2009-12-08 Carol Szabo <carol.szabo@nokia.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-12-08  Carol Szabo  <carol.szabo@nokia.com>
2
3         Reviewed by Darin Adler.
4
5         CSS Counter Nesting still does not work according to the spec.
6         https://bugs.webkit.org/show_bug.cgi?id=31723
7
8         Test: fast/css/counters/nesting.html
9
10         * rendering/RenderCounter.cpp:
11         (WebCore::findPlaceForCounter):
12         Replaced the faulty counter insertion algorithm with one that works.
13
14 2009-12-08  John Sullivan  <sullivan@apple.com>
15
16         Add isAutofilled getter to match existing setter.
17
18         Reviewed by Ada Chan.
19
20         * bindings/objc/DOMHTML.mm:
21         (-[DOMHTMLInputElement _isAutofilled]):
22         Implemented new cover function.
23         
24         * bindings/objc/DOMPrivate.h:
25         Declared new cover function.
26
27 2009-12-08  Dominik Röttsches  <dominik.roettsches@access-company.com>
28
29         Reviewed by Gustavo Noronha Silva.
30
31         [Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
32         https://bugs.webkit.org/show_bug.cgi?id=31469
33
34         Added a TextBreakIterator implementation based on GLib and pango,
35         which allows compiling WebCore without ICU.
36
37         * GNUmakefile.am:
38         * platform/text/gtk/TextBreakIteratorGtk.cpp: Added.
39         (WebCore::):
40         (WebCore::setUpIterator):
41         (WebCore::characterBreakIterator):
42         (WebCore::cursorMovementIterator):
43         (WebCore::wordBreakIterator):
44         (WebCore::lineBreakIterator):
45         (WebCore::sentenceBreakIterator):
46         (WebCore::textBreakFirst):
47         (WebCore::textBreakLast):
48         (WebCore::textBreakNext):
49         (WebCore::textBreakPrevious):
50         (WebCore::textBreakPreceding):
51         (WebCore::textBreakFollowing):
52         (WebCore::textBreakCurrent):
53         (WebCore::isTextBreak):
54
55 2009-12-08  Alexander Pavlov  <apavlov@chromium.org>
56
57         Reviewed by Pavel Feldman.
58
59         Change the way cookies are retrieved in the WebInspector frontend.
60
61         Moved the cookie filtering from the native code into the frontend so that
62         all cookies can be retrieved regardless of the associated domain
63         (required for certain audits to run.)
64         https://bugs.webkit.org/show_bug.cgi?id=32160
65
66         Test: inspector/cookie-resource-match.html
67
68         * inspector/InspectorBackend.cpp:
69         (WebCore::InspectorBackend::getCookies):
70         * inspector/InspectorBackend.h:
71         * inspector/InspectorBackend.idl:
72         * inspector/InspectorController.cpp:
73         (WebCore::InspectorController::getCookies):
74         * inspector/InspectorController.h:
75         * inspector/front-end/CookieItemsView.js:
76         (WebInspector.CookieItemsView.prototype.update.callback):
77         (WebInspector.CookieItemsView.prototype.update):
78         (WebInspector.CookieItemsView.prototype._cookiesForDomain):
79         * inspector/front-end/DOMAgent.js:
80         (WebInspector.Cookies.getCookiesAsync):
81         (WebInspector.Cookies.cookieMatchesResourceURL):
82         (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
83         * inspector/front-end/Resource.js:
84         (WebInspector.Resource):
85         (WebInspector.Resource.prototype.get documentURL):
86         (WebInspector.Resource.prototype.set documentURL):
87         * inspector/front-end/inspector.js:
88         (WebInspector.addResource):
89
90 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
91
92         Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)
93
94         * svg/svgtags.in:
95
96 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
97
98         Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.
99
100         * bindings/scripts/CodeGeneratorJS.pm:
101
102 2009-12-06  Pavel Feldman  <pfeldman@chromium.org>
103
104         Reviewed by Timothy Hatcher.
105
106         Web Inspector: provide custom context menu in the front-end window.
107
108         https://bugs.webkit.org/show_bug.cgi?id=32200
109
110         * English.lproj/localizedStrings.js:
111         * GNUmakefile.am:
112         * WebCore.gypi:
113         * WebCore.pro:
114         * WebCore.vcproj/WebCore.vcproj:
115         * WebCore.xcodeproj/project.pbxproj:
116         * bindings/js/JSInspectorFrontendHostCustom.cpp:
117         (WebCore::JSInspectorFrontendHost::showContextMenu):
118         * inspector/InspectorFrontend.cpp:
119         (WebCore::InspectorFrontend::contextMenuItemSelected):
120         (WebCore::InspectorFrontend::contextMenuCleared):
121         * inspector/InspectorFrontend.h:
122         * inspector/InspectorFrontendHost.cpp:
123         (WebCore::InspectorFrontendHost::InspectorFrontendHost):
124         (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
125         (WebCore::InspectorFrontendHost::showContextMenu):
126         (WebCore::InspectorFrontendHost::contextMenuItemSelected):
127         (WebCore::InspectorFrontendHost::contextMenuCleared):
128         * inspector/InspectorFrontendHost.h:
129         (WebCore::InspectorFrontendHost::MenuSelectionHandler::create):
130         (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler):
131         (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect):
132         (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected):
133         (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared):
134         (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
135         * inspector/InspectorFrontendHost.idl:
136         * inspector/front-end/ContextMenu.js: Added.
137         * inspector/front-end/WebKit.qrc:
138         * inspector/front-end/inspector.html:
139         * inspector/front-end/inspector.js:
140         (WebInspector.loaded):
141         (WebInspector.documentContextMenu):
142         * page/ContextMenuController.cpp:
143         (WebCore::ContextMenuController::ContextMenuController):
144         (WebCore::ContextMenuController::clearContextMenu):
145         (WebCore::ContextMenuController::handleContextMenuEvent):
146         (WebCore::ContextMenuController::showContextMenu):
147         (WebCore::ContextMenuController::createContextMenu):
148         (WebCore::ContextMenuController::contextMenuItemSelected):
149         * page/ContextMenuController.h:
150         * page/ContextMenuSelectionHandler.h: Added.
151         (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler):
152         (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
153         * platform/ContextMenu.cpp:
154         (WebCore::ContextMenu::checkOrEnableIfNeeded):
155         * platform/ContextMenuItem.h:
156
157 2009-12-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
158
159         Rubber-stamped by Kenneth Rohde Christiansen.
160
161         [Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.
162
163         No new tests needed.
164         * WebCore.pro:
165
166 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
167
168         Reviewed by Darin Adler.
169
170         Add a function to show render tree for debugging
171         https://bugs.webkit.org/show_bug.cgi?id=31288
172
173         No new tests because this just adds a function for debugging.
174
175         * rendering/RenderObject.cpp:
176         (WebCore::RenderObject::showRenderObject):
177         (WebCore::RenderObject::showRenderTreeAndMark):
178         (showRenderTree):
179         * rendering/RenderObject.h:
180
181 2009-12-07  Victor Wang  <victorw@chromium.org>
182
183         Reviewed by Dimitri Glazkov.
184
185         Implement NamedPropertyEnumerator and IndexedPropertyEnumerator for
186         V8 NPObject. This should make the object enumerable and fix the
187         enumeration issue in layout test plugins/netscape-enumerate.html.
188
189         Also fix some existing style issues per webkit style guidelines.
190
191         https://bugs.webkit.org/show_bug.cgi?id=32254
192
193         Test: plugins/netscape-enumerate.html
194
195         * bindings/v8/V8NPObject.cpp:
196         (npObjectInvokeImpl):
197         (npObjectInvokeDefaultHandler):
198         (npObjectGetProperty):
199         (npObjectPropertyEnumerator):
200         (npObjectNamedPropertyEnumerator):
201         (npObjectIndexedPropertyEnumerator):
202         (createV8ObjectForNPObject):
203
204 2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>
205
206         Reviewed by Alexey Proskuryakov.
207
208         Fragments now make WebSocket URL parsing fail.
209         https://bugs.webkit.org/show_bug.cgi?id=32144
210
211         * websockets/WebSocket.cpp:
212         (WebCore::WebSocket::connect):
213
214 2009-12-07  Fumitoshi Ukai  <ukai@chromium.org>
215
216         Reviewed by Darin Adler.
217
218         Fix wrong length parsing in WebSocket.
219         https://bugs.webkit.org/show_bug.cgi?id=32203
220
221         * websockets/WebSocketChannel.cpp:
222         (WebCore::WebSocketChannel::didReceiveData):
223
224 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
225
226         Rubber-stamped by Maciej Stachowiak.
227
228         Turn on (SVG) Filters for Qt.
229         https://bugs.webkit.org/show_bug.cgi?id=32224
230
231         * WebCore.pro:
232
233 2009-12-07  Evan Martin  <evan@chromium.org>
234
235         Reviewed by Eric Seidel.
236
237         Chromium: theme scrollbars to match GTK theme.
238         Add functions to RenderThemeChromiumLinux to change the scrollbar
239         color.
240
241         Since the change is to the Chromium WebKit API layer, testing will
242         be in Chromium's test shell.
243         http://bugs.webkit.org/show_bug.cgi?id=32048
244
245         Patch from Markus Gutschke <markus@chromium.org>.
246
247         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
248         (WebCore::saturateAndBrighten):
249         (WebCore::outlineColor):
250         (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
251         (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
252         * rendering/RenderThemeChromiumLinux.cpp:
253         (WebCore::RenderThemeChromiumLinux::setScrollbarColors):
254         * rendering/RenderThemeChromiumLinux.h:
255         (WebCore::RenderThemeChromiumLinux::thumbInactiveColor):
256         (WebCore::RenderThemeChromiumLinux::thumbActiveColor):
257         (WebCore::RenderThemeChromiumLinux::trackColor):
258
259 2009-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
260
261         Reviewed by Xan Lopez.
262
263         [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
264         https://bugs.webkit.org/show_bug.cgi?id=32247
265
266         Allow creating a ResourceResponse from a SoupMessage.
267
268         Covered by API test.
269
270         * platform/network/soup/ResourceResponse.h:
271         (WebCore::ResourceResponse::ResourceResponse):
272         * platform/network/soup/ResourceResponseSoup.cpp:
273         (WebCore::ResourceResponse::updateFromSoupMessage):
274
275 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
276
277         Not reviewed. Reverting problematic patch, causing errors.
278
279         Revert r51789 (Avoid zero division during SVGPaintServerPattern::setup()). Crashes on all Windows slaves.
280         Reopen bug https://bugs.webkit.org/show_bug.cgi?id=29912.
281
282         * svg/graphics/SVGPaintServerPattern.cpp:
283         (WebCore::SVGPaintServerPattern::setup):
284
285 2009-12-07  Kent Tamura  <tkent@chromium.org>
286
287         Reviewed by Darin Adler.
288
289         Add support for HTMLInputElement::stepUp() and stepDown() for
290         type=number and type=range.
291         https://bugs.webkit.org/show_bug.cgi?id=27451
292
293         Our implementation of stepUp() and stepDown() rounds the resultant
294         value to conform to the step value.
295         Change the number-string conversion method for RenderSlider to be
296         consistent with type=number.
297
298         Tests: fast/forms/input-step-number.html
299                fast/forms/input-step-range.html
300                fast/forms/input-step-unsupported.html
301
302         * html/HTMLInputElement.cpp:
303         (WebCore::HTMLInputElement::rangeUnderflow): Unify the code for NUMBER and RANGE.
304         (WebCore::HTMLInputElement::rangeOverflow): Unify the code for NUMBER and RANGE.
305         (WebCore::HTMLInputElement::minimum): Renamed from rangeMinimum(), and support for NUMBER.
306         (WebCore::HTMLInputElement::maximum): Renamed from rangeMaximum(), and support for NUMBER.
307         (WebCore::HTMLInputElement::stepBase):
308         (WebCore::HTMLInputElement::stepMismatch): Use stepBase().
309         (WebCore::HTMLInputElement::applyStepForNumberOrRange):
310         (WebCore::HTMLInputElement::stepUp):
311         (WebCore::HTMLInputElement::stepDown):
312         (WebCore::HTMLInputElement::formStringFromDouble):
313         * html/HTMLInputElement.h:
314         (WebCore::HTMLInputElement::stepUp):
315         (WebCore::HTMLInputElement::stepDown):
316         * html/HTMLInputElement.idl: Add stepUp() and stepDown().
317         * rendering/RenderSlider.cpp:
318         (WebCore::SliderRange::SliderRange): Sync with rangeMinimum()/rangeMaximum() renaming.
319         (WebCore::RenderSlider::updateFromElement): Use formStringFromDouble().
320         (WebCore::RenderSlider::setValueForPosition): Use formStringFromDouble().
321
322 2009-12-07  Albert J. Wong  <ajwong@chromium.org>
323
324         Not reviewed: Chromium build fix try 2 (dumb error).
325
326         * bindings/v8/ScriptValue.h:
327         (WebCore::ScriptValue::getString):
328
329 2009-12-07  Albert J. Wong  <ajwong@chromium.org>
330
331         Not reviewed: Chromium build fix.
332
333         Fix Chromium build break caused by an added dependency from
334         ScriptControllerBase to JSDOMWindowShell, and an API change in
335         ScriptValue.
336
337         * bindings/ScriptControllerBase.cpp:
338         (WebCore::ScriptController::executeIfJavaScriptURL):
339         * bindings/v8/ScriptValue.h:
340         (WebCore::ScriptValue::getString):
341
342 2009-12-07  Enrica Casucci  <enrica@apple.com>
343
344         Reviewed by Darin Adler.
345
346         REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
347         <rdar://problem/7442387>
348         https://bugs.webkit.org/show_bug.cgi?id=32233
349         
350         Fixes problem in re-creating the correct hierarchy under the new block.
351         Added extensive testing to cover all the cases.
352
353         Test: editing/execCommand/indent-with-style2.html
354
355         * editing/CompositeEditCommand.cpp:
356         (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
357
358 2009-12-07  Dmitry Titov  <dimich@chromium.org>
359
360         Rubber-stamped by Darin Adler.
361
362         Remove ENABLE_SHARED_SCRIPT flags
363         https://bugs.webkit.org/show_bug.cgi?id=32245
364         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
365
366         * Configurations/FeatureDefines.xcconfig:
367         * GNUmakefile.am:
368         * WebCore.pro:
369
370 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
371
372         Not reviewed. Force JS binding regeneration, eventually fixing the broken tests on the bots.
373
374         * bindings/scripts/CodeGeneratorJS.pm:
375
376 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
377
378         Not reviewed. Try to fix mac builds by touching svgtags.in - I only tried from-scratch builds.
379
380         * svg/svgtags.in:
381
382 2009-12-07  Gavin Barraclough  <barraclough@apple.com>
383
384         Reviewed by Oliver Hunt.
385
386         https://bugs.webkit.org/show_bug.cgi?id=32184
387         Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
388         Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.
389
390         * bindings/ScriptControllerBase.cpp:
391         (WebCore::ScriptController::executeIfJavaScriptURL):
392         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
393         (WebCore::toHTMLCanvasStyle):
394         (WebCore::JSCanvasRenderingContext2D::setFillColor):
395         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
396         (WebCore::JSCanvasRenderingContext2D::setShadow):
397         * bindings/js/ScriptCallStack.cpp:
398         (WebCore::ScriptCallStack::ScriptCallStack):
399         (WebCore::ScriptCallStack::initialize):
400         * bindings/js/ScriptValue.cpp:
401         (WebCore::ScriptValue::getString):
402         * bindings/js/ScriptValue.h:
403         * bindings/js/SerializedScriptValue.cpp:
404         (WebCore::SerializingTreeWalker::convertIfTerminal):
405         * bindings/objc/WebScriptObject.mm:
406         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
407         * page/Console.cpp:
408         (WebCore::Console::addMessage):
409
410 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
411
412         Reviewed by Holger Hans Peter Freyther.
413
414         Turn on (SVG) Filters support, by default.
415         https://bugs.webkit.org/show_bug.cgi?id=32224
416
417         Only enable filters on mac for now, skipped all affected tests on the other platforms.
418         Will enable them one after another, to minimize breakage.
419
420         * Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.
421
422 2009-12-07  Kent Tamura  <tkent@chromium.org>
423
424         Reviewed by Darin Adler.
425
426         Fix a bug that KURL rejects a host name which has an IPv4 address
427         inside an IPv6 form like [::127.0.0.1].
428         https://bugs.webkit.org/show_bug.cgi?id=29913
429
430         * platform/KURL.cpp:
431         (WebCore::characterClassTable): Add IPv6Char to '.'.
432
433 2009-12-07  Brady Eidson  <beidson@apple.com>
434
435         Reviewed by Sam Weinig.
436
437         <rdar://problem/7443417> - Closing a window opened with "New windows open with: Same Page" results in crash in ::~HistoryItem
438
439         The HistoryItem copy constructor has one very specific use case - to support the feature of a WebView copying another WebView's
440         BackForwardList.  That constructor wasn't initializing its m_document pointer, leading to this crash in the destructor.
441
442         * history/HistoryItem.cpp:
443         (WebCore::HistoryItem::~HistoryItem): Change the setDocument(0) to an ASSERT that the document is already 0. A HistoryItem cannot
444           outlive its Document and Documents will always clear the back-pointer in their ::detach() method.
445         (WebCore::HistoryItem::HistoryItem): Missed the m_document initializer in the copy constructor. Also remove an invalid assertion
446           about the original items m_cachedPage object (which is irrelevant to the copy).
447
448 2009-12-07  Dmitry Titov  <dimich@chromium.org>
449
450         Reviewed by Darin Adler.
451
452         Remove partial SharedScript implementation.
453         https://bugs.webkit.org/show_bug.cgi?id=32237
454         The patch was obtained by running "git revert" command and then un-reverting WebCore/ChangeLog.
455
456         * DerivedSources.make:
457         * SharedScript/SharedScriptContext.cpp: Removed.
458         * SharedScript/SharedScriptContext.h: Removed.
459         * SharedScript/SharedScriptContext.idl: Removed.
460         * SharedScript/SharedScriptController.h: Removed.
461         * SharedScript/WebKitSharedScript.cpp: Removed.
462         * SharedScript/WebKitSharedScript.h: Removed.
463         * SharedScript/WebKitSharedScript.idl: Removed.
464         * SharedScript/WebKitSharedScriptRepository.cpp: Removed.
465         * SharedScript/WebKitSharedScriptRepository.h: Removed.
466         * WebCore.vcproj/WebCore.vcproj:
467         * WebCore.xcodeproj/project.pbxproj:
468         * dom/Document.cpp:
469         (WebCore::Document::detach):
470         * dom/EventTarget.cpp:
471         * dom/EventTarget.h:
472         * dom/ScriptExecutionContext.h:
473
474 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
475
476         Reviewed by Nikolas Zimmermann.
477
478         https://bugs.webkit.org/show_bug.cgi?id=32226
479         Random crashes in WebSocket tests on Leopard Debug builbot
480
481         * platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close):
482         Make sure the object still exists when setting m_state.
483
484 2009-12-07  Shiki Okasaka  <shiki@google.com>
485
486         Reviewed by Dirk Schulze.
487
488         Avoid zero division during SVGPaintServerPattern::setup()
489         https://bugs.webkit.org/show_bug.cgi?id=29912
490
491         Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
492         if the tile of a pattern was bigger than the pattern and the pattern
493         size was < 0.5, and if the attribute overflow was set to visible.
494
495         Test: svg/custom/small-pattern.html
496
497         * svg/graphics/SVGPaintServerPattern.cpp:
498         (WebCore::SVGPaintServerPattern::setup):
499
500 2009-12-07  Kenneth Russell  <kbr@google.com>
501
502         Reviewed by Dimitri Glazkov.
503
504         [v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
505         https://bugs.webkit.org/show_bug.cgi?id=31889
506
507         Fixed bug in handling of zero-argument constructor call.
508
509         Test: fast/canvas/webgl/bug-31889.html
510
511         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
512         (WebCore::CALLBACK_FUNC_DECL):
513
514 2009-12-07  Gyuyoung Kim  <gyuyoung@gmail.com>
515
516         Reviewed by Eric Seidel.
517
518         https://bugs.webkit.org/show_bug.cgi?id=32024
519         [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
520
521         Fix build errors when javascript-debugger is disabled on GTK
522
523         * GNUmakefile.am:
524
525 2009-12-07  Dan Bernstein  <mitz@apple.com>
526
527         Reviewed by Darin Adler.
528
529         Fixed <rdar://problem/7437820> Weird selection artifacts
530
531         Tests: fast/repaint/block-selection-gap-stale-cache-2.html
532                fast/repaint/block-selection-gap-stale-cache.html
533
534         Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
535         time, cache them in each RenderLayer at paint time. This prevents the cache from getting
536         stale due to layout changes and overflow scrolling.
537
538         * rendering/RenderBlock.cpp:
539         (WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
540         (WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.
541         * rendering/RenderLayer.cpp:
542         (WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
543         bounds to include the given rect.
544         (WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
545         selection gaps bounds.
546         (WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
547         selection gaps bounds.
548         * rendering/RenderLayer.h:
549         * rendering/RenderView.cpp:
550         (WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
551         of the view-level cache.
552         (WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().
553         * rendering/RenderView.h:
554
555 2009-12-07  Philippe Normand  <pnormand@igalia.com>
556
557         Reviewed by Gustavo Noronha.
558
559         Fixed whitelist comment and removed useless (tags, sdp) mimetypes
560         from it. Also, GStreamer doesn't handle directly SMIL.
561
562         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
563         (WebCore::mimeTypeCache):
564
565 2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
566
567         Reviewed by Xan Lopez.
568
569         https://bugs.webkit.org/show_bug.cgi?id=25415
570         [GTK][ATK] Please implement support for get_text_at_offset
571
572         Eliminate the segfaults which occur when accessing the text interface now
573         implemented by text controls.
574
575         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
576         (getPangoLayoutForAtk):
577
578 2009-12-07  Gustavo Noronha Silva  <gns@gnome.org>
579
580         Reviewed by Xan Lopez.
581
582         Turn the MediaPlayer supported types blacklist into a whitelist
583
584         [GTK] REGRESSION: webkit thinks it can render PDFs
585         https://bugs.webkit.org/show_bug.cgi?id=32183
586
587         Covered by API test.
588
589         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
590         (WebCore::mimeTypeCache):
591
592 2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
593
594         Reviewed by Xan Lopez.
595
596         https://bugs.webkit.org/show_bug.cgi?id=25524
597         [Gtk] Expose the title attribute to assistive technologies
598
599         Expose 'alt' attribute from images as accessible name.
600         Expose the 'title' core HTML attribute as accessible description.
601         This is a modified version of the original fix submitted by Mario Sanchez Prada,
602         adjusted so that it doesn't impact other platforms.
603
604         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
605         (webkit_accessible_get_name):
606         (webkit_accessible_get_description):
607
608 2009-12-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
609
610         Reviewed by Simon Hausmann.
611
612         [Qt] Fix support for generic font families
613
614         By not propagating the resolved font family in FontCacheQt and
615         only concidering the font description we ended up passing the
616         generic font families to Qt directly. Since most systems don't
617         have a mapping for these font families we ended up using the
618         default font in most cases.
619
620         * platform/graphics/qt/FontCacheQt.cpp:
621         * platform/graphics/qt/FontPlatformData.h:
622         * platform/graphics/qt/FontPlatformDataQt.cpp:
623
624 2009-12-06  Oliver Hunt  <oliver@apple.com>
625
626         Reviewed by Maciej Stachowiak.
627
628         Object.getOwnPropertyDescriptor() allows cross-frame access
629         https://bugs.webkit.org/show_bug.cgi?id=32119
630
631         Make all implementations of getOwnPropertyDescriptor that have
632         cross domain restrictions simply fail immediately on cross domain
633         access, rather than trying to mimic the behaviour of normal
634         property access.
635
636         Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html
637
638         * bindings/js/JSDOMWindowCustom.cpp:
639         (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
640         * bindings/js/JSHistoryCustom.cpp:
641         (WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
642         * bindings/js/JSLocationCustom.cpp:
643         (WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
644         * bindings/scripts/CodeGeneratorJS.pm:
645
646 2009-12-07  Steve Block  <steveblock@google.com>
647
648         Reviewed by Adam Barth.
649
650         Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
651         https://bugs.webkit.org/show_bug.cgi?id=32157
652
653         Build fix only, no new tests.
654
655         * WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
656         * bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
657         * bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
658         * bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
659         * bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
660         * bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
661         * bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
662         * bridge/jni/jsc: Added.
663         * bridge/jni/jsc/jni_utility_private.cpp: Added.
664         (JSC::Bindings::convertArrayInstanceToJavaArray):
665         (JSC::Bindings::convertValueToJValue):
666         * bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
667         * platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.
668
669 2009-12-06  Oliver Hunt  <oliver@apple.com>
670
671         Reviewed by Maciej Stachowiak.
672
673         texImage2D pixel junk for transparency
674         https://bugs.webkit.org/show_bug.cgi?id=32188
675
676         Use kCGBlendModeCopy when drawing an image to the intermediate context
677         used to create a GL texture.
678
679         No test as we don't currently have any mechanism to retrieve pixel data
680         from the webgl context.
681
682         * platform/graphics/mac/GraphicsContext3DMac.cpp:
683         (WebCore::imageToTexture):
684
685 2009-12-03  Philippe Normand  <pnormand@igalia.com>
686
687         Reviewed by Gustavo Noronha.
688
689         Advertize audio/ogg correctly and refactored mime-type cache
690         building.
691
692         [GTK] Recognize oga as audio/ogg
693         https://bugs.webkit.org/show_bug.cgi?id=31990
694
695         Test: media/media-can-play-ogg.html
696
697         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
698         (WebCore::mimeTypeCache):
699
700 2009-12-05  Alexey Proskuryakov  <ap@apple.com>
701
702         Reviewed by Eric Seidel.
703
704         https://bugs.webkit.org/show_bug.cgi?id=32175
705         REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot
706
707         * platform/network/cf/SocketStreamHandleCFNet.cpp:
708         (WebCore::SocketStreamHandle::readStreamCallback): Call platformClose() to unschedule both
709         streams, guaranteeing that there will be no callbacks after SocketStreamHandle is destroyed.
710         (WebCore::SocketStreamHandle::writeStreamCallback): Edited a comment a bit.
711
712 2009-12-05  Adam Langley  <agl@google.com>
713
714         Reviewed by Adam Barth.
715
716         Check that a CSS format() argument is of a valid type.
717
718         https://bugs.webkit.org/show_bug.cgi?id=31815
719         http://code.google.com/p/chromium/issues/detail?id=28582
720
721         Test: fast/css/url-format-non-string.html
722
723         * css/CSSParser.cpp:
724         (WebCore::CSSParser::parseFontFaceSrc):
725
726 2009-12-04  Adam Langley  <agl@google.com>
727
728         Reviewed by Eric Seidel.
729
730         Chromium: make rounded borders heavier.
731
732         Skia draws its rounded corners differently from the other ports.
733         Whereas they have anti-aliased clipping regions, Skia only has 1-bit
734         regions. (Which is technically more correct, but somewhat unhelpful
735         for us.) Instead, with Skia we use a layer and collect all the
736         clipping paths in effect. When the state is popped, we paint
737         transparency outside the clipping paths and merge the layer down.
738
739         This appears to cause rounded borders to look a little thin, which is
740         addressed in this patch.
741
742         This is well covered by existing tests but will require new baselines
743         in the Chromium tree.
744
745         https://bugs.webkit.org/show_bug.cgi?id=31778
746
747         * platform/graphics/skia/GraphicsContextSkia.cpp:
748         (WebCore::GraphicsContext::addInnerRoundedRectClip):
749
750 2009-12-04  Simon Fraser  <simon.fraser@apple.com>
751
752         Reviewed by Dan Bernstein.
753
754         <rdar://problem/7441571> Hardware-backed layers are skipped when printing
755         
756         When printing, set the PaintBehaviorFlattenCompositingLayers flag so that compositing layers
757         paint. This also causes 3D transforms to be flattened to 2D.
758
759         Test: printing/compositing-layer-printing.html
760
761         * page/FrameView.cpp:
762         (WebCore::FrameView::paintContents):
763
764 2009-12-04  Oliver Hunt  <oliver@apple.com>
765
766         Reviewed by Beth Dakin.
767
768         Fix up some issues in my SVGListTraits change from yesterday.
769
770         * svg/SVGListTraits.h:
771         (WebCore::):
772
773 2009-12-04  Albert J. Wong  <ajwong@chromium.org>
774
775         Not reviewed: chromium build fix.
776
777         Fix Chromium build break caused by moving of isDefaultPortForProtocol() and
778         portAllowed() into KURL.h/KURL.cpp.  Cloning code.
779
780         * platform/KURLGoogle.cpp:
781         (WebCore::isDefaultPortForProtocol):
782         (WebCore::portAllowed):
783
784 2009-12-04  Pavel Feldman  <pfeldman@chromium.org>
785
786         Reviewed by Timothy Hatcher.
787
788         Web Inspector: Remove suppress highlight when restoring selected node.
789
790         https://bugs.webkit.org/show_bug.cgi?id=32152
791
792         * inspector/front-end/ElementsPanel.js:
793         (WebInspector.ElementsPanel.prototype.setDocument.selectNode):
794         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
795         (WebInspector.ElementsPanel.prototype.setDocument):
796
797 2009-12-04  Dirk Schulze  <krit@webkit.org>
798
799         Reviewed by Nikolas Zimmermann.
800
801         Gradient SVG animation demonstrates tearing at animation extremes
802         https://bugs.webkit.org/show_bug.cgi?id=11929
803
804         The focalPoint of a radial gradient is temporarly substracted by
805         the centralPoint, if the focalPoint is not in the radius of the
806         gradient. This is needed to calculate a new postion of the focalPoint
807         according to the specification. But the new focalPoint needs to be
808         moved by the centralPoint after this calculation, which is not the case
809         at the moment. This patch fixes this issue. It was also introduced a
810         deviation of maximal 0.2% for Cairo to get around the fixed point numbers
811         in Cairo.
812
813         W3C-SVG-1.1/pservers-grad-13-b needed an update. The missing adjustment
814         of the new focalPoint caused wrong results for the last three tests.
815
816         Test: svg/custom/radial-gradient-with-outstanding-focalPoint.svg
817
818         * svg/SVGRadialGradientElement.cpp:
819         (WebCore::SVGRadialGradientElement::buildGradient):
820
821 2009-12-04  Anton Muhin  <antonm@chromium.org>
822
823         Reviewed by Dmitry Titov.
824
825         Do not use WebCore::String::String(const UChar*, int length) to convert
826         short v8 strings.
827
828         Plus added string traits.
829         https://bugs.webkit.org/show_bug.cgi?id=31415
830
831         * bindings/v8/V8Binding.cpp:
832         (WebCore::):
833         (WebCore::v8StringToWebCoreString):
834
835 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
836
837         Reviewed by Darin Adler.
838
839         REGRESSION: AX: buttons now extremely repetitive
840         https://bugs.webkit.org/show_bug.cgi?id=32164
841
842         Test: platform/mac/accessibility/button-shouldnot-have-axvalue.html
843
844         * accessibility/AccessibilityObject.h:
845         (WebCore::AccessibilityObject::isButton):
846         * accessibility/mac/AccessibilityObjectWrapper.mm:
847         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
848
849 2009-12-04  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
850
851         Reviewed by Darin Adler.
852
853         Check whether the right side of a string append is non-empty
854         https://bugs.webkit.org/show_bug.cgi?id=32151
855
856         Especially beneficial for CachedScript::script() method
857         which usually appends an empty string returned by flush()
858         to its m_script member. m_script is often hundreds of kbytes
859         which is duplated without reason.
860
861         * platform/text/String.cpp:
862         (WebCore::String::append):
863
864 2009-12-04  Enrica Casucci  <enrica@apple.com>
865
866         Reviewed by John Sullivan.
867
868         Mail.app crashes when indenting table pasted from Numbers.app.
869         <rdar://problem/7209507>
870         https://bugs.webkit.org/show_bug.cgi?id=32166
871
872         Test: LayoutTests/editing/execCommand/indent-partial-table.html
873         
874         * editing/IndentOutdentCommand.cpp:
875         (WebCore::IndentOutdentCommand::indentRegion): Added test to verify that the end of the paragraph
876         after the selection has not been moved.
877
878 2009-12-04  Alexey Proskuryakov  <ap@apple.com>
879
880         Reviewed by Darin Adler.
881
882         https://bugs.webkit.org/show_bug.cgi?id=32085
883         WebSocket should block the same ports that are blocked for resource loading
884
885         Test: websocket/tests/url-parsing.html
886
887         * page/SecurityOrigin.cpp:
888         (WebCore::SecurityOrigin::SecurityOrigin):
889         (WebCore::SecurityOrigin::localURLSchemes):
890         * page/SecurityOrigin.h:
891         Move isDefaultPortForProtocol() to KURL, because that's a better place for it (SecurityOrigin
892         is not even in WebCore/platform directory).
893
894         * html/HTMLAnchorElement.cpp:
895         (WebCore::HTMLAnchorElement::host):
896         (WebCore::HTMLAnchorElement::setHost):
897         (WebCore::HTMLAnchorElement::setPort):
898         Updated for the new location of isDefaultPortForProtocol().
899
900         * platform/KURL.cpp:
901         (WebCore::KURL::protocolIs): In an assertion, compare to "javascript" case-insensitively,
902         since the function doesn't require lower case input.
903         (WebCore::isDefaultPortForProtocol): Moved from SecurityOrigin.
904         (WebCore::portAllowed): Moved from ResourceHandle.
905         * platform/KURL.h:
906
907         * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): Updated for the
908         new location of portAllowed().
909
910         * websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Per the spec, raise a SECURITY_ERR
911         if trying to connect to a blocked port.
912
913 2009-12-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
914
915         Reviewed by Kenneth Rohde Christiansen.
916
917         [Qt] WebKit crashes when loading certain SVG images
918         https://bugs.webkit.org/show_bug.cgi?id=29443
919
920         Remove FontFallbackListQt and rely on the common FontFallbackList
921         to handle the fonts. FontCache and FontPlatformData have been
922         updated to work with the common FontFallbackList.
923
924         In the previous implementation, FontPlatformDataCacheKey
925         was a clone of FontPlatformData with the hashing
926         capabilities added in order to use it as a key in the cache's
927         hashmap. FontPlatformData has been modified to handle the hashing
928         function directly so the data are not copied twice in memory.
929
930         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
931         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
932         The behavior is similar except currFamily->family().length() was
933         not tested and the fallback fonts selector were not used.
934
935         Existing tests cover the change.
936
937         * WebCore.pro:
938         * platform/graphics/qt/FontCacheQt.cpp:
939         (WebCore::FontCache::platformInit):
940         (WebCore::FontCache::getFontDataForCharacters):
941         (WebCore::FontCache::getSimilarFontPlatformData):
942         (WebCore::FontCache::getLastResortFallbackFont):
943         (WebCore::FontCache::getTraitsInFamily):
944         (WebCore::FontCache::createFontPlatformData):
945         * platform/graphics/qt/FontCustomPlatformData.cpp:
946         (WebCore::FontCustomPlatformData::fontPlatformData):
947         * platform/graphics/qt/FontFallbackListQt.cpp:
948         Removed. We now use the implementation from FontFallbackList.cpp
949         * platform/graphics/qt/FontPlatformData.h:
950         Add hashing capabilities to be able to use the data with the FontCache.
951         This was previously done in FontCacheQt.cpp
952         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
953         (WebCore::FontPlatformData::FontPlatformData):
954         (WebCore::FontPlatformData::isHashTableDeletedValue):
955         (WebCore::FontPlatformData::font):
956         (WebCore::FontPlatformData::size):
957         (WebCore::FontPlatformData::family):
958         (WebCore::FontPlatformData::bold):
959         (WebCore::FontPlatformData::italic):
960         (WebCore::FontPlatformData::smallCaps):
961         (WebCore::FontPlatformData::pixelSize):
962         * platform/graphics/qt/FontPlatformDataQt.cpp:
963         (WebCore::FontPlatformData::FontPlatformData):
964         (WebCore::FontPlatformData::~FontPlatformData):
965         (WebCore::FontPlatformData::operator=):
966         (WebCore::FontPlatformData::operator==):
967         (WebCore::FontPlatformData::hash):
968
969 2009-12-04  Adam Treat  <atreat@rim.com>
970
971         Reviewed by Dan Bernstein.
972
973         Fix wrong assert that was only working through sheer luck.
974         https://bugs.webkit.org/show_bug.cgi?id=32162
975
976         * platform/text/BidiContext.cpp:
977         (WebCore::BidiContext::create):
978
979 2009-12-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
980
981         Reviewed by Simon Hausmann.
982
983         [Qt] Allow removing 'qrc' as a local security origin scheme
984
985         * page/SecurityOrigin.cpp:
986
987 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
988
989         Reviewed by Eric Seidel.
990
991         Allow custom memory allocation control for WebCore's CollectionCache
992         https://bugs.webkit.org/show_bug.cgi?id=32109
993
994         Inherits the following class from FastAllocBase because it is
995         instantiated by 'new':
996
997         struct name            - instantiated at: WebCore/'location'
998
999         struct CollectionCache - dom/Document.cpp:4029
1000
1001         * html/CollectionCache.h:
1002
1003 2009-12-04  Steve Block  <steveblock@google.com>
1004
1005         Reviewed by Darin Adler.
1006
1007         Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks. 
1008         https://bugs.webkit.org/show_bug.cgi?id=32111
1009
1010         In Geolocation::GeoNotifier::timerFired, a JS callback may be invoked if a
1011         fatal error was registered on this GeoNotifier or if this request has timed
1012         out. If the request is a watch, and is cleared by a call to clearWatch in the
1013         callback, the GeoNotifier object will be destroyed. We must therefore cache the
1014         m_geolocation member to allow us to call Geolocation::fatalErrorOccurred or
1015         Geolocation::requestTimedOut.
1016
1017         Tests: fast/dom/Geolocation/permission-denied-already-clear-watch.html
1018                fast/dom/Geolocation/timeout-clear-watch.html
1019
1020         * page/Geolocation.cpp: Modified.
1021         (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Cache the m_geolocation member before invoking the JS callback.
1022
1023 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
1024
1025         Reviewed by Eric Seidel.
1026
1027         Allow custom memory allocation control for 2 classes of the platform directory in WebCore
1028         https://bugs.webkit.org/show_bug.cgi?id=
1029
1030         Inherits the following class from Noncopyable because it is instantiated
1031         by 'new' and no need to be copyable:
1032
1033         class/struct name         - instantiated at: WebCore/'location'
1034
1035         class SharedTimer         - (its child class) workers/WorkerRunLoop.cpp:91
1036
1037         Inherits the following class from FastAllocBase because it is
1038         instantiated by 'new':
1039
1040         class TransformOperations - rendering/style/RenderStyle.h:1175
1041
1042         Noncopyable.h's include added to SharedTimer.h.
1043
1044         * platform/SharedTimer.h:
1045         * platform/graphics/transforms/TransformOperations.h:
1046
1047 2009-12-04  Xan Lopez  <xlopez@igalia.com>
1048
1049         Reviewed by Gustavo Noronha.
1050
1051         [GTK]Enable DNS prefetching
1052         https://bugs.webkit.org/show_bug.cgi?id=23846
1053
1054         Enable DNS prefetching.
1055
1056         Based on a patch by José Millán.
1057
1058         * platform/network/soup/DNSSoup.cpp:
1059         (WebCore::prefetchDNS):
1060
1061 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
1062
1063         Reviewed by Eric Seidel.
1064
1065         Allow custom memory allocation control for the svg directory in WebCore
1066         https://bugs.webkit.org/show_bug.cgi?id=
1067
1068         Inherits the following classes from Noncopyable because these are instantiated
1069         by 'new' and no need to be copyable:
1070
1071         class/struct name           - instantiated at: WebCore/'location'
1072
1073         struct ResourceSet          - svg/graphics/SVGResource.cpp:148
1074         class SVGFontData           - css/CSSFontFaceSource.cpp:156
1075         class SVGDocumentExtensions - dom/Document.cpp:3962
1076         class SVGViewSpec           - svg/SVGSVGElement.cpp:191
1077
1078         * svg/SVGDocumentExtensions.h:
1079         * svg/SVGFontData.h:
1080         * svg/SVGViewSpec.h:
1081         * svg/graphics/SVGResource.cpp:
1082
1083 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1084
1085         Reviewed by Beth Dakin.
1086
1087         WAI-ARIA: aria-activedescendant doesn't work as intended
1088         https://bugs.webkit.org/show_bug.cgi?id=32100
1089
1090         Fixes a number of issues regarding the "tree" role and aria-activedescendant.
1091         1. The indexes were being reported incorrectly by treeitems.
1092         2. aria-activedescendant changes were not being sent to the containing item.
1093         3. The tree's selected rows need to consult aria-activedescendant.
1094         4. Since a tree changes what it returns as its children (it returns its rows)
1095            the mac-specific array indexing methods need to correctly handle the tree case.
1096
1097         Tests: platform/mac/accessibility/aria-tree-activedescendant.html
1098                platform/mac/accessibility/aria-tree-index-of-items.html
1099
1100         * accessibility/AXObjectCache.h:
1101         (WebCore::AXObjectCache::):
1102         * accessibility/AccessibilityRenderObject.cpp:
1103         (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
1104         (WebCore::AccessibilityRenderObject::activeDescendant):
1105         (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
1106         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1107         * accessibility/mac/AXObjectCacheMac.mm:
1108         (WebCore::AXObjectCache::postPlatformNotification):
1109         * accessibility/mac/AccessibilityObjectWrapper.mm:
1110         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1111         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1112         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1113         * accessibility/win/AXObjectCacheWin.cpp:
1114         (WebCore::AXObjectCache::postPlatformNotification):
1115
1116 2009-12-03  Zoltan Horvath  <zoltan@webkit.org>
1117
1118         Reviewed by Eric Seidel.
1119
1120         Allow custom memory allocation control for the xml directory in WebCore
1121         https://bugs.webkit.org/show_bug.cgi?id=
1122
1123         Inherits the following class from Noncopyable because it is instantiated 
1124         by 'new' and no need to be copyable:
1125
1126         class/struct name               - instantiated at: WebCore/'location'
1127
1128         struct XMLHttpRequestStaticData - xml/XMLHttpRequest.cpp:134
1129
1130         Inherits the following classes from FastAllocBase because these are instantiated by 'new':
1131
1132         class NodeTest                  - xml/XPathGrammar.y:258
1133         class NodeSet                   - xml/XPathValue.cpp:52
1134         struct EvaluationContext        - xml/XPathExpressionNode.cpp:40
1135
1136         * xml/XMLHttpRequest.cpp:
1137         * xml/XPathExpressionNode.h:
1138         * xml/XPathNodeSet.h:
1139         * xml/XPathStep.h:
1140
1141 2009-12-03  Drew Wilson  <atwilson@chromium.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         New History changes do not compile for Chromium/V8
1146         https://bugs.webkit.org/show_bug.cgi?id=32148
1147
1148         Existing tests suffice (just trying to get code to compile).
1149
1150         * WebCore.gypi:
1151         Added V8HistoryCustom.cpp and other missing files.
1152         * bindings/v8/custom/V8CustomBinding.h:
1153         Added custom handlers for History.pushState()/replaceState().
1154         * bindings/v8/custom/V8HistoryCustom.cpp: Added.
1155         Added custom handlers for History.pushState()/replaceState().
1156         * history/BackForwardListChromium.cpp:
1157         (WebCore::BackForwardList::pushStateItem):
1158         Stubbed out this routine for now - will implement in the future.
1159
1160 2009-12-03  Adam Barth  <abarth@webkit.org>
1161
1162         Reviewed by Eric Seidel.
1163
1164         OwnPtr<XBLBindingManager> Document::m_bindingManager;
1165         https://bugs.webkit.org/show_bug.cgi?id=32147
1166
1167         The document actually owns the bindingManager.  That's what the code
1168         should say.
1169
1170         * dom/Document.cpp:
1171         (WebCore::Document::~Document):
1172         * dom/Document.h:
1173         (WebCore::Document::bindingManager):
1174
1175 2009-12-03  Adam Barth  <abarth@webkit.org>
1176
1177         Reviewed by Eric Seidel.
1178
1179         OwnPtr<Tokenizer> Document::m_tokenizer;
1180         https://bugs.webkit.org/show_bug.cgi?id=32145
1181
1182         The document actually owns the tokenizer.  That's what the code should say.
1183
1184         * dom/Document.cpp:
1185         (WebCore::Document::removedLastRef):
1186         (WebCore::Document::~Document):
1187         (WebCore::Document::cancelParsing):
1188         (WebCore::Document::implicitOpen):
1189         (WebCore::Document::implicitClose):
1190         * dom/Document.h:
1191         (WebCore::Document::tokenizer):
1192
1193 2009-12-03  Adam Barth  <abarth@webkit.org>
1194
1195         Reviewed by Eric Seidel.
1196
1197         OwnPtr<RenderArena> Document::m_renderArena;
1198         https://bugs.webkit.org/show_bug.cgi?id=32146
1199
1200         The document owns the renderArena.  That's what the code should say.
1201
1202         * dom/Document.cpp:
1203         (WebCore::Document::Document): Also, removed a redundant initialization
1204         of the tokenizer that I missed in my previous patch.
1205         (WebCore::Document::~Document):
1206         (WebCore::Document::attach):
1207         (WebCore::Document::detach):
1208         * dom/Document.h:
1209         (WebCore::Document::renderArena):
1210
1211 2009-12-03  Drew Wilson  <atwilson@chromium.org>
1212
1213         Rolling back r51633 because it causes a chromium perf regression.
1214
1215         * platform/graphics/SimpleFontData.h:
1216         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
1217
1218 2009-12-03  Adam Barth  <abarth@webkit.org>
1219
1220         Reviewed by Eric Seidel.
1221
1222         The code should say that Document owns DocLoader
1223         https://bugs.webkit.org/show_bug.cgi?id=32143
1224
1225         It's the truth.
1226
1227         * dom/Document.cpp:
1228         (WebCore::Document::~Document):
1229         * dom/Document.h:
1230         (WebCore::Document::docLoader):
1231
1232 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1233
1234         Reviewed by Eric Seidel.
1235
1236         AX: VO just says "term" on many web sites
1237         https://bugs.webkit.org/show_bug.cgi?id=32139
1238
1239         Test: platform/mac/accessibility/definition-list-term.html
1240
1241         * accessibility/AccessibilityRenderObject.cpp:
1242         (WebCore::AccessibilityRenderObject::accessibilityDescription):
1243         * accessibility/mac/AccessibilityObjectWrapper.mm:
1244         (-[AccessibilityObjectWrapper subrole]):
1245         (-[AccessibilityObjectWrapper roleDescription]):
1246
1247 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1248
1249         Reviewed by Beth Dakin.
1250
1251         Implement WAI-ARIA scrollbar role and related property aria-orientation
1252         https://bugs.webkit.org/show_bug.cgi?id=32126
1253
1254         Test: accessibility/aria-scrollbar-role.html
1255
1256         * accessibility/AccessibilityObject.cpp:
1257         (WebCore::createARIARoleMap):
1258         * accessibility/AccessibilityObject.h:
1259         (WebCore::AccessibilityObject::isScrollbar):
1260         * accessibility/AccessibilityRenderObject.cpp:
1261         (WebCore::AccessibilityRenderObject::valueForRange):
1262         (WebCore::AccessibilityRenderObject::orientation):
1263         (WebCore::AccessibilityRenderObject::canHaveChildren):
1264         * accessibility/AccessibilityRenderObject.h:
1265         * accessibility/mac/AccessibilityObjectWrapper.mm:
1266         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1267         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1268         * html/HTMLAttributeNames.in:
1269
1270 2009-12-03  Dan Bernstein  <mitz@apple.com>
1271
1272         Reviewed by Darin Adler.
1273
1274         Fixed <rdar://problem/7401617> Selection painting issue in hardware-
1275         accelerated layers
1276         which is another part of https://bugs.webkit.org/show_bug.cgi?id=23628
1277         Fix selection painting to do container-relative repaints
1278
1279         Test: fast/repaint/block-selection-gap-in-composited-layer.html
1280
1281         * rendering/RenderBlock.cpp:
1282         (WebCore::RenderBlock::selectionGapRectsForRepaint): Compute and paint
1283         gap rects in the coordinate space of the repaint container.
1284         * rendering/RenderLayerCompositor.cpp:
1285         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Added a
1286         FIXME.
1287         * rendering/RenderView.cpp:
1288         (WebCore::RenderView::setSelection): Map block selection gap rects from
1289         the repaint container’s coordinate space to the view’s coordinate space
1290         before adding them to the cached selection bounds.
1291         (WebCore::RenderView::clearSelection): Changed to use
1292         repaintRectangleInViewAndCompositedLayers() so that the selection rect
1293         is invalidated in composited layers as well.
1294
1295 2009-12-03  Jonathan Dixon  <joth@chromium.org>
1296
1297         Reviewed by Dimitri Glazkov.
1298
1299         Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
1300         https://bugs.webkit.org/show_bug.cgi?id=32066
1301
1302         Adds geolocationEnabled in Settings for runtime control of geolocaiton features. This defaults to ON
1303         as it is intended as a development and testing aid, not a user control. To completely remove geolocation
1304         from a given port, the compile time ENABLE_GEOLOCATION should still be used.
1305         Adding placeholder GeolocationServiceChromium implementation, as this is required to allows
1306         ENABLE_GEOLOCATION to be defined (in turn required for testing), even though this patch does not
1307         make that the default just yet.
1308
1309         * WebCore.gypi:
1310         * page/Settings.cpp:
1311         (WebCore::Settings::Settings): Add new m_geolocationEnabled flag default value
1312         (WebCore::Settings::setGeolocationEnabled): Setter for  m_geolocationEnabled flag
1313         * page/Settings.h:
1314         (WebCore::Settings::geolocationEnabled):  Add m_geolocationEnabled flag
1315         * platform/chromium/GeolocationServiceChromium.cpp: Added.
1316         (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): Place holder GeolocationServiceChromium)
1317         (WebCore::createGeolocationService): factory function, only required when ENABLED(GEOLOCATION) is true
1318
1319 2009-12-03  Enrica Casucci  <enrica@apple.com>
1320
1321         Reviewed by John Sullivan.
1322
1323         SpinTracer: 349 spins in Mail at WebCore::Editor::advanceToNextMisspelling(bool)
1324         <rdar://problem/7198592>
1325         https://bugs.webkit.org/show_bug.cgi?id=32129
1326
1327         Fixed the way the next paragraph is calculated.
1328         I've added a repro case in Safari and attached it to the Bugzilla bug.
1329
1330         * editing/Editor.cpp:
1331         (WebCore::findFirstMisspellingOrBadGrammarInRange): Changed the way we move to the
1332         next paragraph in the loop.
1333
1334 2009-12-03  Oliver Hunt  <oliver@apple.com>
1335
1336         Build fix
1337
1338         * svg/SVGListTraits.h:
1339         (WebCore::):
1340
1341 2009-12-03  Oliver Hunt  <oliver@apple.com>
1342
1343         Build fix
1344
1345         * svg/SVGListTraits.h:
1346         (WebCore::):
1347
1348 2009-12-03  Brady Eidson  <beidson@apple.com>
1349
1350         No wonder editing WebCore.exp repeatedly while I worked on this patch never seemed to stick.
1351
1352         Long live our auto-generated overlords that I didn't know about...  
1353
1354         * WebCore.base.exp:
1355
1356 2009-12-03  Oliver Hunt  <oliver@apple.com>
1357
1358         Reviewed by Dan Bernstein.
1359
1360         REGRESSION (r51627): 3 SVG tests are failing
1361         https://bugs.webkit.org/show_bug.cgi?id=32117
1362
1363         Null checking Items in the SVGList is insufficient as items may
1364         be floats, etc so add SVGListTraits::isNull and add appropriate
1365         specializations.
1366
1367         Test: svg/dom/svglist-exception-on-out-bounds-error.html
1368
1369         * svg/SVGList.h:
1370         (WebCore::SVGListTypeOperations::isNull):
1371         (WebCore::SVGList::initialize):
1372         (WebCore::SVGList::insertItemBefore):
1373         (WebCore::SVGList::replaceItem):
1374         (WebCore::SVGList::appendItem):
1375         * svg/SVGListTraits.h:
1376         (WebCore::):
1377
1378 2009-12-03  Brady Eidson  <beidson@apple.com>
1379
1380         No review - release build fix.
1381
1382         * history/HistoryItem.cpp:
1383         (WebCore::HistoryItem::documentDetached):
1384
1385 2009-12-03  Brady Eidson  <beidson@apple.com>
1386
1387         No review - release build fix.
1388
1389         * loader/HistoryController.cpp:
1390         (WebCore::HistoryController::pushState):
1391
1392 2009-12-03  Enrica Casucci  <enrica@apple.com>
1393
1394         Reviewed by Adele Peterson.
1395
1396         Multiple Undos removes the last posted comment and/or the ones before it.
1397         <rdar://problem/6557066>
1398         https://bugs.webkit.org/show_bug.cgi?id=32079
1399         
1400         The fix consists in preventing Undos and Redos to be applied to elements that
1401         are no longer editable. We do not attempt to remove the commands from the queue.
1402         It is a relatively simple fix that comes with a little extra overhead for the apply
1403         and unapply methods where we are now performing the editability check.
1404
1405         Test: editing/undo/undo-indent-noneditable.html
1406
1407         * editing/AppendNodeCommand.cpp:
1408         (WebCore::AppendNodeCommand::doApply):
1409         (WebCore::AppendNodeCommand::doUnapply):
1410         * editing/DeleteFromTextNodeCommand.cpp:
1411         (WebCore::DeleteFromTextNodeCommand::doApply):
1412         (WebCore::DeleteFromTextNodeCommand::doUnapply):
1413         * editing/InsertIntoTextNodeCommand.cpp:
1414         (WebCore::InsertIntoTextNodeCommand::doApply):
1415         (WebCore::InsertIntoTextNodeCommand::doUnapply):
1416         * editing/InsertNodeBeforeCommand.cpp:
1417         (WebCore::InsertNodeBeforeCommand::doApply):
1418         (WebCore::InsertNodeBeforeCommand::doUnapply):
1419         * editing/JoinTextNodesCommand.cpp:
1420         (WebCore::JoinTextNodesCommand::doApply):
1421         (WebCore::JoinTextNodesCommand::doUnapply):
1422         * editing/MergeIdenticalElementsCommand.cpp:
1423         (WebCore::MergeIdenticalElementsCommand::doApply):
1424         (WebCore::MergeIdenticalElementsCommand::doUnapply):
1425         * editing/RemoveNodeCommand.cpp:
1426         (WebCore::RemoveNodeCommand::doApply):
1427         (WebCore::RemoveNodeCommand::doUnapply):
1428         * editing/SplitElementCommand.cpp:
1429         (WebCore::SplitElementCommand::executeApply):
1430         (WebCore::SplitElementCommand::doUnapply):
1431         * editing/SplitTextNodeCommand.cpp:
1432         (WebCore::SplitTextNodeCommand::doApply):
1433         (WebCore::SplitTextNodeCommand::doUnapply):
1434         * editing/WrapContentsInDummySpanCommand.cpp:
1435         (WebCore::WrapContentsInDummySpanCommand::doUnapply):
1436         (WebCore::WrapContentsInDummySpanCommand::doReapply):
1437
1438 2009-12-03  Brady Eidson  <beidson@apple.com>
1439
1440         Reviewed by Sam Weinig.
1441
1442         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
1443
1444         Tests: fast/loader/stateobjects/document-destroyed-navigate-back.html
1445                fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
1446                fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
1447                fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
1448                fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
1449                fast/loader/stateobjects/pushstate-object-types.html
1450                fast/loader/stateobjects/pushstate-then-replacestate.html
1451                fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
1452                fast/loader/stateobjects/replacestate-then-pushstate.html
1453                http/tests/loading/state-object-security-exception.html
1454
1455         Derived sources and project file changes:
1456         * DerivedSources.cpp:
1457         * DerivedSources.make:
1458         * GNUmakefile.am
1459         * WebCore.pro
1460         * WebCore.vcproj/WebCore.vcproj:
1461         * WebCore.xcodeproj/project.pbxproj:
1462
1463         Add the new PopStateEvent:
1464         * dom/PopStateEvent.cpp: Added.
1465         (WebCore::PopStateEvent::PopStateEvent):
1466         (WebCore::PopStateEvent::initPopStateEvent):
1467         * dom/PopStateEvent.h: Added.
1468         (WebCore::PopStateEvent::create):
1469         (WebCore::PopStateEvent::isPopStateEvent):
1470         (WebCore::PopStateEvent::state):
1471         * dom/PopStateEvent.idl: Added.
1472         * bindings/js/JSPopStateEventCustom.cpp: Added.
1473         (WebCore::JSPopStateEvent::initPopStateEvent):
1474         (WebCore::JSPopStateEvent::state):
1475         * bindings/js/JSEventCustom.cpp:
1476         (WebCore::toJS):
1477         * dom/Event.cpp:
1478         (WebCore::Event::isPopStateEvent):
1479         * dom/Event.h:
1480         * dom/EventNames.h:
1481
1482         Add the "onpopstate" attribute:
1483         * html/HTMLAttributeNames.in:
1484         * html/HTMLBodyElement.cpp:
1485         (WebCore::HTMLBodyElement::parseMappedAttribute):
1486         * html/HTMLBodyElement.idl:
1487         * html/HTMLFrameSetElement.cpp:
1488         (WebCore::HTMLFrameSetElement::parseMappedAttribute):
1489         * html/HTMLFrameSetElement.h:
1490         * html/HTMLFrameSetElement.idl:
1491         * page/DOMWindow.h:
1492         * page/DOMWindow.idl:
1493
1494         Add pushState and replaceState management to the loader and history machinery:
1495         * bindings/js/JSHistoryCustom.cpp:
1496         (WebCore::JSHistory::pushState):
1497         (WebCore::JSHistory::replaceState):
1498         * loader/HistoryController.cpp:
1499         (WebCore::HistoryController::updateForSameDocumentNavigation): Augmented from "scrollToAnchor()", combining
1500           both the same-document fragment scroll case with the new same-document state object activation case.
1501         (WebCore::HistoryController::pushState):
1502         (WebCore::HistoryController::replaceState):
1503         * loader/HistoryController.h:
1504         * history/BackForwardList.cpp:
1505         (WebCore::BackForwardList::addItem): Use insertItemAfterCurrent.
1506         (WebCore::BackForwardList::insertItemAfterCurrent): Optionally insert the item without clearing the forward
1507           list, as pushStateItem might've selectively cleared only certain items, with the bulk of the forward list
1508           meant to remain.
1509         (WebCore::BackForwardList::pushStateItem): Clear the forward list *only* for the state item's document, then 
1510           insert the new item.
1511         (WebCore::BackForwardList::removeItem):
1512         * history/BackForwardList.h:
1513         * page/History.cpp:
1514         (WebCore::History::urlForState):
1515         (WebCore::History::stateObjectAdded):
1516         * page/History.h:
1517         * page/History.idl:
1518
1519         Let HistoryItems and Documents associate with each other, as well as letting HistoryItems contain state objects:
1520         * history/HistoryItem.cpp:
1521         (WebCore::HistoryItem::HistoryItem):
1522         (WebCore::HistoryItem::~HistoryItem):
1523         (WebCore::HistoryItem::setStateObject):
1524         (WebCore::HistoryItem::setDocument):
1525         (WebCore::HistoryItem::documentDetached):
1526         * history/HistoryItem.h:
1527         (WebCore::HistoryItem::stateObject):
1528         (WebCore::HistoryItem::document):
1529         * dom/Document.cpp:
1530         (WebCore::Document::detach): Notify all back/forward history items owned by this Document that it
1531           is going away.
1532         (WebCore::Document::registerHistoryItem): Manage the list of back/forward history items this document owns.
1533         (WebCore::Document::unregisterHistoryItem): Ditto.
1534         * dom/Document.h:
1535
1536         Add the ability for Documents, DocumentLoaders, and FrameLoaderClients to be notified when a Documents
1537         URL changes as the result of pushState(), replaceState(), or a popstate navigation:
1538         * dom/Document.cpp:
1539         (WebCore::Document::implicitClose): If there's a pending state object, dispatch the popstate event.
1540         (WebCore::Document::updateURLForPushOrReplaceState):
1541         (WebCore::Document::statePopped): If loading is complete, dispatch the popstate event. Otherwise, set 
1542           the pending state object.
1543         * loader/DocumentLoader.cpp:
1544         (WebCore::DocumentLoader::replaceRequestURLForSameDocumentNavigation):
1545         * loader/DocumentLoader.h:
1546         * loader/FrameLoaderClient.h:
1547         * loader/EmptyClients.h:
1548         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeStateObjectForPageForFrame):
1549
1550         Change handling of "loading a HistoryItem" to distinguish between new-Document navigations and same-Document
1551         navigations, combining the old concept of anchor scrolls with the new concept of state object navigations:
1552         * loader/FrameLoader.cpp:
1553         (WebCore::FrameLoader::loadInSameDocument):
1554         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1555         (WebCore::FrameLoader::navigateWithinDocument):
1556         (WebCore::FrameLoader::navigateToDifferentDocument):
1557         (WebCore::FrameLoader::loadItem):
1558         * loader/FrameLoader.h:
1559         * page/Page.cpp:
1560         (WebCore::Page::goToItem): Changed to allow state object activations to pass through without the load stopping.
1561
1562 2009-12-03  Pavel Feldman  <pfeldman@chromium.org>
1563
1564         Not reviewed: chromium build fix.
1565         r51621 changed JS bindings only, broke v8's.
1566
1567         * bindings/v8/ScriptFunctionCall.cpp:
1568         (WebCore::ScriptFunctionCall::appendArgument):
1569         * bindings/v8/ScriptFunctionCall.h:
1570
1571 2009-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
1572
1573         Reviewed by Adam Barth.
1574
1575         [V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
1576         https://bugs.webkit.org/show_bug.cgi?id=32094
1577
1578         Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html
1579
1580         * bindings/v8/DOMObjectsInclude.h:
1581         * bindings/v8/V8DOMWrapper.cpp:
1582         (WebCore::V8DOMWrapper::getTemplate):
1583         (WebCore::V8DOMWrapper::convertToV8Object):
1584         (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
1585         * bindings/v8/V8DOMWrapper.h:
1586         * bindings/v8/V8GCController.cpp:
1587         (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
1588         * bindings/v8/custom/V8CustomBinding.h:
1589
1590 2009-12-03  Pavel Feldman  <pfeldman@chromium.org>
1591
1592         Reviewed by Timothy Hatcher.
1593
1594         Chromium: Add support for settings containing ":"
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=32118
1597
1598         * inspector/front-end/WatchExpressionsSidebarPane.js:
1599         (WebInspector.WatchExpressionsSection):
1600
1601 2009-12-03  Rafael Antognolli  <antognolli@profusion.mobi>, Kenneth Christiansen <kenneth@webkit.org>
1602
1603         Reviewed by Simon Fraser.
1604
1605         repaint events from outside the viewport aren't received
1606         https://bugs.webkit.org/show_bug.cgi?id=32081
1607
1608         When using a tiled backing store for painting, you need to receive
1609         event from outside the viewport. Setting the viewport to the size
1610         of the contents is not an option if you want to make use of WebCore's
1611         infrastructure for drawing scrollbars etc.
1612
1613         A new property, paintsEntireContents, has been introduced for the
1614         above use-case. It is settable, as tiling will be optional for Qt,
1615         and for the not yet upstreamed EFL port, there will be two different
1616         views, where only one of them are tiled.
1617
1618         No change in behavior, so no new tests added.
1619
1620         * page/FrameView.cpp:
1621         (WebCore::FrameView::repaintContentRectangle):
1622         * platform/ScrollView.cpp:
1623         (WebCore::ScrollView::ScrollView):
1624         (WebCore::ScrollView::setPaintsEntireContents):
1625         (WebCore::ScrollView::wheelEvent):
1626         * platform/ScrollView.h:
1627         (WebCore::ScrollView::paintsEntireContents):
1628
1629 2009-11-23  Jeremy Moskovich  <jeremy@chromium.org>
1630
1631         Reviewed by Eric Seidel.
1632
1633         Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
1634         https://bugs.webkit.org/show_bug.cgi?id=31802
1635
1636         No test since this is already covered by existing pixel tests.
1637
1638         * platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
1639         * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations
1640         of Core Text functions that are public on 10.6 but SPI on 10.5.
1641
1642 2009-12-03  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1643
1644         Reviewed by Timothy Hatcher.
1645
1646         Web Inspector: Simplify the settings support in inspector controller.
1647
1648         https://bugs.webkit.org/show_bug.cgi?id=32076
1649
1650         Test: inspector/settings-set-get.html
1651
1652         * WebCore.Inspector.exp:
1653         * bindings/js/JSInspectorFrontendHostCustom.cpp:
1654         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
1655         * inspector/InspectorClient.h:
1656         * inspector/InspectorController.cpp:
1657         (WebCore::InspectorController::~InspectorController):
1658         (WebCore::InspectorController::setting):
1659         (WebCore::InspectorController::setSetting):
1660         (WebCore::InspectorController::setWindowVisible):
1661         (WebCore::InspectorController::attachWindow):
1662         (WebCore::InspectorController::setAttachedWindowHeight):
1663         (WebCore::InspectorController::storeLastActivePanel):
1664         (WebCore::InspectorController::scriptObjectReady):
1665         (WebCore::InspectorController::showWindow):
1666         (WebCore::InspectorController::enableResourceTracking):
1667         (WebCore::InspectorController::disableResourceTracking):
1668         (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
1669         (WebCore::InspectorController::enableProfiler):
1670         (WebCore::InspectorController::disableProfiler):
1671         (WebCore::InspectorController::enableDebuggerFromFrontend):
1672         (WebCore::InspectorController::disableDebugger):
1673         * inspector/InspectorController.h:
1674         * inspector/InspectorFrontendHost.cpp:
1675         (WebCore::InspectorFrontendHost::setting):
1676         (WebCore::InspectorFrontendHost::setSetting):
1677         * inspector/InspectorFrontendHost.h:
1678         * inspector/InspectorFrontendHost.idl:
1679         * loader/EmptyClients.h:
1680         (WebCore::EmptyInspectorClient::populateSetting):
1681         (WebCore::EmptyInspectorClient::storeSetting):
1682
1683 2009-12-03  Ben Murdoch  <benm@google.com>
1684
1685         Reviewed by Brady Eidson.
1686
1687         [Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed.
1688         https://bugs.webkit.org/show_bug.cgi?id=31915
1689
1690         No change in functionality so no new tests required.
1691
1692         * history/HistoryItem.cpp:
1693         (WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
1694         (WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
1695         (WebCore::HistoryItem::setURLString): ditto.
1696         (WebCore::HistoryItem::setOriginalURLString): ditto.
1697         (WebCore::HistoryItem::setReferrer): ditto.
1698         (WebCore::HistoryItem::setTitle): ditto.
1699         (WebCore::HistoryItem::setTarget): ditto.
1700         (WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
1701         (WebCore::HistoryItem::clearDocumentState): ditto.
1702         (WebCore::HistoryItem::setIsTargetItem): ditto.
1703         (WebCore::HistoryItem::addChildItem): ditto.
1704         (WebCore::HistoryItem::setFormInfoFromRequest): ditto.
1705         * history/HistoryItem.h: Update signature of notifyHistoryItemChanged.
1706
1707 2009-12-03  Ben Murdoch  <benm@google.com>
1708
1709         Reviewed by Brady Eidson.
1710
1711         [Android] The FrameLoaderClient is unaware of BackForwardList changes.
1712         https://bugs.webkit.org/show_bug.cgi?id=31914
1713
1714         This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.
1715
1716         No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.
1717
1718         * history/BackForwardList.cpp:
1719         (WebCore::BackForwardList::addItem): Execute the callback.
1720         (WebCore::BackForwardList::goBack): ditto.
1721         (WebCore::BackForwardList::goForward): ditto.
1722         (WebCore::BackForwardList::goToItem): ditto.
1723         (WebCore::BackForwardList::setCapacity): dito.
1724         * loader/EmptyClients.h:
1725         (WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
1726         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
1727         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
1728         * loader/FrameLoaderClient.h:
1729
1730 2009-12-03  Ben Murdoch  <benm@google.com>
1731
1732         Reviewed by Brady Eidson.
1733
1734         [Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
1735         https://bugs.webkit.org/show_bug.cgi?id=31913
1736
1737         Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.
1738
1739         No new tests required as this is Android specific code.
1740
1741         * history/HistoryItem.h: Add Android specific member data to HistoryItem.
1742         * history/android: Added.
1743         * history/android/AndroidWebHistoryBridge.h: Added.
1744         * history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.
1745         (WebCore::HistoryItem::bridge): Added.
1746         (WebCore::HistoryItem::setBridge): Added.
1747
1748 2009-12-03  Oliver Hunt  <oliver@apple.com>
1749
1750         Reviewed by Maciej Stachowiak.
1751
1752         NULL ptr in SVGPathSegList::getPathSegAtLength()
1753         https://bugs.webkit.org/show_bug.cgi?id=30313
1754
1755         Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
1756         Add null checks to SVGList's content manipulation functions to prevent
1757         null values from entering the list in the first place.
1758
1759         Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html
1760
1761         * svg/SVGList.h:
1762         (WebCore::SVGList::initialize):
1763         (WebCore::SVGList::insertItemBefore):
1764         (WebCore::SVGList::replaceItem):
1765         (WebCore::SVGList::appendItem):
1766         * svg/SVGPathElement.cpp:
1767         (WebCore::SVGPathElement::getPathSegAtLength):
1768         * svg/SVGPathElement.h:
1769         * svg/SVGPathElement.idl:
1770         * svg/SVGPathSegList.cpp:
1771         (WebCore::SVGPathSegList::getPathSegAtLength):
1772         (WebCore::SVGPathSegList::toPathData):
1773         (WebCore::SVGPathSegList::createAnimated):
1774         * svg/SVGPathSegList.h:
1775
1776 2009-12-02  Yusuke Sato  <yusukes@chromium.org>
1777
1778         Reviewed by Eric Seidel.
1779
1780         Sanitize web fonts using the OTS library 
1781         https://bugs.webkit.org/show_bug.cgi?id=31106
1782
1783         Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
1784         and attempts to validate and sanitize them. We hope this reduces the attack surface
1785         of the system font libraries.
1786
1787         * WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
1788         * WebCore.gypi: Added new files below.
1789         * WebCore.xcodeproj/project.pbxproj: Ditto.
1790         * platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font.
1791         (WebCore::createFontCustomPlatformData):
1792         * platform/graphics/mac/FontCustomPlatformData.cpp: Ditto.
1793         (WebCore::createFontCustomPlatformData):
1794         * platform/graphics/opentype/OpenTypeSanitizer.cpp: Added.
1795         (WebCore::OpenTypeSanitizer::sanitize):
1796         * platform/graphics/opentype/OpenTypeSanitizer.h: Added.
1797         (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):
1798
1799 2009-12-02  Oliver Hunt  <oliver@apple.com>
1800
1801         Reviewed by Sam Weinig.
1802
1803         Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
1804         https://bugs.webkit.org/show_bug.cgi?id=32098
1805
1806         Fix is simply to make the ScriptFunctionCall stack allocated as nature intended.
1807         Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
1808         that an explicit String cast would not be necessary.
1809
1810         To prevent something like this happening again in future i've added private
1811         operator new implementations to ScriptFunctionCall making this type of mistake
1812         produce errors when compiling.
1813
1814         Test case: Inspector tests now pass with GC on every alloc enabled.
1815
1816         * bindings/js/ScriptFunctionCall.cpp:
1817         (WebCore::ScriptFunctionCall::appendArgument):
1818         * bindings/js/ScriptFunctionCall.h:
1819         (WebCore::ScriptFunctionCall::operator new):
1820         (WebCore::ScriptFunctionCall::operator new[]):
1821         * inspector/InspectorFrontend.cpp:
1822         (WebCore::InspectorFrontend::addConsoleMessage):
1823         (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
1824         (WebCore::InspectorFrontend::addResource):
1825         (WebCore::InspectorFrontend::updateResource):
1826         (WebCore::InspectorFrontend::removeResource):
1827         (WebCore::InspectorFrontend::updateFocusedNode):
1828         (WebCore::InspectorFrontend::setAttachedWindow):
1829         (WebCore::InspectorFrontend::addRecordToTimeline):
1830         (WebCore::InspectorFrontend::parsedScriptSource):
1831         (WebCore::InspectorFrontend::failedToParseScriptSource):
1832         (WebCore::InspectorFrontend::addProfileHeader):
1833         (WebCore::InspectorFrontend::setRecordingProfile):
1834         (WebCore::InspectorFrontend::didGetProfileHeaders):
1835         (WebCore::InspectorFrontend::didGetProfile):
1836         (WebCore::InspectorFrontend::pausedScript):
1837         (WebCore::InspectorFrontend::setDocument):
1838         (WebCore::InspectorFrontend::setDetachedRoot):
1839         (WebCore::InspectorFrontend::setChildNodes):
1840         (WebCore::InspectorFrontend::childNodeCountUpdated):
1841         (WebCore::InspectorFrontend::childNodeInserted):
1842         (WebCore::InspectorFrontend::childNodeRemoved):
1843         (WebCore::InspectorFrontend::attributesUpdated):
1844         (WebCore::InspectorFrontend::didRemoveNode):
1845         (WebCore::InspectorFrontend::didGetChildNodes):
1846         (WebCore::InspectorFrontend::didApplyDomChange):
1847         (WebCore::InspectorFrontend::didGetEventListenersForNode):
1848         (WebCore::InspectorFrontend::didGetCookies):
1849         (WebCore::InspectorFrontend::didDispatchOnInjectedScript):
1850         (WebCore::InspectorFrontend::addDatabase):
1851         (WebCore::InspectorFrontend::selectDatabase):
1852         (WebCore::InspectorFrontend::didGetDatabaseTableNames):
1853         (WebCore::InspectorFrontend::addDOMStorage):
1854         (WebCore::InspectorFrontend::selectDOMStorage):
1855         (WebCore::InspectorFrontend::didGetDOMStorageEntries):
1856         (WebCore::InspectorFrontend::didSetDOMStorageItem):
1857         (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
1858         (WebCore::InspectorFrontend::updateDOMStorage):
1859         (WebCore::InspectorFrontend::addNodesToSearchResult):
1860         (WebCore::InspectorFrontend::evaluateForTestInFrontend):
1861         * inspector/InspectorFrontend.h:
1862
1863 2009-12-02  Dave Hyatt  <hyatt@apple.com>
1864
1865         Reviewed by Darin Adler.
1866
1867         https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
1868         pass more CSS test suite stuff.  Make the grammar stop enforcing the ordering of @namespace vs.
1869         @variables vs. @import.  Just let the parser handle that instead.  This simplifies the grammar and
1870         makes error handling deal with more cases correctly.
1871
1872         Added fast/css/namespaces/namespaces-invalid-at-rules.xml
1873
1874         * css/CSSGrammar.y:
1875         * css/CSSParser.cpp:
1876         (WebCore::CSSParser::CSSParser):
1877         (WebCore::CSSParser::parseRule):
1878         (WebCore::CSSParser::createCharsetRule):
1879         (WebCore::CSSParser::createImportRule):
1880         (WebCore::CSSParser::createMediaRule):
1881         (WebCore::CSSParser::createKeyframesRule):
1882         (WebCore::CSSParser::createStyleRule):
1883         (WebCore::CSSParser::createFontFaceRule):
1884         (WebCore::CSSParser::addNamespace):
1885         (WebCore::CSSParser::createVariablesRule):
1886         * css/CSSParser.h:
1887
1888 2009-12-02  Yusuke Sato  <yusukes@chromium.org>
1889
1890         Reviewed by Dan Bernstein.
1891
1892         Safari/Chromium for Windows fails to load CJK WebFonts
1893         https://bugs.webkit.org/show_bug.cgi?id=31804
1894         
1895         * platform/graphics/opentype/OpenTypeUtilities.cpp:
1896         (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
1897
1898 2009-12-02  Avi Drissman  <avi@chromium.org>
1899
1900         Reviewed by Darin Fisher.
1901
1902         Chromium: Need tickmarks in scrollbar
1903         https://bugs.webkit.org/show_bug.cgi?id=32069
1904
1905         * WebCore.gyp/WebCore.gyp:
1906         * WebCore.gypi:
1907         * platform/chromium/ScrollbarThemeChromiumMac.h: Added.
1908         * platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
1909
1910 2009-11-13  Timothy Hatcher  <timothy@apple.com>
1911
1912         Expose a function to set the value of an input element on behalf of the user.
1913         This function will dispatch the change event so the page is notified when autofill
1914         happens. Also dispatch a change event when a select element is changed by autofill.
1915
1916         <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
1917
1918         Reviewed by Darin Adler.
1919
1920         * WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
1921         * bindings/objc/DOMHTML.mm:
1922         (-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
1923         a change event is fired. This method is called by Safari autofill.
1924         * dom/Document.cpp:
1925         (WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
1926         of dispatching the change event directly to be consistent.
1927         * html/HTMLFormControlElement.cpp:
1928         (WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
1929         (WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.
1930         * html/HTMLInputElement.h:
1931         * html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
1932         * html/InputElement.h: Added setValueForUser.
1933
1934 2009-12-02  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1935
1936         Reviewed by Timothy Hatcher.
1937
1938         Web Inspector: DOM tree selection disappears upon page refresh.
1939
1940         https://bugs.webkit.org/show_bug.cgi?id=31142
1941
1942         Test: inspector/elements-panel-selection-on-refresh.html
1943
1944         * inspector/InjectedScriptHost.cpp:
1945         (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
1946         * inspector/InjectedScriptHost.h:
1947         * inspector/InjectedScriptHost.idl:
1948         * inspector/InspectorBackend.h:
1949         * inspector/InspectorController.cpp:
1950         (WebCore::InspectorController::close):
1951         (WebCore::InspectorController::releaseDOMAgent):
1952         (WebCore::InspectorController::resetScriptObjects):
1953         * inspector/InspectorDOMAgent.cpp:
1954         (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
1955         (WebCore::InspectorDOMAgent::reset):
1956         (WebCore::InspectorDOMAgent::setDocument):
1957         (WebCore::InspectorDOMAgent::pushDocumentToFrontend):
1958         (WebCore::InspectorDOMAgent::nodeForPath):
1959         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
1960         * inspector/InspectorDOMAgent.h:
1961         * inspector/front-end/DOMAgent.js:
1962         (WebInspector.DOMNode.prototype._renumber):
1963         (WebInspector.DOMAgent.prototype._setDocument):
1964         * inspector/front-end/ElementsPanel.js:
1965         (WebInspector.ElementsPanel.prototype.reset):
1966         (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode):
1967         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
1968         (WebInspector.ElementsPanel.prototype.setDocument):
1969         * inspector/front-end/InjectedScript.js:
1970         (InjectedScript.pushNodeByPathToFrontend):
1971         * inspector/front-end/InjectedScriptAccess.js:
1972
1973 2009-12-01  Dave Hyatt  <hyatt@apple.com>
1974
1975         Reviewed by Dan Bernstein.
1976
1977         https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
1978         all the @-rules we support.  When escape sequences are present, the lexical scanner
1979         just returns a generic token name: ATKEYWORD.  We have to process the escape sequences
1980         and then recheck against the rules we support with the final processed name.  If we
1981         find a match, we mutate the token value to the appropriate rule name token, e.g.,
1982         NAMESPACE_SYM.
1983
1984         Added fast/css/namespaces/namespaces-escapes.xml
1985
1986         * css/CSSParser.cpp:
1987         (WebCore::CSSParser::lex):
1988         (WebCore::CSSParser::recheckAtKeyword):
1989         (WebCore::CSSParser::text):
1990         * css/CSSParser.h:
1991
1992 2009-12-02  Anton Muhin  <antonm@chromium.org>
1993
1994         Reviewed by Adam Barth.:w
1995
1996         Allow to skip thread checks when accessing DOMDataStore for processes
1997         which run V8 in single thread mode.
1998         https://bugs.webkit.org/show_bug.cgi?id=31877
1999
2000         Should be covered by buildbots.
2001
2002         * bindings/v8/V8DOMMap.cpp:
2003         (WebCore::getDOMDataStore):
2004         (WebCore::enableFasterDOMStoreAccess):
2005         (WebCore::getDOMNodeMap):
2006         (WebCore::getDOMObjectMap):
2007         (WebCore::getActiveDOMObjectMap):
2008         (WebCore::getDOMSVGElementInstanceMap):
2009         (WebCore::getDOMSVGObjectWithContextMap):
2010         * bindings/v8/V8DOMMap.h:
2011
2012 2009-12-02  Yury Semikhatsky  <yurys@chromium.org>
2013
2014         Reviewed by Pavel Feldman.
2015
2016         Code clean up: remove ScriptObjectQuarantine.* as a whole.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=32060
2019
2020         * GNUmakefile.am:
2021         * WebCore.gypi:
2022         * WebCore.pro:
2023         * WebCore.vcproj/WebCore.vcproj:
2024         * WebCore.xcodeproj/project.pbxproj:
2025         * WebCoreSources.bkl:
2026         * bindings/js/JSBindingsAllInOne.cpp:
2027         * bindings/js/ScriptObjectQuarantine.cpp: Removed.
2028         * bindings/js/ScriptObjectQuarantine.h: Removed.
2029         * bindings/js/ScriptValue.cpp:
2030         (WebCore::ScriptValue::quarantineValue):
2031         * bindings/js/ScriptValue.h:
2032         * bindings/v8/ScriptObjectQuarantine.cpp: Removed.
2033         * bindings/v8/ScriptObjectQuarantine.h: Removed.
2034         * bindings/v8/ScriptValue.h:
2035         (WebCore::ScriptValue::quarantineValue):
2036         * inspector/ConsoleMessage.cpp:
2037         (WebCore::ConsoleMessage::ConsoleMessage):
2038         * inspector/InspectorController.cpp:
2039         * inspector/InspectorDatabaseResource.cpp:
2040         (WebCore::InspectorDatabaseResource::bind):
2041         * inspector/InspectorFrontend.cpp:
2042
2043 2009-12-02  Fumitoshi Ukai  <ukai@chromium.org>
2044
2045         Reviewed by Alexey Proskuryakov.
2046
2047         WebSocket handshake check query component of URL
2048         https://bugs.webkit.org/show_bug.cgi?id=31617
2049
2050         Tests: websocket/tests/url-with-credential.html
2051                websocket/tests/url-with-empty-query.html
2052                websocket/tests/url-with-fragment.html
2053                websocket/tests/url-with-query-for-no-query.html
2054                websocket/tests/url-with-query.html
2055
2056         * platform/KURLGoogle.cpp:
2057         (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
2058         * websockets/WebSocketHandshake.cpp:
2059         (WebCore::resourceName): added. add query component to path if specified.
2060         (WebCore::WebSocketHandshake::clientLocation):
2061         (WebCore::WebSocketHandshake::clientHandshakeMessage):
2062
2063 2009-12-01  David Levin  <levin@chromium.org>
2064
2065         Reviewed by Eric Seidel.
2066
2067         Incorrect code in WebGLRenderingContext.cpp
2068         https://bugs.webkit.org/show_bug.cgi?id=32046
2069
2070         Fix incorrect code that happened to work. != has higher precendence than &.
2071         The simplest fix is to remove the "!= 0" which violates WebKit style
2072         guidelines anyway.
2073
2074         Also added periods to few comments in the same function.
2075
2076         * html/canvas/WebGLRenderingContext.cpp:
2077         (WebCore::WebGLRenderingContext::validateIndexArray):
2078
2079 2009-12-01  Kent Tamura  <tkent@chromium.org>
2080
2081         Reviewed by Darin Adler.
2082
2083         Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
2084         pattern and step attributes of HTMLInputElement.
2085         https://bugs.webkit.org/show_bug.cgi?id=31708
2086
2087         * html/HTMLInputElement.idl:
2088
2089 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
2090
2091         Reviewed by Darin Adler.
2092
2093         WAI-ARIA: implement support for ARIA drag and drop
2094         https://bugs.webkit.org/show_bug.cgi?id=32007
2095
2096         Test: platform/mac/accessibility/aria-drag-drop.html
2097
2098         * accessibility/AccessibilityObject.h:
2099         (WebCore::AccessibilityObject::supportsARIADropping):
2100         (WebCore::AccessibilityObject::supportsARIADragging):
2101         (WebCore::AccessibilityObject::isARIAGrabbed):
2102         (WebCore::AccessibilityObject::setARIAGrabbed):
2103         (WebCore::AccessibilityObject::determineARIADropEffects):
2104         * accessibility/AccessibilityRenderObject.cpp:
2105         (WebCore::AccessibilityRenderObject::supportsARIADropping):
2106         (WebCore::AccessibilityRenderObject::supportsARIADragging):
2107         (WebCore::AccessibilityRenderObject::isARIAGrabbed):
2108         (WebCore::AccessibilityRenderObject::setARIAGrabbed):
2109         (WebCore::AccessibilityRenderObject::determineARIADropEffects):
2110         * accessibility/AccessibilityRenderObject.h:
2111         * accessibility/mac/AccessibilityObjectWrapper.mm:
2112         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
2113         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2114         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2115         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2116         * html/HTMLAttributeNames.in:
2117
2118 2009-12-01  Adam Barth  <abarth@webkit.org>
2119
2120         https://bugs.webkit.org/show_bug.cgi?id=21288
2121
2122         Unreviewed port of @sandbox to V8.
2123
2124         * bindings/v8/ScriptController.cpp:
2125         (WebCore::ScriptController::isEnabled):
2126         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2127         (WebCore::createWindow):
2128
2129 2009-12-01  Patrik Persson  <patrik.j.persson@ericsson.com>
2130
2131         Reviewed by Darin Adler.
2132
2133         Implement HTML5 sandbox attribute for iframes.
2134         http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
2135         https://bugs.webkit.org/show_bug.cgi?id=21288
2136
2137         Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
2138                fast/frames/sandboxed-iframe-forms.html
2139                fast/frames/sandboxed-iframe-navigation-allowed.html
2140                fast/frames/sandboxed-iframe-navigation-parent.html
2141                fast/frames/sandboxed-iframe-navigation-targetlink.html
2142                fast/frames/sandboxed-iframe-navigation-windowopen.html
2143                fast/frames/sandboxed-iframe-plugins.html
2144                fast/frames/sandboxed-iframe-scripting.html
2145                fast/frames/sandboxed-iframe-storage.html
2146                http/tests/security/sandboxed-iframe-document-cookie.html
2147                http/tests/security/sandboxed-iframe-modify-self.html
2148                http/tests/security/xss-DENIED-sandboxed-iframe.html
2149                http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
2150                http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
2151                http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html
2152
2153         * bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation
2154         (WebCore::createWindow):
2155         * bindings/js/ScriptController.cpp: sandboxing scripts
2156         (WebCore::ScriptController::isEnabled):
2157         * dom/Document.cpp:
2158         (WebCore::Document::processHttpEquiv):
2159         (WebCore::Document::cookie): raise exception when accessed from sandbox
2160         (WebCore::Document::setCookie): raise exception when accessed from sandbox
2161         (WebCore::Document::initSecurityContext): updae sandbox status
2162         (WebCore::Document::updateSandboxFlags):
2163         * dom/Document.h:
2164         * dom/Document.idl:
2165         * html/HTMLAppletElement.cpp: sandboxing applets
2166         (WebCore::HTMLAppletElement::createRenderer):
2167         (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
2168         (WebCore::HTMLAppletElement::canEmbedJava):
2169         * html/HTMLAppletElement.h:
2170         * html/HTMLAttributeNames.in:
2171         * html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute
2172         (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
2173         (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
2174         * html/HTMLFrameOwnerElement.h:
2175         (WebCore::HTMLFrameOwnerElement::sandboxFlags):
2176         * html/HTMLIFrameElement.cpp: sandbox attribute parsing
2177         (WebCore::parseSandboxAttribute):
2178         (WebCore::HTMLIFrameElement::parseMappedAttribute):
2179         * html/HTMLIFrameElement.idl:
2180         * inspector/InspectorController.cpp:
2181         (WebCore::InspectorController::getCookies):
2182         * loader/CrossOriginAccessControl.cpp:
2183         (WebCore::passesAccessControlCheck):
2184         * loader/FrameLoader.cpp:
2185         (WebCore::FrameLoader::FrameLoader):
2186         (WebCore::FrameLoader::init):
2187         (WebCore::FrameLoader::submitForm): sandboxing forms
2188         (WebCore::FrameLoader::requestObject): sandboxing plugins
2189         (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation
2190         (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
2191         * loader/FrameLoader.h:
2192         (WebCore::FrameLoader::ownerElementSandboxFlagsChanged):
2193         (WebCore::FrameLoader::isSandboxed):
2194         (WebCore::FrameLoader::sandboxFlags):
2195         * loader/FrameLoaderTypes.h:
2196         (WebCore::):
2197         * page/DOMWindow.cpp: disable storage and databases in sandboxed frames
2198         (WebCore::DOMWindow::sessionStorage):
2199         (WebCore::DOMWindow::localStorage):
2200         (WebCore::DOMWindow::openDatabase):
2201         * page/SecurityOrigin.cpp: added sandboxing status
2202         (WebCore::SecurityOrigin::SecurityOrigin):
2203         (WebCore::SecurityOrigin::canAccess):
2204         (WebCore::SecurityOrigin::canRequest):
2205         (WebCore::SecurityOrigin::toString):
2206         * page/SecurityOrigin.h:
2207         (WebCore::SecurityOrigin::setSandboxFlags):
2208         (WebCore::SecurityOrigin::isSandboxed):
2209         (WebCore::SecurityOrigin::canAccessDatabase):
2210         (WebCore::SecurityOrigin::canAccessStorage):
2211         * websockets/WebSocketChannel.cpp:
2212         (WebCore::WebSocketChannel::didReceiveData):
2213
2214 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
2215
2216         Reviewed by David Kilzer.
2217
2218         ARIA: support a way to create a static text object
2219         https://bugs.webkit.org/show_bug.cgi?id=32030
2220
2221         Test: accessibility/aria-text-role.html
2222
2223         * accessibility/AccessibilityObject.cpp:
2224         (WebCore::createARIARoleMap):
2225         * accessibility/AccessibilityRenderObject.cpp:
2226         (WebCore::AccessibilityRenderObject::stringValue):
2227         (WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
2228         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2229         (WebCore::AccessibilityRenderObject::text):
2230         * accessibility/AccessibilityRenderObject.h:
2231
2232 2009-12-01  Oliver Hunt  <oliver@apple.com>
2233
2234         Reviewed by Maciej Stachowiak.
2235
2236         Inspector crashes when collecting on every allocation
2237         https://bugs.webkit.org/show_bug.cgi?id=32044
2238
2239         The crash is caused by the prototype wrapper object getting collected
2240         when allocating the object that is going to use it as a prototype.
2241         Because the only reference to the prototype wrapper is through the
2242         new object's Structure it does not get marked automatically.
2243
2244         * bindings/js/JSInspectedObjectWrapper.cpp:
2245         (WebCore::JSInspectedObjectWrapper::wrap):
2246         * bindings/js/JSInspectorCallbackWrapper.cpp:
2247         (WebCore::JSInspectorCallbackWrapper::wrap):
2248
2249 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
2250
2251         Reviewed by Simon Fraser.
2252
2253         Add SVG animation test framework with 'snapshot' functionality
2254         https://bugs.webkit.org/show_bug.cgi?id=31897
2255
2256         Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
2257         for the use within the new SVG animation test framework (LayoutTests/svg/animations/)
2258
2259         layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
2260         to sample a svg animateMotion/animateColor/animate/set element at certain times.
2261
2262         After the desired SVG animation starts and calling the method above, it's immediately forwarded to
2263         the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
2264         a callback is fired used to sample the animation value at the target time. It's modelled similar
2265         to the CSS animation/transition testing framework, inspired by
2266         LayoutTests/animations/animation-test-helpers.js.
2267
2268         Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
2269         the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.
2270
2271         Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
2272         interaction, while animating.
2273
2274         Test: svg/animations/animVal-basics.html
2275
2276         * WebCore.base.exp:
2277         * WebCore.xcodeproj/project.pbxproj:
2278         * svg/SVGDocumentExtensions.cpp:
2279         (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
2280         * svg/SVGDocumentExtensions.h:
2281         * svg/animation/SMILTimeContainer.cpp:
2282         (WebCore::SMILTimeContainer::SMILTimeContainer):
2283         (WebCore::SMILTimeContainer::sampleAnimationAtTime):
2284         (WebCore::SMILTimeContainer::updateAnimations):
2285         * svg/animation/SMILTimeContainer.h:
2286
2287 2009-12-01  Jens Alfke  <snej@chromium.org>
2288
2289         Reviewed by Darin Adler.
2290
2291         Add convenience methods to Element and QualifiedName that take
2292         char* instead of AtomicString, in preparation for removing the
2293         implicit conversion between the two types (30187).
2294         https://bugs.webkit.org/show_bug.cgi?id=31749
2295
2296         * dom/Element.cpp:
2297         (WebCore::Element::setCStringAttribute):  Equivalent to setAttribute.
2298         * dom/Element.h:
2299         * dom/QualifiedName.cpp:
2300         (WebCore::QualifiedName::init):  Shared impl of both constructors
2301         (WebCore::QualifiedName::QualifiedName):  New c'tor taking char*.
2302         * dom/QualifiedName.h:
2303         * platform/network/HTTPHeaderMap.cpp:
2304         (WebCore::CaseFoldingCStringTranslator):  Enables lookup by C string
2305         (WebCore::HTTPHeaderMap::get):  New variant that takes C string
2306         (WebCore::HTTPHeaderMap::contains):  New variant that takes C string
2307         (WebCore::HTTPHeaderMap::add):  New variant that takes C string
2308         * platform/network/HTTPHeaderMap.h:
2309         (WebCore::HTTPHeaderMap::get):
2310         (WebCore::HTTPHeaderMap::add):
2311         * platform/network/ResourceRequestBase.cpp:
2312         (WebCore::ResourceRequestBase::httpHeaderField):  New variant that takes C string
2313         * platform/network/ResourceRequestBase.h:
2314         (WebCore::ResourceRequestBase::setHTTPHeaderField):  Use symbolic names for headers
2315         * platform/network/ResourceResponseBase.cpp:
2316         (WebCore::ResourceResponseBase::httpHeaderField):  New variant that takes C string
2317         * platform/network/ResourceResponseBase.h:
2318
2319 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
2320
2321         More Windows build fix.
2322
2323         * platform/network/cf/CredentialStorageCFNet.cpp:
2324         (WebCore::CredentialStorage::getFromPersistentStorage):
2325
2326 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
2327
2328         Windows build fix.
2329
2330         * platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
2331
2332 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
2333
2334         Reviewed by Darin Adler.
2335
2336         https://bugs.webkit.org/show_bug.cgi?id=32036
2337         Implement CredentialStorage::getFromPersistentStorage for CFNetwork
2338
2339         * platform/network/cf/CredentialStorageCFNet.cpp:
2340         (WebCore::CredentialStorage::getFromPersistentStorage):
2341
2342 2009-12-01  Daniel Bates  <dbates@webkit.org>
2343
2344         Reviewed by Pavel Feldman.
2345
2346         https://bugs.webkit.org/show_bug.cgi?id=32001
2347
2348         Added missing localized strings (that I left out of the patch for bug #21554):
2349         %d × %d pixels
2350         %d × %d pixels (Natural: %d × %d pixels)
2351
2352         Also, changed formatting of these stings to conform with existing ones (added
2353         a space on both sides of the multiply sign).
2354
2355         * English.lproj/localizedStrings.js: Added stings.
2356         * inspector/front-end/ElementsTreeOutline.js:
2357         (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
2358
2359 2009-12-01  Dave Hyatt  <hyatt@apple.com>
2360
2361         Reviewed by Simon Fraser.
2362
2363         Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.
2364
2365         Added fast/css/namespaces/namespaces-empty.xml
2366
2367         * css/CSSStyleSheet.cpp:
2368         (WebCore::CSSStyleSheet::addNamespace):
2369         (WebCore::CSSStyleSheet::determineNamespace):
2370
2371 2009-12-01  Joseph Pecoraro  <joepeck@webkit.org>
2372
2373         Reviewed by Timothy Hatcher.
2374
2375         Web Inspector: Escape key in the Search Field should be more User Friendly
2376         https://bugs.webkit.org/show_bug.cgi?id=32005
2377
2378         * inspector/front-end/inspector.js:
2379         (WebInspector.loaded): add mousedown listener on the search field
2380         (WebInspector.searchFieldManualFocus): user clicked to focus on the search field
2381         (WebInspector.searchKeyDown): handle escape
2382
2383 2009-12-01  Dave Hyatt  <hyatt@apple.com>
2384
2385         Reviewed by David Kilzer.
2386
2387         @namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
2388         the spec.  Not doing so prevent comments from being used immmediately after the namespace prefix.
2389
2390         Added fast/css/namespaces-comments.xml
2391
2392         * css/CSSGrammar.y:
2393
2394 2009-12-01  Yael Aharon  <yael.aharon@nokia.com>
2395
2396         Reviewed by Timothy Hatcher.
2397
2398         Reloading WebInspector from context menu is closing it instead of reloading.
2399         https://bugs.webkit.org/show_bug.cgi?id=32004
2400
2401         When reloading WebInspector, don't delete its m_page.
2402
2403         * inspector/InspectorController.cpp:
2404         (WebCore::InspectorController::close):
2405
2406 2009-12-01  Steve Block  <steveblock@google.com>
2407
2408         Reviewed by Dimitri Glazkov.
2409
2410         Adds V8 bindings for Geolocation.
2411         https://bugs.webkit.org/show_bug.cgi?id=30206
2412
2413         Also adds Geolocation files to Chrome build files.
2414
2415         * WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
2416         * WebCore.gypi: Modified. Adds Geolocation files.
2417         * bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
2418         * bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
2419         * bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
2420         * bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
2421         * bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
2422         * bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
2423         * bindings/v8/custom/V8CustomPositionCallback.cpp: Added.
2424         (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor.
2425         (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor.
2426         (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
2427         * bindings/v8/custom/V8CustomPositionCallback.h: Added.
2428         (WebCore::V8CustomPositionCallback::create): Added. Factory method.
2429         * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added.
2430         (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor.
2431         (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor.
2432         (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
2433         * bindings/v8/custom/V8CustomPositionErrorCallback.h: Added.
2434         (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
2435         * bindings/v8/custom/V8GeolocationCustom.cpp: Added.
2436         (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error.
2437         (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument.
2438         (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument.
2439         (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
2440
2441 2009-12-01  Yury Semikhatsky  <yurys@chromium.org>
2442
2443         Reviewed by Adam Barth.
2444
2445         Provide a way to get ScriptState for the inspected page.
2446
2447         https://bugs.webkit.org/show_bug.cgi?id=32020
2448
2449         * bindings/v8/ScriptController.cpp:
2450         (WebCore::ScriptController::mainWorldScriptState):
2451         * bindings/v8/ScriptController.h:
2452         * bindings/v8/ScriptState.cpp:
2453         (WebCore::scriptStateFromPage):
2454
2455 2009-12-01  Chris Marrin  <cmarrin@apple.com>
2456
2457         Reviewed by Adam Roben.
2458
2459         Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
2460         https://bugs.webkit.org/show_bug.cgi?id=30778
2461
2462         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2463         (WebCore::GraphicsContext3D::getProgramInfoLog):
2464         (WebCore::GraphicsContext3D::getShaderInfoLog):
2465         (WebCore::GraphicsContext3D::getShaderSource):
2466         (WebCore::imageToTexture):
2467
2468 2009-12-01  Mads Ager  <ager@chromium.org>
2469
2470         Reviewed by Eric Seidel.
2471
2472         [V8] Don't crash in DOMWindow event getter in OOM situations
2473         https://bugs.webkit.org/show_bug.cgi?id=32017
2474
2475         Add missing null handle checks in DOMWindow event property
2476         accessors.  V8Proxy::context(frame) can return a null handle in
2477         OOM situations either if failing to initialize a context or if an
2478         OOM is handled gracefully and javascript is disabled.
2479
2480         No new tests because we don't have a good way to test
2481         out-of-memory bugs.
2482
2483         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2484         (WebCore::ACCESSOR_GETTER):
2485         (WebCore::ACCESSOR_SETTER):
2486
2487 2009-12-01  Chris Marrin  <cmarrin@apple.com>
2488
2489         Reviewed by Oliver Hunt.
2490
2491         Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
2492         https://bugs.webkit.org/show_bug.cgi?id=31672
2493
2494         * html/HTMLCanvasElement.cpp:
2495         (WebCore::HTMLCanvasElement::getContext):
2496
2497 2009-12-01  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
2498
2499         Not reviewed: chromium build fix, added missing import.
2500
2501         * inspector/InspectorFrontendHost.cpp:
2502
2503 2009-12-01  Pavel Feldman  <pfeldman@chromium.org>
2504
2505         Not reviewed: fix windows build via unexcluding generated files from
2506         project.
2507
2508         * WebCore.vcproj/WebCore.vcproj:
2509
2510 2009-12-01  Mark Rowe  <mrowe@apple.com>
2511
2512         Stop copying IDL files in to the WebCore framework wrapper.
2513
2514         * WebCore.xcodeproj/project.pbxproj:
2515
2516 2009-12-01  Mark Rowe  <mrowe@apple.com>
2517
2518         Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.
2519
2520         This was probably broken by hand-editing the project file as Xcode itself
2521         knows how to keep project files to a backwards-compatible subset of its format.
2522
2523         * WebCore.xcodeproj/project.pbxproj:
2524
2525 2009-12-01  Pavel Feldman  <pfeldman@chromium.org>
2526
2527         Not reviewed: windows build fix (bad vcproj in r51528).
2528
2529         * WebCore.vcproj/WebCore.vcproj:
2530
2531 2009-11-27  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
2532
2533         Reviewed by Timothy Hatcher.
2534
2535         Web Inspector: Split InspectorBackend into three parts: backend,
2536         injected script host and frontend host.
2537         
2538         https://bugs.webkit.org/show_bug.cgi?id=31888
2539
2540         * DerivedSources.make:
2541         * GNUmakefile.am:
2542         * WebCore.gypi:
2543         * WebCore.pro:
2544         * WebCore.vcproj/WebCore.vcproj:
2545         * WebCore.xcodeproj/project.pbxproj:
2546         * WebCoreSources.bkl:
2547         * bindings/js/JSBindingsAllInOne.cpp:
2548         * bindings/js/JSInspectorBackendCustom.cpp: Removed.
2549         * bindings/js/JSInspectorFrontendHostCustom.cpp: Added.
2550         (WebCore::JSInspectorFrontendHost::search):
2551         (WebCore::JSInspectorFrontendHost::setting):
2552         (WebCore::JSInspectorFrontendHost::setSetting):
2553         * bindings/js/ScriptObject.cpp:
2554         (WebCore::ScriptGlobalObject::set):
2555         * bindings/js/ScriptObject.h:
2556         * bindings/v8/DOMObjectsInclude.h:
2557         * bindings/v8/DerivedSourcesAllInOne.cpp:
2558         * bindings/v8/ScriptObject.cpp:
2559         (WebCore::ScriptGlobalObject::set):
2560         * bindings/v8/ScriptObject.h:
2561         * bindings/v8/V8Index.cpp:
2562         * bindings/v8/V8Index.h:
2563         * bindings/v8/custom/V8CustomBinding.h:
2564         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added.
2565         (WebCore::CALLBACK_FUNC_DECL):
2566         * bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
2567         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added.
2568         (WebCore::CALLBACK_FUNC_DECL):
2569         * inspector/InjectedScriptHost.cpp: Added.
2570         (WebCore::InjectedScriptHost::InjectedScriptHost):
2571         (WebCore::InjectedScriptHost::~InjectedScriptHost):
2572         (WebCore::InjectedScriptHost::copyText):
2573         (WebCore::InjectedScriptHost::nodeForId):
2574         (WebCore::InjectedScriptHost::wrapObject):
2575         (WebCore::InjectedScriptHost::unwrapObject):
2576         (WebCore::InjectedScriptHost::pushNodePathToFrontend):
2577         (WebCore::InjectedScriptHost::addNodesToSearchResult):
2578         (WebCore::InjectedScriptHost::currentCallFrame):
2579         (WebCore::InjectedScriptHost::databaseForId):
2580         (WebCore::InjectedScriptHost::selectDatabase):
2581         (WebCore::InjectedScriptHost::selectDOMStorage):
2582         (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
2583         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2584         (WebCore::InjectedScriptHost::inspectorFrontend):
2585         * inspector/InjectedScriptHost.h: Added.
2586         (WebCore::InjectedScriptHost::create):
2587         (WebCore::InjectedScriptHost::inspectorController):
2588         (WebCore::InjectedScriptHost::disconnectController):
2589         * inspector/InjectedScriptHost.idl: Added.
2590         * inspector/InspectorBackend.cpp:
2591         (WebCore::InspectorBackend::InspectorBackend):
2592         (WebCore::InspectorBackend::storeLastActivePanel):
2593         (WebCore::InspectorBackend::toggleNodeSearch):
2594         (WebCore::InspectorBackend::resourceTrackingEnabled):
2595         (WebCore::InspectorBackend::debuggerEnabled):
2596         (WebCore::InspectorBackend::enableDebugger):
2597         (WebCore::InspectorBackend::disableDebugger):
2598         (WebCore::InspectorBackend::addBreakpoint):
2599         (WebCore::InspectorBackend::updateBreakpoint):
2600         (WebCore::InspectorBackend::removeBreakpoint):
2601         (WebCore::InspectorBackend::pauseInDebugger):
2602         (WebCore::InspectorBackend::resumeDebugger):
2603         (WebCore::InspectorBackend::stepOverStatementInDebugger):
2604         (WebCore::InspectorBackend::stepIntoStatementInDebugger):
2605         (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
2606         (WebCore::InspectorBackend::pauseOnExceptions):
2607         (WebCore::InspectorBackend::setPauseOnExceptions):
2608         (WebCore::InspectorBackend::profilerEnabled):
2609         (WebCore::InspectorBackend::enableProfiler):
2610         (WebCore::InspectorBackend::disableProfiler):
2611         (WebCore::InspectorBackend::startProfiling):
2612         (WebCore::InspectorBackend::stopProfiling):
2613         (WebCore::InspectorBackend::getProfileHeaders):
2614         (WebCore::InspectorBackend::getProfile):
2615         (WebCore::InspectorBackend::currentCallFrame):
2616         (WebCore::InspectorBackend::highlightDOMNode):
2617         (WebCore::InspectorBackend::hideDOMNodeHighlight):
2618         (WebCore::InspectorBackend::getCookies):
2619         (WebCore::InspectorBackend::deleteCookie):
2620         (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
2621         (WebCore::InspectorBackend::nodeForId):
2622         * inspector/InspectorBackend.h:
2623         (WebCore::InspectorBackend::create):
2624         * inspector/InspectorBackend.idl:
2625         * inspector/InspectorController.cpp:
2626         (WebCore::InspectorController::InspectorController):
2627         (WebCore::InspectorController::~InspectorController):
2628         (WebCore::InspectorController::inspectedPageDestroyed):
2629         (WebCore::InspectorController::windowScriptObjectAvailable):
2630         * inspector/InspectorController.h:
2631         (WebCore::InspectorController::inspectorFrontendHost):
2632         (WebCore::InspectorController::injectedScriptHost):
2633         * inspector/InspectorFrontendHost.cpp: Added.
2634         (WebCore::InspectorFrontendHost::InspectorFrontendHost):
2635         (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
2636         (WebCore::InspectorFrontendHost::loaded):
2637         (WebCore::InspectorFrontendHost::attach):
2638         (WebCore::InspectorFrontendHost::detach):
2639         (WebCore::InspectorFrontendHost::closeWindow):
2640         (WebCore::InspectorFrontendHost::windowUnloading):
2641         (WebCore::InspectorFrontendHost::setAttachedWindowHeight):
2642         (WebCore::InspectorFrontendHost::moveWindowBy):
2643         (WebCore::InspectorFrontendHost::localizedStringsURL):
2644         (WebCore::InspectorFrontendHost::hiddenPanels):
2645         (WebCore::InspectorFrontendHost::platform):
2646         (WebCore::InspectorFrontendHost::port):
2647         (WebCore::InspectorFrontendHost::addResourceSourceToFrame):
2648         (WebCore::InspectorFrontendHost::addSourceToFrame):
2649         * inspector/InspectorFrontendHost.h: Added.
2650         (WebCore::InspectorFrontendHost::create):
2651         (WebCore::InspectorFrontendHost::inspectorController):
2652         (WebCore::InspectorFrontendHost::disconnectController):
2653         * inspector/InspectorFrontendHost.idl: Added.
2654         * inspector/front-end/Breakpoint.js:
2655         (WebInspector.Breakpoint.prototype.set condition):
2656         * inspector/front-end/BreakpointsSidebarPane.js:
2657         (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
2658         (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
2659         (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
2660         * inspector/front-end/ConsoleView.js:
2661         (WebInspector.ConsoleView.prototype.clearMessages):
2662         * inspector/front-end/CookieItemsView.js:
2663         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2664         * inspector/front-end/DOMAgent.js:
2665         (WebInspector.DOMAgent.prototype.getChildNodesAsync):
2666         (WebInspector.DOMAgent.prototype.setAttributeAsync):
2667         (WebInspector.DOMAgent.prototype.removeAttributeAsync):
2668         (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
2669         (WebInspector.Cookies.getCookiesAsync):
2670         (WebInspector.EventListeners.getEventListenersForNodeAsync):
2671         * inspector/front-end/DOMStorage.js:
2672         (WebInspector.DOMStorage.prototype.getEntries):
2673         (WebInspector.DOMStorage.prototype.setItem):
2674         (WebInspector.DOMStorage.prototype.removeItem):
2675         * inspector/front-end/Database.js:
2676         (WebInspector.Database.prototype.getTableNames):
2677         * inspector/front-end/ElementsPanel.js:
2678         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
2679         (WebInspector.ElementsPanel.prototype.hide):
2680         (WebInspector.ElementsPanel.prototype.reset):
2681         (WebInspector.ElementsPanel.prototype.handleCopyEvent):
2682         (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
2683         * inspector/front-end/ElementsTreeOutline.js:
2684         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
2685         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
2686         ():
2687         * inspector/front-end/EventListenersSidebarPane.js:
2688         (WebInspector.EventListenersSidebarPane.prototype):
2689         * inspector/front-end/InjectedScript.js:
2690         (InjectedScript._evaluateAndWrap):
2691         (InjectedScript.performSearch.addNodesToResults):
2692         (InjectedScript.getCallFrames):
2693         (InjectedScript._callFrameForId):
2694         (InjectedScript._clearConsoleMessages):
2695         (InjectedScript._inspectObject):
2696         (InjectedScript._copy):
2697         (InjectedScript._ensureCommandLineAPIInstalled):
2698         (InjectedScript._window):
2699         (InjectedScript._nodeForId):
2700         (InjectedScript._objectForId):
2701         (InjectedScript.pushNodeToFrontend):
2702         (InjectedScript.executeSql):
2703         (InjectedScript.executeSql.errorCallback):
2704         (InjectedScript.executeSql.queryTransaction):
2705         * inspector/front-end/InjectedScriptAccess.js:
2706         (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
2707         (InjectedScriptAccess._installHandler):
2708         * inspector/front-end/InspectorBackendStub.js: Added.
2709         (.WebInspector.InspectorBackendStub):
2710         (.WebInspector.InspectorBackendStub.prototype.wrapCallback):
2711         (.WebInspector.InspectorBackendStub.prototype.platform):
2712         (.WebInspector.InspectorBackendStub.prototype.port):
2713         (.WebInspector.InspectorBackendStub.prototype.closeWindow):
2714         (.WebInspector.InspectorBackendStub.prototype.attach):
2715         (.WebInspector.InspectorBackendStub.prototype.detach):
2716         (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel):
2717         (.WebInspector.InspectorBackendStub.prototype.clearMessages):
2718         (.WebInspector.InspectorBackendStub.prototype.searchingForNode):
2719         (.WebInspector.InspectorBackendStub.prototype.search):
2720         (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch):
2721         (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight):
2722         (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted):
2723         (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame):
2724         (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame):
2725         (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode):
2726         (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode):
2727         (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight):
2728         (.WebInspector.InspectorBackendStub.prototype.inspectedWindow):
2729         (.WebInspector.InspectorBackendStub.prototype.loaded):
2730         (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL):
2731         (.WebInspector.InspectorBackendStub.prototype.windowUnloading):
2732         (.WebInspector.InspectorBackendStub.prototype.hiddenPanels):
2733         (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled):
2734         (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking):
2735         (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking):
2736         (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled):
2737         (.WebInspector.InspectorBackendStub.prototype.enableDebugger):
2738         (.WebInspector.InspectorBackendStub.prototype.disableDebugger):
2739         (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
2740         (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint):
2741         (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint):
2742         (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger):
2743         (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions):
2744         (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions):
2745         (.WebInspector.InspectorBackendStub.prototype.resumeDebugger):
2746         (.WebInspector.InspectorBackendStub.prototype.profilerEnabled):
2747         (.WebInspector.InspectorBackendStub.prototype.enableProfiler):
2748         (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
2749         (.WebInspector.InspectorBackendStub.prototype.startProfiling):
2750         (.WebInspector.InspectorBackendStub.prototype.stopProfiling):
2751         (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders):
2752         (.WebInspector.InspectorBackendStub.prototype.getProfile):
2753         (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot):
2754         (.WebInspector.InspectorBackendStub.prototype.databaseTableNames):
2755         (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger):
2756         (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger):
2757         (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger):
2758         (.WebInspector.InspectorBackendStub.prototype.setSetting):
2759         (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript):
2760         (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
2761         (.WebInspector.InspectorBackendStub.prototype.setting):
2762         * inspector/front-end/InspectorControllerStub.js:
2763         * inspector/front-end/InspectorFrontendHostStub.js: Added.
2764         (.WebInspector.InspectorFrontendHostStub):
2765         (.WebInspector.InspectorFrontendHostStub.prototype.platform):
2766         (.WebInspector.InspectorFrontendHostStub.prototype.port):
2767         (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
2768         (.WebInspector.InspectorFrontendHostStub.prototype.attach):
2769         (.WebInspector.InspectorFrontendHostStub.prototype.detach):
2770         (.WebInspector.InspectorFrontendHostStub.prototype.search):
2771         (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
2772         (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
2773         (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame):
2774         (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame):
2775         (.WebInspector.InspectorFrontendHostStub.prototype.loaded):
2776         (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
2777         (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
2778         (.WebInspector.InspectorFrontendHostStub.prototype.setSetting):
2779         (.WebInspector.InspectorFrontendHostStub.prototype.setting):
2780         * inspector/front-end/ProfileView.js:
2781         (WebInspector.CPUProfileView):
2782         (WebInspector.CPUProfileType.prototype.buttonClicked):
2783         * inspector/front-end/ProfilesPanel.js:
2784         (WebInspector.ProfilesPanel.prototype._updateInterface):
2785         (WebInspector.ProfilesPanel.prototype._enableProfiling):
2786         (WebInspector.ProfilesPanel.prototype._toggleProfiling):
2787         * inspector/front-end/ResourcesPanel.js:
2788         (WebInspector.ResourcesPanel.prototype.reset):
2789         (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
2790         (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
2791         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
2792         * inspector/front-end/ScriptView.js:
2793         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
2794         * inspector/front-end/ScriptsPanel.js:
2795         (WebInspector.ScriptsPanel.prototype.show):
2796         (WebInspector.ScriptsPanel.prototype.addScript):
2797         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
2798         (WebInspector.ScriptsPanel.prototype.reset):
2799         (WebInspector.ScriptsPanel.prototype.canShowResource):
2800         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
2801         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
2802         (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
2803         (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
2804         (WebInspector.ScriptsPanel.prototype._enableDebugging):
2805         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2806         (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
2807         (WebInspector.ScriptsPanel.prototype._togglePause):
2808         (WebInspector.ScriptsPanel.prototype._stepOverClicked):
2809         (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
2810         (WebInspector.ScriptsPanel.prototype._stepOutClicked):
2811         * inspector/front-end/SourceView.js:
2812         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
2813         (WebInspector.SourceView.prototype.performSearch.findSearchMatches):
2814         (WebInspector.SourceView.prototype.performSearch):
2815         * inspector/front-end/StylesSidebarPane.js:
2816         (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
2817         * inspector/front-end/TestController.js:
2818         (WebInspector.TestController.prototype.notifyDone):
2819         * inspector/front-end/TimelinePanel.js:
2820         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
2821         * inspector/front-end/WatchExpressionsSidebarPane.js:
2822         (WebInspector.WatchExpressionsSection.prototype.update):
2823         (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions):
2824         (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
2825         * inspector/front-end/WebKit.qrc:
2826         * inspector/front-end/inspector.html:
2827         * inspector/front-end/inspector.js:
2828         (WebInspector.pendingDispatches.0.get platform):
2829         (WebInspector.get port):
2830         (WebInspector.set currentPanel):
2831         (WebInspector._createPanels):
2832         (WebInspector._loadPreferences):
2833         (WebInspector.set attached):
2834         (WebInspector._updateHoverHighlight):
2835         (WebInspector.loaded):
2836         (windowLoaded):
2837         (WebInspector.windowUnload):
2838         (WebInspector.close):
2839         (WebInspector.toolbarDrag):
2840         (WebInspector.UIString):
2841
2842 2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>
2843
2844         Reviewed by Dan Bernstein.
2845
2846         css2.1/t1205-c566-list-stl-00-e-ag.html is failing
2847         https://bugs.webkit.org/show_bug.cgi?id=23264
2848         css2.1/t1205-c565-list-pos-00-b.html is failing
2849         https://bugs.webkit.org/show_bug.cgi?id=23263
2850
2851         Ignore whitespaces after list markers.
2852         Rendering of this was already done for the case where inside=false.
2853         This fixes the rendering of inside=true case and calcInlinePrefWidths.
2854
2855         Test: fast/lists/calc-width-with-space.html
2856
2857         * rendering/RenderBlock.cpp:
2858         (WebCore::RenderBlock::calcInlinePrefWidths):
2859         * rendering/RenderBlockLineLayout.cpp:
2860         (WebCore::RenderBlock::findNextLineBreak):
2861
2862 2009-11-30  Fumitoshi Ukai  <ukai@chromium.org>
2863
2864         Unreviewed Chromium build fix introduced by r51212
2865
2866         Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
2867         as the first argument.
2868         Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
2869         Add debuggerWorld() and pluginWorld() in ScriptState.h.
2870
2871         * bindings/v8/ScriptController.cpp:
2872         * bindings/v8/ScriptController.h:
2873         * bindings/v8/ScriptState.cpp:
2874         (WebCore::scriptStateFromNode):
2875         (WebCore::scriptStateFromPage):
2876         (WebCore::mainThreadNormalWorld):
2877         * bindings/v8/ScriptState.h:
2878         (WebCore::debuggerWorld):
2879         (WebCore::pluginWorld):
2880
2881 2009-11-30  Enrica Casucci  <enrica@apple.com>
2882
2883         Reviewed by Darin Adler.
2884
2885         Can focus but not type into content editable block that contains only non-editable content.
2886         <rdar://problem/5982901>
2887         https://bugs.webkit.org/show_bug.cgi?id=31750
2888         
2889         The goal is to change the way we choose a visible position
2890         after hit detection, by preferring a visually equivalent editable
2891         position if available. By doing this, it is possible to add content
2892         to an editable block that initially contains only non editable elements.
2893
2894         Test: editing/selection/mixed-editability-10.html
2895
2896         * WebCore.base.exp: Changed to match the new signature of downstream
2897         and upstream in the Position class.
2898         * dom/Position.cpp:
2899         (WebCore::Position::atEditingBoundary): Added.
2900         (WebCore::Position::upstream): Modified to allow to cross the boundary
2901         between editable and non editable content if required.
2902         (WebCore::Position::downstream): Modified to allow to cross the boundary
2903         between editable and non editable content if required.
2904         (WebCore::Position::isCandidate): Modified to qualify as candidates positions
2905         that are at the editability boundary.
2906         (WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
2907         to be used in calculating the caret rectangle.
2908         * dom/Position.h:
2909         (WebCore::Position::):
2910         * dom/PositionIterator.cpp:
2911         (WebCore::PositionIterator::atEditingBoundary): Added.
2912         (WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
2913         that are at the editability boundary.
2914         * dom/PositionIterator.h:
2915         * editing/htmlediting.cpp:
2916         (WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
2917         descendants of the editable container, but the container itself.
2918         (WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
2919         descendants of the editable container, but the container itself.
2920         * rendering/RenderObject.cpp:
2921         (WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
2922         if available.
2923         * rendering/RenderText.cpp:
2924         (WebCore::RenderText::isAllCollapsibleWhitespace): Added.
2925         * rendering/RenderText.h:
2926
2927 2009-11-30  Kevin Ollivier  <kevino@theolliviers.com>
2928
2929         wx build fix, add header needed for wx build.
2930
2931         * css/CSSFontFaceSrcValue.cpp:
2932
2933 2009-11-30  Mark Rowe  <mrowe@apple.com>
2934
2935         Reviewed by David Kilzer.
2936
2937         <rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries
2938
2939         The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
2940         If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
2941         be performed against the x86_64 architecture.
2942
2943         * DerivedSources.make:
2944
2945 2009-11-30  Beth Dakin  <bdakin@apple.com>
2946
2947         Reviewed by Oliver Hunt.
2948
2949         Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in 
2950         Safari caused by extreme column-gap and column-width values 
2951         -and corresponding-
2952         <rdar://problem/7425433>
2953
2954         Prevent desiredColumnCount from being less than 1 since it is used 
2955         as a divisor.
2956         * rendering/RenderBlock.cpp:
2957         (WebCore::RenderBlock::calcColumnWidth):
2958
2959 2009-11-30  Alexey Proskuryakov  <ap@apple.com>
2960
2961         Reviewed by Oliver Hunt.
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=31659
2964         Connection must be closed in case of Web Socket handshake error
2965
2966         The network connection was closed, but the close event wasn't dispatched.
2967
2968         Tested by websocket/tests/handshake-error.html, which is un-skipped now.
2969
2970         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
2971         Call client didHandle() method. This looks strange in CFNetwork implementation, because
2972         it's the client that asked to close the stream, so it shouldn't need the callback. It makes
2973         more sense in cross-process implementation, because closing is async there.
2974
2975 2009-11-30  Gavin Barraclough  <barraclough@apple.com>
2976
2977         Reviewed by Geoff Garen.
2978
2979         Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.
2980
2981         WebCore presently has to explicitly specify the world before entering into JSC,
2982         which is a little fragile (particularly since property access via a
2983         getter/setter might invoke execution). Instead derive the current world from
2984         the lexical global object.
2985
2986         Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
2987         currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
2988         object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
2989         are no longer necessary.
2990
2991         * WebCore.base.exp:
2992         * bindings/js/JSCallbackData.cpp:
2993         (WebCore::JSCallbackData::invokeCallback):
2994         * bindings/js/JSCallbackData.h:
2995         (WebCore::JSCallbackData::JSCallbackData):
2996         * bindings/js/JSCustomXPathNSResolver.cpp:
2997         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
2998         * bindings/js/JSDOMBinding.cpp:
2999         (WebCore::currentWorld):
3000         (WebCore::mainThreadNormalWorld):
3001         * bindings/js/JSDOMBinding.h:
3002         (WebCore::WebCoreJSClientData::WebCoreJSClientData):
3003         * bindings/js/JSDOMWindowBase.cpp:
3004         (WebCore::JSDOMWindowBase::updateDocument):
3005         * bindings/js/JSDOMWindowBase.h:
3006         * bindings/js/JSEventListener.cpp:
3007         (WebCore::JSEventListener::handleEvent):
3008         (WebCore::JSEventListener::reportError):
3009         * bindings/js/JSHTMLDocumentCustom.cpp:
3010         (WebCore::JSHTMLDocument::open):
3011         * bindings/js/JSNodeFilterCondition.cpp:
3012         (WebCore::JSNodeFilterCondition::acceptNode):
3013         * bindings/js/JSQuarantinedObjectWrapper.cpp:
3014         (WebCore::JSQuarantinedObjectWrapper::construct):
3015         (WebCore::JSQuarantinedObjectWrapper::call):
3016         * bindings/js/ScheduledAction.cpp:
3017         (WebCore::ScheduledAction::executeFunctionInContext):
3018         * bindings/js/ScriptController.cpp:
3019         (WebCore::ScriptController::evaluateInWorld):
3020         (WebCore::ScriptController::initScript):
3021         (WebCore::ScriptController::updateDocument):
3022         * bindings/js/ScriptFunctionCall.cpp:
3023         (WebCore::ScriptFunctionCall::call):
3024         (WebCore::ScriptFunctionCall::construct):
3025         * bindings/js/ScriptObjectQuarantine.cpp:
3026         (WebCore::getQuarantinedScriptObject):
3027         * bindings/js/ScriptState.cpp:
3028         (WebCore::scriptStateFromNode):
3029         (WebCore::scriptStateFromPage):
3030         * bindings/js/ScriptState.h:
3031         * bindings/js/WorkerScriptController.cpp:
3032         (WebCore::WorkerScriptController::evaluate):
3033         * bindings/objc/WebScriptObject.mm:
3034         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3035         (-[WebScriptObject evaluateWebScript:]):
3036         * bridge/NP_jsobject.cpp:
3037         (_NPN_InvokeDefault):
3038         (_NPN_Invoke):
3039         (_NPN_Evaluate):
3040         (_NPN_Construct):
3041         * bridge/jni/jni_jsobject.mm:
3042         (JavaJSObject::call):
3043         (JavaJSObject::eval):
3044         * dom/NodeFilter.h:
3045         (WebCore::NodeFilter::acceptNode):
3046         * dom/NodeIterator.h:
3047         (WebCore::NodeIterator::nextNode):
3048         (WebCore::NodeIterator::previousNode):
3049         * dom/TreeWalker.h:
3050         (WebCore::TreeWalker::parentNode):
3051         (WebCore::TreeWalker::firstChild):
3052         (WebCore::TreeWalker::lastChild):
3053         (WebCore::TreeWalker::previousSibling):
3054         (WebCore::TreeWalker::nextSibling):
3055         (WebCore::TreeWalker::previousNode):
3056         (WebCore::TreeWalker::nextNode):
3057         * inspector/InspectorController.cpp:
3058         (WebCore::InspectorController::windowScriptObjectAvailable):
3059         (WebCore::InspectorController::didEvaluateForTestInFrontend):
3060         * inspector/JavaScriptCallFrame.cpp:
3061         (WebCore::JavaScriptCallFrame::evaluate):
3062
3063 2009-11-30  Eric Carlson  <eric.carlson@apple.com>
3064
3065         Reviewed by Simon Fraser.
3066
3067         All HTML5 media element events should be regular events
3068         https://bugs.webkit.org/show_bug.cgi?id=30513
3069
3070         * html/HTMLMediaElement.cpp:
3071         (WebCore::HTMLMediaElement::selectMediaResource):
3072         (WebCore::HTMLMediaElement::noneSupported):
3073         (WebCore::HTMLMediaElement::mediaEngineError):
3074         (WebCore::HTMLMediaElement::setNetworkState):
3075         (WebCore::HTMLMediaElement::userCancelledLoad):
3076             Call scheduleEvent instead of scheduleProgressEvent.
3077         (WebCore::HTMLMediaElement::progressEventTimerFired):
3078             Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
3079             after scheduling a 'progress' event so the controller will update download
3080             progress indicator.
3081         * html/HTMLMediaElement.h:
3082             Remove scheduleProgressEvent prototype.
3083
3084 2009-11-30  Joseph Pecoraro  <joepeck@webkit.org>
3085
3086         Reviewed by Pavel Feldman.
3087
3088         Web Inspector: Wrong console output for Regexp escape sequence
3089         https://bugs.webkit.org/show_bug.cgi?id=31538
3090
3091         Updated inspector/console-format.html
3092
3093         * inspector/front-end/ConsoleView.js:
3094         (WebInspector.ConsoleView.createDividerElement): style issues.
3095         (WebInspector.ConsoleView.createFilterElement): style issues.
3096         (WebInspector.ConsoleView): added _customFormatters table.
3097         (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
3098         (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
3099         (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
3100         (WebInspector.ConsoleView.prototype._formatobject):
3101         (WebInspector.ConsoleView.prototype._formatnode):
3102         (WebInspector.ConsoleView.prototype._printArray):
3103         (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
3104         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
3105         (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
3106         (WebInspector.ConsoleCommandResult):
3107         * inspector/front-end/InjectedScript.js: simplified regex formatting.
3108         * inspector/front-end/inspector.js:
3109         (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
3110         * inspector/front-end/utilities.js: 
3111         (Element.prototype.hasStyleClass): update inaccurate comment.
3112         (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
3113
3114 2009-11-30  Erik Arvidsson  <arv@chromium.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
3119         https://bugs.webkit.org/show_bug.cgi?id=31895
3120
3121         No new tests. This is already covered by:
3122                 fast/dom/CSSStyleDeclaration/css-computed-style-item.html
3123                 fast/dom/CSSStyleDeclaration/css-style-item.html
3124
3125         * bindings/v8/V8Collection.h:
3126         (WebCore::collectionStringIndexedPropertyGetter):
3127         (WebCore::setCollectionStringIndexedGetter):
3128         * bindings/v8/V8DOMWrapper.cpp:
3129         (WebCore::V8DOMWrapper::getTemplate):
3130
3131 2009-11-30  Steve Block  <steveblock@google.com>
3132
3133         Reviewed by Eric Seidel.
3134
3135         Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
3136         https://bugs.webkit.org/show_bug.cgi?id=31932
3137
3138         Build fix only, no new tests.
3139
3140         * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
3141
3142 2009-11-30  Steve Block  <steveblock@google.com>
3143
3144         Reviewed by Eric Seidel.
3145
3146         Adds PassOwnPtr include to ScriptExecutionContext.h.
3147         https://bugs.webkit.org/show_bug.cgi?id=31929
3148
3149         Build fix only, no new tests.
3150
3151         * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
3152
3153 2009-11-30  Dirk Schulze  <krit@webkit.org>
3154
3155         Reviewed by Nikolas Zimmermann.
3156
3157         REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
3158         [https://bugs.webkit.org/show_bug.cgi?id=31980]
3159
3160         It turns out, that we did not handle maskUnits="userSpaceOnUse"
3161         correctly. We just need to move the context of the maskImage
3162         if maskContentUnits="objectBoundingBox". The context gets scaled
3163         on this unit combination, so we have to substract the position of
3164         the targetRect. On userSpaceOnUse the position just depends on the
3165         position of the mask element.
3166         I added a test with some senseless and reasonable values for size
3167         and postion of the mask and it's contents. I also used every
3168         combination of maskUnits and maskContentUnits to be sure, that it
3169         is fixed this time.
3170
3171         Test: svg/custom/mask-with-all-units.svg
3172
3173         * svg/SVGMaskElement.cpp:
3174         (WebCore::SVGMaskElement::drawMaskerContent):
3175
3176 2009-11-30  Steve Block  <steveblock@google.com>
3177
3178         Reviewed by Eric Seidel.
3179
3180         Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
3181         https://bugs.webkit.org/show_bug.cgi?id=31928
3182
3183         Build fix only, no new tests.
3184
3185         * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
3186
3187 2009-11-30  Steve Block  <steveblock@google.com>
3188
3189         Reviewed by Eric Seidel.
3190
3191         Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
3192         https://bugs.webkit.org/show_bug.cgi?id=31926
3193
3194         Build fix only, no new tests.
3195
3196         * bindings/v8/WorkerContextExecutionProxy.cpp:
3197         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
3198         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
3199         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
3200
3201 2009-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3202
3203         Reviewed by Kenneth Rohde Christiansen.
3204
3205         Chrome::contentsSizeChanged() is called when the content size has not changed
3206         https://bugs.webkit.org/show_bug.cgi?id=31978
3207
3208         Do not trigger contentsSizeChaned() is the new size is the same as the old one.
3209
3210         * page/FrameView.cpp:
3211         (WebCore::FrameView::setContentsSize):
3212
3213 2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3214
3215         Reviewed by Kenneth Rohde Christiansen.
3216
3217         [Qt] Fix some compiler warnings seen on QtWebKit/Mac
3218         https://bugs.webkit.org/show_bug.cgi?id=31962
3219
3220         No new tests as there is no functional change.
3221
3222         * platform/network/ResourceHandle.h: Make destructor virtual as 
3223         after r50772 ResourceHandle has virtual functions.
3224
3225         * plugins/mac/PluginPackageMac.cpp: 
3226         (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
3227         not a label
3228
3229         * plugins/mac/PluginViewMac.cpp:
3230         (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
3231         specifier
3232
3233 2009-11-30  Xan Lopez  <xlopez@igalia.com>
3234
3235         Reviewed by Gustavo Noronha.
3236
3237         Add new headers to sources list.
3238
3239         * GNUmakefile.am:
3240
3241 2009-11-30  Girish Ramakrishnan  <girish@forwardbias.in>
3242
3243         Reviewed by Holger Freyther.
3244
3245         [Qt] Mac Plugins : Get context menu to work in QGraphicsView
3246         
3247         Flash expects the value in record.where to be the global position for
3248         displaying the context menu.
3249         
3250         https://bugs.webkit.org/show_bug.cgi?id=31979
3251
3252         * plugins/mac/PluginViewMac.cpp:
3253         (WebCore::PluginView::handleMouseEvent):
3254
3255 2009-11-30  Steve Block  <steveblock@google.com>
3256
3257         Reviewed by Eric Seidel.
3258
3259         Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
3260         https://bugs.webkit.org/show_bug.cgi?id=31925
3261
3262         This code uses ChromiumBridge and Chromium-specific constant values not
3263         appropriate for other platforms such as Android.
3264
3265         Build fix only, no new tests.
3266
3267         * bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
3268
3269 2009-11-29  Brent Fulgham  <bfulgham@webkit.org>
3270
3271         Build fix.
3272
3273         Correct draw signature used in ImageCairoWin.cpp.
3274
3275         * platform/graphics/win/ImageCairoWin.cpp:
3276         (WebCore::BitmapImage::getHBITMAPOfSize):
3277         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
3278
3279 2009-11-28  Oliver Hunt  <oliver@apple.com>
3280
3281         Reviewed by Sam Weinig.
3282
3283         postMessage should serialize File objects
3284         https://bugs.webkit.org/show_bug.cgi?id=31955
3285
3286         Update SerializedScriptValue to include support for
3287         File objects in the serialized object graph.
3288
3289         * bindings/js/SerializedScriptValue.cpp:
3290         (WebCore::SerializedScriptValueData::SerializedScriptValueData):
3291         (WebCore::SerializingTreeWalker::convertIfTerminal):
3292         (WebCore::DeserializingTreeWalker::convertIfTerminal):
3293         * bindings/js/SerializedScriptValue.h:
3294         (WebCore::SerializedScriptValueData::):
3295         (WebCore::SerializedScriptValueData::asString):
3296
3297 2009-11-29  Simon Fraser  <simon.fraser@apple.com>
3298
3299         Reviewed by Dan Bernstein.
3300
3301         Optimize the hierarchy rebuilding of compositing layers
3302         https://bugs.webkit.org/show_bug.cgi?id=31879
3303         
3304         When updating the compositing layer hierarchy, instead of removing all
3305         child layers and then re-adding them one by one, build a vector of child
3306         layers, and set them in one go.
3307         
3308         * platform/graphics/GraphicsLayer.h:
3309         * platform/graphics/GraphicsLayer.cpp:
3310         (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child
3311         GraphicsLayers.
3312         
3313         * platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
3314         * platform/graphics/win/GraphicsLayerCACF.h: Ditto.
3315         * platform/graphics/mac/GraphicsLayerCA.mm: 
3316         (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to 
3317         set the bit that notes that sublayers changed.
3318         * platform/graphics/win/GraphicsLayerCACF.cpp:
3319         (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to 
3320         udpate sublayers, with a note that this is not efficient.
3321         
3322         * rendering/RenderLayerCompositor.h:
3323         * rendering/RenderLayerCompositor.cpp:
3324         (WebCore::RenderLayerCompositor::updateCompositingLayers):
3325         When updating compositing layers, use the faster updateLayerTreeGeometry() if
3326         we know that no layer hierarchy changes are needed, and, at the root, use
3327         the vector returned from rebuildCompositingLayerTree() to attach the root
3328         layer.
3329         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to
3330         collect child layers into Vectors of GraphicsLayers, which can be set as
3331         layer children in one go.
3332         (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from
3333         rebuildCompositingLayerTree() for simplicity, and called when we just need to
3334         update layer geometry, without doing any reparenting.
3335
3336 2009-11-29  Daniel Bates  <dbates@webkit.org>
3337
3338         Reviewed by Adam Barth.
3339
3340         https://bugs.webkit.org/show_bug.cgi?id=31971
3341
3342         Updated comment to reflect latest XSSAuditor bindings.
3343
3344         No functionality was changed. So, no new tests.
3345
3346         * page/XSSAuditor.h:
3347
3348 2009-11-29  Daniel Bates  <dbates@webkit.org>
3349
3350         Reviewed by Eric Seidel.
3351
3352         https://bugs.webkit.org/show_bug.cgi?id=31969
3353
3354         Removes unnecessary #include files.
3355
3356         No functionality was changed. So, no new tests.
3357
3358         * css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and
3359         Pair.h
3360         * css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
3361         * css/CSSFontFaceSrcValue.cpp: Removed include Node.h
3362         * css/CSSFontSelector.cpp: Removed include NodeList.h
3363         * css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
3364         * css/CSSImageValue.cpp: Removed include RenderStyle.h
3365         * css/CSSImportRule.cpp: Removed include MediaList.h
3366         * css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
3367         * css/CSSRule.cpp: Removed include CSSStyleSheet.h
3368         * css/CSSStyleSelector.cpp: Removed include CSSFontFace.h,
3369         CSSFontFaceSource.h, and CSSProperty.h
3370         * page/EventSource.h: Removed include EventListener.h
3371
3372 2009-11-29  Daniel Bates  <dbates@webkit.org>
3373
3374         Reviewed by Eric Seidel.
3375
3376         https://bugs.webkit.org/show_bug.cgi?id=31965
3377
3378         Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
3379         forward declared it.
3380
3381         As a side effect, we need to #include KeyframeList.h in
3382         RenderLayerBacking.cpp.
3383
3384         No functionality was changed. So, no new tests.
3385
3386         * css/CSSStyleSelector.cpp:
3387         * css/CSSStyleSelector.h: Removed #include KeyframeList.h
3388         * rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h
3389
3390 2009-11-29  Shu Chang  <Chang.Shu@nokia.com>
3391
3392         Reviewed by Eric Seidel.
3393
3394         Continue to search for matching node in the case where multiple nodes
3395         have the same id.
3396         https://bugs.webkit.org/show_bug.cgi?id=31428
3397
3398         Test: fast/dom/Element/id-in-node-list-index01.html
3399
3400         * dom/DynamicNodeList.cpp:
3401         (WebCore::DynamicNodeList::itemWithName):
3402
3403 2009-11-29  Daniel Bates  <dbates@webkit.org>
3404
3405         Reviewed by Eric Seidel.
3406
3407         https://bugs.webkit.org/show_bug.cgi?id=31966
3408
3409         Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
3410         forward declared it.
3411
3412         No functionality was changed. So, no new tests.
3413
3414         * page/animation/KeyframeAnimation.cpp:
3415         * page/animation/KeyframeAnimation.h:
3416
3417 2009-11-29  Daniel Bates  <dbates@webkit.org>
3418
3419         Unreviewed, fix change log entry date.
3420
3421         For some reason, bugzilla-tool did not update the date in the change
3422         log entry for my last commit (r51468). So, this commit fixes the date
3423         of that entry.
3424
3425 2009-11-29  Daniel Bates  <dbates@webkit.org>
3426
3427         Reviewed by Dan Bernstein.
3428
3429         https://bugs.webkit.org/show_bug.cgi?id=31964
3430
3431         Removed #include StringImpl, StyleImage. Instead, forward declared them.
3432         Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
3433         since it seems we only really used it to include PassRefPtr.h.
3434
3435         No functionality was changed. So, no new tests.
3436
3437         * rendering/style/ContentData.h:
3438
3439 2009-11-29  Zoltan Horvath  <zoltan@webkit.org>
3440
3441         Reviewed by Eric Seidel.
3442
3443         Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
3444         https://bugs.webkit.org/show_bug.cgi?id=31906
3445
3446         Inherits the following classes from Noncopyable because these are instantiated
3447         by 'new' and no need to be copyable:
3448
3449         class/struct name               - instantiated at: WebCore/'location'
3450
3451         class SQLTransactionClient      - storage/DatabaseThread.cpp:45
3452         class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
3453         class OriginUsageRecord         - storage/OriginQuotaManager.cpp:66
3454         class DatabaseTracker           - storage/DatabaseTracker.cpp:62
3455         class ScrollbarTheme            - (its child class) rendering/RenderScrollbarTheme.cpp:35
3456         class RenderSelectionInfoBase   - (its child class) rendering/RenderView.cpp:310
3457         class RenderOverflow            - rendering/RenderBox.cpp:2846
3458
3459         Inherits the following classes from FastAllocBase because these are instantiated by 'new':
3460
3461         struct FillLayer                - css/CSSStyleSelector.cpp:197
3462         struct ShadowData               - rendering/style/ShadowData.cpp:35
3463         class CounterContent            - css/CSSStyleSelector.cpp:4111
3464
3465         * platform/ScrollbarTheme.h:
3466         * rendering/RenderOverflow.h:
3467         * rendering/RenderSelectionInfo.h:
3468         * rendering/style/CounterContent.h:
3469         * rendering/style/FillLayer.h:
3470         * rendering/style/ShadowData.h:
3471         * storage/DatabaseTracker.h:
3472         * storage/OriginUsageRecord.h:
3473         * storage/SQLTransactionClient.h:
3474         * storage/SQLTransactionCoordinator.h:
3475
3476 2009-11-28  Adam Barth  <abarth@webkit.org>
3477
3478         Reviewed by Dimitri Glazkov.
3479
3480         [Chromium] Sify compose button alerts error
3481         https://bugs.webkit.org/show_bug.cgi?id=31394
3482
3483         Test: http/tests/security/calling-versus-current.html
3484
3485         We're supposed to use the calling context for security checks.  In JSC
3486         land, this is the lexicalGlobalObject.
3487
3488         * bindings/v8/V8Proxy.cpp:
3489         (WebCore::V8Proxy::canAccessPrivate):
3490
3491 2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>
3492
3493         Unreviewed Chromium build fix introduced by r51428.
3494
3495         [Chromium] Ignore line-height CSS property for PushButton
3496         https://bugs.webkit.org/show_bug.cgi?id=31712
3497
3498         * rendering/RenderThemeChromiumSkia.cpp:
3499         (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
3500
3501 2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>
3502
3503         Unreviewed Chromium test fix by reverting r51413.
3504
3505         [v8] Do not check the thread when accessing DOMDataStore
3506         https://bugs.webkit.org/show_bug.cgi?id=31877
3507
3508         * bindings/v8/V8DOMMap.cpp:
3509         (WebCore::getDOMNodeMap):
3510         (WebCore::getDOMObjectMap):
3511         (WebCore::getActiveDOMObjectMap):
3512         (WebCore::getDOMSVGElementInstanceMap):
3513         (WebCore::getDOMSVGObjectWithContextMap):
3514
3515 2009-11-27  Daniel Bates  <dbates@webkit.org>
3516
3517         Unreviewed, comment fix.
3518
3519         Corrected misspelling of the word "implemented".
3520
3521         * inspector/front-end/InjectedScriptAccess.js:
3522
3523 2009-11-27  Daniel Bates  <dbates@webkit.org>
3524
3525         Reviewed by Adam Barth.
3526
3527         https://bugs.webkit.org/show_bug.cgi?id=31940
3528
3529         Makes the error messages more descriptive when we refuse to load an object/embed or
3530         refuse to load from the document base URL.
3531
3532         * page/XSSAuditor.cpp:
3533         (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive.
3534         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
3535
3536 2009-11-27  Yury Semikhatsky  <yurys@chromium.org>
3537
3538         Reviewed by Pavel Feldman.
3539
3540         This is a WebCore part of the fix that allows to view plugin
3541         resources loaded by plugins.
3542
3543         https://bugs.webkit.org/show_bug.cgi?id=31832
3544
3545         * inspector/InspectorController.cpp:
3546         (WebCore::InspectorController::willSendRequest):
3547         (WebCore::InspectorController::didReceiveResponse):
3548         (WebCore::InspectorController::didReceiveContentLength):
3549         (WebCore::InspectorController::didFinishLoading):
3550         (WebCore::InspectorController::didFailLoading):
3551         * inspector/InspectorController.h:
3552         * inspector/InspectorResource.cpp:
3553         (WebCore::InspectorResource::addLength):
3554         * loader/ResourceLoadNotifier.cpp:
3555         (WebCore::ResourceLoadNotifier::didFailToLoad):
3556         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3557         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
3558         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
3559         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
3560
3561 2009-11-27  Yury Semikhatsky  <yurys@chromium.org>
3562
3563         Reviewed by Pavel Feldman.
3564
3565         Instead of generating negative identifiers for cached resources in
3566         InspectorController and extending identifier type from 'unsigned long' to 'long
3567         long' reuse progress tracker from the inspected page to generate those
3568         identifiers. It guarantees that InspectorResources have unique ids since
3569         all of them are generated by that progress tracker.
3570
3571         Added a couple new overloaded methods to Script* objects that accept
3572         long and unsigned long arguments. These types of argumens have already
3573         been passed as long long.
3574
3575         https://bugs.webkit.org/show_bug.cgi?id=31921
3576
3577         * bindings/js/ScriptFunctionCall.cpp:
3578         (WebCore::ScriptFunctionCall::appendArgument):
3579         * bindings/js/ScriptFunctionCall.h:
3580         * bindings/js/ScriptObject.cpp:
3581         (WebCore::ScriptObject::set):
3582         * bindings/js/ScriptObject.h: