806a211540f63b496eeefdec83d2342722789ded
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-05  Darin Adler  <darin@apple.com>
2
3         - quick attempt to fix the no-SVG build
4
5         * platform/graphics/svg/SVGResource.cpp:
6         * platform/graphics/svg/SVGResource.h:
7         * platform/graphics/svg/SVGResourceClipper.cpp:
8         * platform/graphics/svg/SVGResourceClipper.h:
9         * platform/graphics/svg/SVGResourceImage.h:
10         * platform/graphics/svg/SVGResourceMarker.cpp:
11         * platform/graphics/svg/SVGResourceMarker.h:
12         * platform/graphics/svg/SVGResourceMasker.cpp:
13         * platform/graphics/svg/SVGResourceMasker.h:
14         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
15         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
16         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
17         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
18         Added #ifdef SVG_SUPPORT to these files.
19
20 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
21
22         Reviewed & landed by Maciej.
23
24         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
25
26         * platform/win/ResourceLoaderWin.cpp:
27         (WebCore::transferJobStatusCallback):
28         (WebCore::ResourceLoader::start):
29
30 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
31
32         Reviewed by Oliver.
33
34         - moved FormData and FormDataStream to platform/network directory
35
36         * WebCore.xcodeproj/project.pbxproj:
37         * bridge/mac/WebCoreFrameBridge.mm:
38         * loader/FormData.cpp: Removed.
39         * loader/FormData.h: Removed.
40         * loader/mac/FormDataStream.h: Removed.
41         * loader/mac/FormDataStream.m: Removed.
42         * loader/mac/FrameLoaderMac.mm:
43         * loader/mac/SubresourceLoaderMac.mm:
44         * platform/network/mac/FormDataStreamMac.h: Added.
45         * platform/network/mac/FormDataStreamMac.mm: Added.
46         * platform/network/mac/ResourceRequestMac.mm:
47
48 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
49
50         Fix build breaks
51
52         * loader/DocumentLoader.h:
53         * platform/win/ScreenWin.cpp:
54
55 2006-11-05  Darin Adler  <darin@apple.com>
56
57         Reviewed by Geoff.
58
59         - more preparation for splitting up Frame into sub-pieces
60         - removed unnecessary includes from Frame.h
61
62         * page/Frame.h: Removed unneeded includes and forward declarations.
63         Added additional forward declarations. Removed the constant
64         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
65         Created sections of functions to be moved into Chrome, Editor,
66         EventHandler, FrameLoader, SelectionController, and the Platform
67         directory, as well as marking one function for deletion.
68
69         * page/FramePrivate.h: Removed the definition of the constructor and
70         destructor and removed unnecessary includes.
71
72         * page/FrameView.h: Removed unneeded forward declarations and friend
73         declarations. Created a section of functions and data to be moved into
74         EventHandler.
75
76         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
77         Created sections of functions and data to be moved into Chrome,
78         Editor, EventHandler, FrameLoader, and the Platform directory.
79
80         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
81         Removed unused methods areScrollbarsVisible,
82         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
83
84         * page/Frame.cpp:
85         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
86         to include KURL.h just for the KURL default constructor.
87         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
88         (WebCore::FramePrivate::~FramePrivate): Ditto.
89
90         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
91         booleans, scrollbarMoved and cleared funcitons.
92         (WebCore::FrameView::clear): Moved the code from the cleared
93         function in here.
94         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
95
96         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
97         for changes to header.
98
99         * editing/SelectionController.cpp:
100         (WebCore::SelectionController::setSelection):
101         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
102         Moved NoXPosForVerticalArrowNavigation into this file.
103
104         * bindings/js/kjs_events.cpp:
105         * bindings/js/kjs_html.cpp:
106         * bindings/js/kjs_window.cpp:
107         * bridge/mac/WebCoreAXObject.mm:
108         * bridge/mac/WebCoreFrameBridge.mm:
109         * css/cssstyleselector.cpp:
110         * dom/Document.cpp:
111         * dom/Element.cpp:
112         * dom/EventTargetNode.cpp:
113         * dom/MouseRelatedEvent.cpp:
114         * dom/XMLTokenizer.cpp:
115         * html/HTMLBaseElement.cpp:
116         * html/HTMLDocument.cpp:
117         * html/HTMLEmbedElement.cpp:
118         * html/HTMLFrameElementBase.cpp:
119         * html/HTMLGenericFormElement.cpp:
120         * html/HTMLObjectElement.cpp:
121         * html/HTMLTokenizer.cpp:
122         * loader/mac/FrameLoaderMac.mm:
123         * page/PageState.cpp:
124         * rendering/RenderApplet.cpp:
125         * rendering/RenderBlock.cpp:
126         * rendering/RenderLayer.cpp:
127         * rendering/RenderObject.cpp:
128         * rendering/RenderPartObject.cpp:
129         * rendering/RenderTreeAsText.cpp:
130         * xml/XSLTProcessor.cpp:
131         Added includes as needed to keep compiling, since there are fewer
132         includes in Frame.h.
133
134 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
135
136         Reviewed by Dave Harrison.
137
138         http://bugs.webkit.org/show_bug.cgi?id=11402
139         REGRESSION: onChange does not work anymore for 1st item in popup
140
141         * html/HTMLSelectElement.cpp:
142         (WebCore::HTMLSelectElement::HTMLSelectElement):
143         (WebCore::HTMLSelectElement::reset):
144         Set m_lastOnChangeIndex to -1.
145
146 2006-11-04  Darin Adler  <darin@apple.com>
147
148         Reviewed by Anders.
149
150         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
151           REGRESSION: Status bar always shows cancelled opening the page
152
153         * platform/network/mac/ResourceHandleMac.mm:
154         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
155         Since the subresource owns the resource handle, there's no need to cancel.
156         This arrangement is only temporary, anyway, since Maciej will soon change
157         things so that the subresource loader uses the resource handle and the
158         resource handle doesn't know anything about the subresource loader.
159
160 2006-11-04  Darin Adler  <darin@apple.com>
161
162         Reviewed by Maciej.
163
164         - converted more of the loader machinery to work with cross-platform
165           data structures instead of Macintosh-specific ones
166
167           converted most uses of NSURL to KURL and NSEvent to DOM Event in
168           loader classes
169
170           moved download function out of FrameLoader.h to avoid reference to
171           NSURLConnection
172
173           added DOM Event parameters to various functions so that the handlers
174           can use the DOM Event instead of the global "current NSEvent";
175           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
176           HTMLFormElement::submit, FrameLoader::load
177
178           moved the setMainFrame call that hands ownership to the Page
179           into one of the Frame constructors, and removed it from all
180           the clients
181
182           removed const from Event parameter to the urlSelected function
183           (we rarely use const with DOM elements)
184
185           removed some redundant includes and declarations from various
186           header files
187
188           removed NSURL parameter from userAgent function -- if we need it we
189           can add it back, but converting from NSURL to KURL and back is
190           inefficient enough that it's best to have it out for now (since it's
191           been unused for years) -- if we add it back, we can choose an
192           appropriate parameter type that's always inexpensive to pass
193
194           did some basic cleanup in the IconLoader class, including removing
195           an unnecessary loop that added icon data a byte at a time
196
197           renamed safeLoad to load, since it's no different from the other
198           FrameLoader load functions, safety-wise
199
200           fixed some code that was trying to distinguish null frame name from
201           empty string frame name -- both should be handled the same, but callers
202           were doing it by checking for empty and turning it into null (in a way
203           that was causing extra round trips between NSString and WebCore::String)
204
205           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
206           and got rid of case-insensitive compares of methods
207
208         * WebCore.exp:
209         * WebCore.xcodeproj/project.pbxproj:
210         * bindings/js/kjs_navigator.cpp:
211         (KJS::Navigator::getValueProperty):
212         * bridge/mac/FrameMac.h:
213         * bridge/mac/FrameMac.mm:
214         (WebCore::FrameMac::submitForm):
215         (WebCore::FrameMac::urlSelected):
216         (WebCore::FrameMac::userAgent):
217         * bridge/mac/FrameViewMac.mm:
218         * bridge/mac/WebCoreAXObject.mm:
219         (-[WebCoreAXObject rendererForView:]):
220         * bridge/mac/WebCorePageBridge.h:
221         * bridge/mac/WebCorePageBridge.mm:
222         * bridge/mac/WebCoreSettings.mm:
223         * bridge/win/FrameWin.cpp:
224         (WebCore::FrameWin::urlSelected):
225         (WebCore::FrameWin::submitForm):
226         * bridge/win/FrameWin.h:
227         * dom/MouseRelatedEvent.cpp:
228         * dom/MouseRelatedEvent.h:
229         * dom/UIEvent.cpp:
230         (WebCore::UIEvent::~UIEvent):
231         * dom/UIEvent.h:
232         * dom/UIEventWithKeyState.h:
233         * dom/XMLTokenizer.cpp:
234         (WebCore::openFunc):
235         * html/HTMLAnchorElement.cpp:
236         (WebCore::HTMLAnchorElement::defaultEventHandler):
237         * html/HTMLButtonElement.cpp:
238         (WebCore::HTMLButtonElement::defaultEventHandler):
239         * html/HTMLFormElement.cpp:
240         (WebCore::HTMLFormElement::submitClick):
241         (WebCore::HTMLFormElement::prepareSubmit):
242         (WebCore::HTMLFormElement::submit):
243         * html/HTMLFormElement.h:
244         * html/HTMLInputElement.cpp:
245         (WebCore::HTMLInputElement::defaultEventHandler):
246         * html/HTMLSelectElement.cpp:
247         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
248         * loader/DocumentLoader.h:
249         * loader/FrameLoader.h:
250         * loader/FrameLoaderClient.h:
251         * loader/NavigationAction.h:
252         (WebCore::NavigationAction::event):
253         * loader/icon/IconLoader.cpp:
254         (WebCore::IconLoader::create):
255         (WebCore::IconLoader::startLoading):
256         (WebCore::IconLoader::didReceiveData):
257         (WebCore::IconLoader::didFinishLoading):
258         * loader/icon/IconLoader.h:
259         * loader/loader.cpp:
260         * loader/mac/DocumentLoaderMac.mm:
261         (WebCore::DocumentLoader::URL):
262         (WebCore::DocumentLoader::unreachableURL):
263         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
264         (WebCore::DocumentLoader::URLForHistory):
265         * loader/mac/FrameLoaderMac.mm:
266         (WebCore::FrameLoader::load):
267         (WebCore::FrameLoader::willSendRequest):
268         (WebCore::FrameLoader::clientRedirected):
269         (WebCore::FrameLoader::shouldReload):
270         (WebCore::FrameLoader::notifyIconChanged):
271         (WebCore::FrameLoader::URL):
272         (WebCore::FrameLoader::reloadAllowingStaleData):
273         (WebCore::FrameLoader::reload):
274         (WebCore::FrameLoader::didChangeTitle):
275         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
276         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
277         (WebCore::FrameLoader::post):
278         (WebCore::FrameLoader::addExtraFieldsToRequest):
279         (WebCore::FrameLoader::loadResourceSynchronously):
280         * loader/mac/IconLoaderMac.mm:
281         (WebCore::IconLoader::notifyIconChanged):
282         * loader/mac/LoaderFunctionsMac.mm:
283         * loader/mac/MainResourceLoaderMac.mm:
284         (WebCore::shouldLoadAsEmptyDocument):
285         (WebCore::MainResourceLoader::continueAfterContentPolicy):
286         * loader/mac/NavigationActionMac.mm:
287         (WebCore::navigationType):
288         (WebCore::NavigationAction::NavigationAction):
289         * loader/mac/ResourceLoaderMac.mm:
290         * loader/mac/SubresourceLoaderMac.mm:
291         * page/Frame.cpp:
292         (WebCore::Frame::Frame):
293         (WebCore::Frame::urlSelected):
294         (WebCore::Frame::submitFormAgain):
295         (WebCore::Frame::submitForm):
296         (WebCore::Frame::endIfNotLoading):
297         (WebCore::Frame::hitTestResultAtPoint):
298         * page/Frame.h:
299         * page/FramePrivate.h:
300         * platform/gdk/FrameGdk.cpp:
301         (WebCore::FrameGdk::FrameGdk):
302         (WebCore::FrameGdk::submitForm):
303         (WebCore::FrameGdk::urlSelected):
304         * platform/gdk/FrameGdk.h:
305         * platform/mac/TextFieldMac.mm:
306         * platform/network/HTTPHeaderMap.h:
307         * platform/network/ResourceHandle.h:
308         * platform/network/ResourceHandleClient.h:
309         * platform/network/ResourceHandleInternal.h:
310         * platform/network/mac/ResourceHandleMac.mm:
311         * platform/network/mac/ResourceResponseMac.h:
312         * platform/network/mac/ResourceResponseMac.mm:
313         (-[NSURLResponse WebCore]):
314         * platform/network/win/ResourceHandleWin.cpp:
315         * platform/qt/FrameQt.cpp:
316         (WebCore::FrameQt::submitForm):
317         (WebCore::FrameQt::urlSelected):
318         * platform/qt/FrameQt.h:
319         * rendering/RenderLineEdit.cpp:
320         (WebCore::RenderLineEdit::returnPressed):
321         * xml/XSLTProcessor.cpp:
322         (WebCore::docLoaderFunc):
323         * xml/xmlhttprequest.cpp:
324
325 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
326
327         Reviewed by Adele.
328
329         - replaced receivedRedirect with new willSendRequest delegate
330         - removed most mac-specific loader functions
331         - use ResourceResponse more in loader code
332
333         * WebCore.xcodeproj/project.pbxproj: Add new files.
334         * bridge/mac/WebCoreFrameBridge.mm:
335         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
336         for CachedResource method renames.
337         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
338         Ditto.
339         * loader/CachedCSSStyleSheet.cpp:
340         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
341         based on ResourceResponse
342         * loader/CachedImage.cpp:
343         (WebCore::CachedImage::createImage): adapt for ResourceResponse
344         * loader/CachedResource.cpp:
345         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
346         platform response is now called platformResponse and expiration date
347         is removed.
348         (WebCore::CachedResource::~CachedResource): ditto
349         (WebCore::CachedResource::isExpired): ditto
350         * loader/CachedResource.h:
351         (WebCore::CachedResource::platformResponse): ditto
352         (WebCore::CachedResource::setResponse): ditto
353         (WebCore::CachedResource::canDelete): ditto
354         * loader/LoaderFunctions.h:
355         * loader/loader.cpp:
356         (WebCore::Loader::receivedResponse): Adjusted for renames.
357         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
358         in the CachedResource.
359         * loader/loader.h:
360         * loader/mac/FormDataStream.h:
361         * loader/mac/FormDataStream.m:
362         (WebCore::getStreamFormDatas): Rearranged things so it's
363         possible to get a FormData back out of a form data stream.
364         (WebCore::formCreate): ditto
365         (WebCore::formFinalize): ditto
366         (WebCore::httpBodyFromStream): ditto
367         * loader/mac/ImageDocumentMac.mm:
368         (WebCore::finishImageLoad): s/response/platformResponse/
369         * loader/mac/LoaderFunctionsMac.mm:
370         (WebCore::CheckCacheObjectStatus): ditto
371         (WebCore::CachedResource::setPlatformResponse): ditto
372         * loader/mac/SubresourceLoaderMac.mm:
373         (WebCore::SubresourceLoader::willSendRequest): send redirect
374         to client appropriately
375         * platform/network/ResourceHandle.h:
376         * platform/network/ResourceHandleClient.h:
377         (WebCore::ResourceHandleClient::willSendRequest): new entry
378         point for SubresourceLoader, dispatch to client.
379         * platform/network/ResourceRequest.h:
380         (WebCore::ResourceRequest::allowHTTPCookies): implemented
381         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
382         * platform/network/ResourceResponse.h:
383         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
384         date(!)
385         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
386         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
387         (WebCore::openNextStream): ditto
388         (WebCore::formCreate): ditto
389         (WebCore::formFinalize): ditto
390         (WebCore::formCanRead): ditto
391         (WebCore::formEventCallback): ditto
392         (WebCore::setHTTPBody): ditto
393         (WebCore::httpBodyFromStream): ditto
394         * platform/network/cf/FormDataStreamCFNet.h: Added.
395         * platform/network/cf/ResourceHandleCFNet.cpp:
396         (WebCore::willSendRequest): implemented
397         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
398         * platform/network/cf/ResourceResponseCFNet.cpp:
399         (WebCore::getResourceResponse): do nothing for a null response
400         * platform/network/mac/ResourceHandleMac.mm:
401         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
402         * platform/network/mac/ResourceRequestMac.h: Added.
403         * platform/network/mac/ResourceRequestMac.mm: Added.
404         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
405         to a ResourceRequest.
406         (WebCore::nsURLRequest): Opposite of the above.
407         * platform/network/cf/ResourceRequestCFNet.h: Added.
408         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
409         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
410         to a ResourceRequest.
411         (WebCore::cfURLRequest): Opposite of the above.
412         * xml/xmlhttprequest.cpp:
413         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
414         adjusted.
415         * xml/xmlhttprequest.h:
416
417 2006-11-04  Darin Adler  <darin@apple.com>
418
419         Change suggested by Mitz.
420
421         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
422           REGRESSION (r17438): Repro crash when opening a web archive
423
424         * bridge/mac/WebCorePageState.mm:
425         (-[WebCorePageState dealloc]): Add null check.
426         (-[WebCorePageState finalize]): Ditto.
427
428 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
429
430         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
431
432         http://bugs.webkit.org/show_bug.cgi?id=11433
433         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
434
435         * WebCore.vcproj/WebCore/WebCore.vcproj:
436         Added platform/graphics platform/network and platform/network/win to headers search paths
437         Created platform/graphics and platform/network filters in hierarchy
438         Moved GraphicsContext and GraphicsTypes to their respective filters
439         Added EditorClient.h
440         Added FrameLoader* files in loader/
441         Added HitTest* files in rendering/
442         Added Editor.* files in editing/
443         Added DeleteButton.* and DeleteButtonController.* in editing/
444
445         * bridge/win/ChromeClientWin.h: Added.
446         (WebCore::ChromeClientWin::~ChromeClientWin):
447         * bridge/win/EditorClientWin.h: Added.
448         (WebCore::EditorClientWin::~EditorClientWin):
449
450         * bridge/win/FrameWin.cpp:
451         (WebCore::FrameWin::FrameWin):
452         (WebCore::FrameWin::urlSelected):
453         (WebCore::FrameWin::submitForm):
454         (WebCore::FrameWin::createNewWindow):
455         * bridge/win/FrameWin.h:
456         Added EditorClient parameter to constructor
457         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
458         Removed openURL() and openURLRequest from class definition
459
460         * bridge/win/PageWin.cpp:
461         * platform/AffineTransform.h:
462         * platform/cairo/AffineTransformCairo.cpp: Added.
463         (WebCore::AffineTransform::AffineTransform):
464         (WebCore::AffineTransform::setMatrix):
465         (WebCore::AffineTransform::map):
466         (WebCore::AffineTransform::mapRect):
467         (WebCore::AffineTransform::isIdentity):
468         (WebCore::AffineTransform::m11):
469         (WebCore::AffineTransform::m12):
470         (WebCore::AffineTransform::m21):
471         (WebCore::AffineTransform::m22):
472         (WebCore::AffineTransform::dx):
473         (WebCore::AffineTransform::dy):
474         (WebCore::AffineTransform::reset):
475         (WebCore::AffineTransform::scale):
476         (WebCore::AffineTransform::rotate):
477         (WebCore::AffineTransform::translate):
478         (WebCore::AffineTransform::shear):
479         (WebCore::AffineTransform::det):
480         (WebCore::AffineTransform::invert):
481         (WebCore::AffineTransform::operator cairo_matrix_t):
482         (WebCore::AffineTransform::operator== ):
483         (WebCore::AffineTransform::operator*= ):
484         (WebCore::AffineTransform::operator* ):
485         * platform/cairo/GraphicsContextCairo.cpp:
486         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
487         * platform/network/win/ResourceHandleWin.cpp:
488         (WebCore::ResourceHandle::onHandleCreated):
489         (WebCore::ResourceHandle::start):
490         (WebCore::ResourceHandle::fileLoadTimer):
491         (WebCore::ResourceHandle::cancel):
492         * platform/win/TemporaryLinkStubs.cpp:
493         (WebCore::FrameWin::goBackOrForward):
494         (WebCore::FrameWin::getHistoryLength):
495         (WebCore::FrameWin::historyURL):
496         (WebCore::ServeSynchronousRequest):
497         (WebCore::ChromeClientWin::canRunModal):
498         (WebCore::ChromeClientWin::runModal):
499         (WebCore::EditorClientWin::shouldDeleteRange):
500         (WebCore::EditorClientWin::shouldShowDeleteInterface):
501         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
502         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
503         (WebCore::EditorClientWin::spellCheckerDocumentTag):
504         (WebCore::Path::transform):
505         (WebCore::PopupMenu::updateFromElement):
506         (WebCore::ResourceLoader::loadsBlocked):
507         (WebCore::systemBeep):
508         * rendering/RenderThemeWin.cpp:
509         (WebCore::RenderThemeWin::paintButton):
510         (WebCore::RenderThemeWin::paintTextField):
511
512 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
513
514         Reviewed by Maciej.
515
516         http://bugs.webkit.org/show_bug.cgi?id=11448
517         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
518
519         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
520
521 2006-11-03  Mark Rowe  <bdash@webkit.org>
522
523         Reviewed by Oliver.
524
525         Update Windows and Qt project files for file removals in r17585.
526
527         * CMakeLists.txt:
528         * WebCore.vcproj/WebCore/WebCore.vcproj:
529
530 2006-11-03  Zack Rusin  <zack@kde.org>
531
532         Reviewed by Maciej.
533
534         The patch fixes text field drawing on the Qt platform.
535
536         * platform/qt/RenderThemeQt.cpp:
537         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
538         render the text field
539
540 2006-11-03  Oliver Hunt  <oliver@apple.com>
541
542         Reviewed by Tim.
543
544         Correct incorrect call to SetCursor
545
546         * rendering/RenderFrameSet.cpp:
547         (WebCore::RenderFrameSet::userResize):
548
549 2006-11-03  Adele Peterson  <adele@apple.com>
550
551         Reviewed by Oliver.
552
553         Removed DeprecatedRenderSelect and ListBox classes.
554
555         * WebCore.xcodeproj/project.pbxproj:
556         * css/html4.css:
557         * html/HTMLOptionElement.h:
558         * html/HTMLSelectElement.cpp:
559         (WebCore::HTMLSelectElement::recalcStyle):
560         (WebCore::HTMLSelectElement::isKeyboardFocusable):
561         (WebCore::HTMLSelectElement::isMouseFocusable):
562         (WebCore::HTMLSelectElement::createRenderer):
563         (WebCore::HTMLSelectElement::setRecalcListItems):
564         (WebCore::HTMLSelectElement::notifyOptionSelected):
565         (WebCore::HTMLSelectElement::defaultEventHandler):
566         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
567         (WebCore::HTMLSelectElement::updateListBoxSelection):
568         * html/HTMLSelectElement.h:
569         * platform/ListBox.h: Removed.
570         * platform/mac/FontCacheMac.mm:
571         * platform/mac/ListBoxMac.mm: Removed.
572         * platform/win/TemporaryLinkStubs.cpp:
573         * rendering/DeprecatedRenderSelect.cpp: Removed.
574         * rendering/DeprecatedRenderSelect.h: Removed.
575
576 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
577
578         Not reviewed, fix for accidental commit.
579
580         - rolled back more of the accidentall commit that I forgot.
581
582         * platform/network/mac/ResourceRequestMac.h: Removed.
583         * platform/network/mac/ResourceRequestMac.mm: Removed.
584
585 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
586
587         Not reviewed, fix for accidental commit.
588
589         - roll back some network changes accidentally committed with a previous patch.
590
591         * WebCore.xcodeproj/project.pbxproj:
592         * bridge/mac/WebCoreFrameBridge.mm:
593         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
594         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
595         * loader/CachedCSSStyleSheet.cpp:
596         (WebCore::CachedCSSStyleSheet::checkNotify):
597         * loader/CachedImage.cpp:
598         (WebCore::CachedImage::createImage):
599         * loader/CachedResource.cpp:
600         (WebCore::CachedResource::CachedResource):
601         (WebCore::CachedResource::~CachedResource):
602         (WebCore::CachedResource::setExpireDate):
603         (WebCore::CachedResource::isExpired):
604         * loader/CachedResource.h:
605         (WebCore::CachedResource::response):
606         * loader/LoaderFunctions.h:
607         * loader/loader.cpp:
608         (WebCore::Loader::receivedResponse):
609         (WebCore::Loader::didReceivedResponse):
610         * loader/loader.h:
611         * loader/mac/FormDataStream.h:
612         * loader/mac/FormDataStream.m:
613         (WebCore::formCreate):
614         (WebCore::formFinalize):
615         * loader/mac/ImageDocumentMac.mm:
616         (WebCore::finishImageLoad):
617         * loader/mac/LoaderFunctionsMac.mm:
618         (WebCore::CheckCacheObjectStatus):
619         (WebCore::CachedResource::setResponse):
620         * loader/mac/SubresourceLoaderMac.mm:
621         (WebCore::SubresourceLoader::willSendRequest):
622         * platform/network/ResourceHandle.h:
623         * platform/network/ResourceHandleClient.h:
624         (WebCore::ResourceHandleClient::receivedRedirect):
625         * platform/network/ResourceRequest.h:
626         * platform/network/ResourceResponse.h:
627         (WebCore::ResourceResponse::ResourceResponse):
628         * platform/network/mac/ResourceHandleMac.mm:
629         (WebCore::ResourceHandle::redirectedToURL):
630         * xml/xmlhttprequest.cpp:
631         (WebCore::XMLHttpRequest::receivedRedirect):
632         * xml/xmlhttprequest.h:
633
634 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
635
636         Rubber-stamped by Oliver.
637
638         Remove these, they have been merged with SVGRenderTreeAsText.
639         
640         * rendering/SVGRenderAsText.cpp: Removed.
641         * rendering/SVGRenderAsText.h: Removed.
642
643 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
644
645         Build fix.
646         
647         * platform/network/cf/ResourceHandleCFNet.cpp:
648         (WebCore::willSendRequest):
649
650 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
651
652         Reviewed by Darin, Beth.
653         
654         First cut at factoring Page's UIDelegate-related functions into Chrome
655         and ChromeClient.
656
657         Layout tests pass.
658         
659         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
660         setBridge method to replace it.
661         (WebCore::Page::setBridge):
662
663         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
664         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
665         and, now that it uses PassRefPtr, can't be.
666         
667         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
668
669         * page/Page.h:
670         (WebCore::Page::dragCaretController): Made this function non-const so that
671         m_dragCaretController doesn't have to be mutable.
672
673 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
674
675         Reviewed by Adele.
676
677         http://bugs.webkit.org/show_bug.cgi?id=7323
678         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
679
680         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
681         in FrameMac.mm. There can be only one drag active at any moment, and having 
682         this information here was making sharing this information between 
683         subframes hard.
684
685         * bridge/mac/FrameMac.mm:
686         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
687         (WebCore::FrameMac::freeClipboard):
688         (WebCore::FrameMac::dragHysteresisExceeded):
689         (WebCore::FrameMac::handleMouseMoveEvent):
690         (WebCore::FrameMac::handleMouseReleaseEvent):
691         (WebCore::FrameMac::mouseDown):
692         (WebCore::FrameMac::dragSourceMovedTo):
693         (WebCore::FrameMac::dragSourceEndedAt):
694         (WebCore::FrameMac::dispatchDragSrcEvent):
695         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
696         Also removed some old code that was forwarding mouse events to subviews to make 
697         HTML editing work in subframes.
698
699         * page/FrameView.cpp:
700         (WebCore::FrameView::updateDragAndDrop):
701         (WebCore::FrameView::cancelDragAndDrop):
702         (WebCore::FrameView::performDragAndDrop):
703         Forward events to subframes for dispatching - this fixes drag target events.
704
705 2006-11-03  Zack Rusin  <zack@kde.org>
706
707         Reviewed by Tim.
708
709         Fixing compile.
710
711         * platform/qt/LoaderFunctionsQt.cpp:
712         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
713
714 2006-11-01  Zack Rusin  <zack@kde.org>
715
716         Reviewed by Maciej.
717
718         Moving the word/sentence seperators into a file of their own
719         and implementing findWordBoundary.
720
721         * CMakeLists.txt:
722         * platform/qt/TemporaryLinkStubs.cpp:
723         * platform/qt/TextBoundaries.cpp: Added.
724         (WebCore::findNextSentenceFromIndex):
725         (WebCore::findSentenceBoundary):
726         (WebCore::findNextWordFromIndex):
727         (WebCore::findWordBoundary):
728
729 2006-11-03  Zack Rusin  <zack@kde.org>
730
731         Reviewed by Maciej.
732
733         Compile on both KDE and Qt platforms
734
735         * CMakeLists.txt: add zlib explicitly
736         * platform/network/qt/ResourceHandleManager.cpp:
737         (WebCore::ResourceHandleManager::self):
738         (WebCore::QtJob::QtJob):
739         (WebCore::QtJob::timerEvent): Integrate both implementations
740         so that moc can parse it
741         (WebCore::ResourceHandleManager::deliverJobData):
742         (WebCore::ResourceHandleManager::remove):
743         * platform/network/qt/ResourceHandleManager.h:
744
745 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
746
747         No review, suggested by Mitz.
748
749         - fix a #if to be #ifdef
750
751         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
752
753 2006-11-03  Zack Rusin  <zack@kde.org>
754
755         Reviewed and landed by Maciej.
756         
757         Compile on the Qt platform.
758
759         * ksvg2/misc/KCanvasRenderingStyle.h:
760         * platform/qt/RenderThemeQt.cpp:
761         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
762
763 2006-11-03  Zack Rusin  <zack@kde.org>
764
765         Reviewed by Hyatt. Landed by Maciej.
766
767         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
768         to graphics context to be able to set consistant state
769         on the platform specific painter without having to change
770         fill/stroke/font on every operation. This fixes color/stroke/fill
771         and font handling in the Qt port.
772
773         * platform/graphics/GraphicsContext.cpp:
774         (WebCore::GraphicsContext::setFont):
775         (WebCore::GraphicsContext::setPen):
776         (WebCore::GraphicsContext::setFillColor):
777         (WebCore::GraphicsContext::setPlatformPen):
778         (WebCore::GraphicsContext::setPlatformFillColor):
779         (WebCore::GraphicsContext::setPlatformFont):
780         * platform/graphics/GraphicsContext.h:
781         * platform/qt/GraphicsContextQt.cpp:
782         (WebCore::toQtCompositionMode):
783         (WebCore::toQtLineCap):
784         (WebCore::toQtLineJoin):
785         (WebCore::toQPenStyle):
786         (WebCore::penToQPen):
787         (WebCore::TransparencyLayer::TransparencyLayer):
788         (WebCore::GraphicsContext::addRoundedRectClip):
789         (WebCore::GraphicsContext::setPlatformFont):
790         (WebCore::GraphicsContext::setPlatformPen):
791         (WebCore::GraphicsContext::setPlatformFillColor):
792         * platform/qt/ScrollViewCanvasQt.cpp:
793         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
794         (WebCore::ScrollViewCanvasQt::paintEvent):
795         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
796         * platform/qt/ScrollViewCanvasQt.h:
797
798 2006-11-02  Adele Peterson  <adele@apple.com>
799
800         Reviewed by Anders.
801
802         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
803         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
804
805         Test: fast/forms/textarea-no-scroll-on-blur.html
806
807         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
808           On blur, only scroll back to the start for text fields.
809
810 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
811
812         Another build fix.
813         
814         * rendering/RenderFileUploadControl.cpp:
815         (WebCore::RenderFileUploadControl::paintObject):
816
817 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
818
819         Build fix.
820         
821         * page/FramePrivate.h:
822         (WebCore::FramePrivate::FramePrivate):
823
824 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
825
826         Reviewed by Geoff, landed by Anders.
827         
828         Fix dependency problems caused when running move-js-headers.sh
829         
830         * move-js-headers.sh:
831         Use cp -p instead of just cp so that the modification time
832         of the original files are used.
833
834 2006-11-02  Adam Roben  <aroben@apple.com>
835
836         Reviewed by Tim H, landed by Anders.
837
838         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
839         REGRESSION: Shadow of file upload button is clipped
840
841         * rendering/RenderFileUploadControl.cpp:
842         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
843         height to keep from clipping in the shadow
844
845 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
846
847         Reviewed by Maciej, landed by Anders.
848
849         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
850         content and window. ScrollViewQt already receives correct content
851         coordinates from QScrollArea.
852         (WebCore::ScrollView::contentsToWindow):
853         (WebCore::ScrollView::windowToContents):
854
855 2006-11-02  Simon Hausmann  <hausmann@kde.org>
856
857         Reviewed by Maciej, landed by Anders
858
859         * CMakeLists.txt: Make linkage against KDE libraries conditional
860         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
861           Qt base resource handler that supports only requests to the
862           local filesystem. Used when compiling without KDE support.
863           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
864           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
865         (WebCore::QtJob::QtJob):
866         (WebCore::QtJob::timerEvent):
867         (WebCore::ResourceHandleManager::ResourceHandleManager):
868         (WebCore::ResourceHandleManager::~ResourceHandleManager):
869         (WebCore::ResourceHandleManager::self):
870         (WebCore::ResourceHandleManager::remove):
871         (WebCore::ResourceHandleManager::add):
872         (WebCore::ResourceHandleManager::cancel):
873         (WebCore::ResourceHandleManager::deliverJobData):
874         * platform/network/qt/ResourceHandleManager.h:
875         * platform/qt/FrameQtClient.cpp:
876         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
877         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
878         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
879         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
880           input dialog functions when compiling without KDE support
881         (WebCore::ServeSynchronousRequest):
882
883 2006-11-02  David Carson  <dacarson@gmail.com>
884
885         Reviewed by Geoff, landed by Anders.
886
887         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
888         Initializing variable in constructor.
889
890         * page/FramePrivate.h:
891         (WebCore::FramePrivate::FramePrivate):
892
893 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
894
895         Reviewed by Geoff.
896
897         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
898         
899         * platform/network/cf/ResourceHandleCFNet.cpp:
900         (WebCore::addHeadersFromHashMap):
901         Don't set all headers at once since that clears any previous headers set.
902         
903         (WebCore::ResourceHandle::start):
904
905 2006-11-02  Adele Peterson  <adele@apple.com>
906
907         Reviewed by Mitz and Geoff.
908
909         - Fix for:
910         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
911         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
912         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
913
914         Test: fast/forms/textarea-scrollbar.html
915
916         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
917         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
918
919         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
920         * rendering/RenderTextControl.cpp: 
921         (WebCore::RenderTextControl::RenderTextControl):
922         (WebCore::RenderTextControl::setStyle):
923         (WebCore::RenderTextControl::createDivStyle):
924         (WebCore::RenderTextControl::updateFromElement):
925         (WebCore::RenderTextControl::calcHeight):
926         (WebCore::RenderTextControl::baselinePosition):
927         (WebCore::RenderTextControl::nodeAtPoint):
928         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
929         (WebCore::RenderTextControl::scrollWidth):
930         (WebCore::RenderTextControl::scrollHeight):
931         (WebCore::RenderTextControl::scrollLeft):
932         (WebCore::RenderTextControl::scrollTop):
933
934         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
935
936 2006-11-02  John Sullivan  <sullivan@apple.com>
937
938         Reviewed by Geoff Garen
939
940         * editing/Selection.cpp:
941         (WebCore::Selection::showTreeForThis):
942         this debugging method now displays start offset and end offset, at Darin's suggestion
943
944 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
945
946         Reviewed by darin
947
948         <rdar://problem/4062865>
949         Copy/paste of a select element fails to include the options
950         
951         * editing/SelectionController.cpp:
952         (WebCore::SelectionController::modify): Added paragraphBoundary.
953         * editing/htmlediting.cpp:
954         (WebCore::canHaveChildrenForEditing): Added checks for input elements
955         and textareas.  Insertion operations would fail when performed just 
956         before/after one of these elements b/c the content would be put inside 
957         the element.
958         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
959         editable content, and made the code to stop at an root faster (don't check
960         isDescendantOf on every iteration).
961         (WebCore::enclosingNodeOfType): Ditto.
962         (WebCore::enclosingList): Ditto.
963         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
964         inappropriately named.
965         * editing/markup.cpp:
966         (WebCore::startMarkup): Use the text node's value instead of its rendered
967         content for text nodes inside select elements.  One might also turn off
968         annotation when createMarkup enters a select element, but createMarkup
969         is iterative, not recursive, so doing so would be complicated.
970         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
971         descendants of a select element.
972         * editing/visible_units.cpp:
973         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
974         where various replaced elements can't be copied when they are the only
975         thing selected.
976         (WebCore::endOfParagraph): Ditto.
977
978 2006-11-01  Oliver Hunt  <oliver@apple.com>
979
980         Reviewed by Adam.
981
982         Converting more or kcanvas/quartz from Obj-C to C++
983         Minor SVG updates
984         compatibility fixes
985
986         * WebCore.xcodeproj/project.pbxproj:
987         * kcanvas/device/KRenderingPaintServer.h:
988         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
989         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
990         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
991         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
992         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
993         * kcanvas/device/quartz/QuartzSupport.h:
994         * ksvg2/css/SVGCSSStyleSelector.cpp:
995         * ksvg2/misc/KCanvasRenderingStyle.h:
996         * ksvg2/scripts/cssmakeprops:
997         * ksvg2/scripts/cssmakevalues:
998         * ksvg2/scripts/make_names.pl:
999         * ksvg2/svg/SVGAnimateColorElement.cpp:
1000         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1001         * ksvg2/svg/SVGAnimationElement.cpp:
1002         * ksvg2/svg/SVGMaskElement.cpp:
1003         * ksvg2/svg/SVGPatternElement.cpp:
1004         * ksvg2/svg/svgpathparser.cpp:
1005         * platform/Path.cpp:
1006         * platform/graphics/svg/SVGResourceImage.h:
1007         * rendering/RenderPath.cpp:
1008         * rendering/SVGRenderAsText.cpp:
1009
1010 2006-11-02  Mitz Pettel  <mitz@webkit.org>
1011
1012         Reviewed by Adele.
1013
1014         - Fix a regression from r17521: painting of and crash caused by tables
1015           with collapsed borders
1016
1017         * rendering/RenderTable.cpp:
1018         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
1019         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
1020         and 'paintInfo' is the parameter, which we were accidently modifying.
1021
1022 2006-11-01  Adele Peterson  <adele@apple.com>
1023
1024         Reviewed by Mitz.
1025
1026         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
1027         REGRESSION: Incomplete repaint of overflow areas when deleting
1028
1029         Restrict the repaint rect for overflow blocks after the height has been fully computed.
1030         Also, adjust the repaint rect coordinates for the scroll offset.
1031
1032         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
1033         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
1034
1035 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
1036
1037         Reviewed by Mitz.
1038
1039         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
1040         Rename the "p" member variable of the PaintInfo struct to "context"
1041
1042         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
1043           'context' and 'rect' respectively.
1044
1045         - Assorted surrounding cleanups.
1046
1047         * rendering/EllipsisBox.cpp:
1048         (WebCore::EllipsisBox::paint):
1049         * rendering/EllipsisBox.h:
1050         * rendering/InlineBox.cpp:
1051         (WebCore::InlineBox::paint):
1052         * rendering/InlineFlowBox.cpp:
1053         (WebCore::InlineFlowBox::paint):
1054         (WebCore::InlineFlowBox::paintBackground):
1055         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
1056         (WebCore::InlineFlowBox::paintDecorations):
1057         * rendering/InlineFlowBox.h:
1058         * rendering/InlineRunBox.h:
1059         * rendering/InlineTextBox.cpp:
1060         (WebCore::InlineTextBox::paint):
1061         * rendering/InlineTextBox.h:
1062         * rendering/RenderBlock.cpp:
1063         (WebCore::RenderBlock::paint):
1064         (WebCore::RenderBlock::paintChildren):
1065         (WebCore::RenderBlock::paintCaret):
1066         (WebCore::RenderBlock::paintObject):
1067         (WebCore::RenderBlock::paintFloats):
1068         (WebCore::RenderBlock::paintEllipsisBoxes):
1069         (WebCore::RenderBlock::paintSelection):
1070         (WebCore::RenderBlock::fillSelectionGaps):
1071         (WebCore::RenderBlock::fillInlineSelectionGaps):
1072         (WebCore::RenderBlock::fillBlockSelectionGaps):
1073         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1074         (WebCore::RenderBlock::fillVerticalSelectionGap):
1075         (WebCore::RenderBlock::fillLeftSelectionGap):
1076         (WebCore::RenderBlock::fillRightSelectionGap):
1077         * rendering/RenderBox.cpp:
1078         (WebCore::RenderBox::paint):
1079         (WebCore::RenderBox::paintRootBoxDecorations):
1080         (WebCore::RenderBox::paintBoxDecorations):
1081         * rendering/RenderBox.h:
1082         * rendering/RenderButton.cpp:
1083         (WebCore::RenderButton::paintObject):
1084         * rendering/RenderFieldset.cpp:
1085         (WebCore::RenderFieldset::paintBoxDecorations):
1086         * rendering/RenderFileUploadControl.cpp:
1087         (WebCore::RenderFileUploadControl::paintObject):
1088         * rendering/RenderFlow.cpp:
1089         (WebCore::RenderFlow::continuationBefore):
1090         (WebCore::RenderFlow::addChildWithContinuation):
1091         (WebCore::RenderFlow::addChild):
1092         (WebCore::RenderFlow::attachLineBox):
1093         (WebCore::RenderFlow::destroy):
1094         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
1095         (WebCore::RenderFlow::dirtyLineBoxes):
1096         (WebCore::RenderFlow::createInlineBox):
1097         (WebCore::RenderFlow::paintLines):
1098         (WebCore::RenderFlow::getAbsoluteRepaintRect):
1099         (WebCore::RenderFlow::lowestPosition):
1100         (WebCore::RenderFlow::rightmostPosition):
1101         (WebCore::RenderFlow::leftmostPosition):
1102         (WebCore::RenderFlow::caretRect):
1103         (WebCore::RenderFlow::addFocusRingRects):
1104         (WebCore::RenderFlow::paintOutline):
1105         (WebCore::RenderFlow::paintOutlineForLine):
1106         * rendering/RenderForeignObject.cpp:
1107         (WebCore::RenderForeignObject::paint):
1108         * rendering/RenderHTMLCanvas.cpp:
1109         (WebCore::RenderHTMLCanvas::paint):
1110         * rendering/RenderImage.cpp:
1111         (WebCore::RenderImage::paint):
1112         * rendering/RenderLayer.cpp:
1113         (WebCore::RenderLayer::paintLayer):
1114         * rendering/RenderListBox.cpp:
1115         (WebCore::RenderListBox::paintObject):
1116         (WebCore::RenderListBox::paintScrollbar):
1117         (WebCore::RenderListBox::paintItemForeground):
1118         (WebCore::RenderListBox::paintItemBackground):
1119         * rendering/RenderListMarker.cpp:
1120         (WebCore::RenderListMarker::paint):
1121         * rendering/RenderMenuList.cpp:
1122         (WebCore::RenderMenuList::paintObject):
1123         * rendering/RenderObject.cpp:
1124         (WebCore::RenderObject::paint):
1125         * rendering/RenderObject.h:
1126         (WebCore::RenderObject::PaintInfo::PaintInfo):
1127         (WebCore::RenderObject::paintBoxDecorations):
1128         (WebCore::RenderObject::paintingRootForChildren):
1129         (WebCore::RenderObject::shouldPaintWithinRoot):
1130         (WebCore::RenderObject::printBoxDecorations):
1131         * rendering/RenderPath.cpp:
1132         (WebCore::RenderPath::paint):
1133         * rendering/RenderReplaced.cpp:
1134         (WebCore::RenderReplaced::shouldPaint):
1135         * rendering/RenderSVGContainer.cpp:
1136         (WebCore::RenderSVGContainer::paint):
1137         * rendering/RenderSVGContainer.h:
1138         * rendering/RenderSVGImage.cpp:
1139         (WebCore::RenderSVGImage::paint):
1140         * rendering/RenderSVGText.cpp:
1141         (WebCore::RenderSVGText::paint):
1142         * rendering/RenderSVGText.h:
1143         (WebCore::RenderSVGText::renderName):
1144         * rendering/RenderTable.cpp:
1145         (WebCore::RenderTable::paint):
1146         (WebCore::RenderTable::paintBoxDecorations):
1147         * rendering/RenderTable.h:
1148         * rendering/RenderTableCell.cpp:
1149         (WebCore::RenderTableCell::paint):
1150         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
1151         (WebCore::RenderTableCell::paintBoxDecorations):
1152         * rendering/RenderTableCell.h:
1153         * rendering/RenderTableRow.cpp:
1154         (WebCore::RenderTableRow::paint):
1155         * rendering/RenderTableRow.h:
1156         * rendering/RenderTableSection.cpp:
1157         (WebCore::RenderTableSection::paint):
1158         * rendering/RenderTableSection.h:
1159         (WebCore::RenderTableSection::getBaseline):
1160         (WebCore::RenderTableSection::setNeedCellRecalc):
1161         * rendering/RenderText.h:
1162         (WebCore::RenderText::renderName):
1163         (WebCore::RenderText::paint):
1164         (WebCore::RenderText::element):
1165         * rendering/RenderTheme.cpp:
1166         (WebCore::RenderTheme::paint):
1167         (WebCore::RenderTheme::paintBorderOnly):
1168         (WebCore::RenderTheme::paintDecorations):
1169         * rendering/RenderTheme.h:
1170         (WebCore::RenderTheme::RenderTheme):
1171         (WebCore::RenderTheme::~RenderTheme):
1172         (WebCore::RenderTheme::controlSupportsTints):
1173         (WebCore::RenderTheme::adjustRepaintRect):
1174         (WebCore::RenderTheme::themeChanged):
1175         (WebCore::RenderTheme::supportsHover):
1176         (WebCore::RenderTheme::paintCheckbox):
1177         (WebCore::RenderTheme::setCheckboxSize):
1178         (WebCore::RenderTheme::paintRadio):
1179         (WebCore::RenderTheme::setRadioSize):
1180         (WebCore::RenderTheme::paintButton):
1181         (WebCore::RenderTheme::setButtonSize):
1182         (WebCore::RenderTheme::paintTextField):
1183         (WebCore::RenderTheme::paintTextArea):
1184         (WebCore::RenderTheme::paintMenuList):
1185         (WebCore::RenderTheme::paintMenuListButton):
1186         * rendering/RenderThemeMac.mm:
1187         (WebCore::RenderThemeMac::paintCheckbox):
1188         (WebCore::RenderThemeMac::paintRadio):
1189         (WebCore::RenderThemeMac::paintButton):
1190         (WebCore::RenderThemeMac::paintTextField):
1191         (WebCore::RenderThemeMac::paintTextArea):
1192         (WebCore::RenderThemeMac::paintMenuList):
1193         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1194         (WebCore::RenderThemeMac::paintMenuListButton):
1195         * rendering/RenderView.cpp:
1196         (WebCore::RenderView::paint):
1197         (WebCore::RenderView::paintBoxDecorations):
1198         * rendering/RenderView.h:
1199         * rendering/RenderWidget.cpp:
1200         (WebCore::RenderWidget::paint):
1201         * rendering/RenderWidget.h:
1202         (WebCore::RenderWidget::isWidget):
1203         * rendering/RootInlineBox.cpp:
1204         (WebCore::RootInlineBox::paintEllipsisBox):
1205         (WebCore::RootInlineBox::paintCustomHighlight):
1206         (WebCore::RootInlineBox::paint):
1207         (WebCore::RootInlineBox::fillLineSelectionGap):
1208         * rendering/RootInlineBox.h:
1209         * rendering/SVGInlineFlowBox.cpp:
1210         (WebCore::paintSVGInlineFlow):
1211
1212 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
1213
1214         Reviewed by Oliver, Brady.
1215
1216         * platform/network/ResourceResponse.h:
1217         (WebCore::ResourceResponse::setLastModifiedDate):
1218         (WebCore::ResourceResponse::lastModifiedDate):
1219         Add getters and setters for last modified dadte.
1220         
1221         * platform/network/cf/ResourceResponseCFNet.cpp:
1222         (WebCore::getResourceResponse):
1223         Fetch the last modified date. Add correct offset to expired date.
1224
1225 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
1226
1227         Reviewed by Mitz.
1228
1229         Added missing "break;" statement in switch statement from r17493.
1230
1231         Bug 11442: [CSS 3] support for cursor: all-scroll
1232         http://bugs.webkit.org/show_bug.cgi?id=11442
1233
1234         * css/CSSComputedStyleDeclaration.cpp:
1235         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1236
1237 2006-10-31  Mitz Pettel  <mitz@webkit.org>
1238
1239         Reviewed by Maciej.
1240
1241         - fix image dragging
1242
1243         This is covered by editing/selection/drag-to-contenteditable-iframe.html
1244
1245         * rendering/HitTestResult.cpp:
1246         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
1247         HTML IMG elements.
1248         (WebCore::HitTestResult::absoluteImageURL): Ditto.
1249
1250 2006-10-31  Beth Dakin  <bdakin@apple.com>
1251
1252         Reviewed by Maciej.
1253
1254         This adds the back-end of the remaining WebElementDictionary 
1255         functions into HitTestResult.
1256
1257         * WebCore.exp:
1258         * rendering/HitTestResult.cpp:
1259         (WebCore::HitTestResult::title):
1260         (WebCore::displayString): This is nearly identical to the 
1261         displayString() defined in DOMInternal.mm except that it returns a 
1262         String instead of an NSString. The old code path used the 
1263         DOMInternal method, so I made a new one here for the new code path.
1264         (WebCore::HitTestResult::altDisplayString):
1265         (WebCore::HitTestResult::image):
1266         (WebCore::HitTestResult::absoluteImageURL):
1267         (WebCore::HitTestResult::absoluteLinkURL):
1268         (WebCore::HitTestResult::titleDisplayString):
1269         (WebCore::HitTestResult::textContent):
1270         * rendering/HitTestResult.h:
1271
1272 2006-10-31  John Sullivan  <sullivan@apple.com>
1273
1274         * bridge/mac/FrameMac.mm:
1275         (WebCore::FrameMac::markMisspellings):
1276         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
1277
1278 2006-10-31  John Sullivan  <sullivan@apple.com>
1279
1280         Reviewed by Maciej
1281         
1282         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
1283         
1284         The foundation of this was in my last checkin. This checkin is all about displaying
1285         the correct string in the toolTip.
1286
1287         * dom/DocumentMarker.h:
1288         New description field in this struct.
1289
1290         * bridge/mac/FrameMac.mm:
1291         (WebCore::FrameMac::advanceToNextMisspelling):
1292         When adding a grammar marker, supply the appropriate description. Also, added a comment
1293         about the remaining work to make grammar checking return sensible answers.
1294         (WebCore::FrameMac::markMisspellings):
1295         ditto (yes, still needs some refactoring to minimize duplicated code)
1296         
1297         * dom/Document.h:
1298         * dom/Document.cpp:
1299         (WebCore::Document::addMarker):
1300         Now takes an optional description string
1301         (WebCore::Document::markerContainingPoint):
1302         New function, returns a pointer to the (first) marker of the specified type whose rect 
1303         contains the specified point, or 0 if none.
1304         
1305         * rendering/HitTestResult.cpp:
1306         (WebCore::HitTestResult::spellingToolTip):
1307         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
1308         and gets the description from the marker.
1309
1310 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
1311
1312         Reviewed by Maciej.
1313         
1314         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
1315
1316         * loader/mac/FrameLoaderMac.mm:
1317         (WebCore::FrameLoader::createWindow):
1318         * manual-tests/window-open-features-parsing.html: Updated for clarity.
1319
1320 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
1321
1322         Reviewed by Alice.
1323
1324         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
1325         to WebCore::Editor.
1326         
1327         Layout tests pass.
1328         
1329         Renamed "may*" to "can*" because "can" is more accurate (these functions
1330         aren't just about permission) and it matches WebKit.
1331
1332         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
1333         password field. Now that WebCore fully implements canCopy(), it doesn't just
1334         mean "the selection is not in a password field" anymore.
1335         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
1336         The fact that it's not called anymore may represent a security issue, but I
1337         don't see how commented-out code will help reveal the issue, and the
1338         bridge is going away, anyway.
1339         * editing/SelectionController.h: Changed selection() calls to references
1340         to m_sel, to match the rest of the file.
1341
1342 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
1343
1344         Reviewed by harrison
1345         
1346         <rdar://problem/4711063>
1347         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
1348
1349         * editing/ReplaceSelectionCommand.cpp:
1350         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
1351         insertion and plain text string creation unless we need the string
1352         for a BeforeTextInserted event handler or for a plain text only region.
1353         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
1354         code here from ReplacementFragment's constructor.
1355         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
1356         FIXME.
1357         * editing/ReplaceSelectionCommand.h:
1358
1359 2006-10-31  Ada Chan  <adachan@apple.com>
1360
1361         Reviewed by Adam
1362
1363         Correct forward declarations of the HitTestRequest struct.
1364
1365         * rendering/EllipsisBox.h:
1366         * rendering/InlineBox.h:
1367         * rendering/InlineFlowBox.h:
1368         * rendering/RenderLayer.h:
1369         * rendering/RenderObject.h:
1370
1371 2006-10-31  John Sullivan  <sullivan@apple.com>
1372
1373         Reviewed by Beth and Adam
1374
1375         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
1376         next I'll make it use a string that's relevant for a specific grammar error.
1377
1378         * WebCore.exp:
1379         export symbol for spellingToolTip function
1380         
1381         * rendering/HitTestResult.h:
1382         * rendering/HitTestResult.cpp:
1383         (WebCore::HitTestResult::spellingToolTip):
1384         new function, returns the string to be used in a tool tip that describes the questionable grammar
1385         
1386         * rendering/InlineTextBox.h:
1387         * rendering/InlineTextBox.cpp:
1388         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1389         now takes a style and font, needed to compute the rect representing the range containing
1390         questionable grammar. Computes the rect and associates it with the marker.
1391         (WebCore::InlineTextBox::paintDocumentMarkers):
1392         Pass in the style and font now needed by paintSpellingOrGrammarMarker
1393
1394 2006-10-31  Adele Peterson  <adele@apple.com>
1395
1396         Removed commented out variable from last checkin.
1397
1398         * html/HTMLSelectElement.cpp:
1399         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1400
1401 2006-10-31  Brady Eidson  <beidson@apple.com>
1402
1403         Build fix (unused variable in release builds)
1404
1405         * html/HTMLSelectElement.cpp:
1406         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1407
1408 2006-10-31  Adele Peterson  <adele@apple.com>
1409
1410         Reviewed by Adam.
1411
1412         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
1413         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
1414         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
1415
1416         Tests: 
1417         * LayoutTests/fast/forms/listbox-selection.html
1418         * LayoutTests/fast/forms/listbox-onchange.html
1419
1420         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
1421           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
1422           And one for onChange, that is updated after onChange is fired.
1423           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
1424  
1425         * html/HTMLSelectElement.cpp:
1426         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
1427         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
1428         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
1429         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
1430         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
1431         (WebCore::HTMLSelectElement::setExtent): Added.
1432         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
1433         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
1434
1435         * rendering/RenderListBox.cpp:
1436         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
1437         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
1438         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
1439         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
1440          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
1441          notify the select element from here.
1442         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
1443         (WebCore::RenderListBox::listIndexIsVisible): Added.
1444         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
1445
1446         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
1447         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
1448         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
1449         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
1450         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
1451
1452 2006-10-31  Beth Dakin  <bdakin@apple.com>
1453
1454         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
1455
1456         * rendering/HitTestRequest.h: Added.
1457         (WebCore::HitTestRequest::HitTestRequest):
1458
1459 2006-10-31  Beth Dakin  <bdakin@apple.com>
1460
1461         Reviewed by Maciej.
1462
1463         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
1464         should be split into HitTestRequest and HitTestResult
1465
1466         This patch creates a new struct called HitTestRequest that holds 
1467         the three boolean values (readonly, active, and mouseMove) that 
1468         were formerly a part of HitTestResult. All hitTest() and 
1469         nodeAtPoint() functions now take a HitTestRequest in addition to 
1470         the HitTestResult.
1471
1472         * WebCore.exp:
1473         * WebCore.xcodeproj/project.pbxproj:
1474         * bridge/mac/FrameMac.mm:
1475         (WebCore::FrameMac::eventMayStartDrag):
1476         (WebCore::FrameMac::handleMouseMoveEvent):
1477         * bridge/mac/WebCoreAXObject.mm:
1478         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
1479         (-[WebCoreAXObject accessibilityHitTest:]):
1480         * dom/Document.cpp:
1481         (WebCore::Document::elementFromPoint):
1482         (WebCore::Document::prepareMouseEvent):
1483         * editing/SelectionController.cpp:
1484         (WebCore::SelectionController::contains):
1485         * page/Frame.cpp:
1486         (WebCore::Frame::hitTestResultAtPoint):
1487         * page/FrameView.cpp:
1488         (WebCore::FrameView::handleWheelEvent):
1489         * rendering/EllipsisBox.cpp:
1490         (WebCore::EllipsisBox::nodeAtPoint):
1491         * rendering/EllipsisBox.h:
1492         * rendering/HitTestResult.cpp:
1493         (WebCore::HitTestResult::HitTestResult):
1494         (WebCore::HitTestResult::operator=):
1495         * rendering/HitTestResult.h:
1496         * rendering/InlineBox.cpp:
1497         (WebCore::InlineBox::nodeAtPoint):
1498         * rendering/InlineBox.h:
1499         * rendering/InlineFlowBox.cpp:
1500         (WebCore::InlineFlowBox::nodeAtPoint):
1501         * rendering/InlineFlowBox.h:
1502         * rendering/InlineTextBox.cpp:
1503         (WebCore::InlineTextBox::nodeAtPoint):
1504         * rendering/InlineTextBox.h:
1505         * rendering/RenderBlock.cpp:
1506         (WebCore::RenderBlock::nodeAtPoint):
1507         * rendering/RenderBlock.h:
1508         * rendering/RenderBox.cpp:
1509         (WebCore::RenderBox::nodeAtPoint):
1510         * rendering/RenderBox.h:
1511         * rendering/RenderFlow.cpp:
1512         (WebCore::RenderFlow::hitTestLines):
1513         * rendering/RenderFlow.h:
1514         * rendering/RenderForeignObject.cpp:
1515         (WebCore::RenderForeignObject::nodeAtPoint):
1516         * rendering/RenderForeignObject.h:
1517         * rendering/RenderFrameSet.cpp:
1518         (WebCore::RenderFrameSet::nodeAtPoint):
1519         * rendering/RenderFrameSet.h:
1520         * rendering/RenderImage.cpp:
1521         (WebCore::RenderImage::nodeAtPoint):
1522         * rendering/RenderImage.h:
1523         * rendering/RenderInline.cpp:
1524         (WebCore::RenderInline::nodeAtPoint):
1525         * rendering/RenderInline.h:
1526         * rendering/RenderLayer.cpp:
1527         (WebCore::RenderLayer::autoscroll):
1528         (WebCore::RenderLayer::hitTest):
1529         (WebCore::RenderLayer::hitTestLayer):
1530         (WebCore::RenderLayer::updateHoverActiveState):
1531         * rendering/RenderLayer.h:
1532         * rendering/RenderObject.cpp:
1533         (WebCore::RenderObject::hitTest):
1534         (WebCore::RenderObject::nodeAtPoint):
1535         * rendering/RenderObject.h:
1536         * rendering/RenderPath.cpp:
1537         (WebCore::RenderPath::nodeAtPoint):
1538         * rendering/RenderPath.h:
1539         * rendering/RenderSVGImage.cpp:
1540         (WebCore::RenderSVGImage::nodeAtPoint):
1541         * rendering/RenderSVGImage.h:
1542         * rendering/RenderSVGText.cpp:
1543         (WebCore::RenderSVGText::nodeAtPoint):
1544         * rendering/RenderSVGText.h:
1545         * rendering/RenderTableRow.cpp:
1546         (WebCore::RenderTableRow::nodeAtPoint):
1547         * rendering/RenderTableRow.h:
1548         * rendering/RenderTableSection.cpp:
1549         (WebCore::RenderTableSection::nodeAtPoint):
1550         * rendering/RenderTableSection.h:
1551         * rendering/RenderText.h:
1552         (WebCore::RenderText::nodeAtPoint):
1553         * rendering/RenderTextControl.cpp:
1554         (WebCore::RenderTextControl::nodeAtPoint):
1555         * rendering/RenderTextControl.h:
1556         * rendering/RootInlineBox.cpp:
1557         (WebCore::RootInlineBox::nodeAtPoint):
1558         * rendering/RootInlineBox.h:
1559
1560 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
1561
1562         Reviewed by Maciej.
1563
1564         Bug 11442: [CSS 3] support for cursor: all-scroll
1565         http://bugs.webkit.org/show_bug.cgi?id=11442
1566
1567         * css/CSSComputedStyleDeclaration.cpp:
1568         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1569         * css/CSSValueKeywords.in:
1570         * css/cssparser.cpp:
1571         (WebCore::CSSParser::parseValue):
1572         * page/FrameView.cpp:
1573         (WebCore::selectCursor):
1574         * rendering/RenderStyle.h:
1575
1576 2006-10-31  Oliver Hunt  <oliver@apple.com>
1577
1578         Reviewed by Geoff.
1579
1580         Converting Obj-C++ to C++ in kcanvas
1581
1582         * WebCore.xcodeproj/project.pbxproj:
1583         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1584         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1585         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
1586         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
1587         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
1588         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1589         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
1590         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1591         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1592         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
1593         * kcanvas/device/quartz/QuartzSupport.h:
1594         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
1595         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
1596         (WebCore::SVGResourceClipper::applyClip):
1597         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
1598         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
1599         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
1600
1601 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
1602
1603         Reviewed by harrison
1604         
1605         <rdar://problem/4808375>
1606         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
1607         
1608         Completely back out r17276 because of performance issues.
1609
1610         * editing/TextIterator.cpp:
1611         (WebCore::TextIterator::TextIterator):
1612         (WebCore::TextIterator::advance):
1613         (WebCore::TextIterator::handleTextNode):
1614         (WebCore::TextIterator::handleTextBox):
1615         (WebCore::TextIterator::handleReplacedElement):
1616         (WebCore::TextIterator::handleNonTextNode):
1617         (WebCore::TextIterator::exitNode):
1618         (WebCore::TextIterator::emitCharacter):
1619         (WebCore::TextIterator::range):
1620         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
1621         (WebCore::SimplifiedBackwardsTextIterator::advance):
1622         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
1623         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
1624         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
1625         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
1626         (WebCore::SimplifiedBackwardsTextIterator::range):
1627         (WebCore::CharacterIterator::range):
1628         (WebCore::TextIterator::rangeFromLocationAndLength):
1629         * editing/TextIterator.h:
1630         (WebCore::TextIterator::atEnd):
1631         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
1632
1633 2006-10-31  Darin Adler  <darin@apple.com>
1634
1635         Reviewed by Brady.
1636
1637         - got "action dictionary" code out of FrameLoader,
1638           replacing with a class called NavigationAction
1639
1640         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
1641         * loader/mac/DocumentLoaderMac.mm:
1642         (WebCore::DocumentLoader::triggeringAction): Ditto.
1643         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
1644
1645         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
1646
1647         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
1648         Removed elementForEvent.
1649         * loader/mac/FrameLoaderMac.mm:
1650         (WebCore::FrameLoader::load): Ditto.
1651         (WebCore::FrameLoader::reload): Ditto.
1652         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
1653         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
1654         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
1655         (WebCore::FrameLoader::post): Ditto.
1656
1657         * loader/NavigationAction.h: Added.
1658         * loader/NavigationAction.cpp: Added.
1659         * loader/mac/NavigationActionMac.mm: Added.
1660
1661         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
1662
1663         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
1664         * WebCore.exp: Updated.
1665
1666 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
1667
1668         Reviewed by Adam.
1669
1670         Build fix
1671
1672         * platform/win/CookieJarWin.cpp:
1673         (WebCore::cookies):
1674
1675 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1676
1677         Reviewed by Maciej. Landed by Adam.
1678
1679         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
1680
1681         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
1682         as dicussed with Dave. Also kill the outdated DESIGN document.
1683
1684         * CMakeLists.txt:
1685         * WebCore.xcodeproj/project.pbxproj:
1686         * kcanvas/DESIGN: Removed.
1687         * kcanvas/KCanvasFilters.cpp:
1688         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
1689         * kcanvas/KCanvasTreeDebug.h: Ditto.
1690         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1691         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1692         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1693         * platform/graphics/svg/SVGResourceClipper.cpp:
1694         * rendering/RenderTreeAsText.cpp:
1695         * rendering/SVGRenderTreeAsText.cpp: Added.
1696         * rendering/SVGRenderTreeAsText.h: Added.
1697         (WebCore::operator<<):
1698
1699 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
1700
1701         Reviewed by Maciej.
1702
1703         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
1704         Includes some CRLF -> LF fixups.
1705
1706         * platform/win/CookieJarWin.cpp:
1707         (WebCore::cookies):
1708
1709 2006-10-31  Adam Roben  <aroben@apple.com>
1710
1711         Reviewed by Steve.
1712
1713         Fix some incorrect forward declarations.
1714
1715         * loader/FrameLoader.h:
1716         * page/Frame.h:
1717
1718 2006-10-31  Darin Adler  <darin@apple.com>
1719
1720         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
1721         try to fix the build on the buildbot.
1722
1723 2006-10-31  Darin Adler  <darin@apple.com>
1724
1725         * bridge/mac/FrameMac.mm:
1726         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
1727         (WebCore::FrameMac::markMisspellings): Ditto.
1728
1729 2006-10-31  John Sullivan  <sullivan@apple.com>
1730
1731         * bridge/mac/FrameMac.mm:
1732         (WebCore::FrameMac::advanceToNextMisspelling):
1733         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
1734
1735 2006-10-30  John Sullivan  <sullivan@apple.com>
1736
1737         Reviewed by Adam Roben
1738         
1739         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
1740         
1741         This patch introduces much of the guts of grammar checking, though still not enough to actually
1742         check grammar sensibly, due to:
1743           
1744         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
1745         context passed to grammar checker
1746
1747         * platform/Logging.h:
1748         * platform/Logging.cpp:
1749         new log channel SpellingAndGrammar
1750
1751         * bridge/mac/WebCorePageBridge.mm:
1752         (initializeLoggingChannelsIfNecessary):
1753         initialize new log channel
1754
1755         * bridge/mac/FrameMac.mm:
1756         (WebCore::FrameMac::advanceToNextMisspelling):
1757         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
1758         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
1759         in the event of a tie), and do further processing with that one (select range; create marker that
1760         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
1761         (WebCore::FrameMac::markMisspellings):
1762         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
1763         differently enough to make sharing code between these two functions a little tricky, so I decided to 
1764         save that for a later patch.
1765         
1766         (WebCore::FrameMac::respondToChangedSelection):
1767         remove grammar markers when we remove spelling markers        
1768
1769 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
1770
1771         Reviewed by Mitz.
1772
1773         Fix Qt/Linux build with older gcc3.3.4.
1774
1775         * bindings/js/kjs_window.cpp:
1776         (KJS::WindowFunc::callAsFunction):
1777
1778 2006-10-31  Zack Rusin  <zack@kde.org>
1779
1780         Reviewed by Mitz.
1781
1782         Fix the Qt build after last nights changes.
1783
1784         * WebCore/platform/qt/FrameQt.cpp:
1785         * WebCore/platform/qt/EditorClientQt.h:
1786         * WebCore/platform/qt/EditorClientQt.cpp:
1787         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1788         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1789         * WebCore/CMakeLists.txt:
1790         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
1791         * WebKitQt/QtLauncher/CMakeLists.txt:
1792         * WebKitQt/WebKitPart/CMakeLists.txt:
1793
1794 2006-10-30  Darin Adler  <darin@apple.com>
1795
1796         Reviewed by Anders.
1797
1798         - remove BrowserExtension
1799
1800         * WebCore.vcproj/WebCore/WebCore.vcproj:
1801         * WebCore.xcodeproj/project.pbxproj:
1802         * bindings/js/kjs_window.cpp:
1803         (KJS::createNewWindow):
1804         (KJS::WindowFunc::callAsFunction):
1805         * bridge/BrowserExtension.h: Removed.
1806         * bridge/mac/BrowserExtensionMac.h: Removed.
1807         * bridge/mac/BrowserExtensionMac.mm: Removed.
1808         * bridge/mac/FrameMac.mm:
1809         (WebCore::FrameMac::FrameMac):
1810         (WebCore::FrameMac::submitForm):
1811         (WebCore::FrameMac::urlSelected):
1812         * bridge/win/BrowserExtensionWin.cpp: Removed.
1813         * bridge/win/BrowserExtensionWin.h: Removed.
1814         * bridge/win/FrameWin.cpp:
1815         (WebCore::FrameWin::FrameWin):
1816         * loader/FrameLoader.cpp:
1817         (WebCore::FrameLoader::createWindow):
1818         * loader/FrameLoader.h:
1819         * loader/icon/IconLoader.cpp:
1820         * loader/mac/FrameLoaderMac.mm:
1821         (WebCore::FrameLoader::safeLoad):
1822         (WebCore::FrameLoader::load):
1823         (WebCore::FrameLoader::createWindow):
1824         * page/Frame.cpp:
1825         (WebCore::Frame::urlSelected):
1826         (WebCore::Frame::requestFrame):
1827         (WebCore::Frame::submitForm):
1828         (WebCore::Frame::scheduleHistoryNavigation):
1829         (WebCore::Frame::redirectionTimerFired):
1830         * page/Frame.h:
1831         * page/FrameLoadRequest.h:
1832         (WebCore::FrameLoadRequest::FrameLoadRequest):
1833         (WebCore::FrameLoadRequest::isEmpty):
1834         (WebCore::FrameLoadRequest::resourceRequest):
1835         (WebCore::FrameLoadRequest::frameName):
1836         (WebCore::FrameLoadRequest::setFrameName):
1837         * page/FramePrivate.h:
1838         (WebCore::FramePrivate::FramePrivate):
1839         (WebCore::FramePrivate::~FramePrivate):
1840         * platform/gdk/BrowserExtensionGdk.h: Removed.
1841         * platform/gdk/FrameGdk.cpp:
1842         (WebCore::FrameGdk::FrameGdk):
1843         * platform/gdk/TemporaryLinkStubs.cpp:
1844         * platform/network/ResourceRequest.h:
1845         (WebCore::ResourceRequest::isEmpty):
1846
1847 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1848
1849         Reviewed by Oliver.
1850
1851         Modified from original due to earlier reversion
1852
1853         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1854
1855         Better SVG integration in WebKit, Part I.
1856
1857         The patch is mostly about creating a new platform/graphics directory, and
1858         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1859         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1860         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1861
1862         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1863         All details of the patch, and upcoming patches can be found in the bug report.
1864
1865         * CMakeLists.txt:
1866         * WebCore.xcodeproj/project.pbxproj:
1867         * graphics/svg/SVGResource.cpp: Removed.
1868         * graphics/svg/SVGResourceClipper.cpp: Removed.
1869         * graphics/svg/SVGResourceClipper.h: Removed.
1870         * graphics/svg/SVGResourceImage.h: Removed.
1871         * graphics/svg/SVGResourceListener.h: Removed.
1872         * graphics/svg/SVGResourceMarker.cpp: Removed.
1873         * graphics/svg/SVGResourceMarker.h: Removed.
1874         * graphics/svg/SVGResourceMasker.cpp: Removed.
1875         * graphics/svg/SVGResourceMasker.h: Removed.
1876         * kcanvas/KCanvasClipper.cpp: Removed.
1877         * kcanvas/KCanvasClipper.h: Removed.
1878         * kcanvas/KCanvasCreator.cpp: Removed.
1879         * kcanvas/KCanvasCreator.h: Removed.
1880         * kcanvas/KCanvasFilters.cpp:
1881         (WebCore::getFilterById):
1882         * kcanvas/KCanvasFilters.h:
1883         * kcanvas/KCanvasImage.h: Removed.
1884         * kcanvas/KCanvasMarker.cpp: Removed.
1885         * kcanvas/KCanvasMarker.h: Removed.
1886         * kcanvas/KCanvasMasker.cpp: Removed.
1887         * kcanvas/KCanvasMasker.h: Removed.
1888         * kcanvas/KCanvasResource.cpp: Removed.
1889         * kcanvas/KCanvasResource.h: Removed.
1890         * kcanvas/KCanvasResourceListener.h: Removed.
1891         * kcanvas/KCanvasTreeDebug.cpp:
1892         (WebCore::writeRenderResources):
1893         * kcanvas/device/KRenderingDevice.h:
1894         * kcanvas/device/KRenderingPaintServer.h:
1895         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1896         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1897         (WebCore::KRenderingPaintServerGradient::listener):
1898         (WebCore::KRenderingPaintServerGradient::setListener):
1899         * kcanvas/device/KRenderingPaintServerGradient.h:
1900         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1901         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1902         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1903         (WebCore::KRenderingPaintServerPattern::tile):
1904         (WebCore::KRenderingPaintServerPattern::setTile):
1905         (WebCore::KRenderingPaintServerPattern::listener):
1906         (WebCore::KRenderingPaintServerPattern::setListener):
1907         * kcanvas/device/KRenderingPaintServerPattern.h:
1908         * kcanvas/device/KRenderingPaintServerSolid.h:
1909         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1910         * kcanvas/device/qt/KCanvasClipperQt.h:
1911         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1912         (WebCore::KRenderingDeviceQt::contextForImage):
1913         (WebCore::KRenderingDeviceQt::createResource):
1914         (WebCore::KRenderingDeviceQt::createPaintServer):
1915         * kcanvas/device/qt/KRenderingDeviceQt.h:
1916         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1917         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1918         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1919         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1920         * kcanvas/device/qt/RenderPathQt.h: Removed.
1921         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1922         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1923         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1924         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1925         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1926         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1927         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1928         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1929         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1930         (WebCore::KRenderingDeviceQuartz::contextForImage):
1931         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1932         (WebCore::KRenderingDeviceQuartz::createResource):
1933         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1934         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1935         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1936         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1937         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1938         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1939         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1940         (WebCore::patternCallback):
1941         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1942         * kcanvas/device/quartz/QuartzSupport.mm:
1943         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1944         (WebCore::sharedSolidPaintServer):
1945         * ksvg2/svg/SVGClipPathElement.cpp:
1946         (WebCore::SVGClipPathElement::SVGClipPathElement):
1947         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1948         (WebCore::SVGClipPathElement::canvasResource):
1949         * ksvg2/svg/SVGClipPathElement.h:
1950         * ksvg2/svg/SVGFEImageElement.cpp:
1951         * ksvg2/svg/SVGFilterElement.cpp:
1952         (WebCore::SVGFilterElement::SVGFilterElement):
1953         (WebCore::SVGFilterElement::~SVGFilterElement):
1954         (WebCore::SVGFilterElement::canvasResource):
1955         * ksvg2/svg/SVGFilterElement.h:
1956         * ksvg2/svg/SVGGradientElement.cpp:
1957         (WebCore::SVGGradientElement::SVGGradientElement):
1958         (WebCore::SVGGradientElement::~SVGGradientElement):
1959         (WebCore::SVGGradientElement::canvasResource):
1960         (WebCore::SVGGradientElement::resourceNotification):
1961         * ksvg2/svg/SVGGradientElement.h:
1962         * ksvg2/svg/SVGImageElement.cpp:
1963         * ksvg2/svg/SVGLinearGradientElement.cpp:
1964         (WebCore::SVGLinearGradientElement::buildGradient):
1965         * ksvg2/svg/SVGLinearGradientElement.h:
1966         * ksvg2/svg/SVGMarkerElement.cpp:
1967         (WebCore::SVGMarkerElement::SVGMarkerElement):
1968         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1969         (WebCore::SVGMarkerElement::canvasResource):
1970         * ksvg2/svg/SVGMarkerElement.h:
1971         * ksvg2/svg/SVGMaskElement.cpp:
1972         (WebCore::SVGMaskElement::SVGMaskElement):
1973         (WebCore::SVGMaskElement::~SVGMaskElement):
1974         (WebCore::SVGMaskElement::drawMaskerContent):
1975         (WebCore::SVGMaskElement::canvasResource):
1976         * ksvg2/svg/SVGMaskElement.h:
1977         * ksvg2/svg/SVGPatternElement.cpp:
1978         (WebCore::SVGPatternElement::SVGPatternElement):
1979         (WebCore::SVGPatternElement::~SVGPatternElement):
1980         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1981         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1982         (WebCore::SVGPatternElement::canvasResource):
1983         * ksvg2/svg/SVGPatternElement.h:
1984         * ksvg2/svg/SVGRadialGradientElement.cpp:
1985         (WebCore::SVGRadialGradientElement::buildGradient):
1986         * ksvg2/svg/SVGRadialGradientElement.h:
1987         * ksvg2/svg/SVGStyledElement.h:
1988         (WebCore::SVGStyledElement::canvasResource):
1989         * platform/GraphicsContext.cpp: Removed.
1990         * platform/GraphicsContext.h: Removed.
1991         * platform/GraphicsTypes.cpp: Removed.
1992         * platform/GraphicsTypes.h: Removed.
1993         * platform/graphics/GraphicsContext.cpp:
1994         (WebCore::GraphicsContextState::GraphicsContextState):
1995         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1996         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1997         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1998         (WebCore::GraphicsContext::save):
1999         (WebCore::GraphicsContext::restore):
2000         (WebCore::GraphicsContext::font):
2001         (WebCore::GraphicsContext::setFont):
2002         (WebCore::GraphicsContext::pen):
2003         (WebCore::GraphicsContext::setPen):
2004         (WebCore::GraphicsContext::setFillColor):
2005         (WebCore::GraphicsContext::fillColor):
2006         (WebCore::GraphicsContext::updatingControlTints):
2007         (WebCore::GraphicsContext::setUpdatingControlTints):
2008         (WebCore::GraphicsContext::setPaintingDisabled):
2009         (WebCore::GraphicsContext::paintingDisabled):
2010         (WebCore::GraphicsContext::drawImage):
2011         (WebCore::GraphicsContext::drawText):
2012         (WebCore::GraphicsContext::drawHighlightForText):
2013         (WebCore::GraphicsContext::initFocusRing):
2014         (WebCore::GraphicsContext::clearFocusRing):
2015         (WebCore::GraphicsContext::focusRingBoundingRect):
2016         (WebCore::GraphicsContext::addFocusRingRect):
2017         (WebCore::GraphicsContext::focusRingWidth):
2018         (WebCore::GraphicsContext::focusRingOffset):
2019         (WebCore::GraphicsContext::focusRingRects):
2020         (WebCore::GraphicsContext::drawTiledImage):
2021         * platform/graphics/GraphicsContext.h:
2022         * platform/graphics/GraphicsTypes.cpp:
2023         (WebCore::):
2024         (WebCore::parseCompositeOperator):
2025         (WebCore::compositeOperatorName):
2026         (WebCore::parseLineCap):
2027         (WebCore::lineCapName):
2028         (WebCore::parseLineJoin):
2029         (WebCore::lineJoinName):
2030         * platform/graphics/GraphicsTypes.h:
2031         (WebCore::):
2032         * platform/graphics/svg/SVGResource.cpp: Added.
2033         (WebCore::SVGResource::SVGResource):
2034         (WebCore::SVGResource::~SVGResource):
2035         (WebCore::SVGResource::invalidate):
2036         (WebCore::SVGResource::addClient):
2037         (WebCore::SVGResource::clients):
2038         (WebCore::SVGResource::idInRegistry):
2039         (WebCore::SVGResource::setIdInRegistry):
2040         (WebCore::SVGResource::externalRepresentation):
2041         (WebCore::getResourceById):
2042         (WebCore::getPaintServerById):
2043         (WebCore::operator<<):
2044         * platform/graphics/svg/SVGResource.h: Added.
2045         (WebCore::):
2046         (WebCore::SVGResource::isPaintServer):
2047         (WebCore::SVGResource::isFilter):
2048         (WebCore::SVGResource::isClipper):
2049         (WebCore::SVGResource::isMarker):
2050         (WebCore::SVGResource::isMasker):
2051         (WebCore::SVGResourceListener::~SVGResourceListener):
2052         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
2053         (WebCore::SVGResourceClipper::SVGResourceClipper):
2054         (WebCore::SVGResourceClipper::~SVGResourceClipper):
2055         (WebCore::SVGResourceClipper::resetClipData):
2056         (WebCore::SVGResourceClipper::addClipData):
2057         (WebCore::SVGResourceClipper::clipData):
2058         (WebCore::SVGResourceClipper::externalRepresentation):
2059         (WebCore::operator<<):
2060         (WebCore::getClipperById):
2061         * platform/graphics/svg/SVGResourceClipper.h: Added.
2062         (WebCore::ClipDataList::addPath):
2063         (WebCore::SVGResourceClipper::isClipper):
2064         * platform/graphics/svg/SVGResourceImage.h: Added.
2065         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
2066         (WebCore::SVGResourceMarker::SVGResourceMarker):
2067         (WebCore::SVGResourceMarker::~SVGResourceMarker):
2068         (WebCore::SVGResourceMarker::setMarker):
2069         (WebCore::SVGResourceMarker::setRef):
2070         (WebCore::SVGResourceMarker::draw):
2071         (WebCore::SVGResourceMarker::externalRepresentation):
2072         (WebCore::getMarkerById):
2073         * platform/graphics/svg/SVGResourceMarker.h: Added.
2074         (WebCore::SVGResourceMarker::refX):
2075         (WebCore::SVGResourceMarker::refY):
2076         (WebCore::SVGResourceMarker::setAngle):
2077         (WebCore::SVGResourceMarker::setAutoAngle):
2078         (WebCore::SVGResourceMarker::angle):
2079         (WebCore::SVGResourceMarker::setUseStrokeWidth):
2080         (WebCore::SVGResourceMarker::useStrokeWidth):
2081         (WebCore::SVGResourceMarker::isMarker):
2082         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
2083         (WebCore::SVGResourceMasker::SVGResourceMasker):
2084         (WebCore::SVGResourceMasker::~SVGResourceMasker):
2085         (WebCore::SVGResourceMasker::setMask):
2086         (WebCore::SVGResourceMasker::mask):
2087         (WebCore::SVGResourceMasker::externalRepresentation):
2088         (WebCore::getMaskerById):
2089         * platform/graphics/svg/SVGResourceMasker.h: Added.
2090         (WebCore::SVGResourceMasker::isMasker):
2091         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
2092         (WebCore::SVGResourceClipper::applyClip):
2093         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
2094         (WebCore::SVGResourceImage::SVGResourceImage):
2095         (WebCore::SVGResourceImage::~SVGResourceImage):
2096         (WebCore::SVGResourceImage::init):
2097         (WebCore::SVGResourceImage::size):
2098         (WebCore::SVGResourceImage::cgLayer):
2099         (WebCore::SVGResourceImage::setCGLayer):
2100         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
2101         (WebCore::applyLuminanceToAlphaFilter):
2102         (WebCore::applyExpandAlphatoGrayscaleFilter):
2103         (WebCore::transformImageIntoGrayscaleMask):
2104         (WebCore::SVGResourceMasker::applyMask):
2105         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
2106         (WebCore::SVGResourceClipper::applyClip):
2107         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
2108         (WebCore::SVGResourceImage::init):
2109         (WebCore::SVGResourceImage::size):
2110         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
2111         (WebCore::SVGResourceMasker::applyMask):
2112         * platform/qt/GraphicsContextQt.cpp:
2113         * rendering/RenderPath.cpp:
2114         (WebCore::RenderPath::paint):
2115         (WebCore::DrawMarkersData::DrawMarkersData):
2116         (WebCore::RenderPath::drawMarkersIfNeeded):
2117         * rendering/RenderSVGContainer.cpp:
2118         (WebCore::RenderSVGContainer::paint):
2119         * rendering/RenderSVGImage.cpp:
2120         (WebCore::RenderSVGImage::paint):
2121         * rendering/SVGInlineFlowBox.cpp:
2122         (WebCore::paintSVGInlineFlow):
2123
2124 2006-10-30  John Sullivan  <sullivan@apple.com>
2125
2126         Reviewed by Brady
2127         
2128         - minor cleanup to make future patches clearer
2129
2130         * bridge/mac/FrameMac.mm:
2131         (WebCore::FrameMac::advanceToNextMisspelling):
2132         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
2133         with "continue" to better match structure of similar code in markMisspellings; a few
2134         other style tweaks.
2135         
2136         (WebCore::FrameMac::markMisspellings):
2137         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
2138         a block just after a break and outdented accordingly.
2139
2140 2006-10-30  John Sullivan  <sullivan@apple.com>
2141
2142         Reviewed by Geoff Garen
2143         
2144         WebCore part of change to push the code that updates the spelling panel
2145         into WebCore, in preparation for some grammar-checking stuff.
2146
2147         * bridge/mac/FrameMac.h:
2148         * bridge/mac/FrameMac.mm:
2149         (WebCore::FrameMac::advanceToNextMisspelling):
2150         no more return value for this method, and update the spelling panel with
2151         the misspelled word here rather than in the WebKit callers.
2152
2153 2006-10-30  Oliver Hunt  <oliver@apple.com>
2154
2155         Reviewed by Anders.
2156
2157         Roll out last patch
2158
2159         * CMakeLists.txt:
2160         * ChangeLog:
2161         * WebCore.xcodeproj/project.pbxproj:
2162         * graphics/svg/SVGResource.cpp:
2163         * graphics/svg/SVGResourceClipper.cpp:
2164         * graphics/svg/SVGResourceClipper.h:
2165         * graphics/svg/SVGResourceImage.h:
2166         * graphics/svg/SVGResourceListener.h:
2167         * graphics/svg/SVGResourceMarker.cpp:
2168         * graphics/svg/SVGResourceMarker.h:
2169         * graphics/svg/SVGResourceMasker.cpp:
2170         * graphics/svg/SVGResourceMasker.h:
2171         * kcanvas/KCanvasClipper.cpp: Added.
2172         (WebCore::operator<<):
2173         (WebCore::KCanvasClipper::KCanvasClipper):
2174         (WebCore::KCanvasClipper::~KCanvasClipper):
2175         (WebCore::KCanvasClipper::resetClipData):
2176         (WebCore::KCanvasClipper::addClipData):
2177         (WebCore::KCanvasClipper::clipData):
2178         (WebCore::KCanvasClipper::externalRepresentation):
2179         (WebCore::getClipperById):
2180         * kcanvas/KCanvasClipper.h: Added.
2181         (WebCore::KCClipData::windRule):
2182         (WebCore::KCClipDataList::KCClipDataList):
2183         (WebCore::KCClipDataList::addPath):
2184         (WebCore::KCanvasClipper::isClipper):
2185         * kcanvas/KCanvasFilters.cpp:
2186         (WebCore::getFilterById):
2187         * kcanvas/KCanvasFilters.h:
2188         * kcanvas/KCanvasImage.h: Added.
2189         (WebCore::KCanvasImage::KCanvasImage):
2190         (WebCore::KCanvasImage::~KCanvasImage):
2191         * kcanvas/KCanvasMarker.cpp: Added.
2192         (WebCore::KCanvasMarker::KCanvasMarker):
2193         (WebCore::KCanvasMarker::~KCanvasMarker):
2194         (WebCore::KCanvasMarker::setMarker):
2195         (WebCore::KCanvasMarker::setRef):
2196         (WebCore::KCanvasMarker::refX):
2197         (WebCore::KCanvasMarker::refY):
2198         (WebCore::KCanvasMarker::setAngle):
2199         (WebCore::KCanvasMarker::angle):
2200         (WebCore::KCanvasMarker::setAutoAngle):
2201         (WebCore::KCanvasMarker::setUseStrokeWidth):
2202         (WebCore::KCanvasMarker::useStrokeWidth):
2203         (WebCore::KCanvasMarker::draw):
2204         (WebCore::KCanvasMarker::externalRepresentation):
2205         (WebCore::getMarkerById):
2206         * kcanvas/KCanvasMarker.h: Added.
2207         (WebCore::KCanvasMarker::isMarker):
2208         * kcanvas/KCanvasMasker.cpp: Added.
2209         (WebCore::KCanvasMasker::KCanvasMasker):
2210         (WebCore::KCanvasMasker::~KCanvasMasker):
2211         (WebCore::KCanvasMasker::setMask):
2212         (WebCore::KCanvasMasker::externalRepresentation):
2213         (WebCore::getMaskerById):
2214         * kcanvas/KCanvasMasker.h: Added.
2215         (WebCore::KCanvasMasker::isMasker):
2216         (WebCore::KCanvasMasker::mask):
2217         * kcanvas/KCanvasResource.cpp: Added.
2218         (WebCore::operator<<):
2219         (WebCore::KCanvasResource::KCanvasResource):
2220         (WebCore::KCanvasResource::~KCanvasResource):
2221         (WebCore::KCanvasResource::addClient):
2222         (WebCore::KCanvasResource::clients):
2223         (WebCore::KCanvasResource::invalidate):
2224         (WebCore::KCanvasResource::idInRegistry):
2225         (WebCore::KCanvasResource::setIdInRegistry):
2226         (WebCore::KCanvasResource::externalRepresentation):
2227         (WebCore::getResourceById):
2228         (WebCore::getPaintServerById):
2229         * kcanvas/KCanvasResource.h:
2230         (WebCore::):
2231         (WebCore::KCanvasResource::isPaintServer):
2232         (WebCore::KCanvasResource::isFilter):
2233         (WebCore::KCanvasResource::isClipper):
2234         (WebCore::KCanvasResource::isMarker):
2235         (WebCore::KCanvasResource::isMasker):
2236         * kcanvas/KCanvasResourceListener.h: Added.
2237         (KCanvasResourceListener::KCanvasResourceListener):
2238         (KCanvasResourceListener::~KCanvasResourceListener):
2239         * kcanvas/KCanvasTreeDebug.cpp:
2240         (WebCore::writeRenderResources):
2241         * kcanvas/device/KRenderingDevice.h:
2242         * kcanvas/device/KRenderingPaintServer.h:
2243         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2244         (WebCore::KRenderingPaintServer::idInRegistry):
2245         (WebCore::KRenderingPaintServer::setIdInRegistry):
2246         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2247         (WebCore::KRenderingPaintServerGradient::listener):
2248         (WebCore::KRenderingPaintServerGradient::setListener):
2249         * kcanvas/device/KRenderingPaintServerGradient.h:
2250         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2251         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2252         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2253         (WebCore::KRenderingPaintServerPattern::tile):
2254         (WebCore::KRenderingPaintServerPattern::setTile):
2255         (WebCore::KRenderingPaintServerPattern::listener):
2256         (WebCore::KRenderingPaintServerPattern::setListener):
2257         * kcanvas/device/KRenderingPaintServerPattern.h:
2258         * kcanvas/device/KRenderingPaintServerSolid.h:
2259         * kcanvas/device/qt/KCanvasClipperQt.cpp:
2260         (WebCore::KCanvasClipperQt::applyClip):
2261         * kcanvas/device/qt/KCanvasClipperQt.h:
2262         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
2263         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2264         (WebCore::KRenderingDeviceQt::contextForImage):
2265         (WebCore::KRenderingDeviceQt::createResource):
2266         (WebCore::KRenderingDeviceQt::createPaintServer):
2267         * kcanvas/device/qt/KRenderingDeviceQt.h:
2268         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
2269         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
2270         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
2271         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
2272         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2273         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
2274         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2275         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2276         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
2277         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2278         (WebCore::applyLuminanceToAlphaFilter):
2279         (WebCore::applyExpandAlphatoGrayscaleFilter):
2280         (WebCore::transformImageIntoGrayscaleMask):
2281         (WebCore::KCanvasMaskerQuartz::applyMask):
2282         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2283         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
2284         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
2285         (WebCore::KCanvasImageQuartz::init):
2286         (WebCore::KCanvasImageQuartz::size):
2287         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2288         (WebCore::KCanvasClipperQuartz::applyClip):
2289         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
2290         (WebCore::KCanvasImageQuartz::cgLayer):
2291         (WebCore::KCanvasImageQuartz::setCGLayer):
2292         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2293         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2294         (WebCore::KRenderingDeviceQuartz::contextForImage):
2295         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2296         (WebCore::KRenderingDeviceQuartz::createResource):
2297         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2298         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
2299         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
2300         (WebCore::KRenderingPaintServerGradientQuartz::setup):
2301         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2302         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2303         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2304         (WebCore::patternCallback):
2305         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2306         * kcanvas/device/quartz/QuartzSupport.mm:
2307         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2308         (WebCore::sharedSolidPaintServer):
2309         * ksvg2/svg/SVGClipPathElement.cpp:
2310         (WebCore::SVGClipPathElement::SVGClipPathElement):
2311         (WebCore::SVGClipPathElement::~SVGClipPathElement):
2312         (WebCore::SVGClipPathElement::canvasResource):
2313         * ksvg2/svg/SVGClipPathElement.h:
2314         * ksvg2/svg/SVGFEImageElement.cpp:
2315         * ksvg2/svg/SVGFilterElement.cpp:
2316         (WebCore::SVGFilterElement::SVGFilterElement):
2317         (WebCore::SVGFilterElement::~SVGFilterElement):
2318         (WebCore::SVGFilterElement::canvasResource):
2319         * ksvg2/svg/SVGFilterElement.h:
2320         * ksvg2/svg/SVGGradientElement.cpp:
2321         (WebCore::SVGGradientElement::SVGGradientElement):
2322         (WebCore::SVGGradientElement::~SVGGradientElement):
2323         (WebCore::SVGGradientElement::canvasResource):
2324         (WebCore::SVGGradientElement::resourceNotification):
2325         * ksvg2/svg/SVGGradientElement.h:
2326         * ksvg2/svg/SVGImageElement.cpp:
2327         * ksvg2/svg/SVGLinearGradientElement.cpp:
2328         (WebCore::SVGLinearGradientElement::buildGradient):
2329         * ksvg2/svg/SVGLinearGradientElement.h:
2330         * ksvg2/svg/SVGMarkerElement.cpp:
2331         (WebCore::SVGMarkerElement::SVGMarkerElement):
2332         (WebCore::SVGMarkerElement::~SVGMarkerElement):
2333         (WebCore::SVGMarkerElement::canvasResource):
2334         * ksvg2/svg/SVGMarkerElement.h:
2335         * ksvg2/svg/SVGMaskElement.cpp:
2336         (WebCore::SVGMaskElement::SVGMaskElement):
2337         (WebCore::SVGMaskElement::~SVGMaskElement):
2338         (WebCore::SVGMaskElement::drawMaskerContent):
2339         (WebCore::SVGMaskElement::canvasResource):
2340         * ksvg2/svg/SVGMaskElement.h:
2341         * ksvg2/svg/SVGPatternElement.cpp:
2342         (WebCore::SVGPatternElement::SVGPatternElement):
2343         (WebCore::SVGPatternElement::~SVGPatternElement):
2344         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2345         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
2346         (WebCore::SVGPatternElement::canvasResource):
2347         * ksvg2/svg/SVGPatternElement.h:
2348         * ksvg2/svg/SVGRadialGradientElement.cpp:
2349         (WebCore::SVGRadialGradientElement::buildGradient):
2350         * ksvg2/svg/SVGRadialGradientElement.h:
2351         * ksvg2/svg/SVGStyledElement.h:
2352         (WebCore::SVGStyledElement::canvasResource):
2353         * platform/GraphicsContext.cpp: Added.
2354         (WebCore::GraphicsContextState::GraphicsContextState):
2355         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
2356         (WebCore::GraphicsContext::createGraphicsContextPrivate):
2357         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
2358         (WebCore::GraphicsContext::save):
2359         (WebCore::GraphicsContext::restore):
2360         (WebCore::GraphicsContext::font):
2361         (WebCore::GraphicsContext::setFont):
2362         (WebCore::GraphicsContext::pen):
2363         (WebCore::GraphicsContext::setPen):
2364         (WebCore::GraphicsContext::setFillColor):
2365         (WebCore::GraphicsContext::fillColor):
2366         (WebCore::GraphicsContext::updatingControlTints):
2367         (WebCore::GraphicsContext::setUpdatingControlTints):
2368         (WebCore::GraphicsContext::setPaintingDisabled):
2369         (WebCore::GraphicsContext::paintingDisabled):
2370         (WebCore::GraphicsContext::drawImage):
2371         (WebCore::GraphicsContext::drawText):
2372         (WebCore::GraphicsContext::drawHighlightForText):
2373         (WebCore::GraphicsContext::initFocusRing):
2374         (WebCore::GraphicsContext::clearFocusRing):
2375         (WebCore::GraphicsContext::focusRingBoundingRect):
2376         (WebCore::GraphicsContext::addFocusRingRect):
2377         (WebCore::GraphicsContext::focusRingWidth):
2378         (WebCore::GraphicsContext::focusRingOffset):
2379         (WebCore::GraphicsContext::focusRingRects):
2380         (WebCore::GraphicsContext::drawTiledImage):
2381         * platform/GraphicsContext.h: Added.
2382         * platform/GraphicsTypes.cpp: Added.
2383         (WebCore::):
2384         (WebCore::parseCompositeOperator):
2385         (WebCore::compositeOperatorName):
2386         (WebCore::parseLineCap):
2387         (WebCore::lineCapName):
2388         (WebCore::parseLineJoin):
2389         (WebCore::lineJoinName):
2390         * platform/GraphicsTypes.h: Added.
2391         (WebCore::):
2392         * platform/graphics/GraphicsContext.cpp:
2393         * platform/graphics/GraphicsContext.h:
2394         * platform/graphics/GraphicsTypes.cpp:
2395         * platform/graphics/GraphicsTypes.h:
2396         * platform/qt/GraphicsContextQt.cpp:
2397         * rendering/RenderPath.cpp:
2398         (WebCore::RenderPath::paint):
2399         (WebCore::DrawMarkersData::DrawMarkersData):
2400         (WebCore::RenderPath::drawMarkersIfNeeded):
2401         * rendering/RenderSVGContainer.cpp:
2402         (WebCore::RenderSVGContainer::paint):
2403         * rendering/RenderSVGImage.cpp:
2404         (WebCore::RenderSVGImage::paint):
2405         * rendering/SVGInlineFlowBox.cpp:
2406         (WebCore::paintSVGInlineFlow):
2407
2408 2006-10-30  John Sullivan  <sullivan@apple.com>
2409
2410         Reviewed by Geoff Garen.
2411         
2412         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
2413         grammar-related method.
2414
2415         * bridge/EditorClient.h:
2416         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
2417         isGrammarCheckingEnabled()
2418         
2419         * bridge/mac/WebCoreFrameBridge.h:
2420         removed bridge equivalents
2421
2422         * bridge/mac/FrameMac.mm:
2423         (WebCore::FrameMac::advanceToNextMisspelling):
2424         convert bridge-using code to editor()->client()-using code
2425         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
2426         ditto
2427         (WebCore::FrameMac::markMisspellings):
2428         ditto
2429         (WebCore::FrameMac::respondToChangedSelection):
2430         ditto
2431         
2432         * editing/Editor.h:
2433         * editing/Editor.cpp:
2434         (WebCore::Editor::client):
2435         new method, returns EditorClient pointer. In an ideal world all the code that needed to
2436         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
2437         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
2438
2439 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
2440
2441         Reviewed by Darin.
2442
2443         Removed a number of editing and selection methods from the bridge.
2444         
2445         I moved cross-platform editing and selection code into Editor and 
2446         SelectionController, respecitvely.
2447
2448         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
2449         everything + the kitchen sink.
2450         
2451         Specific comments below for interesting things.
2452         
2453         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
2454         a new file so that WebKit can use them, too. Added a helper method for
2455         handling exceptions when selecting a Range.
2456         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
2457         WebKit, since they have to do with creating an NSAttributedString for API
2458         consumption, and not much to do with general Frame functionality.
2459         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
2460         for now) into the Editor. Eventually, the Frame will not have to notify 
2461         the Editor of what the lastEditCommand was, since the Editor will perform
2462         all EditCommands.
2463         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
2464         * editing/SelectionController.cpp:
2465         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
2466         and return them. The bridge method to select a DOM range did this implicitly,
2467         since all ObjC DOM operations handle DOM exceptions by throwing them as
2468         ObjC exceptions.
2469         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
2470         The two enumerations are numerically identical, but that's an implementation
2471         detail of TextAffinity that clients shouldn't be required to know about.
2472
2473 2006-10-30  Timothy Hatcher  <timothy@apple.com>
2474
2475         Rolling out the following change because this crash:
2476         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
2477
2478         And this regression:
2479         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
2480
2481     2006-09-06  David Harrison  <harrison@apple.com>
2482
2483         Reviewed and tweaked by Tim H. 
2484
2485         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
2486
2487         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
2488         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
2489         No layout tests affected. Not testable in an automated way that will work on all systems. 
2490
2491         * platform/mac/WebFontCache.mm: 
2492         (+[WebFontCache fontWithFamily:traits:size:]): 
2493
2494 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
2495
2496         Reviewed by harrison
2497
2498         <rdar://problem/4808375>
2499         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
2500
2501         * editing/TextIterator.cpp:
2502         (WebCore::TextIterator::exitNode): Only create VisiblePositions
2503         when we're going to use them to create a range for an emitted character.
2504         We should further speed TextIterators up by avoiding creating VisiblePositions
2505         for TIs that are only used for the characters they emit (like the one that 
2506         plainText uses).
2507
2508 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
2509
2510         Reviewed by Mitz.
2511
2512         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
2513         More rendering code cleaning
2514
2515         * WebCore.xcodeproj/project.pbxproj:
2516         * rendering/RenderApplet.cpp:
2517         (WebCore::RenderApplet::RenderApplet):
2518         (WebCore::RenderApplet::createWidgetIfNecessary):
2519         * rendering/RenderApplet.h:
2520         * rendering/RenderArena.cpp:
2521         (WebCore::):
2522         (WebCore::RenderArena::RenderArena):
2523         (WebCore::RenderArena::allocate):
2524         (WebCore::RenderArena::free):
2525         * rendering/RenderArena.h:
2526         * rendering/RenderBR.cpp:
2527         (WebCore::RenderBR::RenderBR):
2528         (WebCore::RenderBR::baselinePosition):
2529         (WebCore::RenderBR::lineHeight):
2530         (WebCore::RenderBR::setStyle):
2531         (WebCore::RenderBR::caretMinOffset):
2532         (WebCore::RenderBR::positionForCoordinates):
2533         (WebCore::RenderBR::inlineBox):
2534         * rendering/RenderBR.h:
2535         * rendering/RenderBlock.cpp:
2536         * rendering/RenderBlock.h:
2537         (WebCore::RenderBlock::maxTopMargin):
2538         (WebCore::RenderBlock::maxBottomMargin):
2539         (WebCore::RenderBlock::initMaxMarginValues):
2540         (WebCore::RenderBlock::containsFloats):
2541         (WebCore::RenderBlock::setHasMarkupTruncation):
2542         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
2543         (WebCore::RenderBlock::BlockSelectionInfo::block):
2544         (WebCore::RenderBlock::BlockSelectionInfo::state):
2545         (WebCore::RenderBlock::FloatingObject::FloatingObject):
2546         (WebCore::RenderBlock::CompactInfo::clear):
2547         * rendering/RenderButton.cpp:
2548         (WebCore::RenderButton::removeChild):
2549         (WebCore::RenderButton::paintObject):
2550         * rendering/RenderButton.h:
2551         (WebCore::RenderButton::renderName):
2552         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
2553         * rendering/RenderContainer.cpp:
2554         (WebCore::RenderContainer::RenderContainer):
2555         * rendering/RenderContainer.h:
2556         (WebCore::RenderContainer::firstChild):
2557         (WebCore::RenderContainer::lastChild):
2558         (WebCore::RenderContainer::calcMinMaxWidth):
2559         * rendering/RenderCounter.cpp:
2560         (WebCore::RenderCounter::RenderCounter):
2561         (WebCore::toRoman):
2562         (WebCore::toHebrew):
2563         (WebCore::RenderCounter::calcMinMaxWidth):
2564         * rendering/RenderCounter.h:
2565         * rendering/RenderFieldset.cpp:
2566         (WebCore::RenderFieldset::paintBoxDecorations):
2567         (WebCore::RenderFieldset::paintBorderMinusLegend):
2568         (WebCore::RenderFieldset::setStyle):
2569         * rendering/RenderFileUploadControl.cpp:
2570         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
2571         (WebCore::RenderFileUploadControl::setStyle):
2572         (WebCore::RenderFileUploadControl::paintObject):
2573         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
2574         * rendering/RenderFileUploadControl.h:
2575         (WebCore::RenderFileUploadControl::renderName):
2576         * rendering/RenderFlexibleBox.h:
2577         * rendering/RenderFlow.cpp:
2578         * rendering/RenderFlow.h:
2579         * rendering/RenderForeignObject.cpp:
2580         (WebCore::RenderForeignObject::RenderForeignObject):
2581         (WebCore::RenderForeignObject::paint):
2582         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
2583         (WebCore::RenderForeignObject::layout):
2584         (WebCore::RenderForeignObject::nodeAtPoint):
2585         * rendering/RenderForeignObject.h:
2586         (WebCore::RenderForeignObject::renderName):
2587         * rendering/RenderFormElement.cpp:
2588         (WebCore::RenderFormElement::setStyle):
2589         (WebCore::RenderFormElement::layout):
2590         (WebCore::RenderFormElement::textAlignment):
2591         * rendering/RenderFormElement.h:
2592         * rendering/RenderFrame.cpp:
2593         * rendering/RenderFrame.h:
2594         (WebCore::RenderFrame::element):
2595         * rendering/RenderFrameSet.cpp:
2596         * rendering/RenderFrameSet.h:
2597         (WebCore::RenderFrameSet::element):
2598         * rendering/RenderHTMLCanvas.cpp:
2599         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2600         (WebCore::RenderHTMLCanvas::paint):
2601         * rendering/RenderHTMLCanvas.h:
2602         (WebCore::RenderHTMLCanvas::renderName):
2603         * rendering/RenderImage.cpp:
2604         (WebCore::RenderImage::RenderImage):
2605         (WebCore::RenderImage::setStyle):
2606         (WebCore::RenderImage::setContentObject):
2607         (WebCore::RenderImage::setCachedImage):
2608         (WebCore::RenderImage::imageChanged):
2609         (WebCore::RenderImage::paint):
2610         (WebCore::RenderImage::layout):
2611         (WebCore::RenderImage::updateAltText):
2612         * rendering/RenderImage.h:
2613         (WebCore::RenderImage::element):
2614         * rendering/RenderInline.cpp:
2615         (WebCore::RenderInline::RenderInline):
2616         (WebCore::RenderInline::~RenderInline):
2617         (WebCore::RenderInline::setStyle):
2618         (WebCore::RenderInline::addChildToFlow):
2619         (WebCore::RenderInline::cloneInline):
2620         (WebCore::RenderInline::splitInlines):
2621         (WebCore::RenderInline::splitFlow):
2622         (WebCore::RenderInline::paint):
2623         (WebCore::RenderInline::absoluteRects):
2624         (WebCore::RenderInline::calcMinMaxWidth):
2625         (WebCore::RenderInline::requiresLayer):
2626         (WebCore::RenderInline::width):
2627         (WebCore::RenderInline::height):
2628         (WebCore::RenderInline::renderName):
2629         (WebCore::RenderInline::nodeAtPoint):
2630         (WebCore::RenderInline::positionForCoordinates):
2631         * rendering/RenderInline.h:
2632         (WebCore::RenderInline::layout):
2633         * rendering/RenderLayer.cpp:
2634         * rendering/RenderLayer.h:
2635         (WebCore::ClipRects::ClipRects):
2636         (WebCore::RenderLayer::nextSibling):
2637         (WebCore::RenderLayer::root):
2638         (WebCore::RenderLayer::setPos):
2639         (WebCore::RenderLayer::height):
2640         (WebCore::RenderLayer::relativePositionOffset):
2641         * rendering/RenderLineEdit.cpp:
2642         (WebCore::RenderLineEdit::setStyle):
2643         (WebCore::RenderLineEdit::updateFromElement):
2644         (WebCore::RenderLineEdit::selectionStart):
2645         (WebCore::RenderLineEdit::selectionEnd):
2646         (WebCore::RenderLineEdit::setSelectionStart):
2647         (WebCore::RenderLineEdit::setSelectionEnd):
2648         (WebCore::RenderLineEdit::setSelectionRange):
2649         * rendering/RenderLineEdit.h:
2650         * rendering/RenderListBox.cpp:
2651         * rendering/RenderListBox.h:
2652         (WebCore::RenderListBox::renderName):
2653         * rendering/RenderListItem.cpp:
2654         (WebCore::RenderListItem::setStyle):
2655         (WebCore::getParentOfFirstLineBox):
2656         (WebCore::RenderListItem::updateMarkerLocation):
2657         (WebCore::RenderListItem::positionListMarker):
2658         (WebCore::RenderListItem::paint):
2659         * rendering/RenderListItem.h:
2660         * rendering/RenderListMarker.cpp:
2661         * rendering/RenderListMarker.h:
2662         (WebCore::RenderListMarker::renderName):
2663         (WebCore::RenderListMarker::isListMarker):
2664
2665 2006-10-30  Timothy Hatcher  <timothy@apple.com>
2666
2667         Reviewed by Hyatt.
2668
2669         <rdar://problem/4478625> Basic table editing and culling
2670
2671         Refined the criteria for deletable elements, rely on the renderer more.
2672         Corrected the interface positioning for elements that have borders.
2673
2674         * editing/DeleteButtonController.cpp:
2675         (WebCore::isDeletableElement):
2676         (WebCore::DeleteButtonController::show):
2677
2678 2006-10-30  Darin Adler  <darin@apple.com>
2679
2680         - fix build
2681
2682         * loader/ResourceLoader.h: Added header guard.
2683
2684 2006-10-31  Darin Adler  <darin@apple.com>
2685
2686         Reviewed by Adam.
2687
2688         - fix FrameLoader files so they can be built on non-Mac platforms
2689
2690         * page/FramePrivate.h:
2691         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
2692         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
2693
2694         * page/Page.h:
2695         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
2696         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
2697         the other day.
2698
2699         * bridge/mac/FrameMac.mm:
2700         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
2701         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
2702
2703         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
2704         around the PolicyCheck definition.
2705
2706         * loader/FormState.cpp: Changed import to include.
2707         * loader/FrameLoader.cpp: Ditto.
2708         * loader/MainResourceLoader.h: Ditto.
2709
2710         * loader/FrameLoaderTypes.h: Added a header guard.
2711
2712         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
2713         Added #if PLATFORM(MAC) around Mac-specific details.
2714         * loader/SubresourceLoader.h: Ditto.
2715
2716         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
2717         m_loader from m_frameLoader.
2718
2719         * CMakeLists.txt: Updated.
2720         * WebCoreSources.bkl: Updated.
2721
2722 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
2723
2724         Reviewed and landed by Anders.
2725
2726         Patch by Zack rusin to fix: 
2727         http://bugs.webkit.org/show_bug.cgi?id=11429
2728
2729         Fix startup crash.
2730
2731         * platform/qt/FrameQtClient.cpp:
2732         (WebCore::FrameQtClientDefault::openURL):
2733
2734 2006-10-30  Zach Rusin  <zack@kde.org>
2735
2736         Reviewed and landed by Anders.
2737
2738         * platform/network/qt/ResourceHandleQt.cpp:
2739         (WebCore::ResourceHandle::receivedResponse):
2740         * platform/qt/FrameQtClient.cpp:
2741         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
2742         * platform/qt/LoaderFunctionsQt.cpp:
2743         (WebCore::ServeSynchronousRequest):
2744         More build fixes.
2745
2746 2006-10-30  Simon Hausmann  <hausmann@kde.org>
2747
2748         Reviewed and landed by Anders.
2749         
2750         - fix Qt build
2751         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
2752         ResourceHandleClient
2753
2754 2006-10-30  Darin Adler  <darin@apple.com>
2755
2756         Reviewed by John Sullivan.
2757
2758         - work toward removing Objective-C data types from FrameLoader.h:
2759           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
2760           and WebCoreResourceHandle
2761         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
2762
2763         * page/PageState.h:
2764         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
2765
2766         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
2767         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
2768         double for the date instead of an NSDate.
2769
2770         * bridge/mac/WebCoreFrameBridge.h:
2771         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
2772         saveDocumentToPageCache methods.
2773
2774         * bridge/mac/WebCorePageState.h:
2775         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
2776         an Objective-C wrapper for PageState.
2777
2778         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
2779         NSDate and WebCorePageState.
2780         * loader/FrameLoaderClient.h: Changed NSDate to double.
2781         * loader/mac/FrameLoaderMac.mm:
2782         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
2783         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
2784         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
2785         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
2786         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
2787         extract the parameters from the response. Changed the open function that takes
2788         a PageState to use the new C++ PageState.
2789         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
2790         function; tightened up logic, removing a few cases that could never happen, as
2791         well as the unused reload boolean.
2792
2793         * ForwardingHeaders/kjs/property_map.h: Added.
2794
2795         * WebCore.exp: Updated.
2796         * WebCore.xcodeproj/project.pbxproj: Updated.
2797
2798 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2799
2800         Reviewed by Anders.
2801
2802         - added ResourceResponse class and didReceiveResponse delegate call
2803         
2804         * WebCore.xcodeproj/project.pbxproj: Added new files.
2805         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
2806         expiresTimeForResponse: method.
2807         * dom/XMLTokenizer.cpp:
2808         (WebCore::openFunc): Updated to use ResourceResponse.
2809         * loader/FrameLoader.h: Update loadResourceSynchronously to
2810         use ResourceResponse.
2811         * loader/LoaderFunctions.h:
2812         * loader/icon/IconLoader.cpp:
2813         (IconLoader::didReceiveResponse): Updated from receivedResponse
2814         and made cross-platform.
2815         * loader/icon/IconLoader.h: updated for above change
2816         * loader/loader.cpp:
2817         (WebCore::Loader::receivedResponse): reduced to just saving
2818         the PlatformResponse (ideally we'd phase out use of this).
2819         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
2820         logic.
2821         * loader/loader.h:
2822         * loader/mac/FrameLoaderMac.mm:
2823         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2824         as ResourceResponse.
2825         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2826         * loader/mac/LoaderFunctionsMac.mm:
2827         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2828         argument.
2829         * platform/network/ResourceHandle.cpp:
2830         * platform/network/ResourceHandle.h: Remove calls for
2831         broken out response pieces.
2832         * platform/network/ResourceHandleClient.h:
2833         (WebCore::ResourceHandleClient::didReceiveResponse): New
2834         delegate method.
2835         * platform/network/ResourceHandleInternal.h:
2836         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2837         storage of response bits, we're not gonna return them
2838         seprately any more.
2839         * platform/network/ResourceResponse.h: Added.
2840         (WebCore::ResourceResponse::ResourceResponse): Freshly
2841         implemented. Same for below.
2842         (WebCore::ResourceResponse::url):
2843         (WebCore::ResourceResponse::mimeType):
2844         (WebCore::ResourceResponse::expectedContentLength):
2845         (WebCore::ResourceResponse::textEncodingName):
2846         (WebCore::ResourceResponse::suggestedFilename):
2847         (WebCore::ResourceResponse::httpStatusCode):
2848         (WebCore::ResourceResponse::setHTTPStatusCode):
2849         (WebCore::ResourceResponse::httpHeaderField):
2850         (WebCore::ResourceResponse::httpHeaderFields):
2851         (WebCore::ResourceResponse::isMultipart):
2852         (WebCore::ResourceResponse::setExpirationDate):
2853         (WebCore::ResourceResponse::expirationDate):
2854         * platform/network/cf/ResourceHandleCFNet.cpp:
2855         (WebCore::didReceiveResponse): Send didReceiveResponse
2856         client method.
2857         * platform/network/cf/ResourceResponseCFNet.h: Added.
2858         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2859         (getResourceResponse): Helper function to get a ResourceResponse 
2860         from CFURLResponseRef.
2861         * platform/network/mac/ResourceHandleMac.mm:
2862         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2863         Don't bother cleaning up fields we no longer have.
2864         (WebCore::ResourceHandle::receivedResponse): Send
2865         didReceiveResponse client method.
2866         * platform/network/mac/ResourceResponseMac.h: Added.
2867         * platform/network/mac/ResourceResponseMac.mm: Added.
2868         (getResourceResponse): Helper function to get a ResourceResponse 
2869         from an NSURLResponse*.
2870         * rendering/HitTestResult.cpp:
2871         * xml/XSLTProcessor.cpp:
2872         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2873         * xml/xmlhttprequest.cpp:
2874         (WebCore::XMLHttpRequest::getResponseText): Store http response
2875         info in the form of a ResourceResponse, change all methods to
2876         account for this.
2877         (WebCore::XMLHttpRequest::getResponseXML):
2878         (WebCore::XMLHttpRequest::XMLHttpRequest):
2879         (WebCore::XMLHttpRequest::open):
2880         (WebCore::XMLHttpRequest::send):
2881         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2882         (WebCore::XMLHttpRequest::getResponseHeader):
2883         (WebCore::XMLHttpRequest::getStatus):
2884         (WebCore::XMLHttpRequest::getStatusText):
2885         (WebCore::XMLHttpRequest::processSyncLoadResults):
2886         (WebCore::XMLHttpRequest::didFinishLoading):
2887         (WebCore::XMLHttpRequest::didReceiveResponse):
2888         (WebCore::XMLHttpRequest::didReceiveData):
2889         * xml/xmlhttprequest.h:
2890
2891 2006-10-29  Darin Adler  <darin@apple.com>
2892
2893         - fix build
2894
2895         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2896         * loader/NetscapePlugInStreamLoader.h: Ditto.
2897         * loader/ResourceLoader.h: Ditto.
2898
2899 2006-10-29  Darin Adler  <darin@apple.com>
2900
2901         - one last name change -- WebFormState.h to FormState.h
2902         - added more empty placeholder platform-independent files
2903           for currently-Mac-specific loader classes
2904
2905         * loader/FormState.cpp: Updated include.
2906         * loader/FrameLoader.cpp: Updated include.
2907         * loader/mac/FrameLoaderMac.mm: Updated include.
2908
2909         * loader/WebFormState.h: Removed.
2910         * loader/FormState.h: Added.
2911
2912         * loader/DocumentLoader.cpp: Added.
2913         * loader/MainResourceLoader.cpp: Added.
2914         * loader/NetscapePlugInStreamLoader.cpp: Added.
2915         * loader/ResourceLoader.cpp: Added.
2916         * loader/SubresourceLoader.cpp: Added.
2917
2918         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2919
2920 2006-10-29  Darin Adler  <darin@apple.com>
2921
2922         - did the do-webcore-rename renames, including a number of changes
2923           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2924           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2925           and improvements to the names of decoder classes and their source
2926           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2927
2928         * CMakeLists.txt:
2929         * WebCore.exp:
2930         * WebCore.vcproj/WebCore/WebCore.vcproj:
2931         * WebCore.xcodeproj/project.pbxproj:
2932         * WebCoreSources.bkl:
2933         * bindings/js/kjs_binding.cpp:
2934         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2935         * bindings/js/kjs_events.cpp:
2936         (KJS::JSAbstractEventListener::handleEvent):
2937         (KJS::JSLazyEventListener::parseCode):
2938         * bindings/js/kjs_html.cpp:
2939         (KJS::JSHTMLElement::implementsCall):
2940         * bindings/js/kjs_traversal.cpp:
2941         (KJS::JSNodeFilterCondition::acceptNode):
2942         * bindings/js/kjs_window.cpp:
2943         (KJS::Window::interpreter):
2944         (KJS::Window::retrieveWindow):
2945         (KJS::Window::retrieve):
2946         (KJS::ScheduledAction::execute):
2947         * bindings/objc/DOMInternal.mm:
2948         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2949         * bridge/mac/FrameMac.mm:
2950         (WebCore::FrameMac::executionContextForDOM):
2951         (WebCore::FrameMac::bindingRootObject):
2952         (WebCore::FrameMac::windowScriptObject):
2953         (WebCore::FrameMac::windowScriptNPObject):
2954         (WebCore::FrameMac::partClearedInBegin):
2955         * bridge/mac/WebCoreEncodings.mm:
2956         * bridge/mac/WebCoreFrameBridge.mm:
2957         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2958         (-[WebCoreFrameBridge stringWithData:]):
2959         (-[WebCoreFrameBridge executionContextForView:]):
2960         * bridge/win/FrameWin.cpp:
2961         * dom/Document.cpp:
2962         (WebCore::Document::inputEncoding):
2963         (WebCore::Document::setCharset):
2964         (WebCore::Document::createHTMLEventListener):
2965         (WebCore::Document::setDecoder):
2966         * dom/Document.h:
2967         (WebCore::Document::decoder):
2968         * dom/EventTargetNode.cpp:
2969         (WebCore::EventTargetNode::dispatchGenericEvent):
2970         * html/HTMLParser.cpp:
2971         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2972         (WebCore::HTMLParser::canvasCreateErrorCheck):
2973         (WebCore::HTMLParser::isInline):
2974         * html/HTMLPlugInElement.cpp:
2975         (WebCore::HTMLPlugInElement::createNPObject):
2976         * html/HTMLScriptElement.cpp:
2977         (WebCore::HTMLScriptElement::evaluateScript):
2978         * html/HTMLTokenizer.cpp:
2979         (WebCore::HTMLTokenizer::parseTag):
2980         (WebCore::HTMLTokenizer::processToken):
2981         * ksvg2/misc/SVGDocumentExtensions.cpp:
2982         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2983         * loader/CachedCSSStyleSheet.cpp:
2984         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2985         (WebCore::CachedCSSStyleSheet::setEncoding):
2986         * loader/CachedCSSStyleSheet.h:
2987         * loader/CachedXBLDocument.cpp:
2988         (WebCore::CachedXBLDocument::CachedXBLDocument):
2989         (WebCore::CachedXBLDocument::setEncoding):
2990         * loader/CachedXBLDocument.h:
2991         * loader/CachedXSLStyleSheet.cpp:
2992         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2993         (WebCore::CachedXSLStyleSheet::setEncoding):
2994         * loader/CachedXSLStyleSheet.h:
2995         * loader/Decoder.cpp: Removed.
2996         * loader/Decoder.h: Removed.
2997         * loader/FrameLoader.cpp:
2998         * loader/FrameLoader.h:
2999         * loader/FrameLoaderClient.h:
3000         * loader/MainResourceLoader.h: Added.
3001         * loader/NetscapePlugInStreamLoader.h: Added.
3002         * loader/Request.h:
3003         (WebCore::Request::cachedResource):
3004         * loader/ResourceLoader.h: Added.
3005         * loader/SubresourceLoader.h: Added.
3006         * loader/TextResourceDecoder.cpp: Added.
3007         (WebCore::TextResourceDecoder::determineContentType):
3008         (WebCore::TextResourceDecoder::defaultEncoding):
3009         (WebCore::TextResourceDecoder::TextResourceDecoder):
3010         (WebCore::TextResourceDecoder::~TextResourceDecoder):
3011         (WebCore::TextResourceDecoder::setEncoding):
3012         (WebCore::TextResourceDecoder::checkForBOM):
3013         (WebCore::TextResourceDecoder::checkForCSSCharset):
3014         (WebCore::TextResourceDecoder::checkForHeadCharset):
3015         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
3016         (WebCore::TextResourceDecoder::decode):
3017         (WebCore::TextResourceDecoder::flush):
3018         * loader/TextResourceDecoder.h: Added.
3019         * loader/WebDocumentLoader.h: Removed.
3020         * loader/WebLoader.h: Removed.
3021         * loader/WebMainResourceLoader.h: Removed.
3022         * loader/WebNetscapePlugInStreamLoader.h: Removed.
3023         * loader/WebSubresourceLoader.h: Removed.
3024         * loader/loader.cpp:
3025         (WebCore::Loader::servePendingRequests):
3026         (WebCore::Loader::receivedAllData):
3027         (WebCore::Loader::receivedResponse):
3028         (WebCore::Loader::didReceiveData):
3029         (WebCore::Loader::cancelRequests):
3030         (WebCore::Loader::jobForRequest):
3031         * loader/mac/DocumentLoaderMac.mm:
3032         * loader/mac/FormDataStream.m: Added.
3033         * loader/mac/FrameLoaderMac.mm:
3034         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3035         (WebCore::FrameLoader::addPlugInStreamLoader):
3036         (WebCore::FrameLoader::removePlugInStreamLoader):
3037         (WebCore::FrameLoader::addSubresourceLoader):
3038         (WebCore::FrameLoader::removeSubresourceLoader):
3039         (WebCore::FrameLoader::willSendRequest):
3040         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
3041         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
3042         (WebCore::FrameLoader::didReceiveResponse):
3043         (WebCore::FrameLoader::didReceiveData):
3044         (WebCore::FrameLoader::didFinishLoad):
3045         (WebCore::FrameLoader::didFailToLoad):
3046         (WebCore::FrameLoader::open):
3047         (WebCore::FrameLoader::willUseArchive):
3048         (WebCore::FrameLoader::isArchiveLoadPending):
3049         * loader/mac/ImageDocumentMac.mm:
3050         * loader/mac/LoaderFunctionsMac.mm:
3051         (WebCore::CheckCacheObjectStatus):
3052         * loader/mac/MainResourceLoaderMac.mm:
3053         (WebCore::MainResourceLoader::MainResourceLoader):
3054         (WebCore::MainResourceLoader::releaseDelegate):
3055         (WebCore::MainResourceLoader::didCancel):
3056         (WebCore::MainResourceLoader::addData):
3057         (WebCore::MainResourceLoader::willSendRequest):
3058         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3059         (WebCore::MainResourceLoader::didReceiveData):
3060         (WebCore::MainResourceLoader::didFinishLoading):
3061         (WebCore::MainResourceLoader::setDefersLoading):
3062         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
3063         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
3064         (WebCore::NetscapePlugInStreamLoader::releaseResources):
3065         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
3066         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
3067         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
3068         (WebCore::NetscapePlugInStreamLoader::didFail):
3069         (WebCore::NetscapePlugInStreamLoader::didCancel):
3070         * loader/mac/ResourceLoaderMac.mm:
3071         (WebCore::ResourceLoader::ResourceLoader):
3072         (WebCore::ResourceLoader::~ResourceLoader):
3073         (WebCore::ResourceLoader::releaseResources):
3074         (WebCore::ResourceLoader::load):
3075         (WebCore::ResourceLoader::setDefersLoading):
3076         (WebCore::ResourceLoader::frameLoader):
3077         (WebCore::ResourceLoader::addData):
3078         (WebCore::ResourceLoader::resourceData):
3079         (WebCore::ResourceLoader::clearResourceData):
3080         (WebCore::ResourceLoader::willSendRequest):
3081         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
3082         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
3083         (WebCore::ResourceLoader::didReceiveResponse):
3084         (WebCore::ResourceLoader::didReceiveData):
3085         (WebCore::ResourceLoader::willStopBufferingData):
3086         (WebCore::ResourceLoader::didFinishLoading):
3087         (WebCore::ResourceLoader::didFinishLoadingOnePart):
3088         (WebCore::ResourceLoader::didFail):
3089         (WebCore::ResourceLoader::willCacheResponse):
3090         (WebCore::ResourceLoader::didCancel):
3091         (WebCore::ResourceLoader::cancel):
3092         (WebCore::ResourceLoader::setIdentifier):
3093         (WebCore::ResourceLoader::response):
3094         (WebCore::ResourceLoader::inConnectionCallback):
3095         (WebCore::ResourceLoader::cancelledError):
3096         (WebCore::ResourceLoader::receivedCredential):
3097         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
3098         (WebCore::ResourceLoader::receivedCancellation):
3099         (WebCore::ResourceLoader::delegate):
3100         (WebCore::ResourceLoader::releaseDelegate):
3101         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
3102         * loader/mac/SubresourceLoaderMac.mm:
3103         (WebCore::SubresourceLoader::SubresourceLoader):
3104         (WebCore::SubresourceLoader::willSendRequest):
3105         (WebCore::SubresourceLoader::didReceiveResponse):
3106         (WebCore::SubresourceLoader::didReceiveData):
3107         (WebCore::SubresourceLoader::didFinishLoading):
3108         (WebCore::SubresourceLoader::didFail):
3109         (WebCore::SubresourceLoader::didCancel):
3110         * loader/mac/WebFormDataStream.h: Removed.
3111         * loader/mac/WebFormDataStream.m: Removed.
3112         * page/Frame.cpp:
3113         (WebCore::Frame::javaScriptEnabled):
3114         (WebCore::Frame::scriptProxy):
3115         (WebCore::Frame::executeScript):
3116         (WebCore::Frame::write):
3117         (WebCore::Frame::userGestureHint):
3118         (WebCore::Frame::saveInterpreterBuiltins):
3119         (WebCore::Frame::restoreInterpreterBuiltins):
3120         (WebCore::Frame::backslashAsCurrencySymbol):
3121         * page/Frame.h:
3122         * page/FramePrivate.h:
3123         * platform/StreamingTextDecoder.cpp: Removed.
3124         * platform/StreamingTextDecoder.h: Removed.
3125         * platform/StreamingTextDecoderICU.cpp: Removed.
3126         * platform/StreamingTextDecoderICU.h: Removed.
3127         * platform/TextCodec.cpp: Added.
3128         * platform/TextCodec.h: Added.
3129         * platform/TextCodecICU.cpp: Added.
3130         * platform/TextCodecICU.h: Added.
3131         * platform/TextCodecLatin1.h:
3132         * platform/TextCodecUTF16.h:
3133         * platform/TextDecoder.h:
3134         * platform/TextEncoding.cpp:
3135         * platform/TextEncodingRegistry.cpp:
3136         * platform/image-decoders/jpeg/jmorecfg.h:
3137         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
3138         * platform/mac/StreamingTextDecoderMac.h: Removed.
3139         * platform/mac/TextCodecMac.cpp: Added.
3140         * platform/mac/TextCodecMac.h: Added.
3141         * platform/network/ResourceHandleInternal.h:
3142         * platform/network/mac/ResourceHandleMac.mm:
3143         * platform/qt/FrameQt.cpp:
3144         (WebCore::FrameQt::bindingRootObject):
3145         * platform/qt/LoaderFunctionsQt.cpp:
3146         (WebCore::CheckCacheObjectStatus):
3147         * rendering/RenderObject.cpp:
3148         (WebCore::RenderObject::backslashAsCurrencySymbol):
3149         * xml/XSLTProcessor.cpp:
3150         (WebCore::XSLTProcessor::createDocumentFromSource):
3151         * xml/xmlhttprequest.cpp:
3152         (WebCore::XMLHttpRequest::didReceiveData):
3153         * xml/xmlhttprequest.h:
3154
3155 2006-10-29  Darin Adler  <darin@apple.com>
3156
3157         Rubber stamped by Adam (kinda).
3158
3159         - add Mac suffixes and correct filenames inside loader/mac
3160
3161         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
3162
3163         * loader/mac/FrameLoader.mm: Removed.
3164         * loader/mac/WebDocumentLoader.mm: Removed.
3165         * loader/mac/WebLoader.mm: Removed.
3166         * loader/mac/WebMainResourceLoader.mm: Removed.
3167         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
3168         * loader/mac/WebSubresourceLoader.mm: Removed.
3169
3170         * loader/mac/FrameLoaderMac.mm: Added.
3171         * loader/mac/DocumentLoaderMac.mm: Added.
3172         * loader/mac/ResourceLoaderMac.mm: Added.
3173         * loader/mac/MainResourceLoaderMac.mm: Added.
3174         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
3175         * loader/mac/SubresourceLoaderMac.mm: Removed.
3176
3177 2006-10-29  Darin Adler  <darin@apple.com>
3178
3179         Reviewed by Adam.
3180
3181         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
3182           and FrameLoader.cpp mostly ready
3183
3184         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
3185         FormState.cpp. Removed WebFormState.mm.
3186
3187         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
3188         get this header compiling on non-Mac.
3189         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
3190         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
3191
3192         * loader/FrameLoaderClient.h: Added some ifdefs.
3193         * loader/WebDocumentLoader.h: Ditto.
3194         * loader/WebLoader.h: Ditto.
3195         * loader/WebMainResourceLoader.h: Ditto.
3196
3197         * loader/mac/WebDocumentLoader.mm:
3198         (WebCore::DocumentLoader::isLoadingInAPISense):
3199         Rewrote to work without bridge, partly to remove the need for ObjC
3200         bridge type in the header, and also because we're tearing down the bridge.
3201
3202         * loader/mac/WebMainResourceLoader.mm:
3203         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
3204         m_contentLength and m_bytesReceived.
3205         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
3206         (WebCore::MainResourceLoader::didReceiveData): Ditto.
3207
3208         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
3209         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
3210
3211         * loader/mac/FormState.mm: Removed.
3212         * loader/FormState.cpp: Added.
3213
3214 2006-10-29  Darin Adler  <darin@apple.com>
3215
3216         Rubber stamped by Adam.
3217
3218         - moving towards use of FrameLoader cross-platform; move the headers
3219           for the Mac loader from loader/mac into loader, in preparation for
3220           making them useful on non-Mac
3221
3222         * WebCore.xcodeproj/project.pbxproj:
3223
3224         * loader/mac/FrameLoader.h: Removed.
3225         * loader/mac/WebDocumentLoader.h: Removed.
3226         * loader/mac/WebFormState.h: Removed.
3227         * loader/mac/WebLoader.h: Removed.
3228         * loader/mac/WebMainResourceLoader.h: Removed.
3229         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
3230         * loader/mac/WebSubresourceLoader.h: Removed.
3231
3232         * loader/FrameLoader.h: Added.
3233         * loader/WebDocumentLoader.h: Added.
3234         * loader/WebFormState.h: Added.
3235         * loader/WebLoader.h: Added.
3236         * loader/WebMainResourceLoader.h: Added.
3237         * loader/WebNetscapePlugInStreamLoader.h: Added.
3238         * loader/WebSubresourceLoader.h: Added.
3239
3240 2006-10-29  Adam Roben  <aroben@apple.com>
3241
3242         Reviewed by Geoff.
3243
3244         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
3245         r17405.
3246
3247         * platform/DeprecatedString.h:
3248
3249 2006-10-29  Beth Dakin  <bdakin@apple.com>
3250
3251         Rubber stamped by Geoff.
3252
3253         This is a followup to my HitTestResult checkin. Most of the 
3254         HitTestResult local variables in the code were named i or info for 
3255         when the class was named NodeInfo. This patch renames all of these 
3256         local variables to result.
3257
3258         * dom/Document.cpp:
3259         (WebCore::Document::prepareMouseEvent):
3260         * html/HTMLAreaElement.cpp:
3261         (WebCore::HTMLAreaElement::mapMouseEvent):
3262         * html/HTMLMapElement.cpp:
3263         (WebCore::HTMLMapElement::mapMouseEvent):
3264         * rendering/EllipsisBox.cpp:
3265         (WebCore::EllipsisBox::nodeAtPoint):
3266         * rendering/EllipsisBox.h:
3267         * rendering/InlineBox.cpp:
3268         (WebCore::InlineBox::nodeAtPoint):
3269         * rendering/InlineFlowBox.cpp:
3270         (WebCore::InlineFlowBox::nodeAtPoint):
3271         * rendering/InlineTextBox.cpp:
3272         (WebCore::InlineTextBox::nodeAtPoint):
3273         * rendering/RenderBlock.cpp:
3274         (WebCore::RenderBlock::isPointInScrollbar):
3275         (WebCore::RenderBlock::nodeAtPoint):
3276         * rendering/RenderBlock.h:
3277         * rendering/RenderBox.cpp:
3278         (WebCore::RenderBox::nodeAtPoint):
3279         * rendering/RenderBox.h:
3280         * rendering/RenderFlow.cpp:
3281         (WebCore::RenderFlow::hitTestLines):
3282         * rendering/RenderFlow.h:
3283         * rendering/RenderForeignObject.cpp:
3284         (WebCore::RenderForeignObject::nodeAtPoint):
3285         * rendering/RenderFrameSet.cpp:
3286         (WebCore::RenderFrameSet::nodeAtPoint):
3287         * rendering/RenderImage.cpp:
3288         (WebCore::RenderImage::nodeAtPoint):
3289         * rendering/RenderInline.cpp:
3290         (WebCore::RenderInline::nodeAtPoint):
3291         * rendering/RenderInline.h:
3292         * rendering/RenderLayer.cpp:
3293         (WebCore::RenderLayer::autoscroll):
3294         (WebCore::RenderLayer::hitTest):
3295         (WebCore::RenderLayer::hitTestLayer):
3296         (WebCore::RenderLayer::updateHoverActiveState):
3297         * rendering/RenderListBox.cpp:
3298         (WebCore::RenderListBox::isPointInScrollbar):
3299         * rendering/RenderObject.cpp:
3300         (WebCore::RenderObject::hitTest):
3301         (WebCore::RenderObject::setInnerNode):
3302         (WebCore::RenderObject::nodeAtPoint):
3303         * rendering/RenderObject.h:
3304         * rendering/RenderPath.cpp:
3305         (WebCore::RenderPath::nodeAtPoint):
3306         * rendering/RenderSVGImage.cpp:
3307         (WebCore::RenderSVGImage::nodeAtPoint):
3308         * rendering/RenderSVGText.cpp:
3309         (WebCore::RenderSVGText::nodeAtPoint):
3310         * rendering/RenderTableRow.cpp:
3311         (WebCore::RenderTableRow::nodeAtPoint):
3312         * rendering/RenderTableRow.h:
3313         * rendering/RenderTableSection.cpp:
3314         (WebCore::RenderTableSection::nodeAtPoint):
3315         * rendering/RenderTableSection.h:
3316         * rendering/RenderTextControl.cpp:
3317         (WebCore::RenderTextControl::nodeAtPoint):
3318         * rendering/RootInlineBox.cpp:
3319         (WebCore::RootInlineBox::nodeAtPoint):
3320         * rendering/RootInlineBox.h:
3321
3322 2006-10-29  Adam Roben  <aroben@apple.com>
3323
3324         More semi-fixes.
3325
3326         * page/Page.cpp: Forgot to wrap the actual definition of
3327         setDefersLoading() in PLATFORM(MAC).
3328         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
3329
3330 2006-10-29  Adam Roben  <aroben@apple.com>
3331
3332         Build semi-fix.
3333
3334         Move all FrameLoader-related code in Page.{cpp,h} within #if
3335         PLATFORM(MAC), since this class currently only exists on Mac.
3336
3337         * page/Page.cpp:
3338         * page/Page.h:
3339
3340 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
3341
3342         build fix.
3343         
3344         * platform/PlatformString.h:
3345         (WebCore::String::operator NSString*):
3346
3347 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
3348
3349         Rolled out accidental commit.
3350         
3351         * platform/AtomicString.h:
3352         (WebCore::AtomicString::AtomicString):
3353         (WebCore::AtomicString::operator NSString*):
3354
3355 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
3356
3357         RS by Darin.
3358
3359         Rolled out change to map NULL Strings to nil NSStrings because it caused
3360         even more AppKit crashes. Maybe we should remove the NSString * operator
3361         entirely, since its use is not straight-forward, and require callers to
3362         specify explicitly whether they tolerate NULL.
3363         
3364         * platform/AtomicString.h:
3365         * platform/PlatformString.h:
3366         (WebCore::String::operator NSString*):
3367         * platform/mac/TextFieldMac.mm:
3368         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3369
3370 2006-10-29  Darin Adler  <darin@apple.com>
3371
3372         Reviewed by Geoff.
3373
3374         - fixed storage leak showing up on the buildbot
3375
3376         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
3377         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
3378
3379 2006-10-29  Darin Adler  <darin@apple.com>
3380
3381         Rubber stamped by Adam.
3382
3383         - renamed WebFrameLoaderClient to match the class name inside it
3384
3385         * loader/mac/WebFrameLoaderClient.h: Removed.
3386         * loader/FrameLoaderClient.h: Moved it here.
3387
3388         * WebCore.xcodeproj/project.pbxproj: Updated project.
3389
3390         * bridge/mac/FrameMac.mm: Updated includes.
3391         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
3392         * loader/mac/FrameLoader.mm: Ditto.
3393         * loader/mac/WebLoader.h: Ditto.
3394
3395 2006-10-29  Darin Adler  <darin@apple.com>
3396
3397         Reviewed by Mitz.
3398
3399         - fix crash visible on buildbot and also when running the test
3400           anchor-image-scrolled-x-y.html under libgmalloc
3401
3402         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
3403         now that the class is named ResourceHandle.
3404         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
3405         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
3406         a local RefPtr before calling finishJobAndHandle, since we might get
3407         cancelled inside that function, so we should not rely on m_handle to
3408         keep the ResourceHandle alive.
3409         (WebCore::SubresourceLoader::didFail): Ditto.
3410         (WebCore::SubresourceLoader::didCancel): Ditto.
3411
3412 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
3413
3414         - build fix
3415
3416         * platform/network/mac/ResourceHandleMac.mm:
3417
3418 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
3419
3420         Rubber stamped by Darin.
3421
3422         - renamed ResourceLoader to ResourceHandle (and same for related classes)
3423
3424         * CMakeLists.txt:
3425         * Projects/gdk/webcore-gdk.bkl:
3426         * WebCore.vcproj/WebCore/WebCore.vcproj:
3427         * WebCore.xcodeproj/project.pbxproj:
3428         * WebCoreSources.bkl:
3429         * bridge/mac/FrameMac.mm:
3430         * bridge/win/FrameWin.cpp:
3431         * dom/XMLTokenizer.cpp:
3432         * loader/Cache.cpp:
3433         * loader/CachedResource.h:
3434         * loader/LoaderFunctions.h:
3435         * loader/icon/IconLoader.cpp:
3436         (IconLoader::startLoading):
3437         (IconLoader::didReceiveData):
3438         (IconLoader::didFinishLoading):
3439         * loader/icon/IconLoader.h:
3440         * loader/loader.cpp:
3441         (WebCore::Loader::servePendingRequests):
3442         (WebCore::Loader::receivedAllData):
3443         (WebCore::Loader::receivedResponse):
3444         (WebCore::Loader::didReceiveData):
3445         (WebCore::Loader::cancelRequests):
3446         (WebCore::Loader::jobForRequest):
3447         * loader/loader.h:
3448         * loader/mac/IconLoaderMac.mm:
3449         (IconLoader::receivedResponse):
3450         * loader/mac/LoaderFunctionsMac.mm:
3451         * loader/mac/WebLoader.h:
3452         * loader/mac/WebSubresourceLoader.h:
3453         * loader/mac/WebSubresourceLoader.mm:
3454         (WebCore::SubresourceLoader::SubresourceLoader):
3455         (WebCore::SubresourceLoader::create):
3456         * platform/gdk/FrameGdk.cpp:
3457         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
3458         (WebCore::FrameGdkClientDefault::openURL):
3459         (WebCore::FrameGdkClientDefault::submitForm):
3460         (WebCore::FrameGdkClientDefault::receivedResponse):
3461         (WebCore::FrameGdkClientDefault::didReceiveData):
3462         (WebCore::FrameGdkClientDefault::receivedAllData):
3463         * platform/gdk/FrameGdk.h:
3464         * platform/gdk/TemporaryLinkStubs.cpp:
3465         (WebCore::ServeSynchronousRequest):
3466         (WebCore::ResourceHandle::assembleResponseHeaders):
3467         (WebCore::ResourceHandle::retrieveCharset):
3468         * platform/network/ResourceHandle.cpp: Added.
3469         (WebCore::ResourceHandle::ResourceHandle):
3470         (WebCore::ResourceHandle::create):
3471         (WebCore::ResourceHandle::isErrorPage):
3472         (WebCore::ResourceHandle::error):
3473         (WebCore::ResourceHandle::setError):
3474         (WebCore::ResourceHandle::responseEncoding):
3475         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
3476         (WebCore::ResourceHandle::kill):
3477         (WebCore::ResourceHandle::requestHeaders):
3478         (WebCore::ResourceHandle::url):
3479         (WebCore::ResourceHandle::postData):
3480         (WebCore::ResourceHandle::method):
3481         (WebCore::ResourceHandle::client):
3482         * platform/network/ResourceHandle.h: Added.
3483         (WebCore::ResourceHandle::getInternal):
3484         * platform/network/ResourceHandleClient.h: Added.
3485         (WebCore::ResourceHandleClient::~ResourceHandleClient):
3486         (WebCore::ResourceHandleClient::didReceiveData):
3487         (WebCore::ResourceHandleClient::didFinishLoading):
3488         (WebCore::ResourceHandleClient::receivedRedirect):
3489         (WebCore::ResourceHandleClient::receivedResponse):
3490         (WebCore::ResourceHandleClient::receivedAllData):
3491         * platform/network/ResourceHandleInternal.h: Added.
3492         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3493         * platform/network/ResourceLoader.cpp: Removed.
3494         * platform/network/ResourceLoader.h: Removed.
3495         * platform/network/ResourceLoaderClient.h: Removed.
3496         * platform/network/ResourceLoaderInternal.h: Removed.
3497         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
3498         (WebCore::willSendRequest):
3499         (WebCore::didReceiveResponse):
3500         (WebCore::didReceiveData):
3501         (WebCore::didFinishLoading):
3502         (WebCore::didFail):
3503         (WebCore::willCacheResponse):
3504         (WebCore::didReceiveChallenge):
3505         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3506         (WebCore::ResourceHandle::~ResourceHandle):
3507         (WebCore::ResourceHandle::start):
3508         (WebCore::ResourceHandle::cancel):
3509         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
3510         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
3511         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3512         (WebCore::ResourceHandle::~ResourceHandle):
3513         (WebCore::ResourceHandle::start):
3514         (WebCore::ResourceHandle::cancel):
3515         * platform/network/gdk/ResourceHandleManager.cpp: Added.
3516         (WebCore::ResourceHandleManager::ResourceHandleManager):
3517         (WebCore::ResourceHandleManager::get):
3518         (WebCore::ResourceHandleManager::useSimpleTransfer):
3519         (WebCore::writeCallback):
3520         (WebCore::ResourceHandleManager::downloadTimerCallback):
3521         (WebCore::ResourceHandleManager::remove):
3522         (WebCore::ResourceHandleManager::add):
3523         (WebCore::ResourceHandleManager::cancel):
3524         * platform/network/gdk/ResourceHandleManager.h: Added.
3525         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
3526         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
3527         * platform/network/gdk/ResourceLoaderManager.h: Removed.
3528         * platform/network/mac/ResourceHandleMac.mm: Added.
3529         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3530         (WebCore::ResourceHandle::~ResourceHandle):
3531         (WebCore::ResourceHandle::start):
3532         (WebCore::ResourceHandle::assembleResponseHeaders):
3533         (WebCore::ResourceHandle::retrieveResponseEncoding):
3534         (WebCore::ResourceHandle::receivedResponse):
3535         (WebCore::ResourceHandle::cancel):
3536         (WebCore::ResourceHandle::redirectedToURL):
3537         (WebCore::ResourceHandle::addData):
3538         (WebCore::ResourceHandle::finishJobAndHandle):
3539         (WebCore::ResourceHandle::reportError):
3540         * platform/network/mac/ResourceLoaderMac.mm: Removed.
3541         * platform/network/qt/ResourceHandleManager.cpp: Added.
3542         (WebCore::ResourceHandleManager::ResourceHandleManager):
3543         (WebCore::ResourceHandleManager::~ResourceHandleManager):
3544         (WebCore::ResourceHandleManager::self):
3545         (WebCore::ResourceHandleManager::slotData):
3546         (WebCore::ResourceHandleManager::slotMimetype):
3547         (WebCore::ResourceHandleManager::slotResult):
3548         (WebCore::ResourceHandleManager::remove):
3549         (WebCore::ResourceHandleManager::add):
3550         (WebCore::ResourceHandleManager::cancel):
3551         * platform/network/qt/ResourceHandleManager.h: Added.
3552         * platform/network/qt/ResourceHandleQt.cpp: Added.
3553         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3554         (WebCore::ResourceHandle::~ResourceHandle):
3555         (WebCore::ResourceHandle::start):
3556         (WebCore::ResourceHandle::cancel):
3557         (WebCore::ResourceHandle::assembleResponseHeaders):
3558         (WebCore::ResourceHandle::retrieveResponseEncoding):
3559         (WebCore::ResourceHandle::receivedResponse):
3560         (WebCore::ResourceHandle::extractCharsetFromHeaders):
3561         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
3562         * platform/network/qt/ResourceLoaderManager.h: Removed.
3563         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
3564         * platform/network/win/ResourceHandleWin.cpp: Added.
3565         (WebCore::):
3566         (WebCore::addToOutstandingJobs):
3567         (WebCore::lookupResourceHandle):
3568         (WebCore::ResourceHandleWndProc):
3569         (WebCore::initializeOffScreenResourceHandleWindow):
3570         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3571         (WebCore::ResourceHandle::~ResourceHandle):
3572         (WebCore::ResourceHandle::onHandleCreated):
3573         (WebCore::ResourceHandle::onRequestRedirected):
3574         (WebCore::ResourceHandle::onRequestComplete):
3575         (WebCore::ResourceHandle::start):
3576         (WebCore::ResourceHandle::fileLoadTimer):
3577         (WebCore::ResourceHandle::cancel):
3578         (WebCore::ResourceHandle::setHasReceivedResponse):
3579         (WebCore::ResourceHandle::hasReceivedResponse):
3580         * platform/network/win/ResourceHandleWin.h: Added.
3581         * platform/network/win/ResourceLoaderWin.cpp: Removed.
3582         * platform/network/win/ResourceLoaderWin.h: Removed.
3583         * platform/qt/FrameQt.cpp:
3584         * platform/qt/FrameQtClient.cpp:
3585         (WebCore::FrameQtClientDefault::openURL):
3586         (WebCore::FrameQtClientDefault::submitForm):
3587         (WebCore::FrameQtClientDefault::receivedResponse):
3588         (WebCore::FrameQtClientDefault::didReceiveData):
3589         (WebCore::FrameQtClientDefault::receivedAllData):
3590         * platform/qt/FrameQtClient.h:
3591         * platform/win/TemporaryLinkStubs.cpp:
3592         (WebCore::ResourceHandle::assembleResponseHeaders):
3593         (WebCore::ResourceHandle::retrieveResponseEncoding):
3594         (WebCore::ServeSynchronousRequest):
3595         * xml/XSLTProcessor.cpp:
3596         * xml/xmlhttprequest.cpp:
3597         (WebCore::XMLHttpRequest::send):
3598         (WebCore::XMLHttpRequest::didFinishLoading):
3599         (WebCore::XMLHttpRequest::receivedRedirect):
3600         (WebCore::XMLHttpRequest::didReceiveData):
3601         * xml/xmlhttprequest.h:
3602
3603 t2006-10-29  Darin Adler  <darin@apple.com>
3604
3605         Reviewed by Maciej.
3606
3607         - eliminate use of NSArray to carry form data around
3608
3609         * WebCore.exp:
3610         * WebCore.xcodeproj/project.pbxproj:
3611         * bridge/mac/FormDataMac.h: Removed.
3612         * bridge/mac/FormDataMac.mm: Removed.
3613         * bridge/mac/FrameMac.h:
3614         * bridge/mac/WebCoreFrameBridge.h:
3615         * bridge/mac/WebCoreFrameBridge.mm:
3616         * html/HTMLFormElement.cpp:
3617         (WebCore::HTMLFormElement::submit):
3618         * loader/FormData.h:
3619         (WebCore::FormData::isEmpty):
3620         * loader/mac/FrameLoader.h:
3621         * loader/mac/FrameLoader.mm:
3622         (WebCore::FrameLoader::load):
3623         (WebCore::FrameLoader::post):
3624         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3625         (WebCore::FrameLoader::loadResourceSynchronously):
3626         * loader/mac/LoaderFunctionsMac.mm:
3627         (WebCore::ServeSynchronousRequest):
3628         * loader/mac/WebFormDataStream.h:
3629         * loader/mac/WebFormDataStream.m:
3630         (WebCore::pairRetain):
3631         (WebCore::pairRelease):
3632         (WebCore::pairEqual):
3633         (WebCore::pairHash):
3634         (WebCore::closeCurrentStream):
3635         (WebCore::scheduleWithPair):
3636         (WebCore::advanceCurrentStream):
3637         (WebCore::openNextStream):
3638         (WebCore::formCreate):
3639         (WebCore::formFinalize):
3640         (WebCore::formOpen):
3641         (WebCore::formRead):
3642         (WebCore::formCanRead):
3643         (WebCore::formClose):
3644         (WebCore::formSchedule):
3645         (WebCore::formUnschedule):
3646         (WebCore::formEventCallback):
3647         (WebCore::setHTTPBody):
3648         * loader/mac/WebSubresourceLoader.h:
3649         * loader/mac/WebSubresourceLoader.mm:
3650         (WebCore::SubresourceLoader::create):
3651         * platform/network/mac/ResourceLoaderMac.mm:
3652
3653 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
3654
3655         Reviewed by Darin.
3656
3657         - create SubresourceLoader with a ResourceRequest, not broken out request bits
3658
3659         * loader/mac/WebSubresourceLoader.h:
3660         * loader/mac/WebSubresourceLoader.mm:
3661         (WebCore::SubresourceLoader::create):
3662         * platform/network/mac/ResourceLoaderMac.mm:
3663         (WebCore::ResourceLoader::start):
3664
3665 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
3666
3667         Reviewed by Darin.
3668
3669         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
3670
3671         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
3672         
3673         * WebCore.xcodeproj/project.pbxproj:
3674         * bridge/mac/WebCoreFrameBridge.h:
3675         * loader/mac/FrameLoader.h:
3676         * loader/mac/FrameLoader.mm:
3677         * loader/mac/LoaderFunctionsMac.mm:
3678         * loader/mac/WebLoader.h:
3679         * loader/mac/WebSubresourceLoader.h:
3680         * loader/mac/WebSubresourceLoader.mm:
3681         (WebCore::SubresourceLoader::SubresourceLoader):
3682         (WebCore::SubresourceLoader::create):
3683         (WebCore::SubresourceLoader::willSendRequest):
3684         (WebCore::SubresourceLoader::didReceiveResponse):
3685         (WebCore::SubresourceLoader::didReceiveData):
3686         (WebCore::SubresourceLoader::didFinishLoading):
3687         (WebCore::SubresourceLoader::didFail):
3688         (WebCore::SubresourceLoader::didCancel):
3689         * platform/network/ResourceLoader.h:
3690         * platform/network/ResourceLoaderInternal.h:
3691         * platform/network/mac/ResourceLoaderMac.mm:
3692         (WebCore::ResourceLoader::~ResourceLoader):
3693         (WebCore::ResourceLoader::start):
3694         (WebCore::ResourceLoader::receivedResponse):
3695         (WebCore::ResourceLoader::cancel):
3696         (WebCore::ResourceLoader::redirectedToURL):
3697         (WebCore::ResourceLoader::addData):
3698         (WebCore::ResourceLoader::finishJobAndHandle):
3699         (WebCore::ResourceLoader::reportError):
3700         * platform/network/mac/WebCoreResourceLoader.h: Removed.
3701         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
3702         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
3703
3704 2006-10-28  Darin Adler  <darin@apple.com>
3705
3706         Reviewed by Maciej.
3707
3708         - eliminated the use of Objective-C for the policy decider
3709           machinery, obviating the need for WebPolicyDecider,
3710           WebCoreFrameLoaderAsDelegate, and
3711           WebCoreMainResourceLoaderAsPolicyDelegate
3712
3713         - grouped the state related to policy decisions into a PolicyCheck
3714           class to simplify the FrameLoader logic
3715
3716         - removed six methods from the bridge, reducing FrameLoader's use of
3717           the bridge to a single method
3718
3719         - changed form state to always use HashMap instead of NSDictionary
3720
3721         - moved the defersLoading flag from WebView to WebCore::Page
3722           and changed code to consistently call it defersLoading rather
3723           than defersCallbacks
3724
3725         - updated for rename of PassRefPtr::release to releaseRef
3726         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
3727         - cleaned up kjs_binding.h a bit
3728         - cleaned up FrameMac.h a bit
3729
3730         * loader/mac/WebPolicyDecider.h: Removed.
3731         * loader/mac/WebPolicyDecider.mm: Removed.
3732         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
3733
3734         * WebCore.exp:
3735         * bindings/js/kjs_binding.cpp:
3736         (KJS::ScriptInterpreter::ScriptInterpreter):
3737         (KJS::ScriptInterpreter::wasRunByUserGesture):
3738         * bindings/js/kjs_binding.h:
3739         (KJS::ScriptInterpreter::setCurrentEvent):
3740         (KJS::ScriptInterpreter::setInlineCode):
3741         (KJS::ScriptInterpreter::setProcessingTimerCallback):
3742         (KJS::ScriptInterpreter::getCurrentEvent):
3743         (KJS::cacheDOMObject):
3744         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
3745         * bridge/AXObjectCache.h:
3746         * bridge/mac/BrowserExtensionMac.mm:
3747         (WebCore::BrowserExtensionMac::createNewWindow):
3748         * bridge/mac/FrameMac.h:
3749         * bridge/mac/FrameMac.mm:
3750         (WebCore::FrameMac::loadRequest):
3751         (WebCore::FrameMac::submitForm):
3752         (WebCore::FrameMac::urlSelected):
3753         (WebCore::FrameMac::userAgent):
3754         (WebCore::FrameMac::passMouseDownEventToWidget):
3755         (WebCore::FrameMac::handleMouseMoveEvent):
3756         * bridge/mac/PageMac.mm:
3757         (WebCore::Page::Page):
3758         * bridge/mac/WebCoreEditCommand.mm:
3759         * bridge/mac/WebCoreFrameBridge.h:
3760         * bridge/mac/WebCoreFrameBridge.mm:
3761         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3762         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3763         * css/CSSComputedStyleDeclaration.cpp:
3764         (WebCore::):
3765         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3766         * css/CSSPrimitiveValue.cpp:
3767         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3768         (WebCore::CSSPrimitiveValue::cleanup):
3769         (WebCore::CSSPrimitiveValue::cssText):
3770         * css/CSSPrimitiveValue.h:
3771         (WebCore::CSSPrimitiveValue::):
3772         * css/CSSValueList.cpp:
3773         (WebCore::CSSValueList::append):
3774         * css/cssparser.cpp:
3775         (WebCore::CSSParser::parseValue):
3776         * css/cssparser.h:
3777         * css/cssstyleselector.cpp:
3778         (WebCore::CSSStyleSelector::applyProperty):
3779         * dom/Document.cpp:
3780         (WebCore::Document::Document):
3781         (WebCore::Document::updateSelection):
3782         (WebCore::Document::implicitClose):
3783         (WebCore::Document::setFocusNode):
3784         * dom/Document.h:
3785         * editing/ReplaceSelectionCommand.h:
3786         * html/HTMLParser.cpp:
3787         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
3788         * loader/mac/FrameLoader.h:
3789         (WebCore::PolicyCheck::request):
3790         * loader/mac/FrameLoader.mm:
3791         (WebCore::FrameLoader::~FrameLoader):
3792         (WebCore::FrameLoader::safeLoad):
3793         (WebCore::FrameLoader::load):
3794         (WebCore::FrameLoader::open):
3795         (WebCore::FrameLoader::stopLoading):
3796         (WebCore::setAllDefersLoading):
3797         (WebCore::FrameLoader::setDefersLoading):
3798         (WebCore::FrameLoader::willSendRequest):
3799         (WebCore::FrameLoader::receivedMainResourceError):
3800         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
3801         (WebCore::FrameLoader::commitProvisionalLoad):
3802         (WebCore::FrameLoader::checkNavigationPolicy):
3803         (WebCore::FrameLoader::checkContentPolicy):
3804         (WebCore::FrameLoader::cancelContentPolicyCheck):
3805         (WebCore::FrameLoader::stopPolicyCheck):
3806         (WebCore::FrameLoader::checkNewWindowPolicy):
3807         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3808         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3809         (WebCore::FrameLoader::continueAfterContentPolicy):
3810         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3811         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
3812         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3813         (WebCore::FrameLoader::closeDocument):
3814         (WebCore::FrameLoader::transitionToCommitted):
3815         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
3816         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
3817         (WebCore::FrameLoader::post):
3818         (WebCore::FrameLoader::detachFromParent):
3819         (WebCore::FrameLoader::addExtraFieldsToRequest):
3820         (WebCore::PolicyCheck::PolicyCheck):
3821         (WebCore::PolicyCheck::clear):
3822         (WebCore::PolicyCheck::set):
3823         (WebCore::PolicyCheck::call):
3824         (WebCore::PolicyCheck::dropRequest):
3825         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3826         * loader/mac/WebFormState.h:
3827         * loader/mac/WebFormState.mm:
3828         * loader/mac/WebFrameLoaderClient.h:
3829         * loader/mac/WebLoader.h:
3830         (WebCore::WebResourceLoader::defersLoading):
3831         * loader/mac/WebLoader.mm:
3832         (WebCore::WebResourceLoader::WebResourceLoader):
3833         (WebCore::WebResourceLoader::load):
3834         (WebCore::WebResourceLoader::setDefersLoading):
3835         * loader/mac/WebMainResourceLoader.h:
3836         * loader/mac/WebMainResourceLoader.mm:
3837         (WebCore::MainResourceLoader::MainResourceLoader):
3838         (WebCore::MainResourceLoader::releaseDelegate):
3839         (WebCore::MainResourceLoader::didCancel):
3840         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3841         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3842         (WebCore::MainResourceLoader::willSendRequest):
3843         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3844         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3845         (WebCore::MainResourceLoader::didReceiveResponse):
3846         (WebCore::MainResourceLoader::didReceiveData):
3847         (WebCore::MainResourceLoader::didFinishLoading):
3848         (WebCore::MainResourceLoader::didFail):
3849         (WebCore::MainResourceLoader::loadNow):
3850         (WebCore::MainResourceLoader::load):
3851         (WebCore::MainResourceLoader::setDefersLoading):
3852         * page/Frame.cpp:
3853         (WebCore::Frame::paint):
3854         * page/FrameView.cpp:
3855         (WebCore::FrameView::layout):
3856         * page/FrameView.h:
3857         * page/Page.cpp:
3858         (WebCore::Page::setDefersLoading):
3859         * page/Page.h:
3860         (WebCore::Page::defersLoading):
3861         * platform/DeprecatedString.h:
3862         * platform/DeprecatedStringList.h:
3863         * platform/FontFallbackList.h:
3864         * platform/PlatformKeyboardEvent.h:
3865         * platform/PlatformMouseEvent.h:
3866         * platform/PlatformWheelEvent.h:
3867         * platform/mac/ClipboardMac.h:
3868         * platform/mac/ClipboardMac.mm:
3869         (WebCore::ClipboardMac::setDragImage):
3870         (WebCore::ClipboardMac::dragNSImage):
3871         (WebCore::ClipboardMac::sourceOperation):
3872         (WebCore::ClipboardMac::destinationOperation):
3873         * rendering/RenderObject.cpp:
3874         (WebCore::RenderObject::setStyle):
3875         * rendering/break_lines.cpp:
3876         (WebCore::nextBreakablePosition):
3877
3878 2006-10-28  Adam Roben  <aroben@apple.com>
3879
3880         Reviewed by Maciej.
3881
3882         Fix layout tests that broke after r17399. Mitz discovered that the
3883         failures were caused by HitTestResult::m_point being uninitialized
3884         much of the time. HitTestResults are now always constructed with a
3885         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3886         point instead of being passed one explicitly.
3887
3888         * WebCore.exp: Change constructor symbol.
3889         * bridge/mac/FrameMac.mm:
3890         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3891         hitTest().
3892         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3893         * bridge/mac/WebCoreAXObject.mm:
3894         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3895         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3896         * dom/Document.cpp:
3897         (WebCore::Document::elementFromPoint): Ditto.
3898         (WebCore::Document::prepareMouseEvent): Ditto.
3899         * page/Frame.cpp:
3900         (WebCore::Frame::isPointInsideSelection): Ditto.
3901         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3902         * page/FrameView.cpp:
3903         (WebCore::FrameView::handleWheelEvent): Ditto.
3904         * rendering/HitTestResult.cpp:
3905         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3906         passed point.
3907         * rendering/HitTestResult.h: Update constructor declaration.
3908         * rendering/RenderLayer.cpp:
3909         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3910         hitTest().
3911         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3912         HitTestResult instead of being passed one.
3913         (WebCore::RenderLayer::hitTestLayer): Ditto.
3914         * rendering/RenderLayer.h: Update declarations.
3915
3916 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3917
3918         Reviewed by Anders.
3919
3920         Fix Qt/Linux build.
3921
3922         * CMakeLists.txt:
3923         * platform/qt/FrameQtClient.cpp:
3924         (WebCore::numRequests):
3925         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3926         * platform/qt/PopupMenuQt.cpp:
3927         (WebCore::PopupMenu::updateFromElement):
3928
3929 2006-10-28  David Carson  <dacarson@gmail.com>
3930
3931         Tweaked by Sam. Reviewed by Brady.
3932
3933         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3934         Initialize m_modifyBiasSet to false, as it sometimes gets 
3935         used before it has been initalized.
3936
3937         * editing/SelectionController.cpp:
3938         (WebCore::SelectionController::SelectionController):
3939
3940 2006-10-28  Beth Dakin  <bdakin@apple.com>
3941
3942         Reviewed by Darin.
3943
3944         This is the WebCore half of pushing elementAtPoint and the backend 
3945         of WebElementDictionary into WebCore. Most of the changes below are 
3946         to accommodate one of the following:
3947                 
3948         -NodeInfo is now a stand-alone class called HitTestResult. 
3949                 Previously it was defined in RenderObject.h, but not for 
3950                 any particular reason. The WebElementDictionary 
3951                 functionality that was pushed into WebCore has been pushed 
3952                 specifically into the this class. In fact, 
3953                 WebElementDictionary now keeps a HitTestResult as a member 
3954                 varibale.
3955                 
3956         -The enumeration AccessPolicy is now called 
3957                 ClipboardAccessPolicy and is defined in its own header. It 
3958                 was previously defined in ClipboardMac.h, but is now 
3959                 defined independently to avoid including ClipboardMac.h 
3960                 from within FrameMac.h since FrameMac.h is now included in 
3961                 WebElementDictionary.m in WebKit.
3962                 
3963         -Element now has a virtual target() for the sake of 
3964                 NodeInfo::targetFrame() 
3965
3966         * WebCore.exp: Several WebCore functions are newly called from 
3967         WebKit, so they have been added here. 
3968         * WebCore.xcodeproj/project.pbxproj:
3969         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3970         to ClipboardMac.
3971         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3972         * bridge/mac/FrameMac.mm:
3973         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3974         and HitTestResult changes.
3975         (WebCore::FrameMac::eventMayStartDrag): Same.
3976         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3977         (WebCore::FrameMac::dispatchCPPEvent): Same.
3978         (WebCore::FrameMac::mayDHTMLCut): Same.
3979         (WebCore::FrameMac::mayDHTMLCopy): Same.
3980         (WebCore::FrameMac::mayDHTMLPaste): Same.
3981         (WebCore::FrameMac::tryDHTMLCut): Same
3982         (WebCore::FrameMac::tryDHTMLCopy): Same.
3983         (WebCore::FrameMac::tryDHTMLPaste): Same.
3984         * bridge/mac/WebCoreAXObject.mm:
3985         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3986         HitTestResult changes.
3987         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3988         * bridge/mac/WebCoreFrameBridge.h: Same.
3989         * bridge/mac/WebCoreFrameBridge.mm:
3990         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3991         ClipboardAccessPolicy changes.
3992         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3993         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3994         * dom/Document.cpp:
3995         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3996         changes.
3997         (WebCore::Document::prepareMouseEvent): Same.
3998         * dom/Element.h:
3999         (WebCore::Element::target): Now has a virtual target()
4000         * html/HTMLAnchorElement.h: Same.
4001         * html/HTMLAreaElement.cpp:
4002         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
4003         changes.
4004         * html/HTMLAreaElement.h: Virtual target()
4005         * html/HTMLBaseElement.h:
4006         (WebCore::HTMLBaseElement::target): Same.
4007         * html/HTMLFormElement.h: Same.
4008         * html/HTMLLinkElement.h: Same.
4009         * html/HTMLMapElement.cpp:
4010         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
4011         changes.
4012         * html/HTMLMapElement.h: Same.
4013         * page/Frame.cpp:
4014         (WebCore::Frame::isPointInsideSelection): Same.
4015         (WebCore::Frame::hitTestResultAtPoint): Same. 
4016         * page/Frame.h: Same.
4017         * page/FrameView.cpp:
4018         (WebCore::FrameView::handleWheelEvent): Same.
4019         * platform/mac/ClipboardAccessPolicy.h: Added.
4020         (WebCore::):
4021         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
4022         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
4023         ClipboardAccessPolicy.
4024         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
4025         (WebCore::ClipboardMac::ClipboardMac):
4026         (WebCore::ClipboardMac::setAccessPolicy):
4027         (WebCore::ClipboardMac::clearData):
4028         (WebCore::ClipboardMac::clearAllData):
4029         (WebCore::ClipboardMac::getData):
4030         (WebCore::ClipboardMac::setData):
4031         (WebCore::ClipboardMac::types):
4032         (WebCore::ClipboardMac::setDragImage):
4033         (WebCore::ClipboardMac::setDropEffect):
4034         (WebCore::ClipboardMac::setEffectAllowed):
4035         * rendering/EllipsisBox.cpp:
4036         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
4037         changes.
4038         * rendering/EllipsisBox.h:
4039         * rendering/HitTestResult.cpp: Added.
4040         (WebCore::HitTestResult::HitTestResult):
4041         (WebCore::HitTestResult::~HitTestResult):
4042         (WebCore::HitTestResult::operator=):
4043         (WebCore::HitTestResult::setInnerNode):
4044         (WebCore::HitTestResult::setInnerNonSharedNode):
4045         (WebCore::HitTestResult::setURLElement):
4046         (WebCore::HitTestResult::setScrollbar):
4047         (WebCore::HitTestResult::targetFrame):
4048         (WebCore::HitTestResult::boundingBox):
4049         (WebCore::HitTestResult::isSelected):
4050         (WebCore::HitTestResult::title):
4051         * rendering/HitTestResult.h: Added.
4052         (WebCore::HitTestResult::readonly):
4053         (WebCore::HitTestResult::active):
4054         (WebCore::HitTestResult::mouseMove):
4055         (WebCore::HitTestResult::innerNode):
4056         (WebCore::HitTestResult::innerNonSharedNode):
4057         (WebCore::HitTestResult::point):
4058         (WebCore::HitTestResult::URLElement):
4059         (WebCore::HitTestResult::scrollbar):
4060         (WebCore::HitTestResult::setPoint):
4061         (WebCore::HitTestResult::setReadonly):
4062         (WebCore::HitTestResult::setActive):
4063         (WebCore::HitTestResult::setMouseMove):
4064         * rendering/InlineBox.cpp:
4065         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
4066         * rendering/InlineBox.h: Same.
4067         * rendering/InlineFlowBox.cpp:
4068         (WebCore::InlineFlowBox::nodeAtPoint): Same.
4069         * rendering/InlineFlowBox.h: Same.
4070         * rendering/InlineTextBox.cpp: 
4071         (WebCore::InlineTextBox::nodeAtPoint): Same.
4072         * rendering/InlineTextBox.h: Same.
4073         * rendering/RenderBlock.cpp:
4074         (WebCore::RenderBlock::isPointInScrollbar): Same.
4075         (WebCore::RenderBlock::nodeAtPoint): Same.
4076         * rendering/RenderBlock.h: Same.
4077         * rendering/RenderBox.cpp:
4078         (WebCore::RenderBox::nodeAtPoint): Same.
4079         * rendering/RenderBox.h: Same.
4080         * rendering/RenderFlow.cpp:
4081         (WebCore::RenderFlow::hitTestLines): Same.
4082         * rendering/RenderFlow.h: Same.
4083         * rendering/RenderForeignObject.cpp:
4084         (WebCore::RenderForeignObject::nodeAtPoint): Same.
4085         * rendering/RenderForeignObject.h: Same.
4086         * rendering/RenderFrameSet.cpp:
4087         (WebCore::RenderFrameSet::nodeAtPoint): Same.
4088         * rendering/RenderFrameSet.h: Same.
4089         * rendering/RenderImage.cpp:
4090         (WebCore::RenderImage::nodeAtPoint): Same.
4091         * rendering/RenderImage.h: Same.
4092         * rendering/RenderInline.cpp:
4093         (WebCore::RenderInline::nodeAtPoint): Same.
4094         * rendering/RenderInline.h: Same.
4095         * rendering/RenderLayer.cpp:
4096         (WebCore::RenderLayer::autoscroll): Same.
4097         (WebCore::RenderLayer::hitTest): Same.
4098         (WebCore::RenderLayer::hitTestLayer): Same.
4099         (WebCore::RenderLayer::updateHoverActiveState): Same.
4100         * rendering/RenderLayer.h: Same.
4101         * rendering/RenderListBox.cpp:
4102         (WebCore::RenderListBox::isPointInScrollbar): Same.
4103         * rendering/RenderListBox.h: Same.
4104         * rendering/RenderObject.cpp:
4105         (WebCore::RenderObject::hitTest): Same.
4106         (WebCore::RenderObject::setInnerNode): Same.
4107         (WebCore::RenderObject::nodeAtPoint): Same.
4108         * rendering/RenderObject.h: Remove NodeInfo class and forward 
4109         declare HitTestResult.
4110         * rendering/RenderPath.cpp:
4111         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
4112         changes.
4113         * rendering/RenderPath.h: Same.
4114         * rendering/RenderSVGImage.cpp:
4115         (WebCore::RenderSVGImage::nodeAtPoint): Same.
4116         * rendering/RenderSVGImage.h: Same
4117         * rendering/RenderSVGText.cpp:
4118         (WebCore::RenderSVGText::nodeAtPoint): Same.
4119         * rendering/RenderSVGText.h: Same.
4120         * rendering/RenderTableRow.cpp:
4121         (WebCore::RenderTableRow::nodeAtPoint): Same.
4122         * rendering/RenderTableRow.h: Same.
4123         * rendering/RenderTableSection.cpp:
4124         (WebCore::RenderTableSection::nodeAtPoint): Same.
4125         * rendering/RenderTableSection.h: Same.
4126         * rendering/RenderText.h: Same.
4127         (WebCore::RenderText::nodeAtPoint): Same.
4128         * rendering/RenderTextControl.cpp:
4129         (WebCore::RenderTextControl::nodeAtPoint): Same.
4130         * rendering/RenderTextControl.h: Same.
4131         * rendering/RootInlineBox.cpp:
4132         (WebCore::RootInlineBox::nodeAtPoint): Same.
4133         * rendering/RootInlineBox.h: Same.
4134
4135 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
4136
4137         Reviewed by Anders.
4138
4139         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
4140         impact of fixing it again.
4141
4142         * bridge/mac/FrameMac.mm:
4143         (WebCore::FrameMac::clear):
4144
4145 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
4146
4147         Reviewed by John & Adam.
4148
4149         - assorted speedups to fix perf regression from fixing correctness regression
4150
4151         * WebCore.exp: exported new methods.
4152         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
4153         * bridge/mac/WebCoreFrameBridge.h:
4154         * bridge/mac/WebCoreFrameBridge.mm:
4155         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
4156         * loader/CachedResource.h:
4157         * loader/mac/CachedResourceMac.mm: Added.
4158         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
4159         now cached in the CachedObject.
4160         * loader/mac/FrameLoader.h:
4161         * loader/mac/FrameLoader.mm:
4162         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method -&