803b8a5d4bcb68b1b93c08e5afb7ecbc2466214d
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2
3         Reviewed by Oliver Hunt.
4
5         need to implement aria tree roles
6         https://bugs.webkit.org/show_bug.cgi?id=31284
7
8         Tests: platform/mac/accessibility/aria-multiselectable.html
9                platform/mac/accessibility/aria-tree.html
10
11         * accessibility/AccessibilityList.cpp:
12         (WebCore::AccessibilityList::accessibilityIsIgnored):
13         * accessibility/AccessibilityObject.cpp:
14         (WebCore::AccessibilityObject::ariaTreeRows):
15         (WebCore::AccessibilityObject::ariaTreeItemContent):
16         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
17         * accessibility/AccessibilityObject.h:
18         (WebCore::):
19         (WebCore::AccessibilityObject::isTree):
20         (WebCore::AccessibilityObject::isTreeItem):
21         (WebCore::AccessibilityObject::setIsExpanded):
22         (WebCore::AccessibilityObject::canSetExpandedAttribute):
23         (WebCore::AccessibilityObject::hierarchicalLevel):
24         (WebCore::AccessibilityObject::setSelectedRows):
25         (WebCore::AccessibilityObject::performDefaultAction):
26         * accessibility/AccessibilityRenderObject.cpp:
27         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
28         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
29         (WebCore::AccessibilityRenderObject::isExpanded):
30         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
31         (WebCore::AccessibilityRenderObject::elementAttributeValue):
32         (WebCore::AccessibilityRenderObject::setIsExpanded):
33         (WebCore::AccessibilityRenderObject::isSelected):
34         (WebCore::AccessibilityRenderObject::setSelected):
35         (WebCore::AccessibilityRenderObject::setSelectedRows):
36         (WebCore::createARIARoleMap):
37         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
38         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
39         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
40         (WebCore::AccessibilityRenderObject::selectedChildren):
41         * accessibility/AccessibilityRenderObject.h:
42         * accessibility/mac/AccessibilityObjectMac.mm:
43         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
44         * accessibility/mac/AccessibilityObjectWrapper.mm:
45         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
46         (RoleEntry::):
47         (-[AccessibilityObjectWrapper subrole]):
48         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
49         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
50         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
51         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
52         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
53         * html/HTMLAttributeNames.in:
54
55 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
56
57         Build fix after @r50760 with ENABLE_FILTERS.
58
59         * platform/graphics/filters/SourceAlpha.cpp:
60         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
61         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
62           to fillRect.
63
64 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
65
66         Reviewed by Alexey Proskuryakov.
67
68         Fix WebSocket frame parser of frame_type with high-order bit set.
69         https://bugs.webkit.org/show_bug.cgi?id=30668
70
71         If buffer is smaller than frame's length, it should break the loop
72         instead of reading next byte.
73
74         Tests: websocket/tests/frame-length-longer-than-buffer.html
75                websocket/tests/frame-length-skip.html
76
77         * websockets/WebSocketChannel.cpp:
78         (WebCore::WebSocketChannel::didReceiveData):
79
80 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
81
82         Reviewed by Adam Barth.
83
84         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
85         https://bugs.webkit.org/show_bug.cgi?id=31345
86
87         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
88
89         * platform/graphics/chromium/FontCustomPlatformData.cpp:
90         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
91         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
92         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
93
94 2009-11-11  Beth Dakin  <bdakin@apple.com>
95
96         Build fix. No review needed.
97
98         * platform/graphics/gtk/FontGtk.cpp:
99         (WebCore::Font::drawComplexText):
100
101 2009-11-11  Beth Dakin  <bdakin@apple.com>
102
103         Build fix. No review needed.
104
105         * platform/graphics/cairo/FontCairo.cpp:
106         (WebCore::Font::drawGlyphs):
107
108 2009-11-11  Beth Dakin  <bdakin@apple.com>
109
110         Windows build fix. No review needed. 
111
112         * platform/graphics/win/FontCGWin.cpp:
113         (WebCore::Font::drawGlyphs):
114
115 2009-11-11  Beth Dakin  <bdakin@apple.com>
116
117         Reviewed by Simon Fraser.
118
119         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
120         Make -webkit-color-correction work with shadows
121
122         From canvas, just send DeviceColorSpace to setShadow() for now. 
123         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
124         * html/canvas/CanvasRenderingContext2D.cpp:
125         (WebCore::CanvasRenderingContext2D::setShadow):
126         (WebCore::CanvasRenderingContext2D::applyShadow):
127
128         setShadow() and setPlatformShadow() now take a ColorSpace.
129         * platform/graphics/GraphicsContext.cpp:
130         (WebCore::GraphicsContext::setShadow):
131         * platform/graphics/GraphicsContext.h:
132         * platform/graphics/cg/GraphicsContextCG.cpp:
133         (WebCore::createCGColorWithColorSpace): New helper to create a 
134         color in a ColorSpace.
135         (WebCore::setCGFillColor): Call new helper.
136         (WebCore::setCGStrokeColor): Call new helper.
137         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
138         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
139         (WebCore::GraphicsContext::setPlatformShadow):
140
141         Send appropriate ColorSpace to setShadow().
142         * platform/graphics/mac/FontMac.mm:
143         (WebCore::Font::drawGlyphs):
144         * rendering/EllipsisBox.cpp:
145         (WebCore::EllipsisBox::paint):
146         * rendering/InlineFlowBox.cpp:
147         (WebCore::InlineFlowBox::paintTextDecorations):
148         * rendering/InlineTextBox.cpp:
149         (WebCore::paintTextWithShadows):
150         (WebCore::InlineTextBox::paintDecoration):
151         * rendering/RenderBoxModelObject.cpp:
152         (WebCore::RenderBoxModelObject::paintBoxShadow):
153         * rendering/SVGInlineTextBox.cpp:
154         (WebCore::SVGInlineTextBox::paintCharacters):
155         * rendering/SVGRenderSupport.cpp:
156         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
157
158         Attempt to keep ports building.
159         * platform/graphics/cairo/GraphicsContextCairo.cpp:
160         (WebCore::GraphicsContext::setPlatformShadow):
161         * platform/graphics/qt/GraphicsContextQt.cpp:
162         (WebCore::GraphicsContext::setPlatformShadow):
163         * platform/graphics/skia/GraphicsContextSkia.cpp:
164         (WebCore::GraphicsContext::setPlatformShadow):
165         * platform/graphics/wince/GraphicsContextWince.cpp:
166         (WebCore::GraphicsContext::setPlatformShadow):
167         * platform/graphics/wx/GraphicsContextWx.cpp:
168         (WebCore::GraphicsContext::setPlatformShadow):
169
170 2009-11-11  Kent Tamura  <tkent@chromium.org>
171
172         Reviewed by Darin Adler.
173
174         Print the file text of a file upload control in DumpRenderTree for ease of tests.
175         https://bugs.webkit.org/show_bug.cgi?id=31195
176
177         * rendering/RenderFileUploadControl.cpp:
178         (WebCore::RenderFileUploadControl::paintObject):
179         (WebCore::RenderFileUploadControl::fileTextValue):
180         * rendering/RenderFileUploadControl.h:
181         (WebCore::RenderFileUploadControl::isFileUploadControl):
182         (WebCore::toRenderFileUploadControl):
183         * rendering/RenderObject.h:
184         (WebCore::RenderObject::isFileUploadControl):
185         * rendering/RenderTreeAsText.cpp:
186         (WebCore::operator<<):
187
188 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
189
190         Reviewed by Sam Weinig.
191
192         DOM Wrappers for some nodes may not be marked.
193         https://bugs.webkit.org/show_bug.cgi?id=31380
194
195         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
196         the wrapper for the current world only.  This means that wrappers may be GC'ed
197         prematurely, and properties lost.
198
199         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
200
201         * bindings/js/JSAttrCustom.cpp:
202         (WebCore::JSAttr::markChildren):
203         * bindings/js/JSDOMBinding.cpp:
204         (WebCore::markDOMNodeWrapper):
205         * bindings/js/JSDOMBinding.h:
206         * bindings/js/JSNamedNodeMapCustom.cpp:
207         (WebCore::JSNamedNodeMap::markChildren):
208         * bindings/js/JSNodeCustom.cpp:
209         (WebCore::JSNode::markChildren):
210         * bindings/js/JSSVGElementInstanceCustom.cpp:
211         (WebCore::JSSVGElementInstance::markChildren):
212         * bindings/js/JSStyleSheetCustom.cpp:
213         (WebCore::JSStyleSheet::markChildren):
214
215 2009-11-11  Ben Murdoch  <benm@google.com>
216
217         Reviewed by Darin Adler.
218
219         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
220         https://bugs.webkit.org/show_bug.cgi?id=31384
221
222         No functionality change so no tests required.
223
224         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
225
226 2009-11-11  Jens Alfke  <snej@chromium.org>
227
228         Reviewed by Dimitri Glazkov.
229
230         The Big De-Inlining. 450k code size reduction (32-bit x86.)
231         - Various inline functions in V8Binding.h made non-inline.
232         - Some renaming for consistency.
233         - New function createRawTemplate().
234         https://bugs.webkit.org/show_bug.cgi?id=31383
235
236         * bindings/scripts/CodeGeneratorV8.pm:
237         * bindings/v8/V8Binding.cpp:
238         (WebCore::v8DOMWrapperToNative):
239         (WebCore::v8ValueToWebCoreString):
240         (WebCore::v8ValueToAtomicWebCoreString):
241         (WebCore::toInt32):
242         (WebCore::toWebCoreString):
243         (WebCore::toWebCoreStringWithNullCheck):
244         (WebCore::toAtomicWebCoreStringWithNullCheck):
245         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
246         (WebCore::isUndefinedOrNull):
247         (WebCore::v8Boolean):
248         (WebCore::v8UndetectableString):
249         (WebCore::v8StringOrNull):
250         (WebCore::v8StringOrUndefined):
251         (WebCore::v8StringOrFalse):
252         (WebCore::v8StringToWebCoreString):
253         (WebCore::v8ExternalString):
254         (WebCore::createRawTemplate):  New function.
255         * bindings/v8/V8Binding.h:
256         (WebCore::v8DOMWrapperTo):
257         (WebCore::v8DOMWrapperToNode):
258         (WebCore::v8StringToWebCoreString):
259         (WebCore::v8StringToAtomicWebCoreString):
260
261 2009-11-11  Jens Alfke  <snej@chromium.org>
262
263         Reviewed by Dimitri Glazkov.
264
265         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
266         event-listener setter into a new subroutine transferHiddenDependency().
267         https://bugs.webkit.org/show_bug.cgi?id=31377
268
269         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
270         * bindings/v8/V8Utilities.cpp:
271         (WebCore::transferHiddenDependency):  New.
272         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
273
274 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
275
276         Reviewed by Beth Dakin.
277
278         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
279         because there is a CG bug preventing this from working.
280
281         * platform/graphics/cg/GraphicsContextCG.cpp:
282         (WebCore::sRGBColorSpaceRef):
283
284 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
285
286         Reviewed by Timothy Hatcher.
287
288         Check that if Storage panel exists before calling its methods
289
290         https://bugs.webkit.org/show_bug.cgi?id=31343
291
292         * inspector/front-end/inspector.js:
293         (WebInspector.addDatabase):
294         (WebInspector.addCookieDomain):
295         (WebInspector.addDOMStorage):
296         (WebInspector.updateDOMStorage):
297
298 2009-11-11  Jens Alfke  <snej@chromium.org>
299
300         Reviewed by Dimitri Glazkov.
301
302         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
303         times in the generated V8 bindings.
304         https://bugs.webkit.org/show_bug.cgi?id=31368
305
306         * bindings/v8/V8DOMWrapper.cpp:
307         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
308         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
309
310 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
311
312         Reviewed by Timothy Hatcher.
313
314         Display the correct summary in the web inspector for the shorthands
315         border-color, border-width, border-style, margin, and padding.
316         https://bugs.webkit.org/show_bug.cgi?id=7987
317
318         Test: fast/css/shorthands-four-values.html
319
320         * css/CSSMutableStyleDeclaration.cpp:
321         (WebCore::CSSMutableStyleDeclaration::get4Values):
322         Display the summary information in the same way the shorthand would be
323         specified in a css rule.
324
325 2009-11-11  Jens Alfke  <snej@chromium.org>
326
327         Reviewed by Dimitri Glazkov.
328
329         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
330         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
331         https://bugs.webkit.org/show_bug.cgi?id=31367
332
333         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
334
335 2009-11-11  Jens Alfke  <snej@chromium.org>
336
337         Reviewed by Dimitri Glazkov.
338
339         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
340
341         * bindings/v8/DOMData.cpp:
342         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
343             so it can be inlined by its caller.
344         * bindings/v8/DOMData.h:
345         * bindings/v8/MainThreadDOMData.cpp:
346         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
347         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
348         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
349             and getStore, which inline both calls together.
350         * bindings/v8/MainThreadDOMData.h:
351         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
352         * bindings/v8/V8DOMMap.cpp:
353         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
354
355 2009-11-11  Nate Chapin  <japhet@chromium.org>
356
357         Reviewed by Dimitri Glazkov.
358
359         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
360
361         https://bugs.webkit.org/show_bug.cgi?id=31357
362
363         * platform/KURLGoogle.cpp:
364         (WebCore::isSchemeFirstChar):
365         (WebCore::isSchemeChar):
366         (WebCore::KURL::hasPort):
367         (WebCore::KURL::removePort):
368         (WebCore::protocolIsValid):
369
370 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
371
372         Build fix, no reviewed.
373
374         Correct setPlatformFillColor and setPlatformStrokeColor calls
375         to match new ColorSpace-supporting signatures.
376
377         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
378           color space to the set[...]Color calls.
379
380 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
381
382         Reviewed by Sam Weinig.
383
384         https://bugs.webkit.org/show_bug.cgi?id=31327
385         Clean up SocketStreamHandleClient interface
386
387         No change in behavior.
388
389         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
390         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
391         the only client (WebSocketChannel), and it's not clear what this callback's semantics
392         should be.
393         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
394         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
395         For ResourceHandle, this method is called when the user cancels authentication sheet,
396         not when something happens with the stream.
397
398         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
399         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
400
401         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
402         callbacks have no real implementation yet.
403
404 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
405
406         Reviewed by Eric Seidel.
407
408         Allow custom memory allocation control for the part of page directory in WebCore
409         https://bugs.webkit.org/show_bug.cgi?id=31350
410
411         Inherits the following classes from Noncopyable because these are instantiated
412         by 'new' and these are no need to be copyable:
413
414         class DragController         - instantiated at: WebCore/page/Page.cpp:107
415         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
416         class Settings               - instantiated at: WebCore/page/Page.cpp:116
417         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
418         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
419         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
420         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
421         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
422         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
423
424         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
425         PropertyWrapper is instantiated by 'new' in 
426         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
427
428         * page/DragController.h:
429         * page/EventHandler.h:
430         * page/FocusController.h:
431         * page/FrameView.cpp:
432         * page/PluginHalter.h:
433         * page/Settings.h:
434         * page/UserScript.h:
435         * page/UserStyleSheet.h:
436         * page/XSSAuditor.h:
437         * page/animation/AnimationBase.cpp:
438
439 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
440
441         Reviewed by Kenneth Rohde Christiansen.
442
443         https://bugs.webkit.org/show_bug.cgi?id=31323
444         Fix a few compiler warnings
445
446         No new tests as there is no new functionality.
447
448         * editing/htmlediting.cpp:
449         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
450         parentheses to silence gcc 4.4 -Wparentheses warnings
451
452 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
453
454         Reviewed by Mark Rowe.
455
456         Set m_hasPendingGeometryChange to true by default, so that
457         at least one call to NPP_SetWindow is executed, which is
458         needed by the DRT plugin testing framework.
459
460         * plugins/PluginView.cpp:
461         (WebCore::PluginView::PluginView):
462
463 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
464
465         Rubber-stamped by Kenneth Rohde Christiansen.
466
467         https://bugs.webkit.org/show_bug.cgi?id=31348
468         [Qt] Remove unnecessary LUT creator from WebCore.pro
469
470         * WebCore.pro:
471
472 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
473
474         Reviewed by Tor Arne Vestbø.
475
476         Introduce a function for querying the input method status
477         in QWebPageClient.
478
479         * platform/qt/QWebPageClient.h:
480
481 2009-11-11  Benjamin Otte  <otte@gnome.org>
482
483         Reviewed by Jan Alonzo.
484
485         [GTK] Black artifacts in youtube.com/html5
486
487         Paint the video to the given size. It's the job of the callers to keep
488         track of aspect ratio. RenderVideo.cpp does it for the <video>
489         element.
490         https://bugs.webkit.org/show_bug.cgi?id=30925
491
492         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
493         (WebCore::MediaPlayerPrivate::paint):
494
495 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
496
497         Reviewed by Reviewed by Jan Alonzo.
498
499         https://bugs.webkit.org/show_bug.cgi?id=30901
500         [Gtk] Need to de-lint the Atk a11y code
501
502         Cleaned up some missed capitalization style-guideline violations.
503
504         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
505
506 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
507
508         Reviewed by Eric Seidel.
509
510         [Qt] Make the default style background color valid.
511         Currently the color is transparent but invalid, this causes
512         list boxes in QtWebKit to be drawn with a black background
513         since r49242.
514         https://bugs.webkit.org/show_bug.cgi?id=31295
515
516         * rendering/style/RenderStyle.h:
517         (WebCore::InheritedFlags::initialBackgroundColor):
518         * rendering/style/StyleBackgroundData.cpp:
519         (WebCore::StyleBackgroundData::StyleBackgroundData):
520
521 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
522
523         Reviewed by Geoff Garen.
524
525         Simplify the ownership model for worlds - rather than having a pair of weak references
526         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
527         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
528         back forward cache.
529
530         * WebCore.base.exp:
531         * bindings/js/JSDOMBinding.cpp:
532         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
533         * bindings/js/JSDOMBinding.h:
534         (WebCore::DOMWrapperWorld::forgetDocument):
535         * bindings/js/ScriptCachedFrameData.cpp:
536         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
537         (WebCore::ScriptCachedFrameData::restore):
538         (WebCore::ScriptCachedFrameData::clear):
539         * bindings/js/ScriptCachedFrameData.h:
540         * bindings/js/ScriptController.cpp:
541         (WebCore::ScriptController::~ScriptController):
542         (WebCore::ScriptController::clearWindowShell):
543         (WebCore::ScriptController::initScript):
544         (WebCore::ScriptController::updateDocument):
545         * bindings/js/ScriptController.h:
546
547 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
548
549         Reviewed by Darin Adler.
550
551         rename counter to makeCounterNode in RenderCounter.cpp
552         https://bugs.webkit.org/show_bug.cgi?id=31289
553
554         No new test because this is just a small refactoring.
555
556         * rendering/RenderCounter.cpp:
557         (WebCore::findPlaceForCounter):
558         (WebCore::makeCounterNode):
559         (WebCore::RenderCounter::originalText):
560
561 2009-11-10  Daniel Bates  <dbates@webkit.org>
562
563         Reviewed by Oliver Hunt.
564
565         https://bugs.webkit.org/show_bug.cgi?id=30754
566
567         Patch 2 of 2.
568
569         Removed method EventHandler::dragSourceMovedTo, since it is no longer
570         needed. This method fired a drag event whenever the mouse moved, but
571         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
572         model independent of when the mouse moves. See "Among other changes..."
573         in the change log for patch 1 for more details.
574
575         * WebCore.DragSupport.exp:
576         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
577         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
578         * page/EventHandler.h:
579
580 2009-11-10  Daniel Bates  <dbates@webkit.org>
581
582         Reviewed by Oliver Hunt.
583
584         https://bugs.webkit.org/show_bug.cgi?id=30754
585
586         Patch 1 of 2.
587
588         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
589         the drag event should always fire before the dragover event.
590
591         In fixing this bug, this patch also makes our drag processing model
592         conform to the HTML 5 spec.
593
594         Among the changes, this patch ensures that the drag event isn't fired outside
595         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
596         Currently, the drag event is fired whenever the mouse button is down and the OS
597         detects the mouse moved. But, as per the spec, the drag event should
598         fire approx. every 350ms so long as the mouse button is down.
599
600         Test: fast/events/drag-and-drop-fire-drag-dragover.html
601
602         * page/EventHandler.cpp:
603         (WebCore::EventHandler::clear):
604         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
605         Modified to determine when we are in the correct instance of EventHandler to service the drag
606         and drop operation.
607         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
608         into this method.
609         (WebCore::EventHandler::cancelDragAndDrop):
610         (WebCore::EventHandler::performDragAndDrop):
611         (WebCore::EventHandler::clearDragState):
612         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
613         we should fire both drag and dragover events or only the dragover event.
614
615 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
616
617         Reviewed by Dimitri Glazkov.
618
619         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
620         https://bugs.webkit.org/show_bug.cgi?id=31301
621
622         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
623
624         Allowed passing V8Proxy for the calling JS context:
625         * bindings/v8/V8DOMWrapper.h:
626         (WebCore::V8DOMWrapper::getXPathNSResolver):
627         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
628         (WebCore::V8CustomXPathNSResolver::create):
629         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
630         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
631         * bindings/v8/custom/V8CustomXPathNSResolver.h:
632         * bindings/v8/custom/V8DocumentCustom.cpp:
633         (WebCore::CALLBACK_FUNC_DECL):
634
635 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
636
637         Reviewed by Timothy Hatcher.
638
639         Implement URL decomposition IDL attributes for HTMLAnchorElement.
640         https://bugs.webkit.org/show_bug.cgi?id=29972.
641
642         Add methods for setting different parts of the URL in href attribute.
643
644         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
645                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
646                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
647                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
648                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
649                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
650                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
651
652         * bindings/js/JSLocationCustom.cpp:
653         (WebCore::JSLocation::setPort):
654         * html/HTMLAnchorElement.cpp:
655         (WebCore::parsePortFromStringPosition):
656         (WebCore::HTMLAnchorElement::setHash):
657         (WebCore::HTMLAnchorElement::setHost):
658         (WebCore::HTMLAnchorElement::setHostname):
659         (WebCore::HTMLAnchorElement::setPathname):
660         (WebCore::HTMLAnchorElement::setPort):
661         (WebCore::HTMLAnchorElement::setProtocol):
662         (WebCore::HTMLAnchorElement::setSearch):
663         * html/HTMLAnchorElement.h:
664         * html/HTMLAnchorElement.idl:
665         * loader/FrameLoader.cpp:
666         (WebCore::FrameLoader::iconURL):
667         * platform/KURL.cpp:
668         (WebCore::KURL::removePort):
669         (WebCore::KURL::setPort):
670         (WebCore::KURL::prettyURL):
671         (WebCore::protocolIsValid):
672         * platform/KURL.h:
673         (WebCore::KURL::canSetHostOrPort):
674         (WebCore::KURL::canSetPathname):
675         (WebCore::KURL::hasPort):
676         * platform/network/soup/ResourceHandleSoup.cpp:
677         (WebCore::):
678
679 2009-11-10  Nate Chapin  <japhet@chromium.org>
680
681         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
682
683         * platform/chromium/PopupMenuChromium.cpp:
684         (WebCore::PopupContainer::paintBorder):
685         (WebCore::PopupListBox::paint):
686         (WebCore::PopupListBox::paintRow):
687         * platform/graphics/chromium/TransparencyWin.cpp:
688         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
689         * platform/graphics/skia/GraphicsContextSkia.cpp:
690         (WebCore::GraphicsContext::fillRect):
691         (WebCore::GraphicsContext::fillRoundedRect):
692         (WebCore::GraphicsContext::setPlatformFillColor):
693         (WebCore::GraphicsContext::setPlatformStrokeColor):
694         * rendering/RenderMediaControlsChromium.cpp:
695         (WebCore::paintMediaSlider):
696         (WebCore::paintMediaVolumeSlider):
697         (WebCore::paintMediaTimelineContainer):
698         * rendering/RenderThemeChromiumMac.mm:
699         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
700
701 2009-11-10  Brady Eidson  <beidson@apple.com>
702
703         Reviewed by Sam Weinig.
704
705         Repro crash saving pcmag.com article as a webarchive.
706         <rdar://problem/7381219> and https://webkit.org/b/31322
707
708         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
709
710         * css/CSSStyleSheet.cpp:
711         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
712           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
713
714 2009-11-10  Beth Dakin  <bdakin@apple.com>
715
716         Attempt 2 to fix Tiger build. No review needed.
717
718         * platform/graphics/cg/GraphicsContextCG.cpp:
719         (WebCore::deviceRGBColorSpaceRef):
720         (WebCore::sRGBColorSpaceRef):
721
722 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
723
724         wx build fix. Changes needed after r50760.
725
726         * platform/graphics/wx/GraphicsContextWx.cpp:
727         (WebCore::GraphicsContext::GraphicsContext):
728         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
729         (WebCore::drawTextWithSpacing):
730
731 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
732
733         Qt build fix.
734
735         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
736         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
737
738 2009-11-10  Beth Dakin  <bdakin@apple.com>
739
740         Tiger build fix. No review needed.
741
742         * platform/graphics/cg/GraphicsContextCG.cpp:
743         (WebCore::sRGBColorSpaceRef):
744
745 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
746
747         Reviewed by Dan Bernstein.
748
749         https://bugs.webkit.org/show_bug.cgi?id=31312
750         Decouple authentication panel callbacks from ResourceHandle
751
752         No change in functionality.
753
754         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
755         ResourceHandle as delegate.
756
757         * WebCore.vcproj/WebCore.vcproj:
758         * platform/network/AuthenticationClient.h: Added.
759         Added a new interface for listening to authentication panel notifications.
760
761         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
762         it wants with the project file.
763
764         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
765         interface class.
766         (WebCore::AuthenticationClient::deref): Ditto.
767
768         * platform/network/ResourceHandle.h:
769         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
770         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
771
772         * platform/network/cf/AuthenticationCF.cpp:
773         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
774         (WebCore::AuthenticationChallenge::platformCompare):
775         * platform/network/cf/AuthenticationChallenge.h:
776         (WebCore::AuthenticationChallenge::authenticationClient):
777         * platform/network/chromium/AuthenticationChallenge.h:
778         (WebCore::AuthenticationChallenge::authenticationClient):
779         * platform/network/curl/AuthenticationChallenge.h:
780         (WebCore::AuthenticationChallenge::authenticationClient):
781         Keeping a reference to AuthenticationClient, not to ResourceHandle.
782
783 2009-11-10  Beth Dakin  <bdakin@apple.com>
784
785        Second attempted gtk build fix. No review needed.
786
787         * html/canvas/CanvasStyle.cpp:
788         (WebCore::CanvasStyle::applyStrokeColor):
789
790
791 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
792
793         Reviewed by Geoff Garen.
794
795         Fix back/forwards cache with JSC isolated worlds.
796         https://bugs.webkit.org/show_bug.cgi?id=31310
797         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
798
799         Store the global object for all worlds, not just the normal world.
800         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
801         so we can forget global objects if a world goes away.
802
803         * bindings/js/JSDOMBinding.cpp:
804         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
805         * bindings/js/JSDOMBinding.h:
806         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
807         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
808         * bindings/js/ScriptCachedFrameData.cpp:
809         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
810         (WebCore::ScriptCachedFrameData::forgetWorld):
811         (WebCore::ScriptCachedFrameData::domWindow):
812         (WebCore::ScriptCachedFrameData::restore):
813         (WebCore::ScriptCachedFrameData::clear):
814         * bindings/js/ScriptCachedFrameData.h:
815         * bindings/js/ScriptController.h:
816
817 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
818
819         [Qt] Unreviewed buildfix after r50760.
820
821         * platform/graphics/qt/GraphicsContextQt.cpp:
822         (WebCore::GraphicsContext::GraphicsContext):
823
824 2009-11-10  Beth Dakin  <bdakin@apple.com>
825
826         Attempted build fix. (No review needed.)
827
828         * GNUmakefile.am: Adding ColorSpace.h
829
830 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
831
832         Reviewed by NOBODY - Build Fix.
833
834         Updated function calls to take a ColorSpace argument, passing
835         in DeviceColorSpace for now - this should be fixed. Also added
836         ColorSpace.h to WebCore project.
837
838         * WebCore.vcproj/WebCore.vcproj:
839         * platform/graphics/win/FontCGWin.cpp:
840         (WebCore::Font::drawGlyphs):
841         * platform/graphics/win/GraphicsContextCGWin.cpp:
842         (WebCore::GraphicsContext::GraphicsContext):
843         * platform/win/PopupMenuWin.cpp:
844         (WebCore::PopupMenu::paint):
845         * platform/win/WebCoreTextRenderer.cpp:
846         (WebCore::doDrawTextAtPoint):
847         * rendering/RenderThemeSafari.cpp:
848         (WebCore::RenderThemeSafari::paintMenuListButton):
849
850 2009-11-10  Jens Alfke  <snej@chromium.org>
851
852         Reviewed by Darin Adler.
853
854         Optimizations to Element::getAttribute
855         https://bugs.webkit.org/show_bug.cgi?id=30926
856
857         * dom/Element.cpp:
858         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
859         * dom/NamedAttrMap.cpp:
860         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
861         * platform/text/PlatformString.h:
862         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
863
864 2009-11-10  Beth Dakin  <bdakin@apple.com>
865
866         Reviewed by Darin Adler.
867
868         Fix for <rdar://problem/7059710> 
869         -and corresponding-
870         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
871         color-correction for CSS colors
872
873         New exported symbol for GraphicsContext::fillColor() which now 
874         accepts a ColorSpace as an optional parameter.
875         * WebCore.base.exp:
876
877         Added a new file, ColorSpace.h, to define the ColorSpace enum.
878         * WebCore.xcodeproj/project.pbxproj:
879
880         Computed Style for -webkit-color-correction
881         * css/CSSComputedStyleDeclaration.cpp:
882         (WebCore::):
883         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
884
885         Parse -webkit-color-correction
886         * css/CSSParser.cpp:
887         (WebCore::CSSParser::parseValue):
888
889        Map CSS identifiers to the appropriate values of the ColorSpace enum
890         * css/CSSPrimitiveValueMappings.h:
891         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
892         (WebCore::CSSPrimitiveValue::operator ColorSpace):
893
894         New property -webkit-color-correction
895         * css/CSSPropertyNames.in:
896
897         Map -webkit-color-correction into the RenderStyle.
898         * css/CSSStyleSelector.cpp:
899         (WebCore::CSSStyleSelector::applyProperty):
900
901         Add new value sRGB.
902         * css/CSSValueKeywords.in:
903
904         Comment out the reference to sRGB since it will now be inherited as 
905         a value from CSSValueKeywords.
906         * css/SVGCSSValueKeywords.in:
907
908         Definition of the ColorSpace enum.
909         * platform/graphics/ColorSpace.h: Added.
910         (WebCore::):
911
912         These functions all now take a ColorSpace as a parameter.
913         * platform/graphics/GraphicsContext.cpp:
914         (WebCore::GraphicsContext::setStrokeColor):
915         (WebCore::GraphicsContext::setFillColor):
916         (WebCore::GraphicsContext::drawHighlightForText):
917
918         Return the appropriate ColorSpace.
919         (WebCore::GraphicsContext::strokeColorSpace):
920         (WebCore::GraphicsContext::fillColorSpace):
921
922         These functions all call other functions which require a ColorSpace 
923         as a parameter.
924         (WebCore::GraphicsContext::setStrokePattern):
925         (WebCore::GraphicsContext::setFillPattern):
926         (WebCore::GraphicsContext::setStrokeGradient):
927         (WebCore::GraphicsContext::setFillGradient):
928
929         All of the GraphicsContext functions that take a Color should now 
930         also take a ColorSpace.
931         * platform/graphics/GraphicsContext.h:
932
933         Added new member variables stokeColorSpace and fillColorSpace.
934         * platform/graphics/GraphicsContextPrivate.h:
935         (WebCore::GraphicsContextState::GraphicsContextState):
936
937         Attempt to keep the Cairo port building with all of the massive 
938         changes to GraphicsContext.        
939         * platform/graphics/cairo/GraphicsContextCairo.cpp:
940         (WebCore::GraphicsContext::fillRect):
941         (WebCore::GraphicsContext::setPlatformFillColor):
942         (WebCore::GraphicsContext::setPlatformStrokeColor):
943         (WebCore::GraphicsContext::fillRoundedRect):
944
945         
946         * platform/graphics/cg/GraphicsContextCG.cpp:
947         (WebCore::sRGBColorSpaceRef): New static function that returns a 
948         CGColorSpaceRef for the sRGB color space.
949         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
950         a CGColorSpaceRef for the device RGB color space.
951
952         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
953         sets the fill color to the specified color in the given ColorSpace.
954         (WebCore::setCGStrokeColor): Same, but for stroke.
955
956         (WebCore::setCGFillColorSpace): New static to set the 
957         CGFillColorSpace to the given ColorSpace
958         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
959
960         Send ColorSpaces when appropriate, set ColorSpaces when 
961         appropriate, and check ColorSpaces when appropriate.
962         (WebCore::GraphicsContext::GraphicsContext):
963         (WebCore::GraphicsContext::drawRect):
964         (WebCore::GraphicsContext::drawLine):
965         (WebCore::GraphicsContext::fillPath):
966         (WebCore::GraphicsContext::strokePath):
967         (WebCore::GraphicsContext::fillRect):
968         (WebCore::GraphicsContext::fillRoundedRect):
969         (WebCore::GraphicsContext::strokeRect):
970         (WebCore::GraphicsContext::drawLineForText):
971         (WebCore::GraphicsContext::setPlatformStrokeColor):
972         (WebCore::GraphicsContext::setPlatformFillColor):
973
974         Attempt to keep Haiku building.
975         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
976         (WebCore::GraphicsContext::fillRect):
977         (WebCore::GraphicsContext::fillRoundedRect):
978         (WebCore::GraphicsContext::setPlatformStrokeColor):
979         (WebCore::GraphicsContext::setPlatformFillColor):
980
981         Attempt to keep QT building.
982         * platform/graphics/qt/GraphicsContextQt.cpp:
983         (WebCore::GraphicsContext::fillRect):
984         (WebCore::GraphicsContext::fillRoundedRect):
985         (WebCore::GraphicsContext::setPlatformStrokeColor):
986         (WebCore::GraphicsContext::setPlatformFillColor):
987
988         Attempt to keep Wince building.
989         * platform/graphics/wince/GraphicsContextWince.cpp:
990         (WebCore::GraphicsContext::fillRect):
991         (WebCore::GraphicsContext::setPlatformFillColor):
992         (WebCore::GraphicsContext::setPlatformStrokeColor):
993         (WebCore::GraphicsContext::clearRect):
994         (WebCore::GraphicsContext::fillRoundedRect):
995         (WebCore::GraphicsContext::setPlatformShadow):
996
997         Attempt to keep WX building.
998         * platform/graphics/wx/GraphicsContextWx.cpp:
999         (WebCore::GraphicsContext::fillRect):
1000         (WebCore::GraphicsContext::fillRoundedRect):
1001         (WebCore::GraphicsContext::setPlatformStrokeColor):
1002         (WebCore::GraphicsContext::setPlatformFillColor):
1003
1004         Added functions colorSpace() and setColorSpace()
1005         * rendering/style/RenderStyle.h:
1006         (WebCore::InheritedFlags::colorSpace):
1007         (WebCore::InheritedFlags::setColorSpace):
1008
1009         The ColorSpace is stored here.
1010         * rendering/style/StyleRareInheritedData.cpp:
1011         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1012         (WebCore::StyleRareInheritedData::operator==):
1013         * rendering/style/StyleRareInheritedData.h:
1014
1015         All of these call sites call GraphicsContext functions which now 
1016         require ColorSpaces.
1017         * editing/SelectionController.cpp:
1018         (WebCore::SelectionController::paintCaret):
1019         * html/canvas/CanvasRenderingContext2D.cpp:
1020         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1021         * html/canvas/CanvasStyle.cpp:
1022         (WebCore::CanvasStyle::applyStrokeColor):
1023         (WebCore::CanvasStyle::applyFillColor):
1024         * inspector/InspectorController.cpp:
1025         (WebCore::drawOutlinedQuad):
1026         * page/FrameView.cpp:
1027         (WebCore::FrameView::paintContents):
1028         * platform/ScrollbarTheme.h:
1029         (WebCore::ScrollbarTheme::paintScrollCorner):
1030         * platform/ScrollbarThemeComposite.cpp:
1031         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1032         * platform/graphics/Image.cpp:
1033         (WebCore::Image::fillWithSolidColor):
1034         * platform/graphics/mac/FontMac.mm:
1035         (WebCore::Font::drawGlyphs):
1036         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1037         (WebCore::MediaPlayerPrivate::paint):
1038         * rendering/EllipsisBox.cpp:
1039         (WebCore::EllipsisBox::paint):
1040         * rendering/InlineFlowBox.cpp:
1041         (WebCore::InlineFlowBox::paintTextDecorations):
1042         * rendering/InlineTextBox.cpp:
1043         (WebCore::updateGraphicsContext):
1044         (WebCore::paintTextWithShadows):
1045         (WebCore::InlineTextBox::paint):
1046         (WebCore::InlineTextBox::paintSelection):
1047         (WebCore::InlineTextBox::paintCompositionBackground):
1048         (WebCore::InlineTextBox::paintDecoration):
1049         (WebCore::InlineTextBox::paintTextMatchMarker):
1050         (WebCore::InlineTextBox::paintCompositionUnderline):
1051         * rendering/InlineTextBox.h:
1052         * rendering/RenderBlock.cpp:
1053         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1054         (WebCore::RenderBlock::fillVerticalSelectionGap):
1055         (WebCore::RenderBlock::fillLeftSelectionGap):
1056         (WebCore::RenderBlock::fillRightSelectionGap):
1057         * rendering/RenderBoxModelObject.cpp:
1058         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1059         (WebCore::RenderBoxModelObject::paintBoxShadow):
1060         * rendering/RenderFileUploadControl.cpp:
1061         (WebCore::RenderFileUploadControl::paintObject):
1062         * rendering/RenderFrameSet.cpp:
1063         (WebCore::RenderFrameSet::paintColumnBorder):
1064         (WebCore::RenderFrameSet::paintRowBorder):
1065         * rendering/RenderImage.cpp:
1066         (WebCore::RenderImage::paintReplaced):
1067         * rendering/RenderLayer.cpp:
1068         (WebCore::RenderLayer::paintScrollCorner):
1069         (WebCore::RenderLayer::paintResizer):
1070         * rendering/RenderListBox.cpp:
1071         (WebCore::RenderListBox::paintItemForeground):
1072         (WebCore::RenderListBox::paintItemBackground):
1073         * rendering/RenderListMarker.cpp:
1074         (WebCore::RenderListMarker::paint):
1075         * rendering/RenderObject.cpp:
1076         (WebCore::RenderObject::drawLineForBoxSide):
1077         (WebCore::RenderObject::drawArcForBoxSide):
1078         * rendering/RenderReplaced.cpp:
1079         (WebCore::RenderReplaced::paint):
1080         * rendering/RenderScrollbarTheme.cpp:
1081         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1082         * rendering/RenderThemeMac.mm:
1083         (WebCore::RenderThemeMac::paintMenuListButton):
1084         * rendering/RenderView.cpp:
1085         (WebCore::RenderView::paintBoxDecorations):
1086         * rendering/RenderWidget.cpp:
1087         (WebCore::RenderWidget::paint):
1088         * rendering/SVGInlineTextBox.cpp:
1089         (WebCore::SVGInlineTextBox::paintSelection):
1090         * svg/graphics/SVGPaintServerGradient.cpp:
1091         (WebCore::SVGPaintServerGradient::setup):
1092         * svg/graphics/SVGPaintServerSolid.cpp:
1093         (WebCore::SVGPaintServerSolid::setup):
1094
1095 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1096
1097         Reviewed by Timothy Hatcher.
1098
1099         Web Inspector: Speed up syntax highlighter
1100         https://bugs.webkit.org/show_bug.cgi?id=31291
1101
1102         * inspector/front-end/SourceFrame.js:
1103         (WebInspector.SourceFrame.prototype._loaded):
1104         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1105         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1106         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1107         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1108         (WebInspector.CSSSourceSyntaxHighlighter):
1109         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1110
1111 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1112
1113         Reviewed by Eric Seidel.
1114
1115         Remove session storage setting
1116         https://bugs.webkit.org/show_bug.cgi?id=31279
1117
1118         Remove session storage from Settings.  It was added temporarily so we could
1119         disable it by default at runtime in Chromium.  We now disable these things in a
1120         different way, so it's time to remove it.  Qt also depended on this setting for
1121         a short period of time, but after talking to them we agreed that it should be
1122         removed.
1123
1124         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1125
1126         * page/DOMWindow.cpp:
1127         (WebCore::DOMWindow::sessionStorage):
1128         * page/Settings.cpp:
1129         (WebCore::Settings::Settings):
1130         * page/Settings.h:
1131
1132 2009-11-10  Dan Bernstein  <mitz@apple.com>
1133
1134         Reviewed by Eric Carlson and Darin Adler.
1135
1136         WebCore part of making full-screen video pause during scrubbing.
1137
1138         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1139         and HTMLMediaElement::endScrubbing().
1140
1141 2009-11-10  Anton Muhin  <antonm@chromium.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1146         https://bugs.webkit.org/show_bug.cgi?id=31051
1147
1148         * bindings/v8/V8GCController.cpp:
1149         (WebCore::V8GCController::gcEpilogue):
1150         (WebCore::V8GCController::checkMemoryUsage):
1151         * bindings/v8/V8GCController.h:
1152         * bindings/v8/V8Proxy.cpp:
1153         (WebCore::V8Proxy::evaluate):
1154         (WebCore::V8Proxy::runScript):
1155         (WebCore::V8Proxy::callFunction):
1156
1157 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1158
1159         Reviewed by Darin Adler.
1160
1161         Allow custom memory allocation control for the part of loader directory in WebCore
1162         https://bugs.webkit.org/show_bug.cgi?id=31161
1163
1164         Inherits the following classes from Noncopyable because these are instantiated
1165         by 'new' and these are no need to be copyable:
1166
1167         class Request - WebCore/loader/loader.cpp:100
1168         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1169         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1170         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1171         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1172         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1173
1174         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1175         MainThreadBridge is instantiated by 'new' in 
1176         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1177
1178         ThreadableLoaderClient's inheriting has been changed to public.
1179
1180         * loader/ImageLoader.cpp:
1181         * loader/ProgressTracker.cpp:
1182         * loader/RedirectScheduler.cpp:
1183         * loader/Request.h:
1184         * loader/ThreadableLoaderClient.h:
1185         * loader/WorkerThreadableLoader.h:
1186         * loader/appcache/ApplicationCacheHost.h:
1187         * loader/appcache/ApplicationCacheStorage.h:
1188
1189 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1190
1191         Reviewed by Eric Seidel.
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=31047
1194         [GTK] Failing test media/video-played-ranges-1.html
1195
1196         WebKit coding style fixes.
1197
1198         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1199         (WebCore::mediaPlayerPrivateMessageCallback):
1200         (WebCore::MediaPlayerPrivate::naturalSize):
1201         (WebCore::MediaPlayerPrivate::paint):
1202         (WebCore::mimeTypeCache):
1203
1204 2009-11-10  Oliver Hunt  <oliver@apple.com>
1205
1206         Remove build failure introduced by earlier build fix.
1207
1208         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1209
1210 2009-11-10  Oliver Hunt  <oliver@apple.com>
1211
1212         Is this the last build fix? grep tells me yes.
1213
1214         * bindings/v8/custom/V8DocumentCustom.cpp:
1215         (WebCore::CALLBACK_FUNC_DECL):
1216
1217 2009-11-10  Oliver Hunt  <oliver@apple.com>
1218
1219         Hopefully the last one.  Why aren't these autogenerated?
1220
1221         * bindings/v8/V8DOMWrapper.cpp:
1222         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1223         (WebCore::V8DOMWrapper::getTemplate):
1224         (WebCore::V8DOMWrapper::convertToV8Object):
1225
1226 2009-11-10  Oliver Hunt  <oliver@apple.com>
1227
1228         Another chrome build fix.
1229
1230         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1231         (WebCore::CALLBACK_FUNC_DECL):
1232
1233 2009-11-10  Oliver Hunt  <oliver@apple.com>
1234
1235         Yet another chrome buildfix
1236
1237         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1238         (WebCore::CALLBACK_FUNC_DECL):
1239         * bindings/v8/custom/V8WebGLArrayCustom.h:
1240         (WebCore::constructCanvasArray):
1241         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1242         (WebCore::CALLBACK_FUNC_DECL):
1243         (WebCore::INDEXED_PROPERTY_GETTER):
1244         (WebCore::INDEXED_PROPERTY_SETTER):
1245         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1246         (WebCore::CALLBACK_FUNC_DECL):
1247         (WebCore::INDEXED_PROPERTY_GETTER):
1248         (WebCore::INDEXED_PROPERTY_SETTER):
1249         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1250         (WebCore::CALLBACK_FUNC_DECL):
1251         (WebCore::INDEXED_PROPERTY_GETTER):
1252         (WebCore::INDEXED_PROPERTY_SETTER):
1253         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1254         (WebCore::CALLBACK_FUNC_DECL):
1255         (WebCore::vertexAttribAndUniformHelperf):
1256         (WebCore::uniformHelperi):
1257         (WebCore::uniformMatrixHelper):
1258         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1259         (WebCore::CALLBACK_FUNC_DECL):
1260         (WebCore::INDEXED_PROPERTY_GETTER):
1261         (WebCore::INDEXED_PROPERTY_SETTER):
1262         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1263         (WebCore::CALLBACK_FUNC_DECL):
1264         (WebCore::INDEXED_PROPERTY_GETTER):
1265         (WebCore::INDEXED_PROPERTY_SETTER):
1266         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1267         (WebCore::CALLBACK_FUNC_DECL):
1268         (WebCore::INDEXED_PROPERTY_GETTER):
1269         (WebCore::INDEXED_PROPERTY_SETTER):
1270         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1271         (WebCore::CALLBACK_FUNC_DECL):
1272         (WebCore::INDEXED_PROPERTY_GETTER):
1273         (WebCore::INDEXED_PROPERTY_SETTER):
1274
1275 2009-11-10  Oliver Hunt  <oliver@apple.com>
1276
1277         Chrome build fix.
1278
1279         * bindings/v8/V8Index.h:
1280
1281 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1282
1283         Reviewed by Reviewed by Jan Alonzo.
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=30901
1286         [Gtk] Need to de-lint the Atk a11y code
1287
1288         Removal of various and sundry style-violating nits.
1289
1290         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1291
1292 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1293
1294         Reviewed by Jan Alonzo.
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=31047
1297         [GTK] Failing test media/video-played-ranges-1.html
1298
1299         Fix playback rate setter by remembering the rate was changed. Also
1300         correctly handle reverse playback by doing a seek from end to
1301         beginning of the media.
1302
1303         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1304         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1305         (WebCore::MediaPlayerPrivate::currentTime):
1306         (WebCore::MediaPlayerPrivate::seek):
1307         (WebCore::MediaPlayerPrivate::hasAudio):
1308         (WebCore::MediaPlayerPrivate::setVolume):
1309         (WebCore::MediaPlayerPrivate::setRate):
1310         (WebCore::MediaPlayerPrivate::updateStates):
1311         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
1312
1313 2009-11-10  Oliver Hunt  <oliver@apple.com>
1314
1315         Reviewed by Maciej Stachowiak.
1316
1317         Rename 3D Canvas related classes to use WebGL prefix
1318         https://bugs.webkit.org/show_bug.cgi?id=29095
1319
1320         Automatic rename of all WebGL related types from Canvas* to
1321         WebGL* per more recent version of the WebGL spec.
1322
1323         Due to the automatic rename I've removed the 600+ line change list.
1324
1325 2009-11-09  Dirk Schulze  <krit@webkit.org>
1326
1327         Reviewed by Oliver Hunt.
1328
1329         SVG feDisplacementMap is not implemented
1330         [https://bugs.webkit.org/show_bug.cgi?id=31255]
1331
1332         This is the implementation of the SVG filter effect
1333         feDisplacementMap. 
1334
1335         Test: svg/filters/feDisplacementMap.svg
1336
1337         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
1338         (WebCore::FEDisplacementMap::apply):
1339
1340 2009-11-09  Kent Tamura  <tkent@chromium.org>
1341
1342         Reviewed by Darin Adler.
1343
1344         Add a comment about null strings and hash functions.
1345         https://bugs.webkit.org/show_bug.cgi?id=29118
1346
1347         * platform/text/StringHash.h:
1348
1349 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1350
1351         Reviewed by Darin Adler.
1352
1353         Compiler warnings in InspectorResource.h
1354         https://bugs.webkit.org/show_bug.cgi?id=29231
1355
1356         Fix compilation warnings by removing addition operation on an enum type.
1357
1358         * inspector/InspectorResource.h:
1359         (WebCore::InspectorResource::):
1360         (WebCore::InspectorResource::Changes::hasChange):
1361         (WebCore::InspectorResource::Changes::set):
1362         (WebCore::InspectorResource::Changes::setAll):
1363
1364 2009-11-09  Anders Carlsson  <andersca@apple.com>
1365
1366         Reviewed by Darin Adler and Dan Bernstein.
1367
1368         <rdar://problem/7328395>
1369         https://bugs.webkit.org/show_bug.cgi?id=31277
1370
1371         When an object tag's style changes (for example when child nodes are added/removed),
1372         reuse its Frame (if it has one) instead of creating multiple Frames.
1373
1374         Test: fast/dom/HTMLObjectElement/children-changed.html
1375
1376         * loader/FrameLoader.cpp:
1377         (WebCore::FrameLoader::requestObject):
1378
1379 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
1380
1381         Reviewed by Kenneth Rohde Christiansen.
1382
1383         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
1384         since adjustment of RW-section base address will be needed for all new symbian
1385         tool chains, specifically for arm and gcc compilation targets.
1386         Also, change target address to 0xE00000 to be sufficient for all targets.
1387
1388         * WebCore.pro:
1389
1390 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
1391
1392         Reviewed by Timothy Hatcher.
1393
1394         Web Inspector: Crash when inspecting
1395         WebCore\manual-tests\inspector\dom-mutation.html
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=31259
1398
1399         * inspector/InspectorDOMAgent.cpp:
1400         (WebCore::InspectorDOMAgent::handleEvent):
1401
1402 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1403
1404         Reviewed by Kenneth Rohde Christiansen.
1405
1406         [Qt] Few classes have virtual functions but non-virtual destructor
1407         https://bugs.webkit.org/show_bug.cgi?id=31269
1408
1409         No new tests as there is no functional change.
1410
1411         * platform/qt/QWebPageClient.h:
1412         (QWebPageClient::~QWebPageClient): Add virtual destructor.
1413
1414 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
1415
1416         Reviewed by Kenneth Rohde Christiansen.
1417
1418         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
1419         https://bugs.webkit.org/show_bug.cgi?id=31140
1420
1421         QtNetwork interprets null string as request to remove the header, not add it.
1422         Replace null values with empty values before passing them to QtNetwork.
1423
1424         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
1425
1426         * platform/network/qt/ResourceRequestQt.cpp:
1427         (WebCore::ResourceRequest::toNetworkRequest):
1428
1429 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
1430
1431         Reviewed by Kevin Ollivier.
1432
1433         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
1434         simply ignored before resulting in transparent areas being black in PNG
1435         images for example.
1436         
1437         https://bugs.webkit.org/show_bug.cgi?id=30823
1438
1439         * platform/image-decoders/wx/ImageDecoderWx.cpp:
1440         (WebCore::RGBA32Buffer::asNewNativeImage):
1441
1442 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1443
1444         Reviewed by Kenneth Rohde Christiansen.
1445
1446         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
1447         https://bugs.webkit.org/show_bug.cgi?id=31040
1448
1449         No new tests as there is no functional change.
1450
1451         * dom/Document.cpp:
1452         (WebCore::Document::recalcStyleSelector):
1453         * editing/TextIterator.cpp:
1454         (WebCore::pushFullyClippedState):
1455         * editing/VisibleSelection.cpp:
1456         (WebCore::VisibleSelection::appendTrailingWhitespace):
1457         * html/HTMLLinkElement.cpp:
1458         (WebCore::HTMLLinkElement::process):
1459         * loader/RedirectScheduler.cpp:
1460         (WebCore::RedirectScheduler::mustLockBackForwardList):
1461         * loader/appcache/ApplicationCacheGroup.cpp:
1462         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
1463         * platform/graphics/qt/FontCacheQt.cpp:
1464         (WebCore::FontPlatformDataCacheKey::computeHash):
1465         * rendering/RenderBlock.cpp:
1466         (WebCore::RenderBlock::handleRunInChild):
1467         * rendering/RenderBox.cpp:
1468         (WebCore::RenderBox::calcHeight):
1469         * rendering/RenderTextControlMultiLine.cpp:
1470         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1471         * rendering/style/RenderStyle.cpp:
1472         (WebCore::RenderStyle::diff):
1473         * svg/SVGAnimateElement.cpp:
1474         (WebCore::parseNumberValueAndUnit):
1475         * svg/SVGAnimationElement.cpp:
1476         (WebCore::SVGAnimationElement::startedActiveInterval):
1477         * svg/SVGPreserveAspectRatio.cpp:
1478         (WebCore::SVGPreserveAspectRatio::getCTM):
1479
1480 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
1481
1482         Reviewed by Dimitri Glazkov.
1483
1484         Win chromium is slow to draw transparent texts
1485         https://bugs.webkit.org/show_bug.cgi?id=31258
1486
1487         Clip graphics context to reduce calculation.
1488
1489         No new tests because this change only affects performance.
1490
1491         * platform/graphics/chromium/FontChromiumWin.cpp:
1492         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1493         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1494
1495 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
1496
1497         Reviewed by Darin Adler.
1498
1499         showTree(CounterNode*) generates too little info and has too many spaces.
1500         https://bugs.webkit.org/show_bug.cgi?id=31212
1501
1502         No new tests as the change has no functional effect it is just for
1503         improved debugging.
1504
1505         * rendering/CounterNode.cpp:
1506         (WebCore::showTreeAndMark):
1507         Changed to also show addresses of parent, next and previous
1508         siblings.
1509
1510 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
1511
1512         Reviewed by Darin Adler.
1513
1514         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
1515         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
1516
1517         https://bugs.webkit.org/show_bug.cgi?id=31083
1518
1519         No new tests; implementation is unchanged.
1520
1521         * page/Frame.cpp:
1522         (WebCore::Frame::setUseSecureKeyboardEntry):
1523         * page/mac/FrameMac.mm:
1524
1525 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1526
1527         Reviewed by Jan Alonzo.
1528
1529         Make XP_UNIX tests consistent
1530         https://bugs.webkit.org/show_bug.cgi?id=31250
1531
1532         No new tests as there is no functional change.
1533
1534         * plugins/PluginView.cpp:
1535         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
1536         instead of the value of the macro
1537
1538         * plugins/gtk/PluginViewGtk.cpp:
1539         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
1540         defined instead of using the PLATFORM macro to be consistent
1541         (WebCore::PluginView::getValue): Ditto.
1542
1543 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
1544
1545         Reviewed by Darin Adler.
1546
1547         Thunk to the main thread from ~Database to deref Database's m_document.
1548
1549         If the Database was the Document's last referrer, then ~Document occurs on the
1550         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
1551         ASSERT in debug builds.
1552
1553         * storage/Database.cpp:
1554         (WebCore::derefDocument):
1555         (WebCore::Database::~Database):
1556
1557 2009-11-09  Mark Mentovai  <mark@chromium.org>
1558
1559         Reviewed by Dan Bernstein.
1560
1561         Track "can have scrollbar" state within FrameView independently of the
1562         individual scrollbar states in ScrollView.
1563
1564         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
1565         REGRESSION (r48064): mint.com loses scrollbars after coming out of
1566         edit mode.
1567
1568         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
1569         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
1570
1571         Test: fast/overflow/scrollbar-restored.html
1572
1573         * WebCore.base.exp:
1574         * page/FrameView.cpp:
1575         (WebCore::FrameView::FrameView):
1576         (WebCore::FrameView::resetScrollbars):
1577         (WebCore::FrameView::setCanHaveScrollbars):
1578         (WebCore::FrameView::updateCanHaveScrollbars):
1579         (WebCore::FrameView::layout):
1580         * page/FrameView.h:
1581         * platform/ScrollView.h:
1582
1583 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
1584
1585         Reviewed by Timothy Hatcher.
1586
1587         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
1588         https://bugs.webkit.org/show_bug.cgi?id=31257
1589
1590         * inspector/front-end/SourceFrame.js:
1591
1592 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
1593
1594         Reviewed by Timothy Hatcher.
1595
1596         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
1597         https://bugs.webkit.org/show_bug.cgi?id=31252
1598
1599         Route F1-F12 keypresses in the Console view to the current panel if there is one.
1600
1601         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
1602
1603         * inspector/front-end/ConsoleView.js:
1604         (WebInspector.ConsoleView.prototype._promptKeyDown):
1605         * inspector/front-end/utilities.js:
1606         ():
1607         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
1608
1609 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
1610
1611         Reviewed by Kenneth Rohde Christiansen.
1612
1613         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
1614         https://bugs.webkit.org/show_bug.cgi?id=31208
1615
1616         After r42483, the credentials are no longer passed to the network request
1617         in the URL of the request.
1618         Pass the credentials from XMLHTTPRequest to the network request, the same
1619         way that other ports do.
1620
1621         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
1622
1623         * platform/network/qt/ResourceHandleQt.cpp:
1624         (WebCore::ResourceHandle::start):
1625         (WebCore::ResourceHandle::loadResourceSynchronously):
1626
1627 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1628
1629         Unreviewed.
1630
1631         https://bugs.webkit.org/show_bug.cgi?id=31161
1632
1633         Roll back r50657 because it breaks the MAC builds.
1634
1635         * loader/ImageLoader.cpp:
1636         * loader/ProgressTracker.cpp:
1637         * loader/RedirectScheduler.cpp:
1638         * loader/Request.h:
1639         * loader/ThreadableLoaderClient.h:
1640         * loader/WorkerThreadableLoader.h:
1641         * loader/appcache/ApplicationCacheHost.h:
1642         * loader/appcache/ApplicationCacheStorage.h:
1643         * loader/icon/IconDatabaseClient.h:
1644
1645 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1646
1647         Reviewed by Darin Adler.
1648
1649         Allow custom memory allocation control for the part of loader directory in WebCore
1650         https://bugs.webkit.org/show_bug.cgi?id=31161
1651
1652         Inherits the following classes from Noncopyable because these are instantiated
1653         by 'new' and these are no need to be copyable:
1654
1655         class Request - WebCore/loader/loader.cpp:100
1656         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1657         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
1658         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1659         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1660         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1661         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1662
1663         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1664         MainThreadBridge is instantiated by 'new' in 
1665         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1666
1667         ThreadableLoaderClient's inheriting has been changed to public.
1668
1669         * loader/ImageLoader.cpp:
1670         * loader/ProgressTracker.cpp:
1671         * loader/RedirectScheduler.cpp:
1672         * loader/Request.h:
1673         * loader/ThreadableLoaderClient.h:
1674         * loader/WorkerThreadableLoader.h:
1675         * loader/appcache/ApplicationCacheHost.h:
1676         * loader/appcache/ApplicationCacheStorage.h:
1677         * loader/icon/IconDatabaseClient.h:
1678
1679 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1680
1681         Reviewed by Darin Adler.
1682
1683         Allow custom memory allocation control for WebCore's DocLoader
1684         https://bugs.webkit.org/show_bug.cgi?id=31163
1685
1686         Inherits DocLoader class from Noncopyable because it is
1687         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
1688         it is no need to be copyable.
1689
1690         * loader/DocLoader.h:
1691
1692 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1693
1694         Reviewed by Darin Adler.
1695
1696         Allow custom memory allocation control for WebCore's Tokenizer
1697         https://bugs.webkit.org/show_bug.cgi?id=31162
1698
1699         Inherits Tokenizer class from Noncopyable because (its child class)
1700         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
1701         and it is no need to be copyable.
1702
1703         * dom/Tokenizer.h:
1704
1705 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
1706
1707         Reviewed by Darin Adler.
1708
1709         Allow custom memory allocation control for WebCore's DeleteButtonController
1710         https://bugs.webkit.org/show_bug.cgi?id=31105
1711
1712         Inherits DeleteButtonController class from Noncopyable because it is 
1713         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
1714         it is no need to be copyable.  
1715
1716         * editing/DeleteButtonController.h:
1717
1718 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1719
1720         Reviewed by Jan Alonzo.
1721
1722         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1723         https://bugs.webkit.org/show_bug.cgi?id=30482
1724
1725         Expose Page::tabKeyCyclesThroughElements as a property of
1726         WebKitWebView.
1727
1728         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
1729
1730         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
1731         (WebCore::singleCharacterString):
1732
1733 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1734
1735         Reviewed by Xan Lopez.
1736
1737         https://bugs.webkit.org/show_bug.cgi?id=25415
1738         [GTK][ATK] Please implement support for get_text_at_offset
1739
1740         Fix a crasher that occurred with text which included newline
1741         chars in the markup.
1742
1743         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1744         (convertUniCharToUTF8):
1745
1746 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
1747
1748         Reviewed by Holger Freyther.
1749
1750         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
1751         https://bugs.webkit.org/show_bug.cgi?id=31144
1752
1753         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
1754         documents that end prematurely but are not considered invalid by QXmlStream.
1755         This is to stay compatible with the libxml2 implementation.
1756         However, that code path would be also hit in situations when it should not,
1757         i.e. the error would have already been caught and handled. As a result, the
1758         same error would be reported twice.
1759
1760         No new tests, because the problem is already covered by
1761         fast/parser/xml-declaration-missing-ending-mark.html.
1762
1763         * dom/XMLTokenizerQt.cpp:
1764         (WebCore::XMLTokenizer::doEnd):
1765
1766 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
1767
1768         Reviewed by Pavel Feldman.
1769
1770         Web Inspector: Inspector should support copy() in the command line
1771         https://bugs.webkit.org/show_bug.cgi?id=31238
1772
1773         * inspector/InspectorBackend.cpp:
1774         (WebCore::InspectorBackend::copyText): Added.
1775         * inspector/InspectorBackend.h: Added copyText
1776         * inspector/InspectorBackend.idl: Added copyText
1777         * inspector/front-end/InjectedScript.js:
1778         (InjectedScript._copy): Added.
1779         (InjectedScript._ensureCommandLineAPIInstalled):
1780
1781 2009-11-08  Drew Wilson  <atwilson@chromium.org>
1782
1783         Reviewed by Dimitri Glazkov.
1784
1785         V8 WorkerContextExecutionProxy does not handle SharedWorkers
1786         https://bugs.webkit.org/show_bug.cgi?id=31226
1787
1788         Now checks to see what type of context is active and creates the
1789         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
1790
1791         Added support for converting to SharedWorkers and SharedWorkerContexts.
1792
1793         Test: Existing layout tests cover this case (start passing in Chrome).
1794
1795         * bindings/v8/WorkerContextExecutionProxy.cpp:
1796         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
1797         Now generates the right type of DOMWrapper for SharedWorkerContexts.
1798         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
1799         Added support for SHAREDWORKERCONTEXT.
1800         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
1801         Added support for SharedWorker and SharedWorkerContext.
1802
1803 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
1804
1805         Reviewed by Dimitri Glazkov.
1806
1807         https://bugs.webkit.org/show_bug.cgi?id=31224
1808         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
1809
1810         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
1811
1812         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
1813         (WebCore::NAMED_PROPERTY_GETTER):
1814
1815 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
1816
1817         Reviewed by Timothy Hatcher.
1818
1819         Web Inspector: "Search again" on scripts panel switches
1820         to the script this search started with.
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=31243
1823
1824         * inspector/front-end/Panel.js:
1825         (WebInspector.Panel.prototype.jumpToNextSearchResult):
1826
1827 2009-11-08  Kent Tamura  <tkent@chromium.org>
1828
1829         Reviewed by Darin Adler.
1830
1831         Simplify Icon interface.
1832         https://bugs.webkit.org/show_bug.cgi?id=31154
1833
1834         - Remove Icon::createIconForFile().  createIconForFiles() covers
1835           createIconForFile()'s role.
1836         - Remove FileChooser::chooseIcon()
1837         - Change the parameter types of FileChooser constructor and the
1838           factory method, String -> const Vector<String>&, in order to
1839           support initialization with multiple files.
1840         - Remove the icon loading code in IconChromiumWin.cpp, which
1841           doesn't work because of the sandbox.
1842
1843         No tests because it's just a refactoring.
1844
1845         * platform/FileChooser.cpp:
1846         (WebCore::FileChooser::FileChooser):
1847         (WebCore::FileChooser::create):
1848         (WebCore::FileChooser::chooseFile):
1849         (WebCore::FileChooser::chooseFiles):
1850         * platform/FileChooser.h:
1851         * platform/graphics/Icon.h:
1852         * platform/graphics/chromium/IconChromiumLinux.cpp:
1853         * platform/graphics/chromium/IconChromiumMac.cpp:
1854         * platform/graphics/chromium/IconChromiumWin.cpp:
1855         (WebCore::Icon::createIconForFiles):
1856         * platform/graphics/gtk/IconGtk.cpp:
1857         (WebCore::Icon::createIconForFiles):
1858         * platform/graphics/haiku/IconHaiku.cpp:
1859         * platform/graphics/mac/IconMac.mm:
1860         (WebCore::Icon::createIconForFiles):
1861         * platform/graphics/qt/IconQt.cpp:
1862         (WebCore::Icon::createIconForFiles):
1863         * platform/graphics/win/IconWin.cpp:
1864         (WebCore::Icon::createIconForFiles):
1865         * platform/graphics/wx/IconWx.cpp:
1866         * rendering/RenderFileUploadControl.cpp:
1867         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1868
1869 2009-11-08  Daniel Bates  <dbates@webkit.org>
1870
1871         Reviewed by Adam Barth.
1872
1873         https://bugs.webkit.org/show_bug.cgi?id=31098
1874
1875         Allows same-origin plugin-based content to load.
1876
1877         Test: http/tests/security/xssAuditor/object-src-inject.html
1878
1879         * page/XSSAuditor.cpp:
1880         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
1881         (WebCore::XSSAuditor::canLoadObject): Ditto.
1882         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
1883         (WebCore::XSSAuditor::isSameOriginResource): Added.
1884         * page/XSSAuditor.h:
1885
1886 2009-11-08  David Levin  <levin@chromium.org>
1887
1888         Reviewed by NOBODY (chromium build fix).
1889
1890         * platform/network/HTTPParsers.cpp:
1891         (WebCore::parseDate): Changed this to not
1892         use a date parser that needs ExecState passed.
1893         
1894 2009-11-08  David Levin  <levin@chromium.org>
1895
1896         Unreviewed build fix for chromium.
1897
1898         * platform/graphics/skia/GraphicsContextSkia.cpp:
1899         (WebCore::GraphicsContext::fillPath):
1900         (WebCore::GraphicsContext::fillRect):
1901         (WebCore::GraphicsContext::strokePath):
1902         (WebCore::GraphicsContext::strokeRect):
1903
1904 2009-11-08  David Levin  <levin@chromium.org>
1905
1906         Unreviewed build fix for chromium.
1907
1908         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
1909         Clean up GraphicsContext's current concept of ColorSpace
1910
1911         * platform/graphics/skia/GraphicsContextSkia.cpp:
1912         (WebCore::GraphicsContext::fillPath):
1913         (WebCore::GraphicsContext::fillRect):
1914         (WebCore::GraphicsContext::strokePath):
1915         (WebCore::GraphicsContext::strokeRect):
1916
1917 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
1918
1919         Reviewed by Timothy Hatcher.
1920
1921         Web Inspector: [REGRESSION] committing style edit
1922         clears elements panel selection.
1923
1924         https://bugs.webkit.org/show_bug.cgi?id=31242
1925
1926         * inspector/front-end/ElementsTreeOutline.js:
1927         (WebInspector.ElementsTreeOutline.prototype.update):
1928         * inspector/front-end/StylesSidebarPane.js:
1929         (WebInspector.StylePropertyTreeElement.prototype.):
1930         (WebInspector.StylePropertyTreeElement.prototype):
1931
1932 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
1933
1934         Reviewed by Holger Freyther.
1935
1936         ResourceRequest to be class instead of struct
1937         https://bugs.webkit.org/show_bug.cgi?id=30670
1938
1939         Started as a compilation fix for Symbian where the compiler makes a distinction between
1940         class and struct in function argument signatures.
1941         Changed all forward declarations of ResourceRequest to have class in the forward
1942         declaration instead of struct and changed the definition of ResourceRequest to be class
1943         and added access qualifiers where missing. Additionally two references of friend
1944         struct ResourceRequestBase changed to class instead.
1945
1946         * history/HistoryItem.h:
1947         * inspector/InspectorController.h:
1948         * inspector/InspectorResource.h:
1949         * loader/DocumentThreadableLoader.h:
1950         * loader/FrameLoaderClient.h:
1951         * loader/MainResourceLoader.h:
1952         * loader/ResourceLoadNotifier.h:
1953         * loader/SubresourceLoader.h:
1954         * loader/SubresourceLoaderClient.h:
1955         * loader/ThreadableLoader.h:
1956         * loader/WorkerThreadableLoader.h:
1957         * loader/appcache/ApplicationCache.h:
1958         * loader/appcache/ApplicationCacheHost.h:
1959         * platform/CrossThreadCopier.h:
1960         * platform/network/ResourceHandle.h:
1961         * platform/network/ResourceHandleClient.h:
1962         * platform/network/ResourceRequestBase.h:
1963         * platform/network/cf/ResourceRequest.h:
1964         * platform/network/cf/ResourceRequestCFNet.h:
1965         * platform/network/chromium/ResourceRequest.h:
1966         * platform/network/curl/ResourceRequest.h:
1967         * platform/network/qt/ResourceRequest.h:
1968         * platform/network/soup/ResourceRequest.h:
1969         * xml/XMLHttpRequest.h:
1970
1971 2009-11-08  Dan Bernstein  <mitz@apple.com>
1972
1973         Reviewed by Simon Fraser.
1974
1975         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
1976         below FrameView::layout
1977         https://bugs.webkit.org/show_bug.cgi?id=31093
1978
1979         Test: fast/block/positioning/relative-positioned-inline-container.html
1980
1981         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
1982         to mark the object for layout, doing so without marking its ancestors.
1983         However, RenderBlock::skipLeadingWhitespace and
1984         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
1985         positioned inline container, causing it to be marked for layout without
1986         ever going back to give it layout, and thus layout could end with a
1987         dirty object still in the tree, leading to all sorts of badness.
1988
1989         The fix is to revert setStaticY() to not marking the object dirty, and
1990         instead do it in the call sites that require it, which are in
1991         RenderBlock and RenderFlexibleBox.
1992
1993         * rendering/RenderBlock.cpp:
1994         (WebCore::RenderBlock::adjustPositionedBlock):
1995         * rendering/RenderFlexibleBox.cpp:
1996         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1997         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1998         * rendering/RenderLayer.cpp:
1999         * rendering/RenderLayer.h:
2000         (WebCore::RenderLayer::setStaticY):
2001
2002 2009-11-07  Daniel Bates  <dbates@webkit.org>
2003
2004         Reviewed by Darin Adler.
2005
2006         https://bugs.webkit.org/show_bug.cgi?id=20780
2007         
2008         Fixes an issue where the onchange event handler is not fired when the 
2009         input field is autocompleted.
2010         
2011         We cannot test this using DRT since DRT cannot emulate autocompletion.
2012         So, a manual-test is included.
2013
2014         Tests: manual-tests/autocompletion-fire-onchange.html
2015
2016         * manual-tests/autocompletion-fire-onchange.html: Added.
2017         * rendering/RenderTextControl.cpp:
2018         (WebCore::RenderTextControl::setInnerTextValue):
2019
2020 2009-11-07  Benjamin Otte  <otte@gnome.org>
2021
2022         Reviewed by Holger Freyther.
2023
2024         Mark redrawn areas on image surfaces as dirty.
2025
2026         This is required to conform to the Cairo API, but is currently only
2027         used by debugging tools like cairo-trace.
2028
2029         * platform/graphics/cairo/ImageBufferCairo.cpp:
2030         (WebCore::ImageBuffer::platformTransformColorSpace):
2031         (WebCore::putImageData):
2032
2033 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2034
2035         Reviewed by Xan Lopez.
2036
2037         https://bugs.webkit.org/show_bug.cgi?id=30878
2038         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2039
2040         If the end_offset is -1, use the String length as the end_offset.
2041
2042         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2043         (webkit_accessible_text_get_text):
2044
2045 2009-11-06  Beth Dakin  <bdakin@apple.com>
2046
2047         Reviewed by Adele Peterson.
2048
2049         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2050         GraphicsContext's current concept of ColorSpace
2051
2052         ColorSpace is now called ColorType. The variables on the state we 
2053         appropriately re-named as well. I removed strokeColorSpace() and 
2054         fillColorSpace() from GraphicsContext since they were never called. 
2055
2056         * platform/graphics/GraphicsContext.cpp:
2057         (WebCore::GraphicsContext::setStrokeColor):
2058         (WebCore::GraphicsContext::setFillColor):
2059         (WebCore::GraphicsContext::setStrokePattern):
2060         (WebCore::GraphicsContext::setFillPattern):
2061         (WebCore::GraphicsContext::setStrokeGradient):
2062         (WebCore::GraphicsContext::setFillGradient):
2063         * platform/graphics/GraphicsContext.h:
2064         (WebCore::):
2065         * platform/graphics/GraphicsContextPrivate.h:
2066         (WebCore::GraphicsContextState::GraphicsContextState):
2067         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2068         (WebCore::GraphicsContext::fillPath):
2069         (WebCore::GraphicsContext::strokePath):
2070         * platform/graphics/cg/GraphicsContextCG.cpp:
2071         (WebCore::calculateDrawingMode):
2072         (WebCore::GraphicsContext::drawPath):
2073         (WebCore::GraphicsContext::fillPath):
2074         (WebCore::GraphicsContext::strokePath):
2075         (WebCore::GraphicsContext::fillRect):
2076         (WebCore::GraphicsContext::strokeRect):
2077         * platform/graphics/qt/GraphicsContextQt.cpp:
2078         (WebCore::GraphicsContext::fillPath):
2079         (WebCore::GraphicsContext::strokePath):
2080         (WebCore::GraphicsContext::fillRect):
2081         * platform/graphics/wince/GraphicsContextWince.cpp:
2082         (WebCore::GraphicsContext::fillPath):
2083         (WebCore::GraphicsContext::fillRect):
2084
2085 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2086
2087         Reviewed by Tim Hatcher.
2088
2089         Fixes <http://webkit.org/b/31177>.
2090         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2091         
2092         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2093         places in the inspector can use editing in DataGrid (added a FIXME for
2094         some stuff that needs to be generalized).
2095         
2096         Also added deleting functionality to DataGrid, and implemented it for
2097         Cookies and DOM Storage. The reason this patch is so big is because of
2098         the refactoring of editing code, which won't be used yet in a cross-datagrid
2099         way, but should be able to.
2100         
2101         Additionally, moved the callbacks members from DOMStorageDataGrid to
2102         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2103         make the architecture of DOM Storage look a lot more like the Cookies view.
2104         
2105         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2106         inspector from beeping at you when you delete an element.
2107
2108         * WebCore.gypi: Removed DOMStorageDataGrid.
2109         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2110         * inspector/front-end/CookieItemsView.js:
2111         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2112         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2113         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2114         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2115         * inspector/front-end/DOMStorageItemsView.js:
2116         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2117         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2118         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2119         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2120         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2121         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2122         * inspector/front-end/DataGrid.js:
2123         (WebInspector.DataGrid):
2124         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2125         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2126         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2127         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2128         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2129         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2130         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2131         * inspector/front-end/ElementsTreeOutline.js:
2132         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2133         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2134         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2135
2136 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2137
2138         Qt build fix: added an ExecState parameter.
2139
2140         * bridge/qt/qt_runtime.cpp:
2141         (JSC::Bindings::convertValueToQVariant):
2142         (JSC::Bindings::convertQVariantToValue):
2143
2144 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2145
2146         https://bugs.webkit.org/show_bug.cgi?id=31197
2147         Implemented a timezone cache not based on Mac OS X's notify_check API.
2148
2149         Updated for JavaScriptCore internal API change.
2150
2151         * bridge/qt/qt_runtime.cpp:
2152         (JSC::Bindings::convertValueToQVariant):
2153         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2154
2155         * platform/network/HTTPParsers.cpp:
2156         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2157         (This function probably shouldn't be using a JavaScript date parser
2158         to begin with, but oh well.)
2159
2160 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2161
2162         Reviewed by Adam Barth.
2163
2164         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2165         which affects Chromium only.
2166         
2167         Changes to V8HTMLDocumentCustom.cpp are as below:-
2168         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2169            there was no calling javascript context. We now check for this case
2170            and pass in NULL to the HTMLDocument::open function which can handle
2171            a NULL document parameter.
2172         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2173            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2174            anyway. We now check for this case and return a failure.
2175            
2176         Changes to V8DOMWindowCustom.cpp are as below:-
2177         1. Instead of failing the window.open call made by NPAPI for lack of a
2178            calling javascript context, we now use the entered context as the calling
2179            context.
2180
2181         Tests: plugins/document-open.html
2182                plugins/window-open.html
2183
2184         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2185         (WebCore::CALLBACK_FUNC_DECL):
2186         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2187         (WebCore::CALLBACK_FUNC_DECL):
2188
2189 2009-11-06  Steve Block  <steveblock@google.com>
2190
2191         Reviewed by Eric Seidel.
2192
2193         Geolocation error code UNKNOWN_ERROR is deprecated.
2194         https://bugs.webkit.org/show_bug.cgi?id=31184
2195
2196         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2197
2198         Updated fast/dom/Geolocation/error.html to test this.
2199
2200         * page/PositionError.h: Modified.
2201         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2202         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2203         * page/Geolocation.cpp: Modified.
2204         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2205         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2206         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2207
2208 2009-11-06  Dirk Schulze  <krit@webkit.org>
2209
2210         Reviewed by Nikolas Zimmermann.
2211
2212         feMorphology filter is not implemented
2213         [https://bugs.webkit.org/show_bug.cgi?id=5863]
2214
2215         The Implementation of feMorphology.
2216         
2217         Test: We have allready a test for feMorphology
2218               svg/W3C-SVG-1.1/filters-morph-01-f.svg
2219
2220         * svg/graphics/filters/SVGFEMorphology.cpp:
2221         (WebCore::FEMorphology::apply):
2222
2223 2009-11-06  Steve Block  <steveblock@google.com>
2224
2225         Reviewed by Eric Seidel.
2226
2227         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
2228         https://bugs.webkit.org/show_bug.cgi?id=31209
2229
2230         Build fix only. No new tests possible.
2231
2232         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
2233
2234 2009-11-06  Drew Wilson  <atwilson@chromium.org>
2235
2236         Reviewed by David Levin.
2237
2238         V8 bindings do not support SharedWorkers as event targets
2239         https://bugs.webkit.org/show_bug.cgi?id=31199
2240
2241         No new tests because existing layout tests suffice (they currently
2242         crash on Chromium)
2243
2244         * bindings/v8/V8DOMWrapper.cpp:
2245         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
2246         Added clause to create a DOM wrapper for SharedWorkers.
2247
2248 2009-11-06  Anton Muhin  <antonm@chromium.org>
2249
2250         Reviewed by Adam Barth.
2251
2252         Do not unnecessarly synchronzie in weak reference callbacks.
2253         https://bugs.webkit.org/show_bug.cgi?id=31191
2254
2255         * bindings/v8/DOMData.h:
2256         (WebCore::DOMData::handleWeakObject):
2257
2258 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
2259
2260         Reviewed by Pavel Feldman.
2261
2262         Fix resource content search.
2263         https://bugs.webkit.org/show_bug.cgi?id=31202
2264
2265         * inspector/front-end/AbstractTimelinePanel.js:
2266         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2267         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2268         * inspector/front-end/TimelinePanel.js:
2269         (WebInspector.TimelineGraph.prototype.refresh):
2270
2271 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
2272
2273         Reviewed by Eric Seidel.
2274
2275         Fix ASSERT(currentStyle = renderStyle()).
2276         https://bugs.webkit.org/show_bug.cgi?id=31152
2277
2278         * dom/Element.cpp:
2279         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
2280
2281 2009-11-05  Alpha Lam  <hclam@chromium.org>
2282
2283         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
2284
2285         * bindings/v8/V8GCController.cpp:
2286         (WebCore::V8GCController::gcEpilogue):
2287         * bindings/v8/V8GCController.h:
2288         * bindings/v8/V8Proxy.cpp:
2289         (WebCore::V8Proxy::evaluate):
2290         (WebCore::V8Proxy::runScript):
2291         (WebCore::V8Proxy::callFunction):
2292
2293 2009-11-05  Adam Barth  <abarth@webkit.org>
2294
2295         Reviewed by Sam Weinig.
2296
2297         Cross-domain access to stylesheet text should not be allowed
2298         https://bugs.webkit.org/show_bug.cgi?id=20527
2299
2300         Check whether whether the current document can read the cssRules from
2301         the style sheet.  Firefox throws a security error here, but we return
2302         null instead because that's what we usually do in these cases.
2303
2304         Test: http/tests/security/cannot-read-cssrules-redirect.html
2305               http/tests/security/cannot-read-cssrules.html
2306
2307         * css/CSSStyleSheet.cpp:
2308         (WebCore::CSSStyleSheet::cssRules):
2309
2310 2009-11-05  Steve Block  <steveblock@google.com>
2311
2312         Reviewed by Eric Seidel.
2313
2314         If the Geolocation service fails to start, invoke the error callback asynchronously.
2315         https://bugs.webkit.org/show_bug.cgi?id=28276
2316
2317         All Geolocation callbacks must be invoked asynchronously.
2318         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
2319
2320         No new tests possible with current LayoutTestController.
2321
2322         * page/Geolocation.cpp:
2323         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
2324         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
2325         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
2326
2327 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2328
2329         Reviewed by Eric Seidel.
2330
2331         Removed the "this is part of the KDE project" comments from 
2332         all *.h, *.cpp, *.idl, and *.pm files.
2333         
2334         https://bugs.webkit.org/show_bug.cgi?id=31167
2335         
2336         The maintenance and architecture page in the project wiki lists
2337         this as a task.
2338         
2339         This change includes no changes or additions to test cases 
2340         since the change affects only comments.
2341
2342         * bindings/scripts/CodeGeneratorV8.pm:
2343         * bindings/scripts/IDLParser.pm:
2344         * bindings/scripts/IDLStructure.pm:
2345         * css/CSSInheritedValue.cpp:
2346         * css/CSSInitialValue.cpp:
2347         * css/CSSMediaRule.cpp:
2348         * css/CSSNamespace.h:
2349         * css/CSSProperty.cpp:
2350         * css/CSSProperty.h:
2351         * css/CSSRuleList.cpp:
2352         * css/CSSRuleList.h:
2353         * css/CSSSelector.h:
2354         * css/CSSValueList.cpp:
2355         * css/FontValue.cpp:
2356         * css/MediaFeatureNames.cpp:
2357         * css/MediaFeatureNames.h:
2358         * css/Pair.h:
2359         * css/SVGCSSStyleSelector.cpp:
2360         * css/ShadowValue.cpp:
2361         * css/StyleSheet.cpp:
2362         * css/StyleSheetList.cpp:
2363         * css/maketokenizer:
2364         * dom/BeforeUnloadEvent.cpp:
2365         * dom/BeforeUnloadEvent.h:
2366         * dom/CSSMappedAttributeDeclaration.cpp:
2367         * dom/EventNames.cpp:
2368         * dom/EventTarget.cpp:
2369         * dom/MappedAttributeEntry.h:
2370         * dom/MouseRelatedEvent.h:
2371         * dom/RangeException.h:
2372         * dom/StyleElement.h:
2373         * dom/Tokenizer.h:
2374         * html/HTMLHeadElement.h:
2375         * html/HTMLHeadingElement.cpp:
2376         * html/HTMLHeadingElement.h:
2377         * html/HTMLHtmlElement.h:
2378         * html/HTMLImageLoader.h:
2379         * html/HTMLMetaElement.h:
2380         * html/HTMLModElement.cpp:
2381         * html/HTMLModElement.h:
2382         * html/HTMLOptionsCollection.cpp:
2383         * html/HTMLPlugInElement.cpp:
2384         * html/HTMLPreElement.cpp:
2385         * html/HTMLPreElement.h:
2386         * html/HTMLTableCellElement.cpp:
2387         * html/HTMLTableCellElement.h:
2388         * html/HTMLTableColElement.cpp:
2389         * html/HTMLTableColElement.h:
2390         * html/HTMLTablePartElement.cpp:
2391         * html/HTMLTablePartElement.h:
2392         * html/HTMLTitleElement.h:
2393         * page/MouseEventWithHitTestResults.h:
2394         * platform/StaticConstructors.h:
2395         * platform/text/AtomicStringImpl.h:
2396         * platform/text/qt/TextBreakIteratorQt.cpp:
2397         * rendering/AutoTableLayout.h:
2398         * rendering/CounterNode.cpp:
2399         * rendering/EllipsisBox.cpp:
2400         * rendering/EllipsisBox.h:
2401         * rendering/FixedTableLayout.cpp:
2402         * rendering/FixedTableLayout.h:
2403         * rendering/HitTestRequest.h:
2404         * rendering/HitTestResult.h:
2405         * rendering/InlineRunBox.h:
2406         * rendering/PointerEventsHitRules.cpp:
2407         * rendering/PointerEventsHitRules.h:
2408         * rendering/RenderBR.cpp:
2409         * rendering/RenderBR.h:
2410         * rendering/RenderButton.cpp:
2411         * rendering/RenderButton.h:
2412         * rendering/RenderFieldset.cpp:
2413         * rendering/RenderFrameSet.cpp:
2414         * rendering/RenderListItem.cpp:
2415         * rendering/RenderTableRow.cpp:
2416         * rendering/RenderView.h:
2417         * rendering/RootInlineBox.h:
2418         * rendering/SVGInlineTextBox.cpp:
2419         * rendering/SVGInlineTextBox.h:
2420         * rendering/TableLayout.h:
2421         * rendering/break_lines.h:
2422         * rendering/style/SVGRenderStyle.cpp:
2423         * rendering/style/SVGRenderStyle.h:
2424         * rendering/style/SVGRenderStyleDefs.cpp:
2425         * rendering/style/SVGRenderStyleDefs.h:
2426         * svg/GradientAttributes.h:
2427         * svg/LinearGradientAttributes.h:
2428         * svg/PatternAttributes.h:
2429         * svg/RadialGradientAttributes.h:
2430         * svg/SVGAElement.cpp:
2431         * svg/SVGAngle.idl:
2432         * svg/SVGAnimateColorElement.cpp:
2433         * svg/SVGAnimateColorElement.h:
2434         * svg/SVGAnimateElement.cpp:
2435         * svg/SVGAnimateElement.h:
2436         * svg/SVGAnimateTransformElement.h:
2437         * svg/SVGAnimatedPathData.cpp:
2438         * svg/SVGAnimatedPathData.h:
2439         * svg/SVGAnimatedPoints.cpp:
2440         * svg/SVGAnimatedPoints.h:
2441         * svg/SVGAnimationElement.cpp:
2442         * svg/SVGCircleElement.cpp:
2443         * svg/SVGClipPathElement.cpp:
2444         * svg/SVGColor.cpp:
2445         * svg/SVGColor.idl:
2446         * svg/SVGComponentTransferFunctionElement.cpp:
2447         * svg/SVGComponentTransferFunctionElement.h:
2448         * svg/SVGCursorElement.cpp:
2449         * svg/SVGDefsElement.cpp:
2450         * svg/SVGDescElement.cpp:
2451         * svg/SVGDescElement.h:
2452         * svg/SVGDocument.idl:
2453         * svg/SVGElement.idl:
2454         * svg/SVGElementInstanceList.cpp:
2455         * svg/SVGElementInstanceList.h:
2456         * svg/SVGEllipseElement.cpp:
2457         * svg/SVGExternalResourcesRequired.cpp:
2458         * svg/SVGFEBlendElement.cpp:
2459         * svg/SVGFEBlendElement.h:
2460         * svg/SVGFEColorMatrixElement.cpp:
2461         * svg/SVGFEColorMatrixElement.h:
2462         * svg/SVGFEComponentTransferElement.cpp:
2463         * svg/SVGFEComponentTransferElement.h:
2464         * svg/SVGFECompositeElement.cpp:
2465         * svg/SVGFECompositeElement.h:
2466         * svg/SVGFEFloodElement.cpp:
2467         * svg/SVGFEFloodElement.h:
2468         * svg/SVGFEFuncAElement.cpp:
2469         * svg/SVGFEFuncAElement.h:
2470         * svg/SVGFEFuncBElement.cpp:
2471         * svg/SVGFEFuncBElement.h:
2472         * svg/SVGFEFuncGElement.cpp:
2473         * svg/SVGFEFuncGElement.h:
2474         * svg/SVGFEFuncRElement.cpp:
2475         * svg/SVGFEFuncRElement.h:
2476         * svg/SVGFEGaussianBlurElement.cpp:
2477         * svg/SVGFEGaussianBlurElement.h:
2478         * svg/SVGFEImageElement.cpp:
2479         * svg/SVGFEMergeElement.cpp:
2480         * svg/SVGFEMergeElement.h:
2481         * svg/SVGFEMergeNodeElement.cpp:
2482         * svg/SVGFEOffsetElement.cpp:
2483         * svg/SVGFEOffsetElement.h:
2484         * svg/SVGFETileElement.cpp:
2485         * svg/SVGFETileElement.h:
2486         * svg/SVGFETurbulenceElement.cpp:
2487         * svg/SVGFETurbulenceElement.h:
2488         * svg/SVGFilterElement.cpp:
2489         * svg/SVGGElement.cpp:
2490         * svg/SVGGradientElement.cpp:
2491         * svg/SVGHKernElement.idl:
2492         * svg/SVGLangSpace.cpp:
2493         * svg/SVGLangSpace.h:
2494         * svg/SVGLength.cpp:
2495         * svg/SVGLength.h:
2496         * svg/SVGLength.idl:
2497         * svg/SVGLengthList.cpp:
2498         * svg/SVGLengthList.h:
2499         * svg/SVGLineElement.cpp:
2500         * svg/SVGLinearGradientElement.h:
2501         * svg/SVGList.h:
2502         * svg/SVGListTraits.h:
2503         * svg/SVGLocatable.h:
2504         * svg/SVGMaskElement.cpp:
2505         * svg/SVGMatrix.idl:
2506         * svg/SVGMetadataElement.cpp:
2507         * svg/SVGMetadataElement.h:
2508         * svg/SVGMetadataElement.idl:
2509         * svg/SVGNumber.idl:
2510         * svg/SVGNumberList.cpp:
2511         * svg/SVGNumberList.h:
2512         * svg/SVGPaint.cpp:
2513         * svg/SVGPathElement.cpp:
2514         * svg/SVGPathSeg.h:
2515         * svg/SVGPathSegArc.cpp:
2516         * svg/SVGPathSegArc.h:
2517         * svg/SVGPathSegClosePath.cpp:
2518         * svg/SVGPathSegClosePath.h:
2519         * svg/SVGPathSegCurvetoCubic.cpp:
2520         * svg/SVGPathSegCurvetoCubic.h:
2521         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
2522         * svg/SVGPathSegCurvetoCubicSmooth.h:
2523         * svg/SVGPathSegCurvetoQuadratic.cpp:
2524         * svg/SVGPathSegCurvetoQuadratic.h:
2525         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
2526         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
2527         * svg/SVGPathSegLineto.cpp:
2528         * svg/SVGPathSegLineto.h:
2529         * svg/SVGPathSegLinetoHorizontal.cpp:
2530         * svg/SVGPathSegLinetoHorizontal.h:
2531         * svg/SVGPathSegLinetoVertical.cpp:
2532         * svg/SVGPathSegLinetoVertical.h:
2533         * svg/SVGPathSegMoveto.cpp:
2534         * svg/SVGPathSegMoveto.h:
2535         * svg/SVGPatternElement.cpp:
2536         * svg/SVGPoint.idl:
2537         * svg/SVGPointList.cpp:
2538         * svg/SVGPointList.h:
2539         * svg/SVGPolyElement.cpp:
2540         * svg/SVGPolygonElement.cpp:
2541         * svg/SVGPolygonElement.h:
2542         * svg/SVGPolylineElement.cpp:
2543         * svg/SVGPolylineElement.h:
2544         * svg/SVGPreserveAspectRatio.cpp:
2545         * svg/SVGPreserveAspectRatio.h:
2546         * svg/SVGRadialGradientElement.h:
2547         * svg/SVGRect.idl:
2548         * svg/SVGRectElement.cpp:
2549         * svg/SVGRenderingIntent.h:
2550         * svg/SVGSVGElement.idl:
2551         * svg/SVGScriptElement.cpp:
2552         * svg/SVGSetElement.cpp:
2553         * svg/SVGSetElement.h:
2554         * svg/SVGStopElement.cpp:
2555         * svg/SVGStringList.cpp:
2556         * svg/SVGStringList.h:
2557         * svg/SVGStylable.cpp:
2558         * svg/SVGStylable.h:
2559         * svg/SVGStyleElement.cpp:
2560         * svg/SVGStyleElement.h:
2561         * svg/SVGStyledElement.h:
2562         * svg/SVGStyledLocatableElement.cpp:
2563         * svg/SVGStyledLocatableElement.h:
2564         * svg/SVGStyledTransformableElement.cpp:
2565         * svg/SVGStyledTransformableElement.h:
2566         * svg/SVGSwitchElement.cpp:
2567         * svg/SVGSymbolElement.cpp:
2568         * svg/SVGTRefElement.cpp:
2569         * svg/SVGTSpanElement.cpp:
2570         * svg/SVGTSpanElement.h:
2571         * svg/SVGTests.h:
2572         * svg/SVGTextElement.cpp:
2573         * svg/SVGTextElement.h:
2574         * svg/SVGTextPathElement.cpp:
2575         * svg/SVGTextPositioningElement.cpp:
2576         * svg/SVGTextPositioningElement.h:
2577         * svg/SVGTitleElement.cpp:
2578         * svg/SVGTitleElement.h:
2579         * svg/SVGTransform.cpp:
2580         * svg/SVGTransform.h:
2581         * svg/SVGTransform.idl:
2582         * svg/SVGTransformList.cpp:
2583         * svg/SVGTransformList.h:
2584         * svg/SVGTransformable.h:
2585         * svg/SVGURIReference.h:
2586         * svg/SVGUnitTypes.h:
2587         * svg/SVGUseElement.cpp:
2588         * svg/SVGViewElement.cpp:
2589         * svg/SVGZoomAndPan.cpp:
2590         * svg/SVGZoomAndPan.h:
2591         * svg/SVGZoomEvent.cpp:
2592
2593 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
2594
2595         Reviewed by Dimitri Glazkov.
2596
2597         REGRESSION Clean up security origin usage in DOM Storage.
2598         https://bugs.webkit.org/show_bug.cgi?id=31188
2599
2600         Clean up security origin usage in DOM Storage.  This fixes a bug in my
2601         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
2602
2603         Instead of having StorageAreaSync's constructor (which is called in the
2604         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
2605         database identifier, simply have StorageAreaImpl pass the identifier into
2606         StorageAreaSync.
2607
2608         No test because there's no change in externally observable behavior.
2609
2610         * storage/StorageAreaImpl.cpp:
2611         (WebCore::StorageAreaImpl::StorageAreaImpl):
2612         * storage/StorageAreaImpl.h:
2613         * storage/StorageAreaSync.cpp:
2614         (WebCore::StorageAreaSync::create):
2615         (WebCore::StorageAreaSync::StorageAreaSync):
2616         * storage/StorageAreaSync.h:
2617
2618 2009-11-05  Scott Violet  <sky@google.com>
2619
2620         Reviewed by Dimitri Glazkov.
2621
2622         Need notification of scrolling frame
2623         https://bugs.webkit.org/show_bug.cgi?id=31145
2624
2625         Adds FrameLoaderClient::didChangeScrollOffset that is called when
2626         the frame scrolls. This will be used to know when history state
2627         needs to be updated.
2628
2629         * loader/FrameLoaderClient.h:
2630         (WebCore::FrameLoaderClient::didChangeScrollOffset):
2631         * page/FrameView.cpp:
2632         (WebCore::FrameView::valueChanged):
2633
2634 2009-11-05  Kenneth Russell  <kbr@google.com>
2635
2636         Reviewed by Dimitri Glazkov.
2637
2638         [V8] Update bindings to use new API for external arrays
2639         https://bugs.webkit.org/show_bug.cgi?id=31181
2640
2641         No new tests; covered by existing WebGL tests.
2642
2643         * bindings/v8/V8DOMWrapper.cpp:
2644         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2645         (WebCore::V8DOMWrapper::getTemplate):
2646         (WebCore::V8DOMWrapper::convertToV8Object):
2647         * bindings/v8/V8DOMWrapper.h:
2648         * bindings/v8/custom/V8CanvasArrayCustom.h:
2649         (WebCore::constructCanvasArray):
2650
2651 2009-11-05  Alpha Lam  <hclam@chromium.org>
2652
2653         Not reviewed, Chromium build fix.
2654
2655         50561 introduces a custom method for SVGMatrix, we need to implement
2656         this in V8.
2657
2658         * bindings/v8/custom/V8CustomBinding.h:
2659         Adding definition for V8SVGMatrixMultiply.
2660         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
2661         (WebCore::CALLBACK_FUNC_DECL):
2662         Implement V8SVGMatrixMultiply according to the same method in JSC.
2663
2664 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
2665
2666         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
2667
2668         * page/DOMWindow.cpp:
2669         (WebCore::DOMWindow::sessionStorage):
2670         * page/Settings.cpp:
2671         (WebCore::Settings::Settings):
2672         (WebCore::Settings::setSessionStorageEnabled):
2673         * page/Settings.h:
2674         (WebCore::Settings::sessionStorageEnabled):
2675
2676 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
2677
2678         Reviewed by Timothy Hatcher.
2679
2680         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
2681
2682         https://bugs.webkit.org/show_bug.cgi?id=30884
2683
2684         Test: inspector/styles-iframe.html
2685
2686         * inspector/front-end/DOMAgent.js:
2687         (WebInspector.DOMNode):
2688         * inspector/front-end/InjectedScript.js:
2689         (InjectedScript.getStyles):
2690         (InjectedScript.getComputedStyle):
2691         (InjectedScript.addStyleSelector):
2692         * inspector/front-end/TestController.js:
2693         (WebInspector.TestController.prototype.notifyDone):
2694         (WebInspector.TestController.prototype.runAfterPendingDispatches):
2695         (WebInspector.evaluateForTestInFrontend.invokeMethod):
2696         (WebInspector.evaluateForTestInFrontend):
2697
2698 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
2699
2700         Reviewed by Geoffrey Garen and Dimitri Glazkov.
2701
2702         Rehashing of EventListenerMap leads to loss of EvenListenerList.
2703         https://bugs.webkit.org/show_bug.cgi?id=31027
2704
2705         Tested by new fast/events/event-listener-map-rehash-crash.html.
2706
2707         EventListenerMap modified to store pointers to listener vectors:
2708         * dom/EventTarget.cpp:
2709         (WebCore::EventTargetData::~EventTargetData):
2710         (WebCore::EventTarget::addEventListener):
2711         (WebCore::EventTarget::removeEventListener):
2712         (WebCore::EventTarget::fireEventListeners):
2713         (WebCore::EventTarget::getEventListeners):
2714         (WebCore::EventTarget::removeAllEventListeners):
2715         * dom/EventTarget.h:
2716
2717         Usages updated after interface changes:
2718         * inspector/InspectorDOMAgent.cpp:
2719         (WebCore::InspectorDOMAgent::getEventListenersForNode):
2720         * svg/SVGUseElement.cpp:
2721         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
2722
2723 2009-11-05  Dan Kegel  <dank@chromium.org>
2724
2725         Reviewed by Dmitri Titov.
2726
2727         Add missing initialization for m_createdByParser.
2728         https://bugs.webkit.org/show_bug.cgi?id=31089
2729
2730         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
2731
2732         * dom/ProcessingInstruction.cpp:
2733         (WebCore::ProcessingInstruction::ProcessingInstruction):
2734
2735 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2736
2737         Reviewed by Adam Barth.
2738
2739         DOM Storage runtime flag changes
2740         https://bugs.webkit.org/show_bug.cgi?id=30602
2741
2742         Part 2/2.
2743
2744         Revert my changes to Settings and instead implement DOM Storage enabling via
2745         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
2746
2747         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
2748         LayoutTest visible changes and thus no tests.
2749
2750         * bindings/v8/custom/V8CustomBinding.h:
2751         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2752         (WebCore::ACCESSOR_RUNTIME_ENABLER):
2753         * page/DOMWindow.cpp:
2754         (WebCore::DOMWindow::sessionStorage):
2755         * page/DOMWindow.idl:
2756         * page/Settings.cpp:
2757         (WebCore::Settings::Settings):
2758         * page/Settings.h:
2759         * storage/Storage.cpp:
2760         (WebCore::Storage::setLocalStorageAvailable):
2761         (WebCore::Storage::localStorageAvailable):
2762         (WebCore::Storage::setSessionStorageAvailable):
2763         (WebCore::Storage::sessionStorageAvailable):
2764         * storage/Storage.h:
2765
2766 2009-11-05  Jian Li  <jianli@chromium.org>
2767
2768         Reviewed by Pavel Feldman.
2769
2770         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
2771         https://bugs.webkit.org/show_bug.cgi?id=31108
2772
2773         * bindings/v8/V8AbstractEventListener.cpp:
2774         (WebCore::V8AbstractEventListener::invokeEventHandler):
2775         * bindings/v8/V8Utilities.cpp:
2776         (WebCore::reportException):
2777
2778 2009-11-05  Jian Li  <jianli@chromium.org>
2779
2780         Reviewed by Dmitri Titov.
2781
2782         We should not bubble up events if we drag something to an iframe that
2783         has an invalid source.
2784         https://bugs.webkit.org/show_bug.cgi?id=30469
2785
2786         Test: http/tests/misc/bubble-drag-events.html
2787
2788         * page/EventHandler.cpp:
2789         (WebCore::EventHandler::handleDragAndDropForTarget):
2790         (WebCore::EventHandler::updateDragAndDrop):
2791         (WebCore::EventHandler::cancelDragAndDrop):
2792         (WebCore::EventHandler::performDragAndDrop):
2793         * page/EventHandler.h:
2794         (WebCore::EventHandler::):
2795
2796 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
2797
2798         Reviewed by Timothy Hatcher.
2799
2800         Web Inspector: speed up Timelines Clear by a factor of thousands.
2801
2802         https://bugs.webkit.org/show_bug.cgi?id=31160
2803
2804         * inspector/front-end/utilities.js:
2805         (Element.prototype.removeChildren):
2806
2807 2009-11-05  Anton Muhin  <antonm@chromium.org>
2808
2809         Reviewed by Adam Barth.
2810
2811         If high memory usage is detected, hint to V8 that it might be due
2812         to external objects retained by V8 objects.
2813         https://bugs.webkit.org/show_bug.cgi?id=31051
2814
2815         * bindings/v8/V8GCController.cpp:
2816         (WebCore::GetMemoryUsageInMB):
2817         (WebCore::V8GCController::gcEpilogue):
2818         (WebCore::V8GCController::checkMemoryUsage):
2819         * bindings/v8/V8GCController.h:
2820         * bindings/v8/V8Proxy.cpp:
2821         (WebCore::V8Proxy::evaluate):
2822         (WebCore::V8Proxy::runScript):
2823         (WebCore::V8Proxy::callFunction):
2824
2825 2009-11-05  Jeff Schiller  <codedread@gmail.com>
2826
2827         Reviewed by Simon Fraser.
2828
2829         Correct order of matrix multiplication for SVGMatrix.
2830         https://bugs.webkit.org/show_bug.cgi?id=16062
2831
2832         Test: svg/dom/SVGMatrix-interface.xhtml
2833
2834         * bindings/js/JSSVGMatrixCustom.cpp:
2835         (WebCore::JSSVGMatrix::multiply):
2836         * svg/SVGMatrix.idl:
2837
2838 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
2839
2840         Reviewed by Timothy Hatcher.
2841
2842         Web Inspector: Make resource-related records in timeline
2843         actually take some time.
2844
2845         https://bugs.webkit.org/show_bug.cgi?id=31139
2846
2847         * English.lproj/localizedStrings.js:
2848         * inspector/front-end/TimelinePanel.js:
2849         (WebInspector.TimelinePanel):
2850         (WebInspector.TimelinePanel.prototype._formatRecord):
2851         (WebInspector.TimelinePanel.prototype._getRecordDetails):
2852         (WebInspector.TimelinePanel.prototype.reset):
2853
2854 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2855
2856         Reviewed by Darin Fisher.
2857
2858         Simplify LocalStorageThread
2859         https://bugs.webkit.org/show_bug.cgi?id=30935
2860
2861         This is a re-submit of 50519.  LocalStorageTask should have never been ref
2862         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
2863
2864         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
2865         of the method names a bit more clear. Assert proper thread usage. Join rather
2866         than detaching the thread and doing an ad-hoc form of join. Avoid touching
2867         variables on the background thread when simple to do so.  Also create a generic
2868         scheduleTask function rather than one for each task.
2869
2870         No behavior should have changed.
2871
2872         * storage/LocalStorageTask.h:
2873         * storage/LocalStorageThread.cpp:
2874         (WebCore::LocalStorageThread::create):
2875         (WebCore::LocalStorageThread::LocalStorageThread):
2876         (WebCore::LocalStorageThread::~LocalStorageThread):
2877         (WebCore::LocalStorageThread::start):
2878         (WebCore::LocalStorageThread::threadEntryPointCallback):
2879         (WebCore::LocalStorageThread::threadEntryPoint):
2880         (WebCore::LocalStorageThread::scheduleTask):
2881         (WebCore::LocalStorageThread::terminate):
2882         (WebCore::LocalStorageThread::performTerminate):
2883         * storage/LocalStorageThread.h:
2884         * storage/StorageSyncManager.cpp:
2885         (WebCore::StorageSyncManager::StorageSyncManager):
2886         (WebCore::StorageSyncManager::~StorageSyncManager):
2887         (WebCore::StorageSyncManager::scheduleImport):
2888         (WebCore::StorageSyncManager::scheduleSync):
2889         * storage/StorageSyncManager.h:
2890
2891 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
2892
2893         Reviewed by Darin Fisher.
2894
2895         Calling databaseIdentifier on LocalStorage's background thread is not safe.
2896         https://bugs.webkit.org/show_bug.cgi?id=31149
2897
2898         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
2899         is not safe.  databaseIdentifier does a bunch of string concatenation which
2900         ref-counts StringImpls in some cases.  This was caught by valgrind thread
2901         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
2902
2903         There's no way to test for such racyness, unfortunately.
2904
2905         * storage/StorageAreaSync.cpp:
2906         (WebCore::StorageAreaSync::StorageAreaSync):
2907         (WebCore::StorageAreaSync::performImport):
2908         * storage/StorageAreaSync.h:
2909         * storage/StorageSyncManager.cpp:
2910         (WebCore::StorageSyncManager::fullDatabaseFilename):
2911         * storage/StorageSyncManager.h:
2912
2913 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
2914
2915         Reviewed by Darin Fisher.
2916
2917         Clean up StorageAreaSync
2918         https://bugs.webkit.org/show_bug.cgi?id=31100
2919
2920         Major fixes: Break the ref count cycle for StorageArea on the main
2921         thread, not the background thread since the latter is not safe.
2922         Length() needs to block on the import completing.
2923
2924         Small fixes: setItem needs to handle the copy on write case even if it
2925         has an exception.  setItem and removeItem should just bail from the
2926         the function if the value hasn't changed rather than wrapping the end
2927         in an if block.  Clear should only send an event if it wasn't already
2928         cleared.  StorageAreaSync should assert that the final sync was
2929         scheduled.
2930
2931         * storage/StorageAreaImpl.cpp:
2932         (WebCore::StorageAreaImpl::length):
2933           Forgot to block on the import.
2934         (WebCore::StorageAreaImpl::key):
2935         (WebCore::StorageAreaImpl::setItem):
2936           Handle the copy on write case even when there's an exception.
2937         (WebCore::StorageAreaImpl::removeItem):
2938         (WebCore::StorageAreaImpl::clear):
2939         * storage/StorageAreaSync.cpp:
2940         (WebCore::StorageAreaSync::~StorageAreaSync):
2941         (WebCore::StorageAreaSync::scheduleFinalSync):
2942         (WebCore::StorageAreaSync::performImport):
2943         (WebCore::StorageAreaSync::markImported):
2944         (WebCore::StorageAreaSync::blockUntilImportComplete):
2945         * storage/StorageAreaSync.h:
2946
2947 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
2948
2949         Reviewed by Eric Seidel.
2950
2951         Allow custom memory allocation control for WebCore's CachedResource
2952         https://bugs.webkit.org/show_bug.cgi?id=31114
2953
2954         Inherits CachedResource class from Noncopyable because its (its child
2955         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
2956         and it is no need to be copyable.
2957
2958         * loader/CachedResource.h:
2959
2960 2009-11-04  Mark Mentovai  <mark@chromium.org>
2961
2962         Reviewed by Mark Rowe.
2963
2964         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
2965         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
2966         which is true when targeting 10.6 or later.
2967
2968         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
2969         is present in the CGInterpolationQuality enum, and must be handled
2970         by a switch that has cases for each enumerated value.
2971
2972         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
2973         on 10.6 or later, and that CoreGraphics will understand when
2974         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
2975
2976         * platform/graphics/cg/GraphicsContextCG.cpp:
2977         (WebCore::GraphicsContext::setImageInterpolationQuality):
2978         (WebCore::GraphicsContext::imageInterpolationQuality):
2979
2980 2009-11-04  Dan Kegel  <dank@chromium.org>
2981
2982         Reviewed by Alexey Proskuryakov.
2983
2984         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
2985         https://bugs.webkit.org/show_bug.cgi?id=31138
2986
2987         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
2988
2989         * page/Page.cpp:
2990         (WebCore::Page::userStyleSheetLocationChanged):
2991
2992 2009-11-04  Timothy Hatcher  <timothy@apple.com>
2993
2994         Update the Web Inspector Timeline panel to better match the mock-up.
2995
2996         https://bugs.webkit.org/show_bug.cgi?id=31150
2997
2998         Reviewed by Pavel Feldman.
2999
3000         * inspector/front-end/TimelinePanel.js:
3001         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3002         (WebInspector.TimelinePanel.prototype._dragWindow):
3003         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3004         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3005         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3006         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3007         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3008         (WebInspector.TimelineCategoryGraph):
3009         * inspector/front-end/inspector.css:
3010
3011 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
3012
3013         Reviewed by Adele Peterson.
3014
3015         https://bugs.webkit.org/show_bug.cgi?id=25439
3016         Deleting when in front of a block image removes character from previous paragraph
3017
3018         Added editing/deleting/25439-{1,2,3}.html
3019
3020         * editing/DeleteSelectionCommand.cpp:
3021         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot 
3022         be made inline with other content.  Instead of merging, just move the caret to just before 
3023         the selection we deleted.
3024         * editing/htmlediting.cpp:
3025         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which 
3026         doesn't necessarily contain pos (suppose pos was [img, 0]).
3027         (WebCore::lastInSpecialElement): Ditto.
3028         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
3029         * editing/htmlediting.h:
3030         * editing/visible_units.cpp:
3031         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing 
3032         5027702 is now squarely in first/lastInSpecialElement
3033         (WebCore::endOfParagraph): Ditto.
3034         
3035 2009-11-04  Enrica Casucci  <enrica@apple.com>
3036
3037         Reviewed by Adele Peterson.
3038
3039         Hang in Mail on attempting to change indent level.
3040         <rdar://problem/7131805>
3041         https://bugs.webkit.org/show_bug.cgi?id=31127
3042
3043         The hang was caused by an infinite loop inside outdentRegion.
3044         The code did not account for the fact that, when a list item
3045         contains multiple paragraphs, outdent moves all paragraphs at
3046         once, invalidating some of the positions we keep track of in the loop.
3047         Some code refactoring has also been done to minimize duplicated code.
3048         
3049         Test: editing/execCommand/outdent-multiparagraph-list.html
3050
3051         * editing/IndentOutdentCommand.cpp:
3052         (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
3053         outdentRegion to doApply.
3054         (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
3055         (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
3056         * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
3057         indentRegion and outdentRegion.
3058
3059 2009-11-04  Alpha Lam  <hclam@chromium.org>
3060
3061         Reviewed by Eric Carlson.
3062
3063         Volume slider doesn't have a thumb
3064         https://bugs.webkit.org/show_bug.cgi?id=31135
3065
3066         Fixed an incorrect if statement that prevents volume slider
3067         being updated.
3068
3069         The statement checks if the slider value equals to the current
3070         volume value of the media control to avoid updating the volume
3071         slider. Updating the volume slider control shouldn't be within
3072         this condition because we explicitly set them to be equals
3073         during creation of the controls and also when mouse events are
3074         received on the volume control.
3075
3076         No new tests because existing code breaks:
3077         LayoutTests/media/video-volume-slider.html
3078
3079         It should now start passing on Chromium.
3080
3081         * rendering/MediaControlElements.cpp:
3082         (WebCore::MediaControlVolumeSliderElement::update):
3083         Update the volume slider regardless of the current volume value
3084         of the media control.
3085
3086 2009-11-04  Jenn Braithwaite  <jennb@chromium.org>
3087
3088         Reviewed by David Levin.
3089
3090         Need to properly disable applicationCache at runtime
3091         https://bugs.webkit.org/show_bug.cgi?id=30417
3092
3093         Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
3094
3095         No new exposed functionality, so no new tests.
3096
3097         * bindings/v8/RuntimeEnabledFeatures.cpp:
3098         * bindings/v8/RuntimeEnabledFeatures.h:
3099         (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
3100         (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
3101         * bindings/v8/custom/V8CustomBinding.h:
3102         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3103         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3104         * page/DOMWindow.idl:
3105
3106 2009-11-04  Alexey Proskuryakov  <ap@apple.com>
3107
3108         Reviewed by Dan Bernstein.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=31143
3111         Assertion failure in CredentialStorage::set() when proxy credentials are being set
3112
3113         No test, cannot test proxy behavior.
3114
3115         * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
3116         possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
3117         add "://" to origin set, which is weird, but safe.
3118
3119 2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3120
3121         Reviewed by Timothy Hatcher.
3122
3123         Web Inspector: Leftover Breakpoints in the Sidebar Pane
3124         https://bugs.webkit.org/show_bug.cgi?id=30659
3125
3126         No new tests.
3127
3128         * inspector/front-end/ScriptsPanel.js:
3129         (WebInspector.ScriptsPanel.prototype.addScript):
3130
3131 2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3132
3133         Reviewed by Timothy Hatcher.
3134
3135         WebInspector: Use a different method to identify the webkit port in
3136         InspectorBackent::platform().
3137         This corrects the inspector expected behavior with Qt on Windows.
3138         https://bugs.webkit.org/show_bug.cgi?id=31116
3139
3140         * inspector/InspectorBackend.cpp:
3141         (WebCore::InspectorBackend::platform):
3142         (WebCore::InspectorBackend::port):
3143         * inspector/InspectorBackend.h:
3144         * inspector/InspectorBackend.idl:
3145         * inspector/front-end/InspectorControllerStub.js:
3146         (.WebInspector.InspectorControllerStub.prototype.port):
3147         * inspector/front-end/inspector.css:
3148         * inspector/front-end/inspector.js:
3149         (WebInspector.loaded):
3150         (WebInspector.toolbarDragStart):
3151
3152 2009-11-04  Benjamin Otte  <otte@gnome.org>
3153
3154         Reviewed by Gustavo Noronha.
3155
3156         Update Cairo requirement to 1.6.
3157
3158         Also remove all conditional code and workarounds for older versions of
3159         Cairo.
3160         In particular, gain image quality by removing the use of
3161         CAIRO_FILTER_NEAREST when rendering images and use the default
3162         bilinear filter instead.
3163         https://bugs.webkit.org/show_bug.cgi?id=19266
3164
3165         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3166         (WebCore::GraphicsContext::clipOut):
3167         * platform/graphics/cairo/ImageCairo.cpp:
3168         (WebCore::BitmapImage::draw):
3169         (WebCore::BitmapImage::drawPattern):
3170         * platform/graphics/cairo/PathCairo.cpp:
3171         (WebCore::Path::isEmpty):
3172         (WebCore::Path::boundingRect):
3173         * platform/gtk/RenderThemeGtk.cpp:
3174         (WebCore::paintMozWidget):
3175
3176 2009-11-04  Kevin Ollivier  <kevino@theolliviers.com>
3177
3178         wx build fix. Restore removed string conversion after cleanup.
3179
3180         * platform/graphics/wx/FontPlatformDataWx.cpp:
3181         (WebCore::FontPlatformData::computeHash):
3182
3183 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3184
3185         Reviewed by Beth Dakin.
3186
3187         Need to implement ARIA role="combobox"
3188         https://bugs.webkit.org/show_bug.cgi?id=31096
3189
3190         Test: accessibility/aria-combobox.html
3191
3192         * accessibility/AccessibilityObject.h:
3193         (WebCore::AccessibilityObject::isComboBox):
3194         (WebCore::AccessibilityObject::isExpanded):
3195         (WebCore::AccessibilityObject::expandObject):
3196         (WebCore::AccessibilityObject::increment):
3197         (WebCore::AccessibilityObject::decrement):
3198         * accessibility/AccessibilityRenderObject.cpp:
3199         (WebCore::AccessibilityRenderObject::expandObject):
3200         (WebCore::AccessibilityRenderObject::isExpanded):
3201         (WebCore::createARIARoleMap):
3202         * accessibility/AccessibilityRenderObject.h:
3203         * accessibility/mac/AccessibilityObjectWrapper.mm:
3204         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3205         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3206         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3207         * html/HTMLAttributeNames.in:
3208
3209 2009-11-04  Kelly Norton  <knorton@google.com>
3210
3211         Reviewed by Pavel Feldman.
3212
3213         Fixes naming inconsistencies in TimelineRecordFactory.
3214         https://bugs.webkit.org/show_bug.cgi?id=31132
3215
3216         * inspector/InspectorTimelineAgent.cpp:
3217         (WebCore::InspectorTimelineAgent::willPaint):
3218         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
3219         (WebCore::InspectorTimelineAgent::willLoadXHR):
3220         (WebCore::InspectorTimelineAgent::willEvaluateScript):
3221         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3222         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3223         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3224         * inspector/TimelineRecordFactory.cpp:
3225         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
3226         (WebCore::TimelineRecordFactory::createXHRLoadRecord):
3227         (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
3228         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
3229         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
3230         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
3231         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
3232         (WebCore::TimelineRecordFactory::createPaintRecord):
3233         * inspector/TimelineRecordFactory.h:
3234
3235 2009-11-04  Eric Z. Ayers  <zundel@google.com>
3236
3237         Reviewed by Pavel Feldman.
3238
3239         Followon to bug 31080, which protects Timeline
3240         instrumentation in the case where InspectorTimelineAgent
3241         is enabled or disabled during an event dispatch.
3242         
3243         https://bugs.webkit.org/show_bug.cgi?id=31121
3244
3245         * bindings/v8/V8Proxy.cpp:
3246         (WebCore::V8Proxy::evaluate):
3247         * dom/Document.cpp:
3248         (WebCore::Document::recalcStyle):
3249         * dom/Node.cpp:
3250         (WebCore::Node::dispatchGenericEvent):
3251         * html/HTMLTokenizer.cpp:
3252         (WebCore::HTMLTokenizer::write):
3253         * page/DOMWindow.cpp:
3254         (WebCore::DOMWindow::inspectorTimelineAgent):
3255         (WebCore::DOMWindow::dispatchEvent):
3256         * page/DOMWindow.h:
3257         * page/FrameView.cpp:
3258         (WebCore::FrameView::layout):
3259         (WebCore::FrameView::paintContents):
3260         * xml/XMLHttpRequest.cpp:
3261         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
3262
3263 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3264
3265         Revert 50519 while I work out what went wrong.
3266
3267         * storage/LocalStorageThread.cpp:
3268         (WebCore::LocalStorageThread::create):
3269         (WebCore::LocalStorageThread::LocalStorageThread):
3270         (WebCore::LocalStorageThread::start):
3271         (WebCore::LocalStorageThread::localStorageThreadStart):
3272         (WebCore::LocalStorageThread::localStorageThread):
3273         (WebCore::LocalStorageThread::scheduleImport):
3274         (WebCore::LocalStorageThread::scheduleSync):
3275         (WebCore::LocalStorageThread::terminate):
3276         (WebCore::LocalStorageThread::performTerminate):
3277         * storage/LocalStorageThread.h:
3278         * storage/StorageSyncManager.cpp:
3279         (WebCore::StorageSyncManager::StorageSyncManager):
3280         (WebCore::StorageSyncManager::~StorageSyncManager):
3281         (WebCore::StorageSyncManager::scheduleImport):
3282         (WebCore::StorageSyncManager::scheduleSync):
3283         * storage/StorageSyncManager.h:
3284
3285 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3286
3287         Reviewed by Timothy Hatcher.
3288
3289         Web Inspector: Add basic support for resource events and marks.
3290         Couple of drive-by fixes. Enabling the panel!
3291
3292         https://bugs.webkit.org/show_bug.cgi?id=31130
3293
3294         * English.lproj/localizedStrings.js:
3295         * inspector/front-end/TimelinePanel.js:
3296         (WebInspector.TimelinePanel):
3297         (WebInspector.TimelinePanel.prototype._formatRecord):
3298         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3299         (WebInspector.TimelinePanel.prototype.reset):
3300         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
3301         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3302         * inspector/front-end/inspector.js:
3303         (WebInspector._createPanels):
3304
3305 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3306
3307         Reviewed by Darin Fisher.
3308
3309         Simplify LocalStorageThread
3310         https://bugs.webkit.org/show_bug.cgi?id=30935
3311
3312         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3313         of the method names a bit more clear. Assert proper thread usage. Join rather
3314         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3315         variables on the background thread when simple to do so.  Also create a generic
3316         scheduleTask function rather than one for each task.
3317
3318         No behavior should have changed.
3319
3320         * storage/LocalStorageThread.cpp:
3321         (WebCore::LocalStorageThread::create):
3322         (WebCore::LocalStorageThread::LocalStorageThread):
3323         (WebCore::LocalStorageThread::~LocalStorageThread):
3324         (WebCore::LocalStorageThread::start):
3325         (WebCore::LocalStorageThread::threadEntryPointCallback):
3326         (WebCore::LocalStorageThread::threadEntryPoint):
3327         (WebCore::LocalStorageThread::scheduleTask):
3328         (WebCore::LocalStorageThread::terminate):
3329         (WebCore::LocalStorageThread::performTerminate):
3330         * storage/LocalStorageThread.h:
3331         * storage/StorageSyncManager.cpp:
3332         (WebCore::StorageSyncManager::StorageSyncManager):
3333         (WebCore::StorageSyncManager::~StorageSyncManager):
3334         (WebCore::StorageSyncManager::scheduleImport):
3335         (WebCore::StorageSyncManager::scheduleSync):
3336         * storage/StorageSyncManager.h:
3337
3338 2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>
3339
3340         Reviewed by Eric Seidel.
3341
3342         [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
3343
3344         * platform/graphics/wx/FontPlatformDataWx.cpp:
3345         (WebCore::FontPlatformData::computeHash):
3346
3347 2009-11-04  Kelly Norton  <knorton@google.com>
3348
3349         Reviewed by Pavel Feldman.
3350
3351         Adds lightweight network resources to InspectorTimelineAgent.
3352         https://bugs.webkit.org/show_bug.cgi?id=31065
3353
3354         * inspector/InspectorController.cpp:
3355         (WebCore::InspectorController::willSendRequest):
3356         (WebCore::InspectorController::didReceiveResponse):
3357         (WebCore::InspectorController::didFinishLoading):
3358         (WebCore::InspectorController::didFailLoading):
3359         * inspector/InspectorTimelineAgent.cpp:
3360         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3361         (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
3362         (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
3363         * inspector/InspectorTimelineAgent.h:
3364         (WebCore::):
3365         * inspector/TimelineRecordFactory.cpp:
3366         (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
3367         (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
3368         (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
3369         * inspector/TimelineRecordFactory.h:
3370         * inspector/front-end/TimelineAgent.js:
3371
3372 2009-11-04  Yael Aharon  <yael.aharon@nokia.com>
3373
3374         Reviewed by Tor Arne Vestbø.
3375
3376         [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
3377         https://bugs.webkit.org/show_bug.cgi?id=31077
3378
3379         Allow sending the response body under the same conditions that we
3380         allow it to finish without reporting an error.
3381
3382         * platform/network/qt/QNetworkReplyHandler.cpp:
3383         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3384
3385 2009-11-04  Adam Roben  <aroben@apple.com>
3386
3387         Sort WebCore.base.exp
3388
3389         Rubber-stamped by Dan Bernstein.
3390
3391         * WebCore.base.exp: Sorted.
3392
3393 2009-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3394
3395         Unreviewed rollout.
3396
3397         Revert r50496 because it broke all layout tests on QtBuildBot.
3398
3399         * WebCore.pro:
3400         * platform/graphics/qt/FontCacheQt.cpp:
3401         (WebCore::fontCache):
3402         (WebCore::FontCache::FontCache):
3403         (WebCore::FontCache::getTraitsInFamily):
3404         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
3405         (WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
3406         (WebCore::FontPlatformDataCacheKey::):
3407         (WebCore::FontPlatformDataCacheKey::operator==):
3408         (WebCore::FontPlatformDataCacheKey::hash):
3409         (WebCore::FontPlatformDataCacheKey::computeHash):
3410         (WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
3411         (WebCore::FontPlatformDataCacheKeyHash::hash):
3412         (WebCore::FontPlatformDataCacheKeyHash::equal):
3413         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
3414         (WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
3415         (WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
3416         (WebCore::FontCache::getCachedFontPlatformData):
3417         (WebCore::FontCache::getCachedFontData):
3418         (WebCore::FontCache::getLastResortFallbackFont):
3419         (WebCore::FontCache::releaseFontData):
3420         (WebCore::FontCache::purgeInactiveFontData):
3421         (WebCore::FontCache::addClient):
3422         (WebCore::FontCache::removeClient):
3423         (WebCore::FontCache::invalidate):
3424         * platform/graphics/qt/FontFallbackListQt.cpp: Added.
3425         (WebCore::FontFallbackList::FontFallbackList):
3426         (WebCore::FontFallbackList::invalidate):
3427         (WebCore::FontFallbackList::releaseFontData):
3428         (WebCore::FontFallbackList::determinePitch):
3429         (WebCore::FontFallbackList::fontDataAt):
3430         (WebCore::FontFallbackList::fontDataForCharacters):
3431         (WebCore::FontFallbackList::setPlatformFont):
3432         * platform/graphics/qt/FontPlatformData.h:
3433         (WebCore::FontPlatformData::pixelSize):
3434         * platform/graphics/qt/FontPlatformDataQt.cpp:
3435         (WebCore::FontPlatformData::FontPlatformData):
3436
3437 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3438
3439         Reviewed by Jan Alonzo.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=31044
3442         [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
3443
3444         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3445         (atkParentOfWebView):
3446         (webkit_accessible_get_index_in_parent):
3447         (webkit_accessible_get_parent):
3448
3449 2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>
3450
3451         Reviewed by Eric Seidel.
3452
3453         https://bugs.webkit.org/show_bug.cgi?id=15914
3454         [GTK] Implement Unicode functionality using GLib
3455
3456         Initial version of this patch by Jürg Billeter and Naiem Shaik.
3457         Patch 2/4 - Moving TextCodecs to GLib
3458         
3459         Added probing for a hard-coded lists of text encodings.
3460         The basis of this list is taken from the encodings supported by iconv,
3461         then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
3462         a number of Chinese ones.
3463
3464         Probing is necessary with the current design of text codecs
3465         as iconv/GLib do not support enumerating available encodings.
3466
3467         * GNUmakefile.am:
3468         * platform/ThreadGlobalData.cpp:
3469         (WebCore::ThreadGlobalData::ThreadGlobalData):
3470         (WebCore::ThreadGlobalData::~ThreadGlobalData):
3471         * platform/text/TextEncoding.cpp:
3472         (WebCore::TextEncoding::encode):
3473         * platform/text/TextEncodingRegistry.cpp:
3474         (WebCore::buildBaseTextCodecMaps):
3475         (WebCore::extendTextCodecMaps):
3476         * platform/text/gtk/TextCodecGtk.cpp: Added.
3477         (WebCore::):
3478         (WebCore::newTextCodecGtk):
3479         (WebCore::TextCodecGtk::isEncodingAvailable):
3480         (WebCore::TextCodecGtk::registerEncodingNames):
3481         (WebCore::TextCodecGtk::registerCodecs):
3482         (WebCore::TextCodecGtk::registerBaseEncodingNames):
3483         (WebCore::TextCodecGtk::registerBaseCodecs):
3484         (WebCore::TextCodecGtk::registerExtendedEncodingNames):
3485         (WebCore::TextCodecGtk::registerExtendedCodecs):
3486         (WebCore::TextCodecGtk::TextCodecGtk):
3487         (WebCore::TextCodecGtk::~TextCodecGtk):
3488         (WebCore::TextCodecGtk::releaseIConv):
3489         (WebCore::TextCodecGtk::createIConvDecoder):
3490         (WebCore::TextCodecGtk::createIConvEncoder):
3491         (WebCore::TextCodecGtk::decode):
3492         (WebCore::TextCodecGtk::encode):
3493         * platform/text/gtk/TextCodecGtk.h: Added.
3494
3495 2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>
3496
3497         Reviewed by Jan Alonzo.
3498
3499         [GTK] Enable DOM clipboard and drag-and-drop access
3500         https://bugs.webkit.org/show_bug.cgi?id=30623
3501
3502         Unify redudant methods which will always return the same value.
3503
3504         * platform/gtk/PasteboardGtk.cpp:
3505         (WebCore::Pasteboard::writeSelection):
3506         * platform/gtk/PasteboardHelper.h:
3507
3508 2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3509
3510         Reviewed by Jan Alonzo.
3511
3512         https://bugs.webkit.org/show_bug.cgi?id=31035
3513         [GTK] some accessibility tests hitting assertion in debug builds
3514
3515         Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
3516         Any app or AT can attempt to ref a child at a bogus index.
3517
3518         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3519         (webkit_accessible_ref_child):
3520
3521 2009-11-04  Benjamin Otte  <otte@gnome.org>
3522
3523         Reviewed by Jan Alonzo.
3524
3525         [gtk] Use gst_element_class_set_details_simple()
3526
3527         Cosmetic change, just code simplification
3528
3529         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
3530         (webkit_video_sink_base_init):
3531 2009-11-04  Kelly Norton  <knorton@google.com>
3532
3533         Reviewed by Timothy Hatcher.
3534
3535         Adds paint rectangle information to TimelineAgent's didPaint callback.
3536         https://bugs.webkit.org/show_bug.cgi?id=31087
3537
3538         * inspector/InspectorTimelineAgent.cpp:
3539         (WebCore::InspectorTimelineAgent::willPaint):
3540         * inspector/InspectorTimelineAgent.h:
3541         * inspector/TimelineRecordFactory.cpp:
3542         (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
3543         * inspector/TimelineRecordFactory.h:
3544         * page/FrameView.cpp:
3545         (WebCore::FrameView::paintContents):
3546
3547 2009-11-04  Jaime Yap  <jaimeyap@google.com>
3548
3549         Reviewed by Timothy Hatcher.
3550
3551         This patch adds API to the console object for annotating the
3552         inspector timeline. This allows developers to mark logical
3553         checkpoints in their apps and have them overlaid in the event
3554         record tree.
3555
3556         tests updated: LayoutTests/fast/dom/Window/window-properties.html
3557         https://bugs.webkit.org/show_bug.cgi?id=31082
3558
3559
3560         * inspector/InspectorController.cpp:
3561         (WebCore::InspectorController::markTimeline):
3562         * inspector/InspectorController.h:
3563         * inspector/InspectorTimelineAgent.cpp:
3564         (WebCore::InspectorTimelineAgent::didMarkTimeline):
3565         * inspector/InspectorTimelineAgent.h:
3566         (WebCore::):
3567         * inspector/TimelineRecordFactory.cpp:
3568         (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
3569         * inspector/TimelineRecordFactory.h:
3570         * inspector/front-end/TimelineAgent.js:
3571         * page/Console.cpp:
3572         (WebCore::Console::markTimeline):
3573         * page/Console.h:
3574         * page/Console.idl:
3575
3576 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
3577
3578         Unreviewed build fix for WebInspector with Qt build.
3579
3580         Simply re-generate the Qt resource file by running
3581         WebKitTools/Scripts/generate-qt-inspector-resource
3582
3583         * inspector/front-end/WebKit.qrc:
3584
3585 2009-11-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
3586
3587         Reviewed by Simon Hausmann.
3588
3589         [Qt] Handle fonts like the other ports
3590
3591         Remove FontFallbackListQt and rely on the common FontFallbackList
3592         to handle the fonts. FontCache and FontPlatformData have been
3593         updated to work with the common FontFallbackList.
3594
3595         In the previous implementation, FontPlatformDataCacheKey
3596         was a clone of FontPlatformData with the hashing
3597         capabilities added in order to use it as a key in the cache's
3598         hashmap. FontPlatformData has been modified to handle the hashing
3599         function directly so the data are not copied twice in memory.
3600
3601         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
3602         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
3603         The behavior is similar except currFamily->family().length() was
3604         not tested and the fallback fonts selector were not used.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=29856
3607
3608         Test: svg/text/text-font-invalid.html
3609
3610         * WebCore.pro:
3611         * platform/graphics/qt/FontCacheQt.cpp:
3612         (WebCore::FontCache::platformInit):
3613         (WebCore::FontCache::getFontDataForCharacters):
3614         (WebCore::FontCache::getSimilarFontPlatformData):
3615         (WebCore::FontCache::getLastResortFallbackFont):
3616         (WebCore::FontCache::getTraitsInFamily):
3617         (WebCore::FontCache::createFontPlatformData):
3618         * platform/graphics/qt/FontFallbackListQt.cpp:
3619         Removed. We now use the implementation from FontFallbackList.cpp
3620         * platform/graphics/qt/FontPlatformData.h:
3621         Add hashing capabilities to be able to use the data with the FontCache.
3622         This was previously done in FontCacheQt.cpp
3623         (WebCore::FontPlatformData::FontPlatformData):
3624         Added a boolean to identify deleted value in the hash table.
3625         (WebCore::FontPlatformData::isHashTableDeletedValue):
3626         (WebCore::FontPlatformData::hash):
3627         (WebCore::FontPlatformData::operator==):
3628         * platform/graphics/qt/FontPlatformDataQt.cpp:
3629         (WebCore::FontPlatformData::FontPlatformData):
3630
3631 2009-11-03  Dan Bernstein  <mitz@apple.com>
3632
3633         Leopard build fix
3634
3635         * platform/network/mac/AuthenticationMac.mm:
3636         (WebCore::mac):
3637         (WebCore::core):
3638
3639 2009-11-03  Dan Bernstein  <mitz@apple.com>
3640
3641         Reviewed by Alexey Proskuryakov.
3642
3643         Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
3644         authentication in AuthenticationMac
3645
3646         * platform/network/mac/AuthenticationMac.mm:
3647
3648 2009-11-03  Eric Z. Ayers  <zundel@google.com>
3649
3650         Reviewed by Timothy Hatcher.
3651
3652         Fixes a problem where the timeline instrumentation crashes if
3653         timeline profiling is enabled or disabled in the middle of an
3654         event dispatch.
3655
3656         https://bugs.webkit.org/show_bug.cgi?id=31080
3657
3658         Test: inspector/timeline-trivial.html
3659
3660         * bindings/js/ScriptController.cpp:
3661         (WebCore::ScriptController::evaluateInWorld):
3662         (WebCore::ScriptController::processingUserGestureEvent):
3663         * inspector/InspectorTimelineAgent.cpp:
3664         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
3665         * page/DOMTimer.cpp:
3666         (WebCore::DOMTimer::fired):
3667
3668 2009-11-03  Dan Bernstein  <mitz@apple.com>
3669
3670         Reviewed by Dave Hyatt.
3671
3672         Allow a frame to go back to copy-on-scroll when it ceases being overlapped
3673
3674         The code was not testing slow-scrolling frames for overlappedness, thinking the answer
3675         would not matter. That is not the case if the only reason for the slow-scrolling is
3676         being overlapped.
3677
3678         * page/FrameView.cpp:
3679         (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
3680         reason besides being overlapped that the frame would need to fully repaint on scroll.
3681         * page/FrameView.h:
3682         * rendering/RenderWidget.cpp:
3683         (WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().
3684
3685 2009-11-03  Dmitry Titov  <dimich@chromium.org>
3686
3687         Not reviewed, Qt build fix.
3688
3689         Need to use right capitalization for include file.
3690
3691         * page/Navigator.cpp:
3692
3693 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3694
3695         Reviewed by Timothy Hatcher.
3696
3697         Web Inspector: Migrate from top bar filters to check boxes in Timeline.
3698
3699         https://bugs.webkit.org/show_bug.cgi?id=31081
3700
3701         * inspector/front-end/AbstractTimelinePanel.js:
3702         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
3703         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
3704         (WebInspector.AbstractTimelinePanel.prototype.filter):
3705         * inspector/front-end/TimelinePanel.js:
3706         (WebInspector.TimelinePanel):
3707         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3708         (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick):
3709         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
3710         (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
3711         * inspector/front-end/inspector.css:
3712
3713 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3714
3715         Reviewed by Timothy Hatcher.
3716
3717         Web Inspector: clear overview on Clear action and panel reset.
3718
3719         https://bugs.webkit.org/show_bug.cgi?id=31078
3720
3721         * inspector/front-end/TimelinePanel.js:
3722         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3723         (WebInspector.TimelinePanel.prototype.reset):
3724
3725 2009-11-03  Yaar Schnitman  <yaar@chromium.org>
3726
3727         Reviewed by Dimitri Glazkov.
3728
3729         Imported action and rules python files that WebCore.gyp depends on. 
3730         These files used to live in chromium.org and deal mostly with auto-generation
3731         of code by wrapping existing webkit perl scripts.
3732
3733         https://bugs.webkit.org/show_bug.cgi?id=31071
3734
3735         * WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
3736         * WebCore.gyp/scripts/action_csspropertynames.py: Added.
3737         * WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
3738         * WebCore.gyp/scripts/action_makenames.py: Added.
3739         * WebCore.gyp/scripts/action_maketokenizer.py: Added.
3740         * WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
3741         * WebCore.gyp/scripts/rule_binding.py: Added.
3742         * WebCore.gyp/scripts/rule_bison.py: Added.
3743         * WebCore.gyp/scripts/rule_gperf.py: Added.
3744
3745 2009-11-03  Bradley Green  <brg@chromium.org>
3746
3747         Reviewed by Dmitry Titov.
3748
3749         Implement window.navigator.registerProtocolHandler in webkit,
3750         https://bugs.webkit.org/b/29651
3751
3752         Also implemented its sister API window.navigator.registerContentHandler.
3753
3754         These methods are as described in the HTML5 specification which can be
3755         found here,
3756         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
3757         http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler
3758
3759         As specified in the document, the behavior of the browser is determined
3760         by the current registered handler.  The state of a registered handler
3761         can change at any time, with the user clearing a registered handler,
3762         registering a different page as handler, or deferring the hander to the
3763         OS.  If webkit was to track the state of the currently registered
3764         handlers, it would need more APIs and complexity to keep in sync with
3765         user actions reported to webkit from the UA.  For simplicity, the state
3766         of protocol handlers should be kept isolated from webkit and webkit only
3767         notifies the UA that a page has made the call.  The UA is then
3768         responsible for correctly handling the registerProtocolHandler call and
3769         the redirects which result from registration.
3770
3771         We do however follow the specification in insuring that the reserved
3772         schemes and mimeTypes are not passed to the UA as custom handler
3773         registration tests.  We also insure that the "%s" token is present as
3774         required by the specification.
3775
3776         Updated test expectations for window.clientInformation and navigator
3777         objects.
3778
3779         Tests: fast/dom/registerContentHandler.html
3780                fast/dom/registerProtocolHandler.html
3781
3782         * page/Chrome.cpp:
3783         (WebCore::Chrome::registerProtocolHandler):
3784         (WebCore::Chrome::registerContentHandler):
3785         * page/Chrome.h:
3786         * page/ChromeClient.h:
3787         (WebCore::ChromeClient::registerProtocolHandler):
3788         (WebCore::ChromeClient::registerContentHandler):
3789         * page/Navigator.cpp:
3790         (WebCore::verifyCustomHandlerURL):
3791         (WebCore::verifyProtocolHandlerScheme):
3792         (WebCore::Navigator::registerProtocolHandler):
3793         (WebCore::verifyProtocolHandlerMimeType):
3794         (WebCore::Navigator::registerContentHandler):
3795         * page/Navigator.h:
3796         * page/Navigator.idl:
3797
3798 2009-11-03  Brady Eidson  <beidson@apple.com>
3799
3800         Reviewed by Darin Adler.
3801
3802         https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h
3803
3804         No new tests. (No change in functionality)
3805
3806         * dom/Document.cpp:
3807         (WebCore::Document::inspectorTimelineAgent): Moved from Document.h
3808         * dom/Document.h:
3809
3810         Include "Page.h" directly:
3811         * html/HTMLVideoElement.cpp:
3812         * loader/RedirectScheduler.cpp:
3813         * page/History.cpp:
3814         * rendering/MediaControlElements.cpp:
3815         * storage/StorageAreaImpl.cpp:
3816
3817 2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>
3818
3819         Reviewed by Timothy Hatcher.
3820
3821         Web Inspector: hover over JS "things" in source and see their values
3822         https://bugs.webkit.org/show_bug.cgi?id=30913
3823
3824         * inspector/front-end/SourceFrame.js:
3825
3826 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3827
3828         Reviewed by Timothy Hatcher.
3829
3830         Web Inspector: update timeline content boundaries on timer.
3831
3832         https://bugs.webkit.org/show_bug.cgi?id=31072
3833
3834         * inspector/front-end/TimelinePanel.js:
3835         (WebInspector.TimelinePanel.prototype.refresh):
3836         (WebInspector.TimelinePanel.prototype._setWindowPosition):
3837
3838 2009-11-03  Dan Bernstein  <mitz@apple.com>
3839
3840         Reviewed by Anders Carlsson and Beth Dakin.
3841
3842         https://bugs.webkit.org/show_bug.cgi?id=31070
3843         Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
3844         Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()
3845
3846         Tests: plugins/attach-during-destroy.html
3847                plugins/destroy-reentry.html
3848
3849         These crashes were caused by plug-in code running during detach(),
3850         causing re-entry into RenderWidget::destroy() in one case and a call
3851         into attach() in the other. The fix is to prevent plug-in code from
3852         being called at certain unsafe times (during attach(), detach(), and
3853         recalcStyle()) by deferring changes to the widget hierarchy.
3854
3855         * dom/Document.cpp:
3856         (WebCore::Document::recalcStyle): Suspend widget hierarchy updates
3857             during style recalculation.
3858
3859         * dom/Element.cpp:
3860         (WebCore::Element::attach): Suspend widget hierarchy updates during
3861             attach().
3862         (WebCore::Element::detach): Suspend widget hierarchy updates during
3863             detach().
3864
3865         * rendering/RenderWidget.cpp:
3866         (WebCore::widgetNewParentMap): Returns a static map of pending changes
3867             to the widget hierarchy.
3868         (WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the
3869             suspend count.
3870         (WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the
3871             suspend count. If the count is going to be zero, updates the widget
3872             hierarchy by executing the pending changes stored in the map.
3873         (WebCore::moveWidgetToParentSoon): Updates the widget hierarchy
3874             immediately or makes or updates an entry in the map, depending on
3875             whether updates are suspended.
3876         (WebCore::RenderWidget::destroy): Removed earlier bandaid fix for
3877             <rdar://problem/6937089>.
3878         (WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates
3879             are not suspended, because this function updates the widget’s
3880             bounds, which can result in arbitrary native and JavaScript code
3881             execution. I think this assertion is true thanks to some deferred-
3882             update mechanisms that have already been deployed in other places
3883             in the code.
3884         (WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead
3885             of changing the widget hierarchy directly.
3886         * rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()
3887             and resumeWidgetHierarchyUpdates().
3888
3889 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3890
3891         Reviewed by Timothy Hatcher.
3892
3893         Web Inspector: only show timeline records that contribute
3894         to the current window.
3895
3896         https://bugs.webkit.org/show_bug.cgi?id=31069
3897
3898         * inspector/front-end/TimelinePanel.js:
3899         (WebInspector.TimelinePanel.prototype.refresh):
3900         (WebInspector.TimelineGraph):
3901         (WebInspector.TimelineGraph.prototype.refresh):
3902
3903 2009-11-03  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3904
3905         Reviewed by Timothy Hatcher.
3906
3907         Watch expression editor should stay open after Add button was clicked
3908         https://bugs.webkit.org/show_bug.cgi?id=31049
3909
3910         No new tests, was a regression, use existing manual test.
3911
3912         * inspector/front-end/WatchExpressionsSidebarPane.js:
3913         (WebInspector.WatchExpressionsSection.prototype.update):
3914         (WebInspector.WatchExpressionsSection.prototype.addExpression):
3915
3916 2009-11-03  Evan Martin  <evan@chromium.org>
3917
3918         Reviewed by Darin Adler.
3919
3920         Fix an off-by-one in the CSS lexer that causes memory corruption in
3921         hard-to-trigger circumstances.
3922
3923         https://bugs.webkit.org/show_bug.cgi?id=30827
3924
3925         Test: fast/css/end-of-buffer-crash.html
3926
3927         * css/maketokenizer: Add comments, fix off-by-one.
3928
3929 2009-11-02  Darin Adler  <darin@apple.com>
3930
3931         Reviewed by Dan Bernstein.
3932
3933         Crash due to double-destroy related to CSS run-in property
3934         https://bugs.webkit.org/show_bug.cgi?id=31034
3935         rdar://problem/7328458
3936
3937         Test: fast/css/run-in-crash.html
3938
3939         * rendering/RenderBlock.cpp:
3940         (WebCore::RenderBlock::destroy): Reorder destruction so the
3941         continuation is destroyed after anonymous children. See comment
3942         in the code for more details of why this is right.
3943         * rendering/RenderInline.cpp:
3944         (WebCore::RenderInline::destroy): Ditto.
3945
3946 2009-11-03  Alexander Pavlov  <apavlov@chromium.org>
3947
3948         Reviewed by Pavel Feldman.
3949
3950         Fix exception in ElementsPanel.js when moving pointer out of crumbs and window
3951
3952         There might be no new node under mouse if the pointer is moved out of the window
3953         in which case we get an exception.
3954         https://bugs.webkit.org/show_bug.cgi?id=31061
3955
3956         * inspector/front-end/ElementsPanel.js:
3957         (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
3958
3959 2009-11-03  Zoltan Horvath  <zoltan@webkit.org>
3960
3961         Reviewed by Darin Adler.
3962
3963         Allow custom memory allocation control for the dom directory of WebCore
3964         https://bugs.webkit.org/show_bug.cgi?id=31053
3965
3966         Inherits the following classes from Noncopyable because these are
3967         instantiated by 'new' and these are no need to be copyable:
3968
3969         class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
3970         struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
3971         class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
3972         struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51 
3973         struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
3974         class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552
3975
3976         Inherits QualifiedName class from FastAllocBase because it is
3977         instantiated by 'new' in WebCore/editing/markup.cpp:319
3978
3979         * dom/Document.cpp:
3980         * dom/EventNames.h:
3981         * dom/EventTarget.h:
3982         * dom/MessagePortChannel.h:
3983         * dom/NodeRareData.h:
3984         * dom/QualifiedName.h:
3985
3986 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
3987
3988         Reviewed by Timothy Hatcher.
3989
3990         Web Inspector: Implement timeline summary panel.
3991
3992         https://bugs.webkit.org/show_bug.cgi?id=31064
3993
3994         * inspector/front-end/TimelinePanel.js:
3995         (WebInspector.TimelinePanel.prototype._createOverview):
3996         (WebInspector.TimelinePanel.prototype.refresh):
3997         (WebInspector.TimelineCategoryGraph):
3998         (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
3999         (WebInspector.TimelineCategoryGraph.prototype.addChunk):
4000         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
4001         (WebInspector.TimelineGraph.prototype.refresh):
4002         * inspector/front-end/inspector.css:
4003
4004 2009-11-03  Alexander Pavlov  <apavlov@chromium.org>
4005
4006         Reviewed by Timothy Hatcher.
4007
4008         Toggle off 'Search for node' when the Inspector window is closing
4009
4010         Searching for node should be toggled off when the Inspector window is closed,
4011         in a platform-independent manner.
4012         https://bugs.webkit.org/show_bug.cgi?id=31059
4013
4014         * inspector/InspectorController.cpp:
4015         (WebCore::InspectorController::setWindowVisible):
4016
4017 2009-11-03  Mikhail Naganov  <mnaganov@chromium.org>
4018
4019         Reviewed by Timothy Hatcher.
4020
4021         Prepare for heap profiles upstreaming:
4022         - pass profile type id from InspectorController;
4023         - this makes WebInspector.CPUProfile redundant---removed;
4024         - support multiple profile types when populating profiles.
4025
4026         https://bugs.webkit.org/show_bug.cgi?id=31052
4027
4028         * inspector/InspectorController.cpp:
4029         (WebCore::InspectorController::createProfileHeader):
4030         * inspector/front-end/ProfileView.js:
4031         (WebInspector.CPUProfileView.profileCallback):
4032         (WebInspector.CPUProfileView):
4033         (WebInspector.CPUProfileView.prototype._sortData):
4034         * inspector/front-end/ProfilesPanel.js:
4035         (WebInspector.ProfilesPanel.prototype.addProfileHeader):
4036         * inspector/front-end/inspector.js:
4037         (WebInspector.addProfileHeader):
4038
4039 2009-11-03  Dan Kegel  <dank@chromium.org>
4040
4041         Reviewed by Dimitri Glazkov.
4042
4043         UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
4044         https://bugs.webkit.org/show_bug.cgi?id=31063
4045
4046         * accessibility/AccessibilityRenderObject.cpp:
4047         (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
4048
4049 2009-11-03  Pavel Feldman  <pfeldman@chromium.org>
4050
4051         Reviewed by Timothy Hatcher.
4052
4053         Web Inspector: Implement Timeline Window, wire it to the bottom timeline.
4054
4055         https://bugs.webkit.org/show_bug.cgi?id=31056
4056
4057         * English.lproj/localizedStrings.js:
4058         * inspector/front-end/AbstractTimelinePanel.js:
4059         (WebInspector.AbstractTimelinePanel.prototype.get items):
4060         (WebInspector.AbstractTimelinePanel.prototype.createInterface):
4061         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
4062         (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
4063         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
4064         (WebInspector.AbstractTimelinePanel.prototype.refresh):
4065         (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
4066         (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider):
4067         (WebInspector.TimelineGrid):
4068         (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
4069         (WebInspector.TimelineGrid.prototype.updateDividers):
4070         (WebInspector.TimelineGrid.prototype.addExtraDivider):
4071         (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
4072         * inspector/front-end/ResourcesPanel.js:
4073         (WebInspector.ResourcesPanel):
4074         (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
4075         (WebInspector.ResourcesPanel.prototype.get _resources):
4076         * inspector/front-end/TimelinePanel.js:
4077         (WebInspector.TimelinePanel):
4078         (WebInspector.TimelinePanel.prototype.get categories):
4079         (WebInspector.TimelinePanel.prototype._formatRecord):
4080         (WebInspector.TimelinePanel.prototype.reset):
4081         (WebInspector.TimelinePanel.prototype._createOverview):
4082         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
4083         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
4084         (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded):
4085         (WebInspector.TimelinePanel.prototype.refresh):
4086         (WebInspector.TimelinePanel.prototype._resizeWindow):
4087         (WebInspector.TimelinePanel.prototype._windowResizeDragging):
4088         (WebInspector.TimelinePanel.prototype._dragWindow):
4089         (WebInspector.TimelinePanel.prototype._windowDragging):
4090         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
4091         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
4092         (WebInspector.TimelinePanel.prototype._setWindowPosition):
4093         (WebInspector.TimelinePanel.prototype._endWindowDragging):
4094         (WebInspector.TimelineCategoryTreeElement):
4095         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
4096         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
4097         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
4098         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
4099         (WebInspector.TimelineCalculator.prototype.reset):
4100         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
4101         (WebInspector.TimelineCalculator.prototype.formatValue):
4102         * inspector/front-end/inspector.css:
4103
4104 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
4105
4106         Reviewed by Tor Arne Vestbø.
4107
4108         Make QWebPluginDatabase private API for now.
4109
4110         https://bugs.webkit.org/show_bug.cgi?id=30775
4111
4112         * WebCore.pro:
4113
4114 2009-11-03  Simon Hausmann  <hausmann@webkit.org>
4115
4116         Reviewed by Tor Arne Vestbø.
4117
4118         Extended the conversion of the WebCore ResourceRequest to the
4119         QNetworkRequest with a mandatory originating object argument,
4120         which is meant to be the QWebFrame the request belongs to.
4121
4122         https://bugs.webkit.org/show_bug.cgi?id=29975
4123
4124         * platform/network/qt/QNetworkReplyHandler.cpp:
4125         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
4126         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
4127         (WebCore::QNetworkReplyHandler::start):
4128         * platform/network/qt/ResourceRequest.h:
4129         * platform/network/qt/ResourceRequestQt.cpp:
4130         (WebCore::ResourceRequest::toNetworkRequest):
4131
4132 2009-11-03  Keishi Hattori  <casey.hattori@gmail.com>
4133
4134         Reviewed by Pavel Feldman.
4135
4136         Web Inspector: monitorEvent should be monitorEvents
4137         https://bugs.webkit.org/show_bug.cgi?id=31042
4138
4139         * inspector/front-end/InjectedScript.js:
4140         (InjectedScript._ensureCommandLineAPIInstalled):
4141
4142 2009-11-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4143
4144         Rubber-stamped by Antti Koivisto.
4145
4146         [Qt] Build fix for Windows CE
4147
4148         * plugins/PluginDatabase.cpp:
4149
4150 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
4151
4152         Reviewed by David Levin.
4153
4154         fix accessibility webkit-style-check errors
4155         https://bugs.webkit.org/show_bug.cgi?id=29672
4156
4157         * accessibility/AXObjectCache.cpp:
4158         (WebCore::AXObjectCache::getOrCreate):
4159         (WebCore::AXObjectCache::remove):
4160         (WebCore::AXObjectCache::platformGenerateAXID):
4161         (WebCore::AXObjectCache::removeAXID):
4162         * accessibility/AXObjectCache.h:
4163         (WebCore::AXObjectCache::enableAccessibility):
4164         (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
4165         (WebCore::AXObjectCache::accessibilityEnabled):
4166         (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
4167         (WebCore::AXObjectCache::isIDinUse):
4168         (WebCore::AXObjectCache::objectFromAXID):
4169         (WebCore::AXObjectCache::):
4170         (WebCore::AXObjectCache::handleActiveDescendantChanged):
4171         (WebCore::AXObjectCache::handleAriaRoleChanged):
4172         (WebCore::AXObjectCache::detachWrapper):
4173         (WebCore::AXObjectCache::attachWrapper):
4174         (WebCore::AXObjectCache::selectedChildrenChanged):
4175         (WebCore::AXObjectCache::postNotification):
4176         (WebCore::AXObjectCache::postPlatformNotification):
4177         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
4178         (WebCore::AXObjectCache::handleScrolledToAnchor):
4179         * accessibility/AccessibilityARIAGrid.cpp:
4180         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
4181         * accessibility/AccessibilityAllInOne.cpp:
4182         * accessibility/AccessibilityImageMapLink.cpp:
4183         * accessibility/AccessibilityList.h:
4184         (WebCore::AccessibilityList::isList):
4185         * accessibility/AccessibilityListBox.cpp:
4186         * accessibility/AccessibilityListBox.h:
4187         (WebCore::AccessibilityListBox::isListBox):
4188         * accessibility/AccessibilityListBoxOption.cpp:
4189         * accessibility/AccessibilityListBoxOption.h:
4190         (WebCore::AccessibilityListBoxOption::isListBoxOption):
4191         * accessibility/AccessibilityMediaControls.h:
4192         (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
4193         (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
4194         (WebCore::AccessibilityMediaTimeline::isMediaTimeline):
4195         (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
4196         (WebCore::AccessibilityMediaControlsContainer::roleValue):
4197         (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
4198         (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
4199         (WebCore::AccessibilityMediaTimeDisplay::roleValue):
4200         * accessibility/AccessibilityObject.cpp:
4201         (WebCore::AccessibilityObject::parentObjectUnignored):
4202         (WebCore::AccessibilityObject::rightLineVisiblePositionRange):
4203         (WebCore::replacedNodeNeedsCharacter):
4204         (WebCore::AccessibilityObject::stringForVisiblePositionRange):
4205         (WebCore::AccessibilityObject::lengthForVisiblePositionRange):
4206         (WebCore::AccessibilityObject::actionVerb):
4207         * accessibility/AccessibilityObject.h:
4208         (WebCore::PlainTextRange::isNull):
4209         (WebCore::AccessibilityObject::isAccessibilityRenderObject):
4210         (WebCore::AccessibilityObject::isAnchor):
4211         (WebCore::AccessibilityObject::isAttachment):
4212         (WebCore::AccessibilityObject::isHeading):
4213         (WebCore::AccessibilityObject::isLink):
4214         (WebCore::AccessibilityObject::isImage):
4215         (WebCore::AccessibilityObject::isNativeImage):
4216         (WebCore::AccessibilityObject::isImageButton):
4217         (WebCore::AccessibilityObject::isPasswordField):
4218         (WebCore::AccessibilityObject::isTextControl):
4219         (WebCore::AccessibilityObject::isNativeTextControl):
4220         (WebCore::AccessibilityObject::isWebArea):
4221         (WebCore::AccessibilityObject::isCheckboxOrRadio):
4222         (WebCore::AccessibilityObject::isListBox):
4223         (WebCore::AccessibilityObject::isFileUploadButton):
4224         (WebCore::AccessibilityObject::isProgressIndicator):
4225         (WebCore::AccessibilityObject::isSlider):
4226         (WebCore::AccessibilityObject::isControl):
4227         (WebCore::AccessibilityObject::isList):
4228         (WebCore::AccessibilityObject::isDataTable):
4229         (WebCore::AccessibilityObject::isTableRow):
4230         (WebCore::AccessibilityObject::isTableColumn):
4231         (WebCore::AccessibilityObject::isTableCell):
4232         (WebCore::AccessibilityObject::isFieldset):
4233         (WebCore::AccessibilityObject::isGroup):
4234         (WebCore::AccessibilityObject::isChecked):
4235         (WebCore::AccessibilityObject::isEnabled):
4236         (WebCore::AccessibilityObject::isSelected):
4237         (WebCore::AccessibilityObject::isFocused):
4238         (WebCore::AccessibilityObject::isHovered):
4239         (WebCore::AccessibilityObject::isIndeterminate):
4240         (WebCore::AccessibilityObject::isLoaded):
4241         (WebCore::AccessibilityObject::isMultiSelect):
4242         (WebCore::AccessibilityObject::isOffScreen):
4243         (WebCore::AccessibilityObject::isPressed):
4244         (WebCore::AccessibilityObject::isReadOnly):
4245         (WebCore::AccessibilityObject::isVisited):
4246         (WebCore::AccessibilityObject::isRequired):
4247         (WebCore::AccessibilityObject::canSetFocusAttribute):
4248         (WebCore::AccessibilityObject::canSetTextRangeAttributes):
4249         (WebCore::AccessibilityObject::canSetValueAttribute):
4250         (WebCore::AccessibilityObject::hasIntValue):
4251         (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
4252         (WebCore::AccessibilityObject::accessibilityIsIgnored):
4253         * accessibility/AccessibilityRenderObject.cpp:
4254         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
4255         (WebCore::AccessibilityRenderObject::parentObject):
4256         (WebCore::AccessibilityRenderObject::isMenuRelated):
4257         (WebCore::AccessibilityRenderObject::accessibilityDescription):
4258         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
4259         (WebCore::AccessibilityRenderObject::isFocused):
4260         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
4261         (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
4262         (WebCore::AccessibilityRenderObject::doAXRangeForLine):
4263         (WebCore::AccessibilityRenderObject::doAXStringForRange):
4264         (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
4265         (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
4266         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
4267         (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
4268         (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
4269         (WebCore::AccessibilityRenderObject::canHaveChildren):
4270         (WebCore::AccessibilityRenderObject::actionVerb):
4271         (WebCore::shouldReturnTagNameAsRoleForMSAA):
4272         * accessibility/AccessibilityRenderObject.h:
4273         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
4274         * accessibility/AccessibilitySlider.cpp:
4275         (WebCore::AccessibilitySlider::orientation):
4276         * accessibility/AccessibilitySlider.h:
4277         (WebCore::AccessibilitySlider::~AccessibilitySlider):
4278         (WebCore::AccessibilitySlider::roleValue):
4279         (WebCore::AccessibilitySlider::accessibilityIsIgnored):
4280         (WebCore::AccessibilitySlider::isSlider):
4281         (WebCore::AccessibilitySlider::canSetValueAttribute):
4282         (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
4283         (WebCore::AccessibilitySliderThumb::roleValue):