1 2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
3 Reviewed by Darin Adler.
5 https://bugs.webkit.org/show_bug.cgi?id=23354
6 Fix up graphics/chromium files to account for Uniscribe style scrubbing.
8 * platform/graphics/chromium/FontChromiumWin.cpp:
9 (WebCore::windowsCanHandleTextDrawing):
10 (WebCore::Font::selectionRectForComplexText):
11 (WebCore::Font::drawComplexText):
12 (WebCore::Font::floatWidthForComplexText):
13 (WebCore::Font::offsetForPositionForComplexText):
14 * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
15 (WebCore::fillNonBMPGlyphs):
17 2009-01-15 David Levin <levin@chromium.org>
19 Reviewed by Darin Adler.
21 https://bugs.webkit.org/show_bug.cgi?id=23333
22 Adjust due to a name change that happened in a WebKit.
24 * svg/graphics/skia/SVGPaintServerPatternSkia.cpp:
25 (WebCore::SVGPaintServerPattern::setup):
27 2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
29 Reviewed by Eric Seidel.
31 https://bugs.webkit.org/show_bug.cgi?id=23340
32 Add remaining bits of graphics/chromium.
34 * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added.
35 (WebCore::scaleEmToUnits):
36 (WebCore::SimpleFontData::platformInit):
37 (WebCore::SimpleFontData::platformDestroy):
38 (WebCore::SimpleFontData::smallCapsFontData):
39 (WebCore::SimpleFontData::containsCharacters):
40 (WebCore::SimpleFontData::determinePitch):
41 (WebCore::SimpleFontData::platformWidthForGlyph):
42 * platform/graphics/chromium/SimpleFontDataLinux.cpp: Added.
43 (WebCore::SimpleFontData::platformInit):
44 (WebCore::SimpleFontData::platformDestroy):
45 (WebCore::SimpleFontData::smallCapsFontData):
46 (WebCore::SimpleFontData::containsCharacters):
47 (WebCore::SimpleFontData::determinePitch):
48 (WebCore::SimpleFontData::platformWidthForGlyph):
49 * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added.
50 (WebCore::ThemeHelperWin::ThemeHelperWin):
51 (WebCore::ThemeHelperWin::~ThemeHelperWin):
52 * platform/graphics/chromium/ThemeHelperChromiumWin.h: Added.
53 (WebCore::ThemeHelperWin::):
54 (WebCore::ThemeHelperWin::context):
55 (WebCore::ThemeHelperWin::rect):
56 * platform/graphics/chromium/UniscribeHelper.cpp: Added.
57 (WebCore::treatAsSpace):
58 (WebCore::containsMissingGlyphs):
59 (WebCore::setLogFontAndStyle):
60 (WebCore::UniscribeHelper::UniscribeHelper):
61 (WebCore::UniscribeHelper::~UniscribeHelper):
62 (WebCore::UniscribeHelper::initWithOptionalLengthProtection):
63 (WebCore::UniscribeHelper::width):
64 (WebCore::UniscribeHelper::justify):
65 (WebCore::UniscribeHelper::characterToX):
66 (WebCore::UniscribeHelper::xToCharacter):
67 (WebCore::UniscribeHelper::draw):
68 (WebCore::UniscribeHelper::firstGlyphForCharacter):
69 (WebCore::UniscribeHelper::fillRuns):
70 (WebCore::UniscribeHelper::shape):
71 (WebCore::UniscribeHelper::fillShapes):
72 (WebCore::UniscribeHelper::fillScreenOrder):
73 (WebCore::UniscribeHelper::adjustSpaceAdvances):
74 (WebCore::UniscribeHelper::applySpacing):
75 (WebCore::UniscribeHelper::advanceForItem):
76 * platform/graphics/chromium/UniscribeHelper.h: Added.
77 (WebCore::UniscribeHelper::directionalOverride):
78 (WebCore::UniscribeHelper::setDirectionalOverride):
79 (WebCore::UniscribeHelper::inhibitLigate):
80 (WebCore::UniscribeHelper::setInhibitLigate):
81 (WebCore::UniscribeHelper::letterSpacing):
82 (WebCore::UniscribeHelper::setLetterSpacing):
83 (WebCore::UniscribeHelper::spaceWidth):
84 (WebCore::UniscribeHelper::setSpaceWidth):
85 (WebCore::UniscribeHelper::wordSpacing):
86 (WebCore::UniscribeHelper::setWordSpacing):
87 (WebCore::UniscribeHelper::setAscent):
88 (WebCore::UniscribeHelper::init):
89 (WebCore::UniscribeHelper::tryToPreloadFont):
90 (WebCore::UniscribeHelper::Shaping::Shaping):
91 (WebCore::UniscribeHelper::Shaping::glyphLength):
92 (WebCore::UniscribeHelper::Shaping::charLength):
93 (WebCore::UniscribeHelper::Shaping::effectiveAdvances):
94 (WebCore::UniscribeHelper::nextWinFontData):
95 (WebCore::UniscribeHelper::resetFontIndex):
96 * platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added.
97 (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
98 (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
99 (WebCore::UniscribeHelperTextRun::nextWinFontData):
100 (WebCore::UniscribeHelperTextRun::resetFontIndex):
101 * platform/graphics/chromium/UniscribeHelperTextRun.h: Added.
103 2009-01-15 Chris Marrin <cmarrin@apple.com>
105 Reviewed by Dan Bernstein.
107 Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421
109 * WebCore.vcproj/WebCore.vcproj:
111 2009-01-15 Aaron Boodman <aa@chromium.org>
113 Reviewed by Adam Roben.
115 https://bugs.webkit.org/show_bug.cgi?id=15279
116 Right clicking over text (or multiple spaces) auto selects the word
117 (or multiple spaces) under it, which is not a desirable effect for some
120 * page/EventHandler.cpp:
121 (WebCore::EventHandler::sendContextMenuEvent):
122 Don't select words on right-click on Chromium.
124 2009-01-15 Darin Fisher <darin@chromium.org>
126 Reviewed by Eric Seidel.
128 https://bugs.webkit.org/show_bug.cgi?id=23345
129 SharedBuffer.h should include wtf/OwnPtr.h
131 * platform/SharedBuffer.h:
133 2009-01-14 David Kilzer <ddkilzer@apple.com>
135 Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it
137 <https://bugs.webkit.org/show_bug.cgi?id=23338>
139 Reviewed by Timothy Hatcher.
141 * WebCore.xcodeproj/project.pbxproj: Check to see if
142 "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector"
143 exists before trying to change directories into it and then
144 deleting, modifying and adding files to it.
146 2009-01-14 miggilin <mr.diggilin@gmail.com>
148 Reviewed by Kevin Ollivier.
150 Fixing wx compilation for wx 2.9/trunk.
152 * platform/graphics/wx/FontPlatformData.h:
153 (WebCore::FontPlatformData::operator==):
154 (WebCore::FontPlatformData::computeHash):
155 * platform/graphics/wx/GraphicsContextWx.cpp:
156 (WebCore::GraphicsContext::clip):
157 (WebCore::GraphicsContext::setCompositeOperation):
158 * platform/graphics/wx/ImageSourceWx.cpp:
159 (WebCore::ImageSource::createFrameAtIndex):
160 * platform/graphics/wx/PathWx.cpp:
161 (WebCore::Path::contains):
162 * platform/wx/RenderThemeWx.cpp:
163 (WebCore::RenderThemeWx::paintButton):
164 (WebCore::RenderThemeWx::paintTextField):
165 (WebCore::RenderThemeWx::paintMenuList):
166 * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
168 2009-01-14 Kevin Ollivier <kevino@theolliviers.com>
170 wx build fix. Adding WebKitCSSMatrix.
172 * WebCoreSources.bkl:
174 2009-01-14 Adam Treat <adam.treat@torchmobile.com>
176 Prospective build fix for Qt following r39922.
180 2009-01-14 Darin Adler <darin@apple.com>
184 * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
185 (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
188 2009-01-14 Adele Peterson <adele@apple.com>
190 Reviewed by Darin Adler.
192 Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
193 <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
195 No new tests added. In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
196 we'll need a separate set of results for different themes.
198 * css/themeWin.css: Renable search fields. Added new rules for sub-element placement.
200 * rendering/RenderTextControlSingleLine.cpp:
201 (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the
202 desired width for the text block.
204 * rendering/RenderThemeWin.cpp:
205 (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart.
206 (WebCore::RenderThemeWin::determineState): ditto.
207 (WebCore::RenderThemeWin::getClassicThemeData): ditto.
208 (WebCore::RenderThemeWin::getThemeData): ditto.
209 (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork.
210 (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto.
211 (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto.
212 (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height.
213 (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto.
214 (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.
216 2009-01-14 Alp Toker <alp@nuanti.com>
218 GTK+ build fix following r39922.
219 Add WebKitCSSMatrix to the build system.
223 2009-01-14 Chris Marrin <cmarrin@apple.com>
225 Reviewed by Sam Weinig.
227 Implemented 2D WebKitCSSMatrix
228 https://bugs.webkit.org/show_bug.cgi?id=21421
230 Test: transforms/2d/cssmatrix-interface.xhtml
232 * DerivedSources.make:
233 * WebCore.xcodeproj/project.pbxproj:
234 * bindings/js/JSDOMWindowBase.cpp:
235 (jsDOMWindowBaseWebKitCSSMatrix):
236 (setJSDOMWindowBaseWebKitCSSMatrix):
237 * bindings/js/JSWebKitCSSMatrixConstructor.cpp: Added.
239 (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
240 (WebCore::constructWebKitCSSMatrix):
241 (WebCore::JSWebKitCSSMatrixConstructor::getConstructData):
242 * bindings/js/JSWebKitCSSMatrixConstructor.h: Added.
243 (WebCore::JSWebKitCSSMatrixConstructor::classInfo):
244 * bindings/objc/DOMInternal.h:
245 * css/WebKitCSSMatrix.cpp: Added.
246 (WebCore::WebKitCSSMatrix::WebKitCSSMatrix):
247 (WebCore::WebKitCSSMatrix::~WebKitCSSMatrix):
248 (WebCore::WebKitCSSMatrix::setMatrixValue):
249 (WebCore::WebKitCSSMatrix::multiply):
250 (WebCore::WebKitCSSMatrix::inverse):
251 (WebCore::WebKitCSSMatrix::translate):
252 (WebCore::WebKitCSSMatrix::scale):
253 (WebCore::WebKitCSSMatrix::rotate):
254 (WebCore::WebKitCSSMatrix::toString):
255 * css/WebKitCSSMatrix.h: Added.
256 (WebCore::WebKitCSSMatrix::create):
257 (WebCore::WebKitCSSMatrix::a):
258 (WebCore::WebKitCSSMatrix::b):
259 (WebCore::WebKitCSSMatrix::c):
260 (WebCore::WebKitCSSMatrix::d):
261 (WebCore::WebKitCSSMatrix::e):
262 (WebCore::WebKitCSSMatrix::f):
263 (WebCore::WebKitCSSMatrix::setA):
264 (WebCore::WebKitCSSMatrix::setB):
265 (WebCore::WebKitCSSMatrix::setC):
266 (WebCore::WebKitCSSMatrix::setD):
267 (WebCore::WebKitCSSMatrix::setE):
268 (WebCore::WebKitCSSMatrix::setF):
269 (WebCore::WebKitCSSMatrix::transform):
270 * css/WebKitCSSMatrix.idl: Added.
272 2009-01-14 Michael Moss <mmoss@chromium.org>
274 Reviewed by Eric Seidel.
276 Workaround a skia limitation on repeated patterns, and remove extra
277 transformations applied to pattern.
278 https://bugs.webkit.org/show_bug.cgi?id=23332
281 LayoutTests/fast/canvas/patternfill-repeat.html
282 LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg
284 * platform/graphics/skia/PatternSkia.cpp:
285 (WebCore::Pattern::createPlatformPattern):
287 2009-01-14 Mark Rowe <mrowe@apple.com>
289 Fix https://bugs.webkit.org/show_bug.cgi?id=23334
290 Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp
292 Include wtf/UnusedParam.h to get UNUSED_PARAM.
294 * dom/XMLTokenizerLibxml2.cpp:
295 (WebCore::hackAroundLibXMLEntityBug):
297 2009-01-14 David Levin <levin@chromium.org>
299 Reviewed by Darin Adler.
301 https://bugs.webkit.org/show_bug.cgi?id=23333
302 Platform code fixes. These compensate for changes in platform
303 callbacks from WebKit and minor API tweaks.
305 I enumerated a few below.
307 * platform/graphics/chromium/FontCacheChromiumWin.cpp:
308 fontExists has been gone since r34794.
310 * platform/graphics/skia/ImageSkia.cpp:
311 (WebCore::paintSkBitmap):
313 (WebCore::FrameData::clear):
314 r39751 changes this api to take and return a bool.
316 (WebCore::Image::drawPattern):
317 * platform/graphics/skia/PathSkia.cpp:
318 (WebCore::Path::apply):
319 (WebCore::boundingBoxForCurrentStroke):
320 (WebCore::Path::strokeContains):
321 * svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.
323 2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
325 Reviewed by Eric Seidel.
327 <https://bugs.webkit.org/show_bug.cgi?id=16829>
328 Implement NPN_SetException()
330 This mirrors the implementation in the obj-c bindings.
332 Test: plugins/netscape-throw-exception.html
334 * bridge/NP_jsobject.cpp:
336 * bridge/c/c_instance.cpp:
337 (JSC::Bindings::getExceptionString):
338 (JSC::Bindings::CInstance::setGlobalException):
339 (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
340 (JSC::Bindings::CInstance::invokeMethod):
341 (JSC::Bindings::CInstance::invokeDefaultMethod):
342 (JSC::Bindings::CInstance::invokeConstruct):
343 (JSC::Bindings::CInstance::getPropertyNames):
344 * bridge/c/c_instance.h:
346 2009-01-14 Pierre-Olivier Latour <pol@apple.com>
348 Fixed build warning when LIBXML_VERSION >= 20627.
350 * dom/XMLTokenizerLibxml2.cpp:
351 (WebCore::hackAroundLibXMLEntityBug):
353 2009-01-14 Alexey Proskuryakov <ap@webkit.org>
355 Reviewed by Anders Carlsson.
357 https://bugs.webkit.org/show_bug.cgi?id=23326
358 Resources are never deleted from application cache disk database
360 * loader/appcache/ApplicationCacheStorage.cpp:
361 (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when
362 a cache is deleted. Note that this change doesn't require bumping schema version. We should
363 consider switching to foreign keys and cascade delete instead of triggers in the future.
364 (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient
365 to only remove the cache itself.
366 (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this
367 is done automatically when a cache is deleted.
369 2009-01-14 David Kilzer <ddkilzer@apple.com>
371 Bug 22795: favicons should be saved to webarchives
373 <https://bugs.webkit.org/show_bug.cgi?id=22795>
375 Reviewed by Darin Adler.
377 Test: webarchive/test-link-rel-icon.html
379 * html/HTMLLinkElement.cpp:
380 (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add
381 favicon URLs to the list since no ArchiveResource or CachedResource
382 is ever created for them.
383 * loader/archive/cf/LegacyWebArchive.cpp:
384 (WebCore::LegacyWebArchive::create): Handle favicons as a special
385 case for all main resources.
386 * loader/icon/IconDatabase.cpp:
387 (WebCore::IconDatabase::close): Actually close the SQLite database
388 so that isOpen() returns false when called. Added an ASSERT() for
391 2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
393 Reviewed by Eric Seidel.
395 https://bugs.webkit.org/show_bug.cgi?id=23321
396 Upstream more bits of graphics/chromium.
398 * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added.
399 (WebCore::FontPlatformData::FontPlatformData):
400 (WebCore::FontPlatformData::operator=):
401 (WebCore::FontPlatformData::~FontPlatformData):
402 (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
403 (WebCore::FontPlatformData::hashTableDeletedFontValue):
404 (WebCore::FontPlatformData::scriptFontProperties):
405 * platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added.
406 (WebCore::FontPlatformData::isHashTableDeletedValue):
407 (WebCore::FontPlatformData::hfont):
408 (WebCore::FontPlatformData::size):
409 (WebCore::FontPlatformData::hash):
410 (WebCore::FontPlatformData::operator==):
411 (WebCore::FontPlatformData::scriptCache):
412 (WebCore::FontPlatformData::RefCountedHFONT::create):
413 (WebCore::FontPlatformData::RefCountedHFONT::hfont):
414 (WebCore::FontPlatformData::RefCountedHFONT::hash):
415 (WebCore::FontPlatformData::RefCountedHFONT::operator==):
416 (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
417 * platform/graphics/chromium/FontPlatformDataLinux.cpp: Added.
418 (WebCore::FontPlatformData::FontPlatformData):
419 (WebCore::FontPlatformData::~FontPlatformData):
420 (WebCore::FontPlatformData::operator=):
421 (WebCore::FontPlatformData::setupPaint):
422 (WebCore::FontPlatformData::operator==):
423 (WebCore::FontPlatformData::hash):
424 (WebCore::FontPlatformData::isFixedPitch):
425 * platform/graphics/chromium/FontPlatformDataLinux.h: Added.
426 (WebCore::FontPlatformData::FontPlatformData):
427 (WebCore::FontPlatformData::size):
428 (WebCore::FontPlatformData::isHashTableDeletedValue):
429 (WebCore::FontPlatformData::hashTableDeletedFontValue):
430 * platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added.
432 (WebCore::FontMap::getAscent):
433 (WebCore::FontMap::FontData::FontData):
434 (WebCore::getFontFamilyForScript):
435 (WebCore::getFallbackFamily):
436 (WebCore::getDerivedFontData):
437 (WebCore::getStyleFromLogfont):
438 * platform/graphics/chromium/FontUtilsChromiumWin.h: Added.
441 2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
443 Reviewed by Eric Seidel.
445 https://bugs.webkit.org/show_bug.cgi?id=23325
446 Upstream even more graphics/chromium bits.
448 * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added.
449 (WebCore::fillEmptyGlyphs):
450 (WebCore::initSpaceGlyph):
451 (WebCore::fillBMPGlyphs):
452 (WebCore::fillNonBMPGlyphs):
453 (WebCore::GlyphPage::fill):
454 * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added.
455 (WebCore::GlyphPage::fill):
456 * platform/graphics/chromium/IconChromiumLinux.cpp: Added.
457 (WebCore::Icon::Icon):
458 (WebCore::Icon::~Icon):
459 (WebCore::Icon::createIconForFile):
460 (WebCore::Icon::createIconForFiles):
461 (WebCore::Icon::paint):
462 * platform/graphics/chromium/IconChromiumMac.cpp: Added.
463 (WebCore::Icon::createIconForFile):
464 (WebCore::Icon::createIconForFiles):
465 (WebCore::Icon::~Icon):
466 (WebCore::Icon::paint):
467 * platform/graphics/chromium/IconChromiumWin.cpp: Added.
468 (WebCore::Icon::Icon):
469 (WebCore::Icon::~Icon):
470 (WebCore::Icon::createIconForFile):
471 (WebCore::Icon::createIconForFiles):
472 (WebCore::Icon::paint):
473 * platform/graphics/chromium/ImageBufferData.h: Added.
474 * platform/graphics/chromium/ImageChromiumMac.mm: Added.
475 (WebCore::Image::loadPlatformResource):
476 (WebCore::BitmapImage::initPlatformData):
477 (WebCore::BitmapImage::invalidatePlatformData):
478 * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
479 * platform/graphics/chromium/PlatformIcon.h: Added.
481 2009-01-14 Darin Fisher <darin@chromium.org>
483 Reviewed by Eric Seidel.
485 https://bugs.webkit.org/show_bug.cgi?id=23328
486 Upstream remaining files from platform/chromium/
488 * platform/chromium/CursorChromium.cpp:
489 (WebCore::pointerCursor):
490 (WebCore::crossCursor):
491 (WebCore::handCursor):
492 (WebCore::iBeamCursor):
493 (WebCore::waitCursor):
494 (WebCore::helpCursor):
495 (WebCore::eastResizeCursor):
496 (WebCore::northResizeCursor):
497 (WebCore::northEastResizeCursor):
498 (WebCore::northWestResizeCursor):
499 (WebCore::southResizeCursor):
500 (WebCore::southEastResizeCursor):
501 (WebCore::southWestResizeCursor):
502 (WebCore::westResizeCursor):
503 (WebCore::northSouthResizeCursor):
504 (WebCore::eastWestResizeCursor):
505 (WebCore::northEastSouthWestResizeCursor):
506 (WebCore::northWestSouthEastResizeCursor):
507 (WebCore::columnResizeCursor):
508 (WebCore::rowResizeCursor):
509 (WebCore::middlePanningCursor):
510 (WebCore::eastPanningCursor):
511 (WebCore::northPanningCursor):
512 (WebCore::northEastPanningCursor):
513 (WebCore::northWestPanningCursor):
514 (WebCore::southPanningCursor):
515 (WebCore::southEastPanningCursor):
516 (WebCore::southWestPanningCursor):
517 (WebCore::westPanningCursor):
518 (WebCore::moveCursor):
519 (WebCore::verticalTextCursor):
520 (WebCore::cellCursor):
521 (WebCore::contextMenuCursor):
522 (WebCore::aliasCursor):
523 (WebCore::progressCursor):
524 (WebCore::noDropCursor):
525 (WebCore::copyCursor):
526 (WebCore::noneCursor):
527 (WebCore::notAllowedCursor):
528 (WebCore::zoomInCursor):
529 (WebCore::zoomOutCursor):
530 * platform/chromium/DragDataRef.h: Added.
531 * platform/chromium/DragImageChromium.cpp: Added.
532 (WebCore::dragImageSize):
533 (WebCore::deleteDragImage):
534 (WebCore::scaleDragImage):
535 (WebCore::dissolveDragImageToFraction):
536 (WebCore::createDragImageFromImage):
537 (WebCore::createDragImageIconForCachedImage):
538 * platform/chromium/DragImageRef.h:
539 * platform/chromium/KeyCodeConversion.h: Added.
540 * platform/chromium/KeyCodeConversionGtk.cpp: Added.
541 (WebCore::windowsKeyCodeForKeyEvent):
542 * platform/chromium/KeyboardCodes.h: Added.
543 * platform/chromium/KeyboardCodesPosix.h: Added.
545 * platform/chromium/KeyboardCodesWin.h: Added.
547 * platform/chromium/Language.cpp: Added.
548 (WebCore::defaultLanguage):
549 * platform/chromium/LinkHashChromium.cpp: Added.
550 (WebCore::visitedLinkHash):
551 * platform/chromium/MimeTypeRegistryChromium.cpp: Added.
552 (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
553 (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
554 (WebCore::MIMETypeRegistry::getMIMETypeForPath):
555 (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
556 (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
557 (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
558 (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
559 (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
560 (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
561 (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
562 (WebCore::dummyHashSet):
563 (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
564 (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
565 (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
566 (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
567 (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
568 * platform/chromium/PasteboardChromium.cpp: Added.
569 (WebCore::Pasteboard::generalPasteboard):
570 (WebCore::Pasteboard::Pasteboard):
571 (WebCore::Pasteboard::clear):
572 (WebCore::Pasteboard::writeSelection):
573 (WebCore::Pasteboard::writeURL):
574 (WebCore::Pasteboard::writeImage):
575 (WebCore::Pasteboard::canSmartReplace):
576 (WebCore::Pasteboard::plainText):
577 (WebCore::Pasteboard::documentFragment):
578 * platform/chromium/PasteboardPrivate.h:
579 * platform/chromium/PlatformCursor.h: Added.
580 (WebCore::PlatformCursor::):
581 (WebCore::PlatformCursor::PlatformCursor):
582 (WebCore::PlatformCursor::customImage):
583 (WebCore::PlatformCursor::hotSpot):
584 (WebCore::PlatformCursor::type):
585 * platform/chromium/PlatformKeyboardEventChromium.cpp: Added.
586 (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
587 (WebCore::PlatformKeyboardEvent::currentCapsLockState):
588 * platform/chromium/PlatformScreenChromium.cpp: Added.
589 (WebCore::screenDepth):
590 (WebCore::screenDepthPerComponent):
591 (WebCore::screenIsMonochrome):
592 (WebCore::screenRect):
593 (WebCore::screenAvailableRect):
594 * platform/chromium/PlatformWidget.h:
595 * platform/chromium/PopupMenuChromium.cpp: Added.
596 (WebCore::PopupListBox::selectedIndex):
597 (WebCore::PopupListBox::numItems):
598 (WebCore::PopupListBox::setBaseWidth):
599 (WebCore::PopupListBox::setTextOnIndexChange):
600 (WebCore::PopupListBox::setAcceptOnAbandon):
601 (WebCore::PopupListBox::):
602 (WebCore::PopupListBox::ListItem::ListItem):
603 (WebCore::PopupListBox::PopupListBox):
604 (WebCore::PopupListBox::~PopupListBox):
605 (WebCore::PopupListBox::disconnectClient):
606 (WebCore::PopupListBox::scrollToRevealSelection):
607 (WebCore::constructRelativeMouseEvent):
608 (WebCore::constructRelativeWheelEvent):
609 (WebCore::PopupContainer::create):
610 (WebCore::PopupContainer::PopupContainer):
611 (WebCore::PopupContainer::~PopupContainer):
612 (WebCore::PopupContainer::showPopup):
613 (WebCore::PopupContainer::hidePopup):
614 (WebCore::PopupContainer::layout):
615 (WebCore::PopupContainer::handleMouseDownEvent):
616 (WebCore::PopupContainer::handleMouseMoveEvent):
617 (WebCore::PopupContainer::handleMouseReleaseEvent):
618 (WebCore::PopupContainer::handleWheelEvent):
619 (WebCore::PopupContainer::handleKeyEvent):
620 (WebCore::PopupContainer::hide):
621 (WebCore::PopupContainer::paint):
622 (WebCore::PopupContainer::paintBorder):
623 (WebCore::PopupContainer::isInterestedInEventForKey):
624 (WebCore::PopupContainer::show):
625 (WebCore::PopupContainer::setTextOnIndexChange):
626 (WebCore::PopupContainer::setAcceptOnAbandon):
627 (WebCore::PopupContainer::refresh):
628 (WebCore::PopupListBox::handleMouseDownEvent):
629 (WebCore::PopupListBox::handleMouseMoveEvent):
630 (WebCore::PopupListBox::handleMouseReleaseEvent):
631 (WebCore::PopupListBox::handleWheelEvent):
632 (WebCore::PopupListBox::isInterestedInEventForKey):
633 (WebCore::PopupListBox::handleKeyEvent):
634 (WebCore::PopupListBox::hostWindow):
635 (WebCore::PopupListBox::invalidateRect):
636 (WebCore::stripLeadingWhiteSpace):
637 (WebCore::PopupListBox::typeAheadFind):
638 (WebCore::PopupListBox::paint):
639 (WebCore::PopupListBox::paintRow):
640 (WebCore::PopupListBox::getRowFont):
641 (WebCore::PopupListBox::abandon):
642 (WebCore::PopupListBox::pointToRowIndex):
643 (WebCore::PopupListBox::acceptIndex):
644 (WebCore::PopupListBox::selectIndex):
645 (WebCore::PopupListBox::setOriginalIndex):
646 (WebCore::PopupListBox::getRowHeight):
647 (WebCore::PopupListBox::getRowBounds):
648 (WebCore::PopupListBox::invalidateRow):
649 (WebCore::PopupListBox::scrollToRevealRow):
650 (WebCore::PopupListBox::isSelectableItem):
651 (WebCore::PopupListBox::adjustSelectedIndex):
652 (WebCore::PopupListBox::updateFromElement):
653 (WebCore::PopupListBox::layout):
654 (WebCore::PopupListBox::clear):
655 (WebCore::PopupListBox::isPointInBounds):
656 (WebCore::PopupMenu::PopupMenu):
657 (WebCore::PopupMenu::~PopupMenu):
658 (WebCore::PopupMenu::show):
659 (WebCore::PopupMenu::hide):
660 (WebCore::PopupMenu::updateFromElement):
661 (WebCore::PopupMenu::itemWritingDirectionIsNatural):
662 * platform/chromium/PopupMenuChromium.h: Added.
663 (WebCore::PopupContainer::listBox):
664 * platform/chromium/PopupMenuPrivate.h: Added.
665 * platform/chromium/SSLKeyGeneratorChromium.cpp: Added.
666 (WebCore::supportedKeySizes):
667 * platform/chromium/ScrollbarThemeChromium.cpp: Added.
668 (WebCore::ScrollbarTheme::nativeTheme):
669 (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
670 (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
671 (WebCore::ScrollbarThemeChromium::themeChanged):
672 (WebCore::ScrollbarThemeChromium::hasThumb):
673 (WebCore::ScrollbarThemeChromium::backButtonRect):
674 (WebCore::ScrollbarThemeChromium::forwardButtonRect):
675 (WebCore::ScrollbarThemeChromium::trackRect):
676 (WebCore::ScrollbarThemeChromium::paintTrackBackground):
677 (WebCore::ScrollbarThemeChromium::paintTickmarks):
678 (WebCore::ScrollbarThemeChromium::paintScrollCorner):
679 (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb):
680 (WebCore::ScrollbarThemeChromium::buttonSize):
681 * platform/chromium/ScrollbarThemeChromium.h: Added.
682 (WebCore::ScrollbarThemeChromium::hasButtons):
683 * platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
684 (WebCore::ScrollbarThemeChromium::scrollbarThickness):
685 (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
686 (WebCore::initMozState):
687 (WebCore::paintScrollbarWidget):
688 (WebCore::ScrollbarThemeChromium::paintTrackPiece):
689 (WebCore::ScrollbarThemeChromium::paintButton):
690 (WebCore::ScrollbarThemeChromium::paintThumb):
691 * platform/chromium/ScrollbarThemeChromiumWin.cpp:
692 * platform/chromium/SearchPopupMenuChromium.cpp: Added.
693 (WebCore::SearchPopupMenu::SearchPopupMenu):
694 (WebCore::SearchPopupMenu::enabled):
695 (WebCore::SearchPopupMenu::saveRecentSearches):
696 (WebCore::SearchPopupMenu::loadRecentSearches):
697 * platform/chromium/SharedTimerChromium.cpp: Added.
698 (WebCore::setSharedTimerFiredFunction):
699 (WebCore::setSharedTimerFireTime):
700 (WebCore::stopSharedTimer):
701 * platform/chromium/TemporaryLinkStubs.cpp: Added.
702 (WebCore::signedPublicKeyAndChallengeString):
703 (WebCore::getSupportedKeySizes):
704 (WebCore::KURL::fileSystemPath):
705 (WebCore::SharedBuffer::createWithContentsOfFile):
706 (WTF::scheduleDispatchFunctionsOnMainThread):
708 2009-01-14 Darin Fisher <darin@chromium.org>
710 Reviewed by Eric Seidel.
712 https://bugs.webkit.org/show_bug.cgi?id=23323
713 Upstream platform/text/chromium/
715 * platform/text/chromium: Added.
716 * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added.
717 (WebCore::currentTextBreakLocaleID):
719 2009-01-14 Steve Falkenburg <sfalken@apple.com>
721 Update copyright year in version resources.
723 Reviewed by Adam Roben.
725 * WebCore.vcproj/QTMovieWin.rc:
727 2009-01-14 Darin Fisher <darin@chromium.org>
729 Reviewed by Darin Adler.
731 https://bugs.webkit.org/show_bug.cgi?id=23324
732 Move platform/chromium/EditorChromium.cpp into editing/chromium/
734 * editing/chromium: Added.
735 * editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
736 * platform/chromium/EditorChromium.cpp: Removed.
738 2009-01-14 Darin Fisher <darin@chromium.org>
740 Reviewed by Darin Adler.
742 https://bugs.webkit.org/show_bug.cgi?id=23320
743 Make it possible to use notImplemented outside of the WebCore namespace
745 * platform/NotImplemented.h:
747 2009-01-14 Nigel Tao <nigel.tao.gnome@gmail.com>
749 Reviewed by Darin Adler.
751 - fix https://bugs.webkit.org/show_bug.cgi?id=22476
752 Check that the document's SecurityOrigin canLoadLocalResources,
753 when pages try to put NSFilenamesPboardtype data on the clipboard,
754 by calling event.dataTransfer.setData('URL', 'file:///foo/bar');
756 Tests: http/tests/security/dataTransfer-set-data-file-url.html
757 platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html
759 * platform/mac/ClipboardMac.mm:
760 (WebCore::ClipboardMac::setData):
762 2009-01-14 Dan Bernstein <mitz@apple.com>
764 Reviewed by John Sullivan.
770 2009-01-14 Alexey Proskuryakov <ap@webkit.org>
772 Reviewed by Darin Adler.
774 https://bugs.webkit.org/show_bug.cgi?id=23316
775 Application cache updating always fails with an assertion
777 Test: http/tests/appcache/update-cache.html
779 * loader/appcache/ApplicationCacheGroup.cpp:
780 (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where
781 multiple caches survive the last DocumentLoader destruction, preventing a crash in release
783 (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
785 2009-01-14 Alexey Proskuryakov <ap@webkit.org>
789 * loader/appcache/ApplicationCacheStorage.cpp:
790 (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.
792 2009-01-13 Alexey Proskuryakov <ap@webkit.org>
794 Reviewed by Anders Carlsson.
796 Test: http/tests/appcache/xhr-foreign-resource.html
798 https://bugs.webkit.org/show_bug.cgi?id=23256
799 Implement application cache foreign entries
801 * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
802 Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
804 * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
805 If a document that was loaded from appcache should be associated with a different cache,
806 mark the resource as foreign in the original cache and start over.
808 * loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType):
809 This function can now be called after a cache is stored, so it no longer asserts the opposite.
811 * loader/appcache/ApplicationCacheStorage.cpp:
812 (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore
813 in-memory caches that were already rejected.
814 (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
815 (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of
816 an already stored cached resource.
818 * loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
820 2009-01-13 Mark Rowe <mrowe@apple.com>
822 Fix the Tiger WebCore build after r39880.
824 * editing/Editor.cpp:
825 (WebCore::Editor::markBadGrammar):
826 * loader/mac/DocumentLoaderMac.cpp:
827 (WebCore::DocumentLoader::schedule):
828 (WebCore::DocumentLoader::unschedule):
829 * platform/mac/PasteboardMac.mm:
830 (WebCore::Pasteboard::writeSelection):
831 * platform/mac/WebCoreObjCExtras.mm:
832 (WebCoreObjCFinalizeOnMainThread):
833 * platform/network/mac/ResourceHandleMac.mm:
834 (WebCore::ResourceHandle::schedule):
835 (WebCore::ResourceHandle::unschedule):
837 2009-01-13 Darin Adler <darin@apple.com>
839 Reviewed by Sam Weinig.
841 Bug 23102: turn on unused parameter warnings in WebCore
842 https://bugs.webkit.org/show_bug.cgi?id=23102
844 Last step: Turn on the warning and fix the last few instances.
846 * Configurations/Base.xcconfig: Removed -Wno-unused-parameter from
847 WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
849 * bindings/js/JSDOMWindowBase.cpp:
850 (jsDOMWindowBaseMessageChannel): Separate the version for use when
851 CHANNEL_MESSAGING is turned off, so we can omit the argument names.
852 It would be better to not even have this property in that case,
853 rather than having the function return undefined, but I don't know
854 how to do that with the bindings script.
856 * bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in
857 functions where they're not used (the SVG context, and the property
858 name in the index getter). Use UNUSED_PARAM where arguments are
861 * bridge/runtime_object.cpp:
862 (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
864 * css/MediaQueryEvaluator.cpp:
865 (WebCore::animationMediaFeatureEval): Omit argument names for style and frame.
866 (WebCore::transitionMediaFeatureEval): Ditto.
867 (WebCore::transform_2dMediaFeatureEval): Ditto.
868 (WebCore::transform_3dMediaFeatureEval): Ditto.
870 * dom/make_names.pl: Leave out the createdByParser property name in
871 cases where it's not used.
873 * inspector/JavaScriptDebugServer.cpp:
874 (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the
875 version for the Mac platform so we can omit the argument names.
877 * loader/EmptyClients.h:
878 (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
880 * loader/FrameLoaderClient.h:
881 (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out
884 * loader/icon/IconFetcher.cpp:
885 (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED.
886 (WebCore::IconFetcher::didReceiveData): Ditto.
887 (WebCore::IconFetcher::didFinishLoading): Ditto.
888 (WebCore::IconFetcher::didFail): Ditto.
891 (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so
892 we can omit the argument names.
894 * platform/Timer.cpp:
895 (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
897 * platform/graphics/GlyphBuffer.h:
898 (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case.
899 (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
901 * platform/graphics/cg/ImageSourceCG.cpp:
902 (WebCore::ImageSource::clear): Removed argument name.
904 * rendering/SVGRenderSupport.cpp:
905 (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS
907 (WebCore::finishRenderSVGContent): Ditto.
909 2009-01-13 Chris Marrin <cmarrin@apple.com>
911 Reviewed by Darin Adler.
913 Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
914 Simple fix to convertToLength to catch style==null cases
916 * css/CSSStyleSelector.cpp:
917 (WebCore::convertToLength):
919 2009-01-13 Eric Seidel <eric@webkit.org>
921 Reviewed by Mark Rowe.
923 Speculative fix for an Uninitialized Memory Read (UMR)
924 seen by purify in chormium's equivalent V8 file.
926 * bindings/js/JSSVGPODTypeWrapper.h:
927 (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
929 2009-01-13 Dimitri Glazkov <dglazkov@chromium.org>
931 Reviewed by Eric Seidel.
933 Land portions of platform/graphics/chromium.
934 https://bugs.webkit.org/show_bug.cgi?id=23297
936 * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
937 (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
938 (WebCore::FontCustomPlatformData::fontPlatformData):
939 (WebCore::EOTStream::EOTStream):
940 (WebCore::EOTStream::read):
941 (WebCore::readEmbedProc):
942 (WebCore::createUniqueFontName):
943 (WebCore::createFontCustomPlatformData):
944 * platform/graphics/chromium/FontCustomPlatformData.h: Added.
945 (WebCore::FontCustomPlatformData::FontCustomPlatformData):
946 * platform/graphics/chromium/FontLinux.cpp: Added.
947 (WebCore::Font::drawGlyphs):
948 (WebCore::Font::drawComplexText):
949 (WebCore::Font::floatWidthForComplexText):
950 (WebCore::Font::offsetForPositionForComplexText):
951 (WebCore::Font::selectionRectForComplexText):
952 * platform/graphics/chromium/FontPlatformData.h: Added.
954 2009-01-13 Mark Rowe <mrowe@apple.com>
956 Rubber-stamped by Oliver Hunt.
958 Don't copy DOMStringList.idl into the framework bundle.
960 * WebCore.xcodeproj/project.pbxproj:
962 2009-01-13 Christian Dywan <christian@twotoasts.de>
964 Build fix, StorageEvent is only defined if we have DOM_STORAGE
967 (WebCore::Document::createEvent): Conditionalize StorageEvent
969 2009-01-13 Darin Adler <darin@apple.com>
971 Reviewed by Adele Peterson.
973 Bug 23277: space bar scrolls the page when typed in any text field
974 https://bugs.webkit.org/show_bug.cgi?id=23277
975 rdar://problem/6490249
977 There's already a regression test for this, since bug 16421 was the same problem, but on
978 Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
980 This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
981 a text input event from being generated at all. That difference may in itself be a bug, but
982 the only symptom is that you get text input events in more cases on platforms other than Mac.
984 * page/EventHandler.cpp:
985 (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was
986 handled, not the result of the dispatchEvent function, which indicates only whether the
987 default behavior was prevented, not if the default behavior did some insertion. This fix
988 makes it so the keyboard event handler can detect that no space was inserted and know that
989 the space bar keypress event can be treated as a scrolling command.
990 (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the
991 keydown event. Without the change above, making this change would have restored the old
992 behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
994 2009-01-13 Darin Fisher <darin@chromium.org>
996 Reviewed by Eric Seidel.
998 Landing portions of platform/chromium/, taken from here:
999 http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
1001 * platform/chromium/ChromiumBridge.h: Added.
1002 * platform/chromium/ChromiumDataObject.cpp: Added.
1003 (WebCore::ChromiumDataObject::clear):
1004 (WebCore::ChromiumDataObject::hasData):
1005 * platform/chromium/ChromiumDataObject.h: Added.
1006 (WebCore::ChromiumDataObject::create):
1007 (WebCore::ChromiumDataObject::ChromiumDataObject):
1008 * platform/chromium/ClipboardChromium.cpp: Added.
1010 (WebCore::clipboardTypeFromMIMEType):
1011 (WebCore::ClipboardChromium::ClipboardChromium):
1012 (WebCore::ClipboardChromium::create):
1013 (WebCore::ClipboardChromium::clearData):
1014 (WebCore::ClipboardChromium::clearAllData):
1015 (WebCore::ClipboardChromium::getData):
1016 (WebCore::ClipboardChromium::setData):
1017 (WebCore::ClipboardChromium::types):
1018 (WebCore::ClipboardChromium::setDragImage):
1019 (WebCore::ClipboardChromium::setDragImageElement):
1020 (WebCore::ClipboardChromium::createDragImage):
1021 (WebCore::imageToMarkup):
1022 (WebCore::getCachedImage):
1023 (WebCore::writeImageToDataObject):
1024 (WebCore::ClipboardChromium::declareAndWriteDragImage):
1025 (WebCore::ClipboardChromium::writeURL):
1026 (WebCore::ClipboardChromium::writeRange):
1027 (WebCore::ClipboardChromium::hasData):
1028 * platform/chromium/ClipboardChromium.h: Added.
1029 (WebCore::ClipboardChromium::~ClipboardChromium):
1030 (WebCore::ClipboardChromium::dataObject):
1031 * platform/chromium/ClipboardUtilitiesChromium.cpp: Added.
1032 (WebCore::replaceNewlinesWithWindowsStyleNewlines):
1033 (WebCore::replaceNBSPWithSpace):
1034 (WebCore::urlToMarkup):
1035 * platform/chromium/ClipboardUtilitiesChromium.h: Added.
1036 * platform/chromium/ContextMenuChromium.cpp: Added.
1037 (WebCore::ContextMenu::ContextMenu):
1038 (WebCore::ContextMenu::~ContextMenu):
1039 (WebCore::ContextMenu::itemCount):
1040 (WebCore::ContextMenu::insertItem):
1041 (WebCore::ContextMenu::appendItem):
1042 (WebCore::ContextMenu::itemWithAction):
1043 (WebCore::ContextMenu::itemAtIndex):
1044 (WebCore::ContextMenu::setPlatformDescription):
1045 (WebCore::ContextMenu::platformDescription):
1046 (WebCore::ContextMenu::releasePlatformDescription):
1047 * platform/chromium/ContextMenuItemChromium.cpp: Added.
1048 (WebCore::ContextMenuItem::ContextMenuItem):
1049 (WebCore::ContextMenuItem::~ContextMenuItem):
1050 (WebCore::ContextMenuItem::releasePlatformDescription):
1051 (WebCore::ContextMenuItem::type):
1052 (WebCore::ContextMenuItem::action):
1053 (WebCore::ContextMenuItem::title):
1054 (WebCore::ContextMenuItem::platformSubMenu):
1055 (WebCore::ContextMenuItem::setType):
1056 (WebCore::ContextMenuItem::setAction):
1057 (WebCore::ContextMenuItem::setTitle):
1058 (WebCore::ContextMenuItem::setSubMenu):
1059 (WebCore::ContextMenuItem::setChecked):
1060 (WebCore::ContextMenuItem::setEnabled):
1061 (WebCore::ContextMenuItem::enabled):
1062 * platform/chromium/CursorChromium.cpp: Added.
1063 (WebCore::Cursor::Cursor):
1064 (WebCore::Cursor::~Cursor):
1065 (WebCore::Cursor::operator=):
1066 (WebCore::pointerCursor):
1067 (WebCore::crossCursor):
1068 (WebCore::handCursor):
1069 (WebCore::iBeamCursor):
1070 (WebCore::waitCursor):
1071 (WebCore::helpCursor):
1072 (WebCore::eastResizeCursor):
1073 (WebCore::northResizeCursor):
1074 (WebCore::northEastResizeCursor):
1075 (WebCore::northWestResizeCursor):
1076 (WebCore::southResizeCursor):
1077 (WebCore::southEastResizeCursor):
1078 (WebCore::southWestResizeCursor):
1079 (WebCore::westResizeCursor):
1080 (WebCore::northSouthResizeCursor):
1081 (WebCore::eastWestResizeCursor):
1082 (WebCore::northEastSouthWestResizeCursor):
1083 (WebCore::northWestSouthEastResizeCursor):
1084 (WebCore::columnResizeCursor):
1085 (WebCore::rowResizeCursor):
1086 (WebCore::middlePanningCursor):
1087 (WebCore::eastPanningCursor):
1088 (WebCore::northPanningCursor):
1089 (WebCore::northEastPanningCursor):
1090 (WebCore::northWestPanningCursor):
1091 (WebCore::southPanningCursor):
1092 (WebCore::southEastPanningCursor):
1093 (WebCore::southWestPanningCursor):
1094 (WebCore::westPanningCursor):
1095 (WebCore::moveCursor):
1096 (WebCore::verticalTextCursor):
1097 (WebCore::cellCursor):
1098 (WebCore::contextMenuCursor):
1099 (WebCore::aliasCursor):
1100 (WebCore::progressCursor):
1101 (WebCore::noDropCursor):
1102 (WebCore::copyCursor):
1103 (WebCore::noneCursor):
1104 (WebCore::notAllowedCursor):
1105 (WebCore::zoomInCursor):
1106 (WebCore::zoomOutCursor):
1107 (WebCore::grabCursor):
1108 (WebCore::grabbingCursor):
1109 * platform/chromium/DragDataChromium.cpp: Added.
1110 (WebCore::containsHTML):
1111 (WebCore::DragData::createClipboard):
1112 (WebCore::DragData::containsURL):
1113 (WebCore::DragData::asURL):
1114 (WebCore::DragData::containsFiles):
1115 (WebCore::DragData::asFilenames):
1116 (WebCore::DragData::containsPlainText):
1117 (WebCore::DragData::asPlainText):
1118 (WebCore::DragData::containsColor):
1119 (WebCore::DragData::canSmartReplace):
1120 (WebCore::DragData::containsCompatibleContent):
1121 (WebCore::DragData::asFragment):
1122 (WebCore::DragData::asColor):
1123 * platform/chromium/EditorChromium.cpp: Added.
1124 (WebCore::Editor::newGeneralClipboard):
1125 * platform/chromium/FileChooserChromium.cpp: Added.
1126 (WebCore::FileChooser::basenameForWidth):
1127 * platform/chromium/FileSystemChromium.cpp: Added.
1128 (WebCore::deleteFile):
1129 (WebCore::deleteEmptyDirectory):
1130 (WebCore::getFileSize):
1131 (WebCore::getFileModificationTime):
1132 (WebCore::directoryName):
1133 (WebCore::pathByAppendingComponent):
1134 (WebCore::makeAllDirectories):
1135 (WebCore::fileExists):
1136 * platform/chromium/FileSystemChromiumLinux.cpp: Added.
1137 (WebCore::pathGetFileName):
1138 * platform/chromium/FileSystemChromiumMac.mm: Added.
1139 (WebCore::pathGetFileName):
1140 * platform/chromium/FileSystemChromiumWin.cpp: Added.
1141 (WebCore::pathGetFileName):
1142 * platform/chromium/FramelessScrollView.cpp: Added.
1143 (WebCore::FramelessScrollView::~FramelessScrollView):
1144 (WebCore::FramelessScrollView::invalidateScrollbarRect):
1145 (WebCore::FramelessScrollView::isActive):
1146 (WebCore::FramelessScrollView::invalidateRect):
1147 (WebCore::FramelessScrollView::hostWindow):
1148 (WebCore::FramelessScrollView::windowClipRect):
1149 (WebCore::FramelessScrollView::paintContents):
1150 (WebCore::FramelessScrollView::contentsResized):
1151 (WebCore::FramelessScrollView::visibleContentsResized):
1152 * platform/chromium/FramelessScrollView.h: Added.
1153 (WebCore::FramelessScrollView::FramelessScrollView):
1154 (WebCore::FramelessScrollView::client):
1155 (WebCore::FramelessScrollView::setClient):
1156 * platform/chromium/FramelessScrollViewClient.h: Added.
1157 * platform/chromium/ScrollbarThemeChromiumWin.cpp: Added.
1159 (WebCore::ScrollbarThemeChromium::scrollbarThickness):
1160 (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
1161 (WebCore::ScrollbarThemeChromium::paintTrackPiece):
1162 (WebCore::ScrollbarThemeChromium::paintButton):
1163 (WebCore::ScrollbarThemeChromium::paintThumb):
1164 (WebCore::ScrollbarThemeChromium::getThemeState):
1165 (WebCore::ScrollbarThemeChromium::getThemeArrowState):
1166 (WebCore::ScrollbarThemeChromium::getClassicThemeState):
1167 * platform/chromium/SoundChromiumPosix.cpp: Added.
1168 (WebCore::systemBeep):
1169 * platform/chromium/SoundChromiumWin.cpp: Added.
1170 (WebCore::systemBeep):
1171 * platform/chromium/SystemTimeChromium.cpp: Added.
1172 (WebCore::currentTime):
1173 (WebCore::userIdleTime):
1174 * platform/chromium/WidgetChromium.cpp: Added.
1175 (WebCore::Widget::Widget):
1176 (WebCore::Widget::~Widget):
1177 (WebCore::Widget::show):
1178 (WebCore::Widget::hide):
1179 (WebCore::Widget::setCursor):
1180 (WebCore::Widget::paint):
1181 (WebCore::Widget::setFocus):
1182 (WebCore::Widget::setIsSelected):
1183 (WebCore::Widget::frameRect):
1184 (WebCore::Widget::setFrameRect):
1185 * platform/chromium/WindowsVersion.cpp: Added.
1186 (WebCore::isVistaOrNewer):
1187 * platform/chromium/WindowsVersion.h: Added.
1189 2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
1191 Reviewed by Simon Hausmann.
1193 [Qt] Make sure media elements dispatch the 'loaded' event
1195 We assume that when Phonon goes into paused state that we have the
1196 complete media file. Once we do media loading ourselves we can
1197 distinguish between loading the first frame and the complete media.
1199 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1200 (WebCore::MediaPlayerPrivate::updateStates):
1202 2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
1204 Reviewed by Simon Hausmann.
1206 [Qt] Add more verbose error output when loading NPAPI plugins
1208 * plugins/qt/PluginPackageQt.cpp:
1209 (WebCore::PluginPackage::load):
1211 2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
1213 Reviewed by Tor Arne Vestbø.
1215 Fix crash in the Qt port when deleting a popup from within a
1216 JavaScript onchange handler.
1218 * platform/qt/QWebPopup.cpp:
1219 (WebCore::QWebPopup::QWebPopup): Perform the activation of the
1220 combobox item (i.e. the call to the JS handler) from a different
1221 call stack by using a queued connection.
1223 2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
1225 Reviewed by Tor Arne Vestbø.
1227 [GIO] Make sure to untef the GFile and the GInputStream on destruction
1229 Make sure to call cleanupGioOperation from the ResourceHandleInternal
1230 d'tor. Change the signature of cleanupGioOperation so we can do the
1231 cleanup of GIO next to the cleanup of SOUP.
1233 This is happening with many tests from dom/html/level2/html e.g.
1234 LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
1236 * platform/network/soup/ResourceHandleSoup.cpp:
1237 (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1238 (WebCore::cleanupGioOperation):
1239 (WebCore::closeCallback):
1240 (WebCore::readCallback):
1241 (WebCore::openCallback):
1242 (WebCore::queryInfoCallback):
1244 2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
1246 Reviewed by Tor Arne Vestbø.
1248 [GIO] Attach the ResourceHandle to the GObject and get it from the GObject
1250 https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
1252 Sometimes it is not possible to cancel a pending GIO operation and the
1253 callback might be invoked with a pointer to an already destructed
1254 ResourceHandle. To avoid this issue we will attach the ResourceHandle
1255 to the GObject* and in the callback attempt to get the ResourceHandle
1256 from the GObject*. If no ResourceHandle is attached we silently fail
1257 as the cleanup has been already done.
1259 This is happening with many tests from dom/html/level2/html e.g.
1260 LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
1262 * platform/network/soup/ResourceHandleSoup.cpp:
1263 (WebCore::cleanupGioOperation):
1264 (WebCore::closeCallback):
1265 (WebCore::readCallback):
1266 (WebCore::openCallback):
1267 (WebCore::queryInfoCallback):
1268 (WebCore::ResourceHandle::startGio):
1270 2009-01-12 Holger Hans Peter Freyther <zecke@selfish.org>
1272 Reviewed by Tor Arne Vestbø.
1274 [GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
1276 https://bugs.webkit.org/show_bug.cgi?id=23116
1278 The ResourceHandle becomes invalid (e.g. got destructed) from within
1279 the invocation of didFail. Avoid this by cleaning up everything before
1280 calling didFail and simply return afterwards.
1282 This is happening with many tests from dom/html/level2/html e.g.
1283 LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
1285 * platform/network/soup/ResourceHandleSoup.cpp:
1286 (WebCore::readCallback):
1287 (WebCore::openCallback):
1288 (WebCore::queryInfoCallback):
1290 2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
1292 Reviewed by Simon Hausmann.
1294 Change how themes adjust mediaControls.css to match html4/quicks.css
1296 Instead of providing the full style sheet, the themes provide extra
1297 overrides to the default style defined in UserAgentStyleSheetsData.
1299 https://bugs.webkit.org/show_bug.cgi?id=23210
1301 Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
1302 build time for the Qt port.
1304 * Resources/WebKitResources.qrc: Removed. Merged into WebCore.qrc
1306 * WebCore.qrc: Added.
1307 * css/CSSStyleSelector.cpp:
1308 (WebCore::CSSStyleSelector::styleForElement):
1309 * css/qt/mediaControls-extras.css: Rename from html4-adjustments-qt.css
1310 * platform/qt/RenderThemeQt.cpp:
1311 (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
1312 * platform/qt/RenderThemeQt.h:
1313 * platform/qt/WebCoreResources.qrc: Removed.
1314 * platform/qt/html4-adjustments-qt.css: Rename to mediaControls-extras.css
1315 * rendering/RenderTheme.cpp:
1316 * rendering/RenderTheme.h:
1317 (WebCore::RenderTheme::extraMediaControlsStyleSheet):
1319 2009-01-12 Gavin Barraclough <barraclough@apple.com>
1321 Reviewed by Oliver Hunt.
1323 Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
1325 * bindings/js/JSSQLTransactionCustom.cpp:
1326 (WebCore::JSSQLTransaction::executeSql):
1327 * bindings/objc/WebScriptObject.mm:
1328 (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
1330 2009-01-12 Chris Marrin <cmarrin@apple.com>
1332 Reviewed by Dan Bernstein.
1334 Fixed https://bugs.webkit.org/show_bug.cgi?id=22919
1336 I added a common getElapsedTime() function to AnimationBase which uses a combination of
1337 the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
1340 * page/animation/AnimationBase.cpp:
1341 (WebCore::AnimationBase::progress):
1342 (WebCore::AnimationBase::getElapsedTime):
1343 * page/animation/AnimationBase.h:
1344 * page/animation/KeyframeAnimation.cpp:
1345 (WebCore::KeyframeAnimation::animate):
1347 2009-01-12 Robert Blaut <webkit@blaut.biz>
1349 Reviewed by Darin Adler
1351 Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
1352 Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds
1353 instead of miliseconds
1355 Test: fast/css/webkit-marquee-speed-unit-in-quirksmode.html
1357 * css/CSSParser.cpp:
1358 (WebCore::CSSParser::validUnit): treat unitless values in quirks mode
1359 as miliseconds instead of seconds.
1361 2009-01-12 David Hyatt <hyatt@apple.com>
1363 Apply the same idea as the previous fix but for matched declarations.
1365 Reviewed by Dan Bernstein
1367 * css/CSSStyleSelector.h:
1369 2009-01-12 Brady Eidson <beidson@apple.com>
1371 Reviewed by Darin Adler
1373 <rdar://problem/6468274> - Track Non-get requests in global history
1377 * history/HistoryItem.cpp:
1378 (WebCore::HistoryItem::HistoryItem):
1379 * history/HistoryItem.h:
1380 (WebCore::HistoryItem::lastVisitWasHTTPNonGet):
1381 (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
1383 2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
1385 !ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header
1386 so it can be used by all builds.
1388 * platform/graphics/Font.h:
1389 * platform/graphics/SimpleFontData.cpp:
1390 * svg/SVGFontFaceElement.cpp:
1391 * svg/SVGFontFaceElement.h:
1393 2009-01-12 Kevin Ollivier <kevino@theolliviers.com>
1397 * platform/graphics/wx/TransformationMatrixWx.cpp:
1398 (WebCore::TransformationMatrix::TransformationMatrix):
1400 2009-01-12 David Hyatt <hyatt@apple.com>
1402 Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
1403 elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.
1405 Reviewed by Oliver Hunt
1407 * css/CSSStyleSelector.h:
1409 2009-01-12 David Hyatt <hyatt@apple.com>
1411 Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
1412 two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
1415 Reviewed by Oliver Hunt
1418 (WebCore::Element::attributeChanged):
1420 2009-01-12 David Hyatt <hyatt@apple.com>
1422 Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
1423 default to the normal case. Tiny speedup on PLT.
1425 Reviewed by Oliver Hunt
1427 * rendering/RenderFlow.cpp:
1428 (WebCore::RenderFlow::lineHeight):
1430 2009-01-12 David Hyatt <hyatt@apple.com>
1432 Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
1433 in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
1435 Reviewed by Oliver Hunt
1437 * platform/ScrollView.cpp:
1438 (WebCore::ScrollView::ScrollView):
1440 2009-01-12 Simon Fraser <simon.fraser@apple.com>
1442 Reviewed by Dan Bernstein
1444 https://bugs.webkit.org/show_bug.cgi?id=23273
1446 In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
1447 to be computed in absolute coordintes. Instead, we compute a repaintRect
1448 relative to the RenderObject, which can repaint itself.
1450 * rendering/RenderBox.cpp:
1451 (WebCore::RenderBox::repaintLayerRectsForImage):
1453 2009-01-12 Simon Fraser <simon.fraser@apple.com>
1455 Reviewed by Dan Bernstein
1457 https://bugs.webkit.org/show_bug.cgi?id=23220
1459 Merge layoutDelta into LayoutState. This requires that we
1460 push even when layoutState is disabled, so that layoutDelta
1461 can still be stored.
1463 * rendering/LayoutState.cpp:
1464 (WebCore::LayoutState::LayoutState):
1465 * rendering/LayoutState.h:
1466 (WebCore::LayoutState::LayoutState):
1467 * rendering/RenderBlock.cpp:
1468 (WebCore::RenderBlock::layoutBlock):
1469 (WebCore::RenderBlock::layoutBlockChildren):
1470 (WebCore::RenderBlock::layoutOnlyPositionedObjects):
1471 * rendering/RenderBox.cpp:
1472 (WebCore::RenderBox::localToAbsolute):
1473 (WebCore::RenderBox::absoluteToLocal):
1474 (WebCore::RenderBox::computeAbsoluteRepaintRect):
1475 * rendering/RenderFlexibleBox.cpp:
1476 (WebCore::RenderFlexibleBox::layoutBlock):
1477 * rendering/RenderFlow.cpp:
1478 (WebCore::RenderFlow::absoluteClippedOverflowRect):
1479 * rendering/RenderLayer.cpp:
1480 (WebCore::RenderLayer::updateLayerPositions):
1481 * rendering/RenderTableCell.cpp:
1482 (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
1483 (WebCore::RenderTableCell::localToAbsolute):
1484 * rendering/RenderView.cpp:
1485 (WebCore::RenderView::pushLayoutState):
1486 * rendering/RenderView.h:
1487 (WebCore::RenderView::layoutDelta):
1488 (WebCore::RenderView::addLayoutDelta):
1489 (WebCore::RenderView::doingFullRepaint):
1490 (WebCore::RenderView::pushLayoutState):
1491 (WebCore::RenderView::popLayoutState):
1492 (WebCore::RenderView::layoutStateEnabled):
1493 (WebCore::RenderView::layoutState):
1494 (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
1495 (WebCore::LayoutStateMaintainer::push):
1496 (WebCore::LayoutStateMaintainer::pop):
1497 * rendering/bidi.cpp:
1498 (WebCore::RenderBlock::layoutInlineChildren):
1500 2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
1502 Reviewed by Holger Freyther.
1504 [Qt] Build fix after turning the fontCache to a singleton
1505 https://bugs.webkit.org/show_bug.cgi?id=23253
1507 Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
1509 * platform/graphics/qt/FontCacheQt.cpp:
1510 (WebCore::fontCache):
1511 (WebCore::FontCache::FontCache):
1513 2009-01-12 Eric Roman <eroman@chromium.org>
1515 Reviewed by Darin Adler.
1517 Fix some bugs with Selection::appendTrailingWhitespace().
1518 https://bugs.webkit.org/show_bug.cgi?id=23232
1520 Test: editing/selection/doubleclick-whitespace-crash.html
1522 * editing/Selection.cpp:
1523 (WebCore::makeSearchRange):
1524 (WebCore::Selection::appendTrailingWhitespace):
1526 2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
1528 Reviewed by Eric Seidel.
1530 Add the first pieces of platform/graphics/chromium
1531 https://bugs.webkit.org/show_bug.cgi?id=23257
1533 * platform/graphics/chromium/ColorChromium.cpp: Added.
1534 (WebCore::focusRingColor):
1535 * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
1536 (WebCore::FontCache::platformInit):
1537 (WebCore::isStringASCII):
1538 (WebCore::LookupAltName):
1539 (WebCore::FontCodepage::):
1540 (WebCore::FontCodepage::if):
1541 (WebCore::createFontIndirectAndGetWinName):
1542 (WebCore::fontContainsCharacter):
1543 (WebCore::FontCache::getFontDataForCharacters):
1544 (WebCore::FontCache::alternateFamilyName):
1545 (WebCore::FontCache::getSimilarFontPlatformData):
1546 (WebCore::FontCache::getLastResortFallbackFont):
1547 (WebCore::toGDIFontWeight):
1548 (WebCore::FontCache::getGenericFontForScript):
1549 (WebCore::FillLogFont):
1550 (WebCore::FontCache::fontExists):
1551 (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
1552 (WebCore::traitsInFamilyEnumProc):
1553 (WebCore::FontCache::getTraitsInFamily):
1554 (WebCore::FontCache::createFontPlatformData):
1555 * platform/graphics/chromium/FontCacheLinux.cpp: Added.
1556 (WebCore::FontCache::platformInit):
1557 (WebCore::FontCache::getFontDataForCharacters):
1558 (WebCore::FontCache::alternateFamilyName):
1559 (WebCore::FontCache::getSimilarFontPlatformData):
1560 (WebCore::FontCache::getLastResortFallbackFont):
1561 (WebCore::FontCache::getTraitsInFamily):
1562 (WebCore::FontCache::createFontPlatformData):
1563 (WebCore::FontCache::getGenericFontForScript):
1564 * platform/graphics/chromium/FontChromiumWin.cpp: Added.
1565 (WebCore::windowsCanHandleTextDrawing):
1566 (WebCore::skiaDrawText):
1567 (WebCore::PaintSkiaText):
1568 (WebCore::Font::drawGlyphs):
1569 (WebCore::Font::selectionRectForComplexText):
1570 (WebCore::Font::drawComplexText):
1571 (WebCore::Font::floatWidthForComplexText):
1572 (WebCore::Font::offsetForPositionForComplexText):
1574 2009-01-12 Darin Fisher <darin@chromium.org>
1576 Reviewed by Eric Seidel.
1578 https://bugs.webkit.org/show_bug.cgi?id=23254
1579 Upstream page/chromium/
1581 * page/chromium/AXObjectCacheChromium.cpp: Added.
1582 (WebCore::AXObjectCache::detachWrapper):
1583 (WebCore::AXObjectCache::attachWrapper):
1584 (WebCore::AXObjectCache::postNotification):
1585 (WebCore::AXObjectCache::postNotificationToElement):
1586 (WebCore::AXObjectCache::handleFocusedUIElementChanged):
1587 * page/chromium/AccessibilityObjectChromium.cpp:
1588 * page/chromium/AccessibilityObjectWrapper.h:
1589 * page/chromium/ChromeClientChromium.h: Added.
1590 * page/chromium/DragControllerChromium.cpp: Added.
1591 (WebCore::DragController::dragOperation):
1592 (WebCore::DragController::isCopyKeyDown):
1593 (WebCore::DragController::maxDragImageSize):
1594 (WebCore::DragController::cleanupAfterSystemDrag):
1595 * page/chromium/EventHandlerChromium.cpp: Added.
1596 (WebCore::EventHandler::passMousePressEventToSubframe):
1597 (WebCore::EventHandler::passMouseMoveEventToSubframe):
1598 (WebCore::EventHandler::passMouseReleaseEventToSubframe):
1599 (WebCore::EventHandler::passWheelEventToWidget):
1600 (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
1601 (WebCore::EventHandler::passMouseDownEventToWidget):
1602 (WebCore::EventHandler::tabsToAllControls):
1603 (WebCore::EventHandler::eventActivatedView):
1604 (WebCore::EventHandler::createDraggingClipboard):
1605 (WebCore::EventHandler::focusDocumentView):
1606 (WebCore::EventHandler::accessKeyModifiers):
1607 * page/chromium/FrameChromium.cpp: Added.
1608 (WebCore::computePageRectsForFrame):
1609 (WebCore::Frame::dragImageForSelection):
1610 * page/chromium/FrameChromium.h: Added.
1612 2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
1614 Reviewed by Darin Adler.
1616 https://bugs.webkit.org/show_bug.cgi?id=22936
1617 Fix uninitialized memory read error, reported by Purify.
1619 * platform/graphics/SimpleFontData.cpp:
1620 (WebCore::SimpleFontData::SimpleFontData): Added initializer for
1621 m_unitsPerEm using cDefaultUnitsPerEm constant.
1622 * svg/SVGFontFaceElement.cpp:
1623 (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
1625 * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
1627 2009-01-12 Adam Treat <adam.treat@torchmobile.com>
1629 Reviewed by George Staikos.
1631 Do not set fixedLayoutSize for anything other than the mainframe during
1632 the transition as this is a page level state like the viewportSize.
1634 * loader/FrameLoaderClient.cpp:
1635 (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):
1637 2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
1639 Reviewed by Darin Adler.
1641 Bug 22861: Turn the FontCache into a singleton
1642 https://bugs.webkit.org/show_bug.cgi?id=22861
1644 - Added fontCache() to get the global FontCache.
1646 - Made all the methods in FontCache instance method.
1648 - Changed FontCache:: to fontCache()-> in WebCore.
1650 * WebCore.base.exp: Now export fontCache().
1651 * css/CSSFontFaceSource.cpp:
1652 (WebCore::CSSFontFaceSource::getFontData):
1653 * css/CSSFontSelector.cpp:
1654 (WebCore::CSSFontSelector::CSSFontSelector):
1655 (WebCore::CSSFontSelector::~CSSFontSelector):
1656 (WebCore::CSSFontSelector::addFontFaceRule):
1657 (WebCore::fontDataForGenericFamily):
1658 * platform/graphics/Font.cpp:
1659 (WebCore::Font::glyphDataForCharacter):
1660 * platform/graphics/FontCache.cpp:
1661 (WebCore::fontCache):
1662 (WebCore::FontCache::FontCache):
1663 * platform/graphics/FontCache.h:
1664 * platform/graphics/FontFallbackList.cpp:
1665 (WebCore::FontFallbackList::FontFallbackList):
1666 (WebCore::FontFallbackList::invalidate):
1667 (WebCore::FontFallbackList::releaseFontData):
1668 (WebCore::FontFallbackList::fontDataAt):
1669 (WebCore::FontFallbackList::fontDataForCharacters):
1670 (WebCore::FontFallbackList::setPlatformFont):
1671 * platform/graphics/SimpleFontData.cpp:
1672 (WebCore::SimpleFontData::~SimpleFontData):
1673 * platform/graphics/mac/FontCacheMac.mm:
1674 (WebCore::fontCacheATSNotificationCallback):
1675 * platform/graphics/mac/SimpleFontDataMac.mm:
1676 (WebCore::SimpleFontData::smallCapsFontData):
1677 * platform/graphics/win/FontCacheWin.cpp:
1678 (WebCore::getCJKCodePageMasks):
1679 * platform/graphics/win/SimpleFontDataWin.cpp:
1680 (WebCore::SimpleFontData::containsCharacters):
1682 2009-01-11 Darin Adler <darin@apple.com>
1684 Reviewed by Dan Bernstein.
1686 Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
1687 https://bugs.webkit.org/show_bug.cgi?id=23247
1689 Also fix problems where partially parsed paths will still have an effect
1690 rather than failing parsing and being ignored.
1692 Test: dom/path-segments.html
1694 * platform/graphics/Path.h:
1695 (WebCore::Path::swap): Added.
1697 * svg/SVGParserUtilities.cpp:
1698 (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
1699 (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
1700 (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
1702 (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
1703 not directly into the segment list.
1704 (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
1705 (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
1706 (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
1707 (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
1708 (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
1709 (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
1710 (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
1711 (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
1712 (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
1714 * svg/SVGPathSegCurvetoCubicSmooth.h:
1715 (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
1716 Set y2 to y2, not to y.
1718 2009-01-11 Darin Adler <darin@apple.com>
1720 Reviewed by Oliver Hunt.
1722 Bug 23102: turn on unused parameter warnings in WebCore
1723 https://bugs.webkit.org/show_bug.cgi?id=23102
1725 Fourth step: Remove arguments entirely in the many cases where they are not
1726 needed at all. This step is a little less mechanical than the earlier ones.
1728 * dom/DOMImplementation.cpp:
1729 (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
1730 the regular expression, since we already specify a-zA-Z in our expression.
1733 (WebCore::Document::databaseThread): Don't pass in the document when creating
1737 (WebCore::Element::createRareData): Don't pass the element when creating an
1739 (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
1740 (WebCore::Element::recalcStyle): Ditto.
1742 * dom/ElementRareData.h: Remove the unused Element* from the constructor and
1743 the resetComputedStyle function.
1745 * dom/EventTargetNode.cpp:
1746 (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
1747 (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
1748 (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
1749 * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
1751 * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
1752 (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
1753 start and end arguments.
1754 (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
1755 and end to pushDownTextDecorationStyleAroundNode.
1757 * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
1758 unused start and end arguments from pushDownTextDecorationStyleAroundNode.
1760 * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
1762 * html/HTMLTokenizer.cpp:
1763 (WebCore::Token::addAttribute): Removed unused Document* argument.
1764 (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
1766 * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
1768 * page/DOMWindow.cpp:
1769 (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
1771 * page/DragController.cpp:
1772 (WebCore::DragController::dragIsMove): Removed unused DragData argument.
1773 (WebCore::DragController::performDrag): Call concludeEditDrag rather than
1775 (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
1776 (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
1777 should only be called for edit drags. Removed the action mask argument. Also
1778 changed dragIsMove call sites to not pass dragData.
1780 * page/DragController.h: Updated for above changes and tweaked comment format.
1783 (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
1784 when creating regular expressions for clarity. Call match instead of search,
1785 since both do the same thing except for with negative start offsets, and none
1786 used here are negative.
1787 (WebCore::Frame::matchLabelsAgainstElement): Ditto.
1789 * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
1791 * page/mac/AccessibilityObjectWrapper.mm:
1792 (AXAttributeStringSetHeadingLevel): Removed unused object argument.
1793 (AXAttributedStringAppendText): Ditto.
1794 (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
1796 * page/mac/FrameMac.mm:
1797 (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
1798 when creating regular expressions for clarity. Call match instead of search,
1799 since both do the same thing except for with negative start offsets, and none
1800 used here are negative.
1801 (WebCore::Frame::matchLabelsAgainstElement): Ditto.
1803 * platform/graphics/SegmentedFontData.cpp:
1804 (WebCore::SegmentedFontData::containsCharacter): Added.
1805 (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
1806 instead of just the first one, using containsCharacter.
1808 * platform/graphics/SegmentedFontData.h: Made more members private.
1809 Added containsCharacter function member.
1811 * platform/mac/DragImageMac.mm:
1812 (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
1813 DragImageRef for clarity, since this is platform-specific code.
1814 (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
1816 (WebCore::scaleDragImage): Ditto.
1817 (WebCore::dissolveDragImageToFraction): Ditto.
1818 (WebCore::createDragImageFromImage): Ditto.
1819 (WebCore::createDragImageIconForCachedImage): Ditto.
1821 * platform/mac/WebFontCache.mm:
1822 (acceptableChoice): Removed the unused weight-related arguments.
1823 (betterChoice): Ditto.
1824 (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
1826 * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
1827 because we'd rather get a link error rather than a runtime error if we use it
1828 for anything, and right now it's not used.
1830 * platform/text/RegularExpression.cpp: Removed unused private data,
1831 including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
1832 and lastMatchPos. Made the RegularExpression::Private::regex be private
1833 and use an accessor function to get at it.
1834 (WebCore::RegularExpression::RegularExpression): Removed the const char* version
1835 of the constructor because it's not any more efficient. Changed the boolean
1836 constructor argument to use TextCaseSensitivity instead to make it less likely
1838 (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
1839 just use plain old assignment on it. The only reason we do this instead of using
1840 the compiler generated assignment operator is that we want the Private structure
1841 to be internal to the .cpp file.
1842 (WebCore::RegularExpression::match): Added a null check so we won't crash if
1843 we fail to compile the regular expression. Removed the code to handle multiple
1844 match strings, since that was unused.
1846 * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
1847 TextCaseSensitivity and not have a default value. Removed the default constructor,
1848 and the pattern, match, and pos functions.
1850 * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
1851 Page.h, because we should eventually use it in all the places where we have
1852 an argument to control case sensitivity, starting with the functions in this
1855 * platform/text/mac/ShapeArabic.c:
1856 (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
1857 this is code borrowed from ICU, this seems like a simple safe change to make.
1858 (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
1860 * rendering/RenderPath.cpp:
1861 (WebCore::RenderPath::RenderPath): Removed the unused style argument.
1862 Also removed the type check. The argument already has the correct type,
1863 so it's not helpful to upcast it and then check its type again, unless
1864 we have some reason to believe the type is not reliable. And we don't.
1866 * rendering/RenderPath.h: Removed the RenderStyle* argument to the
1867 constructor. Also removed the explicit declaration of the destructor.
1868 It's not helpful or needed.
1870 * rendering/RenderSVGInlineText.cpp:
1871 (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
1872 make it clear that just returning an empty rect is not a good implementation.
1873 Removed the argument names to get rid of the warning.
1875 * rendering/RenderTreeAsText.cpp:
1876 (WebCore::printBorderStyle): Removed the unused RenderObject argument.
1877 (WebCore::operator<<): Updated for the change to printBorderStyle function.
1879 * storage/DatabaseThread.cpp:
1880 (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
1881 * storage/DatabaseThread.h: Ditto.
1883 * storage/LocalStorage.cpp:
1884 (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
1885 * storage/LocalStorage.h: Ditto.
1887 * svg/SVGElement.cpp:
1888 (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
1889 code location to dispatchGenericEvent.
1890 * svg/SVGElementInstance.cpp:
1891 (WebCore::SVGElementInstance::dispatchEvent): Ditto.
1893 * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
1894 (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
1895 the RenderPath constructor.
1897 * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
1899 * xml/XSLTProcessor.cpp:
1900 (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
1901 (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
1903 2009-01-11 Alexey Proskuryakov <ap@webkit.org>
1905 Reviewed by Darin Adler.
1907 https://bugs.webkit.org/show_bug.cgi?id=23165
1908 Disable application cache dynamic entries support.
1910 * bindings/js/JSDOMApplicationCacheCustom.cpp:
1911 * loader/appcache/DOMApplicationCache.idl:
1913 2009-01-11 Adam Treat <adam.treat@torchmobile.com>
1915 Reviewed by Darin Adler.
1917 Correct coordinate transformation for deeply nested frames on resizing. This
1918 fixes https://bugs.webkit.org/show_bug.cgi?id=20766.
1920 Test: fast/frames/frame-deep-nested-resize.html
1922 * rendering/RenderFrameSet.cpp:
1923 (WebCore::RenderFrameSet::userResize):
1925 2009-01-11 Mark Rowe <mrowe@apple.com>
1927 Tiger build fix. The connection parameter is still used on Tiger in this method.
1929 * platform/network/mac/ResourceHandleMac.mm:
1930 (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1932 2009-01-11 Darin Adler <darin@apple.com>
1934 Reviewed by Dan Bernstein.
1936 Bug 23102: turn on unused parameter warnings in WebCore
1937 https://bugs.webkit.org/show_bug.cgi?id=23102
1939 Third step: Deal with cases of arguments used only in assertions.
1941 * dom/MessagePort.cpp:
1942 (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
1944 (WebCore::Worker::notifyFinished): Ditto.
1945 * dom/XMLTokenizer.cpp:
1946 (WebCore::XMLTokenizer::notifyFinished): Ditto.
1947 * loader/appcache/ApplicationCacheGroup.cpp:
1948 (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
1949 * loader/appcache/ApplicationCacheStorage.cpp:
1950 (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
1951 * loader/icon/IconLoader.cpp:
1952 (WebCore::IconLoader::didReceiveData): Since loader and size are only
1953 used when logging, use UNUSED_PARAM when logging is disabled.
1954 * platform/mac/WidgetMac.mm:
1955 (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
1956 * platform/network/mac/ResourceHandleMac.mm:
1957 (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
1958 argument since it's probably a tiny bit more efficient and gets rid
1959 of the unused argument warning.
1960 * rendering/RenderListMarker.cpp:
1961 (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
1962 * rendering/RenderObject.cpp:
1963 (WebCore::RenderObject::createInlineBox): Ditto.
1964 * rendering/RenderSVGInline.cpp:
1965 (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
1966 I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
1967 the only use for two different arguments.
1968 * rendering/RenderText.cpp:
1969 (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
1970 * rendering/RenderThemeMac.mm:
1971 (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
1973 2009-01-11 Simon Fraser <simon.fraser@apple.com>
1975 Reviewed by Oliver Hunt
1977 https://bugs.webkit.org/show_bug.cgi?id=23242
1979 Fix CanvasRenderingContext2D::transform to do a pre-multiply,
1980 rather than a post-multiply into m_transform. This bug did not affect
1981 drawing, but did cause m_transform to be incorrect, which impacted
1982 willDraw(), and isPointInPath.
1984 Test: fast/canvas/canvas-incremental-repaint-2.html
1986 * html/CanvasRenderingContext2D.cpp:
1987 (WebCore::CanvasRenderingContext2D::transform):
1989 2009-01-11 Darin Adler <darin@apple.com>
1991 Reviewed by Dan Bernstein.
1993 Bug 23102: turn on unused parameter warnings in WebCore
1994 https://bugs.webkit.org/show_bug.cgi?id=23102
1996 Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
1997 That's because you can't omit an argument name in Objective-C methods.
1999 * bindings/objc/DOMObject.mm:
2000 (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
2001 the word "unused" so we don't just start using it without removing the macro.
2002 * bindings/objc/WebScriptObject.mm:
2003 (+[WebUndefined allocWithZone:]): Ditto.
2004 (-[WebUndefined initWithCoder:]): Ditto.
2005 (-[WebUndefined encodeWithCoder:]): Ditto.
2006 (-[WebUndefined copyWithZone:]): Ditto.
2007 * page/mac/WebDashboardRegion.m:
2008 (-[WebDashboardRegion copyWithZone:]): Ditto.
2009 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2010 (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
2011 (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
2012 (-[WebCoreMovieObserver rateChanged:]): Ditto.
2013 (-[WebCoreMovieObserver sizeChanged:]): Ditto.
2014 (-[WebCoreMovieObserver timeChanged:]): Ditto.
2015 (-[WebCoreMovieObserver didEnd:]): Ditto.
2016 (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
2017 * platform/mac/ScrollbarThemeMac.mm:
2018 (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
2019 (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
2020 * platform/mac/SharedTimerMac.mm:
2021 (-[WebCorePowerNotifier didWake:]): Ditto.
2022 * platform/mac/WebCoreKeyGenerator.m:
2023 (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
2024 * platform/network/mac/ResourceHandleMac.mm:
2025 (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
2026 (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
2027 (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
2028 (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
2029 (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
2030 (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
2031 (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
2032 (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
2033 (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
2034 (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
2035 (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
2036 (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
2037 (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
2038 (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
2039 (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
2040 (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
2041 (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
2043 2009-01-11 Dirk Schulze <krit@webkit.org>
2045 Reviewed by Darin Adler.
2047 Move platform dependent strokeContains back to RenderPath, Path and delete
2048 unneeded Code in svg.
2050 RenderPath clean-up for strokeContains
2051 [https://bugs.webkit.org/show_bug.cgi?id=22957]
2055 * WebCore.vcproj/WebCore.vcproj:
2056 * WebCore.xcodeproj/project.pbxproj:
2057 * platform/graphics/Path.h:
2058 * platform/graphics/cairo/PathCairo.cpp:
2059 (WebCore::Path::strokeContains):
2060 * platform/graphics/cg/PathCG.cpp:
2061 (WebCore::Path::strokeContains):
2062 * platform/graphics/qt/PathQt.cpp:
2063 (WebCore::Path::strokeContains):
2064 * rendering/RenderPath.cpp:
2065 (WebCore::RenderPath::strokeContains):
2066 * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
2067 * svg/graphics/cg/CgSupport.cpp: Removed.
2068 * svg/graphics/cg/CgSupport.h: Removed.
2069 * svg/graphics/cg/RenderPathCg.cpp: Removed.
2070 * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
2071 * svg/graphics/cg/SVGResourceMaskerCg.mm:
2072 * svg/graphics/qt/RenderPathQt.cpp: Removed.
2074 2009-01-11 Holger Hans Peter Freyther <zecke@selfish.org>
2076 Reviewed by Anders Carlsson.
2078 [GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h
2080 make distcheck pass by adding JSWorkerContextBase.lut.h to the
2081 CLEANFILES that will be cleaned on a make distclean.
2085 2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
2087 Reviewed by Alexey Proskuryakov.
2089 https://bugs.webkit.org/show_bug.cgi?id=23235
2090 Build fix for non-VIDEO builds.
2092 * rendering/RenderTheme.cpp:
2093 * rendering/RenderTheme.h:
2095 2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
2097 Reviewed by Darin Adler.
2099 https://bugs.webkit.org/show_bug.cgi?id=19287
2100 return value of malloc() is not checked in npruntime.cpp
2102 Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
2103 (like in fastMalloc).
2105 * bridge/npruntime.cpp:
2106 (_NPN_GetStringIdentifier):
2107 (_NPN_GetIntIdentifier):
2108 (NPN_InitializeVariantWithStringCopy):
2109 (_NPN_CreateObject):
2111 2009-01-11 Glenn Wilson <gwilson@google.com>
2113 Reviewed by Darin Adler.
2115 Changes radio buttons so they can be 'checked' even if they
2116 don't have the name attribute set.
2118 See https://bugs.webkit.org/show_bug.cgi?id=21534
2120 Test: fast/html/select-unnamed-radio.html
2122 * html/HTMLInputElement.cpp:
2123 (WebCore::HTMLInputElement::preDispatchEventHandler):
2125 2009-01-11 Bernhard Rosenkraenzer <bero@arklinux.ch>
2127 Reviewed by Darin Adler.
2129 https://bugs.webkit.org/show_bug.cgi?id=22205
2130 Fix compatibility with bison 2.4, partially based on older patch by
2131 Priit Laes <amd@store20.com>
2133 * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
2135 2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
2137 Reviewed by Darin Adler.
2139 https://bugs.webkit.org/show_bug.cgi?id=16001
2140 Incorrect assumption that selection is always contiguous LTR.
2142 Test: editing/selection/extend-selection-bidi.html
2144 * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
2145 Make this function not assume a contiguous visual LTR selection range.
2147 2009-01-11 Dmitry Titov <dimich@chromium.org>
2149 Reviewed by Darin Adler.
2151 https://bugs.webkit.org/show_bug.cgi?id=23207
2152 Moved currentTime() to from WebCore to WTF.
2154 Most of these files only have a different header file included.
2155 Various build files reflect removal of SystemTimeGtk, Wx, Qt and Linux
2156 which were removed since they only implemented currentTime().
2158 * ForwardingHeaders/wtf/CurrentTime.h: Added.
2162 * dom/ContainerNode.cpp:
2165 * history/CachedPage.cpp:
2166 * history/PageCache.cpp:
2167 * html/HTMLMediaElement.cpp:
2168 (WebCore::HTMLMediaElement::load):
2169 (WebCore::HTMLMediaElement::progressEventTimerFired):
2170 * html/HTMLTokenizer.cpp:
2171 * html/PreloadScanner.cpp:
2172 * inspector/InspectorController.cpp:
2174 (WebCore::Cache::pruneLiveResources):
2175 * loader/CachedImage.cpp:
2176 * loader/CachedResource.cpp:
2177 * loader/FrameLoader.cpp:
2178 * loader/ProgressTracker.cpp:
2179 * loader/icon/IconDatabase.cpp:
2180 * loader/icon/IconRecord.cpp:
2181 * page/DragController.cpp:
2183 * page/FrameView.cpp:
2184 * page/animation/AnimationBase.cpp:
2185 * page/animation/AnimationController.cpp:
2186 * page/animation/KeyframeAnimation.cpp:
2187 * platform/SystemTime.h:
2188 * platform/Timer.cpp:
2189 * platform/graphics/BitmapImage.cpp:
2190 * platform/gtk/MouseEventGtk.cpp:
2191 * platform/gtk/SharedTimerGtk.cpp:
2192 * platform/gtk/SystemTimeGtk.cpp: Removed.
2193 * platform/gtk/SystemTimeLinux.cpp: Removed.
2194 * platform/mac/SystemTimeMac.cpp:
2195 * platform/qt/PlatformMouseEventQt.cpp:
2196 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2197 * platform/qt/SharedTimerQt.cpp:
2198 * platform/qt/SharedTimerQt.h:
2199 * platform/qt/SystemTimeQt.cpp: Removed.
2200 * platform/win/SharedTimerWin.cpp:
2201 * platform/win/SystemTimeWin.cpp:
2202 * platform/wx/MouseEventWx.cpp:
2203 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2204 * platform/wx/SharedTimerWx.cpp:
2205 * platform/wx/SystemTimeWx.cpp: Removed.
2206 * rendering/RenderImage.cpp:
2207 * rendering/RenderMedia.cpp:
2208 * svg/animation/SMILTimeContainer.cpp:
2210 * xml/XMLHttpRequest.cpp:
2212 2009-01-11 Dmitry Titov <dimich@chromium.org>
2214 Reviewed by Darin Adler.
2216 Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
2217 Part of 'Timers in Workers' work.
2218 https://bugs.webkit.org/show_bug.cgi?id=23223
2220 * bindings/js/ScheduledAction.cpp:
2221 (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
2222 (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
2223 * bindings/js/ScheduledAction.h:
2225 2009-01-10 Eric Carlson <eric.carlson@apple.com>
2227 Reviewed by Eric Seidel.
2229 https://bugs.webkit.org/show_bug.cgi?id=23210
2230 Make it easier for ports to define custom UI for media controls
2232 * css/CSSStyleSelector.cpp:
2233 (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
2234 get the media controller style sheet
2236 * rendering/MediaControlElements.cpp:
2237 (WebCore::MediaControlInputElement::hitTest): Added
2238 * rendering/MediaControlElements.h: Updated
2240 * rendering/RenderMedia.cpp:
2241 (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
2242 so control elements don't necessarily have to be rectangular
2244 * rendering/RenderTheme.cpp:
2245 (WebCore::RenderTheme::styleSheetForMediaControls): Added
2246 (WebCore::RenderTheme::hitTestMediaControlPart): Added
2247 * rendering/RenderTheme.h: Updated
2249 2009-01-10 Simon Fraser <simon.fraser@apple.com>
2251 Reviewed by Dan Bernstein
2253 https://bugs.webkit.org/show_bug.cgi?id=23222
2255 We need to disable LayoutState when an object has transforms,
2256 because LayoutState is not transform-aware and therefore
2257 repaint rects can be computed incorrectly.
2259 Test: fast/repaint/transform-disable-layoutstate.html
2261 * rendering/RenderBlock.cpp:
2262 (WebCore::RenderBlock::layoutBlock):
2263 (WebCore::RenderBlock::layoutOnlyPositionedObjects):
2264 * rendering/RenderFlexibleBox.cpp:
2265 (WebCore::RenderFlexibleBox::layoutBlock):
2267 2009-01-09 Holger Hans Peter Freyther <zecke@selfish.org>
2269 Reviewed by Simon Hausmann.
2271 [QT] Make SharedTimer use QBasicTimer
2273 Kill the SharedTimerQt.h and the usage of signal and slots
2274 by using QBasicTimer.
2277 * platform/qt/SharedTimerQt.cpp:
2278 (WebCore::SharedTimerQt::SharedTimerQt):
2279 (WebCore::SharedTimerQt::inst):
2280 (WebCore::SharedTimerQt::start):
2281 (WebCore::SharedTimerQt::stop):
2282 (WebCore::SharedTimerQt::timerEvent):
2283 (WebCore::setSharedTimerFiredFunction):
2284 (WebCore::setSharedTimerFireTime):
2285 (WebCore::stopSharedTimer):
2286 * platform/qt/SharedTimerQt.h: Removed.
2288 2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
2290 Reviewed by Holger Freyther.
2292 [CURL] POST without body becomes GET
2293 https://bugs.webkit.org/show_bug.cgi?id=23182
2295 Make sure that method is always set to POST even when the body is
2296 empty. Cleaned up httpBody null check.
2298 * platform/network/curl/ResourceHandleManager.cpp:
2299 (WebCore::ResourceHandleManager::setupPOST):
2301 2009-01-09 Adam Treat <adam.treat@torchmobile.com>
2305 * plugins/PluginView.cpp:
2307 2009-01-09 Adele Peterson <adele@apple.com>
2309 Reviewed by Darin Adler.
2311 Fix infinite recursion in clientPaddingLeft and clientPaddingRight. This changes the code back to
2312 how it was before RenderTextControlSingleLine was split out from RenderTextControl.
2314 No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
2316 * rendering/RenderTextControlSingleLine.cpp:
2317 (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
2318 (WebCore::RenderTextControlSingleLine::clientPaddingRight):
2320 2009-01-09 Darin Adler <darin@apple.com>
2322 Reviewed by Jon Honeycutt.
2324 Bug 22913: REGRESSION: Space bar doesn't scroll on windows
2325 https://bugs.webkit.org/show_bug.cgi?id=22913
2326 rdar://problem/6479834
2328 * page/EventHandler.cpp:
2329 (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
2330 defaultSpaceEventHandler.
2331 (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
2333 * page/EventHandler.h: Added defaultSpaceEventHandler.
2335 * platform/mac/ScrollViewMac.mm:
2336 (WebCore::ScrollView::platformScroll): Return false, because this function does
2337 not scroll. In an earlier version of this patch, I used this to prevent the
2338 patch from affecting the Mac, but I decided to use #if instead.
2340 2009-01-09 Gavin Barraclough <barraclough@apple.com>
2342 Reviewed by Oliver Hunt.
2344 Delete references to JSValue, removing this class.
2346 * bindings/js/JSWorkerContextCustom.cpp:
2347 (WebCore::JSWorkerContext::self):
2348 * bindings/js/ScriptCallStack.h:
2350 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
2352 Reviewed by Eric Seidel.
2354 Add svg/graphics/skia files.
2355 https://bugs.webkit.org/show_bug.cgi?id=23147
2357 * svg/graphics/skia/RenderPathSkia.cpp: Added.
2358 (WebCore::RenderPath::strokeContains):
2359 * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
2360 (WebCore::SVGPaintServerPattern::setup):
2361 * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
2362 (WebCore::SVGPaintServer::draw):
2363 (WebCore::SVGPaintServer::teardown):
2364 (WebCore::SVGPaintServer::renderPath):
2365 * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
2366 (WebCore::SVGResourceFilter::createPlatformData):
2367 (WebCore::SVGResourceFilter::prepareFilter):
2368 (WebCore::SVGResourceFilter::applyFilter):
2369 * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
2370 (WebCore::SVGResourceMasker::applyMask):
2372 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
2374 Reviewed by Eric Seidel.
2376 Add SkiaFontWin to platform/graphics/chromium
2377 https://bugs.webkit.org/show_bug.cgi?id=23215
2379 * platform/graphics/skia/SkiaFontWin.cpp: Added.
2380 (WebCore::CachedOutlineKey::CachedOutlineKey):
2381 (WebCore::operator==):
2382 (WebCore::CachedOutlineKeyHash::hash):
2383 (WebCore::CachedOutlineKeyHash::equal):
2384 (WebCore::FIXEDToSkScalar):
2385 (WebCore::deleteOutline):
2386 (WebCore::addPolyCurveToPath):
2387 (WebCore::getPathForGlyph):
2388 (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
2389 (WebCore::SkiaWinOutlineCache::removePathsForFont):
2390 * platform/graphics/skia/SkiaFontWin.h: Added.
2392 2009-01-09 Anders Carlsson <andersca@apple.com>
2398 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
2400 Reviewed by Eric Seidel.
2402 Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
2403 https://bugs.webkit.org/show_bug.cgi?id=23215
2405 * platform/graphics/skia/PlatformContextSkia.cpp: Added.
2406 (PlatformContextSkia::State::State):
2407 (PlatformContextSkia::State::~State):
2408 (PlatformContextSkia::State::applyAlpha):
2409 (PlatformContextSkia::PlatformContextSkia):
2410 (PlatformContextSkia::~PlatformContextSkia):
2411 (PlatformContextSkia::setCanvas):
2412 (PlatformContextSkia::save):
2413 (PlatformContextSkia::restore):
2414 (PlatformContextSkia::drawRect):
2415 (PlatformContextSkia::setupPaintCommon):
2416 (PlatformContextSkia::setupPaintForFilling):
2417 (PlatformContextSkia::setupPaintForStroking):
2418 (PlatformContextSkia::setDrawLooper):
2419 (PlatformContextSkia::setMiterLimit):
2420 (PlatformContextSkia::setAlpha):
2421 (PlatformContextSkia::setLineCap):
2422 (PlatformContextSkia::setLineJoin):
2423 (PlatformContextSkia::setPorterDuffMode):
2424 (PlatformContextSkia::setFillColor):
2425 (PlatformContextSkia::getDrawLooper):
2426 (PlatformContextSkia::getStrokeStyle):
2427 (PlatformContextSkia::setStrokeStyle):
2428 (PlatformContextSkia::setStrokeColor):
2429 (PlatformContextSkia::getStrokeThickness):
2430 (PlatformContextSkia::setStrokeThickness):
2431 (PlatformContextSkia::getTextDrawingMode):
2432 (PlatformContextSkia::setTextDrawingMode):
2433 (PlatformContextSkia::setUseAntialiasing):
2434 (PlatformContextSkia::fillColor):
2435 (PlatformContextSkia::beginPath):
2436 (PlatformContextSkia::addPath):
2437 (PlatformContextSkia::setFillRule):
2438 (PlatformContextSkia::setGradient):
2439 (PlatformContextSkia::setPattern):
2440 (PlatformContextSkia::setDashPathEffect):
2441 (PlatformContextSkia::paintSkPaint):
2442 (PlatformContextSkia::bitmap):
2443 (PlatformContextSkia::isPrinting):
2444 * platform/graphics/skia/PlatformContextSkia.h: Added.
2445 (PlatformContextSkia::currentPath):
2446 (PlatformContextSkia::canvas):
2447 (PlatformContextSkia::gdk_skia):
2448 * platform/graphics/skia/PlatformGraphics.h: Added.
2450 2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
2452 Reviewed by Eric Seidel.
2454 Add TransformationMatrixSkia to platform/graphics/skia
2455 https://bugs.webkit.org/show_bug.cgi?id=23215
2457 * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
2458 (WebCore::TransformationMatrix::TransformationMatrix):
2459 (WebCore::TransformationMatrix::setMatrix):
2460 (WebCore::TransformationMatrix::map):
2461 (WebCore::TransformationMatrix::mapRect):
2462 (WebCore::TransformationMatrix::isIdentity):
2463 (WebCore::TransformationMatrix::reset):
2464 (WebCore::TransformationMatrix::scale):
2465 (WebCore::TransformationMatrix::rotate):
2466 (WebCore::TransformationMatrix::translate):
2467 (WebCore::TransformationMatrix::shear):
2468 (WebCore::TransformationMatrix::det):
2469 (WebCore::TransformationMatrix::inverse):
2470 (WebCore::TransformationMatrix::operator SkMatrix):
2471 (WebCore::TransformationMatrix::operator==):
2472 (WebCore::TransformationMatrix::operator*=):
2473 (WebCore::TransformationMatrix::operator*):
2474 (WebCore::TransformationMatrix::a):
2475 (WebCore::TransformationMatrix::setA):
2476 (WebCore::TransformationMatrix::b):
2477 (WebCore::TransformationMatrix::setB):
2478 (WebCore::TransformationMatrix::c):
2479 (WebCore::TransformationMatrix::setC):
2480 (WebCore::TransformationMatrix::d):
2481 (WebCore::TransformationMatrix::setD):
2482 (WebCore::TransformationMatrix::e):
2483 (WebCore::TransformationMatrix::setE):
2484 (WebCore::TransformationMatrix::f):
2485 (WebCore::TransformationMatrix::setF):
2487 2009-01-09 Alexey Proskuryakov <ap@webkit.org>
2489 Reviewed by Darin Adler.
2491 <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
2493 Test: http/tests/appcache/reload.html
2495 On Windows, reloading resulted in the following sequence of events:
2496 1) A new main resource loader was created and associated with the cache. Its document loader
2497 was not associated with the cache yet.
2498 2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
2499 teardown started, with newestCache being zeroed out.
2500 3) The new document loader was associated with the cache group, and cache update started.
2501 4) Since newestCache was null, this caused many problems.
2503 * loader/appcache/ApplicationCacheGroup.cpp:
2504 (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
2505 no functional changes.
2506 (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
2507 if its newest cache pointer is already saved for teardown. Note that the cache pointer
2508 validity is ensured by MainResourceLoader that holds a reference to it.
2510 2009-01-09 Darin Fisher <darin@chromium.org>
2512 Reviewed by Eric Seidel.
2514 https://bugs.webkit.org/show_bug.cgi?id=23214
2515 Upstream platform/network/chromium/
2517 * platform/network/chromium/AuthenticationChallenge.h: Added.
2518 (WebCore::AuthenticationChallenge::AuthenticationChallenge):
2519 (WebCore::AuthenticationChallenge::sourceHandle):
2520 * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
2521 (WebCore::AuthenticationChallenge::platformCompare):
2522 * platform/network/chromium/CookieJarChromium.cpp: Added.
2523 (WebCore::setCookies):
2525 (WebCore::cookiesEnabled):
2526 * platform/network/chromium/DNSChromium.cpp: Added.
2527 (WebCore::prefetchDNS):
2528 * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
2529 (WebCore::NetworkStateNotifier::updateState):
2530 (WebCore::NetworkStateNotifier::NetworkStateNotifier):
2531 * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
2532 * platform/network/chromium/ResourceError.h: Added.
2533 (WebCore::ResourceError::ResourceError):
2534 * platform/network/chromium/ResourceRequest.h: Added.
2535 (WebCore::ResourceRequest::):
2536 (WebCore::ResourceRequest::ResourceRequest):
2537 (WebCore::ResourceRequest::frame):
2538 (WebCore::ResourceRequest::setFrame):
2539 (WebCore::ResourceRequest::setTargetType):
2540 (WebCore::ResourceRequest::targetType):
2541 (WebCore::ResourceRequest::originPid):
2542 (WebCore::ResourceRequest::setOriginPid):
2543 (WebCore::ResourceRequest::securityInfo):
2544 (WebCore::ResourceRequest::setSecurityInfo):
2545 (WebCore::ResourceRequest::doUpdatePlatformRequest):
2546 (WebCore::ResourceRequest::doUpdateResourceRequest):
2547 * platform/network/chromium/ResourceResponse.h:
2548 (WebCore::ResourceResponse::ResourceResponse):
2549 (WebCore::ResourceResponse::getSecurityInfo):
2550 (WebCore::ResourceResponse::setSecurityInfo):
2551 (WebCore::ResourceResponse::isContentFiltered):
2552 (WebCore::ResourceResponse::setIsContentFiltered):
2553 (WebCore::ResourceResponse::doUpdateResourceResponse):
2555 2009-01-09 Peter Kasting <pkasting@google.com>
2557 Reviewed by David Hyatt.
2559 https://bugs.webkit.org/show_bug.cgi?id=22995
2560 Fix flaky image animation by resetting the metadata for a frame when
2561 we get new data for that frame. This fixes animations that halted
2562 when the next frame of the animation wasn't complete by the time the
2563 current frame's duration expired.
2565 * platform/graphics/BitmapImage.cpp:
2566 (WebCore::BitmapImage::destroyDecodedData):
2567 (WebCore::BitmapImage::dataChanged):
2568 * platform/graphics/BitmapImage.h:
2569 (WebCore::FrameData::~FrameData):
2570 * platform/graphics/cairo/ImageCairo.cpp:
2571 (WebCore::FrameData::clear):
2572 * platform/graphics/cg/ImageCG.cpp:
2573 (WebCore::FrameData::clear):
2574 * platform/graphics/qt/ImageQt.cpp:
2575 (WebCore::FrameData::clear):
2576 * platform/graphics/wx/ImageWx.cpp:
2577 (WebCore::FrameData::clear):
2579 2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
2581 Rubber-stamped by Tor Arne Vestbø.
2583 Swap the .h and the .cpp output in the Qt build for the
2584 UserAgentStyleSheetData files, to put the definition in the .cpp file
2585 and the declaration in the header file.
2589 2009-01-09 David Levin <levin@chromium.org>
2591 Reviewed by Oliver Hunt.
2593 https://bugs.webkit.org/show_bug.cgi?id=23175
2595 Added forwarding header.
2597 * ForwardingHeaders/wtf/PtrAndFlags.h: Added.
2599 2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
2601 Reviewed by Simon Hausmann.
2603 Prevent qmake from generating duplicate rules for embedded stylesheets
2605 The STYLESHEETS_EMBED variable used to contain only one file name, but
2606 now that it is a list of files we need to change it to be a dependency
2607 for the stylesheet generator instead of the input.
2611 2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
2613 Reviewed by Tor Arne Vestbø.
2615 Fix qmake warning about missing test function, a contains() call was
2620 2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
2622 Rubber-stamped by Tor Arne Vestbø.
2624 Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
2628 2009-01-09 David Levin <levin@chromium.org>
2630 Reviewed by Alexey Proskuryakov.
2632 https://bugs.webkit.org/show_bug.cgi?id=23199
2634 Fix deref's of string happening on two different threads.
2636 No observable change in behavior, so no test. However, there are asserts
2637 being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
2638 will detect this issue while running the normal worker tests.
2640 * dom/WorkerThread.cpp:
2641 (WebCore::WorkerThreadStartupData::create):
2642 (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
2643 (WebCore::WorkerThread::WorkerThread):
2644 (WebCore::WorkerThread::workerThread):
2645 * dom/WorkerThread.h:
2647 2009-01-08 Dan Bernstein <mitz@apple.com>
2649 Reviewed by Adam Roben.
2651 - use native glyph support in Core Graphics when available
2653 * platform/graphics/win/FontCGWin.cpp:
2654 (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if
2655 native glyph support is not available or stroking is required. Changed
2656 to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to
2657 request the use of native glyphs.
2658 * platform/graphics/win/FontCustomPlatformData.cpp:
2659 (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to
2660 wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
2661 * platform/graphics/win/FontPlatformDataCGWin.cpp:
2662 (WebCore::FontPlatformData::platformDataInit): Ditto.
2664 2009-01-08 Peter Kasting <pkasting@google.com>
2666 Reviewed by Sam Weinig.
2668 https://bugs.webkit.org/show_bug.cgi?id=22929
2669 Fix memory regression when decoding large animated GIFs.
2671 * platform/graphics/cg/ImageSourceCG.cpp:
2672 (WebCore::ImageSource::clear):
2674 2009-01-08 Scott Violet <sky@chromium.org>
2676 Reviewed by Eric Seidel (and Adam Barth).
2678 Fix Images to return their file extension
2679 http://code.google.com/p/chromium/issues/detail?id=5827
2681 * platform/graphics/skia/ImageSourceSkia.cpp:
2682 (WebCore::ImageSource::filenameExtension):
2684 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2686 Reviewed by Eric Seidel.
2688 Add PathSkia and PatternSkia implementations to WebCore
2689 https://bugs.webkit.org/show_bug.cgi?id=23200
2691 * platform/graphics/skia/PathSkia.cpp: Added.
2692 (WebCore::Path::Path):
2693 (WebCore::Path::~Path):
2694 (WebCore::Path::operator=):
2695 (WebCore::Path::isEmpty):
2696 (WebCore::Path::contains):
2697 (WebCore::Path::translate):
2698 (WebCore::Path::boundingRect):
2699 (WebCore::Path::moveTo):
2700 (WebCore::Path::addLineTo):
2701 (WebCore::Path::addQuadCurveTo):
2702 (WebCore::Path::addBezierCurveTo):
2703 (WebCore::Path::addArcTo):
2704 (WebCore::Path::closeSubpath):
2705 (WebCore::Path::addArc):
2706 (WebCore::Path::addRect):
2707 (WebCore::Path::addEllipse):
2708 (WebCore::Path::clear):
2709 (WebCore::convertPathPoints):
2710 (WebCore::Path::apply):
2711 (WebCore::Path::transform):
2712 (WebCore::Path::debugString):
2713 (WebCore::boundingBoxForCurrentStroke):
2714 (WebCore::Path::strokeBoundingRect):
2715 * platform/graphics/skia/PatternSkia.cpp: Added.
2716 (WebCore::shaderRule):
2717 (WebCore::Pattern::createPlatformPattern):
2719 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2721 Reviewed by Eric Seidel.
2723 Add ImageSourceSkia to platform/graphics/skia
2724 https://bugs.webkit.org/show_bug.cgi?id=23200
2726 ImageSourceSkia is mostly a hack to support our
2727 ICO decoder model. See ImageSourceSkia.h for more
2728 explanation. Eventually we'd like to make our ICO
2731 * platform/graphics/ImageSource.h: mark m_decoder as protected
2732 * platform/graphics/skia/ImageSourceSkia.cpp: Added.
2733 (WebCore::createDecoder):
2734 (WebCore::ImageSource::ImageSource):
2735 (WebCore::ImageSource::~ImageSource):
2736 (WebCore::ImageSource::clear):
2737 (WebCore::ImageSource::initialized):
2738 (WebCore::ImageSource::setData):
2739 (WebCore::ImageSource::isSizeAvailable):
2740 (WebCore::ImageSource::size):
2741 (WebCore::ImageSource::frameSizeAtIndex):
2742 (WebCore::ImageSource::repetitionCount):
2743 (WebCore::ImageSource::frameCount):
2744 (WebCore::ImageSource::createFrameAtIndex):
2745 (WebCore::ImageSource::frameIsCompleteAtIndex):
2746 (WebCore::ImageSource::frameDurationAtIndex):
2747 (WebCore::ImageSource::frameHasAlphaAtIndex):
2748 (WebCore::ImageSourceSkia::setData):
2749 (WebCore::ImageSource::filenameExtension):
2750 * platform/graphics/skia/ImageSourceSkia.h: Added.
2752 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2754 Reviewed by Eric Seidel.
2756 Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
2757 https://bugs.webkit.org/show_bug.cgi?id=23200
2759 * platform/graphics/skia/NativeImageSkia.cpp: Added.
2760 (NativeImageSkia::NativeImageSkia):
2761 (NativeImageSkia::decodedSize):
2762 (NativeImageSkia::hasResizedBitmap):
2763 (NativeImageSkia::resizedBitmap):
2764 (NativeImageSkia::shouldCacheResampling):
2765 * platform/graphics/skia/NativeImageSkia.h: Added.
2766 (NativeImageSkia::setDataComplete):
2767 (NativeImageSkia::isDataComplete):
2769 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2771 Reviewed by Eric Seidel.
2773 Add ImageBufferSkia and ImageSkia files.
2774 https://bugs.webkit.org/show_bug.cgi?id=23200
2775 For now we've left BitmapImage and BitmapImageSingleFrameSkia
2776 implementations in the ImageSkia file (like ImageCG has), but
2777 we intend to break them out into their own files.
2779 * platform/graphics/skia/ImageBufferSkia.cpp: Added.
2780 (WebCore::ImageBufferData::ImageBufferData):
2781 (WebCore::ImageBuffer::ImageBuffer):
2782 (WebCore::ImageBuffer::~ImageBuffer):
2783 (WebCore::ImageBuffer::context):
2784 (WebCore::ImageBuffer::image):
2785 (WebCore::ImageBuffer::getImageData):
2786 (WebCore::ImageBuffer::putImageData):
2787 (WebCore::ImageBuffer::toDataURL):
2788 * platform/graphics/skia/ImageSkia.cpp: Added.
2790 (WebCore::FrameData::clear):
2791 (WebCore::Image::loadPlatformResource):
2792 (WebCore::Image::drawPattern):
2793 (WebCore::BitmapImage::initPlatformData):
2794 (WebCore::BitmapImage::invalidatePlatformData):
2795 (WebCore::BitmapImage::checkForSolidColor):
2796 (WebCore::BitmapImage::draw):
2797 (WebCore::BitmapImageSingleFrameSkia::draw):
2798 (WebCore::BitmapImageSingleFrameSkia::create):
2800 2009-01-08 James Robinson <jamesr@google.com>
2802 Reviewed by Mark Rowe.
2803 Landed by Pamela Greene.
2805 WebCore::Event::timeStamp() is a simple accessor and should be const
2807 https://bugs.webkit.org/show_bug.cgi?id=23176
2810 (WebCore::Event::timeStamp):
2812 2009-01-08 Antti Koivisto <antti@apple.com>
2814 Reviewed by Oliver Hunt.
2816 Fix <rdar://problem/6467206>
2817 Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)
2819 Use CachedResourceHandle in document resource map so resources get updated correctly when using
2820 using cache validation conditionals.
2823 (WebCore::Cache::evict):
2824 * loader/DocLoader.cpp:
2825 (WebCore::DocLoader::~DocLoader):
2826 (WebCore::DocLoader::requestResource):
2827 (WebCore::DocLoader::setAutoLoadImages):
2828 (WebCore::DocLoader::removeCachedResource):
2829 * loader/DocLoader.h:
2830 (WebCore::DocLoader::cachedResource):
2831 (WebCore::DocLoader::allCachedResources):
2832 * loader/DocumentLoader.cpp:
2833 (WebCore::DocumentLoader::getSubresources):
2834 * loader/ImageLoader.cpp:
2835 (WebCore::ImageLoader::updateFromElement):
2837 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2839 Reviewed by Eric Seidel.
2841 Add a cleaned-up GraphicsContextSkia implementation to WebKit.
2842 https://bugs.webkit.org/show_bug.cgi?id=23191
2844 * platform/graphics/skia/GraphicsContextSkia.cpp: Added.
2846 (WebCore::GraphicsContext::GraphicsContext):
2847 (WebCore::GraphicsContext::~GraphicsContext):
2848 (WebCore::GraphicsContext::platformContext):
2849 (WebCore::GraphicsContext::savePlatformState):
2850 (WebCore::GraphicsContext::restorePlatformState):
2851 (WebCore::GraphicsContext::beginTransparencyLayer):
2852 (WebCore::GraphicsContext::endTransparencyLayer):
2853 (WebCore::GraphicsContext::addInnerRoundedRectClip):
2854 (WebCore::GraphicsContext::addPath):
2855 (WebCore::GraphicsContext::beginPath):
2856 (WebCore::GraphicsContext::clearPlatformShadow):
2857 (WebCore::GraphicsContext::clearRect):
2858 (WebCore::GraphicsContext::clip):
2859 (WebCore::GraphicsContext::clipOut):
2860 (WebCore::GraphicsContext::clipOutEllipseInRect):
2861 (WebCore::GraphicsContext::clipPath):
2862 (WebCore::GraphicsContext::clipToImageBuffer):
2863 (WebCore::GraphicsContext::concatCTM):
2864 (WebCore::GraphicsContext::drawConvexPolygon):
2865 (WebCore::GraphicsContext::drawEllipse):
2866 (WebCore::GraphicsContext::drawFocusRing):
2867 (WebCore::GraphicsContext::drawLine):
2868 (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2869 (WebCore::GraphicsContext::drawLineForText):
2870 (WebCore::GraphicsContext::drawRect):
2871 (WebCore::GraphicsContext::fillPath):
2872 (WebCore::GraphicsContext::fillRect):
2873 (WebCore::GraphicsContext::fillRoundedRect):
2874 (WebCore::GraphicsContext::getCTM):
2875 (WebCore::GraphicsContext::roundToDevicePixels):
2876 (WebCore::GraphicsContext::scale):
2877 (WebCore::GraphicsContext::setAlpha):
2878 (WebCore::GraphicsContext::setCompositeOperation):
2879 (WebCore::GraphicsContext::setImageInterpolationQuality):
2880 (WebCore::GraphicsContext::setLineCap):
2881 (WebCore::GraphicsContext::setLineDash):
2882 (WebCore::GraphicsContext::setLineJoin):
2883 (WebCore::GraphicsContext::setMiterLimit):
2884 (WebCore::GraphicsContext::setPlatformFillColor):
2885 (WebCore::GraphicsContext::setPlatformShadow):
2886 (WebCore::GraphicsContext::setPlatformStrokeColor):
2887 (WebCore::GraphicsContext::setPlatformStrokeStyle):
2888 (WebCore::GraphicsContext::setPlatformStrokeThickness):
2889 (WebCore::GraphicsContext::setPlatformTextDrawingMode):
2890 (WebCore::GraphicsContext::setURLForRect):
2891 (WebCore::GraphicsContext::setUseAntialiasing):
2892 (WebCore::GraphicsContext::strokeArc):
2893 (WebCore::GraphicsContext::strokePath):
2894 (WebCore::GraphicsContext::strokeRect):
2895 (WebCore::GraphicsContext::rotate):
2896 (WebCore::GraphicsContext::translate):
2898 2009-01-08 David Hyatt <hyatt@apple.com>
2900 Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.
2902 Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
2903 any scrollable views that may contain a WebView. Does nothing on platforms other than the Mac, but
2904 might eventually be of interest to other platforms.
2906 Reviewed by Oliver Hunt
2910 (WebCore::Chrome::scrollRectIntoView):
2912 * page/ChromeClient.h:
2913 (WebCore::ChromeClient::scrollRectIntoView):
2914 * platform/HostWindow.h:
2915 * platform/ScrollView.cpp:
2916 (WebCore::ScrollView::scrollRectIntoViewRecursively):
2918 2009-01-08 Adam Treat <adam.treat@torchmobile.com>
2920 Reviewed by David Hyatt.
2922 No need to make this part of HostWindow and moreover HostWindow should
2923 not have any reference to non-platform parts of WebCore.
2926 * page/FrameView.cpp:
2927 (WebCore::FrameView::setContentsSize):
2928 * platform/HostWindow.h:
2930 2009-01-08 Eric Carlson <eric.carlson@apple.com>
2932 Reviewed by Adele Peterson.
2934 Simplify Mac interfaces for drawing media controller elements
2936 <rdar://problem/6293969>
2938 * WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
2940 * platform/mac/WebCoreSystemInterface.h: Ditto
2941 * platform/mac/WebCoreSystemInterface.mm: Ditto
2943 * rendering/MediaControlElements.h:
2944 (WebCore::): Add MediaControlElements enum
2946 * rendering/RenderThemeMac.mm:
2947 (WebCore::RenderThemeMac::paintMediaFullscreenButton): update for changed WebKitSystemInterface
2948 media controller functions
2949 (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
2950 (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
2951 (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
2952 (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
2953 (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
2954 (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
2956 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2958 Reviewed by Eric Seidel.
2960 Add two more files for platform/graphics/skia.
2961 https://bugs.webkit.org/show_bug.cgi?id=23191
2963 * platform/graphics/skia/GradientSkia.cpp: Added.
2964 (WebCore::Gradient::platformDestroy):
2966 (WebCore::makeSkColor):
2967 (WebCore::totalStopsNeeded):
2968 (WebCore::fillStops):
2969 (WebCore::compareStops):
2970 (WebCore::Gradient::platformGradient):
2971 (WebCore::Gradient::fill):
2972 * platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h.
2973 (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2974 (WebCore::GraphicsContextPlatformPrivate::context):
2976 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
2978 Reviewed by Eric Seidel.
2980 Commit the right files this time! (Instead of the ugly unfixed ones.)
2981 https://bugs.webkit.org/show_bug.cgi?id=23191
2983 * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
2984 * platform/graphics/skia/FloatPointSkia.cpp:
2985 * platform/graphics/skia/FloatRectSkia.cpp:
2986 * platform/graphics/skia/IntPointSkia.cpp:
2987 * platform/graphics/skia/IntRectSkia.cpp:
2988 (WebCore::IntRect::operator SkRect):
2989 * platform/graphics/skia/SkiaUtils.cpp:
2991 (WebCore::WebCoreCompositeToSkiaComposite):
2992 (WebCore::SkPMColorToWebCoreColor):
2993 (WebCore::IntersectRectAndRegion):
2994 (WebCore::ClipRectToCanvas):
2995 (WebCore::SkPathContainsPoint):
2996 (WebCore::scratchContext):
2997 * platform/graphics/skia/SkiaUtils.h:
2998 (WebCore::WebCoreFloatToSkScalar):
2999 (WebCore::WebCoreDoubleToSkScalar):
3001 2009-01-08 Dimitri Glazkov <dglazkov@chromium.org>
3003 Reviewed by Eric Seidel.
3005 Add the first few files from platform/graphics/skia
3006 https://bugs.webkit.org/show_bug.cgi?id=23191
3008 These are all pretty simple.
3009 Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
3010 SkiaUtils needs to die, but that can come later, no need to block up-streaming now.
3012 * platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added.
3013 (WebCore::BitmapImageSingleFrameSkia::isBitmapImage):
3014 (WebCore::BitmapImageSingleFrameSkia::size):
3015 (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData):
3016 (WebCore::BitmapImageSingleFrameSkia::decodedSize):
3017 (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame):
3018 (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
3019 * platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm.
3020 (WebCore::FloatPoint::FloatPoint):
3021 (WebCore::FloatPoint::operator SkPoint):
3022 * platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
3023 (WebCore::FloatRect::FloatRect):
3024 (WebCore::FloatRect::operator SkRect):
3025 * platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp.
3026 (WebCore::IntPoint::IntPoint):
3027 (WebCore::IntPoint::operator SkIPoint):
3028 (WebCore::IntPoint::operator SkPoint):
3029 * platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp.
3030 (WebCore::IntRect::operator SkIRect):
3031 (WebCore::IntRect::operator SkRect):
3032 (WebCore::IntRect::IntRect):
3033 * platform/graphics/skia/SkiaUtils.cpp: Added.
3034 (WebCore::WebCorePointToSkiaPoint):
3035 (WebCore::WebCoreRectToSkiaRect):
3037 (WebCore::WebCoreCompositeToSkiaComposite):
3038 (WebCore::InvScaleByte):
3039 (WebCore::SkPMColorToColor):
3040 (WebCore::SkPMColorToWebCoreColor):
3041 (WebCore::IntersectRectAndRegion):
3042 (WebCore::ClipRectToCanvas):
3043 (WebCore::SkPathContainsPoint):
3044 (WebCore::scratchContext):
3045 * platform/graphics/skia/SkiaUtils.h: Added.
3046 (WebCore::WebCoreFloatToSkScalar):
3047 (WebCore::WebCoreDoubleToSkScalar):
3049 2009-01-08 Pierre-Olivier Latour <pol@apple.com>
3051 Reviewed by Dan Bernstein.
3053 Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.
3055 Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
3056 instead of simply the "running" ones.
3058 https://bugs.webkit.org/show_bug.cgi?id=23177
3060 Tests: transitions/zero-duration-with-non-zero-delay-end.html
3061 transitions/zero-duration-with-non-zero-delay-start.html
3063 * page/animation/AnimationBase.cpp:
3064 (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
3065 * page/animation/AnimationController.cpp:
3066 (WebCore::AnimationControllerPrivate::animationTimerFired):
3067 * page/animation/CompositeAnimation.cpp:
3068 (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
3070 2009-01-08 Alexey Proskuryakov <ap@webkit.org>
3072 Reviewed by Oliver Hunt.
3074 <rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly
3076 The crash happened whenever a cached resource was downloaded, as opposed to used directly.
3078 No test, as downloading cannot be tested automatically.
3080 * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
3081 Cancel downloads that do not have an associated ResourceHandle, such as downloads from the
3082 application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
3084 2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
3086 Reviewed by Simon Hausmann.
3088 Fix the Qt build on older X11 systems with special X paths.
3090 * WebCore.pro: Use the x11 qmake config to pull in extra paths
3093 2009-01-08 Adam Roben <aroben@apple.com>
3095 Windows build fix after r39699
3097 * DerivedSources.cpp: Added JSDOMStringList.cpp.
3099 2009-01-08 Kent Hansen <khansen@trolltech.com>
3101 Reviewed by Simon Hausmann.
3103 Fix copy & paste of images in the Qt port.
3105 Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.
3107 * platform/qt/ClipboardQt.cpp:
3108 (WebCore::ClipboardQt::declareAndWriteDragImage):
3110 2009-01-08 Hiroyuki Ikezoe <poincare@ikezoe.net>
3112 Reviewed by Holger Freyther.
3114 https://bugs.webkit.org/show_bug.cgi?id=23127
3116 Invoke pango_coverage_get with each Unicode character.
3118 * platform/graphics/gtk/SimpleFontDataPango.cpp:
3119 (WebCore::SimpleFontData::containsCharacters):
3121 2009-01-07 Alexey Proskuryakov <ap@webkit.org>
3123 Reviewed by Darin Adler.
3126 https://bugs.webkit.org/show_bug.cgi?id=23165
3127 Add support for application cache dynamic entries
3129 Test: http/tests/appcache/dynamic-entries-no-cache.html
3131 * DerivedSources.make:
3135 * WebCore.vcproj/WebCore.vcproj:
3136 * WebCore.xcodeproj/project.pbxproj:
3137 * WebCoreSources.bkl:
3140 * bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem):
3141 Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom
3142 to resolve relative URLs correctly.
3144 * bindings/js/JSDOMStringListCustom.cpp: Added.
3145 * dom/DOMStringList.cpp: Added.
3146 * dom/DOMStringList.h: Added.
3147 * dom/DOMStringList.idl: Added.
3148 Added an implementation of DOM 3 Core DOMStringList interface, which is returned by
3149 DOMApplicationCache items attribute.
3151 * dom/StaticStringList.cpp: Added.
3152 * dom/StaticStringList.h: Added.
3153 An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this
3154 matches Firefox, as the spec doesn't say whether the returned list should be live or not).
3156 * loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be
3157 used in the near future.
3159 * loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length
3160 attribute and item(), we now have an items attribute that returns a DOMStringList, and a
3161 hasItem convenience method.
3163 * loader/appcache/DOMApplicationCache.cpp:
3164 (WebCore::DOMApplicationCache::items):
3165 (WebCore::DOMApplicationCache::hasItem):
3166 * loader/appcache/DOMApplicationCache.h:
3167 Added implementations of items attribute and hasItem() (note that underlying ApplicationCache
3168 methods are still unimplemented though).
3170 * page/DOMWindow.idl: Expose a DOMStringList global constructor.
3172 2009-01-07 Chris Marrin <cmarrin@apple.com>
3174 Reviewed by Eric Seidel.
3176 https://bugs.webkit.org/show_bug.cgi?id=23122
3178 This completes the removal of dependencies on WebKit from the platform code
3180 * css/CSSComputedStyleDeclaration.cpp:
3181 (WebCore::getDelayValue):
3182 (WebCore::getDurationValue):
3183 (WebCore::getTimingFunctionValue):
3184 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3186 * css/CSSStyleSelector.cpp:
3187 (WebCore::CSSStyleSelector::mapAnimationDelay):
3188 (WebCore::CSSStyleSelector::mapAnimationDirection):
3189 (WebCore::CSSStyleSelector::mapAnimationDuration):
3190 (WebCore::CSSStyleSelector::mapAnimationIterationCount):
3191 (WebCore::CSSStyleSelector::mapAnimationName):
3192 (WebCore::CSSStyleSelector::mapAnimationPlayState):
3193 (WebCore::CSSStyleSelector::mapAnimationProperty):
3194 (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
3195 * platform/animation/Animation.cpp:
3196 (WebCore::Animation::Animation):
3197 * platform/animation/Animation.h:
3198 (WebCore::Animation::initialAnimationDelay):
3199 (WebCore::Animation::initialAnimationDirection):
3200 (WebCore::Animation::initialAnimationDuration):
3201 (WebCore::Animation::initialAnimationIterationCount):
3202 (WebCore::Animation::initialAnimationName):
3203 (WebCore::Animation::initialAnimationPlayState):
3204 (WebCore::Animation::initialAnimationProperty):
3205 (WebCore::Animation::initialAnimationTimingFunction):
3206 * rendering/style/RenderStyle.h:
3208 2008-01-07 Peter Kasting <pkasting@google.com>
3210 Reviewed by Sam Weinig.
3212 https://bugs.webkit.org/show_bug.cgi?id=22929
3214 Fix errors while decoding GIFs by not calling setData() repeatedly
3215 when it's not necessary. Pushes the responsibility for calling
3216 setData() after clear() into the ImageSource which presumably knows
3217 better than BitmapImage what needs to be done.
3219 NOTE: The above bug is mainly about a memory regression, which this
3222 * platform/graphics/BitmapImage.cpp:
3223 (WebCore::BitmapImage::destroyDecodedData):
3224 * platform/graphics/ImageSource.h:
3225 * platform/graphics/cairo/ImageSourceCairo.cpp:
3226 (WebCore::ImageSource::clear):
3227 * platform/graphics/cg/ImageSourceCG.cpp:
3228 (WebCore::ImageSource::clear):
3229 * platform/graphics/qt/ImageSourceQt.cpp:
3230 (WebCore::ImageSource::~ImageSource):
3231 (WebCore::ImageSource::clear):
3232 * platform/graphics/wx/ImageSourceWx.cpp:
3233 (WebCore::ImageSource::~ImageSource):
3234 (WebCore::ImageSource::clear):
3236 2009-01-07 Justin Garcia <justin.garcia@apple.com>
3238 Reviewed by Darin Adler.
3240 <rdar://problem/6355786> Find fails for queries that contain a line break
3242 * editing/TextIterator.cpp:
3243 (WebCore::findPlainText): Allow find with queries that contain newlines.
3245 2009-01-07 Dean Jackson <dino@apple.com>
3247 Reviewed by Dan Bernstein.
3249 Allow removal of inline shorthand properties for
3250 animation, transition and transform origin. Also
3251 add getter for shorthand animation property.
3253 https://bugs.webkit.org/show_bug.cgi?id=22605
3255 Test: fast/css/transform-inline-style-remove.html
3257 * css/CSSMutableStyleDeclaration.cpp:
3258 (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
3259 Getter for animation property shorthand
3260 (WebCore::initShorthandMap):
3261 Adds initialisation for transform-origin, animation and transition
3263 2009-01-07 Benjamin Otte <otte@gnome.org>
3265 Reviewed by Holger Freyther.
3267 * platform/network/ResourceHandleInternal.h:
3268 (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3269 * platform/network/soup/ResourceHandleSoup.cpp:
3270 (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3271 (WebCore::parseDataUrl):
3272 (WebCore::ResourceHandle::startData): keep track of the idle handler
3273 we add and remove it in the destructor
3275 2009-01-07 Dean Jackson <dino@apple.com>
3277 Reviewed by Darin Adler.
3279 Finish renaming of AffineTransform to TransformationMatrix, this
3280 time ensuring that the platform implementations get the correct
3281 name. Also, clean up some whitespace cruft in old content.
3283 https://bugs.webkit.org/show_bug.cgi?id=23151
3288 * WebCore.vcproj/WebCore.vcproj:
3289 * WebCore.xcodeproj/project.pbxproj:
3290 * platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
3291 * platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
3292 * platform/graphics/cg/AffineTransformCG.cpp: Removed.
3293 * platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
3294 * platform/graphics/qt/AffineTransformQt.cpp: Removed.
3295 * platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
3296 * platform/graphics/transforms/TransformationMatrix.cpp:
3297 * platform/graphics/transforms/TransformationMatrix.h:
3298 * platform/graphics/wx/AffineTransformWx.cpp: Removed.
3299 * platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
3302 2009-01-07 Anders Carlsson <andersca@apple.com>
3308 2008-12-16 David Hyatt <hyatt@apple.com>
3310 Make Safari RSS behave nicely with full page zoom. Need to add a new value to enable resetting of zoom
3311 back to the document-level default.
3313 Reviewed by Darin Adler
3315 * css/CSSParser.cpp:
3316 (WebCore::CSSParser::parseValue):
3317 * css/CSSStyleSelector.cpp:
3318 (WebCore::CSSStyleSelector::applyProperty):
3319 * css/CSSValueKeywords.in:
3321 2009-01-07 Darin Adler <darin@apple.com>
3323 Reviewed by Oliver Hunt.
3325 Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
3326 https://bugs.webkit.org/show_bug.cgi?id=23160
3328 * WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
3330 * inspector/InspectorController.cpp:
3331 (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource
3332 so that there's no extra work the caller has to do when the inspector is disabled.
3333 * inspector/InspectorController.h: Ditto.
3335 * loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification,
3336 takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
3338 * loader/FrameLoader.cpp:
3339 (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when
3340 there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled
3341 and if it's false, use recordMemoryCacheLoadForFutureClientNotification.
3342 (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
3343 * loader/FrameLoader.h: Ditto.
3346 (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior.
3347 (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
3348 * page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled,
3349 and m_areMemoryCacheClientCallsEnabled.
3351 2009-01-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
3353 Rubber-stamped by Simon Hausmann.
3355 Qt build fix after r39670.
3357 * bridge/qt/qt_class.cpp:
3358 (JSC::Bindings::QtClass::fallbackObject):
3359 * bridge/qt/qt_class.h:
3360 * bridge/qt/qt_instance.cpp:
3361 (JSC::Bindings::QtInstance::mark):
3362 (JSC::Bindings::QtInstance::invokeMethod):
3363 (JSC::Bindings::QtInstance::defaultValue):
3364 (JSC::Bindings::QtInstance::stringValue):
3365 (JSC::Bindings::QtInstance::numberValue):
3366 (JSC::Bindings::QtInstance::booleanValue):
3367 (JSC::Bindings::QtInstance::valueOf):
3368 (JSC::Bindings::QtField::valueFromInstance):
3369 (JSC::Bindings::QtField::setValueToInstance):
3370 * bridge/qt/qt_instance.h:
3371 * bridge/qt/qt_runtime.cpp:
3372 (JSC::Bindings::valueRealType):
3373 (JSC::Bindings::convertValueToQVariant):
3374 (JSC::Bindings::convertQVariantToValue):
3375 (JSC::Bindings::findMethodIndex):
3376 (JSC::Bindings::QtRuntimeMetaMethod::call):
3377 (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
3378 (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
3379 (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
3380 (JSC::Bindings::QtRuntimeConnectionMethod::call):
3381 (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
3382 (JSC::Bindings::::setValueAt):
3383 (JSC::Bindings::::valueAt):
3384 * bridge/qt/qt_runtime.h:
3385 (JSC::Bindings::QtRuntimeMethod::createStructure):
3387 2009-01-06 Justin Garcia <justin.garcia@apple.com>
3389 Reviewed by Oliver Hunt.
3391 <rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu
3393 Can't create an automated test case for specific contextual menu items yet and
3394 a normal Copy doesn't cause a crash.
3396 * platform/mac/PasteboardMac.mm:
3397 (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data. It may,
3398 for example, have a purgeable or regular buffer.
3400 2009-01-06 Mark Rowe <mrowe@apple.com>
3402 Reviewed by Geoff Garen.
3404 Fix <https://bugs.webkit.org/show_bug.cgi?id=23157>.
3405 Bug 23157: Crashes on Acid 3
3408 (WebCore::Document::recalcStyle): Null-check the frame.
3410 2009-01-05 Gavin Barraclough <baraclough@apple.com>
3412 Rubber Stamped by Oliver Hunt.
3414 Replace all uses of JSValue* with new wrapper class, JSValuePtr.
3415 See JavaScriptCore/ChangeLog for more detailed description.
3417 * bindings/js/JSAttrCustom.cpp:
3418 (WebCore::JSAttr::setValue):
3419 * bindings/js/JSCSSRuleCustom.cpp:
3421 * bindings/js/JSCSSStyleDeclarationCustom.cpp:
3422 (WebCore::JSCSSStyleDeclaration::nameGetter):
3423 (WebCore::JSCSSStyleDeclaration::customPut):
3424 * bindings/js/JSCSSValueCustom.cpp:
3426 * bindings/js/JSCanvasPixelArrayCustom.h:
3427 (WebCore::JSCanvasPixelArray::getByIndex):
3428 (WebCore::JSCanvasPixelArray::indexSetter):
3429 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3431 (WebCore::toHTMLCanvasStyle):
3432 (WebCore::JSCanvasRenderingContext2D::strokeStyle):
3433 (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
3434 (WebCore::JSCanvasRenderingContext2D::fillStyle):
3435 (WebCore::JSCanvasRenderingContext2D::setFillStyle):
3436 (WebCore::JSCanvasRenderingContext2D::setFillColor):
3437 (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
3438 (WebCore::JSCanvasRenderingContext2D::strokeRect):
3439 (WebCore::JSCanvasRenderingContext2D::drawImage):
3440 (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
3441 (WebCore::JSCanvasRenderingContext2D::setShadow):
3442 (WebCore::JSCanvasRenderingContext2D::createPattern):
3443 (WebCore::JSCanvasRenderingContext2D::putImageData):
3444 (WebCore::JSCanvasRenderingContext2D::fillText):
3445 (WebCore::JSCanvasRenderingContext2D::strokeText):
3446 * bindings/js/JSClipboardCustom.cpp:
3447 (WebCore::JSClipboard::types):
3448 (WebCore::JSClipboard::clearData):
3449 (WebCore::JSClipboard::getData):
3450 (WebCore::JSClipboard::setData):
3451 (WebCore::JSClipboard::setDragImage):
3452 * bindings/js/JSConsoleCustom.cpp:
3453 (WebCore::JSConsole::profiles):
3454 * bindings/js/JSCustomPositionCallback.cpp:
3455 (WebCore::JSCustomPositionCallback::handleEvent):
3456 * bindings/js/JSCustomPositionErrorCallback.cpp:
3457 (WebCore::JSCustomPositionErrorCallback::handleEvent):
3458 * bindings/js/JSCustomSQLStatementCallback.cpp:
3459 (WebCore::JSCustomSQLStatementCallback::handleEvent):
3460 * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3461 (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3462 * bindings/js/JSCustomSQLTransactionCallback.cpp:
3463 (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3464 * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3465 (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3466 * bindings/js/JSCustomVoidCallback.cpp:
3467 (WebCore::JSCustomVoidCallback::handleEvent):
3468 (WebCore::toVoidCallback):
3469 * bindings/js/JSCustomVoidCallback.h:
3470 * bindings/js/JSCustomXPathNSResolver.cpp:
3471 (WebCore::JSCustomXPathNSResolver::create):
3472 (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3473 * bindings/js/JSCustomXPathNSResolver.h:
3474 * bindings/js/JSDOMApplicationCacheCustom.cpp:
3475 (WebCore::JSDOMApplicationCache::add):
3476 (WebCore::JSDOMApplicationCache::remove):
3477 (WebCore::JSDOMApplicationCache::addEventListener):
3478 (WebCore::JSDOMApplicationCache::removeEventListener):
3479 * bindings/js/JSDOMBinding.cpp:
3480 (WebCore::jsStringOrNull):
3481 (WebCore::jsOwnedStringOrNull):
3482 (WebCore::jsStringOrUndefined):
3483 (WebCore::jsStringOrFalse):
3484 (WebCore::valueToStringWithNullCheck):
3485 (WebCore::valueToStringWithUndefinedOrNullCheck):
3486 (WebCore::reportException):
3487 (WebCore::reportCurrentException):
3488 (WebCore::setDOMException):
3489 (WebCore::objectToStringFunctionGetter):
3490 * bindings/js/JSDOMBinding.h:
3491 (WebCore::getDOMObjectWrapper):
3492 (WebCore::getDOMNodeWrapper):
3494 * bindings/js/JSDOMGlobalObject.cpp:
3495 (WebCore::JSDOMGlobalObject::findJSEventListener):
3496 (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
3497 (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener):
3498 (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
3499 * bindings/js/JSDOMGlobalObject.h:
3500 * bindings/js/JSDOMWindowBase.cpp:
3501 (WebCore::createWindow):
3502 (WebCore::showModalDialog):
3503 (jsDOMWindowBaseCrypto):
3504 (jsDOMWindowBaseEvent):
3505 (jsDOMWindowBaseImage):
3506 (jsDOMWindowBaseMessageChannel):
3507 (jsDOMWindowBaseOption):
3508 (jsDOMWindowBaseXMLHttpRequest):
3509 (jsDOMWindowBaseAudio):
3510 (jsDOMWindowBaseWorker):
3511 (jsDOMWindowBaseXSLTProcessor):
3512 (setJSDOMWindowBaseEvent):
3513 (setJSDOMWindowBaseAudio):
3514 (setJSDOMWindowBaseImage):
3515 (setJSDOMWindowBaseMessageChannel):
3516 (setJSDOMWindowBaseOption):
3517 (setJSDOMWindowBaseWorker):
3518 (setJSDOMWindowBaseXMLHttpRequest):
3519 (setJSDOMWindowBaseXSLTProcessor):
3520 (WebCore::JSDOMWindowBase::childFrameGetter):
3521 (WebCore::JSDOMWindowBase::indexGetter):
3522 (WebCore::JSDOMWindowBase::namedItemGetter):
3523 (WebCore::JSDOMWindowBase::getOwnPropertySlot):
3524 (WebCore::JSDOMWindowBase::put):
3525 (WebCore::JSDOMWindowBase::clear):
3526 (windowProtoFuncOpen):
3527 (windowProtoFuncShowModalDialog):
3528 (windowProtoFuncNotImplemented):
3529 (WebCore::JSDOMWindowBase::setReturnValueSlot):
3530 (WebCore::JSDOMWindowBase::installTimeout):
3532 (WebCore::toJSDOMWindow):
3533 * bindings/js/JSDOMWindowBase.h:
3534 * bindings/js/JSDOMWindowCustom.cpp:
3535 (WebCore::JSDOMWindow::lookupGetter):
3536 (WebCore::JSDOMWindow::lookupSetter):
3537 (WebCore::JSDOMWindow::setLocation):
3538 (WebCore::JSDOMWindow::postMessage):
3539 (WebCore::setTimeoutOrInterval):
3540 (WebCore::JSDOMWindow::setTimeout):
3541 (WebCore::JSDOMWindow::clearTimeout):
3542 (WebCore::JSDOMWindow::setInterval):
3543 (WebCore::JSDOMWindow::clearInterval):
3544 (WebCore::JSDOMWindow::atob):
3545 (WebCore::JSDOMWindow::btoa):
3546 (WebCore::JSDOMWindow::addEventListener):
3547 (WebCore::JSDOMWindow::removeEventListener):
3548 (WebCore::toDOMWindow):
3549 (WebCore::nonCachingStaticCloseFunctionGetter):
3550 (WebCore::nonCachingStaticBlurFunctionGetter):
3551 (WebCore::nonCachingStaticFocusFunctionGetter):
3552 (WebCore::nonCachingStaticPostMessageFunctionGetter):
3553 * bindings/js/JSDOMWindowCustom.h:
3554 (WebCore::JSDOMWindow::customPut):
3555 * bindings/js/JSDOMWindowShell.cpp:
3556 (WebCore::JSDOMWindowShell::put):
3557 (WebCore::JSDOMWindowShell::putWithAttributes):
3558 (WebCore::JSDOMWindowShell::lookupGetter):
3559 (WebCore::JSDOMWindowShell::lookupSetter):
3561 * bindings/js/JSDOMWindowShell.h:
3562 (WebCore::JSDOMWindowShell::createStructure):
3563 * bindings/js/JSDatabaseCustom.cpp:
3564 (WebCore::JSDatabase::changeVersion):
3565 (WebCore::JSDatabase::transaction):
3566 * bindings/js/JSDocumentCustom.cpp:
3567 (WebCore::JSDocument::location):
3568 (WebCore::JSDocument::setLocation):
3570 * bindings/js/JSElementCustom.cpp:
3571 (WebCore::JSElement::setAttribute):
3572 (WebCore::JSElement::setAttributeNode):
3573 (WebCore::JSElement::setAttributeNS):
3574 (WebCore::JSElement::setAttributeNodeNS):
3575 (WebCore::toJSNewlyCreated):
3576 * bindings/js/JSEventCustom.cpp:
3577 (WebCore::JSEvent::clipboardData):
3579 * bindings/js/JSEventListener.cpp:
3580 (WebCore::JSAbstractEventListener::handleEvent):
3581 (WebCore::eventParameterName):
3582 (WebCore::JSLazyEventListener::parseCode):
3583 * bindings/js/JSEventTarget.cpp:
3585 * bindings/js/JSEventTarget.h:
3586 * bindings/js/JSEventTargetBase.h:
3587 * bindings/js/JSEventTargetNodeCustom.cpp:
3588 (WebCore::JSEventTargetNode::addEventListener):
3589 (WebCore::JSEventTargetNode::removeEventListener):
3590 * bindings/js/JSGeolocationCustom.cpp:
3591 (WebCore::createPositionOptions):
3592 (WebCore::JSGeolocation::getCurrentPosition):
3593 (WebCore::JSGeolocation::watchPosition):
3594 * bindings/js/JSHTMLAllCollection.h:
3595 (WebCore::JSHTMLAllCollection::createStructure):
3596 * bindings/js/JSHTMLAppletElementCustom.cpp:
3597 (WebCore::JSHTMLAppletElement::customPut):