LayoutTests:
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
2
3         Reviewed by darin
4
5         <rdar://problem/4062865>
6         Copy/paste of a select element fails to include the options
7         
8         * editing/SelectionController.cpp:
9         (WebCore::SelectionController::modify): Added paragraphBoundary.
10         * editing/htmlediting.cpp:
11         (WebCore::canHaveChildrenForEditing): Added checks for input elements
12         and textareas.  Insertion operations would fail when performed just 
13         before/after one of these elements b/c the content would be put inside 
14         the element.
15         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
16         editable content, and made the code to stop at an root faster (don't check
17         isDescendantOf on every iteration).
18         (WebCore::enclosingNodeOfType): Ditto.
19         (WebCore::enclosingList): Ditto.
20         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
21         inappropriately named.
22         * editing/markup.cpp:
23         (WebCore::startMarkup): Use the text node's value instead of its rendered
24         content for text nodes inside select elements.  One might also turn off
25         annotation when createMarkup enters a select element, but createMarkup
26         is iterative, not recursive, so doing so would be complicated.
27         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
28         descendants of a select element.
29         * editing/visible_units.cpp:
30         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
31         where various replaced elements can't be copied when they are the only
32         thing selected.
33         (WebCore::endOfParagraph): Ditto.
34
35 2006-11-01  Oliver Hunt  <oliver@apple.com>
36
37         Reviewed by Adam.
38
39         Converting more or kcanvas/quartz from Obj-C to C++
40         Minor SVG updates
41         compatibility fixes
42
43         * WebCore.xcodeproj/project.pbxproj:
44         * kcanvas/device/KRenderingPaintServer.h:
45         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
46         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
47         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
48         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
49         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
50         * kcanvas/device/quartz/QuartzSupport.h:
51         * ksvg2/css/SVGCSSStyleSelector.cpp:
52         * ksvg2/misc/KCanvasRenderingStyle.h:
53         * ksvg2/scripts/cssmakeprops:
54         * ksvg2/scripts/cssmakevalues:
55         * ksvg2/scripts/make_names.pl:
56         * ksvg2/svg/SVGAnimateColorElement.cpp:
57         * ksvg2/svg/SVGAnimateTransformElement.cpp:
58         * ksvg2/svg/SVGAnimationElement.cpp:
59         * ksvg2/svg/SVGMaskElement.cpp:
60         * ksvg2/svg/SVGPatternElement.cpp:
61         * ksvg2/svg/svgpathparser.cpp:
62         * platform/Path.cpp:
63         * platform/graphics/svg/SVGResourceImage.h:
64         * rendering/RenderPath.cpp:
65         * rendering/SVGRenderAsText.cpp:
66
67 2006-11-02  Mitz Pettel  <mitz@webkit.org>
68
69         Reviewed by Adele.
70
71         - Fix a regression from r17521: painting of and crash caused by tables
72           with collapsed borders
73
74         * rendering/RenderTable.cpp:
75         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
76         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
77         and 'paintInfo' is the parameter, which we were accidently modifying.
78
79 2006-11-01  Adele Peterson  <adele@apple.com>
80
81         Reviewed by Mitz.
82
83         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
84         REGRESSION: Incomplete repaint of overflow areas when deleting
85
86         Restrict the repaint rect for overflow blocks after the height has been fully computed.
87         Also, adjust the repaint rect coordinates for the scroll offset.
88
89         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
90         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
91
92 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
93
94         Reviewed by Mitz.
95
96         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
97         Rename the "p" member variable of the PaintInfo struct to "context"
98
99         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
100           'context' and 'rect' respectively.
101
102         - Assorted surrounding cleanups.
103
104         * rendering/EllipsisBox.cpp:
105         (WebCore::EllipsisBox::paint):
106         * rendering/EllipsisBox.h:
107         * rendering/InlineBox.cpp:
108         (WebCore::InlineBox::paint):
109         * rendering/InlineFlowBox.cpp:
110         (WebCore::InlineFlowBox::paint):
111         (WebCore::InlineFlowBox::paintBackground):
112         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
113         (WebCore::InlineFlowBox::paintDecorations):
114         * rendering/InlineFlowBox.h:
115         * rendering/InlineRunBox.h:
116         * rendering/InlineTextBox.cpp:
117         (WebCore::InlineTextBox::paint):
118         * rendering/InlineTextBox.h:
119         * rendering/RenderBlock.cpp:
120         (WebCore::RenderBlock::paint):
121         (WebCore::RenderBlock::paintChildren):
122         (WebCore::RenderBlock::paintCaret):
123         (WebCore::RenderBlock::paintObject):
124         (WebCore::RenderBlock::paintFloats):
125         (WebCore::RenderBlock::paintEllipsisBoxes):
126         (WebCore::RenderBlock::paintSelection):
127         (WebCore::RenderBlock::fillSelectionGaps):
128         (WebCore::RenderBlock::fillInlineSelectionGaps):
129         (WebCore::RenderBlock::fillBlockSelectionGaps):
130         (WebCore::RenderBlock::fillHorizontalSelectionGap):
131         (WebCore::RenderBlock::fillVerticalSelectionGap):
132         (WebCore::RenderBlock::fillLeftSelectionGap):
133         (WebCore::RenderBlock::fillRightSelectionGap):
134         * rendering/RenderBox.cpp:
135         (WebCore::RenderBox::paint):
136         (WebCore::RenderBox::paintRootBoxDecorations):
137         (WebCore::RenderBox::paintBoxDecorations):
138         * rendering/RenderBox.h:
139         * rendering/RenderButton.cpp:
140         (WebCore::RenderButton::paintObject):
141         * rendering/RenderFieldset.cpp:
142         (WebCore::RenderFieldset::paintBoxDecorations):
143         * rendering/RenderFileUploadControl.cpp:
144         (WebCore::RenderFileUploadControl::paintObject):
145         * rendering/RenderFlow.cpp:
146         (WebCore::RenderFlow::continuationBefore):
147         (WebCore::RenderFlow::addChildWithContinuation):
148         (WebCore::RenderFlow::addChild):
149         (WebCore::RenderFlow::attachLineBox):
150         (WebCore::RenderFlow::destroy):
151         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
152         (WebCore::RenderFlow::dirtyLineBoxes):
153         (WebCore::RenderFlow::createInlineBox):
154         (WebCore::RenderFlow::paintLines):
155         (WebCore::RenderFlow::getAbsoluteRepaintRect):
156         (WebCore::RenderFlow::lowestPosition):
157         (WebCore::RenderFlow::rightmostPosition):
158         (WebCore::RenderFlow::leftmostPosition):
159         (WebCore::RenderFlow::caretRect):
160         (WebCore::RenderFlow::addFocusRingRects):
161         (WebCore::RenderFlow::paintOutline):
162         (WebCore::RenderFlow::paintOutlineForLine):
163         * rendering/RenderForeignObject.cpp:
164         (WebCore::RenderForeignObject::paint):
165         * rendering/RenderHTMLCanvas.cpp:
166         (WebCore::RenderHTMLCanvas::paint):
167         * rendering/RenderImage.cpp:
168         (WebCore::RenderImage::paint):
169         * rendering/RenderLayer.cpp:
170         (WebCore::RenderLayer::paintLayer):
171         * rendering/RenderListBox.cpp:
172         (WebCore::RenderListBox::paintObject):
173         (WebCore::RenderListBox::paintScrollbar):
174         (WebCore::RenderListBox::paintItemForeground):
175         (WebCore::RenderListBox::paintItemBackground):
176         * rendering/RenderListMarker.cpp:
177         (WebCore::RenderListMarker::paint):
178         * rendering/RenderMenuList.cpp:
179         (WebCore::RenderMenuList::paintObject):
180         * rendering/RenderObject.cpp:
181         (WebCore::RenderObject::paint):
182         * rendering/RenderObject.h:
183         (WebCore::RenderObject::PaintInfo::PaintInfo):
184         (WebCore::RenderObject::paintBoxDecorations):
185         (WebCore::RenderObject::paintingRootForChildren):
186         (WebCore::RenderObject::shouldPaintWithinRoot):
187         (WebCore::RenderObject::printBoxDecorations):
188         * rendering/RenderPath.cpp:
189         (WebCore::RenderPath::paint):
190         * rendering/RenderReplaced.cpp:
191         (WebCore::RenderReplaced::shouldPaint):
192         * rendering/RenderSVGContainer.cpp:
193         (WebCore::RenderSVGContainer::paint):
194         * rendering/RenderSVGContainer.h:
195         * rendering/RenderSVGImage.cpp:
196         (WebCore::RenderSVGImage::paint):
197         * rendering/RenderSVGText.cpp:
198         (WebCore::RenderSVGText::paint):
199         * rendering/RenderSVGText.h:
200         (WebCore::RenderSVGText::renderName):
201         * rendering/RenderTable.cpp:
202         (WebCore::RenderTable::paint):
203         (WebCore::RenderTable::paintBoxDecorations):
204         * rendering/RenderTable.h:
205         * rendering/RenderTableCell.cpp:
206         (WebCore::RenderTableCell::paint):
207         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
208         (WebCore::RenderTableCell::paintBoxDecorations):
209         * rendering/RenderTableCell.h:
210         * rendering/RenderTableRow.cpp:
211         (WebCore::RenderTableRow::paint):
212         * rendering/RenderTableRow.h:
213         * rendering/RenderTableSection.cpp:
214         (WebCore::RenderTableSection::paint):
215         * rendering/RenderTableSection.h:
216         (WebCore::RenderTableSection::getBaseline):
217         (WebCore::RenderTableSection::setNeedCellRecalc):
218         * rendering/RenderText.h:
219         (WebCore::RenderText::renderName):
220         (WebCore::RenderText::paint):
221         (WebCore::RenderText::element):
222         * rendering/RenderTheme.cpp:
223         (WebCore::RenderTheme::paint):
224         (WebCore::RenderTheme::paintBorderOnly):
225         (WebCore::RenderTheme::paintDecorations):
226         * rendering/RenderTheme.h:
227         (WebCore::RenderTheme::RenderTheme):
228         (WebCore::RenderTheme::~RenderTheme):
229         (WebCore::RenderTheme::controlSupportsTints):
230         (WebCore::RenderTheme::adjustRepaintRect):
231         (WebCore::RenderTheme::themeChanged):
232         (WebCore::RenderTheme::supportsHover):
233         (WebCore::RenderTheme::paintCheckbox):
234         (WebCore::RenderTheme::setCheckboxSize):
235         (WebCore::RenderTheme::paintRadio):
236         (WebCore::RenderTheme::setRadioSize):
237         (WebCore::RenderTheme::paintButton):
238         (WebCore::RenderTheme::setButtonSize):
239         (WebCore::RenderTheme::paintTextField):
240         (WebCore::RenderTheme::paintTextArea):
241         (WebCore::RenderTheme::paintMenuList):
242         (WebCore::RenderTheme::paintMenuListButton):
243         * rendering/RenderThemeMac.mm:
244         (WebCore::RenderThemeMac::paintCheckbox):
245         (WebCore::RenderThemeMac::paintRadio):
246         (WebCore::RenderThemeMac::paintButton):
247         (WebCore::RenderThemeMac::paintTextField):
248         (WebCore::RenderThemeMac::paintTextArea):
249         (WebCore::RenderThemeMac::paintMenuList):
250         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
251         (WebCore::RenderThemeMac::paintMenuListButton):
252         * rendering/RenderView.cpp:
253         (WebCore::RenderView::paint):
254         (WebCore::RenderView::paintBoxDecorations):
255         * rendering/RenderView.h:
256         * rendering/RenderWidget.cpp:
257         (WebCore::RenderWidget::paint):
258         * rendering/RenderWidget.h:
259         (WebCore::RenderWidget::isWidget):
260         * rendering/RootInlineBox.cpp:
261         (WebCore::RootInlineBox::paintEllipsisBox):
262         (WebCore::RootInlineBox::paintCustomHighlight):
263         (WebCore::RootInlineBox::paint):
264         (WebCore::RootInlineBox::fillLineSelectionGap):
265         * rendering/RootInlineBox.h:
266         * rendering/SVGInlineFlowBox.cpp:
267         (WebCore::paintSVGInlineFlow):
268
269 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
270
271         Reviewed by Oliver, Brady.
272
273         * platform/network/ResourceResponse.h:
274         (WebCore::ResourceResponse::setLastModifiedDate):
275         (WebCore::ResourceResponse::lastModifiedDate):
276         Add getters and setters for last modified dadte.
277         
278         * platform/network/cf/ResourceResponseCFNet.cpp:
279         (WebCore::getResourceResponse):
280         Fetch the last modified date. Add correct offset to expired date.
281
282 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
283
284         Reviewed by Mitz.
285
286         Added missing "break;" statement in switch statement from r17493.
287
288         Bug 11442: [CSS 3] support for cursor: all-scroll
289         http://bugs.webkit.org/show_bug.cgi?id=11442
290
291         * css/CSSComputedStyleDeclaration.cpp:
292         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
293
294 2006-10-31  Mitz Pettel  <mitz@webkit.org>
295
296         Reviewed by Maciej.
297
298         - fix image dragging
299
300         This is covered by editing/selection/drag-to-contenteditable-iframe.html
301
302         * rendering/HitTestResult.cpp:
303         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
304         HTML IMG elements.
305         (WebCore::HitTestResult::absoluteImageURL): Ditto.
306
307 2006-10-31  Beth Dakin  <bdakin@apple.com>
308
309         Reviewed by Maciej.
310
311         This adds the back-end of the remaining WebElementDictionary 
312         functions into HitTestResult.
313
314         * WebCore.exp:
315         * rendering/HitTestResult.cpp:
316         (WebCore::HitTestResult::title):
317         (WebCore::displayString): This is nearly identical to the 
318         displayString() defined in DOMInternal.mm except that it returns a 
319         String instead of an NSString. The old code path used the 
320         DOMInternal method, so I made a new one here for the new code path.
321         (WebCore::HitTestResult::altDisplayString):
322         (WebCore::HitTestResult::image):
323         (WebCore::HitTestResult::absoluteImageURL):
324         (WebCore::HitTestResult::absoluteLinkURL):
325         (WebCore::HitTestResult::titleDisplayString):
326         (WebCore::HitTestResult::textContent):
327         * rendering/HitTestResult.h:
328
329 2006-10-31  John Sullivan  <sullivan@apple.com>
330
331         * bridge/mac/FrameMac.mm:
332         (WebCore::FrameMac::markMisspellings):
333         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
334
335 2006-10-31  John Sullivan  <sullivan@apple.com>
336
337         Reviewed by Maciej
338         
339         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
340         
341         The foundation of this was in my last checkin. This checkin is all about displaying
342         the correct string in the toolTip.
343
344         * dom/DocumentMarker.h:
345         New description field in this struct.
346
347         * bridge/mac/FrameMac.mm:
348         (WebCore::FrameMac::advanceToNextMisspelling):
349         When adding a grammar marker, supply the appropriate description. Also, added a comment
350         about the remaining work to make grammar checking return sensible answers.
351         (WebCore::FrameMac::markMisspellings):
352         ditto (yes, still needs some refactoring to minimize duplicated code)
353         
354         * dom/Document.h:
355         * dom/Document.cpp:
356         (WebCore::Document::addMarker):
357         Now takes an optional description string
358         (WebCore::Document::markerContainingPoint):
359         New function, returns a pointer to the (first) marker of the specified type whose rect 
360         contains the specified point, or 0 if none.
361         
362         * rendering/HitTestResult.cpp:
363         (WebCore::HitTestResult::spellingToolTip):
364         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
365         and gets the description from the marker.
366
367 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
368
369         Reviewed by Maciej.
370         
371         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
372
373         * loader/mac/FrameLoaderMac.mm:
374         (WebCore::FrameLoader::createWindow):
375         * manual-tests/window-open-features-parsing.html: Updated for clarity.
376
377 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
378
379         Reviewed by Alice.
380
381         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
382         to WebCore::Editor.
383         
384         Layout tests pass.
385         
386         Renamed "may*" to "can*" because "can" is more accurate (these functions
387         aren't just about permission) and it matches WebKit.
388
389         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
390         password field. Now that WebCore fully implements canCopy(), it doesn't just
391         mean "the selection is not in a password field" anymore.
392         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
393         The fact that it's not called anymore may represent a security issue, but I
394         don't see how commented-out code will help reveal the issue, and the
395         bridge is going away, anyway.
396         * editing/SelectionController.h: Changed selection() calls to references
397         to m_sel, to match the rest of the file.
398
399 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
400
401         Reviewed by harrison
402         
403         <rdar://problem/4711063>
404         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
405
406         * editing/ReplaceSelectionCommand.cpp:
407         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
408         insertion and plain text string creation unless we need the string
409         for a BeforeTextInserted event handler or for a plain text only region.
410         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
411         code here from ReplacementFragment's constructor.
412         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
413         FIXME.
414         * editing/ReplaceSelectionCommand.h:
415
416 2006-10-31  Ada Chan  <adachan@apple.com>
417
418         Reviewed by Adam
419
420         Correct forward declarations of the HitTestRequest struct.
421
422         * rendering/EllipsisBox.h:
423         * rendering/InlineBox.h:
424         * rendering/InlineFlowBox.h:
425         * rendering/RenderLayer.h:
426         * rendering/RenderObject.h:
427
428 2006-10-31  John Sullivan  <sullivan@apple.com>
429
430         Reviewed by Beth and Adam
431
432         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
433         next I'll make it use a string that's relevant for a specific grammar error.
434
435         * WebCore.exp:
436         export symbol for spellingToolTip function
437         
438         * rendering/HitTestResult.h:
439         * rendering/HitTestResult.cpp:
440         (WebCore::HitTestResult::spellingToolTip):
441         new function, returns the string to be used in a tool tip that describes the questionable grammar
442         
443         * rendering/InlineTextBox.h:
444         * rendering/InlineTextBox.cpp:
445         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
446         now takes a style and font, needed to compute the rect representing the range containing
447         questionable grammar. Computes the rect and associates it with the marker.
448         (WebCore::InlineTextBox::paintDocumentMarkers):
449         Pass in the style and font now needed by paintSpellingOrGrammarMarker
450
451 2006-10-31  Adele Peterson  <adele@apple.com>
452
453         Removed commented out variable from last checkin.
454
455         * html/HTMLSelectElement.cpp:
456         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
457
458 2006-10-31  Brady Eidson  <beidson@apple.com>
459
460         Build fix (unused variable in release builds)
461
462         * html/HTMLSelectElement.cpp:
463         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
464
465 2006-10-31  Adele Peterson  <adele@apple.com>
466
467         Reviewed by Adam.
468
469         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
470         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
471         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
472
473         Tests: 
474         * LayoutTests/fast/forms/listbox-selection.html
475         * LayoutTests/fast/forms/listbox-onchange.html
476
477         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
478           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
479           And one for onChange, that is updated after onChange is fired.
480           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
481  
482         * html/HTMLSelectElement.cpp:
483         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
484         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
485         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
486         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
487         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
488         (WebCore::HTMLSelectElement::setExtent): Added.
489         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
490         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
491
492         * rendering/RenderListBox.cpp:
493         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
494         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
495         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
496         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
497          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
498          notify the select element from here.
499         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
500         (WebCore::RenderListBox::listIndexIsVisible): Added.
501         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
502
503         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
504         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
505         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
506         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
507         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
508
509 2006-10-31  Beth Dakin  <bdakin@apple.com>
510
511         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
512
513         * rendering/HitTestRequest.h: Added.
514         (WebCore::HitTestRequest::HitTestRequest):
515
516 2006-10-31  Beth Dakin  <bdakin@apple.com>
517
518         Reviewed by Maciej.
519
520         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
521         should be split into HitTestRequest and HitTestResult
522
523         This patch creates a new struct called HitTestRequest that holds 
524         the three boolean values (readonly, active, and mouseMove) that 
525         were formerly a part of HitTestResult. All hitTest() and 
526         nodeAtPoint() functions now take a HitTestRequest in addition to 
527         the HitTestResult.
528
529         * WebCore.exp:
530         * WebCore.xcodeproj/project.pbxproj:
531         * bridge/mac/FrameMac.mm:
532         (WebCore::FrameMac::eventMayStartDrag):
533         (WebCore::FrameMac::handleMouseMoveEvent):
534         * bridge/mac/WebCoreAXObject.mm:
535         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
536         (-[WebCoreAXObject accessibilityHitTest:]):
537         * dom/Document.cpp:
538         (WebCore::Document::elementFromPoint):
539         (WebCore::Document::prepareMouseEvent):
540         * editing/SelectionController.cpp:
541         (WebCore::SelectionController::contains):
542         * page/Frame.cpp:
543         (WebCore::Frame::hitTestResultAtPoint):
544         * page/FrameView.cpp:
545         (WebCore::FrameView::handleWheelEvent):
546         * rendering/EllipsisBox.cpp:
547         (WebCore::EllipsisBox::nodeAtPoint):
548         * rendering/EllipsisBox.h:
549         * rendering/HitTestResult.cpp:
550         (WebCore::HitTestResult::HitTestResult):
551         (WebCore::HitTestResult::operator=):
552         * rendering/HitTestResult.h:
553         * rendering/InlineBox.cpp:
554         (WebCore::InlineBox::nodeAtPoint):
555         * rendering/InlineBox.h:
556         * rendering/InlineFlowBox.cpp:
557         (WebCore::InlineFlowBox::nodeAtPoint):
558         * rendering/InlineFlowBox.h:
559         * rendering/InlineTextBox.cpp:
560         (WebCore::InlineTextBox::nodeAtPoint):
561         * rendering/InlineTextBox.h:
562         * rendering/RenderBlock.cpp:
563         (WebCore::RenderBlock::nodeAtPoint):
564         * rendering/RenderBlock.h:
565         * rendering/RenderBox.cpp:
566         (WebCore::RenderBox::nodeAtPoint):
567         * rendering/RenderBox.h:
568         * rendering/RenderFlow.cpp:
569         (WebCore::RenderFlow::hitTestLines):
570         * rendering/RenderFlow.h:
571         * rendering/RenderForeignObject.cpp:
572         (WebCore::RenderForeignObject::nodeAtPoint):
573         * rendering/RenderForeignObject.h:
574         * rendering/RenderFrameSet.cpp:
575         (WebCore::RenderFrameSet::nodeAtPoint):
576         * rendering/RenderFrameSet.h:
577         * rendering/RenderImage.cpp:
578         (WebCore::RenderImage::nodeAtPoint):
579         * rendering/RenderImage.h:
580         * rendering/RenderInline.cpp:
581         (WebCore::RenderInline::nodeAtPoint):
582         * rendering/RenderInline.h:
583         * rendering/RenderLayer.cpp:
584         (WebCore::RenderLayer::autoscroll):
585         (WebCore::RenderLayer::hitTest):
586         (WebCore::RenderLayer::hitTestLayer):
587         (WebCore::RenderLayer::updateHoverActiveState):
588         * rendering/RenderLayer.h:
589         * rendering/RenderObject.cpp:
590         (WebCore::RenderObject::hitTest):
591         (WebCore::RenderObject::nodeAtPoint):
592         * rendering/RenderObject.h:
593         * rendering/RenderPath.cpp:
594         (WebCore::RenderPath::nodeAtPoint):
595         * rendering/RenderPath.h:
596         * rendering/RenderSVGImage.cpp:
597         (WebCore::RenderSVGImage::nodeAtPoint):
598         * rendering/RenderSVGImage.h:
599         * rendering/RenderSVGText.cpp:
600         (WebCore::RenderSVGText::nodeAtPoint):
601         * rendering/RenderSVGText.h:
602         * rendering/RenderTableRow.cpp:
603         (WebCore::RenderTableRow::nodeAtPoint):
604         * rendering/RenderTableRow.h:
605         * rendering/RenderTableSection.cpp:
606         (WebCore::RenderTableSection::nodeAtPoint):
607         * rendering/RenderTableSection.h:
608         * rendering/RenderText.h:
609         (WebCore::RenderText::nodeAtPoint):
610         * rendering/RenderTextControl.cpp:
611         (WebCore::RenderTextControl::nodeAtPoint):
612         * rendering/RenderTextControl.h:
613         * rendering/RootInlineBox.cpp:
614         (WebCore::RootInlineBox::nodeAtPoint):
615         * rendering/RootInlineBox.h:
616
617 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
618
619         Reviewed by Maciej.
620
621         Bug 11442: [CSS 3] support for cursor: all-scroll
622         http://bugs.webkit.org/show_bug.cgi?id=11442
623
624         * css/CSSComputedStyleDeclaration.cpp:
625         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
626         * css/CSSValueKeywords.in:
627         * css/cssparser.cpp:
628         (WebCore::CSSParser::parseValue):
629         * page/FrameView.cpp:
630         (WebCore::selectCursor):
631         * rendering/RenderStyle.h:
632
633 2006-10-31  Oliver Hunt  <oliver@apple.com>
634
635         Reviewed by Geoff.
636
637         Converting Obj-C++ to C++ in kcanvas
638
639         * WebCore.xcodeproj/project.pbxproj:
640         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
641         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
642         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
643         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
644         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
645         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
646         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
647         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
648         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
649         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
650         * kcanvas/device/quartz/QuartzSupport.h:
651         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
652         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
653         (WebCore::SVGResourceClipper::applyClip):
654         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
655         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
656         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
657
658 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
659
660         Reviewed by harrison
661         
662         <rdar://problem/4808375>
663         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
664         
665         Completely back out r17276 because of performance issues.
666
667         * editing/TextIterator.cpp:
668         (WebCore::TextIterator::TextIterator):
669         (WebCore::TextIterator::advance):
670         (WebCore::TextIterator::handleTextNode):
671         (WebCore::TextIterator::handleTextBox):
672         (WebCore::TextIterator::handleReplacedElement):
673         (WebCore::TextIterator::handleNonTextNode):
674         (WebCore::TextIterator::exitNode):
675         (WebCore::TextIterator::emitCharacter):
676         (WebCore::TextIterator::range):
677         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
678         (WebCore::SimplifiedBackwardsTextIterator::advance):
679         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
680         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
681         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
682         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
683         (WebCore::SimplifiedBackwardsTextIterator::range):
684         (WebCore::CharacterIterator::range):
685         (WebCore::TextIterator::rangeFromLocationAndLength):
686         * editing/TextIterator.h:
687         (WebCore::TextIterator::atEnd):
688         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
689
690 2006-10-31  Darin Adler  <darin@apple.com>
691
692         Reviewed by Brady.
693
694         - got "action dictionary" code out of FrameLoader,
695           replacing with a class called NavigationAction
696
697         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
698         * loader/mac/DocumentLoaderMac.mm:
699         (WebCore::DocumentLoader::triggeringAction): Ditto.
700         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
701
702         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
703
704         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
705         Removed elementForEvent.
706         * loader/mac/FrameLoaderMac.mm:
707         (WebCore::FrameLoader::load): Ditto.
708         (WebCore::FrameLoader::reload): Ditto.
709         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
710         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
711         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
712         (WebCore::FrameLoader::post): Ditto.
713
714         * loader/NavigationAction.h: Added.
715         * loader/NavigationAction.cpp: Added.
716         * loader/mac/NavigationActionMac.mm: Added.
717
718         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
719
720         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
721         * WebCore.exp: Updated.
722
723 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
724
725         Reviewed by Adam.
726
727         Build fix
728
729         * platform/win/CookieJarWin.cpp:
730         (WebCore::cookies):
731
732 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
733
734         Reviewed by Maciej. Landed by Adam.
735
736         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
737
738         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
739         as dicussed with Dave. Also kill the outdated DESIGN document.
740
741         * CMakeLists.txt:
742         * WebCore.xcodeproj/project.pbxproj:
743         * kcanvas/DESIGN: Removed.
744         * kcanvas/KCanvasFilters.cpp:
745         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
746         * kcanvas/KCanvasTreeDebug.h: Ditto.
747         * kcanvas/device/KRenderingPaintServerGradient.cpp:
748         * kcanvas/device/KRenderingPaintServerPattern.cpp:
749         * kcanvas/device/KRenderingPaintServerSolid.cpp:
750         * platform/graphics/svg/SVGResourceClipper.cpp:
751         * rendering/RenderTreeAsText.cpp:
752         * rendering/SVGRenderTreeAsText.cpp: Added.
753         * rendering/SVGRenderTreeAsText.h: Added.
754         (WebCore::operator<<):
755
756 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
757
758         Reviewed by Maciej.
759
760         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
761         Includes some CRLF -> LF fixups.
762
763         * platform/win/CookieJarWin.cpp:
764         (WebCore::cookies):
765
766 2006-10-31  Adam Roben  <aroben@apple.com>
767
768         Reviewed by Steve.
769
770         Fix some incorrect forward declarations.
771
772         * loader/FrameLoader.h:
773         * page/Frame.h:
774
775 2006-10-31  Darin Adler  <darin@apple.com>
776
777         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
778         try to fix the build on the buildbot.
779
780 2006-10-31  Darin Adler  <darin@apple.com>
781
782         * bridge/mac/FrameMac.mm:
783         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
784         (WebCore::FrameMac::markMisspellings): Ditto.
785
786 2006-10-31  John Sullivan  <sullivan@apple.com>
787
788         * bridge/mac/FrameMac.mm:
789         (WebCore::FrameMac::advanceToNextMisspelling):
790         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
791
792 2006-10-30  John Sullivan  <sullivan@apple.com>
793
794         Reviewed by Adam Roben
795         
796         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
797         
798         This patch introduces much of the guts of grammar checking, though still not enough to actually
799         check grammar sensibly, due to:
800           
801         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
802         context passed to grammar checker
803
804         * platform/Logging.h:
805         * platform/Logging.cpp:
806         new log channel SpellingAndGrammar
807
808         * bridge/mac/WebCorePageBridge.mm:
809         (initializeLoggingChannelsIfNecessary):
810         initialize new log channel
811
812         * bridge/mac/FrameMac.mm:
813         (WebCore::FrameMac::advanceToNextMisspelling):
814         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
815         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
816         in the event of a tie), and do further processing with that one (select range; create marker that
817         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
818         (WebCore::FrameMac::markMisspellings):
819         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
820         differently enough to make sharing code between these two functions a little tricky, so I decided to 
821         save that for a later patch.
822         
823         (WebCore::FrameMac::respondToChangedSelection):
824         remove grammar markers when we remove spelling markers        
825
826 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
827
828         Reviewed by Mitz.
829
830         Fix Qt/Linux build with older gcc3.3.4.
831
832         * bindings/js/kjs_window.cpp:
833         (KJS::WindowFunc::callAsFunction):
834
835 2006-10-31  Zack Rusin  <zack@kde.org>
836
837         Reviewed by Mitz.
838
839         Fix the Qt build after last nights changes.
840
841         * WebCore/platform/qt/FrameQt.cpp:
842         * WebCore/platform/qt/EditorClientQt.h:
843         * WebCore/platform/qt/EditorClientQt.cpp:
844         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
845         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
846         * WebCore/CMakeLists.txt:
847         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
848         * WebKitQt/QtLauncher/CMakeLists.txt:
849         * WebKitQt/WebKitPart/CMakeLists.txt:
850
851 2006-10-30  Darin Adler  <darin@apple.com>
852
853         Reviewed by Anders.
854
855         - remove BrowserExtension
856
857         * WebCore.vcproj/WebCore/WebCore.vcproj:
858         * WebCore.xcodeproj/project.pbxproj:
859         * bindings/js/kjs_window.cpp:
860         (KJS::createNewWindow):
861         (KJS::WindowFunc::callAsFunction):
862         * bridge/BrowserExtension.h: Removed.
863         * bridge/mac/BrowserExtensionMac.h: Removed.
864         * bridge/mac/BrowserExtensionMac.mm: Removed.
865         * bridge/mac/FrameMac.mm:
866         (WebCore::FrameMac::FrameMac):
867         (WebCore::FrameMac::submitForm):
868         (WebCore::FrameMac::urlSelected):
869         * bridge/win/BrowserExtensionWin.cpp: Removed.
870         * bridge/win/BrowserExtensionWin.h: Removed.
871         * bridge/win/FrameWin.cpp:
872         (WebCore::FrameWin::FrameWin):
873         * loader/FrameLoader.cpp:
874         (WebCore::FrameLoader::createWindow):
875         * loader/FrameLoader.h:
876         * loader/icon/IconLoader.cpp:
877         * loader/mac/FrameLoaderMac.mm:
878         (WebCore::FrameLoader::safeLoad):
879         (WebCore::FrameLoader::load):
880         (WebCore::FrameLoader::createWindow):
881         * page/Frame.cpp:
882         (WebCore::Frame::urlSelected):
883         (WebCore::Frame::requestFrame):
884         (WebCore::Frame::submitForm):
885         (WebCore::Frame::scheduleHistoryNavigation):
886         (WebCore::Frame::redirectionTimerFired):
887         * page/Frame.h:
888         * page/FrameLoadRequest.h:
889         (WebCore::FrameLoadRequest::FrameLoadRequest):
890         (WebCore::FrameLoadRequest::isEmpty):
891         (WebCore::FrameLoadRequest::resourceRequest):
892         (WebCore::FrameLoadRequest::frameName):
893         (WebCore::FrameLoadRequest::setFrameName):
894         * page/FramePrivate.h:
895         (WebCore::FramePrivate::FramePrivate):
896         (WebCore::FramePrivate::~FramePrivate):
897         * platform/gdk/BrowserExtensionGdk.h: Removed.
898         * platform/gdk/FrameGdk.cpp:
899         (WebCore::FrameGdk::FrameGdk):
900         * platform/gdk/TemporaryLinkStubs.cpp:
901         * platform/network/ResourceRequest.h:
902         (WebCore::ResourceRequest::isEmpty):
903
904 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
905
906         Reviewed by Oliver.
907
908         Modified from original due to earlier reversion
909
910         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
911
912         Better SVG integration in WebKit, Part I.
913
914         The patch is mostly about creating a new platform/graphics directory, and
915         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
916         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
917         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
918
919         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
920         All details of the patch, and upcoming patches can be found in the bug report.
921
922         * CMakeLists.txt:
923         * WebCore.xcodeproj/project.pbxproj:
924         * graphics/svg/SVGResource.cpp: Removed.
925         * graphics/svg/SVGResourceClipper.cpp: Removed.
926         * graphics/svg/SVGResourceClipper.h: Removed.
927         * graphics/svg/SVGResourceImage.h: Removed.
928         * graphics/svg/SVGResourceListener.h: Removed.
929         * graphics/svg/SVGResourceMarker.cpp: Removed.
930         * graphics/svg/SVGResourceMarker.h: Removed.
931         * graphics/svg/SVGResourceMasker.cpp: Removed.
932         * graphics/svg/SVGResourceMasker.h: Removed.
933         * kcanvas/KCanvasClipper.cpp: Removed.
934         * kcanvas/KCanvasClipper.h: Removed.
935         * kcanvas/KCanvasCreator.cpp: Removed.
936         * kcanvas/KCanvasCreator.h: Removed.
937         * kcanvas/KCanvasFilters.cpp:
938         (WebCore::getFilterById):
939         * kcanvas/KCanvasFilters.h:
940         * kcanvas/KCanvasImage.h: Removed.
941         * kcanvas/KCanvasMarker.cpp: Removed.
942         * kcanvas/KCanvasMarker.h: Removed.
943         * kcanvas/KCanvasMasker.cpp: Removed.
944         * kcanvas/KCanvasMasker.h: Removed.
945         * kcanvas/KCanvasResource.cpp: Removed.
946         * kcanvas/KCanvasResource.h: Removed.
947         * kcanvas/KCanvasResourceListener.h: Removed.
948         * kcanvas/KCanvasTreeDebug.cpp:
949         (WebCore::writeRenderResources):
950         * kcanvas/device/KRenderingDevice.h:
951         * kcanvas/device/KRenderingPaintServer.h:
952         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
953         * kcanvas/device/KRenderingPaintServerGradient.cpp:
954         (WebCore::KRenderingPaintServerGradient::listener):
955         (WebCore::KRenderingPaintServerGradient::setListener):
956         * kcanvas/device/KRenderingPaintServerGradient.h:
957         * kcanvas/device/KRenderingPaintServerPattern.cpp:
958         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
959         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
960         (WebCore::KRenderingPaintServerPattern::tile):
961         (WebCore::KRenderingPaintServerPattern::setTile):
962         (WebCore::KRenderingPaintServerPattern::listener):
963         (WebCore::KRenderingPaintServerPattern::setListener):
964         * kcanvas/device/KRenderingPaintServerPattern.h:
965         * kcanvas/device/KRenderingPaintServerSolid.h:
966         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
967         * kcanvas/device/qt/KCanvasClipperQt.h:
968         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
969         (WebCore::KRenderingDeviceQt::contextForImage):
970         (WebCore::KRenderingDeviceQt::createResource):
971         (WebCore::KRenderingDeviceQt::createPaintServer):
972         * kcanvas/device/qt/KRenderingDeviceQt.h:
973         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
974         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
975         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
976         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
977         * kcanvas/device/qt/RenderPathQt.h: Removed.
978         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
979         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
980         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
981         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
982         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
983         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
984         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
985         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
986         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
987         (WebCore::KRenderingDeviceQuartz::contextForImage):
988         (WebCore::KRenderingDeviceQuartz::createPaintServer):
989         (WebCore::KRenderingDeviceQuartz::createResource):
990         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
991         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
992         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
993         (WebCore::KRenderingPaintServerGradientQuartz::setup):
994         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
995         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
996         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
997         (WebCore::patternCallback):
998         (WebCore::KRenderingPaintServerPatternQuartz::setup):
999         * kcanvas/device/quartz/QuartzSupport.mm:
1000         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1001         (WebCore::sharedSolidPaintServer):
1002         * ksvg2/svg/SVGClipPathElement.cpp:
1003         (WebCore::SVGClipPathElement::SVGClipPathElement):
1004         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1005         (WebCore::SVGClipPathElement::canvasResource):
1006         * ksvg2/svg/SVGClipPathElement.h:
1007         * ksvg2/svg/SVGFEImageElement.cpp:
1008         * ksvg2/svg/SVGFilterElement.cpp:
1009         (WebCore::SVGFilterElement::SVGFilterElement):
1010         (WebCore::SVGFilterElement::~SVGFilterElement):
1011         (WebCore::SVGFilterElement::canvasResource):
1012         * ksvg2/svg/SVGFilterElement.h:
1013         * ksvg2/svg/SVGGradientElement.cpp:
1014         (WebCore::SVGGradientElement::SVGGradientElement):
1015         (WebCore::SVGGradientElement::~SVGGradientElement):
1016         (WebCore::SVGGradientElement::canvasResource):
1017         (WebCore::SVGGradientElement::resourceNotification):
1018         * ksvg2/svg/SVGGradientElement.h:
1019         * ksvg2/svg/SVGImageElement.cpp:
1020         * ksvg2/svg/SVGLinearGradientElement.cpp:
1021         (WebCore::SVGLinearGradientElement::buildGradient):
1022         * ksvg2/svg/SVGLinearGradientElement.h:
1023         * ksvg2/svg/SVGMarkerElement.cpp:
1024         (WebCore::SVGMarkerElement::SVGMarkerElement):
1025         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1026         (WebCore::SVGMarkerElement::canvasResource):
1027         * ksvg2/svg/SVGMarkerElement.h:
1028         * ksvg2/svg/SVGMaskElement.cpp:
1029         (WebCore::SVGMaskElement::SVGMaskElement):
1030         (WebCore::SVGMaskElement::~SVGMaskElement):
1031         (WebCore::SVGMaskElement::drawMaskerContent):
1032         (WebCore::SVGMaskElement::canvasResource):
1033         * ksvg2/svg/SVGMaskElement.h:
1034         * ksvg2/svg/SVGPatternElement.cpp:
1035         (WebCore::SVGPatternElement::SVGPatternElement):
1036         (WebCore::SVGPatternElement::~SVGPatternElement):
1037         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1038         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1039         (WebCore::SVGPatternElement::canvasResource):
1040         * ksvg2/svg/SVGPatternElement.h:
1041         * ksvg2/svg/SVGRadialGradientElement.cpp:
1042         (WebCore::SVGRadialGradientElement::buildGradient):
1043         * ksvg2/svg/SVGRadialGradientElement.h:
1044         * ksvg2/svg/SVGStyledElement.h:
1045         (WebCore::SVGStyledElement::canvasResource):
1046         * platform/GraphicsContext.cpp: Removed.
1047         * platform/GraphicsContext.h: Removed.
1048         * platform/GraphicsTypes.cpp: Removed.
1049         * platform/GraphicsTypes.h: Removed.
1050         * platform/graphics/GraphicsContext.cpp:
1051         (WebCore::GraphicsContextState::GraphicsContextState):
1052         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1053         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1054         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1055         (WebCore::GraphicsContext::save):
1056         (WebCore::GraphicsContext::restore):
1057         (WebCore::GraphicsContext::font):
1058         (WebCore::GraphicsContext::setFont):
1059         (WebCore::GraphicsContext::pen):
1060         (WebCore::GraphicsContext::setPen):
1061         (WebCore::GraphicsContext::setFillColor):
1062         (WebCore::GraphicsContext::fillColor):
1063         (WebCore::GraphicsContext::updatingControlTints):
1064         (WebCore::GraphicsContext::setUpdatingControlTints):
1065         (WebCore::GraphicsContext::setPaintingDisabled):
1066         (WebCore::GraphicsContext::paintingDisabled):
1067         (WebCore::GraphicsContext::drawImage):
1068         (WebCore::GraphicsContext::drawText):
1069         (WebCore::GraphicsContext::drawHighlightForText):
1070         (WebCore::GraphicsContext::initFocusRing):
1071         (WebCore::GraphicsContext::clearFocusRing):
1072         (WebCore::GraphicsContext::focusRingBoundingRect):
1073         (WebCore::GraphicsContext::addFocusRingRect):
1074         (WebCore::GraphicsContext::focusRingWidth):
1075         (WebCore::GraphicsContext::focusRingOffset):
1076         (WebCore::GraphicsContext::focusRingRects):
1077         (WebCore::GraphicsContext::drawTiledImage):
1078         * platform/graphics/GraphicsContext.h:
1079         * platform/graphics/GraphicsTypes.cpp:
1080         (WebCore::):
1081         (WebCore::parseCompositeOperator):
1082         (WebCore::compositeOperatorName):
1083         (WebCore::parseLineCap):
1084         (WebCore::lineCapName):
1085         (WebCore::parseLineJoin):
1086         (WebCore::lineJoinName):
1087         * platform/graphics/GraphicsTypes.h:
1088         (WebCore::):
1089         * platform/graphics/svg/SVGResource.cpp: Added.
1090         (WebCore::SVGResource::SVGResource):
1091         (WebCore::SVGResource::~SVGResource):
1092         (WebCore::SVGResource::invalidate):
1093         (WebCore::SVGResource::addClient):
1094         (WebCore::SVGResource::clients):
1095         (WebCore::SVGResource::idInRegistry):
1096         (WebCore::SVGResource::setIdInRegistry):
1097         (WebCore::SVGResource::externalRepresentation):
1098         (WebCore::getResourceById):
1099         (WebCore::getPaintServerById):
1100         (WebCore::operator<<):
1101         * platform/graphics/svg/SVGResource.h: Added.
1102         (WebCore::):
1103         (WebCore::SVGResource::isPaintServer):
1104         (WebCore::SVGResource::isFilter):
1105         (WebCore::SVGResource::isClipper):
1106         (WebCore::SVGResource::isMarker):
1107         (WebCore::SVGResource::isMasker):
1108         (WebCore::SVGResourceListener::~SVGResourceListener):
1109         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1110         (WebCore::SVGResourceClipper::SVGResourceClipper):
1111         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1112         (WebCore::SVGResourceClipper::resetClipData):
1113         (WebCore::SVGResourceClipper::addClipData):
1114         (WebCore::SVGResourceClipper::clipData):
1115         (WebCore::SVGResourceClipper::externalRepresentation):
1116         (WebCore::operator<<):
1117         (WebCore::getClipperById):
1118         * platform/graphics/svg/SVGResourceClipper.h: Added.
1119         (WebCore::ClipDataList::addPath):
1120         (WebCore::SVGResourceClipper::isClipper):
1121         * platform/graphics/svg/SVGResourceImage.h: Added.
1122         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1123         (WebCore::SVGResourceMarker::SVGResourceMarker):
1124         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1125         (WebCore::SVGResourceMarker::setMarker):
1126         (WebCore::SVGResourceMarker::setRef):
1127         (WebCore::SVGResourceMarker::draw):
1128         (WebCore::SVGResourceMarker::externalRepresentation):
1129         (WebCore::getMarkerById):
1130         * platform/graphics/svg/SVGResourceMarker.h: Added.
1131         (WebCore::SVGResourceMarker::refX):
1132         (WebCore::SVGResourceMarker::refY):
1133         (WebCore::SVGResourceMarker::setAngle):
1134         (WebCore::SVGResourceMarker::setAutoAngle):
1135         (WebCore::SVGResourceMarker::angle):
1136         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1137         (WebCore::SVGResourceMarker::useStrokeWidth):
1138         (WebCore::SVGResourceMarker::isMarker):
1139         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1140         (WebCore::SVGResourceMasker::SVGResourceMasker):
1141         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1142         (WebCore::SVGResourceMasker::setMask):
1143         (WebCore::SVGResourceMasker::mask):
1144         (WebCore::SVGResourceMasker::externalRepresentation):
1145         (WebCore::getMaskerById):
1146         * platform/graphics/svg/SVGResourceMasker.h: Added.
1147         (WebCore::SVGResourceMasker::isMasker):
1148         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1149         (WebCore::SVGResourceClipper::applyClip):
1150         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1151         (WebCore::SVGResourceImage::SVGResourceImage):
1152         (WebCore::SVGResourceImage::~SVGResourceImage):
1153         (WebCore::SVGResourceImage::init):
1154         (WebCore::SVGResourceImage::size):
1155         (WebCore::SVGResourceImage::cgLayer):
1156         (WebCore::SVGResourceImage::setCGLayer):
1157         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1158         (WebCore::applyLuminanceToAlphaFilter):
1159         (WebCore::applyExpandAlphatoGrayscaleFilter):
1160         (WebCore::transformImageIntoGrayscaleMask):
1161         (WebCore::SVGResourceMasker::applyMask):
1162         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1163         (WebCore::SVGResourceClipper::applyClip):
1164         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1165         (WebCore::SVGResourceImage::init):
1166         (WebCore::SVGResourceImage::size):
1167         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1168         (WebCore::SVGResourceMasker::applyMask):
1169         * platform/qt/GraphicsContextQt.cpp:
1170         * rendering/RenderPath.cpp:
1171         (WebCore::RenderPath::paint):
1172         (WebCore::DrawMarkersData::DrawMarkersData):
1173         (WebCore::RenderPath::drawMarkersIfNeeded):
1174         * rendering/RenderSVGContainer.cpp:
1175         (WebCore::RenderSVGContainer::paint):
1176         * rendering/RenderSVGImage.cpp:
1177         (WebCore::RenderSVGImage::paint):
1178         * rendering/SVGInlineFlowBox.cpp:
1179         (WebCore::paintSVGInlineFlow):
1180
1181 2006-10-30  John Sullivan  <sullivan@apple.com>
1182
1183         Reviewed by Brady
1184         
1185         - minor cleanup to make future patches clearer
1186
1187         * bridge/mac/FrameMac.mm:
1188         (WebCore::FrameMac::advanceToNextMisspelling):
1189         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1190         with "continue" to better match structure of similar code in markMisspellings; a few
1191         other style tweaks.
1192         
1193         (WebCore::FrameMac::markMisspellings):
1194         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1195         a block just after a break and outdented accordingly.
1196
1197 2006-10-30  John Sullivan  <sullivan@apple.com>
1198
1199         Reviewed by Geoff Garen
1200         
1201         WebCore part of change to push the code that updates the spelling panel
1202         into WebCore, in preparation for some grammar-checking stuff.
1203
1204         * bridge/mac/FrameMac.h:
1205         * bridge/mac/FrameMac.mm:
1206         (WebCore::FrameMac::advanceToNextMisspelling):
1207         no more return value for this method, and update the spelling panel with
1208         the misspelled word here rather than in the WebKit callers.
1209
1210 2006-10-30  Oliver Hunt  <oliver@apple.com>
1211
1212         Reviewed by Anders.
1213
1214         Roll out last patch
1215
1216         * CMakeLists.txt:
1217         * ChangeLog:
1218         * WebCore.xcodeproj/project.pbxproj:
1219         * graphics/svg/SVGResource.cpp:
1220         * graphics/svg/SVGResourceClipper.cpp:
1221         * graphics/svg/SVGResourceClipper.h:
1222         * graphics/svg/SVGResourceImage.h:
1223         * graphics/svg/SVGResourceListener.h:
1224         * graphics/svg/SVGResourceMarker.cpp:
1225         * graphics/svg/SVGResourceMarker.h:
1226         * graphics/svg/SVGResourceMasker.cpp:
1227         * graphics/svg/SVGResourceMasker.h:
1228         * kcanvas/KCanvasClipper.cpp: Added.
1229         (WebCore::operator<<):
1230         (WebCore::KCanvasClipper::KCanvasClipper):
1231         (WebCore::KCanvasClipper::~KCanvasClipper):
1232         (WebCore::KCanvasClipper::resetClipData):
1233         (WebCore::KCanvasClipper::addClipData):
1234         (WebCore::KCanvasClipper::clipData):
1235         (WebCore::KCanvasClipper::externalRepresentation):
1236         (WebCore::getClipperById):
1237         * kcanvas/KCanvasClipper.h: Added.
1238         (WebCore::KCClipData::windRule):
1239         (WebCore::KCClipDataList::KCClipDataList):
1240         (WebCore::KCClipDataList::addPath):
1241         (WebCore::KCanvasClipper::isClipper):
1242         * kcanvas/KCanvasFilters.cpp:
1243         (WebCore::getFilterById):
1244         * kcanvas/KCanvasFilters.h:
1245         * kcanvas/KCanvasImage.h: Added.
1246         (WebCore::KCanvasImage::KCanvasImage):
1247         (WebCore::KCanvasImage::~KCanvasImage):
1248         * kcanvas/KCanvasMarker.cpp: Added.
1249         (WebCore::KCanvasMarker::KCanvasMarker):
1250         (WebCore::KCanvasMarker::~KCanvasMarker):
1251         (WebCore::KCanvasMarker::setMarker):
1252         (WebCore::KCanvasMarker::setRef):
1253         (WebCore::KCanvasMarker::refX):
1254         (WebCore::KCanvasMarker::refY):
1255         (WebCore::KCanvasMarker::setAngle):
1256         (WebCore::KCanvasMarker::angle):
1257         (WebCore::KCanvasMarker::setAutoAngle):
1258         (WebCore::KCanvasMarker::setUseStrokeWidth):
1259         (WebCore::KCanvasMarker::useStrokeWidth):
1260         (WebCore::KCanvasMarker::draw):
1261         (WebCore::KCanvasMarker::externalRepresentation):
1262         (WebCore::getMarkerById):
1263         * kcanvas/KCanvasMarker.h: Added.
1264         (WebCore::KCanvasMarker::isMarker):
1265         * kcanvas/KCanvasMasker.cpp: Added.
1266         (WebCore::KCanvasMasker::KCanvasMasker):
1267         (WebCore::KCanvasMasker::~KCanvasMasker):
1268         (WebCore::KCanvasMasker::setMask):
1269         (WebCore::KCanvasMasker::externalRepresentation):
1270         (WebCore::getMaskerById):
1271         * kcanvas/KCanvasMasker.h: Added.
1272         (WebCore::KCanvasMasker::isMasker):
1273         (WebCore::KCanvasMasker::mask):
1274         * kcanvas/KCanvasResource.cpp: Added.
1275         (WebCore::operator<<):
1276         (WebCore::KCanvasResource::KCanvasResource):
1277         (WebCore::KCanvasResource::~KCanvasResource):
1278         (WebCore::KCanvasResource::addClient):
1279         (WebCore::KCanvasResource::clients):
1280         (WebCore::KCanvasResource::invalidate):
1281         (WebCore::KCanvasResource::idInRegistry):
1282         (WebCore::KCanvasResource::setIdInRegistry):
1283         (WebCore::KCanvasResource::externalRepresentation):
1284         (WebCore::getResourceById):
1285         (WebCore::getPaintServerById):
1286         * kcanvas/KCanvasResource.h:
1287         (WebCore::):
1288         (WebCore::KCanvasResource::isPaintServer):
1289         (WebCore::KCanvasResource::isFilter):
1290         (WebCore::KCanvasResource::isClipper):
1291         (WebCore::KCanvasResource::isMarker):
1292         (WebCore::KCanvasResource::isMasker):
1293         * kcanvas/KCanvasResourceListener.h: Added.
1294         (KCanvasResourceListener::KCanvasResourceListener):
1295         (KCanvasResourceListener::~KCanvasResourceListener):
1296         * kcanvas/KCanvasTreeDebug.cpp:
1297         (WebCore::writeRenderResources):
1298         * kcanvas/device/KRenderingDevice.h:
1299         * kcanvas/device/KRenderingPaintServer.h:
1300         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1301         (WebCore::KRenderingPaintServer::idInRegistry):
1302         (WebCore::KRenderingPaintServer::setIdInRegistry):
1303         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1304         (WebCore::KRenderingPaintServerGradient::listener):
1305         (WebCore::KRenderingPaintServerGradient::setListener):
1306         * kcanvas/device/KRenderingPaintServerGradient.h:
1307         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1308         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1309         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1310         (WebCore::KRenderingPaintServerPattern::tile):
1311         (WebCore::KRenderingPaintServerPattern::setTile):
1312         (WebCore::KRenderingPaintServerPattern::listener):
1313         (WebCore::KRenderingPaintServerPattern::setListener):
1314         * kcanvas/device/KRenderingPaintServerPattern.h:
1315         * kcanvas/device/KRenderingPaintServerSolid.h:
1316         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1317         (WebCore::KCanvasClipperQt::applyClip):
1318         * kcanvas/device/qt/KCanvasClipperQt.h:
1319         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1320         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1321         (WebCore::KRenderingDeviceQt::contextForImage):
1322         (WebCore::KRenderingDeviceQt::createResource):
1323         (WebCore::KRenderingDeviceQt::createPaintServer):
1324         * kcanvas/device/qt/KRenderingDeviceQt.h:
1325         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1326         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1327         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1328         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1329         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1330         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1331         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1332         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1333         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1334         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1335         (WebCore::applyLuminanceToAlphaFilter):
1336         (WebCore::applyExpandAlphatoGrayscaleFilter):
1337         (WebCore::transformImageIntoGrayscaleMask):
1338         (WebCore::KCanvasMaskerQuartz::applyMask):
1339         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1340         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1341         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1342         (WebCore::KCanvasImageQuartz::init):
1343         (WebCore::KCanvasImageQuartz::size):
1344         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1345         (WebCore::KCanvasClipperQuartz::applyClip):
1346         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1347         (WebCore::KCanvasImageQuartz::cgLayer):
1348         (WebCore::KCanvasImageQuartz::setCGLayer):
1349         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1350         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1351         (WebCore::KRenderingDeviceQuartz::contextForImage):
1352         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1353         (WebCore::KRenderingDeviceQuartz::createResource):
1354         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1355         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1356         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1357         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1358         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1359         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1360         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1361         (WebCore::patternCallback):
1362         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1363         * kcanvas/device/quartz/QuartzSupport.mm:
1364         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1365         (WebCore::sharedSolidPaintServer):
1366         * ksvg2/svg/SVGClipPathElement.cpp:
1367         (WebCore::SVGClipPathElement::SVGClipPathElement):
1368         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1369         (WebCore::SVGClipPathElement::canvasResource):
1370         * ksvg2/svg/SVGClipPathElement.h:
1371         * ksvg2/svg/SVGFEImageElement.cpp:
1372         * ksvg2/svg/SVGFilterElement.cpp:
1373         (WebCore::SVGFilterElement::SVGFilterElement):
1374         (WebCore::SVGFilterElement::~SVGFilterElement):
1375         (WebCore::SVGFilterElement::canvasResource):
1376         * ksvg2/svg/SVGFilterElement.h:
1377         * ksvg2/svg/SVGGradientElement.cpp:
1378         (WebCore::SVGGradientElement::SVGGradientElement):
1379         (WebCore::SVGGradientElement::~SVGGradientElement):
1380         (WebCore::SVGGradientElement::canvasResource):
1381         (WebCore::SVGGradientElement::resourceNotification):
1382         * ksvg2/svg/SVGGradientElement.h:
1383         * ksvg2/svg/SVGImageElement.cpp:
1384         * ksvg2/svg/SVGLinearGradientElement.cpp:
1385         (WebCore::SVGLinearGradientElement::buildGradient):
1386         * ksvg2/svg/SVGLinearGradientElement.h:
1387         * ksvg2/svg/SVGMarkerElement.cpp:
1388         (WebCore::SVGMarkerElement::SVGMarkerElement):
1389         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1390         (WebCore::SVGMarkerElement::canvasResource):
1391         * ksvg2/svg/SVGMarkerElement.h:
1392         * ksvg2/svg/SVGMaskElement.cpp:
1393         (WebCore::SVGMaskElement::SVGMaskElement):
1394         (WebCore::SVGMaskElement::~SVGMaskElement):
1395         (WebCore::SVGMaskElement::drawMaskerContent):
1396         (WebCore::SVGMaskElement::canvasResource):
1397         * ksvg2/svg/SVGMaskElement.h:
1398         * ksvg2/svg/SVGPatternElement.cpp:
1399         (WebCore::SVGPatternElement::SVGPatternElement):
1400         (WebCore::SVGPatternElement::~SVGPatternElement):
1401         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1402         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1403         (WebCore::SVGPatternElement::canvasResource):
1404         * ksvg2/svg/SVGPatternElement.h:
1405         * ksvg2/svg/SVGRadialGradientElement.cpp:
1406         (WebCore::SVGRadialGradientElement::buildGradient):
1407         * ksvg2/svg/SVGRadialGradientElement.h:
1408         * ksvg2/svg/SVGStyledElement.h:
1409         (WebCore::SVGStyledElement::canvasResource):
1410         * platform/GraphicsContext.cpp: Added.
1411         (WebCore::GraphicsContextState::GraphicsContextState):
1412         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1413         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1414         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1415         (WebCore::GraphicsContext::save):
1416         (WebCore::GraphicsContext::restore):
1417         (WebCore::GraphicsContext::font):
1418         (WebCore::GraphicsContext::setFont):
1419         (WebCore::GraphicsContext::pen):
1420         (WebCore::GraphicsContext::setPen):
1421         (WebCore::GraphicsContext::setFillColor):
1422         (WebCore::GraphicsContext::fillColor):
1423         (WebCore::GraphicsContext::updatingControlTints):
1424         (WebCore::GraphicsContext::setUpdatingControlTints):
1425         (WebCore::GraphicsContext::setPaintingDisabled):
1426         (WebCore::GraphicsContext::paintingDisabled):
1427         (WebCore::GraphicsContext::drawImage):
1428         (WebCore::GraphicsContext::drawText):
1429         (WebCore::GraphicsContext::drawHighlightForText):
1430         (WebCore::GraphicsContext::initFocusRing):
1431         (WebCore::GraphicsContext::clearFocusRing):
1432         (WebCore::GraphicsContext::focusRingBoundingRect):
1433         (WebCore::GraphicsContext::addFocusRingRect):
1434         (WebCore::GraphicsContext::focusRingWidth):
1435         (WebCore::GraphicsContext::focusRingOffset):
1436         (WebCore::GraphicsContext::focusRingRects):
1437         (WebCore::GraphicsContext::drawTiledImage):
1438         * platform/GraphicsContext.h: Added.
1439         * platform/GraphicsTypes.cpp: Added.
1440         (WebCore::):
1441         (WebCore::parseCompositeOperator):
1442         (WebCore::compositeOperatorName):
1443         (WebCore::parseLineCap):
1444         (WebCore::lineCapName):
1445         (WebCore::parseLineJoin):
1446         (WebCore::lineJoinName):
1447         * platform/GraphicsTypes.h: Added.
1448         (WebCore::):
1449         * platform/graphics/GraphicsContext.cpp:
1450         * platform/graphics/GraphicsContext.h:
1451         * platform/graphics/GraphicsTypes.cpp:
1452         * platform/graphics/GraphicsTypes.h:
1453         * platform/qt/GraphicsContextQt.cpp:
1454         * rendering/RenderPath.cpp:
1455         (WebCore::RenderPath::paint):
1456         (WebCore::DrawMarkersData::DrawMarkersData):
1457         (WebCore::RenderPath::drawMarkersIfNeeded):
1458         * rendering/RenderSVGContainer.cpp:
1459         (WebCore::RenderSVGContainer::paint):
1460         * rendering/RenderSVGImage.cpp:
1461         (WebCore::RenderSVGImage::paint):
1462         * rendering/SVGInlineFlowBox.cpp:
1463         (WebCore::paintSVGInlineFlow):
1464
1465 2006-10-30  John Sullivan  <sullivan@apple.com>
1466
1467         Reviewed by Geoff Garen.
1468         
1469         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1470         grammar-related method.
1471
1472         * bridge/EditorClient.h:
1473         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1474         isGrammarCheckingEnabled()
1475         
1476         * bridge/mac/WebCoreFrameBridge.h:
1477         removed bridge equivalents
1478
1479         * bridge/mac/FrameMac.mm:
1480         (WebCore::FrameMac::advanceToNextMisspelling):
1481         convert bridge-using code to editor()->client()-using code
1482         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1483         ditto
1484         (WebCore::FrameMac::markMisspellings):
1485         ditto
1486         (WebCore::FrameMac::respondToChangedSelection):
1487         ditto
1488         
1489         * editing/Editor.h:
1490         * editing/Editor.cpp:
1491         (WebCore::Editor::client):
1492         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1493         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1494         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1495
1496 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1497
1498         Reviewed by Darin.
1499
1500         Removed a number of editing and selection methods from the bridge.
1501         
1502         I moved cross-platform editing and selection code into Editor and 
1503         SelectionController, respecitvely.
1504
1505         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1506         everything + the kitchen sink.
1507         
1508         Specific comments below for interesting things.
1509         
1510         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1511         a new file so that WebKit can use them, too. Added a helper method for
1512         handling exceptions when selecting a Range.
1513         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1514         WebKit, since they have to do with creating an NSAttributedString for API
1515         consumption, and not much to do with general Frame functionality.
1516         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1517         for now) into the Editor. Eventually, the Frame will not have to notify 
1518         the Editor of what the lastEditCommand was, since the Editor will perform
1519         all EditCommands.
1520         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1521         * editing/SelectionController.cpp:
1522         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1523         and return them. The bridge method to select a DOM range did this implicitly,
1524         since all ObjC DOM operations handle DOM exceptions by throwing them as
1525         ObjC exceptions.
1526         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1527         The two enumerations are numerically identical, but that's an implementation
1528         detail of TextAffinity that clients shouldn't be required to know about.
1529
1530 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1531
1532         Rolling out the following change because this crash:
1533         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1534
1535         And this regression:
1536         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1537
1538     2006-09-06  David Harrison  <harrison@apple.com>
1539
1540         Reviewed and tweaked by Tim H. 
1541
1542         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1543
1544         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1545         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1546         No layout tests affected. Not testable in an automated way that will work on all systems. 
1547
1548         * platform/mac/WebFontCache.mm: 
1549         (+[WebFontCache fontWithFamily:traits:size:]): 
1550
1551 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1552
1553         Reviewed by harrison
1554
1555         <rdar://problem/4808375>
1556         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1557
1558         * editing/TextIterator.cpp:
1559         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1560         when we're going to use them to create a range for an emitted character.
1561         We should further speed TextIterators up by avoiding creating VisiblePositions
1562         for TIs that are only used for the characters they emit (like the one that 
1563         plainText uses).
1564
1565 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1566
1567         Reviewed by Mitz.
1568
1569         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1570         More rendering code cleaning
1571
1572         * WebCore.xcodeproj/project.pbxproj:
1573         * rendering/RenderApplet.cpp:
1574         (WebCore::RenderApplet::RenderApplet):
1575         (WebCore::RenderApplet::createWidgetIfNecessary):
1576         * rendering/RenderApplet.h:
1577         * rendering/RenderArena.cpp:
1578         (WebCore::):
1579         (WebCore::RenderArena::RenderArena):
1580         (WebCore::RenderArena::allocate):
1581         (WebCore::RenderArena::free):
1582         * rendering/RenderArena.h:
1583         * rendering/RenderBR.cpp:
1584         (WebCore::RenderBR::RenderBR):
1585         (WebCore::RenderBR::baselinePosition):
1586         (WebCore::RenderBR::lineHeight):
1587         (WebCore::RenderBR::setStyle):
1588         (WebCore::RenderBR::caretMinOffset):
1589         (WebCore::RenderBR::positionForCoordinates):
1590         (WebCore::RenderBR::inlineBox):
1591         * rendering/RenderBR.h:
1592         * rendering/RenderBlock.cpp:
1593         * rendering/RenderBlock.h:
1594         (WebCore::RenderBlock::maxTopMargin):
1595         (WebCore::RenderBlock::maxBottomMargin):
1596         (WebCore::RenderBlock::initMaxMarginValues):
1597         (WebCore::RenderBlock::containsFloats):
1598         (WebCore::RenderBlock::setHasMarkupTruncation):
1599         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1600         (WebCore::RenderBlock::BlockSelectionInfo::block):
1601         (WebCore::RenderBlock::BlockSelectionInfo::state):
1602         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1603         (WebCore::RenderBlock::CompactInfo::clear):
1604         * rendering/RenderButton.cpp:
1605         (WebCore::RenderButton::removeChild):
1606         (WebCore::RenderButton::paintObject):
1607         * rendering/RenderButton.h:
1608         (WebCore::RenderButton::renderName):
1609         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1610         * rendering/RenderContainer.cpp:
1611         (WebCore::RenderContainer::RenderContainer):
1612         * rendering/RenderContainer.h:
1613         (WebCore::RenderContainer::firstChild):
1614         (WebCore::RenderContainer::lastChild):
1615         (WebCore::RenderContainer::calcMinMaxWidth):
1616         * rendering/RenderCounter.cpp:
1617         (WebCore::RenderCounter::RenderCounter):
1618         (WebCore::toRoman):
1619         (WebCore::toHebrew):
1620         (WebCore::RenderCounter::calcMinMaxWidth):
1621         * rendering/RenderCounter.h:
1622         * rendering/RenderFieldset.cpp:
1623         (WebCore::RenderFieldset::paintBoxDecorations):
1624         (WebCore::RenderFieldset::paintBorderMinusLegend):
1625         (WebCore::RenderFieldset::setStyle):
1626         * rendering/RenderFileUploadControl.cpp:
1627         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1628         (WebCore::RenderFileUploadControl::setStyle):
1629         (WebCore::RenderFileUploadControl::paintObject):
1630         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1631         * rendering/RenderFileUploadControl.h:
1632         (WebCore::RenderFileUploadControl::renderName):
1633         * rendering/RenderFlexibleBox.h:
1634         * rendering/RenderFlow.cpp:
1635         * rendering/RenderFlow.h:
1636         * rendering/RenderForeignObject.cpp:
1637         (WebCore::RenderForeignObject::RenderForeignObject):
1638         (WebCore::RenderForeignObject::paint):
1639         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1640         (WebCore::RenderForeignObject::layout):
1641         (WebCore::RenderForeignObject::nodeAtPoint):
1642         * rendering/RenderForeignObject.h:
1643         (WebCore::RenderForeignObject::renderName):
1644         * rendering/RenderFormElement.cpp:
1645         (WebCore::RenderFormElement::setStyle):
1646         (WebCore::RenderFormElement::layout):
1647         (WebCore::RenderFormElement::textAlignment):
1648         * rendering/RenderFormElement.h:
1649         * rendering/RenderFrame.cpp:
1650         * rendering/RenderFrame.h:
1651         (WebCore::RenderFrame::element):
1652         * rendering/RenderFrameSet.cpp:
1653         * rendering/RenderFrameSet.h:
1654         (WebCore::RenderFrameSet::element):
1655         * rendering/RenderHTMLCanvas.cpp:
1656         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1657         (WebCore::RenderHTMLCanvas::paint):
1658         * rendering/RenderHTMLCanvas.h:
1659         (WebCore::RenderHTMLCanvas::renderName):
1660         * rendering/RenderImage.cpp:
1661         (WebCore::RenderImage::RenderImage):
1662         (WebCore::RenderImage::setStyle):
1663         (WebCore::RenderImage::setContentObject):
1664         (WebCore::RenderImage::setCachedImage):
1665         (WebCore::RenderImage::imageChanged):
1666         (WebCore::RenderImage::paint):
1667         (WebCore::RenderImage::layout):
1668         (WebCore::RenderImage::updateAltText):
1669         * rendering/RenderImage.h:
1670         (WebCore::RenderImage::element):
1671         * rendering/RenderInline.cpp:
1672         (WebCore::RenderInline::RenderInline):
1673         (WebCore::RenderInline::~RenderInline):
1674         (WebCore::RenderInline::setStyle):
1675         (WebCore::RenderInline::addChildToFlow):
1676         (WebCore::RenderInline::cloneInline):
1677         (WebCore::RenderInline::splitInlines):
1678         (WebCore::RenderInline::splitFlow):
1679         (WebCore::RenderInline::paint):
1680         (WebCore::RenderInline::absoluteRects):
1681         (WebCore::RenderInline::calcMinMaxWidth):
1682         (WebCore::RenderInline::requiresLayer):
1683         (WebCore::RenderInline::width):
1684         (WebCore::RenderInline::height):
1685         (WebCore::RenderInline::renderName):
1686         (WebCore::RenderInline::nodeAtPoint):
1687         (WebCore::RenderInline::positionForCoordinates):
1688         * rendering/RenderInline.h:
1689         (WebCore::RenderInline::layout):
1690         * rendering/RenderLayer.cpp:
1691         * rendering/RenderLayer.h:
1692         (WebCore::ClipRects::ClipRects):
1693         (WebCore::RenderLayer::nextSibling):
1694         (WebCore::RenderLayer::root):
1695         (WebCore::RenderLayer::setPos):
1696         (WebCore::RenderLayer::height):
1697         (WebCore::RenderLayer::relativePositionOffset):
1698         * rendering/RenderLineEdit.cpp:
1699         (WebCore::RenderLineEdit::setStyle):
1700         (WebCore::RenderLineEdit::updateFromElement):
1701         (WebCore::RenderLineEdit::selectionStart):
1702         (WebCore::RenderLineEdit::selectionEnd):
1703         (WebCore::RenderLineEdit::setSelectionStart):
1704         (WebCore::RenderLineEdit::setSelectionEnd):
1705         (WebCore::RenderLineEdit::setSelectionRange):
1706         * rendering/RenderLineEdit.h:
1707         * rendering/RenderListBox.cpp:
1708         * rendering/RenderListBox.h:
1709         (WebCore::RenderListBox::renderName):
1710         * rendering/RenderListItem.cpp:
1711         (WebCore::RenderListItem::setStyle):
1712         (WebCore::getParentOfFirstLineBox):
1713         (WebCore::RenderListItem::updateMarkerLocation):
1714         (WebCore::RenderListItem::positionListMarker):
1715         (WebCore::RenderListItem::paint):
1716         * rendering/RenderListItem.h:
1717         * rendering/RenderListMarker.cpp:
1718         * rendering/RenderListMarker.h:
1719         (WebCore::RenderListMarker::renderName):
1720         (WebCore::RenderListMarker::isListMarker):
1721
1722 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1723
1724         Reviewed by Hyatt.
1725
1726         <rdar://problem/4478625> Basic table editing and culling
1727
1728         Refined the criteria for deletable elements, rely on the renderer more.
1729         Corrected the interface positioning for elements that have borders.
1730
1731         * editing/DeleteButtonController.cpp:
1732         (WebCore::isDeletableElement):
1733         (WebCore::DeleteButtonController::show):
1734
1735 2006-10-30  Darin Adler  <darin@apple.com>
1736
1737         - fix build
1738
1739         * loader/ResourceLoader.h: Added header guard.
1740
1741 2006-10-31  Darin Adler  <darin@apple.com>
1742
1743         Reviewed by Adam.
1744
1745         - fix FrameLoader files so they can be built on non-Mac platforms
1746
1747         * page/FramePrivate.h:
1748         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1749         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1750
1751         * page/Page.h:
1752         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1753         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1754         the other day.
1755
1756         * bridge/mac/FrameMac.mm:
1757         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1758         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1759
1760         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1761         around the PolicyCheck definition.
1762
1763         * loader/FormState.cpp: Changed import to include.
1764         * loader/FrameLoader.cpp: Ditto.
1765         * loader/MainResourceLoader.h: Ditto.
1766
1767         * loader/FrameLoaderTypes.h: Added a header guard.
1768
1769         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1770         Added #if PLATFORM(MAC) around Mac-specific details.
1771         * loader/SubresourceLoader.h: Ditto.
1772
1773         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1774         m_loader from m_frameLoader.
1775
1776         * CMakeLists.txt: Updated.
1777         * WebCoreSources.bkl: Updated.
1778
1779 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1780
1781         Reviewed and landed by Anders.
1782
1783         Patch by Zack rusin to fix: 
1784         http://bugs.webkit.org/show_bug.cgi?id=11429
1785
1786         Fix startup crash.
1787
1788         * platform/qt/FrameQtClient.cpp:
1789         (WebCore::FrameQtClientDefault::openURL):
1790
1791 2006-10-30  Zach Rusin  <zack@kde.org>
1792
1793         Reviewed and landed by Anders.
1794
1795         * platform/network/qt/ResourceHandleQt.cpp:
1796         (WebCore::ResourceHandle::receivedResponse):
1797         * platform/qt/FrameQtClient.cpp:
1798         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1799         * platform/qt/LoaderFunctionsQt.cpp:
1800         (WebCore::ServeSynchronousRequest):
1801         More build fixes.
1802
1803 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1804
1805         Reviewed and landed by Anders.
1806         
1807         - fix Qt build
1808         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1809         ResourceHandleClient
1810
1811 2006-10-30  Darin Adler  <darin@apple.com>
1812
1813         Reviewed by John Sullivan.
1814
1815         - work toward removing Objective-C data types from FrameLoader.h:
1816           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1817           and WebCoreResourceHandle
1818         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1819
1820         * page/PageState.h:
1821         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1822
1823         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1824         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1825         double for the date instead of an NSDate.
1826
1827         * bridge/mac/WebCoreFrameBridge.h:
1828         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1829         saveDocumentToPageCache methods.
1830
1831         * bridge/mac/WebCorePageState.h:
1832         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1833         an Objective-C wrapper for PageState.
1834
1835         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1836         NSDate and WebCorePageState.
1837         * loader/FrameLoaderClient.h: Changed NSDate to double.
1838         * loader/mac/FrameLoaderMac.mm:
1839         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1840         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1841         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1842         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1843         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1844         extract the parameters from the response. Changed the open function that takes
1845         a PageState to use the new C++ PageState.
1846         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1847         function; tightened up logic, removing a few cases that could never happen, as
1848         well as the unused reload boolean.
1849
1850         * ForwardingHeaders/kjs/property_map.h: Added.
1851
1852         * WebCore.exp: Updated.
1853         * WebCore.xcodeproj/project.pbxproj: Updated.
1854
1855 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1856
1857         Reviewed by Anders.
1858
1859         - added ResourceResponse class and didReceiveResponse delegate call
1860         
1861         * WebCore.xcodeproj/project.pbxproj: Added new files.
1862         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1863         expiresTimeForResponse: method.
1864         * dom/XMLTokenizer.cpp:
1865         (WebCore::openFunc): Updated to use ResourceResponse.
1866         * loader/FrameLoader.h: Update loadResourceSynchronously to
1867         use ResourceResponse.
1868         * loader/LoaderFunctions.h:
1869         * loader/icon/IconLoader.cpp:
1870         (IconLoader::didReceiveResponse): Updated from receivedResponse
1871         and made cross-platform.
1872         * loader/icon/IconLoader.h: updated for above change
1873         * loader/loader.cpp:
1874         (WebCore::Loader::receivedResponse): reduced to just saving
1875         the PlatformResponse (ideally we'd phase out use of this).
1876         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1877         logic.
1878         * loader/loader.h:
1879         * loader/mac/FrameLoaderMac.mm:
1880         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1881         as ResourceResponse.
1882         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1883         * loader/mac/LoaderFunctionsMac.mm:
1884         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1885         argument.
1886         * platform/network/ResourceHandle.cpp:
1887         * platform/network/ResourceHandle.h: Remove calls for
1888         broken out response pieces.
1889         * platform/network/ResourceHandleClient.h:
1890         (WebCore::ResourceHandleClient::didReceiveResponse): New
1891         delegate method.
1892         * platform/network/ResourceHandleInternal.h:
1893         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1894         storage of response bits, we're not gonna return them
1895         seprately any more.
1896         * platform/network/ResourceResponse.h: Added.
1897         (WebCore::ResourceResponse::ResourceResponse): Freshly
1898         implemented. Same for below.
1899         (WebCore::ResourceResponse::url):
1900         (WebCore::ResourceResponse::mimeType):
1901         (WebCore::ResourceResponse::expectedContentLength):
1902         (WebCore::ResourceResponse::textEncodingName):
1903         (WebCore::ResourceResponse::suggestedFilename):
1904         (WebCore::ResourceResponse::httpStatusCode):
1905         (WebCore::ResourceResponse::setHTTPStatusCode):
1906         (WebCore::ResourceResponse::httpHeaderField):
1907         (WebCore::ResourceResponse::httpHeaderFields):
1908         (WebCore::ResourceResponse::isMultipart):
1909         (WebCore::ResourceResponse::setExpirationDate):
1910         (WebCore::ResourceResponse::expirationDate):
1911         * platform/network/cf/ResourceHandleCFNet.cpp:
1912         (WebCore::didReceiveResponse): Send didReceiveResponse
1913         client method.
1914         * platform/network/cf/ResourceResponseCFNet.h: Added.
1915         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1916         (getResourceResponse): Helper function to get a ResourceResponse 
1917         from CFURLResponseRef.
1918         * platform/network/mac/ResourceHandleMac.mm:
1919         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1920         Don't bother cleaning up fields we no longer have.
1921         (WebCore::ResourceHandle::receivedResponse): Send
1922         didReceiveResponse client method.
1923         * platform/network/mac/ResourceResponseMac.h: Added.
1924         * platform/network/mac/ResourceResponseMac.mm: Added.
1925         (getResourceResponse): Helper function to get a ResourceResponse 
1926         from an NSURLResponse*.
1927         * rendering/HitTestResult.cpp:
1928         * xml/XSLTProcessor.cpp:
1929         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1930         * xml/xmlhttprequest.cpp:
1931         (WebCore::XMLHttpRequest::getResponseText): Store http response
1932         info in the form of a ResourceResponse, change all methods to
1933         account for this.
1934         (WebCore::XMLHttpRequest::getResponseXML):
1935         (WebCore::XMLHttpRequest::XMLHttpRequest):
1936         (WebCore::XMLHttpRequest::open):
1937         (WebCore::XMLHttpRequest::send):
1938         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1939         (WebCore::XMLHttpRequest::getResponseHeader):
1940         (WebCore::XMLHttpRequest::getStatus):
1941         (WebCore::XMLHttpRequest::getStatusText):
1942         (WebCore::XMLHttpRequest::processSyncLoadResults):
1943         (WebCore::XMLHttpRequest::didFinishLoading):
1944         (WebCore::XMLHttpRequest::didReceiveResponse):
1945         (WebCore::XMLHttpRequest::didReceiveData):
1946         * xml/xmlhttprequest.h:
1947
1948 2006-10-29  Darin Adler  <darin@apple.com>
1949
1950         - fix build
1951
1952         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1953         * loader/NetscapePlugInStreamLoader.h: Ditto.
1954         * loader/ResourceLoader.h: Ditto.
1955
1956 2006-10-29  Darin Adler  <darin@apple.com>
1957
1958         - one last name change -- WebFormState.h to FormState.h
1959         - added more empty placeholder platform-independent files
1960           for currently-Mac-specific loader classes
1961
1962         * loader/FormState.cpp: Updated include.
1963         * loader/FrameLoader.cpp: Updated include.
1964         * loader/mac/FrameLoaderMac.mm: Updated include.
1965
1966         * loader/WebFormState.h: Removed.
1967         * loader/FormState.h: Added.
1968
1969         * loader/DocumentLoader.cpp: Added.
1970         * loader/MainResourceLoader.cpp: Added.
1971         * loader/NetscapePlugInStreamLoader.cpp: Added.
1972         * loader/ResourceLoader.cpp: Added.
1973         * loader/SubresourceLoader.cpp: Added.
1974
1975         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1976
1977 2006-10-29  Darin Adler  <darin@apple.com>
1978
1979         - did the do-webcore-rename renames, including a number of changes
1980           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1981           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1982           and improvements to the names of decoder classes and their source
1983           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1984
1985         * CMakeLists.txt:
1986         * WebCore.exp:
1987         * WebCore.vcproj/WebCore/WebCore.vcproj:
1988         * WebCore.xcodeproj/project.pbxproj:
1989         * WebCoreSources.bkl:
1990         * bindings/js/kjs_binding.cpp:
1991         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1992         * bindings/js/kjs_events.cpp:
1993         (KJS::JSAbstractEventListener::handleEvent):
1994         (KJS::JSLazyEventListener::parseCode):
1995         * bindings/js/kjs_html.cpp:
1996         (KJS::JSHTMLElement::implementsCall):
1997         * bindings/js/kjs_traversal.cpp:
1998         (KJS::JSNodeFilterCondition::acceptNode):
1999         * bindings/js/kjs_window.cpp:
2000         (KJS::Window::interpreter):
2001         (KJS::Window::retrieveWindow):
2002         (KJS::Window::retrieve):
2003         (KJS::ScheduledAction::execute):
2004         * bindings/objc/DOMInternal.mm:
2005         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2006         * bridge/mac/FrameMac.mm:
2007         (WebCore::FrameMac::executionContextForDOM):
2008         (WebCore::FrameMac::bindingRootObject):
2009         (WebCore::FrameMac::windowScriptObject):
2010         (WebCore::FrameMac::windowScriptNPObject):
2011         (WebCore::FrameMac::partClearedInBegin):
2012         * bridge/mac/WebCoreEncodings.mm:
2013         * bridge/mac/WebCoreFrameBridge.mm:
2014         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2015         (-[WebCoreFrameBridge stringWithData:]):
2016         (-[WebCoreFrameBridge executionContextForView:]):
2017         * bridge/win/FrameWin.cpp:
2018         * dom/Document.cpp:
2019         (WebCore::Document::inputEncoding):
2020         (WebCore::Document::setCharset):
2021         (WebCore::Document::createHTMLEventListener):
2022         (WebCore::Document::setDecoder):
2023         * dom/Document.h:
2024         (WebCore::Document::decoder):
2025         * dom/EventTargetNode.cpp:
2026         (WebCore::EventTargetNode::dispatchGenericEvent):
2027         * html/HTMLParser.cpp:
2028         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2029         (WebCore::HTMLParser::canvasCreateErrorCheck):
2030         (WebCore::HTMLParser::isInline):
2031         * html/HTMLPlugInElement.cpp:
2032         (WebCore::HTMLPlugInElement::createNPObject):
2033         * html/HTMLScriptElement.cpp:
2034         (WebCore::HTMLScriptElement::evaluateScript):
2035         * html/HTMLTokenizer.cpp:
2036         (WebCore::HTMLTokenizer::parseTag):
2037         (WebCore::HTMLTokenizer::processToken):
2038         * ksvg2/misc/SVGDocumentExtensions.cpp:
2039         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2040         * loader/CachedCSSStyleSheet.cpp:
2041         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2042         (WebCore::CachedCSSStyleSheet::setEncoding):
2043         * loader/CachedCSSStyleSheet.h:
2044         * loader/CachedXBLDocument.cpp:
2045         (WebCore::CachedXBLDocument::CachedXBLDocument):
2046         (WebCore::CachedXBLDocument::setEncoding):
2047         * loader/CachedXBLDocument.h:
2048         * loader/CachedXSLStyleSheet.cpp:
2049         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2050         (WebCore::CachedXSLStyleSheet::setEncoding):
2051         * loader/CachedXSLStyleSheet.h:
2052         * loader/Decoder.cpp: Removed.
2053         * loader/Decoder.h: Removed.
2054         * loader/FrameLoader.cpp:
2055         * loader/FrameLoader.h:
2056         * loader/FrameLoaderClient.h:
2057         * loader/MainResourceLoader.h: Added.
2058         * loader/NetscapePlugInStreamLoader.h: Added.
2059         * loader/Request.h:
2060         (WebCore::Request::cachedResource):
2061         * loader/ResourceLoader.h: Added.
2062         * loader/SubresourceLoader.h: Added.
2063         * loader/TextResourceDecoder.cpp: Added.
2064         (WebCore::TextResourceDecoder::determineContentType):
2065         (WebCore::TextResourceDecoder::defaultEncoding):
2066         (WebCore::TextResourceDecoder::TextResourceDecoder):
2067         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2068         (WebCore::TextResourceDecoder::setEncoding):
2069         (WebCore::TextResourceDecoder::checkForBOM):
2070         (WebCore::TextResourceDecoder::checkForCSSCharset):
2071         (WebCore::TextResourceDecoder::checkForHeadCharset):
2072         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2073         (WebCore::TextResourceDecoder::decode):
2074         (WebCore::TextResourceDecoder::flush):
2075         * loader/TextResourceDecoder.h: Added.
2076         * loader/WebDocumentLoader.h: Removed.
2077         * loader/WebLoader.h: Removed.
2078         * loader/WebMainResourceLoader.h: Removed.
2079         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2080         * loader/WebSubresourceLoader.h: Removed.
2081         * loader/loader.cpp:
2082         (WebCore::Loader::servePendingRequests):
2083         (WebCore::Loader::receivedAllData):
2084         (WebCore::Loader::receivedResponse):
2085         (WebCore::Loader::didReceiveData):
2086         (WebCore::Loader::cancelRequests):
2087         (WebCore::Loader::jobForRequest):
2088         * loader/mac/DocumentLoaderMac.mm:
2089         * loader/mac/FormDataStream.m: Added.
2090         * loader/mac/FrameLoaderMac.mm:
2091         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2092         (WebCore::FrameLoader::addPlugInStreamLoader):
2093         (WebCore::FrameLoader::removePlugInStreamLoader):
2094         (WebCore::FrameLoader::addSubresourceLoader):
2095         (WebCore::FrameLoader::removeSubresourceLoader):
2096         (WebCore::FrameLoader::willSendRequest):
2097         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2098         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2099         (WebCore::FrameLoader::didReceiveResponse):
2100         (WebCore::FrameLoader::didReceiveData):
2101         (WebCore::FrameLoader::didFinishLoad):
2102         (WebCore::FrameLoader::didFailToLoad):
2103         (WebCore::FrameLoader::open):
2104         (WebCore::FrameLoader::willUseArchive):
2105         (WebCore::FrameLoader::isArchiveLoadPending):
2106         * loader/mac/ImageDocumentMac.mm:
2107         * loader/mac/LoaderFunctionsMac.mm:
2108         (WebCore::CheckCacheObjectStatus):
2109         * loader/mac/MainResourceLoaderMac.mm:
2110         (WebCore::MainResourceLoader::MainResourceLoader):
2111         (WebCore::MainResourceLoader::releaseDelegate):
2112         (WebCore::MainResourceLoader::didCancel):
2113         (WebCore::MainResourceLoader::addData):
2114         (WebCore::MainResourceLoader::willSendRequest):
2115         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2116         (WebCore::MainResourceLoader::didReceiveData):
2117         (WebCore::MainResourceLoader::didFinishLoading):
2118         (WebCore::MainResourceLoader::setDefersLoading):
2119         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2120         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2121         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2122         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2123         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2124         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2125         (WebCore::NetscapePlugInStreamLoader::didFail):
2126         (WebCore::NetscapePlugInStreamLoader::didCancel):
2127         * loader/mac/ResourceLoaderMac.mm:
2128         (WebCore::ResourceLoader::ResourceLoader):
2129         (WebCore::ResourceLoader::~ResourceLoader):
2130         (WebCore::ResourceLoader::releaseResources):
2131         (WebCore::ResourceLoader::load):
2132         (WebCore::ResourceLoader::setDefersLoading):
2133         (WebCore::ResourceLoader::frameLoader):
2134         (WebCore::ResourceLoader::addData):
2135         (WebCore::ResourceLoader::resourceData):
2136         (WebCore::ResourceLoader::clearResourceData):
2137         (WebCore::ResourceLoader::willSendRequest):
2138         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2139         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2140         (WebCore::ResourceLoader::didReceiveResponse):
2141         (WebCore::ResourceLoader::didReceiveData):
2142         (WebCore::ResourceLoader::willStopBufferingData):
2143         (WebCore::ResourceLoader::didFinishLoading):
2144         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2145         (WebCore::ResourceLoader::didFail):
2146         (WebCore::ResourceLoader::willCacheResponse):
2147         (WebCore::ResourceLoader::didCancel):
2148         (WebCore::ResourceLoader::cancel):
2149         (WebCore::ResourceLoader::setIdentifier):
2150         (WebCore::ResourceLoader::response):
2151         (WebCore::ResourceLoader::inConnectionCallback):
2152         (WebCore::ResourceLoader::cancelledError):
2153         (WebCore::ResourceLoader::receivedCredential):
2154         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2155         (WebCore::ResourceLoader::receivedCancellation):
2156         (WebCore::ResourceLoader::delegate):
2157         (WebCore::ResourceLoader::releaseDelegate):
2158         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2159         * loader/mac/SubresourceLoaderMac.mm:
2160         (WebCore::SubresourceLoader::SubresourceLoader):
2161         (WebCore::SubresourceLoader::willSendRequest):
2162         (WebCore::SubresourceLoader::didReceiveResponse):
2163         (WebCore::SubresourceLoader::didReceiveData):
2164         (WebCore::SubresourceLoader::didFinishLoading):
2165         (WebCore::SubresourceLoader::didFail):
2166         (WebCore::SubresourceLoader::didCancel):
2167         * loader/mac/WebFormDataStream.h: Removed.
2168         * loader/mac/WebFormDataStream.m: Removed.
2169         * page/Frame.cpp:
2170         (WebCore::Frame::javaScriptEnabled):
2171         (WebCore::Frame::scriptProxy):
2172         (WebCore::Frame::executeScript):
2173         (WebCore::Frame::write):
2174         (WebCore::Frame::userGestureHint):
2175         (WebCore::Frame::saveInterpreterBuiltins):
2176         (WebCore::Frame::restoreInterpreterBuiltins):
2177         (WebCore::Frame::backslashAsCurrencySymbol):
2178         * page/Frame.h:
2179         * page/FramePrivate.h:
2180         * platform/StreamingTextDecoder.cpp: Removed.
2181         * platform/StreamingTextDecoder.h: Removed.
2182         * platform/StreamingTextDecoderICU.cpp: Removed.
2183         * platform/StreamingTextDecoderICU.h: Removed.
2184         * platform/TextCodec.cpp: Added.
2185         * platform/TextCodec.h: Added.
2186         * platform/TextCodecICU.cpp: Added.
2187         * platform/TextCodecICU.h: Added.
2188         * platform/TextCodecLatin1.h:
2189         * platform/TextCodecUTF16.h:
2190         * platform/TextDecoder.h:
2191         * platform/TextEncoding.cpp:
2192         * platform/TextEncodingRegistry.cpp:
2193         * platform/image-decoders/jpeg/jmorecfg.h:
2194         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2195         * platform/mac/StreamingTextDecoderMac.h: Removed.
2196         * platform/mac/TextCodecMac.cpp: Added.
2197         * platform/mac/TextCodecMac.h: Added.
2198         * platform/network/ResourceHandleInternal.h:
2199         * platform/network/mac/ResourceHandleMac.mm:
2200         * platform/qt/FrameQt.cpp:
2201         (WebCore::FrameQt::bindingRootObject):
2202         * platform/qt/LoaderFunctionsQt.cpp:
2203         (WebCore::CheckCacheObjectStatus):
2204         * rendering/RenderObject.cpp:
2205         (WebCore::RenderObject::backslashAsCurrencySymbol):
2206         * xml/XSLTProcessor.cpp:
2207         (WebCore::XSLTProcessor::createDocumentFromSource):
2208         * xml/xmlhttprequest.cpp:
2209         (WebCore::XMLHttpRequest::didReceiveData):
2210         * xml/xmlhttprequest.h:
2211
2212 2006-10-29  Darin Adler  <darin@apple.com>
2213
2214         Rubber stamped by Adam (kinda).
2215
2216         - add Mac suffixes and correct filenames inside loader/mac
2217
2218         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2219
2220         * loader/mac/FrameLoader.mm: Removed.
2221         * loader/mac/WebDocumentLoader.mm: Removed.
2222         * loader/mac/WebLoader.mm: Removed.
2223         * loader/mac/WebMainResourceLoader.mm: Removed.
2224         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2225         * loader/mac/WebSubresourceLoader.mm: Removed.
2226
2227         * loader/mac/FrameLoaderMac.mm: Added.
2228         * loader/mac/DocumentLoaderMac.mm: Added.
2229         * loader/mac/ResourceLoaderMac.mm: Added.
2230         * loader/mac/MainResourceLoaderMac.mm: Added.
2231         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2232         * loader/mac/SubresourceLoaderMac.mm: Removed.
2233
2234 2006-10-29  Darin Adler  <darin@apple.com>
2235
2236         Reviewed by Adam.
2237
2238         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2239           and FrameLoader.cpp mostly ready
2240
2241         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2242         FormState.cpp. Removed WebFormState.mm.
2243
2244         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2245         get this header compiling on non-Mac.
2246         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2247         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2248
2249         * loader/FrameLoaderClient.h: Added some ifdefs.
2250         * loader/WebDocumentLoader.h: Ditto.
2251         * loader/WebLoader.h: Ditto.
2252         * loader/WebMainResourceLoader.h: Ditto.
2253
2254         * loader/mac/WebDocumentLoader.mm:
2255         (WebCore::DocumentLoader::isLoadingInAPISense):
2256         Rewrote to work without bridge, partly to remove the need for ObjC
2257         bridge type in the header, and also because we're tearing down the bridge.
2258
2259         * loader/mac/WebMainResourceLoader.mm:
2260         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2261         m_contentLength and m_bytesReceived.
2262         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2263         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2264
2265         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2266         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2267
2268         * loader/mac/FormState.mm: Removed.
2269         * loader/FormState.cpp: Added.
2270
2271 2006-10-29  Darin Adler  <darin@apple.com>
2272
2273         Rubber stamped by Adam.
2274
2275         - moving towards use of FrameLoader cross-platform; move the headers
2276           for the Mac loader from loader/mac into loader, in preparation for
2277           making them useful on non-Mac
2278
2279         * WebCore.xcodeproj/project.pbxproj:
2280
2281         * loader/mac/FrameLoader.h: Removed.
2282         * loader/mac/WebDocumentLoader.h: Removed.
2283         * loader/mac/WebFormState.h: Removed.
2284         * loader/mac/WebLoader.h: Removed.
2285         * loader/mac/WebMainResourceLoader.h: Removed.
2286         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2287         * loader/mac/WebSubresourceLoader.h: Removed.
2288
2289         * loader/FrameLoader.h: Added.
2290         * loader/WebDocumentLoader.h: Added.
2291         * loader/WebFormState.h: Added.
2292         * loader/WebLoader.h: Added.
2293         * loader/WebMainResourceLoader.h: Added.
2294         * loader/WebNetscapePlugInStreamLoader.h: Added.
2295         * loader/WebSubresourceLoader.h: Added.
2296
2297 2006-10-29  Adam Roben  <aroben@apple.com>
2298
2299         Reviewed by Geoff.
2300
2301         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2302         r17405.
2303
2304         * platform/DeprecatedString.h:
2305
2306 2006-10-29  Beth Dakin  <bdakin@apple.com>
2307
2308         Rubber stamped by Geoff.
2309
2310         This is a followup to my HitTestResult checkin. Most of the 
2311         HitTestResult local variables in the code were named i or info for 
2312         when the class was named NodeInfo. This patch renames all of these 
2313         local variables to result.
2314
2315         * dom/Document.cpp:
2316         (WebCore::Document::prepareMouseEvent):
2317         * html/HTMLAreaElement.cpp:
2318         (WebCore::HTMLAreaElement::mapMouseEvent):
2319         * html/HTMLMapElement.cpp:
2320         (WebCore::HTMLMapElement::mapMouseEvent):
2321         * rendering/EllipsisBox.cpp:
2322         (WebCore::EllipsisBox::nodeAtPoint):
2323         * rendering/EllipsisBox.h:
2324         * rendering/InlineBox.cpp:
2325         (WebCore::InlineBox::nodeAtPoint):
2326         * rendering/InlineFlowBox.cpp:
2327         (WebCore::InlineFlowBox::nodeAtPoint):
2328         * rendering/InlineTextBox.cpp:
2329         (WebCore::InlineTextBox::nodeAtPoint):
2330         * rendering/RenderBlock.cpp:
2331         (WebCore::RenderBlock::isPointInScrollbar):
2332         (WebCore::RenderBlock::nodeAtPoint):
2333         * rendering/RenderBlock.h:
2334         * rendering/RenderBox.cpp:
2335         (WebCore::RenderBox::nodeAtPoint):
2336         * rendering/RenderBox.h:
2337         * rendering/RenderFlow.cpp:
2338         (WebCore::RenderFlow::hitTestLines):
2339         * rendering/RenderFlow.h:
2340         * rendering/RenderForeignObject.cpp:
2341         (WebCore::RenderForeignObject::nodeAtPoint):
2342         * rendering/RenderFrameSet.cpp:
2343         (WebCore::RenderFrameSet::nodeAtPoint):
2344         * rendering/RenderImage.cpp:
2345         (WebCore::RenderImage::nodeAtPoint):
2346         * rendering/RenderInline.cpp:
2347         (WebCore::RenderInline::nodeAtPoint):
2348         * rendering/RenderInline.h:
2349         * rendering/RenderLayer.cpp:
2350         (WebCore::RenderLayer::autoscroll):
2351         (WebCore::RenderLayer::hitTest):
2352         (WebCore::RenderLayer::hitTestLayer):
2353         (WebCore::RenderLayer::updateHoverActiveState):
2354         * rendering/RenderListBox.cpp:
2355         (WebCore::RenderListBox::isPointInScrollbar):
2356         * rendering/RenderObject.cpp:
2357         (WebCore::RenderObject::hitTest):
2358         (WebCore::RenderObject::setInnerNode):
2359         (WebCore::RenderObject::nodeAtPoint):
2360         * rendering/RenderObject.h:
2361         * rendering/RenderPath.cpp:
2362         (WebCore::RenderPath::nodeAtPoint):
2363         * rendering/RenderSVGImage.cpp:
2364         (WebCore::RenderSVGImage::nodeAtPoint):
2365         * rendering/RenderSVGText.cpp:
2366         (WebCore::RenderSVGText::nodeAtPoint):
2367         * rendering/RenderTableRow.cpp:
2368         (WebCore::RenderTableRow::nodeAtPoint):
2369         * rendering/RenderTableRow.h:
2370         * rendering/RenderTableSection.cpp:
2371         (WebCore::RenderTableSection::nodeAtPoint):
2372         * rendering/RenderTableSection.h:
2373         * rendering/RenderTextControl.cpp:
2374         (WebCore::RenderTextControl::nodeAtPoint):
2375         * rendering/RootInlineBox.cpp:
2376         (WebCore::RootInlineBox::nodeAtPoint):
2377         * rendering/RootInlineBox.h:
2378
2379 2006-10-29  Adam Roben  <aroben@apple.com>
2380
2381         More semi-fixes.
2382
2383         * page/Page.cpp: Forgot to wrap the actual definition of
2384         setDefersLoading() in PLATFORM(MAC).
2385         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2386
2387 2006-10-29  Adam Roben  <aroben@apple.com>
2388
2389         Build semi-fix.
2390
2391         Move all FrameLoader-related code in Page.{cpp,h} within #if
2392         PLATFORM(MAC), since this class currently only exists on Mac.
2393
2394         * page/Page.cpp:
2395         * page/Page.h:
2396
2397 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2398
2399         build fix.
2400         
2401         * platform/PlatformString.h:
2402         (WebCore::String::operator NSString*):
2403
2404 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2405
2406         Rolled out accidental commit.
2407         
2408         * platform/AtomicString.h:
2409         (WebCore::AtomicString::AtomicString):
2410         (WebCore::AtomicString::operator NSString*):
2411
2412 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2413
2414         RS by Darin.
2415
2416         Rolled out change to map NULL Strings to nil NSStrings because it caused
2417         even more AppKit crashes. Maybe we should remove the NSString * operator
2418         entirely, since its use is not straight-forward, and require callers to
2419         specify explicitly whether they tolerate NULL.
2420         
2421         * platform/AtomicString.h:
2422         * platform/PlatformString.h:
2423         (WebCore::String::operator NSString*):
2424         * platform/mac/TextFieldMac.mm:
2425         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2426
2427 2006-10-29  Darin Adler  <darin@apple.com>
2428
2429         Reviewed by Geoff.
2430
2431         - fixed storage leak showing up on the buildbot
2432
2433         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2434         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2435
2436 2006-10-29  Darin Adler  <darin@apple.com>
2437
2438         Rubber stamped by Adam.
2439
2440         - renamed WebFrameLoaderClient to match the class name inside it
2441
2442         * loader/mac/WebFrameLoaderClient.h: Removed.
2443         * loader/FrameLoaderClient.h: Moved it here.
2444
2445         * WebCore.xcodeproj/project.pbxproj: Updated project.
2446
2447         * bridge/mac/FrameMac.mm: Updated includes.
2448         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2449         * loader/mac/FrameLoader.mm: Ditto.
2450         * loader/mac/WebLoader.h: Ditto.
2451
2452 2006-10-29  Darin Adler  <darin@apple.com>
2453
2454         Reviewed by Mitz.
2455
2456         - fix crash visible on buildbot and also when running the test
2457           anchor-image-scrolled-x-y.html under libgmalloc
2458
2459         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2460         now that the class is named ResourceHandle.
2461         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2462         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2463         a local RefPtr before calling finishJobAndHandle, since we might get
2464         cancelled inside that function, so we should not rely on m_handle to
2465         keep the ResourceHandle alive.
2466         (WebCore::SubresourceLoader::didFail): Ditto.
2467         (WebCore::SubresourceLoader::didCancel): Ditto.
2468
2469 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2470
2471         - build fix
2472
2473         * platform/network/mac/ResourceHandleMac.mm:
2474
2475 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2476
2477         Rubber stamped by Darin.
2478
2479         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2480
2481         * CMakeLists.txt:
2482         * Projects/gdk/webcore-gdk.bkl:
2483         * WebCore.vcproj/WebCore/WebCore.vcproj:
2484         * WebCore.xcodeproj/project.pbxproj:
2485         * WebCoreSources.bkl:
2486         * bridge/mac/FrameMac.mm:
2487         * bridge/win/FrameWin.cpp:
2488         * dom/XMLTokenizer.cpp:
2489         * loader/Cache.cpp:
2490         * loader/CachedResource.h:
2491         * loader/LoaderFunctions.h:
2492         * loader/icon/IconLoader.cpp:
2493         (IconLoader::startLoading):
2494         (IconLoader::didReceiveData):
2495         (IconLoader::didFinishLoading):
2496         * loader/icon/IconLoader.h:
2497         * loader/loader.cpp:
2498         (WebCore::Loader::servePendingRequests):
2499         (WebCore::Loader::receivedAllData):
2500         (WebCore::Loader::receivedResponse):
2501         (WebCore::Loader::didReceiveData):
2502         (WebCore::Loader::cancelRequests):
2503         (WebCore::Loader::jobForRequest):
2504         * loader/loader.h:
2505         * loader/mac/IconLoaderMac.mm:
2506         (IconLoader::receivedResponse):
2507         * loader/mac/LoaderFunctionsMac.mm:
2508         * loader/mac/WebLoader.h:
2509         * loader/mac/WebSubresourceLoader.h:
2510         * loader/mac/WebSubresourceLoader.mm:
2511         (WebCore::SubresourceLoader::SubresourceLoader):
2512         (WebCore::SubresourceLoader::create):
2513         * platform/gdk/FrameGdk.cpp:
2514         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2515         (WebCore::FrameGdkClientDefault::openURL):
2516         (WebCore::FrameGdkClientDefault::submitForm):
2517         (WebCore::FrameGdkClientDefault::receivedResponse):
2518         (WebCore::FrameGdkClientDefault::didReceiveData):
2519         (WebCore::FrameGdkClientDefault::receivedAllData):
2520         * platform/gdk/FrameGdk.h:
2521         * platform/gdk/TemporaryLinkStubs.cpp:
2522         (WebCore::ServeSynchronousRequest):
2523         (WebCore::ResourceHandle::assembleResponseHeaders):
2524         (WebCore::ResourceHandle::retrieveCharset):
2525         * platform/network/ResourceHandle.cpp: Added.
2526         (WebCore::ResourceHandle::ResourceHandle):
2527         (WebCore::ResourceHandle::create):
2528         (WebCore::ResourceHandle::isErrorPage):
2529         (WebCore::ResourceHandle::error):
2530         (WebCore::ResourceHandle::setError):
2531         (WebCore::ResourceHandle::responseEncoding):
2532         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2533         (WebCore::ResourceHandle::kill):
2534         (WebCore::ResourceHandle::requestHeaders):
2535         (WebCore::ResourceHandle::url):
2536         (WebCore::ResourceHandle::postData):
2537         (WebCore::ResourceHandle::method):
2538         (WebCore::ResourceHandle::client):
2539         * platform/network/ResourceHandle.h: Added.
2540         (WebCore::ResourceHandle::getInternal):
2541         * platform/network/ResourceHandleClient.h: Added.
2542         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2543         (WebCore::ResourceHandleClient::didReceiveData):
2544         (WebCore::ResourceHandleClient::didFinishLoading):
2545         (WebCore::ResourceHandleClient::receivedRedirect):
2546         (WebCore::ResourceHandleClient::receivedResponse):
2547         (WebCore::ResourceHandleClient::receivedAllData):
2548         * platform/network/ResourceHandleInternal.h: Added.
2549         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2550         * platform/network/ResourceLoader.cpp: Removed.
2551         * platform/network/ResourceLoader.h: Removed.
2552         * platform/network/ResourceLoaderClient.h: Removed.
2553         * platform/network/ResourceLoaderInternal.h: Removed.
2554         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2555         (WebCore::willSendRequest):
2556         (WebCore::didReceiveResponse):
2557         (WebCore::didReceiveData):
2558         (WebCore::didFinishLoading):
2559         (WebCore::didFail):
2560         (WebCore::willCacheResponse):
2561         (WebCore::didReceiveChallenge):
2562         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2563         (WebCore::ResourceHandle::~ResourceHandle):
2564         (WebCore::ResourceHandle::start):
2565         (WebCore::ResourceHandle::cancel):
2566         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2567         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2568         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2569         (WebCore::ResourceHandle::~ResourceHandle):
2570         (WebCore::ResourceHandle::start):
2571         (WebCore::ResourceHandle::cancel):
2572         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2573         (WebCore::ResourceHandleManager::ResourceHandleManager):
2574         (WebCore::ResourceHandleManager::get):
2575         (WebCore::ResourceHandleManager::useSimpleTransfer):
2576         (WebCore::writeCallback):
2577         (WebCore::ResourceHandleManager::downloadTimerCallback):
2578         (WebCore::ResourceHandleManager::remove):
2579         (WebCore::ResourceHandleManager::add):
2580         (WebCore::ResourceHandleManager::cancel):
2581         * platform/network/gdk/ResourceHandleManager.h: Added.
2582         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2583         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2584         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2585         * platform/network/mac/ResourceHandleMac.mm: Added.
2586         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2587         (WebCore::ResourceHandle::~ResourceHandle):
2588         (WebCore::ResourceHandle::start):
2589         (WebCore::ResourceHandle::assembleResponseHeaders):
2590         (WebCore::ResourceHandle::retrieveResponseEncoding):
2591         (WebCore::ResourceHandle::receivedResponse):
2592         (WebCore::ResourceHandle::cancel):
2593         (WebCore::ResourceHandle::redirectedToURL):
2594         (WebCore::ResourceHandle::addData):
2595         (WebCore::ResourceHandle::finishJobAndHandle):
2596         (WebCore::ResourceHandle::reportError):
2597         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2598         * platform/network/qt/ResourceHandleManager.cpp: Added.
2599         (WebCore::ResourceHandleManager::ResourceHandleManager):
2600         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2601         (WebCore::ResourceHandleManager::self):
2602         (WebCore::ResourceHandleManager::slotData):
2603         (WebCore::ResourceHandleManager::slotMimetype):
2604         (WebCore::ResourceHandleManager::slotResult):
2605         (WebCore::ResourceHandleManager::remove):
2606         (WebCore::ResourceHandleManager::add):
2607         (WebCore::ResourceHandleManager::cancel):
2608         * platform/network/qt/ResourceHandleManager.h: Added.
2609         * platform/network/qt/ResourceHandleQt.cpp: Added.
2610         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2611         (WebCore::ResourceHandle::~ResourceHandle):
2612         (WebCore::ResourceHandle::start):
2613         (WebCore::ResourceHandle::cancel):
2614         (WebCore::ResourceHandle::assembleResponseHeaders):
2615         (WebCore::ResourceHandle::retrieveResponseEncoding):
2616         (WebCore::ResourceHandle::receivedResponse):
2617         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2618         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2619         * platform/network/qt/ResourceLoaderManager.h: Removed.
2620         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2621         * platform/network/win/ResourceHandleWin.cpp: Added.
2622         (WebCore::):
2623         (WebCore::addToOutstandingJobs):
2624         (WebCore::lookupResourceHandle):
2625         (WebCore::ResourceHandleWndProc):
2626         (WebCore::initializeOffScreenResourceHandleWindow):
2627         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2628         (WebCore::ResourceHandle::~ResourceHandle):
2629         (WebCore::ResourceHandle::onHandleCreated):
2630         (WebCore::ResourceHandle::onRequestRedirected):
2631         (WebCore::ResourceHandle::onRequestComplete):
2632         (WebCore::ResourceHandle::start):
2633         (WebCore::ResourceHandle::fileLoadTimer):
2634         (WebCore::ResourceHandle::cancel):
2635         (WebCore::ResourceHandle::setHasReceivedResponse):
2636         (WebCore::ResourceHandle::hasReceivedResponse):
2637         * platform/network/win/ResourceHandleWin.h: Added.
2638         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2639         * platform/network/win/ResourceLoaderWin.h: Removed.
2640         * platform/qt/FrameQt.cpp:
2641         * platform/qt/FrameQtClient.cpp:
2642         (WebCore::FrameQtClientDefault::openURL):
2643         (WebCore::FrameQtClientDefault::submitForm):
2644         (WebCore::FrameQtClientDefault::receivedResponse):
2645         (WebCore::FrameQtClientDefault::didReceiveData):
2646         (WebCore::FrameQtClientDefault::receivedAllData):
2647         * platform/qt/FrameQtClient.h:
2648         * platform/win/TemporaryLinkStubs.cpp:
2649         (WebCore::ResourceHandle::assembleResponseHeaders):
2650         (WebCore::ResourceHandle::retrieveResponseEncoding):
2651         (WebCore::ServeSynchronousRequest):
2652         * xml/XSLTProcessor.cpp:
2653         * xml/xmlhttprequest.cpp:
2654         (WebCore::XMLHttpRequest::send):
2655         (WebCore::XMLHttpRequest::didFinishLoading):
2656         (WebCore::XMLHttpRequest::receivedRedirect):
2657         (WebCore::XMLHttpRequest::didReceiveData):
2658         * xml/xmlhttprequest.h:
2659
2660 t2006-10-29  Darin Adler  <darin@apple.com>
2661
2662         Reviewed by Maciej.
2663
2664         - eliminate use of NSArray to carry form data around
2665
2666         * WebCore.exp:
2667         * WebCore.xcodeproj/project.pbxproj:
2668         * bridge/mac/FormDataMac.h: Removed.
2669         * bridge/mac/FormDataMac.mm: Removed.
2670         * bridge/mac/FrameMac.h:
2671         * bridge/mac/WebCoreFrameBridge.h:
2672         * bridge/mac/WebCoreFrameBridge.mm:
2673         * html/HTMLFormElement.cpp:
2674         (WebCore::HTMLFormElement::submit):
2675         * loader/FormData.h:
2676         (WebCore::FormData::isEmpty):
2677         * loader/mac/FrameLoader.h:
2678         * loader/mac/FrameLoader.mm:
2679         (WebCore::FrameLoader::load):
2680         (WebCore::FrameLoader::post):
2681         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2682         (WebCore::FrameLoader::loadResourceSynchronously):
2683         * loader/mac/LoaderFunctionsMac.mm:
2684         (WebCore::ServeSynchronousRequest):
2685         * loader/mac/WebFormDataStream.h:
2686         * loader/mac/WebFormDataStream.m:
2687         (WebCore::pairRetain):
2688         (WebCore::pairRelease):
2689         (WebCore::pairEqual):
2690         (WebCore::pairHash):
2691         (WebCore::closeCurrentStream):
2692         (WebCore::scheduleWithPair):
2693         (WebCore::advanceCurrentStream):
2694         (WebCore::openNextStream):
2695         (WebCore::formCreate):
2696         (WebCore::formFinalize):
2697         (WebCore::formOpen):
2698         (WebCore::formRead):
2699         (WebCore::formCanRead):
2700         (WebCore::formClose):
2701         (WebCore::formSchedule):
2702         (WebCore::formUnschedule):
2703         (WebCore::formEventCallback):
2704         (WebCore::setHTTPBody):
2705         * loader/mac/WebSubresourceLoader.h:
2706         * loader/mac/WebSubresourceLoader.mm:
2707         (WebCore::SubresourceLoader::create):
2708         * platform/network/mac/ResourceLoaderMac.mm:
2709
2710 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2711
2712         Reviewed by Darin.
2713
2714         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2715
2716         * loader/mac/WebSubresourceLoader.h:
2717         * loader/mac/WebSubresourceLoader.mm:
2718         (WebCore::SubresourceLoader::create):
2719         * platform/network/mac/ResourceLoaderMac.mm:
2720         (WebCore::ResourceLoader::start):
2721
2722 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2723
2724         Reviewed by Darin.
2725
2726         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2727
2728         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2729         
2730         * WebCore.xcodeproj/project.pbxproj:
2731         * bridge/mac/WebCoreFrameBridge.h:
2732         * loader/mac/FrameLoader.h:
2733         * loader/mac/FrameLoader.mm:
2734         * loader/mac/LoaderFunctionsMac.mm:
2735         * loader/mac/WebLoader.h:
2736         * loader/mac/WebSubresourceLoader.h:
2737         * loader/mac/WebSubresourceLoader.mm:
2738         (WebCore::SubresourceLoader::SubresourceLoader):
2739         (WebCore::SubresourceLoader::create):
2740         (WebCore::SubresourceLoader::willSendRequest):
2741         (WebCore::SubresourceLoader::didReceiveResponse):
2742         (WebCore::SubresourceLoader::didReceiveData):
2743         (WebCore::SubresourceLoader::didFinishLoading):
2744         (WebCore::SubresourceLoader::didFail):
2745         (WebCore::SubresourceLoader::didCancel):
2746         * platform/network/ResourceLoader.h:
2747         * platform/network/ResourceLoaderInternal.h:
2748         * platform/network/mac/ResourceLoaderMac.mm:
2749         (WebCore::ResourceLoader::~ResourceLoader):
2750         (WebCore::ResourceLoader::start):
2751         (WebCore::ResourceLoader::receivedResponse):
2752         (WebCore::ResourceLoader::cancel):
2753         (WebCore::ResourceLoader::redirectedToURL):
2754         (WebCore::ResourceLoader::addData):
2755         (WebCore::ResourceLoader::finishJobAndHandle):
2756         (WebCore::ResourceLoader::reportError):
2757         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2758         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2759         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2760
2761 2006-10-28  Darin Adler  <darin@apple.com>
2762
2763         Reviewed by Maciej.
2764
2765         - eliminated the use of Objective-C for the policy decider
2766           machinery, obviating the need for WebPolicyDecider,
2767           WebCoreFrameLoaderAsDelegate, and
2768           WebCoreMainResourceLoaderAsPolicyDelegate
2769
2770         - grouped the state related to policy decisions into a PolicyCheck
2771           class to simplify the FrameLoader logic
2772
2773         - removed six methods from the bridge, reducing FrameLoader's use of
2774           the bridge to a single method
2775
2776         - changed form state to always use HashMap instead of NSDictionary
2777
2778         - moved the defersLoading flag from WebView to WebCore::Page
2779           and changed code to consistently call it defersLoading rather
2780           than defersCallbacks
2781
2782         - updated for rename of PassRefPtr::release to releaseRef
2783         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2784         - cleaned up kjs_binding.h a bit
2785         - cleaned up FrameMac.h a bit
2786
2787         * loader/mac/WebPolicyDecider.h: Removed.
2788         * loader/mac/WebPolicyDecider.mm: Removed.
2789         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2790
2791         * WebCore.exp:
2792         * bindings/js/kjs_binding.cpp:
2793         (KJS::ScriptInterpreter::ScriptInterpreter):
2794         (KJS::ScriptInterpreter::wasRunByUserGesture):
2795         * bindings/js/kjs_binding.h:
2796         (KJS::ScriptInterpreter::setCurrentEvent):
2797         (KJS::ScriptInterpreter::setInlineCode):
2798         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2799         (KJS::ScriptInterpreter::getCurrentEvent):
2800         (KJS::cacheDOMObject):
2801         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2802         * bridge/AXObjectCache.h:
2803         * bridge/mac/BrowserExtensionMac.mm:
2804         (WebCore::BrowserExtensionMac::createNewWindow):
2805         * bridge/mac/FrameMac.h:
2806         * bridge/mac/FrameMac.mm:
2807         (WebCore::FrameMac::loadRequest):
2808         (WebCore::FrameMac::submitForm):
2809         (WebCore::FrameMac::urlSelected):
2810         (WebCore::FrameMac::userAgent):
2811         (WebCore::FrameMac::passMouseDownEventToWidget):
2812         (WebCore::FrameMac::handleMouseMoveEvent):
2813         * bridge/mac/PageMac.mm:
2814         (WebCore::Page::Page):
2815         * bridge/mac/WebCoreEditCommand.mm:
2816         * bridge/mac/WebCoreFrameBridge.h:
2817         * bridge/mac/WebCoreFrameBridge.mm:
2818         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2819         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2820         * css/CSSComputedStyleDeclaration.cpp:
2821         (WebCore::):
2822         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2823         * css/CSSPrimitiveValue.cpp:
2824         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2825         (WebCore::CSSPrimitiveValue::cleanup):
2826         (WebCore::CSSPrimitiveValue::cssText):
2827         * css/CSSPrimitiveValue.h:
2828         (WebCore::CSSPrimitiveValue::):
2829         * css/CSSValueList.cpp:
2830         (WebCore::CSSValueList::append):
2831         * css/cssparser.cpp:
2832         (WebCore::CSSParser::parseValue):
2833         * css/cssparser.h:
2834         * css/cssstyleselector.cpp:
2835         (WebCore::CSSStyleSelector::applyProperty):
2836         * dom/Document.cpp:
2837         (WebCore::Document::Document):
2838         (WebCore::Document::updateSelection):
2839         (WebCore::Document::implicitClose):
2840         (WebCore::Document::setFocusNode):
2841         * dom/Document.h:
2842         * editing/ReplaceSelectionCommand.h:
2843         * html/HTMLParser.cpp:
2844         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2845         * loader/mac/FrameLoader.h:
2846         (WebCore::PolicyCheck::request):
2847         * loader/mac/FrameLoader.mm:
2848         (WebCore::FrameLoader::~FrameLoader):
2849         (WebCore::FrameLoader::safeLoad):
2850         (WebCore::FrameLoader::load):
2851         (WebCore::FrameLoader::open):
2852         (WebCore::FrameLoader::stopLoading):
2853         (WebCore::setAllDefersLoading):
2854         (WebCore::FrameLoader::setDefersLoading):
2855         (WebCore::FrameLoader::willSendRequest):
2856         (WebCore::FrameLoader::receivedMainResourceError):
2857         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2858         (WebCore::FrameLoader::commitProvisionalLoad):
2859         (WebCore::FrameLoader::checkNavigationPolicy):
2860         (WebCore::FrameLoader::checkContentPolicy):
2861         (WebCore::FrameLoader::cancelContentPolicyCheck):
2862         (WebCore::FrameLoader::stopPolicyCheck):
2863         (WebCore::FrameLoader::checkNewWindowPolicy):
2864         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2865         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2866         (WebCore::FrameLoader::continueAfterContentPolicy):
2867         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2868         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2869         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2870         (WebCore::FrameLoader::closeDocument):
2871         (WebCore::FrameLoader::transitionToCommitted):
2872         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2873         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2874         (WebCore::FrameLoader::post):
2875         (WebCore::FrameLoader::detachFromParent):
2876         (WebCore::FrameLoader::addExtraFieldsToRequest):
2877         (WebCore::PolicyCheck::PolicyCheck):
2878         (WebCore::PolicyCheck::clear):
2879         (WebCore::PolicyCheck::set):
2880         (WebCore::PolicyCheck::call):
2881         (WebCore::PolicyCheck::dropRequest):
2882         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2883         * loader/mac/WebFormState.h:
2884         * loader/mac/WebFormState.mm:
2885         * loader/mac/WebFrameLoaderClient.h:
2886         * loader/mac/WebLoader.h:
2887         (WebCore::WebResourceLoader::defersLoading):
2888         * loader/mac/WebLoader.mm:
2889         (WebCore::WebResourceLoader::WebResourceLoader):
2890         (WebCore::WebResourceLoader::load):
2891         (WebCore::WebResourceLoader::setDefersLoading):
2892         * loader/mac/WebMainResourceLoader.h:
2893         * loader/mac/WebMainResourceLoader.mm:
2894         (WebCore::MainResourceLoader::MainResourceLoader):
2895         (WebCore::MainResourceLoader::releaseDelegate):
2896         (WebCore::MainResourceLoader::didCancel):
2897         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2898         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2899         (WebCore::MainResourceLoader::willSendRequest):
2900         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2901         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2902         (WebCore::MainResourceLoader::didReceiveResponse):
2903         (WebCore::MainResourceLoader::didReceiveData):
2904         (WebCore::MainResourceLoader::didFinishLoading):
2905         (WebCore::MainResourceLoader::didFail):
2906         (WebCore::MainResourceLoader::loadNow):
2907         (WebCore::MainResourceLoader::load):
2908         (WebCore::MainResourceLoader::setDefersLoading):
2909         * page/Frame.cpp:
2910         (WebCore::Frame::paint):
2911         * page/FrameView.cpp:
2912         (WebCore::FrameView::layout):
2913         * page/FrameView.h:
2914         * page/Page.cpp:
2915         (WebCore::Page::setDefersLoading):
2916         * page/Page.h:
2917         (WebCore::Page::defersLoading):
2918         * platform/DeprecatedString.h:
2919         * platform/DeprecatedStringList.h:
2920         * platform/FontFallbackList.h:
2921         * platform/PlatformKeyboardEvent.h:
2922         * platform/PlatformMouseEvent.h:
2923         * platform/PlatformWheelEvent.h:
2924         * platform/mac/ClipboardMac.h:
2925         * platform/mac/ClipboardMac.mm:
2926         (WebCore::ClipboardMac::setDragImage):
2927         (WebCore::ClipboardMac::dragNSImage):
2928         (WebCore::ClipboardMac::sourceOperation):
2929         (WebCore::ClipboardMac::destinationOperation):
2930         * rendering/RenderObject.cpp:
2931         (WebCore::RenderObject::setStyle):
2932         * rendering/break_lines.cpp:
2933         (WebCore::nextBreakablePosition):
2934
2935 2006-10-28  Adam Roben  <aroben@apple.com>
2936
2937         Reviewed by Maciej.
2938
2939         Fix layout tests that broke after r17399. Mitz discovered that the
2940         failures were caused by HitTestResult::m_point being uninitialized
2941         much of the time. HitTestResults are now always constructed with a
2942         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2943         point instead of being passed one explicitly.
2944
2945         * WebCore.exp: Change constructor symbol.
2946         * bridge/mac/FrameMac.mm:
2947         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2948         hitTest().
2949         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2950         * bridge/mac/WebCoreAXObject.mm:
2951         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2952         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2953         * dom/Document.cpp:
2954         (WebCore::Document::elementFromPoint): Ditto.
2955         (WebCore::Document::prepareMouseEvent): Ditto.
2956         * page/Frame.cpp:
2957         (WebCore::Frame::isPointInsideSelection): Ditto.
2958         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2959         * page/FrameView.cpp:
2960         (WebCore::FrameView::handleWheelEvent): Ditto.
2961         * rendering/HitTestResult.cpp:
2962         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2963         passed point.
2964         * rendering/HitTestResult.h: Update constructor declaration.
2965         * rendering/RenderLayer.cpp:
2966         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2967         hitTest().
2968         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2969         HitTestResult instead of being passed one.
2970         (WebCore::RenderLayer::hitTestLayer): Ditto.
2971         * rendering/RenderLayer.h: Update declarations.
2972
2973 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2974
2975         Reviewed by Anders.
2976
2977         Fix Qt/Linux build.
2978
2979         * CMakeLists.txt:
2980         * platform/qt/FrameQtClient.cpp:
2981         (WebCore::numRequests):
2982         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2983         * platform/qt/PopupMenuQt.cpp:
2984         (WebCore::PopupMenu::updateFromElement):
2985
2986 2006-10-28  David Carson  <dacarson@gmail.com>
2987
2988         Tweaked by Sam. Reviewed by Brady.
2989
2990         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2991         Initialize m_modifyBiasSet to false, as it sometimes gets 
2992         used before it has been initalized.
2993
2994         * editing/SelectionController.cpp:
2995         (WebCore::SelectionController::SelectionController):
2996
2997 2006-10-28  Beth Dakin  <bdakin@apple.com>
2998
2999         Reviewed by Darin.
3000
3001         This is the WebCore half of pushing elementAtPoint and the backend 
3002         of WebElementDictionary into WebCore. Most of the changes below are 
3003         to accommodate one of the following:
3004                 
3005         -NodeInfo is now a stand-alone class called HitTestResult. 
3006                 Previously it was defined in RenderObject.h, but not for 
3007                 any particular reason. The WebElementDictionary 
3008                 functionality that was pushed into WebCore has been pushed 
3009                 specifically into the this class. In fact, 
3010                 WebElementDictionary now keeps a HitTestResult as a member 
3011                 varibale.
3012                 
3013         -The enumeration AccessPolicy is now called 
3014                 ClipboardAccessPolicy and is defined in its own header. It 
3015                 was previously defined in ClipboardMac.h, but is now 
3016                 defined independently to avoid including ClipboardMac.h 
3017                 from within FrameMac.h since FrameMac.h is now included in 
3018                 WebElementDictionary.m in WebKit.
3019                 
3020         -Element now has a virtual target() for the sake of 
3021                 NodeInfo::targetFrame() 
3022
3023         * WebCore.exp: Several WebCore functions are newly called from 
3024         WebKit, so they have been added here. 
3025         * WebCore.xcodeproj/project.pbxproj:
3026         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3027         to ClipboardMac.
3028         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3029         * bridge/mac/FrameMac.mm:
3030         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3031         and HitTestResult changes.
3032         (WebCore::FrameMac::eventMayStartDrag): Same.
3033         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3034         (WebCore::FrameMac::dispatchCPPEvent): Same.
3035         (WebCore::FrameMac::mayDHTMLCut): Same.
3036         (WebCore::FrameMac::mayDHTMLCopy): Same.
3037         (WebCore::FrameMac::mayDHTMLPaste): Same.
3038         (WebCore::FrameMac::tryDHTMLCut): Same
3039         (WebCore::FrameMac::tryDHTMLCopy): Same.
3040         (WebCore::FrameMac::tryDHTMLPaste): Same.
3041         * bridge/mac/WebCoreAXObject.mm:
3042         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3043         HitTestResult changes.
3044         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3045         * bridge/mac/WebCoreFrameBridge.h: Same.
3046         * bridge/mac/WebCoreFrameBridge.mm:
3047         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3048         ClipboardAccessPolicy changes.
3049         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3050         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3051         * dom/Document.cpp:
3052         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3053         changes.
3054         (WebCore::Document::prepareMouseEvent): Same.
3055         * dom/Element.h:
3056         (WebCore::Element::target): Now has a virtual target()
3057         * html/HTMLAnchorElement.h: Same.
3058         * html/HTMLAreaElement.cpp:
3059         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3060         changes.
3061         * html/HTMLAreaElement.h: Virtual target()
3062         * html/HTMLBaseElement.h:
3063         (WebCore::HTMLBaseElement::target): Same.
3064         * html/HTMLFormElement.h: Same.
3065         * html/HTMLLinkElement.h: Same.
3066         * html/HTMLMapElement.cpp:
3067         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3068         changes.
3069         * html/HTMLMapElement.h: Same.
3070         * page/Frame.cpp:
3071         (WebCore::Frame::isPointInsideSelection): Same.
3072         (WebCore::Frame::hitTestResultAtPoint): Same. 
3073         * page/Frame.h: Same.
3074         * page/FrameView.cpp:
3075         (WebCore::FrameView::handleWheelEvent): Same.
3076         * platform/mac/ClipboardAccessPolicy.h: Added.
3077         (WebCore::):
3078         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3079         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3080         ClipboardAccessPolicy.
3081         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3082         (WebCore::ClipboardMac::ClipboardMac):
3083         (WebCore::ClipboardMac::setAccessPolicy):
3084         (WebCore::ClipboardMac::clearData):
3085         (WebCore::ClipboardMac::clearAllData):
3086         (WebCore::ClipboardMac::getData):
3087         (WebCore::ClipboardMac::setData):
3088         (WebCore::ClipboardMac::types):
3089         (WebCore::ClipboardMac::setDragImage):
3090         (WebCore::ClipboardMac::setDropEffect):
3091         (WebCore::ClipboardMac::setEffectAllowed):
3092         * rendering/EllipsisBox.cpp:
3093         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3094         changes.
3095         * rendering/EllipsisBox.h:
3096         * rendering/HitTestResult.cpp: Added.
3097         (WebCore::HitTestResult::HitTestResult):
3098         (WebCore::HitTestResult::~HitTestResult):
3099         (WebCore::HitTestResult::operator=):
3100         (WebCore::HitTestResult::setInnerNode):
3101         (WebCore::HitTestResult::setInnerNonSharedNode):
3102         (WebCore::HitTestResult::setURLElement):
3103         (WebCore::HitTestResult::setScrollbar):
3104         (WebCore::HitTestResult::targetFrame):
3105         (WebCore::HitTestResult::boundingBox):
3106         (WebCore::HitTestResult::isSelected):
3107         (WebCore::HitTestResult::title):
3108         * rendering/HitTestResult.h: Added.
3109         (WebCore::HitTestResult::readonly):
3110         (WebCore::HitTestResult::active):
3111         (WebCore::HitTestResult::mouseMove):
3112         (WebCore::HitTestResult::innerNode):
3113         (WebCore::HitTestResult::innerNonSharedNode):
3114         (WebCore::HitTestResult::point):
3115         (WebCore::HitTestResult::URLElement):
3116         (WebCore::HitTestResult::scrollbar):
3117         (WebCore::HitTestResult::setPoint):
3118         (WebCore::HitTestResult::setReadonly):
3119         (WebCore::HitTestResult::setActive):
3120         (WebCore::HitTestResult::setMouseMove):
3121         * rendering/InlineBox.cpp:
3122         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3123         * rendering/InlineBox.h: Same.
3124         * rendering/InlineFlowBox.cpp:
3125         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3126         * rendering/InlineFlowBox.h: Same.
3127         * rendering/InlineTextBox.cpp: 
3128         (WebCore::InlineTextBox::nodeAtPoint): Same.
3129         * rendering/InlineTextBox.h: Same.
3130         * rendering/RenderBlock.cpp:
3131         (WebCore::RenderBlock::isPointInScrollbar): Same.
3132         (WebCore::RenderBlock::nodeAtPoint): Same.
3133         * rendering/RenderBlock.h: Same.
3134         * rendering/RenderBox.cpp:
3135         (WebCore::RenderBox::nodeAtPoint): Same.
3136         * rendering/RenderBox.h: Same.
3137         * rendering/RenderFlow.cpp:
3138         (WebCore::RenderFlow::hitTestLines): Same.
3139         * rendering/RenderFlow.h: Same.
3140         * rendering/RenderForeignObject.cpp:
3141         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3142         * rendering/RenderForeignObject.h: Same.
3143         * rendering/RenderFrameSet.cpp:
3144         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3145         * rendering/RenderFrameSet.h: Same.
3146         * rendering/RenderImage.cpp:
3147         (WebCore::RenderImage::nodeAtPoint): Same.
3148         * rendering/RenderImage.h: Same.
3149         * rendering/RenderInline.cpp:
3150         (WebCore::RenderInline::nodeAtPoint): Same.
3151         * rendering/RenderInline.h: Same.
3152         * rendering/RenderLayer.cpp:
3153         (WebCore::RenderLayer::autoscroll): Same.
3154         (WebCore::RenderLayer::hitTest): Same.
3155         (WebCore::RenderLayer::hitTestLayer): Same.
3156         (WebCore::RenderLayer::updateHoverActiveState): Same.
3157         * rendering/RenderLayer.h: Same.
3158         * rendering/RenderListBox.cpp:
3159         (WebCore::RenderListBox::isPointInScrollbar): Same.
3160         * rendering/RenderListBox.h: Same.
3161         * rendering/RenderObject.cpp:
3162         (WebCore::RenderObject::hitTest): Same.
3163         (WebCore::RenderObject::setInnerNode): Same.
3164         (WebCore::RenderObject::nodeAtPoint): Same.
3165         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3166         declare HitTestResult.
3167         * rendering/RenderPath.cpp:
3168         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3169         changes.
3170         * rendering/RenderPath.h: Same.
3171         * rendering/RenderSVGImage.cpp:
3172         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3173         * rendering/RenderSVGImage.h: Same
3174         * rendering/RenderSVGText.cpp:
3175         (WebCore::RenderSVGText::nodeAtPoint): Same.
3176         * rendering/RenderSVGText.h: Same.
3177         * rendering/RenderTableRow.cpp:
3178         (WebCore::RenderTableRow::nodeAtPoint): Same.
3179         * rendering/RenderTableRow.h: Same.
3180         * rendering/RenderTableSection.cpp:
3181         (WebCore::RenderTableSection::nodeAtPoint): Same.
3182         * rendering/RenderTableSection.h: Same.
3183         * rendering/RenderText.h: Same.
3184         (WebCore::RenderText::nodeAtPoint): Same.
3185         * rendering/RenderTextControl.cpp:
3186         (WebCore::RenderTextControl::nodeAtPoint): Same.
3187         * rendering/RenderTextControl.h: Same.
3188         * rendering/RootInlineBox.cpp:
3189         (WebCore::RootInlineBox::nodeAtPoint): Same.
3190         * rendering/RootInlineBox.h: Same.
3191
3192 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3193
3194         Reviewed by Anders.
3195
3196         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3197         impact of fixing it again.
3198
3199         * bridge/mac/FrameMac.mm:
3200         (WebCore::FrameMac::clear):
3201
3202 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3203
3204         Reviewed by John & Adam.
3205
3206         - assorted speedups to fix perf regression from fixing correctness regression
3207
3208         * WebCore.exp: exported new methods.
3209         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3210         * bridge/mac/WebCoreFrameBridge.h:
3211         * bridge/mac/WebCoreFrameBridge.mm:
3212         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3213         * loader/CachedResource.h:
3214         * loader/mac/CachedResourceMac.mm: Added.
3215         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3216         now cached in the CachedObject.
3217         * loader/mac/FrameLoader.h:
3218         * loader/mac/FrameLoader.mm:
3219         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3220         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3221         * loader/mac/LoaderFunctionsMac.mm:
3222         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3223         just call loadedResourceFromMemoryCache.
3224         * loader/mac/WebFrameLoaderClient.h:
3225
3226 2006-10-27  Oliver Hunt  <oliver@apple.com>
3227
3228         Reviewed by Maciej.
3229
3230         build fix
3231
3232         * dom/Document.cpp:
3233         (WebCore::Document::referrer):
3234
3235 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3236
3237         Reviewed by Maciej.
3238
3239         Moved some WebCoreFrameBridge functions into FrameLoader.
3240         
3241         I had to make FrameLoader.h capable of compiling in C++-only source files
3242         by adding some forward declarations and __OBJC__ #ifdefs.
3243
3244         * WebCore.exp:
3245         * bridge/mac/FrameMac.h:
3246         * bridge/mac/FrameMac.mm:
3247         (WebCore::FrameMac::createEmptyDocument):
3248         (WebCore::FrameMac::tokenizerProcessedData):
3249         * bridge/mac/WebCoreFrameBridge.h:
3250         * bridge/mac/WebCoreFrameBridge.mm:
3251         * dom/Document.cpp:
3252         (WebCore::Document::processHttpEquiv):
3253         (WebCore::Document::referrer):
3254         * loader/LoaderFunctions.h:
3255         * loader/mac/FrameLoader.h:
3256         * loader/mac/FrameLoader.mm:
3257         (WebCore::numRequests):
3258         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3259         (WebCore::FrameLoader::isReloading):
3260         (WebCore::FrameLoader::referrer):
3261         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3262         (WebCore::FrameLoader::startLoadingResource):
3263         * loader/mac/LoaderFunctionsMac.mm:
3264         (WebCore::CheckIfReloading):
3265         * page/Frame.h:
3266         * page/FrameTree.cpp:
3267         (WebCore::FrameTree::isDescendantOf):
3268         (WebCore::FrameTree::traverseNext):
3269         * page/FrameTree.h:
3270         * platform/network/mac/ResourceLoaderMac.mm:
3271         (WebCore::ResourceLoader::start):
3272
3273 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3274
3275         Reviewed by Darin.
3276
3277         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3278
3279         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3280
3281         * editing/DeleteButtonController.cpp:
3282         (WebCore::isDeletableElement):
3283         (WebCore::enclosingDeletableElement):
3284         (WebCore::DeleteButtonController::respondToChangedSelection):
3285
3286 2006-10-27  John Sullivan  <sullivan@apple.com>
3287
3288         Reviewed by Kevin Decker
3289         
3290         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3291         you haven't not finished reading this.
3292
3293         * rendering/InlineTextBox.h:
3294         * rendering/InlineTextBox.cpp:
3295         (WebCore::InlineTextBox::paint):
3296         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3297         considered also.
3298         (WebCore::InlineTextBox::paintDocumentMarkers):
3299         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3300         markers should be painted, instead of a marker type. This avoids walking the collection of
3301         markers multiple times back to back. Now handles grammar markers.
3302
3303 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3304
3305         Reviewed by Beth.
3306
3307         Renamed Copy Files to Copy Generated Headers.
3308         Copy 4 DOM*Internal.h headers.
3309
3310         * WebCore.xcodeproj/project.pbxproj:
3311         * bindings/scripts/CodeGeneratorObjC.pm:
3312
3313 2006-10-27  John Sullivan  <sullivan@apple.com>
3314
3315         Reviewed by Anders
3316
3317         * WebCore.exp:
3318         exported symbol for FrameMac->advanceToNextSpelling()
3319         
3320         * bridge/mac/WebCoreFrameBridge.h:
3321         * bridge/mac/WebCoreFrameBridge.mm:
3322         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3323
3324 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3325
3326         Reviewed by harrison
3327         
3328         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3329         REGRESSION: First newline missing from textarea's value
3330         
3331         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3332         
3333         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3334         (the line break) then a br to prevent the '\n' from collapsing, since the 
3335         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3336         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3337         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3338         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3339         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3340         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3341         the shadow div will be placeholders or collapsed.
3342         
3343         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3344         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3345         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3346         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3347         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3348         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3349         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3350         before it.
3351         
3352         * editing/CompositeEditCommand.cpp:
3353         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3354         a br or '\n' if content inserted just before it will cause it to collapse.
3355         * editing/CompositeEditCommand.h:
3356         * editing/InsertLineBreakCommand.cpp:
3357         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3358         to prevent a collapse as was used for the line break.  Fixed comments.
3359         * editing/InsertTextCommand.cpp:
3360         (WebCore::InsertTextCommand::input): Call the renamed function.
3361         
3362 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3363
3364         Reviewed by Brady.
3365
3366         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3367         String became an empty NSString *, instead of nil. This will become important
3368         as we start using this conversion more.
3369         
3370         Added work-around for AppKit crash that semantic accuracy revealed.
3371         
3372         No testcase because I don't think there's a way to reflect this change
3373         in a webpage yet.
3374
3375         * platform/PlatformString.h:
3376         (WebCore::String::operator NSString*):
3377         * platform/mac/TextFieldMac.mm:
3378         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3379
3380 2006-10-27  David Harrison  <harrison@apple.com>
3381
3382         Reviewed by Maciej,
3383
3384         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3385
3386         * bridge/mac/WebCoreAXObject.mm:
3387         (blockquoteLevel):
3388         Calculate and return the blockquote level of the element.
3389         
3390         (AXAttributeStringSetBlockquoteLevel):
3391         Add, if non-zero, or clear the block quote level attribute.
3392         
3393         (AXAttributedStringAppendText):
3394         Send AXAttributeStringSetBlockquoteLevel.
3395
3396 2006-10-27  Darin Adler  <darin@apple.com>
3397
3398         - fix one error in the Qt build
3399
3400         * platform/qt/GraphicsContextQt.cpp:
3401         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3402         Updated.
3403
3404 2006-10-27  Darin Adler  <darin@apple.com>
3405
3406         Reviewed by Maciej.
3407
3408         * WebCore.exp: Export more symbols needed by WebKit.
3409
3410 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3411
3412         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3413
3414         Fixed layout test crash. Oops.
3415         
3416         * loader/mac/WebDocumentLoader.mm:
3417         (WebCore::canonicalizedTitle):
3418
3419 2006-10-26  John Sullivan  <sullivan@apple.com>
3420
3421         Reviewed by Brady
3422         
3423         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3424         
3425         This restores some of the nil-handling that was implicit before some of the code was converted from
3426         Objective-C to C++.
3427
3428         * bridge/mac/FrameMac.mm:
3429         (WebCore::FrameMac::loadRequest):
3430         handle nil FrameMac
3431         
3432         * bridge/mac/WebCoreFrameBridge.mm:
3433         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3434         handle nil Frame
3435
3436 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3437
3438         Reviewed by Darin, Maciej.
3439
3440         Removed many uses of NSString *.
3441         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
3442         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
3443         
3444         PLT says no performance regression.
3445         
3446         * WebCore.exp:
3447         * bridge/mac/WebCoreFrameBridge.mm:
3448         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3449         * loader/mac/FrameLoader.h:
3450         * loader/mac/FrameLoader.mm:
3451         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3452         (WebCore::FrameLoader::load):
3453         (WebCore::FrameLoader::canShowMIMEType):
3454         (WebCore::FrameLoader::representationExistsForURLScheme):
3455         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3456         (WebCore::FrameLoader::checkContentPolicy):
3457         (WebCore::FrameLoader::reloadAllowingStaleData):
3458         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
3459         (WebCore::FrameLoader::checkNewWindowPolicy):
3460         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3461         (WebCore::FrameLoader::transitionToCommitted):
3462         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3463         (WebCore::FrameLoader::post):
3464         * loader/mac/WebDocumentLoader.h:
3465         * loader/mac/WebDocumentLoader.mm:
3466         (WebCore::DocumentLoader::doesProgressiveLoad):
3467         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3468         (WebCore::DocumentLoader::title):
3469         (WebCore::DocumentLoader::setOverrideEncoding):
3470         (WebCore::DocumentLoader::overrideEncoding):
3471         (WebCore::DocumentLoader::setTitle):
3472         * loader/mac/WebFrameLoaderClient.h:
3473         * loader/mac/WebMainResourceLoader.mm:
3474         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3475
3476 2006-10-26  Timothy Hatcher  <timothy@apple.com>
3477
3478         Reviewed by Adam.
3479
3480         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
3481
3482         The main table at nytimes.com has a fixed width of 874px, but the table ends
3483         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
3484         this. The other bug was a missing top and left of 0px on the container element,
3485         causing the deletion UI to sometimes be offset below the table.
3486
3487         Now check for the element's renderer at the beginning of show() and
3488         return early if it is null.
3489
3490         * editing/DeleteButtonController.cpp:
3491         (WebCore::DeleteButtonController::updateOutlineStyle):
3492         (WebCore::DeleteButtonController::show):
3493
3494 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3495
3496         Build fix.
3497
3498         * html/CanvasRenderingContext2D.cpp:
3499         Include MathExtras.h
3500         
3501 2006-10-26  John Sullivan  <sullivan@apple.com>
3502
3503         Reviewed by Anders.
3504
3505         Some changes to support new grammar checking code in WebKit.
3506
3507         * WebCore.exp:
3508         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
3509         
3510         * WebCore.xcodeproj/project.pbxproj:
3511         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
3512         Made HTMLCollection.h private because Document.h uses it.
3513         
3514         * bridge/mac/WebCoreFrameBridge.h:
3515         * bridge/mac/WebCoreFrameBridge.mm:
3516         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
3517
3518 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3519
3520         Reviewed by Brady.
3521
3522         Add reverseFind to String and use it instead of findRev.
3523         Use CString instead of DeprecatedCString in one place.
3524         
3525         * html/HTMLFormElement.cpp:
3526         (WebCore::HTMLFormElement::formData):
3527         * ksvg2/svg/SVGURIReference.cpp:
3528         (WebCore::SVGURIReference::getTarget):
3529         * loader/Decoder.cpp:
3530         (WebCore::Decoder::checkForCSSCharset):