2009-11-13 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-13  Eric Seidel  <eric@webkit.org>
2
3         No review, build fix only.
4
5         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
6
7         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
8         https://bugs.webkit.org/show_bug.cgi?id=31468
9
10         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
11         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
12
13 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
14
15         Reviewed by Dmitry Titov.
16
17         LocalStorage quota should include key sizes in its count
18         https://bugs.webkit.org/show_bug.cgi?id=31451
19
20         * storage/StorageMap.cpp:
21         (WebCore::StorageMap::setItem):
22             Count keys in the quota when adding a new item.
23         (WebCore::StorageMap::removeItem):
24             Remove the key's length from the quota if we're removing the item.
25         (WebCore::StorageMap::importItem):
26             Assume that we're adding things for the first time.
27             Count keys in the quota.
28
29 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
30
31         Reviewed by Eric Seidel.
32
33         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
34         https://bugs.webkit.org/show_bug.cgi?id=31468
35
36         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
37         by removing the direct ICU dependency and replacing it
38         with WTF functions and WebCore's own TextBreakIterator
39         abstractions.
40
41         * GNUmakefile.am:
42         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
43         * platform/text/TextBoundaries.cpp: Added.
44         (WebCore::findNextWordFromIndex):
45         (WebCore::findWordBoundary):
46         * platform/text/TextBoundariesICU.cpp: Removed.
47         * platform/text/TextBreakIterator.h:
48         * platform/text/TextBreakIteratorICU.cpp:
49         (WebCore::textBreakLast):
50         (WebCore::textBreakPrevious):
51
52 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
53
54         Reviewed by Darin Adler.
55
56         WebCore::externalRepresentation should update layout before getting render object
57         https://bugs.webkit.org/show_bug.cgi?id=31459
58
59         * rendering/RenderTreeAsText.cpp:
60         (WebCore::externalRepresentation):
61
62 2009-11-13  Adam Roben  <aroben@apple.com>
63
64         Tell FrameLoaderClient when window objects in isolated worlds are
65         cleared
66
67         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
68         window objects in isolated worlds are cleared
69
70         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
71
72         Reviewed by Dave Hyatt.
73
74         * bindings/js/JSDOMBinding.h:
75         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
76         worlds in m_worldSet to the passed-in Vector.
77
78         * bindings/js/ScriptController.cpp:
79         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
80         WebCoreJSClientData.
81         (WebCore::ScriptController::initScript): Changed to call
82         FrameLoader::dispatchDidClearWindowObjectInWorld.
83
84         * bindings/js/ScriptController.h: Added getAllWorlds.
85
86         * loader/EmptyClients.h:
87         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
88         Updated for FrameLoaderClient change.
89
90         * loader/FrameLoader.cpp:
91         (WebCore::FrameLoader::receivedFirstData):
92         (WebCore::FrameLoader::begin):
93         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
94
95         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
96         Added. Retrieves all the worlds, then calls through to
97         dispatchDidClearWindowObjectInWorld for each one.
98         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
99         dispatchWindowObjectAvailable. Calls up to the client, then, if the
100         world is the mainThreadNormalWorld(), tells the Inspector about it,
101         too.
102
103         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
104         dispatchDidClearWindowObjectInWorld. Added
105         dispatchDidClearWindowObjectsInAllWorlds.
106
107         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
108         dispatchDidClearWindowObjectForWorld.
109
110 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
111
112         Reviewed by Dimitri Glazkov.
113
114         [V8] Fix SVG context assignment for pod types.
115         https://bugs.webkit.org/show_bug.cgi?id=31497
116
117         I broke this in r50958.
118
119         Tested by svg/custom/viewport-update2.svg.
120
121         * bindings/scripts/CodeGeneratorV8.pm:
122
123 2009-11-13  Andrei Popescu  <andreip@google.com>
124
125         Reviewed by Dmitry Titov.
126
127         Bring the platform/android files inline with Android 2.0
128         https://bugs.webkit.org/show_bug.cgi?id=31423
129
130         No new tests required: these are all Android-specific files.
131
132         * platform/android/ClipboardAndroid.cpp:
133         (WebCore::ClipboardAndroid::files):
134         * platform/android/ClipboardAndroid.h:
135         * platform/android/FileChooserAndroid.cpp:
136         (WebCore::FileChooser::basenameForWidth):
137         (WebCore::fileButtonChooseFileLabel):
138         * platform/android/KeyEventAndroid.cpp:
139         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
140         * platform/android/LocalizedStringsAndroid.cpp:
141         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
142         (WebCore::contextMenuItemTagDownloadLinkToDisk):
143         (WebCore::contextMenuItemTagCopyLinkToClipboard):
144         (WebCore::contextMenuItemTagOpenImageInNewWindow):
145         (WebCore::contextMenuItemTagDownloadImageToDisk):
146         (WebCore::contextMenuItemTagCopyImageToClipboard):
147         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
148         (WebCore::contextMenuItemTagCopy):
149         (WebCore::contextMenuItemTagGoBack):
150         (WebCore::contextMenuItemTagGoForward):
151         (WebCore::contextMenuItemTagStop):
152         (WebCore::contextMenuItemTagReload):
153         (WebCore::contextMenuItemTagCut):
154         (WebCore::contextMenuItemTagPaste):
155         (WebCore::contextMenuItemTagNoGuessesFound):
156         (WebCore::contextMenuItemTagIgnoreSpelling):
157         (WebCore::contextMenuItemTagLearnSpelling):
158         (WebCore::contextMenuItemTagSearchWeb):
159         (WebCore::contextMenuItemTagLookUpInDictionary):
160         (WebCore::contextMenuItemTagOpenLink):
161         (WebCore::contextMenuItemTagIgnoreGrammar):
162         (WebCore::contextMenuItemTagSpellingMenu):
163         (WebCore::contextMenuItemTagShowSpellingPanel):
164         (WebCore::contextMenuItemTagCheckSpelling):
165         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
166         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
167         (WebCore::contextMenuItemTagFontMenu):
168         (WebCore::contextMenuItemTagBold):
169         (WebCore::contextMenuItemTagItalic):
170         (WebCore::contextMenuItemTagUnderline):
171         (WebCore::contextMenuItemTagOutline):
172         (WebCore::contextMenuItemTagWritingDirectionMenu):
173         (WebCore::contextMenuItemTagTextDirectionMenu):
174         (WebCore::contextMenuItemTagDefaultDirection):
175         (WebCore::contextMenuItemTagLeftToRight):
176         (WebCore::contextMenuItemTagRightToLeft):
177         (WebCore::mediaElementLoadingStateText):
178         (WebCore::mediaElementLiveBroadcastStateText):
179         (WebCore::searchableIndexIntroduction):
180         (WebCore::resetButtonDefaultLabel):
181         (WebCore::submitButtonDefaultLabel):
182         (WebCore::inputElementAltText):
183         * platform/android/RenderThemeAndroid.cpp:
184         (WebCore::RenderTheme::themeForPage):
185         (WebCore::RenderThemeAndroid::baselinePosition):
186         (WebCore::RenderThemeAndroid::paintButton):
187         (WebCore::adjustMenuListStyleCommon):
188         (WebCore::RenderThemeAndroid::paintCombo):
189         * platform/android/ScreenAndroid.cpp:
190         * platform/android/ScrollViewAndroid.cpp:
191         (WebCore::ScrollView::platformOffscreenContentRectangle):
192         * platform/android/TemporaryLinkStubs.cpp:
193         (JSC::Bindings::dispatchJNICall):
194         * platform/android/WidgetAndroid.cpp:
195         (WebCore::Widget::setFrameRect):
196
197 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
198
199         Reviewed by Eric Seidel.
200
201         Added macros for USERINCLUDE paths within symbian blocks
202         to guarantee inclusion of respective header files from local path
203         first (to avoid clashes with same names of header files in system include path).
204
205         * WebCore.pro:
206
207 2009-11-13  Hironori Bono  <hbono@chromium.org>
208
209         Reviewed by Oliver Hunt.
210
211         Implement composition events introduced in DOM Level 3.
212         This change adds a new IDL which defines the composition events, adds a class which
213         implements the composition events, and sends the composition events according to
214         the specification.
215         https://bugs.webkit.org/show_bug.cgi?id=26310
216
217         Test: fast/events/ime-composition-events-001.html
218
219         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
220         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
221         * WebCore.gypi: ditto.
222         * WebCore.pro: ditto
223         * WebCore.vcproj/WebCore.vcproj: ditto.
224         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
225         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
226         * bindings/js/JSEventCustom.cpp:
227         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
228         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
229         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
230         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
231         (WebCore::V8DOMWrapper::convertEventToV8Object):
232         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
233         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
234         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
235         (WebCore::CompositionEvent::CompositionEvent):
236         (WebCore::CompositionEvent::~CompositionEvent):
237         (WebCore::CompositionEvent::initCompositionEvent):
238         (WebCore::CompositionEvent::isCompositionEvent):
239         * dom/CompositionEvent.h: Declares the CompositionEvent class.
240         (WebCore::CompositionEvent::create):
241         (WebCore::CompositionEvent::data):
242         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
243         * dom/Event.cpp:
244         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
245         * dom/Event.h:
246         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
247         * editing/Editor.cpp:
248         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
249         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
250
251 2009-11-13  Jens Alfke  <snej@chromium.org>
252
253         Reviewed by Dimitri Glazkov.
254
255         Fix a link error in unofficial GCC 4.4 builds on Linux.
256         https://bugs.webkit.org/show_bug.cgi?id=31477
257
258         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
259
260 2009-11-13  Eric Seidel  <eric@webkit.org>
261
262         No review, build fix only.
263
264         Fix Debug build after http://trac.webkit.org/changeset/50960.
265
266         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
267         https://bugs.webkit.org/show_bug.cgi?id=31213
268
269         * rendering/CounterNode.cpp:
270         (WebCore::showTreeAndMark):
271         * rendering/RenderCounter.cpp:
272         (WebCore::destroyCounterNodeChildren):
273
274 2009-11-13  Dirk Schulze  <krit@webkit.org>
275
276         Reviewed by Gustavo Noronha.
277
278         [CAIRO] shadow support for Canvas and SVG
279         [https://bugs.webkit.org/show_bug.cgi?id=30960]
280
281         We currently fill a path with solid color instead of filling
282         a clipping path. This causes problems on some composite operators,
283         since Cairo modifies the area outside the path.
284         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
285
286         Thanks to Benjamin Otte for tracking the bug down.
287
288         * platform/graphics/cairo/GraphicsContextCairo.cpp:
289         (WebCore::setPlatformFill):
290
291 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
292
293         Reviewed by Dimitri Glazkov.
294
295         Adding Chromium's DatabaseTracker implementation.
296
297         https://bugs.webkit.org/show_bug.cgi?id=31440
298
299         * WebCore.gyp/WebCore.gyp:
300         * WebCore.gypi:
301         * storage/DatabaseTracker.h:
302         * storage/chromium/DatabaseTrackerChromium.cpp:
303         (WebCore::DatabaseTracker::fullPathForDatabase):
304         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
305         * storage/chromium/QuotaTracker.cpp:
306         (WebCore::QuotaTracker::updateDatabaseSize):
307         * storage/chromium/QuotaTracker.h:
308
309 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
310
311         Reviewed by Darin Adler.
312
313         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
314         https://bugs.webkit.org/show_bug.cgi?id=31213
315         Added tree navigation methods that permit full implementation of CSS2.1
316         counter feature without using recursion proportional to the counter
317         tree depth.
318         No new tests because I did not find any bug that is fixed by this
319         commit yet, this just reduces the size of the patch for 11031 and
320         helps respond to some concerns regarding that patch.
321
322         * rendering/CounterNode.cpp:
323         (WebCore::CounterNode::CounterNode):
324
325         (WebCore::CounterNode::nextInPreOrderAfterChildren):
326         (WebCore::CounterNode::nextInPreOrder):
327         Added to support non-recursive tree traversal necessary for
328         efficient full implementation of CSS2.1 counters.
329
330         (WebCore::CounterNode::lastDescendant):
331         (WebCore::CounterNode::previousInPreOrder):
332         Moved this methods such that they occupy a place similar to that of
333         identically named methods on the render tree. This allows for their
334         broader use needed in full implementation of CSS2.1 counters.
335
336         (WebCore::CounterNode::resetRenderer):
337         (WebCore::CounterNode::resetRenderers):
338         (WebCore::CounterNode::recount):
339         (WebCore::CounterNode::insertAfter):
340         (WebCore::CounterNode::removeChild):
341         Changed such that insertion/removal of a counter, triggers not only
342         recalculation of PrefixWidths, but also reassesment of values in
343         counter nodes. This is the basis full implementation of CSS2.1
344         counters. It does not change current behavior by much because of
345         changes needed to the recalculation algorithm, but those are comming
346         in the patch for 11031.
347         (WebCore::showTreeAndMark):
348         * rendering/CounterNode.h:
349         * rendering/RenderCounter.cpp:
350         (WebCore::counter):
351         Only changed argument type to prepare for implementation of Darin
352         Adler's recommendation for the patch to 11031.
353
354         (WebCore::RenderCounter::invalidate):
355         (WebCore::destroyCounterNodeChildren):
356         (WebCore::RenderCounter::destroyCounterNodes):
357         * rendering/RenderCounter.h:
358         * rendering/RenderObjectChildList.cpp:
359         (WebCore::invalidateCountersInContainer):
360         (WebCore::RenderObjectChildList::invalidateCounters):
361         * rendering/RenderObjectChildList.h:
362         Added the ability to restrict invalidation to counters with a given
363         identifier.
364         Also invalidated counters that are on the child container itself
365         which were missed by the previous algorithm, but were a valid case.
366
367 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
368
369         Reviewed by Dimitri Glazkov.
370
371         [V8] Protect SVG animated properties from destruction in bindings.
372         https://bugs.webkit.org/show_bug.cgi?id=31474
373
374         See http://crbug.com/26719.
375
376         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
377         under Valgrind.
378
379         Made sure we keep a reference to SVG properties while setting a
380         context:
381         * bindings/scripts/CodeGeneratorV8.pm:
382         * bindings/v8/V8Proxy.h:
383         (WebCore::V8Proxy::withSVGContext):
384
385 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
386
387         Reviewed by Alexey Proskuryakov.
388
389         [CAIRO] shadow support for Canvas and SVG.
390         [https://bugs.webkit.org/show_bug.cgi?id=30960]
391
392         Incorporate Benjamin Otte's recommendations to avoid
393         a buffer overrun, and small performance improvement.
394
395         * platform/graphics/cairo/GraphicsContextCairo.cpp:
396         (WebCore::copyContextProperties): Correctly size output
397          storage for cairo_get_dash to avoid buffer overrun.
398         (WebCore::drawPathShadow): Prefer cairo_fill_extents
399          to slower cairo_stroke_extents when not drawing shadows.
400
401 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
402
403         Reviewed by Dimitri Glazkov.
404
405         Do not register Chromium's HTML5 DB VFS as the default
406         VFS. Otherwise, other sqlite DB users in the same process will
407         stop working.
408
409         https://bugs.webkit.org/show_bug.cgi?id=31462
410
411         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
412         (WebCore::SQLiteFileSystem::openDatabase):
413         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
414         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
415         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
416         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
417
418 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
419
420         Windows build fix
421
422         * platform/network/cf/SocketStreamHandleCFNet.cpp:
423         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
424         avoiding a sign mismatch warning.
425
426 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
427
428         Release build fix.
429
430         * platform/network/cf/SocketStreamHandleCFNet.cpp:
431         (WebCore::SocketStreamHandle::readStreamCallback):
432         (WebCore::SocketStreamHandle::writeStreamCallback):
433         Use ASSERT_UNUSED for unused stream parameter.
434
435 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
436
437         Reviewed by Darin Adler.
438
439         https://bugs.webkit.org/show_bug.cgi?id=31441
440         Implement SocketStreamHandleCFNet
441
442         Existing WebSocket tests now pass on Mac. No proxy support yet.
443
444         * platform/network/SocketStreamHandleClient.h:
445         * platform/network/cf/SocketStreamHandle.h:
446         (WebCore::SocketStreamHandle::shouldUseSSL):
447         (WebCore::SocketStreamHandle::refAuthenticationClient):
448         (WebCore::SocketStreamHandle::derefAuthenticationClient):
449         (WebCore::SocketStreamHandle::):
450         * platform/network/cf/SocketStreamHandleCFNet.cpp:
451         (WebCore::SocketStreamHandle::SocketStreamHandle):
452         (WebCore::SocketStreamHandle::chooseProxy):
453         (WebCore::SocketStreamHandle::createStreams):
454         (WebCore::SocketStreamHandle::copyCFStreamDescription):
455         (WebCore::SocketStreamHandle::readStreamCallback):
456         (WebCore::SocketStreamHandle::writeStreamCallback):
457         (WebCore::SocketStreamHandle::~SocketStreamHandle):
458         (WebCore::SocketStreamHandle::platformSend):
459         (WebCore::SocketStreamHandle::platformClose):
460         (WebCore::SocketStreamHandle::receivedCredential):
461         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
462         (WebCore::SocketStreamHandle::receivedCancellation):
463
464 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
465
466         Reviewed by Timothy Hatcher.
467
468         Web Inspector: preload status bar button glyphs
469         in order to prevent them from flickering (take 2).
470
471         https://bugs.webkit.org/show_bug.cgi?id=31439
472
473         * inspector/front-end/inspector.js:
474         (preloadImages):
475
476 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
477
478         Reviewed by Adam Barth.
479
480         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
481         Rolling back r50890.
482
483         https://bugs.webkit.org/show_bug.cgi?id=31467
484
485         * bindings/v8/V8Proxy.cpp:
486         (WebCore::V8Proxy::canAccessPrivate):
487
488 2009-11-13  Dirk Schulze  <krit@webkit.org>
489
490         Reviewed by Gustavo Noronha.
491
492         [CAIRO] shadow support for Canvas and SVG
493         [https://bugs.webkit.org/show_bug.cgi?id=30960]
494         
495         This is the fix of a regression, caused by the shadow patch
496         from the bug above. Reinserted the save and restore calls
497         that were accidently removed by the previous patch.
498
499         * platform/graphics/cairo/GraphicsContextCairo.cpp:
500         (WebCore::setPlatformFill):
501         (WebCore::setPlatformStroke):
502
503 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
504
505         Not reviewed. Reverting r50908 since it makes inspector tests
506         time out.
507
508         https://bugs.webkit.org/show_bug.cgi?id=31439
509
510         * inspector/front-end/inspector.js:
511
512 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
513
514         Reviewed by Timothy Hatcher.
515
516         Enable 'console.profile()' and 'console.profileEnd()'
517         regardless of JAVASCRIPT_DEBUGGER.
518
519         https://bugs.webkit.org/show_bug.cgi?id=31293
520
521         * WebCore.gypi:
522         * bindings/js/JSConsoleCustom.cpp:
523         (WebCore::JSConsole::profile):
524         (WebCore::JSConsole::profileEnd):
525         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
526         (WebCore::CALLBACK_FUNC_DECL):
527         * bindings/v8/custom/V8CustomBinding.h:
528         * page/Console.idl:
529
530 2009-11-12  David Levin  <levin@chromium.org>
531
532         Reviewed by NOBODY.
533
534         Chromium build fix.
535
536         * bindings/v8/ScriptController.h:
537         (WebCore::ScriptController::evaluateInWorld): Add a dummy
538          method which isn't called in chromium to make things compile.
539
540 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
541
542         Reviewed by Adam Barth.
543         
544         The document-open.html test was flaky at times. The test invokes the layout test plugin
545         which in its destroy stream handler opens a new document. This basically tears down the
546         stream and the associated plugin instance, which causes a crash when the plugin stream
547         dereferences an invalid m_client pointer which points to the PluginView instance which
548         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
549         and check for the same.
550        
551         https://bugs.webkit.org/show_bug.cgi?id=31067
552
553         * plugins/PluginStream.cpp:
554         (WebCore::PluginStream::stop):
555         (WebCore::PluginStream::destroyStream):
556
557 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
558
559         Reviewed by Dimitri Glazkov.
560
561         Renaming some parameters passed to DB-related methods to better
562         indicate their purpose.
563
564         https://bugs.webkit.org/show_bug.cgi?id=31449
565
566         * platform/chromium/ChromiumBridge.h:
567
568 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
569
570         Reviewed by Dan Bernstein.
571
572         Transformed reflected elements are clipped inside element with opacity
573         https://bugs.webkit.org/show_bug.cgi?id=30957
574         
575         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
576         each clip rect into painting space before taking the unions. This, however, did not work
577         correctly with combinations of reflections and transforms. Fixed by unioning the
578         clipRect and mapping through transforms along the way.
579         
580         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
581         where the transparency layers are.
582
583         Test: fast/reflections/opacity-reflection-transform.html
584
585         * rendering/RenderLayer.cpp:
586         (WebCore::expandClipRectForDescendantsAndReflection):
587         (WebCore::transparencyClipBox):
588         (WebCore::RenderLayer::beginTransparencyLayers):
589
590 2009-11-12  Adam Barth  <abarth@webkit.org>
591
592         Reviewed by Darin Fisher.
593
594         Improve SecurityOrigin::toString comment
595         https://bugs.webkit.org/show_bug.cgi?id=31041
596
597         * page/SecurityOrigin.h:
598
599 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
600
601         Reviewed by Darin Adler.
602
603         externalRepresentation should take Frame as the argument
604         https://bugs.webkit.org/show_bug.cgi?id=31393
605
606         No new tests as this is just a refactoring.
607
608         * WebCore.base.exp:
609         * rendering/RenderTreeAsText.cpp:
610         (WebCore::externalRepresentation):
611         * rendering/RenderTreeAsText.h:
612
613 2009-11-12  Ben Murdoch  <benm@google.com>
614
615         Reviewed by Dimitri Glazkov.
616
617         [Android] The Android specific files in page/Android are out of date.
618         https://bugs.webkit.org/show_bug.cgi?id=31437
619
620         No tests required.
621
622         * page/android/DragControllerAndroid.cpp:
623         (WebCore::DragController::dragOperation): Added.
624         (WebCore::DragController::cleanupAfterSystemDrag):
625         * page/android/EventHandlerAndroid.cpp:
626         (WebCore::EventHandler::accessKeyModifiers): Added.
627         * page/android/InspectorControllerAndroid.cpp: Removed.
628
629 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
630
631         Reviewed by Simon Fraser.
632
633         [CAIRO] shadow support for Canvas and SVG.
634         [https://bugs.webkit.org/show_bug.cgi?id=30960]
635
636         Implement Canvas/SVG shadow support for Cairo.  This patch
637         uses the filter code from SVG Filters.  That means that it is
638         necessary to activate filters to see the shadows.
639
640         Test: fast/canvas/canvas-shadow.html
641
642         * GNUmakefile.am:
643         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
644         * platform/graphics/GraphicsContext.h:
645         * platform/graphics/cairo/GraphicsContextCairo.cpp:
646         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
647         (WebCore::setPlatformFill):
648         (WebCore::setPlatformStroke):
649         (WebCore::copyContextProperties):
650         (WebCore::drawPathShadow):
651         (WebCore::GraphicsContext::fillPath):
652         (WebCore::GraphicsContext::strokePath):
653         (WebCore::GraphicsContext::drawPath):
654         (WebCore::GraphicsContext::setPlatformShadow):
655         (WebCore::GraphicsContext::createPlatformShadow):
656         * platform/graphics/cairo/ImageCairo.cpp:
657         (WebCore::BitmapImage::draw): Add filter effect.
658         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
659         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
660         * platform/graphics/filters/ImageBufferFilter.h: Added.
661         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
662         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
663
664 2009-11-12  Dmitry Titov  <dimich@chromium.org>
665
666         Reviewed by Alexey Proskuryakov.
667
668         Add postTaskToMainThread to ScriptExecutionContext.
669         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
670         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
671         contexts that live on the main thread.
672         https://bugs.webkit.org/show_bug.cgi?id=31427
673
674         No new tests - simply moving the code.
675
676         * dom/Document.cpp:
677         (WebCore::Document::postTask):
678         * dom/ScriptExecutionContext.cpp:
679         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
680         (WebCore::ScriptExecutionContextTaskTimer::fired):
681         (WebCore::PerformTaskData::PerformTaskData):
682         (WebCore::PerformTaskData::performTask):
683         (WebCore::ScriptExecutionContext::postTaskToMainThread):
684         * dom/ScriptExecutionContext.h:
685
686 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
687
688         Reviewed by Darin Adler.
689
690         Fix crash when removing compositing layers when GC is enabled
691         https://bugs.webkit.org/show_bug.cgi?id=31429
692
693         Workaround <rdar://problem/7390716> by special-casing the removal
694         of all sublayers when GC is enabled.
695
696         * platform/graphics/mac/GraphicsLayerCA.mm:
697         (WebCore::safeSetSublayers):
698         (WebCore::GraphicsLayerCA::updateSublayerList):
699         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
700
701 2009-11-12  Jens Alfke  <snej@chromium.org>
702
703         Reviewed by Dimitri Glazkov.
704
705         The last of the V8 binding optimizations.
706         - Replace string-valued element accessors with a shared getter/setter function.
707         - Change error handling flow of control to avoid extra branches and function calls.
708         https://bugs.webkit.org/show_bug.cgi?id=31443
709         
710         * bindings/scripts/CodeGeneratorV8.pm:
711         * bindings/v8/V8Binding.cpp:
712         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
713         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
714         * bindings/v8/V8Binding.h:
715
716 2009-11-12  Sam Weinig  <sam@webkit.org>
717
718         Reviewed by Oliver Hunt.
719
720         Fix for <rdar://problem/7267951>
721         Canvas methods should reject uses of NaN and Infinity.
722
723         Test: fast/canvas/canvas-with-illegal-args.html
724
725         * html/canvas/CanvasRenderingContext2D.cpp:
726         (WebCore::CanvasRenderingContext2D::scale):
727         (WebCore::CanvasRenderingContext2D::rotate):
728         (WebCore::CanvasRenderingContext2D::translate):
729         (WebCore::CanvasRenderingContext2D::transform):
730         (WebCore::CanvasRenderingContext2D::setTransform):
731
732 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
733
734         Reviewed by Timothy Hatcher.
735
736         Web Inspector: profile timeline panel, fix obvious problems.
737
738         https://bugs.webkit.org/show_bug.cgi?id=31432
739
740         * inspector/front-end/AbstractTimelinePanel.js:
741         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
742         * inspector/front-end/TimelinePanel.js:
743         (WebInspector.TimelinePanel.prototype._setWindowPosition):
744         (WebInspector.TimelineCalculator):
745         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
746         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
747         (WebInspector.TimelineCalculator.prototype.reset):
748         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
749         (WebInspector.TimelineCalculator.prototype.formatValue):
750         (WebInspector.TimelineGraph):
751         (WebInspector.TimelineGraph.prototype.refresh):
752         * inspector/front-end/utilities.js:
753         (Element.prototype.hasStyleClass):
754
755 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
756
757         Reviewed by Timothy Hatcher.
758
759         Web Inspector: preload status bar button glyphs
760         in order to prevent them from flickering.
761
762         https://bugs.webkit.org/show_bug.cgi?id=31439
763
764         * inspector/front-end/inspector.js:
765         (preloadImages):
766
767 2009-11-12  Adam Roben  <aroben@apple.com>
768
769         Replace worldIDs with world objects
770
771         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
772         user scripts/stylesheets and isolated worlds
773
774         Reviewed by Sam Weinig.
775
776         Covered by existing tests.
777
778         * WebCore.base.exp: Update exported symbols to match what now exists
779         and is needed by WebKit.
780
781         * bindings/js/ScheduledAction.cpp:
782         (WebCore::ScheduledAction::execute): Updated for function rename.
783
784         * bindings/js/ScriptController.cpp: Removed code that dealt with
785         worldIDs.
786         (WebCore::ScriptController::createWorld): Added. Returns a new world
787         suitable for use on the main thread.
788         (WebCore::ScriptController::executeScriptInWorld): Renamed from
789         executeScriptInIsolatedWorld, since this works just fine with a
790         "normal" world.
791
792         * bindings/js/ScriptController.h: Added createWorld, removed functions
793         that took worldIDs, renamed executeScriptInIsolatedWorld to
794         executeScriptInWorld.
795
796         * page/Frame.cpp:
797         (WebCore::Frame::injectUserScripts):
798         (WebCore::Frame::injectUserScriptsForWorld):
799         Updated for changes to UserScriptMap and ScriptController.
800
801         * page/Frame.h: Changed injectUserScriptsForWorld to take a
802         DOMWrapperWorld* instead of a worldID.
803
804         * page/PageGroup.cpp:
805         (WebCore::PageGroup::addUserScriptToWorld):
806         (WebCore::PageGroup::addUserStyleSheetToWorld):
807         (WebCore::PageGroup::removeUserScriptFromWorld):
808         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
809         (WebCore::PageGroup::removeUserScriptsFromWorld):
810         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
811         * page/PageGroup.h:
812         Changed these functions to take a DOMWrapperWorld* instead of a
813         worldID. Also updated for changes to UserScript and UserStyleSheet.
814
815         * page/UserScript.h:
816         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
817         never used.
818
819         * page/UserScriptTypes.h:
820         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
821         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
822         worldID as their key type.
823
824
825 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
826
827         Reviewed by Tim Hatcher.
828
829         Fixes <http://webkit.org/b/31260>.
830         Web Inspector: Main Resources Other than HTML are mis-detected.
831         
832         Even if the resource is a main resource, look at its CachedResource type, 
833         because it might be an image, stylesheet, or JavaScript file, and we
834         want to show them all correctly.
835
836         * inspector/InspectorResource.cpp:
837         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
838         (WebCore::InspectorResource::type): 
839         * inspector/InspectorResource.h:
840
841 2009-11-12  Jens Alfke  <snej@chromium.org>
842
843         Reviewed by Dimitri Glazkov.
844
845         Table-driven setup for V8 binding template callback functions. 100k in code savings.
846         https://bugs.webkit.org/show_bug.cgi?id=31420
847
848         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
849             to call configureTemplate().
850         * bindings/v8/V8Binding.cpp:
851         (WebCore::configureTemplate):  New function; does all the standard configuration work.
852         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
853         * bindings/v8/V8Binding.h:
854         * bindings/v8/V8Proxy.cpp:
855         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
856         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
857         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
858         * bindings/v8/V8Proxy.h:
859
860 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
861
862         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
863
864         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
865
866 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
867
868         Reviewed by Dan Bernstein.
869
870         <rdar://problem/7388969> Add DOM API for fullscreen video
871         
872         DOM API for fullscreen <video>.
873
874         Tests: media/media-fullscreen-inline.html
875                media/media-fullscreen-not-in-document.html
876
877         * dom/EventNames.h:
878             Add webkitbeginfullscreen and webkitendfullscreen.
879
880         * html/HTMLAttributeNames.in:
881             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
882
883         * html/HTMLMediaElement.cpp:
884         (WebCore::HTMLMediaElement::parseMappedAttribute):
885             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
886         (WebCore::HTMLMediaElement::enterFullscreen):
887             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
888             actually do enter fullscreen.
889         (WebCore::HTMLMediaElement::exitFullscreen):
890             Schedule webkitendfullscreenEvent event.
891         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
892         (WebCore::HTMLMediaElement::webkitExitFullScreen):
893         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
894         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
895             New, access to fullscreen properties and methods.
896
897         * html/HTMLMediaElement.h:
898         * html/HTMLMediaElement.idl:
899             Declare methods needed for fullscreen API.
900
901         * html/HTMLVideoElement.cpp:
902         (WebCore::HTMLVideoElement::supportsFullscreen):
903             Return false if a movie does not have video.
904
905         * page/DOMWindow.h:
906             Add webkitbeginfullscreen and webkitendfullscreen.
907
908 2009-11-12  Adam Barth  <abarth@webkit.org>
909
910         Reviewed by Dimitri Glazkov.
911
912         [Chromium] Sify compose button alerts error
913         https://bugs.webkit.org/show_bug.cgi?id=31394
914
915         Test: http/tests/security/calling-versus-current.html
916
917         We're supposed to use the calling context for security checks.  In JSC
918         land, this is the lexicalGlobalObject.
919
920         * bindings/v8/V8Proxy.cpp:
921         (WebCore::V8Proxy::canAccessPrivate):
922
923 2009-11-12  Daniel Bates  <dbates@webkit.org>
924
925         Reviewed by Darin Adler.
926
927         https://bugs.webkit.org/show_bug.cgi?id=30291
928
929         Fixes an issue where the returned drop effect is incorrect when
930         effectAllowed == "uninitialized".
931
932         According to section 7.9.2 of the HTML 5 spec.
933         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
934         when effectAllowed = "uninitialized" the resulting dropEffect should be the
935         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
936         other case.
937         
938         No test cases are included because we have an existing test case from
939         bug #24731.
940
941         * dom/Clipboard.cpp:
942         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
943
944 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
945
946         Reviewed by Timothy Hatcher.
947
948         Web Inspector: Do not highlight node on refresh.
949
950         https://bugs.webkit.org/show_bug.cgi?id=31419
951
952         * inspector/front-end/ElementsPanel.js:
953         (WebInspector.ElementsPanel.prototype.reset):
954
955 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
956
957         Reviewed by Timothy Hatcher.
958
959         Web Inspector: Minor timeline fixes.
960
961         https://bugs.webkit.org/show_bug.cgi?id=31417
962
963         * inspector/front-end/TimelinePanel.js:
964         (WebInspector.TimelinePanel.prototype._getRecordDetails):
965         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
966         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
967         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
968
969 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
970
971         SnowLeopard build fix.
972
973         Renamed initWithClient to initWithAuthenticationClient.
974
975         * platform/network/mac/AuthenticationMac.mm:
976         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
977         (WebCore::AuthenticationChallenge::setAuthenticationClient):
978
979 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
980
981         Reviewed by Darin Adler.
982
983         ARIA: add alert type roles
984         https://bugs.webkit.org/show_bug.cgi?id=31392
985
986         Test: platform/mac/accessibility/aria-alerts.html
987
988         * accessibility/AccessibilityObject.h:
989         * accessibility/AccessibilityRenderObject.cpp:
990         * accessibility/mac/AccessibilityObjectWrapper.mm:
991
992 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
993
994         Reviewed by Darin Adler.
995
996         https://bugs.webkit.org/show_bug.cgi?id=31386
997         Make Mac AuthenticationChallenge usable from cross-platform code
998
999         No change in behavior, so no tests.
1000
1001         * platform/network/ResourceHandle.cpp:
1002         (WebCore::ResourceHandle::clearAuthentication):
1003         * platform/network/ResourceHandleInternal.h:
1004         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1005         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
1006         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
1007         is identical.
1008
1009         * platform/network/cf/AuthenticationChallenge.h:
1010         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
1011         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
1012
1013         * platform/network/cf/ResourceHandleCFNet.cpp:
1014         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
1015         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
1016         be already set.
1017
1018         * platform/network/mac/AuthenticationChallenge.h:
1019         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
1020         best of my understanding.
1021         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
1022         confusion with "mac" and "web" challenges in ResourceHandleInternal.
1023
1024         * platform/network/mac/AuthenticationMac.mm:
1025         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
1026         making it possible to use the latter with NSURLAuthenticationChallenge.
1027         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
1028         m_nsChallenge renaming.
1029         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
1030         set it as sender (or unset, if client is null).
1031
1032         * platform/network/mac/ResourceHandleMac.mm:
1033         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
1034         authentication challenge sender.
1035         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
1036         authentication sheet.
1037         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
1038         using the new setAuthenticationClient() method.
1039         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
1040         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
1041         the original Mac one, not the one we created for use with authentication sheet. I don't
1042         know when a connection would cancel authentication in practice, so I haven't tested this.
1043
1044 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1045
1046         Reviewed by Timothy Hatcher.
1047
1048         Web Inspector: breakpoint sidebar entries should allow click over entire list item
1049         https://bugs.webkit.org/show_bug.cgi?id=31411
1050
1051         No new tests; no new functionality, small usability change. 
1052
1053         * inspector/front-end/BreakpointsSidebarPane.js:
1054         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
1055         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
1056
1057 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1058
1059         Reviewed by Timothy Hatcher.
1060
1061         Web Inspector: breakpoints in named evals are not restored after a reload
1062         https://bugs.webkit.org/show_bug.cgi?id=31375
1063
1064         Manual test added
1065
1066         * inspector/front-end/ScriptsPanel.js:
1067         (WebInspector.ScriptsPanel.prototype.addScript):
1068         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
1069
1070 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
1071
1072         Reviewed by Kenneth Rohde Christiansen.
1073
1074         Custom printing shrink factors
1075         https://bugs.webkit.org/show_bug.cgi?id=29042
1076
1077         This reverts commit r49769. The public API for this needs to be reviewed
1078         before its inclusion in Qt.
1079
1080         * page/PrintContext.cpp:
1081         (WebCore::PrintContext::begin):
1082         * page/Settings.cpp:
1083         (WebCore::Settings::Settings):
1084         * page/Settings.h:
1085
1086 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
1087
1088         Reviewed by Pavel Feldman.
1089
1090         Web Inspector: Resource errors/warnings not shown in the Resource tree.
1091
1092         Error/Warning bubbles are not displayed next to the resource in the 
1093         Resources panel if those occur before the resource is attached to the tree.
1094         https://bugs.webkit.org/show_bug.cgi?id=31404
1095
1096         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
1097
1098         * inspector/front-end/AbstractTimelinePanel.js:
1099         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
1100         * inspector/front-end/ResourcesPanel.js:
1101         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
1102
1103 2009-11-12  Philippe Normand  <pnormand@igalia.com>
1104
1105         Reviewed by Jan Alonzo.
1106
1107         https://bugs.webkit.org/show_bug.cgi?id=31047
1108         [GTK] Failing test media/video-played-ranges-1.html
1109
1110         Follow-up of r50726, don't block the UI thread when calling
1111         gst_element_get_state(). Also fixed a compilation warning and some
1112         static casts.
1113
1114         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1115         (WebCore::playbackPosition):
1116         (WebCore::MediaPlayerPrivate::seek):
1117         (WebCore::MediaPlayerPrivate::setRate):
1118
1119 2009-11-12  Philippe Normand  <pnormand@igalia.com>
1120
1121         Reviewed by Jan Alonzo.
1122
1123         https://bugs.webkit.org/show_bug.cgi?id=31047
1124         [GTK] Failing test media/video-played-ranges-1.html
1125
1126         don't pause pipeline if already paused, same for play()
1127
1128         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1129         (WebCore::MediaPlayerPrivate::play):
1130         (WebCore::MediaPlayerPrivate::pause):
1131
1132 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
1133
1134         Reviewed by David Levin.
1135
1136         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
1137         Chromium too.
1138         https://bugs.webkit.org/show_bug.cgi?id=31292
1139
1140         No new tests. (Corresponding test for Gtk+ is
1141         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
1142
1143         * page/EventHandler.cpp:
1144         * page/chromium/EventHandlerChromium.cpp:
1145
1146 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
1147
1148         Reviewed by Eric Seidel.
1149
1150         Prevent text inside a multi-column block from being split into columns.
1151         
1152         If the tentative height of a multi-column block was too small, we need to
1153         expand the block height and try to layout again, in order to prevent text
1154         from being split into different columns.
1155
1156         CSS Multicolumn text is split awkwardly
1157         https://bugs.webkit.org/show_bug.cgi?id=22249
1158
1159         Test: fast/multicol/single-line.html
1160
1161         * rendering/RenderBlock.cpp:
1162         (WebCore::RenderBlock::layoutColumns):
1163         * rendering/RenderBlock.h:
1164         * rendering/RenderLineBoxList.cpp:
1165         (WebCore::RenderLineBoxList::paint):
1166         * rendering/RenderView.h:
1167         (WebCore::RenderView::setTruncatedAt):
1168         (WebCore::RenderView::setMinimumColumnHeight):
1169         (WebCore::RenderView::minimumColumnHeight):
1170
1171 2009-11-11  Kent Tamura  <tkent@chromium.org>
1172
1173         Reviewed by Darin Adler.
1174
1175         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
1176         https://bugs.webkit.org/show_bug.cgi?id=31195
1177
1178         Test: fast/forms/input-file-re-render.html
1179
1180         * rendering/RenderFileUploadControl.cpp:
1181         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1182
1183 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
1184
1185         Reviewed by Dimitri Glazkov.
1186
1187         Fixing Chromium's POSIX VFS implementation, by adding the required
1188         "used file descriptors" logic.
1189
1190         https://bugs.webkit.org/show_bug.cgi?id=31275
1191
1192         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
1193
1194 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1195
1196         Reviewed by Oliver Hunt.
1197
1198         need to implement aria tree roles
1199         https://bugs.webkit.org/show_bug.cgi?id=31284
1200
1201         Tests: platform/mac/accessibility/aria-multiselectable.html
1202                platform/mac/accessibility/aria-tree.html
1203
1204         * accessibility/AccessibilityList.cpp:
1205         (WebCore::AccessibilityList::accessibilityIsIgnored):
1206         * accessibility/AccessibilityObject.cpp:
1207         (WebCore::AccessibilityObject::ariaTreeRows):
1208         (WebCore::AccessibilityObject::ariaTreeItemContent):
1209         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
1210         * accessibility/AccessibilityObject.h:
1211         (WebCore::):
1212         (WebCore::AccessibilityObject::isTree):
1213         (WebCore::AccessibilityObject::isTreeItem):
1214         (WebCore::AccessibilityObject::setIsExpanded):
1215         (WebCore::AccessibilityObject::canSetExpandedAttribute):
1216         (WebCore::AccessibilityObject::hierarchicalLevel):
1217         (WebCore::AccessibilityObject::setSelectedRows):
1218         (WebCore::AccessibilityObject::performDefaultAction):
1219         * accessibility/AccessibilityRenderObject.cpp:
1220         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
1221         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1222         (WebCore::AccessibilityRenderObject::isExpanded):
1223         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
1224         (WebCore::AccessibilityRenderObject::elementAttributeValue):
1225         (WebCore::AccessibilityRenderObject::setIsExpanded):
1226         (WebCore::AccessibilityRenderObject::isSelected):
1227         (WebCore::AccessibilityRenderObject::setSelected):
1228         (WebCore::AccessibilityRenderObject::setSelectedRows):
1229         (WebCore::createARIARoleMap):
1230         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
1231         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1232         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
1233         (WebCore::AccessibilityRenderObject::selectedChildren):
1234         * accessibility/AccessibilityRenderObject.h:
1235         * accessibility/mac/AccessibilityObjectMac.mm:
1236         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1237         * accessibility/mac/AccessibilityObjectWrapper.mm:
1238         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1239         (RoleEntry::):
1240         (-[AccessibilityObjectWrapper subrole]):
1241         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1242         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1243         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
1244         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1245         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1246         * html/HTMLAttributeNames.in:
1247
1248 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1249
1250         Build fix after @r50760 with ENABLE_FILTERS.
1251
1252         * platform/graphics/filters/SourceAlpha.cpp:
1253         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
1254         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
1255           to fillRect.
1256
1257 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
1258
1259         Reviewed by Alexey Proskuryakov.
1260
1261         Fix WebSocket frame parser of frame_type with high-order bit set.
1262         https://bugs.webkit.org/show_bug.cgi?id=30668
1263
1264         If buffer is smaller than frame's length, it should break the loop
1265         instead of reading next byte.
1266
1267         Tests: websocket/tests/frame-length-longer-than-buffer.html
1268                websocket/tests/frame-length-skip.html
1269
1270         * websockets/WebSocketChannel.cpp:
1271         (WebCore::WebSocketChannel::didReceiveData):
1272
1273 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
1274
1275         Reviewed by Adam Barth.
1276
1277         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
1278         https://bugs.webkit.org/show_bug.cgi?id=31345
1279
1280         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
1281
1282         * platform/graphics/chromium/FontCustomPlatformData.cpp:
1283         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
1284         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
1285         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
1286
1287 2009-11-11  Beth Dakin  <bdakin@apple.com>
1288
1289         Build fix. No review needed.
1290
1291         * platform/graphics/gtk/FontGtk.cpp:
1292         (WebCore::Font::drawComplexText):
1293
1294 2009-11-11  Beth Dakin  <bdakin@apple.com>
1295
1296         Build fix. No review needed.
1297
1298         * platform/graphics/cairo/FontCairo.cpp:
1299         (WebCore::Font::drawGlyphs):
1300
1301 2009-11-11  Beth Dakin  <bdakin@apple.com>
1302
1303         Windows build fix. No review needed. 
1304
1305         * platform/graphics/win/FontCGWin.cpp:
1306         (WebCore::Font::drawGlyphs):
1307
1308 2009-11-11  Beth Dakin  <bdakin@apple.com>
1309
1310         Reviewed by Simon Fraser.
1311
1312         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
1313         Make -webkit-color-correction work with shadows
1314
1315         From canvas, just send DeviceColorSpace to setShadow() for now. 
1316         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
1317         * html/canvas/CanvasRenderingContext2D.cpp:
1318         (WebCore::CanvasRenderingContext2D::setShadow):
1319         (WebCore::CanvasRenderingContext2D::applyShadow):
1320
1321         setShadow() and setPlatformShadow() now take a ColorSpace.
1322         * platform/graphics/GraphicsContext.cpp:
1323         (WebCore::GraphicsContext::setShadow):
1324         * platform/graphics/GraphicsContext.h:
1325         * platform/graphics/cg/GraphicsContextCG.cpp:
1326         (WebCore::createCGColorWithColorSpace): New helper to create a 
1327         color in a ColorSpace.
1328         (WebCore::setCGFillColor): Call new helper.
1329         (WebCore::setCGStrokeColor): Call new helper.
1330         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
1331         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1332         (WebCore::GraphicsContext::setPlatformShadow):
1333
1334         Send appropriate ColorSpace to setShadow().
1335         * platform/graphics/mac/FontMac.mm:
1336         (WebCore::Font::drawGlyphs):
1337         * rendering/EllipsisBox.cpp:
1338         (WebCore::EllipsisBox::paint):
1339         * rendering/InlineFlowBox.cpp:
1340         (WebCore::InlineFlowBox::paintTextDecorations):
1341         * rendering/InlineTextBox.cpp:
1342         (WebCore::paintTextWithShadows):
1343         (WebCore::InlineTextBox::paintDecoration):
1344         * rendering/RenderBoxModelObject.cpp:
1345         (WebCore::RenderBoxModelObject::paintBoxShadow):
1346         * rendering/SVGInlineTextBox.cpp:
1347         (WebCore::SVGInlineTextBox::paintCharacters):
1348         * rendering/SVGRenderSupport.cpp:
1349         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
1350
1351         Attempt to keep ports building.
1352         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1353         (WebCore::GraphicsContext::setPlatformShadow):
1354         * platform/graphics/qt/GraphicsContextQt.cpp:
1355         (WebCore::GraphicsContext::setPlatformShadow):
1356         * platform/graphics/skia/GraphicsContextSkia.cpp:
1357         (WebCore::GraphicsContext::setPlatformShadow):
1358         * platform/graphics/wince/GraphicsContextWince.cpp:
1359         (WebCore::GraphicsContext::setPlatformShadow):
1360         * platform/graphics/wx/GraphicsContextWx.cpp:
1361         (WebCore::GraphicsContext::setPlatformShadow):
1362
1363 2009-11-11  Kent Tamura  <tkent@chromium.org>
1364
1365         Reviewed by Darin Adler.
1366
1367         Print the file text of a file upload control in DumpRenderTree for ease of tests.
1368         https://bugs.webkit.org/show_bug.cgi?id=31195
1369
1370         * rendering/RenderFileUploadControl.cpp:
1371         (WebCore::RenderFileUploadControl::paintObject):
1372         (WebCore::RenderFileUploadControl::fileTextValue):
1373         * rendering/RenderFileUploadControl.h:
1374         (WebCore::RenderFileUploadControl::isFileUploadControl):
1375         (WebCore::toRenderFileUploadControl):
1376         * rendering/RenderObject.h:
1377         (WebCore::RenderObject::isFileUploadControl):
1378         * rendering/RenderTreeAsText.cpp:
1379         (WebCore::operator<<):
1380
1381 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
1382
1383         Reviewed by Sam Weinig.
1384
1385         DOM Wrappers for some nodes may not be marked.
1386         https://bugs.webkit.org/show_bug.cgi?id=31380
1387
1388         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
1389         the wrapper for the current world only.  This means that wrappers may be GC'ed
1390         prematurely, and properties lost.
1391
1392         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
1393
1394         * bindings/js/JSAttrCustom.cpp:
1395         (WebCore::JSAttr::markChildren):
1396         * bindings/js/JSDOMBinding.cpp:
1397         (WebCore::markDOMNodeWrapper):
1398         * bindings/js/JSDOMBinding.h:
1399         * bindings/js/JSNamedNodeMapCustom.cpp:
1400         (WebCore::JSNamedNodeMap::markChildren):
1401         * bindings/js/JSNodeCustom.cpp:
1402         (WebCore::JSNode::markChildren):
1403         * bindings/js/JSSVGElementInstanceCustom.cpp:
1404         (WebCore::JSSVGElementInstance::markChildren):
1405         * bindings/js/JSStyleSheetCustom.cpp:
1406         (WebCore::JSStyleSheet::markChildren):
1407
1408 2009-11-11  Ben Murdoch  <benm@google.com>
1409
1410         Reviewed by Darin Adler.
1411
1412         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1413         https://bugs.webkit.org/show_bug.cgi?id=31384
1414
1415         No functionality change so no tests required.
1416
1417         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1418
1419 2009-11-11  Jens Alfke  <snej@chromium.org>
1420
1421         Reviewed by Dimitri Glazkov.
1422
1423         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1424         - Various inline functions in V8Binding.h made non-inline.
1425         - Some renaming for consistency.
1426         - New function createRawTemplate().
1427         https://bugs.webkit.org/show_bug.cgi?id=31383
1428
1429         * bindings/scripts/CodeGeneratorV8.pm:
1430         * bindings/v8/V8Binding.cpp:
1431         (WebCore::v8DOMWrapperToNative):
1432         (WebCore::v8ValueToWebCoreString):
1433         (WebCore::v8ValueToAtomicWebCoreString):
1434         (WebCore::toInt32):
1435         (WebCore::toWebCoreString):
1436         (WebCore::toWebCoreStringWithNullCheck):
1437         (WebCore::toAtomicWebCoreStringWithNullCheck):
1438         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1439         (WebCore::isUndefinedOrNull):
1440         (WebCore::v8Boolean):
1441         (WebCore::v8UndetectableString):
1442         (WebCore::v8StringOrNull):
1443         (WebCore::v8StringOrUndefined):
1444         (WebCore::v8StringOrFalse):
1445         (WebCore::v8StringToWebCoreString):
1446         (WebCore::v8ExternalString):
1447         (WebCore::createRawTemplate):  New function.
1448         * bindings/v8/V8Binding.h:
1449         (WebCore::v8DOMWrapperTo):
1450         (WebCore::v8DOMWrapperToNode):
1451         (WebCore::v8StringToWebCoreString):
1452         (WebCore::v8StringToAtomicWebCoreString):
1453
1454 2009-11-11  Jens Alfke  <snej@chromium.org>
1455
1456         Reviewed by Dimitri Glazkov.
1457
1458         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1459         event-listener setter into a new subroutine transferHiddenDependency().
1460         https://bugs.webkit.org/show_bug.cgi?id=31377
1461
1462         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1463         * bindings/v8/V8Utilities.cpp:
1464         (WebCore::transferHiddenDependency):  New.
1465         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1466
1467 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1468
1469         Reviewed by Beth Dakin.
1470
1471         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1472         because there is a CG bug preventing this from working.
1473
1474         * platform/graphics/cg/GraphicsContextCG.cpp:
1475         (WebCore::sRGBColorSpaceRef):
1476
1477 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1478
1479         Reviewed by Timothy Hatcher.
1480
1481         Check that if Storage panel exists before calling its methods
1482
1483         https://bugs.webkit.org/show_bug.cgi?id=31343
1484
1485         * inspector/front-end/inspector.js:
1486         (WebInspector.addDatabase):
1487         (WebInspector.addCookieDomain):
1488         (WebInspector.addDOMStorage):
1489         (WebInspector.updateDOMStorage):
1490
1491 2009-11-11  Jens Alfke  <snej@chromium.org>
1492
1493         Reviewed by Dimitri Glazkov.
1494
1495         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1496         times in the generated V8 bindings.
1497         https://bugs.webkit.org/show_bug.cgi?id=31368
1498
1499         * bindings/v8/V8DOMWrapper.cpp:
1500         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1501         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1502
1503 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1504
1505         Reviewed by Timothy Hatcher.
1506
1507         Display the correct summary in the web inspector for the shorthands
1508         border-color, border-width, border-style, margin, and padding.
1509         https://bugs.webkit.org/show_bug.cgi?id=7987
1510
1511         Test: fast/css/shorthands-four-values.html
1512
1513         * css/CSSMutableStyleDeclaration.cpp:
1514         (WebCore::CSSMutableStyleDeclaration::get4Values):
1515         Display the summary information in the same way the shorthand would be
1516         specified in a css rule.
1517
1518 2009-11-11  Jens Alfke  <snej@chromium.org>
1519
1520         Reviewed by Dimitri Glazkov.
1521
1522         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1523         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1524         https://bugs.webkit.org/show_bug.cgi?id=31367
1525
1526         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1527
1528 2009-11-11  Jens Alfke  <snej@chromium.org>
1529
1530         Reviewed by Dimitri Glazkov.
1531
1532         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1533
1534         * bindings/v8/DOMData.cpp:
1535         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1536             so it can be inlined by its caller.
1537         * bindings/v8/DOMData.h:
1538         * bindings/v8/MainThreadDOMData.cpp:
1539         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1540         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1541         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1542             and getStore, which inline both calls together.
1543         * bindings/v8/MainThreadDOMData.h:
1544         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1545         * bindings/v8/V8DOMMap.cpp:
1546         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1547
1548 2009-11-11  Nate Chapin  <japhet@chromium.org>
1549
1550         Reviewed by Dimitri Glazkov.
1551
1552         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=31357
1555
1556         * platform/KURLGoogle.cpp:
1557         (WebCore::isSchemeFirstChar):
1558         (WebCore::isSchemeChar):
1559         (WebCore::KURL::hasPort):
1560         (WebCore::KURL::removePort):
1561         (WebCore::protocolIsValid):
1562
1563 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1564
1565         Build fix, no reviewed.
1566
1567         Correct setPlatformFillColor and setPlatformStrokeColor calls
1568         to match new ColorSpace-supporting signatures.
1569
1570         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1571           color space to the set[...]Color calls.
1572
1573 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1574
1575         Reviewed by Sam Weinig.
1576
1577         https://bugs.webkit.org/show_bug.cgi?id=31327
1578         Clean up SocketStreamHandleClient interface
1579
1580         No change in behavior.
1581
1582         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1583         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1584         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1585         should be.
1586         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1587         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1588         For ResourceHandle, this method is called when the user cancels authentication sheet,
1589         not when something happens with the stream.
1590
1591         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1592         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1593
1594         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1595         callbacks have no real implementation yet.
1596
1597 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1598
1599         Reviewed by Eric Seidel.
1600
1601         Allow custom memory allocation control for the part of page directory in WebCore
1602         https://bugs.webkit.org/show_bug.cgi?id=31350
1603
1604         Inherits the following classes from Noncopyable because these are instantiated
1605         by 'new' and these are no need to be copyable:
1606
1607         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1608         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1609         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1610         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1611         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1612         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1613         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1614         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1615         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1616
1617         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1618         PropertyWrapper is instantiated by 'new' in 
1619         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1620
1621         * page/DragController.h:
1622         * page/EventHandler.h:
1623         * page/FocusController.h:
1624         * page/FrameView.cpp:
1625         * page/PluginHalter.h:
1626         * page/Settings.h:
1627         * page/UserScript.h:
1628         * page/UserStyleSheet.h:
1629         * page/XSSAuditor.h:
1630         * page/animation/AnimationBase.cpp:
1631
1632 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1633
1634         Reviewed by Kenneth Rohde Christiansen.
1635
1636         https://bugs.webkit.org/show_bug.cgi?id=31323
1637         Fix a few compiler warnings
1638
1639         No new tests as there is no new functionality.
1640
1641         * editing/htmlediting.cpp:
1642         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1643         parentheses to silence gcc 4.4 -Wparentheses warnings
1644
1645 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1646
1647         Reviewed by Mark Rowe.
1648
1649         Set m_hasPendingGeometryChange to true by default, so that
1650         at least one call to NPP_SetWindow is executed, which is
1651         needed by the DRT plugin testing framework.
1652
1653         * plugins/PluginView.cpp:
1654         (WebCore::PluginView::PluginView):
1655
1656 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1657
1658         Rubber-stamped by Kenneth Rohde Christiansen.
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=31348
1661         [Qt] Remove unnecessary LUT creator from WebCore.pro
1662
1663         * WebCore.pro:
1664
1665 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1666
1667         Reviewed by Tor Arne Vestbø.
1668
1669         Introduce a function for querying the input method status
1670         in QWebPageClient.
1671
1672         * platform/qt/QWebPageClient.h:
1673
1674 2009-11-11  Benjamin Otte  <otte@gnome.org>
1675
1676         Reviewed by Jan Alonzo.
1677
1678         [GTK] Black artifacts in youtube.com/html5
1679
1680         Paint the video to the given size. It's the job of the callers to keep
1681         track of aspect ratio. RenderVideo.cpp does it for the <video>
1682         element.
1683         https://bugs.webkit.org/show_bug.cgi?id=30925
1684
1685         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1686         (WebCore::MediaPlayerPrivate::paint):
1687
1688 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1689
1690         Reviewed by Reviewed by Jan Alonzo.
1691
1692         https://bugs.webkit.org/show_bug.cgi?id=30901
1693         [Gtk] Need to de-lint the Atk a11y code
1694
1695         Cleaned up some missed capitalization style-guideline violations.
1696
1697         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1698
1699 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1700
1701         Reviewed by Eric Seidel.
1702
1703         [Qt] Make the default style background color valid.
1704         Currently the color is transparent but invalid, this causes
1705         list boxes in QtWebKit to be drawn with a black background
1706         since r49242.
1707         https://bugs.webkit.org/show_bug.cgi?id=31295
1708
1709         * rendering/style/RenderStyle.h:
1710         (WebCore::InheritedFlags::initialBackgroundColor):
1711         * rendering/style/StyleBackgroundData.cpp:
1712         (WebCore::StyleBackgroundData::StyleBackgroundData):
1713
1714 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1715
1716         Reviewed by Geoff Garen.
1717
1718         Simplify the ownership model for worlds - rather than having a pair of weak references
1719         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1720         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1721         back forward cache.
1722
1723         * WebCore.base.exp:
1724         * bindings/js/JSDOMBinding.cpp:
1725         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1726         * bindings/js/JSDOMBinding.h:
1727         (WebCore::DOMWrapperWorld::forgetDocument):
1728         * bindings/js/ScriptCachedFrameData.cpp:
1729         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1730         (WebCore::ScriptCachedFrameData::restore):
1731         (WebCore::ScriptCachedFrameData::clear):
1732         * bindings/js/ScriptCachedFrameData.h:
1733         * bindings/js/ScriptController.cpp:
1734         (WebCore::ScriptController::~ScriptController):
1735         (WebCore::ScriptController::clearWindowShell):
1736         (WebCore::ScriptController::initScript):
1737         (WebCore::ScriptController::updateDocument):
1738         * bindings/js/ScriptController.h:
1739
1740 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1741
1742         Reviewed by Darin Adler.
1743
1744         rename counter to makeCounterNode in RenderCounter.cpp
1745         https://bugs.webkit.org/show_bug.cgi?id=31289
1746
1747         No new test because this is just a small refactoring.
1748
1749         * rendering/RenderCounter.cpp:
1750         (WebCore::findPlaceForCounter):
1751         (WebCore::makeCounterNode):
1752         (WebCore::RenderCounter::originalText):
1753
1754 2009-11-10  Daniel Bates  <dbates@webkit.org>
1755
1756         Reviewed by Oliver Hunt.
1757
1758         https://bugs.webkit.org/show_bug.cgi?id=30754
1759
1760         Patch 2 of 2.
1761
1762         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1763         needed. This method fired a drag event whenever the mouse moved, but
1764         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1765         model independent of when the mouse moves. See "Among other changes..."
1766         in the change log for patch 1 for more details.
1767
1768         * WebCore.DragSupport.exp:
1769         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1770         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1771         * page/EventHandler.h:
1772
1773 2009-11-10  Daniel Bates  <dbates@webkit.org>
1774
1775         Reviewed by Oliver Hunt.
1776
1777         https://bugs.webkit.org/show_bug.cgi?id=30754
1778
1779         Patch 1 of 2.
1780
1781         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1782         the drag event should always fire before the dragover event.
1783
1784         In fixing this bug, this patch also makes our drag processing model
1785         conform to the HTML 5 spec.
1786
1787         Among the changes, this patch ensures that the drag event isn't fired outside
1788         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1789         Currently, the drag event is fired whenever the mouse button is down and the OS
1790         detects the mouse moved. But, as per the spec, the drag event should
1791         fire approx. every 350ms so long as the mouse button is down.
1792
1793         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1794
1795         * page/EventHandler.cpp:
1796         (WebCore::EventHandler::clear):
1797         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1798         Modified to determine when we are in the correct instance of EventHandler to service the drag
1799         and drop operation.
1800         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1801         into this method.
1802         (WebCore::EventHandler::cancelDragAndDrop):
1803         (WebCore::EventHandler::performDragAndDrop):
1804         (WebCore::EventHandler::clearDragState):
1805         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1806         we should fire both drag and dragover events or only the dragover event.
1807
1808 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1809
1810         Reviewed by Dimitri Glazkov.
1811
1812         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1813         https://bugs.webkit.org/show_bug.cgi?id=31301
1814
1815         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1816
1817         Allowed passing V8Proxy for the calling JS context:
1818         * bindings/v8/V8DOMWrapper.h:
1819         (WebCore::V8DOMWrapper::getXPathNSResolver):
1820         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1821         (WebCore::V8CustomXPathNSResolver::create):
1822         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1823         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1824         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1825         * bindings/v8/custom/V8DocumentCustom.cpp:
1826         (WebCore::CALLBACK_FUNC_DECL):
1827
1828 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1829
1830         Reviewed by Timothy Hatcher.
1831
1832         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1833         https://bugs.webkit.org/show_bug.cgi?id=29972.
1834
1835         Add methods for setting different parts of the URL in href attribute.
1836
1837         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1838                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1839                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1840                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1841                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1842                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1843                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1844
1845         * bindings/js/JSLocationCustom.cpp:
1846         (WebCore::JSLocation::setPort):
1847         * html/HTMLAnchorElement.cpp:
1848         (WebCore::parsePortFromStringPosition):
1849         (WebCore::HTMLAnchorElement::setHash):
1850         (WebCore::HTMLAnchorElement::setHost):
1851         (WebCore::HTMLAnchorElement::setHostname):
1852         (WebCore::HTMLAnchorElement::setPathname):
1853         (WebCore::HTMLAnchorElement::setPort):
1854         (WebCore::HTMLAnchorElement::setProtocol):
1855         (WebCore::HTMLAnchorElement::setSearch):
1856         * html/HTMLAnchorElement.h:
1857         * html/HTMLAnchorElement.idl:
1858         * loader/FrameLoader.cpp:
1859         (WebCore::FrameLoader::iconURL):
1860         * platform/KURL.cpp:
1861         (WebCore::KURL::removePort):
1862         (WebCore::KURL::setPort):
1863         (WebCore::KURL::prettyURL):
1864         (WebCore::protocolIsValid):
1865         * platform/KURL.h:
1866         (WebCore::KURL::canSetHostOrPort):
1867         (WebCore::KURL::canSetPathname):
1868         (WebCore::KURL::hasPort):
1869         * platform/network/soup/ResourceHandleSoup.cpp:
1870         (WebCore::):
1871
1872 2009-11-10  Nate Chapin  <japhet@chromium.org>
1873
1874         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1875
1876         * platform/chromium/PopupMenuChromium.cpp:
1877         (WebCore::PopupContainer::paintBorder):
1878         (WebCore::PopupListBox::paint):
1879         (WebCore::PopupListBox::paintRow):
1880         * platform/graphics/chromium/TransparencyWin.cpp:
1881         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1882         * platform/graphics/skia/GraphicsContextSkia.cpp:
1883         (WebCore::GraphicsContext::fillRect):
1884         (WebCore::GraphicsContext::fillRoundedRect):
1885         (WebCore::GraphicsContext::setPlatformFillColor):
1886         (WebCore::GraphicsContext::setPlatformStrokeColor):
1887         * rendering/RenderMediaControlsChromium.cpp:
1888         (WebCore::paintMediaSlider):
1889         (WebCore::paintMediaVolumeSlider):
1890         (WebCore::paintMediaTimelineContainer):
1891         * rendering/RenderThemeChromiumMac.mm:
1892         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1893
1894 2009-11-10  Brady Eidson  <beidson@apple.com>
1895
1896         Reviewed by Sam Weinig.
1897
1898         Repro crash saving pcmag.com article as a webarchive.
1899         <rdar://problem/7381219> and https://webkit.org/b/31322
1900
1901         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1902
1903         * css/CSSStyleSheet.cpp:
1904         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1905           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1906
1907 2009-11-10  Beth Dakin  <bdakin@apple.com>
1908
1909         Attempt 2 to fix Tiger build. No review needed.
1910
1911         * platform/graphics/cg/GraphicsContextCG.cpp:
1912         (WebCore::deviceRGBColorSpaceRef):
1913         (WebCore::sRGBColorSpaceRef):
1914
1915 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1916
1917         wx build fix. Changes needed after r50760.
1918
1919         * platform/graphics/wx/GraphicsContextWx.cpp:
1920         (WebCore::GraphicsContext::GraphicsContext):
1921         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1922         (WebCore::drawTextWithSpacing):
1923
1924 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1925
1926         Qt build fix.
1927
1928         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1929         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1930
1931 2009-11-10  Beth Dakin  <bdakin@apple.com>
1932
1933         Tiger build fix. No review needed.
1934
1935         * platform/graphics/cg/GraphicsContextCG.cpp:
1936         (WebCore::sRGBColorSpaceRef):
1937
1938 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1939
1940         Reviewed by Dan Bernstein.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=31312
1943         Decouple authentication panel callbacks from ResourceHandle
1944
1945         No change in functionality.
1946
1947         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1948         ResourceHandle as delegate.
1949
1950         * WebCore.vcproj/WebCore.vcproj:
1951         * platform/network/AuthenticationClient.h: Added.
1952         Added a new interface for listening to authentication panel notifications.
1953
1954         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1955         it wants with the project file.
1956
1957         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1958         interface class.
1959         (WebCore::AuthenticationClient::deref): Ditto.
1960
1961         * platform/network/ResourceHandle.h:
1962         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1963         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1964
1965         * platform/network/cf/AuthenticationCF.cpp:
1966         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1967         (WebCore::AuthenticationChallenge::platformCompare):
1968         * platform/network/cf/AuthenticationChallenge.h:
1969         (WebCore::AuthenticationChallenge::authenticationClient):
1970         * platform/network/chromium/AuthenticationChallenge.h:
1971         (WebCore::AuthenticationChallenge::authenticationClient):
1972         * platform/network/curl/AuthenticationChallenge.h:
1973         (WebCore::AuthenticationChallenge::authenticationClient):
1974         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1975
1976 2009-11-10  Beth Dakin  <bdakin@apple.com>
1977
1978        Second attempted gtk build fix. No review needed.
1979
1980         * html/canvas/CanvasStyle.cpp:
1981         (WebCore::CanvasStyle::applyStrokeColor):
1982
1983
1984 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1985
1986         Reviewed by Geoff Garen.
1987
1988         Fix back/forwards cache with JSC isolated worlds.
1989         https://bugs.webkit.org/show_bug.cgi?id=31310
1990         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1991
1992         Store the global object for all worlds, not just the normal world.
1993         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1994         so we can forget global objects if a world goes away.
1995
1996         * bindings/js/JSDOMBinding.cpp:
1997         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1998         * bindings/js/JSDOMBinding.h:
1999         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
2000         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
2001         * bindings/js/ScriptCachedFrameData.cpp:
2002         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
2003         (WebCore::ScriptCachedFrameData::forgetWorld):
2004         (WebCore::ScriptCachedFrameData::domWindow):
2005         (WebCore::ScriptCachedFrameData::restore):
2006         (WebCore::ScriptCachedFrameData::clear):
2007         * bindings/js/ScriptCachedFrameData.h:
2008         * bindings/js/ScriptController.h:
2009
2010 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2011
2012         [Qt] Unreviewed buildfix after r50760.
2013
2014         * platform/graphics/qt/GraphicsContextQt.cpp:
2015         (WebCore::GraphicsContext::GraphicsContext):
2016
2017 2009-11-10  Beth Dakin  <bdakin@apple.com>
2018
2019         Attempted build fix. (No review needed.)
2020
2021         * GNUmakefile.am: Adding ColorSpace.h
2022
2023 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
2024
2025         Reviewed by NOBODY - Build Fix.
2026
2027         Updated function calls to take a ColorSpace argument, passing
2028         in DeviceColorSpace for now - this should be fixed. Also added
2029         ColorSpace.h to WebCore project.
2030
2031         * WebCore.vcproj/WebCore.vcproj:
2032         * platform/graphics/win/FontCGWin.cpp:
2033         (WebCore::Font::drawGlyphs):
2034         * platform/graphics/win/GraphicsContextCGWin.cpp:
2035         (WebCore::GraphicsContext::GraphicsContext):
2036         * platform/win/PopupMenuWin.cpp:
2037         (WebCore::PopupMenu::paint):
2038         * platform/win/WebCoreTextRenderer.cpp:
2039         (WebCore::doDrawTextAtPoint):
2040         * rendering/RenderThemeSafari.cpp:
2041         (WebCore::RenderThemeSafari::paintMenuListButton):
2042
2043 2009-11-10  Jens Alfke  <snej@chromium.org>
2044
2045         Reviewed by Darin Adler.
2046
2047         Optimizations to Element::getAttribute
2048         https://bugs.webkit.org/show_bug.cgi?id=30926
2049
2050         * dom/Element.cpp:
2051         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
2052         * dom/NamedAttrMap.cpp:
2053         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
2054         * platform/text/PlatformString.h:
2055         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
2056
2057 2009-11-10  Beth Dakin  <bdakin@apple.com>
2058
2059         Reviewed by Darin Adler.
2060
2061         Fix for <rdar://problem/7059710> 
2062         -and corresponding-
2063         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
2064         color-correction for CSS colors
2065
2066         New exported symbol for GraphicsContext::fillColor() which now 
2067         accepts a ColorSpace as an optional parameter.
2068         * WebCore.base.exp:
2069
2070         Added a new file, ColorSpace.h, to define the ColorSpace enum.
2071         * WebCore.xcodeproj/project.pbxproj:
2072
2073         Computed Style for -webkit-color-correction
2074         * css/CSSComputedStyleDeclaration.cpp:
2075         (WebCore::):
2076         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2077
2078         Parse -webkit-color-correction
2079         * css/CSSParser.cpp:
2080         (WebCore::CSSParser::parseValue):
2081
2082        Map CSS identifiers to the appropriate values of the ColorSpace enum
2083         * css/CSSPrimitiveValueMappings.h:
2084         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2085         (WebCore::CSSPrimitiveValue::operator ColorSpace):
2086
2087         New property -webkit-color-correction
2088         * css/CSSPropertyNames.in:
2089
2090         Map -webkit-color-correction into the RenderStyle.
2091         * css/CSSStyleSelector.cpp:
2092         (WebCore::CSSStyleSelector::applyProperty):
2093
2094         Add new value sRGB.
2095         * css/CSSValueKeywords.in:
2096
2097         Comment out the reference to sRGB since it will now be inherited as 
2098         a value from CSSValueKeywords.
2099         * css/SVGCSSValueKeywords.in:
2100
2101         Definition of the ColorSpace enum.
2102         * platform/graphics/ColorSpace.h: Added.
2103         (WebCore::):
2104
2105         These functions all now take a ColorSpace as a parameter.
2106         * platform/graphics/GraphicsContext.cpp:
2107         (WebCore::GraphicsContext::setStrokeColor):
2108         (WebCore::GraphicsContext::setFillColor):
2109         (WebCore::GraphicsContext::drawHighlightForText):
2110
2111         Return the appropriate ColorSpace.
2112         (WebCore::GraphicsContext::strokeColorSpace):
2113         (WebCore::GraphicsContext::fillColorSpace):
2114
2115         These functions all call other functions which require a ColorSpace 
2116         as a parameter.
2117         (WebCore::GraphicsContext::setStrokePattern):
2118         (WebCore::GraphicsContext::setFillPattern):
2119         (WebCore::GraphicsContext::setStrokeGradient):
2120         (WebCore::GraphicsContext::setFillGradient):
2121
2122         All of the GraphicsContext functions that take a Color should now 
2123         also take a ColorSpace.
2124         * platform/graphics/GraphicsContext.h:
2125
2126         Added new member variables stokeColorSpace and fillColorSpace.
2127         * platform/graphics/GraphicsContextPrivate.h:
2128         (WebCore::GraphicsContextState::GraphicsContextState):
2129
2130         Attempt to keep the Cairo port building with all of the massive 
2131         changes to GraphicsContext.        
2132         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2133         (WebCore::GraphicsContext::fillRect):
2134         (WebCore::GraphicsContext::setPlatformFillColor):
2135         (WebCore::GraphicsContext::setPlatformStrokeColor):
2136         (WebCore::GraphicsContext::fillRoundedRect):
2137
2138         
2139         * platform/graphics/cg/GraphicsContextCG.cpp:
2140         (WebCore::sRGBColorSpaceRef): New static function that returns a 
2141         CGColorSpaceRef for the sRGB color space.
2142         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
2143         a CGColorSpaceRef for the device RGB color space.
2144
2145         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
2146         sets the fill color to the specified color in the given ColorSpace.
2147         (WebCore::setCGStrokeColor): Same, but for stroke.
2148
2149         (WebCore::setCGFillColorSpace): New static to set the 
2150         CGFillColorSpace to the given ColorSpace
2151         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
2152
2153         Send ColorSpaces when appropriate, set ColorSpaces when 
2154         appropriate, and check ColorSpaces when appropriate.
2155         (WebCore::GraphicsContext::GraphicsContext):
2156         (WebCore::GraphicsContext::drawRect):
2157         (WebCore::GraphicsContext::drawLine):
2158         (WebCore::GraphicsContext::fillPath):
2159         (WebCore::GraphicsContext::strokePath):
2160         (WebCore::GraphicsContext::fillRect):
2161         (WebCore::GraphicsContext::fillRoundedRect):
2162         (WebCore::GraphicsContext::strokeRect):
2163         (WebCore::GraphicsContext::drawLineForText):
2164         (WebCore::GraphicsContext::setPlatformStrokeColor):
2165         (WebCore::GraphicsContext::setPlatformFillColor):
2166
2167         Attempt to keep Haiku building.
2168         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2169         (WebCore::GraphicsContext::fillRect):
2170         (WebCore::GraphicsContext::fillRoundedRect):
2171         (WebCore::GraphicsContext::setPlatformStrokeColor):
2172         (WebCore::GraphicsContext::setPlatformFillColor):
2173
2174         Attempt to keep QT building.
2175         * platform/graphics/qt/GraphicsContextQt.cpp:
2176         (WebCore::GraphicsContext::fillRect):
2177         (WebCore::GraphicsContext::fillRoundedRect):
2178         (WebCore::GraphicsContext::setPlatformStrokeColor):
2179         (WebCore::GraphicsContext::setPlatformFillColor):
2180
2181         Attempt to keep Wince building.
2182         * platform/graphics/wince/GraphicsContextWince.cpp:
2183         (WebCore::GraphicsContext::fillRect):
2184         (WebCore::GraphicsContext::setPlatformFillColor):
2185         (WebCore::GraphicsContext::setPlatformStrokeColor):
2186         (WebCore::GraphicsContext::clearRect):
2187         (WebCore::GraphicsContext::fillRoundedRect):
2188         (WebCore::GraphicsContext::setPlatformShadow):
2189
2190         Attempt to keep WX building.
2191         * platform/graphics/wx/GraphicsContextWx.cpp:
2192         (WebCore::GraphicsContext::fillRect):
2193         (WebCore::GraphicsContext::fillRoundedRect):
2194         (WebCore::GraphicsContext::setPlatformStrokeColor):
2195         (WebCore::GraphicsContext::setPlatformFillColor):
2196
2197         Added functions colorSpace() and setColorSpace()
2198         * rendering/style/RenderStyle.h:
2199         (WebCore::InheritedFlags::colorSpace):
2200         (WebCore::InheritedFlags::setColorSpace):
2201
2202         The ColorSpace is stored here.
2203         * rendering/style/StyleRareInheritedData.cpp:
2204         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2205         (WebCore::StyleRareInheritedData::operator==):
2206         * rendering/style/StyleRareInheritedData.h:
2207
2208         All of these call sites call GraphicsContext functions which now 
2209         require ColorSpaces.
2210         * editing/SelectionController.cpp:
2211         (WebCore::SelectionController::paintCaret):
2212         * html/canvas/CanvasRenderingContext2D.cpp:
2213         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2214         * html/canvas/CanvasStyle.cpp:
2215         (WebCore::CanvasStyle::applyStrokeColor):
2216         (WebCore::CanvasStyle::applyFillColor):
2217         * inspector/InspectorController.cpp:
2218         (WebCore::drawOutlinedQuad):
2219         * page/FrameView.cpp:
2220         (WebCore::FrameView::paintContents):
2221         * platform/ScrollbarTheme.h:
2222         (WebCore::ScrollbarTheme::paintScrollCorner):
2223         * platform/ScrollbarThemeComposite.cpp:
2224         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
2225         * platform/graphics/Image.cpp:
2226         (WebCore::Image::fillWithSolidColor):
2227         * platform/graphics/mac/FontMac.mm:
2228         (WebCore::Font::drawGlyphs):
2229         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2230         (WebCore::MediaPlayerPrivate::paint):
2231         * rendering/EllipsisBox.cpp:
2232         (WebCore::EllipsisBox::paint):
2233         * rendering/InlineFlowBox.cpp:
2234         (WebCore::InlineFlowBox::paintTextDecorations):
2235         * rendering/InlineTextBox.cpp:
2236         (WebCore::updateGraphicsContext):
2237         (WebCore::paintTextWithShadows):
2238         (WebCore::InlineTextBox::paint):
2239         (WebCore::InlineTextBox::paintSelection):
2240         (WebCore::InlineTextBox::paintCompositionBackground):
2241         (WebCore::InlineTextBox::paintDecoration):
2242         (WebCore::InlineTextBox::paintTextMatchMarker):
2243         (WebCore::InlineTextBox::paintCompositionUnderline):
2244         * rendering/InlineTextBox.h:
2245         * rendering/RenderBlock.cpp:
2246         (WebCore::RenderBlock::fillHorizontalSelectionGap):
2247         (WebCore::RenderBlock::fillVerticalSelectionGap):
2248         (WebCore::RenderBlock::fillLeftSelectionGap):
2249         (WebCore::RenderBlock::fillRightSelectionGap):
2250         * rendering/RenderBoxModelObject.cpp:
2251         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2252         (WebCore::RenderBoxModelObject::paintBoxShadow):
2253         * rendering/RenderFileUploadControl.cpp:
2254         (WebCore::RenderFileUploadControl::paintObject):
2255         * rendering/RenderFrameSet.cpp:
2256         (WebCore::RenderFrameSet::paintColumnBorder):
2257         (WebCore::RenderFrameSet::paintRowBorder):
2258         * rendering/RenderImage.cpp:
2259         (WebCore::RenderImage::paintReplaced):
2260         * rendering/RenderLayer.cpp:
2261         (WebCore::RenderLayer::paintScrollCorner):
2262         (WebCore::RenderLayer::paintResizer):
2263         * rendering/RenderListBox.cpp:
2264         (WebCore::RenderListBox::paintItemForeground):
2265         (WebCore::RenderListBox::paintItemBackground):
2266         * rendering/RenderListMarker.cpp:
2267         (WebCore::RenderListMarker::paint):
2268         * rendering/RenderObject.cpp:
2269         (WebCore::RenderObject::drawLineForBoxSide):
2270         (WebCore::RenderObject::drawArcForBoxSide):
2271         * rendering/RenderReplaced.cpp:
2272         (WebCore::RenderReplaced::paint):
2273         * rendering/RenderScrollbarTheme.cpp:
2274         (WebCore::RenderScrollbarTheme::paintScrollCorner):
2275         * rendering/RenderThemeMac.mm:
2276         (WebCore::RenderThemeMac::paintMenuListButton):
2277         * rendering/RenderView.cpp:
2278         (WebCore::RenderView::paintBoxDecorations):
2279         * rendering/RenderWidget.cpp:
2280         (WebCore::RenderWidget::paint):
2281         * rendering/SVGInlineTextBox.cpp:
2282         (WebCore::SVGInlineTextBox::paintSelection):
2283         * svg/graphics/SVGPaintServerGradient.cpp:
2284         (WebCore::SVGPaintServerGradient::setup):
2285         * svg/graphics/SVGPaintServerSolid.cpp:
2286         (WebCore::SVGPaintServerSolid::setup):
2287
2288 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
2289
2290         Reviewed by Timothy Hatcher.
2291
2292         Web Inspector: Speed up syntax highlighter
2293         https://bugs.webkit.org/show_bug.cgi?id=31291
2294
2295         * inspector/front-end/SourceFrame.js:
2296         (WebInspector.SourceFrame.prototype._loaded):
2297         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
2298         (WebInspector.SourceSyntaxHighlighter.prototype.process):
2299         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
2300         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
2301         (WebInspector.CSSSourceSyntaxHighlighter):
2302         (WebInspector.JavaScriptSourceSyntaxHighlighter):
2303
2304 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
2305
2306         Reviewed by Eric Seidel.
2307
2308         Remove session storage setting
2309         https://bugs.webkit.org/show_bug.cgi?id=31279
2310
2311         Remove session storage from Settings.  It was added temporarily so we could
2312         disable it by default at runtime in Chromium.  We now disable these things in a
2313         different way, so it's time to remove it.  Qt also depended on this setting for
2314         a short period of time, but after talking to them we agreed that it should be
2315         removed.
2316
2317         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
2318
2319         * page/DOMWindow.cpp:
2320         (WebCore::DOMWindow::sessionStorage):
2321         * page/Settings.cpp:
2322         (WebCore::Settings::Settings):
2323         * page/Settings.h:
2324
2325 2009-11-10  Dan Bernstein  <mitz@apple.com>
2326
2327         Reviewed by Eric Carlson and Darin Adler.
2328
2329         WebCore part of making full-screen video pause during scrubbing.
2330
2331         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
2332         and HTMLMediaElement::endScrubbing().
2333
2334 2009-11-10  Anton Muhin  <antonm@chromium.org>
2335
2336         Reviewed by Adam Barth.
2337
2338         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
2339         https://bugs.webkit.org/show_bug.cgi?id=31051
2340
2341         * bindings/v8/V8GCController.cpp:
2342         (WebCore::V8GCController::gcEpilogue):
2343         (WebCore::V8GCController::checkMemoryUsage):
2344         * bindings/v8/V8GCController.h:
2345         * bindings/v8/V8Proxy.cpp:
2346         (WebCore::V8Proxy::evaluate):
2347         (WebCore::V8Proxy::runScript):
2348         (WebCore::V8Proxy::callFunction):
2349
2350 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
2351
2352         Reviewed by Darin Adler.
2353
2354         Allow custom memory allocation control for the part of loader directory in WebCore
2355         https://bugs.webkit.org/show_bug.cgi?id=31161
2356
2357         Inherits the following classes from Noncopyable because these are instantiated
2358         by 'new' and these are no need to be copyable:
2359
2360         class Request - WebCore/loader/loader.cpp:100
2361         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2362         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2363         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2364         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2365         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2366
2367         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2368         MainThreadBridge is instantiated by 'new' in 
2369         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2370
2371         ThreadableLoaderClient's inheriting has been changed to public.
2372
2373         * loader/ImageLoader.cpp:
2374         * loader/ProgressTracker.cpp:
2375         * loader/RedirectScheduler.cpp:
2376         * loader/Request.h:
2377         * loader/ThreadableLoaderClient.h:
2378         * loader/WorkerThreadableLoader.h:
2379         * loader/appcache/ApplicationCacheHost.h:
2380         * loader/appcache/ApplicationCacheStorage.h:
2381
2382 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2383
2384         Reviewed by Eric Seidel.
2385
2386         https://bugs.webkit.org/show_bug.cgi?id=31047
2387         [GTK] Failing test media/video-played-ranges-1.html
2388
2389         WebKit coding style fixes.
2390
2391         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2392         (WebCore::mediaPlayerPrivateMessageCallback):
2393         (WebCore::MediaPlayerPrivate::naturalSize):
2394         (WebCore::MediaPlayerPrivate::paint):
2395         (WebCore::mimeTypeCache):
2396
2397 2009-11-10  Oliver Hunt  <oliver@apple.com>
2398
2399         Remove build failure introduced by earlier build fix.
2400
2401         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2402
2403 2009-11-10  Oliver Hunt  <oliver@apple.com>
2404
2405         Is this the last build fix? grep tells me yes.
2406
2407         * bindings/v8/custom/V8DocumentCustom.cpp:
2408         (WebCore::CALLBACK_FUNC_DECL):
2409
2410 2009-11-10  Oliver Hunt  <oliver@apple.com>
2411
2412         Hopefully the last one.  Why aren't these autogenerated?
2413
2414         * bindings/v8/V8DOMWrapper.cpp:
2415         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2416         (WebCore::V8DOMWrapper::getTemplate):
2417         (WebCore::V8DOMWrapper::convertToV8Object):
2418
2419 2009-11-10  Oliver Hunt  <oliver@apple.com>
2420
2421         Another chrome build fix.
2422
2423         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2424         (WebCore::CALLBACK_FUNC_DECL):
2425
2426 2009-11-10  Oliver Hunt  <oliver@apple.com>
2427
2428         Yet another chrome buildfix
2429
2430         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2431         (WebCore::CALLBACK_FUNC_DECL):
2432         * bindings/v8/custom/V8WebGLArrayCustom.h:
2433         (WebCore::constructCanvasArray):
2434         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2435         (WebCore::CALLBACK_FUNC_DECL):
2436         (WebCore::INDEXED_PROPERTY_GETTER):
2437         (WebCore::INDEXED_PROPERTY_SETTER):
2438         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2439         (WebCore::CALLBACK_FUNC_DECL):
2440         (WebCore::INDEXED_PROPERTY_GETTER):
2441         (WebCore::INDEXED_PROPERTY_SETTER):
2442         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2443         (WebCore::CALLBACK_FUNC_DECL):
2444         (WebCore::INDEXED_PROPERTY_GETTER):
2445         (WebCore::INDEXED_PROPERTY_SETTER):
2446         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2447         (WebCore::CALLBACK_FUNC_DECL):
2448         (WebCore::vertexAttribAndUniformHelperf):
2449         (WebCore::uniformHelperi):
2450         (WebCore::uniformMatrixHelper):
2451         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2452         (WebCore::CALLBACK_FUNC_DECL):
2453         (WebCore::INDEXED_PROPERTY_GETTER):
2454         (WebCore::INDEXED_PROPERTY_SETTER):
2455         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2456         (WebCore::CALLBACK_FUNC_DECL):
2457         (WebCore::INDEXED_PROPERTY_GETTER):
2458         (WebCore::INDEXED_PROPERTY_SETTER):
2459         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2460         (WebCore::CALLBACK_FUNC_DECL):
2461         (WebCore::INDEXED_PROPERTY_GETTER):
2462         (WebCore::INDEXED_PROPERTY_SETTER):
2463         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2464         (WebCore::CALLBACK_FUNC_DECL):
2465         (WebCore::INDEXED_PROPERTY_GETTER):
2466         (WebCore::INDEXED_PROPERTY_SETTER):
2467
2468 2009-11-10  Oliver Hunt  <oliver@apple.com>
2469
2470         Chrome build fix.
2471
2472         * bindings/v8/V8Index.h:
2473
2474 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2475
2476         Reviewed by Reviewed by Jan Alonzo.
2477
2478         https://bugs.webkit.org/show_bug.cgi?id=30901
2479         [Gtk] Need to de-lint the Atk a11y code
2480
2481         Removal of various and sundry style-violating nits.
2482
2483         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2484
2485 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2486
2487         Reviewed by Jan Alonzo.
2488
2489         https://bugs.webkit.org/show_bug.cgi?id=31047
2490         [GTK] Failing test media/video-played-ranges-1.html
2491
2492         Fix playback rate setter by remembering the rate was changed. Also
2493         correctly handle reverse playback by doing a seek from end to
2494         beginning of the media.
2495
2496         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2497         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2498         (WebCore::MediaPlayerPrivate::currentTime):
2499         (WebCore::MediaPlayerPrivate::seek):
2500         (WebCore::MediaPlayerPrivate::hasAudio):
2501         (WebCore::MediaPlayerPrivate::setVolume):
2502         (WebCore::MediaPlayerPrivate::setRate):
2503         (WebCore::MediaPlayerPrivate::updateStates):
2504         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2505
2506 2009-11-10  Oliver Hunt  <oliver@apple.com>
2507
2508         Reviewed by Maciej Stachowiak.
2509
2510         Rename 3D Canvas related classes to use WebGL prefix
2511         https://bugs.webkit.org/show_bug.cgi?id=29095
2512
2513         Automatic rename of all WebGL related types from Canvas* to
2514         WebGL* per more recent version of the WebGL spec.
2515
2516         Due to the automatic rename I've removed the 600+ line change list.
2517
2518 2009-11-09  Dirk Schulze  <krit@webkit.org>
2519
2520         Reviewed by Oliver Hunt.
2521
2522         SVG feDisplacementMap is not implemented
2523         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2524
2525         This is the implementation of the SVG filter effect
2526         feDisplacementMap. 
2527
2528         Test: svg/filters/feDisplacementMap.svg
2529
2530         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2531         (WebCore::FEDisplacementMap::apply):
2532
2533 2009-11-09  Kent Tamura  <tkent@chromium.org>
2534
2535         Reviewed by Darin Adler.
2536
2537         Add a comment about null strings and hash functions.
2538         https://bugs.webkit.org/show_bug.cgi?id=29118
2539
2540         * platform/text/StringHash.h:
2541
2542 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2543
2544         Reviewed by Darin Adler.
2545
2546         Compiler warnings in InspectorResource.h
2547         https://bugs.webkit.org/show_bug.cgi?id=29231
2548
2549         Fix compilation warnings by removing addition operation on an enum type.
2550
2551         * inspector/InspectorResource.h:
2552         (WebCore::InspectorResource::):
2553         (WebCore::InspectorResource::Changes::hasChange):
2554         (WebCore::InspectorResource::Changes::set):
2555         (WebCore::InspectorResource::Changes::setAll):
2556
2557 2009-11-09  Anders Carlsson  <andersca@apple.com>
2558
2559         Reviewed by Darin Adler and Dan Bernstein.
2560
2561         <rdar://problem/7328395>
2562         https://bugs.webkit.org/show_bug.cgi?id=31277
2563
2564         When an object tag's style changes (for example when child nodes are added/removed),
2565         reuse its Frame (if it has one) instead of creating multiple Frames.
2566
2567         Test: fast/dom/HTMLObjectElement/children-changed.html
2568
2569         * loader/FrameLoader.cpp:
2570         (WebCore::FrameLoader::requestObject):
2571
2572 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2573
2574         Reviewed by Kenneth Rohde Christiansen.
2575
2576         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2577         since adjustment of RW-section base address will be needed for all new symbian
2578         tool chains, specifically for arm and gcc compilation targets.
2579         Also, change target address to 0xE00000 to be sufficient for all targets.
2580
2581         * WebCore.pro:
2582
2583 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2584
2585         Reviewed by Timothy Hatcher.
2586
2587         Web Inspector: Crash when inspecting
2588         WebCore\manual-tests\inspector\dom-mutation.html
2589
2590         https://bugs.webkit.org/show_bug.cgi?id=31259
2591
2592         * inspector/InspectorDOMAgent.cpp:
2593         (WebCore::InspectorDOMAgent::handleEvent):
2594
2595 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2596
2597         Reviewed by Kenneth Rohde Christiansen.
2598
2599         [Qt] Few classes have virtual functions but non-virtual destructor
2600         https://bugs.webkit.org/show_bug.cgi?id=31269
2601
2602         No new tests as there is no functional change.
2603
2604         * platform/qt/QWebPageClient.h:
2605         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2606
2607 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2608
2609         Reviewed by Kenneth Rohde Christiansen.
2610
2611         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2612         https://bugs.webkit.org/show_bug.cgi?id=31140
2613
2614         QtNetwork interprets null string as request to remove the header, not add it.
2615         Replace null values with empty values before passing them to QtNetwork.
2616
2617         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2618
2619         * platform/network/qt/ResourceRequestQt.cpp:
2620         (WebCore::ResourceRequest::toNetworkRequest):
2621
2622 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2623
2624         Reviewed by Kevin Ollivier.
2625
2626         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2627         simply ignored before resulting in transparent areas being black in PNG
2628         images for example.
2629         
2630         https://bugs.webkit.org/show_bug.cgi?id=30823
2631
2632         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2633         (WebCore::RGBA32Buffer::asNewNativeImage):
2634
2635 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2636
2637         Reviewed by Kenneth Rohde Christiansen.
2638
2639         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2640         https://bugs.webkit.org/show_bug.cgi?id=31040
2641
2642         No new tests as there is no functional change.
2643
2644         * dom/Document.cpp:
2645         (WebCore::Document::recalcStyleSelector):
2646         * editing/TextIterator.cpp:
2647         (WebCore::pushFullyClippedState):
2648         * editing/VisibleSelection.cpp:
2649         (WebCore::VisibleSelection::appendTrailingWhitespace):
2650         * html/HTMLLinkElement.cpp:
2651         (WebCore::HTMLLinkElement::process):
2652         * loader/RedirectScheduler.cpp:
2653         (WebCore::RedirectScheduler::mustLockBackForwardList):
2654         * loader/appcache/ApplicationCacheGroup.cpp:
2655         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2656         * platform/graphics/qt/FontCacheQt.cpp:
2657         (WebCore::FontPlatformDataCacheKey::computeHash):
2658         * rendering/RenderBlock.cpp:
2659         (WebCore::RenderBlock::handleRunInChild):
2660         * rendering/RenderBox.cpp:
2661         (WebCore::RenderBox::calcHeight):
2662         * rendering/RenderTextControlMultiLine.cpp:
2663         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2664         * rendering/style/RenderStyle.cpp:
2665         (WebCore::RenderStyle::diff):
2666         * svg/SVGAnimateElement.cpp:
2667         (WebCore::parseNumberValueAndUnit):
2668         * svg/SVGAnimationElement.cpp:
2669         (WebCore::SVGAnimationElement::startedActiveInterval):
2670         * svg/SVGPreserveAspectRatio.cpp:
2671         (WebCore::SVGPreserveAspectRatio::getCTM):
2672
2673 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2674
2675         Reviewed by Dimitri Glazkov.
2676
2677         Win chromium is slow to draw transparent texts
2678         https://bugs.webkit.org/show_bug.cgi?id=31258
2679
2680         Clip graphics context to reduce calculation.
2681
2682         No new tests because this change only affects performance.
2683
2684         * platform/graphics/chromium/FontChromiumWin.cpp:
2685         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2686         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2687
2688 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2689
2690         Reviewed by Darin Adler.
2691
2692         showTree(CounterNode*) generates too little info and has too many spaces.
2693         https://bugs.webkit.org/show_bug.cgi?id=31212
2694
2695         No new tests as the change has no functional effect it is just for
2696         improved debugging.
2697
2698         * rendering/CounterNode.cpp:
2699         (WebCore::showTreeAndMark):
2700         Changed to also show addresses of parent, next and previous
2701         siblings.
2702
2703 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2704
2705         Reviewed by Darin Adler.
2706
2707         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2708         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2709
2710         https://bugs.webkit.org/show_bug.cgi?id=31083
2711
2712         No new tests; implementation is unchanged.
2713
2714         * page/Frame.cpp:
2715         (WebCore::Frame::setUseSecureKeyboardEntry):
2716         * page/mac/FrameMac.mm:
2717
2718 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2719
2720         Reviewed by Jan Alonzo.
2721
2722         Make XP_UNIX tests consistent
2723         https://bugs.webkit.org/show_bug.cgi?id=31250
2724
2725         No new tests as there is no functional change.
2726
2727         * plugins/PluginView.cpp:
2728         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2729         instead of the value of the macro
2730
2731         * plugins/gtk/PluginViewGtk.cpp:
2732         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2733         defined instead of using the PLATFORM macro to be consistent
2734         (WebCore::PluginView::getValue): Ditto.
2735
2736 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2737
2738         Reviewed by Darin Adler.
2739
2740         Thunk to the main thread from ~Database to deref Database's m_document.
2741
2742         If the Database was the Document's last referrer, then ~Document occurs on the
2743         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2744         ASSERT in debug builds.
2745
2746         * storage/Database.cpp:
2747         (WebCore::derefDocument):
2748         (WebCore::Database::~Database):
2749
2750 2009-11-09  Mark Mentovai  <mark@chromium.org>
2751
2752         Reviewed by Dan Bernstein.
2753
2754         Track "can have scrollbar" state within FrameView independently of the
2755         individual scrollbar states in ScrollView.
2756
2757         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2758         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2759         edit mode.
2760
2761         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2762         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2763
2764         Test: fast/overflow/scrollbar-restored.html
2765
2766         * WebCore.base.exp:
2767         * page/FrameView.cpp:
2768         (WebCore::FrameView::FrameView):
2769         (WebCore::FrameView::resetScrollbars):
2770         (WebCore::FrameView::setCanHaveScrollbars):
2771         (WebCore::FrameView::updateCanHaveScrollbars):
2772         (WebCore::FrameView::layout):
2773         * page/FrameView.h:
2774         * platform/ScrollView.h:
2775
2776 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2777
2778         Reviewed by Timothy Hatcher.
2779
2780         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2781         https://bugs.webkit.org/show_bug.cgi?id=31257
2782
2783         * inspector/front-end/SourceFrame.js:
2784
2785 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2786
2787         Reviewed by Timothy Hatcher.
2788
2789         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2790         https://bugs.webkit.org/show_bug.cgi?id=31252
2791
2792         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2793
2794         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2795
2796         * inspector/front-end/ConsoleView.js:
2797         (WebInspector.ConsoleView.prototype._promptKeyDown):
2798         * inspector/front-end/utilities.js:
2799         ():
2800         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2801
2802 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2803
2804         Reviewed by Kenneth Rohde Christiansen.
2805
2806         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2807         https://bugs.webkit.org/show_bug.cgi?id=31208
2808
2809         After r42483, the credentials are no longer passed to the network request
2810         in the URL of the request.
2811         Pass the credentials from XMLHTTPRequest to the network request, the same
2812         way that other ports do.
2813
2814         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2815
2816         * platform/network/qt/ResourceHandleQt.cpp:
2817         (WebCore::ResourceHandle::start):
2818         (WebCore::ResourceHandle::loadResourceSynchronously):
2819
2820 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2821
2822         Unreviewed.
2823
2824         https://bugs.webkit.org/show_bug.cgi?id=31161
2825
2826         Roll back r50657 because it breaks the MAC builds.
2827
2828         * loader/ImageLoader.cpp:
2829         * loader/ProgressTracker.cpp:
2830         * loader/RedirectScheduler.cpp:
2831         * loader/Request.h:
2832         * loader/ThreadableLoaderClient.h:
2833         * loader/WorkerThreadableLoader.h:
2834         * loader/appcache/ApplicationCacheHost.h:
2835         * loader/appcache/ApplicationCacheStorage.h:
2836         * loader/icon/IconDatabaseClient.h:
2837
2838 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2839
2840         Reviewed by Darin Adler.
2841
2842         Allow custom memory allocation control for the part of loader directory in WebCore
2843         https://bugs.webkit.org/show_bug.cgi?id=31161
2844
2845         Inherits the following classes from Noncopyable because these are instantiated
2846         by 'new' and these are no need to be copyable:
2847
2848         class Request - WebCore/loader/loader.cpp:100
2849         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2850         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2851         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2852         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2853         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2854         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2855
2856         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2857         MainThreadBridge is instantiated by 'new' in 
2858         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2859
2860         ThreadableLoaderClient's inheriting has been changed to public.
2861
2862         * loader/ImageLoader.cpp:
2863         * loader/ProgressTracker.cpp:
2864         * loader/RedirectScheduler.cpp:
2865         * loader/Request.h:
2866         * loader/ThreadableLoaderClient.h:
2867         * loader/WorkerThreadableLoader.h:
2868         * loader/appcache/ApplicationCacheHost.h:
2869         * loader/appcache/ApplicationCacheStorage.h:
2870         * loader/icon/IconDatabaseClient.h:
2871
2872 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2873
2874         Reviewed by Darin Adler.
2875
2876         Allow custom memory allocation control for WebCore's DocLoader
2877         https://bugs.webkit.org/show_bug.cgi?id=31163
2878
2879         Inherits DocLoader class from Noncopyable because it is
2880         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2881         it is no need to be copyable.
2882
2883         * loader/DocLoader.h:
2884
2885 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2886
2887         Reviewed by Darin Adler.
2888
2889         Allow custom memory allocation control for WebCore's Tokenizer
2890         https://bugs.webkit.org/show_bug.cgi?id=31162
2891
2892         Inherits Tokenizer class from Noncopyable because (its child class)
2893         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2894         and it is no need to be copyable.
2895
2896         * dom/Tokenizer.h:
2897
2898 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2899
2900         Reviewed by Darin Adler.
2901
2902         Allow custom memory allocation control for WebCore's DeleteButtonController
2903         https://bugs.webkit.org/show_bug.cgi?id=31105
2904
2905         Inherits DeleteButtonController class from Noncopyable because it is 
2906         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2907         it is no need to be copyable.  
2908
2909         * editing/DeleteButtonController.h:
2910
2911 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2912
2913         Reviewed by Jan Alonzo.
2914
2915         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2916         https://bugs.webkit.org/show_bug.cgi?id=30482
2917
2918         Expose Page::tabKeyCyclesThroughElements as a property of
2919         WebKitWebView.
2920
2921         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2922
2923         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2924         (WebCore::singleCharacterString):
2925
2926 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2927
2928         Reviewed by Xan Lopez.
2929
2930         https://bugs.webkit.org/show_bug.cgi?id=25415
2931         [GTK][ATK] Please implement support for get_text_at_offset
2932
2933         Fix a crasher that occurred with text which included newline
2934         chars in the markup.
2935
2936         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2937         (convertUniCharToUTF8):
2938
2939 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2940
2941         Reviewed by Holger Freyther.
2942
2943         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2944         https://bugs.webkit.org/show_bug.cgi?id=31144
2945
2946         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2947         documents that end prematurely but are not considered invalid by QXmlStream.
2948         This is to stay compatible with the libxml2 implementation.
2949         However, that code path would be also hit in situations when it should not,
2950         i.e. the error would have already been caught and handled. As a result, the
2951         same error would be reported twice.
2952
2953         No new tests, because the problem is already covered by
2954         fast/parser/xml-declaration-missing-ending-mark.html.
2955
2956         * dom/XMLTokenizerQt.cpp:
2957         (WebCore::XMLTokenizer::doEnd):
2958
2959 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2960
2961         Reviewed by Pavel Feldman.
2962
2963         Web Inspector: Inspector should support copy() in the command line
2964         https://bugs.webkit.org/show_bug.cgi?id=31238
2965
2966         * inspector/InspectorBackend.cpp:
2967         (WebCore::InspectorBackend::copyText): Added.
2968         * inspector/InspectorBackend.h: Added copyText
2969         * inspector/InspectorBackend.idl: Added copyText
2970         * inspector/front-end/InjectedScript.js:
2971         (InjectedScript._copy): Added.
2972         (InjectedScript._ensureCommandLineAPIInstalled):
2973
2974 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2975
2976         Reviewed by Dimitri Glazkov.
2977
2978         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2979         https://bugs.webkit.org/show_bug.cgi?id=31226
2980
2981         Now checks to see what type of context is active and creates the
2982         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2983
2984         Added support for converting to SharedWorkers and SharedWorkerContexts.
2985
2986         Test: Existing layout tests cover this case (start passing in Chrome).
2987
2988         * bindings/v8/WorkerContextExecutionProxy.cpp:
2989         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2990         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2991         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2992         Added support for SHAREDWORKERCONTEXT.
2993         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2994         Added support for SharedWorker and SharedWorkerContext.
2995
2996 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2997
2998         Reviewed by Dimitri Glazkov.
2999
3000         https://bugs.webkit.org/show_bug.cgi?id=31224
3001         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
3002
3003         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
3004
3005         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
3006         (WebCore::NAMED_PROPERTY_GETTER):
3007
3008 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
3009
3010         Reviewed by Timothy Hatcher.
3011
3012         Web Inspector: "Search again" on scripts panel switches
3013         to the script this search started with.
3014
3015         https://bugs.webkit.org/show_bug.cgi?id=31243
3016
3017         * inspector/front-end/Panel.js:
3018         (WebInspector.Panel.prototype.jumpToNextSearchResult):
3019
3020 2009-11-08  Kent Tamura  <tkent@chromium.org>
3021
3022         Reviewed by Darin Adler.
3023
3024         Simplify Icon interface.
3025         https://bugs.webkit.org/show_bug.cgi?id=31154
3026
3027         - Remove Icon::createIconForFile().  createIconForFiles() covers
3028           createIconForFile()'s role.
3029         - Remove FileChooser::chooseIcon()
3030         - Change the parameter types of FileChooser constructor and the
3031           factory method, String -> const Vector<String>&, in order to
3032           support initialization with multiple files.
3033         - Remove the icon loading code in IconChromiumWin.cpp, which
3034           doesn't work because of the sandbox.
3035
3036         No tests because it's just a refactoring.
3037
3038         * platform/FileChooser.cpp:
3039         (WebCore::FileChooser::FileChooser):
3040         (WebCore::FileChooser::create):
3041         (WebCore::FileChooser::chooseFile):
3042         (WebCore::FileChooser::chooseFiles):
3043         * platform/FileChooser.h:
3044         * platform/graphics/Icon.h:
3045         * platform/graphics/chromium/IconChromiumLinux.cpp:
3046         * platform/graphics/chromium/IconChromiumMac.cpp:
3047         * platform/graphics/chromium/IconChromiumWin.cpp:
3048         (WebCore::Icon::createIconForFiles):
3049         * platform/graphics/gtk/IconGtk.cpp:
3050         (WebCore::Icon::createIconForFiles):
3051         * platform/graphics/haiku/IconHaiku.cpp:
3052         * platform/graphics/mac/IconMac.mm:
3053         (WebCore::Icon::createIconForFiles):
3054         * platform/graphics/qt/IconQt.cpp:
3055         (WebCore::Icon::createIconForFiles):
3056         * platform/graphics/win/IconWin.cpp:
3057         (WebCore::Icon::createIconForFiles):
3058         * platform/graphics/wx/IconWx.cpp:
3059         * rendering/RenderFileUploadControl.cpp:
3060         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3061
3062 2009-11-08  Daniel Bates  <dbates@webkit.org>
3063
3064         Reviewed by Adam Barth.
3065
3066         https://bugs.webkit.org/show_bug.cgi?id=31098
3067
3068         Allows same-origin plugin-based content to load.
3069
3070         Test: http/tests/security/xssAuditor/object-src-inject.html
3071
3072         * page/XSSAuditor.cpp:
3073         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
3074         (WebCore::XSSAuditor::canLoadObject): Ditto.
3075         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
3076         (WebCore::XSSAuditor::isSameOriginResource): Added.
3077         * page/XSSAuditor.h:
3078
3079 2009-11-08  David Levin  <levin@chromium.org>
3080
3081         Reviewed by NOBODY (chromium build fix).
3082
3083         * platform/network/HTTPParsers.cpp:
3084         (WebCore::parseDate): Changed this to not
3085         use a date parser that needs ExecState passed.
3086         
3087 2009-11-08  David Levin  <levin@chromium.org>
3088
3089         Unreviewed build fix for chromium.
3090
3091         * platform/graphics/skia/GraphicsContextSkia.cpp:
3092         (WebCore::GraphicsContext::fillPath):
3093         (WebCore::GraphicsContext::fillRect):
3094         (WebCore::GraphicsContext::strokePath):
3095         (WebCore::GraphicsContext::strokeRect):
3096
3097 2009-11-08  David Levin  <levin@chromium.org>
3098
3099         Unreviewed build fix for chromium.
3100
3101         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
3102         Clean up GraphicsContext's current concept of ColorSpace
3103
3104         * platform/graphics/skia/GraphicsContextSkia.cpp:
3105         (WebCore::GraphicsContext::fillPath):
3106         (WebCore::GraphicsContext::fillRect):
3107         (WebCore::GraphicsContext::strokePath):
3108         (WebCore::GraphicsContext::strokeRect):
3109
3110 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
3111
3112         Reviewed by Timothy Hatcher.
3113
3114         Web Inspector: [REGRESSION] committing style edit
3115         clears elements panel selection.
3116
3117         https://bugs.webkit.org/show_bug.cgi?id=31242
3118
3119         * inspector/front-end/ElementsTreeOutline.js:
3120         (WebInspector.ElementsTreeOutline.prototype.update):
3121         * inspector/front-end/StylesSidebarPane.js:
3122         (WebInspector.StylePropertyTreeElement.prototype.):
3123         (WebInspector.StylePropertyTreeElement.prototype):
3124
3125 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
3126
3127         Reviewed by Holger Freyther.
3128
3129         ResourceRequest to be class instead of struct
3130         https://bugs.webkit.org/show_bug.cgi?id=30670
3131
3132         Started as a compilation fix for Symbian where the compiler makes a distinction between
3133         class and struct in function argument signatures.
3134         Changed all forward declarations of ResourceRequest to have class in the forward
3135         declaration instead of struct and changed the definition of ResourceRequest to be class
3136         and added access qualifiers where missing. Additionally two references of friend
3137         struct ResourceRequestBase changed to class instead.
3138
3139         * history/HistoryItem.h:
3140         * inspector/InspectorController.h:
3141         * inspector/InspectorResource.h:
3142         * loader/DocumentThreadableLoader.h:
3143         * loader/FrameLoaderClient.h:
3144         * loader/MainResourceLoader.h:
3145         * loader/ResourceLoadNotifier.h:
3146         * loader/SubresourceLoader.h:
3147         * loader/SubresourceLoaderClient.h:
3148         * loader/ThreadableLoader.h:
3149         * loader/WorkerThreadableLoader.h:
3150         * loader/appcache/ApplicationCache.h:
3151         * loader/appcache/ApplicationCacheHost.h:
3152         * platform/CrossThreadCopier.h:
3153         * platform/network/ResourceHandle.h:
3154         * platform/network/ResourceHandleClient.h:
3155         * platform/network/ResourceRequestBase.h:
3156         * platform/network/cf/ResourceRequest.h:
3157         * platform/network/cf/ResourceRequestCFNet.h:
3158         * platform/network/chromium/ResourceRequest.h:
3159         * platform/network/curl/ResourceRequest.h:
3160         * platform/network/qt/ResourceRequest.h:
3161         * platform/network/soup/ResourceRequest.h:
3162         * xml/XMLHttpRequest.h:
3163
3164 2009-11-08  Dan Bernstein  <mitz@apple.com>
3165
3166         Reviewed by Simon Fraser.
3167
3168         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
3169         below FrameView::layout
3170         https://bugs.webkit.org/show_bug.cgi?id=31093
3171
3172         Test: fast/block/positioning/relative-positioned-inline-container.html
3173
3174         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
3175         to mark the object for layout, doing so without marking its ancestors.
3176         However, RenderBlock::skipLeadingWhitespace and
3177         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
3178         positioned inline container, causing it to be marked for layout without
3179         ever going back to give it layout, and thus layout could end with a
3180         dirty object still in the tree, leading to all sorts of badness.
3181
3182         The fix is to revert setStaticY() to not marking the object dirty, and
3183         instead do it in the call sites that require it, which are in
3184         RenderBlock and RenderFlexibleBox.
3185
3186         * rendering/RenderBlock.cpp:
3187         (WebCore::RenderBlock::adjustPositionedBlock):
3188         * rendering/RenderFlexibleBox.cpp:
3189         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3190         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3191         * rendering/RenderLayer.cpp:
3192         * rendering/RenderLayer.h:
3193         (WebCore::RenderLayer::setStaticY):
3194
3195 2009-11-07  Daniel Bates  <dbates@webkit.org>
3196
3197         Reviewed by Darin Adler.
3198
3199         https://bugs.webkit.org/show_bug.cgi?id=20780
3200         
3201         Fixes an issue where the onchange event handler is not fired when the 
3202         input field is autocompleted.
3203         
3204         We cannot test this using DRT since DRT cannot emulate autocompletion.
3205         So, a manual-test is included.
3206
3207         Tests: manual-tests/autocompletion-fire-onchange.html
3208
3209         * manual-tests/autocompletion-fire-onchange.html: Added.
3210         * rendering/RenderTextControl.cpp:
3211         (WebCore::RenderTextControl::setInnerTextValue):
3212
3213 2009-11-07  Benjamin Otte  <otte@gnome.org>
3214
3215         Reviewed by Holger Freyther.
3216
3217         Mark redrawn areas on image surfaces as dirty.
3218
3219         This is required to conform to the Cairo API, but is currently only
3220         used by debugging tools like cairo-trace.
3221
3222         * platform/graphics/cairo/ImageBufferCairo.cpp:
3223         (WebCore::ImageBuffer::platformTransformColorSpace):
3224         (WebCore::putImageData):
3225
3226 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3227
3228         Reviewed by Xan Lopez.
3229
3230         https://bugs.webkit.org/show_bug.cgi?id=30878
3231         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
3232
3233         If the end_offset is -1, use the String length as the end_offset.
3234
3235         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3236         (webkit_accessible_text_get_text):
3237
3238 2009-11-06  Beth Dakin  <bdakin@apple.com>
3239
3240         Reviewed by Adele Peterson.
3241
3242         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
3243         GraphicsContext's current concept of ColorSpace
3244
3245         ColorSpace is now called ColorType. The variables on the state we 
3246         appropriately re-named as well. I removed strokeColorSpace() and 
3247         fillColorSpace() from GraphicsContext since they were never called. 
3248
3249         * platform/graphics/GraphicsContext.cpp:
3250         (WebCore::GraphicsContext::setStrokeColor):
3251         (WebCore::GraphicsContext::setFillColor):
3252         (WebCore::GraphicsContext::setStrokePattern):
3253         (WebCore::GraphicsContext::setFillPattern):
3254         (WebCore::GraphicsContext::setStrokeGradient):
3255         (WebCore::GraphicsContext::setFillGradient):
3256         * platform/graphics/GraphicsContext.h:
3257         (WebCore::):
3258         * platform/graphics/GraphicsContextPrivate.h:
3259         (WebCore::GraphicsContextState::GraphicsContextState):
3260         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3261         (WebCore::GraphicsContext::fillPath):
3262         (WebCore::GraphicsContext::strokePath):
3263         * platform/graphics/cg/GraphicsContextCG.cpp:
3264         (WebCore::calculateDrawingMode):
3265         (WebCore::GraphicsContext::drawPath):
3266         (WebCore::GraphicsContext::fillPath):
3267         (WebCore::GraphicsContext::strokePath):
3268         (WebCore::GraphicsContext::fillRect):
3269         (WebCore::GraphicsContext::strokeRect):
3270         * platform/graphics/qt/GraphicsContextQt.cpp:
3271         (WebCore::GraphicsContext::fillPath):
3272         (WebCore::GraphicsContext::strokePath):
3273         (WebCore::GraphicsContext::fillRect):
3274         * platform/graphics/wince/GraphicsContextWince.cpp:
3275         (WebCore::GraphicsContext::fillPath):
3276         (WebCore::GraphicsContext::fillRect):
3277
3278 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
3279
3280         Reviewed by Tim Hatcher.
3281
3282         Fixes <http://webkit.org/b/31177>.
3283         Web Inspector: Bind backspace to delete cookies and DOM Storage.
3284         
3285         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
3286         places in the inspector can use editing in DataGrid (added a FIXME for
3287         some stuff that needs to be generalized).
3288         
3289         Also added deleting functionality to DataGrid, and implemented it for
3290         Cookies and DOM Storage. The reason this patch is so big is because of
3291         the refactoring of editing code, which won't be used yet in a cross-datagrid
3292         way, but should be able to.
3293         
3294         Additionally, moved the callbacks members from DOMStorageDataGrid to
3295         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
3296         make the architecture of DOM Storage look a lot more like the Cookies view.
3297         
3298         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
3299         inspector from beeping at you when you delete an element.
3300
3301         * WebCore.gypi: Removed DOMStorageDataGrid.
3302         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
3303         * inspector/front-end/CookieItemsView.js:
3304         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
3305         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
3306         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
3307         * inspector/front-end/DOMStorageDataGrid.js: Removed.
3308         * inspector/front-end/DOMStorageItemsView.js:
3309         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
3310         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
3311         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
3312         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
3313         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
3314         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
3315         * inspector/front-end/DataGrid.js:
3316         (WebInspector.DataGrid):
3317         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
3318         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
3319         (WebInspector.DataGrid.prototype._startEditing): Ditto.
3320         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
3321         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
3322         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
3323         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
3324         * inspector/front-end/ElementsTreeOutline.js:
3325         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
3326         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
3327         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
3328
3329 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3330
3331         Qt build fix: added an ExecState parameter.
3332
3333         * bridge/qt/qt_runtime.cpp:
3334         (JSC::Bindings::convertValueToQVariant):
3335         (JSC::Bindings::convertQVariantToValue):
3336
3337 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3338
3339         https://bugs.webkit.org/show_bug.cgi?id=31197
3340         Implemented a timezone cache not based on Mac OS X's notify_check API.
3341
3342         Updated for JavaScriptCore internal API change.
3343
3344         * bridge/qt/qt_runtime.cpp:
3345         (JSC::Bindings::convertValueToQVariant):
3346         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
3347
3348         * platform/network/HTTPParsers.cpp:
3349         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
3350         (This function probably shouldn't be using a JavaScript date parser
3351         to begin with, but oh well.)
3352
3353 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3354
3355         Reviewed by Adam Barth.
3356
3357         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
3358         which affects Chromium only.
3359         
3360         Changes to V8HTMLDocumentCustom.cpp are as below:-
3361         1. The HTMLDocumentOpen function would cause a crash in Chromium if
3362            there was no calling javascript context. We now check for this case
3363            and pass in NULL to the HTMLDocument::open function which can handle
3364            a NULL document parameter.
3365         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
3366            had ASSERTS for a NULL caller frame, which was bogus as it would crash
3367            anyway. We now check for this case and return a failure.
3368            
3369         Changes to V8DOMWindowCustom.cpp are as below:-
3370         1. Instead of failing the window.open call made by NPAPI for lack of a
3371            calling javascript context, we now use the entered context as the calling
3372            context.
3373
3374         Tests: plugins/document-open.html
3375                plugins/window-open.html
3376
3377         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3378         (WebCore::CALLBACK_FUNC_DECL):
3379         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3380         (WebCore::CALLBACK_FUNC_DECL):
3381
3382 2009-11-06  Steve Block  <steveblock@google.com>
3383
3384         Reviewed by Eric Seidel.
3385
3386         Geolocation error code UNKNOWN_ERROR is deprecated.
3387         https://bugs.webkit.org/show_bug.cgi?id=31184
3388
3389         Remove this error code from PositionError, both for use from C++ code and from the JS object.
3390
3391         Updated fast/dom/Geolocation/error.html to test this.
3392
3393         * page/PositionError.h: Modified.
3394         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
3395         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
3396         * page/Geolocation.cpp: Modified.
3397         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3398         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
3399         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3400
3401 2009-11-06  Dirk Schulze  <krit@webkit.org>
3402
3403         Reviewed by Nikolas Zimmermann.
3404
3405         feMorphology filter is not implemented
3406         [https://bugs.webkit.org/show_bug.cgi?id=5863]
3407
3408         The Implementation of feMorphology.
3409         
3410         Test: We have allready a test for feMorphology
3411               svg/W3C-SVG-1.1/filters-morph-01-f.svg
3412
3413         * svg/graphics/filters/SVGFEMorphology.cpp:
3414         (WebCore::FEMorphology::apply):
3415
3416 2009-11-06  Steve Block  <steveblock@google.com>
3417
3418         Reviewed by Eric Seidel.
3419
3420         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3421         https://bugs.webkit.org/show_bug.cgi?id=31209
3422
3423         Build fix only. No new tests possible.
3424
3425         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3426
3427 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3428
3429         Reviewed by David Levin.
3430
3431         V8 bindings do not support SharedWorkers as event targets
3432         https://bugs.webkit.org/show_bug.cgi?id=31199
3433
3434         No new tests because existing layout tests suffice (they currently
3435         crash on Chromium)
3436
3437         * bindings/v8/V8DOMWrapper.cpp:
3438         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3439         Added clause to create a DOM wrapper for SharedWorkers.
3440
3441 2009-11-06  Anton Muhin  <antonm@chromium.org>
3442
3443         Reviewed by Adam Barth.
3444
3445         Do not unnecessarly synchronzie in weak reference callbacks.
3446         https://bugs.webkit.org/show_bug.cgi?id=31191
3447
3448         * bindings/v8/DOMData.h:
3449         (WebCore::DOMData::handleWeakObject):
3450
3451 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3452
3453         Reviewed by Pavel Feldman.
3454
3455         Fix resource content search.
3456         https://bugs.webkit.org/show_bug.cgi?id=31202
3457
3458         * inspector/front-end/AbstractTimelinePanel.js:
3459         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3460         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3461         * inspector/front-end/TimelinePanel.js:
3462         (WebInspector.TimelineGraph.prototype.refresh):
3463
3464 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3465
3466         Reviewed by Eric Seidel.
3467
3468         Fix ASSERT(currentStyle = renderStyle()).
3469         https://bugs.webkit.org/show_bug.cgi?id=31152
3470
3471         * dom/Element.cpp:
3472         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3473
3474 2009-11-05  Alpha Lam  <hclam@chromium.org>
3475
3476         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3477
3478         * bindings/v8/V8GCController.cpp:
3479         (WebCore::V8GCController::gcEpilogue):
3480         * bindings/v8/V8GCController.h:
3481         * bindings/v8/V8Proxy.cpp:
3482         (WebCore::V8Proxy::evaluate):
3483         (WebCore::V8Proxy::runScript):
3484         (WebCore::V8Proxy::callFunction):
3485
3486 2009-11-05  Adam Barth  <abarth@webkit.org>
3487
3488         Reviewed by Sam Weinig.
3489
3490         Cross-domain access to stylesheet text should not be allowed
3491         https://bugs.webkit.org/show_bug.cgi?id=20527
3492
3493         Check whether whether the current document can read the cssRules from
3494         the style sheet.  Firefox throws a security error here, but we return
3495         null instead because that's what we usually do in these cases.
3496
3497         Test: http/tests/security/cannot-read-cssrules-redirect.html
3498               http/tests/security/cannot-read-cssrules.html
3499
3500         * css/CSSStyleSheet.cpp:
3501         (WebCore::CSSStyleSheet::cssRules):
3502
3503 2009-11-05  Steve Block  <steveblock@google.com>
3504
3505         Reviewed by Eric Seidel.
3506
3507         If the Geolocation service fails to start, invoke the error callback asynchronously.
3508         https://bugs.webkit.org/show_bug.cgi?id=28276
3509
3510         All Geolocation callbacks must be invoked asynchronously.
3511         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3512
3513         No new tests possible with current LayoutTestController.
3514
3515         * page/Geolocation.cpp:
3516         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3517         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3518         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3519
3520 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3521
3522         Reviewed by Eric Seidel.
3523
3524         Removed the "this is part of the KDE project" comments from 
3525         all *.h, *.cpp, *.idl, and *.pm files.
3526         
3527         https://bugs.webkit.org/show_bug.cgi?id=31167
3528         
3529         The maintenance and architecture page in the project wiki lists
3530         this as a task.
3531         
3532         This change includes no changes or additions to test cases 
3533         since the change affects only comments.
3534
3535         * bindings/scripts/CodeGeneratorV8.pm:
3536         * bindings/scripts/IDLParser.pm:
3537         * bindings/scripts/IDLStructure.pm:
3538         * css/CSSInheritedValue.cpp:
3539         * css/CSSInitialValue.cpp:
3540         * css/CSSMediaRule.cpp:
3541         * css/CSSNamespace.h:
3542         * css/CSSProperty.cpp:
3543         * css/CSSProperty.h:
3544         * css/CSSRuleList.cpp:
3545         * css/CSSRuleList.h:
3546         * css/CSSSelector.h:
3547         * css/CSSValueList.cpp:
3548         * css/FontValue.cpp:
3549         * css/MediaFeatureNames.cpp:
3550         * css/MediaFeatureNames.h:
3551         * css/Pair.h:
3552         * css/SVGCSSStyleSelector.cpp:
3553         * css/ShadowValue.cpp:
3554         * css/StyleSheet.cpp:
3555         * css/StyleSheetList.cpp:
3556         * css/maketokenizer:
3557         * dom/BeforeUnloadEvent.cpp:
3558         * dom/BeforeUnloadEvent.h:
3559         * dom/CSSMappedAttributeDeclaration.cpp:
3560         * dom/EventNames.cpp:
3561         * dom/EventTarget.cpp:
3562         * dom/MappedAttributeEntry.h:
3563         * dom/MouseRelatedEvent.h:
3564         * dom/RangeException.h:
3565         * dom/StyleElement.h:
3566         * dom/Tokenizer.h:
3567         * html/HTMLHeadElement.h:
3568         * html/HTMLHeadingElement.cpp:
3569         * html/HTMLHeadingElement.h:
3570         * html/HTMLHtmlElement.h:
3571         * html/HTMLImageLoader.h:
3572         * html/HTMLMetaElement.h:
3573         * html/HTMLModElement.cpp:
3574         * html/HTMLModElement.h:
3575         * html/HTMLOptionsCollection.cpp:
3576         * html/HTMLPlugInElement.cpp:
3577         * html/HTMLPreElement.cpp:
3578         * html/HTMLPreElement.h:
3579         * html/HTMLTableCellElement.cpp:
3580         * html/HTMLTableCellElement.h:
3581         * html/HTMLTableColElement.cpp:
3582         * html/HTMLTableColElement.h:
3583         * html/HTMLTablePartElement.cpp:
3584         * html/HTMLTablePartElement.h:
3585         * html/HTMLTitleElement.h:
3586         * page/MouseEventWithHitTestResults.h:
3587         * platform/StaticConstructors.h:
3588         * platform/text/AtomicStringImpl.h:
3589         * platform/text/qt/TextBreakIteratorQt.cpp:
3590         * rendering/AutoTableLayout.h:
3591         * rendering/CounterNode.cpp:
3592         * rendering/EllipsisBox.cpp:
3593         * rendering/EllipsisBox.h:
3594         * rendering/FixedTableLayout.cpp:
3595         * rendering/FixedTableLayout.h:
3596         * rendering/HitTestRequest.h:
3597         * rendering/HitTestResult.h:
3598         * rendering/InlineRunBox.h:
3599         * rendering/PointerEventsHitRules.cpp:
3600         * rendering/PointerEventsHitRules.h:
3601         * rendering/RenderBR.cpp:
3602         * rendering/RenderBR.h:
3603         * rendering/RenderButton.cpp:
3604         * rendering/RenderButton.h:
3605         * rendering/RenderFieldset.cpp:
3606         * rendering/RenderFrameSet.cpp:
3607         * rendering/RenderListItem.cpp:
3608         * rendering/RenderTableRow.cpp:
3609         * rendering/RenderView.h:
3610         * rendering/RootInlineBox.h:
3611         * rendering/SVGInlineTextBox.cpp:
3612         * rendering/SVGInlineTextBox.h:
3613         * rendering/TableLayout.h:
3614         * rendering/break_lines.h:
3615         * rendering/style/SVGRenderStyle.cpp:
3616         * rendering/style/SVGRenderStyle.h:
3617         * rendering/style/SVGRenderStyleDefs.cpp:
3618         * rendering/style/SVGRenderStyleDefs.h:
3619         * svg/GradientAttributes.h:
3620         * svg/LinearGradientAttributes.h:
3621         * svg/PatternAttributes.h:
3622         * svg/RadialGradientAttributes.h:
3623         * svg/SVGAElement.cpp:
3624         * svg/SVGAngle.idl:
3625         * svg/SVGAnimateColorElement.cpp:
3626         * svg/SVGAnimateColorElement.h:
3627         * svg/SVGAnimateElement.cpp:
3628         * svg/SVGAnimateElement.h:
3629         * svg/SVGAnimateTransformElement.h:
3630         * svg/SVGAnimatedPathData.cpp:
3631         * svg/SVGAnimatedPathData.h:
3632         * svg/SVGAnimatedPoints.cpp:
3633         * svg/SVGAnimatedPoints.h:
3634    &