LayoutTests:
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-26  Darin Adler  <darin@apple.com>
2
3         Reviewed by Anders.
4
5         - removed non-deterministic behavior in editing that was causing
6           give inconsistent results for editing/pasteboard/copy-paste-bidi.html
7
8         * editing/ReplaceSelectionCommand.cpp:
9         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
10         Use two vectors instead of a map: more efficient, deterministic. There was no
11         reason to use a hash table.
12
13 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
14
15         Reviewed by Anders.
16
17         - .5% speed improvement by avoiding excess CFURLRef allocation
18
19         * loader/CachedResource.cpp:
20         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
21         here for later reuse.
22         * loader/CachedResource.h:
23         * loader/mac/LoaderFunctionsMac.mm:
24         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
25
26 2006-10-25  Darin Adler  <darin@apple.com>
27
28         Reviewed by Anders.
29
30         - removed 55 methods from WebCoreFrameBridge
31         - changed callers to use Frame directly instead
32         - put FrameLoaderTypes.h types into the WebCore namespace
33         - first steps to get FrameLoader.h ready for cross-platform duty
34
35         * WebCore.exp:
36         * WebCore.xcodeproj/project.pbxproj:
37         * bridge/mac/BrowserExtensionMac.mm:
38         (WebCore::BrowserExtensionMac::createNewWindow):
39         * bridge/mac/FrameMac.h:
40         * bridge/mac/FrameMac.mm:
41         (WebCore::FrameMac::loadRequest):
42         (WebCore::FrameMac::startRedirectionTimer):
43         (WebCore::FrameMac::stopRedirectionTimer):
44         (WebCore::FrameMac::passSubframeEventToSubframe):
45         (WebCore::FrameMac::handledOnloadEvents):
46         (WebCore::FrameMac::isLoadTypeReload):
47         * bridge/mac/WebCoreFrameBridge.h:
48         * bridge/mac/WebCoreFrameBridge.mm:
49         (-[WebCoreFrameBridge executionContextForView:]):
50         (updateRenderingForBindings):
51         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
52         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
53         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
54         (-[WebCoreFrameBridge installInFrame:]):
55         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
56         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
57         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
58         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
59         (stringByCollapsingNonPrintingCharacters):
60         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
61         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
62         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
63         * loader/FrameLoaderTypes.h:
64         * loader/mac/FrameLoader.h:
65         * loader/mac/FrameLoader.mm:
66         (WebCore::FrameLoader::FrameLoader):
67         (WebCore::FrameLoader::setupForReplace):
68         (WebCore::FrameLoader::load):
69         (WebCore::FrameLoader::activeDocumentLoader):
70         (WebCore::FrameLoader::state):
71         (WebCore::FrameLoader::setState):
72         (WebCore::FrameLoader::clearProvisionalLoad):
73         (WebCore::FrameLoader::markLoadComplete):
74         (WebCore::FrameLoader::commitProvisionalLoad):
75         (WebCore::FrameLoader::receivedMainResourceError):
76         (WebCore::FrameLoader::handleFallbackContent):
77         (WebCore::FrameLoader::isLoadingMainFrame):
78         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
79         (WebCore::FrameLoader::continueAfterNavigationPolicy):
80         (WebCore::FrameLoader::continueAfterWillSubmitForm):
81         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
82         (WebCore::FrameLoader::transitionToCommitted):
83         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
84         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
85         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
86         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
87         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
88         * loader/mac/ImageDocumentMac.mm:
89         (WebCore::finishImageLoad):
90         * loader/mac/WebDocumentLoader.mm:
91         (WebCore::DocumentLoader::isLoadingInAPISense):
92         * loader/mac/WebMainResourceLoader.h:
93         * loader/mac/WebMainResourceLoader.mm:
94         (WebCore::MainResourceLoader::continueAfterContentPolicy):
95         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
96         * loader/mac/WebSubresourceLoader.mm:
97         (-[WebCoreSubresourceHandle initWithLoader:]):
98         * platform/mac/ListBoxMac.mm:
99         (-[WebCoreTableView keyDown:]):
100         (-[WebCoreTableView keyUp:]):
101         * platform/mac/WebCoreTextField.mm:
102         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
103
104 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
105
106         Reviewed by Darin.
107
108         Printing fixes
109
110         * page/Frame.cpp:
111         (WebCore::Frame::adjustPageHeight):
112         * page/Frame.h:
113         (WebCore::Frame::setupRootForPrinting):
114         (WebCore::Frame::computePageRects):
115
116 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
117
118         Reviewed by Geoff.
119
120         <rdar://problem/4799088>
121         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
122
123         * loader/mac/WebSubresourceLoader.h:
124         * loader/mac/WebSubresourceLoader.mm:
125         (-[WebCoreSubresourceHandle initWithLoader:]):
126         Set the HTTP method before the HTTP body.
127
128 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
129
130         Reviewed by Adam.
131
132         Renamed WebFrameLoader to FrameLoader, to match class name.
133
134         * WebCore.xcodeproj/project.pbxproj:
135         * bridge/mac/FrameMac.mm:
136         * bridge/mac/WebCoreFrameBridge.mm:
137         * loader/mac/FrameLoader.mm: Added.
138         * loader/mac/IconLoaderMac.mm:
139         * loader/mac/WebDocumentLoader.mm:
140         * loader/mac/WebFrameLoader.h: Removed.
141         * loader/mac/WebFrameLoader.mm: Removed.
142         * loader/mac/WebLoader.mm:
143         * loader/mac/WebMainResourceLoader.mm:
144         * loader/mac/WebNetscapePlugInStreamLoader.mm:
145         * loader/mac/WebSubresourceLoader.mm:
146
147 2006-10-25  Darin Adler  <darin@apple.com>
148
149         - fix full builds
150
151         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
152
153 2006-10-25  David Smith  <catfish.man@gmail.com>
154
155         Reviewed by Mitz.
156
157         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
158         http://bugs.webkit.org/show_bug.cgi?id=11411
159
160         * bridge/mac/WebCoreFrameBridge.mm:
161         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
162
163 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
164
165         Rubber stamped by Mitz.
166
167         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
168
169         * WebCore.xcodeproj/project.pbxproj:
170         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
171         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
172         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
173
174 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
175
176         Rubber stamped by Mark.
177
178         - remove no longer existing symbol that was breaking linking
179
180         * WebCore.exp:
181
182 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
183
184         Reviewed by Mitz.
185         
186         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
187         http://bugs.webkit.org/show_bug.cgi?id=11212
188
189         I couldn't figure out how to write a test case.
190
191         * bindings/js/kjs_window.cpp:
192         (KJS::Window::clear): Avoid crashing if already detached.
193         * bridge/mac/FrameMac.h:
194         * bridge/mac/FrameMac.mm:
195         (WebCore::FrameMac::clear): Change prototype to make this a proper
196         overload for Frame::clear once again(!).
197
198 2006-10-24  Darin Adler  <darin@apple.com>
199
200         Reviewed by Anders.
201
202         - converted WebFrameLoaderClient to C++
203         - renamed frame->frameLoader() function to frame->loader()
204         - renamed [bridge impl] to [bridge _frame]
205         - removed some bridge methods
206
207         * WebCore.exp: Added more exports.
208         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
209         so it can be used in WebKit.
210
211         * bridge/mac/BrowserExtensionMac.mm:
212         (WebCore::BrowserExtensionMac::createNewWindow):
213         * bridge/mac/FrameMac.mm:
214         (WebCore::FrameMac::createFrame):
215         (WebCore::FrameMac::didFirstLayout):
216         * bridge/mac/WebCoreAXObject.mm:
217         (-[WebCoreAXObject rendererForView:]):
218         * bridge/mac/WebCoreFrameBridge.h:
219         * bridge/mac/WebCoreFrameBridge.mm:
220         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
221         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
222         (-[WebCoreFrameBridge setOpener:]):
223         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
224         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
225         (-[WebCoreFrameBridge setTitle:]):
226         (-[WebCoreFrameBridge originalRequestURL]):
227         (-[WebCoreFrameBridge isLoadTypeReload]):
228         (-[WebCoreFrameBridge frameDetached]):
229         (-[WebCoreFrameBridge tokenizerProcessedData]):
230         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
231         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
232         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
233         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
234         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
235         (-[WebCoreFrameBridge incomingReferrer]):
236         (-[WebCoreFrameBridge isReloading]):
237         (-[WebCoreFrameBridge handledOnloadEvents]):
238         (-[WebCoreFrameBridge mainResourceURLResponse]):
239         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
240         (-[WebCoreFrameBridge _frame]):
241         (-[WebCoreFrameBridge executionContextForView:]):
242         * bridge/mac/WebCorePageBridge.mm:
243         (-[WebCorePageBridge setMainFrame:]):
244         * dom/Position.cpp:
245         (WebCore::Position::upstream):
246         * loader/mac/IconLoaderMac.mm:
247         (IconLoader::notifyIconChanged):
248         * loader/mac/WebDocumentLoader.mm:
249         (WebCore::DocumentLoader::frameLoader):
250         (WebCore::DocumentLoader::stopLoading):
251         (WebCore::DocumentLoader::finishedLoading):
252         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
253         * loader/mac/WebFormState.mm:
254         (WebCore::FormState::FormState):
255         * loader/mac/WebFrameLoader.h:
256         * loader/mac/WebFrameLoader.mm:
257         (WebCore::FrameLoader::~FrameLoader):
258         (WebCore::FrameLoader::prepareForLoadStart):
259         (WebCore::FrameLoader::finalSetupForReplace):
260         (WebCore::FrameLoader::safeLoad):
261         (WebCore::FrameLoader::load):
262         (WebCore::FrameLoader::startLoading):
263         (WebCore::FrameLoader::stopLoadingSubframes):
264         (WebCore::FrameLoader::stopLoading):
265         (WebCore::FrameLoader::cancelPendingArchiveLoad):
266         (WebCore::FrameLoader::defersCallbacksChanged):
267         (WebCore::FrameLoader::setDefersCallbacks):
268         (WebCore::FrameLoader::setDocumentLoader):
269         (WebCore::FrameLoader::provisionalLoadStarted):
270         (WebCore::FrameLoader::clearProvisionalLoad):
271         (WebCore::FrameLoader::identifierForInitialRequest):
272         (WebCore::FrameLoader::willSendRequest):
273         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
274         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
275         (WebCore::FrameLoader::didReceiveResponse):
276         (WebCore::FrameLoader::didReceiveData):
277         (WebCore::FrameLoader::didFinishLoad):
278         (WebCore::FrameLoader::didFailToLoad):
279         (WebCore::FrameLoader::privateBrowsingEnabled):
280         (WebCore::FrameLoader::receivedMainResourceError):
281         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
282         (WebCore::FrameLoader::clientRedirected):
283         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
284         (WebCore::FrameLoader::closeOldDataSources):
285         (WebCore::FrameLoader::opened):
286         (WebCore::FrameLoader::commitProvisionalLoad):
287         (WebCore::FrameLoader::download):
288         (WebCore::FrameLoader::finishedLoading):
289         (WebCore::FrameLoader::notifyIconChanged):
290         (WebCore::FrameLoader::cancelledError):
291         (WebCore::FrameLoader::fileDoesNotExistError):
292         (WebCore::FrameLoader::willUseArchive):
293         (WebCore::FrameLoader::isArchiveLoadPending):
294         (WebCore::FrameLoader::handleUnimplementablePolicy):
295         (WebCore::FrameLoader::cannotShowMIMEType):
296         (WebCore::FrameLoader::interruptionForPolicyChangeError):
297         (WebCore::FrameLoader::canShowMIMEType):
298         (WebCore::FrameLoader::representationExistsForURLScheme):
299         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
300         (WebCore::FrameLoader::checkContentPolicy):
301         (WebCore::FrameLoader::reloadAllowingStaleData):
302         (WebCore::FrameLoader::reload):
303         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
304         (WebCore::FrameLoader::finishedLoadingDocument):
305         (WebCore::FrameLoader::committedLoad):
306         (WebCore::FrameLoader::revertToProvisional):
307         (WebCore::FrameLoader::setMainDocumentError):
308         (WebCore::FrameLoader::mainReceivedCompleteError):
309         (WebCore::FrameLoader::subframeIsLoading):
310         (WebCore::FrameLoader::willChangeTitle):
311         (WebCore::FrameLoader::didChangeTitle):
312         (WebCore::FrameLoader::checkNewWindowPolicy):
313         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
314         (WebCore::FrameLoader::checkNavigationPolicy):
315         (WebCore::FrameLoader::continueAfterNavigationPolicy):
316         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
317         (WebCore::FrameLoader::didFirstLayout):
318         (WebCore::FrameLoader::frameLoadCompleted):
319         (WebCore::FrameLoader::transitionToCommitted):
320         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
321         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
322         (WebCore::FrameLoader::sendRemainingDelegateMessages):
323         (WebCore::FrameLoader::requestFromDelegate):
324         (WebCore::FrameLoader::post):
325         (WebCore::FrameLoader::detachChildren):
326         (WebCore::FrameLoader::detachFromParent):
327         (WebCore::FrameLoader::addExtraFieldsToRequest):
328         (WebCore::FrameLoader::actionInformation):
329         (WebCore::FrameLoader::checkLoadComplete):
330         (WebCore::FrameLoader::setClient):
331         (WebCore::FrameLoader::client):
332         (WebCore::FrameLoaderClient::~FrameLoaderClient):
333         * loader/mac/WebFrameLoaderClient.h:
334         * loader/mac/WebLoader.mm:
335         (WebCore::WebResourceLoader::frameLoader):
336         * loader/mac/WebSubresourceLoader.mm:
337         (-[WebCoreSubresourceHandle initWithLoader:]):
338         * page/Frame.cpp:
339         (WebCore::Frame::loader):
340         * page/Frame.h:
341         * platform/mac/SliderMac.mm:
342         (Slider::focusPolicy):
343
344 2006-10-24  Darin Adler  <darin@apple.com>
345
346         Rubber stamped by Anders.
347
348         - get rid of the assertion firing while running the layout tests
349
350         This does not fix the real problem, which is that we need to map offsets within
351         possibly-text-transformed text in the render tree to DOM tree offsets and vice
352         versa -- but it gets the tests running again.
353
354         * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
355
356 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
357
358         Reviewed by Oliver.
359
360         - more ResourceLoader cleanup
361             - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
362             - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
363         
364         * loader/LoaderFunctions.h:
365         * loader/mac/LoaderFunctionsMac.mm:
366         (WebCore::ServeSynchronousRequest):
367         * loader/mac/WebSubresourceLoader.mm:
368         (-[WebCoreSubresourceHandle initWithLoader:]):
369         * platform/network/HTTPHeaderMap.h: Added.
370         * platform/network/ResourceLoader.cpp:
371         (WebCore::ResourceLoader::requestHeaders):
372         * platform/network/ResourceLoader.h:
373         * platform/network/ResourceRequest.h:
374         * platform/network/cf/ResourceLoaderCFNet.cpp:
375         (WebCore::addHeadersFromHashMap):
376         * xml/xmlhttprequest.cpp:
377         (WebCore::XMLHttpRequest::send):
378         * xml/xmlhttprequest.h:
379
380 2006-10-24  Justin Garcia  <justin.garcia@apple.com>
381
382         Reviewed by darin
383
384         <http://bugs.webkit.org/show_bug.cgi?id=10993>
385         GMail Editor: Caret doesn't always position itself after list marker
386         
387         List creation uses moveParagraphs to push content into list items.  
388         moveParagraphs uses a TextIterator to restore selections after moves.
389         Some characters emitted by the TextIterator had bad ranges associated
390         with them.  rangeFromLocationAndLength would skip past the range it
391         should have used when asked for ranges of length 0.
392
393         * editing/TextIterator.cpp:
394         (WebCore::TextIterator::TextIterator): No longer need to initialize a
395         removed member variable.
396         (WebCore::TextIterator::advance): An extra newline is emitted when leaving
397         some blocks.  Use the same range for this newline as for the first newline.
398         We should remove this code and just emit two '\n's.
399         (WebCore::TextIterator::handleTextNode): Setup m_range.
400         (WebCore::TextIterator::handleTextBox): Ditto.
401         (WebCore::TextIterator::handleReplacedElement): Ditto.
402         (WebCore::TextIterator::handleNonTextNode): Ditto.
403         (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
404         in the block we're leaving to that VP after that one.
405         (WebCore::TextIterator::emitCharacter): This function now takes in the start
406         and the end of the range associated with the emited character, and sets up m_range.
407         (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd), 
408         return the end of the range used to create the iterator, as a convenience to
409         callers that use call range() on an iterator that is atEnd.
410         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
411         Same as the changes made to TextIterator's constructor.
412         (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
413         a null m_positionNode to signal that we're finished.
414         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
415         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
416         made to TextIterator.
417         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
418         (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
419         (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
420         TextIterator::range.
421         (WebCore::CharacterIterator::range): This function assumed that an iterator's
422         range() was safe to modify.
423         (WebCore::TextIterator::rangeFromLocationAndLength):
424         If the range we're looking for starts in the current chunk, this function assumed
425         that if the chunk started in a text node, it would end in the same text node.  This
426         is no longer the case.
427         If the range we're looking for starts in the middle of the current chunk, I assume
428         that the chunk is inside a text node, because those are the only chunks with length
429         greater than one at the moment.
430         If the range we're looking for is a zero length range that starts/ends at the end of the
431         current chunk, we used to return the start of the next chunk, but that's wrong and
432         is what caused this bug.
433         * editing/TextIterator.h:
434         (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
435         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
436         * editing/visible_units.cpp:
437         (WebCore::previousBoundary): Cleaned up by using a convenience function.
438         (WebCore::nextBoundary): Ditto.
439
440 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
441
442         Reviewed by Maciej.
443
444         * platform/network/mac/ResourceLoaderMac.mm:
445         (WebCore::ResourceLoader::start):
446         Don't retain the header dictionary.
447
448 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
449
450         Reviewed by Anders.
451
452         Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
453         REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref() 
454         running svg/custom/svg/custom/gradient-attr-update.svg
455         
456         SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
457
458         * ksvg2/css/SVGRenderStyle.h:
459         * ksvg2/css/SVGRenderStyleDefs.h:
460
461 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
462
463         Reviewed by Mitz.
464
465         * platform/network/ResourceRequest.h:
466         (WebCore::ResourceRequest::ResourceRequest):
467         Set the http method to "GET" in the constructor that takes a String.
468
469 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
470
471         Reviewed by Tim H.
472
473         Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
474         and rendering/SVG* respectively.  Fix Xcode project and
475         CMakeLists.txt to account for the moves.
476
477         * CMakeLists.txt:
478         * WebCore.xcodeproj/project.pbxproj:
479         * kcanvas/RenderForeignObject.cpp: Removed.
480         * kcanvas/RenderForeignObject.h: Removed.
481         * kcanvas/RenderPath.cpp: Removed.
482         * kcanvas/RenderPath.h: Removed.
483         * kcanvas/RenderSVGContainer.cpp: Removed.
484         * kcanvas/RenderSVGContainer.h: Removed.
485         * kcanvas/RenderSVGImage.cpp: Removed.
486         * kcanvas/RenderSVGImage.h: Removed.
487         * kcanvas/RenderSVGInline.cpp: Removed.
488         * kcanvas/RenderSVGInline.h: Removed.
489         * kcanvas/RenderSVGInlineText.cpp: Removed.
490         * kcanvas/RenderSVGInlineText.h: Removed.
491         * kcanvas/RenderSVGTSpan.cpp: Removed.
492         * kcanvas/RenderSVGTSpan.h: Removed.
493         * kcanvas/RenderSVGText.cpp: Removed.
494         * kcanvas/RenderSVGText.h: Removed.
495         * kcanvas/SVGInlineFlowBox.cpp: Removed.
496         * kcanvas/SVGInlineFlowBox.h: Removed.
497         * kcanvas/SVGRootInlineBox.cpp: Removed.
498         * kcanvas/SVGRootInlineBox.h: Removed.
499
500 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
501
502         Rolling back in, now fixed:
503         
504         Nixed a few more redundant loading functions in Frame. Did my best to update
505         the non-Mac builds.
506
507         * bridge/mac/FrameMac.h:
508         * bridge/mac/FrameMac.mm:
509         (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
510         always 'true', because changing it broke the world, and testing seems to
511         indicate that the one caller that might have passed 'false' didn't need to.
512         * page/Frame.cpp:
513         (WebCore::Frame::requestFrame):
514         (WebCore::Frame::frameLoader):
515         (WebCore::Frame::redirectionTimerFired):
516         * page/Frame.h:
517         * platform/gdk/FrameGdk.cpp:
518         * platform/gdk/FrameGdk.h:
519         * platform/gdk/TemporaryLinkStubs.cpp:
520         (FrameGdk::issueCopyCommand):
521         * platform/qt/FrameQt.cpp:
522         * platform/qt/FrameQt.h:
523         * platform/win/TemporaryLinkStubs.cpp:
524         (WebCore::FrameWin::shouldInterruptJavaScript):
525         (WebCore::FrameWin::issueCopyCommand):
526
527 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
528
529         Fix the build (Update for changes to ResourceLoader)
530         
531         * platform/network/cf/ResourceLoaderCFNet.cpp:
532         (WebCore::addHeadersFromHashMap):
533         (WebCore::ResourceLoader::start):
534         (WebCore::ResourceLoader::cancel):
535
536 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
537
538         Reviewed by Mitz.
539
540         Change #includes using <kcanvas/*.h> to use "*.h" instead
541         to prepare for moving the kcanvas files.
542
543         * kcanvas/RenderSVGContainer.h:
544         * ksvg2/svg/SVGAElement.cpp:
545         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
546         * ksvg2/svg/SVGFETileElement.cpp:
547         * ksvg2/svg/SVGStyledLocatableElement.cpp:
548         * ksvg2/svg/SVGStyledTransformableElement.cpp:
549
550 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
551
552         Reviewed by Darin.
553
554         - More movement towards the final network API.
555         
556         Changed ResourceLoader::create to take a ResurceRequest and start
557         the load. Removed methods relating to setting request
558         headers. Removed methods relating to metaData. Added some more
559         convenience methods to ResourceRequest.
560
561         * dom/XMLTokenizer.cpp:
562         (WebCore::openFunc):
563         * loader/LoaderFunctions.h:
564         * loader/icon/IconLoader.cpp:
565         (IconLoader::startLoading):
566         (IconLoader::didFinishLoading):
567         * loader/icon/IconLoader.h:
568         * loader/loader.cpp:
569         (WebCore::Loader::servePendingRequests):
570         * loader/mac/LoaderFunctionsMac.mm:
571         (WebCore::ServeSynchronousRequest):
572         * platform/gdk/FrameGdk.cpp:
573         (WebCore::FrameGdkClientDefault::openURL):
574         (WebCore::FrameGdkClientDefault::submitForm):
575         * platform/network/ResourceLoader.cpp:
576         (WebCore::ResourceLoader::ResourceLoader):
577         (WebCore::ResourceLoader::create):
578         (WebCore::ResourceLoader::responseHTTPHeadersAsString):
579         (WebCore::ResourceLoader::url):
580         (WebCore::ResourceLoader::postData):
581         (WebCore::ResourceLoader::method):
582         (WebCore::ResourceLoader::client):
583         * platform/network/ResourceLoader.h:
584         * platform/network/ResourceLoaderInternal.h:
585         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
586         * platform/network/ResourceRequest.h:
587         (WebCore::ResourceRequest::ResourceRequest):
588         (WebCore::ResourceRequest::httpAccept):
589         (WebCore::ResourceRequest::setHTTPAccept):
590         (WebCore::ResourceRequest::addHTTPHeaderFields):
591         * platform/network/mac/ResourceLoaderMac.mm:
592         (WebCore::ResourceLoader::start):
593         (WebCore::ResourceLoader::receivedResponse):
594         * platform/qt/FrameQtClient.cpp:
595         (WebCore::FrameQtClientDefault::openURL):
596         (WebCore::FrameQtClientDefault::submitForm):
597         * platform/win/TemporaryLinkStubs.cpp:
598         (WebCore::ResourceLoader::retrieveResponseEncoding):
599         * xml/XSLTProcessor.cpp:
600         (WebCore::docLoaderFunc):
601         * xml/xmlhttprequest.cpp:
602         (WebCore::XMLHttpRequest::send):
603         (WebCore::XMLHttpRequest::didFinishLoading):
604         (WebCore::XMLHttpRequest::didReceiveData):
605         * xml/xmlhttprequest.h:
606
607 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
608
609         Reviewed by Geoff.
610
611         * loader/FormData.cpp:
612         (WebCore::FormData::FormData):
613         * loader/FormData.h:
614         (WebCore::FormData::FormData):
615         Add new constructor that takes a void* and a size.
616
617 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
618
619         Rolling out my last change because it broke the world.
620
621         * bridge/mac/FrameMac.h:
622         * bridge/mac/FrameMac.mm:
623         (WebCore::FrameMac::openURL):
624         (WebCore::FrameMac::openURLRequest):
625         (WebCore::FrameMac::urlSelected):
626         * page/Frame.cpp:
627         (WebCore::Frame::openURL):
628         (WebCore::Frame::frameLoader):
629         (WebCore::Frame::requestFrame):
630         (WebCore::Frame::redirectionTimerFired):
631         * page/Frame.h:
632         * platform/gdk/FrameGdk.cpp:
633         (WebCore::FrameGdk::openURL):
634         * platform/gdk/FrameGdk.h:
635         * platform/gdk/TemporaryLinkStubs.cpp:
636         * platform/qt/FrameQt.cpp:
637         (WebCore::FrameQt::openURL):
638         (WebCore::FrameQt::openURLRequest):
639         * platform/qt/FrameQt.h:
640         * platform/win/TemporaryLinkStubs.cpp:
641         (WebCore::FrameWin::openURL):
642         (WebCore::FrameWin::openURLRequest):
643
644 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
645
646         Reviewed by Adam.
647
648         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11396
649
650         Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
651         anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
652         or broken.
653
654         * CMakeLists.txt:
655         * WebCore.xcodeproj/project.pbxproj:
656         * kcanvas/KCanvasTreeDebug.cpp:
657         (WebCore::operator<<):
658         (WebCore::writeStyle):
659         * kcanvas/RenderPath.cpp:
660         (WebCore::RenderPath::fillContains):
661         * kcanvas/device/KRenderingFillPainter.cpp:
662         * kcanvas/device/KRenderingFillPainter.h:
663         * kcanvas/device/KRenderingStrokePainter.cpp:
664         * kcanvas/device/KRenderingStrokePainter.h:
665         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
666         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
667         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
668         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
669         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
670         (WebCore::KRenderingPaintServerQt::setPenProperties):
671         * kcanvas/device/qt/KRenderingPaintServerQt.h:
672         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
673         (WebCore::KRenderingPaintServerSolidQt::setup):
674         * kcanvas/device/qt/RenderPathQt.cpp:
675         (WebCore::getPathStroke):
676         (WebCore::RenderPath::strokeBBox):
677         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
678         (WebCore::RenderPath::strokeBBox):
679         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
680         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
681         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
682         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
683         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
684         * kcanvas/device/quartz/QuartzSupport.h:
685         (WebCore::CGLineCapFromKC):
686         (WebCore::CGLineJoinFromKC):
687         * kcanvas/device/quartz/QuartzSupport.mm:
688         (WebCore::applyStrokeStyleToContext):
689         (WebCore::strokeBoundingBox):
690         * ksvg2/css/SVGCSSStyleSelector.cpp:
691         (WebCore::CSSStyleSelector::applySVGProperty):
692         * ksvg2/css/SVGRenderStyle.h:
693         (WebCore::SVGRenderStyle::InheritedFlags::):
694         * ksvg2/css/SVGRenderStyleDefs.h:
695         * ksvg2/misc/KCanvasRenderingStyle.cpp:
696         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
697         * ksvg2/misc/KCanvasRenderingStyle.h:
698         * ksvg2/svg/SVGFEImageElement.cpp:
699
700 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
701
702         Reviewed by Anders.
703
704         Nixed a few more redundant loading functions in Frame. Did my best to update
705         the non-Mac builds.
706
707         * bridge/mac/FrameMac.h:
708         * bridge/mac/FrameMac.mm:
709         (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture
710         to actually check for a user gesture. New callers rely on this behavior,
711         and it seems like the previous behavior must have been a bug.
712         * page/Frame.cpp:
713         (WebCore::Frame::requestFrame):
714         (WebCore::Frame::frameLoader):
715         (WebCore::Frame::redirectionTimerFired):
716         * page/Frame.h:
717         * platform/gdk/FrameGdk.cpp:
718         * platform/gdk/FrameGdk.h:
719         * platform/gdk/TemporaryLinkStubs.cpp:
720         (FrameGdk::issueCopyCommand):
721         * platform/qt/FrameQt.cpp:
722         * platform/qt/FrameQt.h:
723         * platform/win/TemporaryLinkStubs.cpp:
724         (WebCore::FrameWin::shouldInterruptJavaScript):
725         (WebCore::FrameWin::issueCopyCommand):
726
727 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
728
729         Reviewed by Maciej.
730
731         Fix Qt/Linux build.
732
733         - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
734         - Fix CMakeLists.txt to include platform/network.
735
736         * CMakeLists.txt:
737         * platform/qt/BrowserExtensionQt.cpp: Removed.
738         * platform/qt/BrowserExtensionQt.h: Removed.
739         * platform/qt/FrameQt.cpp:
740         (WebCore::FrameQt::FrameQt):
741         (WebCore::FrameQt::createNewWindow):
742         (WebCore::FrameQt::goBackOrForward):
743         (WebCore::FrameQt::historyURL):
744         (WebCore::FrameQt::getHistoryLength):
745         * platform/qt/FrameQt.h:
746         * platform/qt/PageQt.cpp:
747         (WebCore::Page::canRunModal):
748         (WebCore::Page::canRunModalNow):
749         (WebCore::Page::runModal):
750
751 2006-10-24  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
752
753         Reviewed by Tim H.
754
755         Fix for http://bugs.webkit.org/show_bug.cgi?id=11314
756         Fix build when XSLT_SUPPORT is not defined
757
758         Fix unconditional use of XSLT support.
759
760         * dom/XMLTokenizer.cpp:
761         (WebCore::XMLTokenizer::end):
762
763 2006-10-24  Simon Hausmann  <hausmann@kde.org>
764
765         Reviewed by Darin.
766
767         * CMakeLists.txt: Added project name to kde4_automoc macro, as
768           required by the latest KDE4 cmake module.
769
770 2006-10-24  Mitz Pettel  <mitz@webkit.org>
771
772         Reviewed by Tim H.
773
774         - fix http://bugs.webkit.org/show_bug.cgi?id=11394
775           HTMLViewSourceDocuments are leaking
776
777         * html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid
778         ref cycle.
779
780 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
781
782         Reviewed by Darin.
783
784         Removed one of Frame's redundant urlSelected methods.
785
786         * bridge/mac/FrameMac.h:
787         * bridge/mac/FrameMac.mm:
788         (WebCore::FrameMac::urlSelected):
789         since it's unused.
790         * html/HTMLAnchorElement.cpp:
791         (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString
792         to String because the former is deprecated and its performance is irrelevant
793         here. Added call to completeURL because Frame no longer does it for us.
794         Having the call here also improves clarity about the element's behavior.
795         * ksvg2/svg/SVGAElement.cpp:
796         (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre
797         irrelevent NULL checks on ownerDocument() because I couldn't help myself.
798         * page/Frame.cpp:
799         (WebCore::Frame::changeLocation):
800         (WebCore::Frame::urlSelected):
801         * page/Frame.h:
802         * platform/network/ResourceRequest.h: Removed explicit keyword on constructor
803         because we want to be able to use these constructors instead of helper functions
804         mimicking their behavior sprinkled across different classes.
805         (WebCore::ResourceRequest::ResourceRequest):
806
807 2006-10-24  Brady Eidson  <beidson@apple.com>
808
809         Reviewed by Maciej
810
811         Moved FrameLoader from WebCoreFrameBridge to Frame.  Frame.h/cpp have generic accessors to the FrameLoader itself
812         and creation/deletion is currently managed in FrameMac.mm
813
814         Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the 
815         frame instead of the bridge.
816
817         The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make 
818         use of it as its days are numbered!
819
820         * bridge/mac/FrameMac.mm:
821         (WebCore::FrameMac::FrameMac): Create the FrameLoader
822         (WebCore::FrameMac::~FrameMac): Nuke it
823         (WebCore::FrameMac::loadRequest):
824
825         * bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
826         * bridge/mac/WebCoreFrameBridge.mm:
827         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader
828         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto
829         (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader
830         (-[WebCoreFrameBridge setFrameLoaderClient:]):
831         (-[WebCoreFrameBridge frameLoader]):
832         (-[WebCoreFrameBridge setTitle:]):
833         (-[WebCoreFrameBridge didFirstLayout]):
834         (-[WebCoreFrameBridge notifyIconChanged:]):
835         (-[WebCoreFrameBridge originalRequestURL]):
836         (-[WebCoreFrameBridge isLoadTypeReload]):
837         (-[WebCoreFrameBridge frameDetached]):
838         (-[WebCoreFrameBridge tokenizerProcessedData]):
839         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
840         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
841         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
842         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
843         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
844         (-[WebCoreFrameBridge incomingReferrer]):
845         (-[WebCoreFrameBridge isReloading]):
846         (-[WebCoreFrameBridge handledOnloadEvents]):
847         (-[WebCoreFrameBridge mainResourceURLResponse]):
848         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
849
850         * loader/mac/WebDocumentLoader.mm:
851         (WebCore::DocumentLoader::frameLoader):
852
853         * loader/mac/WebFrameLoader.mm:
854         (WebCore::FrameLoader::load):
855         (WebCore::FrameLoader::stopLoadingSubframes):
856         (WebCore::FrameLoader::defersCallbacksChanged):
857         (WebCore::FrameLoader::setState):
858         (WebCore::FrameLoader::closeOldDataSources):
859         (WebCore::FrameLoader::subframeIsLoading):
860         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
861         (WebCore::FrameLoader::post):
862         (WebCore::FrameLoader::detachChildren):
863         (WebCore::FrameLoader::checkLoadComplete):
864
865         * loader/mac/WebLoader.mm:
866         (WebCore::WebResourceLoader::frameLoader):
867
868         * loader/mac/WebSubresourceLoader.mm:
869         (-[WebCoreSubresourceHandle initWithLoader:]):
870
871         * page/Frame.cpp:
872         (WebCore::Frame::frameLoader):
873         * page/Frame.h:
874         * page/FramePrivate.h:
875         (WebCore::FramePrivate::FramePrivate):
876
877 2006-10-24  Darin Adler  <darin@apple.com>
878
879         Reviewed by Maciej.
880
881         - fixed two crashes in layout tests I just introduced
882
883         * loader/mac/WebFrameLoader.mm:
884         (WebCore::FrameLoader::load): Add null check.
885         (WebCore::FrameLoader::setState): Ditto.
886
887 2006-10-23  Darin Adler  <darin@apple.com>
888
889         Reviewed by Geoff.
890
891         - converted WebDocumentLoader to C++
892
893         * WebCore.exp:
894         * bridge/mac/WebCoreFrameBridge.mm:
895         (-[WebCoreFrameBridge setTitle:]):
896         (-[WebCoreFrameBridge originalRequestURL]):
897         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
898         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
899         (-[WebCoreFrameBridge incomingReferrer]):
900         (-[WebCoreFrameBridge isReloading]):
901         (-[WebCoreFrameBridge mainResourceURLResponse]):
902         * loader/mac/WebDocumentLoader.h:
903         * loader/mac/WebDocumentLoader.mm:
904         (WebCore::DocumentLoader::DocumentLoader):
905         (WebCore::DocumentLoader::frameLoader):
906         (WebCore::DocumentLoader::~DocumentLoader):
907         (WebCore::DocumentLoader::setMainResourceData):
908         (WebCore::DocumentLoader::mainResourceData):
909         (WebCore::DocumentLoader::originalRequest):
910         (WebCore::DocumentLoader::originalRequestCopy):
911         (WebCore::DocumentLoader::request):
912         (WebCore::DocumentLoader::initialRequest):
913         (WebCore::DocumentLoader::actualRequest):
914         (WebCore::DocumentLoader::URL):
915         (WebCore::DocumentLoader::unreachableURL):
916         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
917         (WebCore::DocumentLoader::setRequest):
918         (WebCore::DocumentLoader::setResponse):
919         (WebCore::DocumentLoader::isStopping):
920         (WebCore::DocumentLoader::bridge):
921         (WebCore::DocumentLoader::setMainDocumentError):
922         (WebCore::DocumentLoader::mainDocumentError):
923         (WebCore::DocumentLoader::clearErrors):
924         (WebCore::DocumentLoader::mainReceivedError):
925         (WebCore::DocumentLoader::stopLoading):
926         (WebCore::DocumentLoader::setupForReplace):
927         (WebCore::DocumentLoader::commitIfReady):
928         (WebCore::DocumentLoader::finishedLoading):
929         (WebCore::DocumentLoader::setCommitted):
930         (WebCore::DocumentLoader::isCommitted):
931         (WebCore::DocumentLoader::setLoading):
932         (WebCore::DocumentLoader::isLoading):
933         (WebCore::DocumentLoader::commitLoad):
934         (WebCore::DocumentLoader::doesProgressiveLoad):
935         (WebCore::DocumentLoader::receivedData):
936         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
937         (WebCore::DocumentLoader::updateLoading):
938         (WebCore::DocumentLoader::response):
939         (WebCore::DocumentLoader::setFrame):
940         (WebCore::DocumentLoader::attachToFrame):
941         (WebCore::DocumentLoader::detachFromFrame):
942         (WebCore::DocumentLoader::prepareForLoadStart):
943         (WebCore::DocumentLoader::loadingStartedTime):
944         (WebCore::DocumentLoader::setIsClientRedirect):
945         (WebCore::DocumentLoader::isClientRedirect):
946         (WebCore::DocumentLoader::setPrimaryLoadComplete):
947         (WebCore::DocumentLoader::isLoadingInAPISense):
948         (WebCore::DocumentLoader::addResponse):
949         (WebCore::DocumentLoader::stopRecordingResponses):
950         (WebCore::DocumentLoader::title):
951         (WebCore::DocumentLoader::setLastCheckedRequest):
952         (WebCore::DocumentLoader::lastCheckedRequest):
953         (WebCore::DocumentLoader::triggeringAction):
954         (WebCore::DocumentLoader::setTriggeringAction):
955         (WebCore::DocumentLoader::responses):
956         (WebCore::DocumentLoader::setOverrideEncoding):
957         (WebCore::DocumentLoader::overrideEncoding):
958         (WebCore::DocumentLoader::setTitle):
959         (WebCore::DocumentLoader::URLForHistory):
960         * loader/mac/WebFrameLoader.h:
961         * loader/mac/WebFrameLoader.mm:
962         (WebCore::FrameLoader::setupForReplaceByMIMEType):
963         (WebCore::FrameLoader::finalSetupForReplace):
964         (WebCore::FrameLoader::safeLoad):
965         (WebCore::FrameLoader::load):
966         (WebCore::FrameLoader::startLoading):
967         (WebCore::FrameLoader::stopLoading):
968         (WebCore::FrameLoader::activeDocumentLoader):
969         (WebCore::FrameLoader::addPlugInStreamLoader):
970         (WebCore::FrameLoader::removePlugInStreamLoader):
971         (WebCore::FrameLoader::addSubresourceLoader):
972         (WebCore::FrameLoader::removeSubresourceLoader):
973         (WebCore::FrameLoader::setDocumentLoader):
974         (WebCore::FrameLoader::documentLoader):
975         (WebCore::FrameLoader::setPolicyDocumentLoader):
976         (WebCore::FrameLoader::provisionalDocumentLoader):
977         (WebCore::FrameLoader::setProvisionalDocumentLoader):
978         (WebCore::FrameLoader::setState):
979         (WebCore::FrameLoader::clearProvisionalLoad):
980         (WebCore::FrameLoader::commitProvisionalLoad):
981         (WebCore::FrameLoader::didReceiveResponse):
982         (WebCore::FrameLoader::originalRequest):
983         (WebCore::FrameLoader::receivedMainResourceError):
984         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
985         (WebCore::FrameLoader::opened):
986         (WebCore::FrameLoader::initialRequest):
987         (WebCore::FrameLoader::receivedData):
988         (WebCore::FrameLoader::setRequest):
989         (WebCore::FrameLoader::isStopping):
990         (WebCore::FrameLoader::setResponse):
991         (WebCore::FrameLoader::mainReceivedError):
992         (WebCore::FrameLoader::finishedLoading):
993         (WebCore::FrameLoader::notifyIconChanged):
994         (WebCore::FrameLoader::URL):
995         (WebCore::FrameLoader::checkContentPolicy):
996         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
997         (WebCore::FrameLoader::reloadAllowingStaleData):
998         (WebCore::FrameLoader::reload):
999         (WebCore::FrameLoader::finishedLoadingDocument):
1000         (WebCore::FrameLoader::committedLoad):
1001         (WebCore::FrameLoader::revertToProvisional):
1002         (WebCore::FrameLoader::setMainDocumentError):
1003         (WebCore::FrameLoader::mainReceivedCompleteError):
1004         (WebCore::FrameLoader::subframeIsLoading):
1005         (WebCore::FrameLoader::willChangeTitle):
1006         (WebCore::FrameLoader::didChangeTitle):
1007         (WebCore::FrameLoader::checkNavigationPolicy):
1008         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
1009         (WebCore::FrameLoader::transitionToCommitted):
1010         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1011         (WebCore::FrameLoader::detachFromParent):
1012         * loader/mac/WebFrameLoaderClient.h:
1013
1014 2006-10-23  Brady Eidson  <beidson@apple.com>
1015
1016         Lovingly reviewed by Maciej
1017
1018         Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
1019         This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself
1020
1021         * bridge/mac/BrowserExtensionMac.mm:
1022         (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest
1023
1024         * bridge/mac/FrameMac.mm:
1025         (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here
1026
1027         * bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
1028         * bridge/mac/WebCoreFrameBridge.mm: Ditto
1029         * loader/mac/WebFrameLoader.mm:
1030         (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest
1031
1032 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1033
1034         RS by Maciej.
1035
1036         Inside Frame, moved the plethora of load() and stopLoading() functions next 
1037         to each other to facilitate merging and crying.
1038
1039         * bridge/mac/FrameMac.h:
1040         * bridge/mac/FrameMac.mm:
1041         (WebCore::FrameMac::loadRequest):
1042         (WebCore::FrameMac::submitForm):
1043         (WebCore::FrameMac::openURL):
1044         (WebCore::FrameMac::openURLRequest):
1045         (WebCore::FrameMac::urlSelected):
1046         (WebCore::FrameMac::openURLFromPageCache):
1047         (WebCore::FrameMac::createFrame):
1048         * page/Frame.cpp:
1049         (WebCore::Frame::openURL):
1050         (WebCore::Frame::changeLocation):
1051         (WebCore::Frame::urlSelected):
1052         (WebCore::Frame::requestFrame):
1053         (WebCore::Frame::loadSubframe):
1054         (WebCore::Frame::submitFormAgain):
1055         (WebCore::Frame::submitForm):
1056         (WebCore::Frame::stop):
1057         (WebCore::Frame::closeURL):
1058         (WebCore::Frame::cancelRedirection):
1059         (WebCore::Frame::iconURL):
1060         (WebCore::Frame::didOpenURL):
1061         (WebCore::Frame::didExplicitOpen):
1062         * page/Frame.h:
1063
1064 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1065
1066         RS by Maciej.
1067
1068         Moved our plethora of load() and stopLoading() functions next to each other
1069         to facilitate merging and laughter.
1070
1071         * loader/mac/WebFrameLoader.h:
1072         * loader/mac/WebFrameLoader.mm:
1073         (WebCore::cancelAll):
1074         (WebCore::FrameLoader::prepareForLoadStart):
1075         (WebCore::FrameLoader::setupForReplace):
1076         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1077         (WebCore::FrameLoader::finalSetupForReplace):
1078         (WebCore::FrameLoader::safeLoad):
1079         (WebCore::FrameLoader::load):
1080         (WebCore::FrameLoader::startLoadingMainResource):
1081         (WebCore::FrameLoader::startLoading):
1082         (WebCore::FrameLoader::stopLoadingPlugIns):
1083         (WebCore::FrameLoader::stopLoadingSubresources):
1084         (WebCore::FrameLoader::stopLoading):
1085         (WebCore::FrameLoader::stopLoadingSubframes):
1086         (WebCore::FrameLoader::cancelMainResourceLoad):
1087         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1088         (WebCore::FrameLoader::removeSubresourceLoader):
1089         (WebCore::FrameLoader::mainResourceData):
1090         (WebCore::FrameLoader::releaseMainResourceLoader):
1091
1092 2006-10-23  Darin Adler  <darin@apple.com>
1093
1094         Reviewed by Maciej.
1095
1096         - converted WebFrameLoader to C++
1097
1098         * WebCore.exp: Added many new entry points for WebKit.
1099         * WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).
1100
1101         * bridge/mac/WebCoreFrameBridge.h:
1102         * bridge/mac/WebCoreFrameBridge.mm:
1103         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
1104         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
1105         (-[WebCoreFrameBridge dealloc]):
1106         (-[WebCoreFrameBridge close]):
1107         (-[WebCoreFrameBridge clearFrame]):
1108         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1109         (-[WebCoreFrameBridge frameLoader]):
1110         (-[WebCoreFrameBridge setTitle:]):
1111         (-[WebCoreFrameBridge didFirstLayout]):
1112         (-[WebCoreFrameBridge notifyIconChanged:]):
1113         (-[WebCoreFrameBridge originalRequestURL]):
1114         (-[WebCoreFrameBridge isLoadTypeReload]):
1115         (-[WebCoreFrameBridge frameDetached]):
1116         (-[WebCoreFrameBridge tokenizerProcessedData]):
1117         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1118         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1119         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
1120         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1121         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
1122         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
1123         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
1124         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1125         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1126         (-[WebCoreFrameBridge incomingReferrer]):
1127         (-[WebCoreFrameBridge isReloading]):
1128         (-[WebCoreFrameBridge handledOnloadEvents]):
1129         (-[WebCoreFrameBridge mainResourceURLResponse]):
1130         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
1131         * loader/mac/WebDocumentLoader.h:
1132         * loader/mac/WebDocumentLoader.mm:
1133         (-[WebDocumentLoader frameLoader]):
1134         (-[WebDocumentLoader dealloc]):
1135         (-[WebDocumentLoader mainResourceData]):
1136         (-[WebDocumentLoader setRequest:]):
1137         (-[WebDocumentLoader bridge]):
1138         (-[WebDocumentLoader setMainDocumentError:]):
1139         (-[WebDocumentLoader mainReceivedError:complete:]):
1140         (-[WebDocumentLoader stopLoading]):
1141         (-[WebDocumentLoader setupForReplace]):
1142         (-[WebDocumentLoader commitIfReady]):
1143         (-[WebDocumentLoader finishedLoading]):
1144         (-[WebDocumentLoader commitLoadWithData:]):
1145         (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]):
1146         (-[WebDocumentLoader setupForReplaceByMIMEType:]):
1147         (-[WebDocumentLoader updateLoading]):
1148         (-[WebDocumentLoader setFrame:]):
1149         (-[WebDocumentLoader attachToFrame]):
1150         (-[WebDocumentLoader detachFromFrame]):
1151         (-[WebDocumentLoader prepareForLoadStart]):
1152         (-[WebDocumentLoader setPrimaryLoadComplete:]):
1153         (-[WebDocumentLoader isLoadingInAPISense]):
1154         (-[WebDocumentLoader setTitle:]):
1155         * loader/mac/WebFrameLoader.h:
1156         (WebCore::FrameLoader::frame):
1157         * loader/mac/WebFrameLoader.mm:
1158         (WebCore::FrameLoader::FrameLoader):
1159         (WebCore::FrameLoader::~FrameLoader):
1160         (WebCore::FrameLoader::activeDocumentLoader):
1161         (WebCore::FrameLoader::addPlugInStreamLoader):
1162         (WebCore::FrameLoader::removePlugInStreamLoader):
1163         (WebCore::FrameLoader::defersCallbacksChanged):
1164         (WebCore::FrameLoader::defersCallbacks):
1165         (WebCore::setAllDefersCallbacks):
1166         (WebCore::FrameLoader::setDefersCallbacks):
1167         (WebCore::cancelAll):
1168         (WebCore::FrameLoader::stopLoadingPlugIns):
1169         (WebCore::FrameLoader::isLoadingMainResource):
1170         (WebCore::FrameLoader::isLoadingSubresources):
1171         (WebCore::FrameLoader::isLoadingPlugIns):
1172         (WebCore::FrameLoader::isLoading):
1173         (WebCore::FrameLoader::stopLoadingSubresources):
1174         (WebCore::FrameLoader::addSubresourceLoader):
1175         (WebCore::FrameLoader::removeSubresourceLoader):
1176         (WebCore::FrameLoader::mainResourceData):
1177         (WebCore::FrameLoader::releaseMainResourceLoader):
1178         (WebCore::FrameLoader::cancelMainResourceLoad):
1179         (WebCore::FrameLoader::startLoadingMainResource):
1180         (WebCore::FrameLoader::stopLoading):
1181         (WebCore::FrameLoader::setDocumentLoader):
1182         (WebCore::FrameLoader::documentLoader):
1183         (WebCore::FrameLoader::setPolicyDocumentLoader):
1184         (WebCore::FrameLoader::provisionalDocumentLoader):
1185         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1186         (WebCore::FrameLoader::state):
1187         (WebCore::FrameLoader::timeOfLastCompletedLoad):
1188         (WebCore::FrameLoader::provisionalLoadStarted):
1189         (WebCore::FrameLoader::setState):
1190         (WebCore::FrameLoader::clearProvisionalLoad):
1191         (WebCore::FrameLoader::markLoadComplete):
1192         (WebCore::FrameLoader::commitProvisionalLoad):
1193         (WebCore::FrameLoader::stopLoadingSubframes):
1194         (WebCore::FrameLoader::startLoading):
1195         (WebCore::FrameLoader::setupForReplace):
1196         (WebCore::FrameLoader::identifierForInitialRequest):
1197         (WebCore::FrameLoader::willSendRequest):
1198         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1199         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1200         (WebCore::FrameLoader::didReceiveResponse):
1201         (WebCore::FrameLoader::didReceiveData):
1202         (WebCore::FrameLoader::didFinishLoad):
1203         (WebCore::FrameLoader::didFailToLoad):
1204         (WebCore::FrameLoader::privateBrowsingEnabled):
1205         (WebCore::FrameLoader::originalRequest):
1206         (WebCore::FrameLoader::receivedMainResourceError):
1207         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
1208         (WebCore::FrameLoader::clientRedirected):
1209         (WebCore::FrameLoader::shouldReload):
1210         (WebCore::FrameLoader::load):
1211         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1212         (WebCore::FrameLoader::closeOldDataSources):
1213         (WebCore::FrameLoader::opened):
1214         (WebCore::FrameLoader::initialRequest):
1215         (WebCore::FrameLoader::receivedData):
1216         (WebCore::FrameLoader::setRequest):
1217         (WebCore::FrameLoader::download):
1218         (WebCore::FrameLoader::bridge):
1219         (WebCore::FrameLoader::handleFallbackContent):
1220         (WebCore::FrameLoader::isStopping):
1221         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1222         (WebCore::FrameLoader::setResponse):
1223         (WebCore::FrameLoader::mainReceivedError):
1224         (WebCore::FrameLoader::finishedLoading):
1225         (WebCore::FrameLoader::notifyIconChanged):
1226         (WebCore::FrameLoader::URL):
1227         (WebCore::FrameLoader::cancelledError):
1228         (WebCore::FrameLoader::fileDoesNotExistError):
1229         (WebCore::FrameLoader::willUseArchive):
1230         (WebCore::FrameLoader::isArchiveLoadPending):
1231         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1232         (WebCore::FrameLoader::handleUnimplementablePolicy):
1233         (WebCore::FrameLoader::cannotShowMIMEType):
1234         (WebCore::FrameLoader::interruptionForPolicyChangeError):
1235         (WebCore::FrameLoader::isHostedByObjectElement):
1236         (WebCore::FrameLoader::isLoadingMainFrame):
1237         (WebCore::FrameLoader::canShowMIMEType):
1238         (WebCore::FrameLoader::representationExistsForURLScheme):
1239         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
1240         (WebCore::FrameLoader::checkNavigationPolicy):
1241         (WebCore::FrameLoader::checkContentPolicy):
1242         (WebCore::FrameLoader::cancelContentPolicyCheck):
1243         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
1244         (WebCore::FrameLoader::reloadAllowingStaleData):
1245         (WebCore::FrameLoader::reload):
1246         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
1247         (WebCore::FrameLoader::finishedLoadingDocument):
1248         (WebCore::FrameLoader::committedLoad):
1249         (WebCore::FrameLoader::isReplacing):
1250         (WebCore::FrameLoader::setReplacing):
1251         (WebCore::FrameLoader::revertToProvisional):
1252         (WebCore::FrameLoader::setMainDocumentError):
1253         (WebCore::FrameLoader::mainReceivedCompleteError):
1254         (WebCore::FrameLoader::finalSetupForReplace):
1255         (WebCore::FrameLoader::prepareForLoadStart):
1256         (WebCore::FrameLoader::subframeIsLoading):
1257         (WebCore::FrameLoader::willChangeTitle):
1258         (WebCore::FrameLoader::didChangeTitle):
1259         (WebCore::FrameLoader::loadType):
1260         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
1261         (WebCore::FrameLoader::checkNewWindowPolicy):
1262         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
1263         (WebCore::FrameLoader::continueAfterNavigationPolicy):
1264         (WebCore::FrameLoader::continueAfterWillSubmitForm):
1265         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
1266         (WebCore::FrameLoader::didFirstLayout):
1267         (WebCore::FrameLoader::frameLoadCompleted):
1268         (WebCore::FrameLoader::firstLayoutDone):
1269         (WebCore::FrameLoader::isQuickRedirectComing):
1270         (WebCore::FrameLoader::transitionToCommitted):
1271         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1272         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
1273         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1274         (WebCore::FrameLoader::requestFromDelegate):
1275         (WebCore::FrameLoader::post):
1276         (WebCore::FrameLoader::detachChildren):
1277         (WebCore::FrameLoader::detachFromParent):
1278         (WebCore::FrameLoader::addExtraFieldsToRequest):
1279         (WebCore::FrameLoader::safeLoad):
1280         (WebCore::FrameLoader::actionInformation):
1281         (WebCore::FrameLoader::checkLoadComplete):
1282         (WebCore::FrameLoader::setFrameLoaderClient):
1283         (WebCore::FrameLoader::client):
1284         (WebCore::FrameLoader::asDelegate):
1285         (-[WebCoreFrameLoaderAsDelegate initWithLoader:]):
1286         (-[WebCoreFrameLoaderAsDelegate detachFromLoader]):
1287         (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]):
1288         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
1289         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
1290         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
1291         (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]):
1292         (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1293         * loader/mac/WebLoader.h:
1294         (WebCore::WebResourceLoader::identifier):
1295         (WebCore::WebResourceLoader::reachedTerminalState):
1296         (WebCore::WebResourceLoader::cancelled):
1297         * loader/mac/WebLoader.mm:
1298         (WebCore::WebResourceLoader::WebResourceLoader):
1299         (WebCore::WebResourceLoader::releaseResources):
1300         (WebCore::WebResourceLoader::load):
1301         (WebCore::WebResourceLoader::frameLoader):
1302         (WebCore::WebResourceLoader::willSendRequest):
1303         (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge):
1304         (WebCore::WebResourceLoader::didCancelAuthenticationChallenge):
1305         (WebCore::WebResourceLoader::didReceiveResponse):
1306         (WebCore::WebResourceLoader::didReceiveData):
1307         (WebCore::WebResourceLoader::didFinishLoading):
1308         (WebCore::WebResourceLoader::didFinishLoadingOnePart):
1309         (WebCore::WebResourceLoader::didFail):
1310         (WebCore::WebResourceLoader::willCacheResponse):
1311         (WebCore::WebResourceLoader::didCancel):
1312         (WebCore::WebResourceLoader::cancel):
1313         (WebCore::WebResourceLoader::cancelledError):
1314         (WebCore::WebResourceLoader::delegate):
1315         * loader/mac/WebMainResourceLoader.h:
1316         * loader/mac/WebMainResourceLoader.mm:
1317         (WebCore::MainResourceLoader::MainResourceLoader):
1318         (WebCore::MainResourceLoader::create):
1319         (WebCore::MainResourceLoader::receivedError):
1320         (WebCore::MainResourceLoader::didCancel):
1321         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
1322         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
1323         (WebCore::MainResourceLoader::addData):
1324         (WebCore::MainResourceLoader::willSendRequest):
1325         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1326         (WebCore::MainResourceLoader::didReceiveResponse):
1327         (WebCore::MainResourceLoader::didReceiveData):
1328         (WebCore::MainResourceLoader::didFinishLoading):
1329         (WebCore::MainResourceLoader::didFail):
1330         (WebCore::MainResourceLoader::loadNow):
1331         (WebCore::MainResourceLoader::policyDelegate):
1332         * loader/mac/WebNetscapePlugInStreamLoader.h:
1333         * loader/mac/WebNetscapePlugInStreamLoader.mm:
1334         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1335         (WebCore::NetscapePlugInStreamLoader::create):
1336         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1337         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1338         (WebCore::NetscapePlugInStreamLoader::didFail):
1339         (WebCore::NetscapePlugInStreamLoader::didCancel):
1340         * loader/mac/WebSubresourceLoader.h:
1341         * loader/mac/WebSubresourceLoader.mm:
1342         (-[WebCoreSubresourceHandle initWithLoader:]):
1343
1344 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1345
1346         Reviewed by Bradee.
1347
1348         Shrunk BrowserExtension in preparation for its imminent death, moving page-
1349         level operations to Page and frame-level operations to Frame.
1350         
1351         Removed bizarre Mac(this) syntax inside virtual FrameMac member functions, 
1352         because 'this' is guaranteed by the compiler to be a FrameMac*.
1353         
1354         * bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places
1355         where it can be NULL.
1356         * bindings/js/kjs_window.cpp:
1357         (KJS::canShowModalDialog):
1358         (KJS::canShowModalDialogNow):
1359         (KJS::showModalDialog):
1360         (KJS::History::getValueProperty):
1361         (KJS::HistoryFunc::callAsFunction):
1362         * bridge/BrowserExtension.h:
1363         (WebCore::BrowserExtension::~BrowserExtension):
1364         * bridge/mac/BrowserExtensionMac.h:
1365         * bridge/mac/BrowserExtensionMac.mm:
1366         (WebCore::BrowserExtensionMac::createNewWindow):
1367         * bridge/mac/FrameMac.h:
1368         * bridge/mac/FrameMac.mm:
1369         (WebCore::FrameMac::frameDetached):
1370         (WebCore::FrameMac::unfocusWindow):
1371         (WebCore::FrameMac::bridgeForWidget):
1372         (WebCore::FrameMac::documentViewForNode):
1373         (WebCore::FrameMac::passSubframeEventToSubframe):
1374         (WebCore::Frame::setNeedsReapplyStyles):
1375         (WebCore::FrameMac::customHighlightLineRect):
1376         (WebCore::FrameMac::paintCustomHighlight):
1377         (WebCore::FrameMac::getHistoryLength):
1378         (WebCore::FrameMac::goBackOrForward):
1379         (WebCore::FrameMac::historyURL):
1380         * bridge/mac/PageMac.mm:
1381         (WebCore::Page::canRunModal):
1382         (WebCore::Page::canRunModalNow):
1383         (WebCore::Page::runModal):
1384         * bridge/mac/WebCoreFrameBridge.h:
1385         * bridge/mac/WebCorePageBridge.h:
1386         * bridge/win/BrowserExtensionWin.h:
1387         * page/Frame.cpp:
1388         (WebCore::Frame::scheduleHistoryNavigation):
1389         (WebCore::Frame::redirectionTimerFired):
1390         * page/Frame.h:
1391         * page/Page.h:
1392
1393 2006-10-23  Justin Garcia  <justin.garcia@apple.com>
1394
1395         Reviewed by mjs
1396
1397         <http://bugs.webkit.org/show_bug.cgi?id=11334>
1398         Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons
1399
1400         * WebCore.xcodeproj/project.pbxproj:
1401         * editing/Editor.cpp:
1402         (WebCore::Editor::selectionUnorderedListState): Added.
1403         (WebCore::Editor::selectionOrderedListState): Added.
1404         * editing/Editor.h:
1405         * editing/JSEditor.cpp:
1406         * page/Frame.cpp:
1407         * page/Frame.h:
1408
1409 2006-10-23  John Sullivan  <sullivan@apple.com>
1410
1411         Reviewed by Tim H
1412
1413         * WebCore.xcodeproj/project.pbxproj:
1414         Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit
1415
1416 2006-10-23  Sam Weinig  <sam.weinig@gmail.com>
1417
1418         Reviewed by Tim H.
1419
1420         Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
1421         PNG as cursor image format instead of TIFF
1422
1423         Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)
1424
1425         - Convert cursor images from TIFF to PNG.
1426
1427         * Resources/eastResizeCursor.png: Added.
1428         * Resources/eastResizeCursor.tiff: Removed.
1429         * Resources/eastWestResizeCursor.png: Added.
1430         * Resources/eastWestResizeCursor.tiff: Removed.
1431         * Resources/helpCursor.png: Added.
1432         * Resources/helpCursor.tiff: Removed.
1433         * Resources/linkCursor.png: Added.
1434         * Resources/linkCursor.tiff: Removed.
1435         * Resources/moveCursor.png: Added.
1436         * Resources/moveCursor.tiff: Removed.
1437         * Resources/northEastResizeCursor.png: Added.
1438         * Resources/northEastResizeCursor.tiff: Removed.
1439         * Resources/northEastSouthWestResizeCursor.png: Added.
1440         * Resources/northEastSouthWestResizeCursor.tiff: Removed.
1441         * Resources/northResizeCursor.png: Added.
1442         * Resources/northResizeCursor.tiff: Removed.
1443         * Resources/northSouthResizeCursor.png: Added.
1444         * Resources/northSouthResizeCursor.tiff: Removed.
1445         * Resources/northWestResizeCursor.png: Added.
1446         * Resources/northWestResizeCursor.tiff: Removed.
1447         * Resources/northWestSouthEastResizeCursor.png: Added.
1448         * Resources/northWestSouthEastResizeCursor.tiff: Removed.
1449         * Resources/southEastResizeCursor.png: Added.
1450         * Resources/southEastResizeCursor.tiff: Removed.
1451         * Resources/southResizeCursor.png: Added.
1452         * Resources/southResizeCursor.tiff: Removed.
1453         * Resources/southWestResizeCursor.png: Added.
1454         * Resources/southWestResizeCursor.tiff: Removed.
1455         * Resources/waitCursor.png: Added.
1456         * Resources/waitCursor.tiff: Removed.
1457         * Resources/westResizeCursor.png: Added.
1458         * Resources/westResizeCursor.tiff: Removed.
1459         * WebCore.xcodeproj/project.pbxproj:
1460         * platform/mac/CursorMac.mm:
1461         (WebCore::leakNamedCursor):
1462
1463 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1464
1465         Not reviewed.
1466
1467         - fixed build from last change.
1468
1469         * bridge/mac/FrameMac.h:
1470         * bridge/mac/FrameMac.mm:
1471         (WebCore::FrameMac::loadRequest):
1472         (WebCore::FrameMac::openURL):
1473
1474 2006-10-23  Adam Roben  <aroben@apple.com>
1475
1476         Reviewed by Adele.
1477
1478         Move border-radius rule for <select>s into RenderThemeMac, as this is
1479         really a platform-specific look.
1480
1481         * css/html4.css:
1482         * rendering/RenderThemeMac.mm:
1483         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
1484
1485 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1486
1487         Reviewed by Brady.
1488
1489         - moved things around so loadURL:... is only called from one place
1490
1491         * bridge/mac/FrameMac.h:
1492         * bridge/mac/FrameMac.mm:
1493         (WebCore::FrameMac::frameDetached):
1494         (WebCore::FrameMac::loadRequest):
1495         (WebCore::FrameMac::submitForm):
1496         (WebCore::FrameMac::openURL):
1497         (WebCore::FrameMac::openURLRequest):
1498         (WebCore::FrameMac::urlSelected):
1499
1500 2006-10-23  Justin Garcia  <justin.garcia@apple.com>
1501
1502         Reviewed by john
1503         
1504         <http://bugs.webkit.org/show_bug.cgi?id=11333>
1505         Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document
1506         
1507         Added special cases in InsertLineBreakCommand for inserting before
1508         and after tables and horizontal rules.  Also, perform InsertLineBreak
1509         instead of InsertParagraphSeparator at these positions.
1510
1511         * editing/InsertLineBreakCommand.cpp:
1512         (WebCore::InsertLineBreakCommand::doApply):  Use the canonical form
1513         of the caret position when we check for the new special cases because 
1514         we know that we canonicalize VisiblePositions to those positions.
1515         Added code to handle inserting before/after tables and horizontal rules.  
1516         Fixed a bug when inserting at the end of a block (it checked for a collapse
1517         of the inserted br by looking for the absence of a br, but the line break 
1518         might have been a '\n' in white-space:pre text).  Removed unused LOGs.
1519         * editing/InsertParagraphSeparatorCommand.cpp:
1520         (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an 
1521         InsertLineBreakCommand when before/after a table or a horizontal rule
1522         so that we don't have to maintain two pieces of special case code.
1523         Migrated to enclosingBlock.
1524         * editing/htmlediting.cpp: Added a FIXME.
1525         * editing/visible_units.cpp:
1526         (WebCore::startOfParagraph): Added a workaround for 8622.
1527         
1528 2006-10-23  Adam Roben  <aroben@apple.com>
1529
1530         Reviewed by Adele.
1531
1532         Make popups a little more flexible.
1533
1534         * platform/PopupMenu.h:
1535
1536 2006-10-23  Sam Weinig  <sam.weinig@gmail.com>
1537
1538         Reviewed by Tim H.
1539
1540         Cleanup CodeGeneratorJS.pm
1541
1542         * bindings/scripts/CodeGeneratorJS.pm:
1543
1544 2006-10-23  Adam Roben  <aroben@apple.com>
1545
1546         Rubberstamped by Brady.
1547
1548         * loader/icon/IconLoader.h: Changed angle-brackets to quotes for
1549         #include of ResourceLoader.h, since it's a WebCore header.
1550
1551 2006-10-23  Darin Adler  <darin@apple.com>
1552
1553         - fixed mistake that was preventing any loading from happening
1554
1555         * platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData):
1556         Changed parameter back to int. Perhaps we want to move to "long long" consistently, but
1557         I'll leave that up to Maciej.
1558
1559 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1560
1561         Reviewed by Anders.
1562
1563         - start converting ResourceLoaderClient to new API
1564
1565         Did the bits I could do without introducing new types:
1566         
1567         - renamed receivedData to didReceiveData
1568         - renamed version of receivedAllData that doesn't pass any data to didFinishLoading
1569
1570         * bridge/mac/WebCoreResourceLoaderImp.mm:
1571         (-[WebCoreResourceLoaderImp addData:]):
1572         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
1573         * loader/icon/IconLoader.cpp:
1574         (IconLoader::didReceiveData):
1575         (IconLoader::didFinishLoading):
1576         * loader/icon/IconLoader.h:
1577         * loader/loader.cpp:
1578         (WebCore::Loader::didReceiveData):
1579         * loader/loader.h:
1580         * platform/gdk/FrameGdk.cpp:
1581         (WebCore::FrameGdkClientDefault::didReceiveData):
1582         * platform/gdk/FrameGdk.h:
1583         * platform/network/ResourceLoaderClient.h:
1584         (WebCore::ResourceLoaderClient::didReceiveData):
1585         (WebCore::ResourceLoaderClient::didFinishLoading):
1586         (WebCore::ResourceLoaderClient::receivedResponse):
1587         * platform/network/cf/ResourceLoaderCFNet.cpp:
1588         (WebCore::didReceiveData):
1589         (WebCore::didFinishLoading):
1590         (WebCore::didFail):
1591         (WebCore::ResourceLoader::cancel):
1592         * platform/network/gdk/ResourceLoaderManager.cpp:
1593         (WebCore::writeCallback):
1594         (WebCore::ResourceLoaderManager::downloadTimerCallback):
1595         (WebCore::ResourceLoaderManager::remove):
1596         * platform/network/qt/ResourceLoaderManager.cpp:
1597         (WebCore::ResourceLoaderManager::slotData):
1598         (WebCore::ResourceLoaderManager::remove):
1599         * platform/network/win/ResourceLoaderWin.cpp:
1600         (WebCore::ResourceLoader::onRequestComplete):
1601         (WebCore::ResourceLoader::fileLoadTimer):
1602         (WebCore::ResourceLoader::cancel):
1603         * platform/qt/FrameQtClient.cpp:
1604         (WebCore::FrameQtClientDefault::didReceiveData):
1605         * platform/qt/FrameQtClient.h:
1606         * xml/xmlhttprequest.cpp:
1607         (WebCore::XMLHttpRequest::processSyncLoadResults):
1608         (WebCore::XMLHttpRequest::didFinishLoading):
1609         (WebCore::XMLHttpRequest::didReceiveData):
1610         * xml/xmlhttprequest.h:
1611
1612 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1613
1614         Rubber stamped by Anders.
1615
1616         - marked files executable
1617         
1618         * ksvg2/scripts/csscssmakeprops:
1619         * ksvg2/scripts/csscssmakevalues:
1620
1621 2006-10-22  Maciej Stachowiak  <mjs@apple.com>
1622
1623         Reviewed by Anders.
1624
1625         - moved ResourceLoader and related files to platform/network
1626         in preparation for building out this API.
1627
1628         I tried to update all the build systems but I'm not sure they are
1629         all fixed properly
1630
1631         * page/ResourceRequest.h: Moved to platform/network.
1632         * platform/ResourceLoader.cpp: Moved to platform/network.
1633         * platform/ResourceLoader.h: Moved to platform/network.
1634         * platform/ResourceLoaderClient.h: Moved to platform/network.
1635         * platform/ResourceLoaderInternal.h: Moved to platform/network.
1636         * platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
1637         * platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
1638         * platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
1639         * platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
1640         * platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
1641         * platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
1642         * platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
1643         * platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
1644         * platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
1645         * platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
1646         * webcore-base.bkl: Updated for new paths.
1647         * CMakeLists.txt: ditto
1648         * Projects/gdk/webcore-gdk.bkl: ditto
1649         * WebCore.xcodeproj/project.pbxproj: ditto
1650         * WebCoreSources.bkl: ditto
1651
1652 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
1653
1654         Reviewed by Tim H.
1655
1656         - Add DOMHTMLFormElementPrivate.h to the project.
1657
1658         * WebCore.xcodeproj/project.pbxproj:
1659         * bindings/objc/DOMPrivate.h:
1660
1661 2006-10-22  Darin Adler  <darin@apple.com>
1662
1663         - another try at fixing Qt
1664
1665         * CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
1666
1667         - and fix a couple warnings while I'm at it
1668
1669         * platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA):
1670         Don't do unsigned *= float.
1671
1672         * rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable
1673         inside #if so it's consistent.
1674
1675 2006-10-21  Darin Adler  <darin@apple.com>
1676
1677         - fix the Qt build
1678
1679         * platform/qt/EditorClientQt.cpp:
1680         (WebCore::EditorClientQt::shouldShowDeleteInterface):
1681         * platform/qt/EditorClientQt.h:
1682         * platform/qt/FrameQt.cpp:
1683
1684 2006-10-21  Darin Adler  <darin@apple.com>
1685
1686         Reviewed by Adele.
1687
1688         - convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)
1689
1690         Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
1691         there's currently another class with that name).
1692         Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
1693         Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
1694         Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
1695
1696         Converted the classes to C++ and added Objective-C delegates to forward from
1697         API that still requires Objective-C.
1698
1699         Did not yet rename the source files.
1700
1701         * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
1702         classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
1703         classes.
1704
1705         * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
1706
1707         * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
1708
1709         * loader/mac/WebLoader.h:
1710         * loader/mac/WebLoader.mm:
1711         * loader/mac/WebMainResourceLoader.h:
1712         * loader/mac/WebMainResourceLoader.mm:
1713         * loader/mac/WebNetscapePlugInStreamLoader.h:
1714         * loader/mac/WebNetscapePlugInStreamLoader.mm:
1715         * loader/mac/WebSubresourceLoader.h:
1716         * loader/mac/WebSubresourceLoader.mm:
1717         Translate to C++.
1718
1719         * bridge/mac/WebCoreFrameBridge.mm:
1720         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1721         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1722         * loader/mac/WebFrameLoader.h:
1723         * loader/mac/WebFrameLoader.mm:
1724         (isCaseInsensitiveEqual):
1725         (isBackForwardLoadType):
1726         (-[WebFrameLoader dealloc]):
1727         (-[WebFrameLoader addPlugInStreamLoader:]):
1728         (-[WebFrameLoader removePlugInStreamLoader:]):
1729         (-[WebFrameLoader setDefersCallbacks:]):
1730         (-[WebFrameLoader stopLoadingPlugIns]):
1731         (-[WebFrameLoader isLoadingMainResource]):
1732         (-[WebFrameLoader isLoadingSubresources]):
1733         (-[WebFrameLoader isLoadingPlugIns]):
1734         (-[WebFrameLoader stopLoadingSubresources]):
1735         (-[WebFrameLoader addSubresourceLoader:]):
1736         (-[WebFrameLoader removeSubresourceLoader:]):
1737         (-[WebFrameLoader mainResourceData]):
1738         (-[WebFrameLoader releaseMainResourceLoader]):
1739         (-[WebFrameLoader cancelMainResourceLoad]):
1740         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
1741         (-[WebFrameLoader stopLoadingWithError:]):
1742         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
1743         (-[WebFrameLoader archiveLoadPendingForLoader:]):
1744         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
1745         * loader/mac/WebFrameLoaderClient.h:
1746         Call the new C++ API.
1747
1748 2006-10-21  Adam Roben  <aroben@apple.com>
1749
1750         Reviewed by Anders.
1751
1752         Popup tweaks.
1753
1754         * platform/PopupMenu.h:
1755
1756 2006-10-21  Darin Adler  <darin@apple.com>
1757
1758         * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable):
1759         Oops, edited this before landing it and introduced a null-deref! This fixes it.
1760
1761 2006-10-21  Darin Adler  <darin@apple.com>
1762
1763         Reviewed by Anders.
1764
1765         - fix http://bugs.webkit.org/show_bug.cgi?id=11379
1766           assertion failure seen in editing tests (in new DeleteButtonController)
1767
1768         I cleaned up the relationship between the Frame, Editor, EditorClient, and
1769         DeleteButtonController a bit while also making the simple change to fix the
1770         assertion failure.
1771
1772         * bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
1773         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
1774
1775         * page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
1776         * page/Frame.cpp:
1777         (WebCore::Frame::Frame): Ditto.
1778         (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents
1779         function, and moved it to Editor rather than right on the DeleteButtonController.
1780         (WebCore::Frame::unappliedEditing): Ditto.
1781         (WebCore::Frame::reappliedEditing): Ditto.
1782         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
1783
1784         * editing/DeleteButtonController.h:
1785         * editing/DeleteButtonController.cpp:
1786         (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*.
1787         The general pattern is that we always use the Frame* as the frame identifier. See FrameTree,
1788         for example.
1789         (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection
1790         function. Includes an additional check for whether the container is contentEditable, which
1791         was missing from the old version. This prevents the assertion failure. Also added a check that
1792         the table itself is editable.
1793         (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper.
1794         (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary
1795         selection parameter. No need to pass in the state of the frame since we can get it if we need it.
1796         (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
1797
1798         * editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be
1799         formatted on multiple lines as usual.
1800         (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller.
1801         (WebCore::Editor::respondToChangedContents): Ditto.
1802         (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
1803
1804         * editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being
1805         defined inline to decouple so that we don't have to include DeleteButtonController.h. That way
1806         changes to DeleteButtonController.h cause very little to recompile.
1807
1808         * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
1809         Updated to call the editor instead of the delete button controller for the selection change.
1810
1811 2006-10-21  Anders Carlsson  <acarlsson@apple.com>
1812
1813         Reviewed by Darin.
1814
1815         * loader/mac/LoaderFunctionsMac.mm:
1816         (WebCore::ServeSynchronousRequest):
1817         * platform/mac/ResourceLoaderMac.mm:
1818         (WebCore::ResourceLoader::start):
1819         Don't leak the header dictionary.
1820
1821 2006-10-21  Darin Adler  <darin@apple.com>
1822
1823         Reviewed by Adam.
1824
1825         - http://bugs.webkit.org/show_bug.cgi?id=11376
1826           build scripts should invoke make with "-j" option for multiple processors
1827
1828         * WebCore.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
1829
1830 2006-10-21  Timothy Hatcher  <timothy@apple.com>
1831
1832         Reviewed by Geoff.
1833
1834         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
1835
1836         Initial implementaltion of table deletion user interface:
1837         * Interface shows up on the nearest table containing the entire selection.
1838         * Shows a Dashboard style close button in the top left corner.
1839         * Shows a 60% opaque black outline around the table.
1840         * Adds a new EditorClient function shouldShowDeleteInterface.
1841
1842         Also adds a new constructor CachedImage and setter functions on
1843         HTMLImageElement and HTMLImageLoader allowing an Image object to be set
1844         and image element in the page. This change also paves the way to allow an
1845         NSImage setter on DOMHTMLImageElement. 
1846
1847         * Resources/deleteButton.tiff: Added.
1848         * Resources/deleteButtonPressed.tiff: Added.
1849         * WebCore.xcodeproj/project.pbxproj:
1850         * bridge/EditorClient.h:
1851         * editing/DeleteButton.cpp: Added.
1852         (WebCore::DeleteButton::DeleteButton):
1853         (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
1854         * editing/DeleteButton.h: Added.
1855         * editing/DeleteButtonController.cpp: Added.
1856         (WebCore::DeleteButtonController::DeleteButtonController):
1857         (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide
1858         (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle
1859         (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size
1860         (WebCore::DeleteButtonController::show): shows the interface on a new element
1861         (WebCore::DeleteButtonController::hide): hides the existing interface
1862         (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
1863         * editing/DeleteButtonController.h: Added.
1864         (WebCore::DeleteButtonController::target): getter for the current target
1865         * editing/Editor.cpp:
1866         (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function
1867         (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client
1868         (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
1869         * editing/Editor.h:
1870         (WebCore::Editor::frame): new getter
1871         (WebCore::Editor::deleteButtonController): ditto
1872         * editing/SelectionController.cpp:
1873         (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
1874         * html/HTMLImageElement.h:
1875         (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
1876         * html/HTMLImageLoader.cpp:
1877         (WebCore::HTMLImageLoader::setImage): ditto
1878         * html/HTMLImageLoader.h:
1879         * loader/CachedImage.cpp:
1880         (WebCore::CachedImage::CachedImage): new constructor that takes an Image
1881         * loader/CachedImage.h: ditto
1882         * page/Frame.cpp:
1883         (WebCore::Frame::selectionController): cleanup coding style
1884         (WebCore::Frame::editor): ditto
1885         (WebCore::Frame::command): ditto
1886         (WebCore::Frame::appliedEditing): tell the delete button outline to update
1887         (WebCore::Frame::unappliedEditing): ditto
1888         (WebCore::Frame::reappliedEditing): ditto
1889         * rendering/RenderTable.cpp:
1890         (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed
1891
1892 2006-10-21  Sam Weinig  <sam.weinig@gmail.com>
1893
1894         Reviewed by Tim H.
1895
1896         Cleanup bindings generation a little through re-factoring 
1897         and general style cleanup.
1898
1899         * bindings/scripts/CodeGenerator.pm:
1900         * bindings/scripts/CodeGeneratorJS.pm:
1901         * bindings/scripts/CodeGeneratorObjC.pm:
1902
1903 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
1904
1905         Reviewed by Mitz.
1906
1907         Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.
1908
1909         * CMakeLists.txt:
1910         * platform/qt/EditorClientQt.cpp: Added.
1911         (WebCore::EditorClientQt::shouldDeleteRange):
1912         * platform/qt/EditorClientQt.h: Added.
1913         (WebCore::EditorClientQt::~EditorClientQt):
1914         * platform/qt/FrameQt.cpp:
1915         (WebCore::FrameQt::FrameQt):
1916         * platform/qt/FrameQt.h:
1917
1918 2006-10-21  Sam Weinig  <sam.weinig@gmail.com>
1919
1920         Reviewed by Tim H.
1921
1922         Fix for http://bugs.webkit.org/show_bug.cgi?id=11372
1923         Auto-generate a few more Objective-C DOM methods.
1924
1925         - Auto-generate getMatchedCSSRules and getComputedStyle methods.
1926
1927         * bindings/objc/DOMCSS.h:
1928         * bindings/objc/DOMCSS.mm:
1929         * bindings/objc/DOMExtensions.h:
1930         * bindings/objc/PublicDOMInterfaces.h:
1931         * bindings/scripts/CodeGeneratorObjC.pm:
1932         * dom/Document.idl:
1933         * page/DOMWindow.idl:
1934
1935 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
1936
1937         Reviewed by aliu, landed by aliu.
1938
1939         Fix Qt/Linux build.
1940
1941         * CMakeLists.txt:
1942         * platform/qt/FrameQt.cpp:
1943         (WebCore::FrameQt::FrameQt):
1944         * platform/qt/SoundQt.cpp: Added.
1945         (WebCore::systemBeep):
1946
1947 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
1948
1949         Reviewed by Mitz, landed by ap.
1950
1951         Fix obscure crashes in RenderTableSection on Rob's musicdb file.
1952         The problem was a missing layout() call on the frame view.
1953         Thanks go to Mitz Pettel for the initial hint!
1954
1955         * platform/qt/ScrollViewCanvasQt.cpp:
1956         (WebCore::ScrollViewCanvasQt::paintEvent):
1957
1958 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
1959
1960         Reviewed by Anders.
1961
1962         Send User-Agent on requests.
1963         Send custom request headers properly.
1964
1965         * platform/cf/ResourceLoaderCFNet.cpp:
1966         (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing
1967         (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
1968
1969 2006-10-20  Timothy Hatcher  <timothy@apple.com>
1970
1971         Reviewed by Hyatt.
1972
1973         Fix some bad formatting.
1974
1975         * css/cssstyleselector.cpp:
1976         (WebCore::CSSStyleSelector::checkOneSelector):
1977
1978 2006-10-20  Darin Adler  <darin@apple.com>
1979
1980         Reviewed by John.
1981
1982         - fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
1983
1984         * loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key"
1985         as the key, not the dictionary itself.
1986
1987 2006-10-20  Alice Liu  <alice.liu@apple.com>
1988
1989         Reviewed by Maciej.
1990
1991         This is the initial foundation for the EditingController class and
1992         everything else it needs to work.  The idea is that the Frame has an
1993         EditingController object that it calls to handle editing commands, the
1994         most simple examples being copy/paste.  This controller will handle
1995         these editing commands in WebCore, and only hand off to WebKit to call
1996         editing delegates (to the let the app intercept editing actions if it
1997         wants to).  Thus we need a platform-specific client to which the
1998         EditingController hands off the delegate calls, 
1999         WebCoreEditingControllerClient.  On the WebCore side this is an 
2000         abstract base class, and on the WebKit(Mac) side this is an ObjC++
2001         subclass, WebEditingControllerClient.  How does the EditingController
2002         get a handle to its platform-specific client?  In WebKit, the creator
2003         of a platform-specific Frame creates the client (which is ref-counted)
2004         and passes it down the chain of constructors until it gets back to the
2005         EditingController, which then refs it in its constructor and derefs in
2006         its destructor.
2007         
2008         No Layout tests needed.
2009         
2010         * WebCore.xcodeproj/project.pbxproj:
2011         Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
2012
2013         * bridge/EditorClient.h: Added.
2014         (WebCore::EditorClient::~EditorClient):
2015
2016         * bridge/mac/FrameMac.h:
2017         Added an EditingClient to the constructor, to pass down to Frame constructor
2018
2019         * bridge/mac/FrameMac.mm:
2020         (WebCore::FrameMac::FrameMac):
2021         Passed client down to Frame constructor
2022         
2023         * bridge/mac/WebCoreFrameBridge.h:
2024         Added an EditingClient to the constructor, to pass down to FrameMac constructor
2025         
2026         * bridge/mac/WebCoreFrameBridge.mm:
2027         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
2028         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
2029         Passed client down to FrameMac constructor
2030         
2031         * editing/Editor.cpp: Added.
2032         Mostly stuf implementations of the following functions, except for a couple.  These are all needed by cut, copy, paste, delete.
2033         (WebCore::generalPasteboard):
2034         (WebCore::Editor::canCopy):
2035         (WebCore::Editor::canCut):
2036         (WebCore::Editor::canDelete):
2037         (WebCore::Editor::canDeleteRange):
2038         (WebCore::Editor::canPaste):
2039         (WebCore::Editor::canSmartCopyOrDelete):
2040         (WebCore::Editor::deleteSelection):
2041         (WebCore::Editor::deleteSelectionWithSmartDelete):
2042         (WebCore::Editor::isSelectionRichlyEditable):
2043         (WebCore::Editor::pasteAsPlainTextWithPasteboard):
2044         (WebCore::Editor::pasteWithPasteboard):
2045         (WebCore::Editor::selectedRange):
2046         (WebCore::Editor::shouldDeleteRange):
2047         (WebCore::Editor::tryDHTMLCopy):
2048         (WebCore::Editor::tryDHTMLCut):
2049         (WebCore::Editor::tryDHTMLPaste):
2050         (WebCore::Editor::writeSelectionToPasteboard):
2051         (WebCore::Editor::Editor):
2052         (WebCore::Editor::~Editor):
2053         (WebCore::Editor::cut):
2054         (WebCore::Editor::copy):
2055         (WebCore::Editor::paste):
2056         (WebCore::Editor::performDelete):
2057         
2058         * editing/Editor.h: Added.
2059         
2060         * page/Frame.h:
2061         Added an EditingClient to the constructor, to pass down to Editor constructor
2062
2063         * page/Frame.cpp:
2064         (WebCore::Frame::Frame):
2065         Passed down to Editor constructor
2066         (WebCore::Frame::editor):
2067         Accessor for Editor stored in FramePrivate
2068         
2069         * page/FramePrivate.h:
2070         (WebCore::FramePrivate::FramePrivate):
2071         Added an Editor object to the FramePrivate data
2072         
2073         * platform/Sound.h: Added.
2074         Made a platform-independent accessor to a beep function
2075         
2076         * platform/mac/SoundMac.mm: Added.
2077         (WebCore::systemBeep):
2078         calls mac system beep
2079         
2080 2006-10-20  David Hyatt  <hyatt@apple.com>
2081
2082         Make sure to support the "encoding" property on form elements for
2083         legacy compatibility.
2084
2085         Reviewed by darin/john
2086
2087         No test cases added.  Not sure how to do a form submission of
2088         various encodings as a layout test.
2089
2090         * html/HTMLFormElement.h:
2091         (WebCore::HTMLFormElement::encoding):
2092         (WebCore::HTMLFormElement::setEncoding):
2093         * html/HTMLFormElement.idl:
2094
2095 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
2096
2097         Reviewed and by Anders.
2098
2099         Fix warnings in JS generation by killing the whole isRefPtr logic,
2100         and just using WTF::getPtr as Sam Weinig suggested. Also kill some
2101         places using get() where getPtr() is cleaner - not for m_impl.get().
2102
2103         * CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
2104         * bindings/scripts/CodeGeneratorJS.pm:
2105
2106 2006-10-20  Darin Adler  <darin@apple.com>
2107
2108         - rolled out my loader change; caused world leak and possibly a plug-in crash
2109
2110 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
2111
2112         Reviewed by Tim H
2113
2114         * loader/mac/LoaderFunctionsMac.mm:
2115         Autorelease the header NSDictionary.
2116         
2117 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
2118
2119         Reviewed by Geoff.
2120
2121         * bindings/js/kjs_window.cpp:
2122         (KJS::Window::timerFired):
2123         Check if the timeout id is still in the table before trying to access it. If it isn't in the table
2124         it has been deleted inside of the execute method.
2125
2126 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
2127
2128         Reviewed by Darin and Geoff.
2129
2130         Remove debugging output.
2131         * xml/xmlhttprequest.cpp:
2132         (WebCore::XMLHttpRequest::send):
2133
2134 2006-10-20  David Harrison  <harrison@apple.com>
2135
2136         Reviewed by John.
2137
2138         <rdar://problem/4792755> REGRESSON: Drag selecting is erratic
2139
2140         No test because it would require autoscrolling, which is not available to layout tests.
2141
2142         * rendering/RenderLayer.cpp:
2143         (WebCore::RenderLayer::autoscroll):
2144         Use hitTest() to find the correct node.
2145         
2146         (WebCore::RenderLayer::hitTest):
2147         Trivial source formatting.
2148
2149 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
2150
2151         Reviewed and landed by Anders.
2152
2153         Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).
2154
2155         * platform/qt/ResourceLoaderManager.cpp:
2156         (WebCore::ResourceLoaderManager::add):
2157
2158 2006-10-20  Darin Adler  <darin@apple.com>
2159
2160         Reviewed by Adele.
2161
2162         - convert WebLoader and its 3 subclasses to C++
2163
2164         Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
2165         there's currently another class with that name).
2166         Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
2167         Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
2168         Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
2169
2170         Converted the classes to C++ and added Objective-C delegates to forward from
2171         API that still requires Objective-C.
2172
2173         Did not yet rename the source files.
2174
2175         * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
2176         classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
2177         classes.
2178
2179         * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
2180
2181         * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
2182
2183         * loader/mac/WebLoader.h:
2184         * loader/mac/WebLoader.mm:
2185         * loader/mac/WebMainResourceLoader.h:
2186         * loader/mac/WebMainResourceLoader.mm:
2187         * loader/mac/WebNetscapePlugInStreamLoader.h:
2188         * loader/mac/WebNetscapePlugInStreamLoader.mm:
2189         * loader/mac/WebSubresourceLoader.h:
2190         * loader/mac/WebSubresourceLoader.mm:
2191         Translate to C++.
2192
2193         * bridge/mac/WebCoreFrameBridge.mm:
2194         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2195         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2196         * loader/mac/WebFrameLoader.h:
2197         * loader/mac/WebFrameLoader.mm:
2198         (isCaseInsensitiveEqual):
2199         (isBackForwardLoadType):
2200         (-[WebFrameLoader dealloc]):
2201         (-[WebFrameLoader addPlugInStreamLoader:]):
2202         (-[WebFrameLoader removePlugInStreamLoader:]):
2203         (-[WebFrameLoader setDefersCallbacks:]):
2204         (-[WebFrameLoader stopLoadingPlugIns]):
2205         (-[WebFrameLoader isLoadingMainResource]):
2206         (-[WebFrameLoader isLoadingSubresources]):
2207         (-[WebFrameLoader isLoadingPlugIns]):
2208         (-[WebFrameLoader stopLoadingSubresources]):
2209         (-[WebFrameLoader addSubresourceLoader:]):
2210         (-[WebFrameLoader removeSubresourceLoader:]):
2211         (-[WebFrameLoader mainResourceData]):
2212         (-[WebFrameLoader releaseMainResourceLoader]):
2213         (-[WebFrameLoader cancelMainResourceLoad]):
2214         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
2215         (-[WebFrameLoader stopLoadingWithError:]):
2216         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2217         (-[WebFrameLoader archiveLoadPendingForLoader:]):
2218         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
2219         * loader/mac/WebFrameLoaderClient.h:
2220         Call the new C++ API.
2221
2222 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
2223
2224         Reviewed and landed by Anders.
2225
2226         Offer a way for WebKitPart to be able to detect when
2227         the webpage has been completly loaded (including subresources).
2228
2229         Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
2230         and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.
2231
2232         * CMakeLists.txt:
2233         * platform/qt/FrameQt.cpp:
2234         (WebCore::FrameQt::submitForm):
2235         (WebCore::FrameQt::client):
2236         * platform/qt/FrameQt.h:
2237         * platform/qt/FrameQtClient.cpp:
2238         (WebCore::FrameQtClientDefault::setFrame):
2239         (WebCore::FrameQtClientDefault::openURL):
2240         (WebCore::FrameQtClientDefault::submitForm):
2241         (WebCore::FrameQtClientDefault::checkLoaded):
2242         (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin):
2243         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2244         (WebCore::FrameQtClientDefault::receivedAllData):
2245         * platform/qt/FrameQtClient.h:
2246         * platform/qt/LoaderFunctionsQt.cpp:
2247         (WebCore::CheckCacheObjectStatus):
2248         * platform/qt/PopupMenuQt.cpp:
2249         * platform/qt/ResourceLoaderManager.cpp:
2250         (WebCore::ResourceLoaderManager::ResourceLoaderManager):
2251         (WebCore::ResourceLoaderManager::slotResult):
2252         (WebCore::ResourceLoaderManager::add):
2253         * platform/qt/ResourceLoaderManager.h:
2254         * platform/qt/ResourceLoaderQt.cpp:
2255         (WebCore::ResourceLoader::start):
2256
2257 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
2258
2259         Reviewed by Geoff.
2260
2261         Fix compiler warnings
2262
2263         * platform/ResourceLoaderClient.h:
2264
2265 2006-10-20  Sam Weinig  <sam.weinig@gmail.com>
2266
2267         Reviewed by Mitz.
2268
2269         Win32 build fix and cleanup.
2270
2271         * WebCore.vcproj/WebCore/WebCore.vcproj:
2272         * bridge/win/FrameWin.cpp:
2273         (WebCore::FrameWin::FrameWin):
2274         (WebCore::FrameWin::submitForm):
2275         * page/ResourceRequest.h:
2276         (WebCore::ResourceRequest::addHTTPHeaderField):
2277         * platform/win/TemporaryLinkStubs.cpp:
2278         (WebCore::Slider::~Slider):
2279         (WebCore::Slider::setMinValue):
2280         (WebCore::searchableIndexIntroduction):
2281         (WebCore::findNextSentenceFromIndex):
2282         (WebCore::findSentenceBoundary):
2283         (WebCore::findNextWordFromIndex):
2284         (WebCore::FrameWin::getObjectInstanceForWidget):
2285         (WebCore::FrameWin::getEmbedInstanceForWidget):
2286         (WebCore::FrameWin::runJavaScriptPrompt):
2287         (WebCore::FrameWin::restoreDocumentState):
2288         (WebCore::FrameWin::partClearedInBegin):
2289         (WebCore::FrameWin::createEmptyDocument):
2290         (WebCore::FrameWin::overrideMediaType):
2291         (WebCore::FrameWin::markedTextRange):
2292         (WebCore::FrameWin::passSubframeEventToSubframe):
2293         (WebCore::FrameWin::lastEventIsMouseUp):
2294         (WebCore::FrameWin::addMessageToConsole):
2295         (WebCore::FrameWin::shouldChangeSelection):
2296         (WebCore::FrameWin::respondToChangedSelection):
2297         (WebCore::FrameWin::createFrame):
2298         (WebCore::FrameWin::saveDocumentState):
2299         (WebCore::FrameWin::clearUndoRedoOperations):
2300         (WebCore::FrameWin::incomingReferrer):
2301         (WebCore::FrameWin::markMisspellingsInAdjacentWords):
2302         (WebCore::FrameWin::respondToChangedContents):
2303         (WebCore::FrameWin::handledOnloadEvents):
2304         (WebCore::FrameWin::createPlugin):
2305         (WebCore::FrameWin::objectContentType):
2306         (WebCore::screenDepthPerComponent):
2307         (WebCore::screenIsMonochrome):
2308         (WebCore::historyContains):
2309         (WebCore::submitButtonDefaultLabel):
2310         (WebCore::inputElementAltText):
2311         (WebCore::resetButtonDefaultLabel):
2312         (WebCore::fileButtonChooseFileLabel):
2313         (WebCore::fileButtonNoFileSelectedLabel):
2314         (WebCore::defaultLanguage):
2315         (WebCore::findWordBoundary):
2316         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
2317         (WebCore::PlugInInfoStore::supportsMIMEType):
2318         (WebCore::refreshPlugins):
2319         (WebCore::ResourceLoader::assembleResponseHeaders):
2320         (WebCore::ResourceLoader::retrieveResponseEncoding):
2321         (WebCore::ResourceLoader::startHTTPRequest):
2322         (WebCore::TextField::TextField):
2323         (WebCore::focusRingColor):
2324         (WebCore::setFocusRingColorChangeFunction):
2325         (WebCore::PopupMenu::~PopupMenu):
2326         (WebCore::PopupMenu::hide):
2327
2328 2006-10-20  Rob Buis  <buis@kde.org>
2329
2330         Reviewed by Darin.
2331
2332         http://bugs.webkit.org/show_bug.cgi?id=11303
2333         Path::transform() should be implemented on Qt build
2334
2335         Use QPainterPath API to implement Path::transform.
2336         This fixes svg/custom/clip-path-with-transform.svg on
2337         the qt build.
2338
2339         * platform/qt/PathQt.cpp:
2340         (WebCore::Path::transform):
2341
2342 2006-10-20  Rob Buis  <buis@kde.org>
2343
2344         Reviewed by Mitz.
2345
2346         http://bugs.webkit.org/show_bug.cgi?id=11217
2347         Cleanup svg coding style
2348
2349         Cleanup coding style in svg clipping and painting classes.
2350
2351         * ksvg2/svg/SVGClipPathElement.cpp:
2352         (WebCore::SVGClipPathElement::parseMappedAttribute):
2353         (WebCore::SVGClipPathElement::canvasResource):
2354         * ksvg2/svg/SVGClipPathElement.h:
2355         * ksvg2/svg/SVGMarkerElement.cpp:
2356         (WebCore::SVGMarkerElement::SVGMarkerElement):
2357         (WebCore::SVGMarkerElement::parseMappedAttribute):
2358         (WebCore::SVGMarkerElement::setOrientToAngle):
2359         (WebCore::SVGMarkerElement::canvasResource):
2360         * ksvg2/svg/SVGMarkerElement.h:
2361         (WebCore::SVGMarkerElement::rendererIsNeeded):
2362         * ksvg2/svg/SVGMaskElement.cpp:
2363         (WebCore::SVGMaskElement::SVGMaskElement):
2364         (WebCore::SVGMaskElement::parseMappedAttribute):
2365         (WebCore::SVGMaskElement::drawMaskerContent):
2366         (WebCore::SVGMaskElement::canvasResource):
2367         * ksvg2/svg/SVGMaskElement.h:
2368         (WebCore::SVGMaskElement::rendererIsNeeded):
2369         * ksvg2/svg/SVGPaint.cpp:
2370         (WebCore::SVGPaint::setPaint):
2371         (WebCore::SVGPaint::cssText):
2372         * ksvg2/svg/SVGPaint.h:
2373
2374 2006-10-20  David Hyatt  <hyatt@apple.com>
2375
2376         Make sure to do the code that checks the repeatInterval before the timer has been
2377         deleted. (Duh.)
2378
2379         Reviewed by andersca
2380
2381         * bindings/js/kjs_window.cpp:
2382         (KJS::DOMWindowTimer::setNestingLevel):
2383         (KJS::Window::timerFired):
2384         (KJS::DOMWindowTimer::fired):
2385         * platform/Timer.h:
2386
2387 2006-10-20  David Hyatt  <hyatt@apple.com>
2388
2389         Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
2390         At that point clamp to 10ms to prevent excessive CPU usage.
2391
2392         Reviewed by anders
2393
2394         * bindings/js/kjs_window.cpp:
2395         (KJS::DOMWindowTimer::DOMWindowTimer):
2396         (KJS::DOMWindowTimer::nestingLevel):
2397         (KJS::Window::installTimeout):
2398         (KJS::Window::pauseTimeouts):
2399         (KJS::Window::resumeTimeouts):
2400         (KJS::DOMWindowTimer::fired):
2401         * platform/Timer.h:
2402         (WebCore::TimerBase::startRepeating):
2403         (WebCore::TimerBase::startOneShot):
2404         (WebCore::TimerBase::repeatInterval):
2405         (WebCore::TimerBase::augmentRepeatInterval):
2406         (WebCore::TimerBase::inHeap):
2407         (WebCore::Timer::Timer):
2408         (WebCore::Timer::fired):
2409
2410 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
2411
2412         Build fix
2413
2414         * ksvg2/svg/SVGAElement.cpp:
2415         (WebCore::SVGAElement::defaultEventHandler):
2416
2417 2006-10-19  Steve Falkenburg  <sfalken@apple.com>
2418
2419         Reviewed by Adam.
2420
2421         Use GetKeyState rather than GetAsyncKeyState since we're
2422         calling in these cases in direct response to an event, and want the
2423         key state associated with that event.
2424         
2425         Pass triggering event to url selection method.
2426         
2427         * bridge/mac/FrameMac.h: Add triggeringEvent parameter
2428         * bridge/mac/FrameMac.mm:
2429         (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
2430         * bridge/win/FrameWin.cpp:
2431         (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
2432         * bridge/win/FrameWin.h: Add triggeringEvent parameter
2433         * html/HTMLAnchorElement.cpp:
2434         (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
2435         * page/Frame.cpp:
2436         (WebCore::Frame::changeLocation): Add 0 as triggeringEvent
2437         (WebCore::Frame::urlSelected): Pass through triggeringEvent
2438         * page/Frame.h: Add triggeringEvent parameter to urlSelected methods
2439         * platform/win/KeyEventWin.cpp:
2440         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
2441         * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState
2442         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2443
2444 2006-10-19  David Hyatt  <hyatt@apple.com>
2445
2446         Correct typos from changing "flush" to "prune" using automated search/replace.
2447
2448         Change the cache heuristic for flushing to allow a higher watermark before initiating an
2449         aggressive prune.  This ensures that small cache sizes are no worse in terms of performance
2450         than the old buggy cache.
2451
2452         Make sizes unsigned instead of ints in the cache's APIs and member variables.
2453
2454         * loader/Cache.cpp:
2455         (WebCore::Cache::prune):
2456         (WebCore::Cache::setMaximumSize):
2457         * loader/Cache.h:
2458         (WebCore::Cache::maximumSize):
2459
2460 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
2461
2462         Reviewed by Daddy Hyatt.
2463
2464         Use a real hash map for the headers.
2465
2466         * loader/LoaderFunctions.h:
2467         * loader/mac/LoaderFunctionsMac.mm:
2468         (WebCore::ServeSynchronousRequest):
2469         * platform/ResourceLoader.cpp:
2470         (WebCore::ResourceLoader::setRequestHeaders):
2471         (WebCore::ResourceLoader::requestHeaders):
2472         * platform/ResourceLoader.h:
2473         * platform/ResourceLoaderInternal.h:
2474         * platform/mac/ResourceLoaderMac.mm:
2475         (WebCore::ResourceLoader::start):
2476         * xml/xmlhttprequest.cpp:
2477         (WebCore::XMLHttpRequest::open):
2478         (WebCore::XMLHttpRequest::send):
2479         (WebCore::XMLHttpRequest::setRequestHeader):
2480         (WebCore::XMLHttpRequest::getRequestHeader):
2481         * xml/xmlhttprequest.h:
2482
2483 2006-10-19  Adam Roben  <aroben@apple.com>
2484
2485         Reviewed by Ada.
2486
2487         Pippity-poppity popup tweaks.
2488
2489         * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
2490         * html/HTMLSelectElement.cpp:
2491         (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if
2492         requested and the new index is actually different than the old one.
2493         * platform/IntPoint.h: Added another casting operator.
2494         * platform/PopupMenu.cpp: Removed. The code in here, while
2495         platform-independent, was only useful for the NSPopUpButtonCell
2496         implementation of popup menus, so I've moved it to PopupMenuMac.mm.
2497         * platform/PopupMenu.h: Moved the definition of PopupMenu::create into
2498         the header since it's fairly simple. Made some more methods private now
2499         that we don't have subclasses and virtual methods anymore.
2500         (WebCore::PopupMenu::create):
2501         (WebCore::PopupMenu::menuList):
2502         (WebCore::PopupMenu::itemHeight):
2503         (WebCore::PopupMenu::windowRect):
2504         (WebCore::PopupMenu::listIndexAtPoint):
2505         (WebCore::PopupMenu::focusedIndex):
2506         (WebCore::PopupMenu::setWasClicked):
2507         (WebCore::PopupMenu::wasClicked):
2508         (WebCore::PopupMenu::setScrollOffset):
2509         (WebCore::PopupMenu::scrollOffset):
2510         (WebCore::PopupMenu::wheelDelta):
2511         * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp.
2512         (WebCore::PopupMenu::populate): Call our own clear() method to clear
2513         the menu.
2514         * platform/win/IntPointWin.cpp: New casting operator.
2515         (WebCore::IntPoint::IntPoint):
2516         (WebCore::IntPoint::operator POINTS):
2517
2518 2006-10-19  Adam Roben  <aroben@apple.com>
2519
2520         Reviewed by Darin.
2521
2522         Cleaning up Document::nextFocusNode and Document::previousFocusNode.
2523
2524         * dom/Document.cpp:
2525         (WebCore::Document::nextFocusNode):
2526         (WebCore::Document::previousFocusNode):
2527
2528 2006-10-19  Maciej Stachowiak  <mjs@apple.com>
2529
2530         Reviewed by Geoff.
2531
2532         - implement new ResourceRequest API and fix up code as appropriate
2533         
2534         * bindings/js/kjs_window.cpp:
2535         (KJS::createNewWindow):
2536         (KJS::WindowFunc::callAsFunction):
2537         * bridge/mac/BrowserExtensionMac.mm:
2538         (WebCore::BrowserExtensionMac::createNewWindow):
2539         * bridge/mac/FrameMac.mm:
2540         (WebCore::FrameMac::submitForm):
2541         (WebCore::FrameMac::openURLRequest):
2542         (WebCore::FrameMac::urlSelected):
2543         * bridge/mac/WebCoreFrameBridge.mm:
2544         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
2545         * dom/DOMImplementation.cpp:
2546         (WebCore::addString):
2547         (WebCore::isSVG10Feature):
2548         (WebCore::isSVG11Feature):
2549         * dom/Document.h:
2550         * editing/CommandByName.cpp:
2551         * editing/JSEditor.cpp:
2552         * page/Frame.cpp:
2553         (WebCore::Frame::changeLocation):
2554         (WebCore::Frame::urlSelected):
2555         (WebCore::Frame::requestFrame):
2556         (WebCore::Frame::submitForm):
2557         * page/Frame.h:
2558         * page/FramePrivate.h:
2559         * page/ResourceRequest.h:
2560         (WebCore::):
2561         (WebCore::ResourceRequest::ResourceRequest):
2562         (WebCore::ResourceRequest::cachePolicy):
2563         (WebCore::ResourceRequest::setCachePolicy):
2564         (WebCore::ResourceRequest::timeoutInterval):
2565         (WebCore::ResourceRequest::setTimeoutInterval):
2566         (WebCore::ResourceRequest::mainDocumentURL):
2567         (WebCore::ResourceRequest::setMainDocumentURL):
2568         (WebCore::ResourceRequest::httpMethod):
2569         (WebCore::ResourceRequest::setHTTPMethod):
2570         (WebCore::ResourceRequest::httpHeaderField):
2571         (WebCore::ResourceRequest::setHTTPHeaderField):
2572         (WebCore::ResourceRequest::httpContentType):
2573         (WebCore::ResourceRequest::setHTTPContentType):
2574         (WebCore::ResourceRequest::httpReferrer):
2575         (WebCore::ResourceRequest::setHTTPReferrer):
2576         (WebCore::ResourceRequest::httpUserAgent):
2577         (WebCore::ResourceRequest::setHTTPUserAgent):
2578         (WebCore::ResourceRequest::httpBody):
2579         (WebCore::ResourceRequest::setHTTPBody):
2580         (WebCore::ResourceRequest::addHTTPHeaderField):
2581         * platform/FontCache.cpp:
2582         (WebCore::computeHash):
2583         * platform/StringHash.h:
2584         (WTF::):
2585         * platform/StringImpl.cpp:
2586         (WebCore::equalIgnoringCase):
2587         * rendering/RenderPartObject.cpp:
2588         (WebCore::RenderPartObject::updateWidget):
2589
2590 2006-10-19  Justin Garcia  <justin.garcia@apple.com>
2591
2592         Reviewed by levi
2593         
2594         <rdar://problem/4447885>
2595         API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
2596         
2597         Fixed indent/outdent to only increment the left margin, to match other browsers.
2598         Used blockquote class="webkit-indent-blockquote" to do this.  Mail can now
2599         implement indent/outdent by customizing the appearance of these blockquotes,
2600         instead of using a new API.
2601         
2602         * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
2603         * editing/IndentOutdentCommand.cpp:
2604         (WebCore::indentBlockquoteString): Added.
2605         (WebCore::createIndentBlockquoteElement): Added.
2606         (WebCore::isIndentBlockquote): Added.
2607         (WebCore::isListOrBlockquote): Added.
2608         (WebCore::IndentOutdentCommand::IndentOutdentCommand):
2609         (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed
2610         a bug in the code that added an extra br if the placeholder collapsed upon insertion.
2611         Used the new indentBlockquote checks and enclosing element getters.  
2612         (WebCore::IndentOutdentCommand::indentRegion): Ditto.
2613         (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.  Cleaned up the
2614         logic to pull the selection out of a list a bit.
2615         * editing/htmlediting.cpp:
2616         (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
2617         * editing/htmlediting.h:
2618
2619 2006-10-19  Timothy Hatcher  <timothy@apple.com>
2620
2621         Rolling out the this change since it caused a bad regression:
2622         <rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)
2623
2624 2006-10-12  Adele Peterson  <adele@apple.com>
2625           
2626         Reviewed by Dave Harrison.
2627           
2628         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
2629           
2630         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
2631         Make subtree layouts work for textareas as well as text fields.
2632
2633 2006-10-19  Nikolas Zimmermann  <zimmermann@kde.org>
2634
2635         Reviewed and landed by Anders.
2636
2637         Fix Qt/Linux build.
2638
2639         * CMakeLists.txt:
2640         * loader/Cache.h:
2641         * platform/qt/BrowserExtensionQt.cpp:
2642         * platform/qt/BrowserExtensionQt.h:
2643         * platform/qt/CursorQt.cpp:
2644         (WebCore::pointerCursor):
2645         * platform/qt/LoaderFunctionsQt.cpp:
2646         (WebCore::NumberOfPendingOrLoadingRequests):
2647         (WebCore::CheckCacheObjectStatus):
2648         * platform/qt/ResourceLoaderQt.cpp:
2649         (WebCore::ResourceLoader::retrieveResponseEncoding):
2650         (WebCore::ResourceLoader::receivedResponse):
2651
2652 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
2653
2654         Reviewed by ap.
2655
2656         Win32 build fix.
2657
2658         * bridge/win/FrameWin.cpp:
2659         * bridge/win/FrameWin.h:
2660         * platform/win/TemporaryLinkStubs.cpp:
2661         (WebCore::ResourceLoader::retrieveResponseEncoding):
2662
2663 2006-10-19  Alexey Proskuryakov  <ap@nypop.com>
2664
2665         Reviewed by Mitz.
2666
2667         http://bugs.webkit.org/show_bug.cgi?id=11141
2668         REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element
2669
2670         Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
2671         to document URL. This matches WinIE and partially matches Firefox - although the latter
2672         reports the href as if it were inherited, it still doesn't use it when resolving URIs in
2673         @import rules.
2674
2675         Test: http/tests/uri/css-href.php
2676
2677         * html/HTMLStyleElement.cpp:
2678         (WebCore::HTMLStyleElement::childrenChanged):
2679         * ksvg2/svg/SVGStyleElement.cpp:
2680         (WebCore::SVGStyleElement::childrenChanged):
2681
2682 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
2683
2684         * loader/Cache.cpp:
2685         Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems
2686         with case-sensitive file systems.
2687
2688 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
2689
2690         Reviewed by Maciej, Brady.
2691
2692         Remove "charset" from the ResourceLoader metadata map and use 
2693         a getter function instead. Also, rename charset to encoding in a couple of places.
2694         
2695         * loader/CachedCSSStyleSheet.cpp:
2696         (WebCore::CachedCSSStyleSheet::setEncoding):
2697         * loader/CachedCSSStyleSheet.h:
2698         * loader/CachedResource.h:
2699         (WebCore::CachedResource::setEncoding):
2700         * loader/CachedScript.cpp:
2701         (WebCore::CachedScript::setEncoding):
2702         * loader/CachedScript.h:
2703         * loader/CachedXBLDocument.cpp:
2704         (WebCore::CachedXBLDocument::setEncoding):
2705         * loader/CachedXBLDocument.h:
2706         * loader/CachedXSLStyleSheet.cpp:
2707         (WebCore::CachedXSLStyleSheet::setEncoding):
2708         * loader/CachedXSLStyleSheet.h:
2709         * loader/loader.cpp:
2710         (WebCore::Loader::receivedResponse):
2711         * platform/ResourceLoader.cpp:
2712         (WebCore::ResourceLoader::responseEncoding):
2713         (WebCore::ResourceLoader::queryMetaData):
2714         * platform/ResourceLoader.h:
2715         * platform/ResourceLoaderInternal.h:
2716         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2717         * platform/mac/ResourceLoaderMac.mm:
2718         (WebCore::ResourceLoader::retrieveResponseEncoding):
2719         (WebCore::ResourceLoader::receivedResponse):
2720         * xml/xmlhttprequest.cpp:
2721         (WebCore::XMLHttpRequest::receivedData):
2722
2723 2006-10-19  David Hyatt  <hyatt@apple.com>
2724
2725         Rewrite of the WebCore memory cache.  The following changes have been made (along with many more):
2726
2727         (1) Referenced objects are now also cached.
2728
2729         (2) Pruning of the cache will occur once the cache is both full and in addition
2730         more than half full with unreferenced objects.
2731
2732         (3) The prune is much more aggressive now, since referenced objects are counted when
2733         pruning.  The cache will therefore often prune out every unreferenced object if lots of
2734         windows/tabs are open.
2735
2736         (4) Consolidated the request methods for various types of resources to go through a single
2737         requestResource bottleneck function.
2738
2739         (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
2740         identical.
2741
2742         (6) Changed "object" to "resource" everywhere.
2743
2744         (7) The Cache is now an actual object, obtained via cache().
2745
2746         (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
2747         and enabled.
2748
2749         (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.
2750
2751         (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
2752         in the LRU lists).  Also fixed a bug with the "-SP" part of the algorithm where the access count was
2753         being incorrectly weighted too much due to a math error.
2754
2755         (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
2756         the size of referenced resources.
2757
2758         Reviewed by Maciej, bradee-oh
2759
2760         * bridge/mac/WebCoreCache.mm:
2761         (+[WebCoreCache statistics]):
2762         (+[WebCoreCache empty]):
2763         (+[WebCoreCache setDisabled:]):
2764         * bridge/mac/WebCoreFrameBridge.mm:
2765         (-[WebCoreFrameBridge initMainFrameWithPage:]):
2766         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2767         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2768         * css/CSSImageValue.cpp:
2769         (WebCore::CSSImageValue::image):
2770         * dom/XMLTokenizer.cpp:
2771         (WebCore::openFunc):
2772         * html/HTMLImageLoader.cpp:
2773         (WebCore::HTMLImageLoader::updateFromElement):
2774         * loader/Cache.cpp:
2775         (WebCore::cache):
2776         (WebCore::Cache::Cache):
2777         (WebCore::createResource):
2778         (WebCore::Cache::requestResource):
2779         (WebCore::Cache::resourceForURL):
2780         (WebCore::Cache::prune):
2781         (WebCore::Cache::setMaximumSize):
2782         (WebCore::Cache::remove):
2783         (WebCore::Cache::addDocLoader):
2784         (WebCore::Cache::removeDocLoader):
2785         (WebCore::fastLog2):
2786         (WebCore::Cache::lruListFor):
2787         (WebCore::Cache::removeFromLRUList):
2788         (WebCore::Cache::insertInLRUList):
2789         (WebCore::Cache::resourceAccessed):
2790         (WebCore::Cache::adjustSize):
2791         (WebCore::Cache::getStatistics):
2792         (WebCore::Cache::setDisabled):
2793         * loader/Cache.h:
2794         (WebCore::LRUList::LRUList):
2795         (WebCore::Cache::loader):
2796         (WebCore::Cache::maximumSize):
2797         (WebCore::Cache::disabled):
2798         (WebCore::Cache::addToLiveObjectSize):
2799         (WebCore::Cache::removeFromLiveObjectSize):
2800         (WebCore::Cache::TypeStatistic::TypeStatistic):
2801         * loader/CachedCSSStyleSheet.cpp:
2802         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2803         * loader/CachedCSSStyleSheet.h:
2804         * loader/CachedImage.cpp:
2805         (WebCore::CachedImage::CachedImage):
2806         (WebCore::CachedImage::~CachedImage):
2807         (WebCore::brokenImage):
2808         (WebCore::nullImage):
2809         (WebCore::CachedImage::image):
2810         (WebCore::CachedImage::data):
2811         * loader/CachedImage.h:
2812         (WebCore::CachedImage::stillNeedsLoad):
2813         * loader/CachedResource.cpp:
2814         (WebCore::CachedResource::CachedResource):
2815         (WebCore::CachedResource::~CachedResource):
2816         (WebCore::CachedResource::finish):
2817         (WebCore::CachedResource::setExpireDate):
2818         (WebCore::CachedResource::isExpired):
2819         (WebCore::CachedResource::setRequest):
2820         (WebCore::CachedResource::ref):
2821         (WebCore::CachedResource::deref):
2822         (WebCore::CachedResource::setSize):
2823         * loader/CachedResource.h:
2824         (WebCore::CachedResource::):
2825         (WebCore::CachedResource::setCharset):
2826         (WebCore::CachedResource::url):
2827         (WebCore::CachedResource::type):
2828         (WebCore::CachedResource::referenced):
2829         (WebCore::CachedResource::count):
2830         (WebCore::CachedResource::status):
2831         (WebCore::CachedResource::size):
2832         (WebCore::CachedResource::isLoaded):
2833         (WebCore::CachedResource::setLoading):
2834         (WebCore::CachedResource::isImage):
2835         (WebCore::CachedResource::accessCount):
2836         (WebCore::CachedResource::increaseAccessCount):
2837         (WebCore::CachedResource::setInCache):
2838         (WebCore::CachedResource::inCache):
2839         (WebCore::CachedResource::cachePolicy):
2840         (WebCore::CachedResource::response):
2841         (WebCore::CachedResource::allData):
2842         (WebCore::CachedResource::canDelete):
2843         (WebCore::CachedResource::schedule):
2844         (WebCore::CachedResource::accept):
2845         (WebCore::CachedResource::setAccept):
2846         * loader/CachedScript.cpp:
2847         (WebCore::CachedScript::CachedScript):
2848         * loader/CachedScript.h:
2849         * loader/CachedXBLDocument.cpp:
2850         * loader/CachedXBLDocument.h:
2851         * loader/CachedXSLStyleSheet.cpp:
2852         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2853         * loader/CachedXSLStyleSheet.h:
2854         * loader/DocLoader.cpp:
2855         (WebCore::DocLoader::DocLoader):
2856         (WebCore::DocLoader::~DocLoader):
2857         (WebCore::DocLoader::checkForReload):
2858         (WebCore::DocLoader::requestImage):
2859         (WebCore::DocLoader::requestCSSStyleSheet):
2860         (WebCore::DocLoader::requestScript):
2861         (WebCore::DocLoader::requestXSLStyleSheet):
2862         (WebCore::DocLoader::requestXBLDocument):
2863         (WebCore::DocLoader::requestResource):
2864         (WebCore::DocLoader::setAutoLoadImages):
2865         (WebCore::DocLoader::removeCachedResource):
2866         * loader/DocLoader.h:
2867         (WebCore::DocLoader::cachedResource):
2868         (WebCore::DocLoader::allCachedResources):
2869         (WebCore::DocLoader::autoLoadImages):
2870         (WebCore::DocLoader::cachePolicy):
2871         (WebCore::DocLoader::expireDate):
2872         (WebCore::DocLoader::frame):
2873         (WebCore::DocLoader::doc):
2874         (WebCore::DocLoader::loadInProgress):
2875         * loader/ImageDocument.cpp:
2876         (WebCore::ImageTokenizer::finish):
2877         * loader/loader.cpp:
2878         (WebCore::Loader::receivedAllData):
2879         (WebCore::Loader::cancelRequests):
2880         * loader/mac/LoaderFunctionsMac.mm:
2881         (WebCore::NumberOfPendingOrLoadingRequests):
2882         (WebCore::CheckCacheObjectStatus):
2883         * page/Frame.cpp:
2884         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
2885         (WebCore::Frame::Frame):
2886         (WebCore::Frame::stopLoading):
2887         (WebCore::Frame::setAutoLoadImages):
2888         (WebCore::Frame::autoLoadImages):
2889         (WebCore::Frame::begin):
2890         (WebCore::Frame::checkCompleted):
2891         (WebCore::Frame::reparseConfiguration):
2892         * page/Frame.h:
2893         * xml/XSLTProcessor.cpp:
2894         (WebCore::docLoaderFunc):
2895         * xml/xmlhttprequest.cpp:
2896         (WebCore::XMLHttpRequest::send):
2897
2898 2006-10-18  Maciej Stachowiak  <mjs@apple.com>
2899
2900         Reviewed by Geoff.
2901
2902         - remove vestiges of KXMLCore name (former name of WTF).
2903
2904         * config.h:
2905
2906 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
2907
2908         Reviewed by Beth.
2909         
2910         Fixed http://bugs.webkit.org/show_bug.cgi?id=11222
2911
2912         Some global JS objects lacked references to their property hashtables,
2913         so for-in enumeration didn't work. I added the references, and then removed
2914         a few bogus properties from the tables. The bogus ones got in there through
2915         bit rot.
2916         
2917         We should come up with some solution to these hand-written bindings bugs.
2918         Maybe we could use a script to autogenerate them or something.
2919
2920         * bindings/js/kjs_window.cpp:
2921         (KJS::):
2922         (KJS::History::getValueProperty):
2923
2924 2006-10-18  Adam Roben  <aroben@apple.com>
2925
2926         Reviewed by Brady.
2927
2928         Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
2929         U+000019 (Backtab). This matches our windowsKeyCode for this key
2930         combination.
2931
2932         * platform/mac/KeyEventMac.mm:
2933         (WebCore::keyIdentifierForKeyEvent):
2934
2935 2006-10-18  Steve Falkenburg  <sfalken@apple.com>
2936
2937         Reviewed by Adam, Brady.
2938
2939         Loader tweaks.
2940
2941         * platform/cf/ResourceLoaderCFNet.cpp:
2942         (WebCore::didFinishLoading):
2943         (WebCore::didFail):
2944         (WebCore::didReceiveChallenge):
2945         (WebCore::runLoaderThread):
2946         (WebCore::ResourceLoader::start):
2947         (WebCore::ResourceLoader::cancel):
2948
2949 2006-10-18  Timothy Hatcher  <timothy@apple.com>
2950
2951         Reviewed by Darin.
2952
2953         <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
2954
2955         - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
2956         - Convert more ObjC local statics and member variables to use RetainPtr.
2957         - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
2958
2959         * bindings/objc/DOM.mm:
2960         (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
2961         (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
2962         * bridge/mac/AXObjectCacheMac.mm:
2963         (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
2964         (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
2965         (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
2966         * bridge/mac/WebCoreFrameBridge.mm:
2967         (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
2968         (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
2969         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2970         (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
2971         * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
2972         * platform/cf/RetainPtr.h:
2973         (WTF::::operator): implement a missing operator= template function
2974         * platform/mac/PopupMenuMac.mm:
2975         (WebCore::PopupMenu::PopupMenu): remove nil initialization
2976         (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
2977         (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
2978         (WebCore::PopupMenu::populate): ditto 
2979         (WebCore::PopupMenu::show): ditto
2980         (WebCore::PopupMenu::hide): ditto
2981         (WebCore::PopupMenu::addSeparator): ditto
2982         (WebCore::PopupMenu::addGroupLabel): ditto
2983         (WebCore::PopupMenu::addOption): ditto
2984
2985 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
2986
2987         Reviewed by Adele.
2988
2989         Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
2990         are tracking or menus are down (run loop modes)
2991
2992         I spent a few hours trying to write an automated test, but DRT doesn't
2993         seem to support it. Manual tests attached to related bugs.
2994         
2995         * bridge/mac/FrameMac.mm:
2996         (WebCore::FrameMac::passMouseDownEventToWidget):
2997         * platform/mac/SharedTimerMac.cpp:
2998         (WebCore::setSharedTimerFireTime):
2999
3000 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
3001
3002         Reviewed by Maciej.
3003
3004         More Win32 buildfix.
3005
3006         * bridge/win/FrameWin.h:
3007
3008 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
3009
3010         Reviewed by Mitz
3011
3012         Win32 build fix.
3013
3014         * bridge/win/BrowserExtensionWin.cpp:
3015         (WebCore::BrowserExtensionWin::BrowserExtensionWin):
3016         (WebCore::BrowserExtensionWin::createNewWindow):
3017         * bridge/win/BrowserExtensionWin.h:
3018         * bridge/win/FrameWin.cpp:
3019         (WebCore::FrameWin::createNewWindow):
3020         * bridge/win/FrameWin.h:
3021         * platform/win/CursorWin.cpp:
3022         * platform/win/TemporaryLinkStubs.cpp:
3023         (Image::getHBITMAP):
3024
3025 2006-10-18  Justin Garcia  <justin.garcia@apple.com>
3026
3027         Reviewed by harrison
3028         
3029         <rdar://problem/4784823>
3030         GMail Editor: Hang occurs when removing list styling on text in a rich text message
3031
3032         List removal moves the contents of every list item out of the list it's 
3033         in. When the code tried to move the contents of an empty list item (an li 
3034         with no child nodes, not even a placeholder br), moveParagraph didn't prune 
3035         the li, like it would if the li had a placeholder inside it.  So the list 
3036         removal code went into an infinite loop, continually attempting to de-list 
3037         an empty list item.
3038
3039         * editing/CompositeEditCommand.cpp:
3040         (WebCore::CompositeEditCommand::moveParagraphs): If the selection
3041         to move was empty and in an empty block that doesn't require a 
3042         placeholder to prop itself open (like a bordered div or an li), 
3043         remove it during the move.
3044
3045 2006-10-18  Adele Peterson  <adele@apple.com>
3046
3047         Reviewed by Beth.
3048
3049         - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
3050           REGRESSION (r16975): fast/events/objc-event-api is failing
3051
3052           When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
3053           a call to invalidateClick.  This change moves it back to the sequence that existed before.  This allows
3054           the click count to get properly reset during a selection.
3055
3056         * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
3057
3058 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
3059         
3060         Reviewed by Anders.
3061         
3062         Factored common scaling code into a helper function.
3063
3064         * platform/mac/ScreenMac.mm:
3065         (WebCore::scale):
3066         (WebCore::scaleScreenRectToPageCoordinates):
3067         (WebCore::scalePageRectToScreenCoordinates):
3068
3069 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
3070
3071         Build fixes
3072
3073         * bridge/win/BrowserExtensionWin.cpp:
3074         (WebCore::BrowserExtensionWin::createNewWindow):
3075         * bridge/win/BrowserExtensionWin.h:
3076         * bridge/win/FrameWin.cpp:
3077         (WebCore::FrameWin::createNewWindow):
3078         * bridge/win/FrameWin.h:
3079         * platform/gdk/BrowserExtensionGdk.h:
3080         * platform/gdk/TemporaryLinkStubs.cpp:
3081         (BrowserExtensionGdk::createNewWindow):
3082         * platform/qt/BrowserExtensionQt.cpp:
3083         (WebCore::BrowserExtensionQt::createNewWindow):
3084         * platform/qt/BrowserExtensionQt.h:
3085
3086 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
3087
3088         Reviewed by Anders.
3089         
3090         Renamed WindowArgs to WindowFeatures, and moved it into its own header.
3091         ("Features" is the term of art in IE documentation. "Args" is pirate
3092         talk.)
3093
3094         * WebCore.xcodeproj/project.pbxproj:
3095         * bindings/js/kjs_window.cpp:
3096         (KJS::createNewWindow):
3097         (KJS::showModalDialog):
3098         (KJS::setWindowFeature):
3099         (KJS::parseWindowFeatures):
3100         (KJS::constrainToVisible):
3101         (KJS::WindowFunc::callAsFunction):
3102         * bridge/BrowserExtension.h:
3103         * bridge/WindowFeatures.h: Added.
3104         * bridge/mac/BrowserExtensionMac.h:
3105         * bridge/mac/BrowserExtensionMac.mm:
3106         (WebCore::BrowserExtensionMac::createNewWindow):
3107
3108 2006-10-17  Sam Weinig  <sam.weinig@gmail.com>
3109
3110         Reviewed by Tim H.
3111
3112         Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
3113         Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
3114
3115         - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
3116
3117         - Moves the contents of ksvg/bindings/js/ to bindings/js/.
3118
3119         - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
3120
3121         - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching 
3122           the other CSSValue classing, and allowing the bindings to allocate
3123           appropriately.
3124
3125         - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
3126           generation for Objective-C.
3127
3128         - Assorted style cleanups.
3129
3130         * DerivedSources.make:
3131         * WebCore.xcodeproj/project.pbxproj:
3132         * bindings/objc/DOMCSS.mm:
3133         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3134         * bindings/objc/DOMEvents.mm:
3135         (+[DOMEvent _eventWith:WebCore::]):
3136         * bindings/objc/DOMSVG.h:
3137         * bindings/objc/DOMSVGNumber.mm:
3138         (-[DOMSVGNumber dealloc]):
3139         (-[DOMSVGNumber finalize]):
3140         (-[DOMSVGNumber value]):
3141         (-[DOMSVGNumber setValue:]):
3142         (-[DOMSVGNumber _SVGNumber]):
3143         (-[DOMSVGNumber _initWithFloat:]):
3144         (+[DOMSVGNumber _SVGNumberWith:]):
3145         * bindings/objc/DOMSVGPoint.mm:
3146         (-[DOMSVGPoint dealloc]):
3147         (-[DOMSVGPoint finalize]):
3148         (-[DOMSVGPoint x]):
3149         (-[DOMSVGPoint setX:]):
3150         (-[DOMSVGPoint y]):
3151         (-[DOMSVGPoint setY:]):
3152         (-[DOMSVGPoint WebCore::]):
3153         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
3154         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
3155         * bindings/objc/DOMSVGRect.mm:
3156         (-[DOMSVGRect dealloc]):
3157         (-[DOMSVGRect finalize]):
3158         (-[DOMSVGRect x]):
3159         (-[DOMSVGRect setX:]):
3160         (-[DOMSVGRect y]):
3161         (-[DOMSVGRect setY:]):
3162         (-[DOMSVGRect width]):
3163         (-[DOMSVGRect setWidth:]):
3164         (-[DOMSVGRect height]):
3165         (-[DOMSVGRect setHeight:]):
3166         (-[DOMSVGRect WebCore::]):
3167         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
3168         (+[DOMSVGRect _SVGRectWith:WebCore::]):
3169         * bindings/scripts/CodeGeneratorObjC.pm:
3170         * css/StyleBase.h:
3171         (WebCore::StyleBase::isSVGColor):
3172         (WebCore::StyleBase::isSVGPaint):
3173         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
3174         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
3175         * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
3176         * ksvg2/bindings/js/JSSVGNumber.h: Removed.
3177         * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
3178         * ksvg2/bindings/js/JSSVGPoint.h: Removed.
3179         * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
3180         * ksvg2/bindings/js/JSSVGRect.h: Removed.
3181         * ksvg2/svg/SVGColor.h:
3182         (WebCore::SVGColor::isSVGColor):
3183         * ksvg2/svg/SVGFECompositeElement.idl:
3184         * ksvg2/svg/SVGFEFloodElement.idl:
3185         * ksvg2/svg/SVGLocatable.idl:
3186         * ksvg2/svg/SVGMarkerElement.idl:
3187         * ksvg2/svg/SVGPaint.h:
3188         (WebCore::SVGPaint::isSVGPaint):
3189         * ksvg2/svg/SVGRectElement.idl:
3190         * ksvg2/svg/SVGZoomEvent.idl: Removed.
3191
3192 2006-10-17  David Hyatt  <hyatt@apple.com>
3193
3194         Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
3195         but this patch makes everything work without a root layer being around.
3196
3197         Reviewed by beth
3198
3199         * rendering/RenderBlock.cpp:
3200         (WebCore::RenderBlock::paint):
3201         (WebCore::RenderBlock::paintChildren):
3202         (WebCore::RenderBlock::nodeAtPoint):
3203         * rendering/RenderLayer.cpp:
3204         (WebCore::frameVisibleRect):
3205         (WebCore::RenderLayer::hitTest):
3206         (WebCore::RenderLayer::hitTestLayer):
3207         (WebCore::RenderLayer::intersectsDamageRect):
3208         * rendering/RenderObject.cpp:
3209         (WebCore::RenderObject::setInnerNode):
3210         * rendering/RenderView.cpp:
3211         (WebCore::RenderView::paint):
3212
3213 2006-10-17  David Hyatt  <hyatt@apple.com>
3214
3215         Back out my previous patch to the WebCore memory cache.
3216
3217         * loader/Cache.cpp:
3218         (WebCore::Cache::flush):
3219         (WebCore::Cache::setSize):
3220         (WebCore::Cache::getLRUListFor):
3221         (WebCore::Cache::removeFromLRUList):
3222         (WebCore::Cache::insertInLRUList):
3223         * loader/Cache.h:
3224         * loader/CachedCSSStyleSheet.cpp:
3225         (WebCore::CachedCSSStyleSheet::deref):
3226         * loader/CachedCSSStyleSheet.h:
3227         * loader/CachedImage.cpp:
3228         (WebCore::CachedImage::deref):
3229         * loader/CachedImage.h:
3230         * loader/CachedResource.cpp:
3231         (WebCore::CachedResource::setRequest):
3232         (WebCore::CachedResource::deref):
3233         * loader/CachedResource.h:
3234         (WebCore::CachedResource::allowInLRUList):
3235         * loader/CachedScript.cpp:
3236         (WebCore::CachedScript::deref):
3237         * loader/CachedScript.h:
3238         * loader/CachedXBLDocument.cpp:
3239         (WebCore::CachedXBLDocument::deref):
3240         * loader/CachedXBLDocument.h:
3241         * loader/CachedXSLStyleSheet.cpp:
3242         (WebCore::CachedXSLStyleSheet::deref):
3243         * loader/CachedXSLStyleSheet.h:
3244
3245 2006-10-17  Oliver Hunt  <oliver@apple.com>
3246
3247         Reviewed by Anders.
3248
3249         Make north and east resize cursors use correct image
3250
3251         * platform/win/CursorWin.cpp:
3252         (WebCore::eastResizeCursor):
3253         (WebCore::northResizeCursor):
3254
3255 2006-10-17  Oliver Hunt  <oliver@apple.com>
3256
3257         Reviewed by Brady
3258
3259         Various cursor fixes
3260
3261         * page/FrameView.cpp:
3262         (WebCore::FrameView::handleMouseMoveEvent):
3263         * platform/Cursor.h:
3264         * platform/mac/CursorMac.mm:
3265         (WebCore::pointerCursor):
3266         * platform/win/CursorWin.cpp:
3267         (WebCore::supportsAlphaCursors):
3268         (WebCore::Cursor::Cursor):
3269         (WebCore::Cursor::~Cursor):
3270         (WebCore::pointerCursor):
3271
3272 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
3273
3274         Reviewed by harrison
3275         
3276         <rdar://problem/4776665>
3277         REGRESSION: In Mail, caret is visible when the message body isn't focused
3278
3279         * page/Frame.cpp:
3280         (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
3281         (like when the frame that contains the caret isn't focused) then we don't 
3282         want to paint the caret.  We should eventually move to using a single bool
3283         for caret painting.
3284
3285 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
3286
3287         Reviewed by harrison
3288         
3289         <rdar://problem/4774354>
3290         REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
3291
3292         Functions call recomputCaretRect to see if the caret rect has changed, 
3293         and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
3294         returning false if the caret turned into a range selection or was blown 
3295         away.
3296
3297         * editing/SelectionController.cpp:
3298         (WebCore::SelectionController::recomputeCaretRect): Don't early return if
3299         !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
3300         may now be null.
3301
3302 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
3303
3304         Reviewed by Brady.
3305
3306         BrowserExtension cleanup.
3307         
3308         - Removed unnecessary #include of BrowserExtension in Frame.h, added
3309         #includes to compensate in other files.
3310         
3311         - Removed unused versions of createNewWindow.
3312         
3313         * bindings/js/kjs_window.cpp:
3314         * bridge/BrowserExtension.h:
3315         * bridge/mac/BrowserExtensionMac.h:
3316         * bridge/mac/BrowserExtensionMac.mm:
3317         (WebCore::BrowserExtensionMac::createNewWindow):
3318         * bridge/mac/WebCoreFrameBridge.mm:
3319         * html/HTMLFormElement.cpp:
3320         * loader/mac/LoaderFunctionsMac.mm:
3321         * page/Frame.h:
3322         * page/FramePrivate.h:
3323
3324 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
3325
3326         Reviewed by Adam.
3327         
3328         - Fixed "FIXME: Violates Liskov Substitution principle."
3329         
3330         IFRAME was never a true subclass of FRAME, since they disagreed on a
3331         number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
3332
3333         The fix here is to factor out things common to IFRAME and FRAME into a
3334         common base class, HTMLFrameElementBase.
3335         
3336         I also changed some " *" to "* " and added #includes in files that implicitly
3337         assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
3338
3339 2006-10-16  Justin Garcia  <justin.garcia@apple.com>
3340
3341         Reviewed by sullivan
3342         
3343         <rdar://problem/4776765>
3344         REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
3345
3346         We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
3347         the old caret rect.  It in fact corrects the caret rect for an offset that it 
3348         believes is due to scrolling but which is actually due to a change in selection
3349         without an accompanying layout.  So it returns the new caret rect regardless of
3350         what m_needsLayout is set to.
3351         
3352         * editing/SelectionController.cpp:
3353         (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
3354         adds a one pixel slop to this new function.
3355         (WebCore::SelectionController::caretRepaintRect): Moved this code to
3356         repaintRectForCaret.
3357         (WebCore::SelectionController::recomputeCaretRect): Compare the old
3358         caret rect to the new one that's computed with a fresh layout.  If
3359         they are different, invalidate both repaint rects.
3360
3361 2006-10-17  David Harrison  <harrison@apple.com>
3362
3363         Reviewed by Adele.
3364
3365         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
3366
3367         * bridge/mac/WebCoreAXObject.mm:
3368         (-[WebCoreAXObject isPasswordField]):
3369         New. Checks for input with inputType() of PASSWORD.
3370         
3371         (-[WebCoreAXObject subrole]):
3372         Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
3373         
3374         (-[WebCoreAXObject roleDescription]):
3375         Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
3376         
3377         (-[WebCoreAXObject value]):
3378         Return nil if [self isPasswordField].
3379         
3380         (-[WebCoreAXObject accessibilityAttributeNames]):
3381         Return generic attributes if [self isPasswordField].
3382
3383         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
3384         Return empty array if [self isPasswordField].
3385
3386 2006-10-17  David Hyatt  <hyatt@apple.com>
3387
3388         Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
3389         code so that it will only run if the body still has no renderer.
3390
3391         * dom/Document.cpp:
3392         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
3393
3394 2006-10-17  David Hyatt  <hyatt@apple.com>
3395
3396         Fix a bug where the WebCore memory cache could grow without bound during extended browsing
3397         sessions.
3398
3399         Reviewed by mjs
3400
3401         * loader/Cache.cpp:
3402         (WebCore::Cache::flush):
3403         (WebCore::Cache::setSize):
3404         (WebCore::Cache::getLRUListFor):
3405         (WebCore::Cache::removeFromLRUList):
3406         (WebCore::Cache::insertInLRUList):
3407         * loader/Cache.h:
3408         * loader/CachedCSSStyleSheet.cpp:
3409         * loader/CachedCSSStyleSheet.h:
3410         * loader/CachedImage.cpp:
3411         * loader/CachedImage.h:
3412         * loader/CachedResource.cpp:
3413         (WebCore::CachedResource::setRequest):
3414         (WebCore::CachedResource::deref):
3415         * loader/CachedResource.h:
3416         (WebCore::CachedResource::allowInLRUList):
3417         * loader/CachedScript.cpp:
3418         * loader/CachedScript.h:
3419         * loader/CachedXBLDocument.cpp:
3420         * loader/CachedXBLDocument.h:
3421         * loader/CachedXSLStyleSheet.cpp:
3422         * loader/CachedXSLStyleSheet.h:
3423
3424 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
3425
3426         Reviewed by harrison
3427         
3428         <rdar://problem/3655385>
3429         Editing: -indent: method unimplemented
3430
3431         Added Frame and bridge methods.
3432
3433         * bridge/mac/WebCoreFrameBridge.h:
3434         * bridge/mac/WebCoreFrameBridge.mm:
3435         (-[WebCoreFrameBridge indent]):
3436         (-[WebCoreFrameBridge outdent]):
3437         * page/Frame.cpp:
3438         (WebCore::Frame::indent): 
3439         (WebCore::Frame::outdent):
3440         * page/Frame.h:
3441
3442 2006-10-16  Adam Roben  <aroben@apple.com>
3443
3444         Reviewed by John.
3445
3446         More menulist cleanup/tweaking.
3447
3448         * html/HTMLSelectElement.cpp:
3449         (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
3450         parameter to 'optionIndex' for clarity.
3451         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
3452         items that are not enabled <option> elements when using arrow keys, and
3453         make sure we pass an option index to setSelectedIndex.
3454         * platform/PopupMenu.h:
3455         (WebCore::PopupMenu::setWasClicked): Specify default argument.
3456         * rendering/RenderMenuList.cpp:
3457         (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
3458         option text before setting the control text so that options within
3459         <optgroup>s don't appear indented in the actual control.
3460
3461 2006-10-16  Sam Weinig  <sam.weinig@gmail.com>
3462
3463         Reviewed by Adam.
3464
3465         Win32 build fix.
3466
3467         * WebCore.vcproj/WebCore/WebCore.vcproj:
3468         * bridge/win/BrowserExtensionWin.cpp:
3469         (WebCore::BrowserExtensionWin::createNewWindow):
3470         * bridge/win/FrameWin.cpp:
3471         (WebCore::FrameWin::urlSelected):
3472         (WebCore::FrameWin::submitForm):
3473         (WebCore::FrameWin::createNewWindow):
3474         * bridge/win/FrameWin.h:
3475         * loader/loader.cpp:
3476         (WebCore::Loader::receivedResponse):
3477         * platform/win/GraphicsContextWin.cpp:
3478         (WebCore::GraphicsContext::getWindowsContext):
3479         (WebCore::GraphicsContext::releaseWindowsContext):
3480         * platform/win/TemporaryLinkStubs.cpp:
3481         (FrameWin::openURLRequest):
3482         (WebCore::ServeSynchronousRequest):
3483         (WebCore::CheckIfReloading):
3484         (WebCore::IsResponseURLEqualToURL):
3485         (WebCore::ResponseMIMEType):
3486         (WebCore::ResponseIsMultipart):
3487         (WebCore::CacheObjectExpiresTime):
3488         (CachedResource::setResponse):
3489         (CachedResource::setAllData):
3490         * rendering/RenderThemeWin.cpp:
3491         (WebCore::doneDrawing):
3492         (WebCore::RenderThemeWin::paintButton):
3493         (WebCore::RenderThemeWin::paintTextField):
3494
3495 2006-10-16  David Hyatt  <hyatt@apple.com>
3496
3497         Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
3498         CSS2.1.  In the absence of any other enclosing positioned elements, the containing block for a positioned
3499         element is the initial containing block (our RenderView).
3500
3501         Reviewed by mjs
3502
3503         Test cases added to fast/block/positioning for quirks and strict modes.
3504
3505         * rendering/RenderBlock.cpp:
3506         (WebCore::RenderBlock::lowestPosition):
3507         (WebCore::RenderBlock::rightmostPosition):
3508         (WebCore::RenderBlock::leftmostPosition):
3509         * rendering/RenderBox.cpp:
3510         (WebCore::RenderBox::containingBlockHeightForPositioned):
3511         (WebCore::RenderBox::calcAbsoluteVertical):
3512         * rendering/RenderObject.cpp:
3513         (WebCore::RenderObject::containingBlock):
3514         (WebCore::RenderObject::container):
3515
3516 2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3517
3518         Reviewed by Anders.
3519
3520         Misc Gdk/Linux build fixes.
3521
3522         * platform/gdk/BrowserExtensionGdk.h:
3523         * platform/gdk/FrameGdk.cpp:
3524         (WebCore::FrameGdk::submitForm):
3525         (WebCore::FrameGdk::urlSelected):
3526         * platform/gdk/FrameGdk.h:
3527         * platform/gdk/RenderPopupMenuGdk.cpp:
3528         (WebCore::PopupMenu::PopupMenu):
3529         (WebCore::PopupMenu::~PopupMenu):
3530         (WebCore::PopupMenu::clear):
3531         (WebCore::PopupMenu::populate):
3532         (WebCore::PopupMenu::show):
3533         (WebCore::PopupMenu::hide):
3534         (WebCore::PopupMenu::addSeparator):
3535         (WebCore::PopupMenu::addGroupLabel):
3536         (WebCore::PopupMenu::addOption):
3537         * platform/gdk/RenderPopupMenuGdk.h:
3538         * platform/gdk/RenderThemeGdk.cpp:
3539         * platform/gdk/RenderThemeGdk.h:
3540         (WebCore::RenderThemeGdk::RenderThemeGdk):
3541         * platform/gdk/TemporaryLinkStubs.cpp:
3542         (BrowserExtensionGdk::createNewWindow):
3543         (BrowserExtensionGdk::BrowserExtensionGdk):
3544         (BrowserExtensionGdk::setTypedIconURL):
3545         (BrowserExtensionGdk::setIconURL):
3546         (BrowserExtensionGdk::getHistoryLength):
3547         (WebCore::CheckIfReloading):
3548         (WebCore::CacheObjectExpiresTime):
3549         (WebCore::ResponseURL):
3550         (WebCore::IsResponseURLEqualToURL):
3551         (WebCore::ResponseIsMultipart):
3552         (WebCore::ResponseMIMEType):
3553         (WebCore::CachedResource::setResponse):
3554         (WebCore::CachedResource::setAllData):
3555         (FileChooser::disconnectUploadControl):
3556         * rendering/RenderTheme.h:
3557         * rendering/RenderThemeMac.h:
3558
3559 2006-10-15  Sam Weinig  <sam.weinig@gmail.com>
3560
3561         Reviewed by Mitz.
3562
3563         Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
3564         Add getModifierState method to KeyboardEvent
3565
3566         * bindings/objc/DOMEvents.h:
3567         * bindings/objc/DOMEvents.mm:
3568         * bindings/objc/PublicDOMInterfaces.h:
3569         * dom/KeyboardEvent.cpp: