2006-10-26 Oliver Hunt <oliver@apple.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-26  Oliver Hunt  <oliver@apple.com>
2
3         Reviewed by Anders.
4         Fixes <rdar://problem/4800518> -- needed to update existing
5         canvas path elements when transforms are performed on the
6         context.
7
8         * html/CanvasRenderingContext2D.cpp:
9         (WebCore::CanvasRenderingContext2D::scale):
10         (WebCore::CanvasRenderingContext2D::rotate):
11         (WebCore::CanvasRenderingContext2D::translate):
12
13 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
14
15         Reviewed by Darin.
16
17         Fix Qt/Linux build.
18
19         * platform/network/qt/ResourceLoaderManager.cpp:
20         (WebCore::ResourceLoaderManager::slotData):
21         (WebCore::ResourceLoaderManager::slotMimetype):
22         (WebCore::ResourceLoaderManager::remove):
23         (WebCore::ResourceLoaderManager::add):
24         * platform/network/qt/ResourceLoaderQt.cpp:
25         (WebCore::ResourceLoader::receivedResponse):
26         * platform/qt/FrameQtClient.cpp:
27         (WebCore::FrameQtClientDefault::openURL):
28         * platform/qt/LoaderFunctionsQt.cpp:
29         (WebCore::ServeSynchronousRequest):
30
31 2006-10-26  Adam Roben  <aroben@apple.com>
32
33         Reviewed by Adele.
34
35         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
36         boxes (<select> elements)
37
38         This also adds type-ahead find for closed menulists (popups).
39
40         * WebCore.xcodeproj/project.pbxproj: Version wars.
41         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
42         find.
43         * html/HTMLSelectElement.cpp:
44         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
45         instance variables.
46         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
47         find on printable character presses.
48         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
49         redundant check that the listIndex has changed (setSelectedIndex does
50         this for us), and fix indentation.
51         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
52         to an else-if.
53         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
54         to strip leading whitespace (including non-breaking spaces) from a
55         string.
56         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
57         type-ahead find.
58         * platform/PopupMenu.h: Added new updateFromElement() method to be
59         called from RenderMenuList::updateFromElement().
60         * platform/mac/PopupMenuMac.mm:
61         (WebCore::PopupMenu::updateFromElement): While we are using
62         NSPopUpButtonCell for our popups, this method can stay empty.
63         * rendering/RenderListBox.cpp:
64         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
65         selected element.
66         * rendering/RenderMenuList.cpp:
67         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
68         if it's visible.
69
70 2006-10-26  Darin Adler  <darin@apple.com>
71
72         Reviewed by Anders.
73
74         - removed non-deterministic behavior in editing that was causing
75           inconsistent results for editing/pasteboard/copy-paste-bidi.html
76
77         * editing/ReplaceSelectionCommand.cpp:
78         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
79         Use two vectors instead of a map: more efficient, deterministic. There was no
80         reason to use a hash table.
81
82 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
83
84         Reviewed by Anders.
85
86         - .5% speed improvement by avoiding excess CFURLRef allocation
87
88         * loader/CachedResource.cpp:
89         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
90         here for later reuse.
91         * loader/CachedResource.h:
92         * loader/mac/LoaderFunctionsMac.mm:
93         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
94
95 2006-10-25  Darin Adler  <darin@apple.com>
96
97         Reviewed by Anders.
98
99         - removed 55 methods from WebCoreFrameBridge
100         - changed callers to use Frame directly instead
101         - put FrameLoaderTypes.h types into the WebCore namespace
102         - first steps to get FrameLoader.h ready for cross-platform duty
103
104         * WebCore.exp:
105         * WebCore.xcodeproj/project.pbxproj:
106         * bridge/mac/BrowserExtensionMac.mm:
107         (WebCore::BrowserExtensionMac::createNewWindow):
108         * bridge/mac/FrameMac.h:
109         * bridge/mac/FrameMac.mm:
110         (WebCore::FrameMac::loadRequest):
111         (WebCore::FrameMac::startRedirectionTimer):
112         (WebCore::FrameMac::stopRedirectionTimer):
113         (WebCore::FrameMac::passSubframeEventToSubframe):
114         (WebCore::FrameMac::handledOnloadEvents):
115         (WebCore::FrameMac::isLoadTypeReload):
116         * bridge/mac/WebCoreFrameBridge.h:
117         * bridge/mac/WebCoreFrameBridge.mm:
118         (-[WebCoreFrameBridge executionContextForView:]):
119         (updateRenderingForBindings):
120         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
121         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
122         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
123         (-[WebCoreFrameBridge installInFrame:]):
124         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
125         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
126         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
127         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
128         (stringByCollapsingNonPrintingCharacters):
129         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
130         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
131         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
132         * loader/FrameLoaderTypes.h:
133         * loader/mac/FrameLoader.h:
134         * loader/mac/FrameLoader.mm:
135         (WebCore::FrameLoader::FrameLoader):
136         (WebCore::FrameLoader::setupForReplace):
137         (WebCore::FrameLoader::load):
138         (WebCore::FrameLoader::activeDocumentLoader):
139         (WebCore::FrameLoader::state):
140         (WebCore::FrameLoader::setState):
141         (WebCore::FrameLoader::clearProvisionalLoad):
142         (WebCore::FrameLoader::markLoadComplete):
143         (WebCore::FrameLoader::commitProvisionalLoad):
144         (WebCore::FrameLoader::receivedMainResourceError):
145         (WebCore::FrameLoader::handleFallbackContent):
146         (WebCore::FrameLoader::isLoadingMainFrame):
147         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
148         (WebCore::FrameLoader::continueAfterNavigationPolicy):
149         (WebCore::FrameLoader::continueAfterWillSubmitForm):
150         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
151         (WebCore::FrameLoader::transitionToCommitted):
152         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
153         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
154         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
155         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
156         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
157         * loader/mac/ImageDocumentMac.mm:
158         (WebCore::finishImageLoad):
159         * loader/mac/WebDocumentLoader.mm:
160         (WebCore::DocumentLoader::isLoadingInAPISense):
161         * loader/mac/WebMainResourceLoader.h:
162         * loader/mac/WebMainResourceLoader.mm:
163         (WebCore::MainResourceLoader::continueAfterContentPolicy):
164         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
165         * loader/mac/WebSubresourceLoader.mm:
166         (-[WebCoreSubresourceHandle initWithLoader:]):
167         * platform/mac/ListBoxMac.mm:
168         (-[WebCoreTableView keyDown:]):
169         (-[WebCoreTableView keyUp:]):
170         * platform/mac/WebCoreTextField.mm:
171         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
172
173 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
174
175         Reviewed by Darin.
176
177         Printing fixes
178
179         * page/Frame.cpp:
180         (WebCore::Frame::adjustPageHeight):
181         * page/Frame.h:
182         (WebCore::Frame::setupRootForPrinting):
183         (WebCore::Frame::computePageRects):
184
185 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
186
187         Reviewed by Geoff.
188
189         <rdar://problem/4799088>
190         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
191
192         * loader/mac/WebSubresourceLoader.h:
193         * loader/mac/WebSubresourceLoader.mm:
194         (-[WebCoreSubresourceHandle initWithLoader:]):
195         Set the HTTP method before the HTTP body.
196
197 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
198
199         Reviewed by Adam.
200
201         Renamed WebFrameLoader to FrameLoader, to match class name.
202
203         * WebCore.xcodeproj/project.pbxproj:
204         * bridge/mac/FrameMac.mm:
205         * bridge/mac/WebCoreFrameBridge.mm:
206         * loader/mac/FrameLoader.mm: Added.
207         * loader/mac/IconLoaderMac.mm:
208         * loader/mac/WebDocumentLoader.mm:
209         * loader/mac/WebFrameLoader.h: Removed.
210         * loader/mac/WebFrameLoader.mm: Removed.
211         * loader/mac/WebLoader.mm:
212         * loader/mac/WebMainResourceLoader.mm:
213         * loader/mac/WebNetscapePlugInStreamLoader.mm:
214         * loader/mac/WebSubresourceLoader.mm:
215
216 2006-10-25  Darin Adler  <darin@apple.com>
217
218         - fix full builds
219
220         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
221
222 2006-10-25  David Smith  <catfish.man@gmail.com>
223
224         Reviewed by Mitz.
225
226         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
227         http://bugs.webkit.org/show_bug.cgi?id=11411
228
229         * bridge/mac/WebCoreFrameBridge.mm:
230         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
231
232 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
233
234         Rubber stamped by Mitz.
235
236         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
237
238         * WebCore.xcodeproj/project.pbxproj:
239         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
240         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
241         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
242
243 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
244
245         Rubber stamped by Mark.
246
247         - remove no longer existing symbol that was breaking linking
248
249         * WebCore.exp:
250
251 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
252
253         Reviewed by Mitz.
254         
255         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
256         http://bugs.webkit.org/show_bug.cgi?id=11212
257
258         I couldn't figure out how to write a test case.
259
260         * bindings/js/kjs_window.cpp:
261         (KJS::Window::clear): Avoid crashing if already detached.
262         * bridge/mac/FrameMac.h:
263         * bridge/mac/FrameMac.mm:
264         (WebCore::FrameMac::clear): Change prototype to make this a proper
265         overload for Frame::clear once again(!).
266
267 2006-10-24  Darin Adler  <darin@apple.com>
268
269         Reviewed by Anders.
270
271         - converted WebFrameLoaderClient to C++
272         - renamed frame->frameLoader() function to frame->loader()
273         - renamed [bridge impl] to [bridge _frame]
274         - removed some bridge methods
275
276         * WebCore.exp: Added more exports.
277         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
278         so it can be used in WebKit.
279
280         * bridge/mac/BrowserExtensionMac.mm:
281         (WebCore::BrowserExtensionMac::createNewWindow):
282         * bridge/mac/FrameMac.mm:
283         (WebCore::FrameMac::createFrame):
284         (WebCore::FrameMac::didFirstLayout):
285         * bridge/mac/WebCoreAXObject.mm:
286         (-[WebCoreAXObject rendererForView:]):
287         * bridge/mac/WebCoreFrameBridge.h:
288         * bridge/mac/WebCoreFrameBridge.mm:
289         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
290         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
291         (-[WebCoreFrameBridge setOpener:]):
292         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
293         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
294         (-[WebCoreFrameBridge setTitle:]):
295         (-[WebCoreFrameBridge originalRequestURL]):
296         (-[WebCoreFrameBridge isLoadTypeReload]):
297         (-[WebCoreFrameBridge frameDetached]):
298         (-[WebCoreFrameBridge tokenizerProcessedData]):
299         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
300         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
301         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
302         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
303         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
304         (-[WebCoreFrameBridge incomingReferrer]):
305         (-[WebCoreFrameBridge isReloading]):
306         (-[WebCoreFrameBridge handledOnloadEvents]):
307         (-[WebCoreFrameBridge mainResourceURLResponse]):
308         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
309         (-[WebCoreFrameBridge _frame]):
310         (-[WebCoreFrameBridge executionContextForView:]):
311         * bridge/mac/WebCorePageBridge.mm:
312         (-[WebCorePageBridge setMainFrame:]):
313         * dom/Position.cpp:
314         (WebCore::Position::upstream):
315         * loader/mac/IconLoaderMac.mm:
316         (IconLoader::notifyIconChanged):
317         * loader/mac/WebDocumentLoader.mm:
318         (WebCore::DocumentLoader::frameLoader):
319         (WebCore::DocumentLoader::stopLoading):
320         (WebCore::DocumentLoader::finishedLoading):
321         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
322         * loader/mac/WebFormState.mm:
323         (WebCore::FormState::FormState):
324         * loader/mac/WebFrameLoader.h:
325         * loader/mac/WebFrameLoader.mm:
326         (WebCore::FrameLoader::~FrameLoader):
327         (WebCore::FrameLoader::prepareForLoadStart):
328         (WebCore::FrameLoader::finalSetupForReplace):
329         (WebCore::FrameLoader::safeLoad):
330         (WebCore::FrameLoader::load):
331         (WebCore::FrameLoader::startLoading):
332         (WebCore::FrameLoader::stopLoadingSubframes):
333         (WebCore::FrameLoader::stopLoading):
334         (WebCore::FrameLoader::cancelPendingArchiveLoad):
335         (WebCore::FrameLoader::defersCallbacksChanged):
336         (WebCore::FrameLoader::setDefersCallbacks):
337         (WebCore::FrameLoader::setDocumentLoader):
338         (WebCore::FrameLoader::provisionalLoadStarted):
339         (WebCore::FrameLoader::clearProvisionalLoad):
340         (WebCore::FrameLoader::identifierForInitialRequest):
341         (WebCore::FrameLoader::willSendRequest):
342         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
343         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
344         (WebCore::FrameLoader::didReceiveResponse):
345         (WebCore::FrameLoader::didReceiveData):
346         (WebCore::FrameLoader::didFinishLoad):
347         (WebCore::FrameLoader::didFailToLoad):
348         (WebCore::FrameLoader::privateBrowsingEnabled):
349         (WebCore::FrameLoader::receivedMainResourceError):
350         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
351         (WebCore::FrameLoader::clientRedirected):
352         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
353         (WebCore::FrameLoader::closeOldDataSources):
354         (WebCore::FrameLoader::opened):
355         (WebCore::FrameLoader::commitProvisionalLoad):
356         (WebCore::FrameLoader::download):
357         (WebCore::FrameLoader::finishedLoading):
358         (WebCore::FrameLoader::notifyIconChanged):
359         (WebCore::FrameLoader::cancelledError):
360         (WebCore::FrameLoader::fileDoesNotExistError):
361         (WebCore::FrameLoader::willUseArchive):
362         (WebCore::FrameLoader::isArchiveLoadPending):
363         (WebCore::FrameLoader::handleUnimplementablePolicy):
364         (WebCore::FrameLoader::cannotShowMIMEType):
365         (WebCore::FrameLoader::interruptionForPolicyChangeError):
366         (WebCore::FrameLoader::canShowMIMEType):
367         (WebCore::FrameLoader::representationExistsForURLScheme):
368         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
369         (WebCore::FrameLoader::checkContentPolicy):
370         (WebCore::FrameLoader::reloadAllowingStaleData):
371         (WebCore::FrameLoader::reload):
372         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
373         (WebCore::FrameLoader::finishedLoadingDocument):
374         (WebCore::FrameLoader::committedLoad):
375         (WebCore::FrameLoader::revertToProvisional):
376         (WebCore::FrameLoader::setMainDocumentError):
377         (WebCore::FrameLoader::mainReceivedCompleteError):
378         (WebCore::FrameLoader::subframeIsLoading):
379         (WebCore::FrameLoader::willChangeTitle):
380         (WebCore::FrameLoader::didChangeTitle):
381         (WebCore::FrameLoader::checkNewWindowPolicy):
382         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
383         (WebCore::FrameLoader::checkNavigationPolicy):
384         (WebCore::FrameLoader::continueAfterNavigationPolicy):
385         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
386         (WebCore::FrameLoader::didFirstLayout):
387         (WebCore::FrameLoader::frameLoadCompleted):
388         (WebCore::FrameLoader::transitionToCommitted):
389         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
390         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
391         (WebCore::FrameLoader::sendRemainingDelegateMessages):
392         (WebCore::FrameLoader::requestFromDelegate):
393         (WebCore::FrameLoader::post):
394         (WebCore::FrameLoader::detachChildren):
395         (WebCore::FrameLoader::detachFromParent):
396         (WebCore::FrameLoader::addExtraFieldsToRequest):
397         (WebCore::FrameLoader::actionInformation):
398         (WebCore::FrameLoader::checkLoadComplete):
399         (WebCore::FrameLoader::setClient):
400         (WebCore::FrameLoader::client):
401         (WebCore::FrameLoaderClient::~FrameLoaderClient):
402         * loader/mac/WebFrameLoaderClient.h:
403         * loader/mac/WebLoader.mm:
404         (WebCore::WebResourceLoader::frameLoader):
405         * loader/mac/WebSubresourceLoader.mm:
406         (-[WebCoreSubresourceHandle initWithLoader:]):
407         * page/Frame.cpp:
408         (WebCore::Frame::loader):
409         * page/Frame.h:
410         * platform/mac/SliderMac.mm:
411         (Slider::focusPolicy):
412
413 2006-10-24  Darin Adler  <darin@apple.com>
414
415         Rubber stamped by Anders.
416
417         - get rid of the assertion firing while running the layout tests
418
419         This does not fix the real problem, which is that we need to map offsets within
420         possibly-text-transformed text in the render tree to DOM tree offsets and vice
421         versa -- but it gets the tests running again.
422
423         * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
424
425 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
426
427         Reviewed by Oliver.
428
429         - more ResourceLoader cleanup
430             - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
431             - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
432         
433         * loader/LoaderFunctions.h:
434         * loader/mac/LoaderFunctionsMac.mm:
435         (WebCore::ServeSynchronousRequest):
436         * loader/mac/WebSubresourceLoader.mm:
437         (-[WebCoreSubresourceHandle initWithLoader:]):
438         * platform/network/HTTPHeaderMap.h: Added.
439         * platform/network/ResourceLoader.cpp:
440         (WebCore::ResourceLoader::requestHeaders):
441         * platform/network/ResourceLoader.h:
442         * platform/network/ResourceRequest.h:
443         * platform/network/cf/ResourceLoaderCFNet.cpp:
444         (WebCore::addHeadersFromHashMap):
445         * xml/xmlhttprequest.cpp:
446         (WebCore::XMLHttpRequest::send):
447         * xml/xmlhttprequest.h:
448
449 2006-10-24  Justin Garcia  <justin.garcia@apple.com>
450
451         Reviewed by darin
452
453         <http://bugs.webkit.org/show_bug.cgi?id=10993>
454         GMail Editor: Caret doesn't always position itself after list marker
455         
456         List creation uses moveParagraphs to push content into list items.  
457         moveParagraphs uses a TextIterator to restore selections after moves.
458         Some characters emitted by the TextIterator had bad ranges associated
459         with them.  rangeFromLocationAndLength would skip past the range it
460         should have used when asked for ranges of length 0.
461
462         * editing/TextIterator.cpp:
463         (WebCore::TextIterator::TextIterator): No longer need to initialize a
464         removed member variable.
465         (WebCore::TextIterator::advance): An extra newline is emitted when leaving
466         some blocks.  Use the same range for this newline as for the first newline.
467         We should remove this code and just emit two '\n's.
468         (WebCore::TextIterator::handleTextNode): Setup m_range.
469         (WebCore::TextIterator::handleTextBox): Ditto.
470         (WebCore::TextIterator::handleReplacedElement): Ditto.
471         (WebCore::TextIterator::handleNonTextNode): Ditto.
472         (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
473         in the block we're leaving to that VP after that one.
474         (WebCore::TextIterator::emitCharacter): This function now takes in the start
475         and the end of the range associated with the emited character, and sets up m_range.
476         (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd), 
477         return the end of the range used to create the iterator, as a convenience to
478         callers that use call range() on an iterator that is atEnd.
479         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
480         Same as the changes made to TextIterator's constructor.
481         (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
482         a null m_positionNode to signal that we're finished.
483         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
484         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
485         made to TextIterator.
486         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
487         (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
488         (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
489         TextIterator::range.
490         (WebCore::CharacterIterator::range): This function assumed that an iterator's
491         range() was safe to modify.
492         (WebCore::TextIterator::rangeFromLocationAndLength):
493         If the range we're looking for starts in the current chunk, this function assumed
494         that if the chunk started in a text node, it would end in the same text node.  This
495         is no longer the case.
496         If the range we're looking for starts in the middle of the current chunk, I assume
497         that the chunk is inside a text node, because those are the only chunks with length
498         greater than one at the moment.
499         If the range we're looking for is a zero length range that starts/ends at the end of the
500         current chunk, we used to return the start of the next chunk, but that's wrong and
501         is what caused this bug.
502         * editing/TextIterator.h:
503         (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
504         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
505         * editing/visible_units.cpp:
506         (WebCore::previousBoundary): Cleaned up by using a convenience function.
507         (WebCore::nextBoundary): Ditto.
508
509 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
510
511         Reviewed by Maciej.
512
513         * platform/network/mac/ResourceLoaderMac.mm:
514         (WebCore::ResourceLoader::start):
515         Don't retain the header dictionary.
516
517 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
518
519         Reviewed by Anders.
520
521         Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
522         REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref() 
523         running svg/custom/svg/custom/gradient-attr-update.svg
524         
525         SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
526
527         * ksvg2/css/SVGRenderStyle.h:
528         * ksvg2/css/SVGRenderStyleDefs.h:
529
530 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
531
532         Reviewed by Mitz.
533
534         * platform/network/ResourceRequest.h:
535         (WebCore::ResourceRequest::ResourceRequest):
536         Set the http method to "GET" in the constructor that takes a String.
537
538 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
539
540         Reviewed by Tim H.
541
542         Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
543         and rendering/SVG* respectively.  Fix Xcode project and
544         CMakeLists.txt to account for the moves.
545
546         * CMakeLists.txt:
547         * WebCore.xcodeproj/project.pbxproj:
548         * kcanvas/RenderForeignObject.cpp: Removed.
549         * kcanvas/RenderForeignObject.h: Removed.
550         * kcanvas/RenderPath.cpp: Removed.
551         * kcanvas/RenderPath.h: Removed.
552         * kcanvas/RenderSVGContainer.cpp: Removed.
553         * kcanvas/RenderSVGContainer.h: Removed.
554         * kcanvas/RenderSVGImage.cpp: Removed.
555         * kcanvas/RenderSVGImage.h: Removed.
556         * kcanvas/RenderSVGInline.cpp: Removed.
557         * kcanvas/RenderSVGInline.h: Removed.
558         * kcanvas/RenderSVGInlineText.cpp: Removed.
559         * kcanvas/RenderSVGInlineText.h: Removed.
560         * kcanvas/RenderSVGTSpan.cpp: Removed.
561         * kcanvas/RenderSVGTSpan.h: Removed.
562         * kcanvas/RenderSVGText.cpp: Removed.
563         * kcanvas/RenderSVGText.h: Removed.
564         * kcanvas/SVGInlineFlowBox.cpp: Removed.
565         * kcanvas/SVGInlineFlowBox.h: Removed.
566         * kcanvas/SVGRootInlineBox.cpp: Removed.
567         * kcanvas/SVGRootInlineBox.h: Removed.
568
569 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
570
571         Rolling back in, now fixed:
572         
573         Nixed a few more redundant loading functions in Frame. Did my best to update
574         the non-Mac builds.
575
576         * bridge/mac/FrameMac.h:
577         * bridge/mac/FrameMac.mm:
578         (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
579         always 'true', because changing it broke the world, and testing seems to
580         indicate that the one caller that might have passed 'false' didn't need to.
581         * page/Frame.cpp:
582         (WebCore::Frame::requestFrame):
583         (WebCore::Frame::frameLoader):
584         (WebCore::Frame::redirectionTimerFired):
585         * page/Frame.h:
586         * platform/gdk/FrameGdk.cpp:
587         * platform/gdk/FrameGdk.h:
588         * platform/gdk/TemporaryLinkStubs.cpp:
589         (FrameGdk::issueCopyCommand):
590         * platform/qt/FrameQt.cpp:
591         * platform/qt/FrameQt.h:
592         * platform/win/TemporaryLinkStubs.cpp:
593         (WebCore::FrameWin::shouldInterruptJavaScript):
594         (WebCore::FrameWin::issueCopyCommand):
595
596 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
597
598         Fix the build (Update for changes to ResourceLoader)
599         
600         * platform/network/cf/ResourceLoaderCFNet.cpp:
601         (WebCore::addHeadersFromHashMap):
602         (WebCore::ResourceLoader::start):
603         (WebCore::ResourceLoader::cancel):
604
605 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
606
607         Reviewed by Mitz.
608
609         Change #includes using <kcanvas/*.h> to use "*.h" instead
610         to prepare for moving the kcanvas files.
611
612         * kcanvas/RenderSVGContainer.h:
613         * ksvg2/svg/SVGAElement.cpp:
614         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
615         * ksvg2/svg/SVGFETileElement.cpp:
616         * ksvg2/svg/SVGStyledLocatableElement.cpp:
617         * ksvg2/svg/SVGStyledTransformableElement.cpp:
618
619 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
620
621         Reviewed by Darin.
622
623         - More movement towards the final network API.
624         
625         Changed ResourceLoader::create to take a ResurceRequest and start
626         the load. Removed methods relating to setting request
627         headers. Removed methods relating to metaData. Added some more
628         convenience methods to ResourceRequest.
629
630         * dom/XMLTokenizer.cpp:
631         (WebCore::openFunc):
632         * loader/LoaderFunctions.h:
633         * loader/icon/IconLoader.cpp:
634         (IconLoader::startLoading):
635         (IconLoader::didFinishLoading):
636         * loader/icon/IconLoader.h:
637         * loader/loader.cpp:
638         (WebCore::Loader::servePendingRequests):
639         * loader/mac/LoaderFunctionsMac.mm:
640         (WebCore::ServeSynchronousRequest):
641         * platform/gdk/FrameGdk.cpp:
642         (WebCore::FrameGdkClientDefault::openURL):
643         (WebCore::FrameGdkClientDefault::submitForm):
644         * platform/network/ResourceLoader.cpp:
645         (WebCore::ResourceLoader::ResourceLoader):
646         (WebCore::ResourceLoader::create):
647         (WebCore::ResourceLoader::responseHTTPHeadersAsString):
648         (WebCore::ResourceLoader::url):
649         (WebCore::ResourceLoader::postData):
650         (WebCore::ResourceLoader::method):
651         (WebCore::ResourceLoader::client):
652         * platform/network/ResourceLoader.h:
653         * platform/network/ResourceLoaderInternal.h:
654         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
655         * platform/network/ResourceRequest.h:
656         (WebCore::ResourceRequest::ResourceRequest):
657         (WebCore::ResourceRequest::httpAccept):
658         (WebCore::ResourceRequest::setHTTPAccept):
659         (WebCore::ResourceRequest::addHTTPHeaderFields):
660         * platform/network/mac/ResourceLoaderMac.mm:
661         (WebCore::ResourceLoader::start):
662         (WebCore::ResourceLoader::receivedResponse):
663         * platform/qt/FrameQtClient.cpp:
664         (WebCore::FrameQtClientDefault::openURL):
665         (WebCore::FrameQtClientDefault::submitForm):
666         * platform/win/TemporaryLinkStubs.cpp:
667         (WebCore::ResourceLoader::retrieveResponseEncoding):
668         * xml/XSLTProcessor.cpp:
669         (WebCore::docLoaderFunc):
670         * xml/xmlhttprequest.cpp:
671         (WebCore::XMLHttpRequest::send):
672         (WebCore::XMLHttpRequest::didFinishLoading):
673         (WebCore::XMLHttpRequest::didReceiveData):
674         * xml/xmlhttprequest.h:
675
676 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
677
678         Reviewed by Geoff.
679
680         * loader/FormData.cpp:
681         (WebCore::FormData::FormData):
682         * loader/FormData.h:
683         (WebCore::FormData::FormData):
684         Add new constructor that takes a void* and a size.
685
686 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
687
688         Rolling out my last change because it broke the world.
689
690         * bridge/mac/FrameMac.h:
691         * bridge/mac/FrameMac.mm:
692         (WebCore::FrameMac::openURL):
693         (WebCore::FrameMac::openURLRequest):
694         (WebCore::FrameMac::urlSelected):
695         * page/Frame.cpp:
696         (WebCore::Frame::openURL):
697         (WebCore::Frame::frameLoader):
698         (WebCore::Frame::requestFrame):
699         (WebCore::Frame::redirectionTimerFired):
700         * page/Frame.h:
701         * platform/gdk/FrameGdk.cpp:
702         (WebCore::FrameGdk::openURL):
703         * platform/gdk/FrameGdk.h:
704         * platform/gdk/TemporaryLinkStubs.cpp:
705         * platform/qt/FrameQt.cpp:
706         (WebCore::FrameQt::openURL):
707         (WebCore::FrameQt::openURLRequest):
708         * platform/qt/FrameQt.h:
709         * platform/win/TemporaryLinkStubs.cpp:
710         (WebCore::FrameWin::openURL):
711         (WebCore::FrameWin::openURLRequest):
712
713 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
714
715         Reviewed by Adam.
716
717         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11396
718
719         Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
720         anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
721         or broken.
722
723         * CMakeLists.txt:
724         * WebCore.xcodeproj/project.pbxproj:
725         * kcanvas/KCanvasTreeDebug.cpp:
726         (WebCore::operator<<):
727         (WebCore::writeStyle):
728         * kcanvas/RenderPath.cpp:
729         (WebCore::RenderPath::fillContains):
730         * kcanvas/device/KRenderingFillPainter.cpp:
731         * kcanvas/device/KRenderingFillPainter.h:
732         * kcanvas/device/KRenderingStrokePainter.cpp:
733         * kcanvas/device/KRenderingStrokePainter.h:
734         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
735         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
736         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
737         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
738         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
739         (WebCore::KRenderingPaintServerQt::setPenProperties):
740         * kcanvas/device/qt/KRenderingPaintServerQt.h:
741         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
742         (WebCore::KRenderingPaintServerSolidQt::setup):
743         * kcanvas/device/qt/RenderPathQt.cpp:
744         (WebCore::getPathStroke):
745         (WebCore::RenderPath::strokeBBox):
746         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
747         (WebCore::RenderPath::strokeBBox):
748         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
749         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
750         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
751         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
752         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
753         * kcanvas/device/quartz/QuartzSupport.h:
754         (WebCore::CGLineCapFromKC):
755         (WebCore::CGLineJoinFromKC):
756         * kcanvas/device/quartz/QuartzSupport.mm:
757         (WebCore::applyStrokeStyleToContext):
758         (WebCore::strokeBoundingBox):
759         * ksvg2/css/SVGCSSStyleSelector.cpp:
760         (WebCore::CSSStyleSelector::applySVGProperty):
761         * ksvg2/css/SVGRenderStyle.h:
762         (WebCore::SVGRenderStyle::InheritedFlags::):
763         * ksvg2/css/SVGRenderStyleDefs.h:
764         * ksvg2/misc/KCanvasRenderingStyle.cpp:
765         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
766         * ksvg2/misc/KCanvasRenderingStyle.h:
767         * ksvg2/svg/SVGFEImageElement.cpp:
768
769 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
770
771         Reviewed by Anders.
772
773         Nixed a few more redundant loading functions in Frame. Did my best to update
774         the non-Mac builds.
775
776         * bridge/mac/FrameMac.h:
777         * bridge/mac/FrameMac.mm:
778         (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture
779         to actually check for a user gesture. New callers rely on this behavior,
780         and it seems like the previous behavior must have been a bug.
781         * page/Frame.cpp:
782         (WebCore::Frame::requestFrame):
783         (WebCore::Frame::frameLoader):
784         (WebCore::Frame::redirectionTimerFired):
785         * page/Frame.h:
786         * platform/gdk/FrameGdk.cpp:
787         * platform/gdk/FrameGdk.h:
788         * platform/gdk/TemporaryLinkStubs.cpp:
789         (FrameGdk::issueCopyCommand):
790         * platform/qt/FrameQt.cpp:
791         * platform/qt/FrameQt.h:
792         * platform/win/TemporaryLinkStubs.cpp:
793         (WebCore::FrameWin::shouldInterruptJavaScript):
794         (WebCore::FrameWin::issueCopyCommand):
795
796 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
797
798         Reviewed by Maciej.
799
800         Fix Qt/Linux build.
801
802         - Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
803         - Fix CMakeLists.txt to include platform/network.
804
805         * CMakeLists.txt:
806         * platform/qt/BrowserExtensionQt.cpp: Removed.
807         * platform/qt/BrowserExtensionQt.h: Removed.
808         * platform/qt/FrameQt.cpp:
809         (WebCore::FrameQt::FrameQt):
810         (WebCore::FrameQt::createNewWindow):
811         (WebCore::FrameQt::goBackOrForward):
812         (WebCore::FrameQt::historyURL):
813         (WebCore::FrameQt::getHistoryLength):
814         * platform/qt/FrameQt.h:
815         * platform/qt/PageQt.cpp:
816         (WebCore::Page::canRunModal):
817         (WebCore::Page::canRunModalNow):
818         (WebCore::Page::runModal):
819
820 2006-10-24  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
821
822         Reviewed by Tim H.
823
824         Fix for http://bugs.webkit.org/show_bug.cgi?id=11314
825         Fix build when XSLT_SUPPORT is not defined
826
827         Fix unconditional use of XSLT support.
828
829         * dom/XMLTokenizer.cpp:
830         (WebCore::XMLTokenizer::end):
831
832 2006-10-24  Simon Hausmann  <hausmann@kde.org>
833
834         Reviewed by Darin.
835
836         * CMakeLists.txt: Added project name to kde4_automoc macro, as
837           required by the latest KDE4 cmake module.
838
839 2006-10-24  Mitz Pettel  <mitz@webkit.org>
840
841         Reviewed by Tim H.
842
843         - fix http://bugs.webkit.org/show_bug.cgi?id=11394
844           HTMLViewSourceDocuments are leaking
845
846         * html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid
847         ref cycle.
848
849 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
850
851         Reviewed by Darin.
852
853         Removed one of Frame's redundant urlSelected methods.
854
855         * bridge/mac/FrameMac.h:
856         * bridge/mac/FrameMac.mm:
857         (WebCore::FrameMac::urlSelected):
858         since it's unused.
859         * html/HTMLAnchorElement.cpp:
860         (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString
861         to String because the former is deprecated and its performance is irrelevant
862         here. Added call to completeURL because Frame no longer does it for us.
863         Having the call here also improves clarity about the element's behavior.
864         * ksvg2/svg/SVGAElement.cpp:
865         (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre
866         irrelevent NULL checks on ownerDocument() because I couldn't help myself.
867         * page/Frame.cpp:
868         (WebCore::Frame::changeLocation):
869         (WebCore::Frame::urlSelected):
870         * page/Frame.h:
871         * platform/network/ResourceRequest.h: Removed explicit keyword on constructor
872         because we want to be able to use these constructors instead of helper functions
873         mimicking their behavior sprinkled across different classes.
874         (WebCore::ResourceRequest::ResourceRequest):
875
876 2006-10-24  Brady Eidson  <beidson@apple.com>
877
878         Reviewed by Maciej
879
880         Moved FrameLoader from WebCoreFrameBridge to Frame.  Frame.h/cpp have generic accessors to the FrameLoader itself
881         and creation/deletion is currently managed in FrameMac.mm
882
883         Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the 
884         frame instead of the bridge.
885
886         The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make 
887         use of it as its days are numbered!
888
889         * bridge/mac/FrameMac.mm:
890         (WebCore::FrameMac::FrameMac): Create the FrameLoader
891         (WebCore::FrameMac::~FrameMac): Nuke it
892         (WebCore::FrameMac::loadRequest):
893
894         * bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
895         * bridge/mac/WebCoreFrameBridge.mm:
896         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader
897         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto
898         (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader
899         (-[WebCoreFrameBridge setFrameLoaderClient:]):
900         (-[WebCoreFrameBridge frameLoader]):
901         (-[WebCoreFrameBridge setTitle:]):
902         (-[WebCoreFrameBridge didFirstLayout]):
903         (-[WebCoreFrameBridge notifyIconChanged:]):
904         (-[WebCoreFrameBridge originalRequestURL]):
905         (-[WebCoreFrameBridge isLoadTypeReload]):
906         (-[WebCoreFrameBridge frameDetached]):
907         (-[WebCoreFrameBridge tokenizerProcessedData]):
908         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
909         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
910         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
911         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
912         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
913         (-[WebCoreFrameBridge incomingReferrer]):
914         (-[WebCoreFrameBridge isReloading]):
915         (-[WebCoreFrameBridge handledOnloadEvents]):
916         (-[WebCoreFrameBridge mainResourceURLResponse]):
917         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
918
919         * loader/mac/WebDocumentLoader.mm:
920         (WebCore::DocumentLoader::frameLoader):
921
922         * loader/mac/WebFrameLoader.mm:
923         (WebCore::FrameLoader::load):
924         (WebCore::FrameLoader::stopLoadingSubframes):
925         (WebCore::FrameLoader::defersCallbacksChanged):
926         (WebCore::FrameLoader::setState):
927         (WebCore::FrameLoader::closeOldDataSources):
928         (WebCore::FrameLoader::subframeIsLoading):
929         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
930         (WebCore::FrameLoader::post):
931         (WebCore::FrameLoader::detachChildren):
932         (WebCore::FrameLoader::checkLoadComplete):
933
934         * loader/mac/WebLoader.mm:
935         (WebCore::WebResourceLoader::frameLoader):
936
937         * loader/mac/WebSubresourceLoader.mm:
938         (-[WebCoreSubresourceHandle initWithLoader:]):
939
940         * page/Frame.cpp:
941         (WebCore::Frame::frameLoader):
942         * page/Frame.h:
943         * page/FramePrivate.h:
944         (WebCore::FramePrivate::FramePrivate):
945
946 2006-10-24  Darin Adler  <darin@apple.com>
947
948         Reviewed by Maciej.
949
950         - fixed two crashes in layout tests I just introduced
951
952         * loader/mac/WebFrameLoader.mm:
953         (WebCore::FrameLoader::load): Add null check.
954         (WebCore::FrameLoader::setState): Ditto.
955
956 2006-10-23  Darin Adler  <darin@apple.com>
957
958         Reviewed by Geoff.
959
960         - converted WebDocumentLoader to C++
961
962         * WebCore.exp:
963         * bridge/mac/WebCoreFrameBridge.mm:
964         (-[WebCoreFrameBridge setTitle:]):
965         (-[WebCoreFrameBridge originalRequestURL]):
966         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
967         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
968         (-[WebCoreFrameBridge incomingReferrer]):
969         (-[WebCoreFrameBridge isReloading]):
970         (-[WebCoreFrameBridge mainResourceURLResponse]):
971         * loader/mac/WebDocumentLoader.h:
972         * loader/mac/WebDocumentLoader.mm:
973         (WebCore::DocumentLoader::DocumentLoader):
974         (WebCore::DocumentLoader::frameLoader):
975         (WebCore::DocumentLoader::~DocumentLoader):
976         (WebCore::DocumentLoader::setMainResourceData):
977         (WebCore::DocumentLoader::mainResourceData):
978         (WebCore::DocumentLoader::originalRequest):
979         (WebCore::DocumentLoader::originalRequestCopy):
980         (WebCore::DocumentLoader::request):
981         (WebCore::DocumentLoader::initialRequest):
982         (WebCore::DocumentLoader::actualRequest):
983         (WebCore::DocumentLoader::URL):
984         (WebCore::DocumentLoader::unreachableURL):
985         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
986         (WebCore::DocumentLoader::setRequest):
987         (WebCore::DocumentLoader::setResponse):
988         (WebCore::DocumentLoader::isStopping):
989         (WebCore::DocumentLoader::bridge):
990         (WebCore::DocumentLoader::setMainDocumentError):
991         (WebCore::DocumentLoader::mainDocumentError):
992         (WebCore::DocumentLoader::clearErrors):
993         (WebCore::DocumentLoader::mainReceivedError):
994         (WebCore::DocumentLoader::stopLoading):
995         (WebCore::DocumentLoader::setupForReplace):
996         (WebCore::DocumentLoader::commitIfReady):
997         (WebCore::DocumentLoader::finishedLoading):
998         (WebCore::DocumentLoader::setCommitted):
999         (WebCore::DocumentLoader::isCommitted):
1000         (WebCore::DocumentLoader::setLoading):
1001         (WebCore::DocumentLoader::isLoading):
1002         (WebCore::DocumentLoader::commitLoad):
1003         (WebCore::DocumentLoader::doesProgressiveLoad):
1004         (WebCore::DocumentLoader::receivedData):
1005         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1006         (WebCore::DocumentLoader::updateLoading):
1007         (WebCore::DocumentLoader::response):
1008         (WebCore::DocumentLoader::setFrame):
1009         (WebCore::DocumentLoader::attachToFrame):
1010         (WebCore::DocumentLoader::detachFromFrame):
1011         (WebCore::DocumentLoader::prepareForLoadStart):
1012         (WebCore::DocumentLoader::loadingStartedTime):
1013         (WebCore::DocumentLoader::setIsClientRedirect):
1014         (WebCore::DocumentLoader::isClientRedirect):
1015         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1016         (WebCore::DocumentLoader::isLoadingInAPISense):
1017         (WebCore::DocumentLoader::addResponse):
1018         (WebCore::DocumentLoader::stopRecordingResponses):
1019         (WebCore::DocumentLoader::title):
1020         (WebCore::DocumentLoader::setLastCheckedRequest):
1021         (WebCore::DocumentLoader::lastCheckedRequest):
1022         (WebCore::DocumentLoader::triggeringAction):
1023         (WebCore::DocumentLoader::setTriggeringAction):
1024         (WebCore::DocumentLoader::responses):
1025         (WebCore::DocumentLoader::setOverrideEncoding):
1026         (WebCore::DocumentLoader::overrideEncoding):
1027         (WebCore::DocumentLoader::setTitle):
1028         (WebCore::DocumentLoader::URLForHistory):
1029         * loader/mac/WebFrameLoader.h:
1030         * loader/mac/WebFrameLoader.mm:
1031         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1032         (WebCore::FrameLoader::finalSetupForReplace):
1033         (WebCore::FrameLoader::safeLoad):
1034         (WebCore::FrameLoader::load):
1035         (WebCore::FrameLoader::startLoading):
1036         (WebCore::FrameLoader::stopLoading):
1037         (WebCore::FrameLoader::activeDocumentLoader):
1038         (WebCore::FrameLoader::addPlugInStreamLoader):
1039         (WebCore::FrameLoader::removePlugInStreamLoader):
1040         (WebCore::FrameLoader::addSubresourceLoader):
1041         (WebCore::FrameLoader::removeSubresourceLoader):
1042         (WebCore::FrameLoader::setDocumentLoader):
1043         (WebCore::FrameLoader::documentLoader):
1044         (WebCore::FrameLoader::setPolicyDocumentLoader):
1045         (WebCore::FrameLoader::provisionalDocumentLoader):
1046         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1047         (WebCore::FrameLoader::setState):
1048         (WebCore::FrameLoader::clearProvisionalLoad):
1049         (WebCore::FrameLoader::commitProvisionalLoad):
1050         (WebCore::FrameLoader::didReceiveResponse):
1051         (WebCore::FrameLoader::originalRequest):
1052         (WebCore::FrameLoader::receivedMainResourceError):
1053         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1054         (WebCore::FrameLoader::opened):
1055         (WebCore::FrameLoader::initialRequest):
1056         (WebCore::FrameLoader::receivedData):
1057         (WebCore::FrameLoader::setRequest):
1058         (WebCore::FrameLoader::isStopping):
1059         (WebCore::FrameLoader::setResponse):
1060         (WebCore::FrameLoader::mainReceivedError):
1061         (WebCore::FrameLoader::finishedLoading):
1062         (WebCore::FrameLoader::notifyIconChanged):
1063         (WebCore::FrameLoader::URL):
1064         (WebCore::FrameLoader::checkContentPolicy):
1065         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
1066         (WebCore::FrameLoader::reloadAllowingStaleData):
1067         (WebCore::FrameLoader::reload):
1068         (WebCore::FrameLoader::finishedLoadingDocument):
1069         (WebCore::FrameLoader::committedLoad):
1070         (WebCore::FrameLoader::revertToProvisional):
1071         (WebCore::FrameLoader::setMainDocumentError):
1072         (WebCore::FrameLoader::mainReceivedCompleteError):
1073         (WebCore::FrameLoader::subframeIsLoading):
1074         (WebCore::FrameLoader::willChangeTitle):
1075         (WebCore::FrameLoader::didChangeTitle):
1076         (WebCore::FrameLoader::checkNavigationPolicy):
1077         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
1078         (WebCore::FrameLoader::transitionToCommitted):
1079         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1080         (WebCore::FrameLoader::detachFromParent):
1081         * loader/mac/WebFrameLoaderClient.h:
1082
1083 2006-10-23  Brady Eidson  <beidson@apple.com>
1084
1085         Lovingly reviewed by Maciej
1086
1087         Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
1088         This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself
1089
1090         * bridge/mac/BrowserExtensionMac.mm:
1091         (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest
1092
1093         * bridge/mac/FrameMac.mm:
1094         (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here
1095
1096         * bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
1097         * bridge/mac/WebCoreFrameBridge.mm: Ditto
1098         * loader/mac/WebFrameLoader.mm:
1099         (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest
1100
1101 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1102
1103         RS by Maciej.
1104
1105         Inside Frame, moved the plethora of load() and stopLoading() functions next 
1106         to each other to facilitate merging and crying.
1107
1108         * bridge/mac/FrameMac.h:
1109         * bridge/mac/FrameMac.mm:
1110         (WebCore::FrameMac::loadRequest):
1111         (WebCore::FrameMac::submitForm):
1112         (WebCore::FrameMac::openURL):
1113         (WebCore::FrameMac::openURLRequest):
1114         (WebCore::FrameMac::urlSelected):
1115         (WebCore::FrameMac::openURLFromPageCache):
1116         (WebCore::FrameMac::createFrame):
1117         * page/Frame.cpp:
1118         (WebCore::Frame::openURL):
1119         (WebCore::Frame::changeLocation):
1120         (WebCore::Frame::urlSelected):
1121         (WebCore::Frame::requestFrame):
1122         (WebCore::Frame::loadSubframe):
1123         (WebCore::Frame::submitFormAgain):
1124         (WebCore::Frame::submitForm):
1125         (WebCore::Frame::stop):
1126         (WebCore::Frame::closeURL):
1127         (WebCore::Frame::cancelRedirection):
1128         (WebCore::Frame::iconURL):
1129         (WebCore::Frame::didOpenURL):
1130         (WebCore::Frame::didExplicitOpen):
1131         * page/Frame.h:
1132
1133 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1134
1135         RS by Maciej.
1136
1137         Moved our plethora of load() and stopLoading() functions next to each other
1138         to facilitate merging and laughter.
1139
1140         * loader/mac/WebFrameLoader.h:
1141         * loader/mac/WebFrameLoader.mm:
1142         (WebCore::cancelAll):
1143         (WebCore::FrameLoader::prepareForLoadStart):
1144         (WebCore::FrameLoader::setupForReplace):
1145         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1146         (WebCore::FrameLoader::finalSetupForReplace):
1147         (WebCore::FrameLoader::safeLoad):
1148         (WebCore::FrameLoader::load):
1149         (WebCore::FrameLoader::startLoadingMainResource):
1150         (WebCore::FrameLoader::startLoading):
1151         (WebCore::FrameLoader::stopLoadingPlugIns):
1152         (WebCore::FrameLoader::stopLoadingSubresources):
1153         (WebCore::FrameLoader::stopLoading):
1154         (WebCore::FrameLoader::stopLoadingSubframes):
1155         (WebCore::FrameLoader::cancelMainResourceLoad):
1156         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1157         (WebCore::FrameLoader::removeSubresourceLoader):
1158         (WebCore::FrameLoader::mainResourceData):
1159         (WebCore::FrameLoader::releaseMainResourceLoader):
1160
1161 2006-10-23  Darin Adler  <darin@apple.com>
1162
1163         Reviewed by Maciej.
1164
1165         - converted WebFrameLoader to C++
1166
1167         * WebCore.exp: Added many new entry points for WebKit.
1168         * WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).
1169
1170         * bridge/mac/WebCoreFrameBridge.h:
1171         * bridge/mac/WebCoreFrameBridge.mm:
1172         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
1173         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
1174         (-[WebCoreFrameBridge dealloc]):
1175         (-[WebCoreFrameBridge close]):
1176         (-[WebCoreFrameBridge clearFrame]):
1177         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1178         (-[WebCoreFrameBridge frameLoader]):
1179         (-[WebCoreFrameBridge setTitle:]):
1180         (-[WebCoreFrameBridge didFirstLayout]):
1181         (-[WebCoreFrameBridge notifyIconChanged:]):
1182         (-[WebCoreFrameBridge originalRequestURL]):
1183         (-[WebCoreFrameBridge isLoadTypeReload]):
1184         (-[WebCoreFrameBridge frameDetached]):
1185         (-[WebCoreFrameBridge tokenizerProcessedData]):
1186         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1187         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1188         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
1189         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1190         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
1191         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
1192         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
1193         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1194         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1195         (-[WebCoreFrameBridge incomingReferrer]):
1196         (-[WebCoreFrameBridge isReloading]):
1197         (-[WebCoreFrameBridge handledOnloadEvents]):
1198         (-[WebCoreFrameBridge mainResourceURLResponse]):
1199         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
1200         * loader/mac/WebDocumentLoader.h:
1201         * loader/mac/WebDocumentLoader.mm:
1202         (-[WebDocumentLoader frameLoader]):
1203         (-[WebDocumentLoader dealloc]):
1204         (-[WebDocumentLoader mainResourceData]):
1205         (-[WebDocumentLoader setRequest:]):
1206         (-[WebDocumentLoader bridge]):
1207         (-[WebDocumentLoader setMainDocumentError:]):
1208         (-[WebDocumentLoader mainReceivedError:complete:]):
1209         (-[WebDocumentLoader stopLoading]):
1210         (-[WebDocumentLoader setupForReplace]):
1211         (-[WebDocumentLoader commitIfReady]):
1212         (-[WebDocumentLoader finishedLoading]):
1213         (-[WebDocumentLoader commitLoadWithData:]):
1214         (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]):
1215         (-[WebDocumentLoader setupForReplaceByMIMEType:]):
1216         (-[WebDocumentLoader updateLoading]):
1217         (-[WebDocumentLoader setFrame:]):
1218         (-[WebDocumentLoader attachToFrame]):
1219         (-[WebDocumentLoader detachFromFrame]):
1220         (-[WebDocumentLoader prepareForLoadStart]):
1221         (-[WebDocumentLoader setPrimaryLoadComplete:]):
1222         (-[WebDocumentLoader isLoadingInAPISense]):
1223         (-[WebDocumentLoader setTitle:]):
1224         * loader/mac/WebFrameLoader.h:
1225         (WebCore::FrameLoader::frame):
1226         * loader/mac/WebFrameLoader.mm:
1227         (WebCore::FrameLoader::FrameLoader):
1228         (WebCore::FrameLoader::~FrameLoader):
1229         (WebCore::FrameLoader::activeDocumentLoader):
1230         (WebCore::FrameLoader::addPlugInStreamLoader):
1231         (WebCore::FrameLoader::removePlugInStreamLoader):
1232         (WebCore::FrameLoader::defersCallbacksChanged):
1233         (WebCore::FrameLoader::defersCallbacks):
1234         (WebCore::setAllDefersCallbacks):
1235         (WebCore::FrameLoader::setDefersCallbacks):
1236         (WebCore::cancelAll):
1237         (WebCore::FrameLoader::stopLoadingPlugIns):
1238         (WebCore::FrameLoader::isLoadingMainResource):
1239         (WebCore::FrameLoader::isLoadingSubresources):
1240         (WebCore::FrameLoader::isLoadingPlugIns):
1241         (WebCore::FrameLoader::isLoading):
1242         (WebCore::FrameLoader::stopLoadingSubresources):
1243         (WebCore::FrameLoader::addSubresourceLoader):
1244         (WebCore::FrameLoader::removeSubresourceLoader):
1245         (WebCore::FrameLoader::mainResourceData):
1246         (WebCore::FrameLoader::releaseMainResourceLoader):
1247         (WebCore::FrameLoader::cancelMainResourceLoad):
1248         (WebCore::FrameLoader::startLoadingMainResource):
1249         (WebCore::FrameLoader::stopLoading):
1250         (WebCore::FrameLoader::setDocumentLoader):
1251         (WebCore::FrameLoader::documentLoader):
1252         (WebCore::FrameLoader::setPolicyDocumentLoader):
1253         (WebCore::FrameLoader::provisionalDocumentLoader):
1254         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1255         (WebCore::FrameLoader::state):
1256         (WebCore::FrameLoader::timeOfLastCompletedLoad):
1257         (WebCore::FrameLoader::provisionalLoadStarted):
1258         (WebCore::FrameLoader::setState):
1259         (WebCore::FrameLoader::clearProvisionalLoad):
1260         (WebCore::FrameLoader::markLoadComplete):
1261         (WebCore::FrameLoader::commitProvisionalLoad):
1262         (WebCore::FrameLoader::stopLoadingSubframes):
1263         (WebCore::FrameLoader::startLoading):
1264         (WebCore::FrameLoader::setupForReplace):
1265         (WebCore::FrameLoader::identifierForInitialRequest):
1266         (WebCore::FrameLoader::willSendRequest):
1267         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1268         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1269         (WebCore::FrameLoader::didReceiveResponse):
1270         (WebCore::FrameLoader::didReceiveData):
1271         (WebCore::FrameLoader::didFinishLoad):
1272         (WebCore::FrameLoader::didFailToLoad):
1273         (WebCore::FrameLoader::privateBrowsingEnabled):
1274         (WebCore::FrameLoader::originalRequest):
1275         (WebCore::FrameLoader::receivedMainResourceError):
1276         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
1277         (WebCore::FrameLoader::clientRedirected):
1278         (WebCore::FrameLoader::shouldReload):
1279         (WebCore::FrameLoader::load):
1280         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1281         (WebCore::FrameLoader::closeOldDataSources):
1282         (WebCore::FrameLoader::opened):
1283         (WebCore::FrameLoader::initialRequest):
1284         (WebCore::FrameLoader::receivedData):
1285         (WebCore::FrameLoader::setRequest):
1286         (WebCore::FrameLoader::download):
1287         (WebCore::FrameLoader::bridge):
1288         (WebCore::FrameLoader::handleFallbackContent):
1289         (WebCore::FrameLoader::isStopping):
1290         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1291         (WebCore::FrameLoader::setResponse):
1292         (WebCore::FrameLoader::mainReceivedError):
1293         (WebCore::FrameLoader::finishedLoading):
1294         (WebCore::FrameLoader::notifyIconChanged):
1295         (WebCore::FrameLoader::URL):
1296         (WebCore::FrameLoader::cancelledError):
1297         (WebCore::FrameLoader::fileDoesNotExistError):
1298         (WebCore::FrameLoader::willUseArchive):
1299         (WebCore::FrameLoader::isArchiveLoadPending):
1300         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1301         (WebCore::FrameLoader::handleUnimplementablePolicy):
1302         (WebCore::FrameLoader::cannotShowMIMEType):
1303         (WebCore::FrameLoader::interruptionForPolicyChangeError):
1304         (WebCore::FrameLoader::isHostedByObjectElement):
1305         (WebCore::FrameLoader::isLoadingMainFrame):
1306         (WebCore::FrameLoader::canShowMIMEType):
1307         (WebCore::FrameLoader::representationExistsForURLScheme):
1308         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
1309         (WebCore::FrameLoader::checkNavigationPolicy):
1310         (WebCore::FrameLoader::checkContentPolicy):
1311         (WebCore::FrameLoader::cancelContentPolicyCheck):
1312         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
1313         (WebCore::FrameLoader::reloadAllowingStaleData):
1314         (WebCore::FrameLoader::reload):
1315         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
1316         (WebCore::FrameLoader::finishedLoadingDocument):
1317         (WebCore::FrameLoader::committedLoad):
1318         (WebCore::FrameLoader::isReplacing):
1319         (WebCore::FrameLoader::setReplacing):
1320         (WebCore::FrameLoader::revertToProvisional):
1321         (WebCore::FrameLoader::setMainDocumentError):
1322         (WebCore::FrameLoader::mainReceivedCompleteError):
1323         (WebCore::FrameLoader::finalSetupForReplace):
1324         (WebCore::FrameLoader::prepareForLoadStart):
1325         (WebCore::FrameLoader::subframeIsLoading):
1326         (WebCore::FrameLoader::willChangeTitle):
1327         (WebCore::FrameLoader::didChangeTitle):
1328         (WebCore::FrameLoader::loadType):
1329         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
1330         (WebCore::FrameLoader::checkNewWindowPolicy):
1331         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
1332         (WebCore::FrameLoader::continueAfterNavigationPolicy):
1333         (WebCore::FrameLoader::continueAfterWillSubmitForm):
1334         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
1335         (WebCore::FrameLoader::didFirstLayout):
1336         (WebCore::FrameLoader::frameLoadCompleted):
1337         (WebCore::FrameLoader::firstLayoutDone):
1338         (WebCore::FrameLoader::isQuickRedirectComing):
1339         (WebCore::FrameLoader::transitionToCommitted):
1340         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1341         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
1342         (WebCore::FrameLoader::sendRemainingDelegateMessages):
1343         (WebCore::FrameLoader::requestFromDelegate):
1344         (WebCore::FrameLoader::post):
1345         (WebCore::FrameLoader::detachChildren):
1346         (WebCore::FrameLoader::detachFromParent):
1347         (WebCore::FrameLoader::addExtraFieldsToRequest):
1348         (WebCore::FrameLoader::safeLoad):
1349         (WebCore::FrameLoader::actionInformation):
1350         (WebCore::FrameLoader::checkLoadComplete):
1351         (WebCore::FrameLoader::setFrameLoaderClient):
1352         (WebCore::FrameLoader::client):
1353         (WebCore::FrameLoader::asDelegate):
1354         (-[WebCoreFrameLoaderAsDelegate initWithLoader:]):
1355         (-[WebCoreFrameLoaderAsDelegate detachFromLoader]):
1356         (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]):
1357         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
1358         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
1359         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
1360         (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]):
1361         (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1362         * loader/mac/WebLoader.h:
1363         (WebCore::WebResourceLoader::identifier):
1364         (WebCore::WebResourceLoader::reachedTerminalState):
1365         (WebCore::WebResourceLoader::cancelled):
1366         * loader/mac/WebLoader.mm:
1367         (WebCore::WebResourceLoader::WebResourceLoader):
1368         (WebCore::WebResourceLoader::releaseResources):
1369         (WebCore::WebResourceLoader::load):
1370         (WebCore::WebResourceLoader::frameLoader):
1371         (WebCore::WebResourceLoader::willSendRequest):
1372         (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge):
1373         (WebCore::WebResourceLoader::didCancelAuthenticationChallenge):
1374         (WebCore::WebResourceLoader::didReceiveResponse):
1375         (WebCore::WebResourceLoader::didReceiveData):
1376         (WebCore::WebResourceLoader::didFinishLoading):
1377         (WebCore::WebResourceLoader::didFinishLoadingOnePart):
1378         (WebCore::WebResourceLoader::didFail):
1379         (WebCore::WebResourceLoader::willCacheResponse):
1380         (WebCore::WebResourceLoader::didCancel):
1381         (WebCore::WebResourceLoader::cancel):
1382         (WebCore::WebResourceLoader::cancelledError):
1383         (WebCore::WebResourceLoader::delegate):
1384         * loader/mac/WebMainResourceLoader.h:
1385         * loader/mac/WebMainResourceLoader.mm:
1386         (WebCore::MainResourceLoader::MainResourceLoader):
1387         (WebCore::MainResourceLoader::create):
1388         (WebCore::MainResourceLoader::receivedError):
1389         (WebCore::MainResourceLoader::didCancel):
1390         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
1391         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
1392         (WebCore::MainResourceLoader::addData):
1393         (WebCore::MainResourceLoader::willSendRequest):
1394         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1395         (WebCore::MainResourceLoader::didReceiveResponse):
1396         (WebCore::MainResourceLoader::didReceiveData):
1397         (WebCore::MainResourceLoader::didFinishLoading):
1398         (WebCore::MainResourceLoader::didFail):
1399         (WebCore::MainResourceLoader::loadNow):
1400         (WebCore::MainResourceLoader::policyDelegate):
1401         * loader/mac/WebNetscapePlugInStreamLoader.h:
1402         * loader/mac/WebNetscapePlugInStreamLoader.mm:
1403         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1404         (WebCore::NetscapePlugInStreamLoader::create):
1405         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1406         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1407         (WebCore::NetscapePlugInStreamLoader::didFail):
1408         (WebCore::NetscapePlugInStreamLoader::didCancel):
1409         * loader/mac/WebSubresourceLoader.h:
1410         * loader/mac/WebSubresourceLoader.mm:
1411         (-[WebCoreSubresourceHandle initWithLoader:]):
1412
1413 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1414
1415         Reviewed by Bradee.
1416
1417         Shrunk BrowserExtension in preparation for its imminent death, moving page-
1418         level operations to Page and frame-level operations to Frame.
1419         
1420         Removed bizarre Mac(this) syntax inside virtual FrameMac member functions, 
1421         because 'this' is guaranteed by the compiler to be a FrameMac*.
1422         
1423         * bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places
1424         where it can be NULL.
1425         * bindings/js/kjs_window.cpp:
1426         (KJS::canShowModalDialog):
1427         (KJS::canShowModalDialogNow):
1428         (KJS::showModalDialog):
1429         (KJS::History::getValueProperty):
1430         (KJS::HistoryFunc::callAsFunction):
1431         * bridge/BrowserExtension.h:
1432         (WebCore::BrowserExtension::~BrowserExtension):
1433         * bridge/mac/BrowserExtensionMac.h:
1434         * bridge/mac/BrowserExtensionMac.mm:
1435         (WebCore::BrowserExtensionMac::createNewWindow):
1436         * bridge/mac/FrameMac.h:
1437         * bridge/mac/FrameMac.mm:
1438         (WebCore::FrameMac::frameDetached):
1439         (WebCore::FrameMac::unfocusWindow):
1440         (WebCore::FrameMac::bridgeForWidget):
1441         (WebCore::FrameMac::documentViewForNode):
1442         (WebCore::FrameMac::passSubframeEventToSubframe):
1443         (WebCore::Frame::setNeedsReapplyStyles):
1444         (WebCore::FrameMac::customHighlightLineRect):
1445         (WebCore::FrameMac::paintCustomHighlight):
1446         (WebCore::FrameMac::getHistoryLength):
1447         (WebCore::FrameMac::goBackOrForward):
1448         (WebCore::FrameMac::historyURL):
1449         * bridge/mac/PageMac.mm:
1450         (WebCore::Page::canRunModal):
1451         (WebCore::Page::canRunModalNow):
1452         (WebCore::Page::runModal):
1453         * bridge/mac/WebCoreFrameBridge.h:
1454         * bridge/mac/WebCorePageBridge.h:
1455         * bridge/win/BrowserExtensionWin.h:
1456         * page/Frame.cpp:
1457         (WebCore::Frame::scheduleHistoryNavigation):
1458         (WebCore::Frame::redirectionTimerFired):
1459         * page/Frame.h:
1460         * page/Page.h:
1461
1462 2006-10-23  Justin Garcia  <justin.garcia@apple.com>
1463
1464         Reviewed by mjs
1465
1466         <http://bugs.webkit.org/show_bug.cgi?id=11334>
1467         Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons
1468
1469         * WebCore.xcodeproj/project.pbxproj:
1470         * editing/Editor.cpp:
1471         (WebCore::Editor::selectionUnorderedListState): Added.
1472         (WebCore::Editor::selectionOrderedListState): Added.
1473         * editing/Editor.h:
1474         * editing/JSEditor.cpp:
1475         * page/Frame.cpp:
1476         * page/Frame.h:
1477
1478 2006-10-23  John Sullivan  <sullivan@apple.com>
1479
1480         Reviewed by Tim H
1481
1482         * WebCore.xcodeproj/project.pbxproj:
1483         Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit
1484
1485 2006-10-23  Sam Weinig  <sam.weinig@gmail.com>
1486
1487         Reviewed by Tim H.
1488
1489         Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
1490         PNG as cursor image format instead of TIFF
1491
1492         Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)
1493
1494         - Convert cursor images from TIFF to PNG.
1495
1496         * Resources/eastResizeCursor.png: Added.
1497         * Resources/eastResizeCursor.tiff: Removed.
1498         * Resources/eastWestResizeCursor.png: Added.
1499         * Resources/eastWestResizeCursor.tiff: Removed.
1500         * Resources/helpCursor.png: Added.
1501         * Resources/helpCursor.tiff: Removed.
1502         * Resources/linkCursor.png: Added.
1503         * Resources/linkCursor.tiff: Removed.
1504         * Resources/moveCursor.png: Added.
1505         * Resources/moveCursor.tiff: Removed.
1506         * Resources/northEastResizeCursor.png: Added.
1507         * Resources/northEastResizeCursor.tiff: Removed.
1508         * Resources/northEastSouthWestResizeCursor.png: Added.
1509         * Resources/northEastSouthWestResizeCursor.tiff: Removed.
1510         * Resources/northResizeCursor.png: Added.
1511         * Resources/northResizeCursor.tiff: Removed.
1512         * Resources/northSouthResizeCursor.png: Added.
1513         * Resources/northSouthResizeCursor.tiff: Removed.
1514         * Resources/northWestResizeCursor.png: Added.
1515         * Resources/northWestResizeCursor.tiff: Removed.
1516         * Resources/northWestSouthEastResizeCursor.png: Added.
1517         * Resources/northWestSouthEastResizeCursor.tiff: Removed.
1518         * Resources/southEastResizeCursor.png: Added.
1519         * Resources/southEastResizeCursor.tiff: Removed.
1520         * Resources/southResizeCursor.png: Added.
1521         * Resources/southResizeCursor.tiff: Removed.
1522         * Resources/southWestResizeCursor.png: Added.
1523         * Resources/southWestResizeCursor.tiff: Removed.
1524         * Resources/waitCursor.png: Added.
1525         * Resources/waitCursor.tiff: Removed.
1526         * Resources/westResizeCursor.png: Added.
1527         * Resources/westResizeCursor.tiff: Removed.
1528         * WebCore.xcodeproj/project.pbxproj:
1529         * platform/mac/CursorMac.mm:
1530         (WebCore::leakNamedCursor):
1531
1532 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1533
1534         Not reviewed.
1535
1536         - fixed build from last change.
1537
1538         * bridge/mac/FrameMac.h:
1539         * bridge/mac/FrameMac.mm:
1540         (WebCore::FrameMac::loadRequest):
1541         (WebCore::FrameMac::openURL):
1542
1543 2006-10-23  Adam Roben  <aroben@apple.com>
1544
1545         Reviewed by Adele.
1546
1547         Move border-radius rule for <select>s into RenderThemeMac, as this is
1548         really a platform-specific look.
1549
1550         * css/html4.css:
1551         * rendering/RenderThemeMac.mm:
1552         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
1553
1554 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1555
1556         Reviewed by Brady.
1557
1558         - moved things around so loadURL:... is only called from one place
1559
1560         * bridge/mac/FrameMac.h:
1561         * bridge/mac/FrameMac.mm:
1562         (WebCore::FrameMac::frameDetached):
1563         (WebCore::FrameMac::loadRequest):
1564         (WebCore::FrameMac::submitForm):
1565         (WebCore::FrameMac::openURL):
1566         (WebCore::FrameMac::openURLRequest):
1567         (WebCore::FrameMac::urlSelected):
1568
1569 2006-10-23  Justin Garcia  <justin.garcia@apple.com>
1570
1571         Reviewed by john
1572         
1573         <http://bugs.webkit.org/show_bug.cgi?id=11333>
1574         Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document
1575         
1576         Added special cases in InsertLineBreakCommand for inserting before
1577         and after tables and horizontal rules.  Also, perform InsertLineBreak
1578         instead of InsertParagraphSeparator at these positions.
1579
1580         * editing/InsertLineBreakCommand.cpp:
1581         (WebCore::InsertLineBreakCommand::doApply):  Use the canonical form
1582         of the caret position when we check for the new special cases because 
1583         we know that we canonicalize VisiblePositions to those positions.
1584         Added code to handle inserting before/after tables and horizontal rules.  
1585         Fixed a bug when inserting at the end of a block (it checked for a collapse
1586         of the inserted br by looking for the absence of a br, but the line break 
1587         might have been a '\n' in white-space:pre text).  Removed unused LOGs.
1588         * editing/InsertParagraphSeparatorCommand.cpp:
1589         (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an 
1590         InsertLineBreakCommand when before/after a table or a horizontal rule
1591         so that we don't have to maintain two pieces of special case code.
1592         Migrated to enclosingBlock.
1593         * editing/htmlediting.cpp: Added a FIXME.
1594         * editing/visible_units.cpp:
1595         (WebCore::startOfParagraph): Added a workaround for 8622.
1596         
1597 2006-10-23  Adam Roben  <aroben@apple.com>
1598
1599         Reviewed by Adele.
1600
1601         Make popups a little more flexible.
1602
1603         * platform/PopupMenu.h:
1604
1605 2006-10-23  Sam Weinig  <sam.weinig@gmail.com>
1606
1607         Reviewed by Tim H.
1608
1609         Cleanup CodeGeneratorJS.pm
1610
1611         * bindings/scripts/CodeGeneratorJS.pm:
1612
1613 2006-10-23  Adam Roben  <aroben@apple.com>
1614
1615         Rubberstamped by Brady.
1616
1617         * loader/icon/IconLoader.h: Changed angle-brackets to quotes for
1618         #include of ResourceLoader.h, since it's a WebCore header.
1619
1620 2006-10-23  Darin Adler  <darin@apple.com>
1621
1622         - fixed mistake that was preventing any loading from happening
1623
1624         * platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData):
1625         Changed parameter back to int. Perhaps we want to move to "long long" consistently, but
1626         I'll leave that up to Maciej.
1627
1628 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1629
1630         Reviewed by Anders.
1631
1632         - start converting ResourceLoaderClient to new API
1633
1634         Did the bits I could do without introducing new types:
1635         
1636         - renamed receivedData to didReceiveData
1637         - renamed version of receivedAllData that doesn't pass any data to didFinishLoading
1638
1639         * bridge/mac/WebCoreResourceLoaderImp.mm:
1640         (-[WebCoreResourceLoaderImp addData:]):
1641         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
1642         * loader/icon/IconLoader.cpp:
1643         (IconLoader::didReceiveData):
1644         (IconLoader::didFinishLoading):
1645         * loader/icon/IconLoader.h:
1646         * loader/loader.cpp:
1647         (WebCore::Loader::didReceiveData):
1648         * loader/loader.h:
1649         * platform/gdk/FrameGdk.cpp:
1650         (WebCore::FrameGdkClientDefault::didReceiveData):
1651         * platform/gdk/FrameGdk.h:
1652         * platform/network/ResourceLoaderClient.h:
1653         (WebCore::ResourceLoaderClient::didReceiveData):
1654         (WebCore::ResourceLoaderClient::didFinishLoading):
1655         (WebCore::ResourceLoaderClient::receivedResponse):
1656         * platform/network/cf/ResourceLoaderCFNet.cpp:
1657         (WebCore::didReceiveData):
1658         (WebCore::didFinishLoading):
1659         (WebCore::didFail):
1660         (WebCore::ResourceLoader::cancel):
1661         * platform/network/gdk/ResourceLoaderManager.cpp:
1662         (WebCore::writeCallback):
1663         (WebCore::ResourceLoaderManager::downloadTimerCallback):
1664         (WebCore::ResourceLoaderManager::remove):
1665         * platform/network/qt/ResourceLoaderManager.cpp:
1666         (WebCore::ResourceLoaderManager::slotData):
1667         (WebCore::ResourceLoaderManager::remove):
1668         * platform/network/win/ResourceLoaderWin.cpp:
1669         (WebCore::ResourceLoader::onRequestComplete):
1670         (WebCore::ResourceLoader::fileLoadTimer):
1671         (WebCore::ResourceLoader::cancel):
1672         * platform/qt/FrameQtClient.cpp:
1673         (WebCore::FrameQtClientDefault::didReceiveData):
1674         * platform/qt/FrameQtClient.h:
1675         * xml/xmlhttprequest.cpp:
1676         (WebCore::XMLHttpRequest::processSyncLoadResults):
1677         (WebCore::XMLHttpRequest::didFinishLoading):
1678         (WebCore::XMLHttpRequest::didReceiveData):
1679         * xml/xmlhttprequest.h:
1680
1681 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
1682
1683         Rubber stamped by Anders.
1684
1685         - marked files executable
1686         
1687         * ksvg2/scripts/csscssmakeprops:
1688         * ksvg2/scripts/csscssmakevalues:
1689
1690 2006-10-22  Maciej Stachowiak  <mjs@apple.com>
1691
1692         Reviewed by Anders.
1693
1694         - moved ResourceLoader and related files to platform/network
1695         in preparation for building out this API.
1696
1697         I tried to update all the build systems but I'm not sure they are
1698         all fixed properly
1699
1700         * page/ResourceRequest.h: Moved to platform/network.
1701         * platform/ResourceLoader.cpp: Moved to platform/network.
1702         * platform/ResourceLoader.h: Moved to platform/network.
1703         * platform/ResourceLoaderClient.h: Moved to platform/network.
1704         * platform/ResourceLoaderInternal.h: Moved to platform/network.
1705         * platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
1706         * platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
1707         * platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
1708         * platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
1709         * platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
1710         * platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
1711         * platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
1712         * platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
1713         * platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
1714         * platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
1715         * webcore-base.bkl: Updated for new paths.
1716         * CMakeLists.txt: ditto
1717         * Projects/gdk/webcore-gdk.bkl: ditto
1718         * WebCore.xcodeproj/project.pbxproj: ditto
1719         * WebCoreSources.bkl: ditto
1720
1721 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
1722
1723         Reviewed by Tim H.
1724
1725         - Add DOMHTMLFormElementPrivate.h to the project.
1726
1727         * WebCore.xcodeproj/project.pbxproj:
1728         * bindings/objc/DOMPrivate.h:
1729
1730 2006-10-22  Darin Adler  <darin@apple.com>
1731
1732         - another try at fixing Qt
1733
1734         * CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
1735
1736         - and fix a couple warnings while I'm at it
1737
1738         * platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA):
1739         Don't do unsigned *= float.
1740
1741         * rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable
1742         inside #if so it's consistent.
1743
1744 2006-10-21  Darin Adler  <darin@apple.com>
1745
1746         - fix the Qt build
1747
1748         * platform/qt/EditorClientQt.cpp:
1749         (WebCore::EditorClientQt::shouldShowDeleteInterface):
1750         * platform/qt/EditorClientQt.h:
1751         * platform/qt/FrameQt.cpp:
1752
1753 2006-10-21  Darin Adler  <darin@apple.com>
1754
1755         Reviewed by Adele.
1756
1757         - convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)
1758
1759         Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
1760         there's currently another class with that name).
1761         Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
1762         Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
1763         Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
1764
1765         Converted the classes to C++ and added Objective-C delegates to forward from
1766         API that still requires Objective-C.
1767
1768         Did not yet rename the source files.
1769
1770         * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
1771         classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
1772         classes.
1773
1774         * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
1775
1776         * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
1777
1778         * loader/mac/WebLoader.h:
1779         * loader/mac/WebLoader.mm:
1780         * loader/mac/WebMainResourceLoader.h:
1781         * loader/mac/WebMainResourceLoader.mm:
1782         * loader/mac/WebNetscapePlugInStreamLoader.h:
1783         * loader/mac/WebNetscapePlugInStreamLoader.mm:
1784         * loader/mac/WebSubresourceLoader.h:
1785         * loader/mac/WebSubresourceLoader.mm:
1786         Translate to C++.
1787
1788         * bridge/mac/WebCoreFrameBridge.mm:
1789         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1790         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1791         * loader/mac/WebFrameLoader.h:
1792         * loader/mac/WebFrameLoader.mm:
1793         (isCaseInsensitiveEqual):
1794         (isBackForwardLoadType):
1795         (-[WebFrameLoader dealloc]):
1796         (-[WebFrameLoader addPlugInStreamLoader:]):
1797         (-[WebFrameLoader removePlugInStreamLoader:]):
1798         (-[WebFrameLoader setDefersCallbacks:]):
1799         (-[WebFrameLoader stopLoadingPlugIns]):
1800         (-[WebFrameLoader isLoadingMainResource]):
1801         (-[WebFrameLoader isLoadingSubresources]):
1802         (-[WebFrameLoader isLoadingPlugIns]):
1803         (-[WebFrameLoader stopLoadingSubresources]):
1804         (-[WebFrameLoader addSubresourceLoader:]):
1805         (-[WebFrameLoader removeSubresourceLoader:]):
1806         (-[WebFrameLoader mainResourceData]):
1807         (-[WebFrameLoader releaseMainResourceLoader]):
1808         (-[WebFrameLoader cancelMainResourceLoad]):
1809         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
1810         (-[WebFrameLoader stopLoadingWithError:]):
1811         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
1812         (-[WebFrameLoader archiveLoadPendingForLoader:]):
1813         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
1814         * loader/mac/WebFrameLoaderClient.h:
1815         Call the new C++ API.
1816
1817 2006-10-21  Adam Roben  <aroben@apple.com>
1818
1819         Reviewed by Anders.
1820
1821         Popup tweaks.
1822
1823         * platform/PopupMenu.h:
1824
1825 2006-10-21  Darin Adler  <darin@apple.com>
1826
1827         * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable):
1828         Oops, edited this before landing it and introduced a null-deref! This fixes it.
1829
1830 2006-10-21  Darin Adler  <darin@apple.com>
1831
1832         Reviewed by Anders.
1833
1834         - fix http://bugs.webkit.org/show_bug.cgi?id=11379
1835           assertion failure seen in editing tests (in new DeleteButtonController)
1836
1837         I cleaned up the relationship between the Frame, Editor, EditorClient, and
1838         DeleteButtonController a bit while also making the simple change to fix the
1839         assertion failure.
1840
1841         * bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
1842         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
1843
1844         * page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
1845         * page/Frame.cpp:
1846         (WebCore::Frame::Frame): Ditto.
1847         (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents
1848         function, and moved it to Editor rather than right on the DeleteButtonController.
1849         (WebCore::Frame::unappliedEditing): Ditto.
1850         (WebCore::Frame::reappliedEditing): Ditto.
1851         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
1852
1853         * editing/DeleteButtonController.h:
1854         * editing/DeleteButtonController.cpp:
1855         (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*.
1856         The general pattern is that we always use the Frame* as the frame identifier. See FrameTree,
1857         for example.
1858         (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection
1859         function. Includes an additional check for whether the container is contentEditable, which
1860         was missing from the old version. This prevents the assertion failure. Also added a check that
1861         the table itself is editable.
1862         (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper.
1863         (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary
1864         selection parameter. No need to pass in the state of the frame since we can get it if we need it.
1865         (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
1866
1867         * editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be
1868         formatted on multiple lines as usual.
1869         (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller.
1870         (WebCore::Editor::respondToChangedContents): Ditto.
1871         (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
1872
1873         * editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being
1874         defined inline to decouple so that we don't have to include DeleteButtonController.h. That way
1875         changes to DeleteButtonController.h cause very little to recompile.
1876
1877         * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
1878         Updated to call the editor instead of the delete button controller for the selection change.
1879
1880 2006-10-21  Anders Carlsson  <acarlsson@apple.com>
1881
1882         Reviewed by Darin.
1883
1884         * loader/mac/LoaderFunctionsMac.mm:
1885         (WebCore::ServeSynchronousRequest):
1886         * platform/mac/ResourceLoaderMac.mm:
1887         (WebCore::ResourceLoader::start):
1888         Don't leak the header dictionary.
1889
1890 2006-10-21  Darin Adler  <darin@apple.com>
1891
1892         Reviewed by Adam.
1893
1894         - http://bugs.webkit.org/show_bug.cgi?id=11376
1895           build scripts should invoke make with "-j" option for multiple processors
1896
1897         * WebCore.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
1898
1899 2006-10-21  Timothy Hatcher  <timothy@apple.com>
1900
1901         Reviewed by Geoff.
1902
1903         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
1904
1905         Initial implementaltion of table deletion user interface:
1906         * Interface shows up on the nearest table containing the entire selection.
1907         * Shows a Dashboard style close button in the top left corner.
1908         * Shows a 60% opaque black outline around the table.
1909         * Adds a new EditorClient function shouldShowDeleteInterface.
1910
1911         Also adds a new constructor CachedImage and setter functions on
1912         HTMLImageElement and HTMLImageLoader allowing an Image object to be set
1913         and image element in the page. This change also paves the way to allow an
1914         NSImage setter on DOMHTMLImageElement. 
1915
1916         * Resources/deleteButton.tiff: Added.
1917         * Resources/deleteButtonPressed.tiff: Added.
1918         * WebCore.xcodeproj/project.pbxproj:
1919         * bridge/EditorClient.h:
1920         * editing/DeleteButton.cpp: Added.
1921         (WebCore::DeleteButton::DeleteButton):
1922         (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
1923         * editing/DeleteButton.h: Added.
1924         * editing/DeleteButtonController.cpp: Added.
1925         (WebCore::DeleteButtonController::DeleteButtonController):
1926         (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide
1927         (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle
1928         (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size
1929         (WebCore::DeleteButtonController::show): shows the interface on a new element
1930         (WebCore::DeleteButtonController::hide): hides the existing interface
1931         (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
1932         * editing/DeleteButtonController.h: Added.
1933         (WebCore::DeleteButtonController::target): getter for the current target
1934         * editing/Editor.cpp:
1935         (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function
1936         (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client
1937         (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
1938         * editing/Editor.h:
1939         (WebCore::Editor::frame): new getter
1940         (WebCore::Editor::deleteButtonController): ditto
1941         * editing/SelectionController.cpp:
1942         (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
1943         * html/HTMLImageElement.h:
1944         (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
1945         * html/HTMLImageLoader.cpp:
1946         (WebCore::HTMLImageLoader::setImage): ditto
1947         * html/HTMLImageLoader.h:
1948         * loader/CachedImage.cpp:
1949         (WebCore::CachedImage::CachedImage): new constructor that takes an Image
1950         * loader/CachedImage.h: ditto
1951         * page/Frame.cpp:
1952         (WebCore::Frame::selectionController): cleanup coding style
1953         (WebCore::Frame::editor): ditto
1954         (WebCore::Frame::command): ditto
1955         (WebCore::Frame::appliedEditing): tell the delete button outline to update
1956         (WebCore::Frame::unappliedEditing): ditto
1957         (WebCore::Frame::reappliedEditing): ditto
1958         * rendering/RenderTable.cpp:
1959         (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed
1960
1961 2006-10-21  Sam Weinig  <sam.weinig@gmail.com>
1962
1963         Reviewed by Tim H.
1964
1965         Cleanup bindings generation a little through re-factoring 
1966         and general style cleanup.
1967
1968         * bindings/scripts/CodeGenerator.pm:
1969         * bindings/scripts/CodeGeneratorJS.pm:
1970         * bindings/scripts/CodeGeneratorObjC.pm:
1971
1972 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
1973
1974         Reviewed by Mitz.
1975
1976         Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.
1977
1978         * CMakeLists.txt:
1979         * platform/qt/EditorClientQt.cpp: Added.
1980         (WebCore::EditorClientQt::shouldDeleteRange):
1981         * platform/qt/EditorClientQt.h: Added.
1982         (WebCore::EditorClientQt::~EditorClientQt):
1983         * platform/qt/FrameQt.cpp:
1984         (WebCore::FrameQt::FrameQt):
1985         * platform/qt/FrameQt.h:
1986
1987 2006-10-21  Sam Weinig  <sam.weinig@gmail.com>
1988
1989         Reviewed by Tim H.
1990
1991         Fix for http://bugs.webkit.org/show_bug.cgi?id=11372
1992         Auto-generate a few more Objective-C DOM methods.
1993
1994         - Auto-generate getMatchedCSSRules and getComputedStyle methods.
1995
1996         * bindings/objc/DOMCSS.h:
1997         * bindings/objc/DOMCSS.mm:
1998         * bindings/objc/DOMExtensions.h:
1999         * bindings/objc/PublicDOMInterfaces.h:
2000         * bindings/scripts/CodeGeneratorObjC.pm:
2001         * dom/Document.idl:
2002         * page/DOMWindow.idl:
2003
2004 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
2005
2006         Reviewed by aliu, landed by aliu.
2007
2008         Fix Qt/Linux build.
2009
2010         * CMakeLists.txt:
2011         * platform/qt/FrameQt.cpp:
2012         (WebCore::FrameQt::FrameQt):
2013         * platform/qt/SoundQt.cpp: Added.
2014         (WebCore::systemBeep):
2015
2016 2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>
2017
2018         Reviewed by Mitz, landed by ap.
2019
2020         Fix obscure crashes in RenderTableSection on Rob's musicdb file.
2021         The problem was a missing layout() call on the frame view.
2022         Thanks go to Mitz Pettel for the initial hint!
2023
2024         * platform/qt/ScrollViewCanvasQt.cpp:
2025         (WebCore::ScrollViewCanvasQt::paintEvent):
2026
2027 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
2028
2029         Reviewed by Anders.
2030
2031         Send User-Agent on requests.
2032         Send custom request headers properly.
2033
2034         * platform/cf/ResourceLoaderCFNet.cpp:
2035         (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing
2036         (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
2037
2038 2006-10-20  Timothy Hatcher  <timothy@apple.com>
2039
2040         Reviewed by Hyatt.
2041
2042         Fix some bad formatting.
2043
2044         * css/cssstyleselector.cpp:
2045         (WebCore::CSSStyleSelector::checkOneSelector):
2046
2047 2006-10-20  Darin Adler  <darin@apple.com>
2048
2049         Reviewed by John.
2050
2051         - fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
2052
2053         * loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key"
2054         as the key, not the dictionary itself.
2055
2056 2006-10-20  Alice Liu  <alice.liu@apple.com>
2057
2058         Reviewed by Maciej.
2059
2060         This is the initial foundation for the EditingController class and
2061         everything else it needs to work.  The idea is that the Frame has an
2062         EditingController object that it calls to handle editing commands, the
2063         most simple examples being copy/paste.  This controller will handle
2064         these editing commands in WebCore, and only hand off to WebKit to call
2065         editing delegates (to the let the app intercept editing actions if it
2066         wants to).  Thus we need a platform-specific client to which the
2067         EditingController hands off the delegate calls, 
2068         WebCoreEditingControllerClient.  On the WebCore side this is an 
2069         abstract base class, and on the WebKit(Mac) side this is an ObjC++
2070         subclass, WebEditingControllerClient.  How does the EditingController
2071         get a handle to its platform-specific client?  In WebKit, the creator
2072         of a platform-specific Frame creates the client (which is ref-counted)
2073         and passes it down the chain of constructors until it gets back to the
2074         EditingController, which then refs it in its constructor and derefs in
2075         its destructor.
2076         
2077         No Layout tests needed.
2078         
2079         * WebCore.xcodeproj/project.pbxproj:
2080         Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
2081
2082         * bridge/EditorClient.h: Added.
2083         (WebCore::EditorClient::~EditorClient):
2084
2085         * bridge/mac/FrameMac.h:
2086         Added an EditingClient to the constructor, to pass down to Frame constructor
2087
2088         * bridge/mac/FrameMac.mm:
2089         (WebCore::FrameMac::FrameMac):
2090         Passed client down to Frame constructor
2091         
2092         * bridge/mac/WebCoreFrameBridge.h:
2093         Added an EditingClient to the constructor, to pass down to FrameMac constructor
2094         
2095         * bridge/mac/WebCoreFrameBridge.mm:
2096         (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
2097         (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
2098         Passed client down to FrameMac constructor
2099         
2100         * editing/Editor.cpp: Added.
2101         Mostly stuf implementations of the following functions, except for a couple.  These are all needed by cut, copy, paste, delete.
2102         (WebCore::generalPasteboard):
2103         (WebCore::Editor::canCopy):
2104         (WebCore::Editor::canCut):
2105         (WebCore::Editor::canDelete):
2106         (WebCore::Editor::canDeleteRange):
2107         (WebCore::Editor::canPaste):
2108         (WebCore::Editor::canSmartCopyOrDelete):
2109         (WebCore::Editor::deleteSelection):
2110         (WebCore::Editor::deleteSelectionWithSmartDelete):
2111         (WebCore::Editor::isSelectionRichlyEditable):
2112         (WebCore::Editor::pasteAsPlainTextWithPasteboard):
2113         (WebCore::Editor::pasteWithPasteboard):
2114         (WebCore::Editor::selectedRange):
2115         (WebCore::Editor::shouldDeleteRange):
2116         (WebCore::Editor::tryDHTMLCopy):
2117         (WebCore::Editor::tryDHTMLCut):
2118         (WebCore::Editor::tryDHTMLPaste):
2119         (WebCore::Editor::writeSelectionToPasteboard):
2120         (WebCore::Editor::Editor):
2121         (WebCore::Editor::~Editor):
2122         (WebCore::Editor::cut):
2123         (WebCore::Editor::copy):
2124         (WebCore::Editor::paste):
2125         (WebCore::Editor::performDelete):
2126         
2127         * editing/Editor.h: Added.
2128         
2129         * page/Frame.h:
2130         Added an EditingClient to the constructor, to pass down to Editor constructor
2131
2132         * page/Frame.cpp:
2133         (WebCore::Frame::Frame):
2134         Passed down to Editor constructor
2135         (WebCore::Frame::editor):
2136         Accessor for Editor stored in FramePrivate
2137         
2138         * page/FramePrivate.h:
2139         (WebCore::FramePrivate::FramePrivate):
2140         Added an Editor object to the FramePrivate data
2141         
2142         * platform/Sound.h: Added.
2143         Made a platform-independent accessor to a beep function
2144         
2145         * platform/mac/SoundMac.mm: Added.
2146         (WebCore::systemBeep):
2147         calls mac system beep
2148         
2149 2006-10-20  David Hyatt  <hyatt@apple.com>
2150
2151         Make sure to support the "encoding" property on form elements for
2152         legacy compatibility.
2153
2154         Reviewed by darin/john
2155
2156         No test cases added.  Not sure how to do a form submission of
2157         various encodings as a layout test.
2158
2159         * html/HTMLFormElement.h:
2160         (WebCore::HTMLFormElement::encoding):
2161         (WebCore::HTMLFormElement::setEncoding):
2162         * html/HTMLFormElement.idl:
2163
2164 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
2165
2166         Reviewed and by Anders.
2167
2168         Fix warnings in JS generation by killing the whole isRefPtr logic,
2169         and just using WTF::getPtr as Sam Weinig suggested. Also kill some
2170         places using get() where getPtr() is cleaner - not for m_impl.get().
2171
2172         * CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
2173         * bindings/scripts/CodeGeneratorJS.pm:
2174
2175 2006-10-20  Darin Adler  <darin@apple.com>
2176
2177         - rolled out my loader change; caused world leak and possibly a plug-in crash
2178
2179 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
2180
2181         Reviewed by Tim H
2182
2183         * loader/mac/LoaderFunctionsMac.mm:
2184         Autorelease the header NSDictionary.
2185         
2186 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
2187
2188         Reviewed by Geoff.
2189
2190         * bindings/js/kjs_window.cpp:
2191         (KJS::Window::timerFired):
2192         Check if the timeout id is still in the table before trying to access it. If it isn't in the table
2193         it has been deleted inside of the execute method.
2194
2195 2006-10-20  Anders Carlsson  <acarlsson@apple.com>
2196
2197         Reviewed by Darin and Geoff.
2198
2199         Remove debugging output.
2200         * xml/xmlhttprequest.cpp:
2201         (WebCore::XMLHttpRequest::send):
2202
2203 2006-10-20  David Harrison  <harrison@apple.com>
2204
2205         Reviewed by John.
2206
2207         <rdar://problem/4792755> REGRESSON: Drag selecting is erratic
2208
2209         No test because it would require autoscrolling, which is not available to layout tests.
2210
2211         * rendering/RenderLayer.cpp:
2212         (WebCore::RenderLayer::autoscroll):
2213         Use hitTest() to find the correct node.
2214         
2215         (WebCore::RenderLayer::hitTest):
2216         Trivial source formatting.
2217
2218 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
2219
2220         Reviewed and landed by Anders.
2221
2222         Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).
2223
2224         * platform/qt/ResourceLoaderManager.cpp:
2225         (WebCore::ResourceLoaderManager::add):
2226
2227 2006-10-20  Darin Adler  <darin@apple.com>
2228
2229         Reviewed by Adele.
2230
2231         - convert WebLoader and its 3 subclasses to C++
2232
2233         Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
2234         there's currently another class with that name).
2235         Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
2236         Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
2237         Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
2238
2239         Converted the classes to C++ and added Objective-C delegates to forward from
2240         API that still requires Objective-C.
2241
2242         Did not yet rename the source files.
2243
2244         * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
2245         classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
2246         classes.
2247
2248         * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
2249
2250         * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
2251
2252         * loader/mac/WebLoader.h:
2253         * loader/mac/WebLoader.mm:
2254         * loader/mac/WebMainResourceLoader.h:
2255         * loader/mac/WebMainResourceLoader.mm:
2256         * loader/mac/WebNetscapePlugInStreamLoader.h:
2257         * loader/mac/WebNetscapePlugInStreamLoader.mm:
2258         * loader/mac/WebSubresourceLoader.h:
2259         * loader/mac/WebSubresourceLoader.mm:
2260         Translate to C++.
2261
2262         * bridge/mac/WebCoreFrameBridge.mm:
2263         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2264         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2265         * loader/mac/WebFrameLoader.h:
2266         * loader/mac/WebFrameLoader.mm:
2267         (isCaseInsensitiveEqual):
2268         (isBackForwardLoadType):
2269         (-[WebFrameLoader dealloc]):
2270         (-[WebFrameLoader addPlugInStreamLoader:]):
2271         (-[WebFrameLoader removePlugInStreamLoader:]):
2272         (-[WebFrameLoader setDefersCallbacks:]):
2273         (-[WebFrameLoader stopLoadingPlugIns]):
2274         (-[WebFrameLoader isLoadingMainResource]):
2275         (-[WebFrameLoader isLoadingSubresources]):
2276         (-[WebFrameLoader isLoadingPlugIns]):
2277         (-[WebFrameLoader stopLoadingSubresources]):
2278         (-[WebFrameLoader addSubresourceLoader:]):
2279         (-[WebFrameLoader removeSubresourceLoader:]):
2280         (-[WebFrameLoader mainResourceData]):
2281         (-[WebFrameLoader releaseMainResourceLoader]):
2282         (-[WebFrameLoader cancelMainResourceLoad]):
2283         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
2284         (-[WebFrameLoader stopLoadingWithError:]):
2285         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2286         (-[WebFrameLoader archiveLoadPendingForLoader:]):
2287         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
2288         * loader/mac/WebFrameLoaderClient.h:
2289         Call the new C++ API.
2290
2291 2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>
2292
2293         Reviewed and landed by Anders.
2294
2295         Offer a way for WebKitPart to be able to detect when
2296         the webpage has been completly loaded (including subresources).
2297
2298         Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
2299         and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.
2300
2301         * CMakeLists.txt:
2302         * platform/qt/FrameQt.cpp:
2303         (WebCore::FrameQt::submitForm):
2304         (WebCore::FrameQt::client):
2305         * platform/qt/FrameQt.h:
2306         * platform/qt/FrameQtClient.cpp:
2307         (WebCore::FrameQtClientDefault::setFrame):
2308         (WebCore::FrameQtClientDefault::openURL):
2309         (WebCore::FrameQtClientDefault::submitForm):
2310         (WebCore::FrameQtClientDefault::checkLoaded):
2311         (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin):
2312         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2313         (WebCore::FrameQtClientDefault::receivedAllData):
2314         * platform/qt/FrameQtClient.h:
2315         * platform/qt/LoaderFunctionsQt.cpp:
2316         (WebCore::CheckCacheObjectStatus):
2317         * platform/qt/PopupMenuQt.cpp:
2318         * platform/qt/ResourceLoaderManager.cpp:
2319         (WebCore::ResourceLoaderManager::ResourceLoaderManager):
2320         (WebCore::ResourceLoaderManager::slotResult):
2321         (WebCore::ResourceLoaderManager::add):
2322         * platform/qt/ResourceLoaderManager.h:
2323         * platform/qt/ResourceLoaderQt.cpp:
2324         (WebCore::ResourceLoader::start):
2325
2326 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
2327
2328         Reviewed by Geoff.
2329
2330         Fix compiler warnings
2331
2332         * platform/ResourceLoaderClient.h:
2333
2334 2006-10-20  Sam Weinig  <sam.weinig@gmail.com>
2335
2336         Reviewed by Mitz.
2337
2338         Win32 build fix and cleanup.
2339
2340         * WebCore.vcproj/WebCore/WebCore.vcproj:
2341         * bridge/win/FrameWin.cpp:
2342         (WebCore::FrameWin::FrameWin):
2343         (WebCore::FrameWin::submitForm):
2344         * page/ResourceRequest.h:
2345         (WebCore::ResourceRequest::addHTTPHeaderField):
2346         * platform/win/TemporaryLinkStubs.cpp:
2347         (WebCore::Slider::~Slider):
2348         (WebCore::Slider::setMinValue):
2349         (WebCore::searchableIndexIntroduction):
2350         (WebCore::findNextSentenceFromIndex):
2351         (WebCore::findSentenceBoundary):
2352         (WebCore::findNextWordFromIndex):
2353         (WebCore::FrameWin::getObjectInstanceForWidget):
2354         (WebCore::FrameWin::getEmbedInstanceForWidget):
2355         (WebCore::FrameWin::runJavaScriptPrompt):
2356         (WebCore::FrameWin::restoreDocumentState):
2357         (WebCore::FrameWin::partClearedInBegin):
2358         (WebCore::FrameWin::createEmptyDocument):
2359         (WebCore::FrameWin::overrideMediaType):
2360         (WebCore::FrameWin::markedTextRange):
2361         (WebCore::FrameWin::passSubframeEventToSubframe):
2362         (WebCore::FrameWin::lastEventIsMouseUp):
2363         (WebCore::FrameWin::addMessageToConsole):
2364         (WebCore::FrameWin::shouldChangeSelection):
2365         (WebCore::FrameWin::respondToChangedSelection):
2366         (WebCore::FrameWin::createFrame):
2367         (WebCore::FrameWin::saveDocumentState):
2368         (WebCore::FrameWin::clearUndoRedoOperations):
2369         (WebCore::FrameWin::incomingReferrer):
2370         (WebCore::FrameWin::markMisspellingsInAdjacentWords):
2371         (WebCore::FrameWin::respondToChangedContents):
2372         (WebCore::FrameWin::handledOnloadEvents):
2373         (WebCore::FrameWin::createPlugin):
2374         (WebCore::FrameWin::objectContentType):
2375         (WebCore::screenDepthPerComponent):
2376         (WebCore::screenIsMonochrome):
2377         (WebCore::historyContains):
2378         (WebCore::submitButtonDefaultLabel):
2379         (WebCore::inputElementAltText):
2380         (WebCore::resetButtonDefaultLabel):
2381         (WebCore::fileButtonChooseFileLabel):
2382         (WebCore::fileButtonNoFileSelectedLabel):
2383         (WebCore::defaultLanguage):
2384         (WebCore::findWordBoundary):
2385         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
2386         (WebCore::PlugInInfoStore::supportsMIMEType):
2387         (WebCore::refreshPlugins):
2388         (WebCore::ResourceLoader::assembleResponseHeaders):
2389         (WebCore::ResourceLoader::retrieveResponseEncoding):
2390         (WebCore::ResourceLoader::startHTTPRequest):
2391         (WebCore::TextField::TextField):
2392         (WebCore::focusRingColor):
2393         (WebCore::setFocusRingColorChangeFunction):
2394         (WebCore::PopupMenu::~PopupMenu):
2395         (WebCore::PopupMenu::hide):
2396
2397 2006-10-20  Rob Buis  <buis@kde.org>
2398
2399         Reviewed by Darin.
2400
2401         http://bugs.webkit.org/show_bug.cgi?id=11303
2402         Path::transform() should be implemented on Qt build
2403
2404         Use QPainterPath API to implement Path::transform.
2405         This fixes svg/custom/clip-path-with-transform.svg on
2406         the qt build.
2407
2408         * platform/qt/PathQt.cpp:
2409         (WebCore::Path::transform):
2410
2411 2006-10-20  Rob Buis  <buis@kde.org>
2412
2413         Reviewed by Mitz.
2414
2415         http://bugs.webkit.org/show_bug.cgi?id=11217
2416         Cleanup svg coding style
2417
2418         Cleanup coding style in svg clipping and painting classes.
2419
2420         * ksvg2/svg/SVGClipPathElement.cpp:
2421         (WebCore::SVGClipPathElement::parseMappedAttribute):
2422         (WebCore::SVGClipPathElement::canvasResource):
2423         * ksvg2/svg/SVGClipPathElement.h:
2424         * ksvg2/svg/SVGMarkerElement.cpp:
2425         (WebCore::SVGMarkerElement::SVGMarkerElement):
2426         (WebCore::SVGMarkerElement::parseMappedAttribute):
2427         (WebCore::SVGMarkerElement::setOrientToAngle):
2428         (WebCore::SVGMarkerElement::canvasResource):
2429         * ksvg2/svg/SVGMarkerElement.h:
2430         (WebCore::SVGMarkerElement::rendererIsNeeded):
2431         * ksvg2/svg/SVGMaskElement.cpp:
2432         (WebCore::SVGMaskElement::SVGMaskElement):
2433         (WebCore::SVGMaskElement::parseMappedAttribute):
2434         (WebCore::SVGMaskElement::drawMaskerContent):
2435         (WebCore::SVGMaskElement::canvasResource):
2436         * ksvg2/svg/SVGMaskElement.h:
2437         (WebCore::SVGMaskElement::rendererIsNeeded):
2438         * ksvg2/svg/SVGPaint.cpp:
2439         (WebCore::SVGPaint::setPaint):
2440         (WebCore::SVGPaint::cssText):
2441         * ksvg2/svg/SVGPaint.h:
2442
2443 2006-10-20  David Hyatt  <hyatt@apple.com>
2444
2445         Make sure to do the code that checks the repeatInterval before the timer has been
2446         deleted. (Duh.)
2447
2448         Reviewed by andersca
2449
2450         * bindings/js/kjs_window.cpp:
2451         (KJS::DOMWindowTimer::setNestingLevel):
2452         (KJS::Window::timerFired):
2453         (KJS::DOMWindowTimer::fired):
2454         * platform/Timer.h:
2455
2456 2006-10-20  David Hyatt  <hyatt@apple.com>
2457
2458         Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
2459         At that point clamp to 10ms to prevent excessive CPU usage.
2460
2461         Reviewed by anders
2462
2463         * bindings/js/kjs_window.cpp:
2464         (KJS::DOMWindowTimer::DOMWindowTimer):
2465         (KJS::DOMWindowTimer::nestingLevel):
2466         (KJS::Window::installTimeout):
2467         (KJS::Window::pauseTimeouts):
2468         (KJS::Window::resumeTimeouts):
2469         (KJS::DOMWindowTimer::fired):
2470         * platform/Timer.h:
2471         (WebCore::TimerBase::startRepeating):
2472         (WebCore::TimerBase::startOneShot):
2473         (WebCore::TimerBase::repeatInterval):
2474         (WebCore::TimerBase::augmentRepeatInterval):
2475         (WebCore::TimerBase::inHeap):
2476         (WebCore::Timer::Timer):
2477         (WebCore::Timer::fired):
2478
2479 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
2480
2481         Build fix
2482
2483         * ksvg2/svg/SVGAElement.cpp:
2484         (WebCore::SVGAElement::defaultEventHandler):
2485
2486 2006-10-19  Steve Falkenburg  <sfalken@apple.com>
2487
2488         Reviewed by Adam.
2489
2490         Use GetKeyState rather than GetAsyncKeyState since we're
2491         calling in these cases in direct response to an event, and want the
2492         key state associated with that event.
2493         
2494         Pass triggering event to url selection method.
2495         
2496         * bridge/mac/FrameMac.h: Add triggeringEvent parameter
2497         * bridge/mac/FrameMac.mm:
2498         (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
2499         * bridge/win/FrameWin.cpp:
2500         (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
2501         * bridge/win/FrameWin.h: Add triggeringEvent parameter
2502         * html/HTMLAnchorElement.cpp:
2503         (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
2504         * page/Frame.cpp:
2505         (WebCore::Frame::changeLocation): Add 0 as triggeringEvent
2506         (WebCore::Frame::urlSelected): Pass through triggeringEvent
2507         * page/Frame.h: Add triggeringEvent parameter to urlSelected methods
2508         * platform/win/KeyEventWin.cpp:
2509         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
2510         * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState
2511         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2512
2513 2006-10-19  David Hyatt  <hyatt@apple.com>
2514
2515         Correct typos from changing "flush" to "prune" using automated search/replace.
2516
2517         Change the cache heuristic for flushing to allow a higher watermark before initiating an
2518         aggressive prune.  This ensures that small cache sizes are no worse in terms of performance
2519         than the old buggy cache.
2520
2521         Make sizes unsigned instead of ints in the cache's APIs and member variables.
2522
2523         * loader/Cache.cpp:
2524         (WebCore::Cache::prune):
2525         (WebCore::Cache::setMaximumSize):
2526         * loader/Cache.h:
2527         (WebCore::Cache::maximumSize):
2528
2529 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
2530
2531         Reviewed by Daddy Hyatt.
2532
2533         Use a real hash map for the headers.
2534
2535         * loader/LoaderFunctions.h:
2536         * loader/mac/LoaderFunctionsMac.mm:
2537         (WebCore::ServeSynchronousRequest):
2538         * platform/ResourceLoader.cpp:
2539         (WebCore::ResourceLoader::setRequestHeaders):
2540         (WebCore::ResourceLoader::requestHeaders):
2541         * platform/ResourceLoader.h:
2542         * platform/ResourceLoaderInternal.h:
2543         * platform/mac/ResourceLoaderMac.mm:
2544         (WebCore::ResourceLoader::start):
2545         * xml/xmlhttprequest.cpp:
2546         (WebCore::XMLHttpRequest::open):
2547         (WebCore::XMLHttpRequest::send):
2548         (WebCore::XMLHttpRequest::setRequestHeader):
2549         (WebCore::XMLHttpRequest::getRequestHeader):
2550         * xml/xmlhttprequest.h:
2551
2552 2006-10-19  Adam Roben  <aroben@apple.com>
2553
2554         Reviewed by Ada.
2555
2556         Pippity-poppity popup tweaks.
2557
2558         * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
2559         * html/HTMLSelectElement.cpp:
2560         (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if
2561         requested and the new index is actually different than the old one.
2562         * platform/IntPoint.h: Added another casting operator.
2563         * platform/PopupMenu.cpp: Removed. The code in here, while
2564         platform-independent, was only useful for the NSPopUpButtonCell
2565         implementation of popup menus, so I've moved it to PopupMenuMac.mm.
2566         * platform/PopupMenu.h: Moved the definition of PopupMenu::create into
2567         the header since it's fairly simple. Made some more methods private now
2568         that we don't have subclasses and virtual methods anymore.
2569         (WebCore::PopupMenu::create):
2570         (WebCore::PopupMenu::menuList):
2571         (WebCore::PopupMenu::itemHeight):
2572         (WebCore::PopupMenu::windowRect):
2573         (WebCore::PopupMenu::listIndexAtPoint):
2574         (WebCore::PopupMenu::focusedIndex):
2575         (WebCore::PopupMenu::setWasClicked):
2576         (WebCore::PopupMenu::wasClicked):
2577         (WebCore::PopupMenu::setScrollOffset):
2578         (WebCore::PopupMenu::scrollOffset):
2579         (WebCore::PopupMenu::wheelDelta):
2580         * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp.
2581         (WebCore::PopupMenu::populate): Call our own clear() method to clear
2582         the menu.
2583         * platform/win/IntPointWin.cpp: New casting operator.
2584         (WebCore::IntPoint::IntPoint):
2585         (WebCore::IntPoint::operator POINTS):
2586
2587 2006-10-19  Adam Roben  <aroben@apple.com>
2588
2589         Reviewed by Darin.
2590
2591         Cleaning up Document::nextFocusNode and Document::previousFocusNode.
2592
2593         * dom/Document.cpp:
2594         (WebCore::Document::nextFocusNode):
2595         (WebCore::Document::previousFocusNode):
2596
2597 2006-10-19  Maciej Stachowiak  <mjs@apple.com>
2598
2599         Reviewed by Geoff.
2600
2601         - implement new ResourceRequest API and fix up code as appropriate
2602         
2603         * bindings/js/kjs_window.cpp:
2604         (KJS::createNewWindow):
2605         (KJS::WindowFunc::callAsFunction):
2606         * bridge/mac/BrowserExtensionMac.mm:
2607         (WebCore::BrowserExtensionMac::createNewWindow):
2608         * bridge/mac/FrameMac.mm:
2609         (WebCore::FrameMac::submitForm):
2610         (WebCore::FrameMac::openURLRequest):
2611         (WebCore::FrameMac::urlSelected):
2612         * bridge/mac/WebCoreFrameBridge.mm:
2613         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
2614         * dom/DOMImplementation.cpp:
2615         (WebCore::addString):
2616         (WebCore::isSVG10Feature):
2617         (WebCore::isSVG11Feature):
2618         * dom/Document.h:
2619         * editing/CommandByName.cpp:
2620         * editing/JSEditor.cpp:
2621         * page/Frame.cpp:
2622         (WebCore::Frame::changeLocation):
2623         (WebCore::Frame::urlSelected):
2624         (WebCore::Frame::requestFrame):
2625         (WebCore::Frame::submitForm):
2626         * page/Frame.h:
2627         * page/FramePrivate.h:
2628         * page/ResourceRequest.h:
2629         (WebCore::):
2630         (WebCore::ResourceRequest::ResourceRequest):
2631         (WebCore::ResourceRequest::cachePolicy):
2632         (WebCore::ResourceRequest::setCachePolicy):
2633         (WebCore::ResourceRequest::timeoutInterval):
2634         (WebCore::ResourceRequest::setTimeoutInterval):
2635         (WebCore::ResourceRequest::mainDocumentURL):
2636         (WebCore::ResourceRequest::setMainDocumentURL):
2637         (WebCore::ResourceRequest::httpMethod):
2638         (WebCore::ResourceRequest::setHTTPMethod):
2639         (WebCore::ResourceRequest::httpHeaderField):
2640         (WebCore::ResourceRequest::setHTTPHeaderField):
2641         (WebCore::ResourceRequest::httpContentType):
2642         (WebCore::ResourceRequest::setHTTPContentType):
2643         (WebCore::ResourceRequest::httpReferrer):
2644         (WebCore::ResourceRequest::setHTTPReferrer):
2645         (WebCore::ResourceRequest::httpUserAgent):
2646         (WebCore::ResourceRequest::setHTTPUserAgent):
2647         (WebCore::ResourceRequest::httpBody):
2648         (WebCore::ResourceRequest::setHTTPBody):
2649         (WebCore::ResourceRequest::addHTTPHeaderField):
2650         * platform/FontCache.cpp:
2651         (WebCore::computeHash):
2652         * platform/StringHash.h:
2653         (WTF::):
2654         * platform/StringImpl.cpp:
2655         (WebCore::equalIgnoringCase):
2656         * rendering/RenderPartObject.cpp:
2657         (WebCore::RenderPartObject::updateWidget):
2658
2659 2006-10-19  Justin Garcia  <justin.garcia@apple.com>
2660
2661         Reviewed by levi
2662         
2663         <rdar://problem/4447885>
2664         API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
2665         
2666         Fixed indent/outdent to only increment the left margin, to match other browsers.
2667         Used blockquote class="webkit-indent-blockquote" to do this.  Mail can now
2668         implement indent/outdent by customizing the appearance of these blockquotes,
2669         instead of using a new API.
2670         
2671         * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
2672         * editing/IndentOutdentCommand.cpp:
2673         (WebCore::indentBlockquoteString): Added.
2674         (WebCore::createIndentBlockquoteElement): Added.
2675         (WebCore::isIndentBlockquote): Added.
2676         (WebCore::isListOrBlockquote): Added.
2677         (WebCore::IndentOutdentCommand::IndentOutdentCommand):
2678         (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed
2679         a bug in the code that added an extra br if the placeholder collapsed upon insertion.
2680         Used the new indentBlockquote checks and enclosing element getters.  
2681         (WebCore::IndentOutdentCommand::indentRegion): Ditto.
2682         (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.  Cleaned up the
2683         logic to pull the selection out of a list a bit.
2684         * editing/htmlediting.cpp:
2685         (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
2686         * editing/htmlediting.h:
2687
2688 2006-10-19  Timothy Hatcher  <timothy@apple.com>
2689
2690         Rolling out the this change since it caused a bad regression:
2691         <rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)
2692
2693 2006-10-12  Adele Peterson  <adele@apple.com>
2694           
2695         Reviewed by Dave Harrison.
2696           
2697         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
2698           
2699         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
2700         Make subtree layouts work for textareas as well as text fields.
2701
2702 2006-10-19  Nikolas Zimmermann  <zimmermann@kde.org>
2703
2704         Reviewed and landed by Anders.
2705
2706         Fix Qt/Linux build.
2707
2708         * CMakeLists.txt:
2709         * loader/Cache.h:
2710         * platform/qt/BrowserExtensionQt.cpp:
2711         * platform/qt/BrowserExtensionQt.h:
2712         * platform/qt/CursorQt.cpp:
2713         (WebCore::pointerCursor):
2714         * platform/qt/LoaderFunctionsQt.cpp:
2715         (WebCore::NumberOfPendingOrLoadingRequests):
2716         (WebCore::CheckCacheObjectStatus):
2717         * platform/qt/ResourceLoaderQt.cpp:
2718         (WebCore::ResourceLoader::retrieveResponseEncoding):
2719         (WebCore::ResourceLoader::receivedResponse):
2720
2721 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
2722
2723         Reviewed by ap.
2724
2725         Win32 build fix.
2726
2727         * bridge/win/FrameWin.cpp:
2728         * bridge/win/FrameWin.h:
2729         * platform/win/TemporaryLinkStubs.cpp:
2730         (WebCore::ResourceLoader::retrieveResponseEncoding):
2731
2732 2006-10-19  Alexey Proskuryakov  <ap@nypop.com>
2733
2734         Reviewed by Mitz.
2735
2736         http://bugs.webkit.org/show_bug.cgi?id=11141
2737         REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element
2738
2739         Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
2740         to document URL. This matches WinIE and partially matches Firefox - although the latter
2741         reports the href as if it were inherited, it still doesn't use it when resolving URIs in
2742         @import rules.
2743
2744         Test: http/tests/uri/css-href.php
2745
2746         * html/HTMLStyleElement.cpp:
2747         (WebCore::HTMLStyleElement::childrenChanged):
2748         * ksvg2/svg/SVGStyleElement.cpp:
2749         (WebCore::SVGStyleElement::childrenChanged):
2750
2751 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
2752
2753         * loader/Cache.cpp:
2754         Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems
2755         with case-sensitive file systems.
2756
2757 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
2758
2759         Reviewed by Maciej, Brady.
2760
2761         Remove "charset" from the ResourceLoader metadata map and use 
2762         a getter function instead. Also, rename charset to encoding in a couple of places.
2763         
2764         * loader/CachedCSSStyleSheet.cpp:
2765         (WebCore::CachedCSSStyleSheet::setEncoding):
2766         * loader/CachedCSSStyleSheet.h:
2767         * loader/CachedResource.h:
2768         (WebCore::CachedResource::setEncoding):
2769         * loader/CachedScript.cpp:
2770         (WebCore::CachedScript::setEncoding):
2771         * loader/CachedScript.h:
2772         * loader/CachedXBLDocument.cpp:
2773         (WebCore::CachedXBLDocument::setEncoding):
2774         * loader/CachedXBLDocument.h:
2775         * loader/CachedXSLStyleSheet.cpp:
2776         (WebCore::CachedXSLStyleSheet::setEncoding):
2777         * loader/CachedXSLStyleSheet.h:
2778         * loader/loader.cpp:
2779         (WebCore::Loader::receivedResponse):
2780         * platform/ResourceLoader.cpp:
2781         (WebCore::ResourceLoader::responseEncoding):
2782         (WebCore::ResourceLoader::queryMetaData):
2783         * platform/ResourceLoader.h:
2784         * platform/ResourceLoaderInternal.h:
2785         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2786         * platform/mac/ResourceLoaderMac.mm:
2787         (WebCore::ResourceLoader::retrieveResponseEncoding):
2788         (WebCore::ResourceLoader::receivedResponse):
2789         * xml/xmlhttprequest.cpp:
2790         (WebCore::XMLHttpRequest::receivedData):
2791
2792 2006-10-19  David Hyatt  <hyatt@apple.com>
2793
2794         Rewrite of the WebCore memory cache.  The following changes have been made (along with many more):
2795
2796         (1) Referenced objects are now also cached.
2797
2798         (2) Pruning of the cache will occur once the cache is both full and in addition
2799         more than half full with unreferenced objects.
2800
2801         (3) The prune is much more aggressive now, since referenced objects are counted when
2802         pruning.  The cache will therefore often prune out every unreferenced object if lots of
2803         windows/tabs are open.
2804
2805         (4) Consolidated the request methods for various types of resources to go through a single
2806         requestResource bottleneck function.
2807
2808         (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
2809         identical.
2810
2811         (6) Changed "object" to "resource" everywhere.
2812
2813         (7) The Cache is now an actual object, obtained via cache().
2814
2815         (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
2816         and enabled.
2817
2818         (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.
2819
2820         (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
2821         in the LRU lists).  Also fixed a bug with the "-SP" part of the algorithm where the access count was
2822         being incorrectly weighted too much due to a math error.
2823
2824         (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
2825         the size of referenced resources.
2826
2827         Reviewed by Maciej, bradee-oh
2828
2829         * bridge/mac/WebCoreCache.mm:
2830         (+[WebCoreCache statistics]):
2831         (+[WebCoreCache empty]):
2832         (+[WebCoreCache setDisabled:]):
2833         * bridge/mac/WebCoreFrameBridge.mm:
2834         (-[WebCoreFrameBridge initMainFrameWithPage:]):
2835         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2836         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2837         * css/CSSImageValue.cpp:
2838         (WebCore::CSSImageValue::image):
2839         * dom/XMLTokenizer.cpp:
2840         (WebCore::openFunc):
2841         * html/HTMLImageLoader.cpp:
2842         (WebCore::HTMLImageLoader::updateFromElement):
2843         * loader/Cache.cpp:
2844         (WebCore::cache):
2845         (WebCore::Cache::Cache):
2846         (WebCore::createResource):
2847         (WebCore::Cache::requestResource):
2848         (WebCore::Cache::resourceForURL):
2849         (WebCore::Cache::prune):
2850         (WebCore::Cache::setMaximumSize):
2851         (WebCore::Cache::remove):
2852         (WebCore::Cache::addDocLoader):
2853         (WebCore::Cache::removeDocLoader):
2854         (WebCore::fastLog2):
2855         (WebCore::Cache::lruListFor):
2856         (WebCore::Cache::removeFromLRUList):
2857         (WebCore::Cache::insertInLRUList):
2858         (WebCore::Cache::resourceAccessed):
2859         (WebCore::Cache::adjustSize):
2860         (WebCore::Cache::getStatistics):
2861         (WebCore::Cache::setDisabled):
2862         * loader/Cache.h:
2863         (WebCore::LRUList::LRUList):
2864         (WebCore::Cache::loader):
2865         (WebCore::Cache::maximumSize):
2866         (WebCore::Cache::disabled):
2867         (WebCore::Cache::addToLiveObjectSize):
2868         (WebCore::Cache::removeFromLiveObjectSize):
2869         (WebCore::Cache::TypeStatistic::TypeStatistic):
2870         * loader/CachedCSSStyleSheet.cpp:
2871         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2872         * loader/CachedCSSStyleSheet.h:
2873         * loader/CachedImage.cpp:
2874         (WebCore::CachedImage::CachedImage):
2875         (WebCore::CachedImage::~CachedImage):
2876         (WebCore::brokenImage):
2877         (WebCore::nullImage):
2878         (WebCore::CachedImage::image):
2879         (WebCore::CachedImage::data):
2880         * loader/CachedImage.h:
2881         (WebCore::CachedImage::stillNeedsLoad):
2882         * loader/CachedResource.cpp:
2883         (WebCore::CachedResource::CachedResource):
2884         (WebCore::CachedResource::~CachedResource):
2885         (WebCore::CachedResource::finish):
2886         (WebCore::CachedResource::setExpireDate):
2887         (WebCore::CachedResource::isExpired):
2888         (WebCore::CachedResource::setRequest):
2889         (WebCore::CachedResource::ref):
2890         (WebCore::CachedResource::deref):
2891         (WebCore::CachedResource::setSize):
2892         * loader/CachedResource.h:
2893         (WebCore::CachedResource::):
2894         (WebCore::CachedResource::setCharset):
2895         (WebCore::CachedResource::url):
2896         (WebCore::CachedResource::type):
2897         (WebCore::CachedResource::referenced):
2898         (WebCore::CachedResource::count):
2899         (WebCore::CachedResource::status):
2900         (WebCore::CachedResource::size):
2901         (WebCore::CachedResource::isLoaded):
2902         (WebCore::CachedResource::setLoading):
2903         (WebCore::CachedResource::isImage):
2904         (WebCore::CachedResource::accessCount):
2905         (WebCore::CachedResource::increaseAccessCount):
2906         (WebCore::CachedResource::setInCache):
2907         (WebCore::CachedResource::inCache):
2908         (WebCore::CachedResource::cachePolicy):
2909         (WebCore::CachedResource::response):
2910         (WebCore::CachedResource::allData):
2911         (WebCore::CachedResource::canDelete):
2912         (WebCore::CachedResource::schedule):
2913         (WebCore::CachedResource::accept):
2914         (WebCore::CachedResource::setAccept):
2915         * loader/CachedScript.cpp:
2916         (WebCore::CachedScript::CachedScript):
2917         * loader/CachedScript.h:
2918         * loader/CachedXBLDocument.cpp:
2919         * loader/CachedXBLDocument.h:
2920         * loader/CachedXSLStyleSheet.cpp:
2921         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2922         * loader/CachedXSLStyleSheet.h:
2923         * loader/DocLoader.cpp:
2924         (WebCore::DocLoader::DocLoader):
2925         (WebCore::DocLoader::~DocLoader):
2926         (WebCore::DocLoader::checkForReload):
2927         (WebCore::DocLoader::requestImage):
2928         (WebCore::DocLoader::requestCSSStyleSheet):
2929         (WebCore::DocLoader::requestScript):
2930         (WebCore::DocLoader::requestXSLStyleSheet):
2931         (WebCore::DocLoader::requestXBLDocument):
2932         (WebCore::DocLoader::requestResource):
2933         (WebCore::DocLoader::setAutoLoadImages):
2934         (WebCore::DocLoader::removeCachedResource):
2935         * loader/DocLoader.h:
2936         (WebCore::DocLoader::cachedResource):
2937         (WebCore::DocLoader::allCachedResources):
2938         (WebCore::DocLoader::autoLoadImages):
2939         (WebCore::DocLoader::cachePolicy):
2940         (WebCore::DocLoader::expireDate):
2941         (WebCore::DocLoader::frame):
2942         (WebCore::DocLoader::doc):
2943         (WebCore::DocLoader::loadInProgress):
2944         * loader/ImageDocument.cpp:
2945         (WebCore::ImageTokenizer::finish):
2946         * loader/loader.cpp:
2947         (WebCore::Loader::receivedAllData):
2948         (WebCore::Loader::cancelRequests):
2949         * loader/mac/LoaderFunctionsMac.mm:
2950         (WebCore::NumberOfPendingOrLoadingRequests):
2951         (WebCore::CheckCacheObjectStatus):
2952         * page/Frame.cpp:
2953         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
2954         (WebCore::Frame::Frame):
2955         (WebCore::Frame::stopLoading):
2956         (WebCore::Frame::setAutoLoadImages):
2957         (WebCore::Frame::autoLoadImages):
2958         (WebCore::Frame::begin):
2959         (WebCore::Frame::checkCompleted):
2960         (WebCore::Frame::reparseConfiguration):
2961         * page/Frame.h:
2962         * xml/XSLTProcessor.cpp:
2963         (WebCore::docLoaderFunc):
2964         * xml/xmlhttprequest.cpp:
2965         (WebCore::XMLHttpRequest::send):
2966
2967 2006-10-18  Maciej Stachowiak  <mjs@apple.com>
2968
2969         Reviewed by Geoff.
2970
2971         - remove vestiges of KXMLCore name (former name of WTF).
2972
2973         * config.h:
2974
2975 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
2976
2977         Reviewed by Beth.
2978         
2979         Fixed http://bugs.webkit.org/show_bug.cgi?id=11222
2980
2981         Some global JS objects lacked references to their property hashtables,
2982         so for-in enumeration didn't work. I added the references, and then removed
2983         a few bogus properties from the tables. The bogus ones got in there through
2984         bit rot.
2985         
2986         We should come up with some solution to these hand-written bindings bugs.
2987         Maybe we could use a script to autogenerate them or something.
2988
2989         * bindings/js/kjs_window.cpp:
2990         (KJS::):
2991         (KJS::History::getValueProperty):
2992
2993 2006-10-18  Adam Roben  <aroben@apple.com>
2994
2995         Reviewed by Brady.
2996
2997         Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
2998         U+000019 (Backtab). This matches our windowsKeyCode for this key
2999         combination.
3000
3001         * platform/mac/KeyEventMac.mm:
3002         (WebCore::keyIdentifierForKeyEvent):
3003
3004 2006-10-18  Steve Falkenburg  <sfalken@apple.com>
3005
3006         Reviewed by Adam, Brady.
3007
3008         Loader tweaks.
3009
3010         * platform/cf/ResourceLoaderCFNet.cpp:
3011         (WebCore::didFinishLoading):
3012         (WebCore::didFail):
3013         (WebCore::didReceiveChallenge):
3014         (WebCore::runLoaderThread):
3015         (WebCore::ResourceLoader::start):
3016         (WebCore::ResourceLoader::cancel):
3017
3018 2006-10-18  Timothy Hatcher  <timothy@apple.com>
3019
3020         Reviewed by Darin.
3021
3022         <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
3023
3024         - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
3025         - Convert more ObjC local statics and member variables to use RetainPtr.
3026         - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
3027
3028         * bindings/objc/DOM.mm:
3029         (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
3030         (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
3031         * bridge/mac/AXObjectCacheMac.mm:
3032         (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
3033         (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
3034         (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
3035         * bridge/mac/WebCoreFrameBridge.mm:
3036         (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
3037         (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
3038         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3039         (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
3040         * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
3041         * platform/cf/RetainPtr.h:
3042         (WTF::::operator): implement a missing operator= template function
3043         * platform/mac/PopupMenuMac.mm:
3044         (WebCore::PopupMenu::PopupMenu): remove nil initialization
3045         (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
3046         (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
3047         (WebCore::PopupMenu::populate): ditto 
3048         (WebCore::PopupMenu::show): ditto
3049         (WebCore::PopupMenu::hide): ditto
3050         (WebCore::PopupMenu::addSeparator): ditto
3051         (WebCore::PopupMenu::addGroupLabel): ditto
3052         (WebCore::PopupMenu::addOption): ditto
3053
3054 2006-10-18  Geoffrey Garen  <ggaren@apple.com>
3055
3056         Reviewed by Adele.
3057
3058         Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
3059         are tracking or menus are down (run loop modes)
3060
3061         I spent a few hours trying to write an automated test, but DRT doesn't
3062         seem to support it. Manual tests attached to related bugs.
3063         
3064         * bridge/mac/FrameMac.mm:
3065         (WebCore::FrameMac::passMouseDownEventToWidget):
3066         * platform/mac/SharedTimerMac.cpp:
3067         (WebCore::setSharedTimerFireTime):
3068
3069 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
3070
3071         Reviewed by Maciej.
3072
3073         More Win32 buildfix.
3074
3075         * bridge/win/FrameWin.h:
3076
3077 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
3078
3079         Reviewed by Mitz
3080
3081         Win32 build fix.
3082
3083         * bridge/win/BrowserExtensionWin.cpp:
3084         (WebCore::BrowserExtensionWin::BrowserExtensionWin):
3085         (WebCore::BrowserExtensionWin::createNewWindow):
3086         * bridge/win/BrowserExtensionWin.h:
3087         * bridge/win/FrameWin.cpp:
3088         (WebCore::FrameWin::createNewWindow):
3089         * bridge/win/FrameWin.h:
3090         * platform/win/CursorWin.cpp:
3091         * platform/win/TemporaryLinkStubs.cpp:
3092         (Image::getHBITMAP):
3093
3094 2006-10-18  Justin Garcia  <justin.garcia@apple.com>
3095
3096         Reviewed by harrison
3097         
3098         <rdar://problem/4784823>
3099         GMail Editor: Hang occurs when removing list styling on text in a rich text message
3100
3101         List removal moves the contents of every list item out of the list it's 
3102         in. When the code tried to move the contents of an empty list item (an li 
3103         with no child nodes, not even a placeholder br), moveParagraph didn't prune 
3104         the li, like it would if the li had a placeholder inside it.  So the list 
3105         removal code went into an infinite loop, continually attempting to de-list 
3106         an empty list item.
3107
3108         * editing/CompositeEditCommand.cpp:
3109         (WebCore::CompositeEditCommand::moveParagraphs): If the selection
3110         to move was empty and in an empty block that doesn't require a 
3111         placeholder to prop itself open (like a bordered div or an li), 
3112         remove it during the move.
3113
3114 2006-10-18  Adele Peterson  <adele@apple.com>
3115
3116         Reviewed by Beth.
3117
3118         - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
3119           REGRESSION (r16975): fast/events/objc-event-api is failing
3120
3121           When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
3122           a call to invalidateClick.  This change moves it back to the sequence that existed before.  This allows
3123           the click count to get properly reset during a selection.
3124
3125         * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
3126
3127 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
3128         
3129         Reviewed by Anders.
3130         
3131         Factored common scaling code into a helper function.
3132
3133         * platform/mac/ScreenMac.mm:
3134         (WebCore::scale):
3135         (WebCore::scaleScreenRectToPageCoordinates):
3136         (WebCore::scalePageRectToScreenCoordinates):
3137
3138 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
3139
3140         Build fixes
3141
3142         * bridge/win/BrowserExtensionWin.cpp:
3143         (WebCore::BrowserExtensionWin::createNewWindow):
3144         * bridge/win/BrowserExtensionWin.h:
3145         * bridge/win/FrameWin.cpp:
3146         (WebCore::FrameWin::createNewWindow):
3147         * bridge/win/FrameWin.h:
3148         * platform/gdk/BrowserExtensionGdk.h:
3149         * platform/gdk/TemporaryLinkStubs.cpp:
3150         (BrowserExtensionGdk::createNewWindow):
3151         * platform/qt/BrowserExtensionQt.cpp:
3152         (WebCore::BrowserExtensionQt::createNewWindow):
3153         * platform/qt/BrowserExtensionQt.h:
3154
3155 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
3156
3157         Reviewed by Anders.
3158         
3159         Renamed WindowArgs to WindowFeatures, and moved it into its own header.
3160         ("Features" is the term of art in IE documentation. "Args" is pirate
3161         talk.)
3162
3163         * WebCore.xcodeproj/project.pbxproj:
3164         * bindings/js/kjs_window.cpp:
3165         (KJS::createNewWindow):
3166         (KJS::showModalDialog):
3167         (KJS::setWindowFeature):
3168         (KJS::parseWindowFeatures):
3169         (KJS::constrainToVisible):
3170         (KJS::WindowFunc::callAsFunction):
3171         * bridge/BrowserExtension.h:
3172         * bridge/WindowFeatures.h: Added.
3173         * bridge/mac/BrowserExtensionMac.h:
3174         * bridge/mac/BrowserExtensionMac.mm:
3175         (WebCore::BrowserExtensionMac::createNewWindow):
3176
3177 2006-10-17  Sam Weinig  <sam.weinig@gmail.com>
3178
3179         Reviewed by Tim H.
3180
3181         Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
3182         Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
3183
3184         - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
3185
3186         - Moves the contents of ksvg/bindings/js/ to bindings/js/.
3187
3188         - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
3189
3190         - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching 
3191           the other CSSValue classing, and allowing the bindings to allocate
3192           appropriately.
3193
3194         - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
3195           generation for Objective-C.
3196
3197         - Assorted style cleanups.
3198
3199         * DerivedSources.make:
3200         * WebCore.xcodeproj/project.pbxproj:
3201         * bindings/objc/DOMCSS.mm:
3202         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3203         * bindings/objc/DOMEvents.mm:
3204         (+[DOMEvent _eventWith:WebCore::]):
3205         * bindings/objc/DOMSVG.h:
3206         * bindings/objc/DOMSVGNumber.mm:
3207         (-[DOMSVGNumber dealloc]):
3208         (-[DOMSVGNumber finalize]):
3209         (-[DOMSVGNumber value]):
3210         (-[DOMSVGNumber setValue:]):
3211         (-[DOMSVGNumber _SVGNumber]):
3212         (-[DOMSVGNumber _initWithFloat:]):
3213         (+[DOMSVGNumber _SVGNumberWith:]):
3214         * bindings/objc/DOMSVGPoint.mm:
3215         (-[DOMSVGPoint dealloc]):
3216         (-[DOMSVGPoint finalize]):
3217         (-[DOMSVGPoint x]):
3218         (-[DOMSVGPoint setX:]):
3219         (-[DOMSVGPoint y]):
3220         (-[DOMSVGPoint setY:]):
3221         (-[DOMSVGPoint WebCore::]):
3222         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
3223         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
3224         * bindings/objc/DOMSVGRect.mm:
3225         (-[DOMSVGRect dealloc]):
3226         (-[DOMSVGRect finalize]):
3227         (-[DOMSVGRect x]):
3228         (-[DOMSVGRect setX:]):
3229         (-[DOMSVGRect y]):
3230         (-[DOMSVGRect setY:]):
3231         (-[DOMSVGRect width]):
3232         (-[DOMSVGRect setWidth:]):
3233         (-[DOMSVGRect height]):
3234         (-[DOMSVGRect setHeight:]):
3235         (-[DOMSVGRect WebCore::]):
3236         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
3237         (+[DOMSVGRect _SVGRectWith:WebCore::]):
3238         * bindings/scripts/CodeGeneratorObjC.pm:
3239         * css/StyleBase.h:
3240         (WebCore::StyleBase::isSVGColor):
3241         (WebCore::StyleBase::isSVGPaint):
3242         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
3243         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
3244         * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
3245         * ksvg2/bindings/js/JSSVGNumber.h: Removed.
3246         * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
3247         * ksvg2/bindings/js/JSSVGPoint.h: Removed.
3248         * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
3249         * ksvg2/bindings/js/JSSVGRect.h: Removed.
3250         * ksvg2/svg/SVGColor.h:
3251         (WebCore::SVGColor::isSVGColor):
3252         * ksvg2/svg/SVGFECompositeElement.idl:
3253         * ksvg2/svg/SVGFEFloodElement.idl:
3254         * ksvg2/svg/SVGLocatable.idl:
3255         * ksvg2/svg/SVGMarkerElement.idl:
3256         * ksvg2/svg/SVGPaint.h:
3257         (WebCore::SVGPaint::isSVGPaint):
3258         * ksvg2/svg/SVGRectElement.idl:
3259         * ksvg2/svg/SVGZoomEvent.idl: Removed.
3260
3261 2006-10-17  David Hyatt  <hyatt@apple.com>
3262
3263         Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
3264         but this patch makes everything work without a root layer being around.
3265
3266         Reviewed by beth
3267
3268         * rendering/RenderBlock.cpp:
3269         (WebCore::RenderBlock::paint):
3270         (WebCore::RenderBlock::paintChildren):
3271         (WebCore::RenderBlock::nodeAtPoint):
3272         * rendering/RenderLayer.cpp:
3273         (WebCore::frameVisibleRect):
3274         (WebCore::RenderLayer::hitTest):
3275         (WebCore::RenderLayer::hitTestLayer):
3276         (WebCore::RenderLayer::intersectsDamageRect):
3277         * rendering/RenderObject.cpp:
3278         (WebCore::RenderObject::setInnerNode):
3279         * rendering/RenderView.cpp:
3280         (WebCore::RenderView::paint):
3281
3282 2006-10-17  David Hyatt  <hyatt@apple.com>
3283
3284         Back out my previous patch to the WebCore memory cache.
3285
3286         * loader/Cache.cpp:
3287         (WebCore::Cache::flush):
3288         (WebCore::Cache::setSize):
3289         (WebCore::Cache::getLRUListFor):
3290         (WebCore::Cache::removeFromLRUList):
3291         (WebCore::Cache::insertInLRUList):
3292         * loader/Cache.h:
3293         * loader/CachedCSSStyleSheet.cpp:
3294         (WebCore::CachedCSSStyleSheet::deref):
3295         * loader/CachedCSSStyleSheet.h:
3296         * loader/CachedImage.cpp:
3297         (WebCore::CachedImage::deref):
3298         * loader/CachedImage.h:
3299         * loader/CachedResource.cpp:
3300         (WebCore::CachedResource::setRequest):
3301         (WebCore::CachedResource::deref):
3302         * loader/CachedResource.h:
3303         (WebCore::CachedResource::allowInLRUList):
3304         * loader/CachedScript.cpp:
3305         (WebCore::CachedScript::deref):
3306         * loader/CachedScript.h:
3307         * loader/CachedXBLDocument.cpp:
3308         (WebCore::CachedXBLDocument::deref):
3309         * loader/CachedXBLDocument.h:
3310         * loader/CachedXSLStyleSheet.cpp:
3311         (WebCore::CachedXSLStyleSheet::deref):
3312         * loader/CachedXSLStyleSheet.h:
3313
3314 2006-10-17  Oliver Hunt  <oliver@apple.com>
3315
3316         Reviewed by Anders.
3317
3318         Make north and east resize cursors use correct image
3319
3320         * platform/win/CursorWin.cpp:
3321         (WebCore::eastResizeCursor):
3322         (WebCore::northResizeCursor):
3323
3324 2006-10-17  Oliver Hunt  <oliver@apple.com>
3325
3326         Reviewed by Brady
3327
3328         Various cursor fixes
3329
3330         * page/FrameView.cpp:
3331         (WebCore::FrameView::handleMouseMoveEvent):
3332         * platform/Cursor.h:
3333         * platform/mac/CursorMac.mm:
3334         (WebCore::pointerCursor):
3335         * platform/win/CursorWin.cpp:
3336         (WebCore::supportsAlphaCursors):
3337         (WebCore::Cursor::Cursor):
3338         (WebCore::Cursor::~Cursor):
3339         (WebCore::pointerCursor):
3340
3341 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
3342
3343         Reviewed by harrison
3344         
3345         <rdar://problem/4776665>
3346         REGRESSION: In Mail, caret is visible when the message body isn't focused
3347
3348         * page/Frame.cpp:
3349         (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
3350         (like when the frame that contains the caret isn't focused) then we don't 
3351         want to paint the caret.  We should eventually move to using a single bool
3352         for caret painting.
3353
3354 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
3355
3356         Reviewed by harrison
3357         
3358         <rdar://problem/4774354>
3359         REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
3360
3361         Functions call recomputCaretRect to see if the caret rect has changed, 
3362         and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
3363         returning false if the caret turned into a range selection or was blown 
3364         away.
3365
3366         * editing/SelectionController.cpp:
3367         (WebCore::SelectionController::recomputeCaretRect): Don't early return if
3368         !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
3369         may now be null.
3370
3371 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
3372
3373         Reviewed by Brady.
3374
3375         BrowserExtension cleanup.
3376         
3377         - Removed unnecessary #include of BrowserExtension in Frame.h, added
3378         #includes to compensate in other files.
3379         
3380         - Removed unused versions of createNewWindow.
3381         
3382         * bindings/js/kjs_window.cpp:
3383         * bridge/BrowserExtension.h:
3384         * bridge/mac/BrowserExtensionMac.h:
3385         * bridge/mac/BrowserExtensionMac.mm:
3386         (WebCore::BrowserExtensionMac::createNewWindow):
3387         * bridge/mac/WebCoreFrameBridge.mm:
3388         * html/HTMLFormElement.cpp:
3389         * loader/mac/LoaderFunctionsMac.mm:
3390         * page/Frame.h:
3391         * page/FramePrivate.h:
3392
3393 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
3394
3395         Reviewed by Adam.
3396         
3397         - Fixed "FIXME: Violates Liskov Substitution principle."
3398         
3399         IFRAME was never a true subclass of FRAME, since they disagreed on a
3400         number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
3401
3402         The fix here is to factor out things common to IFRAME and FRAME into a
3403         common base class, HTMLFrameElementBase.
3404         
3405         I also changed some " *" to "* " and added #includes in files that implicitly
3406         assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
3407
3408 2006-10-16  Justin Garcia  <justin.garcia@apple.com>
3409
3410         Reviewed by sullivan
3411         
3412         <rdar://problem/4776765>
3413         REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
3414
3415         We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
3416         the old caret rect.  It in fact corrects the caret rect for an offset that it 
3417         believes is due to scrolling but which is actually due to a change in selection
3418         without an accompanying layout.  So it returns the new caret rect regardless of
3419         what m_needsLayout is set to.
3420         
3421         * editing/SelectionController.cpp:
3422         (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
3423         adds a one pixel slop to this new function.
3424         (WebCore::SelectionController::caretRepaintRect): Moved this code to
3425         repaintRectForCaret.
3426         (WebCore::SelectionController::recomputeCaretRect): Compare the old
3427         caret rect to the new one that's computed with a fresh layout.  If
3428         they are different, invalidate both repaint rects.
3429
3430 2006-10-17  David Harrison  <harrison@apple.com>
3431
3432         Reviewed by Adele.
3433
3434         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
3435
3436         * bridge/mac/WebCoreAXObject.mm:
3437         (-[WebCoreAXObject isPasswordField]):
3438         New. Checks for input with inputType() of PASSWORD.
3439         
3440         (-[WebCoreAXObject subrole]):
3441         Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
3442         
3443         (-[WebCoreAXObject roleDescription]):
3444         Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
3445         
3446         (-[WebCoreAXObject value]):
3447         Return nil if [self isPasswordField].
3448         
3449         (-[WebCoreAXObject accessibilityAttributeNames]):
3450         Return generic attributes if [self isPasswordField].
3451
3452         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
3453         Return empty array if [self isPasswordField].
3454
3455 2006-10-17  David Hyatt  <hyatt@apple.com>
3456
3457         Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
3458         code so that it will only run if the body still has no renderer.
3459
3460         * dom/Document.cpp:
3461         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
3462
3463 2006-10-17  David Hyatt  <hyatt@apple.com>
3464
3465         Fix a bug where the WebCore memory cache could grow without bound during extended browsing
3466         sessions.
3467
3468         Reviewed by mjs
3469
3470         * loader/Cache.cpp:
3471         (WebCore::Cache::flush):
3472         (WebCore::Cache::setSize):
3473         (WebCore::Cache::getLRUListFor):
3474         (WebCore::Cache::removeFromLRUList):
3475         (WebCore::Cache::insertInLRUList):
3476         * loader/Cache.h:
3477         * loader/CachedCSSStyleSheet.cpp:
3478         * loader/CachedCSSStyleSheet.h:
3479         * loader/CachedImage.cpp:
3480         * loader/CachedImage.h:
3481         * loader/CachedResource.cpp:
3482         (WebCore::CachedResource::setRequest):
3483         (WebCore::CachedResource::deref):
3484         * loader/CachedResource.h:
3485         (WebCore::CachedResource::allowInLRUList):
3486         * loader/CachedScript.cpp:
3487         * loader/CachedScript.h:
3488         * loader/CachedXBLDocument.cpp:
3489         * loader/CachedXBLDocument.h:
3490         * loader/CachedXSLStyleSheet.cpp:
3491         * loader/CachedXSLStyleSheet.h:
3492
3493 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
3494
3495         Reviewed by harrison
3496         
3497         <rdar://problem/3655385>
3498         Editing: -indent: method unimplemented
3499
3500         Added Frame and bridge methods.
3501
3502         * bridge/mac/WebCoreFrameBridge.h:
3503         * bridge/mac/WebCoreFrameBridge.mm:
3504         (-[WebCoreFrameBridge indent]):
3505         (-[WebCoreFrameBridge outdent]):
3506         * page/Frame.cpp:
3507         (WebCore::Frame::indent): 
3508         (WebCore::Frame::outdent):
3509         * page/Frame.h:
3510
3511 2006-10-16  Adam Roben  <aroben@apple.com>
3512
3513         Reviewed by John.
3514
3515         More menulist cleanup/tweaking.
3516
3517         * html/HTMLSelectElement.cpp:
3518         (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
3519         parameter to 'optionIndex' for clarity.
3520         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
3521         items that are not enabled <option> elements when using arrow keys, and
3522         make sure we pass an option index to setSelectedIndex.
3523         * platform/PopupMenu.h:
3524         (WebCore::PopupMenu::setWasClicked): Specify default argument.
3525         * rendering/RenderMenuList.cpp:
3526         (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
3527         option text before setting the control text so that options within
3528         <optgroup>s don't appear indented in the actual control.
3529
3530 2006-10-16  Sam Weinig  <sam.weinig@gmail.com>
3531
3532         Reviewed by Adam.
3533
3534         Win32 build fix.
3535
3536         * WebCore.vcproj/WebCore/WebCore.vcproj:
3537         * bridge/win/BrowserExtensionWin.cpp:
3538         (WebCore::BrowserExtensionWin::createNewWindow):
3539         * bridge/win/FrameWin.cpp:
3540         (WebCore::FrameWin::urlSelected):
3541         (WebCore::FrameWin::submitForm):
3542         (WebCore::FrameWin::createNewWindow):
3543         * bridge/win/FrameWin.h:
3544         * loader/loader.cpp:
3545         (WebCore::Loader::receivedResponse):
3546         * platform/win/GraphicsContextWin.cpp:
3547         (WebCore::GraphicsContext::getWindowsContext):
3548         (WebCore::GraphicsContext::releaseWindowsContext):
3549         * platform/win/TemporaryLinkStubs.cpp:
3550         (FrameWin::openURLRequest):
3551         (WebCore::ServeSynchronousRequest):
3552         (WebCore::CheckIfReloading):
3553         (WebCore::IsResponseURLEqualToURL):
3554         (WebCore::ResponseMIMEType):
3555         (WebCore::ResponseIsMultipart):
3556         (WebCore::CacheObjectExpiresTime):
3557         (CachedResource::setResponse):
3558         (CachedResource::setAllData):
3559         * rendering/RenderThemeWin.cpp:
3560         (WebCore::doneDrawing):
3561         (WebCore::RenderThemeWin::paintButton):
3562         (WebCore::RenderThemeWin::paintTextField):
3563
3564 2006-10-16  David Hyatt  <hyatt@apple.com>
3565
3566         Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
3567         CSS2.1.  In the&nbs