WebCore/ChangeLog

   1 2009-11-19  Steve Block  <steveblock@google.com>
   2
   3         Reviewed by Darin Fisher.
   4
   5         Android port lacks configuration in Platform.h and config.h.
   6         https://bugs.webkit.org/show_bug.cgi?id=31671
   7
   8         Build change only. No new tests possible.
   9
  10         * config.h: Modified. Added Android-specific configuration.
  11
  12 2009-11-20  Roland Steiner  <rolandsteiner@chromium.org>
  13
  14         Reviewed by Darin Adler.
  15
  16         Change default stylesheet to reset text indentation for ruby elements by default.
  17         (https://bugs.webkit.org/show_bug.cgi?id=31247)
  18
  19         Test: fast/ruby/ruby-text-indent.html
  20
  21         * css/html.css: reset text-indent on <ruby> and <rt> elements
  22
  23 2009-11-19  Brian Weinstein  <bweinstein@apple.com>
  24
  25         Reviewed by Darin Adler.
  26
  27         Fixes <http://webkit.org/b/22754>.
  28         Web Inspector: Keyboard shortcut for Element finder.
  29
  30         Use Command + Shift + C as a shortcut for Node Search, to
  31         match the Firebug shortcut to do the same thing.
  32
  33         * inspector/front-end/ElementsPanel.js:
  34         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
  35
  36 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
  37
  38         Reviewed by Darin Adler.
  39
  40         https://bugs.webkit.org/show_bug.cgi?id=31690
  41         Make SocketStreamHandleCFNet work on Windows
  42
  43         * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
  44
  45         * platform/network/ResourceHandle.h: Removed loaderRunLoop().
  46
  47         * platform/network/cf/LoaderRunLoopCF.cpp: Added.
  48         (WebCore::emptyPerform):
  49         (WebCore::runLoaderThread):
  50         (WebCore::loaderRunLoop):
  51         * platform/network/cf/LoaderRunLoopCF.h: Added.
  52         Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
  53         it's needed for more than just resource loading.
  54
  55         * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
  56
  57         * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
  58
  59         * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
  60         main thread.
  61         * platform/network/cf/SocketStreamHandleCFNet.cpp:
  62         (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
  63         inoperable main run loop.
  64
  65         (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
  66         (WebCore::SocketStreamHandle::readStreamCallback):
  67         (WebCore::SocketStreamHandle::writeStreamCallback):
  68         (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
  69         (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
  70         Forward stream events to main thread on Windows.
  71
  72 2009-11-19  Avi Drissman  <avi@chromium.org>
  73
  74         Reviewed by Darin Adler.
  75
  76         Quick style fix.
  77         https://bugs.webkit.org/show_bug.cgi?id=27777
  78
  79         * platform/graphics/cg/PDFDocumentImage.cpp:
  80
  81 2009-11-19  Beth Dakin  <bdakin@apple.com>
  82
  83        Build fix. No review needed.
  84
  85         * platform/chromium/ScrollbarThemeChromium.cpp:
  86         (WebCore::ScrollbarThemeChromium::paintTickmarks):
  87         * rendering/RenderMediaControlsChromium.cpp:
  88         (WebCore::paintMediaButton):
  89
  90 2009-11-19  Beth Dakin  <bdakin@apple.com>
  91
  92        Build fix. No review needed.
  93
  94         * rendering/RenderThemeChromiumSkia.cpp:
  95         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
  96         (WebCore::RenderThemeChromiumSkia::paintRadio):
  97         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
  98         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
  99         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
 100
 101 2009-11-19  Beth Dakin  <bdakin@apple.com>
 102
 103        Build fix. No review needed.
 104
 105         * platform/graphics/qt/StillImageQt.cpp:
 106         (WebCore::StillImage::draw):
 107         * platform/graphics/qt/StillImageQt.h:
 108
 109 2009-11-19  Beth Dakin  <bdakin@apple.com>
 110
 111        Build fix. No review needed.
 112
 113         * rendering/RenderThemeWin.cpp:
 114         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
 115         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
 116         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
 117
 118 2009-11-19  Beth Dakin  <bdakin@apple.com>
 119
 120        Build fix. No review needed.
 121
 122         * plugins/PluginView.cpp:
 123         (WebCore::PluginView::paintMissingPluginIcon):
 124
 125 2009-11-19  Beth Dakin  <bdakin@apple.com>
 126
 127         Build fix. No review needed.
 128
 129         * platform/graphics/win/ImageCGWin.cpp:
 130         (WebCore::BitmapImage::getHBITMAPOfSize):
 131         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
 132
 133 2009-11-19  Beth Dakin  <bdakin@apple.com>
 134
 135         Reviewed by Darin Adler.
 136
 137         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
 138         color-correction work with untagged images
 139
 140         Image's draw(), drawPattern(), and fillWithSolidColor() functions
 141         now take a ColorSpace. A bunch of classes inherit from Image, so
 142         draw() and drawPattern() functions there must also take a
 143         ColorSpace.
 144         * platform/graphics/Image.cpp:
 145         (WebCore::Image::fillWithSolidColor):
 146         (WebCore::Image::drawTiled):
 147         * platform/graphics/Image.h:
 148         * platform/graphics/BitmapImage.h:
 149         * platform/graphics/GeneratedImage.cpp:
 150         (WebCore::GeneratedImage::draw):
 151         (WebCore::GeneratedImage::drawPattern):
 152         * platform/graphics/GeneratedImage.h:
 153         * platform/graphics/cg/PDFDocumentImage.cpp:
 154         (WebCore::PDFDocumentImage::draw):
 155         * platform/graphics/cg/PDFDocumentImage.h:
 156         * svg/graphics/SVGImage.cpp:
 157         (WebCore::SVGImage::draw):
 158         * svg/graphics/SVGImage.h:
 159
 160         All of the drawImage() functions and drawTiled() functions of
 161         GraphicsContext now take a ColorSpace.
 162         * platform/graphics/GraphicsContext.cpp:
 163         (WebCore::GraphicsContext::drawImage):
 164         (WebCore::GraphicsContext::drawTiledImage):
 165         * platform/graphics/GraphicsContext.h:
 166
 167         This is where the actual work is done.
 168         * platform/graphics/cg/ImageCG.cpp:
 169         (WebCore::imageWithColorSpace): New static function that returns a
 170         copy of the given image in the given ColorSpace *IF* we should use
 171         the given ColorSpace. We will ignore the color space if the image
 172         is tagged and return 0.
 173         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
 174         call imageWithColorSpace().
 175         (WebCore::Image::drawPattern): Same.
 176
 177         Attempt to keep all ports building.
 178         * platform/graphics/cairo/ImageCairo.cpp:
 179         (WebCore::BitmapImage::draw):
 180         (WebCore::Image::drawPattern):
 181         * platform/graphics/haiku/ImageHaiku.cpp:
 182         (WebCore::BitmapImage::draw):
 183         (WebCore::Image::drawPattern):
 184         * platform/graphics/qt/ImageQt.cpp:
 185         (WebCore::Image::drawPattern):
 186         (WebCore::BitmapImage::draw):
 187         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
 188         * platform/graphics/skia/ImageSkia.cpp:
 189         (WebCore::Image::drawPattern):
 190         (WebCore::BitmapImage::draw):
 191         (WebCore::BitmapImageSingleFrameSkia::draw):
 192         * platform/graphics/wx/ImageWx.cpp:
 193         (WebCore::BitmapImage::draw):
 194         (WebCore::BitmapImage::drawPattern):
 195
 196         Callers of GraphicsContext's drawImage() and drawTiled() functions
 197         now need to send a ColorSpace.
 198         * html/HTMLCanvasElement.cpp:
 199         (WebCore::HTMLCanvasElement::paint):
 200         * html/canvas/CanvasRenderingContext2D.cpp:
 201         (WebCore::CanvasRenderingContext2D::drawImage):
 202         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
 203         * platform/ScrollView.cpp:
 204         (WebCore::ScrollView::wheelEvent):
 205         * platform/graphics/filters/FEColorMatrix.cpp:
 206         (WebCore::FEColorMatrix::apply):
 207         * platform/graphics/filters/FEComposite.cpp:
 208         (WebCore::FEComposite::apply):
 209         * platform/graphics/filters/SourceGraphic.cpp:
 210         (WebCore::SourceGraphic::apply):
 211         * platform/mac/ScrollbarThemeMac.mm:
 212         (WebCore::ScrollbarThemeMac::paint):
 213         * rendering/RenderBoxModelObject.cpp:
 214         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
 215         (WebCore::RenderBoxModelObject::paintNinePieceImage):
 216         * rendering/RenderImage.cpp:
 217         (WebCore::RenderImage::paintReplaced):
 218         * rendering/RenderLayer.cpp:
 219         (WebCore::RenderLayer::paintResizer):
 220         * rendering/RenderListMarker.cpp:
 221         (WebCore::RenderListMarker::paint):
 222         * rendering/RenderSVGImage.cpp:
 223         (WebCore::RenderSVGImage::paint):
 224         * rendering/RenderWidget.cpp:
 225         (WebCore::RenderWidget::paint):
 226         * svg/graphics/SVGPaintServerPattern.cpp:
 227         (WebCore::SVGPaintServerPattern::setup):
 228         * svg/graphics/SVGResourceFilter.cpp:
 229         (WebCore::SVGResourceFilter::applyFilter):
 230         * svg/graphics/filters/SVGFEMerge.cpp:
 231         (WebCore::FEMerge::apply):
 232         * svg/graphics/filters/SVGFEOffset.cpp:
 233         (WebCore::FEOffset::apply):
 234         * svg/graphics/filters/SVGFETile.cpp:
 235         (WebCore::FETile::apply):
 236
 237 2009-11-19  Avi Drissman  <avi@chromium.org>
 238
 239         Reviewed by Darin Adler.
 240
 241         Properly create a CGImageRef on non-PLATFORM(MAC).
 242         https://bugs.webkit.org/show_bug.cgi?id=27777
 243
 244         * platform/graphics/cg/ImageSourceCG.cpp:
 245         (WebCore::sharedBufferGetBytesAtPosition):
 246         (WebCore::sharedBufferRelease):
 247         (WebCore::ImageSource::setData):
 248         * platform/graphics/cg/ImageSourceCG.h:
 249         * platform/graphics/cg/PDFDocumentImage.cpp:
 250         (WebCore::PDFDocumentImage::dataChanged):
 251
 252 2009-11-19  Oliver Hunt  <oliver@apple.com>
 253
 254         Reviewed by Dave Hyatt.
 255
 256         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
 257         https://bugs.webkit.org/show_bug.cgi?id=31656
 258
 259         Make sure we're a child of the painting root before drawing overflow features.
 260
 261         * manual-tests/user-drag-with-decorations.html: Added.
 262         * rendering/RenderBlock.cpp:
 263         (WebCore::RenderBlock::paint):
 264
 265 2009-11-19  Dmitry Titov  <dimich@chromium.org>
 266
 267         Not reviewed, attempt to fix Chromium build.
 268
 269         * rendering/RenderMediaControlsChromium.cpp:
 270         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
 271
 272 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
 273
 274         Reviewed by Darin Adler.
 275
 276         Do not assert when a high number is used for roman numerals in lists.
 277         https://bugs.webkit.org/show_bug.cgi?id=31652
 278
 279         Test: fast/lists/ol-start-roman.html
 280
 281         * rendering/RenderListMarker.cpp:
 282         (WebCore::toRoman): Increase the char array size.
 283
 284 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 285
 286         Rubber-stamped by Oliver Hunt.
 287
 288         Add translatable strings to cover validationMessage, after
 289         r51172. Already covered by existing test.
 290
 291         * platform/gtk/LocalizedStringsGtk.cpp:
 292         (WebCore::validationMessageValueMissingText):
 293         (WebCore::validationMessageTypeMismatchText):
 294         (WebCore::validationMessagePatternMismatchText):
 295         (WebCore::validationMessageTooLongText):
 296         (WebCore::validationMessageRangeUnderflowText):
 297         (WebCore::validationMessageRangeOverflowText):
 298         (WebCore::validationMessageStepMismatchText):
 299
 300 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 301
 302         Reviewed by Darin Adler.
 303
 304         Remove HAVE(FLOAT_H) guard
 305         https://bugs.webkit.org/show_bug.cgi?id=31661
 306
 307         WebCore has a dependency on float.h, there is
 308         no need to guard float.h.
 309
 310         No new tests as there is no functional change.
 311
 312         * html/HTMLInputElement.cpp: Remove include directive
 313         for float.h as it is included in MathExtras.h already.
 314
 315 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
 316
 317         Reviewed by Pavel Feldman.
 318
 319         Instrumentation should account for painting in compositing layers
 320         https://bugs.webkit.org/show_bug.cgi?id=31674
 321
 322         Add calls to InspectorTimelineAgent for painting into compositing layers,
 323         which is not accounted for in FrameView::paintContents().
 324
 325         * rendering/RenderLayerBacking.cpp:
 326         (WebCore::RenderLayerBacking::paintIntoLayer):
 327         Avoid fetching the FrameView multiple times.
 328
 329         (WebCore::inspectorTimelineAgent):
 330         (WebCore::RenderLayerBacking::paintContents):
 331
 332 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
 333
 334         Reviewed by Dan Bernstein.
 335
 336         <rdar://problem/7035231>
 337         Support closed caption in <video> element
 338
 339         Test: media/media-captions.html
 340
 341         * WebCore.base.exp:
 342         * accessibility/AccessibilityMediaControls.cpp:
 343         (WebCore::AccessibilityMediaControl::controlTypeName):
 344             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
 345
 346         * css/CSSPrimitiveValueMappings.h:
 347         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
 348             Add MediaToggleClosedCaptionsButtonPart.
 349
 350         * css/CSSSelector.cpp:
 351         (WebCore::CSSSelector::extractPseudoType):
 352             Define and match mediaControlsToggleClosedCaptionsButton.
 353
 354         * css/CSSSelector.h:
 355         (WebCore::CSSSelector::):
 356         * css/CSSStyleSelector.cpp:
 357         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
 358             Define and match PseudoMediaControlsToggleClosedCaptions.
 359
 360         * css/CSSValueKeywords.in:
 361             Define and use media-toggle-closed-captions-button.
 362
 363         * css/mediaControls.css:
 364         * css/mediaControlsQuickTime.css:
 365             Add webkit-media-controls-toggle-closed-captions-button.
 366
 367         * html/HTMLMediaElement.cpp:
 368         (WebCore::HTMLMediaElement::HTMLMediaElement):
 369             Initialize m_closedCaptionsVisible.
 370         (WebCore::HTMLMediaElement::loadInternal):
 371             Set m_closedCaptionsVisible to false.
 372         (WebCore::HTMLMediaElement::hasClosedCaptions):
 373         (WebCore::HTMLMediaElement::closedCaptionsVisible):
 374         (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
 375             New, captions internal methods.
 376         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
 377         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
 378         (WebCore::HTMLMediaElement::webkitHasClosedCaptions):
 379             New, captions DOM API.
 380
 381         * html/HTMLMediaElement.h:
 382         * html/HTMLMediaElement.idl:
 383             Declare methods needed for captions API.
 384
 385         * platform/ThemeTypes.h:
 386             Add MediaToggleClosedCaptionsButtonPart.
 387
 388         * platform/android/LocalizedStringsAndroid.cpp:
 389         (WebCore::localizedMediaControlElementString):
 390         (WebCore::localizedMediaControlElementHelpText):
 391         (WebCore::localizedMediaTimeDescription):
 392             Add empty implmentations.
 393
 394         * platform/graphics/MediaPlayer.cpp:
 395         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
 396         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
 397             New, empty implementations of media engine closed caption functions.
 398         (WebCore::MediaPlayer::hasClosedCaptions):
 399         (WebCore::MediaPlayer::setClosedCaptionsVisible):
 400             New, call media engine closed caption functions.
 401
 402         * platform/graphics/MediaPlayer.h:
 403         * platform/graphics/MediaPlayerPrivate.h:
 404         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
 405         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
 406             Declare new media engine methods.
 407
 408         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
 409         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
 410         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
 411         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
 412             New, QTKit implementation of closed caption methods.
 413
 414         * platform/gtk/LocalizedStringsGtk.cpp:
 415         (WebCore::localizedMediaControlElementString):
 416         (WebCore::localizedMediaControlElementHelpText):
 417             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
 418
 419         * platform/mac/WebCoreSystemInterface.h:
 420         * platform/mac/WebCoreSystemInterface.mm:
 421             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
 422
 423         * rendering/MediaControlElements.cpp:
 424         (WebCore::MediaControlInputElement::MediaControlInputElement):
 425             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
 426         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
 427         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
 428         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
 429             New, implement the closed caption toggle button,
 430
 431         * rendering/MediaControlElements.h:
 432             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
 433             declare MediaControlToggleClosedCaptionsButtonElement.
 434
 435         * rendering/RenderMedia.cpp:
 436         (WebCore::RenderMedia::styleDidChange):
 437         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
 438         (WebCore::RenderMedia::createStatusDisplay):
 439         (WebCore::RenderMedia::updateControls):
 440         (WebCore::RenderMedia::forwardEvent):
 441         * rendering/RenderMedia.h:
 442             Deal with m_toggleClosedCaptionsButton.
 443
 444         * rendering/RenderTheme.cpp:
 445         (WebCore::RenderTheme::paint):
 446             Deal with MediaToggleClosedCaptionsButtonPart.
 447
 448         * rendering/RenderTheme.h:
 449         * rendering/RenderThemeMac.h:
 450             Declare paintMediaToggleClosedCaptionsButton.
 451
 452         * rendering/RenderThemeMac.mm:
 453         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
 454             New.
 455         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
 456             Don't render captions toggle button unless we are using the new theme, the
 457             movie has captions, and the movie is in a <video> element since we currently
 458             rely on QTKit to render the captions.
 459
 460         * rendering/style/RenderStyleConstants.h:
 461             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
 462
 463 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
 464
 465         wx build fix. Add missing header.
 466
 467         * platform/wx/LocalizedStringsWx.cpp:
 468
 469 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
 470
 471         Reviewed by Darin Adler.
 472
 473         https://bugs.webkit.org/show_bug.cgi?id=31634
 474         Ignore realm for proxy protection spaces
 475
 476         Only affects WebSocket proxy authentication, cannot be tested in DRT.
 477
 478         * platform/network/ProtectionSpace.cpp:
 479         (WebCore::operator==):
 480         * platform/network/ProtectionSpaceHash.h:
 481         (WebCore::ProtectionSpaceHash::hash):
 482
 483 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
 484
 485         Reviewed by Simon Hausmann.
 486
 487         [Qt] Normalize signal and slot signatures.
 488
 489         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
 490         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
 491
 492 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
 493
 494         Reviewed by Pavel Feldman.
 495
 496         Store cookie domains in the WebInspector object
 497
 498         The cookie domains have been moved from StoragePanel into WebInspector.
 499         Also, the document URLs are now passed inside the WebInspector.addResource()
 500         payload rather than pushed directly from InspectorController.
 501         https://bugs.webkit.org/show_bug.cgi?id=31627
 502
 503         * inspector/InspectorController.cpp:
 504         (WebCore::InspectorController::populateScriptObjects):
 505         (WebCore::InspectorController::didFinishLoading):
 506         * inspector/InspectorFrontend.cpp:
 507         * inspector/InspectorFrontend.h:
 508         * inspector/InspectorResource.cpp:
 509         (WebCore::InspectorResource::createScriptObject):
 510         (WebCore::InspectorResource::updateScriptObject):
 511         * inspector/front-end/StoragePanel.js:
 512         (WebInspector.StoragePanel.prototype.reset):
 513         (WebInspector.StoragePanel.prototype.addCookieDomain):
 514         * inspector/front-end/inspector.js:
 515         (WebInspector.addResource):
 516         (WebInspector.addCookieDomain):
 517         (WebInspector.reset):
 518
 519 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 520
 521         Reviewed by Darin Adler.
 522
 523         Allow custom memory allocation control for the other part of platform directory in WebCore
 524         https://bugs.webkit.org/show_bug.cgi?id=31585
 525
 526         Inherits the following classes from FastAllocBase because these are
 527         instantiated by 'new':
 528
 529         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
 530         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
 531         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
 532         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
 533
 534         Inherits the following classes from Noncopyable because these are
 535         instantiated by 'new' and no need to be copyable:
 536
 537         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
 538         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
 539         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
 540
 541         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
 542         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
 543
 544         * platform/graphics/MediaPlayerPrivate.h:
 545         * platform/graphics/Path.h:
 546         * platform/graphics/qt/FontPlatformData.h:
 547         * platform/graphics/transforms/TransformationMatrix.h:
 548         * platform/image-decoders/ImageDecoder.h:
 549         * platform/network/NetworkStateNotifier.h:
 550         * platform/network/ResourceRequestBase.h:
 551         * platform/qt/CursorQt.cpp:
 552         * platform/text/RegularExpression.h:
 553
 554 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 555
 556         Unreviewed.
 557
 558         [Qt] Build fix for QtWebKit after r51172.
 559
 560         * platform/qt/Localizations.cpp:
 561         (WebCore::validationMessageValueMissingText):
 562         (WebCore::validationMessageTypeMismatchText):
 563         (WebCore::validationMessagePatternMismatchText):
 564         (WebCore::validationMessageTooLongText):
 565         (WebCore::validationMessageRangeUnderflowText):
 566         (WebCore::validationMessageRangeOverflowText):
 567         (WebCore::validationMessageStepMismatchText):
 568
 569 2009-11-18  Dan Bernstein  <mitz@apple.com>
 570
 571         Reviewed by Simon Fraser.
 572
 573         Fixed <rdar://problem/7398987> Assertion failure in
 574         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
 575         enclosed by a transformed layer
 576
 577         Tests: fast/layers/clip-rects-transformed-2.html
 578                fast/layers/clip-rects-transformed.html
 579
 580         * rendering/RenderLayer.cpp:
 581         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
 582         that is either transformed or composited. During painting and hit
 583         testing, when a transformed or composited layer is hit, it becomes the
 584         new root layer, which ultimately gets passed to calculateRects().
 585         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
 586         root layer to calculateRects(), and return the bounding box of the
 587         transformed rectangle.
 588         (WebCore::RenderLayer::selfClipRect): Ditto.
 589         * rendering/RenderLayer.h:
 590
 591 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 592
 593         Reviewed by Kenneth Rohde Christiansen.
 594
 595         [Qt] Remove support for Qt v4.3 or older versions
 596         https://bugs.webkit.org/show_bug.cgi?id=29469
 597
 598         No new tests as there is no change if compiled with
 599         Qt v4.4 or later version.
 600
 601         * WebCore.pro:
 602         * dom/XMLTokenizerQt.cpp:
 603         (WebCore::EntityResolver::resolveUndeclaredEntity):
 604         (WebCore::XMLTokenizer::XMLTokenizer):
 605         (WebCore::XMLTokenizer::~XMLTokenizer):
 606         (WebCore::XMLTokenizer::doWrite):
 607         (WebCore::XMLTokenizer::startDocument):
 608         (WebCore::XMLTokenizer::parseDtd):
 609         * platform/graphics/qt/FontQt.cpp:
 610         * platform/graphics/qt/FontQt43.cpp: Removed.
 611         * platform/graphics/qt/ImageQt.cpp:
 612         * platform/network/ResourceHandleInternal.h:
 613         * platform/network/qt/QNetworkReplyHandler.cpp:
 614         * platform/network/qt/QNetworkReplyHandler.h:
 615         * platform/network/qt/ResourceHandleQt.cpp:
 616         (WebCore::ResourceHandle::start):
 617         (WebCore::ResourceHandle::cancel):
 618         (WebCore::ResourceHandle::loadResourceSynchronously):
 619         (WebCore::ResourceHandle::setDefersLoading):
 620         * platform/network/qt/ResourceRequest.h:
 621         * platform/network/qt/ResourceRequestQt.cpp:
 622         * platform/qt/ClipboardQt.cpp:
 623         (WebCore::ClipboardQt::clearData):
 624         * platform/qt/CookieJarQt.cpp:
 625         (WebCore::cookieJar):
 626         (WebCore::setCookies):
 627         (WebCore::cookies):
 628         (WebCore::cookiesEnabled):
 629         * platform/qt/PlatformKeyboardEventQt.cpp:
 630         (WebCore::keyIdentifierForQtKeyCode):
 631         (WebCore::windowsKeyCodeForKeyEvent):
 632         * platform/text/qt/TextBoundaries.cpp:
 633         * platform/text/qt/TextBreakIteratorQt.cpp:
 634         * plugins/qt/PluginDataQt.cpp:
 635         (WebCore::PluginData::initPlugins):
 636
 637 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
 638
 639         Reviewed by Darin Adler.
 640
 641         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
 642         Support for validationMessage attribute, as per HTML5 specs.
 643
 644         Test: fast/forms/validationMessage.html
 645
 646         * html/HTMLButtonElement.idl: validationMessage attribute
 647         * html/HTMLFieldSetElement.idl: validationMessage attribute
 648         * html/HTMLFormControlElement.cpp:
 649         * html/HTMLFormControlElement.h:
 650         * html/HTMLInputElement.idl: validationMessage attribute
 651         * html/HTMLSelectElement.idl: validationMessage attribute
 652         * html/HTMLTextAreaElement.idl: validationMessage attribute
 653         * html/ValidityState.cpp: new method to retrieve pertinent localized text
 654         * html/ValidityState.h:
 655         * page/mac/WebCoreViewFactory.h:
 656         * platform/LocalizedStrings.h:
 657         * platform/android/LocalizedStringsAndroid.cpp:
 658         * platform/gtk/LocalizedStringsGtk.cpp:
 659         * platform/haiku/LocalizedStringsHaiku.cpp:
 660         * platform/mac/LocalizedStringsMac.mm:
 661         * platform/wx/LocalizedStringsWx.cpp:
 662
 663 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 664
 665         Unreviewed.
 666
 667         Fix a typo. Remove the trailing semicolon
 668         from an include directive after r51137.
 669
 670         No new tests as there is no functional change.
 671
 672         * platform/qt/QWebPageClient.h:
 673
 674 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 675
 676         Unreviewed.
 677
 678         [Qt] Build fix for QtWebKit after r51159.
 679
 680         Include float.h for DBL_MANT_DIG. Not sure why this
 681         is not a problem for other ports.
 682
 683         * html/HTMLInputElement.cpp:
 684
 685 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
 686
 687         Reviewed by Darin Adler.
 688
 689         Bug 31574 -  Crashing bug when removing <ruby> element
 690         (https://bugs.webkit.org/show_bug.cgi?id=31574)
 691
 692         Cause of the bug:
 693         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
 694         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
 695         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
 696         4.) this triggers the special handling of child removal in RenderRubyRun that
 697             causes it to destroy itself
 698         5.) On returning from all this the renderer crashes when accessing a member
 699             or virtual function on this now illegal object.
 700
 701         I therefore added a flag that tracks if the ruby run is being destroyed.
 702         If so, avoid doing the special handling in removeChild that caused this.
 703         It's not the most elegant solution, but the easiest to implement without
 704         touching unrelated code. Also, it's self-documenting.
 705
 706         Test: fast/ruby/ruby-remove.html
 707
 708         * rendering/RenderRubyRun.cpp:
 709         (WebCore::RenderRubyRun::RenderRubyRun):
 710         (WebCore::RenderRubyRun::destroy):
 711         (WebCore::RenderRubyRun::removeChild):
 712         * rendering/RenderRubyRun.h:
 713
 714 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 715
 716         Reviewed by Kenneth Rohde Christiansen.
 717
 718         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
 719         https://bugs.webkit.org/show_bug.cgi?id=31643
 720
 721         No new tests as there is no functional change.
 722
 723         * WebCore.pro:
 724
 725 2009-11-18  Yong Li  <yong.li@torchmobile.com>
 726
 727         Reviewed by Eric Seidel.
 728
 729         Implement TextBoundaries for WINCE port.
 730         https://bugs.webkit.org/show_bug.cgi?id=27371
 731
 732         * platform/text/wince/TextBoundariesWince.cpp: Added.
 733
 734 2009-11-18  Yong Li  <yong.li@torchmobile.com>
 735
 736         Reviewed by Eric Seidel.
 737
 738         Implement TextBreakIterator for WINCE port.
 739         https://bugs.webkit.org/show_bug.cgi?id=27371
 740
 741         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
 742
 743 2009-11-18  Kent Tamura  <tkent@chromium.org>
 744
 745         Reviewed by Darin Adler.
 746
 747         Add support for ValidityState.typeMismatch for the following INPUT types:
 748           date datetime datetime-local month time week
 749         https://bugs.webkit.org/show_bug.cgi?id=31342
 750
 751         Tests: fast/forms/ValidityState-typeMismatch-date.html
 752                fast/forms/ValidityState-typeMismatch-datetime.html
 753                fast/forms/ValidityState-typeMismatch-datetimelocal.html
 754                fast/forms/ValidityState-typeMismatch-month.html
 755                fast/forms/ValidityState-typeMismatch-time.html
 756                fast/forms/ValidityState-typeMismatch-week.html
 757
 758         * html/HTMLInputElement.cpp:
 759         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
 760           validity of the specified type and string using the ISODateTime class.
 761         * html/HTMLInputElement.h:
 762         * html/ValidityState.cpp:
 763         (WebCore::ValidityState::typeMismatch): Check the type validity
 764           for date, datetime, datetime-local, month, time and week with
 765           HTMLInputElemtn::formStringToISODateTime()
 766
 767 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
 768
 769         Reviewed by Oliver Hunt.
 770
 771         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
 772         https://bugs.webkit.org/show_bug.cgi?id=31237
 773
 774         Also speeds up Dromaeo DOM Core tests by 1.31x.
 775
 776         * bindings/js/JSNodeCustom.cpp:
 777         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
 778         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
 779         with wrappers would do marking; there should be only one in the typical case (the root of the
 780         detached subtree).
 781         * dom/Node.cpp:
 782         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
 783         * dom/Node.h: ditto
 784
 785 2009-11-18  Darin Adler  <darin@apple.com>
 786
 787         Reviewed by Sam Weinig.
 788
 789         Get rid of the redundant strokeType and fillType data members on
 790         a GraphicsContext as well as the FillOrStrokeType enum. Use
 791         null pointers instead.
 792
 793         * platform/graphics/GraphicsContext.cpp:
 794         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
 795         and gradient.
 796         (WebCore::GraphicsContext::setFillColor): Ditto.
 797         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
 798         (WebCore::GraphicsContext::setFillPattern): Ditto.
 799         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
 800         (WebCore::GraphicsContext::setFillGradient): Ditto.
 801
 802         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
 803
 804         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 805         (WebCore::setPlatformFill): Use null checks on fillPattern and
 806         fillGraident instead of a switch statement.
 807         (WebCore::setPlatformStroke): Ditto.
 808
 809         * platform/graphics/cg/GraphicsContextCG.cpp:
 810         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
 811         (WebCore::GraphicsContext::applyFillPattern): Ditto.
 812         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
 813         to see if there is a pattern instead of fillType and strokeType.
 814         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
 815         fillPattern, and strokePattern instead of fillType and strokeType.
 816         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
 817         is used in the pattern and gradient case probably erroneously. Moved
 818         gradient code inside an if statement. Streamlined pattern code and
 819         use an if statement. No switch any more.
 820         (WebCore::GraphicsContext::strokePath): Ditto.
 821         (WebCore::GraphicsContext::fillRect): Ditto.
 822         (WebCore::GraphicsContext::strokeRect): Ditto.
 823
 824         * platform/graphics/qt/GraphicsContextQt.cpp:
 825         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
 826         fillGraident instead of a switch statement.
 827         (WebCore::GraphicsContext::strokePath): Ditto.
 828         (WebCore::GraphicsContext::fillRect): Ditto.
 829
 830         * platform/graphics/wince/GraphicsContextWince.cpp:
 831         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
 832         (WebCore::GraphicsContext::fillRect): Ditto.
 833
 834 2009-11-18  Kent Tamura  <tkent@chromium.org>
 835
 836         Reviewed by Darin Adler.
 837
 838         Support for step attribute and ValidityStae.stepMismatch for
 839         type=number and range.  stepMismatch will be false if the
 840         difference between the current value and a multiple of the step
 841         value is very small.
 842
 843         Change the behavior of RenderSlider so that it always has a value
 844         rounded to the step attribute value.
 845
 846         https://bugs.webkit.org/show_bug.cgi?id=31331
 847
 848         Tests: fast/forms/ValidityState-stepMismatch-number.html
 849                fast/forms/ValidityState-stepMismatch-range.html
 850                fast/forms/ValidityState-stepMismatch-unsupported.html
 851                fast/forms/input-step.html
 852
 853         * html/HTMLAttributeNames.in: Add "step".
 854         * html/HTMLInputElement.cpp:
 855         (WebCore::HTMLInputElement::stepMismatch):
 856         (WebCore::HTMLInputElement::getStepParameters):
 857         (WebCore::HTMLInputElement::getAllowedValueStep):
 858         * html/HTMLInputElement.h:
 859         * html/HTMLInputElement.idl: Add "step".
 860         * html/ValidityState.cpp:
 861         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
 862         * html/ValidityState.h:
 863         * rendering/RenderSlider.cpp:
 864         (WebCore::SliderRange::SliderRange):
 865         (WebCore::SliderRange::clampValue):
 866
 867 2009-11-18  Dmitry Titov  <dimich@chromium.org>
 868
 869         Reviewed by Darin Adler.
 870
 871         Need to ASSERT(isMainThread()) in ThreadShared methods.
 872         https://bugs.webkit.org/show_bug.cgi?id=31637
 873
 874         Added ASSERT(IsMainThread()) to all following methods:
 875         * platform/TreeShared.h:
 876         (WebCore::TreeShared::TreeShared):
 877         (WebCore::TreeShared::~TreeShared):
 878         (WebCore::TreeShared::ref):
 879         (WebCore::TreeShared::deref):
 880         (WebCore::TreeShared::setParent):
 881         (WebCore::TreeShared::parent):
 882
 883 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
 884
 885         Reviewed by Eric Seidel.
 886
 887         Add plugin visibility manual test
 888
 889         https://bugs.webkit.org/show_bug.cgi?id=31542
 890
 891         * manual-tests/plugins/windowed.html:
 892         * manual-tests/plugins/windowless.html:
 893
 894 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
 895
 896         Reviewed by Pavel Feldman.
 897
 898         Web Inspector - remember last script displayed in Scripts panel
 899         https://bugs.webkit.org/show_bug.cgi?id=27552
 900
 901         Manual test added
 902
 903         * inspector/front-end/ScriptsPanel.js:
 904         (WebInspector.ScriptsPanel.prototype.showScript):
 905         (WebInspector.ScriptsPanel.prototype.showResource):
 906         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
 907         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
 908         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
 909         (WebInspector.ScriptsPanel.prototype._goBack):
 910         (WebInspector.ScriptsPanel.prototype._goForward):
 911         * manual-tests/inspector/remember-last-script.html: Added.
 912
 913 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 914
 915         Reviewed by Dimitri Glazkov.
 916
 917         Win chromium is slow to draw transparent texts
 918         https://bugs.webkit.org/show_bug.cgi?id=31258
 919
 920         Create bounded transparency layers instead of just clipping.
 921
 922         No new tests because this is just a performance improvement.
 923
 924         * platform/graphics/chromium/FontChromiumWin.cpp:
 925         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
 926
 927 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
 928
 929         Reviewed by Eric Seidel.
 930
 931         [Qt] Add support for displaying deleteButton.
 932         https://bugs.webkit.org/show_bug.cgi?id=31560
 933
 934         Test: LayoutTests/editing/deleting/5408255.html
 935
 936         * WebCore.qrc:
 937         * platform/graphics/qt/ImageQt.cpp:
 938         (loadResourcePixmap):
 939
 940 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
 941
 942         Reviewed by Eric Seidel.
 943
 944         Fix Qt build without JavaScript debugger.
 945
 946         https://bugs.webkit.org/show_bug.cgi?id=31575
 947
 948         * page/Console.idl:
 949
 950 2009-11-18  Daniel Bates  <dbates@webkit.org>
 951
 952         Reviewed by Dave Hyatt.
 953
 954         https://bugs.webkit.org/show_bug.cgi?id=24971
 955         And
 956         <rdar://problem/7138265>
 957
 958         Fixes an issue where setting the height of a table row programmatically
 959         (via JavaScript) causes the table to be improperly rendered because the
 960         height of each row in the table is not recalculated with respect to the
 961         CSS height property.
 962
 963         In particular, programmatically setting the height of some table row causes
 964         the rows of that table to be rendered with a height equal to the minimum
 965         height required by the cells in that row, regardless of any specified cell
 966         heights. Instead, when RenderTableSection::recalcCells is called, the height
 967         of each row should be set to the CSS height property just as we do in
 968         RenderTableSection::addChild.
 969
 970         Test: fast/table/row-height-recalc2.html
 971
 972         * rendering/RenderTableSection.cpp:
 973         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
 974         (WebCore::RenderTableSection::addChild): Moved code that set row height into
 975         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
 976         (WebCore::RenderTableSection::recalcCells): Modified to call
 977         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
 978
 979 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
 980
 981         Reviewed by Darin Adler.
 982
 983         Allow custom memory allocation control for the part of platform directory in WebCore
 984         https://bugs.webkit.org/show_bug.cgi?id=31473
 985
 986         Inherits the following classes from FastAllocBase because these are
 987         instantiated by 'new':
 988
 989         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
 990         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
 991         struct Length                - instantiated at WebCore/platform/Length.cpp:103
 992         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
 993         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
 994         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
 995
 996         Inherits the following classes from Noncopyable because these are
 997         instantiated by 'new' and no need to be copyable:
 998
 999         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
1000         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
1001         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
1002         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
1003
1004         * platform/ContextMenuItem.h:
1005         * platform/DeprecatedPtrList.h:
1006         * platform/DeprecatedPtrListImpl.cpp:
1007         * platform/Length.h:
1008         * platform/PlatformKeyboardEvent.h:
1009         * platform/animation/AnimationList.h:
1010         * platform/graphics/Color.h:
1011         * platform/graphics/FontCache.h:
1012         * platform/graphics/GraphicsContextPrivate.h:
1013         * platform/graphics/MediaPlayer.cpp:
1014
1015 2009-11-18  Daniel Bates  <dbates@webkit.org>
1016
1017         Reviewed by Darin Adler.
1018
1019         https://bugs.webkit.org/show_bug.cgi?id=31186
1020
1021         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
1022         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
1023         These are more descriptive names so as to clear an ambiguity surrounding
1024         their usage. Also, renames associated setters and getters so that they
1025         coincide with the renamed fields.
1026
1027         No functionality was changed. So, no tests were included.
1028
1029         * bindings/objc/DOMHTML.mm:
1030         (-[DOMHTMLInputElement _isEdited]):
1031         (-[DOMHTMLTextAreaElement _isEdited]):
1032         * dom/Document.cpp:
1033         (WebCore::Document::setFocusedNode):
1034         * html/HTMLInputElement.cpp:
1035         (WebCore::HTMLInputElement::defaultEventHandler):
1036         * rendering/RenderTextControl.cpp:
1037         (WebCore::RenderTextControl::RenderTextControl):
1038         (WebCore::RenderTextControl::setInnerTextValue):
1039         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
1040         (WebCore::RenderTextControl::subtreeHasChanged):
1041         * rendering/RenderTextControl.h:
1042         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
1043         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
1044         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
1045         * rendering/RenderTextControlSingleLine.cpp:
1046         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1047         * wml/WMLInputElement.cpp:
1048         (WebCore::WMLInputElement::defaultEventHandler):
1049
1050 2009-11-18  Tony Chang  <tony@chromium.org>
1051
1052         Reviewed by Adam Barth.
1053
1054         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
1055         https://bugs.webkit.org/show_bug.cgi?id=31499
1056
1057         No new tests, just a build cleanup.
1058
1059         * WebCore.gypi:
1060         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
1061         * bindings/v8/custom/V8CustomBinding.h:
1062
1063 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1064
1065         Reviewed by Kevin Ollivier.
1066
1067         Enable wx plugin support using the Windows implementation as a base.
1068
1069         https://bugs.webkit.org/show_bug.cgi?id=31636
1070
1071         * platform/graphics/GraphicsContext.h:
1072         (WebCore::GraphicsContext::inTransparencyLayer):
1073         * platform/graphics/wx/GraphicsContextWx.cpp:
1074         (WebCore::GraphicsContext::getWindowsContext):
1075         (WebCore::GraphicsContext::releaseWindowsContext):
1076         * platform/wx/FileSystemWx.cpp:
1077         (WebCore::unloadModule):
1078         (WebCore::listDirectory):
1079         * plugins/PluginDatabase.cpp:
1080         * plugins/PluginView.cpp:
1081         (WebCore::PluginView::stop):
1082         (WebCore::PluginView::PluginView):
1083         * plugins/PluginView.h:
1084         * plugins/win/PluginViewWin.cpp:
1085         (windowHandleForPageClient):
1086         (WebCore::PluginView::handleMouseEvent):
1087         (WebCore::PluginView::platformStart):
1088         (WebCore::PluginView::snapshot):
1089         * wscript:
1090
1091 2009-11-18  Andrei Popescu  <andreip@google.com>
1092
1093         Reviewed by Dimitri Glazkov.
1094
1095         [Android] Add shared timer and sound utilities to platform/android
1096         https://bugs.webkit.org/show_bug.cgi?id=31584
1097
1098         No new tests required, this is platform specific code.
1099
1100         * platform/android/SharedTimerAndroid.cpp: Added.
1101         (WebCore::setSharedTimerFiredFunction):
1102         (WebCore::setSharedTimerFireTime):
1103         (WebCore::stopSharedTimer):
1104         * platform/android/SoundAndroid.cpp: Added.
1105         (WebCore::systemBeep):
1106
1107 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1108
1109         Reviewed by Timothy Hatcher.
1110
1111         Fix profile tree nodes loss after focus / restore actions.
1112
1113         Focusing on a node is currently implemented via nodes reattaching
1114         with some caching involved. It seems that not all code was updated
1115         to handle this scenario correctly.
1116
1117         https://bugs.webkit.org/show_bug.cgi?id=31553
1118
1119         * inspector/front-end/BottomUpProfileDataGridTree.js:
1120         (WebInspector.BottomUpProfileDataGridNode):
1121         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
1122         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1123         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
1124         * inspector/front-end/DataGrid.js:
1125         (WebInspector.DataGrid.prototype.insertChild):
1126         (WebInspector.DataGridNode.prototype._detach):
1127         (WebInspector.DataGridNode.prototype.savePosition):
1128         (WebInspector.DataGridNode.prototype.restorePosition):
1129         * inspector/front-end/TopDownProfileDataGridTree.js:
1130         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1131         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
1132
1133 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
1134
1135         Reviewed by Kenneth Rohde Christiansen.
1136
1137         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
1138         include it
1139         https://bugs.webkit.org/show_bug.cgi?id=31527
1140
1141         No new tests as this is just a coding style fix that affects the
1142         build of some not yet submitted patches (i.e. for bug 30173).
1143
1144         * platform/qt/QWebPageClient.h:
1145
1146 2009-11-18  Nicolas Roard   <nicolas@roard.com>
1147
1148         Reviewed by Dimitri Glazkov.
1149
1150         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
1151         https://bugs.webkit.org/show_bug.cgi?id=31504
1152
1153         * inspector/InspectorTimelineAgent.h:Added the guard.
1154
1155 2009-11-18  Jens Alfke  <snej@chromium.org>
1156
1157         Build fix to my previous checkin, for Windows Chromium
1158
1159         * svg/SVGAnimatedProperty.h:
1160         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
1161
1162 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
1163
1164         Reviewed by Pavel Feldman.
1165
1166         Web Inspector: Directly Access <head> Instead of Searching for It
1167         https://bugs.webkit.org/show_bug.cgi?id=31641
1168
1169         Changed old access of the head element (document.getElementsByTagName)
1170         to just use the document.head accessor.
1171
1172         * inspector/front-end/FontView.js:
1173         (WebInspector.FontView):
1174         * inspector/front-end/InjectedScript.js:
1175         (InjectedScript.addStyleSelector):
1176         * inspector/front-end/SourceFrame.js:
1177         (WebInspector.SourceFrame.prototype._loaded):
1178         * inspector/front-end/inspector.js:
1179         (windowLoaded):
1180
1181 2009-11-18  Sam Weinig  <sam@webkit.org>
1182
1183         Reviewed by Anders Carlsson.
1184
1185         Fix two Geolocation assertions.
1186
1187         * page/Chrome.cpp:
1188         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
1189         is not called from JS.
1190         * page/Geolocation.cpp:
1191         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
1192         a RefPtr first.
1193
1194 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
1195
1196         Case sensitive file system build fix.
1197
1198         * platform/network/Credential.h: It's not WTF, just wtf.
1199
1200 2009-11-18  Aaron Golden  <agolden@apple.com>
1201
1202         Reviewed by Alexey Proskuryakov.
1203
1204         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
1205         objects and WebCore::Credential objects without losing certificate information.
1206
1207         * platform/network/Credential.cpp:
1208         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
1209         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
1210         (WebCore::Credential::identity): Accessor for the m_identity property
1211         (WebCore::Credential::certificates): Accessor for the m_certificates property
1212         (WebCore::Credential::type):  Accessor for the m_type property
1213         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
1214         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
1215         * platform/network/mac/AuthenticationMac.mm:
1216         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
1217         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
1218
1219 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1220
1221         Reviewed by Eric Seidel.
1222
1223         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
1224         https://bugs.webkit.org/show_bug.cgi?id=31615
1225
1226         * dom/Document.cpp:
1227         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
1228         (WebCore::ScriptExecutionContextTaskTimer::fired):
1229         (WebCore::PerformTaskContext::PerformTaskContext):
1230         (WebCore::performTask):
1231         (WebCore::Document::postTask):
1232         * dom/ScriptExecutionContext.cpp:
1233         * dom/ScriptExecutionContext.h:
1234
1235 2009-11-18  Jens Alfke  <snej@chromium.org>
1236
1237         Reviewed by Darin Adler.
1238
1239         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
1240         by causing the right v8-to-WebCore conversion function to be called for every parameter.
1241         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
1242         To enforce correctness, I added a mode that disables implicit
1243         String-->AtomicString conversions while compiling the generated bindings.
1244         https://bugs.webkit.org/show_bug.cgi?id=31168
1245
1246         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
1247         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
1248         * bindings/v8/V8Binding.h:  Add V8Parameter class.
1249         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
1250         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
1251         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
1252         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
1253         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
1254
1255 2009-11-18  Darin Adler  <darin@apple.com>
1256
1257         Reviewed by Dan Bernstein.
1258
1259         Move FillOrStrokeType out of public header.
1260
1261         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
1262         some years we published Apple changes, sorted forward declarations,
1263         removed FillOrStrokeType enum.
1264         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
1265         to cover some years we published Apple changes, sorted includes,
1266         moved FillOrStrokeType enum here.
1267
1268 2009-11-18  Chris Marrin  <cmarrin@apple.com>
1269
1270         Reviewed by Simon Fraser.
1271
1272         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
1273         https://bugs.webkit.org/show_bug.cgi?id=31601
1274
1275         These are used to debug accelerated compositing layers. I removed
1276         the platform specific code from GraphicsLayerCA.mm and added calls
1277         to GraphicsLayerClient to get it from the higher levels. The values
1278         now get cached in RenderLayerCompositing and are queried from there
1279         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
1280
1281         * WebCore.base.exp:
1282         * page/FrameView.cpp:
1283         (WebCore::FrameView::updateCompositingLayers):
1284         * page/Settings.cpp:
1285         (WebCore::Settings::Settings):
1286         (WebCore::Settings::setShowDebugBorders):
1287         (WebCore::Settings::setShowRepaintCounter):
1288         * page/Settings.h:
1289         (WebCore::Settings::showDebugBorders):
1290         (WebCore::Settings::showRepaintCounter):
1291         * platform/graphics/GraphicsLayer.h:
1292         (WebCore::GraphicsLayer::showDebugBorders):
1293         (WebCore::GraphicsLayer::showRepaintCounter):
1294         * platform/graphics/GraphicsLayerClient.h:
1295         * platform/graphics/mac/GraphicsLayerCA.mm:
1296         * rendering/RenderLayerBacking.cpp:
1297         (WebCore::RenderLayerBacking::showDebugBorders):
1298         (WebCore::RenderLayerBacking::showRepaintCounter):
1299         * rendering/RenderLayerBacking.h:
1300         * rendering/RenderLayerCompositor.cpp:
1301         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
1302         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
1303         * rendering/RenderLayerCompositor.h:
1304         (WebCore::RenderLayerCompositor::showDebugBorders):
1305         (WebCore::RenderLayerCompositor::showRepaintCounter):
1306
1307 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1308
1309         Reviewed by Timothy Hatcher.
1310
1311         Web Inspector: Get rid of metrics and properties sidebars'
1312         flickering.
1313
1314         https://bugs.webkit.org/show_bug.cgi?id=31629
1315
1316         * inspector/front-end/MetricsSidebarPane.js:
1317         * inspector/front-end/PropertiesSidebarPane.js:
1318
1319 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
1320
1321         Reviewed by Pavel Feldman.
1322
1323         Fixes <http://webkit.org/b/31606>.
1324         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
1325
1326         This implements Enter starting editing mode in an editable DataGrid. If the
1327         DataGrid is editable and the user hits return, startEditing the first child
1328         of the selected node. Also refactored some editing functions to take an
1329         event target instead of the event itself, because the functions only needed
1330         the target. Lastly, added had return in editing mode stop propogation, because
1331         when enter was hit to confirm text, it would propagate back to the datagrid
1332         and try to start editing again.
1333
1334         * inspector/front-end/DataGrid.js:
1335         (WebInspector.DataGrid.prototype._ondblclick):
1336         (WebInspector.DataGrid.prototype._startEditing):
1337         (WebInspector.DataGrid.prototype.handleKeyEvent):
1338         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
1339         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
1340         (WebInspector.DataGrid.prototype._clickInDataTable):
1341         * inspector/front-end/inspector.js:
1342         (WebInspector.startEditing.element.handleKeyEvent):
1343         (WebInspector.startEditing):
1344
1345 2009-11-18  Ben Murdoch  <benm@google.com>
1346
1347         Reviewed by Darin Adler.
1348
1349         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
1350         https://bugs.webkit.org/show_bug.cgi?id=31593
1351
1352         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
1353
1354         * html/HTMLAnchorElement.cpp:
1355         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
1356
1357 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1358
1359         Not reviewed. Touch InspectorController so that frontend
1360         JS files are deployed on Windows.
1361
1362         * inspector/InspectorController.cpp:
1363
1364 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
1365
1366         Reviewed by Timothy Hatcher.
1367
1368         Web Inspector: clone timeline records array instead of
1369         copying reference on invalidate all.
1370
1371         https://bugs.webkit.org/show_bug.cgi?id=31596
1372
1373         * inspector/front-end/AbstractTimelinePanel.js:
1374         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
1375
1376 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
1377
1378         Reviewed by Dan Bernstein.
1379
1380         Elements don't drop out of compositing layers when animation ends
1381         https://bugs.webkit.org/show_bug.cgi?id=31613
1382         <rdar://problem/7402913>
1383
1384         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
1385         are compositing anyway for other reasons. Doing so can cause those layers
1386         to stay in compositing mode even after animations finish, because needsToBeComposited()
1387         continues to return true.
1388
1389         No new tests because it's not possible to determine which elements are in
1390         compositing layers from DRT output.
1391
1392         * rendering/RenderLayerCompositor.cpp:
1393         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
1394
1395 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1396
1397         Reviewed by Tor Arne Vestbø.
1398
1399         [Qt] Mac Plugins: Remove null timer
1400
1401         A null timer was used to send mouse move events. Instead, we now use
1402         move events to send nullEvent. This brings down CPU usage by 20-30%.
1403
1404         https://bugs.webkit.org/show_bug.cgi?id=31624
1405
1406         * plugins/PluginView.h:
1407         * plugins/mac/PluginViewMac.cpp:
1408         (WebCore::PluginView::platformStart):
1409         (WebCore::PluginView::handleMouseEvent):
1410
1411 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
1412
1413         Reviewed by Simon Hausmann.
1414
1415         [Qt] WebKit crashes when loading certain SVG images
1416
1417         Check if the familly exist before creating the PlatformData from it.
1418
1419         https://bugs.webkit.org/show_bug.cgi?id=29443
1420
1421         Test: svg/text/text-font-invalid.html
1422
1423         * platform/graphics/qt/FontFallbackListQt.cpp:
1424         (WebCore::FontFallbackList::fontDataAt):
1425
1426 2009-11-17  Nicolas Weber  <thakis@chromium.org>
1427
1428         Reviewed by Darin Fisher.
1429
1430         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
1431         after navigation.
1432         https://bugs.webkit.org/show_bug.cgi?id=31609
1433
1434         * platform/chromium/PopupMenuChromium.cpp:
1435         (WebCore::PopupContainer::showExternal): Set parent for external
1436         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
1437         its parent's client.
1438
1439 2009-11-17  Hayato Ito  <hayato@google.com>
1440
1441         Reviewed by Darin Adler.
1442
1443         Avoid infinite mutual recursion when deeply nested tags are loaded
1444         https://bugs.webkit.org/show_bug.cgi?id=30651
1445
1446         Test: fast/parser/block-nesting-cap-table.html
1447
1448         * html/HTMLParser.cpp:
1449         (WebCore::HTMLParser::parseToken):
1450         (WebCore::tagPriorityOfNode):
1451         (WebCore::HTMLParser::limitBlockDepth):
1452         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
1453         (WebCore::HTMLParser::insertNode):
1454         * html/HTMLParser.h:
1455
1456 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
1457
1458         Rubber-stamped by Alexey Proskuryakov.
1459
1460         Final clean-ups for minor coding standard violations.
1461         https://bugs.webkit.org/show_bug.cgi?id=26102.
1462
1463         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1464
1465 2009-11-17  Johnny Ding  <jnd@chromium.org>
1466
1467         Reviewed by Darin Adler.
1468
1469         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
1470         https://bugs.webkit.org/show_bug.cgi?id=31567
1471
1472         * dom/ScriptElement.cpp:
1473         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
1474
1475 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1476
1477         Reviewed by Timothy Hatcher.
1478
1479         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1480         - Updated DRT to show/close inspector for all tests under /inspector
1481         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1482           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1483         - Removed reload on each inspector test
1484         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1485         inspector for those.
1486         - Reimplemented timeline tests in order to get rid of reload there.
1487         - Moved tests that don't require harness into the fast group.
1488
1489         https://bugs.webkit.org/show_bug.cgi?id=31472
1490
1491         * WebCore.Inspector.exp:
1492         * inspector/front-end/TimelinePanel.js:
1493         (WebInspector.TimelinePanel.prototype._formatRecord):
1494
1495 2009-11-17  Andrei Popescu  <andreip@google.com>
1496
1497         Reviewed by Dimitri Glazkov.
1498
1499         [Android] Android is missing the implementation of the GeolocationService iface.
1500         https://bugs.webkit.org/show_bug.cgi?id=31554
1501
1502         No new tests required as this is platform specific code.
1503
1504         * platform/android/GeolocationServiceAndroid.cpp: Added.
1505         (WebCore::GeolocationServiceAndroid::create):
1506         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
1507         (WebCore::GeolocationServiceAndroid::startUpdating):
1508         (WebCore::GeolocationServiceAndroid::stopUpdating):
1509         (WebCore::GeolocationServiceAndroid::suspend):
1510         (WebCore::GeolocationServiceAndroid::resume):
1511         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
1512         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
1513         (WebCore::GeolocationServiceAndroid::timerFired):
1514         (WebCore::GeolocationServiceAndroid::isPositionMovement):
1515         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
1516         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
1517         * platform/android/GeolocationServiceAndroid.h: Added.
1518         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
1519         (WebCore::GeolocationServiceAndroid::lastPosition):
1520         (WebCore::GeolocationServiceAndroid::lastError):
1521         * platform/android/GeolocationServiceBridge.cpp: Added.
1522         (WebCore::):
1523         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
1524         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
1525         (WebCore::GeolocationServiceBridge::start):
1526         (WebCore::GeolocationServiceBridge::stop):
1527         (WebCore::GeolocationServiceBridge::setEnableGps):
1528         (WebCore::GeolocationServiceBridge::newLocationAvailable):
1529         (WebCore::GeolocationServiceBridge::newErrorAvailable):
1530         (WebCore::GeolocationServiceBridge::toGeoposition):
1531         (WebCore::GeolocationServiceBridge::startJavaImplementation):
1532         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
1533         * platform/android/GeolocationServiceBridge.h: Added.
1534
1535 2009-11-16  Kent Tamura  <tkent@chromium.org>
1536
1537         Unreviewd build fix.
1538
1539         - Fix typo in WebCore.vcproj.
1540         - Intlude limits.h for INT_MAX.
1541         - Enclose with parenthesis to suspress warning.
1542
1543         * WebCore.vcproj/WebCore.vcproj:
1544         * html/ISODateTime.cpp:
1545         (WebCore::ISODateTime::addDay):
1546
1547 2009-11-16  Robin Dunn  <robin@alldunn.com>
1548
1549         Reviewed by Kevin Ollivier.
1550
1551         Make sure wx scrollbar drawing code factors in transforms when switching backends,
1552         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=31570
1555
1556         * platform/wx/ScrollbarThemeWx.cpp:
1557         (WebCore::ScrollbarThemeWx::minimumThumbLength):
1558         (WebCore::ScrollbarThemeWx::splitTrack):
1559         (WebCore::ScrollbarThemeWx::forwardButtonRect):
1560         * platform/wx/ScrollbarThemeWx.h:
1561         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
1562         (wxRenderer_DrawScrollbar):
1563         * platform/wx/wxcode/scrollbar_render.h:
1564         (calcThumbStartAndLength):
1565         * platform/wx/wxcode/win/scrollbar_render.cpp:
1566         (wxRenderer_DrawScrollbar):
1567
1568 2009-11-16  Kent Tamura  <tkent@chromium.org>
1569
1570         Reviewed by David Levin.
1571
1572         Introduce WebCore::ISODateTime class.
1573         https://bugs.webkit.org/show_bug.cgi?id=31340
1574
1575         This class represents a value of date/time types of the HTML5 INPUT
1576         element, and has some parsing methods for ISO 8601.
1577
1578         This change has no tests because the class is not used yet.
1579
1580         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
1581         * WebCore.gypi: ditto.
1582         * WebCore.pro: ditto.
1583         * WebCore.vcproj/WebCore.vcproj: ditto.
1584         * WebCore.xcodeproj/project.pbxproj: ditto.
1585         * WebCoreSources.bkl: ditto.
1586         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
1587         (WebCore::isLeapYear):
1588         (WebCore::maxDayOfMonth):
1589         (WebCore::dayOfWeek):
1590         (WebCore::ISODateTime::maxWeekNumberInYear):
1591         (WebCore::countDigits):
1592         (WebCore::toInt):
1593         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
1594         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
1595         (WebCore::ISODateTime::addMinute): ditto.
1596         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
1597         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
1598         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
1599         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
1600         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
1601         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
1602         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
1603         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
1604         (WebCore::ISODateTime::ISODateTime):
1605         (WebCore::ISODateTime::millisecond):
1606         (WebCore::ISODateTime::second):
1607         (WebCore::ISODateTime::minute):
1608         (WebCore::ISODateTime::hour):
1609         (WebCore::ISODateTime::monthDay):
1610         (WebCore::ISODateTime::month):
1611         (WebCore::ISODateTime::fullYear):
1612         (WebCore::ISODateTime::week):
1613
1614 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1615
1616         Fix a typo in previous commit.
1617
1618         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
1619
1620 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1621
1622         Fix a typo in previous commit.
1623
1624         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1625
1626 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1627
1628         Tiger build fix.
1629
1630         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
1631         differently in Tiger CFNetwork.
1632
1633 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
1634
1635         Reviewed by Darin Fisher.
1636
1637         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
1638
1639         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
1640
1641         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1642
1643         * platform/KURLGoogle.cpp:
1644         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
1645
1646 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1647
1648         Rubber-stamped by Jon Honeycutt.
1649
1650         A better Windows build fix
1651
1652         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
1653         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
1654
1655 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
1656
1657         Reviewed by Darin Adler.
1658
1659         Rename protocolIsValid to isValidProtocol.
1660         https://bugs.webkit.org/show_bug.cgi?id=31503
1661
1662         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
1663
1664         No new tests since no new functionality was introduced.
1665
1666         * html/HTMLAnchorElement.cpp:
1667         (WebCore::HTMLAnchorElement::setProtocol):
1668         * platform/KURL.cpp:
1669         (WebCore::isValidProtocol):
1670         * platform/KURL.h:
1671         * platform/KURLGoogle.cpp:
1672         (WebCore::isValidProtocol):
1673
1674 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1675
1676         Reviewed by Beth Dakin.
1677
1678         AX: aria-labelledby duplicates some of its WAI-ARIA label
1679         https://bugs.webkit.org/show_bug.cgi?id=31565
1680
1681         Test: accessibility/aria-labelledby-overrides-label.html
1682
1683         * accessibility/AccessibilityRenderObject.cpp:
1684         (WebCore::AccessibilityRenderObject::hasTextAlternative):
1685         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
1686         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1687         * accessibility/AccessibilityRenderObject.h:
1688
1689 2009-11-16  Nate Chapin  <japhet@chromium.org>
1690
1691         Reviewed by Darin Fisher.
1692
1693         Handle the case of a null NPObject* in NPN_SetException in
1694         the V8 bindings.  This allow out of process plugins calling
1695         NPN_SetException to just send null instead of sending an
1696         NPObject* that would be an address in a different
1697         process's memory space.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=31561
1700
1701         * bindings/v8/NPV8Object.cpp:
1702         (_NPN_SetException): Allow null NPObject* and just throw a general error.
1703
1704 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1705
1706         Windows build fix.
1707
1708         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
1709         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
1710
1711 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
1712
1713         Reviewed by Kenneth Rohde Christiansen.
1714
1715         [Qt] ASSERT failure while running DRT
1716         https://bugs.webkit.org/show_bug.cgi?id=30978
1717
1718         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
1719         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
1720
1721         * bridge/qt/qt_instance.cpp:
1722         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
1723         * bridge/qt/qt_runtime.h:
1724         (JSC::Bindings::QtRuntimeMethod::createStructure):
1725
1726 2009-11-16  Mark Rowe  <mrowe@apple.com>
1727
1728         Attempt to fix the build.  Land a file that was missing from r51049.
1729
1730         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
1731         (WebCore::setWebGLArrayFromArray):
1732
1733 2009-11-16  Kenneth Russell  <kbr@google.com>
1734
1735         Reviewed by Oliver Hunt.
1736
1737         Update API of WebGLArray and friends
1738         https://bugs.webkit.org/show_bug.cgi?id=31175
1739
1740         * bindings/js/JSWebGLArrayCustom.cpp:
1741         (WebCore::toJS):
1742         * bindings/js/JSWebGLArrayHelper.h: Added.
1743         (WebCore::setWebGLArrayFromArray):
1744         * bindings/js/JSWebGLByteArrayCustom.cpp:
1745         (WebCore::JSWebGLByteArray::set):
1746         * bindings/js/JSWebGLFloatArrayCustom.cpp:
1747         (WebCore::JSWebGLFloatArray::set):
1748         * bindings/js/JSWebGLIntArrayCustom.cpp:
1749         (WebCore::JSWebGLIntArray::set):
1750         * bindings/js/JSWebGLShortArrayCustom.cpp:
1751         (WebCore::JSWebGLShortArray::set):
1752         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
1753         (WebCore::JSWebGLUnsignedByteArray::set):
1754         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
1755         (WebCore::JSWebGLUnsignedIntArray::set):
1756         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
1757         (WebCore::JSWebGLUnsignedShortArray::set):
1758         * bindings/scripts/CodeGeneratorV8.pm:
1759         * bindings/v8/V8DOMWrapper.cpp:
1760         (WebCore::V8DOMWrapper::convertToV8Object):
1761         * bindings/v8/custom/V8CustomBinding.h:
1762         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1763         (WebCore::CALLBACK_FUNC_DECL):
1764         * bindings/v8/custom/V8WebGLArrayCustom.h:
1765         (WebCore::constructWebGLArray):
1766         (WebCore::getWebGLArrayElement):
1767         (WebCore::setWebGLArrayFromArray):
1768         (WebCore::setWebGLArray):
1769         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1770         (WebCore::CALLBACK_FUNC_DECL):
1771         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1772         (WebCore::CALLBACK_FUNC_DECL):
1773         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1774         (WebCore::CALLBACK_FUNC_DECL):
1775         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1776         (WebCore::CALLBACK_FUNC_DECL):
1777         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1778         (WebCore::CALLBACK_FUNC_DECL):
1779         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1780         (WebCore::CALLBACK_FUNC_DECL):
1781         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1782         (WebCore::CALLBACK_FUNC_DECL):
1783         * html/canvas/WebGLArray.cpp:
1784         (WebCore::WebGLArray::WebGLArray):
1785         (WebCore::WebGLArray::~WebGLArray):
1786         (WebCore::WebGLArray::setImpl):
1787         * html/canvas/WebGLArray.h:
1788         (WebCore::WebGLArray::isByteArray):
1789         (WebCore::WebGLArray::isUnsignedByteArray):
1790         (WebCore::WebGLArray::isShortArray):
1791         (WebCore::WebGLArray::isUnsignedShortArray):
1792         (WebCore::WebGLArray::isIntArray):
1793         (WebCore::WebGLArray::isUnsignedIntArray):
1794         (WebCore::WebGLArray::isFloatArray):
1795         (WebCore::WebGLArray::buffer):
1796         (WebCore::WebGLArray::baseAddress):
1797         (WebCore::WebGLArray::byteOffset):
1798         * html/canvas/WebGLArray.idl:
1799         * html/canvas/WebGLArrayBuffer.cpp:
1800         (WebCore::WebGLArrayBuffer::create):
1801         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
1802         (WebCore::WebGLArrayBuffer::data):
1803         (WebCore::WebGLArrayBuffer::byteLength):
1804         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
1805         * html/canvas/WebGLArrayBuffer.h:
1806         * html/canvas/WebGLByteArray.cpp:
1807         (WebCore::WebGLByteArray::create):
1808         (WebCore::WebGLByteArray::byteLength):
1809         (WebCore::WebGLByteArray::slice):
1810         (WebCore::WebGLByteArray::set):
1811         * html/canvas/WebGLByteArray.h:
1812         (WebCore::WebGLByteArray::isByteArray):
1813         (WebCore::WebGLByteArray::data):
1814         (WebCore::WebGLByteArray::set):
1815         (WebCore::WebGLByteArray::get):
1816         (WebCore::WebGLByteArray::item):
1817         * html/canvas/WebGLByteArray.idl:
1818         * html/canvas/WebGLFloatArray.cpp:
1819         (WebCore::WebGLFloatArray::create):
1820         (WebCore::WebGLFloatArray::WebGLFloatArray):
1821         (WebCore::WebGLFloatArray::length):
1822         (WebCore::WebGLFloatArray::byteLength):
1823         (WebCore::WebGLFloatArray::slice):
1824         (WebCore::WebGLFloatArray::set):
1825         * html/canvas/WebGLFloatArray.h:
1826         (WebCore::WebGLFloatArray::isFloatArray):
1827         (WebCore::WebGLFloatArray::data):
1828         (WebCore::WebGLFloatArray::set):
1829         (WebCore::WebGLFloatArray::get):
1830         (WebCore::WebGLFloatArray::item):
1831         * html/canvas/WebGLFloatArray.idl:
1832         * html/canvas/WebGLIntArray.cpp:
1833         (WebCore::WebGLIntArray::create):
1834         (WebCore::WebGLIntArray::WebGLIntArray):
1835         (WebCore::WebGLIntArray::length):
1836         (WebCore::WebGLIntArray::byteLength):
1837         (WebCore::WebGLIntArray::slice):
1838         (WebCore::WebGLIntArray::set):
1839         * html/canvas/WebGLIntArray.h:
1840         (WebCore::WebGLIntArray::isIntArray):
1841         (WebCore::WebGLIntArray::data):
1842         (WebCore::WebGLIntArray::set):
1843         (WebCore::WebGLIntArray::get):
1844         (WebCore::WebGLIntArray::item):
1845         * html/canvas/WebGLIntArray.idl:
1846         * html/canvas/WebGLShortArray.cpp:
1847         (WebCore::WebGLShortArray::create):
1848         (WebCore::WebGLShortArray::WebGLShortArray):
1849         (WebCore::WebGLShortArray::length):
1850         (WebCore::WebGLShortArray::byteLength):
1851         (WebCore::WebGLShortArray::slice):
1852         (WebCore::WebGLShortArray::set):
1853         * html/canvas/WebGLShortArray.h:
1854         (WebCore::WebGLShortArray::isShortArray):
1855         (WebCore::WebGLShortArray::data):
1856         (WebCore::WebGLShortArray::set):
1857         (WebCore::WebGLShortArray::get):
1858         (WebCore::WebGLShortArray::item):
1859         * html/canvas/WebGLShortArray.idl:
1860         * html/canvas/WebGLUnsignedByteArray.cpp:
1861         (WebCore::WebGLUnsignedByteArray::create):
1862         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
1863         (WebCore::WebGLUnsignedByteArray::length):
1864         (WebCore::WebGLUnsignedByteArray::byteLength):
1865         (WebCore::WebGLUnsignedByteArray::slice):
1866         (WebCore::WebGLUnsignedByteArray::set):
1867         * html/canvas/WebGLUnsignedByteArray.h:
1868         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
1869         (WebCore::WebGLUnsignedByteArray::data):
1870         (WebCore::WebGLUnsignedByteArray::set):
1871         (WebCore::WebGLUnsignedByteArray::get):
1872         (WebCore::WebGLUnsignedByteArray::item):
1873         * html/canvas/WebGLUnsignedByteArray.idl:
1874         * html/canvas/WebGLUnsignedIntArray.cpp:
1875         (WebCore::WebGLUnsignedIntArray::create):
1876         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
1877         (WebCore::WebGLUnsignedIntArray::length):
1878         (WebCore::WebGLUnsignedIntArray::byteLength):
1879         (WebCore::WebGLUnsignedIntArray::slice):
1880         (WebCore::WebGLUnsignedIntArray::set):
1881         * html/canvas/WebGLUnsignedIntArray.h:
1882         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
1883         (WebCore::WebGLUnsignedIntArray::data):
1884         (WebCore::WebGLUnsignedIntArray::set):
1885         (WebCore::WebGLUnsignedIntArray::get):
1886         (WebCore::WebGLUnsignedIntArray::item):
1887         * html/canvas/WebGLUnsignedIntArray.idl:
1888         * html/canvas/WebGLUnsignedShortArray.cpp:
1889         (WebCore::WebGLUnsignedShortArray::create):
1890         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
1891         (WebCore::WebGLUnsignedShortArray::length):
1892         (WebCore::WebGLUnsignedShortArray::byteLength):
1893         (WebCore::WebGLUnsignedShortArray::slice):
1894         (WebCore::WebGLUnsignedShortArray::set):
1895         * html/canvas/WebGLUnsignedShortArray.h:
1896         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
1897         (WebCore::WebGLUnsignedShortArray::data):
1898         (WebCore::WebGLUnsignedShortArray::set):
1899         (WebCore::WebGLUnsignedShortArray::get):
1900         (WebCore::WebGLUnsignedShortArray::item):
1901         * html/canvas/WebGLUnsignedShortArray.idl:
1902         * platform/graphics/mac/GraphicsContext3DMac.cpp:
1903         (WebCore::GraphicsContext3D::bufferData):
1904         (WebCore::GraphicsContext3D::bufferSubData):
1905
1906 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1907
1908         Windows build fix.
1909
1910         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
1911
1912 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
1913
1914         Reviewed by Oliver Hunt.
1915
1916         Enable support for webkit-box-shadow in Cairo builds.
1917         https://bugs.webkit.org/show_bug.cgi?id=26102.
1918
1919         Covered by existing fast/box-shadow tests.
1920
1921         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
1922           support for fillRect shadows.
1923
1924 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1925
1926         Windows build fix.
1927
1928         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
1929         in WebKitSupportLibrary.
1930
1931 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
1932
1933         Reviewed by Darin Adler.
1934
1935         https://bugs.webkit.org/show_bug.cgi?id=31494
1936         Add unauthenticated proxy support to SocketStreamHandleCFNet
1937
1938         Cannot be tested in DRT.
1939
1940         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1941         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
1942         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
1943
1944 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1945
1946         Reviewed by Antti Koivisto.
1947
1948         [Qt] Broken back/forward after using ErrorPageExtension to set error page
1949         https://bugs.webkit.org/show_bug.cgi?id=30573
1950
1951         Make FrameLoader::checkLoadCompleteForThisFrame method
1952         to check for any working DocumentLoader instance (through
1953         activeDocumentLoader()) instead of only checking for
1954         'm_provisionalDocumentLoader' in order to decide to if
1955         it is going to reset of not the back and forward history.
1956         after an error page has been loaded.
1957
1958         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
1959
1960         * loader/FrameLoader.cpp:
1961         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1962
1963 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
1964
1965         Reviewed by Darin Adler.
1966
1967         Need to implement ARIA role="directory"
1968         https://bugs.webkit.org/show_bug.cgi?id=31516
1969
1970         Test: platform/mac/accessibility/aria-directory.html
1971
1972         * accessibility/AXObjectCache.cpp:
1973         (WebCore::AXObjectCache::getOrCreate):
1974         * accessibility/AccessibilityList.cpp:
1975         (WebCore::AccessibilityList::isOrderedList):
1976         * accessibility/AccessibilityRenderObject.cpp:
1977         (WebCore::createARIARoleMap):
1978
1979 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
1980
1981         Reviewed by George Staikos.
1982
1983         Compare UChars single unit at a time as opposed to the uint32_t
1984         approach as casting to unaligned addresses may cause a bus failure
1985         on ARMv5 and below. This change replicates the same defines that
1986         exists in AtomicString.cpp
1987
1988         https://bugs.webkit.org/show_bug.cgi?id=31475
1989
1990         * platform/text/StringHash.h:
1991         (WebCore::StringHash::equal):
1992
1993 2009-11-15  Evan Martin  <evan@chromium.org>
1994
1995         Reviewed by Adam Barth.
1996
1997         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=31490
2000
2001         * bindings/v8/V8DOMWrapper.cpp:
2002
2003 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2004
2005         Reviewed by Adam Barth.
2006
2007         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
2008
2009         * platform/haiku/FileChooserHaiku.cpp:
2010
2011 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2012
2013         Reviewed by Adam Barth.
2014
2015         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
2016
2017         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2018         (WebCore::GraphicsContext::setPlatformStrokeColor):
2019
2020 2009-11-15  Daniel Bates  <dbates@webkit.org>
2021
2022         No review, rolling out r50999.
2023         http://trac.webkit.org/changeset/50999
2024
2025         Need to fix some issues in the Windows build. Missed some places where
2026         RenderTextControl::isEdited is called.
2027
2028         * bindings/objc/DOMHTML.mm:
2029         (-[DOMHTMLInputElement _isEdited]):
2030         (-[DOMHTMLTextAreaElement _isEdited]):
2031         * dom/Document.cpp:
2032         (WebCore::Document::setFocusedNode):
2033         * html/HTMLInputElement.cpp:
2034         (WebCore::HTMLInputElement::defaultEventHandler):
2035         * rendering/RenderTextControl.cpp:
2036         (WebCore::RenderTextControl::RenderTextControl):
2037         (WebCore::RenderTextControl::setInnerTextValue):
2038         (WebCore::RenderTextControl::setUserEdited):
2039         (WebCore::RenderTextControl::subtreeHasChanged):
2040         * rendering/RenderTextControl.h:
2041         (WebCore::RenderTextControl::isEdited):
2042         (WebCore::RenderTextControl::setEdited):
2043         (WebCore::RenderTextControl::isUserEdited):
2044         * rendering/RenderTextControlSingleLine.cpp:
2045         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2046         * wml/WMLInputElement.cpp:
2047         (WebCore::WMLInputElement::defaultEventHandler):
2048
2049 2009-11-15  Daniel Bates  <dbates@webkit.org>
2050
2051         Reviewed by Darin Adler.
2052
2053         https://bugs.webkit.org/show_bug.cgi?id=31186
2054
2055         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2056         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2057         These are more descriptive names so as to clear an ambiguity surrounding
2058         their usage. Also, renames associated setters and getters so that they
2059         coincide with the renamed fields.
2060
2061         No functionality was changed. So, no tests were included.
2062
2063         * bindings/objc/DOMHTML.mm:
2064         (-[DOMHTMLInputElement _isEdited]):
2065         (-[DOMHTMLTextAreaElement _isEdited]):
2066         * dom/Document.cpp:
2067         (WebCore::Document::setFocusedNode):
2068         * html/HTMLInputElement.cpp:
2069         (WebCore::HTMLInputElement::defaultEventHandler):
2070         * rendering/RenderTextControl.cpp:
2071         (WebCore::RenderTextControl::RenderTextControl):
2072         (WebCore::RenderTextControl::setInnerTextValue):
2073         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2074         (WebCore::RenderTextControl::subtreeHasChanged):
2075         * rendering/RenderTextControl.h:
2076         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2077         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2078         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2079         * rendering/RenderTextControlSingleLine.cpp:
2080         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2081         * wml/WMLInputElement.cpp:
2082         (WebCore::WMLInputElement::defaultEventHandler):
2083
2084 2009-11-14  Adele Peterson  <adele@apple.com>
2085
2086         Reviewed by Dan Bernstein.
2087
2088         Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
2089
2090         Test: fast/overflow/line-clamp.html
2091
2092         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
2093         * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
2094         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
2095
2096         * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
2097         Use the line count value if available.  Otherwise, convert the percentage to the line count, as we did before.  Also,
2098         if there is anchor as the last child box, still allow adding the ellipsis.
2099
2100         * rendering/RenderLayer.cpp:
2101         (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
2102         (WebCore::RenderLayer::scrollRectToVisible): ditto.
2103
2104         * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
2105         * rendering/style/LineClampValue.h: Added.
2106         (WebCore::LineClampValue::LineClampValue):
2107         (WebCore::LineClampValue::value):
2108         (WebCore::LineClampValue::isPercentage):
2109         (WebCore::LineClampValue::isNone):
2110         (WebCore::LineClampValue::operator==):
2111         (WebCore::LineClampValue::operator!=):
2112         * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
2113
2114         * rendering/style/RenderStyle.h: Use LineClampValue.
2115         (WebCore::InheritedFlags::lineClamp):
2116         (WebCore::InheritedFlags::setLineClamp):
2117         (WebCore::InheritedFlags::initialLineClamp):
2118         * rendering/style/StyleRareNonInheritedData.h:
2119
2120 2009-11-14  Eric Carlson  <eric.carlson@apple.com>
2121
2122         Reviewed by Oliver Hunt.
2123
2124         <rdar://problem/7287487>
2125         Do not use QuickTime version to detect media controller theme
2126
2127         * WebCore.base.exp: Export wkMediaControllerThemeAvailable
2128         * platform/mac/WebCoreSystemInterface.h: Ditto.
2129         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2130
2131         * rendering/RenderThemeMac.mm:
2132         (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
2133         QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2134
2135 2009-11-14  Kent Tamura  <tkent@chromium.org>
2136
2137         Reviewed by Darin Adler.
2138
2139         - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
2140           They have no dedicated UI and no type validation for now.
2141         - Clean up setInputType() and formControlType() of HTMLInputElement.
2142         https://bugs.webkit.org/show_bug.cgi?id=29004
2143
2144         Test: fast/forms/input-type-change3.html
2145
2146         * html/HTMLInputElement.cpp:
2147         (WebCore::HTMLInputElement::valueMissing):
2148         (WebCore::HTMLInputElement::patternMismatch):
2149         (WebCore::HTMLInputElement::tooLong):
2150         (WebCore::createTypeMap):
2151         (WebCore::HTMLInputElement::setInputType):
2152         (WebCore::createFormControlTypes):
2153         (WebCore::HTMLInputElement::formControlType):
2154         (WebCore::HTMLInputElement::saveFormControlState):
2155         (WebCore::HTMLInputElement::restoreFormControlState):
2156         (WebCore::HTMLInputElement::accessKeyAction):
2157         (WebCore::HTMLInputElement::rendererIsNeeded):
2158         (WebCore::HTMLInputElement::createRenderer):
2159         (WebCore::HTMLInputElement::appendFormData):
2160         (WebCore::HTMLInputElement::isTextField):
2161         (WebCore::HTMLInputElement::valueWithDefault):
2162         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2163         (WebCore::HTMLInputElement::defaultEventHandler):
2164         (WebCore::HTMLInputElement::isRequiredFormControl):
2165         (WebCore::HTMLInputElement::dataList):
2166         * html/HTMLInputElement.h:
2167         (WebCore::HTMLInputElement::):
2168
2169 2009-11-13  Chris Fleizach  <cfleizach@apple.com>
2170
2171         Reviewed by Darin Adler.
2172
2173         WAI-ARIA: checkbox does not determine its label from text content
2174         https://bugs.webkit.org/show_bug.cgi?id=31456
2175
2176         Test: accessibility/aria-checkbox-text.html
2177
2178         * accessibility/AccessibilityRenderObject.cpp:
2179         (WebCore::AccessibilityRenderObject::title):
2180
2181 2009-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2182
2183         Unreviewed, build fix.
2184
2185         [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
2186         This is just enough changes to unbreak the port.
2187
2188         * bindings/v8/ScriptController.cpp:
2189         (WebCore::mainThreadNormalWorld):
2190         * bindings/v8/V8Proxy.cpp:
2191         (WebCore::V8Proxy::initContextIfNeeded):
2192         * loader/FrameLoaderClient.h:
2193
2194 2009-11-13  Aaron Boodman  <aa@chromium.org>
2195
2196         Unreviewed fix for Chromium build.
2197
2198         * loader/FrameLoaderClient.h:
2199         (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2200         Provide an empty implementation of this method because I don't know
2201         what it is supposed to do on Chromium.
2202
2203 2009-11-13  Aaron Boodman  <aa@chromium.org>
2204
2205         Unreviewed fix for Chromium build.
2206
2207         * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
2208         public, as Chromium's V8Proxy calls it.
2209
2210 2009-11-13  Aaron Boodman  <aa@chromium.org>
2211
2212         Unreviewed fix to Chromium build.
2213
2214         * bindings/v8/ScriptController.cpp:
2215         (WebCore::ScriptController::getAllWorlds):
2216
2217 2009-11-13  Aaron Boodman  <aa@chromium.org>
2218
2219         Unreviewed fix for Chromium build.
2220
2221         * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
2222
2223 2009-11-13  Adam Barth  <abarth@webkit.org>
2224
2225         Unreviewed partial build fix for Chromium.  Should fix failure #4.
2226
2227         * bindings/v8/ScriptController.cpp:
2228         (WebCore::ScriptController::getAllWorlds):
2229         * bindings/v8/ScriptController.h:
2230         * bindings/v8/V8Proxy.cpp:
2231         (WebCore::V8Proxy::initContextIfNeeded):
2232
2233 2009-11-13  Adam Barth  <abarth@webkit.org>
2234
2235         Unreviewed partial build fix for Chromium.
2236
2237         * bindings/v8/ScriptController.h:
2238         (WebCore::ScriptController::getAllWorlds):
2239
2240 2009-11-13  Eric Seidel  <eric@webkit.org>
2241
2242         No review, build fix only.
2243
2244         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
2245
2246         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2247         https://bugs.webkit.org/show_bug.cgi?id=31468
2248
2249         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
2250         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
2251
2252 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
2253
2254         Reviewed by Dmitry Titov.
2255
2256         LocalStorage quota should include key sizes in its count
2257         https://bugs.webkit.org/show_bug.cgi?id=31451
2258
2259         * storage/StorageMap.cpp:
2260         (WebCore::StorageMap::setItem):
2261             Count keys in the quota when adding a new item.
2262         (WebCore::StorageMap::removeItem):
2263             Remove the key's length from the quota if we're removing the item.
2264         (WebCore::StorageMap::importItem):
2265             Assume that we're adding things for the first time.
2266             Count keys in the quota.
2267
2268 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
2269
2270         Reviewed by Eric Seidel.
2271
2272         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
2273         https://bugs.webkit.org/show_bug.cgi?id=31468
2274
2275         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
2276         by removing the direct ICU dependency and replacing it
2277         with WTF functions and WebCore's own TextBreakIterator
2278         abstractions.
2279
2280         * GNUmakefile.am:
2281         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2282         * platform/text/TextBoundaries.cpp: Added.
2283         (WebCore::findNextWordFromIndex):
2284         (WebCore::findWordBoundary):
2285         * platform/text/TextBoundariesICU.cpp: Removed.
2286         * platform/text/TextBreakIterator.h:
2287         * platform/text/TextBreakIteratorICU.cpp:
2288         (WebCore::textBreakLast):
2289         (WebCore::textBreakPrevious):
2290
2291 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
2292
2293         Reviewed by Darin Adler.
2294
2295         WebCore::externalRepresentation should update layout before getting render object
2296         https://bugs.webkit.org/show_bug.cgi?id=31459
2297
2298         * rendering/RenderTreeAsText.cpp:
2299         (WebCore::externalRepresentation):
2300
2301 2009-11-13  Adam Roben  <aroben@apple.com>
2302
2303         Tell FrameLoaderClient when window objects in isolated worlds are
2304         cleared
2305
2306         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2307         window objects in isolated worlds are cleared
2308
2309         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
2310
2311         Reviewed by Dave Hyatt.
2312
2313         * bindings/js/JSDOMBinding.h:
2314         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
2315         worlds in m_worldSet to the passed-in Vector.
2316
2317         * bindings/js/ScriptController.cpp:
2318         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
2319         WebCoreJSClientData.
2320         (WebCore::ScriptController::initScript): Changed to call
2321         FrameLoader::dispatchDidClearWindowObjectInWorld.
2322
2323         * bindings/js/ScriptController.h: Added getAllWorlds.
2324
2325         * loader/EmptyClients.h:
2326         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2327         Updated for FrameLoaderClient change.
2328
2329         * loader/FrameLoader.cpp:
2330         (WebCore::FrameLoader::receivedFirstData):
2331         (WebCore::FrameLoader::begin):
2332         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
2333
2334         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
2335         Added. Retrieves all the worlds, then calls through to
2336         dispatchDidClearWindowObjectInWorld for each one.
2337         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
2338         dispatchWindowObjectAvailable. Calls up to the client, then, if the
2339         world is the mainThreadNormalWorld(), tells the Inspector about it,
2340         too.
2341
2342         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
2343         dispatchDidClearWindowObjectInWorld. Added
2344         dispatchDidClearWindowObjectsInAllWorlds.
2345
2346         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
2347         dispatchDidClearWindowObjectForWorld.
2348
2349 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2350
2351         Reviewed by Dimitri Glazkov.
2352
2353         [V8] Fix SVG context assignment for pod types.
2354         https://bugs.webkit.org/show_bug.cgi?id=31497
2355
2356         I broke this in r50958.
2357
2358         Tested by svg/custom/viewport-update2.svg.
2359
2360         * bindings/scripts/CodeGeneratorV8.pm:
2361
2362 2009-11-13  Andrei Popescu  <andreip@google.com>
2363
2364         Reviewed by Dmitry Titov.
2365
2366         Bring the platform/android files inline with Android 2.0
2367         https://bugs.webkit.org/show_bug.cgi?id=31423
2368
2369         No new tests required: these are all Android-specific files.
2370
2371         * platform/android/ClipboardAndroid.cpp:
2372         (WebCore::ClipboardAndroid::files):
2373         * platform/android/ClipboardAndroid.h:
2374         * platform/android/FileChooserAndroid.cpp:
2375         (WebCore::FileChooser::basenameForWidth):
2376         (WebCore::fileButtonChooseFileLabel):
2377         * platform/android/KeyEventAndroid.cpp:
2378         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2379         * platform/android/LocalizedStringsAndroid.cpp:
2380         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
2381         (WebCore::contextMenuItemTagDownloadLinkToDisk):
2382         (WebCore::contextMenuItemTagCopyLinkToClipboard):
2383         (WebCore::contextMenuItemTagOpenImageInNewWindow):
2384         (WebCore::contextMenuItemTagDownloadImageToDisk):
2385         (WebCore::contextMenuItemTagCopyImageToClipboard):
2386         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
2387         (WebCore::contextMenuItemTagCopy):
2388         (WebCore::contextMenuItemTagGoBack):
2389         (WebCore::contextMenuItemTagGoForward):
2390         (WebCore::contextMenuItemTagStop):
2391         (WebCore::contextMenuItemTagReload):
2392         (WebCore::contextMenuItemTagCut):
2393         (WebCore::contextMenuItemTagPaste):
2394         (WebCore::contextMenuItemTagNoGuessesFound):
2395         (WebCore::contextMenuItemTagIgnoreSpelling):
2396         (WebCore::contextMenuItemTagLearnSpelling):
2397         (WebCore::contextMenuItemTagSearchWeb):
2398         (WebCore::contextMenuItemTagLookUpInDictionary):
2399         (WebCore::contextMenuItemTagOpenLink):
2400         (WebCore::contextMenuItemTagIgnoreGrammar):
2401         (WebCore::contextMenuItemTagSpellingMenu):
2402         (WebCore::contextMenuItemTagShowSpellingPanel):
2403         (WebCore::contextMenuItemTagCheckSpelling):
2404         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
2405         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
2406         (WebCore::contextMenuItemTagFontMenu):
2407         (WebCore::contextMenuItemTagBold):
2408         (WebCore::contextMenuItemTagItalic):
2409         (WebCore::contextMenuItemTagUnderline):
2410         (WebCore::contextMenuItemTagOutline):
2411         (WebCore::contextMenuItemTagWritingDirectionMenu):
2412         (WebCore::contextMenuItemTagTextDirectionMenu):
2413         (WebCore::contextMenuItemTagDefaultDirection):
2414         (WebCore::contextMenuItemTagLeftToRight):
2415         (WebCore::contextMenuItemTagRightToLeft):
2416         (WebCore::mediaElementLoadingStateText):
2417         (WebCore::mediaElementLiveBroadcastStateText):
2418         (WebCore::searchableIndexIntroduction):
2419         (WebCore::resetButtonDefaultLabel):
2420         (WebCore::submitButtonDefaultLabel):
2421         (WebCore::inputElementAltText):
2422         * platform/android/RenderThemeAndroid.cpp:
2423         (WebCore::RenderTheme::themeForPage):
2424         (WebCore::RenderThemeAndroid::baselinePosition):
2425         (WebCore::RenderThemeAndroid::paintButton):
2426         (WebCore::adjustMenuListStyleCommon):
2427         (WebCore::RenderThemeAndroid::paintCombo):
2428         * platform/android/ScreenAndroid.cpp:
2429         * platform/android/ScrollViewAndroid.cpp:
2430         (WebCore::ScrollView::platformOffscreenContentRectangle):
2431         * platform/android/TemporaryLinkStubs.cpp:
2432         (JSC::Bindings::dispatchJNICall):
2433         * platform/android/WidgetAndroid.cpp:
2434         (WebCore::Widget::setFrameRect):
2435
2436 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
2437
2438         Reviewed by Eric Seidel.
2439
2440         Added macros for USERINCLUDE paths within symbian blocks
2441         to guarantee inclusion of respective header files from local path
2442         first (to avoid clashes with same names of header files in system include path).
2443
2444         * WebCore.pro:
2445
2446 2009-11-13  Hironori Bono  <hbono@chromium.org>
2447
2448         Reviewed by Oliver Hunt.
2449
2450         Implement composition events introduced in DOM Level 3.
2451         This change adds a new IDL which defines the composition events, adds a class which
2452         implements the composition events, and sends the composition events according to
2453         the specification.
2454         https://bugs.webkit.org/show_bug.cgi?id=26310
2455
2456         Test: fast/events/ime-composition-events-001.html
2457
2458         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
2459         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
2460         * WebCore.gypi: ditto.
2461         * WebCore.pro: ditto
2462         * WebCore.vcproj/WebCore.vcproj: ditto.
2463         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
2464         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
2465         * bindings/js/JSEventCustom.cpp:
2466         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
2467         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
2468         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
2469         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
2470         (WebCore::V8DOMWrapper::convertEventToV8Object):
2471         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
2472         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
2473         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
2474         (WebCore::CompositionEvent::CompositionEvent):
2475         (WebCore::CompositionEvent::~CompositionEvent):
2476         (WebCore::CompositionEvent::initCompositionEvent):
2477         (WebCore::CompositionEvent::isCompositionEvent):
2478         * dom/CompositionEvent.h: Declares the CompositionEvent class.
2479         (WebCore::CompositionEvent::create):
2480         (WebCore::CompositionEvent::data):
2481         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
2482         * dom/Event.cpp:
2483         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
2484         * dom/Event.h:
2485         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
2486         * editing/Editor.cpp:
2487         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
2488         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
2489
2490 2009-11-13  Jens Alfke  <snej@chromium.org>
2491
2492         Reviewed by Dimitri Glazkov.
2493
2494         Fix a link error in unofficial GCC 4.4 builds on Linux.
2495         https://bugs.webkit.org/show_bug.cgi?id=31477
2496
2497         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
2498
2499 2009-11-13  Eric Seidel  <eric@webkit.org>
2500
2501         No review, build fix only.
2502
2503         Fix Debug build after http://trac.webkit.org/changeset/50960.
2504
2505         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
2506         https://bugs.webkit.org/show_bug.cgi?id=31213
2507
2508         * rendering/CounterNode.cpp:
2509         (WebCore::showTreeAndMark):
2510         * rendering/RenderCounter.cpp:
2511         (WebCore::destroyCounterNodeChildren):
2512
2513 2009-11-13  Dirk Schulze  <krit@webkit.org>
2514
2515         Reviewed by Gustavo Noronha.
2516
2517         [CAIRO] shadow support for Canvas and SVG
2518         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2519
2520         We currently fill a path with solid color instead of filling
2521         a clipping path. This causes problems on some composite operators,
2522         since Cairo modifies the area outside the path.
2523         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
2524
2525         Thanks to Benjamin Otte for tracking the bug down.
2526
2527         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2528         (WebCore::setPlatformFill):
2529
2530 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2531
2532         Reviewed by Dimitri Glazkov.
2533
2534         Adding Chromium's DatabaseTracker implementation.
2535
2536         https://bugs.webkit.org/show_bug.cgi?id=31440
2537
2538         * WebCore.gyp/WebCore.gyp:
2539         * WebCore.gypi:
2540         * storage/DatabaseTracker.h:
2541         * storage/chromium/DatabaseTrackerChromium.cpp:
2542         (WebCore::DatabaseTracker::fullPathForDatabase):
2543         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
2544         * storage/chromium/QuotaTracker.cpp:
2545         (WebCore::QuotaTracker::updateDatabaseSize):
2546         * storage/chromium/QuotaTracker.h:
2547
2548 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
2549
2550         Reviewed by Darin Adler.
2551
2552         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
2553         https://bugs.webkit.org/show_bug.cgi?id=31213
2554         Added tree navigation methods that permit full implementation of CSS2.1
2555         counter feature without using recursion proportional to the counter
2556         tree depth.
2557         No new tests because I did not find any bug that is fixed by this
2558         commit yet, this just reduces the size of the patch for 11031 and
2559         helps respond to some concerns regarding that patch.
2560
2561         * rendering/CounterNode.cpp:
2562         (WebCore::CounterNode::CounterNode):
2563
2564         (WebCore::CounterNode::nextInPreOrderAfterChildren):
2565         (WebCore::CounterNode::nextInPreOrder):
2566         Added to support non-recursive tree traversal necessary for
2567         efficient full implementation of CSS2.1 counters.
2568
2569         (WebCore::CounterNode::lastDescendant):
2570         (WebCore::CounterNode::previousInPreOrder):
2571         Moved this methods such that they occupy a place similar to that of
2572         identically named methods on the render tree. This allows for their
2573         broader use needed in full implementation of CSS2.1 counters.
2574
2575         (WebCore::CounterNode::resetRenderer):
2576         (WebCore::CounterNode::resetRenderers):
2577         (WebCore::CounterNode::recount):
2578         (WebCore::CounterNode::insertAfter):
2579         (WebCore::CounterNode::removeChild):
2580         Changed such that insertion/removal of a counter, triggers not only
2581         recalculation of PrefixWidths, but also reassesment of values in
2582         counter nodes. This is the basis full implementation of CSS2.1
2583         counters. It does not change current behavior by much because of
2584         changes needed to the recalculation algorithm, but those are comming
2585         in the patch for 11031.
2586         (WebCore::showTreeAndMark):
2587         * rendering/CounterNode.h:
2588         * rendering/RenderCounter.cpp:
2589         (WebCore::counter):
2590         Only changed argument type to prepare for implementation of Darin
2591         Adler's recommendation for the patch to 11031.
2592
2593         (WebCore::RenderCounter::invalidate):
2594         (WebCore::destroyCounterNodeChildren):
2595         (WebCore::RenderCounter::destroyCounterNodes):
2596         * rendering/RenderCounter.h:
2597         * rendering/RenderObjectChildList.cpp:
2598         (WebCore::invalidateCountersInContainer):
2599         (WebCore::RenderObjectChildList::invalidateCounters):
2600         * rendering/RenderObjectChildList.h:
2601         Added the ability to restrict invalidation to counters with a given
2602         identifier.
2603         Also invalidated counters that are on the child container itself
2604         which were missed by the previous algorithm, but were a valid case.
2605
2606 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
2607
2608         Reviewed by Dimitri Glazkov.
2609
2610         [V8] Protect SVG animated properties from destruction in bindings.
2611         https://bugs.webkit.org/show_bug.cgi?id=31474
2612
2613         See http://crbug.com/26719.
2614
2615         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
2616         under Valgrind.
2617
2618         Made sure we keep a reference to SVG properties while setting a
2619         context:
2620         * bindings/scripts/CodeGeneratorV8.pm:
2621         * bindings/v8/V8Proxy.h:
2622         (WebCore::V8Proxy::withSVGContext):
2623
2624 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
2625
2626         Reviewed by Alexey Proskuryakov.
2627
2628         [CAIRO] shadow support for Canvas and SVG.
2629         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2630
2631         Incorporate Benjamin Otte's recommendations to avoid
2632         a buffer overrun, and small performance improvement.
2633
2634         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2635         (WebCore::copyContextProperties): Correctly size output
2636          storage for cairo_get_dash to avoid buffer overrun.
2637         (WebCore::drawPathShadow): Prefer cairo_fill_extents
2638          to slower cairo_stroke_extents when not drawing shadows.
2639
2640 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
2641
2642         Reviewed by Dimitri Glazkov.
2643
2644         Do not register Chromium's HTML5 DB VFS as the default
2645         VFS. Otherwise, other sqlite DB users in the same process will
2646         stop working.
2647
2648         https://bugs.webkit.org/show_bug.cgi?id=31462
2649
2650         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
2651         (WebCore::SQLiteFileSystem::openDatabase):
2652         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
2653         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
2654         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
2655         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
2656
2657 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2658
2659         Windows build fix
2660
2661         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2662         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
2663         avoiding a sign mismatch warning.
2664
2665 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
2666
2667         Release build fix.
2668
2669         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2670         (WebCore::SocketStreamHandle::readStreamCallback):
2671         (WebCore::SocketStreamHandle::writeStreamCallback):
2672         Use ASSERT_UNUSED for unused stream parameter.
2673
2674 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
2675
2676         Reviewed by Darin Adler.
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=31441
2679         Implement SocketStreamHandleCFNet
2680
2681         Existing WebSocket tests now pass on Mac. No proxy support yet.
2682
2683         * platform/network/SocketStreamHandleClient.h:
2684         * platform/network/cf/SocketStreamHandle.h:
2685         (WebCore::SocketStreamHandle::shouldUseSSL):
2686         (WebCore::SocketStreamHandle::refAuthenticationClient):
2687         (WebCore::SocketStreamHandle::derefAuthenticationClient):
2688         (WebCore::SocketStreamHandle::):
2689         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2690         (WebCore::SocketStreamHandle::SocketStreamHandle):
2691         (WebCore::SocketStreamHandle::chooseProxy):
2692         (WebCore::SocketStreamHandle::createStreams):
2693         (WebCore::SocketStreamHandle::copyCFStreamDescription):
2694         (WebCore::SocketStreamHandle::readStreamCallback):
2695         (WebCore::SocketStreamHandle::writeStreamCallback):
2696         (WebCore::SocketStreamHandle::~SocketStreamHandle):
2697         (WebCore::SocketStreamHandle::platformSend):
2698         (WebCore::SocketStreamHandle::platformClose):
2699         (WebCore::SocketStreamHandle::receivedCredential):
2700         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
2701         (WebCore::SocketStreamHandle::receivedCancellation):
2702
2703 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2704
2705         Reviewed by Timothy Hatcher.
2706
2707         Web Inspector: preload status bar button glyphs
2708         in order to prevent them from flickering (take 2).
2709
2710         https://bugs.webkit.org/show_bug.cgi?id=31439
2711
2712         * inspector/front-end/inspector.js:
2713         (preloadImages):
2714
2715 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
2716
2717         Reviewed by Adam Barth.
2718
2719         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
2720         Rolling back r50890.
2721
2722         https://bugs.webkit.org/show_bug.cgi?id=31467
2723
2724         * bindings/v8/V8Proxy.cpp:
2725         (WebCore::V8Proxy::canAccessPrivate):
2726
2727 2009-11-13  Dirk Schulze  <krit@webkit.org>
2728
2729         Reviewed by Gustavo Noronha.
2730
2731         [CAIRO] shadow support for Canvas and SVG
2732         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2733
2734         This is the fix of a regression, caused by the shadow patch
2735         from the bug above. Reinserted the save and restore calls
2736         that were accidently removed by the previous patch.
2737
2738         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2739         (WebCore::setPlatformFill):
2740         (WebCore::setPlatformStroke):
2741
2742 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
2743
2744         Not reviewed. Reverting r50908 since it makes inspector tests
2745         time out.
2746
2747         https://bugs.webkit.org/show_bug.cgi?id=31439
2748
2749         * inspector/front-end/inspector.js:
2750
2751 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
2752
2753         Reviewed by Timothy Hatcher.
2754
2755         Enable 'console.profile()' and 'console.profileEnd()'
2756         regardless of JAVASCRIPT_DEBUGGER.
2757
2758         https://bugs.webkit.org/show_bug.cgi?id=31293
2759
2760         * WebCore.gypi:
2761         * bindings/js/JSConsoleCustom.cpp:
2762         (WebCore::JSConsole::profile):
2763         (WebCore::JSConsole::profileEnd):
2764         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
2765         (WebCore::CALLBACK_FUNC_DECL):
2766         * bindings/v8/custom/V8CustomBinding.h:
2767         * page/Console.idl:
2768
2769 2009-11-12  David Levin  <levin@chromium.org>
2770
2771         Reviewed by NOBODY.
2772
2773         Chromium build fix.
2774
2775         * bindings/v8/ScriptController.h:
2776         (WebCore::ScriptController::evaluateInWorld): Add a dummy
2777          method which isn't called in chromium to make things compile.
2778
2779 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2780
2781         Reviewed by Adam Barth.
2782
2783         The document-open.html test was flaky at times. The test invokes the layout test plugin
2784         which in its destroy stream handler opens a new document. This basically tears down the
2785         stream and the associated plugin instance, which causes a crash when the plugin stream
2786         dereferences an invalid m_client pointer which points to the PluginView instance which
2787         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
2788         and check for the same.
2789
2790         https://bugs.webkit.org/show_bug.cgi?id=31067
2791
2792         * plugins/PluginStream.cpp:
2793         (WebCore::PluginStream::stop):
2794         (WebCore::PluginStream::destroyStream):
2795
2796 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2797
2798         Reviewed by Dimitri Glazkov.
2799
2800         Renaming some parameters passed to DB-related methods to better
2801         indicate their purpose.
2802
2803         https://bugs.webkit.org/show_bug.cgi?id=31449
2804
2805         * platform/chromium/ChromiumBridge.h:
2806
2807 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
2808
2809         Reviewed by Dan Bernstein.
2810
2811         Transformed reflected elements are clipped inside element with opacity
2812         https://bugs.webkit.org/show_bug.cgi?id=30957
2813
2814         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
2815         each clip rect into painting space before taking the unions. This, however, did not work
2816         correctly with combinations of reflections and transforms. Fixed by unioning the
2817         clipRect and mapping through transforms along the way.
2818
2819         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
2820         where the transparency layers are.
2821
2822         Test: fast/reflections/opacity-reflection-transform.html
2823
2824         * rendering/RenderLayer.cpp:
2825         (WebCore::expandClipRectForDescendantsAndReflection):
2826         (WebCore::transparencyClipBox):
2827         (WebCore::RenderLayer::beginTransparencyLayers):
2828
2829 2009-11-12  Adam Barth  <abarth@webkit.org>
2830
2831         Reviewed by Darin Fisher.
2832
2833         Improve SecurityOrigin::toString comment
2834         https://bugs.webkit.org/show_bug.cgi?id=31041
2835
2836         * page/SecurityOrigin.h:
2837
2838 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
2839
2840         Reviewed by Darin Adler.
2841
2842         externalRepresentation should take Frame as the argument
2843         https://bugs.webkit.org/show_bug.cgi?id=31393
2844
2845         No new tests as this is just a refactoring.
2846
2847         * WebCore.base.exp:
2848         * rendering/RenderTreeAsText.cpp:
2849         (WebCore::externalRepresentation):
2850         * rendering/RenderTreeAsText.h:
2851
2852 2009-11-12  Ben Murdoch  <benm@google.com>
2853
2854         Reviewed by Dimitri Glazkov.
2855
2856         [Android] The Android specific files in page/Android are out of date.
2857         https://bugs.webkit.org/show_bug.cgi?id=31437
2858
2859         No tests required.
2860
2861         * page/android/DragControllerAndroid.cpp:
2862         (WebCore::DragController::dragOperation): Added.
2863         (WebCore::DragController::cleanupAfterSystemDrag):
2864         * page/android/EventHandlerAndroid.cpp:
2865         (WebCore::EventHandler::accessKeyModifiers): Added.
2866         * page/android/InspectorControllerAndroid.cpp: Removed.
2867
2868 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
2869
2870         Reviewed by Simon Fraser.
2871
2872         [CAIRO] shadow support for Canvas and SVG.
2873         [https://bugs.webkit.org/show_bug.cgi?id=30960]
2874
2875         Implement Canvas/SVG shadow support for Cairo.  This patch
2876         uses the filter code from SVG Filters.  That means that it is
2877         necessary to activate filters to see the shadows.
2878
2879         Test: fast/canvas/canvas-shadow.html
2880
2881         * GNUmakefile.am:
2882         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
2883         * platform/graphics/GraphicsContext.h:
2884         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2885         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
2886         (WebCore::setPlatformFill):
2887         (WebCore::setPlatformStroke):
2888         (WebCore::copyContextProperties):
2889         (WebCore::drawPathShadow):
2890         (WebCore::GraphicsContext::fillPath):
2891         (WebCore::GraphicsContext::strokePath):
2892         (WebCore::GraphicsContext::drawPath):
2893         (WebCore::GraphicsContext::setPlatformShadow):
2894         (WebCore::GraphicsContext::createPlatformShadow):
2895         * platform/graphics/cairo/ImageCairo.cpp:
2896         (WebCore::BitmapImage::draw): Add filter effect.
2897         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
2898         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
2899         * platform/graphics/filters/ImageBufferFilter.h: Added.
2900         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
2901         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
2902
2903 2009-11-12  Dmitry Titov  <dimich@chromium.org>
2904
2905         Reviewed by Alexey Proskuryakov.
2906
2907         Add postTaskToMainThread to ScriptExecutionContext.
2908         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
2909         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
2910         contexts that live on the main thread.
2911         https://bugs.webkit.org/show_bug.cgi?id=31427
2912
2913         No new tests - simply moving the code.
2914
2915         * dom/Document.cpp:
2916         (WebCore::Document::postTask):
2917         * dom/ScriptExecutionContext.cpp:
2918         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
2919         (WebCore::ScriptExecutionContextTaskTimer::fired):
2920         (WebCore::PerformTaskData::PerformTaskData):
2921         (WebCore::PerformTaskData::performTask):
2922         (WebCore::ScriptExecutionContext::postTaskToMainThread):
2923         * dom/ScriptExecutionContext.h:
2924
2925 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
2926
2927         Reviewed by Darin Adler.
2928
2929         Fix crash when removing compositing layers when GC is enabled
2930         https://bugs.webkit.org/show_bug.cgi?id=31429
2931
2932         Workaround <rdar://problem/7390716> by special-casing the removal
2933         of all sublayers when GC is enabled.
2934
2935         * platform/graphics/mac/GraphicsLayerCA.mm:
2936         (WebCore::safeSetSublayers):
2937         (WebCore::GraphicsLayerCA::updateSublayerList):
2938         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2939
2940 2009-11-12  Jens Alfke  <snej@chromium.org>
2941
2942         Reviewed by Dimitri Glazkov.
2943
2944         The last of the V8 binding optimizations.
2945         - Replace string-valued element accessors with a shared getter/setter function.
2946         - Change error handling flow of control to avoid extra branches and function calls.
2947         https://bugs.webkit.org/show_bug.cgi?id=31443
2948
2949         * bindings/scripts/CodeGeneratorV8.pm:
2950         * bindings/v8/V8Binding.cpp:
2951         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
2952         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
2953         * bindings/v8/V8Binding.h:
2954
2955 2009-11-12  Sam Weinig  <sam@webkit.org>
2956
2957         Reviewed by Oliver Hunt.
2958
2959         Fix for <rdar://problem/7267951>
2960         Canvas methods should reject uses of NaN and Infinity.
2961
2962         Test: fast/canvas/canvas-with-illegal-args.html
2963
2964         * html/canvas/CanvasRenderingContext2D.cpp:
2965         (WebCore::CanvasRenderingContext2D::scale):
2966         (WebCore::CanvasRenderingContext2D::rotate):
2967         (WebCore::CanvasRenderingContext2D::translate):
2968         (WebCore::CanvasRenderingContext2D::transform):
2969         (WebCore::CanvasRenderingContext2D::setTransform):
2970
2971 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2972
2973         Reviewed by Timothy Hatcher.
2974
2975         Web Inspector: profile timeline panel, fix obvious problems.
2976
2977         https://bugs.webkit.org/show_bug.cgi?id=31432
2978
2979         * inspector/front-end/AbstractTimelinePanel.js:
2980         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
2981         * inspector/front-end/TimelinePanel.js:
2982         (WebInspector.TimelinePanel.prototype._setWindowPosition):
2983         (WebInspector.TimelineCalculator):
2984         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
2985         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
2986         (WebInspector.TimelineCalculator.prototype.reset):
2987         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
2988         (WebInspector.TimelineCalculator.prototype.formatValue):
2989         (WebInspector.TimelineGraph):
2990         (WebInspector.TimelineGraph.prototype.refresh):
2991         * inspector/front-end/utilities.js:
2992         (Element.prototype.hasStyleClass):
2993
2994 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
2995
2996         Reviewed by Timothy Hatcher.
2997
2998         Web Inspector: preload status bar button glyphs
2999         in order to prevent them from flickering.
3000
3001         https://bugs.webkit.org/show_bug.cgi?id=31439
3002
3003         * inspector/front-end/inspector.js:
3004         (preloadImages):
3005
3006 2009-11-12  Adam Roben  <aroben@apple.com>
3007
3008         Replace worldIDs with world objects
3009
3010         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3011         user scripts/stylesheets and isolated worlds
3012
3013         Reviewed by Sam Weinig.
3014
3015         Covered by existing tests.
3016
3017         * WebCore.base.exp: Update exported symbols to match what now exists
3018         and is needed by WebKit.
3019
3020         * bindings/js/ScheduledAction.cpp:
3021         (WebCore::ScheduledAction::execute): Updated for function rename.
3022
3023         * bindings/js/ScriptController.cpp: Removed code that dealt with
3024         worldIDs.
3025         (WebCore::ScriptController::createWorld): Added. Returns a new world
3026         suitable for use on the main thread.
3027         (WebCore::ScriptController::executeScriptInWorld): Renamed from
3028         executeScriptInIsolatedWorld, since this works just fine with a
3029         "normal" world.
3030
3031         * bindings/js/ScriptController.h: Added createWorld, removed functions
3032         that took worldIDs, renamed executeScriptInIsolatedWorld to
3033         executeScriptInWorld.
3034
3035         * page/Frame.cpp:
3036         (WebCore::Frame::injectUserScripts):
3037         (WebCore::Frame::injectUserScriptsForWorld):
3038         Updated for changes to UserScriptMap and ScriptController.
3039
3040         * page/Frame.h: Changed injectUserScriptsForWorld to take a
3041         DOMWrapperWorld* instead of a worldID.
3042
3043         * page/PageGroup.cpp:
3044         (WebCore::PageGroup::addUserScriptToWorld):
3045         (WebCore::PageGroup::addUserStyleSheetToWorld):
3046         (WebCore::PageGroup::removeUserScriptFromWorld):
3047         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
3048         (WebCore::PageGroup::removeUserScriptsFromWorld):
3049         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
3050         * page/PageGroup.h:
3051         Changed these functions to take a DOMWrapperWorld* instead of a
3052         worldID. Also updated for changes to UserScript and UserStyleSheet.
3053
3054         * page/UserScript.h:
3055         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
3056         never used.
3057
3058         * page/UserScriptTypes.h:
3059         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
3060         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
3061         worldID as their key type.
3062
3063
3064 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
3065
3066         Reviewed by Tim Hatcher.
3067
3068         Fixes <http://webkit.org/b/31260>.
3069         Web Inspector: Main Resources Other than HTML are mis-detected.
3070
3071         Even if the resource is a main resource, look at its CachedResource type,
3072         because it might be an image, stylesheet, or JavaScript file, and we
3073         want to show them all correctly.
3074
3075         * inspector/InspectorResource.cpp:
3076         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
3077         (WebCore::InspectorResource::type):
3078         * inspector/InspectorResource.h:
3079
3080 2009-11-12  Jens Alfke  <snej@chromium.org>
3081
3082         Reviewed by Dimitri Glazkov.
3083
3084         Table-driven setup for V8 binding template callback functions. 100k in code savings.
3085         https://bugs.webkit.org/show_bug.cgi?id=31420
3086
3087         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
3088             to call configureTemplate().
3089         * bindings/v8/V8Binding.cpp:
3090         (WebCore::configureTemplate):  New function; does all the standard configuration work.
3091         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
3092         * bindings/v8/V8Binding.h:
3093         * bindings/v8/V8Proxy.cpp:
3094         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
3095         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
3096         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
3097         * bindings/v8/V8Proxy.h:
3098
3099 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3100
3101         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
3102
3103         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3104
3105 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
3106
3107         Reviewed by Dan Bernstein.
3108
3109         <rdar://problem/7388969> Add DOM API for fullscreen video
3110
3111         DOM API for fullscreen <video>.
3112
3113         Tests: media/media-fullscreen-inline.html
3114                media/media-fullscreen-not-in-document.html
3115
3116         * dom/EventNames.h:
3117             Add webkitbeginfullscreen and webkitendfullscreen.
3118
3119         * html/HTMLAttributeNames.in:
3120             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
3121
3122         * html/HTMLMediaElement.cpp:
3123         (WebCore::HTMLMediaElement::parseMappedAttribute):
3124             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
3125         (WebCore::HTMLMediaElement::enterFullscreen):
3126             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
3127             actually do enter fullscreen.
3128         (WebCore::HTMLMediaElement::exitFullscreen):
3129             Schedule webkitendfullscreenEvent event.
3130         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
3131         (WebCore::HTMLMediaElement::webkitExitFullScreen):
3132         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
3133         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
3134             New, access to fullscreen properties and methods.
3135
3136         * html/HTMLMediaElement.h:
3137         * html/HTMLMediaElement.idl:
3138             Declare methods needed for fullscreen API.
3139
3140         * html/HTMLVideoElement.cpp:
3141         (WebCore::HTMLVideoElement::supportsFullscreen):
3142             Return false if a movie does not have video.
3143
3144         * page/DOMWindow.h:
3145             Add webkitbeginfullscreen and webkitendfullscreen.
3146
3147 2009-11-12  Adam Barth  <abarth@webkit.org>
3148
3149         Reviewed by Dimitri Glazkov.
3150
3151         [Chromium] Sify compose button alerts error
3152         https://bugs.webkit.org/show_bug.cgi?id=31394
3153
3154         Test: http/tests/security/calling-versus-current.html
3155
3156         We're supposed to use the calling context for security checks.  In JSC
3157         land, this is the lexicalGlobalObject.
3158
3159         * bindings/v8/V8Proxy.cpp:
3160         (WebCore::V8Proxy::canAccessPrivate):
3161
3162 2009-11-12  Daniel Bates  <dbates@webkit.org>
3163
3164         Reviewed by Darin Adler.
3165
3166         https://bugs.webkit.org/show_bug.cgi?id=30291
3167
3168         Fixes an issue where the returned drop effect is incorrect when
3169         effectAllowed == "uninitialized".
3170
3171         According to section 7.9.2 of the HTML 5 spec.
3172         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
3173         when effectAllowed = "uninitialized" the resulting dropEffect should be the
3174         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
3175         other case.
3176
3177         No test cases are included because we have an existing test case from
3178         bug #24731.
3179
3180         * dom/Clipboard.cpp:
3181         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
3182
3183 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3184
3185         Reviewed by Timothy Hatcher.
3186
3187         Web Inspector: Do not highlight node on refresh.
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=31419
3190
3191         * inspector/front-end/ElementsPanel.js:
3192         (WebInspector.ElementsPanel.prototype.reset):
3193
3194 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3195
3196         Reviewed by Timothy Hatcher.
3197
3198         Web Inspector: Minor timeline fixes.
3199
3200         https://bugs.webkit.org/show_bug.cgi?id=31417
3201
3202         * inspector/front-end/TimelinePanel.js:
3203         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3204         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3205         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
3206         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3207
3208 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3209
3210         SnowLeopard build fix.
3211
3212         Renamed initWithClient to initWithAuthenticationClient.
3213
3214         * platform/network/mac/AuthenticationMac.mm:
3215         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
3216         (WebCore::AuthenticationChallenge::setAuthenticationClient):
3217
3218 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
3219
3220         Reviewed by Darin Adler.
3221
3222         ARIA: add alert type roles
3223         https://bugs.webkit.org/show_bug.cgi?id=31392
3224
3225         Test: platform/mac/accessibility/aria-alerts.html
3226
3227         * accessibility/AccessibilityObject.h:
3228         * accessibility/AccessibilityRenderObject.cpp:
3229         * accessibility/mac/AccessibilityObjectWrapper.mm:
3230
3231 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3232
3233         Reviewed by Darin Adler.
3234
3235         https://bugs.webkit.org/show_bug.cgi?id=31386
3236         Make Mac AuthenticationChallenge usable from cross-platform code
3237
3238         No change in behavior, so no tests.
3239
3240         * platform/network/ResourceHandle.cpp:
3241         (WebCore::ResourceHandle::clearAuthentication):
3242         * platform/network/ResourceHandleInternal.h:
3243         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3244         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
3245         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
3246         is identical.
3247
3248         * platform/network/cf/AuthenticationChallenge.h:
3249         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
3250         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
3251
3252         * platform/network/cf/ResourceHandleCFNet.cpp:
3253         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
3254         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
3255         be already set.
3256
3257         * platform/network/mac/AuthenticationChallenge.h:
3258         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
3259         best of my understanding.
3260         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
3261         confusion with "mac" and "web" challenges in ResourceHandleInternal.
3262
3263         * platform/network/mac/AuthenticationMac.mm:
3264         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
3265         making it possible to use the latter with NSURLAuthenticationChallenge.
3266         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
3267         m_nsChallenge renaming.
3268         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
3269         set it as sender (or unset, if client is null).
3270
3271         * platform/network/mac/ResourceHandleMac.mm:
3272         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
3273         authentication challenge sender.
3274         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
3275         authentication sheet.
3276         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
3277         using the new setAuthenticationClient() method.
3278         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
3279         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
3280         the original Mac one, not the one we created for use with authentication sheet. I don't
3281         know when a connection would cancel authentication in practice, so I haven't tested this.
3282
3283 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3284
3285         Reviewed by Timothy Hatcher.
3286
3287         Web Inspector: breakpoint sidebar entries should allow click over entire list item
3288         https://bugs.webkit.org/show_bug.cgi?id=31411
3289
3290         No new tests; no new functionality, small usability change.
3291
3292         * inspector/front-end/BreakpointsSidebarPane.js:
3293         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
3294         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
3295
3296 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
3297
3298         Reviewed by Timothy Hatcher.
3299
3300         Web Inspector: breakpoints in named evals are not restored after a reload
3301         https://bugs.webkit.org/show_bug.cgi?id=31375
3302
3303         Manual test added
3304
3305         * inspector/front-end/ScriptsPanel.js:
3306         (WebInspector.ScriptsPanel.prototype.addScript):
3307         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
3308
3309 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3310
3311         Reviewed by Kenneth Rohde Christiansen.
3312
3313         Custom printing shrink factors
3314         https://bugs.webkit.org/show_bug.cgi?id=29042
3315
3316         This reverts commit r49769. The public API for this needs to be reviewed
3317         before its inclusion in Qt.
3318
3319         * page/PrintContext.cpp:
3320         (WebCore::PrintContext::begin):
3321         * page/Settings.cpp:
3322         (WebCore::Settings::Settings):
3323         * page/Settings.h:
3324
3325 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
3326
3327         Reviewed by Pavel Feldman.
3328
3329         Web Inspector: Resource errors/warnings not shown in the Resource tree.
3330
3331         Error/Warning bubbles are not displayed next to the resource in the
3332         Resources panel if those occur before the resource is attached to the tree.
3333         https://bugs.webkit.org/show_bug.cgi?id=31404
3334
3335         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
3336
3337         * inspector/front-end/AbstractTimelinePanel.js:
3338         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3339         * inspector/front-end/ResourcesPanel.js:
3340         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
3341
3342 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3343
3344         Reviewed by Jan Alonzo.
3345
3346         https://bugs.webkit.org/show_bug.cgi?id=31047
3347         [GTK] Failing test media/video-played-ranges-1.html
3348
3349         Follow-up of r50726, don't block the UI thread when calling
3350         gst_element_get_state(). Also fixed a compilation warning and some
3351         static casts.
3352
3353         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3354         (WebCore::playbackPosition):
3355         (WebCore::MediaPlayerPrivate::seek):
3356         (WebCore::MediaPlayerPrivate::setRate):
3357
3358 2009-11-12  Philippe Normand  <pnormand@igalia.com>
3359
3360         Reviewed by Jan Alonzo.
3361
3362         https://bugs.webkit.org/show_bug.cgi?id=31047
3363         [GTK] Failing test media/video-played-ranges-1.html
3364
3365         don't pause pipeline if already paused, same for play()
3366
3367         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3368         (WebCore::MediaPlayerPrivate::play):
3369         (WebCore::MediaPlayerPrivate::pause):
3370
3371 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
3372
3373         Reviewed by David Levin.
3374
3375         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
3376         Chromium too.
3377         https://bugs.webkit.org/show_bug.cgi?id=31292
3378
3379         No new tests. (Corresponding test for Gtk+ is
3380         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
3381
3382         * page/EventHandler.cpp:
3383         * page/chromium/EventHandlerChromium.cpp:
3384
3385 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
3386
3387         Reviewed by Eric Seidel.
3388
3389         Prevent text inside a multi-column block from being split into columns.
3390
3391         If the tentative height of a multi-column block was too small, we need to
3392         expand the block height and try to layout again, in order to prevent text
3393         from being split into different columns.
3394
3395         CSS Multicolumn text is split awkwardly
3396         https://bugs.webkit.org/show_bug.cgi?id=22249
3397
3398         Test: fast/multicol/single-line.html
3399
3400         * rendering/RenderBlock.cpp:
3401         (WebCore::RenderBlock::layoutColumns):
3402         * rendering/RenderBlock.h:
3403         * rendering/RenderLineBoxList.cpp:
3404         (WebCore::RenderLineBoxList::paint):
3405         * rendering/RenderView.h:
3406         (WebCore::RenderView::setTruncatedAt):
3407         (WebCore::RenderView::setMinimumColumnHeight):
3408         (WebCore::RenderView::minimumColumnHeight):
3409
3410 2009-11-11  Kent Tamura  <tkent@chromium.org>
3411
3412         Reviewed by Darin Adler.
3413
3414         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
3415         https://bugs.webkit.org/show_bug.cgi?id=31195
3416
3417         Test: fast/forms/input-file-re-render.html
3418
3419         * rendering/RenderFileUploadControl.cpp:
3420         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
3421
3422 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
3423
3424         Reviewed by Dimitri Glazkov.
3425
3426         Fixing Chromium's POSIX VFS implementation, by adding the required
3427         "used file descriptors" logic.
3428
3429         https://bugs.webkit.org/show_bug.cgi?id=31275
3430
3431         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3432
3433 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3434
3435         Reviewed by Oliver Hunt.
3436
3437         need to implement aria tree roles
3438         https://bugs.webkit.org/show_bug.cgi?id=31284
3439
3440         Tests: platform/mac/accessibility/aria-multiselectable.html
3441                platform/mac/accessibility/aria-tree.html
3442
3443         * accessibility/AccessibilityList.cpp:
3444         (WebCore::AccessibilityList::accessibilityIsIgnored):
3445         * accessibility/AccessibilityObject.cpp:
3446         (WebCore::AccessibilityObject::ariaTreeRows):
3447         (WebCore::AccessibilityObject::ariaTreeItemContent):
3448         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
3449         * accessibility/AccessibilityObject.h:
3450         (WebCore::):
3451         (WebCore::AccessibilityObject::isTree):
3452         (WebCore::AccessibilityObject::isTreeItem):
3453         (WebCore::AccessibilityObject::setIsExpanded):
3454         (WebCore::AccessibilityObject::canSetExpandedAttribute):
3455         (WebCore::AccessibilityObject::hierarchicalLevel):
3456         (WebCore::AccessibilityObject::setSelectedRows):
3457         (WebCore::AccessibilityObject::performDefaultAction):
3458         * accessibility/AccessibilityRenderObject.cpp:
3459         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
3460         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3461         (WebCore::AccessibilityRenderObject::isExpanded):
3462         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
3463         (WebCore::AccessibilityRenderObject::elementAttributeValue):
3464         (WebCore::AccessibilityRenderObject::setIsExpanded):
3465         (WebCore::AccessibilityRenderObject::isSelected):
3466         (WebCore::AccessibilityRenderObject::setSelected):
3467         (WebCore::AccessibilityRenderObject::setSelectedRows):
3468         (WebCore::createARIARoleMap):
3469         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
3470         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
3471         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
3472         (WebCore::AccessibilityRenderObject::selectedChildren):
3473         * accessibility/AccessibilityRenderObject.h:
3474         * accessibility/mac/AccessibilityObjectMac.mm:
3475         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
3476         * accessibility/mac/AccessibilityObjectWrapper.mm:
3477         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
3478         (RoleEntry::):
3479         (-[AccessibilityObjectWrapper subrole]):
3480         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
3481         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
3482         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
3483         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
3484         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
3485         * html/HTMLAttributeNames.in:
3486
3487 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
3488
3489         Build fix after @r50760 with ENABLE_FILTERS.
3490
3491         * platform/graphics/filters/SourceAlpha.cpp:
3492         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
3493         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
3494           to fillRect.
3495
3496 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
3497
3498         Reviewed by Alexey Proskuryakov.
3499
3500         Fix WebSocket frame parser of frame_type with high-order bit set.
3501         https://bugs.webkit.org/show_bug.cgi?id=30668
3502
3503         If buffer is smaller than frame's length, it should break the loop
3504         instead of reading next byte.
3505
3506         Tests: websocket/tests/frame-length-longer-than-buffer.html
3507                websocket/tests/frame-length-skip.html
3508
3509         * websockets/WebSocketChannel.cpp:
3510         (WebCore::WebSocketChannel::didReceiveData):
3511
3512 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
3513
3514         Reviewed by Adam Barth.
3515
3516         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
3517         https://bugs.webkit.org/show_bug.cgi?id=31345
3518
3519         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
3520
3521         * platform/graphics/chromium/FontCustomPlatformData.cpp:
3522         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
3523         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
3524         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
3525
3526 2009-11-11  Beth Dakin  <bdakin@apple.com>
3527
3528         Build fix. No review needed.
3529
3530         * platform/graphics/gtk/FontGtk.cpp:
3531         (WebCore::Font::drawComplexText):
3532
3533 2009-11-11  Beth Dakin  <bdakin@apple.com>
3534
3535         Build fix. No review needed.
3536
3537         * platform/graphics/cairo/FontCairo.cpp:
3538         (WebCore::Font::drawGlyphs):
3539
3540 2009-11-11  Beth Dakin  <bdakin@apple.com>
3541
3542         Windows build fix. No review needed.
3543
3544         * platform/graphics/win/FontCGWin.cpp:
3545         (WebCore::Font::drawGlyphs):
3546
3547 2009-11-11  Beth Dakin  <bdakin@apple.com>
3548
3549         Reviewed by Simon Fraser.
3550
3551         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
3552         Make -webkit-color-correction work with shadows
3553
3554         From canvas, just send DeviceColorSpace to setShadow() for now.
3555         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
3556         * html/canvas/CanvasRenderingContext2D.cpp:
3557         (WebCore::CanvasRenderingContext2D::setShadow):
3558         (WebCore::CanvasRenderingContext2D::applyShadow):
3559
3560         setShadow() and setPlatformShadow() now take a ColorSpace.
3561         * platform/graphics/GraphicsContext.cpp:
3562         (WebCore::GraphicsContext::setShadow):
3563         * platform/graphics/GraphicsContext.h:
3564         * platform/graphics/cg/GraphicsContextCG.cpp:
3565         (WebCore::createCGColorWithColorSpace): New helper to create a
3566         color in a ColorSpace.
3567         (WebCore::setCGFillColor): Call new helper.
3568         (WebCore::setCGStrokeColor): Call new helper.
3569         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
3570         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3571         (WebCore::GraphicsContext::setPlatformShadow):
3572
3573         Send appropriate ColorSpace to setShadow().
3574         * platform/graphics/mac/FontMac.mm:
3575         (WebCore::Font::drawGlyphs):
3576         * rendering/EllipsisBox.cpp:
3577         (WebCore::EllipsisBox::paint):
3578         * rendering/InlineFlowBox.cpp:
3579         (WebCore::InlineFlowBox::paintTextDecorations):
3580         * rendering/InlineTextBox.cpp:
3581         (WebCore::paintTextWithShadows):
3582         (WebCore::InlineTextBox::paintDecoration):
3583         * rendering/RenderBoxModelObject.cpp:
3584         (WebCore::RenderBoxModelObject::paintBoxShadow):
3585         * rendering/SVGInlineTextBox.cpp:
3586         (WebCore::SVGInlineTextBox::paintCharacters):
3587         * rendering/SVGRenderSupport.cpp:
3588         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
3589
3590         Attempt to keep ports building.
3591         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3592         (WebCore::GraphicsContext::setPlatformShadow):
3593         * platform/graphics/qt/GraphicsContextQt.cpp:
3594         (WebCore::GraphicsContext::setPlatformShadow):
3595         * platform/graphics/skia/GraphicsContextSkia.cpp:
3596         (WebCore::GraphicsContext::setPlatformShadow):
3597         * platform/graphics/wince/GraphicsContextWince.cpp:
3598         (WebCore::GraphicsContext::setPlatformShadow):
3599         * platform/graphics/wx/GraphicsContextWx.cpp:
3600         (WebCore::GraphicsContext::setPlatformShadow):
3601
3602 2009-11-11  Kent Tamura  <tkent@chromium.org>
3603
3604         Reviewed by Darin Adler.
3605
3606         Print the file text of a file upload control in DumpRenderTree for ease of tests.
3607         https://bugs.webkit.org/show_bug.cgi?id=31195
3608
3609         * rendering/RenderFileUploadControl.cpp:
3610         (WebCore::RenderFileUploadControl::paintObject):
3611         (WebCore::RenderFileUploadControl::fileTextValue):
3612         * rendering/RenderFileUploadControl.h:
3613         (WebCore::RenderFileUploadControl::isFileUploadControl):
3614         (WebCore::toRenderFileUploadControl):
3615         * rendering/RenderObject.h:
3616         (WebCore::RenderObject::isFileUploadControl):
3617         * rendering/RenderTreeAsText.cpp:
3618         (WebCore::operator<<):
3619
3620 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
3621
3622         Reviewed by Sam Weinig.
3623