2009-11-12 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-12  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Darin Fisher.
4
5         Improve SecurityOrigin::toString comment
6         https://bugs.webkit.org/show_bug.cgi?id=31041
7
8         * page/SecurityOrigin.h:
9
10 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
11
12         Reviewed by Darin Adler.
13
14         externalRepresentation should take Frame as the argument
15         https://bugs.webkit.org/show_bug.cgi?id=31393
16
17         No new tests as this is just a refactoring.
18
19         * WebCore.base.exp:
20         * rendering/RenderTreeAsText.cpp:
21         (WebCore::externalRepresentation):
22         * rendering/RenderTreeAsText.h:
23
24 2009-11-12  Ben Murdoch  <benm@google.com>
25
26         Reviewed by Dimitri Glazkov.
27
28         [Android] The Android specific files in page/Android are out of date.
29         https://bugs.webkit.org/show_bug.cgi?id=31437
30
31         No tests required.
32
33         * page/android/DragControllerAndroid.cpp:
34         (WebCore::DragController::dragOperation): Added.
35         (WebCore::DragController::cleanupAfterSystemDrag):
36         * page/android/EventHandlerAndroid.cpp:
37         (WebCore::EventHandler::accessKeyModifiers): Added.
38         * page/android/InspectorControllerAndroid.cpp: Removed.
39
40 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
41
42         Reviewed by Simon Fraser.
43
44         [CAIRO] shadow support for Canvas and SVG.
45         [https://bugs.webkit.org/show_bug.cgi?id=30960]
46
47         Implement Canvas/SVG shadow support for Cairo.  This patch
48         uses the filter code from SVG Filters.  That means that it is
49         necessary to activate filters to see the shadows.
50
51         Test: fast/canvas/canvas-shadow.html
52
53         * GNUmakefile.am:
54         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
55         * platform/graphics/GraphicsContext.h:
56         * platform/graphics/cairo/GraphicsContextCairo.cpp:
57         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
58         (WebCore::setPlatformFill):
59         (WebCore::setPlatformStroke):
60         (WebCore::copyContextProperties):
61         (WebCore::drawPathShadow):
62         (WebCore::GraphicsContext::fillPath):
63         (WebCore::GraphicsContext::strokePath):
64         (WebCore::GraphicsContext::drawPath):
65         (WebCore::GraphicsContext::setPlatformShadow):
66         (WebCore::GraphicsContext::createPlatformShadow):
67         * platform/graphics/cairo/ImageCairo.cpp:
68         (WebCore::BitmapImage::draw): Add filter effect.
69         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
70         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
71         * platform/graphics/filters/ImageBufferFilter.h: Added.
72         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
73         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
74
75 2009-11-12  Dmitry Titov  <dimich@chromium.org>
76
77         Reviewed by Alexey Proskuryakov.
78
79         Add postTaskToMainThread to ScriptExecutionContext.
80         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
81         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
82         contexts that live on the main thread.
83         https://bugs.webkit.org/show_bug.cgi?id=31427
84
85         No new tests - simply moving the code.
86
87         * dom/Document.cpp:
88         (WebCore::Document::postTask):
89         * dom/ScriptExecutionContext.cpp:
90         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
91         (WebCore::ScriptExecutionContextTaskTimer::fired):
92         (WebCore::PerformTaskData::PerformTaskData):
93         (WebCore::PerformTaskData::performTask):
94         (WebCore::ScriptExecutionContext::postTaskToMainThread):
95         * dom/ScriptExecutionContext.h:
96
97 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
98
99         Reviewed by Darin Adler.
100
101         Fix crash when removing compositing layers when GC is enabled
102         https://bugs.webkit.org/show_bug.cgi?id=31429
103
104         Workaround <rdar://problem/7390716> by special-casing the removal
105         of all sublayers when GC is enabled.
106
107         * platform/graphics/mac/GraphicsLayerCA.mm:
108         (WebCore::safeSetSublayers):
109         (WebCore::GraphicsLayerCA::updateSublayerList):
110         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
111
112 2009-11-12  Jens Alfke  <snej@chromium.org>
113
114         Reviewed by Dimitri Glazkov.
115
116         The last of the V8 binding optimizations.
117         - Replace string-valued element accessors with a shared getter/setter function.
118         - Change error handling flow of control to avoid extra branches and function calls.
119         https://bugs.webkit.org/show_bug.cgi?id=31443
120         
121         * bindings/scripts/CodeGeneratorV8.pm:
122         * bindings/v8/V8Binding.cpp:
123         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
124         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
125         * bindings/v8/V8Binding.h:
126
127 2009-11-12  Sam Weinig  <sam@webkit.org>
128
129         Reviewed by Oliver Hunt.
130
131         Fix for <rdar://problem/7267951>
132         Canvas methods should reject uses of NaN and Infinity.
133
134         Test: fast/canvas/canvas-with-illegal-args.html
135
136         * html/canvas/CanvasRenderingContext2D.cpp:
137         (WebCore::CanvasRenderingContext2D::scale):
138         (WebCore::CanvasRenderingContext2D::rotate):
139         (WebCore::CanvasRenderingContext2D::translate):
140         (WebCore::CanvasRenderingContext2D::transform):
141         (WebCore::CanvasRenderingContext2D::setTransform):
142
143 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
144
145         Reviewed by Timothy Hatcher.
146
147         Web Inspector: profile timeline panel, fix obvious problems.
148
149         https://bugs.webkit.org/show_bug.cgi?id=31432
150
151         * inspector/front-end/AbstractTimelinePanel.js:
152         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
153         * inspector/front-end/TimelinePanel.js:
154         (WebInspector.TimelinePanel.prototype._setWindowPosition):
155         (WebInspector.TimelineCalculator):
156         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
157         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
158         (WebInspector.TimelineCalculator.prototype.reset):
159         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
160         (WebInspector.TimelineCalculator.prototype.formatValue):
161         (WebInspector.TimelineGraph):
162         (WebInspector.TimelineGraph.prototype.refresh):
163         * inspector/front-end/utilities.js:
164         (Element.prototype.hasStyleClass):
165
166 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
167
168         Reviewed by Timothy Hatcher.
169
170         Web Inspector: preload status bar button glyphs
171         in order to prevent them from flickering.
172
173         https://bugs.webkit.org/show_bug.cgi?id=31439
174
175         * inspector/front-end/inspector.js:
176         (preloadImages):
177
178 2009-11-12  Adam Roben  <aroben@apple.com>
179
180         Replace worldIDs with world objects
181
182         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
183         user scripts/stylesheets and isolated worlds
184
185         Reviewed by Sam Weinig.
186
187         Covered by existing tests.
188
189         * WebCore.base.exp: Update exported symbols to match what now exists
190         and is needed by WebKit.
191
192         * bindings/js/ScheduledAction.cpp:
193         (WebCore::ScheduledAction::execute): Updated for function rename.
194
195         * bindings/js/ScriptController.cpp: Removed code that dealt with
196         worldIDs.
197         (WebCore::ScriptController::createWorld): Added. Returns a new world
198         suitable for use on the main thread.
199         (WebCore::ScriptController::executeScriptInWorld): Renamed from
200         executeScriptInIsolatedWorld, since this works just fine with a
201         "normal" world.
202
203         * bindings/js/ScriptController.h: Added createWorld, removed functions
204         that took worldIDs, renamed executeScriptInIsolatedWorld to
205         executeScriptInWorld.
206
207         * page/Frame.cpp:
208         (WebCore::Frame::injectUserScripts):
209         (WebCore::Frame::injectUserScriptsForWorld):
210         Updated for changes to UserScriptMap and ScriptController.
211
212         * page/Frame.h: Changed injectUserScriptsForWorld to take a
213         DOMWrapperWorld* instead of a worldID.
214
215         * page/PageGroup.cpp:
216         (WebCore::PageGroup::addUserScriptToWorld):
217         (WebCore::PageGroup::addUserStyleSheetToWorld):
218         (WebCore::PageGroup::removeUserScriptFromWorld):
219         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
220         (WebCore::PageGroup::removeUserScriptsFromWorld):
221         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
222         * page/PageGroup.h:
223         Changed these functions to take a DOMWrapperWorld* instead of a
224         worldID. Also updated for changes to UserScript and UserStyleSheet.
225
226         * page/UserScript.h:
227         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
228         never used.
229
230         * page/UserScriptTypes.h:
231         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
232         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
233         worldID as their key type.
234
235
236 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
237
238         Reviewed by Tim Hatcher.
239
240         Fixes <http://webkit.org/b/31260>.
241         Web Inspector: Main Resources Other than HTML are mis-detected.
242         
243         Even if the resource is a main resource, look at its CachedResource type, 
244         because it might be an image, stylesheet, or JavaScript file, and we
245         want to show them all correctly.
246
247         * inspector/InspectorResource.cpp:
248         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
249         (WebCore::InspectorResource::type): 
250         * inspector/InspectorResource.h:
251
252 2009-11-12  Jens Alfke  <snej@chromium.org>
253
254         Reviewed by Dimitri Glazkov.
255
256         Table-driven setup for V8 binding template callback functions. 100k in code savings.
257         https://bugs.webkit.org/show_bug.cgi?id=31420
258
259         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
260             to call configureTemplate().
261         * bindings/v8/V8Binding.cpp:
262         (WebCore::configureTemplate):  New function; does all the standard configuration work.
263         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
264         * bindings/v8/V8Binding.h:
265         * bindings/v8/V8Proxy.cpp:
266         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
267         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
268         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
269         * bindings/v8/V8Proxy.h:
270
271 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
272
273         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
274
275         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
276
277 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
278
279         Reviewed by Dan Bernstein.
280
281         <rdar://problem/7388969> Add DOM API for fullscreen video
282         
283         DOM API for fullscreen <video>.
284
285         Tests: media/media-fullscreen-inline.html
286                media/media-fullscreen-not-in-document.html
287
288         * dom/EventNames.h:
289             Add webkitbeginfullscreen and webkitendfullscreen.
290
291         * html/HTMLAttributeNames.in:
292             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
293
294         * html/HTMLMediaElement.cpp:
295         (WebCore::HTMLMediaElement::parseMappedAttribute):
296             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
297         (WebCore::HTMLMediaElement::enterFullscreen):
298             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
299             actually do enter fullscreen.
300         (WebCore::HTMLMediaElement::exitFullscreen):
301             Schedule webkitendfullscreenEvent event.
302         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
303         (WebCore::HTMLMediaElement::webkitExitFullScreen):
304         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
305         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
306             New, access to fullscreen properties and methods.
307
308         * html/HTMLMediaElement.h:
309         * html/HTMLMediaElement.idl:
310             Declare methods needed for fullscreen API.
311
312         * html/HTMLVideoElement.cpp:
313         (WebCore::HTMLVideoElement::supportsFullscreen):
314             Return false if a movie does not have video.
315
316         * page/DOMWindow.h:
317             Add webkitbeginfullscreen and webkitendfullscreen.
318
319 2009-11-12  Adam Barth  <abarth@webkit.org>
320
321         Reviewed by Dimitri Glazkov.
322
323         [Chromium] Sify compose button alerts error
324         https://bugs.webkit.org/show_bug.cgi?id=31394
325
326         Test: http/tests/security/calling-versus-current.html
327
328         We're supposed to use the calling context for security checks.  In JSC
329         land, this is the lexicalGlobalObject.
330
331         * bindings/v8/V8Proxy.cpp:
332         (WebCore::V8Proxy::canAccessPrivate):
333
334 2009-11-12  Daniel Bates  <dbates@webkit.org>
335
336         Reviewed by Darin Adler.
337
338         https://bugs.webkit.org/show_bug.cgi?id=30291
339
340         Fixes an issue where the returned drop effect is incorrect when
341         effectAllowed == "uninitialized".
342
343         According to section 7.9.2 of the HTML 5 spec.
344         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
345         when effectAllowed = "uninitialized" the resulting dropEffect should be the
346         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
347         other case.
348         
349         No test cases are included because we have an existing test case from
350         bug #24731.
351
352         * dom/Clipboard.cpp:
353         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
354
355 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
356
357         Reviewed by Timothy Hatcher.
358
359         Web Inspector: Do not highlight node on refresh.
360
361         https://bugs.webkit.org/show_bug.cgi?id=31419
362
363         * inspector/front-end/ElementsPanel.js:
364         (WebInspector.ElementsPanel.prototype.reset):
365
366 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
367
368         Reviewed by Timothy Hatcher.
369
370         Web Inspector: Minor timeline fixes.
371
372         https://bugs.webkit.org/show_bug.cgi?id=31417
373
374         * inspector/front-end/TimelinePanel.js:
375         (WebInspector.TimelinePanel.prototype._getRecordDetails):
376         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
377         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
378         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
379
380 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
381
382         SnowLeopard build fix.
383
384         Renamed initWithClient to initWithAuthenticationClient.
385
386         * platform/network/mac/AuthenticationMac.mm:
387         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
388         (WebCore::AuthenticationChallenge::setAuthenticationClient):
389
390 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
391
392         Reviewed by Darin Adler.
393
394         ARIA: add alert type roles
395         https://bugs.webkit.org/show_bug.cgi?id=31392
396
397         Test: platform/mac/accessibility/aria-alerts.html
398
399         * accessibility/AccessibilityObject.h:
400         * accessibility/AccessibilityRenderObject.cpp:
401         * accessibility/mac/AccessibilityObjectWrapper.mm:
402
403 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
404
405         Reviewed by Darin Adler.
406
407         https://bugs.webkit.org/show_bug.cgi?id=31386
408         Make Mac AuthenticationChallenge usable from cross-platform code
409
410         No change in behavior, so no tests.
411
412         * platform/network/ResourceHandle.cpp:
413         (WebCore::ResourceHandle::clearAuthentication):
414         * platform/network/ResourceHandleInternal.h:
415         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
416         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
417         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
418         is identical.
419
420         * platform/network/cf/AuthenticationChallenge.h:
421         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
422         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
423
424         * platform/network/cf/ResourceHandleCFNet.cpp:
425         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
426         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
427         be already set.
428
429         * platform/network/mac/AuthenticationChallenge.h:
430         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
431         best of my understanding.
432         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
433         confusion with "mac" and "web" challenges in ResourceHandleInternal.
434
435         * platform/network/mac/AuthenticationMac.mm:
436         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
437         making it possible to use the latter with NSURLAuthenticationChallenge.
438         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
439         m_nsChallenge renaming.
440         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
441         set it as sender (or unset, if client is null).
442
443         * platform/network/mac/ResourceHandleMac.mm:
444         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
445         authentication challenge sender.
446         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
447         authentication sheet.
448         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
449         using the new setAuthenticationClient() method.
450         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
451         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
452         the original Mac one, not the one we created for use with authentication sheet. I don't
453         know when a connection would cancel authentication in practice, so I haven't tested this.
454
455 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
456
457         Reviewed by Timothy Hatcher.
458
459         Web Inspector: breakpoint sidebar entries should allow click over entire list item
460         https://bugs.webkit.org/show_bug.cgi?id=31411
461
462         No new tests; no new functionality, small usability change. 
463
464         * inspector/front-end/BreakpointsSidebarPane.js:
465         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
466         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
467
468 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
469
470         Reviewed by Timothy Hatcher.
471
472         Web Inspector: breakpoints in named evals are not restored after a reload
473         https://bugs.webkit.org/show_bug.cgi?id=31375
474
475         Manual test added
476
477         * inspector/front-end/ScriptsPanel.js:
478         (WebInspector.ScriptsPanel.prototype.addScript):
479         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
480
481 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
482
483         Reviewed by Kenneth Rohde Christiansen.
484
485         Custom printing shrink factors
486         https://bugs.webkit.org/show_bug.cgi?id=29042
487
488         This reverts commit r49769. The public API for this needs to be reviewed
489         before its inclusion in Qt.
490
491         * page/PrintContext.cpp:
492         (WebCore::PrintContext::begin):
493         * page/Settings.cpp:
494         (WebCore::Settings::Settings):
495         * page/Settings.h:
496
497 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
498
499         Reviewed by Pavel Feldman.
500
501         Web Inspector: Resource errors/warnings not shown in the Resource tree.
502
503         Error/Warning bubbles are not displayed next to the resource in the 
504         Resources panel if those occur before the resource is attached to the tree.
505         https://bugs.webkit.org/show_bug.cgi?id=31404
506
507         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
508
509         * inspector/front-end/AbstractTimelinePanel.js:
510         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
511         * inspector/front-end/ResourcesPanel.js:
512         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
513
514 2009-11-12  Philippe Normand  <pnormand@igalia.com>
515
516         Reviewed by Jan Alonzo.
517
518         https://bugs.webkit.org/show_bug.cgi?id=31047
519         [GTK] Failing test media/video-played-ranges-1.html
520
521         Follow-up of r50726, don't block the UI thread when calling
522         gst_element_get_state(). Also fixed a compilation warning and some
523         static casts.
524
525         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
526         (WebCore::playbackPosition):
527         (WebCore::MediaPlayerPrivate::seek):
528         (WebCore::MediaPlayerPrivate::setRate):
529
530 2009-11-12  Philippe Normand  <pnormand@igalia.com>
531
532         Reviewed by Jan Alonzo.
533
534         https://bugs.webkit.org/show_bug.cgi?id=31047
535         [GTK] Failing test media/video-played-ranges-1.html
536
537         don't pause pipeline if already paused, same for play()
538
539         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
540         (WebCore::MediaPlayerPrivate::play):
541         (WebCore::MediaPlayerPrivate::pause):
542
543 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
544
545         Reviewed by David Levin.
546
547         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
548         Chromium too.
549         https://bugs.webkit.org/show_bug.cgi?id=31292
550
551         No new tests. (Corresponding test for Gtk+ is
552         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
553
554         * page/EventHandler.cpp:
555         * page/chromium/EventHandlerChromium.cpp:
556
557 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
558
559         Reviewed by Eric Seidel.
560
561         Prevent text inside a multi-column block from being split into columns.
562         
563         If the tentative height of a multi-column block was too small, we need to
564         expand the block height and try to layout again, in order to prevent text
565         from being split into different columns.
566
567         CSS Multicolumn text is split awkwardly
568         https://bugs.webkit.org/show_bug.cgi?id=22249
569
570         Test: fast/multicol/single-line.html
571
572         * rendering/RenderBlock.cpp:
573         (WebCore::RenderBlock::layoutColumns):
574         * rendering/RenderBlock.h:
575         * rendering/RenderLineBoxList.cpp:
576         (WebCore::RenderLineBoxList::paint):
577         * rendering/RenderView.h:
578         (WebCore::RenderView::setTruncatedAt):
579         (WebCore::RenderView::setMinimumColumnHeight):
580         (WebCore::RenderView::minimumColumnHeight):
581
582 2009-11-11  Kent Tamura  <tkent@chromium.org>
583
584         Reviewed by Darin Adler.
585
586         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
587         https://bugs.webkit.org/show_bug.cgi?id=31195
588
589         Test: fast/forms/input-file-re-render.html
590
591         * rendering/RenderFileUploadControl.cpp:
592         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
593
594 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
595
596         Reviewed by Dimitri Glazkov.
597
598         Fixing Chromium's POSIX VFS implementation, by adding the required
599         "used file descriptors" logic.
600
601         https://bugs.webkit.org/show_bug.cgi?id=31275
602
603         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
604
605 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
606
607         Reviewed by Oliver Hunt.
608
609         need to implement aria tree roles
610         https://bugs.webkit.org/show_bug.cgi?id=31284
611
612         Tests: platform/mac/accessibility/aria-multiselectable.html
613                platform/mac/accessibility/aria-tree.html
614
615         * accessibility/AccessibilityList.cpp:
616         (WebCore::AccessibilityList::accessibilityIsIgnored):
617         * accessibility/AccessibilityObject.cpp:
618         (WebCore::AccessibilityObject::ariaTreeRows):
619         (WebCore::AccessibilityObject::ariaTreeItemContent):
620         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
621         * accessibility/AccessibilityObject.h:
622         (WebCore::):
623         (WebCore::AccessibilityObject::isTree):
624         (WebCore::AccessibilityObject::isTreeItem):
625         (WebCore::AccessibilityObject::setIsExpanded):
626         (WebCore::AccessibilityObject::canSetExpandedAttribute):
627         (WebCore::AccessibilityObject::hierarchicalLevel):
628         (WebCore::AccessibilityObject::setSelectedRows):
629         (WebCore::AccessibilityObject::performDefaultAction):
630         * accessibility/AccessibilityRenderObject.cpp:
631         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
632         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
633         (WebCore::AccessibilityRenderObject::isExpanded):
634         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
635         (WebCore::AccessibilityRenderObject::elementAttributeValue):
636         (WebCore::AccessibilityRenderObject::setIsExpanded):
637         (WebCore::AccessibilityRenderObject::isSelected):
638         (WebCore::AccessibilityRenderObject::setSelected):
639         (WebCore::AccessibilityRenderObject::setSelectedRows):
640         (WebCore::createARIARoleMap):
641         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
642         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
643         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
644         (WebCore::AccessibilityRenderObject::selectedChildren):
645         * accessibility/AccessibilityRenderObject.h:
646         * accessibility/mac/AccessibilityObjectMac.mm:
647         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
648         * accessibility/mac/AccessibilityObjectWrapper.mm:
649         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
650         (RoleEntry::):
651         (-[AccessibilityObjectWrapper subrole]):
652         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
653         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
654         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
655         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
656         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
657         * html/HTMLAttributeNames.in:
658
659 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
660
661         Build fix after @r50760 with ENABLE_FILTERS.
662
663         * platform/graphics/filters/SourceAlpha.cpp:
664         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
665         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
666           to fillRect.
667
668 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
669
670         Reviewed by Alexey Proskuryakov.
671
672         Fix WebSocket frame parser of frame_type with high-order bit set.
673         https://bugs.webkit.org/show_bug.cgi?id=30668
674
675         If buffer is smaller than frame's length, it should break the loop
676         instead of reading next byte.
677
678         Tests: websocket/tests/frame-length-longer-than-buffer.html
679                websocket/tests/frame-length-skip.html
680
681         * websockets/WebSocketChannel.cpp:
682         (WebCore::WebSocketChannel::didReceiveData):
683
684 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
685
686         Reviewed by Adam Barth.
687
688         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
689         https://bugs.webkit.org/show_bug.cgi?id=31345
690
691         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
692
693         * platform/graphics/chromium/FontCustomPlatformData.cpp:
694         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
695         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
696         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
697
698 2009-11-11  Beth Dakin  <bdakin@apple.com>
699
700         Build fix. No review needed.
701
702         * platform/graphics/gtk/FontGtk.cpp:
703         (WebCore::Font::drawComplexText):
704
705 2009-11-11  Beth Dakin  <bdakin@apple.com>
706
707         Build fix. No review needed.
708
709         * platform/graphics/cairo/FontCairo.cpp:
710         (WebCore::Font::drawGlyphs):
711
712 2009-11-11  Beth Dakin  <bdakin@apple.com>
713
714         Windows build fix. No review needed. 
715
716         * platform/graphics/win/FontCGWin.cpp:
717         (WebCore::Font::drawGlyphs):
718
719 2009-11-11  Beth Dakin  <bdakin@apple.com>
720
721         Reviewed by Simon Fraser.
722
723         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
724         Make -webkit-color-correction work with shadows
725
726         From canvas, just send DeviceColorSpace to setShadow() for now. 
727         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
728         * html/canvas/CanvasRenderingContext2D.cpp:
729         (WebCore::CanvasRenderingContext2D::setShadow):
730         (WebCore::CanvasRenderingContext2D::applyShadow):
731
732         setShadow() and setPlatformShadow() now take a ColorSpace.
733         * platform/graphics/GraphicsContext.cpp:
734         (WebCore::GraphicsContext::setShadow):
735         * platform/graphics/GraphicsContext.h:
736         * platform/graphics/cg/GraphicsContextCG.cpp:
737         (WebCore::createCGColorWithColorSpace): New helper to create a 
738         color in a ColorSpace.
739         (WebCore::setCGFillColor): Call new helper.
740         (WebCore::setCGStrokeColor): Call new helper.
741         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
742         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
743         (WebCore::GraphicsContext::setPlatformShadow):
744
745         Send appropriate ColorSpace to setShadow().
746         * platform/graphics/mac/FontMac.mm:
747         (WebCore::Font::drawGlyphs):
748         * rendering/EllipsisBox.cpp:
749         (WebCore::EllipsisBox::paint):
750         * rendering/InlineFlowBox.cpp:
751         (WebCore::InlineFlowBox::paintTextDecorations):
752         * rendering/InlineTextBox.cpp:
753         (WebCore::paintTextWithShadows):
754         (WebCore::InlineTextBox::paintDecoration):
755         * rendering/RenderBoxModelObject.cpp:
756         (WebCore::RenderBoxModelObject::paintBoxShadow):
757         * rendering/SVGInlineTextBox.cpp:
758         (WebCore::SVGInlineTextBox::paintCharacters):
759         * rendering/SVGRenderSupport.cpp:
760         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
761
762         Attempt to keep ports building.
763         * platform/graphics/cairo/GraphicsContextCairo.cpp:
764         (WebCore::GraphicsContext::setPlatformShadow):
765         * platform/graphics/qt/GraphicsContextQt.cpp:
766         (WebCore::GraphicsContext::setPlatformShadow):
767         * platform/graphics/skia/GraphicsContextSkia.cpp:
768         (WebCore::GraphicsContext::setPlatformShadow):
769         * platform/graphics/wince/GraphicsContextWince.cpp:
770         (WebCore::GraphicsContext::setPlatformShadow):
771         * platform/graphics/wx/GraphicsContextWx.cpp:
772         (WebCore::GraphicsContext::setPlatformShadow):
773
774 2009-11-11  Kent Tamura  <tkent@chromium.org>
775
776         Reviewed by Darin Adler.
777
778         Print the file text of a file upload control in DumpRenderTree for ease of tests.
779         https://bugs.webkit.org/show_bug.cgi?id=31195
780
781         * rendering/RenderFileUploadControl.cpp:
782         (WebCore::RenderFileUploadControl::paintObject):
783         (WebCore::RenderFileUploadControl::fileTextValue):
784         * rendering/RenderFileUploadControl.h:
785         (WebCore::RenderFileUploadControl::isFileUploadControl):
786         (WebCore::toRenderFileUploadControl):
787         * rendering/RenderObject.h:
788         (WebCore::RenderObject::isFileUploadControl):
789         * rendering/RenderTreeAsText.cpp:
790         (WebCore::operator<<):
791
792 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
793
794         Reviewed by Sam Weinig.
795
796         DOM Wrappers for some nodes may not be marked.
797         https://bugs.webkit.org/show_bug.cgi?id=31380
798
799         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
800         the wrapper for the current world only.  This means that wrappers may be GC'ed
801         prematurely, and properties lost.
802
803         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
804
805         * bindings/js/JSAttrCustom.cpp:
806         (WebCore::JSAttr::markChildren):
807         * bindings/js/JSDOMBinding.cpp:
808         (WebCore::markDOMNodeWrapper):
809         * bindings/js/JSDOMBinding.h:
810         * bindings/js/JSNamedNodeMapCustom.cpp:
811         (WebCore::JSNamedNodeMap::markChildren):
812         * bindings/js/JSNodeCustom.cpp:
813         (WebCore::JSNode::markChildren):
814         * bindings/js/JSSVGElementInstanceCustom.cpp:
815         (WebCore::JSSVGElementInstance::markChildren):
816         * bindings/js/JSStyleSheetCustom.cpp:
817         (WebCore::JSStyleSheet::markChildren):
818
819 2009-11-11  Ben Murdoch  <benm@google.com>
820
821         Reviewed by Darin Adler.
822
823         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
824         https://bugs.webkit.org/show_bug.cgi?id=31384
825
826         No functionality change so no tests required.
827
828         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
829
830 2009-11-11  Jens Alfke  <snej@chromium.org>
831
832         Reviewed by Dimitri Glazkov.
833
834         The Big De-Inlining. 450k code size reduction (32-bit x86.)
835         - Various inline functions in V8Binding.h made non-inline.
836         - Some renaming for consistency.
837         - New function createRawTemplate().
838         https://bugs.webkit.org/show_bug.cgi?id=31383
839
840         * bindings/scripts/CodeGeneratorV8.pm:
841         * bindings/v8/V8Binding.cpp:
842         (WebCore::v8DOMWrapperToNative):
843         (WebCore::v8ValueToWebCoreString):
844         (WebCore::v8ValueToAtomicWebCoreString):
845         (WebCore::toInt32):
846         (WebCore::toWebCoreString):
847         (WebCore::toWebCoreStringWithNullCheck):
848         (WebCore::toAtomicWebCoreStringWithNullCheck):
849         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
850         (WebCore::isUndefinedOrNull):
851         (WebCore::v8Boolean):
852         (WebCore::v8UndetectableString):
853         (WebCore::v8StringOrNull):
854         (WebCore::v8StringOrUndefined):
855         (WebCore::v8StringOrFalse):
856         (WebCore::v8StringToWebCoreString):
857         (WebCore::v8ExternalString):
858         (WebCore::createRawTemplate):  New function.
859         * bindings/v8/V8Binding.h:
860         (WebCore::v8DOMWrapperTo):
861         (WebCore::v8DOMWrapperToNode):
862         (WebCore::v8StringToWebCoreString):
863         (WebCore::v8StringToAtomicWebCoreString):
864
865 2009-11-11  Jens Alfke  <snej@chromium.org>
866
867         Reviewed by Dimitri Glazkov.
868
869         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
870         event-listener setter into a new subroutine transferHiddenDependency().
871         https://bugs.webkit.org/show_bug.cgi?id=31377
872
873         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
874         * bindings/v8/V8Utilities.cpp:
875         (WebCore::transferHiddenDependency):  New.
876         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
877
878 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
879
880         Reviewed by Beth Dakin.
881
882         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
883         because there is a CG bug preventing this from working.
884
885         * platform/graphics/cg/GraphicsContextCG.cpp:
886         (WebCore::sRGBColorSpaceRef):
887
888 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
889
890         Reviewed by Timothy Hatcher.
891
892         Check that if Storage panel exists before calling its methods
893
894         https://bugs.webkit.org/show_bug.cgi?id=31343
895
896         * inspector/front-end/inspector.js:
897         (WebInspector.addDatabase):
898         (WebInspector.addCookieDomain):
899         (WebInspector.addDOMStorage):
900         (WebInspector.updateDOMStorage):
901
902 2009-11-11  Jens Alfke  <snej@chromium.org>
903
904         Reviewed by Dimitri Glazkov.
905
906         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
907         times in the generated V8 bindings.
908         https://bugs.webkit.org/show_bug.cgi?id=31368
909
910         * bindings/v8/V8DOMWrapper.cpp:
911         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
912         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
913
914 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
915
916         Reviewed by Timothy Hatcher.
917
918         Display the correct summary in the web inspector for the shorthands
919         border-color, border-width, border-style, margin, and padding.
920         https://bugs.webkit.org/show_bug.cgi?id=7987
921
922         Test: fast/css/shorthands-four-values.html
923
924         * css/CSSMutableStyleDeclaration.cpp:
925         (WebCore::CSSMutableStyleDeclaration::get4Values):
926         Display the summary information in the same way the shorthand would be
927         specified in a css rule.
928
929 2009-11-11  Jens Alfke  <snej@chromium.org>
930
931         Reviewed by Dimitri Glazkov.
932
933         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
934         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
935         https://bugs.webkit.org/show_bug.cgi?id=31367
936
937         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
938
939 2009-11-11  Jens Alfke  <snej@chromium.org>
940
941         Reviewed by Dimitri Glazkov.
942
943         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
944
945         * bindings/v8/DOMData.cpp:
946         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
947             so it can be inlined by its caller.
948         * bindings/v8/DOMData.h:
949         * bindings/v8/MainThreadDOMData.cpp:
950         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
951         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
952         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
953             and getStore, which inline both calls together.
954         * bindings/v8/MainThreadDOMData.h:
955         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
956         * bindings/v8/V8DOMMap.cpp:
957         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
958
959 2009-11-11  Nate Chapin  <japhet@chromium.org>
960
961         Reviewed by Dimitri Glazkov.
962
963         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
964
965         https://bugs.webkit.org/show_bug.cgi?id=31357
966
967         * platform/KURLGoogle.cpp:
968         (WebCore::isSchemeFirstChar):
969         (WebCore::isSchemeChar):
970         (WebCore::KURL::hasPort):
971         (WebCore::KURL::removePort):
972         (WebCore::protocolIsValid):
973
974 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
975
976         Build fix, no reviewed.
977
978         Correct setPlatformFillColor and setPlatformStrokeColor calls
979         to match new ColorSpace-supporting signatures.
980
981         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
982           color space to the set[...]Color calls.
983
984 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
985
986         Reviewed by Sam Weinig.
987
988         https://bugs.webkit.org/show_bug.cgi?id=31327
989         Clean up SocketStreamHandleClient interface
990
991         No change in behavior.
992
993         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
994         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
995         the only client (WebSocketChannel), and it's not clear what this callback's semantics
996         should be.
997         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
998         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
999         For ResourceHandle, this method is called when the user cancels authentication sheet,
1000         not when something happens with the stream.
1001
1002         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1003         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1004
1005         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1006         callbacks have no real implementation yet.
1007
1008 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1009
1010         Reviewed by Eric Seidel.
1011
1012         Allow custom memory allocation control for the part of page directory in WebCore
1013         https://bugs.webkit.org/show_bug.cgi?id=31350
1014
1015         Inherits the following classes from Noncopyable because these are instantiated
1016         by 'new' and these are no need to be copyable:
1017
1018         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1019         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1020         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1021         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1022         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1023         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1024         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1025         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1026         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1027
1028         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1029         PropertyWrapper is instantiated by 'new' in 
1030         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1031
1032         * page/DragController.h:
1033         * page/EventHandler.h:
1034         * page/FocusController.h:
1035         * page/FrameView.cpp:
1036         * page/PluginHalter.h:
1037         * page/Settings.h:
1038         * page/UserScript.h:
1039         * page/UserStyleSheet.h:
1040         * page/XSSAuditor.h:
1041         * page/animation/AnimationBase.cpp:
1042
1043 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1044
1045         Reviewed by Kenneth Rohde Christiansen.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=31323
1048         Fix a few compiler warnings
1049
1050         No new tests as there is no new functionality.
1051
1052         * editing/htmlediting.cpp:
1053         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1054         parentheses to silence gcc 4.4 -Wparentheses warnings
1055
1056 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1057
1058         Reviewed by Mark Rowe.
1059
1060         Set m_hasPendingGeometryChange to true by default, so that
1061         at least one call to NPP_SetWindow is executed, which is
1062         needed by the DRT plugin testing framework.
1063
1064         * plugins/PluginView.cpp:
1065         (WebCore::PluginView::PluginView):
1066
1067 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1068
1069         Rubber-stamped by Kenneth Rohde Christiansen.
1070
1071         https://bugs.webkit.org/show_bug.cgi?id=31348
1072         [Qt] Remove unnecessary LUT creator from WebCore.pro
1073
1074         * WebCore.pro:
1075
1076 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1077
1078         Reviewed by Tor Arne Vestbø.
1079
1080         Introduce a function for querying the input method status
1081         in QWebPageClient.
1082
1083         * platform/qt/QWebPageClient.h:
1084
1085 2009-11-11  Benjamin Otte  <otte@gnome.org>
1086
1087         Reviewed by Jan Alonzo.
1088
1089         [GTK] Black artifacts in youtube.com/html5
1090
1091         Paint the video to the given size. It's the job of the callers to keep
1092         track of aspect ratio. RenderVideo.cpp does it for the <video>
1093         element.
1094         https://bugs.webkit.org/show_bug.cgi?id=30925
1095
1096         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1097         (WebCore::MediaPlayerPrivate::paint):
1098
1099 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1100
1101         Reviewed by Reviewed by Jan Alonzo.
1102
1103         https://bugs.webkit.org/show_bug.cgi?id=30901
1104         [Gtk] Need to de-lint the Atk a11y code
1105
1106         Cleaned up some missed capitalization style-guideline violations.
1107
1108         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1109
1110 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1111
1112         Reviewed by Eric Seidel.
1113
1114         [Qt] Make the default style background color valid.
1115         Currently the color is transparent but invalid, this causes
1116         list boxes in QtWebKit to be drawn with a black background
1117         since r49242.
1118         https://bugs.webkit.org/show_bug.cgi?id=31295
1119
1120         * rendering/style/RenderStyle.h:
1121         (WebCore::InheritedFlags::initialBackgroundColor):
1122         * rendering/style/StyleBackgroundData.cpp:
1123         (WebCore::StyleBackgroundData::StyleBackgroundData):
1124
1125 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1126
1127         Reviewed by Geoff Garen.
1128
1129         Simplify the ownership model for worlds - rather than having a pair of weak references
1130         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1131         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1132         back forward cache.
1133
1134         * WebCore.base.exp:
1135         * bindings/js/JSDOMBinding.cpp:
1136         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1137         * bindings/js/JSDOMBinding.h:
1138         (WebCore::DOMWrapperWorld::forgetDocument):
1139         * bindings/js/ScriptCachedFrameData.cpp:
1140         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1141         (WebCore::ScriptCachedFrameData::restore):
1142         (WebCore::ScriptCachedFrameData::clear):
1143         * bindings/js/ScriptCachedFrameData.h:
1144         * bindings/js/ScriptController.cpp:
1145         (WebCore::ScriptController::~ScriptController):
1146         (WebCore::ScriptController::clearWindowShell):
1147         (WebCore::ScriptController::initScript):
1148         (WebCore::ScriptController::updateDocument):
1149         * bindings/js/ScriptController.h:
1150
1151 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1152
1153         Reviewed by Darin Adler.
1154
1155         rename counter to makeCounterNode in RenderCounter.cpp
1156         https://bugs.webkit.org/show_bug.cgi?id=31289
1157
1158         No new test because this is just a small refactoring.
1159
1160         * rendering/RenderCounter.cpp:
1161         (WebCore::findPlaceForCounter):
1162         (WebCore::makeCounterNode):
1163         (WebCore::RenderCounter::originalText):
1164
1165 2009-11-10  Daniel Bates  <dbates@webkit.org>
1166
1167         Reviewed by Oliver Hunt.
1168
1169         https://bugs.webkit.org/show_bug.cgi?id=30754
1170
1171         Patch 2 of 2.
1172
1173         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1174         needed. This method fired a drag event whenever the mouse moved, but
1175         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1176         model independent of when the mouse moves. See "Among other changes..."
1177         in the change log for patch 1 for more details.
1178
1179         * WebCore.DragSupport.exp:
1180         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1181         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1182         * page/EventHandler.h:
1183
1184 2009-11-10  Daniel Bates  <dbates@webkit.org>
1185
1186         Reviewed by Oliver Hunt.
1187
1188         https://bugs.webkit.org/show_bug.cgi?id=30754
1189
1190         Patch 1 of 2.
1191
1192         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1193         the drag event should always fire before the dragover event.
1194
1195         In fixing this bug, this patch also makes our drag processing model
1196         conform to the HTML 5 spec.
1197
1198         Among the changes, this patch ensures that the drag event isn't fired outside
1199         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1200         Currently, the drag event is fired whenever the mouse button is down and the OS
1201         detects the mouse moved. But, as per the spec, the drag event should
1202         fire approx. every 350ms so long as the mouse button is down.
1203
1204         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1205
1206         * page/EventHandler.cpp:
1207         (WebCore::EventHandler::clear):
1208         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1209         Modified to determine when we are in the correct instance of EventHandler to service the drag
1210         and drop operation.
1211         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1212         into this method.
1213         (WebCore::EventHandler::cancelDragAndDrop):
1214         (WebCore::EventHandler::performDragAndDrop):
1215         (WebCore::EventHandler::clearDragState):
1216         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1217         we should fire both drag and dragover events or only the dragover event.
1218
1219 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1220
1221         Reviewed by Dimitri Glazkov.
1222
1223         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1224         https://bugs.webkit.org/show_bug.cgi?id=31301
1225
1226         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1227
1228         Allowed passing V8Proxy for the calling JS context:
1229         * bindings/v8/V8DOMWrapper.h:
1230         (WebCore::V8DOMWrapper::getXPathNSResolver):
1231         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1232         (WebCore::V8CustomXPathNSResolver::create):
1233         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1234         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1235         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1236         * bindings/v8/custom/V8DocumentCustom.cpp:
1237         (WebCore::CALLBACK_FUNC_DECL):
1238
1239 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1240
1241         Reviewed by Timothy Hatcher.
1242
1243         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1244         https://bugs.webkit.org/show_bug.cgi?id=29972.
1245
1246         Add methods for setting different parts of the URL in href attribute.
1247
1248         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1249                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1250                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1251                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1252                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1253                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1254                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1255
1256         * bindings/js/JSLocationCustom.cpp:
1257         (WebCore::JSLocation::setPort):
1258         * html/HTMLAnchorElement.cpp:
1259         (WebCore::parsePortFromStringPosition):
1260         (WebCore::HTMLAnchorElement::setHash):
1261         (WebCore::HTMLAnchorElement::setHost):
1262         (WebCore::HTMLAnchorElement::setHostname):
1263         (WebCore::HTMLAnchorElement::setPathname):
1264         (WebCore::HTMLAnchorElement::setPort):
1265         (WebCore::HTMLAnchorElement::setProtocol):
1266         (WebCore::HTMLAnchorElement::setSearch):
1267         * html/HTMLAnchorElement.h:
1268         * html/HTMLAnchorElement.idl:
1269         * loader/FrameLoader.cpp:
1270         (WebCore::FrameLoader::iconURL):
1271         * platform/KURL.cpp:
1272         (WebCore::KURL::removePort):
1273         (WebCore::KURL::setPort):
1274         (WebCore::KURL::prettyURL):
1275         (WebCore::protocolIsValid):
1276         * platform/KURL.h:
1277         (WebCore::KURL::canSetHostOrPort):
1278         (WebCore::KURL::canSetPathname):
1279         (WebCore::KURL::hasPort):
1280         * platform/network/soup/ResourceHandleSoup.cpp:
1281         (WebCore::):
1282
1283 2009-11-10  Nate Chapin  <japhet@chromium.org>
1284
1285         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1286
1287         * platform/chromium/PopupMenuChromium.cpp:
1288         (WebCore::PopupContainer::paintBorder):
1289         (WebCore::PopupListBox::paint):
1290         (WebCore::PopupListBox::paintRow):
1291         * platform/graphics/chromium/TransparencyWin.cpp:
1292         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1293         * platform/graphics/skia/GraphicsContextSkia.cpp:
1294         (WebCore::GraphicsContext::fillRect):
1295         (WebCore::GraphicsContext::fillRoundedRect):
1296         (WebCore::GraphicsContext::setPlatformFillColor):
1297         (WebCore::GraphicsContext::setPlatformStrokeColor):
1298         * rendering/RenderMediaControlsChromium.cpp:
1299         (WebCore::paintMediaSlider):
1300         (WebCore::paintMediaVolumeSlider):
1301         (WebCore::paintMediaTimelineContainer):
1302         * rendering/RenderThemeChromiumMac.mm:
1303         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1304
1305 2009-11-10  Brady Eidson  <beidson@apple.com>
1306
1307         Reviewed by Sam Weinig.
1308
1309         Repro crash saving pcmag.com article as a webarchive.
1310         <rdar://problem/7381219> and https://webkit.org/b/31322
1311
1312         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1313
1314         * css/CSSStyleSheet.cpp:
1315         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1316           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1317
1318 2009-11-10  Beth Dakin  <bdakin@apple.com>
1319
1320         Attempt 2 to fix Tiger build. No review needed.
1321
1322         * platform/graphics/cg/GraphicsContextCG.cpp:
1323         (WebCore::deviceRGBColorSpaceRef):
1324         (WebCore::sRGBColorSpaceRef):
1325
1326 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1327
1328         wx build fix. Changes needed after r50760.
1329
1330         * platform/graphics/wx/GraphicsContextWx.cpp:
1331         (WebCore::GraphicsContext::GraphicsContext):
1332         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1333         (WebCore::drawTextWithSpacing):
1334
1335 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1336
1337         Qt build fix.
1338
1339         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1340         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1341
1342 2009-11-10  Beth Dakin  <bdakin@apple.com>
1343
1344         Tiger build fix. No review needed.
1345
1346         * platform/graphics/cg/GraphicsContextCG.cpp:
1347         (WebCore::sRGBColorSpaceRef):
1348
1349 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1350
1351         Reviewed by Dan Bernstein.
1352
1353         https://bugs.webkit.org/show_bug.cgi?id=31312
1354         Decouple authentication panel callbacks from ResourceHandle
1355
1356         No change in functionality.
1357
1358         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1359         ResourceHandle as delegate.
1360
1361         * WebCore.vcproj/WebCore.vcproj:
1362         * platform/network/AuthenticationClient.h: Added.
1363         Added a new interface for listening to authentication panel notifications.
1364
1365         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1366         it wants with the project file.
1367
1368         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1369         interface class.
1370         (WebCore::AuthenticationClient::deref): Ditto.
1371
1372         * platform/network/ResourceHandle.h:
1373         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1374         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1375
1376         * platform/network/cf/AuthenticationCF.cpp:
1377         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1378         (WebCore::AuthenticationChallenge::platformCompare):
1379         * platform/network/cf/AuthenticationChallenge.h:
1380         (WebCore::AuthenticationChallenge::authenticationClient):
1381         * platform/network/chromium/AuthenticationChallenge.h:
1382         (WebCore::AuthenticationChallenge::authenticationClient):
1383         * platform/network/curl/AuthenticationChallenge.h:
1384         (WebCore::AuthenticationChallenge::authenticationClient):
1385         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1386
1387 2009-11-10  Beth Dakin  <bdakin@apple.com>
1388
1389        Second attempted gtk build fix. No review needed.
1390
1391         * html/canvas/CanvasStyle.cpp:
1392         (WebCore::CanvasStyle::applyStrokeColor):
1393
1394
1395 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1396
1397         Reviewed by Geoff Garen.
1398
1399         Fix back/forwards cache with JSC isolated worlds.
1400         https://bugs.webkit.org/show_bug.cgi?id=31310
1401         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1402
1403         Store the global object for all worlds, not just the normal world.
1404         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1405         so we can forget global objects if a world goes away.
1406
1407         * bindings/js/JSDOMBinding.cpp:
1408         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1409         * bindings/js/JSDOMBinding.h:
1410         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1411         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1412         * bindings/js/ScriptCachedFrameData.cpp:
1413         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1414         (WebCore::ScriptCachedFrameData::forgetWorld):
1415         (WebCore::ScriptCachedFrameData::domWindow):
1416         (WebCore::ScriptCachedFrameData::restore):
1417         (WebCore::ScriptCachedFrameData::clear):
1418         * bindings/js/ScriptCachedFrameData.h:
1419         * bindings/js/ScriptController.h:
1420
1421 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1422
1423         [Qt] Unreviewed buildfix after r50760.
1424
1425         * platform/graphics/qt/GraphicsContextQt.cpp:
1426         (WebCore::GraphicsContext::GraphicsContext):
1427
1428 2009-11-10  Beth Dakin  <bdakin@apple.com>
1429
1430         Attempted build fix. (No review needed.)
1431
1432         * GNUmakefile.am: Adding ColorSpace.h
1433
1434 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1435
1436         Reviewed by NOBODY - Build Fix.
1437
1438         Updated function calls to take a ColorSpace argument, passing
1439         in DeviceColorSpace for now - this should be fixed. Also added
1440         ColorSpace.h to WebCore project.
1441
1442         * WebCore.vcproj/WebCore.vcproj:
1443         * platform/graphics/win/FontCGWin.cpp:
1444         (WebCore::Font::drawGlyphs):
1445         * platform/graphics/win/GraphicsContextCGWin.cpp:
1446         (WebCore::GraphicsContext::GraphicsContext):
1447         * platform/win/PopupMenuWin.cpp:
1448         (WebCore::PopupMenu::paint):
1449         * platform/win/WebCoreTextRenderer.cpp:
1450         (WebCore::doDrawTextAtPoint):
1451         * rendering/RenderThemeSafari.cpp:
1452         (WebCore::RenderThemeSafari::paintMenuListButton):
1453
1454 2009-11-10  Jens Alfke  <snej@chromium.org>
1455
1456         Reviewed by Darin Adler.
1457
1458         Optimizations to Element::getAttribute
1459         https://bugs.webkit.org/show_bug.cgi?id=30926
1460
1461         * dom/Element.cpp:
1462         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1463         * dom/NamedAttrMap.cpp:
1464         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1465         * platform/text/PlatformString.h:
1466         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1467
1468 2009-11-10  Beth Dakin  <bdakin@apple.com>
1469
1470         Reviewed by Darin Adler.
1471
1472         Fix for <rdar://problem/7059710> 
1473         -and corresponding-
1474         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1475         color-correction for CSS colors
1476
1477         New exported symbol for GraphicsContext::fillColor() which now 
1478         accepts a ColorSpace as an optional parameter.
1479         * WebCore.base.exp:
1480
1481         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1482         * WebCore.xcodeproj/project.pbxproj:
1483
1484         Computed Style for -webkit-color-correction
1485         * css/CSSComputedStyleDeclaration.cpp:
1486         (WebCore::):
1487         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1488
1489         Parse -webkit-color-correction
1490         * css/CSSParser.cpp:
1491         (WebCore::CSSParser::parseValue):
1492
1493        Map CSS identifiers to the appropriate values of the ColorSpace enum
1494         * css/CSSPrimitiveValueMappings.h:
1495         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1496         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1497
1498         New property -webkit-color-correction
1499         * css/CSSPropertyNames.in:
1500
1501         Map -webkit-color-correction into the RenderStyle.
1502         * css/CSSStyleSelector.cpp:
1503         (WebCore::CSSStyleSelector::applyProperty):
1504
1505         Add new value sRGB.
1506         * css/CSSValueKeywords.in:
1507
1508         Comment out the reference to sRGB since it will now be inherited as 
1509         a value from CSSValueKeywords.
1510         * css/SVGCSSValueKeywords.in:
1511
1512         Definition of the ColorSpace enum.
1513         * platform/graphics/ColorSpace.h: Added.
1514         (WebCore::):
1515
1516         These functions all now take a ColorSpace as a parameter.
1517         * platform/graphics/GraphicsContext.cpp:
1518         (WebCore::GraphicsContext::setStrokeColor):
1519         (WebCore::GraphicsContext::setFillColor):
1520         (WebCore::GraphicsContext::drawHighlightForText):
1521
1522         Return the appropriate ColorSpace.
1523         (WebCore::GraphicsContext::strokeColorSpace):
1524         (WebCore::GraphicsContext::fillColorSpace):
1525
1526         These functions all call other functions which require a ColorSpace 
1527         as a parameter.
1528         (WebCore::GraphicsContext::setStrokePattern):
1529         (WebCore::GraphicsContext::setFillPattern):
1530         (WebCore::GraphicsContext::setStrokeGradient):
1531         (WebCore::GraphicsContext::setFillGradient):
1532
1533         All of the GraphicsContext functions that take a Color should now 
1534         also take a ColorSpace.
1535         * platform/graphics/GraphicsContext.h:
1536
1537         Added new member variables stokeColorSpace and fillColorSpace.
1538         * platform/graphics/GraphicsContextPrivate.h:
1539         (WebCore::GraphicsContextState::GraphicsContextState):
1540
1541         Attempt to keep the Cairo port building with all of the massive 
1542         changes to GraphicsContext.        
1543         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1544         (WebCore::GraphicsContext::fillRect):
1545         (WebCore::GraphicsContext::setPlatformFillColor):
1546         (WebCore::GraphicsContext::setPlatformStrokeColor):
1547         (WebCore::GraphicsContext::fillRoundedRect):
1548
1549         
1550         * platform/graphics/cg/GraphicsContextCG.cpp:
1551         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1552         CGColorSpaceRef for the sRGB color space.
1553         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1554         a CGColorSpaceRef for the device RGB color space.
1555
1556         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1557         sets the fill color to the specified color in the given ColorSpace.
1558         (WebCore::setCGStrokeColor): Same, but for stroke.
1559
1560         (WebCore::setCGFillColorSpace): New static to set the 
1561         CGFillColorSpace to the given ColorSpace
1562         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1563
1564         Send ColorSpaces when appropriate, set ColorSpaces when 
1565         appropriate, and check ColorSpaces when appropriate.
1566         (WebCore::GraphicsContext::GraphicsContext):
1567         (WebCore::GraphicsContext::drawRect):
1568         (WebCore::GraphicsContext::drawLine):
1569         (WebCore::GraphicsContext::fillPath):
1570         (WebCore::GraphicsContext::strokePath):
1571         (WebCore::GraphicsContext::fillRect):
1572         (WebCore::GraphicsContext::fillRoundedRect):
1573         (WebCore::GraphicsContext::strokeRect):
1574         (WebCore::GraphicsContext::drawLineForText):
1575         (WebCore::GraphicsContext::setPlatformStrokeColor):
1576         (WebCore::GraphicsContext::setPlatformFillColor):
1577
1578         Attempt to keep Haiku building.
1579         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1580         (WebCore::GraphicsContext::fillRect):
1581         (WebCore::GraphicsContext::fillRoundedRect):
1582         (WebCore::GraphicsContext::setPlatformStrokeColor):
1583         (WebCore::GraphicsContext::setPlatformFillColor):
1584
1585         Attempt to keep QT building.
1586         * platform/graphics/qt/GraphicsContextQt.cpp:
1587         (WebCore::GraphicsContext::fillRect):
1588         (WebCore::GraphicsContext::fillRoundedRect):
1589         (WebCore::GraphicsContext::setPlatformStrokeColor):
1590         (WebCore::GraphicsContext::setPlatformFillColor):
1591
1592         Attempt to keep Wince building.
1593         * platform/graphics/wince/GraphicsContextWince.cpp:
1594         (WebCore::GraphicsContext::fillRect):
1595         (WebCore::GraphicsContext::setPlatformFillColor):
1596         (WebCore::GraphicsContext::setPlatformStrokeColor):
1597         (WebCore::GraphicsContext::clearRect):
1598         (WebCore::GraphicsContext::fillRoundedRect):
1599         (WebCore::GraphicsContext::setPlatformShadow):
1600
1601         Attempt to keep WX building.
1602         * platform/graphics/wx/GraphicsContextWx.cpp:
1603         (WebCore::GraphicsContext::fillRect):
1604         (WebCore::GraphicsContext::fillRoundedRect):
1605         (WebCore::GraphicsContext::setPlatformStrokeColor):
1606         (WebCore::GraphicsContext::setPlatformFillColor):
1607
1608         Added functions colorSpace() and setColorSpace()
1609         * rendering/style/RenderStyle.h:
1610         (WebCore::InheritedFlags::colorSpace):
1611         (WebCore::InheritedFlags::setColorSpace):
1612
1613         The ColorSpace is stored here.
1614         * rendering/style/StyleRareInheritedData.cpp:
1615         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1616         (WebCore::StyleRareInheritedData::operator==):
1617         * rendering/style/StyleRareInheritedData.h:
1618
1619         All of these call sites call GraphicsContext functions which now 
1620         require ColorSpaces.
1621         * editing/SelectionController.cpp:
1622         (WebCore::SelectionController::paintCaret):
1623         * html/canvas/CanvasRenderingContext2D.cpp:
1624         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1625         * html/canvas/CanvasStyle.cpp:
1626         (WebCore::CanvasStyle::applyStrokeColor):
1627         (WebCore::CanvasStyle::applyFillColor):
1628         * inspector/InspectorController.cpp:
1629         (WebCore::drawOutlinedQuad):
1630         * page/FrameView.cpp:
1631         (WebCore::FrameView::paintContents):
1632         * platform/ScrollbarTheme.h:
1633         (WebCore::ScrollbarTheme::paintScrollCorner):
1634         * platform/ScrollbarThemeComposite.cpp:
1635         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1636         * platform/graphics/Image.cpp:
1637         (WebCore::Image::fillWithSolidColor):
1638         * platform/graphics/mac/FontMac.mm:
1639         (WebCore::Font::drawGlyphs):
1640         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1641         (WebCore::MediaPlayerPrivate::paint):
1642         * rendering/EllipsisBox.cpp:
1643         (WebCore::EllipsisBox::paint):
1644         * rendering/InlineFlowBox.cpp:
1645         (WebCore::InlineFlowBox::paintTextDecorations):
1646         * rendering/InlineTextBox.cpp:
1647         (WebCore::updateGraphicsContext):
1648         (WebCore::paintTextWithShadows):
1649         (WebCore::InlineTextBox::paint):
1650         (WebCore::InlineTextBox::paintSelection):
1651         (WebCore::InlineTextBox::paintCompositionBackground):
1652         (WebCore::InlineTextBox::paintDecoration):
1653         (WebCore::InlineTextBox::paintTextMatchMarker):
1654         (WebCore::InlineTextBox::paintCompositionUnderline):
1655         * rendering/InlineTextBox.h:
1656         * rendering/RenderBlock.cpp:
1657         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1658         (WebCore::RenderBlock::fillVerticalSelectionGap):
1659         (WebCore::RenderBlock::fillLeftSelectionGap):
1660         (WebCore::RenderBlock::fillRightSelectionGap):
1661         * rendering/RenderBoxModelObject.cpp:
1662         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1663         (WebCore::RenderBoxModelObject::paintBoxShadow):
1664         * rendering/RenderFileUploadControl.cpp:
1665         (WebCore::RenderFileUploadControl::paintObject):
1666         * rendering/RenderFrameSet.cpp:
1667         (WebCore::RenderFrameSet::paintColumnBorder):
1668         (WebCore::RenderFrameSet::paintRowBorder):
1669         * rendering/RenderImage.cpp:
1670         (WebCore::RenderImage::paintReplaced):
1671         * rendering/RenderLayer.cpp:
1672         (WebCore::RenderLayer::paintScrollCorner):
1673         (WebCore::RenderLayer::paintResizer):
1674         * rendering/RenderListBox.cpp:
1675         (WebCore::RenderListBox::paintItemForeground):
1676         (WebCore::RenderListBox::paintItemBackground):
1677         * rendering/RenderListMarker.cpp:
1678         (WebCore::RenderListMarker::paint):
1679         * rendering/RenderObject.cpp:
1680         (WebCore::RenderObject::drawLineForBoxSide):
1681         (WebCore::RenderObject::drawArcForBoxSide):
1682         * rendering/RenderReplaced.cpp:
1683         (WebCore::RenderReplaced::paint):
1684         * rendering/RenderScrollbarTheme.cpp:
1685         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1686         * rendering/RenderThemeMac.mm:
1687         (WebCore::RenderThemeMac::paintMenuListButton):
1688         * rendering/RenderView.cpp:
1689         (WebCore::RenderView::paintBoxDecorations):
1690         * rendering/RenderWidget.cpp:
1691         (WebCore::RenderWidget::paint):
1692         * rendering/SVGInlineTextBox.cpp:
1693         (WebCore::SVGInlineTextBox::paintSelection):
1694         * svg/graphics/SVGPaintServerGradient.cpp:
1695         (WebCore::SVGPaintServerGradient::setup):
1696         * svg/graphics/SVGPaintServerSolid.cpp:
1697         (WebCore::SVGPaintServerSolid::setup):
1698
1699 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1700
1701         Reviewed by Timothy Hatcher.
1702
1703         Web Inspector: Speed up syntax highlighter
1704         https://bugs.webkit.org/show_bug.cgi?id=31291
1705
1706         * inspector/front-end/SourceFrame.js:
1707         (WebInspector.SourceFrame.prototype._loaded):
1708         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1709         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1710         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1711         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1712         (WebInspector.CSSSourceSyntaxHighlighter):
1713         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1714
1715 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1716
1717         Reviewed by Eric Seidel.
1718
1719         Remove session storage setting
1720         https://bugs.webkit.org/show_bug.cgi?id=31279
1721
1722         Remove session storage from Settings.  It was added temporarily so we could
1723         disable it by default at runtime in Chromium.  We now disable these things in a
1724         different way, so it's time to remove it.  Qt also depended on this setting for
1725         a short period of time, but after talking to them we agreed that it should be
1726         removed.
1727
1728         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1729
1730         * page/DOMWindow.cpp:
1731         (WebCore::DOMWindow::sessionStorage):
1732         * page/Settings.cpp:
1733         (WebCore::Settings::Settings):
1734         * page/Settings.h:
1735
1736 2009-11-10  Dan Bernstein  <mitz@apple.com>
1737
1738         Reviewed by Eric Carlson and Darin Adler.
1739
1740         WebCore part of making full-screen video pause during scrubbing.
1741
1742         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1743         and HTMLMediaElement::endScrubbing().
1744
1745 2009-11-10  Anton Muhin  <antonm@chromium.org>
1746
1747         Reviewed by Adam Barth.
1748
1749         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1750         https://bugs.webkit.org/show_bug.cgi?id=31051
1751
1752         * bindings/v8/V8GCController.cpp:
1753         (WebCore::V8GCController::gcEpilogue):
1754         (WebCore::V8GCController::checkMemoryUsage):
1755         * bindings/v8/V8GCController.h:
1756         * bindings/v8/V8Proxy.cpp:
1757         (WebCore::V8Proxy::evaluate):
1758         (WebCore::V8Proxy::runScript):
1759         (WebCore::V8Proxy::callFunction):
1760
1761 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1762
1763         Reviewed by Darin Adler.
1764
1765         Allow custom memory allocation control for the part of loader directory in WebCore
1766         https://bugs.webkit.org/show_bug.cgi?id=31161
1767
1768         Inherits the following classes from Noncopyable because these are instantiated
1769         by 'new' and these are no need to be copyable:
1770
1771         class Request - WebCore/loader/loader.cpp:100
1772         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1773         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1774         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1775         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1776         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1777
1778         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1779         MainThreadBridge is instantiated by 'new' in 
1780         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1781
1782         ThreadableLoaderClient's inheriting has been changed to public.
1783
1784         * loader/ImageLoader.cpp:
1785         * loader/ProgressTracker.cpp:
1786         * loader/RedirectScheduler.cpp:
1787         * loader/Request.h:
1788         * loader/ThreadableLoaderClient.h:
1789         * loader/WorkerThreadableLoader.h:
1790         * loader/appcache/ApplicationCacheHost.h:
1791         * loader/appcache/ApplicationCacheStorage.h:
1792
1793 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1794
1795         Reviewed by Eric Seidel.
1796
1797         https://bugs.webkit.org/show_bug.cgi?id=31047
1798         [GTK] Failing test media/video-played-ranges-1.html
1799
1800         WebKit coding style fixes.
1801
1802         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1803         (WebCore::mediaPlayerPrivateMessageCallback):
1804         (WebCore::MediaPlayerPrivate::naturalSize):
1805         (WebCore::MediaPlayerPrivate::paint):
1806         (WebCore::mimeTypeCache):
1807
1808 2009-11-10  Oliver Hunt  <oliver@apple.com>
1809
1810         Remove build failure introduced by earlier build fix.
1811
1812         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1813
1814 2009-11-10  Oliver Hunt  <oliver@apple.com>
1815
1816         Is this the last build fix? grep tells me yes.
1817
1818         * bindings/v8/custom/V8DocumentCustom.cpp:
1819         (WebCore::CALLBACK_FUNC_DECL):
1820
1821 2009-11-10  Oliver Hunt  <oliver@apple.com>
1822
1823         Hopefully the last one.  Why aren't these autogenerated?
1824
1825         * bindings/v8/V8DOMWrapper.cpp:
1826         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1827         (WebCore::V8DOMWrapper::getTemplate):
1828         (WebCore::V8DOMWrapper::convertToV8Object):
1829
1830 2009-11-10  Oliver Hunt  <oliver@apple.com>
1831
1832         Another chrome build fix.
1833
1834         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1835         (WebCore::CALLBACK_FUNC_DECL):
1836
1837 2009-11-10  Oliver Hunt  <oliver@apple.com>
1838
1839         Yet another chrome buildfix
1840
1841         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1842         (WebCore::CALLBACK_FUNC_DECL):
1843         * bindings/v8/custom/V8WebGLArrayCustom.h:
1844         (WebCore::constructCanvasArray):
1845         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1846         (WebCore::CALLBACK_FUNC_DECL):
1847         (WebCore::INDEXED_PROPERTY_GETTER):
1848         (WebCore::INDEXED_PROPERTY_SETTER):
1849         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1850         (WebCore::CALLBACK_FUNC_DECL):
1851         (WebCore::INDEXED_PROPERTY_GETTER):
1852         (WebCore::INDEXED_PROPERTY_SETTER):
1853         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1854         (WebCore::CALLBACK_FUNC_DECL):
1855         (WebCore::INDEXED_PROPERTY_GETTER):
1856         (WebCore::INDEXED_PROPERTY_SETTER):
1857         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1858         (WebCore::CALLBACK_FUNC_DECL):
1859         (WebCore::vertexAttribAndUniformHelperf):
1860         (WebCore::uniformHelperi):
1861         (WebCore::uniformMatrixHelper):
1862         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1863         (WebCore::CALLBACK_FUNC_DECL):
1864         (WebCore::INDEXED_PROPERTY_GETTER):
1865         (WebCore::INDEXED_PROPERTY_SETTER):
1866         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1867         (WebCore::CALLBACK_FUNC_DECL):
1868         (WebCore::INDEXED_PROPERTY_GETTER):
1869         (WebCore::INDEXED_PROPERTY_SETTER):
1870         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1871         (WebCore::CALLBACK_FUNC_DECL):
1872         (WebCore::INDEXED_PROPERTY_GETTER):
1873         (WebCore::INDEXED_PROPERTY_SETTER):
1874         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1875         (WebCore::CALLBACK_FUNC_DECL):
1876         (WebCore::INDEXED_PROPERTY_GETTER):
1877         (WebCore::INDEXED_PROPERTY_SETTER):
1878
1879 2009-11-10  Oliver Hunt  <oliver@apple.com>
1880
1881         Chrome build fix.
1882
1883         * bindings/v8/V8Index.h:
1884
1885 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1886
1887         Reviewed by Reviewed by Jan Alonzo.
1888
1889         https://bugs.webkit.org/show_bug.cgi?id=30901
1890         [Gtk] Need to de-lint the Atk a11y code
1891
1892         Removal of various and sundry style-violating nits.
1893
1894         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1895
1896 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1897
1898         Reviewed by Jan Alonzo.
1899
1900         https://bugs.webkit.org/show_bug.cgi?id=31047
1901         [GTK] Failing test media/video-played-ranges-1.html
1902
1903         Fix playback rate setter by remembering the rate was changed. Also
1904         correctly handle reverse playback by doing a seek from end to
1905         beginning of the media.
1906
1907         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1908         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1909         (WebCore::MediaPlayerPrivate::currentTime):
1910         (WebCore::MediaPlayerPrivate::seek):
1911         (WebCore::MediaPlayerPrivate::hasAudio):
1912         (WebCore::MediaPlayerPrivate::setVolume):
1913         (WebCore::MediaPlayerPrivate::setRate):
1914         (WebCore::MediaPlayerPrivate::updateStates):
1915         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
1916
1917 2009-11-10  Oliver Hunt  <oliver@apple.com>
1918
1919         Reviewed by Maciej Stachowiak.
1920
1921         Rename 3D Canvas related classes to use WebGL prefix
1922         https://bugs.webkit.org/show_bug.cgi?id=29095
1923
1924         Automatic rename of all WebGL related types from Canvas* to
1925         WebGL* per more recent version of the WebGL spec.
1926
1927         Due to the automatic rename I've removed the 600+ line change list.
1928
1929 2009-11-09  Dirk Schulze  <krit@webkit.org>
1930
1931         Reviewed by Oliver Hunt.
1932
1933         SVG feDisplacementMap is not implemented
1934         [https://bugs.webkit.org/show_bug.cgi?id=31255]
1935
1936         This is the implementation of the SVG filter effect
1937         feDisplacementMap. 
1938
1939         Test: svg/filters/feDisplacementMap.svg
1940
1941         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
1942         (WebCore::FEDisplacementMap::apply):
1943
1944 2009-11-09  Kent Tamura  <tkent@chromium.org>
1945
1946         Reviewed by Darin Adler.
1947
1948         Add a comment about null strings and hash functions.
1949         https://bugs.webkit.org/show_bug.cgi?id=29118
1950
1951         * platform/text/StringHash.h:
1952
1953 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1954
1955         Reviewed by Darin Adler.
1956
1957         Compiler warnings in InspectorResource.h
1958         https://bugs.webkit.org/show_bug.cgi?id=29231
1959
1960         Fix compilation warnings by removing addition operation on an enum type.
1961
1962         * inspector/InspectorResource.h:
1963         (WebCore::InspectorResource::):
1964         (WebCore::InspectorResource::Changes::hasChange):
1965         (WebCore::InspectorResource::Changes::set):
1966         (WebCore::InspectorResource::Changes::setAll):
1967
1968 2009-11-09  Anders Carlsson  <andersca@apple.com>
1969
1970         Reviewed by Darin Adler and Dan Bernstein.
1971
1972         <rdar://problem/7328395>
1973         https://bugs.webkit.org/show_bug.cgi?id=31277
1974
1975         When an object tag's style changes (for example when child nodes are added/removed),
1976         reuse its Frame (if it has one) instead of creating multiple Frames.
1977
1978         Test: fast/dom/HTMLObjectElement/children-changed.html
1979
1980         * loader/FrameLoader.cpp:
1981         (WebCore::FrameLoader::requestObject):
1982
1983 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
1984
1985         Reviewed by Kenneth Rohde Christiansen.
1986
1987         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
1988         since adjustment of RW-section base address will be needed for all new symbian
1989         tool chains, specifically for arm and gcc compilation targets.
1990         Also, change target address to 0xE00000 to be sufficient for all targets.
1991
1992         * WebCore.pro:
1993
1994 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
1995
1996         Reviewed by Timothy Hatcher.
1997
1998         Web Inspector: Crash when inspecting
1999         WebCore\manual-tests\inspector\dom-mutation.html
2000
2001         https://bugs.webkit.org/show_bug.cgi?id=31259
2002
2003         * inspector/InspectorDOMAgent.cpp:
2004         (WebCore::InspectorDOMAgent::handleEvent):
2005
2006 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2007
2008         Reviewed by Kenneth Rohde Christiansen.
2009
2010         [Qt] Few classes have virtual functions but non-virtual destructor
2011         https://bugs.webkit.org/show_bug.cgi?id=31269
2012
2013         No new tests as there is no functional change.
2014
2015         * platform/qt/QWebPageClient.h:
2016         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2017
2018 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2019
2020         Reviewed by Kenneth Rohde Christiansen.
2021
2022         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2023         https://bugs.webkit.org/show_bug.cgi?id=31140
2024
2025         QtNetwork interprets null string as request to remove the header, not add it.
2026         Replace null values with empty values before passing them to QtNetwork.
2027
2028         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2029
2030         * platform/network/qt/ResourceRequestQt.cpp:
2031         (WebCore::ResourceRequest::toNetworkRequest):
2032
2033 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2034
2035         Reviewed by Kevin Ollivier.
2036
2037         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2038         simply ignored before resulting in transparent areas being black in PNG
2039         images for example.
2040         
2041         https://bugs.webkit.org/show_bug.cgi?id=30823
2042
2043         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2044         (WebCore::RGBA32Buffer::asNewNativeImage):
2045
2046 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2047
2048         Reviewed by Kenneth Rohde Christiansen.
2049
2050         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2051         https://bugs.webkit.org/show_bug.cgi?id=31040
2052
2053         No new tests as there is no functional change.
2054
2055         * dom/Document.cpp:
2056         (WebCore::Document::recalcStyleSelector):
2057         * editing/TextIterator.cpp:
2058         (WebCore::pushFullyClippedState):
2059         * editing/VisibleSelection.cpp:
2060         (WebCore::VisibleSelection::appendTrailingWhitespace):
2061         * html/HTMLLinkElement.cpp:
2062         (WebCore::HTMLLinkElement::process):
2063         * loader/RedirectScheduler.cpp:
2064         (WebCore::RedirectScheduler::mustLockBackForwardList):
2065         * loader/appcache/ApplicationCacheGroup.cpp:
2066         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2067         * platform/graphics/qt/FontCacheQt.cpp:
2068         (WebCore::FontPlatformDataCacheKey::computeHash):
2069         * rendering/RenderBlock.cpp:
2070         (WebCore::RenderBlock::handleRunInChild):
2071         * rendering/RenderBox.cpp:
2072         (WebCore::RenderBox::calcHeight):
2073         * rendering/RenderTextControlMultiLine.cpp:
2074         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2075         * rendering/style/RenderStyle.cpp:
2076         (WebCore::RenderStyle::diff):
2077         * svg/SVGAnimateElement.cpp:
2078         (WebCore::parseNumberValueAndUnit):
2079         * svg/SVGAnimationElement.cpp:
2080         (WebCore::SVGAnimationElement::startedActiveInterval):
2081         * svg/SVGPreserveAspectRatio.cpp:
2082         (WebCore::SVGPreserveAspectRatio::getCTM):
2083
2084 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2085
2086         Reviewed by Dimitri Glazkov.
2087
2088         Win chromium is slow to draw transparent texts
2089         https://bugs.webkit.org/show_bug.cgi?id=31258
2090
2091         Clip graphics context to reduce calculation.
2092
2093         No new tests because this change only affects performance.
2094
2095         * platform/graphics/chromium/FontChromiumWin.cpp:
2096         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2097         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2098
2099 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2100
2101         Reviewed by Darin Adler.
2102
2103         showTree(CounterNode*) generates too little info and has too many spaces.
2104         https://bugs.webkit.org/show_bug.cgi?id=31212
2105
2106         No new tests as the change has no functional effect it is just for
2107         improved debugging.
2108
2109         * rendering/CounterNode.cpp:
2110         (WebCore::showTreeAndMark):
2111         Changed to also show addresses of parent, next and previous
2112         siblings.
2113
2114 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2115
2116         Reviewed by Darin Adler.
2117
2118         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2119         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=31083
2122
2123         No new tests; implementation is unchanged.
2124
2125         * page/Frame.cpp:
2126         (WebCore::Frame::setUseSecureKeyboardEntry):
2127         * page/mac/FrameMac.mm:
2128
2129 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2130
2131         Reviewed by Jan Alonzo.
2132
2133         Make XP_UNIX tests consistent
2134         https://bugs.webkit.org/show_bug.cgi?id=31250
2135
2136         No new tests as there is no functional change.
2137
2138         * plugins/PluginView.cpp:
2139         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2140         instead of the value of the macro
2141
2142         * plugins/gtk/PluginViewGtk.cpp:
2143         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2144         defined instead of using the PLATFORM macro to be consistent
2145         (WebCore::PluginView::getValue): Ditto.
2146
2147 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2148
2149         Reviewed by Darin Adler.
2150
2151         Thunk to the main thread from ~Database to deref Database's m_document.
2152
2153         If the Database was the Document's last referrer, then ~Document occurs on the
2154         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2155         ASSERT in debug builds.
2156
2157         * storage/Database.cpp:
2158         (WebCore::derefDocument):
2159         (WebCore::Database::~Database):
2160
2161 2009-11-09  Mark Mentovai  <mark@chromium.org>
2162
2163         Reviewed by Dan Bernstein.
2164
2165         Track "can have scrollbar" state within FrameView independently of the
2166         individual scrollbar states in ScrollView.
2167
2168         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2169         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2170         edit mode.
2171
2172         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2173         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2174
2175         Test: fast/overflow/scrollbar-restored.html
2176
2177         * WebCore.base.exp:
2178         * page/FrameView.cpp:
2179         (WebCore::FrameView::FrameView):
2180         (WebCore::FrameView::resetScrollbars):
2181         (WebCore::FrameView::setCanHaveScrollbars):
2182         (WebCore::FrameView::updateCanHaveScrollbars):
2183         (WebCore::FrameView::layout):
2184         * page/FrameView.h:
2185         * platform/ScrollView.h:
2186
2187 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2188
2189         Reviewed by Timothy Hatcher.
2190
2191         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2192         https://bugs.webkit.org/show_bug.cgi?id=31257
2193
2194         * inspector/front-end/SourceFrame.js:
2195
2196 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2197
2198         Reviewed by Timothy Hatcher.
2199
2200         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2201         https://bugs.webkit.org/show_bug.cgi?id=31252
2202
2203         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2204
2205         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2206
2207         * inspector/front-end/ConsoleView.js:
2208         (WebInspector.ConsoleView.prototype._promptKeyDown):
2209         * inspector/front-end/utilities.js:
2210         ():
2211         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2212
2213 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2214
2215         Reviewed by Kenneth Rohde Christiansen.
2216
2217         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2218         https://bugs.webkit.org/show_bug.cgi?id=31208
2219
2220         After r42483, the credentials are no longer passed to the network request
2221         in the URL of the request.
2222         Pass the credentials from XMLHTTPRequest to the network request, the same
2223         way that other ports do.
2224
2225         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2226
2227         * platform/network/qt/ResourceHandleQt.cpp:
2228         (WebCore::ResourceHandle::start):
2229         (WebCore::ResourceHandle::loadResourceSynchronously):
2230
2231 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2232
2233         Unreviewed.
2234
2235         https://bugs.webkit.org/show_bug.cgi?id=31161
2236
2237         Roll back r50657 because it breaks the MAC builds.
2238
2239         * loader/ImageLoader.cpp:
2240         * loader/ProgressTracker.cpp:
2241         * loader/RedirectScheduler.cpp:
2242         * loader/Request.h:
2243         * loader/ThreadableLoaderClient.h:
2244         * loader/WorkerThreadableLoader.h:
2245         * loader/appcache/ApplicationCacheHost.h:
2246         * loader/appcache/ApplicationCacheStorage.h:
2247         * loader/icon/IconDatabaseClient.h:
2248
2249 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2250
2251         Reviewed by Darin Adler.
2252
2253         Allow custom memory allocation control for the part of loader directory in WebCore
2254         https://bugs.webkit.org/show_bug.cgi?id=31161
2255
2256         Inherits the following classes from Noncopyable because these are instantiated
2257         by 'new' and these are no need to be copyable:
2258
2259         class Request - WebCore/loader/loader.cpp:100
2260         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2261         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2262         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2263         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2264         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2265         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2266
2267         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2268         MainThreadBridge is instantiated by 'new' in 
2269         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2270
2271         ThreadableLoaderClient's inheriting has been changed to public.
2272
2273         * loader/ImageLoader.cpp:
2274         * loader/ProgressTracker.cpp:
2275         * loader/RedirectScheduler.cpp:
2276         * loader/Request.h:
2277         * loader/ThreadableLoaderClient.h:
2278         * loader/WorkerThreadableLoader.h:
2279         * loader/appcache/ApplicationCacheHost.h:
2280         * loader/appcache/ApplicationCacheStorage.h:
2281         * loader/icon/IconDatabaseClient.h:
2282
2283 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2284
2285         Reviewed by Darin Adler.
2286
2287         Allow custom memory allocation control for WebCore's DocLoader
2288         https://bugs.webkit.org/show_bug.cgi?id=31163
2289
2290         Inherits DocLoader class from Noncopyable because it is
2291         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2292         it is no need to be copyable.
2293
2294         * loader/DocLoader.h:
2295
2296 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2297
2298         Reviewed by Darin Adler.
2299
2300         Allow custom memory allocation control for WebCore's Tokenizer
2301         https://bugs.webkit.org/show_bug.cgi?id=31162
2302
2303         Inherits Tokenizer class from Noncopyable because (its child class)
2304         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2305         and it is no need to be copyable.
2306
2307         * dom/Tokenizer.h:
2308
2309 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2310
2311         Reviewed by Darin Adler.
2312
2313         Allow custom memory allocation control for WebCore's DeleteButtonController
2314         https://bugs.webkit.org/show_bug.cgi?id=31105
2315
2316         Inherits DeleteButtonController class from Noncopyable because it is 
2317         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2318         it is no need to be copyable.  
2319
2320         * editing/DeleteButtonController.h:
2321
2322 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2323
2324         Reviewed by Jan Alonzo.
2325
2326         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2327         https://bugs.webkit.org/show_bug.cgi?id=30482
2328
2329         Expose Page::tabKeyCyclesThroughElements as a property of
2330         WebKitWebView.
2331
2332         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2333
2334         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2335         (WebCore::singleCharacterString):
2336
2337 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2338
2339         Reviewed by Xan Lopez.
2340
2341         https://bugs.webkit.org/show_bug.cgi?id=25415
2342         [GTK][ATK] Please implement support for get_text_at_offset
2343
2344         Fix a crasher that occurred with text which included newline
2345         chars in the markup.
2346
2347         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2348         (convertUniCharToUTF8):
2349
2350 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2351
2352         Reviewed by Holger Freyther.
2353
2354         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2355         https://bugs.webkit.org/show_bug.cgi?id=31144
2356
2357         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2358         documents that end prematurely but are not considered invalid by QXmlStream.
2359         This is to stay compatible with the libxml2 implementation.
2360         However, that code path would be also hit in situations when it should not,
2361         i.e. the error would have already been caught and handled. As a result, the
2362         same error would be reported twice.
2363
2364         No new tests, because the problem is already covered by
2365         fast/parser/xml-declaration-missing-ending-mark.html.
2366
2367         * dom/XMLTokenizerQt.cpp:
2368         (WebCore::XMLTokenizer::doEnd):
2369
2370 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2371
2372         Reviewed by Pavel Feldman.
2373
2374         Web Inspector: Inspector should support copy() in the command line
2375         https://bugs.webkit.org/show_bug.cgi?id=31238
2376
2377         * inspector/InspectorBackend.cpp:
2378         (WebCore::InspectorBackend::copyText): Added.
2379         * inspector/InspectorBackend.h: Added copyText
2380         * inspector/InspectorBackend.idl: Added copyText
2381         * inspector/front-end/InjectedScript.js:
2382         (InjectedScript._copy): Added.
2383         (InjectedScript._ensureCommandLineAPIInstalled):
2384
2385 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2386
2387         Reviewed by Dimitri Glazkov.
2388
2389         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2390         https://bugs.webkit.org/show_bug.cgi?id=31226
2391
2392         Now checks to see what type of context is active and creates the
2393         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2394
2395         Added support for converting to SharedWorkers and SharedWorkerContexts.
2396
2397         Test: Existing layout tests cover this case (start passing in Chrome).
2398
2399         * bindings/v8/WorkerContextExecutionProxy.cpp:
2400         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2401         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2402         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2403         Added support for SHAREDWORKERCONTEXT.
2404         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2405         Added support for SharedWorker and SharedWorkerContext.
2406
2407 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2408
2409         Reviewed by Dimitri Glazkov.
2410
2411         https://bugs.webkit.org/show_bug.cgi?id=31224
2412         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2413
2414         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2415
2416         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2417         (WebCore::NAMED_PROPERTY_GETTER):
2418
2419 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2420
2421         Reviewed by Timothy Hatcher.
2422
2423         Web Inspector: "Search again" on scripts panel switches
2424         to the script this search started with.
2425
2426         https://bugs.webkit.org/show_bug.cgi?id=31243
2427
2428         * inspector/front-end/Panel.js:
2429         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2430
2431 2009-11-08  Kent Tamura  <tkent@chromium.org>
2432
2433         Reviewed by Darin Adler.
2434
2435         Simplify Icon interface.
2436         https://bugs.webkit.org/show_bug.cgi?id=31154
2437
2438         - Remove Icon::createIconForFile().  createIconForFiles() covers
2439           createIconForFile()'s role.
2440         - Remove FileChooser::chooseIcon()
2441         - Change the parameter types of FileChooser constructor and the
2442           factory method, String -> const Vector<String>&, in order to
2443           support initialization with multiple files.
2444         - Remove the icon loading code in IconChromiumWin.cpp, which
2445           doesn't work because of the sandbox.
2446
2447         No tests because it's just a refactoring.
2448
2449         * platform/FileChooser.cpp:
2450         (WebCore::FileChooser::FileChooser):
2451         (WebCore::FileChooser::create):
2452         (WebCore::FileChooser::chooseFile):
2453         (WebCore::FileChooser::chooseFiles):
2454         * platform/FileChooser.h:
2455         * platform/graphics/Icon.h:
2456         * platform/graphics/chromium/IconChromiumLinux.cpp:
2457         * platform/graphics/chromium/IconChromiumMac.cpp:
2458         * platform/graphics/chromium/IconChromiumWin.cpp:
2459         (WebCore::Icon::createIconForFiles):
2460         * platform/graphics/gtk/IconGtk.cpp:
2461         (WebCore::Icon::createIconForFiles):
2462         * platform/graphics/haiku/IconHaiku.cpp:
2463         * platform/graphics/mac/IconMac.mm:
2464         (WebCore::Icon::createIconForFiles):
2465         * platform/graphics/qt/IconQt.cpp:
2466         (WebCore::Icon::createIconForFiles):
2467         * platform/graphics/win/IconWin.cpp:
2468         (WebCore::Icon::createIconForFiles):
2469         * platform/graphics/wx/IconWx.cpp:
2470         * rendering/RenderFileUploadControl.cpp:
2471         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2472
2473 2009-11-08  Daniel Bates  <dbates@webkit.org>
2474
2475         Reviewed by Adam Barth.
2476
2477         https://bugs.webkit.org/show_bug.cgi?id=31098
2478
2479         Allows same-origin plugin-based content to load.
2480
2481         Test: http/tests/security/xssAuditor/object-src-inject.html
2482
2483         * page/XSSAuditor.cpp:
2484         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2485         (WebCore::XSSAuditor::canLoadObject): Ditto.
2486         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2487         (WebCore::XSSAuditor::isSameOriginResource): Added.
2488         * page/XSSAuditor.h:
2489
2490 2009-11-08  David Levin  <levin@chromium.org>
2491
2492         Reviewed by NOBODY (chromium build fix).
2493
2494         * platform/network/HTTPParsers.cpp:
2495         (WebCore::parseDate): Changed this to not
2496         use a date parser that needs ExecState passed.
2497         
2498 2009-11-08  David Levin  <levin@chromium.org>
2499
2500         Unreviewed build fix for chromium.
2501
2502         * platform/graphics/skia/GraphicsContextSkia.cpp:
2503         (WebCore::GraphicsContext::fillPath):
2504         (WebCore::GraphicsContext::fillRect):
2505         (WebCore::GraphicsContext::strokePath):
2506         (WebCore::GraphicsContext::strokeRect):
2507
2508 2009-11-08  David Levin  <levin@chromium.org>
2509
2510         Unreviewed build fix for chromium.
2511
2512         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2513         Clean up GraphicsContext's current concept of ColorSpace
2514
2515         * platform/graphics/skia/GraphicsContextSkia.cpp:
2516         (WebCore::GraphicsContext::fillPath):
2517         (WebCore::GraphicsContext::fillRect):
2518         (WebCore::GraphicsContext::strokePath):
2519         (WebCore::GraphicsContext::strokeRect):
2520
2521 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2522
2523         Reviewed by Timothy Hatcher.
2524
2525         Web Inspector: [REGRESSION] committing style edit
2526         clears elements panel selection.
2527
2528         https://bugs.webkit.org/show_bug.cgi?id=31242
2529
2530         * inspector/front-end/ElementsTreeOutline.js:
2531         (WebInspector.ElementsTreeOutline.prototype.update):
2532         * inspector/front-end/StylesSidebarPane.js:
2533         (WebInspector.StylePropertyTreeElement.prototype.):
2534         (WebInspector.StylePropertyTreeElement.prototype):
2535
2536 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2537
2538         Reviewed by Holger Freyther.
2539
2540         ResourceRequest to be class instead of struct
2541         https://bugs.webkit.org/show_bug.cgi?id=30670
2542
2543         Started as a compilation fix for Symbian where the compiler makes a distinction between
2544         class and struct in function argument signatures.
2545         Changed all forward declarations of ResourceRequest to have class in the forward
2546         declaration instead of struct and changed the definition of ResourceRequest to be class
2547         and added access qualifiers where missing. Additionally two references of friend
2548         struct ResourceRequestBase changed to class instead.
2549
2550         * history/HistoryItem.h:
2551         * inspector/InspectorController.h:
2552         * inspector/InspectorResource.h:
2553         * loader/DocumentThreadableLoader.h:
2554         * loader/FrameLoaderClient.h:
2555         * loader/MainResourceLoader.h:
2556         * loader/ResourceLoadNotifier.h:
2557         * loader/SubresourceLoader.h:
2558         * loader/SubresourceLoaderClient.h:
2559         * loader/ThreadableLoader.h:
2560         * loader/WorkerThreadableLoader.h:
2561         * loader/appcache/ApplicationCache.h:
2562         * loader/appcache/ApplicationCacheHost.h:
2563         * platform/CrossThreadCopier.h:
2564         * platform/network/ResourceHandle.h:
2565         * platform/network/ResourceHandleClient.h:
2566         * platform/network/ResourceRequestBase.h:
2567         * platform/network/cf/ResourceRequest.h:
2568         * platform/network/cf/ResourceRequestCFNet.h:
2569         * platform/network/chromium/ResourceRequest.h:
2570         * platform/network/curl/ResourceRequest.h:
2571         * platform/network/qt/ResourceRequest.h:
2572         * platform/network/soup/ResourceRequest.h:
2573         * xml/XMLHttpRequest.h:
2574
2575 2009-11-08  Dan Bernstein  <mitz@apple.com>
2576
2577         Reviewed by Simon Fraser.
2578
2579         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2580         below FrameView::layout
2581         https://bugs.webkit.org/show_bug.cgi?id=31093
2582
2583         Test: fast/block/positioning/relative-positioned-inline-container.html
2584
2585         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2586         to mark the object for layout, doing so without marking its ancestors.
2587         However, RenderBlock::skipLeadingWhitespace and
2588         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2589         positioned inline container, causing it to be marked for layout without
2590         ever going back to give it layout, and thus layout could end with a
2591         dirty object still in the tree, leading to all sorts of badness.
2592
2593         The fix is to revert setStaticY() to not marking the object dirty, and
2594         instead do it in the call sites that require it, which are in
2595         RenderBlock and RenderFlexibleBox.
2596
2597         * rendering/RenderBlock.cpp:
2598         (WebCore::RenderBlock::adjustPositionedBlock):
2599         * rendering/RenderFlexibleBox.cpp:
2600         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2601         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2602         * rendering/RenderLayer.cpp:
2603         * rendering/RenderLayer.h:
2604         (WebCore::RenderLayer::setStaticY):
2605
2606 2009-11-07  Daniel Bates  <dbates@webkit.org>
2607
2608         Reviewed by Darin Adler.
2609
2610         https://bugs.webkit.org/show_bug.cgi?id=20780
2611         
2612         Fixes an issue where the onchange event handler is not fired when the 
2613         input field is autocompleted.
2614         
2615         We cannot test this using DRT since DRT cannot emulate autocompletion.
2616         So, a manual-test is included.
2617
2618         Tests: manual-tests/autocompletion-fire-onchange.html
2619
2620         * manual-tests/autocompletion-fire-onchange.html: Added.
2621         * rendering/RenderTextControl.cpp:
2622         (WebCore::RenderTextControl::setInnerTextValue):
2623
2624 2009-11-07  Benjamin Otte  <otte@gnome.org>
2625
2626         Reviewed by Holger Freyther.
2627
2628         Mark redrawn areas on image surfaces as dirty.
2629
2630         This is required to conform to the Cairo API, but is currently only
2631         used by debugging tools like cairo-trace.
2632
2633         * platform/graphics/cairo/ImageBufferCairo.cpp:
2634         (WebCore::ImageBuffer::platformTransformColorSpace):
2635         (WebCore::putImageData):
2636
2637 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2638
2639         Reviewed by Xan Lopez.
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=30878
2642         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2643
2644         If the end_offset is -1, use the String length as the end_offset.
2645
2646         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2647         (webkit_accessible_text_get_text):
2648
2649 2009-11-06  Beth Dakin  <bdakin@apple.com>
2650
2651         Reviewed by Adele Peterson.
2652
2653         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2654         GraphicsContext's current concept of ColorSpace
2655
2656         ColorSpace is now called ColorType. The variables on the state we 
2657         appropriately re-named as well. I removed strokeColorSpace() and 
2658         fillColorSpace() from GraphicsContext since they were never called. 
2659
2660         * platform/graphics/GraphicsContext.cpp:
2661         (WebCore::GraphicsContext::setStrokeColor):
2662         (WebCore::GraphicsContext::setFillColor):
2663         (WebCore::GraphicsContext::setStrokePattern):
2664         (WebCore::GraphicsContext::setFillPattern):
2665         (WebCore::GraphicsContext::setStrokeGradient):
2666         (WebCore::GraphicsContext::setFillGradient):
2667         * platform/graphics/GraphicsContext.h:
2668         (WebCore::):
2669         * platform/graphics/GraphicsContextPrivate.h:
2670         (WebCore::GraphicsContextState::GraphicsContextState):
2671         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2672         (WebCore::GraphicsContext::fillPath):
2673         (WebCore::GraphicsContext::strokePath):
2674         * platform/graphics/cg/GraphicsContextCG.cpp:
2675         (WebCore::calculateDrawingMode):
2676         (WebCore::GraphicsContext::drawPath):
2677         (WebCore::GraphicsContext::fillPath):
2678         (WebCore::GraphicsContext::strokePath):
2679         (WebCore::GraphicsContext::fillRect):
2680         (WebCore::GraphicsContext::strokeRect):
2681         * platform/graphics/qt/GraphicsContextQt.cpp:
2682         (WebCore::GraphicsContext::fillPath):
2683         (WebCore::GraphicsContext::strokePath):
2684         (WebCore::GraphicsContext::fillRect):
2685         * platform/graphics/wince/GraphicsContextWince.cpp:
2686         (WebCore::GraphicsContext::fillPath):
2687         (WebCore::GraphicsContext::fillRect):
2688
2689 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2690
2691         Reviewed by Tim Hatcher.
2692
2693         Fixes <http://webkit.org/b/31177>.
2694         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2695         
2696         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2697         places in the inspector can use editing in DataGrid (added a FIXME for
2698         some stuff that needs to be generalized).
2699         
2700         Also added deleting functionality to DataGrid, and implemented it for
2701         Cookies and DOM Storage. The reason this patch is so big is because of
2702         the refactoring of editing code, which won't be used yet in a cross-datagrid
2703         way, but should be able to.
2704         
2705         Additionally, moved the callbacks members from DOMStorageDataGrid to
2706         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2707         make the architecture of DOM Storage look a lot more like the Cookies view.
2708         
2709         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2710         inspector from beeping at you when you delete an element.
2711
2712         * WebCore.gypi: Removed DOMStorageDataGrid.
2713         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2714         * inspector/front-end/CookieItemsView.js:
2715         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2716         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2717         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2718         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2719         * inspector/front-end/DOMStorageItemsView.js:
2720         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2721         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2722         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2723         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2724         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2725         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2726         * inspector/front-end/DataGrid.js:
2727         (WebInspector.DataGrid):
2728         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2729         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2730         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2731         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2732         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2733         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2734         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2735         * inspector/front-end/ElementsTreeOutline.js:
2736         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2737         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2738         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2739
2740 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2741
2742         Qt build fix: added an ExecState parameter.
2743
2744         * bridge/qt/qt_runtime.cpp:
2745         (JSC::Bindings::convertValueToQVariant):
2746         (JSC::Bindings::convertQVariantToValue):
2747
2748 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2749
2750         https://bugs.webkit.org/show_bug.cgi?id=31197
2751         Implemented a timezone cache not based on Mac OS X's notify_check API.
2752
2753         Updated for JavaScriptCore internal API change.
2754
2755         * bridge/qt/qt_runtime.cpp:
2756         (JSC::Bindings::convertValueToQVariant):
2757         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2758
2759         * platform/network/HTTPParsers.cpp:
2760         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2761         (This function probably shouldn't be using a JavaScript date parser
2762         to begin with, but oh well.)
2763
2764 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2765
2766         Reviewed by Adam Barth.
2767
2768         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2769         which affects Chromium only.
2770         
2771         Changes to V8HTMLDocumentCustom.cpp are as below:-
2772         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2773            there was no calling javascript context. We now check for this case
2774            and pass in NULL to the HTMLDocument::open function which can handle
2775            a NULL document parameter.
2776         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2777            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2778            anyway. We now check for this case and return a failure.
2779            
2780         Changes to V8DOMWindowCustom.cpp are as below:-
2781         1. Instead of failing the window.open call made by NPAPI for lack of a
2782            calling javascript context, we now use the entered context as the calling
2783            context.
2784
2785         Tests: plugins/document-open.html
2786                plugins/window-open.html
2787
2788         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2789         (WebCore::CALLBACK_FUNC_DECL):
2790         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2791         (WebCore::CALLBACK_FUNC_DECL):
2792
2793 2009-11-06  Steve Block  <steveblock@google.com>
2794
2795         Reviewed by Eric Seidel.
2796
2797         Geolocation error code UNKNOWN_ERROR is deprecated.
2798         https://bugs.webkit.org/show_bug.cgi?id=31184
2799
2800         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2801
2802         Updated fast/dom/Geolocation/error.html to test this.
2803
2804         * page/PositionError.h: Modified.
2805         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2806         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2807         * page/Geolocation.cpp: Modified.
2808         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2809         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2810         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2811
2812 2009-11-06  Dirk Schulze  <krit@webkit.org>
2813
2814         Reviewed by Nikolas Zimmermann.
2815
2816         feMorphology filter is not implemented
2817         [https://bugs.webkit.org/show_bug.cgi?id=5863]
2818
2819         The Implementation of feMorphology.
2820         
2821         Test: We have allready a test for feMorphology
2822               svg/W3C-SVG-1.1/filters-morph-01-f.svg
2823
2824         * svg/graphics/filters/SVGFEMorphology.cpp:
2825         (WebCore::FEMorphology::apply):
2826
2827 2009-11-06  Steve Block  <steveblock@google.com>
2828
2829         Reviewed by Eric Seidel.
2830
2831         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
2832         https://bugs.webkit.org/show_bug.cgi?id=31209
2833
2834         Build fix only. No new tests possible.
2835
2836         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
2837
2838 2009-11-06  Drew Wilson  <atwilson@chromium.org>
2839
2840         Reviewed by David Levin.
2841
2842         V8 bindings do not support SharedWorkers as event targets
2843         https://bugs.webkit.org/show_bug.cgi?id=31199
2844
2845         No new tests because existing layout tests suffice (they currently
2846         crash on Chromium)
2847
2848         * bindings/v8/V8DOMWrapper.cpp:
2849         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
2850         Added clause to create a DOM wrapper for SharedWorkers.
2851
2852 2009-11-06  Anton Muhin  <antonm@chromium.org>
2853
2854         Reviewed by Adam Barth.
2855
2856         Do not unnecessarly synchronzie in weak reference callbacks.
2857         https://bugs.webkit.org/show_bug.cgi?id=31191
2858
2859         * bindings/v8/DOMData.h:
2860         (WebCore::DOMData::handleWeakObject):
2861
2862 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
2863
2864         Reviewed by Pavel Feldman.
2865
2866         Fix resource content search.
2867         https://bugs.webkit.org/show_bug.cgi?id=31202
2868
2869         * inspector/front-end/AbstractTimelinePanel.js:
2870         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2871         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2872         * inspector/front-end/TimelinePanel.js:
2873         (WebInspector.TimelineGraph.prototype.refresh):
2874
2875 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
2876
2877         Reviewed by Eric Seidel.
2878
2879         Fix ASSERT(currentStyle = renderStyle()).
2880         https://bugs.webkit.org/show_bug.cgi?id=31152
2881
2882         * dom/Element.cpp:
2883         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
2884
2885 2009-11-05  Alpha Lam  <hclam@chromium.org>
2886
2887         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
2888
2889         * bindings/v8/V8GCController.cpp:
2890         (WebCore::V8GCController::gcEpilogue):
2891         * bindings/v8/V8GCController.h:
2892         * bindings/v8/V8Proxy.cpp:
2893         (WebCore::V8Proxy::evaluate):
2894         (WebCore::V8Proxy::runScript):
2895         (WebCore::V8Proxy::callFunction):
2896
2897 2009-11-05  Adam Barth  <abarth@webkit.org>
2898
2899         Reviewed by Sam Weinig.
2900
2901         Cross-domain access to stylesheet text should not be allowed
2902         https://bugs.webkit.org/show_bug.cgi?id=20527
2903
2904         Check whether whether the current document can read the cssRules from
2905         the style sheet.  Firefox throws a security error here, but we return
2906         null instead because that's what we usually do in these cases.
2907
2908         Test: http/tests/security/cannot-read-cssrules-redirect.html
2909               http/tests/security/cannot-read-cssrules.html
2910
2911         * css/CSSStyleSheet.cpp:
2912         (WebCore::CSSStyleSheet::cssRules):
2913
2914 2009-11-05  Steve Block  <steveblock@google.com>
2915
2916         Reviewed by Eric Seidel.
2917
2918         If the Geolocation service fails to start, invoke the error callback asynchronously.
2919         https://bugs.webkit.org/show_bug.cgi?id=28276
2920
2921         All Geolocation callbacks must be invoked asynchronously.
2922         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
2923
2924         No new tests possible with current LayoutTestController.
2925
2926         * page/Geolocation.cpp:
2927         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
2928         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
2929         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
2930
2931 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2932
2933         Reviewed by Eric Seidel.
2934
2935         Removed the "this is part of the KDE project" comments from 
2936         all *.h, *.cpp, *.idl, and *.pm files.
2937         
2938         https://bugs.webkit.org/show_bug.cgi?id=31167
2939         
2940         The maintenance and architecture page in the project wiki lists
2941         this as a task.
2942         
2943         This change includes no changes or additions to test cases 
2944         since the change affects only comments.
2945
2946         * bindings/scripts/CodeGeneratorV8.pm:
2947         * bindings/scripts/IDLParser.pm:
2948         * bindings/scripts/IDLStructure.pm:
2949         * css/CSSInheritedValue.cpp:
2950         * css/CSSInitialValue.cpp:
2951         * css/CSSMediaRule.cpp:
2952         * css/CSSNamespace.h:
2953         * css/CSSProperty.cpp:
2954         * css/CSSProperty.h:
2955         * css/CSSRuleList.cpp:
2956         * css/CSSRuleList.h:
2957         * css/CSSSelector.h:
2958         * css/CSSValueList.cpp:
2959         * css/FontValue.cpp:
2960         * css/MediaFeatureNames.cpp:
2961         * css/MediaFeatureNames.h:
2962         * css/Pair.h:
2963         * css/SVGCSSStyleSelector.cpp:
2964         * css/ShadowValue.cpp:
2965         * css/StyleSheet.cpp:
2966         * css/StyleSheetList.cpp:
2967         * css/maketokenizer:
2968         * dom/BeforeUnloadEvent.cpp:
2969         * dom/BeforeUnloadEvent.h:
2970         * dom/CSSMappedAttributeDeclaration.cpp:
2971         * dom/EventNames.cpp:
2972         * dom/EventTarget.cpp:
2973         * dom/MappedAttributeEntry.h:
2974         * dom/MouseRelatedEvent.h:
2975         * dom/RangeException.h:
2976         * dom/StyleElement.h:
2977         * dom/Tokenizer.h:
2978         * html/HTMLHeadElement.h:
2979         * html/HTMLHeadingElement.cpp:
2980         * html/HTMLHeadingElement.h:
2981         * html/HTMLHtmlElement.h:
2982         * html/HTMLImageLoader.h:
2983         * html/HTMLMetaElement.h:
2984         * html/HTMLModElement.cpp:
2985         * html/HTMLModElement.h:
2986         * html/HTMLOptionsCollection.cpp:
2987         * html/HTMLPlugInElement.cpp:
2988         * html/HTMLPreElement.cpp:
2989         * html/HTMLPreElement.h:
2990         * html/HTMLTableCellElement.cpp:
2991         * html/HTMLTableCellElement.h:
2992         * html/HTMLTableColElement.cpp:
2993         * html/HTMLTableColElement.h:
2994         * html/HTMLTablePartElement.cpp:
2995         * html/HTMLTablePartElement.h:
2996         * html/HTMLTitleElement.h:
2997         * page/MouseEventWithHitTestResults.h:
2998         * platform/StaticConstructors.h:
2999         * platform/text/AtomicStringImpl.h:
3000         * platform/text/qt/TextBreakIteratorQt.cpp:
3001         * rendering/AutoTableLayout.h:
3002         * rendering/CounterNode.cpp:
3003         * rendering/EllipsisBox.cpp:
3004         * rendering/EllipsisBox.h:
3005         * rendering/FixedTableLayout.cpp:
3006         * rendering/FixedTableLayout.h:
3007         * rendering/HitTestRequest.h:
3008         * rendering/HitTestResult.h:
3009         * rendering/InlineRunBox.h:
3010         * rendering/PointerEventsHitRules.cpp:
3011         * rendering/PointerEventsHitRules.h:
3012         * rendering/RenderBR.cpp:
3013         * rendering/RenderBR.h:
3014         * rendering/RenderButton.cpp:
3015         * rendering/RenderButton.h:
3016         * rendering/RenderFieldset.cpp:
3017         * rendering/RenderFrameSet.cpp:
3018         * rendering/RenderListItem.cpp:
3019         * rendering/RenderTableRow.cpp:
3020         * rendering/RenderView.h:
3021         * rendering/RootInlineBox.h:
3022         * rendering/SVGInlineTextBox.cpp:
3023         * rendering/SVGInlineTextBox.h:
3024         * rendering/TableLayout.h:
3025         * rendering/break_lines.h:
3026         * rendering/style/SVGRenderStyle.cpp:
3027         * rendering/style/SVGRenderStyle.h:
3028         * rendering/style/SVGRenderStyleDefs.cpp:
3029         * rendering/style/SVGRenderStyleDefs.h:
3030         * svg/GradientAttributes.h:
3031         * svg/LinearGradientAttributes.h:
3032         * svg/PatternAttributes.h:
3033         * svg/RadialGradientAttributes.h:
3034         * svg/SVGAElement.cpp:
3035         * svg/SVGAngle.idl:
3036         * svg/SVGAnimateColorElement.cpp:
3037         * svg/SVGAnimateColorElement.h:
3038         * svg/SVGAnimateElement.cpp:
3039         * svg/SVGAnimateElement.h:
3040         * svg/SVGAnimateTransformElement.h:
3041         * svg/SVGAnimatedPathData.cpp:
3042         * svg/SVGAnimatedPathData.h:
3043         * svg/SVGAnimatedPoints.cpp:
3044         * svg/SVGAnimatedPoints.h:
3045         * svg/SVGAnimationElement.cpp:
3046         * svg/SVGCircleElement.cpp:
3047         * svg/SVGClipPathElement.cpp:
3048         * svg/SVGColor.cpp:
3049         * svg/SVGColor.idl:
3050         * svg/SVGComponentTransferFunctionElement.cpp:
3051         * svg/SVGComponentTransferFunctionElement.h:
3052         * svg/SVGCursorElement.cpp:
3053         * svg/SVGDefsElement.cpp:
3054         * svg/SVGDescElement.cpp:
3055         * svg/SVGDescElement.h:
3056         * svg/SVGDocument.idl:
3057         * svg/SVGElement.idl:
3058         * svg/SVGElementInstanceList.cpp:
3059         * svg/SVGElementInstanceList.h:
3060         * svg/SVGEllipseElement.cpp:
3061         * svg/SVGExternalResourcesRequired.cpp:
3062         * svg/SVGFEBlendElement.cpp:
3063         * svg/SVGFEBlendElement.h:
3064         * svg/SVGFEColorMatrixElement.cpp:
3065         * svg/SVGFEColorMatrixElement.h:
3066         * svg/SVGFEComponentTransferElement.cpp:
3067         * svg/SVGFEComponentTransferElement.h:
3068         * svg/SVGFECompositeElement.cpp:
3069         * svg/SVGFECompositeElement.h:
3070         * svg/SVGFEFloodElement.cpp:
3071         * svg/SVGFEFloodElement.h:
3072         * svg/SVGFEFuncAElement.cpp:
3073         * svg/SVGFEFuncAElement.h:
3074         * svg/SVGFEFuncBElement.cpp:
3075         * svg/SVGFEFuncBElement.h:
3076         * svg/SVGFEFuncGElement.cpp:
3077         * svg/SVGFEFuncGElement.h:
3078         * svg/SVGFEFuncRElement.cpp:
3079         * svg/SVGFEFuncRElement.h:
3080         * svg/SVGFEGaussianBlurElement.cpp:
3081         * svg/SVGFEGaussianBlurElement.h:
3082         * svg/SVGFEImageElement.cpp:
3083         * svg/SVGFEMergeElement.cpp:
3084         * svg/SVGFEMergeElement.h:
3085         * svg/SVGFEMergeNodeElement.cpp:
3086         * svg/SVGFEOffsetElement.cpp:
3087         * svg/SVGFEOffsetElement.h:
3088         * svg/SVGFETileElement.cpp:
3089         * svg/SVGFETileElement.h:
3090         * svg/SVGFETurbulenceElement.cpp:
3091         * svg/SVGFETurbulenceElement.h:
3092         * svg/SVGFilterElement.cpp:
3093         * svg/SVGGElement.cpp:
3094         * svg/SVGGradientElement.cpp:
3095         * svg/SVGHKernElement.idl:
3096         * svg/SVGLangSpace.cpp:
3097         * svg/SVGLangSpace.h:
3098         * svg/SVGLength.cpp:
3099         * svg/SVGLength.h:
3100         * svg/SVGLength.idl:
3101         * svg/SVGLengthList.cpp:
3102         * svg/SVGLengthList.h:
3103         * svg/SVGLineElement.cpp:
3104         * svg/SVGLinearGradientElement.h:
3105         * svg/SVGList.h:
3106         * svg/SVGListTraits.h:
3107         * svg/SVGLocatable.h:
3108         * svg/SVGMaskElement.cpp:
3109         * svg/SVGMatrix.idl:
3110         * svg/SVGMetadataElement.cpp:
3111         * svg/SVGMetadataElement.h:
3112         * svg/SVGMetadataElement.idl:
3113         * svg/SVGNumber.idl:
3114         * svg/SVGNumberList.cpp:
3115         * svg/SVGNumberList.h:
3116         * svg/SVGPaint.cpp:
3117         * svg/SVGPathElement.cpp:
3118         * svg/SVGPathSeg.h:
3119         * svg/SVGPathSegArc.cpp:
3120         * svg/SVGPathSegArc.h:
3121         * svg/SVGPathSegClosePath.cpp:
3122         * svg/SVGPathSegClosePath.h:
3123         * svg/SVGPathSegCurvetoCubic.cpp:
3124         * svg/SVGPathSegCurvetoCubic.h:
3125         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3126         * svg/SVGPathSegCurvetoCubicSmooth.h:
3127         * svg/SVGPathSegCurvetoQuadratic.cpp:
3128         * svg/SVGPathSegCurvetoQuadratic.h:
3129         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3130         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3131         * svg/SVGPathSegLineto.cpp:
3132         * svg/SVGPathSegLineto.h:
3133         * svg/SVGPathSegLinetoHorizontal.cpp:
3134         * svg/SVGPathSegLinetoHorizontal.h:
3135         * svg/SVGPathSegLinetoVertical.cpp:
3136         * svg/SVGPathSegLinetoVertical.h:
3137         * svg/SVGPathSegMoveto.cpp:
3138         * svg/SVGPathSegMoveto.h:
3139         * svg/SVGPatternElement.cpp:
3140         * svg/SVGPoint.idl:
3141         * svg/SVGPointList.cpp:
3142         * svg/SVGPointList.h:
3143         * svg/SVGPolyElement.cpp:
3144         * svg/SVGPolygonElement.cpp:
3145         * svg/SVGPolygonElement.h:
3146         * svg/SVGPolylineElement.cpp:
3147         * svg/SVGPolylineElement.h:
3148         * svg/SVGPreserveAspectRatio.cpp:
3149         * svg/SVGPreserveAspectRatio.h:
3150         * svg/SVGRadialGradientElement.h:
3151         * svg/SVGRect.idl:
3152         * svg/SVGRectElement.cpp:
3153         * svg/SVGRenderingIntent.h:
3154         * svg/SVGSVGElement.idl:
3155         * svg/SVGScriptElement.cpp:
3156         * svg/SVGSetElement.cpp:
3157         * svg/SVGSetElement.h:
3158         * svg/SVGStopElement.cpp:
3159         * svg/SVGStringList.cpp:
3160         * svg/SVGStringList.h:
3161         * svg/SVGStylable.cpp:
3162         * svg/SVGStylable.h:
3163         * svg/SVGStyleElement.cpp:
3164         * svg/SVGStyleElement.h:
3165         * svg/SVGStyledElement.h:
3166         * svg/SVGStyledLocatableElement.cpp:
3167         * svg/SVGStyledLocatableElement.h:
3168         * svg/SVGStyledTransformableElement.cpp:
3169         * svg/SVGStyledTransformableElement.h:
3170         * svg/SVGSwitchElement.cpp:
3171         * svg/SVGSymbolElement.cpp:
3172         * svg/SVGTRefElement.cpp:
3173         * svg/SVGTSpanElement.cpp:
3174         * svg/SVGTSpanElement.h:
3175         * svg/SVGTests.h:
3176         * svg/SVGTextElement.cpp:
3177         * svg/SVGTextElement.h:
3178         * svg/SVGTextPathElement.cpp:
3179         * svg/SVGTextPositioningElement.cpp:
3180         * svg/SVGTextPositioningElement.h:
3181         * svg/SVGTitleElement.cpp:
3182         * svg/SVGTitleElement.h:
3183         * svg/SVGTransform.cpp:
3184         * svg/SVGTransform.h:
3185         * svg/SVGTransform.idl:
3186         * svg/SVGTransformList.cpp:
3187         * svg/SVGTransformList.h:
3188         * svg/SVGTransformable.h:
3189         * svg/SVGURIReference.h:
3190         * svg/SVGUnitTypes.h:
3191         * svg/SVGUseElement.cpp:
3192         * svg/SVGViewElement.cpp:
3193         * svg/SVGZoomAndPan.cpp:
3194         * svg/SVGZoomAndPan.h:
3195         * svg/SVGZoomEvent.cpp:
3196
3197 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3198
3199         Reviewed by Dimitri Glazkov.
3200
3201         REGRESSION Clean up security origin usage in DOM Storage.
3202         https://bugs.webkit.org/show_bug.cgi?id=31188
3203
3204         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3205         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3206
3207         Instead of having StorageAreaSync's constructor (which is called in the
3208         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3209         database identifier, simply have StorageAreaImpl pass the identifier into
3210         StorageAreaSync.
3211
3212         No test because there's no change in externally observable behavior.
3213
3214         * storage/StorageAreaImpl.cpp:
3215         (WebCore::StorageAreaImpl::StorageAreaImpl):
3216         * storage/StorageAreaImpl.h:
3217         * storage/StorageAreaSync.cpp:
3218         (WebCore::StorageAreaSync::create):
3219         (WebCore::StorageAreaSync::StorageAreaSync):
3220         * storage/StorageAreaSync.h:
3221
3222 2009-11-05  Scott Violet  <sky@google.com>
3223
3224         Reviewed by Dimitri Glazkov.
3225
3226         Need notification of scrolling frame
3227         https://bugs.webkit.org/show_bug.cgi?id=31145
3228
3229         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3230         the frame scrolls. This will be used to know when history state
3231         needs to be updated.
3232
3233         * loader/FrameLoaderClient.h:
3234         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3235         * page/FrameView.cpp:
3236         (WebCore::FrameView::valueChanged):
3237
3238 2009-11-05  Kenneth Russell  <kbr@google.com>
3239
3240         Reviewed by Dimitri Glazkov.
3241
3242         [V8] Update bindings to use new API for external arrays
3243         https://bugs.webkit.org/show_bug.cgi?id=31181
3244
3245         No new tests; covered by existing WebGL tests.
3246
3247         * bindings/v8/V8DOMWrapper.cpp:
3248         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3249         (WebCore::V8DOMWrapper::getTemplate):
3250         (WebCore::V8DOMWrapper::convertToV8Object):
3251         * bindings/v8/V8DOMWrapper.h:
3252         * bindings/v8/custom/V8CanvasArrayCustom.h:
3253         (WebCore::constructCanvasArray):
3254
3255 2009-11-05  Alpha Lam  <hclam@chromium.org>
3256
3257         Not reviewed, Chromium build fix.
3258
3259         50561 introduces a custom method for SVGMatrix, we need to implement
3260         this in V8.
3261
3262         * bindings/v8/custom/V8CustomBinding.h:
3263         Adding definition for V8SVGMatrixMultiply.
3264         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3265         (WebCore::CALLBACK_FUNC_DECL):
3266         Implement V8SVGMatrixMultiply according to the same method in JSC.
3267
3268 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3269
3270         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3271
3272         * page/DOMWindow.cpp:
3273         (WebCore::DOMWindow::sessionStorage):
3274         * page/Settings.cpp:
3275         (WebCore::Settings::Settings):
3276         (WebCore::Settings::setSessionStorageEnabled):
3277         * page/Settings.h:
3278         (WebCore::Settings::sessionStorageEnabled):
3279
3280 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3281
3282         Reviewed by Timothy Hatcher.
3283
3284         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3285
3286         https://bugs.webkit.org/show_bug.cgi?id=30884
3287
3288         Test: inspector/styles-iframe.html
3289
3290         * inspector/front-end/DOMAgent.js:
3291         (WebInspector.DOMNode):
3292         * inspector/front-end/InjectedScript.js:
3293         (InjectedScript.getStyles):
3294         (InjectedScript.getComputedStyle):
3295         (InjectedScript.addStyleSelector):
3296         * inspector/front-end/TestController.js:
3297         (WebInspector.TestController.prototype.notifyDone):
3298         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3299         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3300         (WebInspector.evaluateForTestInFrontend):
3301
3302 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3303
3304         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3305
3306         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3307         https://bugs.webkit.org/show_bug.cgi?id=31027
3308
3309         Tested by new fast/events/event-listener-map-rehash-crash.html.
3310
3311         EventListenerMap modified to store pointers to listener vectors:
3312         * dom/EventTarget.cpp:
3313         (WebCore::EventTargetData::~EventTargetData):
3314         (WebCore::EventTarget::addEventListener):
3315         (WebCore::EventTarget::removeEventListener):
3316         (WebCore::EventTarget::fireEventListeners):
3317         (WebCore::EventTarget::getEventListeners):
3318         (WebCore::EventTarget::removeAllEventListeners):
3319         * dom/EventTarget.h:
3320
3321         Usages updated after interface changes:
3322         * inspector/InspectorDOMAgent.cpp:
3323         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3324         * svg/SVGUseElement.cpp:
3325         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3326
3327 2009-11-05  Dan Kegel  <dank@chromium.org>
3328
3329         Reviewed by Dmitri Titov.
3330
3331         Add missing initialization for m_createdByParser.
3332         https://bugs.webkit.org/show_bug.cgi?id=31089
3333
3334         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3335
3336         * dom/ProcessingInstruction.cpp:
3337         (WebCore::ProcessingInstruction::ProcessingInstruction):
3338
3339 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3340
3341         Reviewed by Adam Barth.
3342
3343         DOM Storage runtime flag changes
3344         https://bugs.webkit.org/show_bug.cgi?id=30602
3345
3346         Part 2/2.
3347
3348         Revert my changes to Settings and instead implement DOM Storage enabling via
3349         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3350
3351         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3352         LayoutTest visible changes and thus no tests.
3353
3354         * bindings/v8/custom/V8CustomBinding.h:
3355         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3356         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3357         * page/DOMWindow.cpp:
3358         (WebCore::DOMWindow::sessionStorage):
3359         * page/DOMWindow.idl:
3360         * page/Settings.cpp:
3361         (WebCore::Settings::Settings):
3362         * page/Settings.h:
3363         * storage/Storage.cpp:
3364         (WebCore::Storage::setLocalStorageAvailable):
3365         (WebCore::Storage::localStorageAvailable):
3366         (WebCore::Storage::setSessionStorageAvailable):
3367         (WebCore::Storage::sessionStorageAvailable):
3368         * storage/Storage.h:
3369
3370 2009-11-05  Jian Li  <jianli@chromium.org>
3371
3372         Reviewed by Pavel Feldman.
3373
3374         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3375         https://bugs.webkit.org/show_bug.cgi?id=31108
3376
3377         * bindings/v8/V8AbstractEventListener.cpp:
3378         (WebCore::V8AbstractEventListener::invokeEventHandler):
3379         * bindings/v8/V8Utilities.cpp:
3380         (WebCore::reportException):
3381
3382 2009-11-05  Jian Li  <jianli@chromium.org>
3383
3384         Reviewed by Dmitri Titov.
3385
3386         We should not bubble up events if we drag something to an iframe that
3387         has an invalid source.
3388         https://bugs.webkit.org/show_bug.cgi?id=30469
3389
3390         Test: http/tests/misc/bubble-drag-events.html
3391
3392         * page/EventHandler.cpp:
3393         (WebCore::EventHandler::handleDragAndDropForTarget):
3394         (WebCore::EventHandler::updateDragAndDrop):
3395         (WebCore::EventHandler::cancelDragAndDrop):
3396         (WebCore::EventHandler::performDragAndDrop):
3397         * page/EventHandler.h:
3398         (WebCore::EventHandler::):
3399
3400 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3401
3402         Reviewed by Timothy Hatcher.
3403
3404         Web Inspector: speed up Timelines Clear by a factor of thousands.
3405
3406         https://bugs.webkit.org/show_bug.cgi?id=31160
3407
3408         * inspector/front-end/utilities.js:
3409         (Element.prototype.removeChildren):
3410
3411 2009-11-05  Anton Muhin  <antonm@chromium.org>
3412
3413         Reviewed by Adam Barth.
3414
3415         If high memory usage is detected, hint to V8 that it might be due
3416         to external objects retained by V8 objects.
3417         https://bugs.webkit.org/show_bug.cgi?id=31051
3418
3419         * bindings/v8/V8GCController.cpp:
3420         (WebCore::GetMemoryUsageInMB):
3421         (WebCore::V8GCController::gcEpilogue):
3422         (WebCore::V8GCController::checkMemoryUsage):
3423         * bindings/v8/V8GCController.h:
3424         * bindings/v8/V8Proxy.cpp:
3425         (WebCore::V8Proxy::evaluate):
3426         (WebCore::V8Proxy::runScript):
3427         (WebCore::V8Proxy::callFunction):
3428
3429 2009-11-05  Jeff Schiller  <codedread@gmail.com>
3430
3431         Reviewed by Simon Fraser.
3432
3433         Correct order of matrix multiplication for SVGMatrix.
3434         https://bugs.webkit.org/show_bug.cgi?id=16062
3435
3436         Test: svg/dom/SVGMatrix-interface.xhtml
3437
3438         * bindings/js/JSSVGMatrixCustom.cpp:
3439         (WebCore::JSSVGMatrix::multiply):
3440         * svg/SVGMatrix.idl:
3441
3442 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3443
3444         Reviewed by Timothy Hatcher.
3445
3446         Web Inspector: Make resource-related records in timeline
3447         actually take some time.
3448
3449         https://bugs.webkit.org/show_bug.cgi?id=31139
3450
3451         * English.lproj/localizedStrings.js:
3452         * inspector/front-end/TimelinePanel.js:
3453         (WebInspector.TimelinePanel):
3454         (WebInspector.TimelinePanel.prototype._formatRecord):
3455         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3456         (WebInspector.TimelinePanel.prototype.reset):
3457
3458 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3459
3460         Reviewed by Darin Fisher.
3461
3462         Simplify LocalStorageThread
3463         https://bugs.webkit.org/show_bug.cgi?id=30935
3464
3465         This is a re-submit of 50519.  LocalStorageTask should have never been ref
3466         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
3467
3468         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3469         of the method names a bit more clear. Assert proper thread usage. Join rather
3470         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3471         variables on the background thread when simple to do so.  Also create a generic
3472         scheduleTask function rather than one for each task.
3473
3474         No behavior should have changed.
3475
3476         * storage/LocalStorageTask.h:
3477         * storage/LocalStorageThread.cpp:
3478         (WebCore::LocalStorageThread::create):
3479         (WebCore::LocalStorageThread::LocalStorageThread):
3480         (WebCore::LocalStorageThread::~LocalStorageThread):
3481         (WebCore::LocalStorageThread::start):
3482         (WebCore::LocalStorageThread::threadEntryPointCallback):
3483         (WebCore::LocalStorageThread::threadEntryPoint):
3484         (WebCore::LocalStorageThread::scheduleTask):
3485         (WebCore::LocalStorageThread::terminate):
3486         (WebCore::LocalStorageThread::performTerminate):
3487         * storage/LocalStorageThread.h:
3488         * storage/StorageSyncManager.cpp:
3489         (WebCore::StorageSyncManager::StorageSyncManager):
3490         (WebCore::StorageSyncManager::~StorageSyncManager):
3491         (WebCore::StorageSyncManager::scheduleImport):
3492         (WebCore::StorageSyncManager::scheduleSync):
3493         * storage/StorageSyncManager.h:
3494
3495 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3496
3497         Reviewed by Darin Fisher.
3498
3499         Calling databaseIdentifier on LocalStorage's background thread is not safe.
3500         https://bugs.webkit.org/show_bug.cgi?id=31149
3501
3502         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
3503         is not safe.  databaseIdentifier does a bunch of string concatenation which
3504         ref-counts StringImpls in some cases.  This was caught by valgrind thread
3505         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
3506
3507         There's no way to test for such racyness, unfortunately.
3508
3509         * storage/StorageAreaSync.cpp:
3510         (WebCore::StorageAreaSync::StorageAreaSync):
3511         (WebCore::StorageAreaSync::performImport):
3512         * storage/StorageAreaSync.h:
3513         * storage/StorageSyncManager.cpp:
3514         (WebCore::StorageSyncManager::fullDatabaseFilename):
3515         * storage/StorageSyncManager.h:
3516
3517 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3518
3519         Reviewed by Darin Fisher.
3520
3521         Clean up StorageAreaSync
3522         https://bugs.webkit.org/show_bug.cgi?id=31100
3523
3524         Major fixes: Break the ref count cycle for StorageArea on the main
3525         thread, not the background thread since the latter is not safe.
3526         Length() needs to block on the import completing.
3527
3528         Small fixes: setItem needs to handle the copy on write case even if it
3529         has an exception.  setItem and removeItem should just bail from the
3530         the function if the value hasn't changed rather than wrapping the end
3531         in an if block.  Clear should only send an event if it wasn't already
3532         cleared.  StorageAreaSync should assert that the final sync was
3533         scheduled.
3534
3535         * storage/StorageAreaImpl.cpp:
3536         (WebCore::StorageAreaImpl::length):
3537           Forgot to block on the import.
3538         (WebCore::StorageAreaImpl::key):
3539         (WebCore::StorageAreaImpl::setItem):
3540           Handle the copy on write case even when there's an exception.
3541         (WebCore::StorageAreaImpl::removeItem):
3542         (WebCore::StorageAreaImpl::clear):
3543         * storage/StorageAreaSync.cpp:
3544         (WebCore::StorageAreaSync::~StorageAreaSync):
3545         (WebCore::StorageAreaSync::scheduleFinalSync):
3546         (WebCore::StorageAreaSync::performImport):
3547         (WebCore::StorageAreaSync::markImported):
3548         (WebCore::StorageAreaSync::blockUntilImportComplete):
3549         * storage/StorageAreaSync.h:
3550
3551 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
3552
3553         Reviewed by Eric Seidel.
3554
3555         Allow custom memory allocation control for WebCore's CachedResource
3556         https://bugs.webkit.org/show_bug.cgi?id=31114
3557
3558         Inherits CachedResource class from Noncopyable because its (its child
3559         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
3560         and it is no need to be copyable.
3561
3562         * loader/CachedResource.h:
3563
3564 2009-11-04  Mark Mentovai  <mark@chromium.org>
3565
3566         Reviewed by Mark Rowe.
3567
3568         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
3569         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
3570         which is true when targeting 10.6 or later.
3571
3572         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
3573         is present in the CGInterpolationQuality enum, and must be handled
3574         by a switch that has cases for each enumerated value.
3575
3576         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
3577         on 10.6 or later, and that CoreGraphics will understand when
3578         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
3579
3580         * platform/graphics/cg/GraphicsContextCG.cpp:
3581         (WebCore::GraphicsContext::setImageInterpolationQuality):
3582         (WebCore::GraphicsContext::imageInterpolationQuality):
3583
3584 2009-11-04  Dan Kegel  <dank@chromium.org>
3585
3586         Reviewed by Alexey Proskuryakov.
3587
3588         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
3589         https://bugs.webkit.org/show_bug.cgi?id=31138
3590
3591         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
3592
3593         * page/Page.cpp:
3594         (WebCore::Page::userStyleSheetLocationChanged):
3595
3596 2009-11-04  Timothy Hatcher  <timothy@apple.com>
3597
3598         Update the Web Inspector Timeline panel to better match the mock-up.
3599
3600         https://bugs.webkit.org/show_bug.cgi?id=31150
3601
3602         Reviewed by Pavel Feldman.
3603
3604         * inspector/front-end/TimelinePanel.js:
3605         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3606         (WebInspector.TimelinePanel.prototype._dragWindow):
3607         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3608         (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3609         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3610         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3611         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3612         (WebInspector.TimelineCategoryGraph):
3613         * inspector/front-end/inspector.css:
3614
3615 2009-11-05  Justin Garcia  <justin.garcia@apple.com>
3616
3617         Reviewed by Adele Peterson.
3618
3619         https://bugs.webkit.org/show_bug.cgi?id=25439
3620         Deleting when in front of a block image removes character from previous paragraph
3621
3622         Added editing/deleting/25439-{1,2,3}.html
3623
3624         * editing/DeleteSelectionCommand.cpp:
3625         (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot 
3626         be made inline with other content.  Instead of merging, just move the caret to just before 
3627         the selection we deleted.
3628         * editing/htmlediting.cpp:
3629         (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which 
3630         doesn't necessarily contain pos (suppose pos was [img, 0]).
3631         (WebCore::lastInSpecialElement): Ditto.
3632         (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
3633         * editing/htmlediting.h:
3634         * editing/visible_units.cpp:
3635         (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing 
3636         5027702 is now squarely in first/lastInSpecialElement
3637         (WebCore::endOfParagraph): Ditto.
3638