2009-11-13 Norbert Leser <norbert.leser&nokia.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
2
3         Reviewed by Eric Seidel.
4
5         Added macros for USERINCLUDE paths within symbian blocks
6         to guarantee inclusion of respective header files from local path
7         first (to avoid clashes with same names of header files in system include path).
8
9         * WebCore.pro:
10
11 2009-11-13  Hironori Bono  <hbono@chromium.org>
12
13         Reviewed by Oliver Hunt.
14
15         Implement composition events introduced in DOM Level 3.
16         This change adds a new IDL which defines the composition events, adds a class which
17         implements the composition events, and sends the composition events according to
18         the specification.
19         https://bugs.webkit.org/show_bug.cgi?id=26310
20
21         Test: fast/events/ime-composition-events-001.html
22
23         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
24         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
25         * WebCore.gypi: ditto.
26         * WebCore.pro: ditto
27         * WebCore.vcproj/WebCore.vcproj: ditto.
28         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
29         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
30         * bindings/js/JSEventCustom.cpp:
31         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
32         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
33         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
34         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
35         (WebCore::V8DOMWrapper::convertEventToV8Object):
36         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
37         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
38         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
39         (WebCore::CompositionEvent::CompositionEvent):
40         (WebCore::CompositionEvent::~CompositionEvent):
41         (WebCore::CompositionEvent::initCompositionEvent):
42         (WebCore::CompositionEvent::isCompositionEvent):
43         * dom/CompositionEvent.h: Declares the CompositionEvent class.
44         (WebCore::CompositionEvent::create):
45         (WebCore::CompositionEvent::data):
46         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
47         * dom/Event.cpp:
48         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
49         * dom/Event.h:
50         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
51         * editing/Editor.cpp:
52         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
53         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
54
55 2009-11-13  Jens Alfke  <snej@chromium.org>
56
57         Reviewed by Dimitri Glazkov.
58
59         Fix a link error in unofficial GCC 4.4 builds on Linux.
60         https://bugs.webkit.org/show_bug.cgi?id=31477
61
62         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
63
64 2009-11-13  Eric Seidel  <eric@webkit.org>
65
66         No review, build fix only.
67
68         Fix Debug build after http://trac.webkit.org/changeset/50960.
69
70         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
71         https://bugs.webkit.org/show_bug.cgi?id=31213
72
73         * rendering/CounterNode.cpp:
74         (WebCore::showTreeAndMark):
75         * rendering/RenderCounter.cpp:
76         (WebCore::destroyCounterNodeChildren):
77
78 2009-11-13  Dirk Schulze  <krit@webkit.org>
79
80         Reviewed by Gustavo Noronha.
81
82         [CAIRO] shadow support for Canvas and SVG
83         [https://bugs.webkit.org/show_bug.cgi?id=30960]
84
85         We currently fill a path with solid color instead of filling
86         a clipping path. This causes problems on some composite operators,
87         since Cairo modifies the area outside the path.
88         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
89
90         Thanks to Benjamin Otte for tracking the bug down.
91
92         * platform/graphics/cairo/GraphicsContextCairo.cpp:
93         (WebCore::setPlatformFill):
94
95 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
96
97         Reviewed by Dimitri Glazkov.
98
99         Adding Chromium's DatabaseTracker implementation.
100
101         https://bugs.webkit.org/show_bug.cgi?id=31440
102
103         * WebCore.gyp/WebCore.gyp:
104         * WebCore.gypi:
105         * storage/DatabaseTracker.h:
106         * storage/chromium/DatabaseTrackerChromium.cpp:
107         (WebCore::DatabaseTracker::fullPathForDatabase):
108         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
109         * storage/chromium/QuotaTracker.cpp:
110         (WebCore::QuotaTracker::updateDatabaseSize):
111         * storage/chromium/QuotaTracker.h:
112
113 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
114
115         Reviewed by Darin Adler.
116
117         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
118         https://bugs.webkit.org/show_bug.cgi?id=31213
119         Added tree navigation methods that permit full implementation of CSS2.1
120         counter feature without using recursion proportional to the counter
121         tree depth.
122         No new tests because I did not find any bug that is fixed by this
123         commit yet, this just reduces the size of the patch for 11031 and
124         helps respond to some concerns regarding that patch.
125
126         * rendering/CounterNode.cpp:
127         (WebCore::CounterNode::CounterNode):
128
129         (WebCore::CounterNode::nextInPreOrderAfterChildren):
130         (WebCore::CounterNode::nextInPreOrder):
131         Added to support non-recursive tree traversal necessary for
132         efficient full implementation of CSS2.1 counters.
133
134         (WebCore::CounterNode::lastDescendant):
135         (WebCore::CounterNode::previousInPreOrder):
136         Moved this methods such that they occupy a place similar to that of
137         identically named methods on the render tree. This allows for their
138         broader use needed in full implementation of CSS2.1 counters.
139
140         (WebCore::CounterNode::resetRenderer):
141         (WebCore::CounterNode::resetRenderers):
142         (WebCore::CounterNode::recount):
143         (WebCore::CounterNode::insertAfter):
144         (WebCore::CounterNode::removeChild):
145         Changed such that insertion/removal of a counter, triggers not only
146         recalculation of PrefixWidths, but also reassesment of values in
147         counter nodes. This is the basis full implementation of CSS2.1
148         counters. It does not change current behavior by much because of
149         changes needed to the recalculation algorithm, but those are comming
150         in the patch for 11031.
151         (WebCore::showTreeAndMark):
152         * rendering/CounterNode.h:
153         * rendering/RenderCounter.cpp:
154         (WebCore::counter):
155         Only changed argument type to prepare for implementation of Darin
156         Adler's recommendation for the patch to 11031.
157
158         (WebCore::RenderCounter::invalidate):
159         (WebCore::destroyCounterNodeChildren):
160         (WebCore::RenderCounter::destroyCounterNodes):
161         * rendering/RenderCounter.h:
162         * rendering/RenderObjectChildList.cpp:
163         (WebCore::invalidateCountersInContainer):
164         (WebCore::RenderObjectChildList::invalidateCounters):
165         * rendering/RenderObjectChildList.h:
166         Added the ability to restrict invalidation to counters with a given
167         identifier.
168         Also invalidated counters that are on the child container itself
169         which were missed by the previous algorithm, but were a valid case.
170
171 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
172
173         Reviewed by Dimitri Glazkov.
174
175         [V8] Protect SVG animated properties from destruction in bindings.
176         https://bugs.webkit.org/show_bug.cgi?id=31474
177
178         See http://crbug.com/26719.
179
180         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
181         under Valgrind.
182
183         Made sure we keep a reference to SVG properties while setting a
184         context:
185         * bindings/scripts/CodeGeneratorV8.pm:
186         * bindings/v8/V8Proxy.h:
187         (WebCore::V8Proxy::withSVGContext):
188
189 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
190
191         Reviewed by Alexey Proskuryakov.
192
193         [CAIRO] shadow support for Canvas and SVG.
194         [https://bugs.webkit.org/show_bug.cgi?id=30960]
195
196         Incorporate Benjamin Otte's recommendations to avoid
197         a buffer overrun, and small performance improvement.
198
199         * platform/graphics/cairo/GraphicsContextCairo.cpp:
200         (WebCore::copyContextProperties): Correctly size output
201          storage for cairo_get_dash to avoid buffer overrun.
202         (WebCore::drawPathShadow): Prefer cairo_fill_extents
203          to slower cairo_stroke_extents when not drawing shadows.
204
205 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
206
207         Reviewed by Dimitri Glazkov.
208
209         Do not register Chromium's HTML5 DB VFS as the default
210         VFS. Otherwise, other sqlite DB users in the same process will
211         stop working.
212
213         https://bugs.webkit.org/show_bug.cgi?id=31462
214
215         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
216         (WebCore::SQLiteFileSystem::openDatabase):
217         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
218         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
219         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
220         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
221
222 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
223
224         Windows build fix
225
226         * platform/network/cf/SocketStreamHandleCFNet.cpp:
227         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
228         avoiding a sign mismatch warning.
229
230 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
231
232         Release build fix.
233
234         * platform/network/cf/SocketStreamHandleCFNet.cpp:
235         (WebCore::SocketStreamHandle::readStreamCallback):
236         (WebCore::SocketStreamHandle::writeStreamCallback):
237         Use ASSERT_UNUSED for unused stream parameter.
238
239 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
240
241         Reviewed by Darin Adler.
242
243         https://bugs.webkit.org/show_bug.cgi?id=31441
244         Implement SocketStreamHandleCFNet
245
246         Existing WebSocket tests now pass on Mac. No proxy support yet.
247
248         * platform/network/SocketStreamHandleClient.h:
249         * platform/network/cf/SocketStreamHandle.h:
250         (WebCore::SocketStreamHandle::shouldUseSSL):
251         (WebCore::SocketStreamHandle::refAuthenticationClient):
252         (WebCore::SocketStreamHandle::derefAuthenticationClient):
253         (WebCore::SocketStreamHandle::):
254         * platform/network/cf/SocketStreamHandleCFNet.cpp:
255         (WebCore::SocketStreamHandle::SocketStreamHandle):
256         (WebCore::SocketStreamHandle::chooseProxy):
257         (WebCore::SocketStreamHandle::createStreams):
258         (WebCore::SocketStreamHandle::copyCFStreamDescription):
259         (WebCore::SocketStreamHandle::readStreamCallback):
260         (WebCore::SocketStreamHandle::writeStreamCallback):
261         (WebCore::SocketStreamHandle::~SocketStreamHandle):
262         (WebCore::SocketStreamHandle::platformSend):
263         (WebCore::SocketStreamHandle::platformClose):
264         (WebCore::SocketStreamHandle::receivedCredential):
265         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
266         (WebCore::SocketStreamHandle::receivedCancellation):
267
268 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
269
270         Reviewed by Timothy Hatcher.
271
272         Web Inspector: preload status bar button glyphs
273         in order to prevent them from flickering (take 2).
274
275         https://bugs.webkit.org/show_bug.cgi?id=31439
276
277         * inspector/front-end/inspector.js:
278         (preloadImages):
279
280 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
281
282         Reviewed by Adam Barth.
283
284         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
285         Rolling back r50890.
286
287         https://bugs.webkit.org/show_bug.cgi?id=31467
288
289         * bindings/v8/V8Proxy.cpp:
290         (WebCore::V8Proxy::canAccessPrivate):
291
292 2009-11-13  Dirk Schulze  <krit@webkit.org>
293
294         Reviewed by Gustavo Noronha.
295
296         [CAIRO] shadow support for Canvas and SVG
297         [https://bugs.webkit.org/show_bug.cgi?id=30960]
298         
299         This is the fix of a regression, caused by the shadow patch
300         from the bug above. Reinserted the save and restore calls
301         that were accidently removed by the previous patch.
302
303         * platform/graphics/cairo/GraphicsContextCairo.cpp:
304         (WebCore::setPlatformFill):
305         (WebCore::setPlatformStroke):
306
307 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
308
309         Not reviewed. Reverting r50908 since it makes inspector tests
310         time out.
311
312         https://bugs.webkit.org/show_bug.cgi?id=31439
313
314         * inspector/front-end/inspector.js:
315
316 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
317
318         Reviewed by Timothy Hatcher.
319
320         Enable 'console.profile()' and 'console.profileEnd()'
321         regardless of JAVASCRIPT_DEBUGGER.
322
323         https://bugs.webkit.org/show_bug.cgi?id=31293
324
325         * WebCore.gypi:
326         * bindings/js/JSConsoleCustom.cpp:
327         (WebCore::JSConsole::profile):
328         (WebCore::JSConsole::profileEnd):
329         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
330         (WebCore::CALLBACK_FUNC_DECL):
331         * bindings/v8/custom/V8CustomBinding.h:
332         * page/Console.idl:
333
334 2009-11-12  David Levin  <levin@chromium.org>
335
336         Reviewed by NOBODY.
337
338         Chromium build fix.
339
340         * bindings/v8/ScriptController.h:
341         (WebCore::ScriptController::evaluateInWorld): Add a dummy
342          method which isn't called in chromium to make things compile.
343
344 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
345
346         Reviewed by Adam Barth.
347         
348         The document-open.html test was flaky at times. The test invokes the layout test plugin
349         which in its destroy stream handler opens a new document. This basically tears down the
350         stream and the associated plugin instance, which causes a crash when the plugin stream
351         dereferences an invalid m_client pointer which points to the PluginView instance which
352         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
353         and check for the same.
354        
355         https://bugs.webkit.org/show_bug.cgi?id=31067
356
357         * plugins/PluginStream.cpp:
358         (WebCore::PluginStream::stop):
359         (WebCore::PluginStream::destroyStream):
360
361 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
362
363         Reviewed by Dimitri Glazkov.
364
365         Renaming some parameters passed to DB-related methods to better
366         indicate their purpose.
367
368         https://bugs.webkit.org/show_bug.cgi?id=31449
369
370         * platform/chromium/ChromiumBridge.h:
371
372 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
373
374         Reviewed by Dan Bernstein.
375
376         Transformed reflected elements are clipped inside element with opacity
377         https://bugs.webkit.org/show_bug.cgi?id=30957
378         
379         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
380         each clip rect into painting space before taking the unions. This, however, did not work
381         correctly with combinations of reflections and transforms. Fixed by unioning the
382         clipRect and mapping through transforms along the way.
383         
384         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
385         where the transparency layers are.
386
387         Test: fast/reflections/opacity-reflection-transform.html
388
389         * rendering/RenderLayer.cpp:
390         (WebCore::expandClipRectForDescendantsAndReflection):
391         (WebCore::transparencyClipBox):
392         (WebCore::RenderLayer::beginTransparencyLayers):
393
394 2009-11-12  Adam Barth  <abarth@webkit.org>
395
396         Reviewed by Darin Fisher.
397
398         Improve SecurityOrigin::toString comment
399         https://bugs.webkit.org/show_bug.cgi?id=31041
400
401         * page/SecurityOrigin.h:
402
403 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
404
405         Reviewed by Darin Adler.
406
407         externalRepresentation should take Frame as the argument
408         https://bugs.webkit.org/show_bug.cgi?id=31393
409
410         No new tests as this is just a refactoring.
411
412         * WebCore.base.exp:
413         * rendering/RenderTreeAsText.cpp:
414         (WebCore::externalRepresentation):
415         * rendering/RenderTreeAsText.h:
416
417 2009-11-12  Ben Murdoch  <benm@google.com>
418
419         Reviewed by Dimitri Glazkov.
420
421         [Android] The Android specific files in page/Android are out of date.
422         https://bugs.webkit.org/show_bug.cgi?id=31437
423
424         No tests required.
425
426         * page/android/DragControllerAndroid.cpp:
427         (WebCore::DragController::dragOperation): Added.
428         (WebCore::DragController::cleanupAfterSystemDrag):
429         * page/android/EventHandlerAndroid.cpp:
430         (WebCore::EventHandler::accessKeyModifiers): Added.
431         * page/android/InspectorControllerAndroid.cpp: Removed.
432
433 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
434
435         Reviewed by Simon Fraser.
436
437         [CAIRO] shadow support for Canvas and SVG.
438         [https://bugs.webkit.org/show_bug.cgi?id=30960]
439
440         Implement Canvas/SVG shadow support for Cairo.  This patch
441         uses the filter code from SVG Filters.  That means that it is
442         necessary to activate filters to see the shadows.
443
444         Test: fast/canvas/canvas-shadow.html
445
446         * GNUmakefile.am:
447         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
448         * platform/graphics/GraphicsContext.h:
449         * platform/graphics/cairo/GraphicsContextCairo.cpp:
450         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
451         (WebCore::setPlatformFill):
452         (WebCore::setPlatformStroke):
453         (WebCore::copyContextProperties):
454         (WebCore::drawPathShadow):
455         (WebCore::GraphicsContext::fillPath):
456         (WebCore::GraphicsContext::strokePath):
457         (WebCore::GraphicsContext::drawPath):
458         (WebCore::GraphicsContext::setPlatformShadow):
459         (WebCore::GraphicsContext::createPlatformShadow):
460         * platform/graphics/cairo/ImageCairo.cpp:
461         (WebCore::BitmapImage::draw): Add filter effect.
462         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
463         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
464         * platform/graphics/filters/ImageBufferFilter.h: Added.
465         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
466         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
467
468 2009-11-12  Dmitry Titov  <dimich@chromium.org>
469
470         Reviewed by Alexey Proskuryakov.
471
472         Add postTaskToMainThread to ScriptExecutionContext.
473         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
474         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
475         contexts that live on the main thread.
476         https://bugs.webkit.org/show_bug.cgi?id=31427
477
478         No new tests - simply moving the code.
479
480         * dom/Document.cpp:
481         (WebCore::Document::postTask):
482         * dom/ScriptExecutionContext.cpp:
483         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
484         (WebCore::ScriptExecutionContextTaskTimer::fired):
485         (WebCore::PerformTaskData::PerformTaskData):
486         (WebCore::PerformTaskData::performTask):
487         (WebCore::ScriptExecutionContext::postTaskToMainThread):
488         * dom/ScriptExecutionContext.h:
489
490 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
491
492         Reviewed by Darin Adler.
493
494         Fix crash when removing compositing layers when GC is enabled
495         https://bugs.webkit.org/show_bug.cgi?id=31429
496
497         Workaround <rdar://problem/7390716> by special-casing the removal
498         of all sublayers when GC is enabled.
499
500         * platform/graphics/mac/GraphicsLayerCA.mm:
501         (WebCore::safeSetSublayers):
502         (WebCore::GraphicsLayerCA::updateSublayerList):
503         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
504
505 2009-11-12  Jens Alfke  <snej@chromium.org>
506
507         Reviewed by Dimitri Glazkov.
508
509         The last of the V8 binding optimizations.
510         - Replace string-valued element accessors with a shared getter/setter function.
511         - Change error handling flow of control to avoid extra branches and function calls.
512         https://bugs.webkit.org/show_bug.cgi?id=31443
513         
514         * bindings/scripts/CodeGeneratorV8.pm:
515         * bindings/v8/V8Binding.cpp:
516         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
517         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
518         * bindings/v8/V8Binding.h:
519
520 2009-11-12  Sam Weinig  <sam@webkit.org>
521
522         Reviewed by Oliver Hunt.
523
524         Fix for <rdar://problem/7267951>
525         Canvas methods should reject uses of NaN and Infinity.
526
527         Test: fast/canvas/canvas-with-illegal-args.html
528
529         * html/canvas/CanvasRenderingContext2D.cpp:
530         (WebCore::CanvasRenderingContext2D::scale):
531         (WebCore::CanvasRenderingContext2D::rotate):
532         (WebCore::CanvasRenderingContext2D::translate):
533         (WebCore::CanvasRenderingContext2D::transform):
534         (WebCore::CanvasRenderingContext2D::setTransform):
535
536 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
537
538         Reviewed by Timothy Hatcher.
539
540         Web Inspector: profile timeline panel, fix obvious problems.
541
542         https://bugs.webkit.org/show_bug.cgi?id=31432
543
544         * inspector/front-end/AbstractTimelinePanel.js:
545         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
546         * inspector/front-end/TimelinePanel.js:
547         (WebInspector.TimelinePanel.prototype._setWindowPosition):
548         (WebInspector.TimelineCalculator):
549         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
550         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
551         (WebInspector.TimelineCalculator.prototype.reset):
552         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
553         (WebInspector.TimelineCalculator.prototype.formatValue):
554         (WebInspector.TimelineGraph):
555         (WebInspector.TimelineGraph.prototype.refresh):
556         * inspector/front-end/utilities.js:
557         (Element.prototype.hasStyleClass):
558
559 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
560
561         Reviewed by Timothy Hatcher.
562
563         Web Inspector: preload status bar button glyphs
564         in order to prevent them from flickering.
565
566         https://bugs.webkit.org/show_bug.cgi?id=31439
567
568         * inspector/front-end/inspector.js:
569         (preloadImages):
570
571 2009-11-12  Adam Roben  <aroben@apple.com>
572
573         Replace worldIDs with world objects
574
575         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
576         user scripts/stylesheets and isolated worlds
577
578         Reviewed by Sam Weinig.
579
580         Covered by existing tests.
581
582         * WebCore.base.exp: Update exported symbols to match what now exists
583         and is needed by WebKit.
584
585         * bindings/js/ScheduledAction.cpp:
586         (WebCore::ScheduledAction::execute): Updated for function rename.
587
588         * bindings/js/ScriptController.cpp: Removed code that dealt with
589         worldIDs.
590         (WebCore::ScriptController::createWorld): Added. Returns a new world
591         suitable for use on the main thread.
592         (WebCore::ScriptController::executeScriptInWorld): Renamed from
593         executeScriptInIsolatedWorld, since this works just fine with a
594         "normal" world.
595
596         * bindings/js/ScriptController.h: Added createWorld, removed functions
597         that took worldIDs, renamed executeScriptInIsolatedWorld to
598         executeScriptInWorld.
599
600         * page/Frame.cpp:
601         (WebCore::Frame::injectUserScripts):
602         (WebCore::Frame::injectUserScriptsForWorld):
603         Updated for changes to UserScriptMap and ScriptController.
604
605         * page/Frame.h: Changed injectUserScriptsForWorld to take a
606         DOMWrapperWorld* instead of a worldID.
607
608         * page/PageGroup.cpp:
609         (WebCore::PageGroup::addUserScriptToWorld):
610         (WebCore::PageGroup::addUserStyleSheetToWorld):
611         (WebCore::PageGroup::removeUserScriptFromWorld):
612         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
613         (WebCore::PageGroup::removeUserScriptsFromWorld):
614         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
615         * page/PageGroup.h:
616         Changed these functions to take a DOMWrapperWorld* instead of a
617         worldID. Also updated for changes to UserScript and UserStyleSheet.
618
619         * page/UserScript.h:
620         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
621         never used.
622
623         * page/UserScriptTypes.h:
624         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
625         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
626         worldID as their key type.
627
628
629 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
630
631         Reviewed by Tim Hatcher.
632
633         Fixes <http://webkit.org/b/31260>.
634         Web Inspector: Main Resources Other than HTML are mis-detected.
635         
636         Even if the resource is a main resource, look at its CachedResource type, 
637         because it might be an image, stylesheet, or JavaScript file, and we
638         want to show them all correctly.
639
640         * inspector/InspectorResource.cpp:
641         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
642         (WebCore::InspectorResource::type): 
643         * inspector/InspectorResource.h:
644
645 2009-11-12  Jens Alfke  <snej@chromium.org>
646
647         Reviewed by Dimitri Glazkov.
648
649         Table-driven setup for V8 binding template callback functions. 100k in code savings.
650         https://bugs.webkit.org/show_bug.cgi?id=31420
651
652         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
653             to call configureTemplate().
654         * bindings/v8/V8Binding.cpp:
655         (WebCore::configureTemplate):  New function; does all the standard configuration work.
656         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
657         * bindings/v8/V8Binding.h:
658         * bindings/v8/V8Proxy.cpp:
659         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
660         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
661         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
662         * bindings/v8/V8Proxy.h:
663
664 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
665
666         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
667
668         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
669
670 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
671
672         Reviewed by Dan Bernstein.
673
674         <rdar://problem/7388969> Add DOM API for fullscreen video
675         
676         DOM API for fullscreen <video>.
677
678         Tests: media/media-fullscreen-inline.html
679                media/media-fullscreen-not-in-document.html
680
681         * dom/EventNames.h:
682             Add webkitbeginfullscreen and webkitendfullscreen.
683
684         * html/HTMLAttributeNames.in:
685             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
686
687         * html/HTMLMediaElement.cpp:
688         (WebCore::HTMLMediaElement::parseMappedAttribute):
689             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
690         (WebCore::HTMLMediaElement::enterFullscreen):
691             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
692             actually do enter fullscreen.
693         (WebCore::HTMLMediaElement::exitFullscreen):
694             Schedule webkitendfullscreenEvent event.
695         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
696         (WebCore::HTMLMediaElement::webkitExitFullScreen):
697         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
698         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
699             New, access to fullscreen properties and methods.
700
701         * html/HTMLMediaElement.h:
702         * html/HTMLMediaElement.idl:
703             Declare methods needed for fullscreen API.
704
705         * html/HTMLVideoElement.cpp:
706         (WebCore::HTMLVideoElement::supportsFullscreen):
707             Return false if a movie does not have video.
708
709         * page/DOMWindow.h:
710             Add webkitbeginfullscreen and webkitendfullscreen.
711
712 2009-11-12  Adam Barth  <abarth@webkit.org>
713
714         Reviewed by Dimitri Glazkov.
715
716         [Chromium] Sify compose button alerts error
717         https://bugs.webkit.org/show_bug.cgi?id=31394
718
719         Test: http/tests/security/calling-versus-current.html
720
721         We're supposed to use the calling context for security checks.  In JSC
722         land, this is the lexicalGlobalObject.
723
724         * bindings/v8/V8Proxy.cpp:
725         (WebCore::V8Proxy::canAccessPrivate):
726
727 2009-11-12  Daniel Bates  <dbates@webkit.org>
728
729         Reviewed by Darin Adler.
730
731         https://bugs.webkit.org/show_bug.cgi?id=30291
732
733         Fixes an issue where the returned drop effect is incorrect when
734         effectAllowed == "uninitialized".
735
736         According to section 7.9.2 of the HTML 5 spec.
737         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
738         when effectAllowed = "uninitialized" the resulting dropEffect should be the
739         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
740         other case.
741         
742         No test cases are included because we have an existing test case from
743         bug #24731.
744
745         * dom/Clipboard.cpp:
746         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
747
748 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
749
750         Reviewed by Timothy Hatcher.
751
752         Web Inspector: Do not highlight node on refresh.
753
754         https://bugs.webkit.org/show_bug.cgi?id=31419
755
756         * inspector/front-end/ElementsPanel.js:
757         (WebInspector.ElementsPanel.prototype.reset):
758
759 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
760
761         Reviewed by Timothy Hatcher.
762
763         Web Inspector: Minor timeline fixes.
764
765         https://bugs.webkit.org/show_bug.cgi?id=31417
766
767         * inspector/front-end/TimelinePanel.js:
768         (WebInspector.TimelinePanel.prototype._getRecordDetails):
769         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
770         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
771         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
772
773 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
774
775         SnowLeopard build fix.
776
777         Renamed initWithClient to initWithAuthenticationClient.
778
779         * platform/network/mac/AuthenticationMac.mm:
780         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
781         (WebCore::AuthenticationChallenge::setAuthenticationClient):
782
783 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
784
785         Reviewed by Darin Adler.
786
787         ARIA: add alert type roles
788         https://bugs.webkit.org/show_bug.cgi?id=31392
789
790         Test: platform/mac/accessibility/aria-alerts.html
791
792         * accessibility/AccessibilityObject.h:
793         * accessibility/AccessibilityRenderObject.cpp:
794         * accessibility/mac/AccessibilityObjectWrapper.mm:
795
796 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
797
798         Reviewed by Darin Adler.
799
800         https://bugs.webkit.org/show_bug.cgi?id=31386
801         Make Mac AuthenticationChallenge usable from cross-platform code
802
803         No change in behavior, so no tests.
804
805         * platform/network/ResourceHandle.cpp:
806         (WebCore::ResourceHandle::clearAuthentication):
807         * platform/network/ResourceHandleInternal.h:
808         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
809         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
810         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
811         is identical.
812
813         * platform/network/cf/AuthenticationChallenge.h:
814         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
815         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
816
817         * platform/network/cf/ResourceHandleCFNet.cpp:
818         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
819         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
820         be already set.
821
822         * platform/network/mac/AuthenticationChallenge.h:
823         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
824         best of my understanding.
825         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
826         confusion with "mac" and "web" challenges in ResourceHandleInternal.
827
828         * platform/network/mac/AuthenticationMac.mm:
829         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
830         making it possible to use the latter with NSURLAuthenticationChallenge.
831         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
832         m_nsChallenge renaming.
833         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
834         set it as sender (or unset, if client is null).
835
836         * platform/network/mac/ResourceHandleMac.mm:
837         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
838         authentication challenge sender.
839         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
840         authentication sheet.
841         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
842         using the new setAuthenticationClient() method.
843         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
844         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
845         the original Mac one, not the one we created for use with authentication sheet. I don't
846         know when a connection would cancel authentication in practice, so I haven't tested this.
847
848 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
849
850         Reviewed by Timothy Hatcher.
851
852         Web Inspector: breakpoint sidebar entries should allow click over entire list item
853         https://bugs.webkit.org/show_bug.cgi?id=31411
854
855         No new tests; no new functionality, small usability change. 
856
857         * inspector/front-end/BreakpointsSidebarPane.js:
858         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
859         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
860
861 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
862
863         Reviewed by Timothy Hatcher.
864
865         Web Inspector: breakpoints in named evals are not restored after a reload
866         https://bugs.webkit.org/show_bug.cgi?id=31375
867
868         Manual test added
869
870         * inspector/front-end/ScriptsPanel.js:
871         (WebInspector.ScriptsPanel.prototype.addScript):
872         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
873
874 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
875
876         Reviewed by Kenneth Rohde Christiansen.
877
878         Custom printing shrink factors
879         https://bugs.webkit.org/show_bug.cgi?id=29042
880
881         This reverts commit r49769. The public API for this needs to be reviewed
882         before its inclusion in Qt.
883
884         * page/PrintContext.cpp:
885         (WebCore::PrintContext::begin):
886         * page/Settings.cpp:
887         (WebCore::Settings::Settings):
888         * page/Settings.h:
889
890 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
891
892         Reviewed by Pavel Feldman.
893
894         Web Inspector: Resource errors/warnings not shown in the Resource tree.
895
896         Error/Warning bubbles are not displayed next to the resource in the 
897         Resources panel if those occur before the resource is attached to the tree.
898         https://bugs.webkit.org/show_bug.cgi?id=31404
899
900         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
901
902         * inspector/front-end/AbstractTimelinePanel.js:
903         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
904         * inspector/front-end/ResourcesPanel.js:
905         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
906
907 2009-11-12  Philippe Normand  <pnormand@igalia.com>
908
909         Reviewed by Jan Alonzo.
910
911         https://bugs.webkit.org/show_bug.cgi?id=31047
912         [GTK] Failing test media/video-played-ranges-1.html
913
914         Follow-up of r50726, don't block the UI thread when calling
915         gst_element_get_state(). Also fixed a compilation warning and some
916         static casts.
917
918         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
919         (WebCore::playbackPosition):
920         (WebCore::MediaPlayerPrivate::seek):
921         (WebCore::MediaPlayerPrivate::setRate):
922
923 2009-11-12  Philippe Normand  <pnormand@igalia.com>
924
925         Reviewed by Jan Alonzo.
926
927         https://bugs.webkit.org/show_bug.cgi?id=31047
928         [GTK] Failing test media/video-played-ranges-1.html
929
930         don't pause pipeline if already paused, same for play()
931
932         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
933         (WebCore::MediaPlayerPrivate::play):
934         (WebCore::MediaPlayerPrivate::pause):
935
936 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
937
938         Reviewed by David Levin.
939
940         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
941         Chromium too.
942         https://bugs.webkit.org/show_bug.cgi?id=31292
943
944         No new tests. (Corresponding test for Gtk+ is
945         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
946
947         * page/EventHandler.cpp:
948         * page/chromium/EventHandlerChromium.cpp:
949
950 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
951
952         Reviewed by Eric Seidel.
953
954         Prevent text inside a multi-column block from being split into columns.
955         
956         If the tentative height of a multi-column block was too small, we need to
957         expand the block height and try to layout again, in order to prevent text
958         from being split into different columns.
959
960         CSS Multicolumn text is split awkwardly
961         https://bugs.webkit.org/show_bug.cgi?id=22249
962
963         Test: fast/multicol/single-line.html
964
965         * rendering/RenderBlock.cpp:
966         (WebCore::RenderBlock::layoutColumns):
967         * rendering/RenderBlock.h:
968         * rendering/RenderLineBoxList.cpp:
969         (WebCore::RenderLineBoxList::paint):
970         * rendering/RenderView.h:
971         (WebCore::RenderView::setTruncatedAt):
972         (WebCore::RenderView::setMinimumColumnHeight):
973         (WebCore::RenderView::minimumColumnHeight):
974
975 2009-11-11  Kent Tamura  <tkent@chromium.org>
976
977         Reviewed by Darin Adler.
978
979         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
980         https://bugs.webkit.org/show_bug.cgi?id=31195
981
982         Test: fast/forms/input-file-re-render.html
983
984         * rendering/RenderFileUploadControl.cpp:
985         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
986
987 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
988
989         Reviewed by Dimitri Glazkov.
990
991         Fixing Chromium's POSIX VFS implementation, by adding the required
992         "used file descriptors" logic.
993
994         https://bugs.webkit.org/show_bug.cgi?id=31275
995
996         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
997
998 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
999
1000         Reviewed by Oliver Hunt.
1001
1002         need to implement aria tree roles
1003         https://bugs.webkit.org/show_bug.cgi?id=31284
1004
1005         Tests: platform/mac/accessibility/aria-multiselectable.html
1006                platform/mac/accessibility/aria-tree.html
1007
1008         * accessibility/AccessibilityList.cpp:
1009         (WebCore::AccessibilityList::accessibilityIsIgnored):
1010         * accessibility/AccessibilityObject.cpp:
1011         (WebCore::AccessibilityObject::ariaTreeRows):
1012         (WebCore::AccessibilityObject::ariaTreeItemContent):
1013         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
1014         * accessibility/AccessibilityObject.h:
1015         (WebCore::):
1016         (WebCore::AccessibilityObject::isTree):
1017         (WebCore::AccessibilityObject::isTreeItem):
1018         (WebCore::AccessibilityObject::setIsExpanded):
1019         (WebCore::AccessibilityObject::canSetExpandedAttribute):
1020         (WebCore::AccessibilityObject::hierarchicalLevel):
1021         (WebCore::AccessibilityObject::setSelectedRows):
1022         (WebCore::AccessibilityObject::performDefaultAction):
1023         * accessibility/AccessibilityRenderObject.cpp:
1024         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
1025         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1026         (WebCore::AccessibilityRenderObject::isExpanded):
1027         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
1028         (WebCore::AccessibilityRenderObject::elementAttributeValue):
1029         (WebCore::AccessibilityRenderObject::setIsExpanded):
1030         (WebCore::AccessibilityRenderObject::isSelected):
1031         (WebCore::AccessibilityRenderObject::setSelected):
1032         (WebCore::AccessibilityRenderObject::setSelectedRows):
1033         (WebCore::createARIARoleMap):
1034         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
1035         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1036         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
1037         (WebCore::AccessibilityRenderObject::selectedChildren):
1038         * accessibility/AccessibilityRenderObject.h:
1039         * accessibility/mac/AccessibilityObjectMac.mm:
1040         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1041         * accessibility/mac/AccessibilityObjectWrapper.mm:
1042         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1043         (RoleEntry::):
1044         (-[AccessibilityObjectWrapper subrole]):
1045         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1046         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1047         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
1048         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1049         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1050         * html/HTMLAttributeNames.in:
1051
1052 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1053
1054         Build fix after @r50760 with ENABLE_FILTERS.
1055
1056         * platform/graphics/filters/SourceAlpha.cpp:
1057         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
1058         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
1059           to fillRect.
1060
1061 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
1062
1063         Reviewed by Alexey Proskuryakov.
1064
1065         Fix WebSocket frame parser of frame_type with high-order bit set.
1066         https://bugs.webkit.org/show_bug.cgi?id=30668
1067
1068         If buffer is smaller than frame's length, it should break the loop
1069         instead of reading next byte.
1070
1071         Tests: websocket/tests/frame-length-longer-than-buffer.html
1072                websocket/tests/frame-length-skip.html
1073
1074         * websockets/WebSocketChannel.cpp:
1075         (WebCore::WebSocketChannel::didReceiveData):
1076
1077 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
1078
1079         Reviewed by Adam Barth.
1080
1081         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
1082         https://bugs.webkit.org/show_bug.cgi?id=31345
1083
1084         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
1085
1086         * platform/graphics/chromium/FontCustomPlatformData.cpp:
1087         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
1088         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
1089         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
1090
1091 2009-11-11  Beth Dakin  <bdakin@apple.com>
1092
1093         Build fix. No review needed.
1094
1095         * platform/graphics/gtk/FontGtk.cpp:
1096         (WebCore::Font::drawComplexText):
1097
1098 2009-11-11  Beth Dakin  <bdakin@apple.com>
1099
1100         Build fix. No review needed.
1101
1102         * platform/graphics/cairo/FontCairo.cpp:
1103         (WebCore::Font::drawGlyphs):
1104
1105 2009-11-11  Beth Dakin  <bdakin@apple.com>
1106
1107         Windows build fix. No review needed. 
1108
1109         * platform/graphics/win/FontCGWin.cpp:
1110         (WebCore::Font::drawGlyphs):
1111
1112 2009-11-11  Beth Dakin  <bdakin@apple.com>
1113
1114         Reviewed by Simon Fraser.
1115
1116         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
1117         Make -webkit-color-correction work with shadows
1118
1119         From canvas, just send DeviceColorSpace to setShadow() for now. 
1120         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
1121         * html/canvas/CanvasRenderingContext2D.cpp:
1122         (WebCore::CanvasRenderingContext2D::setShadow):
1123         (WebCore::CanvasRenderingContext2D::applyShadow):
1124
1125         setShadow() and setPlatformShadow() now take a ColorSpace.
1126         * platform/graphics/GraphicsContext.cpp:
1127         (WebCore::GraphicsContext::setShadow):
1128         * platform/graphics/GraphicsContext.h:
1129         * platform/graphics/cg/GraphicsContextCG.cpp:
1130         (WebCore::createCGColorWithColorSpace): New helper to create a 
1131         color in a ColorSpace.
1132         (WebCore::setCGFillColor): Call new helper.
1133         (WebCore::setCGStrokeColor): Call new helper.
1134         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
1135         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1136         (WebCore::GraphicsContext::setPlatformShadow):
1137
1138         Send appropriate ColorSpace to setShadow().
1139         * platform/graphics/mac/FontMac.mm:
1140         (WebCore::Font::drawGlyphs):
1141         * rendering/EllipsisBox.cpp:
1142         (WebCore::EllipsisBox::paint):
1143         * rendering/InlineFlowBox.cpp:
1144         (WebCore::InlineFlowBox::paintTextDecorations):
1145         * rendering/InlineTextBox.cpp:
1146         (WebCore::paintTextWithShadows):
1147         (WebCore::InlineTextBox::paintDecoration):
1148         * rendering/RenderBoxModelObject.cpp:
1149         (WebCore::RenderBoxModelObject::paintBoxShadow):
1150         * rendering/SVGInlineTextBox.cpp:
1151         (WebCore::SVGInlineTextBox::paintCharacters):
1152         * rendering/SVGRenderSupport.cpp:
1153         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
1154
1155         Attempt to keep ports building.
1156         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1157         (WebCore::GraphicsContext::setPlatformShadow):
1158         * platform/graphics/qt/GraphicsContextQt.cpp:
1159         (WebCore::GraphicsContext::setPlatformShadow):
1160         * platform/graphics/skia/GraphicsContextSkia.cpp:
1161         (WebCore::GraphicsContext::setPlatformShadow):
1162         * platform/graphics/wince/GraphicsContextWince.cpp:
1163         (WebCore::GraphicsContext::setPlatformShadow):
1164         * platform/graphics/wx/GraphicsContextWx.cpp:
1165         (WebCore::GraphicsContext::setPlatformShadow):
1166
1167 2009-11-11  Kent Tamura  <tkent@chromium.org>
1168
1169         Reviewed by Darin Adler.
1170
1171         Print the file text of a file upload control in DumpRenderTree for ease of tests.
1172         https://bugs.webkit.org/show_bug.cgi?id=31195
1173
1174         * rendering/RenderFileUploadControl.cpp:
1175         (WebCore::RenderFileUploadControl::paintObject):
1176         (WebCore::RenderFileUploadControl::fileTextValue):
1177         * rendering/RenderFileUploadControl.h:
1178         (WebCore::RenderFileUploadControl::isFileUploadControl):
1179         (WebCore::toRenderFileUploadControl):
1180         * rendering/RenderObject.h:
1181         (WebCore::RenderObject::isFileUploadControl):
1182         * rendering/RenderTreeAsText.cpp:
1183         (WebCore::operator<<):
1184
1185 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
1186
1187         Reviewed by Sam Weinig.
1188
1189         DOM Wrappers for some nodes may not be marked.
1190         https://bugs.webkit.org/show_bug.cgi?id=31380
1191
1192         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
1193         the wrapper for the current world only.  This means that wrappers may be GC'ed
1194         prematurely, and properties lost.
1195
1196         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
1197
1198         * bindings/js/JSAttrCustom.cpp:
1199         (WebCore::JSAttr::markChildren):
1200         * bindings/js/JSDOMBinding.cpp:
1201         (WebCore::markDOMNodeWrapper):
1202         * bindings/js/JSDOMBinding.h:
1203         * bindings/js/JSNamedNodeMapCustom.cpp:
1204         (WebCore::JSNamedNodeMap::markChildren):
1205         * bindings/js/JSNodeCustom.cpp:
1206         (WebCore::JSNode::markChildren):
1207         * bindings/js/JSSVGElementInstanceCustom.cpp:
1208         (WebCore::JSSVGElementInstance::markChildren):
1209         * bindings/js/JSStyleSheetCustom.cpp:
1210         (WebCore::JSStyleSheet::markChildren):
1211
1212 2009-11-11  Ben Murdoch  <benm@google.com>
1213
1214         Reviewed by Darin Adler.
1215
1216         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1217         https://bugs.webkit.org/show_bug.cgi?id=31384
1218
1219         No functionality change so no tests required.
1220
1221         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1222
1223 2009-11-11  Jens Alfke  <snej@chromium.org>
1224
1225         Reviewed by Dimitri Glazkov.
1226
1227         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1228         - Various inline functions in V8Binding.h made non-inline.
1229         - Some renaming for consistency.
1230         - New function createRawTemplate().
1231         https://bugs.webkit.org/show_bug.cgi?id=31383
1232
1233         * bindings/scripts/CodeGeneratorV8.pm:
1234         * bindings/v8/V8Binding.cpp:
1235         (WebCore::v8DOMWrapperToNative):
1236         (WebCore::v8ValueToWebCoreString):
1237         (WebCore::v8ValueToAtomicWebCoreString):
1238         (WebCore::toInt32):
1239         (WebCore::toWebCoreString):
1240         (WebCore::toWebCoreStringWithNullCheck):
1241         (WebCore::toAtomicWebCoreStringWithNullCheck):
1242         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1243         (WebCore::isUndefinedOrNull):
1244         (WebCore::v8Boolean):
1245         (WebCore::v8UndetectableString):
1246         (WebCore::v8StringOrNull):
1247         (WebCore::v8StringOrUndefined):
1248         (WebCore::v8StringOrFalse):
1249         (WebCore::v8StringToWebCoreString):
1250         (WebCore::v8ExternalString):
1251         (WebCore::createRawTemplate):  New function.
1252         * bindings/v8/V8Binding.h:
1253         (WebCore::v8DOMWrapperTo):
1254         (WebCore::v8DOMWrapperToNode):
1255         (WebCore::v8StringToWebCoreString):
1256         (WebCore::v8StringToAtomicWebCoreString):
1257
1258 2009-11-11  Jens Alfke  <snej@chromium.org>
1259
1260         Reviewed by Dimitri Glazkov.
1261
1262         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1263         event-listener setter into a new subroutine transferHiddenDependency().
1264         https://bugs.webkit.org/show_bug.cgi?id=31377
1265
1266         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1267         * bindings/v8/V8Utilities.cpp:
1268         (WebCore::transferHiddenDependency):  New.
1269         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1270
1271 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1272
1273         Reviewed by Beth Dakin.
1274
1275         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1276         because there is a CG bug preventing this from working.
1277
1278         * platform/graphics/cg/GraphicsContextCG.cpp:
1279         (WebCore::sRGBColorSpaceRef):
1280
1281 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1282
1283         Reviewed by Timothy Hatcher.
1284
1285         Check that if Storage panel exists before calling its methods
1286
1287         https://bugs.webkit.org/show_bug.cgi?id=31343
1288
1289         * inspector/front-end/inspector.js:
1290         (WebInspector.addDatabase):
1291         (WebInspector.addCookieDomain):
1292         (WebInspector.addDOMStorage):
1293         (WebInspector.updateDOMStorage):
1294
1295 2009-11-11  Jens Alfke  <snej@chromium.org>
1296
1297         Reviewed by Dimitri Glazkov.
1298
1299         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1300         times in the generated V8 bindings.
1301         https://bugs.webkit.org/show_bug.cgi?id=31368
1302
1303         * bindings/v8/V8DOMWrapper.cpp:
1304         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1305         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1306
1307 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1308
1309         Reviewed by Timothy Hatcher.
1310
1311         Display the correct summary in the web inspector for the shorthands
1312         border-color, border-width, border-style, margin, and padding.
1313         https://bugs.webkit.org/show_bug.cgi?id=7987
1314
1315         Test: fast/css/shorthands-four-values.html
1316
1317         * css/CSSMutableStyleDeclaration.cpp:
1318         (WebCore::CSSMutableStyleDeclaration::get4Values):
1319         Display the summary information in the same way the shorthand would be
1320         specified in a css rule.
1321
1322 2009-11-11  Jens Alfke  <snej@chromium.org>
1323
1324         Reviewed by Dimitri Glazkov.
1325
1326         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1327         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1328         https://bugs.webkit.org/show_bug.cgi?id=31367
1329
1330         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1331
1332 2009-11-11  Jens Alfke  <snej@chromium.org>
1333
1334         Reviewed by Dimitri Glazkov.
1335
1336         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1337
1338         * bindings/v8/DOMData.cpp:
1339         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1340             so it can be inlined by its caller.
1341         * bindings/v8/DOMData.h:
1342         * bindings/v8/MainThreadDOMData.cpp:
1343         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1344         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1345         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1346             and getStore, which inline both calls together.
1347         * bindings/v8/MainThreadDOMData.h:
1348         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1349         * bindings/v8/V8DOMMap.cpp:
1350         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1351
1352 2009-11-11  Nate Chapin  <japhet@chromium.org>
1353
1354         Reviewed by Dimitri Glazkov.
1355
1356         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1357
1358         https://bugs.webkit.org/show_bug.cgi?id=31357
1359
1360         * platform/KURLGoogle.cpp:
1361         (WebCore::isSchemeFirstChar):
1362         (WebCore::isSchemeChar):
1363         (WebCore::KURL::hasPort):
1364         (WebCore::KURL::removePort):
1365         (WebCore::protocolIsValid):
1366
1367 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1368
1369         Build fix, no reviewed.
1370
1371         Correct setPlatformFillColor and setPlatformStrokeColor calls
1372         to match new ColorSpace-supporting signatures.
1373
1374         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1375           color space to the set[...]Color calls.
1376
1377 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1378
1379         Reviewed by Sam Weinig.
1380
1381         https://bugs.webkit.org/show_bug.cgi?id=31327
1382         Clean up SocketStreamHandleClient interface
1383
1384         No change in behavior.
1385
1386         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1387         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1388         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1389         should be.
1390         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1391         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1392         For ResourceHandle, this method is called when the user cancels authentication sheet,
1393         not when something happens with the stream.
1394
1395         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1396         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1397
1398         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1399         callbacks have no real implementation yet.
1400
1401 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1402
1403         Reviewed by Eric Seidel.
1404
1405         Allow custom memory allocation control for the part of page directory in WebCore
1406         https://bugs.webkit.org/show_bug.cgi?id=31350
1407
1408         Inherits the following classes from Noncopyable because these are instantiated
1409         by 'new' and these are no need to be copyable:
1410
1411         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1412         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1413         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1414         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1415         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1416         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1417         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1418         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1419         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1420
1421         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1422         PropertyWrapper is instantiated by 'new' in 
1423         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1424
1425         * page/DragController.h:
1426         * page/EventHandler.h:
1427         * page/FocusController.h:
1428         * page/FrameView.cpp:
1429         * page/PluginHalter.h:
1430         * page/Settings.h:
1431         * page/UserScript.h:
1432         * page/UserStyleSheet.h:
1433         * page/XSSAuditor.h:
1434         * page/animation/AnimationBase.cpp:
1435
1436 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1437
1438         Reviewed by Kenneth Rohde Christiansen.
1439
1440         https://bugs.webkit.org/show_bug.cgi?id=31323
1441         Fix a few compiler warnings
1442
1443         No new tests as there is no new functionality.
1444
1445         * editing/htmlediting.cpp:
1446         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1447         parentheses to silence gcc 4.4 -Wparentheses warnings
1448
1449 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1450
1451         Reviewed by Mark Rowe.
1452
1453         Set m_hasPendingGeometryChange to true by default, so that
1454         at least one call to NPP_SetWindow is executed, which is
1455         needed by the DRT plugin testing framework.
1456
1457         * plugins/PluginView.cpp:
1458         (WebCore::PluginView::PluginView):
1459
1460 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1461
1462         Rubber-stamped by Kenneth Rohde Christiansen.
1463
1464         https://bugs.webkit.org/show_bug.cgi?id=31348
1465         [Qt] Remove unnecessary LUT creator from WebCore.pro
1466
1467         * WebCore.pro:
1468
1469 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1470
1471         Reviewed by Tor Arne Vestbø.
1472
1473         Introduce a function for querying the input method status
1474         in QWebPageClient.
1475
1476         * platform/qt/QWebPageClient.h:
1477
1478 2009-11-11  Benjamin Otte  <otte@gnome.org>
1479
1480         Reviewed by Jan Alonzo.
1481
1482         [GTK] Black artifacts in youtube.com/html5
1483
1484         Paint the video to the given size. It's the job of the callers to keep
1485         track of aspect ratio. RenderVideo.cpp does it for the <video>
1486         element.
1487         https://bugs.webkit.org/show_bug.cgi?id=30925
1488
1489         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1490         (WebCore::MediaPlayerPrivate::paint):
1491
1492 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1493
1494         Reviewed by Reviewed by Jan Alonzo.
1495
1496         https://bugs.webkit.org/show_bug.cgi?id=30901
1497         [Gtk] Need to de-lint the Atk a11y code
1498
1499         Cleaned up some missed capitalization style-guideline violations.
1500
1501         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1502
1503 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1504
1505         Reviewed by Eric Seidel.
1506
1507         [Qt] Make the default style background color valid.
1508         Currently the color is transparent but invalid, this causes
1509         list boxes in QtWebKit to be drawn with a black background
1510         since r49242.
1511         https://bugs.webkit.org/show_bug.cgi?id=31295
1512
1513         * rendering/style/RenderStyle.h:
1514         (WebCore::InheritedFlags::initialBackgroundColor):
1515         * rendering/style/StyleBackgroundData.cpp:
1516         (WebCore::StyleBackgroundData::StyleBackgroundData):
1517
1518 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1519
1520         Reviewed by Geoff Garen.
1521
1522         Simplify the ownership model for worlds - rather than having a pair of weak references
1523         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1524         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1525         back forward cache.
1526
1527         * WebCore.base.exp:
1528         * bindings/js/JSDOMBinding.cpp:
1529         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1530         * bindings/js/JSDOMBinding.h:
1531         (WebCore::DOMWrapperWorld::forgetDocument):
1532         * bindings/js/ScriptCachedFrameData.cpp:
1533         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1534         (WebCore::ScriptCachedFrameData::restore):
1535         (WebCore::ScriptCachedFrameData::clear):
1536         * bindings/js/ScriptCachedFrameData.h:
1537         * bindings/js/ScriptController.cpp:
1538         (WebCore::ScriptController::~ScriptController):
1539         (WebCore::ScriptController::clearWindowShell):
1540         (WebCore::ScriptController::initScript):
1541         (WebCore::ScriptController::updateDocument):
1542         * bindings/js/ScriptController.h:
1543
1544 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1545
1546         Reviewed by Darin Adler.
1547
1548         rename counter to makeCounterNode in RenderCounter.cpp
1549         https://bugs.webkit.org/show_bug.cgi?id=31289
1550
1551         No new test because this is just a small refactoring.
1552
1553         * rendering/RenderCounter.cpp:
1554         (WebCore::findPlaceForCounter):
1555         (WebCore::makeCounterNode):
1556         (WebCore::RenderCounter::originalText):
1557
1558 2009-11-10  Daniel Bates  <dbates@webkit.org>
1559
1560         Reviewed by Oliver Hunt.
1561
1562         https://bugs.webkit.org/show_bug.cgi?id=30754
1563
1564         Patch 2 of 2.
1565
1566         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1567         needed. This method fired a drag event whenever the mouse moved, but
1568         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1569         model independent of when the mouse moves. See "Among other changes..."
1570         in the change log for patch 1 for more details.
1571
1572         * WebCore.DragSupport.exp:
1573         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1574         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1575         * page/EventHandler.h:
1576
1577 2009-11-10  Daniel Bates  <dbates@webkit.org>
1578
1579         Reviewed by Oliver Hunt.
1580
1581         https://bugs.webkit.org/show_bug.cgi?id=30754
1582
1583         Patch 1 of 2.
1584
1585         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1586         the drag event should always fire before the dragover event.
1587
1588         In fixing this bug, this patch also makes our drag processing model
1589         conform to the HTML 5 spec.
1590
1591         Among the changes, this patch ensures that the drag event isn't fired outside
1592         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1593         Currently, the drag event is fired whenever the mouse button is down and the OS
1594         detects the mouse moved. But, as per the spec, the drag event should
1595         fire approx. every 350ms so long as the mouse button is down.
1596
1597         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1598
1599         * page/EventHandler.cpp:
1600         (WebCore::EventHandler::clear):
1601         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1602         Modified to determine when we are in the correct instance of EventHandler to service the drag
1603         and drop operation.
1604         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1605         into this method.
1606         (WebCore::EventHandler::cancelDragAndDrop):
1607         (WebCore::EventHandler::performDragAndDrop):
1608         (WebCore::EventHandler::clearDragState):
1609         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1610         we should fire both drag and dragover events or only the dragover event.
1611
1612 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1613
1614         Reviewed by Dimitri Glazkov.
1615
1616         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1617         https://bugs.webkit.org/show_bug.cgi?id=31301
1618
1619         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1620
1621         Allowed passing V8Proxy for the calling JS context:
1622         * bindings/v8/V8DOMWrapper.h:
1623         (WebCore::V8DOMWrapper::getXPathNSResolver):
1624         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1625         (WebCore::V8CustomXPathNSResolver::create):
1626         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1627         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1628         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1629         * bindings/v8/custom/V8DocumentCustom.cpp:
1630         (WebCore::CALLBACK_FUNC_DECL):
1631
1632 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1633
1634         Reviewed by Timothy Hatcher.
1635
1636         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1637         https://bugs.webkit.org/show_bug.cgi?id=29972.
1638
1639         Add methods for setting different parts of the URL in href attribute.
1640
1641         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1642                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1643                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1644                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1645                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1646                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1647                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1648
1649         * bindings/js/JSLocationCustom.cpp:
1650         (WebCore::JSLocation::setPort):
1651         * html/HTMLAnchorElement.cpp:
1652         (WebCore::parsePortFromStringPosition):
1653         (WebCore::HTMLAnchorElement::setHash):
1654         (WebCore::HTMLAnchorElement::setHost):
1655         (WebCore::HTMLAnchorElement::setHostname):
1656         (WebCore::HTMLAnchorElement::setPathname):
1657         (WebCore::HTMLAnchorElement::setPort):
1658         (WebCore::HTMLAnchorElement::setProtocol):
1659         (WebCore::HTMLAnchorElement::setSearch):
1660         * html/HTMLAnchorElement.h:
1661         * html/HTMLAnchorElement.idl:
1662         * loader/FrameLoader.cpp:
1663         (WebCore::FrameLoader::iconURL):
1664         * platform/KURL.cpp:
1665         (WebCore::KURL::removePort):
1666         (WebCore::KURL::setPort):
1667         (WebCore::KURL::prettyURL):
1668         (WebCore::protocolIsValid):
1669         * platform/KURL.h:
1670         (WebCore::KURL::canSetHostOrPort):
1671         (WebCore::KURL::canSetPathname):
1672         (WebCore::KURL::hasPort):
1673         * platform/network/soup/ResourceHandleSoup.cpp:
1674         (WebCore::):
1675
1676 2009-11-10  Nate Chapin  <japhet@chromium.org>
1677
1678         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1679
1680         * platform/chromium/PopupMenuChromium.cpp:
1681         (WebCore::PopupContainer::paintBorder):
1682         (WebCore::PopupListBox::paint):
1683         (WebCore::PopupListBox::paintRow):
1684         * platform/graphics/chromium/TransparencyWin.cpp:
1685         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1686         * platform/graphics/skia/GraphicsContextSkia.cpp:
1687         (WebCore::GraphicsContext::fillRect):
1688         (WebCore::GraphicsContext::fillRoundedRect):
1689         (WebCore::GraphicsContext::setPlatformFillColor):
1690         (WebCore::GraphicsContext::setPlatformStrokeColor):
1691         * rendering/RenderMediaControlsChromium.cpp:
1692         (WebCore::paintMediaSlider):
1693         (WebCore::paintMediaVolumeSlider):
1694         (WebCore::paintMediaTimelineContainer):
1695         * rendering/RenderThemeChromiumMac.mm:
1696         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1697
1698 2009-11-10  Brady Eidson  <beidson@apple.com>
1699
1700         Reviewed by Sam Weinig.
1701
1702         Repro crash saving pcmag.com article as a webarchive.
1703         <rdar://problem/7381219> and https://webkit.org/b/31322
1704
1705         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1706
1707         * css/CSSStyleSheet.cpp:
1708         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1709           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1710
1711 2009-11-10  Beth Dakin  <bdakin@apple.com>
1712
1713         Attempt 2 to fix Tiger build. No review needed.
1714
1715         * platform/graphics/cg/GraphicsContextCG.cpp:
1716         (WebCore::deviceRGBColorSpaceRef):
1717         (WebCore::sRGBColorSpaceRef):
1718
1719 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1720
1721         wx build fix. Changes needed after r50760.
1722
1723         * platform/graphics/wx/GraphicsContextWx.cpp:
1724         (WebCore::GraphicsContext::GraphicsContext):
1725         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1726         (WebCore::drawTextWithSpacing):
1727
1728 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1729
1730         Qt build fix.
1731
1732         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1733         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1734
1735 2009-11-10  Beth Dakin  <bdakin@apple.com>
1736
1737         Tiger build fix. No review needed.
1738
1739         * platform/graphics/cg/GraphicsContextCG.cpp:
1740         (WebCore::sRGBColorSpaceRef):
1741
1742 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1743
1744         Reviewed by Dan Bernstein.
1745
1746         https://bugs.webkit.org/show_bug.cgi?id=31312
1747         Decouple authentication panel callbacks from ResourceHandle
1748
1749         No change in functionality.
1750
1751         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1752         ResourceHandle as delegate.
1753
1754         * WebCore.vcproj/WebCore.vcproj:
1755         * platform/network/AuthenticationClient.h: Added.
1756         Added a new interface for listening to authentication panel notifications.
1757
1758         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1759         it wants with the project file.
1760
1761         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1762         interface class.
1763         (WebCore::AuthenticationClient::deref): Ditto.
1764
1765         * platform/network/ResourceHandle.h:
1766         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1767         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1768
1769         * platform/network/cf/AuthenticationCF.cpp:
1770         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1771         (WebCore::AuthenticationChallenge::platformCompare):
1772         * platform/network/cf/AuthenticationChallenge.h:
1773         (WebCore::AuthenticationChallenge::authenticationClient):
1774         * platform/network/chromium/AuthenticationChallenge.h:
1775         (WebCore::AuthenticationChallenge::authenticationClient):
1776         * platform/network/curl/AuthenticationChallenge.h:
1777         (WebCore::AuthenticationChallenge::authenticationClient):
1778         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1779
1780 2009-11-10  Beth Dakin  <bdakin@apple.com>
1781
1782        Second attempted gtk build fix. No review needed.
1783
1784         * html/canvas/CanvasStyle.cpp:
1785         (WebCore::CanvasStyle::applyStrokeColor):
1786
1787
1788 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1789
1790         Reviewed by Geoff Garen.
1791
1792         Fix back/forwards cache with JSC isolated worlds.
1793         https://bugs.webkit.org/show_bug.cgi?id=31310
1794         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1795
1796         Store the global object for all worlds, not just the normal world.
1797         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1798         so we can forget global objects if a world goes away.
1799
1800         * bindings/js/JSDOMBinding.cpp:
1801         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1802         * bindings/js/JSDOMBinding.h:
1803         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1804         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1805         * bindings/js/ScriptCachedFrameData.cpp:
1806         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1807         (WebCore::ScriptCachedFrameData::forgetWorld):
1808         (WebCore::ScriptCachedFrameData::domWindow):
1809         (WebCore::ScriptCachedFrameData::restore):
1810         (WebCore::ScriptCachedFrameData::clear):
1811         * bindings/js/ScriptCachedFrameData.h:
1812         * bindings/js/ScriptController.h:
1813
1814 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1815
1816         [Qt] Unreviewed buildfix after r50760.
1817
1818         * platform/graphics/qt/GraphicsContextQt.cpp:
1819         (WebCore::GraphicsContext::GraphicsContext):
1820
1821 2009-11-10  Beth Dakin  <bdakin@apple.com>
1822
1823         Attempted build fix. (No review needed.)
1824
1825         * GNUmakefile.am: Adding ColorSpace.h
1826
1827 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1828
1829         Reviewed by NOBODY - Build Fix.
1830
1831         Updated function calls to take a ColorSpace argument, passing
1832         in DeviceColorSpace for now - this should be fixed. Also added
1833         ColorSpace.h to WebCore project.
1834
1835         * WebCore.vcproj/WebCore.vcproj:
1836         * platform/graphics/win/FontCGWin.cpp:
1837         (WebCore::Font::drawGlyphs):
1838         * platform/graphics/win/GraphicsContextCGWin.cpp:
1839         (WebCore::GraphicsContext::GraphicsContext):
1840         * platform/win/PopupMenuWin.cpp:
1841         (WebCore::PopupMenu::paint):
1842         * platform/win/WebCoreTextRenderer.cpp:
1843         (WebCore::doDrawTextAtPoint):
1844         * rendering/RenderThemeSafari.cpp:
1845         (WebCore::RenderThemeSafari::paintMenuListButton):
1846
1847 2009-11-10  Jens Alfke  <snej@chromium.org>
1848
1849         Reviewed by Darin Adler.
1850
1851         Optimizations to Element::getAttribute
1852         https://bugs.webkit.org/show_bug.cgi?id=30926
1853
1854         * dom/Element.cpp:
1855         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1856         * dom/NamedAttrMap.cpp:
1857         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1858         * platform/text/PlatformString.h:
1859         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1860
1861 2009-11-10  Beth Dakin  <bdakin@apple.com>
1862
1863         Reviewed by Darin Adler.
1864
1865         Fix for <rdar://problem/7059710> 
1866         -and corresponding-
1867         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1868         color-correction for CSS colors
1869
1870         New exported symbol for GraphicsContext::fillColor() which now 
1871         accepts a ColorSpace as an optional parameter.
1872         * WebCore.base.exp:
1873
1874         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1875         * WebCore.xcodeproj/project.pbxproj:
1876
1877         Computed Style for -webkit-color-correction
1878         * css/CSSComputedStyleDeclaration.cpp:
1879         (WebCore::):
1880         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1881
1882         Parse -webkit-color-correction
1883         * css/CSSParser.cpp:
1884         (WebCore::CSSParser::parseValue):
1885
1886        Map CSS identifiers to the appropriate values of the ColorSpace enum
1887         * css/CSSPrimitiveValueMappings.h:
1888         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1889         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1890
1891         New property -webkit-color-correction
1892         * css/CSSPropertyNames.in:
1893
1894         Map -webkit-color-correction into the RenderStyle.
1895         * css/CSSStyleSelector.cpp:
1896         (WebCore::CSSStyleSelector::applyProperty):
1897
1898         Add new value sRGB.
1899         * css/CSSValueKeywords.in:
1900
1901         Comment out the reference to sRGB since it will now be inherited as 
1902         a value from CSSValueKeywords.
1903         * css/SVGCSSValueKeywords.in:
1904
1905         Definition of the ColorSpace enum.
1906         * platform/graphics/ColorSpace.h: Added.
1907         (WebCore::):
1908
1909         These functions all now take a ColorSpace as a parameter.
1910         * platform/graphics/GraphicsContext.cpp:
1911         (WebCore::GraphicsContext::setStrokeColor):
1912         (WebCore::GraphicsContext::setFillColor):
1913         (WebCore::GraphicsContext::drawHighlightForText):
1914
1915         Return the appropriate ColorSpace.
1916         (WebCore::GraphicsContext::strokeColorSpace):
1917         (WebCore::GraphicsContext::fillColorSpace):
1918
1919         These functions all call other functions which require a ColorSpace 
1920         as a parameter.
1921         (WebCore::GraphicsContext::setStrokePattern):
1922         (WebCore::GraphicsContext::setFillPattern):
1923         (WebCore::GraphicsContext::setStrokeGradient):
1924         (WebCore::GraphicsContext::setFillGradient):
1925
1926         All of the GraphicsContext functions that take a Color should now 
1927         also take a ColorSpace.
1928         * platform/graphics/GraphicsContext.h:
1929
1930         Added new member variables stokeColorSpace and fillColorSpace.
1931         * platform/graphics/GraphicsContextPrivate.h:
1932         (WebCore::GraphicsContextState::GraphicsContextState):
1933
1934         Attempt to keep the Cairo port building with all of the massive 
1935         changes to GraphicsContext.        
1936         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1937         (WebCore::GraphicsContext::fillRect):
1938         (WebCore::GraphicsContext::setPlatformFillColor):
1939         (WebCore::GraphicsContext::setPlatformStrokeColor):
1940         (WebCore::GraphicsContext::fillRoundedRect):
1941
1942         
1943         * platform/graphics/cg/GraphicsContextCG.cpp:
1944         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1945         CGColorSpaceRef for the sRGB color space.
1946         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1947         a CGColorSpaceRef for the device RGB color space.
1948
1949         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1950         sets the fill color to the specified color in the given ColorSpace.
1951         (WebCore::setCGStrokeColor): Same, but for stroke.
1952
1953         (WebCore::setCGFillColorSpace): New static to set the 
1954         CGFillColorSpace to the given ColorSpace
1955         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1956
1957         Send ColorSpaces when appropriate, set ColorSpaces when 
1958         appropriate, and check ColorSpaces when appropriate.
1959         (WebCore::GraphicsContext::GraphicsContext):
1960         (WebCore::GraphicsContext::drawRect):
1961         (WebCore::GraphicsContext::drawLine):
1962         (WebCore::GraphicsContext::fillPath):
1963         (WebCore::GraphicsContext::strokePath):
1964         (WebCore::GraphicsContext::fillRect):
1965         (WebCore::GraphicsContext::fillRoundedRect):
1966         (WebCore::GraphicsContext::strokeRect):
1967         (WebCore::GraphicsContext::drawLineForText):
1968         (WebCore::GraphicsContext::setPlatformStrokeColor):
1969         (WebCore::GraphicsContext::setPlatformFillColor):
1970
1971         Attempt to keep Haiku building.
1972         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1973         (WebCore::GraphicsContext::fillRect):
1974         (WebCore::GraphicsContext::fillRoundedRect):
1975         (WebCore::GraphicsContext::setPlatformStrokeColor):
1976         (WebCore::GraphicsContext::setPlatformFillColor):
1977
1978         Attempt to keep QT building.
1979         * platform/graphics/qt/GraphicsContextQt.cpp:
1980         (WebCore::GraphicsContext::fillRect):
1981         (WebCore::GraphicsContext::fillRoundedRect):
1982         (WebCore::GraphicsContext::setPlatformStrokeColor):
1983         (WebCore::GraphicsContext::setPlatformFillColor):
1984
1985         Attempt to keep Wince building.
1986         * platform/graphics/wince/GraphicsContextWince.cpp:
1987         (WebCore::GraphicsContext::fillRect):
1988         (WebCore::GraphicsContext::setPlatformFillColor):
1989         (WebCore::GraphicsContext::setPlatformStrokeColor):
1990         (WebCore::GraphicsContext::clearRect):
1991         (WebCore::GraphicsContext::fillRoundedRect):
1992         (WebCore::GraphicsContext::setPlatformShadow):
1993
1994         Attempt to keep WX building.
1995         * platform/graphics/wx/GraphicsContextWx.cpp:
1996         (WebCore::GraphicsContext::fillRect):
1997         (WebCore::GraphicsContext::fillRoundedRect):
1998         (WebCore::GraphicsContext::setPlatformStrokeColor):
1999         (WebCore::GraphicsContext::setPlatformFillColor):
2000
2001         Added functions colorSpace() and setColorSpace()
2002         * rendering/style/RenderStyle.h:
2003         (WebCore::InheritedFlags::colorSpace):
2004         (WebCore::InheritedFlags::setColorSpace):
2005
2006         The ColorSpace is stored here.
2007         * rendering/style/StyleRareInheritedData.cpp:
2008         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2009         (WebCore::StyleRareInheritedData::operator==):
2010         * rendering/style/StyleRareInheritedData.h:
2011
2012         All of these call sites call GraphicsContext functions which now 
2013         require ColorSpaces.
2014         * editing/SelectionController.cpp:
2015         (WebCore::SelectionController::paintCaret):
2016         * html/canvas/CanvasRenderingContext2D.cpp:
2017         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2018         * html/canvas/CanvasStyle.cpp:
2019         (WebCore::CanvasStyle::applyStrokeColor):
2020         (WebCore::CanvasStyle::applyFillColor):
2021         * inspector/InspectorController.cpp:
2022         (WebCore::drawOutlinedQuad):
2023         * page/FrameView.cpp:
2024         (WebCore::FrameView::paintContents):
2025         * platform/ScrollbarTheme.h:
2026         (WebCore::ScrollbarTheme::paintScrollCorner):
2027         * platform/ScrollbarThemeComposite.cpp:
2028         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
2029         * platform/graphics/Image.cpp:
2030         (WebCore::Image::fillWithSolidColor):
2031         * platform/graphics/mac/FontMac.mm:
2032         (WebCore::Font::drawGlyphs):
2033         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2034         (WebCore::MediaPlayerPrivate::paint):
2035         * rendering/EllipsisBox.cpp:
2036         (WebCore::EllipsisBox::paint):
2037         * rendering/InlineFlowBox.cpp:
2038         (WebCore::InlineFlowBox::paintTextDecorations):
2039         * rendering/InlineTextBox.cpp:
2040         (WebCore::updateGraphicsContext):
2041         (WebCore::paintTextWithShadows):
2042         (WebCore::InlineTextBox::paint):
2043         (WebCore::InlineTextBox::paintSelection):
2044         (WebCore::InlineTextBox::paintCompositionBackground):
2045         (WebCore::InlineTextBox::paintDecoration):
2046         (WebCore::InlineTextBox::paintTextMatchMarker):
2047         (WebCore::InlineTextBox::paintCompositionUnderline):
2048         * rendering/InlineTextBox.h:
2049         * rendering/RenderBlock.cpp:
2050         (WebCore::RenderBlock::fillHorizontalSelectionGap):
2051         (WebCore::RenderBlock::fillVerticalSelectionGap):
2052         (WebCore::RenderBlock::fillLeftSelectionGap):
2053         (WebCore::RenderBlock::fillRightSelectionGap):
2054         * rendering/RenderBoxModelObject.cpp:
2055         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2056         (WebCore::RenderBoxModelObject::paintBoxShadow):
2057         * rendering/RenderFileUploadControl.cpp:
2058         (WebCore::RenderFileUploadControl::paintObject):
2059         * rendering/RenderFrameSet.cpp:
2060         (WebCore::RenderFrameSet::paintColumnBorder):
2061         (WebCore::RenderFrameSet::paintRowBorder):
2062         * rendering/RenderImage.cpp:
2063         (WebCore::RenderImage::paintReplaced):
2064         * rendering/RenderLayer.cpp:
2065         (WebCore::RenderLayer::paintScrollCorner):
2066         (WebCore::RenderLayer::paintResizer):
2067         * rendering/RenderListBox.cpp:
2068         (WebCore::RenderListBox::paintItemForeground):
2069         (WebCore::RenderListBox::paintItemBackground):
2070         * rendering/RenderListMarker.cpp:
2071         (WebCore::RenderListMarker::paint):
2072         * rendering/RenderObject.cpp:
2073         (WebCore::RenderObject::drawLineForBoxSide):
2074         (WebCore::RenderObject::drawArcForBoxSide):
2075         * rendering/RenderReplaced.cpp:
2076         (WebCore::RenderReplaced::paint):
2077         * rendering/RenderScrollbarTheme.cpp:
2078         (WebCore::RenderScrollbarTheme::paintScrollCorner):
2079         * rendering/RenderThemeMac.mm:
2080         (WebCore::RenderThemeMac::paintMenuListButton):
2081         * rendering/RenderView.cpp:
2082         (WebCore::RenderView::paintBoxDecorations):
2083         * rendering/RenderWidget.cpp:
2084         (WebCore::RenderWidget::paint):
2085         * rendering/SVGInlineTextBox.cpp:
2086         (WebCore::SVGInlineTextBox::paintSelection):
2087         * svg/graphics/SVGPaintServerGradient.cpp:
2088         (WebCore::SVGPaintServerGradient::setup):
2089         * svg/graphics/SVGPaintServerSolid.cpp:
2090         (WebCore::SVGPaintServerSolid::setup):
2091
2092 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
2093
2094         Reviewed by Timothy Hatcher.
2095
2096         Web Inspector: Speed up syntax highlighter
2097         https://bugs.webkit.org/show_bug.cgi?id=31291
2098
2099         * inspector/front-end/SourceFrame.js:
2100         (WebInspector.SourceFrame.prototype._loaded):
2101         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
2102         (WebInspector.SourceSyntaxHighlighter.prototype.process):
2103         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
2104         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
2105         (WebInspector.CSSSourceSyntaxHighlighter):
2106         (WebInspector.JavaScriptSourceSyntaxHighlighter):
2107
2108 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
2109
2110         Reviewed by Eric Seidel.
2111
2112         Remove session storage setting
2113         https://bugs.webkit.org/show_bug.cgi?id=31279
2114
2115         Remove session storage from Settings.  It was added temporarily so we could
2116         disable it by default at runtime in Chromium.  We now disable these things in a
2117         different way, so it's time to remove it.  Qt also depended on this setting for
2118         a short period of time, but after talking to them we agreed that it should be
2119         removed.
2120
2121         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
2122
2123         * page/DOMWindow.cpp:
2124         (WebCore::DOMWindow::sessionStorage):
2125         * page/Settings.cpp:
2126         (WebCore::Settings::Settings):
2127         * page/Settings.h:
2128
2129 2009-11-10  Dan Bernstein  <mitz@apple.com>
2130
2131         Reviewed by Eric Carlson and Darin Adler.
2132
2133         WebCore part of making full-screen video pause during scrubbing.
2134
2135         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
2136         and HTMLMediaElement::endScrubbing().
2137
2138 2009-11-10  Anton Muhin  <antonm@chromium.org>
2139
2140         Reviewed by Adam Barth.
2141
2142         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
2143         https://bugs.webkit.org/show_bug.cgi?id=31051
2144
2145         * bindings/v8/V8GCController.cpp:
2146         (WebCore::V8GCController::gcEpilogue):
2147         (WebCore::V8GCController::checkMemoryUsage):
2148         * bindings/v8/V8GCController.h:
2149         * bindings/v8/V8Proxy.cpp:
2150         (WebCore::V8Proxy::evaluate):
2151         (WebCore::V8Proxy::runScript):
2152         (WebCore::V8Proxy::callFunction):
2153
2154 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
2155
2156         Reviewed by Darin Adler.
2157
2158         Allow custom memory allocation control for the part of loader directory in WebCore
2159         https://bugs.webkit.org/show_bug.cgi?id=31161
2160
2161         Inherits the following classes from Noncopyable because these are instantiated
2162         by 'new' and these are no need to be copyable:
2163
2164         class Request - WebCore/loader/loader.cpp:100
2165         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2166         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2167         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2168         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2169         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2170
2171         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2172         MainThreadBridge is instantiated by 'new' in 
2173         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2174
2175         ThreadableLoaderClient's inheriting has been changed to public.
2176
2177         * loader/ImageLoader.cpp:
2178         * loader/ProgressTracker.cpp:
2179         * loader/RedirectScheduler.cpp:
2180         * loader/Request.h:
2181         * loader/ThreadableLoaderClient.h:
2182         * loader/WorkerThreadableLoader.h:
2183         * loader/appcache/ApplicationCacheHost.h:
2184         * loader/appcache/ApplicationCacheStorage.h:
2185
2186 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2187
2188         Reviewed by Eric Seidel.
2189
2190         https://bugs.webkit.org/show_bug.cgi?id=31047
2191         [GTK] Failing test media/video-played-ranges-1.html
2192
2193         WebKit coding style fixes.
2194
2195         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2196         (WebCore::mediaPlayerPrivateMessageCallback):
2197         (WebCore::MediaPlayerPrivate::naturalSize):
2198         (WebCore::MediaPlayerPrivate::paint):
2199         (WebCore::mimeTypeCache):
2200
2201 2009-11-10  Oliver Hunt  <oliver@apple.com>
2202
2203         Remove build failure introduced by earlier build fix.
2204
2205         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2206
2207 2009-11-10  Oliver Hunt  <oliver@apple.com>
2208
2209         Is this the last build fix? grep tells me yes.
2210
2211         * bindings/v8/custom/V8DocumentCustom.cpp:
2212         (WebCore::CALLBACK_FUNC_DECL):
2213
2214 2009-11-10  Oliver Hunt  <oliver@apple.com>
2215
2216         Hopefully the last one.  Why aren't these autogenerated?
2217
2218         * bindings/v8/V8DOMWrapper.cpp:
2219         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2220         (WebCore::V8DOMWrapper::getTemplate):
2221         (WebCore::V8DOMWrapper::convertToV8Object):
2222
2223 2009-11-10  Oliver Hunt  <oliver@apple.com>
2224
2225         Another chrome build fix.
2226
2227         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2228         (WebCore::CALLBACK_FUNC_DECL):
2229
2230 2009-11-10  Oliver Hunt  <oliver@apple.com>
2231
2232         Yet another chrome buildfix
2233
2234         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2235         (WebCore::CALLBACK_FUNC_DECL):
2236         * bindings/v8/custom/V8WebGLArrayCustom.h:
2237         (WebCore::constructCanvasArray):
2238         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2239         (WebCore::CALLBACK_FUNC_DECL):
2240         (WebCore::INDEXED_PROPERTY_GETTER):
2241         (WebCore::INDEXED_PROPERTY_SETTER):
2242         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2243         (WebCore::CALLBACK_FUNC_DECL):
2244         (WebCore::INDEXED_PROPERTY_GETTER):
2245         (WebCore::INDEXED_PROPERTY_SETTER):
2246         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2247         (WebCore::CALLBACK_FUNC_DECL):
2248         (WebCore::INDEXED_PROPERTY_GETTER):
2249         (WebCore::INDEXED_PROPERTY_SETTER):
2250         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2251         (WebCore::CALLBACK_FUNC_DECL):
2252         (WebCore::vertexAttribAndUniformHelperf):
2253         (WebCore::uniformHelperi):
2254         (WebCore::uniformMatrixHelper):
2255         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2256         (WebCore::CALLBACK_FUNC_DECL):
2257         (WebCore::INDEXED_PROPERTY_GETTER):
2258         (WebCore::INDEXED_PROPERTY_SETTER):
2259         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2260         (WebCore::CALLBACK_FUNC_DECL):
2261         (WebCore::INDEXED_PROPERTY_GETTER):
2262         (WebCore::INDEXED_PROPERTY_SETTER):
2263         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2264         (WebCore::CALLBACK_FUNC_DECL):
2265         (WebCore::INDEXED_PROPERTY_GETTER):
2266         (WebCore::INDEXED_PROPERTY_SETTER):
2267         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2268         (WebCore::CALLBACK_FUNC_DECL):
2269         (WebCore::INDEXED_PROPERTY_GETTER):
2270         (WebCore::INDEXED_PROPERTY_SETTER):
2271
2272 2009-11-10  Oliver Hunt  <oliver@apple.com>
2273
2274         Chrome build fix.
2275
2276         * bindings/v8/V8Index.h:
2277
2278 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2279
2280         Reviewed by Reviewed by Jan Alonzo.
2281
2282         https://bugs.webkit.org/show_bug.cgi?id=30901
2283         [Gtk] Need to de-lint the Atk a11y code
2284
2285         Removal of various and sundry style-violating nits.
2286
2287         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2288
2289 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2290
2291         Reviewed by Jan Alonzo.
2292
2293         https://bugs.webkit.org/show_bug.cgi?id=31047
2294         [GTK] Failing test media/video-played-ranges-1.html
2295
2296         Fix playback rate setter by remembering the rate was changed. Also
2297         correctly handle reverse playback by doing a seek from end to
2298         beginning of the media.
2299
2300         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2301         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2302         (WebCore::MediaPlayerPrivate::currentTime):
2303         (WebCore::MediaPlayerPrivate::seek):
2304         (WebCore::MediaPlayerPrivate::hasAudio):
2305         (WebCore::MediaPlayerPrivate::setVolume):
2306         (WebCore::MediaPlayerPrivate::setRate):
2307         (WebCore::MediaPlayerPrivate::updateStates):
2308         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2309
2310 2009-11-10  Oliver Hunt  <oliver@apple.com>
2311
2312         Reviewed by Maciej Stachowiak.
2313
2314         Rename 3D Canvas related classes to use WebGL prefix
2315         https://bugs.webkit.org/show_bug.cgi?id=29095
2316
2317         Automatic rename of all WebGL related types from Canvas* to
2318         WebGL* per more recent version of the WebGL spec.
2319
2320         Due to the automatic rename I've removed the 600+ line change list.
2321
2322 2009-11-09  Dirk Schulze  <krit@webkit.org>
2323
2324         Reviewed by Oliver Hunt.
2325
2326         SVG feDisplacementMap is not implemented
2327         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2328
2329         This is the implementation of the SVG filter effect
2330         feDisplacementMap. 
2331
2332         Test: svg/filters/feDisplacementMap.svg
2333
2334         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2335         (WebCore::FEDisplacementMap::apply):
2336
2337 2009-11-09  Kent Tamura  <tkent@chromium.org>
2338
2339         Reviewed by Darin Adler.
2340
2341         Add a comment about null strings and hash functions.
2342         https://bugs.webkit.org/show_bug.cgi?id=29118
2343
2344         * platform/text/StringHash.h:
2345
2346 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2347
2348         Reviewed by Darin Adler.
2349
2350         Compiler warnings in InspectorResource.h
2351         https://bugs.webkit.org/show_bug.cgi?id=29231
2352
2353         Fix compilation warnings by removing addition operation on an enum type.
2354
2355         * inspector/InspectorResource.h:
2356         (WebCore::InspectorResource::):
2357         (WebCore::InspectorResource::Changes::hasChange):
2358         (WebCore::InspectorResource::Changes::set):
2359         (WebCore::InspectorResource::Changes::setAll):
2360
2361 2009-11-09  Anders Carlsson  <andersca@apple.com>
2362
2363         Reviewed by Darin Adler and Dan Bernstein.
2364
2365         <rdar://problem/7328395>
2366         https://bugs.webkit.org/show_bug.cgi?id=31277
2367
2368         When an object tag's style changes (for example when child nodes are added/removed),
2369         reuse its Frame (if it has one) instead of creating multiple Frames.
2370
2371         Test: fast/dom/HTMLObjectElement/children-changed.html
2372
2373         * loader/FrameLoader.cpp:
2374         (WebCore::FrameLoader::requestObject):
2375
2376 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2377
2378         Reviewed by Kenneth Rohde Christiansen.
2379
2380         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2381         since adjustment of RW-section base address will be needed for all new symbian
2382         tool chains, specifically for arm and gcc compilation targets.
2383         Also, change target address to 0xE00000 to be sufficient for all targets.
2384
2385         * WebCore.pro:
2386
2387 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2388
2389         Reviewed by Timothy Hatcher.
2390
2391         Web Inspector: Crash when inspecting
2392         WebCore\manual-tests\inspector\dom-mutation.html
2393
2394         https://bugs.webkit.org/show_bug.cgi?id=31259
2395
2396         * inspector/InspectorDOMAgent.cpp:
2397         (WebCore::InspectorDOMAgent::handleEvent):
2398
2399 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2400
2401         Reviewed by Kenneth Rohde Christiansen.
2402
2403         [Qt] Few classes have virtual functions but non-virtual destructor
2404         https://bugs.webkit.org/show_bug.cgi?id=31269
2405
2406         No new tests as there is no functional change.
2407
2408         * platform/qt/QWebPageClient.h:
2409         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2410
2411 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2412
2413         Reviewed by Kenneth Rohde Christiansen.
2414
2415         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2416         https://bugs.webkit.org/show_bug.cgi?id=31140
2417
2418         QtNetwork interprets null string as request to remove the header, not add it.
2419         Replace null values with empty values before passing them to QtNetwork.
2420
2421         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2422
2423         * platform/network/qt/ResourceRequestQt.cpp:
2424         (WebCore::ResourceRequest::toNetworkRequest):
2425
2426 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2427
2428         Reviewed by Kevin Ollivier.
2429
2430         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2431         simply ignored before resulting in transparent areas being black in PNG
2432         images for example.
2433         
2434         https://bugs.webkit.org/show_bug.cgi?id=30823
2435
2436         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2437         (WebCore::RGBA32Buffer::asNewNativeImage):
2438
2439 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2440
2441         Reviewed by Kenneth Rohde Christiansen.
2442
2443         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2444         https://bugs.webkit.org/show_bug.cgi?id=31040
2445
2446         No new tests as there is no functional change.
2447
2448         * dom/Document.cpp:
2449         (WebCore::Document::recalcStyleSelector):
2450         * editing/TextIterator.cpp:
2451         (WebCore::pushFullyClippedState):
2452         * editing/VisibleSelection.cpp:
2453         (WebCore::VisibleSelection::appendTrailingWhitespace):
2454         * html/HTMLLinkElement.cpp:
2455         (WebCore::HTMLLinkElement::process):
2456         * loader/RedirectScheduler.cpp:
2457         (WebCore::RedirectScheduler::mustLockBackForwardList):
2458         * loader/appcache/ApplicationCacheGroup.cpp:
2459         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2460         * platform/graphics/qt/FontCacheQt.cpp:
2461         (WebCore::FontPlatformDataCacheKey::computeHash):
2462         * rendering/RenderBlock.cpp:
2463         (WebCore::RenderBlock::handleRunInChild):
2464         * rendering/RenderBox.cpp:
2465         (WebCore::RenderBox::calcHeight):
2466         * rendering/RenderTextControlMultiLine.cpp:
2467         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2468         * rendering/style/RenderStyle.cpp:
2469         (WebCore::RenderStyle::diff):
2470         * svg/SVGAnimateElement.cpp:
2471         (WebCore::parseNumberValueAndUnit):
2472         * svg/SVGAnimationElement.cpp:
2473         (WebCore::SVGAnimationElement::startedActiveInterval):
2474         * svg/SVGPreserveAspectRatio.cpp:
2475         (WebCore::SVGPreserveAspectRatio::getCTM):
2476
2477 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2478
2479         Reviewed by Dimitri Glazkov.
2480
2481         Win chromium is slow to draw transparent texts
2482         https://bugs.webkit.org/show_bug.cgi?id=31258
2483
2484         Clip graphics context to reduce calculation.
2485
2486         No new tests because this change only affects performance.
2487
2488         * platform/graphics/chromium/FontChromiumWin.cpp:
2489         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2490         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2491
2492 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2493
2494         Reviewed by Darin Adler.
2495
2496         showTree(CounterNode*) generates too little info and has too many spaces.
2497         https://bugs.webkit.org/show_bug.cgi?id=31212
2498
2499         No new tests as the change has no functional effect it is just for
2500         improved debugging.
2501
2502         * rendering/CounterNode.cpp:
2503         (WebCore::showTreeAndMark):
2504         Changed to also show addresses of parent, next and previous
2505         siblings.
2506
2507 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2508
2509         Reviewed by Darin Adler.
2510
2511         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2512         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2513
2514         https://bugs.webkit.org/show_bug.cgi?id=31083
2515
2516         No new tests; implementation is unchanged.
2517
2518         * page/Frame.cpp:
2519         (WebCore::Frame::setUseSecureKeyboardEntry):
2520         * page/mac/FrameMac.mm:
2521
2522 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2523
2524         Reviewed by Jan Alonzo.
2525
2526         Make XP_UNIX tests consistent
2527         https://bugs.webkit.org/show_bug.cgi?id=31250
2528
2529         No new tests as there is no functional change.
2530
2531         * plugins/PluginView.cpp:
2532         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2533         instead of the value of the macro
2534
2535         * plugins/gtk/PluginViewGtk.cpp:
2536         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2537         defined instead of using the PLATFORM macro to be consistent
2538         (WebCore::PluginView::getValue): Ditto.
2539
2540 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2541
2542         Reviewed by Darin Adler.
2543
2544         Thunk to the main thread from ~Database to deref Database's m_document.
2545
2546         If the Database was the Document's last referrer, then ~Document occurs on the
2547         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2548         ASSERT in debug builds.
2549
2550         * storage/Database.cpp:
2551         (WebCore::derefDocument):
2552         (WebCore::Database::~Database):
2553
2554 2009-11-09  Mark Mentovai  <mark@chromium.org>
2555
2556         Reviewed by Dan Bernstein.
2557
2558         Track "can have scrollbar" state within FrameView independently of the
2559         individual scrollbar states in ScrollView.
2560
2561         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2562         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2563         edit mode.
2564
2565         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2566         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2567
2568         Test: fast/overflow/scrollbar-restored.html
2569
2570         * WebCore.base.exp:
2571         * page/FrameView.cpp:
2572         (WebCore::FrameView::FrameView):
2573         (WebCore::FrameView::resetScrollbars):
2574         (WebCore::FrameView::setCanHaveScrollbars):
2575         (WebCore::FrameView::updateCanHaveScrollbars):
2576         (WebCore::FrameView::layout):
2577         * page/FrameView.h:
2578         * platform/ScrollView.h:
2579
2580 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2581
2582         Reviewed by Timothy Hatcher.
2583
2584         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2585         https://bugs.webkit.org/show_bug.cgi?id=31257
2586
2587         * inspector/front-end/SourceFrame.js:
2588
2589 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2590
2591         Reviewed by Timothy Hatcher.
2592
2593         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2594         https://bugs.webkit.org/show_bug.cgi?id=31252
2595
2596         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2597
2598         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2599
2600         * inspector/front-end/ConsoleView.js:
2601         (WebInspector.ConsoleView.prototype._promptKeyDown):
2602         * inspector/front-end/utilities.js:
2603         ():
2604         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2605
2606 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2607
2608         Reviewed by Kenneth Rohde Christiansen.
2609
2610         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2611         https://bugs.webkit.org/show_bug.cgi?id=31208
2612
2613         After r42483, the credentials are no longer passed to the network request
2614         in the URL of the request.
2615         Pass the credentials from XMLHTTPRequest to the network request, the same
2616         way that other ports do.
2617
2618         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2619
2620         * platform/network/qt/ResourceHandleQt.cpp:
2621         (WebCore::ResourceHandle::start):
2622         (WebCore::ResourceHandle::loadResourceSynchronously):
2623
2624 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2625
2626         Unreviewed.
2627
2628         https://bugs.webkit.org/show_bug.cgi?id=31161
2629
2630         Roll back r50657 because it breaks the MAC builds.
2631
2632         * loader/ImageLoader.cpp:
2633         * loader/ProgressTracker.cpp:
2634         * loader/RedirectScheduler.cpp:
2635         * loader/Request.h:
2636         * loader/ThreadableLoaderClient.h:
2637         * loader/WorkerThreadableLoader.h:
2638         * loader/appcache/ApplicationCacheHost.h:
2639         * loader/appcache/ApplicationCacheStorage.h:
2640         * loader/icon/IconDatabaseClient.h:
2641
2642 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2643
2644         Reviewed by Darin Adler.
2645
2646         Allow custom memory allocation control for the part of loader directory in WebCore
2647         https://bugs.webkit.org/show_bug.cgi?id=31161
2648
2649         Inherits the following classes from Noncopyable because these are instantiated
2650         by 'new' and these are no need to be copyable:
2651
2652         class Request - WebCore/loader/loader.cpp:100
2653         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2654         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2655         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2656         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2657         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2658         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2659
2660         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2661         MainThreadBridge is instantiated by 'new' in 
2662         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2663
2664         ThreadableLoaderClient's inheriting has been changed to public.
2665
2666         * loader/ImageLoader.cpp:
2667         * loader/ProgressTracker.cpp:
2668         * loader/RedirectScheduler.cpp:
2669         * loader/Request.h:
2670         * loader/ThreadableLoaderClient.h:
2671         * loader/WorkerThreadableLoader.h:
2672         * loader/appcache/ApplicationCacheHost.h:
2673         * loader/appcache/ApplicationCacheStorage.h:
2674         * loader/icon/IconDatabaseClient.h:
2675
2676 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2677
2678         Reviewed by Darin Adler.
2679
2680         Allow custom memory allocation control for WebCore's DocLoader
2681         https://bugs.webkit.org/show_bug.cgi?id=31163
2682
2683         Inherits DocLoader class from Noncopyable because it is
2684         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2685         it is no need to be copyable.
2686
2687         * loader/DocLoader.h:
2688
2689 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2690
2691         Reviewed by Darin Adler.
2692
2693         Allow custom memory allocation control for WebCore's Tokenizer
2694         https://bugs.webkit.org/show_bug.cgi?id=31162
2695
2696         Inherits Tokenizer class from Noncopyable because (its child class)
2697         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2698         and it is no need to be copyable.
2699
2700         * dom/Tokenizer.h:
2701
2702 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2703
2704         Reviewed by Darin Adler.
2705
2706         Allow custom memory allocation control for WebCore's DeleteButtonController
2707         https://bugs.webkit.org/show_bug.cgi?id=31105
2708
2709         Inherits DeleteButtonController class from Noncopyable because it is 
2710         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2711         it is no need to be copyable.  
2712
2713         * editing/DeleteButtonController.h:
2714
2715 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2716
2717         Reviewed by Jan Alonzo.
2718
2719         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2720         https://bugs.webkit.org/show_bug.cgi?id=30482
2721
2722         Expose Page::tabKeyCyclesThroughElements as a property of
2723         WebKitWebView.
2724
2725         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2726
2727         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2728         (WebCore::singleCharacterString):
2729
2730 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2731
2732         Reviewed by Xan Lopez.
2733
2734         https://bugs.webkit.org/show_bug.cgi?id=25415
2735         [GTK][ATK] Please implement support for get_text_at_offset
2736
2737         Fix a crasher that occurred with text which included newline
2738         chars in the markup.
2739
2740         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2741         (convertUniCharToUTF8):
2742
2743 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2744
2745         Reviewed by Holger Freyther.
2746
2747         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2748         https://bugs.webkit.org/show_bug.cgi?id=31144
2749
2750         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2751         documents that end prematurely but are not considered invalid by QXmlStream.
2752         This is to stay compatible with the libxml2 implementation.
2753         However, that code path would be also hit in situations when it should not,
2754         i.e. the error would have already been caught and handled. As a result, the
2755         same error would be reported twice.
2756
2757         No new tests, because the problem is already covered by
2758         fast/parser/xml-declaration-missing-ending-mark.html.
2759
2760         * dom/XMLTokenizerQt.cpp:
2761         (WebCore::XMLTokenizer::doEnd):
2762
2763 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2764
2765         Reviewed by Pavel Feldman.
2766
2767         Web Inspector: Inspector should support copy() in the command line
2768         https://bugs.webkit.org/show_bug.cgi?id=31238
2769
2770         * inspector/InspectorBackend.cpp:
2771         (WebCore::InspectorBackend::copyText): Added.
2772         * inspector/InspectorBackend.h: Added copyText
2773         * inspector/InspectorBackend.idl: Added copyText
2774         * inspector/front-end/InjectedScript.js:
2775         (InjectedScript._copy): Added.
2776         (InjectedScript._ensureCommandLineAPIInstalled):
2777
2778 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2779
2780         Reviewed by Dimitri Glazkov.
2781
2782         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2783         https://bugs.webkit.org/show_bug.cgi?id=31226
2784
2785         Now checks to see what type of context is active and creates the
2786         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2787
2788         Added support for converting to SharedWorkers and SharedWorkerContexts.
2789
2790         Test: Existing layout tests cover this case (start passing in Chrome).
2791
2792         * bindings/v8/WorkerContextExecutionProxy.cpp:
2793         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2794         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2795         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2796         Added support for SHAREDWORKERCONTEXT.
2797         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2798         Added support for SharedWorker and SharedWorkerContext.
2799
2800 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2801
2802         Reviewed by Dimitri Glazkov.
2803
2804         https://bugs.webkit.org/show_bug.cgi?id=31224
2805         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2806
2807         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2808
2809         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2810         (WebCore::NAMED_PROPERTY_GETTER):
2811
2812 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2813
2814         Reviewed by Timothy Hatcher.
2815
2816         Web Inspector: "Search again" on scripts panel switches
2817         to the script this search started with.
2818
2819         https://bugs.webkit.org/show_bug.cgi?id=31243
2820
2821         * inspector/front-end/Panel.js:
2822         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2823
2824 2009-11-08  Kent Tamura  <tkent@chromium.org>
2825
2826         Reviewed by Darin Adler.
2827
2828         Simplify Icon interface.
2829         https://bugs.webkit.org/show_bug.cgi?id=31154
2830
2831         - Remove Icon::createIconForFile().  createIconForFiles() covers
2832           createIconForFile()'s role.
2833         - Remove FileChooser::chooseIcon()
2834         - Change the parameter types of FileChooser constructor and the
2835           factory method, String -> const Vector<String>&, in order to
2836           support initialization with multiple files.
2837         - Remove the icon loading code in IconChromiumWin.cpp, which
2838           doesn't work because of the sandbox.
2839
2840         No tests because it's just a refactoring.
2841
2842         * platform/FileChooser.cpp:
2843         (WebCore::FileChooser::FileChooser):
2844         (WebCore::FileChooser::create):
2845         (WebCore::FileChooser::chooseFile):
2846         (WebCore::FileChooser::chooseFiles):
2847         * platform/FileChooser.h:
2848         * platform/graphics/Icon.h:
2849         * platform/graphics/chromium/IconChromiumLinux.cpp:
2850         * platform/graphics/chromium/IconChromiumMac.cpp:
2851         * platform/graphics/chromium/IconChromiumWin.cpp:
2852         (WebCore::Icon::createIconForFiles):
2853         * platform/graphics/gtk/IconGtk.cpp:
2854         (WebCore::Icon::createIconForFiles):
2855         * platform/graphics/haiku/IconHaiku.cpp:
2856         * platform/graphics/mac/IconMac.mm:
2857         (WebCore::Icon::createIconForFiles):
2858         * platform/graphics/qt/IconQt.cpp:
2859         (WebCore::Icon::createIconForFiles):
2860         * platform/graphics/win/IconWin.cpp:
2861         (WebCore::Icon::createIconForFiles):
2862         * platform/graphics/wx/IconWx.cpp:
2863         * rendering/RenderFileUploadControl.cpp:
2864         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2865
2866 2009-11-08  Daniel Bates  <dbates@webkit.org>
2867
2868         Reviewed by Adam Barth.
2869
2870         https://bugs.webkit.org/show_bug.cgi?id=31098
2871
2872         Allows same-origin plugin-based content to load.
2873
2874         Test: http/tests/security/xssAuditor/object-src-inject.html
2875
2876         * page/XSSAuditor.cpp:
2877         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2878         (WebCore::XSSAuditor::canLoadObject): Ditto.
2879         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2880         (WebCore::XSSAuditor::isSameOriginResource): Added.
2881         * page/XSSAuditor.h:
2882
2883 2009-11-08  David Levin  <levin@chromium.org>
2884
2885         Reviewed by NOBODY (chromium build fix).
2886
2887         * platform/network/HTTPParsers.cpp:
2888         (WebCore::parseDate): Changed this to not
2889         use a date parser that needs ExecState passed.
2890         
2891 2009-11-08  David Levin  <levin@chromium.org>
2892
2893         Unreviewed build fix for chromium.
2894
2895         * platform/graphics/skia/GraphicsContextSkia.cpp:
2896         (WebCore::GraphicsContext::fillPath):
2897         (WebCore::GraphicsContext::fillRect):
2898         (WebCore::GraphicsContext::strokePath):
2899         (WebCore::GraphicsContext::strokeRect):
2900
2901 2009-11-08  David Levin  <levin@chromium.org>
2902
2903         Unreviewed build fix for chromium.
2904
2905         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2906         Clean up GraphicsContext's current concept of ColorSpace
2907
2908         * platform/graphics/skia/GraphicsContextSkia.cpp:
2909         (WebCore::GraphicsContext::fillPath):
2910         (WebCore::GraphicsContext::fillRect):
2911         (WebCore::GraphicsContext::strokePath):
2912         (WebCore::GraphicsContext::strokeRect):
2913
2914 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2915
2916         Reviewed by Timothy Hatcher.
2917
2918         Web Inspector: [REGRESSION] committing style edit
2919         clears elements panel selection.
2920
2921         https://bugs.webkit.org/show_bug.cgi?id=31242
2922
2923         * inspector/front-end/ElementsTreeOutline.js:
2924         (WebInspector.ElementsTreeOutline.prototype.update):
2925         * inspector/front-end/StylesSidebarPane.js:
2926         (WebInspector.StylePropertyTreeElement.prototype.):
2927         (WebInspector.StylePropertyTreeElement.prototype):
2928
2929 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2930
2931         Reviewed by Holger Freyther.
2932
2933         ResourceRequest to be class instead of struct
2934         https://bugs.webkit.org/show_bug.cgi?id=30670
2935
2936         Started as a compilation fix for Symbian where the compiler makes a distinction between
2937         class and struct in function argument signatures.
2938         Changed all forward declarations of ResourceRequest to have class in the forward
2939         declaration instead of struct and changed the definition of ResourceRequest to be class
2940         and added access qualifiers where missing. Additionally two references of friend
2941         struct ResourceRequestBase changed to class instead.
2942
2943         * history/HistoryItem.h:
2944         * inspector/InspectorController.h:
2945         * inspector/InspectorResource.h:
2946         * loader/DocumentThreadableLoader.h:
2947         * loader/FrameLoaderClient.h:
2948         * loader/MainResourceLoader.h:
2949         * loader/ResourceLoadNotifier.h:
2950         * loader/SubresourceLoader.h:
2951         * loader/SubresourceLoaderClient.h:
2952         * loader/ThreadableLoader.h:
2953         * loader/WorkerThreadableLoader.h:
2954         * loader/appcache/ApplicationCache.h:
2955         * loader/appcache/ApplicationCacheHost.h:
2956         * platform/CrossThreadCopier.h:
2957         * platform/network/ResourceHandle.h:
2958         * platform/network/ResourceHandleClient.h:
2959         * platform/network/ResourceRequestBase.h:
2960         * platform/network/cf/ResourceRequest.h:
2961         * platform/network/cf/ResourceRequestCFNet.h:
2962         * platform/network/chromium/ResourceRequest.h:
2963         * platform/network/curl/ResourceRequest.h:
2964         * platform/network/qt/ResourceRequest.h:
2965         * platform/network/soup/ResourceRequest.h:
2966         * xml/XMLHttpRequest.h:
2967
2968 2009-11-08  Dan Bernstein  <mitz@apple.com>
2969
2970         Reviewed by Simon Fraser.
2971
2972         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2973         below FrameView::layout
2974         https://bugs.webkit.org/show_bug.cgi?id=31093
2975
2976         Test: fast/block/positioning/relative-positioned-inline-container.html
2977
2978         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2979         to mark the object for layout, doing so without marking its ancestors.
2980         However, RenderBlock::skipLeadingWhitespace and
2981         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2982         positioned inline container, causing it to be marked for layout without
2983         ever going back to give it layout, and thus layout could end with a
2984         dirty object still in the tree, leading to all sorts of badness.
2985
2986         The fix is to revert setStaticY() to not marking the object dirty, and
2987         instead do it in the call sites that require it, which are in
2988         RenderBlock and RenderFlexibleBox.
2989
2990         * rendering/RenderBlock.cpp:
2991         (WebCore::RenderBlock::adjustPositionedBlock):
2992         * rendering/RenderFlexibleBox.cpp:
2993         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2994         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2995         * rendering/RenderLayer.cpp:
2996         * rendering/RenderLayer.h:
2997         (WebCore::RenderLayer::setStaticY):
2998
2999 2009-11-07  Daniel Bates  <dbates@webkit.org>
3000
3001         Reviewed by Darin Adler.
3002
3003         https://bugs.webkit.org/show_bug.cgi?id=20780
3004         
3005         Fixes an issue where the onchange event handler is not fired when the 
3006         input field is autocompleted.
3007         
3008         We cannot test this using DRT since DRT cannot emulate autocompletion.
3009         So, a manual-test is included.
3010
3011         Tests: manual-tests/autocompletion-fire-onchange.html
3012
3013         * manual-tests/autocompletion-fire-onchange.html: Added.
3014         * rendering/RenderTextControl.cpp:
3015         (WebCore::RenderTextControl::setInnerTextValue):
3016
3017 2009-11-07  Benjamin Otte  <otte@gnome.org>
3018
3019         Reviewed by Holger Freyther.
3020
3021         Mark redrawn areas on image surfaces as dirty.
3022
3023         This is required to conform to the Cairo API, but is currently only
3024         used by debugging tools like cairo-trace.
3025
3026         * platform/graphics/cairo/ImageBufferCairo.cpp:
3027         (WebCore::ImageBuffer::platformTransformColorSpace):
3028         (WebCore::putImageData):
3029
3030 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3031
3032         Reviewed by Xan Lopez.
3033
3034         https://bugs.webkit.org/show_bug.cgi?id=30878
3035         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
3036
3037         If the end_offset is -1, use the String length as the end_offset.
3038
3039         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3040         (webkit_accessible_text_get_text):
3041
3042 2009-11-06  Beth Dakin  <bdakin@apple.com>
3043
3044         Reviewed by Adele Peterson.
3045
3046         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
3047         GraphicsContext's current concept of ColorSpace
3048
3049         ColorSpace is now called ColorType. The variables on the state we 
3050         appropriately re-named as well. I removed strokeColorSpace() and 
3051         fillColorSpace() from GraphicsContext since they were never called. 
3052
3053         * platform/graphics/GraphicsContext.cpp:
3054         (WebCore::GraphicsContext::setStrokeColor):
3055         (WebCore::GraphicsContext::setFillColor):
3056         (WebCore::GraphicsContext::setStrokePattern):
3057         (WebCore::GraphicsContext::setFillPattern):
3058         (WebCore::GraphicsContext::setStrokeGradient):
3059         (WebCore::GraphicsContext::setFillGradient):
3060         * platform/graphics/GraphicsContext.h:
3061         (WebCore::):
3062         * platform/graphics/GraphicsContextPrivate.h:
3063         (WebCore::GraphicsContextState::GraphicsContextState):
3064         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3065         (WebCore::GraphicsContext::fillPath):
3066         (WebCore::GraphicsContext::strokePath):
3067         * platform/graphics/cg/GraphicsContextCG.cpp:
3068         (WebCore::calculateDrawingMode):
3069         (WebCore::GraphicsContext::drawPath):
3070         (WebCore::GraphicsContext::fillPath):
3071         (WebCore::GraphicsContext::strokePath):
3072         (WebCore::GraphicsContext::fillRect):
3073         (WebCore::GraphicsContext::strokeRect):
3074         * platform/graphics/qt/GraphicsContextQt.cpp:
3075         (WebCore::GraphicsContext::fillPath):
3076         (WebCore::GraphicsContext::strokePath):
3077         (WebCore::GraphicsContext::fillRect):
3078         * platform/graphics/wince/GraphicsContextWince.cpp:
3079         (WebCore::GraphicsContext::fillPath):
3080         (WebCore::GraphicsContext::fillRect):
3081
3082 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
3083
3084         Reviewed by Tim Hatcher.
3085
3086         Fixes <http://webkit.org/b/31177>.
3087         Web Inspector: Bind backspace to delete cookies and DOM Storage.
3088         
3089         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
3090         places in the inspector can use editing in DataGrid (added a FIXME for
3091         some stuff that needs to be generalized).
3092         
3093         Also added deleting functionality to DataGrid, and implemented it for
3094         Cookies and DOM Storage. The reason this patch is so big is because of
3095         the refactoring of editing code, which won't be used yet in a cross-datagrid
3096         way, but should be able to.
3097         
3098         Additionally, moved the callbacks members from DOMStorageDataGrid to
3099         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
3100         make the architecture of DOM Storage look a lot more like the Cookies view.
3101         
3102         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
3103         inspector from beeping at you when you delete an element.
3104
3105         * WebCore.gypi: Removed DOMStorageDataGrid.
3106         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
3107         * inspector/front-end/CookieItemsView.js:
3108         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
3109         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
3110         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
3111         * inspector/front-end/DOMStorageDataGrid.js: Removed.
3112         * inspector/front-end/DOMStorageItemsView.js:
3113         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
3114         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
3115         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
3116         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
3117         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
3118         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
3119         * inspector/front-end/DataGrid.js:
3120         (WebInspector.DataGrid):
3121         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
3122         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
3123         (WebInspector.DataGrid.prototype._startEditing): Ditto.
3124         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
3125         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
3126         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
3127         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
3128         * inspector/front-end/ElementsTreeOutline.js:
3129         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
3130         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
3131         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
3132
3133 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3134
3135         Qt build fix: added an ExecState parameter.
3136
3137         * bridge/qt/qt_runtime.cpp:
3138         (JSC::Bindings::convertValueToQVariant):
3139         (JSC::Bindings::convertQVariantToValue):
3140
3141 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3142
3143         https://bugs.webkit.org/show_bug.cgi?id=31197
3144         Implemented a timezone cache not based on Mac OS X's notify_check API.
3145
3146         Updated for JavaScriptCore internal API change.
3147
3148         * bridge/qt/qt_runtime.cpp:
3149         (JSC::Bindings::convertValueToQVariant):
3150         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
3151
3152         * platform/network/HTTPParsers.cpp:
3153         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
3154         (This function probably shouldn't be using a JavaScript date parser
3155         to begin with, but oh well.)
3156
3157 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3158
3159         Reviewed by Adam Barth.
3160
3161         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
3162         which affects Chromium only.
3163         
3164         Changes to V8HTMLDocumentCustom.cpp are as below:-
3165         1. The HTMLDocumentOpen function would cause a crash in Chromium if
3166            there was no calling javascript context. We now check for this case
3167            and pass in NULL to the HTMLDocument::open function which can handle
3168            a NULL document parameter.
3169         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
3170            had ASSERTS for a NULL caller frame, which was bogus as it would crash
3171            anyway. We now check for this case and return a failure.
3172            
3173         Changes to V8DOMWindowCustom.cpp are as below:-
3174         1. Instead of failing the window.open call made by NPAPI for lack of a
3175            calling javascript context, we now use the entered context as the calling
3176            context.
3177
3178         Tests: plugins/document-open.html
3179                plugins/window-open.html
3180
3181         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3182         (WebCore::CALLBACK_FUNC_DECL):
3183         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3184         (WebCore::CALLBACK_FUNC_DECL):
3185
3186 2009-11-06  Steve Block  <steveblock@google.com>
3187
3188         Reviewed by Eric Seidel.
3189
3190         Geolocation error code UNKNOWN_ERROR is deprecated.
3191         https://bugs.webkit.org/show_bug.cgi?id=31184
3192
3193         Remove this error code from PositionError, both for use from C++ code and from the JS object.
3194
3195         Updated fast/dom/Geolocation/error.html to test this.
3196
3197         * page/PositionError.h: Modified.
3198         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
3199         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
3200         * page/Geolocation.cpp: Modified.
3201         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3202         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
3203         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3204
3205 2009-11-06  Dirk Schulze  <krit@webkit.org>
3206
3207         Reviewed by Nikolas Zimmermann.
3208
3209         feMorphology filter is not implemented
3210         [https://bugs.webkit.org/show_bug.cgi?id=5863]
3211
3212         The Implementation of feMorphology.
3213         
3214         Test: We have allready a test for feMorphology
3215               svg/W3C-SVG-1.1/filters-morph-01-f.svg
3216
3217         * svg/graphics/filters/SVGFEMorphology.cpp:
3218         (WebCore::FEMorphology::apply):
3219
3220 2009-11-06  Steve Block  <steveblock@google.com>
3221
3222         Reviewed by Eric Seidel.
3223
3224         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3225         https://bugs.webkit.org/show_bug.cgi?id=31209
3226
3227         Build fix only. No new tests possible.
3228
3229         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3230
3231 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3232
3233         Reviewed by David Levin.
3234
3235         V8 bindings do not support SharedWorkers as event targets
3236         https://bugs.webkit.org/show_bug.cgi?id=31199
3237
3238         No new tests because existing layout tests suffice (they currently
3239         crash on Chromium)
3240
3241         * bindings/v8/V8DOMWrapper.cpp:
3242         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3243         Added clause to create a DOM wrapper for SharedWorkers.
3244
3245 2009-11-06  Anton Muhin  <antonm@chromium.org>
3246
3247         Reviewed by Adam Barth.
3248
3249         Do not unnecessarly synchronzie in weak reference callbacks.
3250         https://bugs.webkit.org/show_bug.cgi?id=31191
3251
3252         * bindings/v8/DOMData.h:
3253         (WebCore::DOMData::handleWeakObject):
3254
3255 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3256
3257         Reviewed by Pavel Feldman.
3258
3259         Fix resource content search.
3260         https://bugs.webkit.org/show_bug.cgi?id=31202
3261
3262         * inspector/front-end/AbstractTimelinePanel.js:
3263         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3264         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3265         * inspector/front-end/TimelinePanel.js:
3266         (WebInspector.TimelineGraph.prototype.refresh):
3267
3268 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3269
3270         Reviewed by Eric Seidel.
3271
3272         Fix ASSERT(currentStyle = renderStyle()).
3273         https://bugs.webkit.org/show_bug.cgi?id=31152
3274
3275         * dom/Element.cpp:
3276         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3277
3278 2009-11-05  Alpha Lam  <hclam@chromium.org>
3279
3280         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3281
3282         * bindings/v8/V8GCController.cpp:
3283         (WebCore::V8GCController::gcEpilogue):
3284         * bindings/v8/V8GCController.h:
3285         * bindings/v8/V8Proxy.cpp:
3286         (WebCore::V8Proxy::evaluate):
3287         (WebCore::V8Proxy::runScript):
3288         (WebCore::V8Proxy::callFunction):
3289
3290 2009-11-05  Adam Barth  <abarth@webkit.org>
3291
3292         Reviewed by Sam Weinig.
3293
3294         Cross-domain access to stylesheet text should not be allowed
3295         https://bugs.webkit.org/show_bug.cgi?id=20527
3296
3297         Check whether whether the current document can read the cssRules from
3298         the style sheet.  Firefox throws a security error here, but we return
3299         null instead because that's what we usually do in these cases.
3300
3301         Test: http/tests/security/cannot-read-cssrules-redirect.html
3302               http/tests/security/cannot-read-cssrules.html
3303
3304         * css/CSSStyleSheet.cpp:
3305         (WebCore::CSSStyleSheet::cssRules):
3306
3307 2009-11-05  Steve Block  <steveblock@google.com>
3308
3309         Reviewed by Eric Seidel.
3310
3311         If the Geolocation service fails to start, invoke the error callback asynchronously.
3312         https://bugs.webkit.org/show_bug.cgi?id=28276
3313
3314         All Geolocation callbacks must be invoked asynchronously.
3315         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3316
3317         No new tests possible with current LayoutTestController.
3318
3319         * page/Geolocation.cpp:
3320         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3321         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3322         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3323
3324 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3325
3326         Reviewed by Eric Seidel.
3327
3328         Removed the "this is part of the KDE project" comments from 
3329         all *.h, *.cpp, *.idl, and *.pm files.
3330         
3331         https://bugs.webkit.org/show_bug.cgi?id=31167
3332         
3333         The maintenance and architecture page in the project wiki lists
3334         this as a task.
3335         
3336         This change includes no changes or additions to test cases 
3337         since the change affects only comments.
3338
3339         * bindings/scripts/CodeGeneratorV8.pm:
3340         * bindings/scripts/IDLParser.pm:
3341         * bindings/scripts/IDLStructure.pm:
3342         * css/CSSInheritedValue.cpp:
3343         * css/CSSInitialValue.cpp:
3344         * css/CSSMediaRule.cpp:
3345         * css/CSSNamespace.h:
3346         * css/CSSProperty.cpp:
3347         * css/CSSProperty.h:
3348         * css/CSSRuleList.cpp:
3349         * css/CSSRuleList.h:
3350         * css/CSSSelector.h:
3351         * css/CSSValueList.cpp:
3352         * css/FontValue.cpp:
3353         * css/MediaFeatureNames.cpp:
3354         * css/MediaFeatureNames.h:
3355         * css/Pair.h:
3356         * css/SVGCSSStyleSelector.cpp:
3357         * css/ShadowValue.cpp:
3358         * css/StyleSheet.cpp:
3359         * css/StyleSheetList.cpp:
3360         * css/maketokenizer:
3361         * dom/BeforeUnloadEvent.cpp:
3362         * dom/BeforeUnloadEvent.h:
3363         * dom/CSSMappedAttributeDeclaration.cpp:
3364         * dom/EventNames.cpp:
3365         * dom/EventTarget.cpp:
3366         * dom/MappedAttributeEntry.h:
3367         * dom/MouseRelatedEvent.h:
3368         * dom/RangeException.h:
3369         * dom/StyleElement.h:
3370         * dom/Tokenizer.h:
3371         * html/HTMLHeadElement.h:
3372         * html/HTMLHeadingElement.cpp:
3373         * html/HTMLHeadingElement.h:
3374         * html/HTMLHtmlElement.h:
3375         * html/HTMLImageLoader.h:
3376         * html/HTMLMetaElement.h:
3377         * html/HTMLModElement.cpp:
3378         * html/HTMLModElement.h:
3379         * html/HTMLOptionsCollection.cpp:
3380         * html/HTMLPlugInElement.cpp:
3381         * html/HTMLPreElement.cpp:
3382         * html/HTMLPreElement.h:
3383         * html/HTMLTableCellElement.cpp:
3384         * html/HTMLTableCellElement.h:
3385         * html/HTMLTableColElement.cpp:
3386         * html/HTMLTableColElement.h:
3387         * html/HTMLTablePartElement.cpp:
3388         * html/HTMLTablePartElement.h:
3389         * html/HTMLTitleElement.h:
3390         * page/MouseEventWithHitTestResults.h:
3391         * platform/StaticConstructors.h:
3392         * platform/text/AtomicStringImpl.h:
3393         * platform/text/qt/TextBreakIteratorQt.cpp:
3394         * rendering/AutoTableLayout.h:
3395         * rendering/CounterNode.cpp:
3396         * rendering/EllipsisBox.cpp:
3397         * rendering/EllipsisBox.h:
3398         * rendering/FixedTableLayout.cpp:
3399         * rendering/FixedTableLayout.h:
3400         * rendering/HitTestRequest.h:
3401         * rendering/HitTestResult.h:
3402         * rendering/InlineRunBox.h:
3403         * rendering/PointerEventsHitRules.cpp:
3404         * rendering/PointerEventsHitRules.h:
3405         * rendering/RenderBR.cpp:
3406         * rendering/RenderBR.h:
3407         * rendering/RenderButton.cpp:
3408         * rendering/RenderButton.h:
3409         * rendering/RenderFieldset.cpp:
3410         * rendering/RenderFrameSet.cpp:
3411         * rendering/RenderListItem.cpp:
3412         * rendering/RenderTableRow.cpp:
3413         * rendering/RenderView.h:
3414         * rendering/RootInlineBox.h:
3415         * rendering/SVGInlineTextBox.cpp:
3416         * rendering/SVGInlineTextBox.h:
3417         * rendering/TableLayout.h:
3418         * rendering/break_lines.h:
3419         * rendering/style/SVGRenderStyle.cpp:
3420         * rendering/style/SVGRenderStyle.h:
3421         * rendering/style/SVGRenderStyleDefs.cpp:
3422         * rendering/style/SVGRenderStyleDefs.h:
3423         * svg/GradientAttributes.h:
3424         * svg/LinearGradientAttributes.h:
3425         * svg/PatternAttributes.h:
3426         * svg/RadialGradientAttributes.h:
3427         * svg/SVGAElement.cpp:
3428         * svg/SVGAngle.idl:
3429         * svg/SVGAnimateColorElement.cpp:
3430         * svg/SVGAnimateColorElement.h:
3431         * svg/SVGAnimateElement.cpp:
3432         * svg/SVGAnimateElement.h:
3433         * svg/SVGAnimateTransformElement.h:
3434         * svg/SVGAnimatedPathData.cpp:
3435         * svg/SVGAnimatedPathData.h:
3436         * svg/SVGAnimatedPoints.cpp:
3437         * svg/SVGAnimatedPoints.h:
3438         * svg/SVGAnimationElement.cpp:
3439         * svg/SVGCircleElement.cpp:
3440         * svg/SVGClipPathElement.cpp:
3441         * svg/SVGColor.cpp:
3442         * svg/SVGColor.idl:
3443         * svg/SVGComponentTransferFunctionElement.cpp:
3444         * svg/SVGComponentTransferFunctionElement.h:
3445         * svg/SVGCursorElement.cpp:
3446         * svg/SVGDefsElement.cpp:
3447         * svg/SVGDescElement.cpp:
3448         * svg/SVGDescElement.h:
3449         * svg/SVGDocument.idl:
3450         * svg/SVGElement.idl:
3451         * svg/SVGElementInstanceList.cpp:
3452         * svg/SVGElementInstanceList.h:
3453         * svg/SVGEllipseElement.cpp:
3454         * svg/SVGExternalResourcesRequired.cpp:
3455         * svg/SVGFEBlendElement.cpp:
3456         * svg/SVGFEBlendElement.h:
3457         * svg/SVGFEColorMatrixElement.cpp:
3458         * svg/SVGFEColorMatrixElement.h:
3459         * svg/SVGFEComponentTransferElement.cpp:
3460         * svg/SVGFEComponentTransferElement.h:
3461         * svg/SVGFECompositeElement.cpp:
3462         * svg/SVGFECompositeElement.h:
3463         * svg/SVGFEFloodElement.cpp:
3464         * svg/SVGFEFloodElement.h:
3465         * svg/SVGFEFuncAElement.cpp:
3466         * svg/SVGFEFuncAElement.h:
3467         * svg/SVGFEFuncBElement.cpp:
3468         * svg/SVGFEFuncBElement.h:
3469         * svg/SVGFEFuncGElement.cpp:
3470         * svg/SVGFEFuncGElement.h:
3471         * svg/SVGFEFuncRElement.cpp:
3472         * svg/SVGFEFuncRElement.h:
3473         * svg/SVGFEGaussianBlurElement.cpp:
3474         * svg/SVGFEGaussianBlurElement.h:
3475         * svg/SVGFEImageElement.cpp:
3476         * svg/SVGFEMergeElement.cpp:
3477         * svg/SVGFEMergeElement.h:
3478         * svg/SVGFEMergeNodeElement.cpp:
3479         * svg/SVGFEOffsetElement.cpp:
3480         * svg/SVGFEOffsetElement.h:
3481         * svg/SVGFETileElement.cpp:
3482         * svg/SVGFETileElement.h:
3483         * svg/SVGFETurbulenceElement.cpp:
3484         * svg/SVGFETurbulenceElement.h:
3485         * svg/SVGFilterElement.cpp:
3486         * svg/SVGGElement.cpp:
3487         * svg/SVGGradientElement.cpp:
3488         * svg/SVGHKernElement.idl:
3489         * svg/SVGLangSpace.cpp:
3490         * svg/SVGLangSpace.h:
3491         * svg/SVGLength.cpp:
3492         * svg/SVGLength.h:
3493         * svg/SVGLength.idl:
3494         * svg/SVGLengthList.cpp:
3495         * svg/SVGLengthList.h:
3496         * svg/SVGLineElement.cpp:
3497         * svg/SVGLinearGradientElement.h:
3498         * svg/SVGList.h:
3499         * svg/SVGListTraits.h:
3500         * svg/SVGLocatable.h:
3501         * svg/SVGMaskElement.cpp:
3502         * svg/SVGMatrix.idl:
3503         * svg/SVGMetadataElement.cpp:
3504         * svg/SVGMetadataElement.h:
3505         * svg/SVGMetadataElement.idl:
3506         * svg/SVGNumber.idl:
3507         * svg/SVGNumberList.cpp:
3508         * svg/SVGNumberList.h:
3509         * svg/SVGPaint.cpp:
3510         * svg/SVGPathElement.cpp:
3511         * svg/SVGPathSeg.h:
3512         * svg/SVGPathSegArc.cpp:
3513         * svg/SVGPathSegArc.h:
3514         * svg/SVGPathSegClosePath.cpp:
3515         * svg/SVGPathSegClosePath.h:
3516         * svg/SVGPathSegCurvetoCubic.cpp:
3517         * svg/SVGPathSegCurvetoCubic.h:
3518         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3519         * svg/SVGPathSegCurvetoCubicSmooth.h:
3520         * svg/SVGPathSegCurvetoQuadratic.cpp:
3521         * svg/SVGPathSegCurvetoQuadratic.h:
3522         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3523         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3524         * svg/SVGPathSegLineto.cpp:
3525         * svg/SVGPathSegLineto.h:
3526         * svg/SVGPathSegLinetoHorizontal.cpp:
3527         * svg/SVGPathSegLinetoHorizontal.h:
3528         * svg/SVGPathSegLinetoVertical.cpp:
3529         * svg/SVGPathSegLinetoVertical.h:
3530         * svg/SVGPathSegMoveto.cpp:
3531         * svg/SVGPathSegMoveto.h:
3532         * svg/SVGPatternElement.cpp:
3533         * svg/SVGPoint.idl:
3534         * svg/SVGPointList.cpp:
3535         * svg/SVGPointList.h:
3536         * svg/SVGPolyElement.cpp:
3537         * svg/SVGPolygonElement.cpp:
3538         * svg/SVGPolygonElement.h:
3539         * svg/SVGPolylineElement.cpp:
3540         * svg/SVGPolylineElement.h:
3541         * svg/SVGPreserveAspectRatio.cpp:
3542         * svg/SVGPreserveAspectRatio.h:
3543         * svg/SVGRadialGradientElement.h:
3544         * svg/SVGRect.idl:
3545         * svg/SVGRectElement.cpp:
3546         * svg/SVGRenderingIntent.h:
3547         * svg/SVGSVGElement.idl:
3548         * svg/SVGScriptElement.cpp:
3549         * svg/SVGSetElement.cpp:
3550         * svg/SVGSetElement.h:
3551         * svg/SVGStopElement.cpp:
3552         * svg/SVGStringList.cpp:
3553         * svg/SVGStringList.h:
3554         * svg/SVGStylable.cpp:
3555         * svg/SVGStylable.h:
3556         * svg/SVGStyleElement.cpp:
3557         * svg/SVGStyleElement.h:
3558         * svg/SVGStyledElement.h:
3559         * svg/SVGStyledLocatableElement.cpp:
3560         * svg/SVGStyledLocatableElement.h:
3561         * svg/SVGStyledTransformableElement.cpp:
3562         * svg/SVGStyledTransformableElement.h:
3563         * svg/SVGSwitchElement.cpp:
3564         * svg/SVGSymbolElement.cpp:
3565         * svg/SVGTRefElement.cpp:
3566         * svg/SVGTSpanElement.cpp:
3567         * svg/SVGTSpanElement.h:
3568         * svg/SVGTests.h:
3569         * svg/SVGTextElement.cpp:
3570         * svg/SVGTextElement.h:
3571         * svg/SVGTextPathElement.cpp:
3572         * svg/SVGTextPositioningElement.cpp:
3573         * svg/SVGTextPositioningElement.h:
3574         * svg/SVGTitleElement.cpp:
3575         * svg/SVGTitleElement.h:
3576         * svg/SVGTransform.cpp:
3577         * svg/SVGTransform.h:
3578         * svg/SVGTransform.idl:
3579         * svg/SVGTransformList.cpp:
3580         * svg/SVGTransformList.h:
3581         * svg/SVGTransformable.h:
3582         * svg/SVGURIReference.h:
3583         * svg/SVGUnitTypes.h:
3584         * svg/SVGUseElement.cpp:
3585         * svg/SVGViewElement.cpp:
3586         * svg/SVGZoomAndPan.cpp:
3587         * svg/SVGZoomAndPan.h:
3588         * svg/SVGZoomEvent.cpp:
3589
3590 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3591
3592         Reviewed by Dimitri Glazkov.
3593
3594         REGRESSION Clean up security origin usage in DOM Storage.
3595         https://bugs.webkit.org/show_bug.cgi?id=31188
3596
3597         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3598         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3599
3600         Instead of having StorageAreaSync's constructor (which is called in the
3601         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3602         database identifier, simply have StorageAreaImpl pass the identifier into
3603         StorageAreaSync.
3604
3605         No test because there's no change in externally observable behavior.
3606
3607         * storage/StorageAreaImpl.cpp:
3608         (WebCore::StorageAreaImpl::StorageAreaImpl):
3609         * storage/StorageAreaImpl.h:
3610         * storage/StorageAreaSync.cpp:
3611         (WebCore::StorageAreaSync::create):
3612         (WebCore::StorageAreaSync::StorageAreaSync):
3613         * storage/StorageAreaSync.h:
3614
3615 2009-11-05  Scott Violet  <sky@google.com>
3616
3617         Reviewed by Dimitri Glazkov.
3618
3619         Need notification of scrolling frame
3620         https://bugs.webkit.org/show_bug.cgi?id=31145
3621
3622         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3623         the frame scrolls. This will be used to know when history state
3624         needs to be updated.
3625
3626         * loader/FrameLoaderClient.h:
3627         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3628         * page/FrameView.cpp:
3629         (WebCore::FrameView::valueChanged):
3630
3631 2009-11-05  Kenneth Russell  <kbr@google.com>
3632
3633         Reviewed by Dimitri Glazkov.