Build fix.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-15  Adam Roben  <aroben@apple.com>
2
3         Build fix.
4
5         Rename the items in the ContextMenuAction enum so that they don't
6         conflict with WebKit names.
7
8         * WebCore.xcodeproj/project.pbxproj:
9         * platform/ContextMenu.cpp:
10         (WebCore::ContextMenu::populate):
11         * platform/ContextMenu.h:
12         (WebCore::):
13         (WebCore::ContextMenuItem::ContextMenuItem):
14
15 2006-11-15  Adam Roben  <aroben@apple.com>
16
17         Reviewed by Anders.
18
19         Change m_contextMenu to an OwnPtr.
20
21         * WebCore.xcodeproj/project.pbxproj:
22         * page/ContextMenuController.cpp:
23         (WebCore::ContextMenuController::handleContextMenuEvent):
24         * page/ContextMenuController.h:
25
26 2006-11-15  Adam Roben  <aroben@apple.com>
27
28         Reviewed by Anders.
29
30         Add new ContextMenuController and ContextMenuClient classes, and move
31         context menu responsibilities from Chrome and ChromeClient to them.
32
33         * WebCore.exp:
34         * WebCore.xcodeproj/project.pbxproj: Add new files to project, and
35         alphabetize some others.
36         * page/Chrome.cpp: Remove context menu-related code.
37         * page/Chrome.h: Ditto.
38         * page/ChromeClient.h:
39         * page/ContextMenuClient.h: Added.
40         * page/ContextMenuController.cpp: Added.
41         (WebCore::ContextMenuController::ContextMenuController):
42         (WebCore::ContextMenuController::~ContextMenuController):
43         (WebCore::ContextMenuController::handleContextMenuEvent):
44         (WebCore::ContextMenuController::contextMenuActionSelected):
45         * page/ContextMenuController.h: Added.
46         (WebCore::ContextMenuController::client):
47         * page/Page.cpp: Every Page now has a ContextMenuController.
48         (WebCore::Page::Page):
49         * page/Page.h: Made m_dragCaretController and m_chrome objects instead
50         of pointers to objects.
51         (WebCore::Page::contextMenuController):
52         * platform/ContextMenu.cpp:
53         (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the
54         delegate to add its menu items, and moved the code from the static
55         addDefaultItems function into this method.
56         * platform/ContextMenu.h:
57         (WebCore::ContextMenu::show): Added an empty method body since this
58         method is now called from ContextMenuController (although no one calls
59         into ContextMenuController yet, so it's OK for this to be empty).
60         (WebCore::ContextMenu::hide): Ditto.
61
62 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
63
64         Reviewed by Darin.
65
66         Add null checks on the node filter, they can be null if no filter was passed to the respective
67         create functions.
68         
69         * bindings/js/JSNodeIteratorCustom.cpp:
70         (WebCore::JSNodeIterator::mark):
71         * bindings/js/JSTreeWalkerCustom.cpp:
72         (WebCore::JSTreeWalker::mark):
73
74 2006-11-15  Oliver Hunt  <oliver@apple.com>
75
76         Reviewed by Anders.
77
78         Allow <embed> and <object> tags to include non-plugin
79         content when plugins are disabled
80
81         Fixes <rdar://problems/4839488>
82
83         * html/HTMLEmbedElement.cpp:
84         (WebCore::HTMLEmbedElement::rendererIsNeeded):
85         * html/HTMLObjectElement.cpp:
86         (WebCore::HTMLObjectElement::rendererIsNeeded):
87         * loader/FrameLoader.cpp:
88         (WebCore::FrameLoader::requestObject):
89
90 2006-11-15  Adele Peterson  <adele@apple.com>
91
92         Build fix.  Another type problem that I don't see locally.
93
94         * rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
95
96 2006-11-15  Adele Peterson  <adele@apple.com>
97
98         Reviewed by Adam.
99
100         Adding MathExtras header.
101
102         * rendering/RenderSlider.cpp:
103
104 2006-11-15  Timothy Hatcher  <timothy@apple.com>
105
106         Reviewed by Harrison.
107
108         <rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
109
110         * Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected
111           by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
112
113         * Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before
114           the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
115
116         * Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
117
118         * editing/DeleteButtonController.cpp:
119         (WebCore::DeleteButtonController::DeleteButtonController):
120         (WebCore::isDeletableElement):
121         (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state
122         (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state
123         (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed
124         (WebCore::DeleteButtonController::deleteTarget): check the enabled state
125         * editing/DeleteButtonController.h:
126         (WebCore::DeleteButtonController::disable):
127         (WebCore::DeleteButtonController::enable):
128         (WebCore::DeleteButtonController::enabled):
129         * editing/EditCommand.cpp:
130         (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end
131         (WebCore::EditCommand::unapply): ditto
132         (WebCore::EditCommand::reapply): ditto
133
134 2006-11-15  Adele Peterson  <adele@apple.com>
135
136         Reviewed by Adam.
137
138         New implementation of slider control.
139
140         * WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
141         * rendering/DeprecatedSlider.cpp: Removed.
142         * rendering/DeprecatedSlider.h: Removed.
143         * platform/Slider.h: Removed.
144         * platform/mac/SliderMac.mm: Removed.
145         * platform/win/TemporaryLinkStubs.cpp:
146
147         * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
148         * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
149         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): 
150         * rendering/RenderStyle.cpp:
151         (WebCore::):
152         (WebCore::pseudoBit):
153         * rendering/RenderStyle.h: (WebCore::RenderStyle::):
154
155         * css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
156
157         * html/HTMLInputElement.cpp:
158         (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements.
159         (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
160
161         * page/EventHandler.cpp:  Added concept of a node that will capture all mouse events.  This will be used by the slider thumb, so it can
162           continue to capture mouse move events during the drag, even though those events aren't directly over the slider.
163         (WebCore::EventHandler::EventHandler):
164         (WebCore::EventHandler::setCapturingMouseEventsNode):
165         (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
166         * page/EventHandler.h:
167
168         * rendering/RenderSlider.cpp: Added.
169         (WebCore::HTMLSliderThumbElement::isShadowNode):
170         (WebCore::HTMLSliderThumbElement::shadowParentNode):
171         (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode.
172         (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
173         (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag.
174         (WebCore::RenderSlider::RenderSlider):
175         (WebCore::RenderSlider::~RenderSlider):
176         (WebCore::RenderSlider::baselinePosition):
177         (WebCore::RenderSlider::calcMinMaxWidth):
178         (WebCore::RenderSlider::setStyle):
179         (WebCore::RenderSlider::createThumbStyle):
180         (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track.
181         (WebCore::RenderSlider::updateFromElement):
182         (WebCore::RenderSlider::mouseEventIsInThumb):
183         (WebCore::RenderSlider::setValueForPosition):
184         (WebCore::RenderSlider::setPositionFromValue):
185         (WebCore::RenderSlider::positionForOffset):
186         (WebCore::RenderSlider::valueChanged):
187         (WebCore::RenderSlider::currentPosition):
188         (WebCore::RenderSlider::setCurrentPosition):
189         (WebCore::RenderSlider::trackSize):
190         (WebCore::RenderSlider::forwardEvent):
191         (WebCore::RenderSlider::inDragMode):
192         * rendering/RenderSlider.h: Added.
193         (WebCore::RenderSlider::renderName):
194
195          * rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.
196         (WebCore::RenderTheme::adjustStyle):
197         (WebCore::RenderTheme::paint):
198         (WebCore::RenderTheme::paintBorderOnly):
199         (WebCore::RenderTheme::paintDecorations):
200         (WebCore::RenderTheme::adjustSliderTrackStyle):
201         (WebCore::RenderTheme::adjustSliderThumbStyle):
202         * rendering/RenderTheme.h:
203         (WebCore::RenderTheme::paintSliderTrack):
204         (WebCore::RenderTheme::paintSliderThumb):
205         * rendering/RenderThemeMac.h:
206         * rendering/RenderThemeMac.mm:
207         (WebCore::RenderThemeMac::RenderThemeMac):
208         (WebCore::TrackGradientInterpolate):
209         (WebCore::RenderThemeMac::paintSliderTrack):
210         (WebCore::RenderThemeMac::paintSliderThumb):
211         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
212         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
213
214 2006-11-15  Beth Dakin  <bdakin@apple.com>
215
216         Reviewed by Adam.
217
218         Oops! Forgot to add this!
219
220         * platform/mac/ContextMenuMac.mm: Added.
221         (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]):
222         (-[MenuTarget WebCore::]):
223         (-[MenuTarget setMenu:WebCore::]):
224         (-[MenuTarget forwardContextMenuAction:]):
225         (getNSMenuItem):
226         (ContextMenu::appendItem):
227         (ContextMenu::itemCount):
228         (ContextMenu::insertItem):
229         (ContextMenu::setPlatformMenuDescription):
230
231 2006-11-15  Beth Dakin  <bdakin@apple.com>
232         &   Adam Roben  <aroben@apple.com>
233
234         Reviewed by Adam and Beth.
235
236         Initial cut at pushing Context Menus into WebCore. Nobody actually 
237         calls this code just yet.
238
239         * WebCore.exp:
240         * WebCore.xcodeproj/project.pbxproj:
241         * page/Chrome.cpp:
242         (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to 
243         call into addContextMenuItems on the UIDelegate.
244         * page/Chrome.h:
245         * page/ChromeClient.h:
246         * platform/ContextMenu.cpp: Added.
247         (WebCore::addDefaultItems):
248         (WebCore::ContextMenu::populate):
249         * platform/ContextMenu.h: Added.
250         (WebCore::):
251         (WebCore::ContextMenuItem::ContextMenuItem):
252         (WebCore::ContextMenu::ContextMenu):
253         (WebCore::ContextMenu::hitTestResult):
254         (WebCore::ContextMenu::platformMenuDescription):
255
256 2006-11-15  Adele Peterson  <adele@apple.com>
257
258         Reviewed by Hyatt.
259
260         - Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
261
262         * css/html4.css: Removed "-webkit-user-select: ignore" for labels.
263
264 2006-11-15  David Harrison  <harrison@apple.com>
265
266         Reviewed by Darin.
267
268         <rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
269
270         Test:
271         * manual-tests/keep_spelling_markers.html:
272         Updated to include checking for this bug.
273         
274         * bridge/mac/FrameMac.mm:
275         (WebCore::FrameMac::advanceToNextMisspelling):
276         it.advance() even when current string is a single space.
277
278 2006-11-15  Brady Eidson  <beidson@apple.com>
279
280         Reviewed by lamadio
281
282         Backing out macro expansion
283
284         * WebCore.xcodeproj/project.pbxproj:
285         * html/HTMLElement.cpp:
286         (WebCore::HTMLElement::isRecognizedTagName):
287         * ksvg2/scripts/make_names.pl:
288
289 2006-11-15  David Harrison  <harrison@apple.com>
290
291         Reviewed by Darin.
292
293         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
294
295         The remaining problem was the password fields would return their contents
296         even though they did not advertise that they could. Apparently, VoiceOver
297         does not read the ads.
298
299         * bridge/mac/WebCoreAXObject.mm:
300         (isPasswordFieldElement):
301         (-[WebCoreAXObject isPasswordField]):
302         (-[WebCoreAXObject textMarkerForVisiblePosition:]):
303         (-[WebCoreAXObject accessibilityAttributeValue:]):
304         (-[WebCoreAXObject doAXStringForRange:]):
305
306 2006-11-13  Lou Amadio  <lamadio@apple.com>
307
308         Reviewed by Darin Adler, Maciej Stachowiak
309
310         Cleanup: Expanded macros in generated files
311
312         * html/HTMLElement.cpp:
313         (WebCore::HTMLElement::isRecognizedTagName):
314         * ksvg2/scripts/make_names.pl:
315
316 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
317
318         Reviewed by Geoff.
319
320         Use Vector instead of DeprecatedPtrList.
321         
322         * editing/ApplyStyleCommand.cpp:
323         (WebCore::ApplyStyleCommand::applyBlockStyle):
324         * editing/BreakBlockquoteCommand.cpp:
325         * rendering/RenderFlow.cpp:
326         (WebCore::RenderFlow::paintOutline):
327
328 2006-11-15  Adam Roben  <aroben@apple.com>
329
330         Build fix.
331
332         * page/EventHandler.h:
333
334 2006-11-14  Beth Dakin  <bdakin@apple.com>
335
336         Reviewed by Geoff.
337
338         Move things off the bridge, and move sendContextMenuEvent() from 
339         EventHandlerMac to EventHandler.
340
341         * WebCore.exp:
342         * WebCore.xcodeproj/project.pbxproj:
343         * bridge/EditorClient.h:
344         * bridge/mac/WebCoreFrameBridge.h:
345         * editing/Editor.cpp:
346         (WebCore::Editor::selectWordBeforeMenuEvent):
347         (WebCore::Editor::clientIsEditable):
348         * editing/Editor.h:
349         * page/EventHandler.cpp:
350         (WebCore::EventHandler::sendContextMenuEvent):
351         * page/EventHandler.h:
352         * page/mac/EventHandlerMac.mm:
353
354 2006-11-14  Timothy Hatcher  <timothy@apple.com>
355
356         Reviewed by Harrison.
357
358         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
359
360         Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
361
362         * bridge/mac/WebCoreSettings.mm:
363         (-[WebCoreSettings setEditableLinkBehavior:]):
364         * html/HTMLAnchorElement.cpp:
365         (WebCore::HTMLAnchorElement::defaultEventHandler):
366         (WebCore::HTMLAnchorElement::setActive):
367         (WebCore::HTMLAnchorElement::isLiveLink):
368         * page/FrameView.cpp:
369         (WebCore::selectCursor):
370         * page/Settings.h:
371         (WebCore::Settings::):
372
373 2006-11-14  Mark Rowe  <bdash@webkit.org>
374
375         Reviewed by Oliver.
376
377         Build fix
378
379         * bindings/scripts/CodeGenerator.pm:
380
381 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
382
383         Turns out I wasn't forcing DWARF on the world at all, 
384         it's now the default!
385
386         * WebCore.xcodeproj/project.pbxproj:
387
388 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
389
390         I must stop trying to force DWARF on the world.
391         
392         * WebCore.xcodeproj/project.pbxproj:
393
394 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
395
396         Reviewed by harrison
397         
398         <rdar://problem/4806874>
399         Missing background image after paste
400         
401         * editing/markup.cpp:
402         (WebCore::createMarkup): If the body is fully selected, add a 
403         div with its CSS properties to the markup.  Migrated a use of 
404         enclosingBlockFlowElement to enclosingBlock to fix an infinite 
405         loop when pasting <div><input></div>.
406
407 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
408
409         Reviewed by Adam.
410
411         Add Undo/Redo to execCommand.
412         
413         * editing/Editor.cpp:
414         (WebCore::execRedo):
415         (WebCore::execUndo):
416         (WebCore::canRedo):
417         (WebCore::canUndo):
418         (WebCore::CommandEntry::):
419
420 2006-11-14  Darin Adler  <darin@apple.com>
421
422         Reviewed by Anders.
423
424         - created EventHandler class, moved event handling code from both
425           Frame and FrameView in there
426
427         - added ScrollTypes.h header so you can include the scroller-related
428           enums without all of Scrollbar.h
429
430         * page/EventHandler.cpp: Added.
431         * page/EventHandler.h: Added.
432         * page/mac/EventHandlerMac.mm: Added.
433
434         * platform/ScrollBarMode.h: Removed.
435         * platform/ScrollTypes.h: Added.
436
437         * WebCore.exp:
438         * WebCore.xcodeproj/project.pbxproj:
439         * bridge/mac/FrameMac.h:
440         * bridge/mac/FrameMac.mm:
441         (WebCore::FrameMac::FrameMac):
442         (WebCore::FrameMac::~FrameMac):
443         (WebCore::FrameMac::bridgeForWidget):
444         (WebCore::FrameMac::imageFromRect):
445         * bridge/mac/FrameViewMac.mm:
446         * bridge/mac/WebCoreFrameBridge.mm:
447         (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]):
448         (-[WebCoreFrameBridge nextKeyView]):
449         (-[WebCoreFrameBridge previousKeyView]):
450         (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
451         (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
452         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
453         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
454         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
455         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
456         (-[WebCoreFrameBridge dragSourceMovedTo:]):
457         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
458         * dom/Document.cpp:
459         (WebCore::Document::hoveredNodeDetached):
460         * dom/Element.h:
461         * dom/EventTargetNode.cpp:
462         (WebCore::EventTargetNode::defaultEventHandler):
463         * editing/SelectionController.cpp:
464         (WebCore::SelectionController::SelectionController):
465         * editing/SelectionController.h:
466         (WebCore::SelectionController::setCaretBlinkingSuspended):
467         (WebCore::SelectionController::isCaretBlinkingSuspended):
468         * html/HTMLAnchorElement.cpp:
469         (WebCore::HTMLAnchorElement::isKeyboardFocusable):
470         * html/HTMLFrameElementBase.cpp:
471         (WebCore::HTMLFrameElementBase::setFocus):
472         * html/HTMLFrameElementBase.h:
473         * html/HTMLGenericFormElement.cpp:
474         (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
475         * html/HTMLInputElement.cpp:
476         (WebCore::HTMLInputElement::defaultEventHandler):
477         * html/HTMLSelectElement.cpp:
478         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
479         * loader/FrameLoader.cpp:
480         (WebCore::FrameLoader::clear):
481         (WebCore::FrameLoader::open):
482
483         * page/Frame.cpp:
484         (WebCore::Frame::caretBlinkTimerFired):
485         (WebCore::Frame::frameForWidget):
486         (WebCore::Frame::eventHandler):
487         (WebCore::Frame::setProhibitsScrolling):
488         (WebCore::FramePrivate::FramePrivate):
489         * page/Frame.h:
490         * page/FramePrivate.h:
491         * page/FrameView.cpp:
492         (WebCore::FrameViewPrivate::FrameViewPrivate):
493         (WebCore::FrameViewPrivate::reset):
494         (WebCore::FrameView::FrameView):
495         (WebCore::FrameView::~FrameView):
496         (WebCore::FrameView::clear):
497         (WebCore::FrameView::adjustViewSize):
498         (WebCore::FrameView::addRepaintInfo):
499         (WebCore::FrameView::layout):
500         (WebCore::FrameView::scrollPointRecursively):
501         (WebCore::FrameView::setContentsPos):
502         (WebCore::FrameView::scheduleRelayoutOfSubtree):
503         (WebCore::FrameView::scheduleEvent):
504         (WebCore::FrameView::updateOverflowStatus):
505         (WebCore::FrameView::dispatchScheduledEvents):
506         (WebCore::FrameView::windowClipRectForLayer):
507         (WebCore::FrameView::handleMouseMoveEvent):
508         (WebCore::FrameView::handleMouseReleaseEvent):
509         * page/FrameView.h:
510         * page/PageState.cpp:
511         (WebCore::PageState::PageState):
512         (WebCore::PageState::restore):
513         * page/PageState.h:
514         * platform/ScrollBar.h:
515         * platform/ScrollView.h:
516         * platform/mac/ClipboardMac.mm:
517         * platform/mac/PopupMenuMac.mm:
518         (WebCore::PopupMenu::show):
519         * platform/mac/SliderMac.mm:
520         (-[WebCoreSlider becomeFirstResponder]):
521         (-[WebCoreSlider nextKeyView]):
522         (-[WebCoreSlider previousKeyView]):
523         (-[WebCoreSlider canBecomeKeyView]):
524         (Slider::focusPolicy):
525         * platform/mac/WebCoreTextField.mm:
526         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
527         (-[WebCoreTextFieldController setHasFocus:]):
528         (-[WebCoreSearchField nextKeyView]):
529         (-[WebCoreSearchField previousKeyView]):
530         (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
531         * platform/mac/WidgetMac.mm:
532         (WebCore::Widget::hasFocus):
533         (WebCore::Widget::clearFocus):
534         * rendering/RenderFrameSet.cpp:
535         (WebCore::RenderFrameSet::setResizing):
536         * rendering/RenderLayer.cpp:
537         (WebCore::RenderLayer::autoscroll):
538         (WebCore::RenderLayer::resize):
539         (WebCore::RenderLayer::updateOverflowStatus):
540         * rendering/RenderLayer.h:
541         * rendering/RenderListBox.cpp:
542         (WebCore::RenderListBox::autoscroll):
543         * rendering/RenderObject.cpp:
544         (WebCore::RenderObject::draggableNode):
545         (WebCore::RenderObject::destroy):
546         * rendering/RenderObject.h:
547         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
548         * rendering/RenderPartObject.cpp:
549         (WebCore::RenderPartObject::viewCleared):
550
551 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
552
553         Reviewed by Darin.
554
555         Let the editor client handle undo/redo.
556         
557         * WebCore.exp:
558         * WebCore.xcodeproj/project.pbxproj:
559         * bridge/EditorClient.h:
560         * bridge/mac/FrameMac.h:
561         * bridge/mac/FrameMac.mm:
562         (WebCore::FrameMac::canUndo):
563         (WebCore::FrameMac::canRedo):
564         * bridge/mac/WebCoreEditCommand.h: Removed.
565         * bridge/mac/WebCoreEditCommand.mm: Removed.
566         * bridge/mac/WebCoreFrameBridge.h:
567         * bridge/mac/WebCoreFrameBridge.mm:
568         * editing/Editor.cpp:
569         (WebCore::Editor::appliedEditing):
570         (WebCore::Editor::unappliedEditing):
571         (WebCore::Editor::reappliedEditing):
572         * editing/JSEditor.cpp:
573         * loader/FrameLoader.cpp:
574         (WebCore::FrameLoader::closeURL):
575         * page/Frame.cpp:
576         * page/Frame.h:
577         * rendering/RenderTextControl.cpp:
578         (WebCore::RenderTextControl::updateFromElement):
579
580 2006-11-14  Nikolas Zimmermann  <zimmermann@kde.org>
581
582         Reviewed and landed by Brady
583
584         Fix Qt/Linux build.
585
586         * ChangeLog:
587         * loader/qt/FrameLoaderQt.cpp:
588         (WebCore::FrameLoader::submitForm):
589         * platform/network/qt/ResourceHandleManager.cpp:
590         (WebCore::ResourceHandleManager::add):
591         * platform/qt/FrameQtClient.cpp:
592         (WebCore::FrameQtClientDefault::submitForm):
593         * platform/qt/FrameQtClient.h:
594
595 2006-11-14  Brady Eidson  <beidson@apple.com>
596
597         Reviewed by Anders
598
599         Cleanup of my patch last night and merging with aroben-style changes from this morning
600         (More ref-counted FormData stuff)
601
602         * html/HTMLFormElement.cpp:
603         (WebCore::HTMLFormElement::submit):
604         * loader/FrameLoader.cpp:
605         (WebCore::FrameLoader::submitForm):
606         * platform/network/ResourceHandle.cpp:
607         (WebCore::ResourceHandle::postData):
608         * platform/network/ResourceHandle.h:
609         * platform/network/cf/FormDataStreamCFNet.cpp:
610         (WebCore::setHTTPBody):
611         * platform/network/mac/FormDataStreamMac.h:
612         * platform/network/mac/FormDataStreamMac.mm:
613         (WebCore::getStreamFormDatas):
614         (WebCore::formCreate):
615         (WebCore::formFinalize):
616         (WebCore::setHTTPBody):
617         (WebCore::httpBodyFromStream):
618         * platform/network/mac/ResourceRequestMac.mm:
619         (WebCore::getResourceRequest):
620
621 2006-11-14  Rob Buis  <buis@kde.org>
622
623         Reviewed by Darin.
624
625         http://bugs.webkit.org/show_bug.cgi?id=11575
626         Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
627
628         Test: fast/css/css-imports.html
629
630         * css/CSSImportRule.cpp:
631         (WebCore::CSSImportRule::insertedIntoParent):
632         Fix the crash by testing for null pointer.
633
634 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
635
636         Reviewed by Tim H.
637
638         Test for http://bugs.webkit.org/show_bug.cgi?id=3387
639         Redundant keydown, keypress, keyup events sent for arrow keys
640
641         * manual-tests/arrow-key-events.html: Added.
642
643 2006-11-14  Darin Adler  <darin@apple.com>
644
645         Reviewed by Adam.
646
647         Fix up usages of FormData within CFNet loader code.
648
649         * platform/network/ResourceRequest.h:
650         (WebCore::ResourceRequest::httpBody):
651         * platform/network/cf/FormDataStreamCFNet.cpp:
652         (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the
653         streamFormDatas HashMap.
654         (WebCore::formCreate):
655         (WebCore::formFinalize): Removed delete because the remove() will deref
656         and delete if necessary.
657         (WebCore::setHTTPBody): Changed parameter to PassRefPtr.
658         (WebCore::httpBodyFromStream):
659         * platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
660         * platform/network/cf/ResourceRequestCFNet.cpp:
661         (WebCore::getResourceRequest):
662
663 2006-11-14  Greg Jackson  <gjspanner@gmail.com>
664
665         Reviewed by Darin.
666
667         Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
668         rather than overriding it based on platform detection.
669
670         * bindings/js/kjs_navigator.cpp:
671
672 2006-11-13  Brady Eidson  <beidson@apple.com>
673
674         Reviewed by Maciej
675
676         Made FormData Shared, and pass it around as such.
677
678         * WebCore.xcodeproj/project.pbxproj: Reordered some items
679         * html/HTMLFormElement.cpp:
680         (WebCore::HTMLFormElement::formData):
681         (WebCore::HTMLFormElement::submit):
682         * html/HTMLFormElement.h:
683         * loader/FrameLoader.cpp:
684         (WebCore::FormSubmission::FormSubmission):
685         (WebCore::FrameLoader::submitForm):
686         * loader/FrameLoader.h:
687         * loader/mac/FrameLoaderMac.mm:
688         (WebCore::FrameLoader::post):
689         (WebCore::FrameLoader::loadResourceSynchronously):
690         * loader/mac/SubresourceLoaderMac.mm:
691         (WebCore::SubresourceLoader::create):
692         * platform/network/FormData.h: Made FormData shared
693         * platform/network/ResourceHandle.h:
694         * platform/network/ResourceHandle.cpp:
695         (WebCore::ResourceHandle::postData): 
696         * platform/network/ResourceRequest.h:
697         (WebCore::ResourceRequest::httpBody):
698         (WebCore::ResourceRequest::setHTTPBody): 
699         * platform/network/mac/ResourceRequestMac.mm:
700         (WebCore::getResourceRequest):
701         (WebCore::nsURLRequest): 
702
703         * platform/network/mac/FormDataStreamMac.h:
704         * platform/network/mac/FormDataStreamMac.mm:
705         (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s
706         (WebCore::formCreate):
707         (WebCore::formFinalize):
708         (WebCore::setHTTPBody):
709         (WebCore::httpBodyFromStream):
710
711         * xml/xmlhttprequest.cpp:
712         (WebCore::XMLHttpRequest::send):
713
714 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
715
716         Reviewed by harrison
717         
718         <rdar://problem/4828264>
719         In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)
720         
721         The start of the selection is in an editable area, and the end is in an 
722         input field inside that editable area.  The code that should pull the end
723         of such a selection outside the input field didn't escape shadow nodes,
724         it would leave a dangling end, causing the crash in toRange.
725         
726         * editing/Selection.cpp:
727         (WebCore::Selection::adjustForEditableContent):  Added an ASSERT and a fixup
728         to prevent crashes like this in future Release builds.
729         * editing/htmlediting.cpp:
730         (WebCore::firstEditablePositionAfterPositionInRoot): Let this function 
731         escape shadow nodes.  We might eventually push this code down into 
732         next/previous{VisuallyDistinct}Canditate.
733         (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
734
735 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
736
737         Reviewed by darin
738         
739         * editing/DeleteSelectionCommand.cpp:
740         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
741         * editing/Editor.cpp:
742         (WebCore::Editor::appliedEditing):
743         * editing/Editor.h:
744         (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
745
746 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
747
748         Reviewed by Oliver
749         
750         <rdar://problem/4820026>
751         copy/paste of news.google.com yields text from hidden select element options
752
753         We were adding descendants of unrendered select elements. 
754
755         * editing/markup.cpp:
756         (WebCore::createMarkup): Don't traverse into nodes without renderers, unless 
757         they are grandfathered in by a rendered select element.
758         
759 2006-11-12  Simon Hausmann  <hausmann@kde.org>
760
761         Reviewed by Sam Weinig.
762
763         Fix Qt build. Missing AbstractShared implementation.
764         http://bugs.webkit.org/show_bug.cgi?id=11581
765
766         * loader/qt/FrameLoaderClientQt.cpp:
767         (WebCore::FrameLoaderClientQt::ref):
768         (WebCore::FrameLoaderClientQt::deref):
769         * loader/qt/FrameLoaderClientQt.h:
770         * platform/qt/ChromeClientQt.cpp:
771         (WebCore::ChromeClientQt::ref):
772         (WebCore::ChromeClientQt::deref):
773         * platform/qt/ChromeClientQt.h:
774         * platform/qt/EditorClientQt.cpp:
775         (WebCore::EditorClientQt::ref):
776         (WebCore::EditorClientQt::deref):
777         * platform/qt/EditorClientQt.h:
778
779 2006-11-13  Mark Rowe  <bdash@webkit.org>
780
781         Reviewed by Mitz.
782
783         Fix some Linux/Gdk build issues noted by Alp Toker.
784
785         * Projects/gdk/webcore-gdk.bkl:
786         * WebCoreSources.bkl:
787         * platform/graphics/gdk/ImageGdk.cpp:
788         (WebCore::Image::loadPlatformResource):
789
790 2006-11-12  Brady Eidson <beidson@apple.com>
791
792         Reviewed by Anders
793
794         Logging channel plumbing for future work
795
796         * platform/Logging.cpp:
797         (WebCore::):
798         * platform/Logging.h:
799         * platform/mac/LoggingMac.mm:
800         (WebCore::InitializeLoggingChannelsIfNecessary):
801
802 2006-11-12  Mark Rowe  <bdash@webkit.org>
803
804         Reviewed by Mitz.
805
806         Linux/Gdk compilation fixes, and bakefile cleanups.  Based on patches by
807         Alp Toker.
808
809         * Projects/gdk/webcore-gdk.bkl:
810         * WebCoreSources.bkl:
811         * page/PageState.cpp:
812         * platform/gdk/ChromeClientGdk.h:
813         (WebCore::ChromeClientGdk::ref):
814         (WebCore::ChromeClientGdk::deref):
815         * platform/gdk/FrameGdk.cpp:
816         (WebCore::FrameGdkClientDefault::openURL):
817         (WebCore::FrameGdkClientDefault::didReceiveData):
818         (WebCore::FrameGdkClientDefault::receivedAllData):
819         (WebCore::FrameGdk::FrameGdk):
820         (WebCore::FrameGdk::~FrameGdk):
821         * platform/gdk/FrameGdk.h:
822         * platform/gdk/KeyEventGdk.cpp:
823         (WebCore::keyIdentifierForGdkKeyCode):
824         * platform/gdk/ScreenClientGdk.h: Removed.
825         * platform/gdk/TemporaryLinkStubs.cpp:
826         (FrameGdk::canPaste):
827         (FrameGdk::originalRequestURL):
828         (TextField::TextField):
829         * platform/network/gdk/ResourceHandleManager.cpp:
830         (WebCore::ResourceHandleManager::downloadTimerCallback):
831         (WebCore::ResourceHandleManager::add):
832         (WebCore::ResourceHandleManager::cancel):
833         * webcore-base.bkl:
834
835 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
836
837         Reviewed by Maciej Stachowiak.
838         
839         - Fixed loader crash by clarifying ownership of WebKit client objects. 
840         WebCore objects own their WebKit clients, and ref and deref through 
841         virtual methods, leaving WebKit free to use whatever client / reference-counting 
842         implementation it likes.
843         
844         * WebCore.exp:
845         * WebCore.xcodeproj/project.pbxproj:
846         * bridge/EditorClient.h: Fixed up function prototypes for style.
847         * loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
848         was to implement an alternative ownership model.
849         (WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
850         (WebCore::FrameLoader::setClient): This function now takes ownership
851         (WebCore::FrameLoader::client):
852         * loader/FrameLoader.h:
853         * loader/FrameLoaderClient.h:
854         * page/ChromeClient.h:
855         * platform/AbstractShared.h: Added. This is the virtual function-based refcounting
856         complement to Shared.
857         (WebCore::AbstractShared::~AbstractShared):
858
859 2006-11-11  George Staikos  <staikos@kde.org>
860
861         Reviewed by Maciej.
862
863         Fix uninitialized variable.
864
865         * rendering/RenderStyle.h:
866
867 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
868
869         Reviewed/landed by Adam.
870
871         Complete cleanup of the CMakeLists.txt.
872         Now all files to be built are sorted in alphabetic order.
873
874         General style cleanup, remove all tabs etc.
875
876         * CMakeLists.txt:
877
878 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
879
880         Reviewed by Maciej Stachowiak.
881         
882         Added missing initializer to ResourceRequest -- fixes some loader crashes
883         due to assuming a request always has a non-null httpMethod.
884
885         * platform/network/ResourceRequest.h:
886         (WebCore::ResourceRequest::ResourceRequest):
887
888 2006-11-11  Brady Eidson <beidson@apple.com>
889
890         Reviewed by Maciej
891
892         Fixed header guard
893
894         * loader/FrameLoaderClient.h:
895
896 2006-11-11  Darin Adler  <darin@apple.com>
897
898         - attempt to fix Qt build
899
900         * platform/qt/CursorQt.cpp:
901         (WebCore::verticalTextCursor): Added. Just returns pointer cursor.
902         (WebCore::cellCursor): Ditto.
903         (WebCore::contextMenuCursor): Ditto.
904
905 2006-11-11  Rob Buis  <buis@kde.org>
906
907         Reviewed by hyatt.
908
909         http://bugs.webkit.org/show_bug.cgi?id=10893
910         InsertRule can not handle @import statements
911
912         Allow @import as part of a css rule.
913
914         * css/CSSGrammar.y:
915         * css/CSSImportRule.cpp:
916         (WebCore::CSSImportRule::insertedIntoParent):
917         * css/CSSStyleSheet.cpp:
918         (WebCore::CSSStyleSheet::CSSStyleSheet):
919         (WebCore::CSSStyleSheet::checkLoaded):
920         * css/CSSStyleSheet.h:
921         (WebCore::CSSStyleSheet::loadCompleted):
922
923 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
924
925         Attempt to fix Qt build.
926
927         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
928
929 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
930
931         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
932
933         [CSS 3] support for vertical-text, cell and context-menu cursors
934         http://bugs.webkit.org/show_bug.cgi?id=11494
935
936         * Resources/cellCursor.png: Added.
937         * Resources/contextMenuCursor.png: Added.
938         * Resources/verticalTextCursor.png: Added.
939         * WebCore.xcodeproj/project.pbxproj:
940         * css/CSSComputedStyleDeclaration.cpp:
941         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
942         * css/CSSValueKeywords.in:
943         * manual-tests/cursor.html:
944         * page/FrameView.cpp:
945         (WebCore::selectCursor):
946         * platform/Cursor.h:
947         * platform/mac/CursorMac.mm:
948         (WebCore::verticalTextCursor):
949         (WebCore::cellCursor):
950         (WebCore::contextMenuCursor):
951         * rendering/RenderStyle.h:
952         (WebCore::):
953
954 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
955
956         Reviewed by aroben and ap, landed by ap.
957
958         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
959
960         Group graphics related files in platform/graphics.
961         Move certain files from certain subdirectories
962         into platform/graphics/{win,mac,cg,gdk,qt}
963
964         * CMakeLists.txt:
965         * WebCore.xcodeproj/project.pbxproj:
966         * platform/AffineTransform.cpp: Removed.
967         * platform/AffineTransform.h: Removed.
968         * platform/Color.cpp: Removed.
969         * platform/Color.h: Removed.
970         * platform/FloatPoint.cpp: Removed.
971         * platform/FloatPoint.h: Removed.
972         * platform/FloatRect.cpp: Removed.
973         * platform/FloatRect.h: Removed.
974         * platform/FloatSize.cpp: Removed.
975         * platform/FloatSize.h: Removed.
976         * platform/Icon.h: Removed.
977         * platform/Image.cpp: Removed.
978         * platform/Image.h: Removed.
979         * platform/ImageSource.h: Removed.
980         * platform/IntPoint.h: Removed.
981         * platform/IntRect.cpp: Removed.
982         * platform/IntRect.h: Removed.
983         * platform/IntSize.h: Removed.
984         * platform/IntSizeHash.h: Removed.
985         * platform/Path.cpp: Removed.
986         * platform/Path.h: Removed.
987         * platform/Pen.cpp: Removed.
988         * platform/Pen.h: Removed.
989         * platform/cairo/AffineTransformCairo.cpp: Removed.
990         * platform/cairo/GraphicsContextCairo.cpp: Removed.
991         * platform/cairo/ImageCairo.cpp: Removed.
992         * platform/cairo/ImageSourceCairo.cpp: Removed.
993         * platform/cairo/cairo/AUTHORS: Removed.
994         * platform/cairo/cairo/COPYING: Removed.
995         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
996         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
997         * platform/cairo/cairo/INSTALL: Removed.
998         * platform/cairo/cairo/NEWS: Removed.
999         * platform/cairo/cairo/README: Removed.
1000         * platform/cairo/cairo/TODO: Removed.
1001         * platform/cairo/cairo/src/Makefile.in: Removed.
1002         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
1003         * platform/cairo/cairo/src/cairo-arc.c: Removed.
1004         * platform/cairo/cairo/src/cairo-array.c: Removed.
1005         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
1006         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
1007         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
1008         * platform/cairo/cairo/src/cairo-beos.h: Removed.
1009         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
1010         * platform/cairo/cairo/src/cairo-cache.c: Removed.
1011         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
1012         * platform/cairo/cairo/src/cairo-clip.c: Removed.
1013         * platform/cairo/cairo/src/cairo-color.c: Removed.
1014         * platform/cairo/cairo/src/cairo-debug.c: Removed.
1015         * platform/cairo/cairo/src/cairo-debug.h: Removed.
1016         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
1017         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
1018         * platform/cairo/cairo/src/cairo-features.h: Removed.
1019         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
1020         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
1021         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
1022         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
1023         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
1024         * platform/cairo/cairo/src/cairo-font.c: Removed.
1025         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
1026         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
1027         * platform/cairo/cairo/src/cairo-ft.h: Removed.
1028         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
1029         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
1030         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
1031         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
1032         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
1033         * platform/cairo/cairo/src/cairo-hash.c: Removed.
1034         * platform/cairo/cairo/src/cairo-hull.c: Removed.
1035         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
1036         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
1037         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
1038         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
1039         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
1040         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
1041         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
1042         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
1043         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
1044         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
1045         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
1046         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
1047         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
1048         * platform/cairo/cairo/src/cairo-path.c: Removed.
1049         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
1050         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
1051         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
1052         * platform/cairo/cairo/src/cairo-pen.c: Removed.
1053         * platform/cairo/cairo/src/cairo-platform.h: Removed.
1054         * platform/cairo/cairo/src/cairo-png.c: Removed.
1055         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
1056         * platform/cairo/cairo/src/cairo-private.h: Removed.
1057         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
1058         * platform/cairo/cairo/src/cairo-ps.h: Removed.
1059         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
1060         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
1061         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
1062         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
1063         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
1064         * platform/cairo/cairo/src/cairo-region.c: Removed.
1065         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
1066         * platform/cairo/cairo/src/cairo-slope.c: Removed.
1067         * platform/cairo/cairo/src/cairo-spline.c: Removed.
1068         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
1069         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
1070         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
1071         * platform/cairo/cairo/src/cairo-surface.c: Removed.
1072         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
1073         * platform/cairo/cairo/src/cairo-svg.h: Removed.
1074         * platform/cairo/cairo/src/cairo-traps.c: Removed.
1075         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
1076         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
1077         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
1078         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
1079         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
1080         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
1081         * platform/cairo/cairo/src/cairo-win32.h: Removed.
1082         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
1083         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
1084         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
1085         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
1086         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
1087         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
1088         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
1089         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
1090         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
1091         * platform/cairo/cairo/src/cairo.c: Removed.
1092         * platform/cairo/cairo/src/cairo.h: Removed.
1093         * platform/cairo/cairo/src/cairoint.h: Removed.
1094         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
1095         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
1096         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
1097         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
1098         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
1099         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
1100         * platform/cairo/pixman/AUTHORS: Removed.
1101         * platform/cairo/pixman/COPYING: Removed.
1102         * platform/cairo/pixman/README: Removed.
1103         * platform/cairo/pixman/src/Makefile.in: Removed.
1104         * platform/cairo/pixman/src/fbcompose.c: Removed.
1105         * platform/cairo/pixman/src/fbedge.c: Removed.
1106         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
1107         * platform/cairo/pixman/src/fbmmx.c: Removed.
1108         * platform/cairo/pixman/src/fbmmx.h: Removed.
1109         * platform/cairo/pixman/src/fbpict.c: Removed.
1110         * platform/cairo/pixman/src/fbpict.h: Removed.
1111         * platform/cairo/pixman/src/fbtrap.c: Removed.
1112         * platform/cairo/pixman/src/icblt.c: Removed.
1113         * platform/cairo/pixman/src/icbltone.c: Removed.
1114         * platform/cairo/pixman/src/iccolor.c: Removed.
1115         * platform/cairo/pixman/src/icformat.c: Removed.
1116         * platform/cairo/pixman/src/icimage.c: Removed.
1117         * platform/cairo/pixman/src/icimage.h: Removed.
1118         * platform/cairo/pixman/src/icint.h: Removed.
1119         * platform/cairo/pixman/src/icpixels.c: Removed.
1120         * platform/cairo/pixman/src/icrect.c: Removed.
1121         * platform/cairo/pixman/src/icrop.h: Removed.
1122         * platform/cairo/pixman/src/icstipple.c: Removed.
1123         * platform/cairo/pixman/src/ictransform.c: Removed.
1124         * platform/cairo/pixman/src/ictrap.c: Removed.
1125         * platform/cairo/pixman/src/ictri.c: Removed.
1126         * platform/cairo/pixman/src/icutil.c: Removed.
1127         * platform/cairo/pixman/src/pixman-remap.h: Removed.
1128         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
1129         * platform/cairo/pixman/src/pixman.h: Removed.
1130         * platform/cairo/pixman/src/pixregion.c: Removed.
1131         * platform/cairo/pixman/src/pixregionint.h: Removed.
1132         * platform/cairo/pixman/src/renderedge.c: Removed.
1133         * platform/cairo/pixman/src/renderedge.h: Removed.
1134         * platform/cairo/pixman/src/slim_internal.h: Removed.
1135         * platform/cairo/rgb24-hacks.txt: Removed.
1136         * platform/cairo/scale-removal.txt: Removed.
1137         * platform/cg/AffineTransformCG.cpp: Removed.
1138         * platform/cg/FloatPointCG.cpp: Removed.
1139         * platform/cg/FloatRectCG.cpp: Removed.
1140         * platform/cg/FloatSizeCG.cpp: Removed.
1141         * platform/cg/GraphicsContextCG.cpp: Removed.
1142         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
1143         * platform/cg/ImageCG.cpp: Removed.
1144         * platform/cg/ImageSourceCG.cpp: Removed.
1145         * platform/cg/IntPointCG.cpp: Removed.
1146         * platform/cg/IntRectCG.cpp: Removed.
1147         * platform/cg/IntSizeCG.cpp: Removed.
1148         * platform/cg/PDFDocumentImage.cpp: Removed.
1149         * platform/cg/PDFDocumentImage.h: Removed.
1150         * platform/cg/PathCG.cpp: Removed.
1151         * platform/gdk/ImageGdk.cpp: Removed.
1152         * platform/mac/ColorMac.mm: Removed.
1153         * platform/mac/FloatPointMac.mm: Removed.
1154         * platform/mac/FloatRectMac.mm: Removed.
1155         * platform/mac/FloatSizeMac.mm: Removed.
1156         * platform/mac/GraphicsContextMac.mm:
1157         * platform/mac/IconMac.mm: Removed.
1158         * platform/mac/ImageMac.mm: Removed.
1159         * platform/mac/IntPointMac.mm: Removed.
1160         * platform/mac/IntRectMac.mm: Removed.
1161         * platform/mac/IntSizeMac.mm: Removed.
1162         * platform/qt/AffineTransformQt.cpp: Removed.
1163         * platform/qt/ColorQt.cpp: Removed.
1164         * platform/qt/FloatPointQt.cpp: Removed.
1165         * platform/qt/FloatRectQt.cpp: Removed.
1166         * platform/qt/IconQt.cpp: Removed.
1167         * platform/qt/ImageQt.cpp: Removed.
1168         * platform/qt/ImageSourceQt.cpp: Removed.
1169         * platform/qt/IntPointQt.cpp: Removed.
1170         * platform/qt/IntRectQt.cpp: Removed.
1171         * platform/qt/IntSizeQt.cpp: Removed.
1172         * platform/qt/PathQt.cpp: Removed.
1173         * platform/win/ImageWin.cpp: Removed.
1174         * platform/win/IntPointWin.cpp: Removed.
1175         * platform/win/IntRectWin.cpp: Removed.
1176         * platform/win/IntSizeWin.cpp: Removed.
1177
1178 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
1179
1180         Reviewed by hyatt.
1181
1182         A layout test was added when this bug was fixed, so none needed now.
1183         
1184         Cleanup after:
1185         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
1186         http://bugs.webkit.org/show_bug.cgi?id=11570
1187         
1188         * rendering/RenderStyle.h:
1189         (WebCore::RenderStyle::isSpace): Removed.
1190         * rendering/RenderText.cpp:
1191         (WebCore::isSpace): Added.
1192         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
1193
1194 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
1195
1196         Reviewed by mitz.
1197         
1198         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
1199         http://bugs.webkit.org/show_bug.cgi?id=11570
1200
1201         * rendering/RenderStyle.h:
1202         (WebCore::RenderStyle::isSpace): Added.
1203         * rendering/RenderText.cpp:
1204         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
1205         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
1206
1207 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
1208
1209         Reviewed by Maciej.
1210
1211         Added basic types for symbian platform.
1212         http://bugs.webkit.org/show_bug.cgi?id=11540
1213
1214         * config.h:
1215         * platform/AtomicString.h:
1216         (WebCore::AtomicString::AtomicString):
1217         (WebCore::AtomicString::operator TPtrC):
1218         * platform/DeprecatedString.cpp:
1219         (WebCore::initializeHandleNodeBlock):
1220         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
1221           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
1222           bitfields and breaks byte aligment
1223         * platform/FloatPoint.h:
1224         * platform/FloatRect.h:
1225         * platform/IntPoint.h:
1226         * platform/IntRect.h:
1227         * platform/IntSize.h:
1228         * platform/PlatformString.h:
1229         (WebCore::String::operator TPtrC):
1230         (WebCore::String::des):
1231         * platform/StringImpl.h:
1232         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
1233         (WebCore::DeprecatedString::setBufferFromDes):
1234         (WebCore::DeprecatedString::fromDes):
1235         (WebCore::DeprecatedString::des):
1236         (WebCore::DeprecatedString::des8):
1237         * platform/symbian/FloatPointSymbian.cpp: Added.
1238         (WebCore::FloatPoint::FloatPoint):
1239         (WebCore::FloatPoint::operator TPoint):
1240         * platform/symbian/FloatRectSymbian.cpp: Added.
1241         (WebCore::FloatRect::FloatRect):
1242         (WebCore::FloatRect::operator TRect):
1243         (WebCore::FloatRect::rect):
1244         * platform/symbian/IntPointSymbian.cpp: Added.
1245         (WebCore::IntPoint::IntPoint):
1246         (WebCore::IntPoint::operator TPoint):
1247         * platform/symbian/IntRectSymbian.cpp: Added.
1248         (WebCore::IntRect::IntRect):
1249         (WebCore::IntRect::operator TRect):
1250         (WebCore::IntRect::Rect):
1251         * platform/symbian/IntSizeSymbian.cpp: Added.
1252         (WebCore::IntSize::IntSize):
1253         (WebCore::IntSize::operator TSize):
1254         * platform/symbian/StringImplSymbian.cpp: Added.
1255         (WebCore::StringImpl::StringImpl):
1256         (WebCore::StringImpl::des):
1257         * platform/symbian/StringSymbian.cpp: Added.
1258         (WebCore::String::String):
1259
1260 2006-11-10  Zack Rusin  <zack@kde.org>
1261
1262         Reviewed by Anders.
1263
1264         Adjust to the changes Brady made in the Qt code.
1265
1266         * loader/qt/FrameLoaderClientQt.cpp:
1267         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
1268         * loader/qt/FrameLoaderClientQt.h:
1269
1270 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
1271
1272         Reviewed by harrison
1273         
1274         <rdar://problem/4069359>
1275         Deleting hyperlink text, then typing uses link typing style but loses the link itself
1276         
1277         The removed anchor element needs to stick around temporarily, in the same way
1278         that the typing style hangs off the caret until the user moves it.  Also text
1279         insertion around anchors didn't match TextEdit.
1280
1281         * editing/DeleteSelectionCommand.cpp:
1282         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
1283         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
1284         * editing/DeleteSelectionCommand.h:
1285         * editing/EditCommand.cpp:
1286         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
1287         editing command that doesn't preserve the typing style (matches TextEdit).
1288         * editing/Editor.cpp:
1289         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
1290         setSelection with a message telling it to clear the typing style 
1291         (and the saved anchor) here.  Save/restore the saved anchor because of this.
1292         * editing/Editor.h:
1293         (WebCore::Editor::removedAnchor): Getter.
1294         (WebCore::Editor::setRemovedAnchor): Setter.
1295         * editing/InsertTextCommand.cpp:
1296         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
1297         if one exists.
1298         * editing/SelectionController.cpp:
1299         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
1300         we make a selection change that clears the typing style.
1301         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
1302         * editing/htmlediting.cpp:
1303         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
1304         made some changes to match TextEdit's behavior.  First, insert content
1305         inside the anchor when the caret is after it, unless the caret is at the
1306         end of the document, or if the caret is before it and at the start of a 
1307         paragraph.
1308
1309 === Safari-521.30 ===
1310
1311 2006-11-10  Timothy Hatcher  <timothy@apple.com>
1312
1313         Reviewed by Hyatt.
1314
1315         Check for BHIDDEN in isVisible() also.
1316
1317         * rendering/RenderStyle.h:
1318         (WebCore::BorderValue::isVisible):
1319
1320 2006-11-10  Timothy Hatcher  <timothy@apple.com>
1321
1322         Reviewed by Adam.
1323
1324         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
1325
1326         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
1327
1328         * editing/DeleteButtonController.cpp:
1329         (WebCore::isDeletableElement):
1330         * rendering/RenderStyle.h:
1331         (WebCore::BorderValue::isVisible):
1332
1333 2006-11-10  Adam Roben  <aroben@apple.com>
1334
1335         Rubberstamped by Anders.
1336
1337         Back out some accidentally-committed changes from r17711.
1338
1339         * page/Frame.cpp:
1340         (WebCore::Frame::command):
1341         (WebCore::FramePrivate::FramePrivate):
1342         * page/Frame.h:
1343         * page/FramePrivate.h:
1344
1345 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1346
1347         Reviewed by Geoff.
1348
1349         Add more commands, make toggleBold and toggleItalic executable commands.
1350
1351         * WebCore.exp:
1352         * editing/Editor.cpp:
1353         (WebCore::execCopy):
1354         (WebCore::execCut):
1355         (WebCore::execDelete):
1356         (WebCore::execForwardDelete):
1357         (WebCore::execPaste):
1358         (WebCore::execSelectAll):
1359         (WebCore::execToggleBold):
1360         (WebCore::execToggleItalic):
1361         (WebCore::enabled):
1362         (WebCore::canPaste):
1363         (WebCore::hasEditableSelection):
1364         (WebCore::hasEditableRangeSelection):
1365         (WebCore::hasRangeSelection):
1366         (WebCore::hasRichlyEditableSelection):
1367         (WebCore::CommandEntry::):
1368         * editing/Editor.h:
1369
1370 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1371
1372         Reviewed by Maciej, Geoff.
1373
1374         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
1375         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
1376
1377         * WebCore.exp:
1378         * bridge/mac/WebCoreFrameBridge.h:
1379         * bridge/mac/WebCoreFrameBridge.mm:
1380         * editing/Editor.cpp:
1381         (WebCore::execMoveBackward):
1382         (WebCore::execMoveBackwardAndModifySelection):
1383         (WebCore::execMoveDown):
1384         (WebCore::execMoveDownAndModifySelection):
1385         (WebCore::execMoveForward):
1386         (WebCore::execMoveForwardAndModifySelection):
1387         (WebCore::execMoveLeft):
1388         (WebCore::execMoveLeftAndModifySelection):
1389         (WebCore::execMoveRight):
1390         (WebCore::execMoveRightAndModifySelection):
1391         (WebCore::execMoveToBeginningOfDocument):
1392         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
1393         (WebCore::execMoveToBeginningOfSentence):
1394         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
1395         (WebCore::execMoveToBeginningOfLine):
1396         (WebCore::execMoveToBeginningOfLineAndModifySelection):
1397         (WebCore::execMoveToBeginningOfParagraph):
1398         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
1399         (WebCore::execMoveToEndOfDocument):
1400         (WebCore::execMoveToEndOfDocumentAndModifySelection):
1401         (WebCore::execMoveToEndOfSentence):
1402         (WebCore::execMoveToEndOfSentenceAndModifySelection):
1403         (WebCore::execMoveToEndOfLine):
1404         (WebCore::execMoveToEndOfLineAndModifySelection):
1405         (WebCore::execMoveToEndOfParagraph):
1406         (WebCore::execMoveToEndOfParagraphAndModifySelection):
1407         (WebCore::execMoveParagraphBackwardAndModifySelection):
1408         (WebCore::execMoveParagraphForwardAndModifySelection):
1409         (WebCore::execMoveUp):
1410         (WebCore::execMoveUpAndModifySelection):
1411         (WebCore::execMoveWordBackward):
1412         (WebCore::execMoveWordBackwardAndModifySelection):
1413         (WebCore::execMoveWordForward):
1414         (WebCore::execMoveWordForwardAndModifySelection):
1415         (WebCore::execMoveWordLeft):
1416         (WebCore::execMoveWordLeftAndModifySelection):
1417         (WebCore::execMoveWordRight):
1418         (WebCore::execMoveWordRightAndModifySelection):
1419         (WebCore::enabledAnySelection):
1420         (WebCore::createCommandMap):
1421         (WebCore::CommandEntry::):
1422         (WebCore::Editor::execCommand):
1423         * editing/Editor.h:
1424
1425 2006-11-10  Brady Eidson  <beidson@apple.com>
1426
1427         Reviewed by Darin
1428
1429         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
1430
1431         * WebCore.exp:
1432         * WebCore.xcodeproj/project.pbxproj:
1433         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
1434         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
1435         * loader/FrameLoaderClient.h:
1436         * loader/icon/IconDatabase.cpp:
1437         (WebCore::IconDatabase::sharedIconDatabase):
1438         (WebCore::IconDatabase::~IconDatabase):
1439         * loader/icon/IconDatabase.h:
1440         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1441         (WebCore::IconDatabase::enabled):
1442         * loader/icon/IconLoader.cpp:
1443         (WebCore::IconLoader::finishLoading):
1444         * loader/mac/FrameLoaderMac.mm:
1445
1446 2006-11-10  Zack Rusin  <zack@kde.org>
1447
1448         Reviewed and landed by Anders.
1449
1450         Adjust platform Qt/KDE code to the recent loader
1451         changes. 
1452
1453         * CMakeLists.txt:
1454         * loader/DocumentLoader.h:
1455         * loader/FrameLoader.cpp:
1456         (WebCore::FrameLoader::createEmptyDocument):
1457         * loader/FrameLoader.h:
1458         * loader/FrameLoaderClient.h:
1459         * loader/qt/DocumentLoaderQt.cpp: Added.
1460         (WebCore::canonicalizedTitle):
1461         (WebCore::DocumentLoader::DocumentLoader):
1462         (WebCore::DocumentLoader::frameLoader):
1463         (WebCore::DocumentLoader::~DocumentLoader):
1464         (WebCore::DocumentLoader::URL):
1465         (WebCore::DocumentLoader::unreachableURL):
1466         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
1467         (WebCore::DocumentLoader::isStopping):
1468         (WebCore::DocumentLoader::clearErrors):
1469         (WebCore::DocumentLoader::stopLoading):
1470         (WebCore::DocumentLoader::setupForReplace):
1471         (WebCore::DocumentLoader::commitIfReady):
1472         (WebCore::DocumentLoader::finishedLoading):
1473         (WebCore::DocumentLoader::setCommitted):
1474         (WebCore::DocumentLoader::isCommitted):
1475         (WebCore::DocumentLoader::setLoading):
1476         (WebCore::DocumentLoader::isLoading):
1477         (WebCore::DocumentLoader::doesProgressiveLoad):
1478         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1479         (WebCore::DocumentLoader::updateLoading):
1480         (WebCore::DocumentLoader::setFrame):
1481         (WebCore::DocumentLoader::attachToFrame):
1482         (WebCore::DocumentLoader::detachFromFrame):
1483         (WebCore::DocumentLoader::prepareForLoadStart):
1484         (WebCore::DocumentLoader::loadingStartedTime):
1485         (WebCore::DocumentLoader::setIsClientRedirect):
1486         (WebCore::DocumentLoader::isClientRedirect):
1487         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1488         (WebCore::DocumentLoader::isLoadingInAPISense):
1489         (WebCore::DocumentLoader::stopRecordingResponses):
1490         (WebCore::DocumentLoader::title):
1491         (WebCore::DocumentLoader::triggeringAction):
1492         (WebCore::DocumentLoader::setTriggeringAction):
1493         (WebCore::DocumentLoader::setOverrideEncoding):
1494         (WebCore::DocumentLoader::overrideEncoding):
1495         (WebCore::DocumentLoader::setTitle):
1496         (WebCore::DocumentLoader::URLForHistory):
1497         * loader/qt/FrameLoaderClientQt.cpp: Added.
1498         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
1499         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
1500         (WebCore::FrameLoaderClientQt::detachFrameLoader):
1501         (WebCore::FrameLoaderClientQt::hasWebView):
1502         (WebCore::FrameLoaderClientQt::hasFrameView):
1503         (WebCore::FrameLoaderClientQt::hasBackForwardList):
1504         (WebCore::FrameLoaderClientQt::resetBackForwardList):
1505         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
1506         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
1507         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
1508         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
1509         (WebCore::FrameLoaderClientQt::makeDocumentView):
1510         (WebCore::FrameLoaderClientQt::makeRepresentation):
1511         (WebCore::FrameLoaderClientQt::forceLayout):
1512         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
1513         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
1514         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
1515         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
1516         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
1517         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
1518         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
1519         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
1520         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
1521         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
1522         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
1523         (WebCore::FrameLoaderClientQt::willCloseDocument):
1524         (WebCore::FrameLoaderClientQt::detachedFromParent1):
1525         (WebCore::FrameLoaderClientQt::detachedFromParent2):
1526         (WebCore::FrameLoaderClientQt::detachedFromParent3):
1527         (WebCore::FrameLoaderClientQt::detachedFromParent4):
1528         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
1529         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
1530         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
1531         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
1532         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
1533         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
1534         (WebCore::FrameLoaderClientQt::dispatchWillClose):
1535         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
1536         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1537         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1538         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
1539         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
1540         (WebCore::FrameLoaderClientQt::dispatchShow):
1541         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
1542         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
1543         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
1544         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
1545         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
1546         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
1547         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
1548         (WebCore::FrameLoaderClientQt::progressStarted):
1549         (WebCore::FrameLoaderClientQt::progressCompleted):
1550         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
1551         (WebCore::FrameLoaderClientQt::willChangeTitle):
1552         (WebCore::FrameLoaderClientQt::didChangeTitle):
1553         (WebCore::FrameLoaderClientQt::finishedLoading):
1554         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
1555         (WebCore::FrameLoaderClientQt::setDefersLoading):
1556         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
1557         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
1558         (WebCore::FrameLoaderClientQt::clearArchivedResources):
1559         (WebCore::FrameLoaderClientQt::canShowMIMEType):
1560         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
1561         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
1562         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
1563         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
1564         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
1565         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
1566         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
1567         (WebCore::FrameLoaderClientQt::didFinishLoad):
1568         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
1569         (WebCore::FrameLoaderClientQt::setTitle):
1570         (WebCore::FrameLoaderClientQt::userAgent):
1571         * loader/qt/FrameLoaderClientQt.h: Added.
1572         * loader/qt/FrameLoaderQt.cpp:
1573         (WebCore::FrameLoader::submitForm):
1574         (WebCore::FrameLoader::overrideMediaType):
1575         (WebCore::FrameLoader::getHistoryLength):
1576         (WebCore::FrameLoader::referrer):
1577         (WebCore::FrameLoader::detachFromParent):
1578         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1579         (WebCore::FrameLoader::goBackOrForward):
1580         (WebCore::FrameLoader::historyURL):
1581         (WebCore::FrameLoader::didFirstLayout):
1582         (WebCore::FrameLoader::canGoBackOrForward):
1583         (WebCore::FrameLoader::partClearedInBegin):
1584         (WebCore::FrameLoader::saveDocumentState):
1585         (WebCore::FrameLoader::restoreDocumentState):
1586         (WebCore::FrameLoader::didChangeTitle):
1587         (WebCore::FrameLoader::redirectDataToPlugin):
1588         (WebCore::PolicyCheck::PolicyCheck):
1589         (WebCore::PolicyCheck::clear):
1590         (WebCore::PolicyCheck::set):
1591         (WebCore::PolicyCheck::call):
1592         (WebCore::PolicyCheck::clearRequest):
1593         * loader/qt/NavigationActionQt.cpp: Added.
1594         (WebCore::navigationType):
1595         (WebCore::NavigationAction::NavigationAction):
1596         * loader/qt/ResourceLoaderQt.cpp: Added.
1597         (WebCore::ResourceLoader::ResourceLoader):
1598         (WebCore::ResourceLoader::~ResourceLoader):
1599         (WebCore::ResourceLoader::setDefersLoading):
1600         (WebCore::ResourceLoader::cancel):
1601         (WebCore::ResourceLoader::loadsBlocked):
1602         * platform/MimeTypeRegistry.cpp:
1603         (WebCore::initialiseSupportedImageMIMETypes):
1604         * platform/network/qt/ResourceHandleManager.cpp:
1605         (WebCore::ResourceHandleManager::slotResult):
1606         (WebCore::ResourceHandleManager::cancel):
1607         * platform/qt/ChromeClientQt.cpp: Added.
1608         (WebCore::rootWindowForFrame):
1609         (WebCore::ChromeClientQt::ChromeClientQt):
1610         (WebCore::ChromeClientQt::~ChromeClientQt):
1611         (WebCore::ChromeClientQt::setWindowRect):
1612         (WebCore::ChromeClientQt::windowRect):
1613         (WebCore::ChromeClientQt::pageRect):
1614         (WebCore::ChromeClientQt::scaleFactor):
1615         (WebCore::ChromeClientQt::focus):
1616         (WebCore::ChromeClientQt::unfocus):
1617         (WebCore::ChromeClientQt::createWindow):
1618         (WebCore::ChromeClientQt::createModalDialog):
1619         (WebCore::ChromeClientQt::show):
1620         (WebCore::ChromeClientQt::canRunModal):
1621         (WebCore::ChromeClientQt::runModal):
1622         (WebCore::ChromeClientQt::setToolbarsVisible):
1623         (WebCore::ChromeClientQt::toolbarsVisible):
1624         (WebCore::ChromeClientQt::setStatusbarVisible):
1625         (WebCore::ChromeClientQt::statusbarVisible):
1626         (WebCore::ChromeClientQt::setScrollbarsVisible):
1627         (WebCore::ChromeClientQt::scrollbarsVisible):
1628         (WebCore::ChromeClientQt::setMenubarVisible):
1629         (WebCore::ChromeClientQt::menubarVisible):
1630         (WebCore::ChromeClientQt::setResizable):
1631         * platform/qt/ChromeClientQt.h: Added.
1632         * platform/qt/EditorClientQt.cpp:
1633         (WebCore::EditorClientQt::shouldBeginEditing):
1634         (WebCore::EditorClientQt::shouldEndEditing):
1635         (WebCore::EditorClientQt::shouldApplyStyle):
1636         (WebCore::EditorClientQt::didBeginEditing):
1637         (WebCore::EditorClientQt::respondToChangedContents):
1638         (WebCore::EditorClientQt::didEndEditing):
1639         * platform/qt/EditorClientQt.h:
1640         * platform/qt/FrameQt.cpp:
1641         (WebCore::FrameQt::FrameQt):
1642         (WebCore::FrameQt::~FrameQt):
1643         (WebCore::FrameQt::keyEvent):
1644         * platform/qt/FrameQt.h:
1645         * platform/qt/FrameQtClient.cpp:
1646         (WebCore::FrameQtClientDefault::openURL):
1647         (WebCore::FrameQtClientDefault::didReceiveData):
1648         (WebCore::FrameQtClientDefault::receivedAllData):
1649         * platform/qt/ImageQt.cpp:
1650         * platform/qt/MimeTypeRegistryQt.cpp: Added.
1651         (WebCore::getMIMETypeForUTI):
1652         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1653         * platform/qt/PageQt.cpp:
1654         * platform/qt/PlatformKeyboardEventQt.cpp:
1655         (WebCore::keyIdentifierForQtKeyCode):
1656         * platform/qt/ScreenQt.cpp:
1657         * platform/qt/TemporaryLinkStubs.cpp:
1658         (WebCore::TextField::TextField):
1659         (WebCore::screenDepth):
1660         (WebCore::screenDepthPerComponent):
1661         (WebCore::screenIsMonochrome):
1662         (WebCore::screenRect):
1663         (WebCore::screenAvailableRect):
1664
1665 2006-11-10  Brady Eidson <beidson@apple.com>
1666
1667         Reviewed by Mitz
1668
1669         http://bugs.webkit.org/show_bug.cgi?id=11554
1670         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
1671         in case the icon load fails after some data has been received. 
1672
1673         * loader/icon/IconLoader.cpp:
1674         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
1675         on error.  Also, as a loader re-factoring sanity check, added an assertion
1676         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
1677         is already committed to the DB.  Skip doing that step twice.
1678
1679 2006-11-09  Oliver Hunt  <oliver@apple.com>
1680
1681         Reviewed by Brady.
1682
1683         Pulled MIME type handling out of WebFrameBridge and added
1684         a general C++ class to store/query MIME info
1685         Added an Obj-C bridge to provide WebKit with access to the
1686         MimeTypeRegistry for non-Obj-C++ classes.
1687         
1688         * WebCore.exp:
1689         * WebCore.xcodeproj/project.pbxproj:
1690         * bridge/mac/WebCoreFrameBridge.h:
1691         * bridge/mac/WebCoreFrameBridge.mm:
1692         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
1693         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
1694         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
1695         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
1696         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
1697         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
1698         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
1699         * platform/Image.cpp:
1700         (WebCore::Image::supportsType):
1701         * platform/Image.h:
1702         * platform/MimeTypeRegistry.cpp: Added.
1703         (WebCore::initialiseSupportedImageMIMETypes):
1704         (WebCore::initialiseSupportedNonImageMimeTypes):
1705         (WebCore::initialiseMimeTypeRegistry):
1706         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
1707         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
1708         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
1709         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
1710         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
1711         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
1712         * platform/MimeTypeRegistry.h: Added.
1713         * platform/mac/ImageMac.mm:
1714         * platform/mac/MimeTypeRegistryMac.mm: Added.
1715         (WebCore::getMIMETypeForUTI):
1716         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1717
1718 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1719
1720         Reviewed by Oliver.
1721
1722         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
1723         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
1724         for you and use vsnprintf.
1725
1726         * bindings/js/kjs_window.cpp:
1727         (KJS::Window::isSafeScript):
1728         * css/cssparser.cpp:
1729         (WebCore::CSSParser::parseColorFromValue):
1730         * dom/StyledElement.cpp:
1731         (WebCore::StyledElement::addCSSColor):
1732         * dom/XMLTokenizer.cpp:
1733         (WebCore::XMLTokenizer::handleError):
1734         * ksvg2/css/SVGCSSParser.cpp:
1735         (WebCore::CSSParser::parseSVGPaint):
1736         (WebCore::CSSParser::parseSVGColor):
1737         * ksvg2/svg/SVGPathSegArc.h:
1738         (WebCore::SVGPathSegArcAbs::toString):
1739         (WebCore::SVGPathSegArcRel::toString):
1740         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1741         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
1742         (WebCore::SVGPathSegCurvetoCubicRel::toString):
1743         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1744         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
1745         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
1746         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1747         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
1748         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
1749         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1750         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
1751         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
1752         * ksvg2/svg/SVGPathSegLineto.h:
1753         (WebCore::SVGPathSegLinetoAbs::toString):
1754         (WebCore::SVGPathSegLinetoRel::toString):
1755         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1756         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
1757         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
1758         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1759         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
1760         (WebCore::SVGPathSegLinetoVerticalRel::toString):
1761         * ksvg2/svg/SVGPathSegMoveto.h:
1762         (WebCore::SVGPathSegMovetoAbs::toString):
1763         (WebCore::SVGPathSegMovetoRel::toString):
1764         * ksvg2/svg/SVGPolyElement.cpp:
1765         (WebCore::SVGPolyElement::notifyAttributeChange):
1766         * ksvg2/svg/SVGUseElement.cpp:
1767         (WebCore::SVGUseElement::closeRenderer):
1768         * loader/icon/IconDatabase.cpp:
1769         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
1770         * loader/icon/SQLDatabase.cpp:
1771         (WebCore::SQLDatabase::setSynchronous):
1772         * platform/Color.cpp:
1773         (WebCore::Color::name):
1774         * platform/DeprecatedString.cpp:
1775         (WebCore::DeprecatedString::setNum):
1776         (WebCore::DeprecatedString::format):
1777         * platform/DeprecatedString.h:
1778         * platform/PlatformString.h:
1779         * platform/String.cpp:
1780         (WebCore::String::format):
1781         (WebCore::String::number):
1782         * platform/mac/KeyEventMac.mm:
1783         (WebCore::keyIdentifierForKeyEvent):
1784         * platform/win/KeyEventWin.cpp:
1785         (WebCore::keyIdentifierForWindowsKeyCode):
1786         * rendering/RenderListMarker.cpp:
1787         (WebCore::RenderListMarker::calcMinMaxWidth):
1788
1789 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1790
1791         Reviewed by Anders.
1792
1793         - fixed "Regression: Can't log into gmail.com"
1794         - fixed "iBench doesn't report results - tests run but no number is recorded"
1795         
1796         * platform/network/cf/FormDataStreamCFNet.cpp:
1797         (WebCore::setHTTPBody): Removed extra ! character.
1798
1799 2006-11-09  Beth Dakin  <bdakin@apple.com>
1800
1801         Reviewed by Hyatt.
1802
1803         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
1804         WebCore::RenderBlock::skipWhitespace
1805
1806         Note that this will still crash on Debug builds because it will hit 
1807         an assertion failure in editing. (One of the reasons there is no 
1808         layout test along with this fix.) There is definitely some editing 
1809         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
1810         id=10144 for updates on the assertion failure bug.
1811
1812         * rendering/RootInlineBox.cpp:
1813         (WebCore::RootInlineBox::childRemoved): It is possible for a 
1814         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
1815         of just clearing the lineBreakObj of the prevRootBox, cycle through 
1816         all prevRootBoxs with the same lineBreakObj. 
1817
1818 2006-11-09  Adam Roben  <aroben@apple.com>
1819
1820         Reviewed by Geoff.
1821
1822         Fix the change in behavior I caused in r17680 with my build fix.
1823
1824         * rendering/RenderObject.cpp:
1825         (WebCore::RenderObject::maxTopMargin):
1826         (WebCore::RenderObject::maxBottomMargin):
1827
1828 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
1829
1830         Reviewed by Adam, Oliver.
1831
1832         Move more functions to Editor.
1833
1834         * bridge/EditorClient.h:
1835         * bridge/mac/FrameMac.h:
1836         * bridge/mac/FrameMac.mm:
1837         * bridge/mac/WebCoreFrameBridge.h:
1838         * editing/EditCommand.cpp:
1839         (WebCore::EditCommand::apply):
1840         (WebCore::EditCommand::unapply):
1841         (WebCore::EditCommand::reapply):
1842         * editing/Editor.cpp:
1843         (WebCore::Editor::respondToChangedContents):
1844         (WebCore::dispatchEditableContentChangedEvents):
1845         (WebCore::Editor::appliedEditing):
1846         (WebCore::Editor::unappliedEditing):
1847         (WebCore::Editor::reappliedEditing):
1848         * editing/Editor.h:
1849         * editing/TypingCommand.cpp:
1850         (WebCore::TypingCommand::typingAddedToOpenCommand):
1851         * page/Frame.cpp:
1852         * page/Frame.h:
1853
1854 2006-11-09  Darin Adler  <darin@apple.com>
1855
1856         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
1857
1858 2006-11-09  Alice Liu  <alice.liu@apple.com>
1859
1860         Reviewed by Beth Dakin.
1861
1862         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
1863         All existing layout tests pass
1864
1865         * html/HTMLTableElement.cpp:
1866         (WebCore::HTMLTableElement::deleteRow):
1867         check lastSection before deleting row
1868
1869 2006-11-09  Darin Adler  <darin@apple.com>
1870
1871         - improved version of last night's build fix (should not do using namespace in a header)
1872
1873         * rendering/RenderObject.h:
1874         * rendering/RenderObject.cpp:
1875         (WebCore::RenderObject::maxTopMargin):
1876         (WebCore::RenderObject::maxBottomMargin):
1877
1878 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
1879
1880         Reviewed by Geoff.
1881         
1882         - added ResourceError class and didFailWithError client method
1883
1884         * WebCore.xcodeproj/project.pbxproj:
1885         * loader/icon/IconLoader.cpp:
1886         (WebCore::IconLoader::didFailWithError):
1887         (WebCore::IconLoader::didFinishLoading):
1888         * loader/icon/IconLoader.h:
1889         * loader/loader.cpp:
1890         (WebCore::Loader::receivedAllData):
1891         (WebCore::Loader::didFailWithError):
1892         * loader/loader.h:
1893         * loader/mac/SubresourceLoaderMac.mm:
1894         (WebCore::SubresourceLoader::didFail):
1895         (WebCore::SubresourceLoader::didCancel):
1896         * platform/cf/RetainPtr.h:
1897         (WebCore::):
1898         (WebCore::adoptCFReference):
1899         (WebCore::RetainPtr::RetainPtr):
1900         (WebCore::::adopt):
1901         * platform/network/ResourceError.cpp: Added.
1902         * platform/network/ResourceError.h: Added.
1903         (WebCore::ResourceError::ResourceError):
1904         (WebCore::ResourceError::domain):
1905         (WebCore::ResourceError::errorCode):
1906         (WebCore::ResourceError::failingURL):
1907         (WebCore::ResourceError::localizedDescription):
1908         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
1909         * platform/network/ResourceHandle.cpp:
1910         * platform/network/ResourceHandle.h:
1911         * platform/network/ResourceHandleClient.h:
1912         (WebCore::ResourceHandleClient::didFailWithError):
1913         * platform/network/cf/ResourceHandleCFNet.cpp:
1914         (WebCore::didFail):
1915         (WebCore::ResourceHandle::cancel):
1916         * platform/network/mac/ResourceErrorMac.mm: Added.
1917         (-[NSError WebCore]):
1918         * platform/network/mac/ResourceHandleMac.mm:
1919         (WebCore::ResourceHandle::reportError):
1920         * xml/xmlhttprequest.cpp:
1921         (WebCore::XMLHttpRequest::didFailWithError):
1922         (WebCore::XMLHttpRequest::didFinishLoading):
1923         * xml/xmlhttprequest.h:
1924
1925 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1926
1927         Reviewed by Maciej.
1928
1929         Linux\Gdk fixes.
1930
1931         * platform/gdk/ChromeClientGdk.h:
1932         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1933         * platform/gdk/CursorGdk.cpp:
1934         (WebCore::Cursor::Cursor):
1935         (WebCore::moveCursor):
1936         * platform/gdk/FrameGdk.cpp:
1937         (WebCore::FrameGdk::FrameGdk):
1938         (WebCore::FrameGdk::submitForm):
1939         (WebCore::FrameGdk::urlSelected):
1940         * platform/gdk/PageGdk.cpp:
1941         * platform/gdk/ScreenClientGdk.h: Added.
1942         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1943         * platform/gdk/ScreenGdk.cpp:
1944         (WebCore::ScreenClientGdk::depth):
1945         (WebCore::ScreenClientGdk::depthPerComponent):
1946         (WebCore::ScreenClientGdk::isMonochrome):
1947         (WebCore::ScreenClientGdk::rect):
1948         (WebCore::ScreenClientGdk::usableRect):
1949         * platform/gdk/TemporaryLinkStubs.cpp:
1950         (FrameGdk::historyURL):
1951         (ChromeClientGdk::windowRect):
1952         (ChromeClientGdk::setWindowRect):
1953         (ChromeClientGdk::pageRect):
1954         (ChromeClientGdk::scaleFactor):
1955         (ChromeClientGdk::focus):
1956         (ChromeClientGdk::unfocus):
1957         (ChromeClientGdk::createWindow):
1958         (ChromeClientGdk::createModalDialog):
1959         (ChromeClientGdk::show):
1960         (ChromeClientGdk::canRunModal):
1961         (ChromeClientGdk::runModal):
1962         (ChromeClientGdk::setToolbarsVisible):
1963         (ChromeClientGdk::toolbarsVisible):
1964         (ChromeClientGdk::setStatusbarVisible):
1965         (ChromeClientGdk::statusbarVisible):
1966         (ChromeClientGdk::setScrollbarsVisible):
1967         (ChromeClientGdk::scrollbarsVisible):
1968         (ChromeClientGdk::setMenubarVisible):
1969         (ChromeClientGdk::menubarVisible):
1970         (ChromeClientGdk::setResizable):
1971         * platform/network/ResourceHandleInternal.h:
1972         (WebCore::ResourceHandleInternal::client):
1973         * platform/network/gdk/ResourceHandleManager.cpp:
1974         (WebCore::writeCallback):
1975         (WebCore::ResourceHandleManager::downloadTimerCallback):
1976         (WebCore::ResourceHandleManager::remove):
1977
1978 2006-11-08  Adam Roben  <aroben@apple.com>
1979
1980         Build fix.
1981
1982         * rendering/RenderObject.h:
1983         (WebCore::RenderObject::maxTopMargin):
1984         (WebCore::RenderObject::maxBottomMargin):
1985
1986 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1987
1988         Reviewed by Anders Carlsson.
1989
1990         Made Screen a good platform citizen by removing its reference to Page. This
1991         made a class unnecessary, so all screen fuctions are stand-alone now.
1992
1993         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
1994         when computing the screen's available dimensions.
1995
1996 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
1997
1998         Reviewed by Mitz.
1999
2000         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
2001         Cleanup RenderObject
2002
2003         * rendering/RenderObject.cpp:
2004         (WebCore::RenderObject::operator delete):
2005         (WebCore::RenderObject::createObject):
2006         (WebCore::RenderObjectCounter::~RenderObjectCounter):
2007         (WebCore::RenderObject::RenderObject):
2008         (WebCore::RenderObject::isDescendantOf):
2009         (WebCore::RenderObject::isRoot):
2010         (WebCore::RenderObject::addChild):
2011         (WebCore::RenderObject::removeChildNode):
2012         (WebCore::RenderObject::removeChild):
2013         (WebCore::RenderObject::appendChildNode):
2014         (WebCore::RenderObject::insertChildNode):
2015         (WebCore::RenderObject::nextInPreOrder):
2016         (WebCore::RenderObject::nextInPreOrderAfterChildren):
2017         (WebCore::RenderObject::previousInPreOrder):
2018         (WebCore::RenderObject::isEditable):
2019         (WebCore::RenderObject::nextEditable):
2020         (WebCore::RenderObject::previousEditable):
2021         (WebCore::RenderObject::firstLeafChild):
2022         (WebCore::RenderObject::lastLeafChild):
2023         (WebCore::RenderObject::addLayers):
2024         (WebCore::RenderObject::removeLayers):
2025         (WebCore::RenderObject::moveLayers):
2026         (WebCore::RenderObject::findNextLayer):
2027         (WebCore::RenderObject::enclosingLayer):
2028         (WebCore::RenderObject::updateFirstLetter):
2029         (WebCore::RenderObject::offsetParent):
2030         (WebCore::RenderObject::scroll):
2031         (WebCore::RenderObject::hasStaticX):
2032         (WebCore::RenderObject::setNeedsLayout):
2033         (WebCore::RenderObject::setChildNeedsLayout):
2034         (WebCore::RenderObject::markContainingBlocksForLayout):
2035         (WebCore::RenderObject::containingBlock):
2036         (WebCore::RenderObject::containingBlockWidth):
2037         (WebCore::RenderObject::containingBlockHeight):
2038         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
2039         (WebCore::RenderObject::drawBorderArc):
2040         (WebCore::RenderObject::drawBorder):
2041         (WebCore::RenderObject::paintBorderImage):
2042         (WebCore::RenderObject::paintBorder):
2043         (WebCore::RenderObject::absoluteRects):
2044         (WebCore::RenderObject::addPDFURLRect):
2045         (WebCore::RenderObject::addFocusRingRects):
2046         (WebCore::RenderObject::paintOutline):
2047         (WebCore::RenderObject::repaint):
2048         (WebCore::RenderObject::repaintRectangle):
2049         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2050         (WebCore::RenderObject::repaintObjectsBeforeLayout):
2051         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
2052         (WebCore::RenderObject::information):
2053         (WebCore::RenderObject::dump):
2054         (WebCore::selectStartNode):
2055         (WebCore::RenderObject::shouldSelect):
2056         (WebCore::RenderObject::draggableNode):
2057         (WebCore::RenderObject::createAnonymousBlock):
2058         (WebCore::RenderObject::handleDynamicFloatPositionChange):
2059         (WebCore::RenderObject::setStyle):
2060         (WebCore::RenderObject::setStyleInternal):
2061         (WebCore::RenderObject::updateBackgroundImages):
2062         (WebCore::RenderObject::absolutePosition):
2063         (WebCore::RenderObject::caretRect):
2064         (WebCore::RenderObject::paddingTop):
2065         (WebCore::RenderObject::paddingBottom):
2066         (WebCore::RenderObject::paddingLeft):
2067         (WebCore::RenderObject::paddingRight):
2068         (WebCore::RenderObject::tabWidth):
2069         (WebCore::RenderObject::container):
2070         (WebCore::RenderObject::removeFromObjectLists):
2071         (WebCore::RenderObject::destroy):
2072         (WebCore::RenderObject::arenaDelete):
2073         (WebCore::RenderObject::hitTest):
2074         (WebCore::RenderObject::setInnerNode):
2075         (WebCore::RenderObject::nodeAtPoint):
2076         (WebCore::RenderObject::verticalPositionHint):
2077         (WebCore::RenderObject::getVerticalPosition):
2078         (WebCore::RenderObject::lineHeight):
2079         (WebCore::RenderObject::invalidateVerticalPositions):
2080         (WebCore::RenderObject::recalcMinMaxWidths):
2081         (WebCore::RenderObject::scheduleRelayout):
2082         (WebCore::RenderObject::setInlineBoxWrapper):
2083         (WebCore::RenderObject::firstLineStyle):
2084         (WebCore::RenderObject::getPseudoStyle):
2085         (WebCore::RenderObject::getTextDecorationColors):
2086         (WebCore::RenderObject::addDashboardRegions):
2087         (WebCore::RenderObject::collectDashboardRegions):
2088         (WebCore::RenderObject::avoidsFloats):
2089         (WebCore::RenderObject::findCounter):
2090         (WebCore::RenderObject::backslashAsCurrencySymbol):
2091         (WebCore::RenderObject::imageChanged):
2092         (WebCore::RenderObject::previousOffset):
2093         (WebCore::RenderObject::nextOffset):
2094         (WebCore::RenderObject::inlineBox):
2095         * rendering/RenderObject.h:
2096         (WebCore::):
2097         (WebCore::RenderObject::renderName):
2098         (WebCore::RenderObject::parent):
2099         (WebCore::RenderObject::previousSibling):
2100         (WebCore::RenderObject::nextSibling):
2101         (WebCore::RenderObject::firstChild):
2102         (WebCore::RenderObject::lastChild):
2103         (WebCore::RenderObject::getOverflowClipRect):
2104         (WebCore::RenderObject::getClipRect):
2105         (WebCore::RenderObject::getBaselineOfFirstLineBox):
2106         (WebCore::RenderObject::setEdited):
2107         (WebCore::RenderObject::setStaticX):
2108         (WebCore::RenderObject::setStaticY):
2109         (WebCore::RenderObject::setPreviousSibling):
2110         (WebCore::RenderObject::setNextSibling):
2111         (WebCore::RenderObject::setParent):
2112         (WebCore::RenderObject::isInlineBlockOrInlineTable):
2113         (WebCore::RenderObject::isRenderView):
2114         (WebCore::RenderObject::childrenInline):
2115         (WebCore::RenderObject::setChildrenInline):
2116         (WebCore::RenderObject::isAnonymousBlock):
2117         (WebCore::RenderObject::isDragging):
2118         (WebCore::RenderObject::needsLayout):
2119         (WebCore::RenderObject::setMinMaxKnown):
2120         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
2121         (WebCore::RenderObject::setPositioned):
2122         (WebCore::RenderObject::setRelPositioned):
2123         (WebCore::RenderObject::setFloating):
2124         (WebCore::RenderObject::setInline):
2125         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
2126         (WebCore::RenderObject::setReplaced):
2127         (WebCore::RenderObject::PaintInfo::PaintInfo):
2128         (WebCore::RenderObject::paintBackgroundExtended):
2129         (WebCore::RenderObject::calcWidth):
2130         (WebCore::RenderObject::updateFromElement):
2131         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
2132         (WebCore::RenderObject::setOverrideSize):
2133         (WebCore::RenderObject::setPos):
2134         (WebCore::RenderObject::setWidth):
2135         (WebCore::RenderObject::setHeight):
2136         (WebCore::RenderObject::absolutePositionForContent):
2137         (WebCore::RenderObject::overflowHeight):
2138         (WebCore::RenderObject::overflowWidth):
2139         (WebCore::RenderObject::setOverflowHeight):
2140         (WebCore::RenderObject::setOverflowWidth):
2141         (WebCore::RenderObject::overflowLeft):
2142         (WebCore::RenderObject::overflowTop):
2143         (WebCore::RenderObject::overflowRect):
2144         (WebCore::RenderObject::stopAutoscroll):
2145         (WebCore::RenderObject::collapsedMarginTop):
2146         (WebCore::RenderObject::collapsedMarginBottom):
2147         (WebCore::RenderObject::maxTopMargin):
2148         (WebCore::RenderObject::maxBottomMargin):
2149         (WebCore::RenderObject::):
2150         (WebCore::RenderObject::setTable):
2151         (WebCore::RenderObject::isFloatingOrPositioned):
2152         (WebCore::RenderObject::containsFloat):
2153         (WebCore::RenderObject::setSelectionState):
2154         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
2155         (WebCore::RenderObject::lowestPosition):
2156         (WebCore::RenderObject::rightmostPosition):
2157         (WebCore::RenderObject::leftmostPosition):
2158         (WebCore::RenderObject::calcVerticalMargins):
2159         (WebCore::RenderObject::font):
2160
2161 2006-11-08  Darin Adler  <darin@apple.com>
2162
2163         Reviewed by Anders.
2164
2165         - added event parameters to focus-related functions so we can
2166           implement the "option-tab to all links" behavior without relying
2167           on a global "current event" -- also makes it work with DOM events
2168
2169         * page/Frame.h: Removed unneeded includes. Moved some functions
2170         that were misplaced into the appropriate sections.
2171         * page/Frame.cpp:
2172         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
2173         PlatformKeyboardEvent to the DOM keyboard event class.
2174         (WebCore::Frame::tabsToLinks): Added event parameter.
2175         (WebCore::Frame::tabsToAllControls): Ditto.
2176         (WebCore::scanForForm): Fixed code that incorrectly assumes
2177         that an iframe is an HTMLFrameElement (no longer true since Geoff
2178         changed the class hierarchy a bit).
2179         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2180
2181         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
2182         that were misplaced into the appropriate sections.
2183         * bridge/mac/FrameMac.mm:
2184         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
2185         a PlatformKeyboardEvent.
2186         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
2187         and pass event into next/previousFocusNode.
2188         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
2189         the AppKit current event, if it's a keyboard event. Really just a hack that's
2190         needed to preserve some code we can remove once we deal with the last NSView-
2191         based form control.
2192         (WebCore::isKeyboardOptionTab): Added.
2193         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
2194         option (alt) key is down.
2195         (WebCore::FrameMac::tabsToAllControls): Ditto.
2196         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
2197         call resetMultipleFormSubmissionProtection() explicitly instead.
2198         (WebCore::FrameMac::mouseDown): Ditto.
2199
2200         * bridge/mac/WebCoreAXObject.mm:
2201         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
2202         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
2203         changed the class hierarchy a bit).
2204         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
2205         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
2206         explicitly instead.
2207
2208         * page/FrameView.h:
2209         * page/FrameView.cpp:
2210         (WebCore::FrameView::advanceFocus): Changed function to take an
2211         event parameter, and decide the direction based on the shift key
2212         modifier instead of a passed-in boolean.
2213
2214         * dom/Document.h:
2215         * dom/Document.cpp:
2216         (WebCore::Document::nextFocusNode): Added event parameter.
2217         (WebCore::Document::previousFocusNode): Ditto.
2218         * dom/Node.h:
2219         * dom/Node.cpp:
2220         (WebCore::Node::isKeyboardFocusable): Ditto.
2221         * html/HTMLAnchorElement.h:
2222         * html/HTMLAnchorElement.cpp:
2223         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
2224         * html/HTMLGenericFormElement.h:
2225         * html/HTMLGenericFormElement.cpp:
2226         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
2227         * html/HTMLInputElement.h:
2228         * html/HTMLInputElement.cpp:
2229         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
2230         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
2231         * html/HTMLSelectElement.h:
2232         * html/HTMLSelectElement.cpp:
2233         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
2234         * html/HTMLTextAreaElement.h:
2235         * html/HTMLTextAreaElement.cpp:
2236         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
2237
2238         * dom/EventTargetNode.cpp:
2239         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
2240         advanceFocus function.
2241
2242         * platform/TextField.h:
2243         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
2244
2245         * platform/mac/WebCoreTextField.h:
2246         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
2247         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
2248         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
2249         needed since the default handler in HTMLInputElement takes care of
2250         option-tab.
2251
2252         * platform/mac/SliderMac.mm:
2253         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
2254         and pass event into tabsToAllControls.
2255         (Slider::focusPolicy): Ditto.
2256
2257         * rendering/RenderLineEdit.cpp:
2258         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
2259         (WebCore::RenderLineEdit::updateFromElement): Ditto.
2260
2261 2006-11-08  Brady Eidson  <beidson@apple.com>
2262
2263         Reviewed by Dave Harrison, Oliver, and Darin 
2264         (oh my!  where was superkevin on this one?)
2265
2266         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
2267
2268         More "free nil checking" we lost in the transition from ObjC to C++
2269
2270         * loader/mac/FrameLoaderMac.mm:
2271         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
2272         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
2273
2274 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2275
2276         Reviewed by Adam.
2277
2278         Move more code into editor.
2279         
2280         * WebCore.exp:
2281         * bridge/EditorClient.h:
2282         * bridge/mac/FrameMac.h:
2283         * bridge/mac/FrameMac.mm:
2284         * bridge/mac/WebCoreFrameBridge.h:
2285         * dom/Document.cpp:
2286         (WebCore::Document::relinquishesEditingFocus):
2287         (WebCore::Document::acceptsEditingFocus):
2288         (WebCore::Document::didBeginEditing):
2289         (WebCore::Document::didEndEditing):
2290         * editing/Editor.cpp:
2291         (WebCore::Editor::indent):
2292         (WebCore::Editor::outdent):
2293         * editing/Editor.h:
2294         * page/Frame.cpp:
2295         * page/Frame.h:
2296
2297 2006-11-08  Beth Dakin  <bdakin@apple.com>
2298
2299         Reviewed by Adam.
2300
2301         Add ability to HitTestResult to ask if the inner non-shared node is 
2302         content editable.
2303
2304         * WebCore.exp: Export HitTestResult::isContentEditable()
2305         * rendering/HitTestResult.cpp:
2306         (WebCore::HitTestResult::isContentEditable):
2307         * rendering/HitTestResult.h:
2308
2309 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2310
2311         Build fix.
2312         
2313         * WebCore.xcodeproj/project.pbxproj:
2314         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
2315
2316 2006-11-08  Timothy Hatcher  <timothy@apple.com>
2317
2318         Reviewed by Darin.
2319
2320         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
2321         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
2322
2323         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
2324
2325         * bindings/objc/DOM.mm:
2326         (WebCore::kit):
2327         (-[DOMNode lineBoxRects]):
2328         (-[DOMRange boundingBox]):
2329         (-[DOMRange lineBoxRects]):
2330         * bindings/objc/DOMPrivate.h:
2331         * dom/Range.cpp:
2332         (WebCore::Range::boundingBox):
2333         (WebCore::Range::addLineBoxRects):
2334         * dom/Range.h:
2335         * rendering/RenderContainer.cpp:
2336         (WebCore::RenderContainer::addLineBoxRects):
2337         * rendering/RenderContainer.h:
2338         * rendering/RenderObject.cpp:
2339         (WebCore::RenderObject::addLineBoxRects):
2340         * rendering/RenderObject.h:
2341         * rendering/RenderText.cpp:
2342         (WebCore::RenderText::addLineBoxRects):
2343         * rendering/RenderText.h:
2344
2345 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2346
2347         Reviewed by Oliver.
2348         
2349         Move methods from the bridge and frame into editor.
2350         
2351         * WebCore.exp:
2352         * bridge/EditorClient.h:
2353         * bridge/mac/WebCoreFrameBridge.h:
2354         * bridge/mac/WebCoreFrameBridge.mm:
2355         * editing/Editor.cpp:
2356         (WebCore::Editor::removeFormattingAndStyle):
2357         (WebCore::Editor::applyStyle):
2358         (WebCore::Editor::applyParagraphStyle):
2359         (WebCore::Editor::applyStyleToSelection):
2360         (WebCore::Editor::applyParagraphStyleToSelection):
2361         (WebCore::Editor::toggleBold):
2362         (WebCore::Editor::toggleItalic):
2363         (WebCore::Editor::selectionStartHasStyle):
2364         * editing/Editor.h:
2365         * editing/JSEditor.cpp:
2366         * page/Frame.cpp:
2367         * page/Frame.h:
2368
2369 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
2370
2371         Reviewed by Beth.
2372         
2373         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
2374         be able to dispatch user events even when off-screen, so we have to support
2375         off-screen windows when handling mouse events.
2376
2377         * platform/Screen.h:
2378         * platform/mac/PlatformMouseEventMac.mm:
2379         (WebCore::globalPoint): Grab the best screen instead of the screen you're
2380         on, since you might be off-screen.
2381         * platform/mac/ScreenMac.mm:
2382         (WebCore::screenForWindow):
2383
2384 2006-11-08  Darin Adler  <darin@apple.com>
2385
2386         - fix bug caused by last-minute change to my check-in last night
2387           that is causing layout tests to hang
2388
2389         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
2390         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
2391         a null string into an empty string before calling completeURL.
2392
2393 2006-11-08  Brady Eidson <beidson@apple.com>
2394
2395         Reviewed by Maciej
2396
2397         If the request has already been aborted, bail out of didFinishLoading()
2398         immediately.  This prevents state change notifications that aren't
2399         needed.
2400
2401         * xml/xmlhttprequest.cpp:
2402         (WebCore::XMLHttpRequest::didFinishLoading):
2403
2404 2006-11-08  Darin Adler  <darin@apple.com>
2405
2406         - another attempt to fix Qt build
2407
2408         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
2409
2410 2006-11-08  Darin Adler  <darin@apple.com>
2411
2412         Reviewed by Geoff.
2413
2414         - stray bits of my FrameLoader patch that I left out by accident
2415
2416         * loader/FrameLoader.cpp:
2417         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
2418         inside the FrameLoader class.
2419         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
2420         (WebCore::FrameLoader::clear): Stop the redirection timer.
2421         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
2422         entire function in an if statement. Use less DeprecatedString.
2423         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
2424         (WebCore::FrameLoader::scheduleRefresh): Ditto.
2425         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
2426         inside the FrameLoader class.
2427         * loader/mac/FrameLoaderMac.mm:
2428         (WebCore::FrameLoader::load): Ditto.
2429         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
2430
2431 2006-11-07  Beth Dakin  <bdakin@apple.com>
2432
2433         Reviewed by Hyatt.
2434
2435         Another go at fix for <rdar://problem/4820814> A crash occurs at 
2436         WebCore::HitTestResult::spellingToolTip() when mousing down on 
2437         iframe at www.macsurfer.com
2438
2439         The fix from yesterday caused a layout test regression which 
2440         exposed an existing bug. The existing bug was that we allowed text 
2441         nodes to stay in the head tag, but other browsers move them to the 
2442         body. The previous fix also caused a performance regression, which 
2443         was seemingly easy to fix by moving the new clause in 
2444         HTMLParser::handleError() to be below the HTMLElement case.
2445
2446         * html/HTMLDocument.cpp:
2447         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
2448         be the child of the document.
2449         * html/HTMLHeadElement.cpp:
2450         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
2451         whitespace text nodes to be children of the head.
2452         * html/HTMLHeadElement.h:
2453         * html/HTMLParser.cpp:
2454         (WebCore::HTMLParser::handleError): Error case for comment nodes.
2455         * page/FrameView.cpp:
2456         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
2457         for the original crash. 
2458
2459 2006-11-07  Darin Adler  <darin@apple.com>
2460
2461         - another attempt to fix Qt build
2462
2463         * loader/icon/IconLoader.h: Added missing include.
2464
2465 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2466
2467         Reviewed by Tim Hatcher.
2468         
2469         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
2470         
2471         None of Screen's responsibilities require up-calls to WebKit or delegates, 
2472         so WebCore can handle it all.
2473         
2474         Moved Screen back from page/ to platform/ because it's a platform
2475         abstraction again.
2476
2477         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
2478         since the two were always used together.
2479         
2480         Changed pixel depth queries to query the deepest screen. Darin mentioned
2481         that it might have been a feature, not a bug, to use the main/menubar screen
2482         regardless of the screen you were on. For scaling and flipping that's not
2483         the case, but for querying pixel depth I think it is. You want to know
2484         about the highest pixel depth your content may display on.
2485         
2486         Tests still pass.
2487
2488         * WebCore.exp:
2489         * WebCore.xcodeproj/project.pbxproj:
2490         * page/Page.cpp:
2491         (WebCore::Page::Page):
2492         * page/Page.h:
2493         * page/Screen.cpp: Removed.
2494         * page/Screen.h: Removed.
2495         * page/ScreenClient.h: Removed.
2496         * platform/mac/PlatformMouseEventMac.mm:
2497         (WebCore::globalPoint):
2498         * platform/mac/ScreenMac.mm:
2499         (WebCore::window):
2500         (WebCore::bestScreen):
2501         (WebCore::Screen::depth):
2502         (WebCore::Screen::depthPerComponent):
2503         (WebCore::Screen::isMonochrome):
2504         (WebCore::Screen::rect):
2505         (WebCore::Screen::usableRect):
2506         (WebCore::toUserSpace):
2507         (WebCore::toDeviceSpace):
2508
2509 2006-11-07  Darin Adler  <darin@apple.com>
2510
2511         - try to fix Qt build
2512
2513         * CMakeLists.txt: Updated for some file changes.
2514         * WebCoreSources.bkl: Ditto.
2515
2516 2006-11-07  Darin Adler  <darin@apple.com>
2517
2518         Reviewed by Geoff.
2519
2520         - moved loader code from Frame/FrameMac to FrameLoader
2521
2522         * WebCore.exp:
2523         * WebCore.xcodeproj/project.pbxproj:
2524         * bindings/js/JSXSLTProcessor.h:
2525         * bindings/js/kjs_events.cpp:
2526         (KJS::JSLazyEventListener::parseCode):
2527         * bindings/js/kjs_html.cpp:
2528         (KJS::JSHTMLDocument::putValueProperty):
2529         * bindings/js/kjs_navigator.cpp:
2530         (KJS::Navigator::getValueProperty):
2531         * bindings/js/kjs_proxy.cpp:
2532         (WebCore::KJSProxy::initScriptIfNeeded):
2533         * bindings/js/kjs_window.cpp:
2534         (KJS::Screen::Screen):
2535         (KJS::createNewWindow):
2536         (KJS::Window::getValueProperty):
2537         (KJS::Window::put):
2538         (KJS::Window::isSafeScript):
2539         (KJS::WindowFunc::callAsFunction):
2540         (KJS::ScheduledAction::execute):
2541         (KJS::Location::getValueProperty):
2542         (KJS::Location::put):
2543         (KJS::Location::toString):
2544         (KJS::LocationFunc::callAsFunction):
2545         (KJS::History::getValueProperty):
2546         (KJS::HistoryFunc::callAsFunction):
2547         * bindings/objc/DOM.mm:
2548         (+[DOMNode _nodeWith:WebCore::]):
2549         * bridge/mac/FrameMac.h:
2550         * bridge/mac/FrameMac.mm:
2551         (WebCore::FrameMac::~FrameMac):
2552         (WebCore::FrameMac::setView):
2553         (WebCore::FrameMac::setStatusBarText):
2554         * bridge/mac/WebCoreFrameBridge.h:
2555         * bridge/mac/WebCoreFrameBridge.mm:
2556         (-[WebCoreFrameBridge close]):
2557         (-[WebCoreFrameBridge addData:]):
2558         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
2559         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
2560         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2561         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2562         (-[WebCoreFrameBridge baseURL]):
2563         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2564         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
2565         (-[WebCoreFrameBridge canProvideDocumentSource]):
2566         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2567         * css/cssparser.cpp:
2568         (WebCore::CSSParser::parseContent):
2569         * dom/DOMImplementation.cpp:
2570         (WebCore::DOMImplementation::createDocument):
2571         (WebCore::DOMImplementation::createHTMLDocument):
2572         * dom/DOMImplementation.h:
2573         * dom/Document.cpp:
2574         (WebCore::Document::readyState):
2575         (WebCore::Document::updateTitle):
2576         (WebCore::Document::open):
2577         (WebCore::Document::close):
2578         (WebCore::Document::implicitClose):
2579         (WebCore::Document::processHttpEquiv):
2580         (WebCore::Document::referrer):
2581         (WebCore::Document::finishedParsing):
2582         * dom/ProcessingInstruction.cpp:
2583         (WebCore::ProcessingInstruction::checkStyleSheet):
2584         * dom/XMLTokenizer.cpp:
2585         (WebCore::XMLTokenizer::endElementNs):
2586         (WebCore::ignorableWhitespaceHandler):
2587         (WebCore::XMLTokenizer::notifyFinished):
2588         * editing/TextIterator.cpp:
2589         (WebCore::TextIterator::rangeFromLocationAndLength):
2590         * html/HTMLAnchorElement.cpp:
2591         (WebCore::HTMLAnchorElement::defaultEventHandler):
2592         * html/HTMLBaseElement.cpp:
2593         (WebCore::HTMLBaseElement::process):
2594         * html/HTMLDocument.cpp:
2595         (WebCore::HTMLDocument::lastModified):
2596         * html/HTMLFormElement.cpp:
2597         (WebCore::HTMLFormElement::formData):
2598         (WebCore::HTMLFormElement::submit):
2599         * html/HTMLFrameElementBase.cpp:
2600         (WebCore::HTMLFrameElementBase::isURLAllowed):
2601         (WebCore::HTMLFrameElementBase::openURL):
2602         (WebCore::HTMLFrameElementBase::willRemove):
2603         * html/HTMLInputElement.cpp:
2604         (WebCore::HTMLInputElement::setValueFromRenderer):
2605         * html/HTMLLinkElement.cpp:
2606         (WebCore::HTMLLinkElement::process):
2607         * html/HTMLParser.cpp:
2608         (WebCore::HTMLParser::handleError):
2609         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2610         * html/HTMLPreElement.idl:
2611         * html/HTMLScriptElement.cpp:
2612         (WebCore::HTMLScriptElement::parseMappedAttribute):
2613         (WebCore::HTMLScriptElement::insertedIntoDocument):
2614         * html/HTMLTokenizer.cpp:
2615         (WebCore::HTMLTokenizer::scriptExecution):
2616         (WebCore::HTMLTokenizer::parseTag):
2617         (WebCore::HTMLTokenizer::write):
2618         (WebCore::HTMLTokenizer::stopParsing):
2619         (WebCore::HTMLTokenizer::timerFired):
2620         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2621         (WebCore::KCanvasFilterQuartz::prepareFilter):
2622         * ksvg2/svg/SVGAElement.cpp:
2623         (WebCore::SVGAElement::defaultEventHandler):
2624         * ksvg2/svg/SVGElement.cpp:
2625         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
2626         * loader/DocLoader.cpp:
2627         (WebCore::DocLoader::setLoadInProgress):
2628         * loader/FrameLoader.cpp:
2629         (WebCore::FormSubmission::FormSubmission):
2630         (WebCore::ScheduledRedirection::):
2631         (WebCore::ScheduledRedirection::ScheduledRedirection):
2632         (WebCore::cancelAll):
2633         (WebCore::getString):
2634         (WebCore::isBackForwardLoadType):
2635         (WebCore::numRequests):
2636         (WebCore::FrameLoader::FrameLoader):
2637         (WebCore::FrameLoader::~FrameLoader):
2638         (WebCore::FrameLoader::createWindow):
2639         (WebCore::FrameLoader::changeLocation):
2640         (WebCore::FrameLoader::urlSelected):
2641         (WebCore::FrameLoader::requestFrame):
2642         (WebCore::FrameLoader::loadSubframe):
2643         (WebCore::FrameLoader::submitFormAgain):
2644         (WebCore::FrameLoader::submitForm):
2645         (WebCore::FrameLoader::stopLoading):
2646         (WebCore::FrameLoader::stop):
2647         (WebCore::FrameLoader::closeURL):
2648         (WebCore::FrameLoader::cancelRedirection):
2649         (WebCore::FrameLoader::iconURL):
2650         (WebCore::FrameLoader::didOpenURL):
2651         (WebCore::FrameLoader::didExplicitOpen):
2652         (WebCore::FrameLoader::replaceContentsWithScriptResult):
2653         (WebCore::FrameLoader::executeScript):
2654         (WebCore::FrameLoader::cancelAndClear):
2655         (WebCore::FrameLoader::clear):
2656         (WebCore::FrameLoader::receivedFirstData):
2657         (WebCore::FrameLoader::responseMIMEType):
2658         (WebCore::FrameLoader::setResponseMIMEType):
2659         (WebCore::FrameLoader::begin):
2660         (WebCore::FrameLoader::write):
2661         (WebCore::FrameLoader::end):
2662         (WebCore::FrameLoader::endIfNotLoading):
2663         (WebCore::FrameLoader::startIconLoader):
2664         (WebCore::FrameLoader::commitIconURLToIconDatabase):
2665         (WebCore::FrameLoader::gotoAnchor):
2666         (WebCore::FrameLoader::finishedParsing):
2667         (WebCore::FrameLoader::loadDone):
2668         (WebCore::FrameLoader::checkCompleted):
2669         (WebCore::FrameLoader::checkEmitLoadEvent):
2670         (WebCore::FrameLoader::baseURL):
2671         (WebCore::FrameLoader::baseTarget):
2672         (WebCore::FrameLoader::completeURL):
2673         (WebCore::FrameLoader::scheduleRedirection):
2674         (WebCore::FrameLoader::scheduleLocationChange):
2675         (WebCore::FrameLoader::scheduleRefresh):
2676         (WebCore::FrameLoader::isScheduledLocationChangePending):
2677         (WebCore::FrameLoader::scheduleHistoryNavigation):
2678         (WebCore::FrameLoader::redirectionTimerFired):
2679         (WebCore::FrameLoader::encoding):
2680         (WebCore::FrameLoader::requestObject):
2681         (WebCore::FrameLoader::shouldUsePlugin):
2682         (WebCore::FrameLoader::loadPlugin):
2683         (WebCore::FrameLoader::clearRecordedFormValues):
2684         (WebCore::FrameLoader::recordFormValue):
2685         (WebCore::FrameLoader::parentCompleted):
2686         (WebCore::FrameLoader::outgoingReferrer):
2687         (WebCore::FrameLoader::lastModified):
2688         (WebCore::FrameLoader::opener):
2689         (WebCore::FrameLoader::setOpener):
2690         (WebCore::FrameLoader::openedByJavaScript):
2691         (WebCore::FrameLoader::setOpenedByJavaScript):
2692         (WebCore::FrameLoader::handleFallbackContent):
2693         (WebCore::FrameLoader::provisionalLoadStarted):
2694         (WebCore::FrameLoader::userGestureHint):
2695         (WebCore::FrameLoader::didNotOpenURL):
2696         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
2697         (WebCore::FrameLoader::setEncoding):
2698         (WebCore::FrameLoader::addData):
2699         (WebCore::FrameLoader::canCachePage):
2700         (WebCore::FrameLoader::updatePolicyBaseURL):
2701         (WebCore::FrameLoader::setPolicyBaseURL):
2702         (WebCore::FrameLoader::scrollToAnchor):
2703         (WebCore::FrameLoader::isComplete):
2704         (WebCore::FrameLoader::isLoadingMainResource):
2705         (WebCore::FrameLoader::url):
2706         (WebCore::FrameLoader::startRedirectionTimer):
2707         (WebCore::FrameLoader::stopRedirectionTimer):
2708         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
2709         (WebCore::FrameLoader::completed):
2710         (WebCore::FrameLoader::started):
2711         (WebCore::FrameLoader::containsPlugins):
2712         (WebCore::FrameLoader::prepareForLoadStart):
2713         (WebCore::FrameLoader::setupForReplace):
2714         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2715         (WebCore::FrameLoader::finalSetupForReplace):
2716         (WebCore::FrameLoader::load):
2717         (WebCore::FrameLoader::canTarget):
2718         (WebCore::FrameLoader::stopLoadingPlugIns):
2719         (WebCore::FrameLoader::stopLoadingSubresources):
2720         (WebCore::FrameLoader::stopLoadingSubframes):
2721         (WebCore::FrameLoader::stopAllLoaders):
2722         (WebCore::FrameLoader::cancelMainResourceLoad):
2723         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2724         (WebCore::FrameLoader::activeDocumentLoader):
2725         (WebCore::FrameLoader::addPlugInStreamLoader):
2726         (WebCore::FrameLoader::removePlugInStreamLoader):
2727         (WebCore::FrameLoader::hasMainResourceLoader):
2728         (WebCore::FrameLoader::isLoadingSubresources):
2729         (WebCore::FrameLoader::isLoadingPlugIns):
2730         (WebCore::FrameLoader::isLoading):
2731         (WebCore::FrameLoader::addSubresourceLoader):
2732         (WebCore::FrameLoader::removeSubresourceLoader):
2733         (WebCore::FrameLoader::releaseMainResourceLoader):
2734         (WebCore::FrameLoader::setDocumentLoader):
2735         (WebCore::FrameLoader::documentLoader):
2736         (WebCore::FrameLoader::setPolicyDocumentLoader):
2737         (WebCore::FrameLoader::provisionalDocumentLoader):
2738         (WebCore::FrameLoader::setProvisionalDocumentLoader):
2739         (WebCore::FrameLoader::state):
2740         (WebCore::FrameLoader::timeOfLastCompletedLoad):
2741         (WebCore::FrameLoader::setState):
2742         (WebCore::FrameLoader::clearProvisionalLoad):
2743         (WebCore::FrameLoader::markLoadComplete):
2744         (WebCore::FrameLoader::commitProvisionalLoad):
2745         (WebCore::FrameLoader::privateBrowsingEnabled):
2746         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
2747         (WebCore::FrameLoader::clientRedirected):
2748         (WebCore::FrameLoader::shouldReload):
2749         (WebCore::FrameLoader::closeOldDataSources):
2750         (WebCore::FrameLoader::open):
2751         (WebCore::FrameLoader::isStopping):
2752         (WebCore::FrameLoader::finishedLoading):
2753         (WebCore::FrameLoader::URL):
2754         (WebCore::FrameLoader::isArchiveLoadPending):
2755         (WebCore::FrameLoader::isHostedByObjectElement):
2756         (WebCore::FrameLoader::isLoadingMainFrame):
2757         (WebCore::FrameLoader::canShowMIMEType):
2758         (WebCore::FrameLoader::representationExistsForURLScheme):
2759         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2760         (WebCore::FrameLoader::cancelContentPolicyCheck):
2761         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
2762         (WebCore::FrameLoader::finishedLoadingDocument):
2763         (WebCore::FrameLoader::isReplacing):
2764         (WebCore::FrameLoader::setReplacing):
2765         (WebCore::FrameLoader::revertToProvisional):
2766         (WebCore::FrameLoader::subframeIsLoading):
2767         (WebCore::FrameLoader::willChangeTitle):
2768         (WebCore::FrameLoader::loadType):
2769         (WebCore::FrameLoader::stopPolicyCheck):
2770         (WebCore::FrameLoader::continueAfterContentPolicy):
2771         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2772         (WebCore::FrameLoader::didFirstLayout):
2773         (WebCore::FrameLoader::frameLoadCompleted):
2774         (WebCore::FrameLoader::firstLayoutDone):
2775         (WebCore::FrameLoader::isQuickRedirectComing):
2776         (WebCore::FrameLoader::closeDocument):
2777         (WebCore::FrameLoader::detachChildren):
2778         (WebCore::FrameLoader::checkLoadComplete):
2779         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2780         (WebCore::FrameLoader::setClient):
2781         (WebCore::FrameLoader::client):
2782         (WebCore::FrameLoader::userAgent):
2783         (WebCore::FrameLoader::createEmptyDocument):
2784         (WebCore::FrameLoader::tokenizerProcessedData):
2785         (WebCore::FrameLoader::didTellBridgeAboutLoad):
2786         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
2787         (WebCore::FrameLoader::handledOnloadEvents):
2788         (WebCore::FrameLoader::frameDetached):
2789         (WebCore::FrameLoader::setTitle):
2790         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2791         * loader/FrameLoader.h:
2792         (WebCore::):
2793         * loader/FrameLoaderClient.h:
2794         * loader/PluginDocument.cpp:
2795         (WebCore::PluginTokenizer::createDocumentStructure):
2796         (WebCore::PluginTokenizer::writeRawData):
2797         * loader/ResourceLoader.h:
2798         * loader/TextResourceDecoder.cpp:
2799         (WebCore::TextResourceDecoder::checkForHeadCharset):
2800         * loader/icon/IconLoader.cpp:
2801         (WebCore::IconLoader::startLoading):
2802         (WebCore::IconLoader::finishLoading):
2803         * loader/loader.cpp:
2804         (WebCore::Loader::didReceiveResponse):
2805         * loader/mac/DocumentLoaderMac.mm:
2806         (WebCore::DocumentLoader::~DocumentLoader):
2807         (WebCore::DocumentLoader::stopLoading):
2808         (WebCore::DocumentLoader::finishedLoading):
2809         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2810         (WebCore::DocumentLoader::setPrimaryLoadComplete):
2811         * loader/mac/FrameLoaderMac.mm:
2812         (WebCore::FrameLoader::load):
2813         (WebCore::FrameLoader::startLoading):
2814         (WebCore::FrameLoader::cancelMainResourceLoad):
2815         (WebCore::FrameLoader::receivedMainResourceError):
2816         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
2817         (WebCore::FrameLoader::commitProvisionalLoad):
2818         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2819         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2820         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2821         (WebCore::FrameLoader::detachFromParent):
2822         (WebCore::FrameLoader::addExtraFieldsToRequest):
2823         (WebCore::FrameLoader::loadResourceSynchronously):
2824         (WebCore::FrameLoader::createFrame):
2825         (WebCore::FrameLoader::objectContentType):
2826         (WebCore::nsArray):
2827         (WebCore::FrameLoader::createPlugin):
2828         (WebCore::FrameLoader::redirectDataToPlugin):
2829         (WebCore::FrameLoader::createJavaAppletWidget):
2830         (WebCore::FrameLoader::partClearedInBegin):
2831         (WebCore::FrameLoader::saveDocumentState):
2832         (WebCore::FrameLoader::restoreDocumentState):
2833         (WebCore::FrameLoader::overrideMediaType):
2834         (WebCore::FrameLoader::mainResourceData):
2835         (WebCore::FrameLoader::canGoBackOrForward):
2836         (WebCore::FrameLoader::originalRequestURL):
2837         (WebCore::FrameLoader::getHistoryLength):
2838         (WebCore::FrameLoader::goBackOrForward):
2839         (WebCore::FrameLoader::historyURL):
2840         (WebCore::FrameLoader::didFinishLoad):
2841         * loader/mac/LoaderFunctionsMac.mm:
2842         (WebCore::ServeSynchronousRequest):
2843         (WebCore::CheckCacheObjectStatus):
2844         * loader/mac/ResourceLoaderMac.mm:
2845         (WebCore::ResourceLoader::cancel):
2846         * loader/mac/SubresourceLoaderMac.mm:
2847         (WebCore::SubresourceLoader::create):
2848         * loader/qt/FrameLoaderQt.cpp: Added.
2849         (WebCore::FrameLoader::submitForm):
2850         (WebCore::FrameLoader::urlSelected):
2851         (WebCore::FrameLoader::setTitle):
2852         (WebCore::FrameLoader::createFrame):
2853         (WebCore::FrameLoader::objectContentType):
2854         (WebCore::FrameLoader::createPlugin):
2855         (WebCore::FrameLoader::createJavaAppletWidget):
2856         (WebCore::FrameLoader::originalRequestURL):
2857         * page/DOMWindow.cpp:
2858         (WebCore::DOMWindow::document):
2859         * page/Frame.cpp:
2860         (WebCore::Frame::~Frame):
2861         (WebCore::Frame::reparseConfiguration):
2862         (WebCore::Frame::shouldDragAutoNode):
2863         (WebCore::Frame::prepareForUserAction):
2864         (WebCore::FramePrivate::FramePrivate):
2865         (WebCore::FramePrivate::~FramePrivate):
2866         * page/Frame.h:
2867         * page/FramePrivate.h:
2868         * page/FrameView.cpp:
2869         (WebCore::FrameView::layout):
2870         (WebCore::FrameView::mediaType):
2871         * page/FrameView.h:
2872         * page/PageState.cpp:
2873         (WebCore::PageState::PageState):
2874         (WebCore::PageState::restoreJavaScriptState):
2875         * platform/mac/CookieJar.mm:
2876         (WebCore::setCookies):
2877         * platform/mac/TextCodecMac.cpp:
2878         * platform/mac/WebFontCache.mm:
2879         (+[WebFontCache fontWithFamily:traits:size:]):
2880         * platform/network/cf/ResourceHandleCFNet.cpp:
2881         (WebCore::ResourceHandle::start):
2882         * platform/network/mac/ResourceHandleMac.mm:
2883         (WebCore::ResourceHandle::start):
2884         * platform/qt/FrameQt.cpp:
2885         * platform/qt/FrameQt.h:
2886         * rendering/RenderApplet.cpp:
2887         (WebCore::RenderApplet::createWidgetIfNecessary):
2888         * rendering/RenderBlock.h:
2889         * rendering/RenderPartObject.cpp:
2890         (WebCore::isURLAllowed):
2891         (WebCore::RenderPartObject::updateWidget):
2892         * xml/DOMParser.cpp:
2893         (WebCore::DOMParser::parseFromString):
2894         * xml/XSLTProcessor.cpp:
2895         (WebCore::XSLTProcessor::createDocumentFromSource):
2896         * xml/xmlhttprequest.cpp:
2897         (WebCore::XMLHttpRequest::getResponseXML):
2898
2899 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
2900
2901         Reviewed by Geoff.
2902
2903         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
2904         
2905         * bridge/mac/FrameMac.mm:
2906         (WebCore::FrameMac::registerCommandForUndoOrRedo):
2907         * bridge/mac/WebCoreFrameBridge.h:
2908         * bridge/mac/WebCoreFrameBridge.mm:
2909         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2910         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2911         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
2912         (-[WebCoreFrameBridge selectionGranularity]):
2913         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2914         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2915         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
2916         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
2917         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
2918         * editing/SelectionController.cpp:
2919         (WebCore::SelectionController::setModifyBias):
2920         (WebCore::SelectionController::modify):
2921         * editing/SelectionController.h:
2922         (WebCore::SelectionController::):
2923         * editing/TextGranularity.h:
2924
2925 2006-11-07  Brady Eidson  <beidson@apple.com>
2926
2927         Reviewed by Maciej
2928
2929         Changed the check for "top level frame" to something much more valid
2930
2931         * page/Frame.cpp:
2932         (WebCore::Frame::endIfNotLoading):
2933
2934 2006-11-07  Beth Dakin  <bdakin@apple.com>
2935
2936         Reviewed by Hyatt (yesterday).
2937
2938         Here is part of my patch from yesterday that is safe to roll back 
2939         in. It will make the BuildBot happy.
2940
2941         * rendering/HitTestResult.cpp:
2942         (WebCore::HitTestResult::spellingToolTip): Null-check 
2943         m_innerNonSharedNode.
2944
2945 2006-11-07  Darin Adler  <darin@apple.com>
2946
2947         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2948         Comment grammar fix.
2949
2950 2006-11-07  Darin Adler  <darin@apple.com>
2951
2952         Rolled out change for <rdar://problem/4820814>.
2953
2954         Beth's planning on landing a new change for it soon, but in the mean time
2955         we need layout tests succeeding again.
2956
2957 2006-11-07  Darin Adler  <darin@apple.com>
2958
2959         Reviewed by Brady.
2960
2961         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
2962           crashes on launch in WebCore::ResourceLoader::start
2963
2964         No layout test, because this depends on cached icons, although there's
2965         perhaps a way to write a test for it with some further ingenuity.
2966
2967         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
2968         to make explicit the fact that it can't be successfully copied.
2969         Remove notifyIconChanged function and put the contents in the caller.
2970         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
2971         and clearLoadingState functions to share code. Removed m_url, since the
2972         resource handle already stores the URL. Renamed m_resourceLoader to
2973         m_handle to reflect the class's name change. Removed the 4096-byte
2974         inline buffer from m_data, since the malloc savings is not sufficient
2975         to offset the additional memory use. Removed m_httpStatusCode because
2976         we can instead cancel the load when we get a status code that reflects
2977         failure. Added m_loadIsInProgress boolean because we need to detect
2978         loads that complete during the ResourceHandle::create function call.
2979
2980         * loader/icon/IconLoader.cpp:
2981         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
2982         Don't initialize m_httpStatusCode.
2983         (WebCore::IconLoader::~IconLoader): Updated for name change.
2984         (WebCore::IconLoader::startLoading): Added code to use the
2985         m_loadIsInProgress flag to detect if the load completed while inside
2986         the ResourceHandle::create function. Removed code to set m_url.
2987         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
2988         more code.
2989         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
2990         and finish loading if the HTTP status code indicates failure.
2991         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
2992         the ResourceHandle, since we can't do that any more.
2993         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
2994         so we can share code with the new didReceiveResponse code path.
2995         (WebCore::IconLoader::finishLoading): Moved code here from the
2996         didFinishLoading callback. Pass a URL when calling
2997         commitIconURLToIconDatabase. Call notifyIconChanged directly here
2998         instead of using a separate function. Call clearLoadingState to
2999         share more code with stopLoading.
3000         (WebCore::IconLoader::clearLoadingState): Added.
3001
3002         * loader/mac/IconLoaderMac.mm: Removed.
3003         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
3004
3005 2006-11-06  David Harrison  <harrison@apple.com>
3006
3007         Reviewed by Darin.
3008
3009         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
3010
3011         * editing/pasteboard/3976872-expected.txt:
3012         * editing/pasteboard/4076267-2-expected.txt:
3013         * editing/pasteboard/4076267-3-expected.txt:
3014         * editing/pasteboard/4076267-expected.txt:
3015         * editing/pasteboard/8145-1-expected.txt:
3016         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
3017         * editing/pasteboard/paste-match-style-001-expected.txt:
3018         * editing/pasteboard/paste-match-style-002-expected.txt:
3019         * editing/pasteboard/paste-text-019-expected.txt:
3020         * editing/pasteboard/pasting-tabs-expected.txt:
3021         Updated because pasting text with no newlines does not use intermediate div.
3022         
3023         * editing/markup.cpp:
3024         (WebCore::fillContainerFromString):
3025         First parameter is now a Container so a fragment can be passed.
3026         
3027         (WebCore::createFragmentFromText):
3028         A string with no newlines gets added inline, rather than being put into a paragraph.
3029
3030 2006-11-06  Beth Dakin  <bdakin@apple.com>
3031
3032         Reviewed by Hyatt.
3033
3034         Fix for <rdar://problem/4820814> A crash occurs at 
3035         WebCore::HitTestResult::spellingToolTip() when mousing down on 
3036         iframe at www.macsurfer.com
3037
3038         The bug here is that the source of the iframe is only a comment, 
3039         and we were not properly constructing the frame because it was 
3040         sort-of empty but not.
3041
3042         * html/HTMLDocument.cpp:
3043         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
3044         it is a comment node.
3045         * html/HTMLParser.cpp:
3046         (WebCore::HTMLParser::handleError): if n is a comment node and 
3047         there is no head, we create a head, insert in the document, and add 
3048         the comment node as a child. This is what Firefox does too. 
3049         * page/FrameView.cpp:
3050         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
3051         fix. It is possible to get a mouse event without a target node, so 
3052         we null check it. (Of course, in the case of this bug, it should 
3053         not have been null, but it is a good thing to check for anyway.
3054         * rendering/HitTestResult.cpp:
3055         (WebCore::HitTestResult::spellingToolTip): Null-check 
3056         m_innerNonSharedNode.
3057
3058 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
3059
3060         Reviewed by harrison
3061         
3062         <rdar://problem/4641880>
3063         Setting bullets to existing text grabs subsequent paragraph
3064         
3065         When a selection ends at the start of a paragraph, we rarely paint 
3066         the selection gap before that paragraph, because there often is no gap.  
3067         In a case like this, it's not obvious to the user that the selection 
3068         ends "inside" that paragraph, so it would be confusing if 
3069         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
3070         
3071         * editing/FormatBlockCommand.cpp:
3072         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
3073         the selection to a more appropriate place.  Change the endingSelection
3074         if it ends at the start of a paragraph.
3075         * editing/IndentOutdentCommand.cpp:
3076         (WebCore::IndentOutdentCommand::doApply): Ditto.
3077         * editing/InsertListCommand.cpp:
3078         (WebCore::InsertListCommand::doApply): Ditto.
3079
3080 2006-11-06  Brady Eidson  <beidson@apple.com>
3081
3082         Reviewed by Sarge
3083
3084         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
3085         Toned it down a bit.
3086
3087         * xml/xmlhttprequest.cpp:
3088         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
3089
3090 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3091
3092         Reviewed by Maciej.
3093
3094         Linux\Gdk build fixes.
3095
3096         * loader/icon/IconDatabase.cpp:
3097         * loader/icon/SQLStatement.h:
3098         * platform/gdk/ChromeClientGdk.h: Added.
3099         (WebCore::ChromeClientGdk::~ChromeClientGdk):
3100         * platform/gdk/CursorGdk.cpp:
3101         (WebCore::pointerCursor):
3102         * platform/gdk/FrameGdk.cpp:
3103         (WebCore::doScroll):
3104         (WebCore::FrameGdk::FrameGdk):
3105         (WebCore::FrameGdk::submitForm):
3106         (WebCore::FrameGdk::urlSelected):
3107         (WebCore::FrameGdk::openURL):
3108         (WebCore::FrameGdk::handleGdkEvent):
3109         * platform/gdk/FrameGdk.h:
3110         (WebCore::FrameGdk::client):
3111         * platform/gdk/RenderPopupMenuGdk.cpp:
3112         (WebCore::PopupMenu::updateFromElement):
3113         * platform/gdk/ScreenGdk.cpp:
3114         * platform/gdk/TemporaryLinkStubs.cpp:
3115         (Slider::focusPolicy):
3116         (WebCore::ServeSynchronousRequest):
3117         (FrameGdk::goBackOrForward):
3118         (FrameGdk::getHistoryLength):
3119         (FrameGdk::historyURL):
3120         (ChromeClientGdk::canRunModal):
3121         (ChromeClientGdk::runModal):
3122         (WebCore::systemBeep):
3123         (WebCore::CachedResource::setPlatformResponse):
3124         (Path::transform):
3125         (ResourceLoader::loadsBlocked):
3126         (IconLoader::notifyIconChanged):
3127         * platform/network/gdk/ResourceHandleManager.cpp:
3128         (WebCore::writeCallback):
3129         (WebCore::ResourceHandleManager::downloadTimerCallback):
3130         (WebCore::ResourceHandleManager::remove):
3131         (WebCore::ResourceHandleManager::add):
3132
3133 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3134
3135         build fix.
3136         
3137         * WebCore.xcodeproj/project.pbxproj:
3138
3139 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3140
3141         Reviewed by Maciej, Anders, Darin.
3142
3143         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
3144         Fixed a minor where WebCore would always assume it was displayed on the 
3145         monitor containing the menubar. window.open and window.showModalDialog 
3146         are now cross-platform. 
3147         
3148         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
3149         window-open-features-parsing all pass. I verified the new screen functionality
3150         by running in DRT, and checking whether WebCore knew it was off-screen.
3151         
3152         Some refactoring remains, as all were not pleased by this design. I see
3153         in my future another patch.
3154
3155         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
3156         client, to encapsulate asking the platform questions about the screen occupied by
3157         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
3158         * bridge/mac/WebCoreFrameBridge.mm:
3159         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
3160         functions.
3161         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
3162         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
3163         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
3164         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
3165         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
3166         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
3167         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
3168         (In this case, neither size nor position is specified, so you should
3169         get the default window size and position.)
3170         * page/Screen.cpp: Added. Includes screen-related helper functions used
3171         in WebCore and WebKit.
3172         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
3173         to be duplicated. Renamed "position" to "point" since both were used,
3174         and "point" seemed clearer.
3175         * platform/Screen.h: Removed. Dead Code.
3176         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
3177         initialization.
3178
3179 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
3180
3181         Reviewed by Tim Hatcher.
3182
3183         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
3184         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
3185         
3186         No layout tests added as this must be tested manually by the test
3187         WebCore/manual-tests/contenteditable-link.html
3188
3189         * WebCore.exp: Exported HitTestResult::isLiveLink().
3190         * html/HTMLAnchorElement.cpp:
3191         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3192         (WebCore::HTMLAnchorElement::defaultEventHandler):
3193         (WebCore::HTMLAnchorElement::isLiveLink):
3194         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
3195         to track shift key status.
3196         * manual-tests/contenteditable-link.html: Added description about link
3197         dragging behaviour.
3198         * rendering/HitTestResult.cpp:
3199         (WebCore::HitTestResult::isLiveLink): Added.
3200         * rendering/HitTestResult.h:
3201
3202 2006-11-06  Brady Eidson  <beidson@apple.com>
3203
3204         Reviewed by Oliver
3205
3206         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
3207         For now, we have to not load favicons when we have no Document - linking directly 
3208         to PDFs being the common case
3209
3210         * loader/icon/IconLoader.cpp:
3211         (WebCore::IconLoader::startLoading): Check for the document and return if none
3212
3213 2006-11-06  Brady Eidson  <beidson@apple.com>
3214
3215         Reviewed by Dave Harrison
3216
3217         <rdar://problem/4801066>
3218         Added a critical null frameLoader() check
3219
3220         * loader/mac/MainResourceLoaderMac.mm:
3221         (WebCore::MainResourceLoader::loadNow):
3222
3223 2006-11-06  David Harrison  <harrison@apple.com>
3224
3225         Reviewed by Darin.
3226
3227         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
3228
3229         Test:
3230         * editing/deleting/delete-br-012.html
3231         
3232         * editing/DeleteSelectionCommand.cpp:
3233         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
3234         Update m_endingPosition when preventing merge.
3235         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
3236
3237 2006-11-06  Mark Rowe  <bdash@webkit.org>
3238
3239         Reviewed by Maciej.
3240
3241         http://bugs.webkit.org/show_bug.cgi?id=11526
3242         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
3243
3244         Update DOMNode::toString to always use className rather than preferring nodeName.
3245
3246         * bindings/js/kjs_dom.cpp:
3247         (KJS::DOMNode::toString): Match the format returned by valueOf.
3248
3249 2006-11-06  Oliver Hunt  <oliver@apple.com>
3250
3251         Reviewed by Maciej.
3252
3253         Fix RTL text in SVG to have correct positioning
3254
3255         * rendering/SVGRootInlineBox.cpp:
3256         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
3257
3258 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
3259
3260         Reviewed by Maciej.
3261
3262         http://bugs.webkit.org/show_bug.cgi?id=11517
3263         REGRESSION: Flash clicks/interactivity not working properly
3264
3265         * bridge/mac/FrameMac.mm:
3266         (WebCore::FrameMac::handleMouseMoveEvent):
3267         (WebCore::FrameMac::handleMouseReleaseEvent):
3268         Restore parts of event dispatching that were removed when fixing
3269         bug 7323 - just bypass those for subframes.
3270
3271 2006-11-05  Darin Adler  <darin@apple.com>
3272
3273         - quick attempt to fix the no-SVG build
3274
3275         * platform/graphics/svg/SVGResource.cpp:
3276         * platform/graphics/svg/SVGResource.h:
3277         * platform/graphics/svg/SVGResourceClipper.cpp:
3278         * platform/graphics/svg/SVGResourceClipper.h:
3279         * platform/graphics/svg/SVGResourceImage.h:
3280         * platform/graphics/svg/SVGResourceMarker.cpp:
3281         * platform/graphics/svg/SVGResourceMarker.h:
3282         * platform/graphics/svg/SVGResourceMasker.cpp:
3283         * platform/graphics/svg/SVGResourceMasker.h:
3284         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
3285         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
3286         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
3287         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
3288         Added #ifdef SVG_SUPPORT to these files.
3289
3290 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
3291
3292         Reviewed & landed by Maciej.
3293
3294         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
3295
3296         * platform/win/ResourceLoaderWin.cpp:
3297         (WebCore::transferJobStatusCallback):
3298         (WebCore::ResourceLoader::start):
3299
3300 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
3301
3302         Reviewed by Oliver.
3303
3304         - moved FormData and FormDataStream to platform/network directory
3305
3306         * WebCore.xcodeproj/project.pbxproj:
3307         * bridge/mac/WebCoreFrameBridge.mm:
3308         * loader/FormData.cpp: Removed.
3309         * loader/FormData.h: Removed.
3310         * loader/mac/FormDataStream.h: Removed.
3311         * loader/mac/FormDataStream.m: Removed.
3312         * loader/mac/FrameLoaderMac.mm:
3313         * loader/mac/SubresourceLoaderMac.mm:
3314         * platform/network/mac/FormDataStreamMac.h: Added.
3315         * platform/network/mac/FormDataStreamMac.mm: Added.
3316         * platform/network/mac/ResourceRequestMac.mm:
3317
3318 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
3319
3320         Fix build breaks
3321
3322         * loader/DocumentLoader.h:
3323         * platform/win/ScreenWin.cpp:
3324
3325 2006-11-05  Darin Adler  <darin@apple.com>
3326
3327         Reviewed by Geoff.
3328
3329         - more preparation for splitting up Frame into sub-pieces
3330         - removed unnecessary includes from Frame.h
3331
3332         * page/Frame.h: Removed unneeded includes and forward declarations.
3333         Added additional forward declarations. Removed the constant
3334         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
3335         Created sections of functions to be moved into Chrome, Editor,
3336         EventHandler, FrameLoader, SelectionController, and the Platform
3337         directory, as well as marking one function for deletion.
3338
3339         * page/FramePrivate.h: Removed the definition of the constructor and
3340         destructor and removed unnecessary includes.
3341
3342         * page/FrameView.h: Removed unneeded forward declarations and friend
3343         declarations. Created a section of functions and data to be moved into
3344         EventHandler.
3345
3346         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
3347         Created sections of functions and data to be moved into Chrome,
3348         Editor, EventHandler, FrameLoader, and the Platform directory.
3349
3350         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
3351         Removed unused methods areScrollbarsVisible,
3352         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
3353
3354         * page/Frame.cpp:
3355         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
3356         to include KURL.h just for the KURL default constructor.
3357         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
3358         (WebCore::FramePrivate::~FramePrivate): Ditto.
3359
3360         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
3361         booleans, scrollbarMoved and cleared funcitons.
3362         (WebCore::FrameView::clear): Moved the code from the cleared
3363         function in here.
3364         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
3365
3366         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
3367         for changes to header.
3368
3369         * editing/SelectionController.cpp:
3370         (WebCore::SelectionController::setSelection):
3371         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
3372         Moved NoXPosForVerticalArrowNavigation into this file.
3373
3374         * bindings/js/kjs_events.cpp:
3375         * bindings/js/kjs_html.cpp:
3376         * bindings/js/kjs_window.cpp:
3377         * bridge/mac/WebCoreAXObject.mm:
3378         * bridge/mac/WebCoreFrameBridge.mm:
3379         * css/cssstyleselector.cpp:
3380         * dom/Document.cpp:
3381         * dom/Element.cpp:
3382         * dom/EventTargetNode.cpp:
3383         * dom/MouseRelatedEvent.cpp:
3384         * dom/XMLTokenizer.cpp:
3385         * html/HTMLBaseElement.cpp:
3386         * html/HTMLDocument.cpp:
3387         * html/HTMLEmbedElement.cpp:
3388         * html/HTMLFrameElementBase.cpp:
3389         * html/HTMLGenericFormElement.cpp:
3390         * html/HTMLObjectElement.cpp:
3391         * html/HTMLTokenizer.cpp:
3392         * loader/mac/FrameLoaderMac.mm:
3393         * page/PageState.cpp:
3394         * rendering/RenderApplet.cpp:
3395         * rendering/RenderBlock.cpp:
3396         * rendering/RenderLayer.cpp:
3397         * rendering/RenderObject.cpp:
3398         * rendering/RenderPartObject.cpp:
3399         * rendering/RenderTreeAsText.cpp:
3400         * xml/XSLTProcessor.cpp:
3401         Added includes as needed to keep compiling, since there are fewer
3402         includes in Frame.h.
3403
3404 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
3405
3406         Reviewed by Dave Harrison.
3407
3408         http://bugs.webkit.org/show_bug.cgi?id=11402
3409         REGRESSION: onChange does not work anymore for 1st item in popup
3410
3411         * html/HTMLSelectElement.cpp:
3412         (WebCore::HTMLSelectElement::HTMLSelectElement):
3413         (WebCore::HTMLSelectElement::reset):
3414         Set m_lastOnChangeIndex to -1.
3415
3416 2006-11-04  Darin Adler  <darin@apple.com>
3417
3418         Reviewed by Anders.
3419
3420         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
3421           REGRESSION: Status bar always shows cancelled opening the page
3422
3423         * platform/network/mac/ResourceHandleMac.mm:
3424         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
3425         Since the subresource owns the resource handle, there's no need to cancel.
3426         This arrangement is only temporary, anyway, since Maciej will soon change
3427         things so that the subresource loader uses the resource handle and the
3428         resource handle doesn't know anything about the subresource loader.
3429
3430 2006-11-04  Darin Adler  <darin@apple.com>
3431
3432         Reviewed by Maciej.
3433
3434         - converted more of the loader machinery to work with cross-platform
3435           data structures instead of Macintosh-specific ones
3436
3437           converted most uses of NSURL to KURL and NSEvent to DOM Event in
3438           loader classes
3439
3440           moved download function out of FrameLoader.h to avoid reference to
3441           NSURLConnection
3442
3443           added DOM Event parameters to various functions so that the handlers
3444           can use the DOM Event instead of the global "current NSEvent";
3445           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
3446           HTMLFormElement::submit, FrameLoader::load
3447
3448           moved the setMainFrame call that hands ownership to the Page
3449           into one of the Frame constructors, and removed it from all
3450           the clients
3451
3452           removed const from Event parameter to the urlSelected function
3453           (we rarely use const with DOM elements)
3454
3455           removed some redundant includes and declarations from various
3456           header files
3457
3458           removed NSURL parameter from userAgent function -- if we need it we
3459           can add it back, but converting from NSURL to KURL and back is
3460           inefficient enough that it's best to have it out for now (since it's
3461           been unused for years) -- if we add it back, we can choose an
3462           appropriate parameter type that's always inexpensive to pass
3463
3464           did some basic cleanup in the IconLoader class, including removing
3465           an unnecessary loop that added icon data a byte at a time
3466
3467           renamed safeLoad to load, since it's no different from the other
3468           FrameLoader load functions, safety-wise
3469
3470           fixed some code that was trying to distinguish null frame name from
3471           empty string frame name -- both should be handled the same, but callers
3472           were doing it by checking for empty and turning it into null (in a way
3473           that was causing extra round trips between NSString and WebCore::String)
3474
3475           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
3476           and got rid of case-insensitive compares of methods
3477
3478         * WebCore.exp:
3479         * WebCore.xcodeproj/project.pbxproj:
3480         * bindings/js/kjs_navigator.cpp:
3481         (KJS::Navigator::getValueProperty):
3482         * bridge/mac/FrameMac.h:
3483         * bridge/mac/FrameMac.mm:
3484         (WebCore::FrameMac::submitForm):
3485         (WebCore::FrameMac::urlSelected):
3486         (WebCore::FrameMac::userAgent):
3487         * bridge/mac/FrameViewMac.mm:
3488         * bridge/mac/WebCoreAXObject.mm:
3489         (-[WebCoreAXObject rendererForView:]):
3490         * bridge/mac/WebCorePageBridge.h:
3491         * bridge/mac/WebCorePageBridge.mm:
3492         * bridge/mac/WebCoreSettings.mm:
3493         * bridge/win/FrameWin.cpp:
3494         (WebCore::FrameWin::urlSelected):
3495         (WebCore::FrameWin::submitForm):
3496         * bridge/win/FrameWin.h:
3497         * dom/MouseRelatedEvent.cpp:
3498         * dom/MouseRelatedEvent.h:
3499         * dom/UIEvent.cpp:
3500         (WebCore::UIEvent::~UIEvent):
3501         * dom/UIEvent.h:
3502         * dom/UIEventWithKeyState.h:
3503         * dom/XMLTokenizer.cpp:
3504         (WebCore::openFunc):
3505         * html/HTMLAnchorElement.cpp:
3506         (WebCore::HTMLAnchorElement::defaultEventHandler):
3507         * html/HTMLButtonElement.cpp:
3508         (WebCore::HTMLButtonElement::defaultEventHandler):
3509         * html/HTMLFormElement.cpp:
3510         (WebCore::HTMLFormElement::submitClick):
3511         (WebCore::HTMLFormElement::prepareSubmit):
3512         (WebCore::HTMLFormElement::submit):
3513         * html/HTMLFormElement.h:
3514         * html/HTMLInputElement.cpp:
3515         (WebCore::HTMLInputElement::defaultEventHandler):
3516         * html/HTMLSelectElement.cpp:
3517         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
3518         * loader/DocumentLoader.h:
3519         * loader/FrameLoader.h:
3520         * loader/FrameLoaderClient.h:
3521         * loader/NavigationAction.h:
3522         (WebCore::NavigationAction::event):
3523         * loader/icon/IconLoader.cpp:
3524         (WebCore::IconLoader::create):
3525         (WebCore::IconLoader::startLoading):
3526         (WebCore::IconLoader::didReceiveData):
3527         (WebCore::IconLoader::didFinishLoading):
3528         * loader/icon/IconLoader.h:
3529         * loader/loader.cpp:
3530         * loader/mac/DocumentLoaderMac.mm:
3531         (WebCore::DocumentLoader::URL):
3532         (WebCore::DocumentLoader::unreachableURL):
3533         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
3534         (WebCore::DocumentLoader::URLForHistory):
3535         * loader/mac/FrameLoaderMac.mm:
3536         (WebCore::FrameLoader::load):
3537         (WebCore::FrameLoader::willSendRequest):
3538         (WebCore::FrameLoader::clientRedirected):
3539         (WebCore::FrameLoader::shouldReload):
3540         (WebCore::FrameLoader::notifyIconChanged):
3541         (WebCore::FrameLoader::URL):
3542         (WebCore::FrameLoader::reloadAllowingStaleData):
3543         (WebCore::FrameLoader::reload):
3544         (WebCore::FrameLoader::didChangeTitle):
3545         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3546         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3547         (WebCore::FrameLoader::post):
3548         (WebCore::FrameLoader::addExtraFieldsToRequest):
3549         (WebCore::FrameLoader::loadResourceSynchronously):
3550         * loader/mac/IconLoaderMac.mm:
3551         (WebCore::IconLoader::notifyIconChanged):
3552         * loader/mac/LoaderFunctionsMac.mm:
3553         * loader/mac/MainResourceLoaderMac.mm:
3554         (WebCore::shouldLoadAsEmptyDocument):
3555         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3556         * loader/mac/NavigationActionMac.mm:
3557         (WebCore::navigationType):
3558         (WebCore::NavigationAction::NavigationAction):
3559         * loader/mac/ResourceLoaderMac.mm:
3560         * loader/mac/SubresourceLoaderMac.mm: