620a92177db44b70219f97a66cfa57cd48ff4acd
[WebKit-https.git] / WebCore / ChangeLog
1 2007-07-01  Rob Buis  <buis@kde.org>
2
3         Reviewed by Darin.
4
5         http://bugs.webkit.org/show_bug.cgi?id=14453
6         REGRESSION: www.nzherald.co.nz almost all the formating is gone
7  
8         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
9
10 2007-07-01  Sam Weinig  <sam@webkit.org>
11
12         Reviewed by Oliver.
13
14         Third round of implicit 64-32 bit conversion errors fixes.
15         <rdar://problem/5292262>
16
17         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
18           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
19
20         * css/CSSPrimitiveValue.cpp:
21         (WebCore::CSSPrimitiveValue::computeLengthInt):
22         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
23         (WebCore::CSSPrimitiveValue::computeLengthShort):
24         (WebCore::CSSPrimitiveValue::computeLengthFloat):
25         (WebCore::CSSPrimitiveValue::computeLengthDouble):
26         (WebCore::CSSPrimitiveValue::getDoubleValue):
27         * css/CSSPrimitiveValue.h:
28         (WebCore::CSSPrimitiveValue::getDoubleValue):
29         (WebCore::CSSPrimitiveValue::getFloatValue):
30         (WebCore::CSSPrimitiveValue::getIntValue):
31         * css/Counter.h:
32         (WebCore::Counter::listStyleNumber):
33         * css/MediaQueryEvaluator.cpp:
34         (WebCore::parseAspectRatio):
35         * css/cssparser.cpp:
36         (WebCore::BorderImageParseContext::commitBorderImage):
37         * css/cssstyleselector.cpp:
38         (WebCore::convertToLength):
39         (WebCore::applyCounterList):
40         (WebCore::CSSStyleSelector::applyProperty):
41         (WebCore::CSSStyleSelector::mapBackgroundSize):
42         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
43         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
44         * html/HTMLTableElement.cpp:
45         (WebCore::HTMLTableElement::parseMappedAttribute):
46         * ksvg2/css/SVGCSSStyleSelector.cpp:
47         (WebCore::CSSStyleSelector::applySVGProperty):
48         * ksvg2/misc/KCanvasRenderingStyle.cpp:
49         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
50         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
51
52 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
53
54         Reviewed by Darin.
55
56         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
57         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
58         <rdar://problem/5290084>
59
60         Use std::stable_sort() instead of qsort() to sort gradient stops.
61         Adjust the comparison function accordingly.
62
63         * html/CanvasGradient.cpp:
64         (WebCore::compareStops):
65         (WebCore::CanvasGradient::findStop):
66
67 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
68
69         Reviewed by Darin.
70
71         m_usesPageCache was not initialized. As the b/f cache is only
72         implemented in the Mac port and WebView.mm is taking care of calling
73         Settings::setUsesPageCache I decided to make it false by default.
74
75         * page/Settings.cpp:
76         (WebCore::Settings::Settings): m_usesPageCache was not initialized
77
78 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
79
80         Reviewed by Darin.
81
82         Inherited- and NonInheritedFlags is a bit field. But for comparsion
83         the other part of the union _iflags/_niflags is used for comparions.
84         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
85         Make sure the unused bits have a specified value.
86
87         * ksvg2/css/SVGRenderStyle.h:
88         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
89         have a value as well.
90
91 2007-06-30  Adam Roben  <aroben@apple.com>
92
93         Compile WebCore with /W4 on Windows
94
95         Some more warnings were disabled globally, including assignment within
96         a conditional, unused variable, and various warnings related to
97         inability to instantiate opaque structs.
98
99         In addition, the "unreachable code" warning was turned off for
100         CSSGrammar.cpp and XPathGrammar.cpp.
101
102         Reviewed by Oliver.
103
104         * WebCore.vcproj/WebCore.vcproj:
105
106 2007-06-29  Adam Roben  <aroben@apple.com>
107
108         Give CString an equality operator to fix a bug in HTMLFormElement::formData
109
110         The bug was spotted by MSVC /W4. The problem was that we were comparing
111         a CString to a char* using ==, but CString had no equality operator.
112         The result was that the CString was being cast to a const char* and a
113         pointer comparison was being done, which would (essentially) always
114         return false.
115
116         There are two parts to the fix: get rid of CString's const char*
117         casting operator, and add an equality operator. Previous uses of the
118         casting operator have been changed to use CString::data().
119
120         Test: http/misc/isindex-formdata.html
121
122         Reviewed by Oliver.
123
124         * dom/XMLTokenizer.cpp:
125         (WebCore::parseXMLDocumentFragment):
126         * html/HTMLDocument.cpp:
127         (WebCore::HTMLDocument::determineParseMode):
128         * html/HTMLFormElement.cpp:
129         (WebCore::HTMLFormElement::formData):
130         * loader/TextResourceDecoder.cpp:
131         (WebCore::TextResourceDecoder::checkForCSSCharset):
132         * platform/CString.cpp:
133         (WebCore::operator==):
134         * platform/CString.h:
135         * platform/KURL.cpp:
136         (WebCore::encodeRelativeString):
137         * platform/StringImpl.cpp:
138         (WebCore::StringImpl::toDouble):
139         * platform/network/cf/FormDataStreamCFNet.cpp:
140         (WebCore::setHTTPBody):
141         * platform/network/mac/FormDataStreamMac.mm:
142         (WebCore::setHTTPBody):
143         * platform/win/ClipboardUtilitiesWin.cpp:
144         (WebCore::markupToCF_HTML):
145         * plugins/win/PluginPackageWin.cpp:
146         (WebCore::splitString):
147         * plugins/win/PluginStreamWin.cpp:
148         (WebCore::PluginStreamWin::startStream):
149         (WebCore::PluginStreamWin::destroyStream):
150         (WebCore::PluginStreamWin::sendJavaScriptStream):
151         (WebCore::PluginStreamWin::didFinishLoading):
152         * plugins/win/PluginViewWin.cpp:
153         (WebCore::PluginViewWin::start):
154         (WebCore::createUTF8String):
155         (WebCore::PluginViewWin::userAgent):
156         * xml/XSLStyleSheet.cpp:
157         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
158         * xml/XSLTProcessor.cpp:
159         (WebCore::xsltParamArrayFromParameterMap):
160
161 2007-06-29  Adam Roben  <aroben@apple.com>
162
163         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
164
165         Reviewed by John.
166
167         * editing/Editor.cpp:
168         (WebCore::Editor::advanceToNextMisspelling):
169         * html/HTMLParser.cpp:
170
171 2007-06-29  Adam Roben  <aroben@apple.com>
172
173         Fix some possibly unitialized variables found by MSVC /W4
174
175         Reviewed by John.
176
177         * rendering/bidi.cpp:
178         (WebCore::RenderBlock::layoutInlineChildren):
179
180 2007-06-29  Adam Roben  <aroben@apple.com>
181
182         Remove bogus cast found by MSVC /W4
183
184         Reviewed by John and Oliver.
185
186         * ksvg2/css/SVGCSSParser.cpp:
187         (WebCore::CSSParser::parseSVGValue):
188
189 2007-06-29  Adam Roben  <aroben@apple.com>
190
191         Remove unused local functions uncovered by MSVC /W4
192
193         Reviewed by John and Oliver.
194
195         * platform/win/SearchPopupMenuWin.cpp:
196         * rendering/RenderText.cpp:
197
198 2007-06-29  Adam Roben  <aroben@apple.com>
199
200         Don't take the address of temporary values to appease MSVC /W4
201
202         Reviewed by Oliver.
203
204         No regression test possible.
205
206         * platform/win/PopupMenuWin.cpp:
207         (WebCore::PopupMenu::invalidateItem):
208         (WebCore::PopupMenu::valueChanged):
209         (WebCore::PopupWndProc):
210         * platform/win/ScrollViewWin.cpp:
211         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
212         * platform/win/UniscribeController.cpp:
213         (WebCore::UniscribeController::shapeAndPlaceItem):
214         * platform/win/WidgetWin.cpp:
215         (WebCore::Widget::invalidateRect):
216
217 2007-06-29  Adam Roben  <aroben@apple.com>
218
219         Make an int -> UINT conversion explicit that MSVC /W4 complains about
220
221         Reviewed by John and Oliver.
222
223         No regression test possible.
224
225         * platform/win/SoundWin.cpp:
226
227 2007-06-29  Adam Roben  <aroben@apple.com>
228
229         Remove unreachable code uncovered by MSVC /W4
230
231         Reviewed by Oliver.
232
233         No regression test possible.
234
235         * html/CanvasRenderingContext2D.cpp:
236         (WebCore::CanvasRenderingContext2D::createPattern):
237         * html/HTMLAnchorElement.cpp:
238         (WebCore::HTMLAnchorElement::isLiveLink):
239         * html/HTMLElement.cpp:
240         (WebCore::HTMLElement::contentEditable):
241         * platform/DeprecatedString.cpp:
242         (WebCore::allocateHandle):
243         (WebCore::freeHandle):
244         * plugins/win/npapi.cpp:
245         (pluginViewForInstance):
246         * rendering/RenderImage.cpp:
247         (WebCore::RenderImage::isWidthSpecified):
248         (WebCore::RenderImage::isHeightSpecified):
249         * rendering/RenderTheme.cpp:
250         (WebCore::RenderTheme::isControlStyled):
251
252 2007-06-29  John Sullivan  <sullivan@apple.com>
253
254         Reviewed by Oliver Hunt.
255         
256         - WebCore support for accessing the set of rectangles that encompass the selected text
257         
258         * page/Frame.h:
259         * page/Frame.cpp:
260         (WebCore::Frame::selectionTextRects):
261         new function, fills in a passed Vector with the line box rects that represent the selected range
262
263         * rendering/RenderText.cpp:
264         (WebCore::RenderText::addLineBoxRects):
265         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
266
267         * WebCore.exp:
268         exported symbol for this new function
269
270 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
271
272         Reviewed by Harrison.
273         
274         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
275         
276         Rolled out a change made in r23787.
277         
278         * editing/DeleteSelectionCommand.cpp:
279         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
280
281 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
282
283         Reviewed by Darin Adler, Anders Carlsson.
284         
285         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
286         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
287         
288         The spec says that responseXML must return null for any HTTP response
289         with a non-XML MIME type. Technically, that leaves non-HTTP responses
290         free to do whatever they want.
291
292         * xml/xmlhttprequest.cpp:
293         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
294         MIME types if the response was HTTP.
295
296 2007-06-29  Sam Weinig  <sam@webkit.org>
297
298         Reviewed by Darin.
299
300         Second pass at fixing implicit 64-32 bit conversion errors.
301         <rdar://problem/5292262>
302
303         - Use new JSValue::toFloat() method instead of toNumber() where
304           appropriate.
305
306         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
307         (WebCore::JSCanvasRenderingContext2D::setFillColor):
308         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
309         (WebCore::JSCanvasRenderingContext2D::strokeRect):
310         (WebCore::JSCanvasRenderingContext2D::drawImage):
311         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
312         (WebCore::JSCanvasRenderingContext2D::setShadow):
313         * bindings/js/JSHTMLSelectElementCustom.cpp:
314         (WebCore::JSHTMLSelectElement::remove):
315         * bindings/js/JSSVGMatrixCustom.cpp:
316         (WebCore::JSSVGMatrix::rotateFromVector):
317         * bindings/js/kjs_events.cpp:
318         (KJS::JSClipboardPrototypeFunction::callAsFunction):
319         * bindings/scripts/CodeGeneratorJS.pm:
320         * ksvg2/svg/SVGScriptElement.cpp:
321         (WebCore::SVGScriptElement::executeScript):
322
323 2007-06-29  Adele Peterson  <adele@apple.com>
324
325         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
326
327         * html/HTMLInputElement.h:
328         * html/HTMLTextAreaElement.h:
329
330 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
331
332         Reviewed by Oliver Hunt.
333
334         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
335         local file throws exception -- breaks Wikipedia widget
336
337         * WebCore.xcodeproj/project.pbxproj:
338         * xml/xmlhttprequest.cpp:
339         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
340
341 2007-06-29  Ada Chan  <adachan@apple.com>
342
343         Reviewed by Adam.
344
345         Fixed a previous fix to a signed/unsigned mismatch.
346
347         * plugins/win/PluginPackageWin.cpp:
348         (WebCore::splitString):
349
350 2007-06-29  Adele Peterson  <adele@apple.com>
351
352         Reviewed by Ada and Kevin McCullough.
353
354         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
355
356         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
357
358         Tests:
359         fast/forms/input-readonly-select-all.html
360         fast/forms/textarea-readonly-select-all.html
361
362         * html/HTMLInputElement.h:
363         (WebCore::HTMLInputElement::canSelectAll):
364         (WebCore::HTMLInputElement::selectAll):
365         * html/HTMLTextAreaElement.h:
366         (WebCore::HTMLTextAreaElement::canSelectAll):
367         (WebCore::HTMLTextAreaElement::selectAll):
368
369 2007-06-29  Adam Roben  <aroben@apple.com>
370
371         Build fix
372
373         This is what happens when you test your patch on two OSs and then
374         commit from the wrong one.
375
376         * rendering/RenderTextControl.cpp:
377         (WebCore::RenderTextControl::valueChanged):
378         (WebCore::RenderTextControl::itemText):
379         (WebCore::RenderTextControl::itemIsSeparator):
380
381 2007-06-29  Adam Roben  <aroben@apple.com>
382
383         Start compiling WebCore with /W3 under MSVC
384
385         One warning was globally disabled: implicit conversion of int to bool.
386
387         Reviewed by Darin.
388
389         * WebCore.vcproj/WebCore.vcproj:
390
391 2007-06-29  Adam Roben  <aroben@apple.com>
392
393         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
394
395         DeprecatedStringData now has no public copy constructor. The single
396         call to the old one has been replaced with a call to the new
397         DeprecatedStringData::createAndAdopt static method.
398
399         Reviewed by Darin.
400
401         All regression tests pass.
402
403         * platform/DeprecatedString.cpp:
404         (WebCore::DeprecatedStringData::createAndAdopt):
405         (WebCore::DeprecatedStringData::adopt):
406         (WebCore::DeprecatedString::detachIfInternal):
407         * platform/DeprecatedString.h:
408
409 2007-06-29  Adam Roben  <aroben@apple.com>
410
411         Fix more signed/unsigned mismatches uncovered by MSVC /W3
412
413         Reviewed by John.
414
415         No regression tests possible.
416
417         * platform/network/cf/ResourceResponseCFNet.cpp:
418         (WebCore::filenameHasSaneExtension):
419         * platform/win/FontDataWin.cpp:
420         (WebCore::FontData::containsCharacters):
421         * platform/win/PlatformScrollBarSafari.cpp:
422         (WebCore::):
423         * platform/win/UniscribeController.cpp:
424         (WebCore::UniscribeController::advance):
425         (WebCore::UniscribeController::shapeAndPlaceItem):
426         * platform/win/WebCoreTextRenderer.cpp:
427         (WebCore::doDrawTextAtPoint):
428         * plugins/win/PluginDatabaseWin.cpp:
429         (WebCore::parseVersionString):
430         * plugins/win/PluginPackageWin.cpp:
431         (WebCore::splitString):
432         * plugins/win/PluginViewWin.cpp:
433         (WebCore::freeStringArray):
434         (WebCore::PluginViewWin::invalidateTimerFired):
435
436 2007-06-29  Adam Roben  <aroben@apple.com>
437
438         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
439
440         Reviewed by John.
441
442         No regression test possible.
443
444         * html/HTMLSelectElement.cpp:
445         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
446         * platform/PopupMenuClient.h:
447         * platform/win/PopupMenuWin.cpp:
448         (WebCore::PopupMenu::calculatePositionAndSize):
449         (WebCore::PopupMenu::focusFirst):
450         (WebCore::PopupMenu::focusLast):
451         (WebCore::PopupMenu::down):
452         (WebCore::PopupMenu::up):
453         (WebCore::PopupMenu::paint):
454         * rendering/RenderMenuList.cpp:
455         * rendering/RenderMenuList.h:
456         * rendering/RenderTextControl.cpp:
457         * rendering/RenderTextControl.h:
458
459 2007-06-29  Adam Roben  <aroben@apple.com>
460
461         Fix two typos spotted by MSVC /W3
462
463         Both typos were a semicolon following the condition of an if. This
464         would cause the intended body of the if to always execute.
465
466         Unfortunately neither of these fixes are testable.
467         BackForwardList::goForward is only called from WebBackForwardList, and
468         the createDragImageFromImage bug would only manifest itself when
469         CreateCompatibleDC failed.
470
471         Reviewed by Mark.
472
473         * history/BackForwardList.cpp:
474         (WebCore::BackForwardList::goForward):
475         * platform/win/DragImageWin.cpp:
476         (WebCore::createDragImageFromImage):
477
478 2007-06-29  Adam Treat  <adam@staikos.net>
479
480         Reviewed by george Staikos.
481
482         Support horizontal and vertical scroll, and set the right units.
483
484         * platform/qt/WheelEventQt.cpp:
485         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
486
487 2007-06-28  Adam Roben  <aroben@apple.com>
488
489         Get WebCore compiling with /W2 on Windows
490
491         Reviewed by Steve.
492
493         No regression tests affected.
494
495         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
496         disable two warnings: implicit int <=> float conversion, and class vs.
497         struct inconsistency.
498         * dom/CharacterData.cpp:
499         (WebCore::CharacterData::deleteData): Cast to int before negating.
500         * loader/Cache.cpp:
501         (WebCore::Cache::remove): Ditto.
502         * platform/graphics/Path.cpp:
503         (WebCore::pathLengthApplierFunction): Consistently use floats.
504         * platform/graphics/cg/GraphicsContextCG.cpp:
505         (WebCore::GraphicsContext::drawEllipse): Ditto.
506         * platform/win/GraphicsContextWin.cpp:
507         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
508
509 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
510
511         Reviewed by Maciej Stachowiak.
512         
513         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
514         pool => pathologically high high water mark
515         
516         I couldn't measure any performance problems with iBench HTML or PLT.
517
518         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
519         * platform/mac/SharedTimerMac.cpp:
520         (WebCore::timerFired): Added autorelease pool.
521
522 2007-06-28  Mitz Pettel  <mitz@webkit.org>
523
524         Reviewed by Beth.
525
526         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
527           ASSERTION FAILED: !needsLayout() seen again
528
529         Test: fast/dynamic/recursive-layout.html
530
531         * page/FrameView.cpp:
532         (WebCore::FrameView::layout): Removed the midLayout guards around
533         the calls to invalidateSelection() and updateWidgetPositions(). Those
534         calls may dirty the layout, but in that case they also update it, so
535         they should be allowed to do it. Added an ASSERT to make sure that when
536         they return, the root is not marked for layout.
537
538 2007-06-28  Sam Weinig  <sam@webkit.org>
539
540         Rubberstamped by Adam Roben.
541
542         Roll out r23861.  It caused the buildbot to fail on intel.
543
544         * page/Page.cpp:
545         (WebCore::Page::goToItem):
546
547 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
548
549         Reviewed by Geoff.
550
551         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
552         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
553
554         Modification of an ASSERT on goToItem related to go back/forward in
555         history.Don't need to check the frameset if the target is _blank.
556
557          * page/Page.cpp:
558          (WebCore::Page::goToItem):
559
560 2007-06-28  Anders Carlsson  <andersca@apple.com>
561
562         Reviewed by Oliver.
563
564         <rdar://problem/5234139>
565         <object> with PNG src rendered as image document.
566         
567         Complete the URL before passing it to the frame loader client.
568         
569         * html/HTMLObjectElement.cpp:
570         (WebCore::HTMLObjectElement::isImageType):
571
572 2007-06-28  Rob Buis  <buis@kde.org>
573
574         Reviewed by Maciej.
575
576         http://bugs.webkit.org/show_bug.cgi?id=14373
577         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
578
579         Make sure the id selector validates against the CSS2.1 identfier
580         definition, not the hexcolor/HASH definition.
581
582         * css/CSSGrammar.y:
583         * css/cssparser.cpp:
584         (WebCore::CSSParser::lex):
585         (WebCore::CSSParser::text):
586         * css/tokenizer.flex:
587
588 2007-06-28  Simon Hausmann  <hausmann@kde.org>
589
590         Reviewed by Zack.
591
592         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
593
594         * platform/qt/PasteboardQt.cpp:
595         (WebCore::Pasteboard::writeSelection):
596
597 2007-06-28  Antti Koivisto  <antti@apple.com>
598
599         Reviewed by Mitz.
600         
601         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
602         Bug 14332: REGRESSION (r21145): <td> width ignored
603         <rdar://problem/5290123>
604         
605         Cells in table with non-zero cellpadding are not considered empty.
606
607         * rendering/AutoTableLayout.cpp:
608         (WebCore::AutoTableLayout::recalcColumn):
609
610 2007-06-28  Adam Roben  <aroben@apple.com>
611
612         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
613
614         Reviewed by Hyatt.
615
616         No layout test possible, as this bug didn't have any effect since
617         "bool & bool" has the same value as "bool && bool"
618
619         * rendering/RenderBlock.cpp:
620         (WebCore::RenderBlock::paintObject): Changed & to &&.
621
622 2007-06-28  Adam Roben  <aroben@apple.com>
623
624         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
625
626         The bug was caused by two typos found by prefast.
627
628         Reviewed by Hyatt.
629
630         * css/cssparser.cpp:
631         (WebCore::CSSParser::parseValue): Fixed typos.
632
633 2007-06-20  Matt Perry  <mpComplete@gmail.com>
634
635         Reviewed by Adam.
636
637         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
638           onchange handler for select controls doesn't fire when changing via keyboard
639
640         * html/HTMLSelectElement.cpp:
641         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
642         a call to saveLastSelection in the "Enter" key handler for select
643         controls that was preventing onchange from firing.
644
645 2007-06-27  Sam Weinig  <sam@webkit.org>
646
647         Fix Gdk, Qt, and Win32 builds.
648
649         * WebCore.pro:
650         * WebCore.vcproj/WebCore.vcproj:
651
652 2007-06-27  Sam Weinig  <sam@webkit.org>
653
654         Reviewed by Geoff.
655
656         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
657         Move the Selection object out of the JS bindings
658
659         - Renames JS Object Selection to DOMSelection to avoid a name
660           conflict.
661
662         * DerivedSources.make:
663         * WebCore.xcodeproj/project.pbxproj:
664         * bindings/js/kjs_window.cpp:
665         (KJS::WindowPrivate::WindowPrivate):
666         (KJS::Window::mark):
667         (KJS::Window::clearHelperObjectProperties):
668         (KJS::WindowFunc::callAsFunction):
669         (KJS::Window::disconnectFrame):
670         * bindings/js/kjs_window.h:
671         (KJS::Window::):
672         * page/DOMSelection.cpp: Added.
673         (WebCore::DOMSelection::DOMSelection):
674         (WebCore::DOMSelection::frame):
675         (WebCore::DOMSelection::disconnectFrame):
676         (WebCore::DOMSelection::anchorNode):
677         (WebCore::DOMSelection::baseNode):
678         (WebCore::DOMSelection::anchorOffset):
679         (WebCore::DOMSelection::baseOffset):
680         (WebCore::DOMSelection::focusNode):
681         (WebCore::DOMSelection::extentNode):
682         (WebCore::DOMSelection::focusOffset):
683         (WebCore::DOMSelection::extentOffset):
684         (WebCore::DOMSelection::isCollapsed):
685         (WebCore::DOMSelection::type):
686         (WebCore::DOMSelection::rangeCount):
687         (WebCore::DOMSelection::collapse):
688         (WebCore::DOMSelection::collapseToEnd):
689         (WebCore::DOMSelection::collapseToStart):
690         (WebCore::DOMSelection::empty):
691         (WebCore::DOMSelection::setBaseAndExtent):
692         (WebCore::DOMSelection::setPosition):
693         (WebCore::DOMSelection::modify):
694         (WebCore::DOMSelection::getRangeAt):
695         (WebCore::DOMSelection::removeAllRanges):
696         (WebCore::DOMSelection::addRange):
697         (WebCore::DOMSelection::toString):
698         * page/DOMSelection.h: Added.
699         * page/DOMSelection.idl: Added.
700         * page/DOMWindow.cpp:
701         (WebCore::DOMWindow::disconnectFrame):
702         (WebCore::DOMWindow::getSelection):
703         * page/DOMWindow.h:
704         * page/DOMWindow.idl:
705
706 2007-06-27  Sam Weinig  <sam@webkit.org>
707
708         Reviewed by Maciej.
709
710         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
711         Autogenerate Event JS binding
712
713         - Cleanup kjs_events
714
715         * bindings/js/kjs_events.cpp:
716         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
717         (WebCore::JSAbstractEventListener::handleEvent):
718         (WebCore::JSAbstractEventListener::isHTMLEventListener):
719         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
720         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
721         (WebCore::JSUnprotectedEventListener::listenerObj):
722         (WebCore::JSUnprotectedEventListener::windowObj):
723         (WebCore::JSUnprotectedEventListener::clearWindowObj):
724         (WebCore::JSUnprotectedEventListener::mark):
725         (WebCore::JSEventListener::JSEventListener):
726         (WebCore::JSEventListener::~JSEventListener):
727         (WebCore::JSEventListener::listenerObj):
728         (WebCore::JSEventListener::windowObj):
729         (WebCore::JSEventListener::clearWindowObj):
730         (WebCore::JSLazyEventListener::JSLazyEventListener):
731         (WebCore::JSLazyEventListener::listenerObj):
732         (WebCore::JSLazyEventListener::parseCode):
733         (WebCore::getNodeEventListener):
734         (WebCore::JSClipboard::JSClipboard):
735         (WebCore::JSClipboard::getValueProperty):
736         (WebCore::JSClipboard::putValueProperty):
737         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
738         (WebCore::toJS):
739         (WebCore::toClipboard):
740         * bindings/js/kjs_events.h:
741         (WebCore::JSClipboard::classInfo):
742         (WebCore::JSClipboard::impl):
743         * bindings/js/kjs_window.h:
744         * ksvg2/events/JSSVGLazyEventListener.h:
745
746 2007-06-27  Sam Weinig  <sam@webkit.org>
747
748         Reviewed by Adam Roben.
749
750         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
751         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
752         <rdar://problem/5286670>
753
754         Test: fast/forms/thumbslider-no-parent-slider.html
755         Test: fast/forms/thumbslider-crash.html
756
757         * rendering/RenderObject.h:
758         (WebCore::RenderObject::isSlider):
759         * rendering/RenderSlider.h:
760         (WebCore::RenderSlider::isSlider):
761         * rendering/RenderTheme.cpp:
762         (WebCore::RenderTheme::paint): Only paint thumbslider
763         if the parent renderer is a RenderSlider.
764         * rendering/RenderThemeMac.mm:
765         (WebCore::RenderThemeMac::paintSliderThumb):
766         * rendering/RenderThemeSafari.cpp:
767         (WebCore::RenderThemeSafari::paintSliderThumb):
768
769 2007-06-27  George Staikos  <staikos@kde.org>
770
771         Make Qt builds link when XSLT is turned off.
772
773         * WebCore.pro:
774
775 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
776
777         Turn on static code analysis (Windows only).
778
779         Affects only folks that have Visual Studio Team Suite installed,
780         or who have replaced their compiler with the version shipping in the
781         Vista SDK.
782         
783         Reviewed by Oliver.
784
785         * WebCore.vcproj/WebCore.vcproj:
786
787 2007-06-27  George Staikos  <staikos@kde.org>
788
789         Remove old commented out files that no-longer exist.
790
791         * WebCore.pro:
792
793 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
794
795         Reviewed by John.
796
797         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
798         
799         Pasting with a trailing interchange newline doesn't work when pasting
800         into an empty line.  Code that handles removing brs at the insertion
801         position tries to also handle trailing interchange newlines by re-using
802         those brs and fails.  Removed that code and handle all interchange
803         newlines with code later in doApply().
804
805         * editing/ReplaceSelectionCommand.cpp:
806         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
807         endBR when there's a trailing interchange newline.
808         
809 2007-06-27  Anders Carlsson  <andersca@apple.com>
810
811         Reviewed by Oliver.
812
813         <rdar://problem/5253950>
814         When Shockwave plugin has been loaded, exiting crashes Safari
815         
816         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
817         
818         * plugins/win/PluginPackageWin.cpp:
819         (WebCore::PluginPackageWin::PluginPackageWin):
820         (WebCore::PluginPackageWin::load):
821         (WebCore::PluginPackageWin::unload):
822         (WebCore::PluginPackageWin::unloadWithoutShutdown):
823         * plugins/win/PluginPackageWin.h:
824         
825         * plugins/win/PluginViewWin.cpp:
826         (WebCore::PluginViewWin::~PluginViewWin):
827         Make sure to unload the plugin package and clear any references to plugin script objects.
828
829 2007-06-27  George Staikos  <staikos@kde.org>
830
831         This was succeeding compile by luck.  Setup dependencies properly.
832
833         * WebCore.pro:
834
835 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
836
837         Reviewed by John.
838
839         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
840         
841         When a quoted numbered list is broken in half, it's cloned
842         to make the second list. That second list needs its start attribute
843         set so that the numbers of the list items in it will be preserved.
844
845         * editing/BreakBlockquoteCommand.cpp:
846         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
847         of a cloned list to be the original number of the first list item in it.
848
849 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
850
851         Reviewed by Geoff.
852
853         http://bugs.webkit.org/show_bug.cgi?id=14413
854         GIF animation throttling is different from MSIE
855
856         * platform/graphics/cg/ImageSourceCG.cpp:
857         (WebCore::ImageSource::frameDurationAtIndex):
858         Change the cut-off value to 50ms to match MSIE.
859
860 2007-06-27  Sam Weinig  <sam@webkit.org>
861
862         Reviewed by Darin.
863
864         First pass at fixing implicit 64-32 bit conversion errors.
865         <rdar://problem/5292262>
866
867         - Add 'f' suffix where necessary.
868
869         * bridge/mac/WebCoreAXObject.mm:
870         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
871         * css/csshelper.h:
872         * css/cssstyleselector.cpp:
873         (WebCore::):
874         (WebCore::CSSStyleSelector::largerFontSize):
875         (WebCore::CSSStyleSelector::smallerFontSize):
876         * html/CanvasGradient.cpp:
877         (WebCore::CanvasGradient::addColorStop):
878         * html/CanvasPattern.cpp:
879         (WebCore::CanvasPattern::createPattern):
880         * ksvg2/css/SVGCSSStyleSelector.cpp:
881         (WebCore::CSSStyleSelector::applySVGProperty):
882         * ksvg2/css/SVGRenderStyle.h:
883         * ksvg2/events/SVGZoomEvent.cpp:
884         (WebCore::SVGZoomEvent::SVGZoomEvent):
885         * ksvg2/svg/SVGLength.cpp:
886         (WebCore::SVGLength::SVGLength):
887         (WebCore::SVGLength::value):
888         (WebCore::SVGLength::setValue):
889         (WebCore::SVGLength::valueAsPercentage):
890         (WebCore::SVGLength::PercentageOfViewport):
891         * ksvg2/svg/SVGSVGElement.cpp:
892         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
893         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
894         (WebCore::SVGSVGElement::getScreenCTM):
895         * ksvg2/svg/SVGTextContentElement.cpp:
896         (WebCore::SVGTextContentElement::getComputedTextLength):
897         (WebCore::SVGTextContentElement::getSubStringLength):
898         (WebCore::SVGTextContentElement::getRotationOfChar):
899         * ksvg2/svg/SVGTransformDistance.cpp:
900         (WebCore::SVGTransformDistance::SVGTransformDistance):
901         (WebCore::SVGTransformDistance::distance):
902         * page/InspectorController.cpp:
903         (WebCore::InspectorResource::InspectorResource):
904         * platform/graphics/FloatPoint3D.cpp:
905         (WebCore::FloatPoint3D::normalize):
906         * platform/graphics/Path.cpp:
907         (WebCore::pathLengthApplierFunction):
908         (WebCore::Path::createRoundedRectangle):
909         * platform/graphics/cg/GraphicsContextCG.cpp:
910         (WebCore::GraphicsContext::drawLine):
911         (WebCore::GraphicsContext::strokeArc):
912         * platform/graphics/cg/ImageCG.cpp:
913         (WebCore::FrameData::clear):
914         * platform/graphics/cg/ImageSourceCG.cpp:
915         (WebCore::ImageSource::frameDurationAtIndex):
916         * platform/graphics/cg/PDFDocumentImage.cpp:
917         (WebCore::PDFDocumentImage::setCurrentPage):
918         * platform/graphics/svg/SVGPaintServerPattern.cpp:
919         (WebCore::SVGPaintServerPattern::externalRepresentation):
920         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
921         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
922         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
923         (WebCore::cgGradientCallback):
924         (WebCore::CGShadingRefForRadialGradient):
925         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
926         * platform/mac/FontDataMac.mm:
927         (WebCore::webFallbackFontFamily):
928         * platform/mac/PopupMenuMac.mm:
929         (WebCore::PopupMenu::show):
930         * rendering/InlineFlowBox.cpp:
931         (WebCore::InlineFlowBox::placeBoxesHorizontally):
932         * rendering/RenderSlider.cpp:
933         (WebCore::RenderSlider::setValueForPosition):
934         (WebCore::RenderSlider::setPositionFromValue):
935
936 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
937
938         Reviewed by Geoff.
939
940         http://bugs.webkit.org/show_bug.cgi?id=14288
941         XMLHttpRequest doesn't use a correct content type for file:// URLs
942
943         Test: fast/dom/xmlhttprequest-html-response-encoding.html
944
945         * xml/xmlhttprequest.cpp:
946         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
947         the network layer, since it provides it even for non-HTTP responses.
948
949 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
950
951         Reviewed by Sam Weinig.
952
953         http://bugs.webkit.org/show_bug.cgi?id=14061
954         Implement more of FrameLoaderClientGdk
955
956         Make FrameLoaderClientGdk work properly when the MIME type is set.
957
958         * loader/gdk/FrameLoaderClientGdk.cpp:
959         (WebCore::FrameLoaderClientGdk::objectContentType):
960         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
961
962 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
963
964         Reviewed by Maciej.
965
966         http://bugs.webkit.org/show_bug.cgi?id=14058
967         Gdk font backend cleanup
968
969         * platform/FontData.h: Remove obsolete function.
970         * platform/gdk/FontDataGdk.cpp:
971         (WebCore::FontData::containsCharacters): Lock/unlock only once.
972         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
973         * platform/gdk/FontPlatformData.h: Remove obsolete function.
974         * platform/gdk/FontPlatformDataGdk.cpp:
975         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
976         not the pixel size.
977         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
978         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
979         (WebCore::GlyphPage::fill): Lock/unlock only once.
980
981 2007-06-26  Mitz Pettel  <mitz@webkit.org>
982
983         Reviewed by Hyatt.
984
985         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
986           <colgroup>'s borders are ignored when it has <col> children
987
988         Covered by existing tests.
989
990         * rendering/RenderTableCell.cpp:
991         (WebCore::RenderTableCell::collapsedLeftBorder):
992         (WebCore::RenderTableCell::collapsedRightBorder):
993         (WebCore::RenderTableCell::collapsedTopBorder):
994         (WebCore::RenderTableCell::collapsedBottomBorder):
995
996 2007-06-26  Mitz Pettel  <mitz@webkit.org>
997
998         Reviewed by Oliver.
999
1000         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
1001           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
1002
1003         Test: fast/repaint/text-selection-rect-in-overflow-2.html
1004
1005         * rendering/RenderObject.cpp:
1006         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
1007         for overflow scroll and columns.
1008         * rendering/RenderText.cpp:
1009         (WebCore::RenderText::selectionRect): Adjust for columns only in the
1010         non-clipped case, since RenderObject::absolutePosition() does not.
1011
1012 2007-06-26  Mitz Pettel  <mitz@webkit.org>
1013
1014         Reviewed by Sam.
1015
1016         - http://bugs.webkit.org/show_bug.cgi?id=14415
1017           Remove the unused method RenderObject::setTable()
1018
1019         * rendering/RenderObject.h:
1020
1021 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
1022
1023         Reviewed by Maciej.
1024
1025         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
1026         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
1027
1028         This change moves the bulk of ResourceRequest into a base class named
1029         ResourceRequestBase with all platform-specific bits pushed into
1030         ResourceRequest.  This allows ports to easily add new members to a
1031         ResourceRequest without having to #ifdef the code that is shared
1032         between ports.
1033
1034         * WebCore.exp:
1035         * WebCore.pro:
1036         * WebCore.vcproj/WebCore.vcproj:
1037         * WebCore.xcodeproj/project.pbxproj:
1038         * platform/network/ResourceRequest.cpp: Removed.
1039         * platform/network/ResourceRequest.h: Removed.
1040         * platform/network/ResourceRequestBase.cpp: Added.
1041         (WebCore::ResourceRequestBase::asResourceRequest):
1042         (WebCore::ResourceRequestBase::isEmpty):
1043         (WebCore::ResourceRequestBase::isNull):
1044         (WebCore::ResourceRequestBase::url):
1045         (WebCore::ResourceRequestBase::setURL):
1046         (WebCore::ResourceRequestBase::cachePolicy):
1047         (WebCore::ResourceRequestBase::setCachePolicy):
1048         (WebCore::ResourceRequestBase::timeoutInterval):
1049         (WebCore::ResourceRequestBase::setTimeoutInterval):
1050         (WebCore::ResourceRequestBase::mainDocumentURL):
1051         (WebCore::ResourceRequestBase::setMainDocumentURL):
1052         (WebCore::ResourceRequestBase::httpMethod):
1053         (WebCore::ResourceRequestBase::setHTTPMethod):
1054         (WebCore::ResourceRequestBase::httpHeaderFields):
1055         (WebCore::ResourceRequestBase::httpHeaderField):
1056         (WebCore::ResourceRequestBase::setHTTPHeaderField):
1057         (WebCore::ResourceRequestBase::httpBody):
1058         (WebCore::ResourceRequestBase::setHTTPBody):
1059         (WebCore::ResourceRequestBase::allowHTTPCookies):
1060         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
1061         (WebCore::ResourceRequestBase::addHTTPHeaderField):
1062         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
1063         (WebCore::operator==):
1064         (WebCore::ResourceRequestBase::isConditional):
1065         (WebCore::ResourceRequestBase::updatePlatformRequest):
1066         (WebCore::ResourceRequestBase::updateResourceRequest):
1067         * platform/network/ResourceRequestBase.h: Added.
1068         (WebCore::):
1069         (WebCore::ResourceRequestBase::httpContentType):
1070         (WebCore::ResourceRequestBase::setHTTPContentType):
1071         (WebCore::ResourceRequestBase::httpReferrer):
1072         (WebCore::ResourceRequestBase::setHTTPReferrer):
1073         (WebCore::ResourceRequestBase::clearHTTPReferrer):
1074         (WebCore::ResourceRequestBase::httpUserAgent):
1075         (WebCore::ResourceRequestBase::setHTTPUserAgent):
1076         (WebCore::ResourceRequestBase::httpAccept):
1077         (WebCore::ResourceRequestBase::setHTTPAccept):
1078         (WebCore::ResourceRequestBase::ResourceRequestBase):
1079         (WebCore::operator!=):
1080         * platform/network/cf/ResourceRequest.h: Added.
1081         (WebCore::ResourceRequest::ResourceRequest):
1082         * platform/network/curl/ResourceRequest.h: Added.
1083         (WebCore::ResourceRequest::ResourceRequest):
1084         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1085         (WebCore::ResourceRequest::doUpdateResourceRequest):
1086         * platform/network/mac/ResourceRequest.h: Added.
1087         (WebCore::ResourceRequest::ResourceRequest):
1088         * platform/network/qt/ResourceRequest.h: Added.
1089         (WebCore::ResourceRequest::ResourceRequest):
1090         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1091         (WebCore::ResourceRequest::doUpdateResourceRequest):
1092
1093 2007-06-26  Adam Roben  <aroben@apple.com>
1094
1095         Add ChangeLog entries from the Windows merge.
1096
1097         Reviewed by Maciej.
1098
1099         * ChangeLog:
1100
1101 2007-06-26  Sam Weinig  <sam@webkit.org>
1102
1103         Reviewed by Maciej.
1104
1105         Make sure not to enumerate the toString() function.
1106         <rdar://problem/5297118>
1107
1108         * bindings/js/kjs_window.cpp:
1109         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
1110         * html/HTMLAnchorElement.idl:
1111
1112 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1113
1114         Reviewed by Mitz, landed by Anders.
1115
1116         http://bugs.webkit.org/show_bug.cgi?id=14421
1117         Implement GraphicsContext::clearRect()
1118
1119         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1120         (WebCore::GraphicsContext::clearRect):
1121
1122 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
1123
1124         Reviewed and landed by Anders.
1125
1126         http://bugs.webkit.org/show_bug.cgi?id=14416
1127         Content does not render fully in some cases
1128
1129         Fix mismatched calls to cairo_save/restore due to an early method return.
1130
1131         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1132         (WebCore::GraphicsContext::drawLine):
1133
1134 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
1135
1136         Reviewed by John Sullivan.
1137
1138         Added two accessor functions for <rdar://problem/4119138>
1139
1140         * bindings/objc/DOMHTML.mm:
1141         (-[DOMHTMLInputElement _isEdited]):
1142         (-[DOMHTMLTextAreaElement _isEdited]):
1143         Added an accessor to the isEdited value of a DOM node's render object
1144
1145         * bindings/objc/DOMPrivate.h:
1146         Added header definitions for _isEdited
1147
1148 2007-06-26  Sam Weinig  <sam@webkit.org>
1149
1150         Fix Win32 build.
1151
1152         * WebCore.vcproj/WebCore.vcproj:
1153
1154 2007-06-26  Sam Weinig  <sam@webkit.org>
1155
1156         Fix Qt and Gdk builds.
1157
1158         * WebCore.pro:
1159
1160 2007-06-26  Sam Weinig  <sam@webkit.org>
1161
1162         Reviewed by Geoff.
1163
1164         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
1165         Autogenerate Event JS binding
1166
1167         - Moves the dataTransfer method into MouseEvent where it should be.
1168
1169         * WebCore.xcodeproj/project.pbxproj:
1170         * bindings/js/JSEventCustom.cpp: Added.
1171         (WebCore::JSEvent::clipboardData):
1172         (WebCore::toJS):
1173         * bindings/js/JSEventTargetNode.cpp:
1174         * bindings/js/JSXMLHttpRequest.cpp:
1175         * bindings/js/kjs_events.cpp:
1176         * bindings/js/kjs_events.h:
1177         * bindings/objc/DOMUtility.mm:
1178         (KJS::createDOMWrapper):
1179         * bindings/scripts/CodeGeneratorJS.pm:
1180         * dom/Event.h:
1181         (WebCore::Event::returnValue):
1182         (WebCore::Event::setReturnValue):
1183         (WebCore::Event::clipboardData):
1184         * dom/Event.idl:
1185         * dom/MouseEvent.h:
1186         (WebCore::MouseEvent::dataTransfer):
1187         * dom/MouseEvent.idl:
1188
1189 2007-06-26  Timothy Hatcher  <timothy@apple.com>
1190
1191         Reviewed by Mark Rowe.
1192
1193         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1194         http://bugs.webkit.org/show_bug.cgi?id=14385
1195
1196         Correctly remember the "Show implicit properties" setting as you switch nodes.
1197
1198         * page/inspector/ResourcePanel.js:
1199
1200 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
1201
1202         Reviewed by John.
1203
1204         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
1205         
1206         Editing removed a node that was part of a search field's internal
1207         structure that should not be removed.
1208
1209         * editing/DeleteSelectionCommand.cpp:
1210         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
1211         selection to delete ends at [container, x], where x is the number
1212         of children in container, don't remove container.  Special case
1213         code elsewhere in this function will remove it if necessary.
1214
1215 2007-06-25  Sam Weinig  <sam@webkit.org>
1216
1217         Reviewed by Maciej.
1218
1219         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
1220         Mutating document.constructor.prototype mutates Object.prototype
1221
1222         Test: fast/js/constructor.html
1223
1224         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
1225         classes with constructors.  It is an non-enumeratable, non-deletable,
1226         readonly attribute.
1227
1228 2007-06-26  George Staikos  <staikos@kde.org>
1229
1230         Repair the OS X build.
1231
1232         * WebCore.exp:
1233
1234 2007-06-26  Adam Treat  <adam@staikos.net>
1235
1236         Reviewed by Adam Roben.
1237
1238         Make the SQLite icon database optional.
1239
1240         * loader/icon/IconDatabase.cpp:
1241         (WebCore::IconDatabase::isOpen):
1242         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1243         (WebCore::IconDatabase::enabled):
1244         * loader/icon/IconDatabase.h:
1245
1246 2007-06-25  Sam Weinig  <sam@webkit.org>
1247
1248         Reviewed by Adam Roben.
1249
1250         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
1251         HTML syntax highlighting colors and DOM tree colors should be the same
1252
1253         * css/view-source.css:
1254         * page/inspector/ResourcePanel.js:
1255         * page/inspector/inspector.css:
1256         * page/inspector/inspector.js:
1257         * page/inspector/utilities.js:
1258
1259 2007-06-25  Adam Roben  <aroben@apple.com>
1260
1261         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
1262         http://bugs.webkit.org/show_bug.cgi?id=14402
1263
1264         The solution was to make KURL::lastPathComponent ignore trailing
1265         slashes, which is what -[NSURL lastPathComponent] does, too.
1266
1267         Reviewed by Oliver.
1268
1269         * platform/KURL.cpp:
1270         (WebCore::KURL::lastPathComponent):
1271
1272 2007-06-25  Sam Weinig  <sam@webkit.org>
1273
1274         Reviewed by Adam Roben.
1275
1276         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
1277         Web Inspector lists favicon.ico as "other" instead of "image"
1278
1279         * page/InspectorController.cpp:
1280         (WebCore::InspectorResource::type):
1281
1282 2007-06-25  Adele Peterson  <adele@apple.com>
1283
1284         Reviewed by Hyatt.
1285
1286         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
1287         http://bugs.webkit.org/show_bug.cgi?id=14297
1288
1289         Test: fast/overflow/hidden-scrollbar-resize.html
1290
1291         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
1292         Updated our shouldPaint check to consider visibility.
1293
1294 2007-06-25  Oliver Hunt  <oliver@apple.com>
1295
1296         Reviewed by Darin.
1297
1298         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
1299
1300         Fixing logic error in DragController
1301
1302         * manual-tests/drop-text-acquires-style.html: Added.
1303         * page/DragController.cpp:
1304         (WebCore::documentFragmentFromDragData):
1305
1306 2007-06-25  Sam Weinig  <sam@webkit.org>
1307
1308         Reviewed by Adam Roben.
1309
1310         Annotate prototypes by adding "Prototype" subtitle.
1311
1312         * page/inspector/ResourcePanel.js:
1313
1314 2007-06-25  George Staikos  <staikos@kde.org>
1315
1316         Reviewed by Zack.
1317
1318         Start to add proxy and SSL support to WebKitQt.  Proxying works.
1319
1320         * platform/network/ResourceHandleInternal.h:
1321         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1322         * platform/network/qt/ResourceHandleQt.cpp:
1323         (WebCore::ResourceHandle::start):
1324
1325 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1326
1327         Reviewed by Adam Roben.
1328
1329         http://bugs.webkit.org/show_bug.cgi?id=14386
1330         Gdk build fix
1331
1332         * WebCore.pro: Fix gtk/gdk typo.
1333
1334 2007-06-25  Timothy Hatcher  <timothy@apple.com>
1335
1336         Reviewed by Anders.
1337
1338         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
1339         http://bugs.webkit.org/show_bug.cgi?id=14385
1340
1341         Add a toggle to show implict computed properties.
1342
1343         * page/inspector/ResourcePanel.js:
1344         * page/inspector/inspector.css:
1345         * page/inspector/inspector.js:
1346
1347 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
1348
1349         Reviewed by Mark.
1350
1351         http://bugs.webkit.org/show_bug.cgi?id=13975
1352         Use system-provided libjpeg and libpng
1353
1354         * WebCore.pro: Remove bundled libjpeg and libpng sources.
1355         * platform/image-decoders/jpeg: Remove sources.
1356         * platform/image-decoders/png: Remove sources.
1357
1358 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1359
1360         Reviewed by Darin.
1361
1362         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
1363           Table caption renders too narrow sometimes
1364
1365         Test: fast/table/caption-relayout.html
1366
1367         * rendering/RenderTable.cpp:
1368         (WebCore::RenderTable::layout): Mark the caption for layout if the table
1369         width changed.
1370
1371 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1372
1373         Reviewed by Darin.
1374
1375         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
1376           Underline painted under <br>, not repainted properly
1377
1378         Test: fast/inline/br-text-decoration.html
1379
1380         * platform/graphics/cg/GraphicsContextCG.cpp:
1381         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
1382         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
1383         than their thickness paint correctly.
1384
1385 2007-06-25  Mitz Pettel  <mitz@webkit.org>
1386
1387         Reviewed by Maciej.
1388
1389         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
1390           rules="none" ignored in certain cases
1391
1392         Covered by existing tests.
1393
1394         * html/HTMLTableElement.cpp:
1395         (WebCore::HTMLTableElement::getSharedCellDecl):
1396
1397 2007-06-24  Sam Weinig  <sam@webkit.org>
1398
1399         Reviewed by Mitz.
1400
1401         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
1402         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
1403
1404         * page/inspector/ResourcePanel.js: make sure not to call an overriden
1405         toString() by using Object.prototype.toString.call().
1406
1407 2007-06-24  Adam Roben  <aroben@apple.com>
1408
1409         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
1410         Bug 14374: Computed Style section should be expanded by default
1411
1412         Reviewed by Sam.
1413
1414         No regression test possible.
1415
1416         * page/inspector/ResourcePanel.js: Expand all style sections.
1417
1418 2007-06-24  Adam Roben  <aroben@apple.com>
1419
1420         Unify the style of enums in the Inspector JS
1421
1422         All our enums are now represented by an object with a property for
1423         each enum value.
1424
1425         Reviewed by Sam.
1426
1427         No regression test possible.
1428
1429         * page/inspector/ConsolePanel.js:
1430         * page/inspector/Resource.js:
1431         * page/inspector/ResourcePanel.js:
1432         * page/inspector/inspector.js:
1433
1434 2007-06-23  Sam Weinig  <sam@webkit.org>
1435
1436         Reviewed by Mitz.
1437
1438         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
1439         getComputedStyle(...).zIndex returns string "normal"
1440
1441         Test: fast/css/getComputedStyle-zIndex-auto.html
1442
1443         * css/CSSComputedStyleDeclaration.cpp:
1444         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
1445
1446 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
1447
1448         Reviewed by Tim Hatcher.
1449
1450         Bug 14265: Cannot resize columns in webinspector
1451         http://bugs.webkit.org/show_bug.cgi?id=14265
1452
1453         * page/inspector/inspector.css:
1454         * page/inspector/inspector.html:
1455         * page/inspector/inspector.js:
1456
1457 2007-06-23  Adam Roben  <aroben@apple.com>
1458
1459         Silence a build warning about not finding `num-cpus`
1460
1461         Reviewed by Mark Rowe.
1462
1463         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
1464         location.
1465
1466 2007-06-22  Anders Carlsson  <andersca@apple.com>
1467
1468         Reviewed by Darin.
1469
1470         * plugins/win/PluginStreamWin.cpp:
1471         (WebCore::PluginStreamWin::didFinishLoading):
1472         No need to fetch the size from resourceData.
1473
1474 2007-06-22  Anders Carlsson  <andersca@apple.com>
1475
1476         Reviewed by Darin.
1477
1478         <rdar://problem/5288617>
1479         Crash playing a very large QuickTime movie inside Safari.
1480
1481         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
1482         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
1483         
1484         * plugins/win/PluginStreamWin.cpp:
1485         (WebCore::PluginStreamWin::PluginStreamWin):
1486         (WebCore::PluginStreamWin::~PluginStreamWin):
1487         (WebCore::PluginStreamWin::didReceiveData):
1488         (WebCore::PluginStreamWin::didFinishLoading):
1489         * plugins/win/PluginStreamWin.h:
1490
1491 2007-06-22  Beth Dakin  <bdakin@apple.com>
1492
1493         Reviewed by Oliver and Darin.
1494
1495         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
1496         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
1497
1498         We already have code that tries to prevent allocating too-large 
1499         rowspans. The rowspan in this test, however, was small enough that 
1500         we thought it was okay in that code, even though clearly it was 
1501         still too large. I did a bunch of testing in Firefox, and it seems 
1502         that they set a hard limit on the maximum rowspan right in the DOM 
1503         -- 8k. So that is what this patch implements. 
1504
1505         * html/HTMLTableCellElement.cpp:
1506         (WebCore::HTMLTableCellElement::parseMappedAttribute):
1507
1508 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
1509
1510         Reviewed by Darin.
1511         
1512         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
1513         
1514         Deletion inserts a placeholder after it removes full paragraphs if
1515         one doesn't already exist.  The code that looked for a pre-existing
1516         placeholder didn't work because of a bug in enclosingNodeOfType.
1517
1518         * editing/htmlediting.cpp:
1519         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
1520         but don't go above an editing root.
1521
1522 2007-06-22  Anders Carlsson  <andersca@apple.com>
1523
1524         Reviewed by Maciej and Geoff.
1525
1526         <rdar://problem/5244734>
1527         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
1528         
1529         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
1530         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
1531         argument to a bunch of classes).
1532         
1533         * loader/Cache.cpp:
1534         (WebCore::createResource):
1535         (WebCore::Cache::requestResource):
1536         * loader/Cache.h:
1537         * loader/CachedCSSStyleSheet.cpp:
1538         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1539         * loader/CachedCSSStyleSheet.h:
1540         * loader/CachedResource.cpp:
1541         (WebCore::CachedResource::CachedResource):
1542         * loader/CachedResource.h:
1543         (WebCore::CachedResource::sendResourceLoadCallbacks):
1544         * loader/DocLoader.cpp:
1545         (WebCore::DocLoader::requestCSSStyleSheet):
1546         (WebCore::DocLoader::requestResource):
1547         (WebCore::DocLoader::checkCacheObjectStatus):
1548         * loader/DocLoader.h:
1549         * loader/MainResourceLoader.cpp:
1550         (WebCore::MainResourceLoader::MainResourceLoader):
1551         * loader/Request.cpp:
1552         (WebCore::Request::Request):
1553         * loader/Request.h:
1554         (WebCore::Request::sendResourceLoadCallbacks):
1555         * loader/ResourceLoader.cpp:
1556         (WebCore::ResourceLoader::ResourceLoader):
1557         (WebCore::ResourceLoader::willSendRequest):
1558         (WebCore::ResourceLoader::didReceiveResponse):
1559         (WebCore::ResourceLoader::didReceiveData):
1560         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1561         (WebCore::ResourceLoader::didFail):
1562         (WebCore::ResourceLoader::didCancel):
1563         * loader/ResourceLoader.h:
1564         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
1565         * loader/SubresourceLoader.cpp:
1566         (WebCore::SubresourceLoader::SubresourceLoader):
1567         (WebCore::SubresourceLoader::create):
1568         * loader/SubresourceLoader.h:
1569         * loader/loader.cpp:
1570         (WebCore::Loader::load):
1571         (WebCore::Loader::servePendingRequests):
1572         * loader/loader.h:
1573         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1574         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1575
1576 2007-06-21  Richard Connamacher  <rich@indieimage.com>
1577
1578         Reviewed by Tim Hatcher.
1579
1580         Bug 14305: Web Inspector marks local files with server-side compression tip
1581         http://bugs.webkit.org/show_bug.cgi?id=14305
1582
1583         * page/inspector/Resource.js:
1584         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
1585         from being given to local files
1586
1587 2007-06-21  Mark Rowe  <mrowe@apple.com>
1588
1589         Reviewed by Darin.
1590
1591         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
1592
1593         * platform/StringImpl.cpp:
1594         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
1595         a length of zero when the string is collapsed to empty by whitespace simplification.
1596
1597 2007-06-21  Dave Hyatt  <hyatt@apple.com>
1598
1599         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
1600         
1601         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
1602         start failing to do anything useful if the font size is too big.
1603         
1604         Reviewed by olliej
1605
1606         * css/cssstyleselector.cpp:
1607         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
1608         
1609 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1610
1611         Reviewed by Timothy.
1612
1613         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
1614
1615         * page/inspector/inspector.css: Set body margin to 0
1616
1617 2007-06-21  Adam Treat  <adam@staikos.net>
1618
1619         Reviewed by George Staikos.
1620
1621         Implement the default resources on Qt.
1622
1623         * platform/graphics/BitmapImage.h:
1624         * platform/graphics/Image.h:
1625         * platform/graphics/qt/ImageQt.cpp:
1626         (WebCore::Image::loadPlatformResource):
1627         (WebCore::BitmapImage::BitmapImage):
1628         (WebCore::BitmapImage::initPlatformData):
1629         (WebCore::BitmapImage::invalidatePlatformData):
1630         (WebCore::BitmapImage::getPixmap):
1631         * platform/qt/TemporaryLinkStubs.cpp:
1632
1633 2007-06-21  Oliver Hunt  <oliver@apple.com>
1634
1635         Reviewed by Darin.
1636
1637         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
1638         and makes reference handling simpler in advance of IME refactoring.
1639
1640         * WebCore.xcodeproj/project.pbxproj:
1641         * page/mac/EventHandlerMac.mm:
1642         (WebCore::currentEvent):
1643         (WebCore::EventHandler::currentNSEvent):
1644         (WebCore::EventHandler::wheelEvent):
1645         (WebCore::EventHandler::keyEvent):
1646         (WebCore::lastEventIsMouseUp):
1647         (WebCore::EventHandler::passMouseDownEventToWidget):
1648         (WebCore::EventHandler::eventLoopHandleMouseDragged):
1649         (WebCore::EventHandler::eventLoopHandleMouseUp):
1650         (WebCore::EventHandler::passSubframeEventToSubframe):
1651         (WebCore::EventHandler::passWheelEventToWidget):
1652         (WebCore::EventHandler::mouseDown):
1653         (WebCore::EventHandler::mouseDragged):
1654         (WebCore::EventHandler::mouseUp):
1655         (WebCore::EventHandler::mouseMoved):
1656
1657 2007-06-21  George Staikos  <staikos@kde.org>
1658
1659         Reviewed by George & Marius.
1660
1661         Patch by me, revision by Marius, minor rev by me.  Adds rendered
1662         and stylable scrollbars.
1663
1664         * page/qt/EventHandlerQt.cpp:
1665         (WebCore::EventHandler::passMousePressEventToScrollbar):
1666         * platform/Widget.h:
1667         * platform/qt/PlatformScrollBar.h:
1668         (WebCore::PlatformScrollbar::isWidget):
1669         * platform/qt/PlatformScrollBarQt.cpp:
1670         (WebCore::PlatformScrollbar::PlatformScrollbar):
1671         (WebCore::PlatformScrollbar::~PlatformScrollbar):
1672         (WebCore::PlatformScrollbar::updateThumbPosition):
1673         (WebCore::PlatformScrollbar::updateThumbProportion):
1674         (WebCore::PlatformScrollbar::width):
1675         (WebCore::PlatformScrollbar::height):
1676         (WebCore::PlatformScrollbar::setRect):
1677         (WebCore::PlatformScrollbar::isEnabled):
1678         (WebCore::PlatformScrollbar::setEnabled):
1679         (WebCore::PlatformScrollbar::paint):
1680         (WebCore::PlatformScrollbar::thumbPosition):
1681         (WebCore::PlatformScrollbar::thumbLength):
1682         (WebCore::PlatformScrollbar::trackLength):
1683         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
1684         (WebCore::PlatformScrollbar::handleMouseOutEvent):
1685         (WebCore::PlatformScrollbar::handleMousePressEvent):
1686         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
1687         (WebCore::PlatformScrollbar::startTimerIfNeeded):
1688         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
1689         (WebCore::PlatformScrollbar::autoscrollPressedPart):
1690         (WebCore::PlatformScrollbar::autoscrollTimerFired):
1691         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
1692         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
1693         (WebCore::PlatformScrollbar::thumbUnderMouse):
1694         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1695         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1696         (WebCore::PlatformScrollbar::windowClipRect):
1697         * platform/qt/ScrollViewQt.cpp:
1698         (WebCore::ScrollView::addChild):
1699         (WebCore::ScrollView::removeChild):
1700         * platform/qt/WidgetQt.cpp:
1701         (WebCore::WidgetPrivate::WidgetPrivate):
1702         (WebCore::Widget::setQWidget):
1703         (WebCore::Widget::invalidate):
1704         (WebCore::Widget::invalidateRect):
1705         (WebCore::Widget::setParent):
1706         (WebCore::Widget::parent):
1707
1708 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
1709
1710         Reviewed by Dave Hyatt.
1711         
1712         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
1713         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
1714         effects when clicking on its links (12646)
1715         
1716         I'm rolling our r7703 for these reasons:
1717
1718         1. It broke RapidWeaver.
1719         
1720         2. WebKit is now orders of magnitude faster when handling deep nesting
1721         (5 seconds vs 3 minutes on my MBP in this particular case).
1722
1723         3. Firefox, IE, and HTML5 all allow nested heading tags.
1724         
1725         4. Hyatt said so.
1726
1727         * html/HTMLParser.cpp:
1728         (WebCore::HTMLParser::parseToken):
1729
1730 2007-06-21  Sam Weinig  <sam@webkit.org>
1731
1732         Reviewed by Tim Hatcher.
1733
1734         http://bugs.webkit.org/show_bug.cgi?id=14260
1735         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
1736
1737         Remove assert for now as it is causing the back button to not
1738         work in debug builds.
1739
1740         * page/InspectorController.cpp:
1741         (WebCore::InspectorController::didCommitLoad):
1742
1743 2007-06-21  Lars Knoll <lars@trolltech.com>
1744
1745         Remove some debug output.
1746
1747         * platform/qt/FontQt.cpp:
1748         (WebCore::generateComponents):
1749         (WebCore::Font::width):
1750
1751 2007-06-21  George Staikos  <staikos@kde.org>
1752
1753         Repair Qt/Mac OS X build.
1754
1755         * WebCore.pro:
1756
1757 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
1758
1759         Reviewed by Anders.
1760
1761         http://bugs.webkit.org/show_bug.cgi?id=13905
1762         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
1763
1764         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
1765         (regardless of the actual response MIME type). This was corrected a while ago to match other 
1766         browsers and the draft XHR spec.
1767
1768         Now restoring this functionality for "text/html", with spec editor's blessing.
1769
1770         * xml/xmlhttprequest.cpp:
1771         (WebCore::XMLHttpRequest::responseMIMEType):
1772         (WebCore::XMLHttpRequest::responseIsXML):
1773         (WebCore::XMLHttpRequest::didReceiveData):
1774         * xml/xmlhttprequest.h:
1775
1776 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
1777
1778         Mac build fix.
1779
1780         * platform/Font.h:
1781
1782 2007-06-21  Lars Knoll  <lars@trolltech.com>
1783
1784         Reviewed by Simon.
1785
1786         another small fix for letter spacing
1787
1788         * platform/qt/FontQt.cpp:
1789         (WebCore::generateComponents):
1790
1791 2007-06-21  Lars Knoll  <lars@trolltech.com>
1792
1793         Reviewed by Simon.
1794
1795         fix word-spacing
1796
1797         * platform/qt/FontQt.cpp:
1798         (WebCore::generateComponents):
1799         (WebCore::Font::width):
1800
1801 2007-06-21  Lars Knoll  <lars@trolltech.com>
1802
1803         Reviewed by Simon.
1804
1805         fix letterspacing and small caps.
1806
1807         * platform/Font.h:
1808         * platform/graphics/qt/GraphicsContextQt.cpp:
1809         (WebCore::GraphicsContext::setPlatformFont):
1810         * platform/qt/FileChooserQt.cpp:
1811         * platform/qt/FontQt.cpp:
1812         (WebCore::TextRunComponent::TextRunComponent):
1813         (WebCore::Font::Font):
1814         (WebCore::Font::operator=):
1815         (WebCore::Font::update):
1816         (WebCore::generateComponents):
1817         (WebCore::Font::selectionRectForText):
1818         * platform/qt/RenderThemeQt.cpp:
1819
1820 2007-06-21  Lars Knoll  <lars@trolltech.com>
1821
1822         Reviewed by Simon.
1823
1824         store the metrics and space width in the Font object
1825
1826         * platform/Font.h:
1827         * platform/qt/FontQt.cpp:
1828         (WebCore::Font::Font):
1829         (WebCore::Font::drawText):
1830         (WebCore::Font::width):
1831         (WebCore::Font::isFixedPitch):
1832         (WebCore::Font::ascent):
1833         (WebCore::Font::descent):
1834         (WebCore::Font::lineSpacing):
1835
1836 2007-06-21  Lars Knoll  <lars@trolltech.com>
1837
1838         Reviewed by Simon.
1839
1840         simplify some codepaths
1841
1842         * platform/qt/FontQt.cpp:
1843         (WebCore::Font::drawText):
1844         (WebCore::Font::width):
1845
1846 2007-06-21  Lars Knoll  <lars@trolltech.com>
1847
1848         Reviewed by Simon.
1849
1850         fix copyright header
1851
1852         * platform/qt/FontQt.cpp:
1853
1854 2007-06-21  Lars Knoll  <lars@trolltech.com>
1855
1856         Reviewed by Simon.
1857
1858         correctly load fonts when a list of font families is given
1859
1860         * platform/qt/FontQt.cpp:
1861         (WebCore::Font::Font):
1862
1863 2007-06-21  Lars Knoll  <lars@trolltech.com>
1864
1865         Reviewed by Simon.
1866
1867         fix some more of the font support
1868
1869         * platform/qt/FontQt.cpp:
1870         (WebCore::Font::drawText):
1871         (WebCore::Font::width):
1872
1873 2007-06-21  Lars Knoll  <lars@trolltech.com>
1874
1875         Reviewed by Simon.
1876
1877         Compile fixes
1878
1879         * platform/Font.h:
1880         (WebCore::Font::isRoundingHackCharacter):
1881         * platform/qt/FontQt.cpp:
1882         (WebCore::Font::drawText):
1883
1884 2007-06-21  Lars Knoll  <lars@trolltech.com>
1885
1886         Reviewed by Simon.
1887
1888         Some more work on the implementation of FontQt.
1889
1890         * platform/qt/FontQt.cpp:
1891         (WebCore::Font::Font):
1892         (WebCore::Font::~Font):
1893         (WebCore::Font::operator=):
1894
1895 2007-06-21  Lars Knoll  <lars@trolltech.com>
1896
1897         Reviewed by Simon.
1898
1899         Started work on the new font infrastructure for the Qt port.
1900
1901         * WebCore.pro:
1902         * editing/Editor.cpp:
1903         (WebCore::Editor::fontForSelection):
1904         * platform/Font.h:
1905         (WebCore::Font::treatAsSpace):
1906         (WebCore::Font::treatAsZeroWidthSpace):
1907         (WebCore::Font::isRoundingHackCharacter):
1908         * platform/qt/FontQt.cpp:
1909         (WebCore::Font::operator QFont):
1910         * platform/qt/TemporaryLinkStubs.cpp:
1911
1912 2007-06-21  Adam Roben  <aroben@apple.com>
1913
1914         More Gdk build fixes.
1915
1916         * page/gdk/ContextMenuClientGdk.cpp:
1917         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
1918         * page/gdk/ContextMenuClientGdk.h:
1919         * platform/gdk/TemporaryLinkStubs.cpp:
1920
1921 2007-06-21  Adam Roben  <aroben@apple.com>
1922
1923         Speculative Gdk build fix.
1924
1925         * page/InspectorController.h: Only include the JS headers we really
1926         need to avoid pulling in ones like JSStringRefCF.h.
1927
1928 2007-06-20  Adam Roben  <aroben@apple.com>
1929
1930         Speculative Gdk build fix.
1931
1932         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
1933
1934 2007-06-20  Adam Roben  <aroben@apple.com>
1935
1936         Windows build fix.
1937
1938         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
1939         everything but $WebKitLibrariesDir so that we will pick up
1940         JavaScriptCore headers directly.
1941
1942 2007-06-15  George Staikos  <staikos@kde.org>
1943
1944         Add missing symbol.
1945
1946         * platform/qt/TemporaryLinkStubs.cpp:
1947         (WebCore::contextMenuItemTagInspectElement):
1948
1949 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
1950
1951         Reviewed by Maciej, Anders.
1952         
1953         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
1954
1955         Keep a reference to the Page (via the main frame) for the
1956         load deferred pages.
1957         
1958         Reference is held via the frame since Page isn't refcounted.
1959
1960         * page/Chrome.cpp:
1961         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1962         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1963
1964 2007-06-15  Adam Treat <adam@staikos.net>
1965
1966         Reviewed by George Staikos.
1967
1968         Add ICO support to the Qt build.
1969
1970         * WebCore.pro:
1971         * platform/graphics/qt/ImageDecoderQt.cpp:
1972         (Q_IMPORT_PLUGIN):
1973
1974 2007-06-15  George Staikos  <staikos@kde.org>
1975
1976         Fixing Qt build.
1977
1978         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
1979         * WebCore.pro:
1980         * page/InspectorController.h:
1981
1982 2007-06-20  Adam Roben  <aroben@apple.com>
1983
1984         More speculative Qt/Gdk build fixes.
1985
1986         * WebCore.pro: Add new files.
1987
1988 2007-06-20  Adam Roben  <aroben@apple.com>
1989
1990         Speculative Qt/Gdk build fix.
1991
1992         Added forwarding headers for JavaScriptCore. We may eventually move
1993         InspectorController off of the JSC API, but for now this is the
1994         quickest way to a working build.
1995
1996         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
1997         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
1998         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
1999         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
2000         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
2001         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
2002         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
2003
2004 2007-06-20  Sam Weinig  <sam@webkit.org>
2005
2006         Rubber stamped by Adam Roben.
2007
2008         Add licenses.
2009
2010         * page/inspector/ConsolePanel.js:
2011         * page/inspector/NetworkPanel.js:
2012         * page/inspector/Resource.js:
2013         * page/inspector/ResourceCategory.js:
2014         * page/inspector/ResourcePanel.js:
2015
2016 2007-06-20  Mark Rowe  <mrowe@apple.com>
2017
2018         Reviewed by Adam.
2019
2020         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
2021
2022 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
2023
2024         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
2025
2026         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
2027         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
2028         returning nil instead of "")
2029
2030         I'm basically rolling out the change for <rdar://problem/4782422> because
2031         my testing shows that it was backwards.
2032         
2033         * html/HTMLElement.cpp:
2034         (dumpInnerHTML): New debug-only function to work around gdb being 
2035         perpetually suck-tastic.
2036
2037         * page/mac/WebCoreFrameBridge.mm:
2038         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2039         
2040         Return "", not nil. This function never used to return nil, so let's not
2041         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
2042
2043 2007-06-20  Adam Roben  <aroben@apple.com>
2044
2045         Addressed some of Geoff's comments.
2046
2047         * page/ContextMenuController.cpp:
2048         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
2049         FIXME.
2050         * platform/ContextMenu.cpp:
2051         (WebCore::ContextMenu::addInspectElementItem): Null-check
2052         frame->page().
2053
2054 2007-06-20  Adam Roben  <aroben@apple.com>
2055
2056         Fix crash in fast/dom/dir-no-body.html
2057
2058         Reviewed by Mark.
2059
2060         * html/HTMLDocument.cpp:
2061         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
2062         Frame, since we won't if someone creates an HTMLDocument from JS.
2063
2064 2007-06-20  Adam Roben  <aroben@apple.com>
2065
2066         Land the new Inspector.
2067
2068         Co-written with Tim Hatcher.
2069
2070         Reviewed by Anders, Adele, Hyatt, and Sam.
2071
2072         No regression tests possible.
2073
2074         Add a new InspectorController that is in charge of the Inspector. It
2075         has an InspectorClient that controls the Inspector's window and node
2076         highlight.
2077
2078         * page/InspectorClient.h: Added.
2079         (WebCore::InspectorClient::~InspectorClient):
2080         * page/InspectorController.cpp: Added.
2081         (WebCore::ConsoleMessage::ConsoleMessage):
2082         (WebCore::InspectorResource::): Represents a single resource that the
2083         Inspector knows about.
2084         (WebCore::InspectorResource::InspectorResource):
2085         (WebCore::InspectorResource::~InspectorResource):
2086         (WebCore::InspectorResource::type):
2087         (WebCore::InspectorResource::setScriptObject):
2088         (WebCore::addSourceToFrame): Callback available from JS.
2089         (WebCore::getResourceDocumentNode): Ditto.
2090         (WebCore::highlightDOMNode): Ditto.
2091         (WebCore::hideDOMNodeHighlight): Ditto.
2092         (WebCore::loaded): Ditto.
2093         (WebCore::unloading): Ditto.
2094         (WebCore::attach): Ditto.
2095         (WebCore::detach): Ditto.
2096         (WebCore::log): Ditto.
2097         (WebCore::search): Ditto.
2098         (WebCore::inspectedWindow): Ditto.
2099         (WebCore::InspectorController::InspectorController):
2100         (WebCore::InspectorController::~InspectorController):
2101         (WebCore::InspectorController::inspect): Called by
2102         ContextMenuController to inspect a node.
2103         (WebCore::InspectorController::focusNode):
2104         (WebCore::InspectorController::highlight):
2105         (WebCore::InspectorController::hideHighlight):
2106         (WebCore::InspectorController::windowVisible):
2107         (WebCore::InspectorController::setWindowVisible):
2108         (WebCore::InspectorController::addMessageToConsole):
2109         (WebCore::InspectorController::attachWindow):
2110         (WebCore::InspectorController::detachWindow):
2111         (WebCore::InspectorController::windowScriptObjectAvailable):
2112         (WebCore::InspectorController::scriptObjectReady):
2113         (WebCore::InspectorController::windowUnloading):
2114         (WebCore::addHeaders): Static helper function.
2115         (WebCore::objectForRequest): Ditto.
2116         (WebCore::objectForResponse): Ditto.
2117         (WebCore::InspectorController::addScriptResource):
2118         (WebCore::InspectorController::addAndUpdateScriptResource):
2119         (WebCore::InspectorController::removeScriptResource):
2120         (WebCore::InspectorController::updateScriptResource):
2121         (WebCore::InspectorController::populateScriptResources):
2122         (WebCore::InspectorController::addScriptConsoleMessage):
2123         (WebCore::callClearFunction): Static helper function.
2124         (WebCore::InspectorController::clearScriptResources):
2125         (WebCore::InspectorController::clearScriptConsoleMessages):
2126         (WebCore::InspectorController::clearNetworkTimeline):
2127         (WebCore::InspectorController::pruneResources):
2128         (WebCore::InspectorController::didCommitLoad): Callback from
2129         FrameLoader.
2130         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
2131         (WebCore::InspectorController::addResource): Ditto.
2132         (WebCore::InspectorController::removeResource): Ditto.
2133         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
2134         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
2135         (WebCore::InspectorController::willSendRequest): Ditto.
2136         (WebCore::InspectorController::didReceiveResponse): Ditto.
2137         (WebCore::InspectorController::didReceiveContentLength): Ditto.
2138         (WebCore::InspectorController::didFinishLoading): Ditto.
2139         (WebCore::InspectorController::didFailLoading): Ditto.
2140         * page/InspectorController.h: Added.
2141         (WebCore::InspectorController::inspectedPage):
2142         (WebCore::InspectorController::scriptContext):
2143         (WebCore::InspectorController::setScriptContext):
2144         (WebCore::InspectorController::resources):
2145         (WebCore::InspectorController::removeAllResources):
2146
2147         Add the JavaScript that defines most of the behavior of the Inspector.
2148         
2149         * page/inspector/ConsolePanel.js: Added.
2150         * page/inspector/NetworkPanel.js: Added.
2151         * page/inspector/Resource.js: Added.
2152         * page/inspector/ResourceCategory.js: Added.
2153         * page/inspector/ResourcePanel.js: Added.
2154         * page/inspector/inspector.js: Added.
2155         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
2156         * page/inspector/utilities.js: Added.
2157
2158         Add the Inspector's CSS and HTML.
2159
2160         * page/inspector/inspector.css: Added.
2161         * page/inspector/inspector.html: Added.
2162
2163         Hang the InspectorController off of Page. We only create an
2164         InspectorController if an InspectorClient is given to the Page.
2165
2166         * page/Page.cpp:
2167         (WebCore::Page::Page):
2168         * page/Page.h:
2169         (WebCore::Page::inspectorController):
2170
2171         Use FrameLoader to notify the InspectorController of resource loads.
2172
2173         * loader/FrameLoader.cpp:
2174         (WebCore::FrameLoader::begin):
2175         (WebCore::FrameLoader::transitionToCommitted):
2176         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
2177         (WebCore::FrameLoader::detachFromParent):
2178         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
2179         (WebCore::FrameLoader::willSendRequest):
2180         (WebCore::FrameLoader::didReceiveResponse):
2181         (WebCore::FrameLoader::didReceiveData):
2182         (WebCore::FrameLoader::sendRemainingDelegateMessages):
2183         (WebCore::FrameLoader::requestFromDelegate):
2184         (WebCore::FrameLoader::didFinishLoad):
2185         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
2186         (WebCore::FrameLoader::dispatchDidCommitLoad):
2187         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
2188         (WebCore::FrameLoader::dispatchWillSendRequest):
2189         (WebCore::FrameLoader::dispatchDidReceiveResponse):
2190         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
2191         (WebCore::FrameLoader::dispatchDidFinishLoading):
2192         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
2193         * loader/FrameLoader.h:
2194
2195         Send console messages to the InspectorController.
2196
2197         * page/Chrome.cpp:
2198         (WebCore::Chrome::addMessageToConsole): Send all console messages to
2199         the InspectorController.
2200         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
2201         used in the Inspector JS.
2202
2203         Report HTML errors when the Inspector window is open.
2204         We don't report errors when the window is closed because we don't want
2205         to slow down the HTMLTokenizer.
2206
2207         * html/HTMLDocument.cpp:
2208         (WebCore::HTMLDocument::createTokenizer):
2209         * html/HTMLParser.cpp:
2210         (WebCore::HTMLParser::HTMLParser):
2211         * html/HTMLParser.h:
2212         * html/HTMLTokenizer.cpp:
2213         (WebCore::HTMLTokenizer::HTMLTokenizer):
2214         * html/HTMLTokenizer.h:
2215
2216         Append the "Inspect Element" context menu item after passing the
2217         context menu to the ContextMenuClient. This work used to be done in
2218         WebKit.
2219
2220         * page/ContextMenuClient.h:
2221         * page/ContextMenuController.cpp:
2222         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
2223         "Inspect Element" item.
2224         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
2225         "Inspect Element" item.
2226         * platform/ContextMenu.cpp:
2227         (WebCore::ContextMenu::addInspectElementItem):
2228         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
2229         Element" item.
2230         * platform/ContextMenu.h:
2231         * platform/ContextMenuItem.h:
2232         (WebCore::): Add ContextMenuItemTagInspectElement.
2233         * platform/graphics/svg/SVGImageEmptyClients.h:
2234         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
2235         string.
2236         * platform/LocalizedStrings.h: Ditto.
2237         * platform/mac/LocalizedStringsMac.mm:
2238         (WebCore::contextMenuItemTagInspectElement): Ditto.
2239
2240         Miscellaneous changes:
2241
2242         * css/view-source.css: Add message bubble styles.
2243         * loader/DocumentLoader.h: Add a frame getter.
2244         * platform/win/ScrollViewWin.cpp:
2245         (WebCore::ScrollView::updateScrollbars): Respect
2246         Frame::prohibitsScrolling.
2247
2248         Add new images needed for the Inspector.
2249
2250         * page/inspector/Images/attachedShadow.png: Added.
2251         * page/inspector/Images/bottomShadow.png: Added.
2252         * page/inspector/Images/breadcrumbBackground.png: Added.
2253         * page/inspector/Images/checker.png: Added.
2254         * page/inspector/Images/console.png: Added.
2255         * page/inspector/Images/darkShadow.png: Added.
2256         * page/inspector/Images/disclosureDownPressed.png: Added.
2257         * page/inspector/Images/disclosureRightDown.png: Added.
2258         * page/inspector/Images/disclosureRightPressed.png: Added.
2259         * page/inspector/Images/document.png: Added.
2260         * page/inspector/Images/domViewButton.png: Added.
2261         * page/inspector/Images/domViewButtonSelected.png: Added.
2262         * page/inspector/Images/downTriangle.png: Added.
2263         * page/inspector/Images/errorIcon.png: Added.
2264         * page/inspector/Images/errorMediumIcon.png: Added.
2265         * page/inspector/Images/folder.png: Added.
2266         * page/inspector/Images/goArrow.png: Added.
2267         * page/inspector/Images/gradient.png: Added.
2268         * page/inspector/Images/gradientHighlight.png: Added.
2269         * page/inspector/Images/gradientHighlightBottom.png: Added.
2270         * page/inspector/Images/hideStatusWidget.png: Added.
2271         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
2272         * page/inspector/Images/network.png: Added.
2273         * page/inspector/Images/paneBottomGrow.png: Added.
2274         * page/inspector/Images/paneBottomGrowActive.png: Added.
2275         * page/inspector/Images/paneGrowHandleLine.png: Added.
2276         * page/inspector/Images/paneHeader.png: Added.
2277         * page/inspector/Images/paneHeaderActive.png: Added.
2278         * page/inspector/Images/plainDocument.png: Added.
2279         * page/inspector/Images/popupArrows.png: Added.
2280         * page/inspector/Images/rightTriangle.png: Added.
2281         * page/inspector/Images/segment.png: Added.
2282         * page/inspector/Images/segmentEnd.png: Added.
2283         * page/inspector/Images/segmentHover.png: Added.
2284         * page/inspector/Images/segmentHoverEnd.png: Added.
2285         * page/inspector/Images/segmentSelected.png: Added.
2286         * page/inspector/Images/segmentSelectedEnd.png: Added.
2287         * page/inspector/Images/showStatusWidget.png: Added.
2288         * page/inspector/Images/showStatusWidgetPressed.png: Added.
2289         * page/inspector/Images/sidbarItemBackground.png: Added.
2290         * page/inspector/Images/sidebarActionWidget.png: Added.
2291         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
2292         * page/inspector/Images/sidebarAttachWidget.png: Added.
2293         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
2294         * page/inspector/Images/sidebarDetachWidget.png: Added.
2295         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
2296         * page/inspector/Images/sidebarResizeWidget.png: Added.
2297         * page/inspector/Images/sidebarSelection.png: Added.
2298         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
2299         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
2300         * page/inspector/Images/sidebarSelectionGray.png: Added.
2301         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
2302         * page/inspector/Images/sidebarSelectionTall.png: Added.
2303         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
2304         * page/inspector/Images/sourceViewButton.png: Added.
2305         * page/inspector/Images/sourceViewButtonSelected.png: Added.
2306         * page/inspector/Images/splitviewDimple.png: Added.
2307         * page/inspector/Images/splitviewDividerBackground.png: Added.
2308         * page/inspector/Images/tab.png: Added.
2309         * page/inspector/Images/tabSelected.png: Added.
2310         * page/inspector/Images/timelinePillBlue.png: Added.
2311         * page/inspector/Images/timelinePillGray.png: Added.
2312         * page/inspector/Images/timelinePillGreen.png: Added.
2313         * page/inspector/Images/timelinePillOrange.png: Added.
2314         * page/inspector/Images/timelinePillPurple.png: Added.
2315         * page/inspector/Images/timelinePillRed.png: Added.
2316         * page/inspector/Images/timelinePillYellow.png: Added.
2317         * page/inspector/Images/tipBalloon.png: Added.
2318         * page/inspector/Images/tipBalloonBottom.png: Added.
2319         * page/inspector/Images/tipIcon.png: Added.
2320         * page/inspector/Images/tipIconPressed.png: Added.
2321         * page/inspector/Images/toggleDown.png: Added.
2322         * page/inspector/Images/toggleUp.png: Added.
2323         * page/inspector/Images/toolbarBackground.png: Added.
2324         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
2325         * page/inspector/Images/toolbarButton.png: Added.
2326         * page/inspector/Images/toolbarButtonInactive.png: Added.
2327         * page/inspector/Images/toolbarButtonPressed.png: Added.
2328         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
2329         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
2330         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
2331         * page/inspector/Images/treeDownTriangleBlack.png: Added.
2332         * page/inspector/Images/treeDownTriangleWhite.png: Added.
2333         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
2334         * page/inspector/Images/treeRightTriangleBlack.png: Added.
2335         * page/inspector/Images/treeRightTriangleWhite.png: Added.
2336         * page/inspector/Images/warningIcon.png: Added.
2337         * page/inspector/Images/warningMediumIcon.png: Added.
2338         * page/inspector/Images/warningsErrors.png: Added.
2339
2340         Build-fu:
2341
2342         * WebCore.exp: Added new symbols.
2343         * WebCore.xcodeproj/project.pbxproj: Added new source files and
2344         resources.
2345         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
2346         $WebKitOutputDir.
2347
2348         Windows build fixes:
2349
2350         * history/HistoryItem.h: ResourceRequest is a struct.
2351         * loader/FrameLoaderClient.h: Ditto.
2352
2353 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2354
2355         Reviewed by Beth.
2356
2357         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
2358           REGRESSION (r21113-21143): TR background not repainted via style class change
2359
2360         Test: fast/repaint/table-row.html
2361
2362         * rendering/RenderTableRow.cpp:
2363         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
2364         table row also needs layout, so it doesn't get a repaint in setStyle().
2365
2366 2007-06-20  Mitz Pettel  <mitz@webkit.org>
2367
2368         Reviewed by Adele.
2369
2370         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
2371           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
2372
2373         Test: fast/borders/border-image-01.html
2374
2375         Correctly account for the fact that "pattern space" is flipped.
2376
2377         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
2378         * platform/graphics/cg/ImageCG.cpp:
2379         (WebCore::Image::drawPatternCallback):
2380         (WebCore::Image::drawPattern):
2381
2382 2007-06-20  Anders Carlsson  <andersca@apple.com>
2383
2384         Reviewed by Darin.
2385
2386         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
2387         
2388         Check for either '\r' or '\n' in the header value.
2389         
2390         * xml/xmlhttprequest.cpp:
2391         (WebCore::isValidHeaderValue):
2392
2393 2007-06-20  Patti Hoa  <patti@apple.com>
2394
2395         Reviewed by Geoffrey Garen.
2396
2397         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2398         Add additional change from review
2399         
2400         * bridge/mac/WebCoreAXObject.mm:
2401         (-[WebCoreAXObject accessibilityAttributeValue:]):
2402         Check if the element has imgTag before asking for its url
2403         
2404 2007-06-20  Patti Hoa  <patti@apple.com>
2405
2406         Reviewed by Tristan O'Tierney.
2407
2408         <rdar://problem/4882527> VO should speak URL of image links that lack tags
2409         
2410         * bridge/mac/WebCoreAXObject.mm:
2411         (-[WebCoreAXObject accessibilityAttributeNames]):
2412         (-[WebCoreAXObject accessibilityAttributeValue:]):
2413         Return the url of images.
2414
2415 2007-06-19  Anders Carlsson  <andersca@apple.com>
2416
2417         Reviewed by Kevin Decker.
2418
2419         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
2420         
2421         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
2422         
2423         * loader/DocumentLoader.cpp:
2424         (WebCore::DocumentLoader::DocumentLoader):
2425         * loader/DocumentLoader.h:
2426         (WebCore::DocumentLoader::deferMainResourceDataLoad):
2427         * loader/MainResourceLoader.cpp:
2428         (WebCore::MainResourceLoader::handleDataLoadSoon):
2429         (WebCore::MainResourceLoader::loadNow):
2430         (WebCore::MainResourceLoader::setDefersLoading):
2431
2432 2007-06-19  Patti Hoa <patti@apple.com>
2433
2434         Reviewed by Justin Garcia.
2435         
2436         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
2437         
2438         * editing/visible_units.cpp:
2439         (WebCore::startPositionForLine):
2440         (WebCore::startOfLine):
2441         (WebCore::endPositionForLine):
2442         (WebCore::endOfLine):
2443         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
2444         An example would be when lineStart/lineEnd at different line than the input position.
2445         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
2446         specifically a line without webkit-line-break:after-white-space style.
2447
2448 2007-06-19  Patti Hoa  <patti@apple.com>
2449
2450         Reviewed by Justin Garcia.
2451         
2452         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
2453         
2454         * bridge/mac/WebCoreAXObject.mm:
2455         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
2456         Improve the accuracy of the bounds for a given range
2457         
2458 2007-06-19  Anders Carlsson  <andersca@apple.com>
2459
2460         Reviewed by Darin.
2461
2462         <rdar://problem/5130630>
2463         XPath fails LayoutTests on Windows
2464         
2465         * xml/XPathPredicate.cpp:
2466         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
2467         
2468         * xml/XPathValue.cpp:
2469         (WebCore::XPath::Value::toNumber):
2470         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
2471         
2472 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
2473
2474         Reviewed by Darin Adler.
2475
2476         Fixed cross-frame access. <rdar://problem/5251309>. 
2477
2478         * bindings/js/kjs_window.cpp:
2479         (KJS::Window::getValueProperty):
2480         * bindings/scripts/CodeGeneratorJS.pm:
2481         * page/DOMWindow.idl:
2482
2483 2007-06-19  Anders Carlsson  <andersca@apple.com>
2484
2485         Build fix.
2486         
2487         * platform/win/PopupMenuWin.cpp:
2488
2489 2007-06-19  Lars Knoll <lars@trolltech.com>
2490
2491         Reviewed by Zack
2492
2493         Implement these methods correctly.
2494
2495         * platform/qt/PlatformScreenQt.cpp:
2496         (WebCore::screenRect):
2497         (WebCore::screenAvailableRect):
2498
2499 2007-06-19  Sam Weinig  <sam@webkit.org>
2500
2501         Reviewed by Geoff.
2502
2503         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
2504         Move the History object out of the JS bindings
2505
2506         - Autogenerate JSHistory.
2507
2508         * DerivedSources.make:
2509         * WebCore.pro:
2510         * WebCore.vcproj/WebCore.vcproj:
2511         * WebCore.xcodeproj/project.pbxproj:
2512         * bindings/js/kjs_window.cpp:
2513         (KJS::WindowPrivate::WindowPrivate):
2514         (KJS::Window::mark):
2515         (KJS::Window::getValueProperty):
2516         (KJS::Window::clearHelperObjectProperties):
2517         (KJS::Window::disconnectFrame):
2518         * bindings/js/kjs_window.h:
2519         (KJS::Window::):
2520         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
2521         * bridge/History.h: Removed.
2522         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
2523         * bridge/mac/HistoryMac.mm: Removed.
2524         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
2525         * bridge/win/HistoryWin.cpp: Removed.
2526         * css/cssstyleselector.cpp:
2527         * page/DOMWindow.cpp:
2528         (WebCore::DOMWindow::disconnectFrame):
2529         (WebCore::DOMWindow::history):
2530         * page/DOMWindow.h:
2531         * page/DOMWindow.idl:
2532         * page/History.cpp: Added.
2533         (WebCore::History::History):
2534         (WebCore::History::frame):
2535         (WebCore::History::disconnectFrame):
2536         (WebCore::History::length):
2537         (WebCore::History::back):
2538         (WebCore::History::forward):
2539         (WebCore::History::go):
2540         * page/History.h: Added.
2541         * page/History.idl: Added.
2542         * platform/gdk/TemporaryLinkStubs.cpp:
2543         * platform/qt/TemporaryLinkStubs.cpp:
2544         * platform/wx/TemporaryLinkStubs.cpp:
2545
2546 2007-06-18  Sam Weinig  <sam@webkit.org>
2547
2548         Qt build fix.
2549
2550         * platform/qt/PlatformScreenQt.cpp:
2551         (WebCore::screenDepth):
2552         (WebCore::screenDepthPerComponent):
2553         (WebCore::screenIsMonochrome):
2554         (WebCore::screenRect):
2555         (WebCore::screenAvailableRect):
2556
2557 2007-06-18  Sam Weinig  <sam@webkit.org>
2558
2559         Reviewed by Beth.
2560
2561         Fix build and update licenses. 
2562
2563         * WebCore.xcodeproj/project.pbxproj:
2564         * page/BarInfo.cpp:
2565         * page/BarInfo.h:
2566         * page/BarInfo.idl:
2567         * page/Screen.cpp:
2568         (WebCore::Screen::height):
2569         (WebCore::Screen::width):
2570         (WebCore::Screen::colorDepth):
2571         (WebCore::Screen::pixelDepth):
2572         (WebCore::Screen::availLeft):
2573         (WebCore::Screen::availTop):
2574         (WebCore::Screen::availHeight):
2575         (WebCore::Screen::availWidth):
2576         * page/Screen.h:
2577         * page/Screen.idl:
2578
2579 2007-06-18  Anders Carlsson  <andersca@apple.com>
2580
2581         Reviewed by John Sullivan.
2582
2583         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
2584         
2585         Don't send any frame load callbacks if the document load hasn't been
2586         committed for real.
2587         
2588         * loader/FrameLoader.cpp:
2589         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2590
2591 2007-06-18  Sam Weinig  <sam@webkit.org>
2592
2593         Reviewed by Geoff.
2594
2595         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
2596         Move the Screen object out of the JS bindings
2597
2598         - Renames Screen.h to PlatformScreen.h to accommodate new class.
2599         - Autogenerates JSScreen.
2600
2601         * DerivedSources.make:
2602         * WebCore.pro:
2603         * WebCore.vcproj/WebCore.vcproj:
2604         * WebCore.xcodeproj/project.pbxproj:
2605         * bindings/js/kjs_window.cpp:
2606         (KJS::WindowPrivate::WindowPrivate):
2607         (KJS::Window::mark):
2608         (KJS::Window::getValueProperty):
2609         (KJS::Window::clearHelperObjectProperties):
2610         * bindings/js/kjs_window.h:
2611         (KJS::Window::):
2612         * css/MediaQueryEvaluator.cpp:
2613         * page/DOMWindow.cpp:
2614         (WebCore::DOMWindow::DOMWindow):
2615         (WebCore::DOMWindow::~DOMWindow):
2616         (WebCore::DOMWindow::frame):
2617         (WebCore::DOMWindow::disconnectFrame):
2618         (WebCore::DOMWindow::screen):
2619         * page/DOMWindow.h:
2620         * page/DOMWindow.idl:
2621         * page/Screen.cpp: Added.
2622         (WebCore::Screen::Screen):
2623         (WebCore::Screen::disconnectFrame):
2624         (WebCore::Screen::height):
2625         (WebCore::Screen::width):
2626         (WebCore::Screen::colorDepth):
2627         (WebCore::Screen::pixelDepth):
2628         (WebCore::Screen::availLeft):
2629         (WebCore::Screen::availTop):
2630         (WebCore::Screen::availHeight):
2631         (WebCore::Screen::availWidth):
2632         * page/Screen.h: Added.
2633         * page/Screen.idl: Added.
2634         * page/mac/WebCoreFrameBridge.mm:
2635         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
2636         * platform/Screen.h: Removed.
2637         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
2638         * platform/gdk/ScreenGdk.cpp: Removed.
2639         * platform/mac/PlatformMouseEventMac.mm:
2640         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
2641         * platform/mac/ScreenMac.mm: Removed.
2642         * platform/qt/PlatformScreenQt.cpp: Added.
2643         (WebCore::WebCore::screenDepth):
2644         (WebCore::WebCore::screenDepthPerComponent):
2645         (WebCore::WebCore::screenIsMonochrome):
2646         (WebCore::WebCore::screenRect):
2647         (WebCore::WebCore::screenAvailableRect):
2648         * platform/qt/TemporaryLinkStubs.cpp:
2649         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
2650         * platform/win/ScreenWin.cpp: Removed.
2651         * rendering/RenderObject.cpp:
2652
2653 2007-06-18  Sam Weinig  <sam@webkit.org>
2654
2655         Reviewed by Geoff.
2656
2657         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
2658         Move the BarInfo object out of the JS bindings
2659
2660         * DerivedSources.make:
2661         * WebCore.pro:
2662         * WebCore.vcproj/WebCore.vcproj:
2663         * WebCore.xcodeproj/project.pbxproj:
2664         * bindings/js/kjs_window.cpp:
2665         (KJS::WindowPrivate::WindowPrivate):
2666         (KJS::Window::mark):
2667         (KJS::Window::getValueProperty):
2668         (KJS::Window::clearHelperObjectProperties):
2669         (KJS::Window::disconnectFrame):
2670         * bindings/js/kjs_window.h:
2671         (KJS::Window::):
2672         * page/BarInfo.cpp: Added.
2673         (WebCore::BarInfo::BarInfo):
2674         (WebCore::BarInfo::disconnectFrame):
2675         (WebCore::BarInfo::visible):
2676         * page/BarInfo.h: Added.
2677         (WebCore::BarInfo::):
2678         * page/BarInfo.idl: Added.
2679         * page/DOMWindow.cpp:
2680         (WebCore::DOMWindow::~DOMWindow):
2681         (WebCore::DOMWindow::disconnectFrame):
2682         (WebCore::DOMWindow::locationbar):
2683         (WebCore::DOMWindow::menubar):
2684         (WebCore::DOMWindow::personalbar):
2685         (WebCore::DOMWindow::scrollbars):
2686         (WebCore::DOMWindow::statusbar):
2687         (WebCore::DOMWindow::toolbar):
2688         * page/DOMWindow.h:
2689         * page/DOMWindow.idl:
2690
2691 2007-06-18  Sam Weinig  <sam@webkit.org>
2692
2693         Reviewed by Darin.
2694
2695         Remove the FrameArray class and instead make window.frames another
2696         self-reference for window (like window.window, window.self, etc).
2697         This is what Firefox and what the HTML5 dictates.
2698
2699         * bindings/js/kjs_window.cpp:
2700         (KJS::WindowPrivate::WindowPrivate):
2701         (KJS::Window::mark):
2702         (KJS::Window::getValueProperty):
2703         (KJS::Window::clearHelperObjectProperties):
2704         (KJS::Window::disconnectFrame):
2705         * bindings/js/kjs_window.h:
2706
2707 2007-06-18  Mitz Pettel  <mitz@webkit.org>
2708
2709         Reviewed by Adele.
2710
2711         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
2712           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
2713
2714         Test: fast/forms/input-zero-height-focus.html
2715
2716         * rendering/RenderTextControl.cpp:
2717         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
2718         selection in a zero-height text control.
2719
2720 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
2721
2722         Reviewed by Sam Weinig.
2723
2724         http://bugs.webkit.org/show_bug.cgi?id=14052
2725         Implement SoundGdk
2726
2727         * WebCore.pro:
2728         * platform/gdk/SoundGdk.cpp: Added.
2729         (WebCore::systemBeep):
2730         * platform/gdk/TemporaryLinkStubs.cpp:
2731         (WebCore::systemBeep):
2732
2733 2007-06-18  Dave Hyatt  <hyatt@apple.com>
2734
2735         Add support for horizontal mouse wheeling on Windows.
2736         
2737         Reviewed by aroben
2738
2739         * platform/PlatformWheelEvent.h:
2740         * platform/win/WheelEventWin.cpp:
2741         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2742
2743 2007-06-17  Sam Weinig  <sam@webkit.org>
2744
2745         Win32 build fix.
2746
2747         * WebCore.vcproj/WebCore.vcproj:
2748
2749 2007-06-15  David Hyatt  <hyatt@apple.com>
2750
2751         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
2752         because of a botched 'round' support removal.  Also update for a change in
2753         the spec that has the second stretch/round/repeat keyword match the first
2754         if omitted.
2755         
2756         Reviewed by olliej
2757
2758         * css/cssparser.cpp:
2759         (WebCore::BorderImageParseContext::commitBorderImage):
2760         * platform/graphics/Image.cpp:
2761         (WebCore::Image::drawTiled):
2762         * platform/graphics/Image.h:
2763         (WebCore::Image::):
2764
2765 2007-06-15  Sam Weinig  <sam@webkit.org>
2766
2767         Reviewed by Darin.
2768
2769         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
2770         Autogenerate JS binding for Rect
2771
2772         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
2773           and DOMRGBColor to JSRGBColor
2774         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
2775
2776         * DerivedSources.make:
2777         * WebCore.pro:
2778         * WebCore.xcodeproj/project.pbxproj:
2779         * bindings/js/kjs_css.cpp:
2780         (WebCore::):
2781         (WebCore::JSStyleSheetList::JSStyleSheetList):
2782         (WebCore::JSStyleSheetList::~JSStyleSheetList):
2783         (WebCore::JSStyleSheetList::getValueProperty):
2784         (WebCore::JSStyleSheetList::indexGetter):
2785         (WebCore::JSStyleSheetList::nameGetter):
2786         (WebCore::JSStyleSheetList::getOwnPropertySlot):
2787         (WebCore::toJS):
2788         (WebCore::JSStyleSheetListFunc::callAsFunction):
2789         (WebCore::JSRGBColor::JSRGBColor):
2790         (WebCore::JSRGBColor::~JSRGBColor):
2791         (WebCore::JSRGBColor::getOwnPropertySlot):
2792         (WebCore::JSRGBColor::getValueProperty):
2793         (WebCore::getJSRGBColor):
2794         * bindings/js/kjs_css.h:
2795         (WebCore::JSStyleSheetList::classInfo):
2796         (WebCore::JSStyleSheetList::):
2797         (WebCore::JSStyleSheetList::impl):
2798         (WebCore::JSRGBColor::classInfo):
2799         (WebCore::JSRGBColor::):
2800         (WebCore::JSRGBColor::impl):
2801         * bindings/objc/DOMUtility.mm:
2802         (KJS::createDOMWrapper):
2803         * bindings/scripts/CodeGeneratorJS.pm:
2804         * bindings/scripts/CodeGeneratorObjC.pm:
2805         * css/CSSBorderImageValue.cpp:
2806         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
2807         * css/CSSBorderImageValue.h:
2808         * css/CSSPrimitiveValue.cpp:
2809         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2810         (WebCore::CSSPrimitiveValue::cssText):
2811         * css/CSSPrimitiveValue.h:
2812         (WebCore::CSSPrimitiveValue::getRectValue):
2813         (WebCore::CSSPrimitiveValue::):
2814         * css/DashboardRegion.h:
2815         * css/Rect.h: Copied from css/RectImpl.h.
2816         (WebCore::Rect::~Rect):
2817         (WebCore::Rect::top):
2818         (WebCore::Rect::right):
2819         (WebCore::Rect::bottom):
2820         (WebCore::Rect::left):
2821         (WebCore::Rect::setTop):
2822         (WebCore::Rect::setRight):
2823         (WebCore::Rect::setBottom):
2824         (WebCore::Rect::setLeft):
2825         * css/Rect.idl:
2826         * css/RectImpl.h: Removed.
2827         * css/cssparser.cpp:
2828         (WebCore::CSSParser::parseShape):
2829         (WebCore::BorderImageParseContext::commitBorderImage):
2830         * css/cssstyleselector.cpp:
2831         (WebCore::CSSStyleSelector::applyProperty):
2832         * page/DOMWindow.idl:
2833
2834 2007-06-14  George Staikos  <staikos@kde.org>
2835
2836         Reviewed by Lars.
2837
2838         Implement missing tab support and a slight refactor.
2839
2840         * platform/qt/PlatformKeyboardEventQt.cpp:
2841         (WebCore::keyIdentifierForQtKeyCode):
2842         (WebCore::windowsKeyCodeForKeyEvent):
2843         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2844
2845 2007-06-14  Dave Hyatt  <hyatt@apple.com>
2846
2847         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
2848         
2849         This patch adds an additional step after the lookup by full name fails.  It will then look up
2850         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
2851         found, then the font's name table is obtained and searched for a PostScript name (and the
2852         result is cached).
2853         
2854         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
2855         list (so text should never be missing).
2856
2857         Reviewed by Darin (thoroughly reviewed, super reviewed even)
2858
2859         * platform/win/FontCacheWin.cpp:
2860         * platform/win/FontPlatformDataWin.cpp:
2861
2862 2007-06-14  Anders Carlsson  <andersca@apple.com>
2863
2864         Reviewed by Geoff.
2865
2866         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
2867         for a given plug-in.
2868
2869         * WebCore.exp:
2870         * page/Frame.cpp:
2871         (WebCore::Frame::cleanupScriptObjectsForPlugin):
2872         * page/Frame.h:
2873
2874 2007-06-14  Anders Carlsson  <andersca@apple.com>
2875
2876         Reviewed by Geoff.
2877
2878         <rdar://problem/5211677>
2879         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
2880         
2881         * loader/FrameLoader.cpp:
2882         (WebCore::FrameLoader::requestObject):
2883         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
2884         
2885         * platform/MimeTypeRegistry.cpp:
2886         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
2887         Clean this up and add another applet MIME type.
2888
2889 2007-06-14  George Staikos  <staikos@kde.org>
2890
2891         Reviewed by Lars.
2892
2893         Implement the file chooser for Qt.
2894
2895         * platform/qt/FileChooserQt.cpp:
2896         (WebCore::FileChooser::openFileChooser):
2897         (WebCore::FileChooser::basenameForWidth):
2898
2899 2007-06-14  George Staikos  <staikos@kde.org>
2900
2901         Reviewed by Lars.
2902
2903         Add missing initialization of pointer.
2904
2905         * platform/qt/ContextMenuQt.cpp:
2906         (WebCore::ContextMenu::ContextMenu):
2907
2908 2007-06-14  Anders Carlsson  <andersca@apple.com>
2909
2910         Reviewed by Mitz.
2911
2912         <rdar://problem/5244948>
2913         Safari keeps on complaining about slow script playing NBC TV video (14133)
2914
2915         http://bugs.webkit.org/show_bug.cgi?id=14133
2916         Runaway JavaScript timer fires when spinning around in Google Maps street view
2917
2918         Make sure to start and stop the timeout checker around calls to JS.
2919
2920         * bindings/objc/WebScriptObject.mm:
2921         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2922         (-[WebScriptObject evaluateWebScript:]):
2923
2924 2007-06-14  George Staikos  <staikos@kde.org>
2925
2926         Reviewed by Maciej.
2927
2928         Keypress causes typeahead crash on empty selects due to modulo 0.
2929
2930         * html/HTMLSelectElement.cpp:
2931         (WebCore::HTMLSelectElement::typeAheadFind):
2932
2933 2007-06-13  George Staikos  <staikos@kde.org>
2934
2935         Reviewed by Lars.
2936
2937         Compile without self-linking.
2938
2939         * WebCore.pro:
2940
2941 2007-06-13  Darin Adler  <darin@apple.com>
2942
2943         Reviewed by Kevin Decker.
2944
2945         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
2946           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
2947
2948         * platform/mac/WebFontCache.mm:
2949         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
2950         Took out the auto-activation code.
2951         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
2952         then calls NSFont to trigger activation if that returned nil, then calls
2953         internalFontWithFamily again.
2954
2955 2007-06-13  Anders Carlsson  <andersca@apple.com>
2956
2957         Reviewed by Geoff.
2958
2959         Pass the root object to methods that end up creating new ObjcInstance objects.
2960         
2961         * bindings/objc/WebScriptObject.mm:
2962         (listFromNSArray):
2963         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2964         (-[WebScriptObject evaluateWebScript:]):
2965         (-[WebScriptObject setValue:forKey:]):
2966         (-[WebScriptObject valueForKey:]):
2967         (-[WebScriptObject removeWebScriptKey:]):
2968         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
2969
2970 2007-06-13  Anders Carlsson  <andersca@apple.com>
2971
2972         Reviewed by Darin.
2973
2974         <rdar://problem/5267992>
2975         Make sure an alert doesn't allow loading to continue inside a script.
2976         
2977         Make sure to defer all loads where it's possible for a second main loop to be running.
2978         
2979         * page/Chrome.cpp:
2980         (WebCore::Chrome::runModal):
2981         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
2982         (WebCore::Chrome::runJavaScriptAlert):
2983         (WebCore::Chrome::runJavaScriptConfirm):
2984         (WebCore::Chrome::runJavaScriptPrompt):
2985         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2986         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2987         
2988         * platform/network/cf/ResourceHandleCFNet.cpp:
2989         (WebCore::ResourceHandle::setDefersLoading):
2990         Implement this.
2991
2992 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
2993
2994         Reviewed by Rob.
2995
2996         http://bugs.webkit.org/show_bug.cgi?id=14060
2997         Cairo SVG support
2998
2999         * WebCore.pro: Add new files to the build.
3000         * platform/graphics/svg/SVGPaintServerPattern.h:
3001         * platform/graphics/svg/SVGPaintServerSolid.h:
3002         * platform/graphics/svg/cairo: Added.
3003         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
3004         (WebCore::RenderPath::strokeContains):
3005         (WebCore::RenderPath::strokeBBox):
3006         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
3007         (WebCore::SVGPaintServer::draw):
3008         (WebCore::SVGPaintServer::teardown):
3009         (WebCore::SVGPaintServer::renderPath):
3010         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
3011         (WebCore::SVGPaintServerGradient::setup):
3012         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
3013         (WebCore::SVGPaintServerPattern::setup):
3014         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
3015         (WebCore::SVGPaintServerSolid::setup):
3016         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
3017         (WebCore::SVGResourceClipper::applyClip):
3018         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
3019         (WebCore::SVGResourceMasker::applyMask):
3020
3021 2007-06-13  Simon Hausmann  <hausmann@kde.org>
3022
3023         Reviewed by Lars.
3024
3025         Added a make install target that installs the Qt port and renamed
3026         WebKitQt to QtWebKit
3027
3028         * WebCore.pro:
3029
3030 2007-06-13  Adam Roben  <aroben@apple.com>
3031
3032         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
3033
3034         Rubberstamped by Oliver.
3035
3036         * platform/win/DragImageWin.cpp:
3037         (WebCore::allocImage):
3038
3039 2007-06-12  Oliver Hunt  <oliver@apple.com>
3040
3041         Reviewed by Darin.
3042
3043         Use correct size for BITMAPINFOHEADER -- whoops.
3044
3045         * platform/win/CursorWin.cpp:
3046         (WebCore::Cursor::Cursor):
3047         * platform/win/PasteboardWin.cpp:
3048         (WebCore::Pasteboard::writeImage):
3049
3050 2007-06-12  Sam Weinig  <sam@webkit.org>
3051
3052         Reviewed by Oliver.
3053
3054         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
3055         Cleanup JSEvent and JSClipboard in preperation for autogeneration
3056
3057         * bindings/js/kjs_events.cpp:
3058         (KJS::DOMEvent::DOMEvent):
3059         (KJS::DOMEvent::getValueProperty):
3060         (KJS::DOMEvent::put):
3061         (KJS::DOMEvent::putValueProperty):
3062         (KJS::DOMEventPrototypeFunction::callAsFunction):
3063         (KJS::toJS):
3064         (KJS::toEvent):
3065         (KJS::):
3066         (KJS::JSClipboard::JSClipboard):
3067         (KJS::JSClipboard::~JSClipboard):
3068         (KJS::JSClipboard::getOwnPropertySlot):
3069         (KJS::JSClipboard::getValueProperty):
3070         (KJS::JSClipboard::put):
3071         (KJS::JSClipboard::putValueProperty):
3072         (KJS::JSClipboardPrototypeFunction::callAsFunction):
3073         (KJS::toClipboard):
3074         * bindings/js/kjs_events.h:
3075         (KJS::DOMEvent::):
3076         (KJS::DOMEvent::impl):
3077         (KJS::JSClipboard::impl):
3078         * dom/ClipboardEvent.h:
3079         * dom/Event.h:
3080         (WebCore::Event::srcElement):
3081         (WebCore::Event::returnValue):
3082         (WebCore::Event::clipboardData):
3083         (WebCore::Event::dataTransfer):
3084         (WebCore::Event::clipboard):
3085         * dom/MouseEvent.h:
3086
3087 2007-06-13  Lars Knoll <lars@trolltech.com>
3088
3089         Reviewed by Niko.
3090
3091         Small cleanup
3092
3093         * platform/qt/PlugInInfoStoreQt.cpp:
3094         (WebCore::PlugInInfoStore::supportsMIMEType):
3095
3096 2007-06-13  Lars Knoll <lars@trolltech.com>
3097
3098         Reviewed by Niko
3099
3100         Implement the parts required for the JS bridge
3101         to know about the plugins.
3102
3103         * WebCore.pro:
3104         * platform/qt/PlugInInfoStoreQt.cpp: Added.
3105         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
3106         (WebCore::PlugInInfoStore::pluginCount):
3107         (WebCore::PlugInInfoStore::supportsMIMEType):
3108         (WebCore::refreshPlugins):
3109         * platform/qt/TemporaryLinkStubs.cpp:
3110
3111 === Merged the following changes from branches/WindowsMerge ===
3112
3113 2007-06-09  Sam Weinig  <sam@webkit.org>
3114
3115         Build fix.
3116
3117         * WebCore.vcproj/WebCore.vcproj:
3118
3119 2007-06-08  Anders Carlsson  <andersca@apple.com>
3120
3121         Reviewed by Adam.
3122
3123         If both the old and new WMP plugins are present, remove the old one
3124         so we won't end up choosing it.
3125         
3126         * plugins/win/PluginDatabaseWin.cpp:
3127         (WebCore::PluginDatabaseWin::getPluginsInPaths):
3128
3129 2007-06-08  David Hyatt  <hyatt@apple.com>
3130
3131         Update licenses/copyrights for WebCoreWin.
3132
3133         Reviewed by mccullough
3134
3135         * WebCorePrefix.cpp:
3136         * bridge/win/FrameWin.cpp:
3137         * bridge/win/FrameWin.h:
3138         * bridge/win/HistoryWin.cpp:
3139         * bridge/win/PageWin.cpp:
3140         * page/win/EventHandlerWin.cpp:
3141         * platform/graphics/cg/ColorCG.cpp:
3142         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
3143         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3144         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3145         * platform/graphics/win/IconWin.cpp:
3146         * platform/graphics/win/ImageWin.cpp:
3147         * platform/network/cf/FormDataStreamCFNet.cpp:
3148         * platform/network/cf/FormDataStreamCFNet.h:
3149         * platform/network/cf/ResourceHandleCFNet.cpp:
3150         * platform/network/cf/ResourceRequestCFNet.cpp:
3151         * platform/network/cf/ResourceResponseCFNet.cpp:
3152         * platform/network/win/CookieJarWin.cpp:
3153         * platform/network/win/ResourceHandleWin.cpp:
3154         * platform/network/win/ResourceHandleWin.h:
3155         * platform/win/BString.cpp:
3156         * platform/win/BString.h:
3157         * platform/win/ClipboardWin.h:
3158         * platform/win/ContextMenuWin.cpp:
3159         * platform/win/CursorWin.cpp:
3160         * platform/win/EditorWin.cpp:
3161         * platform/win/FontCacheWin.cpp:
3162         * platform/win/FontDataWin.cpp:
3163         * platform/win/FontPlatformData.h:
3164         * platform/win/FontPlatformDataWin.cpp:
3165         * platform/win/FontWin.cpp:
3166         * platform/win/GlyphPageTreeNodeWin.cpp:
3167         * platform/win/GraphicsContextWin.cpp:
3168         * platform/win/KeyEventWin.cpp:
3169         * platform/win/MimeTypeRegistryWin.cpp:
3170         * platform/win/NotImplemented.h:
3171         * platform/win/PlatformMouseEventWin.cpp:
3172         * platform/win/PlatformScrollBar.h:
3173         * platform/win/PlatformScrollBarWin.cpp:
3174         * platform/win/PopupMenuWin.cpp:
3175         * platform/win/ScreenWin.cpp:
3176         * platform/win/ScrollViewWin.cpp:
3177         * platform/win/SearchPopupMenuWin.cpp:
3178         * platform/win/SoundWin.cpp:
3179         * platform/win/TemporaryLinkStubs.cpp:
3180         * platform/win/TextBoundariesWin.cpp:
3181         * platform/win/WebCoreHistory.cpp:
3182         * platform/win/WebCoreHistory.h:
3183         * platform/win/WebCoreSystemInterface.cpp:
3184         * platform/win/WebCoreSystemInterface.h:
3185         * platform/win/WheelEventWin.cpp:
3186         * platform/win/WidgetWin.cpp:
3187         * plugins/win/PlugInInfoStoreWin.cpp:
3188         * plugins/win/PluginDatabaseWin.cpp:
3189         * plugins/win/PluginDatabaseWin.h:
3190         * plugins/win/PluginDebug.h:
3191         * plugins/win/PluginPackageWin.cpp:
3192         * plugins/win/PluginPackageWin.h:
3193         * plugins/win/PluginStreamWin.cpp:
3194         * plugins/win/PluginStreamWin.h:
3195         * plugins/win/PluginViewWin.cpp:
3196         * plugins/win/PluginViewWin.h:
3197         * plugins/win/npapi.cpp:
3198         * plugins/win/npfunctions.h:
3199         * rendering/RenderThemeSafari.cpp:
3200         * rendering/RenderThemeSafari.h:
3201         * rendering/RenderThemeWin.h:
3202
3203 2007-06-07  Sam Weinig  <sam@webkit.org>
3204
3205         Fix build.
3206
3207         * WebCore.vcproj/WebCore.vcproj:
3208
3209 2007-06-07  Anders Carlsson  <andersca@apple.com>
3210
3211         Reviewed by Steve.
3212
3213         <rdar://problem/5252902>
3214         Shockwave plug-in content crashes.
3215         
3216         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
3217         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
3218         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
3219         does not use CallWndProc but instead treats the WNDPROC as a function.
3220         
3221         * plugins/win/PluginViewWin.cpp:
3222         (WebCore::PluginViewWndProc):
3223         (WebCore::PluginViewWin::determineQuirks):
3224         (WebCore::PluginViewWin::init):
3225         * plugins/win/PluginViewWin.h:
3226         (WebCore::):
3227         (WebCore::PluginViewWin::quirks):
3228
3229 2007-06-07  Sam Weinig  <sam@webkit.org>
3230
3231         Build fix for the build fix.
3232
3233         * WebCore.vcproj/WebCore.vcproj:
3234
3235 2007-06-07  Sam Weinig  <sam@webkit.org>
3236
3237         Build fix.
3238
3239         * WebCore.vcproj/WebCore.vcproj:
3240
3241 2007-06-06  Sam Weinig  <sam@webkit.org>
3242
3243         Build fix.
3244
3245         * WebCore.vcproj/WebCore.vcproj:
3246
3247 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3248
3249         Reviewed by Oliver.
3250
3251         Update to last fix.
3252         Invalidate a list of rects rather than unioning them.
3253
3254         * plugins/win/PluginViewWin.cpp:
3255         (WebCore::PluginViewWin::invalidateTimerFired):
3256         (WebCore::PluginViewWin::invalidateRect):
3257         * plugins/win/PluginViewWin.h:
3258
3259 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
3260
3261         Reviewed by Oliver.
3262
3263         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
3264         
3265         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
3266         starving other HWNDs.
3267         
3268         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
3269         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
3270         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
3271
3272         * plugins/win/PluginViewWin.cpp:
3273         (WebCore::PluginViewWin::invalidateTimerFired): Added.
3274         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
3275         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
3276         * plugins/win/PluginViewWin.h:
3277
3278 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3279
3280         Reviewed by Adam.
3281
3282         Update last fix to use startsWith instead of strcmpi.
3283
3284         * plugins/win/PluginStreamWin.cpp:
3285         (WebCore::PluginStreamWin::startStream):
3286         * plugins/win/PluginViewWin.cpp:
3287         (WebCore::scriptStringIfJavaScriptURL):
3288
3289 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
3290
3291         Reviewed by gramps.
3292
3293         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
3294         Make "javascript" URL scheme string compare case insensitive.
3295
3296         * plugins/win/PluginStreamWin.cpp:
3297         (WebCore::PluginStreamWin::startStream): Use strcmpi.
3298         * plugins/win/PluginViewWin.cpp:
3299         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
3300
3301 2007-06-01  Anders Carlsson  <andersca@apple.com>
3302
3303         Reviewed by Steve.
3304
3305         If the value exists but is empty, return an empty String.
3306         
3307         * plugins/win/PluginPackageWin.cpp:
3308         (WebCore::getVersionInfo):
3309
3310 2007-06-01  Anders Carlsson  <andersca@apple.com>
3311
3312         Reviewed by Steve.
3313
3314         Add the default path for the new WMP Firefox plugin.
3315
3316         * plugins/win/PluginDatabaseWin.cpp:
3317         (WebCore::addWindowsMediaPlayerPluginPath):
3318
3319 2007-05-31  Sam Weinig  <sam@webkit.org>
3320
3321         Fixed build.
3322
3323         * WebCore.vcproj/WebCore.vcproj:
3324
3325 2007-05-31  Sam Weinig  <sam@webkit.org>
3326
3327         Fixed build.
3328
3329         * WebCore.vcproj/WebCore.vcproj:
3330
3331 2007-05-30  Ada Chan  <adachan@apple.com>
3332
3333         Reviewed by Adam.
3334
3335         Fixed build.
3336
3337         * platform/win/PopupMenuWin.cpp:
3338         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
3339
3340 2007-05-30  Sam Weinig  <sam@webkit.org>
3341
3342         Build Fix.
3343
3344         * WebCore.vcproj/WebCore.vcproj:
3345
3346 2007-05-29  Sam Weinig  <sam@webkit.org>
3347
3348         Fix the build.
3349
3350         * WebCore.vcproj/WebCore.vcproj:
3351
3352 2007-05-29  Anders Carlsson  <andersca@apple.com>
3353
3354         Reviewed by Adam.
3355
3356         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
3357
3358         Pass the plugin window coordinates for windowed plugins too.
3359         
3360         * plugins/win/PluginViewWin.cpp:
3361         (WebCore::PluginViewWin::setNPWindowRect):
3362
3363 2007-05-29  Anders Carlsson  <andersca@apple.com>
3364
3365         Reviewed by Adam.
3366
3367         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
3368         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
3369         
3370         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
3371         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
3372         quirk for that.
3373         
3374         * plugins/win/PluginViewWin.cpp:
3375         (WebCore::PluginViewWin::determineQuirks):
3376         (WebCore::PluginViewWin::init):
3377         * plugins/win/PluginViewWin.h:
3378         (WebCore::):
3379
3380 2007-05-29  Sam Weinig  <sam@webkit.org>
3381
3382         Reviewed by Adam Roben.
3383
3384         - Removes platform/win/NotImplemented.h because we have consolidated
3385           the notImplemented() for all platforms in platform/NotImplemented.h
3386         - Fixes remaining uses of old macro to use the new notImplemented() one.
3387
3388         * WebCore.vcproj/WebCore.vcproj:
3389         * page/win/EventHandlerWin.cpp:
3390         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3391         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
3392         (WebCore::SVGResourceFilter::prepareFilter):
3393         (WebCore::SVGResourceFilter::applyFilter):
3394         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
3395         (WebCore::SVGResourceMasker::applyMask):
3396         * platform/win/GraphicsContextWin.cpp:
3397         (WebCore::contextForImage):
3398         * platform/win/NotImplemented.h: Removed.
3399         * platform/win/SearchPopupMenuWin.cpp:
3400         (WebCore::SearchPopupMenu::saveRecentSearches):
3401         (WebCore::SearchPopupMenu::loadRecentSearches):
3402         * platform/win/TemporaryLinkStubs.cpp:
3403         (Frame::print):
3404         (Frame::issueTransposeCommand):
3405         (GraphicsContextPlatformPrivate::clip):
3406         (WebCore::FrameView::updateBorder):
3407         (Widget::setIsSelected):
3408         (ScrollView::inWindow):
3409         (WebCore::focusRingColor):
3410         (WebCore::setFocusRingColorChangeFunction):
3411         (Frame::setNeedsReapplyStyles):
3412         (FrameLoader::overrideMediaType):
3413         (DocumentLoader::getResponseModifiedHeader):
3414         (ResourceHandle::willLoadFromCache):
3415         (WebCore::userIdleTime):
3416         (CachedPage::close):
3417         (WebCore::supportedKeySizes):
3418         (WebCore::signedPublicKeyAndChallengeString):
3419         * plugins/win/PluginViewWin.cpp:
3420         (WebCore::PluginViewWin::newStream):
3421         (WebCore::PluginViewWin::write):
3422         (WebCore::PluginViewWin::setValue):
3423
3424 2007-05-29  Anders Carlsson  <andersca@apple.com>
3425
3426         Build fix.
3427         
3428         * rendering/RenderThemeSafari.cpp:
3429         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
3430
3431 2007-05-29  Anders Carlsson  <andersca@apple.com>
3432
3433         Reviewed by Adam.
3434
3435         Port code from open source changeset 21808, fixing
3436         http://bugs.webkit.org/show_bug.cgi?id=13871 
3437         
3438         * rendering/RenderThemeSafari.cpp:
3439         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3440         * rendering/RenderThemeSafari.h:
3441
3442 2007-05-29  Ada Chan  <adachan@apple.com>
3443
3444         Build fix.
3445         - Added "$(ProjectDir)..\platform\win" to include paths
3446         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
3447
3448         * WebCore.vcproj/WebCore.vcproj:
3449
3450 2007-05-28  Sam Weinig  <sam@webkit.org>
3451
3452         Build fix.
3453
3454         * WebCore.vcproj/WebCore.vcproj:
3455
3456 2007-05-27  Sam Weinig  <sam@webkit.org>
3457
3458         Build fix.
3459
3460         * WebCore.vcproj/WebCore.vcproj:
3461
3462 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
3463
3464         Reviewed by Darin Adler.
3465
3466         Fixed a bug with Settings where a number of different objects held bare 
3467         Settings* data members, even though the Page owns the Settings object and 
3468         deletes it upon destruction.
3469
3470         Added NULL checks since the Page can be deleted before the frame/document.
3471
3472         * plugins/win/PluginViewWin.cpp:
3473         (WebCore::PluginViewWin::load):
3474
3475 2007-05-24  Sam Weinig  <sam@webkit.org>
3476
3477         Reviewed by NOBODY.
3478
3479         Build fix.
3480
3481         * WebCore.vcproj/WebCore.vcproj:
3482
3483 2007-05-24  Anders Carlsson  <andersca@apple.com>
3484
3485         Reviewed by Adam.
3486
3487         <rdar://5211882>
3488         Need to relaunch Boomer to recognize newly installed QT plug-in
3489         
3490         <rdar://5061867>
3491         After installing Flash, Safari would still not display pages that needed it
3492         
3493         * plugins/win/PluginDatabaseWin.cpp:
3494         (WebCore::PluginDatabaseWin::refresh):
3495         Return whether the plugin database changed or not.
3496         
3497         (WebCore::PluginDatabaseWin::findPlugin):
3498         New function that tries to find a plug-in given its url and MIME type.
3499         
3500         (WebCore::PluginDatabaseWin::createPluginView):
3501         If no plugin is found, refresh the database and search for the plugin again if the database changed.
3502         
3503 2007-05-24  Adele Peterson  <adele@apple.com>
3504
3505         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
3506           Separator in new <select> widget disappears when block element with border is in document.
3507
3508         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
3509          Added calls to set the stroke style and thickness when painting the arrows and the separator.
3510
3511 2007-05-24  Sam Weinig  <sam@webkit.org>
3512
3513         Build fix.
3514
3515         * WebCore.vcproj/WebCore.vcproj:
3516
3517 2007-05-23  Sam Weinig  <sam@webkit.org>
3518
3519         Build fix.
3520
3521         * WebCore.vcproj/WebCore.vcproj:
3522
3523 2007-05-23  Anders Carlsson  <andersca@apple.com>
3524
3525         Fix build.
3526         
3527         * platform/win/CursorWin.cpp:
3528         (WebCore::zoomInCursor):
3529         (WebCore::zoomOutCursor):
3530
3531 2007-05-22  Ada Chan  <adachan@apple.com>
3532
3533         Fix build.
3534
3535         * plugins/win/PluginViewWin.cpp:
3536         (WebCore::PluginViewWin::handleMouseEvent):
3537
3538 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
3539
3540         Reviewed by oliver
3541
3542         Build fix.
3543
3544         * plugins/win/PluginViewWin.cpp:
3545         (WebCore::PluginViewWin::handleMouseEvent): 
3546
3547 2007-05-21  Sam Weinig  <sam@webkit.org>
3548
3549         Reviewed by Oliver.
3550
3551         Build fix.
3552
3553         * WebCore.vcproj/WebCore.vcproj:
3554
3555 2007-05-21  Sam Weinig  <sam@webkit.org>
3556
3557         Reviewed by Adam.
3558
3559         Build fix.
3560
3561         * WebCore.vcproj/WebCore.vcproj:
3562
3563 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
3564
3565         Reviewed by Geoff, Adam.
3566
3567         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
3568         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
3569         
3570         A few files needed to be excluded, since they didn't build properly with
3571         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
3572
3573         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
3574         * WebCorePrefix.cpp: Added.
3575         * WebCorePrefix.h: Added.
3576         * config.h: Modified to be compatible with WebCorePrefix.h.
3577
3578 2007-05-18  Sam Weinig  <sam@webkit.org>
3579
3580         Reviewed by Adam.
3581
3582         Fixing the vcproj paths.
3583
3584         * WebCore.vcproj/WebCore.vcproj:
3585
3586 2007-05-18  Sam Weinig  <sam@webkit.org>
3587
3588         Reviewed by Geoff.
3589
3590         Build fix after r21577.
3591
3592         * WebCore.vcproj/WebCore.vcproj:
3593
3594 2007-05-18  Adam Roben  <aroben@apple.com>
3595
3596         Build fix after r21562.
3597
3598         * platform/win/TemporaryLinkStubs.cpp:
3599         * platform/win/WidgetWin.cpp:
3600         * plugins/win/PluginViewWin.cpp:
3601         * plugins/win/PluginViewWin.h:
3602
3603 2007-05-18  Anders Carlsson  <andersca@apple.com>
3604
3605         Reviewed by Geoff.
3606         
3607         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
3608         
3609         This patch does two things:
3610         
3611         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
3612         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
3613         
3614         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
3615         
3616         * plugins/win/PluginViewWin.cpp:
3617         (WebCore::PluginViewWin::updateWindow):
3618
3619 2007-05-18  Adam Roben  <aroben@apple.com>
3620
3621         Build fix after r21555.
3622
3623         * page/win/EventHandlerWin.cpp:
3624         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3625
3626 2007-05-17  Sam Weinig  <sam@webkit.org>
3627
3628         Reviewed by Adam.
3629
3630         Build Fix after <rdar://problem/5201423>
3631
3632         * WebCore.vcproj/WebCore.vcproj:
3633
3634 2007-05-17  Adele Peterson  <adele@apple.com>
3635
3636         Reviewed by Hyatt.
3637
3638         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3639
3640         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
3641           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
3642           we will match the button text.
3643
3644 2007-05-17  Anders Carlsson  <andersca@apple.com>
3645
3646         Reviewed by Darin.
3647
3648         <rdar://problem/5210600> New WMP plugin doesn't show any contents
3649
3650         Call NPP_SetWindow after the window's size has been updated.
3651         
3652         * plugins/win/PluginViewWin.cpp:
3653         (WebCore::PluginViewWin::setFrameGeometry):
3654
3655 2007-05-17  Anders Carlsson  <andersca@apple.com>
3656
3657         Reviewed by John.
3658
3659         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
3660         
3661         Return null if the extension is null.
3662         
3663         * platform/win/MimeTypeRegistryWin.cpp:
3664         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
3665
3666 2007-05-16  Adele Peterson  <adele@apple.com>
3667
3668         Reviewed by Hyatt.
3669
3670         Fix for:
3671             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
3672             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
3673
3674         * platform/win/PopupMenuWin.cpp:
3675         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
3676         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
3677         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
3678
3679 2007-05-14  Oliver Hunt  <oliver@apple.com>
3680
3681         Reviewed by Sam.
3682
3683         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
3684
3685         If the image does not already have a title, fall back to the 
3686         name suggested by Content-Disposition.
3687
3688         * platform/win/ClipboardWin.cpp:
3689         (WebCore::createGlobalImageFileDescriptor):
3690
3691 2007-05-14  Oliver Hunt  <oliver@apple.com>
3692
3693         Reviewed by Sam.
3694
3695         Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)
3696         
3697         Null terminate manually to prevent us from dereferencing null.
3698
3699         * platform/win/ClipboardUtilitiesWin.cpp:
3700         (WebCore::createGlobalData):
3701
3702 2007-05-14  Oliver Hunt  <oliver@apple.com>
3703
3704         Reviewed by Geoff.
3705
3706         Windows side of fix for
3707         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
3708
3709         * platform/win/ClipboardUtilitiesWin.cpp:
3710         (WebCore::cfHDropFormat):
3711           Need to be able to access externally
3712           
3713         * platform/win/ClipboardUtilitiesWin.h:
3714           Declare cfHDropFormat
3715           
3716         * platform/win/DragDataWin.cpp:
3717         (WebCore::DragData::containsFiles):
3718         (WebCore::DragData::asFilenames):
3719           Add implementation of containsFiles and asFilenames
3720
3721 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
3722
3723         Build fix.
3724
3725         * WebCore.vcproj/WebCore.vcproj:
3726
3727 2007-05-14  Anders Carlsson  <andersca@apple.com>
3728
3729         Reviewed by Geoff.
3730
3731         <rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported
3732         
3733         * plugins/win/PluginDatabaseWin.cpp:
3734         (WebCore::addPluginsFromRegistry):
3735         New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
3736
3737         * plugins/win/PluginViewWin.cpp:
3738         (WebCore::PluginViewWin::invalidateRect):
3739         (WebCore::PluginViewWin::forceRedraw):
3740         Make these work with windowed plugins.
3741         
3742 2007-05-13  Darin Adler  <darin@apple.com>
3743
3744         Requested by Hyatt.
3745
3746         - internal part of http://bugs.webkit.org/show_bug.cgi?id=13529
3747           DOM3 keyIdentifier text is incorrect
3748
3749         * platform/win/KeyEventWin.cpp:
3750         (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
3751
3752 2007-05-12  Oliver Hunt  <oliver@apple.com>
3753
3754         rs=hyatt.
3755
3756         Stubs to prevent build bustage
3757
3758         * platform/win/DragDataWin.cpp:
3759         (WebCore::DragData::containsFiles):
3760         (WebCore::DragData::asFilenames):
3761
3762 2007-05-11  Darin Adler  <darin@apple.com>
3763
3764         * WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.
3765
3766 2007-05-10  Adele Peterson  <adele@apple.com>
3767
3768         Reviewed by Hyatt.
3769
3770         * bridge/win/FrameWin.cpp:
3771         (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
3772         
3773 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3774
3775         Rubber-stamped by Geoff.
3776
3777         Moved shared EditorWin code to Editor.cpp in open source.
3778
3779         * platform/win/EditorWin.cpp: Deleted (moved) most of this file.
3780
3781 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3782
3783         Reviewed by Darin, Oliver.
3784
3785         Removed localized string stubs.
3786
3787         * platform/win/TemporaryLinkStubs.cpp:
3788
3789 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
3790
3791         Reviewed by Ada.
3792
3793         Updated for new editor interface.
3794
3795         * platform/win/EditorWin.cpp:
3796         (WebCore::Editor::advanceToNextMisspelling):
3797         (WebCore::isRangeUngrammatical):
3798
3799 2007-05-07  Alice Liu  <alice.liu@apple.com>
3800
3801         Reviewed by Oliver.
3802
3803         Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
3804         and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
3805         and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
3806         into ClipboardUtilitiesWin.h/cpp.
3807
3808         * WebCore.vcproj/WebCore.vcproj:
3809         * platform/win/ClipboardUtilitiesWin.cpp: Added.
3810         (WebCore::cfHDropFormat):
3811         (WebCore::getWebLocData):
3812         (WebCore::extractURL):
3813         (WebCore::texthtmlFormat):
3814         (WebCore::createGlobalData):
3815         (WebCore::markupToCF_HTML):
3816         (WebCore::urlToMarkup):
3817         (WebCore::replaceNewlinesWithWindowsStyleNewlines):
3818         (WebCore::replaceNBSPWithSpace):
3819         (WebCore::urlWFormat):
3820         (WebCore::urlFormat):
3821         (WebCore::plainTextFormat):
3822         (WebCore::plainTextWFormat):
3823         (WebCore::filenameWFormat):
3824         (WebCore::filenameFormat):
3825         (WebCore::htmlFormat):
3826         (WebCore::getURL):
3827         (WebCore::getPlainText):
3828         (WebCore::fragmentFromFilenames):
3829         (WebCore::containsFilenames):
3830         (WebCore::fragmentFromCF_HTML):
3831         (WebCore::fragmentFromHTML):
3832         (WebCore::containsHTML):
3833         * platform/win/ClipboardUtilitiesWin.h: Added.
3834         * platform/win/ClipboardWin.cpp:
3835         (WebCore::ClipboardWin::writeRange):
3836         * platform/win/DragDataWin.cpp:
3837         * platform/win/PasteboardWin.cpp:
3838         (WebCore::Pasteboard::writeSelection):
3839         (WebCore::Pasteboard::documentFragment):
3840
3841 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
3842
3843         Reviewed by Darin.
3844
3845         Fix crash when using "check spelling while typing".
3846
3847         * WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
3848         * platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.
3849
3850 2007-05-04  Alice Liu  <alice.liu@apple.com>
3851
3852         Reviewed by Darin.
3853
3854         changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()
3855
3856         * platform/win/DragDataWin.cpp:
3857         (WebCore::fragmentFromHTML):
3858         * platform/win/PasteboardWin.cpp:
3859         (WebCore::Pasteboard::documentFragment):
3860
3861 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
3862
3863         Reviewed by Ada, Oliver.
3864
3865         Checkpoint:
3866         <rdar://problem/4602372> Spelling
3867         <rdar://problem/4769763> Spell checking engine support
3868
3869         * platform/win/EditorWin.cpp:
3870         (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake).
3871         (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error.
3872         (WebCore::isRangeUngrammatical): Include user description with spelling error.
3873
3874 2007-05-03  Alice Liu  <alice.liu@apple.com>
3875
3876         Reviewed by Oliver.
3877
3878         Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted
3879
3880         * platform/win/DragDataWin.cpp:
3881         (WebCore::fragmentFromHTML):
3882         * platform/win/PasteboardWin.cpp:
3883         (WebCore::fragmentFromCF_HTML):
3884         (WebCore::Pasteboard::documentFragment):
3885
3886 2007-05-03  Oliver Hunt  <oliver@apple.com>
3887
3888         Reviewed by Steve
3889
3890         Fix misuse of GlobalLock.
3891
3892         * platform/win/PasteboardWin.cpp:
3893         (WebCore::createGlobalData):
3894
3895 2007-05-03  Oliver Hunt  <oliver@apple.com>
3896
3897         Reviewed by Steve.
3898
3899         Add logic to draw underlines for grammar and spelling errors.
3900         (rdar://problem/4769832)
3901
3902         * platform/win/GraphicsContextWin.cpp:
3903         (WebCore::spellingPatternColor):
3904         (WebCore::grammarPatternColor):
3905           Can't define global const with constructor so use function scoped globals instead.
3906         (WebCore::setCGStrokeColor):
3907           Utility function pulled over from GraphicsContextCG          
3908         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3909         
3910         * platform/win/TemporaryLinkStubs.cpp:
3911           Remove old drawLineForMisspellingOrBadGrammar stub
3912
3913 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
3914
3915         Reviewed by Oliver.
3916
3917         Fix crash when retrieving title of context menu after it has been selected.
3918         Necessary to get spelling corrections code working.
3919
3920         * platform/win/ContextMenuWin.cpp:
3921         (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.
3922
3923 2007-04-29  Adam Roben  <aroben@apple.com>
3924
3925         Build fix after r21183.
3926
3927         * WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).
3928
3929 2007-04-29  Oliver Hunt  <oliver@apple.com>
3930
3931         Reviewed by Steve.
3932
3933         Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
3934  
3935         Prevent build bustage from opensource changes, correct scaling
3936
3937         * platform/win/DragImageWin.cpp:
3938         (WebCore::scaleDragImage):
3939
3940 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
3941
3942         Reviewed by Darin, Oliver.
3943
3944         Checkpoint:
3945         <rdar://problem/4602372> Spelling
3946         <rdar://problem/4769763> Spell checking engine support
3947         
3948         Ported code from EditorMac.mm into EditorWin.cpp.
3949         Once this works, I'll move this code into Editor.cpp and remove it
3950         form EditorMac.mm.
3951
3952         * platform/win/EditorWin.cpp:
3953         (WebCore::Editor::ignoreSpelling):
3954         (WebCore::Editor::learnSpelling):
3955         (WebCore::findFirstMisspellingInRange):
3956         (WebCore::paragraphAlignedRangeForRange):
3957         (WebCore::findFirstGrammarDetailInRange):
3958         (WebCore::findFirstBadGrammarInRange):
3959         (WebCore::Editor::advanceToNextMisspelling):
3960         (WebCore::Editor::isSelectionMisspelled):
3961         (WebCore::isRangeUngrammatical):
3962         (WebCore::Editor::isSelectionUngrammatical):
3963         (WebCore::Editor::guessesForUngrammaticalSelection):
3964         (WebCore::Editor::guessesForMisspelledSelection):
3965         (WebCore::Editor::showSpellingGuessPanel):
3966         (WebCore::Editor::spellingPanelIsShowing):
3967         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
3968         (WebCore::markAllMisspellingsInRange):
3969         (WebCore::markAllBadGrammarInRange):
3970         (WebCore::markMisspellingsOrBadGrammar):
3971         (WebCore::Editor::markMisspellings):
3972         (WebCore::Editor::markBadGrammar):
3973         * platform/win/TemporaryLinkStubs.cpp:
3974
3975 2007-04-23  Anders Carlsson  <andersca@apple.com>
3976
3977         Reviewed by Ada.
3978
3979         <rdar://problem/5061022>
3980         REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)
3981         
3982         * page/win/EventHandlerWin.cpp:
3983         (WebCore::EventHandler::passWheelEventToWidget):
3984         Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
3985
3986 2007-04-23  Adam Roben  <aroben@apple.com>
3987
3988         Build fix.
3989
3990         * page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.
3991
3992 2007-04-20  Beth Dakin  <bdakin@apple.com>
3993
3994         Reviewed by Adam.
3995
3996         Fix for <rdar://problem/5089822> Boomer does not send scroll events
3997
3998         * platform/win/ScrollViewWin.cpp:
3999         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
4000
4001 2007-04-19  Adam Roben  <aroben@apple.com>
4002
4003         * WebCore.vcproj/WebCore.vcproj: Removed empty filter.
4004
4005 2007-04-19  Adam Roben  <aroben@apple.com>
4006
4007         * WebCore.vcproj/WebCore.vcproj: Removed unused files.
4008
4009 2007-04-18  Adam Roben  <aroben@apple.com>
4010
4011         Reviewed by Oliver.
4012
4013         Added an equality operator to COMPtr.
4014
4015         * platform/win/COMPtr.h:
4016         (operator==):
4017         (operator!=):
4018
4019 2007-04-18  Oliver Hunt  <oliver@apple.com>
4020
4021         Reviewed by Geoff.
4022
4023         Allow images to be dragged from page and dropped as files.
4024         This is the remainder of the fix for <rdar://problem/5035948> 
4025           -- Dragging image or link from boomer doesn't create webloc 
4026              or image file.
4027
4028         * platform/win/ClipboardWin.cpp:
4029         (WebCore::filesystemPathFromUrlOrTitle):
4030           Make name generation nicer, and better match Firefox
4031         
4032         (WebCore::createGlobalURLContent):
4033           rename function
4034         
4035         (WebCore::createGlobalImageFileContent):
4036           Copies image data into global store
4037         
4038         (WebCore::createGlobalUrlFileDescriptor):
4039           Rename function
4040           Updated for parameter change on filesystemPathFromUrlOrTitle
4041         
4042         (WebCore::createGlobalImageFileDescriptor):
4043           Set up file descriptor for image drag
4044         
4045         (WebCore::getCachedImage):
4046           Helper function
4047         
4048         (WebCore::writeImageToDataObject):
4049           Attempts to build and insert data for image->file drag
4050         
4051         (WebCore::ClipboardWin::declareAndWriteDragImage):
4052           Attempts to build and insert data for image->file drag
4053         
4054         (WebCore::ClipboardWin::writeURL):
4055           Add call to imageDataToDataObject
4056
4057 2007-04-17  Adam Roben  <aroben@apple.com>
4058
4059         Rubberstamped by Oliver.
4060
4061         * platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary
4062         include.
4063
4064 2007-04-17  Oliver Hunt  <oliver@apple.com>
4065
4066         Whoops, had code commented out from manual failure test.
4067         Also fixed date of previous changelog entry
4068
4069         * platform/win/ClipboardWin.cpp:
4070         (WebCore::writeFileToDataObject):
4071
4072 2007-04-17  Oliver Hunt  <oliver@apple.com>
4073
4074         Reviewed by Ada.
4075
4076         Partial fix for <rdar://problem/5035948> -- Dragging image 
4077         or link from boomer doesn't create webloc or image file.
4078         
4079         Add all the ground work to set up FileDescriptors and FileContent
4080         for allowing files to be created from drag and drop actions,
4081         and hook up logic for links to create WebLoc data for drag and drop.
4082
4083         * platform/win/ClipboardWin.cpp:
4084         (WebCore::fileDescriptorFormat):
4085         (WebCore::fileContentFormat):
4086           Clipboard formats 
4087           
4088         (WebCore::pathRemoveBadFSCharacters):
4089         (WebCore::filesystemPathFromUrlOrTitle):
4090           Helper functions for create filenames
4091           
4092         (WebCore::createGlobalDataForURLContent):
4093           Create the WebLoc content
4094           
4095         (WebCore::createGlobalDataForUrlFileDescriptor):
4096           Create a file descriptor for the WebLoc data
4097           
4098         (WebCore::writeFileToDataObject):
4099           Basic helper function to push generated file info
4100           into the target DataObject
4101           
4102         (WebCore::ClipboardWin::writeURL):
4103           Now puts WebLoc file onto the Clipboard
4104
4105 2007-04-16  Adam Roben  <aroben@apple.com>
4106
4107         Reviewed by Adele.
4108
4109         Fix <rdar://problem/5002577> Focus ring SPI in GraphicsContextWin.cpp
4110         needs to move to WebKitSystemInterface
4111
4112         * platform/win/GraphicsContextWin.cpp:
4113         (WebCore::GraphicsContext::drawFocusRing): Use wkDrawFocusRing.
4114
4115 2007-04-14  Adam Roben  <aroben@apple.com>
4116
4117         * WebCore.vcproj/WebCore.submit.sln: Use the Debug_Internal
4118         configuration.
4119
4120 2007-04-14  Adam Roben  <aroben@apple.com>
4121
4122         Small correctness fix that is needed for building OpenSource.
4123
4124         * platform/win/PopupMenuWin.cpp: Use RenderTheme instead of RenderThemeWin.
4125
4126 2007-04-13  Adam Roben  <aroben@apple.com>
4127
4128         Reviewed by Tim.
4129
4130         Sync our config.h with the OpenSource version so we can merge ours in
4131         later.
4132
4133         * config.h: Added #defines from the OpenSource version, moved
4134         Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid
4135         of assert.h
4136         * platform/win/CursorWin.cpp:
4137         (WebCore::Cursor::Cursor): Use ASSERT instead of assert.
4138
4139 2007-04-13  Adam Roben  <aroben@apple.com>
4140
4141         Rubberstamped by Tim.
4142
4143         Removed the loader/win directory since it only contains empty files.
4144
4145         * WebCore.vcproj/WebCore.vcproj: Removed empty files.
4146         * loader/win/FrameLoaderWin.cpp: Removed.
4147         * loader/win/ResourceLoaderWin.cpp: Removed.
4148
4149 2007-04-12  Adam Roben  <aroben@apple.com>
4150
4151         Rubberstamped by Steve.
4152
4153         Removed unused file.
4154
4155         * WebCore.vcproj/WebCore.sln: Removed.
4156
4157 2007-04-12  Adam Roben  <aroben@apple.com>
4158
4159         Didn't mean to commit this.
4160
4161         * WebCore.vcproj/WebCore.vcproj:
4162
4163 2007-04-12  Adam Roben  <aroben@apple.com>
4164
4165         Reviewed by Steve.
4166
4167         <rdar://problem/5131565> Need to be able to use debug WebKit with
4168         release Safari.
4169
4170         * WebCore.vcproj/WebCore.vcproj:
4171         * WebCore.vcproj/debug.vsprops:
4172         * WebCore.vcproj/debug_internal.vsprops: Added.
4173         * WebCore.vcproj/release.vsprops:
4174
4175 2007-04-11  Adam Roben  <aroben@apple.com>
4176
4177         Reviewed by Tim.
4178
4179         Get rid of FrameViewWin.cpp, since it's empty.
4180
4181         * WebCore.vcproj/WebCore.vcproj:
4182         * bridge/win/FrameViewWin.cpp: Removed.
4183
4184 2007-04-11  Adam Roben  <aroben@apple.com>
4185
4186         Reviewed by Anders.
4187
4188         Update for changes to Pasteboard.
4189
4190         * platform/win/PasteboardWin.cpp:
4191         (WebCore::Pasteboard::writeImage):
4192
4193 2007-04-10  Brady Eidson  <beidson@apple.com>
4194
4195         Reviewed by Darin
4196
4197         <rdar://problem/4887095> - PageCache and PageState should be combined
4198
4199         Changed a TemporaryLinkStub and updated the project file
4200
4201         * WebCore.vcproj/WebCore.vcproj:
4202         * platform/win/TemporaryLinkStubs.cpp:
4203         (CachedPage::close):
4204
4205 2007-04-10  John Sullivan  <sullivan@apple.com>
4206
4207         * platform/win/TemporaryLinkStubs.cpp:
4208         (WebCore::Editor::markBadGrammar):
4209         Keep build going: added stub for this new method
4210
4211 2007-04-10  Anders Carlsson  <andersca@apple.com>
4212
4213         Reviewed by Adam.
4214
4215         <rdar://problem/5056988>
4216         Can not open player on http://radioalice.com
4217
4218         Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past 
4219         a '?' character because that would be parsed as the query part of the URL.
4220         
4221         * plugins/win/PluginViewWin.cpp:
4222         (WebCore::scriptStringIfJavaScriptURL):
4223         Make this be more like the mac, chopping off the first 12 characters ("javascript:") 
4224         and then decoding the remaining characters.
4225
4226 2007-04-10  Anders Carlsson  <acarlsson@apple.com>
4227
4228         * plugins/win/PluginViewWin.cpp:
4229         (WebCore::PluginViewWin::PluginViewWin):
4230         Initialize m_status.
4231
4232 2007-04-09  Anders Carlsson  <acarlsson@apple.com>
4233
4234         Reviewed by Adam.
4235
4236         <rdar://problem/5062624>
4237         No prompt to install QT for pages with uninstalled QT plug-in.
4238         
4239         Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
4240         loaded successfully or not.
4241         
4242         * plugins/win/PluginViewWin.cpp:
4243         (WebCore::PluginViewWin::PluginViewWin):
4244         (WebCore::PluginViewWin::init):
4245         * plugins/win/PluginViewWin.h:
4246         (WebCore::):
4247         (WebCore::PluginViewWin::status):
4248
4249 2007-04-09  Brady Eidson  <beidson@apple.com>
4250
4251         Build fix
4252
4253         * plugins/win/PluginViewWin.cpp:
4254         (WebCore::PluginViewWin::performRequest): assume userGesture is true
4255
4256 2007-04-09  Adam Roben  <aroben@apple.com>
4257
4258         Build fix.
4259
4260         * platform/win/PasteboardWin.cpp:
4261         (WebCore::Pasteboard::writeImage):
4262
4263 2007-04-08  Adam Roben  <aroben@apple.com>
4264
4265         Reviewed by Oliver.
4266
4267         Stubbed out Frame::dashboardRegionsChanged now that it's not
4268         Mac-specific.
4269
4270         * bridge/win/FrameWin.cpp:
4271         (WebCore::Frame::dashboardRegionsChanged):
4272
4273 2007-04-06  Oliver Hunt  <oliver@apple.com>
4274
4275         Reviewed by Adam.
4276
4277         Fix for rdar://problem/5097227 Can't drag Flash-based 
4278         scrollbar on mtv.com
4279         
4280         The problem was when creating a mouse move event for the 
4281         plugin we weren't passing on the mouse button state.  
4282         
4283         The opensource side of this patch adds logic that allows 
4284         us to distinguish between a MouseEvent with NoButton and
4285         a MouseEvent with LeftButton, so we can then provide the 
4286         correct information to the plugin.
4287
4288         * plugins/win/PluginViewWin.cpp:
4289         (WebCore::PluginViewWin::handleMouseEvent):
4290
4291 2007-04-06  Dave Hyatt  <hyatt@apple.com>
4292
4293         Internal side of fix for bug 13274.
4294
4295         Reviewed by olliej
4296
4297         * page/win/EventHandlerWin.cpp:
4298         (WebCore::EventHandler::passMousePressEventToSubframe):
4299         * platform/win/PlatformScrollBarSafari.cpp:
4300         (WebCore::PlatformScrollbar::handleMousePressEvent):
4301         * platform/win/PopupMenuWin.cpp:
4302         (WebCore::PopupMenu::PopupMenu):
4303         (WebCore::PopupWndProc):
4304         * platform/win/ScrollViewWin.cpp:
4305         (WebCore::ScrollView::removeChild):
4306         * platform/win/WidgetWin.cpp:
4307
4308 2007-04-07  Mark Rowe  <mrowe@apple.com>
4309
4310         Internal build fox after opensource r20753.
4311
4312         * platform/win/PlatformMouseEventWin.cpp:
4313         * platform/win/TemporaryLinkStubs.cpp:
4314
4315 2007-04-03  Oliver Hunt  <oliver@apple.com>
4316
4317         Buildfix
4318
4319         * platform/network/cf/ResourceResponseCFNet.cpp:
4320         (WebCore::ResourceResponse::doUpdateResourceResponse):
4321            Adding .get() calls
4322
4323 2007-04-03  Maciej Stachowiak  <mjs@apple.com>
4324
4325         Reviewed by Alice.
4326
4327         - fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
4328
4329         * platform/network/cf/ResourceResponseCFNet.cpp:
4330         (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once
4331         just as style cleanup).
4332
4333 2007-04-02  Anders Carlsson  <andersca@apple.com>
4334
4335         Reviewed by Adam.
4336
4337         Fix crashes seen when running the plugin layout tests.
4338         
4339         * plugins/win/PluginPackageWin.cpp:
4340         (WebCore::PluginPackageWin::load):
4341         Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).
4342         
4343         * plugins/win/PluginStreamWin.cpp:
4344         (WebCore::PluginStreamWin::didFinishLoading):
4345         Handle the case where there was no plugin stream data at all.
4346
4347 2007-04-02  Anders Carlsson  <andersca@apple.com>
4348
4349         Reviewed by Darin.
4350
4351         Check that NPStream pointers passed to NPN_DestroyStream are valid.
4352         
4353         * plugins/win/PluginStreamWin.cpp:
4354         (WebCore::streams):
4355         (WebCore::PluginStreamWin::PluginStreamWin):
4356         (WebCore::PluginStreamWin::~PluginStreamWin):
4357         (WebCore::PluginStreamWin::ownerForStream):
4358         * plugins/win/PluginStreamWin.h:
4359         * plugins/win/PluginViewWin.cpp:
4360         (WebCore::PluginViewWin::destroyStream):
4361
4362 2007-04-02  Anders Carlsson  <andersca@apple.com>
4363
4364         Reviewed by Darin.
4365
4366         <rdar://problem/5095582>
4367         PluginViewWin doesn't implement NPN_DestroyStream.
4368
4369         * plugins/win/PluginStreamWin.cpp:
4370         (WebCore::PluginStreamWin::startStream):
4371         Handle the case where NPN_DestroyStream is called from the newstream handler.
4372         
4373         * plugins/win/PluginViewWin.cpp:
4374         (WebCore::PluginViewWin::destroyStream):
4375         Implement this.
4376
4377 2007-04-02  Anders Carlsson  <andersca@apple.com>
4378
4379         Reviewed by Dave Hyatt.
4380
4381         <rdar://problem/5097225> 
4382         Mouse cursors don't work with windowless plugins
4383         
4384         * platform/win/WidgetWin.cpp:
4385         (WebCore::Widget::setCursor):
4386         Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.
4387         
4388         * plugins/win/PluginViewWin.cpp:
4389         (WebCore::PluginViewWin::handleMouseEvent):
4390         Store away the current cursor and make sure that it won't be reset.
4391
4392 2007-04-02  Anders Carlsson  <andersca@apple.com>
4393
4394         Reviewed by Adam.
4395
4396         Fix logic in windowless paint functions.
4397         
4398         * plugins/win/PluginViewWin.cpp:
4399         (WebCore::PluginViewWin::invalidateRect):
4400         (WebCore::PluginViewWin::invalidateRegion):
4401         (WebCore::PluginViewWin::forceRedraw):
4402