Reviewed by darin
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
2
3         Reviewed by darin
4         
5         * editing/DeleteSelectionCommand.cpp:
6         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
7         * editing/Editor.cpp:
8         (WebCore::Editor::appliedEditing):
9         * editing/Editor.h:
10         (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
11
12 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
13
14         Reviewed by Oliver
15         
16         <rdar://problem/4820026>
17         copy/paste of news.google.com yields text from hidden select element options
18
19         We were adding descendants of unrendered select elements. 
20
21         * editing/markup.cpp:
22         (WebCore::createMarkup): Don't traverse into nodes without renderers, unless 
23         they are grandfathered in by a rendered select element.
24         
25 2006-11-12  Simon Hausmann  <hausmann@kde.org>
26
27         Reviewed by Sam Weinig.
28
29         Fix Qt build. Missing AbstractShared implementation.
30         http://bugs.webkit.org/show_bug.cgi?id=11581
31
32         * loader/qt/FrameLoaderClientQt.cpp:
33         (WebCore::FrameLoaderClientQt::ref):
34         (WebCore::FrameLoaderClientQt::deref):
35         * loader/qt/FrameLoaderClientQt.h:
36         * platform/qt/ChromeClientQt.cpp:
37         (WebCore::ChromeClientQt::ref):
38         (WebCore::ChromeClientQt::deref):
39         * platform/qt/ChromeClientQt.h:
40         * platform/qt/EditorClientQt.cpp:
41         (WebCore::EditorClientQt::ref):
42         (WebCore::EditorClientQt::deref):
43         * platform/qt/EditorClientQt.h:
44
45 2006-11-13  Mark Rowe  <bdash@webkit.org>
46
47         Reviewed by Mitz.
48
49         Fix some Linux/Gdk build issues noted by Alp Toker.
50
51         * Projects/gdk/webcore-gdk.bkl:
52         * WebCoreSources.bkl:
53         * platform/graphics/gdk/ImageGdk.cpp:
54         (WebCore::Image::loadPlatformResource):
55
56 2006-11-12  Brady Eidson <beidson@apple.com>
57
58         Reviewed by Anders
59
60         Logging channel plumbing for future work
61
62         * platform/Logging.cpp:
63         (WebCore::):
64         * platform/Logging.h:
65         * platform/mac/LoggingMac.mm:
66         (WebCore::InitializeLoggingChannelsIfNecessary):
67
68 2006-11-12  Mark Rowe  <bdash@webkit.org>
69
70         Reviewed by Mitz.
71
72         Linux/Gdk compilation fixes, and bakefile cleanups.  Based on patches by
73         Alp Toker.
74
75         * Projects/gdk/webcore-gdk.bkl:
76         * WebCoreSources.bkl:
77         * page/PageState.cpp:
78         * platform/gdk/ChromeClientGdk.h:
79         (WebCore::ChromeClientGdk::ref):
80         (WebCore::ChromeClientGdk::deref):
81         * platform/gdk/FrameGdk.cpp:
82         (WebCore::FrameGdkClientDefault::openURL):
83         (WebCore::FrameGdkClientDefault::didReceiveData):
84         (WebCore::FrameGdkClientDefault::receivedAllData):
85         (WebCore::FrameGdk::FrameGdk):
86         (WebCore::FrameGdk::~FrameGdk):
87         * platform/gdk/FrameGdk.h:
88         * platform/gdk/KeyEventGdk.cpp:
89         (WebCore::keyIdentifierForGdkKeyCode):
90         * platform/gdk/ScreenClientGdk.h: Removed.
91         * platform/gdk/TemporaryLinkStubs.cpp:
92         (FrameGdk::canPaste):
93         (FrameGdk::originalRequestURL):
94         (TextField::TextField):
95         * platform/network/gdk/ResourceHandleManager.cpp:
96         (WebCore::ResourceHandleManager::downloadTimerCallback):
97         (WebCore::ResourceHandleManager::add):
98         (WebCore::ResourceHandleManager::cancel):
99         * webcore-base.bkl:
100
101 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
102
103         Reviewed by Maciej Stachowiak.
104         
105         - Fixed loader crash by clarifying ownership of WebKit client objects. 
106         WebCore objects own their WebKit clients, and ref and deref through 
107         virtual methods, leaving WebKit free to use whatever client / reference-counting 
108         implementation it likes.
109         
110         * WebCore.exp:
111         * WebCore.xcodeproj/project.pbxproj:
112         * bridge/EditorClient.h: Fixed up function prototypes for style.
113         * loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
114         was to implement an alternative ownership model.
115         (WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
116         (WebCore::FrameLoader::setClient): This function now takes ownership
117         (WebCore::FrameLoader::client):
118         * loader/FrameLoader.h:
119         * loader/FrameLoaderClient.h:
120         * page/ChromeClient.h:
121         * platform/AbstractShared.h: Added. This is the virtual function-based refcounting
122         complement to Shared.
123         (WebCore::AbstractShared::~AbstractShared):
124
125 2006-11-11  George Staikos  <staikos@kde.org>
126
127         Reviewed by Maciej.
128
129         Fix uninitialized variable.
130
131         * rendering/RenderStyle.h:
132
133 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
134
135         Reviewed/landed by Adam.
136
137         Complete cleanup of the CMakeLists.txt.
138         Now all files to be built are sorted in alphabetic order.
139
140         General style cleanup, remove all tabs etc.
141
142         * CMakeLists.txt:
143
144 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
145
146         Reviewed by Maciej Stachowiak.
147         
148         Added missing initializer to ResourceRequest -- fixes some loader crashes
149         due to assuming a request always has a non-null httpMethod.
150
151         * platform/network/ResourceRequest.h:
152         (WebCore::ResourceRequest::ResourceRequest):
153
154 2006-11-11  Brady Eidson <beidson@apple.com>
155
156         Reviewed by Maciej
157
158         Fixed header guard
159
160         * loader/FrameLoaderClient.h:
161
162 2006-11-11  Darin Adler  <darin@apple.com>
163
164         - attempt to fix Qt build
165
166         * platform/qt/CursorQt.cpp:
167         (WebCore::verticalTextCursor): Added. Just returns pointer cursor.
168         (WebCore::cellCursor): Ditto.
169         (WebCore::contextMenuCursor): Ditto.
170
171 2006-11-11  Rob Buis  <buis@kde.org>
172
173         Reviewed by hyatt.
174
175         http://bugs.webkit.org/show_bug.cgi?id=10893
176         InsertRule can not handle @import statements
177
178         Allow @import as part of a css rule.
179
180         * css/CSSGrammar.y:
181         * css/CSSImportRule.cpp:
182         (WebCore::CSSImportRule::insertedIntoParent):
183         * css/CSSStyleSheet.cpp:
184         (WebCore::CSSStyleSheet::CSSStyleSheet):
185         (WebCore::CSSStyleSheet::checkLoaded):
186         * css/CSSStyleSheet.h:
187         (WebCore::CSSStyleSheet::loadCompleted):
188
189 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
190
191         Attempt to fix Qt build.
192
193         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
194
195 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
196
197         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
198
199         [CSS 3] support for vertical-text, cell and context-menu cursors
200         http://bugs.webkit.org/show_bug.cgi?id=11494
201
202         * Resources/cellCursor.png: Added.
203         * Resources/contextMenuCursor.png: Added.
204         * Resources/verticalTextCursor.png: Added.
205         * WebCore.xcodeproj/project.pbxproj:
206         * css/CSSComputedStyleDeclaration.cpp:
207         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
208         * css/CSSValueKeywords.in:
209         * manual-tests/cursor.html:
210         * page/FrameView.cpp:
211         (WebCore::selectCursor):
212         * platform/Cursor.h:
213         * platform/mac/CursorMac.mm:
214         (WebCore::verticalTextCursor):
215         (WebCore::cellCursor):
216         (WebCore::contextMenuCursor):
217         * rendering/RenderStyle.h:
218         (WebCore::):
219
220 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
221
222         Reviewed by aroben and ap, landed by ap.
223
224         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
225
226         Group graphics related files in platform/graphics.
227         Move certain files from certain subdirectories
228         into platform/graphics/{win,mac,cg,gdk,qt}
229
230         * CMakeLists.txt:
231         * WebCore.xcodeproj/project.pbxproj:
232         * platform/AffineTransform.cpp: Removed.
233         * platform/AffineTransform.h: Removed.
234         * platform/Color.cpp: Removed.
235         * platform/Color.h: Removed.
236         * platform/FloatPoint.cpp: Removed.
237         * platform/FloatPoint.h: Removed.
238         * platform/FloatRect.cpp: Removed.
239         * platform/FloatRect.h: Removed.
240         * platform/FloatSize.cpp: Removed.
241         * platform/FloatSize.h: Removed.
242         * platform/Icon.h: Removed.
243         * platform/Image.cpp: Removed.
244         * platform/Image.h: Removed.
245         * platform/ImageSource.h: Removed.
246         * platform/IntPoint.h: Removed.
247         * platform/IntRect.cpp: Removed.
248         * platform/IntRect.h: Removed.
249         * platform/IntSize.h: Removed.
250         * platform/IntSizeHash.h: Removed.
251         * platform/Path.cpp: Removed.
252         * platform/Path.h: Removed.
253         * platform/Pen.cpp: Removed.
254         * platform/Pen.h: Removed.
255         * platform/cairo/AffineTransformCairo.cpp: Removed.
256         * platform/cairo/GraphicsContextCairo.cpp: Removed.
257         * platform/cairo/ImageCairo.cpp: Removed.
258         * platform/cairo/ImageSourceCairo.cpp: Removed.
259         * platform/cairo/cairo/AUTHORS: Removed.
260         * platform/cairo/cairo/COPYING: Removed.
261         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
262         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
263         * platform/cairo/cairo/INSTALL: Removed.
264         * platform/cairo/cairo/NEWS: Removed.
265         * platform/cairo/cairo/README: Removed.
266         * platform/cairo/cairo/TODO: Removed.
267         * platform/cairo/cairo/src/Makefile.in: Removed.
268         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
269         * platform/cairo/cairo/src/cairo-arc.c: Removed.
270         * platform/cairo/cairo/src/cairo-array.c: Removed.
271         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
272         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
273         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
274         * platform/cairo/cairo/src/cairo-beos.h: Removed.
275         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
276         * platform/cairo/cairo/src/cairo-cache.c: Removed.
277         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
278         * platform/cairo/cairo/src/cairo-clip.c: Removed.
279         * platform/cairo/cairo/src/cairo-color.c: Removed.
280         * platform/cairo/cairo/src/cairo-debug.c: Removed.
281         * platform/cairo/cairo/src/cairo-debug.h: Removed.
282         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
283         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
284         * platform/cairo/cairo/src/cairo-features.h: Removed.
285         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
286         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
287         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
288         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
289         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
290         * platform/cairo/cairo/src/cairo-font.c: Removed.
291         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
292         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
293         * platform/cairo/cairo/src/cairo-ft.h: Removed.
294         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
295         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
296         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
297         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
298         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
299         * platform/cairo/cairo/src/cairo-hash.c: Removed.
300         * platform/cairo/cairo/src/cairo-hull.c: Removed.
301         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
302         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
303         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
304         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
305         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
306         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
307         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
308         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
309         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
310         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
311         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
312         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
313         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
314         * platform/cairo/cairo/src/cairo-path.c: Removed.
315         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
316         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
317         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
318         * platform/cairo/cairo/src/cairo-pen.c: Removed.
319         * platform/cairo/cairo/src/cairo-platform.h: Removed.
320         * platform/cairo/cairo/src/cairo-png.c: Removed.
321         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
322         * platform/cairo/cairo/src/cairo-private.h: Removed.
323         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
324         * platform/cairo/cairo/src/cairo-ps.h: Removed.
325         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
326         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
327         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
328         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
329         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
330         * platform/cairo/cairo/src/cairo-region.c: Removed.
331         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
332         * platform/cairo/cairo/src/cairo-slope.c: Removed.
333         * platform/cairo/cairo/src/cairo-spline.c: Removed.
334         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
335         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
336         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
337         * platform/cairo/cairo/src/cairo-surface.c: Removed.
338         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
339         * platform/cairo/cairo/src/cairo-svg.h: Removed.
340         * platform/cairo/cairo/src/cairo-traps.c: Removed.
341         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
342         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
343         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
344         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
345         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
346         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
347         * platform/cairo/cairo/src/cairo-win32.h: Removed.
348         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
349         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
350         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
351         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
352         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
353         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
354         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
355         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
356         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
357         * platform/cairo/cairo/src/cairo.c: Removed.
358         * platform/cairo/cairo/src/cairo.h: Removed.
359         * platform/cairo/cairo/src/cairoint.h: Removed.
360         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
361         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
362         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
363         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
364         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
365         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
366         * platform/cairo/pixman/AUTHORS: Removed.
367         * platform/cairo/pixman/COPYING: Removed.
368         * platform/cairo/pixman/README: Removed.
369         * platform/cairo/pixman/src/Makefile.in: Removed.
370         * platform/cairo/pixman/src/fbcompose.c: Removed.
371         * platform/cairo/pixman/src/fbedge.c: Removed.
372         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
373         * platform/cairo/pixman/src/fbmmx.c: Removed.
374         * platform/cairo/pixman/src/fbmmx.h: Removed.
375         * platform/cairo/pixman/src/fbpict.c: Removed.
376         * platform/cairo/pixman/src/fbpict.h: Removed.
377         * platform/cairo/pixman/src/fbtrap.c: Removed.
378         * platform/cairo/pixman/src/icblt.c: Removed.
379         * platform/cairo/pixman/src/icbltone.c: Removed.
380         * platform/cairo/pixman/src/iccolor.c: Removed.
381         * platform/cairo/pixman/src/icformat.c: Removed.
382         * platform/cairo/pixman/src/icimage.c: Removed.
383         * platform/cairo/pixman/src/icimage.h: Removed.
384         * platform/cairo/pixman/src/icint.h: Removed.
385         * platform/cairo/pixman/src/icpixels.c: Removed.
386         * platform/cairo/pixman/src/icrect.c: Removed.
387         * platform/cairo/pixman/src/icrop.h: Removed.
388         * platform/cairo/pixman/src/icstipple.c: Removed.
389         * platform/cairo/pixman/src/ictransform.c: Removed.
390         * platform/cairo/pixman/src/ictrap.c: Removed.
391         * platform/cairo/pixman/src/ictri.c: Removed.
392         * platform/cairo/pixman/src/icutil.c: Removed.
393         * platform/cairo/pixman/src/pixman-remap.h: Removed.
394         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
395         * platform/cairo/pixman/src/pixman.h: Removed.
396         * platform/cairo/pixman/src/pixregion.c: Removed.
397         * platform/cairo/pixman/src/pixregionint.h: Removed.
398         * platform/cairo/pixman/src/renderedge.c: Removed.
399         * platform/cairo/pixman/src/renderedge.h: Removed.
400         * platform/cairo/pixman/src/slim_internal.h: Removed.
401         * platform/cairo/rgb24-hacks.txt: Removed.
402         * platform/cairo/scale-removal.txt: Removed.
403         * platform/cg/AffineTransformCG.cpp: Removed.
404         * platform/cg/FloatPointCG.cpp: Removed.
405         * platform/cg/FloatRectCG.cpp: Removed.
406         * platform/cg/FloatSizeCG.cpp: Removed.
407         * platform/cg/GraphicsContextCG.cpp: Removed.
408         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
409         * platform/cg/ImageCG.cpp: Removed.
410         * platform/cg/ImageSourceCG.cpp: Removed.
411         * platform/cg/IntPointCG.cpp: Removed.
412         * platform/cg/IntRectCG.cpp: Removed.
413         * platform/cg/IntSizeCG.cpp: Removed.
414         * platform/cg/PDFDocumentImage.cpp: Removed.
415         * platform/cg/PDFDocumentImage.h: Removed.
416         * platform/cg/PathCG.cpp: Removed.
417         * platform/gdk/ImageGdk.cpp: Removed.
418         * platform/mac/ColorMac.mm: Removed.
419         * platform/mac/FloatPointMac.mm: Removed.
420         * platform/mac/FloatRectMac.mm: Removed.
421         * platform/mac/FloatSizeMac.mm: Removed.
422         * platform/mac/GraphicsContextMac.mm:
423         * platform/mac/IconMac.mm: Removed.
424         * platform/mac/ImageMac.mm: Removed.
425         * platform/mac/IntPointMac.mm: Removed.
426         * platform/mac/IntRectMac.mm: Removed.
427         * platform/mac/IntSizeMac.mm: Removed.
428         * platform/qt/AffineTransformQt.cpp: Removed.
429         * platform/qt/ColorQt.cpp: Removed.
430         * platform/qt/FloatPointQt.cpp: Removed.
431         * platform/qt/FloatRectQt.cpp: Removed.
432         * platform/qt/IconQt.cpp: Removed.
433         * platform/qt/ImageQt.cpp: Removed.
434         * platform/qt/ImageSourceQt.cpp: Removed.
435         * platform/qt/IntPointQt.cpp: Removed.
436         * platform/qt/IntRectQt.cpp: Removed.
437         * platform/qt/IntSizeQt.cpp: Removed.
438         * platform/qt/PathQt.cpp: Removed.
439         * platform/win/ImageWin.cpp: Removed.
440         * platform/win/IntPointWin.cpp: Removed.
441         * platform/win/IntRectWin.cpp: Removed.
442         * platform/win/IntSizeWin.cpp: Removed.
443
444 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
445
446         Reviewed by hyatt.
447
448         A layout test was added when this bug was fixed, so none needed now.
449         
450         Cleanup after:
451         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
452         http://bugs.webkit.org/show_bug.cgi?id=11570
453         
454         * rendering/RenderStyle.h:
455         (WebCore::RenderStyle::isSpace): Removed.
456         * rendering/RenderText.cpp:
457         (WebCore::isSpace): Added.
458         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
459
460 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
461
462         Reviewed by mitz.
463         
464         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
465         http://bugs.webkit.org/show_bug.cgi?id=11570
466
467         * rendering/RenderStyle.h:
468         (WebCore::RenderStyle::isSpace): Added.
469         * rendering/RenderText.cpp:
470         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
471         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
472
473 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
474
475         Reviewed by Maciej.
476
477         Added basic types for symbian platform.
478         http://bugs.webkit.org/show_bug.cgi?id=11540
479
480         * config.h:
481         * platform/AtomicString.h:
482         (WebCore::AtomicString::AtomicString):
483         (WebCore::AtomicString::operator TPtrC):
484         * platform/DeprecatedString.cpp:
485         (WebCore::initializeHandleNodeBlock):
486         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
487           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
488           bitfields and breaks byte aligment
489         * platform/FloatPoint.h:
490         * platform/FloatRect.h:
491         * platform/IntPoint.h:
492         * platform/IntRect.h:
493         * platform/IntSize.h:
494         * platform/PlatformString.h:
495         (WebCore::String::operator TPtrC):
496         (WebCore::String::des):
497         * platform/StringImpl.h:
498         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
499         (WebCore::DeprecatedString::setBufferFromDes):
500         (WebCore::DeprecatedString::fromDes):
501         (WebCore::DeprecatedString::des):
502         (WebCore::DeprecatedString::des8):
503         * platform/symbian/FloatPointSymbian.cpp: Added.
504         (WebCore::FloatPoint::FloatPoint):
505         (WebCore::FloatPoint::operator TPoint):
506         * platform/symbian/FloatRectSymbian.cpp: Added.
507         (WebCore::FloatRect::FloatRect):
508         (WebCore::FloatRect::operator TRect):
509         (WebCore::FloatRect::rect):
510         * platform/symbian/IntPointSymbian.cpp: Added.
511         (WebCore::IntPoint::IntPoint):
512         (WebCore::IntPoint::operator TPoint):
513         * platform/symbian/IntRectSymbian.cpp: Added.
514         (WebCore::IntRect::IntRect):
515         (WebCore::IntRect::operator TRect):
516         (WebCore::IntRect::Rect):
517         * platform/symbian/IntSizeSymbian.cpp: Added.
518         (WebCore::IntSize::IntSize):
519         (WebCore::IntSize::operator TSize):
520         * platform/symbian/StringImplSymbian.cpp: Added.
521         (WebCore::StringImpl::StringImpl):
522         (WebCore::StringImpl::des):
523         * platform/symbian/StringSymbian.cpp: Added.
524         (WebCore::String::String):
525
526 2006-11-10  Zack Rusin  <zack@kde.org>
527
528         Reviewed by Anders.
529
530         Adjust to the changes Brady made in the Qt code.
531
532         * loader/qt/FrameLoaderClientQt.cpp:
533         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
534         * loader/qt/FrameLoaderClientQt.h:
535
536 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
537
538         Reviewed by harrison
539         
540         <rdar://problem/4069359>
541         Deleting hyperlink text, then typing uses link typing style but loses the link itself
542         
543         The removed anchor element needs to stick around temporarily, in the same way
544         that the typing style hangs off the caret until the user moves it.  Also text
545         insertion around anchors didn't match TextEdit.
546
547         * editing/DeleteSelectionCommand.cpp:
548         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
549         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
550         * editing/DeleteSelectionCommand.h:
551         * editing/EditCommand.cpp:
552         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
553         editing command that doesn't preserve the typing style (matches TextEdit).
554         * editing/Editor.cpp:
555         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
556         setSelection with a message telling it to clear the typing style 
557         (and the saved anchor) here.  Save/restore the saved anchor because of this.
558         * editing/Editor.h:
559         (WebCore::Editor::removedAnchor): Getter.
560         (WebCore::Editor::setRemovedAnchor): Setter.
561         * editing/InsertTextCommand.cpp:
562         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
563         if one exists.
564         * editing/SelectionController.cpp:
565         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
566         we make a selection change that clears the typing style.
567         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
568         * editing/htmlediting.cpp:
569         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
570         made some changes to match TextEdit's behavior.  First, insert content
571         inside the anchor when the caret is after it, unless the caret is at the
572         end of the document, or if the caret is before it and at the start of a 
573         paragraph.
574
575 === Safari-521.30 ===
576
577 2006-11-10  Timothy Hatcher  <timothy@apple.com>
578
579         Reviewed by Hyatt.
580
581         Check for BHIDDEN in isVisible() also.
582
583         * rendering/RenderStyle.h:
584         (WebCore::BorderValue::isVisible):
585
586 2006-11-10  Timothy Hatcher  <timothy@apple.com>
587
588         Reviewed by Adam.
589
590         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
591
592         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
593
594         * editing/DeleteButtonController.cpp:
595         (WebCore::isDeletableElement):
596         * rendering/RenderStyle.h:
597         (WebCore::BorderValue::isVisible):
598
599 2006-11-10  Adam Roben  <aroben@apple.com>
600
601         Rubberstamped by Anders.
602
603         Back out some accidentally-committed changes from r17711.
604
605         * page/Frame.cpp:
606         (WebCore::Frame::command):
607         (WebCore::FramePrivate::FramePrivate):
608         * page/Frame.h:
609         * page/FramePrivate.h:
610
611 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
612
613         Reviewed by Geoff.
614
615         Add more commands, make toggleBold and toggleItalic executable commands.
616
617         * WebCore.exp:
618         * editing/Editor.cpp:
619         (WebCore::execCopy):
620         (WebCore::execCut):
621         (WebCore::execDelete):
622         (WebCore::execForwardDelete):
623         (WebCore::execPaste):
624         (WebCore::execSelectAll):
625         (WebCore::execToggleBold):
626         (WebCore::execToggleItalic):
627         (WebCore::enabled):
628         (WebCore::canPaste):
629         (WebCore::hasEditableSelection):
630         (WebCore::hasEditableRangeSelection):
631         (WebCore::hasRangeSelection):
632         (WebCore::hasRichlyEditableSelection):
633         (WebCore::CommandEntry::):
634         * editing/Editor.h:
635
636 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
637
638         Reviewed by Maciej, Geoff.
639
640         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
641         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
642
643         * WebCore.exp:
644         * bridge/mac/WebCoreFrameBridge.h:
645         * bridge/mac/WebCoreFrameBridge.mm:
646         * editing/Editor.cpp:
647         (WebCore::execMoveBackward):
648         (WebCore::execMoveBackwardAndModifySelection):
649         (WebCore::execMoveDown):
650         (WebCore::execMoveDownAndModifySelection):
651         (WebCore::execMoveForward):
652         (WebCore::execMoveForwardAndModifySelection):
653         (WebCore::execMoveLeft):
654         (WebCore::execMoveLeftAndModifySelection):
655         (WebCore::execMoveRight):
656         (WebCore::execMoveRightAndModifySelection):
657         (WebCore::execMoveToBeginningOfDocument):
658         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
659         (WebCore::execMoveToBeginningOfSentence):
660         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
661         (WebCore::execMoveToBeginningOfLine):
662         (WebCore::execMoveToBeginningOfLineAndModifySelection):
663         (WebCore::execMoveToBeginningOfParagraph):
664         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
665         (WebCore::execMoveToEndOfDocument):
666         (WebCore::execMoveToEndOfDocumentAndModifySelection):
667         (WebCore::execMoveToEndOfSentence):
668         (WebCore::execMoveToEndOfSentenceAndModifySelection):
669         (WebCore::execMoveToEndOfLine):
670         (WebCore::execMoveToEndOfLineAndModifySelection):
671         (WebCore::execMoveToEndOfParagraph):
672         (WebCore::execMoveToEndOfParagraphAndModifySelection):
673         (WebCore::execMoveParagraphBackwardAndModifySelection):
674         (WebCore::execMoveParagraphForwardAndModifySelection):
675         (WebCore::execMoveUp):
676         (WebCore::execMoveUpAndModifySelection):
677         (WebCore::execMoveWordBackward):
678         (WebCore::execMoveWordBackwardAndModifySelection):
679         (WebCore::execMoveWordForward):
680         (WebCore::execMoveWordForwardAndModifySelection):
681         (WebCore::execMoveWordLeft):
682         (WebCore::execMoveWordLeftAndModifySelection):
683         (WebCore::execMoveWordRight):
684         (WebCore::execMoveWordRightAndModifySelection):
685         (WebCore::enabledAnySelection):
686         (WebCore::createCommandMap):
687         (WebCore::CommandEntry::):
688         (WebCore::Editor::execCommand):
689         * editing/Editor.h:
690
691 2006-11-10  Brady Eidson  <beidson@apple.com>
692
693         Reviewed by Darin
694
695         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
696
697         * WebCore.exp:
698         * WebCore.xcodeproj/project.pbxproj:
699         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
700         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
701         * loader/FrameLoaderClient.h:
702         * loader/icon/IconDatabase.cpp:
703         (WebCore::IconDatabase::sharedIconDatabase):
704         (WebCore::IconDatabase::~IconDatabase):
705         * loader/icon/IconDatabase.h:
706         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
707         (WebCore::IconDatabase::enabled):
708         * loader/icon/IconLoader.cpp:
709         (WebCore::IconLoader::finishLoading):
710         * loader/mac/FrameLoaderMac.mm:
711
712 2006-11-10  Zack Rusin  <zack@kde.org>
713
714         Reviewed and landed by Anders.
715
716         Adjust platform Qt/KDE code to the recent loader
717         changes. 
718
719         * CMakeLists.txt:
720         * loader/DocumentLoader.h:
721         * loader/FrameLoader.cpp:
722         (WebCore::FrameLoader::createEmptyDocument):
723         * loader/FrameLoader.h:
724         * loader/FrameLoaderClient.h:
725         * loader/qt/DocumentLoaderQt.cpp: Added.
726         (WebCore::canonicalizedTitle):
727         (WebCore::DocumentLoader::DocumentLoader):
728         (WebCore::DocumentLoader::frameLoader):
729         (WebCore::DocumentLoader::~DocumentLoader):
730         (WebCore::DocumentLoader::URL):
731         (WebCore::DocumentLoader::unreachableURL):
732         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
733         (WebCore::DocumentLoader::isStopping):
734         (WebCore::DocumentLoader::clearErrors):
735         (WebCore::DocumentLoader::stopLoading):
736         (WebCore::DocumentLoader::setupForReplace):
737         (WebCore::DocumentLoader::commitIfReady):
738         (WebCore::DocumentLoader::finishedLoading):
739         (WebCore::DocumentLoader::setCommitted):
740         (WebCore::DocumentLoader::isCommitted):
741         (WebCore::DocumentLoader::setLoading):
742         (WebCore::DocumentLoader::isLoading):
743         (WebCore::DocumentLoader::doesProgressiveLoad):
744         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
745         (WebCore::DocumentLoader::updateLoading):
746         (WebCore::DocumentLoader::setFrame):
747         (WebCore::DocumentLoader::attachToFrame):
748         (WebCore::DocumentLoader::detachFromFrame):
749         (WebCore::DocumentLoader::prepareForLoadStart):
750         (WebCore::DocumentLoader::loadingStartedTime):
751         (WebCore::DocumentLoader::setIsClientRedirect):
752         (WebCore::DocumentLoader::isClientRedirect):
753         (WebCore::DocumentLoader::setPrimaryLoadComplete):
754         (WebCore::DocumentLoader::isLoadingInAPISense):
755         (WebCore::DocumentLoader::stopRecordingResponses):
756         (WebCore::DocumentLoader::title):
757         (WebCore::DocumentLoader::triggeringAction):
758         (WebCore::DocumentLoader::setTriggeringAction):
759         (WebCore::DocumentLoader::setOverrideEncoding):
760         (WebCore::DocumentLoader::overrideEncoding):
761         (WebCore::DocumentLoader::setTitle):
762         (WebCore::DocumentLoader::URLForHistory):
763         * loader/qt/FrameLoaderClientQt.cpp: Added.
764         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
765         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
766         (WebCore::FrameLoaderClientQt::detachFrameLoader):
767         (WebCore::FrameLoaderClientQt::hasWebView):
768         (WebCore::FrameLoaderClientQt::hasFrameView):
769         (WebCore::FrameLoaderClientQt::hasBackForwardList):
770         (WebCore::FrameLoaderClientQt::resetBackForwardList):
771         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
772         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
773         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
774         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
775         (WebCore::FrameLoaderClientQt::makeDocumentView):
776         (WebCore::FrameLoaderClientQt::makeRepresentation):
777         (WebCore::FrameLoaderClientQt::forceLayout):
778         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
779         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
780         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
781         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
782         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
783         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
784         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
785         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
786         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
787         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
788         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
789         (WebCore::FrameLoaderClientQt::willCloseDocument):
790         (WebCore::FrameLoaderClientQt::detachedFromParent1):
791         (WebCore::FrameLoaderClientQt::detachedFromParent2):
792         (WebCore::FrameLoaderClientQt::detachedFromParent3):
793         (WebCore::FrameLoaderClientQt::detachedFromParent4):
794         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
795         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
796         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
797         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
798         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
799         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
800         (WebCore::FrameLoaderClientQt::dispatchWillClose):
801         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
802         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
803         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
804         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
805         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
806         (WebCore::FrameLoaderClientQt::dispatchShow):
807         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
808         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
809         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
810         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
811         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
812         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
813         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
814         (WebCore::FrameLoaderClientQt::progressStarted):
815         (WebCore::FrameLoaderClientQt::progressCompleted):
816         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
817         (WebCore::FrameLoaderClientQt::willChangeTitle):
818         (WebCore::FrameLoaderClientQt::didChangeTitle):
819         (WebCore::FrameLoaderClientQt::finishedLoading):
820         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
821         (WebCore::FrameLoaderClientQt::setDefersLoading):
822         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
823         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
824         (WebCore::FrameLoaderClientQt::clearArchivedResources):
825         (WebCore::FrameLoaderClientQt::canShowMIMEType):
826         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
827         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
828         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
829         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
830         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
831         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
832         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
833         (WebCore::FrameLoaderClientQt::didFinishLoad):
834         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
835         (WebCore::FrameLoaderClientQt::setTitle):
836         (WebCore::FrameLoaderClientQt::userAgent):
837         * loader/qt/FrameLoaderClientQt.h: Added.
838         * loader/qt/FrameLoaderQt.cpp:
839         (WebCore::FrameLoader::submitForm):
840         (WebCore::FrameLoader::overrideMediaType):
841         (WebCore::FrameLoader::getHistoryLength):
842         (WebCore::FrameLoader::referrer):
843         (WebCore::FrameLoader::detachFromParent):
844         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
845         (WebCore::FrameLoader::goBackOrForward):
846         (WebCore::FrameLoader::historyURL):
847         (WebCore::FrameLoader::didFirstLayout):
848         (WebCore::FrameLoader::canGoBackOrForward):
849         (WebCore::FrameLoader::partClearedInBegin):
850         (WebCore::FrameLoader::saveDocumentState):
851         (WebCore::FrameLoader::restoreDocumentState):
852         (WebCore::FrameLoader::didChangeTitle):
853         (WebCore::FrameLoader::redirectDataToPlugin):
854         (WebCore::PolicyCheck::PolicyCheck):
855         (WebCore::PolicyCheck::clear):
856         (WebCore::PolicyCheck::set):
857         (WebCore::PolicyCheck::call):
858         (WebCore::PolicyCheck::clearRequest):
859         * loader/qt/NavigationActionQt.cpp: Added.
860         (WebCore::navigationType):
861         (WebCore::NavigationAction::NavigationAction):
862         * loader/qt/ResourceLoaderQt.cpp: Added.
863         (WebCore::ResourceLoader::ResourceLoader):
864         (WebCore::ResourceLoader::~ResourceLoader):
865         (WebCore::ResourceLoader::setDefersLoading):
866         (WebCore::ResourceLoader::cancel):
867         (WebCore::ResourceLoader::loadsBlocked):
868         * platform/MimeTypeRegistry.cpp:
869         (WebCore::initialiseSupportedImageMIMETypes):
870         * platform/network/qt/ResourceHandleManager.cpp:
871         (WebCore::ResourceHandleManager::slotResult):
872         (WebCore::ResourceHandleManager::cancel):
873         * platform/qt/ChromeClientQt.cpp: Added.
874         (WebCore::rootWindowForFrame):
875         (WebCore::ChromeClientQt::ChromeClientQt):
876         (WebCore::ChromeClientQt::~ChromeClientQt):
877         (WebCore::ChromeClientQt::setWindowRect):
878         (WebCore::ChromeClientQt::windowRect):
879         (WebCore::ChromeClientQt::pageRect):
880         (WebCore::ChromeClientQt::scaleFactor):
881         (WebCore::ChromeClientQt::focus):
882         (WebCore::ChromeClientQt::unfocus):
883         (WebCore::ChromeClientQt::createWindow):
884         (WebCore::ChromeClientQt::createModalDialog):
885         (WebCore::ChromeClientQt::show):
886         (WebCore::ChromeClientQt::canRunModal):
887         (WebCore::ChromeClientQt::runModal):
888         (WebCore::ChromeClientQt::setToolbarsVisible):
889         (WebCore::ChromeClientQt::toolbarsVisible):
890         (WebCore::ChromeClientQt::setStatusbarVisible):
891         (WebCore::ChromeClientQt::statusbarVisible):
892         (WebCore::ChromeClientQt::setScrollbarsVisible):
893         (WebCore::ChromeClientQt::scrollbarsVisible):
894         (WebCore::ChromeClientQt::setMenubarVisible):
895         (WebCore::ChromeClientQt::menubarVisible):
896         (WebCore::ChromeClientQt::setResizable):
897         * platform/qt/ChromeClientQt.h: Added.
898         * platform/qt/EditorClientQt.cpp:
899         (WebCore::EditorClientQt::shouldBeginEditing):
900         (WebCore::EditorClientQt::shouldEndEditing):
901         (WebCore::EditorClientQt::shouldApplyStyle):
902         (WebCore::EditorClientQt::didBeginEditing):
903         (WebCore::EditorClientQt::respondToChangedContents):
904         (WebCore::EditorClientQt::didEndEditing):
905         * platform/qt/EditorClientQt.h:
906         * platform/qt/FrameQt.cpp:
907         (WebCore::FrameQt::FrameQt):
908         (WebCore::FrameQt::~FrameQt):
909         (WebCore::FrameQt::keyEvent):
910         * platform/qt/FrameQt.h:
911         * platform/qt/FrameQtClient.cpp:
912         (WebCore::FrameQtClientDefault::openURL):
913         (WebCore::FrameQtClientDefault::didReceiveData):
914         (WebCore::FrameQtClientDefault::receivedAllData):
915         * platform/qt/ImageQt.cpp:
916         * platform/qt/MimeTypeRegistryQt.cpp: Added.
917         (WebCore::getMIMETypeForUTI):
918         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
919         * platform/qt/PageQt.cpp:
920         * platform/qt/PlatformKeyboardEventQt.cpp:
921         (WebCore::keyIdentifierForQtKeyCode):
922         * platform/qt/ScreenQt.cpp:
923         * platform/qt/TemporaryLinkStubs.cpp:
924         (WebCore::TextField::TextField):
925         (WebCore::screenDepth):
926         (WebCore::screenDepthPerComponent):
927         (WebCore::screenIsMonochrome):
928         (WebCore::screenRect):
929         (WebCore::screenAvailableRect):
930
931 2006-11-10  Brady Eidson <beidson@apple.com>
932
933         Reviewed by Mitz
934
935         http://bugs.webkit.org/show_bug.cgi?id=11554
936         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
937         in case the icon load fails after some data has been received. 
938
939         * loader/icon/IconLoader.cpp:
940         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
941         on error.  Also, as a loader re-factoring sanity check, added an assertion
942         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
943         is already committed to the DB.  Skip doing that step twice.
944
945 2006-11-09  Oliver Hunt  <oliver@apple.com>
946
947         Reviewed by Brady.
948
949         Pulled MIME type handling out of WebFrameBridge and added
950         a general C++ class to store/query MIME info
951         Added an Obj-C bridge to provide WebKit with access to the
952         MimeTypeRegistry for non-Obj-C++ classes.
953         
954         * WebCore.exp:
955         * WebCore.xcodeproj/project.pbxproj:
956         * bridge/mac/WebCoreFrameBridge.h:
957         * bridge/mac/WebCoreFrameBridge.mm:
958         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
959         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
960         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
961         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
962         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
963         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
964         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
965         * platform/Image.cpp:
966         (WebCore::Image::supportsType):
967         * platform/Image.h:
968         * platform/MimeTypeRegistry.cpp: Added.
969         (WebCore::initialiseSupportedImageMIMETypes):
970         (WebCore::initialiseSupportedNonImageMimeTypes):
971         (WebCore::initialiseMimeTypeRegistry):
972         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
973         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
974         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
975         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
976         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
977         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
978         * platform/MimeTypeRegistry.h: Added.
979         * platform/mac/ImageMac.mm:
980         * platform/mac/MimeTypeRegistryMac.mm: Added.
981         (WebCore::getMIMETypeForUTI):
982         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
983
984 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
985
986         Reviewed by Oliver.
987
988         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
989         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
990         for you and use vsnprintf.
991
992         * bindings/js/kjs_window.cpp:
993         (KJS::Window::isSafeScript):
994         * css/cssparser.cpp:
995         (WebCore::CSSParser::parseColorFromValue):
996         * dom/StyledElement.cpp:
997         (WebCore::StyledElement::addCSSColor):
998         * dom/XMLTokenizer.cpp:
999         (WebCore::XMLTokenizer::handleError):
1000         * ksvg2/css/SVGCSSParser.cpp:
1001         (WebCore::CSSParser::parseSVGPaint):
1002         (WebCore::CSSParser::parseSVGColor):
1003         * ksvg2/svg/SVGPathSegArc.h:
1004         (WebCore::SVGPathSegArcAbs::toString):
1005         (WebCore::SVGPathSegArcRel::toString):
1006         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1007         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
1008         (WebCore::SVGPathSegCurvetoCubicRel::toString):
1009         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1010         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
1011         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
1012         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1013         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
1014         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
1015         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1016         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
1017         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
1018         * ksvg2/svg/SVGPathSegLineto.h:
1019         (WebCore::SVGPathSegLinetoAbs::toString):
1020         (WebCore::SVGPathSegLinetoRel::toString):
1021         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1022         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
1023         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
1024         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1025         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
1026         (WebCore::SVGPathSegLinetoVerticalRel::toString):
1027         * ksvg2/svg/SVGPathSegMoveto.h:
1028         (WebCore::SVGPathSegMovetoAbs::toString):
1029         (WebCore::SVGPathSegMovetoRel::toString):
1030         * ksvg2/svg/SVGPolyElement.cpp:
1031         (WebCore::SVGPolyElement::notifyAttributeChange):
1032         * ksvg2/svg/SVGUseElement.cpp:
1033         (WebCore::SVGUseElement::closeRenderer):
1034         * loader/icon/IconDatabase.cpp:
1035         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
1036         * loader/icon/SQLDatabase.cpp:
1037         (WebCore::SQLDatabase::setSynchronous):
1038         * platform/Color.cpp:
1039         (WebCore::Color::name):
1040         * platform/DeprecatedString.cpp:
1041         (WebCore::DeprecatedString::setNum):
1042         (WebCore::DeprecatedString::format):
1043         * platform/DeprecatedString.h:
1044         * platform/PlatformString.h:
1045         * platform/String.cpp:
1046         (WebCore::String::format):
1047         (WebCore::String::number):
1048         * platform/mac/KeyEventMac.mm:
1049         (WebCore::keyIdentifierForKeyEvent):
1050         * platform/win/KeyEventWin.cpp:
1051         (WebCore::keyIdentifierForWindowsKeyCode):
1052         * rendering/RenderListMarker.cpp:
1053         (WebCore::RenderListMarker::calcMinMaxWidth):
1054
1055 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1056
1057         Reviewed by Anders.
1058
1059         - fixed "Regression: Can't log into gmail.com"
1060         - fixed "iBench doesn't report results - tests run but no number is recorded"
1061         
1062         * platform/network/cf/FormDataStreamCFNet.cpp:
1063         (WebCore::setHTTPBody): Removed extra ! character.
1064
1065 2006-11-09  Beth Dakin  <bdakin@apple.com>
1066
1067         Reviewed by Hyatt.
1068
1069         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
1070         WebCore::RenderBlock::skipWhitespace
1071
1072         Note that this will still crash on Debug builds because it will hit 
1073         an assertion failure in editing. (One of the reasons there is no 
1074         layout test along with this fix.) There is definitely some editing 
1075         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
1076         id=10144 for updates on the assertion failure bug.
1077
1078         * rendering/RootInlineBox.cpp:
1079         (WebCore::RootInlineBox::childRemoved): It is possible for a 
1080         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
1081         of just clearing the lineBreakObj of the prevRootBox, cycle through 
1082         all prevRootBoxs with the same lineBreakObj. 
1083
1084 2006-11-09  Adam Roben  <aroben@apple.com>
1085
1086         Reviewed by Geoff.
1087
1088         Fix the change in behavior I caused in r17680 with my build fix.
1089
1090         * rendering/RenderObject.cpp:
1091         (WebCore::RenderObject::maxTopMargin):
1092         (WebCore::RenderObject::maxBottomMargin):
1093
1094 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
1095
1096         Reviewed by Adam, Oliver.
1097
1098         Move more functions to Editor.
1099
1100         * bridge/EditorClient.h:
1101         * bridge/mac/FrameMac.h:
1102         * bridge/mac/FrameMac.mm:
1103         * bridge/mac/WebCoreFrameBridge.h:
1104         * editing/EditCommand.cpp:
1105         (WebCore::EditCommand::apply):
1106         (WebCore::EditCommand::unapply):
1107         (WebCore::EditCommand::reapply):
1108         * editing/Editor.cpp:
1109         (WebCore::Editor::respondToChangedContents):
1110         (WebCore::dispatchEditableContentChangedEvents):
1111         (WebCore::Editor::appliedEditing):
1112         (WebCore::Editor::unappliedEditing):
1113         (WebCore::Editor::reappliedEditing):
1114         * editing/Editor.h:
1115         * editing/TypingCommand.cpp:
1116         (WebCore::TypingCommand::typingAddedToOpenCommand):
1117         * page/Frame.cpp:
1118         * page/Frame.h:
1119
1120 2006-11-09  Darin Adler  <darin@apple.com>
1121
1122         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
1123
1124 2006-11-09  Alice Liu  <alice.liu@apple.com>
1125
1126         Reviewed by Beth Dakin.
1127
1128         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
1129         All existing layout tests pass
1130
1131         * html/HTMLTableElement.cpp:
1132         (WebCore::HTMLTableElement::deleteRow):
1133         check lastSection before deleting row
1134
1135 2006-11-09  Darin Adler  <darin@apple.com>
1136
1137         - improved version of last night's build fix (should not do using namespace in a header)
1138
1139         * rendering/RenderObject.h:
1140         * rendering/RenderObject.cpp:
1141         (WebCore::RenderObject::maxTopMargin):
1142         (WebCore::RenderObject::maxBottomMargin):
1143
1144 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
1145
1146         Reviewed by Geoff.
1147         
1148         - added ResourceError class and didFailWithError client method
1149
1150         * WebCore.xcodeproj/project.pbxproj:
1151         * loader/icon/IconLoader.cpp:
1152         (WebCore::IconLoader::didFailWithError):
1153         (WebCore::IconLoader::didFinishLoading):
1154         * loader/icon/IconLoader.h:
1155         * loader/loader.cpp:
1156         (WebCore::Loader::receivedAllData):
1157         (WebCore::Loader::didFailWithError):
1158         * loader/loader.h:
1159         * loader/mac/SubresourceLoaderMac.mm:
1160         (WebCore::SubresourceLoader::didFail):
1161         (WebCore::SubresourceLoader::didCancel):
1162         * platform/cf/RetainPtr.h:
1163         (WebCore::):
1164         (WebCore::adoptCFReference):
1165         (WebCore::RetainPtr::RetainPtr):
1166         (WebCore::::adopt):
1167         * platform/network/ResourceError.cpp: Added.
1168         * platform/network/ResourceError.h: Added.
1169         (WebCore::ResourceError::ResourceError):
1170         (WebCore::ResourceError::domain):
1171         (WebCore::ResourceError::errorCode):
1172         (WebCore::ResourceError::failingURL):
1173         (WebCore::ResourceError::localizedDescription):
1174         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
1175         * platform/network/ResourceHandle.cpp:
1176         * platform/network/ResourceHandle.h:
1177         * platform/network/ResourceHandleClient.h:
1178         (WebCore::ResourceHandleClient::didFailWithError):
1179         * platform/network/cf/ResourceHandleCFNet.cpp:
1180         (WebCore::didFail):
1181         (WebCore::ResourceHandle::cancel):
1182         * platform/network/mac/ResourceErrorMac.mm: Added.
1183         (-[NSError WebCore]):
1184         * platform/network/mac/ResourceHandleMac.mm:
1185         (WebCore::ResourceHandle::reportError):
1186         * xml/xmlhttprequest.cpp:
1187         (WebCore::XMLHttpRequest::didFailWithError):
1188         (WebCore::XMLHttpRequest::didFinishLoading):
1189         * xml/xmlhttprequest.h:
1190
1191 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1192
1193         Reviewed by Maciej.
1194
1195         Linux\Gdk fixes.
1196
1197         * platform/gdk/ChromeClientGdk.h:
1198         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1199         * platform/gdk/CursorGdk.cpp:
1200         (WebCore::Cursor::Cursor):
1201         (WebCore::moveCursor):
1202         * platform/gdk/FrameGdk.cpp:
1203         (WebCore::FrameGdk::FrameGdk):
1204         (WebCore::FrameGdk::submitForm):
1205         (WebCore::FrameGdk::urlSelected):
1206         * platform/gdk/PageGdk.cpp:
1207         * platform/gdk/ScreenClientGdk.h: Added.
1208         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1209         * platform/gdk/ScreenGdk.cpp:
1210         (WebCore::ScreenClientGdk::depth):
1211         (WebCore::ScreenClientGdk::depthPerComponent):
1212         (WebCore::ScreenClientGdk::isMonochrome):
1213         (WebCore::ScreenClientGdk::rect):
1214         (WebCore::ScreenClientGdk::usableRect):
1215         * platform/gdk/TemporaryLinkStubs.cpp:
1216         (FrameGdk::historyURL):
1217         (ChromeClientGdk::windowRect):
1218         (ChromeClientGdk::setWindowRect):
1219         (ChromeClientGdk::pageRect):
1220         (ChromeClientGdk::scaleFactor):
1221         (ChromeClientGdk::focus):
1222         (ChromeClientGdk::unfocus):
1223         (ChromeClientGdk::createWindow):
1224         (ChromeClientGdk::createModalDialog):
1225         (ChromeClientGdk::show):
1226         (ChromeClientGdk::canRunModal):
1227         (ChromeClientGdk::runModal):
1228         (ChromeClientGdk::setToolbarsVisible):
1229         (ChromeClientGdk::toolbarsVisible):
1230         (ChromeClientGdk::setStatusbarVisible):
1231         (ChromeClientGdk::statusbarVisible):
1232         (ChromeClientGdk::setScrollbarsVisible):
1233         (ChromeClientGdk::scrollbarsVisible):
1234         (ChromeClientGdk::setMenubarVisible):
1235         (ChromeClientGdk::menubarVisible):
1236         (ChromeClientGdk::setResizable):
1237         * platform/network/ResourceHandleInternal.h:
1238         (WebCore::ResourceHandleInternal::client):
1239         * platform/network/gdk/ResourceHandleManager.cpp:
1240         (WebCore::writeCallback):
1241         (WebCore::ResourceHandleManager::downloadTimerCallback):
1242         (WebCore::ResourceHandleManager::remove):
1243
1244 2006-11-08  Adam Roben  <aroben@apple.com>
1245
1246         Build fix.
1247
1248         * rendering/RenderObject.h:
1249         (WebCore::RenderObject::maxTopMargin):
1250         (WebCore::RenderObject::maxBottomMargin):
1251
1252 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1253
1254         Reviewed by Anders Carlsson.
1255
1256         Made Screen a good platform citizen by removing its reference to Page. This
1257         made a class unnecessary, so all screen fuctions are stand-alone now.
1258
1259         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
1260         when computing the screen's available dimensions.
1261
1262 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
1263
1264         Reviewed by Mitz.
1265
1266         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
1267         Cleanup RenderObject
1268
1269         * rendering/RenderObject.cpp:
1270         (WebCore::RenderObject::operator delete):
1271         (WebCore::RenderObject::createObject):
1272         (WebCore::RenderObjectCounter::~RenderObjectCounter):
1273         (WebCore::RenderObject::RenderObject):
1274         (WebCore::RenderObject::isDescendantOf):
1275         (WebCore::RenderObject::isRoot):
1276         (WebCore::RenderObject::addChild):
1277         (WebCore::RenderObject::removeChildNode):
1278         (WebCore::RenderObject::removeChild):
1279         (WebCore::RenderObject::appendChildNode):
1280         (WebCore::RenderObject::insertChildNode):
1281         (WebCore::RenderObject::nextInPreOrder):
1282         (WebCore::RenderObject::nextInPreOrderAfterChildren):
1283         (WebCore::RenderObject::previousInPreOrder):
1284         (WebCore::RenderObject::isEditable):
1285         (WebCore::RenderObject::nextEditable):
1286         (WebCore::RenderObject::previousEditable):
1287         (WebCore::RenderObject::firstLeafChild):
1288         (WebCore::RenderObject::lastLeafChild):
1289         (WebCore::RenderObject::addLayers):
1290         (WebCore::RenderObject::removeLayers):
1291         (WebCore::RenderObject::moveLayers):
1292         (WebCore::RenderObject::findNextLayer):
1293         (WebCore::RenderObject::enclosingLayer):
1294         (WebCore::RenderObject::updateFirstLetter):
1295         (WebCore::RenderObject::offsetParent):
1296         (WebCore::RenderObject::scroll):
1297         (WebCore::RenderObject::hasStaticX):
1298         (WebCore::RenderObject::setNeedsLayout):
1299         (WebCore::RenderObject::setChildNeedsLayout):
1300         (WebCore::RenderObject::markContainingBlocksForLayout):
1301         (WebCore::RenderObject::containingBlock):
1302         (WebCore::RenderObject::containingBlockWidth):
1303         (WebCore::RenderObject::containingBlockHeight):
1304         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
1305         (WebCore::RenderObject::drawBorderArc):
1306         (WebCore::RenderObject::drawBorder):
1307         (WebCore::RenderObject::paintBorderImage):
1308         (WebCore::RenderObject::paintBorder):
1309         (WebCore::RenderObject::absoluteRects):
1310         (WebCore::RenderObject::addPDFURLRect):
1311         (WebCore::RenderObject::addFocusRingRects):
1312         (WebCore::RenderObject::paintOutline):
1313         (WebCore::RenderObject::repaint):
1314         (WebCore::RenderObject::repaintRectangle):
1315         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
1316         (WebCore::RenderObject::repaintObjectsBeforeLayout):
1317         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
1318         (WebCore::RenderObject::information):
1319         (WebCore::RenderObject::dump):
1320         (WebCore::selectStartNode):
1321         (WebCore::RenderObject::shouldSelect):
1322         (WebCore::RenderObject::draggableNode):
1323         (WebCore::RenderObject::createAnonymousBlock):
1324         (WebCore::RenderObject::handleDynamicFloatPositionChange):
1325         (WebCore::RenderObject::setStyle):
1326         (WebCore::RenderObject::setStyleInternal):
1327         (WebCore::RenderObject::updateBackgroundImages):
1328         (WebCore::RenderObject::absolutePosition):
1329         (WebCore::RenderObject::caretRect):
1330         (WebCore::RenderObject::paddingTop):
1331         (WebCore::RenderObject::paddingBottom):
1332         (WebCore::RenderObject::paddingLeft):
1333         (WebCore::RenderObject::paddingRight):
1334         (WebCore::RenderObject::tabWidth):
1335         (WebCore::RenderObject::container):
1336         (WebCore::RenderObject::removeFromObjectLists):
1337         (WebCore::RenderObject::destroy):
1338         (WebCore::RenderObject::arenaDelete):
1339         (WebCore::RenderObject::hitTest):
1340         (WebCore::RenderObject::setInnerNode):
1341         (WebCore::RenderObject::nodeAtPoint):
1342         (WebCore::RenderObject::verticalPositionHint):
1343         (WebCore::RenderObject::getVerticalPosition):
1344         (WebCore::RenderObject::lineHeight):
1345         (WebCore::RenderObject::invalidateVerticalPositions):
1346         (WebCore::RenderObject::recalcMinMaxWidths):
1347         (WebCore::RenderObject::scheduleRelayout):
1348         (WebCore::RenderObject::setInlineBoxWrapper):
1349         (WebCore::RenderObject::firstLineStyle):
1350         (WebCore::RenderObject::getPseudoStyle):
1351         (WebCore::RenderObject::getTextDecorationColors):
1352         (WebCore::RenderObject::addDashboardRegions):
1353         (WebCore::RenderObject::collectDashboardRegions):
1354         (WebCore::RenderObject::avoidsFloats):
1355         (WebCore::RenderObject::findCounter):
1356         (WebCore::RenderObject::backslashAsCurrencySymbol):
1357         (WebCore::RenderObject::imageChanged):
1358         (WebCore::RenderObject::previousOffset):
1359         (WebCore::RenderObject::nextOffset):
1360         (WebCore::RenderObject::inlineBox):
1361         * rendering/RenderObject.h:
1362         (WebCore::):
1363         (WebCore::RenderObject::renderName):
1364         (WebCore::RenderObject::parent):
1365         (WebCore::RenderObject::previousSibling):
1366         (WebCore::RenderObject::nextSibling):
1367         (WebCore::RenderObject::firstChild):
1368         (WebCore::RenderObject::lastChild):
1369         (WebCore::RenderObject::getOverflowClipRect):
1370         (WebCore::RenderObject::getClipRect):
1371         (WebCore::RenderObject::getBaselineOfFirstLineBox):
1372         (WebCore::RenderObject::setEdited):
1373         (WebCore::RenderObject::setStaticX):
1374         (WebCore::RenderObject::setStaticY):
1375         (WebCore::RenderObject::setPreviousSibling):
1376         (WebCore::RenderObject::setNextSibling):
1377         (WebCore::RenderObject::setParent):
1378         (WebCore::RenderObject::isInlineBlockOrInlineTable):
1379         (WebCore::RenderObject::isRenderView):
1380         (WebCore::RenderObject::childrenInline):
1381         (WebCore::RenderObject::setChildrenInline):
1382         (WebCore::RenderObject::isAnonymousBlock):
1383         (WebCore::RenderObject::isDragging):
1384         (WebCore::RenderObject::needsLayout):
1385         (WebCore::RenderObject::setMinMaxKnown):
1386         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
1387         (WebCore::RenderObject::setPositioned):
1388         (WebCore::RenderObject::setRelPositioned):
1389         (WebCore::RenderObject::setFloating):
1390         (WebCore::RenderObject::setInline):
1391         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
1392         (WebCore::RenderObject::setReplaced):
1393         (WebCore::RenderObject::PaintInfo::PaintInfo):
1394         (WebCore::RenderObject::paintBackgroundExtended):
1395         (WebCore::RenderObject::calcWidth):
1396         (WebCore::RenderObject::updateFromElement):
1397         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
1398         (WebCore::RenderObject::setOverrideSize):
1399         (WebCore::RenderObject::setPos):
1400         (WebCore::RenderObject::setWidth):
1401         (WebCore::RenderObject::setHeight):
1402         (WebCore::RenderObject::absolutePositionForContent):
1403         (WebCore::RenderObject::overflowHeight):
1404         (WebCore::RenderObject::overflowWidth):
1405         (WebCore::RenderObject::setOverflowHeight):
1406         (WebCore::RenderObject::setOverflowWidth):
1407         (WebCore::RenderObject::overflowLeft):
1408         (WebCore::RenderObject::overflowTop):
1409         (WebCore::RenderObject::overflowRect):
1410         (WebCore::RenderObject::stopAutoscroll):
1411         (WebCore::RenderObject::collapsedMarginTop):
1412         (WebCore::RenderObject::collapsedMarginBottom):
1413         (WebCore::RenderObject::maxTopMargin):
1414         (WebCore::RenderObject::maxBottomMargin):
1415         (WebCore::RenderObject::):
1416         (WebCore::RenderObject::setTable):
1417         (WebCore::RenderObject::isFloatingOrPositioned):
1418         (WebCore::RenderObject::containsFloat):
1419         (WebCore::RenderObject::setSelectionState):
1420         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
1421         (WebCore::RenderObject::lowestPosition):
1422         (WebCore::RenderObject::rightmostPosition):
1423         (WebCore::RenderObject::leftmostPosition):
1424         (WebCore::RenderObject::calcVerticalMargins):
1425         (WebCore::RenderObject::font):
1426
1427 2006-11-08  Darin Adler  <darin@apple.com>
1428
1429         Reviewed by Anders.
1430
1431         - added event parameters to focus-related functions so we can
1432           implement the "option-tab to all links" behavior without relying
1433           on a global "current event" -- also makes it work with DOM events
1434
1435         * page/Frame.h: Removed unneeded includes. Moved some functions
1436         that were misplaced into the appropriate sections.
1437         * page/Frame.cpp:
1438         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
1439         PlatformKeyboardEvent to the DOM keyboard event class.
1440         (WebCore::Frame::tabsToLinks): Added event parameter.
1441         (WebCore::Frame::tabsToAllControls): Ditto.
1442         (WebCore::scanForForm): Fixed code that incorrectly assumes
1443         that an iframe is an HTMLFrameElement (no longer true since Geoff
1444         changed the class hierarchy a bit).
1445         (WebCore::Frame::hitTestResultAtPoint): Ditto.
1446
1447         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
1448         that were misplaced into the appropriate sections.
1449         * bridge/mac/FrameMac.mm:
1450         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
1451         a PlatformKeyboardEvent.
1452         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
1453         and pass event into next/previousFocusNode.
1454         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
1455         the AppKit current event, if it's a keyboard event. Really just a hack that's
1456         needed to preserve some code we can remove once we deal with the last NSView-
1457         based form control.
1458         (WebCore::isKeyboardOptionTab): Added.
1459         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
1460         option (alt) key is down.
1461         (WebCore::FrameMac::tabsToAllControls): Ditto.
1462         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
1463         call resetMultipleFormSubmissionProtection() explicitly instead.
1464         (WebCore::FrameMac::mouseDown): Ditto.
1465
1466         * bridge/mac/WebCoreAXObject.mm:
1467         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
1468         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
1469         changed the class hierarchy a bit).
1470         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
1471         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
1472         explicitly instead.
1473
1474         * page/FrameView.h:
1475         * page/FrameView.cpp:
1476         (WebCore::FrameView::advanceFocus): Changed function to take an
1477         event parameter, and decide the direction based on the shift key
1478         modifier instead of a passed-in boolean.
1479
1480         * dom/Document.h:
1481         * dom/Document.cpp:
1482         (WebCore::Document::nextFocusNode): Added event parameter.
1483         (WebCore::Document::previousFocusNode): Ditto.
1484         * dom/Node.h:
1485         * dom/Node.cpp:
1486         (WebCore::Node::isKeyboardFocusable): Ditto.
1487         * html/HTMLAnchorElement.h:
1488         * html/HTMLAnchorElement.cpp:
1489         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
1490         * html/HTMLGenericFormElement.h:
1491         * html/HTMLGenericFormElement.cpp:
1492         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
1493         * html/HTMLInputElement.h:
1494         * html/HTMLInputElement.cpp:
1495         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
1496         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
1497         * html/HTMLSelectElement.h:
1498         * html/HTMLSelectElement.cpp:
1499         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
1500         * html/HTMLTextAreaElement.h:
1501         * html/HTMLTextAreaElement.cpp:
1502         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
1503
1504         * dom/EventTargetNode.cpp:
1505         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
1506         advanceFocus function.
1507
1508         * platform/TextField.h:
1509         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
1510
1511         * platform/mac/WebCoreTextField.h:
1512         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
1513         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
1514         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
1515         needed since the default handler in HTMLInputElement takes care of
1516         option-tab.
1517
1518         * platform/mac/SliderMac.mm:
1519         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
1520         and pass event into tabsToAllControls.
1521         (Slider::focusPolicy): Ditto.
1522
1523         * rendering/RenderLineEdit.cpp:
1524         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
1525         (WebCore::RenderLineEdit::updateFromElement): Ditto.
1526
1527 2006-11-08  Brady Eidson  <beidson@apple.com>
1528
1529         Reviewed by Dave Harrison, Oliver, and Darin 
1530         (oh my!  where was superkevin on this one?)
1531
1532         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
1533
1534         More "free nil checking" we lost in the transition from ObjC to C++
1535
1536         * loader/mac/FrameLoaderMac.mm:
1537         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
1538         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
1539
1540 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1541
1542         Reviewed by Adam.
1543
1544         Move more code into editor.
1545         
1546         * WebCore.exp:
1547         * bridge/EditorClient.h:
1548         * bridge/mac/FrameMac.h:
1549         * bridge/mac/FrameMac.mm:
1550         * bridge/mac/WebCoreFrameBridge.h:
1551         * dom/Document.cpp:
1552         (WebCore::Document::relinquishesEditingFocus):
1553         (WebCore::Document::acceptsEditingFocus):
1554         (WebCore::Document::didBeginEditing):
1555         (WebCore::Document::didEndEditing):
1556         * editing/Editor.cpp:
1557         (WebCore::Editor::indent):
1558         (WebCore::Editor::outdent):
1559         * editing/Editor.h:
1560         * page/Frame.cpp:
1561         * page/Frame.h:
1562
1563 2006-11-08  Beth Dakin  <bdakin@apple.com>
1564
1565         Reviewed by Adam.
1566
1567         Add ability to HitTestResult to ask if the inner non-shared node is 
1568         content editable.
1569
1570         * WebCore.exp: Export HitTestResult::isContentEditable()
1571         * rendering/HitTestResult.cpp:
1572         (WebCore::HitTestResult::isContentEditable):
1573         * rendering/HitTestResult.h:
1574
1575 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1576
1577         Build fix.
1578         
1579         * WebCore.xcodeproj/project.pbxproj:
1580         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
1581
1582 2006-11-08  Timothy Hatcher  <timothy@apple.com>
1583
1584         Reviewed by Darin.
1585
1586         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
1587         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
1588
1589         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
1590
1591         * bindings/objc/DOM.mm:
1592         (WebCore::kit):
1593         (-[DOMNode lineBoxRects]):
1594         (-[DOMRange boundingBox]):
1595         (-[DOMRange lineBoxRects]):
1596         * bindings/objc/DOMPrivate.h:
1597         * dom/Range.cpp:
1598         (WebCore::Range::boundingBox):
1599         (WebCore::Range::addLineBoxRects):
1600         * dom/Range.h:
1601         * rendering/RenderContainer.cpp:
1602         (WebCore::RenderContainer::addLineBoxRects):
1603         * rendering/RenderContainer.h:
1604         * rendering/RenderObject.cpp:
1605         (WebCore::RenderObject::addLineBoxRects):
1606         * rendering/RenderObject.h:
1607         * rendering/RenderText.cpp:
1608         (WebCore::RenderText::addLineBoxRects):
1609         * rendering/RenderText.h:
1610
1611 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1612
1613         Reviewed by Oliver.
1614         
1615         Move methods from the bridge and frame into editor.
1616         
1617         * WebCore.exp:
1618         * bridge/EditorClient.h:
1619         * bridge/mac/WebCoreFrameBridge.h:
1620         * bridge/mac/WebCoreFrameBridge.mm:
1621         * editing/Editor.cpp:
1622         (WebCore::Editor::removeFormattingAndStyle):
1623         (WebCore::Editor::applyStyle):
1624         (WebCore::Editor::applyParagraphStyle):
1625         (WebCore::Editor::applyStyleToSelection):
1626         (WebCore::Editor::applyParagraphStyleToSelection):
1627         (WebCore::Editor::toggleBold):
1628         (WebCore::Editor::toggleItalic):
1629         (WebCore::Editor::selectionStartHasStyle):
1630         * editing/Editor.h:
1631         * editing/JSEditor.cpp:
1632         * page/Frame.cpp:
1633         * page/Frame.h:
1634
1635 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1636
1637         Reviewed by Beth.
1638         
1639         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
1640         be able to dispatch user events even when off-screen, so we have to support
1641         off-screen windows when handling mouse events.
1642
1643         * platform/Screen.h:
1644         * platform/mac/PlatformMouseEventMac.mm:
1645         (WebCore::globalPoint): Grab the best screen instead of the screen you're
1646         on, since you might be off-screen.
1647         * platform/mac/ScreenMac.mm:
1648         (WebCore::screenForWindow):
1649
1650 2006-11-08  Darin Adler  <darin@apple.com>
1651
1652         - fix bug caused by last-minute change to my check-in last night
1653           that is causing layout tests to hang
1654
1655         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
1656         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
1657         a null string into an empty string before calling completeURL.
1658
1659 2006-11-08  Brady Eidson <beidson@apple.com>
1660
1661         Reviewed by Maciej
1662
1663         If the request has already been aborted, bail out of didFinishLoading()
1664         immediately.  This prevents state change notifications that aren't
1665         needed.
1666
1667         * xml/xmlhttprequest.cpp:
1668         (WebCore::XMLHttpRequest::didFinishLoading):
1669
1670 2006-11-08  Darin Adler  <darin@apple.com>
1671
1672         - another attempt to fix Qt build
1673
1674         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
1675
1676 2006-11-08  Darin Adler  <darin@apple.com>
1677
1678         Reviewed by Geoff.
1679
1680         - stray bits of my FrameLoader patch that I left out by accident
1681
1682         * loader/FrameLoader.cpp:
1683         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
1684         inside the FrameLoader class.
1685         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
1686         (WebCore::FrameLoader::clear): Stop the redirection timer.
1687         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
1688         entire function in an if statement. Use less DeprecatedString.
1689         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
1690         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1691         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
1692         inside the FrameLoader class.
1693         * loader/mac/FrameLoaderMac.mm:
1694         (WebCore::FrameLoader::load): Ditto.
1695         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
1696
1697 2006-11-07  Beth Dakin  <bdakin@apple.com>
1698
1699         Reviewed by Hyatt.
1700
1701         Another go at fix for <rdar://problem/4820814> A crash occurs at 
1702         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1703         iframe at www.macsurfer.com
1704
1705         The fix from yesterday caused a layout test regression which 
1706         exposed an existing bug. The existing bug was that we allowed text 
1707         nodes to stay in the head tag, but other browsers move them to the 
1708         body. The previous fix also caused a performance regression, which 
1709         was seemingly easy to fix by moving the new clause in 
1710         HTMLParser::handleError() to be below the HTMLElement case.
1711
1712         * html/HTMLDocument.cpp:
1713         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
1714         be the child of the document.
1715         * html/HTMLHeadElement.cpp:
1716         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
1717         whitespace text nodes to be children of the head.
1718         * html/HTMLHeadElement.h:
1719         * html/HTMLParser.cpp:
1720         (WebCore::HTMLParser::handleError): Error case for comment nodes.
1721         * page/FrameView.cpp:
1722         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
1723         for the original crash. 
1724
1725 2006-11-07  Darin Adler  <darin@apple.com>
1726
1727         - another attempt to fix Qt build
1728
1729         * loader/icon/IconLoader.h: Added missing include.
1730
1731 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1732
1733         Reviewed by Tim Hatcher.
1734         
1735         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1736         
1737         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1738         so WebCore can handle it all.
1739         
1740         Moved Screen back from page/ to platform/ because it's a platform
1741         abstraction again.
1742
1743         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
1744         since the two were always used together.
1745         
1746         Changed pixel depth queries to query the deepest screen. Darin mentioned
1747         that it might have been a feature, not a bug, to use the main/menubar screen
1748         regardless of the screen you were on. For scaling and flipping that's not
1749         the case, but for querying pixel depth I think it is. You want to know
1750         about the highest pixel depth your content may display on.
1751         
1752         Tests still pass.
1753
1754         * WebCore.exp:
1755         * WebCore.xcodeproj/project.pbxproj:
1756         * page/Page.cpp:
1757         (WebCore::Page::Page):
1758         * page/Page.h:
1759         * page/Screen.cpp: Removed.
1760         * page/Screen.h: Removed.
1761         * page/ScreenClient.h: Removed.
1762         * platform/mac/PlatformMouseEventMac.mm:
1763         (WebCore::globalPoint):
1764         * platform/mac/ScreenMac.mm:
1765         (WebCore::window):
1766         (WebCore::bestScreen):
1767         (WebCore::Screen::depth):
1768         (WebCore::Screen::depthPerComponent):
1769         (WebCore::Screen::isMonochrome):
1770         (WebCore::Screen::rect):
1771         (WebCore::Screen::usableRect):
1772         (WebCore::toUserSpace):
1773         (WebCore::toDeviceSpace):
1774
1775 2006-11-07  Darin Adler  <darin@apple.com>
1776
1777         - try to fix Qt build
1778
1779         * CMakeLists.txt: Updated for some file changes.
1780         * WebCoreSources.bkl: Ditto.
1781
1782 2006-11-07  Darin Adler  <darin@apple.com>
1783
1784         Reviewed by Geoff.
1785
1786         - moved loader code from Frame/FrameMac to FrameLoader
1787
1788         * WebCore.exp:
1789         * WebCore.xcodeproj/project.pbxproj:
1790         * bindings/js/JSXSLTProcessor.h:
1791         * bindings/js/kjs_events.cpp:
1792         (KJS::JSLazyEventListener::parseCode):
1793         * bindings/js/kjs_html.cpp:
1794         (KJS::JSHTMLDocument::putValueProperty):
1795         * bindings/js/kjs_navigator.cpp:
1796         (KJS::Navigator::getValueProperty):
1797         * bindings/js/kjs_proxy.cpp:
1798         (WebCore::KJSProxy::initScriptIfNeeded):
1799         * bindings/js/kjs_window.cpp:
1800         (KJS::Screen::Screen):
1801         (KJS::createNewWindow):
1802         (KJS::Window::getValueProperty):
1803         (KJS::Window::put):
1804         (KJS::Window::isSafeScript):
1805         (KJS::WindowFunc::callAsFunction):
1806         (KJS::ScheduledAction::execute):
1807         (KJS::Location::getValueProperty):
1808         (KJS::Location::put):
1809         (KJS::Location::toString):
1810         (KJS::LocationFunc::callAsFunction):
1811         (KJS::History::getValueProperty):
1812         (KJS::HistoryFunc::callAsFunction):
1813         * bindings/objc/DOM.mm:
1814         (+[DOMNode _nodeWith:WebCore::]):
1815         * bridge/mac/FrameMac.h:
1816         * bridge/mac/FrameMac.mm:
1817         (WebCore::FrameMac::~FrameMac):
1818         (WebCore::FrameMac::setView):
1819         (WebCore::FrameMac::setStatusBarText):
1820         * bridge/mac/WebCoreFrameBridge.h:
1821         * bridge/mac/WebCoreFrameBridge.mm:
1822         (-[WebCoreFrameBridge close]):
1823         (-[WebCoreFrameBridge addData:]):
1824         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
1825         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
1826         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1827         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1828         (-[WebCoreFrameBridge baseURL]):
1829         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1830         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
1831         (-[WebCoreFrameBridge canProvideDocumentSource]):
1832         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1833         * css/cssparser.cpp:
1834         (WebCore::CSSParser::parseContent):
1835         * dom/DOMImplementation.cpp:
1836         (WebCore::DOMImplementation::createDocument):
1837         (WebCore::DOMImplementation::createHTMLDocument):
1838         * dom/DOMImplementation.h:
1839         * dom/Document.cpp:
1840         (WebCore::Document::readyState):
1841         (WebCore::Document::updateTitle):
1842         (WebCore::Document::open):
1843         (WebCore::Document::close):
1844         (WebCore::Document::implicitClose):
1845         (WebCore::Document::processHttpEquiv):
1846         (WebCore::Document::referrer):
1847         (WebCore::Document::finishedParsing):
1848         * dom/ProcessingInstruction.cpp:
1849         (WebCore::ProcessingInstruction::checkStyleSheet):
1850         * dom/XMLTokenizer.cpp:
1851         (WebCore::XMLTokenizer::endElementNs):
1852         (WebCore::ignorableWhitespaceHandler):
1853         (WebCore::XMLTokenizer::notifyFinished):
1854         * editing/TextIterator.cpp:
1855         (WebCore::TextIterator::rangeFromLocationAndLength):
1856         * html/HTMLAnchorElement.cpp:
1857         (WebCore::HTMLAnchorElement::defaultEventHandler):
1858         * html/HTMLBaseElement.cpp:
1859         (WebCore::HTMLBaseElement::process):
1860         * html/HTMLDocument.cpp:
1861         (WebCore::HTMLDocument::lastModified):
1862         * html/HTMLFormElement.cpp:
1863         (WebCore::HTMLFormElement::formData):
1864         (WebCore::HTMLFormElement::submit):
1865         * html/HTMLFrameElementBase.cpp:
1866         (WebCore::HTMLFrameElementBase::isURLAllowed):
1867         (WebCore::HTMLFrameElementBase::openURL):
1868         (WebCore::HTMLFrameElementBase::willRemove):
1869         * html/HTMLInputElement.cpp:
1870         (WebCore::HTMLInputElement::setValueFromRenderer):
1871         * html/HTMLLinkElement.cpp:
1872         (WebCore::HTMLLinkElement::process):
1873         * html/HTMLParser.cpp:
1874         (WebCore::HTMLParser::handleError):
1875         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1876         * html/HTMLPreElement.idl:
1877         * html/HTMLScriptElement.cpp:
1878         (WebCore::HTMLScriptElement::parseMappedAttribute):
1879         (WebCore::HTMLScriptElement::insertedIntoDocument):
1880         * html/HTMLTokenizer.cpp:
1881         (WebCore::HTMLTokenizer::scriptExecution):
1882         (WebCore::HTMLTokenizer::parseTag):
1883         (WebCore::HTMLTokenizer::write):
1884         (WebCore::HTMLTokenizer::stopParsing):
1885         (WebCore::HTMLTokenizer::timerFired):
1886         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1887         (WebCore::KCanvasFilterQuartz::prepareFilter):
1888         * ksvg2/svg/SVGAElement.cpp:
1889         (WebCore::SVGAElement::defaultEventHandler):
1890         * ksvg2/svg/SVGElement.cpp:
1891         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1892         * loader/DocLoader.cpp:
1893         (WebCore::DocLoader::setLoadInProgress):
1894         * loader/FrameLoader.cpp:
1895         (WebCore::FormSubmission::FormSubmission):
1896         (WebCore::ScheduledRedirection::):
1897         (WebCore::ScheduledRedirection::ScheduledRedirection):
1898         (WebCore::cancelAll):
1899         (WebCore::getString):
1900         (WebCore::isBackForwardLoadType):
1901         (WebCore::numRequests):
1902         (WebCore::FrameLoader::FrameLoader):
1903         (WebCore::FrameLoader::~FrameLoader):
1904         (WebCore::FrameLoader::createWindow):
1905         (WebCore::FrameLoader::changeLocation):
1906         (WebCore::FrameLoader::urlSelected):
1907         (WebCore::FrameLoader::requestFrame):
1908         (WebCore::FrameLoader::loadSubframe):
1909         (WebCore::FrameLoader::submitFormAgain):
1910         (WebCore::FrameLoader::submitForm):
1911         (WebCore::FrameLoader::stopLoading):
1912         (WebCore::FrameLoader::stop):
1913         (WebCore::FrameLoader::closeURL):
1914         (WebCore::FrameLoader::cancelRedirection):
1915         (WebCore::FrameLoader::iconURL):
1916         (WebCore::FrameLoader::didOpenURL):
1917         (WebCore::FrameLoader::didExplicitOpen):
1918         (WebCore::FrameLoader::replaceContentsWithScriptResult):
1919         (WebCore::FrameLoader::executeScript):
1920         (WebCore::FrameLoader::cancelAndClear):
1921         (WebCore::FrameLoader::clear):
1922         (WebCore::FrameLoader::receivedFirstData):
1923         (WebCore::FrameLoader::responseMIMEType):
1924         (WebCore::FrameLoader::setResponseMIMEType):
1925         (WebCore::FrameLoader::begin):
1926         (WebCore::FrameLoader::write):
1927         (WebCore::FrameLoader::end):
1928         (WebCore::FrameLoader::endIfNotLoading):
1929         (WebCore::FrameLoader::startIconLoader):
1930         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1931         (WebCore::FrameLoader::gotoAnchor):
1932         (WebCore::FrameLoader::finishedParsing):
1933         (WebCore::FrameLoader::loadDone):
1934         (WebCore::FrameLoader::checkCompleted):
1935         (WebCore::FrameLoader::checkEmitLoadEvent):
1936         (WebCore::FrameLoader::baseURL):
1937         (WebCore::FrameLoader::baseTarget):
1938         (WebCore::FrameLoader::completeURL):
1939         (WebCore::FrameLoader::scheduleRedirection):
1940         (WebCore::FrameLoader::scheduleLocationChange):
1941         (WebCore::FrameLoader::scheduleRefresh):
1942         (WebCore::FrameLoader::isScheduledLocationChangePending):
1943         (WebCore::FrameLoader::scheduleHistoryNavigation):
1944         (WebCore::FrameLoader::redirectionTimerFired):
1945         (WebCore::FrameLoader::encoding):
1946         (WebCore::FrameLoader::requestObject):
1947         (WebCore::FrameLoader::shouldUsePlugin):
1948         (WebCore::FrameLoader::loadPlugin):
1949         (WebCore::FrameLoader::clearRecordedFormValues):
1950         (WebCore::FrameLoader::recordFormValue):
1951         (WebCore::FrameLoader::parentCompleted):
1952         (WebCore::FrameLoader::outgoingReferrer):
1953         (WebCore::FrameLoader::lastModified):
1954         (WebCore::FrameLoader::opener):
1955         (WebCore::FrameLoader::setOpener):
1956         (WebCore::FrameLoader::openedByJavaScript):
1957         (WebCore::FrameLoader::setOpenedByJavaScript):
1958         (WebCore::FrameLoader::handleFallbackContent):
1959         (WebCore::FrameLoader::provisionalLoadStarted):
1960         (WebCore::FrameLoader::userGestureHint):
1961         (WebCore::FrameLoader::didNotOpenURL):
1962         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
1963         (WebCore::FrameLoader::setEncoding):
1964         (WebCore::FrameLoader::addData):
1965         (WebCore::FrameLoader::canCachePage):
1966         (WebCore::FrameLoader::updatePolicyBaseURL):
1967         (WebCore::FrameLoader::setPolicyBaseURL):
1968         (WebCore::FrameLoader::scrollToAnchor):
1969         (WebCore::FrameLoader::isComplete):
1970         (WebCore::FrameLoader::isLoadingMainResource):
1971         (WebCore::FrameLoader::url):
1972         (WebCore::FrameLoader::startRedirectionTimer):
1973         (WebCore::FrameLoader::stopRedirectionTimer):
1974         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
1975         (WebCore::FrameLoader::completed):
1976         (WebCore::FrameLoader::started):
1977         (WebCore::FrameLoader::containsPlugins):
1978         (WebCore::FrameLoader::prepareForLoadStart):
1979         (WebCore::FrameLoader::setupForReplace):
1980         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1981         (WebCore::FrameLoader::finalSetupForReplace):
1982         (WebCore::FrameLoader::load):
1983         (WebCore::FrameLoader::canTarget):
1984         (WebCore::FrameLoader::stopLoadingPlugIns):
1985         (WebCore::FrameLoader::stopLoadingSubresources):
1986         (WebCore::FrameLoader::stopLoadingSubframes):
1987         (WebCore::FrameLoader::stopAllLoaders):
1988         (WebCore::FrameLoader::cancelMainResourceLoad):
1989         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1990         (WebCore::FrameLoader::activeDocumentLoader):
1991         (WebCore::FrameLoader::addPlugInStreamLoader):
1992         (WebCore::FrameLoader::removePlugInStreamLoader):
1993         (WebCore::FrameLoader::hasMainResourceLoader):
1994         (WebCore::FrameLoader::isLoadingSubresources):
1995         (WebCore::FrameLoader::isLoadingPlugIns):
1996         (WebCore::FrameLoader::isLoading):
1997         (WebCore::FrameLoader::addSubresourceLoader):
1998         (WebCore::FrameLoader::removeSubresourceLoader):
1999         (WebCore::FrameLoader::releaseMainResourceLoader):
2000         (WebCore::FrameLoader::setDocumentLoader):
2001         (WebCore::FrameLoader::documentLoader):
2002         (WebCore::FrameLoader::setPolicyDocumentLoader):
2003         (WebCore::FrameLoader::provisionalDocumentLoader):
2004         (WebCore::FrameLoader::setProvisionalDocumentLoader):
2005         (WebCore::FrameLoader::state):
2006         (WebCore::FrameLoader::timeOfLastCompletedLoad):
2007         (WebCore::FrameLoader::setState):
2008         (WebCore::FrameLoader::clearProvisionalLoad):
2009         (WebCore::FrameLoader::markLoadComplete):
2010         (WebCore::FrameLoader::commitProvisionalLoad):
2011         (WebCore::FrameLoader::privateBrowsingEnabled):
2012         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
2013         (WebCore::FrameLoader::clientRedirected):
2014         (WebCore::FrameLoader::shouldReload):
2015         (WebCore::FrameLoader::closeOldDataSources):
2016         (WebCore::FrameLoader::open):
2017         (WebCore::FrameLoader::isStopping):
2018         (WebCore::FrameLoader::finishedLoading):
2019         (WebCore::FrameLoader::URL):
2020         (WebCore::FrameLoader::isArchiveLoadPending):
2021         (WebCore::FrameLoader::isHostedByObjectElement):
2022         (WebCore::FrameLoader::isLoadingMainFrame):
2023         (WebCore::FrameLoader::canShowMIMEType):
2024         (WebCore::FrameLoader::representationExistsForURLScheme):
2025         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2026         (WebCore::FrameLoader::cancelContentPolicyCheck):
2027         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
2028         (WebCore::FrameLoader::finishedLoadingDocument):
2029         (WebCore::FrameLoader::isReplacing):
2030         (WebCore::FrameLoader::setReplacing):
2031         (WebCore::FrameLoader::revertToProvisional):
2032         (WebCore::FrameLoader::subframeIsLoading):
2033         (WebCore::FrameLoader::willChangeTitle):
2034         (WebCore::FrameLoader::loadType):
2035         (WebCore::FrameLoader::stopPolicyCheck):
2036         (WebCore::FrameLoader::continueAfterContentPolicy):
2037         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2038         (WebCore::FrameLoader::didFirstLayout):
2039         (WebCore::FrameLoader::frameLoadCompleted):
2040         (WebCore::FrameLoader::firstLayoutDone):
2041         (WebCore::FrameLoader::isQuickRedirectComing):
2042         (WebCore::FrameLoader::closeDocument):
2043         (WebCore::FrameLoader::detachChildren):
2044         (WebCore::FrameLoader::checkLoadComplete):
2045         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2046         (WebCore::FrameLoader::setClient):
2047         (WebCore::FrameLoader::client):
2048         (WebCore::FrameLoader::userAgent):
2049         (WebCore::FrameLoader::createEmptyDocument):
2050         (WebCore::FrameLoader::tokenizerProcessedData):
2051         (WebCore::FrameLoader::didTellBridgeAboutLoad):
2052         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
2053         (WebCore::FrameLoader::handledOnloadEvents):
2054         (WebCore::FrameLoader::frameDetached):
2055         (WebCore::FrameLoader::setTitle):
2056         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2057         * loader/FrameLoader.h:
2058         (WebCore::):
2059         * loader/FrameLoaderClient.h:
2060         * loader/PluginDocument.cpp:
2061         (WebCore::PluginTokenizer::createDocumentStructure):
2062         (WebCore::PluginTokenizer::writeRawData):
2063         * loader/ResourceLoader.h:
2064         * loader/TextResourceDecoder.cpp:
2065         (WebCore::TextResourceDecoder::checkForHeadCharset):
2066         * loader/icon/IconLoader.cpp:
2067         (WebCore::IconLoader::startLoading):
2068         (WebCore::IconLoader::finishLoading):
2069         * loader/loader.cpp:
2070         (WebCore::Loader::didReceiveResponse):
2071         * loader/mac/DocumentLoaderMac.mm:
2072         (WebCore::DocumentLoader::~DocumentLoader):
2073         (WebCore::DocumentLoader::stopLoading):
2074         (WebCore::DocumentLoader::finishedLoading):
2075         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2076         (WebCore::DocumentLoader::setPrimaryLoadComplete):
2077         * loader/mac/FrameLoaderMac.mm:
2078         (WebCore::FrameLoader::load):
2079         (WebCore::FrameLoader::startLoading):
2080         (WebCore::FrameLoader::cancelMainResourceLoad):
2081         (WebCore::FrameLoader::receivedMainResourceError):
2082         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
2083         (WebCore::FrameLoader::commitProvisionalLoad):
2084         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2085         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2086         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2087         (WebCore::FrameLoader::detachFromParent):
2088         (WebCore::FrameLoader::addExtraFieldsToRequest):
2089         (WebCore::FrameLoader::loadResourceSynchronously):
2090         (WebCore::FrameLoader::createFrame):
2091         (WebCore::FrameLoader::objectContentType):
2092         (WebCore::nsArray):
2093         (WebCore::FrameLoader::createPlugin):
2094         (WebCore::FrameLoader::redirectDataToPlugin):
2095         (WebCore::FrameLoader::createJavaAppletWidget):
2096         (WebCore::FrameLoader::partClearedInBegin):
2097         (WebCore::FrameLoader::saveDocumentState):
2098         (WebCore::FrameLoader::restoreDocumentState):
2099         (WebCore::FrameLoader::overrideMediaType):
2100         (WebCore::FrameLoader::mainResourceData):
2101         (WebCore::FrameLoader::canGoBackOrForward):
2102         (WebCore::FrameLoader::originalRequestURL):
2103         (WebCore::FrameLoader::getHistoryLength):
2104         (WebCore::FrameLoader::goBackOrForward):
2105         (WebCore::FrameLoader::historyURL):
2106         (WebCore::FrameLoader::didFinishLoad):
2107         * loader/mac/LoaderFunctionsMac.mm:
2108         (WebCore::ServeSynchronousRequest):
2109         (WebCore::CheckCacheObjectStatus):
2110         * loader/mac/ResourceLoaderMac.mm:
2111         (WebCore::ResourceLoader::cancel):
2112         * loader/mac/SubresourceLoaderMac.mm:
2113         (WebCore::SubresourceLoader::create):
2114         * loader/qt/FrameLoaderQt.cpp: Added.
2115         (WebCore::FrameLoader::submitForm):
2116         (WebCore::FrameLoader::urlSelected):
2117         (WebCore::FrameLoader::setTitle):
2118         (WebCore::FrameLoader::createFrame):
2119         (WebCore::FrameLoader::objectContentType):
2120         (WebCore::FrameLoader::createPlugin):
2121         (WebCore::FrameLoader::createJavaAppletWidget):
2122         (WebCore::FrameLoader::originalRequestURL):
2123         * page/DOMWindow.cpp:
2124         (WebCore::DOMWindow::document):
2125         * page/Frame.cpp:
2126         (WebCore::Frame::~Frame):
2127         (WebCore::Frame::reparseConfiguration):
2128         (WebCore::Frame::shouldDragAutoNode):
2129         (WebCore::Frame::prepareForUserAction):
2130         (WebCore::FramePrivate::FramePrivate):
2131         (WebCore::FramePrivate::~FramePrivate):
2132         * page/Frame.h:
2133         * page/FramePrivate.h:
2134         * page/FrameView.cpp:
2135         (WebCore::FrameView::layout):
2136         (WebCore::FrameView::mediaType):
2137         * page/FrameView.h:
2138         * page/PageState.cpp:
2139         (WebCore::PageState::PageState):
2140         (WebCore::PageState::restoreJavaScriptState):
2141         * platform/mac/CookieJar.mm:
2142         (WebCore::setCookies):
2143         * platform/mac/TextCodecMac.cpp:
2144         * platform/mac/WebFontCache.mm:
2145         (+[WebFontCache fontWithFamily:traits:size:]):
2146         * platform/network/cf/ResourceHandleCFNet.cpp:
2147         (WebCore::ResourceHandle::start):
2148         * platform/network/mac/ResourceHandleMac.mm:
2149         (WebCore::ResourceHandle::start):
2150         * platform/qt/FrameQt.cpp:
2151         * platform/qt/FrameQt.h:
2152         * rendering/RenderApplet.cpp:
2153         (WebCore::RenderApplet::createWidgetIfNecessary):
2154         * rendering/RenderBlock.h:
2155         * rendering/RenderPartObject.cpp:
2156         (WebCore::isURLAllowed):
2157         (WebCore::RenderPartObject::updateWidget):
2158         * xml/DOMParser.cpp:
2159         (WebCore::DOMParser::parseFromString):
2160         * xml/XSLTProcessor.cpp:
2161         (WebCore::XSLTProcessor::createDocumentFromSource):
2162         * xml/xmlhttprequest.cpp:
2163         (WebCore::XMLHttpRequest::getResponseXML):
2164
2165 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
2166
2167         Reviewed by Geoff.
2168
2169         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
2170         
2171         * bridge/mac/FrameMac.mm:
2172         (WebCore::FrameMac::registerCommandForUndoOrRedo):
2173         * bridge/mac/WebCoreFrameBridge.h:
2174         * bridge/mac/WebCoreFrameBridge.mm:
2175         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2176         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2177         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
2178         (-[WebCoreFrameBridge selectionGranularity]):
2179         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2180         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2181         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
2182         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
2183         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
2184         * editing/SelectionController.cpp:
2185         (WebCore::SelectionController::setModifyBias):
2186         (WebCore::SelectionController::modify):
2187         * editing/SelectionController.h:
2188         (WebCore::SelectionController::):
2189         * editing/TextGranularity.h:
2190
2191 2006-11-07  Brady Eidson  <beidson@apple.com>
2192
2193         Reviewed by Maciej
2194
2195         Changed the check for "top level frame" to something much more valid
2196
2197         * page/Frame.cpp:
2198         (WebCore::Frame::endIfNotLoading):
2199
2200 2006-11-07  Beth Dakin  <bdakin@apple.com>
2201
2202         Reviewed by Hyatt (yesterday).
2203
2204         Here is part of my patch from yesterday that is safe to roll back 
2205         in. It will make the BuildBot happy.
2206
2207         * rendering/HitTestResult.cpp:
2208         (WebCore::HitTestResult::spellingToolTip): Null-check 
2209         m_innerNonSharedNode.
2210
2211 2006-11-07  Darin Adler  <darin@apple.com>
2212
2213         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2214         Comment grammar fix.
2215
2216 2006-11-07  Darin Adler  <darin@apple.com>
2217
2218         Rolled out change for <rdar://problem/4820814>.
2219
2220         Beth's planning on landing a new change for it soon, but in the mean time
2221         we need layout tests succeeding again.
2222
2223 2006-11-07  Darin Adler  <darin@apple.com>
2224
2225         Reviewed by Brady.
2226
2227         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
2228           crashes on launch in WebCore::ResourceLoader::start
2229
2230         No layout test, because this depends on cached icons, although there's
2231         perhaps a way to write a test for it with some further ingenuity.
2232
2233         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
2234         to make explicit the fact that it can't be successfully copied.
2235         Remove notifyIconChanged function and put the contents in the caller.
2236         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
2237         and clearLoadingState functions to share code. Removed m_url, since the
2238         resource handle already stores the URL. Renamed m_resourceLoader to
2239         m_handle to reflect the class's name change. Removed the 4096-byte
2240         inline buffer from m_data, since the malloc savings is not sufficient
2241         to offset the additional memory use. Removed m_httpStatusCode because
2242         we can instead cancel the load when we get a status code that reflects
2243         failure. Added m_loadIsInProgress boolean because we need to detect
2244         loads that complete during the ResourceHandle::create function call.
2245
2246         * loader/icon/IconLoader.cpp:
2247         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
2248         Don't initialize m_httpStatusCode.
2249         (WebCore::IconLoader::~IconLoader): Updated for name change.
2250         (WebCore::IconLoader::startLoading): Added code to use the
2251         m_loadIsInProgress flag to detect if the load completed while inside
2252         the ResourceHandle::create function. Removed code to set m_url.
2253         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
2254         more code.
2255         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
2256         and finish loading if the HTTP status code indicates failure.
2257         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
2258         the ResourceHandle, since we can't do that any more.
2259         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
2260         so we can share code with the new didReceiveResponse code path.
2261         (WebCore::IconLoader::finishLoading): Moved code here from the
2262         didFinishLoading callback. Pass a URL when calling
2263         commitIconURLToIconDatabase. Call notifyIconChanged directly here
2264         instead of using a separate function. Call clearLoadingState to
2265         share more code with stopLoading.
2266         (WebCore::IconLoader::clearLoadingState): Added.
2267
2268         * loader/mac/IconLoaderMac.mm: Removed.
2269         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
2270
2271 2006-11-06  David Harrison  <harrison@apple.com>
2272
2273         Reviewed by Darin.
2274
2275         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
2276
2277         * editing/pasteboard/3976872-expected.txt:
2278         * editing/pasteboard/4076267-2-expected.txt:
2279         * editing/pasteboard/4076267-3-expected.txt:
2280         * editing/pasteboard/4076267-expected.txt:
2281         * editing/pasteboard/8145-1-expected.txt:
2282         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
2283         * editing/pasteboard/paste-match-style-001-expected.txt:
2284         * editing/pasteboard/paste-match-style-002-expected.txt:
2285         * editing/pasteboard/paste-text-019-expected.txt:
2286         * editing/pasteboard/pasting-tabs-expected.txt:
2287         Updated because pasting text with no newlines does not use intermediate div.
2288         
2289         * editing/markup.cpp:
2290         (WebCore::fillContainerFromString):
2291         First parameter is now a Container so a fragment can be passed.
2292         
2293         (WebCore::createFragmentFromText):
2294         A string with no newlines gets added inline, rather than being put into a paragraph.
2295
2296 2006-11-06  Beth Dakin  <bdakin@apple.com>
2297
2298         Reviewed by Hyatt.
2299
2300         Fix for <rdar://problem/4820814> A crash occurs at 
2301         WebCore::HitTestResult::spellingToolTip() when mousing down on 
2302         iframe at www.macsurfer.com
2303
2304         The bug here is that the source of the iframe is only a comment, 
2305         and we were not properly constructing the frame because it was 
2306         sort-of empty but not.
2307
2308         * html/HTMLDocument.cpp:
2309         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
2310         it is a comment node.
2311         * html/HTMLParser.cpp:
2312         (WebCore::HTMLParser::handleError): if n is a comment node and 
2313         there is no head, we create a head, insert in the document, and add 
2314         the comment node as a child. This is what Firefox does too. 
2315         * page/FrameView.cpp:
2316         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
2317         fix. It is possible to get a mouse event without a target node, so 
2318         we null check it. (Of course, in the case of this bug, it should 
2319         not have been null, but it is a good thing to check for anyway.
2320         * rendering/HitTestResult.cpp:
2321         (WebCore::HitTestResult::spellingToolTip): Null-check 
2322         m_innerNonSharedNode.
2323
2324 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
2325
2326         Reviewed by harrison
2327         
2328         <rdar://problem/4641880>
2329         Setting bullets to existing text grabs subsequent paragraph
2330         
2331         When a selection ends at the start of a paragraph, we rarely paint 
2332         the selection gap before that paragraph, because there often is no gap.  
2333         In a case like this, it's not obvious to the user that the selection 
2334         ends "inside" that paragraph, so it would be confusing if 
2335         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
2336         
2337         * editing/FormatBlockCommand.cpp:
2338         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
2339         the selection to a more appropriate place.  Change the endingSelection
2340         if it ends at the start of a paragraph.
2341         * editing/IndentOutdentCommand.cpp:
2342         (WebCore::IndentOutdentCommand::doApply): Ditto.
2343         * editing/InsertListCommand.cpp:
2344         (WebCore::InsertListCommand::doApply): Ditto.
2345
2346 2006-11-06  Brady Eidson  <beidson@apple.com>
2347
2348         Reviewed by Sarge
2349
2350         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
2351         Toned it down a bit.
2352
2353         * xml/xmlhttprequest.cpp:
2354         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
2355
2356 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2357
2358         Reviewed by Maciej.
2359
2360         Linux\Gdk build fixes.
2361
2362         * loader/icon/IconDatabase.cpp:
2363         * loader/icon/SQLStatement.h:
2364         * platform/gdk/ChromeClientGdk.h: Added.
2365         (WebCore::ChromeClientGdk::~ChromeClientGdk):
2366         * platform/gdk/CursorGdk.cpp:
2367         (WebCore::pointerCursor):
2368         * platform/gdk/FrameGdk.cpp:
2369         (WebCore::doScroll):
2370         (WebCore::FrameGdk::FrameGdk):
2371         (WebCore::FrameGdk::submitForm):
2372         (WebCore::FrameGdk::urlSelected):
2373         (WebCore::FrameGdk::openURL):
2374         (WebCore::FrameGdk::handleGdkEvent):
2375         * platform/gdk/FrameGdk.h:
2376         (WebCore::FrameGdk::client):
2377         * platform/gdk/RenderPopupMenuGdk.cpp:
2378         (WebCore::PopupMenu::updateFromElement):
2379         * platform/gdk/ScreenGdk.cpp:
2380         * platform/gdk/TemporaryLinkStubs.cpp:
2381         (Slider::focusPolicy):
2382         (WebCore::ServeSynchronousRequest):
2383         (FrameGdk::goBackOrForward):
2384         (FrameGdk::getHistoryLength):
2385         (FrameGdk::historyURL):
2386         (ChromeClientGdk::canRunModal):
2387         (ChromeClientGdk::runModal):
2388         (WebCore::systemBeep):
2389         (WebCore::CachedResource::setPlatformResponse):
2390         (Path::transform):
2391         (ResourceLoader::loadsBlocked):
2392         (IconLoader::notifyIconChanged):
2393         * platform/network/gdk/ResourceHandleManager.cpp:
2394         (WebCore::writeCallback):
2395         (WebCore::ResourceHandleManager::downloadTimerCallback):
2396         (WebCore::ResourceHandleManager::remove):
2397         (WebCore::ResourceHandleManager::add):
2398
2399 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2400
2401         build fix.
2402         
2403         * WebCore.xcodeproj/project.pbxproj:
2404
2405 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2406
2407         Reviewed by Maciej, Anders, Darin.
2408
2409         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
2410         Fixed a minor where WebCore would always assume it was displayed on the 
2411         monitor containing the menubar. window.open and window.showModalDialog 
2412         are now cross-platform. 
2413         
2414         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
2415         window-open-features-parsing all pass. I verified the new screen functionality
2416         by running in DRT, and checking whether WebCore knew it was off-screen.
2417         
2418         Some refactoring remains, as all were not pleased by this design. I see
2419         in my future another patch.
2420
2421         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
2422         client, to encapsulate asking the platform questions about the screen occupied by
2423         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
2424         * bridge/mac/WebCoreFrameBridge.mm:
2425         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
2426         functions.
2427         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
2428         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
2429         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
2430         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
2431         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
2432         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
2433         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
2434         (In this case, neither size nor position is specified, so you should
2435         get the default window size and position.)
2436         * page/Screen.cpp: Added. Includes screen-related helper functions used
2437         in WebCore and WebKit.
2438         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
2439         to be duplicated. Renamed "position" to "point" since both were used,
2440         and "point" seemed clearer.
2441         * platform/Screen.h: Removed. Dead Code.
2442         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
2443         initialization.
2444
2445 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
2446
2447         Reviewed by Tim Hatcher.
2448
2449         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
2450         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
2451         
2452         No layout tests added as this must be tested manually by the test
2453         WebCore/manual-tests/contenteditable-link.html
2454
2455         * WebCore.exp: Exported HitTestResult::isLiveLink().
2456         * html/HTMLAnchorElement.cpp:
2457         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
2458         (WebCore::HTMLAnchorElement::defaultEventHandler):
2459         (WebCore::HTMLAnchorElement::isLiveLink):
2460         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
2461         to track shift key status.
2462         * manual-tests/contenteditable-link.html: Added description about link
2463         dragging behaviour.
2464         * rendering/HitTestResult.cpp:
2465         (WebCore::HitTestResult::isLiveLink): Added.
2466         * rendering/HitTestResult.h:
2467
2468 2006-11-06  Brady Eidson  <beidson@apple.com>
2469
2470         Reviewed by Oliver
2471
2472         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
2473         For now, we have to not load favicons when we have no Document - linking directly 
2474         to PDFs being the common case
2475
2476         * loader/icon/IconLoader.cpp:
2477         (WebCore::IconLoader::startLoading): Check for the document and return if none
2478
2479 2006-11-06  Brady Eidson  <beidson@apple.com>
2480
2481         Reviewed by Dave Harrison
2482
2483         <rdar://problem/4801066>
2484         Added a critical null frameLoader() check
2485
2486         * loader/mac/MainResourceLoaderMac.mm:
2487         (WebCore::MainResourceLoader::loadNow):
2488
2489 2006-11-06  David Harrison  <harrison@apple.com>
2490
2491         Reviewed by Darin.
2492
2493         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
2494
2495         Test:
2496         * editing/deleting/delete-br-012.html
2497         
2498         * editing/DeleteSelectionCommand.cpp:
2499         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
2500         Update m_endingPosition when preventing merge.
2501         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
2502
2503 2006-11-06  Mark Rowe  <bdash@webkit.org>
2504
2505         Reviewed by Maciej.
2506
2507         http://bugs.webkit.org/show_bug.cgi?id=11526
2508         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
2509
2510         Update DOMNode::toString to always use className rather than preferring nodeName.
2511
2512         * bindings/js/kjs_dom.cpp:
2513         (KJS::DOMNode::toString): Match the format returned by valueOf.
2514
2515 2006-11-06  Oliver Hunt  <oliver@apple.com>
2516
2517         Reviewed by Maciej.
2518
2519         Fix RTL text in SVG to have correct positioning
2520
2521         * rendering/SVGRootInlineBox.cpp:
2522         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
2523
2524 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2525
2526         Reviewed by Maciej.
2527
2528         http://bugs.webkit.org/show_bug.cgi?id=11517
2529         REGRESSION: Flash clicks/interactivity not working properly
2530
2531         * bridge/mac/FrameMac.mm:
2532         (WebCore::FrameMac::handleMouseMoveEvent):
2533         (WebCore::FrameMac::handleMouseReleaseEvent):
2534         Restore parts of event dispatching that were removed when fixing
2535         bug 7323 - just bypass those for subframes.
2536
2537 2006-11-05  Darin Adler  <darin@apple.com>
2538
2539         - quick attempt to fix the no-SVG build
2540
2541         * platform/graphics/svg/SVGResource.cpp:
2542         * platform/graphics/svg/SVGResource.h:
2543         * platform/graphics/svg/SVGResourceClipper.cpp:
2544         * platform/graphics/svg/SVGResourceClipper.h:
2545         * platform/graphics/svg/SVGResourceImage.h:
2546         * platform/graphics/svg/SVGResourceMarker.cpp:
2547         * platform/graphics/svg/SVGResourceMarker.h:
2548         * platform/graphics/svg/SVGResourceMasker.cpp:
2549         * platform/graphics/svg/SVGResourceMasker.h:
2550         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
2551         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
2552         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
2553         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
2554         Added #ifdef SVG_SUPPORT to these files.
2555
2556 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
2557
2558         Reviewed & landed by Maciej.
2559
2560         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
2561
2562         * platform/win/ResourceLoaderWin.cpp:
2563         (WebCore::transferJobStatusCallback):
2564         (WebCore::ResourceLoader::start):
2565
2566 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
2567
2568         Reviewed by Oliver.
2569
2570         - moved FormData and FormDataStream to platform/network directory
2571
2572         * WebCore.xcodeproj/project.pbxproj:
2573         * bridge/mac/WebCoreFrameBridge.mm:
2574         * loader/FormData.cpp: Removed.
2575         * loader/FormData.h: Removed.
2576         * loader/mac/FormDataStream.h: Removed.
2577         * loader/mac/FormDataStream.m: Removed.
2578         * loader/mac/FrameLoaderMac.mm:
2579         * loader/mac/SubresourceLoaderMac.mm:
2580         * platform/network/mac/FormDataStreamMac.h: Added.
2581         * platform/network/mac/FormDataStreamMac.mm: Added.
2582         * platform/network/mac/ResourceRequestMac.mm:
2583
2584 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
2585
2586         Fix build breaks
2587
2588         * loader/DocumentLoader.h:
2589         * platform/win/ScreenWin.cpp:
2590
2591 2006-11-05  Darin Adler  <darin@apple.com>
2592
2593         Reviewed by Geoff.
2594
2595         - more preparation for splitting up Frame into sub-pieces
2596         - removed unnecessary includes from Frame.h
2597
2598         * page/Frame.h: Removed unneeded includes and forward declarations.
2599         Added additional forward declarations. Removed the constant
2600         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
2601         Created sections of functions to be moved into Chrome, Editor,
2602         EventHandler, FrameLoader, SelectionController, and the Platform
2603         directory, as well as marking one function for deletion.
2604
2605         * page/FramePrivate.h: Removed the definition of the constructor and
2606         destructor and removed unnecessary includes.
2607
2608         * page/FrameView.h: Removed unneeded forward declarations and friend
2609         declarations. Created a section of functions and data to be moved into
2610         EventHandler.
2611
2612         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
2613         Created sections of functions and data to be moved into Chrome,
2614         Editor, EventHandler, FrameLoader, and the Platform directory.
2615
2616         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
2617         Removed unused methods areScrollbarsVisible,
2618         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
2619
2620         * page/Frame.cpp:
2621         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
2622         to include KURL.h just for the KURL default constructor.
2623         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
2624         (WebCore::FramePrivate::~FramePrivate): Ditto.
2625
2626         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
2627         booleans, scrollbarMoved and cleared funcitons.
2628         (WebCore::FrameView::clear): Moved the code from the cleared
2629         function in here.
2630         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
2631
2632         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
2633         for changes to header.
2634
2635         * editing/SelectionController.cpp:
2636         (WebCore::SelectionController::setSelection):
2637         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2638         Moved NoXPosForVerticalArrowNavigation into this file.
2639
2640         * bindings/js/kjs_events.cpp:
2641         * bindings/js/kjs_html.cpp:
2642         * bindings/js/kjs_window.cpp:
2643         * bridge/mac/WebCoreAXObject.mm:
2644         * bridge/mac/WebCoreFrameBridge.mm:
2645         * css/cssstyleselector.cpp:
2646         * dom/Document.cpp:
2647         * dom/Element.cpp:
2648         * dom/EventTargetNode.cpp:
2649         * dom/MouseRelatedEvent.cpp:
2650         * dom/XMLTokenizer.cpp:
2651         * html/HTMLBaseElement.cpp:
2652         * html/HTMLDocument.cpp:
2653         * html/HTMLEmbedElement.cpp:
2654         * html/HTMLFrameElementBase.cpp:
2655         * html/HTMLGenericFormElement.cpp:
2656         * html/HTMLObjectElement.cpp:
2657         * html/HTMLTokenizer.cpp:
2658         * loader/mac/FrameLoaderMac.mm:
2659         * page/PageState.cpp:
2660         * rendering/RenderApplet.cpp:
2661         * rendering/RenderBlock.cpp:
2662         * rendering/RenderLayer.cpp:
2663         * rendering/RenderObject.cpp:
2664         * rendering/RenderPartObject.cpp:
2665         * rendering/RenderTreeAsText.cpp:
2666         * xml/XSLTProcessor.cpp:
2667         Added includes as needed to keep compiling, since there are fewer
2668         includes in Frame.h.
2669
2670 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
2671
2672         Reviewed by Dave Harrison.
2673
2674         http://bugs.webkit.org/show_bug.cgi?id=11402
2675         REGRESSION: onChange does not work anymore for 1st item in popup
2676
2677         * html/HTMLSelectElement.cpp:
2678         (WebCore::HTMLSelectElement::HTMLSelectElement):
2679         (WebCore::HTMLSelectElement::reset):
2680         Set m_lastOnChangeIndex to -1.
2681
2682 2006-11-04  Darin Adler  <darin@apple.com>
2683
2684         Reviewed by Anders.
2685
2686         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
2687           REGRESSION: Status bar always shows cancelled opening the page
2688
2689         * platform/network/mac/ResourceHandleMac.mm:
2690         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
2691         Since the subresource owns the resource handle, there's no need to cancel.
2692         This arrangement is only temporary, anyway, since Maciej will soon change
2693         things so that the subresource loader uses the resource handle and the
2694         resource handle doesn't know anything about the subresource loader.
2695
2696 2006-11-04  Darin Adler  <darin@apple.com>
2697
2698         Reviewed by Maciej.
2699
2700         - converted more of the loader machinery to work with cross-platform
2701           data structures instead of Macintosh-specific ones
2702
2703           converted most uses of NSURL to KURL and NSEvent to DOM Event in
2704           loader classes
2705
2706           moved download function out of FrameLoader.h to avoid reference to
2707           NSURLConnection
2708
2709           added DOM Event parameters to various functions so that the handlers
2710           can use the DOM Event instead of the global "current NSEvent";
2711           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
2712           HTMLFormElement::submit, FrameLoader::load
2713
2714           moved the setMainFrame call that hands ownership to the Page
2715           into one of the Frame constructors, and removed it from all
2716           the clients
2717
2718           removed const from Event parameter to the urlSelected function
2719           (we rarely use const with DOM elements)
2720
2721           removed some redundant includes and declarations from various
2722           header files
2723
2724           removed NSURL parameter from userAgent function -- if we need it we
2725           can add it back, but converting from NSURL to KURL and back is
2726           inefficient enough that it's best to have it out for now (since it's
2727           been unused for years) -- if we add it back, we can choose an
2728           appropriate parameter type that's always inexpensive to pass
2729
2730           did some basic cleanup in the IconLoader class, including removing
2731           an unnecessary loop that added icon data a byte at a time
2732
2733           renamed safeLoad to load, since it's no different from the other
2734           FrameLoader load functions, safety-wise
2735
2736           fixed some code that was trying to distinguish null frame name from
2737           empty string frame name -- both should be handled the same, but callers
2738           were doing it by checking for empty and turning it into null (in a way
2739           that was causing extra round trips between NSString and WebCore::String)
2740
2741           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
2742           and got rid of case-insensitive compares of methods
2743
2744         * WebCore.exp:
2745         * WebCore.xcodeproj/project.pbxproj:
2746         * bindings/js/kjs_navigator.cpp:
2747         (KJS::Navigator::getValueProperty):
2748         * bridge/mac/FrameMac.h:
2749         * bridge/mac/FrameMac.mm:
2750         (WebCore::FrameMac::submitForm):
2751         (WebCore::FrameMac::urlSelected):
2752         (WebCore::FrameMac::userAgent):
2753         * bridge/mac/FrameViewMac.mm:
2754         * bridge/mac/WebCoreAXObject.mm:
2755         (-[WebCoreAXObject rendererForView:]):
2756         * bridge/mac/WebCorePageBridge.h:
2757         * bridge/mac/WebCorePageBridge.mm:
2758         * bridge/mac/WebCoreSettings.mm:
2759         * bridge/win/FrameWin.cpp:
2760         (WebCore::FrameWin::urlSelected):
2761         (WebCore::FrameWin::submitForm):
2762         * bridge/win/FrameWin.h:
2763         * dom/MouseRelatedEvent.cpp:
2764         * dom/MouseRelatedEvent.h:
2765         * dom/UIEvent.cpp:
2766         (WebCore::UIEvent::~UIEvent):
2767         * dom/UIEvent.h:
2768         * dom/UIEventWithKeyState.h:
2769         * dom/XMLTokenizer.cpp:
2770         (WebCore::openFunc):
2771         * html/HTMLAnchorElement.cpp:
2772         (WebCore::HTMLAnchorElement::defaultEventHandler):
2773         * html/HTMLButtonElement.cpp:
2774         (WebCore::HTMLButtonElement::defaultEventHandler):
2775         * html/HTMLFormElement.cpp:
2776         (WebCore::HTMLFormElement::submitClick):
2777         (WebCore::HTMLFormElement::prepareSubmit):
2778         (WebCore::HTMLFormElement::submit):
2779         * html/HTMLFormElement.h:
2780         * html/HTMLInputElement.cpp:
2781         (WebCore::HTMLInputElement::defaultEventHandler):
2782         * html/HTMLSelectElement.cpp:
2783         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2784         * loader/DocumentLoader.h:
2785         * loader/FrameLoader.h:
2786         * loader/FrameLoaderClient.h:
2787         * loader/NavigationAction.h:
2788         (WebCore::NavigationAction::event):
2789         * loader/icon/IconLoader.cpp:
2790         (WebCore::IconLoader::create):
2791         (WebCore::IconLoader::startLoading):
2792         (WebCore::IconLoader::didReceiveData):
2793         (WebCore::IconLoader::didFinishLoading):
2794         * loader/icon/IconLoader.h:
2795         * loader/loader.cpp:
2796         * loader/mac/DocumentLoaderMac.mm:
2797         (WebCore::DocumentLoader::URL):
2798         (WebCore::DocumentLoader::unreachableURL):
2799         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
2800         (WebCore::DocumentLoader::URLForHistory):
2801         * loader/mac/FrameLoaderMac.mm:
2802         (WebCore::FrameLoader::load):
2803         (WebCore::FrameLoader::willSendRequest):
2804         (WebCore::FrameLoader::clientRedirected):
2805         (WebCore::FrameLoader::shouldReload):
2806         (WebCore::FrameLoader::notifyIconChanged):
2807         (WebCore::FrameLoader::URL):
2808         (WebCore::FrameLoader::reloadAllowingStaleData):
2809         (WebCore::FrameLoader::reload):
2810         (WebCore::FrameLoader::didChangeTitle):
2811         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2812         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2813         (WebCore::FrameLoader::post):
2814         (WebCore::FrameLoader::addExtraFieldsToRequest):
2815         (WebCore::FrameLoader::loadResourceSynchronously):
2816         * loader/mac/IconLoaderMac.mm:
2817         (WebCore::IconLoader::notifyIconChanged):
2818         * loader/mac/LoaderFunctionsMac.mm:
2819         * loader/mac/MainResourceLoaderMac.mm:
2820         (WebCore::shouldLoadAsEmptyDocument):
2821         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2822         * loader/mac/NavigationActionMac.mm:
2823         (WebCore::navigationType):
2824         (WebCore::NavigationAction::NavigationAction):
2825         * loader/mac/ResourceLoaderMac.mm:
2826         * loader/mac/SubresourceLoaderMac.mm:
2827         * page/Frame.cpp:
2828         (WebCore::Frame::Frame):
2829         (WebCore::Frame::urlSelected):
2830         (WebCore::Frame::submitFormAgain):
2831         (WebCore::Frame::submitForm):
2832         (WebCore::Frame::endIfNotLoading):
2833         (WebCore::Frame::hitTestResultAtPoint):
2834         * page/Frame.h:
2835         * page/FramePrivate.h:
2836         * platform/gdk/FrameGdk.cpp:
2837         (WebCore::FrameGdk::FrameGdk):
2838         (WebCore::FrameGdk::submitForm):
2839         (WebCore::FrameGdk::urlSelected):
2840         * platform/gdk/FrameGdk.h:
2841         * platform/mac/TextFieldMac.mm:
2842         * platform/network/HTTPHeaderMap.h:
2843         * platform/network/ResourceHandle.h:
2844         * platform/network/ResourceHandleClient.h:
2845         * platform/network/ResourceHandleInternal.h:
2846         * platform/network/mac/ResourceHandleMac.mm:
2847         * platform/network/mac/ResourceResponseMac.h:
2848         * platform/network/mac/ResourceResponseMac.mm:
2849         (-[NSURLResponse WebCore]):
2850         * platform/network/win/ResourceHandleWin.cpp:
2851         * platform/qt/FrameQt.cpp:
2852         (WebCore::FrameQt::submitForm):
2853         (WebCore::FrameQt::urlSelected):
2854         * platform/qt/FrameQt.h:
2855         * rendering/RenderLineEdit.cpp:
2856         (WebCore::RenderLineEdit::returnPressed):
2857         * xml/XSLTProcessor.cpp:
2858         (WebCore::docLoaderFunc):
2859         * xml/xmlhttprequest.cpp:
2860
2861 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2862
2863         Reviewed by Adele.
2864
2865         - replaced receivedRedirect with new willSendRequest delegate
2866         - removed most mac-specific loader functions
2867         - use ResourceResponse more in loader code
2868
2869         * WebCore.xcodeproj/project.pbxproj: Add new files.
2870         * bridge/mac/WebCoreFrameBridge.mm:
2871         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
2872         for CachedResource method renames.
2873         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2874         Ditto.
2875         * loader/CachedCSSStyleSheet.cpp:
2876         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
2877         based on ResourceResponse
2878         * loader/CachedImage.cpp:
2879         (WebCore::CachedImage::createImage): adapt for ResourceResponse
2880         * loader/CachedResource.cpp:
2881         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
2882         platform response is now called platformResponse and expiration date
2883         is removed.
2884         (WebCore::CachedResource::~CachedResource): ditto
2885         (WebCore::CachedResource::isExpired): ditto
2886         * loader/CachedResource.h:
2887         (WebCore::CachedResource::platformResponse): ditto
2888         (WebCore::CachedResource::setResponse): ditto
2889         (WebCore::CachedResource::canDelete): ditto
2890         * loader/LoaderFunctions.h:
2891         * loader/loader.cpp:
2892         (WebCore::Loader::receivedResponse): Adjusted for renames.
2893         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
2894         in the CachedResource.
2895         * loader/loader.h:
2896         * loader/mac/FormDataStream.h:
2897         * loader/mac/FormDataStream.m:
2898         (WebCore::getStreamFormDatas): Rearranged things so it's
2899         possible to get a FormData back out of a form data stream.
2900         (WebCore::formCreate): ditto
2901         (WebCore::formFinalize): ditto
2902         (WebCore::httpBodyFromStream): ditto
2903         * loader/mac/ImageDocumentMac.mm:
2904         (WebCore::finishImageLoad): s/response/platformResponse/
2905         * loader/mac/LoaderFunctionsMac.mm:
2906         (WebCore::CheckCacheObjectStatus): ditto
2907         (WebCore::CachedResource::setPlatformResponse): ditto
2908         * loader/mac/SubresourceLoaderMac.mm:
2909         (WebCore::SubresourceLoader::willSendRequest): send redirect
2910         to client appropriately
2911         * platform/network/ResourceHandle.h:
2912         * platform/network/ResourceHandleClient.h:
2913         (WebCore::ResourceHandleClient::willSendRequest): new entry
2914         point for SubresourceLoader, dispatch to client.
2915         * platform/network/ResourceRequest.h:
2916         (WebCore::ResourceRequest::allowHTTPCookies): implemented
2917         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
2918         * platform/network/ResourceResponse.h:
2919         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
2920         date(!)
2921         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
2922         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
2923         (WebCore::openNextStream): ditto
2924         (WebCore::formCreate): ditto
2925         (WebCore::formFinalize): ditto
2926         (WebCore::formCanRead): ditto
2927         (WebCore::formEventCallback): ditto
2928         (WebCore::setHTTPBody): ditto
2929         (WebCore::httpBodyFromStream): ditto
2930         * platform/network/cf/FormDataStreamCFNet.h: Added.
2931         * platform/network/cf/ResourceHandleCFNet.cpp:
2932         (WebCore::willSendRequest): implemented
2933         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
2934         * platform/network/cf/ResourceResponseCFNet.cpp:
2935         (WebCore::getResourceResponse): do nothing for a null response
2936         * platform/network/mac/ResourceHandleMac.mm:
2937         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
2938         * platform/network/mac/ResourceRequestMac.h: Added.
2939         * platform/network/mac/ResourceRequestMac.mm: Added.
2940         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
2941         to a ResourceRequest.
2942         (WebCore::nsURLRequest): Opposite of the above.
2943         * platform/network/cf/ResourceRequestCFNet.h: Added.
2944         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
2945         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
2946         to a ResourceRequest.
2947         (WebCore::cfURLRequest): Opposite of the above.
2948         * xml/xmlhttprequest.cpp:
2949         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
2950         adjusted.
2951         * xml/xmlhttprequest.h:
2952
2953 2006-11-04  Darin Adler  <darin@apple.com>
2954
2955         Change suggested by Mitz.
2956
2957         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
2958           REGRESSION (r17438): Repro crash when opening a web archive
2959
2960         * bridge/mac/WebCorePageState.mm:
2961         (-[WebCorePageState dealloc]): Add null check.
2962         (-[WebCorePageState finalize]): Ditto.
2963
2964 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
2965
2966         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
2967
2968         http://bugs.webkit.org/show_bug.cgi?id=11433
2969         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
2970
2971         * WebCore.vcproj/WebCore/WebCore.vcproj:
2972         Added platform/graphics platform/network and platform/network/win to headers search paths
2973         Created platform/graphics and platform/network filters in hierarchy
2974         Moved GraphicsContext and GraphicsTypes to their respective filters
2975         Added EditorClient.h
2976         Added FrameLoader* files in loader/
2977         Added HitTest* files in rendering/
2978         Added Editor.* files in editing/
2979         Added DeleteButton.* and DeleteButtonController.* in editing/
2980
2981         * bridge/win/ChromeClientWin.h: Added.
2982         (WebCore::ChromeClientWin::~ChromeClientWin):
2983         * bridge/win/EditorClientWin.h: Added.
2984         (WebCore::EditorClientWin::~EditorClientWin):
2985
2986         * bridge/win/FrameWin.cpp:
2987         (WebCore::FrameWin::FrameWin):
2988         (WebCore::FrameWin::urlSelected):
2989         (WebCore::FrameWin::submitForm):
2990         (WebCore::FrameWin::createNewWindow):
2991         * bridge/win/FrameWin.h:
2992         Added EditorClient parameter to constructor
2993         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
2994         Removed openURL() and openURLRequest from class definition
2995
2996         * bridge/win/PageWin.cpp:
2997         * platform/AffineTransform.h:
2998         * platform/cairo/AffineTransformCairo.cpp: Added.
2999         (WebCore::AffineTransform::AffineTransform):
3000         (WebCore::AffineTransform::setMatrix):
3001         (WebCore::AffineTransform::map):
3002         (WebCore::AffineTransform::mapRect):
3003         (WebCore::AffineTransform::isIdentity):
3004         (WebCore::AffineTransform::m11):
3005         (WebCore::AffineTransform::m12):
3006         (WebCore::AffineTransform::m21):
3007         (WebCore::AffineTransform::m22):
3008         (WebCore::AffineTransform::dx):
3009         (WebCore::AffineTransform::dy):
3010         (WebCore::AffineTransform::reset):
3011         (WebCore::AffineTransform::scale):
3012         (WebCore::AffineTransform::rotate):
3013         (WebCore::AffineTransform::translate):
3014         (WebCore::AffineTransform::shear):
3015         (WebCore::AffineTransform::det):
3016         (WebCore::AffineTransform::invert):
3017         (WebCore::AffineTransform::operator cairo_matrix_t):
3018         (WebCore::AffineTransform::operator== ):
3019         (WebCore::AffineTransform::operator*= ):
3020         (WebCore::AffineTransform::operator* ):
3021         * platform/cairo/GraphicsContextCairo.cpp:
3022         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3023         * platform/network/win/ResourceHandleWin.cpp:
3024         (WebCore::ResourceHandle::onHandleCreated):
3025         (WebCore::ResourceHandle::start):
3026         (WebCore::ResourceHandle::fileLoadTimer):
3027         (WebCore::ResourceHandle::cancel):
3028         * platform/win/TemporaryLinkStubs.cpp:
3029         (WebCore::FrameWin::goBackOrForward):
3030         (WebCore::FrameWin::getHistoryLength):
3031         (WebCore::FrameWin::historyURL):
3032         (WebCore::ServeSynchronousRequest):
3033         (WebCore::ChromeClientWin::canRunModal):
3034         (WebCore::ChromeClientWin::runModal):
3035         (WebCore::EditorClientWin::shouldDeleteRange):
3036         (WebCore::EditorClientWin::shouldShowDeleteInterface):
3037         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
3038         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
3039         (WebCore::EditorClientWin::spellCheckerDocumentTag):
3040         (WebCore::Path::transform):
3041         (WebCore::PopupMenu::updateFromElement):
3042         (WebCore::ResourceLoader::loadsBlocked):
3043         (WebCore::systemBeep):
3044         * rendering/RenderThemeWin.cpp:
3045         (WebCore::RenderThemeWin::paintButton):
3046         (WebCore::RenderThemeWin::paintTextField):
3047
3048 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
3049
3050         Reviewed by Maciej.
3051
3052         http://bugs.webkit.org/show_bug.cgi?id=11448
3053         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
3054
3055         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
3056
3057 2006-11-03  Mark Rowe  <bdash@webkit.org>
3058
3059         Reviewed by Oliver.
3060
3061         Update Windows and Qt project files for file removals in r17585.
3062
3063         * CMakeLists.txt:
3064         * WebCore.vcproj/WebCore/WebCore.vcproj:
3065
3066 2006-11-03  Zack Rusin  <zack@kde.org>
3067
3068         Reviewed by Maciej.
3069
3070         The patch fixes text field drawing on the Qt platform.
3071
3072         * platform/qt/RenderThemeQt.cpp:
3073         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
3074         render the text field
3075
3076 2006-11-03  Oliver Hunt  <oliver@apple.com>
3077
3078         Reviewed by Tim.
3079
3080         Correct incorrect call to SetCursor
3081
3082         * rendering/RenderFrameSet.cpp:
3083         (WebCore::RenderFrameSet::userResize):
3084
3085 2006-11-03  Adele Peterson  <adele@apple.com>
3086
3087         Reviewed by Oliver.
3088
3089         Removed DeprecatedRenderSelect and ListBox classes.
3090
3091         * WebCore.xcodeproj/project.pbxproj:
3092         * css/html4.css:
3093         * html/HTMLOptionElement.h:
3094         * html/HTMLSelectElement.cpp:
3095         (WebCore::HTMLSelectElement::recalcStyle):
3096         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3097         (WebCore::HTMLSelectElement::isMouseFocusable):
3098         (WebCore::HTMLSelectElement::createRenderer):
3099         (WebCore::HTMLSelectElement::setRecalcListItems):
3100         (WebCore::HTMLSelectElement::notifyOptionSelected):
3101         (WebCore::HTMLSelectElement::defaultEventHandler):
3102         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3103         (WebCore::HTMLSelectElement::updateListBoxSelection):
3104         * html/HTMLSelectElement.h:
3105         * platform/ListBox.h: Removed.
3106         * platform/mac/FontCacheMac.mm:
3107         * platform/mac/ListBoxMac.mm: Removed.
3108         * platform/win/TemporaryLinkStubs.cpp:
3109         * rendering/DeprecatedRenderSelect.cpp: Removed.
3110         * rendering/DeprecatedRenderSelect.h: Removed.
3111
3112 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3113
3114         Not reviewed, fix for accidental commit.
3115
3116         - rolled back more of the accidentall commit that I forgot.
3117
3118         * platform/network/mac/ResourceRequestMac.h: Removed.
3119         * platform/network/mac/ResourceRequestMac.mm: Removed.
3120
3121 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3122
3123         Not reviewed, fix for accidental commit.
3124
3125         - roll back some network changes accidentally committed with a previous patch.
3126
3127         * WebCore.xcodeproj/project.pbxproj:
3128         * bridge/mac/WebCoreFrameBridge.mm:
3129         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3130         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3131         * loader/CachedCSSStyleSheet.cpp:
3132         (WebCore::CachedCSSStyleSheet::checkNotify):
3133         * loader/CachedImage.cpp:
3134         (WebCore::CachedImage::createImage):
3135         * loader/CachedResource.cpp:
3136         (WebCore::CachedResource::CachedResource):
3137         (WebCore::CachedResource::~CachedResource):
3138         (WebCore::CachedResource::setExpireDate):
3139         (WebCore::CachedResource::isExpired):
3140         * loader/CachedResource.h:
3141         (WebCore::CachedResource::response):
3142         * loader/LoaderFunctions.h:
3143         * loader/loader.cpp:
3144         (WebCore::Loader::receivedResponse):
3145         (WebCore::Loader::didReceivedResponse):
3146         * loader/loader.h:
3147         * loader/mac/FormDataStream.h:
3148         * loader/mac/FormDataStream.m:
3149         (WebCore::formCreate):
3150         (WebCore::formFinalize):
3151         * loader/mac/ImageDocumentMac.mm:
3152         (WebCore::finishImageLoad):
3153         * loader/mac/LoaderFunctionsMac.mm:
3154         (WebCore::CheckCacheObjectStatus):
3155         (WebCore::CachedResource::setResponse):
3156         * loader/mac/SubresourceLoaderMac.mm:
3157         (WebCore::SubresourceLoader::willSendRequest):
3158         * platform/network/ResourceHandle.h:
3159         * platform/network/ResourceHandleClient.h:
3160         (WebCore::ResourceHandleClient::receivedRedirect):
3161         * platform/network/ResourceRequest.h:
3162         * platform/network/ResourceResponse.h:
3163         (WebCore::ResourceResponse::ResourceResponse):
3164         * platform/network/mac/ResourceHandleMac.mm:
3165         (WebCore::ResourceHandle::redirectedToURL):
3166         * xml/xmlhttprequest.cpp:
3167         (WebCore::XMLHttpRequest::receivedRedirect):
3168         * xml/xmlhttprequest.h:
3169
3170 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3171
3172         Rubber-stamped by Oliver.
3173
3174         Remove these, they have been merged with SVGRenderTreeAsText.
3175         
3176         * rendering/SVGRenderAsText.cpp: Removed.
3177         * rendering/SVGRenderAsText.h: Removed.
3178
3179 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3180
3181         Build fix.
3182         
3183         * platform/network/cf/ResourceHandleCFNet.cpp:
3184         (WebCore::willSendRequest):
3185
3186 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
3187
3188         Reviewed by Darin, Beth.
3189         
3190         First cut at factoring Page's UIDelegate-related functions into Chrome
3191         and ChromeClient.
3192
3193         Layout tests pass.
3194         
3195         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
3196         setBridge method to replace it.
3197         (WebCore::Page::setBridge):
3198
3199         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
3200         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
3201         and, now that it uses PassRefPtr, can't be.
3202         
3203         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
3204
3205         * page/Page.h:
3206         (WebCore::Page::dragCaretController): Made this function non-const so that
3207         m_dragCaretController doesn't have to be mutable.
3208
3209 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
3210
3211         Reviewed by Adele.
3212
3213         http://bugs.webkit.org/show_bug.cgi?id=7323
3214         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
3215
3216         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
3217         in FrameMac.mm. There can be only one drag active at any moment, and having 
3218         this information here was making sharing this information between 
3219         subframes hard.
3220
3221         * bridge/mac/FrameMac.mm:
3222         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
3223         (WebCore::FrameMac::freeClipboard):
3224         (WebCore::FrameMac::dragHysteresisExceeded):
3225         (WebCore::FrameMac::handleMouseMoveEvent):
3226         (WebCore::FrameMac::handleMouseReleaseEvent):
3227         (WebCore::FrameMac::mouseDown):
3228         (WebCore::FrameMac::dragSourceMovedTo):
3229         (WebCore::FrameMac::dragSourceEndedAt):
3230         (WebCore::FrameMac::dispatchDragSrcEvent):
3231         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
3232         Also removed some old code that was forwarding mouse events to subviews to make 
3233         HTML editing work in subframes.
3234
3235         * page/FrameView.cpp:
3236         (WebCore::FrameView::updateDragAndDrop):
3237         (WebCore::FrameView::cancelDragAndDrop):
3238         (WebCore::FrameView::performDragAndDrop):
3239         Forward events to subframes for dispatching - this fixes drag target events.
3240
3241 2006-11-03  Zack Rusin  <zack@kde.org>
3242
3243         Reviewed by Tim.
3244
3245         Fixing compile.
3246
3247         * platform/qt/LoaderFunctionsQt.cpp:
3248         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
3249
3250 2006-11-01  Zack Rusin  <zack@kde.org>
3251
3252         Reviewed by Maciej.
3253
3254         Moving the word/sentence seperators into a file of their own
3255         and implementing findWordBoundary.
3256
3257         * CMakeLists.txt:
3258         * platform/qt/TemporaryLinkStubs.cpp:
3259         * platform/qt/TextBoundaries.cpp: Added.
3260         (WebCore::findNextSentenceFromIndex):
3261         (WebCore::findSentenceBoundary):
3262         (WebCore::findNextWordFromIndex):
3263         (WebCore::findWordBoundary):
3264
3265 2006-11-03  Zack Rusin  <zack@kde.org>
3266
3267         Reviewed by Maciej.
3268
3269         Compile on both KDE and Qt platforms
3270
3271         * CMakeLists.txt: add zlib explicitly
3272         * platform/network/qt/ResourceHandleManager.cpp:
3273         (WebCore::ResourceHandleManager::self):
3274         (WebCore::QtJob::QtJob):
3275         (WebCore::QtJob::timerEvent): Integrate both implementations
3276         so that moc can parse it
3277         (WebCore::ResourceHandleManager::deliverJobData):
3278         (WebCore::ResourceHandleManager::remove):
3279         * platform/network/qt/ResourceHandleManager.h:
3280
3281 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3282
3283         No review, suggested by Mitz.
3284
3285         - fix a #if to be #ifdef
3286
3287         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
3288
3289 2006-11-03  Zack Rusin  <zack@kde.org>
3290
3291         Reviewed and landed by Maciej.
3292         
3293         Compile on the Qt platform.
3294
3295         * ksvg2/misc/KCanvasRenderingStyle.h:
3296         * platform/qt/RenderThemeQt.cpp:
3297         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
3298
3299 2006-11-03  Zack Rusin  <zack@kde.org>
3300
3301         Reviewed by Hyatt. Landed by Maciej.
3302
3303         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
3304         to graphics context to be able to set consistant state
3305         on the platform specific painter without having to change
3306         fill/stroke/font on every operation. This fixes color/stroke/fill
3307         and font handling in the Qt port.
3308
3309         * platform/graphics/GraphicsContext.cpp:
3310         (WebCore::GraphicsContext::setFont):
3311         (WebCore::GraphicsContext::setPen):
3312         (WebCore::GraphicsContext::setFillColor):
3313         (WebCore::GraphicsContext::setPlatformPen):
3314         (WebCore::GraphicsContext::setPlatformFillColor):
3315         (WebCore::GraphicsContext::setPlatformFont):
3316         * platform/graphics/GraphicsContext.h:
3317         * platform/qt/GraphicsContextQt.cpp:
3318         (WebCore::toQtCompositionMode):
3319         (WebCore::toQtLineCap):
3320         (WebCore::toQtLineJoin):
3321         (WebCore::toQPenStyle):
3322         (WebCore::penToQPen):
3323         (WebCore::TransparencyLayer::TransparencyLayer):
3324         (WebCore::GraphicsContext::addRoundedRectClip):
3325         (WebCore::GraphicsContext::setPlatformFont):
3326         (WebCore::GraphicsContext::setPlatformPen):
3327         (WebCore::GraphicsContext::setPlatformFillColor):
3328         * platform/qt/ScrollViewCanvasQt.cpp:
3329         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
3330         (WebCore::ScrollViewCanvasQt::paintEvent):
3331         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
3332         * platform/qt/ScrollViewCanvasQt.h:
3333
3334 2006-11-02  Adele Peterson  <adele@apple.com>
3335
3336         Reviewed by Anders.
3337
3338         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
3339         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
3340
3341         Test: fast/forms/textarea-no-scroll-on-blur.html
3342
3343         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
3344           On blur, only scroll back to the start for text fields.
3345
3346 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3347
3348         Another build fix.
3349         
3350         * rendering/RenderFileUploadControl.cpp:
3351         (WebCore::RenderFileUploadControl::paintObject):
3352
3353 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3354
3355         Build fix.
3356         
3357         * page/FramePrivate.h:
3358         (WebCore::FramePrivate::FramePrivate):
3359
3360 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
3361
3362         Reviewed by Geoff, landed by Anders.
3363         
3364         Fix dependency problems caused when running move-js-headers.sh
3365         
3366         * move-js-headers.sh:
3367         Use cp -p instead of just cp so that the modification time
3368         of the original files are used.
3369
3370 2006-11-02  Adam Roben  <aroben@apple.com>
3371
3372         Reviewed by Tim H, landed by Anders.
3373
3374         Fixes http://bugs.webkit.org/show_bug.cgi?id=10840
3375         REGRESSION: Shadow of file upload button is clipped
3376
3377         * rendering/RenderFileUploadControl.cpp:
3378         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
3379         height to keep from clipping in the shadow
3380
3381 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
3382
3383         Reviewed by Maciej, landed by Anders.
3384
3385         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
3386         content and window. ScrollViewQt already receives correct content
3387         coordinates from QScrollArea.
3388         (WebCore::ScrollView::contentsToWindow):
3389         (WebCore::ScrollView::windowToContents):
3390
3391 2006-11-02  Simon Hausmann  <hausmann@kde.org>
3392
3393         Reviewed by Maciej, landed by Anders
3394
3395         * CMakeLists.txt: Make linkage against KDE libraries conditional
3396         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
3397           Qt base resource handler that supports only requests to the
3398           local filesystem. Used when compiling without KDE support.
3399           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
3400           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
3401         (WebCore::QtJob::QtJob):
3402         (WebCore::QtJob::timerEvent):
3403         (WebCore::ResourceHandleManager::ResourceHandleManager):
3404         (WebCore::ResourceHandleManager::~ResourceHandleManager):
3405         (WebCore::ResourceHandleManager::self):
3406         (WebCore::ResourceHandleManager::remove):
3407         (WebCore::ResourceHandleManager::add):
3408         (WebCore::ResourceHandleManager::cancel):
3409         (WebCore::ResourceHandleManager::deliverJobData):
3410         * platform/network/qt/ResourceHandleManager.h:
3411         * platform/qt/FrameQtClient.cpp:
3412         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
3413         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
3414         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
3415         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
3416           input dialog functions when compiling without KDE support
3417         (WebCore::ServeSynchronousRequest):
3418
3419 2006-11-02  David Carson  <dacarson@gmail.com>
3420
3421         Reviewed by Geoff, landed by Anders.
3422
3423         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
3424         Initializing variable in constructor.
3425
3426         * page/FramePrivate.h:
3427         (WebCore::FramePrivate::FramePrivate):
3428
3429 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3430
3431         Reviewed by Geoff.
3432
3433         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
3434         
3435         * platform/network/cf/ResourceHandleCFNet.cpp:
3436         (WebCore::addHeadersFromHashMap):
3437         Don't set all headers at once since that clears any previous headers set.
3438         
3439         (WebCore::ResourceHandle::start):
3440
3441 2006-11-02  Adele Peterson  <adele@apple.com>
3442
3443         Reviewed by Mitz and Geoff.
3444
3445         - Fix for:
3446         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
3447         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
3448         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
3449
3450         Test: fast/forms/textarea-scrollbar.html
3451
3452         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
3453         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
3454
3455         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
3456         * rendering/RenderTextControl.cpp: 
3457         (WebCore::RenderTextControl::RenderTextControl):
3458         (WebCore::RenderTextControl::setStyle):
3459         (WebCore::RenderTextControl::createDivStyle):
3460         (WebCore::RenderTextControl::updateFromElement):
3461         (WebCore::RenderTextControl::calcHeight):
3462         (WebCore::RenderTextControl::baselinePosition):
3463         (WebCore::RenderTextControl::nodeAtPoint):
3464         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
3465         (WebCore::RenderTextControl::scrollWidth):
3466         (WebCore::RenderTextControl::scrollHeight):
3467         (WebCore::RenderTextControl::scrollLeft):
3468         (WebCore::RenderTextControl::scrollTop):
3469
3470         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
3471
3472 2006-11-02  John Sullivan  <sullivan@apple.com>
3473
3474         Reviewed by Geoff Garen
3475
3476         * editing/Selection.cpp:
3477         (WebCore::Selection::showTreeForThis):
3478         this debugging method now displays start offset and end offset, at Darin's suggestion
3479
3480 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
3481
3482         Reviewed by darin
3483
3484         <rdar://problem/4062865>
3485         Copy/paste of a select element fails to include the options
3486         
3487         * editing/SelectionController.cpp:
3488         (WebCore::SelectionController::modify): Added paragraphBoundary.
3489         * editing/htmlediting.cpp:
3490         (WebCore::canHaveChildrenForEditing): Added checks for input elements
3491         and textareas.  Insertion operations would fail when performed just 
3492         before/after one of these elements b/c the content would be put inside 
3493         the element.
3494         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
3495         editable content, and made the code to stop at an root faster (don't check
3496         isDescendantOf on every iteration).
3497         (WebCore::enclosingNodeOfType): Ditto.
3498         (WebCore::enclosingList): Ditto.
3499         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
3500         inappropriately named.
3501         * editing/markup.cpp:
3502         (WebCore::startMarkup): Use the text node's value instead of its rendered
3503         content for text nodes inside select elements.  One might also turn off
3504         annotation when createMarkup enters a select element, but createMarkup
3505         is iterative, not recursive, so doing so would be complicated.
3506         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
3507         descendants of a select element.
3508         * editing/visible_units.cpp:
3509         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
3510         where various replaced elements can't be copied when they are the only
3511         thing selected.
3512         (WebCore::endOfParagraph): Ditto.
3513
3514 2006-11-01  Oliver Hunt  <oliver@apple.com>
3515
3516         Reviewed by Adam.
3517
3518         Converting more or kcanvas/quartz from Obj-C to C++
3519         Minor SVG updates
3520         compatibility fixes
3521
3522         * WebCore.xcodeproj/project.pbxproj:
3523         * kcanvas/device/KRenderingPaintServer.h:
3524         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
3525         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3526         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
3527         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
3528         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
3529         * kcanvas/device/quartz/QuartzSupport.h:
3530         * ksvg2/css/SVGCSSStyleSelector.cpp:
3531         * ksvg2/misc/KCanvasRenderingStyle.h:
3532         * ksvg2/scripts/cssmakeprops:
3533         * ksvg2/scripts/cssmakevalues:
3534         * ksvg2/scripts/make_names.pl:
3535         * ksvg2/svg/SVGAnimateColorElement.cpp:
3536         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3537         * ksvg2/svg/SVGAnimationElement.cpp:
3538         * ksvg2/svg/SVGMaskElement.cpp:
3539         * ksvg2/svg/SVGPatternElement.cpp:
3540         * ksvg2/svg/svgpathparser.cpp:
3541         * platform/Path.cpp:
3542         * platform/graphics/svg/SVGResourceImage.h:
3543         * rendering/RenderPath.cpp:
3544         * rendering/SVGRenderAsText.cpp:
3545
3546 2006-11-02  Mitz Pettel  <mitz@webkit.org>
3547
3548         Reviewed by Adele.
3549
3550         - Fix a regression from r17521: painting of and crash caused by tables