WebCore:
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-04  David Levin  <levin@chromium.org>
2
3         Reviewed by Alexey Proskuryakov.
4
5         Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
6         <https://bugs.webkit.org/show_bug.cgi?id=24337>
7
8         Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
9                http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
10
11         * loader/mac/ResourceLoaderMac.mm:
12         (WebCore::ResourceLoader::willCacheResponse):
13         An identifier is only asssigned if resource load callbacks are done.  So don't send
14         willCacheResponse which uses identifier if resource load callbacks aren't being sent.
15
16 2009-03-04  David Levin  <levin@chromium.org>
17
18         Reviewed by Alexey Proskuryakov.
19
20         Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
21         <https://bugs.webkit.org/show_bug.cgi?id=24330>
22
23         Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
24
25         * dom/ExceptionCode.cpp:
26         (WebCore::xmlHttpRequestExceptionNames):
27         Added missing ABORT_ERR whose absence caused an assert.
28
29         * loader/WorkerThreadableLoader.cpp:
30         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
31         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
32         Add more logic to handle the termination case for sync xhr.
33
34 2009-03-04  Eric Carlson  <eric.carlson@apple.com>
35
36         Reviewed by Antti Koivisto.
37
38         https://bugs.webkit.org/show_bug.cgi?id=24364
39         Add support for HTMLMediaElement canPlayType method. Make
40         MediaPlayer::supportsType take a ContentType instead of a
41         separate mime type and codecs parameter.
42
43         Test: media/video-can-play-type.html
44
45         * dom/DOMImplementation.cpp:
46         (WebCore::DOMImplementation::createDocument):
47         * html/HTMLMediaElement.cpp:
48         (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
49         (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
50         (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
51         (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
52         * html/HTMLMediaElement.h: Add prototype.
53         * html/HTMLMediaElement.idl: Ditto.
54         * platform/graphics/MediaPlayer.cpp:
55         (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
56         (WebCore::MediaPlayer::supportsType): Ditto.
57         * platform/graphics/MediaPlayer.h:
58
59 2009-03-04  Antti Koivisto  <antti@apple.com>
60
61         Reviewed by Dave Hyatt.
62
63         https://bugs.webkit.org/show_bug.cgi?id=24359
64         Repaint throttling mechanism
65         
66         Excessive repainting can slow down page loadind. This implements a timer
67         based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
68         enabled by default.
69
70         * loader/FrameLoader.cpp:
71         (WebCore::FrameLoader::checkCompleted):
72         * page/EventHandler.cpp:
73         (WebCore::EventHandler::dispatchDragEvent):
74         (WebCore::EventHandler::dispatchMouseEvent):
75         (WebCore::EventHandler::keyEvent):
76         (WebCore::EventHandler::handleTextInputEvent):
77         * page/FrameView.cpp:
78         (WebCore::FrameView::FrameView):
79         (WebCore::FrameView::reset):
80         (WebCore::FrameView::repaintContentRectangle):
81         (WebCore::FrameView::beginDeferredRepaints):
82         (WebCore::FrameView::endDeferredRepaints):
83         (WebCore::FrameView::checkStopDelayingDeferredRepaints):
84         (WebCore::FrameView::doDeferredRepaints):
85         (WebCore::FrameView::updateDeferredRepaintDelay):
86         (WebCore::FrameView::resetDeferredRepaintDelay):
87         (WebCore::FrameView::adjustedDeferredRepaintDelay):
88         (WebCore::FrameView::deferredRepaintTimerFired):
89         (WebCore::FrameView::paintContents):
90         * page/FrameView.h:
91
92 2009-03-04  Sam Weinig  <sam@webkit.org>
93
94         Rubber-stamped by Antti Koivisto.
95
96         Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
97
98         * dom/Document.cpp:
99         (WebCore::Document::Document):
100         * dom/Document.h:
101         (WebCore::Document::haveStylesheetsLoaded):
102         * html/HTMLTokenizer.cpp:
103         (WebCore::HTMLTokenizer::scriptHandler):
104         * loader/Cache.cpp:
105         (WebCore::Cache::requestResource):
106         * loader/CachedCSSStyleSheet.cpp:
107         (WebCore::CachedCSSStyleSheet::checkNotify):
108         * loader/DocLoader.h:
109         * loader/FrameLoader.cpp:
110         (WebCore::FrameLoader::FrameLoader):
111         (WebCore::FrameLoader::requestFrame):
112         (WebCore::FrameLoader::stopLoading):
113         (WebCore::FrameLoader::begin):
114         (WebCore::FrameLoader::write):
115         (WebCore::FrameLoader::endIfNotLoadingMainResource):
116         (WebCore::FrameLoader::checkCompleted):
117         (WebCore::FrameLoader::requestObject):
118         (WebCore::FrameLoader::loadItem):
119         * loader/FrameLoader.h:
120
121 2009-03-02  Xan Lopez  <xan@gnome.org>
122
123         Reviewed by Mark Rowe.
124
125         https://bugs.webkit.org/show_bug.cgi?id=24287
126         [GTK] Move auth dialog feature to WebKit/
127
128         Remove WebKitSoupAuthDialog files from build and stop using it.
129
130         * GNUmakefile.am:
131         * platform/network/soup/ResourceHandleSoup.cpp:
132         (WebCore::ensureSessionIsInitialized):
133         * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
134         * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
135
136 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
137
138         Reviewed by Dave Hyatt
139         
140         https://bugs.webkit.org/show_bug.cgi?id=24361
141         
142         Reinstate code that sets result.innerNode when hitTest() returns true,
143         but never filled in the innerNode. Fixes hit testing of generated content.
144
145         Test: fast/css-generated-content/hit-test-generated-content.html
146
147         * rendering/RenderLayer.cpp:
148         (WebCore::RenderLayer::hitTestContents):
149
150 2009-03-04  Adam Barth  <abath@webkit.org>
151
152         Reviewed by Alexey Proskuryakov.
153
154         https://bugs.webkit.org/show_bug.cgi?id=24356
155
156         Fix WebKit style for allowUniversalAccessFromFileURLs.
157
158         * WebCore.base.exp:
159         * dom/Document.cpp:
160         (WebCore::Document::initSecurityContext):
161         * page/Settings.cpp:
162         (WebCore::Settings::Settings):
163         (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
164         * page/Settings.h:
165         (WebCore::Settings::allowUniversalAccessFromFileURLs):
166
167 2009-03-04  Brady Eidson  <beidson@apple.com>
168
169         Reviewed by Darin Adler
170
171         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
172
173         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
174         consolidated some of the various decision making pieces of the Cache into the new method
175         FrameLoader::cachePolicy().
176
177         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
178         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
179         same URL for this image every time and expects it to be reloaded with each new card.
180
181         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
182         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
183
184         * loader/FrameLoader.cpp:
185         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
186           condition for returning CachePolicyReload.
187
188 2009-03-04  Timothy Hatcher  <timothy@apple.com>
189
190         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
191         "LOCAL STORAGE" and "SESSION STORAGE".
192
193 2009-03-04  Timothy Hatcher  <timothy@apple.com>
194
195         Fix a regression where the Web Inspector console would not animate
196         in or out correctly.
197
198         Reviewed by Anders Carlsson.
199
200         * inspector/front-end/inspector.css: Move a z-index to a child element
201         to get the correct stacking order during the animation.
202
203 2009-03-03  David Hyatt  <hyatt@apple.com>
204
205         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
206
207         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
208         the final position against the y position estimate until after the clear has happened.  This gets rid
209         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
210
211         Reviewed by Dan Bernstein
212
213         Added fast/block/float/nested-clearance.html
214
215         * rendering/RenderBlock.cpp:
216         (WebCore::RenderBlock::collapseMargins):
217         (WebCore::RenderBlock::clearFloatsIfNeeded):
218         (WebCore::RenderBlock::estimateVerticalPosition):
219         (WebCore::RenderBlock::layoutBlockChildren):
220         (WebCore::RenderBlock::getClearDelta):
221         * rendering/RenderBlock.h:
222
223 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
224
225         Reviewed by Simon Hausmann.
226
227         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
228         instead of QMatrix. This allows perspective transformations since QTransform is
229         a true 3x3 matrix.
230
231         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
232         (WebCore::GraphicsContext::getCTM):
233         (WebCore::GraphicsContext::restorePlatformState):
234         (WebCore::GraphicsContext::fillPath):
235         (WebCore::GraphicsContext::strokePath):
236         (WebCore::GraphicsContext::fillRect):
237         (WebCore::GraphicsContext::translate):
238         (WebCore::GraphicsContext::rotate):
239         (WebCore::GraphicsContext::scale):
240         (WebCore::GraphicsContext::concatCTM):
241         * platform/graphics/qt/ImageQt.cpp:
242         (WebCore::Image::drawPattern):
243         * platform/graphics/qt/PathQt.cpp:
244         (WebCore::Path::translate):
245         (WebCore::Path::transform):
246         * platform/graphics/qt/PatternQt.cpp:
247         (WebCore::Pattern::createPlatformPattern):
248         * platform/graphics/qt/TransformationMatrixQt.cpp:
249         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
250         to QMatrix with one to QTransform.
251         * platform/graphics/transforms/TransformationMatrix.h:
252         * platform/graphics/qt/FontQt.cpp:
253
254 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
255
256         Reviewed by Simon Hausmann.
257
258         https://bugs.webkit.org/show_bug.cgi?id=24151
259         Fix Qt/S60 build break
260
261         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
262         * platform/qt/FileSystemQt.cpp: Ditto
263         (WebCore::unloadModule):
264
265 2009-03-03  Mike Belshe  <mike@belshe.com>
266
267         Reviewed by Alexey Proskuryakov.
268
269         https://bugs.webkit.org/show_bug.cgi?id=21939
270         Uninitialized ExceptionCode in DOMWindow::postMessage
271
272         * dom/MessagePort.cpp:
273         (WebCore::MessagePort::postMessage):
274
275 2009-03-03  David Kilzer  <ddkilzer@apple.com>
276
277         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
278
279         Reviewed by Mark Rowe.
280
281         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
282         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
283         sure various build phase scripts work with the installhdrs build
284         phase.
285
286         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
287         based on PLATFORM_NAME to work around the missing definition on
288         Tiger.
289         * Configurations/WebCore.xcconfig: Added
290         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
291         the "Generate Derived Sources" script.  Added
292         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
293
294         * WebCore.xcodeproj/project.pbxproj:
295         - Added shell code to prevent running "Check For Global
296           Initializers", "Check For Exit Time Destructors" and "Check
297           For Weak VTables" scripts during the installhdrs build phase.
298         - Made "Generate Derived Sources" work for the installhdrs build
299           phase.  Also simplified setting of CREATE_HASH_TABLE by using
300           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
301
302 2009-03-02  Adam Langley  <agl@google.com>
303
304         Reviewed by Darin Fisher.
305
306         Chromium Linux: Switch to using Skia to render widgets.
307
308         In order to sandbox the Chromium renderer on Linux we need to remove
309         the X connection. GTK cannot render without an X connection so, for
310         now, we render widgets ourselves.
311
312         Previously didn't use anti-alias fonts in order to match Windows font
313         rendering exactly. This was helpful when bootstrapping our layout
314         tests. Now, however, we are ready to enable it.
315
316         https://bugs.webkit.org/show_bug.cgi?id=24244
317
318         * platform/chromium/ScrollbarThemeChromium.cpp:
319         (WebCore::ScrollbarThemeChromium::buttonSize):
320         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
321         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
322         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
323         (WebCore::ScrollbarThemeChromium::paintButton):
324         (WebCore::ScrollbarThemeChromium::paintThumb):
325         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
326         (WebCore::FontPlatformData::setupPaint):
327         * platform/graphics/skia/PlatformContextSkia.cpp:
328         (PlatformContextSkia::PlatformContextSkia):
329         (PlatformContextSkia::~PlatformContextSkia):
330         * platform/graphics/skia/PlatformContextSkia.h:
331         * rendering/RenderThemeChromiumGtk.cpp: Removed.
332         * rendering/RenderThemeChromiumGtk.h: Removed.
333         * rendering/RenderThemeChromiumLinux.cpp: Added.
334         * rendering/RenderThemeChromiumLinux.h: Added.
335
336 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
337
338         Reviewed by Darin Fisher.
339
340         https://bugs.webkit.org/show_bug.cgi?id=24261
341         Fix return types.
342
343         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
344
345         * bindings/v8/V8Binding.h:
346         (WebCore::toInt32): change return type to int
347         (WebCore::toFloat): change return type to float.
348
349 2009-03-03  Anders Carlsson  <andersca@apple.com>
350
351         Reviewed by John Sullivan.
352
353         https://bugs.webkit.org/show_bug.cgi?id=22884
354         <rdar://problem/6449783>
355         modified layout test crashes Safari
356
357         Null check NPStream before dereferencing it.
358         
359         * plugins/PluginView.cpp:
360         (WebCore::PluginView::destroyStream):
361
362 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
363
364         Reviewed by Simon Fraser.
365
366         Fix for <rdar://problem/6641045>
367         Don't call QTKit to get movie properties until movie metadata has been loaded.
368
369         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
370         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
371         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
372         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
373         (WebCore::MediaPlayerPrivate::play): Ditto.
374         (WebCore::MediaPlayerPrivate::pause): Ditto.
375         (WebCore::MediaPlayerPrivate::duration): Ditto.
376         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
377         (WebCore::MediaPlayerPrivate::seek): Ditto.
378         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
379         (WebCore::MediaPlayerPrivate::paused): Ditto.
380         (WebCore::MediaPlayerPrivate::seeking): Ditto.
381         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
382         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
383         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
384         (WebCore::MediaPlayerPrivate::setRate): Ditto.
385         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
386         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
387         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
388
389 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
390
391         - Spelling fix.
392
393         * page/Console.cpp:
394         (WebCore::Console::profile):
395
396 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
397
398         Reviewed by Darin Fisher.
399
400         https://bugs.webkit.org/show_bug.cgi?id=23657
401         Remove Database API callback IDLs from the project. 
402         They were removed in r40633.
403
404         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
405
406 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
407
408         Reviewed by Oliver Hunt.
409
410         <rdar://problem/6639110> console.profile() doesn't work without a title
411
412         * page/Console.cpp:
413         (WebCore::Console::profile): If there is no title assume this is a user
414         initiated profile and give it the next incremented title name.
415
416 2009-03-03  Timothy Hatcher  <timothy@apple.com>
417
418         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
419         the console code and refactored things to have fewer code paths and duplication.
420
421         rdar://problem/6367127
422         https://bugs.webkit.org/show_bug.cgi?id=24329
423
424         Reviewed by Kevin McCullough.
425
426         Test: manual-tests/inspector/console-dir.html
427
428         * bindings/js/JSInspectedObjectWrapper.cpp:
429         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
430         to fix an ASSERT about using a wrapper from the wrong ExecState.
431         * bindings/js/JSQuarantinedObjectWrapper.cpp:
432         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
433         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
434         * inspector/front-end/Console.js:
435         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
436         When forceObjectFormat is true, the only formatter used is _formatobject.
437         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
438         (WebInspector.Console.prototype._formatstring): Ditto.
439         (WebInspector.Console.prototype._formatregexp): Ditto.
440         (WebInspector.Console.prototype._formatarray): Ditto.
441         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
442         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
443         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
444         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
445         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
446         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
447         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
448         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
449         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
450         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
451         * inspector/front-end/utilities.js:
452         (Object.type): Return "node" for Node objects.
453         (Object.describe): Handle the "node" type.
454         * page/Console.cpp:
455         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
456         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
457         * page/Console.h:
458         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
459
460 2009-03-03  Scott Violet  <sky@google.com>
461
462         Reviewed by Eric Seidel.
463
464         https://bugs.webkit.org/show_bug.cgi?id=24325
465         Crash on replacing document contents during drop.
466
467         Makes sure a node is in the document during a move before using it.
468
469         Test: fast/events/crash-on-mutate-during-drop.html
470
471         * editing/MoveSelectionCommand.cpp:
472         (WebCore::MoveSelectionCommand::doApply):
473
474 2009-03-03  Jungshik Shin <jshin@chromium.org>
475
476         Reviewed by Eric Seidel.
477
478         https://bugs.webkit.org/show_bug.cgi?id=23028
479         Enable dynamic web font support to Chromium on Windows.
480         Files that were omitted by mistake in the latest patch
481         that was landed.
482
483         * loader/CachedFont.cpp:
484         (WebCore::CachedFont::~CachedFont):
485         (WebCore::CachedFont::ensureCustomFontData):
486         (WebCore::CachedFont::platformDataFromCustomData):
487         (WebCore::CachedFont::allClientsRemoved):
488         * platform/graphics/chromium/FontCustomPlatformData.cpp:
489         (WebCore::EOTStream::EOTStream):
490         (WebCore::createFontCustomPlatformData):
491         * platform/graphics/win/FontCustomPlatformData.cpp:
492         (WebCore::EOTStream::EOTStream):
493         (WebCore::createFontCustomPlatformData):
494
495 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
496
497         Reviewed by Alexey Proskuryakov.
498
499         https://bugs.webkit.org/show_bug.cgi?id=16826
500         [Gtk] Implement WebKitDownload
501
502         Make the Soup backend able to handle requests without a frame,
503         since we may have such things now that we support downloads.
504
505         * platform/network/ResourceHandleInternal.h:
506         * platform/network/soup/ResourceHandleSoup.cpp:
507         (WebCore::ResourceHandle::start):
508
509 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
510
511         Reviewed by Eric Seidel.
512
513         https://bugs.webkit.org/show_bug.cgi?id=24331
514         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
515
516         * bindings/v8/custom/V8AttrCustom.cpp: Added.
517         * bindings/v8/custom/V8CustomBinding.cpp: Added.
518         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
519         * bindings/v8/custom/V8ElementCustom.cpp: Added.
520         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
521         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
522
523 2009-03-03  Brady Eidson  <beidson@apple.com>
524
525         Reviewed by Darin Adler
526
527         <rdar://problem/6616664> - Quick looks of various file types is broken
528
529         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
530         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
531         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
532
533         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
534         before that patch.
535
536         * loader/FrameLoader.cpp:
537         (WebCore::FrameLoader::addExtraFieldsToRequest):
538
539         * platform/network/ResourceRequestBase.cpp:
540         (WebCore::ResourceRequestBase::setMainDocumentURL):
541
542 2009-03-03  Chris Marrin  <cmarrin@apple.com>
543
544         Reviewed by Simon Fraser.
545
546         https://bugs.webkit.org/show_bug.cgi?id=24256
547
548         Added a WebCoreForceSoftwareAnimation flag.
549
550         * platform/graphics/mac/GraphicsLayerCA.mm:
551         (WebCore::forceSoftwareAnimation):
552         (WebCore::GraphicsLayerCA::setOpacity):
553         (WebCore::GraphicsLayerCA::animateTransform):
554         (WebCore::GraphicsLayerCA::animateFloat):
555
556 2009-03-02  Chris Marrin  <cmarrin@apple.com>
557
558         Reviewed by Sam Weinig.
559
560         https://bugs.webkit.org/show_bug.cgi?id=24257
561
562         Added prototype properties for several classes with constructors that
563         were missing them, including the one mentioned in the bug.
564
565         Test: fast/dom/Window/custom-constructors.html
566
567         * bindings/js/JSAudioConstructor.cpp:
568         (WebCore::JSAudioConstructor::JSAudioConstructor):
569         * bindings/js/JSDOMWindowBase.cpp:
570         (jsDOMWindowBaseWebKitCSSMatrix):
571         * bindings/js/JSImageConstructor.cpp:
572         (WebCore::JSImageConstructor::JSImageConstructor):
573         * bindings/js/JSOptionConstructor.cpp:
574         (WebCore::JSOptionConstructor::JSOptionConstructor):
575         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
576         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
577         * bindings/js/JSWebKitCSSMatrixConstructor.h:
578         * bindings/js/JSWebKitPointConstructor.cpp:
579         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
580         * bindings/js/JSWorkerConstructor.cpp:
581         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
582
583 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
584
585         Reviewed by Darin Fisher.
586
587         https://bugs.webkit.org/show_bug.cgi?id=24321
588         Add V8 bindings headers.
589
590         * bindings/v8/V8Binding.h: Added.
591         * bindings/v8/V8Proxy.h: Added.
592         * bindings/v8/custom/V8CustomBinding.h: Added.
593         * bindings/v8/custom/V8CustomEventListener.h: Added.
594
595 2009-03-03  Jungshik Shin <jshin@chromium.org>
596
597         Reviewed by Eric Seidel.
598
599         https://bugs.webkit.org/show_bug.cgi?id=23803
600         Fix an 'off-by-1' error in ChromiumWin's font fallback.
601
602         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
603         (WebCore::FontCache::getFontDataForCharacters):
604
605 2009-03-03  Jungshik Shin  <jshin@chromium.org>
606
607         Reviewed by Eric Seidel.
608
609         http://bugs.webkit.org/show_bug.cgi?id=23028
610         Enable dynamic web font support to Chromium on Windows: Part 1
611         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
612           from platform/graphics/win because both Windows port and Chromium Windows
613           port will use them.
614         - Adjust WebCore.vcproj accordingly.
615
616         * WebCore.vcproj/WebCore.vcproj:
617         * platform/graphics/opentype: Added.
618         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
619         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
620         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
621         * platform/graphics/win/OpenTypeUtilities.h: Removed.
622
623 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
624
625         Reviewed by Dave Hyatt
626
627         https://bugs.webkit.org/show_bug.cgi?id=24312
628         
629         Take 3D transforms into account when hit testing:
630         
631         1. Maintain a bit on each RenderLayer that is set when the layer
632            has 3d descendants, so that we know when to fall into the slow
633            hit testing path.
634            
635         2. Make a ref-counted HitTestingTransformState, which is used to store
636            an accumulated transform, and the hit test point, and hitTestRect
637            in the plane of the ancestor non-3d ('flattening') layer.
638            
639            It's ref-counted so we can heap allocate it (to avoid stack bloat),
640            and avoid copying when hitTestLayer calls itself after applying the transform.
641            
642         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
643            3D transforms, or to do deep depth-testing when traversing a preserves-3d
644            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
645            layer, which allows for correct depth testing.
646            
647            The existing early-return codepath is unaffected when there are no 3d transforms
648            and no preserve-3d.
649
650         * rendering/RenderLayer.cpp:
651         (WebCore::RenderLayer::RenderLayer):
652         (WebCore::RenderLayer::updateTransform):
653         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
654         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
655         (WebCore::RenderLayer::hitTest):
656         (WebCore::computeZOffset):
657         (WebCore::RenderLayer::createLocalTransformState):
658         (WebCore::RenderLayer::hitTestLayer):
659         (WebCore::RenderLayer::hitTestContents):
660         * rendering/RenderLayer.h:
661         (WebCore::RenderLayer::preserves3D):
662         (WebCore::RenderLayer::has3DTransform):
663         (WebCore::RenderLayer::setHas3DTransformedDescendant):
664         (WebCore::RenderLayer::has3DTransformedDescendant):
665         * rendering/RenderLayerBacking.cpp:
666         * rendering/TransformState.cpp:
667         (WebCore::TransformState::flatten):
668         (WebCore::TransformState::mappedPoint):
669         (WebCore::HitTestingTransformState::move):
670         (WebCore::HitTestingTransformState::applyTransform):
671         (WebCore::HitTestingTransformState::flatten):
672         (WebCore::HitTestingTransformState::mappedPoint):
673         (WebCore::HitTestingTransformState::mappedQuad):
674         * rendering/TransformState.h:
675         (WebCore::TransformState::TransformState):
676         (WebCore::HitTestingTransformState::create):
677         (WebCore::HitTestingTransformState::move):
678         (WebCore::HitTestingTransformState::HitTestingTransformState):
679
680 2009-03-03  Brett Wilson  <brettw@chromium.org>
681
682         Fix uninitialized memory reads in the Chromium Windows transparency
683         code that were identified by Purify,
684
685         Reviewed by Darin Fisher.
686
687         * platform/graphics/chromium/TransparencyWin.cpp:
688         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
689         (WebCore::TransparencyWin::initializeNewContext):
690
691 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
692
693         Reviewed by Dave Hyatt
694
695         https://bugs.webkit.org/show_bug.cgi?id=24312
696         
697         Factor the code that compute a transform relative to the container
698         into RenderObject::transformFromContainer().
699         
700         * rendering/RenderBox.cpp:
701         (WebCore::RenderBox::mapLocalToAbsolutePoint):
702         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
703         * rendering/RenderObject.cpp:
704         (WebCore::RenderObject::transformFromContainer):
705         * rendering/RenderObject.h:
706
707 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
708
709         Reviewed by Dave Hyatt
710
711         https://bugs.webkit.org/show_bug.cgi?id=24317
712         
713         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
714         the superclass found a node, otherwise we set the innerNode of the
715         HitTestResult, but don't actually report that we found a hit.
716
717         * rendering/RenderTextControlMultiLine.cpp:
718         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
719
720 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
721
722         Reviewed by Anders Carlsson.
723
724         https://bugs.webkit.org/show_bug.cgi?id=23707
725         resizing plugins does not work, because the plugin never gets informed
726
727         Make gtk plugins resize correctly, by sending them the setwindow event
728         correctly. Also ensure that all plugin eventing is done with correct
729         locking/calling. Mostly copied from mac implementation.
730
731         manual test: manual-tests/gtk/plugin-resize-scroll.html
732
733         * plugins/PluginView.h:
734         * plugins/gtk/PluginViewGtk.cpp:
735         (WebCore::PluginView::dispatchNPEvent):
736         ensure locking/calling for NPEvents
737         (WebCore::PluginView::updatePluginWidget):
738         if something changed, let setNPWindowIfNeeded handle it
739         (WebCore::PluginView::paint):
740         (WebCore::PluginView::handleKeyboardEvent):
741         (WebCore::PluginView::handleMouseEvent):
742         ensure calling conventions
743         (WebCore::PluginView::setNPWindowRect):
744         just pass control to setNPWindowIfNeeded
745         (WebCore::PluginView::setNPWindowIfNeeded):
746         event the plugin correctly of new window
747         (WebCore::PluginView::init):
748         init through the new setup
749
750 2009-03-03  Mike Belshe  <mike@belshe.com>
751
752         Reviewed by Darin Fisher.
753
754         https://bugs.webkit.org/show_bug.cgi?id=24311
755         Make IDL returning DOMObject use [V8Custom]
756
757         * dom/Document.idl:
758         * html/HTMLCanvasElement.idl:
759
760 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
761
762         Reviewed by Adele Peterson
763
764         https://bugs.webkit.org/show_bug.cgi?id=24313
765         
766         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
767         HitTestResult, then it had better well return |true|. And m_innerBlock
768         could never have been set as the hit node by the superclass, because
769         the superclass knows nothing about m_innerBlock.
770         
771         Test: fast/forms/input-hit-test-border.html
772
773         * rendering/RenderTextControlSingleLine.cpp:
774         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
775
776 2009-03-02  Sam Weinig  <sam@webkit.org>
777
778         Reviewed by Mark Rowe.
779
780         Enable Geolocation (except on Tiger and Leopard).
781
782         * Configurations/WebCore.xcconfig:
783
784 2009-03-02  Ojan Vafai  <ojan@chromium.org>
785
786         Reviewed by Adele Peterson.
787
788         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
789         Null out m_highlightedNode on hideHighlight().
790         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
791
792         * inspector/InspectorController.cpp:
793         (WebCore::InspectorController::hideHighlight):
794
795 2009-03-02  Sam Weinig  <sam@webkit.org>
796
797         Reviewed by Geoffrey Garen.
798
799         Fix for <rdar://problem/6507404> Add Geolocation support.
800
801         This is not yet turned on for any Mac platform.
802
803         * WebCore.xcodeproj/project.pbxproj:
804         * page/Chrome.cpp:
805         (WebCore::Chrome::shouldAllowGeolocationForFrame):
806         * page/Chrome.h:
807         * page/ChromeClient.h:
808         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
809         * page/Geolocation.cpp:
810         (WebCore::Geolocation::Geolocation):
811         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
812         will not be alive at this point.
813         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
814         return a PERMISSION_DENIED if not.
815         (WebCore::Geolocation::watchPosition): Ditto.
816         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
817         to allow geolocation and cache the result. 
818         * page/Geolocation.h:
819         (WebCore::Geolocation::):
820         * platform/GeolocationService.cpp:
821         * platform/GeolocationService.h:
822         (WebCore::GeolocationService::~GeolocationService):
823         (WebCore::GeolocationService::stopUpdating):
824         * platform/mac/GeolocationServiceMac.h: Added.
825         (WebCore::GeolocationServiceMac::lastPosition):
826         (WebCore::GeolocationServiceMac::lastError):
827         * platform/mac/GeolocationServiceMac.mm: Added.
828         (WebCore::GeolocationService::create):
829         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
830         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
831         (WebCore::GeolocationServiceMac::startUpdating):
832         (WebCore::GeolocationServiceMac::stopUpdating):
833         (WebCore::GeolocationServiceMac::suspend):
834         (WebCore::GeolocationServiceMac::resume):
835         (WebCore::GeolocationServiceMac::positionChanged):
836         (WebCore::GeolocationServiceMac::errorOccurred):
837         (-[WebCoreCoreLocationObserver initWithCallback:]):
838         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
839         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
840
841 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
842
843         Build fixes for wxWidgets Mac trunk build.
844
845         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
846         (wxFontProperties::wxFontProperties):
847         (GetTextExtent):
848         * webcore-wx.bkl:
849
850 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
851
852         wxGTK missing header build fix.
853
854         * platform/wx/wxcode/gtk/fontprops.cpp:
855
856 2009-03-02  Dan Bernstein  <mitz@apple.com>
857
858         Reviewed by Adam Roben.
859
860         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
861           REGRESSION: Windows Build Not Selecting Proper Font
862
863         * platform/graphics/win/FontCacheWin.cpp:
864         (WebCore::createGDIFont): Added back code to verify that the created
865         HFONT has the requested face name.
866
867 2009-03-02  Timothy Hatcher  <timothy@apple.com>
868
869         Fixes a regression caused by splitting the input and output of console commands.
870
871         https://bugs.webkit.org/show_bug.cgi?id=24293
872
873         Reviewed by Kevin McCullough.
874
875         * inspector/front-end/Console.js:
876         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
877         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
878
879 2009-03-02  Timothy Hatcher  <timothy@apple.com>
880
881         Make exception messages and logged Error objects display consistently.
882
883         https://bugs.webkit.org/show_bug.cgi?id=18983
884
885         Reviewed by Adam Roben.
886
887         * English.lproj/localizedStrings.js: Remove a string for line numbers.
888         * inspector/front-end/Console.js:
889         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
890         boolean to the ConsoleCommandResult constructor and don't pass level.
891         (WebInspector.Console.prototype._formatnode): Fix a className typo.
892         (WebInspector.Console.prototype._formaterror): Add an error-message
893         classed span around the message to show in red and remove the
894         console-message-url class from the link so it doesn't float right.
895         Instead enclose the link in parentheses and use displayNameForURL
896         to shorten the URL in the link.
897         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
898         how line numbers are shown since link underlining a string with
899         parentheses looks bad.
900         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
901         instead of a level and get line and URL based on that flag.
902         * inspector/front-end/inspector.css: Tweaks to the styles.
903
904 2009-03-02  Ojan Vafai  <ojan@chromium.org>
905
906         Reviewed by Adele Peterson.
907
908         Bug 24048: extra windows button padding doesn't apply when there's no appearance
909         <https://bugs.webkit.org/show_bug.cgi?id=24048>
910
911         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
912
913         No tests added as existing tests already cover this behavior.
914
915         * rendering/RenderButton.cpp:
916         (WebCore::RenderButton::setupInnerStyle):
917         * rendering/RenderTheme.cpp:
918         * rendering/RenderTheme.h:
919         (WebCore::RenderTheme::buttonInternalPaddingLeft):
920         (WebCore::RenderTheme::buttonInternalPaddingRight):
921         (WebCore::RenderTheme::buttonInternalPaddingTop):
922         * rendering/RenderThemeChromiumGtk.cpp:
923         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
924         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
925         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
926         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
927         * rendering/RenderThemeChromiumGtk.h:
928         * rendering/RenderThemeChromiumWin.cpp:
929         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
930         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
931         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
932         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
933         * rendering/RenderThemeChromiumWin.h:
934         * rendering/RenderThemeWin.cpp:
935         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
936         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
937         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
938         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
939         * rendering/RenderThemeWin.h:
940
941 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
942
943         Build fix for Qt port.  Remove unnecessary assert.
944
945         * platform/graphics/qt/ImageBufferQt.cpp:
946         (WebCore::ImageBuffer::putImageData):
947
948 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
949
950         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
951
952         https://bugs.webkit.org/show_bug.cgi?id=24227
953         Ensure that the checkForSolidColor() optimization is correctly triggered
954         for all cases of drawPattern.  Currently, the optimization was not triggered
955         when the check had not been previously performed via a request for the
956         image's NativeImagePtr.
957
958         Implement the Qt version of the checkForSolidColor() method.  Combined with
959         the bug fix this reduces the time it takes to draw a repeating background
960         of a 1x1 image from ~50msecs to ~0msecs on my machine.
961
962         * platform/graphics/BitmapImage.cpp:
963         (WebCore::BitmapImage::BitmapImage):
964         * platform/graphics/BitmapImage.h:
965         (WebCore::BitmapImage::mayFillWithSolidColor):
966         * platform/graphics/Image.h:
967         (WebCore::Image::mayFillWithSolidColor):
968         * platform/graphics/cairo/ImageCairo.cpp:
969         (WebCore::BitmapImage::BitmapImage):
970         (WebCore::BitmapImage::checkForSolidColor):
971         * platform/graphics/cg/ImageCG.cpp:
972         (WebCore::BitmapImage::BitmapImage):
973         (WebCore::BitmapImage::checkForSolidColor):
974         * platform/graphics/qt/ImageQt.cpp:
975         (WebCore::BitmapImage::checkForSolidColor):
976         * platform/graphics/skia/ImageSkia.cpp:
977         (WebCore::BitmapImage::checkForSolidColor):
978         * platform/graphics/wx/ImageWx.cpp:
979         (WebCore::BitmapImage::checkForSolidColor):
980
981 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
982
983         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
984         they show up in the tarball.
985
986         * GNUmakefile.am:
987
988 2009-03-02  Dirk Schulze  <krit@webkit.org>
989
990         Reviewed by Holger Freyther.
991
992         Added putImageData to Qt. Discussed with Ariya Hidayat.
993
994         [Qt] lacks putImageData support in Canvas
995         https://bugs.webkit.org/show_bug.cgi?id=22186
996
997         * platform/graphics/qt/ImageBufferQt.cpp:
998         (WebCore::ImageBuffer::putImageData):
999
1000 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1001
1002         Show exception messages again when evaluating bad expressions in the
1003         Web Inspector's console.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=19890
1006
1007         Reviewed by Oliver Hunt.
1008
1009         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1010         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
1011         Fix the order in which the exception is set and cleared now that the
1012         exception is stored in the shared GlobalData, not per ExecState.
1013
1014 2009-02-28  Timothy Hatcher  <timothy@apple.com>
1015
1016         Make input in the Web Inspector console print before any output
1017         that might be added by the called function.
1018
1019         https://bugs.webkit.org/show_bug.cgi?id=19931
1020
1021         Reviewed by Oliver Hunt.
1022
1023         * inspector/front-end/Console.js:
1024         (WebInspector.Console.prototype._enterKeyPressed): Add the command
1025         message before evaluating the result. Associate the originating
1026         command to the result, so if they are adjacent there is no divider.
1027         (WebInspector.ConsoleCommand): No longer take a result.
1028         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
1029         code removed since it isn't used now.
1030         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
1031         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
1032         Call the ConsoleMessage toMessageElement and add a style class.
1033         * inspector/front-end/inspector.css: Add a new style class for
1034         adjacent results to hide the divider. Also tweak the position of
1035         the disclosure triangle for objects to not use the left margin.
1036
1037 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
1038
1039         Reviewed by Oliver Hunt.
1040
1041         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
1042         <https://bugs.webkit.org/show_bug.cgi?id=24282>
1043
1044         When fetching an array of elements with a range, attachment views need to be returned
1045         instead of the actual attachment.
1046
1047         * page/mac/AccessibilityObjectWrapper.mm:
1048         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1049         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1050
1051 2009-03-01  Ojan Vafai  <ojan@chromium.org>
1052
1053         Reviewed by Eric Seidel.
1054
1055         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
1056         <https://bugs.webkit.org/show_bug.cgi?id=24251>
1057         
1058         Make RenderObject::positionForCoordinate non-virtual and
1059         RenderObject::positionForPoint virtual in preparation for
1060         removing positionFor* from RenderObject/RenderText.
1061
1062         * page/Frame.cpp:
1063         (WebCore::Frame::visiblePositionForPoint):
1064         * rendering/RenderBR.cpp:
1065         (WebCore::RenderBR::positionForPoint):
1066         * rendering/RenderBR.h:
1067         * rendering/RenderBlock.cpp:
1068         (WebCore::RenderBlock::positionForPoint):
1069         * rendering/RenderBlock.h:
1070         * rendering/RenderBox.cpp:
1071         (WebCore::RenderBox::positionForPoint):
1072         * rendering/RenderBox.h:
1073         * rendering/RenderInline.cpp:
1074         (WebCore::RenderInline::positionForPoint):
1075         * rendering/RenderInline.h:
1076         * rendering/RenderObject.cpp:
1077         (WebCore::RenderObject::positionForCoordinates):
1078         (WebCore::RenderObject::positionForPoint):
1079         * rendering/RenderObject.h:
1080         * rendering/RenderReplaced.cpp:
1081         (WebCore::RenderReplaced::positionForPoint):
1082         * rendering/RenderReplaced.h:
1083         * rendering/RenderSVGInlineText.cpp:
1084         (WebCore::RenderSVGInlineText::positionForPoint):
1085         * rendering/RenderSVGInlineText.h:
1086         * rendering/RenderText.cpp:
1087         (WebCore::RenderText::positionForPoint):
1088         * rendering/RenderText.h:
1089
1090 2009-03-01  Larry Ewing  <lewing@novell.com>
1091
1092         Reviewed by Alexey Proskuryakov.
1093
1094         https://bugs.webkit.org/show_bug.cgi?id=24080
1095         NPN_GetValue casting to the wrong type and writing outside bounds
1096
1097         Make sure to cast the value to the correct type so that only
1098         memory owned by the value is written to.
1099
1100         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
1101         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
1102         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
1103         (PluginView::getValue):
1104
1105 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
1106
1107         Reviewed by Simon Fraser.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=24197 and
1110         https://bugs.webkit.org/show_bug.cgi?id=23512
1111
1112         The Windows version of cgColor() is conditionally compiled using
1113         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
1114         can use the OS X version instead of the Windows version.
1115
1116         Also rename cgColor() -> createCGColor()
1117
1118         No observable change in behavior, so no test.
1119
1120         * platform/graphics/Color.h:
1121         * platform/graphics/cg/ColorCG.cpp:
1122         (WebCore::createCGColor):
1123         * platform/graphics/cg/GraphicsContextCG.cpp:
1124         (WebCore::GraphicsContext::setPlatformShadow):
1125         * platform/graphics/mac/ColorMac.mm:
1126         (WebCore::createCGColor):
1127         * platform/graphics/mac/GraphicsContextMac.mm:
1128         (WebCore::GraphicsContext::drawFocusRing):
1129         * platform/graphics/mac/GraphicsLayerCA.mm:
1130         (WebCore::setLayerBorderColor):
1131         (WebCore::setLayerBackgroundColor):
1132         (WebCore::GraphicsLayerCA::setBackgroundColor):
1133         * platform/graphics/win/GraphicsContextCGWin.cpp:
1134         (WebCore::GraphicsContext::drawFocusRing):
1135         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
1136         (WebCore::ciColor):
1137
1138 2009-03-01  David Levin  <levin@chromium.org>
1139
1140         Reviewed by Alexey Proskuryakov.
1141
1142         Bug 24271: XMLHttpRequest needs js bindings for Workers.
1143         <https://bugs.webkit.org/show_bug.cgi?id=24271>
1144
1145         Tests: http/tests/xmlhttprequest/workers/methods-async.html
1146                http/tests/xmlhttprequest/workers/methods.html
1147
1148         * bindings/js/JSWorkerContextBase.cpp:
1149         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
1150         (jsWorkerContextBaseXMLHttpRequest):
1151         (setJSWorkerContextBaseXMLHttpRequest):
1152         Expose XMLHttpRequest to Workers.
1153
1154         * bindings/js/JSWorkerContextBase.h:
1155
1156         * bindings/js/JSXMLHttpRequestConstructor.cpp:
1157         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
1158         (WebCore::constructXMLHttpRequest):
1159         (WebCore::JSXMLHttpRequestConstructor::mark):
1160         Removed the dependencies on Document.
1161
1162         * bindings/js/JSXMLHttpRequestConstructor.h:
1163         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
1164         * dom/EventException.idl:
1165         * dom/EventListener.idl:
1166         Change to have the NoStaticTables attribute since they are used from XHR.
1167
1168         * loader/WorkerThreadableLoader.cpp:
1169         (WebCore::workerContextDidFinishLoading):
1170         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
1171         Fixed identifier to be unsigned long.
1172
1173         * loader/WorkerThreadableLoader.h:
1174         * workers/WorkerThread.cpp:
1175         (WebCore::WorkerThread::workerThread):
1176         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
1177
1178         * xml/XMLHttpRequestUpload.cpp:
1179
1180         * xml/XMLHttpRequest.idl:
1181         * xml/XMLHttpRequestException.idl:
1182         * xml/XMLHttpRequestProgressEvent.idl:
1183         * xml/XMLHttpRequestUpload.idl:
1184         Change to have the NoStaticTables attribute since they are used from XHR.
1185
1186 2009-03-01  Horia Olaru  <olaru@adobe.com>
1187
1188         Adding manual debugger test cases for bug.
1189
1190         https://bugs.webkit.org/show_bug.cgi?id=21073
1191
1192         Reviewed by Kevin McCullough.
1193
1194         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
1195         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
1196         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
1197         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
1198         * manual-tests/inspector/resources/loop-statements.js: Added.
1199
1200 2009-03-01  Dan Bernstein  <mitz@apple.com>
1201
1202         Reviewed by Darin Adler.
1203
1204         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
1205
1206         Test: fast/events/scroll-during-zoom-change.html
1207
1208         * dom/Document.cpp:
1209         (WebCore::Document::recalcStyle): Pause scheduled events during style
1210         reclaculation. Changes to the zoom property result in scroll events
1211         being generated during style recalc, and those events need to be
1212         deferred until the render tree is consistent.
1213         * page/FrameView.cpp:
1214         (WebCore::FrameView::layout): Changed to account for a case in which the
1215         post-layout tasks trigger a nested layout, which reactivates the
1216         post-layout task timer.
1217
1218 2009-03-01  Ross Boucher  <rboucher@gmail.com>
1219
1220         Alphabetically sort scripts in the Script's panel file popup menu.
1221
1222         https://bugs.webkit.org/show_bug.cgi?id=23395
1223
1224         Reviewed by Timothy Hatcher.
1225
1226         * inspector/front-end/ScriptsPanel.js:
1227         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1228         * inspector/front-end/utilities.js:
1229         (insertionIndexForObjectInListSortedByFunction):
1230         (indexOfObjectInListSortedByFunction):
1231
1232 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1233
1234         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1235         when creating databases, localStorage or sessionStorage. Changing document.domain
1236         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1237
1238         https://bugs.webkit.org/show_bug.cgi?id=23844
1239
1240         Reviewed by Timothy Hatcher.
1241
1242         * inspector/InspectorController.cpp:
1243         (WebCore::InspectorController::addDOMStorageScriptResource):
1244         (WebCore::InspectorController::didUseDOMStorage):
1245         * storage/Database.cpp:
1246         (WebCore::Database::openDatabase):
1247
1248 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1249
1250         Reviewed by Holger Freyther.
1251
1252         Avoid leaking errors when reporting GIO errors.
1253
1254         * platform/network/soup/ResourceHandleSoup.cpp:
1255         (WebCore::readCallback):
1256         (WebCore::openCallback):
1257         (WebCore::queryInfoCallback):
1258
1259 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1260
1261         Reviewed by Holger Freyther.
1262
1263         Fixes crash when the GIO backend is given the URI for a directory.
1264
1265         * platform/network/soup/ResourceHandleSoup.cpp:
1266         (WebCore::networkErrorForFile):
1267
1268 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1269
1270         Reviewed by Darin Fisher.
1271
1272         https://bugs.webkit.org/show_bug.cgi?id=24261
1273         Fix V8 custom binding scrubbing error.
1274
1275         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1276         Test: traversal/exception-forwarding.html
1277         TesT: traversal/stay-within-root.html
1278
1279         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1280         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1281         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1282         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1283         (WebCore::toV8): Ditto.
1284
1285 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1286
1287         Reviewed by Darin Fisher.
1288
1289         https://bugs.webkit.org/show_bug.cgi?id=24261
1290         Fix V8 custom binding scrubbing error.
1291
1292         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1293
1294         * WebCore.xcodeproj/project.pbxproj:
1295         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1296         (WebCore::cssPropertyName):  Remove dubious checks, left over from
1297             incomplete conversion of parameter from pointer to pass-by-ref.
1298         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
1299         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
1300
1301 2009-02-28  Xan Lopez  <xan@gnome.org>
1302
1303         Reviewed by Holger Freyther.
1304
1305         https://bugs.webkit.org/show_bug.cgi?id=24263
1306         [GTK] ref ResourceHandle until we are finished with it
1307
1308         Add a ref to the ResourceHandle in startHttp so we can keep it
1309         alive untill all callbacks have been executed, and unref it when
1310         soup tells us it's done with the SoupMessage (in
1311         finishedCallback). Fixes a number of crashes when calling
1312         didReceiveData whould crash because of the handle dying.
1313
1314         * platform/network/soup/ResourceHandleSoup.cpp:
1315         (WebCore::finishedCallback):
1316         (WebCore::ResourceHandle::startHttp):
1317
1318 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
1319
1320         Reviewed by Alexey Proskuryakov.
1321
1322         https://bugs.webkit.org/show_bug.cgi?id=24226
1323         [SOUP] HTTP status text is never set
1324
1325         Set HTTP status text to SoupMessage reason_phrase.
1326
1327         * platform/network/soup/ResourceHandleSoup.cpp:
1328         (WebCore::fillResponseFromMessage):
1329
1330 2009-02-28  Dan Bernstein  <mitz@apple.com>
1331
1332         - fix malformed project file
1333
1334         * WebCore.xcodeproj/project.pbxproj:
1335
1336 2009-02-28  Dan Bernstein  <mitz@apple.com>
1337
1338         Reviewed by Oliver Hunt.
1339
1340         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
1341           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
1342
1343         Test: fast/layers/inline-dirty-z-order-lists.html
1344
1345         * rendering/RenderBox.cpp:
1346         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
1347         layer's and its stacking context's z-order lists when the layer's
1348         z-index or visibility change from here...
1349         * rendering/RenderBoxModelObject.cpp:
1350         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
1351         it will apply to RenderInline too.
1352
1353 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
1354
1355         Reviewed by David Hyatt.
1356
1357         Don't include TextResourceDecoder.h in Document.h
1358
1359         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
1360         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
1361
1362         * dom/Document.cpp:
1363         (WebCore::Document::displayStringModifiedByEncoding):
1364         (WebCore::Document::displayBufferModifiedByEncoding):
1365         * dom/Document.h:
1366         * WebCore.base.exp:
1367
1368 2009-02-27  Matt Pennig  <pennig@apple.com>
1369
1370         Reviewed by David Hyatt.
1371
1372         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
1373         "Fixed elements have 0 as an offsetLeft property"
1374         
1375         Code also brings offsetLeft/Top in full conformance with the spec.
1376         Added two tests, one for fixed-position elements, and one for <html>.
1377         
1378         Tests: fast/dom/Element/fixed-position-offset-parent.html
1379                fast/dom/Element/offsetLeft-offsetTop-html.html
1380
1381         * rendering/RenderBoxModelObject.cpp:
1382         (WebCore::RenderBoxModelObject::offsetLeft):
1383         (WebCore::RenderBoxModelObject::offsetTop):
1384
1385 2009-02-27  Dean Jackson  <dino@apple.com>
1386
1387         Reviewed by Simon Fraser.
1388
1389         renderer()->hasTransform() returns true for elements
1390         with perspective, but no transform, so test for transform
1391         when hit testing. This fixes ASSERT from
1392         https://bugs.webkit.org/show_bug.cgi?id=24252
1393
1394         Test: transforms/no_transform_hit_testing.html
1395
1396         * rendering/RenderLayer.cpp:
1397         (WebCore::RenderLayer::hitTestLayer):
1398
1399 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1400
1401         Reviewed by Darin Fisher.
1402
1403         Fix scrubbing error -- a reversed condition.
1404
1405         * bindings/v8/ScriptValue.h:
1406         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
1407
1408 2009-02-27  Jian Li  <jianli@chromium.org>
1409
1410         Reviewed by Alexey Proskuryakov.
1411
1412         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
1413         https://bugs.webkit.org/show_bug.cgi?id=24152
1414
1415         * workers/WorkerMessagingProxy.cpp:
1416         (WebCore::MessageWorkerContextTask::performTask):
1417         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
1418         * workers/WorkerMessagingProxy.h:
1419         * workers/WorkerObjectProxy.h:
1420
1421 2009-02-27  Anders Carlsson  <andersca@apple.com>
1422
1423         Reviewed by David Hyatt.
1424
1425         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
1426         because it leads to assertion failures in the Mac port.
1427         
1428         * platform/graphics/BitmapImage.cpp:
1429         (WebCore::BitmapImage::BitmapImage):
1430         * platform/graphics/BitmapImage.h:
1431         (WebCore::BitmapImage::mayFillWithSolidColor):
1432         * platform/graphics/Image.h:
1433         (WebCore::Image::mayFillWithSolidColor):
1434         * platform/graphics/cairo/ImageCairo.cpp:
1435         (WebCore::BitmapImage::BitmapImage):
1436         * platform/graphics/cg/ImageCG.cpp:
1437         (WebCore::BitmapImage::BitmapImage):
1438         (WebCore::BitmapImage::checkForSolidColor):
1439         * platform/graphics/qt/ImageQt.cpp:
1440         (WebCore::BitmapImage::checkForSolidColor):
1441         * platform/graphics/skia/ImageSkia.cpp:
1442         (WebCore::BitmapImage::checkForSolidColor):
1443         * platform/graphics/wx/ImageWx.cpp:
1444         (WebCore::BitmapImage::checkForSolidColor):
1445
1446 2009-02-27  Adam Barth  <abarth@webkit.org>
1447
1448         Reviewed by Eric Seidel.
1449
1450         https://bugs.webkit.org/show_bug.cgi?id=20249
1451
1452         Add a preference to allow universal access from local URLs to mitigate
1453         some attacks.  Some clients still want to allow this access, so we
1454         expose this as a preference.
1455
1456         * WebCore.base.exp:
1457         * dom/Document.cpp:
1458         (WebCore::Document::initSecurityContext):
1459         * page/SecurityOrigin.cpp:
1460         (WebCore::SecurityOrigin::SecurityOrigin):
1461         * page/Settings.cpp:
1462         (WebCore::Settings::Settings):
1463         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
1464         * page/Settings.h:
1465         (WebCore::Settings::allowUniversalAccessFromFileUrls):
1466
1467 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1468
1469         Reviewed by Eric Seidel.
1470
1471         https://bugs.webkit.org/show_bug.cgi?id=24229
1472         If an image has no alpha channel there is no reason to use SourceOver.
1473
1474         * platform/graphics/qt/ImageQt.cpp:
1475         (WebCore::Image::drawPattern):
1476         (WebCore::BitmapImage::draw):
1477
1478 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1479
1480         Reviewed by Eric Seidel and Simon Fraser.
1481
1482         https://bugs.webkit.org/show_bug.cgi?id=24227
1483         Ensure that the checkForSolidColor() optimization is correctly triggered
1484         for all cases of drawPattern.  Currently, the optimization was not triggered
1485         when the check had not been previously performed via a request for the
1486         image's NativeImagePtr.
1487
1488         Implement the Qt version of the checkForSolidColor() method.  Combined with
1489         the bug fix this reduces the time it takes to draw a repeating background
1490         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1491
1492         * platform/graphics/BitmapImage.cpp:
1493         (WebCore::BitmapImage::BitmapImage):
1494         * platform/graphics/BitmapImage.h:
1495         (WebCore::BitmapImage::mayFillWithSolidColor):
1496         * platform/graphics/Image.h:
1497         (WebCore::Image::mayFillWithSolidColor):
1498         * platform/graphics/cairo/ImageCairo.cpp:
1499         (WebCore::BitmapImage::BitmapImage):
1500         * platform/graphics/cg/ImageCG.cpp:
1501         (WebCore::BitmapImage::BitmapImage):
1502         (WebCore::BitmapImage::checkForSolidColor):
1503         * platform/graphics/qt/ImageQt.cpp:
1504         (WebCore::BitmapImage::checkForSolidColor):
1505         * platform/graphics/skia/ImageSkia.cpp:
1506         (WebCore::BitmapImage::checkForSolidColor):
1507         * platform/graphics/wx/ImageWx.cpp:
1508         (WebCore::BitmapImage::checkForSolidColor):
1509
1510 2009-02-27  Dirk Schulze  <krit@webkit.org>
1511
1512         Reviewed by Zack Rusin.
1513
1514         Added support for gradients and pattern on Fonts for Qt.
1515
1516         [Qt] gradients and patterns for FontQt
1517         https://bugs.webkit.org/show_bug.cgi?id=24243
1518
1519         * platform/graphics/qt/FontQt.cpp:
1520         (WebCore::Font::drawComplexText):
1521
1522 2009-02-27  Jian Li  <jianli@chromium.org>
1523
1524         Reviewed by Alexey Proskuryakov.
1525
1526         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
1527         https://bugs.webkit.org/show_bug.cgi?id=24113
1528
1529         * workers/WorkerMessagingProxy.cpp:
1530
1531 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1532
1533         Added a refresh button to storage views.
1534
1535         https://bugs.webkit.org/show_bug.cgi?id=24040
1536
1537         Reviewed by Timothy Hatcher.
1538
1539         * inspector/front-end/DOMStorageItemsView.js:
1540         (WebInspector.DOMStorageItemsView):
1541         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1542         (WebInspector.DOMStorageItemsView.prototype.update):
1543         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1544         * inspector/front-end/DatabaseTableView.js:
1545         (WebInspector.DatabaseTableView):
1546         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
1547         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
1548         * inspector/front-end/DatabasesPanel.js:
1549         (WebInspector.DatabasesPanel):
1550         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1551         (WebInspector.DatabasesPanel.prototype.reset):
1552         (WebInspector.DatabasesPanel.prototype.showDatabase):
1553         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1554         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1555         * inspector/front-end/inspector.css:
1556
1557 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1558
1559         Added support for editing/deleting localStorage and sessionStorage items
1560         directly from Web Inspector.
1561
1562         https://bugs.webkit.org/show_bug.cgi?id=23866.
1563
1564         Reviewed by Timothy Hatcher.
1565
1566         * WebCore.vcproj/WebCore.vcproj:
1567         * inspector/front-end/DOMStorageDataGrid.js: Added.
1568         (WebInspector.DOMStorageDataGrid):
1569         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
1570         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
1571         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
1572         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
1573         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
1574         * inspector/front-end/DOMStorageItemsView.js:
1575         (WebInspector.DOMStorageItemsView):
1576         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1577         (WebInspector.DOMStorageItemsView.prototype.hide):
1578         (WebInspector.DOMStorageItemsView.prototype.update):
1579         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1580         * inspector/front-end/DatabasesPanel.js:
1581         (WebInspector.DatabasesPanel):
1582         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1583         (WebInspector.DatabasesPanel.prototype.reset):
1584         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1585         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
1586         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1587         * inspector/front-end/WebKit.qrc:
1588         * inspector/front-end/inspector.css:
1589         * inspector/front-end/inspector.html:
1590
1591 2009-02-26  Brett Wilson  <brettw@chromium.org>
1592
1593         Fix Windows transparency for the Chromium port. Implement a helper
1594         class for handling transparency on Windows. It allows semitransparent
1595         ClearType and semitransparent form controls by making new layers in the
1596         background.
1597
1598         It also replaces the "ThemeHelper" which allows better
1599         scaling and transforms on Windows form controls. In addition to the
1600         functionality that the ThemeHelper did, but additionally handles the
1601         antialiasing properly so that the form controls aren't composited on a
1602         white square.
1603
1604         https://bugs.webkit.org/show_bug.cgi?id=24101
1605
1606         Reviewed by Eric Seidel.
1607
1608         * platform/graphics/chromium/FontChromiumWin.cpp:
1609         (WebCore::):
1610         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1611         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1612         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1613         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
1614         (WebCore::Font::drawGlyphs):
1615         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
1616         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
1617         * platform/graphics/chromium/TransparencyWin.cpp: Added.
1618         (WebCore::):
1619         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1620         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
1621         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
1622         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
1623         (WebCore::TransparencyWin::TransparencyWin):
1624         (WebCore::TransparencyWin::~TransparencyWin):
1625         (WebCore::TransparencyWin::init):
1626         (WebCore::TransparencyWin::computeLayerSize):
1627         (WebCore::TransparencyWin::setupLayer):
1628         (WebCore::TransparencyWin::setupLayerForNoLayer):
1629         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
1630         (WebCore::TransparencyWin::setupLayerForTextComposite):
1631         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1632         (WebCore::TransparencyWin::setupTransform):
1633         (WebCore::TransparencyWin::setupTransformForKeepTransform):
1634         (WebCore::TransparencyWin::setupTransformForUntransform):
1635         (WebCore::TransparencyWin::setupTransformForScaleTransform):
1636         (WebCore::TransparencyWin::setTextCompositeColor):
1637         (WebCore::TransparencyWin::initializeNewContext):
1638         (WebCore::TransparencyWin::compositeOpaqueComposite):
1639         (WebCore::TransparencyWin::compositeTextComposite):
1640         (WebCore::TransparencyWin::makeLayerOpaque):
1641         * platform/graphics/chromium/TransparencyWin.h: Added.
1642         (WebCore::TransparencyWin::):
1643         (WebCore::TransparencyWin::context):
1644         (WebCore::TransparencyWin::platformContext):
1645         (WebCore::TransparencyWin::drawRect):
1646         * platform/graphics/skia/GraphicsContextSkia.cpp:
1647         (WebCore::GraphicsContext::endTransparencyLayer):
1648         * platform/graphics/skia/ImageSkia.cpp:
1649         (WebCore::paintSkBitmap):
1650         * rendering/RenderThemeChromiumWin.cpp:
1651         (WebCore::):
1652         (WebCore::RenderThemeChromiumWin::paintButton):
1653         (WebCore::RenderThemeChromiumWin::paintMenuList):
1654         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1655
1656 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1657
1658         Reviewed by Eric Seidel.
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=24211
1661         Add ScheduledAction for V8.
1662
1663         * bindings/v8/ScheduledAction.cpp: Added.
1664         (WebCore::ScheduledAction::ScheduledAction):
1665         (WebCore::ScheduledAction::~ScheduledAction):
1666         (WebCore::ScheduledAction::execute):
1667         * bindings/v8/ScheduledAction.h: Added.
1668         (WebCore::ScheduledAction::ScheduledAction):
1669
1670 2009-02-27  Zack Rusin  <zack@kde.org>
1671
1672         Reviewed by Nikolas Zimmermann.
1673
1674         Qt: be more reasonable about scrolled lines
1675
1676         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
1677         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
1678         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
1679         single step scroll
1680
1681         * platform/qt/WheelEventQt.cpp:
1682
1683 2009-02-27  Xan Lopez  <xan@gnome.org>
1684
1685         Rubber-stamped by Alexey Proskuryakov.
1686
1687         https://bugs.webkit.org/show_bug.cgi?id=24222
1688         [GTK] Remove checks for old glib versions
1689
1690         libsoup, which is a hard dependency, needs at least glib 2.15.3,
1691         so remove all glib checks for versions older than that.
1692
1693         * platform/gtk/ContextMenuGtk.cpp:
1694         (WebCore::ContextMenu::ContextMenu):
1695         * platform/gtk/ContextMenuItemGtk.cpp:
1696         (WebCore::ContextMenuItem::setSubMenu):
1697         * platform/gtk/PopupMenuGtk.cpp:
1698         (WebCore::PopupMenu::show):
1699         * platform/gtk/WidgetGtk.cpp:
1700         (WebCore::Widget::retainPlatformWidget):
1701         * platform/network/soup/ResourceHandleSoup.cpp:
1702
1703 2009-02-26  Dirk Schulze  <krit@webkit.org>
1704
1705         Reviewed by Oliver Hunt.
1706
1707         Added support for Gradients and Patterns on filled or stroked Fonts
1708         in Cairo. I also added support for globalAlpha on FontCairo.
1709
1710         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
1711         https://bugs.webkit.org/show_bug.cgi?id=18617
1712
1713         * html/CanvasRenderingContext2D.cpp:
1714         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1715         * platform/graphics/cairo/FontCairo.cpp:
1716         (WebCore::Font::drawGlyphs):
1717
1718 2009-02-26  Stephen White  <senorblanco@chromium.org>
1719
1720         Reviewed by Eric Seidel.
1721
1722         https://bugs.webkit.org/show_bug.cgi?id=23957
1723
1724         Fix for SVG gradient and pattern text for Chromium/skia. 
1725         Added accessors for the fill and stroke gradients to
1726         GraphicsContext.  Changed the paintSkiaText function to take a
1727         GraphicsContext, so we can check for gradients/patterns. 
1728         Changed the skiaDrawText function to set the SkPaint shader
1729         correctly, and to scale up the gradient shader matrix to
1730         encompass the entire text string.  Also offset each glyph
1731         separately, rather than transforming the canvas, so that the
1732         gradient/pattern stays fixed relative to the text origin.
1733
1734         * platform/graphics/GraphicsContext.cpp:
1735         (WebCore::GraphicsContext::getFillGradient):
1736         (WebCore::GraphicsContext::getStrokeGradient):
1737         (WebCore::GraphicsContext::getFillPattern):
1738         (WebCore::GraphicsContext::getStrokePattern):
1739         * platform/graphics/GraphicsContext.h:
1740         * platform/graphics/chromium/FontChromiumWin.cpp:
1741         (WebCore::Font::drawGlyphs):
1742         * platform/graphics/chromium/UniscribeHelper.cpp:
1743         (WebCore::UniscribeHelper::draw):
1744         * platform/graphics/skia/SkiaFontWin.cpp:
1745         (WebCore::windowsCanHandleTextDrawing):
1746         (WebCore::skiaDrawText):
1747         (WebCore::paintSkiaText):
1748         * platform/graphics/skia/SkiaFontWin.h:
1749
1750 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1751
1752         Reviewed by Eric Seidel.
1753
1754         https://bugs.webkit.org/show_bug.cgi?id=24208
1755         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1756
1757         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1758         (WebCore::ACCESSOR_GETTER):
1759         (WebCore::CALLBACK_FUNC_DECL):
1760         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1761         (WebCore::CALLBACK_FUNC_DECL):
1762         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1763         (WebCore::ACCESSOR_GETTER):
1764         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1765         (WebCore::CALLBACK_FUNC_DECL):
1766
1767 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1768
1769         Unreviewed build fix for building with GNOME Keyring enabled.
1770
1771         * platform/network/soup/webkit-soup-auth-dialog.c:
1772         (show_auth_dialog):
1773
1774 2009-02-26  Xan Lopez  <xan@gnome.org>
1775
1776         Reviewed by Holger Freyther.
1777
1778         https://bugs.webkit.org/show_bug.cgi?id=16947
1779         [GTK] Missing HTTP Auth challenge
1780
1781         Add HTTP authentication dialog with optional GNOME Keyring
1782         storage.
1783
1784         * GNUmakefile.am:
1785         * platform/network/ResourceHandleInternal.h:
1786         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1787         * platform/network/soup/ResourceHandleSoup.cpp:
1788         (WebCore::currentToplevelCallback):
1789         (WebCore::ResourceHandle::startHttp):
1790         (WebCore::ResourceHandle::start):
1791         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1792         (webkit_soup_auth_dialog_class_init):
1793         (webkit_soup_auth_dialog_init):
1794         (webkit_soup_auth_dialog_session_feature_init):
1795         (free_authData):
1796         (set_password_callback):
1797         (response_callback):
1798         (show_auth_dialog):
1799         (find_password_callback):
1800         (session_authenticate):
1801         (attach):
1802         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1803
1804 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1805
1806         Reviewed by Dave Hyatt.
1807
1808         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1809         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1810         started failing because Ojan's new code was now *correctly* calling through to
1811         SVG asking for the closest text offset in the last line box, instead of
1812         just returning the offset at the end of the last line box when clicking below a box.
1813
1814         But!  The SVG code was wrong, in that it returned the character offset of the last
1815         character when you asked for a character offset after the end of the box, instead
1816         it should return the offset *after* the last character.  This patch fixes
1817         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1818
1819         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1820         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1821         what it is doing (which also makes more obvious what's wrong with it).
1822
1823         * rendering/RenderSVGInlineText.cpp:
1824         (WebCore::RenderSVGInlineText::positionForCoordinates):
1825         * rendering/SVGInlineTextBox.cpp:
1826         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1827         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1828         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1829         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1830         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1831
1832 2009-02-26  Darin Fisher  <darin@chromium.org>
1833
1834         Reviewed by Eric Seidel.
1835
1836         Minor cleanup of ChromiumBridge:
1837         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1838
1839         * platform/chromium/ChromiumBridge.h:
1840         * platform/chromium/MimeTypeRegistryChromium.cpp:
1841         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1842         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1843         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1844
1845 2009-02-26  David Hyatt  <hyatt@apple.com>
1846
1847         Reviewed by Sam Weinig
1848
1849         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1850         the line-height below the descent.
1851
1852         Added fast/inline/vertical-align-text-bottom.html
1853
1854         * rendering/RenderBoxModelObject.cpp:
1855         (WebCore::RenderBoxModelObject::verticalPosition):
1856
1857 2009-02-26  Dirk Schulze  <krit@webkit.org>
1858
1859         Reviewed by Eric Seidel.
1860
1861         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1862         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1863         just to implement this three methods to support SVG Masking now.
1864  
1865         Make SVG Masking platform aware
1866         https://bugs.webkit.org/show_bug.cgi?id=19243
1867
1868         * GNUmakefile.am:
1869         * WebCore.pro:
1870         * WebCore.vcproj/WebCore.vcproj:
1871         * WebCore.xcodeproj/project.pbxproj:
1872         * svg/graphics/SVGResourceMasker.cpp:
1873         (WebCore::SVGResourceMasker::applyMask):
1874         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1875         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1876         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1877         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1878         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1879
1880 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1881
1882         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1883
1884         Test: http/tests/misc/slow-preload-cancel.html
1885
1886         https://bugs.webkit.org/show_bug.cgi?id=24133
1887         Clear all pending preloads in the DocLoader object when we decide to
1888         cancel its all requests.
1889
1890         * loader/DocLoader.cpp:
1891         (WebCore::DocLoader::clearPendingPreloads):
1892         * loader/DocLoader.h:
1893         * loader/loader.cpp:
1894         (WebCore::Loader::cancelRequests):
1895
1896 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1897
1898         Reviewed by Eric Seidel.
1899
1900         https://bugs.webkit.org/show_bug.cgi?id=24182
1901         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1902
1903         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1904         (WebCore::CALLBACK_FUNC_DECL):
1905         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1906         (WebCore::toV8):
1907         (WebCore::CALLBACK_FUNC_DECL):
1908         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1909         (WebCore::toV8):
1910         (WebCore::CALLBACK_FUNC_DECL):
1911
1912 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1913
1914         Reviewed by Darin Adler.
1915
1916         https://bugs.webkit.org/show_bug.cgi?id=23500
1917         KURL::parse() incorrectly compares its result to original string
1918
1919         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
1920
1921 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1922
1923         Reviewed by Kevin McCullough.
1924
1925         Manual test for inspector node highlighting.
1926
1927         * manual-tests/inspector/highlight-nodes.html: Added.
1928
1929 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
1930
1931         Reviewed by Darin Fisher.
1932
1933         https://bugs.webkit.org/show_bug.cgi?id=23973
1934         ScrollView::scrollContents can be invoked during view shutdown.  In
1935         this scenario the FrameView::hostWindow method can return NULL, which
1936         indicates that the frame/page is being destroyed. This causes a crash
1937         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
1938         NULL check for this.  
1939
1940         * platform/ScrollView.cpp:
1941         (WebCore::ScrollView::scrollContents):
1942
1943 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
1944
1945         Reviewed by Dave Hyatt.
1946
1947         https://bugs.webkit.org/show_bug.cgi?id=24003
1948         Fix a crash caused by unsafe type conversion.
1949
1950         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
1951
1952         * rendering/RenderBox.cpp:
1953         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
1954
1955 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1956
1957         Reviewed by Adam Roben.
1958
1959         https://bugs.webkit.org/show_bug.cgi?id=24202
1960         Have drawNodeHighlight clip instead of clearing. This makes it work for
1961         both Safari and Chromium since Chromium draws the inspector highlighting
1962         in the same buffer as the page.
1963
1964         * inspector/InspectorController.cpp:
1965         (WebCore::quadToPath):
1966         (WebCore::drawOutlinedQuad):
1967         (WebCore::drawOutlinedQuadWithClip):
1968         (WebCore::drawHighlightForBox):
1969
1970 2009-02-26  David Hyatt  <hyatt@apple.com>
1971
1972         Reviewed by Dan Bernstein & Darin Adler
1973
1974         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
1975         
1976         Added fast/inline/inline-continuation-borders.html
1977
1978         * rendering/InlineFlowBox.cpp:
1979         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
1980
1981 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
1982
1983         Build fix, no review.
1984         
1985         Try to fix the wx build after r41218.
1986
1987         * WebCoreSources.bkl:
1988
1989 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1990
1991         Reviewed by Darin Adler.
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=19527
1994         ASSERTION FAILED: containerA && containerB
1995
1996         Test: fast/dom/Range/bug-19527.html
1997
1998         * dom/Range.cpp:
1999         (WebCore::Range::isPointInRange):
2000         (WebCore::Range::comparePoint):
2001         Bring the behavior in line with current Firefox, making it impossible for these methods
2002         to pass a null container to compareBoundaryPoints().
2003
2004 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
2005
2006         Reviewed by Holger Freyther.
2007
2008         https://bugs.webkit.org/show_bug.cgi?id=20358
2009
2010         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2011         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
2012         should set the computed size rather than the specified size, otherwise
2013         the caps just get rendered normal size.
2014
2015 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
2016
2017         Reviewed by George Staikos.
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=24062
2020         QNetworkCookieJar expects the url and not the policy url.  Sending the
2021         policy url will cause QNetworkCookieJar to behave incorrectly.  One
2022         example would be a cookie that does not have a path or domain.
2023         QNetworkCookieJar will use the url it is given to fill in default values.
2024         This allows setting cookies on the url of the main frame from an iFrame
2025         when the cookie should be set on the url of the iFrame.
2026
2027         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
2028
2029         * platform/qt/CookieJarQt.cpp:
2030         (WebCore::setCookies):
2031
2032 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
2033
2034         Reviewed by George Staikos.
2035
2036         make WebKit/Qt compile with SVG disabled
2037
2038         * WebCore.pro:
2039         * platform/graphics/qt/FontPlatformDataQt.cpp:
2040
2041 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
2042
2043         Unreviewed build fix. Add WebCore/workers to the list of paths
2044         searched by the bindings generator perl script.
2045
2046         * GNUmakefile.am:
2047
2048 2009-02-25  Sam Weinig  <sam@webkit.org>
2049
2050         Reviewed by Geoffrey Garen.
2051
2052         Add canvas to the list of RenderObjects that can mark a page as
2053         visually not empty.
2054
2055         * rendering/RenderHTMLCanvas.cpp:
2056         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2057
2058 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
2059
2060         Reviewed by Dave Hyatt.
2061
2062         * rendering/RenderBox.cpp:
2063         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
2064         as RenderMedia with controls always has a layer.
2065
2066 2009-02-25  Dan Bernstein  <mitz@apple.com>
2067
2068         Reviewed by Simon Fraser.
2069
2070         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
2071           <rdar://problem/6618196> Paint very slow when horizontally resizing
2072
2073         Test: fast/gradients/background-clipped.html
2074
2075         * rendering/RenderBoxModelObject.cpp:
2076         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
2077         destination rectangle passed to drawTiledImage() with the dirty
2078         rectangle. This makes it more likely for the destination rect to be
2079         contained in a single tile rect, which results in a faster code path
2080         being taken down the road (just drawing a single tile instead of
2081         tiling).
2082
2083 2009-02-25  Ojan Vafai  <ojan@chromium.org>
2084
2085         Reviewed by Eric Seidel.
2086
2087         Fix test regressions from positionForCoordinates patch.
2088         https://bugs.webkit.org/show_bug.cgi?id=24148
2089
2090         * rendering/RenderBlock.cpp:
2091         (WebCore::positionForPointWithInlineChildren):
2092         Remove ASSERT that placeholder text codepath is hitting.
2093
2094 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
2095
2096         Reviewed by Beth Dakin.
2097
2098         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
2099         https://bugs.webkit.org/show_bug.cgi?id=24143
2100
2101         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
2102         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
2103         Make sure the AXObjectWrapper's have an object before calling them
2104         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
2105
2106         Test: platform/mac-snowleopard/accessibility/table-updating.html
2107
2108         * WebCore.base.exp:
2109         * page/AXObjectCache.cpp:
2110         (WebCore::AXObjectCache::~AXObjectCache):
2111         (WebCore::AXObjectCache::get):
2112         (WebCore::AXObjectCache::getOrCreate):
2113         (WebCore::AXObjectCache::removeAXID):
2114         (WebCore::AXObjectCache::handleActiveDescendantChanged):
2115         (WebCore::AXObjectCache::handleAriaRoleChanged):
2116         * page/AXObjectCache.h:
2117         * page/AccessibilityImageMapLink.cpp:
2118         (WebCore::AccessibilityImageMapLink::parentObject):
2119         * page/AccessibilityListBox.cpp:
2120         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
2121         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
2122         * page/AccessibilityListBoxOption.cpp:
2123         (WebCore::AccessibilityListBoxOption::elementRect):
2124         (WebCore::AccessibilityListBoxOption::parentObject):
2125         * page/AccessibilityObject.cpp:
2126         (WebCore::AccessibilityObject::detach):
2127         (WebCore::AccessibilityObject::parentObjectIfExists):
2128         (WebCore::replacedNodeNeedsCharacter):
2129         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
2130         * page/AccessibilityObject.h:
2131         * page/AccessibilityRenderObject.cpp:
2132         (WebCore::AccessibilityRenderObject::firstChild):
2133         (WebCore::AccessibilityRenderObject::lastChild):
2134         (WebCore::AccessibilityRenderObject::previousSibling):
2135         (WebCore::AccessibilityRenderObject::nextSibling):
2136         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
2137         (WebCore::AccessibilityRenderObject::parentObject):
2138         (WebCore::AccessibilityRenderObject::isAttachment):
2139         (WebCore::AccessibilityRenderObject::headingLevel):
2140         (WebCore::AccessibilityRenderObject::anchorElement):
2141         (WebCore::AccessibilityRenderObject::menuForMenuButton):
2142         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
2143         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
2144         (WebCore::AccessibilityRenderObject::internalLinkElement):
2145         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
2146         (WebCore::AccessibilityRenderObject::titleUIElement):
2147         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2148         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
2149         (WebCore::AccessibilityRenderObject::getDocumentLinks):
2150         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2151         (WebCore::AccessibilityRenderObject::focusedUIElement):
2152         (WebCore::AccessibilityRenderObject::activeDescendant):
2153         (WebCore::AccessibilityRenderObject::observableObject):
2154         (WebCore::AccessibilityRenderObject::childrenChanged):
2155         (WebCore::AccessibilityRenderObject::addChildren):
2156         * page/AccessibilityRenderObject.h:
2157         (WebCore::AccessibilityRenderObject::setRenderObject):
2158         * page/AccessibilityTable.cpp:
2159         (WebCore::AccessibilityTable::addChildren):
2160         (WebCore::AccessibilityTable::headerContainer):
2161         (WebCore::AccessibilityTable::cellForColumnAndRow):
2162         * page/AccessibilityTableCell.cpp:
2163         (WebCore::AccessibilityTableCell::isTableCell):
2164         (WebCore::AccessibilityTableCell::titleUIElement):
2165         * page/AccessibilityTableColumn.cpp:
2166         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2167         * page/AccessibilityTableRow.cpp:
2168         (WebCore::AccessibilityTableRow::isTableRow):
2169         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
2170         * page/mac/AXObjectCacheMac.mm:
2171         (WebCore::AXObjectCache::postNotification):
2172         (WebCore::AXObjectCache::postNotificationToElement):
2173         * page/mac/AccessibilityObjectWrapper.mm:
2174         (textMarkerForVisiblePosition):
2175         (AXLinkElementForNode):
2176         (nsStringForReplacedNode):
2177         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
2178         (-[AccessibilityObjectWrapper accessibilityActionNames]):
2179         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2180         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
2181         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
2182         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2183         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
2184         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2185         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
2186         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
2187         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2188         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
2189         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
2190         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
2191         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2192
2193 2009-02-25  Beth Dakin  <bdakin@apple.com>
2194
2195         Reviewed by Geoff Garen.
2196
2197         Re-working of <rdar://problem/6487249> repro crash in 
2198         WebCore::CSSParser::parseFillImage copying entire contents of this 
2199         page
2200         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2201
2202         Fixes a bunch of layout test failures I caused!
2203
2204         * css/CSSParser.cpp:
2205         (WebCore::CSSParser::parseValue):
2206         (WebCore::CSSParser::parseContent):
2207         (WebCore::CSSParser::parseFillImage):
2208         (WebCore::CSSParser::parseFontFaceSrc):
2209         (WebCore::CSSParser::parseBorderImage):
2210
2211 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
2212
2213         Reviewed by Eric Seidel.
2214
2215         https://bugs.webkit.org/show_bug.cgi?id=24174
2216         Add more V8 custom bindings.
2217
2218         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
2219         (WebCore::hasCSSPropertyNamePrefix):
2220         (WebCore::cssPropertyName):
2221         (WebCore::NAMED_PROPERTY_GETTER):
2222         (WebCore::NAMED_PROPERTY_SETTER):
2223         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2224         (WebCore::INDEXED_PROPERTY_GETTER):
2225         (WebCore::CALLBACK_FUNC_DECL):
2226         * bindings/v8/custom/V8EventCustom.cpp: Added.
2227         (WebCore::ACCESSOR_SETTER):
2228         (WebCore::ACCESSOR_GETTER):
2229         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2230         (WebCore::NAMED_PROPERTY_DELETER):
2231         (WebCore::NAMED_PROPERTY_SETTER):
2232         (WebCore::NAMED_PROPERTY_GETTER):
2233         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2234         (WebCore::NAMED_PROPERTY_GETTER):
2235         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2236         (WebCore::INDEXED_PROPERTY_GETTER):
2237         (WebCore::NAMED_PROPERTY_GETTER):
2238         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2239         (WebCore::NAMED_PROPERTY_GETTER):
2240         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2241         (WebCore::NAMED_PROPERTY_GETTER):
2242
2243 2009-02-25  Scott Violet  <sky@google.com>
2244
2245         Reviewed by Dave Hyatt.
2246
2247         https://bugs.webkit.org/show_bug.cgi?id=24171
2248         Provides a RenderTheme method for getting the scroll bar size and
2249         changes RenderListBox to use it. RenderTheme returns a size of regular,
2250         and Mac's override to return small. Changes ScrollbarThemeChromium to
2251         use the scrollbarsize of the scrollbar when getting the size
2252         instead of passing in no-args.
2253
2254         * platform/chromium/ScrollbarThemeChromium.cpp:
2255         (WebCore::ScrollbarThemeChromium::trackRect):
2256         (WebCore::ScrollbarThemeChromium::buttonSize):
2257         * rendering/RenderListBox.cpp:
2258         (WebCore::RenderListBox::createScrollbar):
2259         * rendering/RenderTheme.h:
2260         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2261         * rendering/RenderThemeChromiumMac.h:
2262         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2263         * rendering/RenderThemeMac.h:
2264         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2265
2266 2009-02-25  Beth Dakin  <bdakin@apple.com>
2267
2268         Reviewed by Darin Adler.
2269
2270         Fix for <rdar://problem/6487249> repro crash in 
2271         WebCore::CSSParser::parseFillImage copying entire contents of this 
2272         page
2273         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2274
2275         * css/CSSParser.cpp:
2276         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2277
2278 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2279
2280         Fix the Qt build.
2281
2282         * WebCore.pro:
2283
2284 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2285
2286         Gtk build fix. Not reviewed.
2287
2288         Add files to the build per r41218.
2289         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2290
2291         * GNUmakefile.am:
2292         * page/DOMWindow.cpp:
2293
2294 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
2295
2296         Reviewed by Alexey Proskuryakov.
2297
2298         https://bugs.webkit.org/show_bug.cgi?id=24043
2299         When faced with URLs with unsupported protocol on Gtk port,
2300         report the error through an idle function and return true, so
2301         a proper resource handle is created.
2302
2303         * platform/network/soup/ResourceHandleSoup.cpp:
2304         (WebCore::reportUnknownProtocolError):
2305         (WebCore::ResourceHandle::start):
2306
2307 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2308
2309         Windows build fix.
2310         Use struct to forward declare ResourceRequest.
2311
2312         * history/HistoryItem.h:
2313         * inspector/InspectorController.h:
2314         * loader/DocumentThreadableLoader.h:
2315         * loader/FrameLoaderClient.h:
2316         * loader/MainResourceLoader.h:
2317         * loader/SubresourceLoader.h:
2318         * loader/SubresourceLoaderClient.h:
2319         * loader/ThreadableLoader.h:
2320         * loader/WorkerThreadableLoader.h:
2321         * platform/CrossThreadCopier.h:
2322         * platform/network/ResourceHandle.h:
2323         * platform/network/ResourceHandleClient.h:
2324         * platform/network/ResourceRequestBase.h:
2325         * platform/network/cf/ResourceRequestCFNet.h:
2326         * xml/XMLHttpRequest.h:
2327
2328 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2329
2330         Partial Windows build fix.
2331         
2332         * DerivedSources.cpp:
2333         * WebCore.vcproj/WebCore.vcproj:
2334
2335 2009-02-25  Dirk Schulze  <krit@webkit.org>
2336
2337         Reviewed by Oliver Hunt.
2338
2339         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
2340         calculate the behavior of arcTo and draws it with lineTo and arc.
2341
2342         [QT] implement Canvas arcTo
2343         https://bugs.webkit.org/show_bug.cgi?id=23873
2344
2345         * platform/graphics/qt/PathQt.cpp:
2346         (WebCore::Path::addArcTo):
2347
2348 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
2349
2350         Reviewed by Dan Bernstein
2351
2352         Remove idl files from Resources, and sort.
2353         
2354         * WebCore.xcodeproj/project.pbxproj:
2355
2356 2009-02-25  Chris Marrin  <cmarrin@apple.com>
2357
2358         Reviewed by Simon Fraser.
2359
2360         https://bugs.webkit.org/show_bug.cgi?id=23943
2361
2362         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
2363         the window object. Also added WebKitPoint object, which is passed in and out
2364         of these functions.
2365
2366         Test: fast/dom/Window/webkitConvertPoint.html
2367
2368         * DerivedSources.make:
2369         * WebCore.pro:
2370         * WebCore.vcproj/WebCore.vcproj:
2371         * WebCore.xcodeproj/project.pbxproj:
2372         * WebCoreSources.bkl:
2373         * bindings/js/JSDOMWindowBase.cpp:
2374         (jsDOMWindowBaseWebKitPoint):
2375         (setJSDOMWindowBaseWebKitPoint):
2376         * bindings/js/JSWebKitPointConstructor.cpp: Added.
2377         (WebCore::):
2378         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2379         (WebCore::constructWebKitPoint):
2380         (WebCore::JSWebKitPointConstructor::getConstructData):
2381         * bindings/js/JSWebKitPointConstructor.h: Added.
2382         (WebCore::JSWebKitPointConstructor::classInfo):
2383         * dom/Node.cpp:
2384         (WebCore::Node::convertToPage):
2385         (WebCore::Node::convertFromPage):
2386         * dom/Node.h:
2387         * page/DOMWindow.cpp:
2388         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
2389         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
2390         * page/DOMWindow.h:
2391         * page/DOMWindow.idl:
2392         * page/WebKitPoint.h: Added.
2393         (WebCore::WebKitPoint::create):
2394         (WebCore::WebKitPoint::x):
2395         (WebCore::WebKitPoint::y):
2396         (WebCore::WebKitPoint::setX):
2397         (WebCore::WebKitPoint::setY):
2398         (WebCore::WebKitPoint::WebKitPoint):
2399         * page/WebKitPoint.idl: Added.
2400
2401 2009-02-25  Jian Li  <jianli@chromium.org>
2402
2403         Reviewed by Alexey Proskuryakov.
2404
2405         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
2406         https://bugs.webkit.org/show_bug.cgi?id=24145
2407
2408         * platform/CrossThreadCopier.cpp:
2409         * platform/CrossThreadCopier.h:
2410
2411 2009-02-25  David Levin  <levin@chromium.org>
2412
2413         Reviewed by Alexey Proskuryakov.
2414
2415         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
2416         <https://bugs.webkit.org/show_bug.cgi?id=23688>
2417
2418         No observable change in behavior, so no test.
2419
2420         * loader/ThreadableLoader.cpp:
2421         (WebCore::ThreadableLoader::loadResourceSynchronously):
2422         * loader/ThreadableLoaderClientWrapper.h:
2423         (WebCore::ThreadableLoaderClientWrapper::clearClient):
2424         (WebCore::ThreadableLoaderClientWrapper::done):
2425         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
2426         (WebCore::ThreadableLoaderClientWrapper::didFail):
2427         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2428         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
2429         Expose whether the loader is done (based on what callbacks were done).
2430
2431         * loader/WorkerThreadableLoader.cpp:
2432         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2433         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2434         Each loader is given its own mode so that only its callbacks get through the run loop.
2435
2436         The xhr spec says that the readystatechange events are synchronous, so in the case of a
2437         nested sync xhr no readystatechange events should be fired for the outer xhr.
2438
2439         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2440
2441         * loader/WorkerThreadableLoader.h:
2442         (WebCore::WorkerThreadableLoader::create):
2443         (WebCore::WorkerThreadableLoader::done):
2444
2445         * workers/WorkerRunLoop.cpp:
2446         (WebCore::WorkerRunLoop::WorkerRunLoop):
2447         * workers/WorkerRunLoop.h:
2448         (WebCore::WorkerRunLoop::createUniqueId):
2449         Simple method to create a uniqueId on demand with respect to the run loop.
2450
2451         * workers/WorkerThread.h:
2452
2453 2009-02-25  David Levin  <levin@chromium.org>
2454
2455         Reviewed by Alexey Proskuryakov.
2456
2457         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
2458         <https://bugs.webkit.org/show_bug.cgi?id=24089>
2459
2460         Make threadable loader callbacks to happen during the sync load call.
2461
2462         Changes the behavior of sync xhr for insecure redirects in two ways:
2463         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
2464         + Throws a network exception which is what other browsers do and what the spec
2465         says to do (http://www.w3.org/TR/XMLHttpRequest/).
2466
2467         * loader/DocumentThreadableLoader.cpp:
2468         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2469         * loader/DocumentThreadableLoader.h:
2470         * loader/ThreadableLoader.cpp:
2471         (WebCore::ThreadableLoader::loadResourceSynchronously):
2472         * loader/ThreadableLoader.h:
2473         * xml/XMLHttpRequest.cpp:
2474         (WebCore::XMLHttpRequest::XMLHttpRequest):
2475         (WebCore::XMLHttpRequest::loadRequestSynchronously):
2476         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
2477         (WebCore::XMLHttpRequest::didFail):
2478         (WebCore::XMLHttpRequest::didFailRedirectCheck):
2479         * xml/XMLHttpRequest.h:
2480
2481 2009-02-24  Chris Marrin  <cmarrin@apple.com>
2482
2483         Reviewed by David Hyatt.
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=23368
2486
2487         Added logic to correctly hit test accelerated layers.
2488
2489         Tests: animations/animation-hit-test-transform.html
2490                animations/animation-hit-test.html
2491                transitions/transition-hit-test-transform.html
2492                transitions/transition-hit-test.html
2493
2494         * page/animation/KeyframeAnimation.cpp:
2495         (WebCore::KeyframeAnimation::animate):
2496         * rendering/RenderLayer.cpp:
2497         (WebCore::RenderLayer::hitTestLayer):
2498         (WebCore::RenderLayer::updateClipRects):
2499         * rendering/RenderLayerBacking.cpp:
2500         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2501
2502 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
2503
2504         Reviewed by Darin Adler.
2505
2506         https://bugs.webkit.org/show_bug.cgi?id=24067
2507         REGRESSION: Crash in WebCore::Document::initSecurityContext
2508
2509         The crash started to happen when we removed a check for frame->document() being null.
2510         However, the original document shouldn't be null here, because it is needed to alias
2511         security origins. So, this patch fixes the crash by correcting security origin behavior.
2512
2513         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
2514         This tests for not crashing, and for inheriting the domain from the document being replaced.
2515         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
2516         domain to remove a prefix from.
2517
2518         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
2519         clearing the frame, so that Document::initSecurityContext() could access the old one.
2520
2521 2009-02-25  Jay Campan  <jcampan@google.com>
2522
2523         Reviewed by Darin Fisher.
2524
2525         https://bugs.webkit.org/show_bug.cgi?id=24066
2526
2527         Items in drop-downs were not painted correctly.  Makes sure the
2528         PopupListBox invalidates in the coordinates of the window as this is
2529         FramelessScrollView::invalidateRect paints to.
2530
2531         * platform/chromium/PopupMenuChromium.cpp:
2532         (WebCore::PopupListBox::invalidateRow):
2533
2534 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2535
2536         Reviewed by Anders Carlsson
2537
2538         https://bugs.webkit.org/show_bug.cgi?id=15081
2539         
2540         Make display:none work for applet, emebed and object elements
2541         by calling rendererIsNeeded() on superclasses.
2542
2543         Tests: fast/replaced/applet-display-none.html
2544                fast/replaced/embed-display-none.html
2545                fast/replaced/object-display-none.html
2546
2547         * html/HTMLAppletElement.cpp:
2548         (WebCore::HTMLAppletElement::rendererIsNeeded):
2549         * html/HTMLElement.cpp:
2550         (WebCore::HTMLElement::rendererIsNeeded):
2551         * html/HTMLEmbedElement.cpp:
2552         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2553         * html/HTMLObjectElement.cpp:
2554         (WebCore::HTMLObjectElement::rendererIsNeeded):
2555
2556 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2557
2558         Reviewed by Dave Hyatt
2559
2560         https://bugs.webkit.org/show_bug.cgi?id=24137
2561         
2562         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
2563         taking perspective and transform-style: preserve-3d into account.
2564         
2565         In order to support transform-style: preserve-3d, which keeps elements in a
2566         3d space, we have to carry along an accumulated matrix in TransformState.
2567         We also need to apply the perspective from the parent, if any, with the
2568         appropriate origin.
2569
2570         * GNUmakefile.am:
2571         * WebCore.base.exp:
2572         * WebCore.pro:
2573         * WebCore.scons:
2574         * WebCore.vcproj/WebCore.vcproj:
2575         * WebCore.xcodeproj/project.pbxproj:
2576         * WebCoreSources.bkl:
2577         * css/CSSComputedStyleDeclaration.cpp:
2578         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2579         * platform/graphics/transforms/TransformationMatrix.cpp:
2580         (WebCore::TransformationMatrix::translate):
2581         (WebCore::TransformationMatrix::translate3d):
2582         (WebCore::TransformationMatrix::translateRight3d):
2583         * platform/graphics/transforms/TransformationMatrix.h:
2584         * rendering/RenderBox.cpp:
2585         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2586         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2587         * rendering/RenderBox.h:
2588         * rendering/RenderLayer.cpp:
2589         (WebCore::RenderLayer::updateTransform):
2590         (WebCore::RenderLayer::perspectiveTransform):
2591         (WebCore::RenderLayer::perspectiveOrigin):
2592         * rendering/RenderLayer.h:
2593         * rendering/RenderLayerBacking.cpp:
2594         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2595         * rendering/RenderLayerCompositor.cpp:
2596         (WebCore::requiresCompositingLayerForTransform):
2597         (WebCore::RenderLayerCompositor::layerHas3DContent):
2598         * rendering/RenderObject.cpp:
2599         (WebCore::RenderObject::localToAbsolute):
2600         (WebCore::RenderObject::absoluteToLocal):
2601         (WebCore::RenderObject::mapLocalToAbsolutePoint):
2602         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2603         * rendering/RenderObject.h:
2604         * rendering/RenderTableCell.cpp:
2605         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
2606         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
2607         * rendering/RenderTableCell.h:
2608         * rendering/RenderView.cpp:
2609         (WebCore::RenderView::mapLocalToAbsolutePoint):
2610         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2611         * rendering/RenderView.h:
2612         * rendering/TransformState.cpp: Added.
2613         (WebCore::TransformState::move):
2614         (WebCore::TransformState::applyTransform):
2615         (WebCore::TransformState::flatten):
2616         * rendering/TransformState.h: Added.
2617         (WebCore::TransformState::):
2618         (WebCore::TransformState::TransformState):
2619         (WebCore::TransformState::move):
2620         * rendering/style/RenderStyle.h:
2621         (WebCore::InheritedFlags::hasPerspective):
2622
2623 2009-02-24  Sam Weinig  <sam@webkit.org>
2624
2625         Reviewed by David Hyatt.
2626
2627         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
2628         Regression (r40837): JavaScript image popup doesn't work
2629
2630         Make the getClientRects and getBoundingClientRect methods return rects
2631         relative to the viewport.
2632
2633         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
2634
2635         * dom/Element.cpp:
2636         (WebCore::Element::getClientRects):
2637         (WebCore::Element::getBoundingClientRect):
2638
2639 2009-02-24  Ojan Vafai  <ojan@chromium.org>
2640
2641         Reviewed by Eric Seidel.
2642
2643         SVG pages don't have a body or an html element! 
2644         Don't return early if there is no body.
2645
2646         * editing/VisiblePosition.cpp:
2647         (WebCore::VisiblePosition::canonicalPosition):
2648
2649 2009-02-23  David Hyatt  <hyatt@apple.com>
2650
2651         Reviewed by Eric Seidel
2652
2653         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
2654         
2655         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
2656         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
2657         reflections or masks).
2658         
2659         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
2660         The only difference is that the clip has to be pushed and popped when painting the object's children.
2661         
2662         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
2663         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
2664         use the new functions.
2665         
2666         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
2667         
2668         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
2669         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
2670         
2671         Masks are now treated like normal flow layers (just like reflections).
2672
2673         A couple of test cases have been added to fast/overflow to test the stacking order. 
2674
2675         * rendering/InlineFlowBox.cpp:
2676         (WebCore::InlineFlowBox::nodeAtPoint):
2677         (WebCore::InlineFlowBox::paint):
2678         * rendering/RenderBlock.cpp:
2679         (WebCore::RenderBlock::repaintOverhangingFloats):
2680         (WebCore::RenderBlock::paint):
2681         (WebCore::RenderBlock::paintChildren):
2682         (WebCore::RenderBlock::paintObject):
2683         (WebCore::RenderBlock::paintFloats):
2684         (WebCore::RenderBlock::insertFloatingObject):
2685         (WebCore::RenderBlock::floatRect):
2686         (WebCore::RenderBlock::lowestPosition):
2687         (WebCore::RenderBlock::rightmostPosition):
2688         (WebCore::RenderBlock::leftmostPosition):
2689         (WebCore::RenderBlock::addOverhangingFloats):
2690         (WebCore::RenderBlock::nodeAtPoint):
2691         (WebCore::RenderBlock::hitTestContents):
2692         * rendering/RenderBox.cpp:
2693         (WebCore::RenderBox::nodeAtPoint):
2694         (WebCore::RenderBox::pushContentsClip):
2695         (WebCore::RenderBox::popContentsClip):
2696         * rendering/RenderBox.h:
2697         (WebCore::RenderBox::paintObject):
2698         * rendering/RenderBoxModelObject.cpp:
2699         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
2700         * rendering/RenderBoxModelObject.h:
2701         * rendering/RenderLayer.cpp:
2702         (WebCore::RenderLayer::paintLayer):
2703         (WebCore::RenderLayer::hitTestLayer):
2704         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2705         (WebCore::RenderLayer::isSelfPaintingLayer):
2706         * rendering/RenderLayer.h:
2707         * rendering/RenderTable.cpp:
2708         (WebCore::RenderTable::paint):
2709         (WebCore::RenderTable::paintObject):
2710         (WebCore::RenderTable::nodeAtPoint):
2711         * rendering/RenderTable.h:
2712         * rendering/RenderTableCell.cpp:
2713         (WebCore::RenderTableCell::paint):
2714         * rendering/RenderTableRow.cpp:
2715         (WebCore::RenderTableRow::nodeAtPoint):
2716         (WebCore::RenderTableRow::paint):
2717         * rendering/RenderTableRow.h:
2718         * rendering/RenderTableSection.cpp:
2719         (WebCore::RenderTableSection::paint):
2720         (WebCore::RenderTableSection::paintObject):
2721         (WebCore::RenderTableSection::nodeAtPoint):
2722         * rendering/RenderTableSection.h:
2723         * rendering/RenderTreeAsText.cpp:
2724         (WebCore::write):
2725         (WebCore::writeLayers):
2726
2727 2009-02-24  David Levin  <levin@chromium.org>
2728
2729         Reviewed by NOBODY (build fix).
2730
2731         Attempted build fix for wx-mac.
2732
2733         * WebCoreSources.bkl:
2734
2735 2009-02-24  David Levin  <levin@chromium.org>
2736
2737         Reviewed by NOBODY (build fix).
2738
2739         Attempted build fixes for qt-linux and wx-mac.
2740
2741         * WebCore.pro:
2742         * webcore-base.bkl:
2743
2744 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
2745
2746         Reviewed by Sam Weinig.
2747
2748         Fix null pointer error. If the node is the Document, then ownerDocument() 
2749         returns null, document() does not.
2750
2751         * editing/VisiblePosition.cpp:
2752         (WebCore::VisiblePosition::canonicalPosition):
2753
2754 2009-02-24  Jian Li  <jianli@chromium.org>
2755
2756         Reviewed by NOBODY (attempted build fixes).
2757
2758         Fix build break for Windows and Linux.
2759
2760         * GNUmakefile.am:
2761         * WebCore.vcproj/WebCore.vcproj:
2762
2763 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2764
2765         Reviewed by Eric Seidel.
2766
2767         https://bugs.webkit.org/show_bug.cgi?id=24131
2768         Fix-up COM/RefCounted dichotomy in Chromium port.
2769
2770         * page/chromium/AccessibilityObjectWrapper.h:
2771         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2772         explicit setting of recount.
2773
2774 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2775
2776         Reviewed by Eric Seidel.
2777
2778         https://bugs.webkit.org/show_bug.cgi?id=24141
2779         Add clarity to V8 interceptor helper function.
2780
2781         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2782         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2783         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2784         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2785         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2786
2787 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2788
2789         Reviewed by Eric Seidel
2790
2791         Minor numeric cleanup: convert float literals to doubles.
2792         
2793         * platform/graphics/transforms/RotateTransformOperation.cpp:
2794         (WebCore::RotateTransformOperation::blend):
2795
2796 2009-02-24  Mark Mentovai  <mark@chromium.org>
2797
2798         Reviewed by Eric Seidel.
2799
2800         https://bugs.webkit.org/show_bug.cgi?id=24139
2801         Add missing include.
2802
2803         * bindings/v8/ScriptInstance.h:
2804
2805 2009-02-24  Jian Li  <jianli@chromium.org>
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         Move worker related files from dom directory to worker directory under WebCore.
2810         https://bugs.webkit.org/show_bug.cgi?id=24123
2811
2812         * DerivedSources.make:
2813         * GNUmakefile.am:
2814         * WebCore.pro:
2815         * WebCore.scons:
2816         * WebCore.vcproj/MigrateIDLAndScripts:
2817         * WebCore.vcproj/WebCore.vcproj:
2818         * WebCore.xcodeproj/project.pbxproj:
2819         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2820         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2821         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2822         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2823         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2824         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2825         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2826         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2827         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2828         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2829         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2830         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2831         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2832         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2833         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2834         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2835         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2836         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2837         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2838         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2839
2840 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2841
2842         Reviewed by Dave Hyatt.
2843
2844         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2845         around divs inside editable regions.
2846         https://bugs.webkit.org/show_bug.cgi?id=23605
2847
2848         Fix clicks outside editable regions from focusing the editable region.
2849         https://bugs.webkit.org/show_bug.cgi?id=23607
2850
2851         Removed editing/selection/contenteditable-click-outside.html as it's
2852         not as useful as our new tests.
2853
2854         Clean up RenderBlock::positionForCoordinates to remove dead code,
2855         duplicate code, and generally make it more readable.
2856
2857         Tests: editing/selection/click-in-margins-inside-editable-div.html
2858                editing/selection/click-in-padding-with-multiple-line-boxes.html
2859                editing/selection/click-outside-editable-div.html
2860
2861         * editing/VisiblePosition.cpp:
2862         (WebCore::VisiblePosition::canonicalPosition):
2863         * rendering/RenderBlock.cpp:
2864         (WebCore::positionForPointRespectingEditingBoundaries):
2865         (WebCore::positionForPointWithInlineChildren):
2866         (WebCore::RenderBlock::positionForCoordinates):
2867         (WebCore::RenderBlock::updateFirstLetter):
2868
2869 2009-02-24  Sam Weinig  <sam@webkit.org>
2870
2871         Reviewed by Geoffrey Garen.
2872
2873         Related to <rdar://problem/6590295>
2874         Allow disabling javascript: urls.
2875
2876         * WebCore.base.exp:
2877         * html/HTMLAnchorElement.cpp:
2878         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2879         * loader/FrameLoader.cpp:
2880         (WebCore::FrameLoader::executeIfJavaScriptURL):
2881         * page/Page.cpp:
2882         (WebCore::Page::Page):
2883         (WebCore::Page::setJavaScriptURLsAreAllowed):
2884         (WebCore::Page::javaScriptURLsAreAllowed):
2885         * page/Page.h:
2886
2887 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2888
2889         Fix build when ACCELERATED_COMPOSITING is turned on
2890         (overflowList() -> normalFlowList()).
2891     
2892         * rendering/RenderLayerBacking.cpp:
2893         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2894         (WebCore::RenderLayerBacking::paintIntoLayer):
2895         * rendering/RenderLayerCompositor.cpp:
2896         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2897         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2898         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2899         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2900         (WebCore::RenderLayerCompositor::layerHas3DContent):
2901
2902 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2903
2904         Reviewed by Darin Adler
2905         
2906         https://bugs.webkit.org/show_bug.cgi?id=24135
2907         
2908         Round the FloatPoint returned by absoluteToLocal(), rather than
2909         truncating it.
2910
2911         * dom/MouseRelatedEvent.cpp:
2912         (WebCore::MouseRelatedEvent::receivedTarget):
2913
2914 2009-02-24  Beth Dakin  <bdakin@apple.com>
2915
2916         Reviewed by Sam Weinig.
2917
2918         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
2919         Ordered list item marker misaligned when line height is not 1.2 
2920         -and corresponding <rdar://problem/6602506>
2921
2922         This is a regression from http://trac.webkit.org/changeset/40880 
2923         where createInlineBox was taken off of RenderObject and moved to 
2924         RenderBox. The problem was that the RenderBox version still needs 
2925         to be virtual because there is still an existing implementation in 
2926         RenderListMarker. 
2927
2928         * rendering/RenderBox.h:
2929         * rendering/RenderListMarker.cpp:
2930         (WebCore::RenderListMarker::createInlineBox):
2931         * rendering/RenderListMarker.h:
2932
2933 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2934
2935         Reviewed by Eric Seidel.
2936
2937         https://bugs.webkit.org/show_bug.cgi?id=24128
2938         Upstream more V8 custom bindings: constructors, XSLTProcessor.
2939
2940         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
2941         (WebCore::CALLBACK_FUNC_DECL):
2942         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
2943         (WebCore::CALLBACK_FUNC_DECL):
2944         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
2945         (WebCore::CALLBACK_FUNC_DECL):
2946         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
2947         (WebCore::CALLBACK_FUNC_DECL):
2948         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
2949         (WebCore::CALLBACK_FUNC_DECL):
2950         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
2951         (WebCore::CALLBACK_FUNC_DECL):
2952
2953 2009-02-24  David Levin  <levin@chromium.org>
2954
2955         Reviewed by Alexey Proskuryakov.
2956
2957         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
2958         <https://bugs.webkit.org/show_bug.cgi?id=24090>
2959
2960         No observable change in behavior, so no test.
2961
2962         * dom/WorkerMessagingProxy.cpp:
2963         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
2964         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
2965         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
2966
2967         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
2968
2969         * dom/WorkerMessagingProxy.h:
2970         * loader/ThreadableLoader.cpp:
2971         (WebCore::ThreadableLoader::create):
2972         * loader/WorkerThreadableLoader.cpp:
2973         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2974         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2975         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
2976         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2977         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
2978         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
2979         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
2980         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2981         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
2982         Changed these methods to post task using a mode.
2983
2984         * loader/WorkerThreadableLoader.h:
2985         (WebCore::WorkerThreadableLoader::create):
2986
2987 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
2988
2989         Reviewed by Darin Adler.
2990
2991         https://bugs.webkit.org/show_bug.cgi?id=24091
2992         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
2993
2994         Test: http/tests/appcache/access-via-redirect.php
2995
2996         * loader/appcache/ApplicationCacheGroup.cpp:
2997         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
2998         not the original one.
2999
3000 2009-02-24  Jian Li  <jianli@chromium.org>
3001
3002         Reviewed by Alexey Proskuryakov.
3003
3004         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
3005         https://bugs.webkit.org/show_bug.cgi?id=24112
3006
3007         * bindings/js/WorkerScriptController.cpp:
3008         * dom/WorkerContext.cpp:
3009
3010 2009-02-23  Antti Koivisto  <antti@apple.com>
3011
3012         Reviewed by Oliver Hunt.
3013
3014         <rdar://problem/6613796> Extended text codecs registered on webview creation
3015
3016         Comparing a text encoding with string "GBK" ended up constructing
3017         TextEncoding("GBK") which in turn initialized all extended
3018         text codecs.
3019
3020         * platform/text/TextCodecICU.cpp:
3021         (WebCore::TextCodecICU::decode):
3022
3023 2009-02-23  Sam Weinig  <sam@webkit.org>
3024
3025         Fix Qt build.
3026
3027         * bridge/qt/qt_runtime.cpp:
3028         (JSC::Bindings::valueRealType):
3029
3030 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
3031
3032         Reviewed by Darin Adler.
3033
3034         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
3035
3036         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
3037         element created with createElement could have a wrong nodeName (createElement sets the string as the
3038         localName without checking for a prefix).
3039
3040         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
3041         and will always succeed.
3042         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
3043         to ensure that).
3044
3045         Test: fast/dom/cloneNode.html
3046
3047         * dom/Element.cpp:
3048         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
3049         always return an element.
3050
3051         * html/HTMLElement.cpp:
3052         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
3053
3054 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
3055
3056         Reviewed by Eric Seidel.
3057
3058         https://bugs.webkit.org/show_bug.cgi?id=24109
3059         Upstream V8 Script abstractions, all except ScriptController.
3060
3061         * bindings/v8/ScriptCachedFrameData.h: Added.
3062         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
3063         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
3064         (WebCore::ScriptCachedFrameData::restore):
3065         (WebCore::ScriptCachedFrameData::clear):
3066         (WebCore::ScriptCachedFrameData::domWindow):
3067         * bindings/v8/ScriptCallFrame.cpp: Added.
3068         (WebCore::ScriptCallFrame::ScriptCallFrame):
3069         (WebCore::ScriptCallFrame::~ScriptCallFrame):
3070         (WebCore::ScriptCallFrame::argumentAt):
3071         * bindings/v8/ScriptCallFrame.h: Added.
3072         (WebCore::ScriptCallFrame::functionName):
3073         (WebCore::ScriptCallFrame::sourceURL):
3074         (WebCore::ScriptCallFrame::lineNumber):
3075         (WebCore::ScriptCallFrame::argumentCount):
3076         * bindings/v8/ScriptCallStack.cpp: Added.
3077         (WebCore::ScriptCallStack::ScriptCallStack):
3078         (WebCore::ScriptCallStack::~ScriptCallStack):
3079         (WebCore::ScriptCallStack::at):
3080         * bindings/v8/ScriptCallStack.h: Added.
3081         (WebCore::ScriptCallStack::size):
3082         * bindings/v8/ScriptInstance.cpp: Added.
3083         (WebCore::V8ScriptInstance::V8ScriptInstance):
3084         (WebCore::V8ScriptInstance::~V8ScriptInstance):
3085         (WebCore::V8ScriptInstance::instance):
3086         (WebCore::V8ScriptInstance::clear):
3087         (WebCore::V8ScriptInstance::set):
3088         * bindings/v8/ScriptInstance.h: Added.
3089         (WebCore::V8ScriptInstance::create):
3090         * bindings/v8/ScriptSourceCode.h: Added.
3091         (WebCore::ScriptSourceCode::ScriptSourceCode):
3092         (WebCore::ScriptSourceCode::isEmpty):
3093         (WebCore::ScriptSourceCode::source):
3094         (WebCore::ScriptSourceCode::url):
3095         (WebCore::ScriptSourceCode::startLine):
3096         * bindings/v8/ScriptState.h: Added.
3097         (WebCore::ScriptState::hadException):
3098         (WebCore::ScriptState::setException):
3099         (WebCore::ScriptState::exception):
3100         * bindings/v8/ScriptString.h: Added.
3101         (WebCore::ScriptString::ScriptString):
3102         (WebCore::ScriptString::operator String):
3103         (WebCore::ScriptString::isNull):
3104         (WebCore::ScriptString::size):
3105         (WebCore::ScriptString::operator=):
3106         (WebCore::ScriptString::operator+=):
3107         * bindings/v8/ScriptValue.cpp: Added.
3108         (WebCore::ScriptValue::getString):
3109         * bindings/v8/ScriptValue.h: Added.
3110         (WebCore::ScriptValue::ScriptValue):
3111         (WebCore::ScriptValue::operator=):
3112         (WebCore::ScriptValue::operator==):
3113         (WebCore::ScriptValue::operator!=):
3114         (WebCore::ScriptValue::isNull):
3115         (WebCore::ScriptValue::isUndefined):
3116         (WebCore::ScriptValue::clear):
3117         (WebCore::ScriptValue::~ScriptValue):
3118         (WebCore::ScriptValue::v8Value):
3119
3120 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3121
3122         Reviewed by Timothy Hatcher.
3123
3124         https://bugs.webkit.org/show_bug.cgi?id=24106
3125         The Qt port is crashing on exit because the tear down procedure involves
3126         the WebCore::InspectorController trying to access the JS execution context
3127         for a page that is being deleted.  This patch amends the inspector so
3128         that it does not try and access the execution context of the WebCore::Page
3129         in the midst of deletion.
3130
3131         * inspector/InspectorController.cpp:
3132         (WebCore::InspectorController::inspectedPageDestroyed):
3133         (WebCore::InspectorController::stopUserInitiatedProfiling):
3134
3135 2009-02-23  David Levin  <levin@chromium.org>
3136
3137         Reviewed by Alexey Proskuryakov.
3138
3139         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
3140         <https://bugs.webkit.org/show_bug.cgi?id=24088>
3141
3142         No observable change in behavior, so no test.
3143
3144         * loader/DocumentThreadableLoader.cpp:
3145         (WebCore::DocumentThreadableLoader::create):
3146         * loader/ThreadableLoaderClient.h:
3147         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
3148         * loader/ThreadableLoaderClientWrapper.h:
3149         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
3150         * loader/WorkerThreadableLoader.cpp:
3151         (WebCore::workerContextDidFailRedirectCheck):
3152         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3153         * loader/WorkerThreadableLoader.h:
3154         * xml/XMLHttpRequest.cpp:
3155         (WebCore::XMLHttpRequest::didFinishLoading):
3156         * xml/XMLHttpRequest.h:
3157
3158 2009-02-23  David Levin  <levin@chromium.org>
3159
3160         Reviewed by Alexey Proskuryakov.
3161
3162         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
3163         <https://bugs.webkit.org/show_bug.cgi?id=24047>
3164
3165         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
3166         using only MessageQueue::waitForMessageFilteredWithTimeout instead
3167         of three different MessageQueue methods.
3168
3169         No observable change in behavior, so no test.
3170
3171         * dom/WorkerRunLoop.cpp:
3172         (WebCore::ModePredicate::operator()):
3173         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
3174         (WebCore::WorkerRunLoop::runInMode):
3175         * dom/WorkerRunLoop.h:
3176
3177 2009-02-23  David Hyatt  <hyatt@apple.com>
3178
3179         In preparation for making layers for multicol objects (so that they can properly split child layers
3180         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
3181         of RenderLayer to use the term "normal flow" instead.
3182
3183         Reviewed by Cameron Zwarich
3184
3185         * rendering/RenderLayer.cpp:
3186         (WebCore::RenderLayer::RenderLayer):
3187         (WebCore::RenderLayer::~RenderLayer):
3188         (WebCore::RenderLayer::setHasVisibleContent):
3189         (WebCore::RenderLayer::enclosingCompositingLayer):
3190         (WebCore::RenderLayer::addChild):
3191         (WebCore::RenderLayer::removeChild):
3192         (WebCore::RenderLayer::paintLayer):
3193         (WebCore::RenderLayer::hitTestLayer):
3194         (WebCore::RenderLayer::dirtyNormalFlowList):
3195         (WebCore::RenderLayer::updateNormalFlowList):
3196         (WebCore::RenderLayer::collectLayers):
3197         (WebCore::RenderLayer::updateLayerListsIfNeeded):
3198         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3199         (WebCore::RenderLayer::styleChanged):
3200         * rendering/RenderLayer.h:
3201         (WebCore::RenderLayer::isNormalFlowOnly):
3202         (WebCore::RenderLayer::normalFlowList):
3203         * rendering/RenderTreeAsText.cpp:
3204         (WebCore::writeLayers):
3205
3206 2009-02-23  David Hyatt  <hyatt@apple.com>
3207
3208         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
3209         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
3210         column rules (rather than ending up above the background of the box but behind the column rules).
3211
3212         Reviewed by Eric Seidel
3213
3214         Added fast/multicol/column-rules-stacking.html
3215
3216         * rendering/RenderBlock.cpp:
3217         (WebCore::RenderBlock::paintColumnRules):
3218         (WebCore::RenderBlock::paintColumnContents):
3219         (WebCore::RenderBlock::paintObject):
3220         * rendering/RenderBlock.h:
3221
3222 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3223
3224         Reviewed by David Hyatt.
3225
3226         No testcases have been added or modified since this patch should not result in
3227         a behavior change for ports that have layout tests enabled.
3228
3229         Currently, the implementation of GraphicsContext::drawLineForText amongst
3230         the various ports differ in that some of them are honoring the context's
3231         strokeStyle when drawing a text-decoration and some of them are not.
3232         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3233         but the Cairo implementation does and has an explicit workaround that
3234         sets the strokeStyle() temporarily.
3235
3236         This patch fixes so that all ports are consistent by explicitly making sure
3237         to set the GraphicsContext strokeStyle to SolidStroke whenever
3238         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3239         should always use a solid stroke.
3240
3241         This patch addresses these bugs:
3242         https://bugs.webkit.org/show_bug.cgi?id=19364
3243         https://bugs.webkit.org/show_bug.cgi?id=15659
3244
3245         * rendering/InlineFlowBox.cpp:
3246         (WebCore::InlineFlowBox::paintTextDecorations):
3247         * rendering/InlineTextBox.cpp:
3248         (WebCore::InlineTextBox::paintDecoration):
3249
3250 2009-02-23  Scott Violet  <sky@google.com>
3251
3252         Reviewed by Eric Seidel.
3253
3254         https://bugs.webkit.org/show_bug.cgi?id=24098
3255         Bugs in ClipboardChromium
3256
3257         Fixes the following bugs in ClipboardChromium:
3258         * It's possible for the extension to be empty, resulting in a bad file
3259           name, for example, 'foo.' or just '.'.
3260         * We weren't restricting the size of the file to MAX_PATH.
3261         * We weren't removing characters that are invalid for file system names.
3262
3263         * platform/chromium/ClipboardChromium.cpp:
3264         (WebCore::writeImageToDataObject):
3265         * platform/chromium/ClipboardChromium.h:
3266         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3267         (WebCore::ClipboardChromium::validateFileName):
3268         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3269         (WebCore::ClipboardChromium::validateFileName):
3270         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3271         (WebCore::isInvalidFileCharacter):
3272         (WebCore::ClipboardChromium::validateFileName):
3273
3274 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3275
3276         Reviewed by Simon Hausmann.
3277
3278         Fix the Copyright notices in a few files
3279
3280         * platform/qt/RenderThemeQt.h:
3281
3282 2009-02-23  Xan Lopez  <xan@gnome.org>
3283
3284         Reviewed by Alexey Proskuryakov.
3285
3286         https://bugs.webkit.org/show_bug.cgi?id=22624
3287         [SOUP][GTK] Need API to get SoupSession from WebKit.
3288
3289         Allow to retrieve the Soup session and modify the code to take
3290         into account users changing features on it.
3291
3292         * platform/network/ResourceHandle.h:
3293         * platform/network/soup/CookieJarSoup.cpp:
3294         (WebCore::defaultCookieJar):
3295         (WebCore::setDefaultCookieJar):
3296         * platform/network/soup/CookieJarSoup.h:
3297         * platform/network/soup/ResourceHandleSoup.cpp:
3298         (WebCore::createSoupSession):
3299         (WebCore::ensureSessionIsInitialized):
3300         (WebCore::ResourceHandle::startHttp):
3301         (WebCore::ResourceHandle::cancel):
3302         (WebCore::ResourceHandle::defaultSession):
3303
3304 2009-02-23  Xan Lopez  <xan@gnome.org>
3305
3306         Reviewed by Alexey Proskuryakov.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=22624
3309         [SOUP][GTK] Need API to get SoupSession from WebKit.
3310
3311         Remove CURL support.
3312
3313         * GNUmakefile.am:
3314
3315 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3316
3317         Reviewed by Mark Rowe.
3318
3319         Test: fast/dom/empty-hash-and-search.html
3320
3321         https://bugs.webkit.org/show_bug.cgi?id=21147
3322         hash property returns incorrect value for links w/o hash
3323
3324         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
3325
3326         * platform/KURL.cpp:
3327         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
3328         (WebCore::KURL::prettyURL): Append the query with the question mark.
3329
3330         * page/Location.cpp:
3331         (WebCore::Location::search): Return an empty string if query is empty or missing.
3332         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
3333
3334         * dom/WorkerLocation.cpp:
3335         (WebCore::WorkerLocation::search):
3336         (WebCore::WorkerLocation::hash):
3337         Match document.location fixes above.
3338
3339         * html/HTMLAnchorElement.cpp:
3340         (WebCore::HTMLAnchorElement::hash):
3341         (WebCore::HTMLAnchorElement::search):
3342         Return an empty string for empty and missing parts.
3343
3344 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3345
3346         Reviewed by Darin Adler.
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=20184
3349         SELECT with no name generates invalid query string
3350
3351         Test: fast/forms/select-no-name.html
3352
3353         * html/HTMLSelectElement.cpp:
3354         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
3355
3356 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3357
3358         Apply review comments for the previous check-in (forgot to save the file, oops).
3359
3360         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
3361
3362 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3363
3364         Reviewed by Darin Adler.
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=15707
3367         Crash when manipulating document from within an iframe onload function
3368
3369         Test: fast/dom/onload-open.html
3370
3371         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
3372         the current node, because anything can happen when dispatching events.
3373
3374 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3375
3376         Reviewed by Darin Adler.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=18970
3379         Numerically named input fields cause document.forms loop problems
3380
3381         Test: fast/forms/numeric-input-name.html
3382
3383         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
3384         latter overrides properties.
3385
3386 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3387
3388         Reviewed by Sam Weinig.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=24059
3391         Tokenizer::write() return value is never used
3392
3393         * dom/Tokenizer.h:
3394         * dom/XMLTokenizer.cpp:
3395         (WebCore::XMLTokenizer::write):
3396         * dom/XMLTokenizer.h:
3397         * html/HTMLTokenizer.cpp:
3398         (WebCore::HTMLTokenizer::write):
3399         * html/HTMLTokenizer.h:
3400         * loader/FTPDirectoryDocument.cpp:
3401         (WebCore::FTPDirectoryTokenizer::write):
3402         * loader/ImageDocument.cpp:
3403         (WebCore::ImageTokenizer::write):
3404         * loader/MediaDocument.cpp:
3405         (WebCore::MediaTokenizer::write):
3406         * loader/PluginDocument.cpp:
3407         (WebCore::PluginTokenizer::write):
3408         * loader/TextDocument.cpp:
3409         (WebCore::TextTokenizer::write):
3410         Made write() return void, not bool.
3411
3412 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
3413
3414         Reviewed by Sam Weinig.
3415
3416         Updated for JavaScriptCore changes to timeout checking.
3417
3418         * bindings/js/JSCustomPositionCallback.cpp:
3419         (WebCore::JSCustomPositionCallback::handleEvent):
3420         * bindings/js/JSCustomPositionErrorCallback.cpp:
3421         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3422         * bindings/js/JSCustomSQLStatementCallback.cpp:
3423         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3424         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3425         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3426         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3427         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3428         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3429         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3430         * bindings/js/JSCustomVoidCallback.cpp:
3431         (WebCore::JSCustomVoidCallback::handleEvent):
3432         * bindings/js/JSCustomXPathNSResolver.cpp:
3433         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3434         * bindings/js/JSDOMWindowBase.cpp:
3435         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
3436         (WebCore::JSDOMWindowBase::commonJSGlobalData):
3437         * bindings/js/JSEventListener.cpp:
3438         (WebCore::JSAbstractEventListener::handleEvent):
3439         * bindings/js/ScheduledAction.cpp:
3440         (WebCore::ScheduledAction::executeFunctionInContext):
3441         * bindings/js/ScriptController.cpp:
3442         (WebCore::ScriptController::evaluate):
3443         * bindings/js/WorkerScriptController.cpp:
3444         (WebCore::WorkerScriptController::evaluate):
3445         (WebCore::WorkerScriptController::forbidExecution):
3446         * bindings/objc/WebScriptObject.mm:
3447         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3448         (-[WebScriptObject evaluateWebScript:]):
3449         * bridge/NP_jsobject.cpp:
3450         (_NPN_InvokeDefault):
3451         (_NPN_Invoke):
3452         (_NPN_Evaluate):
3453         (_NPN_Construct):
3454         * bridge/jni/jni_jsobject.mm:
3455         (JavaJSObject::call):
3456         (JavaJSObject::eval):
3457
3458 2009-02-21  Hironori Bono  <hbono@chromium.org>
3459
3460         Reviewed by Alexey Proskuryakov.
3461
3462         https://bugs.webkit.org/show_bug.cgi?id=23786
3463         [Chromium] line-break characters in a complex text are treated as zero-width spaces
3464
3465         This change prevents the UniscribeHelper class from treating the line-break characters
3466         as whitespaces.
3467
3468         Tests: fast/text/international/bidi-linebreak-001.html
3469                fast/text/international/bidi-linebreak-002.html
3470                fast/text/international/bidi-linebreak-003.html
3471
3472         * platform/graphics/chromium/UniscribeHelper.cpp:
3473         (WebCore::UniscribeHelper::adjustSpaceAdvances):
3474         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
3475         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
3476         so does when Chromium renders a simple text.
3477
3478 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
3479
3480         Reviewed by Alexey Proskuryakov.
3481
3482         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
3483
3484         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
3485         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
3486         unneeded.
3487
3488         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
3489         enables us to use some generated QualifiedName.
3490
3491         * bindings/js/JSOptionConstructor.cpp:
3492         (WebCore::constructHTMLOptionElement):
3493         * dom/Document.cpp:
3494         (WebCore::Document::setTitle):
3495         * dom/XMLTokenizer.cpp:
3496         (WebCore::createXHTMLParserErrorHeader):
3497         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3498         * editing/CompositeEditCommand.cpp:
3499         (WebCore::createBlockPlaceholderElement):
3500         * editing/htmlediting.cpp:
3501         (WebCore::createTabSpanElement):
3502         * html/HTMLSelectElement.cpp:
3503         (WebCore::HTMLSelectElement::setLength):
3504         * loader/FTPDirectoryDocument.cpp:
3505         (WebCore::FTPDirectoryTokenizer::appendEntry):
3506         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
3507         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
3508         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
3509         * loader/ImageDocument.cpp:
3510         (WebCore::ImageDocument::createDocumentStructure):
3511         * loader/MediaDocument.cpp:
3512         (WebCore::MediaTokenizer::createDocumentStructure):
3513         * loader/PluginDocument.cpp:
3514         (WebCore::PluginTokenizer::createDocumentStructure):
3515         * loader/TextDocument.cpp:
3516         (WebCore::TextTokenizer::write):
3517         * page/Frame.cpp:
3518         (WebCore::Frame::selectionComputedStyle):
3519         (WebCore::Frame::styleForSelectionStart):
3520         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
3521
3522         * xml/XPathFunctions.cpp:
3523         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
3524         * page/DragController.cpp:
3525         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
3526
3527 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3528
3529         Reviewed by Eric Seidel.
3530
3531         https://bugs.webkit.org/show_bug.cgi?id=24060
3532         Fix up to accommodate for CanvasPixelArray return.
3533
3534         * platform/graphics/skia/ImageBufferSkia.cpp:
3535         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
3536         (WebCore::ImageBuffer::putImageData): Ditto.
3537
3538 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3539
3540         Simon Fraser
3541
3542         https://bugs.webkit.org/show_bug.cgi?id=24042
3543         Bug 24042: MediaPlayer should cache plug-in proxy
3544
3545         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
3546         MediaPlayer will always have created the private media player object before
3547         the plug-in is instantiated and calls back with the proxy object. This is not
3548         true on all platforms because of threading latency, so MediaPlayer should
3549         cache the plug-in proxy so it can pass it to the media engine at a later time.
3550
3551         * platform/graphics/MediaPlayer.cpp:
3552         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
3553         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
3554         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
3555         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
3556         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
3557         (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
3558         * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
3559
3560 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3561
3562         Simon Fraser.
3563
3564         https://bugs.webkit.org/show_bug.cgi?id=24063
3565         Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
3566
3567         * html/HTMLMediaElement.cpp:
3568         (WebCore::HTMLMediaElement::HTMLMediaElement):  Rename m_loadRestrictions to m_Restrictions.
3569         Initialize m_internalCall.
3570         (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
3571         (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
3572         (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
3573         (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
3574         (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
3575         (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
3576         (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
3577         (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
3578         (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
3579         (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
3580         * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
3581         add RequireUserGestureRateChangeRestriction.
3582
3583 2009-02-20  Darin Fisher  <darin@chromium.org>
3584
3585         Fix build bustage in FileSystemWin.cpp.
3586
3587         Need to return CString() instead of 0 since there are now two CString
3588         constructors that take a pointer type.
3589
3590         * platform/win/FileSystemWin.cpp:
3591         (WebCore::openTemporaryFile):
3592
3593 2009-02-20  Dimitri Glazkov  <dglazkov@chromium.org>
3594
3595         Reviewed by Sam Weinig.
3596
3597         https://bugs.webkit.org/show_bug.cgi?id=23999
3598         Change license headers to accurately reflect code history.
3599
3600         * platform/ContentType.cpp:
3601         * platform/ContentType.h:
3602
3603 2009-02-18  Dimitri Glazkov  <dglazkov@chromium.org>
3604
3605         Reviewed by Antti Koivisto.
3606
3607         https://bugs.webkit.org/show_bug.cgi?id=23999
3608         Split off MIME type parsing into its own class.