59a6bd3f951e57f1e4eda76ebfb359fabc14f4d9
[WebKit-https.git] / WebCore / ChangeLog
1 2006-09-26  Eric Seidel  <eric@eseidel.com>
2
3         Reviewed by mitz.
4
5         Bring animation back to life
6         http://bugzilla.opendarwin.org/show_bug.cgi?id=11021
7         
8         Register/unregister SVGSVGElements as time containers on insertion/removal.
9         Replace uses of DeprecatedString with String in SVGAnimationElement
10         Various whitespace clean-up.
11
12         * ksvg2/misc/KSVGTimeScheduler.cpp:
13         (WebCore::SVGTimer::notifyAll):
14         * ksvg2/misc/SVGDocumentExtensions.cpp:
15         (WebCore::SVGDocumentExtensions::startAnimations):
16         (WebCore::SVGDocumentExtensions::pauseAnimations):
17         (WebCore::SVGDocumentExtensions::unpauseAnimations):
18         * ksvg2/svg/SVGAnimateTransformElement.cpp:
19         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
20         (WebCore::SVGAnimateTransformElement::parseTransformValue):
21         * ksvg2/svg/SVGAnimateTransformElement.h:
22         * ksvg2/svg/SVGAnimationElement.cpp:
23         (WebCore::SVGAnimationElement::SVGAnimationElement):
24         (WebCore::SVGAnimationElement::parseMappedAttribute):
25         (WebCore::SVGAnimationElement::parseClockValue):
26         (WebCore::SVGAnimationElement::targetAttribute):
27         (WebCore::SVGAnimationElement::setTargetAttribute):
28         (WebCore::SVGAnimationElement::attributeName):
29         * ksvg2/svg/SVGAnimationElement.h:
30         (WebCore::SVGAnimationElement::rendererIsNeeded):
31         * ksvg2/svg/SVGSVGElement.cpp:
32         (WebCore::SVGSVGElement::getScreenCTM):
33         (WebCore::SVGSVGElement::createRenderer):
34         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
35         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
36         * ksvg2/svg/SVGSVGElement.h:
37         * ksvg2/svg/SVGSetElement.cpp:
38         (WebCore::SVGSetElement::handleTimerEvent):
39         * ksvg2/svg/SVGURIReference.cpp:
40         (WebCore::SVGURIReference::getTarget):
41         * ksvg2/svg/SVGURIReference.h:
42
43 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
44
45         Reviewed by mitzpettel.
46
47         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
48         No-SVG build broken since r16549
49         
50         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
51
52         * css/cssparser.cpp:
53         (WebCore::CSSParser::parseValue):
54         * css/cssstyleselector.cpp:
55         (WebCore::CSSStyleSelector::applyProperty):
56         * page/FrameView.cpp:
57         (WebCore::selectCursor):
58         * platform/qt/GraphicsContextQt.cpp:
59
60 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
61
62         Reviewed by Maciej.
63
64         http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
65         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
66         
67         (Originally written by Eric Seidel).
68         
69         * bindings/js/kjs_window.cpp:
70         (KJS::floatFeature):
71         * ksvg2/svg/SVGAngle.cpp:
72         (SVGAngle::setValueAsString):
73         * ksvg2/svg/SVGAnimationElement.cpp:
74         (SVGAnimationElement::parseMappedAttribute):
75         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
76         (SVGComponentTransferFunctionElement::parseMappedAttribute):
77         * ksvg2/svg/SVGFECompositeElement.cpp:
78         (WebCore::SVGFECompositeElement::parseMappedAttribute):
79         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
80         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
81         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
82         (SVGFEDisplacementMapElement::parseMappedAttribute):
83         * ksvg2/svg/SVGFELightElement.cpp:
84         (SVGFELightElement::parseMappedAttribute):
85         * ksvg2/svg/SVGFEOffsetElement.cpp:
86         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
87         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
88         (SVGFESpecularLightingElement::parseMappedAttribute):
89         * ksvg2/svg/SVGFETurbulenceElement.cpp:
90         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
91         * ksvg2/svg/SVGStopElement.cpp:
92         (SVGStopElement::parseMappedAttribute):
93         * platform/AtomicString.h:
94         (WebCore::AtomicString::toDouble):
95         * platform/PlatformString.h:
96         * platform/String.cpp:
97         (WebCore::String::toDouble):
98         * platform/StringImpl.cpp:
99         (WebCore::StringImpl::toDouble):
100         * platform/StringImpl.h:
101         * rendering/DeprecatedSlider.cpp:
102         (WebCore::DeprecatedSlider::updateFromElement):
103         * xml/XPathGrammar.y:
104
105 2006-09-25  David Harrison  <harrison@apple.com>
106
107         Reviewed by Tim Omernick and Tim Hatcher.
108
109         <rdar://problem/4717965> Text Field text parameterized attributes should work
110         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
111
112         * bridge/mac/WebCoreAXObject.mm:
113         (-[WebCoreAXObject accessibilityAttributeValue:]):
114         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
115         
116         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
117         Cleaned up. Added text field and text area parameterzed attributes.
118         
119         (-[WebCoreAXObject doAXLineForTextMarker:]):
120         Fixed to be zero-based and to deal with the first position properly.
121         
122         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
123         Minor formatting.
124         
125         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
126         (-[WebCoreAXObject indexForTextMarker:]):
127         (-[WebCoreAXObject textMarkerRangeForRange:]):
128         (-[WebCoreAXObject rangeForTextMarkerRange:]):
129         New utility methods.
130         
131         (-[WebCoreAXObject doAXLineForIndex:]):
132         (-[WebCoreAXObject doAXRangeForLine:]):
133         (-[WebCoreAXObject doAXStringForRange:]):
134         (-[WebCoreAXObject doAXRangeForPosition:]):
135         (-[WebCoreAXObject doAXRangeForIndex:]):
136         (-[WebCoreAXObject doAXBoundsForRange:]):
137         (-[WebCoreAXObject doAXAttributedStringForRange:]):
138         (-[WebCoreAXObject doAXRTFForRange:]):
139         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
140         Implement text field and text area parameterized attributes.
141          
142         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
143         Added text field and text area parameterzed attributes.
144
145         * rendering/RenderTextControl.h:
146         Made indexForVisiblePosition() and visiblePositionForIndex() public.
147
148 2006-09-25  Adam Roben  <aroben@apple.com>
149
150         Reviewed by Brady.
151
152         Build fixes.
153
154         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
155         * platform/ResourceLoader.h: Store whether a particular job
156         has received a response within the ResourceLoader object itself, since
157         it's possible that we will enter the InternetReadFileExA while loop
158         twice for the same job.
159         * platform/ResourceLoaderInternal.h: Add private instance variable to
160         store whether we've received a response.
161         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
162         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
163         directives.
164         * platform/win/ResourceLoaderWin.cpp: 
165         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
166         whether it has received a response instead of assuming it hasn't.
167         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
168         (WebCore::ResourceLoader::hasReceivedResponse): Added.
169         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
170         setProportion
171         (ScrollBar::setProportion):
172
173 2006-09-25  Brady Eidson  <beidson@apple.com>
174
175         Requested by ggaren
176
177         Disabled IconDatabase logging by default
178
179         * platform/Logging.cpp:
180         (WebCore::):
181
182 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
183
184         Build fix
185
186         * platform/cf/ResourceLoaderCFNet.cpp:
187         (WebCore::willCacheResponse):
188
189 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
190
191         Reviewed by john
192         
193         <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
194         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
195         
196         * editing/IndentOutdentCommand.cpp:
197         (WebCore::IndentOutdentCommand::indentRegion): Special case
198         an empty root editable element.
199
200 2006-09-25  Brady Eidson  <beidson@apple.com>
201
202         Reviewed by Steve
203
204         Math error in SystemTimeWin
205
206         * platform/win/SystemTimeWin.cpp:
207         (WebCore::currentTime):
208
209 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
210
211         Reviewed by Eric.
212
213         Whitespace cleanup; rename *job variables to *loader.
214
215         * bindings/js/JSXMLHttpRequest.cpp:
216         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
217         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
218         (KJS::JSXMLHttpRequestConstructorImp::construct):
219         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
220         (KJS::JSXMLHttpRequest::getValueProperty):
221         (KJS::JSXMLHttpRequest::put):
222         (KJS::JSXMLHttpRequest::putValueProperty):
223         (KJS::JSXMLHttpRequest::mark):
224         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
225         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
226         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
227         * bindings/js/JSXMLHttpRequest.h:
228         (KJS::JSXMLHttpRequest::toBoolean):
229         * xml/xmlhttprequest.cpp:
230         (WebCore::XMLHttpRequest::XMLHttpRequest):
231         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
232         (WebCore::XMLHttpRequest::send):
233         (WebCore::XMLHttpRequest::abort):
234         (WebCore::XMLHttpRequest::receivedAllData):
235         (WebCore::XMLHttpRequest::receivedData):
236         * xml/xmlhttprequest.h:
237         (WebCore::):
238
239 2006-09-25  Timothy Hatcher  <timothy@apple.com>
240
241         Reviewed by Brady.
242
243         - Deprecate the rest of the old-style methods that are not generated.
244         - Add @property syntax to DOMRange.
245
246         * WebCore.xcodeproj/project.pbxproj:
247         * bindings/objc/DOM.mm:
248         (-[DOMRange setStart:offset:]):
249         (-[DOMRange setEnd:offset:]):
250         (-[DOMRange compareBoundaryPoints:sourceRange:]):
251         (-[DOMRange setStart::]):
252         (-[DOMRange setEnd::]):
253         (-[DOMRange compareBoundaryPoints::]):
254         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
255         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
256         (-[DOMDocument createNodeIterator::::]):
257         (-[DOMDocument createTreeWalker::::]):
258         * bindings/objc/DOMCSS.h:
259         * bindings/objc/DOMCSS.mm:
260         (-[DOMDocument getComputedStyle:pseudoElement:]):
261         (-[DOMDocument getComputedStyle::]):
262         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
263         * bindings/objc/DOMExtensions.h:
264         * bindings/objc/DOMHTML.h:
265         * bindings/objc/DOMRange.h:
266         * bindings/objc/DOMTraversal.h:
267
268 2006-09-25  Eric Seidel  <eric@eseidel.com>
269
270         Reviewed by mjs.
271         
272         Outermost <svg> element should clip to viewport
273         http://bugzilla.opendarwin.org/show_bug.cgi?id=11007
274
275         Test: svg/custom/viewport-clip.svg
276
277         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
278
279 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
280
281         Reviewed by Maciej.
282
283         * css/MediaList.cpp:
284         Remove unused header.
285         
286         * dom/Document.cpp:
287         (WebCore::Document::clear):
288         Use clear instead of iterating through the list of event listeners, removing each one.
289         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
290         
291         * html/HTMLKeygenElement.cpp:
292         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
293         (WebCore::HTMLKeygenElement::appendFormData):
294         Update due to changes in the SSL key generator.
295         
296         * ksvg2/svg/SVGAngle.cpp:
297         Remove unused header.
298         
299         * ksvg2/svg/SVGAnimationElement.cpp:
300         (SVGAnimationElement::parseMappedAttribute):
301         Rename methods and pass Strings instead of DeprecatedStrings to
302         parseSeparatedList.
303         
304         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
305         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
306         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
307         * ksvg2/svg/SVGFEMergeElement.cpp:
308         * ksvg2/svg/SVGFEOffsetElement.cpp:
309         Remove unused headers.
310         
311         * ksvg2/svg/SVGHelper.cpp:
312         (WebCore::SVGHelper::parseSeparatedList):
313         * ksvg2/svg/SVGHelper.h:
314         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
315         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
316         
317         * ksvg2/svg/SVGLengthList.cpp:
318         (WebCore::SVGLengthList::parse):
319         * ksvg2/svg/SVGLengthList.h:
320         Use Vector<String> instead of DeprecatedStringList.
321         
322         * loader/Cache.cpp:
323         (WebCore::Cache::requestImage):
324         (WebCore::Cache::requestStyleSheet):
325         (WebCore::Cache::requestScript):
326         (WebCore::Cache::requestXSLStyleSheet):
327         (WebCore::Cache::requestXBLDocument):
328         (WebCore::Cache::remove):
329         (WebCore::Cache::get):
330         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
331         
332         * loader/DocLoader.cpp:
333         (WebCore::DocLoader::needReload):
334         * loader/DocLoader.h:
335         Use a HashSet instead of DeprecatedStringList.
336         
337         * page/FrameView.h:
338         Remove declarations that have no functions.
339         
340         * platform/SSLKeyGenerator.h:
341         * platform/mac/SSLKeyGeneratorMac.mm:
342         (WebCore::supportedKeySizes):
343         (WebCore::signedPublicKeyAndChallengeString):
344         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
345         DeprecatedString.
346
347 2006-09-25  Dave Hyatt  <hyatt@apple.com>
348
349         Shunt the RenderTheme world transform adoption between
350         Cairo and Windows into getWindowsContext and move the method
351         out of GraphicsContextCairo and into GraphicsContextWin.
352
353         * ChangeLog:
354         * WebCore.vcproj/WebCore/WebCore.vcproj:
355         * platform/cairo/GraphicsContextCairo.cpp:
356         * platform/win/GraphicsContextWin.cpp: Added.
357         (WebCore::GraphicsContext::getWindowsContext):
358         (WebCore::GraphicsContext::releaseWindowsContext):
359         * rendering/RenderThemeWin.cpp:
360         (WebCore::prepareForDrawing):
361
362 2006-09-24  Eric Seidel  <eric@eseidel.com>
363
364         Reviewed by hyatt.
365
366         <svg:a> cannot be styled with a:hover
367         http://bugzilla.opendarwin.org/show_bug.cgi?id=11005
368         
369         Test: svg/hixie/cascade/002.xml
370
371         * css/cssstyleselector.cpp:
372         (WebCore::checkPseudoState):
373
374 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
375
376         Reviewed by Tim H.
377
378         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
379         SVG needs Obj-C DOM bindings
380
381         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The 
382           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
383           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and 
384           DOMSVGTransformList.
385
386         * DerivedSources.make:
387         * WebCore.xcodeproj/project.pbxproj:
388         * bindings/objc/DOMInternal.h:
389         * bindings/objc/DOMSVG.h: Added.
390         * ksvg2/svg/SVGAngle.idl:
391         * ksvg2/svg/SVGLength.idl:
392         * ksvg2/svg/SVGLengthList.idl:
393         * ksvg2/svg/SVGMatrix.idl:
394         * ksvg2/svg/SVGPathSeg.idl:
395         * ksvg2/svg/SVGPathSegList.idl:
396         * ksvg2/svg/SVGTransform.idl:
397         * ksvg2/svg/SVGTransformList.idl:
398
399 2006-09-24  Rob Buis  <buis@kde.org>
400
401         Reviewed by eseidel.
402
403         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
404         WebKit does not handle fallback custom cursors
405         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
406         WebKit does not properly handle SVG <cursor> element
407
408         Add support for svg cursor images. Also make sure hotspot
409         settings are handled correctly. Add tests for handling of css3
410         cursor syntax with hotspots in strict and quirks mode. Finally
411         implement fallback.
412
413         * WebCore.xcodeproj/project.pbxproj:
414         * css/CSSComputedStyleDeclaration.cpp:
415         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
416         * css/CSSCursorImageValue.cpp: Added.
417         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
418         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
419         * css/CSSCursorImageValue.h: Added.
420         (WebCore::CSSCursorImageValue::hotspot):
421         * css/cssparser.cpp:
422         (WebCore::CSSParser::parseValue):
423         * css/cssstyleselector.cpp:
424         (WebCore::CSSStyleSelector::applyProperty):
425         * ksvg2/svg/SVGCursorElement.cpp:
426         * manual-tests/css3-cursor-fallback-quirks.html: Added.
427         * manual-tests/css3-cursor-fallback-strict.html: Added.
428         * manual-tests/cursorfallback.xml: Added.
429         * page/FrameView.cpp:
430         (WebCore::selectCursor):
431         * platform/Cursor.h:
432         * platform/mac/CursorMac.mm:
433         (WebCore::createCustomCursor):
434         (WebCore::Cursor::Cursor):
435         * platform/qt/CursorQt.cpp:
436         (WebCore::Cursor::Cursor):
437         * rendering/RenderStyle.cpp:
438         (WebCore::StyleInheritedData::StyleInheritedData):
439         (WebCore::StyleInheritedData::operator==):
440         (WebCore::RenderStyle::diff):
441         (WebCore::RenderStyle::addCursor):
442         (WebCore::RenderStyle::addSVGCursor):
443         (WebCore::RenderStyle::setCursorList):
444         (WebCore::RenderStyle::clearCursorList):
445         * rendering/RenderStyle.h:
446         (WebCore::CursorData::CursorData):
447         (WebCore::CursorList::operator[]):
448         (WebCore::CursorList::size):
449         (WebCore::CursorList::append):
450         (WebCore::RenderStyle::cursors):
451
452 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
453
454         Reviewed by Tim H.
455
456         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
457         Auto-generate the internal methods interfaces for the Objective-C bindings
458
459         - Auto-generate the internal method declarations into their own files
460           named in the form DOMFooBarInternal.h for class DOMFooBar.
461
462         - Remove all use of DOM_cast from code.
463
464         - Assorted cleanups.
465
466         * WebCore.xcodeproj/project.pbxproj:
467         * bindings/objc/DOM.mm:
468         (-[DOMNode _initWithNode:WebCore::]):
469         (-[DOMNode WebCore::]):
470         (-[DOMRange dealloc]):
471         (-[DOMRange finalize]):
472         (-[DOMRange _initWithRange:WebCore::]):
473         (-[DOMRange WebCore::]):
474         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
475         (-[DOMNodeFilter WebCore::]):
476         (-[DOMNodeFilter dealloc]):
477         (-[DOMNodeFilter finalize]):
478         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
479         (-[DOMNodeIterator WebCore::]):
480         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
481         (-[DOMTreeWalker WebCore::]):
482         * bindings/objc/DOMAbstractView.mm:
483         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
484         * bindings/objc/DOMCSS.mm:
485         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
486         (-[DOMCSSRule _initWithRule:WebCore::]):
487         (-[DOMCSSValue _initWithValue:WebCore::]):
488         * bindings/objc/DOMEvents.mm:
489         (-[DOMEvent _initWithEvent:WebCore::]):
490         * bindings/objc/DOMHTMLAppletElement.mm:
491         (-[DOMHTMLAppletElement align]):
492         (-[DOMHTMLAppletElement setAlign:]):
493         (-[DOMHTMLAppletElement alt]):
494         (-[DOMHTMLAppletElement setAlt:]):
495         (-[DOMHTMLAppletElement archive]):
496         (-[DOMHTMLAppletElement setArchive:]):
497         (-[DOMHTMLAppletElement code]):
498         (-[DOMHTMLAppletElement setCode:]):
499         (-[DOMHTMLAppletElement codeBase]):
500         (-[DOMHTMLAppletElement setCodeBase:]):
501         (-[DOMHTMLAppletElement height]):
502         (-[DOMHTMLAppletElement setHeight:]):
503         (-[DOMHTMLAppletElement hspace]):
504         (-[DOMHTMLAppletElement setHspace:]):
505         (-[DOMHTMLAppletElement name]):
506         (-[DOMHTMLAppletElement setName:]):
507         (-[DOMHTMLAppletElement object]):
508         (-[DOMHTMLAppletElement setObject:]):
509         (-[DOMHTMLAppletElement vspace]):
510         (-[DOMHTMLAppletElement setVspace:]):
511         (-[DOMHTMLAppletElement width]):
512         (-[DOMHTMLAppletElement setWidth:]):
513         * bindings/objc/DOMInternal.h:
514         (getDOMWrapper):
515         (addDOMWrapper):
516         (raiseOnDOMError):
517         * bindings/objc/DOMXPath.mm:
518         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
519         * bindings/scripts/CodeGeneratorObjC.pm:
520
521 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
522
523         Reviewed by eseidel.
524
525         Fix Qt/Linux build after Dave's Scrollbar changes.
526
527         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
528         * platform/qt/TemporaryLinkStubs.cpp:
529         (WebCore::ScrollBar::setProportion):
530         (WebCore::PlatformScrollBar::updateThumbPosition):
531         (WebCore::PlatformScrollBar::updateThumbProportion):
532
533 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
534
535         Reviewed by eseidel.
536
537         Qt/Linux build system changes: enable xpath/xslt by default.
538         Offer possibility to change all of these using 'ccmake'.
539
540         * CMakeLists.txt:
541
542 2006-09-24  Dave Hyatt  <hyatt@apple.com>
543
544         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
545         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
546         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
547
548         * platform/ScrollBar.cpp:
549         (WebCore::ScrollBar::setValue):
550         (WebCore::ScrollBar::setProportion):
551         * platform/ScrollBar.h:
552         (WebCore::ScrollBar::value):
553         * platform/mac/PlatformScrollBar.h:
554         * platform/mac/PlatformScrollBarMac.mm:
555         (WebCore::PlatformScrollBar::updateThumbPosition):
556         (WebCore::PlatformScrollBar::updateThumbProportion):
557         * platform/win/PlatformScrollBar.h:
558         * platform/win/TemporaryLinkStubs.cpp:
559         (PlatformScrollBar::updateThumbPosition):
560         (PlatformScrollBar::updateThumbProportion):
561         * rendering/RenderLayer.cpp:
562         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
563
564 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
565
566         Reviewed by Eric.
567
568         http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
569         XMLHttpRequest fails to throw an exception when there is a security violation
570         (mismatching domains)
571
572         Raise an exception if there is a security violation, and also in cases required by
573         the current draft of XHR specification.
574
575         * bindings/js/JSXMLHttpRequest.cpp:
576         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
577         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
578         reports one, and also if there were too few arguments passed. 
579
580         * bindings/js/kjs_binding.cpp:
581         (KJS::setDOMException): Added support for custom XHR exceptions.
582
583         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
584         exception code range for XHR exceptions.
585
586         * xml/xmlhttprequest.cpp:
587         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
588         (WebCore::XMLHttpRequest::send):
589         (WebCore::XMLHttpRequest::setRequestHeader):
590         (WebCore::XMLHttpRequest::getStatus):
591         (WebCore::XMLHttpRequest::getStatusText):
592         (WebCore::XMLHttpRequest::processSyncLoadResults):
593         (WebCore::XMLHttpRequest::receivedAllData):
594         (WebCore::XMLHttpRequest::receivedData):
595
596 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
597
598         Reviewed by Jeff Jenkins.
599
600         Tweak CF types.
601
602         * platform/cf/ResourceLoaderCFNet.cpp:
603         (WebCore::willCacheResponse):
604
605 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
606
607         Reviewed by darin
608
609         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
610         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
611
612         * dom/Document.cpp:
613         (WebCore::Document::clearSelectionIfNeeded):
614         * dom/Element.cpp:
615         (WebCore::Element::contains):
616         * dom/Node.cpp:
617         (WebCore::Node::traverseNextNode):
618         (WebCore::Node::traverseNextSibling):
619         (WebCore::Node::traversePreviousNodePostOrder):
620         (WebCore::Node::checkAddChild):
621         (WebCore::Node::isDescendantOf):
622         * dom/Node.h:
623         * dom/NodeIterator.cpp:
624         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
625         * editing/ApplyStyleCommand.cpp:
626         (WebCore::ApplyStyleCommand::applyBlockStyle):
627         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
628         (WebCore::ApplyStyleCommand::applyInlineStyle):
629         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
630         * editing/CompositeEditCommand.cpp:
631         (WebCore::CompositeEditCommand::mergeIdenticalElements):
632         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
633         * editing/DeleteSelectionCommand.cpp:
634         (WebCore::updatePositionForNodeRemoval):
635         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
636         (WebCore::DeleteSelectionCommand::mergeParagraphs):
637         * editing/FormatBlockCommand.cpp:
638         (WebCore::FormatBlockCommand::doApply):
639         * editing/IndentOutdentCommand.cpp:
640         (WebCore::enclosingListOrBlockquote):
641         * editing/Selection.cpp:
642         (WebCore::Selection::validate):
643         * editing/SelectionController.cpp:
644         (WebCore::SelectionController::nodeWillBeRemoved):
645         * editing/TextIterator.cpp:
646         (WebCore::SimplifiedBackwardsTextIterator::advance):
647         * editing/VisiblePosition.cpp:
648         (WebCore::VisiblePosition::next):
649         (WebCore::VisiblePosition::previous):
650         (WebCore::VisiblePosition::canonicalPosition):
651         (WebCore::isFirstVisiblePositionInNode):
652         (WebCore::isLastVisiblePositionInNode):
653         * editing/htmlediting.cpp:
654         (WebCore::firstEditablePositionAfterPositionInRoot):
655         (WebCore::lastEditablePositionBeforePositionInRoot):
656         (WebCore::enclosingNodeWithTag):
657         (WebCore::enclosingList):
658         (WebCore::enclosingListChild):
659         * editing/markup.cpp:
660         (WebCore::createMarkup):
661
662 2006-09-22  Timothy Hatcher  <timothy@apple.com>
663
664         Reviewed by Darin.
665
666         - Added @property syntax to non-generated headers
667           inside #ifndef BUILDING_ON_TIGER.
668         - Changed the DOMEventTarget protocol to have have new versions
669           of addEventListener and removeEventListener with named parameters.
670           These old style methods can be removed once Mail changes to use
671           the new methods <rdar://problem/4746649>.
672
673         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
674         * bindings/objc/DOM.mm:
675         (-[DOMNode addEventListener:listener:useCapture:]):
676         (-[DOMNode addEventListener:::]): call the new method
677         (-[DOMNode removeEventListener:listener:useCapture:]):
678         (-[DOMNode removeEventListener:::]): call the new method
679         * bindings/objc/DOMAbstractView.h:
680         * bindings/objc/DOMEventTarget.h:
681         * bindings/objc/DOMHTMLAppletElement.h:
682         * bindings/objc/DOMHTMLEmbedElement.h:
683         * bindings/objc/DOMHTMLOptionElement.h:
684         * bindings/objc/DOMObject.h:
685         * bindings/objc/DOMRGBColor.h:
686
687 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
688
689         Reviewed by Eric.
690
691         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
692
693         * platform/qt/FrameQt.cpp:
694         * platform/qt/GraphicsContextQt.cpp:
695         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
696         (WebCore::GraphicsContext::origin):
697         * platform/qt/PlatformScrollBar.h: Added.
698         (WebCore::PlatformScrollBar::isWidget):
699         * platform/qt/WidgetQt.cpp:
700         (WebCore::Widget::invalidate):
701         (WebCore::Widget::invalidateRect):
702
703 2006-09-22  Dave Hyatt <hyatt@apple.com>
704
705         Super-minor tweaks to the systemFont function on Mac.
706         Set the generic family to None rather than to Serif, and
707         don't waste time setting the computed size, since that is
708         set from the specified size over in CSSStyleSelector anyway.
709
710         * rendering/RenderThemeMac.mm:
711         (WebCore::RenderThemeMac::systemFont):
712
713 2006-09-22  Timothy Hatcher  <timothy@apple.com>
714
715         Reviewed by Brady.
716
717         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
718         take floats. There was already an implicit conversion to float/double
719         when calling CGContextTranslateCTM or cairo_translate.
720
721         * platform/GraphicsContext.h:
722         * platform/cairo/GraphicsContextCairo.cpp:
723         (WebCore::GraphicsContext::translate):
724         * platform/cg/GraphicsContextCG.cpp:
725         (WebCore::GraphicsContext::translate):
726
727 2006-09-22  Brady Eidson  <beidson@apple.com>
728
729         Reviewed by Sfalken
730
731         Add redirect and other cleanup to ResourceLoaderWin.cpp
732         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10927
733         Fixes bug http://bugzilla.opendarwin.org/show_bug.cgi?id=10744
734
735         * WebCore.xcodeproj/project.pbxproj:
736         * platform/ResourceLoader.h:
737         * platform/win/ResourceLoaderWin.cpp:
738         (WebCore::ResourceLoaderWndProc):
739         (WebCore::initializeOffScreenResourceLoaderWindow):
740         (WebCore::ResourceLoader::onHandleCreated):
741         (WebCore::ResourceLoader::onRequestRedirected):
742         (WebCore::ResourceLoader::onRequestComplete):
743         (WebCore::transferJobStatusCallback):
744
745 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
746
747         Reviewed by Geoff.
748
749         http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
750         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
751
752         * page/FrameView.cpp:
753         (WebCore::FrameView::hoverTimerFired): Use the current event.
754
755 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
756
757         Reviewed by Anders.
758
759         Fix (last) svg memory leak.
760
761         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
762         (SVGTransformable::parseTransformAttribute):
763
764 2006-09-22  Eric Seidel  <eric@eseidel.com>
765
766         No review necessary, just removing a dead file.
767
768         Remove unused file (added previously by mistake) to make room for real implementation.
769
770         * platform/mac/BitmapImageMac.mm: Removed.
771
772 2006-09-22  Dave Hyatt <hyatt@apple.com>
773
774         Move PlatformScrollBar.h down into the platforms.
775         
776         Reviewed by andersca
777
778         * platform/PlatformScrollBar.h: Removed.
779         * platform/win/PlatformScrollBar.h: Added.
780         * platform/mac/PlatformScrollBar.h: Added.
781
782 2006-09-22   Dave Hyatt  <hyatt@apple.com>
783
784         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
785         any widget subsystems that don't have any underlying native objects backing the widgets.
786
787         Reviewed by anders
788
789         * platform/Widget.h:
790         * platform/mac/WidgetMac.mm:
791         (WebCore::Widget::invalidate):
792         (WebCore::Widget::invalidateRect):
793         * platform/win/TemporaryLinkStubs.cpp:
794         (Widget::invalidate):
795         (Widget::invalidateRect):
796
797 2006-09-22  Rob Buis  <buis@kd.org>
798
799         Reviewed by eseidel.
800
801         http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
802         Merge build fixes from unity
803
804         * CMakeLists.txt:
805
806 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
807
808         Reviewed by eseidel.
809
810         http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
811         SVGDocument does not expose 'rootElement' property
812
813         Enable 'rootElement' property.
814
815         * ksvg2/svg/SVGDocument.idl:
816
817 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
818
819         Tweak includes.
820
821         * platform/ResourceLoaderInternal.h:
822
823 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
824
825         build fixed. band happy.
826         
827         * platform/cg/GraphicsContextCG.cpp:
828         (WebCore::GraphicsContext::translate):
829         * platform/mac/WidgetMac.mm:
830
831 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
832
833         Reviewed by Maciej.
834         
835         Some Widget refactoring.
836
837         * WebCore.vcproj/WebCore/WebCore.vcproj:
838         * bridge/mac/FrameMac.mm:
839         * bridge/win/FrameWin.cpp:
840         (WebCore::FrameWin::runJavaScriptAlert):
841         (WebCore::FrameWin::runJavaScriptConfirm):
842         * bridge/win/PageWin.cpp:
843         (WebCore::Page::Page):
844         (WebCore::rootWindowForFrame):
845         * html/CanvasRenderingContext2D.cpp:
846         (WebCore::CanvasRenderingContext2D::translate):
847         * page/FrameView.cpp:
848         (WebCore::FrameView::isFrameView):
849         * page/Page.h:
850         (WebCore::Page::setInstanceHandle):
851         (WebCore::Page::instanceHandle):
852         * platform/GraphicsContext.h:
853         * platform/ScrollView.h:
854         * platform/Widget.h:
855         * platform/cairo/GraphicsContextCairo.cpp:
856         (WebCore::GraphicsContext::translate):
857         (WebCore::GraphicsContext::origin):
858         * platform/mac/WidgetMac.mm:
859         (WebCore::Widget::clearFocus):
860         * platform/win/ResourceLoaderWin.cpp:
861         (WebCore::initializeOffScreenResourceLoaderWindow):
862         * platform/win/ScreenWin.cpp:
863         (WebCore::monitorInfo):
864         * platform/win/ScrollViewWin.cpp:
865         (WebCore::ScrollView::updateContents):
866         (WebCore::ScrollView::visibleWidth):
867         (WebCore::ScrollView::visibleHeight):
868         (WebCore::ScrollView::visibleContentRect):
869         (WebCore::ScrollView::viewportToContents):
870         (WebCore::ScrollView::contentsToViewport):
871         (WebCore::ScrollView::scrollBy):
872         (WebCore::ScrollView::updateScrollInfo):
873         (WebCore::ScrollView::updateScrollBars):
874         * platform/win/SharedTimerWin.cpp:
875         (WebCore::initializeOffScreenTimerWindow):
876         * platform/win/TemporaryLinkStubs.cpp:
877         (FrameView::updateBorder):
878         (ScrollView::paint):
879         (GraphicsContext::clip):
880         * platform/win/WidgetWin.cpp:
881         (WebCore::Widget::Widget):
882         (WebCore::Widget::parentWindow):
883         (WebCore::Widget::setParentWindow):
884         (WebCore::Widget::frameGeometry):
885         (WebCore::Widget::hasFocus):
886         (WebCore::Widget::setFocus):
887         (WebCore::Widget::show):
888         (WebCore::Widget::hide):
889         (WebCore::Widget::setFrameGeometry):
890
891 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
892
893         Reviewed by Tim H.
894
895         * platform/TextEncoding.cpp:
896         (WebCore::TextEncoding::backslashAsCurrencySymbol):
897         Add comment clarifying why backslashAsCurrencySymbol is needed.
898
899 2006-09-21  Sean Gies  <seangies@apple.com>
900
901         Reviewed by Adam Roben.
902
903         Add utility functions to get and release HDC from GraphicsContext.
904
905         * platform/GraphicsContext.h: Add utilities to get and release HDC.
906         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
907         * rendering/RenderThemeWin.cpp: Switch to new utilities.
908
909 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
910
911         Reviewed by anders
912         
913         <rdar://problem/4426622>
914         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
915
916         * editing/htmlediting.cpp:
917         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
918         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
919         Got rid of uses of DepricatedString.
920
921 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
922
923         Reviewed by eseidel.
924
925         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
926
927         * page/Frame.cpp:
928         (WebCore::Frame::endIfNotLoading):
929
930 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
931
932         Reviewed by eseidel.
933
934         Fix Qt/Linux build.
935
936         * CMakeLists.txt:
937         * kcanvas/device/qt/KCanvasClipperQt.h:
938         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
939         * platform/qt/FrameQt.cpp:
940         (WebCore::FrameQt::isLoadTypeReload):
941         (WebCore::FrameQt::originalRequestURL):
942         * platform/qt/FrameQt.h:
943         * platform/qt/GraphicsContextQt.cpp:
944         (WebCore::GraphicsContext::concatCTM):
945         * platform/qt/ScrollViewQt.cpp:
946         (WebCore::ScrollView::wheelEvent):
947         * platform/qt/TemporaryLinkStubs.cpp:
948         (WebCore::IconDatabase::setIconURLForPageURL):
949
950 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
951
952         Reviewed by john
953         
954         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
955         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
956
957         * editing/MoveSelectionCommand.cpp:
958         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
959         to the position-to-move-to's document, not the fragment's document.  The 
960         fragment's document is the document used to create the fragment and is irrelavant.
961
962 === Safari-521.27 ===
963
964 2006-09-21  Brady Eidson  <beidson@apple.com>
965
966         Reviewed by Anders
967
968         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
969         This fixes Spinneret so it won't crash on its first load!
970
971         * page/Frame.cpp:
972         (WebCore::Frame::endIfNotLoading):
973
974 2006-09-21  Brady Eidson  <beidson@apple.com>
975
976         Build fix
977
978         * platform/win/TemporaryLinkStubs.cpp:
979         (ScrollView::wheelEvent):
980
981 2006-09-20  Rob Buis  <buis@kde.org>
982
983         Reviewed by eseidel.
984
985         http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
986         new marker code draws end-marker in wrong place
987
988         Keep track of the start of the subpath so we can handle
989         closeTo/moveTo correctly.
990
991         * kcanvas/RenderPath.cpp:
992         (WebCore::DrawMarkersData::DrawMarkersData):
993         (WebCore::updateMarkerDataForElement):
994
995 2006-09-21  David Hyatt <hyatt@apple.com>
996
997         Wheel scrolling prep for Win32.
998
999         WARNING: NO TEST CASES ADDED OR CHANGED
1000
1001         * platform/PlatformWheelEvent.h:
1002         * platform/ScrollBar.h:
1003         * platform/ScrollView.h:
1004         * platform/mac/ScrollViewMac.mm:
1005         (WebCore::ScrollView::wheelEvent):
1006         * rendering/RenderLayer.cpp:
1007
1008 2006-09-20  Timothy Hatcher  <timothy@apple.com>
1009
1010         Reviewed by Hyatt.
1011
1012         Bug 10917: REGRESSION (r16027): iFrame transparency broken
1013         http://bugzilla.opendarwin.org/show_bug.cgi?id=10917
1014
1015         Don't paint the base background color if we transparent.
1016
1017         * rendering/RenderBox.cpp:
1018         (WebCore::RenderBox::paintBackgroundExtended):
1019
1020 2006-09-20  Adam Roben  <aroben@apple.com>
1021
1022         Reviewed by andersca.
1023
1024         * platform/FileChooser.h: Remove no-longer-necessary namespace std
1025
1026 2006-09-20  Eric Seidel  <eric@eseidel.com>
1027
1028         Reviewed by beth.
1029
1030         Cleanup style in KCanvas.
1031         Remove extra white-space, unneeded arguments, etc.
1032
1033         * WebCore.xcodeproj/project.pbxproj:
1034         * kcanvas/KCanvasClipper.cpp:
1035         (WebCore::operator<<):
1036         (WebCore::KCanvasClipper::externalRepresentation):
1037         * kcanvas/KCanvasClipper.h:
1038         * kcanvas/KCanvasFilters.cpp:
1039         (WebCore::KCanvasFilter::externalRepresentation):
1040         (WebCore::operator<<):
1041         (WebCore::KCanvasFilterEffect::externalRepresentation):
1042         (WebCore::KCPointLightSource::externalRepresentation):
1043         (WebCore::KCSpotLightSource::externalRepresentation):
1044         (WebCore::KCDistantLightSource::externalRepresentation):
1045         (WebCore::KCanvasFEBlend::externalRepresentation):
1046         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
1047         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
1048         (WebCore::KCanvasFEComposite::externalRepresentation):
1049         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
1050         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
1051         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
1052         (WebCore::KCanvasFEFlood::externalRepresentation):
1053         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
1054         (WebCore::KCanvasFEImage::externalRepresentation):
1055         (WebCore::KCanvasFEMerge::externalRepresentation):
1056         (WebCore::KCanvasFEMorphology::externalRepresentation):
1057         (WebCore::KCanvasFEOffset::externalRepresentation):
1058         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
1059         (WebCore::KCanvasFETile::externalRepresentation):
1060         (WebCore::KCanvasFETurbulence::externalRepresentation):
1061         * kcanvas/KCanvasFilters.h:
1062         (WebCore::KCanvasFEDiffuseLighting::lightSource):
1063         (WebCore::KCanvasFESpecularLighting::lightSource):
1064         * kcanvas/KCanvasImage.h:
1065         * kcanvas/KCanvasMarker.cpp:
1066         (WebCore::KCanvasMarker::externalRepresentation):
1067         * kcanvas/KCanvasMarker.h:
1068         * kcanvas/KCanvasResource.cpp:
1069         (WebCore::operator<<):
1070         * kcanvas/KCanvasResource.h:
1071         * kcanvas/KCanvasTreeDebug.cpp:
1072         (WebCore::operator<<):
1073         (WebCore::writeIndent):
1074         (WebCore::writeStyle):
1075         (WebCore::write):
1076         (WebCore::writeRenderResources):
1077         * kcanvas/KCanvasTreeDebug.h:
1078         (WebCore::operator<<):
1079         * kcanvas/RenderForeignObject.cpp:
1080         (WebCore::RenderForeignObject::paint):
1081         * kcanvas/RenderPath.cpp:
1082         (WebCore::RenderPath::paint):
1083         (WebCore::drawStartAndMidMarkers):
1084         * kcanvas/RenderSVGContainer.cpp:
1085         (WebCore::RenderSVGContainer::paint):
1086         * kcanvas/RenderSVGImage.cpp:
1087         (WebCore::RenderSVGImage::translateForAttributes):
1088         * kcanvas/RenderSVGImage.h:
1089         * kcanvas/device/KRenderingDevice.cpp:
1090         (WebCore::KRenderingDevice::currentContext):
1091         (WebCore::KRenderingDevice::popContext):
1092         (WebCore::KRenderingDevice::pushContext):
1093         * kcanvas/device/KRenderingDevice.h:
1094         * kcanvas/device/KRenderingFillPainter.h:
1095         * kcanvas/device/KRenderingPaintServer.h:
1096         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1097         (WebCore::KRenderingPaintServer::activeClient):
1098         (WebCore::KRenderingPaintServer::setActiveClient):
1099         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1100         (WebCore::operator<<):
1101         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
1102         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
1103         (WebCore::KRenderingPaintServerGradient::listener):
1104         (WebCore::KRenderingPaintServerGradient::setListener):
1105         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
1106         * kcanvas/device/KRenderingPaintServerGradient.h:
1107         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1108         (WebCore::KRenderingPaintServerPattern::tile):
1109         (WebCore::KRenderingPaintServerPattern::setTile):
1110         (WebCore::KRenderingPaintServerPattern::listener):
1111         (WebCore::KRenderingPaintServerPattern::setListener):
1112         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
1113         * kcanvas/device/KRenderingPaintServerPattern.h:
1114         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1115         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
1116         * kcanvas/device/KRenderingPaintServerSolid.h:
1117         * kcanvas/device/KRenderingStrokePainter.cpp:
1118         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
1119         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
1120         * kcanvas/device/KRenderingStrokePainter.h:
1121         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1122         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1123         (WebCore::KCanvasFilterQuartz::prepareFilter):
1124         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
1125         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1126         (WebCore::KCanvasMaskerQuartz::applyMask):
1127         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1128         (WebCore::KCanvasImageQuartz::init):
1129         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1130         (WebCore::KCanvasClipperQuartz::applyClip):
1131         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1132         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1133         (WebCore::KRenderingDeviceQuartz::quartzContext):
1134         (WebCore::KRenderingDeviceQuartz::contextForImage):
1135         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1136         (WebCore::KRenderingDeviceQuartz::createResource):
1137         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
1138         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1139         (WebCore::CGShadingRefForLinearGradient):
1140         (WebCore::CGShadingRefForRadialGradient):
1141         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1142         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1143         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1144         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1145         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
1146         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
1147         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
1148         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
1149         (WebCore::KRenderingPaintServerSolidQuartz::draw):
1150         (WebCore::KRenderingPaintServerSolidQuartz::setup):
1151         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
1152         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1153         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
1154         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
1155         * kcanvas/device/quartz/QuartzSupport.h:
1156         * kcanvas/device/quartz/QuartzSupport.mm:
1157         (WebCore::applyStrokeStyleToContext):
1158
1159 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1160
1161         Reviewed by Dave Hyatt.
1162
1163         * dom/WheelEvent.cpp:
1164         (WebCore::WheelEvent::WheelEvent):
1165         Use lroundf instead of lround since deltas are floats.
1166
1167 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
1168
1169         Reviewed by eseidel.  Landed by eseidel.
1170
1171         Test: svg/custom/pattern-y-offset.svg
1172
1173         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1174         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1175
1176 2006-09-20  David Hyatt  <hyatt@apple.com>
1177
1178         Add a new wheelEvent method to ScrollView.  Platforms that wish
1179         to handle the wheel event for the scroll view themselves can then
1180         do so there.  (Mac lets the underlying NSScrollView do it for now.)
1181
1182         * page/FrameView.cpp:
1183         (WebCore::FrameView::handleWheelEvent):
1184         * platform/ScrollView.h:
1185         (WebCore::ScrollView::wheelEvent):
1186
1187 2006-09-20  Brady Eidson  <beidson@apple.com>
1188
1189         Reviewed by Tim Omernick
1190
1191         Part of fixing a crash Tim O showed me that I missed in a release build.
1192         WebKit should be able to call through the bridge to WebCore no matter what -
1193         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
1194
1195         * bridge/mac/WebCoreIconDatabaseBridge.h:
1196         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1197         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
1198         (-[WebCoreIconDatabaseBridge isOpen]):
1199         (-[WebCoreIconDatabaseBridge removeAllIcons]):
1200         (-[WebCoreIconDatabaseBridge _isEmpty]):
1201         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
1202         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
1203         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
1204         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
1205         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
1206         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
1207         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
1208         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
1209         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
1210         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
1211         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
1212         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
1213         (-[WebCoreIconDatabaseBridge _setEnabled:]):
1214         (-[WebCoreIconDatabaseBridge _isEnabled]):
1215
1216 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
1217
1218         Reviewed by Darin.
1219
1220         Add String::split which returns a Vector of Strings and use it instead of 
1221         DeprecatedStringList.
1222         
1223         * bindings/js/kjs_events.cpp:
1224         (KJS::Clipboard::getValueProperty):
1225         * bindings/js/kjs_window.cpp:
1226         (KJS::parseModalDialogFeatures):
1227         * css/MediaList.cpp:
1228         (WebCore::MediaList::setMediaText):
1229         * dom/Clipboard.h:
1230         * html/HTMLFormElement.cpp:
1231         (WebCore::HTMLFormElement::formData):
1232         * html/HTMLLinkElement.cpp:
1233         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
1234         * platform/PlatformString.h:
1235         * platform/String.cpp:
1236         (WebCore::String::split):
1237         * platform/StringImpl.cpp:
1238         * platform/StringImpl.h:
1239         * platform/mac/ClipboardMac.h:
1240         * platform/mac/ClipboardMac.mm:
1241         (WebCore::ClipboardMac::types):
1242
1243 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
1244
1245         Reviewed by harrison
1246
1247         * css/cssstyleselector.cpp:
1248         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
1249         HTMLElement::isContentEditable just to check the Frame's editability, since
1250         it calls updateRenderering, which can get us into infinite recursion.
1251
1252 2006-09-20  Brady Eidson  <beidson@apple.com>
1253
1254         Reviewed by Darin
1255
1256         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
1257
1258         * loader/icon/IconDatabase.cpp:
1259         (WebCore::IconDatabase::IconDatabase): Disabled by default
1260         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
1261         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
1262         (WebCore::IconDatabase::iconForPageURL): Ditto
1263         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
1264         (WebCore::IconDatabase::iconURLForPageURL): Ditto
1265         (WebCore::IconDatabase::retainIconForPageURL): Ditto
1266         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1267         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
1268         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
1269         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
1270         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
1271
1272 2006-09-20  Adam Roben  <aroben@apple.com>
1273
1274         Reviewed by Adele.
1275
1276         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
1277         REGRESSION: file upload control with direction:rtl or text-align:right
1278         draws button on top of filename/icon
1279
1280         * rendering/RenderFileUploadControl.cpp:
1281         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
1282         match direction
1283         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
1284         the filename and icon in RTL
1285
1286 2006-09-20  Alice Liu  <alice.liu@apple.com>
1287
1288         Reviewed by Adam Roben.
1289
1290         fixed windows build
1291
1292         * dom/WheelEvent.cpp:
1293         (WebCore::WheelEvent::WheelEvent):
1294         changed lrint to lround
1295
1296 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
1297
1298         Build Fix.  Adds isHorizontal attribute back to WheelEvent
1299         for the Objective-C bindings.  If it is found that isHorizontal
1300         is not used, we should remove it again but also remove it's
1301         declaration from PublicDOMInterfaces.h
1302
1303         * dom/WheelEvent.h:
1304         (WebCore::WheelEvent::isHorizontal):
1305         * dom/WheelEvent.idl:
1306
1307 2006-09-20  David Hyatt  <hyatt@apple.com>
1308
1309         Fix for 10945, WheelEvent should support two dimensions at once, since
1310         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
1311         to allow for diagonal scrolling.
1312
1313         Reviewed by Eric
1314
1315         * dom/EventTargetNode.cpp:
1316         (WebCore::EventTargetNode::dispatchWheelEvent):
1317         * dom/WheelEvent.cpp:
1318         (WebCore::WheelEvent::WheelEvent):
1319         (WebCore::WheelEvent::initWheelEvent):
1320         * dom/WheelEvent.h:
1321         (WebCore::WheelEvent::wheelDelta):
1322         (WebCore::WheelEvent::wheelDeltaX):
1323         (WebCore::WheelEvent::wheelDeltaY):
1324         * dom/WheelEvent.idl:
1325         * page/FrameView.cpp:
1326         (WebCore::FrameView::handleWheelEvent):
1327         * platform/PlatformWheelEvent.h:
1328         (WebCore::PlatformWheelEvent::deltaX):
1329         (WebCore::PlatformWheelEvent::deltaY):
1330         (WebCore::PlatformWheelEvent::normalize):
1331         * platform/mac/WheelEventMac.mm:
1332         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1333
1334 2006-09-19  Eric Seidel  <eric@eseidel.com>
1335
1336         Reviewed by hyatt.
1337
1338         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
1339         
1340         No tests were harmed in the making of this patch.
1341
1342         * WebCore.xcodeproj/project.pbxproj:
1343         * kcanvas/KCanvasClipper.cpp: Added.
1344         (WebCore::operator<<):
1345         * kcanvas/KCanvasClipper.h: Added.
1346         * kcanvas/KCanvasFilters.h:
1347         * kcanvas/KCanvasImage.h:
1348         * kcanvas/KCanvasMarker.cpp: Added.
1349         * kcanvas/KCanvasMarker.h: Added.
1350         * kcanvas/KCanvasMasker.cpp: Added.
1351         (WebCore::KCanvasMasker::KCanvasMasker):
1352         (WebCore::KCanvasMasker::setMask):
1353         (WebCore::KCanvasMasker::externalRepresentation):
1354         (WebCore::getMaskerById):
1355         * kcanvas/KCanvasMasker.h: Added.
1356         * kcanvas/KCanvasResource.cpp: Added.
1357         (WebCore::KCanvasResource::invalidate):
1358         (WebCore::KCanvasResource::externalRepresentation):
1359         (WebCore::getResourceById):
1360         (WebCore::getPaintServerById):
1361         * kcanvas/KCanvasResource.h: Added.
1362         * kcanvas/KCanvasResources.cpp: Removed.
1363         * kcanvas/KCanvasResources.h: Removed.
1364         * kcanvas/RenderPath.cpp:
1365         * kcanvas/RenderSVGContainer.cpp:
1366         * kcanvas/RenderSVGImage.cpp:
1367         * kcanvas/RenderSVGText.cpp:
1368         * kcanvas/device/KRenderingPaintServer.h:
1369         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1370         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1371         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1372         * ksvg2/svg/SVGClipPathElement.h:
1373         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1374         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1375         * ksvg2/svg/SVGFECompositeElement.cpp:
1376         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1377         * ksvg2/svg/SVGFELightElement.cpp:
1378         * ksvg2/svg/SVGFEOffsetElement.cpp:
1379         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1380         * ksvg2/svg/SVGFilterElement.cpp:
1381         * ksvg2/svg/SVGLinearGradientElement.cpp:
1382         * ksvg2/svg/SVGMarkerElement.h:
1383         * ksvg2/svg/SVGMaskElement.h:
1384
1385 2006-09-19  Brady Eidson <beidson@apple.com>
1386
1387         Reviewed by Sarge Decker
1388
1389         <rdar://problem/4739892> and <rdar://problem/4729797>
1390         - WebCore::IconDatabase needs to have and respect an enabled() flag
1391         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
1392
1393         * bridge/mac/WebCoreIconDatabaseBridge.h:
1394         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1395         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
1396         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
1397         * loader/icon/IconDatabase.cpp:
1398         (WebCore::IconDatabase::IconDatabase):
1399         (WebCore::IconDatabase::open): Don't open if disabled
1400         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
1401         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
1402         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
1403         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
1404         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
1405         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
1406         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
1407         (WebCore::IconDatabase::releaseIconURL):
1408         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
1409         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
1410         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
1411         (WebCore::IconDatabase::setEnabled): Added
1412         * loader/icon/IconDatabase.h:
1413         (WebCore::IconDatabase::enabled): Added
1414         * page/Frame.cpp:
1415         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
1416         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
1417
1418 2006-09-20  David Hyatt  <hyatt@apple.com>
1419
1420         Massage mouse wheel handling so that it is more cross-platform.  Make
1421         all the work happen in handleWheelEvent on the FrameView.
1422
1423         Reviewed by bradee-oh
1424
1425         * bridge/mac/FrameMac.mm:
1426         (WebCore::FrameMac::wheelEvent):
1427         * page/FrameView.cpp:
1428         (WebCore::FrameView::handleWheelEvent):
1429         * platform/PlatformWheelEvent.h:
1430         (WebCore::PlatformWheelEvent::platformDelta):
1431         (WebCore::PlatformWheelEvent::delta):
1432         * platform/mac/WheelEventMac.mm:
1433         (WebCore::platformDeltaForEvent):
1434         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1435         * rendering/RenderLayer.cpp:
1436         (WebCore::RenderLayer::scroll):
1437         * rendering/RenderObject.cpp:
1438         (WebCore::RenderObject::scroll):
1439
1440 2006-09-19  Eric Seidel  <eric@eseidel.com>
1441
1442         Reviewed by adele.
1443
1444         Improve test output for filters with bounding-box relative sizes.
1445         http://bugzilla.opendarwin.org/show_bug.cgi?id=8585
1446
1447         Many test results updated.
1448
1449         * kcanvas/KCanvasFilters.cpp:
1450         (WebCore::KCanvasFilter::externalRepresentation):
1451
1452 2006-09-19  Eric Seidel  <eric@eseidel.com>
1453
1454         Reviewed by adele.
1455         
1456         Markers should clip to their viewport.
1457         http://bugzilla.opendarwin.org/show_bug.cgi?id=5967
1458
1459         Test: svg/custom/marker-overflow-clip.svg
1460
1461         * kcanvas/KCanvasResources.cpp:
1462         (WebCore::KCanvasMarker::KCanvasMarker):
1463         (WebCore::KCanvasMarker::setMarker):
1464         (WebCore::KCanvasMarker::draw):
1465         * kcanvas/KCanvasResources.h:
1466         (WebCore::KCanvasMasker::mask):
1467         * ksvg2/svg/SVGMarkerElement.cpp:
1468         (WebCore::SVGMarkerElement::SVGMarkerElement):
1469         (WebCore::SVGMarkerElement::parseMappedAttribute):
1470         (WebCore::SVGMarkerElement::canvasResource):
1471         (WebCore::SVGMarkerElement::createRenderer):
1472
1473 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1474
1475         Reviewed by eseidel
1476
1477         Backing out my recent change.
1478
1479         * css/cssstyleselector.cpp:
1480         (WebCore::CSSStyleSelector::adjustRenderStyle): 
1481
1482 2006-09-19  Brady Eidson  <beidson@apple.com>
1483
1484         Reviewed by Kevin McCullough
1485
1486         http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
1487         Opening a PDF in a new tab/window creates a documentless-frame
1488         and we deref the document without checking its validity
1489
1490         * page/Frame.cpp:
1491         (WebCore::Frame::iconURL):
1492
1493 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1494
1495         Reviewed by harrison
1496         
1497         <rdar://problem/4735272>
1498         Can not click into link in programmatically editable content
1499
1500         * css/cssstyleselector.cpp:
1501         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
1502         userModify to implement document wide editability.
1503
1504 2006-09-19  MorganL  <morlmor@yahoo.com>
1505
1506         Reviewed by Darin and landed by Brady
1507
1508         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
1509         Build broken when SVG is not enabled.
1510
1511         * dom/XMLTokenizer.cpp:
1512         (WebCore::XMLTokenizer::startElementNs):
1513
1514 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
1515
1516         Reviewed by harrison
1517         
1518         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
1519
1520         Pasting plain text results in a match style paste, and the insertion
1521         position is whitespace normal, which clobbers the whitespace:pre on 
1522         tab spans.  Skip changes to the whitespace mode when computing a style
1523         change for tab spans or the text nodes inside tab spans.
1524
1525         * editing/ApplyStyleCommand.cpp:
1526         (WebCore::StyleChange::init): Don't change the whitespace mode inside
1527         tab spans.
1528
1529 2006-09-19  David Hyatt  <hyatt@apple.com>
1530
1531         Fix for bug 5298, shape=default not supported for image maps.  Implement
1532         support for it.
1533
1534         Reviewed by timo
1535
1536         * html/HTMLAreaElement.cpp:
1537         (WebCore::HTMLAreaElement::getRegion):
1538         * html/HTMLMapElement.cpp:
1539         (WebCore::HTMLMapElement::mapMouseEvent):
1540
1541 2006-09-19  Adam Roben  <aroben@apple.com>
1542
1543         Reviewed by Adele.
1544
1545         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
1546         "no file selected" placeholder text missing from file upload control
1547
1548         * WebCore.xcodeproj/project.pbxproj:
1549         * rendering/RenderFileUploadControl.cpp: Remove class
1550         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
1551         defaultWidthNumChars
1552         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
1553         RenderBlock constructor instead of RenderFlexibleBox, 
1554         (WebCore::RenderFileUploadControl::setStyle): Remove references to
1555         m_fileBox.
1556         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
1557         instead of updateIconAndFileName() (which has been removed)
1558         (WebCore::RenderFileUploadControl::updateFromElement): Remove
1559         references to m_fileBox, don't call updateIconAndFilename()
1560         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
1561         without using m_fileBox
1562         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
1563         now-unnecessary display:box rule.
1564         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
1565         to paintingDisabled() now that Icon::paint() does it, and add code to
1566         paint the filename directly.
1567         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
1568         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
1569         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
1570         subclass of RenderBlock instead of RenderFlexibleBox, remove
1571         updateIconAndFilename() method, remove m_fileBox instance variable.
1572
1573 2006-09-19  Eric Seidel  <eric@eseidel.com>
1574
1575         Reviewed by hyatt.
1576
1577         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
1578         http://bugzilla.opendarwin.org/show_bug.cgi?id=10846
1579         
1580         No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.
1581
1582         * dom/XMLTokenizer.cpp:
1583         (WebCore::XMLTokenizer::XMLTokenizer):
1584         (WebCore::XMLTokenizer::startElementNs):
1585         (WebCore::XMLTokenizer::endElementNs):
1586
1587 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
1588
1589         Reviewed by eseidel.  Landed by eseidel.
1590         
1591         Build fix only, no tests affected.
1592
1593         * platform/gdk/FontPlatformDataGdk.cpp:
1594         (WebCore::FontPlatformData::FontPlatformData):
1595         (WebCore::FontPlatformData::~FontPlatformData):
1596         * platform/gdk/FrameGdk.h:
1597         * platform/gdk/TemporaryLinkStubs.cpp:
1598         (FrameGdk::isLoadTypeReload):
1599         (FrameGdk::originalRequestURL):
1600         (IconDatabase::setIconURLForPageURL):
1601
1602 2006-09-19  David Hyatt  <hyatt@apple.com>
1603
1604         Refine the fix for 9805 to really get all the complex cases right.
1605
1606         Reviewed by Eric
1607
1608         * rendering/RenderBlock.cpp:
1609         (WebCore::RenderBlock::clearFloatsIfNeeded):
1610         (WebCore::RenderBlock::handleBottomOfBlock):
1611
1612 2006-09-18  David Hyatt  <hyatt@apple.com>
1613
1614         Fix for 9805, <hr> not positioned properly following a previous empty sibling
1615         that had clear:both set on it.  Update self-collapsing block clearance
1616         behavior to match what is specified in the latest draft of CSS2.1.
1617
1618         Reviewed by Eric
1619
1620         Added fast/block/margin-collapse/empty-clear-blocks.html
1621
1622         * rendering/RenderBlock.cpp:
1623         (WebCore::RenderBlock::clearFloatsIfNeeded):
1624         (WebCore::RenderBlock::handleBottomOfBlock):
1625
1626 2006-09-18  MorganL  <morlmor@yahoo.com>
1627
1628         Reviewed by Brady, landed by Brady
1629
1630         Send receivedResponse callback to ResourceLoaderClient when loading
1631         file URLs.
1632
1633         See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
1634
1635         * platform/win/ResourceLoaderWin.cpp:
1636         (WebCore::ResourceLoader::fileLoadTimer):
1637
1638 2006-09-18  Brady Eidson  <beidson@apple.com>
1639
1640         Reviewed by Anders
1641
1642         <rdar://problem/3028061> - WebKit never updates favicon
1643         The WebKit enforced expiration date for icons has worked for some time, but the
1644         move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
1645         functionality.  This patch fixes that up, along with some other architectural improvements,
1646         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
1647
1648         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
1649         * bridge/mac/FrameMac.mm:
1650         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
1651         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
1652         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
1653         * dom/Document.h: Added m_iconURL
1654         (WebCore::Document::iconURL): Added
1655         (WebCore::Document::setIconURL): Ditto
1656         * html/HTMLLinkElement.cpp:
1657         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
1658         * page/Frame.cpp:
1659         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
1660         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
1661         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
1662         * page/FramePrivate.h: Nuked IconURL
1663         * platform/win/TemporaryLinkStubs.cpp:
1664         (FrameWin::isLoadTypeReload):
1665
1666 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1667
1668         Reviewed by Tim H.
1669
1670         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
1671           it is it turns out that AppKit uses it.
1672
1673         * bindings/objc/DOMPrivate.h:
1674         * bindings/objc/DOMRGBColor.mm:
1675         (-[DOMRGBColor _color]):
1676
1677 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
1678
1679         Reviewed by Tim H.
1680
1681         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
1682         Yet Another Objective-C Bindings Patch
1683
1684         - Whitespace cleanup for IDLParser.pm
1685
1686         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
1687           and DOMAbstractView into their own files.
1688
1689         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
1690           it is not used and a public method is available now.
1691
1692         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
1693           as it not used.
1694
1695         - Auto-generate method isContentEditable for DOMNode.
1696
1697         - General cleanup of bindings code including removing unneeded #imports
1698           and whitespace cleanup
1699
1700         * WebCore.xcodeproj/project.pbxproj:
1701         * bindings/objc/DOM.mm:
1702         (addElementClass):
1703         (elementClass):
1704         (-[DOMNode _initWithNode:WebCore::]):
1705         (+[DOMNode _nodeWith:WebCore::]):
1706         (-[DOMNode WebCore::]):
1707         (-[DOMNode KJS::Bindings::]):
1708         (-[DOMNode addEventListener:::]):
1709         (-[DOMNode removeEventListener:::]):
1710         (-[DOMNode dispatchEvent:]):
1711         (-[DOMElement image]):
1712         (-[DOMElement _font]):
1713         (-[DOMElement _imageTIFFRepresentation]):
1714         (-[DOMElement _getURLAttribute:]):
1715         (-[DOMElement _NPObject]):
1716         (-[DOMElement isFocused]):
1717         (-[DOMRange dealloc]):
1718         (-[DOMRange finalize]):
1719         (-[DOMRange description]):
1720         (-[DOMRange startContainer]):
1721         (-[DOMRange startOffset]):
1722         (-[DOMRange endContainer]):
1723         (-[DOMRange endOffset]):
1724         (-[DOMRange collapsed]):
1725         (-[DOMRange commonAncestorContainer]):
1726         (-[DOMRange setStart::]):
1727         (-[DOMRange setEnd::]):
1728         (-[DOMRange setStartBefore:]):
1729         (-[DOMRange setStartAfter:]):
1730         (-[DOMRange setEndBefore:]):
1731         (-[DOMRange setEndAfter:]):
1732         (-[DOMRange collapse:]):
1733         (-[DOMRange selectNode:]):
1734         (-[DOMRange selectNodeContents:]):
1735         (-[DOMRange compareBoundaryPoints::]):
1736         (-[DOMRange deleteContents]):
1737         (-[DOMRange extractContents]):
1738         (-[DOMRange cloneContents]):
1739         (-[DOMRange insertNode:]):
1740         (-[DOMRange surroundContents:]):
1741         (-[DOMRange cloneRange]):
1742         (-[DOMRange toString]):
1743         (-[DOMRange detach]):
1744         (-[DOMRange _initWithRange:WebCore::]):
1745         (+[DOMRange _rangeWith:WebCore::]):
1746         (-[DOMRange WebCore::]):
1747         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1748         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1749         (-[DOMNodeFilter WebCore::]):
1750         (-[DOMNodeFilter dealloc]):
1751         (-[DOMNodeFilter finalize]):
1752         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1753         (-[DOMNodeIterator WebCore::]):
1754         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
1755         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1756         (-[DOMTreeWalker WebCore::]):
1757         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
1758         (ObjCNodeFilterCondition::acceptNode):
1759         (-[DOMDocument createNodeIterator::::]):
1760         (-[DOMDocument createTreeWalker::::]):
1761         (ObjCEventListener::find):
1762         (ObjCEventListener::create):
1763         (ObjCEventListener::handleEvent):
1764         * bindings/objc/DOMAbstractView.h: Added.
1765         * bindings/objc/DOMAbstractView.mm: Added.
1766         (-[DOMAbstractView document]):
1767         (-[DOMAbstractView WebCore::]):
1768         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1769         (+[DOMAbstractView _abstractViewWith:WebCore::]):
1770         * bindings/objc/DOMCSS.mm:
1771         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1772         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1773         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
1774         (-[DOMCSSRule _initWithRule:WebCore::]):
1775         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1776         (-[DOMCSSValue _initWithValue:WebCore::]):
1777         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1778         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
1779         (-[DOMDocument getComputedStyle::]):
1780         (-[DOMDocument getMatchedCSSRules::]):
1781         * bindings/objc/DOMCore.h:
1782         * bindings/objc/DOMEventException.h: Added.
1783         * bindings/objc/DOMEvents.h:
1784         * bindings/objc/DOMEvents.mm:
1785         * bindings/objc/DOMException.h: Added.
1786         * bindings/objc/DOMHTML.mm:
1787         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
1788         (viewForElement):
1789         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1790         (-[DOMHTMLInputElement _selectedRange]):
1791         (-[DOMHTMLInputElement _setAutofilled:]):
1792         * bindings/objc/DOMInternal.h:
1793         * bindings/objc/DOMObject.h:
1794         * bindings/objc/DOMPrivate.h:
1795         * bindings/objc/DOMRange.h:
1796         * bindings/objc/DOMRangeException.h: Added.
1797         * bindings/objc/DOMViews.h:
1798         * bindings/objc/DOMViews.mm: Removed.
1799         * bindings/objc/DOMXPath.h:
1800         * bindings/objc/DOMXPathException.h: Added.
1801         * bindings/scripts/IDLParser.pm:
1802         * dom/Node.idl:
1803
1804 2006-09-18  Brady Eidson  <beidson@apple.com>
1805
1806         Windows build fix
1807
1808         * platform/win/TemporaryLinkStubs.cpp:
1809         (IconDatabase::setIconURLForPageURL):
1810
1811 2006-09-18  David Hyatt  <hyatt@apple.com>
1812
1813         Fix for bug 3969, hr width doesn't update when it clears a float.  This
1814         was also a problem with tables and overflow sections.
1815
1816         Reviewed by Eric
1817
1818         Added fast/block/float/width-update-after-clear.html
1819
1820         * rendering/RenderBlock.cpp:
1821         (WebCore::RenderBlock::collapseMargins):
1822         (WebCore::RenderBlock::clearFloatsIfNeeded):
1823
1824 2006-09-18  Brady Eidson  <beidson@apple.com>
1825
1826         Reviewed by John
1827
1828         http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
1829         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
1830
1831         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
1832         * bridge/win/FrameWin.h: Added originalRequestURL()
1833         * loader/icon/IconLoader.cpp:
1834         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
1835         * page/Frame.cpp:
1836         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
1837         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
1838         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
1839         * page/Frame.h: Added pure virtual originalRequestURL()
1840         * platform/win/TemporaryLinkStubs.cpp:
1841         (FrameWin::originalRequestURL): Added
1842
1843 2006-09-18  Rob Buis  <buis@kde.org>
1844
1845         Reviewed by Maciej.
1846
1847         http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
1848         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
1849
1850         Make sure the paint method is not exited without popping
1851         context and transparency layer.
1852
1853         WARNING: NO TEST CASES ADDED OR CHANGED
1854
1855         * kcanvas/RenderSVGImage.cpp:
1856         (WebCore::RenderSVGImage::paint):
1857
1858 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
1859
1860         Reviewed by Eric.
1861         
1862         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
1863         REGRESSION: WebKit can't be built with SVG disabled
1864         
1865         * bindings/scripts/CodeGeneratorObjC.pm:
1866         For each file generated add a #ifdef <something>_SUPPORT / #endif
1867         pair if the idl file has a Conditional extended attribute
1868
1869 2006-09-17  Eric Seidel  <eric@eseidel.com>
1870
1871         Reviewed by ap.
1872         
1873         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
1874         http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
1875
1876         * bridge/mac/WebCoreFrameBridge.mm:
1877         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
1878
1879 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
1880
1881         Reviewed by Hyatt.
1882
1883         http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
1884         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
1885
1886         No test possible.
1887
1888         * platform/Image.cpp:
1889         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
1890         maybe the rest just hasn't been loaded yet.
1891         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
1892         to start animating before we get at least two frames.
1893
1894 2006-09-17  Brady Eidson <beidson@apple.com>
1895
1896         Reviewed by Sarge
1897
1898         IconLoader now gracefully handles the condition where there's no document in the frame
1899         (ie. PDFs)
1900
1901         * loader/icon/IconLoader.cpp:
1902         (IconLoader::startLoading):
1903
1904 2006-09-17  David Hyatt  <hyatt@apple.com>
1905
1906         Fix for bug 10899, rework how CSS keywords work to be smarter about
1907         using the correct size when generic families change (e.g., monospace to
1908         serif and vice versa).
1909
1910         Reviewed by aroben
1911
1912         Added fast/text/basic/generic-family-changes.html
1913
1914         * css/cssstyleselector.cpp:
1915         (WebCore::CSSStyleSelector::applyProperty):
1916         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
1917         (WebCore::CSSStyleSelector::fontSizeForKeyword):
1918         * css/cssstyleselector.h:
1919         * dom/Document.cpp:
1920         (WebCore::Document::recalcStyle):
1921         * platform/FontDescription.h:
1922         (WebCore::FontDescription::FontDescription):
1923         (WebCore::FontDescription::keywordSize):
1924         (WebCore::FontDescription::setKeywordSize):
1925         (WebCore::FontDescription::operator==):
1926
1927 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
1928
1929         Reviewed by Brady.
1930
1931         http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
1932         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
1933
1934         Test: http/tests/xmlhttprequest/xhr-onunload.html
1935
1936         * xml/xmlhttprequest.cpp:
1937         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
1938
1939         * loader/icon/IconLoader.cpp:
1940         (IconLoader::startLoading): Fix a similar latent bug here.
1941
1942 2006-09-17  Adam Roben  <aroben@apple.com>
1943
1944         Build fix.
1945
1946         * loader/icon/IconDatabase.cpp:
1947
1948 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
1949
1950         Reviewed by Brady.
1951
1952         Add simplifyWhiteSpace and stripWhiteSpace to the String class. 
1953         Change the XSLT Parameter Map to use Strings instead of StringImpls.
1954         General cleanup.
1955
1956         * bindings/js/JSXSLTProcessor.cpp:
1957         (KJS::XSLTProcessorProtoFunc::callAsFunction):
1958         * bindings/js/kjs_events.cpp:
1959         (KJS::JSAbstractEventListener::handleEvent):
1960         * bindings/js/kjs_window.cpp:
1961         (KJS::ScheduledAction::execute):
1962         * css/MediaList.cpp:
1963         (WebCore::MediaList::setMediaText):
1964         * dom/Document.cpp:
1965         (WebCore::Document::processHttpEquiv):
1966         * editing/ApplyStyleCommand.cpp:
1967         (WebCore::StyleChange::init):
1968         * html/HTMLDocument.cpp:
1969         (WebCore::parseDocTypeDeclaration):
1970         * html/HTMLLinkElement.cpp:
1971         (WebCore::HTMLLinkElement::parseMappedAttribute):
1972         * html/HTMLObjectElement.cpp:
1973         (WebCore::HTMLObjectElement::HTMLObjectElement):
1974         (WebCore::HTMLObjectElement::parseMappedAttribute):
1975         (WebCore::HTMLObjectElement::attach):
1976         (WebCore::HTMLObjectElement::setComplete):
1977         (WebCore::HTMLObjectElement::detach):
1978         (WebCore::HTMLObjectElement::recalcStyle):
1979         (WebCore::HTMLObjectElement::childrenChanged):
1980         (WebCore::HTMLObjectElement::isImageType):
1981         * html/HTMLObjectElement.h:
1982         * html/HTMLOptionElement.cpp:
1983         (WebCore::HTMLOptionElement::value):
1984         * html/HTMLSelectElement.cpp:
1985         (WebCore::HTMLSelectElement::appendFormData):
1986         * html/HTMLTokenizer.cpp:
1987         (WebCore::HTMLTokenizer::parseTag):
1988         * ksvg2/svg/SVGColor.cpp:
1989         (WebCore::SVGColor::setRGBColor):
1990         * ksvg2/svg/SVGDescElement.cpp:
1991         (WebCore::SVGDescElement::description):
1992         * platform/PlatformString.h:
1993         * platform/String.cpp:
1994         (WebCore::String::stripWhiteSpace):
1995         (WebCore::String::simplifyWhiteSpace):
1996         * platform/StringImpl.cpp:
1997         (WebCore::isSpace):
1998         (WebCore::parseLength):
1999         (WebCore::StringImpl::stripWhiteSpace):
2000         (WebCore::StringImpl::simplifyWhiteSpace):
2001         (WebCore::StringImpl::toInt):
2002         * platform/StringImpl.h:
2003         * platform/mac/ClipboardMac.mm:
2004         (WebCore::cocoaTypeFromMIMEType):
2005         * rendering/RenderPartObject.cpp:
2006         (WebCore::RenderPartObject::updateWidget):
2007         * xml/XPathFunctions.cpp:
2008         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
2009         * xml/XPathGrammar.y:
2010         * xml/XPathStep.cpp:
2011         (WebCore::XPath::Step::nodeTestMatches):
2012         * xml/XSLStyleSheet.cpp:
2013         (WebCore::XSLStyleSheet::loadChildSheets):
2014         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
2015         * xml/XSLTProcessor.cpp:
2016         (WebCore::xsltParamArrayFromParameterMap):
2017         (WebCore::XSLTProcessor::setParameter):
2018         (WebCore::XSLTProcessor::getParameter):
2019         (WebCore::XSLTProcessor::removeParameter):
2020         * xml/XSLTProcessor.h:
2021         * xml/xmlhttprequest.cpp:
2022         (WebCore::XMLHttpRequest::getStatusText):
2023
2024 2006-09-17  David Hyatt  <hyatt@apple.com>
2025
2026         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
2027         are declared right before the fieldsets.  It turns out fieldsets in other
2028         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
2029         adding that behavior to fieldset fixes the bug.
2030
2031         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
2032         and fieldsets all subclass.
2033
2034         Reviewed by anders
2035
2036         Added fast/forms/float-before-fieldset.html
2037
2038         * rendering/RenderFieldset.h:
2039         (WebCore::RenderFieldset::avoidsFloats):
2040         * rendering/RenderFlexibleBox.h:
2041         (WebCore::RenderFlexibleBox::avoidsFloats):
2042         * rendering/RenderObject.cpp:
2043         (WebCore::RenderObject::avoidsFloats):
2044         * rendering/RenderObject.h:
2045         * rendering/RenderTable.h:
2046         (WebCore::RenderTable::avoidsFloats):
2047
2048 2006-09-17  David Hyatt  <hyatt@apple.com>
2049
2050         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
2051         "rules" attributes on tables.
2052
2053         Reviewed by bradee-oh
2054
2055         Well-covered by existing layout tests.
2056
2057         * html/HTMLTableCellElement.cpp:
2058         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
2059         * html/HTMLTableColElement.cpp:
2060         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
2061         * html/HTMLTableColElement.h:
2062         * html/HTMLTableElement.cpp:
2063         (WebCore::HTMLTableElement::HTMLTableElement):
2064         (WebCore::HTMLTableElement::~HTMLTableElement):
2065         (WebCore::HTMLTableElement::setCaption):
2066         (WebCore::HTMLTableElement::setTHead):
2067         (WebCore::HTMLTableElement::setTFoot):
2068         (WebCore::HTMLTableElement::setTBody):
2069         (WebCore::HTMLTableElement::createTHead):
2070         (WebCore::HTMLTableElement::deleteTHead):
2071         (WebCore::HTMLTableElement::createTFoot):
2072         (WebCore::HTMLTableElement::deleteTFoot):
2073         (WebCore::HTMLTableElement::createCaption):
2074         (WebCore::HTMLTableElement::deleteCaption):
2075         (WebCore::HTMLTableElement::insertRow):
2076         (WebCore::HTMLTableElement::deleteRow):
2077         (WebCore::HTMLTableElement::addChild):
2078         (WebCore::HTMLTableElement::childrenChanged):
2079         (WebCore::HTMLTableElement::mapToEntry):
2080         (WebCore::HTMLTableElement::parseMappedAttribute):
2081         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2082         (WebCore::HTMLTableElement::getSharedCellDecl):
2083         (WebCore::HTMLTableElement::getSharedGroupDecl):
2084         (WebCore::HTMLTableElement::attach):
2085         * html/HTMLTableElement.h:
2086         (WebCore::HTMLTableElement::caption):
2087         (WebCore::HTMLTableElement::tHead):
2088         (WebCore::HTMLTableElement::tFoot):
2089         (WebCore::HTMLTableElement::):
2090         * html/HTMLTableRowElement.h:
2091         * html/HTMLTableSectionElement.cpp:
2092         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
2093         * html/HTMLTableSectionElement.h:
2094
2095 2006-09-17  David Hyatt  <hyatt@apple.com>
2096
2097         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
2098         specify their own new font-family list.  Make sure to always
2099         reset the generic family along with the family list when mapping in
2100         new font-family values.
2101
2102         Reviewed by bradee-oh
2103
2104         fast/text/basic/generic-family-reset.html
2105
2106         * css/cssstyleselector.cpp:
2107         (WebCore::CSSStyleSelector::applyProperty):
2108
2109 2006-09-16  Brady Eidson <beidson@apple.com>
2110
2111         Reviewed by Hyatt
2112
2113         Pruning code relating to WebKit's icon loader
2114
2115         * bridge/mac/WebCoreIconDatabaseBridge.h:
2116         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2117         * loader/icon/IconDatabase.h:
2118         * page/Frame.cpp:
2119         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to 
2120         its new home
2121
2122 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2123
2124         Reviewed by Tim H.
2125
2126         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
2127         Auto-generate DOMHTMLDocument for the Objective-C bindings
2128
2129         * DerivedSources.make:
2130         * WebCore.xcodeproj/project.pbxproj:
2131         * bindings/objc/DOMExtensions.h:
2132         * bindings/objc/DOMHTML.mm:
2133         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
2134         * bindings/objc/DOMHTMLDocument.h: Removed.
2135         * bindings/objc/DOMHTMLDocument.mm: Removed.
2136         * bindings/objc/PublicDOMInterfaces.h:
2137         * bindings/scripts/CodeGeneratorObjC.pm:
2138         * html/HTMLDocument.idl:
2139         * platform/DeprecatedString.h:
2140         (WebCore::DeprecatedString::operator NSString*):
2141
2142 2006-09-16  Rob Buis  <buis@kde.org>
2143
2144         Reviewed by Eric.
2145
2146         http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
2147         Code in kcanvas/ should not use Private
2148
2149         Remove Private classes and tweak coding style.
2150
2151         WARNING: NO TEST CASES ADDED OR CHANGED
2152
2153         * kcanvas/RenderPath.cpp:
2154         (WebCore::RenderPath::RenderPath):
2155         (WebCore::RenderPath::~RenderPath):
2156         (WebCore::RenderPath::localTransform):
2157         (WebCore::RenderPath::setLocalTransform):
2158         (WebCore::RenderPath::fillContains):
2159         (WebCore::RenderPath::relativeBBox):
2160         (WebCore::RenderPath::setPath):
2161         (WebCore::RenderPath::path):
2162         (WebCore::RenderPath::layout):
2163         * kcanvas/RenderPath.h:
2164         * kcanvas/RenderSVGContainer.cpp:
2165         (WebCore::RenderSVGContainer::RenderSVGContainer):
2166         (WebCore::RenderSVGContainer::~RenderSVGContainer):
2167         (WebCore::RenderSVGContainer::drawsContents):
2168         (WebCore::RenderSVGContainer::setDrawsContents):
2169         (WebCore::RenderSVGContainer::localTransform):
2170         (WebCore::RenderSVGContainer::setLocalTransform):
2171         (WebCore::RenderSVGContainer::layout):
2172         (WebCore::RenderSVGContainer::paint):
2173         (WebCore::RenderSVGContainer::setViewport):
2174         (WebCore::RenderSVGContainer::viewport):
2175         (WebCore::RenderSVGContainer::setViewBox):
2176         (WebCore::RenderSVGContainer::viewBox):
2177         (WebCore::RenderSVGContainer::setAlign):
2178         (WebCore::RenderSVGContainer::align):
2179         (WebCore::RenderSVGContainer::fillContains):
2180         (WebCore::RenderSVGContainer::strokeContains):
2181         (WebCore::RenderSVGContainer::setSlice):
2182         (WebCore::RenderSVGContainer::slice):
2183         * kcanvas/RenderSVGContainer.h:
2184         * kcanvas/device/KRenderingFillPainter.cpp:
2185         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
2186         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
2187         (WebCore::KRenderingFillPainter::fillRule):
2188         (WebCore::KRenderingFillPainter::setFillRule):
2189         (WebCore::KRenderingFillPainter::opacity):
2190         (WebCore::KRenderingFillPainter::setOpacity):
2191         * kcanvas/device/KRenderingFillPainter.h:
2192         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2193         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
2194         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
2195         (WebCore::KRenderingPaintServerGradient::gradientStops):
2196         (WebCore::KRenderingPaintServerGradient::setGradientStops):
2197         (WebCore::KRenderingPaintServerGradient::spreadMethod):
2198         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
2199         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
2200         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
2201         (WebCore::KRenderingPaintServerGradient::gradientTransform):
2202         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
2203         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
2204         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
2205         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
2206         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
2207         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
2208         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
2209         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
2210         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
2211         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
2212         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
2213         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
2214         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
2215         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
2216         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
2217         (WebCore::KRenderingPaintServerGradient::listener):
2218         (WebCore::KRenderingPaintServerGradient::setListener):
2219         * kcanvas/device/KRenderingPaintServerGradient.h:
2220         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2221         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2222         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2223         (WebCore::KRenderingPaintServerPattern::setBbox):
2224         (WebCore::KRenderingPaintServerPattern::bbox):
2225         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
2226         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
2227         (WebCore::KRenderingPaintServerPattern::tile):
2228         (WebCore::KRenderingPaintServerPattern::setTile):
2229         (WebCore::KRenderingPaintServerPattern::patternTransform):
2230         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
2231         (WebCore::KRenderingPaintServerPattern::listener):
2232         (WebCore::KRenderingPaintServerPattern::setListener):
2233         * kcanvas/device/KRenderingPaintServerPattern.h:
2234         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2235         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
2236         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
2237         (WebCore::KRenderingPaintServerSolid::color):
2238         (WebCore::KRenderingPaintServerSolid::setColor):
2239         * kcanvas/device/KRenderingPaintServerSolid.h:
2240         * kcanvas/device/KRenderingStrokePainter.cpp:
2241         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
2242         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
2243         (WebCore::KRenderingStrokePainter::strokeWidth):
2244         (WebCore::KRenderingStrokePainter::setStrokeWidth):
2245         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2246         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2247         (WebCore::KRenderingStrokePainter::strokeCapStyle):
2248         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
2249         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
2250         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
2251         (WebCore::KRenderingStrokePainter::dashOffset):
2252         (WebCore::KRenderingStrokePainter::setDashOffset):
2253         (WebCore::KRenderingStrokePainter::dashArray):
2254         (WebCore::KRenderingStrokePainter::setDashArray):
2255         (WebCore::KRenderingStrokePainter::opacity):
2256         (WebCore::KRenderingStrokePainter::setOpacity):
2257         (WebCore::KRenderingStrokePainter::dirty):
2258         (WebCore::KRenderingStrokePainter::setDirty):
2259         * kcanvas/device/KRenderingStrokePainter.h:
2260
2261 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
2262
2263         Reviewed by Anders.
2264
2265         http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
2266         Fix build error
2267
2268         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
2269
2270 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
2271
2272         Reviewed by Anders.
2273
2274         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
2275         REGRESSION (r16387): Reproducible crash when mousing over HTML document
2276
2277         - Special case method [DOMNode ownerDocument] to call document() instead
2278           or ownerDocument() to return to the old behavior. 
2279
2280         * WebCore.xcodeproj/project.pbxproj:
2281         * bindings/scripts/CodeGeneratorObjC.pm:
2282
2283 2006-09-15  Brady Eidson  <beidson@apple.com>
2284
2285         Reviewed by Tim Hatcher
2286
2287         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
2288         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
2289
2290         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
2291         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
2292         (WebCore::IconDatabase::open): Make sure the directory exists
2293
2294 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2295
2296         Reviewed by Brady.
2297
2298         Make new style ObjC methods public API.
2299
2300         * WebCore.xcodeproj/project.pbxproj:
2301         * bindings/objc/DOMPrivate.h:
2302         * bindings/objc/PublicDOMInterfaces.h:
2303
2304 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2305
2306         Reviewed by Tim H.
2307
2308         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
2309         Auto-generate DOMNode for the Objective-C bindings
2310
2311         * DerivedSources.make:
2312         * WebCore.xcodeproj/project.pbxproj:
2313         * bindings/objc/DOM.mm:
2314         (-[DOMNode boundingBox]):
2315         (-[DOMNode lineBoxRects]):
2316         * bindings/objc/DOMEvents.h:
2317         * bindings/objc/DOMExtensions.h:
2318         * bindings/objc/DOMNode.h: Removed.
2319         * bindings/objc/DOMNode.mm: Removed.
2320         * bindings/objc/PublicDOMInterfaces.h:
2321         * bindings/scripts/CodeGeneratorObjC.pm:
2322         * dom/Node.idl:
2323
2324 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2325
2326         Reviewed by Justin.
2327
2328         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
2329
2330         * bridge/mac/WebCoreFrameBridge.h:
2331         * bridge/mac/WebCoreFrameBridge.mm:
2332         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
2333         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
2334         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
2335         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
2336         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
2337         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
2338         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2339         (-[WebCoreFrameBridge increaseSelectionListLevel]):
2340         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
2341         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
2342         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
2343         (-[WebCoreFrameBridge insertLineBreak]):
2344         (-[WebCoreFrameBridge insertParagraphSeparator]):
2345         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
2346         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
2347         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2348         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2349         (createMouseEventFromDraggingInfo):
2350         * editing/SelectionController.cpp:
2351         (WebCore::SelectionController::moveTo):
2352         (WebCore::SelectionController::setSelection):
2353         (WebCore::SelectionController::modify):
2354         (WebCore::SelectionController::setBase):
2355         (WebCore::SelectionController::setExtent):
2356         * editing/SelectionController.h:
2357         * page/Frame.cpp:
2358         (WebCore::Frame::revealSelection):
2359         (WebCore::Frame::revealCaret):
2360         * page/Frame.h:
2361
2362 2006-09-15  Brady Eidson  <beidson@apple.com>
2363
2364         Reviewed by Anders
2365
2366         Added the ability to get a mutable char* from a CString, which will copy the internal
2367         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
2368         referrer of that buffer.
2369
2370         * platform/CString.cpp:
2371         (WebCore::CString::mutableData):
2372         (WebCore::CString::copyBufferIfNeeded):
2373         * platform/CString.h:
2374
2375 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
2376
2377         Reviewed by harrison
2378         
2379         <rdar://problem/4674869>
2380         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
2381
2382         * editing/SelectionController.cpp:
2383         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
2384         * editing/visible_units.cpp:
2385         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
2386         position before it, not after it.
2387
2388 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2389
2390         Reviewed by Adam.
2391
2392         http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
2393         Bug 10864: Linux\GDK build fixes
2394
2395         * Projects/gdk/webcore-gdk.bkl:
2396         * WebCoreSources.bkl:
2397         * platform/gdk/FontCacheGdk.cpp:
2398         * platform/gdk/FontDataGdk.cpp:
2399         (WebCore::FontData::platformInit):
2400         * platform/gdk/FontGdk.cpp:
2401         (WebCore::Font::drawGlyphs):
2402         * platform/gdk/FrameGdk.cpp:
2403         (WebCore::FrameGdk::handleGdkEvent):
2404         * platform/gdk/FrameGdk.h:
2405         * platform/gdk/ImageGdk.cpp: Added.
2406         (WebCore::Image::initPlatformData):
2407         (WebCore::Image::invalidatePlatformData):
2408         (WebCore::Image::loadPlatformResource):
2409         (WebCore::Image::supportsType):
2410         * platform/gdk/RenderPopupMenuGdk.cpp:
2411         (WebCore::RenderPopupMenuGdk::hidePopup):
2412         * platform/gdk/RenderPopupMenuGdk.h:
2413         * platform/gdk/ScreenGdk.cpp:
2414         (WebCore::drawableForPage):
2415         (WebCore::screenRect):
2416         (WebCore::screenDepth):
2417         (WebCore::usableScreenRect):
2418         (WebCore::scaleFactor):
2419         * platform/gdk/SystemTimeLinux.cpp:
2420         (WebCore::currentTime):
2421         * platform/gdk/TemporaryLinkStubs.cpp:
2422         (FrameGdk::bindingRootObject):
2423         (FrameGdk::markMisspellings):
2424         (WebCore::screenDepthPerComponent):
2425         (WebCore::screenIsMonochrome):
2426         (WebCore::fileButtonChooseFileLabel):
2427         (WebCore::fileButtonNoFileSelectedLabel):
2428         (FrameGdk::shouldChangeSelection):
2429         (FrameGdk::respondToChangedSelection):
2430         (FrameGdk::respondToChangedContents):
2431         (Path::contains):
2432         (PlatformScrollBar::PlatformScrollBar):
2433         (PlatformScrollBar::~PlatformScrollBar):
2434         (PlatformScrollBar::width):
2435         (PlatformScrollBar::height):
2436         (PlatformScrollBar::setEnabled):
2437         (PlatformScrollBar::paint):
2438         (PlatformScrollBar::setScrollBarValue):
2439         (PlatformScrollBar::setKnobProportion):
2440         (PlatformScrollBar::setRect):
2441         (ScrollBar::ScrollBar):
2442         (FileChooser::FileChooser):
2443         (FileChooser::~FileChooser):
2444         (FileChooser::openFileChooser):
2445         (FileChooser::basenameForWidth):
2446         (FileChooser::uploadControlDetaching):
2447         (FileChooser::chooseFile):
2448         (Icon::Icon):
2449         (Icon::~Icon):
2450         (Icon::newIconForFile):
2451         (Icon::paint):
2452         (IconLoader::stopLoading):
2453         (IconLoader::startLoading):
2454         (IconLoader::createForFrame):
2455         (IconDatabase::isIconExpiredForIconURL):
2456         (IconDatabase::hasEntryForIconURL):
2457         (IconDatabase::sharedIconDatabase):
2458         * platform/gdk/WidgetGdk.cpp:
2459         * webcore-base.bkl:
2460
2461 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2462
2463         Reviewed by Eric.
2464
2465         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
2466         Fix svg memory leaks.
2467
2468         Reworked SVGList to deal with RefPtr's for ptr types
2469         which makes manual refcounting unnecessary, and is much safer.
2470
2471         Removing all virtual functions (nullItem) from SVGList, and
2472         also remove SVGListBase. Switch to a similar concept like
2473         Vector/VectorTraits (see new file SVGListTraits.h).
2474
2475         Credits go to Eric/Maciej for the inspiration.
2476
2477         * CMakeLists.txt: Add SVGListTraits.cpp to build
2478         * WebCore.xcodeproj/project.pbxproj: Ditto.
2479         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
2480         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
2481         (WebCore::RenderSVGText::translationForAttributes):
2482         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
2483         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2484         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
2485         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
2486         * ksvg2/svg/SVGElementInstanceList.h:
2487         * ksvg2/svg/SVGLengthList.cpp: Ditto.
2488         (WebCore::SVGLengthList::SVGLengthList):
2489         * ksvg2/svg/SVGLengthList.h: Ditto.
2490         * ksvg2/svg/SVGList.h: Rewrote, as described above.
2491         (WebCore::SVGListTypeOperations::nullItem):
2492         (WebCore::SVGList::SVGList):
2493         (WebCore::SVGList::~SVGList):
2494         (WebCore::SVGList::clear):
2495         (WebCore::SVGList::getFirst):
2496         (WebCore::SVGList::getLast):
2497         (WebCore::SVGList::getItem):
2498         (WebCore::SVGList::replaceItem):
2499         (WebCore::SVGList::removeItem):
2500         * ksvg2/svg/SVGListTraits.cpp: Added.
2501         * ksvg2/svg/SVGListTraits.h: Added.
2502         (WebCore::):
2503         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
2504         (WebCore::SVGPathElement::toPathData):
2505         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
2506         (WebCore::SVGPathSegList::SVGPathSegList):
2507         * ksvg2/svg/SVGPathSegList.h: Ditto.
2508         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
2509         (SVGTransform::SVGTransform):
2510         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
2511         (SVGTransformList::SVGTransformList):
2512         (SVGTransformList::createSVGTransformFromMatrix):
2513         (SVGTransformList::consolidate):
2514         * ksvg2/svg/SVGTransformList.h: Ditto.
2515         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
2516         (SVGTransformable::parseTransformAttribute):
2517
2518 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
2519
2520         Reviewed by eseidel.  Landed by eseidel.
2521
2522         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
2523         be able to see javascript errors for instance.
2524
2525         * CMakeLists.txt:
2526         * platform/qt/FrameQt.h:
2527         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
2528         (WebCore::FrameQt::bindingRootObject):
2529         * platform/qt/TemporaryLinkStubs.cp
2530         (WebCore::IconDatabase::hasEntryForIconURL):
2531         (WebCore::IconDatabase::sharedIconDatabase):
2532
2533 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
2534
2535         Reviewed by Tim H.
2536
2537         Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
2538         Auto-generate the internal methods for the Objective-C bindings
2539
2540         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
2541           implementations where standard.  For cases where a custom implementation was
2542           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
2543
2544         - Some general cleanup of some of the non-generated bindings, to bring them in-
2545           line with what the generated bindings look like.
2546
2547         * bindings/objc/DOM.mm:
2548         (-[DOMNode description]):
2549         * bindings/objc/DOMCSS.mm:
2550         (-[DOMCSSPrimitiveValue WebCore::]):
2551         (-[DOMDocument getComputedStyle::]):
2552         (-[DOMDocument getMatchedCSSRules::]):
2553         * bindings/objc/DOMEvents.mm:
2554         (-[DOMEvent WebCore::]):
2555         * bindings/objc/DOMHTML.mm:
2556         * bindings/objc/DOMHTMLDocument.mm:
2557         (-[DOMHTMLDocument title]):
2558         (-[DOMHTMLDocument setTitle:]):
2559         (-[DOMHTMLDocument referrer]):
2560         (-[DOMHTMLDocument domain]):
2561         (-[DOMHTMLDocument URL]):
2562         (-[DOMHTMLDocument body]):
2563         (-[DOMHTMLDocument setBody:]):
2564         (-[DOMHTMLDocument images]):
2565         (-[DOMHTMLDocument applets]):
2566         (-[DOMHTMLDocument links]):
2567         (-[DOMHTMLDocument forms]):
2568         (-[DOMHTMLDocument anchors]):
2569         (-[DOMHTMLDocument cookie]):
2570         (-[DOMHTMLDocument setCookie:]):
2571         (-[DOMHTMLDocument open]):
2572         (-[DOMHTMLDocument close]):
2573         (-[DOMHTMLDocument write:]):
2574         (-[DOMHTMLDocument writeln:]):
2575         (-[DOMHTMLDocument getElementById:]):
2576         (-[DOMHTMLDocument getElementsByName:]):
2577         (-[DOMHTMLDocument WebCore::]):
2578         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
2579         * bindings/objc/DOMHTMLOptionElement.mm:
2580         (-[DOMHTMLOptionElement form]):
2581         (-[DOMHTMLOptionElement defaultSelected]):
2582         (-[DOMHTMLOptionElement setDefaultSelected:]):
2583         (-[DOMHTMLOptionElement text]):
2584         (-[DOMHTMLOptionElement index]):
2585         (-[DOMHTMLOptionElement disabled]):
2586         (-[DOMHTMLOptionElement setDisabled:]):
2587         (-[DOMHTMLOptionElement label]):
2588         (-[DOMHTMLOptionElement setLabel:]):
2589         (-[DOMHTMLOptionElement selected]):
2590         (-[DOMHTMLOptionElement setSelected:]):
2591         (-[DOMHTMLOptionElement value]):
2592         (-[DOMHTMLOptionElement setValue:]):
2593         (-[DOMHTMLOptionElement WebCore::]):
2594         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
2595         * bindings/objc/DOMInternal.h:
2596         * bindings/objc/DOMNode.mm:
2597         (-[DOMNode dealloc]):
2598         (-[DOMNode finalize]):
2599         (-[DOMNode nodeName]):
2600         (-[DOMNode nodeValue]):
2601         (-[DOMNode setNodeValue:]):
2602         (-[DOMNode nodeType]):
2603         (-[DOMNode parentNode]):
2604         (-[DOMNode childNodes]):
2605         (-[DOMNode firstChild]):
2606         (-[DOMNode lastChild]):
2607         (-[DOMNode previousSibling]):
2608         (-[DOMNode nextSibling]):
2609         (-[DOMNode attributes]):
2610         (-[DOMNode ownerDocument]):
2611         (-[DOMNode insertBefore::]):
2612         (-[DOMNode replaceChild::]):
2613         (-[DOMNode removeChild:]):
2614         (-[DOMNode appendChild:]):
2615         (-[DOMNode hasChildNodes]):
2616         (-[DOMNode cloneNode:]):
2617         (-[DOMNode normalize]):
2618         (-[DOMNode isSupported::]):
2619         (-[DOMNode namespaceURI]):
2620         (-[DOMNode prefix]):
2621         (-[DOMNode setPrefix:]):
2622         (-[DOMNode localName]):
2623         (-[DOMNode hasAttributes]):
2624         (-[DOMNode isSameNode:]):
2625         (-[DOMNode isEqualNode:]):
2626         (-[DOMNode isDefaultNamespace:]):
2627         (-[DOMNode lookupPrefix:]):
2628         (-[DOMNode lookupNamespaceURI:]):
2629         (-[DOMNode textContent]):
2630         (-[DOMNode setTextContent:]):
2631         (-[DOMNode boundingBox]):
2632         (-[DOMNode lineBoxRects]):
2633         * bindings/objc/DOMObject.mm:
2634         (-[DOMObject _init]):
2635         * bindings/objc/DOMXPath.mm:
2636         (-[DOMNativeXPathNSResolver dealloc]):
2637         (-[DOMNativeXPathNSResolver finalize]):
2638         (-[DOMNativeXPathNSResolver WebCore::]):
2639         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2640         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
2641         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
2642         * bindings/scripts/CodeGeneratorObjC.pm:
2643         * bridge/mac/WebCoreFrameBridge.mm:
2644         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2645         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
2646         * css/CSSCharsetRule.idl:
2647         * css/CSSFontFaceRule.idl:
2648         * css/CSSImportRule.idl:
2649         * css/CSSMediaRule.idl:
2650         * css/CSSPageRule.idl:
2651         * css/CSSPrimitiveValue.idl:
2652         * css/CSSRule.idl:
2653         * css/CSSStyleRule.idl:
2654         * css/CSSStyleSheet.idl:
2655         * css/CSSUnknownRule.idl:
2656         * css/CSSValue.idl:
2657         * css/CSSValueList.idl:
2658         * css/StyleSheet.idl:
2659         * dom/Event.idl:
2660         * dom/KeyboardEvent.idl:
2661         * dom/MouseEvent.idl:
2662         * dom/MutationEvent.idl:
2663         * dom/NodeIterator.idl:
2664         * dom/OverflowEvent.idl:
2665         * dom/TreeWalker.idl:
2666         * dom/UIEvent.idl:
2667         * dom/WheelEvent.idl:
2668
2669 2006-09-15  Adam Roben  <aroben@apple.com>
2670
2671         Reviewed by timothy.
2672
2673         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
2674         New file upload control should match the width of the old one
2675
2676         Make width of new file upload control match the old one as closely as
2677         possible.
2678
2679         * rendering/RenderFileUploadControl.cpp:
2680
2681 2006-09-15  Timothy Hatcher  <timothy@apple.com>
2682
2683         Reviewed by Eric.
2684
2685         Remove the SVG IDL files from the Copy Resources phase.
2686
2687         * WebCore.xcodeproj/project.pbxproj:
2688
2689 2006-09-15  Brady Eidson  <beidson@apple.com>
2690
2691         Reviewed by Eric Siedel
2692
2693         Dumped the use of CGColorRef and directly use the floating point data from
2694         WebCore::Color
2695
2696         This fixes the performance regression found between 16285 and 16286
2697
2698         * platform/mac/FontMac.mm:
2699         (WebCore::Font::drawComplexText):
2700         (WebCore::Font::drawGlyphs):
2701
2702 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
2703
2704         Reviewed by Adam.
2705
2706         http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
2707         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
2708
2709         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
2710         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
2711         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
2712
2713         * bridge/mac/FrameMac.mm:
2714         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
2715         will be called from Frame::clear
2716         * page/Frame.cpp:
2717         (WebCore::Frame::~Frame): Use cancelAndClear.
2718         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
2719         FrameMac can use.
2720         * page/Frame.h:
2721
2722 2006-09-14  Brady Eidson  <beidson@apple.com>
2723
2724         Reviewed by Maciej's rubber stamp
2725
2726         Exact same fix I just made, but in the other method I horked up
2727         Also added a reference to the bugzilla in comments
2728
2729         * page/Frame.cpp:
2730         (WebCore::Frame::endIfNotLoading):
2731         (WebCore::Frame::stop):
2732
2733 2006-09-14  Brady Eidson  <beidson@apple.com>
2734
2735         Reviewed by Maciej
2736
2737         Fixed a bad iFrame crash, resolving some of the layout test badness
2738
2739         * page/Frame.cpp:
2740         (WebCore::Frame::endIfNotLoading):
2741         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
2742
2743 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
2744
2745         Reviewed by harrison
2746         
2747         <rdar://problem/4655880> Up/Down arrows skip over To Do
2748
2749         * bridge/mac/WebCoreFrameBridge.mm:
2750         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
2751         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
2752         * dom/Node.h:
2753         * editing/SelectionController.cpp:
2754         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
2755         * editing/visible_units.cpp:
2756         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
2757         editable content into editable content that's embedded in non-editable content.
2758         (WebCore::nextLinePosition): Ditto.
2759         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
2760         This is the behavior that callers desire.  This fixes Command + Up/Down.
2761         (WebCore::endOfEditableContent): Ditto.
2762         * editing/visible_units.h:
2763
2764 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
2765
2766         Reviewed by timothy. Landed by aroben.
2767
2768         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
2769         Windows build fixes after r16360
2770
2771         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
2772         AdditionalIncludeDirectories
2773         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
2774         IconDatabase
2775         (IconLoader::stopLoading):
2776         (IconLoader::startLoading):
2777         (IconLoader::createForFrame):
2778         (IconDatabase::isIconExpiredForIconURL):
2779         (IconDatabase::hasEntryForIconURL):
2780         (IconDatabase::sharedIconDatabase):
2781
2782 2006-09-14  Brady Eidson  <beidson@apple.com>
2783
2784         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
2785
2786         * loader/icon/IconLoader.cpp:
2787         (IconLoader::receivedAllData):
2788         * page/Frame.cpp:
2789         * page/FramePrivate.h:
2790
2791 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
2792
2793         Reviewed by Justin Garcia.
2794
2795         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
2796           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
2797
2798         * editing/ApplyStyleCommand.cpp:
2799         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
2800         makeing sure that the 'beyondEnd' node is after the start node.
2801
2802 2006-09-14  MorganL  <morlmor@yahoo.com>
2803
2804         Reviewed by Brady.
2805
2806         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
2807         Various bugs/crashes in ResourceLoaderWin with local files.
2808
2809         * platform/ResourceLoaderInternal.h:
2810         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2811         * platform/win/ResourceLoaderWin.cpp:
2812         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
2813         (WebCore::ResourceLoader::fileLoadTimer):
2814
2815 2006-09-13  Brady Eidson <beidson@apple.com>
2816
2817         Reviewed by Maciej
2818
2819         Icon loads now take place in WebCore
2820
2821         * WebCore.xcodeproj/project.pbxproj:
2822         * bridge/BrowserExtension.h:
2823         * bridge/mac/BrowserExtensionMac.h:
2824         * bridge/mac/BrowserExtensionMac.mm:
2825         - Moved enforcement of a Mozilla Favicon extension elsewhere
2826         
2827         * bridge/mac/FrameMac.h: 
2828         * bridge/mac/FrameMac.mm: 
2829         (WebCore::FrameMac::originalRequestURL):
2830         - Added accessor to "original request URL"
2831         
2832         * bridge/mac/WebCoreFrameBridge.h: 
2833         - Removed methods to set the iconURL as all loading is now done in WebCore
2834         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
2835         
2836         * html/HTMLLinkElement.cpp: 
2837         (WebCore::HTMLLinkElement::process):
2838         - Moved enforcement of a Mozilla Favicon extension elsewhere
2839         
2840         * loader/icon/IconDatabase.cpp:
2841         (WebCore::IconDatabase::setIconURLForPageURL):
2842         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
2843
2844         * loader/icon/IconLoader.h: Added.
2845         * loader/icon/IconLoader.cpp: Added.
2846         (IconLoader::IconLoader):
2847         (IconLoader::createForFrame):
2848         - Static factory method with a private constructor to enforce 
2849           "you MUST have a Frame to create an IconLoader" semantics
2850         (IconLoader::~IconLoader):
2851         (IconLoader::startLoading):
2852         (IconLoader::stopLoading):
2853         (IconLoader::receivedData):
2854         - ResourceLoaderClient delegate
2855         (IconLoader::receivedAllData):
2856         - Ditto
2857
2858         * loader/mac/IconLoaderMac.mm: Added.
2859         (IconLoader::receivedResponse):
2860         (IconLoader::notifyIconChanged):
2861         - For now, these are platform specific methods
2862         - One to get the HTTP response code of an icon load
2863         - The other to call through to the app when the icon has changed (loaded)
2864
2865         * page/Frame.h:
2866         * page/Frame.cpp:
2867         (WebCore::Frame::iconURL):
2868         (WebCore::Frame::setIconURL):
2869         - Frame objects now have an inherent icon URL and a way to calculate/access it
2870         (WebCore::Frame::endIfNotLoading):
2871         - This is where we actually kick off the IconLoader
2872         (WebCore::Frame::stop):
2873         - Added call to stop loading the icon
2874
2875         * page/FramePrivate.h:
2876         (WebCore::FramePrivate::FramePrivate):
2877         (WebCore::FramePrivate::~FramePrivate):
2878         - Added the icon URL as a private member
2879         - Added the IconLoader as a private member, and clean it up on deletion
2880
2881         * platform/mac/ResourceLoaderMac.mm:
2882         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
2883
2884 2006-09-13  David Hyatt  <hyatt@apple.com>
2885
2886         Fix for 10841, unable to check checkboxes inside labels.
2887
2888         Reviewed by xenon, bradee-oh
2889
2890         * css/html4.css:
2891         * dom/Element.cpp:
2892         (WebCore::Element::contains):
2893         * dom/Element.h:
2894         * html/HTMLLabelElement.cpp:
2895         (WebCore::HTMLLabelElement::defaultEventHandler):
2896
2897 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
2898
2899         Reviewed by Adam.
2900
2901         http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
2902         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
2903
2904         * platform/mac/FileChooserMac.mm:
2905         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
2906
2907 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
2908
2909         Reviewed by Eric.
2910
2911         http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
2912         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
2913
2914         * platform/mac/FontMac.mm:
2915         (WebCore::Font::drawComplexText): Release CGColorRef after use.
2916         (WebCore::Font::drawGlyphs): Ditto.
2917
2918 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
2919
2920         Try fixing the Win32 build.
2921         
2922         * bridge/win/FrameWin.h:
2923         * platform/win/TemporaryLinkStubs.cpp:
2924         (FrameWin::bindingRootObject):
2925
2926 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
2927
2928         Reviewed by Tim O.
2929
2930         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
2931         
2932         * bindings/js/kjs_binding.cpp:
2933         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
2934         * bindings/js/kjs_dom.cpp:
2935         (KJS::getRuntimeObject):
2936         * bridge/mac/FrameMac.h:
2937         * config.h:
2938         * html/HTMLAppletElement.cpp:
2939         (WebCore::HTMLAppletElement::~HTMLAppletElement):
2940         (WebCore::HTMLAppletElement::detach):
2941         * html/HTMLAppletElement.h:
2942         * html/HTMLEmbedElement.cpp:
2943         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
2944         (WebCore::HTMLEmbedElement::detach):
2945         * html/HTMLEmbedElement.h:
2946         * html/HTMLObjectElement.cpp:
2947         (WebCore::HTMLObjectElement::~HTMLObjectElement):
2948         (WebCore::HTMLObjectElement::detach):
2949         * html/HTMLObjectElement.h:
2950         * html/HTMLPlugInElement.cpp:
2951         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
2952         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
2953         (WebCore::HTMLPlugInElement::createNPObject):
2954         * html/HTMLPlugInElement.h:
2955         * page/Frame.h:
2956
2957 2006-09-13  David Hyatt  <hyatt@apple.com>
2958
2959         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
2960         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
2961         KHTML_XSLT is now XSLT_SUPPORT.
2962
2963         * WebCore.xcodeproj/project.pbxproj:
2964         * bindings/js/JSXSLTProcessor.cpp:
2965         * bindings/js/JSXSLTProcessor.h:
2966         * bindings/js/kjs_window.cpp:
2967         (KJS::Window::getValueProperty):
2968         * config.h:
2969         * css/CSSComputedStyleDeclaration.cpp:
2970         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2971         * css/cssparser.cpp:
2972         (WebCore::CSSParser::parseValue):
2973         * css/cssstyleselector.cpp:
2974         (WebCore::CSSStyleSelector::applyProperty):
2975         * dom/Document.cpp:
2976         (WebCore::Document::Document):
2977         (WebCore::Document::~Document):
2978         (WebCore::Document::recalcStyleSelector):
2979         * dom/Document.h:
2980         (WebCore::Document::bindingManager):
2981         * dom/Node.cpp:
2982         (WebCore::Node::createRendererIfNeeded):
2983         * dom/ProcessingInstruction.cpp:
2984         (WebCore::ProcessingInstruction::ProcessingInstruction):
2985         (WebCore::ProcessingInstruction::checkStyleSheet):
2986         (WebCore::ProcessingInstruction::setStyleSheet):
2987         * dom/ProcessingInstruction.h:
2988         * dom/XMLTokenizer.cpp:
2989         (WebCore::XMLTokenizer::processingInstruction):
2990         (WebCore::XMLTokenizer::insertErrorMessageBlock):
2991         * dom/XMLTokenizer.h:
2992         * loader/Cache.cpp:
2993         (WebCore::Cache::getStatistics):
2994         * loader/Cache.h:
2995         * loader/CachedResource.h:
2996         (WebCore::CachedResource::):
2997         * loader/CachedResourceClient.h:
2998         * loader/CachedXBLDocument.cpp:
2999         * loader/CachedXBLDocument.h:
3000         * loader/CachedXSLStyleSheet.cpp:
3001         * loader/CachedXSLStyleSheet.h:
3002         * loader/DocLoader.cpp:
3003         * loader/DocLoader.h:
3004         * rendering/RenderStyle.cpp:
3005         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
3006         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
3007         (WebCore::StyleCSS3NonInheritedData::operator==):
3008         * rendering/RenderStyle.h:
3009         * xml/XSLImportRule.cpp:
3010         * xml/XSLImportRule.h:
3011         * xml/XSLStyleSheet.cpp:
3012         * xml/XSLStyleSheet.h:
3013         * xml/XSLTProcessor.cpp:
3014         * xml/XSLTProcessor.h:
3015
3016 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3017
3018         Reviewed by eseidel.  Landed by eseidel.
3019
3020         Fix newly introduced memory leaks in SVG.
3021         http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
3022
3023         * ksvg2/svg/SVGList.h:
3024         (WebCore::SVGListBase::~SVGListBase):
3025         (WebCore::SVGListBase::clearVector):
3026         (WebCore::SVGListBase::clear):
3027         (WebCore::SVGList::clearVector):
3028         (WebCore::):
3029         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
3030         (SVGNumberList::SVGNumberList):
3031         * ksvg2/svg/SVGNumberList.h: Ditto.
3032
3033 2006-09-13  MorganL  <morlmor@yahoo.com>
3034
3035         Reviewed/landed by aroben.
3036
3037         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
3038         Windows build needs fixed after move to engine-rendered file upload widget
3039
3040         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
3041         remove RenderFileButton files
3042         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
3043         (FileChooser::FileChooser):
3044         (FileChooser::~FileChooser):
3045         (FileChooser::openFileChooser):
3046         (FileChooser::basenameForWidth):
3047         (FileChooser::uploadControlDetaching):
3048         (FileChooser::chooseFile):
3049         (WebCore::fileButtonChooseFileLabel):
3050         (WebCore::fileButtonNoFileSelectedLabel):
3051         (Icon::Icon):
3052         (Icon::~Icon):
3053         (Icon::newIconForFile):
3054         (Icon::paint):
3055
3056 2006-09-13  MorganL  <morlmor@yahoo.com>
3057
3058         Reviewed/landed by aroben.
3059
3060         Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
3061         Webkit WebCore build fails on Windows
3062
3063         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
3064         variable
3065
3066 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
3067
3068         Reviewed by Tim H.
3069
3070         Fix Qt/Linux build.
3071
3072         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
3073         * platform/Icon.h: Add wtf/Platform.h include
3074         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
3075         (WebCore::FileChooser::FileChooser):
3076         (WebCore::FileChooser::~FileChooser):
3077         (WebCore::FileChooser::openFileChooser):
3078         (WebCore::FileChooser::basenameForWidth):
3079         (WebCore::FileChooser::uploadControlDetaching):
3080         (WebCore::FileChooser::chooseFile):
3081         * platform/qt/IconQt.cpp: Added as stub.
3082         (WebCore::Icon::Icon):
3083         (WebCore::Icon::~Icon):
3084         (WebCore::Icon::newIconForFile):
3085         (WebCore::Icon::paint):
3086         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
3087         (searchableIndexIntroduction):
3088         (fileButtonChooseFileLabel):
3089         (fileButtonNoFileSelectedLabel):
3090
3091 2006-09-12  Adam Roben  <aroben@apple.com>
3092
3093         Reviewed by eseidel.
3094
3095         Switch back to passing relative paths to generate-bindings.pl when
3096         generating JS bindings.
3097
3098         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
3099         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
3100         chdir and always construct absolute paths instead.
3101
3102 2006-09-12  David Hyatt  <hyatt@apple.com>
3103
3104         Fix for bug 3244, implement html4 label support.
3105
3106         Reviewed by mjs, aroben
3107
3108         Added fast/events/label-focus.html
3109
3110         * css/html4.css:
3111         * html/HTMLLabelElement.cpp:
3112         (WebCore::HTMLLabelElement::formElement):
3113         (WebCore::HTMLLabelElement::setActive):
3114         (WebCore::HTMLLabelElement::setHovered):
3115         (WebCore::HTMLLabelElement::defaultEventHandler):
3116         * html/HTMLLabelElement.h:
3117
3118 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
3119
3120         Reviewed by darin.  Landed by eseidel.
3121
3122         * ksvg2/svg/svgpathparser.cpp:
3123         (WebCore::SVGPolyParser::parsePoints):
3124
3125 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
3126
3127         Reviewed by Andersca, Maciej, Brady.
3128
3129         - Implemented intersectsNode in the Range Class
3130           to be compliant with Mozilla standard
3131
3132         * dom/Range.cpp:
3133         (WebCore::Range::intersectsNode):
3134         * dom/Range.h:
3135         * dom/Range.idl:
3136
3137 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3138
3139         Reviewed by eseidel.  Landed by eseidel.
3140
3141         Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
3142         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826
3143         
3144         Also finally fixes some long outstanding bugs:
3145         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
3146         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
3147         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413
3148
3149         Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.
3150
3151         * CMakeLists.txt:
3152         * DerivedSources.make:
3153         * WebCore.xcodeproj/project.pbxproj:
3154         * bindings/scripts/CodeGenerator.pm:
3155         * bindings/scripts/CodeGeneratorJS.pm:
3156         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
3157         * ksvg2/svg/SVGAElement.idl: Added.
3158         * ksvg2/svg/SVGAngle.idl:
3159         * ksvg2/svg/SVGAnimateColorElement.idl: Added.
3160         * ksvg2/svg/SVGAnimateElement.idl: Added.
3161         * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
3162         * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
3163         * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
3164         * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
3165         * ksvg2/svg/SVGAnimationElement.idl: Added.
3166         * ksvg2/svg/SVGCircleElement.idl: Added.
3167         * ksvg2/svg/SVGClipPathElement.idl: Added.
3168         * ksvg2/svg/SVGColor.idl:
3169         * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
3170         * ksvg2/svg/SVGCursorElement.idl: Added.
3171         * ksvg2/svg/SVGDefsElement.idl: Added.
3172         * ksvg2/svg/SVGDescElement.idl: Added.
3173         * ksvg2/svg/SVGEllipseElement.idl: Added.
3174         * ksvg2/svg/SVGEvent.idl:
3175         * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
3176         * ksvg2/svg/SVGFEBlendElement.idl: Added.
3177         * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
3178         * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
3179         * ksvg2/svg/SVGFECompositeElement.idl: Added.
3180         * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
3181         * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
3182         * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
3183         * ksvg2/svg/SVGFEFloodElement.idl: Added.
3184         * ksvg2/svg/SVGFEFuncAElement.idl: Added.
3185         * ksvg2/svg/SVGFEFuncBElement.idl: Added.
3186         * ksvg2/svg/SVGFEFuncGElement.idl: Added.
3187         * ksvg2/svg/SVGFEFuncRElement.idl: Added.
3188         * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
3189         * ksvg2/svg/SVGFEImageElement.idl: Added.
3190         * ksvg2/svg/SVGFEMergeElement.idl: Added.
3191         * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
3192         * ksvg2/svg/SVGFEOffsetElement.idl: Added.
3193         * ksvg2/svg/SVGFEPointLightElement.idl: Added.
3194         * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
3195         * ksvg2/svg/SVGFESpotLightElement.idl: Added.
3196         * ksvg2/svg/SVGFETileElement.idl: Added.
3197         * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
3198         * ksvg2/svg/SVGFilterElement.idl: Added.
3199         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
3200         * ksvg2/svg/SVGFitToViewBox.idl: Added.
3201         * ksvg2/svg/SVGForeignObjectElement.idl: Added.
3202         * ksvg2/svg/SVGGElement.idl: Added.
3203         * ksvg2/svg/SVGGradientElement.idl: Added.
3204         * ksvg2/svg/SVGImageElement.idl: Added.
3205         * ksvg2/svg/SVGLangSpace.idl: Added.
3206         * ksvg2/svg/SVGLength.idl:
3207         * ksvg2/svg/SVGLengthList.idl: Added.
3208         * ksvg2/svg/SVGLineElement.idl: Added.
3209         * ksvg2/svg/SVGLinearGradientElement.idl: Added.
3210         * ksvg2/svg/SVGLocatable.idl: Added.
3211         * ksvg2/svg/SVGMarkerElement.idl: Added.
3212         * ksvg2/svg/SVGMaskElement.idl: Added.
3213         * ksvg2/svg/SVGNumberList.idl: Added.
3214         * ksvg2/svg/SVGPaint.idl: Added.
3215         * ksvg2/svg/SVGPathElement.idl:
3216         * ksvg2/svg/SVGPathSeg.idl:
3217         * ksvg2/svg/SVGPatternElement.idl: Added.
3218         * ksvg2/svg/SVGPointList.idl: Added.
3219         * ksvg2/svg/SVGPolygonElement.idl: Added.
3220         * ksvg2/svg/SVGPolylineElement.idl: Added.
3221         * ksvg2/svg/SVGPreserveAspectRatio.idl:
3222         * ksvg2/svg/SVGRadialGradientElement.idl: Added.
3223         * ksvg2/svg/SVGRectElement.idl: Added.
3224         * ksvg2/svg/SVGRenderingIntent.idl: Added.
3225         * ksvg2/svg/SVGSVGElement.idl:
3226         * ksvg2/svg/SVGScriptElement.idl: Added.
3227         * ksvg2/svg/SVGSetElement.idl: Added.
3228         * ksvg2/svg/SVGStopElement.idl: Added.
3229         * ksvg2/svg/SVGStringList.idl: Added.
3230         * ksvg2/svg/SVGStylable.idl: Added.
3231         * ksvg2/svg/SVGStyleElement.idl: Added.
3232         * ksvg2/svg/SVGSwitchElement.idl: Added.
3233         * ksvg2/svg/SVGSymbolElement.idl: Added.
3234         * ksvg2/svg/SVGTRefElement.idl: Added.
3235         * ksvg2/svg/SVGTSpanElement.idl: Added.
3236         * ksvg2/svg/SVGTests.idl: Added.
3237         * ksvg2/svg/SVGTextContentElement.idl: Added.
3238         * ksvg2/svg/SVGTextElement.idl: Added.
3239         * ksvg2/svg/SVGTextPositioningElement.idl: Added.
3240         * ksvg2/svg/SVGTitleElement.idl: Added.
3241         * ksvg2/svg/SVGTransform.idl:
3242         * ksvg2/svg/SVGTransformList.idl: Added.
3243         * ksvg2/svg/SVGTransformable.idl: Added.
3244         * ksvg2/svg/SVGURIReference.idl: Added.
3245         * ksvg2/svg/SVGUnitTypes.idl: Added.
3246         * ksvg2/svg/SVGUseElement.idl: Added.
3247         * ksvg2/svg/SVGViewElement.idl: Added.
3248         * ksvg2/svg/SVGZoomAndPan.idl: Added.
3249         * ksvg2/svg/SVGZoomEvent.idl: Added.
3250
3251 2006-09-12  Adam Roben  <aroben@apple.com>
3252
3253         Reviewed by timo, ggaren.
3254
3255         Make Icon ref-counted.
3256
3257         * platform/FileChooser.h: Store m_icon as a RefPtr instead of
3258         auto_ptr.
3259         * platform/Icon.h: Inherit from Shared<Icon>
3260         * platform/mac/FileChooserMac.mm:
3261         (WebCore::FileChooser::chooseFile): Update m_icon usage
3262         * platform/mac/IconMac.mm:
3263         (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
3264         auto_ptr
3265
3266 === Safari-521.26 ===
3267
3268 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
3269
3270         Reviewed by Anders.
3271
3272         Add exception codes to SVGList functions, adjust all code using it.
3273
3274         Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
3275         Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
3276         Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
3277         Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
3278         Move SVGFE* related enums into their respecitive classes.
3279
3280         Fix JSSVGNumber to operator on doubles, instead of floats.
3281
3282         * ksvg2/bindings/js/JSSVGNumber.cpp:
3283         (WebCore::getJSSVGNumber):
3284         * ksvg2/bindings/js/JSSVGNumber.h:
3285         (WebCore::JSSVGNumber::JSSVGNumber):
3286         * ksvg2/css/SVGCSSParser.cpp:
3287         (WebCore::CSSParser::parseSVGValue):
3288         (WebCore::CSSParser::parseSVGPaint):
3289         * ksvg2/css/SVGRenderStyleDefs.cpp:
3290         (StyleFillData::operator==):
3291         * ksvg2/ksvg.h:
3292         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3293         (WebCore::KSVGPainterFactory::isFilled):
3294         (WebCore::KSVGPainterFactory::fillPaintServer):
3295         (WebCore::KSVGPainterFactory::isStroked):
3296         (WebCore::KSVGPainterFactory::strokePaintServer):
3297         * ksvg2/misc/KSVGTimeScheduler.cpp:
3298         (WebCore::SVGTimer::notifyAll):
3299         * ksvg2/svg/SVGAnimateColorElement.cpp:
3300         (WebCore::SVGAnimateColorElement::handleTimerEvent):
3301         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3302         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
3303         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
3304         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3305         (WebCore::SVGAnimateTransformElement::parseTransformValue):
3306         * ksvg2/svg/SVGAnimateTransformElement.h:
3307         * ksvg2/svg/SVGAnimatedTemplate.h:
3308         * ksvg2/svg/SVGAnimationElement.cpp:
3309         (SVGAnimationElement::getSimpleDuration):
3310         (SVGAnimationElement::parseMappedAttribute):
3311         (SVGAnimationElement::setTargetAttribute):
3312         * ksvg2/svg/SVGAnimationElement.h:
3313         * ksvg2/svg/SVGClipPathElement.cpp:
3314         (SVGClipPathElement::SVGClipPathElement):
3315         (SVGClipPathElement::parseMappedAttribute):
3316         (SVGClipPathElement::canvasResource):
3317         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3318         (SVGComponentTransferFunctionElement::transferFunction):
3319         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
3320         (WebCore::SVGComponentTransferFunctionElement::):
3321         * ksvg2/svg/SVGDocument.cpp:
3322         (WebCore::SVGDocument::dispatchZoomEvent):
3323         (WebCore::SVGDocument::dispatchScrollEvent):
3324         * ksvg2/svg/SVGFEBlendElement.cpp:
3325         (WebCore::SVGFEBlendElement::parseMappedAttribute):
3326         (WebCore::SVGFEBlendElement::filterEffect):
3327         * ksvg2/svg/SVGFEBlendElement.h:
3328         (WebCore::SVGFEBlendElement::):
3329         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3330         (SVGFEColorMatrixElement::parseMappedAttribute):
3331         (SVGFEColorMatrixElement::filterEffect):
3332         * ksvg2/svg/SVGFEColorMatrixElement.h:
3333         (WebCore::SVGFEColorMatrixElement::):
3334         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3335         (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
3336         (WebCore::SVGFEComponentTransferElement::filterEffect):
3337         * ksvg2/svg/SVGFEComponentTransferElement.h:
3338         * ksvg2/svg/SVGFECompositeElement.cpp:
3339         (SVGFECompositeElement::parseMappedAttribute):
3340         (SVGFECompositeElement::filterEffect):
3341         * ksvg2/svg/SVGFECompositeElement.h:
3342         (WebCore::SVGFECompositeElement::):
3343         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3344         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3345         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
3346         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
3347         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3348         (SVGFEDisplacementMapElement::parseMappedAttribute):
3349         (SVGFEDisplacementMapElement::filterEffect):
3350         * ksvg2/svg/SVGFEDisplacementMapElement.h:
3351         (WebCore::SVGFEDisplacementMapElement::):
3352         * ksvg2/svg/SVGFEFloodElement.cpp:
3353         (WebCore::SVGFEFloodElement::parseMappedAttribute):
3354         (WebCore::SVGFEFloodElement::filterEffect):
3355         * ksvg2/svg/SVGFEFloodElement.h:
3356         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3357         (SVGFEGaussianBlurElement::parseMappedAttribute):
3358         (SVGFEGaussianBlurElement::filterEffect):
3359         * ksvg2/svg/SVGFEGaussianBlurElement.h:
3360         * ksvg2/svg/SVGFEMergeElement.cpp:
3361         (SVGFEMergeElement::filterEffect):
3362         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
3363         (SVGFEMergeNodeElement::parseMappedAttribute):
3364         * ksvg2/svg/SVGFEMergeNodeElement.h:
3365         * ksvg2/svg/SVGFEOffsetElement.cpp:
3366         (SVGFEOffsetElement::parseMappedAttribute):
3367         (SVGFEOffsetElement::filterEffect):
3368         * ksvg2/svg/SVGFEOffsetElement.h:
3369         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3370         (SVGFESpecularLightingElement::parseMappedAttribute):
3371         (SVGFESpecularLightingElement::filterEffect):
3372         * ksvg2/svg/SVGFESpecularLightingElement.h:
3373         * ksvg2/svg/SVGFETileElement.cpp:
3374         (WebCore::SVGFETileElement::parseMappedAttribute):
3375         (WebCore::SVGFETileElement::filterEffect):
3376         * ksvg2/svg/SVGFETileElement.h:
3377         * ksvg2/svg/SVGFETurbulenceElement.h:
3378         (WebCore::SVGFETurbulenceElement::):
3379         * ksvg2/svg/SVGFilterElement.cpp:
3380         (SVGFilterElement::SVGFilterElement):
3381         (SVGFilterElement::parseMappedAttribute):
3382         (SVGFilterElement::canvasResource):
3383         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
3384         (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
3385         * ksvg2/svg/SVGGradientElement.cpp:
3386         (SVGGradientElement::SVGGradientElement):
3387         (SVGGradientElement::parseMappedAttribute):
3388         * ksvg2/svg/SVGGradientElement.h:
3389         (WebCore::SVGGradientElement::):
3390         * ksvg2/svg/SVGHelper.cpp:
3391         (WebCore::SVGHelper::ParseSeperatedList):
3392         * ksvg2/svg/SVGLengthList.cpp:
3393         (WebCore::SVGLengthList::parse):
3394         * ksvg2/svg/SVGLinearGradientElement.cpp:
3395         (SVGLinearGradientElement::buildGradient):
3396         * ksvg2/svg/SVGList.h:
3397         (WebCore::SVGListBase::clear):
3398         (WebCore::SVGListBase::initialize):
3399         (WebCore::SVGListBase::getItem):
3400         (WebCore::SVGListBase::insertItemBefore):
3401         (WebCore::SVGListBase::replaceItem):
3402         (WebCore::SVGListBase::removeItem):
3403         (WebCore::SVGListBase::appendItem):
3404         * ksvg2/svg/SVGLocatable.cpp:
3405         * ksvg2/svg/SVGLocatable.h:
3406         * ksvg2/svg/SVGMarkerElement.h:
3407         (WebCore::SVGMarkerElement::):
3408         * ksvg2/svg/SVGNumberList.cpp:
3409         (SVGNumberList::parse):
3410         * ksvg2/svg/SVGPaint.cpp:
3411         (WebCore::SVGPaint::SVGPaint):
3412         (WebCore::SVGPaint::uri):
3413         (WebCore::SVGPaint::setUri):
3414         (WebCore::SVGPaint::setPaint):
3415         * ksvg2/svg/SVGPaint.h:
3416         (WebCore::SVGPaint::):
3417         * ksvg2/svg/SVGPathElement.cpp:
3418         (WebCore::SVGPathElement::svgMoveTo):
3419         (WebCore::SVGPathElement::svgLineTo):
3420         (WebCore::SVGPathElement::svgLineToHorizontal):
3421         (WebCore::SVGPathElement::svgLineToVertical):
3422         (WebCore::SVGPathElement::svgCurveToCubic):
3423         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
3424         (WebCore::SVGPathElement::svgCurveToQuadratic):
3425         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
3426         (WebCore::SVGPathElement::svgArcTo):
3427         (WebCore::SVGPathElement::svgClosePath):
3428         (WebCore::SVGPathElement::parseMappedAttribute):
3429         (WebCore::SVGPathElement::toPathData):
3430         * ksvg2/svg/SVGPatternElement.cpp:
3431         (WebCore::SVGPatternElement::SVGPatternElement):
3432         (WebCore::SVGPatternElement::parseMappedAttribute):
3433         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3434         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3435         * ksvg2/svg/SVGPolyElement.cpp:
3436         (SVGPolyElement::parseMappedAttribute):
3437         (SVGPolyElement::svgPolyTo):
3438         (SVGPolyElement::notifyAttributeChange):
3439         * ksvg2/svg/SVGPolygonElement.cpp:
3440         (SVGPolygonElement::toPathData):
3441         * ksvg2/svg/SVGPolylineElement.cpp:
3442         (SVGPolylineElement::toPathData):
3443         * ksvg2/svg/SVGRadialGradientElement.cpp:
3444         (WebCore::SVGRadialGradientElement::buildGradient):
3445         * ksvg2/svg/SVGRenderingIntent.h: Added.
3446         (WebCore::SVGRenderingIntent::):
3447         (WebCore::SVGRenderingIntent::SVGRenderingIntent):
3448         (WebCore::SVGRenderingIntent::~SVGRenderingIntent):
3449         * ksvg2/svg/SVGSVGElement.h:
3450         (WebCore::SVGSVGElement::):
3451         * ksvg2/svg/SVGScriptElement.cpp:
3452         (WebCore::SVGScriptElement::type):
3453         (WebCore::SVGScriptElement::setType):
3454         (WebCore::SVGScriptElement::parseMappedAttribute):
3455         * ksvg2/svg/SVGScriptElement.h:
3456         * ksvg2/svg/SVGStringList.cpp:
3457         (WebCore::SVGStringList::reset):
3458         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3459         (SVGStyledLocatableElement::getTransformToElement):
3460         * ksvg2/svg/SVGStyledLocatableElement.h:
3461         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3462         (SVGStyledTransformableElement::parseMappedAttribute):
3463         (SVGStyledTransformableElement::getTransformToElement):
3464         * ksvg2/svg/SVGStyledTransformableElement.h:
3465         * ksvg2/svg/SVGTests.cpp:
3466         (WebCore::SVGTests::hasExtension):
3467         (WebCore::SVGTests::isValid):
3468         * ksvg2/svg/SVGTests.h:
3469         * ksvg2/svg/SVGTextContentElement.cpp:
3470         (SVGTextContentElement::getSubStringLength):
3471         (SVGTextContentElement::getStartPositionOfChar):
3472         (SVGTextContentElement::getEndPositionOfChar):
3473         (SVGTextContentElement::getExtentOfChar):
3474         (SVGTextContentElement::getRotationOfChar):
3475         (SVGTextContentElement::selectSubString):
3476         * ksvg2/svg/SVGTextContentElement.h:
3477         (WebCore::SVGTextContentElement::):
3478         * ksvg2/svg/SVGTextElement.cpp:
3479         (WebCore::SVGTextElement::parseMappedAttribute):
3480         * ksvg2/svg/SVGTextElement.h:
3481         (WebCore::SVGTextElement::getTransformToElement):
3482         * ksvg2/svg/SVGTransform.h:
3483         * ksvg2/svg/SVGTransformList.cpp:
3484         (SVGTransformList::consolidate):
3485         (SVGTransformList::concatenate):
3486         * ksvg2/svg/SVGTransformable.cpp:
3487         (SVGTransformable::parseTransformAttribute):
3488         * ksvg2/svg/SVGUnitTypes.h: Added.
3489         (WebCore::SVGUnitTypes::):
3490         (WebCore::SVGUnitTypes::SVGUnitTypes):
3491         (WebCore::SVGUnitTypes::~SVGUnitTypes):
3492         * ksvg2/svg/SVGUseElement.cpp:
3493         (SVGUseElement::closeRenderer):
3494         * ksvg2/svg/SVGViewElement.h:
3495         (WebCore::SVGViewElement::):
3496         * ksvg2/svg/SVGZoomAndPan.cpp:
3497         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
3498         (WebCore::SVGZoomAndPan::parseMappedAttribute):
3499
3500 2006-09-12  John Sullivan  <sullivan@apple.com>
3501
3502         Reviewed by Adele Peterson.
3503
3504         * bridge/mac/FrameMac.mm:
3505         (WebCore::FrameMac::doTextFieldCommandFromEvent):
3506         Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a
3507         (valid) assertion failure in some Safari code.
3508
3509 2006-09-12  David Harrison  <harrison@apple.com>
3510
3511         Reviewed by John Sullivan.
3512
3513         <rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field
3514
3515         * bridge/mac/WebCoreAXObject.mm:
3516         (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
3517         For AXFocus, use focus() if the node is an element, so that selection is set.
3518         Matches tabbing behavior in text fields and text areas.
3519
3520 2006-09-12  Adam Roben  <aroben@apple.com>
3521
3522         Reviewed by adele.
3523
3524         Make uploading work with the new file upload control.
3525
3526         * css/html4.css: Remove unnecessary style (this is already done in
3527         RenderFileUpload.cpp)
3528         * html/HTMLInputElement.cpp: Don't get the button text from the value
3529         attribute for file controls.
3530         (WebCore::HTMLInputElement::valueWithDefault):
3531         * platform/mac/FileChooserMac.mm: Call
3532         RenderFileUploadControl::valueChanged when the user selects a file.
3533         (WebCore::FileChooser::chooseFile):
3534         * rendering/RenderFileUploadControl.cpp: Add valueChanged() method to
3535         update the form and fire the onChange event.
3536         (WebCore::RenderFileUploadControl::valueChanged):
3537         (WebCore::RenderFileUploadControl::updateFromElement):
3538         * rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
3539
3540 2006-09-12  Adam Roben  <aroben@apple.com>
3541
3542         Adding rules to html4.css to style the button in file upload controls.
3543
3544         * css/html4.css:
3545
3546 2006-09-12  Adam Roben  <aroben@apple.com>
3547
3548         Reviewed many times by darin, hyatt.
3549
3550         Switch to new engine-based implementation of <input type="file">
3551
3552         * WebCore.exp: Remove obsolete symbol WebCoreFileButton
3553         * WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based
3554         control, add files for new engine-based control
3555         * css/CSSSelector.cpp: Add support for new
3556         '-webkit-file-upload-button' pseudo element
3557         (WebCore::CSSSelector::extractPseudoType):
3558         * css/CSSSelector.h: Ditto.
3559         (WebCore::CSSSelector::):
3560         * css/cssstyleselector.cpp: Ditto.
3561         (WebCore::CSSStyleSelector::checkOneSelector):
3562         * html/HTMLInputElement.cpp: Send click events to new control
3563         (WebCore::HTMLInputElement::select):
3564         (WebCore::HTMLInputElement::click):
3565         (WebCore::HTMLInputElement::createRenderer):
3566         (WebCore::HTMLInputElement::valueWithDefault):
3567         (WebCore::HTMLInputElement::defaultEventHandler):
3568         * html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword
3569         (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
3570         * platform/FileButton.h: Removed.
3571         * platform/FileChooser.h: Added. This is the replacement for
3572         FileButton.h
3573         (WebCore::FileChooser::filename):
3574         (WebCore::FileChooser::icon):
3575         (WebCore::FileChooser::uploadControl):
3576         (WebCore::FileChooser::document):
3577         * platform/Icon.h: Added new platform-specific class representing a
3578         file icon.
3579         * platform/LocalizedStrings.h:
3580         * platform/mac/FileButtonMac.mm: Removed.
3581         * platform/mac/FileChooserMac.mm: Added. This is the replacement for
3582         FileButtonMac.mm
3583         (-[OpenPanelController initWithFileChooser:]):
3584         (-[OpenPanelController fileChooserDetachingSoon]):
3585         (-[OpenPanelController beginSheet]):
3586         (-[OpenPanelController chooseFilename:]):
3587         (-[OpenPanelController cancel]):
3588         (WebCore::FileChooser::FileChooser):
3589         (WebCore::FileChooser::~FileChooser):
3590         (WebCore::FileChooser::openFileChooser):
3591         (WebCore::FileChooser::basenameForWidth):
3592         (WebCore::FileChooser::uploadControlDetaching):
3593         (WebCore::FileChooser::chooseFile):
3594         * platform/mac/IconMac.mm: Added.
3595         (WebCore::Icon::Icon):
3596         (WebCore::Icon::~Icon):
3597         (WebCore::Icon::newIconForFile):
3598         (WebCore::Icon::paint):
3599         * platform/mac/LocalizedStringsMac.mm: Call across bridge to get
3600         localized strings.
3601         (WebCore::fileButtonChooseFileLabel):
3602         (WebCore::fileButtonNoFileSelectedLabel):
3603         * rendering/RenderButton.cpp: Extract method setText() from
3604         updateFromElement.
3605         (WebCore::RenderButton::updateFromElement):
3606         (WebCore::RenderButton::setText):
3607         * rendering/RenderButton.h: Add declaration for new setText method.
3608         * rendering/RenderFileButton.cpp: Removed.
3609         * rendering/RenderFileButton.h: Removed.