WebCore/ChangeLog

   1 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
   2
   3         Reviewed by Maciej.
   4
   5         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.
   6         * loader/loader.cpp:
   7         (WebCore::Loader::servePendingRequests):
   8
   9 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
  10
  11         Reviewed by Darin.
  12
  13         Convert a bunch of RefPtr<StringImpl> to String.
  14
  15         * bridge/mac/FrameMac.h:
  16         * bridge/mac/FrameMac.mm:
  17         (WebCore::FrameMac::didTellBridgeAboutLoad):
  18         (WebCore::FrameMac::haveToldBridgeAboutLoad):
  19         * dom/BeforeUnloadEvent.cpp:
  20         (WebCore::BeforeUnloadEvent::storeResult):
  21         * dom/BeforeUnloadEvent.h:
  22         (WebCore::BeforeUnloadEvent::result):
  23         * dom/Document.cpp:
  24         (WebCore::Document::createEntityReference):
  25         * dom/Entity.cpp:
  26         (WebCore::Entity::Entity):
  27         (WebCore::Entity::nodeName):
  28         (WebCore::Entity::toString):
  29         * dom/Entity.h:
  30         (WebCore::Entity::publicId):
  31         (WebCore::Entity::systemId):
  32         (WebCore::Entity::notationName):
  33         * dom/EntityReference.cpp:
  34         (WebCore::EntityReference::EntityReference):
  35         (WebCore::EntityReference::nodeName):
  36         (WebCore::EntityReference::cloneNode):
  37         (WebCore::EntityReference::toString):
  38         * dom/EntityReference.h:
  39         * dom/KeyboardEvent.cpp:
  40         (WebCore::KeyboardEvent::KeyboardEvent):
  41         (WebCore::KeyboardEvent::initKeyboardEvent):
  42         * dom/KeyboardEvent.h:
  43         (WebCore::KeyboardEvent::keyIdentifier):
  44         * dom/MutationEvent.cpp:
  45         (WebCore::MutationEvent::MutationEvent):
  46         (WebCore::MutationEvent::initMutationEvent):
  47         * dom/MutationEvent.h:
  48         (WebCore::MutationEvent::prevValue):
  49         (WebCore::MutationEvent::newValue):
  50         (WebCore::MutationEvent::attrName):
  51         * dom/Notation.cpp:
  52         (WebCore::Notation::Notation):
  53         (WebCore::Notation::nodeName):
  54         * dom/Notation.h:
  55         (WebCore::Notation::publicId):
  56         (WebCore::Notation::systemId):
  57         * dom/ProcessingInstruction.cpp:
  58         (WebCore::ProcessingInstruction::ProcessingInstruction):
  59         (WebCore::ProcessingInstruction::setData):
  60         (WebCore::ProcessingInstruction::nodeName):
  61         (WebCore::ProcessingInstruction::nodeValue):
  62         (WebCore::ProcessingInstruction::cloneNode):
  63         (WebCore::ProcessingInstruction::checkStyleSheet):
  64         (WebCore::ProcessingInstruction::toString):
  65         * dom/ProcessingInstruction.h:
  66         (WebCore::ProcessingInstruction::target):
  67         (WebCore::ProcessingInstruction::data):
  68         (WebCore::ProcessingInstruction::localHref):
  69
  70 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
  71
  72         Reviewed by Tim H.
  73
  74         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
  75         10 more SVG Objective-C auto-generated bindings
  76
  77         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox,
  78           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
  79           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement,
  80           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
  81
  82         - Auto-generate the text method for DOMRange.
  83
  84         * DerivedSources.make:
  85         * WebCore.xcodeproj/project.pbxproj:
  86         * bindings/objc/DOM.mm:
  87         * bindings/objc/DOMExtensions.h:
  88         * bindings/objc/DOMInternal.h:
  89         * bindings/objc/DOMPrivate.h:
  90         * bindings/objc/DOMRGBColor.mm:
  91         * bindings/objc/DOMSVG.h:
  92         * bindings/objc/PublicDOMInterfaces.h:
  93         * bindings/scripts/CodeGeneratorObjC.pm:
  94         * dom/Range.idl:
  95         * ksvg2/svg/SVGFilterElement.cpp:
  96         * ksvg2/svg/SVGFilterElement.h:
  97         * ksvg2/svg/SVGFilterElement.idl:
  98         * ksvg2/svg/SVGForeignObjectElement.idl:
  99         * ksvg2/svg/SVGGElement.idl:
 100         * ksvg2/svg/SVGGradientElement.idl:
 101         * ksvg2/svg/SVGImageElement.idl:
 102         * ksvg2/svg/SVGLineElement.idl:
 103         * ksvg2/svg/SVGLinearGradientElement.idl:
 104         * ksvg2/svg/SVGMarkerElement.idl:
 105         * ksvg2/svg/SVGMaskElement.idl:
 106         * ksvg2/svg/SVGPaint.idl:
 107
 108 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
 109
 110         Reviewed by Tim H.
 111
 112         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
 113         Auto-generate a few more Objective-C DOM interfaces
 114
 115         - Fully auto-generate DOMAbstractView and DOMRange.
 116
 117         - Auto-generate just the interface for DOMRGBColor.
 118
 119         - Add DOMRanges.h as the new top level file for Ranges
 120           module.
 121
 122         - Add DOMRanges.h and DOMXPath.h to DOM.mm
 123
 124         * DerivedSources.make:
 125         * WebCore.xcodeproj/project.pbxproj:
 126         * bindings/objc/DOM.h:
 127         * bindings/objc/DOM.mm:
 128         * bindings/objc/DOMAbstractView.h: Removed.
 129         * bindings/objc/DOMAbstractView.mm: Removed.
 130         * bindings/objc/DOMInternal.h:
 131         * bindings/objc/DOMPrivate.h:
 132         * bindings/objc/DOMRGBColor.h: Removed.
 133         * bindings/objc/DOMRGBColor.mm:
 134         * bindings/objc/DOMRange.h: Removed.
 135         * bindings/objc/DOMRanges.h: Added.
 136         * bindings/objc/PublicDOMInterfaces.h:
 137         * bindings/scripts/CodeGeneratorObjC.pm:
 138         * css/RGBColor.idl:
 139         * dom/Range.idl:
 140         * page/AbstractView.idl: Added.
 141
 142 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
 143
 144         Reviewed by Eric.
 145
 146         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
 147         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
 148
 149         Return null when there is no frame. This matches Firefox.
 150
 151         * bindings/js/kjs_html.cpp:
 152         (KJS::JSHTMLDocument::getValueProperty):
 153
 154 2006-10-07  David Hyatt  <hyatt@apple.com>
 155
 156         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
 157         scrollbar joins properly.
 158
 159         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
 160         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
 161
 162         Reviewed by mitz
 163
 164         * page/FrameView.cpp:
 165         (WebCore::selectCursor):
 166         (WebCore::FrameView::handleMouseMoveEvent):
 167         * platform/mac/PlatformScrollBar.h:
 168         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
 169         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
 170         * rendering/RenderLayer.cpp:
 171         (WebCore::RenderLayer::RenderLayer):
 172         (WebCore::RenderLayer::~RenderLayer):
 173         (WebCore::RenderLayer::updateLayerPositions):
 174         (WebCore::scrollCornerRect):
 175         (WebCore::RenderLayer::positionOverflowControls):
 176         (WebCore::RenderLayer::paintOverflowControls):
 177         (WebCore::RenderLayer::isPointInResizeControl):
 178         (WebCore::RenderLayer::paintLayer):
 179         * rendering/RenderLayer.h:
 180
 181 2006-10-07  Mark Rowe  <bdash@webkit.org>
 182
 183         Reviewed by Mitz.
 184
 185         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
 186         matching recent ResourceLoader changes.
 187
 188         * platform/gdk/FrameGdk.cpp:
 189         (WebCore::FrameGdk::openURL):
 190         (WebCore::FrameGdk::urlSelected):
 191         * platform/gdk/PlatformScrollBar.h:
 192         * platform/gdk/ResourceLoaderCurl.cpp:
 193         (WebCore::ResourceLoader::start):
 194         * platform/gdk/ScrollViewGdk.cpp:
 195         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
 196         (WebCore::ScrollView::resizeContents):
 197         (WebCore::ScrollView::scrollBy):
 198         (WebCore::ScrollView::hScrollbarMode):
 199         (WebCore::ScrollView::vScrollbarMode):
 200         (WebCore::ScrollView::suppressScrollbars):
 201         (WebCore::ScrollView::setHScrollbarMode):
 202         (WebCore::ScrollView::setVScrollbarMode):
 203         (WebCore::ScrollView::setScrollbarsMode):
 204         * platform/gdk/TemporaryLinkStubs.cpp:
 205         (FrameView::passMousePressEventToScrollbar):
 206         (Widget::removeFromParent):
 207         (ScrollView::addChild):
 208         (ScrollView::updateScrollbars):
 209         (ScrollView::scrollbarUnderMouse):
 210         (PlatformScrollbar::PlatformScrollbar):
 211         (PlatformScrollbar::~PlatformScrollbar):
 212         (PlatformScrollbar::width):
 213         (PlatformScrollbar::height):
 214         (PlatformScrollbar::setEnabled):
 215         (PlatformScrollbar::paint):
 216         (PlatformScrollbar::updateThumbPosition):
 217         (PlatformScrollbar::updateThumbProportion):
 218         (PlatformScrollbar::setRect):
 219         (Scrollbar::Scrollbar):
 220         (Scrollbar::setSteps):
 221         (Scrollbar::scroll):
 222         (Scrollbar::setValue):
 223         (Scrollbar::setProportion):
 224
 225 2006-10-06  Dave Hyatt  <hyatt@apple.com>
 226
 227         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
 228
 229         * page/FrameView.cpp:
 230         (WebCore::FrameView::windowClipRect):
 231         * page/FrameView.h:
 232         * platform/ScrollView.h:
 233         * platform/Widget.cpp:
 234         (WebCore::Widget::windowClipRect):
 235         * platform/Widget.h:
 236         (WebCore::Widget::geometryChanged):
 237         (WebCore::Widget::handleMouseMoveEvent):
 238         (WebCore::Widget::handleMouseReleaseEvent):
 239         * platform/mac/ScrollViewMac.mm:
 240         (WebCore::ScrollView::addChild):
 241         * rendering/RenderLayer.cpp:
 242         (WebCore::RenderLayer::documentClipRect):
 243         * rendering/RenderLayer.h:
 244
 245 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
 246
 247         Reviewed by Adam.
 248
 249         Add another method we'll need for scrollbar dodging
 250
 251         * platform/ScrollView.h:
 252         * platform/win/TemporaryLinkStubs.cpp:
 253         (ScrollView::resizerOverlapsContent):
 254
 255 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
 256
 257         Reviewed by Tim H.
 258
 259         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
 260         Auto-generate the interfaces even for Objective-C DOM
 261         bindings that need custom implementations
 262
 263         - Fully auto-generate DOMEventTarget, DOMNodeFilter and
 264           DOMHTMLOptionElement.
 265
 266         - Auto-generate just the interface for DOMHTMLAppletElement,
 267           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
 268           using the new IDL property ObjCCustomImplementation.
 269
 270         * DerivedSources.make:
 271         * WebCore.xcodeproj/project.pbxproj:
 272         * bindings/objc/DOMEventTarget.h: Removed.
 273         * bindings/objc/DOMHTMLAppletElement.h: Removed.
 274         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
 275         * bindings/objc/DOMHTMLOptionElement.h: Removed.
 276         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
 277         * bindings/objc/DOMInternal.h:
 278         * bindings/objc/DOMNodeFilter.h: Removed.
 279         * bindings/objc/DOMSVGNumber.h: Removed.
 280         * bindings/objc/DOMSVGPoint.h: Removed.
 281         * bindings/objc/DOMSVGPoint.mm:
 282         (-[DOMSVGPoint matrixTransform:]):
 283         * bindings/objc/DOMSVGRect.h: Removed.
 284         * bindings/objc/PublicDOMInterfaces.h:
 285         * bindings/scripts/CodeGeneratorObjC.pm:
 286         * dom/EventTarget.idl:
 287         * html/HTMLAppletElement.idl:
 288         * html/HTMLEmbedElement.idl:
 289         * html/HTMLOptionElement.idl:
 290         * ksvg2/svg/SVGNumber.idl:
 291         * ksvg2/svg/SVGPoint.idl:
 292         * ksvg2/svg/SVGRect.idl:
 293
 294 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
 295
 296         Reviewed by Tim H.
 297
 298         Make Qt/Linux compile again completly.
 299
 300         * platform/qt/WidgetQt.cpp:
 301         (WebCore::Widget::removeFromParent):
 302
 303 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
 304
 305         Reviewed by Tim H.
 306
 307         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
 308
 309         * platform/qt/PlatformScrollBar.h:
 310         * platform/qt/ScrollViewQt.cpp:
 311         (WebCore::ScrollView::hScrollbarMode):
 312         (WebCore::ScrollView::vScrollbarMode):
 313         (WebCore::ScrollView::suppressScrollbars):
 314         (WebCore::ScrollView::setHScrollbarMode):
 315         (WebCore::ScrollView::setVScrollbarMode):
 316         (WebCore::ScrollView::setScrollbarsMode):
 317         (WebCore::ScrollView::scrollbarUnderMouse):
 318         * platform/qt/TemporaryLinkStubs.cpp:
 319         (WebCore::Scrollbar::Scrollbar):
 320         (WebCore::Scrollbar::setSteps):
 321         (WebCore::Scrollbar::scroll):
 322         (WebCore::Scrollbar::setValue):
 323         (WebCore::Scrollbar::setProportion):
 324         (WebCore::PlatformScrollbar::PlatformScrollbar):
 325         (WebCore::PlatformScrollbar::~PlatformScrollbar):
 326         (WebCore::PlatformScrollbar::width):
 327         (WebCore::PlatformScrollbar::height):
 328         (WebCore::PlatformScrollbar::setEnabled):
 329         (WebCore::PlatformScrollbar::paint):
 330         (WebCore::PlatformScrollbar::updateThumbPosition):
 331         (WebCore::PlatformScrollbar::updateThumbProportion):
 332         (WebCore::PlatformScrollbar::setRect):
 333         (FrameView::passMousePressEventToScrollbar):
 334
 335 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
 336
 337         Reviewed by Tim H.
 338
 339         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
 340         Another round of Objective-C SVG DOM bindings auto-generation
 341
 342         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect,
 343           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement,
 344           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement,
 345           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
 346           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement,
 347           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement,
 348           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement,
 349           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement,
 350           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement,
 351           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement,
 352           DOMSVGFETileElement, DOMSVGFETurbulenceElement,
 353           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
 354
 355         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
 356           and DOMSVGRect.
 357
 358         - IDL clean up.
 359
 360         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
 361           in it's macro declaration and definition.
 362
 363         * DerivedSources.make:
 364         * WebCore.xcodeproj/project.pbxproj:
 365         * bindings/objc/DOMCSS.mm:
 366         (+[DOMCSSValue _CSSValueWith:WebCore::]):
 367         * bindings/objc/DOMInternal.h:
 368         * bindings/objc/DOMSVG.h:
 369         * bindings/objc/DOMSVGNumber.h: Added.
 370         * bindings/objc/DOMSVGNumber.mm: Added.
 371         (-[DOMSVGNumber dealloc]):
 372         (-[DOMSVGNumber finalize]):
 373         (-[DOMSVGNumber value]):
 374         (-[DOMSVGNumber setValue:]):
 375         (-[DOMSVGNumber _SVGNumber]):
 376         (-[DOMSVGNumber _initWithFloat:]):
 377         (+[DOMSVGNumber _SVGNumberWith:]):
 378         * bindings/objc/DOMSVGPoint.h: Added.
 379         * bindings/objc/DOMSVGPoint.mm: Added.
 380         (-[DOMSVGPoint dealloc]):
 381         (-[DOMSVGPoint finalize]):
 382         (-[DOMSVGPoint x]):
 383         (-[DOMSVGPoint setX:]):
 384         (-[DOMSVGPoint y]):
 385         (-[DOMSVGPoint setY:]):
 386         (-[DOMSVGPoint WebCore::]):
 387         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
 388         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
 389         * bindings/objc/DOMSVGRect.h: Added.
 390         * bindings/objc/DOMSVGRect.mm: Added.
 391         (-[DOMSVGRect dealloc]):
 392         (-[DOMSVGRect finalize]):
 393         (-[DOMSVGRect x]):
 394         (-[DOMSVGRect setX:]):
 395         (-[DOMSVGRect y]):
 396         (-[DOMSVGRect setY:]):
 397         (-[DOMSVGRect width]):
 398         (-[DOMSVGRect setWidth:]):
 399         (-[DOMSVGRect height]):
 400         (-[DOMSVGRect setHeight:]):
 401         (-[DOMSVGRect WebCore::]):
 402         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
 403         (+[DOMSVGRect _SVGRectWith:WebCore::]):
 404         * bindings/scripts/CodeGeneratorObjC.pm:
 405         * ksvg2/svg/SVGAnimatedNumberList.idl:
 406         * ksvg2/svg/SVGAnimatedRect.idl:
 407         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
 408         * ksvg2/svg/SVGCursorElement.idl:
 409         * ksvg2/svg/SVGFEBlendElement.idl:
 410         * ksvg2/svg/SVGFEColorMatrixElement.idl:
 411         * ksvg2/svg/SVGFEComponentTransferElement.idl:
 412         * ksvg2/svg/SVGFECompositeElement.idl:
 413         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
 414         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
 415         * ksvg2/svg/SVGFEDistantLightElement.idl:
 416         * ksvg2/svg/SVGFEFloodElement.idl:
 417         * ksvg2/svg/SVGFEFuncAElement.idl:
 418         * ksvg2/svg/SVGFEFuncBElement.idl:
 419         * ksvg2/svg/SVGFEFuncGElement.idl:
 420         * ksvg2/svg/SVGFEFuncRElement.idl:
 421         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
 422         * ksvg2/svg/SVGFEImageElement.idl:
 423         * ksvg2/svg/SVGFEMergeElement.idl:
 424         * ksvg2/svg/SVGFEMergeNodeElement.idl:
 425         * ksvg2/svg/SVGFEOffsetElement.idl:
 426         * ksvg2/svg/SVGFEPointLightElement.idl:
 427         * ksvg2/svg/SVGFESpecularLightingElement.idl:
 428         * ksvg2/svg/SVGFESpotLightElement.idl:
 429         * ksvg2/svg/SVGFETileElement.idl:
 430         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 431         * ksvg2/svg/SVGFETurbulenceElement.h:
 432         * ksvg2/svg/SVGFETurbulenceElement.idl:
 433         * ksvg2/svg/SVGNumberList.idl:
 434
 435 2006-10-06  Adam Roben  <aroben@apple.com>
 436
 437         Backing out my previous change.
 438
 439         * WebCore.xcodeproj/project.pbxproj:
 440         * page/FrameView.cpp:
 441         (WebCore::FrameView::adjustViewSize):
 442
 443 2006-10-06  Adam Roben  <aroben@apple.com>
 444
 445         Build fix.
 446
 447         * WebCore.xcodeproj/project.pbxproj:
 448         * page/FrameView.cpp:
 449         (WebCore::FrameView::windowResizerRect):
 450
 451 2006-10-06  Adam Roben  <aroben@apple.com>
 452
 453         Reviewed by Maciej.
 454
 455         More loader tweaks.
 456
 457         * platform/ResourceLoader.h:
 458         * platform/ResourceLoaderInternal.h:
 459         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 460         * platform/win/TemporaryLinkStubs.cpp:
 461         (WebCore::ResourceLoader::newHTTPRequest):
 462
 463 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
 464
 465         Reviewed by aroben.
 466
 467         Stub out some methods that we'll be able to use to dodge a window resizer.
 468
 469         * bridge/win/FrameWin.h:
 470         * page/Frame.h:
 471         (WebCore::Frame::windowResizerRect):
 472         * page/FrameView.h:
 473         * platform/ScrollView.h:
 474         (WebCore::ScrollView::windowResizerRect):
 475         * platform/Widget.h:
 476         * platform/win/TemporaryLinkStubs.cpp:
 477         (FrameView::windowResizerRect):
 478         (Widget::setParent):
 479         (Widget::parent):
 480         (FrameWin::windowResizerRect):
 481
 482 2006-10-05  Dave Hyatt  <hyatt@apple.com>
 483
 484         Stub out setFrameGeometry.
 485
 486         * platform/ScrollView.h:
 487
 488 2006-10-05  Adele Peterson  <adele@apple.com>
 489
 490         Reverting autoscroll fix.  I need to rework this a little.
 491
 492         * page/Frame.cpp:
 493         (WebCore::Frame::handleAutoscroll):
 494         (WebCore::Frame::autoscrollTimerFired):
 495         (WebCore::Frame::stopAutoscrollTimer):
 496         * page/Frame.h:
 497         * rendering/RenderLayer.cpp:
 498         (WebCore::RenderLayer::~RenderLayer):
 499         * rendering/RenderListBox.cpp:
 500         (WebCore::RenderListBox::~RenderListBox):
 501
 502 2006-10-05  Alice  <alice.liu@apple.com>
 503
 504         Reviewed by Adam.
 505
 506         Fixed <rdar://problem/4731778>
 507
 508         * editing/CommandByName.cpp:
 509         (WebCore::Frame::Command::):
 510         was calling the wrong enabledFn for arrow selection and navigation
 511
 512 2006-10-05  Adele Peterson  <adele@apple.com>
 513
 514         Reviewed by Maciej.
 515
 516         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
 517           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
 518
 519         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
 520         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
 521
 522         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
 523         (WebCore::Frame::handleAutoscroll):
 524         (WebCore::Frame::autoscrollTimerFired):
 525         (WebCore::Frame::autoscrollRenderer):
 526         (WebCore::Frame::setAutoscrollRenderer):
 527         (WebCore::Frame::stopAutoscrollTimer):
 528         * page/Frame.h:
 529
 530 2006-10-05  Don Gibson  <dgibson77@gmail.com>
 531
 532         Reviewed by Eric.
 533
 534         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
 535         Properly include PlatformScrollBar.h in WbCore.vcproj.
 536         Clean up WidgetWin.cpp a bit.
 537
 538         * WebCore.vcproj/WebCore/WebCore.vcproj:
 539         * platform/Widget.h:
 540         * platform/win/PlatformScrollBar.h:
 541         * platform/win/ScrollViewWin.cpp:
 542         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
 543         (WebCore::ScrollView::resizeContents):
 544         (WebCore::ScrollView::scrollBy):
 545         (WebCore::ScrollView::hScrollbarMode):
 546         (WebCore::ScrollView::vScrollbarMode):
 547         (WebCore::ScrollView::suppressScrollbars):
 548         (WebCore::ScrollView::setHScrollbarMode):
 549         (WebCore::ScrollView::setVScrollbarMode):
 550         (WebCore::ScrollView::setScrollbarsMode):
 551         (WebCore::ScrollView::updateScrollbars):
 552         * platform/win/TemporaryLinkStubs.cpp:
 553         (FrameView::passMousePressEventToScrollbar):
 554         (Widget::removeFromParent):
 555         (ScrollView::scrollbarUnderMouse):
 556         (PlatformScrollbar::PlatformScrollbar):
 557         (PlatformScrollbar::~PlatformScrollbar):
 558         (PlatformScrollbar::width):
 559         (PlatformScrollbar::height):
 560         (PlatformScrollbar::setEnabled):
 561         (PlatformScrollbar::paint):
 562         (PlatformScrollbar::updateThumbPosition):
 563         (PlatformScrollbar::updateThumbProportion):
 564         (PlatformScrollbar::setRect):
 565         (Scrollbar::Scrollbar):
 566         (Scrollbar::setSteps):
 567         (Scrollbar::scroll):
 568         (Scrollbar::setValue):
 569         (Scrollbar::setProportion):
 570         * platform/win/WidgetWin.cpp:
 571         (WebCore::WidgetPrivate::WidgetPrivate):
 572         (WebCore::Widget::Widget):
 573         (WebCore::Widget::setContainingWindow):
 574         (WebCore::Widget::containingWindow):
 575
 576 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
 577
 578         build fix.
 579
 580         * WebCore.xcodeproj/project.pbxproj:
 581         * bridge/mac/BrowserExtensionMac.mm:
 582         (WebCore::BrowserExtensionMac::createNewWindow):
 583         * bridge/mac/FrameMac.mm:
 584         (WebCore::FrameMac::createFrame):
 585         * bridge/mac/FrameViewMac.mm:
 586         (WebCore::FrameView::passMousePressEventToScrollbar):
 587         * bridge/mac/WebCoreFrameBridge.mm:
 588         (-[WebCoreFrameBridge installInFrame:]):
 589         * bridge/mac/WebCoreFrameView.h:
 590         * platform/ScrollBar.cpp:
 591         * platform/Widget.h:
 592         * platform/mac/PlatformScrollBar.h:
 593         * platform/mac/PlatformScrollBarMac.mm:
 594         (NSControlSizeForScrollBarControlSize):
 595         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
 596         (-[WebCoreScrollBar detachPlatformScrollbar]):
 597         (-[WebCoreScrollBar scroll:]):
 598         (-[WebCoreScrollBar widget]):
 599         (WebCore::PlatformScrollbar::PlatformScrollbar):
 600         (WebCore::PlatformScrollbar::~PlatformScrollbar):
 601         (WebCore::PlatformScrollbar::updateThumbPosition):
 602         (WebCore::PlatformScrollbar::updateThumbProportion):
 603         (WebCore::PlatformScrollbar::scrollbarHit):
 604         (WebCore::PlatformScrollbar::width):
 605         (WebCore::PlatformScrollbar::height):
 606         (WebCore::PlatformScrollbar::setRect):
 607         (WebCore::PlatformScrollbar::setEnabled):
 608         (WebCore::PlatformScrollbar::paint):
 609         * platform/mac/ScrollViewMac.mm:
 610         (WebCore::ScrollView::setVScrollbarMode):
 611         (WebCore::ScrollView::setHScrollbarMode):
 612         (WebCore::ScrollView::setScrollbarsMode):
 613         (WebCore::ScrollView::vScrollbarMode):
 614         (WebCore::ScrollView::hScrollbarMode):
 615         (WebCore::ScrollView::suppressScrollbars):
 616         (WebCore::ScrollView::scrollbarUnderMouse):
 617         * platform/mac/WidgetMac.mm:
 618         (WebCore::Widget::removeFromParent):
 619         * rendering/RenderLayer.cpp:
 620         (WebCore::RenderLayer::destroyScrollbar):
 621
 622 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
 623
 624         build fix.
 625
 626         * platform/Widget.h:
 627         * rendering/RenderLayer.cpp:
 628         (WebCore::RenderLayer::destroyScrollbar):
 629
 630 2006-10-06  Mitz Pettel  <mitz@webkit.org>
 631
 632         http://bugs.webkit.org/show_bug.cgi?id=8276
 633         Fix broken manual test added back in r13990.
 634
 635         Add resource forks for test resources.
 636
 637         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
 638         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
 639         * manual-tests/resources/plain-text-paste/._4.txt: Added.
 640         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
 641
 642 2006-10-05  David Hyatt  <hyatt@apple.com>
 643
 644         Rename addClip to clip.
 645
 646         Reviewed by darin
 647
 648         * kcanvas/RenderForeignObject.cpp:
 649         (WebCore::RenderForeignObject::paint):
 650         * kcanvas/RenderSVGContainer.cpp:
 651         (WebCore::RenderSVGContainer::paint):
 652         * kcanvas/RenderSVGImage.cpp:
 653         (WebCore::RenderSVGImage::paint):
 654         * platform/GraphicsContext.h:
 655         * platform/cairo/GraphicsContextCairo.cpp:
 656         (WebCore::GraphicsContext::clip):
 657         * platform/cg/GraphicsContextCG.cpp:
 658         (WebCore::GraphicsContext::savePlatformState):
 659         (WebCore::GraphicsContext::restorePlatformState):
 660         (WebCore::GraphicsContext::clip):
 661         (WebCore::GraphicsContext::addRoundedRectClip):
 662         (WebCore::GraphicsContext::addInnerRoundedRectClip):
 663         (WebCore::GraphicsContext::scale):
 664         (WebCore::GraphicsContext::rotate):
 665         (WebCore::GraphicsContext::translate):
 666         (WebCore::GraphicsContext::concatCTM):
 667         * platform/cg/GraphicsContextPlatformPrivate.h:
 668         (WebCore::GraphicsContextPlatformPrivate::save):
 669         (WebCore::GraphicsContextPlatformPrivate::restore):
 670         (WebCore::GraphicsContextPlatformPrivate::clip):
 671         (WebCore::GraphicsContextPlatformPrivate::scale):
 672         (WebCore::GraphicsContextPlatformPrivate::rotate):
 673         (WebCore::GraphicsContextPlatformPrivate::translate):
 674         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
 675         * platform/qt/GraphicsContextQt.cpp:
 676         (WebCore::GraphicsContext::clip):
 677         (WebCore::GraphicsContext::addInnerRoundedRectClip):
 678         (WebCore::GraphicsContext::addRoundedRectClip):
 679         * rendering/InlineFlowBox.cpp:
 680         (WebCore::InlineFlowBox::paintBackground):
 681         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
 682         * rendering/InlineTextBox.cpp:
 683         (WebCore::InlineTextBox::paintSelection):
 684         (WebCore::InlineTextBox::paintTextMatchMarker):
 685         * rendering/RenderBox.cpp:
 686         (WebCore::RenderBox::paintBackgroundExtended):
 687         * rendering/RenderButton.cpp:
 688         (WebCore::RenderButton::paintObject):
 689         * rendering/RenderFileUploadControl.cpp:
 690         (WebCore::RenderFileUploadControl::paintObject):
 691         * rendering/RenderLayer.cpp:
 692         (WebCore::RenderLayer::beginTransparencyLayers):
 693         (WebCore::setClip):
 694         * rendering/RenderListBox.cpp:
 695         (WebCore::RenderListBox::paintObject):
 696         * rendering/RenderMenuList.cpp:
 697         (WebCore::RenderMenuList::paintObject):
 698         * rendering/RenderTableCell.cpp:
 699         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
 700
 701 2006-10-05  Mitz Pettel  <mitz@webkit.org>
 702
 703         Reviewed by Darin.
 704
 705         - http://bugs.webkit.org/show_bug.cgi?id=10386
 706           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
 707
 708         * CMakeLists.txt:
 709         * WebCore.vcproj/WebCore/WebCore.vcproj:
 710         * WebCoreSources.bkl:
 711         * rendering/RenderImageButton.cpp: Removed.
 712         * rendering/RenderImageButton.h: Removed.
 713
 714 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 715
 716         Reviewed by Darin.
 717
 718         - http://bugs.webkit.org/show_bug.cgi?id=11067
 719           manual-tests/scrollbar-hittest2.html is invalid
 720
 721         * manual-tests/scrollbar-hittest2.html:
 722
 723 2006-10-05  David Carson  <dacarson@gmail.com>
 724
 725         Reviewed by Darin.
 726
 727         http://bugs.webkit.org/show_bug.cgi?id=11152
 728         Adjust the tokenizer chunk size to be smaller for
 729         mobile devices, and also decrease the yield timer
 730         for the tokenizer so that it can resume earlier.
 731
 732         * html/HTMLTokenizer.cpp:
 733         * config.h:
 734
 735 2006-10-05  Adam Roben  <aroben@apple.com>
 736
 737         Removing accidentally-checked-in do-nothing code.
 738
 739         * html/HTMLInputElement.cpp:
 740         (WebCore::HTMLInputElement::defaultEventHandler):
 741
 742 2006-10-05  David Carson  <dacarson@gmail.com>
 743
 744         Reviewed by Mitz.
 745
 746         http://bugs.webkit.org/show_bug.cgi?id=11158
 747         Initialize class variables
 748
 749         * rendering/RenderLayer.cpp:
 750         (WebCore::RenderLayer::RenderLayer):
 751
 752 2006-10-05  Don Gibson  <dgibson77@gmail.com>
 753
 754         Reviewed by Darin, landed by Adam.
 755
 756         http://bugs.webkit.org/show_bug.cgi?id=11176
 757         Fix win32 build, adapt to Maciej's ResourceLoader changes.
 758
 759         * platform/win/ResourceLoaderWin.cpp:
 760         (WebCore::ResourceLoader::start):
 761
 762 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
 763
 764         Reviewed by Darin.
 765
 766         http://bugs.webkit.org/show_bug.cgi?id=10989
 767         Provide a way for embedders to implement BrowserExtensionWin
 768
 769         * WebCore.vcproj/WebCore/WebCore.vcproj:
 770         * bridge/win/BrowserExtensionWin.cpp: Added.
 771         (BrowserExtensionWin::BrowserExtensionWin):
 772         (BrowserExtensionWin::setTypedIconURL):
 773         (BrowserExtensionWin::setIconURL):
 774         (BrowserExtensionWin::getHistoryLength):
 775         (BrowserExtensionWin::canRunModal):
 776         (BrowserExtensionWin::createNewWindow):
 777         (BrowserExtensionWin::canRunModalNow):
 778         (BrowserExtensionWin::runModal):
 779         (BrowserExtensionWin::goBackOrForward):
 780         (BrowserExtensionWin::historyURL):
 781         * bridge/win/BrowserExtensionWin.h:
 782         * bridge/win/FrameWin.cpp:
 783         (WebCore::FrameWin::createNewWindow):
 784         * bridge/win/FrameWin.h:
 785         * platform/win/TemporaryLinkStubs.cpp:
 786
 787 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
 788
 789         Reviewed by Darin.
 790
 791         Fixed <rdar://problem/4766987>
 792
 793         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
 794         except for file names.
 795
 796         - fixed RenderLayer to properly tear down scrollbars, removing them from
 797         their parents.
 798
 799         * bindings/js/kjs_window.cpp:
 800         (KJS::showModalDialog):
 801         (KJS::setWindowFeature):
 802         (KJS::parseWindowFeatures):
 803         * bridge/BrowserExtension.h:
 804         * dom/Document.cpp:
 805         (WebCore::Document::setInPageCache):
 806         * html/HTMLFrameElement.cpp:
 807         (WebCore::HTMLFrameElement::init):
 808         (WebCore::HTMLFrameElement::parseMappedAttribute):
 809         * html/HTMLFrameElement.h:
 810         (WebCore::HTMLFrameElement::scrollingMode):
 811         * page/Frame.cpp:
 812         (WebCore::Frame::finishedParsing):
 813         (WebCore::Frame::scrollbarsVisible):
 814         * page/FrameView.cpp:
 815         (WebCore::FrameViewPrivate::FrameViewPrivate):
 816         (WebCore::FrameViewPrivate::reset):
 817         (WebCore::FrameView::~FrameView):
 818         (WebCore::FrameView::resetScrollbars):
 819         (WebCore::FrameView::clear):
 820         (WebCore::FrameView::initScrollbars):
 821         (WebCore::FrameView::applyOverflowToViewport):
 822         (WebCore::FrameView::layout):
 823         (WebCore::FrameView::handleMousePressEvent):
 824         (WebCore::selectCursor):
 825         (WebCore::FrameView::handleMouseMoveEvent):
 826         (WebCore::FrameView::setScrollbarsMode):
 827         (WebCore::FrameView::setVScrollbarMode):
 828         (WebCore::FrameView::setHScrollbarMode):
 829         (WebCore::FrameView::restoreScrollbar):
 830         (WebCore::FrameView::dispatchMouseEvent):
 831         (WebCore::FrameView::scrollbarMoved):
 832         * page/FrameView.h:
 833         * page/MouseEventWithHitTestResults.cpp:
 834         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
 835         * page/MouseEventWithHitTestResults.h:
 836         (WebCore::MouseEventWithHitTestResults::scrollbar):
 837         * platform/ScrollBar.cpp:
 838         (WebCore::Scrollbar::Scrollbar):
 839         (WebCore::Scrollbar::setValue):
 840         (WebCore::Scrollbar::setProportion):
 841         (WebCore::Scrollbar::setSteps):
 842         (WebCore::Scrollbar::scroll):
 843         * platform/ScrollBar.h:
 844         (WebCore::):
 845         (WebCore::ScrollbarClient::~ScrollbarClient):
 846         (WebCore::Scrollbar::~Scrollbar):
 847         (WebCore::Scrollbar::orientation):
 848         (WebCore::Scrollbar::controlSize):
 849         (WebCore::Scrollbar::hasPlatformScrollbars):
 850         (WebCore::Scrollbar::client):
 851         * platform/ScrollBarMode.h:
 852         (WebCore::):
 853         * platform/ScrollView.h:
 854         * rendering/RenderBlock.cpp:
 855         (WebCore::RenderBlock::isPointInScrollbar):
 856         * rendering/RenderLayer.cpp:
 857         (WebCore::RenderLayer::RenderLayer):
 858         (WebCore::RenderLayer::~RenderLayer):
 859         (WebCore::RenderLayer::scrollToOffset):
 860         (WebCore::RenderLayer::horizontaScrollbarWidget):
 861         (WebCore::RenderLayer::verticalScrollbarWidget):
 862         (WebCore::RenderLayer::valueChanged):
 863         (WebCore::RenderLayer::createScrollbar):
 864         (WebCore::RenderLayer::destroyScrollbar):
 865         (WebCore::RenderLayer::setHasHorizontalScrollbar):
 866         (WebCore::RenderLayer::setHasVerticalScrollbar):
 867         (WebCore::RenderLayer::verticalScrollbarWidth):
 868         (WebCore::RenderLayer::horizontalScrollbarHeight):
 869         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
 870         * rendering/RenderLayer.h:
 871         (WebCore::RenderLayer::horizontalScrollbar):
 872         (WebCore::RenderLayer::verticalScrollbar):
 873         * rendering/RenderListBox.cpp:
 874         (WebCore::RenderListBox::~RenderListBox):
 875         (WebCore::RenderListBox::calcMinMaxWidth):
 876         (WebCore::RenderListBox::isPointInScrollbar):
 877         (WebCore::RenderListBox::optionAtPoint):
 878         (WebCore::RenderListBox::valueChanged):
 879         * rendering/RenderListBox.h:
 880         * rendering/RenderObject.h:
 881         (WebCore::RenderObject::NodeInfo::scrollbar):
 882         (WebCore::RenderObject::NodeInfo::setScrollbar):
 883
 884 2006-10-05  Don Gibson  <dgibson77@gmail.com>
 885
 886         Reviewed by Adam.
 887
 888         http://bugs.webkit.org/show_bug.cgi?id=11138
 889         Incorrect mouse event generation on Windows
 890
 891         * platform/win/MouseEventWin.cpp:
 892         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
 893         (1) Set mouse button even for non-click-related messages.
 894         (2) Track clicks correctly for all buttons, not just the left button.
 895
 896 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
 897
 898         Reviewed and landed by ap.
 899
 900         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
 901
 902         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 903         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
 904         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
 905         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
 906         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
 907         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 908         (WebCore::KRenderingPaintServerPatternQt::renderPath):
 909         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 910         (WebCore::KRenderingPaintServerQt::setPenProperties):
 911         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 912         (WebCore::KRenderingPaintServerSolidQt::setup):
 913         (WebCore::KRenderingPaintServerSolidQt::renderPath):
 914         * kcanvas/device/qt/RenderPathQt.cpp:
 915         (WebCore::getPathStroke):
 916
 917 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
 918
 919         Reviewed by Darin.
 920
 921         http://bugs.webkit.org/show_bug.cgi?id=11054
 922         REGRESSION: Traditional Chinese encoding in login authentication
 923
 924         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
 925         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
 926         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
 927
 928         * platform/StreamingTextDecoderICU.cpp:
 929         (WebCore::TextCodecICU::registerEncodingNames):
 930
 931 2006-10-05  Eric Seidel  <eric@eseidel.com>
 932
 933         Reviewed by mjs.
 934
 935         Removed dead code.
 936         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
 937
 938         * WebCore.xcodeproj/project.pbxproj:
 939         * ksvg2/ecma/GlobalObject.cpp: Removed.
 940         * ksvg2/ecma/GlobalObject.h: Removed.
 941
 942 2006-10-05  Adam Roben  <aroben@apple.com>
 943
 944         Reviewed by Maciej.
 945
 946         Small ResourceLoaderInternal tweak.
 947
 948         * platform/ResourceLoaderInternal.h:
 949         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 950
 951 2006-10-05  Eric Seidel  <eric@eseidel.com>
 952
 953         Reviewed by mjs.
 954
 955         More incremental KCanvas cleanup and optimization.
 956         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
 957         Optimized dash array usage to not malloc.
 958         Also removed un-needed KSVGRenderingStyle includes.
 959
 960         * kcanvas/KCanvasTreeDebug.cpp:
 961         (WebCore::operator<<):
 962         * kcanvas/RenderPath.cpp:
 963         (WebCore::RenderPath::nodeAtPoint):
 964         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 965         (WebCore::RenderPath::strokeBBox):
 966         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 967         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 968         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
 969         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 970         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 971         (WebCore::KRenderingPaintServerSolidQuartz::setup):
 972         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
 973         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 974         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
 975         * kcanvas/device/quartz/QuartzSupport.mm:
 976         (WebCore::applyStrokeStyleToContext):
 977         * ksvg2/css/SVGRenderStyle.h:
 978         (WebCore::SVGRenderStyle::hasStroke):
 979         (WebCore::SVGRenderStyle::hasFill):
 980         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 981         (WebCore::KSVGPainterFactory::fillPaintServer):
 982         (WebCore::KSVGPainterFactory::strokePaintServer):
 983         * ksvg2/misc/KCanvasRenderingStyle.h:
 984
 985 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
 986
 987         Reviewed by Adam.
 988
 989         - changed ResourceLoader to be refcounted
 990
 991         It keeps a ref on itself while loading as well. This makes
 992         for a much saner memory management model than the previous.
 993
 994         * bridge/mac/WebCoreResourceLoaderImp.mm:
 995         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
 996         * dom/XMLTokenizer.cpp:
 997         (WebCore::openFunc):
 998         * loader/icon/IconLoader.cpp:
 999         (IconLoader::IconLoader):
1000         (IconLoader::~IconLoader):
1001         (IconLoader::startLoading):
1002         (IconLoader::stopLoading):
1003         (IconLoader::receivedData):
1004         * loader/icon/IconLoader.h:
1005         * loader/loader.cpp:
1006         (WebCore::Loader::servePendingRequests):
1007         * platform/ResourceLoader.cpp:
1008         (WebCore::ResourceLoader::create):
1009         (WebCore::ResourceLoader::kill):
1010         * platform/ResourceLoader.h:
1011         * platform/ResourceLoaderInternal.h:
1012         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1013         * platform/mac/ResourceLoaderMac.mm:
1014         (WebCore::ResourceLoader::start):
1015         * xml/XSLTProcessor.cpp:
1016         (WebCore::docLoaderFunc):
1017         * xml/xmlhttprequest.cpp:
1018         (WebCore::XMLHttpRequest::send):
1019         * xml/xmlhttprequest.h:
1020
1021 2006-10-05  Eric Seidel  <eric@eseidel.com>
1022
1023         Reviewed by mjs.
1024
1025         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
1026         http://bugs.webkit.org/show_bug.cgi?id=11163
1027
1028         No SVG performance tests yet.
1029
1030         * kcanvas/RenderForeignObject.cpp:
1031         (WebCore::RenderForeignObject::paint):
1032         * kcanvas/RenderSVGContainer.cpp:
1033         (WebCore::RenderSVGContainer::paint):
1034         * kcanvas/RenderSVGImage.cpp:
1035         (WebCore::RenderSVGImage::paint):
1036         * kcanvas/RenderSVGText.cpp:
1037         (WebCore::RenderSVGText::paint):
1038
1039 2006-10-05  Dave Hyatt  <hyatt@apple.com>
1040
1041         Stub out some stuff for widget focusability.
1042
1043         Reviewed by maciej
1044
1045         * page/FrameView.cpp:
1046         (WebCore::FrameView::dispatchMouseEvent):
1047         * platform/ScrollView.h:
1048         * platform/Widget.h:
1049
1050 2006-10-05  Adam Roben  <aroben@apple.com>
1051
1052         Reviewed by Maciej and Tim H.
1053
1054         Copy some WebKit frame lifetime logic into WebCore -- just a step
1055         along the path to frame lifetime being handled completely in WebCore.
1056
1057         * bridge/mac/FrameMac.mm:
1058         (WebCore::FrameMac::setView): Move platform-independent parts of this
1059         method into Frame.
1060         * page/Frame.cpp:
1061         (WebCore::Frame::setView): Adding platform-independent parts of
1062         FrameMac::setView
1063         (WebCore::Frame::detachChildren): New method to accomplish what
1064         -[WebFrameBridge _detachChildren] currently does.
1065         (WebCore::Frame::clear): Call detachChildren
1066         * page/Frame.h: Add declaration for detachChildren
1067
1068 2006-10-04  Alice Liu  <alice.liu@apple.com>
1069
1070         Reviewed by Darin.
1071
1072         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
1073
1074         * xml/xmlhttprequest.cpp:
1075         (WebCore::XMLHttpRequest::setRequestHeader):
1076         removed exception set when the request is not open yet
1077
1078 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
1079
1080         Reviewed by John Sullivan.
1081
1082         <rdar://problem/4654328>
1083         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
1084
1085         * loader/PluginDocument.cpp:
1086         (WebCore::PluginTokenizer::writeRawData):
1087         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
1088
1089 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
1090
1091         Reviewed by Tim H.
1092
1093         http://bugs.webkit.org/show_bug.cgi?id=11130
1094         Convert "undefined" to AE missing value
1095
1096         * bridge/mac/WebCoreFrameBridge.mm:
1097         (aeDescFromJSValue): return missing value for UndefinedType.
1098
1099 2006-10-03  Dave Hyatt  <hyatt@apple.com>
1100
1101         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
1102         the windowToContents/contentsToWindow functions.
1103
1104         Reviewed by anders
1105
1106         * bridge/mac/FrameMac.mm:
1107         (WebCore::FrameMac::eventMayStartDrag):
1108         (WebCore::FrameMac::dragHysteresisExceeded):
1109         (WebCore::FrameMac::mouseDown):
1110         (WebCore::FrameMac::shouldDragAutoNode):
1111         (WebCore::FrameMac::sendContextMenuEvent):
1112         * bridge/mac/FrameViewMac.mm:
1113         (WebCore::FrameView::passMousePressEventToScrollbar):
1114         * bridge/mac/WebCoreFrameBridge.mm:
1115         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1116         * dom/EventTargetNode.cpp:
1117         (WebCore::EventTargetNode::dispatchMouseEvent):
1118         (WebCore::EventTargetNode::dispatchWheelEvent):
1119         * page/Frame.cpp:
1120         (WebCore::Frame::selectClosestWordFromMouseEvent):
1121         (WebCore::Frame::handleMousePressEventTripleClick):
1122         (WebCore::Frame::handleMousePressEventSingleClick):
1123         (WebCore::Frame::handleMouseMoveEvent):
1124         (WebCore::Frame::handleMouseReleaseEvent):
1125         * page/FrameView.cpp:
1126         (WebCore::FrameView::handleMousePressEvent):
1127         (WebCore::FrameView::handleMouseDoubleClickEvent):
1128         (WebCore::selectCursor):
1129         (WebCore::FrameView::handleMouseMoveEvent):
1130         (WebCore::FrameView::handleMouseReleaseEvent):
1131         (WebCore::FrameView::dispatchDragEvent):
1132         (WebCore::FrameView::prepareMouseEvent):
1133         (WebCore::FrameView::handleWheelEvent):
1134         * page/FrameView.h:
1135         * platform/ScrollBar.cpp:
1136         (WebCore::ScrollBar::setValue):
1137         * platform/ScrollView.h:
1138         * platform/Widget.h:
1139         (WebCore::Widget::scrolled):
1140         * platform/mac/ScrollViewMac.mm:
1141         (WebCore::ScrollView::contentsToWindow):
1142         (WebCore::ScrollView::windowToContents):
1143         (WebCore::ScrollView::scrollbarUnderMouse):
1144         * platform/mac/WidgetMac.mm:
1145         * rendering/RenderLayer.cpp:
1146         (WebCore::RenderLayer::resize):
1147         (WebCore::RenderLayer::positionScrollbars):
1148         * rendering/RenderReplaced.cpp:
1149         (WebCore::RenderReplaced::shouldPaint):
1150         * rendering/RenderView.cpp:
1151         * rendering/RenderView.h:
1152         * rendering/RenderWidget.cpp:
1153         (WebCore::RenderWidget::setWidget):
1154
1155 2006-09-26  David Smith  <catfish.man@gmail.com>
1156
1157         Reviewed by Timothy.
1158
1159         http://bugs.webkit.org/show_bug.cgi?id=3723
1160         Add -scrollDOMRangeToVisible:
1161
1162         No automated tests are possible as this code path isn't reachable from JavaScript.
1163
1164         * bridge/mac/WebCoreFrameBridge.h:
1165         * bridge/mac/WebCoreFrameBridge.mm:
1166         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
1167
1168 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
1169
1170         Reviewed by Timothy.
1171
1172         <http://bugs.webkit.org/show_bug.cgi?id=10338>
1173         When contentEditable, cursor doesn't change to hand
1174
1175         Allow the behaviour of editable links to be specified by a WebPreference
1176         The preference WebKitEditableLinkBehavior has four options:
1177          - AlwaysLive: Safari 2.0 behaviour
1178          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
1179          - LiveWhenNotFocused: Editable links are live only when their editable block is not
1180              focused, or when the shift key is pressed
1181          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
1182
1183         No layout tests, just a modification of a manual-test as it isn't possible to test
1184         this automatically.
1185
1186         * bridge/mac/WebCoreSettings.h:
1187         * bridge/mac/WebCoreSettings.mm:
1188         (-[WebCoreSettings setEditableLinkBehavior:]):
1189         (-[WebCoreSettings editableLinkBehavior]):
1190         * html/HTMLAnchorElement.cpp:
1191         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1192         (WebCore::HTMLAnchorElement::defaultEventHandler):
1193         (WebCore::HTMLAnchorElement::setActive):
1194         * html/HTMLAnchorElement.h:
1195         * manual-tests/contenteditable-link.html:
1196         * page/FrameView.cpp:
1197         (WebCore::nodeIsNotBeingEdited):
1198         (WebCore::selectCursor):
1199         * page/Settings.h:
1200         (WebCore::Settings::):
1201         (WebCore::Settings::Settings):
1202         (WebCore::Settings::editableLinkBehavior):
1203         (WebCore::Settings::setEditableLinkBehavior):
1204
1205 2006-10-03  Beth Dakin  <bdakin@apple.com>
1206
1207         Reviewed Darin.
1208
1209         No test cases needed.
1210
1211         Implemented a version of StringImpl::append that takes a UChar* and
1212         a length.
1213
1214         * platform/StringImpl.cpp:
1215         (WebCore::StringImpl::append):
1216         (WebCore::StringImpl::insert): Call new append instead of making a
1217         new StringImpl.
1218         * platform/StringImpl.h:
1219
1220 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
1221
1222         Reviewed by Darin.
1223
1224         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
1225         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
1226
1227         * platform/win/ResourceLoaderWin.cpp:
1228         (WebCore::ResourceLoader::onHandleCreated):
1229
1230 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
1231
1232         Feared, loathed, reviewed by Darin.
1233
1234         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
1235         into FRAME, plus other cleanup.
1236
1237         No new behavior, so no new test. Layout tests pass. Basic browsing and
1238         Mail editing seem to work.
1239
1240         * dom/Node.cpp:
1241         (WebCore::Node::detach): Removed random commented-out code.
1242         * html/HTMLFrameElement.cpp:
1243         (WebCore::HTMLFrameElement::isURLAllowed):
1244         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
1245         (2) Renamed newURL to completeURL because the difference between newURL
1246         and URLString is that newURL is a KURL that is the complete version of URLString,
1247         not that it is new.
1248         (WebCore::HTMLFrameElement::willRemove):
1249         (1) Removed close() call and moved close() code into willRemove(), also removing
1250         close() call from detach(), since willRemove is the well-defined place
1251         from DOM tear-down, not detach().
1252         (2) Removed manual renderer detach code because the DOM is not responsible
1253         for managing the render tree. I confirmed that this change not
1254         regress <rdar://problem/4132581>.
1255         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
1256         lost their content frames after being removed from the DOM. That's our
1257         current behavior, but it's going to change in future rounds of refactoring.
1258         This also fixes <rdar://problem/4750835>.
1259         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
1260         attach/detach, because the render tree should not be in charge of deciding
1261         when to load.
1262         * html/HTMLFrameElement.h:
1263         * html/HTMLIFrameElement.cpp:
1264         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
1265         because the renderer is a renderPartObject, not a renderPart.
1266         * html/HTMLIFrameElement.h:
1267
1268 2006-10-03  Mark Rowe  <bdash@webkit.org>
1269
1270         Reviewed by Mitz.
1271
1272         http://bugs.webkit.org/show_bug.cgi?id=11137
1273         Bug 11137: GdkLauncher dies with "pure virtual method called" if
1274         window is closed while page still loading
1275
1276         * platform/gdk/FrameGdk.cpp:
1277         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
1278         methods to be called before the FrameGdk portion of "this" is torn down.
1279
1280 2006-10-03  Adam Roben  <aroben@apple.com>
1281
1282         Reviewed by Darin.
1283
1284         Handle tab key presses in the DOM.
1285
1286         * dom/EventTargetNode.cpp:
1287         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
1288         * page/FrameView.cpp:
1289         (WebCore::FrameView::advanceFocus): Rename and reimplement
1290         focusNextPrevNode. Now we just call Element::focus().
1291         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
1292         it public.
1293
1294 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
1295
1296         Reviewed by mjs
1297
1298         <rdar://problem/4760612>
1299         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
1300
1301         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
1302
1303         * dom/Range.cpp:
1304         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
1305         positions are non-null since most of it's callers would be in a bad state if the positions
1306         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
1307         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
1308         from entering compareBoundaryPoints and hitting the assert.
1309
1310 2006-10-03  Adele Peterson  <adele@apple.com>
1311
1312         Reviewed by Geoff.
1313
1314         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
1315
1316         * html/HTMLSelectElement.cpp:
1317         (WebCore::HTMLSelectElement::recalcStyle):
1318         (WebCore::HTMLSelectElement::isKeyboardFocusable):
1319         (WebCore::HTMLSelectElement::isMouseFocusable):
1320         (WebCore::HTMLSelectElement::createRenderer):
1321         (WebCore::HTMLSelectElement::setRecalcListItems):
1322         (WebCore::HTMLSelectElement::notifyOptionSelected):
1323         (WebCore::HTMLSelectElement::defaultEventHandler):
1324
1325 2006-10-04  Darin Adler  <darin@apple.com>
1326
1327         Reviewed by Geoff.
1328
1329         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
1330           Caret disappears when you're typing
1331
1332         * editing/SelectionController.cpp:
1333         (WebCore::SelectionController::setSelection): Remove unnecessary call to
1334         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
1335         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
1336         to false so we can get the old caret repaint rect. Later we need to change the
1337         design so getting the rect doesn't have a side effect of causing a layout without
1338         invalidation.
1339
1340 2006-10-03  David Harrison  <harrison@apple.com>
1341
1342         Reviewed by Maciej.
1343
1344         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
1345
1346         Updated test:
1347         * fast/text/justified-text-rect.html
1348
1349         * bridge/mac/WebCoreFrameBridge.mm:
1350         (-[WebCoreFrameBridge convertToNSRange:]):
1351         (-[WebCoreFrameBridge convertToDOMRange:]):
1352         Make the selection's root editable element (or the document itself) be
1353         the basis for NSRange conversions. This supports "shadow DOM" like
1354         that for text fields and text areas.
1355
1356         * editing/CompositeEditCommand.cpp:
1357         (WebCore::CompositeEditCommand::moveParagraphs):
1358         Pass the document element as the scope.
1359
1360         * editing/TextIterator.cpp:
1361         (WebCore::TextIterator::rangeFromLocationAndLength):
1362         Make the first parameter the scope.
1363
1364         * editing/TextIterator.h:
1365         Make the first parameter of rangeFromLocationAndLength() the scope.
1366
1367 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
1368
1369         Reviewed by Eric.
1370
1371         Fix Qt/Linux build.
1372
1373         * CMakeLists.txt: Add counter related files.
1374
1375 2006-10-03  Mark Rowe  <bdash@webkit.org>
1376
1377         Reviewed by Eric.
1378
1379         http://bugs.webkit.org/show_bug.cgi?id=10981
1380         Linux/GDK build fixes
1381
1382         Based on a patch by Krzysztof Kowalczyk.
1383
1384         * WebCoreSources.bkl:
1385         * platform/gdk/FrameGdk.cpp:
1386         (WebCore::doScroll):
1387         (WebCore::FrameGdk::handleGdkEvent):
1388         * platform/gdk/PlatformScrollBar.h: Added.
1389         (WebCore::PlatformScrollBar::isWidget):
1390         * platform/gdk/ScrollViewGdk.cpp:
1391         * platform/gdk/TemporaryLinkStubs.cpp:
1392         (FrameView::passMousePressEventToScrollbar):
1393         (FrameView::passMousePressEventToSubframe):
1394         (FrameView::passMouseReleaseEventToSubframe):
1395         (FrameView::passMouseMoveEventToSubframe):
1396         (FrameView::passWheelEventToSubframe):
1397         (Cursor::Cursor):
1398         (Widget::invalidate):
1399         (Widget::invalidateRect):
1400         (ScrollView::wheelEvent):
1401         (ScrollView::convertToContainingWindow):
1402         (ScrollView::convertFromContainingWindow):
1403         (GraphicsContext::clip):
1404         (PlatformScrollBar::PlatformScrollBar):
1405         (PlatformScrollBar::updateThumbPosition):
1406         (PlatformScrollBar::updateThumbProportion):
1407         (ScrollBar::ScrollBar):
1408         (ScrollBar::setProportion):
1409         (WebCore::supportedKeySizes):
1410         (WebCore::signedPublicKeyAndChallengeString):
1411         * platform/gdk/WheelEventGdk.cpp:
1412         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1413         * platform/gdk/WidgetGdk.cpp:
1414         (WebCore::Widget::convertToContainingWindow):
1415         (WebCore::Widget::convertFromContainingWindow):
1416
1417 2006-10-02  Adam Roben  <aroben@apple.com>
1418
1419         Reviewed by Maciej.
1420
1421         Let Windows determine which mouse button is pressed.
1422
1423         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
1424         * platform/win/MouseEventWin.cpp:
1425         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
1426         parameter to determine which mouse button is pressed.
1427
1428 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
1429
1430         Reviewed by anders
1431
1432         Build fix
1433
1434         * editing/SelectionController.cpp:
1435         (WebCore::SelectionController::empty):
1436         * editing/SelectionController.h:
1437
1438 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
1439
1440         Reviewed by john
1441
1442         <rdar://problem/4755287>
1443         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
1444
1445         * editing/markup.cpp:
1446         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
1447         elements).  Don't skip blocks that aren't containers (like horizontal rules).
1448
1449 2006-10-03  Darin Adler  <darin@apple.com>
1450
1451         Reviewed by Justin Garcia.
1452
1453         - correct mistaken code that would restart blinking every
1454           time "invalidateSelection" is called even if the caret
1455           has not moved
1456
1457         * editing/SelectionController.h:
1458         * editing/SelectionController.cpp:
1459         (WebCore::SelectionController::setSelection): Update for name change.
1460         (WebCore::SelectionController::recomputeCaretRect): New function.
1461         Computes caret rect and does any necessary invalidation if the rect
1462         changes.
1463         (WebCore::SelectionController::invalidateCaretRect): Renamed from
1464         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
1465         calls recomputeCaretRect as a side effect.
1466
1467         * page/Frame.cpp:
1468         (WebCore::Frame::invalidateSelection): Remove unneeded call to
1469         clearCaretRectIfNeeded.
1470         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
1471         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
1472         recomputeCaretRect function and not restart blinking if caret has
1473         not changed position.
1474         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
1475         are not needed since selectionLayoutChanged already checks these.
1476
1477         * page/FramePrivate.h: Removed unused m_blinkCaret.
1478
1479 2006-10-02  Beth Dakin  <bdakin@apple.com>
1480
1481         Reviewed by Adam.
1482
1483         Build fix. Add counters to vcproj.
1484
1485         * WebCore.vcproj/WebCore/WebCore.vcproj:
1486
1487 2006-10-02  Brady Eidson  <beidson@apple.com>
1488
1489         Reviewed by Adele
1490
1491         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
1492         icon data out because we don't correctly check SQL error conditions.
1493
1494         * loader/icon/IconDataCache.cpp:
1495         (WebCore::IconDataCache::writeToDatabase):
1496
1497 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
1498
1499         Reviewed by Hyatt.
1500
1501         Added method to find out whether a layout has occurred.
1502
1503         * page/FrameView.cpp:
1504         (WebCore::FrameView::didFirstLayout):
1505         * page/FrameView.h:
1506
1507 2006-10-02  Beth Dakin  <bdakin@apple.com>
1508
1509         Reviewed by Darin.
1510
1511         Initial implementation of CSS2 counters. See http://
1512         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
1513
1514         * WebCore.xcodeproj/project.pbxproj:
1515         * css/CSSComputedStyleDeclaration.cpp:
1516         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
1517         the increment/reset list now that this is implemented.
1518         * css/CSSPrimitiveValue.cpp:
1519         (WebCore::CSSPrimitiveValue::cssText):
1520         * css/Counter.h:
1521         (WebCore::Counter::Counter):
1522         (WebCore::Counter::~Counter):
1523         (WebCore::Counter::identifier):
1524         (WebCore::Counter::listStyle):
1525         (WebCore::Counter::separator):
1526         (WebCore::Counter::listStyleNumber):
1527         (WebCore::Counter::setIdentifier):
1528         (WebCore::Counter::setListStyle):
1529         (WebCore::Counter::setSeparator):
1530         * css/cssparser.cpp:
1531         (WebCore::CSSParser::addProperty): Take care of reset/increment
1532         (WebCore::CSSParser::parseValue):
1533         (WebCore::CSSParser::parseContent): content can now take counters
1534         (WebCore::CSSParser::parseCounterContent): Parse counter() and
1535         counters()
1536         (WebCore::CSSParser::parseCounter): Parse counter-reset and
1537         counter-increment
1538         * css/cssparser.h:
1539         * css/cssstyleselector.cpp:
1540         (WebCore::CSSStyleSelector::matchUARules):
1541         (WebCore::CSSStyleSelector::applyProperty):
1542         * platform/PlatformString.h:
1543         * platform/String.cpp:
1544         (WebCore::String::insert): Implemented a version of insert that
1545         accepts a UChar* and a length.
1546         * platform/StringImpl.cpp:
1547         (WebCore::StringImpl::insert): Same as above.
1548         * platform/StringImpl.h:
1549         * rendering/CounterListItem.h: Added.
1550         * rendering/CounterNode.cpp: Added.
1551         (WebCore::CounterNode::CounterNode):
1552         (WebCore::CounterNode::insertAfter):
1553         (WebCore::CounterNode::removeChild):
1554         (WebCore::CounterNode::remove):
1555         (WebCore::CounterNode::setUsesSeparator):
1556         (WebCore::CounterNode::recountAndGetNext):
1557         (WebCore::CounterNode::recountTree):
1558         (WebCore::CounterNode::setSelfDirty):
1559         (WebCore::CounterNode::setParentDirty):
1560         * rendering/CounterNode.h: Added.
1561         (WebCore::CounterNode::~CounterNode):
1562         (WebCore::CounterNode::parent):
1563         (WebCore::CounterNode::previousSibling):
1564         (WebCore::CounterNode::nextSibling):
1565         (WebCore::CounterNode::firstChild):
1566         (WebCore::CounterNode::lastChild):
1567         (WebCore::CounterNode::value):
1568         (WebCore::CounterNode::setValue):
1569         (WebCore::CounterNode::count):
1570         (WebCore::CounterNode::setCount):
1571         (WebCore::CounterNode::setHasSeparator):
1572         (WebCore::CounterNode::isReset):
1573         (WebCore::CounterNode::hasSeparator):
1574         (WebCore::CounterNode::willNeedLayout):
1575         (WebCore::CounterNode::setWillNeedLayout):
1576         (WebCore::CounterNode::isRoot):
1577         (WebCore::CounterNode::setRenderer):
1578         (WebCore::CounterNode::renderer):
1579         * rendering/CounterResetNode.cpp: Added.
1580         (WebCore::CounterResetNode::CounterResetNode):
1581         (WebCore::CounterResetNode::insertAfter):
1582         (WebCore::CounterResetNode::removeChild):
1583         (WebCore::CounterResetNode::recountAndGetNext):
1584         (WebCore::CounterResetNode::setParentDirty):
1585         (WebCore::CounterResetNode::updateTotal):
1586         * rendering/CounterResetNode.h: Added.
1587         (WebCore::CounterResetNode::firstChild):
1588         (WebCore::CounterResetNode::lastChild):
1589         (WebCore::CounterResetNode::isReset):
1590         (WebCore::CounterResetNode::total):
1591         * rendering/RenderContainer.cpp:
1592         (WebCore::RenderContainer::updatePseudoChildForObject): Account for
1593         counter content.
1594         * rendering/RenderCounter.cpp: Added.
1595         (WebCore::RenderCounter::RenderCounter):
1596         (WebCore::RenderCounter::layout):
1597         (WebCore::toRoman):
1598         (WebCore::toLetterString):
1599         (WebCore::toHebrew):
1600         (WebCore::RenderCounter::convertValueToType):
1601         (WebCore::RenderCounter::calcMinMaxWidth):
1602         * rendering/RenderCounter.h: Added.
1603         (WebCore::RenderCounter::renderName):
1604         (WebCore::RenderCounter::isCounter):
1605         * rendering/RenderObject.cpp:
1606         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
1607         maps of CounterNodes
1608         (WebCore::RenderObject::RenderObject):
1609         (WebCore::RenderObject::destroy): Destroy the maps.
1610         (WebCore::RenderObject::findCounter): Finds/creates counters.
1611         * rendering/RenderObject.h:
1612         (WebCore::RenderObject::isCounter):
1613         * rendering/RenderStyle.cpp:
1614         (WebCore::StyleVisualData::StyleVisualData):
1615         (WebCore::RenderStyle::arenaDelete):
1616         (WebCore::RenderStyle::RenderStyle):
1617         (WebCore::RenderStyle::diff):
1618         (WebCore::RenderStyle::setContent):
1619         (WebCore::ContentData::clearContent):
1620         (WebCore::RenderStyle::counterDataEquivalent):
1621         (WebCore::hasCounter):
1622         (WebCore::RenderStyle::hasCounterReset):
1623         (WebCore::RenderStyle::hasCounterIncrement):
1624         (WebCore::readCounter):
1625         (WebCore::RenderStyle::counterReset):
1626         (WebCore::RenderStyle::counterIncrement):
1627         * rendering/RenderStyle.h:
1628         (WebCore::StyleVisualData::operator==):
1629         (WebCore::CounterData::CounterData):
1630         (WebCore::CounterData::identifier):
1631         (WebCore::CounterData::listStyle):
1632         (WebCore::CounterData::separator):
1633         (WebCore::ContentData::contentCounter):
1634         (WebCore::ContentData::):
1635         (WebCore::RenderStyle::counterIncrement):
1636         (WebCore::RenderStyle::counterReset):
1637         (WebCore::RenderStyle::setCounterIncrement):
1638         (WebCore::RenderStyle::setCounterReset):
1639         (WebCore::RenderStyle::setCounterResetList):
1640         (WebCore::RenderStyle::setCounterIncrementList):
1641         (WebCore::RenderStyle::counterResetValueList):
1642         (WebCore::RenderStyle::counterIncrementValueList):
1643
1644 2006-10-02  Adele Peterson  <adele@apple.com>
1645
1646         Reviewed by Adam.
1647
1648         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
1649
1650         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
1651         by using "-webkit-appearance:none".
1652
1653         * css/html4.css:
1654
1655 2006-10-02  David Harrison  <harrison@apple.com>
1656
1657         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
1658         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
1659         Left the layout test.
1660
1661         * rendering/bidi.cpp:
1662         (WebCore::checkMidpoints):
1663
1664 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
1665
1666         Reviewed by eseidel.  Landed by eseidel.
1667
1668         Fix Qt/Linux build.
1669
1670         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
1671         (WebCore::supportedKeySizes):
1672
1673 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
1674
1675         Reviewed by eseidel & mjs.  Landed by eseidel.
1676
1677         Fix Qt/Linux build with older gcc 3.3.4.
1678         http://bugs.webkit.org/show_bug.cgi?id=11116
1679
1680         As discussed with Maciej, the GCC_ROOT_NS_HACK
1681         can be completely removed, as well as the friendship
1682         between cacheGlobalObject & the JS* objects.
1683
1684         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
1685         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
1686         (png_read_filter_row_mmx_avg):
1687         * platform/image-decoders/png/pngvcrd.c: Ditto.
1688         (png_mmx_support):
1689         (png_read_filter_row_mmx_avg):
1690
1691 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
1692
1693         Rubber stamped by Alexey.
1694
1695         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
1696
1697         * css/CSSGrammar.y:
1698
1699 2006-10-01  Eric Seidel  <eric@webkit.org>
1700
1701         Reviewed by mjs.
1702
1703         Eliminate a few more hotspots in SVG drawing code.
1704
1705         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
1706
1707         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1708         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
1709         * platform/mac/ColorMac.mm:
1710         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
1711
1712 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
1713
1714         Reviewed by Maciej.
1715
1716         More frame/iframe merging.
1717
1718         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
1719         false, so this was dead code.
1720         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
1721         than attach(), is the correct place for setInViewSourceMode, because
1722         openURL() is the function that creates our frame.
1723         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
1724         code that did the same thing in other places.
1725         - Made FRAME's attach() method suffuciently generic so that IFRAME could
1726         call up to it, rather than skipping its superclass and calling up directly
1727         to ELEMENT.
1728         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
1729         - Replaced ad hoc frame loading code in FRAME::attach() with call to
1730         openURL(), the designated frame loading function.
1731
1732         Layout tests pass. I added a layout test for viewsource mode, since I
1733         broke it in the course of writing this patch.
1734
1735 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
1736
1737         Reviewed by Geoff.
1738
1739         * dom/Document.cpp:
1740         (WebCore::Document::recalcStyleSelector):
1741         * dom/Document.h:
1742         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
1743
1744         * dom/Node.h:
1745         Remove DeprecatedStringList class forward declaration.
1746
1747         * editing/markup.cpp:
1748         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
1749
1750         * kcanvas/KCanvasTreeDebug.cpp:
1751         * kcanvas/KCanvasTreeDebug.h:
1752         Remove unused functions.
1753
1754         * loader/loader.cpp:
1755         * page/Frame.cpp:
1756         * page/Frame.h:
1757         * page/FrameView.h:
1758         Fixup DeprecatedStringList.h includes.
1759
1760 2006-09-30  David Harrison  <harrison@apple.com>
1761
1762         Reviewed by John Sullivan.
1763
1764         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
1765
1766         Problem was that the decision to trim was based only on whether the character
1767         is a soft hyphen, which caused pretty much any Japanese character to go.
1768         Changed to decide based on whether the character is ignorable whitespace.
1769
1770         Test:
1771         * fast/text/international/wrap-CJK-001.html
1772
1773         * rendering/bidi.cpp:
1774         (WebCore::isTrimmableChar):
1775         New. Checks whether character is whitespace that can be ignored
1776         according to the text node's style.
1777         trimmed from the end of wrapped line.
1778         (WebCore::checkMidpoints):
1779         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
1780
1781 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
1782
1783         Reviewed by Mitz Pettel.
1784
1785         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
1786
1787         * ksvg2/svg/SVGColor.cpp:
1788         (WebCore::SVGColor::setRGBColor):
1789         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1790         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1791         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1792         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1793         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1794         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1795         (SVGFESpecularLightingElement::parseMappedAttribute):
1796         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1797         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1798         * ksvg2/svg/SVGLengthList.cpp:
1799         * ksvg2/svg/SVGNumberList.cpp:
1800         (SVGNumberList::parse):
1801         * ksvg2/svg/SVGNumberList.h:
1802         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
1803         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
1804         * ksvg2/svg/SVGStringList.cpp:
1805         (WebCore::SVGStringList::reset):
1806         * ksvg2/svg/SVGStringList.h:
1807         * ksvg2/svg/SVGTransformable.cpp:
1808         (SVGTransformable::parseTransformAttribute):
1809
1810 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
1811
1812         Reviewed by Eric, tweaked and landed by ap.
1813
1814         Fix Qt/Linux build.
1815
1816         * CMakeLists.txt:
1817         * platform/qt/PlatformScrollBar.h:
1818         * platform/qt/TemporaryLinkStubs.cpp:
1819         (WebCore::ScrollBar::ScrollBar):
1820         (WebCore::PlatformScrollBar::PlatformScrollBar):
1821         (FrameView::passMousePressEventToSubframe):
1822         (FrameView::passMouseMoveEventToSubframe):
1823         (FrameView::passMouseReleaseEventToSubframe):
1824         (FrameView::passWheelEventToSubframe):
1825         (FrameView::passMousePressEventToScrollbar):
1826         * ksvg2/svg/SVGDocument.h:
1827
1828 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1829
1830         Reviewed by Darin.
1831
1832         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
1833         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
1834
1835         No test case added (probably requires new DumpRenderTree functionality)
1836
1837         * rendering/RenderImage.cpp:
1838         (WebCore::RenderImage::imageChanged): Added early return if the document is
1839         being destroyed.
1840
1841 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
1842
1843         Reviewed by Hyatt.
1844
1845         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
1846         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
1847
1848         Make sure we only break after a space (and not any other valid line-break) if
1849         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
1850         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
1851         twice in quick succession.
1852
1853         * rendering/bidi.cpp:
1854         (WebCore::RenderBlock::findNextLineBreak):
1855
1856 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
1857
1858         Reviewed by Maciej and Darin.
1859
1860         http://bugs.webkit.org/show_bug.cgi?id=4372
1861         JavaScript document.write page form does not submit in Safari
1862
1863         Test: fast/forms/document-write.html
1864
1865         * page/Frame.cpp:
1866         (WebCore::Frame::submitForm): Don't check for parsing().
1867
1868 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
1869
1870         Build fix.
1871
1872         * bridge/mac/FrameViewMac.mm: Add missing #imports.
1873
1874 2006-10-01  Dave Hyatt  <hyatt@apple.com>
1875
1876         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
1877
1878         Reviewed by mitz
1879
1880         * bridge/mac/FrameMac.mm:
1881         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1882         * bridge/mac/FrameViewMac.mm:
1883         (WebCore::FrameView::passMousePressEventToScrollbar):
1884         * page/FrameView.cpp:
1885         (WebCore::FrameView::handleMousePressEvent):
1886         (WebCore::FrameView::setMousePressed):
1887         * page/FrameView.h:
1888         * platform/win/TemporaryLinkStubs.cpp:
1889         (FrameView::passMousePressEventToScrollbar):
1890
1891 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
1892
1893         Reviewed by Darin.
1894
1895         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
1896         Add more SVG Objective-C DOM bindings
1897
1898         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
1899           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
1900           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
1901           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
1902           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
1903           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
1904
1905         * DerivedSources.make:
1906         * WebCore.xcodeproj/project.pbxproj:
1907         * bindings/objc/DOMInternal.h:
1908         * bindings/objc/DOMSVG.h:
1909         * bindings/scripts/CodeGeneratorObjC.pm:
1910         * ksvg2/svg/SVGAElement.idl:
1911         * ksvg2/svg/SVGAnimateColorElement.idl:
1912         * ksvg2/svg/SVGAnimateElement.idl:
1913         * ksvg2/svg/SVGAnimateTransformElement.idl:
1914         * ksvg2/svg/SVGAnimatedPathData.idl:
1915         * ksvg2/svg/SVGAnimatedPoints.idl:
1916         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
1917         * ksvg2/svg/SVGAnimationElement.idl:
1918         * ksvg2/svg/SVGCircleElement.idl:
1919         * ksvg2/svg/SVGClipPathElement.idl:
1920         * ksvg2/svg/SVGColor.idl:
1921         * ksvg2/svg/SVGCursorElement.idl:
1922         * ksvg2/svg/SVGDefsElement.idl:
1923         * ksvg2/svg/SVGDescElement.idl:
1924         * ksvg2/svg/SVGDocument.idl:
1925         * ksvg2/svg/SVGEllipseElement.idl:
1926         * ksvg2/svg/SVGPointList.idl:
1927         * ksvg2/svg/SVGPreserveAspectRatio.idl:
1928         * ksvg2/svg/SVGRect.idl:
1929         * ksvg2/svg/SVGSVGElement.idl:
1930
1931 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
1932
1933         Reviewed by Adele.
1934
1935         - fix build
1936
1937         * platform/FloatRect.h:
1938         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
1939         but more appropriate for path-type stuff.
1940         * platform/cg/PathCG.cpp:
1941         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
1942
1943 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
1944
1945         Reviewed by Darin.
1946
1947         http://bugs.webkit.org/show_bug.cgi?id=11011
1948         External CSS is parsed as iso-8859-1 even though the main document is utf-8
1949
1950         Test: fast/encoding/css-charset-default.xhtml
1951
1952         * loader/CachedResourceClient.h:
1953         (WebCore::CachedResourceClient::setCSSStyleSheet):
1954         (WebCore::CachedResourceClient::setXSLStyleSheet):
1955         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
1956         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
1957
1958         * css/CSSImportRule.cpp:
1959         (WebCore::CSSImportRule::setCSSStyleSheet):
1960         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
1961         * css/CSSImportRule.h:
1962
1963         * css/CSSStyleSheet.cpp:
1964         (WebCore::CSSStyleSheet::CSSStyleSheet):
1965         * css/CSSStyleSheet.h:
1966         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
1967         member. Changed some String parameters to const String&.
1968
1969         * css/StyleSheet.cpp:
1970         (WebCore::StyleSheet::StyleSheet):
1971         * css/StyleSheet.h:
1972         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
1973
1974         * css/StyleSheetList.cpp:
1975         (WebCore::StyleSheetList::length):
1976         (WebCore::StyleSheetList::item):
1977         * css/StyleSheetList.h:
1978         Special-casing implicit stylesheets seemed to be dead code, removed.
1979
1980         * dom/Document.cpp:
1981         (WebCore::Document::setCSSStyleSheet):
1982         (WebCore::Document::recalcStyleSelector):
1983         * dom/Document.h:
1984         Renamed setStyleSheet() to setCSSStyleSheet().
1985
1986         * dom/ProcessingInstruction.cpp:
1987         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
1988         (WebCore::ProcessingInstruction::setCSSStyleSheet):
1989         (WebCore::ProcessingInstruction::setXSLStyleSheet):
1990         (WebCore::ProcessingInstruction::parseStyleSheet):
1991         * dom/ProcessingInstruction.h:
1992
1993         * html/HTMLLinkElement.cpp:
1994         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
1995         is not specified.
1996         (WebCore::HTMLLinkElement::setCSSStyleSheet):
1997         * html/HTMLLinkElement.h:
1998
1999         * html/HTMLStyleElement.cpp:
2000         (WebCore::HTMLStyleElement::childrenChanged):
2001         * ksvg2/svg/SVGStyleElement.cpp:
2002         (WebCore::SVGStyleElement::childrenChanged):
2003         Inherit URL and charset from the document.
2004
2005         * loader/Cache.cpp:
2006         (WebCore::Cache::requestCSSStyleSheet):
2007         * loader/Cache.h:
2008         Adjust for setStyleSheet() renaming.
2009
2010         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
2011         * loader/CachedCSSStyleSheet.cpp:
2012         (WebCore::CachedCSSStyleSheet::ref):
2013         (WebCore::CachedCSSStyleSheet::deref):
2014         (WebCore::CachedCSSStyleSheet::checkNotify):
2015         Pass the encoding to setCSSStyleSheet().
2016
2017         * loader/CachedXSLStyleSheet.cpp:
2018         (WebCore::CachedXSLStyleSheet::ref):
2019         (WebCore::CachedXSLStyleSheet::checkNotify):
2020         * loader/DocLoader.cpp:
2021         (WebCore::DocLoader::requestCSSStyleSheet):
2022         * loader/DocLoader.h:
2023         * page/Frame.cpp:
2024         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
2025         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
2026         * xml/XSLImportRule.cpp:
2027         (WebCore::XSLImportRule::setXSLStyleSheet):
2028         (WebCore::XSLImportRule::loadSheet):
2029         * xml/XSLImportRule.h:
2030         Adjust for setStyleSheet() renaming.
2031
2032 2006-09-30  Rob Buis  <buis@kde.org>
2033
2034         Reviewed by eseidel.
2035
2036         http://bugs.webkit.org/show_bug.cgi?id=11096
2037         Hit testing for polylines fails
2038
2039         Fix Path::contains so it handles filled, non-closed paths too.
2040
2041         * platform/cg/PathCG.cpp:
2042         (WebCore::Path::contains):
2043
2044 2006-09-30  Dave Hyatt  <hyatt@apple.com>
2045
2046         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
2047         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
2048         subframes while the mouse is down.
2049
2050         Reviewed by mitzpettel
2051
2052         * bridge/mac/FrameMac.h:
2053         * bridge/mac/FrameMac.mm:
2054         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
2055         (WebCore::FrameMac::passWheelEventToWidget):
2056         * bridge/mac/FrameViewMac.mm:
2057         (WebCore::FrameView::passMousePressEventToSubframe):
2058         (WebCore::FrameView::passMouseMoveEventToSubframe):
2059         (WebCore::FrameView::passMouseReleaseEventToSubframe):
2060         (WebCore::FrameView::passWheelEventToSubframe):
2061         * page/Frame.cpp:
2062         * page/Frame.h:
2063         * page/FrameView.cpp:
2064         (WebCore::subframeForTargetNode):
2065         (WebCore::FrameView::handleMousePressEvent):
2066         (WebCore::FrameView::handleMouseDoubleClickEvent):
2067         (WebCore::FrameView::handleMouseMoveEvent):
2068         (WebCore::FrameView::handleMouseReleaseEvent):
2069         (WebCore::FrameView::handleWheelEvent):
2070         * page/FrameView.h:
2071         * platform/ScrollBar.h:
2072         (WebCore::ScrollBar::handleMouseMoveEvent):
2073         (WebCore::ScrollBar::handleMouseOutEvent):
2074         * platform/Widget.h:
2075         (WebCore::Widget::handleMouseMoveEvent):
2076         (WebCore::Widget::handleMouseReleaseEvent):
2077         * platform/win/TemporaryLinkStubs.cpp:
2078         (FrameView::passMousePressEventToSubframe):
2079         (FrameView::passMouseMoveEventToSubframe):
2080         (FrameView::passMouseReleaseEventToSubframe):
2081         (FrameView::passWheelEventToSubframe):
2082         (Widget::capturingMouse):
2083         (Widget::setCapturingMouse):
2084         (Widget::capturingTarget):
2085         (Widget::capturingChild):
2086         (Widget::setCapturingChild):
2087         * rendering/RenderView.cpp:
2088         (WebCore::RenderView::paintBoxDecorations):
2089
2090 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
2091
2092         Reviewed by Adele.
2093
2094         Fixes windows bustage:
2095         http://bugs.webkit.org/show_bug.cgi?id=11093
2096
2097         * platform/win/PlatformScrollBar.h:
2098         * platform/win/TemporaryLinkStubs.cpp:
2099         (PlatformScrollBar::PlatformScrollBar):
2100         (ScrollBar::ScrollBar):
2101
2102 2006-09-29  David Hyatt  <hyatt@apple.com>
2103
2104         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
2105         in RenderObject::NodeInfo (and then propagating that Widget to
2106         MouseEventWithHitTestResults).
2107
2108         This allows RenderListBox and RenderBlock to do the same thing when the
2109         mouse is over the scrollbar.
2110
2111         Also land fix to support font-size: 0.
2112
2113         Reviewed by mjs (scrollbar), eric (font-size)
2114
2115         * dom/Document.cpp:
2116         (WebCore::Document::prepareMouseEvent):
2117         * page/Frame.cpp:
2118         (WebCore::Frame::passWidgetMouseDownEventToWidget):
2119         * page/FrameView.cpp:
2120         (WebCore::selectCursor):
2121         (WebCore::FrameView::handleMouseMoveEvent):
2122         (WebCore::FrameView::dispatchMouseEvent):
2123         * page/MouseEventWithHitTestResults.cpp:
2124         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2125         * page/MouseEventWithHitTestResults.h:
2126         (WebCore::MouseEventWithHitTestResults::scrollbar):
2127         * rendering/RenderBlock.cpp:
2128         (WebCore::RenderBlock::isPointInScrollbar):
2129         (WebCore::RenderBlock::nodeAtPoint):
2130         * rendering/RenderBlock.h:
2131         * rendering/RenderLayer.cpp:
2132         (WebCore::RenderLayer::hitTest):
2133         * rendering/RenderLayer.h:
2134         (WebCore::RenderLayer::getHiddenBehavior):
2135         * rendering/RenderListBox.cpp:
2136         (WebCore::RenderListBox::RenderListBox):
2137         (WebCore::RenderListBox::~RenderListBox):
2138         (WebCore::RenderListBox::isPointInScrollbar):
2139         * rendering/RenderListBox.h:
2140         * rendering/RenderObject.h:
2141         (WebCore::RenderObject::NodeInfo::NodeInfo):
2142         (WebCore::RenderObject::NodeInfo::scrollbar):
2143         (WebCore::RenderObject::NodeInfo::setScrollbar):
2144
2145 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
2146
2147         Reviewed by Adele.
2148
2149         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
2150
2151         * platform/win/ScrollViewWin.cpp:
2152         (WebCore::ScrollView::convertToContainingWindow):
2153         (WebCore::ScrollView::convertFromContainingWindow):
2154         * platform/win/WidgetWin.cpp:
2155         (WebCore::Widget::convertToContainingWindow):
2156         (WebCore::Widget::convertFromContainingWindow):
2157
2158 2006-09-29  Adele Peterson  <adele@apple.com>
2159
2160         Updated with new argument for PlatformScrollBar.
2161
2162         * platform/win/TemporaryLinkStubs.cpp:
2163         (PlatformScrollBar::PlatformScrollBar):
2164
2165 2006-09-29  Adele Peterson  <adele@apple.com>
2166
2167         Reviewed by Hyatt.
2168
2169         Fixing build bustage with cast to int.
2170
2171         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
2172
2173 2006-09-29  Adele Peterson  <adele@apple.com>
2174
2175         Fixing accidental include.
2176
2177         * rendering/RenderListBox.cpp:
2178
2179 2006-09-29  Adele Peterson  <adele@apple.com>
2180
2181         Adding RenderListBox files.
2182
2183         * WebCore.vcproj/WebCore/WebCore.vcproj:
2184
2185 2006-09-29  Adele Peterson  <adele@apple.com>
2186
2187         Reviewed by Adam.
2188
2189         Initial implementation of engine-based list box control.
2190
2191         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
2192
2193         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
2194         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
2195         (WebCore::FrameMac::FrameMac):
2196         (WebCore::FrameMac::handleMousePressEvent):
2197         (WebCore::FrameMac::handleMouseMoveEvent):
2198         (WebCore::FrameMac::mouseDown):
2199
2200         * page/Frame.cpp:
2201         (WebCore::Frame::handleMouseMoveEvent):
2202         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
2203         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
2204         (WebCore::Frame::autoscrollTimerFired): ditto.
2205         (WebCore::Frame::stopAutoscrollTimer): ditto.
2206         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
2207         * page/Frame.h:
2208         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
2209
2210         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
2211         (WebCore::FrameViewPrivate::reset):
2212         (WebCore::FrameView::currentMousePosition):
2213         (WebCore::FrameView::handleMousePressEvent):
2214         (WebCore::FrameView::handleMouseDoubleClickEvent):
2215         (WebCore::selectCursor):
2216         (WebCore::FrameView::handleMouseMoveEvent):
2217         (WebCore::FrameView::handleMouseReleaseEvent):
2218         * page/FrameView.h:
2219
2220         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
2221         * platform/ScrollBar.h:
2222         (WebCore::):
2223         (WebCore::ScrollBar::controlSize):
2224         * platform/mac/PlatformScrollBar.h:
2225         * platform/mac/PlatformScrollBarMac.mm:
2226         (NSControlSizeForScrollBarControlSize):
2227         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
2228         (WebCore::PlatformScrollBar::PlatformScrollBar):
2229
2230         * rendering/RenderBlock.h:
2231         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
2232         * rendering/RenderLayer.h:
2233         * rendering/RenderObject.cpp:
2234         (WebCore::RenderObject::shouldAutoscroll):
2235         (WebCore::RenderObject::autoscroll):
2236         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
2237
2238         * css/html4.css: Added properties for new list boxes.
2239
2240         * html/HTMLOptionElement.cpp:
2241         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
2242         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
2243         * html/HTMLOptionElement.h: Added disabled method.
2244
2245         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
2246         (WebCore::HTMLSelectElement::recalcStyle):
2247         (WebCore::HTMLSelectElement::lastSelectedListIndex):
2248         (WebCore::HTMLSelectElement::deselectItems):
2249         (WebCore::HTMLSelectElement::setSelectedIndex):
2250         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2251         (WebCore::HTMLSelectElement::isMouseFocusable):
2252         (WebCore::HTMLSelectElement::createRenderer):
2253         (WebCore::HTMLSelectElement::recalcListItems):
2254         (WebCore::HTMLSelectElement::setRecalcListItems):
2255         (WebCore::HTMLSelectElement::reset):
2256         (WebCore::HTMLSelectElement::notifyOptionSelected):
2257         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
2258         (WebCore::HTMLSelectElement::nextSelectableListIndex):
2259         (WebCore::HTMLSelectElement::previousSelectableListIndex):
2260         * html/HTMLSelectElement.h:
2261
2262         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
2263         (WebCore::RenderTheme::paint):
2264         (WebCore::RenderTheme::paintBorderOnly):
2265         (WebCore::RenderTheme::paintDecorations):
2266         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
2267         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
2268         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
2269         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
2270         (WebCore::RenderTheme::isControlStyled):
2271         (WebCore::RenderTheme::supportsFocusRing):
2272         * rendering/RenderTheme.h:
2273         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
2274
2275         * rendering/RenderListBox.cpp: Added.
2276         (WebCore::RenderListBox::RenderListBox):
2277         (WebCore::RenderListBox::~RenderListBox):
2278         (WebCore::RenderListBox::setStyle):
2279         (WebCore::RenderListBox::updateFromElement):
2280         (WebCore::RenderListBox::calcMinMaxWidth):
2281         (WebCore::RenderListBox::size):
2282         (WebCore::RenderListBox::numItems):
2283         (WebCore::RenderListBox::calcHeight):
2284         (WebCore::RenderListBox::baselinePosition):
2285         (WebCore::RenderListBox::itemBoundingBoxRect):
2286         (WebCore::RenderListBox::paintObject):
2287         (WebCore::RenderListBox::paintScrollbar):
2288         (WebCore::RenderListBox::paintItemForeground):
2289         (WebCore::RenderListBox::paintItemBackground):
2290         (WebCore::RenderListBox::scrollBarTarget):
2291         (WebCore::RenderListBox::isPointInScrollbar):
2292         (WebCore::RenderListBox::optionAtPoint):
2293         (WebCore::RenderListBox::autoscroll):
2294         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
2295         (WebCore::RenderListBox::scroll):
2296         (WebCore::RenderListBox::valueChanged):
2297         * rendering/RenderListBox.h: Added.
2298         (WebCore::RenderListBox::isListBox):
2299         (WebCore::RenderListBox::selectionChanged):
2300         (WebCore::RenderListBox::setSelectionChanged):
2301         (WebCore::RenderListBox::canHaveChildren):
2302         (WebCore::RenderListBox::renderName):
2303         (WebCore::RenderListBox::setOptionsChanged):
2304         (WebCore::RenderListBox::shouldAutoscroll):
2305         (WebCore::RenderListBox::listIndexIsVisible):
2306
2307 2006-09-29  Beth Dakin  <bdakin@apple.com>
2308
2309         Reviewed by Darin.
2310
2311         We had a bug where html4.css was ignoring Media Queries. In the end
2312         the problem was that we were trying to send a char* to the
2313         MediaQueryEvaluator constructor that expects a String, but the
2314         char* got interpreted as a bool, the wrong constructor was called,
2315         and the media type was never set.
2316
2317         No test case possible since this only affects html4.css
2318
2319         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
2320         char*
2321         (WebCore::MediaQueryEvaluator):
2322         * css/MediaQueryEvaluator.h: Same.
2323
2324 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
2325
2326         Reviewed by John, Maciej.
2327
2328         Integrated some frame and iframe code. I'm trying to fix up frame ownership
2329         and loading. Reducing the number of different code paths involved
2330         seemed like a good first step.
2331
2332         As a side effect, I fixed a bug where FRAME elements would report their
2333         src attributes as relative, rather than compelete, URLs. (IFRAME elements
2334         had the correct complete URL behavior.)
2335
2336         * html/HTMLFrameElement.cpp:
2337         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
2338         (WebCore::HTMLFrameElement::openURL):
2339             (1) Removed checks that requestFrame does for us
2340             (2) Added isURLAllowed check, to have one clear bottleneck for it
2341             (3) Added viewsource check, to have one clear bottleneck for it
2342         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
2343         method, instead of finding our content frame in our own unique way.
2344         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
2345         since openURL does this for us now.
2346         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
2347         This is what FF does, and it made no sense to have different behaviors
2348         for FRAME and IFRAME elements.
2349         * html/HTMLIFrameElement.cpp:
2350         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
2351         code.
2352         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
2353         HTMLFrameElement now does everything we need.
2354
2355 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
2356
2357         Reviewed by Hyatt.
2358
2359         Fix Qt/Linux build.
2360
2361         * CMakeLists.txt:
2362         * platform/qt/ScrollViewQt.cpp:
2363         (WebCore::ScrollView::convertToContainingWindow):
2364         (WebCore::ScrollView::convertFromContainingWindow):
2365         * platform/qt/TemporaryLinkStubs.cpp:
2366         (WebCore::signedPublicKeyAndChallengeString):
2367         * platform/qt/WidgetQt.cpp:
2368         (WebCore::Widget::convertToContainingWindow):
2369         (WebCore::Widget::convertFromContainingWindow):
2370
2371 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
2372
2373         Reviewed by Tim H.
2374
2375         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
2376         Simplify Internal methods for the auto-generated Objective-C DOM code
2377
2378         - Auto-generate the internal methods for more Objective-C classes.
2379
2380         * WebCore.xcodeproj/project.pbxproj:
2381         * bindings/objc/DOM.mm:
2382         * bindings/objc/DOMCSS.mm:
2383         (-[DOMStyleSheet WebCore::]):
2384         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2385         (-[DOMCSSRule WebCore::]):
2386         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
2387         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2388         (-[DOMCSSValue WebCore::]):
2389         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
2390         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2391         * bindings/objc/DOMHTMLAppletElement.mm:
2392         (-[DOMHTMLAppletElement WebCore::]):
2393         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
2394         * bindings/objc/DOMHTMLEmbedElement.mm:
2395         (-[DOMHTMLEmbedElement WebCore::]):
2396         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
2397         * bindings/objc/DOMInternal.h:
2398         * bindings/objc/DOMInternal.mm:
2399         * bindings/scripts/CodeGeneratorObjC.pm:
2400         * css/CSSCharsetRule.idl:
2401         * css/CSSFontFaceRule.idl:
2402         * css/CSSImportRule.idl:
2403         * css/CSSMediaRule.idl:
2404         * css/CSSPageRule.idl:
2405         * css/CSSPrimitiveValue.idl:
2406         * css/CSSStyleRule.idl:
2407         * css/CSSStyleSheet.idl:
2408         * css/CSSUnknownRule.idl:
2409         * css/CSSValueList.idl:
2410         * dom/KeyboardEvent.idl:
2411         * dom/MouseEvent.idl:
2412         * dom/MutationEvent.idl:
2413         * dom/NodeIterator.idl:
2414         * dom/OverflowEvent.idl:
2415         * dom/UIEvent.idl:
2416         * dom/WheelEvent.idl:
2417
2418 2006-09-29  David Harrison  <harrison@apple.com>
2419
2420         Reviewed by John Sullivan.
2421
2422         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
2423         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
2424
2425         Test added
2426         * fast/text/attributed-substring-from-range-001.html
2427
2428         * bridge/mac/FrameMac.mm:
2429         (WebCore::FrameMac::attributedString):
2430         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
2431         Also, add validation of the range.
2432
2433 2006-09-29  Rob Buis  <buis@kde.org>
2434
2435         Reviewed by Maciej.
2436
2437         http://bugs.webkit.org/show_bug.cgi?id=10893
2438         InsertRule can not handle @import statements
2439
2440         Allow @import as part of a css rule.
2441
2442         * css/CSSGrammar.y:
2443
2444 2006-09-28  David Hyatt  <hyatt@apple.com>
2445
2446         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
2447
2448         * bridge/mac/FrameMac.mm:
2449         (WebCore::FrameMac::eventMayStartDrag):
2450         (WebCore::FrameMac::dragHysteresisExceeded):
2451         (WebCore::FrameMac::mouseDown):
2452         (WebCore::FrameMac::shouldDragAutoNode):
2453         (WebCore::FrameMac::sendContextMenuEvent):
2454         * bridge/mac/WebCoreFrameBridge.mm:
2455         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
2456
2457 2006-09-28  Dave Hyatt  <hyatt@apple.com>
2458
2459         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
2460         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
2461         view.
2462
2463         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
2464         the patch after review, once I realized that these new functions essentially do the same thing.)
2465
2466         * dom/EventTargetNode.cpp:
2467         (WebCore::EventTargetNode::dispatchMouseEvent):
2468         (WebCore::EventTargetNode::dispatchWheelEvent):
2469         * page/Frame.cpp:
2470         (WebCore::Frame::selectClosestWordFromMouseEvent):
2471         (WebCore::Frame::handleMousePressEventTripleClick):
2472         (WebCore::Frame::handleMousePressEventSingleClick):
2473         (WebCore::Frame::handleMouseMoveEvent):
2474         (WebCore::Frame::handleMouseReleaseEvent):
2475         * page/FrameView.cpp:
2476         (WebCore::FrameView::handleMousePressEvent):
2477         (WebCore::selectCursor):
2478         (WebCore::FrameView::dispatchDragEvent):
2479         (WebCore::FrameView::prepareMouseEvent):
2480         (WebCore::FrameView::handleWheelEvent):
2481         * platform/ScrollView.h:
2482         * platform/Widget.cpp:
2483         (WebCore::Widget::convertToContainingWindow):
2484         * platform/Widget.h:
2485         * platform/mac/ScrollViewMac.mm:
2486         (WebCore::ScrollView::convertToContainingWindow):
2487         (WebCore::ScrollView::convertFromContainingWindow):
2488         * platform/mac/WidgetMac.mm:
2489         (WebCore::Widget::convertToContainingWindow):
2490         (WebCore::Widget::convertFromContainingWindow):
2491         * platform/win/ScrollViewWin.cpp:
2492         (WebCore::ScrollView::convertToContainingWindow):
2493         (WebCore::ScrollView::convertFromContainingWindow):
2494         * rendering/RenderLayer.cpp:
2495         (WebCore::RenderLayer::resize):
2496
2497 2006-09-28  Alice Liu  <alice.liu@apple.com>
2498
2499         Build fix by adding missing files for CommandByName
2500
2501         * WebCore.xcodeproj/project.pbxproj:
2502
2503 2006-09-28  Alice Liu  <alice.liu@apple.com>
2504
2505         Adding CommandByName files to the vcproj
2506
2507         * WebCore.vcproj/WebCore/WebCore.vcproj:
2508
2509 2006-09-28  Alice Liu  <alice.liu@apple.com>
2510
2511         Reviewed by Adam Roben.
2512
2513         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
2514         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
2515         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
2516
2517         * editing/CommandByName.cpp: Added.
2518         Added a command class that hangs off the frame so the frame can call commands more easily.
2519         (WebCore::Frame::commandImp):
2520         (WebCore::Frame::execCopy):
2521         (WebCore::Frame::execCut):
2522         (WebCore::Frame::execDelete):
2523         (WebCore::Frame::execForwardDelete):
2524         (WebCore::Frame::execPaste):
2525         (WebCore::Frame::execMoveLeft):
2526         (WebCore::Frame::execMoveRight):
2527         (WebCore::Frame::execMoveUp):
2528         (WebCore::Frame::execMoveDown):
2529         (WebCore::Frame::execSelectAll):
2530         (WebCore::Frame::execSelectLeft):
2531         (WebCore::Frame::execSelectRight):
2532         (WebCore::Frame::execSelectUp):
2533         (WebCore::Frame::execSelectDown):
2534         (WebCore::Frame::enabled):
2535         (WebCore::Frame::enabledAnySelection):
2536         (WebCore::Frame::enabledAnyEditableSelection):
2537         (WebCore::Frame::enabledPaste):
2538         (WebCore::Frame::enabledAnyRangeSelection):
2539         (WebCore::Frame::enabledAnyEditableRangeSelection):
2540         (WebCore::Frame::createCommandDictionary):
2541         (WebCore::Frame::Command::):
2542         (WebCore:::m_frame):
2543         (WebCore::CommandByName::execCommand):
2544         * editing/CommandByName.h: Added.
2545         * page/Frame.cpp:
2546         Added implementation of accessor for CommandByName member
2547         (WebCore::Frame::command):
2548         * page/Frame.h:
2549         Added accessor for CommandByName member
2550         * page/FramePrivate.h:
2551         Added a CommandByName member
2552         (WebCore::FramePrivate::FramePrivate):
2553         * platform/PlatformMouseEvent.h:
2554         Changed constructor prototype
2555         * platform/StringImpl.cpp:
2556         Exposing getWordBreakIterator to be used elsewhere
2557         (WebCore::getWordBreakIterator):
2558         * platform/StringImpl.h:
2559         Exposing getWordBreakIterator to be used elsewhere
2560         * platform/win/MouseEventWin.cpp:
2561         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
2562         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2563
2564 2006-09-28  Adam Roben  <aroben@apple.com>
2565
2566         Reviewed by Adele.
2567
2568         Remove no-longer-used PopUpButton.
2569
2570         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
2571         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
2572         PopUpButtonMac.mm
2573         * platform/PopUpButton.h: Removed.
2574         * platform/mac/PopUpButtonMac.mm: Removed.
2575         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
2576         * rendering/DeprecatedRenderSelect.cpp: Change #include of
2577         PopUpButton.h to ListBox.h
2578
2579 2006-09-28  Darin Adler  <darin@apple.com>
2580
2581         Reviewed by Alice.
2582
2583         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
2584           10% perf. regression (copying strings while decoding)
2585
2586         Use Vector<UChar> instead of String when building up the decoded string in
2587         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
2588         String grows the buffer every single time that append is called. Using
2589         Vector::append instead of String::append also avoids constructing a string
2590         each time just to append and a questionable copy that is done inside the
2591         String::append function which also contributed to the slowness.
2592
2593         * platform/PlatformString.h:
2594         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
2595         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
2596         allocation.
2597         * platform/StringImpl.h:
2598         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
2599
2600         * platform/StreamingTextDecoder.h:
2601         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
2602         Change to use a Vector<UChar> instead of a String, since vectors have better
2603         resizing performance (they store a separate capacity).
2604
2605         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
2606         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
2607         Change to use Vector<UChar> instead of String and then create a string at
2608         the end of the process using the new adopt function.
2609
2610 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
2611
2612         Reviewed by Tim H.
2613
2614         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
2615         Auto-generate more SVG Objective-C bindings
2616
2617         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
2618           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
2619           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
2620           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
2621           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
2622           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
2623           and DOMSVGTransformable.
2624
2625         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
2626           parent interfaces and the SVG animated classes.
2627
2628         - Corrects CodeGenerator.pm to only skip the first parent for the main
2629           interface.
2630
2631         * DerivedSources.make:
2632         * WebCore.xcodeproj/project.pbxproj:
2633         * bindings/objc/DOMInternal.h:
2634         * bindings/objc/DOMSVG.h:
2635         * bindings/scripts/CodeGenerator.pm:
2636         * bindings/scripts/CodeGeneratorObjC.pm:
2637         * ksvg2/svg/SVGAnimatedAngle.idl:
2638         * ksvg2/svg/SVGAnimatedBoolean.idl:
2639         * ksvg2/svg/SVGAnimatedEnumeration.idl:
2640         * ksvg2/svg/SVGAnimatedInteger.idl:
2641         * ksvg2/svg/SVGAnimatedLength.idl:
2642         * ksvg2/svg/SVGAnimatedLengthList.idl:
2643         * ksvg2/svg/SVGAnimatedNumber.idl:
2644         * ksvg2/svg/SVGAnimatedPathData.idl:
2645         * ksvg2/svg/SVGAnimatedString.idl:
2646         * ksvg2/svg/SVGAnimatedTransformList.idl:
2647         * ksvg2/svg/SVGExternalResourcesRequired.idl:
2648         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
2649         * ksvg2/svg/SVGFitToViewBox.idl:
2650         * ksvg2/svg/SVGLangSpace.idl:
2651         * ksvg2/svg/SVGLocatable.idl:
2652         * ksvg2/svg/SVGMetadataElement.idl:
2653         * ksvg2/svg/SVGStringList.idl:
2654         * ksvg2/svg/SVGStylable.idl:
2655         * ksvg2/svg/SVGStyleElement.idl:
2656         * ksvg2/svg/SVGTests.idl:
2657         * ksvg2/svg/SVGTransformable.idl:
2658         * ksvg2/svg/SVGURIReference.idl:
2659         * ksvg2/svg/SVGUnitTypes.idl:
2660         * ksvg2/svg/SVGZoomAndPan.idl:
2661
2662 2006-09-28  Brady Eidson  <beidson@apple.com>
2663
2664         Reviewed by Mitz Pettel!!!
2665
2666         Change the error code check for common functions from SQLResultOk to SQLResultDone
2667
2668         * loader/icon/IconDatabase.cpp:
2669         (WebCore::IconDatabase::forgetPageURLQuery):
2670         (WebCore::IconDatabase::setIconIDForPageURLQuery):
2671         (WebCore::IconDatabase::addIconForIconURLQuery):
2672
2673 2006-09-28  Dave Hyatt  <hyatt@apple.com>
2674
2675         Just eliminate MapWindowPoints usage and use the HWND as
2676         the viewport.
2677
2678         * platform/win/MouseEventWin.cpp:
2679         (WebCore::positionForEvent):
2680         * platform/win/ScrollViewWin.cpp:
2681         (WebCore::ScrollView::viewportToContents):
2682         (WebCore::ScrollView::contentsToViewport):
2683
2684 2006-09-27  David Hyatt  <hyatt@apple.com>
2685
2686         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
2687         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
2688         scrollbars to provide hover feedback if needed.
2689
2690         Reviewed by Eric
2691
2692         * page/FrameView.cpp:
2693         (WebCore::selectCursor):
2694         (WebCore::FrameView::handleMouseMoveEvent):
2695         * platform/ScrollBar.h:
2696         (WebCore::ScrollBar::mouseMoved):
2697
2698 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
2699
2700         Reviewed by Maciej and Adam, landed by Adam
2701
2702         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
2703         Windows build is busted
2704
2705         * platform/win/TemporaryLinkStubs.cpp:
2706         (ScrollView::paint):
2707         (ScrollView::themeChanged):
2708
2709 2006-09-27  Eric Seidel  <eric@eseidel.com>
2710
2711         Reviewed by mitz.
2712
2713         paths with no fill specified default to black but do not recieve paint-related mouse events
2714         http://bugs.webkit.org/show_bug.cgi?id=11069
2715         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
2716
2717         Test: svg/custom/hover-default-fill.svg
2718
2719         * kcanvas/RenderPath.cpp:
2720         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
2721         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
2722         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2723         (WebCore::KSVGPainterFactory::isFilled): remove null check
2724         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
2725         (WebCore::KSVGPainterFactory::isStroked): remove null check
2726         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
2727         * ksvg2/svg/SVGPaint.cpp:
2728         (WebCore::SVGPaint::defaultFill): added.
2729         (WebCore::SVGPaint::defaultStroke): added.
2730         * ksvg2/svg/SVGPaint.h:
2731
2732 2006-09-27  Rob Buis  <buis@kde.org>
2733
2734         Reviewed by eseidel.
2735
2736         http://bugs.webkit.org/show_bug.cgi?id=11015
2737         SVG handles em units incorrectly
2738
2739         Calculate viewport coordinates at layout time, since
2740         at this point the font size is known and lengths depending
2741         on font sizes can be calculated correctly.
2742
2743         * kcanvas/RenderSVGContainer.cpp:
2744         (WebCore::RenderSVGContainer::layout):
2745         (WebCore::RenderSVGContainer::viewport):
2746         (WebCore::RenderSVGContainer::calcViewport):
2747         * kcanvas/RenderSVGContainer.h:
2748         * ksvg2/svg/SVGLength.cpp:
2749         (WebCore::SVGLength::updateValue):
2750         * ksvg2/svg/SVGMarkerElement.cpp:
2751         (WebCore::SVGMarkerElement::createRenderer):
2752         * ksvg2/svg/SVGSVGElement.cpp:
2753         (WebCore::SVGSVGElement::createRenderer):
2754         (WebCore::SVGSVGElement::attributeChanged):
2755         * ksvg2/svg/SVGSVGElement.h:
2756
2757 2006-09-27  Eric Seidel  <eric@eseidel.com>
2758
2759         Reviewed by darin.
2760
2761         Change our invalid-fill error behavior to match Opera (and soon Firefox)
2762         http://bugs.webkit.org/show_bug.cgi?id=11017
2763
2764         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2765         (WebCore::KSVGPainterFactory::isFilled):
2766         (WebCore::KSVGPainterFactory::fillPaintServer):
2767         (WebCore::KSVGPainterFactory::isStroked):
2768         (WebCore::KSVGPainterFactory::strokePaintServer):
2769
2770 2006-09-27  Brady Eidson  <beidson@apple.com>
2771
2772         Build fix
2773
2774         * loader/icon/IconDatabase.cpp:
2775         (WebCore::readySQLStatement):
2776
2777 2006-09-27  Brady Eidson  <beidson@apple.com>
2778
2779         Reviewed by Adam
2780
2781         In very specific circumstances, prepared SQLStatements can become invalid without
2782         any warning.  This checks for that state and re-prepares the statement and also
2783         adds more aggressive error-checking everywhere these statements are used.
2784
2785         * loader/icon/IconDatabase.cpp:
2786         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
2787         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
2788         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
2789         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
2790         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
2791         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
2792         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
2793         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
2794         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
2795         * loader/icon/SQLStatement.cpp:
2796         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
2797         * loader/icon/SQLStatement.h:
2798
2799 2006-09-26  Darin Adler  <darin@apple.com>
2800
2801         Reviewed by Steve.
2802
2803         - clean up options for font code path
2804
2805         * platform/Font.h:
2806         * platform/Font.cpp:
2807         (WebCore::Font::setCodePath): Added. Replaces boolean version.
2808         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
2809
2810         * platform/mac/WebCoreTextRenderer.mm:
2811         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
2812
2813 2006-09-26  John Sullivan  <sullivan@apple.com>
2814
2815         Reviewed by Darin
2816
2817         * bridge/mac/WebCoreFrameBridge.h:
2818         * bridge/mac/WebCoreFrameBridge.mm:
2819         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
2820         Added limit parameter, passed down to Frame
2821
2822         * page/Frame.h:
2823         * page/Frame.cpp:
2824         (WebCore::Frame::markAllMatchesForText):
2825         Added limit parameter. Stop the search if it hits limit.
2826
2827 2006-09-26  Sean Gies  <seangies@apple.com>
2828
2829         Reviewed by Brady Eidson.
2830
2831         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
2832
2833 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
2834
2835         Reviewed by john
2836
2837         <rdar://problem/4747695>
2838         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
2839
2840         * editing/DeleteSelectionCommand.cpp:
2841         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
2842         to select special elements that are fully selected after expansion
2843         moves to positions that are visually distinct from the originals.
2844         * editing/InsertListCommand.cpp:
2845         (WebCore::InsertListCommand::doApply): If the content of the list
2846         item will be moved into another list, put it in a list item.
2847
2848 2006-09-26  Geoffrey Garen <ggaren@apple.com>
2849
2850         Reviewed by Darin.
2851
2852         Temporary work-around for frame lifetime issue.
2853
2854         * page/Frame.cpp:
2855         (WebCore::Frame::clear):
2856         (WebCore::Frame::disconnectOwnerElement):
2857
2858 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
2859
2860         Reviewed by Tim H.
2861
2862         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
2863         Auto-generate DOMSVGElement for the Objective-C bindings
2864
2865         - Auto-generates DOMSVGElement.
2866
2867         - Make SVGExceptions work like all the other ExceptionCode
2868           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
2869           and SVGExceptionMax.
2870
2871         * DerivedSources.make:
2872         * WebCore.xcodeproj/project.pbxproj:
2873         * bindings/js/kjs_binding.cpp:
2874         (KJS::):
2875         (KJS::setDOMException):
2876         * bindings/objc/DOMInternal.h:
2877         * bindings/objc/DOMInternal.mm:
2878         (raiseDOMException):
2879         * bindings/objc/DOMSVG.h:
2880         * bindings/objc/DOMSVGExecption.h: Added.
2881         * ksvg2/ksvg.h:
2882         * ksvg2/svg/SVGElement.cpp:
2883         (WebCore::SVGElement::setId):
2884         (WebCore::SVGElement::setXmlbase):
2885         * ksvg2/svg/SVGElement.h:
2886         * ksvg2/svg/SVGElement.idl:
2887         * ksvg2/svg/SVGException.h: Added.
2888         (WebCore::):
2889
2890 2006-09-26  Eric Seidel  <eric@eseidel.com>
2891
2892         Reviewed by Tim H.
2893
2894         viewbox parser does not allow <tab> as a delimiter
2895         http://bugs.webkit.org/show_bug.cgi?id=11014
2896
2897         Test: svg/hixie/viewbox/003.xml
2898
2899         * ksvg2/svg/svgpathparser.cpp:
2900         (WebCore::isWhitespace): new function
2901         (WebCore::skipOptionalSpaces):
2902         (WebCore::skipOptionalSpacesOrComma):
2903
2904 2006-09-26  Eric Seidel  <eric@eseidel.com>
2905
2906         Reviewed by Tim H.
2907
2908         SVGDocument::createElement does not create elements in the SVG namespace
2909         http://bugs.webkit.org/show_bug.cgi?id=10932
2910
2911         Test: svg/custom/createelement.svg
2912
2913         * ksvg2/svg/SVGDocument.cpp:
2914         (WebCore::SVGDocument::createElement):
2915         * ksvg2/svg/SVGDocument.h:
2916
2917 2006-09-26  Eric Seidel  <eric@eseidel.com>
2918
2919         Reviewed by Tim H.
2920
2921         RenderPath::nodeAtPoint does not respect stroke width
2922         http://bugs.webkit.org/show_bug.cgi?id=10829
2923
2924         Test: svg/custom/stroke-width-click.svg
2925
2926         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2927         (WebCore::RenderPath::strokeContains):
2928         * kcanvas/device/quartz/QuartzSupport.h:
2929         * kcanvas/device/quartz/QuartzSupport.mm:
2930
2931 2006-09-26  Eric Seidel  <eric@eseidel.com>
2932
2933         Reviewed by mitz.
2934
2935         Bring animation back to life
2936         http://bugs.webkit.org/show_bug.cgi?id=11021
2937
2938         Register/unregister SVGSVGElements as time containers on insertion/removal.
2939         Replace uses of DeprecatedString with String in SVGAnimationElement
2940         Various whitespace clean-up.
2941
2942         * ksvg2/misc/KSVGTimeScheduler.cpp:
2943         (WebCore::SVGTimer::notifyAll):
2944         * ksvg2/misc/SVGDocumentExtensions.cpp:
2945         (WebCore::SVGDocumentExtensions::startAnimations):
2946         (WebCore::SVGDocumentExtensions::pauseAnimations):
2947         (WebCore::SVGDocumentExtensions::unpauseAnimations):
2948         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2949         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2950         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2951         * ksvg2/svg/SVGAnimateTransformElement.h:
2952         * ksvg2/svg/SVGAnimationElement.cpp:
2953         (WebCore::SVGAnimationElement::SVGAnimationElement):
2954         (WebCore::SVGAnimationElement::parseMappedAttribute):
2955         (WebCore::SVGAnimationElement::parseClockValue):
2956         (WebCore::SVGAnimationElement::targetAttribute):
2957         (WebCore::SVGAnimationElement::setTargetAttribute):
2958         (WebCore::SVGAnimationElement::attributeName):
2959         * ksvg2/svg/SVGAnimationElement.h:
2960         (WebCore::SVGAnimationElement::rendererIsNeeded):
2961         * ksvg2/svg/SVGSVGElement.cpp:
2962         (WebCore::SVGSVGElement::getScreenCTM):
2963         (WebCore::SVGSVGElement::createRenderer):
2964         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
2965         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
2966         * ksvg2/svg/SVGSVGElement.h:
2967         * ksvg2/svg/SVGSetElement.cpp:
2968         (WebCore::SVGSetElement::handleTimerEvent):
2969         * ksvg2/svg/SVGURIReference.cpp:
2970         (WebCore::SVGURIReference::getTarget):
2971         * ksvg2/svg/SVGURIReference.h:
2972
2973 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
2974
2975         Reviewed by mitzpettel.
2976
2977         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
2978         No-SVG build broken since r16549
2979
2980         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
2981
2982         * css/cssparser.cpp:
2983         (WebCore::CSSParser::parseValue):
2984         * css/cssstyleselector.cpp:
2985         (WebCore::CSSStyleSelector::applyProperty):
2986         * page/FrameView.cpp:
2987         (WebCore::selectCursor):
2988         * platform/qt/GraphicsContextQt.cpp:
2989
2990 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
2991
2992         Reviewed by Maciej.
2993
2994         http://bugs.webkit.org/show_bug.cgi?id=10820
2995         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
2996
2997         (Originally written by Eric Seidel).
2998
2999         * bindings/js/kjs_window.cpp:
3000         (KJS::floatFeature):
3001         * ksvg2/svg/SVGAngle.cpp:
3002         (SVGAngle::setValueAsString):
3003         * ksvg2/svg/SVGAnimationElement.cpp:
3004         (SVGAnimationElement::parseMappedAttribute):
3005         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3006         (SVGComponentTransferFunctionElement::parseMappedAttribute):
3007         * ksvg2/svg/SVGFECompositeElement.cpp:
3008         (WebCore::SVGFECompositeElement::parseMappedAttribute):
3009         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3010         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3011         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3012         (SVGFEDisplacementMapElement::parseMappedAttribute):
3013         * ksvg2/svg/SVGFELightElement.cpp:
3014         (SVGFELightElement::parseMappedAttribute):
3015         * ksvg2/svg/SVGFEOffsetElement.cpp:
3016         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
3017         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3018         (SVGFESpecularLightingElement::parseMappedAttribute):
3019         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3020         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
3021         * ksvg2/svg/SVGStopElement.cpp:
3022         (SVGStopElement::parseMappedAttribute):
3023         * platform/AtomicString.h:
3024         (WebCore::AtomicString::toDouble):
3025         * platform/PlatformString.h:
3026         * platform/String.cpp:
3027         (WebCore::String::toDouble):
3028         * platform/StringImpl.cpp:
3029         (WebCore::StringImpl::toDouble):
3030         * platform/StringImpl.h:
3031         * rendering/DeprecatedSlider.cpp:
3032         (WebCore::DeprecatedSlider::updateFromElement):
3033         * xml/XPathGrammar.y:
3034
3035 2006-09-25  David Harrison  <harrison@apple.com>
3036
3037         Reviewed by Tim Omernick and Tim Hatcher.
3038
3039         <rdar://problem/4717965> Text Field text parameterized attributes should work
3040         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
3041
3042         * bridge/mac/WebCoreAXObject.mm:
3043         (-[WebCoreAXObject accessibilityAttributeValue:]):
3044         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
3045
3046         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
3047         Cleaned up. Added text field and text area parameterzed attributes.
3048
3049         (-[WebCoreAXObject doAXLineForTextMarker:]):
3050         Fixed to be zero-based and to deal with the first position properly.
3051
3052         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
3053         Minor formatting.
3054
3055         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
3056         (-[WebCoreAXObject indexForTextMarker:]):
3057         (-[WebCoreAXObject textMarkerRangeForRange:]):
3058         (-[WebCoreAXObject rangeForTextMarkerRange:]):
3059         New utility methods.
3060
3061         (-[WebCoreAXObject doAXLineForIndex:]):
3062         (-[WebCoreAXObject doAXRangeForLine:]):
3063         (-[WebCoreAXObject doAXStringForRange:]):
3064         (-[WebCoreAXObject doAXRangeForPosition:]):
3065         (-[WebCoreAXObject doAXRangeForIndex:]):
3066         (-[WebCoreAXObject doAXBoundsForRange:]):
3067         (-[WebCoreAXObject doAXAttributedStringForRange:]):
3068         (-[WebCoreAXObject doAXRTFForRange:]):
3069         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
3070         Implement text field and text area parameterized attributes.
3071
3072         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
3073         Added text field and text area parameterzed attributes.
3074
3075         * rendering/RenderTextControl.h:
3076         Made indexForVisiblePosition() and visiblePositionForIndex() public.
3077
3078 2006-09-25  Adam Roben  <aroben@apple.com>
3079
3080         Reviewed by Brady.
3081
3082         Build fixes.
3083
3084         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
3085         * platform/ResourceLoader.h: Store whether a particular job
3086         has received a response within the ResourceLoader object itself, since
3087         it's possible that we will enter the InternetReadFileExA while loop
3088         twice for the same job.
3089         * platform/ResourceLoaderInternal.h: Add private instance variable to
3090         store whether we've received a response.
3091         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3092         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
3093         directives.
3094         * platform/win/ResourceLoaderWin.cpp:
3095         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
3096         whether it has received a response instead of assuming it hasn't.
3097         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
3098         (WebCore::ResourceLoader::hasReceivedResponse): Added.
3099         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
3100         setProportion
3101         (ScrollBar::setProportion):
3102
3103 2006-09-25  Brady Eidson  <beidson@apple.com>
3104
3105         Requested by ggaren
3106
3107         Disabled IconDatabase logging by default
3108
3109         * platform/Logging.cpp:
3110         (WebCore::):
3111
3112 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
3113
3114         Build fix
3115
3116         * platform/cf/ResourceLoaderCFNet.cpp:
3117         (WebCore::willCacheResponse):
3118
3119 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
3120
3121         Reviewed by john
3122
3123         <http://bugs.webkit.org/show_bug.cgi?id=11002>
3124         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
3125
3126         * editing/IndentOutdentCommand.cpp:
3127         (WebCore::IndentOutdentCommand::indentRegion): Special case
3128         an empty root editable element.
3129
3130 2006-09-25  Brady Eidson  <beidson@apple.com>
3131
3132         Reviewed by Steve
3133
3134         Math error in SystemTimeWin
3135
3136         * platform/win/SystemTimeWin.cpp:
3137         (WebCore::currentTime):
3138
3139 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
3140
3141         Reviewed by Eric.
3142
3143         Whitespace cleanup; rename *job variables to *loader.
3144
3145         * bindings/js/JSXMLHttpRequest.cpp:
3146         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
3147         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
3148         (KJS::JSXMLHttpRequestConstructorImp::construct):
3149         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
3150         (KJS::JSXMLHttpRequest::getValueProperty):
3151         (KJS::JSXMLHttpRequest::put):
3152         (KJS::JSXMLHttpRequest::putValueProperty):
3153         (KJS::JSXMLHttpRequest::mark):
3154         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
3155         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
3156         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
3157         * bindings/js/JSXMLHttpRequest.h:
3158         (KJS::JSXMLHttpRequest::toBoolean):
3159         * xml/xmlhttprequest.cpp:
3160         (WebCore::XMLHttpRequest::XMLHttpRequest):
3161         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
3162         (WebCore::XMLHttpRequest::send):
3163         (WebCore::XMLHttpRequest::abort):
3164         (WebCore::XMLHttpRequest::receivedAllData):
3165         (WebCore::XMLHttpRequest::receivedData):
3166         * xml/xmlhttprequest.h:
3167         (WebCore::):
3168
3169 2006-09-25  Timothy Hatcher  <timothy@apple.com>
3170
3171         Reviewed by Brady.
3172
3173         - Deprecate the rest of the old-style methods that are not generated.
3174         - Add @property syntax to DOMRange.
3175
3176         * WebCore.xcodeproj/project.pbxproj:
3177         * bindings/objc/DOM.mm:
3178         (-[DOMRange setStart:offset:]):
3179         (-[DOMRange setEnd:offset:]):
3180         (-[DOMRange compareBoundaryPoints:sourceRange:]):
3181         (-[DOMRange setStart::]):
3182         (-[DOMRange setEnd::]):
3183         (-[DOMRange compareBoundaryPoints::]):
3184         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3185         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3186         (-[DOMDocument createNodeIterator::::]):
3187         (-[DOMDocument createTreeWalker::::]):
3188         * bindings/objc/DOMCSS.h:
3189         * bindings/objc/DOMCSS.mm:
3190         (-[DOMDocument getComputedStyle:pseudoElement:]):
3191         (-[DOMDocument getComputedStyle::]):
3192         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
3193         * bindings/objc/DOMExtensions.h:
3194         * bindings/objc/DOMHTML.h:
3195         * bindings/objc/DOMRange.h:
3196         * bindings/objc/DOMTraversal.h:
3197
3198 2006-09-25  Eric Seidel  <eric@eseidel.com>
3199
3200         Reviewed by mjs.
3201
3202         Outermost <svg> element should clip to viewport
3203         http://bugs.webkit.org/show_bug.cgi?id=11007
3204
3205         Test: svg/custom/viewport-clip.svg
3206
3207         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
3208
3209 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
3210
3211         Reviewed by Maciej.
3212
3213         * css/MediaList.cpp:
3214         Remove unused header.
3215
3216         * dom/Document.cpp:
3217         (WebCore::Document::clear):
3218         Use clear instead of iterating through the list of event listeners, removing each one.
3219         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
3220
3221         * html/HTMLKeygenElement.cpp:
3222         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
3223         (WebCore::HTMLKeygenElement::appendFormData):
3224         Update due to changes in the SSL key generator.
3225
3226         * ksvg2/svg/SVGAngle.cpp:
3227         Remove unused header.
3228
3229         * ksvg2/svg/SVGAnimationElement.cpp:
3230         (SVGAnimationElement::parseMappedAttribute):
3231         Rename methods and pass Strings instead of DeprecatedStrings to
3232         parseSeparatedList.
3233
3234         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3235         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3236         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3237         * ksvg2/svg/SVGFEMergeElement.cpp:
3238         * ksvg2/svg/SVGFEOffsetElement.cpp:
3239         Remove unused headers.
3240
3241         * ksvg2/svg/SVGHelper.cpp:
3242         (WebCore::SVGHelper::parseSeparatedList):
3243         * ksvg2/svg/SVGHelper.h:
3244         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
3245         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
3246
3247         * ksvg2/svg/SVGLengthList.cpp:
3248         (WebCore::SVGLengthList::parse):
3249         * ksvg2/svg/SVGLengthList.h:
3250         Use Vector<String> instead of DeprecatedStringList.
3251
3252         * loader/Cache.cpp:
3253         (WebCore::Cache::requestImage):
3254         (WebCore::Cache::requestStyleSheet):
3255         (WebCore::Cache::requestScript):
3256         (WebCore::Cache::requestXSLStyleSheet):
3257         (WebCore::Cache::requestXBLDocument):
3258         (WebCore::Cache::remove):
3259         (WebCore::Cache::get):
3260         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
3261
3262         * loader/DocLoader.cpp:
3263         (WebCore::DocLoader::needReload):
3264         * loader/DocLoader.h:
3265         Use a HashSet instead of DeprecatedStringList.
3266
3267         * page/FrameView.h:
3268         Remove declarations that have no functions.
3269
3270         * platform/SSLKeyGenerator.h:
3271         * platform/mac/SSLKeyGeneratorMac.mm:
3272         (WebCore::supportedKeySizes):
3273         (WebCore::signedPublicKeyAndChallengeString):
3274         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
3275         DeprecatedString.
3276
3277 2006-09-25  Dave Hyatt  <hyatt@apple.com>
3278
3279         Shunt the RenderTheme world transform adoption between
3280         Cairo and Windows into getWindowsContext and move the method
3281         out of GraphicsContextCairo and into GraphicsContextWin.
3282
3283         * ChangeLog:
3284         * WebCore.vcproj/WebCore/WebCore.vcproj:
3285         * platform/cairo/GraphicsContextCairo.cpp:
3286         * platform/win/GraphicsContextWin.cpp: Added.
3287         (WebCore::GraphicsContext::getWindowsContext):
3288         (WebCore::GraphicsContext::releaseWindowsContext):
3289         * rendering/RenderThemeWin.cpp:
3290         (WebCore::prepareForDrawing):
3291
3292 2006-09-24  Eric Seidel  <eric@eseidel.com>
3293
3294         Reviewed by hyatt.
3295
3296         <svg:a> cannot be styled with a:hover
3297         http://bugs.webkit.org/show_bug.cgi?id=11005
3298
3299         Test: svg/hixie/cascade/002.xml
3300
3301         * css/cssstyleselector.cpp:
3302         (WebCore::checkPseudoState):
3303
3304 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
3305
3306         Reviewed by Tim H.
3307
3308         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
3309         SVG needs Obj-C DOM bindings
3310
3311         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
3312           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
3313           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
3314           DOMSVGTransformList.
3315
3316         * DerivedSources.make:
3317         * WebCore.xcodeproj/project.pbxproj:
3318         * bindings/objc/DOMInternal.h:
3319         * bindings/objc/DOMSVG.h: Added.
3320         * ksvg2/svg/SVGAngle.idl:
3321         * ksvg2/svg/SVGLength.idl:
3322         * ksvg2/svg/SVGLengthList.idl:
3323         * ksvg2/svg/SVGMatrix.idl:
3324         * ksvg2/svg/SVGPathSeg.idl:
3325         * ksvg2/svg/SVGPathSegList.idl:
3326         * ksvg2/svg/SVGTransform.idl:
3327         * ksvg2/svg/SVGTransformList.idl:
3328
3329 2006-09-24  Rob Buis  <buis@kde.org>
3330
3331         Reviewed by eseidel.
3332
3333         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
3334         WebKit does not handle fallback custom cursors
3335         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
3336         WebKit does not properly handle SVG <cursor> element
3337
3338         Add support for svg cursor images. Also make sure hotspot
3339         settings are handled correctly. Add tests for handling of css3
3340         cursor syntax with hotspots in strict and quirks mode. Finally
3341         implement fallback.
3342
3343         * WebCore.xcodeproj/project.pbxproj:
3344         * css/CSSComputedStyleDeclaration.cpp:
3345         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3346         * css/CSSCursorImageValue.cpp: Added.
3347         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
3348         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
3349         * css/CSSCursorImageValue.h: Added.
3350         (WebCore::CSSCursorImageValue::hotspot):
3351         * css/cssparser.cpp:
3352         (WebCore::CSSParser::parseValue):
3353         * css/cssstyleselector.cpp:
3354         (WebCore::CSSStyleSelector::applyProperty):
3355         * ksvg2/svg/SVGCursorElement.cpp:
3356         * manual-tests/css3-cursor-fallback-quirks.html: Added.
3357         * manual-tests/css3-cursor-fallback-strict.html: Added.
3358         * manual-tests/cursorfallback.xml: Added.
3359         * page/FrameView.cpp:
3360         (WebCore::selectCursor):
3361         * platform/Cursor.h:
3362         * platform/mac/CursorMac.mm:
3363         (WebCore::createCustomCursor):
3364         (WebCore::Cursor::Cursor):
3365         * platform/qt/CursorQt.cpp:
3366         (WebCore::Cursor::Cursor):
3367         * rendering/RenderStyle.cpp:
3368         (WebCore::StyleInheritedData::StyleInheritedData):
3369         (WebCore::StyleInheritedData::operator==):
3370         (WebCore::RenderStyle::diff):
3371         (WebCore::RenderStyle::addCursor):
3372         (WebCore::RenderStyle::addSVGCursor):
3373         (WebCore::RenderStyle::setCursorList):
3374         (WebCore::RenderStyle::clearCursorList):
3375         * rendering/RenderStyle.h:
3376         (WebCore::CursorData::CursorData):
3377         (WebCore::CursorList::operator[]):
3378         (WebCore::CursorList::size):
3379         (WebCore::CursorList::append):
3380         (WebCore::RenderStyle::cursors):
3381
3382 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
3383
3384         Reviewed by Tim H.
3385
3386         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
3387         Auto-generate the internal methods interfaces for the Objective-C bindings
3388
3389         - Auto-generate the internal method declarations into their own files
3390           named in the form DOMFooBarInternal.h for class DOMFooBar.
3391
3392         - Remove all use of DOM_cast from code.
3393
3394         - Assorted cleanups.
3395
3396         * WebCore.xcodeproj/project.pbxproj:
3397         * bindings/objc/DOM.mm:
3398         (-[DOMNode _initWithNode:WebCore::]):
3399         (-[DOMNode WebCore::]):
3400         (-[DOMRange dealloc]):
3401         (-[DOMRange finalize]):
3402         (-[DOMRange _initWithRange:WebCore::]):
3403         (-[DOMRange WebCore::]):
3404         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
3405         (-[DOMNodeFilter WebCore::]):
3406         (-[DOMNodeFilter dealloc]):
3407         (-[DOMNodeFilter finalize]):
3408         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
3409         (-[DOMNodeIterator WebCore::]):
3410         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
3411         (-[DOMTreeWalker WebCore::]):
3412         * bindings/objc/DOMAbstractView.mm:
3413         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
3414         * bindings/objc/DOMCSS.mm:
3415         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
3416         (-[DOMCSSRule _initWithRule:WebCore::]):
3417         (-[DOMCSSValue _initWithValue:WebCore::]):
3418         * bindings/objc/DOMEvents.mm:
3419         (-[DOMEvent _initWithEvent:WebCore::]):
3420         * bindings/objc/DOMHTMLAppletElement.mm:
3421         (-[DOMHTMLAppletElement align]):
3422         (-[DOMHTMLAppletElement setAlign:]):
3423         (-[DOMHTMLAppletElement alt]):
3424         (-[DOMHTMLAppletElement setAlt:]):
3425         (-[DOMHTMLAppletElement archive]):
3426         (-[DOMHTMLAppletElement setArchive:]):
3427         (-[DOMHTMLAppletElement code]):
3428         (-[DOMHTMLAppletElement setCode:]):
3429         (-[DOMHTMLAppletElement codeBase]):
3430         (-[DOMHTMLAppletElement setCodeBase:]):
3431         (-[DOMHTMLAppletElement height]):
3432         (-[DOMHTMLAppletElement setHeight:]):
3433         (-[DOMHTMLAppletElement hspace]):
3434         (-[DOMHTMLAppletElement setHspace:]):
3435         (-[DOMHTMLAppletElement name]):
3436         (-[DOMHTMLAppletElement setName:]):
3437         (-[DOMHTMLAppletElement object]):
3438         (-[DOMHTMLAppletElement setObject:]):
3439         (-[DOMHTMLAppletElement vspace]):
3440         (-[DOMHTMLAppletElement setVspace:]):
3441         (-[DOMHTMLAppletElement width]):
3442         (-[DOMHTMLAppletElement setWidth:]):
3443         * bindings/objc/DOMInternal.h:
3444         (getDOMWrapper):
3445         (addDOMWrapper):
3446         (raiseOnDOMError):
3447         * bindings/objc/DOMXPath.mm:
3448         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3449         * bindings/scripts/CodeGeneratorObjC.pm:
3450
3451 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
3452
3453         Reviewed by eseidel.
3454
3455         Fix Qt/Linux build after Dave's Scrollbar changes.
3456
3457         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
3458         * platform/qt/TemporaryLinkStubs.cpp:
3459         (WebCore::ScrollBar::setProportion):
3460         (WebCore::PlatformScrollBar::updateThumbPosition):
3461         (WebCore::PlatformScrollBar::updateThumbProportion):
3462
3463 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
3464
3465         Reviewed by eseidel.
3466
3467         Qt/Linux build system changes: enable xpath/xslt by default.
3468         Offer possibility to change all of these using 'ccmake'.
3469
3470         * CMakeLists.txt:
3471
3472 2006-09-24  Dave Hyatt  <hyatt@apple.com>
3473
3474         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
3475         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
3476         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
3477
3478         * platform/ScrollBar.cpp:
3479         (WebCore::ScrollBar::setValue):
3480         (WebCore::ScrollBar::setProportion):
3481         * platform/ScrollBar.h:
3482         (WebCore::ScrollBar::value):
3483         * platform/mac/PlatformScrollBar.h:
3484         * platform/mac/PlatformScrollBarMac.mm:
3485         (WebCore::PlatformScrollBar::updateThumbPosition):
3486         (WebCore::PlatformScrollBar::updateThumbProportion):
3487         * platform/win/PlatformScrollBar.h:
3488         * platform/win/TemporaryLinkStubs.cpp:
3489         (PlatformScrollBar::updateThumbPosition):
3490         (PlatformScrollBar::updateThumbProportion):
3491         * rendering/RenderLayer.cpp:
3492         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
3493
3494 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
3495
3496         Reviewed by Eric.
3497
3498         http://bugs.webkit.org/show_bug.cgi?id=4872
3499         XMLHttpRequest fails to throw an exception when there is a security violation
3500         (mismatching domains)
3501
3502         Raise an exception if there is a security violation, and also in cases required by
3503         the current draft of XHR specification.
3504
3505         * bindings/js/JSXMLHttpRequest.cpp:
3506         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
3507         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
3508         reports one, and also if there were too few arguments passed.
3509
3510         * bindings/js/kjs_binding.cpp:
3511         (KJS::setDOMException): Added support for custom XHR exceptions.
3512
3513         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
3514         exception code range for XHR exceptions.
3515
3516         * xml/xmlhttprequest.cpp:
3517         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
3518         (WebCore::XMLHttpRequest::send):
3519         (WebCore::XMLHttpRequest::setRequestHeader):
3520         (WebCore::XMLHttpRequest::getStatus):
3521         (WebCore::XMLHttpRequest::getStatusText):
3522         (WebCore::XMLHttpRequest::processSyncLoadResults):
3523         (WebCore::XMLHttpRequest::receivedAllData):
3524         (WebCore::XMLHttpRequest::receivedData):
3525
3526 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
3527
3528         Reviewed by Jeff Jenkins.
3529
3530         Tweak CF types.
3531
3532         * platform/cf/ResourceLoaderCFNet.cpp:
3533         (WebCore::willCacheResponse):
3534
3535 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
3536
3537         Reviewed by darin
3538
3539         <http://bugs.webkit.org/show_bug.cgi?id=8029>
3540         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
3541
3542         * dom/Document.cpp:
3543         (WebCore::Document::clearSelectionIfNeeded):
3544         * dom/Element.cpp:
3545         (WebCore::Element::contains):
3546         * dom/Node.cpp:
3547         (WebCore::Node::traverseNextNode):
3548         (WebCore::Node::traverseNextSibling):
3549         (WebCore::Node::traversePreviousNodePostOrder):
3550         (WebCore::Node::checkAddChild):
3551         (WebCore::Node::isDescendantOf):
3552         * dom/Node.h:
3553         * dom/NodeIterator.cpp:
3554         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
3555         * editing/ApplyStyleCommand.cpp:
3556         (WebCore::ApplyStyleCommand::applyBlockStyle):
3557         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
3558         (WebCore::ApplyStyleCommand::applyInlineStyle):
3559         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
3560         * editing/CompositeEditCommand.cpp:
3561         (WebCore::CompositeEditCommand::mergeIdenticalElements):
3562         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
3563         * editing/DeleteSelectionCommand.cpp:
3564         (WebCore::updatePositionForNodeRemoval):
3565         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
3566         (WebCore::DeleteSelectionCommand::mergeParagraphs):
3567         * editing/FormatBlockCommand.cpp:
3568         (WebCore::FormatBlockCommand::doApply):
3569         * editing/IndentOutdentCommand.cpp:
3570         (WebCore::enclosingListOrBlockquote):
3571         * editing/Selection.cpp:
3572         (WebCore::Selection::validate):
3573         * editing/SelectionController.cpp:
3574         (WebCore::SelectionController::nodeWillBeRemoved):
3575         * editing/TextIterator.cpp:
3576         (WebCore::SimplifiedBackwardsTextIterator::advance):
3577         * editing/VisiblePosition.cpp:
3578         (WebCore::VisiblePosition::next):
3579         (WebCore::VisiblePosition::previous):
3580         (WebCore::VisiblePosition::canonicalPosition):
3581         (WebCore::isFirstVisiblePositionInNode):
3582         (WebCore::isLastVisiblePositionInNode):
3583         * editing/htmlediting.cpp:
3584         (WebCore::firstEditablePositionAfterPositionInRoot):
3585         (WebCore::lastEditablePositionBeforePositionInRoot):
3586         (WebCore::enclosingNodeWithTag):
3587         (WebCore::enclosingList):
3588         (WebCore::enclosingListChild):
3589         * editing/markup.cpp:
3590         (WebCore::createMarkup):
3591
3592 2006-09-22  Timothy Hatcher  <timothy@apple.com>
3593
3594         Reviewed by Darin.
3595
3596         - Added @property syntax to non-generated headers
3597           inside #ifndef BUILDING_ON_TIGER.
3598         - Changed the DOMEventTarget protocol to have have new versions
3599           of addEventListener and removeEventListener with named parameters.
3600           These old style methods can be removed once Mail changes to use
3601           the new methods <rdar://problem/4746649>.
3602
3603         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
3604         * bindings/objc/DOM.mm:
3605         (-[DOMNode addEventListener:listener:useCapture:]):
3606         (-[DOMNode addEventListener:::]): call the new method
3607         (-[DOMNode removeEventListener:listener:useCapture:]):
3608         (-[DOMNode removeEventListener:::]): call the new method
3609         * bindings/objc/DOMAbstractView.h:
3610         * bindings/objc/DOMEventTarget.h:
3611         * bindings/objc/DOMHTMLAppletElement.h:
3612         * bindings/objc/DOMHTMLEmbedElement.h:
3613         * bindings/objc/DOMHTMLOptionElement.h:
3614         * bindings/objc/DOMObject.h:
3615         * bindings/objc/DOMRGBColor.h:
3616