5503e1b5c93c711d8501ca8f9e9c38be41df4385
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
2
3         Reviewed by Darin Adler.
4
5         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
6         https://bugs.webkit.org/show_bug.cgi?id=31213
7         Added tree navigation methods that permit full implementation of CSS2.1
8         counter feature without using recursion proportional to the counter
9         tree depth.
10         No new tests because I did not find any bug that is fixed by this
11         commit yet, this just reduces the size of the patch for 11031 and
12         helps respond to some concerns regarding that patch.
13
14         * rendering/CounterNode.cpp:
15         (WebCore::CounterNode::CounterNode):
16
17         (WebCore::CounterNode::nextInPreOrderAfterChildren):
18         (WebCore::CounterNode::nextInPreOrder):
19         Added to support non-recursive tree traversal necessary for
20         efficient full implementation of CSS2.1 counters.
21
22         (WebCore::CounterNode::lastDescendant):
23         (WebCore::CounterNode::previousInPreOrder):
24         Moved this methods such that they occupy a place similar to that of
25         identically named methods on the render tree. This allows for their
26         broader use needed in full implementation of CSS2.1 counters.
27
28         (WebCore::CounterNode::resetRenderer):
29         (WebCore::CounterNode::resetRenderers):
30         (WebCore::CounterNode::recount):
31         (WebCore::CounterNode::insertAfter):
32         (WebCore::CounterNode::removeChild):
33         Changed such that insertion/removal of a counter, triggers not only
34         recalculation of PrefixWidths, but also reassesment of values in
35         counter nodes. This is the basis full implementation of CSS2.1
36         counters. It does not change current behavior by much because of
37         changes needed to the recalculation algorithm, but those are comming
38         in the patch for 11031.
39         (WebCore::showTreeAndMark):
40         * rendering/CounterNode.h:
41         * rendering/RenderCounter.cpp:
42         (WebCore::counter):
43         Only changed argument type to prepare for implementation of Darin
44         Adler's recommendation for the patch to 11031.
45
46         (WebCore::RenderCounter::invalidate):
47         (WebCore::destroyCounterNodeChildren):
48         (WebCore::RenderCounter::destroyCounterNodes):
49         * rendering/RenderCounter.h:
50         * rendering/RenderObjectChildList.cpp:
51         (WebCore::invalidateCountersInContainer):
52         (WebCore::RenderObjectChildList::invalidateCounters):
53         * rendering/RenderObjectChildList.h:
54         Added the ability to restrict invalidation to counters with a given
55         identifier.
56         Also invalidated counters that are on the child container itself
57         which were missed by the previous algorithm, but were a valid case.
58
59 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
60
61         Reviewed by Dimitri Glazkov.
62
63         [V8] Protect SVG animated properties from destruction in bindings.
64         https://bugs.webkit.org/show_bug.cgi?id=31474
65
66         See http://crbug.com/26719.
67
68         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
69         under Valgrind.
70
71         Made sure we keep a reference to SVG properties while setting a
72         context:
73         * bindings/scripts/CodeGeneratorV8.pm:
74         * bindings/v8/V8Proxy.h:
75         (WebCore::V8Proxy::withSVGContext):
76
77 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
78
79         Reviewed by Alexey Proskuryakov.
80
81         [CAIRO] shadow support for Canvas and SVG.
82         [https://bugs.webkit.org/show_bug.cgi?id=30960]
83
84         Incorporate Benjamin Otte's recommendations to avoid
85         a buffer overrun, and small performance improvement.
86
87         * platform/graphics/cairo/GraphicsContextCairo.cpp:
88         (WebCore::copyContextProperties): Correctly size output
89          storage for cairo_get_dash to avoid buffer overrun.
90         (WebCore::drawPathShadow): Prefer cairo_fill_extents
91          to slower cairo_stroke_extents when not drawing shadows.
92
93 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
94
95         Reviewed by Dimitri Glazkov.
96
97         Do not register Chromium's HTML5 DB VFS as the default
98         VFS. Otherwise, other sqlite DB users in the same process will
99         stop working.
100
101         https://bugs.webkit.org/show_bug.cgi?id=31462
102
103         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
104         (WebCore::SQLiteFileSystem::openDatabase):
105         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
106         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
107         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
108         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
109
110 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
111
112         Windows build fix
113
114         * platform/network/cf/SocketStreamHandleCFNet.cpp:
115         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
116         avoiding a sign mismatch warning.
117
118 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
119
120         Release build fix.
121
122         * platform/network/cf/SocketStreamHandleCFNet.cpp:
123         (WebCore::SocketStreamHandle::readStreamCallback):
124         (WebCore::SocketStreamHandle::writeStreamCallback):
125         Use ASSERT_UNUSED for unused stream parameter.
126
127 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
128
129         Reviewed by Darin Adler.
130
131         https://bugs.webkit.org/show_bug.cgi?id=31441
132         Implement SocketStreamHandleCFNet
133
134         Existing WebSocket tests now pass on Mac. No proxy support yet.
135
136         * platform/network/SocketStreamHandleClient.h:
137         * platform/network/cf/SocketStreamHandle.h:
138         (WebCore::SocketStreamHandle::shouldUseSSL):
139         (WebCore::SocketStreamHandle::refAuthenticationClient):
140         (WebCore::SocketStreamHandle::derefAuthenticationClient):
141         (WebCore::SocketStreamHandle::):
142         * platform/network/cf/SocketStreamHandleCFNet.cpp:
143         (WebCore::SocketStreamHandle::SocketStreamHandle):
144         (WebCore::SocketStreamHandle::chooseProxy):
145         (WebCore::SocketStreamHandle::createStreams):
146         (WebCore::SocketStreamHandle::copyCFStreamDescription):
147         (WebCore::SocketStreamHandle::readStreamCallback):
148         (WebCore::SocketStreamHandle::writeStreamCallback):
149         (WebCore::SocketStreamHandle::~SocketStreamHandle):
150         (WebCore::SocketStreamHandle::platformSend):
151         (WebCore::SocketStreamHandle::platformClose):
152         (WebCore::SocketStreamHandle::receivedCredential):
153         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
154         (WebCore::SocketStreamHandle::receivedCancellation):
155
156 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
157
158         Reviewed by Timothy Hatcher.
159
160         Web Inspector: preload status bar button glyphs
161         in order to prevent them from flickering (take 2).
162
163         https://bugs.webkit.org/show_bug.cgi?id=31439
164
165         * inspector/front-end/inspector.js:
166         (preloadImages):
167
168 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
169
170         Reviewed by Adam Barth.
171
172         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
173         Rolling back r50890.
174
175         https://bugs.webkit.org/show_bug.cgi?id=31467
176
177         * bindings/v8/V8Proxy.cpp:
178         (WebCore::V8Proxy::canAccessPrivate):
179
180 2009-11-13  Dirk Schulze  <krit@webkit.org>
181
182         Reviewed by Gustavo Noronha.
183
184         [CAIRO] shadow support for Canvas and SVG
185         [https://bugs.webkit.org/show_bug.cgi?id=30960]
186         
187         This is the fix of a regression, caused by the shadow patch
188         from the bug above. Reinserted the save and restore calls
189         that were accidently removed by the previous patch.
190
191         * platform/graphics/cairo/GraphicsContextCairo.cpp:
192         (WebCore::setPlatformFill):
193         (WebCore::setPlatformStroke):
194
195 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
196
197         Not reviewed. Reverting r50908 since it makes inspector tests
198         time out.
199
200         https://bugs.webkit.org/show_bug.cgi?id=31439
201
202         * inspector/front-end/inspector.js:
203
204 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
205
206         Reviewed by Timothy Hatcher.
207
208         Enable 'console.profile()' and 'console.profileEnd()'
209         regardless of JAVASCRIPT_DEBUGGER.
210
211         https://bugs.webkit.org/show_bug.cgi?id=31293
212
213         * WebCore.gypi:
214         * bindings/js/JSConsoleCustom.cpp:
215         (WebCore::JSConsole::profile):
216         (WebCore::JSConsole::profileEnd):
217         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
218         (WebCore::CALLBACK_FUNC_DECL):
219         * bindings/v8/custom/V8CustomBinding.h:
220         * page/Console.idl:
221
222 2009-11-12  David Levin  <levin@chromium.org>
223
224         Reviewed by NOBODY.
225
226         Chromium build fix.
227
228         * bindings/v8/ScriptController.h:
229         (WebCore::ScriptController::evaluateInWorld): Add a dummy
230          method which isn't called in chromium to make things compile.
231
232 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
233
234         Reviewed by Adam Barth.
235         
236         The document-open.html test was flaky at times. The test invokes the layout test plugin
237         which in its destroy stream handler opens a new document. This basically tears down the
238         stream and the associated plugin instance, which causes a crash when the plugin stream
239         dereferences an invalid m_client pointer which points to the PluginView instance which
240         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
241         and check for the same.
242        
243         https://bugs.webkit.org/show_bug.cgi?id=31067
244
245         * plugins/PluginStream.cpp:
246         (WebCore::PluginStream::stop):
247         (WebCore::PluginStream::destroyStream):
248
249 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
250
251         Reviewed by Dimitri Glazkov.
252
253         Renaming some parameters passed to DB-related methods to better
254         indicate their purpose.
255
256         https://bugs.webkit.org/show_bug.cgi?id=31449
257
258         * platform/chromium/ChromiumBridge.h:
259
260 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
261
262         Reviewed by Dan Bernstein.
263
264         Transformed reflected elements are clipped inside element with opacity
265         https://bugs.webkit.org/show_bug.cgi?id=30957
266         
267         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
268         each clip rect into painting space before taking the unions. This, however, did not work
269         correctly with combinations of reflections and transforms. Fixed by unioning the
270         clipRect and mapping through transforms along the way.
271         
272         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
273         where the transparency layers are.
274
275         Test: fast/reflections/opacity-reflection-transform.html
276
277         * rendering/RenderLayer.cpp:
278         (WebCore::expandClipRectForDescendantsAndReflection):
279         (WebCore::transparencyClipBox):
280         (WebCore::RenderLayer::beginTransparencyLayers):
281
282 2009-11-12  Adam Barth  <abarth@webkit.org>
283
284         Reviewed by Darin Fisher.
285
286         Improve SecurityOrigin::toString comment
287         https://bugs.webkit.org/show_bug.cgi?id=31041
288
289         * page/SecurityOrigin.h:
290
291 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
292
293         Reviewed by Darin Adler.
294
295         externalRepresentation should take Frame as the argument
296         https://bugs.webkit.org/show_bug.cgi?id=31393
297
298         No new tests as this is just a refactoring.
299
300         * WebCore.base.exp:
301         * rendering/RenderTreeAsText.cpp:
302         (WebCore::externalRepresentation):
303         * rendering/RenderTreeAsText.h:
304
305 2009-11-12  Ben Murdoch  <benm@google.com>
306
307         Reviewed by Dimitri Glazkov.
308
309         [Android] The Android specific files in page/Android are out of date.
310         https://bugs.webkit.org/show_bug.cgi?id=31437
311
312         No tests required.
313
314         * page/android/DragControllerAndroid.cpp:
315         (WebCore::DragController::dragOperation): Added.
316         (WebCore::DragController::cleanupAfterSystemDrag):
317         * page/android/EventHandlerAndroid.cpp:
318         (WebCore::EventHandler::accessKeyModifiers): Added.
319         * page/android/InspectorControllerAndroid.cpp: Removed.
320
321 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
322
323         Reviewed by Simon Fraser.
324
325         [CAIRO] shadow support for Canvas and SVG.
326         [https://bugs.webkit.org/show_bug.cgi?id=30960]
327
328         Implement Canvas/SVG shadow support for Cairo.  This patch
329         uses the filter code from SVG Filters.  That means that it is
330         necessary to activate filters to see the shadows.
331
332         Test: fast/canvas/canvas-shadow.html
333
334         * GNUmakefile.am:
335         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
336         * platform/graphics/GraphicsContext.h:
337         * platform/graphics/cairo/GraphicsContextCairo.cpp:
338         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
339         (WebCore::setPlatformFill):
340         (WebCore::setPlatformStroke):
341         (WebCore::copyContextProperties):
342         (WebCore::drawPathShadow):
343         (WebCore::GraphicsContext::fillPath):
344         (WebCore::GraphicsContext::strokePath):
345         (WebCore::GraphicsContext::drawPath):
346         (WebCore::GraphicsContext::setPlatformShadow):
347         (WebCore::GraphicsContext::createPlatformShadow):
348         * platform/graphics/cairo/ImageCairo.cpp:
349         (WebCore::BitmapImage::draw): Add filter effect.
350         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
351         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
352         * platform/graphics/filters/ImageBufferFilter.h: Added.
353         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
354         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
355
356 2009-11-12  Dmitry Titov  <dimich@chromium.org>
357
358         Reviewed by Alexey Proskuryakov.
359
360         Add postTaskToMainThread to ScriptExecutionContext.
361         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
362         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
363         contexts that live on the main thread.
364         https://bugs.webkit.org/show_bug.cgi?id=31427
365
366         No new tests - simply moving the code.
367
368         * dom/Document.cpp:
369         (WebCore::Document::postTask):
370         * dom/ScriptExecutionContext.cpp:
371         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
372         (WebCore::ScriptExecutionContextTaskTimer::fired):
373         (WebCore::PerformTaskData::PerformTaskData):
374         (WebCore::PerformTaskData::performTask):
375         (WebCore::ScriptExecutionContext::postTaskToMainThread):
376         * dom/ScriptExecutionContext.h:
377
378 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
379
380         Reviewed by Darin Adler.
381
382         Fix crash when removing compositing layers when GC is enabled
383         https://bugs.webkit.org/show_bug.cgi?id=31429
384
385         Workaround <rdar://problem/7390716> by special-casing the removal
386         of all sublayers when GC is enabled.
387
388         * platform/graphics/mac/GraphicsLayerCA.mm:
389         (WebCore::safeSetSublayers):
390         (WebCore::GraphicsLayerCA::updateSublayerList):
391         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
392
393 2009-11-12  Jens Alfke  <snej@chromium.org>
394
395         Reviewed by Dimitri Glazkov.
396
397         The last of the V8 binding optimizations.
398         - Replace string-valued element accessors with a shared getter/setter function.
399         - Change error handling flow of control to avoid extra branches and function calls.
400         https://bugs.webkit.org/show_bug.cgi?id=31443
401         
402         * bindings/scripts/CodeGeneratorV8.pm:
403         * bindings/v8/V8Binding.cpp:
404         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
405         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
406         * bindings/v8/V8Binding.h:
407
408 2009-11-12  Sam Weinig  <sam@webkit.org>
409
410         Reviewed by Oliver Hunt.
411
412         Fix for <rdar://problem/7267951>
413         Canvas methods should reject uses of NaN and Infinity.
414
415         Test: fast/canvas/canvas-with-illegal-args.html
416
417         * html/canvas/CanvasRenderingContext2D.cpp:
418         (WebCore::CanvasRenderingContext2D::scale):
419         (WebCore::CanvasRenderingContext2D::rotate):
420         (WebCore::CanvasRenderingContext2D::translate):
421         (WebCore::CanvasRenderingContext2D::transform):
422         (WebCore::CanvasRenderingContext2D::setTransform):
423
424 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
425
426         Reviewed by Timothy Hatcher.
427
428         Web Inspector: profile timeline panel, fix obvious problems.
429
430         https://bugs.webkit.org/show_bug.cgi?id=31432
431
432         * inspector/front-end/AbstractTimelinePanel.js:
433         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
434         * inspector/front-end/TimelinePanel.js:
435         (WebInspector.TimelinePanel.prototype._setWindowPosition):
436         (WebInspector.TimelineCalculator):
437         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
438         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
439         (WebInspector.TimelineCalculator.prototype.reset):
440         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
441         (WebInspector.TimelineCalculator.prototype.formatValue):
442         (WebInspector.TimelineGraph):
443         (WebInspector.TimelineGraph.prototype.refresh):
444         * inspector/front-end/utilities.js:
445         (Element.prototype.hasStyleClass):
446
447 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
448
449         Reviewed by Timothy Hatcher.
450
451         Web Inspector: preload status bar button glyphs
452         in order to prevent them from flickering.
453
454         https://bugs.webkit.org/show_bug.cgi?id=31439
455
456         * inspector/front-end/inspector.js:
457         (preloadImages):
458
459 2009-11-12  Adam Roben  <aroben@apple.com>
460
461         Replace worldIDs with world objects
462
463         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
464         user scripts/stylesheets and isolated worlds
465
466         Reviewed by Sam Weinig.
467
468         Covered by existing tests.
469
470         * WebCore.base.exp: Update exported symbols to match what now exists
471         and is needed by WebKit.
472
473         * bindings/js/ScheduledAction.cpp:
474         (WebCore::ScheduledAction::execute): Updated for function rename.
475
476         * bindings/js/ScriptController.cpp: Removed code that dealt with
477         worldIDs.
478         (WebCore::ScriptController::createWorld): Added. Returns a new world
479         suitable for use on the main thread.
480         (WebCore::ScriptController::executeScriptInWorld): Renamed from
481         executeScriptInIsolatedWorld, since this works just fine with a
482         "normal" world.
483
484         * bindings/js/ScriptController.h: Added createWorld, removed functions
485         that took worldIDs, renamed executeScriptInIsolatedWorld to
486         executeScriptInWorld.
487
488         * page/Frame.cpp:
489         (WebCore::Frame::injectUserScripts):
490         (WebCore::Frame::injectUserScriptsForWorld):
491         Updated for changes to UserScriptMap and ScriptController.
492
493         * page/Frame.h: Changed injectUserScriptsForWorld to take a
494         DOMWrapperWorld* instead of a worldID.
495
496         * page/PageGroup.cpp:
497         (WebCore::PageGroup::addUserScriptToWorld):
498         (WebCore::PageGroup::addUserStyleSheetToWorld):
499         (WebCore::PageGroup::removeUserScriptFromWorld):
500         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
501         (WebCore::PageGroup::removeUserScriptsFromWorld):
502         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
503         * page/PageGroup.h:
504         Changed these functions to take a DOMWrapperWorld* instead of a
505         worldID. Also updated for changes to UserScript and UserStyleSheet.
506
507         * page/UserScript.h:
508         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
509         never used.
510
511         * page/UserScriptTypes.h:
512         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
513         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
514         worldID as their key type.
515
516
517 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
518
519         Reviewed by Tim Hatcher.
520
521         Fixes <http://webkit.org/b/31260>.
522         Web Inspector: Main Resources Other than HTML are mis-detected.
523         
524         Even if the resource is a main resource, look at its CachedResource type, 
525         because it might be an image, stylesheet, or JavaScript file, and we
526         want to show them all correctly.
527
528         * inspector/InspectorResource.cpp:
529         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
530         (WebCore::InspectorResource::type): 
531         * inspector/InspectorResource.h:
532
533 2009-11-12  Jens Alfke  <snej@chromium.org>
534
535         Reviewed by Dimitri Glazkov.
536
537         Table-driven setup for V8 binding template callback functions. 100k in code savings.
538         https://bugs.webkit.org/show_bug.cgi?id=31420
539
540         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
541             to call configureTemplate().
542         * bindings/v8/V8Binding.cpp:
543         (WebCore::configureTemplate):  New function; does all the standard configuration work.
544         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
545         * bindings/v8/V8Binding.h:
546         * bindings/v8/V8Proxy.cpp:
547         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
548         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
549         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
550         * bindings/v8/V8Proxy.h:
551
552 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
553
554         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
555
556         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
557
558 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
559
560         Reviewed by Dan Bernstein.
561
562         <rdar://problem/7388969> Add DOM API for fullscreen video
563         
564         DOM API for fullscreen <video>.
565
566         Tests: media/media-fullscreen-inline.html
567                media/media-fullscreen-not-in-document.html
568
569         * dom/EventNames.h:
570             Add webkitbeginfullscreen and webkitendfullscreen.
571
572         * html/HTMLAttributeNames.in:
573             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
574
575         * html/HTMLMediaElement.cpp:
576         (WebCore::HTMLMediaElement::parseMappedAttribute):
577             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
578         (WebCore::HTMLMediaElement::enterFullscreen):
579             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
580             actually do enter fullscreen.
581         (WebCore::HTMLMediaElement::exitFullscreen):
582             Schedule webkitendfullscreenEvent event.
583         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
584         (WebCore::HTMLMediaElement::webkitExitFullScreen):
585         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
586         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
587             New, access to fullscreen properties and methods.
588
589         * html/HTMLMediaElement.h:
590         * html/HTMLMediaElement.idl:
591             Declare methods needed for fullscreen API.
592
593         * html/HTMLVideoElement.cpp:
594         (WebCore::HTMLVideoElement::supportsFullscreen):
595             Return false if a movie does not have video.
596
597         * page/DOMWindow.h:
598             Add webkitbeginfullscreen and webkitendfullscreen.
599
600 2009-11-12  Adam Barth  <abarth@webkit.org>
601
602         Reviewed by Dimitri Glazkov.
603
604         [Chromium] Sify compose button alerts error
605         https://bugs.webkit.org/show_bug.cgi?id=31394
606
607         Test: http/tests/security/calling-versus-current.html
608
609         We're supposed to use the calling context for security checks.  In JSC
610         land, this is the lexicalGlobalObject.
611
612         * bindings/v8/V8Proxy.cpp:
613         (WebCore::V8Proxy::canAccessPrivate):
614
615 2009-11-12  Daniel Bates  <dbates@webkit.org>
616
617         Reviewed by Darin Adler.
618
619         https://bugs.webkit.org/show_bug.cgi?id=30291
620
621         Fixes an issue where the returned drop effect is incorrect when
622         effectAllowed == "uninitialized".
623
624         According to section 7.9.2 of the HTML 5 spec.
625         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
626         when effectAllowed = "uninitialized" the resulting dropEffect should be the
627         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
628         other case.
629         
630         No test cases are included because we have an existing test case from
631         bug #24731.
632
633         * dom/Clipboard.cpp:
634         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
635
636 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
637
638         Reviewed by Timothy Hatcher.
639
640         Web Inspector: Do not highlight node on refresh.
641
642         https://bugs.webkit.org/show_bug.cgi?id=31419
643
644         * inspector/front-end/ElementsPanel.js:
645         (WebInspector.ElementsPanel.prototype.reset):
646
647 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
648
649         Reviewed by Timothy Hatcher.
650
651         Web Inspector: Minor timeline fixes.
652
653         https://bugs.webkit.org/show_bug.cgi?id=31417
654
655         * inspector/front-end/TimelinePanel.js:
656         (WebInspector.TimelinePanel.prototype._getRecordDetails):
657         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
658         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
659         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
660
661 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
662
663         SnowLeopard build fix.
664
665         Renamed initWithClient to initWithAuthenticationClient.
666
667         * platform/network/mac/AuthenticationMac.mm:
668         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
669         (WebCore::AuthenticationChallenge::setAuthenticationClient):
670
671 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
672
673         Reviewed by Darin Adler.
674
675         ARIA: add alert type roles
676         https://bugs.webkit.org/show_bug.cgi?id=31392
677
678         Test: platform/mac/accessibility/aria-alerts.html
679
680         * accessibility/AccessibilityObject.h:
681         * accessibility/AccessibilityRenderObject.cpp:
682         * accessibility/mac/AccessibilityObjectWrapper.mm:
683
684 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
685
686         Reviewed by Darin Adler.
687
688         https://bugs.webkit.org/show_bug.cgi?id=31386
689         Make Mac AuthenticationChallenge usable from cross-platform code
690
691         No change in behavior, so no tests.
692
693         * platform/network/ResourceHandle.cpp:
694         (WebCore::ResourceHandle::clearAuthentication):
695         * platform/network/ResourceHandleInternal.h:
696         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
697         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
698         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
699         is identical.
700
701         * platform/network/cf/AuthenticationChallenge.h:
702         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
703         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
704
705         * platform/network/cf/ResourceHandleCFNet.cpp:
706         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
707         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
708         be already set.
709
710         * platform/network/mac/AuthenticationChallenge.h:
711         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
712         best of my understanding.
713         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
714         confusion with "mac" and "web" challenges in ResourceHandleInternal.
715
716         * platform/network/mac/AuthenticationMac.mm:
717         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
718         making it possible to use the latter with NSURLAuthenticationChallenge.
719         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
720         m_nsChallenge renaming.
721         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
722         set it as sender (or unset, if client is null).
723
724         * platform/network/mac/ResourceHandleMac.mm:
725         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
726         authentication challenge sender.
727         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
728         authentication sheet.
729         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
730         using the new setAuthenticationClient() method.
731         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
732         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
733         the original Mac one, not the one we created for use with authentication sheet. I don't
734         know when a connection would cancel authentication in practice, so I haven't tested this.
735
736 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
737
738         Reviewed by Timothy Hatcher.
739
740         Web Inspector: breakpoint sidebar entries should allow click over entire list item
741         https://bugs.webkit.org/show_bug.cgi?id=31411
742
743         No new tests; no new functionality, small usability change. 
744
745         * inspector/front-end/BreakpointsSidebarPane.js:
746         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
747         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
748
749 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
750
751         Reviewed by Timothy Hatcher.
752
753         Web Inspector: breakpoints in named evals are not restored after a reload
754         https://bugs.webkit.org/show_bug.cgi?id=31375
755
756         Manual test added
757
758         * inspector/front-end/ScriptsPanel.js:
759         (WebInspector.ScriptsPanel.prototype.addScript):
760         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
761
762 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
763
764         Reviewed by Kenneth Rohde Christiansen.
765
766         Custom printing shrink factors
767         https://bugs.webkit.org/show_bug.cgi?id=29042
768
769         This reverts commit r49769. The public API for this needs to be reviewed
770         before its inclusion in Qt.
771
772         * page/PrintContext.cpp:
773         (WebCore::PrintContext::begin):
774         * page/Settings.cpp:
775         (WebCore::Settings::Settings):
776         * page/Settings.h:
777
778 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
779
780         Reviewed by Pavel Feldman.
781
782         Web Inspector: Resource errors/warnings not shown in the Resource tree.
783
784         Error/Warning bubbles are not displayed next to the resource in the 
785         Resources panel if those occur before the resource is attached to the tree.
786         https://bugs.webkit.org/show_bug.cgi?id=31404
787
788         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
789
790         * inspector/front-end/AbstractTimelinePanel.js:
791         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
792         * inspector/front-end/ResourcesPanel.js:
793         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
794
795 2009-11-12  Philippe Normand  <pnormand@igalia.com>
796
797         Reviewed by Jan Alonzo.
798
799         https://bugs.webkit.org/show_bug.cgi?id=31047
800         [GTK] Failing test media/video-played-ranges-1.html
801
802         Follow-up of r50726, don't block the UI thread when calling
803         gst_element_get_state(). Also fixed a compilation warning and some
804         static casts.
805
806         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
807         (WebCore::playbackPosition):
808         (WebCore::MediaPlayerPrivate::seek):
809         (WebCore::MediaPlayerPrivate::setRate):
810
811 2009-11-12  Philippe Normand  <pnormand@igalia.com>
812
813         Reviewed by Jan Alonzo.
814
815         https://bugs.webkit.org/show_bug.cgi?id=31047
816         [GTK] Failing test media/video-played-ranges-1.html
817
818         don't pause pipeline if already paused, same for play()
819
820         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
821         (WebCore::MediaPlayerPrivate::play):
822         (WebCore::MediaPlayerPrivate::pause):
823
824 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
825
826         Reviewed by David Levin.
827
828         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
829         Chromium too.
830         https://bugs.webkit.org/show_bug.cgi?id=31292
831
832         No new tests. (Corresponding test for Gtk+ is
833         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
834
835         * page/EventHandler.cpp:
836         * page/chromium/EventHandlerChromium.cpp:
837
838 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
839
840         Reviewed by Eric Seidel.
841
842         Prevent text inside a multi-column block from being split into columns.
843         
844         If the tentative height of a multi-column block was too small, we need to
845         expand the block height and try to layout again, in order to prevent text
846         from being split into different columns.
847
848         CSS Multicolumn text is split awkwardly
849         https://bugs.webkit.org/show_bug.cgi?id=22249
850
851         Test: fast/multicol/single-line.html
852
853         * rendering/RenderBlock.cpp:
854         (WebCore::RenderBlock::layoutColumns):
855         * rendering/RenderBlock.h:
856         * rendering/RenderLineBoxList.cpp:
857         (WebCore::RenderLineBoxList::paint):
858         * rendering/RenderView.h:
859         (WebCore::RenderView::setTruncatedAt):
860         (WebCore::RenderView::setMinimumColumnHeight):
861         (WebCore::RenderView::minimumColumnHeight):
862
863 2009-11-11  Kent Tamura  <tkent@chromium.org>
864
865         Reviewed by Darin Adler.
866
867         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
868         https://bugs.webkit.org/show_bug.cgi?id=31195
869
870         Test: fast/forms/input-file-re-render.html
871
872         * rendering/RenderFileUploadControl.cpp:
873         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
874
875 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
876
877         Reviewed by Dimitri Glazkov.
878
879         Fixing Chromium's POSIX VFS implementation, by adding the required
880         "used file descriptors" logic.
881
882         https://bugs.webkit.org/show_bug.cgi?id=31275
883
884         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
885
886 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
887
888         Reviewed by Oliver Hunt.
889
890         need to implement aria tree roles
891         https://bugs.webkit.org/show_bug.cgi?id=31284
892
893         Tests: platform/mac/accessibility/aria-multiselectable.html
894                platform/mac/accessibility/aria-tree.html
895
896         * accessibility/AccessibilityList.cpp:
897         (WebCore::AccessibilityList::accessibilityIsIgnored):
898         * accessibility/AccessibilityObject.cpp:
899         (WebCore::AccessibilityObject::ariaTreeRows):
900         (WebCore::AccessibilityObject::ariaTreeItemContent):
901         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
902         * accessibility/AccessibilityObject.h:
903         (WebCore::):
904         (WebCore::AccessibilityObject::isTree):
905         (WebCore::AccessibilityObject::isTreeItem):
906         (WebCore::AccessibilityObject::setIsExpanded):
907         (WebCore::AccessibilityObject::canSetExpandedAttribute):
908         (WebCore::AccessibilityObject::hierarchicalLevel):
909         (WebCore::AccessibilityObject::setSelectedRows):
910         (WebCore::AccessibilityObject::performDefaultAction):
911         * accessibility/AccessibilityRenderObject.cpp:
912         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
913         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
914         (WebCore::AccessibilityRenderObject::isExpanded):
915         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
916         (WebCore::AccessibilityRenderObject::elementAttributeValue):
917         (WebCore::AccessibilityRenderObject::setIsExpanded):
918         (WebCore::AccessibilityRenderObject::isSelected):
919         (WebCore::AccessibilityRenderObject::setSelected):
920         (WebCore::AccessibilityRenderObject::setSelectedRows):
921         (WebCore::createARIARoleMap):
922         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
923         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
924         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
925         (WebCore::AccessibilityRenderObject::selectedChildren):
926         * accessibility/AccessibilityRenderObject.h:
927         * accessibility/mac/AccessibilityObjectMac.mm:
928         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
929         * accessibility/mac/AccessibilityObjectWrapper.mm:
930         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
931         (RoleEntry::):
932         (-[AccessibilityObjectWrapper subrole]):
933         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
934         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
935         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
936         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
937         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
938         * html/HTMLAttributeNames.in:
939
940 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
941
942         Build fix after @r50760 with ENABLE_FILTERS.
943
944         * platform/graphics/filters/SourceAlpha.cpp:
945         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
946         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
947           to fillRect.
948
949 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
950
951         Reviewed by Alexey Proskuryakov.
952
953         Fix WebSocket frame parser of frame_type with high-order bit set.
954         https://bugs.webkit.org/show_bug.cgi?id=30668
955
956         If buffer is smaller than frame's length, it should break the loop
957         instead of reading next byte.
958
959         Tests: websocket/tests/frame-length-longer-than-buffer.html
960                websocket/tests/frame-length-skip.html
961
962         * websockets/WebSocketChannel.cpp:
963         (WebCore::WebSocketChannel::didReceiveData):
964
965 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
966
967         Reviewed by Adam Barth.
968
969         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
970         https://bugs.webkit.org/show_bug.cgi?id=31345
971
972         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
973
974         * platform/graphics/chromium/FontCustomPlatformData.cpp:
975         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
976         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
977         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
978
979 2009-11-11  Beth Dakin  <bdakin@apple.com>
980
981         Build fix. No review needed.
982
983         * platform/graphics/gtk/FontGtk.cpp:
984         (WebCore::Font::drawComplexText):
985
986 2009-11-11  Beth Dakin  <bdakin@apple.com>
987
988         Build fix. No review needed.
989
990         * platform/graphics/cairo/FontCairo.cpp:
991         (WebCore::Font::drawGlyphs):
992
993 2009-11-11  Beth Dakin  <bdakin@apple.com>
994
995         Windows build fix. No review needed. 
996
997         * platform/graphics/win/FontCGWin.cpp:
998         (WebCore::Font::drawGlyphs):
999
1000 2009-11-11  Beth Dakin  <bdakin@apple.com>
1001
1002         Reviewed by Simon Fraser.
1003
1004         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
1005         Make -webkit-color-correction work with shadows
1006
1007         From canvas, just send DeviceColorSpace to setShadow() for now. 
1008         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
1009         * html/canvas/CanvasRenderingContext2D.cpp:
1010         (WebCore::CanvasRenderingContext2D::setShadow):
1011         (WebCore::CanvasRenderingContext2D::applyShadow):
1012
1013         setShadow() and setPlatformShadow() now take a ColorSpace.
1014         * platform/graphics/GraphicsContext.cpp:
1015         (WebCore::GraphicsContext::setShadow):
1016         * platform/graphics/GraphicsContext.h:
1017         * platform/graphics/cg/GraphicsContextCG.cpp:
1018         (WebCore::createCGColorWithColorSpace): New helper to create a 
1019         color in a ColorSpace.
1020         (WebCore::setCGFillColor): Call new helper.
1021         (WebCore::setCGStrokeColor): Call new helper.
1022         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
1023         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1024         (WebCore::GraphicsContext::setPlatformShadow):
1025
1026         Send appropriate ColorSpace to setShadow().
1027         * platform/graphics/mac/FontMac.mm:
1028         (WebCore::Font::drawGlyphs):
1029         * rendering/EllipsisBox.cpp:
1030         (WebCore::EllipsisBox::paint):
1031         * rendering/InlineFlowBox.cpp:
1032         (WebCore::InlineFlowBox::paintTextDecorations):
1033         * rendering/InlineTextBox.cpp:
1034         (WebCore::paintTextWithShadows):
1035         (WebCore::InlineTextBox::paintDecoration):
1036         * rendering/RenderBoxModelObject.cpp:
1037         (WebCore::RenderBoxModelObject::paintBoxShadow):
1038         * rendering/SVGInlineTextBox.cpp:
1039         (WebCore::SVGInlineTextBox::paintCharacters):
1040         * rendering/SVGRenderSupport.cpp:
1041         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
1042
1043         Attempt to keep ports building.
1044         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1045         (WebCore::GraphicsContext::setPlatformShadow):
1046         * platform/graphics/qt/GraphicsContextQt.cpp:
1047         (WebCore::GraphicsContext::setPlatformShadow):
1048         * platform/graphics/skia/GraphicsContextSkia.cpp:
1049         (WebCore::GraphicsContext::setPlatformShadow):
1050         * platform/graphics/wince/GraphicsContextWince.cpp:
1051         (WebCore::GraphicsContext::setPlatformShadow):
1052         * platform/graphics/wx/GraphicsContextWx.cpp:
1053         (WebCore::GraphicsContext::setPlatformShadow):
1054
1055 2009-11-11  Kent Tamura  <tkent@chromium.org>
1056
1057         Reviewed by Darin Adler.
1058
1059         Print the file text of a file upload control in DumpRenderTree for ease of tests.
1060         https://bugs.webkit.org/show_bug.cgi?id=31195
1061
1062         * rendering/RenderFileUploadControl.cpp:
1063         (WebCore::RenderFileUploadControl::paintObject):
1064         (WebCore::RenderFileUploadControl::fileTextValue):
1065         * rendering/RenderFileUploadControl.h:
1066         (WebCore::RenderFileUploadControl::isFileUploadControl):
1067         (WebCore::toRenderFileUploadControl):
1068         * rendering/RenderObject.h:
1069         (WebCore::RenderObject::isFileUploadControl):
1070         * rendering/RenderTreeAsText.cpp:
1071         (WebCore::operator<<):
1072
1073 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
1074
1075         Reviewed by Sam Weinig.
1076
1077         DOM Wrappers for some nodes may not be marked.
1078         https://bugs.webkit.org/show_bug.cgi?id=31380
1079
1080         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
1081         the wrapper for the current world only.  This means that wrappers may be GC'ed
1082         prematurely, and properties lost.
1083
1084         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
1085
1086         * bindings/js/JSAttrCustom.cpp:
1087         (WebCore::JSAttr::markChildren):
1088         * bindings/js/JSDOMBinding.cpp:
1089         (WebCore::markDOMNodeWrapper):
1090         * bindings/js/JSDOMBinding.h:
1091         * bindings/js/JSNamedNodeMapCustom.cpp:
1092         (WebCore::JSNamedNodeMap::markChildren):
1093         * bindings/js/JSNodeCustom.cpp:
1094         (WebCore::JSNode::markChildren):
1095         * bindings/js/JSSVGElementInstanceCustom.cpp:
1096         (WebCore::JSSVGElementInstance::markChildren):
1097         * bindings/js/JSStyleSheetCustom.cpp:
1098         (WebCore::JSStyleSheet::markChildren):
1099
1100 2009-11-11  Ben Murdoch  <benm@google.com>
1101
1102         Reviewed by Darin Adler.
1103
1104         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1105         https://bugs.webkit.org/show_bug.cgi?id=31384
1106
1107         No functionality change so no tests required.
1108
1109         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1110
1111 2009-11-11  Jens Alfke  <snej@chromium.org>
1112
1113         Reviewed by Dimitri Glazkov.
1114
1115         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1116         - Various inline functions in V8Binding.h made non-inline.
1117         - Some renaming for consistency.
1118         - New function createRawTemplate().
1119         https://bugs.webkit.org/show_bug.cgi?id=31383
1120
1121         * bindings/scripts/CodeGeneratorV8.pm:
1122         * bindings/v8/V8Binding.cpp:
1123         (WebCore::v8DOMWrapperToNative):
1124         (WebCore::v8ValueToWebCoreString):
1125         (WebCore::v8ValueToAtomicWebCoreString):
1126         (WebCore::toInt32):
1127         (WebCore::toWebCoreString):
1128         (WebCore::toWebCoreStringWithNullCheck):
1129         (WebCore::toAtomicWebCoreStringWithNullCheck):
1130         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1131         (WebCore::isUndefinedOrNull):
1132         (WebCore::v8Boolean):
1133         (WebCore::v8UndetectableString):
1134         (WebCore::v8StringOrNull):
1135         (WebCore::v8StringOrUndefined):
1136         (WebCore::v8StringOrFalse):
1137         (WebCore::v8StringToWebCoreString):
1138         (WebCore::v8ExternalString):
1139         (WebCore::createRawTemplate):  New function.
1140         * bindings/v8/V8Binding.h:
1141         (WebCore::v8DOMWrapperTo):
1142         (WebCore::v8DOMWrapperToNode):
1143         (WebCore::v8StringToWebCoreString):
1144         (WebCore::v8StringToAtomicWebCoreString):
1145
1146 2009-11-11  Jens Alfke  <snej@chromium.org>
1147
1148         Reviewed by Dimitri Glazkov.
1149
1150         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1151         event-listener setter into a new subroutine transferHiddenDependency().
1152         https://bugs.webkit.org/show_bug.cgi?id=31377
1153
1154         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1155         * bindings/v8/V8Utilities.cpp:
1156         (WebCore::transferHiddenDependency):  New.
1157         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1158
1159 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1160
1161         Reviewed by Beth Dakin.
1162
1163         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1164         because there is a CG bug preventing this from working.
1165
1166         * platform/graphics/cg/GraphicsContextCG.cpp:
1167         (WebCore::sRGBColorSpaceRef):
1168
1169 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1170
1171         Reviewed by Timothy Hatcher.
1172
1173         Check that if Storage panel exists before calling its methods
1174
1175         https://bugs.webkit.org/show_bug.cgi?id=31343
1176
1177         * inspector/front-end/inspector.js:
1178         (WebInspector.addDatabase):
1179         (WebInspector.addCookieDomain):
1180         (WebInspector.addDOMStorage):
1181         (WebInspector.updateDOMStorage):
1182
1183 2009-11-11  Jens Alfke  <snej@chromium.org>
1184
1185         Reviewed by Dimitri Glazkov.
1186
1187         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1188         times in the generated V8 bindings.
1189         https://bugs.webkit.org/show_bug.cgi?id=31368
1190
1191         * bindings/v8/V8DOMWrapper.cpp:
1192         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1193         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1194
1195 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1196
1197         Reviewed by Timothy Hatcher.
1198
1199         Display the correct summary in the web inspector for the shorthands
1200         border-color, border-width, border-style, margin, and padding.
1201         https://bugs.webkit.org/show_bug.cgi?id=7987
1202
1203         Test: fast/css/shorthands-four-values.html
1204
1205         * css/CSSMutableStyleDeclaration.cpp:
1206         (WebCore::CSSMutableStyleDeclaration::get4Values):
1207         Display the summary information in the same way the shorthand would be
1208         specified in a css rule.
1209
1210 2009-11-11  Jens Alfke  <snej@chromium.org>
1211
1212         Reviewed by Dimitri Glazkov.
1213
1214         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1215         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1216         https://bugs.webkit.org/show_bug.cgi?id=31367
1217
1218         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1219
1220 2009-11-11  Jens Alfke  <snej@chromium.org>
1221
1222         Reviewed by Dimitri Glazkov.
1223
1224         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1225
1226         * bindings/v8/DOMData.cpp:
1227         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1228             so it can be inlined by its caller.
1229         * bindings/v8/DOMData.h:
1230         * bindings/v8/MainThreadDOMData.cpp:
1231         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1232         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1233         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1234             and getStore, which inline both calls together.
1235         * bindings/v8/MainThreadDOMData.h:
1236         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1237         * bindings/v8/V8DOMMap.cpp:
1238         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1239
1240 2009-11-11  Nate Chapin  <japhet@chromium.org>
1241
1242         Reviewed by Dimitri Glazkov.
1243
1244         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1245
1246         https://bugs.webkit.org/show_bug.cgi?id=31357
1247
1248         * platform/KURLGoogle.cpp:
1249         (WebCore::isSchemeFirstChar):
1250         (WebCore::isSchemeChar):
1251         (WebCore::KURL::hasPort):
1252         (WebCore::KURL::removePort):
1253         (WebCore::protocolIsValid):
1254
1255 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1256
1257         Build fix, no reviewed.
1258
1259         Correct setPlatformFillColor and setPlatformStrokeColor calls
1260         to match new ColorSpace-supporting signatures.
1261
1262         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1263           color space to the set[...]Color calls.
1264
1265 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1266
1267         Reviewed by Sam Weinig.
1268
1269         https://bugs.webkit.org/show_bug.cgi?id=31327
1270         Clean up SocketStreamHandleClient interface
1271
1272         No change in behavior.
1273
1274         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1275         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1276         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1277         should be.
1278         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1279         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1280         For ResourceHandle, this method is called when the user cancels authentication sheet,
1281         not when something happens with the stream.
1282
1283         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1284         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1285
1286         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1287         callbacks have no real implementation yet.
1288
1289 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1290
1291         Reviewed by Eric Seidel.
1292
1293         Allow custom memory allocation control for the part of page directory in WebCore
1294         https://bugs.webkit.org/show_bug.cgi?id=31350
1295
1296         Inherits the following classes from Noncopyable because these are instantiated
1297         by 'new' and these are no need to be copyable:
1298
1299         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1300         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1301         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1302         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1303         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1304         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1305         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1306         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1307         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1308
1309         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1310         PropertyWrapper is instantiated by 'new' in 
1311         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1312
1313         * page/DragController.h:
1314         * page/EventHandler.h:
1315         * page/FocusController.h:
1316         * page/FrameView.cpp:
1317         * page/PluginHalter.h:
1318         * page/Settings.h:
1319         * page/UserScript.h:
1320         * page/UserStyleSheet.h:
1321         * page/XSSAuditor.h:
1322         * page/animation/AnimationBase.cpp:
1323
1324 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1325
1326         Reviewed by Kenneth Rohde Christiansen.
1327
1328         https://bugs.webkit.org/show_bug.cgi?id=31323
1329         Fix a few compiler warnings
1330
1331         No new tests as there is no new functionality.
1332
1333         * editing/htmlediting.cpp:
1334         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1335         parentheses to silence gcc 4.4 -Wparentheses warnings
1336
1337 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1338
1339         Reviewed by Mark Rowe.
1340
1341         Set m_hasPendingGeometryChange to true by default, so that
1342         at least one call to NPP_SetWindow is executed, which is
1343         needed by the DRT plugin testing framework.
1344
1345         * plugins/PluginView.cpp:
1346         (WebCore::PluginView::PluginView):
1347
1348 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1349
1350         Rubber-stamped by Kenneth Rohde Christiansen.
1351
1352         https://bugs.webkit.org/show_bug.cgi?id=31348
1353         [Qt] Remove unnecessary LUT creator from WebCore.pro
1354
1355         * WebCore.pro:
1356
1357 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1358
1359         Reviewed by Tor Arne Vestbø.
1360
1361         Introduce a function for querying the input method status
1362         in QWebPageClient.
1363
1364         * platform/qt/QWebPageClient.h:
1365
1366 2009-11-11  Benjamin Otte  <otte@gnome.org>
1367
1368         Reviewed by Jan Alonzo.
1369
1370         [GTK] Black artifacts in youtube.com/html5
1371
1372         Paint the video to the given size. It's the job of the callers to keep
1373         track of aspect ratio. RenderVideo.cpp does it for the <video>
1374         element.
1375         https://bugs.webkit.org/show_bug.cgi?id=30925
1376
1377         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1378         (WebCore::MediaPlayerPrivate::paint):
1379
1380 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1381
1382         Reviewed by Reviewed by Jan Alonzo.
1383
1384         https://bugs.webkit.org/show_bug.cgi?id=30901
1385         [Gtk] Need to de-lint the Atk a11y code
1386
1387         Cleaned up some missed capitalization style-guideline violations.
1388
1389         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1390
1391 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1392
1393         Reviewed by Eric Seidel.
1394
1395         [Qt] Make the default style background color valid.
1396         Currently the color is transparent but invalid, this causes
1397         list boxes in QtWebKit to be drawn with a black background
1398         since r49242.
1399         https://bugs.webkit.org/show_bug.cgi?id=31295
1400
1401         * rendering/style/RenderStyle.h:
1402         (WebCore::InheritedFlags::initialBackgroundColor):
1403         * rendering/style/StyleBackgroundData.cpp:
1404         (WebCore::StyleBackgroundData::StyleBackgroundData):
1405
1406 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1407
1408         Reviewed by Geoff Garen.
1409
1410         Simplify the ownership model for worlds - rather than having a pair of weak references
1411         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1412         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1413         back forward cache.
1414
1415         * WebCore.base.exp:
1416         * bindings/js/JSDOMBinding.cpp:
1417         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1418         * bindings/js/JSDOMBinding.h:
1419         (WebCore::DOMWrapperWorld::forgetDocument):
1420         * bindings/js/ScriptCachedFrameData.cpp:
1421         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1422         (WebCore::ScriptCachedFrameData::restore):
1423         (WebCore::ScriptCachedFrameData::clear):
1424         * bindings/js/ScriptCachedFrameData.h:
1425         * bindings/js/ScriptController.cpp:
1426         (WebCore::ScriptController::~ScriptController):
1427         (WebCore::ScriptController::clearWindowShell):
1428         (WebCore::ScriptController::initScript):
1429         (WebCore::ScriptController::updateDocument):
1430         * bindings/js/ScriptController.h:
1431
1432 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1433
1434         Reviewed by Darin Adler.
1435
1436         rename counter to makeCounterNode in RenderCounter.cpp
1437         https://bugs.webkit.org/show_bug.cgi?id=31289
1438
1439         No new test because this is just a small refactoring.
1440
1441         * rendering/RenderCounter.cpp:
1442         (WebCore::findPlaceForCounter):
1443         (WebCore::makeCounterNode):
1444         (WebCore::RenderCounter::originalText):
1445
1446 2009-11-10  Daniel Bates  <dbates@webkit.org>
1447
1448         Reviewed by Oliver Hunt.
1449
1450         https://bugs.webkit.org/show_bug.cgi?id=30754
1451
1452         Patch 2 of 2.
1453
1454         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1455         needed. This method fired a drag event whenever the mouse moved, but
1456         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1457         model independent of when the mouse moves. See "Among other changes..."
1458         in the change log for patch 1 for more details.
1459
1460         * WebCore.DragSupport.exp:
1461         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1462         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1463         * page/EventHandler.h:
1464
1465 2009-11-10  Daniel Bates  <dbates@webkit.org>
1466
1467         Reviewed by Oliver Hunt.
1468
1469         https://bugs.webkit.org/show_bug.cgi?id=30754
1470
1471         Patch 1 of 2.
1472
1473         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1474         the drag event should always fire before the dragover event.
1475
1476         In fixing this bug, this patch also makes our drag processing model
1477         conform to the HTML 5 spec.
1478
1479         Among the changes, this patch ensures that the drag event isn't fired outside
1480         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1481         Currently, the drag event is fired whenever the mouse button is down and the OS
1482         detects the mouse moved. But, as per the spec, the drag event should
1483         fire approx. every 350ms so long as the mouse button is down.
1484
1485         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1486
1487         * page/EventHandler.cpp:
1488         (WebCore::EventHandler::clear):
1489         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1490         Modified to determine when we are in the correct instance of EventHandler to service the drag
1491         and drop operation.
1492         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1493         into this method.
1494         (WebCore::EventHandler::cancelDragAndDrop):
1495         (WebCore::EventHandler::performDragAndDrop):
1496         (WebCore::EventHandler::clearDragState):
1497         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1498         we should fire both drag and dragover events or only the dragover event.
1499
1500 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1501
1502         Reviewed by Dimitri Glazkov.
1503
1504         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1505         https://bugs.webkit.org/show_bug.cgi?id=31301
1506
1507         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1508
1509         Allowed passing V8Proxy for the calling JS context:
1510         * bindings/v8/V8DOMWrapper.h:
1511         (WebCore::V8DOMWrapper::getXPathNSResolver):
1512         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1513         (WebCore::V8CustomXPathNSResolver::create):
1514         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1515         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1516         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1517         * bindings/v8/custom/V8DocumentCustom.cpp:
1518         (WebCore::CALLBACK_FUNC_DECL):
1519
1520 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1521
1522         Reviewed by Timothy Hatcher.
1523
1524         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1525         https://bugs.webkit.org/show_bug.cgi?id=29972.
1526
1527         Add methods for setting different parts of the URL in href attribute.
1528
1529         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1530                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1531                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1532                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1533                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1534                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1535                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1536
1537         * bindings/js/JSLocationCustom.cpp:
1538         (WebCore::JSLocation::setPort):
1539         * html/HTMLAnchorElement.cpp:
1540         (WebCore::parsePortFromStringPosition):
1541         (WebCore::HTMLAnchorElement::setHash):
1542         (WebCore::HTMLAnchorElement::setHost):
1543         (WebCore::HTMLAnchorElement::setHostname):
1544         (WebCore::HTMLAnchorElement::setPathname):
1545         (WebCore::HTMLAnchorElement::setPort):
1546         (WebCore::HTMLAnchorElement::setProtocol):
1547         (WebCore::HTMLAnchorElement::setSearch):
1548         * html/HTMLAnchorElement.h:
1549         * html/HTMLAnchorElement.idl:
1550         * loader/FrameLoader.cpp:
1551         (WebCore::FrameLoader::iconURL):
1552         * platform/KURL.cpp:
1553         (WebCore::KURL::removePort):
1554         (WebCore::KURL::setPort):
1555         (WebCore::KURL::prettyURL):
1556         (WebCore::protocolIsValid):
1557         * platform/KURL.h:
1558         (WebCore::KURL::canSetHostOrPort):
1559         (WebCore::KURL::canSetPathname):
1560         (WebCore::KURL::hasPort):
1561         * platform/network/soup/ResourceHandleSoup.cpp:
1562         (WebCore::):
1563
1564 2009-11-10  Nate Chapin  <japhet@chromium.org>
1565
1566         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1567
1568         * platform/chromium/PopupMenuChromium.cpp:
1569         (WebCore::PopupContainer::paintBorder):
1570         (WebCore::PopupListBox::paint):
1571         (WebCore::PopupListBox::paintRow):
1572         * platform/graphics/chromium/TransparencyWin.cpp:
1573         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1574         * platform/graphics/skia/GraphicsContextSkia.cpp:
1575         (WebCore::GraphicsContext::fillRect):
1576         (WebCore::GraphicsContext::fillRoundedRect):
1577         (WebCore::GraphicsContext::setPlatformFillColor):
1578         (WebCore::GraphicsContext::setPlatformStrokeColor):
1579         * rendering/RenderMediaControlsChromium.cpp:
1580         (WebCore::paintMediaSlider):
1581         (WebCore::paintMediaVolumeSlider):
1582         (WebCore::paintMediaTimelineContainer):
1583         * rendering/RenderThemeChromiumMac.mm:
1584         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1585
1586 2009-11-10  Brady Eidson  <beidson@apple.com>
1587
1588         Reviewed by Sam Weinig.
1589
1590         Repro crash saving pcmag.com article as a webarchive.
1591         <rdar://problem/7381219> and https://webkit.org/b/31322
1592
1593         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1594
1595         * css/CSSStyleSheet.cpp:
1596         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1597           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1598
1599 2009-11-10  Beth Dakin  <bdakin@apple.com>
1600
1601         Attempt 2 to fix Tiger build. No review needed.
1602
1603         * platform/graphics/cg/GraphicsContextCG.cpp:
1604         (WebCore::deviceRGBColorSpaceRef):
1605         (WebCore::sRGBColorSpaceRef):
1606
1607 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1608
1609         wx build fix. Changes needed after r50760.
1610
1611         * platform/graphics/wx/GraphicsContextWx.cpp:
1612         (WebCore::GraphicsContext::GraphicsContext):
1613         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1614         (WebCore::drawTextWithSpacing):
1615
1616 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1617
1618         Qt build fix.
1619
1620         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1621         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1622
1623 2009-11-10  Beth Dakin  <bdakin@apple.com>
1624
1625         Tiger build fix. No review needed.
1626
1627         * platform/graphics/cg/GraphicsContextCG.cpp:
1628         (WebCore::sRGBColorSpaceRef):
1629
1630 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1631
1632         Reviewed by Dan Bernstein.
1633
1634         https://bugs.webkit.org/show_bug.cgi?id=31312
1635         Decouple authentication panel callbacks from ResourceHandle
1636
1637         No change in functionality.
1638
1639         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1640         ResourceHandle as delegate.
1641
1642         * WebCore.vcproj/WebCore.vcproj:
1643         * platform/network/AuthenticationClient.h: Added.
1644         Added a new interface for listening to authentication panel notifications.
1645
1646         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1647         it wants with the project file.
1648
1649         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1650         interface class.
1651         (WebCore::AuthenticationClient::deref): Ditto.
1652
1653         * platform/network/ResourceHandle.h:
1654         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1655         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1656
1657         * platform/network/cf/AuthenticationCF.cpp:
1658         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1659         (WebCore::AuthenticationChallenge::platformCompare):
1660         * platform/network/cf/AuthenticationChallenge.h:
1661         (WebCore::AuthenticationChallenge::authenticationClient):
1662         * platform/network/chromium/AuthenticationChallenge.h:
1663         (WebCore::AuthenticationChallenge::authenticationClient):
1664         * platform/network/curl/AuthenticationChallenge.h:
1665         (WebCore::AuthenticationChallenge::authenticationClient):
1666         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1667
1668 2009-11-10  Beth Dakin  <bdakin@apple.com>
1669
1670        Second attempted gtk build fix. No review needed.
1671
1672         * html/canvas/CanvasStyle.cpp:
1673         (WebCore::CanvasStyle::applyStrokeColor):
1674
1675
1676 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1677
1678         Reviewed by Geoff Garen.
1679
1680         Fix back/forwards cache with JSC isolated worlds.
1681         https://bugs.webkit.org/show_bug.cgi?id=31310
1682         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1683
1684         Store the global object for all worlds, not just the normal world.
1685         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1686         so we can forget global objects if a world goes away.
1687
1688         * bindings/js/JSDOMBinding.cpp:
1689         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1690         * bindings/js/JSDOMBinding.h:
1691         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1692         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1693         * bindings/js/ScriptCachedFrameData.cpp:
1694         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1695         (WebCore::ScriptCachedFrameData::forgetWorld):
1696         (WebCore::ScriptCachedFrameData::domWindow):
1697         (WebCore::ScriptCachedFrameData::restore):
1698         (WebCore::ScriptCachedFrameData::clear):
1699         * bindings/js/ScriptCachedFrameData.h:
1700         * bindings/js/ScriptController.h:
1701
1702 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1703
1704         [Qt] Unreviewed buildfix after r50760.
1705
1706         * platform/graphics/qt/GraphicsContextQt.cpp:
1707         (WebCore::GraphicsContext::GraphicsContext):
1708
1709 2009-11-10  Beth Dakin  <bdakin@apple.com>
1710
1711         Attempted build fix. (No review needed.)
1712
1713         * GNUmakefile.am: Adding ColorSpace.h
1714
1715 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1716
1717         Reviewed by NOBODY - Build Fix.
1718
1719         Updated function calls to take a ColorSpace argument, passing
1720         in DeviceColorSpace for now - this should be fixed. Also added
1721         ColorSpace.h to WebCore project.
1722
1723         * WebCore.vcproj/WebCore.vcproj:
1724         * platform/graphics/win/FontCGWin.cpp:
1725         (WebCore::Font::drawGlyphs):
1726         * platform/graphics/win/GraphicsContextCGWin.cpp:
1727         (WebCore::GraphicsContext::GraphicsContext):
1728         * platform/win/PopupMenuWin.cpp:
1729         (WebCore::PopupMenu::paint):
1730         * platform/win/WebCoreTextRenderer.cpp:
1731         (WebCore::doDrawTextAtPoint):
1732         * rendering/RenderThemeSafari.cpp:
1733         (WebCore::RenderThemeSafari::paintMenuListButton):
1734
1735 2009-11-10  Jens Alfke  <snej@chromium.org>
1736
1737         Reviewed by Darin Adler.
1738
1739         Optimizations to Element::getAttribute
1740         https://bugs.webkit.org/show_bug.cgi?id=30926
1741
1742         * dom/Element.cpp:
1743         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1744         * dom/NamedAttrMap.cpp:
1745         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1746         * platform/text/PlatformString.h:
1747         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1748
1749 2009-11-10  Beth Dakin  <bdakin@apple.com>
1750
1751         Reviewed by Darin Adler.
1752
1753         Fix for <rdar://problem/7059710> 
1754         -and corresponding-
1755         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1756         color-correction for CSS colors
1757
1758         New exported symbol for GraphicsContext::fillColor() which now 
1759         accepts a ColorSpace as an optional parameter.
1760         * WebCore.base.exp:
1761
1762         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1763         * WebCore.xcodeproj/project.pbxproj:
1764
1765         Computed Style for -webkit-color-correction
1766         * css/CSSComputedStyleDeclaration.cpp:
1767         (WebCore::):
1768         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1769
1770         Parse -webkit-color-correction
1771         * css/CSSParser.cpp:
1772         (WebCore::CSSParser::parseValue):
1773
1774        Map CSS identifiers to the appropriate values of the ColorSpace enum
1775         * css/CSSPrimitiveValueMappings.h:
1776         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1777         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1778
1779         New property -webkit-color-correction
1780         * css/CSSPropertyNames.in:
1781
1782         Map -webkit-color-correction into the RenderStyle.
1783         * css/CSSStyleSelector.cpp:
1784         (WebCore::CSSStyleSelector::applyProperty):
1785
1786         Add new value sRGB.
1787         * css/CSSValueKeywords.in:
1788
1789         Comment out the reference to sRGB since it will now be inherited as 
1790         a value from CSSValueKeywords.
1791         * css/SVGCSSValueKeywords.in:
1792
1793         Definition of the ColorSpace enum.
1794         * platform/graphics/ColorSpace.h: Added.
1795         (WebCore::):
1796
1797         These functions all now take a ColorSpace as a parameter.
1798         * platform/graphics/GraphicsContext.cpp:
1799         (WebCore::GraphicsContext::setStrokeColor):
1800         (WebCore::GraphicsContext::setFillColor):
1801         (WebCore::GraphicsContext::drawHighlightForText):
1802
1803         Return the appropriate ColorSpace.
1804         (WebCore::GraphicsContext::strokeColorSpace):
1805         (WebCore::GraphicsContext::fillColorSpace):
1806
1807         These functions all call other functions which require a ColorSpace 
1808         as a parameter.
1809         (WebCore::GraphicsContext::setStrokePattern):
1810         (WebCore::GraphicsContext::setFillPattern):
1811         (WebCore::GraphicsContext::setStrokeGradient):
1812         (WebCore::GraphicsContext::setFillGradient):
1813
1814         All of the GraphicsContext functions that take a Color should now 
1815         also take a ColorSpace.
1816         * platform/graphics/GraphicsContext.h:
1817
1818         Added new member variables stokeColorSpace and fillColorSpace.
1819         * platform/graphics/GraphicsContextPrivate.h:
1820         (WebCore::GraphicsContextState::GraphicsContextState):
1821
1822         Attempt to keep the Cairo port building with all of the massive 
1823         changes to GraphicsContext.        
1824         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1825         (WebCore::GraphicsContext::fillRect):
1826         (WebCore::GraphicsContext::setPlatformFillColor):
1827         (WebCore::GraphicsContext::setPlatformStrokeColor):
1828         (WebCore::GraphicsContext::fillRoundedRect):
1829
1830         
1831         * platform/graphics/cg/GraphicsContextCG.cpp:
1832         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1833         CGColorSpaceRef for the sRGB color space.
1834         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1835         a CGColorSpaceRef for the device RGB color space.
1836
1837         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1838         sets the fill color to the specified color in the given ColorSpace.
1839         (WebCore::setCGStrokeColor): Same, but for stroke.
1840
1841         (WebCore::setCGFillColorSpace): New static to set the 
1842         CGFillColorSpace to the given ColorSpace
1843         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1844
1845         Send ColorSpaces when appropriate, set ColorSpaces when 
1846         appropriate, and check ColorSpaces when appropriate.
1847         (WebCore::GraphicsContext::GraphicsContext):
1848         (WebCore::GraphicsContext::drawRect):
1849         (WebCore::GraphicsContext::drawLine):
1850         (WebCore::GraphicsContext::fillPath):
1851         (WebCore::GraphicsContext::strokePath):
1852         (WebCore::GraphicsContext::fillRect):
1853         (WebCore::GraphicsContext::fillRoundedRect):
1854         (WebCore::GraphicsContext::strokeRect):
1855         (WebCore::GraphicsContext::drawLineForText):
1856         (WebCore::GraphicsContext::setPlatformStrokeColor):
1857         (WebCore::GraphicsContext::setPlatformFillColor):
1858
1859         Attempt to keep Haiku building.
1860         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1861         (WebCore::GraphicsContext::fillRect):
1862         (WebCore::GraphicsContext::fillRoundedRect):
1863         (WebCore::GraphicsContext::setPlatformStrokeColor):
1864         (WebCore::GraphicsContext::setPlatformFillColor):
1865
1866         Attempt to keep QT building.
1867         * platform/graphics/qt/GraphicsContextQt.cpp:
1868         (WebCore::GraphicsContext::fillRect):
1869         (WebCore::GraphicsContext::fillRoundedRect):
1870         (WebCore::GraphicsContext::setPlatformStrokeColor):
1871         (WebCore::GraphicsContext::setPlatformFillColor):
1872
1873         Attempt to keep Wince building.
1874         * platform/graphics/wince/GraphicsContextWince.cpp:
1875         (WebCore::GraphicsContext::fillRect):
1876         (WebCore::GraphicsContext::setPlatformFillColor):
1877         (WebCore::GraphicsContext::setPlatformStrokeColor):
1878         (WebCore::GraphicsContext::clearRect):
1879         (WebCore::GraphicsContext::fillRoundedRect):
1880         (WebCore::GraphicsContext::setPlatformShadow):
1881
1882         Attempt to keep WX building.
1883         * platform/graphics/wx/GraphicsContextWx.cpp:
1884         (WebCore::GraphicsContext::fillRect):
1885         (WebCore::GraphicsContext::fillRoundedRect):
1886         (WebCore::GraphicsContext::setPlatformStrokeColor):
1887         (WebCore::GraphicsContext::setPlatformFillColor):
1888
1889         Added functions colorSpace() and setColorSpace()
1890         * rendering/style/RenderStyle.h:
1891         (WebCore::InheritedFlags::colorSpace):
1892         (WebCore::InheritedFlags::setColorSpace):
1893
1894         The ColorSpace is stored here.
1895         * rendering/style/StyleRareInheritedData.cpp:
1896         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1897         (WebCore::StyleRareInheritedData::operator==):
1898         * rendering/style/StyleRareInheritedData.h:
1899
1900         All of these call sites call GraphicsContext functions which now 
1901         require ColorSpaces.
1902         * editing/SelectionController.cpp:
1903         (WebCore::SelectionController::paintCaret):
1904         * html/canvas/CanvasRenderingContext2D.cpp:
1905         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1906         * html/canvas/CanvasStyle.cpp:
1907         (WebCore::CanvasStyle::applyStrokeColor):
1908         (WebCore::CanvasStyle::applyFillColor):
1909         * inspector/InspectorController.cpp:
1910         (WebCore::drawOutlinedQuad):
1911         * page/FrameView.cpp:
1912         (WebCore::FrameView::paintContents):
1913         * platform/ScrollbarTheme.h:
1914         (WebCore::ScrollbarTheme::paintScrollCorner):
1915         * platform/ScrollbarThemeComposite.cpp:
1916         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1917         * platform/graphics/Image.cpp:
1918         (WebCore::Image::fillWithSolidColor):
1919         * platform/graphics/mac/FontMac.mm:
1920         (WebCore::Font::drawGlyphs):
1921         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1922         (WebCore::MediaPlayerPrivate::paint):
1923         * rendering/EllipsisBox.cpp:
1924         (WebCore::EllipsisBox::paint):
1925         * rendering/InlineFlowBox.cpp:
1926         (WebCore::InlineFlowBox::paintTextDecorations):
1927         * rendering/InlineTextBox.cpp:
1928         (WebCore::updateGraphicsContext):
1929         (WebCore::paintTextWithShadows):
1930         (WebCore::InlineTextBox::paint):
1931         (WebCore::InlineTextBox::paintSelection):
1932         (WebCore::InlineTextBox::paintCompositionBackground):
1933         (WebCore::InlineTextBox::paintDecoration):
1934         (WebCore::InlineTextBox::paintTextMatchMarker):
1935         (WebCore::InlineTextBox::paintCompositionUnderline):
1936         * rendering/InlineTextBox.h:
1937         * rendering/RenderBlock.cpp:
1938         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1939         (WebCore::RenderBlock::fillVerticalSelectionGap):
1940         (WebCore::RenderBlock::fillLeftSelectionGap):
1941         (WebCore::RenderBlock::fillRightSelectionGap):
1942         * rendering/RenderBoxModelObject.cpp:
1943         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1944         (WebCore::RenderBoxModelObject::paintBoxShadow):
1945         * rendering/RenderFileUploadControl.cpp:
1946         (WebCore::RenderFileUploadControl::paintObject):
1947         * rendering/RenderFrameSet.cpp:
1948         (WebCore::RenderFrameSet::paintColumnBorder):
1949         (WebCore::RenderFrameSet::paintRowBorder):
1950         * rendering/RenderImage.cpp:
1951         (WebCore::RenderImage::paintReplaced):
1952         * rendering/RenderLayer.cpp:
1953         (WebCore::RenderLayer::paintScrollCorner):
1954         (WebCore::RenderLayer::paintResizer):
1955         * rendering/RenderListBox.cpp:
1956         (WebCore::RenderListBox::paintItemForeground):
1957         (WebCore::RenderListBox::paintItemBackground):
1958         * rendering/RenderListMarker.cpp:
1959         (WebCore::RenderListMarker::paint):
1960         * rendering/RenderObject.cpp:
1961         (WebCore::RenderObject::drawLineForBoxSide):
1962         (WebCore::RenderObject::drawArcForBoxSide):
1963         * rendering/RenderReplaced.cpp:
1964         (WebCore::RenderReplaced::paint):
1965         * rendering/RenderScrollbarTheme.cpp:
1966         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1967         * rendering/RenderThemeMac.mm:
1968         (WebCore::RenderThemeMac::paintMenuListButton):
1969         * rendering/RenderView.cpp:
1970         (WebCore::RenderView::paintBoxDecorations):
1971         * rendering/RenderWidget.cpp:
1972         (WebCore::RenderWidget::paint):
1973         * rendering/SVGInlineTextBox.cpp:
1974         (WebCore::SVGInlineTextBox::paintSelection):
1975         * svg/graphics/SVGPaintServerGradient.cpp:
1976         (WebCore::SVGPaintServerGradient::setup):
1977         * svg/graphics/SVGPaintServerSolid.cpp:
1978         (WebCore::SVGPaintServerSolid::setup):
1979
1980 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1981
1982         Reviewed by Timothy Hatcher.
1983
1984         Web Inspector: Speed up syntax highlighter
1985         https://bugs.webkit.org/show_bug.cgi?id=31291
1986
1987         * inspector/front-end/SourceFrame.js:
1988         (WebInspector.SourceFrame.prototype._loaded):
1989         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1990         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1991         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1992         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1993         (WebInspector.CSSSourceSyntaxHighlighter):
1994         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1995
1996 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1997
1998         Reviewed by Eric Seidel.
1999
2000         Remove session storage setting
2001         https://bugs.webkit.org/show_bug.cgi?id=31279
2002
2003         Remove session storage from Settings.  It was added temporarily so we could
2004         disable it by default at runtime in Chromium.  We now disable these things in a
2005         different way, so it's time to remove it.  Qt also depended on this setting for
2006         a short period of time, but after talking to them we agreed that it should be
2007         removed.
2008
2009         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
2010
2011         * page/DOMWindow.cpp:
2012         (WebCore::DOMWindow::sessionStorage):
2013         * page/Settings.cpp:
2014         (WebCore::Settings::Settings):
2015         * page/Settings.h:
2016
2017 2009-11-10  Dan Bernstein  <mitz@apple.com>
2018
2019         Reviewed by Eric Carlson and Darin Adler.
2020
2021         WebCore part of making full-screen video pause during scrubbing.
2022
2023         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
2024         and HTMLMediaElement::endScrubbing().
2025
2026 2009-11-10  Anton Muhin  <antonm@chromium.org>
2027
2028         Reviewed by Adam Barth.
2029
2030         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
2031         https://bugs.webkit.org/show_bug.cgi?id=31051
2032
2033         * bindings/v8/V8GCController.cpp:
2034         (WebCore::V8GCController::gcEpilogue):
2035         (WebCore::V8GCController::checkMemoryUsage):
2036         * bindings/v8/V8GCController.h:
2037         * bindings/v8/V8Proxy.cpp:
2038         (WebCore::V8Proxy::evaluate):
2039         (WebCore::V8Proxy::runScript):
2040         (WebCore::V8Proxy::callFunction):
2041
2042 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
2043
2044         Reviewed by Darin Adler.
2045
2046         Allow custom memory allocation control for the part of loader directory in WebCore
2047         https://bugs.webkit.org/show_bug.cgi?id=31161
2048
2049         Inherits the following classes from Noncopyable because these are instantiated
2050         by 'new' and these are no need to be copyable:
2051
2052         class Request - WebCore/loader/loader.cpp:100
2053         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2054         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2055         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2056         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2057         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2058
2059         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2060         MainThreadBridge is instantiated by 'new' in 
2061         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2062
2063         ThreadableLoaderClient's inheriting has been changed to public.
2064
2065         * loader/ImageLoader.cpp:
2066         * loader/ProgressTracker.cpp:
2067         * loader/RedirectScheduler.cpp:
2068         * loader/Request.h:
2069         * loader/ThreadableLoaderClient.h:
2070         * loader/WorkerThreadableLoader.h:
2071         * loader/appcache/ApplicationCacheHost.h:
2072         * loader/appcache/ApplicationCacheStorage.h:
2073
2074 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2075
2076         Reviewed by Eric Seidel.
2077
2078         https://bugs.webkit.org/show_bug.cgi?id=31047
2079         [GTK] Failing test media/video-played-ranges-1.html
2080
2081         WebKit coding style fixes.
2082
2083         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2084         (WebCore::mediaPlayerPrivateMessageCallback):
2085         (WebCore::MediaPlayerPrivate::naturalSize):
2086         (WebCore::MediaPlayerPrivate::paint):
2087         (WebCore::mimeTypeCache):
2088
2089 2009-11-10  Oliver Hunt  <oliver@apple.com>
2090
2091         Remove build failure introduced by earlier build fix.
2092
2093         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2094
2095 2009-11-10  Oliver Hunt  <oliver@apple.com>
2096
2097         Is this the last build fix? grep tells me yes.
2098
2099         * bindings/v8/custom/V8DocumentCustom.cpp:
2100         (WebCore::CALLBACK_FUNC_DECL):
2101
2102 2009-11-10  Oliver Hunt  <oliver@apple.com>
2103
2104         Hopefully the last one.  Why aren't these autogenerated?
2105
2106         * bindings/v8/V8DOMWrapper.cpp:
2107         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2108         (WebCore::V8DOMWrapper::getTemplate):
2109         (WebCore::V8DOMWrapper::convertToV8Object):
2110
2111 2009-11-10  Oliver Hunt  <oliver@apple.com>
2112
2113         Another chrome build fix.
2114
2115         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2116         (WebCore::CALLBACK_FUNC_DECL):
2117
2118 2009-11-10  Oliver Hunt  <oliver@apple.com>
2119
2120         Yet another chrome buildfix
2121
2122         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2123         (WebCore::CALLBACK_FUNC_DECL):
2124         * bindings/v8/custom/V8WebGLArrayCustom.h:
2125         (WebCore::constructCanvasArray):
2126         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2127         (WebCore::CALLBACK_FUNC_DECL):
2128         (WebCore::INDEXED_PROPERTY_GETTER):
2129         (WebCore::INDEXED_PROPERTY_SETTER):
2130         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2131         (WebCore::CALLBACK_FUNC_DECL):
2132         (WebCore::INDEXED_PROPERTY_GETTER):
2133         (WebCore::INDEXED_PROPERTY_SETTER):
2134         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2135         (WebCore::CALLBACK_FUNC_DECL):
2136         (WebCore::INDEXED_PROPERTY_GETTER):
2137         (WebCore::INDEXED_PROPERTY_SETTER):
2138         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2139         (WebCore::CALLBACK_FUNC_DECL):
2140         (WebCore::vertexAttribAndUniformHelperf):
2141         (WebCore::uniformHelperi):
2142         (WebCore::uniformMatrixHelper):
2143         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2144         (WebCore::CALLBACK_FUNC_DECL):
2145         (WebCore::INDEXED_PROPERTY_GETTER):
2146         (WebCore::INDEXED_PROPERTY_SETTER):
2147         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2148         (WebCore::CALLBACK_FUNC_DECL):
2149         (WebCore::INDEXED_PROPERTY_GETTER):
2150         (WebCore::INDEXED_PROPERTY_SETTER):
2151         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2152         (WebCore::CALLBACK_FUNC_DECL):
2153         (WebCore::INDEXED_PROPERTY_GETTER):
2154         (WebCore::INDEXED_PROPERTY_SETTER):
2155         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2156         (WebCore::CALLBACK_FUNC_DECL):
2157         (WebCore::INDEXED_PROPERTY_GETTER):
2158         (WebCore::INDEXED_PROPERTY_SETTER):
2159
2160 2009-11-10  Oliver Hunt  <oliver@apple.com>
2161
2162         Chrome build fix.
2163
2164         * bindings/v8/V8Index.h:
2165
2166 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2167
2168         Reviewed by Reviewed by Jan Alonzo.
2169
2170         https://bugs.webkit.org/show_bug.cgi?id=30901
2171         [Gtk] Need to de-lint the Atk a11y code
2172
2173         Removal of various and sundry style-violating nits.
2174
2175         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2176
2177 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2178
2179         Reviewed by Jan Alonzo.
2180
2181         https://bugs.webkit.org/show_bug.cgi?id=31047
2182         [GTK] Failing test media/video-played-ranges-1.html
2183
2184         Fix playback rate setter by remembering the rate was changed. Also
2185         correctly handle reverse playback by doing a seek from end to
2186         beginning of the media.
2187
2188         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2189         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2190         (WebCore::MediaPlayerPrivate::currentTime):
2191         (WebCore::MediaPlayerPrivate::seek):
2192         (WebCore::MediaPlayerPrivate::hasAudio):
2193         (WebCore::MediaPlayerPrivate::setVolume):
2194         (WebCore::MediaPlayerPrivate::setRate):
2195         (WebCore::MediaPlayerPrivate::updateStates):
2196         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2197
2198 2009-11-10  Oliver Hunt  <oliver@apple.com>
2199
2200         Reviewed by Maciej Stachowiak.
2201
2202         Rename 3D Canvas related classes to use WebGL prefix
2203         https://bugs.webkit.org/show_bug.cgi?id=29095
2204
2205         Automatic rename of all WebGL related types from Canvas* to
2206         WebGL* per more recent version of the WebGL spec.
2207
2208         Due to the automatic rename I've removed the 600+ line change list.
2209
2210 2009-11-09  Dirk Schulze  <krit@webkit.org>
2211
2212         Reviewed by Oliver Hunt.
2213
2214         SVG feDisplacementMap is not implemented
2215         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2216
2217         This is the implementation of the SVG filter effect
2218         feDisplacementMap. 
2219
2220         Test: svg/filters/feDisplacementMap.svg
2221
2222         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2223         (WebCore::FEDisplacementMap::apply):
2224
2225 2009-11-09  Kent Tamura  <tkent@chromium.org>
2226
2227         Reviewed by Darin Adler.
2228
2229         Add a comment about null strings and hash functions.
2230         https://bugs.webkit.org/show_bug.cgi?id=29118
2231
2232         * platform/text/StringHash.h:
2233
2234 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2235
2236         Reviewed by Darin Adler.
2237
2238         Compiler warnings in InspectorResource.h
2239         https://bugs.webkit.org/show_bug.cgi?id=29231
2240
2241         Fix compilation warnings by removing addition operation on an enum type.
2242
2243         * inspector/InspectorResource.h:
2244         (WebCore::InspectorResource::):
2245         (WebCore::InspectorResource::Changes::hasChange):
2246         (WebCore::InspectorResource::Changes::set):
2247         (WebCore::InspectorResource::Changes::setAll):
2248
2249 2009-11-09  Anders Carlsson  <andersca@apple.com>
2250
2251         Reviewed by Darin Adler and Dan Bernstein.
2252
2253         <rdar://problem/7328395>
2254         https://bugs.webkit.org/show_bug.cgi?id=31277
2255
2256         When an object tag's style changes (for example when child nodes are added/removed),
2257         reuse its Frame (if it has one) instead of creating multiple Frames.
2258
2259         Test: fast/dom/HTMLObjectElement/children-changed.html
2260
2261         * loader/FrameLoader.cpp:
2262         (WebCore::FrameLoader::requestObject):
2263
2264 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2265
2266         Reviewed by Kenneth Rohde Christiansen.
2267
2268         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2269         since adjustment of RW-section base address will be needed for all new symbian
2270         tool chains, specifically for arm and gcc compilation targets.
2271         Also, change target address to 0xE00000 to be sufficient for all targets.
2272
2273         * WebCore.pro:
2274
2275 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2276
2277         Reviewed by Timothy Hatcher.
2278
2279         Web Inspector: Crash when inspecting
2280         WebCore\manual-tests\inspector\dom-mutation.html
2281
2282         https://bugs.webkit.org/show_bug.cgi?id=31259
2283
2284         * inspector/InspectorDOMAgent.cpp:
2285         (WebCore::InspectorDOMAgent::handleEvent):
2286
2287 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2288
2289         Reviewed by Kenneth Rohde Christiansen.
2290
2291         [Qt] Few classes have virtual functions but non-virtual destructor
2292         https://bugs.webkit.org/show_bug.cgi?id=31269
2293
2294         No new tests as there is no functional change.
2295
2296         * platform/qt/QWebPageClient.h:
2297         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2298
2299 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2300
2301         Reviewed by Kenneth Rohde Christiansen.
2302
2303         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2304         https://bugs.webkit.org/show_bug.cgi?id=31140
2305
2306         QtNetwork interprets null string as request to remove the header, not add it.
2307         Replace null values with empty values before passing them to QtNetwork.
2308
2309         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2310
2311         * platform/network/qt/ResourceRequestQt.cpp:
2312         (WebCore::ResourceRequest::toNetworkRequest):
2313
2314 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2315
2316         Reviewed by Kevin Ollivier.
2317
2318         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2319         simply ignored before resulting in transparent areas being black in PNG
2320         images for example.
2321         
2322         https://bugs.webkit.org/show_bug.cgi?id=30823
2323
2324         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2325         (WebCore::RGBA32Buffer::asNewNativeImage):
2326
2327 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2328
2329         Reviewed by Kenneth Rohde Christiansen.
2330
2331         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2332         https://bugs.webkit.org/show_bug.cgi?id=31040
2333
2334         No new tests as there is no functional change.
2335
2336         * dom/Document.cpp:
2337         (WebCore::Document::recalcStyleSelector):
2338         * editing/TextIterator.cpp:
2339         (WebCore::pushFullyClippedState):
2340         * editing/VisibleSelection.cpp:
2341         (WebCore::VisibleSelection::appendTrailingWhitespace):
2342         * html/HTMLLinkElement.cpp:
2343         (WebCore::HTMLLinkElement::process):
2344         * loader/RedirectScheduler.cpp:
2345         (WebCore::RedirectScheduler::mustLockBackForwardList):
2346         * loader/appcache/ApplicationCacheGroup.cpp:
2347         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2348         * platform/graphics/qt/FontCacheQt.cpp:
2349         (WebCore::FontPlatformDataCacheKey::computeHash):
2350         * rendering/RenderBlock.cpp:
2351         (WebCore::RenderBlock::handleRunInChild):
2352         * rendering/RenderBox.cpp:
2353         (WebCore::RenderBox::calcHeight):
2354         * rendering/RenderTextControlMultiLine.cpp:
2355         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2356         * rendering/style/RenderStyle.cpp:
2357         (WebCore::RenderStyle::diff):
2358         * svg/SVGAnimateElement.cpp:
2359         (WebCore::parseNumberValueAndUnit):
2360         * svg/SVGAnimationElement.cpp:
2361         (WebCore::SVGAnimationElement::startedActiveInterval):
2362         * svg/SVGPreserveAspectRatio.cpp:
2363         (WebCore::SVGPreserveAspectRatio::getCTM):
2364
2365 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2366
2367         Reviewed by Dimitri Glazkov.
2368
2369         Win chromium is slow to draw transparent texts
2370         https://bugs.webkit.org/show_bug.cgi?id=31258
2371
2372         Clip graphics context to reduce calculation.
2373
2374         No new tests because this change only affects performance.
2375
2376         * platform/graphics/chromium/FontChromiumWin.cpp:
2377         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2378         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2379
2380 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2381
2382         Reviewed by Darin Adler.
2383
2384         showTree(CounterNode*) generates too little info and has too many spaces.
2385         https://bugs.webkit.org/show_bug.cgi?id=31212
2386
2387         No new tests as the change has no functional effect it is just for
2388         improved debugging.
2389
2390         * rendering/CounterNode.cpp:
2391         (WebCore::showTreeAndMark):
2392         Changed to also show addresses of parent, next and previous
2393         siblings.
2394
2395 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2396
2397         Reviewed by Darin Adler.
2398
2399         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2400         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2401
2402         https://bugs.webkit.org/show_bug.cgi?id=31083
2403
2404         No new tests; implementation is unchanged.
2405
2406         * page/Frame.cpp:
2407         (WebCore::Frame::setUseSecureKeyboardEntry):
2408         * page/mac/FrameMac.mm:
2409
2410 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2411
2412         Reviewed by Jan Alonzo.
2413
2414         Make XP_UNIX tests consistent
2415         https://bugs.webkit.org/show_bug.cgi?id=31250
2416
2417         No new tests as there is no functional change.
2418
2419         * plugins/PluginView.cpp:
2420         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2421         instead of the value of the macro
2422
2423         * plugins/gtk/PluginViewGtk.cpp:
2424         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2425         defined instead of using the PLATFORM macro to be consistent
2426         (WebCore::PluginView::getValue): Ditto.
2427
2428 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2429
2430         Reviewed by Darin Adler.
2431
2432         Thunk to the main thread from ~Database to deref Database's m_document.
2433
2434         If the Database was the Document's last referrer, then ~Document occurs on the
2435         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2436         ASSERT in debug builds.
2437
2438         * storage/Database.cpp:
2439         (WebCore::derefDocument):
2440         (WebCore::Database::~Database):
2441
2442 2009-11-09  Mark Mentovai  <mark@chromium.org>
2443
2444         Reviewed by Dan Bernstein.
2445
2446         Track "can have scrollbar" state within FrameView independently of the
2447         individual scrollbar states in ScrollView.
2448
2449         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2450         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2451         edit mode.
2452
2453         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2454         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2455
2456         Test: fast/overflow/scrollbar-restored.html
2457
2458         * WebCore.base.exp:
2459         * page/FrameView.cpp:
2460         (WebCore::FrameView::FrameView):
2461         (WebCore::FrameView::resetScrollbars):
2462         (WebCore::FrameView::setCanHaveScrollbars):
2463         (WebCore::FrameView::updateCanHaveScrollbars):
2464         (WebCore::FrameView::layout):
2465         * page/FrameView.h:
2466         * platform/ScrollView.h:
2467
2468 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2469
2470         Reviewed by Timothy Hatcher.
2471
2472         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2473         https://bugs.webkit.org/show_bug.cgi?id=31257
2474
2475         * inspector/front-end/SourceFrame.js:
2476
2477 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2478
2479         Reviewed by Timothy Hatcher.
2480
2481         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2482         https://bugs.webkit.org/show_bug.cgi?id=31252
2483
2484         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2485
2486         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2487
2488         * inspector/front-end/ConsoleView.js:
2489         (WebInspector.ConsoleView.prototype._promptKeyDown):
2490         * inspector/front-end/utilities.js:
2491         ():
2492         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2493
2494 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2495
2496         Reviewed by Kenneth Rohde Christiansen.
2497
2498         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2499         https://bugs.webkit.org/show_bug.cgi?id=31208
2500
2501         After r42483, the credentials are no longer passed to the network request
2502         in the URL of the request.
2503         Pass the credentials from XMLHTTPRequest to the network request, the same
2504         way that other ports do.
2505
2506         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2507
2508         * platform/network/qt/ResourceHandleQt.cpp:
2509         (WebCore::ResourceHandle::start):
2510         (WebCore::ResourceHandle::loadResourceSynchronously):
2511
2512 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2513
2514         Unreviewed.
2515
2516         https://bugs.webkit.org/show_bug.cgi?id=31161
2517
2518         Roll back r50657 because it breaks the MAC builds.
2519
2520         * loader/ImageLoader.cpp:
2521         * loader/ProgressTracker.cpp:
2522         * loader/RedirectScheduler.cpp:
2523         * loader/Request.h:
2524         * loader/ThreadableLoaderClient.h:
2525         * loader/WorkerThreadableLoader.h:
2526         * loader/appcache/ApplicationCacheHost.h:
2527         * loader/appcache/ApplicationCacheStorage.h:
2528         * loader/icon/IconDatabaseClient.h:
2529
2530 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2531
2532         Reviewed by Darin Adler.
2533
2534         Allow custom memory allocation control for the part of loader directory in WebCore
2535         https://bugs.webkit.org/show_bug.cgi?id=31161
2536
2537         Inherits the following classes from Noncopyable because these are instantiated
2538         by 'new' and these are no need to be copyable:
2539
2540         class Request - WebCore/loader/loader.cpp:100
2541         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2542         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2543         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2544         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2545         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2546         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2547
2548         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2549         MainThreadBridge is instantiated by 'new' in 
2550         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2551
2552         ThreadableLoaderClient's inheriting has been changed to public.
2553
2554         * loader/ImageLoader.cpp:
2555         * loader/ProgressTracker.cpp:
2556         * loader/RedirectScheduler.cpp:
2557         * loader/Request.h:
2558         * loader/ThreadableLoaderClient.h:
2559         * loader/WorkerThreadableLoader.h:
2560         * loader/appcache/ApplicationCacheHost.h:
2561         * loader/appcache/ApplicationCacheStorage.h:
2562         * loader/icon/IconDatabaseClient.h:
2563
2564 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2565
2566         Reviewed by Darin Adler.
2567
2568         Allow custom memory allocation control for WebCore's DocLoader
2569         https://bugs.webkit.org/show_bug.cgi?id=31163
2570
2571         Inherits DocLoader class from Noncopyable because it is
2572         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2573         it is no need to be copyable.
2574
2575         * loader/DocLoader.h:
2576
2577 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2578
2579         Reviewed by Darin Adler.
2580
2581         Allow custom memory allocation control for WebCore's Tokenizer
2582         https://bugs.webkit.org/show_bug.cgi?id=31162
2583
2584         Inherits Tokenizer class from Noncopyable because (its child class)
2585         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2586         and it is no need to be copyable.
2587
2588         * dom/Tokenizer.h:
2589
2590 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2591
2592         Reviewed by Darin Adler.
2593
2594         Allow custom memory allocation control for WebCore's DeleteButtonController
2595         https://bugs.webkit.org/show_bug.cgi?id=31105
2596
2597         Inherits DeleteButtonController class from Noncopyable because it is 
2598         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2599         it is no need to be copyable.  
2600
2601         * editing/DeleteButtonController.h:
2602
2603 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2604
2605         Reviewed by Jan Alonzo.
2606
2607         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2608         https://bugs.webkit.org/show_bug.cgi?id=30482
2609
2610         Expose Page::tabKeyCyclesThroughElements as a property of
2611         WebKitWebView.
2612
2613         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2614
2615         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2616         (WebCore::singleCharacterString):
2617
2618 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2619
2620         Reviewed by Xan Lopez.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=25415
2623         [GTK][ATK] Please implement support for get_text_at_offset
2624
2625         Fix a crasher that occurred with text which included newline
2626         chars in the markup.
2627
2628         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2629         (convertUniCharToUTF8):
2630
2631 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2632
2633         Reviewed by Holger Freyther.
2634
2635         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2636         https://bugs.webkit.org/show_bug.cgi?id=31144
2637
2638         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2639         documents that end prematurely but are not considered invalid by QXmlStream.
2640         This is to stay compatible with the libxml2 implementation.
2641         However, that code path would be also hit in situations when it should not,
2642         i.e. the error would have already been caught and handled. As a result, the
2643         same error would be reported twice.
2644
2645         No new tests, because the problem is already covered by
2646         fast/parser/xml-declaration-missing-ending-mark.html.
2647
2648         * dom/XMLTokenizerQt.cpp:
2649         (WebCore::XMLTokenizer::doEnd):
2650
2651 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2652
2653         Reviewed by Pavel Feldman.
2654
2655         Web Inspector: Inspector should support copy() in the command line
2656         https://bugs.webkit.org/show_bug.cgi?id=31238
2657
2658         * inspector/InspectorBackend.cpp:
2659         (WebCore::InspectorBackend::copyText): Added.
2660         * inspector/InspectorBackend.h: Added copyText
2661         * inspector/InspectorBackend.idl: Added copyText
2662         * inspector/front-end/InjectedScript.js:
2663         (InjectedScript._copy): Added.
2664         (InjectedScript._ensureCommandLineAPIInstalled):
2665
2666 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2667
2668         Reviewed by Dimitri Glazkov.
2669
2670         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2671         https://bugs.webkit.org/show_bug.cgi?id=31226
2672
2673         Now checks to see what type of context is active and creates the
2674         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2675
2676         Added support for converting to SharedWorkers and SharedWorkerContexts.
2677
2678         Test: Existing layout tests cover this case (start passing in Chrome).
2679
2680         * bindings/v8/WorkerContextExecutionProxy.cpp:
2681         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2682         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2683         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2684         Added support for SHAREDWORKERCONTEXT.
2685         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2686         Added support for SharedWorker and SharedWorkerContext.
2687
2688 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2689
2690         Reviewed by Dimitri Glazkov.
2691
2692         https://bugs.webkit.org/show_bug.cgi?id=31224
2693         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2694
2695         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2696
2697         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2698         (WebCore::NAMED_PROPERTY_GETTER):
2699
2700 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2701
2702         Reviewed by Timothy Hatcher.
2703
2704         Web Inspector: "Search again" on scripts panel switches
2705         to the script this search started with.
2706
2707         https://bugs.webkit.org/show_bug.cgi?id=31243
2708
2709         * inspector/front-end/Panel.js:
2710         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2711
2712 2009-11-08  Kent Tamura  <tkent@chromium.org>
2713
2714         Reviewed by Darin Adler.
2715
2716         Simplify Icon interface.
2717         https://bugs.webkit.org/show_bug.cgi?id=31154
2718
2719         - Remove Icon::createIconForFile().  createIconForFiles() covers
2720           createIconForFile()'s role.
2721         - Remove FileChooser::chooseIcon()
2722         - Change the parameter types of FileChooser constructor and the
2723           factory method, String -> const Vector<String>&, in order to
2724           support initialization with multiple files.
2725         - Remove the icon loading code in IconChromiumWin.cpp, which
2726           doesn't work because of the sandbox.
2727
2728         No tests because it's just a refactoring.
2729
2730         * platform/FileChooser.cpp:
2731         (WebCore::FileChooser::FileChooser):
2732         (WebCore::FileChooser::create):
2733         (WebCore::FileChooser::chooseFile):
2734         (WebCore::FileChooser::chooseFiles):
2735         * platform/FileChooser.h:
2736         * platform/graphics/Icon.h:
2737         * platform/graphics/chromium/IconChromiumLinux.cpp:
2738         * platform/graphics/chromium/IconChromiumMac.cpp:
2739         * platform/graphics/chromium/IconChromiumWin.cpp:
2740         (WebCore::Icon::createIconForFiles):
2741         * platform/graphics/gtk/IconGtk.cpp:
2742         (WebCore::Icon::createIconForFiles):
2743         * platform/graphics/haiku/IconHaiku.cpp:
2744         * platform/graphics/mac/IconMac.mm:
2745         (WebCore::Icon::createIconForFiles):
2746         * platform/graphics/qt/IconQt.cpp:
2747         (WebCore::Icon::createIconForFiles):
2748         * platform/graphics/win/IconWin.cpp:
2749         (WebCore::Icon::createIconForFiles):
2750         * platform/graphics/wx/IconWx.cpp:
2751         * rendering/RenderFileUploadControl.cpp:
2752         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2753
2754 2009-11-08  Daniel Bates  <dbates@webkit.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         https://bugs.webkit.org/show_bug.cgi?id=31098
2759
2760         Allows same-origin plugin-based content to load.
2761
2762         Test: http/tests/security/xssAuditor/object-src-inject.html
2763
2764         * page/XSSAuditor.cpp:
2765         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2766         (WebCore::XSSAuditor::canLoadObject): Ditto.
2767         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2768         (WebCore::XSSAuditor::isSameOriginResource): Added.
2769         * page/XSSAuditor.h:
2770
2771 2009-11-08  David Levin  <levin@chromium.org>
2772
2773         Reviewed by NOBODY (chromium build fix).
2774
2775         * platform/network/HTTPParsers.cpp:
2776         (WebCore::parseDate): Changed this to not
2777         use a date parser that needs ExecState passed.
2778         
2779 2009-11-08  David Levin  <levin@chromium.org>
2780
2781         Unreviewed build fix for chromium.
2782
2783         * platform/graphics/skia/GraphicsContextSkia.cpp:
2784         (WebCore::GraphicsContext::fillPath):
2785         (WebCore::GraphicsContext::fillRect):
2786         (WebCore::GraphicsContext::strokePath):
2787         (WebCore::GraphicsContext::strokeRect):
2788
2789 2009-11-08  David Levin  <levin@chromium.org>
2790
2791         Unreviewed build fix for chromium.
2792
2793         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2794         Clean up GraphicsContext's current concept of ColorSpace
2795
2796         * platform/graphics/skia/GraphicsContextSkia.cpp:
2797         (WebCore::GraphicsContext::fillPath):
2798         (WebCore::GraphicsContext::fillRect):
2799         (WebCore::GraphicsContext::strokePath):
2800         (WebCore::GraphicsContext::strokeRect):
2801
2802 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2803
2804         Reviewed by Timothy Hatcher.
2805
2806         Web Inspector: [REGRESSION] committing style edit
2807         clears elements panel selection.
2808
2809         https://bugs.webkit.org/show_bug.cgi?id=31242
2810
2811         * inspector/front-end/ElementsTreeOutline.js:
2812         (WebInspector.ElementsTreeOutline.prototype.update):
2813         * inspector/front-end/StylesSidebarPane.js:
2814         (WebInspector.StylePropertyTreeElement.prototype.):
2815         (WebInspector.StylePropertyTreeElement.prototype):
2816
2817 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2818
2819         Reviewed by Holger Freyther.
2820
2821         ResourceRequest to be class instead of struct
2822         https://bugs.webkit.org/show_bug.cgi?id=30670
2823
2824         Started as a compilation fix for Symbian where the compiler makes a distinction between
2825         class and struct in function argument signatures.
2826         Changed all forward declarations of ResourceRequest to have class in the forward
2827         declaration instead of struct and changed the definition of ResourceRequest to be class
2828         and added access qualifiers where missing. Additionally two references of friend
2829         struct ResourceRequestBase changed to class instead.
2830
2831         * history/HistoryItem.h:
2832         * inspector/InspectorController.h:
2833         * inspector/InspectorResource.h:
2834         * loader/DocumentThreadableLoader.h:
2835         * loader/FrameLoaderClient.h:
2836         * loader/MainResourceLoader.h:
2837         * loader/ResourceLoadNotifier.h:
2838         * loader/SubresourceLoader.h:
2839         * loader/SubresourceLoaderClient.h:
2840         * loader/ThreadableLoader.h:
2841         * loader/WorkerThreadableLoader.h:
2842         * loader/appcache/ApplicationCache.h:
2843         * loader/appcache/ApplicationCacheHost.h:
2844         * platform/CrossThreadCopier.h:
2845         * platform/network/ResourceHandle.h:
2846         * platform/network/ResourceHandleClient.h:
2847         * platform/network/ResourceRequestBase.h:
2848         * platform/network/cf/ResourceRequest.h:
2849         * platform/network/cf/ResourceRequestCFNet.h:
2850         * platform/network/chromium/ResourceRequest.h:
2851         * platform/network/curl/ResourceRequest.h:
2852         * platform/network/qt/ResourceRequest.h:
2853         * platform/network/soup/ResourceRequest.h:
2854         * xml/XMLHttpRequest.h:
2855
2856 2009-11-08  Dan Bernstein  <mitz@apple.com>
2857
2858         Reviewed by Simon Fraser.
2859
2860         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2861         below FrameView::layout
2862         https://bugs.webkit.org/show_bug.cgi?id=31093
2863
2864         Test: fast/block/positioning/relative-positioned-inline-container.html
2865
2866         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2867         to mark the object for layout, doing so without marking its ancestors.
2868         However, RenderBlock::skipLeadingWhitespace and
2869         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2870         positioned inline container, causing it to be marked for layout without
2871         ever going back to give it layout, and thus layout could end with a
2872         dirty object still in the tree, leading to all sorts of badness.
2873
2874         The fix is to revert setStaticY() to not marking the object dirty, and
2875         instead do it in the call sites that require it, which are in
2876         RenderBlock and RenderFlexibleBox.
2877
2878         * rendering/RenderBlock.cpp:
2879         (WebCore::RenderBlock::adjustPositionedBlock):
2880         * rendering/RenderFlexibleBox.cpp:
2881         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2882         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2883         * rendering/RenderLayer.cpp:
2884         * rendering/RenderLayer.h:
2885         (WebCore::RenderLayer::setStaticY):
2886
2887 2009-11-07  Daniel Bates  <dbates@webkit.org>
2888
2889         Reviewed by Darin Adler.
2890
2891         https://bugs.webkit.org/show_bug.cgi?id=20780
2892         
2893         Fixes an issue where the onchange event handler is not fired when the 
2894         input field is autocompleted.
2895         
2896         We cannot test this using DRT since DRT cannot emulate autocompletion.
2897         So, a manual-test is included.
2898
2899         Tests: manual-tests/autocompletion-fire-onchange.html
2900
2901         * manual-tests/autocompletion-fire-onchange.html: Added.
2902         * rendering/RenderTextControl.cpp:
2903         (WebCore::RenderTextControl::setInnerTextValue):
2904
2905 2009-11-07  Benjamin Otte  <otte@gnome.org>
2906
2907         Reviewed by Holger Freyther.
2908
2909         Mark redrawn areas on image surfaces as dirty.
2910
2911         This is required to conform to the Cairo API, but is currently only
2912         used by debugging tools like cairo-trace.
2913
2914         * platform/graphics/cairo/ImageBufferCairo.cpp:
2915         (WebCore::ImageBuffer::platformTransformColorSpace):
2916         (WebCore::putImageData):
2917
2918 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2919
2920         Reviewed by Xan Lopez.
2921
2922         https://bugs.webkit.org/show_bug.cgi?id=30878
2923         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2924
2925         If the end_offset is -1, use the String length as the end_offset.
2926
2927         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2928         (webkit_accessible_text_get_text):
2929
2930 2009-11-06  Beth Dakin  <bdakin@apple.com>
2931
2932         Reviewed by Adele Peterson.
2933
2934         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2935         GraphicsContext's current concept of ColorSpace
2936
2937         ColorSpace is now called ColorType. The variables on the state we 
2938         appropriately re-named as well. I removed strokeColorSpace() and 
2939         fillColorSpace() from GraphicsContext since they were never called. 
2940
2941         * platform/graphics/GraphicsContext.cpp:
2942         (WebCore::GraphicsContext::setStrokeColor):
2943         (WebCore::GraphicsContext::setFillColor):
2944         (WebCore::GraphicsContext::setStrokePattern):
2945         (WebCore::GraphicsContext::setFillPattern):
2946         (WebCore::GraphicsContext::setStrokeGradient):
2947         (WebCore::GraphicsContext::setFillGradient):
2948         * platform/graphics/GraphicsContext.h:
2949         (WebCore::):
2950         * platform/graphics/GraphicsContextPrivate.h:
2951         (WebCore::GraphicsContextState::GraphicsContextState):
2952         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2953         (WebCore::GraphicsContext::fillPath):
2954         (WebCore::GraphicsContext::strokePath):
2955         * platform/graphics/cg/GraphicsContextCG.cpp:
2956         (WebCore::calculateDrawingMode):
2957         (WebCore::GraphicsContext::drawPath):
2958         (WebCore::GraphicsContext::fillPath):
2959         (WebCore::GraphicsContext::strokePath):
2960         (WebCore::GraphicsContext::fillRect):
2961         (WebCore::GraphicsContext::strokeRect):
2962         * platform/graphics/qt/GraphicsContextQt.cpp:
2963         (WebCore::GraphicsContext::fillPath):
2964         (WebCore::GraphicsContext::strokePath):
2965         (WebCore::GraphicsContext::fillRect):
2966         * platform/graphics/wince/GraphicsContextWince.cpp:
2967         (WebCore::GraphicsContext::fillPath):
2968         (WebCore::GraphicsContext::fillRect):
2969
2970 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2971
2972         Reviewed by Tim Hatcher.
2973
2974         Fixes <http://webkit.org/b/31177>.
2975         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2976         
2977         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2978         places in the inspector can use editing in DataGrid (added a FIXME for
2979         some stuff that needs to be generalized).
2980         
2981         Also added deleting functionality to DataGrid, and implemented it for
2982         Cookies and DOM Storage. The reason this patch is so big is because of
2983         the refactoring of editing code, which won't be used yet in a cross-datagrid
2984         way, but should be able to.
2985         
2986         Additionally, moved the callbacks members from DOMStorageDataGrid to
2987         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2988         make the architecture of DOM Storage look a lot more like the Cookies view.
2989         
2990         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2991         inspector from beeping at you when you delete an element.
2992
2993         * WebCore.gypi: Removed DOMStorageDataGrid.
2994         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2995         * inspector/front-end/CookieItemsView.js:
2996         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2997         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2998         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2999         * inspector/front-end/DOMStorageDataGrid.js: Removed.
3000         * inspector/front-end/DOMStorageItemsView.js:
3001         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
3002         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
3003         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
3004         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
3005         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
3006         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
3007         * inspector/front-end/DataGrid.js:
3008         (WebInspector.DataGrid):
3009         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
3010         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
3011         (WebInspector.DataGrid.prototype._startEditing): Ditto.
3012         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
3013         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
3014         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
3015         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
3016         * inspector/front-end/ElementsTreeOutline.js:
3017         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
3018         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
3019         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
3020
3021 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3022
3023         Qt build fix: added an ExecState parameter.
3024
3025         * bridge/qt/qt_runtime.cpp:
3026         (JSC::Bindings::convertValueToQVariant):
3027         (JSC::Bindings::convertQVariantToValue):
3028
3029 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
3030
3031         https://bugs.webkit.org/show_bug.cgi?id=31197
3032         Implemented a timezone cache not based on Mac OS X's notify_check API.
3033
3034         Updated for JavaScriptCore internal API change.
3035
3036         * bridge/qt/qt_runtime.cpp:
3037         (JSC::Bindings::convertValueToQVariant):
3038         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
3039
3040         * platform/network/HTTPParsers.cpp:
3041         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
3042         (This function probably shouldn't be using a JavaScript date parser
3043         to begin with, but oh well.)
3044
3045 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3046
3047         Reviewed by Adam Barth.
3048
3049         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
3050         which affects Chromium only.
3051         
3052         Changes to V8HTMLDocumentCustom.cpp are as below:-
3053         1. The HTMLDocumentOpen function would cause a crash in Chromium if
3054            there was no calling javascript context. We now check for this case
3055            and pass in NULL to the HTMLDocument::open function which can handle
3056            a NULL document parameter.
3057         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
3058            had ASSERTS for a NULL caller frame, which was bogus as it would crash
3059            anyway. We now check for this case and return a failure.
3060            
3061         Changes to V8DOMWindowCustom.cpp are as below:-
3062         1. Instead of failing the window.open call made by NPAPI for lack of a
3063            calling javascript context, we now use the entered context as the calling
3064            context.
3065
3066         Tests: plugins/document-open.html
3067                plugins/window-open.html
3068
3069         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3070         (WebCore::CALLBACK_FUNC_DECL):
3071         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3072         (WebCore::CALLBACK_FUNC_DECL):
3073
3074 2009-11-06  Steve Block  <steveblock@google.com>
3075
3076         Reviewed by Eric Seidel.
3077
3078         Geolocation error code UNKNOWN_ERROR is deprecated.
3079         https://bugs.webkit.org/show_bug.cgi?id=31184
3080
3081         Remove this error code from PositionError, both for use from C++ code and from the JS object.
3082
3083         Updated fast/dom/Geolocation/error.html to test this.
3084
3085         * page/PositionError.h: Modified.
3086         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
3087         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
3088         * page/Geolocation.cpp: Modified.
3089         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3090         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
3091         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3092
3093 2009-11-06  Dirk Schulze  <krit@webkit.org>
3094
3095         Reviewed by Nikolas Zimmermann.
3096
3097         feMorphology filter is not implemented
3098         [https://bugs.webkit.org/show_bug.cgi?id=5863]
3099
3100         The Implementation of feMorphology.
3101         
3102         Test: We have allready a test for feMorphology
3103               svg/W3C-SVG-1.1/filters-morph-01-f.svg
3104
3105         * svg/graphics/filters/SVGFEMorphology.cpp:
3106         (WebCore::FEMorphology::apply):
3107
3108 2009-11-06  Steve Block  <steveblock@google.com>
3109
3110         Reviewed by Eric Seidel.
3111
3112         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3113         https://bugs.webkit.org/show_bug.cgi?id=31209
3114
3115         Build fix only. No new tests possible.
3116
3117         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3118
3119 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3120
3121         Reviewed by David Levin.
3122
3123         V8 bindings do not support SharedWorkers as event targets
3124         https://bugs.webkit.org/show_bug.cgi?id=31199
3125
3126         No new tests because existing layout tests suffice (they currently
3127         crash on Chromium)
3128
3129         * bindings/v8/V8DOMWrapper.cpp:
3130         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3131         Added clause to create a DOM wrapper for SharedWorkers.
3132
3133 2009-11-06  Anton Muhin  <antonm@chromium.org>
3134
3135         Reviewed by Adam Barth.
3136
3137         Do not unnecessarly synchronzie in weak reference callbacks.
3138         https://bugs.webkit.org/show_bug.cgi?id=31191
3139
3140         * bindings/v8/DOMData.h:
3141         (WebCore::DOMData::handleWeakObject):
3142
3143 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3144
3145         Reviewed by Pavel Feldman.
3146
3147         Fix resource content search.
3148         https://bugs.webkit.org/show_bug.cgi?id=31202
3149
3150         * inspector/front-end/AbstractTimelinePanel.js:
3151         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3152         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3153         * inspector/front-end/TimelinePanel.js:
3154         (WebInspector.TimelineGraph.prototype.refresh):
3155
3156 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3157
3158         Reviewed by Eric Seidel.
3159
3160         Fix ASSERT(currentStyle = renderStyle()).
3161         https://bugs.webkit.org/show_bug.cgi?id=31152
3162
3163         * dom/Element.cpp:
3164         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3165
3166 2009-11-05  Alpha Lam  <hclam@chromium.org>
3167
3168         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3169
3170         * bindings/v8/V8GCController.cpp:
3171         (WebCore::V8GCController::gcEpilogue):
3172         * bindings/v8/V8GCController.h:
3173         * bindings/v8/V8Proxy.cpp:
3174         (WebCore::V8Proxy::evaluate):
3175         (WebCore::V8Proxy::runScript):
3176         (WebCore::V8Proxy::callFunction):
3177
3178 2009-11-05  Adam Barth  <abarth@webkit.org>
3179
3180         Reviewed by Sam Weinig.
3181
3182         Cross-domain access to stylesheet text should not be allowed
3183         https://bugs.webkit.org/show_bug.cgi?id=20527
3184
3185         Check whether whether the current document can read the cssRules from
3186         the style sheet.  Firefox throws a security error here, but we return
3187         null instead because that's what we usually do in these cases.
3188
3189         Test: http/tests/security/cannot-read-cssrules-redirect.html
3190               http/tests/security/cannot-read-cssrules.html
3191
3192         * css/CSSStyleSheet.cpp:
3193         (WebCore::CSSStyleSheet::cssRules):
3194
3195 2009-11-05  Steve Block  <steveblock@google.com>
3196
3197         Reviewed by Eric Seidel.
3198
3199         If the Geolocation service fails to start, invoke the error callback asynchronously.
3200         https://bugs.webkit.org/show_bug.cgi?id=28276
3201
3202         All Geolocation callbacks must be invoked asynchronously.
3203         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3204
3205         No new tests possible with current LayoutTestController.
3206
3207         * page/Geolocation.cpp:
3208         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3209         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3210         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3211
3212 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3213
3214         Reviewed by Eric Seidel.
3215
3216         Removed the "this is part of the KDE project" comments from 
3217         all *.h, *.cpp, *.idl, and *.pm files.
3218         
3219         https://bugs.webkit.org/show_bug.cgi?id=31167
3220         
3221         The maintenance and architecture page in the project wiki lists
3222         this as a task.
3223         
3224         This change includes no changes or additions to test cases 
3225         since the change affects only comments.
3226
3227         * bindings/scripts/CodeGeneratorV8.pm:
3228         * bindings/scripts/IDLParser.pm:
3229         * bindings/scripts/IDLStructure.pm:
3230         * css/CSSInheritedValue.cpp:
3231         * css/CSSInitialValue.cpp:
3232         * css/CSSMediaRule.cpp:
3233         * css/CSSNamespace.h:
3234         * css/CSSProperty.cpp:
3235         * css/CSSProperty.h:
3236         * css/CSSRuleList.cpp:
3237         * css/CSSRuleList.h:
3238         * css/CSSSelector.h:
3239         * css/CSSValueList.cpp:
3240         * css/FontValue.cpp:
3241         * css/MediaFeatureNames.cpp:
3242         * css/MediaFeatureNames.h:
3243         * css/Pair.h:
3244         * css/SVGCSSStyleSelector.cpp:
3245         * css/ShadowValue.cpp:
3246         * css/StyleSheet.cpp:
3247         * css/StyleSheetList.cpp:
3248         * css/maketokenizer:
3249         * dom/BeforeUnloadEvent.cpp:
3250         * dom/BeforeUnloadEvent.h:
3251         * dom/CSSMappedAttributeDeclaration.cpp:
3252         * dom/EventNames.cpp:
3253         * dom/EventTarget.cpp:
3254         * dom/MappedAttributeEntry.h:
3255         * dom/MouseRelatedEvent.h:
3256         * dom/RangeException.h:
3257         * dom/StyleElement.h:
3258         * dom/Tokenizer.h:
3259         * html/HTMLHeadElement.h:
3260         * html/HTMLHeadingElement.cpp:
3261         * html/HTMLHeadingElement.h:
3262         * html/HTMLHtmlElement.h:
3263         * html/HTMLImageLoader.h:
3264         * html/HTMLMetaElement.h:
3265         * html/HTMLModElement.cpp:
3266         * html/HTMLModElement.h:
3267         * html/HTMLOptionsCollection.cpp:
3268         * html/HTMLPlugInElement.cpp:
3269         * html/HTMLPreElement.cpp:
3270         * html/HTMLPreElement.h:
3271         * html/HTMLTableCellElement.cpp:
3272         * html/HTMLTableCellElement.h:
3273         * html/HTMLTableColElement.cpp:
3274         * html/HTMLTableColElement.h:
3275         * html/HTMLTablePartElement.cpp:
3276         * html/HTMLTablePartElement.h:
3277         * html/HTMLTitleElement.h:
3278         * page/MouseEventWithHitTestResults.h:
3279         * platform/StaticConstructors.h:
3280         * platform/text/AtomicStringImpl.h:
3281         * platform/text/qt/TextBreakIteratorQt.cpp:
3282         * rendering/AutoTableLayout.h:
3283         * rendering/CounterNode.cpp:
3284         * rendering/EllipsisBox.cpp:
3285         * rendering/EllipsisBox.h:
3286         * rendering/FixedTableLayout.cpp:
3287         * rendering/FixedTableLayout.h:
3288         * rendering/HitTestRequest.h:
3289         * rendering/HitTestResult.h:
3290         * rendering/InlineRunBox.h:
3291         * rendering/PointerEventsHitRules.cpp:
3292         * rendering/PointerEventsHitRules.h:
3293         * rendering/RenderBR.cpp:
3294         * rendering/RenderBR.h:
3295         * rendering/RenderButton.cpp:
3296         * rendering/RenderButton.h:
3297         * rendering/RenderFieldset.cpp:
3298         * rendering/RenderFrameSet.cpp:
3299         * rendering/RenderListItem.cpp:
3300         * rendering/RenderTableRow.cpp:
3301         * rendering/RenderView.h:
3302         * rendering/RootInlineBox.h:
3303         * rendering/SVGInlineTextBox.cpp:
3304         * rendering/SVGInlineTextBox.h:
3305         * rendering/TableLayout.h:
3306         * rendering/break_lines.h:
3307         * rendering/style/SVGRenderStyle.cpp:
3308         * rendering/style/SVGRenderStyle.h:
3309         * rendering/style/SVGRenderStyleDefs.cpp:
3310         * rendering/style/SVGRenderStyleDefs.h:
3311         * svg/GradientAttributes.h:
3312         * svg/LinearGradientAttributes.h:
3313         * svg/PatternAttributes.h:
3314         * svg/RadialGradientAttributes.h:
3315         * svg/SVGAElement.cpp:
3316         * svg/SVGAngle.idl:
3317         * svg/SVGAnimateColorElement.cpp:
3318         * svg/SVGAnimateColorElement.h:
3319         * svg/SVGAnimateElement.cpp:
3320         * svg/SVGAnimateElement.h:
3321         * svg/SVGAnimateTransformElement.h:
3322         * svg/SVGAnimatedPathData.cpp:
3323         * svg/SVGAnimatedPathData.h:
3324         * svg/SVGAnimatedPoints.cpp:
3325         * svg/SVGAnimatedPoints.h:
3326         * svg/SVGAnimationElement.cpp:
3327         * svg/SVGCircleElement.cpp:
3328         * svg/SVGClipPathElement.cpp:
3329         * svg/SVGColor.cpp:
3330         * svg/SVGColor.idl:
3331         * svg/SVGComponentTransferFunctionElement.cpp:
3332         * svg/SVGComponentTransferFunctionElement.h:
3333         * svg/SVGCursorElement.cpp:
3334         * svg/SVGDefsElement.cpp:
3335         * svg/SVGDescElement.cpp:
3336         * svg/SVGDescElement.h:
3337         * svg/SVGDocument.idl:
3338         * svg/SVGElement.idl:
3339         * svg/SVGElementInstanceList.cpp:
3340         * svg/SVGElementInstanceList.h:
3341         * svg/SVGEllipseElement.cpp:
3342         * svg/SVGExternalResourcesRequired.cpp:
3343         * svg/SVGFEBlendElement.cpp:
3344         * svg/SVGFEBlendElement.h:
3345         * svg/SVGFEColorMatrixElement.cpp:
3346         * svg/SVGFEColorMatrixElement.h:
3347         * svg/SVGFEComponentTransferElement.cpp:
3348         * svg/SVGFEComponentTransferElement.h:
3349         * svg/SVGFECompositeElement.cpp:
3350         * svg/SVGFECompositeElement.h:
3351         * svg/SVGFEFloodElement.cpp:
3352         * svg/SVGFEFloodElement.h:
3353         * svg/SVGFEFuncAElement.cpp:
3354         * svg/SVGFEFuncAElement.h:
3355         * svg/SVGFEFuncBElement.cpp:
3356         * svg/SVGFEFuncBElement.h:
3357         * svg/SVGFEFuncGElement.cpp:
3358         * svg/SVGFEFuncGElement.h:
3359         * svg/SVGFEFuncRElement.cpp:
3360         * svg/SVGFEFuncRElement.h:
3361         * svg/SVGFEGaussianBlurElement.cpp:
3362         * svg/SVGFEGaussianBlurElement.h:
3363         * svg/SVGFEImageElement.cpp:
3364         * svg/SVGFEMergeElement.cpp:
3365         * svg/SVGFEMergeElement.h:
3366         * svg/SVGFEMergeNodeElement.cpp:
3367         * svg/SVGFEOffsetElement.cpp:
3368         * svg/SVGFEOffsetElement.h:
3369         * svg/SVGFETileElement.cpp:
3370         * svg/SVGFETileElement.h:
3371         * svg/SVGFETurbulenceElement.cpp:
3372         * svg/SVGFETurbulenceElement.h:
3373         * svg/SVGFilterElement.cpp:
3374         * svg/SVGGElement.cpp:
3375         * svg/SVGGradientElement.cpp:
3376         * svg/SVGHKernElement.idl:
3377         * svg/SVGLangSpace.cpp:
3378         * svg/SVGLangSpace.h:
3379         * svg/SVGLength.cpp:
3380         * svg/SVGLength.h:
3381         * svg/SVGLength.idl:
3382         * svg/SVGLengthList.cpp:
3383         * svg/SVGLengthList.h:
3384         * svg/SVGLineElement.cpp:
3385         * svg/SVGLinearGradientElement.h:
3386         * svg/SVGList.h:
3387         * svg/SVGListTraits.h:
3388         * svg/SVGLocatable.h:
3389         * svg/SVGMaskElement.cpp:
3390         * svg/SVGMatrix.idl:
3391         * svg/SVGMetadataElement.cpp:
3392         * svg/SVGMetadataElement.h:
3393         * svg/SVGMetadataElement.idl:
3394         * svg/SVGNumber.idl:
3395         * svg/SVGNumberList.cpp:
3396         * svg/SVGNumberList.h:
3397         * svg/SVGPaint.cpp:
3398         * svg/SVGPathElement.cpp:
3399         * svg/SVGPathSeg.h:
3400         * svg/SVGPathSegArc.cpp:
3401         * svg/SVGPathSegArc.h:
3402         * svg/SVGPathSegClosePath.cpp:
3403         * svg/SVGPathSegClosePath.h:
3404         * svg/SVGPathSegCurvetoCubic.cpp:
3405         * svg/SVGPathSegCurvetoCubic.h:
3406         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3407         * svg/SVGPathSegCurvetoCubicSmooth.h:
3408         * svg/SVGPathSegCurvetoQuadratic.cpp:
3409         * svg/SVGPathSegCurvetoQuadratic.h:
3410         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3411         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3412         * svg/SVGPathSegLineto.cpp:
3413         * svg/SVGPathSegLineto.h:
3414         * svg/SVGPathSegLinetoHorizontal.cpp:
3415         * svg/SVGPathSegLinetoHorizontal.h:
3416         * svg/SVGPathSegLinetoVertical.cpp:
3417         * svg/SVGPathSegLinetoVertical.h:
3418         * svg/SVGPathSegMoveto.cpp:
3419         * svg/SVGPathSegMoveto.h:
3420         * svg/SVGPatternElement.cpp:
3421         * svg/SVGPoint.idl:
3422         * svg/SVGPointList.cpp:
3423         * svg/SVGPointList.h:
3424         * svg/SVGPolyElement.cpp:
3425         * svg/SVGPolygonElement.cpp:
3426         * svg/SVGPolygonElement.h:
3427         * svg/SVGPolylineElement.cpp:
3428         * svg/SVGPolylineElement.h:
3429         * svg/SVGPreserveAspectRatio.cpp:
3430         * svg/SVGPreserveAspectRatio.h:
3431         * svg/SVGRadialGradientElement.h:
3432         * svg/SVGRect.idl:
3433         * svg/SVGRectElement.cpp:
3434         * svg/SVGRenderingIntent.h:
3435         * svg/SVGSVGElement.idl:
3436         * svg/SVGScriptElement.cpp:
3437         * svg/SVGSetElement.cpp:
3438         * svg/SVGSetElement.h:
3439         * svg/SVGStopElement.cpp:
3440         * svg/SVGStringList.cpp:
3441         * svg/SVGStringList.h:
3442         * svg/SVGStylable.cpp:
3443         * svg/SVGStylable.h:
3444         * svg/SVGStyleElement.cpp:
3445         * svg/SVGStyleElement.h:
3446         * svg/SVGStyledElement.h:
3447         * svg/SVGStyledLocatableElement.cpp:
3448         * svg/SVGStyledLocatableElement.h:
3449         * svg/SVGStyledTransformableElement.cpp:
3450         * svg/SVGStyledTransformableElement.h:
3451         * svg/SVGSwitchElement.cpp:
3452         * svg/SVGSymbolElement.cpp:
3453         * svg/SVGTRefElement.cpp:
3454         * svg/SVGTSpanElement.cpp:
3455         * svg/SVGTSpanElement.h:
3456         * svg/SVGTests.h:
3457         * svg/SVGTextElement.cpp:
3458         * svg/SVGTextElement.h:
3459         * svg/SVGTextPathElement.cpp:
3460         * svg/SVGTextPositioningElement.cpp:
3461         * svg/SVGTextPositioningElement.h:
3462         * svg/SVGTitleElement.cpp:
3463         * svg/SVGTitleElement.h:
3464         * svg/SVGTransform.cpp:
3465         * svg/SVGTransform.h:
3466         * svg/SVGTransform.idl:
3467         * svg/SVGTransformList.cpp:
3468         * svg/SVGTransformList.h:
3469         * svg/SVGTransformable.h:
3470         * svg/SVGURIReference.h:
3471         * svg/SVGUnitTypes.h:
3472         * svg/SVGUseElement.cpp:
3473         * svg/SVGViewElement.cpp:
3474         * svg/SVGZoomAndPan.cpp:
3475         * svg/SVGZoomAndPan.h:
3476         * svg/SVGZoomEvent.cpp:
3477
3478 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3479
3480         Reviewed by Dimitri Glazkov.
3481
3482         REGRESSION Clean up security origin usage in DOM Storage.
3483         https://bugs.webkit.org/show_bug.cgi?id=31188
3484
3485         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3486         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3487
3488         Instead of having StorageAreaSync's constructor (which is called in the
3489         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3490         database identifier, simply have StorageAreaImpl pass the identifier into
3491         StorageAreaSync.
3492
3493         No test because there's no change in externally observable behavior.
3494
3495         * storage/StorageAreaImpl.cpp:
3496         (WebCore::StorageAreaImpl::StorageAreaImpl):
3497         * storage/StorageAreaImpl.h:
3498         * storage/StorageAreaSync.cpp:
3499         (WebCore::StorageAreaSync::create):
3500         (WebCore::StorageAreaSync::StorageAreaSync):
3501         * storage/StorageAreaSync.h:
3502
3503 2009-11-05  Scott Violet  <sky@google.com>
3504
3505         Reviewed by Dimitri Glazkov.
3506
3507         Need notification of scrolling frame
3508         https://bugs.webkit.org/show_bug.cgi?id=31145
3509
3510         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3511         the frame scrolls. This will be used to know when history state
3512         needs to be updated.
3513
3514         * loader/FrameLoaderClient.h:
3515         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3516         * page/FrameView.cpp:
3517         (WebCore::FrameView::valueChanged):
3518
3519 2009-11-05  Kenneth Russell  <kbr@google.com>
3520
3521         Reviewed by Dimitri Glazkov.
3522
3523         [V8] Update bindings to use new API for external arrays
3524         https://bugs.webkit.org/show_bug.cgi?id=31181
3525
3526         No new tests; covered by existing WebGL tests.
3527
3528         * bindings/v8/V8DOMWrapper.cpp:
3529         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3530         (WebCore::V8DOMWrapper::getTemplate):
3531         (WebCore::V8DOMWrapper::convertToV8Object):
3532         * bindings/v8/V8DOMWrapper.h:
3533         * bindings/v8/custom/V8CanvasArrayCustom.h:
3534         (WebCore::constructCanvasArray):
3535
3536 2009-11-05  Alpha Lam  <hclam@chromium.org>
3537
3538         Not reviewed, Chromium build fix.
3539
3540         50561 introduces a custom method for SVGMatrix, we need to implement
3541         this in V8.
3542
3543         * bindings/v8/custom/V8CustomBinding.h:
3544         Adding definition for V8SVGMatrixMultiply.
3545         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3546         (WebCore::CALLBACK_FUNC_DECL):
3547         Implement V8SVGMatrixMultiply according to the same method in JSC.
3548
3549 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3550
3551         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3552
3553         * page/DOMWindow.cpp:
3554         (WebCore::DOMWindow::sessionStorage):
3555         * page/Settings.cpp:
3556         (WebCore::Settings::Settings):
3557         (WebCore::Settings::setSessionStorageEnabled):
3558         * page/Settings.h:
3559         (WebCore::Settings::sessionStorageEnabled):
3560
3561 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3562
3563         Reviewed by Timothy Hatcher.
3564
3565         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3566
3567         https://bugs.webkit.org/show_bug.cgi?id=30884
3568
3569         Test: inspector/styles-iframe.html
3570
3571         * inspector/front-end/DOMAgent.js:
3572         (WebInspector.DOMNode):
3573         * inspector/front-end/InjectedScript.js:
3574         (InjectedScript.getStyles):
3575         (InjectedScript.getComputedStyle):
3576         (InjectedScript.addStyleSelector):
3577         * inspector/front-end/TestController.js:
3578         (WebInspector.TestController.prototype.notifyDone):
3579         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3580         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3581         (WebInspector.evaluateForTestInFrontend):
3582
3583 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3584
3585         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3586
3587         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3588         https://bugs.webkit.org/show_bug.cgi?id=31027
3589
3590         Tested by new fast/events/event-listener-map-rehash-crash.html.
3591
3592         EventListenerMap modified to store pointers to listener vectors:
3593         * dom/EventTarget.cpp:
3594         (WebCore::EventTargetData::~EventTargetData):
3595         (WebCore::EventTarget::addEventListener):
3596         (WebCore::EventTarget::removeEventListener):
3597         (WebCore::EventTarget::fireEventListeners):
3598         (WebCore::EventTarget::getEventListeners):
3599         (WebCore::EventTarget::removeAllEventListeners):
3600         * dom/EventTarget.h:
3601
3602         Usages updated after interface changes:
3603         * inspector/InspectorDOMAgent.cpp:
3604         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3605         * svg/SVGUseElement.cpp:
3606         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3607
3608 2009-11-05  Dan Kegel  <dank@chromium.org>
3609
3610         Reviewed by Dmitri Titov.
3611
3612         Add missing initialization for m_createdByParser.
3613         https://bugs.webkit.org/show_bug.cgi?id=31089
3614
3615         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3616
3617         * dom/ProcessingInstruction.cpp:
3618         (WebCore::ProcessingInstruction::ProcessingInstruction):
3619
3620 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3621
3622         Reviewed by Adam Barth.
3623
3624         DOM Storage runtime flag changes
3625         https://bugs.webkit.org/show_bug.cgi?id=30602
3626
3627         Part 2/2.
3628
3629         Revert my changes to Settings and instead implement DOM Storage enabling via
3630         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3631
3632         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3633         LayoutTest visible changes and thus no tests.
3634
3635         * bindings/v8/custom/V8CustomBinding.h:
3636         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3637         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3638         * page/DOMWindow.cpp:
3639         (WebCore::DOMWindow::sessionStorage):
3640         * page/DOMWindow.idl:
3641         * page/Settings.cpp:
3642         (WebCore::Settings::Settings):
3643