2006-10-31 Mark Rowe <bdash@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-31  Beth Dakin  <bdakin@apple.com>
2
3         Reviewed by Maciej.
4
5         This adds the back-end of the remaining WebElementDictionary 
6         functions into HitTestResult.
7
8         * WebCore.exp:
9         * rendering/HitTestResult.cpp:
10         (WebCore::HitTestResult::title):
11         (WebCore::displayString): This is nearly identical to the 
12         displayString() defined in DOMInternal.mm except that it returns a 
13         String instead of an NSString. The old code path used the 
14         DOMInternal method, so I made a new one here for the new code path.
15         (WebCore::HitTestResult::altDisplayString):
16         (WebCore::HitTestResult::image):
17         (WebCore::HitTestResult::absoluteImageURL):
18         (WebCore::HitTestResult::absoluteLinkURL):
19         (WebCore::HitTestResult::titleDisplayString):
20         (WebCore::HitTestResult::textContent):
21         * rendering/HitTestResult.h:
22
23 2006-10-31  John Sullivan  <sullivan@apple.com>
24
25         * bridge/mac/FrameMac.mm:
26         (WebCore::FrameMac::markMisspellings):
27         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
28
29 2006-10-31  John Sullivan  <sullivan@apple.com>
30
31         Reviewed by Maciej
32         
33         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
34         
35         The foundation of this was in my last checkin. This checkin is all about displaying
36         the correct string in the toolTip.
37
38         * dom/DocumentMarker.h:
39         New description field in this struct.
40
41         * bridge/mac/FrameMac.mm:
42         (WebCore::FrameMac::advanceToNextMisspelling):
43         When adding a grammar marker, supply the appropriate description. Also, added a comment
44         about the remaining work to make grammar checking return sensible answers.
45         (WebCore::FrameMac::markMisspellings):
46         ditto (yes, still needs some refactoring to minimize duplicated code)
47         
48         * dom/Document.h:
49         * dom/Document.cpp:
50         (WebCore::Document::addMarker):
51         Now takes an optional description string
52         (WebCore::Document::markerContainingPoint):
53         New function, returns a pointer to the (first) marker of the specified type whose rect 
54         contains the specified point, or 0 if none.
55         
56         * rendering/HitTestResult.cpp:
57         (WebCore::HitTestResult::spellingToolTip):
58         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
59         and gets the description from the marker.
60
61 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
62
63         Reviewed by Maciej.
64         
65         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
66
67         * loader/mac/FrameLoaderMac.mm:
68         (WebCore::FrameLoader::createWindow):
69         * manual-tests/window-open-features-parsing.html: Updated for clarity.
70
71 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
72
73         Reviewed by Alice.
74
75         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
76         to WebCore::Editor.
77         
78         Layout tests pass.
79         
80         Renamed "may*" to "can*" because "can" is more accurate (these functions
81         aren't just about permission) and it matches WebKit.
82
83         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
84         password field. Now that WebCore fully implements canCopy(), it doesn't just
85         mean "the selection is not in a password field" anymore.
86         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
87         The fact that it's not called anymore may represent a security issue, but I
88         don't see how commented-out code will help reveal the issue, and the
89         bridge is going away, anyway.
90         * editing/SelectionController.h: Changed selection() calls to references
91         to m_sel, to match the rest of the file.
92
93 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
94
95         Reviewed by harrison
96         
97         <rdar://problem/4711063>
98         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
99
100         * editing/ReplaceSelectionCommand.cpp:
101         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
102         insertion and plain text string creation unless we need the string
103         for a BeforeTextInserted event handler or for a plain text only region.
104         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
105         code here from ReplacementFragment's constructor.
106         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
107         FIXME.
108         * editing/ReplaceSelectionCommand.h:
109
110 2006-10-31  Ada Chan  <adachan@apple.com>
111
112         Reviewed by Adam
113
114         Correct forward declarations of the HitTestRequest struct.
115
116         * rendering/EllipsisBox.h:
117         * rendering/InlineBox.h:
118         * rendering/InlineFlowBox.h:
119         * rendering/RenderLayer.h:
120         * rendering/RenderObject.h:
121
122 2006-10-31  John Sullivan  <sullivan@apple.com>
123
124         Reviewed by Beth and Adam
125
126         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
127         next I'll make it use a string that's relevant for a specific grammar error.
128
129         * WebCore.exp:
130         export symbol for spellingToolTip function
131         
132         * rendering/HitTestResult.h:
133         * rendering/HitTestResult.cpp:
134         (WebCore::HitTestResult::spellingToolTip):
135         new function, returns the string to be used in a tool tip that describes the questionable grammar
136         
137         * rendering/InlineTextBox.h:
138         * rendering/InlineTextBox.cpp:
139         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
140         now takes a style and font, needed to compute the rect representing the range containing
141         questionable grammar. Computes the rect and associates it with the marker.
142         (WebCore::InlineTextBox::paintDocumentMarkers):
143         Pass in the style and font now needed by paintSpellingOrGrammarMarker
144
145 2006-10-31  Adele Peterson  <adele@apple.com>
146
147         Removed commented out variable from last checkin.
148
149         * html/HTMLSelectElement.cpp:
150         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
151
152 2006-10-31  Brady Eidson  <beidson@apple.com>
153
154         Build fix (unused variable in release builds)
155
156         * html/HTMLSelectElement.cpp:
157         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
158
159 2006-10-31  Adele Peterson  <adele@apple.com>
160
161         Reviewed by Adam.
162
163         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
164         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
165         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
166
167         Tests: 
168         * LayoutTests/fast/forms/listbox-selection.html
169         * LayoutTests/fast/forms/listbox-onchange.html
170
171         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
172           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
173           And one for onChange, that is updated after onChange is fired.
174           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
175  
176         * html/HTMLSelectElement.cpp:
177         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
178         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
179         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
180         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
181         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
182         (WebCore::HTMLSelectElement::setExtent): Added.
183         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
184         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
185
186         * rendering/RenderListBox.cpp:
187         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
188         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
189         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
190         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
191          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
192          notify the select element from here.
193         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
194         (WebCore::RenderListBox::listIndexIsVisible): Added.
195         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
196
197         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
198         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
199         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
200         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
201         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
202
203 2006-10-31  Beth Dakin  <bdakin@apple.com>
204
205         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
206
207         * rendering/HitTestRequest.h: Added.
208         (WebCore::HitTestRequest::HitTestRequest):
209
210 2006-10-31  Beth Dakin  <bdakin@apple.com>
211
212         Reviewed by Maciej.
213
214         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
215         should be split into HitTestRequest and HitTestResult
216
217         This patch creates a new struct called HitTestRequest that holds 
218         the three boolean values (readonly, active, and mouseMove) that 
219         were formerly a part of HitTestResult. All hitTest() and 
220         nodeAtPoint() functions now take a HitTestRequest in addition to 
221         the HitTestResult.
222
223         * WebCore.exp:
224         * WebCore.xcodeproj/project.pbxproj:
225         * bridge/mac/FrameMac.mm:
226         (WebCore::FrameMac::eventMayStartDrag):
227         (WebCore::FrameMac::handleMouseMoveEvent):
228         * bridge/mac/WebCoreAXObject.mm:
229         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
230         (-[WebCoreAXObject accessibilityHitTest:]):
231         * dom/Document.cpp:
232         (WebCore::Document::elementFromPoint):
233         (WebCore::Document::prepareMouseEvent):
234         * editing/SelectionController.cpp:
235         (WebCore::SelectionController::contains):
236         * page/Frame.cpp:
237         (WebCore::Frame::hitTestResultAtPoint):
238         * page/FrameView.cpp:
239         (WebCore::FrameView::handleWheelEvent):
240         * rendering/EllipsisBox.cpp:
241         (WebCore::EllipsisBox::nodeAtPoint):
242         * rendering/EllipsisBox.h:
243         * rendering/HitTestResult.cpp:
244         (WebCore::HitTestResult::HitTestResult):
245         (WebCore::HitTestResult::operator=):
246         * rendering/HitTestResult.h:
247         * rendering/InlineBox.cpp:
248         (WebCore::InlineBox::nodeAtPoint):
249         * rendering/InlineBox.h:
250         * rendering/InlineFlowBox.cpp:
251         (WebCore::InlineFlowBox::nodeAtPoint):
252         * rendering/InlineFlowBox.h:
253         * rendering/InlineTextBox.cpp:
254         (WebCore::InlineTextBox::nodeAtPoint):
255         * rendering/InlineTextBox.h:
256         * rendering/RenderBlock.cpp:
257         (WebCore::RenderBlock::nodeAtPoint):
258         * rendering/RenderBlock.h:
259         * rendering/RenderBox.cpp:
260         (WebCore::RenderBox::nodeAtPoint):
261         * rendering/RenderBox.h:
262         * rendering/RenderFlow.cpp:
263         (WebCore::RenderFlow::hitTestLines):
264         * rendering/RenderFlow.h:
265         * rendering/RenderForeignObject.cpp:
266         (WebCore::RenderForeignObject::nodeAtPoint):
267         * rendering/RenderForeignObject.h:
268         * rendering/RenderFrameSet.cpp:
269         (WebCore::RenderFrameSet::nodeAtPoint):
270         * rendering/RenderFrameSet.h:
271         * rendering/RenderImage.cpp:
272         (WebCore::RenderImage::nodeAtPoint):
273         * rendering/RenderImage.h:
274         * rendering/RenderInline.cpp:
275         (WebCore::RenderInline::nodeAtPoint):
276         * rendering/RenderInline.h:
277         * rendering/RenderLayer.cpp:
278         (WebCore::RenderLayer::autoscroll):
279         (WebCore::RenderLayer::hitTest):
280         (WebCore::RenderLayer::hitTestLayer):
281         (WebCore::RenderLayer::updateHoverActiveState):
282         * rendering/RenderLayer.h:
283         * rendering/RenderObject.cpp:
284         (WebCore::RenderObject::hitTest):
285         (WebCore::RenderObject::nodeAtPoint):
286         * rendering/RenderObject.h:
287         * rendering/RenderPath.cpp:
288         (WebCore::RenderPath::nodeAtPoint):
289         * rendering/RenderPath.h:
290         * rendering/RenderSVGImage.cpp:
291         (WebCore::RenderSVGImage::nodeAtPoint):
292         * rendering/RenderSVGImage.h:
293         * rendering/RenderSVGText.cpp:
294         (WebCore::RenderSVGText::nodeAtPoint):
295         * rendering/RenderSVGText.h:
296         * rendering/RenderTableRow.cpp:
297         (WebCore::RenderTableRow::nodeAtPoint):
298         * rendering/RenderTableRow.h:
299         * rendering/RenderTableSection.cpp:
300         (WebCore::RenderTableSection::nodeAtPoint):
301         * rendering/RenderTableSection.h:
302         * rendering/RenderText.h:
303         (WebCore::RenderText::nodeAtPoint):
304         * rendering/RenderTextControl.cpp:
305         (WebCore::RenderTextControl::nodeAtPoint):
306         * rendering/RenderTextControl.h:
307         * rendering/RootInlineBox.cpp:
308         (WebCore::RootInlineBox::nodeAtPoint):
309         * rendering/RootInlineBox.h:
310
311 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
312
313         Reviewed by Maciej.
314
315         Bug 11442: [CSS 3] support for cursor: all-scroll
316         http://bugs.webkit.org/show_bug.cgi?id=11442
317
318         * css/CSSComputedStyleDeclaration.cpp:
319         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
320         * css/CSSValueKeywords.in:
321         * css/cssparser.cpp:
322         (WebCore::CSSParser::parseValue):
323         * page/FrameView.cpp:
324         (WebCore::selectCursor):
325         * rendering/RenderStyle.h:
326
327 2006-10-31  Oliver Hunt  <oliver@apple.com>
328
329         Reviewed by Geoff.
330
331         Converting Obj-C++ to C++ in kcanvas
332
333         * WebCore.xcodeproj/project.pbxproj:
334         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
335         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
336         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
337         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
338         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
339         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
340         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
341         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
342         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
343         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
344         * kcanvas/device/quartz/QuartzSupport.h:
345         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
346         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
347         (WebCore::SVGResourceClipper::applyClip):
348         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
349         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
350         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
351
352 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
353
354         Reviewed by harrison
355         
356         <rdar://problem/4808375>
357         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
358         
359         Completely back out r17276 because of performance issues.
360
361         * editing/TextIterator.cpp:
362         (WebCore::TextIterator::TextIterator):
363         (WebCore::TextIterator::advance):
364         (WebCore::TextIterator::handleTextNode):
365         (WebCore::TextIterator::handleTextBox):
366         (WebCore::TextIterator::handleReplacedElement):
367         (WebCore::TextIterator::handleNonTextNode):
368         (WebCore::TextIterator::exitNode):
369         (WebCore::TextIterator::emitCharacter):
370         (WebCore::TextIterator::range):
371         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
372         (WebCore::SimplifiedBackwardsTextIterator::advance):
373         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
374         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
375         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
376         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
377         (WebCore::SimplifiedBackwardsTextIterator::range):
378         (WebCore::CharacterIterator::range):
379         (WebCore::TextIterator::rangeFromLocationAndLength):
380         * editing/TextIterator.h:
381         (WebCore::TextIterator::atEnd):
382         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
383
384 2006-10-31  Darin Adler  <darin@apple.com>
385
386         Reviewed by Brady.
387
388         - got "action dictionary" code out of FrameLoader,
389           replacing with a class called NavigationAction
390
391         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
392         * loader/mac/DocumentLoaderMac.mm:
393         (WebCore::DocumentLoader::triggeringAction): Ditto.
394         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
395
396         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
397
398         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
399         Removed elementForEvent.
400         * loader/mac/FrameLoaderMac.mm:
401         (WebCore::FrameLoader::load): Ditto.
402         (WebCore::FrameLoader::reload): Ditto.
403         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
404         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
405         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
406         (WebCore::FrameLoader::post): Ditto.
407
408         * loader/NavigationAction.h: Added.
409         * loader/NavigationAction.cpp: Added.
410         * loader/mac/NavigationActionMac.mm: Added.
411
412         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
413
414         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
415         * WebCore.exp: Updated.
416
417 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
418
419         Reviewed by Adam.
420
421         Build fix
422
423         * platform/win/CookieJarWin.cpp:
424         (WebCore::cookies):
425
426 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
427
428         Reviewed by Maciej. Landed by Adam.
429
430         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
431
432         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
433         as dicussed with Dave. Also kill the outdated DESIGN document.
434
435         * CMakeLists.txt:
436         * WebCore.xcodeproj/project.pbxproj:
437         * kcanvas/DESIGN: Removed.
438         * kcanvas/KCanvasFilters.cpp:
439         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
440         * kcanvas/KCanvasTreeDebug.h: Ditto.
441         * kcanvas/device/KRenderingPaintServerGradient.cpp:
442         * kcanvas/device/KRenderingPaintServerPattern.cpp:
443         * kcanvas/device/KRenderingPaintServerSolid.cpp:
444         * platform/graphics/svg/SVGResourceClipper.cpp:
445         * rendering/RenderTreeAsText.cpp:
446         * rendering/SVGRenderTreeAsText.cpp: Added.
447         * rendering/SVGRenderTreeAsText.h: Added.
448         (WebCore::operator<<):
449
450 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
451
452         Reviewed by Maciej.
453
454         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
455         Includes some CRLF -> LF fixups.
456
457         * platform/win/CookieJarWin.cpp:
458         (WebCore::cookies):
459
460 2006-10-31  Adam Roben  <aroben@apple.com>
461
462         Reviewed by Steve.
463
464         Fix some incorrect forward declarations.
465
466         * loader/FrameLoader.h:
467         * page/Frame.h:
468
469 2006-10-31  Darin Adler  <darin@apple.com>
470
471         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
472         try to fix the build on the buildbot.
473
474 2006-10-31  Darin Adler  <darin@apple.com>
475
476         * bridge/mac/FrameMac.mm:
477         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
478         (WebCore::FrameMac::markMisspellings): Ditto.
479
480 2006-10-31  John Sullivan  <sullivan@apple.com>
481
482         * bridge/mac/FrameMac.mm:
483         (WebCore::FrameMac::advanceToNextMisspelling):
484         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
485
486 2006-10-30  John Sullivan  <sullivan@apple.com>
487
488         Reviewed by Adam Roben
489         
490         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
491         
492         This patch introduces much of the guts of grammar checking, though still not enough to actually
493         check grammar sensibly, due to:
494           
495         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
496         context passed to grammar checker
497
498         * platform/Logging.h:
499         * platform/Logging.cpp:
500         new log channel SpellingAndGrammar
501
502         * bridge/mac/WebCorePageBridge.mm:
503         (initializeLoggingChannelsIfNecessary):
504         initialize new log channel
505
506         * bridge/mac/FrameMac.mm:
507         (WebCore::FrameMac::advanceToNextMisspelling):
508         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
509         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
510         in the event of a tie), and do further processing with that one (select range; create marker that
511         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
512         (WebCore::FrameMac::markMisspellings):
513         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
514         differently enough to make sharing code between these two functions a little tricky, so I decided to 
515         save that for a later patch.
516         
517         (WebCore::FrameMac::respondToChangedSelection):
518         remove grammar markers when we remove spelling markers        
519
520 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
521
522         Reviewed by Mitz.
523
524         Fix Qt/Linux build with older gcc3.3.4.
525
526         * bindings/js/kjs_window.cpp:
527         (KJS::WindowFunc::callAsFunction):
528
529 2006-10-31  Zack Rusin  <zack@kde.org>
530
531         Reviewed by Mitz.
532
533         Fix the Qt build after last nights changes.
534
535         * WebCore/platform/qt/FrameQt.cpp:
536         * WebCore/platform/qt/EditorClientQt.h:
537         * WebCore/platform/qt/EditorClientQt.cpp:
538         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
539         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
540         * WebCore/CMakeLists.txt:
541         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
542         * WebKitQt/QtLauncher/CMakeLists.txt:
543         * WebKitQt/WebKitPart/CMakeLists.txt:
544
545 2006-10-30  Darin Adler  <darin@apple.com>
546
547         Reviewed by Anders.
548
549         - remove BrowserExtension
550
551         * WebCore.vcproj/WebCore/WebCore.vcproj:
552         * WebCore.xcodeproj/project.pbxproj:
553         * bindings/js/kjs_window.cpp:
554         (KJS::createNewWindow):
555         (KJS::WindowFunc::callAsFunction):
556         * bridge/BrowserExtension.h: Removed.
557         * bridge/mac/BrowserExtensionMac.h: Removed.
558         * bridge/mac/BrowserExtensionMac.mm: Removed.
559         * bridge/mac/FrameMac.mm:
560         (WebCore::FrameMac::FrameMac):
561         (WebCore::FrameMac::submitForm):
562         (WebCore::FrameMac::urlSelected):
563         * bridge/win/BrowserExtensionWin.cpp: Removed.
564         * bridge/win/BrowserExtensionWin.h: Removed.
565         * bridge/win/FrameWin.cpp:
566         (WebCore::FrameWin::FrameWin):
567         * loader/FrameLoader.cpp:
568         (WebCore::FrameLoader::createWindow):
569         * loader/FrameLoader.h:
570         * loader/icon/IconLoader.cpp:
571         * loader/mac/FrameLoaderMac.mm:
572         (WebCore::FrameLoader::safeLoad):
573         (WebCore::FrameLoader::load):
574         (WebCore::FrameLoader::createWindow):
575         * page/Frame.cpp:
576         (WebCore::Frame::urlSelected):
577         (WebCore::Frame::requestFrame):
578         (WebCore::Frame::submitForm):
579         (WebCore::Frame::scheduleHistoryNavigation):
580         (WebCore::Frame::redirectionTimerFired):
581         * page/Frame.h:
582         * page/FrameLoadRequest.h:
583         (WebCore::FrameLoadRequest::FrameLoadRequest):
584         (WebCore::FrameLoadRequest::isEmpty):
585         (WebCore::FrameLoadRequest::resourceRequest):
586         (WebCore::FrameLoadRequest::frameName):
587         (WebCore::FrameLoadRequest::setFrameName):
588         * page/FramePrivate.h:
589         (WebCore::FramePrivate::FramePrivate):
590         (WebCore::FramePrivate::~FramePrivate):
591         * platform/gdk/BrowserExtensionGdk.h: Removed.
592         * platform/gdk/FrameGdk.cpp:
593         (WebCore::FrameGdk::FrameGdk):
594         * platform/gdk/TemporaryLinkStubs.cpp:
595         * platform/network/ResourceRequest.h:
596         (WebCore::ResourceRequest::isEmpty):
597
598 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
599
600         Reviewed by Oliver.
601
602         Modified from original due to earlier reversion
603
604         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
605
606         Better SVG integration in WebKit, Part I.
607
608         The patch is mostly about creating a new platform/graphics directory, and
609         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
610         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
611         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
612
613         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
614         All details of the patch, and upcoming patches can be found in the bug report.
615
616         * CMakeLists.txt:
617         * WebCore.xcodeproj/project.pbxproj:
618         * graphics/svg/SVGResource.cpp: Removed.
619         * graphics/svg/SVGResourceClipper.cpp: Removed.
620         * graphics/svg/SVGResourceClipper.h: Removed.
621         * graphics/svg/SVGResourceImage.h: Removed.
622         * graphics/svg/SVGResourceListener.h: Removed.
623         * graphics/svg/SVGResourceMarker.cpp: Removed.
624         * graphics/svg/SVGResourceMarker.h: Removed.
625         * graphics/svg/SVGResourceMasker.cpp: Removed.
626         * graphics/svg/SVGResourceMasker.h: Removed.
627         * kcanvas/KCanvasClipper.cpp: Removed.
628         * kcanvas/KCanvasClipper.h: Removed.
629         * kcanvas/KCanvasCreator.cpp: Removed.
630         * kcanvas/KCanvasCreator.h: Removed.
631         * kcanvas/KCanvasFilters.cpp:
632         (WebCore::getFilterById):
633         * kcanvas/KCanvasFilters.h:
634         * kcanvas/KCanvasImage.h: Removed.
635         * kcanvas/KCanvasMarker.cpp: Removed.
636         * kcanvas/KCanvasMarker.h: Removed.
637         * kcanvas/KCanvasMasker.cpp: Removed.
638         * kcanvas/KCanvasMasker.h: Removed.
639         * kcanvas/KCanvasResource.cpp: Removed.
640         * kcanvas/KCanvasResource.h: Removed.
641         * kcanvas/KCanvasResourceListener.h: Removed.
642         * kcanvas/KCanvasTreeDebug.cpp:
643         (WebCore::writeRenderResources):
644         * kcanvas/device/KRenderingDevice.h:
645         * kcanvas/device/KRenderingPaintServer.h:
646         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
647         * kcanvas/device/KRenderingPaintServerGradient.cpp:
648         (WebCore::KRenderingPaintServerGradient::listener):
649         (WebCore::KRenderingPaintServerGradient::setListener):
650         * kcanvas/device/KRenderingPaintServerGradient.h:
651         * kcanvas/device/KRenderingPaintServerPattern.cpp:
652         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
653         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
654         (WebCore::KRenderingPaintServerPattern::tile):
655         (WebCore::KRenderingPaintServerPattern::setTile):
656         (WebCore::KRenderingPaintServerPattern::listener):
657         (WebCore::KRenderingPaintServerPattern::setListener):
658         * kcanvas/device/KRenderingPaintServerPattern.h:
659         * kcanvas/device/KRenderingPaintServerSolid.h:
660         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
661         * kcanvas/device/qt/KCanvasClipperQt.h:
662         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
663         (WebCore::KRenderingDeviceQt::contextForImage):
664         (WebCore::KRenderingDeviceQt::createResource):
665         (WebCore::KRenderingDeviceQt::createPaintServer):
666         * kcanvas/device/qt/KRenderingDeviceQt.h:
667         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
668         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
669         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
670         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
671         * kcanvas/device/qt/RenderPathQt.h: Removed.
672         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
673         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
674         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
675         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
676         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
677         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
678         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
679         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
680         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
681         (WebCore::KRenderingDeviceQuartz::contextForImage):
682         (WebCore::KRenderingDeviceQuartz::createPaintServer):
683         (WebCore::KRenderingDeviceQuartz::createResource):
684         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
685         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
686         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
687         (WebCore::KRenderingPaintServerGradientQuartz::setup):
688         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
689         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
690         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
691         (WebCore::patternCallback):
692         (WebCore::KRenderingPaintServerPatternQuartz::setup):
693         * kcanvas/device/quartz/QuartzSupport.mm:
694         * ksvg2/misc/KCanvasRenderingStyle.cpp:
695         (WebCore::sharedSolidPaintServer):
696         * ksvg2/svg/SVGClipPathElement.cpp:
697         (WebCore::SVGClipPathElement::SVGClipPathElement):
698         (WebCore::SVGClipPathElement::~SVGClipPathElement):
699         (WebCore::SVGClipPathElement::canvasResource):
700         * ksvg2/svg/SVGClipPathElement.h:
701         * ksvg2/svg/SVGFEImageElement.cpp:
702         * ksvg2/svg/SVGFilterElement.cpp:
703         (WebCore::SVGFilterElement::SVGFilterElement):
704         (WebCore::SVGFilterElement::~SVGFilterElement):
705         (WebCore::SVGFilterElement::canvasResource):
706         * ksvg2/svg/SVGFilterElement.h:
707         * ksvg2/svg/SVGGradientElement.cpp:
708         (WebCore::SVGGradientElement::SVGGradientElement):
709         (WebCore::SVGGradientElement::~SVGGradientElement):
710         (WebCore::SVGGradientElement::canvasResource):
711         (WebCore::SVGGradientElement::resourceNotification):
712         * ksvg2/svg/SVGGradientElement.h:
713         * ksvg2/svg/SVGImageElement.cpp:
714         * ksvg2/svg/SVGLinearGradientElement.cpp:
715         (WebCore::SVGLinearGradientElement::buildGradient):
716         * ksvg2/svg/SVGLinearGradientElement.h:
717         * ksvg2/svg/SVGMarkerElement.cpp:
718         (WebCore::SVGMarkerElement::SVGMarkerElement):
719         (WebCore::SVGMarkerElement::~SVGMarkerElement):
720         (WebCore::SVGMarkerElement::canvasResource):
721         * ksvg2/svg/SVGMarkerElement.h:
722         * ksvg2/svg/SVGMaskElement.cpp:
723         (WebCore::SVGMaskElement::SVGMaskElement):
724         (WebCore::SVGMaskElement::~SVGMaskElement):
725         (WebCore::SVGMaskElement::drawMaskerContent):
726         (WebCore::SVGMaskElement::canvasResource):
727         * ksvg2/svg/SVGMaskElement.h:
728         * ksvg2/svg/SVGPatternElement.cpp:
729         (WebCore::SVGPatternElement::SVGPatternElement):
730         (WebCore::SVGPatternElement::~SVGPatternElement):
731         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
732         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
733         (WebCore::SVGPatternElement::canvasResource):
734         * ksvg2/svg/SVGPatternElement.h:
735         * ksvg2/svg/SVGRadialGradientElement.cpp:
736         (WebCore::SVGRadialGradientElement::buildGradient):
737         * ksvg2/svg/SVGRadialGradientElement.h:
738         * ksvg2/svg/SVGStyledElement.h:
739         (WebCore::SVGStyledElement::canvasResource):
740         * platform/GraphicsContext.cpp: Removed.
741         * platform/GraphicsContext.h: Removed.
742         * platform/GraphicsTypes.cpp: Removed.
743         * platform/GraphicsTypes.h: Removed.
744         * platform/graphics/GraphicsContext.cpp:
745         (WebCore::GraphicsContextState::GraphicsContextState):
746         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
747         (WebCore::GraphicsContext::createGraphicsContextPrivate):
748         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
749         (WebCore::GraphicsContext::save):
750         (WebCore::GraphicsContext::restore):
751         (WebCore::GraphicsContext::font):
752         (WebCore::GraphicsContext::setFont):
753         (WebCore::GraphicsContext::pen):
754         (WebCore::GraphicsContext::setPen):
755         (WebCore::GraphicsContext::setFillColor):
756         (WebCore::GraphicsContext::fillColor):
757         (WebCore::GraphicsContext::updatingControlTints):
758         (WebCore::GraphicsContext::setUpdatingControlTints):
759         (WebCore::GraphicsContext::setPaintingDisabled):
760         (WebCore::GraphicsContext::paintingDisabled):
761         (WebCore::GraphicsContext::drawImage):
762         (WebCore::GraphicsContext::drawText):
763         (WebCore::GraphicsContext::drawHighlightForText):
764         (WebCore::GraphicsContext::initFocusRing):
765         (WebCore::GraphicsContext::clearFocusRing):
766         (WebCore::GraphicsContext::focusRingBoundingRect):
767         (WebCore::GraphicsContext::addFocusRingRect):
768         (WebCore::GraphicsContext::focusRingWidth):
769         (WebCore::GraphicsContext::focusRingOffset):
770         (WebCore::GraphicsContext::focusRingRects):
771         (WebCore::GraphicsContext::drawTiledImage):
772         * platform/graphics/GraphicsContext.h:
773         * platform/graphics/GraphicsTypes.cpp:
774         (WebCore::):
775         (WebCore::parseCompositeOperator):
776         (WebCore::compositeOperatorName):
777         (WebCore::parseLineCap):
778         (WebCore::lineCapName):
779         (WebCore::parseLineJoin):
780         (WebCore::lineJoinName):
781         * platform/graphics/GraphicsTypes.h:
782         (WebCore::):
783         * platform/graphics/svg/SVGResource.cpp: Added.
784         (WebCore::SVGResource::SVGResource):
785         (WebCore::SVGResource::~SVGResource):
786         (WebCore::SVGResource::invalidate):
787         (WebCore::SVGResource::addClient):
788         (WebCore::SVGResource::clients):
789         (WebCore::SVGResource::idInRegistry):
790         (WebCore::SVGResource::setIdInRegistry):
791         (WebCore::SVGResource::externalRepresentation):
792         (WebCore::getResourceById):
793         (WebCore::getPaintServerById):
794         (WebCore::operator<<):
795         * platform/graphics/svg/SVGResource.h: Added.
796         (WebCore::):
797         (WebCore::SVGResource::isPaintServer):
798         (WebCore::SVGResource::isFilter):
799         (WebCore::SVGResource::isClipper):
800         (WebCore::SVGResource::isMarker):
801         (WebCore::SVGResource::isMasker):
802         (WebCore::SVGResourceListener::~SVGResourceListener):
803         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
804         (WebCore::SVGResourceClipper::SVGResourceClipper):
805         (WebCore::SVGResourceClipper::~SVGResourceClipper):
806         (WebCore::SVGResourceClipper::resetClipData):
807         (WebCore::SVGResourceClipper::addClipData):
808         (WebCore::SVGResourceClipper::clipData):
809         (WebCore::SVGResourceClipper::externalRepresentation):
810         (WebCore::operator<<):
811         (WebCore::getClipperById):
812         * platform/graphics/svg/SVGResourceClipper.h: Added.
813         (WebCore::ClipDataList::addPath):
814         (WebCore::SVGResourceClipper::isClipper):
815         * platform/graphics/svg/SVGResourceImage.h: Added.
816         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
817         (WebCore::SVGResourceMarker::SVGResourceMarker):
818         (WebCore::SVGResourceMarker::~SVGResourceMarker):
819         (WebCore::SVGResourceMarker::setMarker):
820         (WebCore::SVGResourceMarker::setRef):
821         (WebCore::SVGResourceMarker::draw):
822         (WebCore::SVGResourceMarker::externalRepresentation):
823         (WebCore::getMarkerById):
824         * platform/graphics/svg/SVGResourceMarker.h: Added.
825         (WebCore::SVGResourceMarker::refX):
826         (WebCore::SVGResourceMarker::refY):
827         (WebCore::SVGResourceMarker::setAngle):
828         (WebCore::SVGResourceMarker::setAutoAngle):
829         (WebCore::SVGResourceMarker::angle):
830         (WebCore::SVGResourceMarker::setUseStrokeWidth):
831         (WebCore::SVGResourceMarker::useStrokeWidth):
832         (WebCore::SVGResourceMarker::isMarker):
833         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
834         (WebCore::SVGResourceMasker::SVGResourceMasker):
835         (WebCore::SVGResourceMasker::~SVGResourceMasker):
836         (WebCore::SVGResourceMasker::setMask):
837         (WebCore::SVGResourceMasker::mask):
838         (WebCore::SVGResourceMasker::externalRepresentation):
839         (WebCore::getMaskerById):
840         * platform/graphics/svg/SVGResourceMasker.h: Added.
841         (WebCore::SVGResourceMasker::isMasker):
842         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
843         (WebCore::SVGResourceClipper::applyClip):
844         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
845         (WebCore::SVGResourceImage::SVGResourceImage):
846         (WebCore::SVGResourceImage::~SVGResourceImage):
847         (WebCore::SVGResourceImage::init):
848         (WebCore::SVGResourceImage::size):
849         (WebCore::SVGResourceImage::cgLayer):
850         (WebCore::SVGResourceImage::setCGLayer):
851         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
852         (WebCore::applyLuminanceToAlphaFilter):
853         (WebCore::applyExpandAlphatoGrayscaleFilter):
854         (WebCore::transformImageIntoGrayscaleMask):
855         (WebCore::SVGResourceMasker::applyMask):
856         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
857         (WebCore::SVGResourceClipper::applyClip):
858         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
859         (WebCore::SVGResourceImage::init):
860         (WebCore::SVGResourceImage::size):
861         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
862         (WebCore::SVGResourceMasker::applyMask):
863         * platform/qt/GraphicsContextQt.cpp:
864         * rendering/RenderPath.cpp:
865         (WebCore::RenderPath::paint):
866         (WebCore::DrawMarkersData::DrawMarkersData):
867         (WebCore::RenderPath::drawMarkersIfNeeded):
868         * rendering/RenderSVGContainer.cpp:
869         (WebCore::RenderSVGContainer::paint):
870         * rendering/RenderSVGImage.cpp:
871         (WebCore::RenderSVGImage::paint):
872         * rendering/SVGInlineFlowBox.cpp:
873         (WebCore::paintSVGInlineFlow):
874
875 2006-10-30  John Sullivan  <sullivan@apple.com>
876
877         Reviewed by Brady
878         
879         - minor cleanup to make future patches clearer
880
881         * bridge/mac/FrameMac.mm:
882         (WebCore::FrameMac::advanceToNextMisspelling):
883         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
884         with "continue" to better match structure of similar code in markMisspellings; a few
885         other style tweaks.
886         
887         (WebCore::FrameMac::markMisspellings):
888         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
889         a block just after a break and outdented accordingly.
890
891 2006-10-30  John Sullivan  <sullivan@apple.com>
892
893         Reviewed by Geoff Garen
894         
895         WebCore part of change to push the code that updates the spelling panel
896         into WebCore, in preparation for some grammar-checking stuff.
897
898         * bridge/mac/FrameMac.h:
899         * bridge/mac/FrameMac.mm:
900         (WebCore::FrameMac::advanceToNextMisspelling):
901         no more return value for this method, and update the spelling panel with
902         the misspelled word here rather than in the WebKit callers.
903
904 2006-10-30  Oliver Hunt  <oliver@apple.com>
905
906         Reviewed by Anders.
907
908         Roll out last patch
909
910         * CMakeLists.txt:
911         * ChangeLog:
912         * WebCore.xcodeproj/project.pbxproj:
913         * graphics/svg/SVGResource.cpp:
914         * graphics/svg/SVGResourceClipper.cpp:
915         * graphics/svg/SVGResourceClipper.h:
916         * graphics/svg/SVGResourceImage.h:
917         * graphics/svg/SVGResourceListener.h:
918         * graphics/svg/SVGResourceMarker.cpp:
919         * graphics/svg/SVGResourceMarker.h:
920         * graphics/svg/SVGResourceMasker.cpp:
921         * graphics/svg/SVGResourceMasker.h:
922         * kcanvas/KCanvasClipper.cpp: Added.
923         (WebCore::operator<<):
924         (WebCore::KCanvasClipper::KCanvasClipper):
925         (WebCore::KCanvasClipper::~KCanvasClipper):
926         (WebCore::KCanvasClipper::resetClipData):
927         (WebCore::KCanvasClipper::addClipData):
928         (WebCore::KCanvasClipper::clipData):
929         (WebCore::KCanvasClipper::externalRepresentation):
930         (WebCore::getClipperById):
931         * kcanvas/KCanvasClipper.h: Added.
932         (WebCore::KCClipData::windRule):
933         (WebCore::KCClipDataList::KCClipDataList):
934         (WebCore::KCClipDataList::addPath):
935         (WebCore::KCanvasClipper::isClipper):
936         * kcanvas/KCanvasFilters.cpp:
937         (WebCore::getFilterById):
938         * kcanvas/KCanvasFilters.h:
939         * kcanvas/KCanvasImage.h: Added.
940         (WebCore::KCanvasImage::KCanvasImage):
941         (WebCore::KCanvasImage::~KCanvasImage):
942         * kcanvas/KCanvasMarker.cpp: Added.
943         (WebCore::KCanvasMarker::KCanvasMarker):
944         (WebCore::KCanvasMarker::~KCanvasMarker):
945         (WebCore::KCanvasMarker::setMarker):
946         (WebCore::KCanvasMarker::setRef):
947         (WebCore::KCanvasMarker::refX):
948         (WebCore::KCanvasMarker::refY):
949         (WebCore::KCanvasMarker::setAngle):
950         (WebCore::KCanvasMarker::angle):
951         (WebCore::KCanvasMarker::setAutoAngle):
952         (WebCore::KCanvasMarker::setUseStrokeWidth):
953         (WebCore::KCanvasMarker::useStrokeWidth):
954         (WebCore::KCanvasMarker::draw):
955         (WebCore::KCanvasMarker::externalRepresentation):
956         (WebCore::getMarkerById):
957         * kcanvas/KCanvasMarker.h: Added.
958         (WebCore::KCanvasMarker::isMarker):
959         * kcanvas/KCanvasMasker.cpp: Added.
960         (WebCore::KCanvasMasker::KCanvasMasker):
961         (WebCore::KCanvasMasker::~KCanvasMasker):
962         (WebCore::KCanvasMasker::setMask):
963         (WebCore::KCanvasMasker::externalRepresentation):
964         (WebCore::getMaskerById):
965         * kcanvas/KCanvasMasker.h: Added.
966         (WebCore::KCanvasMasker::isMasker):
967         (WebCore::KCanvasMasker::mask):
968         * kcanvas/KCanvasResource.cpp: Added.
969         (WebCore::operator<<):
970         (WebCore::KCanvasResource::KCanvasResource):
971         (WebCore::KCanvasResource::~KCanvasResource):
972         (WebCore::KCanvasResource::addClient):
973         (WebCore::KCanvasResource::clients):
974         (WebCore::KCanvasResource::invalidate):
975         (WebCore::KCanvasResource::idInRegistry):
976         (WebCore::KCanvasResource::setIdInRegistry):
977         (WebCore::KCanvasResource::externalRepresentation):
978         (WebCore::getResourceById):
979         (WebCore::getPaintServerById):
980         * kcanvas/KCanvasResource.h:
981         (WebCore::):
982         (WebCore::KCanvasResource::isPaintServer):
983         (WebCore::KCanvasResource::isFilter):
984         (WebCore::KCanvasResource::isClipper):
985         (WebCore::KCanvasResource::isMarker):
986         (WebCore::KCanvasResource::isMasker):
987         * kcanvas/KCanvasResourceListener.h: Added.
988         (KCanvasResourceListener::KCanvasResourceListener):
989         (KCanvasResourceListener::~KCanvasResourceListener):
990         * kcanvas/KCanvasTreeDebug.cpp:
991         (WebCore::writeRenderResources):
992         * kcanvas/device/KRenderingDevice.h:
993         * kcanvas/device/KRenderingPaintServer.h:
994         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
995         (WebCore::KRenderingPaintServer::idInRegistry):
996         (WebCore::KRenderingPaintServer::setIdInRegistry):
997         * kcanvas/device/KRenderingPaintServerGradient.cpp:
998         (WebCore::KRenderingPaintServerGradient::listener):
999         (WebCore::KRenderingPaintServerGradient::setListener):
1000         * kcanvas/device/KRenderingPaintServerGradient.h:
1001         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1002         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1003         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1004         (WebCore::KRenderingPaintServerPattern::tile):
1005         (WebCore::KRenderingPaintServerPattern::setTile):
1006         (WebCore::KRenderingPaintServerPattern::listener):
1007         (WebCore::KRenderingPaintServerPattern::setListener):
1008         * kcanvas/device/KRenderingPaintServerPattern.h:
1009         * kcanvas/device/KRenderingPaintServerSolid.h:
1010         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1011         (WebCore::KCanvasClipperQt::applyClip):
1012         * kcanvas/device/qt/KCanvasClipperQt.h:
1013         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1014         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1015         (WebCore::KRenderingDeviceQt::contextForImage):
1016         (WebCore::KRenderingDeviceQt::createResource):
1017         (WebCore::KRenderingDeviceQt::createPaintServer):
1018         * kcanvas/device/qt/KRenderingDeviceQt.h:
1019         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1020         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1021         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1022         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1023         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1024         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1025         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1026         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1027         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1028         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1029         (WebCore::applyLuminanceToAlphaFilter):
1030         (WebCore::applyExpandAlphatoGrayscaleFilter):
1031         (WebCore::transformImageIntoGrayscaleMask):
1032         (WebCore::KCanvasMaskerQuartz::applyMask):
1033         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1034         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1035         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1036         (WebCore::KCanvasImageQuartz::init):
1037         (WebCore::KCanvasImageQuartz::size):
1038         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1039         (WebCore::KCanvasClipperQuartz::applyClip):
1040         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1041         (WebCore::KCanvasImageQuartz::cgLayer):
1042         (WebCore::KCanvasImageQuartz::setCGLayer):
1043         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1044         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1045         (WebCore::KRenderingDeviceQuartz::contextForImage):
1046         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1047         (WebCore::KRenderingDeviceQuartz::createResource):
1048         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1049         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1050         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1051         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1052         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1053         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1054         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1055         (WebCore::patternCallback):
1056         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1057         * kcanvas/device/quartz/QuartzSupport.mm:
1058         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1059         (WebCore::sharedSolidPaintServer):
1060         * ksvg2/svg/SVGClipPathElement.cpp:
1061         (WebCore::SVGClipPathElement::SVGClipPathElement):
1062         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1063         (WebCore::SVGClipPathElement::canvasResource):
1064         * ksvg2/svg/SVGClipPathElement.h:
1065         * ksvg2/svg/SVGFEImageElement.cpp:
1066         * ksvg2/svg/SVGFilterElement.cpp:
1067         (WebCore::SVGFilterElement::SVGFilterElement):
1068         (WebCore::SVGFilterElement::~SVGFilterElement):
1069         (WebCore::SVGFilterElement::canvasResource):
1070         * ksvg2/svg/SVGFilterElement.h:
1071         * ksvg2/svg/SVGGradientElement.cpp:
1072         (WebCore::SVGGradientElement::SVGGradientElement):
1073         (WebCore::SVGGradientElement::~SVGGradientElement):
1074         (WebCore::SVGGradientElement::canvasResource):
1075         (WebCore::SVGGradientElement::resourceNotification):
1076         * ksvg2/svg/SVGGradientElement.h:
1077         * ksvg2/svg/SVGImageElement.cpp:
1078         * ksvg2/svg/SVGLinearGradientElement.cpp:
1079         (WebCore::SVGLinearGradientElement::buildGradient):
1080         * ksvg2/svg/SVGLinearGradientElement.h:
1081         * ksvg2/svg/SVGMarkerElement.cpp:
1082         (WebCore::SVGMarkerElement::SVGMarkerElement):
1083         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1084         (WebCore::SVGMarkerElement::canvasResource):
1085         * ksvg2/svg/SVGMarkerElement.h:
1086         * ksvg2/svg/SVGMaskElement.cpp:
1087         (WebCore::SVGMaskElement::SVGMaskElement):
1088         (WebCore::SVGMaskElement::~SVGMaskElement):
1089         (WebCore::SVGMaskElement::drawMaskerContent):
1090         (WebCore::SVGMaskElement::canvasResource):
1091         * ksvg2/svg/SVGMaskElement.h:
1092         * ksvg2/svg/SVGPatternElement.cpp:
1093         (WebCore::SVGPatternElement::SVGPatternElement):
1094         (WebCore::SVGPatternElement::~SVGPatternElement):
1095         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1096         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1097         (WebCore::SVGPatternElement::canvasResource):
1098         * ksvg2/svg/SVGPatternElement.h:
1099         * ksvg2/svg/SVGRadialGradientElement.cpp:
1100         (WebCore::SVGRadialGradientElement::buildGradient):
1101         * ksvg2/svg/SVGRadialGradientElement.h:
1102         * ksvg2/svg/SVGStyledElement.h:
1103         (WebCore::SVGStyledElement::canvasResource):
1104         * platform/GraphicsContext.cpp: Added.
1105         (WebCore::GraphicsContextState::GraphicsContextState):
1106         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1107         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1108         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1109         (WebCore::GraphicsContext::save):
1110         (WebCore::GraphicsContext::restore):
1111         (WebCore::GraphicsContext::font):
1112         (WebCore::GraphicsContext::setFont):
1113         (WebCore::GraphicsContext::pen):
1114         (WebCore::GraphicsContext::setPen):
1115         (WebCore::GraphicsContext::setFillColor):
1116         (WebCore::GraphicsContext::fillColor):
1117         (WebCore::GraphicsContext::updatingControlTints):
1118         (WebCore::GraphicsContext::setUpdatingControlTints):
1119         (WebCore::GraphicsContext::setPaintingDisabled):
1120         (WebCore::GraphicsContext::paintingDisabled):
1121         (WebCore::GraphicsContext::drawImage):
1122         (WebCore::GraphicsContext::drawText):
1123         (WebCore::GraphicsContext::drawHighlightForText):
1124         (WebCore::GraphicsContext::initFocusRing):
1125         (WebCore::GraphicsContext::clearFocusRing):
1126         (WebCore::GraphicsContext::focusRingBoundingRect):
1127         (WebCore::GraphicsContext::addFocusRingRect):
1128         (WebCore::GraphicsContext::focusRingWidth):
1129         (WebCore::GraphicsContext::focusRingOffset):
1130         (WebCore::GraphicsContext::focusRingRects):
1131         (WebCore::GraphicsContext::drawTiledImage):
1132         * platform/GraphicsContext.h: Added.
1133         * platform/GraphicsTypes.cpp: Added.
1134         (WebCore::):
1135         (WebCore::parseCompositeOperator):
1136         (WebCore::compositeOperatorName):
1137         (WebCore::parseLineCap):
1138         (WebCore::lineCapName):
1139         (WebCore::parseLineJoin):
1140         (WebCore::lineJoinName):
1141         * platform/GraphicsTypes.h: Added.
1142         (WebCore::):
1143         * platform/graphics/GraphicsContext.cpp:
1144         * platform/graphics/GraphicsContext.h:
1145         * platform/graphics/GraphicsTypes.cpp:
1146         * platform/graphics/GraphicsTypes.h:
1147         * platform/qt/GraphicsContextQt.cpp:
1148         * rendering/RenderPath.cpp:
1149         (WebCore::RenderPath::paint):
1150         (WebCore::DrawMarkersData::DrawMarkersData):
1151         (WebCore::RenderPath::drawMarkersIfNeeded):
1152         * rendering/RenderSVGContainer.cpp:
1153         (WebCore::RenderSVGContainer::paint):
1154         * rendering/RenderSVGImage.cpp:
1155         (WebCore::RenderSVGImage::paint):
1156         * rendering/SVGInlineFlowBox.cpp:
1157         (WebCore::paintSVGInlineFlow):
1158
1159 2006-10-30  John Sullivan  <sullivan@apple.com>
1160
1161         Reviewed by Geoff Garen.
1162         
1163         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1164         grammar-related method.
1165
1166         * bridge/EditorClient.h:
1167         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1168         isGrammarCheckingEnabled()
1169         
1170         * bridge/mac/WebCoreFrameBridge.h:
1171         removed bridge equivalents
1172
1173         * bridge/mac/FrameMac.mm:
1174         (WebCore::FrameMac::advanceToNextMisspelling):
1175         convert bridge-using code to editor()->client()-using code
1176         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1177         ditto
1178         (WebCore::FrameMac::markMisspellings):
1179         ditto
1180         (WebCore::FrameMac::respondToChangedSelection):
1181         ditto
1182         
1183         * editing/Editor.h:
1184         * editing/Editor.cpp:
1185         (WebCore::Editor::client):
1186         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1187         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1188         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1189
1190 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1191
1192         Reviewed by Darin.
1193
1194         Removed a number of editing and selection methods from the bridge.
1195         
1196         I moved cross-platform editing and selection code into Editor and 
1197         SelectionController, respecitvely.
1198
1199         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1200         everything + the kitchen sink.
1201         
1202         Specific comments below for interesting things.
1203         
1204         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1205         a new file so that WebKit can use them, too. Added a helper method for
1206         handling exceptions when selecting a Range.
1207         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1208         WebKit, since they have to do with creating an NSAttributedString for API
1209         consumption, and not much to do with general Frame functionality.
1210         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1211         for now) into the Editor. Eventually, the Frame will not have to notify 
1212         the Editor of what the lastEditCommand was, since the Editor will perform
1213         all EditCommands.
1214         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1215         * editing/SelectionController.cpp:
1216         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1217         and return them. The bridge method to select a DOM range did this implicitly,
1218         since all ObjC DOM operations handle DOM exceptions by throwing them as
1219         ObjC exceptions.
1220         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1221         The two enumerations are numerically identical, but that's an implementation
1222         detail of TextAffinity that clients shouldn't be required to know about.
1223
1224 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1225
1226         Rolling out the following change because this crash:
1227         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1228
1229         And this regression:
1230         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1231
1232     2006-09-06  David Harrison  <harrison@apple.com>
1233
1234         Reviewed and tweaked by Tim H. 
1235
1236         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1237
1238         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1239         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1240         No layout tests affected. Not testable in an automated way that will work on all systems. 
1241
1242         * platform/mac/WebFontCache.mm: 
1243         (+[WebFontCache fontWithFamily:traits:size:]): 
1244
1245 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1246
1247         Reviewed by harrison
1248
1249         <rdar://problem/4808375>
1250         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1251
1252         * editing/TextIterator.cpp:
1253         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1254         when we're going to use them to create a range for an emitted character.
1255         We should further speed TextIterators up by avoiding creating VisiblePositions
1256         for TIs that are only used for the characters they emit (like the one that 
1257         plainText uses).
1258
1259 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1260
1261         Reviewed by Mitz.
1262
1263         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1264         More rendering code cleaning
1265
1266         * WebCore.xcodeproj/project.pbxproj:
1267         * rendering/RenderApplet.cpp:
1268         (WebCore::RenderApplet::RenderApplet):
1269         (WebCore::RenderApplet::createWidgetIfNecessary):
1270         * rendering/RenderApplet.h:
1271         * rendering/RenderArena.cpp:
1272         (WebCore::):
1273         (WebCore::RenderArena::RenderArena):
1274         (WebCore::RenderArena::allocate):
1275         (WebCore::RenderArena::free):
1276         * rendering/RenderArena.h:
1277         * rendering/RenderBR.cpp:
1278         (WebCore::RenderBR::RenderBR):
1279         (WebCore::RenderBR::baselinePosition):
1280         (WebCore::RenderBR::lineHeight):
1281         (WebCore::RenderBR::setStyle):
1282         (WebCore::RenderBR::caretMinOffset):
1283         (WebCore::RenderBR::positionForCoordinates):
1284         (WebCore::RenderBR::inlineBox):
1285         * rendering/RenderBR.h:
1286         * rendering/RenderBlock.cpp:
1287         * rendering/RenderBlock.h:
1288         (WebCore::RenderBlock::maxTopMargin):
1289         (WebCore::RenderBlock::maxBottomMargin):
1290         (WebCore::RenderBlock::initMaxMarginValues):
1291         (WebCore::RenderBlock::containsFloats):
1292         (WebCore::RenderBlock::setHasMarkupTruncation):
1293         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1294         (WebCore::RenderBlock::BlockSelectionInfo::block):
1295         (WebCore::RenderBlock::BlockSelectionInfo::state):
1296         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1297         (WebCore::RenderBlock::CompactInfo::clear):
1298         * rendering/RenderButton.cpp:
1299         (WebCore::RenderButton::removeChild):
1300         (WebCore::RenderButton::paintObject):
1301         * rendering/RenderButton.h:
1302         (WebCore::RenderButton::renderName):
1303         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1304         * rendering/RenderContainer.cpp:
1305         (WebCore::RenderContainer::RenderContainer):
1306         * rendering/RenderContainer.h:
1307         (WebCore::RenderContainer::firstChild):
1308         (WebCore::RenderContainer::lastChild):
1309         (WebCore::RenderContainer::calcMinMaxWidth):
1310         * rendering/RenderCounter.cpp:
1311         (WebCore::RenderCounter::RenderCounter):
1312         (WebCore::toRoman):
1313         (WebCore::toHebrew):
1314         (WebCore::RenderCounter::calcMinMaxWidth):
1315         * rendering/RenderCounter.h:
1316         * rendering/RenderFieldset.cpp:
1317         (WebCore::RenderFieldset::paintBoxDecorations):
1318         (WebCore::RenderFieldset::paintBorderMinusLegend):
1319         (WebCore::RenderFieldset::setStyle):
1320         * rendering/RenderFileUploadControl.cpp:
1321         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1322         (WebCore::RenderFileUploadControl::setStyle):
1323         (WebCore::RenderFileUploadControl::paintObject):
1324         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1325         * rendering/RenderFileUploadControl.h:
1326         (WebCore::RenderFileUploadControl::renderName):
1327         * rendering/RenderFlexibleBox.h:
1328         * rendering/RenderFlow.cpp:
1329         * rendering/RenderFlow.h:
1330         * rendering/RenderForeignObject.cpp:
1331         (WebCore::RenderForeignObject::RenderForeignObject):
1332         (WebCore::RenderForeignObject::paint):
1333         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1334         (WebCore::RenderForeignObject::layout):
1335         (WebCore::RenderForeignObject::nodeAtPoint):
1336         * rendering/RenderForeignObject.h:
1337         (WebCore::RenderForeignObject::renderName):
1338         * rendering/RenderFormElement.cpp:
1339         (WebCore::RenderFormElement::setStyle):
1340         (WebCore::RenderFormElement::layout):
1341         (WebCore::RenderFormElement::textAlignment):
1342         * rendering/RenderFormElement.h:
1343         * rendering/RenderFrame.cpp:
1344         * rendering/RenderFrame.h:
1345         (WebCore::RenderFrame::element):
1346         * rendering/RenderFrameSet.cpp:
1347         * rendering/RenderFrameSet.h:
1348         (WebCore::RenderFrameSet::element):
1349         * rendering/RenderHTMLCanvas.cpp:
1350         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1351         (WebCore::RenderHTMLCanvas::paint):
1352         * rendering/RenderHTMLCanvas.h:
1353         (WebCore::RenderHTMLCanvas::renderName):
1354         * rendering/RenderImage.cpp:
1355         (WebCore::RenderImage::RenderImage):
1356         (WebCore::RenderImage::setStyle):
1357         (WebCore::RenderImage::setContentObject):
1358         (WebCore::RenderImage::setCachedImage):
1359         (WebCore::RenderImage::imageChanged):
1360         (WebCore::RenderImage::paint):
1361         (WebCore::RenderImage::layout):
1362         (WebCore::RenderImage::updateAltText):
1363         * rendering/RenderImage.h:
1364         (WebCore::RenderImage::element):
1365         * rendering/RenderInline.cpp:
1366         (WebCore::RenderInline::RenderInline):
1367         (WebCore::RenderInline::~RenderInline):
1368         (WebCore::RenderInline::setStyle):
1369         (WebCore::RenderInline::addChildToFlow):
1370         (WebCore::RenderInline::cloneInline):
1371         (WebCore::RenderInline::splitInlines):
1372         (WebCore::RenderInline::splitFlow):
1373         (WebCore::RenderInline::paint):
1374         (WebCore::RenderInline::absoluteRects):
1375         (WebCore::RenderInline::calcMinMaxWidth):
1376         (WebCore::RenderInline::requiresLayer):
1377         (WebCore::RenderInline::width):
1378         (WebCore::RenderInline::height):
1379         (WebCore::RenderInline::renderName):
1380         (WebCore::RenderInline::nodeAtPoint):
1381         (WebCore::RenderInline::positionForCoordinates):
1382         * rendering/RenderInline.h:
1383         (WebCore::RenderInline::layout):
1384         * rendering/RenderLayer.cpp:
1385         * rendering/RenderLayer.h:
1386         (WebCore::ClipRects::ClipRects):
1387         (WebCore::RenderLayer::nextSibling):
1388         (WebCore::RenderLayer::root):
1389         (WebCore::RenderLayer::setPos):
1390         (WebCore::RenderLayer::height):
1391         (WebCore::RenderLayer::relativePositionOffset):
1392         * rendering/RenderLineEdit.cpp:
1393         (WebCore::RenderLineEdit::setStyle):
1394         (WebCore::RenderLineEdit::updateFromElement):
1395         (WebCore::RenderLineEdit::selectionStart):
1396         (WebCore::RenderLineEdit::selectionEnd):
1397         (WebCore::RenderLineEdit::setSelectionStart):
1398         (WebCore::RenderLineEdit::setSelectionEnd):
1399         (WebCore::RenderLineEdit::setSelectionRange):
1400         * rendering/RenderLineEdit.h:
1401         * rendering/RenderListBox.cpp:
1402         * rendering/RenderListBox.h:
1403         (WebCore::RenderListBox::renderName):
1404         * rendering/RenderListItem.cpp:
1405         (WebCore::RenderListItem::setStyle):
1406         (WebCore::getParentOfFirstLineBox):
1407         (WebCore::RenderListItem::updateMarkerLocation):
1408         (WebCore::RenderListItem::positionListMarker):
1409         (WebCore::RenderListItem::paint):
1410         * rendering/RenderListItem.h:
1411         * rendering/RenderListMarker.cpp:
1412         * rendering/RenderListMarker.h:
1413         (WebCore::RenderListMarker::renderName):
1414         (WebCore::RenderListMarker::isListMarker):
1415
1416 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1417
1418         Reviewed by Hyatt.
1419
1420         <rdar://problem/4478625> Basic table editing and culling
1421
1422         Refined the criteria for deletable elements, rely on the renderer more.
1423         Corrected the interface positioning for elements that have borders.
1424
1425         * editing/DeleteButtonController.cpp:
1426         (WebCore::isDeletableElement):
1427         (WebCore::DeleteButtonController::show):
1428
1429 2006-10-30  Darin Adler  <darin@apple.com>
1430
1431         - fix build
1432
1433         * loader/ResourceLoader.h: Added header guard.
1434
1435 2006-10-31  Darin Adler  <darin@apple.com>
1436
1437         Reviewed by Adam.
1438
1439         - fix FrameLoader files so they can be built on non-Mac platforms
1440
1441         * page/FramePrivate.h:
1442         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1443         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1444
1445         * page/Page.h:
1446         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1447         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1448         the other day.
1449
1450         * bridge/mac/FrameMac.mm:
1451         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1452         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1453
1454         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1455         around the PolicyCheck definition.
1456
1457         * loader/FormState.cpp: Changed import to include.
1458         * loader/FrameLoader.cpp: Ditto.
1459         * loader/MainResourceLoader.h: Ditto.
1460
1461         * loader/FrameLoaderTypes.h: Added a header guard.
1462
1463         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1464         Added #if PLATFORM(MAC) around Mac-specific details.
1465         * loader/SubresourceLoader.h: Ditto.
1466
1467         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1468         m_loader from m_frameLoader.
1469
1470         * CMakeLists.txt: Updated.
1471         * WebCoreSources.bkl: Updated.
1472
1473 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1474
1475         Reviewed and landed by Anders.
1476
1477         Patch by Zack rusin to fix: 
1478         http://bugs.webkit.org/show_bug.cgi?id=11429
1479
1480         Fix startup crash.
1481
1482         * platform/qt/FrameQtClient.cpp:
1483         (WebCore::FrameQtClientDefault::openURL):
1484
1485 2006-10-30  Zach Rusin  <zack@kde.org>
1486
1487         Reviewed and landed by Anders.
1488
1489         * platform/network/qt/ResourceHandleQt.cpp:
1490         (WebCore::ResourceHandle::receivedResponse):
1491         * platform/qt/FrameQtClient.cpp:
1492         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1493         * platform/qt/LoaderFunctionsQt.cpp:
1494         (WebCore::ServeSynchronousRequest):
1495         More build fixes.
1496
1497 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1498
1499         Reviewed and landed by Anders.
1500         
1501         - fix Qt build
1502         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1503         ResourceHandleClient
1504
1505 2006-10-30  Darin Adler  <darin@apple.com>
1506
1507         Reviewed by John Sullivan.
1508
1509         - work toward removing Objective-C data types from FrameLoader.h:
1510           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1511           and WebCoreResourceHandle
1512         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1513
1514         * page/PageState.h:
1515         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1516
1517         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1518         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1519         double for the date instead of an NSDate.
1520
1521         * bridge/mac/WebCoreFrameBridge.h:
1522         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1523         saveDocumentToPageCache methods.
1524
1525         * bridge/mac/WebCorePageState.h:
1526         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1527         an Objective-C wrapper for PageState.
1528
1529         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1530         NSDate and WebCorePageState.
1531         * loader/FrameLoaderClient.h: Changed NSDate to double.
1532         * loader/mac/FrameLoaderMac.mm:
1533         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1534         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1535         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1536         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1537         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1538         extract the parameters from the response. Changed the open function that takes
1539         a PageState to use the new C++ PageState.
1540         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1541         function; tightened up logic, removing a few cases that could never happen, as
1542         well as the unused reload boolean.
1543
1544         * ForwardingHeaders/kjs/property_map.h: Added.
1545
1546         * WebCore.exp: Updated.
1547         * WebCore.xcodeproj/project.pbxproj: Updated.
1548
1549 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1550
1551         Reviewed by Anders.
1552
1553         - added ResourceResponse class and didReceiveResponse delegate call
1554         
1555         * WebCore.xcodeproj/project.pbxproj: Added new files.
1556         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1557         expiresTimeForResponse: method.
1558         * dom/XMLTokenizer.cpp:
1559         (WebCore::openFunc): Updated to use ResourceResponse.
1560         * loader/FrameLoader.h: Update loadResourceSynchronously to
1561         use ResourceResponse.
1562         * loader/LoaderFunctions.h:
1563         * loader/icon/IconLoader.cpp:
1564         (IconLoader::didReceiveResponse): Updated from receivedResponse
1565         and made cross-platform.
1566         * loader/icon/IconLoader.h: updated for above change
1567         * loader/loader.cpp:
1568         (WebCore::Loader::receivedResponse): reduced to just saving
1569         the PlatformResponse (ideally we'd phase out use of this).
1570         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1571         logic.
1572         * loader/loader.h:
1573         * loader/mac/FrameLoaderMac.mm:
1574         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1575         as ResourceResponse.
1576         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1577         * loader/mac/LoaderFunctionsMac.mm:
1578         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1579         argument.
1580         * platform/network/ResourceHandle.cpp:
1581         * platform/network/ResourceHandle.h: Remove calls for
1582         broken out response pieces.
1583         * platform/network/ResourceHandleClient.h:
1584         (WebCore::ResourceHandleClient::didReceiveResponse): New
1585         delegate method.
1586         * platform/network/ResourceHandleInternal.h:
1587         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1588         storage of response bits, we're not gonna return them
1589         seprately any more.
1590         * platform/network/ResourceResponse.h: Added.
1591         (WebCore::ResourceResponse::ResourceResponse): Freshly
1592         implemented. Same for below.
1593         (WebCore::ResourceResponse::url):
1594         (WebCore::ResourceResponse::mimeType):
1595         (WebCore::ResourceResponse::expectedContentLength):
1596         (WebCore::ResourceResponse::textEncodingName):
1597         (WebCore::ResourceResponse::suggestedFilename):
1598         (WebCore::ResourceResponse::httpStatusCode):
1599         (WebCore::ResourceResponse::setHTTPStatusCode):
1600         (WebCore::ResourceResponse::httpHeaderField):
1601         (WebCore::ResourceResponse::httpHeaderFields):
1602         (WebCore::ResourceResponse::isMultipart):
1603         (WebCore::ResourceResponse::setExpirationDate):
1604         (WebCore::ResourceResponse::expirationDate):
1605         * platform/network/cf/ResourceHandleCFNet.cpp:
1606         (WebCore::didReceiveResponse): Send didReceiveResponse
1607         client method.
1608         * platform/network/cf/ResourceResponseCFNet.h: Added.
1609         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1610         (getResourceResponse): Helper function to get a ResourceResponse 
1611         from CFURLResponseRef.
1612         * platform/network/mac/ResourceHandleMac.mm:
1613         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1614         Don't bother cleaning up fields we no longer have.
1615         (WebCore::ResourceHandle::receivedResponse): Send
1616         didReceiveResponse client method.
1617         * platform/network/mac/ResourceResponseMac.h: Added.
1618         * platform/network/mac/ResourceResponseMac.mm: Added.
1619         (getResourceResponse): Helper function to get a ResourceResponse 
1620         from an NSURLResponse*.
1621         * rendering/HitTestResult.cpp:
1622         * xml/XSLTProcessor.cpp:
1623         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1624         * xml/xmlhttprequest.cpp:
1625         (WebCore::XMLHttpRequest::getResponseText): Store http response
1626         info in the form of a ResourceResponse, change all methods to
1627         account for this.
1628         (WebCore::XMLHttpRequest::getResponseXML):
1629         (WebCore::XMLHttpRequest::XMLHttpRequest):
1630         (WebCore::XMLHttpRequest::open):
1631         (WebCore::XMLHttpRequest::send):
1632         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1633         (WebCore::XMLHttpRequest::getResponseHeader):
1634         (WebCore::XMLHttpRequest::getStatus):
1635         (WebCore::XMLHttpRequest::getStatusText):
1636         (WebCore::XMLHttpRequest::processSyncLoadResults):
1637         (WebCore::XMLHttpRequest::didFinishLoading):
1638         (WebCore::XMLHttpRequest::didReceiveResponse):
1639         (WebCore::XMLHttpRequest::didReceiveData):
1640         * xml/xmlhttprequest.h:
1641
1642 2006-10-29  Darin Adler  <darin@apple.com>
1643
1644         - fix build
1645
1646         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1647         * loader/NetscapePlugInStreamLoader.h: Ditto.
1648         * loader/ResourceLoader.h: Ditto.
1649
1650 2006-10-29  Darin Adler  <darin@apple.com>
1651
1652         - one last name change -- WebFormState.h to FormState.h
1653         - added more empty placeholder platform-independent files
1654           for currently-Mac-specific loader classes
1655
1656         * loader/FormState.cpp: Updated include.
1657         * loader/FrameLoader.cpp: Updated include.
1658         * loader/mac/FrameLoaderMac.mm: Updated include.
1659
1660         * loader/WebFormState.h: Removed.
1661         * loader/FormState.h: Added.
1662
1663         * loader/DocumentLoader.cpp: Added.
1664         * loader/MainResourceLoader.cpp: Added.
1665         * loader/NetscapePlugInStreamLoader.cpp: Added.
1666         * loader/ResourceLoader.cpp: Added.
1667         * loader/SubresourceLoader.cpp: Added.
1668
1669         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1670
1671 2006-10-29  Darin Adler  <darin@apple.com>
1672
1673         - did the do-webcore-rename renames, including a number of changes
1674           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1675           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1676           and improvements to the names of decoder classes and their source
1677           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1678
1679         * CMakeLists.txt:
1680         * WebCore.exp:
1681         * WebCore.vcproj/WebCore/WebCore.vcproj:
1682         * WebCore.xcodeproj/project.pbxproj:
1683         * WebCoreSources.bkl:
1684         * bindings/js/kjs_binding.cpp:
1685         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1686         * bindings/js/kjs_events.cpp:
1687         (KJS::JSAbstractEventListener::handleEvent):
1688         (KJS::JSLazyEventListener::parseCode):
1689         * bindings/js/kjs_html.cpp:
1690         (KJS::JSHTMLElement::implementsCall):
1691         * bindings/js/kjs_traversal.cpp:
1692         (KJS::JSNodeFilterCondition::acceptNode):
1693         * bindings/js/kjs_window.cpp:
1694         (KJS::Window::interpreter):
1695         (KJS::Window::retrieveWindow):
1696         (KJS::Window::retrieve):
1697         (KJS::ScheduledAction::execute):
1698         * bindings/objc/DOMInternal.mm:
1699         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1700         * bridge/mac/FrameMac.mm:
1701         (WebCore::FrameMac::executionContextForDOM):
1702         (WebCore::FrameMac::bindingRootObject):
1703         (WebCore::FrameMac::windowScriptObject):
1704         (WebCore::FrameMac::windowScriptNPObject):
1705         (WebCore::FrameMac::partClearedInBegin):
1706         * bridge/mac/WebCoreEncodings.mm:
1707         * bridge/mac/WebCoreFrameBridge.mm:
1708         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1709         (-[WebCoreFrameBridge stringWithData:]):
1710         (-[WebCoreFrameBridge executionContextForView:]):
1711         * bridge/win/FrameWin.cpp:
1712         * dom/Document.cpp:
1713         (WebCore::Document::inputEncoding):
1714         (WebCore::Document::setCharset):
1715         (WebCore::Document::createHTMLEventListener):
1716         (WebCore::Document::setDecoder):
1717         * dom/Document.h:
1718         (WebCore::Document::decoder):
1719         * dom/EventTargetNode.cpp:
1720         (WebCore::EventTargetNode::dispatchGenericEvent):
1721         * html/HTMLParser.cpp:
1722         (WebCore::HTMLParser::noscriptCreateErrorCheck):
1723         (WebCore::HTMLParser::canvasCreateErrorCheck):
1724         (WebCore::HTMLParser::isInline):
1725         * html/HTMLPlugInElement.cpp:
1726         (WebCore::HTMLPlugInElement::createNPObject):
1727         * html/HTMLScriptElement.cpp:
1728         (WebCore::HTMLScriptElement::evaluateScript):
1729         * html/HTMLTokenizer.cpp:
1730         (WebCore::HTMLTokenizer::parseTag):
1731         (WebCore::HTMLTokenizer::processToken):
1732         * ksvg2/misc/SVGDocumentExtensions.cpp:
1733         (WebCore::SVGDocumentExtensions::createSVGEventListener):
1734         * loader/CachedCSSStyleSheet.cpp:
1735         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1736         (WebCore::CachedCSSStyleSheet::setEncoding):
1737         * loader/CachedCSSStyleSheet.h:
1738         * loader/CachedXBLDocument.cpp:
1739         (WebCore::CachedXBLDocument::CachedXBLDocument):
1740         (WebCore::CachedXBLDocument::setEncoding):
1741         * loader/CachedXBLDocument.h:
1742         * loader/CachedXSLStyleSheet.cpp:
1743         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1744         (WebCore::CachedXSLStyleSheet::setEncoding):
1745         * loader/CachedXSLStyleSheet.h:
1746         * loader/Decoder.cpp: Removed.
1747         * loader/Decoder.h: Removed.
1748         * loader/FrameLoader.cpp:
1749         * loader/FrameLoader.h:
1750         * loader/FrameLoaderClient.h:
1751         * loader/MainResourceLoader.h: Added.
1752         * loader/NetscapePlugInStreamLoader.h: Added.
1753         * loader/Request.h:
1754         (WebCore::Request::cachedResource):
1755         * loader/ResourceLoader.h: Added.
1756         * loader/SubresourceLoader.h: Added.
1757         * loader/TextResourceDecoder.cpp: Added.
1758         (WebCore::TextResourceDecoder::determineContentType):
1759         (WebCore::TextResourceDecoder::defaultEncoding):
1760         (WebCore::TextResourceDecoder::TextResourceDecoder):
1761         (WebCore::TextResourceDecoder::~TextResourceDecoder):
1762         (WebCore::TextResourceDecoder::setEncoding):
1763         (WebCore::TextResourceDecoder::checkForBOM):
1764         (WebCore::TextResourceDecoder::checkForCSSCharset):
1765         (WebCore::TextResourceDecoder::checkForHeadCharset):
1766         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
1767         (WebCore::TextResourceDecoder::decode):
1768         (WebCore::TextResourceDecoder::flush):
1769         * loader/TextResourceDecoder.h: Added.
1770         * loader/WebDocumentLoader.h: Removed.
1771         * loader/WebLoader.h: Removed.
1772         * loader/WebMainResourceLoader.h: Removed.
1773         * loader/WebNetscapePlugInStreamLoader.h: Removed.
1774         * loader/WebSubresourceLoader.h: Removed.
1775         * loader/loader.cpp:
1776         (WebCore::Loader::servePendingRequests):
1777         (WebCore::Loader::receivedAllData):
1778         (WebCore::Loader::receivedResponse):
1779         (WebCore::Loader::didReceiveData):
1780         (WebCore::Loader::cancelRequests):
1781         (WebCore::Loader::jobForRequest):
1782         * loader/mac/DocumentLoaderMac.mm:
1783         * loader/mac/FormDataStream.m: Added.
1784         * loader/mac/FrameLoaderMac.mm:
1785         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1786         (WebCore::FrameLoader::addPlugInStreamLoader):
1787         (WebCore::FrameLoader::removePlugInStreamLoader):
1788         (WebCore::FrameLoader::addSubresourceLoader):
1789         (WebCore::FrameLoader::removeSubresourceLoader):
1790         (WebCore::FrameLoader::willSendRequest):
1791         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1792         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1793         (WebCore::FrameLoader::didReceiveResponse):
1794         (WebCore::FrameLoader::didReceiveData):
1795         (WebCore::FrameLoader::didFinishLoad):
1796         (WebCore::FrameLoader::didFailToLoad):
1797         (WebCore::FrameLoader::open):
1798         (WebCore::FrameLoader::willUseArchive):
1799         (WebCore::FrameLoader::isArchiveLoadPending):
1800         * loader/mac/ImageDocumentMac.mm:
1801         * loader/mac/LoaderFunctionsMac.mm:
1802         (WebCore::CheckCacheObjectStatus):
1803         * loader/mac/MainResourceLoaderMac.mm:
1804         (WebCore::MainResourceLoader::MainResourceLoader):
1805         (WebCore::MainResourceLoader::releaseDelegate):
1806         (WebCore::MainResourceLoader::didCancel):
1807         (WebCore::MainResourceLoader::addData):
1808         (WebCore::MainResourceLoader::willSendRequest):
1809         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1810         (WebCore::MainResourceLoader::didReceiveData):
1811         (WebCore::MainResourceLoader::didFinishLoading):
1812         (WebCore::MainResourceLoader::setDefersLoading):
1813         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1814         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1815         (WebCore::NetscapePlugInStreamLoader::releaseResources):
1816         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1817         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
1818         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1819         (WebCore::NetscapePlugInStreamLoader::didFail):
1820         (WebCore::NetscapePlugInStreamLoader::didCancel):
1821         * loader/mac/ResourceLoaderMac.mm:
1822         (WebCore::ResourceLoader::ResourceLoader):
1823         (WebCore::ResourceLoader::~ResourceLoader):
1824         (WebCore::ResourceLoader::releaseResources):
1825         (WebCore::ResourceLoader::load):
1826         (WebCore::ResourceLoader::setDefersLoading):
1827         (WebCore::ResourceLoader::frameLoader):
1828         (WebCore::ResourceLoader::addData):
1829         (WebCore::ResourceLoader::resourceData):
1830         (WebCore::ResourceLoader::clearResourceData):
1831         (WebCore::ResourceLoader::willSendRequest):
1832         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1833         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1834         (WebCore::ResourceLoader::didReceiveResponse):
1835         (WebCore::ResourceLoader::didReceiveData):
1836         (WebCore::ResourceLoader::willStopBufferingData):
1837         (WebCore::ResourceLoader::didFinishLoading):
1838         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1839         (WebCore::ResourceLoader::didFail):
1840         (WebCore::ResourceLoader::willCacheResponse):
1841         (WebCore::ResourceLoader::didCancel):
1842         (WebCore::ResourceLoader::cancel):
1843         (WebCore::ResourceLoader::setIdentifier):
1844         (WebCore::ResourceLoader::response):
1845         (WebCore::ResourceLoader::inConnectionCallback):
1846         (WebCore::ResourceLoader::cancelledError):
1847         (WebCore::ResourceLoader::receivedCredential):
1848         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1849         (WebCore::ResourceLoader::receivedCancellation):
1850         (WebCore::ResourceLoader::delegate):
1851         (WebCore::ResourceLoader::releaseDelegate):
1852         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
1853         * loader/mac/SubresourceLoaderMac.mm:
1854         (WebCore::SubresourceLoader::SubresourceLoader):
1855         (WebCore::SubresourceLoader::willSendRequest):
1856         (WebCore::SubresourceLoader::didReceiveResponse):
1857         (WebCore::SubresourceLoader::didReceiveData):
1858         (WebCore::SubresourceLoader::didFinishLoading):
1859         (WebCore::SubresourceLoader::didFail):
1860         (WebCore::SubresourceLoader::didCancel):
1861         * loader/mac/WebFormDataStream.h: Removed.
1862         * loader/mac/WebFormDataStream.m: Removed.
1863         * page/Frame.cpp:
1864         (WebCore::Frame::javaScriptEnabled):
1865         (WebCore::Frame::scriptProxy):
1866         (WebCore::Frame::executeScript):
1867         (WebCore::Frame::write):
1868         (WebCore::Frame::userGestureHint):
1869         (WebCore::Frame::saveInterpreterBuiltins):
1870         (WebCore::Frame::restoreInterpreterBuiltins):
1871         (WebCore::Frame::backslashAsCurrencySymbol):
1872         * page/Frame.h:
1873         * page/FramePrivate.h:
1874         * platform/StreamingTextDecoder.cpp: Removed.
1875         * platform/StreamingTextDecoder.h: Removed.
1876         * platform/StreamingTextDecoderICU.cpp: Removed.
1877         * platform/StreamingTextDecoderICU.h: Removed.
1878         * platform/TextCodec.cpp: Added.
1879         * platform/TextCodec.h: Added.
1880         * platform/TextCodecICU.cpp: Added.
1881         * platform/TextCodecICU.h: Added.
1882         * platform/TextCodecLatin1.h:
1883         * platform/TextCodecUTF16.h:
1884         * platform/TextDecoder.h:
1885         * platform/TextEncoding.cpp:
1886         * platform/TextEncodingRegistry.cpp:
1887         * platform/image-decoders/jpeg/jmorecfg.h:
1888         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
1889         * platform/mac/StreamingTextDecoderMac.h: Removed.
1890         * platform/mac/TextCodecMac.cpp: Added.
1891         * platform/mac/TextCodecMac.h: Added.
1892         * platform/network/ResourceHandleInternal.h:
1893         * platform/network/mac/ResourceHandleMac.mm:
1894         * platform/qt/FrameQt.cpp:
1895         (WebCore::FrameQt::bindingRootObject):
1896         * platform/qt/LoaderFunctionsQt.cpp:
1897         (WebCore::CheckCacheObjectStatus):
1898         * rendering/RenderObject.cpp:
1899         (WebCore::RenderObject::backslashAsCurrencySymbol):
1900         * xml/XSLTProcessor.cpp:
1901         (WebCore::XSLTProcessor::createDocumentFromSource):
1902         * xml/xmlhttprequest.cpp:
1903         (WebCore::XMLHttpRequest::didReceiveData):
1904         * xml/xmlhttprequest.h:
1905
1906 2006-10-29  Darin Adler  <darin@apple.com>
1907
1908         Rubber stamped by Adam (kinda).
1909
1910         - add Mac suffixes and correct filenames inside loader/mac
1911
1912         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
1913
1914         * loader/mac/FrameLoader.mm: Removed.
1915         * loader/mac/WebDocumentLoader.mm: Removed.
1916         * loader/mac/WebLoader.mm: Removed.
1917         * loader/mac/WebMainResourceLoader.mm: Removed.
1918         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
1919         * loader/mac/WebSubresourceLoader.mm: Removed.
1920
1921         * loader/mac/FrameLoaderMac.mm: Added.
1922         * loader/mac/DocumentLoaderMac.mm: Added.
1923         * loader/mac/ResourceLoaderMac.mm: Added.
1924         * loader/mac/MainResourceLoaderMac.mm: Added.
1925         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
1926         * loader/mac/SubresourceLoaderMac.mm: Removed.
1927
1928 2006-10-29  Darin Adler  <darin@apple.com>
1929
1930         Reviewed by Adam.
1931
1932         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
1933           and FrameLoader.cpp mostly ready
1934
1935         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
1936         FormState.cpp. Removed WebFormState.mm.
1937
1938         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
1939         get this header compiling on non-Mac.
1940         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
1941         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
1942
1943         * loader/FrameLoaderClient.h: Added some ifdefs.
1944         * loader/WebDocumentLoader.h: Ditto.
1945         * loader/WebLoader.h: Ditto.
1946         * loader/WebMainResourceLoader.h: Ditto.
1947
1948         * loader/mac/WebDocumentLoader.mm:
1949         (WebCore::DocumentLoader::isLoadingInAPISense):
1950         Rewrote to work without bridge, partly to remove the need for ObjC
1951         bridge type in the header, and also because we're tearing down the bridge.
1952
1953         * loader/mac/WebMainResourceLoader.mm:
1954         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
1955         m_contentLength and m_bytesReceived.
1956         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
1957         (WebCore::MainResourceLoader::didReceiveData): Ditto.
1958
1959         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
1960         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1961
1962         * loader/mac/FormState.mm: Removed.
1963         * loader/FormState.cpp: Added.
1964
1965 2006-10-29  Darin Adler  <darin@apple.com>
1966
1967         Rubber stamped by Adam.
1968
1969         - moving towards use of FrameLoader cross-platform; move the headers
1970           for the Mac loader from loader/mac into loader, in preparation for
1971           making them useful on non-Mac
1972
1973         * WebCore.xcodeproj/project.pbxproj:
1974
1975         * loader/mac/FrameLoader.h: Removed.
1976         * loader/mac/WebDocumentLoader.h: Removed.
1977         * loader/mac/WebFormState.h: Removed.
1978         * loader/mac/WebLoader.h: Removed.
1979         * loader/mac/WebMainResourceLoader.h: Removed.
1980         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
1981         * loader/mac/WebSubresourceLoader.h: Removed.
1982
1983         * loader/FrameLoader.h: Added.
1984         * loader/WebDocumentLoader.h: Added.
1985         * loader/WebFormState.h: Added.
1986         * loader/WebLoader.h: Added.
1987         * loader/WebMainResourceLoader.h: Added.
1988         * loader/WebNetscapePlugInStreamLoader.h: Added.
1989         * loader/WebSubresourceLoader.h: Added.
1990
1991 2006-10-29  Adam Roben  <aroben@apple.com>
1992
1993         Reviewed by Geoff.
1994
1995         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
1996         r17405.
1997
1998         * platform/DeprecatedString.h:
1999
2000 2006-10-29  Beth Dakin  <bdakin@apple.com>
2001
2002         Rubber stamped by Geoff.
2003
2004         This is a followup to my HitTestResult checkin. Most of the 
2005         HitTestResult local variables in the code were named i or info for 
2006         when the class was named NodeInfo. This patch renames all of these 
2007         local variables to result.
2008
2009         * dom/Document.cpp:
2010         (WebCore::Document::prepareMouseEvent):
2011         * html/HTMLAreaElement.cpp:
2012         (WebCore::HTMLAreaElement::mapMouseEvent):
2013         * html/HTMLMapElement.cpp:
2014         (WebCore::HTMLMapElement::mapMouseEvent):
2015         * rendering/EllipsisBox.cpp:
2016         (WebCore::EllipsisBox::nodeAtPoint):
2017         * rendering/EllipsisBox.h:
2018         * rendering/InlineBox.cpp:
2019         (WebCore::InlineBox::nodeAtPoint):
2020         * rendering/InlineFlowBox.cpp:
2021         (WebCore::InlineFlowBox::nodeAtPoint):
2022         * rendering/InlineTextBox.cpp:
2023         (WebCore::InlineTextBox::nodeAtPoint):
2024         * rendering/RenderBlock.cpp:
2025         (WebCore::RenderBlock::isPointInScrollbar):
2026         (WebCore::RenderBlock::nodeAtPoint):
2027         * rendering/RenderBlock.h:
2028         * rendering/RenderBox.cpp:
2029         (WebCore::RenderBox::nodeAtPoint):
2030         * rendering/RenderBox.h:
2031         * rendering/RenderFlow.cpp:
2032         (WebCore::RenderFlow::hitTestLines):
2033         * rendering/RenderFlow.h:
2034         * rendering/RenderForeignObject.cpp:
2035         (WebCore::RenderForeignObject::nodeAtPoint):
2036         * rendering/RenderFrameSet.cpp:
2037         (WebCore::RenderFrameSet::nodeAtPoint):
2038         * rendering/RenderImage.cpp:
2039         (WebCore::RenderImage::nodeAtPoint):
2040         * rendering/RenderInline.cpp:
2041         (WebCore::RenderInline::nodeAtPoint):
2042         * rendering/RenderInline.h:
2043         * rendering/RenderLayer.cpp:
2044         (WebCore::RenderLayer::autoscroll):
2045         (WebCore::RenderLayer::hitTest):
2046         (WebCore::RenderLayer::hitTestLayer):
2047         (WebCore::RenderLayer::updateHoverActiveState):
2048         * rendering/RenderListBox.cpp:
2049         (WebCore::RenderListBox::isPointInScrollbar):
2050         * rendering/RenderObject.cpp:
2051         (WebCore::RenderObject::hitTest):
2052         (WebCore::RenderObject::setInnerNode):
2053         (WebCore::RenderObject::nodeAtPoint):
2054         * rendering/RenderObject.h:
2055         * rendering/RenderPath.cpp:
2056         (WebCore::RenderPath::nodeAtPoint):
2057         * rendering/RenderSVGImage.cpp:
2058         (WebCore::RenderSVGImage::nodeAtPoint):
2059         * rendering/RenderSVGText.cpp:
2060         (WebCore::RenderSVGText::nodeAtPoint):
2061         * rendering/RenderTableRow.cpp:
2062         (WebCore::RenderTableRow::nodeAtPoint):
2063         * rendering/RenderTableRow.h:
2064         * rendering/RenderTableSection.cpp:
2065         (WebCore::RenderTableSection::nodeAtPoint):
2066         * rendering/RenderTableSection.h:
2067         * rendering/RenderTextControl.cpp:
2068         (WebCore::RenderTextControl::nodeAtPoint):
2069         * rendering/RootInlineBox.cpp:
2070         (WebCore::RootInlineBox::nodeAtPoint):
2071         * rendering/RootInlineBox.h:
2072
2073 2006-10-29  Adam Roben  <aroben@apple.com>
2074
2075         More semi-fixes.
2076
2077         * page/Page.cpp: Forgot to wrap the actual definition of
2078         setDefersLoading() in PLATFORM(MAC).
2079         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2080
2081 2006-10-29  Adam Roben  <aroben@apple.com>
2082
2083         Build semi-fix.
2084
2085         Move all FrameLoader-related code in Page.{cpp,h} within #if
2086         PLATFORM(MAC), since this class currently only exists on Mac.
2087
2088         * page/Page.cpp:
2089         * page/Page.h:
2090
2091 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2092
2093         build fix.
2094         
2095         * platform/PlatformString.h:
2096         (WebCore::String::operator NSString*):
2097
2098 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2099
2100         Rolled out accidental commit.
2101         
2102         * platform/AtomicString.h:
2103         (WebCore::AtomicString::AtomicString):
2104         (WebCore::AtomicString::operator NSString*):
2105
2106 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2107
2108         RS by Darin.
2109
2110         Rolled out change to map NULL Strings to nil NSStrings because it caused
2111         even more AppKit crashes. Maybe we should remove the NSString * operator
2112         entirely, since its use is not straight-forward, and require callers to
2113         specify explicitly whether they tolerate NULL.
2114         
2115         * platform/AtomicString.h:
2116         * platform/PlatformString.h:
2117         (WebCore::String::operator NSString*):
2118         * platform/mac/TextFieldMac.mm:
2119         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2120
2121 2006-10-29  Darin Adler  <darin@apple.com>
2122
2123         Reviewed by Geoff.
2124
2125         - fixed storage leak showing up on the buildbot
2126
2127         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2128         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2129
2130 2006-10-29  Darin Adler  <darin@apple.com>
2131
2132         Rubber stamped by Adam.
2133
2134         - renamed WebFrameLoaderClient to match the class name inside it
2135
2136         * loader/mac/WebFrameLoaderClient.h: Removed.
2137         * loader/FrameLoaderClient.h: Moved it here.
2138
2139         * WebCore.xcodeproj/project.pbxproj: Updated project.
2140
2141         * bridge/mac/FrameMac.mm: Updated includes.
2142         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2143         * loader/mac/FrameLoader.mm: Ditto.
2144         * loader/mac/WebLoader.h: Ditto.
2145
2146 2006-10-29  Darin Adler  <darin@apple.com>
2147
2148         Reviewed by Mitz.
2149
2150         - fix crash visible on buildbot and also when running the test
2151           anchor-image-scrolled-x-y.html under libgmalloc
2152
2153         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2154         now that the class is named ResourceHandle.
2155         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2156         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2157         a local RefPtr before calling finishJobAndHandle, since we might get
2158         cancelled inside that function, so we should not rely on m_handle to
2159         keep the ResourceHandle alive.
2160         (WebCore::SubresourceLoader::didFail): Ditto.
2161         (WebCore::SubresourceLoader::didCancel): Ditto.
2162
2163 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2164
2165         - build fix
2166
2167         * platform/network/mac/ResourceHandleMac.mm:
2168
2169 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2170
2171         Rubber stamped by Darin.
2172
2173         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2174
2175         * CMakeLists.txt:
2176         * Projects/gdk/webcore-gdk.bkl:
2177         * WebCore.vcproj/WebCore/WebCore.vcproj:
2178         * WebCore.xcodeproj/project.pbxproj:
2179         * WebCoreSources.bkl:
2180         * bridge/mac/FrameMac.mm:
2181         * bridge/win/FrameWin.cpp:
2182         * dom/XMLTokenizer.cpp:
2183         * loader/Cache.cpp:
2184         * loader/CachedResource.h:
2185         * loader/LoaderFunctions.h:
2186         * loader/icon/IconLoader.cpp:
2187         (IconLoader::startLoading):
2188         (IconLoader::didReceiveData):
2189         (IconLoader::didFinishLoading):
2190         * loader/icon/IconLoader.h:
2191         * loader/loader.cpp:
2192         (WebCore::Loader::servePendingRequests):
2193         (WebCore::Loader::receivedAllData):
2194         (WebCore::Loader::receivedResponse):
2195         (WebCore::Loader::didReceiveData):
2196         (WebCore::Loader::cancelRequests):
2197         (WebCore::Loader::jobForRequest):
2198         * loader/loader.h:
2199         * loader/mac/IconLoaderMac.mm:
2200         (IconLoader::receivedResponse):
2201         * loader/mac/LoaderFunctionsMac.mm:
2202         * loader/mac/WebLoader.h:
2203         * loader/mac/WebSubresourceLoader.h:
2204         * loader/mac/WebSubresourceLoader.mm:
2205         (WebCore::SubresourceLoader::SubresourceLoader):
2206         (WebCore::SubresourceLoader::create):
2207         * platform/gdk/FrameGdk.cpp:
2208         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2209         (WebCore::FrameGdkClientDefault::openURL):
2210         (WebCore::FrameGdkClientDefault::submitForm):
2211         (WebCore::FrameGdkClientDefault::receivedResponse):
2212         (WebCore::FrameGdkClientDefault::didReceiveData):
2213         (WebCore::FrameGdkClientDefault::receivedAllData):
2214         * platform/gdk/FrameGdk.h:
2215         * platform/gdk/TemporaryLinkStubs.cpp:
2216         (WebCore::ServeSynchronousRequest):
2217         (WebCore::ResourceHandle::assembleResponseHeaders):
2218         (WebCore::ResourceHandle::retrieveCharset):
2219         * platform/network/ResourceHandle.cpp: Added.
2220         (WebCore::ResourceHandle::ResourceHandle):
2221         (WebCore::ResourceHandle::create):
2222         (WebCore::ResourceHandle::isErrorPage):
2223         (WebCore::ResourceHandle::error):
2224         (WebCore::ResourceHandle::setError):
2225         (WebCore::ResourceHandle::responseEncoding):
2226         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2227         (WebCore::ResourceHandle::kill):
2228         (WebCore::ResourceHandle::requestHeaders):
2229         (WebCore::ResourceHandle::url):
2230         (WebCore::ResourceHandle::postData):
2231         (WebCore::ResourceHandle::method):
2232         (WebCore::ResourceHandle::client):
2233         * platform/network/ResourceHandle.h: Added.
2234         (WebCore::ResourceHandle::getInternal):
2235         * platform/network/ResourceHandleClient.h: Added.
2236         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2237         (WebCore::ResourceHandleClient::didReceiveData):
2238         (WebCore::ResourceHandleClient::didFinishLoading):
2239         (WebCore::ResourceHandleClient::receivedRedirect):
2240         (WebCore::ResourceHandleClient::receivedResponse):
2241         (WebCore::ResourceHandleClient::receivedAllData):
2242         * platform/network/ResourceHandleInternal.h: Added.
2243         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2244         * platform/network/ResourceLoader.cpp: Removed.
2245         * platform/network/ResourceLoader.h: Removed.
2246         * platform/network/ResourceLoaderClient.h: Removed.
2247         * platform/network/ResourceLoaderInternal.h: Removed.
2248         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2249         (WebCore::willSendRequest):
2250         (WebCore::didReceiveResponse):
2251         (WebCore::didReceiveData):
2252         (WebCore::didFinishLoading):
2253         (WebCore::didFail):
2254         (WebCore::willCacheResponse):
2255         (WebCore::didReceiveChallenge):
2256         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2257         (WebCore::ResourceHandle::~ResourceHandle):
2258         (WebCore::ResourceHandle::start):
2259         (WebCore::ResourceHandle::cancel):
2260         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2261         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2262         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2263         (WebCore::ResourceHandle::~ResourceHandle):
2264         (WebCore::ResourceHandle::start):
2265         (WebCore::ResourceHandle::cancel):
2266         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2267         (WebCore::ResourceHandleManager::ResourceHandleManager):
2268         (WebCore::ResourceHandleManager::get):
2269         (WebCore::ResourceHandleManager::useSimpleTransfer):
2270         (WebCore::writeCallback):
2271         (WebCore::ResourceHandleManager::downloadTimerCallback):
2272         (WebCore::ResourceHandleManager::remove):
2273         (WebCore::ResourceHandleManager::add):
2274         (WebCore::ResourceHandleManager::cancel):
2275         * platform/network/gdk/ResourceHandleManager.h: Added.
2276         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2277         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2278         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2279         * platform/network/mac/ResourceHandleMac.mm: Added.
2280         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2281         (WebCore::ResourceHandle::~ResourceHandle):
2282         (WebCore::ResourceHandle::start):
2283         (WebCore::ResourceHandle::assembleResponseHeaders):
2284         (WebCore::ResourceHandle::retrieveResponseEncoding):
2285         (WebCore::ResourceHandle::receivedResponse):
2286         (WebCore::ResourceHandle::cancel):
2287         (WebCore::ResourceHandle::redirectedToURL):
2288         (WebCore::ResourceHandle::addData):
2289         (WebCore::ResourceHandle::finishJobAndHandle):
2290         (WebCore::ResourceHandle::reportError):
2291         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2292         * platform/network/qt/ResourceHandleManager.cpp: Added.
2293         (WebCore::ResourceHandleManager::ResourceHandleManager):
2294         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2295         (WebCore::ResourceHandleManager::self):
2296         (WebCore::ResourceHandleManager::slotData):
2297         (WebCore::ResourceHandleManager::slotMimetype):
2298         (WebCore::ResourceHandleManager::slotResult):
2299         (WebCore::ResourceHandleManager::remove):
2300         (WebCore::ResourceHandleManager::add):
2301         (WebCore::ResourceHandleManager::cancel):
2302         * platform/network/qt/ResourceHandleManager.h: Added.
2303         * platform/network/qt/ResourceHandleQt.cpp: Added.
2304         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2305         (WebCore::ResourceHandle::~ResourceHandle):
2306         (WebCore::ResourceHandle::start):
2307         (WebCore::ResourceHandle::cancel):
2308         (WebCore::ResourceHandle::assembleResponseHeaders):
2309         (WebCore::ResourceHandle::retrieveResponseEncoding):
2310         (WebCore::ResourceHandle::receivedResponse):
2311         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2312         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2313         * platform/network/qt/ResourceLoaderManager.h: Removed.
2314         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2315         * platform/network/win/ResourceHandleWin.cpp: Added.
2316         (WebCore::):
2317         (WebCore::addToOutstandingJobs):
2318         (WebCore::lookupResourceHandle):
2319         (WebCore::ResourceHandleWndProc):
2320         (WebCore::initializeOffScreenResourceHandleWindow):
2321         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2322         (WebCore::ResourceHandle::~ResourceHandle):
2323         (WebCore::ResourceHandle::onHandleCreated):
2324         (WebCore::ResourceHandle::onRequestRedirected):
2325         (WebCore::ResourceHandle::onRequestComplete):
2326         (WebCore::ResourceHandle::start):
2327         (WebCore::ResourceHandle::fileLoadTimer):
2328         (WebCore::ResourceHandle::cancel):
2329         (WebCore::ResourceHandle::setHasReceivedResponse):
2330         (WebCore::ResourceHandle::hasReceivedResponse):
2331         * platform/network/win/ResourceHandleWin.h: Added.
2332         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2333         * platform/network/win/ResourceLoaderWin.h: Removed.
2334         * platform/qt/FrameQt.cpp:
2335         * platform/qt/FrameQtClient.cpp:
2336         (WebCore::FrameQtClientDefault::openURL):
2337         (WebCore::FrameQtClientDefault::submitForm):
2338         (WebCore::FrameQtClientDefault::receivedResponse):
2339         (WebCore::FrameQtClientDefault::didReceiveData):
2340         (WebCore::FrameQtClientDefault::receivedAllData):
2341         * platform/qt/FrameQtClient.h:
2342         * platform/win/TemporaryLinkStubs.cpp:
2343         (WebCore::ResourceHandle::assembleResponseHeaders):
2344         (WebCore::ResourceHandle::retrieveResponseEncoding):
2345         (WebCore::ServeSynchronousRequest):
2346         * xml/XSLTProcessor.cpp:
2347         * xml/xmlhttprequest.cpp:
2348         (WebCore::XMLHttpRequest::send):
2349         (WebCore::XMLHttpRequest::didFinishLoading):
2350         (WebCore::XMLHttpRequest::receivedRedirect):
2351         (WebCore::XMLHttpRequest::didReceiveData):
2352         * xml/xmlhttprequest.h:
2353
2354 t2006-10-29  Darin Adler  <darin@apple.com>
2355
2356         Reviewed by Maciej.
2357
2358         - eliminate use of NSArray to carry form data around
2359
2360         * WebCore.exp:
2361         * WebCore.xcodeproj/project.pbxproj:
2362         * bridge/mac/FormDataMac.h: Removed.
2363         * bridge/mac/FormDataMac.mm: Removed.
2364         * bridge/mac/FrameMac.h:
2365         * bridge/mac/WebCoreFrameBridge.h:
2366         * bridge/mac/WebCoreFrameBridge.mm:
2367         * html/HTMLFormElement.cpp:
2368         (WebCore::HTMLFormElement::submit):
2369         * loader/FormData.h:
2370         (WebCore::FormData::isEmpty):
2371         * loader/mac/FrameLoader.h:
2372         * loader/mac/FrameLoader.mm:
2373         (WebCore::FrameLoader::load):
2374         (WebCore::FrameLoader::post):
2375         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2376         (WebCore::FrameLoader::loadResourceSynchronously):
2377         * loader/mac/LoaderFunctionsMac.mm:
2378         (WebCore::ServeSynchronousRequest):
2379         * loader/mac/WebFormDataStream.h:
2380         * loader/mac/WebFormDataStream.m:
2381         (WebCore::pairRetain):
2382         (WebCore::pairRelease):
2383         (WebCore::pairEqual):
2384         (WebCore::pairHash):
2385         (WebCore::closeCurrentStream):
2386         (WebCore::scheduleWithPair):
2387         (WebCore::advanceCurrentStream):
2388         (WebCore::openNextStream):
2389         (WebCore::formCreate):
2390         (WebCore::formFinalize):
2391         (WebCore::formOpen):
2392         (WebCore::formRead):
2393         (WebCore::formCanRead):
2394         (WebCore::formClose):
2395         (WebCore::formSchedule):
2396         (WebCore::formUnschedule):
2397         (WebCore::formEventCallback):
2398         (WebCore::setHTTPBody):
2399         * loader/mac/WebSubresourceLoader.h:
2400         * loader/mac/WebSubresourceLoader.mm:
2401         (WebCore::SubresourceLoader::create):
2402         * platform/network/mac/ResourceLoaderMac.mm:
2403
2404 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2405
2406         Reviewed by Darin.
2407
2408         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2409
2410         * loader/mac/WebSubresourceLoader.h:
2411         * loader/mac/WebSubresourceLoader.mm:
2412         (WebCore::SubresourceLoader::create):
2413         * platform/network/mac/ResourceLoaderMac.mm:
2414         (WebCore::ResourceLoader::start):
2415
2416 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2417
2418         Reviewed by Darin.
2419
2420         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2421
2422         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2423         
2424         * WebCore.xcodeproj/project.pbxproj:
2425         * bridge/mac/WebCoreFrameBridge.h:
2426         * loader/mac/FrameLoader.h:
2427         * loader/mac/FrameLoader.mm:
2428         * loader/mac/LoaderFunctionsMac.mm:
2429         * loader/mac/WebLoader.h:
2430         * loader/mac/WebSubresourceLoader.h:
2431         * loader/mac/WebSubresourceLoader.mm:
2432         (WebCore::SubresourceLoader::SubresourceLoader):
2433         (WebCore::SubresourceLoader::create):
2434         (WebCore::SubresourceLoader::willSendRequest):
2435         (WebCore::SubresourceLoader::didReceiveResponse):
2436         (WebCore::SubresourceLoader::didReceiveData):
2437         (WebCore::SubresourceLoader::didFinishLoading):
2438         (WebCore::SubresourceLoader::didFail):
2439         (WebCore::SubresourceLoader::didCancel):
2440         * platform/network/ResourceLoader.h:
2441         * platform/network/ResourceLoaderInternal.h:
2442         * platform/network/mac/ResourceLoaderMac.mm:
2443         (WebCore::ResourceLoader::~ResourceLoader):
2444         (WebCore::ResourceLoader::start):
2445         (WebCore::ResourceLoader::receivedResponse):
2446         (WebCore::ResourceLoader::cancel):
2447         (WebCore::ResourceLoader::redirectedToURL):
2448         (WebCore::ResourceLoader::addData):
2449         (WebCore::ResourceLoader::finishJobAndHandle):
2450         (WebCore::ResourceLoader::reportError):
2451         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2452         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2453         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2454
2455 2006-10-28  Darin Adler  <darin@apple.com>
2456
2457         Reviewed by Maciej.
2458
2459         - eliminated the use of Objective-C for the policy decider
2460           machinery, obviating the need for WebPolicyDecider,
2461           WebCoreFrameLoaderAsDelegate, and
2462           WebCoreMainResourceLoaderAsPolicyDelegate
2463
2464         - grouped the state related to policy decisions into a PolicyCheck
2465           class to simplify the FrameLoader logic
2466
2467         - removed six methods from the bridge, reducing FrameLoader's use of
2468           the bridge to a single method
2469
2470         - changed form state to always use HashMap instead of NSDictionary
2471
2472         - moved the defersLoading flag from WebView to WebCore::Page
2473           and changed code to consistently call it defersLoading rather
2474           than defersCallbacks
2475
2476         - updated for rename of PassRefPtr::release to releaseRef
2477         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2478         - cleaned up kjs_binding.h a bit
2479         - cleaned up FrameMac.h a bit
2480
2481         * loader/mac/WebPolicyDecider.h: Removed.
2482         * loader/mac/WebPolicyDecider.mm: Removed.
2483         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2484
2485         * WebCore.exp:
2486         * bindings/js/kjs_binding.cpp:
2487         (KJS::ScriptInterpreter::ScriptInterpreter):
2488         (KJS::ScriptInterpreter::wasRunByUserGesture):
2489         * bindings/js/kjs_binding.h:
2490         (KJS::ScriptInterpreter::setCurrentEvent):
2491         (KJS::ScriptInterpreter::setInlineCode):
2492         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2493         (KJS::ScriptInterpreter::getCurrentEvent):
2494         (KJS::cacheDOMObject):
2495         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2496         * bridge/AXObjectCache.h:
2497         * bridge/mac/BrowserExtensionMac.mm:
2498         (WebCore::BrowserExtensionMac::createNewWindow):
2499         * bridge/mac/FrameMac.h:
2500         * bridge/mac/FrameMac.mm:
2501         (WebCore::FrameMac::loadRequest):
2502         (WebCore::FrameMac::submitForm):
2503         (WebCore::FrameMac::urlSelected):
2504         (WebCore::FrameMac::userAgent):
2505         (WebCore::FrameMac::passMouseDownEventToWidget):
2506         (WebCore::FrameMac::handleMouseMoveEvent):
2507         * bridge/mac/PageMac.mm:
2508         (WebCore::Page::Page):
2509         * bridge/mac/WebCoreEditCommand.mm:
2510         * bridge/mac/WebCoreFrameBridge.h:
2511         * bridge/mac/WebCoreFrameBridge.mm:
2512         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2513         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2514         * css/CSSComputedStyleDeclaration.cpp:
2515         (WebCore::):
2516         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2517         * css/CSSPrimitiveValue.cpp:
2518         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2519         (WebCore::CSSPrimitiveValue::cleanup):
2520         (WebCore::CSSPrimitiveValue::cssText):
2521         * css/CSSPrimitiveValue.h:
2522         (WebCore::CSSPrimitiveValue::):
2523         * css/CSSValueList.cpp:
2524         (WebCore::CSSValueList::append):
2525         * css/cssparser.cpp:
2526         (WebCore::CSSParser::parseValue):
2527         * css/cssparser.h:
2528         * css/cssstyleselector.cpp:
2529         (WebCore::CSSStyleSelector::applyProperty):
2530         * dom/Document.cpp:
2531         (WebCore::Document::Document):
2532         (WebCore::Document::updateSelection):
2533         (WebCore::Document::implicitClose):
2534         (WebCore::Document::setFocusNode):
2535         * dom/Document.h:
2536         * editing/ReplaceSelectionCommand.h:
2537         * html/HTMLParser.cpp:
2538         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2539         * loader/mac/FrameLoader.h:
2540         (WebCore::PolicyCheck::request):
2541         * loader/mac/FrameLoader.mm:
2542         (WebCore::FrameLoader::~FrameLoader):
2543         (WebCore::FrameLoader::safeLoad):
2544         (WebCore::FrameLoader::load):
2545         (WebCore::FrameLoader::open):
2546         (WebCore::FrameLoader::stopLoading):
2547         (WebCore::setAllDefersLoading):
2548         (WebCore::FrameLoader::setDefersLoading):
2549         (WebCore::FrameLoader::willSendRequest):
2550         (WebCore::FrameLoader::receivedMainResourceError):
2551         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2552         (WebCore::FrameLoader::commitProvisionalLoad):
2553         (WebCore::FrameLoader::checkNavigationPolicy):
2554         (WebCore::FrameLoader::checkContentPolicy):
2555         (WebCore::FrameLoader::cancelContentPolicyCheck):
2556         (WebCore::FrameLoader::stopPolicyCheck):
2557         (WebCore::FrameLoader::checkNewWindowPolicy):
2558         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2559         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2560         (WebCore::FrameLoader::continueAfterContentPolicy):
2561         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2562         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2563         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2564         (WebCore::FrameLoader::closeDocument):
2565         (WebCore::FrameLoader::transitionToCommitted):
2566         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2567         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2568         (WebCore::FrameLoader::post):
2569         (WebCore::FrameLoader::detachFromParent):
2570         (WebCore::FrameLoader::addExtraFieldsToRequest):
2571         (WebCore::PolicyCheck::PolicyCheck):
2572         (WebCore::PolicyCheck::clear):
2573         (WebCore::PolicyCheck::set):
2574         (WebCore::PolicyCheck::call):
2575         (WebCore::PolicyCheck::dropRequest):
2576         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2577         * loader/mac/WebFormState.h:
2578         * loader/mac/WebFormState.mm:
2579         * loader/mac/WebFrameLoaderClient.h:
2580         * loader/mac/WebLoader.h:
2581         (WebCore::WebResourceLoader::defersLoading):
2582         * loader/mac/WebLoader.mm:
2583         (WebCore::WebResourceLoader::WebResourceLoader):
2584         (WebCore::WebResourceLoader::load):
2585         (WebCore::WebResourceLoader::setDefersLoading):
2586         * loader/mac/WebMainResourceLoader.h:
2587         * loader/mac/WebMainResourceLoader.mm:
2588         (WebCore::MainResourceLoader::MainResourceLoader):
2589         (WebCore::MainResourceLoader::releaseDelegate):
2590         (WebCore::MainResourceLoader::didCancel):
2591         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2592         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2593         (WebCore::MainResourceLoader::willSendRequest):
2594         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2595         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2596         (WebCore::MainResourceLoader::didReceiveResponse):
2597         (WebCore::MainResourceLoader::didReceiveData):
2598         (WebCore::MainResourceLoader::didFinishLoading):
2599         (WebCore::MainResourceLoader::didFail):
2600         (WebCore::MainResourceLoader::loadNow):
2601         (WebCore::MainResourceLoader::load):
2602         (WebCore::MainResourceLoader::setDefersLoading):
2603         * page/Frame.cpp:
2604         (WebCore::Frame::paint):
2605         * page/FrameView.cpp:
2606         (WebCore::FrameView::layout):
2607         * page/FrameView.h:
2608         * page/Page.cpp:
2609         (WebCore::Page::setDefersLoading):
2610         * page/Page.h:
2611         (WebCore::Page::defersLoading):
2612         * platform/DeprecatedString.h:
2613         * platform/DeprecatedStringList.h:
2614         * platform/FontFallbackList.h:
2615         * platform/PlatformKeyboardEvent.h:
2616         * platform/PlatformMouseEvent.h:
2617         * platform/PlatformWheelEvent.h:
2618         * platform/mac/ClipboardMac.h:
2619         * platform/mac/ClipboardMac.mm:
2620         (WebCore::ClipboardMac::setDragImage):
2621         (WebCore::ClipboardMac::dragNSImage):
2622         (WebCore::ClipboardMac::sourceOperation):
2623         (WebCore::ClipboardMac::destinationOperation):
2624         * rendering/RenderObject.cpp:
2625         (WebCore::RenderObject::setStyle):
2626         * rendering/break_lines.cpp:
2627         (WebCore::nextBreakablePosition):
2628
2629 2006-10-28  Adam Roben  <aroben@apple.com>
2630
2631         Reviewed by Maciej.
2632
2633         Fix layout tests that broke after r17399. Mitz discovered that the
2634         failures were caused by HitTestResult::m_point being uninitialized
2635         much of the time. HitTestResults are now always constructed with a
2636         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2637         point instead of being passed one explicitly.
2638
2639         * WebCore.exp: Change constructor symbol.
2640         * bridge/mac/FrameMac.mm:
2641         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2642         hitTest().
2643         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2644         * bridge/mac/WebCoreAXObject.mm:
2645         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2646         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2647         * dom/Document.cpp:
2648         (WebCore::Document::elementFromPoint): Ditto.
2649         (WebCore::Document::prepareMouseEvent): Ditto.
2650         * page/Frame.cpp:
2651         (WebCore::Frame::isPointInsideSelection): Ditto.
2652         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2653         * page/FrameView.cpp:
2654         (WebCore::FrameView::handleWheelEvent): Ditto.
2655         * rendering/HitTestResult.cpp:
2656         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2657         passed point.
2658         * rendering/HitTestResult.h: Update constructor declaration.
2659         * rendering/RenderLayer.cpp:
2660         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2661         hitTest().
2662         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2663         HitTestResult instead of being passed one.
2664         (WebCore::RenderLayer::hitTestLayer): Ditto.
2665         * rendering/RenderLayer.h: Update declarations.
2666
2667 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2668
2669         Reviewed by Anders.
2670
2671         Fix Qt/Linux build.
2672
2673         * CMakeLists.txt:
2674         * platform/qt/FrameQtClient.cpp:
2675         (WebCore::numRequests):
2676         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2677         * platform/qt/PopupMenuQt.cpp:
2678         (WebCore::PopupMenu::updateFromElement):
2679
2680 2006-10-28  David Carson  <dacarson@gmail.com>
2681
2682         Tweaked by Sam. Reviewed by Brady.
2683
2684         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2685         Initialize m_modifyBiasSet to false, as it sometimes gets 
2686         used before it has been initalized.
2687
2688         * editing/SelectionController.cpp:
2689         (WebCore::SelectionController::SelectionController):
2690
2691 2006-10-28  Beth Dakin  <bdakin@apple.com>
2692
2693         Reviewed by Darin.
2694
2695         This is the WebCore half of pushing elementAtPoint and the backend 
2696         of WebElementDictionary into WebCore. Most of the changes below are 
2697         to accommodate one of the following:
2698                 
2699         -NodeInfo is now a stand-alone class called HitTestResult. 
2700                 Previously it was defined in RenderObject.h, but not for 
2701                 any particular reason. The WebElementDictionary 
2702                 functionality that was pushed into WebCore has been pushed 
2703                 specifically into the this class. In fact, 
2704                 WebElementDictionary now keeps a HitTestResult as a member 
2705                 varibale.
2706                 
2707         -The enumeration AccessPolicy is now called 
2708                 ClipboardAccessPolicy and is defined in its own header. It 
2709                 was previously defined in ClipboardMac.h, but is now 
2710                 defined independently to avoid including ClipboardMac.h 
2711                 from within FrameMac.h since FrameMac.h is now included in 
2712                 WebElementDictionary.m in WebKit.
2713                 
2714         -Element now has a virtual target() for the sake of 
2715                 NodeInfo::targetFrame() 
2716
2717         * WebCore.exp: Several WebCore functions are newly called from 
2718         WebKit, so they have been added here. 
2719         * WebCore.xcodeproj/project.pbxproj:
2720         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
2721         to ClipboardMac.
2722         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
2723         * bridge/mac/FrameMac.mm:
2724         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
2725         and HitTestResult changes.
2726         (WebCore::FrameMac::eventMayStartDrag): Same.
2727         (WebCore::FrameMac::handleMouseMoveEvent): Same.
2728         (WebCore::FrameMac::dispatchCPPEvent): Same.
2729         (WebCore::FrameMac::mayDHTMLCut): Same.
2730         (WebCore::FrameMac::mayDHTMLCopy): Same.
2731         (WebCore::FrameMac::mayDHTMLPaste): Same.
2732         (WebCore::FrameMac::tryDHTMLCut): Same
2733         (WebCore::FrameMac::tryDHTMLCopy): Same.
2734         (WebCore::FrameMac::tryDHTMLPaste): Same.
2735         * bridge/mac/WebCoreAXObject.mm:
2736         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
2737         HitTestResult changes.
2738         (-[WebCoreAXObject accessibilityHitTest:]): Same.
2739         * bridge/mac/WebCoreFrameBridge.h: Same.
2740         * bridge/mac/WebCoreFrameBridge.mm:
2741         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
2742         ClipboardAccessPolicy changes.
2743         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
2744         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
2745         * dom/Document.cpp:
2746         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
2747         changes.
2748         (WebCore::Document::prepareMouseEvent): Same.
2749         * dom/Element.h:
2750         (WebCore::Element::target): Now has a virtual target()
2751         * html/HTMLAnchorElement.h: Same.
2752         * html/HTMLAreaElement.cpp:
2753         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
2754         changes.
2755         * html/HTMLAreaElement.h: Virtual target()
2756         * html/HTMLBaseElement.h:
2757         (WebCore::HTMLBaseElement::target): Same.
2758         * html/HTMLFormElement.h: Same.
2759         * html/HTMLLinkElement.h: Same.
2760         * html/HTMLMapElement.cpp:
2761         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
2762         changes.
2763         * html/HTMLMapElement.h: Same.
2764         * page/Frame.cpp:
2765         (WebCore::Frame::isPointInsideSelection): Same.
2766         (WebCore::Frame::hitTestResultAtPoint): Same. 
2767         * page/Frame.h: Same.
2768         * page/FrameView.cpp:
2769         (WebCore::FrameView::handleWheelEvent): Same.
2770         * platform/mac/ClipboardAccessPolicy.h: Added.
2771         (WebCore::):
2772         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
2773         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
2774         ClipboardAccessPolicy.
2775         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
2776         (WebCore::ClipboardMac::ClipboardMac):
2777         (WebCore::ClipboardMac::setAccessPolicy):
2778         (WebCore::ClipboardMac::clearData):
2779         (WebCore::ClipboardMac::clearAllData):
2780         (WebCore::ClipboardMac::getData):
2781         (WebCore::ClipboardMac::setData):
2782         (WebCore::ClipboardMac::types):
2783         (WebCore::ClipboardMac::setDragImage):
2784         (WebCore::ClipboardMac::setDropEffect):
2785         (WebCore::ClipboardMac::setEffectAllowed):
2786         * rendering/EllipsisBox.cpp:
2787         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
2788         changes.
2789         * rendering/EllipsisBox.h:
2790         * rendering/HitTestResult.cpp: Added.
2791         (WebCore::HitTestResult::HitTestResult):
2792         (WebCore::HitTestResult::~HitTestResult):
2793         (WebCore::HitTestResult::operator=):
2794         (WebCore::HitTestResult::setInnerNode):
2795         (WebCore::HitTestResult::setInnerNonSharedNode):
2796         (WebCore::HitTestResult::setURLElement):
2797         (WebCore::HitTestResult::setScrollbar):
2798         (WebCore::HitTestResult::targetFrame):
2799         (WebCore::HitTestResult::boundingBox):
2800         (WebCore::HitTestResult::isSelected):
2801         (WebCore::HitTestResult::title):
2802         * rendering/HitTestResult.h: Added.
2803         (WebCore::HitTestResult::readonly):
2804         (WebCore::HitTestResult::active):
2805         (WebCore::HitTestResult::mouseMove):
2806         (WebCore::HitTestResult::innerNode):
2807         (WebCore::HitTestResult::innerNonSharedNode):
2808         (WebCore::HitTestResult::point):
2809         (WebCore::HitTestResult::URLElement):
2810         (WebCore::HitTestResult::scrollbar):
2811         (WebCore::HitTestResult::setPoint):
2812         (WebCore::HitTestResult::setReadonly):
2813         (WebCore::HitTestResult::setActive):
2814         (WebCore::HitTestResult::setMouseMove):
2815         * rendering/InlineBox.cpp:
2816         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
2817         * rendering/InlineBox.h: Same.
2818         * rendering/InlineFlowBox.cpp:
2819         (WebCore::InlineFlowBox::nodeAtPoint): Same.
2820         * rendering/InlineFlowBox.h: Same.
2821         * rendering/InlineTextBox.cpp: 
2822         (WebCore::InlineTextBox::nodeAtPoint): Same.
2823         * rendering/InlineTextBox.h: Same.
2824         * rendering/RenderBlock.cpp:
2825         (WebCore::RenderBlock::isPointInScrollbar): Same.
2826         (WebCore::RenderBlock::nodeAtPoint): Same.
2827         * rendering/RenderBlock.h: Same.
2828         * rendering/RenderBox.cpp:
2829         (WebCore::RenderBox::nodeAtPoint): Same.
2830         * rendering/RenderBox.h: Same.
2831         * rendering/RenderFlow.cpp:
2832         (WebCore::RenderFlow::hitTestLines): Same.
2833         * rendering/RenderFlow.h: Same.
2834         * rendering/RenderForeignObject.cpp:
2835         (WebCore::RenderForeignObject::nodeAtPoint): Same.
2836         * rendering/RenderForeignObject.h: Same.
2837         * rendering/RenderFrameSet.cpp:
2838         (WebCore::RenderFrameSet::nodeAtPoint): Same.
2839         * rendering/RenderFrameSet.h: Same.
2840         * rendering/RenderImage.cpp:
2841         (WebCore::RenderImage::nodeAtPoint): Same.
2842         * rendering/RenderImage.h: Same.
2843         * rendering/RenderInline.cpp:
2844         (WebCore::RenderInline::nodeAtPoint): Same.
2845         * rendering/RenderInline.h: Same.
2846         * rendering/RenderLayer.cpp:
2847         (WebCore::RenderLayer::autoscroll): Same.
2848         (WebCore::RenderLayer::hitTest): Same.
2849         (WebCore::RenderLayer::hitTestLayer): Same.
2850         (WebCore::RenderLayer::updateHoverActiveState): Same.
2851         * rendering/RenderLayer.h: Same.
2852         * rendering/RenderListBox.cpp:
2853         (WebCore::RenderListBox::isPointInScrollbar): Same.
2854         * rendering/RenderListBox.h: Same.
2855         * rendering/RenderObject.cpp:
2856         (WebCore::RenderObject::hitTest): Same.
2857         (WebCore::RenderObject::setInnerNode): Same.
2858         (WebCore::RenderObject::nodeAtPoint): Same.
2859         * rendering/RenderObject.h: Remove NodeInfo class and forward 
2860         declare HitTestResult.
2861         * rendering/RenderPath.cpp:
2862         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
2863         changes.
2864         * rendering/RenderPath.h: Same.
2865         * rendering/RenderSVGImage.cpp:
2866         (WebCore::RenderSVGImage::nodeAtPoint): Same.
2867         * rendering/RenderSVGImage.h: Same
2868         * rendering/RenderSVGText.cpp:
2869         (WebCore::RenderSVGText::nodeAtPoint): Same.
2870         * rendering/RenderSVGText.h: Same.
2871         * rendering/RenderTableRow.cpp:
2872         (WebCore::RenderTableRow::nodeAtPoint): Same.
2873         * rendering/RenderTableRow.h: Same.
2874         * rendering/RenderTableSection.cpp:
2875         (WebCore::RenderTableSection::nodeAtPoint): Same.
2876         * rendering/RenderTableSection.h: Same.
2877         * rendering/RenderText.h: Same.
2878         (WebCore::RenderText::nodeAtPoint): Same.
2879         * rendering/RenderTextControl.cpp:
2880         (WebCore::RenderTextControl::nodeAtPoint): Same.
2881         * rendering/RenderTextControl.h: Same.
2882         * rendering/RootInlineBox.cpp:
2883         (WebCore::RootInlineBox::nodeAtPoint): Same.
2884         * rendering/RootInlineBox.h: Same.
2885
2886 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2887
2888         Reviewed by Anders.
2889
2890         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
2891         impact of fixing it again.
2892
2893         * bridge/mac/FrameMac.mm:
2894         (WebCore::FrameMac::clear):
2895
2896 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2897
2898         Reviewed by John & Adam.
2899
2900         - assorted speedups to fix perf regression from fixing correctness regression
2901
2902         * WebCore.exp: exported new methods.
2903         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
2904         * bridge/mac/WebCoreFrameBridge.h:
2905         * bridge/mac/WebCoreFrameBridge.mm:
2906         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
2907         * loader/CachedResource.h:
2908         * loader/mac/CachedResourceMac.mm: Added.
2909         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
2910         now cached in the CachedObject.
2911         * loader/mac/FrameLoader.h:
2912         * loader/mac/FrameLoader.mm:
2913         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
2914         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
2915         * loader/mac/LoaderFunctionsMac.mm:
2916         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
2917         just call loadedResourceFromMemoryCache.
2918         * loader/mac/WebFrameLoaderClient.h:
2919
2920 2006-10-27  Oliver Hunt  <oliver@apple.com>
2921
2922         Reviewed by Maciej.
2923
2924         build fix
2925
2926         * dom/Document.cpp:
2927         (WebCore::Document::referrer):
2928
2929 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2930
2931         Reviewed by Maciej.
2932
2933         Moved some WebCoreFrameBridge functions into FrameLoader.
2934         
2935         I had to make FrameLoader.h capable of compiling in C++-only source files
2936         by adding some forward declarations and __OBJC__ #ifdefs.
2937
2938         * WebCore.exp:
2939         * bridge/mac/FrameMac.h:
2940         * bridge/mac/FrameMac.mm:
2941         (WebCore::FrameMac::createEmptyDocument):
2942         (WebCore::FrameMac::tokenizerProcessedData):
2943         * bridge/mac/WebCoreFrameBridge.h:
2944         * bridge/mac/WebCoreFrameBridge.mm:
2945         * dom/Document.cpp:
2946         (WebCore::Document::processHttpEquiv):
2947         (WebCore::Document::referrer):
2948         * loader/LoaderFunctions.h:
2949         * loader/mac/FrameLoader.h:
2950         * loader/mac/FrameLoader.mm:
2951         (WebCore::numRequests):
2952         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2953         (WebCore::FrameLoader::isReloading):
2954         (WebCore::FrameLoader::referrer):
2955         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2956         (WebCore::FrameLoader::startLoadingResource):
2957         * loader/mac/LoaderFunctionsMac.mm:
2958         (WebCore::CheckIfReloading):
2959         * page/Frame.h:
2960         * page/FrameTree.cpp:
2961         (WebCore::FrameTree::isDescendantOf):
2962         (WebCore::FrameTree::traverseNext):
2963         * page/FrameTree.h:
2964         * platform/network/mac/ResourceLoaderMac.mm:
2965         (WebCore::ResourceLoader::start):
2966
2967 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2968
2969         Reviewed by Darin.
2970
2971         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2972
2973         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
2974
2975         * editing/DeleteButtonController.cpp:
2976         (WebCore::isDeletableElement):
2977         (WebCore::enclosingDeletableElement):
2978         (WebCore::DeleteButtonController::respondToChangedSelection):
2979
2980 2006-10-27  John Sullivan  <sullivan@apple.com>
2981
2982         Reviewed by Kevin Decker
2983         
2984         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
2985         you haven't not finished reading this.
2986
2987         * rendering/InlineTextBox.h:
2988         * rendering/InlineTextBox.cpp:
2989         (WebCore::InlineTextBox::paint):
2990         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
2991         considered also.
2992         (WebCore::InlineTextBox::paintDocumentMarkers):
2993         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
2994         markers should be painted, instead of a marker type. This avoids walking the collection of
2995         markers multiple times back to back. Now handles grammar markers.
2996
2997 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2998
2999         Reviewed by Beth.
3000
3001         Renamed Copy Files to Copy Generated Headers.
3002         Copy 4 DOM*Internal.h headers.
3003
3004         * WebCore.xcodeproj/project.pbxproj:
3005         * bindings/scripts/CodeGeneratorObjC.pm:
3006
3007 2006-10-27  John Sullivan  <sullivan@apple.com>
3008
3009         Reviewed by Anders
3010
3011         * WebCore.exp:
3012         exported symbol for FrameMac->advanceToNextSpelling()
3013         
3014         * bridge/mac/WebCoreFrameBridge.h:
3015         * bridge/mac/WebCoreFrameBridge.mm:
3016         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3017
3018 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3019
3020         Reviewed by harrison
3021         
3022         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3023         REGRESSION: First newline missing from textarea's value
3024         
3025         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3026         
3027         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3028         (the line break) then a br to prevent the '\n' from collapsing, since the 
3029         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3030         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3031         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3032         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3033         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3034         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3035         the shadow div will be placeholders or collapsed.
3036         
3037         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3038         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3039         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3040         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3041         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3042         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3043         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3044         before it.
3045         
3046         * editing/CompositeEditCommand.cpp:
3047         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3048         a br or '\n' if content inserted just before it will cause it to collapse.
3049         * editing/CompositeEditCommand.h:
3050         * editing/InsertLineBreakCommand.cpp:
3051         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3052         to prevent a collapse as was used for the line break.  Fixed comments.
3053         * editing/InsertTextCommand.cpp:
3054         (WebCore::InsertTextCommand::input): Call the renamed function.
3055         
3056 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3057
3058         Reviewed by Brady.
3059
3060         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3061         String became an empty NSString *, instead of nil. This will become important
3062         as we start using this conversion more.
3063         
3064         Added work-around for AppKit crash that semantic accuracy revealed.
3065         
3066         No testcase because I don't think there's a way to reflect this change
3067         in a webpage yet.
3068
3069         * platform/PlatformString.h:
3070         (WebCore::String::operator NSString*):
3071         * platform/mac/TextFieldMac.mm:
3072         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3073
3074 2006-10-27  David Harrison  <harrison@apple.com>
3075
3076         Reviewed by Maciej,
3077
3078         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3079
3080         * bridge/mac/WebCoreAXObject.mm:
3081         (blockquoteLevel):
3082         Calculate and return the blockquote level of the element.
3083         
3084         (AXAttributeStringSetBlockquoteLevel):
3085         Add, if non-zero, or clear the block quote level attribute.
3086         
3087         (AXAttributedStringAppendText):
3088         Send AXAttributeStringSetBlockquoteLevel.
3089
3090 2006-10-27  Darin Adler  <darin@apple.com>
3091
3092         - fix one error in the Qt build
3093
3094         * platform/qt/GraphicsContextQt.cpp:
3095         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3096         Updated.
3097
3098 2006-10-27  Darin Adler  <darin@apple.com>
3099
3100         Reviewed by Maciej.
3101
3102         * WebCore.exp: Export more symbols needed by WebKit.
3103
3104 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3105
3106         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3107
3108         Fixed layout test crash. Oops.
3109         
3110         * loader/mac/WebDocumentLoader.mm:
3111         (WebCore::canonicalizedTitle):
3112
3113 2006-10-26  John Sullivan  <sullivan@apple.com>
3114
3115         Reviewed by Brady
3116         
3117         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3118         
3119         This restores some of the nil-handling that was implicit before some of the code was converted from
3120         Objective-C to C++.
3121
3122         * bridge/mac/FrameMac.mm:
3123         (WebCore::FrameMac::loadRequest):
3124         handle nil FrameMac
3125         
3126         * bridge/mac/WebCoreFrameBridge.mm:
3127         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3128         handle nil Frame
3129
3130 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3131
3132         Reviewed by Darin, Maciej.
3133
3134         Removed many uses of NSString *.
3135         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
3136         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
3137         
3138         PLT says no performance regression.
3139         
3140         * WebCore.exp:
3141         * bridge/mac/WebCoreFrameBridge.mm:
3142         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3143         * loader/mac/FrameLoader.h:
3144         * loader/mac/FrameLoader.mm:
3145         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3146         (WebCore::FrameLoader::load):
3147         (WebCore::FrameLoader::canShowMIMEType):
3148         (WebCore::FrameLoader::representationExistsForURLScheme):
3149         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3150         (WebCore::FrameLoader::checkContentPolicy):
3151         (WebCore::FrameLoader::reloadAllowingStaleData):
3152         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
3153         (WebCore::FrameLoader::checkNewWindowPolicy):
3154         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3155         (WebCore::FrameLoader::transitionToCommitted):
3156         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3157         (WebCore::FrameLoader::post):
3158         * loader/mac/WebDocumentLoader.h:
3159         * loader/mac/WebDocumentLoader.mm:
3160         (WebCore::DocumentLoader::doesProgressiveLoad):
3161         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3162         (WebCore::DocumentLoader::title):
3163         (WebCore::DocumentLoader::setOverrideEncoding):
3164         (WebCore::DocumentLoader::overrideEncoding):
3165         (WebCore::DocumentLoader::setTitle):
3166         * loader/mac/WebFrameLoaderClient.h:
3167         * loader/mac/WebMainResourceLoader.mm:
3168         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3169
3170 2006-10-26  Timothy Hatcher  <timothy@apple.com>
3171
3172         Reviewed by Adam.
3173
3174         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
3175
3176         The main table at nytimes.com has a fixed width of 874px, but the table ends
3177         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
3178         this. The other bug was a missing top and left of 0px on the container element,
3179         causing the deletion UI to sometimes be offset below the table.
3180
3181         Now check for the element's renderer at the beginning of show() and
3182         return early if it is null.
3183
3184         * editing/DeleteButtonController.cpp:
3185         (WebCore::DeleteButtonController::updateOutlineStyle):
3186         (WebCore::DeleteButtonController::show):
3187
3188 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3189
3190         Build fix.
3191
3192         * html/CanvasRenderingContext2D.cpp:
3193         Include MathExtras.h
3194         
3195 2006-10-26  John Sullivan  <sullivan@apple.com>
3196
3197         Reviewed by Anders.
3198
3199         Some changes to support new grammar checking code in WebKit.
3200
3201         * WebCore.exp:
3202         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
3203         
3204         * WebCore.xcodeproj/project.pbxproj:
3205         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
3206         Made HTMLCollection.h private because Document.h uses it.
3207         
3208         * bridge/mac/WebCoreFrameBridge.h:
3209         * bridge/mac/WebCoreFrameBridge.mm:
3210         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
3211
3212 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3213
3214         Reviewed by Brady.
3215
3216         Add reverseFind to String and use it instead of findRev.
3217         Use CString instead of DeprecatedCString in one place.
3218         
3219         * html/HTMLFormElement.cpp:
3220         (WebCore::HTMLFormElement::formData):
3221         * ksvg2/svg/SVGURIReference.cpp:
3222         (WebCore::SVGURIReference::getTarget):
3223         * loader/Decoder.cpp:
3224         (WebCore::Decoder::checkForCSSCharset):
3225         * platform/PlatformString.h:
3226         (WebCore::String::reverseFind):
3227         * platform/StringImpl.cpp:
3228         (WebCore::StringImpl::reverseFind):
3229         * platform/StringImpl.h:
3230
3231 2006-10-26  John Sullivan  <sullivan@apple.com>
3232
3233         Reviewed by Darin
3234         
3235         More plumbing for grammar checking. Still no grammars is checked.
3236
3237         * dom/DocumentMarker.h:
3238         (WebCore::DocumentMarker::):
3239         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
3240         
3241         * platform/GraphicsContext.h:
3242         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
3243         now takes a bool parameter for whether it represents bad grammar or a misspelling 
3244         
3245         * platform/mac/GraphicsContextMac.mm:
3246         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3247         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
3248         an existing "assert" to "ASSERT".
3249         
3250         * rendering/InlineTextBox.h:
3251         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
3252
3253         * rendering/InlineTextBox.cpp:
3254         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3255         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
3256         bad grammar or a misspelling
3257         (WebCore::InlineTextBox::paintAllMarkersOfType):
3258         now handles markers of type Grammar
3259
3260 === Safari-521.29 ===
3261         
3262 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
3263
3264         Reviewed by Mitz.
3265
3266         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
3267         Cleanup rendering code
3268
3269         - Assorted code cleanup.
3270
3271         * rendering/AutoTableLayout.cpp:
3272         * rendering/AutoTableLayout.h:
3273         (WebCore::AutoTableLayout::totalPercent):
3274         * rendering/CounterListItem.h:
3275         * rendering/CounterNode.cpp:
3276         * rendering/CounterNode.h:
3277         (WebCore::CounterNode::~CounterNode):
3278         (WebCore::CounterNode::isReset):
3279         * rendering/CounterResetNode.cpp:
3280         * rendering/CounterResetNode.h:
3281         * rendering/DataRef.h:
3282         (WebCore::DataRef::DataRef):
3283         * rendering/DeprecatedRenderSelect.h:
3284         * rendering/DeprecatedSlider.cpp:
3285         * rendering/DeprecatedSlider.h:
3286         * rendering/EllipsisBox.cpp:
3287         * rendering/EllipsisBox.h:
3288         (WebCore::EllipsisBox::EllipsisBox):
3289         * rendering/FixedTableLayout.cpp:
3290         * rendering/FixedTableLayout.h:
3291         * rendering/GapRects.h:
3292         * rendering/InlineBox.cpp:
3293         * rendering/InlineBox.h:
3294         (WebCore::InlineBox::InlineBox):
3295         (WebCore::InlineBox::setConstructed):
3296         (WebCore::InlineBox::clearTruncation):
3297         (WebCore::InlineBox::markDirty):
3298         * rendering/InlineFlowBox.cpp:
3299         * rendering/InlineFlowBox.h:
3300         (WebCore::InlineFlowBox::InlineFlowBox):
3301         (WebCore::InlineFlowBox::setConstructed):
3302         (WebCore::InlineFlowBox::setEdges):
3303         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
3304         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
3305         * rendering/InlineRunBox.h:
3306         (WebCore::InlineRunBox::paintBackgroundAndBorder):
3307         (WebCore::InlineRunBox::paintDecorations):
3308         * rendering/InlineTextBox.cpp:
3309         * rendering/InlineTextBox.h:
3310         (WebCore::InlineTextBox::InlineTextBox):
3311         (WebCore::InlineTextBox::end):
3312         (WebCore::InlineTextBox::textObject):
3313         * rendering/Length.h:
3314         (WebCore::Length::Length):
3315         * rendering/ListMarkerBox.cpp:
3316         * rendering/ListMarkerBox.h:
3317         * rendering/RenderPartObject.h:
3318         * rendering/RootInlineBox.cpp:
3319         * rendering/RootInlineBox.h:
3320         * rendering/SVGInlineFlowBox.cpp:
3321         * rendering/SVGInlineFlowBox.h:
3322         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
3323         * rendering/SVGRootInlineBox.cpp:
3324         * rendering/SVGRootInlineBox.h:
3325         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
3326         * rendering/TableLayout.h:
3327         (WebCore::TableLayout::TableLayout):
3328         (WebCore::TableLayout::~TableLayout):
3329         * rendering/bidi.h:
3330         (WebCore::BidiStatus::BidiStatus):
3331         (WebCore::BidiRun::BidiRun):
3332         * rendering/break_lines.h:
3333
3334 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
3335
3336         Reviewed by john
3337
3338         <http://bugs.webkit.org/show_bug.cgi?id=11329>
3339         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
3340         
3341         * editing/Editor.cpp:
3342         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
3343         Wrapped the plain text fragment in a style span with the document 
3344         default style so that it will appear unstyled regardless of where
3345         it is inserted.  Could have also inserted the plain text fragment 
3346         and then applied the document default style to it, but there is not 
3347         yet any redundant style prevention in ApplyStyleCommand, so this
3348         is cleaner.
3349         * editing/Editor.h:
3350         * editing/JSEditor.cpp:
3351
3352 2006-10-26  Oliver Hunt  <oliver@apple.com>
3353
3354         Reviewed by Anders.
3355         Fixes <rdar://problem/4800518> -- needed to update existing
3356         canvas path elements when transforms are performed on the
3357         context.
3358
3359         * html/CanvasRenderingContext2D.cpp:
3360         (WebCore::CanvasRenderingContext2D::scale):
3361         (WebCore::CanvasRenderingContext2D::rotate):
3362         (WebCore::CanvasRenderingContext2D::translate):
3363
3364 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
3365
3366         Reviewed by Darin.
3367
3368         Fix Qt/Linux build.
3369
3370         * platform/network/qt/ResourceLoaderManager.cpp:
3371         (WebCore::ResourceLoaderManager::slotData):
3372         (WebCore::ResourceLoaderManager::slotMimetype):
3373         (WebCore::ResourceLoaderManager::remove):
3374         (WebCore::ResourceLoaderManager::add):
3375         * platform/network/qt/ResourceLoaderQt.cpp:
3376         (WebCore::ResourceLoader::receivedResponse):
3377         * platform/qt/FrameQtClient.cpp:
3378         (WebCore::FrameQtClientDefault::openURL):
3379         * platform/qt/LoaderFunctionsQt.cpp:
3380         (WebCore::ServeSynchronousRequest):
3381
3382 2006-10-26  Adam Roben  <aroben@apple.com>
3383
3384         Reviewed by Adele.
3385
3386         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
3387         boxes (<select> elements)
3388         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
3389         should have type-ahead selection without popping up menu
3390
3391         * WebCore.xcodeproj/project.pbxproj: Version wars.
3392         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
3393         find.
3394         * html/HTMLSelectElement.cpp:
3395         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
3396         instance variables.
3397         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
3398         find on printable character presses.
3399         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
3400         redundant check that the listIndex has changed (setSelectedIndex does
3401         this for us), and fix indentation.
3402         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
3403         to an else-if.
3404         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
3405         to strip leading whitespace (including non-breaking spaces) from a
3406         string.
3407         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
3408         type-ahead find.
3409         * platform/PopupMenu.h: Added new updateFromElement() method to be
3410         called from RenderMenuList::updateFromElement().
3411         * platform/mac/PopupMenuMac.mm:
3412         (WebCore::PopupMenu::updateFromElement): While we are using
3413         NSPopUpButtonCell for our popups, this method can stay empty.
3414         * rendering/RenderListBox.cpp:
3415         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
3416         selected element.
3417         * rendering/RenderMenuList.cpp:
3418         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
3419         if it's visible.
3420
3421 2006-10-26  Darin Adler  <darin@apple.com>
3422
3423         Reviewed by Anders.
3424
3425         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
3426           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
3427
3428         * editing/ReplaceSelectionCommand.cpp:
3429         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
3430         Use two vectors instead of a hash map: more efficient, deterministic. There was no
3431         reason to use a hash table.
3432
3433 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
3434
3435         Reviewed by Anders.
3436
3437         - .5% speed improvement by avoiding excess CFURLRef allocation
3438
3439         * loader/CachedResource.cpp:
3440         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
3441         here for later reuse.
3442         * loader/CachedResource.h:
3443         * loader/mac/LoaderFunctionsMac.mm:
3444         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
3445
3446 2006-10-25  Darin Adler  <darin@apple.com>
3447
3448         Reviewed by Anders.
3449
3450         - removed 55 methods from WebCoreFrameBridge
3451         - changed callers to use Frame directly instead
3452         - put FrameLoaderTypes.h types into the WebCore namespace
3453         - first steps to get FrameLoader.h ready for cross-platform duty
3454
3455         * WebCore.exp:
3456         * WebCore.xcodeproj/project.pbxproj:
3457         * bridge/mac/BrowserExtensionMac.mm:
3458         (WebCore::BrowserExtensionMac::createNewWindow):
3459         * bridge/mac/FrameMac.h:
3460         * bridge/mac/FrameMac.mm:
3461         (WebCore::FrameMac::loadRequest):
3462         (WebCore::FrameMac::startRedirectionTimer):
3463         (WebCore::FrameMac::stopRedirectionTimer):
3464         (WebCore::FrameMac::passSubframeEventToSubframe):
3465         (WebCore::FrameMac::handledOnloadEvents):
3466         (WebCore::FrameMac::isLoadTypeReload):
3467         * bridge/mac/WebCoreFrameBridge.h:
3468         * bridge/mac/WebCoreFrameBridge.mm:
3469         (-[WebCoreFrameBridge executionContextForView:]):
3470         (updateRenderingForBindings):
3471         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3472         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
3473         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3474         (-[WebCoreFrameBridge installInFrame:]):
3475         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
3476         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3477         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
3478         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3479         (stringByCollapsingNonPrintingCharacters):
3480         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3481         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3482         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3483         * loader/FrameLoaderTypes.h:
3484         * loader/mac/FrameLoader.h:
3485         * loader/mac/FrameLoader.mm:
3486         (WebCore::FrameLoader::FrameLoader):
3487         (WebCore::FrameLoader::setupForReplace):
3488         (WebCore::FrameLoader::load):
3489         (WebCore::FrameLoader::activeDocumentLoader):
3490         (WebCore::FrameLoader::state):
3491         (WebCore::FrameLoader::setState):
3492         (WebCore::FrameLoader::clearProvisionalLoad):
3493         (WebCore::FrameLoader::markLoadComplete):
3494         (WebCore::FrameLoader::commitProvisionalLoad):
3495         (WebCore::FrameLoader::receivedMainResourceError):
3496         (WebCore::FrameLoader::handleFallbackContent):
3497         (WebCore::FrameLoader::isLoadingMainFrame):
3498         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3499         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3500         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3501         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3502         (WebCore::FrameLoader::transitionToCommitted):
3503         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3504         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3505         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
3506         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
3507         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
3508         * loader/mac/ImageDocumentMac.mm:
3509         (WebCore::finishImageLoad):
3510         * loader/mac/WebDocumentLoader.mm:
3511         (WebCore::DocumentLoader::isLoadingInAPISense):
3512         * loader/mac/WebMainResourceLoader.h:
3513         * loader/mac/WebMainResourceLoader.mm:
3514         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3515         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
3516         * loader/mac/WebSubresourceLoader.mm:
3517         (-[WebCoreSubresourceHandle initWithLoader:]):
3518         * platform/mac/ListBoxMac.mm:
3519         (-[WebCoreTableView keyDown:]):
3520         (-[WebCoreTableView keyUp:]):
3521         * platform/mac/WebCoreTextField.mm:
3522         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
3523
3524 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
3525
3526         Reviewed by Darin.
3527
3528         Printing fixes