WebCore/ChangeLog

   1 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
   2
   3         Attempt to fix Qt build.
   4
   5         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
   6
   7 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
   8
   9         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
  10
  11         [CSS 3] support for vertical-text, cell and context-menu cursors
  12         http://bugs.webkit.org/show_bug.cgi?id=11494
  13
  14         * Resources/cellCursor.png: Added.
  15         * Resources/contextMenuCursor.png: Added.
  16         * Resources/verticalTextCursor.png: Added.
  17         * WebCore.xcodeproj/project.pbxproj:
  18         * css/CSSComputedStyleDeclaration.cpp:
  19         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  20         * css/CSSValueKeywords.in:
  21         * manual-tests/cursor.html:
  22         * page/FrameView.cpp:
  23         (WebCore::selectCursor):
  24         * platform/Cursor.h:
  25         * platform/mac/CursorMac.mm:
  26         (WebCore::verticalTextCursor):
  27         (WebCore::cellCursor):
  28         (WebCore::contextMenuCursor):
  29         * rendering/RenderStyle.h:
  30         (WebCore::):
  31
  32 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
  33
  34         Reviewed by aroben and ap, landed by ap.
  35
  36         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
  37
  38         Group graphics related files in platform/graphics.
  39         Move certain files from certain subdirectories
  40         into platform/graphics/{win,mac,cg,gdk,qt}
  41
  42         * CMakeLists.txt:
  43         * WebCore.xcodeproj/project.pbxproj:
  44         * platform/AffineTransform.cpp: Removed.
  45         * platform/AffineTransform.h: Removed.
  46         * platform/Color.cpp: Removed.
  47         * platform/Color.h: Removed.
  48         * platform/FloatPoint.cpp: Removed.
  49         * platform/FloatPoint.h: Removed.
  50         * platform/FloatRect.cpp: Removed.
  51         * platform/FloatRect.h: Removed.
  52         * platform/FloatSize.cpp: Removed.
  53         * platform/FloatSize.h: Removed.
  54         * platform/Icon.h: Removed.
  55         * platform/Image.cpp: Removed.
  56         * platform/Image.h: Removed.
  57         * platform/ImageSource.h: Removed.
  58         * platform/IntPoint.h: Removed.
  59         * platform/IntRect.cpp: Removed.
  60         * platform/IntRect.h: Removed.
  61         * platform/IntSize.h: Removed.
  62         * platform/IntSizeHash.h: Removed.
  63         * platform/Path.cpp: Removed.
  64         * platform/Path.h: Removed.
  65         * platform/Pen.cpp: Removed.
  66         * platform/Pen.h: Removed.
  67         * platform/cairo/AffineTransformCairo.cpp: Removed.
  68         * platform/cairo/GraphicsContextCairo.cpp: Removed.
  69         * platform/cairo/ImageCairo.cpp: Removed.
  70         * platform/cairo/ImageSourceCairo.cpp: Removed.
  71         * platform/cairo/cairo/AUTHORS: Removed.
  72         * platform/cairo/cairo/COPYING: Removed.
  73         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
  74         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
  75         * platform/cairo/cairo/INSTALL: Removed.
  76         * platform/cairo/cairo/NEWS: Removed.
  77         * platform/cairo/cairo/README: Removed.
  78         * platform/cairo/cairo/TODO: Removed.
  79         * platform/cairo/cairo/src/Makefile.in: Removed.
  80         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
  81         * platform/cairo/cairo/src/cairo-arc.c: Removed.
  82         * platform/cairo/cairo/src/cairo-array.c: Removed.
  83         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
  84         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
  85         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
  86         * platform/cairo/cairo/src/cairo-beos.h: Removed.
  87         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
  88         * platform/cairo/cairo/src/cairo-cache.c: Removed.
  89         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
  90         * platform/cairo/cairo/src/cairo-clip.c: Removed.
  91         * platform/cairo/cairo/src/cairo-color.c: Removed.
  92         * platform/cairo/cairo/src/cairo-debug.c: Removed.
  93         * platform/cairo/cairo/src/cairo-debug.h: Removed.
  94         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
  95         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
  96         * platform/cairo/cairo/src/cairo-features.h: Removed.
  97         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
  98         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
  99         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
 100         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
 101         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
 102         * platform/cairo/cairo/src/cairo-font.c: Removed.
 103         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
 104         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
 105         * platform/cairo/cairo/src/cairo-ft.h: Removed.
 106         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
 107         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
 108         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
 109         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
 110         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
 111         * platform/cairo/cairo/src/cairo-hash.c: Removed.
 112         * platform/cairo/cairo/src/cairo-hull.c: Removed.
 113         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
 114         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
 115         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
 116         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
 117         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
 118         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
 119         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
 120         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
 121         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
 122         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
 123         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
 124         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
 125         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
 126         * platform/cairo/cairo/src/cairo-path.c: Removed.
 127         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
 128         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
 129         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
 130         * platform/cairo/cairo/src/cairo-pen.c: Removed.
 131         * platform/cairo/cairo/src/cairo-platform.h: Removed.
 132         * platform/cairo/cairo/src/cairo-png.c: Removed.
 133         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
 134         * platform/cairo/cairo/src/cairo-private.h: Removed.
 135         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
 136         * platform/cairo/cairo/src/cairo-ps.h: Removed.
 137         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
 138         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
 139         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
 140         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
 141         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
 142         * platform/cairo/cairo/src/cairo-region.c: Removed.
 143         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
 144         * platform/cairo/cairo/src/cairo-slope.c: Removed.
 145         * platform/cairo/cairo/src/cairo-spline.c: Removed.
 146         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
 147         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
 148         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
 149         * platform/cairo/cairo/src/cairo-surface.c: Removed.
 150         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
 151         * platform/cairo/cairo/src/cairo-svg.h: Removed.
 152         * platform/cairo/cairo/src/cairo-traps.c: Removed.
 153         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
 154         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
 155         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
 156         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
 157         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
 158         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
 159         * platform/cairo/cairo/src/cairo-win32.h: Removed.
 160         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
 161         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
 162         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
 163         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
 164         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
 165         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
 166         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
 167         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
 168         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
 169         * platform/cairo/cairo/src/cairo.c: Removed.
 170         * platform/cairo/cairo/src/cairo.h: Removed.
 171         * platform/cairo/cairo/src/cairoint.h: Removed.
 172         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
 173         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
 174         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
 175         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
 176         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
 177         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
 178         * platform/cairo/pixman/AUTHORS: Removed.
 179         * platform/cairo/pixman/COPYING: Removed.
 180         * platform/cairo/pixman/README: Removed.
 181         * platform/cairo/pixman/src/Makefile.in: Removed.
 182         * platform/cairo/pixman/src/fbcompose.c: Removed.
 183         * platform/cairo/pixman/src/fbedge.c: Removed.
 184         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
 185         * platform/cairo/pixman/src/fbmmx.c: Removed.
 186         * platform/cairo/pixman/src/fbmmx.h: Removed.
 187         * platform/cairo/pixman/src/fbpict.c: Removed.
 188         * platform/cairo/pixman/src/fbpict.h: Removed.
 189         * platform/cairo/pixman/src/fbtrap.c: Removed.
 190         * platform/cairo/pixman/src/icblt.c: Removed.
 191         * platform/cairo/pixman/src/icbltone.c: Removed.
 192         * platform/cairo/pixman/src/iccolor.c: Removed.
 193         * platform/cairo/pixman/src/icformat.c: Removed.
 194         * platform/cairo/pixman/src/icimage.c: Removed.
 195         * platform/cairo/pixman/src/icimage.h: Removed.
 196         * platform/cairo/pixman/src/icint.h: Removed.
 197         * platform/cairo/pixman/src/icpixels.c: Removed.
 198         * platform/cairo/pixman/src/icrect.c: Removed.
 199         * platform/cairo/pixman/src/icrop.h: Removed.
 200         * platform/cairo/pixman/src/icstipple.c: Removed.
 201         * platform/cairo/pixman/src/ictransform.c: Removed.
 202         * platform/cairo/pixman/src/ictrap.c: Removed.
 203         * platform/cairo/pixman/src/ictri.c: Removed.
 204         * platform/cairo/pixman/src/icutil.c: Removed.
 205         * platform/cairo/pixman/src/pixman-remap.h: Removed.
 206         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
 207         * platform/cairo/pixman/src/pixman.h: Removed.
 208         * platform/cairo/pixman/src/pixregion.c: Removed.
 209         * platform/cairo/pixman/src/pixregionint.h: Removed.
 210         * platform/cairo/pixman/src/renderedge.c: Removed.
 211         * platform/cairo/pixman/src/renderedge.h: Removed.
 212         * platform/cairo/pixman/src/slim_internal.h: Removed.
 213         * platform/cairo/rgb24-hacks.txt: Removed.
 214         * platform/cairo/scale-removal.txt: Removed.
 215         * platform/cg/AffineTransformCG.cpp: Removed.
 216         * platform/cg/FloatPointCG.cpp: Removed.
 217         * platform/cg/FloatRectCG.cpp: Removed.
 218         * platform/cg/FloatSizeCG.cpp: Removed.
 219         * platform/cg/GraphicsContextCG.cpp: Removed.
 220         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
 221         * platform/cg/ImageCG.cpp: Removed.
 222         * platform/cg/ImageSourceCG.cpp: Removed.
 223         * platform/cg/IntPointCG.cpp: Removed.
 224         * platform/cg/IntRectCG.cpp: Removed.
 225         * platform/cg/IntSizeCG.cpp: Removed.
 226         * platform/cg/PDFDocumentImage.cpp: Removed.
 227         * platform/cg/PDFDocumentImage.h: Removed.
 228         * platform/cg/PathCG.cpp: Removed.
 229         * platform/gdk/ImageGdk.cpp: Removed.
 230         * platform/mac/ColorMac.mm: Removed.
 231         * platform/mac/FloatPointMac.mm: Removed.
 232         * platform/mac/FloatRectMac.mm: Removed.
 233         * platform/mac/FloatSizeMac.mm: Removed.
 234         * platform/mac/GraphicsContextMac.mm:
 235         * platform/mac/IconMac.mm: Removed.
 236         * platform/mac/ImageMac.mm: Removed.
 237         * platform/mac/IntPointMac.mm: Removed.
 238         * platform/mac/IntRectMac.mm: Removed.
 239         * platform/mac/IntSizeMac.mm: Removed.
 240         * platform/qt/AffineTransformQt.cpp: Removed.
 241         * platform/qt/ColorQt.cpp: Removed.
 242         * platform/qt/FloatPointQt.cpp: Removed.
 243         * platform/qt/FloatRectQt.cpp: Removed.
 244         * platform/qt/IconQt.cpp: Removed.
 245         * platform/qt/ImageQt.cpp: Removed.
 246         * platform/qt/ImageSourceQt.cpp: Removed.
 247         * platform/qt/IntPointQt.cpp: Removed.
 248         * platform/qt/IntRectQt.cpp: Removed.
 249         * platform/qt/IntSizeQt.cpp: Removed.
 250         * platform/qt/PathQt.cpp: Removed.
 251         * platform/win/ImageWin.cpp: Removed.
 252         * platform/win/IntPointWin.cpp: Removed.
 253         * platform/win/IntRectWin.cpp: Removed.
 254         * platform/win/IntSizeWin.cpp: Removed.
 255
 256 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
 257
 258         Reviewed by hyatt.
 259
 260         A layout test was added when this bug was fixed, so none needed now.
 261
 262         Cleanup after:
 263         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
 264         http://bugs.webkit.org/show_bug.cgi?id=11570
 265
 266         * rendering/RenderStyle.h:
 267         (WebCore::RenderStyle::isSpace): Removed.
 268         * rendering/RenderText.cpp:
 269         (WebCore::isSpace): Added.
 270         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
 271
 272 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
 273
 274         Reviewed by mitz.
 275
 276         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
 277         http://bugs.webkit.org/show_bug.cgi?id=11570
 278
 279         * rendering/RenderStyle.h:
 280         (WebCore::RenderStyle::isSpace): Added.
 281         * rendering/RenderText.cpp:
 282         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths,
 283         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
 284
 285 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
 286
 287         Reviewed by Maciej.
 288
 289         Added basic types for symbian platform.
 290         http://bugs.webkit.org/show_bug.cgi?id=11540
 291
 292         * config.h:
 293         * platform/AtomicString.h:
 294         (WebCore::AtomicString::AtomicString):
 295         (WebCore::AtomicString::operator TPtrC):
 296         * platform/DeprecatedString.cpp:
 297         (WebCore::initializeHandleNodeBlock):
 298         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
 299           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
 300           bitfields and breaks byte aligment
 301         * platform/FloatPoint.h:
 302         * platform/FloatRect.h:
 303         * platform/IntPoint.h:
 304         * platform/IntRect.h:
 305         * platform/IntSize.h:
 306         * platform/PlatformString.h:
 307         (WebCore::String::operator TPtrC):
 308         (WebCore::String::des):
 309         * platform/StringImpl.h:
 310         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
 311         (WebCore::DeprecatedString::setBufferFromDes):
 312         (WebCore::DeprecatedString::fromDes):
 313         (WebCore::DeprecatedString::des):
 314         (WebCore::DeprecatedString::des8):
 315         * platform/symbian/FloatPointSymbian.cpp: Added.
 316         (WebCore::FloatPoint::FloatPoint):
 317         (WebCore::FloatPoint::operator TPoint):
 318         * platform/symbian/FloatRectSymbian.cpp: Added.
 319         (WebCore::FloatRect::FloatRect):
 320         (WebCore::FloatRect::operator TRect):
 321         (WebCore::FloatRect::rect):
 322         * platform/symbian/IntPointSymbian.cpp: Added.
 323         (WebCore::IntPoint::IntPoint):
 324         (WebCore::IntPoint::operator TPoint):
 325         * platform/symbian/IntRectSymbian.cpp: Added.
 326         (WebCore::IntRect::IntRect):
 327         (WebCore::IntRect::operator TRect):
 328         (WebCore::IntRect::Rect):
 329         * platform/symbian/IntSizeSymbian.cpp: Added.
 330         (WebCore::IntSize::IntSize):
 331         (WebCore::IntSize::operator TSize):
 332         * platform/symbian/StringImplSymbian.cpp: Added.
 333         (WebCore::StringImpl::StringImpl):
 334         (WebCore::StringImpl::des):
 335         * platform/symbian/StringSymbian.cpp: Added.
 336         (WebCore::String::String):
 337
 338 2006-11-10  Zack Rusin  <zack@kde.org>
 339
 340         Reviewed by Anders.
 341
 342         Adjust to the changes Brady made in the Qt code.
 343
 344         * loader/qt/FrameLoaderClientQt.cpp:
 345         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
 346         * loader/qt/FrameLoaderClientQt.h:
 347
 348 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
 349
 350         Reviewed by harrison
 351
 352         <rdar://problem/4069359>
 353         Deleting hyperlink text, then typing uses link typing style but loses the link itself
 354
 355         The removed anchor element needs to stick around temporarily, in the same way
 356         that the typing style hangs off the caret until the user moves it.  Also text
 357         insertion around anchors didn't match TextEdit.
 358
 359         * editing/DeleteSelectionCommand.cpp:
 360         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
 361         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
 362         * editing/DeleteSelectionCommand.h:
 363         * editing/EditCommand.cpp:
 364         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
 365         editing command that doesn't preserve the typing style (matches TextEdit).
 366         * editing/Editor.cpp:
 367         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call
 368         setSelection with a message telling it to clear the typing style
 369         (and the saved anchor) here.  Save/restore the saved anchor because of this.
 370         * editing/Editor.h:
 371         (WebCore::Editor::removedAnchor): Getter.
 372         (WebCore::Editor::setRemovedAnchor): Setter.
 373         * editing/InsertTextCommand.cpp:
 374         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
 375         if one exists.
 376         * editing/SelectionController.cpp:
 377         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
 378         we make a selection change that clears the typing style.
 379         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
 380         * editing/htmlediting.cpp:
 381         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
 382         made some changes to match TextEdit's behavior.  First, insert content
 383         inside the anchor when the caret is after it, unless the caret is at the
 384         end of the document, or if the caret is before it and at the start of a
 385         paragraph.
 386
 387 === Safari-521.30 ===
 388
 389 2006-11-10  Timothy Hatcher  <timothy@apple.com>
 390
 391         Reviewed by Hyatt.
 392
 393         Check for BHIDDEN in isVisible() also.
 394
 395         * rendering/RenderStyle.h:
 396         (WebCore::BorderValue::isVisible):
 397
 398 2006-11-10  Timothy Hatcher  <timothy@apple.com>
 399
 400         Reviewed by Adam.
 401
 402         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
 403
 404         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
 405
 406         * editing/DeleteButtonController.cpp:
 407         (WebCore::isDeletableElement):
 408         * rendering/RenderStyle.h:
 409         (WebCore::BorderValue::isVisible):
 410
 411 2006-11-10  Adam Roben  <aroben@apple.com>
 412
 413         Rubberstamped by Anders.
 414
 415         Back out some accidentally-committed changes from r17711.
 416
 417         * page/Frame.cpp:
 418         (WebCore::Frame::command):
 419         (WebCore::FramePrivate::FramePrivate):
 420         * page/Frame.h:
 421         * page/FramePrivate.h:
 422
 423 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
 424
 425         Reviewed by Geoff.
 426
 427         Add more commands, make toggleBold and toggleItalic executable commands.
 428
 429         * WebCore.exp:
 430         * editing/Editor.cpp:
 431         (WebCore::execCopy):
 432         (WebCore::execCut):
 433         (WebCore::execDelete):
 434         (WebCore::execForwardDelete):
 435         (WebCore::execPaste):
 436         (WebCore::execSelectAll):
 437         (WebCore::execToggleBold):
 438         (WebCore::execToggleItalic):
 439         (WebCore::enabled):
 440         (WebCore::canPaste):
 441         (WebCore::hasEditableSelection):
 442         (WebCore::hasEditableRangeSelection):
 443         (WebCore::hasRangeSelection):
 444         (WebCore::hasRichlyEditableSelection):
 445         (WebCore::CommandEntry::):
 446         * editing/Editor.h:
 447
 448 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
 449
 450         Reviewed by Maciej, Geoff.
 451
 452         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
 453         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
 454
 455         * WebCore.exp:
 456         * bridge/mac/WebCoreFrameBridge.h:
 457         * bridge/mac/WebCoreFrameBridge.mm:
 458         * editing/Editor.cpp:
 459         (WebCore::execMoveBackward):
 460         (WebCore::execMoveBackwardAndModifySelection):
 461         (WebCore::execMoveDown):
 462         (WebCore::execMoveDownAndModifySelection):
 463         (WebCore::execMoveForward):
 464         (WebCore::execMoveForwardAndModifySelection):
 465         (WebCore::execMoveLeft):
 466         (WebCore::execMoveLeftAndModifySelection):
 467         (WebCore::execMoveRight):
 468         (WebCore::execMoveRightAndModifySelection):
 469         (WebCore::execMoveToBeginningOfDocument):
 470         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
 471         (WebCore::execMoveToBeginningOfSentence):
 472         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
 473         (WebCore::execMoveToBeginningOfLine):
 474         (WebCore::execMoveToBeginningOfLineAndModifySelection):
 475         (WebCore::execMoveToBeginningOfParagraph):
 476         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
 477         (WebCore::execMoveToEndOfDocument):
 478         (WebCore::execMoveToEndOfDocumentAndModifySelection):
 479         (WebCore::execMoveToEndOfSentence):
 480         (WebCore::execMoveToEndOfSentenceAndModifySelection):
 481         (WebCore::execMoveToEndOfLine):
 482         (WebCore::execMoveToEndOfLineAndModifySelection):
 483         (WebCore::execMoveToEndOfParagraph):
 484         (WebCore::execMoveToEndOfParagraphAndModifySelection):
 485         (WebCore::execMoveParagraphBackwardAndModifySelection):
 486         (WebCore::execMoveParagraphForwardAndModifySelection):
 487         (WebCore::execMoveUp):
 488         (WebCore::execMoveUpAndModifySelection):
 489         (WebCore::execMoveWordBackward):
 490         (WebCore::execMoveWordBackwardAndModifySelection):
 491         (WebCore::execMoveWordForward):
 492         (WebCore::execMoveWordForwardAndModifySelection):
 493         (WebCore::execMoveWordLeft):
 494         (WebCore::execMoveWordLeftAndModifySelection):
 495         (WebCore::execMoveWordRight):
 496         (WebCore::execMoveWordRightAndModifySelection):
 497         (WebCore::enabledAnySelection):
 498         (WebCore::createCommandMap):
 499         (WebCore::CommandEntry::):
 500         (WebCore::Editor::execCommand):
 501         * editing/Editor.h:
 502
 503 2006-11-10  Brady Eidson  <beidson@apple.com>
 504
 505         Reviewed by Darin
 506
 507         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
 508
 509         * WebCore.exp:
 510         * WebCore.xcodeproj/project.pbxproj:
 511         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
 512         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
 513         * loader/FrameLoaderClient.h:
 514         * loader/icon/IconDatabase.cpp:
 515         (WebCore::IconDatabase::sharedIconDatabase):
 516         (WebCore::IconDatabase::~IconDatabase):
 517         * loader/icon/IconDatabase.h:
 518         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
 519         (WebCore::IconDatabase::enabled):
 520         * loader/icon/IconLoader.cpp:
 521         (WebCore::IconLoader::finishLoading):
 522         * loader/mac/FrameLoaderMac.mm:
 523
 524 2006-11-10  Zack Rusin  <zack@kde.org>
 525
 526         Reviewed and landed by Anders.
 527
 528         Adjust platform Qt/KDE code to the recent loader
 529         changes.
 530
 531         * CMakeLists.txt:
 532         * loader/DocumentLoader.h:
 533         * loader/FrameLoader.cpp:
 534         (WebCore::FrameLoader::createEmptyDocument):
 535         * loader/FrameLoader.h:
 536         * loader/FrameLoaderClient.h:
 537         * loader/qt/DocumentLoaderQt.cpp: Added.
 538         (WebCore::canonicalizedTitle):
 539         (WebCore::DocumentLoader::DocumentLoader):
 540         (WebCore::DocumentLoader::frameLoader):
 541         (WebCore::DocumentLoader::~DocumentLoader):
 542         (WebCore::DocumentLoader::URL):
 543         (WebCore::DocumentLoader::unreachableURL):
 544         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
 545         (WebCore::DocumentLoader::isStopping):
 546         (WebCore::DocumentLoader::clearErrors):
 547         (WebCore::DocumentLoader::stopLoading):
 548         (WebCore::DocumentLoader::setupForReplace):
 549         (WebCore::DocumentLoader::commitIfReady):
 550         (WebCore::DocumentLoader::finishedLoading):
 551         (WebCore::DocumentLoader::setCommitted):
 552         (WebCore::DocumentLoader::isCommitted):
 553         (WebCore::DocumentLoader::setLoading):
 554         (WebCore::DocumentLoader::isLoading):
 555         (WebCore::DocumentLoader::doesProgressiveLoad):
 556         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
 557         (WebCore::DocumentLoader::updateLoading):
 558         (WebCore::DocumentLoader::setFrame):
 559         (WebCore::DocumentLoader::attachToFrame):
 560         (WebCore::DocumentLoader::detachFromFrame):
 561         (WebCore::DocumentLoader::prepareForLoadStart):
 562         (WebCore::DocumentLoader::loadingStartedTime):
 563         (WebCore::DocumentLoader::setIsClientRedirect):
 564         (WebCore::DocumentLoader::isClientRedirect):
 565         (WebCore::DocumentLoader::setPrimaryLoadComplete):
 566         (WebCore::DocumentLoader::isLoadingInAPISense):
 567         (WebCore::DocumentLoader::stopRecordingResponses):
 568         (WebCore::DocumentLoader::title):
 569         (WebCore::DocumentLoader::triggeringAction):
 570         (WebCore::DocumentLoader::setTriggeringAction):
 571         (WebCore::DocumentLoader::setOverrideEncoding):
 572         (WebCore::DocumentLoader::overrideEncoding):
 573         (WebCore::DocumentLoader::setTitle):
 574         (WebCore::DocumentLoader::URLForHistory):
 575         * loader/qt/FrameLoaderClientQt.cpp: Added.
 576         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
 577         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
 578         (WebCore::FrameLoaderClientQt::detachFrameLoader):
 579         (WebCore::FrameLoaderClientQt::hasWebView):
 580         (WebCore::FrameLoaderClientQt::hasFrameView):
 581         (WebCore::FrameLoaderClientQt::hasBackForwardList):
 582         (WebCore::FrameLoaderClientQt::resetBackForwardList):
 583         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
 584         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
 585         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
 586         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
 587         (WebCore::FrameLoaderClientQt::makeDocumentView):
 588         (WebCore::FrameLoaderClientQt::makeRepresentation):
 589         (WebCore::FrameLoaderClientQt::forceLayout):
 590         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
 591         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
 592         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
 593         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
 594         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
 595         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
 596         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
 597         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
 598         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
 599         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
 600         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
 601         (WebCore::FrameLoaderClientQt::willCloseDocument):
 602         (WebCore::FrameLoaderClientQt::detachedFromParent1):
 603         (WebCore::FrameLoaderClientQt::detachedFromParent2):
 604         (WebCore::FrameLoaderClientQt::detachedFromParent3):
 605         (WebCore::FrameLoaderClientQt::detachedFromParent4):
 606         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
 607         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
 608         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
 609         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
 610         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
 611         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
 612         (WebCore::FrameLoaderClientQt::dispatchWillClose):
 613         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
 614         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
 615         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
 616         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
 617         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
 618         (WebCore::FrameLoaderClientQt::dispatchShow):
 619         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
 620         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
 621         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
 622         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
 623         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
 624         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
 625         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
 626         (WebCore::FrameLoaderClientQt::progressStarted):
 627         (WebCore::FrameLoaderClientQt::progressCompleted):
 628         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
 629         (WebCore::FrameLoaderClientQt::willChangeTitle):
 630         (WebCore::FrameLoaderClientQt::didChangeTitle):
 631         (WebCore::FrameLoaderClientQt::finishedLoading):
 632         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
 633         (WebCore::FrameLoaderClientQt::setDefersLoading):
 634         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
 635         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
 636         (WebCore::FrameLoaderClientQt::clearArchivedResources):
 637         (WebCore::FrameLoaderClientQt::canShowMIMEType):
 638         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
 639         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
 640         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
 641         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
 642         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
 643         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
 644         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
 645         (WebCore::FrameLoaderClientQt::didFinishLoad):
 646         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
 647         (WebCore::FrameLoaderClientQt::setTitle):
 648         (WebCore::FrameLoaderClientQt::userAgent):
 649         * loader/qt/FrameLoaderClientQt.h: Added.
 650         * loader/qt/FrameLoaderQt.cpp:
 651         (WebCore::FrameLoader::submitForm):
 652         (WebCore::FrameLoader::overrideMediaType):
 653         (WebCore::FrameLoader::getHistoryLength):
 654         (WebCore::FrameLoader::referrer):
 655         (WebCore::FrameLoader::detachFromParent):
 656         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
 657         (WebCore::FrameLoader::goBackOrForward):
 658         (WebCore::FrameLoader::historyURL):
 659         (WebCore::FrameLoader::didFirstLayout):
 660         (WebCore::FrameLoader::canGoBackOrForward):
 661         (WebCore::FrameLoader::partClearedInBegin):
 662         (WebCore::FrameLoader::saveDocumentState):
 663         (WebCore::FrameLoader::restoreDocumentState):
 664         (WebCore::FrameLoader::didChangeTitle):
 665         (WebCore::FrameLoader::redirectDataToPlugin):
 666         (WebCore::PolicyCheck::PolicyCheck):
 667         (WebCore::PolicyCheck::clear):
 668         (WebCore::PolicyCheck::set):
 669         (WebCore::PolicyCheck::call):
 670         (WebCore::PolicyCheck::clearRequest):
 671         * loader/qt/NavigationActionQt.cpp: Added.
 672         (WebCore::navigationType):
 673         (WebCore::NavigationAction::NavigationAction):
 674         * loader/qt/ResourceLoaderQt.cpp: Added.
 675         (WebCore::ResourceLoader::ResourceLoader):
 676         (WebCore::ResourceLoader::~ResourceLoader):
 677         (WebCore::ResourceLoader::setDefersLoading):
 678         (WebCore::ResourceLoader::cancel):
 679         (WebCore::ResourceLoader::loadsBlocked):
 680         * platform/MimeTypeRegistry.cpp:
 681         (WebCore::initialiseSupportedImageMIMETypes):
 682         * platform/network/qt/ResourceHandleManager.cpp:
 683         (WebCore::ResourceHandleManager::slotResult):
 684         (WebCore::ResourceHandleManager::cancel):
 685         * platform/qt/ChromeClientQt.cpp: Added.
 686         (WebCore::rootWindowForFrame):
 687         (WebCore::ChromeClientQt::ChromeClientQt):
 688         (WebCore::ChromeClientQt::~ChromeClientQt):
 689         (WebCore::ChromeClientQt::setWindowRect):
 690         (WebCore::ChromeClientQt::windowRect):
 691         (WebCore::ChromeClientQt::pageRect):
 692         (WebCore::ChromeClientQt::scaleFactor):
 693         (WebCore::ChromeClientQt::focus):
 694         (WebCore::ChromeClientQt::unfocus):
 695         (WebCore::ChromeClientQt::createWindow):
 696         (WebCore::ChromeClientQt::createModalDialog):
 697         (WebCore::ChromeClientQt::show):
 698         (WebCore::ChromeClientQt::canRunModal):
 699         (WebCore::ChromeClientQt::runModal):
 700         (WebCore::ChromeClientQt::setToolbarsVisible):
 701         (WebCore::ChromeClientQt::toolbarsVisible):
 702         (WebCore::ChromeClientQt::setStatusbarVisible):
 703         (WebCore::ChromeClientQt::statusbarVisible):
 704         (WebCore::ChromeClientQt::setScrollbarsVisible):
 705         (WebCore::ChromeClientQt::scrollbarsVisible):
 706         (WebCore::ChromeClientQt::setMenubarVisible):
 707         (WebCore::ChromeClientQt::menubarVisible):
 708         (WebCore::ChromeClientQt::setResizable):
 709         * platform/qt/ChromeClientQt.h: Added.
 710         * platform/qt/EditorClientQt.cpp:
 711         (WebCore::EditorClientQt::shouldBeginEditing):
 712         (WebCore::EditorClientQt::shouldEndEditing):
 713         (WebCore::EditorClientQt::shouldApplyStyle):
 714         (WebCore::EditorClientQt::didBeginEditing):
 715         (WebCore::EditorClientQt::respondToChangedContents):
 716         (WebCore::EditorClientQt::didEndEditing):
 717         * platform/qt/EditorClientQt.h:
 718         * platform/qt/FrameQt.cpp:
 719         (WebCore::FrameQt::FrameQt):
 720         (WebCore::FrameQt::~FrameQt):
 721         (WebCore::FrameQt::keyEvent):
 722         * platform/qt/FrameQt.h:
 723         * platform/qt/FrameQtClient.cpp:
 724         (WebCore::FrameQtClientDefault::openURL):
 725         (WebCore::FrameQtClientDefault::didReceiveData):
 726         (WebCore::FrameQtClientDefault::receivedAllData):
 727         * platform/qt/ImageQt.cpp:
 728         * platform/qt/MimeTypeRegistryQt.cpp: Added.
 729         (WebCore::getMIMETypeForUTI):
 730         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
 731         * platform/qt/PageQt.cpp:
 732         * platform/qt/PlatformKeyboardEventQt.cpp:
 733         (WebCore::keyIdentifierForQtKeyCode):
 734         * platform/qt/ScreenQt.cpp:
 735         * platform/qt/TemporaryLinkStubs.cpp:
 736         (WebCore::TextField::TextField):
 737         (WebCore::screenDepth):
 738         (WebCore::screenDepthPerComponent):
 739         (WebCore::screenIsMonochrome):
 740         (WebCore::screenRect):
 741         (WebCore::screenAvailableRect):
 742
 743 2006-11-10  Brady Eidson <beidson@apple.com>
 744
 745         Reviewed by Mitz
 746
 747         http://bugs.webkit.org/show_bug.cgi?id=11554
 748         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
 749         in case the icon load fails after some data has been received.
 750
 751         * loader/icon/IconLoader.cpp:
 752         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
 753         on error.  Also, as a loader re-factoring sanity check, added an assertion
 754         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon
 755         is already committed to the DB.  Skip doing that step twice.
 756
 757 2006-11-09  Oliver Hunt  <oliver@apple.com>
 758
 759         Reviewed by Brady.
 760
 761         Pulled MIME type handling out of WebFrameBridge and added
 762         a general C++ class to store/query MIME info
 763         Added an Obj-C bridge to provide WebKit with access to the
 764         MimeTypeRegistry for non-Obj-C++ classes.
 765
 766         * WebCore.exp:
 767         * WebCore.xcodeproj/project.pbxproj:
 768         * bridge/mac/WebCoreFrameBridge.h:
 769         * bridge/mac/WebCoreFrameBridge.mm:
 770         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
 771         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
 772         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
 773         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
 774         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
 775         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
 776         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
 777         * platform/Image.cpp:
 778         (WebCore::Image::supportsType):
 779         * platform/Image.h:
 780         * platform/MimeTypeRegistry.cpp: Added.
 781         (WebCore::initialiseSupportedImageMIMETypes):
 782         (WebCore::initialiseSupportedNonImageMimeTypes):
 783         (WebCore::initialiseMimeTypeRegistry):
 784         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
 785         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
 786         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
 787         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
 788         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
 789         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
 790         * platform/MimeTypeRegistry.h: Added.
 791         * platform/mac/ImageMac.mm:
 792         * platform/mac/MimeTypeRegistryMac.mm: Added.
 793         (WebCore::getMIMETypeForUTI):
 794         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
 795
 796 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
 797
 798         Reviewed by Oliver.
 799
 800         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
 801         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
 802         for you and use vsnprintf.
 803
 804         * bindings/js/kjs_window.cpp:
 805         (KJS::Window::isSafeScript):
 806         * css/cssparser.cpp:
 807         (WebCore::CSSParser::parseColorFromValue):
 808         * dom/StyledElement.cpp:
 809         (WebCore::StyledElement::addCSSColor):
 810         * dom/XMLTokenizer.cpp:
 811         (WebCore::XMLTokenizer::handleError):
 812         * ksvg2/css/SVGCSSParser.cpp:
 813         (WebCore::CSSParser::parseSVGPaint):
 814         (WebCore::CSSParser::parseSVGColor):
 815         * ksvg2/svg/SVGPathSegArc.h:
 816         (WebCore::SVGPathSegArcAbs::toString):
 817         (WebCore::SVGPathSegArcRel::toString):
 818         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
 819         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
 820         (WebCore::SVGPathSegCurvetoCubicRel::toString):
 821         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
 822         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
 823         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
 824         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
 825         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
 826         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
 827         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
 828         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
 829         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
 830         * ksvg2/svg/SVGPathSegLineto.h:
 831         (WebCore::SVGPathSegLinetoAbs::toString):
 832         (WebCore::SVGPathSegLinetoRel::toString):
 833         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
 834         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
 835         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
 836         * ksvg2/svg/SVGPathSegLinetoVertical.h:
 837         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
 838         (WebCore::SVGPathSegLinetoVerticalRel::toString):
 839         * ksvg2/svg/SVGPathSegMoveto.h:
 840         (WebCore::SVGPathSegMovetoAbs::toString):
 841         (WebCore::SVGPathSegMovetoRel::toString):
 842         * ksvg2/svg/SVGPolyElement.cpp:
 843         (WebCore::SVGPolyElement::notifyAttributeChange):
 844         * ksvg2/svg/SVGUseElement.cpp:
 845         (WebCore::SVGUseElement::closeRenderer):
 846         * loader/icon/IconDatabase.cpp:
 847         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
 848         * loader/icon/SQLDatabase.cpp:
 849         (WebCore::SQLDatabase::setSynchronous):
 850         * platform/Color.cpp:
 851         (WebCore::Color::name):
 852         * platform/DeprecatedString.cpp:
 853         (WebCore::DeprecatedString::setNum):
 854         (WebCore::DeprecatedString::format):
 855         * platform/DeprecatedString.h:
 856         * platform/PlatformString.h:
 857         * platform/String.cpp:
 858         (WebCore::String::format):
 859         (WebCore::String::number):
 860         * platform/mac/KeyEventMac.mm:
 861         (WebCore::keyIdentifierForKeyEvent):
 862         * platform/win/KeyEventWin.cpp:
 863         (WebCore::keyIdentifierForWindowsKeyCode):
 864         * rendering/RenderListMarker.cpp:
 865         (WebCore::RenderListMarker::calcMinMaxWidth):
 866
 867 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
 868
 869         Reviewed by Anders.
 870
 871         - fixed "Regression: Can't log into gmail.com"
 872         - fixed "iBench doesn't report results - tests run but no number is recorded"
 873
 874         * platform/network/cf/FormDataStreamCFNet.cpp:
 875         (WebCore::setHTTPBody): Removed extra ! character.
 876
 877 2006-11-09  Beth Dakin  <bdakin@apple.com>
 878
 879         Reviewed by Hyatt.
 880
 881         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in
 882         WebCore::RenderBlock::skipWhitespace
 883
 884         Note that this will still crash on Debug builds because it will hit
 885         an assertion failure in editing. (One of the reasons there is no
 886         layout test along with this fix.) There is definitely some editing
 887         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
 888         id=10144 for updates on the assertion failure bug.
 889
 890         * rendering/RootInlineBox.cpp:
 891         (WebCore::RootInlineBox::childRemoved): It is possible for a
 892         prevRootBox and its prevRootBox to share a lineBreakObj. So instead
 893         of just clearing the lineBreakObj of the prevRootBox, cycle through
 894         all prevRootBoxs with the same lineBreakObj.
 895
 896 2006-11-09  Adam Roben  <aroben@apple.com>
 897
 898         Reviewed by Geoff.
 899
 900         Fix the change in behavior I caused in r17680 with my build fix.
 901
 902         * rendering/RenderObject.cpp:
 903         (WebCore::RenderObject::maxTopMargin):
 904         (WebCore::RenderObject::maxBottomMargin):
 905
 906 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
 907
 908         Reviewed by Adam, Oliver.
 909
 910         Move more functions to Editor.
 911
 912         * bridge/EditorClient.h:
 913         * bridge/mac/FrameMac.h:
 914         * bridge/mac/FrameMac.mm:
 915         * bridge/mac/WebCoreFrameBridge.h:
 916         * editing/EditCommand.cpp:
 917         (WebCore::EditCommand::apply):
 918         (WebCore::EditCommand::unapply):
 919         (WebCore::EditCommand::reapply):
 920         * editing/Editor.cpp:
 921         (WebCore::Editor::respondToChangedContents):
 922         (WebCore::dispatchEditableContentChangedEvents):
 923         (WebCore::Editor::appliedEditing):
 924         (WebCore::Editor::unappliedEditing):
 925         (WebCore::Editor::reappliedEditing):
 926         * editing/Editor.h:
 927         * editing/TypingCommand.cpp:
 928         (WebCore::TypingCommand::typingAddedToOpenCommand):
 929         * page/Frame.cpp:
 930         * page/Frame.h:
 931
 932 2006-11-09  Darin Adler  <darin@apple.com>
 933
 934         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
 935
 936 2006-11-09  Alice Liu  <alice.liu@apple.com>
 937
 938         Reviewed by Beth Dakin.
 939
 940         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
 941         All existing layout tests pass
 942
 943         * html/HTMLTableElement.cpp:
 944         (WebCore::HTMLTableElement::deleteRow):
 945         check lastSection before deleting row
 946
 947 2006-11-09  Darin Adler  <darin@apple.com>
 948
 949         - improved version of last night's build fix (should not do using namespace in a header)
 950
 951         * rendering/RenderObject.h:
 952         * rendering/RenderObject.cpp:
 953         (WebCore::RenderObject::maxTopMargin):
 954         (WebCore::RenderObject::maxBottomMargin):
 955
 956 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
 957
 958         Reviewed by Geoff.
 959
 960         - added ResourceError class and didFailWithError client method
 961
 962         * WebCore.xcodeproj/project.pbxproj:
 963         * loader/icon/IconLoader.cpp:
 964         (WebCore::IconLoader::didFailWithError):
 965         (WebCore::IconLoader::didFinishLoading):
 966         * loader/icon/IconLoader.h:
 967         * loader/loader.cpp:
 968         (WebCore::Loader::receivedAllData):
 969         (WebCore::Loader::didFailWithError):
 970         * loader/loader.h:
 971         * loader/mac/SubresourceLoaderMac.mm:
 972         (WebCore::SubresourceLoader::didFail):
 973         (WebCore::SubresourceLoader::didCancel):
 974         * platform/cf/RetainPtr.h:
 975         (WebCore::):
 976         (WebCore::adoptCFReference):
 977         (WebCore::RetainPtr::RetainPtr):
 978         (WebCore::::adopt):
 979         * platform/network/ResourceError.cpp: Added.
 980         * platform/network/ResourceError.h: Added.
 981         (WebCore::ResourceError::ResourceError):
 982         (WebCore::ResourceError::domain):
 983         (WebCore::ResourceError::errorCode):
 984         (WebCore::ResourceError::failingURL):
 985         (WebCore::ResourceError::localizedDescription):
 986         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
 987         * platform/network/ResourceHandle.cpp:
 988         * platform/network/ResourceHandle.h:
 989         * platform/network/ResourceHandleClient.h:
 990         (WebCore::ResourceHandleClient::didFailWithError):
 991         * platform/network/cf/ResourceHandleCFNet.cpp:
 992         (WebCore::didFail):
 993         (WebCore::ResourceHandle::cancel):
 994         * platform/network/mac/ResourceErrorMac.mm: Added.
 995         (-[NSError WebCore]):
 996         * platform/network/mac/ResourceHandleMac.mm:
 997         (WebCore::ResourceHandle::reportError):
 998         * xml/xmlhttprequest.cpp:
 999         (WebCore::XMLHttpRequest::didFailWithError):
1000         (WebCore::XMLHttpRequest::didFinishLoading):
1001         * xml/xmlhttprequest.h:
1002
1003 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1004
1005         Reviewed by Maciej.
1006
1007         Linux\Gdk fixes.
1008
1009         * platform/gdk/ChromeClientGdk.h:
1010         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1011         * platform/gdk/CursorGdk.cpp:
1012         (WebCore::Cursor::Cursor):
1013         (WebCore::moveCursor):
1014         * platform/gdk/FrameGdk.cpp:
1015         (WebCore::FrameGdk::FrameGdk):
1016         (WebCore::FrameGdk::submitForm):
1017         (WebCore::FrameGdk::urlSelected):
1018         * platform/gdk/PageGdk.cpp:
1019         * platform/gdk/ScreenClientGdk.h: Added.
1020         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1021         * platform/gdk/ScreenGdk.cpp:
1022         (WebCore::ScreenClientGdk::depth):
1023         (WebCore::ScreenClientGdk::depthPerComponent):
1024         (WebCore::ScreenClientGdk::isMonochrome):
1025         (WebCore::ScreenClientGdk::rect):
1026         (WebCore::ScreenClientGdk::usableRect):
1027         * platform/gdk/TemporaryLinkStubs.cpp:
1028         (FrameGdk::historyURL):
1029         (ChromeClientGdk::windowRect):
1030         (ChromeClientGdk::setWindowRect):
1031         (ChromeClientGdk::pageRect):
1032         (ChromeClientGdk::scaleFactor):
1033         (ChromeClientGdk::focus):
1034         (ChromeClientGdk::unfocus):
1035         (ChromeClientGdk::createWindow):
1036         (ChromeClientGdk::createModalDialog):
1037         (ChromeClientGdk::show):
1038         (ChromeClientGdk::canRunModal):
1039         (ChromeClientGdk::runModal):
1040         (ChromeClientGdk::setToolbarsVisible):
1041         (ChromeClientGdk::toolbarsVisible):
1042         (ChromeClientGdk::setStatusbarVisible):
1043         (ChromeClientGdk::statusbarVisible):
1044         (ChromeClientGdk::setScrollbarsVisible):
1045         (ChromeClientGdk::scrollbarsVisible):
1046         (ChromeClientGdk::setMenubarVisible):
1047         (ChromeClientGdk::menubarVisible):
1048         (ChromeClientGdk::setResizable):
1049         * platform/network/ResourceHandleInternal.h:
1050         (WebCore::ResourceHandleInternal::client):
1051         * platform/network/gdk/ResourceHandleManager.cpp:
1052         (WebCore::writeCallback):
1053         (WebCore::ResourceHandleManager::downloadTimerCallback):
1054         (WebCore::ResourceHandleManager::remove):
1055
1056 2006-11-08  Adam Roben  <aroben@apple.com>
1057
1058         Build fix.
1059
1060         * rendering/RenderObject.h:
1061         (WebCore::RenderObject::maxTopMargin):
1062         (WebCore::RenderObject::maxBottomMargin):
1063
1064 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1065
1066         Reviewed by Anders Carlsson.
1067
1068         Made Screen a good platform citizen by removing its reference to Page. This
1069         made a class unnecessary, so all screen fuctions are stand-alone now.
1070
1071         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
1072         when computing the screen's available dimensions.
1073
1074 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
1075
1076         Reviewed by Mitz.
1077
1078         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
1079         Cleanup RenderObject
1080
1081         * rendering/RenderObject.cpp:
1082         (WebCore::RenderObject::operator delete):
1083         (WebCore::RenderObject::createObject):
1084         (WebCore::RenderObjectCounter::~RenderObjectCounter):
1085         (WebCore::RenderObject::RenderObject):
1086         (WebCore::RenderObject::isDescendantOf):
1087         (WebCore::RenderObject::isRoot):
1088         (WebCore::RenderObject::addChild):
1089         (WebCore::RenderObject::removeChildNode):
1090         (WebCore::RenderObject::removeChild):
1091         (WebCore::RenderObject::appendChildNode):
1092         (WebCore::RenderObject::insertChildNode):
1093         (WebCore::RenderObject::nextInPreOrder):
1094         (WebCore::RenderObject::nextInPreOrderAfterChildren):
1095         (WebCore::RenderObject::previousInPreOrder):
1096         (WebCore::RenderObject::isEditable):
1097         (WebCore::RenderObject::nextEditable):
1098         (WebCore::RenderObject::previousEditable):
1099         (WebCore::RenderObject::firstLeafChild):
1100         (WebCore::RenderObject::lastLeafChild):
1101         (WebCore::RenderObject::addLayers):
1102         (WebCore::RenderObject::removeLayers):
1103         (WebCore::RenderObject::moveLayers):
1104         (WebCore::RenderObject::findNextLayer):
1105         (WebCore::RenderObject::enclosingLayer):
1106         (WebCore::RenderObject::updateFirstLetter):
1107         (WebCore::RenderObject::offsetParent):
1108         (WebCore::RenderObject::scroll):
1109         (WebCore::RenderObject::hasStaticX):
1110         (WebCore::RenderObject::setNeedsLayout):
1111         (WebCore::RenderObject::setChildNeedsLayout):
1112         (WebCore::RenderObject::markContainingBlocksForLayout):
1113         (WebCore::RenderObject::containingBlock):
1114         (WebCore::RenderObject::containingBlockWidth):
1115         (WebCore::RenderObject::containingBlockHeight):
1116         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
1117         (WebCore::RenderObject::drawBorderArc):
1118         (WebCore::RenderObject::drawBorder):
1119         (WebCore::RenderObject::paintBorderImage):
1120         (WebCore::RenderObject::paintBorder):
1121         (WebCore::RenderObject::absoluteRects):
1122         (WebCore::RenderObject::addPDFURLRect):
1123         (WebCore::RenderObject::addFocusRingRects):
1124         (WebCore::RenderObject::paintOutline):
1125         (WebCore::RenderObject::repaint):
1126         (WebCore::RenderObject::repaintRectangle):
1127         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
1128         (WebCore::RenderObject::repaintObjectsBeforeLayout):
1129         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
1130         (WebCore::RenderObject::information):
1131         (WebCore::RenderObject::dump):
1132         (WebCore::selectStartNode):
1133         (WebCore::RenderObject::shouldSelect):
1134         (WebCore::RenderObject::draggableNode):
1135         (WebCore::RenderObject::createAnonymousBlock):
1136         (WebCore::RenderObject::handleDynamicFloatPositionChange):
1137         (WebCore::RenderObject::setStyle):
1138         (WebCore::RenderObject::setStyleInternal):
1139         (WebCore::RenderObject::updateBackgroundImages):
1140         (WebCore::RenderObject::absolutePosition):
1141         (WebCore::RenderObject::caretRect):
1142         (WebCore::RenderObject::paddingTop):
1143         (WebCore::RenderObject::paddingBottom):
1144         (WebCore::RenderObject::paddingLeft):
1145         (WebCore::RenderObject::paddingRight):
1146         (WebCore::RenderObject::tabWidth):
1147         (WebCore::RenderObject::container):
1148         (WebCore::RenderObject::removeFromObjectLists):
1149         (WebCore::RenderObject::destroy):
1150         (WebCore::RenderObject::arenaDelete):
1151         (WebCore::RenderObject::hitTest):
1152         (WebCore::RenderObject::setInnerNode):
1153         (WebCore::RenderObject::nodeAtPoint):
1154         (WebCore::RenderObject::verticalPositionHint):
1155         (WebCore::RenderObject::getVerticalPosition):
1156         (WebCore::RenderObject::lineHeight):
1157         (WebCore::RenderObject::invalidateVerticalPositions):
1158         (WebCore::RenderObject::recalcMinMaxWidths):
1159         (WebCore::RenderObject::scheduleRelayout):
1160         (WebCore::RenderObject::setInlineBoxWrapper):
1161         (WebCore::RenderObject::firstLineStyle):
1162         (WebCore::RenderObject::getPseudoStyle):
1163         (WebCore::RenderObject::getTextDecorationColors):
1164         (WebCore::RenderObject::addDashboardRegions):
1165         (WebCore::RenderObject::collectDashboardRegions):
1166         (WebCore::RenderObject::avoidsFloats):
1167         (WebCore::RenderObject::findCounter):
1168         (WebCore::RenderObject::backslashAsCurrencySymbol):
1169         (WebCore::RenderObject::imageChanged):
1170         (WebCore::RenderObject::previousOffset):
1171         (WebCore::RenderObject::nextOffset):
1172         (WebCore::RenderObject::inlineBox):
1173         * rendering/RenderObject.h:
1174         (WebCore::):
1175         (WebCore::RenderObject::renderName):
1176         (WebCore::RenderObject::parent):
1177         (WebCore::RenderObject::previousSibling):
1178         (WebCore::RenderObject::nextSibling):
1179         (WebCore::RenderObject::firstChild):
1180         (WebCore::RenderObject::lastChild):
1181         (WebCore::RenderObject::getOverflowClipRect):
1182         (WebCore::RenderObject::getClipRect):
1183         (WebCore::RenderObject::getBaselineOfFirstLineBox):
1184         (WebCore::RenderObject::setEdited):
1185         (WebCore::RenderObject::setStaticX):
1186         (WebCore::RenderObject::setStaticY):
1187         (WebCore::RenderObject::setPreviousSibling):
1188         (WebCore::RenderObject::setNextSibling):
1189         (WebCore::RenderObject::setParent):
1190         (WebCore::RenderObject::isInlineBlockOrInlineTable):
1191         (WebCore::RenderObject::isRenderView):
1192         (WebCore::RenderObject::childrenInline):
1193         (WebCore::RenderObject::setChildrenInline):
1194         (WebCore::RenderObject::isAnonymousBlock):
1195         (WebCore::RenderObject::isDragging):
1196         (WebCore::RenderObject::needsLayout):
1197         (WebCore::RenderObject::setMinMaxKnown):
1198         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
1199         (WebCore::RenderObject::setPositioned):
1200         (WebCore::RenderObject::setRelPositioned):
1201         (WebCore::RenderObject::setFloating):
1202         (WebCore::RenderObject::setInline):
1203         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
1204         (WebCore::RenderObject::setReplaced):
1205         (WebCore::RenderObject::PaintInfo::PaintInfo):
1206         (WebCore::RenderObject::paintBackgroundExtended):
1207         (WebCore::RenderObject::calcWidth):
1208         (WebCore::RenderObject::updateFromElement):
1209         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
1210         (WebCore::RenderObject::setOverrideSize):
1211         (WebCore::RenderObject::setPos):
1212         (WebCore::RenderObject::setWidth):
1213         (WebCore::RenderObject::setHeight):
1214         (WebCore::RenderObject::absolutePositionForContent):
1215         (WebCore::RenderObject::overflowHeight):
1216         (WebCore::RenderObject::overflowWidth):
1217         (WebCore::RenderObject::setOverflowHeight):
1218         (WebCore::RenderObject::setOverflowWidth):
1219         (WebCore::RenderObject::overflowLeft):
1220         (WebCore::RenderObject::overflowTop):
1221         (WebCore::RenderObject::overflowRect):
1222         (WebCore::RenderObject::stopAutoscroll):
1223         (WebCore::RenderObject::collapsedMarginTop):
1224         (WebCore::RenderObject::collapsedMarginBottom):
1225         (WebCore::RenderObject::maxTopMargin):
1226         (WebCore::RenderObject::maxBottomMargin):
1227         (WebCore::RenderObject::):
1228         (WebCore::RenderObject::setTable):
1229         (WebCore::RenderObject::isFloatingOrPositioned):
1230         (WebCore::RenderObject::containsFloat):
1231         (WebCore::RenderObject::setSelectionState):
1232         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
1233         (WebCore::RenderObject::lowestPosition):
1234         (WebCore::RenderObject::rightmostPosition):
1235         (WebCore::RenderObject::leftmostPosition):
1236         (WebCore::RenderObject::calcVerticalMargins):
1237         (WebCore::RenderObject::font):
1238
1239 2006-11-08  Darin Adler  <darin@apple.com>
1240
1241         Reviewed by Anders.
1242
1243         - added event parameters to focus-related functions so we can
1244           implement the "option-tab to all links" behavior without relying
1245           on a global "current event" -- also makes it work with DOM events
1246
1247         * page/Frame.h: Removed unneeded includes. Moved some functions
1248         that were misplaced into the appropriate sections.
1249         * page/Frame.cpp:
1250         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
1251         PlatformKeyboardEvent to the DOM keyboard event class.
1252         (WebCore::Frame::tabsToLinks): Added event parameter.
1253         (WebCore::Frame::tabsToAllControls): Ditto.
1254         (WebCore::scanForForm): Fixed code that incorrectly assumes
1255         that an iframe is an HTMLFrameElement (no longer true since Geoff
1256         changed the class hierarchy a bit).
1257         (WebCore::Frame::hitTestResultAtPoint): Ditto.
1258
1259         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
1260         that were misplaced into the appropriate sections.
1261         * bridge/mac/FrameMac.mm:
1262         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
1263         a PlatformKeyboardEvent.
1264         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
1265         and pass event into next/previousFocusNode.
1266         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
1267         the AppKit current event, if it's a keyboard event. Really just a hack that's
1268         needed to preserve some code we can remove once we deal with the last NSView-
1269         based form control.
1270         (WebCore::isKeyboardOptionTab): Added.
1271         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
1272         option (alt) key is down.
1273         (WebCore::FrameMac::tabsToAllControls): Ditto.
1274         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
1275         call resetMultipleFormSubmissionProtection() explicitly instead.
1276         (WebCore::FrameMac::mouseDown): Ditto.
1277
1278         * bridge/mac/WebCoreAXObject.mm:
1279         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
1280         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
1281         changed the class hierarchy a bit).
1282         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
1283         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
1284         explicitly instead.
1285
1286         * page/FrameView.h:
1287         * page/FrameView.cpp:
1288         (WebCore::FrameView::advanceFocus): Changed function to take an
1289         event parameter, and decide the direction based on the shift key
1290         modifier instead of a passed-in boolean.
1291
1292         * dom/Document.h:
1293         * dom/Document.cpp:
1294         (WebCore::Document::nextFocusNode): Added event parameter.
1295         (WebCore::Document::previousFocusNode): Ditto.
1296         * dom/Node.h:
1297         * dom/Node.cpp:
1298         (WebCore::Node::isKeyboardFocusable): Ditto.
1299         * html/HTMLAnchorElement.h:
1300         * html/HTMLAnchorElement.cpp:
1301         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
1302         * html/HTMLGenericFormElement.h:
1303         * html/HTMLGenericFormElement.cpp:
1304         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
1305         * html/HTMLInputElement.h:
1306         * html/HTMLInputElement.cpp:
1307         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
1308         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
1309         * html/HTMLSelectElement.h:
1310         * html/HTMLSelectElement.cpp:
1311         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
1312         * html/HTMLTextAreaElement.h:
1313         * html/HTMLTextAreaElement.cpp:
1314         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
1315
1316         * dom/EventTargetNode.cpp:
1317         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
1318         advanceFocus function.
1319
1320         * platform/TextField.h:
1321         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
1322
1323         * platform/mac/WebCoreTextField.h:
1324         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
1325         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
1326         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
1327         needed since the default handler in HTMLInputElement takes care of
1328         option-tab.
1329
1330         * platform/mac/SliderMac.mm:
1331         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
1332         and pass event into tabsToAllControls.
1333         (Slider::focusPolicy): Ditto.
1334
1335         * rendering/RenderLineEdit.cpp:
1336         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
1337         (WebCore::RenderLineEdit::updateFromElement): Ditto.
1338
1339 2006-11-08  Brady Eidson  <beidson@apple.com>
1340
1341         Reviewed by Dave Harrison, Oliver, and Darin
1342         (oh my!  where was superkevin on this one?)
1343
1344         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
1345
1346         More "free nil checking" we lost in the transition from ObjC to C++
1347
1348         * loader/mac/FrameLoaderMac.mm:
1349         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
1350         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
1351
1352 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1353
1354         Reviewed by Adam.
1355
1356         Move more code into editor.
1357
1358         * WebCore.exp:
1359         * bridge/EditorClient.h:
1360         * bridge/mac/FrameMac.h:
1361         * bridge/mac/FrameMac.mm:
1362         * bridge/mac/WebCoreFrameBridge.h:
1363         * dom/Document.cpp:
1364         (WebCore::Document::relinquishesEditingFocus):
1365         (WebCore::Document::acceptsEditingFocus):
1366         (WebCore::Document::didBeginEditing):
1367         (WebCore::Document::didEndEditing):
1368         * editing/Editor.cpp:
1369         (WebCore::Editor::indent):
1370         (WebCore::Editor::outdent):
1371         * editing/Editor.h:
1372         * page/Frame.cpp:
1373         * page/Frame.h:
1374
1375 2006-11-08  Beth Dakin  <bdakin@apple.com>
1376
1377         Reviewed by Adam.
1378
1379         Add ability to HitTestResult to ask if the inner non-shared node is
1380         content editable.
1381
1382         * WebCore.exp: Export HitTestResult::isContentEditable()
1383         * rendering/HitTestResult.cpp:
1384         (WebCore::HitTestResult::isContentEditable):
1385         * rendering/HitTestResult.h:
1386
1387 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1388
1389         Build fix.
1390
1391         * WebCore.xcodeproj/project.pbxproj:
1392         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
1393
1394 2006-11-08  Timothy Hatcher  <timothy@apple.com>
1395
1396         Reviewed by Darin.
1397
1398         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
1399         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
1400
1401         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
1402
1403         * bindings/objc/DOM.mm:
1404         (WebCore::kit):
1405         (-[DOMNode lineBoxRects]):
1406         (-[DOMRange boundingBox]):
1407         (-[DOMRange lineBoxRects]):
1408         * bindings/objc/DOMPrivate.h:
1409         * dom/Range.cpp:
1410         (WebCore::Range::boundingBox):
1411         (WebCore::Range::addLineBoxRects):
1412         * dom/Range.h:
1413         * rendering/RenderContainer.cpp:
1414         (WebCore::RenderContainer::addLineBoxRects):
1415         * rendering/RenderContainer.h:
1416         * rendering/RenderObject.cpp:
1417         (WebCore::RenderObject::addLineBoxRects):
1418         * rendering/RenderObject.h:
1419         * rendering/RenderText.cpp:
1420         (WebCore::RenderText::addLineBoxRects):
1421         * rendering/RenderText.h:
1422
1423 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1424
1425         Reviewed by Oliver.
1426
1427         Move methods from the bridge and frame into editor.
1428
1429         * WebCore.exp:
1430         * bridge/EditorClient.h:
1431         * bridge/mac/WebCoreFrameBridge.h:
1432         * bridge/mac/WebCoreFrameBridge.mm:
1433         * editing/Editor.cpp:
1434         (WebCore::Editor::removeFormattingAndStyle):
1435         (WebCore::Editor::applyStyle):
1436         (WebCore::Editor::applyParagraphStyle):
1437         (WebCore::Editor::applyStyleToSelection):
1438         (WebCore::Editor::applyParagraphStyleToSelection):
1439         (WebCore::Editor::toggleBold):
1440         (WebCore::Editor::toggleItalic):
1441         (WebCore::Editor::selectionStartHasStyle):
1442         * editing/Editor.h:
1443         * editing/JSEditor.cpp:
1444         * page/Frame.cpp:
1445         * page/Frame.h:
1446
1447 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1448
1449         Reviewed by Beth.
1450
1451         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
1452         be able to dispatch user events even when off-screen, so we have to support
1453         off-screen windows when handling mouse events.
1454
1455         * platform/Screen.h:
1456         * platform/mac/PlatformMouseEventMac.mm:
1457         (WebCore::globalPoint): Grab the best screen instead of the screen you're
1458         on, since you might be off-screen.
1459         * platform/mac/ScreenMac.mm:
1460         (WebCore::screenForWindow):
1461
1462 2006-11-08  Darin Adler  <darin@apple.com>
1463
1464         - fix bug caused by last-minute change to my check-in last night
1465           that is causing layout tests to hang
1466
1467         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
1468         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
1469         a null string into an empty string before calling completeURL.
1470
1471 2006-11-08  Brady Eidson <beidson@apple.com>
1472
1473         Reviewed by Maciej
1474
1475         If the request has already been aborted, bail out of didFinishLoading()
1476         immediately.  This prevents state change notifications that aren't
1477         needed.
1478
1479         * xml/xmlhttprequest.cpp:
1480         (WebCore::XMLHttpRequest::didFinishLoading):
1481
1482 2006-11-08  Darin Adler  <darin@apple.com>
1483
1484         - another attempt to fix Qt build
1485
1486         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
1487
1488 2006-11-08  Darin Adler  <darin@apple.com>
1489
1490         Reviewed by Geoff.
1491
1492         - stray bits of my FrameLoader patch that I left out by accident
1493
1494         * loader/FrameLoader.cpp:
1495         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
1496         inside the FrameLoader class.
1497         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
1498         (WebCore::FrameLoader::clear): Stop the redirection timer.
1499         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
1500         entire function in an if statement. Use less DeprecatedString.
1501         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
1502         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1503         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
1504         inside the FrameLoader class.
1505         * loader/mac/FrameLoaderMac.mm:
1506         (WebCore::FrameLoader::load): Ditto.
1507         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
1508
1509 2006-11-07  Beth Dakin  <bdakin@apple.com>
1510
1511         Reviewed by Hyatt.
1512
1513         Another go at fix for <rdar://problem/4820814> A crash occurs at
1514         WebCore::HitTestResult::spellingToolTip() when mousing down on
1515         iframe at www.macsurfer.com
1516
1517         The fix from yesterday caused a layout test regression which
1518         exposed an existing bug. The existing bug was that we allowed text
1519         nodes to stay in the head tag, but other browsers move them to the
1520         body. The previous fix also caused a performance regression, which
1521         was seemingly easy to fix by moving the new clause in
1522         HTMLParser::handleError() to be below the HTMLElement case.
1523
1524         * html/HTMLDocument.cpp:
1525         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to
1526         be the child of the document.
1527         * html/HTMLHeadElement.cpp:
1528         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
1529         whitespace text nodes to be children of the head.
1530         * html/HTMLHeadElement.h:
1531         * html/HTMLParser.cpp:
1532         (WebCore::HTMLParser::handleError): Error case for comment nodes.
1533         * page/FrameView.cpp:
1534         (WebCore::FrameView::handleMousePressEvent): Safety-net null check
1535         for the original crash.
1536
1537 2006-11-07  Darin Adler  <darin@apple.com>
1538
1539         - another attempt to fix Qt build
1540
1541         * loader/icon/IconLoader.h: Added missing include.
1542
1543 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1544
1545         Reviewed by Tim Hatcher.
1546
1547         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1548
1549         None of Screen's responsibilities require up-calls to WebKit or delegates,
1550         so WebCore can handle it all.
1551
1552         Moved Screen back from page/ to platform/ because it's a platform
1553         abstraction again.
1554
1555         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
1556         since the two were always used together.
1557
1558         Changed pixel depth queries to query the deepest screen. Darin mentioned
1559         that it might have been a feature, not a bug, to use the main/menubar screen
1560         regardless of the screen you were on. For scaling and flipping that's not
1561         the case, but for querying pixel depth I think it is. You want to know
1562         about the highest pixel depth your content may display on.
1563
1564         Tests still pass.
1565
1566         * WebCore.exp:
1567         * WebCore.xcodeproj/project.pbxproj:
1568         * page/Page.cpp:
1569         (WebCore::Page::Page):
1570         * page/Page.h:
1571         * page/Screen.cpp: Removed.
1572         * page/Screen.h: Removed.
1573         * page/ScreenClient.h: Removed.
1574         * platform/mac/PlatformMouseEventMac.mm:
1575         (WebCore::globalPoint):
1576         * platform/mac/ScreenMac.mm:
1577         (WebCore::window):
1578         (WebCore::bestScreen):
1579         (WebCore::Screen::depth):
1580         (WebCore::Screen::depthPerComponent):
1581         (WebCore::Screen::isMonochrome):
1582         (WebCore::Screen::rect):
1583         (WebCore::Screen::usableRect):
1584         (WebCore::toUserSpace):
1585         (WebCore::toDeviceSpace):
1586
1587 2006-11-07  Darin Adler  <darin@apple.com>
1588
1589         - try to fix Qt build
1590
1591         * CMakeLists.txt: Updated for some file changes.
1592         * WebCoreSources.bkl: Ditto.
1593
1594 2006-11-07  Darin Adler  <darin@apple.com>
1595
1596         Reviewed by Geoff.
1597
1598         - moved loader code from Frame/FrameMac to FrameLoader
1599
1600         * WebCore.exp:
1601         * WebCore.xcodeproj/project.pbxproj:
1602         * bindings/js/JSXSLTProcessor.h:
1603         * bindings/js/kjs_events.cpp:
1604         (KJS::JSLazyEventListener::parseCode):
1605         * bindings/js/kjs_html.cpp:
1606         (KJS::JSHTMLDocument::putValueProperty):
1607         * bindings/js/kjs_navigator.cpp:
1608         (KJS::Navigator::getValueProperty):
1609         * bindings/js/kjs_proxy.cpp:
1610         (WebCore::KJSProxy::initScriptIfNeeded):
1611         * bindings/js/kjs_window.cpp:
1612         (KJS::Screen::Screen):
1613         (KJS::createNewWindow):
1614         (KJS::Window::getValueProperty):
1615         (KJS::Window::put):
1616         (KJS::Window::isSafeScript):
1617         (KJS::WindowFunc::callAsFunction):
1618         (KJS::ScheduledAction::execute):
1619         (KJS::Location::getValueProperty):
1620         (KJS::Location::put):
1621         (KJS::Location::toString):
1622         (KJS::LocationFunc::callAsFunction):
1623         (KJS::History::getValueProperty):
1624         (KJS::HistoryFunc::callAsFunction):
1625         * bindings/objc/DOM.mm:
1626         (+[DOMNode _nodeWith:WebCore::]):
1627         * bridge/mac/FrameMac.h:
1628         * bridge/mac/FrameMac.mm:
1629         (WebCore::FrameMac::~FrameMac):
1630         (WebCore::FrameMac::setView):
1631         (WebCore::FrameMac::setStatusBarText):
1632         * bridge/mac/WebCoreFrameBridge.h:
1633         * bridge/mac/WebCoreFrameBridge.mm:
1634         (-[WebCoreFrameBridge close]):
1635         (-[WebCoreFrameBridge addData:]):
1636         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
1637         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
1638         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1639         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1640         (-[WebCoreFrameBridge baseURL]):
1641         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1642         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
1643         (-[WebCoreFrameBridge canProvideDocumentSource]):
1644         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1645         * css/cssparser.cpp:
1646         (WebCore::CSSParser::parseContent):
1647         * dom/DOMImplementation.cpp:
1648         (WebCore::DOMImplementation::createDocument):
1649         (WebCore::DOMImplementation::createHTMLDocument):
1650         * dom/DOMImplementation.h:
1651         * dom/Document.cpp:
1652         (WebCore::Document::readyState):
1653         (WebCore::Document::updateTitle):
1654         (WebCore::Document::open):
1655         (WebCore::Document::close):
1656         (WebCore::Document::implicitClose):
1657         (WebCore::Document::processHttpEquiv):
1658         (WebCore::Document::referrer):
1659         (WebCore::Document::finishedParsing):
1660         * dom/ProcessingInstruction.cpp:
1661         (WebCore::ProcessingInstruction::checkStyleSheet):
1662         * dom/XMLTokenizer.cpp:
1663         (WebCore::XMLTokenizer::endElementNs):
1664         (WebCore::ignorableWhitespaceHandler):
1665         (WebCore::XMLTokenizer::notifyFinished):
1666         * editing/TextIterator.cpp:
1667         (WebCore::TextIterator::rangeFromLocationAndLength):
1668         * html/HTMLAnchorElement.cpp:
1669         (WebCore::HTMLAnchorElement::defaultEventHandler):
1670         * html/HTMLBaseElement.cpp:
1671         (WebCore::HTMLBaseElement::process):
1672         * html/HTMLDocument.cpp:
1673         (WebCore::HTMLDocument::lastModified):
1674         * html/HTMLFormElement.cpp:
1675         (WebCore::HTMLFormElement::formData):
1676         (WebCore::HTMLFormElement::submit):
1677         * html/HTMLFrameElementBase.cpp:
1678         (WebCore::HTMLFrameElementBase::isURLAllowed):
1679         (WebCore::HTMLFrameElementBase::openURL):
1680         (WebCore::HTMLFrameElementBase::willRemove):
1681         * html/HTMLInputElement.cpp:
1682         (WebCore::HTMLInputElement::setValueFromRenderer):
1683         * html/HTMLLinkElement.cpp:
1684         (WebCore::HTMLLinkElement::process):
1685         * html/HTMLParser.cpp:
1686         (WebCore::HTMLParser::handleError):
1687         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1688         * html/HTMLPreElement.idl:
1689         * html/HTMLScriptElement.cpp:
1690         (WebCore::HTMLScriptElement::parseMappedAttribute):
1691         (WebCore::HTMLScriptElement::insertedIntoDocument):
1692         * html/HTMLTokenizer.cpp:
1693         (WebCore::HTMLTokenizer::scriptExecution):
1694         (WebCore::HTMLTokenizer::parseTag):
1695         (WebCore::HTMLTokenizer::write):
1696         (WebCore::HTMLTokenizer::stopParsing):
1697         (WebCore::HTMLTokenizer::timerFired):
1698         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1699         (WebCore::KCanvasFilterQuartz::prepareFilter):
1700         * ksvg2/svg/SVGAElement.cpp:
1701         (WebCore::SVGAElement::defaultEventHandler):
1702         * ksvg2/svg/SVGElement.cpp:
1703         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1704         * loader/DocLoader.cpp:
1705         (WebCore::DocLoader::setLoadInProgress):
1706         * loader/FrameLoader.cpp:
1707         (WebCore::FormSubmission::FormSubmission):
1708         (WebCore::ScheduledRedirection::):
1709         (WebCore::ScheduledRedirection::ScheduledRedirection):
1710         (WebCore::cancelAll):
1711         (WebCore::getString):
1712         (WebCore::isBackForwardLoadType):
1713         (WebCore::numRequests):
1714         (WebCore::FrameLoader::FrameLoader):
1715         (WebCore::FrameLoader::~FrameLoader):
1716         (WebCore::FrameLoader::createWindow):
1717         (WebCore::FrameLoader::changeLocation):
1718         (WebCore::FrameLoader::urlSelected):
1719         (WebCore::FrameLoader::requestFrame):
1720         (WebCore::FrameLoader::loadSubframe):
1721         (WebCore::FrameLoader::submitFormAgain):
1722         (WebCore::FrameLoader::submitForm):
1723         (WebCore::FrameLoader::stopLoading):
1724         (WebCore::FrameLoader::stop):
1725         (WebCore::FrameLoader::closeURL):
1726         (WebCore::FrameLoader::cancelRedirection):
1727         (WebCore::FrameLoader::iconURL):
1728         (WebCore::FrameLoader::didOpenURL):
1729         (WebCore::FrameLoader::didExplicitOpen):
1730         (WebCore::FrameLoader::replaceContentsWithScriptResult):
1731         (WebCore::FrameLoader::executeScript):
1732         (WebCore::FrameLoader::cancelAndClear):
1733         (WebCore::FrameLoader::clear):
1734         (WebCore::FrameLoader::receivedFirstData):
1735         (WebCore::FrameLoader::responseMIMEType):
1736         (WebCore::FrameLoader::setResponseMIMEType):
1737         (WebCore::FrameLoader::begin):
1738         (WebCore::FrameLoader::write):
1739         (WebCore::FrameLoader::end):
1740         (WebCore::FrameLoader::endIfNotLoading):
1741         (WebCore::FrameLoader::startIconLoader):
1742         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1743         (WebCore::FrameLoader::gotoAnchor):
1744         (WebCore::FrameLoader::finishedParsing):
1745         (WebCore::FrameLoader::loadDone):
1746         (WebCore::FrameLoader::checkCompleted):
1747         (WebCore::FrameLoader::checkEmitLoadEvent):
1748         (WebCore::FrameLoader::baseURL):
1749         (WebCore::FrameLoader::baseTarget):
1750         (WebCore::FrameLoader::completeURL):
1751         (WebCore::FrameLoader::scheduleRedirection):
1752         (WebCore::FrameLoader::scheduleLocationChange):
1753         (WebCore::FrameLoader::scheduleRefresh):
1754         (WebCore::FrameLoader::isScheduledLocationChangePending):
1755         (WebCore::FrameLoader::scheduleHistoryNavigation):
1756         (WebCore::FrameLoader::redirectionTimerFired):
1757         (WebCore::FrameLoader::encoding):
1758         (WebCore::FrameLoader::requestObject):
1759         (WebCore::FrameLoader::shouldUsePlugin):
1760         (WebCore::FrameLoader::loadPlugin):
1761         (WebCore::FrameLoader::clearRecordedFormValues):
1762         (WebCore::FrameLoader::recordFormValue):
1763         (WebCore::FrameLoader::parentCompleted):
1764         (WebCore::FrameLoader::outgoingReferrer):
1765         (WebCore::FrameLoader::lastModified):
1766         (WebCore::FrameLoader::opener):
1767         (WebCore::FrameLoader::setOpener):
1768         (WebCore::FrameLoader::openedByJavaScript):
1769         (WebCore::FrameLoader::setOpenedByJavaScript):
1770         (WebCore::FrameLoader::handleFallbackContent):
1771         (WebCore::FrameLoader::provisionalLoadStarted):
1772         (WebCore::FrameLoader::userGestureHint):
1773         (WebCore::FrameLoader::didNotOpenURL):
1774         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
1775         (WebCore::FrameLoader::setEncoding):
1776         (WebCore::FrameLoader::addData):
1777         (WebCore::FrameLoader::canCachePage):
1778         (WebCore::FrameLoader::updatePolicyBaseURL):
1779         (WebCore::FrameLoader::setPolicyBaseURL):
1780         (WebCore::FrameLoader::scrollToAnchor):
1781         (WebCore::FrameLoader::isComplete):
1782         (WebCore::FrameLoader::isLoadingMainResource):
1783         (WebCore::FrameLoader::url):
1784         (WebCore::FrameLoader::startRedirectionTimer):
1785         (WebCore::FrameLoader::stopRedirectionTimer):
1786         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
1787         (WebCore::FrameLoader::completed):
1788         (WebCore::FrameLoader::started):
1789         (WebCore::FrameLoader::containsPlugins):
1790         (WebCore::FrameLoader::prepareForLoadStart):
1791         (WebCore::FrameLoader::setupForReplace):
1792         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1793         (WebCore::FrameLoader::finalSetupForReplace):
1794         (WebCore::FrameLoader::load):
1795         (WebCore::FrameLoader::canTarget):
1796         (WebCore::FrameLoader::stopLoadingPlugIns):
1797         (WebCore::FrameLoader::stopLoadingSubresources):
1798         (WebCore::FrameLoader::stopLoadingSubframes):
1799         (WebCore::FrameLoader::stopAllLoaders):
1800         (WebCore::FrameLoader::cancelMainResourceLoad):
1801         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1802         (WebCore::FrameLoader::activeDocumentLoader):
1803         (WebCore::FrameLoader::addPlugInStreamLoader):
1804         (WebCore::FrameLoader::removePlugInStreamLoader):
1805         (WebCore::FrameLoader::hasMainResourceLoader):
1806         (WebCore::FrameLoader::isLoadingSubresources):
1807         (WebCore::FrameLoader::isLoadingPlugIns):
1808         (WebCore::FrameLoader::isLoading):
1809         (WebCore::FrameLoader::addSubresourceLoader):
1810         (WebCore::FrameLoader::removeSubresourceLoader):
1811         (WebCore::FrameLoader::releaseMainResourceLoader):
1812         (WebCore::FrameLoader::setDocumentLoader):
1813         (WebCore::FrameLoader::documentLoader):
1814         (WebCore::FrameLoader::setPolicyDocumentLoader):
1815         (WebCore::FrameLoader::provisionalDocumentLoader):
1816         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1817         (WebCore::FrameLoader::state):
1818         (WebCore::FrameLoader::timeOfLastCompletedLoad):
1819         (WebCore::FrameLoader::setState):
1820         (WebCore::FrameLoader::clearProvisionalLoad):
1821         (WebCore::FrameLoader::markLoadComplete):
1822         (WebCore::FrameLoader::commitProvisionalLoad):
1823         (WebCore::FrameLoader::privateBrowsingEnabled):
1824         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
1825         (WebCore::FrameLoader::clientRedirected):
1826         (WebCore::FrameLoader::shouldReload):
1827         (WebCore::FrameLoader::closeOldDataSources):
1828         (WebCore::FrameLoader::open):
1829         (WebCore::FrameLoader::isStopping):
1830         (WebCore::FrameLoader::finishedLoading):
1831         (WebCore::FrameLoader::URL):
1832         (WebCore::FrameLoader::isArchiveLoadPending):
1833         (WebCore::FrameLoader::isHostedByObjectElement):
1834         (WebCore::FrameLoader::isLoadingMainFrame):
1835         (WebCore::FrameLoader::canShowMIMEType):
1836         (WebCore::FrameLoader::representationExistsForURLScheme):
1837         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
1838         (WebCore::FrameLoader::cancelContentPolicyCheck):
1839         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
1840         (WebCore::FrameLoader::finishedLoadingDocument):
1841         (WebCore::FrameLoader::isReplacing):
1842         (WebCore::FrameLoader::setReplacing):
1843         (WebCore::FrameLoader::revertToProvisional):
1844         (WebCore::FrameLoader::subframeIsLoading):
1845         (WebCore::FrameLoader::willChangeTitle):
1846         (WebCore::FrameLoader::loadType):
1847         (WebCore::FrameLoader::stopPolicyCheck):
1848         (WebCore::FrameLoader::continueAfterContentPolicy):
1849         (WebCore::FrameLoader::continueAfterWillSubmitForm):
1850         (WebCore::FrameLoader::didFirstLayout):
1851         (WebCore::FrameLoader::frameLoadCompleted):
1852         (WebCore::FrameLoader::firstLayoutDone):
1853         (WebCore::FrameLoader::isQuickRedirectComing):
1854         (WebCore::FrameLoader::closeDocument):
1855         (WebCore::FrameLoader::detachChildren):
1856         (WebCore::FrameLoader::checkLoadComplete):
1857         (WebCore::FrameLoader::numPendingOrLoadingRequests):
1858         (WebCore::FrameLoader::setClient):
1859         (WebCore::FrameLoader::client):
1860         (WebCore::FrameLoader::userAgent):
1861         (WebCore::FrameLoader::createEmptyDocument):
1862         (WebCore::FrameLoader::tokenizerProcessedData):
1863         (WebCore::FrameLoader::didTellBridgeAboutLoad):
1864         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
1865         (WebCore::FrameLoader::handledOnloadEvents):
1866         (WebCore::FrameLoader::frameDetached):
1867         (WebCore::FrameLoader::setTitle):
1868         (WebCore::FrameLoaderClient::~FrameLoaderClient):
1869         * loader/FrameLoader.h:
1870         (WebCore::):
1871         * loader/FrameLoaderClient.h:
1872         * loader/PluginDocument.cpp:
1873         (WebCore::PluginTokenizer::createDocumentStructure):
1874         (WebCore::PluginTokenizer::writeRawData):
1875         * loader/ResourceLoader.h:
1876         * loader/TextResourceDecoder.cpp:
1877         (WebCore::TextResourceDecoder::checkForHeadCharset):
1878         * loader/icon/IconLoader.cpp:
1879         (WebCore::IconLoader::startLoading):
1880         (WebCore::IconLoader::finishLoading):
1881         * loader/loader.cpp:
1882         (WebCore::Loader::didReceiveResponse):
1883         * loader/mac/DocumentLoaderMac.mm:
1884         (WebCore::DocumentLoader::~DocumentLoader):
1885         (WebCore::DocumentLoader::stopLoading):
1886         (WebCore::DocumentLoader::finishedLoading):
1887         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1888         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1889         * loader/mac/FrameLoaderMac.mm:
1890         (WebCore::FrameLoader::load):
1891         (WebCore::FrameLoader::startLoading):
1892         (WebCore::FrameLoader::cancelMainResourceLoad):
1893         (WebCore::FrameLoader::receivedMainResourceError):
1894         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1895         (WebCore::FrameLoader::commitProvisionalLoad):
1896         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1897         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1898         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
1899         (WebCore::FrameLoader::detachFromParent):
1900         (WebCore::FrameLoader::addExtraFieldsToRequest):
1901         (WebCore::FrameLoader::loadResourceSynchronously):
1902         (WebCore::FrameLoader::createFrame):
1903         (WebCore::FrameLoader::objectContentType):
1904         (WebCore::nsArray):
1905         (WebCore::FrameLoader::createPlugin):
1906         (WebCore::FrameLoader::redirectDataToPlugin):
1907         (WebCore::FrameLoader::createJavaAppletWidget):
1908         (WebCore::FrameLoader::partClearedInBegin):
1909         (WebCore::FrameLoader::saveDocumentState):
1910         (WebCore::FrameLoader::restoreDocumentState):
1911         (WebCore::FrameLoader::overrideMediaType):
1912         (WebCore::FrameLoader::mainResourceData):
1913         (WebCore::FrameLoader::canGoBackOrForward):
1914         (WebCore::FrameLoader::originalRequestURL):
1915         (WebCore::FrameLoader::getHistoryLength):
1916         (WebCore::FrameLoader::goBackOrForward):
1917         (WebCore::FrameLoader::historyURL):
1918         (WebCore::FrameLoader::didFinishLoad):
1919         * loader/mac/LoaderFunctionsMac.mm:
1920         (WebCore::ServeSynchronousRequest):
1921         (WebCore::CheckCacheObjectStatus):
1922         * loader/mac/ResourceLoaderMac.mm:
1923         (WebCore::ResourceLoader::cancel):
1924         * loader/mac/SubresourceLoaderMac.mm:
1925         (WebCore::SubresourceLoader::create):
1926         * loader/qt/FrameLoaderQt.cpp: Added.
1927         (WebCore::FrameLoader::submitForm):
1928         (WebCore::FrameLoader::urlSelected):
1929         (WebCore::FrameLoader::setTitle):
1930         (WebCore::FrameLoader::createFrame):
1931         (WebCore::FrameLoader::objectContentType):
1932         (WebCore::FrameLoader::createPlugin):
1933         (WebCore::FrameLoader::createJavaAppletWidget):
1934         (WebCore::FrameLoader::originalRequestURL):
1935         * page/DOMWindow.cpp:
1936         (WebCore::DOMWindow::document):
1937         * page/Frame.cpp:
1938         (WebCore::Frame::~Frame):
1939         (WebCore::Frame::reparseConfiguration):
1940         (WebCore::Frame::shouldDragAutoNode):
1941         (WebCore::Frame::prepareForUserAction):
1942         (WebCore::FramePrivate::FramePrivate):
1943         (WebCore::FramePrivate::~FramePrivate):
1944         * page/Frame.h:
1945         * page/FramePrivate.h:
1946         * page/FrameView.cpp:
1947         (WebCore::FrameView::layout):
1948         (WebCore::FrameView::mediaType):
1949         * page/FrameView.h:
1950         * page/PageState.cpp:
1951         (WebCore::PageState::PageState):
1952         (WebCore::PageState::restoreJavaScriptState):
1953         * platform/mac/CookieJar.mm:
1954         (WebCore::setCookies):
1955         * platform/mac/TextCodecMac.cpp:
1956         * platform/mac/WebFontCache.mm:
1957         (+[WebFontCache fontWithFamily:traits:size:]):
1958         * platform/network/cf/ResourceHandleCFNet.cpp:
1959         (WebCore::ResourceHandle::start):
1960         * platform/network/mac/ResourceHandleMac.mm:
1961         (WebCore::ResourceHandle::start):
1962         * platform/qt/FrameQt.cpp:
1963         * platform/qt/FrameQt.h:
1964         * rendering/RenderApplet.cpp:
1965         (WebCore::RenderApplet::createWidgetIfNecessary):
1966         * rendering/RenderBlock.h:
1967         * rendering/RenderPartObject.cpp:
1968         (WebCore::isURLAllowed):
1969         (WebCore::RenderPartObject::updateWidget):
1970         * xml/DOMParser.cpp:
1971         (WebCore::DOMParser::parseFromString):
1972         * xml/XSLTProcessor.cpp:
1973         (WebCore::XSLTProcessor::createDocumentFromSource):
1974         * xml/xmlhttprequest.cpp:
1975         (WebCore::XMLHttpRequest::getResponseXML):
1976
1977 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
1978
1979         Reviewed by Geoff.
1980
1981         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
1982
1983         * bridge/mac/FrameMac.mm:
1984         (WebCore::FrameMac::registerCommandForUndoOrRedo):
1985         * bridge/mac/WebCoreFrameBridge.h:
1986         * bridge/mac/WebCoreFrameBridge.mm:
1987         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1988         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1989         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
1990         (-[WebCoreFrameBridge selectionGranularity]):
1991         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
1992         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
1993         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
1994         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
1995         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
1996         * editing/SelectionController.cpp:
1997         (WebCore::SelectionController::setModifyBias):
1998         (WebCore::SelectionController::modify):
1999         * editing/SelectionController.h:
2000         (WebCore::SelectionController::):
2001         * editing/TextGranularity.h:
2002
2003 2006-11-07  Brady Eidson  <beidson@apple.com>
2004
2005         Reviewed by Maciej
2006
2007         Changed the check for "top level frame" to something much more valid
2008
2009         * page/Frame.cpp:
2010         (WebCore::Frame::endIfNotLoading):
2011
2012 2006-11-07  Beth Dakin  <bdakin@apple.com>
2013
2014         Reviewed by Hyatt (yesterday).
2015
2016         Here is part of my patch from yesterday that is safe to roll back
2017         in. It will make the BuildBot happy.
2018
2019         * rendering/HitTestResult.cpp:
2020         (WebCore::HitTestResult::spellingToolTip): Null-check
2021         m_innerNonSharedNode.
2022
2023 2006-11-07  Darin Adler  <darin@apple.com>
2024
2025         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2026         Comment grammar fix.
2027
2028 2006-11-07  Darin Adler  <darin@apple.com>
2029
2030         Rolled out change for <rdar://problem/4820814>.
2031
2032         Beth's planning on landing a new change for it soon, but in the mean time
2033         we need layout tests succeeding again.
2034
2035 2006-11-07  Darin Adler  <darin@apple.com>
2036
2037         Reviewed by Brady.
2038
2039         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
2040           crashes on launch in WebCore::ResourceLoader::start
2041
2042         No layout test, because this depends on cached icons, although there's
2043         perhaps a way to write a test for it with some further ingenuity.
2044
2045         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
2046         to make explicit the fact that it can't be successfully copied.
2047         Remove notifyIconChanged function and put the contents in the caller.
2048         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
2049         and clearLoadingState functions to share code. Removed m_url, since the
2050         resource handle already stores the URL. Renamed m_resourceLoader to
2051         m_handle to reflect the class's name change. Removed the 4096-byte
2052         inline buffer from m_data, since the malloc savings is not sufficient
2053         to offset the additional memory use. Removed m_httpStatusCode because
2054         we can instead cancel the load when we get a status code that reflects
2055         failure. Added m_loadIsInProgress boolean because we need to detect
2056         loads that complete during the ResourceHandle::create function call.
2057
2058         * loader/icon/IconLoader.cpp:
2059         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
2060         Don't initialize m_httpStatusCode.
2061         (WebCore::IconLoader::~IconLoader): Updated for name change.
2062         (WebCore::IconLoader::startLoading): Added code to use the
2063         m_loadIsInProgress flag to detect if the load completed while inside
2064         the ResourceHandle::create function. Removed code to set m_url.
2065         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
2066         more code.
2067         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
2068         and finish loading if the HTTP status code indicates failure.
2069         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
2070         the ResourceHandle, since we can't do that any more.
2071         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
2072         so we can share code with the new didReceiveResponse code path.
2073         (WebCore::IconLoader::finishLoading): Moved code here from the
2074         didFinishLoading callback. Pass a URL when calling
2075         commitIconURLToIconDatabase. Call notifyIconChanged directly here
2076         instead of using a separate function. Call clearLoadingState to
2077         share more code with stopLoading.
2078         (WebCore::IconLoader::clearLoadingState): Added.
2079
2080         * loader/mac/IconLoaderMac.mm: Removed.
2081         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
2082
2083 2006-11-06  David Harrison  <harrison@apple.com>
2084
2085         Reviewed by Darin.
2086
2087         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
2088
2089         * editing/pasteboard/3976872-expected.txt:
2090         * editing/pasteboard/4076267-2-expected.txt:
2091         * editing/pasteboard/4076267-3-expected.txt:
2092         * editing/pasteboard/4076267-expected.txt:
2093         * editing/pasteboard/8145-1-expected.txt:
2094         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
2095         * editing/pasteboard/paste-match-style-001-expected.txt:
2096         * editing/pasteboard/paste-match-style-002-expected.txt:
2097         * editing/pasteboard/paste-text-019-expected.txt:
2098         * editing/pasteboard/pasting-tabs-expected.txt:
2099         Updated because pasting text with no newlines does not use intermediate div.
2100
2101         * editing/markup.cpp:
2102         (WebCore::fillContainerFromString):
2103         First parameter is now a Container so a fragment can be passed.
2104
2105         (WebCore::createFragmentFromText):
2106         A string with no newlines gets added inline, rather than being put into a paragraph.
2107
2108 2006-11-06  Beth Dakin  <bdakin@apple.com>
2109
2110         Reviewed by Hyatt.
2111
2112         Fix for <rdar://problem/4820814> A crash occurs at
2113         WebCore::HitTestResult::spellingToolTip() when mousing down on
2114         iframe at www.macsurfer.com
2115
2116         The bug here is that the source of the iframe is only a comment,
2117         and we were not properly constructing the frame because it was
2118         sort-of empty but not.
2119
2120         * html/HTMLDocument.cpp:
2121         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if
2122         it is a comment node.
2123         * html/HTMLParser.cpp:
2124         (WebCore::HTMLParser::handleError): if n is a comment node and
2125         there is no head, we create a head, insert in the document, and add
2126         the comment node as a child. This is what Firefox does too.
2127         * page/FrameView.cpp:
2128         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the
2129         fix. It is possible to get a mouse event without a target node, so
2130         we null check it. (Of course, in the case of this bug, it should
2131         not have been null, but it is a good thing to check for anyway.
2132         * rendering/HitTestResult.cpp:
2133         (WebCore::HitTestResult::spellingToolTip): Null-check
2134         m_innerNonSharedNode.
2135
2136 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
2137
2138         Reviewed by harrison
2139
2140         <rdar://problem/4641880>
2141         Setting bullets to existing text grabs subsequent paragraph
2142
2143         When a selection ends at the start of a paragraph, we rarely paint
2144         the selection gap before that paragraph, because there often is no gap.
2145         In a case like this, it's not obvious to the user that the selection
2146         ends "inside" that paragraph, so it would be confusing if
2147         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
2148
2149         * editing/FormatBlockCommand.cpp:
2150         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
2151         the selection to a more appropriate place.  Change the endingSelection
2152         if it ends at the start of a paragraph.
2153         * editing/IndentOutdentCommand.cpp:
2154         (WebCore::IndentOutdentCommand::doApply): Ditto.
2155         * editing/InsertListCommand.cpp:
2156         (WebCore::InsertListCommand::doApply): Ditto.
2157
2158 2006-11-06  Brady Eidson  <beidson@apple.com>
2159
2160         Reviewed by Sarge
2161
2162         <rdar://problem/4822911> - ASSERTION was a little overzealous.
2163         Toned it down a bit.
2164
2165         * xml/xmlhttprequest.cpp:
2166         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
2167
2168 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2169
2170         Reviewed by Maciej.
2171
2172         Linux\Gdk build fixes.
2173
2174         * loader/icon/IconDatabase.cpp:
2175         * loader/icon/SQLStatement.h:
2176         * platform/gdk/ChromeClientGdk.h: Added.
2177         (WebCore::ChromeClientGdk::~ChromeClientGdk):
2178         * platform/gdk/CursorGdk.cpp:
2179         (WebCore::pointerCursor):
2180         * platform/gdk/FrameGdk.cpp:
2181         (WebCore::doScroll):
2182         (WebCore::FrameGdk::FrameGdk):
2183         (WebCore::FrameGdk::submitForm):
2184         (WebCore::FrameGdk::urlSelected):
2185         (WebCore::FrameGdk::openURL):
2186         (WebCore::FrameGdk::handleGdkEvent):
2187         * platform/gdk/FrameGdk.h:
2188         (WebCore::FrameGdk::client):
2189         * platform/gdk/RenderPopupMenuGdk.cpp:
2190         (WebCore::PopupMenu::updateFromElement):
2191         * platform/gdk/ScreenGdk.cpp:
2192         * platform/gdk/TemporaryLinkStubs.cpp:
2193         (Slider::focusPolicy):
2194         (WebCore::ServeSynchronousRequest):
2195         (FrameGdk::goBackOrForward):
2196         (FrameGdk::getHistoryLength):
2197         (FrameGdk::historyURL):
2198         (ChromeClientGdk::canRunModal):
2199         (ChromeClientGdk::runModal):
2200         (WebCore::systemBeep):
2201         (WebCore::CachedResource::setPlatformResponse):
2202         (Path::transform):
2203         (ResourceLoader::loadsBlocked):
2204         (IconLoader::notifyIconChanged):
2205         * platform/network/gdk/ResourceHandleManager.cpp:
2206         (WebCore::writeCallback):
2207         (WebCore::ResourceHandleManager::downloadTimerCallback):
2208         (WebCore::ResourceHandleManager::remove):
2209         (WebCore::ResourceHandleManager::add):
2210
2211 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2212
2213         build fix.
2214
2215         * WebCore.xcodeproj/project.pbxproj:
2216
2217 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2218
2219         Reviewed by Maciej, Anders, Darin.
2220
2221         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
2222         Fixed a minor where WebCore would always assume it was displayed on the
2223         monitor containing the menubar. window.open and window.showModalDialog
2224         are now cross-platform.
2225
2226         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
2227         window-open-features-parsing all pass. I verified the new screen functionality
2228         by running in DRT, and checking whether WebCore knew it was off-screen.
2229
2230         Some refactoring remains, as all were not pleased by this design. I see
2231         in my future another patch.
2232
2233         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
2234         client, to encapsulate asking the platform questions about the screen occupied by
2235         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
2236         * bridge/mac/WebCoreFrameBridge.mm:
2237         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
2238         functions.
2239         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
2240         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
2241         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
2242         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
2243         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
2244         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
2245         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
2246         (In this case, neither size nor position is specified, so you should
2247         get the default window size and position.)
2248         * page/Screen.cpp: Added. Includes screen-related helper functions used
2249         in WebCore and WebKit.
2250         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
2251         to be duplicated. Renamed "position" to "point" since both were used,
2252         and "point" seemed clearer.
2253         * platform/Screen.h: Removed. Dead Code.
2254         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
2255         initialization.
2256
2257 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
2258
2259         Reviewed by Tim Hatcher.
2260
2261         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
2262         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
2263
2264         No layout tests added as this must be tested manually by the test
2265         WebCore/manual-tests/contenteditable-link.html
2266
2267         * WebCore.exp: Exported HitTestResult::isLiveLink().
2268         * html/HTMLAnchorElement.cpp:
2269         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
2270         (WebCore::HTMLAnchorElement::defaultEventHandler):
2271         (WebCore::HTMLAnchorElement::isLiveLink):
2272         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
2273         to track shift key status.
2274         * manual-tests/contenteditable-link.html: Added description about link
2275         dragging behaviour.
2276         * rendering/HitTestResult.cpp:
2277         (WebCore::HitTestResult::isLiveLink): Added.
2278         * rendering/HitTestResult.h:
2279
2280 2006-11-06  Brady Eidson  <beidson@apple.com>
2281
2282         Reviewed by Oliver
2283
2284         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
2285         For now, we have to not load favicons when we have no Document - linking directly
2286         to PDFs being the common case
2287
2288         * loader/icon/IconLoader.cpp:
2289         (WebCore::IconLoader::startLoading): Check for the document and return if none
2290
2291 2006-11-06  Brady Eidson  <beidson@apple.com>
2292
2293         Reviewed by Dave Harrison
2294
2295         <rdar://problem/4801066>
2296         Added a critical null frameLoader() check
2297
2298         * loader/mac/MainResourceLoaderMac.mm:
2299         (WebCore::MainResourceLoader::loadNow):
2300
2301 2006-11-06  David Harrison  <harrison@apple.com>
2302
2303         Reviewed by Darin.
2304
2305         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
2306
2307         Test:
2308         * editing/deleting/delete-br-012.html
2309
2310         * editing/DeleteSelectionCommand.cpp:
2311         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
2312         Update m_endingPosition when preventing merge.
2313         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
2314
2315 2006-11-06  Mark Rowe  <bdash@webkit.org>
2316
2317         Reviewed by Maciej.
2318
2319         http://bugs.webkit.org/show_bug.cgi?id=11526
2320         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
2321
2322         Update DOMNode::toString to always use className rather than preferring nodeName.
2323
2324         * bindings/js/kjs_dom.cpp:
2325         (KJS::DOMNode::toString): Match the format returned by valueOf.
2326
2327 2006-11-06  Oliver Hunt  <oliver@apple.com>
2328
2329         Reviewed by Maciej.
2330
2331         Fix RTL text in SVG to have correct positioning
2332
2333         * rendering/SVGRootInlineBox.cpp:
2334         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
2335
2336 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2337
2338         Reviewed by Maciej.
2339
2340         http://bugs.webkit.org/show_bug.cgi?id=11517
2341         REGRESSION: Flash clicks/interactivity not working properly
2342
2343         * bridge/mac/FrameMac.mm:
2344         (WebCore::FrameMac::handleMouseMoveEvent):
2345         (WebCore::FrameMac::handleMouseReleaseEvent):
2346         Restore parts of event dispatching that were removed when fixing
2347         bug 7323 - just bypass those for subframes.
2348
2349 2006-11-05  Darin Adler  <darin@apple.com>
2350
2351         - quick attempt to fix the no-SVG build
2352
2353         * platform/graphics/svg/SVGResource.cpp:
2354         * platform/graphics/svg/SVGResource.h:
2355         * platform/graphics/svg/SVGResourceClipper.cpp:
2356         * platform/graphics/svg/SVGResourceClipper.h:
2357         * platform/graphics/svg/SVGResourceImage.h:
2358         * platform/graphics/svg/SVGResourceMarker.cpp:
2359         * platform/graphics/svg/SVGResourceMarker.h:
2360         * platform/graphics/svg/SVGResourceMasker.cpp:
2361         * platform/graphics/svg/SVGResourceMasker.h:
2362         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
2363         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
2364         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
2365         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
2366         Added #ifdef SVG_SUPPORT to these files.
2367
2368 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
2369
2370         Reviewed & landed by Maciej.
2371
2372         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
2373
2374         * platform/win/ResourceLoaderWin.cpp:
2375         (WebCore::transferJobStatusCallback):
2376         (WebCore::ResourceLoader::start):
2377
2378 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
2379
2380         Reviewed by Oliver.
2381
2382         - moved FormData and FormDataStream to platform/network directory
2383
2384         * WebCore.xcodeproj/project.pbxproj:
2385         * bridge/mac/WebCoreFrameBridge.mm:
2386         * loader/FormData.cpp: Removed.
2387         * loader/FormData.h: Removed.
2388         * loader/mac/FormDataStream.h: Removed.
2389         * loader/mac/FormDataStream.m: Removed.
2390         * loader/mac/FrameLoaderMac.mm:
2391         * loader/mac/SubresourceLoaderMac.mm:
2392         * platform/network/mac/FormDataStreamMac.h: Added.
2393         * platform/network/mac/FormDataStreamMac.mm: Added.
2394         * platform/network/mac/ResourceRequestMac.mm:
2395
2396 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
2397
2398         Fix build breaks
2399
2400         * loader/DocumentLoader.h:
2401         * platform/win/ScreenWin.cpp:
2402
2403 2006-11-05  Darin Adler  <darin@apple.com>
2404
2405         Reviewed by Geoff.
2406
2407         - more preparation for splitting up Frame into sub-pieces
2408         - removed unnecessary includes from Frame.h
2409
2410         * page/Frame.h: Removed unneeded includes and forward declarations.
2411         Added additional forward declarations. Removed the constant
2412         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
2413         Created sections of functions to be moved into Chrome, Editor,
2414         EventHandler, FrameLoader, SelectionController, and the Platform
2415         directory, as well as marking one function for deletion.
2416
2417         * page/FramePrivate.h: Removed the definition of the constructor and
2418         destructor and removed unnecessary includes.
2419
2420         * page/FrameView.h: Removed unneeded forward declarations and friend
2421         declarations. Created a section of functions and data to be moved into
2422         EventHandler.
2423
2424         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
2425         Created sections of functions and data to be moved into Chrome,
2426         Editor, EventHandler, FrameLoader, and the Platform directory.
2427
2428         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
2429         Removed unused methods areScrollbarsVisible,
2430         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
2431
2432         * page/Frame.cpp:
2433         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
2434         to include KURL.h just for the KURL default constructor.
2435         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
2436         (WebCore::FramePrivate::~FramePrivate): Ditto.
2437
2438         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
2439         booleans, scrollbarMoved and cleared funcitons.
2440         (WebCore::FrameView::clear): Moved the code from the cleared
2441         function in here.
2442         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
2443
2444         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
2445         for changes to header.
2446
2447         * editing/SelectionController.cpp:
2448         (WebCore::SelectionController::setSelection):
2449         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2450         Moved NoXPosForVerticalArrowNavigation into this file.
2451
2452         * bindings/js/kjs_events.cpp:
2453         * bindings/js/kjs_html.cpp:
2454         * bindings/js/kjs_window.cpp:
2455         * bridge/mac/WebCoreAXObject.mm:
2456         * bridge/mac/WebCoreFrameBridge.mm:
2457         * css/cssstyleselector.cpp:
2458         * dom/Document.cpp:
2459         * dom/Element.cpp:
2460         * dom/EventTargetNode.cpp:
2461         * dom/MouseRelatedEvent.cpp:
2462         * dom/XMLTokenizer.cpp:
2463         * html/HTMLBaseElement.cpp:
2464         * html/HTMLDocument.cpp:
2465         * html/HTMLEmbedElement.cpp:
2466         * html/HTMLFrameElementBase.cpp:
2467         * html/HTMLGenericFormElement.cpp:
2468         * html/HTMLObjectElement.cpp:
2469         * html/HTMLTokenizer.cpp:
2470         * loader/mac/FrameLoaderMac.mm:
2471         * page/PageState.cpp:
2472         * rendering/RenderApplet.cpp:
2473         * rendering/RenderBlock.cpp:
2474         * rendering/RenderLayer.cpp:
2475         * rendering/RenderObject.cpp:
2476         * rendering/RenderPartObject.cpp:
2477         * rendering/RenderTreeAsText.cpp:
2478         * xml/XSLTProcessor.cpp:
2479         Added includes as needed to keep compiling, since there are fewer
2480         includes in Frame.h.
2481
2482 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
2483
2484         Reviewed by Dave Harrison.
2485
2486         http://bugs.webkit.org/show_bug.cgi?id=11402
2487         REGRESSION: onChange does not work anymore for 1st item in popup
2488
2489         * html/HTMLSelectElement.cpp:
2490         (WebCore::HTMLSelectElement::HTMLSelectElement):
2491         (WebCore::HTMLSelectElement::reset):
2492         Set m_lastOnChangeIndex to -1.
2493
2494 2006-11-04  Darin Adler  <darin@apple.com>
2495
2496         Reviewed by Anders.
2497
2498         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
2499           REGRESSION: Status bar always shows cancelled opening the page
2500
2501         * platform/network/mac/ResourceHandleMac.mm:
2502         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
2503         Since the subresource owns the resource handle, there's no need to cancel.
2504         This arrangement is only temporary, anyway, since Maciej will soon change
2505         things so that the subresource loader uses the resource handle and the
2506         resource handle doesn't know anything about the subresource loader.
2507
2508 2006-11-04  Darin Adler  <darin@apple.com>
2509
2510         Reviewed by Maciej.
2511
2512         - converted more of the loader machinery to work with cross-platform
2513           data structures instead of Macintosh-specific ones
2514
2515           converted most uses of NSURL to KURL and NSEvent to DOM Event in
2516           loader classes
2517
2518           moved download function out of FrameLoader.h to avoid reference to
2519           NSURLConnection
2520
2521           added DOM Event parameters to various functions so that the handlers
2522           can use the DOM Event instead of the global "current NSEvent";
2523           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
2524           HTMLFormElement::submit, FrameLoader::load
2525
2526           moved the setMainFrame call that hands ownership to the Page
2527           into one of the Frame constructors, and removed it from all
2528           the clients
2529
2530           removed const from Event parameter to the urlSelected function
2531           (we rarely use const with DOM elements)
2532
2533           removed some redundant includes and declarations from various
2534           header files
2535
2536           removed NSURL parameter from userAgent function -- if we need it we
2537           can add it back, but converting from NSURL to KURL and back is
2538           inefficient enough that it's best to have it out for now (since it's
2539           been unused for years) -- if we add it back, we can choose an
2540           appropriate parameter type that's always inexpensive to pass
2541
2542           did some basic cleanup in the IconLoader class, including removing
2543           an unnecessary loop that added icon data a byte at a time
2544
2545           renamed safeLoad to load, since it's no different from the other
2546           FrameLoader load functions, safety-wise
2547
2548           fixed some code that was trying to distinguish null frame name from
2549           empty string frame name -- both should be handled the same, but callers
2550           were doing it by checking for empty and turning it into null (in a way
2551           that was causing extra round trips between NSString and WebCore::String)
2552
2553           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
2554           and got rid of case-insensitive compares of methods
2555
2556         * WebCore.exp:
2557         * WebCore.xcodeproj/project.pbxproj:
2558         * bindings/js/kjs_navigator.cpp:
2559         (KJS::Navigator::getValueProperty):
2560         * bridge/mac/FrameMac.h:
2561         * bridge/mac/FrameMac.mm:
2562         (WebCore::FrameMac::submitForm):
2563         (WebCore::FrameMac::urlSelected):
2564         (WebCore::FrameMac::userAgent):
2565         * bridge/mac/FrameViewMac.mm:
2566         * bridge/mac/WebCoreAXObject.mm:
2567         (-[WebCoreAXObject rendererForView:]):
2568         * bridge/mac/WebCorePageBridge.h:
2569         * bridge/mac/WebCorePageBridge.mm:
2570         * bridge/mac/WebCoreSettings.mm:
2571         * bridge/win/FrameWin.cpp:
2572         (WebCore::FrameWin::urlSelected):
2573         (WebCore::FrameWin::submitForm):
2574         * bridge/win/FrameWin.h:
2575         * dom/MouseRelatedEvent.cpp:
2576         * dom/MouseRelatedEvent.h:
2577         * dom/UIEvent.cpp:
2578         (WebCore::UIEvent::~UIEvent):
2579         * dom/UIEvent.h:
2580         * dom/UIEventWithKeyState.h:
2581         * dom/XMLTokenizer.cpp:
2582         (WebCore::openFunc):
2583         * html/HTMLAnchorElement.cpp:
2584         (WebCore::HTMLAnchorElement::defaultEventHandler):
2585         * html/HTMLButtonElement.cpp:
2586         (WebCore::HTMLButtonElement::defaultEventHandler):
2587         * html/HTMLFormElement.cpp:
2588         (WebCore::HTMLFormElement::submitClick):
2589         (WebCore::HTMLFormElement::prepareSubmit):
2590         (WebCore::HTMLFormElement::submit):
2591         * html/HTMLFormElement.h:
2592         * html/HTMLInputElement.cpp:
2593         (WebCore::HTMLInputElement::defaultEventHandler):
2594         * html/HTMLSelectElement.cpp:
2595         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2596         * loader/DocumentLoader.h:
2597         * loader/FrameLoader.h:
2598         * loader/FrameLoaderClient.h:
2599         * loader/NavigationAction.h:
2600         (WebCore::NavigationAction::event):
2601         * loader/icon/IconLoader.cpp:
2602         (WebCore::IconLoader::create):
2603         (WebCore::IconLoader::startLoading):
2604         (WebCore::IconLoader::didReceiveData):
2605         (WebCore::IconLoader::didFinishLoading):
2606         * loader/icon/IconLoader.h:
2607         * loader/loader.cpp:
2608         * loader/mac/DocumentLoaderMac.mm:
2609         (WebCore::DocumentLoader::URL):
2610         (WebCore::DocumentLoader::unreachableURL):
2611         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
2612         (WebCore::DocumentLoader::URLForHistory):
2613         * loader/mac/FrameLoaderMac.mm:
2614         (WebCore::FrameLoader::load):
2615         (WebCore::FrameLoader::willSendRequest):
2616         (WebCore::FrameLoader::clientRedirected):
2617         (WebCore::FrameLoader::shouldReload):
2618         (WebCore::FrameLoader::notifyIconChanged):
2619         (WebCore::FrameLoader::URL):
2620         (WebCore::FrameLoader::reloadAllowingStaleData):
2621         (WebCore::FrameLoader::reload):
2622         (WebCore::FrameLoader::didChangeTitle):
2623         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2624         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2625         (WebCore::FrameLoader::post):
2626         (WebCore::FrameLoader::addExtraFieldsToRequest):
2627         (WebCore::FrameLoader::loadResourceSynchronously):
2628         * loader/mac/IconLoaderMac.mm:
2629         (WebCore::IconLoader::notifyIconChanged):
2630         * loader/mac/LoaderFunctionsMac.mm:
2631         * loader/mac/MainResourceLoaderMac.mm:
2632         (WebCore::shouldLoadAsEmptyDocument):
2633         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2634         * loader/mac/NavigationActionMac.mm:
2635         (WebCore::navigationType):
2636         (WebCore::NavigationAction::NavigationAction):
2637         * loader/mac/ResourceLoaderMac.mm:
2638         * loader/mac/SubresourceLoaderMac.mm:
2639         * page/Frame.cpp:
2640         (WebCore::Frame::Frame):
2641         (WebCore::Frame::urlSelected):
2642         (WebCore::Frame::submitFormAgain):
2643         (WebCore::Frame::submitForm):
2644         (WebCore::Frame::endIfNotLoading):
2645         (WebCore::Frame::hitTestResultAtPoint):
2646         * page/Frame.h:
2647         * page/FramePrivate.h:
2648         * platform/gdk/FrameGdk.cpp:
2649         (WebCore::FrameGdk::FrameGdk):
2650         (WebCore::FrameGdk::submitForm):
2651         (WebCore::FrameGdk::urlSelected):
2652         * platform/gdk/FrameGdk.h:
2653         * platform/mac/TextFieldMac.mm:
2654         * platform/network/HTTPHeaderMap.h:
2655         * platform/network/ResourceHandle.h:
2656         * platform/network/ResourceHandleClient.h:
2657         * platform/network/ResourceHandleInternal.h:
2658         * platform/network/mac/ResourceHandleMac.mm:
2659         * platform/network/mac/ResourceResponseMac.h:
2660         * platform/network/mac/ResourceResponseMac.mm:
2661         (-[NSURLResponse WebCore]):
2662         * platform/network/win/ResourceHandleWin.cpp:
2663         * platform/qt/FrameQt.cpp:
2664         (WebCore::FrameQt::submitForm):
2665         (WebCore::FrameQt::urlSelected):
2666         * platform/qt/FrameQt.h:
2667         * rendering/RenderLineEdit.cpp:
2668         (WebCore::RenderLineEdit::returnPressed):
2669         * xml/XSLTProcessor.cpp:
2670         (WebCore::docLoaderFunc):
2671         * xml/xmlhttprequest.cpp:
2672
2673 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2674
2675         Reviewed by Adele.
2676
2677         - replaced receivedRedirect with new willSendRequest delegate
2678         - removed most mac-specific loader functions
2679         - use ResourceResponse more in loader code
2680
2681         * WebCore.xcodeproj/project.pbxproj: Add new files.
2682         * bridge/mac/WebCoreFrameBridge.mm:
2683         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
2684         for CachedResource method renames.
2685         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2686         Ditto.
2687         * loader/CachedCSSStyleSheet.cpp:
2688         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
2689         based on ResourceResponse
2690         * loader/CachedImage.cpp:
2691         (WebCore::CachedImage::createImage): adapt for ResourceResponse
2692         * loader/CachedResource.cpp:
2693         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
2694         platform response is now called platformResponse and expiration date
2695         is removed.
2696         (WebCore::CachedResource::~CachedResource): ditto
2697         (WebCore::CachedResource::isExpired): ditto
2698         * loader/CachedResource.h:
2699         (WebCore::CachedResource::platformResponse): ditto
2700         (WebCore::CachedResource::setResponse): ditto
2701         (WebCore::CachedResource::canDelete): ditto
2702         * loader/LoaderFunctions.h:
2703         * loader/loader.cpp:
2704         (WebCore::Loader::receivedResponse): Adjusted for renames.
2705         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
2706         in the CachedResource.
2707         * loader/loader.h:
2708         * loader/mac/FormDataStream.h:
2709         * loader/mac/FormDataStream.m:
2710         (WebCore::getStreamFormDatas): Rearranged things so it's
2711         possible to get a FormData back out of a form data stream.
2712         (WebCore::formCreate): ditto
2713         (WebCore::formFinalize): ditto
2714         (WebCore::httpBodyFromStream): ditto
2715         * loader/mac/ImageDocumentMac.mm:
2716         (WebCore::finishImageLoad): s/response/platformResponse/
2717         * loader/mac/LoaderFunctionsMac.mm:
2718         (WebCore::CheckCacheObjectStatus): ditto
2719         (WebCore::CachedResource::setPlatformResponse): ditto
2720         * loader/mac/SubresourceLoaderMac.mm:
2721         (WebCore::SubresourceLoader::willSendRequest): send redirect
2722         to client appropriately
2723         * platform/network/ResourceHandle.h:
2724         * platform/network/ResourceHandleClient.h:
2725         (WebCore::ResourceHandleClient::willSendRequest): new entry
2726         point for SubresourceLoader, dispatch to client.
2727         * platform/network/ResourceRequest.h:
2728         (WebCore::ResourceRequest::allowHTTPCookies): implemented
2729         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
2730         * platform/network/ResourceResponse.h:
2731         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
2732         date(!)
2733         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
2734         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
2735         (WebCore::openNextStream): ditto
2736         (WebCore::formCreate): ditto
2737         (WebCore::formFinalize): ditto
2738         (WebCore::formCanRead): ditto
2739         (WebCore::formEventCallback): ditto
2740         (WebCore::setHTTPBody): ditto
2741         (WebCore::httpBodyFromStream): ditto
2742         * platform/network/cf/FormDataStreamCFNet.h: Added.
2743         * platform/network/cf/ResourceHandleCFNet.cpp:
2744         (WebCore::willSendRequest): implemented
2745         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
2746         * platform/network/cf/ResourceResponseCFNet.cpp:
2747         (WebCore::getResourceResponse): do nothing for a null response
2748         * platform/network/mac/ResourceHandleMac.mm:
2749         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
2750         * platform/network/mac/ResourceRequestMac.h: Added.
2751         * platform/network/mac/ResourceRequestMac.mm: Added.
2752         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
2753         to a ResourceRequest.
2754         (WebCore::nsURLRequest): Opposite of the above.
2755         * platform/network/cf/ResourceRequestCFNet.h: Added.
2756         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
2757         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
2758         to a ResourceRequest.
2759         (WebCore::cfURLRequest): Opposite of the above.
2760         * xml/xmlhttprequest.cpp:
2761         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
2762         adjusted.
2763         * xml/xmlhttprequest.h:
2764
2765 2006-11-04  Darin Adler  <darin@apple.com>
2766
2767         Change suggested by Mitz.
2768
2769         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
2770           REGRESSION (r17438): Repro crash when opening a web archive
2771
2772         * bridge/mac/WebCorePageState.mm:
2773         (-[WebCorePageState dealloc]): Add null check.
2774         (-[WebCorePageState finalize]): Ditto.
2775
2776 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
2777
2778         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
2779
2780         http://bugs.webkit.org/show_bug.cgi?id=11433
2781         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
2782
2783         * WebCore.vcproj/WebCore/WebCore.vcproj:
2784         Added platform/graphics platform/network and platform/network/win to headers search paths
2785         Created platform/graphics and platform/network filters in hierarchy
2786         Moved GraphicsContext and GraphicsTypes to their respective filters
2787         Added EditorClient.h
2788         Added FrameLoader* files in loader/
2789         Added HitTest* files in rendering/
2790         Added Editor.* files in editing/
2791         Added DeleteButton.* and DeleteButtonController.* in editing/
2792
2793         * bridge/win/ChromeClientWin.h: Added.
2794         (WebCore::ChromeClientWin::~ChromeClientWin):
2795         * bridge/win/EditorClientWin.h: Added.
2796         (WebCore::EditorClientWin::~EditorClientWin):
2797
2798         * bridge/win/FrameWin.cpp:
2799         (WebCore::FrameWin::FrameWin):
2800         (WebCore::FrameWin::urlSelected):
2801         (WebCore::FrameWin::submitForm):
2802         (WebCore::FrameWin::createNewWindow):
2803         * bridge/win/FrameWin.h:
2804         Added EditorClient parameter to constructor
2805         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
2806         Removed openURL() and openURLRequest from class definition
2807
2808         * bridge/win/PageWin.cpp:
2809         * platform/AffineTransform.h:
2810         * platform/cairo/AffineTransformCairo.cpp: Added.
2811         (WebCore::AffineTransform::AffineTransform):
2812         (WebCore::AffineTransform::setMatrix):
2813         (WebCore::AffineTransform::map):
2814         (WebCore::AffineTransform::mapRect):
2815         (WebCore::AffineTransform::isIdentity):
2816         (WebCore::AffineTransform::m11):
2817         (WebCore::AffineTransform::m12):
2818         (WebCore::AffineTransform::m21):
2819         (WebCore::AffineTransform::m22):
2820         (WebCore::AffineTransform::dx):
2821         (WebCore::AffineTransform::dy):
2822         (WebCore::AffineTransform::reset):
2823         (WebCore::AffineTransform::scale):
2824         (WebCore::AffineTransform::rotate):
2825         (WebCore::AffineTransform::translate):
2826         (WebCore::AffineTransform::shear):
2827         (WebCore::AffineTransform::det):
2828         (WebCore::AffineTransform::invert):
2829         (WebCore::AffineTransform::operator cairo_matrix_t):
2830         (WebCore::AffineTransform::operator== ):
2831         (WebCore::AffineTransform::operator*= ):
2832         (WebCore::AffineTransform::operator* ):
2833         * platform/cairo/GraphicsContextCairo.cpp:
2834         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2835         * platform/network/win/ResourceHandleWin.cpp:
2836         (WebCore::ResourceHandle::onHandleCreated):
2837         (WebCore::ResourceHandle::start):
2838         (WebCore::ResourceHandle::fileLoadTimer):
2839         (WebCore::ResourceHandle::cancel):
2840         * platform/win/TemporaryLinkStubs.cpp:
2841         (WebCore::FrameWin::goBackOrForward):
2842         (WebCore::FrameWin::getHistoryLength):
2843         (WebCore::FrameWin::historyURL):
2844         (WebCore::ServeSynchronousRequest):
2845         (WebCore::ChromeClientWin::canRunModal):
2846         (WebCore::ChromeClientWin::runModal):
2847         (WebCore::EditorClientWin::shouldDeleteRange):
2848         (WebCore::EditorClientWin::shouldShowDeleteInterface):
2849         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
2850         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
2851         (WebCore::EditorClientWin::spellCheckerDocumentTag):
2852         (WebCore::Path::transform):
2853         (WebCore::PopupMenu::updateFromElement):
2854         (WebCore::ResourceLoader::loadsBlocked):
2855         (WebCore::systemBeep):
2856         * rendering/RenderThemeWin.cpp:
2857         (WebCore::RenderThemeWin::paintButton):
2858         (WebCore::RenderThemeWin::paintTextField):
2859
2860 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
2861
2862         Reviewed by Maciej.
2863
2864         http://bugs.webkit.org/show_bug.cgi?id=11448
2865         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
2866
2867         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
2868
2869 2006-11-03  Mark Rowe  <bdash@webkit.org>
2870
2871         Reviewed by Oliver.
2872
2873         Update Windows and Qt project files for file removals in r17585.
2874
2875         * CMakeLists.txt:
2876         * WebCore.vcproj/WebCore/WebCore.vcproj:
2877
2878 2006-11-03  Zack Rusin  <zack@kde.org>
2879
2880         Reviewed by Maciej.
2881
2882         The patch fixes text field drawing on the Qt platform.
2883
2884         * platform/qt/RenderThemeQt.cpp:
2885         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
2886         render the text field
2887
2888 2006-11-03  Oliver Hunt  <oliver@apple.com>
2889
2890         Reviewed by Tim.
2891
2892         Correct incorrect call to SetCursor
2893
2894         * rendering/RenderFrameSet.cpp:
2895         (WebCore::RenderFrameSet::userResize):
2896
2897 2006-11-03  Adele Peterson  <adele@apple.com>
2898
2899         Reviewed by Oliver.
2900
2901         Removed DeprecatedRenderSelect and ListBox classes.
2902
2903         * WebCore.xcodeproj/project.pbxproj:
2904         * css/html4.css:
2905         * html/HTMLOptionElement.h:
2906         * html/HTMLSelectElement.cpp:
2907         (WebCore::HTMLSelectElement::recalcStyle):
2908         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2909         (WebCore::HTMLSelectElement::isMouseFocusable):
2910         (WebCore::HTMLSelectElement::createRenderer):
2911         (WebCore::HTMLSelectElement::setRecalcListItems):
2912         (WebCore::HTMLSelectElement::notifyOptionSelected):
2913         (WebCore::HTMLSelectElement::defaultEventHandler):
2914         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
2915         (WebCore::HTMLSelectElement::updateListBoxSelection):
2916         * html/HTMLSelectElement.h:
2917         * platform/ListBox.h: Removed.
2918         * platform/mac/FontCacheMac.mm:
2919         * platform/mac/ListBoxMac.mm: Removed.
2920         * platform/win/TemporaryLinkStubs.cpp:
2921         * rendering/DeprecatedRenderSelect.cpp: Removed.
2922         * rendering/DeprecatedRenderSelect.h: Removed.
2923
2924 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2925
2926         Not reviewed, fix for accidental commit.
2927
2928         - rolled back more of the accidentall commit that I forgot.
2929
2930         * platform/network/mac/ResourceRequestMac.h: Removed.
2931         * platform/network/mac/ResourceRequestMac.mm: Removed.
2932
2933 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2934
2935         Not reviewed, fix for accidental commit.
2936
2937         - roll back some network changes accidentally committed with a previous patch.
2938
2939         * WebCore.xcodeproj/project.pbxproj:
2940         * bridge/mac/WebCoreFrameBridge.mm:
2941         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2942         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2943         * loader/CachedCSSStyleSheet.cpp:
2944         (WebCore::CachedCSSStyleSheet::checkNotify):
2945         * loader/CachedImage.cpp:
2946         (WebCore::CachedImage::createImage):
2947         * loader/CachedResource.cpp:
2948         (WebCore::CachedResource::CachedResource):
2949         (WebCore::CachedResource::~CachedResource):
2950         (WebCore::CachedResource::setExpireDate):
2951         (WebCore::CachedResource::isExpired):
2952         * loader/CachedResource.h:
2953         (WebCore::CachedResource::response):
2954         * loader/LoaderFunctions.h:
2955         * loader/loader.cpp:
2956         (WebCore::Loader::receivedResponse):
2957         (WebCore::Loader::didReceivedResponse):
2958         * loader/loader.h:
2959         * loader/mac/FormDataStream.h:
2960         * loader/mac/FormDataStream.m:
2961         (WebCore::formCreate):
2962         (WebCore::formFinalize):
2963         * loader/mac/ImageDocumentMac.mm:
2964         (WebCore::finishImageLoad):
2965         * loader/mac/LoaderFunctionsMac.mm:
2966         (WebCore::CheckCacheObjectStatus):
2967         (WebCore::CachedResource::setResponse):
2968         * loader/mac/SubresourceLoaderMac.mm:
2969         (WebCore::SubresourceLoader::willSendRequest):
2970         * platform/network/ResourceHandle.h:
2971         * platform/network/ResourceHandleClient.h:
2972         (WebCore::ResourceHandleClient::receivedRedirect):
2973         * platform/network/ResourceRequest.h:
2974         * platform/network/ResourceResponse.h:
2975         (WebCore::ResourceResponse::ResourceResponse):
2976         * platform/network/mac/ResourceHandleMac.mm:
2977         (WebCore::ResourceHandle::redirectedToURL):
2978         * xml/xmlhttprequest.cpp:
2979         (WebCore::XMLHttpRequest::receivedRedirect):
2980         * xml/xmlhttprequest.h:
2981
2982 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
2983
2984         Rubber-stamped by Oliver.
2985
2986         Remove these, they have been merged with SVGRenderTreeAsText.
2987
2988         * rendering/SVGRenderAsText.cpp: Removed.
2989         * rendering/SVGRenderAsText.h: Removed.
2990
2991 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
2992
2993         Build fix.
2994
2995         * platform/network/cf/ResourceHandleCFNet.cpp:
2996         (WebCore::willSendRequest):
2997
2998 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
2999
3000         Reviewed by Darin, Beth.
3001
3002         First cut at factoring Page's UIDelegate-related functions into Chrome
3003         and ChromeClient.
3004
3005         Layout tests pass.
3006
3007         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
3008         setBridge method to replace it.
3009         (WebCore::Page::setBridge):
3010
3011         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
3012         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
3013         and, now that it uses PassRefPtr, can't be.
3014
3015         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
3016
3017         * page/Page.h:
3018         (WebCore::Page::dragCaretController): Made this function non-const so that
3019         m_dragCaretController doesn't have to be mutable.
3020
3021 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
3022
3023         Reviewed by Adele.
3024
3025         http://bugs.webkit.org/show_bug.cgi?id=7323
3026         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
3027
3028         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
3029         in FrameMac.mm. There can be only one drag active at any moment, and having
3030         this information here was making sharing this information between
3031         subframes hard.
3032
3033         * bridge/mac/FrameMac.mm:
3034         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
3035         (WebCore::FrameMac::freeClipboard):
3036         (WebCore::FrameMac::dragHysteresisExceeded):
3037         (WebCore::FrameMac::handleMouseMoveEvent):
3038         (WebCore::FrameMac::handleMouseReleaseEvent):
3039         (WebCore::FrameMac::mouseDown):
3040         (WebCore::FrameMac::dragSourceMovedTo):
3041         (WebCore::FrameMac::dragSourceEndedAt):
3042         (WebCore::FrameMac::dispatchDragSrcEvent):
3043         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
3044         Also removed some old code that was forwarding mouse events to subviews to make
3045         HTML editing work in subframes.
3046
3047         * page/FrameView.cpp:
3048         (WebCore::FrameView::updateDragAndDrop):
3049         (WebCore::FrameView::cancelDragAndDrop):
3050         (WebCore::FrameView::performDragAndDrop):
3051         Forward events to subframes for dispatching - this fixes drag target events.
3052
3053 2006-11-03  Zack Rusin  <zack@kde.org>
3054
3055         Reviewed by Tim.
3056
3057         Fixing compile.
3058
3059         * platform/qt/LoaderFunctionsQt.cpp:
3060         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
3061
3062 2006-11-01  Zack Rusin  <zack@kde.org>
3063
3064         Reviewed by Maciej.
3065
3066         Moving the word/sentence seperators into a file of their own
3067         and implementing findWordBoundary.
3068
3069         * CMakeLists.txt:
3070         * platform/qt/TemporaryLinkStubs.cpp:
3071         * platform/qt/TextBoundaries.cpp: Added.
3072         (WebCore::findNextSentenceFromIndex):
3073         (WebCore::findSentenceBoundary):
3074         (WebCore::findNextWordFromIndex):
3075         (WebCore::findWordBoundary):
3076
3077 2006-11-03  Zack Rusin  <zack@kde.org>
3078
3079         Reviewed by Maciej.
3080
3081         Compile on both KDE and Qt platforms
3082
3083         * CMakeLists.txt: add zlib explicitly
3084         * platform/network/qt/ResourceHandleManager.cpp:
3085         (WebCore::ResourceHandleManager::self):
3086         (WebCore::QtJob::QtJob):
3087         (WebCore::QtJob::timerEvent): Integrate both implementations
3088         so that moc can parse it
3089         (WebCore::ResourceHandleManager::deliverJobData):
3090         (WebCore::ResourceHandleManager::remove):
3091         * platform/network/qt/ResourceHandleManager.h:
3092
3093 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3094
3095         No review, suggested by Mitz.
3096
3097         - fix a #if to be #ifdef
3098
3099         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
3100
3101 2006-11-03  Zack Rusin  <zack@kde.org>
3102
3103         Reviewed and landed by Maciej.
3104
3105         Compile on the Qt platform.
3106
3107         * ksvg2/misc/KCanvasRenderingStyle.h:
3108         * platform/qt/RenderThemeQt.cpp:
3109         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
3110
3111 2006-11-03  Zack Rusin  <zack@kde.org>
3112
3113         Reviewed by Hyatt. Landed by Maciej.
3114
3115         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
3116         to graphics context to be able to set consistant state
3117         on the platform specific painter without having to change
3118         fill/stroke/font on every operation. This fixes color/stroke/fill
3119         and font handling in the Qt port.
3120
3121         * platform/graphics/GraphicsContext.cpp:
3122         (WebCore::GraphicsContext::setFont):
3123         (WebCore::GraphicsContext::setPen):
3124         (WebCore::GraphicsContext::setFillColor):
3125         (WebCore::GraphicsContext::setPlatformPen):
3126         (WebCore::GraphicsContext::setPlatformFillColor):
3127         (WebCore::GraphicsContext::setPlatformFont):
3128         * platform/graphics/GraphicsContext.h:
3129         * platform/qt/GraphicsContextQt.cpp:
3130         (WebCore::toQtCompositionMode):
3131         (WebCore::toQtLineCap):
3132         (WebCore::toQtLineJoin):
3133         (WebCore::toQPenStyle):
3134         (WebCore::penToQPen):
3135         (WebCore::TransparencyLayer::TransparencyLayer):
3136         (WebCore::GraphicsContext::addRoundedRectClip):
3137         (WebCore::GraphicsContext::setPlatformFont):
3138         (WebCore::GraphicsContext::setPlatformPen):
3139         (WebCore::GraphicsContext::setPlatformFillColor):
3140         * platform/qt/ScrollViewCanvasQt.cpp:
3141         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
3142         (WebCore::ScrollViewCanvasQt::paintEvent):
3143         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
3144         * platform/qt/ScrollViewCanvasQt.h:
3145
3146 2006-11-02  Adele Peterson  <adele@apple.com>
3147
3148         Reviewed by Anders.
3149
3150         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
3151         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
3152
3153         Test: fast/forms/textarea-no-scroll-on-blur.html
3154
3155         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
3156           On blur, only scroll back to the start for text fields.
3157
3158 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3159
3160         Another build fix.
3161
3162         * rendering/RenderFileUploadControl.cpp:
3163         (WebCore::RenderFileUploadControl::paintObject):
3164
3165 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3166
3167         Build fix.
3168
3169         * page/FramePrivate.h:
3170         (WebCore::FramePrivate::FramePrivate):
3171
3172 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
3173
3174         Reviewed by Geoff, landed by Anders.
3175
3176         Fix dependency problems caused when running move-js-headers.sh
3177
3178         * move-js-headers.sh:
3179         Use cp -p instead of just cp so that the modification time
3180         of the original files are used.
3181
3182 2006-11-02  Adam Roben  <aroben@apple.com>
3183
3184         Reviewed by Tim H, landed by Anders.
3185
3186         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
3187         REGRESSION: Shadow of file upload button is clipped
3188
3189         * rendering/RenderFileUploadControl.cpp:
3190         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
3191         height to keep from clipping in the shadow
3192
3193 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
3194
3195         Reviewed by Maciej, landed by Anders.
3196
3197         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
3198         content and window. ScrollViewQt already receives correct content
3199         coordinates from QScrollArea.
3200         (WebCore::ScrollView::contentsToWindow):
3201         (WebCore::ScrollView::windowToContents):
3202
3203 2006-11-02  Simon Hausmann  <hausmann@kde.org>
3204
3205         Reviewed by Maciej, landed by Anders
3206
3207         * CMakeLists.txt: Make linkage against KDE libraries conditional
3208         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
3209           Qt base resource handler that supports only requests to the
3210           local filesystem. Used when compiling without KDE support.
3211           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
3212           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
3213         (WebCore::QtJob::QtJob):
3214         (WebCore::QtJob::timerEvent):
3215         (WebCore::ResourceHandleManager::ResourceHandleManager):
3216         (WebCore::ResourceHandleManager::~ResourceHandleManager):
3217         (WebCore::ResourceHandleManager::self):
3218         (WebCore::ResourceHandleManager::remove):
3219         (WebCore::ResourceHandleManager::add):
3220         (WebCore::ResourceHandleManager::cancel):
3221         (WebCore::ResourceHandleManager::deliverJobData):
3222         * platform/network/qt/ResourceHandleManager.h:
3223         * platform/qt/FrameQtClient.cpp:
3224         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
3225         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
3226         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
3227         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
3228           input dialog functions when compiling without KDE support
3229         (WebCore::ServeSynchronousRequest):
3230
3231 2006-11-02  David Carson  <dacarson@gmail.com>
3232
3233         Reviewed by Geoff, landed by Anders.
3234
3235         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
3236         Initializing variable in constructor.
3237
3238         * page/FramePrivate.h:
3239         (WebCore::FramePrivate::FramePrivate):
3240
3241 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
3242
3243         Reviewed by Geoff.
3244
3245         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
3246
3247         * platform/network/cf/ResourceHandleCFNet.cpp:
3248         (WebCore::addHeadersFromHashMap):
3249         Don't set all headers at once since that clears any previous headers set.
3250
3251         (WebCore::ResourceHandle::start):
3252
3253 2006-11-02  Adele Peterson  <adele@apple.com>
3254
3255         Reviewed by Mitz and Geoff.
3256
3257         - Fix for:
3258         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
3259         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
3260         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
3261
3262         Test: fast/forms/textarea-scrollbar.html
3263
3264         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
3265         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
3266
3267         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
3268         * rendering/RenderTextControl.cpp:
3269         (WebCore::RenderTextControl::RenderTextControl):
3270         (WebCore::RenderTextControl::setStyle):
3271         (WebCore::RenderTextControl::createDivStyle):
3272         (WebCore::RenderTextControl::updateFromElement):
3273         (WebCore::RenderTextControl::calcHeight):
3274         (WebCore::RenderTextControl::baselinePosition):
3275         (WebCore::RenderTextControl::nodeAtPoint):
3276         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
3277         (WebCore::RenderTextControl::scrollWidth):
3278         (WebCore::RenderTextControl::scrollHeight):
3279         (WebCore::RenderTextControl::scrollLeft):
3280         (WebCore::RenderTextControl::scrollTop):
3281
3282         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
3283
3284 2006-11-02  John Sullivan  <sullivan@apple.com>
3285
3286         Reviewed by Geoff Garen
3287
3288         * editing/Selection.cpp:
3289         (WebCore::Selection::showTreeForThis):
3290         this debugging method now displays start offset and end offset, at Darin's suggestion
3291
3292 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
3293
3294         Reviewed by darin
3295
3296         <rdar://problem/4062865>
3297         Copy/paste of a select element fails to include the options
3298
3299         * editing/SelectionController.cpp:
3300         (WebCore::SelectionController::modify): Added paragraphBoundary.
3301         * editing/htmlediting.cpp:
3302         (WebCore::canHaveChildrenForEditing): Added checks for input elements
3303         and textareas.  Insertion operations would fail when performed just
3304         before/after one of these elements b/c the content would be put inside
3305         the element.
3306         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
3307         editable content, and made the code to stop at an root faster (don't check
3308         isDescendantOf on every iteration).
3309         (WebCore::enclosingNodeOfType): Ditto.
3310         (WebCore::enclosingList): Ditto.
3311         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
3312         inappropriately named.
3313         * editing/markup.cpp:
3314         (WebCore::startMarkup): Use the text node's value instead of its rendered
3315         content for text nodes inside select elements.  One might also turn off
3316         annotation when createMarkup enters a select element, but createMarkup
3317         is iterative, not recursive, so doing so would be complicated.
3318         (WebCore::createMarkup): Add markup for unrendered nodes if they are
3319         descendants of a select element.
3320         * editing/visible_units.cpp:
3321         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
3322         where various replaced elements can't be copied when they are the only
3323         thing selected.
3324         (WebCore::endOfParagraph): Ditto.
3325
3326 2006-11-01  Oliver Hunt  <oliver@apple.com>
3327
3328         Reviewed by Adam.
3329
3330         Converting more or kcanvas/quartz from Obj-C to C++
3331         Minor SVG updates
3332         compatibility fixes
3333
3334         * WebCore.xcodeproj/project.pbxproj:
3335         * kcanvas/device/KRenderingPaintServer.h:
3336         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
3337         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3338         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
3339         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
3340         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
3341         * kcanvas/device/quartz/QuartzSupport.h:
3342         * ksvg2/css/SVGCSSStyleSelector.cpp:
3343         * ksvg2/misc/KCanvasRenderingStyle.h:
3344         * ksvg2/scripts/cssmakeprops:
3345         * ksvg2/scripts/cssmakevalues:
3346         * ksvg2/scripts/make_names.pl:
3347         * ksvg2/svg/SVGAnimateColorElement.cpp:
3348         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3349         * ksvg2/svg/SVGAnimationElement.cpp:
3350         * ksvg2/svg/SVGMaskElement.cpp:
3351         * ksvg2/svg/SVGPatternElement.cpp:
3352         * ksvg2/svg/svgpathparser.cpp:
3353         * platform/Path.cpp:
3354         * platform/graphics/svg/SVGResourceImage.h:
3355         * rendering/RenderPath.cpp:
3356         * rendering/SVGRenderAsText.cpp:
3357
3358 2006-11-02  Mitz Pettel  <mitz@webkit.org>
3359
3360         Reviewed by Adele.
3361
3362         - Fix a regression from r17521: painting of and crash caused by tables
3363           with collapsed borders
3364
3365         * rendering/RenderTable.cpp:
3366         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
3367         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
3368         and 'paintInfo' is the parameter, which we were accidently modifying.
3369
3370 2006-11-01  Adele Peterson  <adele@apple.com>
3371
3372         Reviewed by Mitz.
3373
3374         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
3375         REGRESSION: Incomplete repaint of overflow areas when deleting
3376
3377         Restrict the repaint rect for overflow blocks after the height has been fully computed.
3378         Also, adjust the repaint rect coordinates for the scroll offset.
3379
3380         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
3381         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
3382
3383 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
3384
3385         Reviewed by Mitz.
3386
3387         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
3388         Rename the "p" member variable of the PaintInfo struct to "context"
3389
3390         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
3391           'context' and 'rect' respectively.
3392
3393         - Assorted surrounding cleanups.
3394
3395         * rendering/EllipsisBox.cpp:
3396         (WebCore::EllipsisBox::paint):
3397         * rendering/EllipsisBox.h:
3398         * rendering/InlineBox.cpp:
3399         (WebCore::InlineBox::paint):
3400         * rendering/InlineFlowBox.cpp:
3401         (WebCore::InlineFlowBox::paint):
3402         (WebCore::InlineFlowBox::paintBackground):
3403         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3404         (WebCore::InlineFlowBox::paintDecorations):
3405         * rendering/InlineFlowBox.h:
3406         * rendering/InlineRunBox.h:
3407         * rendering/InlineTextBox.cpp:
3408         (WebCore::InlineTextBox::paint):
3409         * rendering/InlineTextBox.h:
3410         * rendering/RenderBlock.cpp:
3411         (WebCore::RenderBlock::paint):
3412         (WebCore::RenderBlock::paintChildren):
3413         (WebCore::RenderBlock::paintCaret):
3414         (WebCore::RenderBlock::paintObject):
3415         (WebCore::RenderBlock::paintFloats):
3416         (WebCore::RenderBlock::paintEllipsisBoxes):
3417         (WebCore::RenderBlock::paintSelection):
3418         (WebCore::RenderBlock::fillSelectionGaps):
3419         (WebCore::RenderBlock::fillInlineSelectionGaps):
3420         (WebCore::RenderBlock::fillBlockSelectionGaps):
3421         (WebCore::RenderBlock::fillHorizontalSelectionGap):
3422         (WebCore::RenderBlock::fillVerticalSelectionGap):
3423         (WebCore::RenderBlock::fillLeftSelectionGap):
3424         (WebCore::RenderBlock::fillRightSelectionGap):
3425         * rendering/RenderBox.cpp:
3426         (WebCore::RenderBox::paint):
3427         (WebCore::RenderBox::paintRootBoxDecorations):
3428         (WebCore::RenderBox::paintBoxDecorations):
3429         * rendering/RenderBox.h:
3430         * rendering/RenderButton.cpp:
3431         (WebCore::RenderButton::paintObject):
3432         * rendering/RenderFieldset.cpp:
3433         (WebCore::RenderFieldset::paintBoxDecorations):
3434         * rendering/RenderFileUploadControl.cpp:
3435         (WebCore::RenderFileUploadControl::paintObject):
3436         * rendering/RenderFlow.cpp:
3437         (WebCore::RenderFlow::continuationBefore):
3438         (WebCore::RenderFlow::addChildWithContinuation):
3439         (WebCore::RenderFlow::addChild):
3440         (WebCore::RenderFlow::attachLineBox):
3441         (WebCore::RenderFlow::destroy):
3442         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
3443         (WebCore::RenderFlow::dirtyLineBoxes):
3444         (WebCore::RenderFlow::createInlineBox):
3445         (WebCore::RenderFlow::paintLines):
3446         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3447         (WebCore::RenderFlow::lowestPosition):
3448         (WebCore::RenderFlow::rightmostPosition):
3449         (WebCore::RenderFlow::leftmostPosition):
3450         (WebCore::RenderFlow::caretRect):
3451         (WebCore::RenderFlow::addFocusRingRects):
3452         (WebCore::RenderFlow::paintOutline):
3453         (WebCore::RenderFlow::paintOutlineForLine):
3454         * rendering/RenderForeignObject.cpp:
3455         (WebCore::RenderForeignObject::paint):
3456         * rendering/RenderHTMLCanvas.cpp:
3457         (WebCore::RenderHTMLCanvas::paint):
3458         * rendering/RenderImage.cpp:
3459         (WebCore::RenderImage::paint):
3460         * rendering/RenderLayer.cpp:
3461         (WebCore::RenderLayer::paintLayer):
3462         * rendering/RenderListBox.cpp:
3463         (WebCore::RenderListBox::paintObject):
3464         (WebCore::RenderListBox::paintScrollbar):
3465         (WebCore::RenderListBox::paintItemForeground):
3466         (WebCore::RenderListBox::paintItemBackground):
3467         * rendering/RenderListMarker.cpp:
3468         (WebCore::RenderListMarker::paint):
3469         * rendering/RenderMenuList.cpp:
3470         (WebCore::RenderMenuList::paintObject):
3471         * rendering/RenderObject.cpp:
3472         (WebCore::RenderObject::paint):
3473         * rendering/RenderObject.h:
3474         (WebCore::RenderObject::PaintInfo::PaintInfo):
3475         (WebCore::RenderObject::paintBoxDecorations):
3476         (WebCore::RenderObject::paintingRootForChildren):
3477         (WebCore::RenderObject::shouldPaintWithinRoot):
3478         (WebCore::RenderObject::printBoxDecorations):
3479         * rendering/RenderPath.cpp:
3480         (WebCore::RenderPath::paint):
3481         * rendering/RenderReplaced.cpp:
3482         (WebCore::RenderReplaced::shouldPaint):
3483         * rendering/RenderSVGContainer.cpp:
3484         (WebCore::RenderSVGContainer::paint):
3485         * rendering/RenderSVGContainer.h:
3486         * rendering/RenderSVGImage.cpp:
3487         (WebCore::RenderSVGImage::paint):
3488         * rendering/RenderSVGText.cpp:
3489         (WebCore::RenderSVGText::paint):
3490         * rendering/RenderSVGText.h:
3491         (WebCore::RenderSVGText::renderName):
3492         * rendering/RenderTable.cpp:
3493         (WebCore::RenderTable::paint):
3494         (WebCore::RenderTable::paintBoxDecorations):
3495         * rendering/RenderTable.h:
3496         * rendering/RenderTableCell.cpp:
3497         (WebCore::RenderTableCell::paint):
3498         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3499         (WebCore::RenderTableCell::paintBoxDecorations):
3500         * rendering/RenderTableCell.h:
3501         * rendering/RenderTableRow.cpp:
3502         (WebCore::RenderTableRow::paint):
3503         * rendering/RenderTableRow.h:
3504         * rendering/RenderTableSection.cpp:
3505         (WebCore::RenderTableSection::paint):
3506         * rendering/RenderTableSection.h:
3507         (WebCore::RenderTableSection::getBaseline):
3508         (WebCore::RenderTableSection::setNeedCellRecalc):
3509         * rendering/RenderText.h:
3510         (WebCore::RenderText::renderName):
3511         (WebCore::RenderText::paint):
3512         (WebCore::RenderText::element):
3513         * rendering/RenderTheme.cpp:
3514         (WebCore::RenderTheme::paint):
3515         (WebCore::RenderTheme::paintBorderOnly):
3516         (WebCore::RenderTheme::paintDecorations):
3517         * rendering/RenderTheme.h:
3518         (WebCore::RenderTheme::RenderTheme):
3519         (WebCore::RenderTheme::~RenderTheme):
3520         (WebCore::RenderTheme::controlSupportsTints):
3521         (WebCore::RenderTheme::adjustRepaintRect):
3522         (WebCore::RenderTheme::themeChanged):
3523         (WebCore::RenderTheme::supportsHover):
3524         (WebCore::RenderTheme::paintCheckbox):
3525         (WebCore::RenderTheme::setCheckboxSize):
3526         (WebCore::RenderTheme::paintRadio):
3527         (WebCore::RenderTheme::setRadioSize):
3528         (WebCore::RenderTheme::paintButton):
3529         (WebCore::RenderTheme::setButtonSize):
3530         (WebCore::RenderTheme::paintTextField):
3531         (WebCore::RenderTheme::paintTextArea):
3532         (WebCore::RenderTheme::paintMenuList):
3533         (WebCore::RenderTheme::paintMenuListButton):
3534         * rendering/RenderThemeMac.mm:
3535         (WebCore::RenderThemeMac::paintCheckbox):
3536         (WebCore::RenderThemeMac::paintRadio):
3537         (WebCore::RenderThemeMac::paintButton):
3538         (WebCore::RenderThemeMac::paintTextField):
3539         (WebCore::RenderThemeMac::paintTextArea):
3540         (WebCore::RenderThemeMac::paintMenuList):