5088eb58981714e1a5d202bcbd3547bfa7535bca
[WebKit-https.git] / WebCore / ChangeLog
1 2010-09-22  Kent Tamura  <tkent@chromium.org>
2
3         Reviewed by Chris Fleizach.
4
5         Support keyboard operations for <input type=range>.
6         https://bugs.webkit.org/show_bug.cgi?id=45803
7
8         Increasing the value with Up/Right arrow keys by its step value,
9         and decreasing with Down/Left arrow keys. If an input element has
10         step=any attribute, increasing/decreasing by 1/100 of max-min.
11
12         Note: This change is not useful on Mac because users can't set
13         focus on range controls.
14
15         Test: fast/forms/range-keyoperation.html
16
17         * html/HTMLInputElement.cpp:
18         (WebCore::HTMLInputElement::defaultEventHandler):
19           Calls handleKeyEventForRange() for RANGE and key events.
20         (WebCore::HTMLInputElement::handleKeyEventForRange):
21         * html/HTMLInputElement.h: Add handleKeyEventForRange() declaration.
22
23 2010-09-22  Mario Sanchez Prada  <msanchez@igalia.com>
24
25         Reviewed by Chris Fleizach.
26
27         [Gtk] Incorrect exposure of list items whose children are elements
28         https://bugs.webkit.org/show_bug.cgi?id=45383
29
30         Set ATK_ROLE_LIST_ITEM looking for the role of the parent object
31
32         Test: platform/gtk/accessibility/list-items-always-exposed.html
33
34         * accessibility/gtk/AccessibilityObjectAtk.cpp:
35         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
36         Always include objects with ListItemRole in accessibility for GTK.
37         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
38         (getInterfaceMaskFromObject): Add some specific code to handle the
39         special case of list markers by implementing AtkText when needed.
40
41 2010-09-22  Dirk Schulze  <krit@webkit.org>
42
43         Reviewed by Nikolas Zimmermann.
44
45         Make FilterEffects independent of SVG
46         https://bugs.webkit.org/show_bug.cgi?id=46177
47
48         Moving all FilterEffects from svg/graphics/filters to platform/graphics/filters, now that they
49         are independent of SVG. Removed the SVG prefix of the files and updated the headers.
50
51         * Android.mk:
52         * CMakeLists.txt:
53         * GNUmakefile.am:
54         * WebCore.gypi:
55         * WebCore.pro:
56         * WebCore.vcproj/WebCore.vcproj:
57         * WebCore.xcodeproj/project.pbxproj:
58         * platform/graphics/filters/DistantLightSource.h: Copied from WebCore/svg/graphics/filters/SVGDistantLightSource.h.
59         * platform/graphics/filters/FEConvolveMatrix.cpp: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp.
60         * platform/graphics/filters/FEConvolveMatrix.h: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h.
61         * platform/graphics/filters/FEDiffuseLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.cpp.
62         * platform/graphics/filters/FEDiffuseLighting.h: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h.
63         * platform/graphics/filters/FEDisplacementMap.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.cpp.
64         * platform/graphics/filters/FEDisplacementMap.h: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.h.
65         * platform/graphics/filters/FEFlood.cpp: Copied from WebCore/svg/graphics/filters/SVGFEFlood.cpp.
66         * platform/graphics/filters/FEFlood.h: Copied from WebCore/svg/graphics/filters/SVGFEFlood.h.
67         * platform/graphics/filters/FELighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFELighting.cpp.
68         * platform/graphics/filters/FELighting.h: Copied from WebCore/svg/graphics/filters/SVGFELighting.h.
69         * platform/graphics/filters/FEMerge.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMerge.cpp.
70         * platform/graphics/filters/FEMerge.h: Copied from WebCore/svg/graphics/filters/SVGFEMerge.h.
71         * platform/graphics/filters/FEMorphology.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.cpp.
72         * platform/graphics/filters/FEMorphology.h: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.h.
73         * platform/graphics/filters/FEOffset.cpp: Copied from WebCore/svg/graphics/filters/SVGFEOffset.cpp.
74         * platform/graphics/filters/FEOffset.h: Copied from WebCore/svg/graphics/filters/SVGFEOffset.h.
75         * platform/graphics/filters/FESpecularLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.cpp.
76         * platform/graphics/filters/FESpecularLighting.h: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.h.
77         * platform/graphics/filters/FETile.cpp: Copied from WebCore/svg/graphics/filters/SVGFETile.cpp.
78         * platform/graphics/filters/FETile.h: Copied from WebCore/svg/graphics/filters/SVGFETile.h.
79         * platform/graphics/filters/FETurbulence.cpp: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.cpp.
80         * platform/graphics/filters/FETurbulence.h: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.h.
81         * platform/graphics/filters/LightSource.cpp: Copied from WebCore/svg/graphics/filters/SVGLightSource.cpp.
82         * platform/graphics/filters/LightSource.h: Copied from WebCore/svg/graphics/filters/SVGLightSource.h.
83         * platform/graphics/filters/PointLightSource.h: Copied from WebCore/svg/graphics/filters/SVGPointLightSource.h.
84         * platform/graphics/filters/SpotLightSource.h: Copied from WebCore/svg/graphics/filters/SVGSpotLightSource.h.
85         * svg/SVGFEConvolveMatrixElement.h:
86         * svg/SVGFEDiffuseLightingElement.cpp:
87         * svg/SVGFEDisplacementMapElement.h:
88         * svg/SVGFEDistantLightElement.cpp:
89         * svg/SVGFEFloodElement.h:
90         * svg/SVGFELightElement.h:
91         * svg/SVGFEMergeElement.h:
92         * svg/SVGFEMorphologyElement.h:
93         * svg/SVGFEOffsetElement.h:
94         * svg/SVGFEPointLightElement.cpp:
95         * svg/SVGFESpecularLightingElement.h:
96         * svg/SVGFESpotLightElement.cpp:
97         * svg/SVGFETileElement.h:
98         * svg/SVGFETurbulenceElement.h:
99         * svg/graphics/filters/SVGDistantLightSource.h: Removed.
100         * svg/graphics/filters/SVGFEConvolveMatrix.cpp: Removed.
101         * svg/graphics/filters/SVGFEConvolveMatrix.h: Removed.
102         * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Removed.
103         * svg/graphics/filters/SVGFEDiffuseLighting.h: Removed.
104         * svg/graphics/filters/SVGFEDisplacementMap.cpp: Removed.
105         * svg/graphics/filters/SVGFEDisplacementMap.h: Removed.
106         * svg/graphics/filters/SVGFEFlood.cpp: Removed.
107         * svg/graphics/filters/SVGFEFlood.h: Removed.
108         * svg/graphics/filters/SVGFELighting.cpp: Removed.
109         * svg/graphics/filters/SVGFELighting.h: Removed.
110         * svg/graphics/filters/SVGFEMerge.cpp: Removed.
111         * svg/graphics/filters/SVGFEMerge.h: Removed.
112         * svg/graphics/filters/SVGFEMorphology.cpp: Removed.
113         * svg/graphics/filters/SVGFEMorphology.h: Removed.
114         * svg/graphics/filters/SVGFEOffset.cpp: Removed.
115         * svg/graphics/filters/SVGFEOffset.h: Removed.
116         * svg/graphics/filters/SVGFESpecularLighting.cpp: Removed.
117         * svg/graphics/filters/SVGFESpecularLighting.h: Removed.
118         * svg/graphics/filters/SVGFETile.cpp: Removed.
119         * svg/graphics/filters/SVGFETile.h: Removed.
120         * svg/graphics/filters/SVGFETurbulence.cpp: Removed.
121         * svg/graphics/filters/SVGFETurbulence.h: Removed.
122         * svg/graphics/filters/SVGLightSource.cpp: Removed.
123         * svg/graphics/filters/SVGLightSource.h: Removed.
124         * svg/graphics/filters/SVGPointLightSource.h: Removed.
125         * svg/graphics/filters/SVGSpotLightSource.h: Removed.
126
127 2010-09-22  Patrick Gansterer  <paroga@webkit.org>
128
129         Reviewed by Adam Roben.
130
131         [WIN] Add internetHandle to WebCoreSynchronousLoader.
132         https://bugs.webkit.org/show_bug.cgi?id=46185
133
134         For loading content via network the WebCoreSynchronousLoader needs its own (synchronous) internetHandle.
135         This also adds asynchronousInternetHandle() to create a static asynchronous internetHandle.
136
137         * platform/network/win/ResourceHandleWin.cpp:
138         (WebCore::createInternetHandle):
139         (WebCore::asynchronousInternetHandle):
140         (WebCore::WebCoreSynchronousLoader::internetHandle):
141         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Create synchronous internetHandle.
142         (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Delete synchronous internetHandle.
143
144 2010-09-22  Kwang Yul Seo  <skyul@company100.net>
145
146         Reviewed by Chris Fleizach.
147
148         [chromium] Remove unused sys/types.h in VDMXParser.cpp
149         https://bugs.webkit.org/show_bug.cgi?id=46136
150
151         sys/types.h is not needed here.
152
153         * platform/graphics/chromium/VDMXParser.cpp:
154
155 2010-09-22  Kwang Yul Seo  <skyul@company100.net>
156
157         Reviewed by Kent Tamura.
158
159         [BREWMP] Change the home directory path to the WebKit module directory
160         https://bugs.webkit.org/show_bug.cgi?id=45895
161
162         AEEFS_HOME_DIR denotes the currently running application's directory. 
163         Change it to fs:/~<clsid> to use the WebKit module directory as home.
164
165         * platform/brew/FileSystemBrew.cpp:
166         (WebCore::homeDirectoryPath):
167
168 2010-09-22  Kwang Yul Seo  <skyul@company100.net>
169
170         Reviewed by Kent Tamura.
171
172         [BREWMP] Add dummy Pasteboard
173         https://bugs.webkit.org/show_bug.cgi?id=46107
174
175         Pasteboard is not supported yet. Add dummy implementation to avoid link errors.
176
177         * platform/brew/PasteboardBrew.cpp: Added.
178         (WebCore::Pasteboard::generalPasteboard):
179         (WebCore::Pasteboard::Pasteboard):
180         (WebCore::Pasteboard::clear):
181         (WebCore::Pasteboard::writeSelection):
182         (WebCore::Pasteboard::writePlainText):
183         (WebCore::Pasteboard::writeURL):
184         (WebCore::Pasteboard::writeImage):
185         (WebCore::Pasteboard::canSmartReplace):
186         (WebCore::Pasteboard::plainText):
187         (WebCore::Pasteboard::documentFragment):
188
189 2010-09-21  Ryosuke Niwa  <rniwa@webkit.org>
190
191         Reviewed by Kent Tamura.
192
193         Each EntityMaskIn* needs explanation
194         https://bugs.webkit.org/show_bug.cgi?id=44833
195
196         Added a description as to why we escape nbsp when serializing HTML documents but not when serializing XML documents.
197
198         * editing/markup.cpp:
199
200 2010-09-21  Ryosuke Niwa  <rniwa@webkit.org>
201
202         Reviewed by Kent Tamura.
203
204         cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged
205         https://bugs.webkit.org/show_bug.cgi?id=46205
206
207         Cleanup required to fix the bug 27818. Added the style extraction mechanism to removeInlineStyleFromElement
208         and removeCSSStyle and replaced the call to extractInlineStyleToPushDown by a call to removeInlineStyleFromElement.
209
210         * editing/ApplyStyleCommand.cpp:
211         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle argument.
212         (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle argument.
213         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement instead of
214         extractInlineStyleToPushDown which has been deleted.
215         * editing/ApplyStyleCommand.h:
216
217 2010-09-21  Andrew Wilson  <atwilson@chromium.org>
218
219         Unreviewed, rolling out r67982.
220         http://trac.webkit.org/changeset/67982
221         https://bugs.webkit.org/show_bug.cgi?id=45156
222
223         Causes crashes on chromium testshell
224
225         * WebCore.gypi:
226         * accessibility/chromium/AXObjectCacheChromium.cpp:
227         (WebCore::AXObjectCache::postPlatformNotification):
228         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
229         (WebCore::AXObjectCache::handleScrolledToAnchor):
230         * dom/Document.cpp:
231         (WebCore::Document::implicitClose):
232         (WebCore::Document::setFocusedNode):
233         * editing/SelectionController.h:
234         * editing/chromium/SelectionControllerChromium.cpp: Removed.
235         * page/FrameView.cpp:
236         (WebCore::FrameView::layout):
237         * page/chromium/ChromeClientChromium.h:
238
239 2010-09-21  Cosmin Truta  <ctruta@chromium.org>
240
241         Reviewed by James Robinson.
242
243         RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
244         https://bugs.webkit.org/show_bug.cgi?id=46120
245
246         Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.
247
248         * rendering/RenderImage.h:
249         (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
250         * html/HTMLImageElement.cpp:
251         (HTMLImageElement::createRenderer): Fixed indentation.
252
253 2010-09-21  Kenneth Russell  <kbr@google.com>
254
255         Reviewed by James Robinson.
256
257         [chromium] Remove GLES2Context and WebGLES2Context
258         https://bugs.webkit.org/show_bug.cgi?id=46131
259
260         Removed now-obsolete GLES2Context and WebGLES2Context classes, and
261         dependency on command buffer client code from WebCore. Built and
262         tested 3D CSS and WebGL content on Mac OS X to test.
263
264         * WebCore.gypi:
265         * platform/chromium/GLES2Context.h: Removed.
266         * platform/graphics/skia/ImageSkia.cpp:
267
268 2010-09-21  Geoffrey Garen  <ggaren@apple.com>
269
270         Try to fix the Windows build.
271
272         * loader/Cache.cpp:
273         (WebCore::Cache::makeResourcePurgeable):
274         (WebCore::Cache::evict): Cast to int before using unary '-', to avoid an
275         MSVC warning.
276
277 2010-09-21  Pratik Solanki  <psolanki@apple.com>
278
279         Reviewed by Geoffrey Garen and Darin Adler.
280
281         Use purgeable memory to keep more dead resources in cache
282         https://bugs.webkit.org/show_bug.cgi?id=44806
283         <rdar://problem/8350901>
284
285         This changes the behavior of dead resources in the WebCore cache to be the following if
286         shouldMakeResourcePurgeableOnEviction() returns true.
287
288         1. Dead resources in the cache are kept in non-purgeable memory.
289         2. When we prune dead resources, instead of freeing them, we mark their memory as purgeable
290         and keep the resources until the kernel reclaims the purgeable memory.
291
292         By leaving the in-cache dead resources in dirty resident memory, we decrease the likelihood
293         of the kernel claiming that memory and forcing us to refetch the resource (for example when
294         a user presses back).
295
296         And by having an unbounded number of resource objects using purgeable memory, we can use
297         as much memory as is available on the machine. The trade-off is that the CachedResource
298         object (and its member variables) are allocated in non-purgeable TC-malloc'd memory so
299         we would see slightly more memory use due to this.
300
301         * loader/Cache.cpp:
302         (WebCore::Cache::resourceForURL): Adjust sizes appropriately if we made resource memory
303         non-purgeable.
304         (WebCore::Cache::pruneDeadResources): When removing dead resources, try first to mark their
305         memory as purgeable. If not, evict the resource.
306         (WebCore::Cache::makeResourcePurgeable): Added. Try to mark resource
307         memory as purgeable. If successful, adjust the sizes so that we don't
308         factor this resources size in the Cache size calculation.
309         (WebCore::Cache::evict): Don't decrement size if we already did it in makeResourcePurgeable.
310         (WebCore::Cache::dumpLRULists): Extra debug logging.
311         * loader/Cache.h:
312         (WebCore::Cache::shouldMakeResourcePurgeableOnEviction): Added. Indicates if the new
313         behaviour is enabled.
314         * loader/CachedCSSStyleSheet.cpp:
315         (WebCore::CachedCSSStyleSheet::allClientsRemoved): Do not mark memory as purgeable. The
316         Cache class takes care of this.
317         * loader/CachedImage.cpp:
318         (WebCore::CachedImage::destroyDecodedData): Ditto.
319         * loader/CachedScript.cpp:
320         (WebCore::CachedScript::destroyDecodedData): Ditto.
321
322 2010-09-21  Dan Bernstein  <mitz@apple.com>
323
324         Reviewed by Darin Adler.
325
326         <rdar://problem/7729077> Extending the selection to sentence boundary after a line break may select extra character
327         https://bugs.webkit.org/show_bug.cgi?id=46232
328
329         Test: editing/selection/extend-by-sentence-002.html
330
331         * editing/visible_units.cpp:
332         (WebCore::nextBoundary): The text iterator’s range end can be the position after
333         the line break, in which case the next visible is actually after the first character
334         of the next sentence. Instead, advance the text iterator past the newline character
335         and return the beginning of its range, which is guaranteed to still be before the
336         next sentence.
337
338 2010-09-21  Robert Hogan  <robert@webkit.org>
339
340         Rubber-stamped by Ariya Hidayat.
341
342         [Qt] Build fix against qt trunk
343
344         * platform/graphics/qt/ContextShadow.cpp:
345         (WebCore::ContextShadow::beginShadowLayer):
346
347 2010-09-21  Tony Chang  <tony@chromium.org>
348
349         Unreviewed, QT build fix.
350
351         * platform/qt/ClipboardQt.cpp:
352         (WebCore::ClipboardQt::ClipboardQt):
353
354 2010-09-21  Andy Estes  <aestes@apple.com>
355
356         Reviewed by Darin Adler.
357
358         REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
359         https://bugs.webkit.org/show_bug.cgi?id=46134
360
361         * WebCore.exp.in: Export __ZN7WebCore32applicationIsAOLInstantMessengerEv.
362         * platform/mac/RuntimeApplicationChecks.h:
363         * platform/mac/RuntimeApplicationChecks.mm:
364         (WebCore::applicationIsAOLInstantMessenger): Determine if the embedding
365         application is AOL Instant Messenger by checking the bundle identifier.
366
367 2010-09-21  Chris Guillory   <chris.guillory@google.com>
368
369         Reviewed by Chris Fleizach.
370
371         Send webkit accessibility notifications to Chromium.
372         https://bugs.webkit.org/show_bug.cgi?id=45156
373
374         * WebCore.gypi:
375         * accessibility/chromium/AXObjectCacheChromium.cpp:
376         (WebCore::AXObjectCache::postPlatformNotification):
377         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
378         (WebCore::AXObjectCache::handleScrolledToAnchor):
379         * dom/Document.cpp:
380         (WebCore::Document::implicitClose):
381         (WebCore::Document::setFocusedNode):
382         * editing/SelectionController.h:
383         * editing/chromium/SelectionControllerChromium.cpp: Added.
384         (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
385         * page/FrameView.cpp:
386         (WebCore::FrameView::layout):
387         * page/chromium/ChromeClientChromium.h:
388
389 2010-09-21  Alejandro G. Castro  <alex@igalia.com>
390
391         Reviewed by Martin Robinson.
392
393         [gtk] Move copyContextProperties outside the GraphicsContextCairo
394         https://bugs.webkit.org/show_bug.cgi?id=46179.
395
396         Moved the copyContextProperties function to the CairoUtilities so
397         we can use it outside GraphicsContextCairo. We moved also the old
398         gtk CairoUtilities file to GdkCairoUtilities and added the new
399         file in the cairo directory.
400
401         * GNUmakefile.am:
402         * platform/graphics/cairo/CairoUtilities.cpp: Added.
403         (WebCore::copyContextProperties):
404         * platform/graphics/cairo/CairoUtilities.h: Added.
405         * platform/graphics/cairo/GraphicsContextCairo.cpp:
406         * platform/graphics/gtk/CairoUtilities.cpp: Removed.
407         * platform/graphics/gtk/CairoUtilities.h: Removed.
408         * platform/graphics/gtk/GdkCairoUtilities.cpp: Added.
409         (getCairoSurfacePixel):
410         (getGdkPixbufPixel):
411         (cairoImageSurfaceToGdkPixbuf):
412         * platform/graphics/gtk/GdkCairoUtilities.h: Added.
413         * platform/graphics/gtk/ImageBufferGtk.cpp:
414         * platform/graphics/gtk/ImageGtk.cpp:
415
416 2010-09-21  Vangelis Kokkevis  <vangelis@chromium.org>
417
418         Reviewed by James Robinson.
419
420         [chromium] Cleaned up LayerRendererChromium::prepareToDrawLayers
421         logic to avoid unnecessary copy operations if the existing root layer
422         contents aren't useful for scrolling. Also removed call to updateLayersRecursive()
423         as the composited layer update is actually happening in the drawLayers() method.
424         https://bugs.webkit.org/show_bug.cgi?id=46199
425
426
427         * platform/graphics/chromium/LayerRendererChromium.cpp:
428         (WebCore::LayerRendererChromium::prepareToDrawLayers):
429
430 2010-09-21  Daniel Cheng  <dcheng@chromium.org>
431
432         Reviewed by Tony Chang.
433
434         Change Clipboard to use an enum instead of isForDragging = true/false
435         https://bugs.webkit.org/show_bug.cgi?id=46004
436
437         No new tests, since it's just a refactoring change.
438
439         * bindings/js/JSClipboardCustom.cpp:
440         (WebCore::JSClipboard::setDragImage):
441         * bindings/v8/custom/V8ClipboardCustom.cpp:
442         (WebCore::V8Clipboard::setDragImageCallback):
443         * dom/Clipboard.cpp:
444         (WebCore::Clipboard::Clipboard):
445         (WebCore::Clipboard::setDropEffect):
446         (WebCore::Clipboard::setEffectAllowed):
447         * dom/Clipboard.h:
448         (WebCore::Clipboard::isForCopyAndPaste):
449         (WebCore::Clipboard::isForDragAndDrop):
450         * editing/android/EditorAndroid.cpp:
451         (WebCore::Editor::newGeneralClipboard):
452         * editing/brew/EditorBrew.cpp:
453         (WebCore::Editor::newGeneralClipboard):
454         * editing/chromium/EditorChromium.cpp:
455         (WebCore::Editor::newGeneralClipboard):
456         * editing/haiku/EditorHaiku.cpp:
457         (WebCore::Editor::newGeneralClipboard):
458         * editing/mac/EditorMac.mm:
459         (WebCore::Editor::newGeneralClipboard):
460         * editing/wx/EditorWx.cpp:
461         (WebCore::Editor::newGeneralClipboard):
462         * page/chromium/EventHandlerChromium.cpp:
463         (WebCore::EventHandler::createDraggingClipboard):
464         * page/efl/EventHandlerEfl.cpp:
465         (WebCore::EventHandler::createDraggingClipboard):
466         * page/gtk/EventHandlerGtk.cpp:
467         (WebCore::EventHandler::createDraggingClipboard):
468         * page/haiku/EventHandlerHaiku.cpp:
469         (WebCore::EventHandler::createDraggingClipboard):
470         * page/mac/EventHandlerMac.mm:
471         (WebCore::EventHandler::createDraggingClipboard):
472         * page/qt/EventHandlerQt.cpp:
473         (WebCore::EventHandler::createDraggingClipboard):
474         * page/win/EventHandlerWin.cpp:
475         (WebCore::EventHandler::createDraggingClipboard):
476         * page/wx/EventHandlerWx.cpp:
477         (WebCore::EventHandler::createDraggingClipboard):
478         * platform/android/ClipboardAndroid.cpp:
479         (WebCore::ClipboardAndroid::ClipboardAndroid):
480         (WebCore::ClipboardAndroid::clearData):
481         (WebCore::ClipboardAndroid::clearAllData):
482         (WebCore::ClipboardAndroid::setData):
483         * platform/android/ClipboardAndroid.h:
484         * platform/brew/ClipboardBrew.cpp:
485         (WebCore::ClipboardBrew::ClipboardBrew):
486         (WebCore::ClipboardBrew::clearData):
487         (WebCore::ClipboardBrew::clearAllData):
488         (WebCore::ClipboardBrew::setData):
489         * platform/brew/ClipboardBrew.h:
490         * platform/chromium/ClipboardChromium.cpp:
491         (WebCore::Clipboard::create):
492         (WebCore::ClipboardChromium::ClipboardChromium):
493         (WebCore::ClipboardChromium::create):
494         (WebCore::ClipboardChromium::getData):
495         * platform/chromium/ClipboardChromium.h:
496         * platform/efl/ClipboardEfl.cpp:
497         (WebCore::Editor::newGeneralClipboard):
498         (WebCore::ClipboardEfl::ClipboardEfl):
499         * platform/efl/ClipboardEfl.h:
500         (WebCore::ClipboardEfl::create):
501         * platform/gtk/ClipboardGtk.cpp:
502         (WebCore::Editor::newGeneralClipboard):
503         (WebCore::Clipboard::create):
504         (WebCore::ClipboardGtk::ClipboardGtk):
505         (WebCore::dataObjectTypeFromHTMLClipboardType):
506         (WebCore::ClipboardGtk::clearData):
507         (WebCore::ClipboardGtk::getData):
508         (WebCore::ClipboardGtk::setData):
509         * platform/gtk/ClipboardGtk.h:
510         (WebCore::ClipboardGtk::create):
511         * platform/haiku/ClipboardHaiku.cpp:
512         (WebCore::Clipboard::create):
513         (WebCore::ClipboardHaiku::ClipboardHaiku):
514         * platform/haiku/ClipboardHaiku.h:
515         (WebCore::ClipboardHaiku::create):
516         * platform/mac/ClipboardMac.h:
517         (WebCore::ClipboardMac::create):
518         * platform/mac/ClipboardMac.mm:
519         (WebCore::Clipboard::create):
520         (WebCore::ClipboardMac::ClipboardMac):
521         * platform/qt/ClipboardQt.cpp:
522         (WebCore::ClipboardQt::ClipboardQt):
523         (WebCore::ClipboardQt::~ClipboardQt):
524         (WebCore::ClipboardQt::clearData):
525         (WebCore::ClipboardQt::clearAllData):
526         (WebCore::ClipboardQt::setData):
527         (WebCore::ClipboardQt::declareAndWriteDragImage):
528         (WebCore::ClipboardQt::writeURL):
529         (WebCore::ClipboardQt::writeRange):
530         (WebCore::ClipboardQt::writePlainText):
531         * platform/qt/ClipboardQt.h:
532         (WebCore::ClipboardQt::create):
533         * platform/win/ClipboardWin.cpp:
534         (WebCore::Clipboard::create):
535         (WebCore::ClipboardWin::ClipboardWin):
536         (WebCore::ClipboardWin::clearData):
537         (WebCore::ClipboardWin::clearAllData):
538         (WebCore::ClipboardWin::setData):
539         (WebCore::ClipboardWin::setExternalDataObject):
540         * platform/win/ClipboardWin.h:
541         (WebCore::ClipboardWin::create):
542         * platform/win/EditorWin.cpp:
543         (WebCore::Editor::newGeneralClipboard):
544         * platform/wx/ClipboardWx.cpp:
545         (WebCore::ClipboardWx::ClipboardWx):
546         * platform/wx/ClipboardWx.h:
547         (WebCore::ClipboardWx::create):
548
549 2010-09-21  Abhishek Arya  <inferno@chromium.org>
550
551         Reviewed by Dave Hyatt.
552
553         Take isValueList() checks out of the asserts for memory safety.
554         https://bugs.webkit.org/show_bug.cgi?id=46194
555
556         Test: editing/execCommand/apply-style-text-decoration-crash.html
557
558         * editing/ApplyStyleCommand.cpp:
559         (WebCore::StyleChange::extractTextStyles):
560         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
561
562 2010-09-21  Vangelis Kokkevis  <vangelis@chromium.org>
563
564         Reviewed by Kenneth Russell.
565
566         [chromium] Fixing double translation of composited layers when scrolling.
567         The scrolling transform is now applied by a separate layer maintained in
568         the RenderLayerCompositor.
569         https://bugs.webkit.org/show_bug.cgi?id=46193
570
571         * platform/graphics/chromium/LayerRendererChromium.cpp:
572         (WebCore::LayerRendererChromium::drawLayers):
573
574 2010-09-21  David Hyatt  <hyatt@apple.com>
575
576         Reviewed by Dan Bernstein.
577
578         https://bugs.webkit.org/show_bug.cgi?id=46196, add marginStart/Before/End/After accessors to RenderBoxModelObject.
579
580         * rendering/RenderBox.cpp:
581         (WebCore::RenderBox::marginBefore):
582         (WebCore::RenderBox::marginAfter):
583         (WebCore::RenderBox::marginStart):
584         (WebCore::RenderBox::marginEnd):
585         * rendering/RenderBox.h:
586         * rendering/RenderBoxModelObject.h:
587         * rendering/RenderInline.cpp:
588         (WebCore::computeMargin):
589         (WebCore::RenderInline::marginLeft):
590         (WebCore::RenderInline::marginRight):
591         (WebCore::RenderInline::marginTop):
592         (WebCore::RenderInline::marginBottom):
593         (WebCore::RenderInline::marginStart):
594         (WebCore::RenderInline::marginEnd):
595         * rendering/RenderInline.h:
596         (WebCore::RenderInline::marginBefore):
597         (WebCore::RenderInline::marginAfter):
598
599 2010-09-21  David Hyatt  <hyatt@apple.com>
600
601         Reviewed by Dan Bernstein.
602
603         https://bugs.webkit.org/show_bug.cgi?id=46190, add borderStart/Before/End/After accessors to RenderBoxModelObject.
604
605         * rendering/RenderBoxModelObject.h:
606         (WebCore::RenderBoxModelObject::borderBefore):
607         (WebCore::RenderBoxModelObject::borderAfter):
608         (WebCore::RenderBoxModelObject::borderStart):
609         (WebCore::RenderBoxModelObject::borderEnd):
610         (WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
611         (WebCore::RenderBoxModelObject::borderAndPaddingLogicalWidth):
612         * rendering/RenderTableCell.cpp:
613         (WebCore::RenderTableCell::borderStart):
614         (WebCore::RenderTableCell::borderEnd):
615         (WebCore::RenderTableCell::borderBefore):
616         (WebCore::RenderTableCell::borderAfter):
617         * rendering/RenderTableCell.h:
618
619 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
620
621         Reviewed by Xan Lopez.
622
623         [GTK] 'make dist' should be fixed in preparation for the next release
624         https://bugs.webkit.org/show_bug.cgi?id=46129
625
626         * GNUmakefile.am: Update the sources list to include missing headers.
627
628 2010-09-21  David Hyatt  <hyatt@apple.com>
629
630         Reviewed by John Sullivan.
631
632         https://bugs.webkit.org/show_bug.cgi?id=46188, make the cross-platform setPrinting method match the Mac version of the method.
633         Specifically don't pass the page size down to subframes of the one you're printing.
634
635         * page/Frame.cpp:
636         (WebCore::Frame::setPrinting):
637
638 2010-09-21  Patrick Gansterer  <paroga@webkit.org>
639
640         Reviewed by Adam Roben.
641
642         Use WTF::Vector for storing formData in ResourceHandleWin.
643         https://bugs.webkit.org/show_bug.cgi?id=46180
644
645         * platform/network/ResourceHandleInternal.h:
646         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
647         * platform/network/win/ResourceHandleWin.cpp:
648         (WebCore::ResourceHandle::onHandleCreated):
649         (WebCore::ResourceHandle::onRequestComplete):
650
651 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
652
653         Reviewed by Andreas Kling.
654
655         [Qt] Check if the reply has been deleted before finishing a network request
656         https://bugs.webkit.org/show_bug.cgi?id=46174
657
658         A crash can happen with the following sequence:
659         1. QNetworkReplyHandler::abort() emits reply->deleteLater()
660         2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
661         3. event loop would call reply->deleteLater()
662         However a crash occurs since m_reply == 0 on step 2.
663
664         * platform/network/qt/QNetworkReplyHandler.cpp:
665         (WebCore::QNetworkReplyHandler::finish):
666
667 2010-09-21  Jochen Eisinger  <jochen@chromium.org>
668
669         Reviewed by Jeremy Orlow.
670
671         Use @ to concatenate the database name and the database identifier when building
672         the filename to use for indexed databases. That character is valid for filenames
673         but cannot occur in a database identifier derived from a security origin.
674         https://bugs.webkit.org/show_bug.cgi?id=46178
675
676         * storage/IDBFactoryBackendImpl.cpp:
677         (WebCore::IDBFactoryBackendImpl::databaseFileName):
678
679 2010-09-21  Steve Block  <steveblock@google.com>
680
681         Reviewed by Jeremy Orlow.
682
683         DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
684         https://bugs.webkit.org/show_bug.cgi?id=45891
685
686         Tested by existing DeviceOrientation tests.
687
688         * dom/DeviceMotionClient.h:
689         * dom/DeviceMotionController.cpp:
690         (WebCore::DeviceMotionController::~DeviceMotionController):
691         * dom/DeviceMotionController.h:
692         * dom/DeviceOrientationClient.h:
693         * dom/DeviceOrientationController.cpp:
694         (WebCore::DeviceOrientationController::~DeviceOrientationController):
695         * dom/DeviceOrientationController.h:
696         * loader/EmptyClients.h:
697         (WebCore::EmptyDeviceMotionClient::deviceOrientationControllerDestroyed):
698         (WebCore::EmptyDeviceOrientationClient::deviceOrientationControllerDestroyed):
699         * platform/mock/DeviceOrientationClientMock.h:
700         (WebCore::DeviceOrientationClientMock::deviceOrientationControllerDestroyed):
701
702 2010-09-21  Jochen Eisinger  <jochen@chromium.org>
703
704         Reviewed by Jeremy Orlow.
705
706         Factor out the file name used for a given indexed database to a static method.
707         https://bugs.webkit.org/show_bug.cgi?id=46090
708
709         * storage/IDBFactoryBackendImpl.cpp:
710         (WebCore::openSQLiteDatabase):
711         (WebCore::IDBFactoryBackendImpl::databaseFileName):
712         * storage/IDBFactoryBackendImpl.h:
713
714 2010-09-21  Dirk Schulze  <krit@webkit.org>
715
716         SVG Filter cleanup
717         https://bugs.webkit.org/show_bug.cgi?id=45612
718
719         Unreviewed change of epsilon back to a more tolerant value in RenderTreeAsText and made it a static const.
720         This should turn the bots green again.
721
722         * rendering/RenderTreeAsText.cpp:
723         (WebCore::hasFractions):
724
725 2010-09-21  David Hyatt  <hyatt@apple.com>
726
727         Reviewed by Dan Bernstein.
728
729         https://bugs.webkit.org/show_bug.cgi?id=46125, convert table cell intrinsic padding from top/bottom-based
730         to before/after-based.  A vertical text table can have intrinsic padding built into the left/right
731         direction (and this allows the base class logical padding methods on RenderBoxModelObject to be safe to use).
732
733         * rendering/RenderTableCell.cpp:
734         (WebCore::RenderTableCell::RenderTableCell):
735         (WebCore::RenderTableCell::paddingTop):
736         (WebCore::RenderTableCell::paddingBottom):
737         (WebCore::RenderTableCell::paddingLeft):
738         (WebCore::RenderTableCell::paddingRight):
739         (WebCore::RenderTableCell::paddingBefore):
740         (WebCore::RenderTableCell::paddingAfter):
741         * rendering/RenderTableCell.h:
742         (WebCore::RenderTableCell::setIntrinsicPaddingBefore):
743         (WebCore::RenderTableCell::setIntrinsicPaddingAfter):
744         (WebCore::RenderTableCell::setIntrinsicPadding):
745         (WebCore::RenderTableCell::intrinsicPaddingBefore):
746         (WebCore::RenderTableCell::intrinsicPaddingAfter):
747         * rendering/RenderTableSection.cpp:
748         (WebCore::RenderTableSection::calcRowHeight):
749         (WebCore::RenderTableSection::layoutRows):
750         * rendering/RenderTreeAsText.cpp:
751         (WebCore::RenderTreeAsText::writeRenderObject):
752         (WebCore::writeTextRun):
753
754 2010-09-21  Dirk Schulze  <krit@webkit.org>
755
756         Reviewed by Nikolas Zimmermann.
757
758         SVG Filter cleanup
759         https://bugs.webkit.org/show_bug.cgi?id=45612
760
761         Second cleanup patch. Modified files to follow webkit style. Removed dependencies
762         to SVG of most of the filter effects and prepared them to move from WebCore/svg/graphics/filters
763         to WebCore/platform/graphics/filters/.
764         Renamed calculateDrawingIntRect and calculateDrawingRect to requestedRegionOfInputImageData and
765         drawingRegionOfInputImage to clarify the functionality and make both functions distinguishable.
766
767         * platform/graphics/filters/FEBlend.cpp:
768         (WebCore::FEBlend::apply):
769         * platform/graphics/filters/FEBlend.h:
770         * platform/graphics/filters/FEColorMatrix.cpp:
771         (WebCore::FEColorMatrix::apply):
772         * platform/graphics/filters/FEColorMatrix.h:
773         * platform/graphics/filters/FEComponentTransfer.cpp:
774         (WebCore::FEComponentTransfer::apply):
775         * platform/graphics/filters/FEComponentTransfer.h:
776         (WebCore::ComponentTransferFunction::ComponentTransferFunction):
777         * platform/graphics/filters/FEComposite.cpp:
778         (WebCore::FEComposite::apply):
779         * platform/graphics/filters/FEComposite.h:
780         * platform/graphics/filters/FEGaussianBlur.cpp:
781         (WebCore::FEGaussianBlur::apply):
782         * platform/graphics/filters/FEGaussianBlur.h:
783         * platform/graphics/filters/Filter.h:
784         * platform/graphics/filters/FilterEffect.cpp:
785         (WebCore::FilterEffect::requestedRegionOfInputImageData):
786         (WebCore::FilterEffect::drawingRegionOfInputImage):
787         (WebCore::FilterEffect::effectContext):
788         * platform/graphics/filters/FilterEffect.h:
789         * platform/graphics/filters/ImageBufferFilter.cpp:
790         * platform/graphics/filters/ImageBufferFilter.h:
791         * platform/graphics/filters/SourceAlpha.cpp:
792         (WebCore::SourceAlpha::apply):
793         * platform/graphics/filters/SourceAlpha.h:
794         (WebCore::SourceAlpha::isSourceInput):
795         (WebCore::SourceAlpha::SourceAlpha):
796         * platform/graphics/filters/SourceGraphic.cpp:
797         (WebCore::SourceGraphic::apply):
798         * platform/graphics/filters/SourceGraphic.h:
799         (WebCore::SourceGraphic::isSourceInput):
800         (WebCore::SourceGraphic::SourceGraphic):
801         * rendering/RenderTreeAsText.cpp:
802         (WebCore::hasFractions):
803         (WebCore::operator<<):
804         * rendering/RenderTreeAsText.h:
805         (WebCore::operator<<):
806         * rendering/SVGRenderTreeAsText.cpp:
807         * rendering/SVGRenderTreeAsText.h:
808         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
809         (WebCore::FEConvolveMatrix::apply):
810         * svg/graphics/filters/SVGFEConvolveMatrix.h:
811         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
812         * svg/graphics/filters/SVGFEDiffuseLighting.h:
813         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
814         (WebCore::FEDisplacementMap::apply):
815         * svg/graphics/filters/SVGFEDisplacementMap.h:
816         * svg/graphics/filters/SVGFEFlood.cpp:
817         (WebCore::FEFlood::apply):
818         (WebCore::FEFlood::externalRepresentation):
819         * svg/graphics/filters/SVGFEFlood.h:
820         * svg/graphics/filters/SVGFEImage.cpp:
821         (WebCore::FEImage::apply):
822         * svg/graphics/filters/SVGFEImage.h:
823         * svg/graphics/filters/SVGFELighting.cpp:
824         (WebCore::FELighting::apply):
825         * svg/graphics/filters/SVGFELighting.h:
826         * svg/graphics/filters/SVGFEMerge.cpp:
827         (WebCore::FEMerge::apply):
828         * svg/graphics/filters/SVGFEMerge.h:
829         * svg/graphics/filters/SVGFEMorphology.cpp:
830         (WebCore::FEMorphology::apply):
831         * svg/graphics/filters/SVGFEMorphology.h:
832         * svg/graphics/filters/SVGFEOffset.cpp:
833         (WebCore::FEOffset::apply):
834         * svg/graphics/filters/SVGFEOffset.h:
835         * svg/graphics/filters/SVGFESpecularLighting.cpp:
836         * svg/graphics/filters/SVGFESpecularLighting.h:
837         * svg/graphics/filters/SVGFETile.cpp:
838         (WebCore::FETile::apply):
839         * svg/graphics/filters/SVGFETile.h:
840         * svg/graphics/filters/SVGFETurbulence.cpp:
841         (WebCore::FETurbulence::apply):
842         * svg/graphics/filters/SVGFETurbulence.h:
843
844 2010-09-20  Philippe Normand  <pnormand@igalia.com>
845
846         Reviewed by Eric Carlson.
847
848         [GTK] enhanced context menu for media elements
849         https://bugs.webkit.org/show_bug.cgi?id=45021
850
851         New items in the media Element context menu:
852         - play/pause
853         - mute/unmute
854         - controls display control
855         - switch to fullscreen (for video only)
856         - loop playback control
857         - copy media url to clipboard
858         - open in new window
859
860         Test: media/context-menu-actions.html
861
862         * page/ContextMenuController.cpp:
863         (WebCore::ContextMenuController::contextMenuItemSelected):
864         * platform/ContextMenu.cpp:
865         (WebCore::ContextMenu::populate):
866         (WebCore::ContextMenu::checkOrEnableIfNeeded):
867         * platform/ContextMenuItem.h:
868         * platform/LocalizationStrategy.h:
869         * platform/LocalizedStrings.cpp:
870         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
871         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
872         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
873         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
874         (WebCore::contextMenuItemTagToggleMediaControls):
875         (WebCore::contextMenuItemTagToggleMediaLoop):
876         (WebCore::contextMenuItemTagEnterVideoFullscreen):
877         (WebCore::contextMenuItemTagMediaPlay):
878         (WebCore::contextMenuItemTagMediaPause):
879         (WebCore::contextMenuItemTagMediaMute):
880         * platform/LocalizedStrings.h:
881         * platform/android/LocalizedStringsAndroid.cpp:
882         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
883         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
884         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
885         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
886         (WebCore::contextMenuItemTagToggleMediaControls):
887         (WebCore::contextMenuItemTagToggleMediaLoop):
888         (WebCore::contextMenuItemTagEnterVideoFullscreen):
889         (WebCore::contextMenuItemTagMediaPlay):
890         (WebCore::contextMenuItemTagMediaPause):
891         (WebCore::contextMenuItemTagMediaMute):
892         * platform/brew/LocalizedStringsBrew.cpp:
893         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
894         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
895         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
896         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
897         (WebCore::contextMenuItemTagToggleMediaControls):
898         (WebCore::contextMenuItemTagToggleMediaLoop):
899         (WebCore::contextMenuItemTagEnterVideoFullscreen):
900         (WebCore::contextMenuItemTagMediaPlay):
901         (WebCore::contextMenuItemTagMediaPause):
902         (WebCore::contextMenuItemTagMediaMute):
903         * platform/efl/LocalizedStringsEfl.cpp:
904         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
905         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
906         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
907         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
908         (WebCore::contextMenuItemTagToggleMediaControls):
909         (WebCore::contextMenuItemTagToggleMediaLoop):
910         (WebCore::contextMenuItemTagEnterVideoFullscreen):
911         (WebCore::contextMenuItemTagMediaPlay):
912         (WebCore::contextMenuItemTagMediaPause):
913         (WebCore::contextMenuItemTagMediaMute):
914         * platform/gtk/ContextMenuItemGtk.cpp:
915         (WebCore::gtkStockIDFromContextMenuAction):
916         * platform/gtk/LocalizedStringsGtk.cpp:
917         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
918         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
919         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
920         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
921         (WebCore::contextMenuItemTagToggleMediaControls):
922         (WebCore::contextMenuItemTagToggleMediaLoop):
923         (WebCore::contextMenuItemTagEnterVideoFullscreen):
924         (WebCore::contextMenuItemTagMediaPlay):
925         (WebCore::contextMenuItemTagMediaPause):
926         (WebCore::contextMenuItemTagMediaMute):
927         * platform/haiku/LocalizedStringsHaiku.cpp:
928         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
929         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
930         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
931         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
932         (WebCore::contextMenuItemTagToggleMediaControls):
933         (WebCore::contextMenuItemTagToggleMediaLoop):
934         (WebCore::contextMenuItemTagEnterVideoFullscreen):
935         (WebCore::contextMenuItemTagMediaPlay):
936         (WebCore::contextMenuItemTagMediaPause):
937         (WebCore::contextMenuItemTagMediaMute):
938         * platform/wx/LocalizedStringsWx.cpp:
939         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
940         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
941         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
942         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
943         (WebCore::contextMenuItemTagToggleMediaControls):
944         (WebCore::contextMenuItemTagToggleMediaLoop):
945         (WebCore::contextMenuItemTagEnterVideoFullscreen):
946         (WebCore::contextMenuItemTagMediaPlay):
947         (WebCore::contextMenuItemTagMediaPause):
948         (WebCore::contextMenuItemTagMediaMute):
949         * rendering/HitTestResult.cpp:
950         (WebCore::HitTestResult::absoluteMediaURL):
951         (WebCore::HitTestResult::mediaSupportsFullscreen):
952         (WebCore::HitTestResult::mediaElement):
953         (WebCore::HitTestResult::toggleMediaControlsDisplay):
954         (WebCore::HitTestResult::toggleMediaLoopPlayback):
955         (WebCore::HitTestResult::enterFullscreenForVideo):
956         (WebCore::HitTestResult::mediaControlsEnabled):
957         (WebCore::HitTestResult::mediaLoopEnabled):
958         (WebCore::HitTestResult::mediaPlaying):
959         (WebCore::HitTestResult::toggleMediaPlayState):
960         (WebCore::HitTestResult::mediaHasAudio):
961         (WebCore::HitTestResult::mediaMuted):
962         (WebCore::HitTestResult::toggleMediaMuteState):
963         * rendering/HitTestResult.h:
964
965 2010-09-20  Kwang Yul Seo  <skyul@company100.net>
966
967         Reviewed by Daniel Bates.
968
969         [BREWMP] Handle tab key
970         https://bugs.webkit.org/show_bug.cgi?id=46104
971
972         In Brew MP, AVK_FUNCTION is the key code for tab.
973         Process AVK_FUNCTION as tab in PlatformKeyboardEvent.
974
975         * platform/brew/PlatformKeyboardEventBrew.cpp:
976         (WebCore::keyIdentifierForBrewKeyCode):
977         (WebCore::windowsKeyCodeForKeyEvent):
978
979 2010-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
980
981         Unreviewed, rolling out r67918.
982         http://trac.webkit.org/changeset/67918
983         https://bugs.webkit.org/show_bug.cgi?id=46162
984
985         Broke chromium win compile (Requested by jamesr on #webkit).
986
987         * WebCore.gyp/WebCore.gyp:
988         * WebCore.gypi:
989         * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Renamed from WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp.
990         (WebCore::GlyphPage::fill):
991
992 2010-09-20  Daniel Bates  <dbates@rim.com>
993
994         Reviewed by Dan Bernstein.
995
996         Cleanup: Extract common border radii expansion code in
997         RenderBoxModelObject::paintBoxShadow() into function
998         https://bugs.webkit.org/show_bug.cgi?id=45934
999
1000         Extracted code for expanding and clamping the border radii
1001         into common function to remove duplicate code.
1002
1003         No functionality was changed. So, no new tests.
1004
1005         * rendering/RenderBoxModelObject.cpp:
1006         (WebCore::uniformlyExpandBorderRadii): Added.
1007         (WebCore::RenderBoxModelObject::paintBoxShadow): Moved common code to uniformlyExpandBorderRadii().
1008
1009 2010-09-20  Kwang Yul Seo  <skyul@company100.net>
1010
1011         Reviewed by James Robinson.
1012
1013         Make sure skia is not Chromium specific
1014         https://bugs.webkit.org/show_bug.cgi?id=39672
1015
1016         GGlyphPageTreeNodeLinux does not depend on Linux or Chromium.
1017         Move GGlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
1018         GlyphPageTreeNodeSkia.cpp so that other ports can use it.
1019
1020         * WebCore.gyp/WebCore.gyp:
1021         * WebCore.gypi:
1022         * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
1023         * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
1024
1025 2010-09-20  Kinuko Yasuda  <kinuko@chromium.org>
1026
1027         Reviewed by David Levin.
1028
1029         Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
1030         https://bugs.webkit.org/show_bug.cgi?id=46021
1031
1032         Added NoStaticTables attributes to IDLs except for ones for Callbacks.
1033         (As NoStaticTables only affects non-callback interfaces.)
1034
1035         * fileapi/DOMFileSystem.idl:
1036         * fileapi/DirectoryEntry.idl:
1037         * fileapi/DirectoryReader.idl:
1038         * fileapi/Entry.idl:
1039         * fileapi/EntryArray.idl:
1040         * fileapi/FileEntry.idl:
1041         * fileapi/Flags.idl:
1042         * fileapi/Metadata.idl:
1043
1044 2010-09-20  Nico Weber  <thakis@chromium.org>
1045
1046         Reviewed by Adam Barth.
1047
1048         Fix "operands of ? are integers of different signs" clang warnings
1049         https://bugs.webkit.org/show_bug.cgi?id=46157
1050
1051         * platform/graphics/mac/ComplexTextController.cpp:
1052         (WebCore::ComplexTextController::advance):
1053         * rendering/RenderBox.cpp:
1054         (WebCore::RenderBox::calcHeight):
1055
1056 2010-09-20  Vangelis Kokkevis  <vangelis@chromium.org>
1057
1058         Unreviewed, rolling out r67906.
1059         http://trac.webkit.org/changeset/67906
1060         https://bugs.webkit.org/show_bug.cgi?id=46139
1061
1062         Change causes chromium to crash when switching pages
1063
1064         * platform/graphics/chromium/ContentLayerChromium.h:
1065         * platform/graphics/chromium/LayerChromium.h:
1066
1067 2010-09-19  Antonio Gomes  <agomes@rim.com>
1068
1069         Reviewed by Ojan Vafai.
1070
1071         SelectionController::modify should ask EditingBehavior for platform specific behavior
1072         https://bugs.webkit.org/show_bug.cgi?id=41975
1073
1074         As a follow up of the refactoring work in bug 39854, patch makes SelectionController::modify()
1075         stop accessing EditingBehaviorType values directly, and replaces its use by the EditingBehavior
1076         class.
1077
1078         Since the "Settings*" parameter of the private SelectionController::modify() method becomes unneeded
1079         with this change (it was used to query the editingBehaviorType), patch merges two modify() methods.
1080
1081         No behavior change, so no new tests.
1082
1083         * editing/EditingBehavior.h:
1084         (WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
1085         * editing/SelectionController.cpp:
1086         (WebCore::SelectionController::modify):
1087         * editing/SelectionController.h:
1088
1089 2010-09-20  Vangelis Kokkevis  <vangelis@chromium.org>
1090
1091         Reviewed by James Robinson.
1092
1093         [chromium] Making destructors of LayerChromium and ContentLayerChromium virtual
1094         so that the derived class' destructor code gets called.
1095         https://bugs.webkit.org/show_bug.cgi?id=46139
1096
1097         * platform/graphics/chromium/ContentLayerChromium.h:
1098         * platform/graphics/chromium/LayerChromium.h:
1099
1100 2010-09-20  Darin Adler  <darin@apple.com>
1101
1102         Reviewed by James Robinson.
1103
1104         Deprecate the inputType function on HTMLInputElement
1105         https://bugs.webkit.org/show_bug.cgi?id=46023
1106
1107         * html/HTMLInputElement.cpp:
1108         (WebCore::HTMLInputElement::HTMLInputElement): Use m_deprecatedTypeNumber.
1109         (WebCore::HTMLInputElement::isValidValue): Use deprecatedInputType.
1110         (WebCore::HTMLInputElement::typeMismatch): Ditto.
1111         (WebCore::HTMLInputElement::valueMissing): Ditto.
1112         (WebCore::HTMLInputElement::rangeUnderflow): Ditto.
1113         (WebCore::HTMLInputElement::rangeOverflow): Ditto.
1114         (WebCore::HTMLInputElement::minimum): Ditto.
1115         (WebCore::HTMLInputElement::maximum): Ditto.
1116         (WebCore::HTMLInputElement::stepBase): Ditto.
1117         (WebCore::HTMLInputElement::stepMismatch): Ditto.
1118         (WebCore::HTMLInputElement::getStepParameters): Ditto.
1119         (WebCore::HTMLInputElement::getAllowedValueStep): Ditto.
1120         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
1121         (WebCore::HTMLInputElement::shouldUseInputMethod): Ditto.
1122         (WebCore::HTMLInputElement::handleBlurEvent): Ditto.
1123         (WebCore::HTMLInputElement::setType): Added a comment.
1124         (WebCore::HTMLInputElement::updateType): Replaced the setInputType function
1125         with this. The type is always the type attribute value, so there is no value
1126         in passing the type string in, and this is an internal implementation detail,
1127         not a public function.
1128         (WebCore::createFormControlTypes): Use deprecatedNumberOfTypes.
1129         (WebCore::HTMLInputElement::formControlType): Use deprecatedInputType.
1130         (WebCore::HTMLInputElement::saveFormControlState): Ditto.
1131         (WebCore::HTMLInputElement::restoreFormControlState): Ditto.
1132         (WebCore::HTMLInputElement::accessKeyAction): Ditto.
1133         (WebCore::HTMLInputElement::mapToEntry): Ditto.
1134         (WebCore::HTMLInputElement::parseMappedAttribute): Ditto.
1135         (WebCore::HTMLInputElement::rendererIsNeeded): Ditto.
1136         (WebCore::HTMLInputElement::createRenderer): Ditto.
1137         (WebCore::HTMLInputElement::attach): Ditto.
1138         (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Ditto.
1139         (WebCore::HTMLInputElement::appendFormData): Ditto.
1140         (WebCore::HTMLInputElement::isTextField): Ditto.
1141         (WebCore::HTMLInputElement::isTextType): Ditto.
1142         (WebCore::HTMLInputElement::setChecked): Ditto.
1143         (WebCore::HTMLInputElement::value): Ditto.
1144         (WebCore::HTMLInputElement::valueWithDefault): Ditto.
1145         (WebCore::HTMLInputElement::setSuggestedValue): Ditto.
1146         (WebCore::HTMLInputElement::setValue): Ditto.
1147         (WebCore::HTMLInputElement::parseToDouble): Ditto.
1148         (WebCore::HTMLInputElement::valueAsDate): Ditto.
1149         (WebCore::HTMLInputElement::setValueAsDate): Ditto.
1150         (WebCore::HTMLInputElement::valueAsNumber): Ditto.
1151         (WebCore::HTMLInputElement::setValueAsNumber): Ditto.
1152         (WebCore::HTMLInputElement::serializeForDateTimeTypes): Ditto.
1153         (WebCore::HTMLInputElement::serialize): Ditto.
1154         (WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
1155         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Ditto.
1156         (WebCore::HTMLInputElement::preDispatchEventHandler): Ditto.
1157         (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
1158         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
1159         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Ditto.
1160         (WebCore::HTMLInputElement::files): Ditto.
1161         (WebCore::HTMLInputElement::isAcceptableValue): Ditto.
1162         (WebCore::HTMLInputElement::sanitizeValue): Ditto.
1163         (WebCore::HTMLInputElement::hasUnacceptableValue): Ditto.
1164         (WebCore::HTMLInputElement::needsActivationCallback): Ditto.
1165         (WebCore::HTMLInputElement::isRequiredFormControl): Ditto.
1166         (WebCore::HTMLInputElement::recalcWillValidate): Ditto.
1167         (WebCore::HTMLInputElement::parseToDateComponents): Ditto.
1168         (WebCore::HTMLInputElement::dataList): Ditto.
1169         (WebCore::HTMLInputElement::isSpeechEnabled): Ditto.
1170
1171         * html/HTMLInputElement.h: Renamed InputType to DeprecatedInputType since it
1172         should not be used outside this class. Renamed numberOfTypes to
1173         dprecatedNumberOfTypes for the same reason. Changed all code to use
1174         deprecatedInputType function instead of m_type. Renamed inputType function
1175         to deprecatedInputType. Replaced public setInputType function with private
1176         updateType function. Renamed m_type data member to m_deprecatedTypeNumber.
1177
1178         * rendering/MediaControlElements.cpp:
1179         (WebCore::MediaControlInputElement::MediaControlInputElement):
1180         * rendering/RenderFileUploadControl.cpp:
1181         (WebCore::RenderFileUploadControl::updateFromElement):
1182         Use setType instead of setInputType.
1183
1184 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1185
1186         Unreviewed; an attempt to fix Windows build.
1187
1188         * WebCore.vcproj/WebCore.vcproj:
1189
1190 2010-09-20  Simon Fraser  <simon.fraser@apple.com>
1191
1192         Reviewed by Dan Bernstein.
1193
1194         When PDF image is directly composited, it does not display
1195         https://bugs.webkit.org/show_bug.cgi?id=46144
1196         
1197         In the "direct image compositing" code path, we set the image directly
1198         as the contents of the GraphicsLayer. However, this only works with
1199         bitmap images, so we have to check that the image is a bitmap image.
1200
1201         Test: compositing/images/direct-pdf-image.html
1202
1203         * rendering/RenderLayerBacking.cpp:
1204         (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
1205
1206 2010-09-20  Simon Fraser  <simon.fraser@apple.com>
1207
1208         Reviewed by Darin Adler.
1209
1210         Crash when div with content set to image gets composited (Vimeo).
1211         https://bugs.webkit.org/show_bug.cgi?id=46140
1212         
1213         When CSS specifies that the content of an element is an image, we make
1214         a RenderImage, and setStyle() before setting the image resource. In this
1215         case the compositing code can attempt to access the cached image, which
1216         would crash with a null deref.
1217         
1218         Fix by null-checking m_imageResource.
1219
1220         Test: compositing/images/content-image.html
1221
1222         * rendering/RenderImage.h:
1223         (WebCore::RenderImage::cachedImage):
1224
1225 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1226
1227         Reviewed by Dimitri Glazkov.
1228
1229         Hashchange event is no longer a simple event, needs to be its own interface
1230         https://bugs.webkit.org/show_bug.cgi?id=36335
1231         
1232         Add HashChangeEvent.idl and supporting files/changes.
1233
1234         Test: fast/loader/hashchange-event-properties.html
1235
1236         The original version of this patch was written by
1237         Steven Lai <s3lance@hotmail.com>.
1238
1239         * CMakeLists.txt:
1240         * DerivedSources.cpp:
1241         * DerivedSources.make:
1242         * GNUmakefile.am:
1243         * WebCore.gypi:
1244         * WebCore.pri:
1245         * WebCore.vcproj/WebCore.vcproj:
1246         * WebCore.xcodeproj/project.pbxproj:
1247         * bindings/js/JSEventCustom.cpp:
1248         (WebCore::toJS):
1249         * bindings/v8/custom/V8EventCustom.cpp:
1250         (WebCore::toV8):
1251         * dom/Document.cpp:
1252         (WebCore::Document::enqueueHashchangeEvent):
1253         * dom/Event.cpp:
1254         (WebCore::Event::isHashChangeEvent):
1255         * dom/Event.h:
1256         * dom/HashChangeEvent.h: Added.
1257         (WebCore::HashChangeEvent::isHashChangeEvent):
1258         (WebCore::HashChangeEvent::create):
1259         (WebCore::HashChangeEvent::initHashChangeEvent):
1260         (WebCore::HashChangeEvent::oldURL):
1261         (WebCore::HashChangeEvent::newURL):
1262         (WebCore::HashChangeEvent::HashChangeEvent):
1263         * dom/HashChangeEvent.idl: Added.
1264         * page/DOMWindow.idl:
1265
1266 2010-09-20  Andy Estes  <aestes@apple.com>
1267
1268         Reviewed by Adam Barth.
1269
1270         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1271         https://bugs.webkit.org/show_bug.cgi?id=40961
1272
1273         Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
1274         legacy behavior when the start of a new token is encountered before the
1275         current token is finished parsing. The legacy behavior is to emit the
1276         current token as if it were properly closed and being parsing the new
1277         token.
1278
1279         Test: fast/parser/pre-html5-parser-quirks.html
1280
1281         * html/parser/HTMLDocumentParser.cpp:
1282         (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate
1283         m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
1284         (WebCore::usePreHTMLParserQuirks): Add a helper function to return the
1285         value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
1286         * html/parser/HTMLPreloadScanner.cpp:
1287         (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate
1288         m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
1289         * html/parser/HTMLTokenizer.cpp:
1290         (WebCore::HTMLTokenizer::HTMLTokenizer):
1291         (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an
1292         unexpected '<' is encountered in certain states, emit the current token
1293         and reprocess the '<' as the start of a new token.
1294         * html/parser/HTMLTokenizer.h:
1295         (WebCore::HTMLTokenizer::create):
1296         * html/parser/HTMLViewSourceParser.cpp:
1297         (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate
1298         m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
1299         * page/Settings.cpp:
1300         (WebCore::Settings::Settings):
1301         * page/Settings.h:
1302         (WebCore::Settings::setUsePreHTML5ParserQuirks):
1303         (WebCore::Settings::usePreHTML5ParserQuirks):
1304
1305 2010-09-20  David Hyatt  <hyatt@apple.com>
1306
1307         Reviewed by Dan Bernstein.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=46132, add an isVerticalBlockFlow() method to RenderStyle and
1310         patch callers so that they don't have to check both top-to-bottom and bottom-to-top block flow.
1311
1312         * rendering/RenderBox.cpp:
1313         (WebCore::RenderBox::availableLogicalWidth):
1314         * rendering/style/RenderStyle.cpp:
1315         (WebCore::RenderStyle::logicalWidth):
1316         (WebCore::RenderStyle::logicalHeight):
1317         (WebCore::RenderStyle::logicalMinWidth):
1318         (WebCore::RenderStyle::logicalMaxWidth):
1319         (WebCore::RenderStyle::logicalMinHeight):
1320         (WebCore::RenderStyle::logicalMaxHeight):
1321         (WebCore::RenderStyle::borderStartWidth):
1322         (WebCore::RenderStyle::borderEndWidth):
1323         (WebCore::RenderStyle::marginStart):
1324         (WebCore::RenderStyle::marginEnd):
1325         (WebCore::RenderStyle::paddingStart):
1326         (WebCore::RenderStyle::paddingEnd):
1327         * rendering/style/RenderStyle.h:
1328         (WebCore::InheritedFlags::isVerticalBlockFlow):
1329
1330 2010-09-20  David Hyatt  <hyatt@apple.com>
1331
1332         Reviewed by Dan Bernstein.
1333
1334         https://bugs.webkit.org/show_bug.cgi?id=46124, add support for logical padding accessors to
1335         RenderBoxModelObject.
1336
1337         Added fast/blockflow/percentage-padding.html even though it fails, so that when more of layout is patched
1338         we can see it start passing.
1339
1340         * rendering/RenderBoxModelObject.cpp:
1341         (WebCore::RenderBoxModelObject::paddingTop):
1342         (WebCore::RenderBoxModelObject::paddingBottom):
1343         (WebCore::RenderBoxModelObject::paddingLeft):
1344         (WebCore::RenderBoxModelObject::paddingRight):
1345         (WebCore::RenderBoxModelObject::paddingBefore):
1346         (WebCore::RenderBoxModelObject::paddingAfter):
1347         (WebCore::RenderBoxModelObject::paddingStart):
1348         (WebCore::RenderBoxModelObject::paddingEnd):
1349         * rendering/RenderBoxModelObject.h:
1350
1351 2010-09-20  David Hyatt  <hyatt@apple.com>
1352
1353         Reviewed by Dan Bernstein.
1354
1355         https://bugs.webkit.org/show_bug.cgi?id=46126, add availableLogicalWidth() to RenderBox.
1356         
1357         * rendering/RenderBlock.cpp:
1358         (WebCore::RenderBlock::availableWidth):
1359         (WebCore::RenderBlock::availableLogicalWidth):
1360         * rendering/RenderBlock.h:
1361         * rendering/RenderBox.cpp:
1362         (WebCore::RenderBox::availableLogicalWidth):
1363         * rendering/RenderBox.h:
1364         (WebCore::RenderBox::availableWidth):
1365
1366 2010-09-20  Kenneth Russell  <kbr@google.com>
1367
1368         Reviewed by James Robinson.
1369
1370         [chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
1371         https://bugs.webkit.org/show_bug.cgi?id=45912
1372
1373         Switched Chromium's compositor to use GraphicsContext3D to issue
1374         its OpenGL rendering calls rather than the Chromium-specific
1375         GLES2Context and command buffer OpenGL implementation.
1376
1377         The in-process software rendering path for GraphicsContext3D does
1378         not yet work with the compositor, at least not on Mac OS X. This
1379         will be worked on in subsequent bugs.
1380
1381         Tested manually with 3D CSS, WebGL and video content on Mac OS X
1382         and Linux. No new tests.
1383
1384         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
1385         (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
1386         (WebCore::Canvas2DLayerChromium::updateContents):
1387         * platform/graphics/chromium/CanvasLayerChromium.cpp:
1388         (WebCore::CanvasLayerChromium::SharedValues::SharedValues):
1389         (WebCore::CanvasLayerChromium::SharedValues::~SharedValues):
1390         (WebCore::CanvasLayerChromium::draw):
1391         * platform/graphics/chromium/CanvasLayerChromium.h:
1392         * platform/graphics/chromium/ContentLayerChromium.cpp:
1393         (WebCore::ContentLayerChromium::SharedValues::SharedValues):
1394         (WebCore::ContentLayerChromium::SharedValues::~SharedValues):
1395         (WebCore::ContentLayerChromium::~ContentLayerChromium):
1396         (WebCore::ContentLayerChromium::updateTextureRect):
1397         (WebCore::ContentLayerChromium::draw):
1398         * platform/graphics/chromium/ContentLayerChromium.h:
1399         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1400         (WebCore::DrawingBuffer::publishToPlatformLayer):
1401         * platform/graphics/chromium/LayerChromium.cpp:
1402         (WebCore::loadShader):
1403         (WebCore::LayerChromium::SharedValues::SharedValues):
1404         (WebCore::LayerChromium::SharedValues::~SharedValues):
1405         (WebCore::LayerChromium::createShaderProgram):
1406         (WebCore::LayerChromium::layerRendererContext):
1407         (WebCore::LayerChromium::drawTexturedQuad):
1408         (WebCore::LayerChromium::drawDebugBorder):
1409         (WebCore::LayerChromium::drawAsMask):
1410         (WebCore::LayerChromium::prepareForDraw):
1411         * platform/graphics/chromium/LayerChromium.h:
1412         (WebCore::LayerChromium::SharedValues::context):
1413         * platform/graphics/chromium/LayerRendererChromium.cpp:
1414         (WebCore::LayerRendererChromium::create):
1415         (WebCore::LayerRendererChromium::LayerRendererChromium):
1416         (WebCore::LayerRendererChromium::context):
1417         (WebCore::LayerRendererChromium::debugGLCall):
1418         (WebCore::LayerRendererChromium::useShader):
1419         (WebCore::LayerRendererChromium::prepareToDrawLayers):
1420         (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
1421         (WebCore::LayerRendererChromium::drawLayers):
1422         (WebCore::LayerRendererChromium::finish):
1423         (WebCore::LayerRendererChromium::present):
1424         (WebCore::LayerRendererChromium::getFramebufferPixels):
1425         (WebCore::LayerRendererChromium::createLayerTexture):
1426         (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer):
1427         (WebCore::LayerRendererChromium::drawLayersRecursive):
1428         (WebCore::LayerRendererChromium::drawLayer):
1429         (WebCore::LayerRendererChromium::scissorToRect):
1430         (WebCore::LayerRendererChromium::makeContextCurrent):
1431         (WebCore::LayerRendererChromium::resizeOnscreenContent):
1432         (WebCore::LayerRendererChromium::initializeSharedObjects):
1433         (WebCore::LayerRendererChromium::cleanupSharedObjects):
1434         * platform/graphics/chromium/LayerRendererChromium.h:
1435         * platform/graphics/chromium/VideoLayerChromium.cpp:
1436         (WebCore::VideoLayerChromium::createTextureRect):
1437         (WebCore::VideoLayerChromium::updateTextureRect):
1438         * platform/graphics/chromium/WebGLLayerChromium.cpp:
1439         (WebCore::WebGLLayerChromium::updateContents):
1440         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1441         (WebCore::SharedGraphicsContext3D::flush):
1442         (WebCore::SharedGraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM):
1443         (WebCore::SharedGraphicsContext3D::copyTextureToParentTextureCHROMIUM):
1444         * platform/graphics/gpu/SharedGraphicsContext3D.h:
1445
1446 2010-09-20  David Hyatt  <hyatt@apple.com>
1447
1448         Reviewed by Dan Bernstein.
1449
1450         https://bugs.webkit.org/show_bug.cgi?id=46119, add logical accessors to RenderStyle.  Not used by any RenderObjects yet, so no tests
1451         until then.
1452
1453         * rendering/style/RenderStyle.cpp:
1454         (WebCore::RenderStyle::logicalWidth):
1455         (WebCore::RenderStyle::logicalHeight):
1456         (WebCore::RenderStyle::logicalMinWidth):
1457         (WebCore::RenderStyle::logicalMaxWidth):
1458         (WebCore::RenderStyle::logicalMinHeight):
1459         (WebCore::RenderStyle::logicalMaxHeight):
1460         (WebCore::RenderStyle::borderBeforeWidth):
1461         (WebCore::RenderStyle::borderAfterWidth):
1462         (WebCore::RenderStyle::borderStartWidth):
1463         (WebCore::RenderStyle::borderEndWidth):
1464         (WebCore::RenderStyle::marginBefore):
1465         (WebCore::RenderStyle::marginAfter):
1466         (WebCore::RenderStyle::marginStart):
1467         (WebCore::RenderStyle::marginEnd):
1468         (WebCore::RenderStyle::paddingBefore):
1469         (WebCore::RenderStyle::paddingAfter):
1470         (WebCore::RenderStyle::paddingStart):
1471         (WebCore::RenderStyle::paddingEnd):
1472         * rendering/style/RenderStyle.h:
1473
1474 2010-09-20  David Hyatt  <hyatt@apple.com>
1475
1476         Reviewed by Dan Bernstein.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=46116, implement block-flow-aware logical properties.
1479         
1480         This patch adds all the logical properties from the CSS3 Writing Mode draft for margins, padding, border,
1481         width and height.
1482
1483         Added fast/css/logical-property-resolution.html
1484
1485         * css/CSSComputedStyleDeclaration.cpp:
1486         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1487         * css/CSSParser.cpp:
1488         (WebCore::CSSParser::parseValue):
1489         * css/CSSProperty.cpp:
1490         (WebCore::resolveToPhysicalProperty):
1491         (WebCore::CSSProperty::resolveDirectionAwareProperty):
1492         * css/CSSProperty.h:
1493         * css/CSSPropertyNames.in:
1494         * css/CSSStyleSelector.cpp:
1495         (WebCore::CSSStyleSelector::applyDeclarations):
1496         (WebCore::CSSStyleSelector::applyProperty):
1497
1498 2010-09-20  David Hyatt  <hyatt@apple.com>
1499
1500         Reviewed by Beth Dakin.
1501
1502         https://bugs.webkit.org/show_bug.cgi?id=46114, two tables repaint tests failing on bots.
1503
1504         Patch layoutRows to apply the layout delta when setting a new cell location prior to laying out the cell.
1505         
1506         The layout delta is then removed after layout has happened when the repaint check is done.  This change
1507         makes cell layout match block child layout, and now the cells have the correct new location up front
1508         when laying out (a necessity for pagination).
1509
1510         * rendering/RenderTableSection.cpp:
1511         (WebCore::RenderTableSection::layoutRows):
1512
1513 2010-09-20  Jacob Dinu  <dinu.jacob@nokia.com>
1514
1515         Reviewed by Adam Barth.
1516
1517         When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
1518         that all initialzations are done before calling client dispatchDidCommitLoad to avoid
1519         client from accessing incorrect data.
1520         https://bugs.webkit.org/show_bug.cgi?id=41155
1521
1522         * loader/FrameLoader.cpp:
1523         (WebCore::FrameLoader::commitProvisionalLoad):
1524         (WebCore::FrameLoader::transitionToCommitted):
1525
1526 2010-09-20  Simon Fraser  <simon.fraser@apple.com>
1527
1528         Reviewed by Adam Roben.
1529
1530         REGRESSION: alternating animation direction doesn't work on Windows
1531         https://bugs.webkit.org/show_bug.cgi?id=46017
1532         
1533         Animation-direction on Windows was broken because bitfields on
1534         Windows are signed.
1535         
1536         Fixed by making m_direction an unsigned in the bitfield, and
1537         casting in the accessor.
1538
1539         Test: animations/animation-direction.html
1540
1541         * platform/animation/Animation.h:
1542         (WebCore::Animation::direction):
1543
1544 2010-09-20  Enrica Casucci  <enrica@apple.com>
1545
1546         Reviewed by Sam Weinig.
1547
1548         Pasteboard doesn't work in WebKit2.
1549         https://bugs.webkit.org/show_bug.cgi?id=42317
1550         <rdar://problem/7660537>
1551
1552         * loader/EmptyClients.h:
1553         (WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
1554         be a Vector of RefPtr.
1555         * page/EditorClient.h:
1556         * platform/mac/PasteboardMac.mm:
1557         (WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.
1558
1559 2010-09-20  Yong Li  <yoli@rim.com>
1560
1561         Reviewed by Alexey Proskuryakov.
1562
1563         https://bugs.webkit.org/show_bug.cgi?id=39966
1564         Make compareBorders() a consistent compare function which can beused by qsort().
1565
1566         New test case added: LayoutTests/tables/sort-collapsed-border-styles.html
1567
1568         * rendering/RenderTableCell.cpp:
1569         (WebCore::compareBorders):
1570         (WebCore::chooseBorder):
1571         (WebCore::RenderTableCell::collapsedLeftBorder):
1572         (WebCore::RenderTableCell::collapsedRightBorder):
1573         (WebCore::RenderTableCell::collapsedTopBorder):
1574         (WebCore::RenderTableCell::collapsedBottomBorder):
1575         (WebCore::compareBorderStylesForQSort):
1576
1577 2010-09-20  Patrick Gansterer  <paroga@paroga.com>
1578
1579         Reviewed by Adam Roben.
1580
1581         [WINCE] Buildfix for PluginViewWin.cpp
1582         https://bugs.webkit.org/show_bug.cgi?id=46033
1583
1584         * plugins/win/PluginViewWin.cpp:
1585         (WebCore::PluginView::paintIntoTransformedContext):
1586         (WebCore::PluginView::snapshot):
1587
1588 2010-09-18  David Hyatt  <hyatt@apple.com>
1589
1590         Reviewed by Sam Weinig.
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=46030, aintitcool.com doesn't paginate correctly when printed.
1593         
1594         This happens because the site always has a document width that will exceed the page width.
1595         We incorrectly apply a double scale instead of clipping after the first scale still doesn't fit.
1596         The fix for the issue is to cap the right layout overflow to the page width and to just clip out
1597         any additional excess.  This is the code in FrameView.cpp.
1598         
1599         This patch also cleans up table cell invalidation to reduce the # of relayouts.  This change is not
1600         a correctness fix.  It's just performance.
1601         
1602         I'm not sure how to write a test for this, since the double scale is an artifact of how WebKit mac calls
1603         back in when really printing.
1604
1605         * page/FrameView.cpp:
1606         (WebCore::FrameView::forceLayoutForPagination):
1607         * rendering/RenderBlock.cpp:
1608         (WebCore::RenderBlock::layoutBlockChild):
1609         (WebCore::RenderBlock::layoutPositionedObjects):
1610         (WebCore::RenderBlock::positionNewFloats):
1611         * rendering/RenderBlock.h:
1612         (WebCore::RenderBlock::markForPaginationRelayout):
1613         * rendering/RenderFlexibleBox.cpp:
1614         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1615         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1616         * rendering/RenderTableSection.cpp:
1617         (WebCore::RenderTableSection::layoutRows):
1618
1619 2010-09-20  Ilya Tikhonovsky  <loislo@chromium.org>
1620
1621         Reviewed by Pavel Feldman.
1622
1623         Web Inspector: merge Inspector client runtime events into the serialized inspector state object.
1624
1625         Drive-by rename getBackendSettings -> getInspectorState to better reflect the nature of the data.
1626
1627         https://bugs.webkit.org/show_bug.cgi?id=45974
1628
1629         * inspector/Inspector.idl:
1630         * inspector/InspectorClient.h:
1631         (WebCore::InspectorClient::updateInspectorStateCookie):
1632         * inspector/InspectorController.cpp:
1633         (WebCore::InspectorController::saveApplicationSettings):
1634         (WebCore::InspectorController::getInspectorState):
1635         (WebCore::InspectorController::updateInspectorStateCookie):
1636         (WebCore::InspectorController::restoreInspectorStateFromCookie):
1637         (WebCore::InspectorController::getSettings):
1638         (WebCore::InspectorController::setMonitoringXHREnabled):
1639         (WebCore::InspectorController::restoreDebugger):
1640         (WebCore::InspectorController::restoreProfiler):
1641         (WebCore::InspectorController::setResourceTrackingEnabled):
1642         (WebCore::InspectorController::ensureSettingsLoaded):
1643         (WebCore::InspectorController::startTimelineProfiler):
1644         (WebCore::InspectorController::stopTimelineProfiler):
1645         (WebCore::InspectorController::enableProfiler):
1646         (WebCore::InspectorController::disableProfiler):
1647         (WebCore::InspectorController::enableDebuggerFromFrontend):
1648         (WebCore::InspectorController::disableDebugger):
1649         * inspector/InspectorController.h:
1650         * inspector/front-end/ConsoleView.js:
1651         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
1652         * inspector/front-end/ResourcesPanel.js:
1653         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
1654         * inspector/front-end/Settings.js:
1655         (WebInspector.Settings.initialize):
1656         * inspector/front-end/inspector.js:
1657         (WebInspector.doLoadedDone.populateInspectorState):
1658         (WebInspector.doLoadedDone):
1659
1660 2010-09-20  Dirk Schulze  <krit@webkit.org>
1661
1662         Reviewed by Nikolas Zimmermann.
1663
1664         SVG Filter cleanup
1665         https://bugs.webkit.org/show_bug.cgi?id=45612
1666         
1667         All effect inputs are stored in a Vector in FilterEffect instead of passing them via constructors to every effect type.
1668         This simplifies the primitive subregion logic and centralizes it in determineFilterPrimitiveSubregion.
1669         Just SourceGraphic, SourceAlpha and FETile still calculate filter primitive subregions on
1670         their own. Working on it in a followup patch.
1671         The subregions code is SVG specific and moving this calculation to FilterEffect is an
1672         intermediate step before moving it to RenderSVGResourceFilterPrimitive in a following patch.
1673         The new FilterEffectVector will also make it possible to add code to determine the
1674         smallest used region of an effect and will help save memory and resources in the future.
1675         subRegion got renamed to filterPrimitiveSubregion to match the name scheme. scaledSubRegion got
1676         renamed to repaintRectInLocalCoordinates since this is its proper meaning.
1677         Removed unnecessary member variables and functions from FilterEffect.
1678
1679         No new tests added since the functionality didn't change.
1680
1681         * platform/graphics/cairo/GraphicsContextCairo.cpp: scaledSubRegion was renamed to repaintRectInLocalCoordinates.
1682         (WebCore::GraphicsContext::createShadowMask):
1683         * platform/graphics/filters/FEBlend.cpp: Removed Filter effect inputs from constructor.
1684         (WebCore::FEBlend::FEBlend):
1685         (WebCore::FEBlend::create):
1686         (WebCore::FEBlend::apply): Call inputFilterEffects to get input filter primitives.
1687         (WebCore::FEBlend::externalRepresentation): Call inputFilterEffects to get input filter primitives.
1688         * platform/graphics/filters/FEBlend.h:
1689         * platform/graphics/filters/FEColorMatrix.cpp: Ditto.
1690         (WebCore::FEColorMatrix::FEColorMatrix):
1691         (WebCore::FEColorMatrix::create):
1692         (WebCore::FEColorMatrix::apply):
1693         (WebCore::FEColorMatrix::externalRepresentation):
1694         * platform/graphics/filters/FEColorMatrix.h:
1695         * platform/graphics/filters/FEComponentTransfer.cpp: Ditto.
1696         (WebCore::FEComponentTransfer::FEComponentTransfer):
1697         (WebCore::FEComponentTransfer::create):
1698         (WebCore::FEComponentTransfer::apply):
1699         (WebCore::FEComponentTransfer::externalRepresentation):
1700         * platform/graphics/filters/FEComponentTransfer.h:
1701         * platform/graphics/filters/FEComposite.cpp: Ditto.
1702         (WebCore::FEComposite::FEComposite):
1703         (WebCore::FEComposite::create):
1704         (WebCore::FEComposite::apply):
1705         (WebCore::FEComposite::externalRepresentation):
1706         * platform/graphics/filters/FEComposite.h:
1707         * platform/graphics/filters/FEGaussianBlur.cpp: Ditto.
1708         (WebCore::FEGaussianBlur::FEGaussianBlur):
1709         (WebCore::FEGaussianBlur::create):
1710         (WebCore::FEGaussianBlur::apply):
1711         (WebCore::FEGaussianBlur::externalRepresentation):
1712         * platform/graphics/filters/FEGaussianBlur.h:
1713         * platform/graphics/filters/Filter.h:
1714         (WebCore::Filter::determineFilterPrimitiveSubregion): Renamed from calculateEffectSubRegion to match name scheme.
1715         * platform/graphics/filters/FilterEffect.cpp:
1716         (WebCore::FilterEffect::FilterEffect):
1717         (WebCore::FilterEffect::determineFilterPrimitiveSubregion): The main place for subregion calculation.
1718         (WebCore::FilterEffect::calculateDrawingIntRect): Takes repaintRectInLocalCoordinates now.
1719         (WebCore::FilterEffect::calculateDrawingRect): ditto.
1720         (WebCore::FilterEffect::getEffectContext): Check if ImageBuffer was created.
1721         * platform/graphics/filters/FilterEffect.h: Changed names to match name scheme. Removed unnecessary member variables and functions.
1722             Seperate SVG specific member variables and functions. Will get removed in followup patches.
1723         (WebCore::FilterEffect::resultImage):
1724         (WebCore::FilterEffect::setEffectBuffer):
1725         (WebCore::FilterEffect::inputEffect):
1726         (WebCore::FilterEffect::inputEffects):
1727         (WebCore::FilterEffect::numberOfinputEffects):
1728         (WebCore::FilterEffect::isAlphaImage):
1729         (WebCore::FilterEffect::setIsAlphaImage):
1730         (WebCore::FilterEffect::repaintRectInLocalCoordinates):
1731         (WebCore::FilterEffect::setRepaintRectInLocalCoordinates):
1732         (WebCore::FilterEffect::isSourceInput):
1733         (WebCore::FilterEffect::hasX):
1734         (WebCore::FilterEffect::setHasX):
1735         (WebCore::FilterEffect::hasY):
1736         (WebCore::FilterEffect::setHasY):
1737         (WebCore::FilterEffect::hasWidth):
1738         (WebCore::FilterEffect::setHasWidth):
1739         (WebCore::FilterEffect::hasHeight):
1740         (WebCore::FilterEffect::setHasHeight):
1741         (WebCore::FilterEffect::filterPrimitiveSubregion):
1742         (WebCore::FilterEffect::setFilterPrimitiveSubregion):
1743         (WebCore::FilterEffect::effectBoundaries):
1744         (WebCore::FilterEffect::setEffectBoundaries):
1745         * platform/graphics/filters/SourceAlpha.cpp:
1746         (WebCore::SourceAlpha::determineFilterPrimitiveSubregion): Renamed to match name scheme.
1747         * platform/graphics/filters/SourceAlpha.h:
1748         (WebCore::SourceAlpha::isSourceInput):
1749         * platform/graphics/filters/SourceGraphic.cpp:
1750         (WebCore::SourceGraphic::determineFilterPrimitiveSubregion): Ditto.
1751         * platform/graphics/filters/SourceGraphic.h:
1752         (WebCore::SourceGraphic::isSourceInput):
1753         * rendering/RenderSVGResourceFilter.cpp: Adapt to renames in FilterEffect.
1754         (WebCore::RenderSVGResourceFilter::applyResource):
1755         (WebCore::RenderSVGResourceFilter::postApplyResource):
1756         * svg/SVGFEBlendElement.cpp: Constructor of FEBlend doesn't take input effects. Adding them afterwards.
1757         (WebCore::SVGFEBlendElement::build):
1758         * svg/SVGFEColorMatrixElement.cpp: Ditto.
1759         (WebCore::SVGFEColorMatrixElement::build):
1760         * svg/SVGFEComponentTransferElement.cpp: Ditto.
1761         (WebCore::SVGFEComponentTransferElement::build):
1762         * svg/SVGFECompositeElement.cpp: Ditto.
1763         (WebCore::SVGFECompositeElement::build):
1764         * svg/SVGFEConvolveMatrixElement.cpp: Ditto.
1765         (WebCore::SVGFEConvolveMatrixElement::build):
1766         * svg/SVGFEDiffuseLightingElement.cpp: Ditto.
1767         (WebCore::SVGFEDiffuseLightingElement::build):
1768         * svg/SVGFEDisplacementMapElement.cpp: Ditto.
1769         (WebCore::SVGFEDisplacementMapElement::build):
1770         * svg/SVGFEGaussianBlurElement.cpp: Ditto.
1771         (WebCore::SVGFEGaussianBlurElement::build):
1772         * svg/SVGFEMergeElement.cpp: Ditto.
1773         (WebCore::SVGFEMergeElement::build):
1774         * svg/SVGFEMorphologyElement.cpp: Ditto.
1775         (WebCore::SVGFEMorphologyElement::build):
1776         * svg/SVGFEOffsetElement.cpp: Ditto.
1777         (WebCore::SVGFEOffsetElement::build):
1778         * svg/SVGFESpecularLightingElement.cpp: Ditto.
1779         (WebCore::SVGFESpecularLightingElement::build):
1780         * svg/SVGFETileElement.cpp: Ditto.
1781         (WebCore::SVGFETileElement::build):
1782         * svg/graphics/filters/SVGFEConvolveMatrix.cpp: Ditto.
1783         (WebCore::FEConvolveMatrix::FEConvolveMatrix):
1784         (WebCore::FEConvolveMatrix::create):
1785         (WebCore::FEConvolveMatrix::apply):
1786         (WebCore::FEConvolveMatrix::externalRepresentation):
1787         * svg/graphics/filters/SVGFEConvolveMatrix.h:
1788         * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
1789         (WebCore::FEDiffuseLighting::FEDiffuseLighting):
1790         (WebCore::FEDiffuseLighting::create):
1791         (WebCore::FEDiffuseLighting::externalRepresentation):
1792         * svg/graphics/filters/SVGFEDiffuseLighting.h:
1793         * svg/graphics/filters/SVGFEDisplacementMap.cpp: Ditto.
1794         (WebCore::FEDisplacementMap::FEDisplacementMap):
1795         (WebCore::FEDisplacementMap::create):
1796         (WebCore::FEDisplacementMap::apply):
1797         (WebCore::FEDisplacementMap::externalRepresentation):
1798         * svg/graphics/filters/SVGFEDisplacementMap.h:
1799         * svg/graphics/filters/SVGFEFlood.cpp: Ditto.
1800         (WebCore::FEFlood::apply):
1801         * svg/graphics/filters/SVGFEImage.cpp: Ditto.
1802         (WebCore::FEImage::apply):
1803         * svg/graphics/filters/SVGFELighting.cpp: Ditto.
1804         (WebCore::FELighting::FELighting):
1805         (WebCore::FELighting::apply):
1806         * svg/graphics/filters/SVGFELighting.h:
1807         * svg/graphics/filters/SVGFEMerge.cpp: Ditto.
1808         (WebCore::FEMerge::FEMerge):
1809         (WebCore::FEMerge::create):
1810         (WebCore::FEMerge::apply):
1811         (WebCore::FEMerge::externalRepresentation):
1812         * svg/graphics/filters/SVGFEMerge.h:
1813         * svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
1814         (WebCore::FEMorphology::FEMorphology):
1815         (WebCore::FEMorphology::create):
1816         (WebCore::FEMorphology::apply):
1817         (WebCore::FEMorphology::externalRepresentation):
1818         * svg/graphics/filters/SVGFEMorphology.h:
1819         * svg/graphics/filters/SVGFEOffset.cpp: Ditto.
1820         (WebCore::FEOffset::FEOffset):
1821         (WebCore::FEOffset::create):
1822         (WebCore::FEOffset::apply):
1823         (WebCore::FEOffset::externalRepresentation):
1824         * svg/graphics/filters/SVGFEOffset.h:
1825         * svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
1826         (WebCore::FESpecularLighting::FESpecularLighting):
1827         (WebCore::FESpecularLighting::create):
1828         (WebCore::FESpecularLighting::externalRepresentation):
1829         * svg/graphics/filters/SVGFESpecularLighting.h:
1830         * svg/graphics/filters/SVGFETile.cpp: Ditto.
1831         (WebCore::FETile::FETile):
1832         (WebCore::FETile::create):
1833         (WebCore::FETile::determineFilterPrimitiveSubregion): Renamed to match name scheme.
1834         (WebCore::FETile::apply):
1835         (WebCore::FETile::externalRepresentation):
1836         * svg/graphics/filters/SVGFETile.h:
1837         * svg/graphics/filters/SVGFilter.cpp: Renamed itemBox to targetBoundingBox to match name scheme.
1838         (WebCore::SVGFilter::SVGFilter):
1839         (WebCore::SVGFilter::determineFilterPrimitiveSubregion): Renamed to match name scheme.
1840         (WebCore::SVGFilter::create):
1841         * svg/graphics/filters/SVGFilter.h:
1842         (WebCore::SVGFilter::sourceImageRect):
1843
1844 2010-09-20  Pavel Podivilov  <podivilov@chromium.org>
1845
1846         Reviewed by Pavel Feldman.
1847
1848         Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
1849         https://bugs.webkit.org/show_bug.cgi?id=45897
1850
1851         * inspector/front-end/BreakpointsSidebarPane.js:
1852         (WebInspector.BreakpointItem):
1853         (WebInspector.JSBreakpointItem):
1854         (WebInspector.DOMBreakpointItem):
1855         (WebInspector.DOMBreakpointItem.prototype.compareTo):
1856         (WebInspector.DOMBreakpointItem.prototype._breakpointClicked):
1857         * inspector/front-end/ElementsPanel.js:
1858         (WebInspector.ElementsPanel.prototype.hide):
1859         (WebInspector.ElementsPanel.prototype.reset):
1860         (WebInspector.ElementsPanel.prototype.setDocument.selectNode):
1861         (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs):
1862         (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
1863         (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
1864         * inspector/front-end/ElementsTreeOutline.js:
1865         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
1866         (WebInspector.ElementsTreeOutline.prototype._onmousemove):
1867         (WebInspector.ElementsTreeOutline.prototype._onmouseout):
1868         * inspector/front-end/inspector.js:
1869         (WebInspector.highlightDOMNode):
1870         (WebInspector.highlightDOMNodeForTwoSeconds):
1871         (WebInspector.wireElementWithDOMNode):
1872         (WebInspector._updateFocusedNode):
1873         (WebInspector.reset):
1874         (WebInspector.updateFocusedNode):
1875
1876 2010-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1877
1878         Unreviewed, rolling out r67749.
1879         http://trac.webkit.org/changeset/67749
1880         https://bugs.webkit.org/show_bug.cgi?id=46068
1881
1882         breaking ToT chromium canary build (Requested by shans on
1883         #webkit).
1884
1885         * bindings/v8/V8DOMWindowShell.cpp:
1886         (WebCore::V8DOMWindowShell::createNewContext):
1887         * bindings/v8/V8Proxy.cpp:
1888         (WebCore::V8Proxy::registeredExtensionWithV8):
1889         (WebCore::V8Proxy::registerExtension):
1890         * bindings/v8/V8Proxy.h:
1891         * loader/EmptyClients.h:
1892         * loader/FrameLoaderClient.h:
1893
1894 2010-09-19  Gavin Barraclough  <barraclough@apple.com>
1895
1896         Reviewed by Oliver Hunt.
1897
1898         Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.
1899
1900         These methods implement the same conversion (see discussion in the notes
1901         of sections of 9.5 and 9.6 of the spec), only differing in how the result
1902         is interpretted.
1903
1904         Removing JSValue::toInt32 (since this has weird, non-spec function).
1905         A couple of places in the binding are using this method, so adding
1906         finiteInt32Value to the bindings to maintain current behaviour.
1907
1908         Test: fast/js/toInt32UInt32.html
1909
1910         * bindings/js/JSDOMBinding.h:
1911         (WebCore::finiteInt32Value):
1912         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
1913         (WebCore::JSHTMLOptionsCollection::add):
1914         * bindings/js/JSSQLResultSetRowListCustom.cpp:
1915         (WebCore::JSSQLResultSetRowList::item):
1916         * bindings/js/JSSVGPODListCustom.h:
1917         (WebCore::JSSVGPODListCustom::getItem):
1918         (WebCore::JSSVGPODListCustom::insertItemBefore):
1919         (WebCore::JSSVGPODListCustom::replaceItem):
1920         (WebCore::JSSVGPODListCustom::removeItem):
1921         * bindings/js/JSSVGPathSegListCustom.cpp:
1922         (WebCore::JSSVGPathSegList::getItem):
1923         (WebCore::JSSVGPathSegList::insertItemBefore):
1924         (WebCore::JSSVGPathSegList::replaceItem):
1925         (WebCore::JSSVGPathSegList::removeItem):
1926
1927 2010-09-19  Andreas Kling  <andreas.kling@nokia.com>
1928
1929         Reviewed by Kenneth Rohde Christiansen.
1930
1931         [Qt] clipBoundingRect() should return rect relevant to current layer
1932         https://bugs.webkit.org/show_bug.cgi?id=46059
1933
1934         r65791 inadvertently changed clipBoundingRect() to always use the GC painter
1935         without checking the TransparencyLayer stack first.
1936
1937         * platform/graphics/qt/GraphicsContextQt.cpp:
1938         (WebCore::GraphicsContextPlatformPrivate::p):
1939         (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
1940
1941 2010-09-19  Sam Weinig  <sam@webkit.org>
1942
1943         Reviewed by Anders Carlsson.
1944
1945         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
1946         https://bugs.webkit.org/show_bug.cgi?id=46054
1947
1948         * WebCore.exp.in:
1949         * WebCore.xcodeproj/project.pbxproj:
1950
1951 2010-09-19  Patrick Gansterer  <paroga@paroga.com>
1952
1953         Unreviewed.
1954
1955         [WINCE] Buildfix for Gradient after r67801.
1956
1957         * platform/graphics/Gradient.h:
1958         * platform/graphics/wince/GradientWinCE.cpp:
1959         (WebCore::Gradient::getStops):
1960
1961 2010-09-19  Kent Tamura  <tkent@chromium.org>
1962
1963         Reviewed by Dimitri Glazkov.
1964
1965         [Chromium] Add is<input type>() functions to WebInputElement
1966         https://bugs.webkit.org/show_bug.cgi?id=46035
1967
1968         * html/HTMLInputElement.h:
1969         (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
1970
1971 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
1972
1973         Reviewed by Antonio Gomes.
1974
1975         [Qt] Path: Remove unused member variable
1976         https://bugs.webkit.org/show_bug.cgi?id=46048
1977
1978         Path::m_lastMoveToIndex is not used for anything, so remove it.
1979
1980         * platform/graphics/Path.h:
1981         * platform/graphics/qt/PathQt.cpp:
1982         (WebCore::Path::Path):
1983         (WebCore::Path::operator=):
1984         (WebCore::Path::moveTo):
1985
1986 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
1987
1988         Reviewed by Darin Adler.
1989
1990         Use AtomicString insted of String in XMLDocumentParser
1991         https://bugs.webkit.org/show_bug.cgi?id=45990
1992
1993         Create AtomicString as early as possible.
1994         This can avoid unnecessary memcpy of String content.
1995
1996         * dom/XMLDocumentParser.h:
1997         * dom/XMLDocumentParserLibxml2.cpp:
1998         (WebCore::toAtomicString):
1999         (WebCore::handleElementNamespaces):
2000         (WebCore::handleElementAttributes):
2001         (WebCore::XMLDocumentParser::startElementNs):
2002
2003 2010-09-18  Erik Arvidsson  <arv@chromium.org>
2004
2005         Reviewed by Nate Chapin.
2006
2007         [Chromium] fast/dom/dataset-gc.html is failing
2008         https://bugs.webkit.org/show_bug.cgi?id=45426
2009
2010         * bindings/scripts/CodeGeneratorV8.pm:
2011         * bindings/v8/custom/V8DOMStringMapCustom.cpp:
2012         (WebCore::toV8):
2013         * dom/DOMStringMap.h:
2014         * dom/DatasetDOMStringMap.h:
2015         (WebCore::DatasetDOMStringMap::element):
2016
2017 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
2018
2019         Reviewed by Oliver Hunt.
2020
2021         Gradient: Fast-path for the ideal case in sortStopsIfNecessary()
2022         https://bugs.webkit.org/show_bug.cgi?id=46045
2023
2024         Avoid calling std::stable_sort for 2-stop gradients that are already in order.
2025
2026         * platform/graphics/Gradient.cpp:
2027         (WebCore::Gradient::sortStopsIfNecessary):
2028
2029 2010-09-18  Kwang Yul Seo  <skyul@company100.net>
2030
2031         Reviewed by Andreas Kling.
2032
2033         [BREWMP] Fix a typo in key code name
2034         https://bugs.webkit.org/show_bug.cgi?id=46003
2035
2036         AVK_CLR is the right Brew MP key code name for VK_BACK.
2037
2038         * platform/brew/PlatformKeyboardEventBrew.cpp:
2039         (WebCore::windowsKeyCodeForKeyEvent):
2040
2041 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
2042
2043         Reviewed by Oliver Hunt.
2044
2045         Gradient: Pre-reserve space for 2 color stops
2046         https://bugs.webkit.org/show_bug.cgi?id=46044
2047
2048         Most gradients have only 2 color stops, pre-reserve space for these in m_stops
2049         to avoid growing the vector dynamically in the common case.
2050
2051         * platform/graphics/Gradient.h:
2052
2053 2010-09-18  Dimitri Glazkov  <dglazkov@chromium.org>
2054
2055         Unreviewed, rolling out r67792.
2056         http://trac.webkit.org/changeset/67792
2057         https://bugs.webkit.org/show_bug.cgi?id=45976
2058
2059         Broke over a hundred SVG tests.
2060
2061         * platform/graphics/GraphicsContext.cpp:
2062         (WebCore::GraphicsContext::drawImage):
2063         (WebCore::GraphicsContext::drawImageBuffer):
2064         * platform/graphics/GraphicsContext.h:
2065
2066 2010-09-18  Mihai Parparita  <mihaip@chromium.org>
2067
2068         Reviewed by Simon Fraser.
2069
2070         webkitAnimationEnd event doesn't fire when skipping over final iteration
2071         https://bugs.webkit.org/show_bug.cgi?id=46010
2072         
2073         It's possible for AnimationBase::fireAnimationEventsIfNeeded to decide
2074         that the animation is ended while we're in the looping state, if the
2075         animation timer never fires during an iteration. That then fails the
2076         assert in AnimationBase::updateStateMachine (we don't expect
2077         AnimationStateInputEndTimerFired while in the looping state). Jump the
2078         state to AnimationStateEnding, which is more accurate.
2079
2080         Test: animations/animation-end-event-short-iterations.html
2081
2082         * page/animation/AnimationBase.cpp:
2083         (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
2084
2085 2010-09-18  Kwang Yul Seo  <skyul@company100.net>
2086
2087         Reviewed by Andreas Kling.
2088
2089         [BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
2090         https://bugs.webkit.org/show_bug.cgi?id=46005
2091
2092         The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.
2093
2094         * platform/brew/PlatformKeyboardEventBrew.cpp:
2095         (WebCore::keyIdentifierForBrewKeyCode):
2096
2097 2010-09-18  Matthew Delaney  <mdelaney@apple.com>
2098
2099         Reviewed by Oliver Hunt.
2100
2101         Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
2102         https://bugs.webkit.org/show_bug.cgi?id=45976
2103
2104         Specifying a -1 width or height for either the source or destination rectangle in drawImage
2105         get improperly drawn with -1 replaced as the corresponding image width or height. This was because
2106         the value -1 was being passed around to signal non-specified widths and heights and thus was
2107         interpreted lower down in the drawImage implementation which disallowed any calls that actually
2108         wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
2109         -1 in-band signaling to denote default behavior.
2110
2111         Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html
2112                canvas/philip/tests/2d.drawImage.negativeOneSource.html
2113
2114         * platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have
2115         the desired replaces for unspecified widths and heights earlier on.
2116         * platform/graphics/GraphicsContext.h: Removed faulty default value.
2117
2118 2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2119
2120         Reviewed by Kenneth Rohde Christiansen.
2121
2122         Enable Platform Strategies on Qt
2123
2124         [Qt] Turn on PLATFORM_STRATEGIES
2125         https://bugs.webkit.org/show_bug.cgi?id=45831
2126
2127         * WebCore.pro: Adding/removing implementation files
2128         * platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was
2129         moved from platform/qt/Localizations.cpp
2130         (WebCore::defaultLanguage): Moved from Localizations.cpp
2131         * platform/qt/Localizations.cpp: Removed (code is now inside
2132         WebCoreSupport/WebPlatformStrategies.cpp)
2133         * plugins/qt/PluginDataQt.cpp: Removed (idem)
2134
2135 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2136
2137         Reviewed by Darin Adler.
2138
2139         Rename Wince files to WinCE
2140         https://bugs.webkit.org/show_bug.cgi?id=37287
2141
2142         * loader/icon/wince/IconDatabaseWinCE.cpp: Copied from WebCore/loader/icon/wince/IconDatabaseWince.cpp.
2143         * loader/icon/wince/IconDatabaseWince.cpp: Removed.
2144         * page/wince/FrameWinCE.cpp: Copied from WebCore/page/wince/FrameWince.cpp.
2145         * page/wince/FrameWince.cpp: Removed.
2146         * platform/graphics/MediaPlayer.cpp:
2147         * platform/graphics/wince/ColorWinCE.cpp: Copied from WebCore/platform/graphics/wince/ColorWince.cpp.
2148         * platform/graphics/wince/ColorWince.cpp: Removed.
2149         * platform/graphics/wince/FontCacheWinCE.cpp: Copied from WebCore/platform/graphics/wince/FontCacheWince.cpp.
2150         * platform/graphics/wince/FontCacheWince.cpp: Removed.
2151         * platform/graphics/wince/FontWinCE.cpp: Copied from WebCore/platform/graphics/wince/FontWince.cpp.
2152         * platform/graphics/wince/FontWince.cpp: Removed.
2153         * platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp: Copied from WebCore/platform/graphics/wince/GlyphPageTreeNodeWince.cpp.
2154         * platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Removed.
2155         * platform/graphics/wince/GradientWinCE.cpp: Copied from WebCore/platform/graphics/wince/GradientWince.cpp.
2156         * platform/graphics/wince/GradientWince.cpp: Removed.
2157         * platform/graphics/wince/GraphicsContextWinCE.cpp: Copied from WebCore/platform/graphics/wince/GraphicsContextWince.cpp.
2158         * platform/graphics/wince/GraphicsContextWince.cpp: Removed.
2159         * platform/graphics/wince/ImageBufferWinCE.cpp: Copied from WebCore/platform/graphics/wince/ImageBufferWince.cpp.
2160         * platform/graphics/wince/ImageBufferWince.cpp: Removed.
2161         * platform/graphics/wince/MediaPlayerPrivateWinCE.h: Copied from WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h.
2162         * platform/graphics/wince/MediaPlayerPrivateWince.h: Removed.
2163         * platform/graphics/wince/PathWinCE.cpp: Copied from WebCore/platform/graphics/wince/PathWince.cpp.
2164         * platform/graphics/wince/PathWince.cpp: Removed.
2165         * platform/graphics/wince/PlatformPathWinCE.cpp: Copied from WebCore/platform/graphics/wince/PlatformPathWince.cpp.
2166         * platform/graphics/wince/PlatformPathWinCE.h: Copied from WebCore/platform/graphics/wince/PlatformPathWince.h.
2167         * platform/graphics/wince/PlatformPathWince.cpp: Removed.
2168         * platform/graphics/wince/PlatformPathWince.h: Removed.
2169         * platform/graphics/wince/SimpleFontDataWinCE.cpp: Copied from WebCore/platform/graphics/wince/SimpleFontDataWince.cpp.
2170         * platform/graphics/wince/SimpleFontDataWince.cpp: Removed.
2171         * platform/graphics/wince/WinCEGraphicsExtras.h: Copied from WebCore/platform/graphics/wince/WinceGraphicsExtras.h.
2172         * platform/graphics/wince/WinceGraphicsExtras.h: Removed.
2173         * platform/text/wince/TextBoundariesWinCE.cpp: Copied from WebCore/platform/text/wince/TextBoundariesWince.cpp.
2174         * platform/text/wince/TextBoundariesWince.cpp: Removed.
2175         * platform/text/wince/TextBreakIteratorWinCE.cpp: Copied from WebCore/platform/text/wince/TextBreakIteratorWince.cpp.
2176         * platform/text/wince/TextBreakIteratorWince.cpp: Removed.
2177         * platform/wince/CursorWinCE.cpp: Copied from WebCore/platform/wince/CursorWince.cpp.
2178         * platform/wince/CursorWince.cpp: Removed.
2179         * platform/wince/DragDataWinCE.cpp: Copied from WebCore/platform/wince/DragDataWince.cpp.
2180         * platform/wince/DragDataWince.cpp: Removed.
2181         * platform/wince/DragImageWinCE.cpp: Copied from WebCore/platform/wince/DragImageWince.cpp.
2182         * platform/wince/DragImageWince.cpp: Removed.
2183         * platform/wince/EditorWinCE.cpp: Copied from WebCore/platform/wince/EditorWince.cpp.
2184         (WebCore::Editor::newGeneralClipboard):
2185         * platform/wince/EditorWince.cpp: Removed.
2186         * platform/wince/FileChooserWinCE.cpp: Copied from WebCore/platform/wince/FileChooserWince.cpp.
2187         * platform/wince/FileChooserWince.cpp: Removed.
2188         * platform/wince/FileSystemWinCE.cpp: Copied from WebCore/platform/wince/FileSystemWince.cpp.
2189         * platform/wince/FileSystemWince.cpp: Removed.
2190         * platform/wince/KURLWinCE.cpp: Copied from WebCore/platform/wince/KURLWince.cpp.
2191         * platform/wince/KURLWince.cpp: Removed.
2192         * platform/wince/KeygenWinCE.cpp: Copied from WebCore/platform/wince/KeygenWince.cpp.
2193         * platform/wince/KeygenWince.cpp: Removed.
2194         * platform/wince/MIMETypeRegistryWinCE.cpp: Copied from WebCore/platform/wince/MIMETypeRegistryWince.cpp.
2195         * platform/wince/MIMETypeRegistryWince.cpp: Removed.
2196         * platform/wince/PasteboardWinCE.cpp: Copied from WebCore/platform/wince/PasteboardWince.cpp.
2197         * platform/wince/PasteboardWince.cpp: Removed.
2198         * platform/wince/SearchPopupMenuWinCE.cpp: Copied from WebCore/platform/wince/SearchPopupMenuWince.cpp.
2199         * platform/wince/SearchPopupMenuWince.cpp: Removed.
2200         * platform/wince/SharedTimerWinCE.cpp: Copied from WebCore/platform/wince/SharedTimerWince.cpp.
2201         * platform/wince/SharedTimerWince.cpp: Removed.
2202         * rendering/RenderThemeWinCE.cpp: Copied from WebCore/rendering/RenderThemeWince.cpp.
2203         (WebCore::RenderThemeWinCE::create):
2204         (WebCore::RenderTheme::themeForPage):
2205         (WebCore::RenderThemeWinCE::RenderThemeWinCE):
2206         (WebCore::RenderThemeWinCE::~RenderThemeWinCE):
2207         (WebCore::RenderThemeWinCE::platformActiveSelectionBackgroundColor):
2208         (WebCore::RenderThemeWinCE::platformInactiveSelectionBackgroundColor):
2209         (WebCore::RenderThemeWinCE::platformActiveSelectionForegroundColor):
2210         (WebCore::RenderThemeWinCE::platformInactiveSelectionForegroundColor):
2211         (WebCore::RenderThemeWinCE::supportsFocus):
2212         (WebCore::RenderThemeWinCE::supportsFocusRing):
2213         (WebCore::RenderThemeWinCE::determineClassicState):
2214         (WebCore::RenderThemeWinCE::getThemeData):
2215         (WebCore::RenderThemeWinCE::paintButton):
2216         (WebCore::RenderThemeWinCE::setCheckboxSize):
2217         (WebCore::RenderThemeWinCE::paintTextField):
2218         (WebCore::RenderThemeWinCE::adjustMenuListStyle):
2219         (WebCore::RenderThemeWinCE::paintMenuList):
2220         (WebCore::RenderThemeWinCE::paintMenuListButton):
2221         (WebCore::RenderThemeWinCE::systemFont):
2222         (WebCore::RenderThemeWinCE::themeChanged):
2223         (WebCore::RenderThemeWinCE::extraDefaultStyleSheet):
2224         (WebCore::RenderThemeWinCE::extraQuirksStyleSheet):
2225         (WebCore::RenderThemeWinCE::supportsHover):
2226         (WebCore::RenderThemeWinCE::systemColor):
2227         (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
2228         (WebCore::RenderThemeWinCE::adjustButtonInnerStyle):
2229         (WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
2230         (WebCore::RenderThemeWinCE::paintSearchField):
2231         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
2232         (WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
2233         (WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
2234         (WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
2235         (WebCore::RenderThemeWinCE::paintSearchFieldResultsDecoration):
2236         (WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
2237         (WebCore::RenderThemeWinCE::paintSearchFieldResultsButton):
2238         (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
2239         (WebCore::RenderThemeWinCE::paintSliderTrack):
2240         (WebCore::RenderThemeWinCE::paintSliderThumb):
2241         (WebCore::RenderThemeWinCE::paintMediaFullscreenButton):
2242         (WebCore::RenderThemeWinCE::paintMediaMuteButton):
2243         (WebCore::RenderThemeWinCE::paintMediaPlayButton):
2244         (WebCore::RenderThemeWinCE::paintMediaSeekBackButton):
2245         (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):
2246         (WebCore::RenderThemeWinCE::paintMediaSliderTrack):
2247         (WebCore::RenderThemeWinCE::paintMediaSliderThumb):
2248         * rendering/RenderThemeWinCE.h: Copied from WebCore/rendering/RenderThemeWince.h.
2249         * rendering/RenderThemeWince.cpp: Removed.
2250         * rendering/RenderThemeWince.h: Removed.
2251         * storage/wince/DatabaseThreadWinCE.cpp: Copied from WebCore/storage/wince/DatabaseThreadWince.cpp.
2252         * storage/wince/DatabaseThreadWinCE.h: Copied from WebCore/storage/wince/DatabaseThreadWince.h.
2253         * storage/wince/DatabaseThreadWince.cpp: Removed.
2254         * storage/wince/DatabaseThreadWince.h: Removed.
2255         * storage/wince/LocalStorageThreadWinCE.cpp: Copied from WebCore/storage/wince/LocalStorageThreadWince.cpp.
2256         * storage/wince/LocalStorageThreadWinCE.h: Copied from WebCore/storage/wince/LocalStorageThreadWince.h.
2257         * storage/wince/LocalStorageThreadWince.cpp: Removed.
2258         * storage/wince/LocalStorageThreadWince.h: Removed.
2259
2260 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2261
2262         Reviewed by Eric Seidel.
2263
2264         Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
2265         https://bugs.webkit.org/show_bug.cgi?id=45900
2266
2267         PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
2268         Move them into plaform sepcific build system.
2269
2270         * CMakeLists.txt:
2271         * CMakeListsEfl.txt:
2272
2273 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
2274
2275         Reviewed by Simon Hausmann.
2276
2277         [Qt] Don't copy clip path to TransparencyLayer
2278         https://bugs.webkit.org/show_bug.cgi?id=45965
2279
2280         We don't need to copy the GC's clip path to the TransparencyLayer since it will
2281         clip anyway when ending the layer.
2282
2283         * platform/graphics/qt/TransparencyLayer.h:
2284         (WebCore::TransparencyLayer::TransparencyLayer):
2285
2286 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2287
2288         Unreviewed.
2289
2290         [WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.
2291
2292         * page/wince/FrameWince.cpp:
2293         (WebCore::computePageRectsForFrame):
2294         (WebCore::imageFromSelection):
2295
2296 2010-09-18  Kent Tamura  <tkent@chromium.org>
2297
2298         Unreviewed, a trivial change.
2299
2300         Run sort-Xcode-project-file.
2301
2302         * WebCore.xcodeproj/project.pbxproj:
2303
2304 2010-09-18  Dan Bernstein  <mitz@apple.com>
2305
2306         Reviewed by Eric Seidel.
2307
2308         REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
2309         https://bugs.webkit.org/show_bug.cgi?id=46031
2310
2311         * page/Frame.cpp:
2312         (WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
2313         (WebCore::parentTextZoomFactor): Ditto.
2314
2315 2010-09-17  Sam Weinig  <sam@webkit.org>
2316
2317         Reviewed by Jon Honeycutt.
2318
2319         Need a way to load data (as plain text) in a WKPage
2320         <rdar://problem/8424239>
2321
2322         * WebCore.exp.in:
2323
2324 2010-09-17  David Hyatt  <hyatt@apple.com>
2325
2326         Reviewed by Sam Weinig.
2327
2328         https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.
2329         
2330         Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
2331         when appropriate.  An image on a line did this, but a block-level image did not.
2332
2333         Added fast/multicol/image-inside-nested-blocks-with-border.html
2334
2335         * rendering/RenderBlock.cpp:
2336         (WebCore::RenderBlock::layoutBlockChild):
2337
2338 2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>
2339
2340         Unreviewed, build fix.
2341
2342         Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().
2343
2344         * page/EventHandler.cpp:
2345         (WebCore::EventHandler::handleTouchEvent): Removed a helper function,
2346             added direct calls to frame->pageZoomFactor().
2347
2348 2010-09-17  David Hyatt  <hyatt@apple.com>
2349
2350         Reviewed by Simon Fraser.
2351
2352         https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
2353
2354         Make printing store the page height in the RenderView and push that into the layout state to
2355         use the new pagination model.  The old pagination model is retained because it is still used
2356         for embedded WebViews.
2357
2358         * page/FrameView.cpp:
2359         (WebCore::FrameView::reset):
2360         (WebCore::FrameView::layout):
2361         (WebCore::FrameView::forceLayout):
2362         (WebCore::FrameView::forceLayoutForPagination):
2363         (WebCore::FrameView::adjustPageHeight):
2364         * page/FrameView.h:
2365         * page/PrintContext.cpp:
2366         (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
2367         * rendering/RenderBlock.cpp:
2368         (WebCore::RenderBlock::paintChildren):
2369         * rendering/RenderBox.cpp:
2370         (WebCore::RenderBox::calcHeight):
2371         * rendering/RenderImage.cpp:
2372         (WebCore::RenderImage::paintReplaced):
2373         * rendering/RenderLineBoxList.cpp:
2374         (WebCore::RenderLineBoxList::paint):
2375         * rendering/RenderVideo.cpp:
2376         (WebCore::RenderVideo::paintReplaced):
2377         * rendering/RenderView.cpp:
2378         (WebCore::RenderView::RenderView):
2379         (WebCore::RenderView::layout):
2380         (WebCore::RenderView::paint):
2381         (WebCore::RenderView::setBestTruncatedAt):
2382         * rendering/RenderView.h:
2383         (WebCore::RenderView::popLayoutState):
2384         (WebCore::RenderView::pageHeight):
2385         (WebCore::RenderView::setPageHeight):
2386         (WebCore::RenderView::bestTruncatedAt):
2387         (WebCore::RenderView::truncatedAt):
2388         (WebCore::RenderView::setTruncatedAt):
2389         (WebCore::RenderView::printRect):
2390         (WebCore::RenderView::setPrintRect):
2391         (WebCore::RenderView::pushLayoutState):
2392         (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
2393         (WebCore::LayoutStateMaintainer::push):
2394         (WebCore::LayoutStateMaintainer::pop):
2395
2396 2010-09-17  Dan Bernstein  <mitz@apple.com>
2397
2398         Reviewed by Simon Fraser.
2399
2400         Canvas sizing ignores intrinsic size
2401         https://bugs.webkit.org/show_bug.cgi?id=46024
2402
2403         Updated fast/replaced/table-percent-height.html
2404
2405         * rendering/RenderEmbeddedObject.cpp:
2406         (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
2407         for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
2408         width is auto and height is specified).
2409         * rendering/RenderImage.cpp:
2410         (WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
2411         RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
2412         which we don’t want.
2413         (WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().
2414         * rendering/RenderImage.h:
2415         * rendering/RenderReplaced.cpp:
2416         (WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
2417         (WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
2418         is{Width,Height}Specified().
2419         (WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
2420         up here so other replaced objects could use this logic.
2421         (WebCore::RenderReplaced::calcReplacedHeight): Ditto.
2422         (WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
2423         (WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
2424         (WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
2425         of the logic.
2426         (WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.
2427         * rendering/RenderReplaced.h:
2428         (WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
2429         to allow RenderVideo to call through.
2430         (WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.
2431         * rendering/RenderVideo.cpp:
2432         (WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
2433         the way other RenderReplaced objects do.
2434         (WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
2435         which matches what used to be here, skipping over the RenderImage implementation.
2436         (WebCore::RenderVideo::calcReplacedHeight): Ditto.
2437         (WebCore::RenderVideo::minimumReplacedHeight): Ditto.
2438         * rendering/RenderVideo.h:
2439
2440 2010-09-17  Darin Adler  <darin@apple.com>
2441
2442         Build fix for platforms that compile Touch.
2443
2444         * dom/Touch.cpp:
2445         (WebCore::contentsX):
2446         (WebCore::contentsY):
2447         Get zoom factor from Frame rather than FrameView.
2448
2449 2010-09-17  Darin Adler  <darin@apple.com>
2450
2451         Reviewed by Sam Weinig.
2452
2453         REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
2454         https://bugs.webkit.org/show_bug.cgi?id=42863
2455
2456         Moved zoom level back from FrameView to Frame.
2457         I had forgotten that FrameView's lifetime is much shorter than
2458         Frame's, and until that is fixed it's best to leave this on Frame.
2459
2460         * WebCore.exp.in: Updated.
2461
2462         * css/CSSStyleSelector.cpp:
2463         (WebCore::CSSStyleSelector::styleForDocument):
2464         (WebCore::CSSStyleSelector::applyProperty):
2465         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
2466         * dom/Document.cpp:
2467         (WebCore::Document::nodesFromRect):
2468         (WebCore::Document::elementFromPoint):
2469         (WebCore::Document::caretRangeFromPoint):
2470         * dom/MouseRelatedEvent.cpp:
2471         (WebCore::contentsX):
2472         (WebCore::contentsY):
2473         (WebCore::pageZoomFactor):
2474         * dom/Node.cpp:
2475         (WebCore::Node::dispatchMouseEvent):
2476         (WebCore::Node::dispatchWheelEvent):
2477         * html/HTMLBodyElement.cpp:
2478         (WebCore::adjustForZoom):
2479         (WebCore::HTMLBodyElement::scrollLeft):
2480         (WebCore::HTMLBodyElement::setScrollLeft):
2481         (WebCore::HTMLBodyElement::scrollTop):
2482         (WebCore::HTMLBodyElement::setScrollTop):
2483         (WebCore::HTMLBodyElement::scrollHeight):
2484         (WebCore::HTMLBodyElement::scrollWidth):
2485         * html/ImageDocument.cpp:
2486         (WebCore::pageZoomFactor):
2487         (WebCore::ImageDocument::scale):
2488         (WebCore::ImageDocument::imageFitsInWindow):
2489         * page/DOMWindow.cpp:
2490         (WebCore::DOMWindow::innerHeight):
2491         (WebCore::DOMWindow::innerWidth):
2492         (WebCore::DOMWindow::scrollX):
2493         (WebCore::DOMWindow::scrollY):
2494         (WebCore::DOMWindow::scrollTo):
2495         * page/DragController.cpp:
2496         (WebCore::elementUnderMouse):
2497         * rendering/RenderView.cpp:
2498         (WebCore::RenderView::zoomFactor):
2499         * svg/SVGSVGElement.cpp:
2500         (WebCore::SVGSVGElement::currentScale):
2501         (WebCore::SVGSVGElement::setCurrentScale):
2502         Get zoom factor from Frame rather than FrameView.
2503
2504         * page/Frame.cpp:
2505         (WebCore::parentPageZoomFactor): Moved back here from FrameView.
2506         (WebCore::parentTextZoomFactor): Ditto.
2507         (WebCore::Frame::Frame): Ditto.
2508         (WebCore::Frame::setPageZoomFactor): Ditto.
2509         (WebCore::Frame::setTextZoomFactor): Ditto.
2510         (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
2511
2512         * page/Frame.h: Moved functions and data for zooming back here
2513         from FrameView.
2514
2515         * page/FrameView.cpp:
2516         (WebCore::FrameView::FrameView):
2517         * page/FrameView.h:
2518         Removed code from here.
2519
2520 2010-09-17  Matthew Delaney  <mdelaney@apple.com>
2521
2522         Reviewed by Simon Fraser.
2523
2524         Reduce minimum DOMTimer interval
2525         https://bugs.webkit.org/show_bug.cgi?id=45362
2526
2527         Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
2528         which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
2529         performance on perf tests that have tight frequent loops such as canvas "animation"
2530         performance tests.
2531
2532         No new tests added. Can't reliably instrument a test in javascript to verify that
2533         the minimum clamped interval time is in fact 4ms. 
2534
2535         * WebCore.exp.in:
2536         * page/DOMTimer.cpp: Removed old comments.
2537         * page/DOMTimer.h: Removed old comments.
2538         * page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
2539         * page/Settings.h:
2540
2541 2010-09-17  Marc-Antoine Ruel  <maruel@chromium.org>
2542
2543         Reviewed by Dimitri Glazkov.
2544
2545         [Chromium] Split webcore_platform off webcore_remaining
2546
2547         Further reduce webcore_remaining size by moving platform/ code in its
2548         own static libary.
2549         https://bugs.webkit.org/show_bug.cgi?id=45915
2550
2551         * WebCore.gyp/WebCore.gyp:
2552
2553 2010-09-13  Matt Perry  <mpcomplete@chromium.org>
2554
2555         Reviewed by Darin Fisher.
2556
2557         Have V8DOMWindowShell ask the embedder whether to run a V8 extension
2558         in a particular script context.
2559         https://bugs.webkit.org/show_bug.cgi?id=45721
2560
2561         * bindings/v8/V8DOMWindowShell.cpp:
2562         (WebCore::V8DOMWindowShell::createNewContext):
2563         * bindings/v8/V8Proxy.cpp:
2564         (WebCore::V8Proxy::registeredExtensionWithV8):
2565         (WebCore::V8Proxy::registerExtension):
2566         * bindings/v8/V8Proxy.h:
2567         * loader/EmptyClients.h:
2568         (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
2569         * loader/FrameLoaderClient.h:
2570
2571 2010-09-17  Anders Carlsson  <andersca@apple.com>
2572
2573         Reviewed by Sam Weinig.
2574
2575         REGRESSION (r66711): Plug-in replacement text is never shown
2576         https://bugs.webkit.org/show_bug.cgi?id=45997
2577         <rdar://problem/8446766>
2578
2579         Don't return when the plug-in has replacement text.
2580
2581         * rendering/RenderEmbeddedObject.cpp:
2582         (WebCore::RenderEmbeddedObject::paintReplaced):
2583
2584 2010-09-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2585
2586         Unreviewed, build fix. Add files missed in r67704.
2587
2588         * CMakeLists.txt:
2589
2590 2010-09-17  Simon Fraser  <simon.fraser@apple.com>
2591
2592         Reviewed by Chris Marrin.
2593
2594         Remove scroll and clip layers for WKCACFLayerRenderer
2595         https://bugs.webkit.org/show_bug.cgi?id=45922
2596
2597         WKCACFLayerRenderer no longer needs its own layers for managing scrolling
2598         and clipping, because RenderLayerCompositor provides this functionality.
2599
2600         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
2601         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame().
2602         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
2603
2604         * platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers
2605         (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
2606         (WebCore::WKCACFLayerRenderer::setRootChildLayer):
2607         (WebCore::WKCACFLayerRenderer::destroyRenderer):
2608         (WebCore::WKCACFLayerRenderer::resize):
2609         * platform/graphics/win/WKCACFLayerRenderer.h:
2610
2611         * rendering/RenderLayerCompositor.cpp:
2612         (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer.
2613         (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows,
2614         always say yes.
2615
2616 2010-09-17  Jian Li  <jianli@chromium.org>
2617
2618         Reviewed by Dmitry Titov.
2619
2620         createBlobURL with no argument causes crash.
2621         https://bugs.webkit.org/show_bug.cgi?id=45880
2622
2623         The fix is to check if the passing blob argument is NULL or not.
2624
2625         Test: fast/files/create-blob-url-crash.html
2626
2627         * dom/ScriptExecutionContext.cpp:
2628         (WebCore::ScriptExecutionContext::createPublicBlobURL):
2629         * page/DOMWindow.idl: Add attribute to convert null string to undefined.
2630
2631 2010-09-17  Chris Marrin  <cmarrin@apple.com>
2632
2633         Reviewed by Simon Fraser.
2634
2635         Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
2636         https://bugs.webkit.org/show_bug.cgi?id=45911
2637
2638         * WebCore.exp.in:
2639
2640 2010-09-17  Tony Gentilcore  <tonyg@chromium.org>
2641
2642         Reviewed by Adam Barth.
2643
2644         ASSERTION FAILED: m_loadEventDelayCount
2645         https://bugs.webkit.org/show_bug.cgi?id=45790
2646
2647         * dom/AsyncScriptRunner.cpp: 
2648         (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
2649
2650 2010-09-17  Stephen White  <senorblanco@chromium.org>
2651
2652         Reviewed by Kenneth Russell.
2653
2654         [CHROMIUM] GPU-accelerated canvas should work in test_shell.
2655         https://bugs.webkit.org/show_bug.cgi?id=45968
2656
2657         In order for the shaders in GPU-accelerated canvas to work in both the
2658         GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
2659         passes them to the Mesa backend unmodified), the precision specifiers
2660         in the fragment shader have to be wrapped in #if GL_ES.
2661
2662         Soon to be covered by many layout tests.
2663
2664         * platform/graphics/gpu/SolidFillShader.cpp:
2665         (WebCore::SolidFillShader::create):
2666         * platform/graphics/gpu/TexShader.cpp:
2667         (WebCore::TexShader::create):
2668
2669 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2670
2671         Reviewed by Xan Lopez.
2672
2673         [GTK] [REGRESSION] Listbox rendering is incorrect
2674         https://bugs.webkit.org/show_bug.cgi?id=45941
2675
2676         Only apply the shadow tiling optimization to a layer if the GraphicsContext
2677         has a shadow.
2678
2679         This is covered by manual-tests/select-element-type-select.html.
2680
2681         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2682         (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization
2683         first check to see if the context has a shadow at all.
2684
2685 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2686
2687         Reviewed by Oliver Hunt.
2688
2689         [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
2690         https://bugs.webkit.org/show_bug.cgi?id=45917
2691
2692         Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
2693         members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
2694         as this type is reference-counted.
2695
2696         No new tests as this should not introduce any functionality changes.
2697
2698         * platform/graphics/cairo/FontCacheFreeType.cpp:
2699         (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes.
2700         (WebCore::FontCache::createFontPlatformData): Ditto.
2701         * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
2702         (WebCore::FontPlatformData::FontPlatformData): Ditto.
2703         (WebCore::FontPlatformData::operator=): Ditto.
2704         (WebCore::FontPlatformData::~FontPlatformData): Ditto.
2705         (WebCore::FontPlatformData::isFixedPitch): Ditto.
2706         (WebCore::FontPlatformData::operator==): Ditto.
2707         * platform/graphics/cairo/FontPlatformDataFreeType.h:
2708         (WebCore::FontPlatformData::FontPlatformData): Ditto.
2709         (WebCore::FontPlatformData::scaledFont): Ditto.
2710         (WebCore::FontPlatformData::hash): Ditto.
2711         (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
2712         * platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp:
2713         (WebCore::GlyphPage::fill): Ditto.
2714         * platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
2715         * platform/graphics/cairo/OwnPtrCairo.h: Ditto.
2716         * platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations.
2717         (WTF::refPlatformPtr): Ditto.
2718         (WTF::derefPlatformPtr): Ditto.
2719         * platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
2720         * platform/graphics/cairo/SimpleFontDataCairo.cpp:
2721         (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes.
2722         (WebCore::SimpleFontData::containsCharacters): Ditto.
2723         (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
2724         * platform/graphics/gtk/FontGtk.cpp:
2725         (WebCore::setPangoAttributes): Ditto.
2726
2727 2010-09-14  Pavel Podivilov  <podivilov@chromium.org>
2728
2729         Reviewed by Pavel Feldman.
2730
2731         Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
2732         https://bugs.webkit.org/show_bug.cgi?id=45114
2733
2734         * English.lproj/localizedStrings.js:
2735         * inspector/InspectorDOMAgent.cpp:
2736         (WebCore::InspectorDOMAgent::performSearch):
2737         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
2738         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
2739         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
2740         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
2741         * inspector/InspectorDOMAgent.h:
2742         * inspector/InspectorDebuggerAgent.cpp:
2743         (WebCore::InspectorDebuggerAgent::didPause):
2744         * inspector/front-end/CallStackSidebarPane.js:
2745         (WebInspector.CallStackSidebarPane):
2746         (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s):
2747         (WebInspector.CallStackSidebarPane.prototype.updateStatus.append):
2748         (WebInspector.CallStackSidebarPane.prototype.updateStatus):
2749         * inspector/front-end/ElementsPanel.js:
2750         (WebInspector.ElementsPanel.prototype.linkifyNodeById):
2751         * inspector/front-end/ScriptsPanel.js:
2752         (WebInspector.ScriptsPanel.prototype.debuggerPaused):
2753         * inspector/front-end/inspector.css:
2754         (.pane > .body .placard + .info):
2755         * inspector/front-end/inspector.js:
2756         (WebInspector.pausedScript):
2757         (WebInspector.formatLocalized):
2758
2759 2010-09-17  Johnny Ding  <jnd@chromium.org>
2760
2761         Reviewed by Adam Barth.
2762
2763         Stop history reload navigation to bypass WebKit's popup blocker.
2764         Now history reload can only navigate the page in self frame, no matter
2765         what target frame is defined in <base> and no new window can be created.
2766         https://bugs.webkit.org/show_bug.cgi?id=45369
2767
2768         Test: fast/events/popup-blocked-from-history-reload.html
2769
2770         * loader/RedirectScheduler.cpp:
2771         (WebCore::ScheduledNavigation::ScheduledNavigation):
2772         (WebCore::ScheduledNavigation::wasUserGesture):
2773         Move the m_wasUserGesture to base class ScheduledNavigation. Then all
2774         asynchronous navigation situations can restore the correct gesture state
2775         during the real navigation process.
2776         (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
2777         (WebCore::ScheduledURLNavigation::fire):
2778         (WebCore::ScheduledURLNavigation::referrer):
2779         (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
2780         (WebCore::ScheduledHistoryNavigation::fire):
2781         (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
2782         (WebCore::ScheduledFormSubmission::fire):
2783         (WebCore::RedirectScheduler::scheduleHistoryNavigation):
2784
2785 2010-09-16  Vangelis Kokkevis  <vangelis@chromium.org>
2786
2787         Reviewed by James Robinson.
2788
2789         [chromium] Clip the update region of an ImageLayerChromium to actual size
2790         of the image bitmap to prevent uninitialized memory access when uploading
2791         the dirty region to the texture.
2792         https://bugs.webkit.org/show_bug.cgi?id=45937
2793
2794
2795         * platform/graphics/chromium/ImageLayerChromium.cpp:
2796         (WebCore::ImageLayerChromium::updateContents):
2797
2798 2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>
2799
2800         Reviewed by David Hyatt.
2801
2802         Remove extraneous RenderObject traversal.
2803         https://bugs.webkit.org/show_bug.cgi?id=45821
2804
2805         This code always exits in the first iteration of the loop,
2806         because in the context of this call, node->renderer()->node() != 0
2807         is always true.
2808
2809         No behavior change, covered by existing tests.
2810
2811         * page/EventHandler.cpp:
2812         (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop.
2813         (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
2814
2815 2010-09-17  Pavel Feldman  <pfeldman@chromium.org>
2816
2817         Reviewed by Yury Semikhatsky.
2818
2819         Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
2820         resource as not cached to InspectorController.
2821         https://bugs.webkit.org/show_bug.cgi?id=45961
2822
2823         Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
2824         resource as not cached to InspectorController.
2825         There is one path in control flow that leads to resources being
2826         reported as not cached. Patch to follow.
2827
2828         * inspector/InspectorController.cpp:
2829         (WebCore::InspectorController::markResourceAsCached):
2830         * inspector/InspectorController.h:
2831         * inspector/InspectorResource.cpp:
2832         (WebCore::InspectorResource::markAsCached):
2833         (WebCore::InspectorResource::updateResponse):
2834         * inspector/InspectorResource.h:
2835         * loader/FrameLoader.cpp:
2836         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
2837
2838 2010-09-17  Alexander Pavlov  <apavlov@chromium.org>
2839
2840         Unreviewed, build fix. Add files missed in the previous commit.
2841
2842         * GNUmakefile.am:
2843         * css/CSSPropertySourceData.cpp: Added.
2844         (WebCore::SourceRange::SourceRange):
2845         (WebCore::SourceRange::operator=):
2846         (WebCore::CSSPropertySourceData::CSSPropertySourceData):
2847         (WebCore::CSSPropertySourceData::operator=):
2848         (WebCore::CSSPropertySourceData::toString):
2849         (WebCore::CSSPropertySourceData::hash):
2850         (WebCore::CSSPropertySourceData::init):
2851         * css/CSSPropertySourceData.h: Added.
2852         (WebCore::CSSPropertySourceData::~CSSPropertySourceData):
2853         (WebCore::CSSStyleSourceData::create):
2854
2855 2010-09-15  Alexander Pavlov  <apavlov@chromium.org>
2856
2857         Reviewed by Pavel Feldman.
2858
2859         Provide source-based properties for style declarations to CSSParser clients
2860
2861         This change:
2862         - Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets,
2863           even with the resource tracking turned off.
2864         - Adds to CSSParser a capability of source-related style declaration data extraction:
2865           * Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
2866           * Start/end source offsets for CSS properties, relative to the declaration start.
2867           * CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
2868         - Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData().
2869         https://bugs.webkit.org/show_bug.cgi?id=44949
2870
2871         * WebCore.gypi:
2872         * WebCore.pro:
2873         * WebCore.vcproj/WebCore.vcproj:
2874         * WebCore.xcodeproj/project.pbxproj:
2875         * css/CSSGrammar.y:
2876         * css/CSSMutableStyleDeclaration.h:
2877         (WebCore::CSSMutableStyleDeclaration::node):
2878         * css/CSSParser.cpp:
2879         (WebCore::CSSParser::CSSParser):
2880         (WebCore::CSSParser::parseSheet):
2881         (WebCore::CSSParser::parseDeclaration):
2882         (WebCore::CSSParser::createStyleRule):
2883         (WebCore::CSSParser::markRuleBodyStart):
2884         (WebCore::CSSParser::markPropertyStart):
2885         (WebCore::CSSParser::markPropertyEnd):
2886         * css/CSSParser.h:
2887         (WebCore::CSSParser::resetPropertyMarks):
2888         * css/CSSPropertySourceData.cpp: Added.
2889         (WebCore::SourceRange::SourceRange):
2890         (WebCore::SourceRange::operator=):
2891         (WebCore::CSSPropertySourceData::CSSPropertySourceData):
2892         (WebCore::CSSPropertySourceData::operator=):
2893         (WebCore::CSSPropertySourceData::toString):
2894         (WebCore::CSSPropertySourceData::hash):
2895         (WebCore::CSSPropertySourceData::init):
2896         * css/CSSPropertySourceData.h: Added.
2897         (WebCore::CSSPropertySourceData::~CSSPropertySourceData):
2898         (WebCore::CSSStyleSourceData::create):
2899         * inspector/Inspector.idl:
2900         * inspector/InspectorCSSStore.cpp:
2901         (WebCore::InspectorCSSStore::reset):
2902         (WebCore::InspectorCSSStore::styleSheetText):
2903         (WebCore::InspectorCSSStore::resourceStyleSheetText):
2904         (WebCore::InspectorCSSStore::inlineStyleSheetText):
2905         (WebCore::InspectorCSSStore::getStyleSourceData):
2906         (WebCore::InspectorCSSStore::extractRanges):
2907         (WebCore::InspectorCSSStore::getStyleAttributeRanges):
2908         (WebCore::InspectorCSSStore::getParentStyleSheet):
2909         (WebCore::InspectorCSSStore::inlineStyleElement):
2910         * inspector/InspectorCSSStore.h:
2911         * inspector/InspectorController.cpp:
2912         (WebCore::InspectorController::resourceContentForURL):
2913         * inspector/InspectorController.h:
2914         * inspector/InspectorDOMAgent.cpp:
2915         (WebCore::InspectorDOMAgent::getStyleSourceData):
2916         (WebCore::InspectorDOMAgent::buildObjectForStyle):
2917         * inspector/InspectorDOMAgent.h:
2918
2919 2010-09-17  Alexander Pavlov  <apavlov@chromium.org>
2920
2921         Reviewed by Pavel Feldman.
2922
2923         Web Inspector: Show node description in inspector highlight
2924         https://bugs.webkit.org/show_bug.cgi?id=20930
2925
2926         * inspector/InspectorController.cpp:
2927         (WebCore::InspectorController::drawNodeHighlight):
2928         (WebCore::InspectorController::drawElementTitle):
2929         * inspector/InspectorController.h:
2930
2931 2010-09-16  takano takumi  <takano1@asia.apple.com>
2932
2933         Reviewed by Kent Tamura.
2934
2935         https://bugs.webkit.org/show_bug.cgi?id=45020
2936         Support "block-flow" and "writing-mode": interpret properties into RenderStyle
2937
2938         Fixed a regression in SVG test introduced by my previous change.
2939
2940         * css/CSSPrimitiveValueMappings.h:
2941         (WebCore::CSSPrimitiveValue::operator EWritingMode):
2942         * css/SVGCSSParser.cpp:
2943         (WebCore::CSSParser::parseSVGValue):
2944
2945 2010-09-16  Kenneth Russell  <kbr@google.com>
2946
2947         Reviewed by James Robinson.
2948
2949         Add entry points to GraphicsContext3D needed for Chromium compositor port
2950         https://bugs.webkit.org/show_bug.cgi?id=45939
2951
2952         Added entry points for two Chromium-specific extensions, and added
2953         a flag to the GraphicsContext3D constructor, currently unsupported
2954         by all ports (including Chromium), indicating whether the context
2955         should render directly to the passed HostWindow or off-screen per
2956         the current semantics. The switch to use GraphicsContext3D in
2957         Chromium's compositor will follow in a subsequent patch.
2958
2959         No new tests; functionality is unchanged. Built and tested
2960         Chromium and WebKit on Mac OS X.
2961
2962         * platform/graphics/GraphicsContext3D.cpp:
2963         (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM):
2964         (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM):
2965         (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM):
2966         (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM):
2967         (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM):
2968         (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM):
2969         (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
2970         * platform/graphics/GraphicsContext3D.h:
2971         * platform/graphics/mac/GraphicsContext3DMac.mm:
2972         (WebCore::GraphicsContext3D::create):
2973         (WebCore::GraphicsContext3D::GraphicsContext3D):
2974         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2975         (WebCore::GraphicsContext3D::create):
2976         (WebCore::GraphicsContext3D::GraphicsContext3D):
2977
2978 2010-09-16  Simon Fraser  <simon.fraser@apple.com>
2979
2980         Reviewed by James Robinson.
2981
2982         In layerTreeAsText output, avoid printing properties which have their default values
2983         https://bugs.webkit.org/show_bug.cgi?id=45931
2984
2985         Don't dump properties that have their default values to simplify output.
2986
2987         * platform/graphics/GraphicsLayer.cpp:
2988         (WebCore::GraphicsLayer::dumpProperties):
2989
2990 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
2991
2992         Reviewed by Ariya Hidayat.
2993
2994         [Qt] GraphicsContext: Remove unused variable
2995
2996         GraphicsContextPlatformPrivate::redirect wasn't used for anything.
2997
2998         * platform/graphics/qt/GraphicsContextQt.cpp:
2999         (WebCore::GraphicsContextPlatformPrivate::p):
3000         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
3001
3002 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
3003
3004         Reviewed by Ariya Hidayat.
3005
3006         [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
3007         https://bugs.webkit.org/show_bug.cgi?id=45923
3008
3009         QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
3010         instead of QPainter::clipPath().isEmpty().
3011
3012         * platform/graphics/qt/TransparencyLayer.h:
3013         (WebCore::TransparencyLayer::TransparencyLayer):
3014
3015 2010-09-16  David Hyatt  <hyatt@apple.com>
3016
3017         Reviewed by Eric Seidel.
3018
3019         Fix for regression from my previous check-in.  Make sure not to move the LayoutRepainter line
3020         below the setHeight(0) call.  This meant it snagged the wrong rectangle and we ended up repainting
3021         the world.
3022
3023         * rendering/RenderBlock.cpp:
3024         (WebCore::RenderBlock::layoutBlock):
3025
3026 2010-09-16  takano takumi  <takano1@asia.apple.com>
3027
3028         Reviewed by Dave Hyatt.
3029
3030         https://bugs.webkit.org/show_bug.cgi?id=45020
3031         Support "block-flow" and "writing-mode": interpret properties into RenderStyle
3032  
3033         Added code that interprets "block-flow" property and "writing-mode" property settings
3034         into a RenderStyle object.
3035
3036         Test: fast/text/international/block-flow-parser-test.html
3037
3038         * css/CSSComputedStyleDeclaration.cpp:
3039         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3040         * css/CSSParser.cpp:
3041         (WebCore::CSSParser::parseValue):
3042         * css/CSSPrimitiveValueMappings.h:
3043         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3044         (WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):
3045         * css/CSSPropertyNames.in:
3046         * css/CSSStyleSelector.cpp:
3047         (WebCore::CSSStyleSelector::applyProperty):
3048         * css/CSSValueKeywords.in:
3049         * css/SVGCSSValueKeywords.in:
3050         * rendering/style/RenderStyle.cpp:
3051         (WebCore::RenderStyle::diff):
3052         * rendering/style/RenderStyle.h:
3053         (WebCore::InheritedFlags::setBitDefaults):
3054         (WebCore::InheritedFlags::blockFlow):
3055         (WebCore::InheritedFlags::setBlockFlow):
3056         (WebCore::InheritedFlags::initialBlockFlow):
3057         * rendering/style/RenderStyleConstants.h:
3058
3059 2010-09-16  Martin Robinson  <mrobinson@igalia.com>
3060
3061         Reviewed by Xan Lopez.
3062
3063         [GTK] Implement dissolveDragImageToFraction
3064         https://bugs.webkit.org/show_bug.cgi?id=45826
3065
3066         Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
3067         might this allow code to be shared between Cairo ports it prevents a
3068         full data copy when the image is not resized and makes the implementation
3069         of dissolveDragImageToFraction more straight-forward.
3070
3071         This feature is covered by manual-tests/drag-image.html.
3072
3073         * page/gtk/DragControllerGtk.cpp:
3074         (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag
3075         image a little smaller.
3076         * platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
3077         * platform/gtk/DragImageGtk.cpp:
3078         (WebCore::dragImageSize): Reimplemented to reflect new drag image type.
3079         (WebCore::deleteDragImage): Ditto.
3080         (WebCore::scaleDragImage): Ditto.
3081         (WebCore::dissolveDragImageToFraction): Filled the stub of this function.
3082         (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
3083         * platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.
3084
3085 2010-09-15  David Hyatt  <hyatt@apple.com>
3086
3087         Reviewed by Darin Adler.
3088
3089         https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.
3090
3091         This patch adds support for column breaking at layout time rather than at paint time.  New variables have been
3092         added to LayoutState and to ColumnInfo to track column information while laying out.
3093         
3094         The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
3095         into multiple columns.  Now, however, layout is aware of the columns and will move objects up and down vertically in order
3096         to ensure they don't intersect a break.
3097         
3098         Many new tests added in fast/multicol and new results added for existing fast/multicol tests.
3099
3100         * rendering/ColumnInfo.h:
3101         (WebCore::ColumnInfo::ColumnInfo):
3102         (WebCore::ColumnInfo::columnCount):
3103         (WebCore::ColumnInfo::columnHeight):
3104         (WebCore::ColumnInfo::setColumnCountAndHeight):
3105         (WebCore::ColumnInfo::setColumnHeight):
3106         (WebCore::ColumnInfo::updateMinimumColumnHeight):
3107         (WebCore::ColumnInfo::minimumColumnHeight):
3108         (WebCore::ColumnInfo::forcedBreaks):
3109         (WebCore::ColumnInfo::forcedBreakOffset):
3110         (WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
3111         (WebCore::ColumnInfo::clearForcedBreaks):
3112         (WebCore::ColumnInfo::addForcedBreak):
3113         * rendering/LayoutState.cpp:
3114         (WebCore::LayoutState::LayoutState):
3115         (WebCore::LayoutState::clearPaginationInformation):
3116         (WebCore::LayoutState::pageY):
3117         (WebCore::LayoutState::addForcedColumnBreak):
3118         * rendering/LayoutState.h:
3119         (WebCore::LayoutState::LayoutState):
3120         (WebCore::LayoutState::paginatingColumns):
3121         (WebCore::LayoutState::paginated):
3122         * rendering/RenderBlock.cpp:
3123         (WebCore::RenderBlock::RenderBlock):
3124         (WebCore::RenderBlock::~RenderBlock):
3125         (WebCore::RenderBlock::layoutBlock):
3126         (WebCore::RenderBlock::collapseMargins):
3127         (WebCore::RenderBlock::estimateVerticalPosition):
3128         (WebCore::RenderBlock::layoutBlockChild):
3129         (WebCore::RenderBlock::layoutPositionedObjects):
3130         (WebCore::RenderBlock::paintColumnRules):
3131         (WebCore::RenderBlock::paintColumnContents):
3132         (WebCore::RenderBlock::paintChildren):
3133         (WebCore::RenderBlock::insertFloatingObject):
3134         (WebCore::RenderBlock::removeFloatingObjects):
3135         (WebCore::RenderBlock::positionNewFloats):
3136         (WebCore::RenderBlock::positionNewFloatOnLine):
3137         (WebCore::RenderBlock::lowestPosition):
3138         (WebCore::RenderBlock::rightmostPosition):
3139         (WebCore::RenderBlock::leftmostPosition):
3140         (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
3141         (WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
3142         (WebCore::RenderBlock::hitTestColumns):
3143         (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
3144         (WebCore::RenderBlock::columnCount):
3145         (WebCore::RenderBlock::columnRectAt):
3146         (WebCore::RenderBlock::layoutColumns):
3147         (WebCore::RenderBlock::adjustPointToColumnContents):
3148         (WebCore::RenderBlock::adjustRectForColumns):
3149         (WebCore::RenderBlock::adjustForColumns):
3150         (WebCore::RenderBlock::setMaxTopMargins):
3151         (WebCore::RenderBlock::setMaxBottomMargins):
3152         (WebCore::RenderBlock::setPaginationStrut):
3153         (WebCore::RenderBlock::setPageY):
3154         (WebCore::RenderBlock::nextPageTop):
3155         (WebCore::inNormalFlow):
3156         (WebCore::RenderBlock::applyBeforeBreak):
3157         (WebCore::RenderBlock::applyAfterBreak):
3158         (WebCore::RenderBlock::adjustForUnsplittableChild):
3159         (WebCore::RenderBlock::adjustLinePositionForPagination):
3160         * rendering/RenderBlock.h:
3161         (WebCore::RenderBlock::paginationStrut):
3162         (WebCore::RenderBlock::pageY):
3163         (WebCore::RenderBlock::maxTopPosMargin):
3164         (WebCore::RenderBlock::maxTopNegMargin):
3165         (WebCore::RenderBlock::maxBottomPosMargin):
3166         (WebCore::RenderBlock::maxBottomNegMargin):
3167         (WebCore::RenderBlock::initMaxMarginValues):
3168         (WebCore::RenderBlock::FloatingObject::FloatingObject):
3169         (WebCore::RenderBlock::FloatingObject::type):
3170         (WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
3171         * rendering/RenderBlockLineLayout.cpp:
3172         (WebCore::RenderBlock::layoutInlineChildren):
3173         (WebCore::RenderBlock::determineStartPosition):
3174         (WebCore::RenderBlock::skipLeadingWhitespace):
3175         (WebCore::RenderBlock::findNextLineBreak):
3176         * rendering/RenderBox.cpp:
3177         (WebCore::RenderBox::mapLocalToContainer):
3178         (WebCore::RenderBox::computeRectForRepaint):
3179         (WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):
3180         * rendering/RenderBox.h:
3181         * rendering/RenderFlexibleBox.cpp:
3182         (WebCore::RenderFlexibleBox::layoutBlock):
3183         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3184         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3185         * rendering/RenderFlexibleBox.h:
3186         * rendering/RenderInline.cpp:
3187         (WebCore::RenderInline::computeRectForRepaint):
3188         (WebCore::RenderInline::mapLocalToContainer):
3189         * rendering/RenderLayer.cpp:
3190         (WebCore::RenderLayer::updatePagination):
3191         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3192         (WebCore::RenderLayer::hitTestChildLayerColumns):
3193         * rendering/RenderLineBoxList.cpp:
3194         (WebCore::RenderLineBoxList::paint):
3195         * rendering/RenderTable.cpp:
3196         (WebCore::RenderTable::RenderTable):
3197         (WebCore::RenderTable::layout):
3198         * rendering/RenderTable.h:
3199         * rendering/RenderTableRow.cpp:
3200         (WebCore::RenderTableRow::layout):
3201         * rendering/RenderTableSection.cpp:
3202         (WebCore::RenderTableSection::layoutRows):
3203         * rendering/RenderView.cpp:
3204         (WebCore::RenderView::RenderView):
3205         (WebCore::RenderView::pushLayoutState):
3206         * rendering/RenderView.h:
3207         (WebCore::RenderView::setTruncatedAt):
3208         (WebCore::RenderView::pushLayoutState):
3209         (WebCore::RenderView::popLayoutState):
3210         (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
3211         (WebCore::LayoutStateMaintainer::push):
3212         * rendering/RootInlineBox.h:
3213         (WebCore::RootInlineBox::RootInlineBox):
3214         (WebCore::RootInlineBox::paginationStrut):
3215         (WebCore::RootInlineBox::setPaginationStrut):
3216
3217 2010-09-16  Pavel Podivilov  <podivilov@chromium.org>
3218
3219         Reviewed by Dimitri Glazkov.
3220
3221         Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
3222         https://bugs.webkit.org/show_bug.cgi?id=45737
3223
3224         Test: fast/frames/frame-limit.html
3225
3226         * html/HTMLFrameOwnerElement.cpp:
3227         (WebCore::HTMLFrameOwnerElement::willRemove):
3228
3229 2010-09-16  Thomas Zander <t.zander@nokia.com>
3230
3231         Reviewed by Andreas Kling.
3232
3233         https://bugs.webkit.org/show_bug.cgi?id=45878
3234
3235         [Qt] Fixed incorrect Symbian scoping.
3236
3237         The missing install functionality is only true for mmp based systems.
3238
3239         * WebCore.pro: limit functionality to mmp systems.
3240
3241 2010-09-16  Anders Carlsson  <andersca@apple.com>
3242
3243         Fix clang build.
3244
3245         * page/animation/AnimationBase.h:
3246         Fix struct/class mismatch.
3247
3248 2010-09-16  Darin Adler  <darin@apple.com>
3249
3250         Reviewed by Andreas Kling.
3251
3252         Reduce use of HTMLInputElement::inputType so we can remove it later
3253         https://bugs.webkit.org/show_bug.cgi?id=45903
3254
3255         * accessibility/AccessibilityRenderObject.cpp:
3256         (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload.
3257         (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton.
3258         (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use
3259         isCheckbox and isRadioButton.
3260
3261         * css/CSSStyleSelector.cpp:
3262         (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.
3263
3264         * editing/Editor.cpp:
3265         (WebCore::Editor::setBaseWritingDirection): Use isTextField.
3266
3267         * editing/ReplaceSelectionCommand.cpp:
3268         (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.
3269
3270         * editing/SelectionController.cpp:
3271         (WebCore::SelectionController::isInPasswordField): Use isPasswordField.
3272
3273         * html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.
3274
3275         * page/Chrome.cpp:
3276         (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.
3277
3278         * page/DragController.cpp:
3279         (WebCore::asFileInput): Use isFileUpload.
3280
3281         * page/EventHandler.cpp:
3282         (WebCore::isSubmitImage): Use isImageButton.
3283
3284         * rendering/RenderFileUploadControl.cpp:
3285         (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.
3286
3287 2010-09-16  Pavel Podivilov  <podivilov@chromium.org>
3288
3289         Reviewed by Pavel Feldman.
3290
3291         Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
3292         https://bugs.webkit.org/show_bug.cgi?id=45901
3293
3294         * inspector/InspectorController.cpp:
3295         (WebCore::InspectorController::breakpointsSettingKey):
3296
3297 2010-09-16  Pavel Feldman  <pfeldman@chromium.org>
3298
3299         Reviewed by Yury Semikhatsky.
3300
3301         Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
3302         https://bugs.webkit.org/show_bug.cgi?id=45892
3303
3304         * inspector/InspectorResource.cpp:
3305         (WebCore::InspectorResource::endTiming):
3306
3307 2010-09-16  Ilya Tikhonovsky  <loislo@chromium.org>
3308
3309         Reviewed by Yury Semikhatsky.
3310
3311         Web Inspector: move resourceTracking flag under control of BackendSettings.
3312
3313         Four Inspector API methods about resourceTracking flag were removed.
3314         Actual state of the flag is transfered as the response of setResourceTracking request.
3315         Initial state of the flag on the frontend side is obtained from settings.backend.
3316
3317         https://bugs.webkit.org/show_bug.cgi?id=45887
3318
3319         * inspector/Inspector.idl:
3320         * inspector/InspectorController.cpp:
3321         (WebCore::InspectorController::getBackendSettings):
3322         (WebCore::InspectorController::populateScriptObjects):
3323         (WebCore::InspectorController::setResourceTracking):
3324         * inspector/InspectorController.h:
3325         * inspector/front-end/ResourcesPanel.js:
3326         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
3327         * inspector/front-end/Settings.js:
3328         (WebInspector.Settings.initialize.populateBackendSettings):
3329         (WebInspector.Settings.initialize):
3330         * inspector/front-end/inspector.js:
3331
3332 2010-09-16  Jian Li  <jianli@chromium.org>
3333
3334         Reviewed by David Levin.
3335
3336         BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
3337         https://bugs.webkit.org/show_bug.cgi?id=45909
3338
3339         * fileapi/ThreadableBlobRegistry.cpp:
3340         (WebCore::BlobRegistryContext::BlobRegistryContext):
3341
3342 2010-09-16  Daniel Cheng  <dcheng@chromium.org>
3343
3344         Reviewed by Simon Fraser.
3345
3346         [chromium] Fix incorrect drag node/selection painting.
3347         https://bugs.webkit.org/show_bug.cgi?id=45573
3348
3349         Drag selections were being incorrectly clipped when dragging a selection
3350         near the bottom of a page that was taller than the viewport. To fix
3351         this, we use paintContents() instead of paint().
3352
3353         * page/chromium/FrameChromium.cpp:
3354         (WebCore::Frame::nodeImage):
3355         (WebCore::Frame::dragImageForSelection):
3356
3357 2010-09-16  Daniel Cheng  <dcheng@chromium.org>
3358
3359         Reviewed by Tony Chang.
3360
3361         Fix incorrect usage of dissolveDragImageToFraction().
3362         https://bugs.webkit.org/show_bug.cgi?id=45835
3363
3364         createDragImageForSelection() was ignoring the return value of
3365         dissolveDragImageToFraction(). This didn't happen to crash on most
3366         platforms, since most implementations simply modified the image that was
3367         passed in. However, Chromium Mac's implementation actually creates a new
3368         image and returns that instead. This caused us to crash when copying the
3369         image from the renderer to the browser process, since the memory had
3370         already been freed.
3371
3372         * manual-tests/selection-drag-crash.html: Added.
3373         * platform/DragImage.cpp:
3374         (WebCore::createDragImageForSelection):
3375
3376 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3377
3378         Unreviewed, rolling out r67628.
3379         http://trac.webkit.org/changeset/67628
3380         https://bugs.webkit.org/show_bug.cgi?id=45904
3381
3382         broke the build (Requested by eric_carlson on #webkit).
3383
3384         * page/ContextMenuController.cpp:
3385         (WebCore::ContextMenuController::contextMenuItemSelected):
3386         * platform/ContextMenu.cpp:
3387         (WebCore::ContextMenu::populate):
3388         (WebCore::ContextMenu::checkOrEnableIfNeeded):
3389         * platform/ContextMenuItem.h:
3390         * platform/LocalizationStrategy.h:
3391         * platform/LocalizedStrings.cpp:
3392         * platform/LocalizedStrings.h:
3393         * platform/android/LocalizedStringsAndroid.cpp:
3394         * platform/brew/LocalizedStringsBrew.cpp:
3395         * platform/efl/LocalizedStringsEfl.cpp:
3396         * platform/gtk/ContextMenuItemGtk.cpp:
3397         (WebCore::gtkStockIDFromContextMenuAction):
3398         * platform/gtk/LocalizedStringsGtk.cpp:
3399         * platform/haiku/LocalizedStringsHaiku.cpp:
3400         * platform/wx/LocalizedStringsWx.cpp:
3401         * rendering/HitTestResult.cpp:
3402         (WebCore::HitTestResult::absoluteMediaURL):
3403         * rendering/HitTestResult.h:
3404
3405 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
3406
3407         Reviewed by Simon Fraser.
3408
3409         CSS: Fix crash in getTimingFunctionValue()
3410         https://bugs.webkit.org/show_bug.cgi?id=45896
3411
3412         Use a RefPtr to avoid deleting the TimingFunction prematurely.
3413
3414         This is covered by existing tests, e.g transitions/inherit-other-props.html
3415         but will only actually crash on picky platforms (or in valgrind.)
3416
3417         * css/CSSComputedStyleDeclaration.cpp:
3418         (WebCore::getTimingFunctionValue):
3419
3420 2010-09-16  Pavel Feldman  <pfeldman@chromium.org>
3421
3422         Reviewed by Yury Semikhatsky.
3423
3424         Web Inspector: prevent resource timing popover from having scrollers.
3425         https://bugs.webkit.org/show_bug.cgi?id=45883
3426
3427         * inspector/front-end/ResourcesPanel.js:
3428         (WebInspector.ResourcesPanel.prototype._showPopover):
3429
3430 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3431
3432         Reviewed by Eric Carlson.
3433
3434         [GTK] enhanced context menu for media elements
3435         https://bugs.webkit.org/show_bug.cgi?id=45021
3436
3437         New items in the media Element context menu:
3438         - play/pause
3439         - mute/unmute
3440         - controls display control
3441         - switch to fullscreen (for video only)
3442         - loop playback control
3443         - copy media url to clipboard
3444         - open in new window
3445
3446         Test: media/context-menu-actions.html
3447
3448         * page/ContextMenuController.cpp:
3449         (WebCore::ContextMenuController::contextMenuItemSelected):
3450         * platform/ContextMenu.cpp:
3451         (WebCore::ContextMenu::populate):
3452         (WebCore::ContextMenu::checkOrEnableIfNeeded):
3453         * platform/ContextMenuItem.h:
3454         * platform/LocalizationStrategy.h:
3455         * platform/LocalizedStrings.cpp:
3456         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3457         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3458         (WebCore::contextMenuItemTagToggleMediaControls):
3459         (WebCore::contextMenuItemTagToggleMediaLoop):
3460         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3461         (WebCore::contextMenuItemTagMediaPlay):
3462         (WebCore::contextMenuItemTagMediaPause):
3463         (WebCore::contextMenuItemTagMediaMute):
3464         (WebCore::contextMenuItemTagMediaUnMute):
3465         * platform/LocalizedStrings.h:
3466         * platform/android/LocalizedStringsAndroid.cpp:
3467         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3468         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3469         (WebCore::contextMenuItemTagToggleMediaControls):
3470         (WebCore::contextMenuItemTagToggleMediaLoop):
3471         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3472         (WebCore::contextMenuItemTagMediaPlay):
3473         (WebCore::contextMenuItemTagMediaPause):
3474         (WebCore::contextMenuItemTagMediaMute):
3475         (WebCore::contextMenuItemTagMediaUnMute):
3476         * platform/brew/LocalizedStringsBrew.cpp:
3477         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3478         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3479         (WebCore::contextMenuItemTagToggleMediaControls):
3480         (WebCore::contextMenuItemTagToggleMediaLoop):
3481         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3482         (WebCore::contextMenuItemTagMediaPlay):
3483         (WebCore::contextMenuItemTagMediaPause):
3484         (WebCore::contextMenuItemTagMediaMute):
3485         (WebCore::contextMenuItemTagMediaUnMute):
3486         * platform/efl/LocalizedStringsEfl.cpp:
3487         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3488         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3489         (WebCore::contextMenuItemTagToggleMediaControls):
3490         (WebCore::contextMenuItemTagToggleMediaLoop):
3491         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3492         (WebCore::contextMenuItemTagMediaPlay):
3493         (WebCore::contextMenuItemTagMediaPause):
3494         (WebCore::contextMenuItemTagMediaMute):
3495         (WebCore::contextMenuItemTagMediaUnMute):
3496         * platform/gtk/ContextMenuItemGtk.cpp:
3497         (WebCore::gtkStockIDFromContextMenuAction):
3498         * platform/gtk/LocalizedStringsGtk.cpp:
3499         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3500         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3501         (WebCore::contextMenuItemTagToggleMediaControls):
3502         (WebCore::contextMenuItemTagToggleMediaLoop):
3503         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3504         (WebCore::contextMenuItemTagMediaPlay):
3505         (WebCore::contextMenuItemTagMediaPause):
3506         (WebCore::contextMenuItemTagMediaMute):
3507         (WebCore::contextMenuItemTagMediaUnMute):
3508         * platform/haiku/LocalizedStringsHaiku.cpp:
3509         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3510         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3511         (WebCore::contextMenuItemTagToggleMediaControls):
3512         (WebCore::contextMenuItemTagToggleMediaLoop):
3513         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3514         (WebCore::contextMenuItemTagMediaPlay):
3515         (WebCore::contextMenuItemTagMediaPause):
3516         (WebCore::contextMenuItemTagMediaMute):
3517         (WebCore::contextMenuItemTagMediaUnMute):
3518         * platform/wx/LocalizedStringsWx.cpp:
3519         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3520         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3521         (WebCore::contextMenuItemTagToggleMediaControls):
3522         (WebCore::contextMenuItemTagToggleMediaLoop):
3523         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3524         (WebCore::contextMenuItemTagMediaPlay):
3525         (WebCore::contextMenuItemTagMediaPause):
3526         (WebCore::contextMenuItemTagMediaMute):
3527         (WebCore::contextMenuItemTagMediaUnMute):
3528         * rendering/HitTestResult.cpp:
3529         (WebCore::HitTestResult::absoluteMediaURL):
3530         (WebCore::HitTestResult::mediaSupportsFullscreen):
3531         (WebCore::HitTestResult::mediaElement):
3532         (WebCore::HitTestResult::toggleMediaControlsDisplay):
3533         (WebCore::HitTestResult::toggleMediaLoopPlayback):
3534         (WebCore::HitTestResult::enterFullscreenForVideo):
3535         (WebCore::HitTestResult::mediaControlsEnabled):
3536         (WebCore::HitTestResult::mediaLoopEnabled):
3537         (WebCore::HitTestResult::mediaPlaying):
3538         (WebCore::HitTestResult::toggleMediaPlayState):
3539         (WebCore::HitTestResult::mediaHasAudio):
3540         (WebCore::HitTestResult::mediaMuted):
3541         (WebCore::HitTestResult::toggleMediaMuteState):
3542         * rendering/HitTestResult.h:
3543
3544 2010-09-16  Tony Gentilcore  <tonyg@chromium.org>
3545
3546         Reviewed by Adam Barth.
3547
3548         Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
3549         https://bugs.webkit.org/show_bug.cgi?id=45833
3550
3551         Test: fast/parser/x-frame-options-detached-document-crash.html
3552
3553         * dom/Document.cpp:
3554         (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
3555
3556 2010-09-16  Vangelis Kokkevis  <vangelis@chromium.org>
3557
3558         Reviewed by Darin Fisher.
3559
3560         [chromium] ImageLayerChromium needs to keep a ref to the Image it uses
3561         so that it never tries to access an already destroyed Image.
3562         https://bugs.webkit.org/show_bug.cgi?id=45869
3563
3564         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3565         (WebCore::GraphicsLayerChromium::setContentsToImage):
3566         * platform/graphics/chromium/ImageLayerChromium.cpp:
3567         (WebCore::ImageLayerChromium::setContents):
3568         (WebCore::ImageLayerChromium::updateContents):
3569         * platform/graphics/chromium/ImageLayerChromium.h:
3570
3571 2010-09-16  Patrick Gansterer  <paroga@paroga.com>
3572
3573         Reviewed by Adam Roben.
3574
3575         [WINCE] Add platform-specific Image methods
3576         https://bugs.webkit.org/show_bug.cgi?id=28272
3577
3578         * platform/graphics/wince/ImageWinCE.cpp: Added.
3579         (WebCore::RGBA32Buffer::asNewNativeImage):
3580         (WebCore::FrameData::clear):
3581         (WebCore::BitmapImage::getHBITMAPOfSize):
3582         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
3583         (WebCore::BitmapImage::draw):
3584         (WebCore::Image::drawPattern):
3585         (WebCore::BitmapImage::drawPattern):
3586         (WebCore::BitmapImage::checkForSolidColor):
3587
3588 2010-09-16  Yury Semikhatsky  <yurys@chromium.org>
3589
3590         Reviewed by Pavel Feldman.
3591
3592         Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
3593         https://bugs.webkit.org/show_bug.cgi?id=45890
3594
3595         * inspector/InspectorController.cpp:
3596         (WebCore::InspectorController::populateScriptObjects):
3597         (WebCore::InspectorController::restoreDebugger):
3598         (WebCore::InspectorController::restoreProfiler):
3599         * inspector/InspectorController.h:
3600
3601 2010-09-16  Satish Sampath  <satish@chromium.org>
3602
3603         Unreviewed, fixing a build break with VS 2008.
3604
3605         Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly.
3606         https://bugs.webkit.org/show_bug.cgi?id=45893
3607
3608         * fileapi/FileWriter.h:
3609
3610 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3611
3612         Reviewed by Martin Robinson.
3613
3614         [GStreamer] XOverlay API changes break the build
3615         https://bugs.webkit.org/show_bug.cgi?id=45810
3616
3617         Cope with the GStreamer XOverlay API change for the upcoming
3618         0.10.31 version.
3619         No new tests, build fix only.
3620
3621         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
3622         (WebCore::GStreamerGWorld::setWindowOverlay):
3623
3624 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
3625
3626         Reviewed by Tor Arne Vestbø.
3627
3628         [Qt] V8 port: Fix debug build
3629
3630         Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds.
3631
3632         * history/PageCache.cpp:
3633         * html/HTMLElement.cpp:
3634         * html/HTMLMediaElement.cpp:
3635         * loader/DocumentLoader.cpp:
3636         * loader/icon/IconDatabase.cpp:
3637         * loader/icon/IconLoader.cpp:
3638         * storage/AbstractDatabase.cpp:
3639         * storage/Database.cpp:
3640         * storage/DatabaseSync.cpp:
3641         * storage/DatabaseTracker.cpp:
3642
3643 2010-09-16  Alexey Proskuryakov  <ap@apple.com>
3644
3645         Reviewed by Adam Barth.
3646
3647         https://bugs.webkit.org/show_bug.cgi?id=45852
3648         Range::selectNode and selectNodeContents misbehave when argument is in another document
3649
3650         Test: fast/dom/Range/select-node-different-document.html
3651
3652         There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in
3653         Firefox.
3654
3655         * dom/Range.cpp:
3656         (WebCore::Range::setDocument):
3657         (WebCore::Range::selectNode):
3658         (WebCore::Range::selectNodeContents):
3659         * dom/Range.h:
3660
3661 2010-09-16  Andrey Kosyakov  <caseq@chromium.org>
3662
3663         Reviewed by Pavel Feldman.
3664
3665         Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
3666         Added support to export HAR to file from Resources panel (conditional on Preferences)
3667         Added support for HARLog (a higher-level aggregate than HAREntry)
3668         https://bugs.webkit.org/show_bug.cgi?id=45663
3669
3670         * English.lproj/localizedStrings.js:
3671         * inspector/front-end/HAREntry.js:
3672         (WebInspector.HAREntry.prototype.build):
3673         (WebInspector.HAREntry.prototype._buildTimings):
3674         (WebInspector.HAREntry._toMilliseconds):
3675         (WebInspector.HARLog):
3676         (WebInspector.HARLog.prototype.build):
3677         (WebInspector.HARLog.prototype._buildPages):
3678         (WebInspector.HARLog.prototype._buildMainResourceTimings):
3679         (WebInspector.HARLog.prototype._convertResource):
3680         * inspector/front-end/ResourcesPanel.js:
3681         (WebInspector.ResourcesPanel):
3682         (WebInspector.ResourcesPanel.prototype.hide):
3683         (WebInspector.ResourcesPanel.prototype._contextMenu):
3684         (WebInspector.ResourcesPanel.prototype._exportAll):
3685         (WebInspector.ResourcesPanel.prototype._exportResource):
3686         * inspector/front-end/Settings.js:
3687         * inspector/front-end/utilities.js:
3688         ():
3689
3690 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3691
3692         Reviewed by Jian Li.
3693
3694         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3695         https://bugs.webkit.org/show_bug.cgi?id=45798
3696
3697         * CMakeLists.txt:
3698         * Configurations/FeatureDefines.xcconfig:
3699         * GNUmakefile.am:
3700         * WebCore.pro:
3701         * dom/EventTarget.cpp:
3702         * dom/EventTarget.h:
3703         * dom/ExceptionCode.h:
3704         * dom/ScriptExecutionContext.cpp:
3705         (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
3706         * dom/ScriptExecutionContext.h:
3707         * fileapi/AsyncFileWriter.h:
3708         * fileapi/FileEntry.cpp:
3709         * fileapi/FileEntry.h:
3710         * fileapi/FileEntry.idl:
3711         * fileapi/FileError.h:
3712         * fileapi/FileError.idl:
3713         * fileapi/FileException.h:
3714         * fileapi/FileException.idl:
3715         * fileapi/FileStreamProxy.cpp:
3716         * fileapi/FileStreamProxy.h:
3717         * fileapi/FileThread.cpp:
3718         * fileapi/FileThread.h:
3719         * fileapi/FileWriter.cpp:
3720         * fileapi/FileWriter.h:
3721         * fileapi/FileWriter.idl:
3722         * fileapi/FileWriterCallback.h:
3723         * fileapi/FileWriterCallback.idl:
3724         * fileapi/FileWriterClient.h:
3725         * page/DOMWindow.idl:
3726         * platform/AsyncFileStream.h:
3727         * platform/FileStream.cpp:
3728         * platform/FileStream.h:
3729         * platform/FileStreamClient.h:
3730
3731 2010-09-16  Marc-Antoine Ruel  <maruel@chromium.org>
3732
3733         Reviewed by Dimitri Glazkov.
3734
3735         Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!.
3736
3737         This is necessary because sources! is processed before sources/. This makes
3738         applying broader pattern in sources/ more difficult since it overrides the files
3739         listed in sources!. Having all them in sources/ permits controlling the ordering
3740         of the regexp, thus the final list of included files.
3741
3742         Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp
3743
3744         https://bugs.webkit.org/show_bug.cgi?id=45823
3745
3746         * WebCore.gyp/WebCore.gyp:
3747         * WebCore.gypi:
3748
3749 2010-09-16  Nat Duca  <nduca@chromium.org>
3750
3751         Reviewed by Darin Fisher.
3752
3753         [chromium] Make compositor obey finish flag
3754         https://bugs.webkit.org/show_bug.cgi?id=45552
3755
3756         The compositor should obey the finish flag on doComposite. This
3757         flag causes the compositor to finish rendering before returning,
3758         which is needed when resizing the window to avoid flashes of green.
3759
3760         * platform/graphics/chromium/LayerRendererChromium.cpp:
3761         (WebCore::LayerRendererChromium::finish):
3762         * platform/graphics/chromium/LayerRendererChromium.h:
3763
3764 2010-09-16  Alejandro G. Castro  <alex@igalia.com>
3765
3766         Reviewed by Xan Lopez.
3767
3768         GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
3769         "activate-slider" style property for scrollbars is gone.
3770
3771         * platform/gtk/PopupMenuGtk.cpp:
3772         (WebCore::PopupMenuGtk::show):
3773         * platform/gtk/gtk2drawing.c:
3774         (moz_gtk_scrollbar_thumb_paint):
3775         (moz_gtk_combo_box_paint):
3776
3777 2010-09-16  Diego Gonzalez  <diegohcg@webkit.org>
3778
3779         Reviewed by Kenneth Rohde Christiansen.
3780
3781         [Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
3782         https://bugs.webkit.org/show_bug.cgi?id=42293
3783
3784         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
3785         (WebCore::MediaPlayerPrivate::commitLoad):
3786
3787 2010-09-16  Ryuan Choi  <ryuan.choi@samsung.com>
3788
3789         Unreviewed build fix for EFL
3790
3791         [EFL] REGRESSION(67567) FontCacheCairo was removed
3792         https://bugs.webkit.org/show_bug.cgi?id=45858
3793
3794         * CMakeListsEfl.txt:
3795
3796 2010-09-16  Yong Li  <yoli@rim.com>
3797
3798         Reviewed by George Staikos.
3799
3800         https://bugs.webkit.org/show_bug.cgi?id=37117
3801
3802         Add platform-independent JPEG/PNG image encoders that
3803         work with big endian RGBA source data.
3804
3805         There's no layout test because this patch does't make
3806         any port start using the encoders.
3807
3808         * platform/image-encoders/JPEGImageEncoder.cpp: Added.
3809         * platform/image-encoders/JPEGImageEncoder.h: Added.
3810         * platform/image-encoders/PNGImageEncoder.cpp: Added.
3811         * platform/image-encoders/PNGImageEncoder.h: Added.
3812
3813 2010-09-15  Jeremy Orlow  <jorlow@chromium.org>
3814
3815         Reviewed by Steve Block.
3816
3817         Allow the embedder to specify the base path for IndexedDB.
3818         https://bugs.webkit.org/show_bug.cgi?id=45815
3819
3820         Existing tests provide coverage. Use the indexedDBPath parameter that's
3821         already on the group settings object. Pass this parameter into the backend
3822         which will use it rather than a hard coded tmp directory location. If
3823         nothing is specified, assume it should be an in-memory temporary database.
3824         (This is useful for bringup and Chromium's incognito mode.)
3825
3826         * storage/IDBFactory.cpp:
3827         (WebCore::IDBFactory::open):
3828         * storage/IDBFactoryBackendImpl.cpp:
3829         (WebCore::openSQLiteDatabase):
3830         (WebCore::createTables):
3831         (WebCore::IDBFactoryBackendImpl::open):
3832         * storage/IDBFactoryBackendImpl.h:
3833         * storage/IDBFactoryBackendInterface.h:
3834
3835 2010-09-16  Yong Li  <yoli@rim.com>
3836
3837         Reviewed by George Staikos.
3838
3839         Fix the bug that GIF image down sampling can miss some lines.
3840         https://bugs.webkit.org/show_bug.cgi?id=45322
3841
3842         Test: fast/images/gif-large-checkerboard.html
3843
3844         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3845         (WebCore::GIFImageDecoder::haveDecodedRow):
3846
3847 2010-09-16  Philippe Normand  <pnormand@igalia.com>
3848
3849         Reviewed by Andreas Kling.
3850
3851         [GStreamer] un-needed header includes in MediaPlayerPrivate
3852         https://bugs.webkit.org/show_bug.cgi?id=45877
3853
3854         Include only the headers we need.
3855         No new tests, #includes cleanup only.
3856
3857         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3858
3859 2010-09-16  Pavel Feldman  <pfeldman@chromium.org>
3860
3861         Reviewed by Yury Semikhatsky.
3862
3863         Web Inspector: console.group(object) does not allow object to be expanded.
3864         https://bugs.webkit.org/show_bug.cgi?id=45806
3865
3866         * inspector/front-end/ConsoleView.js:
3867         (WebInspector.ConsoleGroup.prototype.addMessage):
3868         * inspector/front-end/treeoutline.js:
3869         (TreeElement.treeElementToggled):
3870
3871 2010-09-08  Jeremy Orlow  <jorlow@chromium.org>
3872
3873         Reviewed by Steve Block.
3874
3875         Complete index support for IndexedDB
3876         https://bugs.webkit.org/show_bug.cgi?id=45386
3877
3878         Add the rest of the index related API for IndexedDB.  This
3879         includes cursor suport.  A bunch of code was also refactored
3880         since it is shared between indexes and objectStores.
3881
3882         Tests: storage/indexeddb/index-basics.html
3883                storage/indexeddb/index-cursor.html
3884                + additions to others.
3885
3886         * storage/IDBAny.cpp:
3887         (WebCore::IDBAny::set):
3888         * storage/IDBCursor.cpp:
3889         (WebCore::IDBCursor::value):
3890         * storage/IDBCursorBackendImpl.cpp:
3891         (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
3892         (WebCore::IDBCursorBackendImpl::value):
3893         (WebCore::IDBCursorBackendImpl::update):
3894         (WebCore::IDBCursorBackendImpl::continueFunction):
3895         (WebCore::IDBCursorBackendImpl::remove):
3896         (WebCore::IDBCursorBackendImpl::loadCurrentRow):
3897         (WebCore::IDBCursorBackendImpl::database):
3898         * storage/IDBCursorBackendImpl.h:
3899         (WebCore::IDBCursorBackendImpl::create):
3900         * storage/IDBCursorBackendInterface.h:
3901         * storage/IDBFactoryBackendImpl.cpp:
3902         (WebCore::createTables):
3903         * storage/IDBIndex.cpp:
3904         (WebCore::IDBIndex::openObjectCursor):
3905         (WebCore::IDBIndex::openCursor):
3906         (WebCore::IDBIndex::getObject):
3907         (WebCore::IDBIndex::get):
3908         * storage/IDBIndex.h:
3909         (WebCore::IDBIndex::storeName):
3910         * storage/IDBIndex.idl:
3911         * storage/IDBIndexBackendImpl.cpp:
3912         (WebCore::IDBIndexBackendImpl::storeName):
3913         (WebCore::openCursorInternal):
3914         (WebCore::IDBIndexBackendImpl::openObjectCursor):
3915         (WebCore::IDBIndexBackendImpl::openCursor):
3916         (WebCore::getInternal):
3917         (WebCore::IDBIndexBackendImpl::getObject):
3918         (WebCore::IDBIndexBackendImpl::get):
3919         * storage/IDBIndexBackendImpl.h:
3920         (WebCore::IDBIndexBackendImpl::objectStore):
3921         * storage/IDBIndexBackendInterface.h:
3922         * storage/IDBKey.cpp:
3923         (WebCore::IDBKey::fromQuery):
3924         (WebCore::IDBKey::whereSyntax):
3925         (WebCore::IDBKey::leftCursorWhereFragment):
3926         (WebCore::IDBKey::rightCursorWhereFragment):
3927         * storage/IDBKey.h:
3928         * storage/IDBKeyRange.cpp:
3929         (WebCore::IDBKeyRange::leftWhereClauseComparisonOperator):
3930         (WebCore::IDBKeyRange::rightWhereClauseComparisonOperator):
3931         * storage/IDBKeyRange.h:
3932         * storage/IDBObjectStoreBackendImpl.cpp:
3933         (WebCore::IDBObjectStoreBackendImpl::openCursor):
3934         * storage/IDBRequest.cpp:
3935         (WebCore::IDBRequest::timerFired):
3936
3937 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3938
3939         Fix chromium build.
3940         
3941         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3942
3943 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3944
3945         Reviewed by Adam Roben.
3946
3947         https://bugs.webkit.org/show_bug.cgi?id=44715
3948         maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
3949
3950         Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will
3951         be taken care of in platform code without the need to complicate the GraphicsLayer API.
3952         
3953         RenderLayerCompositor no longer sets the geometry orientation for the root
3954         platform layer; platform-specific code does this instead.
3955         
3956         This fixes flipped layers in WebKit2, since WebKit2 was already flipping
3957         geometry, and then RenderLayerCompositor was doing an additional flip.
3958
3959         * platform/graphics/GraphicsLayer.cpp:
3960         (WebCore::GraphicsLayer::GraphicsLayer):
3961         * platform/graphics/GraphicsLayer.h:
3962         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3963         * platform/graphics/chromium/GraphicsLayerChromium.h:
3964         * platform/graphics/mac/GraphicsLayerCA.h:
3965         * platform/graphics/mac/GraphicsLayerCA.mm:
3966         (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
3967         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
3968         (WebCore::GraphicsLayerCA::defaultContentsOrientation):
3969         * platform/graphics/qt/GraphicsLayerQt.cpp:
3970         (WebCore::GraphicsLayerQtImpl::flushChanges):
3971         * platform/graphics/qt/GraphicsLayerQt.h:
3972         * platform/graphics/win/GraphicsLayerCACF.cpp:
3973         (WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
3974         * platform/graphics/win/GraphicsLayerCACF.h:
3975         * platform/graphics/win/WKCACFLayerRenderer.cpp:
3976         (WebCore::WKCACFLayerRenderer::setRootChildLayer):
3977         * rendering/RenderLayerCompositor.cpp:
3978         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
3979
3980 2010-09-15  Julien Chaffraix  <jchaffraix@codeaurora.org>
3981
3982         Unreviewed.
3983
3984         Reverting my changes as it is breaking several tests on Gtk and Qt.
3985
3986         * css/CSSParser.cpp:
3987         (WebCore::CSSParser::parseColor):
3988         * css/CSSParser.h:
3989         * html/canvas/CanvasRenderingContext2D.cpp:
3990         (WebCore::CanvasRenderingContext2D::setStrokeColor):
3991         (WebCore::CanvasRenderingContext2D::setFillColor):
3992         * html/canvas/CanvasStyle.cpp:
3993         (WebCore::CanvasStyle::createFromString):
3994         * html/canvas/CanvasStyle.h:
3995
3996 2010-09-15  Julien Chaffraix  <jchaffraix@codeaurora.org>
3997
3998         Reviewed by Andreas Kling.
3999
4000         Parse system colors in the HTML5 canvas context.
4001         https://bugs.webkit.org/show_bug.cgi?id=39168
4002
4003         Test: fast/css/test-setting-canvas-color.html
4004
4005         Based on previous work by Jan Erik Hanssen  <jhanssen@codeaurora.org>
4006
4007         * css/CSSParser.cpp:
4008         (WebCore::CSSParser::parseColor): Changed the function to better match our
4009         early return policy. Also we now return false when we don't parse the color.
4010         This is needed for createFromString to fallback to using parseSystemColor.
4011
4012         (WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
4013         the system colors.
4014
4015         * css/CSSParser.h: Added the new parseSystemColor method.
4016
4017         * html/canvas/CanvasRenderingContext2D.cpp:
4018         (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
4019         (WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
4020         * html/canvas/CanvasStyle.cpp:
4021         (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
4022         and fall back to parseSystemColor if it did not work.
4023
4024         * html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
4025
4026 2010-09-14  Erik Arvidsson  <arv@chromium.org>
4027
4028         Reviewed by Darin Adler.
4029
4030         getComputedStyle() returns different values for different zoom levels
4031         https://bugs.webkit.org/show_bug.cgi?id=32230
4032
4033         Test: fast/css/getComputedStyle/computed-style-with-zoom.html
4034
4035         * css/CSSComputedStyleDeclaration.cpp:
4036         (WebCore::zoomAdjustedPixelValue):
4037         (WebCore::zoomAdjustedNumberValue):
4038         (WebCore::valueForReflection):
4039         (WebCore::getPositionOffsetValue):
4040         (WebCore::getBorderRadiusCornerValue):
4041         (WebCore::computedTransform):
4042         (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
4043         (WebCore::CSSComputedStyleDeclaration::valueForShadow):
4044         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4045         * css/CSSComputedStyleDeclaration.h:
4046         * css/SVGCSSComputedStyleDeclaration.cpp:
4047         (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
4048         * rendering/RenderObject.h:
4049         (WebCore::adjustForAbsoluteZoom):
4050         * rendering/style/RenderStyle.h:
4051         (WebCore::adjustForAbsoluteZoom):
4052
4053 2010-09-14  Martin Robinson  <mrobinson@igalia.com>
4054
4055         Reviewed by Xan Lopez.
4056
4057         [GTK] Fully separate Pango and FreeType font backends
4058         https://bugs.webkit.org/show_bug.cgi?id=27442
4059
4060         Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo.
4061         Include the correct file via #ifdef'd includes, like the Chromium port. Also split
4062         FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in
4063         common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this
4064         compilation unit is used only by the FreeType backend. This change is important to
4065         prevent upcoming fixes to the FreeType backend from affecting other backends.
4066
4067         No new tests as functionality has not changed.
4068
4069         * CMakeListsEfl.txt: Update source lists.
4070         * GNUmakefile.am: Update source lists.
4071         * platform/graphics/cairo/FontCacheCairo.cpp: Removed.
4072         * platform/graphics/cairo/FontCacheFreeType.cpp: Added.
4073         (WebCore::FontCache::platformInit):
4074         (WebCore::FontCache::getFontDataForCharacters):
4075         (WebCore::FontCache::getSimilarFontPlatformData):
4076         (WebCore::FontCache::getLastResortFallbackFont):
4077         (WebCore::FontCache::getTraitsInFamily):
4078         (WebCore::isWellKnownFontName):
4079         (WebCore::FontCache::createFontPlatformData):
4080         * platform/graphics/cairo/FontPlatformData.h:
4081         * platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp.
4082         (WebCore::FontPlatformData::FontPlatformData):
4083         (WebCore::FontPlatformData::operator=):
4084         (WebCore::FontPlatformData::init):
4085         (WebCore::FontPlatformData::~FontPlatformData):
4086         (WebCore::FontPlatformData::isFixedPitch):
4087         (WebCore::FontPlatformData::operator==):
4088         (WebCore::FontPlatformData::description):
4089         * platform/graphics/cairo/FontPlatformDataFreeType.h: Added.
4090         (WebCore::FontPlatformData::FontPlatformData):
4091         (WebCore::FontPlatformData::size):
4092         (WebCore::FontPlatformData::setSize):
4093         (WebCore::FontPlatformData::syntheticBold):
4094         (WebCore::FontPlatformData::syntheticOblique):
4095         (WebCore::FontPlatformData::scaledFont):
4096         (WebCore::FontPlatformData::hash):
4097         (WebCore::FontPlatformData::isHashTableDeletedValue):
4098         (WebCore::FontPlatformData::hashTableDeletedFontValue):
4099         * platform/graphics/gtk/FontCachePango.cpp: Added.
4100         (WebCore::FontCache::platformInit):
4101         (WebCore::FontCache::getFontDataForCharacters):
4102         (WebCore::FontCache::getSimilarFontPlatformData):
4103         (WebCore::FontCache::getLastResortFallbackFont):
4104         (WebCore::FontCache::getTraitsInFamily):
4105         (WebCore::FontCache::createFontPlatformData):
4106         * platform/graphics/gtk/FontPlatformDataPango.h: Added.
4107         (WebCore::FontPlatformData::FontPlatformData):
4108         (WebCore::FontPlatformData::size):
4109         (WebCore::FontPlatformData::setSize):
4110         (WebCore::FontPlatformData::syntheticBold):
4111         (WebCore::FontPlatformData::syntheticOblique):
4112         (WebCore::FontPlatformData::scaledFont):
4113         (WebCore::FontPlatformData::hash):
4114         (WebCore::FontPlatformData::isHashTableDeletedValue):
4115         (WebCore::FontPlatformData::hashTableDeletedFontValue):
4116         * platform/graphics/win/FontPlatformDataCairoWin.h: Added.
4117         (WebCore::FontPlatformData::FontPlatformData):
4118         (WebCore::FontPlatformData::hfont):
4119         (WebCore::FontPlatformData::useGDI):
4120         (WebCore::FontPlatformData::fontFace):
4121         (WebCore::FontPlatformData::size):
4122         (WebCore::FontPlatformData::setSize):
4123         (WebCore::FontPlatformData::syntheticBold):
4124         (WebCore::FontPlatformData::syntheticOblique):
4125         (WebCore::FontPlatformData::scaledFont):
4126         (WebCore::FontPlatformData::hash):
4127         (WebCore::FontPlatformData::isHashTableDeletedValue):
4128
4129 2010-09-15  Chris Fleizach  <cfleizach@apple.com>
4130
4131         Reviewed by Simon Fraser.
4132
4133         AX: when text is auto-truncated, accessibility bounds are wrong
4134         https://bugs.webkit.org/show_bug.cgi?id=45793
4135
4136         Allow accessibility to retrieve the absoluteQuads of a text node that
4137         clips to the ellipsis.
4138         
4139         Test: accessibility/ellipsis-text.html
4140
4141         * accessibility/AccessibilityRenderObject.cpp:
4142         (WebCore::AccessibilityRenderObject::boundingBoxRect):
4143         * rendering/RenderText.cpp:
4144         (WebCore::ellipsisRectForBox):
4145             Make a common method to retrieve the ellipsis rect.
4146         (WebCore::RenderText::absoluteQuads):
4147             Default into the absoluteQuads method that allows for ellipsis clipping.
4148         (WebCore::RenderText::selectionRectForRepaint):
4149             Use the common method for retrieving the ellipsis.
4150         * rendering/RenderText.h:
4151
4152 2010-09-15  Ariya Hidayat  <ariya@sencha.com>
4153
4154         [Qt] Improve the speed of blur shadow
4155         https://bugs.webkit.org/show_bug.cgi?id=44222
4156
4157         Rewrite the shadow blur function with loop unrolls and sliding step
4158         unification for both horizontal and vertical directions.
4159         This gives significant performance improvement on most cases.
4160
4161         * platform/graphics/qt/ContextShadow.cpp:
4162         (WebCore::shadowBlur):
4163
4164 2010-09-14  Pavel Feldman  <pfeldman@chromium.org>
4165
4166         Reviewed by Yury Semikhatsky.
4167
4168         (Take 2). Web Inspector: Provide network-based load timing.
4169         Before this change, inspector used timers taken from
4170         within WebCore notifications (that are by definition
4171         synchronous and serialized). As a result, timing was
4172         affected by the routines running on the main thread
4173         (JavaScript and such).
4174         https://bugs.webkit.org/show_bug.cgi?id=45664
4175
4176         * inspector/InspectorController.cpp:
4177         (WebCore::InspectorController::willSendRequest):
4178         (WebCore::InspectorController::didFinishLoading):
4179         (WebCore::InspectorController::didFailLoading):
4180         * inspector/InspectorController.h:
4181         * inspector/InspectorResource.cpp:
4182         (WebCore::InspectorResource::endTiming):
4183         * inspector/InspectorResource.h:
4184         * loader/PingLoader.h:
4185         (WebCore::PingLoader::didFinishLoading):
4186         * loader/ResourceLoadNotifier.cpp:
4187         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
4188         * loader/ResourceLoader.cpp:
4189         (WebCore::ResourceLoader::didFinishLoading):
4190         * loader/ResourceLoader.h:
4191         * loader/appcache/ApplicationCacheGroup.cpp:
4192         (WebCore::ApplicationCacheGroup::didFinishLoading):
4193         * loader/appcache/ApplicationCacheGroup.h:
4194         * loader/icon/IconFetcher.cpp:
4195         (WebCore::IconFetcher::didFinishLoading):
4196         * loader/icon/IconFetcher.h:
4197         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
4198         (Streami