2010-12-07 Patrick Gansterer <paroga@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-12-07  Patrick Gansterer  <paroga@webkit.org>
2
3         Reviewed by Andreas Kling.
4
5         [CMake] Remove WebKitGenerators
6         https://bugs.webkit.org/show_bug.cgi?id=50445
7
8         Move remaining logic into main CMakeLists.txt.
9
10         * CMakeLists.txt:
11
12 2010-12-07  Justin Schuh  <jschuh@chromium.org>
13
14         Reviewed by Nikolas Zimmermann.
15
16         Clear old SVG cursor entry before adding a new one
17         https://bugs.webkit.org/show_bug.cgi?id=50549
18
19         Test: svg/css/cursor-replace.svg
20
21         * css/CSSCursorImageValue.cpp:
22         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
23         * svg/SVGCursorElement.cpp:
24         (WebCore::SVGCursorElement::~SVGCursorElement):
25         (WebCore::SVGCursorElement::removeClient):
26         (WebCore::SVGCursorElement::removeReferencedElement):
27         * svg/SVGCursorElement.h:
28         * svg/SVGElement.cpp:
29         (WebCore::SVGElement::setCursorElement):
30         (WebCore::SVGElement::cursorElementRemoved):
31         (WebCore::SVGElement::setCursorImageValue):
32         (WebCore::SVGElement::cursorImageElementRemoved):
33         * svg/SVGElement.h:
34
35 2010-12-07  Kenichi Ishibashi  <bashi@google.com>
36
37         Reviewed by Kent Tamura.
38
39         Let HTMLObjectElement be a form associated element
40         https://bugs.webkit.org/show_bug.cgi?id=48821
41
42         Introduces FormAssociatedElement class which would be a super class
43         of form assocated elements. Some of member functions and variables of
44         HTMLFormControlElement are migrated into this class.
45         Following the HTML5 spec, HTMLFormControlElement class and
46         HTMLObjectElement class are subclasses of it for now.
47
48         Test: fast/forms/form-collection-elements-order.html
49
50         * Android.mk: Added FormAssociatedElement.cpp
51         * CMakeLists.txt: Ditto.
52         * GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
53         * WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
54         * WebCore.gypi: Added FormAssociatedElement.{cpp,h}
55         * WebCore.pro: Ditto.
56         * WebCore.vcproj/WebCore.vcproj: Ditto.
57         * WebCore.xcodeproj/project.pbxproj: Ditto.
58         * dom/CheckedRadioButtons.h: Fixed class forward declaration order.
59         * dom/Document.cpp:
60         (WebCore::Document::registerFormElementWithFormAttribute): Modified to
61         use FormAssociatedElement instead of HTMLFormControlElement
62         (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto.
63         (WebCore::Document::resetFormElementsOwner):
64         * dom/Document.h: Ditto.
65         * html/DOMFormData.cpp: Ditto.
66         (WebCore::DOMFormData::DOMFormData):
67         * html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp.
68         (WebCore::FormAssociatedElement::FormAssociatedElement):
69         (WebCore::FormAssociatedElement::~FormAssociatedElement):
70         (WebCore::FormAssociatedElement::validity):
71         (WebCore::FormAssociatedElement::insertedIntoTree):
72         (WebCore::FormAssociatedElement::removedFromTree):
73         (WebCore::FormAssociatedElement::removeFromForm):
74         (WebCore::FormAssociatedElement::resetFormOwner):
75         (WebCore::FormAssociatedElement::formAttributeChanged):
76         (WebCore::toHTMLElement):
77         * html/FormAssociatedElement.h: Ditto.
78         (WebCore::FormAssociatedElement::ref):
79         (WebCore::FormAssociatedElement::deref):
80         (WebCore::FormAssociatedElement::formDestroyed):
81         (WebCore::FormAssociatedElement::setForm):
82         * html/HTMLElement.h: Changed the access level of findFormAncestor().
83         * html/HTMLFormCollection.cpp:
84         (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement
85         instead of HTMLFormControlElement.
86         (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
87         (WebCore::HTMLFormCollection::updateNameCache): Ditto.
88         * html/HTMLFormControlElement.cpp: Modified regarding with the change of class
89         hierarchy.
90         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
91         (WebCore::HTMLFormControlElement::~HTMLFormControlElement):
92         (WebCore::HTMLFormControlElement::insertedIntoTree):
93         (WebCore::HTMLFormControlElement::removedFromTree):
94         (WebCore::HTMLFormControlElement::supportsFocus):
95         (WebCore::HTMLFormControlElement::checkValidity):
96         (WebCore::HTMLFormControlElement::virtualForm):
97         (WebCore::HTMLFormControlElement::isDefaultButtonForForm):
98         (WebCore::HTMLFormControlElement::attributeChanged):
99         * html/HTMLFormControlElement.h: Ditto.
100         (WebCore::HTMLFormControlElement::form):
101         (WebCore::HTMLFormControlElement::disabled):
102         (WebCore::HTMLFormControlElement::type):
103         (WebCore::HTMLFormControlElement::refFormAssociatedElement):
104         (WebCore::HTMLFormControlElement::derefFormAssociatedElement):
105         * html/HTMLFormElement.cpp: Modified to use FormAssociatedElement
106         instead of HTMLFormControlElement.
107         (WebCore::HTMLFormElement::submitImplicitly):
108         (WebCore::HTMLFormElement::validateInteractively):
109         (WebCore::HTMLFormElement::submit):
110         (WebCore::HTMLFormElement::reset):
111         (WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
112         (WebCore::HTMLFormElement::formElementIndex):
113         (WebCore::HTMLFormElement::registerFormElement):
114         (WebCore::HTMLFormElement::removeFormElement):
115         (WebCore::HTMLFormElement::defaultButton):
116         (WebCore::HTMLFormElement::checkValidity):
117         (WebCore::HTMLFormElement::collectUnhandledInvalidControls):
118         (WebCore::HTMLFormElement::documentDidBecomeActive):
119         * html/HTMLFormElement.h: Ditto.
120         (WebCore::HTMLFormElement::associatedElements):
121         * html/HTMLInputElement.cpp: Ditto.
122         (WebCore::HTMLInputElement::updateCheckedRadioButtons):
123         * html/HTMLObjectElement.cpp: Modified regarding with the change of class
124         hierarchy.
125         (WebCore::HTMLObjectElement::HTMLObjectElement):
126         (WebCore::HTMLObjectElement::~HTMLObjectElement):
127         (WebCore::HTMLObjectElement::create):
128         (WebCore::HTMLObjectElement::attributeChanged):
129         (WebCore::HTMLObjectElement::insertedIntoTree):
130         (WebCore::HTMLObjectElement::removedFromTree):
131         (WebCore::HTMLObjectElement::appendFormData):
132         (WebCore::HTMLObjectElement::formControlName):
133         * html/HTMLObjectElement.h: Ditto.
134         (WebCore::HTMLObjectElement::form):
135         (WebCore::HTMLObjectElement::isFormControlElement):
136         (WebCore::HTMLObjectElement::isEnumeratable):
137         (WebCore::HTMLObjectElement::refFormAssociatedElement):
138         (WebCore::HTMLObjectElement::derefFormAssociatedElement):
139         * html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
140         * html/ValidationMessage.cpp: Modified to use FormAssociatedElement
141         instead of HTMLFormControlElement.
142         (WebCore::ValidationMessage::ValidationMessage):
143         (WebCore::ValidationMessage::create):
144         * html/ValidationMessage.h: Ditto.
145         * html/ValidityState.cpp: Ditto.
146         (WebCore::ValidityState::validationMessage):
147         (WebCore::ValidityState::setCustomErrorMessage):
148         (WebCore::ValidityState::valueMissing):
149         (WebCore::ValidityState::typeMismatch):
150         (WebCore::ValidityState::patternMismatch):
151         (WebCore::ValidityState::tooLong):
152         (WebCore::ValidityState::rangeUnderflow):
153         (WebCore::ValidityState::rangeOverflow):
154         (WebCore::ValidityState::stepMismatch):
155         * html/ValidityState.h: Ditto.
156         (WebCore::ValidityState::create):
157         (WebCore::ValidityState::ValidityState):
158         * loader/FormSubmission.cpp: Ditto.
159         (WebCore::FormSubmission::create):
160
161 2010-12-06  Pavel Feldman  <pfeldman@chromium.org>
162
163         Not reviewed. Rolling out r72988 for breaking iframes.
164
165         * css/CSSImportRule.cpp:
166         (WebCore::CSSImportRule::insertedIntoParent):
167
168 2010-12-06  Hironori Bono  <hbono@chromium.org>
169
170         Reviewed by David Levin.
171
172         [Chromium] Refactor FontCacheChromiumWin.cpp
173         https://bugs.webkit.org/show_bug.cgi?id=50611
174         
175         This change just moved the helper functions for the WebCore::FontCache class to the beginning of ths file.
176
177         No new tests are added since this is a refactoring.
178
179         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
180         (WebCore::fontDataFromDescriptionAndLogFont): Moved to the beginning of the file.
181         (WebCore::toGDIFontWeight): Moved to the beginning of the file.
182         (WebCore::FillLogFont): Moved to the beginning of the file.
183         (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Moved to the beginning of the file.
184         (WebCore::traitsInFamilyEnumProc): Moved to the beginning of the file.
185         (WebCore::FontCache::platformInit): Moved after the static functions.
186
187 2010-12-06  Alexey Marinichev  <amarinichev@chromium.org>
188
189         Reviewed by Kenneth Russell.
190
191         Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored.
192         https://bugs.webkit.org/show_bug.cgi?id=50364
193
194         No new tests since there is currently no way to force a context lost event.
195
196         * html/canvas/WebGLRenderingContext.cpp:
197         (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
198         (WebCore::WebGLRenderingContext::create):
199         (WebCore::WebGLRenderingContext::WebGLRenderingContext):
200         (WebCore::WebGLRenderingContext::isContextLost):
201         (WebCore::WebGLRenderingContext::loseContext):
202         (WebCore::WebGLRenderingContext::restoreContext):
203         * html/canvas/WebGLRenderingContext.h:
204         (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::WebGLRenderingContextRestoreTimer):
205
206 2010-12-06  David Hyatt  <hyatt@apple.com>
207
208         Reviewed by Simon Fraser.
209
210         https://bugs.webkit.org/show_bug.cgi?id=50593
211         
212         Fix background canvas painting for documents with left/top overflow.  The math from the original RTL patch was incorrect.
213         
214         Just use the RenderView's document dimensions always.
215
216         * rendering/RenderBox.cpp:
217         (WebCore::RenderBox::paintRootBoxDecorations):
218
219 2010-12-06  Simon Fraser  <simon.fraser@apple.com>
220
221         Reviewed by Beth Dakin.
222
223         CSS animation doesn't work for border-radius
224         https://bugs.webkit.org/show_bug.cgi?id=48340
225         
226         Include CSSPropertyBorderRadius in the list of shorthand
227         properties, so that the individual border-radius properties
228         get animated.
229
230         Test: transitions/border-radius-transition.html
231
232         * page/animation/AnimationBase.cpp:
233         (WebCore::addShorthandProperties):
234
235 2010-12-06  Ryosuke Niwa  <rniwa@webkit.org>
236
237         Reviewed by Tony Chang.
238
239         ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration
240         https://bugs.webkit.org/show_bug.cgi?id=49938
241
242         Modified ApplyStyleCommand::ApplyStyleCommand and ApplyStyleCommand::create to take EditingStyle*
243         instead of CSSStyleDeclaration*. Also replaced much of code in Editor::computeAndSetTypingStyle
244         by calls to EditingStyle's member functions and extracted EditingStyle::overrideWith and
245         EditingStyle::extractAndRemoveBlockProperties.
246
247         No new tests are added since this is a refactoring.
248
249         * WebCore.exp.in: Added SelectionController::copyTypingStyle and EditingStyle::~EditingStyle.
250         * css/CSSMutableStyleDeclaration.cpp: Made CSSMutableStyleDeclaration* in the argument list const.
251         (WebCore::CSSMutableStyleDeclaration::merge):
252         * css/CSSMutableStyleDeclaration.h:
253         * editing/ApplyStyleCommand.cpp:
254         (WebCore::ApplyStyleCommand::ApplyStyleCommand): Takes EditingStyle* instead of CSSStyleDeclaration*.
255         (WebCore::ApplyStyleCommand::doApply): Uses EditingStyle.
256         * editing/ApplyStyleCommand.h: m_style is now a ref-pointer to EditingStyle instead of CSSMutableStyleDeclaration.
257         (WebCore::ApplyStyleCommand::create): Takes EditingStyle* instead of CSSStyleDeclaration*.
258         * editing/CompositeEditCommand.cpp:
259         (WebCore::CompositeEditCommand::applyStyle): Ditto.
260         (WebCore::CompositeEditCommand::moveParagraphs): Calls applyStyle.
261         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
262         * editing/CompositeEditCommand.h:
263         * editing/DeleteSelectionCommand.cpp:
264         (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
265         * editing/EditCommand.cpp:
266         * editing/EditCommand.h:
267         * editing/EditingStyle.cpp:
268         (WebCore::EditingStyle::~EditingStyle): Added.
269         (WebCore::EditingStyle::overrideWithStyle): Extracted from Editor::calculateTypingStyleAfterDelete.
270         (WebCore::EditingStyle::copy): Added.
271         (WebCore::EditingStyle::extractAndRemoveBlockProperties): Extracted from Editor::calculateTypingStyleAfterDelete.
272         * editing/EditingStyle.h:
273         * editing/Editor.cpp:
274         (WebCore::Editor::applyStyle): Calls ApplyStyleCommand::create.
275         (WebCore::Editor::applyParagraphStyle): Ditto.
276         (WebCore::Editor::computeAndSetTypingStyle): Ditto.
277         * editing/InsertLineBreakCommand.cpp:
278         (WebCore::InsertLineBreakCommand::doApply): Calls applyStyle.
279         * editing/InsertParagraphSeparatorCommand.cpp:
280         (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
281         * editing/InsertTextCommand.cpp:
282         (WebCore::InsertTextCommand::input): Ditto.
283         * editing/RemoveFormatCommand.cpp:
284         (WebCore::RemoveFormatCommand::doApply): Calls ApplyStyleCommand::create.
285         * editing/ReplaceSelectionCommand.cpp:
286         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Calls applyStyle.
287         * editing/SelectionController.cpp:
288         (WebCore::SelectionController::copyTypingStyle): Moved from SelectionController.h
289         * editing/SelectionController.h:
290
291 2010-12-05  Ryosuke Niwa  <rniwa@webkit.org>
292
293         Reviewed by Tony Chang.
294
295         Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre
296         https://bugs.webkit.org/show_bug.cgi?id=47300
297
298         The bug was caused by FormatBlockCommand::formatRange's not removing refNode when the refNode
299         contains more than one paragraphs even when the refNode is fully selected.
300
301         Fixed the bug by modifying FormatBlockCommand::formatRange to correctly remove the node in
302         such a situation.
303
304         Also fixed a bug in ApplyBlockElementCommand::formatSelection that the end of selection
305         is not properly updated when the end of selection resides in the node split by
306         rangeForParagraphSplittingTextNodesIfNeeded or endOfNextParagrahSplittingTextNodesIfNeeded.
307
308         Test: editing/execCommand/format-block-multiple-paragraphs-in-pre.html
309
310         * editing/ApplyBlockElementCommand.cpp:
311         (WebCore::ApplyBlockElementCommand::formatSelection): Calls formatRange with m_endOfLastParagraph.
312         (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Updates
313         m_endOfLastParagraph when the position points to the node split by this function.
314         (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Ditto.
315         * editing/ApplyBlockElementCommand.h: Added m_endOfLastParagraph as a member variable.
316         * editing/FormatBlockCommand.cpp:
317         (WebCore::FormatBlockCommand::formatRange): See above.
318         * editing/FormatBlockCommand.h:
319         * editing/IndentOutdentCommand.cpp:
320         (WebCore::IndentOutdentCommand::formatRange): Ignores the end of selection.
321         * editing/IndentOutdentCommand.h:
322
323 2010-12-03  Zhenyao Mo  <zmo@google.com>
324
325         Reviewed by Kenneth Russell.
326
327         Postpone gl delete* calls until shaders/programs are no longer attached
328         https://bugs.webkit.org/show_bug.cgi?id=50501
329
330         * html/canvas/WebGLBuffer.cpp:
331         (WebCore::WebGLBuffer::deleteObjectImpl): Simply delete GL resource.
332         * html/canvas/WebGLFramebuffer.cpp:
333         (WebCore::WebGLFramebuffer::deleteObjectImpl): Ditto.
334         * html/canvas/WebGLObject.cpp:
335         (WebCore::WebGLObject::deleteObject): Tracking whether deleteObjectImpl should be called or not.
336         * html/canvas/WebGLObject.h:
337         (WebCore::WebGLObject::detachContext): Set attachmentCount to 0 to ensure OpenGL resource deletion.
338         (WebCore::WebGLObject::onDetached): No need to track attachmentCount here as we track it in deleteObject.
339         (WebCore::WebGLObject::isDeleted): Make this public.
340         * html/canvas/WebGLProgram.cpp:
341         (WebCore::WebGLProgram::deleteObjectImpl): Simply delete GL resource.
342         * html/canvas/WebGLRenderbuffer.cpp:
343         (WebCore::WebGLRenderbuffer::deleteObjectImpl): Ditto.
344         * html/canvas/WebGLRenderingContext.cpp:
345         (WebCore::WebGLRenderingContext::getProgramParameter): intercept DELETE_STATUS.
346         (WebCore::WebGLRenderingContext::getShaderParameter): Ditto.
347         * html/canvas/WebGLShader.cpp:
348         (WebCore::WebGLShader::deleteObjectImpl): Simply delete GL resource.
349         * html/canvas/WebGLTexture.cpp:
350         (WebCore::WebGLTexture::deleteObjectImpl): Simply delete GL resource.
351
352 2010-12-06  Ryosuke Niwa  <rniwa@webkit.org>
353
354         Yet unreviewed another Leopard build fix for r73380.
355
356         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
357         (PlatformCAAnimation::setKeyTimes):
358         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
359         (PlatformCALayer::platformCALayer):
360
361 2010-12-06  Andy Estes  <aestes@apple.com>
362
363         Reviewed by Darin Adler.
364
365         Marquee elements do not stop animating when scrollAmount is set to 0.
366         https://bugs.webkit.org/show_bug.cgi?id=50434
367
368         Test: fast/html/marquee-scrollamount.html
369
370         * rendering/RenderMarquee.cpp:
371         (WebCore::RenderMarquee::timerFired): Allow increment to be 0.
372
373 2010-12-06  Ryosuke Niwa  <rniwa@webkit.org>
374
375         Unreviewed Leopard buildfix for r73380.
376
377         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
378         (PlatformCAAnimation::setTimingFunctions):
379         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
380         (PlatformCALayer::PlatformCALayer):
381
382 2010-12-06  Philippe Normand  <pnormand@igalia.com>
383
384         Reviewed by Martin Robinson.
385
386         [GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer
387         https://bugs.webkit.org/show_bug.cgi?id=44157
388
389         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
390         (webKitWebSrcNeedDataMainCb):
391         (webKitWebSrcEnoughDataMainCb): Replaced platform-specific code
392         with cross-platform ResourceHandle::setDefersLoading calls.
393
394 2010-12-06  Ryosuke Niwa  <rniwa@webkit.org>
395
396         Unreviewed Leopard build fix for r73388.
397
398         * accessibility/AccessibilitySlider.cpp:
399         (WebCore::AccessibilitySlider::maxValueForRange):
400         (WebCore::AccessibilitySlider::minValueForRange):
401
402 2010-12-06  Ryosuke Niwa  <rniwa@webkit.org>
403
404         Unreviewed build fix for Leopard after r73379.
405
406         * platform/graphics/cg/GraphicsContextCG.cpp:
407         (WebCore::GraphicsContext::setAllowsFontSmoothing):
408
409 2010-12-06  Nate Chapin  <japhet@chromium.org>
410
411         Reviewed by Adam Barth.
412
413         Make DocumentWriter a member of DocumentLoader
414         instead of FrameLoader.
415         https://bugs.webkit.org/show_bug.cgi?id=50489
416
417         Refactor, no new tests.
418
419         * bindings/ScriptControllerBase.cpp:
420         (WebCore::ScriptController::executeIfJavaScriptURL):
421         * dom/Document.cpp:
422         (WebCore::Document::Document):
423         (WebCore::Document::close):
424         (WebCore::Document::lastModified):
425         (WebCore::Document::finishedParsing):
426         (WebCore::Document::initSecurityContext):
427         (WebCore::Document::updateURLForPushOrReplaceState):
428         * dom/Document.h:
429         (WebCore::Document::setDocumentLoader):
430         (WebCore::Document::loader):
431         * dom/ProcessingInstruction.cpp:
432         (WebCore::ProcessingInstruction::checkStyleSheet):
433         * dom/ScriptElement.cpp:
434         (WebCore::ScriptElement::scriptCharset):
435         * html/HTMLLinkElement.cpp:
436         (WebCore::HTMLLinkElement::process):
437         * html/MediaDocument.cpp:
438         (WebCore::MediaDocument::replaceMediaElementTimerFired):
439         * html/PluginDocument.cpp:
440         (WebCore::PluginDocumentParser::createDocumentStructure):
441         * loader/DocumentLoader.cpp:
442         (WebCore::DocumentLoader::DocumentLoader):
443         (WebCore::DocumentLoader::finishedLoading):
444         (WebCore::DocumentLoader::commitData):
445         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
446         (WebCore::DocumentLoader::setFrame):
447         * loader/DocumentLoader.h:
448         (WebCore::DocumentLoader::writer):
449         * loader/DocumentWriter.h:
450         (WebCore::DocumentWriter::setFrame):
451         * loader/FrameLoader.cpp:
452         (WebCore::FrameLoader::FrameLoader):
453         (WebCore::FrameLoader::init):
454         (WebCore::FrameLoader::clear):
455         (WebCore::FrameLoader::receivedFirstData):
456         (WebCore::FrameLoader::transitionToCommitted):
457         (WebCore::FrameLoader::open):
458         (WebCore::FrameLoader::finishedLoadingDocument):
459         (WebCore::FrameLoader::addExtraFieldsToRequest):
460         * loader/FrameLoader.h:
461         (WebCore::FrameLoader::notifier):
462         * loader/cache/CachedResourceLoader.cpp:
463         (WebCore::CachedResourceLoader::requestPreload):
464         * platform/network/FormDataBuilder.cpp:
465         (WebCore::FormDataBuilder::encodingFromAcceptCharset):
466         * svg/graphics/SVGImage.cpp:
467         (WebCore::SVGImage::dataChanged):
468
469 2010-12-06  Mark Rowe  <mrowe@apple.com>
470
471         Build fix.
472
473         * WebCore.xcodeproj/project.pbxproj: Don't force WebCore to build against the 10.5 SDK.
474         That's just plain wrong.
475
476 2010-12-06  Chris Fleizach  <cfleizach@apple.com>
477
478         Reviewed by Darin Adler.
479
480         HTML5 Slider does not work correctly with VoiceOver
481         https://bugs.webkit.org/show_bug.cgi?id=50505
482
483         Address a few problems with the Mac implementation for the accessibility slider.
484             1) The value indicator is not hit testable.
485             2) The value indicator does not return an AXValue.
486             3) In the slider, the min/max values are not correct when min/max attributes are not present.
487             4) When you change the value with the keyboard, it doesn't send out the right notification.
488             5) Sliders were returning AXValue and AXTopLevelUIElement attributes twice in their list of attributes.
489  
490         Test: platform/mac/accessibility/html-slider-indicator.html
491
492         * accessibility/AccessibilityObject.cpp:
493         (WebCore::AccessibilityObject::getAttribute):
494             Use fastGetAttribute on Element, instead of getAttribute.
495         * accessibility/AccessibilityObject.h:
496         (WebCore::AccessibilityObject::isInputSlider):
497         * accessibility/AccessibilityRenderObject.cpp:
498         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
499         * accessibility/AccessibilitySlider.cpp:
500         (WebCore::AccessibilitySlider::doAccessibilityHitTest):
501         (WebCore::AccessibilitySlider::maxValueForRange):
502         (WebCore::AccessibilitySlider::minValueForRange):
503         * accessibility/AccessibilitySlider.h:
504         (WebCore::AccessibilitySlider::isInputSlider):
505         * accessibility/mac/AccessibilityObjectWrapper.mm:
506         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
507         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
508         * html/HTMLInputElement.cpp:
509         (WebCore::HTMLInputElement::applyStep):
510
511 2010-12-06  David Hyatt  <hyatt@apple.com>
512
513         Reviewed by Simon Fraser.
514
515         Fix for https://bugs.webkit.org/show_bug.cgi?id=49220 <<rdar://problem/8644849>, REGRESSION: transforms now
516         O(n^3) from pathological behavior in lowestPosition, rightmostPosition, leftmostPosition and topmostPosition.
517
518         This patch throws out the lowest/rightmost/leftmost/topmostPosition functions and re-architects layout overflow
519         in the engine to cache all the information required to properly handle scrolling.
520
521         In the old code, there were two types of overflow: layout overflow and visual overflow.  The former could
522         affect scrolling and the latter could not.  The distinction was largely meaningless, since layout overflow
523         wasn't actually used to determine scroll width or scroll height.  It didn't propagate across self-painting layer
524         boundaries either.  In the old code, the term visible overflow meant the union of the layout overflow and
525         visual overflow rects.
526
527         In the new code, the two types of overflow remain, but the distinction between the two is now clear.  Visual overflow
528         is used purely for painting and hit testing checks and layout overflow is used specifically for scrolling.  It has
529         been expanded to propagate across self-painting layers, to factor in relative positioning and transforms, and to
530         work with writing modes.
531
532         In order to minimize layout test changes, layers no longer incorporate right/bottom overflow into their width/height members.
533         Doing so uncovered two bugs where left/top overflow was ignored (proof that even having layer dimensions is harmful).
534         A render tree dump hack has been put into the code to keep this overflow dumping for the RenderView's layer, since otherwise
535         a huge number of tests would change.
536
537         Added fast/overflow/overflow-rtl-vertical.html to test vertical writing-mode overflow.  Existing tests cover the rest.
538
539         * page/FrameView.cpp:
540         (WebCore::FrameView::adjustViewSize):
541         (WebCore::FrameView::forceLayoutForPagination):
542         Changed to use RenderView's docTop/Left/Width/Height accessors, which simply grab the overflow and properly flip it
543         to account for writing modes.
544
545         * platform/graphics/IntRect.h:
546         (WebCore::IntRect::shiftLeftEdgeTo):
547         (WebCore::IntRect::shiftRightEdgeTo):
548         (WebCore::IntRect::shiftTopEdgeTo):
549         (WebCore::IntRect::shiftBottomEdgeTo):
550         New helper functions for sliding the edge of a rectangle without moving any of the other three edges.
551
552         * rendering/InlineBox.h:
553         (WebCore::InlineBox::frameRect):
554         frameRect is a helper for obtaining the x, y, width, height of an InlineBox as an IntRect.
555
556         * rendering/InlineFlowBox.cpp:
557         (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
558         All of the overflow setting in the inline direction has been removed from this function.  All line overflow is computed
559         at once now in a single function: computeOverflow.
560
561         (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
562         (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
563         (WebCore::InlineFlowBox::addReplacedChildOverflow):
564         Helper for propagating overflow from specific types of children that occur on a line into the InlineFlowBox's overflow.
565
566         (WebCore::InlineFlowBox::computeOverflow):
567         The new function that computes both horizontal and vertical overflow for a line box.
568
569         (WebCore::InlineFlowBox::setLayoutOverflow):
570         (WebCore::InlineFlowBox::setVisualOverflow):
571         (WebCore::InlineFlowBox::setOverflowFromLogicalRects):
572         New functions that set the overflow computed by computeOverflow.  These replace setBlockDirectionOverflowPositions
573         and setInlineDirectionOverflowPositions.  They essentially do the same thing, but they operate on rectangles.
574
575         (WebCore::InlineFlowBox::nodeAtPoint):
576         (WebCore::InlineFlowBox::paint):
577         Changed to use visual overflow instead of visible overflow.  (Visible overflow as a union of layout and visual
578         overflow is no longer necessary, since visual overflow is now equivalent to the old visible overflow concept.)
579
580         * rendering/InlineFlowBox.h:
581         (WebCore::InlineFlowBox::logicalLayoutOverflowRect):
582         (WebCore::InlineFlowBox::logicalVisualOverflowRect):
583         Helpers for obtaining logical overflow rectangles, since lines compute their overflow in logical terms before
584         converting to block coordinates at the end.
585
586         * rendering/RenderBlock.cpp:
587         (WebCore::RenderBlock::layoutBlock):
588         (WebCore::RenderBlock::addOverflowFromChildren):
589         (WebCore::RenderBlock::computeOverflow):
590         (WebCore::RenderBlock::addOverflowFromFloats):
591         (WebCore::RenderBlock::addOverflowFromPositionedObjects):
592         Blocks now have a computeOverflow function called at the end of layout that adds in all the types of overflow.  The addOverflowFromChildren
593         method is virtual so that RenderListItem and RenderTable can subclass it.  RenderListItem has to position its list marker and
594         propagate marker overflow up, and RenderTable adds in overflow from its sections.
595
596         (WebCore::RenderBlock::layoutOnlyPositionedObjects):
597         (WebCore::RenderBlock::layoutPositionedObjects):
598         When only positioned objects lay out, overflow must still be recomputed.  The refactoring of overflow computation into a single
599         callable method: computeOverflow, makes it possible for this to be done easily.
600
601         (WebCore::RenderBlock::paint):
602         visible -> visual.
603
604         (WebCore::RenderBlock::addOverhangingFloats):
605         The propagation of float overflow has changed substantially.  The basic rules are:
606             (1) The float must be in our floating objects list to contribute to overflow.
607             (2) The float must be a descendant to contribute to overflow.
608             (3) The block must have the outermost list that contains the float, or it has a self-painting layer and
609                 so the float needs to be included in its overflow.
610
611         (WebCore::RenderBlock::nodeAtPoint):
612         visible -> visual.
613
614         (WebCore::RenderBlock::layoutColumns):
615         Remove column overflow computation from layoutColumns and move it to computeOverflow.
616
617         (WebCore::RenderBlock::adjustLinePositionForPagination):
618         visible -> visual.
619
620         * rendering/RenderBlock.h:
621         (WebCore::RenderBlock::scrollbarsChanged):
622         Added a new virtual method used by table cells when scrollbars in an overflow:auto/scroll table cell come and go.
623
624         * rendering/RenderBlockLineLayout.cpp:
625         (WebCore::RenderBlock::layoutInlineChildren):
626         (WebCore::RenderBlock::determineStartPosition):
627         (WebCore::RenderBlock::matchedEndLine):
628         (WebCore::RenderBlock::addOverflowFromInlineChildren):
629         (WebCore::RenderBlock::beforeSideVisualOverflowForLine):
630         (WebCore::RenderBlock::afterSideVisualOverflowForLine):
631         visible -> visual.
632
633         * rendering/RenderBox.cpp:
634         (WebCore::RenderBox::scrollWidth):
635         (WebCore::RenderBox::scrollHeight):
636         Patched to use layoutOverflow functions instead of the old rightmost/leftmostPosition functions.
637
638         (WebCore::RenderBox::paintRootBoxDecorations):
639         Use docLeft and docTop here, so that writing modes are handled.
640
641         (WebCore::RenderBox::clippedOverflowRectForRepaint):
642         visible -> visual.
643
644         (WebCore::RenderBox::addOverflowFromChild):
645         (WebCore::RenderBox::addLayoutOverflow):
646         (WebCore::RenderBox::addVisualOverflow):
647         (WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
648         (WebCore::RenderBox::visualOverflowRectForPropagation):
649         (WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
650         (WebCore::RenderBox::layoutOverflowRectForPropagation):
651         * rendering/RenderBox.h:
652         The new overflow system for boxes.  Layout overflow now crosses self-painting layer boundaries and adjusts child boxes
653         for transforms, relative positioning and writing mode differences.
654
655         (WebCore::RenderBox::layoutOverflowRect):
656         (WebCore::RenderBox::topLayoutOverflow):
657         (WebCore::RenderBox::bottomLayoutOverflow):
658         (WebCore::RenderBox::leftLayoutOverflow):
659         (WebCore::RenderBox::rightLayoutOverflow):
660         Changed the default rectangle for layout overflow to be the client box to match the scrollable areas of overflow regions.
661
662         (WebCore::RenderBox::clientLogicalBottom):
663         New helper for obtaining the logical bottom of the client box.
664
665         (WebCore::RenderBox::clientBoxRect):
666         New helper for obtaining the clientLeft/Top/Width/Height box.
667
668         * rendering/RenderBoxModelObject.h:
669         (WebCore::RenderBoxModelObject::relativePositionLogicalOffset):
670         Helper for obtaining the relative position offset transposed for vertical writing modes.  Used by line overflow.
671
672         * rendering/RenderFlexibleBox.cpp:
673         (WebCore::RenderFlexibleBox::layoutBlock):
674         Changed flexible boxes to just call the base class computeOverflow method.
675
676         * rendering/RenderInline.cpp:
677         (WebCore::RenderInline::linesVisualOverflowBoundingBox):
678         (WebCore::RenderInline::clippedOverflowRectForRepaint):
679         visible -> visual.
680
681         * rendering/RenderInline.h:
682         * rendering/RenderLayer.cpp:
683         (WebCore::RenderLayer::updateLayerPosition):
684         Changed layers to no longer incorporate right/bottom overflow into width/height.  This is the reason many layout
685         tests change.  (Not doing this makes the layout test changes far worse, since overflow propagates across self-painting
686         layers now.)
687
688         (WebCore::RenderLayer::overflowTop):
689         (WebCore::RenderLayer::overflowBottom):
690         (WebCore::RenderLayer::overflowLeft):
691         (WebCore::RenderLayer::overflowRight):
692         overflowTop/Bottom/Left/Right return overflow that accounts for writing modes, i.e., purely physical overflow that can be used
693         to set up the scroll area.
694
695         (WebCore::RenderLayer::computeScrollDimensions):
696         Drastically simplified this method now that overflowTop/Bottom/Left/Right just do the right thing regarding unreachable overflow.
697
698         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
699         Make sure to explicitly set the vertical scrollbar's position just as we did with horizontal scrollbars, so that clamping to the
700         bottom works.
701
702         (WebCore::performOverlapTests):
703         (WebCore::RenderLayer::paintLayer):
704         Fix a bug in performOverlapTests.  It incorrectly used the layer's bounds, and so it didn't account for left/top overflow out
705         of the layer (see why I hate layers even having dimensions?).  Changed it to use the bounding box of the layer instead.
706
707         (WebCore::RenderLayer::hitTest):
708         Fix a bug in hit testing.  It incorrectly used the root layer's bounds as the limit of the hit test, and so it didn't account
709         for left/top overflow in a ScrollView (hate hate hate layers having dimensions).  I changed it to use the hit test rect instead,
710         so that the damage rect never stops the point from being tested (unless the hit test request says not to ignore clipping).
711
712         (WebCore::RenderLayer::localBoundingBox):
713         visible -> visual.
714
715         * rendering/RenderLayer.h:
716         Added the new overflowTop/Left/Right/Bottom accessors.
717
718         * rendering/RenderLineBoxList.cpp:
719         (WebCore::RenderLineBoxList::anyLineIntersectsRect):
720         (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
721         (WebCore::RenderLineBoxList::paint):
722         (WebCore::RenderLineBoxList::hitTest):
723         visible -> visual.
724
725         * rendering/RenderListItem.cpp:
726         (WebCore::RenderListItem::addOverflowFromChildren):
727         (WebCore::RenderListItem::positionListMarker):
728         * rendering/RenderListItem.h:
729         RenderListItem now positions the list marker when computing its overflow, since the marker propagates overflow back up to the list item.
730
731         * rendering/RenderListMarker.cpp:
732         (WebCore::RenderListMarker::paint):
733         visible -> visual.
734
735         * rendering/RenderMarquee.cpp:
736         (WebCore::RenderMarquee::computePosition):
737         Changed to use overflow functions instead of rightmost/lowestPosition.
738
739         * rendering/RenderMedia.cpp:
740         * rendering/RenderMedia.h:
741         Removed the lowest/topmost/rightmost/leftmostPosition functions, since control overflow is handled properly already.
742
743         * rendering/RenderOverflow.h:
744         (WebCore::RenderOverflow::RenderOverflow):
745         (WebCore::RenderOverflow::setLayoutOverflow):
746         (WebCore::RenderOverflow::setVisualOverflow):
747         Add new setters for layout and visual overflow as rects.
748
749         * rendering/RenderReplaced.cpp:
750         (WebCore::RenderReplaced::shouldPaint):
751         (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
752         visible -> visual.
753
754         * rendering/RenderRubyRun.cpp:
755         (WebCore::RenderRubyRun::layout):
756         Call computeOverflow to recompute our overflow information after we adjust the ruby.
757
758         * rendering/RenderTable.cpp:
759         (WebCore::RenderTable::layout):
760         (WebCore::RenderTable::addOverflowFromChildren):
761         (WebCore::RenderTable::paint):
762         * rendering/RenderTable.h:
763         Move section overflow propagation into addOverflowFromChildren, and change RenderTable to just call computeOverflow.
764
765         * rendering/RenderTableCell.cpp:
766         (WebCore::RenderTableCell::clippedOverflowRectForRepaint):
767         visible -> visual.
768
769         (WebCore::RenderTableCell::scrollbarsChanged):
770         Adding unreachable overflow support (something that in the old code only existed for positioned objects in the root view) exposed
771         a bug in table layout.  If scrollbars are added during the layout that occurs after intrinsic padding was incorporated into the
772         cell, then the cell won't lay out properly the second time (after the scrollbars have been added).  We have to adjust the intrinsic
773         padding accounting for the presence of the new scrollbar so the second layout will get the right dimensions.
774
775         * rendering/RenderTableCell.h:
776         (WebCore::RenderTableCell::hasVisualOverflow):
777         visible -> visual.
778
779         * rendering/RenderTableSection.cpp:
780         (WebCore::RenderTableSection::layoutRows):
781         * rendering/RenderTableSection.h:
782         visible -> visual.  Removed the leftmost/rightmost/topmost/bottommostPosition functions.
783
784         * rendering/RenderTreeAsText.cpp:
785         (WebCore::writeLayers):
786         Added a hack to render tree dumping to include right/bottom overflow for the root layer only.  This keeps a zillion layout tests
787         from failing.
788
789         * rendering/RenderView.cpp:
790         (WebCore::RenderView::layout):
791         (WebCore::RenderView::docTop):
792         (WebCore::RenderView::docBottom):
793         (WebCore::RenderView::docLeft):
794         (WebCore::RenderView::docRight):
795         * rendering/RenderView.h:
796         (WebCore::RenderView::docHeight):
797         (WebCore::RenderView::docWidth):
798         RenderView now uses docLeft/Top/Height/Width functions, which are just overflow queries that account for writing modes.  These methods
799         are now the preferred way to query for the physical dimensions of a document.
800
801         * rendering/RootInlineBox.cpp:
802         (WebCore::RootInlineBox::addHighlightOverflow):
803         Changed to call setOverflowFromLogicalRects instead of the block/inline position functions.
804
805         (WebCore::RootInlineBox::alignBoxesInBlockDirection):
806         Remove the computation of block direction overflow, since it now all happens at once after the line is built.
807
808         (WebCore::RootInlineBox::paddedLayoutOverflowRect):
809         * rendering/RootInlineBox.h:
810         Added a new helper function for incorporating the end padding into a line.  This end padding also includes the single pixel for a caret
811         in LTR if needed.
812
813 2010-12-06  Chris Marrin  <cmarrin@apple.com>
814
815         Reviewed by Simon Fraser.
816
817         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
818         https://bugs.webkit.org/show_bug.cgi?id=49388
819
820         Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially 
821         identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls 
822         with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA 
823         platform neutral as long as implementations of those two classes are available. 
824         Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got 
825         rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer() 
826         to avoid confusion since both names were used to refer to the same thing. 
827
828         This patch is only for Mac. Windows implementation has not changed.
829
830         * WebCore.xcodeproj/project.pbxproj:
831         * platform/graphics/GraphicsLayer.h:
832         * platform/graphics/ca/GraphicsLayerCA.cpp: Copied from WebCore/platform/graphics/ca/GraphicsLayerCA.cpp.
833         * platform/graphics/ca/GraphicsLayerCA.h: Copied from WebCore/platform/graphics/ca/GraphicsLayerCA.h.
834         * platform/graphics/ca/PlatformCAAnimation.h: Copied from WebCore/platform/graphics/ca/PlatformCAAnimation.h.
835         * platform/graphics/ca/PlatformCALayer.h: Copied from WebCore/platform/graphics/ca/PlatformCALayer.h.
836         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: Copied from WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm.
837         (toCAMediaTimingFunction):
838         * platform/graphics/ca/mac/PlatformCALayerMac.mm: Copied from WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm.
839         (PlatformCALayer::PlatformCALayer):
840         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
841         * platform/graphics/chromium/GraphicsLayerChromium.h:
842         * platform/graphics/mac/GraphicsLayerMac.h: Removed.
843         * platform/graphics/mac/GraphicsLayerMac.mm: Removed.
844         * platform/graphics/mac/WebLayer.h:
845         * platform/graphics/mac/WebLayer.mm:
846         (-[WebLayer setNeedsDisplay]):
847         (-[WebLayer setNeedsDisplayInRect:]):
848         (-[WebLayer display]):
849         (-[WebLayer drawInContext:]):
850         * platform/graphics/mac/WebTiledLayer.h:
851         * platform/graphics/mac/WebTiledLayer.mm:
852         (-[WebTiledLayer setNeedsDisplay]):
853         (-[WebTiledLayer setNeedsDisplayInRect:]):
854         (-[WebTiledLayer display]):
855         (-[WebTiledLayer drawInContext:]):
856         * platform/graphics/qt/GraphicsLayerQt.cpp:
857         (WebCore::GraphicsLayerQtImpl::flushChanges):
858         * platform/graphics/qt/GraphicsLayerQt.h:
859         * platform/graphics/win/GraphicsLayerCACF.cpp:
860         * platform/graphics/win/GraphicsLayerCACF.h:
861
862 2010-12-06  Simon Fraser  <simon.fraser@apple.com>
863
864         Reviewed by Dan Bernstein.
865
866         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
867         https://bugs.webkit.org/show_bug.cgi?id=23364
868
869         Text rendered by Core Graphics over a transparent background looks bad because of 
870         font smoothing, so turn off smoothing when rendering text into compositing layers.
871
872         * platform/graphics/GraphicsContext.h:
873         * platform/graphics/cg/GraphicsContextCG.cpp:
874         (WebCore::GraphicsContext::setAllowsFontSmoothing):
875         * platform/graphics/mac/WebLayer.mm:
876         (drawLayerContents):
877
878 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
879
880         Reviewed by Andreas Kling.
881
882         [WINCE] Add build system
883         https://bugs.webkit.org/show_bug.cgi?id=50522
884
885         * CMakeListsWinCE.txt: Added.
886
887 2010-12-06  Chris Fleizach  <cfleizach@apple.com>
888
889         Reviewed by Oliver Hunt.
890
891         AX does not support HTML5 "required"
892         https://bugs.webkit.org/show_bug.cgi?id=50507
893
894         Test: platform/mac/accessibility/html5-required-attribute.html
895
896         * accessibility/AccessibilityRenderObject.cpp:
897         (WebCore::AccessibilityRenderObject::isRequired):
898
899 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
900
901         Reviewed by Martin Robinson.
902
903         [GTK] using shadows leaks memory
904         https://bugs.webkit.org/show_bug.cgi?id=50541
905
906         Fixed leaks in the shadow code.
907         * platform/graphics/cairo/CairoUtilities.cpp:
908         (WebCore::drawPatternToCairoContext): adoptRef instead of just
909         getting a new reference.
910         * platform/graphics/cairo/GraphicsContextCairo.cpp:
911         (WebCore::drawPathShadow): handle cairo_path_t with smart
912         pointers.
913
914 2010-12-06  Yury Semikhatsky  <yurys@chromium.org>
915
916         Reviewed by Pavel Feldman.
917
918         [v8] Web Inspector: remove duplicate code for capturing stack trace
919         https://bugs.webkit.org/show_bug.cgi?id=50461
920
921         No new tests. Covered with existing inspector tests.
922
923         * bindings/js/ScriptCallStackFactory.cpp:
924         (WebCore::createScriptCallStack):
925         * bindings/js/ScriptCallStackFactory.h:
926         * bindings/v8/ScriptCallStackFactory.cpp:
927         (WebCore::toScriptCallFrame):
928         (WebCore::toScriptCallFramesVector):
929         (WebCore::createScriptCallStack):
930         * bindings/v8/ScriptCallStackFactory.h:
931         * bindings/v8/V8ConsoleMessage.cpp:
932         (WebCore::V8ConsoleMessage::handler):
933         * inspector/ScriptCallFrame.cpp:
934         (WebCore::ScriptCallFrame::ScriptCallFrame):
935         (WebCore::ScriptCallFrame::isEqual):
936         (WebCore::ScriptCallFrame::buildInspectorObject):
937         * inspector/ScriptCallFrame.h:
938         (WebCore::ScriptCallFrame::sourceURL):
939         * inspector/ScriptCallStack.h:
940         * inspector/TimelineRecordFactory.cpp:
941         (WebCore::TimelineRecordFactory::createGenericRecord):
942         * inspector/front-end/ConsoleView.js:
943         (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
944
945 == Rolled over to ChangeLog-2010-12-06 ==