4be18e2667f512ebc0f2f870be207d6ac432f784
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-14  David Carson  <dacarson@gmail.com>
2
3         Reviewed by Maciej.
4
5         Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
6         Removed Mac platform dependance, changed WebCore functions to
7         use PlatformResponse/PlatformData rather than NSURLResponse/
8         NSData. 
9
10         * loader/CachedCSSStyleSheet.cpp:
11         (WebCore::CachedCSSStyleSheet::checkNotify):
12         * loader/CachedImage.cpp:
13         (WebCore::CachedImage::createImage):
14         * loader/CachedResource.cpp:
15         (WebCore::CachedResource::~CachedResource):
16         * loader/CachedResource.h:
17         (WebCore::CachedResource::CachedResource):
18         (WebCore::CachedResource::response):
19         (WebCore::CachedResource::allData):
20         * loader/LoaderFunctions.h:
21         * loader/loader.cpp:
22         (WebCore::Loader::receivedResponse):
23         * loader/mac/LoaderFunctionsMac.mm:
24         (WebCore::ResponseMIMEType):
25         (WebCore::ResponseIsMultipart):
26         (WebCore::CacheObjectExpiresTime):
27         (WebCore::CachedResource::setResponse):
28         (WebCore::CachedResource::setAllData):
29         * platform/qt/TemporaryLinkStubs.cpp:
30         (WebCore::CacheObjectExpiresTime):
31         (WebCore::ResponseIsMultipart):
32         (WebCore::ResponseMIMEType):
33         (WebCore::CachedResource::setResponse):
34         (WebCore::CachedResource::setAllData):
35         * platform/win/TemporaryLinkStubs.cpp:
36         (WebCore::CacheObjectExpiresTime):
37         (WebCore::ResponseIsMultipart):
38         (WebCore::ResponseMIMEType):
39         (WebCore::CachedResource::setResponse):
40         (WebCore::CachedResource::setAllData):
41
42 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
43
44         Reviewed by Maciej.
45
46         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
47         Pure virtual classes require non-pure destructor, who knew.
48
49         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
50         so that other platforms can also use CURL, if they wish.
51
52         Silence compiler warning about unused variable in SharedTimerLinux.cpp
53
54         * platform/ResourceLoaderInternal.h:
55         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
56         * platform/gdk/FrameGdk.h:
57         (WebCore::FrameGdkClient::~FrameGdkClient):
58         * platform/gdk/ResourceLoaderManager.cpp:
59         (WebCore::ResourceLoaderManager::downloadTimerCallback):
60         * platform/gdk/SharedTimerLinux.cpp:
61         (WebCore::stopSharedTimer):
62
63 2006-10-13  Beth Dakin  <bdakin@apple.com>
64
65         Reviewed by Geoff.
66
67         Build fix from my last check-in. Make hasOutlineAnnotation() non-
68         inline so that we don't have to include Document.h in 
69         RenderObject.h
70         Doing so causes a build failure in WebKit, and it probably isn't a 
71         good idea anyway.
72
73         * rendering/RenderObject.cpp:
74         (WebCore::RenderObject::hasOutlineAnnotation):
75         * rendering/RenderObject.h:
76         (WebCore::RenderObject::hasOutline):
77
78 2006-10-13  Beth Dakin  <bdakin@apple.com>
79
80         Patch written mostly by Ken Kraisler, but also by me.
81
82         Reviewed by Hyatt.
83
84         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
85         problem/3391162> PDF created by printing should have live 
86         hyperlinks
87
88         * platform/GraphicsContext.cpp:
89         (WebCore::GraphicsContext::focusRingBoundingRect):
90         * platform/GraphicsContext.h:
91         * platform/cairo/GraphicsContextCairo.cpp:
92         (WebCore::GraphicsContext::setURLForRect):
93         * platform/cg/GraphicsContextCG.cpp:
94         (WebCore::GraphicsContext::setURLForRect): Implement method to add 
95         URL link to PDF document.
96         * rendering/InlineFlowBox.cpp:
97         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
98         querying the outline width
99         * rendering/RenderBlock.cpp:
100         (WebCore::RenderBlock::paintObject): Same as above.
101         * rendering/RenderFlow.cpp:
102         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
103         (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
104         pdf url rects, and outline painting.
105         * rendering/RenderFlow.h:
106         * rendering/RenderObject.cpp:
107         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
108         link to a rectanglular region.
109         (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
110         well as focus ring painting.
111         * rendering/RenderObject.h:
112         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
113         element is a link and we are printing.
114         (WebCore::RenderObject::hasOutline): Returns true is the style has 
115         an outline and hasOutlineAnnotation() is true.
116         * rendering/RenderStyle.h:
117         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
118         greater than 0 and outlineStyle is greater than BHIDDEN.
119
120 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
121
122         Reviewed by ggaren and harrison
123         
124         <rdar://problem/4744008>
125         9A270: Mail crashes when I try to paste large items from Safari
126
127         * editing/ReplaceSelectionCommand.cpp:
128         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
129         Even though we put nodes in the hash map in pre-order, they don't necessary
130         come out of the iterator that way.  If a node is a redundant style span
131         and one of its pruned ancestors comes off the hash map after it, and that
132         ancestor is a redundant style span or font tag, we will try to remove it
133         even though it has already been removed and we'll crash.
134         The test case added with the fix depends on our hash map implementation
135         because it requires that a particular redundant style span come out of 
136         the iterator before its parent. So, it may eventually not provide 
137         coverage for the fix.
138
139 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
140
141         Reviewed by Darin.
142
143         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
144
145         * WebCore.xcodeproj/project.pbxproj:
146         * bindings/js/kjs_window.cpp:
147         (KJS::createNewWindow):
148         (KJS::WindowFunc::callAsFunction):
149         * bridge/BrowserExtension.h:
150         * bridge/mac/BrowserExtensionMac.h:
151         * bridge/mac/BrowserExtensionMac.mm:
152         (WebCore::BrowserExtensionMac::createNewWindow):
153         * bridge/mac/FrameMac.h:
154         * bridge/mac/FrameMac.mm:
155         (WebCore::FrameMac::submitForm):
156         (WebCore::FrameMac::openURLRequest):
157         (WebCore::FrameMac::urlSelected):
158         * bridge/win/BrowserExtensionWin.h:
159         * page/Frame.cpp:
160         (WebCore::Frame::changeLocation):
161         (WebCore::Frame::urlSelected):
162         (WebCore::Frame::requestFrame):
163         (WebCore::Frame::submitForm):
164         * page/Frame.h:
165         * page/FrameLoadRequest.h: Added.
166         (WebCore::FrameLoadRequest::FrameLoadRequest):
167         (WebCore::FrameLoadRequest::lockHistory):
168         (WebCore::FrameLoadRequest::setLockHistory):
169         * page/ResourceRequest.h:
170         (WebCore::ResourceRequest::ResourceRequest):
171
172 2006-10-13  John Sullivan  <sullivan@apple.com>
173
174         Reviewed by Maciej
175
176         * loader/mac/WebFrameLoader.mm:
177         (-[WebFrameLoader loadDocumentLoader:]):
178         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
179         happen when loading a page during a decidePolicyForNavigationAction callback.
180
181 2006-10-13  Dave Hyatt  <hyatt@apple.com>
182
183         Transparency layer work.
184
185         Reviewed by aroben
186
187         * platform/GraphicsContext.h:
188         * platform/cg/GraphicsContextCG.cpp:
189         (WebCore::GraphicsContext::beginTransparencyLayer):
190         (WebCore::GraphicsContext::endTransparencyLayer):
191         * platform/cg/GraphicsContextPlatformPrivate.h:
192         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
193         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
194
195 2006-10-13  Rob Buis  <buis@kde.org>
196
197         Reviewed by Mitz.
198
199         http://bugs.webkit.org/show_bug.cgi?id=11217
200         Cleanup svg coding style
201
202         Cleanup coding style in svg paint server classes.
203
204         * ksvg2/svg/SVGGradientElement.cpp:
205         (WebCore::SVGGradientElement::SVGGradientElement):
206         (WebCore::SVGGradientElement::parseMappedAttribute):
207         (WebCore::SVGGradientElement::notifyAttributeChange):
208         (WebCore::SVGGradientElement::canvasResource):
209         (WebCore::SVGGradientElement::rebuildStops):
210         * ksvg2/svg/SVGGradientElement.h:
211         * ksvg2/svg/SVGLinearGradientElement.cpp:
212         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
213         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
214         (WebCore::SVGLinearGradientElement::buildGradient):
215         * ksvg2/svg/SVGLinearGradientElement.h:
216         * ksvg2/svg/SVGPatternElement.cpp:
217         (WebCore::SVGPatternElement::SVGPatternElement):
218         (WebCore::SVGPatternElement::parseMappedAttribute):
219         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
220         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
221         (WebCore::SVGPatternElement::notifyClientsToRepaint):
222         (WebCore::SVGPatternElement::notifyAttributeChange):
223         (WebCore::SVGPatternElement::canvasResource):
224         (WebCore::SVGPatternElement::getCTM):
225         * ksvg2/svg/SVGPatternElement.h:
226         (WebCore::SVGPatternElement::rendererIsNeeded):
227         * ksvg2/svg/SVGRadialGradientElement.cpp:
228         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
229         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
230         (WebCore::SVGRadialGradientElement::buildGradient):
231         * ksvg2/svg/SVGRadialGradientElement.h:
232         * ksvg2/svg/SVGStopElement.cpp:
233         (WebCore::SVGStopElement::SVGStopElement):
234         (WebCore::SVGStopElement::parseMappedAttribute):
235         * ksvg2/svg/SVGStopElement.h:
236
237 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
238
239         Reviewed by Darin, John.
240
241         - Merged more frame and iframe code
242         - Fixed a bug where iframes returned incorrect values for renderer-dependent 
243         properties during javascript: loads because they didn't have renderers at 
244         load time
245         
246         PLT insists this is a small performance win. Don't believe its lies.
247
248         * bindings/js/kjs_html.cpp:
249         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
250         width and height, for consistency with the rest of the DOM.
251         * dom/ContainerNode.cpp:
252         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
253         queue that gets drained after the render tree is fully constructed. Currently,
254         this is only used for frame loading.
255         (WebCore::ContainerNode::attach):
256         * dom/ContainerNode.h:
257         * html/HTMLFrameElement.cpp:
258         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
259         attach() because loading iframes during attach() causes a crash. 
260         Moved frame loading logic into insertedIntoDocument(). That's a more 
261         logical place for it because  document insertion is what 
262         triggers frame loading. Made frame loading a post-attach callback, instead
263         of an immediate action, to fix the incorrect values bug.
264         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
265         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
266         require this call, once I remove the call from WebKit.
267         (WebCore::HTMLFrameElement::setLocation):
268         (WebCore::HTMLFrameElement::width):
269         (WebCore::HTMLFrameElement::height):
270         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
271         killing of puppies.
272         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
273         (WebCore::HTMLIFrameElement::rendererIsNeeded):
274         (WebCore::HTMLIFrameElement::createRenderer):
275         (WebCore::HTMLIFrameElement::insertedIntoDocument):
276         (WebCore::HTMLIFrameElement::removedFromDocument):
277         (WebCore::HTMLIFrameElement::attach):
278         * page/FrameView.h: Removed unused method.
279
280 2006-10-13  David Harrison  <harrison@apple.com>
281
282         Reviewed by Justin.
283
284         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
285
286         Tests added or changed:
287         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
288         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
289         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
290         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
291         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
292
293         * dom/Text.cpp:
294         (WebCore::Text::splitText):
295         Comment changes.
296         
297         * editing/ApplyStyleCommand.cpp:
298         (WebCore::isUnstyledStyleSpan):
299         Renamed from isEmptyStyleSpan.
300         
301         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
302         Rename emptySpans local to unstyledSpans.
303         
304         (WebCore::dummySpanAncestorForNode):
305         New. To locate Apple style span created when splitting a text node.
306         
307         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
308         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
309         of dummy span's parents, rather than traversing up from start and
310         end locations. Old algorithm would miss empty spans in the bug case.
311         
312         (WebCore::ApplyStyleCommand::applyInlineStyle):
313         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
314         
315         (WebCore::ApplyStyleCommand::removeCSSStyle):
316         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
317         
318         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
319         Comment changes.
320         
321         * editing/ApplyStyleCommand.h:
322         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
323           
324         * editing/ReplaceSelectionCommand.cpp:
325         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
326         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
327         Use !node->hasChildNodes() instead of !node->firstChild().
328         
329         * editing/SplitTextNodeCommand.cpp:
330         (WebCore::SplitTextNodeCommand::doApply):
331         Comment changes.
332         
333         * rendering/RenderTreeAsText.cpp:
334         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
335         (WebCore::operator<<):
336         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
337
338 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
339
340         Reviewed by Eric.
341
342         Fix Qt/Linux build after Adele's popup menu changes.
343
344         * CMakeLists.txt:
345         * platform/qt/FileChooserQt.cpp:
346         (WebCore::FileChooser::disconnectUploadControl):
347         * platform/qt/PopupMenuQt.cpp: Added.
348         (WebCore::PopupMenu::PopupMenu):
349         (WebCore::PopupMenu::~PopupMenu):
350         (WebCore::PopupMenu::clear):
351         (WebCore::PopupMenu::populate):
352         (WebCore::PopupMenu::show):
353         (WebCore::PopupMenu::hide):
354         (WebCore::PopupMenu::addSeparator):
355         (WebCore::PopupMenu::addGroupLabel):
356         (WebCore::PopupMenu::addOption):
357         * platform/qt/RenderPopupMenuQt.cpp: Removed.
358         * platform/qt/RenderPopupMenuQt.h: Removed.
359         * platform/qt/RenderThemeQt.cpp:
360
361 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
362
363         Reviewed by Darin.
364
365         fixed build failure 
366
367         * WebCore.xcodeproj/project.pbxproj:
368         * loader/mac/WebFrameLoader.mm:
369
370 2006-10-13  Darin Adler  <darin@apple.com>
371
372         Reviewed by Adele.
373
374         - converted WebFormState from Objective-C to C++
375
376         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
377
378         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
379         Added UChar.h and FrameLoaderTypes.h.
380
381         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
382
383         * loader/mac/WebFormState.h: Converted class to C++.
384         * loader/mac/WebFormState.mm: Ditto.
385
386         * loader/mac/WebFrameLoader.h:
387         * loader/mac/WebFrameLoader.mm:
388         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
389         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
390         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
391         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
392         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
393         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
394         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
395         (-[WebFrameLoader continueAfterNavigationPolicy:]):
396         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
397         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
398         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
399         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
400         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
401
402 2006-10-13  Adele Peterson  <adele@apple.com>
403
404         Reviewed by Maciej.
405
406         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
407
408         * rendering/RenderListBox.cpp:
409         (WebCore::RenderListBox::paintItemForeground):
410         * rendering/RenderTheme.cpp:
411         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
412         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
413         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
414         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
415         * rendering/RenderThemeMac.h:
416         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
417
418 2006-10-13  Rob Buis  <buis@kde.org>
419
420         Reviewed by Mitz.
421
422         http://bugs.webkit.org/show_bug.cgi?id=11217
423         Cleanup svg coding style
424
425         Cleanup coding style in svg structure classes.
426
427         * ksvg2/svg/SVGDefsElement.cpp:
428         (WebCore::SVGDefsElement::SVGDefsElement):
429         * ksvg2/svg/SVGDefsElement.h:
430         * ksvg2/svg/SVGDescElement.cpp:
431         (WebCore::SVGDescElement::SVGDescElement):
432         * ksvg2/svg/SVGDescElement.h:
433         * ksvg2/svg/SVGDocument.cpp:
434         * ksvg2/svg/SVGDocument.h:
435         * ksvg2/svg/SVGElementInstance.cpp:
436         (WebCore::SVGElementInstance::SVGElementInstance):
437         (WebCore::SVGElementInstance::correspondingElement):
438         (WebCore::SVGElementInstance::correspondingUseElement):
439         (WebCore::SVGElementInstance::parentNode):
440         (WebCore::SVGElementInstance::childNodes):
441         (WebCore::SVGElementInstance::previousSibling):
442         (WebCore::SVGElementInstance::nextSibling):
443         (WebCore::SVGElementInstance::firstChild):
444         (WebCore::SVGElementInstance::lastChild):
445         * ksvg2/svg/SVGElementInstance.h:
446         * ksvg2/svg/SVGElementInstanceList.cpp:
447         * ksvg2/svg/SVGElementInstanceList.h:
448         * ksvg2/svg/SVGGElement.cpp:
449         (WebCore::SVGGElement::SVGGElement):
450         (WebCore::SVGGElement::parseMappedAttribute):
451         (WebCore::SVGDummyElement::SVGDummyElement):
452         * ksvg2/svg/SVGGElement.h:
453         (WebCore::SVGGElement::rendererIsNeeded):
454         * ksvg2/svg/SVGImageElement.cpp:
455         (WebCore::SVGImageElement::createRenderer):
456         * ksvg2/svg/SVGImageElement.h:
457         * ksvg2/svg/SVGSVGElement.cpp:
458         (WebCore::SVGSVGElement::SVGSVGElement):
459         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
460         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
461         (WebCore::SVGSVGElement::currentScale):
462         (WebCore::SVGSVGElement::setCurrentScale):
463         (WebCore::SVGSVGElement::currentTranslate):
464         (WebCore::SVGSVGElement::parseMappedAttribute):
465         (WebCore::SVGSVGElement::suspendRedraw):
466         (WebCore::SVGSVGElement::unsuspendRedraw):
467         (WebCore::SVGSVGElement::unsuspendRedrawAll):
468         (WebCore::SVGSVGElement::forceRedraw):
469         (WebCore::SVGSVGElement::getIntersectionList):
470         (WebCore::SVGSVGElement::getEnclosureList):
471         (WebCore::SVGSVGElement::checkIntersection):
472         (WebCore::SVGSVGElement::checkEnclosure):
473         (WebCore::SVGSVGElement::deselectAll):
474         (WebCore::SVGSVGElement::createSVGLength):
475         (WebCore::SVGSVGElement::createSVGAngle):
476         (WebCore::SVGSVGElement::createSVGMatrix):
477         (WebCore::SVGSVGElement::createSVGTransform):
478         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
479         (WebCore::SVGSVGElement::getCTM):
480         (WebCore::SVGSVGElement::getScreenCTM):
481         (WebCore::SVGSVGElement::setCurrentTime):
482         * ksvg2/svg/SVGSVGElement.h:
483         (WebCore::SVGSVGElement::rendererIsNeeded):
484         * ksvg2/svg/SVGSwitchElement.cpp:
485         (WebCore::SVGSwitchElement::SVGSwitchElement):
486         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
487         * ksvg2/svg/SVGSwitchElement.h:
488         (WebCore::SVGSwitchElement::rendererIsNeeded):
489         * ksvg2/svg/SVGSymbolElement.cpp:
490         (WebCore::SVGSymbolElement::SVGSymbolElement):
491         (WebCore::SVGSymbolElement::parseMappedAttribute):
492         * ksvg2/svg/SVGSymbolElement.h:
493         (WebCore::SVGSymbolElement::shouldAttachChild):
494         * ksvg2/svg/SVGTitleElement.cpp:
495         (WebCore::SVGTitleElement::SVGTitleElement):
496         * ksvg2/svg/SVGTitleElement.h:
497         * ksvg2/svg/SVGUseElement.cpp:
498         (WebCore::SVGUseElement::parseMappedAttribute):
499         (WebCore::SVGUseElement::closeRenderer):
500         * ksvg2/svg/SVGUseElement.h:
501         (WebCore::SVGUseElement::rendererIsNeeded):
502
503 2006-10-12  Adele Peterson  <adele@apple.com>
504
505         Reviewed by Anders.
506
507         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
508           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
509         
510          Test: fast/forms/listbox-width-change.html
511
512         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
513           When the options change, call setNeedsLayoutAndMinMaxRecalc.
514
515 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
516
517         Reviewed by Oliver.
518
519         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
520
521         * WebCore.xcodeproj/project.pbxproj:
522         * bridge/mac/WebCoreFrameBridge.h:
523         * bridge/mac/WebCoreFrameBridge.mm:
524         (stringByCollapsingNonPrintingCharacters):
525         (-[WebCoreFrameBridge setTitle:]):
526         (-[WebCoreFrameBridge didFirstLayout]):
527         (-[WebCoreFrameBridge notifyIconChanged:]):
528         (-[WebCoreFrameBridge originalRequestURL]):
529         (-[WebCoreFrameBridge isLoadTypeReload]):
530         (-[WebCoreFrameBridge frameDetached]):
531         (-[WebCoreFrameBridge tokenizerProcessedData]):
532         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
533         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
534         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
535         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
536         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
537         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
538         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
539         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
540         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
541         (-[WebCoreFrameBridge incomingReferrer]):
542         (-[WebCoreFrameBridge isReloading]):
543         (-[WebCoreFrameBridge handledOnloadEvents]):
544         (-[WebCoreFrameBridge mainResourceURLResponse]):
545         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
546         * loader/mac/LoaderNSURLExtras.h:
547         * loader/mac/LoaderNSURLRequestExtras.h: Added.
548         * loader/mac/LoaderNSURLRequestExtras.m: Added.
549         (isConditionalRequest):
550         (setHTTPReferrer):
551         * loader/mac/WebFrameLoader.mm:
552         * loader/mac/WebSubresourceLoader.mm:
553
554 2006-10-12  Adele Peterson  <adele@apple.com>
555
556         RS by Geoff.
557
558         Renamed menuListIsDetaching to disconnectMenuList, 
559         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
560         These names match similar methods in WebCore a little better.
561
562         * platform/FileChooser.h:
563         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
564         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
565         (WebCore::FileChooser::disconnectUploadControl):
566         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
567         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
568         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
569
570 2006-10-12  Adele Peterson  <adele@apple.com>
571
572         Reviewed by Maciej.
573
574         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
575
576         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
577
578         * bridge/mac/FrameMac.h:
579         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
580         * bridge/mac/WebCoreFrameBridge.h:
581
582         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
583
584 2006-10-12  Adele Peterson  <adele@apple.com>
585
586         Reviewed by Alice.
587
588         - Fix for <rdar://problem/4707372> 
589           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
590
591         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
592         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
593         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
594           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
595
596 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
597
598         Reviewed by Maciej.
599
600         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
601         document.open(); document.write(..); and NO document.close(). On the Qt platform this
602         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
603         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
604
605         Hmpf, this took me nine hours to debug today.
606         Result: Couldn't find the real fix, going for a workaround for now.
607         
608         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
609
610         * platform/qt/FrameQt.cpp:
611         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
612         * platform/qt/FrameQtClient.cpp:
613         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
614
615 2006-10-12  Adam Roben  <aroben@apple.com>
616
617         Reviewed by Adele.
618
619         Move popup menu code out of rendering/ and into platform/.
620         RenderPopupMenu becomes PopupMenu, the
621         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
622         virtual methods go away, RenderTheme gets to stop worrying about popup
623         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
624
625         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
626         * WebCore.xcodeproj/project.pbxproj: Ditto.
627         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
628         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
629         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
630         from RenderMenuList::showPopup/hidePopup.
631         (WebCore::PopupMenu::create): New static creation method to hand back a
632         PassRefPtr<PopupMenu>.
633         (WebCore::PopupMenu::addItems): This platform-independent method should
634         be called by PopupMenu::populate when the platform-specific
635         implementation is ready to receive the menu items. Fixed an ASSERT
636         while I was at it.
637         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
638         need for virtual methods.
639         (WebCore::PopupMenu::wasClicked):
640         (WebCore::PopupMenu::setWasClicked):
641         (WebCore::PopupMenu::popupHandle):
642         * platform/mac/PopupMenuMac.mm: Moved from
643         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
644         (WebCore::PopupMenu::PopupMenu):
645         (WebCore::PopupMenu::~PopupMenu):
646         (WebCore::PopupMenu::clear):
647         (WebCore::PopupMenu::populate):
648         (WebCore::PopupMenu::show):
649         (WebCore::PopupMenu::hide):
650         (WebCore::PopupMenu::addSeparator):
651         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
652         RenderStyle anymore, just pick up the style from our RenderMenuList.
653         (WebCore::PopupMenu::addOption): Ditto.
654         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
655         (PopupMenu::PopupMenu):
656         (PopupMenu::~PopupMenu):
657         (PopupMenu::clear):
658         (PopupMenu::populate):
659         (PopupMenu::show):
660         (PopupMenu::hide):
661         (PopupMenu::addSeparator):
662         (PopupMenu::addGroupLabel):
663         (PopupMenu::addOption):
664         * rendering/RenderMenuList.cpp:
665         (WebCore::RenderMenuList::~RenderMenuList):
666         (WebCore::RenderMenuList::showPopup): Use nice new simple
667         PopupMenu::create to make the popup.
668         (WebCore::RenderMenuList::hidePopup):
669         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
670         RenderPopupMenu*.
671         (WebCore::RenderMenuList::popup):
672         * rendering/RenderPopupMenu.cpp: Removed.
673         * rendering/RenderPopupMenu.h: Removed.
674         * rendering/RenderPopupMenuMac.h: Removed.
675         * rendering/RenderPopupMenuMac.mm: Removed.
676         * rendering/RenderPopupMenuWin.h: Removed.
677         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
678         * rendering/RenderTheme.h: Ditto.
679         * rendering/RenderThemeMac.h: Ditto.
680         * rendering/RenderThemeMac.mm: Ditto.
681         * rendering/RenderThemeWin.cpp: Ditto.
682         * rendering/RenderThemeWin.h: Ditto.
683
684 2006-10-12  Adele Peterson  <adele@apple.com>
685
686         Reviewed by Dave Harrison.
687
688         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
689
690         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
691         Make subtree layouts work for textareas as well as text fields.
692
693 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
694
695         Reviewed by MacDome.
696
697         Finally found a way to remove our begin() trickery in FrameQt.
698         The (probably misnamed) Frame::setEncoding() function automatically
699         calls Frame::receivedFirstData() which calls being on the working
700         url, which has been passed to didOpenUrl(). Took me some hours
701         to figure out that the missing charset logic, forced us to do hacks.
702
703         * platform/ResourceLoader.h:
704         * platform/ResourceLoaderInternal.h:
705         * platform/qt/FrameQt.cpp:
706         (WebCore::FrameQt::tokenizerProcessedData):
707         * platform/qt/FrameQt.h:
708         * platform/qt/FrameQtClient.cpp:
709         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
710         (WebCore::FrameQtClientDefault::openURL):
711         (WebCore::FrameQtClientDefault::submitForm):
712         (WebCore::FrameQtClientDefault::receivedData):
713         (WebCore::FrameQtClientDefault::receivedAllData):
714         * platform/qt/FrameQtClient.h:
715         * platform/qt/ResourceLoaderManager.cpp:
716         (WebCore::ResourceLoaderManager::slotData):
717         (WebCore::ResourceLoaderManager::slotMimetype):
718         (WebCore::ResourceLoaderManager::slotResult):
719         (WebCore::ResourceLoaderManager::remove):
720         * platform/qt/ResourceLoaderQt.cpp:
721         (WebCore::ResourceLoader::retrieveCharset):
722         (WebCore::ResourceLoader::extractCharsetFromHeaders):
723
724 2006-10-12  Adam Roben  <aroben@apple.com>
725
726         Reviewed by Hyatt.
727
728         Bandaid-ing a null-dereference crash until a real fix is made.
729
730         * page/FrameView.cpp:
731         (WebCore::FrameView::windowClipRect):
732
733 2006-10-12  Rob Buis  <buis@kde.org>
734
735         Reviewed by Mitz.
736
737         http://bugs.webkit.org/show_bug.cgi?id=11217
738         Cleanup svg coding style
739
740         Cleanup coding style in svg text classes.
741
742         * ksvg2/svg/SVGTRefElement.cpp:
743         (WebCore::SVGTRefElement::SVGTRefElement):
744         (WebCore::SVGTRefElement::updateReferencedText):
745         (WebCore::SVGTRefElement::parseMappedAttribute):
746         (WebCore::SVGTRefElement::childShouldCreateRenderer):
747         (WebCore::SVGTRefElement::createRenderer):
748         * ksvg2/svg/SVGTRefElement.h:
749         (WebCore::SVGTRefElement::rendererIsNeeded):
750         * ksvg2/svg/SVGTSpanElement.cpp:
751         (WebCore::SVGTSpanElement::SVGTSpanElement):
752         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
753         (WebCore::SVGTSpanElement::createRenderer):
754         * ksvg2/svg/SVGTSpanElement.h:
755         (WebCore::SVGTSpanElement::rendererIsNeeded):
756         * ksvg2/svg/SVGTextContentElement.cpp:
757         (WebCore::SVGTextContentElement::SVGTextContentElement):
758         (WebCore::SVGTextContentElement::parseMappedAttribute):
759         * ksvg2/svg/SVGTextContentElement.h:
760         * ksvg2/svg/SVGTextElement.cpp:
761         (WebCore::SVGTextElement::SVGTextElement):
762         (WebCore::SVGTextElement::localMatrix):
763         (WebCore::SVGTextElement::parseMappedAttribute):
764         (WebCore::SVGTextElement::updateLocalTransform):
765         (WebCore::SVGTextElement::nearestViewportElement):
766         (WebCore::SVGTextElement::farthestViewportElement):
767         (WebCore::SVGTextElement::getScreenCTM):
768         (WebCore::SVGTextElement::getCTM):
769         (WebCore::SVGTextElement::createRenderer):
770         (WebCore::SVGTextElement::childShouldCreateRenderer):
771         * ksvg2/svg/SVGTextElement.h:
772         (WebCore::SVGTextElement::getTransformToElement):
773         (WebCore::SVGTextElement::rendererIsNeeded):
774         * ksvg2/svg/SVGTextPositioningElement.cpp:
775         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
776         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
777         * ksvg2/svg/SVGTextPositioningElement.h:
778
779 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
780
781         Reviewed by Maciej.
782
783         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
784
785         * platform/qt/FrameQt.cpp:
786         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
787         * platform/qt/FrameQtClient.cpp:
788         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
789         * platform/qt/FrameQtClient.h:
790
791 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
792
793         Reviewed by Eric.
794
795         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
796
797         * page/FramePrivate.h: Add m_responseMIMEType
798         * page/ResourceRequest.h: Remove m_responseMIMEType
799         * page/Frame.cpp:
800         (WebCore::Frame::setResponseMIMEType): added
801         (WebCore::Frame::responseMIMEType): added
802         (WebCore::Frame::begin): get MIME type from the right place
803         (WebCore::Frame::write): ditto
804         * page/Frame.h:
805         * bindings/js/kjs_window.cpp:
806         (KJS::createNewWindow): updated to use new Frame methods
807         (KJS::WindowFunc::callAsFunction): ditto
808         * bridge/mac/WebCoreFrameBridge.mm:
809         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
810         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
811         * loader/PluginDocument.cpp:
812         (WebCore::PluginTokenizer::createDocumentStructure): ditto
813
814 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
815
816         Reviewed by Eric.
817         
818         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
819
820         We really need some way to test loadHTMLString since it keeps breaking!
821         
822         * loader/mac/WebFrameLoader.mm:
823         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
824
825 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
826
827         Reviewed by Eric.
828
829         Fix Qt/Linux build.
830
831         * CMakeLists.txt:
832         * platform/qt/FileChooserQt.cpp:
833         (WebCore::FileChooser::create):
834
835 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
836
837         Reviewed by Maciej.
838
839         Update Gdk\Linux build for recent changes, based on Qt code
840
841         * platform/gdk/FrameGdk.cpp:
842         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
843         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
844         (WebCore::FrameGdkClientDefault::setFrame):
845         (WebCore::FrameGdkClientDefault::openURL):
846         (WebCore::FrameGdkClientDefault::submitForm):
847         (WebCore::FrameGdkClientDefault::receivedResponse):
848         (WebCore::FrameGdkClientDefault::receivedData):
849         (WebCore::FrameGdkClientDefault::receivedAllData):
850         (WebCore::FrameGdk::FrameGdk):
851         (WebCore::FrameGdk::openURL):
852         (WebCore::FrameGdk::submitForm):
853         (WebCore::FrameGdk::urlSelected):
854         * platform/gdk/FrameGdk.h:
855         * platform/gdk/TemporaryLinkStubs.cpp:
856         (FrameGdk::createJavaAppletWidget):
857         (FileChooser::create):
858
859 2006-10-12  Dave Hyatt  <hyatt@apple.com>
860
861         Patch to add more clipping retrieval functionality for widgets.
862        
863         Reviewed by mjs
864
865         * page/Frame.h:
866         Remove windowResizerRect.  This is in the wrong place.
867         
868         * page/FrameView.cpp:
869         (WebCore::FrameView::windowClipRect):
870         (WebCore::FrameView::windowClipRectForLayer):
871         Break out windowClipRect into helper functions that can be called separately (to make
872         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
873         layer and get the right clip.
874         
875         * page/FrameView.h:
876         Add the new windowClipRect helper methods.
877         
878         * platform/ScrollBar.h:
879         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
880         clip rects for themselves depending on how they are used.
881         
882         * platform/ScrollView.h:
883         Stub out methods for talking to a double buffer backing store on Win32.
884         
885         * platform/Widget.h:
886         Add the ability to query for invalidation suppression.
887         
888         * rendering/RenderLayer.cpp:
889         (WebCore::RenderLayer::windowClipRect):
890         (WebCore::RenderLayer::paintOverflowControls):
891         (WebCore::RenderLayer::calculateRects):
892         (WebCore::RenderLayer::childrenClipRect):
893         (WebCore::RenderLayer::selfClipRect):
894         * rendering/RenderLayer.h:
895         Enhance layers so that they can return either their foreground or background
896         document clip rects.  Make sure a layer scrollbar can return a proper clip.
897         
898         * rendering/RenderListBox.cpp:
899         (WebCore::RenderListBox::windowClipRect):
900         * rendering/RenderListBox.h:
901         Make sure a list box scrollbar can return a proper clip.
902         
903         * rendering/RenderObject.cpp:
904         (WebCore::RenderObject::enclosingLayer):
905         * rendering/RenderObject.h:
906         Make enclosingLayer const.
907         
908 2006-10-11  Darin Adler  <darin@apple.com>
909
910         Reviewed by John.
911
912         - some changes to prepare for converting more code to C++
913
914         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
915         self-sufficient.
916
917         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
918         Needed since the class is used in this header (for some work I have not landed yet).
919
920         * loader/mac/LoaderNSURLExtras.h:
921         * loader/mac/WebFormDataStream.h:
922         Added extern "C" so this code can be used from C++.
923
924         * loader/mac/LoaderNSURLExtras.m:
925         * loader/mac/WebDataProtocol.mm:
926         * loader/mac/WebDocumentLoader.mm:
927         * loader/mac/WebFormDataStream.m:
928         * loader/mac/WebLoader.mm:
929         * loader/mac/WebMainResourceLoader.mm:
930         * loader/mac/WebNetscapePlugInStreamLoader.mm:
931         * loader/mac/WebPolicyDecider.mm:
932         * loader/mac/WebSubresourceLoader.mm:
933         Added missing includes of config.h.
934
935 2006-10-11  John Sullivan  <sullivan@apple.com>
936         
937         Darin wrote this code; we tested it; I give it the thumbs up.
938         
939         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
940
941         The hash table to look up an element class given a QualifiedName was
942         not working at all.
943
944         * dom/QualifiedName.h:
945         (WebCore::QualifiedName::impl):
946         Added. This new accessor method for impl is needed if we want to use
947         a QualifiedName as a hash table key without doing the kind of specialization
948         we do for String. Maybe later we can do the String thing.
949
950         * bindings/objc/DOM.mm:
951         (WebCore::addElementClass):
952         Use QualifiedName.impl instead of the QualifiedName pointer itself.
953         The QualifiedName pointer is *not* unique so almost nothing would be found
954         in this hash table!
955         (WebCore::elementClass):
956         ditto
957         
958 2006-10-11  Adam Roben  <aroben@apple.com>
959
960         Rubberstamped by Anders.
961
962         Clean up FileChooser::create and Icon::newIconForFile.
963
964         * WebCore.xcodeproj/project.pbxproj:
965         * platform/mac/FileChooserMac.mm:
966         (WebCore::FileChooser::create):
967         * platform/mac/IconMac.mm:
968         (WebCore::Icon::newIconForFile):
969
970 2006-10-11  Oliver Hunt  <oliver@apple.com>
971
972         Reviewed by Adam.
973
974         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
975         Corrects canvas tag to not throw JS exception when drawing
976         zero sized rects, arcs, etc
977
978         * html/CanvasRenderingContext2D.cpp:
979         (WebCore::CanvasRenderingContext2D::arcTo):
980         (WebCore::CanvasRenderingContext2D::arc):
981         (WebCore::CanvasRenderingContext2D::rect):
982         (WebCore::CanvasRenderingContext2D::clearRect):
983         (WebCore::CanvasRenderingContext2D::fillRect):
984         (WebCore::CanvasRenderingContext2D::strokeRect):
985
986 2006-10-11  Rob Buis  <buis@kde.org>
987
988         Reviewed by Mitz.
989
990         http://bugs.webkit.org/show_bug.cgi?id=11221
991         REGRESSION: iExploder crash due to style="cursor: url()"
992
993         Take better care of empty cursor lists.
994
995         Test: fast/css/invalid-cursor-property-crash.html
996
997         * css/cssparser.cpp:
998         (WebCore::CSSParser::parseValue):
999
1000 2006-10-11  Adam Roben  <aroben@apple.com>
1001
1002         Fixing Windows for real this time.
1003
1004         * platform/win/TemporaryLinkStubs.cpp:
1005         (FileChooser::create):
1006
1007 2006-10-11  Adam Roben  <aroben@apple.com>
1008
1009         Fix Windows build.
1010
1011         * platform/win/TemporaryLinkStubs.cpp:
1012         (FileChooser::create):
1013
1014 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
1015
1016         Reviewed by Hyatt.
1017         
1018         http://bugs.webkit.org/show_bug.cgi?id=4377
1019         
1020         Respect css visibility semantics for layers too
1021
1022         * rendering/RenderContainer.cpp:
1023         (WebCore::RenderContainer::removeChildNode):
1024         (WebCore::RenderContainer::appendChildNode):
1025         (WebCore::RenderContainer::insertChildNode):
1026         * rendering/RenderLayer.cpp:
1027         (WebCore::RenderLayer::RenderLayer):
1028         (WebCore::RenderLayer::updateLayerPositions):
1029         (WebCore::RenderLayer::setHasVisibleContent):
1030         (WebCore::RenderLayer::dirtyVisibleContentStatus):
1031         (WebCore::RenderLayer::childVisibilityChanged):
1032         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
1033         (WebCore::RenderLayer::updateVisibilityStatus):
1034         (WebCore::RenderLayer::addChild):
1035         (WebCore::RenderLayer::removeChild):
1036         (WebCore::RenderLayer::updateZOrderLists):
1037         (WebCore::RenderLayer::collectLayers):
1038         * rendering/RenderLayer.h:
1039         (WebCore::RenderLayer::hasVisibleContent):
1040         * rendering/RenderObject.cpp:
1041         (WebCore::RenderObject::setStyle):
1042
1043 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1044
1045         Reviewed by Oliver.
1046
1047         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
1048
1049         * WebCore.xcodeproj/project.pbxproj:
1050         * platform/cf/RetainPtr.h: Added.
1051         (WTF::):
1052         (WTF::RetainPtr::RetainPtr):
1053         (WTF::RetainPtr::~RetainPtr):
1054         (WTF::RetainPtr::get):
1055         (WTF::RetainPtr::operator*):
1056         (WTF::RetainPtr::operator->):
1057         (WTF::RetainPtr::operator!):
1058         (WTF::RetainPtr::operator UnspecifiedBoolType):
1059         (WTF::::operator):
1060         (WTF::::swap):
1061         (WTF::swap):
1062         (WTF::operator==):
1063         (WTF::operator!=):
1064         (WTF::static_pointer_cast):
1065         (WTF::const_pointer_cast):
1066         (WTF::getPtr):
1067         
1068         - use it in WidgetMac so it gets tested in at least one place
1069         
1070         * platform/mac/WidgetMac.mm:
1071         (WebCore::Widget::Widget):
1072         (WebCore::Widget::~Widget):
1073         (WebCore::Widget::setEnabled):
1074         (WebCore::Widget::isEnabled):
1075         (WebCore::Widget::setCursor):
1076         (WebCore::Widget::getView):
1077         (WebCore::Widget::setView):
1078         (WebCore::Widget::getOuterView):
1079
1080 2006-10-10  Brady Eidson  <beidson@apple.com>
1081
1082         Reviewed by Maciej.
1083
1084         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
1085
1086         * bridge/mac/WebCoreFrameBridge.h:
1087         * bridge/mac/WebCoreFrameBridge.mm:
1088         (-[WebCoreFrameBridge initMainFrameWithPage:]):
1089         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
1090         (-[WebCoreFrameBridge dealloc]):
1091         (-[WebCoreFrameBridge close]):
1092         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1093         (-[WebCoreFrameBridge frameLoader]):
1094         * loader/mac/WebFrameLoader.h:
1095         * loader/mac/WebFrameLoader.mm:
1096         (-[WebFrameLoader initWithFrameBridge:]):
1097         (-[WebFrameLoader setFrameLoaderClient:]):
1098
1099 2006-10-10  Adam Roben  <aroben@apple.com>
1100
1101         Reviewed by Oliver.
1102
1103         Make FileChooser ref-counted.
1104
1105         * platform/FileChooser.h:
1106         * platform/mac/FileChooserMac.mm:
1107         (WebCore::FileChooser::create):
1108         * rendering/RenderFileUploadControl.cpp:
1109         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1110         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1111         * rendering/RenderFileUploadControl.h:
1112
1113 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
1114
1115         Reviewed by Tim H.
1116
1117         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
1118         Even More auto-generated Objective-C DOM bindings changes
1119
1120         - Auto-generate DOMSVGPathElement.
1121
1122         - Auto-generate the internal interfaces even for classes that have
1123           custom internal implementations.  Change IDL property from ObjCNoInternal
1124           to ObjCCustomInternalImpl to indicate the change.
1125
1126         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
1127
1128         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
1129           and make DOM binding possible.
1130
1131         - Assorted cleanups.
1132
1133         * DerivedSources.make:
1134         * WebCore.xcodeproj/project.pbxproj:
1135         * bindings/objc/DOM.mm:
1136         (WebCore::addElementClass):
1137         (WebCore::createElementClassMap):
1138         (WebCore::elementClass):
1139         (-[DOMNode description]):
1140         (+[DOMNode _nodeWith:WebCore::]):
1141         (-[DOMNode addEventListener:listener:useCapture:]):
1142         (-[DOMNode removeEventListener:listener:useCapture:]):
1143         (-[DOMElement _NPObject]):
1144         (WebCore::ObjCEventListener::handleEvent):
1145         * bindings/objc/DOMEvents.mm:
1146         (+[DOMEvent _eventWith:WebCore::]):
1147         * bindings/objc/DOMInternal.h:
1148         * bindings/objc/DOMRGBColor.mm:
1149         (-[DOMRGBColor WebCore::]):
1150         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
1151         * bindings/scripts/CodeGeneratorObjC.pm:
1152         * css/CSSRule.idl:
1153         * css/CSSValue.idl:
1154         * css/StyleSheet.idl:
1155         * dom/Event.cpp:
1156         (WebCore::Event::isSVGZoomEvent):
1157         * dom/Event.h:
1158         * dom/Event.idl:
1159         * dom/Node.idl:
1160         * ksvg2/events/SVGZoomEvent.cpp:
1161         (WebCore::SVGZoomEvent::isSVGZoomEvent):
1162         * ksvg2/events/SVGZoomEvent.h:
1163         * ksvg2/svg/SVGAnimatedAngle.idl:
1164         * ksvg2/svg/SVGCircleElement.idl:
1165         * ksvg2/svg/SVGClipPathElement.idl:
1166         * ksvg2/svg/SVGPathElement.idl:
1167         * ksvg2/svg/SVGPathSeg.idl:
1168
1169 2006-10-10  Oliver Hunt  <oliver@apple.com>
1170
1171         rubber stamped by Anders.
1172
1173         More buildbot bustage
1174
1175         * kcanvas/SVGInlineFlowBox.cpp:
1176         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1177
1178 2006-10-10  Oliver Hunt  <oliver@apple.com>
1179
1180         Reviewed by Anders 
1181
1182         Unbreak build bots
1183
1184         * dom/Text.cpp:
1185         * kcanvas/RenderSVGText.cpp:
1186         (WebCore::RenderSVGText::layout):
1187         * kcanvas/SVGInlineFlowBox.cpp:
1188         (WebCore::placePositionedBoxesHorizontally):
1189         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1190
1191 2006-10-10  Oliver Hunt  <oliver@apple.com>
1192
1193         Reviewed by hyatt.
1194
1195         Fixes bugs #6423, #6559, #10380 and #10839 
1196
1197         * WebCore.xcodeproj/project.pbxproj:
1198         * css/svg.css:
1199         * dom/Text.cpp:
1200         (WebCore::Text::createRenderer):
1201         * kcanvas/RenderSVGInline.cpp: Added.
1202         (WebCore::RenderSVGInline::RenderSVGInline):
1203         (WebCore::RenderSVGInline::createInlineBox):
1204         * kcanvas/RenderSVGInline.h: Added.
1205         (WebCore::RenderSVGInline::renderName):
1206         (WebCore::RenderSVGInline::requiresLayer):
1207         * kcanvas/RenderSVGInlineText.cpp: Added.
1208         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
1209         (WebCore::RenderSVGInlineText::absoluteRects):
1210         (WebCore::RenderSVGInlineText::selectionRect):
1211         * kcanvas/RenderSVGInlineText.h: Added.
1212         (WebCore::RenderSVGInlineText::renderName):
1213         (WebCore::RenderSVGInlineText::requiresLayer):
1214         * kcanvas/RenderSVGTSpan.cpp: Added.
1215         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
1216         (WebCore::RenderSVGTSpan::absoluteRects):
1217         * kcanvas/RenderSVGTSpan.h: Added.
1218         (WebCore::RenderSVGTSpan::renderName):
1219         * kcanvas/RenderSVGText.cpp:
1220         (WebCore::RenderSVGText::RenderSVGText):
1221         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
1222         (WebCore::RenderSVGText::layout):
1223         (WebCore::RenderSVGText::createInlineBox):
1224         (WebCore::RenderSVGText::nodeAtPoint):
1225         (WebCore::RenderSVGText::absoluteRects):
1226         (WebCore::RenderSVGText::paint):
1227         (WebCore::RenderSVGText::relativeBBox):
1228         * kcanvas/RenderSVGText.h:
1229         (WebCore::RenderSVGText::renderName):
1230         * kcanvas/SVGInlineFlowBox.cpp: Added.
1231         (WebCore::SVGInlineFlowBox::paint):
1232         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
1233         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
1234         (WebCore::paintSVGInlineFlow):
1235         (WebCore::translateBox):
1236         (WebCore::placePositionedBoxesHorizontally):
1237         (WebCore::placeSVGFlowHorizontally):
1238         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1239         (WebCore::placeSVGFlowVertically):
1240         * kcanvas/SVGInlineFlowBox.h: Added.
1241         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
1242         * kcanvas/SVGRootInlineBox.cpp: Added.
1243         (WebCore::SVGRootInlineBox::paint):
1244         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1245         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
1246         * kcanvas/SVGRootInlineBox.h: Added.
1247         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
1248         * ksvg2/svg/SVGTRefElement.cpp:
1249         (SVGTRefElement::createRenderer):
1250         * ksvg2/svg/SVGTSpanElement.cpp:
1251         (SVGTSpanElement::createRenderer):
1252         * rendering/InlineFlowBox.h:
1253
1254 2006-10-10  Adam Roben  <aroben@apple.com>
1255
1256         Reviewed by Adele.
1257
1258         Improve popup menu behavior.
1259
1260         * html/HTMLSelectElement.cpp:
1261         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
1262         m_lastOnChangeIndex so we know when to fire onChange.
1263         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
1264         specify whether we should fire onChange.
1265         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
1266         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
1267         onChange when using the Enter key to change the selection.
1268         * html/HTMLSelectElement.h:
1269         * rendering/RenderMenuList.cpp:
1270         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
1271         into its own method.
1272         (WebCore::RenderMenuList::setTextFromOption): New method.
1273         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
1274         onChange instead of calling it directly here.
1275         * rendering/RenderMenuList.h:
1276
1277 2006-10-10  Adele Peterson  <adele@apple.com>
1278
1279         Reviewed by Beth. 
1280
1281
1282         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
1283           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
1284
1285         Moved autoscroll code to the Frame class
1286
1287         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
1288         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
1289         (WebCore::FrameMac::FrameMac):
1290         (WebCore::FrameMac::handleMousePressEvent):
1291         (WebCore::FrameMac::eventMayStartDrag):
1292         (WebCore::FrameMac::handleMouseMoveEvent):
1293         (WebCore::FrameMac::mouseDown):
1294
1295         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
1296         Now we scroll our views in WebCore.
1297
1298         * page/Frame.cpp:
1299         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
1300         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
1301         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
1302         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
1303         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
1304         (WebCore::Frame::mouseDownMayStartDrag): Added.
1305         (WebCore::Frame::setMouseDownMayStartDrag): Added.
1306         (WebCore::Frame::autoscrollRenderer): Added
1307         (WebCore::Frame::setAutoscrollRenderer): Added.
1308         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
1309         (WebCore::Frame::autoscrollTimerFired): ditto.
1310         (WebCore::Frame::stopAutoscrollTimer): ditto. 
1311         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
1312
1313         * page/FramePrivate.h:
1314         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
1315
1316         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
1317         (WebCore::FrameView::handleMousePressEvent):
1318         (WebCore::FrameView::handleMouseDoubleClickEvent):
1319         (WebCore::FrameView::handleMouseMoveEvent):
1320         (WebCore::FrameView::handleMouseReleaseEvent):
1321
1322         * rendering/RenderLayer.cpp:
1323         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).  
1324          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
1325
1326         * rendering/RenderListBox.cpp:
1327         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
1328
1329         * rendering/RenderObject.cpp:
1330         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
1331         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
1332
1333 2006-10-10  Darin Adler  <darin@apple.com>
1334
1335         Rubber stamped by Maciej.
1336
1337         - convert many of the loader source files to Objective-C++ to prepare
1338           to convert some of them to C++
1339
1340         * WebCore.xcodeproj/project.pbxproj:
1341         * loader/mac/WebDataProtocol.m: Removed.
1342         * loader/mac/WebDocumentLoader.m: Removed.
1343         * loader/mac/WebFormState.m: Removed.
1344         * loader/mac/WebFrameLoader.m: Removed.
1345         * loader/mac/WebLoader.m: Removed.
1346         * loader/mac/WebMainResourceLoader.m: Removed.
1347         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
1348         * loader/mac/WebPolicyDecider.m: Removed.
1349         * loader/mac/WebSubresourceLoader.m: Removed.
1350         * loader/mac/WebDataProtocol.mm: Added.
1351         * loader/mac/WebDocumentLoader.mm: Added.
1352         * loader/mac/WebFormState.mm: Added.
1353         * loader/mac/WebFrameLoader.mm: Added.
1354         * loader/mac/WebLoader.mm: Added.
1355         * loader/mac/WebMainResourceLoader.mm: Added.
1356         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
1357         * loader/mac/WebPolicyDecider.mm: Added.
1358         * loader/mac/WebSubresourceLoader.mm: Added.
1359
1360 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1361
1362         Reviewed by Mitz.
1363
1364         - fixed REGRESSION (r16960): crash on navigating to site
1365         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
1366         
1367         * loader/mac/WebFrameLoader.m:
1368         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1369         Add back a mistakenly removed retain.
1370
1371 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1372
1373         Not reviewed, build fix.
1374
1375         - fixed release build
1376
1377         * WebCore.xcodeproj/project.pbxproj:
1378
1379 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1380
1381         Rubber stamped by Eric.
1382
1383         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
1384
1385         * WebCore.exp:
1386         * WebCore.xcodeproj/project.pbxproj:
1387         * loader/mac/LoaderNSURLExtras.m: Added.
1388         * loader/mac/WebDataProtocol.m: Added.
1389         * loader/mac/WebDocumentLoader.m: Added.
1390         * loader/mac/WebFormDataStream.m: Added.
1391         * loader/mac/WebFrameLoader.m: Added.
1392         * loader/mac/WebLoader.m: Added.
1393         (-[NSURLProtocol didReceiveResponse:]):
1394         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
1395         * loader/mac/WebMainResourceLoader.m: Added.
1396         (-[WebMainResourceLoader didReceiveResponse:]):
1397         * loader/mac/WebPolicyDecider.m: Added.
1398         * loader/mac/WebSubresourceLoader.h: Added.
1399         * loader/mac/WebSubresourceLoader.m: Added.
1400
1401 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1402
1403         Reviewed by Oliver (sort of?)
1404
1405         - WebCore part of moving down NSURL extras
1406
1407         * WebCore.exp:
1408         * platform/mac/WebCoreSystemInterface.h:
1409         * platform/mac/WebCoreSystemInterface.mm:
1410
1411 2006-10-09  Rob Buis  <buis@kde.org>
1412
1413         Reviewed by Mitz.
1414
1415         http://bugs.webkit.org/show_bug.cgi?id=11217
1416         Cleanup svg coding style
1417
1418         Cleanup coding style in svg animation classes.
1419
1420         * ksvg2/svg/SVGAnimateColorElement.cpp:
1421         (WebCore::SVGAnimateColorElement::handleTimerEvent):
1422         * ksvg2/svg/SVGAnimateElement.cpp:
1423         (WebCore::SVGAnimateElement::SVGAnimateElement):
1424         (WebCore::SVGAnimateElement::handleTimerEvent):
1425         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1426         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
1427         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
1428         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1429         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1430         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
1431         (WebCore::SVGAnimateTransformElement::initialMatrix):
1432         (WebCore::SVGAnimateTransformElement::transformMatrix):
1433         * ksvg2/svg/SVGAnimateTransformElement.h:
1434         * ksvg2/svg/SVGAnimatedPathData.cpp:
1435         * ksvg2/svg/SVGAnimatedPathData.h:
1436         * ksvg2/svg/SVGAnimatedPoints.cpp:
1437         * ksvg2/svg/SVGAnimatedPoints.h:
1438         * ksvg2/svg/SVGAnimationElement.cpp:
1439         (WebCore::SVGAnimationElement::targetElement):
1440
1441 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
1442
1443         Reviewed by Oliver.
1444
1445         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
1446
1447         * bridge/mac/WebCoreFrameBridge.h:
1448         * bridge/mac/WebCoreFrameBridge.mm:
1449         (-[WebCoreFrameBridge isMainFrame]):
1450
1451 2006-10-09  Adam Roben  <aroben@apple.com>
1452
1453         Backing out accidental commit.
1454
1455         * page/Frame.cpp:
1456         (WebCore::Frame::finishedParsing):
1457
1458 2006-10-09  Adam Roben  <aroben@apple.com>
1459
1460         Reviewed by Darin.
1461
1462         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
1463         this could cause recursive calls to the destructor. RefPtr now also
1464         inherits from Noncopyable.
1465
1466         * dom/NodeFilter.h:
1467         * dom/Traversal.h:
1468         * page/DOMWindow.h:
1469         * page/Frame.cpp:
1470         (WebCore::Frame::finishedParsing):
1471         * page/Frame.h:
1472         * page/Plugin.h:
1473         * platform/FontFallbackList.h:
1474         * platform/Icon.h:
1475         * platform/Shared.h:
1476         (WebCore::Shared::Shared):
1477         (WebCore::Shared::ref):
1478         (WebCore::Shared::deref):
1479         (WebCore::Shared::hasOneRef):
1480         (WebCore::Shared::refCount):
1481         * platform/StringImpl.h:
1482
1483 2006-10-09  Oliver Hunt <ohunt@apple.com>
1484
1485         Reviewed by Anders.
1486
1487         Correcting ifdef's
1488
1489         * html/CanvasGradient.cpp:
1490         (WebCore::CanvasGradient::CanvasGradient):
1491         (WebCore::CanvasGradient::~CanvasGradient):
1492         (WebCore::CanvasGradient::addColorStop):
1493         * html/CanvasGradient.h:
1494         * html/CanvasPattern.cpp:
1495         (WebCore::CanvasPattern::CanvasPattern):
1496         (WebCore::CanvasPattern::~CanvasPattern):
1497         * html/CanvasPattern.h:
1498         * html/CanvasRenderingContext2D.cpp:
1499         (WebCore::CanvasRenderingContext2D::fill):
1500         (WebCore::CanvasRenderingContext2D::stroke):
1501         (WebCore::CanvasRenderingContext2D::fillRect):
1502         (WebCore::CanvasRenderingContext2D::setShadow):
1503         (WebCore::CanvasRenderingContext2D::applyShadow):
1504         (WebCore::CanvasRenderingContext2D::drawImage):
1505         (WebCore::CanvasRenderingContext2D::createPattern):
1506         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
1507         (WebCore::CanvasRenderingContext2D::applyFillPattern):
1508         * html/CanvasRenderingContext2D.h:
1509         * html/CanvasStyle.cpp:
1510         (WebCore::CanvasStyle::applyStrokeColor):
1511         (WebCore::CanvasStyle::applyFillColor):
1512         * html/HTMLCanvasElement.cpp:
1513         (WebCore::HTMLCanvasElement::paint):
1514         (WebCore::HTMLCanvasElement::createDrawingContext):
1515         * html/HTMLCanvasElement.h:
1516
1517 2006-10-09  Adam Roben  <aroben@apple.com>
1518
1519         Reviewed by Maciej.
1520
1521         Fix a possible recursive destructor call.
1522
1523         * page/Frame.cpp:
1524         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
1525         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
1526         we're already being destroyed.
1527
1528 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
1529
1530         Reviewed by Tim H.
1531
1532         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
1533         Assorted Objective-C bindings changes
1534
1535         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, 
1536           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, 
1537           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, 
1538           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, 
1539           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, 
1540           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, 
1541           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, 
1542           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, 
1543           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
1544
1545         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
1546           DOMHTMLObjectElement.
1547
1548         - Auto-generate the internal methods for classes with ivars (notably 
1549           DOMNodeIterator and DOMTreeWalker)
1550
1551         - Put more methods in the WebCore namespace and factor out the  
1552           displayString method into DOMInternal.h as done by Darin in his 
1553           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
1554
1555         * DerivedSources.make:
1556         * WebCore.xcodeproj/project.pbxproj:
1557         * bindings/objc/DOM.mm:
1558         (-[DOMNode _initWithNode:WebCore::]):
1559         (+[DOMNode _nodeWith:WebCore::]):
1560         (-[DOMNode addEventListener:listener:useCapture:]):
1561         (-[DOMNode removeEventListener:listener:useCapture:]):
1562         (-[DOMNode dispatchEvent:]):
1563         (-[DOMElement _imageTIFFRepresentation]):
1564         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1565         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1566         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1567         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1568         * bindings/objc/DOMCSS.mm:
1569         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1570         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1571         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
1572         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1573         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
1574         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1575         * bindings/objc/DOMEvents.mm:
1576         (-[DOMEvent _initWithEvent:WebCore::]):
1577         (+[DOMEvent _eventWith:WebCore::]):
1578         * bindings/objc/DOMExtensions.h:
1579         * bindings/objc/DOMHTML.mm:
1580         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1581         * bindings/objc/DOMInternal.h:
1582         (-[DOMNodeFilter WebCore::]):
1583         * bindings/objc/DOMInternal.mm:
1584         (-[WebScriptObject _init]):
1585         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1586         (WebCore::displayString):
1587         * bindings/objc/DOMObject.mm:
1588         (-[DOMObject dealloc]):
1589         (-[DOMObject finalize]):
1590         * bindings/objc/DOMRGBColor.mm:
1591         (-[DOMRGBColor dealloc]):
1592         (-[DOMRGBColor finalize]):
1593         (-[DOMRGBColor color]):
1594         (-[DOMRGBColor _initWithRGB:WebCore::]):
1595         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
1596         * bindings/objc/DOMSVG.h:
1597         * bindings/objc/DOMSVGPathSegInternal.h: Added.
1598         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
1599         (-[DOMSVGPathSeg WebCore::]):
1600         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
1601         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
1602         * bindings/objc/DOMXPath.mm:
1603         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1604         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
1605         * bindings/objc/PublicDOMInterfaces.h:
1606         * bindings/scripts/CodeGeneratorObjC.pm:
1607         * dom/NodeIterator.idl:
1608         * dom/TreeWalker.idl:
1609         * html/HTMLInputElement.idl:
1610         * html/HTMLObjectElement.idl:
1611         * ksvg2/svg/SVGDocument.idl:
1612         * ksvg2/svg/SVGElement.idl:
1613         * ksvg2/svg/SVGPathSeg.idl:
1614         * ksvg2/svg/SVGPathSegArcAbs.idl:
1615         * ksvg2/svg/SVGPathSegArcRel.idl:
1616         * ksvg2/svg/SVGPathSegClosePath.idl:
1617         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
1618         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
1619         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
1620         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
1621         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
1622         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
1623         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
1624         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
1625         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
1626         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
1627         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
1628         * ksvg2/svg/SVGPathSegLinetoRel.idl:
1629         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
1630         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
1631         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
1632         * ksvg2/svg/SVGPathSegMovetoRel.idl:
1633
1634 2006-10-09  Don Gibson  <dgibson77@gmail.com>
1635
1636         Unreviewed build fix.
1637
1638         Fix windows build bustage.
1639
1640         * platform/win/TemporaryLinkStubs.cpp:
1641
1642 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1643
1644         Reviewed by Geoff.
1645
1646         Fix memory leaks discovered via valgrind. Gdk build fixes.
1647
1648         * Projects/gdk/webcore-gdk.bkl:
1649         * make-generated-sources.sh:
1650         * platform/cairo/ImageCairo.cpp:
1651         (WebCore::Image::draw):
1652         * platform/gdk/FrameGdk.cpp:
1653         (WebCore::FrameGdk::handleGdkEvent):
1654         * platform/gdk/FrameGdk.h:
1655         * platform/gdk/PlatformScrollBar.h:
1656         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1657         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1658
1659 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
1660
1661         Reviewed by Beth.
1662
1663         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
1664
1665         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
1666         (WebCore::GlyphMap::fillPage):
1667
1668 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
1669
1670         Unreviewed build fix.
1671
1672         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
1673
1674         * platform/qt/FrameQt.cpp:
1675         (WebCore::FrameQt::createJavaAppletWidget):
1676         * platform/qt/FrameQt.h:
1677         * platform/qt/TemporaryLinkStubs.cpp:
1678
1679 2006-10-09  Brady Eidson  <beidson@apple.com>
1680
1681         Reviewed by Maciej
1682
1683         Tiny changes to help reorganize WebFrameLoader code in WebKit
1684
1685         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
1686         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1687         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
1688
1689 2006-10-09  Adam Roben  <aroben@apple.com>
1690
1691         Reviewed by Adele.
1692
1693         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
1694         already called frome ~FrameMac.
1695
1696         * page/Frame.cpp:
1697         (WebCore::Frame::~Frame):
1698
1699 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1700
1701         * bridge/win/FrameWin.h:
1702         Add function declaration.
1703         
1704 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1705
1706         * platform/win/TemporaryLinkStubs.cpp:
1707         (FrameWin::createJavaAppletWidget):
1708         Try fixing the Win32 build.
1709
1710 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1711
1712         Reviewed by Adam.
1713
1714         Move applet widget creation to Frame and get rid of JavaAppletWidget.
1715         * WebCore.xcodeproj/project.pbxproj:
1716         * bridge/JavaAppletWidget.h: Removed.
1717         * bridge/mac/FrameMac.h:
1718         * bridge/mac/FrameMac.mm:
1719         (WebCore::FrameMac::createJavaAppletWidget):
1720         * bridge/mac/JavaAppletWidget.mm: Removed.
1721         * page/Frame.h:
1722         * rendering/RenderApplet.cpp:
1723         (WebCore::RenderApplet::createWidgetIfNecessary):
1724
1725 2006-10-09  Mitz Pettel  <mitz@webkit.org>
1726
1727         Reviewed by Darin.
1728
1729         - http://bugs.webkit.org/show_bug.cgi?id=11220
1730           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
1731
1732         Subversion does not support resource forks and HFS metadata, so
1733         the resources for this test need to be on a disk image.
1734
1735         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
1736         * manual-tests/resources/plain-text-paste.dmg: Added.
1737         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
1738         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
1739         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
1740         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
1741         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
1742         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
1743         * manual-tests/resources/plain-text-paste/3.gif: Removed.
1744         * manual-tests/resources/plain-text-paste/4.txt: Removed.
1745         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
1746
1747 2006-10-09  Rob Buis  <buis@kde.org>
1748
1749         Reviewed by Darin.
1750
1751         http://bugs.webkit.org/show_bug.cgi?id=11217
1752         Cleanup svg coding style
1753
1754         Cleanup coding style in filter classes.
1755
1756         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1757         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
1758         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
1759         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
1760         * ksvg2/svg/SVGFEBlendElement.cpp:
1761         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
1762         (WebCore::SVGFEBlendElement::parseMappedAttribute):
1763         (WebCore::SVGFEBlendElement::filterEffect):
1764         * ksvg2/svg/SVGFEBlendElement.h:
1765         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1766         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
1767         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
1768         (WebCore::SVGFEColorMatrixElement::filterEffect):
1769         * ksvg2/svg/SVGFEColorMatrixElement.h:
1770         * ksvg2/svg/SVGFECompositeElement.cpp:
1771         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1772         * ksvg2/svg/SVGFECompositeElement.h:
1773         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1774         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
1775         * ksvg2/svg/SVGFEDisplacementMapElement.h:
1776         * ksvg2/svg/SVGFEFloodElement.cpp:
1777         (WebCore::SVGFEFloodElement::filterEffect):
1778         * ksvg2/svg/SVGFEFuncAElement.cpp:
1779         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
1780         * ksvg2/svg/SVGFEFuncBElement.cpp:
1781         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
1782         * ksvg2/svg/SVGFEFuncGElement.cpp:
1783         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
1784         * ksvg2/svg/SVGFEFuncRElement.cpp:
1785         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
1786         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1787         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
1788         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1789         (WebCore::SVGFEGaussianBlurElement::filterEffect):
1790         * ksvg2/svg/SVGFEGaussianBlurElement.h:
1791         * ksvg2/svg/SVGFELightElement.cpp:
1792         (WebCore::SVGFELightElement::SVGFELightElement):
1793         (WebCore::SVGFELightElement::parseMappedAttribute):
1794         * ksvg2/svg/SVGFELightElement.h:
1795         * ksvg2/svg/SVGFEMergeElement.cpp:
1796         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
1797
1798 2006-10-09  Rob Buis  <buis@kde.org>
1799
1800         Reviewed by olliej.
1801
1802         http://bugs.webkit.org/show_bug.cgi?id=11217
1803         Cleanup svg coding style
1804
1805         Cleanup coding style in SVGPath* classes.
1806
1807         * ksvg2/svg/SVGPathElement.cpp:
1808         (WebCore::SVGPathElement::SVGPathElement):
1809         (WebCore::SVGPathElement::getPointAtLength):
1810         (WebCore::SVGPathElement::createSVGPathSegClosePath):
1811         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
1812         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
1813         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
1814         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
1815         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
1816         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
1817         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
1818         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
1819         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
1820         (WebCore::SVGPathElement::createSVGPathSegArcRel):
1821         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
1822         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
1823         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
1824         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
1825         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
1826         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
1827         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
1828         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
1829         (WebCore::SVGPathElement::svgMoveTo):
1830         (WebCore::SVGPathElement::svgLineTo):
1831         (WebCore::SVGPathElement::svgLineToHorizontal):
1832         (WebCore::SVGPathElement::svgLineToVertical):
1833         (WebCore::SVGPathElement::svgCurveToCubic):
1834         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
1835         (WebCore::SVGPathElement::svgCurveToQuadratic):
1836         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
1837         (WebCore::SVGPathElement::svgArcTo):
1838         (WebCore::SVGPathElement::parseMappedAttribute):
1839         (WebCore::SVGPathElement::pathSegList):
1840         (WebCore::SVGPathElement::normalizedPathSegList):
1841         (WebCore::SVGPathElement::animatedPathSegList):
1842         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
1843         (WebCore::SVGPathElement::toPathData):
1844         * ksvg2/svg/SVGPathElement.h:
1845         (WebCore::SVGPathElement::rendererIsNeeded):
1846         * ksvg2/svg/SVGPathSeg.h:
1847         * ksvg2/svg/SVGPathSegArc.cpp:
1848
1849 2006-10-09  Rob Buis  <buis@kde.org>
1850
1851         Reviewed by aroben.
1852
1853         http://bugs.webkit.org/show_bug.cgi?id=11217
1854         Cleanup svg coding style
1855
1856         Cleanup coding style in svg shape classes.
1857
1858         * ksvg2/svg/SVGCircleElement.cpp:
1859         (WebCore::SVGCircleElement::SVGCircleElement):
1860         (WebCore::SVGCircleElement::parseMappedAttribute):
1861         (WebCore::SVGCircleElement::pushAttributeContext):
1862         * ksvg2/svg/SVGCircleElement.h:
1863         (WebCore::SVGCircleElement::rendererIsNeeded):
1864         * ksvg2/svg/SVGEllipseElement.cpp:
1865         * ksvg2/svg/SVGEllipseElement.h:
1866         (WebCore::SVGEllipseElement::rendererIsNeeded):
1867         * ksvg2/svg/SVGLineElement.cpp:
1868         (WebCore::SVGLineElement::parseMappedAttribute):
1869         (WebCore::SVGLineElement::pushAttributeContext):
1870         * ksvg2/svg/SVGLineElement.h:
1871         (WebCore::SVGLineElement::rendererIsNeeded):
1872         * ksvg2/svg/SVGPolyElement.cpp:
1873         (WebCore::SVGPolyElement::SVGPolyElement):
1874         (WebCore::SVGPolyElement::points):
1875         (WebCore::SVGPolyElement::animatedPoints):
1876         (WebCore::SVGPolyElement::parseMappedAttribute):
1877         (WebCore::SVGPolyElement::notifyAttributeChange):
1878         * ksvg2/svg/SVGPolyElement.h:
1879         (WebCore::SVGPolyElement::rendererIsNeeded):
1880         * ksvg2/svg/SVGPolygonElement.cpp:
1881         (WebCore::SVGPolygonElement::SVGPolygonElement):
1882         (WebCore::SVGPolygonElement::toPathData):
1883         * ksvg2/svg/SVGPolygonElement.h:
1884         * ksvg2/svg/SVGPolylineElement.cpp:
1885         (WebCore::SVGPolylineElement::SVGPolylineElement):
1886         (WebCore::SVGPolylineElement::toPathData):
1887         * ksvg2/svg/SVGPolylineElement.h:
1888         * ksvg2/svg/SVGRectElement.cpp:
1889         (WebCore::SVGRectElement::parseMappedAttribute):
1890         (WebCore::SVGRectElement::pushAttributeContext):
1891         * ksvg2/svg/SVGRectElement.h:
1892         (WebCore::SVGRectElement::rendererIsNeeded):
1893
1894 2006-10-08  Darin Adler  <darin@apple.com>
1895
1896         Reviewed by Maciej.
1897
1898         - added a bit more WebCoreSystemInterface
1899
1900             wkGetNSURLResponseCalculatedExpiration
1901             wkGetNSURLResponseLastModifiedDate
1902             wkGetNSURLResponseMustRevalidate
1903
1904         * WebCore.exp: Added the new symbols.
1905         * platform/mac/WebCoreSystemInterface.h: Ditto.
1906         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1907
1908         - quiet down the code generation script
1909
1910         * bindings/scripts/CodeGenerator.pm:
1911
1912 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1913
1914         Reviewed by Darin.
1915
1916         - more code laundering - add wkSupportsMultipartXMixedReplace
1917
1918         * WebCore.exp:
1919         * platform/mac/WebCoreSystemInterface.h:
1920         * platform/mac/WebCoreSystemInterface.mm:
1921
1922 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1923
1924         Reviewed by Darin and Oliver.
1925
1926         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
1927
1928         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
1929         (WebCore::GraphicsContext::drawConvexPolygon):
1930
1931 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1932
1933         Reviewed by Darin.
1934
1935         * page/Frame.cpp:
1936         (WebCore::Frame::submitForm):
1937         No need to use latin1() here.
1938
1939 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1940
1941         Reviewed by Darin.
1942
1943         Kill warnings when generating IDL files on Qt/Linux, as the
1944         SOURCE_ROOT environment variable is not defined (and not needed) for us.
1945
1946         * bindings/scripts/CodeGenerator.pm:
1947
1948 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1949
1950         Reviewed by Darin.
1951
1952         - split didNotOpenURL: into general and page-cache-specific parts
1953
1954         * bridge/mac/WebCoreFrameBridge.h:
1955         * bridge/mac/WebCoreFrameBridge.mm:
1956         (-[WebCoreFrameBridge didNotOpenURL:]):
1957         (-[WebCoreFrameBridge invalidatePageCache:]):
1958
1959 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1960
1961         Reviewed by Darin.
1962
1963         * loader/loader.cpp:
1964         Remove DeprecatedStringList.h include.
1965         
1966         * page/Frame.cpp:
1967         (WebCore::Frame::submitForm):
1968         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
1969
1970 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
1971
1972         Reviewed by Darin.
1973
1974         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
1975         Yet another round of Objective-C SVG DOM bindings auto-generation
1976
1977         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, 
1978           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
1979           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, 
1980           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, 
1981           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, 
1982           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, 
1983           DOMSVGZoomAndPan and DOMSVGZoomEvent.
1984
1985         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
1986           using the new [ConvertFromString] property.
1987
1988         - Add forward declarations for NS* types to auto-generated classes.
1989
1990         * DerivedSources.make:
1991         * WebCore.xcodeproj/project.pbxproj:
1992         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
1993         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
1994         * bindings/objc/DOMInternal.h:
1995         * bindings/objc/DOMSVG.h:
1996         * bindings/scripts/CodeGeneratorObjC.pm:
1997         * html/HTMLAppletElement.idl:
1998         * html/HTMLEmbedElement.idl:
1999         * ksvg2/svg/SVGPatternElement.idl:
2000         * ksvg2/svg/SVGPolygonElement.idl:
2001         * ksvg2/svg/SVGPolylineElement.idl:
2002         * ksvg2/svg/SVGRadialGradientElement.idl:
2003         * ksvg2/svg/SVGRenderingIntent.idl:
2004         * ksvg2/svg/SVGScriptElement.idl:
2005         * ksvg2/svg/SVGSetElement.idl:
2006         * ksvg2/svg/SVGStopElement.idl:
2007         * ksvg2/svg/SVGSwitchElement.idl:
2008         * ksvg2/svg/SVGSymbolElement.idl:
2009         * ksvg2/svg/SVGTRefElement.idl:
2010         * ksvg2/svg/SVGTSpanElement.idl:
2011         * ksvg2/svg/SVGTextContentElement.idl:
2012         * ksvg2/svg/SVGTextElement.idl:
2013         * ksvg2/svg/SVGTextPositioningElement.idl:
2014         * ksvg2/svg/SVGTitleElement.idl:
2015         * ksvg2/svg/SVGUseElement.idl:
2016         * ksvg2/svg/SVGViewElement.idl:
2017         * ksvg2/svg/SVGZoomEvent.idl:
2018
2019 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2020
2021         Reviewed by Maciej.
2022
2023         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.        
2024         * loader/loader.cpp:
2025         (WebCore::Loader::servePendingRequests):
2026         
2027 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2028
2029         Reviewed by Darin.
2030
2031         Convert a bunch of RefPtr<StringImpl> to String.
2032         
2033         * bridge/mac/FrameMac.h:
2034         * bridge/mac/FrameMac.mm:
2035         (WebCore::FrameMac::didTellBridgeAboutLoad):
2036         (WebCore::FrameMac::haveToldBridgeAboutLoad):
2037         * dom/BeforeUnloadEvent.cpp:
2038         (WebCore::BeforeUnloadEvent::storeResult):
2039         * dom/BeforeUnloadEvent.h:
2040         (WebCore::BeforeUnloadEvent::result):
2041         * dom/Document.cpp:
2042         (WebCore::Document::createEntityReference):
2043         * dom/Entity.cpp:
2044         (WebCore::Entity::Entity):
2045         (WebCore::Entity::nodeName):
2046         (WebCore::Entity::toString):
2047         * dom/Entity.h:
2048         (WebCore::Entity::publicId):
2049         (WebCore::Entity::systemId):
2050         (WebCore::Entity::notationName):
2051         * dom/EntityReference.cpp:
2052         (WebCore::EntityReference::EntityReference):
2053         (WebCore::EntityReference::nodeName):
2054         (WebCore::EntityReference::cloneNode):
2055         (WebCore::EntityReference::toString):
2056         * dom/EntityReference.h:
2057         * dom/KeyboardEvent.cpp:
2058         (WebCore::KeyboardEvent::KeyboardEvent):
2059         (WebCore::KeyboardEvent::initKeyboardEvent):
2060         * dom/KeyboardEvent.h:
2061         (WebCore::KeyboardEvent::keyIdentifier):
2062         * dom/MutationEvent.cpp:
2063         (WebCore::MutationEvent::MutationEvent):
2064         (WebCore::MutationEvent::initMutationEvent):
2065         * dom/MutationEvent.h:
2066         (WebCore::MutationEvent::prevValue):
2067         (WebCore::MutationEvent::newValue):
2068         (WebCore::MutationEvent::attrName):
2069         * dom/Notation.cpp:
2070         (WebCore::Notation::Notation):
2071         (WebCore::Notation::nodeName):
2072         * dom/Notation.h:
2073         (WebCore::Notation::publicId):
2074         (WebCore::Notation::systemId):
2075         * dom/ProcessingInstruction.cpp:
2076         (WebCore::ProcessingInstruction::ProcessingInstruction):
2077         (WebCore::ProcessingInstruction::setData):
2078         (WebCore::ProcessingInstruction::nodeName):
2079         (WebCore::ProcessingInstruction::nodeValue):
2080         (WebCore::ProcessingInstruction::cloneNode):
2081         (WebCore::ProcessingInstruction::checkStyleSheet):
2082         (WebCore::ProcessingInstruction::toString):
2083         * dom/ProcessingInstruction.h:
2084         (WebCore::ProcessingInstruction::target):
2085         (WebCore::ProcessingInstruction::data):
2086         (WebCore::ProcessingInstruction::localHref):
2087
2088 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2089
2090         Reviewed by Tim H.
2091
2092         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
2093         10 more SVG Objective-C auto-generated bindings
2094
2095         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
2096           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
2097           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
2098           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
2099
2100         - Auto-generate the text method for DOMRange.
2101
2102         * DerivedSources.make:
2103         * WebCore.xcodeproj/project.pbxproj:
2104         * bindings/objc/DOM.mm:
2105         * bindings/objc/DOMExtensions.h:
2106         * bindings/objc/DOMInternal.h:
2107         * bindings/objc/DOMPrivate.h:
2108         * bindings/objc/DOMRGBColor.mm:
2109         * bindings/objc/DOMSVG.h:
2110         * bindings/objc/PublicDOMInterfaces.h:
2111         * bindings/scripts/CodeGeneratorObjC.pm:
2112         * dom/Range.idl:
2113         * ksvg2/svg/SVGFilterElement.cpp:
2114         * ksvg2/svg/SVGFilterElement.h:
2115         * ksvg2/svg/SVGFilterElement.idl:
2116         * ksvg2/svg/SVGForeignObjectElement.idl:
2117         * ksvg2/svg/SVGGElement.idl:
2118         * ksvg2/svg/SVGGradientElement.idl:
2119         * ksvg2/svg/SVGImageElement.idl:
2120         * ksvg2/svg/SVGLineElement.idl:
2121         * ksvg2/svg/SVGLinearGradientElement.idl:
2122         * ksvg2/svg/SVGMarkerElement.idl:
2123         * ksvg2/svg/SVGMaskElement.idl:
2124         * ksvg2/svg/SVGPaint.idl:
2125
2126 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2127
2128         Reviewed by Tim H.
2129
2130         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
2131         Auto-generate a few more Objective-C DOM interfaces
2132
2133         - Fully auto-generate DOMAbstractView and DOMRange.
2134
2135         - Auto-generate just the interface for DOMRGBColor.
2136
2137         - Add DOMRanges.h as the new top level file for Ranges
2138           module.
2139
2140         - Add DOMRanges.h and DOMXPath.h to DOM.mm
2141
2142         * DerivedSources.make:
2143         * WebCore.xcodeproj/project.pbxproj:
2144         * bindings/objc/DOM.h:
2145         * bindings/objc/DOM.mm:
2146         * bindings/objc/DOMAbstractView.h: Removed.
2147         * bindings/objc/DOMAbstractView.mm: Removed.
2148         * bindings/objc/DOMInternal.h:
2149         * bindings/objc/DOMPrivate.h:
2150         * bindings/objc/DOMRGBColor.h: Removed.
2151         * bindings/objc/DOMRGBColor.mm:
2152         * bindings/objc/DOMRange.h: Removed.
2153         * bindings/objc/DOMRanges.h: Added.
2154         * bindings/objc/PublicDOMInterfaces.h:
2155         * bindings/scripts/CodeGeneratorObjC.pm:
2156         * css/RGBColor.idl:
2157         * dom/Range.idl:
2158         * page/AbstractView.idl: Added.
2159
2160 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
2161
2162         Reviewed by Eric.
2163
2164         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
2165         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
2166
2167         Return null when there is no frame. This matches Firefox.
2168
2169         * bindings/js/kjs_html.cpp:
2170         (KJS::JSHTMLDocument::getValueProperty):
2171
2172 2006-10-07  David Hyatt  <hyatt@apple.com>
2173
2174         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
2175         scrollbar joins properly.
2176
2177         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
2178         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
2179
2180         Reviewed by mitz
2181
2182         * page/FrameView.cpp:
2183         (WebCore::selectCursor):
2184         (WebCore::FrameView::handleMouseMoveEvent):
2185         * platform/mac/PlatformScrollBar.h:
2186         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2187         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2188         * rendering/RenderLayer.cpp:
2189         (WebCore::RenderLayer::RenderLayer):
2190         (WebCore::RenderLayer::~RenderLayer):
2191         (WebCore::RenderLayer::updateLayerPositions):
2192         (WebCore::scrollCornerRect):
2193         (WebCore::RenderLayer::positionOverflowControls):
2194         (WebCore::RenderLayer::paintOverflowControls):
2195         (WebCore::RenderLayer::isPointInResizeControl):
2196         (WebCore::RenderLayer::paintLayer):
2197         * rendering/RenderLayer.h:
2198
2199 2006-10-07  Mark Rowe  <bdash@webkit.org>
2200
2201         Reviewed by Mitz.
2202
2203         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
2204         matching recent ResourceLoader changes.
2205
2206         * platform/gdk/FrameGdk.cpp:
2207         (WebCore::FrameGdk::openURL):
2208         (WebCore::FrameGdk::urlSelected):
2209         * platform/gdk/PlatformScrollBar.h:
2210         * platform/gdk/ResourceLoaderCurl.cpp:
2211         (WebCore::ResourceLoader::start):
2212         * platform/gdk/ScrollViewGdk.cpp:
2213         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2214         (WebCore::ScrollView::resizeContents):
2215         (WebCore::ScrollView::scrollBy):
2216         (WebCore::ScrollView::hScrollbarMode):
2217         (WebCore::ScrollView::vScrollbarMode):
2218         (WebCore::ScrollView::suppressScrollbars):
2219         (WebCore::ScrollView::setHScrollbarMode):
2220         (WebCore::ScrollView::setVScrollbarMode):
2221         (WebCore::ScrollView::setScrollbarsMode):
2222         * platform/gdk/TemporaryLinkStubs.cpp:
2223         (FrameView::passMousePressEventToScrollbar):
2224         (Widget::removeFromParent):
2225         (ScrollView::addChild):
2226         (ScrollView::updateScrollbars):
2227         (ScrollView::scrollbarUnderMouse):
2228         (PlatformScrollbar::PlatformScrollbar):
2229         (PlatformScrollbar::~PlatformScrollbar):
2230         (PlatformScrollbar::width):
2231         (PlatformScrollbar::height):
2232         (PlatformScrollbar::setEnabled):
2233         (PlatformScrollbar::paint):
2234         (PlatformScrollbar::updateThumbPosition):
2235         (PlatformScrollbar::updateThumbProportion):
2236         (PlatformScrollbar::setRect):
2237         (Scrollbar::Scrollbar):
2238         (Scrollbar::setSteps):
2239         (Scrollbar::scroll):
2240         (Scrollbar::setValue):
2241         (Scrollbar::setProportion):
2242
2243 2006-10-06  Dave Hyatt  <hyatt@apple.com>
2244
2245         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
2246
2247         * page/FrameView.cpp:
2248         (WebCore::FrameView::windowClipRect):
2249         * page/FrameView.h:
2250         * platform/ScrollView.h:
2251         * platform/Widget.cpp:
2252         (WebCore::Widget::windowClipRect):
2253         * platform/Widget.h:
2254         (WebCore::Widget::geometryChanged):
2255         (WebCore::Widget::handleMouseMoveEvent):
2256         (WebCore::Widget::handleMouseReleaseEvent):
2257         * platform/mac/ScrollViewMac.mm:
2258         (WebCore::ScrollView::addChild):
2259         * rendering/RenderLayer.cpp:
2260         (WebCore::RenderLayer::documentClipRect):
2261         * rendering/RenderLayer.h:
2262
2263 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
2264
2265         Reviewed by Adam.
2266
2267         Add another method we'll need for scrollbar dodging
2268
2269         * platform/ScrollView.h:
2270         * platform/win/TemporaryLinkStubs.cpp:
2271         (ScrollView::resizerOverlapsContent):
2272
2273 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
2274
2275         Reviewed by Tim H.
2276
2277         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
2278         Auto-generate the interfaces even for Objective-C DOM 
2279         bindings that need custom implementations
2280
2281         - Fully auto-generate DOMEventTarget, DOMNodeFilter and 
2282           DOMHTMLOptionElement.
2283
2284         - Auto-generate just the interface for DOMHTMLAppletElement,
2285           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
2286           using the new IDL property ObjCCustomImplementation.
2287
2288         * DerivedSources.make:
2289         * WebCore.xcodeproj/project.pbxproj:
2290         * bindings/objc/DOMEventTarget.h: Removed.
2291         * bindings/objc/DOMHTMLAppletElement.h: Removed.
2292         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
2293         * bindings/objc/DOMHTMLOptionElement.h: Removed.
2294         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
2295         * bindings/objc/DOMInternal.h:
2296         * bindings/objc/DOMNodeFilter.h: Removed.
2297         * bindings/objc/DOMSVGNumber.h: Removed.
2298         * bindings/objc/DOMSVGPoint.h: Removed.
2299         * bindings/objc/DOMSVGPoint.mm:
2300         (-[DOMSVGPoint matrixTransform:]):
2301         * bindings/objc/DOMSVGRect.h: Removed.
2302         * bindings/objc/PublicDOMInterfaces.h:
2303         * bindings/scripts/CodeGeneratorObjC.pm:
2304         * dom/EventTarget.idl:
2305         * html/HTMLAppletElement.idl:
2306         * html/HTMLEmbedElement.idl:
2307         * html/HTMLOptionElement.idl:
2308         * ksvg2/svg/SVGNumber.idl:
2309         * ksvg2/svg/SVGPoint.idl:
2310         * ksvg2/svg/SVGRect.idl:
2311
2312 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
2313
2314         Reviewed by Tim H.
2315
2316         Make Qt/Linux compile again completly.
2317
2318         * platform/qt/WidgetQt.cpp:
2319         (WebCore::Widget::removeFromParent):
2320
2321 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
2322
2323         Reviewed by Tim H.
2324
2325         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
2326
2327         * platform/qt/PlatformScrollBar.h:
2328         * platform/qt/ScrollViewQt.cpp:
2329         (WebCore::ScrollView::hScrollbarMode):
2330         (WebCore::ScrollView::vScrollbarMode):
2331         (WebCore::ScrollView::suppressScrollbars):
2332         (WebCore::ScrollView::setHScrollbarMode):
2333         (WebCore::ScrollView::setVScrollbarMode):
2334         (WebCore::ScrollView::setScrollbarsMode):
2335         (WebCore::ScrollView::scrollbarUnderMouse):
2336         * platform/qt/TemporaryLinkStubs.cpp:
2337         (WebCore::Scrollbar::Scrollbar):
2338         (WebCore::Scrollbar::setSteps):
2339         (WebCore::Scrollbar::scroll):
2340         (WebCore::Scrollbar::setValue):
2341         (WebCore::Scrollbar::setProportion):
2342         (WebCore::PlatformScrollbar::PlatformScrollbar):
2343         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2344         (WebCore::PlatformScrollbar::width):
2345         (WebCore::PlatformScrollbar::height):
2346         (WebCore::PlatformScrollbar::setEnabled):
2347         (WebCore::PlatformScrollbar::paint):
2348         (WebCore::PlatformScrollbar::updateThumbPosition):
2349         (WebCore::PlatformScrollbar::updateThumbProportion):
2350         (WebCore::PlatformScrollbar::setRect):
2351         (FrameView::passMousePressEventToScrollbar):
2352
2353 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
2354
2355         Reviewed by Tim H.
2356
2357         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
2358         Another round of Objective-C SVG DOM bindings auto-generation
2359
2360         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, 
2361           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, 
2362           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, 
2363           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
2364           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, 
2365           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, 
2366           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, 
2367           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, 
2368           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, 
2369           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, 
2370           DOMSVGFETileElement, DOMSVGFETurbulenceElement, 
2371           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. 
2372
2373         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
2374           and DOMSVGRect.
2375
2376         - IDL clean up.
2377
2378         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
2379           in it's macro declaration and definition.
2380
2381         * DerivedSources.make:
2382         * WebCore.xcodeproj/project.pbxproj:
2383         * bindings/objc/DOMCSS.mm:
2384         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2385         * bindings/objc/DOMInternal.h:
2386         * bindings/objc/DOMSVG.h:
2387         * bindings/objc/DOMSVGNumber.h: Added.
2388         * bindings/objc/DOMSVGNumber.mm: Added.
2389         (-[DOMSVGNumber dealloc]):
2390         (-[DOMSVGNumber finalize]):
2391         (-[DOMSVGNumber value]):
2392         (-[DOMSVGNumber setValue:]):
2393         (-[DOMSVGNumber _SVGNumber]):
2394         (-[DOMSVGNumber _initWithFloat:]):
2395         (+[DOMSVGNumber _SVGNumberWith:]):
2396         * bindings/objc/DOMSVGPoint.h: Added.
2397         * bindings/objc/DOMSVGPoint.mm: Added.
2398         (-[DOMSVGPoint dealloc]):
2399         (-[DOMSVGPoint finalize]):
2400         (-[DOMSVGPoint x]):
2401         (-[DOMSVGPoint setX:]):
2402         (-[DOMSVGPoint y]):
2403         (-[DOMSVGPoint setY:]):
2404         (-[DOMSVGPoint WebCore::]):
2405         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
2406         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
2407         * bindings/objc/DOMSVGRect.h: Added.
2408         * bindings/objc/DOMSVGRect.mm: Added.
2409         (-[DOMSVGRect dealloc]):
2410         (-[DOMSVGRect finalize]):
2411         (-[DOMSVGRect x]):
2412         (-[DOMSVGRect setX:]):
2413         (-[DOMSVGRect y]):
2414         (-[DOMSVGRect setY:]):
2415         (-[DOMSVGRect width]):
2416         (-[DOMSVGRect setWidth:]):
2417         (-[DOMSVGRect height]):
2418         (-[DOMSVGRect setHeight:]):
2419         (-[DOMSVGRect WebCore::]):
2420         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
2421         (+[DOMSVGRect _SVGRectWith:WebCore::]):
2422         * bindings/scripts/CodeGeneratorObjC.pm:
2423         * ksvg2/svg/SVGAnimatedNumberList.idl:
2424         * ksvg2/svg/SVGAnimatedRect.idl:
2425         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
2426         * ksvg2/svg/SVGCursorElement.idl:
2427         * ksvg2/svg/SVGFEBlendElement.idl:
2428         * ksvg2/svg/SVGFEColorMatrixElement.idl:
2429         * ksvg2/svg/SVGFEComponentTransferElement.idl:
2430         * ksvg2/svg/SVGFECompositeElement.idl:
2431         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
2432         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
2433         * ksvg2/svg/SVGFEDistantLightElement.idl:
2434         * ksvg2/svg/SVGFEFloodElement.idl:
2435         * ksvg2/svg/SVGFEFuncAElement.idl:
2436         * ksvg2/svg/SVGFEFuncBElement.idl:
2437         * ksvg2/svg/SVGFEFuncGElement.idl:
2438         * ksvg2/svg/SVGFEFuncRElement.idl:
2439         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
2440         * ksvg2/svg/SVGFEImageElement.idl:
2441         * ksvg2/svg/SVGFEMergeElement.idl:
2442         * ksvg2/svg/SVGFEMergeNodeElement.idl:
2443         * ksvg2/svg/SVGFEOffsetElement.idl:
2444         * ksvg2/svg/SVGFEPointLightElement.idl:
2445         * ksvg2/svg/SVGFESpecularLightingElement.idl:
2446         * ksvg2/svg/SVGFESpotLightElement.idl:
2447         * ksvg2/svg/SVGFETileElement.idl:
2448         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2449         * ksvg2/svg/SVGFETurbulenceElement.h:
2450         * ksvg2/svg/SVGFETurbulenceElement.idl:
2451         * ksvg2/svg/SVGNumberList.idl:
2452
2453 2006-10-06  Adam Roben  <aroben@apple.com>
2454
2455         Backing out my previous change.
2456
2457         * WebCore.xcodeproj/project.pbxproj:
2458         * page/FrameView.cpp:
2459         (WebCore::FrameView::adjustViewSize):
2460
2461 2006-10-06  Adam Roben  <aroben@apple.com>
2462
2463         Build fix.
2464
2465         * WebCore.xcodeproj/project.pbxproj:
2466         * page/FrameView.cpp:
2467         (WebCore::FrameView::windowResizerRect):
2468
2469 2006-10-06  Adam Roben  <aroben@apple.com>
2470
2471         Reviewed by Maciej.
2472
2473         More loader tweaks.
2474
2475         * platform/ResourceLoader.h:
2476         * platform/ResourceLoaderInternal.h:
2477         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2478         * platform/win/TemporaryLinkStubs.cpp:
2479         (WebCore::ResourceLoader::newHTTPRequest):
2480
2481 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
2482
2483         Reviewed by aroben.
2484
2485         Stub out some methods that we'll be able to use to dodge a window resizer.
2486
2487         * bridge/win/FrameWin.h:
2488         * page/Frame.h:
2489         (WebCore::Frame::windowResizerRect):
2490         * page/FrameView.h:
2491         * platform/ScrollView.h:
2492         (WebCore::ScrollView::windowResizerRect):
2493         * platform/Widget.h:
2494         * platform/win/TemporaryLinkStubs.cpp:
2495         (FrameView::windowResizerRect):
2496         (Widget::setParent):
2497         (Widget::parent):
2498         (FrameWin::windowResizerRect):
2499
2500 2006-10-05  Dave Hyatt  <hyatt@apple.com>
2501
2502         Stub out setFrameGeometry.
2503         
2504         * platform/ScrollView.h:
2505
2506 2006-10-05  Adele Peterson  <adele@apple.com>
2507
2508         Reverting autoscroll fix.  I need to rework this a little.
2509
2510         * page/Frame.cpp:
2511         (WebCore::Frame::handleAutoscroll):
2512         (WebCore::Frame::autoscrollTimerFired):
2513         (WebCore::Frame::stopAutoscrollTimer):
2514         * page/Frame.h:
2515         * rendering/RenderLayer.cpp:
2516         (WebCore::RenderLayer::~RenderLayer):
2517         * rendering/RenderListBox.cpp:
2518         (WebCore::RenderListBox::~RenderListBox):
2519
2520 2006-10-05  Alice  <alice.liu@apple.com>
2521
2522         Reviewed by Adam.
2523
2524         Fixed <rdar://problem/4731778>
2525
2526         * editing/CommandByName.cpp:
2527         (WebCore::Frame::Command::):
2528         was calling the wrong enabledFn for arrow selection and navigation
2529
2530 2006-10-05  Adele Peterson  <adele@apple.com>
2531
2532         Reviewed by Maciej.
2533
2534         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
2535           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
2536
2537         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
2538         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
2539
2540         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
2541         (WebCore::Frame::handleAutoscroll):
2542         (WebCore::Frame::autoscrollTimerFired):
2543         (WebCore::Frame::autoscrollRenderer):
2544         (WebCore::Frame::setAutoscrollRenderer):
2545         (WebCore::Frame::stopAutoscrollTimer):
2546         * page/Frame.h:
2547
2548 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2549
2550         Reviewed by Eric.
2551
2552         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
2553         Properly include PlatformScrollBar.h in WbCore.vcproj.
2554         Clean up WidgetWin.cpp a bit.
2555
2556         * WebCore.vcproj/WebCore/WebCore.vcproj:
2557         * platform/Widget.h:
2558         * platform/win/PlatformScrollBar.h:
2559         * platform/win/ScrollViewWin.cpp:
2560         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2561         (WebCore::ScrollView::resizeContents):
2562         (WebCore::ScrollView::scrollBy):
2563         (WebCore::ScrollView::hScrollbarMode):
2564         (WebCore::ScrollView::vScrollbarMode):
2565         (WebCore::ScrollView::suppressScrollbars):
2566         (WebCore::ScrollView::setHScrollbarMode):
2567         (WebCore::ScrollView::setVScrollbarMode):
2568         (WebCore::ScrollView::setScrollbarsMode):
2569         (WebCore::ScrollView::updateScrollbars):
2570         * platform/win/TemporaryLinkStubs.cpp:
2571         (FrameView::passMousePressEventToScrollbar):
2572         (Widget::removeFromParent):
2573         (ScrollView::scrollbarUnderMouse):
2574         (PlatformScrollbar::PlatformScrollbar):
2575         (PlatformScrollbar::~PlatformScrollbar):
2576         (PlatformScrollbar::width):
2577         (PlatformScrollbar::height):
2578         (PlatformScrollbar::setEnabled):
2579         (PlatformScrollbar::paint):
2580         (PlatformScrollbar::updateThumbPosition):
2581         (PlatformScrollbar::updateThumbProportion):
2582         (PlatformScrollbar::setRect):
2583         (Scrollbar::Scrollbar):
2584         (Scrollbar::setSteps):
2585         (Scrollbar::scroll):
2586         (Scrollbar::setValue):
2587         (Scrollbar::setProportion):
2588         * platform/win/WidgetWin.cpp:
2589         (WebCore::WidgetPrivate::WidgetPrivate):
2590         (WebCore::Widget::Widget):
2591         (WebCore::Widget::setContainingWindow):
2592         (WebCore::Widget::containingWindow):
2593
2594 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2595
2596         build fix.
2597         
2598         * WebCore.xcodeproj/project.pbxproj:
2599         * bridge/mac/BrowserExtensionMac.mm:
2600         (WebCore::BrowserExtensionMac::createNewWindow):
2601         * bridge/mac/FrameMac.mm:
2602         (WebCore::FrameMac::createFrame):
2603         * bridge/mac/FrameViewMac.mm:
2604         (WebCore::FrameView::passMousePressEventToScrollbar):
2605         * bridge/mac/WebCoreFrameBridge.mm:
2606         (-[WebCoreFrameBridge installInFrame:]):
2607         * bridge/mac/WebCoreFrameView.h:
2608         * platform/ScrollBar.cpp:
2609         * platform/Widget.h:
2610         * platform/mac/PlatformScrollBar.h:
2611         * platform/mac/PlatformScrollBarMac.mm:
2612         (NSControlSizeForScrollBarControlSize):
2613         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
2614         (-[WebCoreScrollBar detachPlatformScrollbar]):
2615         (-[WebCoreScrollBar scroll:]):
2616         (-[WebCoreScrollBar widget]):
2617         (WebCore::PlatformScrollbar::PlatformScrollbar):
2618         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2619         (WebCore::PlatformScrollbar::updateThumbPosition):
2620         (WebCore::PlatformScrollbar::updateThumbProportion):
2621         (WebCore::PlatformScrollbar::scrollbarHit):
2622         (WebCore::PlatformScrollbar::width):
2623         (WebCore::PlatformScrollbar::height):
2624         (WebCore::PlatformScrollbar::setRect):
2625         (WebCore::PlatformScrollbar::setEnabled):
2626         (WebCore::PlatformScrollbar::paint):
2627         * platform/mac/ScrollViewMac.mm:
2628         (WebCore::ScrollView::setVScrollbarMode):
2629         (WebCore::ScrollView::setHScrollbarMode):
2630         (WebCore::ScrollView::setScrollbarsMode):
2631         (WebCore::ScrollView::vScrollbarMode):
2632         (WebCore::ScrollView::hScrollbarMode):
2633         (WebCore::ScrollView::suppressScrollbars):
2634         (WebCore::ScrollView::scrollbarUnderMouse):
2635         * platform/mac/WidgetMac.mm:
2636         (WebCore::Widget::removeFromParent):
2637         * rendering/RenderLayer.cpp:
2638         (WebCore::RenderLayer::destroyScrollbar):
2639
2640 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2641
2642         build fix.
2643         
2644         * platform/Widget.h:
2645         * rendering/RenderLayer.cpp:
2646         (WebCore::RenderLayer::destroyScrollbar):
2647
2648 2006-10-06  Mitz Pettel  <mitz@webkit.org>
2649
2650         http://bugs.webkit.org/show_bug.cgi?id=8276
2651         Fix broken manual test added back in r13990.
2652
2653         Add resource forks for test resources.
2654
2655         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
2656         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
2657         * manual-tests/resources/plain-text-paste/._4.txt: Added.
2658         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
2659
2660 2006-10-05  David Hyatt  <hyatt@apple.com>
2661
2662         Rename addClip to clip.
2663
2664         Reviewed by darin
2665
2666         * kcanvas/RenderForeignObject.cpp:
2667         (WebCore::RenderForeignObject::paint):
2668         * kcanvas/RenderSVGContainer.cpp:
2669         (WebCore::RenderSVGContainer::paint):
2670         * kcanvas/RenderSVGImage.cpp:
2671         (WebCore::RenderSVGImage::paint):
2672         * platform/GraphicsContext.h:
2673         * platform/cairo/GraphicsContextCairo.cpp:
2674         (WebCore::GraphicsContext::clip):
2675         * platform/cg/GraphicsContextCG.cpp:
2676         (WebCore::GraphicsContext::savePlatformState):
2677         (WebCore::GraphicsContext::restorePlatformState):
2678         (WebCore::GraphicsContext::clip):
2679         (WebCore::GraphicsContext::addRoundedRectClip):
2680         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2681         (WebCore::GraphicsContext::scale):
2682         (WebCore::GraphicsContext::rotate):
2683         (WebCore::GraphicsContext::translate):
2684         (WebCore::GraphicsContext::concatCTM):
2685         * platform/cg/GraphicsContextPlatformPrivate.h:
2686         (WebCore::GraphicsContextPlatformPrivate::save):
2687         (WebCore::GraphicsContextPlatformPrivate::restore):
2688         (WebCore::GraphicsContextPlatformPrivate::clip):
2689         (WebCore::GraphicsContextPlatformPrivate::scale):
2690         (WebCore::GraphicsContextPlatformPrivate::rotate):
2691         (WebCore::GraphicsContextPlatformPrivate::translate):
2692         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
2693         * platform/qt/GraphicsContextQt.cpp:
2694         (WebCore::GraphicsContext::clip):
2695         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2696         (WebCore::GraphicsContext::addRoundedRectClip):
2697         * rendering/InlineFlowBox.cpp:
2698         (WebCore::InlineFlowBox::paintBackground):
2699         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
2700         * rendering/InlineTextBox.cpp:
2701         (WebCore::InlineTextBox::paintSelection):
2702         (WebCore::InlineTextBox::paintTextMatchMarker):
2703         * rendering/RenderBox.cpp:
2704         (WebCore::RenderBox::paintBackgroundExtended):
2705         * rendering/RenderButton.cpp:
2706         (WebCore::RenderButton::paintObject):
2707         * rendering/RenderFileUploadControl.cpp:
2708         (WebCore::RenderFileUploadControl::paintObject):
2709         * rendering/RenderLayer.cpp:
2710         (WebCore::RenderLayer::beginTransparencyLayers):
2711         (WebCore::setClip):
2712         * rendering/RenderListBox.cpp:
2713         (WebCore::RenderListBox::paintObject):
2714         * rendering/RenderMenuList.cpp:
2715         (WebCore::RenderMenuList::paintObject):
2716         * rendering/RenderTableCell.cpp:
2717         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
2718
2719 2006-10-05  Mitz Pettel  <mitz@webkit.org>
2720
2721         Reviewed by Darin.
2722
2723         - http://bugs.webkit.org/show_bug.cgi?id=10386
2724           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
2725
2726         * CMakeLists.txt:
2727         * WebCore.vcproj/WebCore/WebCore.vcproj:
2728         * WebCoreSources.bkl:
2729         * rendering/RenderImageButton.cpp: Removed.
2730         * rendering/RenderImageButton.h: Removed.
2731
2732 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2733
2734         Reviewed by Darin.
2735
2736         - http://bugs.webkit.org/show_bug.cgi?id=11067
2737           manual-tests/scrollbar-hittest2.html is invalid
2738
2739         * manual-tests/scrollbar-hittest2.html:
2740
2741 2006-10-05  David Carson  <dacarson@gmail.com>
2742
2743         Reviewed by Darin.
2744
2745         http://bugs.webkit.org/show_bug.cgi?id=11152
2746         Adjust the tokenizer chunk size to be smaller for
2747         mobile devices, and also decrease the yield timer
2748         for the tokenizer so that it can resume earlier.
2749
2750         * html/HTMLTokenizer.cpp:
2751         * config.h:
2752
2753 2006-10-05  Adam Roben  <aroben@apple.com>
2754
2755         Removing accidentally-checked-in do-nothing code.
2756
2757         * html/HTMLInputElement.cpp:
2758         (WebCore::HTMLInputElement::defaultEventHandler):
2759
2760 2006-10-05  David Carson  <dacarson@gmail.com>
2761
2762         Reviewed by Mitz.
2763
2764         http://bugs.webkit.org/show_bug.cgi?id=11158
2765         Initialize class variables
2766
2767         * rendering/RenderLayer.cpp:
2768         (WebCore::RenderLayer::RenderLayer):
2769
2770 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2771
2772         Reviewed by Darin, landed by Adam.
2773
2774         http://bugs.webkit.org/show_bug.cgi?id=11176
2775         Fix win32 build, adapt to Maciej's ResourceLoader changes.
2776
2777         * platform/win/ResourceLoaderWin.cpp:
2778         (WebCore::ResourceLoader::start):
2779
2780 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
2781
2782         Reviewed by Darin.
2783
2784         http://bugs.webkit.org/show_bug.cgi?id=10989
2785         Provide a way for embedders to implement BrowserExtensionWin
2786
2787         * WebCore.vcproj/WebCore/WebCore.vcproj:
2788         * bridge/win/BrowserExtensionWin.cpp: Added.
2789         (BrowserExtensionWin::BrowserExtensionWin):
2790         (BrowserExtensionWin::setTypedIconURL):
2791         (BrowserExtensionWin::setIconURL):
2792         (BrowserExtensionWin::getHistoryLength):
2793         (BrowserExtensionWin::canRunModal):
2794         (BrowserExtensionWin::createNewWindow):
2795         (BrowserExtensionWin::canRunModalNow):
2796         (BrowserExtensionWin::runModal):
2797         (BrowserExtensionWin::goBackOrForward):
2798         (BrowserExtensionWin::historyURL):
2799         * bridge/win/BrowserExtensionWin.h:
2800         * bridge/win/FrameWin.cpp:
2801         (WebCore::FrameWin::createNewWindow):
2802         * bridge/win/FrameWin.h:
2803         * platform/win/TemporaryLinkStubs.cpp:
2804
2805 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2806
2807         Reviewed by Darin.
2808         
2809         Fixed <rdar://problem/4766987>
2810         
2811         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
2812         except for file names.
2813         
2814         - fixed RenderLayer to properly tear down scrollbars, removing them from
2815         their parents.
2816
2817         * bindings/js/kjs_window.cpp:
2818         (KJS::showModalDialog):
2819         (KJS::setWindowFeature):
2820         (KJS::parseWindowFeatures):
2821         * bridge/BrowserExtension.h:
2822         * dom/Document.cpp:
2823         (WebCore::Document::setInPageCache):
2824         * html/HTMLFrameElement.cpp:
2825         (WebCore::HTMLFrameElement::init):
2826         (WebCore::HTMLFrameElement::parseMappedAttribute):
2827         * html/HTMLFrameElement.h:
2828         (WebCore::HTMLFrameElement::scrollingMode):
2829         * page/Frame.cpp:
2830         (WebCore::Frame::finishedParsing):
2831         (WebCore::Frame::scrollbarsVisible):
2832         * page/FrameView.cpp:
2833         (WebCore::FrameViewPrivate::FrameViewPrivate):
2834         (WebCore::FrameViewPrivate::reset):
2835         (WebCore::FrameView::~FrameView):
2836         (WebCore::FrameView::resetScrollbars):
2837         (WebCore::FrameView::clear):
2838         (WebCore::FrameView::initScrollbars):
2839         (WebCore::FrameView::applyOverflowToViewport):
2840         (WebCore::FrameView::layout):
2841         (WebCore::FrameView::handleMousePressEvent):
2842         (WebCore::selectCursor):
2843         (WebCore::FrameView::handleMouseMoveEvent):
2844         (WebCore::FrameView::setScrollbarsMode):
2845         (WebCore::FrameView::setVScrollbarMode):
2846         (WebCore::FrameView::setHScrollbarMode):
2847         (WebCore::FrameView::restoreScrollbar):
2848         (WebCore::FrameView::dispatchMouseEvent):
2849         (WebCore::FrameView::scrollbarMoved):
2850         * page/FrameView.h:
2851         * page/MouseEventWithHitTestResults.cpp:
2852         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2853         * page/MouseEventWithHitTestResults.h:
2854         (WebCore::MouseEventWithHitTestResults::scrollbar):
2855         * platform/ScrollBar.cpp:
2856         (WebCore::Scrollbar::Scrollbar):
2857         (WebCore::Scrollbar::setValue):
2858         (WebCore::Scrollbar::setProportion):
2859         (WebCore::Scrollbar::setSteps):
2860         (WebCore::Scrollbar::scroll):
2861         * platform/ScrollBar.h:
2862         (WebCore::):
2863         (WebCore::ScrollbarClient::~ScrollbarClient):
2864         (WebCore::Scrollbar::~Scrollbar):
2865         (WebCore::Scrollbar::orientation):
2866         (WebCore::Scrollbar::controlSize):
2867         (WebCore::Scrollbar::hasPlatformScrollbars):
2868         (WebCore::Scrollbar::client):
2869         * platform/ScrollBarMode.h:
2870         (WebCore::):
2871         * platform/ScrollView.h:
2872         * rendering/RenderBlock.cpp:
2873         (WebCore::RenderBlock::isPointInScrollbar):
2874         * rendering/RenderLayer.cpp:
2875         (WebCore::RenderLayer::RenderLayer):
2876         (WebCore::RenderLayer::~RenderLayer):
2877         (WebCore::RenderLayer::scrollToOffset):
2878         (WebCore::RenderLayer::horizontaScrollbarWidget):
2879         (WebCore::RenderLayer::verticalScrollbarWidget):
2880         (WebCore::RenderLayer::valueChanged):
2881         (WebCore::RenderLayer::createScrollbar):
2882         (WebCore::RenderLayer::destroyScrollbar):
2883         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2884         (WebCore::RenderLayer::setHasVerticalScrollbar):
2885         (WebCore::RenderLayer::verticalScrollbarWidth):
2886         (WebCore::RenderLayer::horizontalScrollbarHeight):
2887         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2888         * rendering/RenderLayer.h:
2889         (WebCore::RenderLayer::horizontalScrollbar):
2890         (WebCore::RenderLayer::verticalScrollbar):
2891         * rendering/RenderListBox.cpp:
2892         (WebCore::RenderListBox::~RenderListBox):
2893         (WebCore::RenderListBox::calcMinMaxWidth):
2894         (WebCore::RenderListBox::isPointInScrollbar):
2895         (WebCore::RenderListBox::optionAtPoint):
2896         (WebCore::RenderListBox::valueChanged):
2897         * rendering/RenderListBox.h:
2898         * rendering/RenderObject.h:
2899         (WebCore::RenderObject::NodeInfo::scrollbar):
2900         (WebCore::RenderObject::NodeInfo::setScrollbar):
2901
2902 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2903
2904         Reviewed by Adam.
2905
2906         http://bugs.webkit.org/show_bug.cgi?id=11138
2907         Incorrect mouse event generation on Windows
2908
2909         * platform/win/MouseEventWin.cpp:
2910         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2911         (1) Set mouse button even for non-click-related messages.
2912         (2) Track clicks correctly for all buttons, not just the left button.
2913
2914 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
2915
2916         Reviewed and landed by ap.
2917
2918         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
2919
2920         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
2921         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
2922         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
2923         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
2924         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
2925         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
2926         (WebCore::KRenderingPaintServerPatternQt::renderPath):
2927         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
2928         (WebCore::KRenderingPaintServerQt::setPenProperties):
2929         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
2930         (WebCore::KRenderingPaintServerSolidQt::setup):
2931         (WebCore::KRenderingPaintServerSolidQt::renderPath):
2932         * kcanvas/device/qt/RenderPathQt.cpp:
2933         (WebCore::getPathStroke):
2934
2935 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
2936
2937         Reviewed by Darin.
2938
2939         http://bugs.webkit.org/show_bug.cgi?id=11054
2940         REGRESSION: Traditional Chinese encoding in login authentication
2941
2942         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
2943         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
2944         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
2945
2946         * platform/StreamingTextDecoderICU.cpp:
2947         (WebCore::TextCodecICU::registerEncodingNames):
2948
2949 2006-10-05  Eric Seidel  <eric@eseidel.com>
2950
2951         Reviewed by mjs.
2952
2953         Removed dead code.
2954         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
2955
2956         * WebCore.xcodeproj/project.pbxproj:
2957         * ksvg2/ecma/GlobalObject.cpp: Removed.
2958         * ksvg2/ecma/GlobalObject.h: Removed.
2959
2960 2006-10-05  Adam Roben  <aroben@apple.com>
2961
2962         Reviewed by Maciej.
2963
2964         Small ResourceLoaderInternal tweak.
2965
2966         * platform/ResourceLoaderInternal.h:
2967         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2968
2969 2006-10-05  Eric Seidel  <eric@eseidel.com>
2970
2971         Reviewed by mjs.
2972
2973         More incremental KCanvas cleanup and optimization.
2974         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
2975         Optimized dash array usage to not malloc.
2976         Also removed un-needed KSVGRenderingStyle includes.
2977
2978         * kcanvas/KCanvasTreeDebug.cpp:
2979         (WebCore::operator<<):
2980         * kcanvas/RenderPath.cpp:
2981         (WebCore::RenderPath::nodeAtPoint):
2982         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2983         (WebCore::RenderPath::strokeBBox):
2984         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2985         (WebCore::KRenderingPaintServerGradientQuartz::setup):
2986         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
2987         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2988         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2989         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2990         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2991         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2992         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2993         * kcanvas/device/quartz/QuartzSupport.mm:
2994         (WebCore::applyStrokeStyleToContext):
2995         * ksvg2/css/SVGRenderStyle.h:
2996         (WebCore::SVGRenderStyle::hasStroke):
2997         (WebCore::SVGRenderStyle::hasFill):
2998         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2999         (WebCore::KSVGPainterFactory::fillPaintServer):
3000         (WebCore::KSVGPainterFactory::strokePaintServer):
3001         * ksvg2/misc/KCanvasRenderingStyle.h:
3002
3003 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
3004
3005         Reviewed by Adam.
3006
3007         - changed ResourceLoader to be refcounted
3008
3009         It keeps a ref on itself while loading as well. This makes
3010         for a much saner memory management model than the previous.
3011
3012         * bridge/mac/WebCoreResourceLoaderImp.mm:
3013         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
3014         * dom/XMLTokenizer.cpp:
3015         (WebCore::openFunc):
3016         * loader/icon/IconLoader.cpp:
3017         (IconLoader::IconLoader):
3018         (IconLoader::~IconLoader):
3019         (IconLoader::startLoading):
3020         (IconLoader::stopLoading):
3021         (IconLoader::receivedData):
3022         * loader/icon/IconLoader.h:
3023         * loader/loader.cpp:
3024         (WebCore::Loader::servePendingRequests):
3025         * platform/ResourceLoader.cpp:
3026         (WebCore::ResourceLoader::create):
3027         (WebCore::ResourceLoader::kill):
3028         * platform/ResourceLoader.h:
3029         * platform/ResourceLoaderInternal.h:
3030         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3031         * platform/mac/ResourceLoaderMac.mm:
3032         (WebCore::ResourceLoader::start):
3033         * xml/XSLTProcessor.cpp:
3034         (WebCore::docLoaderFunc):
3035         * xml/xmlhttprequest.cpp:
3036         (WebCore::XMLHttpRequest::send):
3037         * xml/xmlhttprequest.h:
3038
3039 2006-10-05  Eric Seidel  <eric@eseidel.com>
3040
3041         Reviewed by mjs.
3042
3043         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
3044         http://bugs.webkit.org/show_bug.cgi?id=11163
3045         
3046         No SVG performance tests yet.
3047
3048         * kcanvas/RenderForeignObject.cpp:
3049         (WebCore::RenderForeignObject::paint):
3050         * kcanvas/RenderSVGContainer.cpp:
3051         (WebCore::RenderSVGContainer::paint):
3052         * kcanvas/RenderSVGImage.cpp:
3053         (WebCore::RenderSVGImage::paint):
3054         * kcanvas/RenderSVGText.cpp:
3055         (WebCore::RenderSVGText::paint):
3056
3057 2006-10-05  Dave Hyatt  <hyatt@apple.com>
3058
3059         Stub out some stuff for widget focusability.
3060
3061         Reviewed by maciej
3062  
3063         * page/FrameView.cpp:
3064         (WebCore::FrameView::dispatchMouseEvent):
3065         * platform/ScrollView.h:
3066         * platform/Widget.h:
3067
3068 2006-10-05  Adam Roben  <aroben@apple.com>
3069
3070         Reviewed by Maciej and Tim H.
3071
3072         Copy some WebKit frame lifetime logic into WebCore -- just a step
3073         along the path to frame lifetime being handled completely in WebCore.
3074
3075         * bridge/mac/FrameMac.mm:
3076         (WebCore::FrameMac::setView): Move platform-independent parts of this
3077         method into Frame.
3078         * page/Frame.cpp:
3079         (WebCore::Frame::setView): Adding platform-independent parts of
3080         FrameMac::setView
3081         (WebCore::Frame::detachChildren): New method to accomplish what
3082         -[WebFrameBridge _detachChildren] currently does.
3083         (WebCore::Frame::clear): Call detachChildren
3084         * page/Frame.h: Add declaration for detachChildren
3085
3086 2006-10-04  Alice Liu  <alice.liu@apple.com>
3087
3088         Reviewed by Darin.
3089
3090         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
3091
3092         * xml/xmlhttprequest.cpp:
3093         (WebCore::XMLHttpRequest::setRequestHeader):
3094         removed exception set when the request is not open yet
3095
3096 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
3097
3098         Reviewed by John Sullivan.
3099
3100         <rdar://problem/4654328>
3101         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
3102         
3103         * loader/PluginDocument.cpp:
3104         (WebCore::PluginTokenizer::writeRawData):
3105         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
3106
3107 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
3108
3109         Reviewed by Tim H.
3110
3111         http://bugs.webkit.org/show_bug.cgi?id=11130
3112         Convert "undefined" to AE missing value
3113
3114         * bridge/mac/WebCoreFrameBridge.mm:
3115         (aeDescFromJSValue): return missing value for UndefinedType.
3116
3117 2006-10-03  Dave Hyatt  <hyatt@apple.com>
3118
3119         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
3120         the windowToContents/contentsToWindow functions.
3121         
3122         Reviewed by anders
3123
3124         * bridge/mac/FrameMac.mm:
3125         (WebCore::FrameMac::eventMayStartDrag):
3126         (WebCore::FrameMac::dragHysteresisExceeded):
3127         (WebCore::FrameMac::mouseDown):
3128         (WebCore::FrameMac::shouldDragAutoNode):
3129         (WebCore::FrameMac::sendContextMenuEvent):
3130         * bridge/mac/FrameViewMac.mm:
3131         (WebCore::FrameView::passMousePressEventToScrollbar):
3132         * bridge/mac/WebCoreFrameBridge.mm:
3133         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
3134         * dom/EventTargetNode.cpp:
3135         (WebCore::EventTargetNode::dispatchMouseEvent):
3136         (WebCore::EventTargetNode::dispatchWheelEvent):
3137         * page/Frame.cpp:
3138         (WebCore::Frame::selectClosestWordFromMouseEvent):
3139         (WebCore::Frame::handleMousePressEventTripleClick):
3140         (WebCore::Frame::handleMousePressEventSingleClick):
3141         (WebCore::Frame::handleMouseMoveEvent):
3142         (WebCore::Frame::handleMouseReleaseEvent):
3143         * page/FrameView.cpp:
3144         (WebCore::FrameView::handleMousePressEvent):
3145         (WebCore::FrameView::handleMouseDoubleClickEvent):
3146         (WebCore::selectCursor):
3147         (WebCore::FrameView::handleMouseMoveEvent):
3148         (WebCore::FrameView::handleMouseReleaseEvent):
3149         (WebCore::FrameView::dispatchDragEvent):
3150         (WebCore::FrameView::prepareMouseEvent):
3151         (WebCore::FrameView::handleWheelEvent):
3152         * page/FrameView.h:
3153         * platform/ScrollBar.cpp:
3154         (WebCore::ScrollBar::setValue):
3155         * platform/ScrollView.h:
3156         * platform/Widget.h:
3157         (WebCore::Widget::scrolled):
3158         * platform/mac/ScrollViewMac.mm:
3159         (WebCore::ScrollView::contentsToWindow):
3160         (WebCore::ScrollView::windowToContents):
3161         (WebCore::ScrollView::scrollbarUnderMouse):
3162         * platform/mac/WidgetMac.mm:
3163         * rendering/RenderLayer.cpp:
3164         (WebCore::RenderLayer::resize):
3165         (WebCore::RenderLayer::positionScrollbars):
3166         * rendering/RenderReplaced.cpp:
3167         (WebCore::RenderReplaced::shouldPaint):
3168         * rendering/RenderView.cpp:
3169         * rendering/RenderView.h:
3170         * rendering/RenderWidget.cpp:
3171         (WebCore::RenderWidget::setWidget):
3172
3173 2006-09-26  David Smith  <catfish.man@gmail.com>
3174
3175         Reviewed by Timothy.
3176
3177         http://bugs.webkit.org/show_bug.cgi?id=3723
3178         Add -scrollDOMRangeToVisible:
3179
3180         No automated tests are possible as this code path isn't reachable from JavaScript.
3181
3182         * bridge/mac/WebCoreFrameBridge.h:
3183         * bridge/mac/WebCoreFrameBridge.mm:
3184         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
3185
3186 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
3187
3188         Reviewed by Timothy.
3189
3190         <http://bugs.webkit.org/show_bug.cgi?id=10338>
3191         When contentEditable, cursor doesn't change to hand
3192         
3193         Allow the behaviour of editable links to be specified by a WebPreference
3194         The preference WebKitEditableLinkBehavior has four options:
3195          - AlwaysLive: Safari 2.0 behaviour
3196          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
3197          - LiveWhenNotFocused: Editable links are live only when their editable block is not
3198              focused, or when the shift key is pressed
3199          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
3200          
3201         No layout tests, just a modification of a manual-test as it isn't possible to test
3202         this automatically.
3203
3204         * bridge/mac/WebCoreSettings.h:
3205         * bridge/mac/WebCoreSettings.mm:
3206         (-[WebCoreSettings setEditableLinkBehavior:]):
3207         (-[WebCoreSettings editableLinkBehavior]):
3208         * html/HTMLAnchorElement.cpp:
3209         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3210         (WebCore::HTMLAnchorElement::defaultEventHandler):
3211         (WebCore::HTMLAnchorElement::setActive):
3212         * html/HTMLAnchorElement.h:
3213         * manual-tests/contenteditable-link.html:
3214         * page/FrameView.cpp:
3215         (WebCore::nodeIsNotBeingEdited):
3216         (WebCore::selectCursor):
3217         * page/Settings.h:
3218         (WebCore::Settings::):
3219         (WebCore::Settings::Settings):
3220         (WebCore::Settings::editableLinkBehavior):
3221         (WebCore::Settings::setEditableLinkBehavior):
3222
3223 2006-10-03  Beth Dakin  <bdakin@apple.com>
3224
3225         Reviewed Darin.
3226
3227         No test cases needed.
3228
3229         Implemented a version of StringImpl::append that takes a UChar* and 
3230         a length.
3231
3232         * platform/StringImpl.cpp:
3233         (WebCore::StringImpl::append):
3234         (WebCore::StringImpl::insert): Call new append instead of making a 
3235         new StringImpl.
3236         * platform/StringImpl.h:
3237
3238 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
3239
3240         Reviewed by Darin.
3241
3242         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
3243         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
3244
3245         * platform/win/ResourceLoaderWin.cpp:
3246         (WebCore::ResourceLoader::onHandleCreated):
3247
3248 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
3249
3250         Feared, loathed, reviewed by Darin.
3251
3252         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
3253         into FRAME, plus other cleanup.
3254         
3255         No new behavior, so no new test. Layout tests pass. Basic browsing and
3256         Mail editing seem to work.
3257         
3258         * dom/Node.cpp:
3259         (WebCore::Node::detach): Removed random commented-out code.
3260         * html/HTMLFrameElement.cpp:
3261         (WebCore::HTMLFrameElement::isURLAllowed): 
3262         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
3263         (2) Renamed newURL to completeURL because the difference between newURL
3264         and URLString is that newURL is a KURL that is the complete version of URLString,
3265         not that it is new.
3266         (WebCore::HTMLFrameElement::willRemove): 
3267         (1) Removed close() call and moved close() code into willRemove(), also removing 
3268         close() call from detach(), since willRemove is the well-defined place 
3269         from DOM tear-down, not detach().
3270         (2) Removed manual renderer detach code because the DOM is not responsible
3271         for managing the render tree. I confirmed that this change not
3272         regress <rdar://problem/4132581>.
3273         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
3274         lost their content frames after being removed from the DOM. That's our 
3275         current behavior, but it's going to change in future rounds of refactoring.
3276         This also fixes <rdar://problem/4750835>.
3277         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
3278         attach/detach, because the render tree should not be in charge of deciding
3279         when to load.
3280         * html/HTMLFrameElement.h:
3281         * html/HTMLIFrameElement.cpp:
3282         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
3283         because the renderer is a renderPartObject, not a renderPart.
3284         * html/HTMLIFrameElement.h:
3285
3286 2006-10-03  Mark Rowe  <bdash@webkit.org>
3287
3288         Reviewed by Mitz.
3289
3290         http://bugs.webkit.org/show_bug.cgi?id=11137
3291         Bug 11137: GdkLauncher dies with "pure virtual method called" if
3292         window is closed while page still loading
3293
3294         * platform/gdk/FrameGdk.cpp:
3295         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
3296         methods to be called before the FrameGdk portion of "this" is torn down.
3297
3298 2006-10-03  Adam Roben  <aroben@apple.com>
3299
3300         Reviewed by Darin.
3301
3302         Handle tab key presses in the DOM.
3303
3304         * dom/EventTargetNode.cpp:
3305         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
3306         * page/FrameView.cpp:
3307         (WebCore::FrameView::advanceFocus): Rename and reimplement
3308         focusNextPrevNode. Now we just call Element::focus().
3309         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
3310         it public.
3311
3312 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3313
3314         Reviewed by mjs
3315         
3316         <rdar://problem/4760612>
3317         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
3318         
3319         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
3320         
3321         * dom/Range.cpp:
3322         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
3323         positions are non-null since most of it's callers would be in a bad state if the positions 
3324         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
3325         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
3326         from entering compareBoundaryPoints and hitting the assert.
3327
3328 2006-10-03  Adele Peterson  <adele@apple.com>
3329
3330         Reviewed by Geoff.
3331
3332         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
3333
3334         * html/HTMLSelectElement.cpp:
3335         (WebCore::HTMLSelectElement::recalcStyle):
3336         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3337         (WebCore::HTMLSelectElement::isMouseFocusable):
3338         (WebCore::HTMLSelectElement::createRenderer):
3339         (WebCore::HTMLSelectElement::setRecalcListItems):
3340         (WebCore::HTMLSelectElement::notifyOptionSelected):
3341         (WebCore::HTMLSelectElement::defaultEventHandler):
3342
3343 2006-10-04  Darin Adler  <darin@apple.com>
3344
3345         Reviewed by Geoff.
3346
3347         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
3348           Caret disappears when you're typing
3349
3350         * editing/SelectionController.cpp:
3351         (WebCore::SelectionController::setSelection): Remove unnecessary call to
3352         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
3353         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
3354         to false so we can get the old caret repaint rect. Later we need to change the
3355         design so getting the rect doesn't have a side effect of causing a layout without
3356         invalidation.
3357
3358 2006-10-03  David Harrison  <harrison@apple.com>
3359
3360         Reviewed by Maciej.
3361
3362         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
3363
3364         Updated test:
3365         * fast/text/justified-text-rect.html
3366
3367         * bridge/mac/WebCoreFrameBridge.mm:
3368         (-[WebCoreFrameBridge convertToNSRange:]):
3369         (-[WebCoreFrameBridge convertToDOMRange:]):
3370         Make the selection's root editable element (or the document itself) be
3371         the basis for NSRange conversions. This supports "shadow DOM" like
3372         that for text fields and text areas.
3373         
3374         * editing/CompositeEditCommand.cpp:
3375         (WebCore::CompositeEditCommand::moveParagraphs):
3376         Pass the document element as the scope.
3377         
3378         * editing/TextIterator.cpp:
3379         (WebCore::TextIterator::rangeFromLocationAndLength):
3380         Make the first parameter the scope.
3381         
3382         * editing/TextIterator.h:
3383         Make the first parameter of rangeFromLocationAndLength() the scope.
3384
3385 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
3386
3387         Reviewed by Eric.
3388
3389         Fix Qt/Linux build.
3390
3391         * CMakeLists.txt: Add counter related files.
3392
3393 2006-10-03  Mark Rowe  <bdash@webkit.org>
3394
3395         Reviewed by Eric.
3396
3397         http://bugs.webkit.org/show_bug.cgi?id=10981
3398         Linux/GDK build fixes
3399
3400         Based on a patch by Krzysztof Kowalczyk.
3401
3402         * WebCoreSources.bkl:
3403         * platform/gdk/FrameGdk.cpp:
3404         (WebCore::doScroll):
3405         (WebCore::FrameGdk::handleGdkEvent):
3406         * platform/gdk/PlatformScrollBar.h: Added.
3407         (WebCore::PlatformScrollBar::isWidget):
3408         * platform/gdk/ScrollViewGdk.cpp:
3409         * platform/gdk/TemporaryLinkStubs.cpp:
3410         (FrameView::passMousePressEventToScrollbar):
3411         (FrameView::passMousePressEventToSubframe):
3412         (FrameView::passMouseReleaseEventToSubframe):
3413         (FrameView::passMouseMoveEventToSubframe):
3414         (FrameView::passWheelEventToSubframe):
3415         (Cursor::Cursor):
3416         (Widget::invalidate):
3417         (Widget::invalidateRect):
3418         (ScrollView::wheelEvent):
3419         (ScrollView::convertToContainingWindow):
3420         (ScrollView::convertFromContainingWindow):
3421         (GraphicsContext::clip):
3422         (PlatformScrollBar::PlatformScrollBar):
3423         (PlatformScrollBar::updateThumbPosition):
3424         (PlatformScrollBar::updateThumbProportion):
3425         (ScrollBar::ScrollBar):
3426         (ScrollBar::setProportion):
3427         (WebCore::supportedKeySizes):
3428         (WebCore::signedPublicKeyAndChallengeString):
3429         * platform/gdk/WheelEventGdk.cpp:
3430         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3431         * platform/gdk/WidgetGdk.cpp:
3432         (WebCore::Widget::convertToContainingWindow):
3433         (WebCore::Widget::convertFromContainingWindow):
3434
3435 2006-10-02  Adam Roben  <aroben@apple.com>
3436
3437         Reviewed by Maciej.
3438
3439         Let Windows determine which mouse button is pressed.
3440
3441         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
3442         * platform/win/MouseEventWin.cpp:
3443         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
3444         parameter to determine which mouse button is pressed.
3445
3446 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3447
3448         Reviewed by anders
3449         
3450         Build fix
3451         
3452         * editing/SelectionController.cpp:
3453         (WebCore::SelectionController::empty):
3454         * editing/SelectionController.h:
3455
3456 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3457
3458         Reviewed by john
3459         
3460         <rdar://problem/4755287>
3461         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
3462
3463         * editing/markup.cpp:
3464         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
3465         elements).  Don't skip blocks that aren't containers (like horizontal rules).
3466
3467 2006-10-03  Darin Adler  <darin@apple.com>
3468
3469         Reviewed by Justin Garcia.
3470
3471         - correct mistaken code that would restart blinking every
3472           time "invalidateSelection" is called even if the caret
3473           has not moved
3474
3475         * editing/SelectionController.h:
3476         * editing/SelectionController.cpp:
3477         (WebCore::SelectionController::setSelection): Update for name change.
3478         (WebCore::SelectionController::recomputeCaretRect): New function.
3479         Computes caret rect and does any necessary invalidation if the rect
3480         changes.
3481         (WebCore::SelectionController::invalidateCaretRect): Renamed from
3482         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
3483         calls recomputeCaretRect as a side effect.
3484
3485         * page/Frame.cpp:
3486         (WebCore::Frame::invalidateSelection): Remove unneeded call to
3487         clearCaretRectIfNeeded.
3488         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
3489         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
3490         recomputeCaretRect function and not restart blinking if caret has
3491         not changed position.
3492         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
3493         are not needed since selectionLayoutChanged already checks these.
3494
3495         * page/FramePrivate.h: Removed unused m_blinkCaret.
3496
3497 2006-10-02  Beth Dakin  <bdakin@apple.com>
3498
3499         Reviewed by Adam.
3500
3501         Build fix. Add counters to vcproj.
3502
3503         * WebCore.vcproj/WebCore/WebCore.vcproj:
3504
3505 2006-10-02  Brady Eidson  <beidson@apple.com>
3506
3507         Reviewed by Adele
3508
3509         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
3510         icon data out because we don't correctly check SQL error conditions.
3511
3512         * loader/icon/IconDataCache.cpp:
3513         (WebCore::IconDataCache::writeToDatabase):
3514
3515 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
3516
3517         Reviewed by Hyatt.
3518
3519         Added method to find out whether a layout has occurred.
3520
3521         * page/FrameView.cpp:
3522         (WebCore::FrameView::didFirstLayout):
3523         * page/FrameView.h:
3524
3525 2006-10-02  Beth Dakin  <bdakin@apple.com>
3526
3527         Reviewed by Darin.
3528
3529         Initial implementation of CSS2 counters. See http://
3530         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
3531
3532         * WebCore.xcodeproj/project.pbxproj:
3533         * css/CSSComputedStyleDeclaration.cpp: 
3534         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
3535         the increment/reset list now that this is implemented.
3536         * css/CSSPrimitiveValue.cpp:
3537         (WebCore::CSSPrimitiveValue::cssText): 
3538         * css/Counter.h:
3539         (WebCore::Counter::Counter):
3540         (WebCore::Counter::~Counter):
3541         (WebCore::Counter::identifier):
3542         (WebCore::Counter::listStyle):
3543         (WebCore::Counter::separator):
3544         (WebCore::Counter::listStyleNumber):
3545         (WebCore::Counter::setIdentifier):
3546         (WebCore::Counter::setListStyle):
3547         (WebCore::Counter::setSeparator):
3548         * css/cssparser.cpp:
3549         (WebCore::CSSParser::addProperty): Take care of reset/increment
3550         (WebCore::CSSParser::parseValue):
3551         (WebCore::CSSParser::parseContent): content can now take counters
3552         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
3553         counters()
3554         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
3555         counter-increment
3556         * css/cssparser.h:
3557         * css/cssstyleselector.cpp:
3558         (WebCore::CSSStyleSelector::matchUARules):
3559         (WebCore::CSSStyleSelector::applyProperty):
3560         * platform/PlatformString.h:
3561         * platform/String.cpp:
3562         (WebCore::String::insert): Implemented a version of insert that 
3563         accepts a UChar* and a length.
3564         * platform/StringImpl.cpp:
3565         (WebCore::StringImpl::insert): Same as above.
3566         * platform/StringImpl.h:
3567         * rendering/CounterListItem.h: Added.
3568         * rendering/CounterNode.cpp: Added.
3569         (WebCore::CounterNode::CounterNode):
3570         (WebCore::CounterNode::insertAfter):
3571         (WebCore::CounterNode::removeChild):
3572         (WebCore::CounterNode::remove):
3573         (WebCore::CounterNode::setUsesSeparator):
3574         (WebCore::CounterNode::recountAndGetNext):
3575         (WebCore::CounterNode::recountTree):
3576         (WebCore::CounterNode::setSelfDirty):
3577         (WebCore::CounterNode::setParentDirty):
3578         * rendering/CounterNode.h: Added.
3579         (WebCore::CounterNode::~CounterNode):
3580         (WebCore::CounterNode::parent):
3581         (WebCore::CounterNode::previousSibling):
3582         (WebCore::CounterNode::nextSibling):
3583         (WebCore::CounterNode::firstChild):
3584         (WebCore::CounterNode::lastChild):
3585         (WebCore::CounterNode::value):
3586         (WebCore::CounterNode::setValue):
3587         (WebCore::CounterNode::count):
3588         (WebCore::CounterNode::setCount):
3589         (WebCore::CounterNode::setHasSeparator):
3590         (WebCore::CounterNode::isReset):
3591         (WebCore::CounterNode::hasSeparator):
3592         (WebCore::CounterNode::willNeedLayout):
3593         (WebCore::CounterNode::setWillNeedLayout):
3594         (WebCore::CounterNode::isRoot):
3595         (WebCore::CounterNode::setRenderer):
3596         (WebCore::CounterNode::renderer):
3597         * rendering/CounterResetNode.cpp: Added.
3598         (WebCore::CounterResetNode::CounterResetNode):
3599         (WebCore::CounterResetNode::insertAfter):
3600         (WebCore::CounterResetNode::removeChild):
3601         (WebCore::CounterResetNode::recountAndGetNext):
3602         (WebCore::CounterResetNode::setParentDirty):
3603         (WebCore::CounterResetNode::updateTotal):
3604         * rendering/CounterResetNode.h: Added.
3605         (WebCore::CounterResetNode::firstChild):
3606         (WebCore::CounterResetNode::lastChild):
3607         (WebCore::CounterResetNode::isReset):
3608         (WebCore::CounterResetNode::total):
3609         * rendering/RenderContainer.cpp:
3610         (WebCore::RenderContainer::updatePseudoChildForObject): Account for 
3611         counter content.
3612         * rendering/RenderCounter.cpp: Added.
3613         (WebCore::RenderCounter::RenderCounter):
3614         (WebCore::RenderCounter::layout):
3615         (WebCore::toRoman):
3616         (WebCore::toLetterString):
3617         (WebCore::toHebrew):
3618         (WebCore::RenderCounter::convertValueToType):
3619         (WebCore::RenderCounter::calcMinMaxWidth):
3620         * rendering/RenderCounter.h: Added.
3621         (WebCore::RenderCounter::renderName):
3622         (WebCore::RenderCounter::isCounter):
3623         * rendering/RenderObject.cpp:
3624         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to 
3625         maps of CounterNodes
3626         (WebCore::RenderObject::RenderObject):
3627         (WebCore::RenderObject::destroy): Destroy the maps.
3628         (WebCore::RenderObject::findCounter): Finds/creates counters.
3629         * rendering/RenderObject.h:
3630         (WebCore::RenderObject::isCounter):
3631         * rendering/RenderStyle.cpp:
3632         (WebCore::StyleVisualData::StyleVisualData):
3633         (WebCore::RenderStyle::arenaDelete):
3634         (WebCore::RenderStyle::RenderStyle):
3635         (WebCore::RenderStyle::diff):
3636         (WebCore::RenderStyle::setContent):
3637         (WebCore::ContentData::clearContent):
3638         (WebCore::RenderStyle::counterDataEquivalent):
3639         (WebCore::hasCounter):
3640         (WebCore::RenderStyle::hasCounterReset):
3641         (WebCore::RenderStyle::hasCounterIncrement):
3642         (WebCore::readCounter):
3643         (WebCore::RenderStyle::counterReset):
3644         (WebCore::RenderStyle::counterIncrement):
3645         * rendering/RenderStyle.h:
3646         (WebCore::StyleVisualData::operator==):
3647         (WebCore::CounterData::CounterData):
3648         (WebCore::CounterData::identifier):
3649         (WebCore::CounterData::listStyle):
3650         (WebCore::CounterData::separator):
3651         (WebCore::ContentData::contentCounter):
3652         (WebCore::ContentData::):
3653         (WebCore::RenderStyle::counterIncrement):
3654         (WebCore::RenderStyle::counterReset):
3655         (WebCore::RenderStyle::setCounterIncrement):
3656         (WebCore::RenderStyle::setCounterReset):
3657         (WebCore::RenderStyle::setCounterResetList):
3658         (WebCore::RenderStyle::setCounterIncrementList):
3659         (WebCore::RenderStyle::counterResetValueList):
3660         (WebCore::RenderStyle::counterIncrementValueList):
3661
3662 2006-10-02  Adele Peterson  <adele@apple.com>
3663
3664         Reviewed by Adam.
3665
3666         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
3667
3668         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
3669         by using "-webkit-appearance:none".
3670
3671         * css/html4.css:
3672
3673 2006-10-02  David Harrison  <harrison@apple.com>
3674
3675         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
3676         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
3677         Left the layout test.
3678         
3679         * rendering/bidi.cpp:
3680         (WebCore::checkMidpoints):
3681
3682 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
3683
3684         Reviewed by eseidel.  Landed by eseidel.
3685
3686         Fix Qt/Linux build.
3687
3688         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
3689         (WebCore::supportedKeySizes):
3690
3691 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
3692
3693         Reviewed by eseidel & mjs.  Landed by eseidel.
3694
3695         Fix Qt/Linux build with older gcc 3.3.4.
3696         http://bugs.webkit.org/show_bug.cgi?id=11116
3697
3698         As discussed with Maciej, the GCC_ROOT_NS_HACK
3699         can be completely removed, as well as the friendship
3700         between cacheGlobalObject & the JS* objects.
3701
3702         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
3703         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
3704         (png_read_filter_row_mmx_avg):
3705         * platform/image-decoders/png/pngvcrd.c: Ditto.
3706         (png_mmx_support):
3707         (png_read_filter_row_mmx_avg):
3708
3709 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
3710
3711         Rubber stamped by Alexey.
3712
3713         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
3714
3715         * css/CSSGrammar.y:
3716
3717 2006-10-01  Eric Seidel  <eric@webkit.org>
3718
3719         Reviewed by mjs.
3720
3721         Eliminate a few more hotspots in SVG drawing code.
3722         
3723         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
3724
3725         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3726         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
3727         * platform/mac/ColorMac.mm:
3728         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
3729
3730 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
3731
3732         Reviewed by Maciej.
3733         
3734         More frame/iframe merging.
3735         
3736         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
3737         false, so this was dead code.
3738         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
3739         than attach(), is the correct place for setInViewSourceMode, because
3740         openURL() is the function that creates our frame.
3741         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
3742         code that did the same thing in other places.
3743         - Made FRAME's attach() method suffuciently generic so that IFRAME could
3744         call up to it, rather than skipping its superclass and calling up directly 
3745         to ELEMENT.
3746         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
3747         - Replaced ad hoc frame loading code in FRAME::attach() with call to
3748         openURL(), the designated frame loading function.
3749
3750         Layout tests pass. I added a layout test for viewsource mode, since I
3751         broke it in the course of writing this patch.
3752
3753 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
3754
3755         Reviewed by Geoff.
3756
3757         * dom/Document.cpp:
3758         (WebCore::Document::recalcStyleSelector):
3759         * dom/Document.h:
3760         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
3761         
3762         * dom/Node.h:
3763         Remove DeprecatedStringList class forward declaration.
3764         
3765         * editing/markup.cpp:
3766         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
3767         
3768         * kcanvas/KCanvasTreeDebug.cpp:
3769         * kcanvas/KCanvasTreeDebug.h:
3770         Remove unused functions.
3771         
3772         * loader/loader.cpp:
3773         * page/Frame.cpp:
3774         * page/Frame.h:
3775         * page/FrameView.h:
3776         Fixup DeprecatedStringList.h includes.
3777
3778 2006-09-30  David Harrison  <harrison@apple.com>
3779
3780         Reviewed by John Sullivan.
3781
3782         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
3783
3784         Problem was that the decision to trim was based only on whether the character
3785         is a soft hyphen, which caused pretty much any Japanese character to go.
3786         Changed to decide based on whether the character is ignorable whitespace.
3787         
3788         Test:
3789         * fast/text/international/wrap-CJK-001.html
3790
3791         * rendering/bidi.cpp:
3792         (WebCore::isTrimmableChar):
3793         New. Checks whether character is whitespace that can be ignored
3794         according to the text node's style.
3795         trimmed from the end of wrapped line.
3796         (WebCore::checkMidpoints):
3797         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
3798
3799 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
3800
3801         Reviewed by Mitz Pettel.
3802
3803         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
3804
3805         * ksvg2/svg/SVGColor.cpp:
3806         (WebCore::SVGColor::setRGBColor):
3807         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3808         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3809         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
3810         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3811         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
3812         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3813         (SVGFESpecularLightingElement::parseMappedAttribute):
3814         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3815         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
3816         * ksvg2/svg/SVGLengthList.cpp:
3817         * ksvg2/svg/SVGNumberList.cpp:
3818         (SVGNumberList::parse):
3819         * ksvg2/svg/SVGNumberList.h:
3820         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
3821         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
3822         * ksvg2/svg/SVGStringList.cpp:
3823         (WebCore::SVGStringList::reset):
3824         * ksvg2/svg/SVGStringList.h:
3825         * ksvg2/svg/SVGTransformable.cpp:
3826         (SVGTransformable::parseTransformAttribute):
3827
3828 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
3829
3830         Reviewed by Eric, tweaked and landed by ap.
3831
3832         Fix Qt/Linux build.
3833
3834         * CMakeLists.txt:
3835         * platform/qt/PlatformScrollBar.h:
3836         * platform/qt/TemporaryLinkStubs.cpp:
3837         (WebCore::ScrollBar::ScrollBar):
3838         (WebCore::PlatformScrollBar::PlatformScrollBar):
3839         (FrameView::passMousePressEventToSubframe):
3840         (FrameView::passMouseMoveEventToSubframe):
3841         (FrameView::passMouseReleaseEventToSubframe):
3842         (FrameView::passWheelEventToSubframe):
3843         (FrameView::passMousePressEventToScrollbar):
3844         * ksvg2/svg/SVGDocument.h:
3845
3846 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3847
3848         Reviewed by Darin.
3849
3850         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
3851         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
3852
3853         No test case added (probably requires new DumpRenderTree functionality)
3854
3855         * rendering/RenderImage.cpp:
3856         (WebCore::RenderImage::imageChanged): Added early return if the document is
3857         being destroyed.
3858
3859 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
3860
3861         Reviewed by Hyatt.
3862
3863         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
3864         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
3865         
3866         Make sure we only break after a space (and not any other valid line-break) if
3867         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
3868         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
3869         twice in quick succession.
3870
3871         * rendering/bidi.cpp:
3872         (WebCore::RenderBlock::findNextLineBreak): 
3873
3874 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
3875
3876         Reviewed by Maciej and Darin.
3877
3878         http://bugs.webkit.org/show_bug.cgi?id=4372
3879         JavaScript document.write page form does not submit in Safari
3880
3881         Test: fast/forms/document-write.html
3882
3883         * page/Frame.cpp:
3884         (WebCore::Frame::submitForm): Don't check for parsing().
3885
3886 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
3887
3888         Build fix.
3889
3890         * bridge/mac/FrameViewMac.mm: Add missing #imports.
3891
3892 2006-10-01  Dave Hyatt  <hyatt@apple.com>
3893
3894         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
3895        
3896         Reviewed by mitz
3897
3898         * bridge/mac/FrameMac.mm:
3899         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
3900         * bridge/mac/FrameViewMac.mm:
3901         (WebCore::FrameView::passMousePressEventToScrollbar):
3902         * page/FrameView.cpp:
3903         (WebCore::FrameView::handleMousePressEvent):
3904         (WebCore::FrameView::setMousePressed):
3905         * page/FrameView.h:
3906         * platform/win/TemporaryLinkStubs.cpp:
3907         (FrameView::passMousePressEventToScrollbar):
3908
3909 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
3910
3911         Reviewed by Darin.
3912
3913         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
3914         Add more SVG Objective-C DOM bindings
3915
3916         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
3917           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
3918           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
3919           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
3920           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
3921           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
3922
3923         * DerivedSources.make:
3924         * WebCore.xcodeproj/project.pbxproj:
3925         * bindings/objc/DOMInternal.h:
3926         * bindings/objc/DOMSVG.h:
3927         * bindings/scripts/CodeGeneratorObjC.pm:
3928         * ksvg2/svg/SVGAElement.idl:
3929         * ksvg2/svg/SVGAnimateColorElement.idl:
3930         * ksvg2/svg/SVGAnimateElement.idl:
3931         * ksvg2/svg/SVGAnimateTransformElement.idl:
3932         * ksvg2/svg/SVGAnimatedPathData.idl:
3933         * ksvg2/svg/SVGAnimatedPoints.idl:
3934         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
3935         * ksvg2/svg/SVGAnimationElement.idl:
3936         * ksvg2/svg/SVGCircleElement.idl:
3937         * ksvg2/svg/SVGClipPathElement.idl:
3938         * ksvg2/svg/SVGColor.idl:
3939         * ksvg2/svg/SVGCursorElement.idl:
3940         * ksvg2/svg/SVGDefsElement.idl:
3941         * ksvg2/svg/SVGDescElement.idl:
3942         * ksvg2/svg/SVGDocument.idl:
3943         * ksvg2/svg/SVGEllipseElement.idl:
3944         * ksvg2/svg/SVGPointList.idl:
3945         * ksvg2/svg/SVGPreserveAspectRatio.idl:
3946         * ksvg2/svg/SVGRect.idl:
3947         * ksvg2/svg/SVGSVGElement.idl:
3948
3949 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
3950
3951         Reviewed by Adele.
3952
3953         - fix build
3954
3955         * platform/FloatRect.h:
3956         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
3957         but more appropriate for path-type stuff.
3958         * platform/cg/PathCG.cpp:
3959         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
3960
3961 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
3962
3963         Reviewed by Darin.
3964
3965         http://bugs.webkit.org/show_bug.cgi?id=11011
3966         External CSS is parsed as iso-8859-1 even though the main document is utf-8
3967
3968         Test: fast/encoding/css-charset-default.xhtml
3969
3970         * loader/CachedResourceClient.h:
3971         (WebCore::CachedResourceClient::setCSSStyleSheet):
3972         (WebCore::CachedResourceClient::setXSLStyleSheet):
3973         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
3974         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
3975
3976         * css/CSSImportRule.cpp:
3977         (WebCore::CSSImportRule::setCSSStyleSheet):
3978         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
3979         * css/CSSImportRule.h:
3980
3981         * css/CSSStyleSheet.cpp:
3982         (WebCore::CSSStyleSheet::CSSStyleSheet):
3983         * css/CSSStyleSheet.h:
3984         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
3985         member. Changed some String parameters to const String&.
3986
3987         * css/StyleSheet.cpp:
3988         (WebCore::StyleSheet::StyleSheet):
3989         * css/StyleSheet.h:
3990         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
3991
3992         * css/StyleSheetList.cpp:
3993         (WebCore::StyleSheetList::length):
3994         (WebCore::StyleSheetList::item):
3995         * css/StyleSheetList.h:
3996         Special-casing implicit stylesheets seemed to be dead code, removed.
3997
3998         * dom/Document.cpp:
3999         (WebCore::Document::setCSSStyleSheet):
4000         (WebCore::Document::recalcStyleSelector):
4001         * dom/Document.h:
4002         Renamed setStyleSheet() to setCSSStyleSheet().
4003
4004         * dom/ProcessingInstruction.cpp:
4005         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
4006         (WebCore::ProcessingInstruction::setCSSStyleSheet):
4007         (WebCore::ProcessingInstruction::setXSLStyleSheet):
4008         (WebCore::ProcessingInstruction::parseStyleSheet):
4009         * dom/ProcessingInstruction.h:
4010
4011         * html/HTMLLinkElement.cpp:
4012         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
4013         is not specified.
4014         (WebCore::HTMLLinkElement::setCSSStyleSheet):
4015         * html/HTMLLinkElement.h:
4016
4017         * html/HTMLStyleElement.cpp:
4018         (WebCore::HTMLStyleElement::childrenChanged):
4019         * ksvg2/svg/SVGStyleElement.cpp:
4020         (WebCore::SVGStyleElement::childrenChanged):
4021         Inherit URL and charset from the document.
4022
4023         * loader/Cache.cpp:
4024         (WebCore::Cache::requestCSSStyleSheet):
4025         * loader/Cache.h:
4026         Adjust for setStyleSheet() renaming.
4027
4028         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
4029         * loader/CachedCSSStyleSheet.cpp:
4030         (WebCore::CachedCSSStyleSheet::ref):
4031         (WebCore::CachedCSSStyleSheet::deref):
4032         (WebCore::CachedCSSStyleSheet::checkNotify):
4033         Pass the encoding to setCSSStyleSheet().
4034
4035         * loader/CachedXSLStyleSheet.cpp:
4036         (WebCore::CachedXSLStyleSheet::ref):
4037         (WebCore::CachedXSLStyleSheet::checkNotify):
4038         * loader/DocLoader.cpp:
4039         (WebCore::DocLoader::requestCSSStyleSheet):
4040         * loader/DocLoader.h:
4041         * page/Frame.cpp:
4042         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
4043         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
4044         * xml/XSLImportRule.cpp:
4045         (WebCore::XSLImportRule::setXSLStyleSheet):
4046         (WebCore::XSLImportRule::loadSheet):
4047         * xml/XSLImportRule.h:
4048         Adjust for setStyleSheet() renaming.
4049
4050 2006-09-30  Rob Buis  <buis@kde.org>
4051
4052         Reviewed by eseidel.
4053
4054         http://bugs.webkit.org/show_bug.cgi?id=11096
4055         Hit testing for polylines fails
4056
4057         Fix Path::contains so it handles filled, non-closed paths too.
4058
4059         * platform/cg/PathCG.cpp:
4060         (WebCore::Path::contains):
4061
4062 2006-09-30  Dave Hyatt  <hyatt@apple.com>
4063
4064         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
4065         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
4066         subframes while the mouse is down.
4067       
4068         Reviewed by mitzpettel
4069
4070         * bridge/mac/FrameMac.h:
4071         * bridge/mac/FrameMac.mm:
4072         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
4073         (WebCore::FrameMac::passWheelEventToWidget):
4074         * bridge/mac/FrameViewMac.mm:
4075         (WebCore::FrameView::passMousePressEventToSubframe):
4076         (WebCore::FrameView::passMouseMoveEventToSubframe):
4077         (WebCore::FrameView::passMouseReleaseEventToSubframe):
4078         (WebCore::FrameView::passWheelEventToSubframe):
4079         * page/Frame.cpp:
4080         * page/Frame.h:
4081         * page/FrameView.cpp:
4082         (WebCore::subframeForTargetNode):
4083         (WebCore::FrameView::handleMousePressEvent):
4084         (WebCore::FrameView::handleMouseDoubleClickEvent):
4085         (WebCore::FrameView::handleMouseMoveEvent):
4086         (WebCore::FrameView::handleMouseReleaseEvent):
4087         (WebCore::FrameView::handleWheelEvent):
4088         * page/FrameView.h:
4089         * platform/ScrollBar.h:
4090         (WebCore::ScrollBar::handleMouseMoveEvent):
4091         (WebCore::ScrollBar::handleMouseOutEvent):
4092         * platform/Widget.h:
4093         (WebCore::Widget::handleMouseMoveEvent):
4094         (WebCore::Widget::handleMouseReleaseEvent):
4095         * platform/win/TemporaryLinkStubs.cpp:
4096         (FrameView::passMousePressEventToSubframe):
4097         (FrameView::passMouseMoveEventToSubframe):
4098         (FrameView::passMouseReleaseEventToSubframe):
4099         (FrameView::passWheelEventToSubframe):
4100         (Widget::capturingMouse):
4101         (Widget::setCapturingMouse):
4102         (Widget::capturingTarget):
4103         (Widget::capturingChild):
4104         (Widget::setCapturingChild):
4105         * rendering/RenderView.cpp:
4106         (WebCore::RenderView::paintBoxDecorations):
4107
4108 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
4109
4110         Reviewed by Adele.
4111
4112         Fixes windows bustage:
4113         http://bugs.webkit.org/show_bug.cgi?id=11093
4114
4115         * platform/win/PlatformScrollBar.h:
4116         * platform/win/TemporaryLinkStubs.cpp:
4117         (PlatformScrollBar::PlatformScrollBar):
4118         (ScrollBar::ScrollBar):
4119
4120 2006-09-29  David Hyatt  <hyatt@apple.com>
4121
4122         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
4123         in RenderObject::NodeInfo (and then propagating that Widget to
4124         MouseEventWithHitTestResults).
4125
4126         This allows RenderListBox and RenderBlock to do the same thing when the
4127         mouse is over the scrollbar.
4128
4129         Also land fix to support font-size: 0.
4130
4131         Reviewed by mjs (scrollbar), eric (font-size)
4132
4133         * dom/Document.cpp:
4134         (WebCore::Document::prepareMouseEvent):
4135         * page/Frame.cpp:
4136         (WebCore::Frame::passWidgetMouseDownEventToWidget):
4137         * page/FrameView.cpp:
4138         (WebCore::selectCursor):
4139         (WebCore::FrameView::handleMouseMoveEvent):
4140         (WebCore::FrameView::dispatchMouseEvent):
4141         * page/MouseEventWithHitTestResults.cpp:
4142         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
4143         * page/MouseEventWithHitTestResults.h:
4144         (WebCore::MouseEventWithHitTestResults::scrollbar):
4145         * rendering/RenderBlock.cpp:
4146         (WebCore::RenderBlock::isPointInScrollbar):
4147         (WebCore::RenderBlock::nodeAtPoint):
4148         * rendering/RenderBlock.h:
4149         * rendering/RenderLayer.cpp:
4150         (WebCore::RenderLayer::hitTest):
4151         * rendering/RenderLayer.h:
4152         (WebCore::RenderLayer::getHiddenBehavior):
4153         * rendering/RenderListBox.cpp:
4154         (WebCore::RenderListBox::RenderListBox):
4155         (WebCore::RenderListBox::~RenderListBox):
4156         (WebCore::RenderListBox::isPointInScrollbar):
4157         * rendering/RenderListBox.h:
4158         * rendering/RenderObject.h:
4159         (WebCore::RenderObject::NodeInfo::NodeInfo):
4160         (WebCore::RenderObject::NodeInfo::scrollbar):
4161         (WebCore::RenderObject::NodeInfo::setScrollbar):
4162
4163 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
4164
4165         Reviewed by Adele.
4166
4167         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
4168
4169         * platform/win/ScrollViewWin.cpp:
4170         (WebCore::ScrollView::convertToContainingWindow):
4171         (WebCore::ScrollView::convertFromContainingWindow):
4172         * platform/win/WidgetWin.cpp:
4173         (WebCore::Widget::convertToContainingWindow):
4174         (WebCore::Widget::convertFromContainingWindow):
4175
4176 2006-09-29  Adele Peterson  <adele@apple.com>
4177
4178         Updated with new argument for PlatformScrollBar.
4179
4180         * platform/win/TemporaryLinkStubs.cpp:
4181         (PlatformScrollBar::PlatformScrollBar):
4182
4183 2006-09-29  Adele Peterson  <adele@apple.com>
4184
4185         Reviewed by Hyatt.
4186
4187         Fixing build bustage with cast to int.
4188
4189         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
4190
4191 2006-09-29  Adele Peterson  <adele@apple.com>
4192
4193         Fixing accidental include.
4194
4195         * rendering/RenderListBox.cpp:
4196
4197 2006-09-29  Adele Peterson  <adele@apple.com>
4198
4199         Adding RenderListBox files.
4200
4201         * WebCore.vcproj/WebCore/WebCore.vcproj:
4202
4203 2006-09-29  Adele Peterson  <adele@apple.com>
4204
4205         Reviewed by Adam.
4206
4207         Initial implementation of engine-based list box control.
4208
4209         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
4210
4211         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
4212         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
4213         (WebCore::FrameMac::FrameMac):
4214         (WebCore::FrameMac::handleMousePressEvent):
4215         (WebCore::FrameMac::handleMouseMoveEvent):
4216         (WebCore::FrameMac::mouseDown):
4217
4218         * page/Frame.cpp:
4219         (WebCore::Frame::handleMouseMoveEvent):
4220         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
4221         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
4222         (WebCore::Frame::autoscrollTimerFired): ditto.
4223         (WebCore::Frame::stopAutoscrollTimer): ditto.
4224         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
4225         * page/Frame.h:
4226         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
4227
4228         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
4229         (WebCore::FrameViewPrivate::reset):
4230         (WebCore::FrameView::currentMousePosition):
4231         (WebCore::FrameView::handleMousePressEvent):
4232         (WebCore::FrameView::handleMouseDoubleClickEvent):
4233         (WebCore::selectCursor):
4234         (WebCore::FrameView::handleMouseMoveEvent):
4235         (WebCore::FrameView::handleMouseReleaseEvent):
4236         * page/FrameView.h:
4237
4238         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
4239         * platform/ScrollBar.h:
4240         (WebCore::):
4241         (WebCore::ScrollBar::controlSize):
4242         * platform/mac/PlatformScrollBar.h:
4243         * platform/mac/PlatformScrollBarMac.mm:
4244         (NSControlSizeForScrollBarControlSize):
4245         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
4246         (WebCore::PlatformScrollBar::PlatformScrollBar):
4247
4248         * rendering/RenderBlock.h:
4249         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
4250         * rendering/RenderLayer.h:
4251         * rendering/RenderObject.cpp:
4252         (WebCore::RenderObject::shouldAutoscroll):
4253         (WebCore::RenderObject::autoscroll):
4254         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
4255
4256      &nb