Reviewed by ap.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-08-24  Nikolas Zimmermann  <zimmermann@kde.org>
2
3         Reviewed by ap.
4
5         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
6         WebKit should have Qt platform support (Part II)
7
8         Adapt the KCanvas Qt device to Rob's KCanvasMatrix removal.
9         Use AffineTransform everywhere instead.
10
11         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
12         (WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt):
13         (WebCore::KRenderingDeviceContextQt::concatCTM):
14         (WebCore::KRenderingDeviceContextQt::ctm):
15         * kcanvas/device/qt/KRenderingDeviceQt.h:
16         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
17         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
18         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
19
20 2006-08-24  Rob Buis  <buis@kde.org>
21
22         Reviewed by Darin.
23
24         http://bugzilla.opendarwin.org/show_bug.cgi?id=10524
25         svg transform: comma delimiting breaks display
26
27         Properly parse transforms which use ',' as seperators.
28
29         * ksvg2/svg/SVGTransformable.cpp:
30         (SVGTransformable::parseTransformAttribute):
31
32 2006-08-23  Darin Adler  <darin@apple.com>
33
34         Reviewed by Maciej.
35
36         - added an assert to make it slightly easier to debug the common case of
37           calling document() on a node of 0
38
39         * dom/Node.h: (WebCore::Node::document): ASSERT(this).
40
41 2006-08-23  David Hyatt  <hyatt@apple.com>
42
43         Refactor Cairo and CoreGraphics to use platform ifdefs.  This patch
44         separates the graphics engines from their respective platforms and replaces
45         #ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).
46
47         Reviewed by darin
48
49         * WebCore.xcodeproj/project.pbxproj:
50         * platform/AffineTransform.h:
51         * platform/Color.h:
52         * platform/Cursor.h:
53         * platform/FloatPoint.h:
54         * platform/FloatRect.h:
55         * platform/FloatSize.h:
56         * platform/Font.h:
57         * platform/FontData.h:
58         * platform/GlyphBuffer.h:
59         (WebCore::GlyphBuffer::glyphAt):
60         (WebCore::GlyphBuffer::advanceAt):
61         (WebCore::GlyphBuffer::add):
62         * platform/GraphicsContext.h:
63         * platform/Image.h:
64         * platform/ImageSource.h:
65         * platform/IntPoint.h:
66         * platform/IntRect.h:
67         * platform/IntSize.h:
68         * platform/ResourceLoader.h:
69         * platform/ResourceLoaderClient.h:
70         * platform/Widget.h:
71         * platform/cairo/GraphicsContextCairo.cpp:
72         * platform/cairo/ImageCairo.cpp:
73         * platform/cairo/ImageSourceCairo.cpp:
74         * platform/cg/AffineTransformCG.cpp:
75         * platform/cg/FloatPointCG.cpp: Added.
76         * platform/cg/FloatRectCG.cpp: Added.
77         * platform/cg/FloatSizeCG.cpp: Added.
78         * platform/cg/GraphicsContextCG.cpp:
79         (WebCore::GraphicsContext::GraphicsContext):
80         (WebCore::GraphicsContext::~GraphicsContext):
81         (WebCore::GraphicsContext::setFocusRingClip):
82         (WebCore::GraphicsContext::clearFocusRingClip):
83         (WebCore::GraphicsContext::platformContext):
84         (WebCore::GraphicsContext::drawRect):
85         (WebCore::GraphicsContext::drawLine):
86         * platform/cg/GraphicsContextPlatformPrivate.h: Added.
87         (WebCore::GraphicsContextPlatformPrivate:::m_cgContext):
88         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
89         * platform/cg/ImageCG.cpp: Added.
90         (WebCore::Image::drawTiled):
91         * platform/cg/ImageSourceCG.cpp: Added.
92         * platform/cg/IntPointCG.cpp: Added.
93         * platform/cg/IntRectCG.cpp: Added.
94         * platform/cg/IntSizeCG.cpp: Added.
95         * platform/cg/PDFDocumentImage.cpp: Added.
96         (WebCore::PDFDocumentImage::adjustCTM):
97         * platform/cg/PDFDocumentImage.h: Added.
98         * platform/cg/PathCG.cpp:
99         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
100         * platform/image-decoders/gif/GIFImageDecoder.cpp:
101         * platform/image-decoders/gif/GIFImageReader.cpp:
102         * platform/image-decoders/ico/ICOImageDecoder.cpp:
103         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
104         * platform/image-decoders/png/PNGImageDecoder.cpp:
105         * platform/image-decoders/xbm/XBMImageDecoder.cpp:
106         * platform/mac/FloatPointMac.mm:
107         * platform/mac/FloatRectMac.mm:
108         * platform/mac/FloatSizeMac.mm:
109         * platform/mac/GraphicsContextMac.mm:
110         * platform/mac/ImageMac.mm:
111         * platform/mac/ImageSourceMac.cpp: Removed.
112         * platform/mac/IntPointMac.mm:
113         * platform/mac/IntRectMac.mm:
114         * platform/mac/IntSizeMac.mm:
115         * platform/mac/PDFDocumentImage.h: Removed.
116         * platform/mac/PDFDocumentImage.mm: Removed.
117
118 2006-08-23  David Hyatt  <hyatt@apple.com>
119
120         Remove the ifdef for platform scrollbars vs. engine scrollbars until
121         engine scrollbars actually exist.
122
123         * platform/ScrollBar.h:
124         (WebCore::ScrollBar::hasPlatformScrollBars):
125
126 2006-08-23  Justin Garcia  <justin.garcia@apple.com>
127
128         Reviewed by harrison
129         
130         Removed the poorly named next/previousVisiblePosition
131         and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
132         Removed the unused VisiblePosition::maxOffset()
133
134         * editing/VisiblePosition.cpp:
135         (WebCore::VisiblePosition::next):
136         (WebCore::VisiblePosition::previous):
137         (WebCore::VisiblePosition::canonicalPosition):
138         * editing/VisiblePosition.h: 
139
140 2006-08-23  Nikolas Zimmermann  <zimmermann@kde.org>
141
142         Reviewed by Alexey. Landed by rwlbuis.
143
144         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
145         WebKit should have Qt platform support (Part II)
146
147         * platform/qt/GraphicsContextQt.cpp: Added.
148         (WebCore::toQtCompositionMode):
149         (WebCore::toQtLineCap):
150         (WebCore::toQtLineJoin):
151         (WebCore::TransparencyLayer::TransparencyLayer):
152         (WebCore::TransparencyLayer::cleanup):
153         (WebCore::TextShadow::TextShadow):
154         (WebCore::TextShadow::isNull):
155         (WebCore::GraphicsContextPlatformPrivate::p):
156         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
157         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
158         (WebCore::GraphicsContext::GraphicsContext):
159         (WebCore::GraphicsContext::~GraphicsContext):
160         (WebCore::GraphicsContext::platformContext):
161         (WebCore::GraphicsContext::savePlatformState):
162         (WebCore::GraphicsContext::restorePlatformState):
163         (WebCore::GraphicsContext::drawRect):
164         (WebCore::adjustLineToPixelBounderies):
165         (WebCore::GraphicsContext::drawLine):
166         (WebCore::GraphicsContext::drawEllipse):
167         (WebCore::GraphicsContext::drawArc):
168         (WebCore::GraphicsContext::drawConvexPolygon):
169         (WebCore::GraphicsContext::fillRect):
170         (WebCore::GraphicsContext::addClip):
171         (WebCore::GraphicsContext::drawFocusRing):
172         (WebCore::GraphicsContext::setFocusRingClip):
173         (WebCore::GraphicsContext::clearFocusRingClip):
174         (WebCore::GraphicsContext::drawLineForText):
175         (WebCore::GraphicsContext::drawLineForMisspelling):
176         (WebCore::GraphicsContext::roundToDevicePixels):
177         (WebCore::GraphicsContext::setShadow):
178         (WebCore::GraphicsContext::clearShadow):
179         (WebCore::GraphicsContext::beginTransparencyLayer):
180         (WebCore::GraphicsContext::endTransparencyLayer):
181         (WebCore::GraphicsContext::clearRect):
182         (WebCore::GraphicsContext::strokeRect):
183         (WebCore::GraphicsContext::setLineWidth):
184         (WebCore::GraphicsContext::setLineCap):
185         (WebCore::GraphicsContext::setLineJoin):
186         (WebCore::GraphicsContext::setMiterLimit):
187         (WebCore::GraphicsContext::setAlpha):
188         (WebCore::GraphicsContext::setCompositeOperation):
189         (WebCore::GraphicsContext::clip):
190         (WebCore::GraphicsContext::translate):
191         (WebCore::GraphicsContext::rotate):
192         (WebCore::GraphicsContext::scale):
193         (WebCore::GraphicsContext::addInnerRoundedRectClip):
194         (WebCore::GraphicsContext::addRoundedRectClip):
195         (WebCore::GraphicsContext::createRenderingDeviceContext):
196         * platform/qt/ImageQt.cpp: Added.
197         (WebCore::FrameData::clear):
198         (WebCore::Image::initNativeData):
199         (WebCore::Image::destroyNativeData):
200         (WebCore::Image::invalidateNativeData):
201         (WebCore::Image::loadResource):
202         (WebCore::Image::supportsType):
203         (WebCore::Image::draw):
204         (WebCore::Image::drawTiled):
205         (WebCore::Image::checkForSolidColor):
206         * platform/qt/ImageSourceQt.cpp: Added.
207         (WebCore::createDecoder):
208         (WebCore::ImageSource::ImageSource):
209         (WebCore::ImageSource::~ImageSource):
210         (WebCore::ImageSource::initialized):
211         (WebCore::ImageSource::setData):
212         (WebCore::ImageSource::isSizeAvailable):
213         (WebCore::ImageSource::size):
214         (WebCore::ImageSource::repetitionCount):
215         (WebCore::ImageSource::frameCount):
216         (WebCore::ImageSource::createFrameAtIndex):
217         (WebCore::ImageSource::frameDurationAtIndex):
218         (WebCore::ImageSource::frameHasAlphaAtIndex):
219
220 2006-08-23  Brady Eidson  <beidson@apple.com>
221
222         Reviewed by Adele
223
224         Moved default URL icon from WebKit to WebCore
225
226         * Resources/urlIcon.tiff: Added.
227         * WebCore.xcodeproj/project.pbxproj:
228         * loader/icon/IconDataCache.cpp:
229         (WebCore::IconDataCache::loadImageFromResource):
230         * loader/icon/IconDataCache.h:
231         * loader/icon/IconDatabase.cpp:
232         (WebCore::IconDatabase::IconDatabase):
233         (WebCore::IconDatabase::defaultIcon):
234         * loader/icon/IconDatabase.h:
235
236 2006-08-23  Adam Roben  <aroben@apple.com>
237
238         Reviewed by Darin, Adele.
239
240         Some popup refactoring/cleanup.
241
242         * html/HTMLSelectElement.cpp:
243         (WebCore::HTMLSelectElement::defaultEventHandler):
244         * rendering/RenderMenuList.cpp:
245         (WebCore::RenderMenuList::RenderMenuList):
246         (WebCore::RenderMenuList::~RenderMenuList):
247         (WebCore::RenderMenuList::showPopup):
248         (WebCore::RenderMenuList::hidePopup):
249         * rendering/RenderMenuList.h:
250         (WebCore::RenderMenuList::popup):
251         (WebCore::RenderMenuList::popupIsVisible):
252         * rendering/RenderPopupMenu.h:
253         * rendering/RenderPopupMenuMac.h:
254         (WebCore::RenderPopupMenuMac::hidePopup):
255
256 2006-08-23  Nikolas Zimmermann  <zimmermann@kde.org>
257
258         Reviewed by Anders. Landed by rwlbuis.
259
260         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
261         WebKit should have Qt platform support
262
263         * platform/qt/ResourceLoaderCurl.cpp: Added.
264         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
265         (WebCore::ResourceLoader::~ResourceLoader):
266         (WebCore::ResourceLoader::start):
267         (WebCore::ResourceLoader::cancel):
268         (WebCore::ResourceLoader::assembleResponseHeaders):
269         (WebCore::ResourceLoader::retrieveCharset):
270         (WebCore::ResourceLoader::receivedResponse):
271         * platform/qt/ResourceLoaderManager.cpp: Added.
272         (WebCore::ResourceLoaderManager::ResourceLoaderManager):
273         (WebCore::ResourceLoaderManager::get):
274         (WebCore::ResourceLoaderManager::useSimpleTransfer):
275         (WebCore::writeCallback):
276         (WebCore::headerCallback):
277         (WebCore::ResourceLoaderManager::downloadTimerCallback):
278         (WebCore::ResourceLoaderManager::remove):
279         (WebCore::ResourceLoaderManager::add):
280         (WebCore::ResourceLoaderManager::cancel):
281         * platform/qt/ResourceLoaderManager.h: Added.
282         * platform/qt/StringQt.cpp: Added.
283         (WebCore::String::String):
284         (WebCore::String::operator QString):
285         (WebCore::DeprecatedString::operator QString):
286
287 2006-08-23  Brady Eidson  <beidson@apple.com>
288
289         Reviewed by Maciej
290
291         Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries
292
293         * WebCore.xcodeproj/project.pbxproj: Reordered some files
294         * loader/icon/IconDataCache.cpp: Use the new escapeSQLString()
295         (WebCore::IconDataCache::writeToDatabase):
296         * loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout
297         (WebCore::IconDatabase::retainIconURL):
298         (WebCore::IconDatabase::releaseIconURL):
299         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
300         (WebCore::IconDatabase::establishIconIDForIconURL):
301         (WebCore::imageDataForIconURLQuery):
302         (WebCore::timeStampForIconURLQuery):
303         (WebCore::iconURLForPageURLQuery):
304         (WebCore::forgetPageURLQuery):
305         (WebCore::setIconIDForPageURLQuery):
306         (WebCore::getIconIDForIconURLQuery):
307         (WebCore::addIconForIconURLQuery):
308         (WebCore::hasIconForIconURLQuery):
309         * loader/icon/SQLDatabase.h:
310         (WebCore::escapeSQLString): Added
311
312 2006-08-22  Maciej Stachowiak  <mjs@apple.com>
313
314         Reviewed by Brady.
315
316         - assorted style cleanup of icon loader code:
317         
318         - wrapped all implementation files in namespace WebCore {} instead of "using namespace WebCore;" at top
319         - split headers to be one per class, to match impl files
320         - made files that are purely local in IconDatabase.cpp static
321         - make each impl file include config.h as first header (and no config.h includes in other headers)
322         - avoid multiple copies of Vector<unsigned char> for image data
323
324         * WebCore.xcodeproj/project.pbxproj:
325         * loader/icon/IconDataCache.cpp:
326         * loader/icon/IconDataCache.h: Added.
327         (WebCore::):
328         (WebCore::IconDataCache::getTimestamp):
329         (WebCore::IconDataCache::setTimestamp):
330         (WebCore::IconDataCache::getIconURL):
331         * loader/icon/IconDatabase.cpp:
332         (WebCore::IconDatabase::imageDataForIconURL):
333         (WebCore::IconDatabase::iconForPageURL):
334         (WebCore::pageURLTableIsEmptyQuery):
335         (WebCore::imageDataForIconURLQuery):
336         (WebCore::timeStampForIconURLQuery):
337         (WebCore::iconURLForPageURLQuery):
338         (WebCore::forgetPageURLQuery):
339         (WebCore::setIconIDForPageURLQuery):
340         (WebCore::getIconIDForIconURLQuery):
341         (WebCore::addIconForIconURLQuery):
342         (WebCore::hasIconForIconURLQuery):
343         * loader/icon/IconDatabase.h:
344         * loader/icon/SQLDatabase.cpp:
345         * loader/icon/SQLDatabase.h:
346         * loader/icon/SQLStatement.cpp:
347         (WebCore::SQLStatement::getColumnBlobAsVector):
348         * loader/icon/SQLStatement.h: Added.
349         (WebCore::SQLStatement::isPrepared):
350         (WebCore::SQLStatement::prepareAndStep):
351         (WebCore::SQLStatement::lastError):
352         (WebCore::SQLStatement::lastErrorMsg):
353         * loader/icon/SQLTransaction.cpp:
354         * loader/icon/SQLTransaction.h: Added.
355
356 2006-08-22  Brady Eidson  <beidson@apple.com>
357
358         Reviewed by Maciej
359
360         The role of the SiteIcon is now the original intention - to be a cache of data relating to an Icon
361         As such, I'm renaming it to IconDataCache.
362         Also, the IconDatabase has to manually set the image data on the IconDataCache and also sets the 
363         TimeStamp when an icon is created or the data is changed.
364         IconDataCache now has a method to write itself *to* a given database, instead of read itself from one.
365         IconDatabase schema changes to have the timestamp set manually instead of via a trigger.
366         The overall purpose of this change is to cache the timestamp, killing off a very common SQL query.
367
368         * WebCore.xcodeproj/project.pbxproj: Renamed a file
369         * loader/icon/IconDataCache.cpp: Added.
370         (IconDataCache::IconDataCache):
371         (IconDataCache::getImage): Now either returns the stored image, or 0 - no attempt to grab data
372         (IconDataCache::manuallySetImageData): Delete the old image and create the new one
373         (IconDataCache::writeToDatabase): Write the current iconURL, data, and timestamp to the given DB
374         (IconDataCache::imageDataStatus): Determine if an IconDataCache is new without data versus actually having null data
375         * loader/icon/IconDatabase.cpp:
376         (WebCore::IconDatabase::createDatabaseTables): Changed DB schema to version 5 (hopefully the final version)
377         (WebCore::IconDatabase::iconForPageURL): 
378         (WebCore::IconDatabase::isIconExpiredForIconURL): Uses the timestamp in the IconDataCache object instead of always querying
379         (WebCore::IconDatabase::getOrCreateIconDataCache): Added, to handle creation of new IconDataCache when appropriate
380         (WebCore::IconDatabase::setIconDataForIconURL): Puts data in SiteIcon then marks it for a future write
381         (WebCore::IconDatabase::syncDatabase): Now syncs SiteIconsPendingUpdate
382         * loader/icon/IconDatabase.h:
383         (WebCore::IconDataCache::getTimestamp):
384         (WebCore::IconDataCache::setTimestamp):
385         * loader/icon/SiteIcon.cpp: Removed.
386
387
388 2006-08-22  Justin Garcia  <justin.garcia@apple.com>
389
390         Reviewed by harrison
391         
392         <http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
393         REGRESSION(r15918): drag-into-marker.html failing
394
395         * editing/ReplaceSelectionCommand.cpp:
396         (WebCore::ReplaceSelectionCommand::doApply): Don't avoid nesting
397         in a list item.
398
399 2006-08-22  Brady Eidson  <beidson@apple.com>
400
401         Reviewed by Kevin
402
403         Added a check in getTIFFRepresentation to not proceed if the frame count is zero
404         This is an error condition that was handled gracefully before - in certain circumstances
405         the call to CGImageDestinationCreateWithData will spam the Console if it is passed null/empty data
406         or invalid data.  This small change bails out before that call if that call will definitely fail
407
408         * platform/mac/ImageMac.mm:
409         (WebCore::Image::getTIFFRepresentation):
410
411 2006-08-22  David Harrison  <harrison@apple.com>
412
413         Backed out my last change (r15966) because it broke lots of layout tests.
414
415         * editing/TextIterator.cpp:
416         (WebCore::TextIterator::advance):
417
418 2006-08-22  Maciej Stachowiak  <mjs@apple.com>
419
420         Reviewed by Anders.
421
422         - added some SPI indirections to support the following in WebKit/Loader:
423             - pull more WebDataSource code into WebFrameLoader
424             - make WebMainResourceLoader not depend on WebKit or on SPI
425
426         * WebCore.exp:
427         * WebCore.xcodeproj/project.pbxproj:
428         * platform/mac/WebCoreSystemInterface.h:
429         * platform/mac/WebCoreSystemInterface.mm:
430
431 2006-08-22  Justin Garcia  <justin.garcia@apple.com>
432
433         Reviewed by harrison
434
435         <rdar://problem/4052343&4052343&4426622> Mail hung on paste text
436         
437         * editing/ReplaceSelectionCommand.cpp:
438         (WebCore::isInterchangeNewlineNode):
439         (WebCore::isInterchangeConvertedSpaceSpan):
440         (WebCore::ReplacementFragment::ReplacementFragment):
441         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Compute the redundant inheritable styles and
442         remove them and remove style nodes and style spans which were only contributing redundant styles.
443         (WebCore::ReplaceSelectionCommand::doApply):
444         * editing/ReplaceSelectionCommand.h:
445
446 2006-08-22  David Harrison  <harrison@apple.com>
447
448         Reviewed by Darin.
449
450         <rdar://problem/4077676> Inline hole line adheres to the Japanese characters in inline hole
451
452         This happens because the underline is always 2 pixels thick, and placed 3 pixels above the bottom of the text box.
453
454         Test case added:
455         * manual-tests/inline-input-marking.html: Added.
456         Check that underlining of the inline input hole does not obscure the glyphs.
457         
458         * rendering/InlineTextBox.cpp:
459         (WebCore::InlineTextBox::paintMarkedTextUnderline):
460         Position underline at bottom of text box.
461         Height of underline is reduced to 1 px when font's descent is less than or equal to 2 px.
462
463 2006-08-22  Rob Buis  <buis@kde.org>
464
465         Reviewed by Eric.
466
467         http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
468         REPRO: SVG crashes inside gradient code
469
470         Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.
471
472         * ksvg2/svg/SVGGradientElement.cpp:
473         (SVGGradientElement::notifyAttributeChange):
474         (SVGGradientElement::resourceNotification):
475
476 2006-08-22  David Harrison  <harrison@apple.com>
477
478         Reviewed by John.
479
480         <rdar://problem/4523606> Represent heading elements in AXAttributedStringForTextMarkerRange
481
482         * bridge/mac/WebCoreAXObject.mm:
483         (headingLevel):
484         (-[WebCoreAXObject headingLevel]):
485         (-[WebCoreAXObject isHeading]):
486         New. Heading level is per the tag (h1 == 1, h2 == 2, etc.)
487         
488         (-[WebCoreAXObject role]):
489         (-[WebCoreAXObject roleDescription]):
490         Add role and roleDescription for headings.
491         
492         (-[WebCoreAXObject value]):
493         Value is the headingLevel.
494         
495         (AXAttributeStringSetHeadingLevel):
496         (AXAttributedStringAppendText):
497         Put text's heading level (if applicable) in the attributes.
498         
499 2006-08-22  David Harrison  <harrison@apple.com>
500
501         Reviewed by John.
502
503         <rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange
504
505         Treat controls as replaced elements, so that AXAttributedStringForTextMarkerRange will, too.
506         
507         * editing/TextIterator.cpp:
508         (WebCore::TextIterator::advance):
509         Include controls.
510
511 2006-08-22  David Harrison  <harrison@apple.com>
512
513         Reviewed by Maciej.
514
515         <rdar://problem/4407336> Some non-text elements return AXTextMarkerRangeForUIElement with equal start and end marker
516
517         * bridge/mac/WebCoreAXObject.mm:
518         (-[WebCoreAXObject textMarkerRange]):
519         Use 0 and maxDeepOffset(), instead of caretMinOffset() and caretMaxRenderedOffset().
520         Check for VisiblePositions being equal.  If so, adjust end one to its next().
521         That happens with, e.g., buttons.
522
523 2006-08-22  Rob Buis  <buis@kde.org>
524
525         Reviewed by Eric.
526
527         http://bugzilla.opendarwin.org/show_bug.cgi?id=10491
528         KCanvasMatrix removal
529
530         Remove KCanvasMatrix from project, using AffineTransform instead.
531
532         * WebCore.xcodeproj/project.pbxproj:
533         * kcanvas/KCanvasMatrix.cpp: Removed.
534         * kcanvas/KCanvasMatrix.h: Removed.
535         * kcanvas/KCanvasResources.cpp:
536         (WebCore::KCanvasMarker::draw):
537         * kcanvas/KCanvasResources.h:
538         * kcanvas/RenderForeignObject.cpp:
539         * kcanvas/RenderPath.h:
540         * kcanvas/RenderSVGContainer.cpp:
541         (WebCore::RenderSVGContainer::viewportTransform):
542         (WebCore::RenderSVGContainer::getAspectRatio):
543         * kcanvas/RenderSVGContainer.h:
544         * kcanvas/RenderSVGText.cpp:
545         * kcanvas/device/KRenderingDevice.h:
546         * kcanvas/device/KRenderingPaintServerGradient.cpp:
547         (WebCore::KRenderingPaintServerGradient::gradientTransform):
548         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
549         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
550         * kcanvas/device/KRenderingPaintServerGradient.h:
551         * kcanvas/device/KRenderingPaintServerPattern.cpp:
552         (WebCore::KRenderingPaintServerPattern::patternTransform):
553         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
554         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
555         * kcanvas/device/KRenderingPaintServerPattern.h:
556         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
557         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
558         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
559         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
560         (WebCore::KRenderingDeviceContextQuartz::concatCTM):
561         (WebCore::KRenderingDeviceContextQuartz::ctm):
562         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
563         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
564         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
565         (WebCore::KRenderingPaintServerPatternQuartz::setup):
566         * kcanvas/device/quartz/QuartzSupport.mm:
567         * ksvg2/misc/KCanvasRenderingStyle.h:
568         * ksvg2/svg/SVGAnimateTransformElement.cpp:
569         * ksvg2/svg/SVGAnimateTransformElement.h:
570         * ksvg2/svg/SVGLinearGradientElement.cpp:
571         (SVGLinearGradientElement::buildGradient):
572         * ksvg2/svg/SVGPatternElement.cpp:
573         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
574         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
575         (WebCore::SVGPatternElement::notifyAttributeChange):
576         * ksvg2/svg/SVGPatternElement.h:
577         * ksvg2/svg/SVGRadialGradientElement.cpp:
578         (WebCore::SVGRadialGradientElement::buildGradient):
579
580 2006-08-22  Rob Buis  <buis@kde.org>
581
582         Reviewed by Eric.
583
584         http://bugzilla.opendarwin.org/show_bug.cgi?id=10405
585         REPRO: SVG Maze crashes in RenderPath code
586
587         Do not render a path when it is empty so maze15.svg does not crash anymore.
588         Also get rid of a runtime warning issued by CGContextGetPathBoundingBox.
589
590         * kcanvas/RenderPath.cpp:
591         (WebCore::RenderPath::paint):
592         * kcanvas/device/quartz/KCanvasPathQuartz.mm:
593         (WebCore::KCanvasPathQuartz::strokeBoundingBox):
594
595 2006-08-21  Brady Eidson  <beidson@apple.com>
596
597         Reviewed by Maciej
598
599         <rdar://4690949> - New IconDB: Need to prune unretained icons on startup
600
601         Added a flag to track whether or not the initial pruning has taken place on startup
602         If that flag is not set, IconURL retain counts will be tracked in a temporary db table
603         in addition to the in-memory hash.  Then when the timer fires after initial retains
604         are complete, we prune those icons not in the retain table, prune dangling PageURL
605         references, delete the temporary table, and set the flag - and carry on as normal
606
607         * loader/icon/IconDatabase.cpp:
608         (WebCore::IconDatabase::IconDatabase): initialize the flag
609         (WebCore::IconDatabase::open): changed the schema of the temporary table
610         (WebCore::IconDatabase::retainIconURL): store the icon retain to the temp table if starting up
611         (WebCore::IconDatabase::releaseIconURL): ditto
612         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): remove all icons *not* in the retain table, then
613           wipe all the PageURLs who no longer point to a valid IconURL
614         * loader/icon/IconDatabase.h:
615
616 2006-08-21  Alexey Proskuryakov  <ap@nypop.com>
617
618         Reviewed by Eric.
619
620         http://bugzilla.opendarwin.org/show_bug.cgi?id=10419
621         XSLTProcessor transformToFragment fails because of an XML declaration
622
623         Test: fast/xsl/transformToFragment-XML-declaration.html
624
625         * xml/XSLTProcessor.cpp:
626         (WebCore::XSLTProcessor::transformToString): Always inhibit XML declaration printout.
627
628 2006-08-21  David Harrison  <harrison@apple.com>
629
630         Reviewed by Justin.
631
632         <rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange
633
634         Added support for the NSAccessibilityMisspelledTextAttribute.
635         
636         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
637         is not possible.  See following bug...
638             <rdar://problem/4256882> Need automated testing support for accessibility APIs
639
640         * bridge/mac/WebCoreAXObject.mm:
641         Lots of trivial formatting in many methods.
642         
643         (-[WebCoreAXObject accessibilityAttributeValue:]):
644         Fixed AXStartTextMarker and AXEndTextMarker to use startOfDocument and endOfDocument, instead of
645         of positionForCoordinates. I had seen erroneous endOfDocument results while testing the spelling
646         attribute.
647
648         (WebCore::AXAttributeStringSetSpelling): 
649         New. Adds the NSAccessibilityMisspelledTextAttribute for misspelled words.
650
651         (-[WebCoreAXObject AXAttributedStringAppendText:]):
652         Added call to AXAttributeStringSetSpelling.
653         
654         * editing/visible_units.cpp:
655         (WebCore::startOfDocument):
656         (WebCore::endOfDocument):
657         Added for AXStartTextMarker/AXEndTextMarker fix, these forms of the familiar functions take a Node*,
658         so a previously existing VisiblePosition is not required.
659         
660         * editing/visible_units.h:
661         Declare new forms of startOfDocument and endOfDocument.
662
663 2006-08-21  Nikolas Zimmermann  <zimmermann@kde.org>
664
665         Reviewed by Eric.
666
667         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
668         WebKit should have Qt platform support
669
670         * platform/qt/TemporaryLinkStubs.cpp: Added.
671         (JavaAppletWidget::JavaAppletWidget):
672         (Font::selectionRectForComplexText):
673         (Font::offsetForPositionForComplexText):
674         (WebCore::refreshPlugins):
675         (WebCore::focusRingColor):
676         (Image::drawTiled):
677         (WebCore::TextField::selectAll):
678         (WebCore::TextField::addSearchResult):
679         (WebCore::TextField::selectionStart):
680         (WebCore::TextField::hasSelectedText):
681         (WebCore::TextField::selectedText):
682         (WebCore::TextField::setAutoSaveName):
683         (WebCore::TextField::checksDescendantsForFocus):
684         (WebCore::TextField::setSelection):
685         (WebCore::TextField::setMaxResults):
686         (WebCore::TextField::edited):
687         (WebCore::TextField::focusPolicy):
688         (WebCore::TextField::TextField):
689         (WebCore::TextField::~TextField):
690         (WebCore::TextField::setFont):
691         (WebCore::TextField::setAlignment):
692         (WebCore::TextField::setWritingDirection):
693         (WebCore::TextField::maxLength):
694         (WebCore::TextField::setMaxLength):
695         (WebCore::TextField::text):
696         (WebCore::TextField::setText):
697         (WebCore::TextField::cursorPosition):
698         (WebCore::TextField::setCursorPosition):
699         (WebCore::TextField::setEdited):
700         (WebCore::TextField::setReadOnly):
701         (WebCore::TextField::setPlaceholderString):
702         (WebCore::TextField::setColors):
703         (WebCore::TextField::sizeForCharacterWidth):
704         (WebCore::TextField::baselinePosition):
705         (WebCore::TextField::setLiveSearch):
706         (WebCore::Slider::Slider):
707         (WebCore::Slider::sizeHint):
708         (WebCore::Slider::~Slider):
709         (WebCore::Slider::setValue):
710         (WebCore::Slider::setMaxValue):
711         (WebCore::Slider::setMinValue):
712         (WebCore::Slider::setFont):
713         (WebCore::Slider::value):
714         (WebCore::Slider::focusPolicy):
715         (WebCore::ScrollBar::ScrollBar):
716         (WebCore::ScrollBar::setSteps):
717         (WebCore::ScrollBar::scroll):
718         (WebCore::ScrollBar::setValue):
719         (WebCore::ScrollBar::setKnobProportion):
720         (WebCore::PlatformScrollBar::PlatformScrollBar):
721         (WebCore::PlatformScrollBar::~PlatformScrollBar):
722         (WebCore::PlatformScrollBar::width):
723         (WebCore::PlatformScrollBar::height):
724         (WebCore::PlatformScrollBar::setEnabled):
725         (WebCore::PlatformScrollBar::paint):
726         (WebCore::PlatformScrollBar::setScrollBarValue):
727         (WebCore::PlatformScrollBar::setKnobProportion):
728         (WebCore::PlatformScrollBar::setRect):
729         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
730         (WebCore::CheckCacheObjectStatus):
731         (WebCore::CheckIfReloading):
732         (WebCore::ServeSynchronousRequest):
733         (WebCore::historyContains):
734         (WebCore::submitButtonDefaultLabel):
735         (WebCore::inputElementAltText):
736         (WebCore::resetButtonDefaultLabel):
737         (WebCore::defaultLanguage):
738         (WebCore::findNextSentenceFromIndex):
739         (WebCore::findSentenceBoundary):
740         (WebCore::findNextWordFromIndex):
741         (WebCore::findWordBoundary):
742         (Frame::setNeedsReapplyStyles):
743         (WebCore::screenDepthPerComponent):
744         (WebCore::screenIsMonochrome):
745         (WebCore::searchableIndexIntroduction):
746         (WebCore::setFocusRingColorChangeFunction):
747         (FrameView::updateBorder):
748         (loadResourceIntoArray):
749         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
750         (PlugInInfoStore::pluginCount):
751         (WebCore::PlugInInfoStore::supportsMIMEType):
752         (FileButton::FileButton):
753         (FileButton::click):
754         (FileButton::sizeForCharacterWidth):
755         (FileButton::focusPolicy):
756         (FileButton::frameGeometry):
757         (FileButton::setFilename):
758         (FileButton::baselinePosition):
759         (FileButton::setFrameGeometry):
760         (FileButton::setDisabled):
761         (WebCore::supportedKeySizes):
762         (WebCore::signedPublicKeyAndChallengeString):
763
764 2006-08-21  Nikolas Zimmermann  <zimmermann@kde.org>
765
766         Reviewed by Maciej.
767
768         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
769         WebKit should have Qt platform support
770
771         * platform/qt/CursorQt.cpp: Added.
772         (WebCore::Cursor::Cursor):
773         (WebCore::Cursor::~Cursor):
774         (WebCore::Cursor::operator=):
775         (WebCore::Cursors::Cursors::self):
776         (WebCore::moveCursor):
777         (WebCore::crossCursor):
778         (WebCore::handCursor):
779         (WebCore::iBeamCursor):
780         (WebCore::waitCursor):
781         (WebCore::helpCursor):
782         (WebCore::eastResizeCursor):
783         (WebCore::northResizeCursor):
784         (WebCore::northEastResizeCursor):
785         (WebCore::northWestResizeCursor):
786         (WebCore::southResizeCursor):
787         (WebCore::southEastResizeCursor):
788         (WebCore::southWestResizeCursor):
789         (WebCore::westResizeCursor):
790         (WebCore::northSouthResizeCursor):
791         (WebCore::eastWestResizeCursor):
792         (WebCore::northEastSouthWestResizeCursor):
793         (WebCore::northWestSouthEastResizeCursor):
794         (WebCore::columnResizeCursor):
795         (WebCore::rowResizeCursor):
796         * platform/qt/RenderThemeQt.cpp: Added.
797         (WebCore::RenderThemeQt::RenderThemeQt):
798         (WebCore::RenderThemeQt::supportsHover):
799         (WebCore::RenderThemeQt::paintCheckbox):
800         (WebCore::RenderThemeQt::paintRadio):
801         (WebCore::theme):
802         (WebCore::RenderThemeQt::isControlStyled):
803         (WebCore::RenderThemeQt::controlSupportsTints):
804         (WebCore::RenderThemeQt::systemFont):
805         (WebCore::RenderThemeQt::createPopupMenu):
806         (WebCore::RenderThemeQt::addIntrinsicMargins):
807         (WebCore::RenderThemeQt::stylePainterAndWidgetForPaintInfo):
808         (WebCore::RenderThemeQt::setCheckboxSize):
809         (WebCore::RenderThemeQt::setRadioSize):
810         (WebCore::RenderThemeQt::supportsFocus):
811         (WebCore::RenderThemeQt::applyTheme):
812         (WebCore::RenderThemeQt::adjustButtonStyle):
813         (WebCore::RenderThemeQt::paintButton):
814         (WebCore::RenderThemeQt::adjustTextFieldStyle):
815         (WebCore::RenderThemeQt::paintTextField):
816
817 2006-08-21  Nikolas Zimmermann  <zimmermann@kde.org>
818
819         Reviewed by Maciej.
820
821         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
822         WebKit should have Qt platform support
823
824         * platform/qt/SharedTimerQt.cpp: Added.
825         (WebCore:setSharedTimerFiredFunction):
826         (WebCore::setSharedTimerFireTime):
827         (WebCore::stopSharedTimer):
828         * platform/qt/SharedTimerQt.h: Added.
829         (WebCore::SharedTimerQt::SharedTimerQt):
830         (WebCore::SharedTimerQt::~SharedTimerQt):
831         (WebCore::SharedTimerQt::inst):
832         (WebCore::SharedTimerQt::fire):
833         * platform/qt/SystemTimeQt.cpp: Added.
834         (WebCore::currentTime):
835
836 2006-08-21  Brady Eidson  <beidson@apple.com>
837
838         Reviewed by John
839
840         -Defers writing to the database via a timer and handles starting the timer
841          intelligently
842
843         * loader/icon/IconDatabase.cpp:
844         (WebCore::IconDatabase::IconDatabase):
845         (WebCore::IconDatabase::open): Don't start the update timer by default
846         (WebCore::IconDatabase::close): Call syncDatabase()
847         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Call syncDatabase()
848         (WebCore::IconDatabase::setIconURLForPageURL): Setup the cached url, but defer the DB call
849         (WebCore::IconDatabase::setIconURLForPageURLInDatabase): Actually commit the url to the DB
850         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
851         (WebCore::IconDatabase::updateDatabase): The updateTimer calls this, which just calls syncDatabase()
852         (WebCore::IconDatabase::syncDatabase): Add and remove pending pageURLs and iconURLs, and stop the updateTimer
853         * loader/icon/IconDatabase.h:
854
855 2006-08-21  Alexey Proskuryakov  <ap@nypop.com>
856
857         Reviewed by Eric.
858
859         - http://bugzilla.opendarwin.org/show_bug.cgi?id=10429
860           XSLTProcessor.transformToFragment crashes if the owner document is empty
861
862         Test: fast/js/xslt-fragment-in-empty-doc.html
863
864         * dom/XMLTokenizer.cpp:
865         (WebCore::XMLTokenizer::XMLTokenizer): Don't iterate over the element stack if it's empty.
866
867 2006-08-21  Brady Eidson  <beidson@apple.com>
868
869         Reviewed by Anders
870
871         -Added timer-based, deferred deletion of database records - PageURLs and Icons handled seperately
872          In the near future, we'll also have timer-based deferred *addition* of database records
873         -Keep retain/release counts in a hash instead of a DB table
874         -Keep only one hash record for the SiteIcons
875         -Renamed some methods for clarity
876
877         * bridge/mac/WebCoreIconDatabaseBridge.h: Renamed method for clarity
878         * bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
879         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): Ditto
880         * loader/icon/IconDatabase.cpp:
881         (WebCore::IconDatabase::IconDatabase):
882         (WebCore::IconDatabase::open): Added new timer setup
883         (WebCore::IconDatabase::iconForPageURL): Only work with one hash of the SiteIcons
884         (WebCore::IconDatabase::retainIconForPageURL): Keep count in a hash
885         (WebCore::IconDatabase::releaseIconForPageURL): Keep count in a hash, use deferred deletion
886         (WebCore::IconDatabase::retainIconURL): Added
887         (WebCore::IconDatabase::releaseIconURL): Added
888         (WebCore::IconDatabase::forgetPageURL):  Added
889         (WebCore::IconDatabase::isIconURLRetained): New and improved simplicity
890         (WebCore::IconDatabase::setIconDataForIconURL): Cleanup
891         (WebCore::IconDatabase::setIconURLForPageURL):
892         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Renamed
893         (WebCore::IconDatabase::pruneIconsPendingDeletion): Added
894         (WebCore::IconDatabase::hasEntryForIconURL): Renamed for clarity
895         * loader/icon/IconDatabase.h: Added multiple stuffs
896
897 2006-08-21  Brady Eidson  <beidson@apple.com>
898
899         Reviewed by Maciej's rubberstamp
900
901         Removed stale file references from the Xcode.proj
902
903         * WebCore.xcodeproj/project.pbxproj:
904
905 2006-08-20  Nikolas Zimmermann  <zimmermann@kde.org>
906
907         Reviewed by Maciej. Landed by rwlbuis.
908
909         Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
910         WebKit should have Qt platform support
911
912         Removing HelperQt.h usage by creating appropriate operators
913         constructor in some of the platform classes, as suggested by Darin.
914
915         * CMakeLists.txt:
916         * platform/DeprecatedString.h:
917         * platform/Font.h:
918         * platform/PlatformString.h:
919         * platform/qt/ComboBoxQt.cpp:
920         (WebCore::PlatformComboBox::appendItem):
921         (WebCore::PlatformComboBox::appendGroupLabel):
922         (WebCore::PlatformComboBox::setFont):
923         * platform/qt/LineEditQt.cpp:
924         (WebCore::PlatformLineEdit::setFont):
925         (WebCore::PlatformLineEdit::setText):
926         (WebCore::PlatformLineEdit::text):
927         (WebCore::PlatformLineEdit::selectedText):
928         * platform/qt/ListBoxQt.cpp:
929         (WebCore::ListBox::setFont):
930         (WebCore::ListBox::appendItem):
931         * platform/qt/PlatformKeyboardEventQt.cpp:
932         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
933         * platform/qt/ScrollViewQt.cpp:
934         * platform/qt/StringQt.cpp: Added.
935         (WebCore::String::String):
936         (WebCore::String::operator QString):
937         (WebCore::DeprecatedString::operator QString):
938         * platform/qt/TextEditQt.cpp:
939         * platform/qt/WidgetQt.cpp:
940         (WebCore::Widget::setFont):
941
942 2006-08-18  Steve Falkenburg  <sfalken@apple.com>
943
944         Rubber stamped by adele.
945         
946         Fix call to WebFormDelegate's textFieldDidBeginEditing.
947
948         * rendering/RenderTextControl.cpp:
949         (WebCore::RenderTextControl::subtreeHasChanged):
950
951 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
952
953         Reviewed by Eric. Landed by rwlbuis.
954
955         Next chunk of the implementation for:
956         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
957
958         WebKit should have Qt platform support
959
960         * platform/qt/KeyboardCodes.h: Added.
961         * platform/qt/PlatformKeyboardEventQt.cpp: Added.
962         (WebCore::keyIdentifierForQtKeyCode):
963         (WebCore::windowsKeyCodeForKeyEvent):
964         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
965         * platform/qt/PlatformMouseEventQt.cpp: Added.
966         (WebCore::):
967         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
968
969 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
970
971         Reviewed by Eric. Landed by rwlbuis.
972
973         Next chunk of the implementation for:
974         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
975
976         WebKit should have Qt platform support
977
978         * platform/qt/AffineTransformQt.cpp: Added.
979         (WebCore::AffineTransform::AffineTransform):
980         (WebCore::AffineTransform::setMatrix):
981         (WebCore::AffineTransform::map):
982         (WebCore::AffineTransform::mapRect):
983         (WebCore::AffineTransform::isIdentity):
984         (WebCore::AffineTransform::m11):
985         (WebCore::AffineTransform::m12):
986         (WebCore::AffineTransform::m21):
987         (WebCore::AffineTransform::m22):
988         (WebCore::AffineTransform::dx):
989         (WebCore::AffineTransform::dy):
990         (WebCore::AffineTransform::reset):
991         (WebCore::AffineTransform::scale):
992         (WebCore::AffineTransform::rotate):
993         (WebCore::AffineTransform::translate):
994         (WebCore::AffineTransform::shear):
995         (WebCore::AffineTransform::det):
996         (WebCore::AffineTransform::invert):
997         (WebCore::AffineTransform::operator QMatrix):
998         (WebCore::AffineTransform::operator==):
999         (WebCore::AffineTransform::operator*=):
1000         (WebCore::AffineTransform::operator*):
1001         * platform/qt/BrowserExtensionQt.cpp: Added.
1002         (WebCore::BrowserExtensionQt::BrowserExtensionQt):
1003         (WebCore::BrowserExtensionQt::canRunModal):
1004         (WebCore::BrowserExtensionQt::createNewWindow):
1005         (WebCore::BrowserExtensionQt::canRunModalNow):
1006         (WebCore::BrowserExtensionQt::runModal):
1007         (WebCore::BrowserExtensionQt::goBackOrForward):
1008         (WebCore::BrowserExtensionQt::historyURL):
1009         (WebCore::BrowserExtensionQt::setTypedIconURL):
1010         (WebCore::BrowserExtensionQt::setIconURL):
1011         (WebCore::BrowserExtensionQt::getHistoryLength):
1012         * platform/qt/BrowserExtensionQt.h: Added.
1013         * platform/qt/CookieJarQt.cpp: Added.
1014         (WebCore::setCookies):
1015         (WebCore::cookies):
1016         (WebCore::cookiesEnabled):
1017         * platform/qt/PageQt.cpp: Added.
1018         (WebCore::rootWindowForFrame):
1019         (WebCore::Page::windowRect):
1020         (WebCore::Page::setWindowRect):
1021         * platform/qt/PathQt.cpp: Added.
1022         (WebCore::Path::Path):
1023         (WebCore::Path::~Path):
1024         (WebCore::Path::operator=):
1025         (WebCore::Path::contains):
1026         (WebCore::Path::translate):
1027         (WebCore::Path::boundingRect):
1028         (WebCore::Path::moveTo):
1029         (WebCore::Path::addLineTo):
1030         (WebCore::Path::addQuadCurveTo):
1031         (WebCore::Path::addBezierCurveTo):
1032         (WebCore::Path::addArcTo):
1033         (WebCore::Path::closeSubpath):
1034         (WebCore::Path::addArc):
1035         (WebCore::Path::addRect):
1036         (WebCore::Path::addEllipse):
1037         (WebCore::Path::clear):
1038         * platform/qt/ScreenQt.cpp: Added.
1039         (WebCore::screenRect):
1040         (WebCore::screenDepth):
1041         (WebCore::usableScreenRect):
1042
1043
1044 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
1045
1046         Reviewed by Eric. Landed by rwlbuis.
1047
1048         First chunk of the implementation for:
1049         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
1050
1051         WebKit should have Qt platform support
1052
1053         * platform/qt/ComboBoxQt.cpp: Added.
1054         (WebCore::PlatformComboBox::PlatformComboBox):
1055         (WebCore::PlatformComboBox::~PlatformComboBox):
1056         (WebCore::PlatformComboBox::setParentWidget):
1057         (WebCore::PlatformComboBox::clear):
1058         (WebCore::PlatformComboBox::appendItem):
1059         (WebCore::PlatformComboBox::appendGroupLabel):
1060         (WebCore::PlatformComboBox::appendSeparator):
1061         (WebCore::PlatformComboBox::setCurrentItem):
1062         (WebCore::PlatformComboBox::sizeHint):
1063         (WebCore::PlatformComboBox::frameGeometry):
1064         (WebCore::PlatformComboBox::setFrameGeometry):
1065         (WebCore::PlatformComboBox::baselinePosition):
1066         (WebCore::PlatformComboBox::setFont):
1067         (WebCore::PlatformComboBox::focusPolicy):
1068         (WebCore::PlatformComboBox::itemSelected):
1069         (WebCore::PlatformComboBox::setWritingDirection):
1070         (WebCore::PlatformComboBox::populate):
1071         (WebCore::PlatformComboBox::populateMenu):
1072         * platform/qt/LineEditQt.cpp: Added.
1073         (WebCore::PlatformLineEdit::PlatformLineEdit):
1074         (WebCore::PlatformLineEdit::~PlatformLineEdit):
1075         (WebCore::PlatformLineEdit::setParentWidget):
1076         (WebCore::PlatformLineEdit::setColors):
1077         (WebCore::PlatformLineEdit::setAlignment):
1078         (WebCore::PlatformLineEdit::setCursorPosition):
1079         (WebCore::PlatformLineEdit::cursorPosition):
1080         (WebCore::PlatformLineEdit::setEdited):
1081         (WebCore::PlatformLineEdit::edited):
1082         (WebCore::PlatformLineEdit::setFont):
1083         (WebCore::PlatformLineEdit::setMaxLength):
1084         (WebCore::PlatformLineEdit::maxLength):
1085         (WebCore::PlatformLineEdit::setReadOnly):
1086         (WebCore::PlatformLineEdit::isReadOnly):
1087         (WebCore::PlatformLineEdit::setText):
1088         (WebCore::PlatformLineEdit::text):
1089         (WebCore::PlatformLineEdit::setWritingDirection):
1090         (WebCore::PlatformLineEdit::selectAll):
1091         (WebCore::PlatformLineEdit::hasSelectedText):
1092         (WebCore::PlatformLineEdit::selectionStart):
1093         (WebCore::PlatformLineEdit::selectedText):
1094         (WebCore::PlatformLineEdit::setSelection):
1095         (WebCore::PlatformLineEdit::sizeForCharacterWidth):
1096         (WebCore::PlatformLineEdit::baselinePosition):
1097         (WebCore::PlatformLineEdit::focusPolicy):
1098         (WebCore::PlatformLineEdit::checksDescendantsForFocus):
1099         (WebCore::PlatformLineEdit::setLiveSearch):
1100         (WebCore::PlatformLineEdit::setAutoSaveName):
1101         (WebCore::PlatformLineEdit::setMaxResults):
1102         (WebCore::PlatformLineEdit::setPlaceholderString):
1103         (WebCore::PlatformLineEdit::addSearchResult):
1104         * platform/qt/ListBoxQt.cpp: Added.
1105         (WebCore::ListBox::ListBox):
1106         (WebCore::ListBox::~ListBox):
1107         (WebCore::ListBox::setParentWidget):
1108         (WebCore::ListBox::sizeForNumberOfLines):
1109         (WebCore::ListBox::setSelectionMode):
1110         (WebCore::ListBox::clear):
1111         (WebCore::ListBox::doneAppendingItems):
1112         (WebCore::ListBox::setSelected):
1113         (WebCore::ListBox::isSelected):
1114         (WebCore::ListBox::setEnabled):
1115         (WebCore::ListBox::isEnabled):
1116         (WebCore::ListBox::setWritingDirection):
1117         (WebCore::ListBox::focusPolicy):
1118         (WebCore::ListBox::checksDescendantsForFocus):
1119         (WebCore::ListBox::clearCachedTextRenderers):
1120         (WebCore::ListBox::setFont):
1121         (WebCore::ListBox::appendItem):
1122         * platform/qt/ScrollViewQt.cpp: Added.
1123         (WebCore::ScrollView::ScrollView):
1124         (WebCore::ScrollView::~ScrollView):
1125         (WebCore::ScrollView::setParentWidget):
1126         (WebCore::ScrollView::updateContents):
1127         (WebCore::ScrollView::visibleWidth):
1128         (WebCore::ScrollView::visibleHeight):
1129         (WebCore::ScrollView::visibleContentRect):
1130         (WebCore::ScrollView::setContentsPos):
1131         (WebCore::ScrollView::resizeContents):
1132         (WebCore::ScrollView::contentsX):
1133         (WebCore::ScrollView::contentsY):
1134         (WebCore::ScrollView::contentsWidth):
1135         (WebCore::ScrollView::contentsHeight):
1136         (WebCore::ScrollView::viewportToContents):
1137         (WebCore::ScrollView::contentsToViewport):
1138         (WebCore::ScrollView::scrollOffset):
1139         (WebCore::ScrollView::scrollBy):
1140         (WebCore::ScrollView::hScrollBarMode):
1141         (WebCore::ScrollView::vScrollBarMode):
1142         (WebCore::ScrollView::suppressScrollBars):
1143         (WebCore::ScrollView::setHScrollBarMode):
1144         (WebCore::ScrollView::setVScrollBarMode):
1145         (WebCore::ScrollView::setScrollBarsMode):
1146         (WebCore::ScrollView::setStaticBackground):
1147         (WebCore::ScrollView::addChild):
1148         (WebCore::ScrollView::removeChild):
1149         (WebCore::ScrollView::scrollPointRecursively):
1150         (WebCore::ScrollView::inWindow):
1151         * platform/qt/TextEditQt.cpp: Added.
1152         (WebCore::PlatformTextEdit::PlatformTextEdit):
1153         (WebCore::PlatformTextEdit::~PlatformTextEdit):
1154         (WebCore::PlatformTextEdit::setParentWidget):
1155         (WebCore::PlatformTextEdit::setColors):
1156         (WebCore::PlatformTextEdit::setAlignment):
1157         (WebCore::PlatformTextEdit::setLineHeight):
1158         (WebCore::PlatformTextEdit::setCursorPosition):
1159         (WebCore::PlatformTextEdit::getCursorPosition):
1160         (WebCore::PlatformTextEdit::setFont):
1161         (WebCore::PlatformTextEdit::setReadOnly):
1162         (WebCore::PlatformTextEdit::isReadOnly):
1163         (WebCore::PlatformTextEdit::setDisabled):
1164         (WebCore::PlatformTextEdit::isDisabled):
1165         (WebCore::PlatformTextEdit::hasSelectedText):
1166         (WebCore::PlatformTextEdit::setText):
1167         (WebCore::PlatformTextEdit::text):
1168         (WebCore::PlatformTextEdit::textWithHardLineBreaks):
1169         (WebCore::PlatformTextEdit::focusPolicy):
1170         (WebCore::PlatformTextEdit::setWordWrap):
1171         (WebCore::PlatformTextEdit::wordWrap):
1172         (WebCore::PlatformTextEdit::setScrollBarModes):
1173         (WebCore::PlatformTextEdit::setWritingDirection):
1174         (WebCore::PlatformTextEdit::selectionStart):
1175         (WebCore::PlatformTextEdit::selectionEnd):
1176         (WebCore::PlatformTextEdit::setSelectionStart):
1177         (WebCore::PlatformTextEdit::setSelectionEnd):
1178         (WebCore::PlatformTextEdit::selectAll):
1179         (WebCore::PlatformTextEdit::setSelectionRange):
1180         (WebCore::PlatformTextEdit::sizeWithColumnsAndRows):
1181         (WebCore::PlatformTextEdit::checksDescendantsForFocus):
1182         * platform/qt/WidgetQt.cpp: Added.
1183         (WebCore::WidgetPrivate::WidgetPrivate):
1184         (WebCore::WidgetPrivate::~WidgetPrivate):
1185         (WebCore::Widget::Widget):
1186         (WebCore::Widget::~Widget):
1187         (WebCore::Widget::setClient):
1188         (WebCore::Widget::client):
1189         (WebCore::Widget::frameGeometry):
1190         (WebCore::Widget::hasFocus):
1191         (WebCore::Widget::setFocus):
1192         (WebCore::Widget::clearFocus):
1193         (WebCore::Widget::font):
1194         (WebCore::Widget::setFont):
1195         (WebCore::Widget::setCursor):
1196         (WebCore::Widget::show):
1197         (WebCore::Widget::hide):
1198         (WebCore::Widget::setQWidget):
1199         (WebCore::Widget::qwidget):
1200         (WebCore::Widget::setParentWidget):
1201         (WebCore::Widget::parentWidget):
1202         (WebCore::Widget::setFrameGeometry):
1203         (WebCore::Widget::mapFromGlobal):
1204         (WebCore::Widget::scaleFactor):
1205         (WebCore::Widget::lockDrawingFocus):
1206         (WebCore::Widget::unlockDrawingFocus):
1207         (WebCore::Widget::paint):
1208         (WebCore::Widget::enableFlushDrawing):
1209         (WebCore::Widget::isEnabled):
1210         (WebCore::Widget::setIsSelected):
1211         (WebCore::Widget::disableFlushDrawing):
1212         (WebCore::Widget::setEnabled):
1213         (WebCore::Widget::focusPolicy):
1214
1215 2006-08-19  Nikolas Zimmermann  <zimmermann@kde.org>
1216
1217         Reviewed by Eric. Landed by rwlbuis.
1218
1219         First chunk of the implementation for:
1220         http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
1221
1222         WebKit should have Qt platform support
1223
1224         * platform/qt/ColorQt.cpp: Added.
1225         (WebCore::Color::Color):
1226         (WebCore::Color::operator QColor):
1227         * platform/qt/FloatPointQt.cpp: Added.
1228         (WebCore::FloatPoint::FloatPoint):
1229         (WebCore::FloatPoint::operator QPointF):
1230         * platform/qt/FloatRectQt.cpp: Added.
1231         (WebCore::FloatRect::FloatRect):
1232         (WebCore::FloatRect::operator QRectF):
1233         * platform/qt/IntPointQt.cpp: Added.
1234         (WebCore::IntPoint::IntPoint):
1235         (WebCore::IntPoint::operator QPoint):
1236         * platform/qt/IntRectQt.cpp: Added.
1237         (WebCore::IntRect::IntRect):
1238         (WebCore::IntRect::operator QRect):
1239         * platform/qt/IntSizeQt.cpp: Added.
1240         (WebCore::IntSize::IntSize):
1241         (WebCore::IntSize::operator QSize):
1242
1243  2006-08-18  Nikolas Zimmermann  <zimmermann@kde.org>
1244  
1245          Reviewed by Eric. Landed by rwlbuis.
1246  
1247          Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
1248          The Qt platform needs a KCanvas device.
1249  
1250          * kcanvas/device/qt/KCanvasClipperQt.cpp: Added.
1251          (WebCore::KCanvasClipperQt::applyClip):
1252          * kcanvas/device/qt/KCanvasClipperQt.h: Added.
1253          (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1254          * kcanvas/device/qt/KCanvasPathQt.cpp: Added.
1255          (WebCore::KCanvasPathQt::KCanvasPathQt):
1256          (WebCore::KCanvasPathQt::~KCanvasPathQt):
1257          (WebCore::KCanvasPathQt::isEmpty):
1258          (WebCore::KCanvasPathQt::moveTo):
1259          (WebCore::KCanvasPathQt::lineTo):
1260          (WebCore::KCanvasPathQt::curveTo):
1261          (WebCore::KCanvasPathQt::closeSubpath):
1262          (WebCore::KCanvasPathQt::boundingBox):
1263          (WebCore::KCanvasPathQt::strokeBoundingBox):
1264          (WebCore::KCanvasPathQt::strokeContainsPoint):
1265          (WebCore::KCanvasPathQt::containsPoint):
1266          * kcanvas/device/qt/KCanvasPathQt.h: Added.
1267          (WebCore::KCanvasPathQt::qtPath):
1268          * kcanvas/device/qt/KRenderingDeviceQt.cpp: Added.
1269          (WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt):
1270          (WebCore::KRenderingDeviceContextQt::~KRenderingDeviceContextQt):
1271          (WebCore::KRenderingDeviceContextQt::concatCTM):
1272          (WebCore::KRenderingDeviceContextQt::ctm):
1273          (WebCore::KRenderingDeviceContextQt::mapFromVisual):
1274          (WebCore::KRenderingDeviceContextQt::mapToVisual):
1275          (WebCore::KRenderingDeviceContextQt::clearPath):
1276          (WebCore::KRenderingDeviceContextQt::addPath):
1277          (WebCore::KRenderingDeviceContextQt::createGraphicsContext):
1278          (WebCore::KRenderingDeviceContextQt::painter):
1279          (WebCore::KRenderingDeviceContextQt::pathBBox):
1280          (WebCore::KRenderingDeviceContextQt::setFillRule):
1281          (WebCore::KRenderingDeviceContextQt::fillPath):
1282          (WebCore::KRenderingDeviceContextQt::strokePath):
1283          (WebCore::KRenderingDeviceQt::KRenderingDeviceQt):
1284          (WebCore::KRenderingDeviceQt::~KRenderingDeviceQt):
1285          (WebCore::KRenderingDeviceQt::popContext):
1286          (WebCore::KRenderingDeviceQt::pushContext):
1287          (WebCore::KRenderingDeviceQt::qtContext):
1288          (WebCore::KRenderingDeviceQt::contextForImage):
1289          (WebCore::KRenderingDeviceQt::stringForPath):
1290          (WebCore::KRenderingDeviceQt::createResource):
1291          (WebCore::KRenderingDeviceQt::createPaintServer):
1292          (WebCore::KRenderingDeviceQt::createFilterEffect):
1293
1294 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
1295
1296         Reviewed by Eric. Landed by rwlbuis.
1297
1298         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
1299         WebKit should have Qt platform support.
1300
1301         * platform/Color.h:
1302         * platform/Cursor.h:
1303         (WebCore::Cursor::Cursor):
1304         * platform/FloatPoint.h:
1305         * platform/FloatRect.h:
1306         * platform/GlyphBuffer.h:
1307         (WebCore::GlyphBuffer::glyphAt):
1308         (WebCore::GlyphBuffer::advanceAt):
1309         (WebCore::GlyphBuffer::add):
1310         * platform/GraphicsContext.h:
1311         * platform/ImageSource.h:
1312         * platform/IntPoint.h:
1313         * platform/IntRect.h:
1314         * platform/IntSize.h:
1315         * platform/ListBox.h:
1316         * platform/Path.h:
1317         * platform/PlatformKeyboardEvent.h:
1318         * platform/PlatformMouseEvent.h:
1319         * platform/ResourceLoader.h:
1320         * platform/ResourceLoaderClient.h:
1321         * platform/ResourceLoaderInternal.h:
1322         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1323         * platform/ScrollView.h:
1324         * platform/Widget.h:
1325
1326 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
1327
1328         Reviewed by Eric. Landed by rwlbuis.
1329
1330         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
1331         General WebKit Linux build fixes.
1332
1333         * kcanvas/KCanvasFilters.cpp:
1334         (WebCore::operator<<):
1335         * kcanvas/RenderSVGImage.cpp:
1336         * ksvg2/css/SVGCSSStyleSelector.cpp:
1337         * ksvg2/svg/SVGAnimateColorElement.cpp:
1338         * ksvg2/svg/SVGMaskElement.cpp:
1339         * ksvg2/svg/SVGPatternElement.cpp:
1340         * page/Frame.h:
1341         * rendering/RenderStyle.h:
1342         (WebCore::RenderStyle::deleteBindingURIs):
1343         * xml/DOMParser.cpp:
1344
1345 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
1346
1347         Reviewed by Eric. Landed by rwlbuis.
1348
1349         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
1350         Offer a cmake build system for Qt platform.
1351
1352         * CMakeLists.txt: Added.
1353
1354 2006-08-17  David Harrison  <harrison@apple.com>
1355
1356         Reviewed by John Sullivan.
1357
1358         <rdar://problem/4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons
1359
1360         Accessorized RenderMenuList objects.
1361         
1362         * bridge/mac/WebCoreAXObject.mm:
1363         (-[WebCoreAXObject mouseButtonListener]):
1364         Trivial formatting.
1365         
1366         (-[WebCoreAXObject actionElement]):
1367         Return the HTMLSelectElement.
1368         
1369         (-[WebCoreAXObject firstChild]):
1370         (-[WebCoreAXObject lastChild]):
1371         (-[WebCoreAXObject previousSibling]):
1372         (-[WebCoreAXObject nextSibling]):
1373         (-[WebCoreAXObject parentObject]):
1374         (-[WebCoreAXObject parentObjectUnignored]):
1375         (-[WebCoreAXObject isAttachment]):
1376         (-[WebCoreAXObject attachmentView]):
1377         Trivial formatting.
1378
1379         (-[WebCoreAXObject role]):
1380         Return NSAccessibilityPopUpButtonRole.
1381
1382         (-[WebCoreAXObject subrole]):
1383         Trivial formatting.
1384         
1385         (-[WebCoreAXObject roleDescription]):
1386         Return NSAccessibilityPopUpButtonRole.
1387         
1388         (-[WebCoreAXObject textUnderElement]):
1389         Trivial formatting.
1390
1391         (-[WebCoreAXObject value]):
1392         Return the RenderMenuList::text().
1393         
1394         (-[WebCoreAXObject position]):
1395          Trivial formatting.
1396
1397         (-[WebCoreAXObject accessibilityIsIgnored]):
1398         - Ignore popup menu items because AppKit does.
1399         - Remove redundant check for buttonTag (earlier isControl() check suffices).
1400         
1401         (-[WebCoreAXObject accessibilityAttributeNames]):
1402         (-[WebCoreAXObject accessibilityActionNames]):
1403         (-[WebCoreAXObject accessibilityAttributeValue:]):
1404         Trivial formatting.
1405         
1406         (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
1407         Removed old debugging code that is no longer needed.
1408         Trivial formatting.
1409         
1410         (-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
1411         (-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
1412         (-[WebCoreAXObject removeAXObjectID]):
1413         Trivial formatting.
1414         
1415         * html/HTMLSelectElement.cpp:
1416         (WebCore::HTMLSelectElement::accessKeyAction):
1417         Call click() instead of focus().
1418         
1419         * rendering/RenderMenuList.cpp:
1420         (WebCore::RenderMenuList::text):
1421         Added for easy access to popup's current text.
1422         
1423         * rendering/RenderMenuList.h:
1424         (WebCore::RenderMenuList::isMenuList):
1425         * rendering/RenderObject.h:
1426         (WebCore::RenderObject::isMenuList):
1427         Added so popups can be identified.
1428
1429 2006-08-17  David Harrison  <harrison@apple.com>
1430
1431         Reviewed by Maciej.
1432
1433         <rdar://problem/4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range
1434
1435         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
1436         is not possible.  See following bug...
1437             <rdar://problem/4256882> Need automated testing support for accessibility APIs
1438
1439         * bridge/mac/AXObjectCacheMac.mm:
1440         (WebCore::AXObjectCache::visiblePositionForTextMarker):
1441         Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.
1442
1443 2006-08-17  Nikolas Zimmermann  <zimmermann@kde.org>
1444
1445         Reviewed by Anders.
1446
1447         Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10447
1448         AffineTransform should be multi-platform compatible
1449
1450         * platform/AffineTransform.h:
1451         * platform/cg/AffineTransformCG.cpp:
1452         (WebCore::AffineTransform::m11):
1453         (WebCore::AffineTransform::m12):
1454         (WebCore::AffineTransform::m21):
1455         (WebCore::AffineTransform::m22):
1456         (WebCore::AffineTransform::dx):
1457         (WebCore::AffineTransform::dy):
1458
1459 2006-08-16  David Hyatt  <hyatt@apple.com>
1460
1461         Fix an issue with CSS2 system fonts where they did not respect text
1462         zoom.  This was most visible with the new control fonts used for form
1463         controls (they stopped swapping between small/mini/regular as you zoomed).
1464
1465         Reviewed by beth
1466
1467         * css/cssstyleselector.cpp:
1468         (WebCore::CSSStyleSelector::applyProperty):
1469
1470 2006-08-15  Justin Garcia  <justin.garcia@apple.com>
1471
1472         Reviewed by thatcher
1473         
1474         First part of fix for:
1475         <rdar://problem/4384589>
1476         Mail hung on paste text
1477         
1478         Fixes:
1479         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8592>
1480         Extra line left after deleting whitespace:pre text
1481         <rdar://problem/4128080> Paste as HTML does not yield equivalent style
1482         <rdar://problem/4046469> Box styles on first element aren't copied/pasted
1483         Copy/paste of arstechnica.com
1484         
1485         Here's how we avoid adding redundant style information on paste: insert 
1486         the fragment and do a test rendering, save away style information for 
1487         every node in the fragment, remove all style information from the fragment, 
1488         remove the fragment, insert it into the appropriate place in the document, 
1489         then restore only those styles gathered during the test insertion that aren't
1490         redundant.  Restoring the styles in this way results in an ApplyStyleCommand 
1491         and a layout for nearly every inserted node.  
1492         Instead we want to insert the fragment into the document without removing the 
1493         style information, then mark style nodes and inline style declarations for 
1494         removal if they are redundant, and sweep to remove them.  This means that we 
1495         can't rely on ReplacementFragment::wasBlock anymore, because blocks will now 
1496         have style spans around them.  This patch removes the use of wasBlock in 
1497         ReplaceSelectionCommand.
1498         
1499         * editing/CompositeEditCommand.cpp:
1500         (WebCore::CompositeEditCommand::moveParagraphs): Added code
1501         to remove the line placeholder left after a move from preserveNewline text.
1502         * editing/DeleteSelectionCommand.cpp:
1503         (WebCore::DeleteSelectionCommand::doApply): Don't add a placeholder if 
1504         we're deleting a paragraph in preserveNewline text.
1505         * editing/JSEditor.cpp: Pass true to prevent nesting.
1506         * editing/ReplaceSelectionCommand.cpp: Removed wasBlock and friends.
1507         (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
1508         (WebCore::ReplacementFragment::saveRenderingInfo): Ditto.
1509         (WebCore::RenderingInfo::RenderingInfo): Ditto.
1510         (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
1511         (WebCore::ReplaceSelectionCommand::shouldMergeStart): Combined the to/from
1512         merging rules into one method.
1513         (WebCore::ReplaceSelectionCommand::shouldMergeEnd):
1514         (WebCore::ReplaceSelectionCommand::shouldMerge):
1515         (WebCore::ReplaceSelectionCommand::doApply): 
1516         Don't do nesting prevention when pasting into an empty paragraph, this
1517         fixes 4046469, the common cause of paste fidelity bugs, but needs
1518         to be tweaked a little because this can lead to margin/border build-up
1519         on repeated copy/pastes.
1520         Don't track startPos in addition to insertionPos.  It was never used.
1521         Fixed a bug where a fragment starting with an interchange newline would
1522         cause content to be put outside of an editable region when pasting at the 
1523         very end of it.
1524         Adjust insertionPos before insertion (not during) and do not consult wasBlock
1525         to decide whether or not to do so.
1526         Changed the way we do the start merge: insert the fragment, then stich 
1527         paragraphs together, in the same way that we do the end merge.  This 
1528         doesn't require wasBlock and fixes bugs.
1529         Replaced some uses of insertionPos with endOfInsertedContent.
1530         Fixed a bug in the expansion of the last incoming br (a "collapsed" br
1531         is one where !isStartOfParagraph([br,0])).
1532         Removed the special case code that did the end merge for the preserveNewline 
1533         case, since this patch fixes the moveParagraph bug in the preserveNewline case.
1534         Removed some unused variables.
1535         (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): An endBR that was 
1536         holding a line open should always be displaced by inserted content, unless 
1537         the inserted content ends with a br.
1538         (WebCore::ReplaceSelectionCommand::updateNodesInserted):
1539         * editing/ReplaceSelectionCommand.h:
1540         (WebCore::RenderingInfo::style):
1541         * editing/markup.cpp:
1542         (WebCore::createMarkup): Only add mail blockquotes and list/table/pre when
1543         annotate is true (when we're creating markup for the pasteboard).
1544
1545 2006-08-16  John Sullivan  <sullivan@apple.com>
1546
1547         Reviewed by Brady Eidson
1548         
1549         - fixed <rdar://problem/4637156> underlines appearing in white selection text
1550
1551         * rendering/InlineFlowBox.cpp:
1552         (WebCore::InlineFlowBox::paintDecorations):
1553         bail out if phase is PaintPhaseSelection and forceWhiteText is true
1554
1555 2006-08-16  Brady Eidson  <beidson@apple.com>
1556
1557         Reviewed by John
1558
1559         Updated the DB version number and added a helpful comment explaining its meaning
1560
1561         * loader/icon/IconDatabase.cpp:
1562
1563 2006-08-16  Brady Eidson  <beidson@apple.com>
1564
1565         Reviewed by Maciej
1566
1567         Major refactoring of new iconDB:
1568         -Instead of private browsing being handled by in-memory tables, it's now handled
1569          by a separate in-memory database with the same table names.  This allows us to 
1570          re-use the same SQL on either the main or private-browsing database
1571         -So it follows, I broke out much of the SQL queries into seperate methods suffixed with
1572          "Query" that take a database as the method's argument so the same language can run on
1573          both private and main tables
1574         -Now that we have two DBs, moved the retain/release count to the m_mainDB
1575         -While I was at it, updated the schema to combine the Icon and IconResource table - cuts 
1576          down on some high-usage, low value queries which were too expensive
1577         -Ditched the _url -> url convention for escaping urls for SQL.  Now its url and escapedURL
1578         -Pruned tons of unused methods from previous revisions
1579
1580      * bridge/mac/WebCoreIconDatabaseBridge.h: Removed isIconExpiredForPageURL as it was never used 
1581         * bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
1582         * loader/icon/IconDatabase.cpp:
1583         (WebCore::IconDatabase::IconDatabase): Updated initializer list
1584         (WebCore::IconDatabase::open): Sets up both databases
1585         (WebCore::IconDatabase::close): Closes both databases
1586         (WebCore::IconDatabase::isEmpty): Queries both databases for at least 1 record
1587         (WebCore::IconDatabase::isValidDatabase): Reflect the updated schema
1588         (WebCore::IconDatabase::clearDatabaseTables): Ditto - and takes DB as a parameter
1589         (WebCore::IconDatabase::createDatabaseTables): Ditto
1590         (WebCore::IconDatabase::imageDataForIconURL): style cleanup, and using a query-function
1591         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Resets private DB instead of private tables
1592         (WebCore::IconDatabase::isIconExpiredForIconURL): Uses a query-function on each DB
1593         (WebCore::IconDatabase::iconURLForPageURL): Uses a query-function on each DB
1594         (WebCore::IconDatabase::retainIconForPageURL): Retain count DB changes 
1595         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
1596         (WebCore::IconDatabase::isIconURLRetained): Determine if it's time to prune a released icon yet
1597         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): Alot simpler
1598         (WebCore::IconDatabase::setIconDataForIconURL): Style cleanup
1599         (WebCore::IconDatabase::setHaveNoIconForIconURL): Ditto
1600         (WebCore::IconDatabase::setIconURLForPageURL): Ditto - and using a query-function
1601         (WebCore::IconDatabase::establishIconIDForIconURL): Style cleanup
1602         (WebCore::IconDatabase::pruneUnreferencedIcons): DB name change
1603         (WebCore::IconDatabase::pruneUnretainedIcons): Ditto
1604         (WebCore::IconDatabase::hasIconForIconURL): Simpler, using a query-function
1605         (WebCore::IconDatabase::~IconDatabase):
1606         (WebCore::pageURLTableIsEmptyQuery): Self-explanatory SQL query
1607         (WebCore::imageDataForIconURLQuery): Self-explanatory SQL query
1608         (WebCore::timeStampForIconURLQuery): Self-explanatory SQL query
1609         (WebCore::iconURLForPageURLQuery): Self-explanatory SQL query
1610         (WebCore::forgetPageURLQuery): Self-explanatory SQL query
1611         (WebCore::setIconIDForPageURLQuery): Self-explanatory SQL query
1612         (WebCore::getIconIDForIconURLQuery): Self-explanatory SQL query
1613         (WebCore::addIconForIconURLQuery): Self-explanatory SQL query
1614         (WebCore::hasIconForIconURLQuery): Self-explanatory SQL query
1615      * loader/icon/IconDatabase.h: Some new/changed methods, pruned methods, and new comments
1616         (WebCore::IconDatabase::isOpen):  Changed our meaning of "isOpen" to reflect the 2 databases
1617
1618 2006-08-15  Jonas Witt <jonas.witt@gmail.com>
1619
1620         Reviewed by Darin.
1621
1622         - added ObjC wrappers for the KeyboardEvent and WheelEvent initializers
1623           http://bugzilla.opendarwin.org/show_bug.cgi?id=9736
1624
1625         * bindings/objc/DOMEvents.mm:
1626         (-[DOMKeyboardEvent initKeyboardEvent::::::::::]):
1627         * bindings/objc/DOMEventsNonstandard.mm:
1628         (-[DOMWheelEvent initWheelEvent:::::::::::]):
1629         * bindings/objc/DOMPrivate.h:
1630
1631         - added an initializer for the WheelEvent
1632
1633         * dom/WheelEvent.cpp:
1634         (WebCore::WheelEvent::initWheelEvent):
1635         * dom/WheelEvent.h:
1636
1637 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1638
1639         Reviewed by Tim H.
1640
1641         Build fix:  DWARF and -gfull are incompatible with symbol separation.
1642
1643         * WebCore.xcodeproj/project.pbxproj:
1644
1645 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1646
1647         Reviewed by Tim H.
1648
1649         http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
1650         Bug 10394: WebKit Release and Production configurations should enable dead code stripping
1651
1652         * WebCore.xcodeproj/project.pbxproj:
1653
1654 2006-08-15  Geoffrey Garen  <ggaren@apple.com>
1655
1656         Reviewed by Darin.
1657         
1658         - This patch reworks a previous fix for <rdar://problem/3524912> repro 
1659         crash in KHTMLParser::parseToken, due to parser's current element being 
1660         destroyed (www.gnnetcom.dk), along with subsequent adjustments to fix
1661         leaks.
1662         
1663         The previous solutions caused a ~2% performance regression on iBench HTML,
1664         due to RefPtr churn. The optimizations here gain back that ~2% plus ~1% more,
1665         for a total win of ~3% vs current TOT.
1666         
1667         We can merge this fix to the branch to fix <rdar://problem/4661982> 
1668         (crash in KHTMLParser::popBlock).
1669         
1670         The solution here is:
1671         (1) Don't let the parser ref document nodes -- that causes leaks.
1672         (2) Handle ref/deref manually, to avoid RefPtr churn. Specifically, when 
1673         moving a node between stacks or to/from 'current', rather than deref'ing
1674         and then ref'ing again, simply move the node, along with its refcount, to
1675         its new location, and overwrite its old location.
1676  
1677         * WebCore.xcodeproj/project.pbxproj:
1678         * html/HTMLParser.cpp:
1679         (WebCore::HTMLStackElem::HTMLStackElem):
1680         (WebCore::HTMLStackElem::derefNode):
1681         (WebCore::HTMLParser::HTMLParser):
1682         (WebCore::HTMLParser::setCurrent):
1683         (WebCore::HTMLParser::insertNode):
1684         (WebCore::HTMLParser::popNestedHeaderTag):
1685         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1686         (WebCore::HTMLParser::reopenResidualStyleTags):
1687         (WebCore::HTMLParser::pushBlock):
1688         (WebCore::HTMLParser::popBlock):
1689         (WebCore::HTMLParser::popOneBlockCommon):
1690         (WebCore::HTMLParser::popOneBlock):
1691         (WebCore::HTMLParser::moveOneBlockToStack):
1692         * html/HTMLParser.h:
1693
1694 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1695
1696         Reviewed by Tim H.
1697
1698         http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
1699         Bug 10384: Switch to DWARF for Release configuration
1700
1701         * WebCore.xcodeproj/project.pbxproj:
1702
1703 2006-08-15  Mark Rowe  <opendarwin.org@bdash.net.nz>
1704
1705         Reviewed by Hyatt.
1706         Tweaked and landed by Darin.
1707
1708         http://bugzilla.opendarwin.org/show_bug.cgi?id=10399
1709         Bug 10399: RenderTextArea is unused
1710
1711         * WebCore.vcproj/WebCore/WebCore.vcproj:
1712         * WebCore.xcodeproj/project.pbxproj:
1713         * WebCoreSources.bkl:
1714         Removed RenderTextArea source files.
1715
1716         * html/HTMLTextAreaElement.cpp: Removed include of RenderTextArea.h.
1717         * html/HTMLTextAreaElement.h: Removed forward declaration of RenderTextArea.
1718
1719         * platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Updated a comment.
1720
1721         * platform/TextBox.h: Removed.
1722         * platform/mac/TextBoxMac.mm: Removed.
1723         * platform/mac/WebCoreTextArea.h: Removed.
1724         * platform/mac/WebCoreTextArea.mm: Removed.
1725         * rendering/RenderTextArea.cpp: Removed.
1726         * rendering/RenderTextArea.h: Removed.
1727
1728 2006-08-15  Brady Eidson  <beidson@apple.com>
1729
1730         Reviewed by THE OTHER Maciej...
1731
1732         Two small fixes -
1733         1) Renamed retain/release methods to add PageUrl in - we're being consistent and clear in the WebCore API
1734         2) Fixed a bug where a null SiteIcon reference would be added into the pageURLToSiteIcon map causing a
1735         null dereference later
1736
1737         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1738         (-[WebCoreIconDatabaseBridge retainIconForURL:]):  Changed IconDatabase method name
1739         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):  ditto
1740         * loader/icon/IconDatabase.cpp:
1741         (WebCore::IconDatabase::retainIconForPageURL):  Name change
1742         (WebCore::IconDatabase::releaseIconForPageURL):  ditto
1743         (WebCore::IconDatabase::setIconURLForPageURL):  Added the null site-icon check when changing a PageURL's iconURL
1744         * loader/icon/IconDatabase.h:  Some renames
1745
1746 2006-08-14  Eric Seidel  <eric@eseidel.com>
1747
1748         Reviewed by mjs.
1749
1750         <mask>, <marker>, <pattern> inside <defs> do not work
1751         http://bugzilla.opendarwin.org/show_bug.cgi?id=6548
1752
1753         * ksvg2/svg/SVGDefsElement.cpp:
1754         (WebCore::SVGDefsElement::SVGDefsElement): moved to .cpp file
1755         (WebCore::SVGDefsElement::isValid): moved to .cpp file
1756         (WebCore::SVGDefsElement::rendererIsNeeded): Added.
1757         (WebCore::SVGDefsElement::createRenderer): Added.
1758         * ksvg2/svg/SVGDefsElement.h:
1759         * ksvg2/svg/SVGGElement.cpp:
1760         (WebCore::SVGGElement::SVGGElement): adjusted spacing
1761         (WebCore::SVGGElement::parseMappedAttribute): adjusted spacing
1762         (WebCore::SVGDummyElement::SVGDummyElement): adjusted spacing
1763
1764 2006-08-14  Eric Seidel  <eric@eseidel.com>
1765
1766         Reviewed by darin and mjs.
1767         
1768         Add better SVGLoad event support.
1769         http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
1770         There will still need to be additional support added for <link> and <script> elements.
1771         Not all of the error -> loaded -> error transition cases work yet.
1772
1773         * dom/EventTargetNode.cpp:
1774         (WebCore::EventTargetNode::dispatchGenericEvent):
1775         * html/HTMLImageLoader.cpp:
1776         (WebCore::HTMLImageLoader::dispatchLoadEvent):
1777         * html/HTMLImageLoader.h:
1778         (WebCore::HTMLImageLoader::haveFiredLoadEvent):
1779         (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
1780         * ksvg2/misc/SVGImageLoader.cpp:
1781         (WebCore::SVGImageLoader::SVGImageLoader):
1782         (WebCore::SVGImageLoader::dispatchLoadEvent):
1783         * ksvg2/misc/SVGImageLoader.h:
1784         * ksvg2/svg/SVGAElement.cpp:
1785         (WebCore::SVGAElement::parseMappedAttribute):
1786         * ksvg2/svg/SVGAnimatedBoolean.h:
1787         * ksvg2/svg/SVGElement.cpp:
1788         (WebCore::SVGElement::SVGElement):
1789         (WebCore::SVGElement::parseMappedAttribute):
1790         (WebCore::SVGElement::haveLoadedRequiredResources):
1791         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1792         (WebCore::SVGElement::closeRenderer):
1793         * ksvg2/svg/SVGElement.h:
1794         (WebCore::SVGElement::rendererIsNeeded):
1795         (WebCore::svg_dynamic_cast):
1796         * ksvg2/svg/SVGExternalResourcesRequired.h:
1797         * ksvg2/svg/SVGImageElement.cpp:
1798         (SVGImageElement::SVGImageElement):
1799         (SVGImageElement::haveLoadedRequiredResources):
1800         * ksvg2/svg/SVGImageElement.h:
1801         * ksvg2/svg/SVGSVGElement.cpp:
1802         (WebCore::SVGSVGElement::parseMappedAttribute):
1803         * ksvg2/svg/SVGScriptElement.cpp:
1804         (WebCore::SVGScriptElement::SVGScriptElement):
1805         (WebCore::SVGScriptElement::parseMappedAttribute):
1806         (WebCore::SVGScriptElement::executeScript):
1807         * xml/xmlhttprequest.cpp:
1808         (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
1809
1810 2006-08-14  Anders Carlsson  <acarlsson@apple.com>
1811
1812         Reviewed by Maciej.
1813
1814         http://bugzilla.opendarwin.org/show_bug.cgi?id=10393
1815         Autogenerate NodeIterator and TreeWalker.
1816         
1817         * DerivedSources.make:
1818         * WebCore.xcodeproj/project.pbxproj:
1819         Add new files.
1820         
1821         * bindings/js/JSNodeIteratorCustom.cpp: Added.
1822         (WebCore::JSNodeIterator::mark):
1823         * bindings/js/JSTreeWalkerCustom.cpp: Added.
1824         (WebCore::JSTreeWalker::mark):
1825         
1826         * bindings/js/kjs_traversal.cpp:
1827         * bindings/js/kjs_traversal.h:
1828         Remove implementations of DOMNodeIterator and DOMTreeWalker.
1829
1830         * bindings/scripts/CodeGeneratorJS.pm:
1831         Add "CustomMarkFunction" attribute for classes where mark() needs to be overridden.
1832         
1833         * bindings/objc/DOM.mm:
1834         (-[DOMNodeIterator detach]):
1835         * dom/NodeIterator.cpp:
1836         (WebCore::NodeIterator::detach):
1837         * dom/NodeIterator.h:
1838         Get rid of exception in detach, it isn't used at all and this function can't throw an exception according to the spec.
1839         * dom/NodeIterator.idl: Added.
1840         * dom/TreeWalker.idl: Added.
1841
1842 2006-08-14  Brady Eidson  <beidson@apple.com>
1843
1844         Reviewed by John
1845
1846         The changes are plentiful, but small, mostly to improve performance
1847         1) Add a bool flag to SiteIcon to stop it from querying the database over and over
1848         2) Added a pageURL->iconURL hashmap to cache database results, as an optimization
1849         3) Fix a bug in setIconURLForPageURL code where the pageURL would still point to an old icon
1850         4) Added isIconURLRetained() to optimize the retain count check
1851         5) Prune old, unused code
1852
1853         * loader/icon/IconDatabase.cpp:
1854         (WebCore::IconDatabase::imageDataForIconID): Removed unused code
1855         (WebCore::IconDatabase::imageDataForIconURL): Removed unused code
1856         (WebCore::IconDatabase::imageDataForPageURL): Removed unused code
1857         (WebCore::IconDatabase::isIconExpiredForIconURL): Removed LOG msg
1858         (WebCore::IconDatabase::isIconExpiredForPageURL): Removed LOG msg
1859         (WebCore::IconDatabase::iconURLForPageURL): Added a hashmap cache to avoid common queries
1860         (WebCore::IconDatabase::releaseIconForURL): Changed to is isRetained() instead of retainCount()
1861         (WebCore::IconDatabase::isIconURLRetained): Added - we don't care about the actual retain count
1862           for an icon so much as whether or not it is retained
1863         (WebCore::IconDatabase::setIconURLForPageURL): If the new and old iconURLs are the same, skip the
1864           SQLite code
1865         * loader/icon/IconDatabase.h:  Added new methods/variables
1866         * loader/icon/SiteIcon.cpp:
1867         (SiteIcon::SiteIcon): Added a flag so it only queries the database for icon data once
1868         (SiteIcon::getImage): Ditto
1869
1870 2006-08-14  David Hyatt  <hyatt@apple.com>
1871
1872         Fix for bug 10385, add more support for crappy pseudo-XML-in-HTML.
1873
1874         Reviewed by ggaren
1875
1876         Added fast/parser/bad-xml-slash.html
1877
1878         * html/HTMLTokenizer.cpp:
1879         (WebCore::HTMLTokenizer::parseTag):
1880
1881 2006-08-14  Darin Adler  <darin@apple.com>
1882
1883         Reviewed by John Sullivan.
1884
1885         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10204
1886           REGRESSION: title tag parsing problem breaks Travelocity and Google Analytics pages
1887
1888         Test: fast/parser/title-error-test.html
1889
1890         * html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Fixed an error
1891         handling case that was skipping until a </style> tag in code that was shared
1892         between both <title> and <style>. Also rearranged the code a tiny bit.
1893
1894 2006-08-14  Darin Adler  <darin@apple.com>
1895
1896         Reviewed by Hyatt.
1897
1898         - fixed some storage leaks
1899           (part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10259)
1900
1901         * platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
1902         Rearrange code so that "delete this" is called any time the function returns
1903         false -- ownership was inconsistent before.
1904
1905         * rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
1906         Call deleteLineBoxWrapper even when documentBeingDestroyed() is true, because
1907         some of what it does has to be done during destruction. A little awkward since
1908         I preserved the order of operations. Perhaps we could structure this better later.
1909
1910 2006-08-14  David Harrison  <harrison@apple.com>
1911
1912         Reviewed by John Sullivan and Geoff Garen.
1913
1914         <rdar://problem/3854950> AX Seed: Blackboard Learning Systems - frame names need to be put in AXDescription AXAttribute
1915
1916         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
1917         is not possible.  See following bug...
1918             <rdar://problem/4256882> Need automated testing support for accessibility APIs
1919
1920         * bridge/mac/WebCoreAXObject.mm:
1921         (-[WebCoreAXObject accessibilityDescription]):
1922         For a web area, return the name of the owning frame or iframe.
1923         
1924         (-[WebCoreAXObject accessibilityAttributeNames]):
1925         Advertize NSAccessibilityDescriptionAttribute.
1926         
1927         (-[WebCoreAXObject rendererForView:]):
1928         Clean up some old naming.
1929
1930 2006-08-11  Anders Carlsson  <acarlsson@apple.com>
1931
1932         Reviewed by Darin.
1933
1934         http://bugzilla.opendarwin.org/show_bug.cgi?id=10353
1935         XMLSerializer and DOMParser should have real implementations
1936         
1937         Make real implementation files for DOMParser and XMLSerializer and wrap them
1938         using our bindings generation.
1939         
1940         * DerivedSources.make:
1941         * WebCore.xcodeproj/project.pbxproj:
1942         * bindings/js/JSDOMParser.cpp: Removed.
1943         * bindings/js/JSDOMParser.h: Removed.
1944         * bindings/js/JSXMLSerializer.cpp: Removed.
1945         * bindings/js/JSXMLSerializer.h: Removed.
1946         * bindings/js/kjs_window.cpp:
1947         (KJS::Window::getValueProperty):
1948         * bindings/js/kjs_window.h:
1949         (KJS::Window::):
1950         * page/DOMWindow.idl:
1951         * xml/DOMParser.cpp: Added.
1952         (WebCore::DOMParser::parseFromString):
1953         * xml/DOMParser.h: Added.
1954         * xml/DOMParser.idl: Added.
1955         * xml/XMLSerializer.cpp: Added.
1956         (WebCore::XMLSerializer::serializeToString):
1957         * xml/XMLSerializer.h: Added.
1958         * xml/XMLSerializer.idl: Added.
1959
1960 2006-08-14  Maciej Stachowiak  <mjs@apple.com>
1961
1962         Reviewed by Brady.
1963
1964         - removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
1965
1966         * WebCore.exp: export new functions
1967         * platform/mac/WebCoreSystemInterface.h: Added CFReadStream related functions
1968         * platform/mac/WebCoreSystemInterface.mm: ditto
1969
1970 2006-08-13  Maks Orlovich  <maksim@kde.org>
1971
1972         Reviewed (and tweaked a little) by Maciej.
1973         
1974         - shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting
1975         in a 1.2% speed improvement on JS iBench (and probably overall memory savings).
1976
1977         The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.
1978         
1979         * bindings/js/kjs_events.cpp:
1980         (KJS::JSLazyEventListener::parseCode):
1981
1982 2006-08-12  Eric Seidel  <eric@eseidel.com>
1983
1984         Reviewed by hyatt and mjs.
1985
1986         Fix two missing null checks causing layout test crashes.
1987
1988         * css/cssstyleselector.cpp:
1989         (WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
1990         * kcanvas/RenderSVGContainer.cpp:
1991         (WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null
1992
1993
1994 2006-08-11  Eric Seidel  <eric@eseidel.com>
1995
1996         Reviewed by andersca.
1997
1998         The outermost <svg> element needs to clip itself
1999         http://bugzilla.opendarwin.org/show_bug.cgi?id=5358
2000
2001         * css/cssstyleselector.cpp:
2002         (WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
2003         * kcanvas/RenderSVGContainer.cpp:
2004         (WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG
2005         (WebCore::RenderSVGContainer::paint):
2006         * kcanvas/device/KRenderingDevice.h:
2007         * kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
2008         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods
2009         (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
2010         * ksvg2/svg/SVGPaint.cpp: spacing changes
2011         (WebCore::SVGPaint::SVGPaint): spacing cleanup
2012         * ksvg2/svg/SVGSVGElement.cpp:
2013         (WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
2014         * platform/GraphicsContext.h: Added concatCTM
2015         * platform/cg/GraphicsContextCG.cpp:
2016         (WebCore::GraphicsContext::concatCTM): Added.
2017
2018 2006-08-11  Brady Eidson  <beidson@apple.com>
2019
2020         Reviewed by Maciej
2021
2022         Renamed a method/parameter for clarity and consistency, as well as some style
2023         cleanups and removing some ridiculously verbose log messages.
2024         Also added an _isEmpty method to the database and bridge for WebKit's use.
2025         Finally, added a central way for both WebKit and WebCore to get the icon database filename
2026
2027         * bridge/mac/WebCoreIconDatabaseBridge.h:  Added _isEmpty and defaultDatabaseFilename
2028         * bridge/mac/WebCoreIconDatabaseBridge.mm:  Removed an unnecessary semicolon off most of these methods
2029         (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]):
2030         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2031         (-[WebCoreIconDatabaseBridge isOpen]):
2032         (-[WebCoreIconDatabaseBridge _isEmpty]):  Added
2033         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2034         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2035         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2036         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2037         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2038         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2039         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2040         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2041         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2042         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2043         (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
2044         (-[WebCoreIconDatabaseBridge defaultDatabaseFilename]):  Added
2045
2046         * loader/icon/IconDatabase.cpp:
2047         (WebCore::IconDatabase::defaultDatabaseFilename):  Added
2048         (WebCore::IconDatabase::open):  
2049         (WebCore::IconDatabase::isEmpty):  Added
2050         (WebCore::IconDatabase::retainIconForURL):  Removed log message
2051         (WebCore::IconDatabase::releaseIconForURL):  Removed log message
2052         * loader/icon/IconDatabase.h: 
2053
2054 2006-08-11  David Hyatt  <hyatt@apple.com>
2055
2056         Eliminate RenderImageButton.
2057
2058         Reviewed by darin
2059
2060         * WebCore.xcodeproj/project.pbxproj:
2061         * bridge/mac/WebCoreAXObject.mm:
2062         (-[WebCoreAXObject isImageButton]):
2063         * html/HTMLInputElement.cpp:
2064         (WebCore::HTMLInputElement::createRenderer):
2065         * rendering/RenderImage.h:
2066         (WebCore::RenderImage::isImage):
2067
2068 2006-08-11  Adele Peterson  <adele@apple.com>
2069
2070         Reviewed by Brady.
2071
2072         - Fix for <rdar://problem/4656274> 
2073         REGRESSION: option elements are selected when added regardless of "selected" property
2074
2075         Test: fast/forms/option-constructor-selected.html
2076
2077         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption):
2078         When adding an option element, check that the option element is selected before calling setSelectedIndex.
2079
2080 2006-08-11  David Hyatt  <hyatt@apple.com>
2081
2082         Fix for bug 10349, make sure to call setChanged when an anchor changes
2083         from not being a link to being a link (and vice versa).
2084
2085         Test is in fast/dynamic/link-href-change.html
2086
2087         Reviewed by darin
2088
2089         * html/HTMLAnchorElement.cpp:
2090         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
2091         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2092         * html/HTMLAnchorElement.h:
2093         * html/HTMLAreaElement.cpp:
2094         (WebCore::HTMLAreaElement::parseMappedAttribute):
2095
2096 2006-08-09  Rob Buis  <buis@kde.org>
2097
2098         Reviewed by Darin.
2099
2100         Revert an over-optimization step that messed up the HashSet lookup.
2101
2102         * dom/DOMImplementation.cpp:
2103
2104 2006-08-12  Oliver  <ojh16@student.canterbury.ac.nz>
2105
2106         Rubber stamped by tim
2107
2108         Removed commented out code
2109
2110         * kcanvas/RenderSVGImage.cpp:
2111         (WebCore::RenderSVGImage::paint):
2112
2113 2006-08-12  Oliver  <ojh16@student.canterbury.ac.nz>
2114
2115         Reviewed by geoff
2116
2117         Fixed regression in SVG image layout
2118         (see bug #10346)
2119
2120         * kcanvas/RenderSVGImage.cpp:
2121         (WebCore::RenderSVGImage::paint):
2122
2123 2006-08-10  Anders Carlsson  <acarlsson@apple.com>
2124
2125         Rubber-stamped by Maciej.
2126
2127         Move xpath to xml.
2128         
2129         * DerivedSources.make:
2130         * WebCore.vcproj/WebCore/WebCore.vcproj:
2131         * WebCore.xcodeproj/project.pbxproj:
2132         * xpath/XPathEvaluator.cpp: Removed.
2133         * xpath/XPathEvaluator.h: Removed.
2134         * xpath/XPathEvaluator.idl: Removed.
2135         * xpath/XPathExpression.cpp: Removed.
2136         * xpath/XPathExpression.h: Removed.
2137         * xpath/XPathExpression.idl: Removed.
2138         * xpath/XPathNSResolver.cpp: Removed.
2139         * xpath/XPathNSResolver.h: Removed.
2140         * xpath/XPathNSResolver.idl: Removed.
2141         * xpath/XPathNamespace.cpp: Removed.
2142         * xpath/XPathNamespace.h: Removed.
2143         * xpath/XPathResult.cpp: Removed.
2144         * xpath/XPathResult.h: Removed.
2145         * xpath/XPathResult.idl: Removed.
2146         * xpath/impl/XPathExpressionNode.cpp: Removed.
2147         * xpath/impl/XPathExpressionNode.h: Removed.
2148         * xpath/impl/XPathFunctions.cpp: Removed.
2149         * xpath/impl/XPathFunctions.h: Removed.
2150         * xpath/impl/XPathGrammar.y: Removed.
2151         * xpath/impl/XPathParser.cpp: Removed.
2152         * xpath/impl/XPathParser.h: Removed.
2153         * xpath/impl/XPathPath.cpp: Removed.
2154         * xpath/impl/XPathPath.h: Removed.
2155         * xpath/impl/XPathPredicate.cpp: Removed.
2156         * xpath/impl/XPathPredicate.h: Removed.
2157         * xpath/impl/XPathStep.cpp: Removed.
2158         * xpath/impl/XPathStep.h: Removed.
2159         * xpath/impl/XPathUtil.cpp: Removed.
2160         * xpath/impl/XPathUtil.h: Removed.
2161         * xpath/impl/XPathValue.cpp: Removed.
2162         * xpath/impl/XPathValue.h: Removed.
2163         * xpath/impl/XPathVariableReference.cpp: Removed.
2164         * xpath/impl/XPathVariableReference.h: Removed.
2165
2166 2006-08-10  David Harrison  <harrison@apple.com>
2167
2168         Reviewed by John Sullivan.
2169
2170         <rdar://problem/4600112> REGRESSION: VO no longer able to review text within an edit field on web pages
2171
2172         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
2173         is not possible.  See following bug...
2174             <rdar://problem/4256882> Need automated testing support for accessibility APIs
2175
2176         * bridge/mac/WebCoreAXObject.mm:
2177         (-[WebCoreAXObject value]):
2178         Add handling for text input fields.
2179
2180 2006-08-09  Graham Dennis  <graham.dennis@gmail.com>
2181
2182         Reviewed by Darin.
2183
2184         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10247
2185         REGRESSION: Unable to build webkit without SVG/XPATH
2186
2187         * bindings/js/kjs_binding.cpp:
2188         (KJS::setDOMException):
2189         * bindings/js/kjs_dom.cpp:
2190         (KJS::toJS):
2191         * bindings/js/kjs_html.cpp:
2192         (KJS::HTMLElementFunction::callAsFunction):
2193         * bindings/js/kjs_proxy.cpp:
2194         * bindings/js/kjs_proxy.h:
2195         * bindings/objc/DOMInternal.h:
2196         * bindings/objc/DOMInternal.mm:
2197         (raiseDOMException):
2198         * bindings/objc/DOMXPath.mm:
2199         * bindings/objc/DOMXPathInternal.h:
2200         * bindings/scripts/CodeGeneratorJS.pm:
2201         * bridge/mac/WebCoreFrameBridge.mm:
2202         (+[WebCoreFrameBridge supportedNonImageMIMETypes]):
2203         * css/CSSGrammar.y:
2204         * css/CSSStyleDeclaration.cpp:
2205         (WebCore::propertyID):
2206         * css/cssparser.cpp:
2207         (WebCore::CSSParser::parseValue):
2208         * css/cssparser.h:
2209         * css/cssstyleselector.cpp:
2210         (WebCore::CSSStyleSelector::loadDefaultStyle):
2211         (WebCore::CSSStyleSelector::applyProperty):
2212         * css/cssstyleselector.h:
2213         * dom/Document.cpp:
2214         (WebCore::Document::Document):
2215         (WebCore::Document::~Document):
2216         (WebCore::Document::createElementNS):
2217         (WebCore::Document::implicitClose):
2218         (WebCore::Document::recalcStyleSelector):
2219         (WebCore::Document::createEvent):
2220         * dom/Document.h:
2221         * dom/Document.idl:
2222         * dom/Node.cpp:
2223         (WebCore::Node::createRendererIfNeeded):
2224         * dom/Node.h:
2225         * dom/XMLTokenizer.cpp:
2226         (WebCore::XMLTokenizer::endElementNs):
2227         (WebCore::XMLTokenizer::insertErrorMessageBlock):
2228         * html/HTMLEmbedElement.cpp:
2229         * html/HTMLEmbedElement.h:
2230         * html/HTMLObjectElement.cpp:
2231         * html/HTMLObjectElement.h:
2232         * kcanvas/KCanvasCreator.cpp:
2233         * kcanvas/KCanvasCreator.h:
2234         * kcanvas/KCanvasFilters.cpp:
2235         * kcanvas/KCanvasFilters.h:
2236         * kcanvas/KCanvasImage.h:
2237         * kcanvas/KCanvasMatrix.cpp:
2238         * kcanvas/KCanvasMatrix.h:
2239         * kcanvas/KCanvasPath.cpp:
2240         * kcanvas/KCanvasPath.h:
2241         * kcanvas/KCanvasResourceListener.h:
2242         * kcanvas/KCanvasResources.cpp:
2243         * kcanvas/KCanvasResources.h:
2244         * kcanvas/KCanvasTreeDebug.cpp:
2245         * kcanvas/RenderForeignObject.cpp:
2246         * kcanvas/RenderForeignObject.h:
2247         * kcanvas/RenderPath.cpp:
2248         * kcanvas/RenderPath.h:
2249         * kcanvas/RenderSVGContainer.cpp:
2250         * kcanvas/RenderSVGContainer.h:
2251         * kcanvas/RenderSVGImage.cpp:
2252         * kcanvas/RenderSVGImage.h:
2253         * kcanvas/RenderSVGText.cpp:
2254         * kcanvas/RenderSVGText.h:
2255         * kcanvas/device/KRenderingDevice.cpp:
2256         * kcanvas/device/KRenderingDevice.h:
2257         * kcanvas/device/KRenderingFillPainter.cpp:
2258         * kcanvas/device/KRenderingFillPainter.h:
2259         * kcanvas/device/KRenderingPaintServer.h:
2260         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2261         * kcanvas/device/KRenderingPaintServerGradient.h:
2262         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2263         * kcanvas/device/KRenderingPaintServerPattern.h:
2264         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2265         * kcanvas/device/KRenderingPaintServerSolid.h:
2266         * kcanvas/device/KRenderingStrokePainter.cpp:
2267         * kcanvas/device/KRenderingStrokePainter.h:
2268         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2269         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2270         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2271         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2272         * kcanvas/device/quartz/KCanvasPathQuartz.mm:
2273         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2274         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2275         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2276         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2277         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2278         * kcanvas/device/quartz/QuartzSupport.h:
2279         * kcanvas/device/quartz/QuartzSupport.mm:
2280         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
2281         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h:
2282         * ksvg2/css/SVGCSSParser.cpp:
2283         * ksvg2/css/SVGCSSStyleSelector.cpp:
2284         * ksvg2/css/SVGRenderStyle.cpp:
2285         * ksvg2/css/SVGRenderStyle.h:
2286         * ksvg2/css/SVGRenderStyleDefs.cpp:
2287         * ksvg2/css/SVGRenderStyleDefs.h:
2288         * ksvg2/ecma/GlobalObject.cpp:
2289         * ksvg2/ecma/GlobalObject.h:
2290         * ksvg2/events/JSSVGLazyEventListener.cpp:
2291         * ksvg2/events/JSSVGLazyEventListener.h:
2292         * ksvg2/events/SVGZoomEvent.cpp:
2293         * ksvg2/events/SVGZoomEvent.h:
2294         * ksvg2/ksvg.h:
2295         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2296         * ksvg2/misc/KCanvasRenderingStyle.h:
2297         * ksvg2/misc/KSVGTimeScheduler.cpp:
2298         * ksvg2/misc/KSVGTimeScheduler.h:
2299         * ksvg2/misc/SVGDocumentExtensions.cpp:
2300         * ksvg2/misc/SVGDocumentExtensions.h:
2301         * ksvg2/misc/SVGImageLoader.cpp:
2302         * ksvg2/misc/SVGImageLoader.h:
2303         * ksvg2/svg/DOMList.h:
2304         * ksvg2/svg/SVGAElement.cpp:
2305         * ksvg2/svg/SVGAElement.h:
2306         * ksvg2/svg/SVGAngle.cpp:
2307         * ksvg2/svg/SVGAngle.h:
2308         * ksvg2/svg/SVGAnimateColorElement.cpp:
2309         * ksvg2/svg/SVGAnimateColorElement.h:
2310         * ksvg2/svg/SVGAnimateElement.cpp:
2311         * ksvg2/svg/SVGAnimateElement.h:
2312         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2313         * ksvg2/svg/SVGAnimateTransformElement.h:
2314         * ksvg2/svg/SVGAnimatedAngle.cpp:
2315         * ksvg2/svg/SVGAnimatedAngle.h:
2316         * ksvg2/svg/SVGAnimatedBoolean.cpp:
2317         * ksvg2/svg/SVGAnimatedBoolean.h:
2318         * ksvg2/svg/SVGAnimatedColor.cpp:
2319         * ksvg2/svg/SVGAnimatedColor.h:
2320         * ksvg2/svg/SVGAnimatedEnumeration.cpp:
2321         * ksvg2/svg/SVGAnimatedEnumeration.h:
2322         * ksvg2/svg/SVGAnimatedInteger.cpp:
2323         * ksvg2/svg/SVGAnimatedInteger.h:
2324         * ksvg2/svg/SVGAnimatedLength.cpp:
2325         * ksvg2/svg/SVGAnimatedLength.h:
2326         * ksvg2/svg/SVGAnimatedLengthList.cpp:
2327         * ksvg2/svg/SVGAnimatedLengthList.h:
2328         * ksvg2/svg/SVGAnimatedNumber.cpp:
2329         * ksvg2/svg/SVGAnimatedNumber.h:
2330         * ksvg2/svg/SVGAnimatedNumberList.cpp:
2331         * ksvg2/svg/SVGAnimatedNumberList.h:
2332         * ksvg2/svg/SVGAnimatedPathData.cpp:
2333         * ksvg2/svg/SVGAnimatedPathData.h:
2334         * ksvg2/svg/SVGAnimatedPoints.cpp:
2335         * ksvg2/svg/SVGAnimatedPoints.h:
2336         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.cpp:
2337         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
2338         * ksvg2/svg/SVGAnimatedRect.cpp:
2339         * ksvg2/svg/SVGAnimatedRect.h:
2340         * ksvg2/svg/SVGAnimatedString.cpp:
2341         * ksvg2/svg/SVGAnimatedString.h:
2342         * ksvg2/svg/SVGAnimatedTemplate.h:
2343         * ksvg2/svg/SVGAnimatedTransformList.cpp:
2344         * ksvg2/svg/SVGAnimatedTransformList.h:
2345         * ksvg2/svg/SVGAnimationElement.cpp:
2346         * ksvg2/svg/SVGAnimationElement.h:
2347         * ksvg2/svg/SVGCircleElement.cpp:
2348         * ksvg2/svg/SVGCircleElement.h:
2349         * ksvg2/svg/SVGClipPathElement.cpp:
2350         * ksvg2/svg/SVGClipPathElement.h:
2351         * ksvg2/svg/SVGColor.cpp:
2352         * ksvg2/svg/SVGColor.h:
2353         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2354         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
2355         * ksvg2/svg/SVGCursorElement.cpp:
2356         * ksvg2/svg/SVGCursorElement.h:
2357         * ksvg2/svg/SVGDOMImplementation.cpp:
2358         * ksvg2/svg/SVGDOMImplementation.h:
2359         * ksvg2/svg/SVGDefsElement.cpp:
2360         * ksvg2/svg/SVGDefsElement.h:
2361         * ksvg2/svg/SVGDescElement.cpp:
2362         * ksvg2/svg/SVGDescElement.h:
2363         * ksvg2/svg/SVGDocument.cpp:
2364         * ksvg2/svg/SVGDocument.h:
2365         * ksvg2/svg/SVGElement.cpp:
2366         * ksvg2/svg/SVGElement.h:
2367         * ksvg2/svg/SVGElementInstance.cpp:
2368         * ksvg2/svg/SVGElementInstance.h:
2369         * ksvg2/svg/SVGElementInstanceList.cpp:
2370         * ksvg2/svg/SVGElementInstanceList.h:
2371         * ksvg2/svg/SVGEllipseElement.cpp:
2372         * ksvg2/svg/SVGEllipseElement.h:
2373         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
2374         * ksvg2/svg/SVGExternalResourcesRequired.h:
2375         * ksvg2/svg/SVGFEBlendElement.cpp:
2376         * ksvg2/svg/SVGFEBlendElement.h:
2377         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2378         * ksvg2/svg/SVGFEColorMatrixElement.h:
2379         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2380         * ksvg2/svg/SVGFEComponentTransferElement.h:
2381         * ksvg2/svg/SVGFECompositeElement.cpp:
2382         * ksvg2/svg/SVGFECompositeElement.h:
2383         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2384         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
2385         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2386         * ksvg2/svg/SVGFEDisplacementMapElement.h:
2387         * ksvg2/svg/SVGFEDistantLightElement.cpp:
2388         * ksvg2/svg/SVGFEDistantLightElement.h:
2389         * ksvg2/svg/SVGFEFloodElement.cpp:
2390         * ksvg2/svg/SVGFEFloodElement.h:
2391         * ksvg2/svg/SVGFEFuncAElement.cpp:
2392         * ksvg2/svg/SVGFEFuncAElement.h:
2393         * ksvg2/svg/SVGFEFuncBElement.cpp:
2394         * ksvg2/svg/SVGFEFuncBElement.h:
2395         * ksvg2/svg/SVGFEFuncGElement.cpp:
2396         * ksvg2/svg/SVGFEFuncGElement.h:
2397         * ksvg2/svg/SVGFEFuncRElement.cpp:
2398         * ksvg2/svg/SVGFEFuncRElement.h:
2399         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2400         * ksvg2/svg/SVGFEGaussianBlurElement.h:
2401         * ksvg2/svg/SVGFEImageElement.cpp:
2402         * ksvg2/svg/SVGFEImageElement.h:
2403         * ksvg2/svg/SVGFELightElement.cpp:
2404         * ksvg2/svg/SVGFELightElement.h:
2405         * ksvg2/svg/SVGFEMergeElement.cpp:
2406         * ksvg2/svg/SVGFEMergeElement.h:
2407         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
2408         * ksvg2/svg/SVGFEMergeNodeElement.h:
2409         * ksvg2/svg/SVGFEOffsetElement.cpp:
2410         * ksvg2/svg/SVGFEOffsetElement.h:
2411         * ksvg2/svg/SVGFEPointLightElement.cpp:
2412         * ksvg2/svg/SVGFEPointLightElement.h:
2413         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2414         * ksvg2/svg/SVGFESpecularLightingElement.h:
2415         * ksvg2/svg/SVGFESpotLightElement.cpp:
2416         * ksvg2/svg/SVGFESpotLightElement.h:
2417         * ksvg2/svg/SVGFETileElement.cpp:
2418         * ksvg2/svg/SVGFETileElement.h:
2419         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2420         * ksvg2/svg/SVGFETurbulenceElement.h:
2421         * ksvg2/svg/SVGFilterElement.cpp:
2422         * ksvg2/svg/SVGFilterElement.h:
2423         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
2424         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
2425         * ksvg2/svg/SVGFitToViewBox.cpp:
2426         * ksvg2/svg/SVGFitToViewBox.h:
2427         * ksvg2/svg/SVGForeignObjectElement.cpp:
2428         * ksvg2/svg/SVGForeignObjectElement.h:
2429         * ksvg2/svg/SVGGElement.cpp:
2430         * ksvg2/svg/SVGGElement.h:
2431         * ksvg2/svg/SVGGradientElement.cpp:
2432         * ksvg2/svg/SVGGradientElement.h:
2433         * ksvg2/svg/SVGHelper.cpp:
2434         * ksvg2/svg/SVGHelper.h:
2435         * ksvg2/svg/SVGImageElement.cpp:
2436         * ksvg2/svg/SVGImageElement.h:
2437         * ksvg2/svg/SVGLangSpace.cpp:
2438         * ksvg2/svg/SVGLangSpace.h:
2439         * ksvg2/svg/SVGLength.cpp:
2440         * ksvg2/svg/SVGLength.h:
2441         * ksvg2/svg/SVGLengthList.cpp:
2442         * ksvg2/svg/SVGLengthList.h:
2443         * ksvg2/svg/SVGLineElement.cpp:
2444         * ksvg2/svg/SVGLineElement.h:
2445         * ksvg2/svg/SVGLinearGradientElement.cpp:
2446         * ksvg2/svg/SVGLinearGradientElement.h:
2447         * ksvg2/svg/SVGList.h:
2448         * ksvg2/svg/SVGLocatable.cpp:
2449         * ksvg2/svg/SVGLocatable.h:
2450         * ksvg2/svg/SVGMarkerElement.cpp:
2451         * ksvg2/svg/SVGMarkerElement.h:
2452         * ksvg2/svg/SVGMaskElement.cpp:
2453         * ksvg2/svg/SVGMaskElement.h:
2454         * ksvg2/svg/SVGMatrix.cpp:
2455         * ksvg2/svg/SVGMatrix.h:
2456         * ksvg2/svg/SVGNumber.cpp:
2457         * ksvg2/svg/SVGNumber.h:
2458         * ksvg2/svg/SVGNumberList.cpp:
2459         * ksvg2/svg/SVGNumberList.h:
2460         * ksvg2/svg/SVGPaint.cpp:
2461         * ksvg2/svg/SVGPaint.h:
2462         * ksvg2/svg/SVGPathElement.cpp:
2463         * ksvg2/svg/SVGPathElement.h:
2464         * ksvg2/svg/SVGPathSeg.cpp:
2465         * ksvg2/svg/SVGPathSeg.h:
2466         * ksvg2/svg/SVGPathSegArc.cpp:
2467         * ksvg2/svg/SVGPathSegArc.h:
2468         * ksvg2/svg/SVGPathSegClosePath.cpp:
2469         * ksvg2/svg/SVGPathSegClosePath.h:
2470         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
2471         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
2472         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
2473         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
2474         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
2475         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
2476         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
2477         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
2478         * ksvg2/svg/SVGPathSegLineto.cpp:
2479         * ksvg2/svg/SVGPathSegLineto.h:
2480         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
2481         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
2482         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
2483         * ksvg2/svg/SVGPathSegLinetoVertical.h:
2484         * ksvg2/svg/SVGPathSegList.cpp:
2485         * ksvg2/svg/SVGPathSegList.h:
2486         * ksvg2/svg/SVGPathSegMoveto.cpp:
2487         * ksvg2/svg/SVGPathSegMoveto.h:
2488         * ksvg2/svg/SVGPatternElement.cpp:
2489         * ksvg2/svg/SVGPatternElement.h:
2490         * ksvg2/svg/SVGPoint.cpp:
2491         * ksvg2/svg/SVGPoint.h:
2492         * ksvg2/svg/SVGPointList.cpp:
2493         * ksvg2/svg/SVGPointList.h:
2494         * ksvg2/svg/SVGPolyElement.cpp:
2495         * ksvg2/svg/SVGPolyElement.h:
2496         * ksvg2/svg/SVGPolygonElement.cpp:
2497         * ksvg2/svg/SVGPolygonElement.h:
2498         * ksvg2/svg/SVGPolylineElement.cpp:
2499         * ksvg2/svg/SVGPolylineElement.h:
2500         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
2501         * ksvg2/svg/SVGPreserveAspectRatio.h:
2502         * ksvg2/svg/SVGRadialGradientElement.cpp:
2503         * ksvg2/svg/SVGRadialGradientElement.h:
2504         * ksvg2/svg/SVGRect.cpp:
2505         * ksvg2/svg/SVGRect.h:
2506         * ksvg2/svg/SVGRectElement.cpp:
2507         * ksvg2/svg/SVGRectElement.h:
2508         * ksvg2/svg/SVGSVGElement.cpp:
2509         * ksvg2/svg/SVGSVGElement.h:
2510         * ksvg2/svg/SVGScriptElement.cpp:
2511         * ksvg2/svg/SVGScriptElement.h:
2512         * ksvg2/svg/SVGSetElement.cpp:
2513         * ksvg2/svg/SVGSetElement.h:
2514         * ksvg2/svg/SVGStopElement.cpp:
2515         * ksvg2/svg/SVGStopElement.h:
2516         * ksvg2/svg/SVGStringList.cpp:
2517         * ksvg2/svg/SVGStringList.h:
2518         * ksvg2/svg/SVGStylable.cpp:
2519         * ksvg2/svg/SVGStylable.h:
2520         * ksvg2/svg/SVGStyleElement.cpp:
2521         * ksvg2/svg/SVGStyleElement.h:
2522         * ksvg2/svg/SVGStyledElement.cpp:
2523         * ksvg2/svg/SVGStyledElement.h:
2524         * ksvg2/svg/SVGStyledLocatableElement.cpp:
2525         * ksvg2/svg/SVGStyledLocatableElement.h:
2526         * ksvg2/svg/SVGStyledTransformableElement.cpp:
2527         * ksvg2/svg/SVGStyledTransformableElement.h:
2528         * ksvg2/svg/SVGSwitchElement.cpp:
2529         * ksvg2/svg/SVGSwitchElement.h:
2530         * ksvg2/svg/SVGSymbolElement.cpp:
2531         * ksvg2/svg/SVGSymbolElement.h:
2532         * ksvg2/svg/SVGTRefElement.cpp:
2533         * ksvg2/svg/SVGTRefElement.h:
2534         * ksvg2/svg/SVGTSpanElement.cpp:
2535         * ksvg2/svg/SVGTSpanElement.h:
2536         * ksvg2/svg/SVGTests.cpp:
2537         * ksvg2/svg/SVGTests.h:
2538         * ksvg2/svg/SVGTextContentElement.cpp:
2539         * ksvg2/svg/SVGTextContentElement.h:
2540         * ksvg2/svg/SVGTextElement.cpp:
2541         * ksvg2/svg/SVGTextElement.h:
2542         * ksvg2/svg/SVGTextPositioningElement.cpp:
2543         * ksvg2/svg/SVGTextPositioningElement.h:
2544         * ksvg2/svg/SVGTitleElement.cpp:
2545         * ksvg2/svg/SVGTitleElement.h:
2546         * ksvg2/svg/SVGTransform.cpp:
2547         * ksvg2/svg/SVGTransform.h:
2548         * ksvg2/svg/SVGTransformList.cpp:
2549         * ksvg2/svg/SVGTransformList.h:
2550         * ksvg2/svg/SVGTransformable.cpp:
2551         * ksvg2/svg/SVGTransformable.h:
2552         * ksvg2/svg/SVGURIReference.cpp:
2553         * ksvg2/svg/SVGURIReference.h:
2554         * ksvg2/svg/SVGUseElement.cpp:
2555         * ksvg2/svg/SVGUseElement.h:
2556         * ksvg2/svg/SVGViewElement.cpp:
2557         * ksvg2/svg/SVGViewElement.h:
2558         * ksvg2/svg/SVGZoomAndPan.cpp:
2559         * ksvg2/svg/SVGZoomAndPan.h:
2560         * ksvg2/svg/svgpathparser.cpp:
2561         * ksvg2/svg/svgpathparser.h:
2562         * page/DOMWindow.idl:
2563         * page/Frame.cpp:
2564         (WebCore::Frame::Frame):
2565         (WebCore::Frame::begin):
2566         (WebCore::Frame::pauseTimeouts):
2567         (WebCore::Frame::resumeTimeouts):
2568         * platform/GraphicsContext.h:
2569         * platform/cg/GraphicsContextCG.cpp:
2570         * rendering/RenderLayer.cpp:
2571         (WebCore::RenderLayer::isTransparent):
2572         * rendering/RenderObject.cpp:
2573         (WebCore::RenderObject::containingBlock):
2574         * rendering/RenderObject.h:
2575         * rendering/RenderStyle.cpp:
2576         (WebCore::RenderStyle::RenderStyle):
2577         (WebCore::RenderStyle::inheritFrom):
2578         (WebCore::RenderStyle::operator==):
2579         (WebCore::RenderStyle::inheritedNotEqual):
2580         (WebCore::RenderStyle::diff):
2581         * rendering/RenderStyle.h:
2582         * rendering/RenderTreeAsText.cpp:
2583         (WebCore::write):
2584         (WebCore::externalRepresentation):
2585         * xpath/XPathEvaluator.cpp:
2586         * xpath/XPathEvaluator.h:
2587         * xpath/XPathExpression.cpp:
2588         * xpath/XPathExpression.h:
2589         * xpath/XPathNSResolver.cpp:
2590         * xpath/XPathNSResolver.h:
2591         * xpath/XPathNamespace.cpp:
2592         * xpath/XPathNamespace.h:
2593         * xpath/XPathResult.cpp:
2594         * xpath/XPathResult.h:
2595         * xpath/impl/XPathExpressionNode.cpp:
2596         * xpath/impl/XPathExpressionNode.h:
2597         * xpath/impl/XPathFunctions.cpp:
2598         * xpath/impl/XPathFunctions.h:
2599         * xpath/impl/XPathGrammar.y:
2600         * xpath/impl/XPathParser.cpp:
2601         * xpath/impl/XPathParser.h:
2602         * xpath/impl/XPathPath.cpp:
2603         * xpath/impl/XPathPath.h:
2604         * xpath/impl/XPathPredicate.cpp:
2605         * xpath/impl/XPathPredicate.h:
2606         * xpath/impl/XPathStep.cpp:
2607         * xpath/impl/XPathStep.h:
2608         * xpath/impl/XPathUtil.cpp:
2609         * xpath/impl/XPathUtil.h:
2610         * xpath/impl/XPathValue.cpp:
2611         * xpath/impl/XPathValue.h:
2612         * xpath/impl/XPathVariableReference.cpp:
2613         * xpath/impl/XPathVariableReference.h:
2614
2615         Change all #if SVG_SUPPORT to #ifdef SVG_SUPPORT and
2616         #if XPATH_SUPPORT to #ifdef XPATH_SUPPORT
2617         (except for one #if !SVG_SUPPORT to a #ifndef SVG_SUPPORT
2618         in RenderTreeAsText.cpp)
2619
2620 2006-08-08  Rob Buis  <buis@kde.org>
2621
2622         Reviewed by Darin.
2623
2624         http://bugzilla.opendarwin.org/show_bug.cgi?id=10230
2625         SVGDOMImplementation should die (and be rolled into DOMImplementation)
2626
2627         Delete SVGDOMImplementation and references to it. The
2628         svg specific functionality is now in DOMImplementation.
2629
2630         * WebCore.xcodeproj/project.pbxproj:
2631         * dom/DOMImplementation.cpp:
2632         (WebCore::svgFeatureSet):
2633         (WebCore::DOMImplementation::hasFeature):
2634         (WebCore::DOMImplementation::createDocument):
2635         (WebCore::DOMImplementation::createSVGDocument):
2636         * dom/DOMImplementation.h:
2637         * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Removed.
2638         * ksvg2/misc/KSVGTimeScheduler.cpp:
2639         * ksvg2/svg/SVGColor.cpp:
2640         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2641         * ksvg2/svg/SVGDocument.cpp:
2642         (WebCore::SVGDocument::SVGDocument):
2643         * ksvg2/svg/SVGDocument.h:
2644         * ksvg2/svg/SVGElement.cpp:
2645         (WebCore::SVGElement::isSupported):
2646         * ksvg2/svg/SVGFEBlendElement.cpp:
2647         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2648         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2649         * ksvg2/svg/SVGFECompositeElement.cpp:
2650         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2651         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2652         * ksvg2/svg/SVGFEFloodElement.cpp:
2653         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2654         * ksvg2/svg/SVGFELightElement.cpp:
2655         * ksvg2/svg/SVGFEMergeElement.cpp:
2656         * ksvg2/svg/SVGFEOffsetElement.cpp:
2657         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2658         * ksvg2/svg/SVGFETileElement.cpp:
2659         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2660         * ksvg2/svg/SVGGradientElement.cpp:
2661         * ksvg2/svg/SVGPatternElement.cpp:
2662         * ksvg2/svg/SVGPolyElement.cpp:
2663         * ksvg2/svg/SVGStopElement.cpp:
2664         * ksvg2/svg/SVGStyledElement.cpp:
2665         * ksvg2/svg/SVGStyledTransformableElement.cpp:
2666         * ksvg2/svg/SVGTests.cpp:
2667         (WebCore::SVGTests::isValid):
2668         * ksvg2/svg/SVGTransformable.cpp:
2669         * page/Frame.cpp:
2670         (WebCore::Frame::begin):
2671
2672 2006-08-07  Brady Eidson  <beidson@apple.com>
2673
2674         Reviewed by Anders and John
2675
2676         Icons can now refresh when new data is sent from WebKit, both on disk and in memory
2677
2678         * bridge/mac/WebCoreIconDatabaseBridge.h:
2679         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2680         (WebCore::IconDatabase::loadIconFromURL):  Allows WebCore/Kit to kick off a load
2681         outside of any greater context
2682         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2683         (-[WebCoreIconDatabaseBridge isIconExpiredForPageURL:]): Allows WebKit
2684         to get whether or not an icon has expired
2685
2686         * loader/icon/IconDatabase.cpp:
2687         (WebCore::IconDatabase::recreateDatabase): Changed database schema slightly
2688         (WebCore::IconDatabase::createPrivateTables): Changed database schema slightly
2689         (WebCore::IconDatabase::iconForPageURL): 
2690         (WebCore::IconDatabase::isIconExpiredForIconURL): Get if an icon has expired
2691         (WebCore::IconDatabase::isIconExpiredForPageURL): Get if an icon has expired
2692         (WebCore::IconDatabase::setIconDataForIconURL): Force a refresh of the in memory
2693         image when new icon data is loaded
2694         (WebCore::IconDatabase::setIconURLForPageURL): added a check for null iconID
2695
2696         * loader/icon/IconDatabase.h: added/changed some methods
2697         * loader/icon/SiteIcon.cpp:
2698         (SiteIcon::getImage): simplified/removed debugging code
2699         (SiteIcon::manuallySetImageData): allow the image data to be changed when new icon
2700         data is loaded
2701
2702 2006-08-05  Darin Adler  <darin@apple.com>
2703
2704         Reviewed by Eric Seidel.
2705
2706         - fix a storage leak
2707
2708         * rendering/RenderView.cpp: (WebCore::RenderView::setSelection):
2709         Delete the values if we are going to exit without using the maps.
2710         Otherwise all the values leak.
2711
2712 2006-08-05  Darin Adler  <darin@apple.com>
2713
2714         Reviewed by Hyatt.
2715
2716         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10213
2717           REGRESSION: Crash in WebCore::RenderLayer::isTransparent involving <iframe> and <select>
2718
2719         Test: fast/frames/iframe-option-crash.xhtml
2720
2721         * rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
2722         Check for a nil renderer.
2723
2724 2006-08-04  David Hyatt  <hyatt@apple.com>
2725
2726         Fix for Radar bug #4644045, regression where dragging selection no longer
2727         works for floats contained inside layers.  I added an optimization to
2728         refine dirty rect checking for layers, and it incorrectly excluded floats
2729         from the paint bounds since PaintPhaseSelection was not considered when
2730         analyzing the floatRect().
2731
2732         Reviewed by beth
2733
2734         * rendering/RenderBlock.cpp:
2735         (WebCore::RenderBlock::paint):
2736
2737 2006-08-04  David Hyatt  <hyatt@apple.com>
2738
2739         Fix remove() so that it is equivalent to calling removeChild on the
2740         parent.  This involved moving three operations that remove did.
2741
2742         (1) Move the accessibility object cache removal into the destroy methods,
2743         since this really should just happen when a render object is going away.
2744
2745         (2) removeFromObjectLists shifted into removeChild, which means it will
2746         now be called more often (this is a correct change).  Note that there is
2747         also now a new guard on removeFromObjectLists so that it won't do any
2748         work unless the document is not being destroyed.
2749
2750         (3) The big one.  deleteLineBoxWrapper was not getting called to clean up
2751         the line box tree.  This moved right into RenderContainer's removeChildNode so
2752         that it is now done even in the lowest level RenderContainer removal primitive.
2753
2754         Reviewed by beth
2755
2756         * rendering/RenderContainer.cpp:
2757         (WebCore::RenderContainer::removeChildNode):
2758         (WebCore::RenderContainer::removeChild):
2759         * rendering/RenderObject.cpp:
2760         (WebCore::RenderObject::removeFromObjectLists):
2761         (WebCore::RenderObject::destroy):
2762         * rendering/RenderObject.h:
2763         (WebCore::RenderObject::remove):
2764         * rendering/RenderWidget.cpp:
2765         (WebCore::RenderWidget::destroy):
2766
2767 2006-08-04  David Hyatt  <hyatt@apple.com>
2768
2769         Back out the fix for list marker crashes.  The actual bug here is that
2770         there is a confusing mismatch between remove() and removeChild() in the
2771         render tree.  remove() does a little bit of extra work that removeChild
2772         should be doing instead (so that remove() can just be a shorthand for
2773         removeChild).
2774
2775         This conservative fix does not solve the remove/removeChild mismatch
2776         but instead just changes the list marker updating code to use remove
2777         instead.
2778
2779         Reviewed by beth
2780
2781         Test Case: fast/lists/dynamic-marker-crash.html
2782
2783         * rendering/ListMarkerBox.cpp:
2784         * rendering/ListMarkerBox.h:
2785         * rendering/RenderListItem.cpp:
2786         (WebCore::RenderListItem::updateMarkerLocation):
2787
2788 2006-08-04  Sam Weinig  <sam.weinig@gmail.com>
2789
2790         Reviewed by Darin.
2791
2792         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
2793           Make WebCore (and friends) compile with -Wshorten-64-to-32
2794
2795           * Adds -Wshorten-64-to-32 flag to Xcode project.
2796           * Adds 'f' to float literals where expecting a float.
2797           * Use cosf() instead of cos() when assigning to a float.
2798
2799         * WebCore.xcodeproj/project.pbxproj:
2800         * kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m:
2801         (+[WKDiffuseLightingFilter initialize]):
2802         * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m:
2803         (-[WKDiscreteTransferFilter outputImage]):
2804         * kcanvas/device/quartz/filters/WKDisplacementMapFilter.m:
2805         (+[WKDisplacementMapFilter initialize]):
2806         * kcanvas/device/quartz/filters/WKSpecularLightingFilter.m:
2807         (+[WKSpecularLightingFilter initialize]):
2808         * kcanvas/device/quartz/filters/WKSpotLightFilter.m:
2809         (-[WKSpotLightFilter outputImage]):
2810         * kcanvas/device/quartz/filters/WKTableTransferFilter.m:
2811         (-[WKTableTransferFilter outputImage]):
2812
2813 2006-08-03  David Hyatt  <hyatt@apple.com>
2814
2815         Fix for bug 10229, don't bother trying to clear when no floats are
2816         present.  I suspect there's still a bug in the math that follows, but
2817         this fix is safer in that it just does the obvious thing (and doesn't
2818         compute any clearance if no floats are even around).
2819
2820         Reviewed by maciej
2821
2822         * ChangeLog:
2823         * rendering/RenderBlock.cpp:
2824         (WebCore::RenderBlock::getClearDelta):
2825
2826 2006-08-03  Justin Garcia  <justin.garcia@apple.com>
2827
2828         Reviewed by harrison
2829         
2830         <rdar://problem/4641033/4515463/4052426/4046570/4053718/4053724/4060115/4062858>
2831         Copy/Paste fidelity was bad.
2832
2833         * editing/ApplyStyleCommand.cpp:
2834         (WebCore::ApplyStyleCommand::applyInlineStyle):
2835         * editing/markup.cpp:
2836         (WebCore::startMarkup): We were not adding non-inheritable styles
2837         to the markup for an element unless they were in the elements inline
2838         style declaration.
2839
2840 2006-08-03  Sam Weinig  <sam.weinig@gmail.com>
2841
2842         Reviewed by Darin.
2843
2844         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
2845           Make WebCore compile with -Wundef
2846
2847           * Adds -Wundef flag to Xcode project
2848           * Converts #ifs to #ifdef and #ifndefs where needed.
2849           * Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN)
2850             (and in one instance in config.h with #if !COMPILER(MSVC))
2851           * Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y
2852             to fix a warning from within Bison.
2853           * Cleaned up style a little in surrounding code.
2854
2855         * WebCore.xcodeproj/project.pbxproj:
2856         * bridge/mac/WebCoreAXObject.mm:
2857         (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
2858         * config.h:
2859         * css/CSSGrammar.y:
2860         * css/MediaFeatureNames.cpp:
2861         * css/MediaFeatureNames.h:
2862         * css/cssparser.cpp:
2863         * dom/ContainerNode.cpp:
2864         (WebCore::ContainerNode::setActive):
2865         * dom/Element.cpp:
2866         (WebCore::Element::attach):
2867         * dom/Element.h:
2868         * dom/EventNames.cpp:
2869         * dom/EventNames.h:
2870         * dom/NamedAttrMap.h:
2871         * dom/Position.cpp:
2872         * dom/QualifiedName.cpp:
2873         * dom/QualifiedName.h:
2874         * dom/Range.h:
2875         * dom/XMLTokenizer.cpp:
2876         (WebCore::XMLTokenizer::error):
2877         * html/HTMLTokenizer.cpp:
2878         (WebCore::HTMLTokenizer::scriptHandler):
2879         (WebCore::HTMLTokenizer::scriptExecution):
2880         (WebCore::HTMLTokenizer::parseTag):
2881         (WebCore::HTMLTokenizer::continueProcessing):
2882         (WebCore::HTMLTokenizer::write):
2883         (WebCore::HTMLTokenizer::timerFired):
2884         (WebCore::HTMLTokenizer::notifyFinished):
2885         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2886         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2887         * ksvg2/css/SVGRenderStyle.h:
2888         * ksvg2/css/SVGRenderStyleDefs.h:
2889         * ksvg2/scripts/make_names.pl:
2890         * loader/CachedResource.h:
2891         * loader/LoaderFunctions.h:
2892         * loader/loader.h:
2893         * page/Frame.cpp:
2894         * page/FrameTree.cpp:
2895         * page/FrameView.cpp:
2896         (WebCore::FrameView::clear):
2897         (WebCore::FrameView::layout):
2898         (WebCore::FrameView::layoutTimerFired):
2899         (WebCore::FrameView::scheduleRelayout):
2900         (WebCore::FrameView::unscheduleRelayout):
2901         * platform/AtomicString.cpp:
2902         * platform/AtomicString.h:
2903         * platform/Cursor.h:
2904         * platform/DeprecatedArray.h:
2905         * platform/DeprecatedString.cpp:
2906         (WebCore::allocateHandle):
2907         (WebCore::initializeHandleNodeBlock):
2908         (WebCore::freeHandle):
2909         * platform/FloatPoint.h:
2910         * platform/FloatRect.h:
2911         * platform/FloatSize.h:
2912         * platform/GraphicsContext.h:
2913         * platform/Image.h:
2914         * platform/IntPoint.h:
2915         * platform/IntRect.h:
2916         (WebCore::IntRect::inflateX):
2917         (WebCore::IntRect::inflateY):
2918         * platform/IntSize.h:
2919         * platform/PlatformKeyboardEvent.h:
2920         * platform/PlatformMouseEvent.h:
2921         * platform/PlatformString.h:
2922         * platform/ResourceLoader.h:
2923         * platform/ResourceLoaderInternal.h:
2924         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2925         * platform/ScrollView.h:
2926         * platform/StaticConstructors.h:
2927         * platform/StreamingTextDecoderICU.cpp:
2928         (WebCore::StreamingTextDecoderICU::convert):
2929         * platform/StringImpl.h:
2930         * platform/Widget.h:
2931         * platform/mac/BlockExceptions.mm:
2932         * platform/mac/ColorMac.mm:
2933         (+[WebCoreControlTintObserver WebCore]):
2934         * platform/mac/FloatPointMac.mm:
2935         * platform/mac/FloatRectMac.mm:
2936         * platform/mac/FloatSizeMac.mm:
2937         * platform/mac/FontMac.mm:
2938         * platform/mac/GraphicsContextMac.mm:
2939         (WebCore::GraphicsContext::drawFocusRing):
2940         * platform/mac/IntPointMac.mm:
2941         * platform/mac/IntRectMac.mm:
2942         * platform/mac/IntSizeMac.mm:
2943         * platform/mac/WebCoreSystemInterface.h:
2944         * rendering/RenderBlock.h:
2945         * rendering/RenderTableCell.h:
2946         * rendering/bidi.cpp:
2947         (WebCore::appendRun):
2948         (WebCore::RenderBlock::layoutInlineChildren):
2949         * xml/XSLTProcessor.cpp:
2950         (WebCore::parseErrorFunc):
2951         * xpath/impl/XPathGrammar.y:
2952
2953 2006-08-03  Adam Roben  <aroben@apple.com>
2954
2955         Reviewed by Maciej and Beth.
2956
2957         Fix use-after-dispose heap corruption bug.
2958
2959         * rendering/ListMarkerBox.cpp:
2960         (WebCore::ListMarkerBox::destroy): Only call removeChild if we're not
2961         destroying the document
2962
2963 2006-08-03  Adam Roben  <aroben@apple.com>
2964
2965         Reviewed by Anders.
2966
2967         - Fixed Windows build.
2968
2969         * platform/Color.cpp:
2970         (WebCore::makeRGBAFromHSLA): Whitespace change
2971         * platform/win/TemporaryLinkStubs.cpp: Add new method stubs
2972         (PlatformScrollBar::PlatformScrollBar):
2973         (PlatformScrollBar::~PlatformScrollBar):
2974         (PlatformScrollBar::width):
2975         (PlatformScrollBar::height):
2976         (PlatformScrollBar::setEnabled):
2977         (PlatformScrollBar::paint):
2978         (PlatformScrollBar::setScrollBarValue):
2979         (PlatformScrollBar::setKnobProportion):
2980         (PlatformScrollBar::setRect):
2981         (ScrollBar::ScrollBar):
2982         (ScrollBar::scroll):
2983         (ScrollBar::setValue):
2984
2985 2006-08-02  Justin Garcia  <justin.garcia@apple.com>
2986
2987         Reviewed by mjs
2988         
2989         <http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
2990         GMail Editor: Change Hilite Color doesn't work
2991
2992         * editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...).
2993         It's what GMail uses to implement text hiliting.  It's just a synonym for BackColor.
2994         * editing/SelectionController.cpp:
2995         (WebCore::SelectionController::nodeWillBeRemoved): Moved a comment
2996         a more appropriate place.
2997
2998 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2999
3000         Reviewed by Adele and Darin.
3001
3002         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10177
3003           REGRESSION: Successfully dragging text into a disabled field
3004
3005         Test: fast/forms/textfield-drag-into-disabled.html
3006
3007         * rendering/RenderTextControl.cpp:
3008         (WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify
3009         to read-only on the inner div if the control is disabled.       
3010         (WebCore::RenderTextControl::updateFromElement): Ditto.
3011
3012 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3013
3014         Reviewed by Darin.
3015
3016         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10198
3017           REGRESSION: WebKit r15750 crashes while loading anthem.com
3018
3019         Test: fast/overflow/generated-content-crash.html
3020
3021         * rendering/RenderLayer.cpp:
3022         (WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for
3023         the renderer's element. Generated content does not have an element and
3024         therefore does not need to maintain overflow status.
3025
3026 2006-08-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3027
3028         Reviewed by Anders.
3029
3030         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202
3031           REGRESSION: Repro crash when loading an empty image document
3032
3033         Test: fast/tokenizer/image-empty-crash.html
3034
3035         * loader/ImageDocument.cpp:
3036         (WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement.
3037         (WebCore::ImageTokenizer::finish): Ditto.
3038
3039 2006-08-03  Darin Adler  <darin@apple.com>
3040
3041         Reviewed by Anders.
3042
3043         - clean up "flip"-related code a tiny bit
3044
3045         * platform/Screen.h: Removed redundant parameter names.
3046         * platform/mac/ScreenMac.mm:
3047         (WebCore::flipScreenRect): Changed to call flipScreenPoint so we only have one
3048         copy of the flipping code.
3049         (WebCore::flipScreenPoint): Fixed indentation.
3050
3051         * bridge/mac/WebCoreFrameBridge.mm: (globalPoint): Removed type casts and
3052         simplified a bit.
3053
3054         * platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPositionForEvent):
3055         * platform/mac/WheelEventMac.mm: (WebCore::globalPositionForEvent):
3056         Removed unneeded local variable.
3057
3058 2006-08-02  David Hyatt  <hyatt@apple.com>
3059
3060         Abstract RenderLayer scrollbar creation and destruction so that there
3061         is a clean spot in which to drop in engine scrollbar stuff.
3062
3063         Reviewed by timo
3064
3065         * platform/ScrollBar.h:
3066         (WebCore::ScrollBar::hasPlatformScrollBars):
3067         * rendering/RenderLayer.cpp:
3068         (WebCore::RenderLayer::createScrollbar):
3069         (WebCore::RenderLayer::destroyScrollbar):
3070         (WebCore::RenderLayer::setHasHorizontalScrollbar):
3071         (WebCore::RenderLayer::setHasVerticalScrollbar):
3072         * rendering/RenderLayer.h:
3073
3074 2006-08-02  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3075
3076         Reviewed by Darin.
3077
3078         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3438
3079           incorrect display of transparent 1x1 PNGs
3080
3081         Test: fast/replaced/image-solid-color-with-alpha.html
3082
3083         * platform/mac/ImageMac.mm:
3084         (WebCore::Image::checkForSolidColor): Changed to divide each color component
3085         by the alpha component. You need to do that since the bitmap context has
3086         premultiplied alpha but m_solidColor should be non-premultiplied.
3087
3088 2006-08-02  Adam Roben  <aroben@apple.com>
3089
3090         Reviewed by Brady.
3091
3092         - Remove redundant #include
3093
3094         * loader/loader.cpp:
3095
3096 2006-07-31  Sam Weinig  <sam.weinig@gmail.com>
3097
3098         Reviewed by Darin.
3099
3100         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=9955
3101         Colors scaled from [0, 1] range to [0, 255] incorrectly
3102         
3103         Fixes scaling issue and fixes Color to follow style guidelines.
3104
3105         * css/cssstyleselector.cpp:
3106         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
3107         * platform/Color.cpp:
3108         (WebCore::calcHue):
3109         (WebCore::makeRGBAFromHSLA):
3110         (WebCore::Color::Color):
3111         (WebCore::Color::name):
3112         (WebCore::Color::setNamedColor):
3113         (WebCore::Color::light):
3114         (WebCore::Color::dark):
3115         (WebCore::blend):
3116         * platform/Color.h:
3117         (WebCore::Color::Color):
3118         (WebCore::Color::isValid):
3119         (WebCore::Color::red):
3120         (WebCore::Color::green):
3121         (WebCore::Color::blue):
3122         (WebCore::Color::alpha):
3123         (WebCore::Color::rgb):
3124         (WebCore::Color::setRGB):
3125         (WebCore::operator==):
3126         (WebCore::operator!=):
3127         * rendering/RenderObject.cpp:
3128         (WebCore::RenderObject::drawBorder):
3129
3130 2006-07-31  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3131
3132         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10158
3133           REGRESSION: Selection highlight is dark and opaque when solid-color images are used
3134
3135         Reviewed by Darin.
3136
3137         Pixel test: fast/backgrounds/solid-color-context-restore.html
3138
3139         * platform/mac/ImageMac.mm:
3140         (WebCore::Image::draw): Added calls to preserve the graphics context
3141         around the painting of a solid color image.
3142         (WebCore::Image::drawTiled): Ditto.
3143
3144 2006-07-31  Maciej Stachowiak  <mjs@apple.com>
3145
3146         Rubber-stamped by Tim Hatcher.
3147
3148         - renamed TransferJob to ResourceLoader
3149
3150         * Projects/gdk/webcore-gdk.bkl:
3151         * WebCore.vcproj/WebCore/WebCore.vcproj:
3152         * WebCore.xcodeproj/project.pbxproj:
3153         * WebCoreSources.bkl:
3154         * bridge/mac/FrameMac.mm:
3155         * bridge/mac/WebCoreResourceLoaderImp.h:
3156         * bridge/mac/WebCoreResourceLoaderImp.mm:
3157         (-[WebCoreResourceLoaderImp redirectedToURL:]):
3158         (-[WebCoreResourceLoaderImp addData:]):
3159         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
3160         * bridge/win/FrameWin.cpp:
3161         * dom/XMLTokenizer.cpp:
3162         (WebCore::openFunc):
3163         * loader/Cache.cpp:
3164         * loader/LoaderFunctions.h:
3165         * loader/loader.cpp:
3166         (WebCore::Loader::servePendingRequests):
3167         (WebCore::Loader::receivedAllData):
3168         (WebCore::Loader::receivedResponse):
3169         (WebCore::Loader::receivedData):
3170         (WebCore::Loader::cancelRequests):
3171         (WebCore::Loader::jobForRequest):
3172         * loader/loader.h:
3173         * loader/mac/LoaderFunctionsMac.mm:
3174         (WebCore::ServeSynchronousRequest):
3175         * platform/ResourceLoader.cpp: Added.
3176         (WebCore::ResourceLoader::ResourceLoader):
3177         (WebCore::ResourceLoader::isErrorPage):
3178         (WebCore::ResourceLoader::error):
3179         (WebCore::ResourceLoader::setError):
3180         (WebCore::ResourceLoader::queryMetaData):
3181         (WebCore::ResourceLoader::addMetaData):
3182         (WebCore::ResourceLoader::kill):
3183         (WebCore::ResourceLoader::url):
3184         (WebCore::ResourceLoader::postData):
3185         (WebCore::ResourceLoader::method):
3186         (WebCore::ResourceLoader::client):
3187         * platform/ResourceLoader.h: Added.
3188         (WebCore::ResourceLoader::getInternal):
3189         * platform/ResourceLoaderClient.h: Added.
3190         (WebCore::ResourceLoaderClient::~ResourceLoaderClient):
3191         (WebCore::ResourceLoaderClient::receivedRedirect):
3192         (WebCore::ResourceLoaderClient::receivedResponse):
3193         (WebCore::ResourceLoaderClient::receivedData):
3194         (WebCore::ResourceLoaderClient::receivedAllData):
3195         * platform/ResourceLoaderInternal.h: Added.
3196         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3197         * platform/TransferJob.cpp: Removed.
3198         * platform/TransferJob.h: Removed.
3199         * platform/TransferJobClient.h: Removed.
3200         * platform/TransferJobInternal.h: Removed.
3201         * platform/gdk/FrameGdk.cpp:
3202         (WebCore::FrameGdk::openURL):
3203         (WebCore::FrameGdk::urlSelected):
3204         (WebCore::FrameGdk::receivedData):
3205         (WebCore::FrameGdk::receivedAllData):
3206         * platform/gdk/FrameGdk.h:
3207         * platform/gdk/ResourceLoaderCurl.cpp: Added.
3208         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3209         (WebCore::ResourceLoader::~ResourceLoader):
3210         (WebCore::ResourceLoader::start):
3211         (WebCore::ResourceLoader::cancel):
3212         * platform/gdk/ResourceLoaderManager.cpp: Added.
3213         (WebCore::ResourceLoaderManager::ResourceLoaderManager):
3214         (WebCore::ResourceLoaderManager::get):
3215         (WebCore::ResourceLoaderManager::useSimpleTransfer):
3216         (WebCore::writeCallback):
3217         (WebCore::ResourceLoaderManager::downloadTimerCallback):
3218         (WebCore::ResourceLoaderManager::remove):
3219         (WebCore::ResourceLoaderManager::add):
3220         (WebCore::ResourceLoaderManager::cancel):
3221         * platform/gdk/ResourceLoaderManager.h: Added.
3222         * platform/gdk/TemporaryLinkStubs.cpp:
3223         (WebCore::ServeSynchronousRequest):
3224         (WebCore::ResourceLoader::assembleResponseHeaders):
3225         (WebCore::ResourceLoader::retrieveCharset):
3226         * platform/gdk/TransferJobCurl.cpp: Removed.
3227         * platform/gdk/TransferJobManager.cpp: Removed.
3228         * platform/gdk/TransferJobManager.h: Removed.
3229         * platform/mac/ResourceLoaderMac.mm: Added.
3230         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3231         (WebCore::ResourceLoader::~ResourceLoader):
3232         (WebCore::ResourceLoader::start):
3233         (WebCore::ResourceLoader::assembleResponseHeaders):
3234         (WebCore::ResourceLoader::retrieveCharset):
3235         (WebCore::ResourceLoader::setLoader):
3236         (WebCore::ResourceLoader::receivedResponse):
3237         (WebCore::ResourceLoader::cancel):
3238         * platform/mac/TransferJobMac.mm: Removed.
3239         * platform/win/ResourceLoaderWin.cpp: Added.
3240         (WebCore::addToOutstandingJobs):
3241         (WebCore::lookupResourceLoader):
3242         (WebCore::ResourceLoaderWndProc):
3243         (WebCore::initializeOffScreenResourceLoaderWindow):
3244         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3245         (WebCore::ResourceLoader::~ResourceLoader):
3246         (WebCore::ResourceLoader::start):
3247         (WebCore::ResourceLoader::fileLoadTimer):
3248         (WebCore::ResourceLoader::cancel):
3249         * platform/win/ResourceLoaderWin.h: Added.
3250         * platform/win/TemporaryLinkStubs.cpp:
3251         (WebCore::ServeSynchronousRequest):
3252         (WebCore::ResourceLoader::assembleResponseHeaders):
3253         (WebCore::ResourceLoader::retrieveCharset):
3254         * platform/win/TransferJobWin.cpp: Removed.
3255         * platform/win/TransferJobWin.h: Removed.
3256         * xml/XSLTProcessor.cpp:
3257         (WebCore::docLoaderFunc):
3258         * xml/xmlhttprequest.cpp:
3259         (WebCore::XMLHttpRequest::send):
3260         (WebCore::XMLHttpRequest::receivedAllData):
3261         (WebCore::XMLHttpRequest::receivedRedirect):
3262         (WebCore::XMLHttpRequest::receivedData):
3263         * xml/xmlhttprequest.h:
3264
3265 2006-07-31  Darin Adler  <darin@apple.com>
3266
3267         Reviewed by Hyatt.
3268
3269         - removed obsolete cell margin hack
3270
3271         * rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins):
3272         Set top and bottom margins to 0 for table cells instead of -16384.
3273         No effect on layout (including layout tests).
3274
3275         * css/CSSComputedStyleDeclaration.cpp:
3276         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3277         Added a few comments about differences between this class and the
3278         what the CSS specification says about computed style.
3279
3280 2006-07-31  Mark Rowe  <opendarwin.org@bdash.net.nz>
3281
3282         Reviewed by Maciej.
3283
3284         http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
3285         Bug 9738: Unqualified :hover selector ignored in strict parsing mode
3286
3287         * css/cssstyleselector.cpp:
3288         (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active
3289         exclusion based on onlyHoverActive to quirks mode.
3290
3291 2006-07-31  David Hyatt  <hyatt@apple.com>
3292
3293         Fix for bug 10179, digg.com scrolls slowly.  Improve fixed positioning
3294         and fixed backgrounds so that a count of them is kept on the FrameView.
3295         This allows us to switch slow scrolling on and off as these objects come
3296         and go.
3297
3298         * css/cssstyleselector.cpp:
3299         (WebCore::CSSStyleSelector::adjustRenderStyle):
3300         (WebCore::CSSStyleSelector::applyProperty):
3301         * page/FrameView.cpp:
3302         (WebCore::FrameViewPrivate::reset):
3303         (WebCore::FrameView::layout):
3304         (WebCore::FrameView::useSlowRepaints):
3305         (WebCore::FrameView::setUseSlowRepaints):
3306         (WebCore::FrameView::addSlowRepaintObject):
3307         (WebCore::FrameView::removeSlowRepaintObject):
3308         * page/FrameView.h:
3309         * rendering/RenderBox.cpp:
3310         (WebCore::RenderBox::paintBackgroundExtended):
3311         * rendering/RenderObject.cpp:
3312         (WebCore::RenderObject::setStyle):
3313         * rendering/RenderView.cpp:
3314         (WebCore::RenderView::paintBoxDecorations):
3315
3316 2006-07-31  David Hyatt  <hyatt@apple.com>
3317
3318         Begin disentangling of scrollbar logic in preparation for engine-implemented
3319         scrollbars.  Split ScrollBar into two classes, an abstract base (still named
3320         ScrollBar) and a new PlatformScrollBar subclass.  This subclass is used only
3321         by platforms that want to continue to use a platform scrollbar (rather than
3322         the engine one).
3323
3324         Reviewed by darin
3325
3326         * WebCore.xcodeproj/project.pbxproj:
3327         * html/HTMLCanvasElement.h:
3328         * page/Frame.cpp:
3329         * platform/PlatformScrollBar.h: Added.
3330         (WebCore::PlatformScrollBar::isWidget):
3331         * platform/ScrollBar.h:
3332         (WebCore::ScrollBarClient::~ScrollBarClient):
3333         (WebCore::ScrollBar::~ScrollBar):
3334         (WebCore::ScrollBar::orientation):
3335         (WebCore::ScrollBar::value):
3336         (WebCore::ScrollBar::client):
3337         * platform/mac/PlatformScrollBarMac.mm: Added.
3338         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
3339         (-[WebCoreScrollBar detachPlatformScrollBar]):
3340         (-[WebCoreScrollBar scroll:]):
3341         (-[WebCoreScrollBar widget]):
3342         (-[WebCoreScrollBar mouseDown:]):
3343         (WebCore::PlatformScrollBar::PlatformScrollBar):
3344         (WebCore::PlatformScrollBar::~PlatformScrollBar):
3345         (WebCore::PlatformScrollBar::setScrollBarValue):
3346         (WebCore::PlatformScrollBar::setKnobProportion):
3347         (WebCore::PlatformScrollBar::scrollbarHit):
3348         (WebCore::PlatformScrollBar::width):
3349         (WebCore::PlatformScrollBar::height):
3350         (WebCore::PlatformScrollBar::setRect):
3351         (WebCore::PlatformScrollBar::setEnabled):
3352         (WebCore::PlatformScrollBar::paint):
3353         * platform/mac/ScrollBarMac.mm: Removed.
3354         * platform/mac/WebCoreTextArea.mm:
3355         * rendering/RenderBlock.cpp:
3356         (WebCore::RenderBlock::isPointInScrollbar):
3357         * rendering/RenderFormElement.cpp:
3358         * rendering/RenderLayer.cpp:
3359         (WebCore::RenderLayer::horizontalScrollbarWidget):
3360         (WebCore::RenderLayer::verticalScrollbarWidget):
3361         (WebCore::RenderLayer::valueChanged):
3362         (WebCore::RenderLayer::setHasHorizontalScrollbar):
3363         (WebCore::RenderLayer::setHasVerticalScrollbar):
3364         (WebCore::RenderLayer::positionScrollbars):
3365         * rendering/RenderLayer.h:
3366         * rendering/RenderWidget.h:
3367
3368 2006-07-31  Adele Peterson  <adele@apple.com>
3369
3370         Reviewed by John and Anders.
3371
3372         - Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key
3373
3374         Test: fast/forms/onchange-enter-submit.html
3375
3376         Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
3377         This matches the sequence of events fired in WinIE.
3378
3379         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
3380         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
3381
3382 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
3383
3384         Reviewed by Kevin.
3385
3386         Moved string debug function outside of the WebCore namespace so that it's
3387         easier to call in the debugger. I will never doubt Darin again (x100).
3388
3389         * platform/String.cpp:
3390         (string):
3391
3392 2006-07-31  David Hyatt  <hyatt@apple.com>
3393
3394         Partial fix for 5453.  Improve overflow so that when it changes
3395         dynamically from scroll/auto to hidden that we properly hide the
3396         scrollbars.  Also refine the dirty dashboard region updating so that
3397         it only happens if the scrollbars genuinely come and go.
3398
3399         Also eliminate the extra repaint of the entire block.  This should not be
3400         necessary, since the scrollbars repaint themselves already and children
3401         will repaint already if they move.
3402
3403         Reviewed by darin
3404
3405         Adding test case from bug into fast/overflow/dynamic-hidden.html
3406
3407         * rendering/RenderLayer.cpp:
3408         (WebCore::RenderLayer::setHasHorizontalScrollbar):
3409         (WebCore::RenderLayer::setHasVerticalScrollbar):
3410         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
3411
3412 2006-07-31  Graham Dennis  <graham.dennis@gmail.com>
3413
3414         Reviewed by justin
3415         
3416         <http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
3417         Empty style spans created in applyInlineStyle
3418         
3419         Improves paste fidelity because some of these empty font/style spans had a non-zero
3420         size and were messing up the layout of pasted content:
3421         <rdar://problem/4515463>
3422         REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page   
3423
3424         * editing/ApplyStyleCommand.cpp:
3425         (WebCore::ApplyStyleCommand::applyInlineStyle): Use the adjusted start node instead 
3426         of start.node().  Don't do any application if the endpoints are swapped.  Adjust
3427         endNode if the start node is a descendant of it, so that the pre-order traversal will
3428         terminate properly.
3429
3430 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
3431
3432         Reviewed by Darin.
3433
3434         * platform/String.cpp:
3435         (WebCore::string): Added a debugging function to create a String from a
3436         const char*.
3437
3438 2006-07-31  Anders Carlsson  <acarlsson@apple.com>
3439
3440         * css/CSSPrimitiveValue.cpp:
3441         Fix windows build.
3442
3443 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
3444
3445         Reinstating my last change. Everything builds now.
3446         
3447 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
3448
3449         Backing out my last change because it causes a build failure in some
3450         configurations. This seems to be the cleanest way to get svn to cooperate.
3451
3452 2006-07-31  Geoffrey Garen  <ggaren@apple.com>
3453
3454         Reviewed by Maciej.
3455
3456         Moved files around to make WebCore's structure clearer
3457         and easier to explain.
3458
3459         DerivedSources/JS* -> bindings/js/DerivedSources/ (so JS* files
3460         show up when you search inside bindings/js/, but are marked, at
3461         the same time, as files that you should not edit manually)
3462
3463         WebCore+SVG/DOMList.h -> ksvg2/svg/ (only files inside ksvg2/svg/
3464         use DOMList.h)
3465
3466         icon -> loader/icon
3467
3468         I tested that everything still builds.
3469
3470 2006-07-30  Darin Adler  <darin@apple.com>
3471
3472         Reviewed by Tim Hatcher.
3473
3474         - some improvements for the benefit of the style pane of the inspector
3475
3476         * css/CSSComputedStyleDeclaration.cpp: Removed background-position
3477         and border-spacing from the list of properties that show up in
3478         computed style, because of background-position-x, background-position-y,
3479         -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
3480         (WebCore::valueForLength): Added handling for undefinedLength, intrinsic,
3481         and min-intrinsic.
3482         (WebCore::primitiveValueFromLength): Removed code that would add a
3483         space to the string for no good reason.
3484         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a
3485         special case for a line clamp of -1, which should come back as "none"
3486         rather than an actual "-1".
3487         (WebCore::CSSComputedStyleDeclaration::length): Return 0 if the
3488         declaration has no corresponding node or no renderer.
3489         (WebCore::CSSComputedStyleDeclaration::item): Check against length()
3490         so that the two stay consistent rather than using a constant.
3491
3492         * css/CSSPrimitiveValue.cpp:
3493         (WebCore::isCSSTokenizerIdentifier): Added.
3494         (WebCore::isCSSTokenizerURL): Added.
3495         (WebCore::quoteString): Added.
3496         (WebCore::quoteStringIfNeeded): Changed to quote strings in many more
3497         cases -- any cases where they would not parse in the CSS parser otherwise.
3498         The main case this affects is font names with spaces in them.
3499         (WebCore::quoteURLIfNeeded): Added.
3500         (WebCore::CSSPrimitiveValue::cssText): Use quoteURLIfNeeded in the case
3501         where we're making the text form of a URI.
3502
3503         * css/tokenizer.flex: Whitespace tweaks to line things up better.
3504
3505 2006-07-30  Eric Seidel  <eric@eseidel.com>
3506
3507         Reviewed by gramps!
3508
3509         Remove some unused SVG code.
3510
3511         * ksvg2/ecma/Ecma.cpp: Removed.
3512         * ksvg2/ecma/Ecma.h: Removed.
3513         * ksvg2/ecma/GlobalObject.cpp: remove a couple dead functions.
3514         * ksvg2/ecma/GlobalObject.h: add a comment about this dead code.
3515         * ksvg2/ecma/SVGLookup.h: Removed.
3516
3517 2006-07-29  Darin Adler  <darin@apple.com>
3518
3519         - Removed tabs from these source files that still had them.
3520           We don't use them; that way source files look fine in editors
3521           that have tabs set to 8 spaces or to 4 spaces.
3522         - Removed allow-tabs Subversion property from the files too.
3523
3524         * bindings/objc/WebScriptObject.h:
3525         * bindings/objc/WebScriptObject.mm:
3526         * platform/FontData.cpp:
3527
3528 2006-07-29  Sam Weinig  <sam.weinig@gmail.com>
3529
3530         Reviewed by Darin.
3531
3532         - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080
3533           Adopt pedantic changes from the Unity project to improve 
3534           cross-compiler compatibility
3535
3536           Changes include:
3537           * Removing trailing semicolon from namespace braces.
3538           * Removing trailing comma from last enum declaration.
3539           * Updating to match style guidelines.
3540           * Adding missing newline to the end of the file.
3541           * Turning on gcc warning for missing newline at the end of a source file
3542             (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
3543           * Alphabetical sorting of Xcode source list files.
3544           * Use abs() function from <math.h> instead of ABS() macro.
3545           * Use C-style comments instead of C++ comments in files that might
3546             be included by either C or C++ files.
3547           * Use -numeric_limits<double>::infinity() instead of -HUGE_VAL.
3548
3549         * WebCore+SVG/DOMList.h:
3550         * WebCore.xcodeproj/project.pbxproj:
3551         * WebCorePrefix.h:
3552         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3553         * bindings/js/JSXSLTProcessor.h:
3554         * bindings/js/kjs_domnode.h:
3555         (KJS::DOMNode::):
3556         * bindings/objc/DOMCSS.h:
3557         (-[DOMCSSValue enum]):