WebCore/ChangeLog

   1 2006-10-31  Adam Roben  <aroben@apple.com>
   2
   3         Reviewed by Steve.
   4
   5         Fix some incorrect forward declarations.
   6
   7         * loader/FrameLoader.h:
   8         * page/Frame.h:
   9
  10 2006-10-31  Darin Adler  <darin@apple.com>
  11
  12         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
  13         try to fix the build on the buildbot.
  14
  15 2006-10-31  Darin Adler  <darin@apple.com>
  16
  17         * bridge/mac/FrameMac.mm:
  18         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
  19         (WebCore::FrameMac::markMisspellings): Ditto.
  20
  21 2006-10-31  John Sullivan  <sullivan@apple.com>
  22
  23         * bridge/mac/FrameMac.mm:
  24         (WebCore::FrameMac::advanceToNextMisspelling):
  25         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
  26
  27 2006-10-30  John Sullivan  <sullivan@apple.com>
  28
  29         Reviewed by Adam Roben
  30
  31         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
  32
  33         This patch introduces much of the guts of grammar checking, though still not enough to actually
  34         check grammar sensibly, due to:
  35
  36         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
  37         context passed to grammar checker
  38
  39         * platform/Logging.h:
  40         * platform/Logging.cpp:
  41         new log channel SpellingAndGrammar
  42
  43         * bridge/mac/WebCorePageBridge.mm:
  44         (initializeLoggingChannelsIfNecessary):
  45         initialize new log channel
  46
  47         * bridge/mac/FrameMac.mm:
  48         (WebCore::FrameMac::advanceToNextMisspelling):
  49         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
  50         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
  51         in the event of a tie), and do further processing with that one (select range; create marker that
  52         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
  53         (WebCore::FrameMac::markMisspellings):
  54         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
  55         differently enough to make sharing code between these two functions a little tricky, so I decided to
  56         save that for a later patch.
  57
  58         (WebCore::FrameMac::respondToChangedSelection):
  59         remove grammar markers when we remove spelling markers
  60
  61 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
  62
  63         Reviewed by Mitz.
  64
  65         Fix Qt/Linux build with older gcc3.3.4.
  66
  67         * bindings/js/kjs_window.cpp:
  68         (KJS::WindowFunc::callAsFunction):
  69
  70 2006-10-31  Zack Rusin  <zack@kde.org>
  71
  72         Reviewed by Mitz.
  73
  74         Fix the Qt build after last nights changes.
  75
  76         * WebCore/platform/qt/FrameQt.cpp:
  77         * WebCore/platform/qt/EditorClientQt.h:
  78         * WebCore/platform/qt/EditorClientQt.cpp:
  79         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
  80         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  81         * WebCore/CMakeLists.txt:
  82         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
  83         * WebKitQt/QtLauncher/CMakeLists.txt:
  84         * WebKitQt/WebKitPart/CMakeLists.txt:
  85
  86 2006-10-30  Darin Adler  <darin@apple.com>
  87
  88         Reviewed by Anders.
  89
  90         - remove BrowserExtension
  91
  92         * WebCore.vcproj/WebCore/WebCore.vcproj:
  93         * WebCore.xcodeproj/project.pbxproj:
  94         * bindings/js/kjs_window.cpp:
  95         (KJS::createNewWindow):
  96         (KJS::WindowFunc::callAsFunction):
  97         * bridge/BrowserExtension.h: Removed.
  98         * bridge/mac/BrowserExtensionMac.h: Removed.
  99         * bridge/mac/BrowserExtensionMac.mm: Removed.
 100         * bridge/mac/FrameMac.mm:
 101         (WebCore::FrameMac::FrameMac):
 102         (WebCore::FrameMac::submitForm):
 103         (WebCore::FrameMac::urlSelected):
 104         * bridge/win/BrowserExtensionWin.cpp: Removed.
 105         * bridge/win/BrowserExtensionWin.h: Removed.
 106         * bridge/win/FrameWin.cpp:
 107         (WebCore::FrameWin::FrameWin):
 108         * loader/FrameLoader.cpp:
 109         (WebCore::FrameLoader::createWindow):
 110         * loader/FrameLoader.h:
 111         * loader/icon/IconLoader.cpp:
 112         * loader/mac/FrameLoaderMac.mm:
 113         (WebCore::FrameLoader::safeLoad):
 114         (WebCore::FrameLoader::load):
 115         (WebCore::FrameLoader::createWindow):
 116         * page/Frame.cpp:
 117         (WebCore::Frame::urlSelected):
 118         (WebCore::Frame::requestFrame):
 119         (WebCore::Frame::submitForm):
 120         (WebCore::Frame::scheduleHistoryNavigation):
 121         (WebCore::Frame::redirectionTimerFired):
 122         * page/Frame.h:
 123         * page/FrameLoadRequest.h:
 124         (WebCore::FrameLoadRequest::FrameLoadRequest):
 125         (WebCore::FrameLoadRequest::isEmpty):
 126         (WebCore::FrameLoadRequest::resourceRequest):
 127         (WebCore::FrameLoadRequest::frameName):
 128         (WebCore::FrameLoadRequest::setFrameName):
 129         * page/FramePrivate.h:
 130         (WebCore::FramePrivate::FramePrivate):
 131         (WebCore::FramePrivate::~FramePrivate):
 132         * platform/gdk/BrowserExtensionGdk.h: Removed.
 133         * platform/gdk/FrameGdk.cpp:
 134         (WebCore::FrameGdk::FrameGdk):
 135         * platform/gdk/TemporaryLinkStubs.cpp:
 136         * platform/network/ResourceRequest.h:
 137         (WebCore::ResourceRequest::isEmpty):
 138
 139 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
 140
 141         Reviewed by Oliver.
 142
 143         Modified from original due to earlier reversion
 144
 145         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
 146
 147         Better SVG integration in WebKit, Part I.
 148
 149         The patch is mostly about creating a new platform/graphics directory, and
 150         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
 151         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
 152         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
 153
 154         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
 155         All details of the patch, and upcoming patches can be found in the bug report.
 156
 157         * CMakeLists.txt:
 158         * WebCore.xcodeproj/project.pbxproj:
 159         * graphics/svg/SVGResource.cpp: Removed.
 160         * graphics/svg/SVGResourceClipper.cpp: Removed.
 161         * graphics/svg/SVGResourceClipper.h: Removed.
 162         * graphics/svg/SVGResourceImage.h: Removed.
 163         * graphics/svg/SVGResourceListener.h: Removed.
 164         * graphics/svg/SVGResourceMarker.cpp: Removed.
 165         * graphics/svg/SVGResourceMarker.h: Removed.
 166         * graphics/svg/SVGResourceMasker.cpp: Removed.
 167         * graphics/svg/SVGResourceMasker.h: Removed.
 168         * kcanvas/KCanvasClipper.cpp: Removed.
 169         * kcanvas/KCanvasClipper.h: Removed.
 170         * kcanvas/KCanvasCreator.cpp: Removed.
 171         * kcanvas/KCanvasCreator.h: Removed.
 172         * kcanvas/KCanvasFilters.cpp:
 173         (WebCore::getFilterById):
 174         * kcanvas/KCanvasFilters.h:
 175         * kcanvas/KCanvasImage.h: Removed.
 176         * kcanvas/KCanvasMarker.cpp: Removed.
 177         * kcanvas/KCanvasMarker.h: Removed.
 178         * kcanvas/KCanvasMasker.cpp: Removed.
 179         * kcanvas/KCanvasMasker.h: Removed.
 180         * kcanvas/KCanvasResource.cpp: Removed.
 181         * kcanvas/KCanvasResource.h: Removed.
 182         * kcanvas/KCanvasResourceListener.h: Removed.
 183         * kcanvas/KCanvasTreeDebug.cpp:
 184         (WebCore::writeRenderResources):
 185         * kcanvas/device/KRenderingDevice.h:
 186         * kcanvas/device/KRenderingPaintServer.h:
 187         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
 188         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 189         (WebCore::KRenderingPaintServerGradient::listener):
 190         (WebCore::KRenderingPaintServerGradient::setListener):
 191         * kcanvas/device/KRenderingPaintServerGradient.h:
 192         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 193         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
 194         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
 195         (WebCore::KRenderingPaintServerPattern::tile):
 196         (WebCore::KRenderingPaintServerPattern::setTile):
 197         (WebCore::KRenderingPaintServerPattern::listener):
 198         (WebCore::KRenderingPaintServerPattern::setListener):
 199         * kcanvas/device/KRenderingPaintServerPattern.h:
 200         * kcanvas/device/KRenderingPaintServerSolid.h:
 201         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
 202         * kcanvas/device/qt/KCanvasClipperQt.h:
 203         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
 204         (WebCore::KRenderingDeviceQt::contextForImage):
 205         (WebCore::KRenderingDeviceQt::createResource):
 206         (WebCore::KRenderingDeviceQt::createPaintServer):
 207         * kcanvas/device/qt/KRenderingDeviceQt.h:
 208         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 209         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 210         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 211         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 212         * kcanvas/device/qt/RenderPathQt.h: Removed.
 213         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 214         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
 215         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 216         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
 217         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
 218         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
 219         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
 220         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 221         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
 222         (WebCore::KRenderingDeviceQuartz::contextForImage):
 223         (WebCore::KRenderingDeviceQuartz::createPaintServer):
 224         (WebCore::KRenderingDeviceQuartz::createResource):
 225         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 226         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
 227         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
 228         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 229         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 230         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 231         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 232         (WebCore::patternCallback):
 233         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 234         * kcanvas/device/quartz/QuartzSupport.mm:
 235         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 236         (WebCore::sharedSolidPaintServer):
 237         * ksvg2/svg/SVGClipPathElement.cpp:
 238         (WebCore::SVGClipPathElement::SVGClipPathElement):
 239         (WebCore::SVGClipPathElement::~SVGClipPathElement):
 240         (WebCore::SVGClipPathElement::canvasResource):
 241         * ksvg2/svg/SVGClipPathElement.h:
 242         * ksvg2/svg/SVGFEImageElement.cpp:
 243         * ksvg2/svg/SVGFilterElement.cpp:
 244         (WebCore::SVGFilterElement::SVGFilterElement):
 245         (WebCore::SVGFilterElement::~SVGFilterElement):
 246         (WebCore::SVGFilterElement::canvasResource):
 247         * ksvg2/svg/SVGFilterElement.h:
 248         * ksvg2/svg/SVGGradientElement.cpp:
 249         (WebCore::SVGGradientElement::SVGGradientElement):
 250         (WebCore::SVGGradientElement::~SVGGradientElement):
 251         (WebCore::SVGGradientElement::canvasResource):
 252         (WebCore::SVGGradientElement::resourceNotification):
 253         * ksvg2/svg/SVGGradientElement.h:
 254         * ksvg2/svg/SVGImageElement.cpp:
 255         * ksvg2/svg/SVGLinearGradientElement.cpp:
 256         (WebCore::SVGLinearGradientElement::buildGradient):
 257         * ksvg2/svg/SVGLinearGradientElement.h:
 258         * ksvg2/svg/SVGMarkerElement.cpp:
 259         (WebCore::SVGMarkerElement::SVGMarkerElement):
 260         (WebCore::SVGMarkerElement::~SVGMarkerElement):
 261         (WebCore::SVGMarkerElement::canvasResource):
 262         * ksvg2/svg/SVGMarkerElement.h:
 263         * ksvg2/svg/SVGMaskElement.cpp:
 264         (WebCore::SVGMaskElement::SVGMaskElement):
 265         (WebCore::SVGMaskElement::~SVGMaskElement):
 266         (WebCore::SVGMaskElement::drawMaskerContent):
 267         (WebCore::SVGMaskElement::canvasResource):
 268         * ksvg2/svg/SVGMaskElement.h:
 269         * ksvg2/svg/SVGPatternElement.cpp:
 270         (WebCore::SVGPatternElement::SVGPatternElement):
 271         (WebCore::SVGPatternElement::~SVGPatternElement):
 272         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
 273         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
 274         (WebCore::SVGPatternElement::canvasResource):
 275         * ksvg2/svg/SVGPatternElement.h:
 276         * ksvg2/svg/SVGRadialGradientElement.cpp:
 277         (WebCore::SVGRadialGradientElement::buildGradient):
 278         * ksvg2/svg/SVGRadialGradientElement.h:
 279         * ksvg2/svg/SVGStyledElement.h:
 280         (WebCore::SVGStyledElement::canvasResource):
 281         * platform/GraphicsContext.cpp: Removed.
 282         * platform/GraphicsContext.h: Removed.
 283         * platform/GraphicsTypes.cpp: Removed.
 284         * platform/GraphicsTypes.h: Removed.
 285         * platform/graphics/GraphicsContext.cpp:
 286         (WebCore::GraphicsContextState::GraphicsContextState):
 287         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
 288         (WebCore::GraphicsContext::createGraphicsContextPrivate):
 289         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
 290         (WebCore::GraphicsContext::save):
 291         (WebCore::GraphicsContext::restore):
 292         (WebCore::GraphicsContext::font):
 293         (WebCore::GraphicsContext::setFont):
 294         (WebCore::GraphicsContext::pen):
 295         (WebCore::GraphicsContext::setPen):
 296         (WebCore::GraphicsContext::setFillColor):
 297         (WebCore::GraphicsContext::fillColor):
 298         (WebCore::GraphicsContext::updatingControlTints):
 299         (WebCore::GraphicsContext::setUpdatingControlTints):
 300         (WebCore::GraphicsContext::setPaintingDisabled):
 301         (WebCore::GraphicsContext::paintingDisabled):
 302         (WebCore::GraphicsContext::drawImage):
 303         (WebCore::GraphicsContext::drawText):
 304         (WebCore::GraphicsContext::drawHighlightForText):
 305         (WebCore::GraphicsContext::initFocusRing):
 306         (WebCore::GraphicsContext::clearFocusRing):
 307         (WebCore::GraphicsContext::focusRingBoundingRect):
 308         (WebCore::GraphicsContext::addFocusRingRect):
 309         (WebCore::GraphicsContext::focusRingWidth):
 310         (WebCore::GraphicsContext::focusRingOffset):
 311         (WebCore::GraphicsContext::focusRingRects):
 312         (WebCore::GraphicsContext::drawTiledImage):
 313         * platform/graphics/GraphicsContext.h:
 314         * platform/graphics/GraphicsTypes.cpp:
 315         (WebCore::):
 316         (WebCore::parseCompositeOperator):
 317         (WebCore::compositeOperatorName):
 318         (WebCore::parseLineCap):
 319         (WebCore::lineCapName):
 320         (WebCore::parseLineJoin):
 321         (WebCore::lineJoinName):
 322         * platform/graphics/GraphicsTypes.h:
 323         (WebCore::):
 324         * platform/graphics/svg/SVGResource.cpp: Added.
 325         (WebCore::SVGResource::SVGResource):
 326         (WebCore::SVGResource::~SVGResource):
 327         (WebCore::SVGResource::invalidate):
 328         (WebCore::SVGResource::addClient):
 329         (WebCore::SVGResource::clients):
 330         (WebCore::SVGResource::idInRegistry):
 331         (WebCore::SVGResource::setIdInRegistry):
 332         (WebCore::SVGResource::externalRepresentation):
 333         (WebCore::getResourceById):
 334         (WebCore::getPaintServerById):
 335         (WebCore::operator<<):
 336         * platform/graphics/svg/SVGResource.h: Added.
 337         (WebCore::):
 338         (WebCore::SVGResource::isPaintServer):
 339         (WebCore::SVGResource::isFilter):
 340         (WebCore::SVGResource::isClipper):
 341         (WebCore::SVGResource::isMarker):
 342         (WebCore::SVGResource::isMasker):
 343         (WebCore::SVGResourceListener::~SVGResourceListener):
 344         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
 345         (WebCore::SVGResourceClipper::SVGResourceClipper):
 346         (WebCore::SVGResourceClipper::~SVGResourceClipper):
 347         (WebCore::SVGResourceClipper::resetClipData):
 348         (WebCore::SVGResourceClipper::addClipData):
 349         (WebCore::SVGResourceClipper::clipData):
 350         (WebCore::SVGResourceClipper::externalRepresentation):
 351         (WebCore::operator<<):
 352         (WebCore::getClipperById):
 353         * platform/graphics/svg/SVGResourceClipper.h: Added.
 354         (WebCore::ClipDataList::addPath):
 355         (WebCore::SVGResourceClipper::isClipper):
 356         * platform/graphics/svg/SVGResourceImage.h: Added.
 357         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
 358         (WebCore::SVGResourceMarker::SVGResourceMarker):
 359         (WebCore::SVGResourceMarker::~SVGResourceMarker):
 360         (WebCore::SVGResourceMarker::setMarker):
 361         (WebCore::SVGResourceMarker::setRef):
 362         (WebCore::SVGResourceMarker::draw):
 363         (WebCore::SVGResourceMarker::externalRepresentation):
 364         (WebCore::getMarkerById):
 365         * platform/graphics/svg/SVGResourceMarker.h: Added.
 366         (WebCore::SVGResourceMarker::refX):
 367         (WebCore::SVGResourceMarker::refY):
 368         (WebCore::SVGResourceMarker::setAngle):
 369         (WebCore::SVGResourceMarker::setAutoAngle):
 370         (WebCore::SVGResourceMarker::angle):
 371         (WebCore::SVGResourceMarker::setUseStrokeWidth):
 372         (WebCore::SVGResourceMarker::useStrokeWidth):
 373         (WebCore::SVGResourceMarker::isMarker):
 374         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
 375         (WebCore::SVGResourceMasker::SVGResourceMasker):
 376         (WebCore::SVGResourceMasker::~SVGResourceMasker):
 377         (WebCore::SVGResourceMasker::setMask):
 378         (WebCore::SVGResourceMasker::mask):
 379         (WebCore::SVGResourceMasker::externalRepresentation):
 380         (WebCore::getMaskerById):
 381         * platform/graphics/svg/SVGResourceMasker.h: Added.
 382         (WebCore::SVGResourceMasker::isMasker):
 383         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
 384         (WebCore::SVGResourceClipper::applyClip):
 385         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
 386         (WebCore::SVGResourceImage::SVGResourceImage):
 387         (WebCore::SVGResourceImage::~SVGResourceImage):
 388         (WebCore::SVGResourceImage::init):
 389         (WebCore::SVGResourceImage::size):
 390         (WebCore::SVGResourceImage::cgLayer):
 391         (WebCore::SVGResourceImage::setCGLayer):
 392         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
 393         (WebCore::applyLuminanceToAlphaFilter):
 394         (WebCore::applyExpandAlphatoGrayscaleFilter):
 395         (WebCore::transformImageIntoGrayscaleMask):
 396         (WebCore::SVGResourceMasker::applyMask):
 397         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
 398         (WebCore::SVGResourceClipper::applyClip):
 399         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
 400         (WebCore::SVGResourceImage::init):
 401         (WebCore::SVGResourceImage::size):
 402         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
 403         (WebCore::SVGResourceMasker::applyMask):
 404         * platform/qt/GraphicsContextQt.cpp:
 405         * rendering/RenderPath.cpp:
 406         (WebCore::RenderPath::paint):
 407         (WebCore::DrawMarkersData::DrawMarkersData):
 408         (WebCore::RenderPath::drawMarkersIfNeeded):
 409         * rendering/RenderSVGContainer.cpp:
 410         (WebCore::RenderSVGContainer::paint):
 411         * rendering/RenderSVGImage.cpp:
 412         (WebCore::RenderSVGImage::paint):
 413         * rendering/SVGInlineFlowBox.cpp:
 414         (WebCore::paintSVGInlineFlow):
 415
 416 2006-10-30  John Sullivan  <sullivan@apple.com>
 417
 418         Reviewed by Brady
 419
 420         - minor cleanup to make future patches clearer
 421
 422         * bridge/mac/FrameMac.mm:
 423         (WebCore::FrameMac::advanceToNextMisspelling):
 424         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
 425         with "continue" to better match structure of similar code in markMisspellings; a few
 426         other style tweaks.
 427
 428         (WebCore::FrameMac::markMisspellings):
 429         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
 430         a block just after a break and outdented accordingly.
 431
 432 2006-10-30  John Sullivan  <sullivan@apple.com>
 433
 434         Reviewed by Geoff Garen
 435
 436         WebCore part of change to push the code that updates the spelling panel
 437         into WebCore, in preparation for some grammar-checking stuff.
 438
 439         * bridge/mac/FrameMac.h:
 440         * bridge/mac/FrameMac.mm:
 441         (WebCore::FrameMac::advanceToNextMisspelling):
 442         no more return value for this method, and update the spelling panel with
 443         the misspelled word here rather than in the WebKit callers.
 444
 445 2006-10-30  Oliver Hunt  <oliver@apple.com>
 446
 447         Reviewed by Anders.
 448
 449         Roll out last patch
 450
 451         * CMakeLists.txt:
 452         * ChangeLog:
 453         * WebCore.xcodeproj/project.pbxproj:
 454         * graphics/svg/SVGResource.cpp:
 455         * graphics/svg/SVGResourceClipper.cpp:
 456         * graphics/svg/SVGResourceClipper.h:
 457         * graphics/svg/SVGResourceImage.h:
 458         * graphics/svg/SVGResourceListener.h:
 459         * graphics/svg/SVGResourceMarker.cpp:
 460         * graphics/svg/SVGResourceMarker.h:
 461         * graphics/svg/SVGResourceMasker.cpp:
 462         * graphics/svg/SVGResourceMasker.h:
 463         * kcanvas/KCanvasClipper.cpp: Added.
 464         (WebCore::operator<<):
 465         (WebCore::KCanvasClipper::KCanvasClipper):
 466         (WebCore::KCanvasClipper::~KCanvasClipper):
 467         (WebCore::KCanvasClipper::resetClipData):
 468         (WebCore::KCanvasClipper::addClipData):
 469         (WebCore::KCanvasClipper::clipData):
 470         (WebCore::KCanvasClipper::externalRepresentation):
 471         (WebCore::getClipperById):
 472         * kcanvas/KCanvasClipper.h: Added.
 473         (WebCore::KCClipData::windRule):
 474         (WebCore::KCClipDataList::KCClipDataList):
 475         (WebCore::KCClipDataList::addPath):
 476         (WebCore::KCanvasClipper::isClipper):
 477         * kcanvas/KCanvasFilters.cpp:
 478         (WebCore::getFilterById):
 479         * kcanvas/KCanvasFilters.h:
 480         * kcanvas/KCanvasImage.h: Added.
 481         (WebCore::KCanvasImage::KCanvasImage):
 482         (WebCore::KCanvasImage::~KCanvasImage):
 483         * kcanvas/KCanvasMarker.cpp: Added.
 484         (WebCore::KCanvasMarker::KCanvasMarker):
 485         (WebCore::KCanvasMarker::~KCanvasMarker):
 486         (WebCore::KCanvasMarker::setMarker):
 487         (WebCore::KCanvasMarker::setRef):
 488         (WebCore::KCanvasMarker::refX):
 489         (WebCore::KCanvasMarker::refY):
 490         (WebCore::KCanvasMarker::setAngle):
 491         (WebCore::KCanvasMarker::angle):
 492         (WebCore::KCanvasMarker::setAutoAngle):
 493         (WebCore::KCanvasMarker::setUseStrokeWidth):
 494         (WebCore::KCanvasMarker::useStrokeWidth):
 495         (WebCore::KCanvasMarker::draw):
 496         (WebCore::KCanvasMarker::externalRepresentation):
 497         (WebCore::getMarkerById):
 498         * kcanvas/KCanvasMarker.h: Added.
 499         (WebCore::KCanvasMarker::isMarker):
 500         * kcanvas/KCanvasMasker.cpp: Added.
 501         (WebCore::KCanvasMasker::KCanvasMasker):
 502         (WebCore::KCanvasMasker::~KCanvasMasker):
 503         (WebCore::KCanvasMasker::setMask):
 504         (WebCore::KCanvasMasker::externalRepresentation):
 505         (WebCore::getMaskerById):
 506         * kcanvas/KCanvasMasker.h: Added.
 507         (WebCore::KCanvasMasker::isMasker):
 508         (WebCore::KCanvasMasker::mask):
 509         * kcanvas/KCanvasResource.cpp: Added.
 510         (WebCore::operator<<):
 511         (WebCore::KCanvasResource::KCanvasResource):
 512         (WebCore::KCanvasResource::~KCanvasResource):
 513         (WebCore::KCanvasResource::addClient):
 514         (WebCore::KCanvasResource::clients):
 515         (WebCore::KCanvasResource::invalidate):
 516         (WebCore::KCanvasResource::idInRegistry):
 517         (WebCore::KCanvasResource::setIdInRegistry):
 518         (WebCore::KCanvasResource::externalRepresentation):
 519         (WebCore::getResourceById):
 520         (WebCore::getPaintServerById):
 521         * kcanvas/KCanvasResource.h:
 522         (WebCore::):
 523         (WebCore::KCanvasResource::isPaintServer):
 524         (WebCore::KCanvasResource::isFilter):
 525         (WebCore::KCanvasResource::isClipper):
 526         (WebCore::KCanvasResource::isMarker):
 527         (WebCore::KCanvasResource::isMasker):
 528         * kcanvas/KCanvasResourceListener.h: Added.
 529         (KCanvasResourceListener::KCanvasResourceListener):
 530         (KCanvasResourceListener::~KCanvasResourceListener):
 531         * kcanvas/KCanvasTreeDebug.cpp:
 532         (WebCore::writeRenderResources):
 533         * kcanvas/device/KRenderingDevice.h:
 534         * kcanvas/device/KRenderingPaintServer.h:
 535         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
 536         (WebCore::KRenderingPaintServer::idInRegistry):
 537         (WebCore::KRenderingPaintServer::setIdInRegistry):
 538         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 539         (WebCore::KRenderingPaintServerGradient::listener):
 540         (WebCore::KRenderingPaintServerGradient::setListener):
 541         * kcanvas/device/KRenderingPaintServerGradient.h:
 542         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 543         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
 544         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
 545         (WebCore::KRenderingPaintServerPattern::tile):
 546         (WebCore::KRenderingPaintServerPattern::setTile):
 547         (WebCore::KRenderingPaintServerPattern::listener):
 548         (WebCore::KRenderingPaintServerPattern::setListener):
 549         * kcanvas/device/KRenderingPaintServerPattern.h:
 550         * kcanvas/device/KRenderingPaintServerSolid.h:
 551         * kcanvas/device/qt/KCanvasClipperQt.cpp:
 552         (WebCore::KCanvasClipperQt::applyClip):
 553         * kcanvas/device/qt/KCanvasClipperQt.h:
 554         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
 555         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
 556         (WebCore::KRenderingDeviceQt::contextForImage):
 557         (WebCore::KRenderingDeviceQt::createResource):
 558         (WebCore::KRenderingDeviceQt::createPaintServer):
 559         * kcanvas/device/qt/KRenderingDeviceQt.h:
 560         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
 561         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
 562         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
 563         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
 564         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 565         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
 566         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
 567         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
 568         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
 569         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
 570         (WebCore::applyLuminanceToAlphaFilter):
 571         (WebCore::applyExpandAlphatoGrayscaleFilter):
 572         (WebCore::transformImageIntoGrayscaleMask):
 573         (WebCore::KCanvasMaskerQuartz::applyMask):
 574         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
 575         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
 576         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
 577         (WebCore::KCanvasImageQuartz::init):
 578         (WebCore::KCanvasImageQuartz::size):
 579         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
 580         (WebCore::KCanvasClipperQuartz::applyClip):
 581         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
 582         (WebCore::KCanvasImageQuartz::cgLayer):
 583         (WebCore::KCanvasImageQuartz::setCGLayer):
 584         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 585         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
 586         (WebCore::KRenderingDeviceQuartz::contextForImage):
 587         (WebCore::KRenderingDeviceQuartz::createPaintServer):
 588         (WebCore::KRenderingDeviceQuartz::createResource):
 589         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 590         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
 591         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
 592         (WebCore::KRenderingPaintServerGradientQuartz::setup):
 593         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
 594         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 595         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 596         (WebCore::patternCallback):
 597         (WebCore::KRenderingPaintServerPatternQuartz::setup):
 598         * kcanvas/device/quartz/QuartzSupport.mm:
 599         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 600         (WebCore::sharedSolidPaintServer):
 601         * ksvg2/svg/SVGClipPathElement.cpp:
 602         (WebCore::SVGClipPathElement::SVGClipPathElement):
 603         (WebCore::SVGClipPathElement::~SVGClipPathElement):
 604         (WebCore::SVGClipPathElement::canvasResource):
 605         * ksvg2/svg/SVGClipPathElement.h:
 606         * ksvg2/svg/SVGFEImageElement.cpp:
 607         * ksvg2/svg/SVGFilterElement.cpp:
 608         (WebCore::SVGFilterElement::SVGFilterElement):
 609         (WebCore::SVGFilterElement::~SVGFilterElement):
 610         (WebCore::SVGFilterElement::canvasResource):
 611         * ksvg2/svg/SVGFilterElement.h:
 612         * ksvg2/svg/SVGGradientElement.cpp:
 613         (WebCore::SVGGradientElement::SVGGradientElement):
 614         (WebCore::SVGGradientElement::~SVGGradientElement):
 615         (WebCore::SVGGradientElement::canvasResource):
 616         (WebCore::SVGGradientElement::resourceNotification):
 617         * ksvg2/svg/SVGGradientElement.h:
 618         * ksvg2/svg/SVGImageElement.cpp:
 619         * ksvg2/svg/SVGLinearGradientElement.cpp:
 620         (WebCore::SVGLinearGradientElement::buildGradient):
 621         * ksvg2/svg/SVGLinearGradientElement.h:
 622         * ksvg2/svg/SVGMarkerElement.cpp:
 623         (WebCore::SVGMarkerElement::SVGMarkerElement):
 624         (WebCore::SVGMarkerElement::~SVGMarkerElement):
 625         (WebCore::SVGMarkerElement::canvasResource):
 626         * ksvg2/svg/SVGMarkerElement.h:
 627         * ksvg2/svg/SVGMaskElement.cpp:
 628         (WebCore::SVGMaskElement::SVGMaskElement):
 629         (WebCore::SVGMaskElement::~SVGMaskElement):
 630         (WebCore::SVGMaskElement::drawMaskerContent):
 631         (WebCore::SVGMaskElement::canvasResource):
 632         * ksvg2/svg/SVGMaskElement.h:
 633         * ksvg2/svg/SVGPatternElement.cpp:
 634         (WebCore::SVGPatternElement::SVGPatternElement):
 635         (WebCore::SVGPatternElement::~SVGPatternElement):
 636         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
 637         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
 638         (WebCore::SVGPatternElement::canvasResource):
 639         * ksvg2/svg/SVGPatternElement.h:
 640         * ksvg2/svg/SVGRadialGradientElement.cpp:
 641         (WebCore::SVGRadialGradientElement::buildGradient):
 642         * ksvg2/svg/SVGRadialGradientElement.h:
 643         * ksvg2/svg/SVGStyledElement.h:
 644         (WebCore::SVGStyledElement::canvasResource):
 645         * platform/GraphicsContext.cpp: Added.
 646         (WebCore::GraphicsContextState::GraphicsContextState):
 647         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
 648         (WebCore::GraphicsContext::createGraphicsContextPrivate):
 649         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
 650         (WebCore::GraphicsContext::save):
 651         (WebCore::GraphicsContext::restore):
 652         (WebCore::GraphicsContext::font):
 653         (WebCore::GraphicsContext::setFont):
 654         (WebCore::GraphicsContext::pen):
 655         (WebCore::GraphicsContext::setPen):
 656         (WebCore::GraphicsContext::setFillColor):
 657         (WebCore::GraphicsContext::fillColor):
 658         (WebCore::GraphicsContext::updatingControlTints):
 659         (WebCore::GraphicsContext::setUpdatingControlTints):
 660         (WebCore::GraphicsContext::setPaintingDisabled):
 661         (WebCore::GraphicsContext::paintingDisabled):
 662         (WebCore::GraphicsContext::drawImage):
 663         (WebCore::GraphicsContext::drawText):
 664         (WebCore::GraphicsContext::drawHighlightForText):
 665         (WebCore::GraphicsContext::initFocusRing):
 666         (WebCore::GraphicsContext::clearFocusRing):
 667         (WebCore::GraphicsContext::focusRingBoundingRect):
 668         (WebCore::GraphicsContext::addFocusRingRect):
 669         (WebCore::GraphicsContext::focusRingWidth):
 670         (WebCore::GraphicsContext::focusRingOffset):
 671         (WebCore::GraphicsContext::focusRingRects):
 672         (WebCore::GraphicsContext::drawTiledImage):
 673         * platform/GraphicsContext.h: Added.
 674         * platform/GraphicsTypes.cpp: Added.
 675         (WebCore::):
 676         (WebCore::parseCompositeOperator):
 677         (WebCore::compositeOperatorName):
 678         (WebCore::parseLineCap):
 679         (WebCore::lineCapName):
 680         (WebCore::parseLineJoin):
 681         (WebCore::lineJoinName):
 682         * platform/GraphicsTypes.h: Added.
 683         (WebCore::):
 684         * platform/graphics/GraphicsContext.cpp:
 685         * platform/graphics/GraphicsContext.h:
 686         * platform/graphics/GraphicsTypes.cpp:
 687         * platform/graphics/GraphicsTypes.h:
 688         * platform/qt/GraphicsContextQt.cpp:
 689         * rendering/RenderPath.cpp:
 690         (WebCore::RenderPath::paint):
 691         (WebCore::DrawMarkersData::DrawMarkersData):
 692         (WebCore::RenderPath::drawMarkersIfNeeded):
 693         * rendering/RenderSVGContainer.cpp:
 694         (WebCore::RenderSVGContainer::paint):
 695         * rendering/RenderSVGImage.cpp:
 696         (WebCore::RenderSVGImage::paint):
 697         * rendering/SVGInlineFlowBox.cpp:
 698         (WebCore::paintSVGInlineFlow):
 699
 700 2006-10-30  John Sullivan  <sullivan@apple.com>
 701
 702         Reviewed by Geoff Garen.
 703
 704         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
 705         grammar-related method.
 706
 707         * bridge/EditorClient.h:
 708         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
 709         isGrammarCheckingEnabled()
 710
 711         * bridge/mac/WebCoreFrameBridge.h:
 712         removed bridge equivalents
 713
 714         * bridge/mac/FrameMac.mm:
 715         (WebCore::FrameMac::advanceToNextMisspelling):
 716         convert bridge-using code to editor()->client()-using code
 717         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
 718         ditto
 719         (WebCore::FrameMac::markMisspellings):
 720         ditto
 721         (WebCore::FrameMac::respondToChangedSelection):
 722         ditto
 723
 724         * editing/Editor.h:
 725         * editing/Editor.cpp:
 726         (WebCore::Editor::client):
 727         new method, returns EditorClient pointer. In an ideal world all the code that needed to
 728         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
 729         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
 730
 731 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
 732
 733         Reviewed by Darin.
 734
 735         Removed a number of editing and selection methods from the bridge.
 736
 737         I moved cross-platform editing and selection code into Editor and
 738         SelectionController, respecitvely.
 739
 740         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
 741         everything + the kitchen sink.
 742
 743         Specific comments below for interesting things.
 744
 745         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
 746         a new file so that WebKit can use them, too. Added a helper method for
 747         handling exceptions when selecting a Range.
 748         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into
 749         WebKit, since they have to do with creating an NSAttributedString for API
 750         consumption, and not much to do with general Frame functionality.
 751         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
 752         for now) into the Editor. Eventually, the Frame will not have to notify
 753         the Editor of what the lastEditCommand was, since the Editor will perform
 754         all EditCommands.
 755         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
 756         * editing/SelectionController.cpp:
 757         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
 758         and return them. The bridge method to select a DOM range did this implicitly,
 759         since all ObjC DOM operations handle DOM exceptions by throwing them as
 760         ObjC exceptions.
 761         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
 762         The two enumerations are numerically identical, but that's an implementation
 763         detail of TextAffinity that clients shouldn't be required to know about.
 764
 765 2006-10-30  Timothy Hatcher  <timothy@apple.com>
 766
 767         Rolling out the following change because this crash:
 768         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
 769
 770         And this regression:
 771         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
 772
 773     2006-09-06  David Harrison  <harrison@apple.com>
 774
 775         Reviewed and tweaked by Tim H.
 776
 777         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation
 778
 779         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
 780         to trigger a search that will include auto activation. No PLT or iBench perf impact.
 781         No layout tests affected. Not testable in an automated way that will work on all systems.
 782
 783         * platform/mac/WebFontCache.mm:
 784         (+[WebFontCache fontWithFamily:traits:size:]):
 785
 786 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
 787
 788         Reviewed by harrison
 789
 790         <rdar://problem/4808375>
 791         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
 792
 793         * editing/TextIterator.cpp:
 794         (WebCore::TextIterator::exitNode): Only create VisiblePositions
 795         when we're going to use them to create a range for an emitted character.
 796         We should further speed TextIterators up by avoiding creating VisiblePositions
 797         for TIs that are only used for the characters they emit (like the one that
 798         plainText uses).
 799
 800 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
 801
 802         Reviewed by Mitz.
 803
 804         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
 805         More rendering code cleaning
 806
 807         * WebCore.xcodeproj/project.pbxproj:
 808         * rendering/RenderApplet.cpp:
 809         (WebCore::RenderApplet::RenderApplet):
 810         (WebCore::RenderApplet::createWidgetIfNecessary):
 811         * rendering/RenderApplet.h:
 812         * rendering/RenderArena.cpp:
 813         (WebCore::):
 814         (WebCore::RenderArena::RenderArena):
 815         (WebCore::RenderArena::allocate):
 816         (WebCore::RenderArena::free):
 817         * rendering/RenderArena.h:
 818         * rendering/RenderBR.cpp:
 819         (WebCore::RenderBR::RenderBR):
 820         (WebCore::RenderBR::baselinePosition):
 821         (WebCore::RenderBR::lineHeight):
 822         (WebCore::RenderBR::setStyle):
 823         (WebCore::RenderBR::caretMinOffset):
 824         (WebCore::RenderBR::positionForCoordinates):
 825         (WebCore::RenderBR::inlineBox):
 826         * rendering/RenderBR.h:
 827         * rendering/RenderBlock.cpp:
 828         * rendering/RenderBlock.h:
 829         (WebCore::RenderBlock::maxTopMargin):
 830         (WebCore::RenderBlock::maxBottomMargin):
 831         (WebCore::RenderBlock::initMaxMarginValues):
 832         (WebCore::RenderBlock::containsFloats):
 833         (WebCore::RenderBlock::setHasMarkupTruncation):
 834         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
 835         (WebCore::RenderBlock::BlockSelectionInfo::block):
 836         (WebCore::RenderBlock::BlockSelectionInfo::state):
 837         (WebCore::RenderBlock::FloatingObject::FloatingObject):
 838         (WebCore::RenderBlock::CompactInfo::clear):
 839         * rendering/RenderButton.cpp:
 840         (WebCore::RenderButton::removeChild):
 841         (WebCore::RenderButton::paintObject):
 842         * rendering/RenderButton.h:
 843         (WebCore::RenderButton::renderName):
 844         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
 845         * rendering/RenderContainer.cpp:
 846         (WebCore::RenderContainer::RenderContainer):
 847         * rendering/RenderContainer.h:
 848         (WebCore::RenderContainer::firstChild):
 849         (WebCore::RenderContainer::lastChild):
 850         (WebCore::RenderContainer::calcMinMaxWidth):
 851         * rendering/RenderCounter.cpp:
 852         (WebCore::RenderCounter::RenderCounter):
 853         (WebCore::toRoman):
 854         (WebCore::toHebrew):
 855         (WebCore::RenderCounter::calcMinMaxWidth):
 856         * rendering/RenderCounter.h:
 857         * rendering/RenderFieldset.cpp:
 858         (WebCore::RenderFieldset::paintBoxDecorations):
 859         (WebCore::RenderFieldset::paintBorderMinusLegend):
 860         (WebCore::RenderFieldset::setStyle):
 861         * rendering/RenderFileUploadControl.cpp:
 862         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
 863         (WebCore::RenderFileUploadControl::setStyle):
 864         (WebCore::RenderFileUploadControl::paintObject):
 865         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
 866         * rendering/RenderFileUploadControl.h:
 867         (WebCore::RenderFileUploadControl::renderName):
 868         * rendering/RenderFlexibleBox.h:
 869         * rendering/RenderFlow.cpp:
 870         * rendering/RenderFlow.h:
 871         * rendering/RenderForeignObject.cpp:
 872         (WebCore::RenderForeignObject::RenderForeignObject):
 873         (WebCore::RenderForeignObject::paint):
 874         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
 875         (WebCore::RenderForeignObject::layout):
 876         (WebCore::RenderForeignObject::nodeAtPoint):
 877         * rendering/RenderForeignObject.h:
 878         (WebCore::RenderForeignObject::renderName):
 879         * rendering/RenderFormElement.cpp:
 880         (WebCore::RenderFormElement::setStyle):
 881         (WebCore::RenderFormElement::layout):
 882         (WebCore::RenderFormElement::textAlignment):
 883         * rendering/RenderFormElement.h:
 884         * rendering/RenderFrame.cpp:
 885         * rendering/RenderFrame.h:
 886         (WebCore::RenderFrame::element):
 887         * rendering/RenderFrameSet.cpp:
 888         * rendering/RenderFrameSet.h:
 889         (WebCore::RenderFrameSet::element):
 890         * rendering/RenderHTMLCanvas.cpp:
 891         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
 892         (WebCore::RenderHTMLCanvas::paint):
 893         * rendering/RenderHTMLCanvas.h:
 894         (WebCore::RenderHTMLCanvas::renderName):
 895         * rendering/RenderImage.cpp:
 896         (WebCore::RenderImage::RenderImage):
 897         (WebCore::RenderImage::setStyle):
 898         (WebCore::RenderImage::setContentObject):
 899         (WebCore::RenderImage::setCachedImage):
 900         (WebCore::RenderImage::imageChanged):
 901         (WebCore::RenderImage::paint):
 902         (WebCore::RenderImage::layout):
 903         (WebCore::RenderImage::updateAltText):
 904         * rendering/RenderImage.h:
 905         (WebCore::RenderImage::element):
 906         * rendering/RenderInline.cpp:
 907         (WebCore::RenderInline::RenderInline):
 908         (WebCore::RenderInline::~RenderInline):
 909         (WebCore::RenderInline::setStyle):
 910         (WebCore::RenderInline::addChildToFlow):
 911         (WebCore::RenderInline::cloneInline):
 912         (WebCore::RenderInline::splitInlines):
 913         (WebCore::RenderInline::splitFlow):
 914         (WebCore::RenderInline::paint):
 915         (WebCore::RenderInline::absoluteRects):
 916         (WebCore::RenderInline::calcMinMaxWidth):
 917         (WebCore::RenderInline::requiresLayer):
 918         (WebCore::RenderInline::width):
 919         (WebCore::RenderInline::height):
 920         (WebCore::RenderInline::renderName):
 921         (WebCore::RenderInline::nodeAtPoint):
 922         (WebCore::RenderInline::positionForCoordinates):
 923         * rendering/RenderInline.h:
 924         (WebCore::RenderInline::layout):
 925         * rendering/RenderLayer.cpp:
 926         * rendering/RenderLayer.h:
 927         (WebCore::ClipRects::ClipRects):
 928         (WebCore::RenderLayer::nextSibling):
 929         (WebCore::RenderLayer::root):
 930         (WebCore::RenderLayer::setPos):
 931         (WebCore::RenderLayer::height):
 932         (WebCore::RenderLayer::relativePositionOffset):
 933         * rendering/RenderLineEdit.cpp:
 934         (WebCore::RenderLineEdit::setStyle):
 935         (WebCore::RenderLineEdit::updateFromElement):
 936         (WebCore::RenderLineEdit::selectionStart):
 937         (WebCore::RenderLineEdit::selectionEnd):
 938         (WebCore::RenderLineEdit::setSelectionStart):
 939         (WebCore::RenderLineEdit::setSelectionEnd):
 940         (WebCore::RenderLineEdit::setSelectionRange):
 941         * rendering/RenderLineEdit.h:
 942         * rendering/RenderListBox.cpp:
 943         * rendering/RenderListBox.h:
 944         (WebCore::RenderListBox::renderName):
 945         * rendering/RenderListItem.cpp:
 946         (WebCore::RenderListItem::setStyle):
 947         (WebCore::getParentOfFirstLineBox):
 948         (WebCore::RenderListItem::updateMarkerLocation):
 949         (WebCore::RenderListItem::positionListMarker):
 950         (WebCore::RenderListItem::paint):
 951         * rendering/RenderListItem.h:
 952         * rendering/RenderListMarker.cpp:
 953         * rendering/RenderListMarker.h:
 954         (WebCore::RenderListMarker::renderName):
 955         (WebCore::RenderListMarker::isListMarker):
 956
 957 2006-10-30  Timothy Hatcher  <timothy@apple.com>
 958
 959         Reviewed by Hyatt.
 960
 961         <rdar://problem/4478625> Basic table editing and culling
 962
 963         Refined the criteria for deletable elements, rely on the renderer more.
 964         Corrected the interface positioning for elements that have borders.
 965
 966         * editing/DeleteButtonController.cpp:
 967         (WebCore::isDeletableElement):
 968         (WebCore::DeleteButtonController::show):
 969
 970 2006-10-30  Darin Adler  <darin@apple.com>
 971
 972         - fix build
 973
 974         * loader/ResourceLoader.h: Added header guard.
 975
 976 2006-10-31  Darin Adler  <darin@apple.com>
 977
 978         Reviewed by Adam.
 979
 980         - fix FrameLoader files so they can be built on non-Mac platforms
 981
 982         * page/FramePrivate.h:
 983         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
 984         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
 985
 986         * page/Page.h:
 987         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
 988         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
 989         the other day.
 990
 991         * bridge/mac/FrameMac.mm:
 992         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
 993         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
 994
 995         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
 996         around the PolicyCheck definition.
 997
 998         * loader/FormState.cpp: Changed import to include.
 999         * loader/FrameLoader.cpp: Ditto.
1000         * loader/MainResourceLoader.h: Ditto.
1001
1002         * loader/FrameLoaderTypes.h: Added a header guard.
1003
1004         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1005         Added #if PLATFORM(MAC) around Mac-specific details.
1006         * loader/SubresourceLoader.h: Ditto.
1007
1008         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1009         m_loader from m_frameLoader.
1010
1011         * CMakeLists.txt: Updated.
1012         * WebCoreSources.bkl: Updated.
1013
1014 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1015
1016         Reviewed and landed by Anders.
1017
1018         Patch by Zack rusin to fix:
1019         http://bugs.webkit.org/show_bug.cgi?id=11429
1020
1021         Fix startup crash.
1022
1023         * platform/qt/FrameQtClient.cpp:
1024         (WebCore::FrameQtClientDefault::openURL):
1025
1026 2006-10-30  Zach Rusin  <zack@kde.org>
1027
1028         Reviewed and landed by Anders.
1029
1030         * platform/network/qt/ResourceHandleQt.cpp:
1031         (WebCore::ResourceHandle::receivedResponse):
1032         * platform/qt/FrameQtClient.cpp:
1033         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1034         * platform/qt/LoaderFunctionsQt.cpp:
1035         (WebCore::ServeSynchronousRequest):
1036         More build fixes.
1037
1038 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1039
1040         Reviewed and landed by Anders.
1041
1042         - fix Qt build
1043         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1044         ResourceHandleClient
1045
1046 2006-10-30  Darin Adler  <darin@apple.com>
1047
1048         Reviewed by John Sullivan.
1049
1050         - work toward removing Objective-C data types from FrameLoader.h:
1051           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1052           and WebCoreResourceHandle
1053         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1054
1055         * page/PageState.h:
1056         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1057
1058         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1059         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1060         double for the date instead of an NSDate.
1061
1062         * bridge/mac/WebCoreFrameBridge.h:
1063         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1064         saveDocumentToPageCache methods.
1065
1066         * bridge/mac/WebCorePageState.h:
1067         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1068         an Objective-C wrapper for PageState.
1069
1070         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1071         NSDate and WebCorePageState.
1072         * loader/FrameLoaderClient.h: Changed NSDate to double.
1073         * loader/mac/FrameLoaderMac.mm:
1074         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1075         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1076         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1077         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1078         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1079         extract the parameters from the response. Changed the open function that takes
1080         a PageState to use the new C++ PageState.
1081         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1082         function; tightened up logic, removing a few cases that could never happen, as
1083         well as the unused reload boolean.
1084
1085         * ForwardingHeaders/kjs/property_map.h: Added.
1086
1087         * WebCore.exp: Updated.
1088         * WebCore.xcodeproj/project.pbxproj: Updated.
1089
1090 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1091
1092         Reviewed by Anders.
1093
1094         - added ResourceResponse class and didReceiveResponse delegate call
1095
1096         * WebCore.xcodeproj/project.pbxproj: Added new files.
1097         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1098         expiresTimeForResponse: method.
1099         * dom/XMLTokenizer.cpp:
1100         (WebCore::openFunc): Updated to use ResourceResponse.
1101         * loader/FrameLoader.h: Update loadResourceSynchronously to
1102         use ResourceResponse.
1103         * loader/LoaderFunctions.h:
1104         * loader/icon/IconLoader.cpp:
1105         (IconLoader::didReceiveResponse): Updated from receivedResponse
1106         and made cross-platform.
1107         * loader/icon/IconLoader.h: updated for above change
1108         * loader/loader.cpp:
1109         (WebCore::Loader::receivedResponse): reduced to just saving
1110         the PlatformResponse (ideally we'd phase out use of this).
1111         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse
1112         logic.
1113         * loader/loader.h:
1114         * loader/mac/FrameLoaderMac.mm:
1115         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1116         as ResourceResponse.
1117         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1118         * loader/mac/LoaderFunctionsMac.mm:
1119         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1120         argument.
1121         * platform/network/ResourceHandle.cpp:
1122         * platform/network/ResourceHandle.h: Remove calls for
1123         broken out response pieces.
1124         * platform/network/ResourceHandleClient.h:
1125         (WebCore::ResourceHandleClient::didReceiveResponse): New
1126         delegate method.
1127         * platform/network/ResourceHandleInternal.h:
1128         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1129         storage of response bits, we're not gonna return them
1130         seprately any more.
1131         * platform/network/ResourceResponse.h: Added.
1132         (WebCore::ResourceResponse::ResourceResponse): Freshly
1133         implemented. Same for below.
1134         (WebCore::ResourceResponse::url):
1135         (WebCore::ResourceResponse::mimeType):
1136         (WebCore::ResourceResponse::expectedContentLength):
1137         (WebCore::ResourceResponse::textEncodingName):
1138         (WebCore::ResourceResponse::suggestedFilename):
1139         (WebCore::ResourceResponse::httpStatusCode):
1140         (WebCore::ResourceResponse::setHTTPStatusCode):
1141         (WebCore::ResourceResponse::httpHeaderField):
1142         (WebCore::ResourceResponse::httpHeaderFields):
1143         (WebCore::ResourceResponse::isMultipart):
1144         (WebCore::ResourceResponse::setExpirationDate):
1145         (WebCore::ResourceResponse::expirationDate):
1146         * platform/network/cf/ResourceHandleCFNet.cpp:
1147         (WebCore::didReceiveResponse): Send didReceiveResponse
1148         client method.
1149         * platform/network/cf/ResourceResponseCFNet.h: Added.
1150         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1151         (getResourceResponse): Helper function to get a ResourceResponse
1152         from CFURLResponseRef.
1153         * platform/network/mac/ResourceHandleMac.mm:
1154         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1155         Don't bother cleaning up fields we no longer have.
1156         (WebCore::ResourceHandle::receivedResponse): Send
1157         didReceiveResponse client method.
1158         * platform/network/mac/ResourceResponseMac.h: Added.
1159         * platform/network/mac/ResourceResponseMac.mm: Added.
1160         (getResourceResponse): Helper function to get a ResourceResponse
1161         from an NSURLResponse*.
1162         * rendering/HitTestResult.cpp:
1163         * xml/XSLTProcessor.cpp:
1164         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1165         * xml/xmlhttprequest.cpp:
1166         (WebCore::XMLHttpRequest::getResponseText): Store http response
1167         info in the form of a ResourceResponse, change all methods to
1168         account for this.
1169         (WebCore::XMLHttpRequest::getResponseXML):
1170         (WebCore::XMLHttpRequest::XMLHttpRequest):
1171         (WebCore::XMLHttpRequest::open):
1172         (WebCore::XMLHttpRequest::send):
1173         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1174         (WebCore::XMLHttpRequest::getResponseHeader):
1175         (WebCore::XMLHttpRequest::getStatus):
1176         (WebCore::XMLHttpRequest::getStatusText):
1177         (WebCore::XMLHttpRequest::processSyncLoadResults):
1178         (WebCore::XMLHttpRequest::didFinishLoading):
1179         (WebCore::XMLHttpRequest::didReceiveResponse):
1180         (WebCore::XMLHttpRequest::didReceiveData):
1181         * xml/xmlhttprequest.h:
1182
1183 2006-10-29  Darin Adler  <darin@apple.com>
1184
1185         - fix build
1186
1187         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1188         * loader/NetscapePlugInStreamLoader.h: Ditto.
1189         * loader/ResourceLoader.h: Ditto.
1190
1191 2006-10-29  Darin Adler  <darin@apple.com>
1192
1193         - one last name change -- WebFormState.h to FormState.h
1194         - added more empty placeholder platform-independent files
1195           for currently-Mac-specific loader classes
1196
1197         * loader/FormState.cpp: Updated include.
1198         * loader/FrameLoader.cpp: Updated include.
1199         * loader/mac/FrameLoaderMac.mm: Updated include.
1200
1201         * loader/WebFormState.h: Removed.
1202         * loader/FormState.h: Added.
1203
1204         * loader/DocumentLoader.cpp: Added.
1205         * loader/MainResourceLoader.cpp: Added.
1206         * loader/NetscapePlugInStreamLoader.cpp: Added.
1207         * loader/ResourceLoader.cpp: Added.
1208         * loader/SubresourceLoader.cpp: Added.
1209
1210         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1211
1212 2006-10-29  Darin Adler  <darin@apple.com>
1213
1214         - did the do-webcore-rename renames, including a number of changes
1215           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1216           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1217           and improvements to the names of decoder classes and their source
1218           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1219
1220         * CMakeLists.txt:
1221         * WebCore.exp:
1222         * WebCore.vcproj/WebCore/WebCore.vcproj:
1223         * WebCore.xcodeproj/project.pbxproj:
1224         * WebCoreSources.bkl:
1225         * bindings/js/kjs_binding.cpp:
1226         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1227         * bindings/js/kjs_events.cpp:
1228         (KJS::JSAbstractEventListener::handleEvent):
1229         (KJS::JSLazyEventListener::parseCode):
1230         * bindings/js/kjs_html.cpp:
1231         (KJS::JSHTMLElement::implementsCall):
1232         * bindings/js/kjs_traversal.cpp:
1233         (KJS::JSNodeFilterCondition::acceptNode):
1234         * bindings/js/kjs_window.cpp:
1235         (KJS::Window::interpreter):
1236         (KJS::Window::retrieveWindow):
1237         (KJS::Window::retrieve):
1238         (KJS::ScheduledAction::execute):
1239         * bindings/objc/DOMInternal.mm:
1240         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1241         * bridge/mac/FrameMac.mm:
1242         (WebCore::FrameMac::executionContextForDOM):
1243         (WebCore::FrameMac::bindingRootObject):
1244         (WebCore::FrameMac::windowScriptObject):
1245         (WebCore::FrameMac::windowScriptNPObject):
1246         (WebCore::FrameMac::partClearedInBegin):
1247         * bridge/mac/WebCoreEncodings.mm:
1248         * bridge/mac/WebCoreFrameBridge.mm:
1249         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1250         (-[WebCoreFrameBridge stringWithData:]):
1251         (-[WebCoreFrameBridge executionContextForView:]):
1252         * bridge/win/FrameWin.cpp:
1253         * dom/Document.cpp:
1254         (WebCore::Document::inputEncoding):
1255         (WebCore::Document::setCharset):
1256         (WebCore::Document::createHTMLEventListener):
1257         (WebCore::Document::setDecoder):
1258         * dom/Document.h:
1259         (WebCore::Document::decoder):
1260         * dom/EventTargetNode.cpp:
1261         (WebCore::EventTargetNode::dispatchGenericEvent):
1262         * html/HTMLParser.cpp:
1263         (WebCore::HTMLParser::noscriptCreateErrorCheck):
1264         (WebCore::HTMLParser::canvasCreateErrorCheck):
1265         (WebCore::HTMLParser::isInline):
1266         * html/HTMLPlugInElement.cpp:
1267         (WebCore::HTMLPlugInElement::createNPObject):
1268         * html/HTMLScriptElement.cpp:
1269         (WebCore::HTMLScriptElement::evaluateScript):
1270         * html/HTMLTokenizer.cpp:
1271         (WebCore::HTMLTokenizer::parseTag):
1272         (WebCore::HTMLTokenizer::processToken):
1273         * ksvg2/misc/SVGDocumentExtensions.cpp:
1274         (WebCore::SVGDocumentExtensions::createSVGEventListener):
1275         * loader/CachedCSSStyleSheet.cpp:
1276         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1277         (WebCore::CachedCSSStyleSheet::setEncoding):
1278         * loader/CachedCSSStyleSheet.h:
1279         * loader/CachedXBLDocument.cpp:
1280         (WebCore::CachedXBLDocument::CachedXBLDocument):
1281         (WebCore::CachedXBLDocument::setEncoding):
1282         * loader/CachedXBLDocument.h:
1283         * loader/CachedXSLStyleSheet.cpp:
1284         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1285         (WebCore::CachedXSLStyleSheet::setEncoding):
1286         * loader/CachedXSLStyleSheet.h:
1287         * loader/Decoder.cpp: Removed.
1288         * loader/Decoder.h: Removed.
1289         * loader/FrameLoader.cpp:
1290         * loader/FrameLoader.h:
1291         * loader/FrameLoaderClient.h:
1292         * loader/MainResourceLoader.h: Added.
1293         * loader/NetscapePlugInStreamLoader.h: Added.
1294         * loader/Request.h:
1295         (WebCore::Request::cachedResource):
1296         * loader/ResourceLoader.h: Added.
1297         * loader/SubresourceLoader.h: Added.
1298         * loader/TextResourceDecoder.cpp: Added.
1299         (WebCore::TextResourceDecoder::determineContentType):
1300         (WebCore::TextResourceDecoder::defaultEncoding):
1301         (WebCore::TextResourceDecoder::TextResourceDecoder):
1302         (WebCore::TextResourceDecoder::~TextResourceDecoder):
1303         (WebCore::TextResourceDecoder::setEncoding):
1304         (WebCore::TextResourceDecoder::checkForBOM):
1305         (WebCore::TextResourceDecoder::checkForCSSCharset):
1306         (WebCore::TextResourceDecoder::checkForHeadCharset):
1307         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
1308         (WebCore::TextResourceDecoder::decode):
1309         (WebCore::TextResourceDecoder::flush):
1310         * loader/TextResourceDecoder.h: Added.
1311         * loader/WebDocumentLoader.h: Removed.
1312         * loader/WebLoader.h: Removed.
1313         * loader/WebMainResourceLoader.h: Removed.
1314         * loader/WebNetscapePlugInStreamLoader.h: Removed.
1315         * loader/WebSubresourceLoader.h: Removed.
1316         * loader/loader.cpp:
1317         (WebCore::Loader::servePendingRequests):
1318         (WebCore::Loader::receivedAllData):
1319         (WebCore::Loader::receivedResponse):
1320         (WebCore::Loader::didReceiveData):
1321         (WebCore::Loader::cancelRequests):
1322         (WebCore::Loader::jobForRequest):
1323         * loader/mac/DocumentLoaderMac.mm:
1324         * loader/mac/FormDataStream.m: Added.
1325         * loader/mac/FrameLoaderMac.mm:
1326         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1327         (WebCore::FrameLoader::addPlugInStreamLoader):
1328         (WebCore::FrameLoader::removePlugInStreamLoader):
1329         (WebCore::FrameLoader::addSubresourceLoader):
1330         (WebCore::FrameLoader::removeSubresourceLoader):
1331         (WebCore::FrameLoader::willSendRequest):
1332         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1333         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1334         (WebCore::FrameLoader::didReceiveResponse):
1335         (WebCore::FrameLoader::didReceiveData):
1336         (WebCore::FrameLoader::didFinishLoad):
1337         (WebCore::FrameLoader::didFailToLoad):
1338         (WebCore::FrameLoader::open):
1339         (WebCore::FrameLoader::willUseArchive):
1340         (WebCore::FrameLoader::isArchiveLoadPending):
1341         * loader/mac/ImageDocumentMac.mm:
1342         * loader/mac/LoaderFunctionsMac.mm:
1343         (WebCore::CheckCacheObjectStatus):
1344         * loader/mac/MainResourceLoaderMac.mm:
1345         (WebCore::MainResourceLoader::MainResourceLoader):
1346         (WebCore::MainResourceLoader::releaseDelegate):
1347         (WebCore::MainResourceLoader::didCancel):
1348         (WebCore::MainResourceLoader::addData):
1349         (WebCore::MainResourceLoader::willSendRequest):
1350         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1351         (WebCore::MainResourceLoader::didReceiveData):
1352         (WebCore::MainResourceLoader::didFinishLoading):
1353         (WebCore::MainResourceLoader::setDefersLoading):
1354         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1355         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1356         (WebCore::NetscapePlugInStreamLoader::releaseResources):
1357         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1358         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
1359         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1360         (WebCore::NetscapePlugInStreamLoader::didFail):
1361         (WebCore::NetscapePlugInStreamLoader::didCancel):
1362         * loader/mac/ResourceLoaderMac.mm:
1363         (WebCore::ResourceLoader::ResourceLoader):
1364         (WebCore::ResourceLoader::~ResourceLoader):
1365         (WebCore::ResourceLoader::releaseResources):
1366         (WebCore::ResourceLoader::load):
1367         (WebCore::ResourceLoader::setDefersLoading):
1368         (WebCore::ResourceLoader::frameLoader):
1369         (WebCore::ResourceLoader::addData):
1370         (WebCore::ResourceLoader::resourceData):
1371         (WebCore::ResourceLoader::clearResourceData):
1372         (WebCore::ResourceLoader::willSendRequest):
1373         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1374         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1375         (WebCore::ResourceLoader::didReceiveResponse):
1376         (WebCore::ResourceLoader::didReceiveData):
1377         (WebCore::ResourceLoader::willStopBufferingData):
1378         (WebCore::ResourceLoader::didFinishLoading):
1379         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1380         (WebCore::ResourceLoader::didFail):
1381         (WebCore::ResourceLoader::willCacheResponse):
1382         (WebCore::ResourceLoader::didCancel):
1383         (WebCore::ResourceLoader::cancel):
1384         (WebCore::ResourceLoader::setIdentifier):
1385         (WebCore::ResourceLoader::response):
1386         (WebCore::ResourceLoader::inConnectionCallback):
1387         (WebCore::ResourceLoader::cancelledError):
1388         (WebCore::ResourceLoader::receivedCredential):
1389         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1390         (WebCore::ResourceLoader::receivedCancellation):
1391         (WebCore::ResourceLoader::delegate):
1392         (WebCore::ResourceLoader::releaseDelegate):
1393         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
1394         * loader/mac/SubresourceLoaderMac.mm:
1395         (WebCore::SubresourceLoader::SubresourceLoader):
1396         (WebCore::SubresourceLoader::willSendRequest):
1397         (WebCore::SubresourceLoader::didReceiveResponse):
1398         (WebCore::SubresourceLoader::didReceiveData):
1399         (WebCore::SubresourceLoader::didFinishLoading):
1400         (WebCore::SubresourceLoader::didFail):
1401         (WebCore::SubresourceLoader::didCancel):
1402         * loader/mac/WebFormDataStream.h: Removed.
1403         * loader/mac/WebFormDataStream.m: Removed.
1404         * page/Frame.cpp:
1405         (WebCore::Frame::javaScriptEnabled):
1406         (WebCore::Frame::scriptProxy):
1407         (WebCore::Frame::executeScript):
1408         (WebCore::Frame::write):
1409         (WebCore::Frame::userGestureHint):
1410         (WebCore::Frame::saveInterpreterBuiltins):
1411         (WebCore::Frame::restoreInterpreterBuiltins):
1412         (WebCore::Frame::backslashAsCurrencySymbol):
1413         * page/Frame.h:
1414         * page/FramePrivate.h:
1415         * platform/StreamingTextDecoder.cpp: Removed.
1416         * platform/StreamingTextDecoder.h: Removed.
1417         * platform/StreamingTextDecoderICU.cpp: Removed.
1418         * platform/StreamingTextDecoderICU.h: Removed.
1419         * platform/TextCodec.cpp: Added.
1420         * platform/TextCodec.h: Added.
1421         * platform/TextCodecICU.cpp: Added.
1422         * platform/TextCodecICU.h: Added.
1423         * platform/TextCodecLatin1.h:
1424         * platform/TextCodecUTF16.h:
1425         * platform/TextDecoder.h:
1426         * platform/TextEncoding.cpp:
1427         * platform/TextEncodingRegistry.cpp:
1428         * platform/image-decoders/jpeg/jmorecfg.h:
1429         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
1430         * platform/mac/StreamingTextDecoderMac.h: Removed.
1431         * platform/mac/TextCodecMac.cpp: Added.
1432         * platform/mac/TextCodecMac.h: Added.
1433         * platform/network/ResourceHandleInternal.h:
1434         * platform/network/mac/ResourceHandleMac.mm:
1435         * platform/qt/FrameQt.cpp:
1436         (WebCore::FrameQt::bindingRootObject):
1437         * platform/qt/LoaderFunctionsQt.cpp:
1438         (WebCore::CheckCacheObjectStatus):
1439         * rendering/RenderObject.cpp:
1440         (WebCore::RenderObject::backslashAsCurrencySymbol):
1441         * xml/XSLTProcessor.cpp:
1442         (WebCore::XSLTProcessor::createDocumentFromSource):
1443         * xml/xmlhttprequest.cpp:
1444         (WebCore::XMLHttpRequest::didReceiveData):
1445         * xml/xmlhttprequest.h:
1446
1447 2006-10-29  Darin Adler  <darin@apple.com>
1448
1449         Rubber stamped by Adam (kinda).
1450
1451         - add Mac suffixes and correct filenames inside loader/mac
1452
1453         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
1454
1455         * loader/mac/FrameLoader.mm: Removed.
1456         * loader/mac/WebDocumentLoader.mm: Removed.
1457         * loader/mac/WebLoader.mm: Removed.
1458         * loader/mac/WebMainResourceLoader.mm: Removed.
1459         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
1460         * loader/mac/WebSubresourceLoader.mm: Removed.
1461
1462         * loader/mac/FrameLoaderMac.mm: Added.
1463         * loader/mac/DocumentLoaderMac.mm: Added.
1464         * loader/mac/ResourceLoaderMac.mm: Added.
1465         * loader/mac/MainResourceLoaderMac.mm: Added.
1466         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
1467         * loader/mac/SubresourceLoaderMac.mm: Removed.
1468
1469 2006-10-29  Darin Adler  <darin@apple.com>
1470
1471         Reviewed by Adam.
1472
1473         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
1474           and FrameLoader.cpp mostly ready
1475
1476         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
1477         FormState.cpp. Removed WebFormState.mm.
1478
1479         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
1480         get this header compiling on non-Mac.
1481         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
1482         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
1483
1484         * loader/FrameLoaderClient.h: Added some ifdefs.
1485         * loader/WebDocumentLoader.h: Ditto.
1486         * loader/WebLoader.h: Ditto.
1487         * loader/WebMainResourceLoader.h: Ditto.
1488
1489         * loader/mac/WebDocumentLoader.mm:
1490         (WebCore::DocumentLoader::isLoadingInAPISense):
1491         Rewrote to work without bridge, partly to remove the need for ObjC
1492         bridge type in the header, and also because we're tearing down the bridge.
1493
1494         * loader/mac/WebMainResourceLoader.mm:
1495         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
1496         m_contentLength and m_bytesReceived.
1497         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
1498         (WebCore::MainResourceLoader::didReceiveData): Ditto.
1499
1500         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
1501         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1502
1503         * loader/mac/FormState.mm: Removed.
1504         * loader/FormState.cpp: Added.
1505
1506 2006-10-29  Darin Adler  <darin@apple.com>
1507
1508         Rubber stamped by Adam.
1509
1510         - moving towards use of FrameLoader cross-platform; move the headers
1511           for the Mac loader from loader/mac into loader, in preparation for
1512           making them useful on non-Mac
1513
1514         * WebCore.xcodeproj/project.pbxproj:
1515
1516         * loader/mac/FrameLoader.h: Removed.
1517         * loader/mac/WebDocumentLoader.h: Removed.
1518         * loader/mac/WebFormState.h: Removed.
1519         * loader/mac/WebLoader.h: Removed.
1520         * loader/mac/WebMainResourceLoader.h: Removed.
1521         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
1522         * loader/mac/WebSubresourceLoader.h: Removed.
1523
1524         * loader/FrameLoader.h: Added.
1525         * loader/WebDocumentLoader.h: Added.
1526         * loader/WebFormState.h: Added.
1527         * loader/WebLoader.h: Added.
1528         * loader/WebMainResourceLoader.h: Added.
1529         * loader/WebNetscapePlugInStreamLoader.h: Added.
1530         * loader/WebSubresourceLoader.h: Added.
1531
1532 2006-10-29  Adam Roben  <aroben@apple.com>
1533
1534         Reviewed by Geoff.
1535
1536         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
1537         r17405.
1538
1539         * platform/DeprecatedString.h:
1540
1541 2006-10-29  Beth Dakin  <bdakin@apple.com>
1542
1543         Rubber stamped by Geoff.
1544
1545         This is a followup to my HitTestResult checkin. Most of the
1546         HitTestResult local variables in the code were named i or info for
1547         when the class was named NodeInfo. This patch renames all of these
1548         local variables to result.
1549
1550         * dom/Document.cpp:
1551         (WebCore::Document::prepareMouseEvent):
1552         * html/HTMLAreaElement.cpp:
1553         (WebCore::HTMLAreaElement::mapMouseEvent):
1554         * html/HTMLMapElement.cpp:
1555         (WebCore::HTMLMapElement::mapMouseEvent):
1556         * rendering/EllipsisBox.cpp:
1557         (WebCore::EllipsisBox::nodeAtPoint):
1558         * rendering/EllipsisBox.h:
1559         * rendering/InlineBox.cpp:
1560         (WebCore::InlineBox::nodeAtPoint):
1561         * rendering/InlineFlowBox.cpp:
1562         (WebCore::InlineFlowBox::nodeAtPoint):
1563         * rendering/InlineTextBox.cpp:
1564         (WebCore::InlineTextBox::nodeAtPoint):
1565         * rendering/RenderBlock.cpp:
1566         (WebCore::RenderBlock::isPointInScrollbar):
1567         (WebCore::RenderBlock::nodeAtPoint):
1568         * rendering/RenderBlock.h:
1569         * rendering/RenderBox.cpp:
1570         (WebCore::RenderBox::nodeAtPoint):
1571         * rendering/RenderBox.h:
1572         * rendering/RenderFlow.cpp:
1573         (WebCore::RenderFlow::hitTestLines):
1574         * rendering/RenderFlow.h:
1575         * rendering/RenderForeignObject.cpp:
1576         (WebCore::RenderForeignObject::nodeAtPoint):
1577         * rendering/RenderFrameSet.cpp:
1578         (WebCore::RenderFrameSet::nodeAtPoint):
1579         * rendering/RenderImage.cpp:
1580         (WebCore::RenderImage::nodeAtPoint):
1581         * rendering/RenderInline.cpp:
1582         (WebCore::RenderInline::nodeAtPoint):
1583         * rendering/RenderInline.h:
1584         * rendering/RenderLayer.cpp:
1585         (WebCore::RenderLayer::autoscroll):
1586         (WebCore::RenderLayer::hitTest):
1587         (WebCore::RenderLayer::hitTestLayer):
1588         (WebCore::RenderLayer::updateHoverActiveState):
1589         * rendering/RenderListBox.cpp:
1590         (WebCore::RenderListBox::isPointInScrollbar):
1591         * rendering/RenderObject.cpp:
1592         (WebCore::RenderObject::hitTest):
1593         (WebCore::RenderObject::setInnerNode):
1594         (WebCore::RenderObject::nodeAtPoint):
1595         * rendering/RenderObject.h:
1596         * rendering/RenderPath.cpp:
1597         (WebCore::RenderPath::nodeAtPoint):
1598         * rendering/RenderSVGImage.cpp:
1599         (WebCore::RenderSVGImage::nodeAtPoint):
1600         * rendering/RenderSVGText.cpp:
1601         (WebCore::RenderSVGText::nodeAtPoint):
1602         * rendering/RenderTableRow.cpp:
1603         (WebCore::RenderTableRow::nodeAtPoint):
1604         * rendering/RenderTableRow.h:
1605         * rendering/RenderTableSection.cpp:
1606         (WebCore::RenderTableSection::nodeAtPoint):
1607         * rendering/RenderTableSection.h:
1608         * rendering/RenderTextControl.cpp:
1609         (WebCore::RenderTextControl::nodeAtPoint):
1610         * rendering/RootInlineBox.cpp:
1611         (WebCore::RootInlineBox::nodeAtPoint):
1612         * rendering/RootInlineBox.h:
1613
1614 2006-10-29  Adam Roben  <aroben@apple.com>
1615
1616         More semi-fixes.
1617
1618         * page/Page.cpp: Forgot to wrap the actual definition of
1619         setDefersLoading() in PLATFORM(MAC).
1620         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
1621
1622 2006-10-29  Adam Roben  <aroben@apple.com>
1623
1624         Build semi-fix.
1625
1626         Move all FrameLoader-related code in Page.{cpp,h} within #if
1627         PLATFORM(MAC), since this class currently only exists on Mac.
1628
1629         * page/Page.cpp:
1630         * page/Page.h:
1631
1632 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1633
1634         build fix.
1635
1636         * platform/PlatformString.h:
1637         (WebCore::String::operator NSString*):
1638
1639 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1640
1641         Rolled out accidental commit.
1642
1643         * platform/AtomicString.h:
1644         (WebCore::AtomicString::AtomicString):
1645         (WebCore::AtomicString::operator NSString*):
1646
1647 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
1648
1649         RS by Darin.
1650
1651         Rolled out change to map NULL Strings to nil NSStrings because it caused
1652         even more AppKit crashes. Maybe we should remove the NSString * operator
1653         entirely, since its use is not straight-forward, and require callers to
1654         specify explicitly whether they tolerate NULL.
1655
1656         * platform/AtomicString.h:
1657         * platform/PlatformString.h:
1658         (WebCore::String::operator NSString*):
1659         * platform/mac/TextFieldMac.mm:
1660         (-[NSSearchFieldCell _addStringToRecentSearches:]):
1661
1662 2006-10-29  Darin Adler  <darin@apple.com>
1663
1664         Reviewed by Geoff.
1665
1666         - fixed storage leak showing up on the buildbot
1667
1668         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
1669         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
1670
1671 2006-10-29  Darin Adler  <darin@apple.com>
1672
1673         Rubber stamped by Adam.
1674
1675         - renamed WebFrameLoaderClient to match the class name inside it
1676
1677         * loader/mac/WebFrameLoaderClient.h: Removed.
1678         * loader/FrameLoaderClient.h: Moved it here.
1679
1680         * WebCore.xcodeproj/project.pbxproj: Updated project.
1681
1682         * bridge/mac/FrameMac.mm: Updated includes.
1683         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1684         * loader/mac/FrameLoader.mm: Ditto.
1685         * loader/mac/WebLoader.h: Ditto.
1686
1687 2006-10-29  Darin Adler  <darin@apple.com>
1688
1689         Reviewed by Mitz.
1690
1691         - fix crash visible on buildbot and also when running the test
1692           anchor-image-scrolled-x-y.html under libgmalloc
1693
1694         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
1695         now that the class is named ResourceHandle.
1696         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
1697         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
1698         a local RefPtr before calling finishJobAndHandle, since we might get
1699         cancelled inside that function, so we should not rely on m_handle to
1700         keep the ResourceHandle alive.
1701         (WebCore::SubresourceLoader::didFail): Ditto.
1702         (WebCore::SubresourceLoader::didCancel): Ditto.
1703
1704 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1705
1706         - build fix
1707
1708         * platform/network/mac/ResourceHandleMac.mm:
1709
1710 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1711
1712         Rubber stamped by Darin.
1713
1714         - renamed ResourceLoader to ResourceHandle (and same for related classes)
1715
1716         * CMakeLists.txt:
1717         * Projects/gdk/webcore-gdk.bkl:
1718         * WebCore.vcproj/WebCore/WebCore.vcproj:
1719         * WebCore.xcodeproj/project.pbxproj:
1720         * WebCoreSources.bkl:
1721         * bridge/mac/FrameMac.mm:
1722         * bridge/win/FrameWin.cpp:
1723         * dom/XMLTokenizer.cpp:
1724         * loader/Cache.cpp:
1725         * loader/CachedResource.h:
1726         * loader/LoaderFunctions.h:
1727         * loader/icon/IconLoader.cpp:
1728         (IconLoader::startLoading):
1729         (IconLoader::didReceiveData):
1730         (IconLoader::didFinishLoading):
1731         * loader/icon/IconLoader.h:
1732         * loader/loader.cpp:
1733         (WebCore::Loader::servePendingRequests):
1734         (WebCore::Loader::receivedAllData):
1735         (WebCore::Loader::receivedResponse):
1736         (WebCore::Loader::didReceiveData):
1737         (WebCore::Loader::cancelRequests):
1738         (WebCore::Loader::jobForRequest):
1739         * loader/loader.h:
1740         * loader/mac/IconLoaderMac.mm:
1741         (IconLoader::receivedResponse):
1742         * loader/mac/LoaderFunctionsMac.mm:
1743         * loader/mac/WebLoader.h:
1744         * loader/mac/WebSubresourceLoader.h:
1745         * loader/mac/WebSubresourceLoader.mm:
1746         (WebCore::SubresourceLoader::SubresourceLoader):
1747         (WebCore::SubresourceLoader::create):
1748         * platform/gdk/FrameGdk.cpp:
1749         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
1750         (WebCore::FrameGdkClientDefault::openURL):
1751         (WebCore::FrameGdkClientDefault::submitForm):
1752         (WebCore::FrameGdkClientDefault::receivedResponse):
1753         (WebCore::FrameGdkClientDefault::didReceiveData):
1754         (WebCore::FrameGdkClientDefault::receivedAllData):
1755         * platform/gdk/FrameGdk.h:
1756         * platform/gdk/TemporaryLinkStubs.cpp:
1757         (WebCore::ServeSynchronousRequest):
1758         (WebCore::ResourceHandle::assembleResponseHeaders):
1759         (WebCore::ResourceHandle::retrieveCharset):
1760         * platform/network/ResourceHandle.cpp: Added.
1761         (WebCore::ResourceHandle::ResourceHandle):
1762         (WebCore::ResourceHandle::create):
1763         (WebCore::ResourceHandle::isErrorPage):
1764         (WebCore::ResourceHandle::error):
1765         (WebCore::ResourceHandle::setError):
1766         (WebCore::ResourceHandle::responseEncoding):
1767         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
1768         (WebCore::ResourceHandle::kill):
1769         (WebCore::ResourceHandle::requestHeaders):
1770         (WebCore::ResourceHandle::url):
1771         (WebCore::ResourceHandle::postData):
1772         (WebCore::ResourceHandle::method):
1773         (WebCore::ResourceHandle::client):
1774         * platform/network/ResourceHandle.h: Added.
1775         (WebCore::ResourceHandle::getInternal):
1776         * platform/network/ResourceHandleClient.h: Added.
1777         (WebCore::ResourceHandleClient::~ResourceHandleClient):
1778         (WebCore::ResourceHandleClient::didReceiveData):
1779         (WebCore::ResourceHandleClient::didFinishLoading):
1780         (WebCore::ResourceHandleClient::receivedRedirect):
1781         (WebCore::ResourceHandleClient::receivedResponse):
1782         (WebCore::ResourceHandleClient::receivedAllData):
1783         * platform/network/ResourceHandleInternal.h: Added.
1784         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1785         * platform/network/ResourceLoader.cpp: Removed.
1786         * platform/network/ResourceLoader.h: Removed.
1787         * platform/network/ResourceLoaderClient.h: Removed.
1788         * platform/network/ResourceLoaderInternal.h: Removed.
1789         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
1790         (WebCore::willSendRequest):
1791         (WebCore::didReceiveResponse):
1792         (WebCore::didReceiveData):
1793         (WebCore::didFinishLoading):
1794         (WebCore::didFail):
1795         (WebCore::willCacheResponse):
1796         (WebCore::didReceiveChallenge):
1797         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1798         (WebCore::ResourceHandle::~ResourceHandle):
1799         (WebCore::ResourceHandle::start):
1800         (WebCore::ResourceHandle::cancel):
1801         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
1802         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
1803         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1804         (WebCore::ResourceHandle::~ResourceHandle):
1805         (WebCore::ResourceHandle::start):
1806         (WebCore::ResourceHandle::cancel):
1807         * platform/network/gdk/ResourceHandleManager.cpp: Added.
1808         (WebCore::ResourceHandleManager::ResourceHandleManager):
1809         (WebCore::ResourceHandleManager::get):
1810         (WebCore::ResourceHandleManager::useSimpleTransfer):
1811         (WebCore::writeCallback):
1812         (WebCore::ResourceHandleManager::downloadTimerCallback):
1813         (WebCore::ResourceHandleManager::remove):
1814         (WebCore::ResourceHandleManager::add):
1815         (WebCore::ResourceHandleManager::cancel):
1816         * platform/network/gdk/ResourceHandleManager.h: Added.
1817         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
1818         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
1819         * platform/network/gdk/ResourceLoaderManager.h: Removed.
1820         * platform/network/mac/ResourceHandleMac.mm: Added.
1821         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1822         (WebCore::ResourceHandle::~ResourceHandle):
1823         (WebCore::ResourceHandle::start):
1824         (WebCore::ResourceHandle::assembleResponseHeaders):
1825         (WebCore::ResourceHandle::retrieveResponseEncoding):
1826         (WebCore::ResourceHandle::receivedResponse):
1827         (WebCore::ResourceHandle::cancel):
1828         (WebCore::ResourceHandle::redirectedToURL):
1829         (WebCore::ResourceHandle::addData):
1830         (WebCore::ResourceHandle::finishJobAndHandle):
1831         (WebCore::ResourceHandle::reportError):
1832         * platform/network/mac/ResourceLoaderMac.mm: Removed.
1833         * platform/network/qt/ResourceHandleManager.cpp: Added.
1834         (WebCore::ResourceHandleManager::ResourceHandleManager):
1835         (WebCore::ResourceHandleManager::~ResourceHandleManager):
1836         (WebCore::ResourceHandleManager::self):
1837         (WebCore::ResourceHandleManager::slotData):
1838         (WebCore::ResourceHandleManager::slotMimetype):
1839         (WebCore::ResourceHandleManager::slotResult):
1840         (WebCore::ResourceHandleManager::remove):
1841         (WebCore::ResourceHandleManager::add):
1842         (WebCore::ResourceHandleManager::cancel):
1843         * platform/network/qt/ResourceHandleManager.h: Added.
1844         * platform/network/qt/ResourceHandleQt.cpp: Added.
1845         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1846         (WebCore::ResourceHandle::~ResourceHandle):
1847         (WebCore::ResourceHandle::start):
1848         (WebCore::ResourceHandle::cancel):
1849         (WebCore::ResourceHandle::assembleResponseHeaders):
1850         (WebCore::ResourceHandle::retrieveResponseEncoding):
1851         (WebCore::ResourceHandle::receivedResponse):
1852         (WebCore::ResourceHandle::extractCharsetFromHeaders):
1853         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
1854         * platform/network/qt/ResourceLoaderManager.h: Removed.
1855         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
1856         * platform/network/win/ResourceHandleWin.cpp: Added.
1857         (WebCore::):
1858         (WebCore::addToOutstandingJobs):
1859         (WebCore::lookupResourceHandle):
1860         (WebCore::ResourceHandleWndProc):
1861         (WebCore::initializeOffScreenResourceHandleWindow):
1862         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1863         (WebCore::ResourceHandle::~ResourceHandle):
1864         (WebCore::ResourceHandle::onHandleCreated):
1865         (WebCore::ResourceHandle::onRequestRedirected):
1866         (WebCore::ResourceHandle::onRequestComplete):
1867         (WebCore::ResourceHandle::start):
1868         (WebCore::ResourceHandle::fileLoadTimer):
1869         (WebCore::ResourceHandle::cancel):
1870         (WebCore::ResourceHandle::setHasReceivedResponse):
1871         (WebCore::ResourceHandle::hasReceivedResponse):
1872         * platform/network/win/ResourceHandleWin.h: Added.
1873         * platform/network/win/ResourceLoaderWin.cpp: Removed.
1874         * platform/network/win/ResourceLoaderWin.h: Removed.
1875         * platform/qt/FrameQt.cpp:
1876         * platform/qt/FrameQtClient.cpp:
1877         (WebCore::FrameQtClientDefault::openURL):
1878         (WebCore::FrameQtClientDefault::submitForm):
1879         (WebCore::FrameQtClientDefault::receivedResponse):
1880         (WebCore::FrameQtClientDefault::didReceiveData):
1881         (WebCore::FrameQtClientDefault::receivedAllData):
1882         * platform/qt/FrameQtClient.h:
1883         * platform/win/TemporaryLinkStubs.cpp:
1884         (WebCore::ResourceHandle::assembleResponseHeaders):
1885         (WebCore::ResourceHandle::retrieveResponseEncoding):
1886         (WebCore::ServeSynchronousRequest):
1887         * xml/XSLTProcessor.cpp:
1888         * xml/xmlhttprequest.cpp:
1889         (WebCore::XMLHttpRequest::send):
1890         (WebCore::XMLHttpRequest::didFinishLoading):
1891         (WebCore::XMLHttpRequest::receivedRedirect):
1892         (WebCore::XMLHttpRequest::didReceiveData):
1893         * xml/xmlhttprequest.h:
1894
1895 t2006-10-29  Darin Adler  <darin@apple.com>
1896
1897         Reviewed by Maciej.
1898
1899         - eliminate use of NSArray to carry form data around
1900
1901         * WebCore.exp:
1902         * WebCore.xcodeproj/project.pbxproj:
1903         * bridge/mac/FormDataMac.h: Removed.
1904         * bridge/mac/FormDataMac.mm: Removed.
1905         * bridge/mac/FrameMac.h:
1906         * bridge/mac/WebCoreFrameBridge.h:
1907         * bridge/mac/WebCoreFrameBridge.mm:
1908         * html/HTMLFormElement.cpp:
1909         (WebCore::HTMLFormElement::submit):
1910         * loader/FormData.h:
1911         (WebCore::FormData::isEmpty):
1912         * loader/mac/FrameLoader.h:
1913         * loader/mac/FrameLoader.mm:
1914         (WebCore::FrameLoader::load):
1915         (WebCore::FrameLoader::post):
1916         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
1917         (WebCore::FrameLoader::loadResourceSynchronously):
1918         * loader/mac/LoaderFunctionsMac.mm:
1919         (WebCore::ServeSynchronousRequest):
1920         * loader/mac/WebFormDataStream.h:
1921         * loader/mac/WebFormDataStream.m:
1922         (WebCore::pairRetain):
1923         (WebCore::pairRelease):
1924         (WebCore::pairEqual):
1925         (WebCore::pairHash):
1926         (WebCore::closeCurrentStream):
1927         (WebCore::scheduleWithPair):
1928         (WebCore::advanceCurrentStream):
1929         (WebCore::openNextStream):
1930         (WebCore::formCreate):
1931         (WebCore::formFinalize):
1932         (WebCore::formOpen):
1933         (WebCore::formRead):
1934         (WebCore::formCanRead):
1935         (WebCore::formClose):
1936         (WebCore::formSchedule):
1937         (WebCore::formUnschedule):
1938         (WebCore::formEventCallback):
1939         (WebCore::setHTTPBody):
1940         * loader/mac/WebSubresourceLoader.h:
1941         * loader/mac/WebSubresourceLoader.mm:
1942         (WebCore::SubresourceLoader::create):
1943         * platform/network/mac/ResourceLoaderMac.mm:
1944
1945 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1946
1947         Reviewed by Darin.
1948
1949         - create SubresourceLoader with a ResourceRequest, not broken out request bits
1950
1951         * loader/mac/WebSubresourceLoader.h:
1952         * loader/mac/WebSubresourceLoader.mm:
1953         (WebCore::SubresourceLoader::create):
1954         * platform/network/mac/ResourceLoaderMac.mm:
1955         (WebCore::ResourceLoader::start):
1956
1957 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1958
1959         Reviewed by Darin.
1960
1961         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
1962
1963         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
1964
1965         * WebCore.xcodeproj/project.pbxproj:
1966         * bridge/mac/WebCoreFrameBridge.h:
1967         * loader/mac/FrameLoader.h:
1968         * loader/mac/FrameLoader.mm:
1969         * loader/mac/LoaderFunctionsMac.mm:
1970         * loader/mac/WebLoader.h:
1971         * loader/mac/WebSubresourceLoader.h:
1972         * loader/mac/WebSubresourceLoader.mm:
1973         (WebCore::SubresourceLoader::SubresourceLoader):
1974         (WebCore::SubresourceLoader::create):
1975         (WebCore::SubresourceLoader::willSendRequest):
1976         (WebCore::SubresourceLoader::didReceiveResponse):
1977         (WebCore::SubresourceLoader::didReceiveData):
1978         (WebCore::SubresourceLoader::didFinishLoading):
1979         (WebCore::SubresourceLoader::didFail):
1980         (WebCore::SubresourceLoader::didCancel):
1981         * platform/network/ResourceLoader.h:
1982         * platform/network/ResourceLoaderInternal.h:
1983         * platform/network/mac/ResourceLoaderMac.mm:
1984         (WebCore::ResourceLoader::~ResourceLoader):
1985         (WebCore::ResourceLoader::start):
1986         (WebCore::ResourceLoader::receivedResponse):
1987         (WebCore::ResourceLoader::cancel):
1988         (WebCore::ResourceLoader::redirectedToURL):
1989         (WebCore::ResourceLoader::addData):
1990         (WebCore::ResourceLoader::finishJobAndHandle):
1991         (WebCore::ResourceLoader::reportError):
1992         * platform/network/mac/WebCoreResourceLoader.h: Removed.
1993         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
1994         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
1995
1996 2006-10-28  Darin Adler  <darin@apple.com>
1997
1998         Reviewed by Maciej.
1999
2000         - eliminated the use of Objective-C for the policy decider
2001           machinery, obviating the need for WebPolicyDecider,
2002           WebCoreFrameLoaderAsDelegate, and
2003           WebCoreMainResourceLoaderAsPolicyDelegate
2004
2005         - grouped the state related to policy decisions into a PolicyCheck
2006           class to simplify the FrameLoader logic
2007
2008         - removed six methods from the bridge, reducing FrameLoader's use of
2009           the bridge to a single method
2010
2011         - changed form state to always use HashMap instead of NSDictionary
2012
2013         - moved the defersLoading flag from WebView to WebCore::Page
2014           and changed code to consistently call it defersLoading rather
2015           than defersCallbacks
2016
2017         - updated for rename of PassRefPtr::release to releaseRef
2018         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2019         - cleaned up kjs_binding.h a bit
2020         - cleaned up FrameMac.h a bit
2021
2022         * loader/mac/WebPolicyDecider.h: Removed.
2023         * loader/mac/WebPolicyDecider.mm: Removed.
2024         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2025
2026         * WebCore.exp:
2027         * bindings/js/kjs_binding.cpp:
2028         (KJS::ScriptInterpreter::ScriptInterpreter):
2029         (KJS::ScriptInterpreter::wasRunByUserGesture):
2030         * bindings/js/kjs_binding.h:
2031         (KJS::ScriptInterpreter::setCurrentEvent):
2032         (KJS::ScriptInterpreter::setInlineCode):
2033         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2034         (KJS::ScriptInterpreter::getCurrentEvent):
2035         (KJS::cacheDOMObject):
2036         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2037         * bridge/AXObjectCache.h:
2038         * bridge/mac/BrowserExtensionMac.mm:
2039         (WebCore::BrowserExtensionMac::createNewWindow):
2040         * bridge/mac/FrameMac.h:
2041         * bridge/mac/FrameMac.mm:
2042         (WebCore::FrameMac::loadRequest):
2043         (WebCore::FrameMac::submitForm):
2044         (WebCore::FrameMac::urlSelected):
2045         (WebCore::FrameMac::userAgent):
2046         (WebCore::FrameMac::passMouseDownEventToWidget):
2047         (WebCore::FrameMac::handleMouseMoveEvent):
2048         * bridge/mac/PageMac.mm:
2049         (WebCore::Page::Page):
2050         * bridge/mac/WebCoreEditCommand.mm:
2051         * bridge/mac/WebCoreFrameBridge.h:
2052         * bridge/mac/WebCoreFrameBridge.mm:
2053         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2054         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2055         * css/CSSComputedStyleDeclaration.cpp:
2056         (WebCore::):
2057         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2058         * css/CSSPrimitiveValue.cpp:
2059         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2060         (WebCore::CSSPrimitiveValue::cleanup):
2061         (WebCore::CSSPrimitiveValue::cssText):
2062         * css/CSSPrimitiveValue.h:
2063         (WebCore::CSSPrimitiveValue::):
2064         * css/CSSValueList.cpp:
2065         (WebCore::CSSValueList::append):
2066         * css/cssparser.cpp:
2067         (WebCore::CSSParser::parseValue):
2068         * css/cssparser.h:
2069         * css/cssstyleselector.cpp:
2070         (WebCore::CSSStyleSelector::applyProperty):
2071         * dom/Document.cpp:
2072         (WebCore::Document::Document):
2073         (WebCore::Document::updateSelection):
2074         (WebCore::Document::implicitClose):
2075         (WebCore::Document::setFocusNode):
2076         * dom/Document.h:
2077         * editing/ReplaceSelectionCommand.h:
2078         * html/HTMLParser.cpp:
2079         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2080         * loader/mac/FrameLoader.h:
2081         (WebCore::PolicyCheck::request):
2082         * loader/mac/FrameLoader.mm:
2083         (WebCore::FrameLoader::~FrameLoader):
2084         (WebCore::FrameLoader::safeLoad):
2085         (WebCore::FrameLoader::load):
2086         (WebCore::FrameLoader::open):
2087         (WebCore::FrameLoader::stopLoading):
2088         (WebCore::setAllDefersLoading):
2089         (WebCore::FrameLoader::setDefersLoading):
2090         (WebCore::FrameLoader::willSendRequest):
2091         (WebCore::FrameLoader::receivedMainResourceError):
2092         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2093         (WebCore::FrameLoader::commitProvisionalLoad):
2094         (WebCore::FrameLoader::checkNavigationPolicy):
2095         (WebCore::FrameLoader::checkContentPolicy):
2096         (WebCore::FrameLoader::cancelContentPolicyCheck):
2097         (WebCore::FrameLoader::stopPolicyCheck):
2098         (WebCore::FrameLoader::checkNewWindowPolicy):
2099         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2100         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2101         (WebCore::FrameLoader::continueAfterContentPolicy):
2102         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2103         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2104         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2105         (WebCore::FrameLoader::closeDocument):
2106         (WebCore::FrameLoader::transitionToCommitted):
2107         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2108         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2109         (WebCore::FrameLoader::post):
2110         (WebCore::FrameLoader::detachFromParent):
2111         (WebCore::FrameLoader::addExtraFieldsToRequest):
2112         (WebCore::PolicyCheck::PolicyCheck):
2113         (WebCore::PolicyCheck::clear):
2114         (WebCore::PolicyCheck::set):
2115         (WebCore::PolicyCheck::call):
2116         (WebCore::PolicyCheck::dropRequest):
2117         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2118         * loader/mac/WebFormState.h:
2119         * loader/mac/WebFormState.mm:
2120         * loader/mac/WebFrameLoaderClient.h:
2121         * loader/mac/WebLoader.h:
2122         (WebCore::WebResourceLoader::defersLoading):
2123         * loader/mac/WebLoader.mm:
2124         (WebCore::WebResourceLoader::WebResourceLoader):
2125         (WebCore::WebResourceLoader::load):
2126         (WebCore::WebResourceLoader::setDefersLoading):
2127         * loader/mac/WebMainResourceLoader.h:
2128         * loader/mac/WebMainResourceLoader.mm:
2129         (WebCore::MainResourceLoader::MainResourceLoader):
2130         (WebCore::MainResourceLoader::releaseDelegate):
2131         (WebCore::MainResourceLoader::didCancel):
2132         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2133         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2134         (WebCore::MainResourceLoader::willSendRequest):
2135         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2136         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2137         (WebCore::MainResourceLoader::didReceiveResponse):
2138         (WebCore::MainResourceLoader::didReceiveData):
2139         (WebCore::MainResourceLoader::didFinishLoading):
2140         (WebCore::MainResourceLoader::didFail):
2141         (WebCore::MainResourceLoader::loadNow):
2142         (WebCore::MainResourceLoader::load):
2143         (WebCore::MainResourceLoader::setDefersLoading):
2144         * page/Frame.cpp:
2145         (WebCore::Frame::paint):
2146         * page/FrameView.cpp:
2147         (WebCore::FrameView::layout):
2148         * page/FrameView.h:
2149         * page/Page.cpp:
2150         (WebCore::Page::setDefersLoading):
2151         * page/Page.h:
2152         (WebCore::Page::defersLoading):
2153         * platform/DeprecatedString.h:
2154         * platform/DeprecatedStringList.h:
2155         * platform/FontFallbackList.h:
2156         * platform/PlatformKeyboardEvent.h:
2157         * platform/PlatformMouseEvent.h:
2158         * platform/PlatformWheelEvent.h:
2159         * platform/mac/ClipboardMac.h:
2160         * platform/mac/ClipboardMac.mm:
2161         (WebCore::ClipboardMac::setDragImage):
2162         (WebCore::ClipboardMac::dragNSImage):
2163         (WebCore::ClipboardMac::sourceOperation):
2164         (WebCore::ClipboardMac::destinationOperation):
2165         * rendering/RenderObject.cpp:
2166         (WebCore::RenderObject::setStyle):
2167         * rendering/break_lines.cpp:
2168         (WebCore::nextBreakablePosition):
2169
2170 2006-10-28  Adam Roben  <aroben@apple.com>
2171
2172         Reviewed by Maciej.
2173
2174         Fix layout tests that broke after r17399. Mitz discovered that the
2175         failures were caused by HitTestResult::m_point being uninitialized
2176         much of the time. HitTestResults are now always constructed with a
2177         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2178         point instead of being passed one explicitly.
2179
2180         * WebCore.exp: Change constructor symbol.
2181         * bridge/mac/FrameMac.mm:
2182         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2183         hitTest().
2184         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2185         * bridge/mac/WebCoreAXObject.mm:
2186         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2187         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2188         * dom/Document.cpp:
2189         (WebCore::Document::elementFromPoint): Ditto.
2190         (WebCore::Document::prepareMouseEvent): Ditto.
2191         * page/Frame.cpp:
2192         (WebCore::Frame::isPointInsideSelection): Ditto.
2193         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2194         * page/FrameView.cpp:
2195         (WebCore::FrameView::handleWheelEvent): Ditto.
2196         * rendering/HitTestResult.cpp:
2197         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2198         passed point.
2199         * rendering/HitTestResult.h: Update constructor declaration.
2200         * rendering/RenderLayer.cpp:
2201         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2202         hitTest().
2203         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2204         HitTestResult instead of being passed one.
2205         (WebCore::RenderLayer::hitTestLayer): Ditto.
2206         * rendering/RenderLayer.h: Update declarations.
2207
2208 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2209
2210         Reviewed by Anders.
2211
2212         Fix Qt/Linux build.
2213
2214         * CMakeLists.txt:
2215         * platform/qt/FrameQtClient.cpp:
2216         (WebCore::numRequests):
2217         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2218         * platform/qt/PopupMenuQt.cpp:
2219         (WebCore::PopupMenu::updateFromElement):
2220
2221 2006-10-28  David Carson  <dacarson@gmail.com>
2222
2223         Tweaked by Sam. Reviewed by Brady.
2224
2225         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2226         Initialize m_modifyBiasSet to false, as it sometimes gets
2227         used before it has been initalized.
2228
2229         * editing/SelectionController.cpp:
2230         (WebCore::SelectionController::SelectionController):
2231
2232 2006-10-28  Beth Dakin  <bdakin@apple.com>
2233
2234         Reviewed by Darin.
2235
2236         This is the WebCore half of pushing elementAtPoint and the backend
2237         of WebElementDictionary into WebCore. Most of the changes below are
2238         to accommodate one of the following:
2239
2240         -NodeInfo is now a stand-alone class called HitTestResult.
2241                 Previously it was defined in RenderObject.h, but not for
2242                 any particular reason. The WebElementDictionary
2243                 functionality that was pushed into WebCore has been pushed
2244                 specifically into the this class. In fact,
2245                 WebElementDictionary now keeps a HitTestResult as a member
2246                 varibale.
2247
2248         -The enumeration AccessPolicy is now called
2249                 ClipboardAccessPolicy and is defined in its own header. It
2250                 was previously defined in ClipboardMac.h, but is now
2251                 defined independently to avoid including ClipboardMac.h
2252                 from within FrameMac.h since FrameMac.h is now included in
2253                 WebElementDictionary.m in WebKit.
2254
2255         -Element now has a virtual target() for the sake of
2256                 NodeInfo::targetFrame()
2257
2258         * WebCore.exp: Several WebCore functions are newly called from
2259         WebKit, so they have been added here.
2260         * WebCore.xcodeproj/project.pbxproj:
2261         * bindings/objc/DOM.mm: Must include Image.h because of adjustments
2262         to ClipboardMac.
2263         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
2264         * bridge/mac/FrameMac.mm:
2265         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy
2266         and HitTestResult changes.
2267         (WebCore::FrameMac::eventMayStartDrag): Same.
2268         (WebCore::FrameMac::handleMouseMoveEvent): Same.
2269         (WebCore::FrameMac::dispatchCPPEvent): Same.
2270         (WebCore::FrameMac::mayDHTMLCut): Same.
2271         (WebCore::FrameMac::mayDHTMLCopy): Same.
2272         (WebCore::FrameMac::mayDHTMLPaste): Same.
2273         (WebCore::FrameMac::tryDHTMLCut): Same
2274         (WebCore::FrameMac::tryDHTMLCopy): Same.
2275         (WebCore::FrameMac::tryDHTMLPaste): Same.
2276         * bridge/mac/WebCoreAXObject.mm:
2277         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to
2278         HitTestResult changes.
2279         (-[WebCoreAXObject accessibilityHitTest:]): Same.
2280         * bridge/mac/WebCoreFrameBridge.h: Same.
2281         * bridge/mac/WebCoreFrameBridge.mm:
2282         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for
2283         ClipboardAccessPolicy changes.
2284         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
2285         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
2286         * dom/Document.cpp:
2287         (WebCore::Document::elementFromPoint): Adjust for HitTestResult
2288         changes.
2289         (WebCore::Document::prepareMouseEvent): Same.
2290         * dom/Element.h:
2291         (WebCore::Element::target): Now has a virtual target()
2292         * html/HTMLAnchorElement.h: Same.
2293         * html/HTMLAreaElement.cpp:
2294         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult
2295         changes.
2296         * html/HTMLAreaElement.h: Virtual target()
2297         * html/HTMLBaseElement.h:
2298         (WebCore::HTMLBaseElement::target): Same.
2299         * html/HTMLFormElement.h: Same.
2300         * html/HTMLLinkElement.h: Same.
2301         * html/HTMLMapElement.cpp:
2302         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult
2303         changes.
2304         * html/HTMLMapElement.h: Same.
2305         * page/Frame.cpp:
2306         (WebCore::Frame::isPointInsideSelection): Same.
2307         (WebCore::Frame::hitTestResultAtPoint): Same.
2308         * page/Frame.h: Same.
2309         * page/FrameView.cpp:
2310         (WebCore::FrameView::handleWheelEvent): Same.
2311         * platform/mac/ClipboardAccessPolicy.h: Added.
2312         (WebCore::):
2313         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy,
2314         include ClipboardAccessPolicy.h, and rename AccessPolicy to
2315         ClipboardAccessPolicy.
2316         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
2317         (WebCore::ClipboardMac::ClipboardMac):
2318         (WebCore::ClipboardMac::setAccessPolicy):
2319         (WebCore::ClipboardMac::clearData):
2320         (WebCore::ClipboardMac::clearAllData):
2321         (WebCore::ClipboardMac::getData):
2322         (WebCore::ClipboardMac::setData):
2323         (WebCore::ClipboardMac::types):
2324         (WebCore::ClipboardMac::setDragImage):
2325         (WebCore::ClipboardMac::setDropEffect):
2326         (WebCore::ClipboardMac::setEffectAllowed):
2327         * rendering/EllipsisBox.cpp:
2328         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult
2329         changes.
2330         * rendering/EllipsisBox.h:
2331         * rendering/HitTestResult.cpp: Added.
2332         (WebCore::HitTestResult::HitTestResult):
2333         (WebCore::HitTestResult::~HitTestResult):
2334         (WebCore::HitTestResult::operator=):
2335         (WebCore::HitTestResult::setInnerNode):
2336         (WebCore::HitTestResult::setInnerNonSharedNode):
2337         (WebCore::HitTestResult::setURLElement):
2338         (WebCore::HitTestResult::setScrollbar):
2339         (WebCore::HitTestResult::targetFrame):
2340         (WebCore::HitTestResult::boundingBox):
2341         (WebCore::HitTestResult::isSelected):
2342         (WebCore::HitTestResult::title):
2343         * rendering/HitTestResult.h: Added.
2344         (WebCore::HitTestResult::readonly):
2345         (WebCore::HitTestResult::active):
2346         (WebCore::HitTestResult::mouseMove):
2347         (WebCore::HitTestResult::innerNode):
2348         (WebCore::HitTestResult::innerNonSharedNode):
2349         (WebCore::HitTestResult::point):
2350         (WebCore::HitTestResult::URLElement):
2351         (WebCore::HitTestResult::scrollbar):
2352         (WebCore::HitTestResult::setPoint):
2353         (WebCore::HitTestResult::setReadonly):
2354         (WebCore::HitTestResult::setActive):
2355         (WebCore::HitTestResult::setMouseMove):
2356         * rendering/InlineBox.cpp:
2357         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
2358         * rendering/InlineBox.h: Same.
2359         * rendering/InlineFlowBox.cpp:
2360         (WebCore::InlineFlowBox::nodeAtPoint): Same.
2361         * rendering/InlineFlowBox.h: Same.
2362         * rendering/InlineTextBox.cpp:
2363         (WebCore::InlineTextBox::nodeAtPoint): Same.
2364         * rendering/InlineTextBox.h: Same.
2365         * rendering/RenderBlock.cpp:
2366         (WebCore::RenderBlock::isPointInScrollbar): Same.
2367         (WebCore::RenderBlock::nodeAtPoint): Same.
2368         * rendering/RenderBlock.h: Same.
2369         * rendering/RenderBox.cpp:
2370         (WebCore::RenderBox::nodeAtPoint): Same.
2371         * rendering/RenderBox.h: Same.
2372         * rendering/RenderFlow.cpp:
2373         (WebCore::RenderFlow::hitTestLines): Same.
2374         * rendering/RenderFlow.h: Same.
2375         * rendering/RenderForeignObject.cpp:
2376         (WebCore::RenderForeignObject::nodeAtPoint): Same.
2377         * rendering/RenderForeignObject.h: Same.
2378         * rendering/RenderFrameSet.cpp:
2379         (WebCore::RenderFrameSet::nodeAtPoint): Same.
2380         * rendering/RenderFrameSet.h: Same.
2381         * rendering/RenderImage.cpp:
2382         (WebCore::RenderImage::nodeAtPoint): Same.
2383         * rendering/RenderImage.h: Same.
2384         * rendering/RenderInline.cpp:
2385         (WebCore::RenderInline::nodeAtPoint): Same.
2386         * rendering/RenderInline.h: Same.
2387         * rendering/RenderLayer.cpp:
2388         (WebCore::RenderLayer::autoscroll): Same.
2389         (WebCore::RenderLayer::hitTest): Same.
2390         (WebCore::RenderLayer::hitTestLayer): Same.
2391         (WebCore::RenderLayer::updateHoverActiveState): Same.
2392         * rendering/RenderLayer.h: Same.
2393         * rendering/RenderListBox.cpp:
2394         (WebCore::RenderListBox::isPointInScrollbar): Same.
2395         * rendering/RenderListBox.h: Same.
2396         * rendering/RenderObject.cpp:
2397         (WebCore::RenderObject::hitTest): Same.
2398         (WebCore::RenderObject::setInnerNode): Same.
2399         (WebCore::RenderObject::nodeAtPoint): Same.
2400         * rendering/RenderObject.h: Remove NodeInfo class and forward
2401         declare HitTestResult.
2402         * rendering/RenderPath.cpp:
2403         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult
2404         changes.
2405         * rendering/RenderPath.h: Same.
2406         * rendering/RenderSVGImage.cpp:
2407         (WebCore::RenderSVGImage::nodeAtPoint): Same.
2408         * rendering/RenderSVGImage.h: Same
2409         * rendering/RenderSVGText.cpp:
2410         (WebCore::RenderSVGText::nodeAtPoint): Same.
2411         * rendering/RenderSVGText.h: Same.
2412         * rendering/RenderTableRow.cpp:
2413         (WebCore::RenderTableRow::nodeAtPoint): Same.
2414         * rendering/RenderTableRow.h: Same.
2415         * rendering/RenderTableSection.cpp:
2416         (WebCore::RenderTableSection::nodeAtPoint): Same.
2417         * rendering/RenderTableSection.h: Same.
2418         * rendering/RenderText.h: Same.
2419         (WebCore::RenderText::nodeAtPoint): Same.
2420         * rendering/RenderTextControl.cpp:
2421         (WebCore::RenderTextControl::nodeAtPoint): Same.
2422         * rendering/RenderTextControl.h: Same.
2423         * rendering/RootInlineBox.cpp:
2424         (WebCore::RootInlineBox::nodeAtPoint): Same.
2425         * rendering/RootInlineBox.h: Same.
2426
2427 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2428
2429         Reviewed by Anders.
2430
2431         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
2432         impact of fixing it again.
2433
2434         * bridge/mac/FrameMac.mm:
2435         (WebCore::FrameMac::clear):
2436
2437 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2438
2439         Reviewed by John & Adam.
2440
2441         - assorted speedups to fix perf regression from fixing correctness regression
2442
2443         * WebCore.exp: exported new methods.
2444         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
2445         * bridge/mac/WebCoreFrameBridge.h:
2446         * bridge/mac/WebCoreFrameBridge.mm:
2447         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
2448         * loader/CachedResource.h:
2449         * loader/mac/CachedResourceMac.mm: Added.
2450         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
2451         now cached in the CachedObject.
2452         * loader/mac/FrameLoader.h:
2453         * loader/mac/FrameLoader.mm:
2454         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
2455         the WebKit side do faster dispatch for clients that implement the fast path delegate.
2456         * loader/mac/LoaderFunctionsMac.mm:
2457         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
2458         just call loadedResourceFromMemoryCache.
2459         * loader/mac/WebFrameLoaderClient.h:
2460
2461 2006-10-27  Oliver Hunt  <oliver@apple.com>
2462
2463         Reviewed by Maciej.
2464
2465         build fix
2466
2467         * dom/Document.cpp:
2468         (WebCore::Document::referrer):
2469
2470 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2471
2472         Reviewed by Maciej.
2473
2474         Moved some WebCoreFrameBridge functions into FrameLoader.
2475
2476         I had to make FrameLoader.h capable of compiling in C++-only source files
2477         by adding some forward declarations and __OBJC__ #ifdefs.
2478
2479         * WebCore.exp:
2480         * bridge/mac/FrameMac.h:
2481         * bridge/mac/FrameMac.mm:
2482         (WebCore::FrameMac::createEmptyDocument):
2483         (WebCore::FrameMac::tokenizerProcessedData):
2484         * bridge/mac/WebCoreFrameBridge.h:
2485         * bridge/mac/WebCoreFrameBridge.mm:
2486         * dom/Document.cpp:
2487         (WebCore::Document::processHttpEquiv):
2488         (WebCore::Document::referrer):
2489         * loader/LoaderFunctions.h:
2490         * loader/mac/FrameLoader.h:
2491         * loader/mac/FrameLoader.mm:
2492         (WebCore::numRequests):
2493         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2494         (WebCore::FrameLoader::isReloading):
2495         (WebCore::FrameLoader::referrer):
2496         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2497         (WebCore::FrameLoader::startLoadingResource):
2498         * loader/mac/LoaderFunctionsMac.mm:
2499         (WebCore::CheckIfReloading):
2500         * page/Frame.h:
2501         * page/FrameTree.cpp:
2502         (WebCore::FrameTree::isDescendantOf):
2503         (WebCore::FrameTree::traverseNext):
2504         * page/FrameTree.h:
2505         * platform/network/mac/ResourceLoaderMac.mm:
2506         (WebCore::ResourceLoader::start):
2507
2508 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2509
2510         Reviewed by Darin.
2511
2512         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2513
2514         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
2515
2516         * editing/DeleteButtonController.cpp:
2517         (WebCore::isDeletableElement):
2518         (WebCore::enclosingDeletableElement):
2519         (WebCore::DeleteButtonController::respondToChangedSelection):
2520
2521 2006-10-27  John Sullivan  <sullivan@apple.com>
2522
2523         Reviewed by Kevin Decker
2524
2525         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
2526         you haven't not finished reading this.
2527
2528         * rendering/InlineTextBox.h:
2529         * rendering/InlineTextBox.cpp:
2530         (WebCore::InlineTextBox::paint):
2531         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
2532         considered also.
2533         (WebCore::InlineTextBox::paintDocumentMarkers):
2534         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
2535         markers should be painted, instead of a marker type. This avoids walking the collection of
2536         markers multiple times back to back. Now handles grammar markers.
2537
2538 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2539
2540         Reviewed by Beth.
2541
2542         Renamed Copy Files to Copy Generated Headers.
2543         Copy 4 DOM*Internal.h headers.
2544
2545         * WebCore.xcodeproj/project.pbxproj:
2546         * bindings/scripts/CodeGeneratorObjC.pm:
2547
2548 2006-10-27  John Sullivan  <sullivan@apple.com>
2549
2550         Reviewed by Anders
2551
2552         * WebCore.exp:
2553         exported symbol for FrameMac->advanceToNextSpelling()
2554
2555         * bridge/mac/WebCoreFrameBridge.h:
2556         * bridge/mac/WebCoreFrameBridge.mm:
2557         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
2558
2559 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
2560
2561         Reviewed by harrison
2562
2563         <http://bugs.webkit.org/show_bug.cgi?id=11423>
2564         REGRESSION: First newline missing from textarea's value
2565
2566         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
2567
2568         Before my change in r17223, return (an InsertLineBreak) would insert a '\n'
2569         (the line break) then a br to prevent the '\n' from collapsing, since the
2570         insertion is being done at the end of a block (the textarea's shadow div).  Then,
2571         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
2572         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed
2573         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
2574         serialize as "foobar" because when serializing RenderTextControl intentionally asks
2575         textContent to not convert brs to newlines.  It seems to think that the only brs in
2576         the shadow div will be placeholders or collapsed.
2577
2578         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
2579         to insert two '\n's when at the end of a block in white-space:pre text.  This alone
2580         would have fixed the bug, but introduced a new one, because foo, return, bar would
2581         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
2582         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to
2583         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as
2584         a br or '\n' that will collapse (become superfluous) when content is inserted just
2585         before it.
2586
2587         * editing/CompositeEditCommand.cpp:
2588         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
2589         a br or '\n' if content inserted just before it will cause it to collapse.
2590         * editing/CompositeEditCommand.h:
2591         * editing/InsertLineBreakCommand.cpp:
2592         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
2593         to prevent a collapse as was used for the line break.  Fixed comments.
2594         * editing/InsertTextCommand.cpp:
2595         (WebCore::InsertTextCommand::input): Call the renamed function.
2596
2597 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2598
2599         Reviewed by Brady.
2600
2601         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
2602         String became an empty NSString *, instead of nil. This will become important
2603         as we start using this conversion more.
2604
2605         Added work-around for AppKit crash that semantic accuracy revealed.
2606
2607         No testcase because I don't think there's a way to reflect this change
2608         in a webpage yet.
2609
2610         * platform/PlatformString.h:
2611         (WebCore::String::operator NSString*):
2612         * platform/mac/TextFieldMac.mm:
2613         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2614
2615 2006-10-27  David Harrison  <harrison@apple.com>
2616
2617         Reviewed by Maciej,
2618
2619         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
2620
2621         * bridge/mac/WebCoreAXObject.mm:
2622         (blockquoteLevel):
2623         Calculate and return the blockquote level of the element.
2624
2625         (AXAttributeStringSetBlockquoteLevel):
2626         Add, if non-zero, or clear the block quote level attribute.
2627
2628         (AXAttributedStringAppendText):
2629         Send AXAttributeStringSetBlockquoteLevel.
2630
2631 2006-10-27  Darin Adler  <darin@apple.com>
2632
2633         - fix one error in the Qt build
2634
2635         * platform/qt/GraphicsContextQt.cpp:
2636         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2637         Updated.
2638
2639 2006-10-27  Darin Adler  <darin@apple.com>
2640
2641         Reviewed by Maciej.
2642
2643         * WebCore.exp: Export more symbols needed by WebKit.
2644
2645 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2646
2647         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
2648
2649         Fixed layout test crash. Oops.
2650
2651         * loader/mac/WebDocumentLoader.mm:
2652         (WebCore::canonicalizedTitle):
2653
2654 2006-10-26  John Sullivan  <sullivan@apple.com>
2655
2656         Reviewed by Brady
2657
2658         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
2659
2660         This restores some of the nil-handling that was implicit before some of the code was converted from
2661         Objective-C to C++.
2662
2663         * bridge/mac/FrameMac.mm:
2664         (WebCore::FrameMac::loadRequest):
2665         handle nil FrameMac
2666
2667         * bridge/mac/WebCoreFrameBridge.mm:
2668         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
2669         handle nil Frame
2670
2671 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2672
2673         Reviewed by Darin, Maciej.
2674
2675         Removed many uses of NSString *.
2676         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
2677         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
2678
2679         PLT says no performance regression.
2680
2681         * WebCore.exp:
2682         * bridge/mac/WebCoreFrameBridge.mm:
2683         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2684         * loader/mac/FrameLoader.h:
2685         * loader/mac/FrameLoader.mm:
2686         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2687         (WebCore::FrameLoader::load):
2688         (WebCore::FrameLoader::canShowMIMEType):
2689         (WebCore::FrameLoader::representationExistsForURLScheme):
2690         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2691         (WebCore::FrameLoader::checkContentPolicy):
2692         (WebCore::FrameLoader::reloadAllowingStaleData):
2693         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
2694         (WebCore::FrameLoader::checkNewWindowPolicy):
2695         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2696         (WebCore::FrameLoader::transitionToCommitted):
2697         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
2698         (WebCore::FrameLoader::post):
2699         * loader/mac/WebDocumentLoader.h:
2700         * loader/mac/WebDocumentLoader.mm:
2701         (WebCore::DocumentLoader::doesProgressiveLoad):
2702         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2703         (WebCore::DocumentLoader::title):
2704         (WebCore::DocumentLoader::setOverrideEncoding):
2705         (WebCore::DocumentLoader::overrideEncoding):
2706         (WebCore::DocumentLoader::setTitle):
2707         * loader/mac/WebFrameLoaderClient.h:
2708         * loader/mac/WebMainResourceLoader.mm:
2709         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2710
2711 2006-10-26  Timothy Hatcher  <timothy@apple.com>
2712
2713         Reviewed by Adam.
2714
2715         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
2716
2717         The main table at nytimes.com has a fixed width of 874px, but the table ends
2718         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
2719         this. The other bug was a missing top and left of 0px on the container element,
2720         causing the deletion UI to sometimes be offset below the table.
2721
2722         Now check for the element's renderer at the beginning of show() and
2723         return early if it is null.
2724
2725         * editing/DeleteButtonController.cpp:
2726         (WebCore::DeleteButtonController::updateOutlineStyle):
2727         (WebCore::DeleteButtonController::show):
2728
2729 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
2730
2731         Build fix.
2732
2733         * html/CanvasRenderingContext2D.cpp:
2734         Include MathExtras.h
2735
2736 2006-10-26  John Sullivan  <sullivan@apple.com>
2737
2738         Reviewed by Anders.
2739
2740         Some changes to support new grammar checking code in WebKit.
2741
2742         * WebCore.exp:
2743         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
2744
2745         * WebCore.xcodeproj/project.pbxproj:
2746         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
2747         Made HTMLCollection.h private because Document.h uses it.
2748
2749         * bridge/mac/WebCoreFrameBridge.h:
2750         * bridge/mac/WebCoreFrameBridge.mm:
2751         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
2752
2753 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
2754
2755         Reviewed by Brady.
2756
2757         Add reverseFind to String and use it instead of findRev.
2758         Use CString instead of DeprecatedCString in one place.
2759
2760         * html/HTMLFormElement.cpp:
2761         (WebCore::HTMLFormElement::formData):
2762         * ksvg2/svg/SVGURIReference.cpp:
2763         (WebCore::SVGURIReference::getTarget):
2764         * loader/Decoder.cpp:
2765         (WebCore::Decoder::checkForCSSCharset):
2766         * platform/PlatformString.h:
2767         (WebCore::String::reverseFind):
2768         * platform/StringImpl.cpp:
2769         (WebCore::StringImpl::reverseFind):
2770         * platform/StringImpl.h:
2771
2772 2006-10-26  John Sullivan  <sullivan@apple.com>
2773
2774         Reviewed by Darin
2775
2776         More plumbing for grammar checking. Still no grammars is checked.
2777
2778         * dom/DocumentMarker.h:
2779         (WebCore::DocumentMarker::):
2780         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
2781
2782         * platform/GraphicsContext.h:
2783         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
2784         now takes a bool parameter for whether it represents bad grammar or a misspelling
2785
2786         * platform/mac/GraphicsContextMac.mm:
2787         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2788         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
2789         an existing "assert" to "ASSERT".
2790
2791         * rendering/InlineTextBox.h:
2792         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
2793
2794         * rendering/InlineTextBox.cpp:
2795         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
2796         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
2797         bad grammar or a misspelling
2798         (WebCore::InlineTextBox::paintAllMarkersOfType):
2799         now handles markers of type Grammar
2800
2801 === Safari-521.29 ===
2802
2803 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
2804
2805         Reviewed by Mitz.
2806
2807         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
2808         Cleanup rendering code
2809
2810         - Assorted code cleanup.
2811
2812         * rendering/AutoTableLayout.cpp:
2813         * rendering/AutoTableLayout.h:
2814         (WebCore::AutoTableLayout::totalPercent):
2815         * rendering/CounterListItem.h:
2816         * rendering/CounterNode.cpp:
2817         * rendering/CounterNode.h:
2818         (WebCore::CounterNode::~CounterNode):
2819         (WebCore::CounterNode::isReset):
2820         * rendering/CounterResetNode.cpp:
2821         * rendering/CounterResetNode.h:
2822         * rendering/DataRef.h:
2823         (WebCore::DataRef::DataRef):
2824         * rendering/DeprecatedRenderSelect.h:
2825         * rendering/DeprecatedSlider.cpp:
2826         * rendering/DeprecatedSlider.h:
2827         * rendering/EllipsisBox.cpp:
2828         * rendering/EllipsisBox.h:
2829         (WebCore::EllipsisBox::EllipsisBox):
2830         * rendering/FixedTableLayout.cpp:
2831         * rendering/FixedTableLayout.h:
2832         * rendering/GapRects.h:
2833         * rendering/InlineBox.cpp:
2834         * rendering/InlineBox.h:
2835         (WebCore::InlineBox::InlineBox):
2836         (WebCore::InlineBox::setConstructed):
2837         (WebCore::InlineBox::clearTruncation):
2838         (WebCore::InlineBox::markDirty):
2839         * rendering/InlineFlowBox.cpp:
2840         * rendering/InlineFlowBox.h:
2841         (WebCore::InlineFlowBox::InlineFlowBox):
2842         (WebCore::InlineFlowBox::setConstructed):
2843         (WebCore::InlineFlowBox::setEdges):
2844         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
2845         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
2846         * rendering/InlineRunBox.h:
2847         (WebCore::InlineRunBox::paintBackgroundAndBorder):
2848         (WebCore::InlineRunBox::paintDecorations):
2849         * rendering/InlineTextBox.cpp:
2850         * rendering/InlineTextBox.h:
2851         (WebCore::InlineTextBox::InlineTextBox):
2852         (WebCore::InlineTextBox::end):
2853         (WebCore::InlineTextBox::textObject):
2854         * rendering/Length.h:
2855         (WebCore::Length::Length):
2856         * rendering/ListMarkerBox.cpp:
2857         * rendering/ListMarkerBox.h:
2858         * rendering/RenderPartObject.h:
2859         * rendering/RootInlineBox.cpp:
2860         * rendering/RootInlineBox.h:
2861         * rendering/SVGInlineFlowBox.cpp:
2862         * rendering/SVGInlineFlowBox.h:
2863         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
2864         * rendering/SVGRootInlineBox.cpp:
2865         * rendering/SVGRootInlineBox.h:
2866         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
2867         * rendering/TableLayout.h:
2868         (WebCore::TableLayout::TableLayout):
2869         (WebCore::TableLayout::~TableLayout):
2870         * rendering/bidi.h:
2871         (WebCore::BidiStatus::BidiStatus):
2872         (WebCore::BidiRun::BidiRun):
2873         * rendering/break_lines.h:
2874
2875 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
2876
2877         Reviewed by john
2878
2879         <http://bugs.webkit.org/show_bug.cgi?id=11329>
2880         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
2881
2882         * editing/Editor.cpp:
2883         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
2884         Wrapped the plain text fragment in a style span with the document
2885         default style so that it will appear unstyled regardless of where
2886         it is inserted.  Could have also inserted the plain text fragment
2887         and then applied the document default style to it, but there is not
2888         yet any redundant style prevention in ApplyStyleCommand, so this
2889         is cleaner.
2890         * editing/Editor.h:
2891         * editing/JSEditor.cpp:
2892
2893 2006-10-26  Oliver Hunt  <oliver@apple.com>
2894
2895         Reviewed by Anders.
2896         Fixes <rdar://problem/4800518> -- needed to update existing
2897         canvas path elements when transforms are performed on the
2898         context.
2899
2900         * html/CanvasRenderingContext2D.cpp:
2901         (WebCore::CanvasRenderingContext2D::scale):
2902         (WebCore::CanvasRenderingContext2D::rotate):
2903         (WebCore::CanvasRenderingContext2D::translate):
2904
2905 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
2906
2907         Reviewed by Darin.
2908
2909         Fix Qt/Linux build.
2910
2911         * platform/network/qt/ResourceLoaderManager.cpp:
2912         (WebCore::ResourceLoaderManager::slotData):
2913         (WebCore::ResourceLoaderManager::slotMimetype):
2914         (WebCore::ResourceLoaderManager::remove):
2915         (WebCore::ResourceLoaderManager::add):
2916         * platform/network/qt/ResourceLoaderQt.cpp:
2917         (WebCore::ResourceLoader::receivedResponse):
2918         * platform/qt/FrameQtClient.cpp:
2919         (WebCore::FrameQtClientDefault::openURL):
2920         * platform/qt/LoaderFunctionsQt.cpp:
2921         (WebCore::ServeSynchronousRequest):
2922
2923 2006-10-26  Adam Roben  <aroben@apple.com>
2924
2925         Reviewed by Adele.
2926
2927         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
2928         boxes (<select> elements)
2929         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
2930         should have type-ahead selection without popping up menu
2931
2932         * WebCore.xcodeproj/project.pbxproj: Version wars.
2933         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
2934         find.
2935         * html/HTMLSelectElement.cpp:
2936         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
2937         instance variables.
2938         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
2939         find on printable character presses.
2940         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
2941         redundant check that the listIndex has changed (setSelectedIndex does
2942         this for us), and fix indentation.
2943         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
2944         to an else-if.
2945         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
2946         to strip leading whitespace (including non-breaking spaces) from a
2947         string.
2948         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
2949         type-ahead find.
2950         * platform/PopupMenu.h: Added new updateFromElement() method to be
2951         called from RenderMenuList::updateFromElement().
2952         * platform/mac/PopupMenuMac.mm:
2953         (WebCore::PopupMenu::updateFromElement): While we are using
2954         NSPopUpButtonCell for our popups, this method can stay empty.
2955         * rendering/RenderListBox.cpp:
2956         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
2957         selected element.
2958         * rendering/RenderMenuList.cpp:
2959         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
2960         if it's visible.
2961
2962 2006-10-26  Darin Adler  <darin@apple.com>
2963
2964         Reviewed by Anders.
2965
2966         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
2967           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
2968
2969         * editing/ReplaceSelectionCommand.cpp:
2970         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
2971         Use two vectors instead of a hash map: more efficient, deterministic. There was no
2972         reason to use a hash table.
2973
2974 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
2975
2976         Reviewed by Anders.
2977
2978         - .5% speed improvement by avoiding excess CFURLRef allocation
2979
2980         * loader/CachedResource.cpp:
2981         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
2982         here for later reuse.
2983         * loader/CachedResource.h:
2984         * loader/mac/LoaderFunctionsMac.mm:
2985         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
2986
2987 2006-10-25  Darin Adler  <darin@apple.com>
2988
2989         Reviewed by Anders.
2990
2991         - removed 55 methods from WebCoreFrameBridge
2992         - changed callers to use Frame directly instead
2993         - put FrameLoaderTypes.h types into the WebCore namespace
2994         - first steps to get FrameLoader.h ready for cross-platform duty
2995
2996         * WebCore.exp:
2997         * WebCore.xcodeproj/project.pbxproj:
2998         * bridge/mac/BrowserExtensionMac.mm:
2999         (WebCore::BrowserExtensionMac::createNewWindow):
3000         * bridge/mac/FrameMac.h:
3001         * bridge/mac/FrameMac.mm:
3002         (WebCore::FrameMac::loadRequest):
3003         (WebCore::FrameMac::startRedirectionTimer):
3004         (WebCore::FrameMac::stopRedirectionTimer):
3005         (WebCore::FrameMac::passSubframeEventToSubframe):
3006         (WebCore::FrameMac::handledOnloadEvents):
3007         (WebCore::FrameMac::isLoadTypeReload):
3008         * bridge/mac/WebCoreFrameBridge.h:
3009         * bridge/mac/WebCoreFrameBridge.mm:
3010         (-[WebCoreFrameBridge executionContextForView:]):
3011         (updateRenderingForBindings):
3012         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3013         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
3014         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3015         (-[WebCoreFrameBridge installInFrame:]):
3016         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
3017         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3018         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
3019         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3020         (stringByCollapsingNonPrintingCharacters):
3021         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3022         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3023         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3024         * loader/FrameLoaderTypes.h:
3025         * loader/mac/FrameLoader.h:
3026         * loader/mac/FrameLoader.mm:
3027         (WebCore::FrameLoader::FrameLoader):
3028         (WebCore::FrameLoader::setupForReplace):
3029         (WebCore::FrameLoader::load):
3030         (WebCore::FrameLoader::activeDocumentLoader):
3031         (WebCore::FrameLoader::state):
3032         (WebCore::FrameLoader::setState):
3033         (WebCore::FrameLoader::clearProvisionalLoad):
3034         (WebCore::FrameLoader::markLoadComplete):
3035         (WebCore::FrameLoader::commitProvisionalLoad):
3036         (WebCore::FrameLoader::receivedMainResourceError):
3037         (WebCore::FrameLoader::handleFallbackContent):
3038         (WebCore::FrameLoader::isLoadingMainFrame):
3039         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3040         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3041         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3042         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3043         (WebCore::FrameLoader::transitionToCommitted):
3044         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3045         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3046         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
3047         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
3048         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
3049         * loader/mac/ImageDocumentMac.mm:
3050         (WebCore::finishImageLoad):
3051         * loader/mac/WebDocumentLoader.mm:
3052         (WebCore::DocumentLoader::isLoadingInAPISense):
3053         * loader/mac/WebMainResourceLoader.h:
3054         * loader/mac/WebMainResourceLoader.mm:
3055         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3056         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
3057         * loader/mac/WebSubresourceLoader.mm:
3058         (-[WebCoreSubresourceHandle initWithLoader:]):
3059         * platform/mac/ListBoxMac.mm:
3060         (-[WebCoreTableView keyDown:]):
3061         (-[WebCoreTableView keyUp:]):
3062         * platform/mac/WebCoreTextField.mm:
3063         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
3064
3065 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
3066
3067         Reviewed by Darin.
3068
3069         Printing fixes
3070
3071         * page/Frame.cpp:
3072         (WebCore::Frame::adjustPageHeight):
3073         * page/Frame.h:
3074         (WebCore::Frame::setupRootForPrinting):
3075         (WebCore::Frame::computePageRects):
3076
3077 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
3078
3079         Reviewed by Geoff.
3080
3081         <rdar://problem/4799088>
3082         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
3083
3084         * loader/mac/WebSubresourceLoader.h:
3085         * loader/mac/WebSubresourceLoader.mm:
3086         (-[WebCoreSubresourceHandle initWithLoader:]):
3087         Set the HTTP method before the HTTP body.
3088
3089 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
3090
3091         Reviewed by Adam.
3092
3093         Renamed WebFrameLoader to FrameLoader, to match class name.
3094
3095         * WebCore.xcodeproj/project.pbxproj:
3096         * bridge/mac/FrameMac.mm:
3097         * bridge/mac/WebCoreFrameBridge.mm:
3098         * loader/mac/FrameLoader.mm: Added.
3099         * loader/mac/IconLoaderMac.mm:
3100         * loader/mac/WebDocumentLoader.mm:
3101         * loader/mac/WebFrameLoader.h: Removed.
3102         * loader/mac/WebFrameLoader.mm: Removed.
3103         * loader/mac/WebLoader.mm:
3104         * loader/mac/WebMainResourceLoader.mm:
3105         * loader/mac/WebNetscapePlugInStreamLoader.mm:
3106         * loader/mac/WebSubresourceLoader.mm:
3107
3108 2006-10-25  Darin Adler  <darin@apple.com>
3109
3110         - fix full builds
3111
3112         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
3113
3114 2006-10-25  David Smith  <catfish.man@gmail.com>
3115
3116         Reviewed by Mitz.
3117
3118         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
3119         http://bugs.webkit.org/show_bug.cgi?id=11411
3120
3121         * bridge/mac/WebCoreFrameBridge.mm:
3122         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
3123
3124 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3125
3126         Rubber stamped by Mitz.
3127
3128         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
3129
3130         * WebCore.xcodeproj/project.pbxproj:
3131         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
3132         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
3133         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
3134
3135 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3136
3137         Rubber stamped by Mark.
3138
3139         - remove no longer existing symbol that was breaking linking
3140
3141         * WebCore.exp:
3142
3143 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3144
3145         Reviewed by Mitz.
3146
3147         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
3148         http://bugs.webkit.org/show_bug.cgi?id=11212
3149
3150         I couldn't figure out how to write a test case.
3151
3152         * bindings/js/kjs_window.cpp:
3153         (KJS::Window::clear): Avoid crashing if already detached.
3154         * bridge/mac/FrameMac.h:
3155         * bridge/mac/FrameMac.mm:
3156         (WebCore::FrameMac::clear): Change prototype to make this a proper
3157         overload for Frame::clear once again(!).
3158
3159 2006-10-24  Darin Adler  <darin@apple.com>
3160
3161         Reviewed by Anders.
3162
3163         - converted WebFrameLoaderClient to C++
3164         - renamed frame->frameLoader() function to frame->loader()
3165         - renamed [bridge impl] to [bridge _frame]
3166         - removed some bridge methods
3167
3168         * WebCore.exp: Added more exports.
3169         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
3170         so it can be used in WebKit.
3171
3172         * bridge/mac/BrowserExtensionMac.mm:
3173         (WebCore::BrowserExtensionMac::createNewWindow):
3174         * bridge/mac/FrameMac.mm:
3175         (WebCore::FrameMac::createFrame):
3176         (WebCore::FrameMac::didFirstLayout):
3177         * bridge/mac/WebCoreAXObject.mm:
3178         (-[WebCoreAXObject rendererForView:]):
3179         * bridge/mac/WebCoreFrameBridge.h:
3180         * bridge/mac/WebCoreFrameBridge.mm:
3181         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
3182         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3183         (-[WebCoreFrameBridge setOpener:]):
3184         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3185         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3186         (-[WebCoreFrameBridge setTitle:]):
3187         (-[WebCoreFrameBridge originalRequestURL]):
3188         (-[WebCoreFrameBridge isLoadTypeReload]):
3189         (-[WebCoreFrameBridge frameDetached]):
3190         (-[WebCoreFrameBridge tokenizerProcessedData]):
3191         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3192         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3193         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3194         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
3195         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3196         (-[WebCoreFrameBridge incomingReferrer]):
3197         (-[WebCoreFrameBridge isReloading]):
3198         (-[WebCoreFrameBridge handledOnloadEvents]):
3199         (-[WebCoreFrameBridge mainResourceURLResponse]):
3200         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
3201         (-[WebCoreFrameBridge _frame]):
3202         (-[WebCoreFrameBridge executionContextForView:]):
3203         * bridge/mac/WebCorePageBridge.mm:
3204         (-[WebCorePageBridge setMainFrame:]):
3205         * dom/Position.cpp:
3206         (WebCore::Position::upstream):
3207         * loader/mac/IconLoaderMac.mm:
3208         (IconLoader::notifyIconChanged):
3209         * loader/mac/WebDocumentLoader.mm:
3210         (WebCore::DocumentLoader::frameLoader):
3211         (WebCore::DocumentLoader::stopLoading):
3212         (WebCore::DocumentLoader::finishedLoading):
3213         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3214         * loader/mac/WebFormState.mm:
3215         (WebCore::FormState::FormState):
3216         * loader/mac/WebFrameLoader.h:
3217         * loader/mac/WebFrameLoader.mm:
3218         (WebCore::FrameLoader::~FrameLoader):
3219         (WebCore::FrameLoader::prepareForLoadStart):
3220         (WebCore::FrameLoader::finalSetupForReplace):
3221         (WebCore::FrameLoader::safeLoad):
3222         (WebCore::FrameLoader::load):
3223         (WebCore::FrameLoader::startLoading):
3224         (WebCore::FrameLoader::stopLoadingSubframes):
3225         (WebCore::FrameLoader::stopLoading):
3226         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3227         (WebCore::FrameLoader::defersCallbacksChanged):
3228         (WebCore::FrameLoader::setDefersCallbacks):
3229         (WebCore::FrameLoader::setDocumentLoader):
3230         (WebCore::FrameLoader::provisionalLoadStarted):
3231         (WebCore::FrameLoader::clearProvisionalLoad):
3232         (WebCore::FrameLoader::identifierForInitialRequest):
3233         (WebCore::FrameLoader::willSendRequest):
3234         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
3235         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
3236         (WebCore::FrameLoader::didReceiveResponse):
3237         (WebCore::FrameLoader::didReceiveData):
3238         (WebCore::FrameLoader::didFinishLoad):
3239         (WebCore::FrameLoader::didFailToLoad):
3240         (WebCore::FrameLoader::privateBrowsingEnabled):
3241         (WebCore::FrameLoader::receivedMainResourceError):
3242         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
3243         (WebCore::FrameLoader::clientRedirected):
3244         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
3245         (WebCore::FrameLoader::closeOldDataSources):
3246         (WebCore::FrameLoader::opened):
3247         (WebCore::FrameLoader::commitProvisionalLoad):
3248         (WebCore::FrameLoader::download):
3249         (WebCore::FrameLoader::finishedLoading):
3250         (WebCore::FrameLoader::notifyIconChanged):
3251         (WebCore::FrameLoader::cancelledError):
3252         (WebCore::FrameLoader::fileDoesNotExistError):
3253         (WebCore::FrameLoader::willUseArchive):
3254         (WebCore::FrameLoader::isArchiveLoadPending):
3255         (WebCore::FrameLoader::handleUnimplementablePolicy):
3256         (WebCore::FrameLoader::cannotShowMIMEType):
3257         (WebCore::FrameLoader::interruptionForPolicyChangeError):
3258         (WebCore::FrameLoader::canShowMIMEType):
3259         (WebCore::FrameLoader::representationExistsForURLScheme):
3260         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3261         (WebCore::FrameLoader::checkContentPolicy):
3262         (WebCore::FrameLoader::reloadAllowingStaleData):
3263         (WebCore::FrameLoader::reload):
3264         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
3265         (WebCore::FrameLoader::finishedLoadingDocument):
3266         (WebCore::FrameLoader::committedLoad):
3267         (WebCore::FrameLoader::revertToProvisional):
3268         (WebCore::FrameLoader::setMainDocumentError):
3269         (WebCore::FrameLoader::mainReceivedCompleteError):
3270         (WebCore::FrameLoader::subframeIsLoading):
3271         (WebCore::FrameLoader::willChangeTitle):
3272         (WebCore::FrameLoader::didChangeTitle):
3273         (WebCore::FrameLoader::checkNewWindowPolicy):
3274         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3275         (WebCore::FrameLoader::checkNavigationPolicy):
3276         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3277         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3278         (WebCore::FrameLoader::didFirstLayout):
3279         (WebCore::FrameLoader::frameLoadCompleted):
3280         (WebCore::FrameLoader::transitionToCommitted):
3281         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3282         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3283         (WebCore::FrameLoader::sendRemainingDelegateMessages):
3284         (WebCore::FrameLoader::requestFromDelegate):
3285         (WebCore::FrameLoader::post):
3286         (WebCore::FrameLoader::detachChildren):
3287         (WebCore::FrameLoader::detachFromParent):
3288         (WebCore::FrameLoader::addExtraFieldsToRequest):
3289         (WebCore::FrameLoader::actionInformation):
3290         (WebCore::FrameLoader::checkLoadComplete):
3291         (WebCore::FrameLoader::setClient):
3292         (WebCore::FrameLoader::client):
3293         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3294         * loader/mac/WebFrameLoaderClient.h:
3295         * loader/mac/WebLoader.mm:
3296         (WebCore::WebResourceLoader::frameLoader):
3297         * loader/mac/WebSubresourceLoader.mm:
3298         (-[WebCoreSubresourceHandle initWithLoader:]):
3299         * page/Frame.cpp:
3300         (WebCore::Frame::loader):
3301         * page/Frame.h:
3302         * platform/mac/SliderMac.mm:
3303         (Slider::focusPolicy):
3304
3305 2006-10-24  Darin Adler  <darin@apple.com>
3306
3307         Rubber stamped by Anders.
3308
3309         - get rid of the assertion firing while running the layout tests
3310
3311         This does not fix the real problem, which is that we need to map offsets within
3312         possibly-text-transformed text in the render tree to DOM tree offsets and vice
3313         versa -- but it gets the tests running again.
3314
3315         * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
3316
3317 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3318
3319         Reviewed by Oliver.
3320
3321         - more ResourceLoader cleanup
3322             - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
3323             - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
3324
3325         * loader/LoaderFunctions.h:
3326         * loader/mac/LoaderFunctionsMac.mm:
3327         (WebCore::ServeSynchronousRequest):
3328         * loader/mac/WebSubresourceLoader.mm:
3329         (-[WebCoreSubresourceHandle initWithLoader:]):
3330         * platform/network/HTTPHeaderMap.h: Added.
3331         * platform/network/ResourceLoader.cpp:
3332         (WebCore::ResourceLoader::requestHeaders):
3333         * platform/network/ResourceLoader.h:
3334         * platform/network/ResourceRequest.h:
3335         * platform/network/cf/ResourceLoaderCFNet.cpp:
3336         (WebCore::addHeadersFromHashMap):
3337         * xml/xmlhttprequest.cpp:
3338         (WebCore::XMLHttpRequest::send):
3339         * xml/xmlhttprequest.h:
3340
3341 2006-10-24  Justin Garcia  <justin.garcia@apple.com>
3342
3343         Reviewed by darin
3344
3345         <http://bugs.webkit.org/show_bug.cgi?id=10993>
3346         GMail Editor: Caret doesn't always position itself after list marker
3347
3348         List creation uses moveParagraphs to push content into list items.
3349         moveParagraphs uses a TextIterator to restore selections after moves.
3350         Some characters emitted by the TextIterator had bad ranges associated
3351         with them.  rangeFromLocationAndLength would skip past the range it
3352         should have used when asked for ranges of length 0.
3353
3354         * editing/TextIterator.cpp:
3355         (WebCore::TextIterator::TextIterator): No longer need to initialize a
3356         removed member variable.
3357         (WebCore::TextIterator::advance): An extra newline is emitted when leaving
3358         some blocks.  Use the same range for this newline as for the first newline.
3359         We should remove this code and just emit two '\n's.
3360         (WebCore::TextIterator::handleTextNode): Setup m_range.
3361         (WebCore::TextIterator::handleTextBox): Ditto.
3362         (WebCore::TextIterator::handleReplacedElement): Ditto.
3363         (WebCore::TextIterator::handleNonTextNode): Ditto.
3364         (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
3365         in the block we're leaving to that VP after that one.
3366         (WebCore::TextIterator::emitCharacter): This function now takes in the start
3367         and the end of the range associated with the emited character, and sets up m_range.
3368         (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd),
3369         return the end of the range used to create the iterator, as a convenience to
3370         callers that use call range() on an iterator that is atEnd.
3371         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
3372         Same as the changes made to TextIterator's constructor.
3373         (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
3374         a null m_positionNode to signal that we're finished.
3375         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
3376         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
3377         made to TextIterator.
3378         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
3379         (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
3380         (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
3381         TextIterator::range.
3382         (WebCore::CharacterIterator::range): This function assumed that an iterator's
3383         range() was safe to modify.
3384         (WebCore::TextIterator::rangeFromLocationAndLength):
3385         If the range we're looking for starts in the current chunk, this function assumed
3386         that if the chunk started in a text node, it would end in the same text node.  This
3387         is no longer the case.
3388         If the range we're looking for starts in the middle of the current chunk, I assume
3389         that the chunk is inside a text node, because those are the only chunks with length
3390         greater than one at the moment.
3391         If the range we're looking for is a zero length range that starts/ends at the end of the
3392         current chunk, we used to return the start of the next chunk, but that's wrong and
3393         is what caused this bug.
3394         * editing/TextIterator.h:
3395         (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
3396         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
3397         * editing/visible_units.cpp:
3398         (WebCore::previousBoundary): Cleaned up by using a convenience function.
3399         (WebCore::nextBoundary): Ditto.
3400
3401 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3402
3403         Reviewed by Maciej.
3404
3405         * platform/network/mac/ResourceLoaderMac.mm:
3406         (WebCore::ResourceLoader::start):
3407         Don't retain the header dictionary.
3408
3409 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3410
3411         Reviewed by Anders.
3412
3413         Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
3414         REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
3415         running svg/custom/svg/custom/gradient-attr-update.svg
3416
3417         SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
3418
3419         * ksvg2/css/SVGRenderStyle.h:
3420         * ksvg2/css/SVGRenderStyleDefs.h:
3421
3422 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3423
3424         Reviewed by Mitz.
3425
3426         * platform/network/ResourceRequest.h:
3427         (WebCore::ResourceRequest::ResourceRequest):
3428         Set the http method to "GET" in the constructor that takes a String.
3429
3430 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3431
3432         Reviewed by Tim H.
3433
3434         Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
3435         and rendering/SVG* respectively.  Fix Xcode project and
3436         CMakeLists.txt to account for the moves.
3437
3438         * CMakeLists.txt:
3439         * WebCore.xcodeproj/project.pbxproj:
3440         * kcanvas/RenderForeignObject.cpp: Removed.
3441         * kcanvas/RenderForeignObject.h: Removed.
3442         * kcanvas/RenderPath.cpp: Removed.
3443         * kcanvas/RenderPath.h: Removed.
3444         * kcanvas/RenderSVGContainer.cpp: Removed.
3445         * kcanvas/RenderSVGContainer.h: Removed.
3446         * kcanvas/RenderSVGImage.cpp: Removed.
3447         * kcanvas/RenderSVGImage.h: Removed.
3448         * kcanvas/RenderSVGInline.cpp: Removed.
3449         * kcanvas/RenderSVGInline.h: Removed.
3450         * kcanvas/RenderSVGInlineText.cpp: Removed.
3451         * kcanvas/RenderSVGInlineText.h: Removed.
3452         * kcanvas/RenderSVGTSpan.cpp: Removed.
3453         * kcanvas/RenderSVGTSpan.h: Removed.
3454         * kcanvas/RenderSVGText.cpp: Removed.
3455         * kcanvas/RenderSVGText.h: Removed.
3456         * kcanvas/SVGInlineFlowBox.cpp: Removed.
3457         * kcanvas/SVGInlineFlowBox.h: Removed.
3458         * kcanvas/SVGRootInlineBox.cpp: Removed.
3459         * kcanvas/SVGRootInlineBox.h: Removed.
3460
3461 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3462
3463         Rolling back in, now fixed:
3464
3465         Nixed a few more redundant loading functions in Frame. Did my best to update
3466         the non-Mac builds.
3467
3468         * bridge/mac/FrameMac.h:
3469         * bridge/mac/FrameMac.mm:
3470         (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
3471         always 'true', because changing it broke the world, and testing seems to
3472         indicate that the one caller that might have passed 'false' didn't need to.
3473         * page/Frame.cpp:
3474         (WebCore::Frame::requestFrame):
3475         (WebCore::Frame::frameLoader):
3476         (WebCore::Frame::redirectionTimerFired):
3477         * page/Frame.h:
3478         * platform/gdk/FrameGdk.cpp:
3479         * platform/gdk/FrameGdk.h:
3480         * platform/gdk/TemporaryLinkStubs.cpp:
3481         (FrameGdk::issueCopyCommand):
3482         * platform/qt/FrameQt.cpp:
3483         * platform/qt/FrameQt.h:
3484         * platform/win/TemporaryLinkStubs.cpp:
3485         (WebCore::FrameWin::shouldInterruptJavaScript):
3486         (WebCore::FrameWin::issueCopyCommand):
3487
3488 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3489
3490         Fix the build (Update for changes to ResourceLoader)
3491
3492         * platform/network/cf/ResourceLoaderCFNet.cpp:
3493         (WebCore::addHeadersFromHashMap):
3494         (WebCore::ResourceLoader::start):
3495         (WebCore::ResourceLoader::cancel):
3496
3497 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3498
3499         Reviewed by Mitz.
3500
3501         Change #includes using <kcanvas/*.h> to use "*.h" instead
3502         to prepare for moving the kcanvas files.
3503
3504         * kcanvas/RenderSVGContainer.h:
3505         * ksvg2/svg/SVGAElement.cpp:
3506         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3507         * ksvg2/svg/SVGFETileElement.cpp:
3508         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3509         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3510
3511 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3512
3513         Reviewed by Darin.
3514
3515         - More movement towards the final network API.
3516
3517         Changed ResourceLoader::create to take a ResurceRequest and start
3518         the load. Removed methods relating to setting request
3519         headers. Removed methods relating to metaData. Added some more
3520         convenience methods to ResourceRequest.
3521
3522         * dom/XMLTokenizer.cpp:
3523         (WebCore::openFunc):
3524         * loader/LoaderFunctions.h:
3525         * loader/icon/IconLoader.cpp:
3526         (IconLoader::startLoading):
3527         (IconLoader::didFinishLoading):
3528         * loader/icon/IconLoader.h:
3529         * loader/loader.cpp:
3530         (WebCore::Loader::servePendingRequests):
3531         * loader/mac/LoaderFunctionsMac.mm:
3532         (WebCore::ServeSynchronousRequest):
3533         * platform/gdk/FrameGdk.cpp: