Do not register Chromium's HTML5 DB VFS as the default
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Do not register Chromium's HTML5 DB VFS as the default
6         VFS. Otherwise, other sqlite DB users in the same process will
7         stop working.
8
9         https://bugs.webkit.org/show_bug.cgi?id=31462
10
11         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
12         (WebCore::SQLiteFileSystem::openDatabase):
13         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
14         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
15         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
16         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
17
18 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
19
20         Windows build fix
21
22         * platform/network/cf/SocketStreamHandleCFNet.cpp:
23         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
24         avoiding a sign mismatch warning.
25
26 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
27
28         Release build fix.
29
30         * platform/network/cf/SocketStreamHandleCFNet.cpp:
31         (WebCore::SocketStreamHandle::readStreamCallback):
32         (WebCore::SocketStreamHandle::writeStreamCallback):
33         Use ASSERT_UNUSED for unused stream parameter.
34
35 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
36
37         Reviewed by Darin Adler.
38
39         https://bugs.webkit.org/show_bug.cgi?id=31441
40         Implement SocketStreamHandleCFNet
41
42         Existing WebSocket tests now pass on Mac. No proxy support yet.
43
44         * platform/network/SocketStreamHandleClient.h:
45         * platform/network/cf/SocketStreamHandle.h:
46         (WebCore::SocketStreamHandle::shouldUseSSL):
47         (WebCore::SocketStreamHandle::refAuthenticationClient):
48         (WebCore::SocketStreamHandle::derefAuthenticationClient):
49         (WebCore::SocketStreamHandle::):
50         * platform/network/cf/SocketStreamHandleCFNet.cpp:
51         (WebCore::SocketStreamHandle::SocketStreamHandle):
52         (WebCore::SocketStreamHandle::chooseProxy):
53         (WebCore::SocketStreamHandle::createStreams):
54         (WebCore::SocketStreamHandle::copyCFStreamDescription):
55         (WebCore::SocketStreamHandle::readStreamCallback):
56         (WebCore::SocketStreamHandle::writeStreamCallback):
57         (WebCore::SocketStreamHandle::~SocketStreamHandle):
58         (WebCore::SocketStreamHandle::platformSend):
59         (WebCore::SocketStreamHandle::platformClose):
60         (WebCore::SocketStreamHandle::receivedCredential):
61         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
62         (WebCore::SocketStreamHandle::receivedCancellation):
63
64 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
65
66         Reviewed by Timothy Hatcher.
67
68         Web Inspector: preload status bar button glyphs
69         in order to prevent them from flickering (take 2).
70
71         https://bugs.webkit.org/show_bug.cgi?id=31439
72
73         * inspector/front-end/inspector.js:
74         (preloadImages):
75
76 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
77
78         Reviewed by Adam Barth.
79
80         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
81         Rolling back r50890.
82
83         https://bugs.webkit.org/show_bug.cgi?id=31467
84
85         * bindings/v8/V8Proxy.cpp:
86         (WebCore::V8Proxy::canAccessPrivate):
87
88 2009-11-13  Dirk Schulze  <krit@webkit.org>
89
90         Reviewed by Gustavo Noronha.
91
92         [CAIRO] shadow support for Canvas and SVG
93         [https://bugs.webkit.org/show_bug.cgi?id=30960]
94         
95         This is the fix of a regression, caused by the shadow patch
96         from the bug above. Reinserted the save and restore calls
97         that were accidently removed by the previous patch.
98
99         * platform/graphics/cairo/GraphicsContextCairo.cpp:
100         (WebCore::setPlatformFill):
101         (WebCore::setPlatformStroke):
102
103 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
104
105         Not reviewed. Reverting r50908 since it makes inspector tests
106         time out.
107
108         https://bugs.webkit.org/show_bug.cgi?id=31439
109
110         * inspector/front-end/inspector.js:
111
112 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
113
114         Reviewed by Timothy Hatcher.
115
116         Enable 'console.profile()' and 'console.profileEnd()'
117         regardless of JAVASCRIPT_DEBUGGER.
118
119         https://bugs.webkit.org/show_bug.cgi?id=31293
120
121         * WebCore.gypi:
122         * bindings/js/JSConsoleCustom.cpp:
123         (WebCore::JSConsole::profile):
124         (WebCore::JSConsole::profileEnd):
125         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
126         (WebCore::CALLBACK_FUNC_DECL):
127         * bindings/v8/custom/V8CustomBinding.h:
128         * page/Console.idl:
129
130 2009-11-12  David Levin  <levin@chromium.org>
131
132         Reviewed by NOBODY.
133
134         Chromium build fix.
135
136         * bindings/v8/ScriptController.h:
137         (WebCore::ScriptController::evaluateInWorld): Add a dummy
138          method which isn't called in chromium to make things compile.
139
140 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
141
142         Reviewed by Adam Barth.
143         
144         The document-open.html test was flaky at times. The test invokes the layout test plugin
145         which in its destroy stream handler opens a new document. This basically tears down the
146         stream and the associated plugin instance, which causes a crash when the plugin stream
147         dereferences an invalid m_client pointer which points to the PluginView instance which
148         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
149         and check for the same.
150        
151         https://bugs.webkit.org/show_bug.cgi?id=31067
152
153         * plugins/PluginStream.cpp:
154         (WebCore::PluginStream::stop):
155         (WebCore::PluginStream::destroyStream):
156
157 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
158
159         Reviewed by Dimitri Glazkov.
160
161         Renaming some parameters passed to DB-related methods to better
162         indicate their purpose.
163
164         https://bugs.webkit.org/show_bug.cgi?id=31449
165
166         * platform/chromium/ChromiumBridge.h:
167
168 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
169
170         Reviewed by Dan Bernstein.
171
172         Transformed reflected elements are clipped inside element with opacity
173         https://bugs.webkit.org/show_bug.cgi?id=30957
174         
175         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
176         each clip rect into painting space before taking the unions. This, however, did not work
177         correctly with combinations of reflections and transforms. Fixed by unioning the
178         clipRect and mapping through transforms along the way.
179         
180         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
181         where the transparency layers are.
182
183         Test: fast/reflections/opacity-reflection-transform.html
184
185         * rendering/RenderLayer.cpp:
186         (WebCore::expandClipRectForDescendantsAndReflection):
187         (WebCore::transparencyClipBox):
188         (WebCore::RenderLayer::beginTransparencyLayers):
189
190 2009-11-12  Adam Barth  <abarth@webkit.org>
191
192         Reviewed by Darin Fisher.
193
194         Improve SecurityOrigin::toString comment
195         https://bugs.webkit.org/show_bug.cgi?id=31041
196
197         * page/SecurityOrigin.h:
198
199 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
200
201         Reviewed by Darin Adler.
202
203         externalRepresentation should take Frame as the argument
204         https://bugs.webkit.org/show_bug.cgi?id=31393
205
206         No new tests as this is just a refactoring.
207
208         * WebCore.base.exp:
209         * rendering/RenderTreeAsText.cpp:
210         (WebCore::externalRepresentation):
211         * rendering/RenderTreeAsText.h:
212
213 2009-11-12  Ben Murdoch  <benm@google.com>
214
215         Reviewed by Dimitri Glazkov.
216
217         [Android] The Android specific files in page/Android are out of date.
218         https://bugs.webkit.org/show_bug.cgi?id=31437
219
220         No tests required.
221
222         * page/android/DragControllerAndroid.cpp:
223         (WebCore::DragController::dragOperation): Added.
224         (WebCore::DragController::cleanupAfterSystemDrag):
225         * page/android/EventHandlerAndroid.cpp:
226         (WebCore::EventHandler::accessKeyModifiers): Added.
227         * page/android/InspectorControllerAndroid.cpp: Removed.
228
229 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
230
231         Reviewed by Simon Fraser.
232
233         [CAIRO] shadow support for Canvas and SVG.
234         [https://bugs.webkit.org/show_bug.cgi?id=30960]
235
236         Implement Canvas/SVG shadow support for Cairo.  This patch
237         uses the filter code from SVG Filters.  That means that it is
238         necessary to activate filters to see the shadows.
239
240         Test: fast/canvas/canvas-shadow.html
241
242         * GNUmakefile.am:
243         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
244         * platform/graphics/GraphicsContext.h:
245         * platform/graphics/cairo/GraphicsContextCairo.cpp:
246         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
247         (WebCore::setPlatformFill):
248         (WebCore::setPlatformStroke):
249         (WebCore::copyContextProperties):
250         (WebCore::drawPathShadow):
251         (WebCore::GraphicsContext::fillPath):
252         (WebCore::GraphicsContext::strokePath):
253         (WebCore::GraphicsContext::drawPath):
254         (WebCore::GraphicsContext::setPlatformShadow):
255         (WebCore::GraphicsContext::createPlatformShadow):
256         * platform/graphics/cairo/ImageCairo.cpp:
257         (WebCore::BitmapImage::draw): Add filter effect.
258         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
259         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
260         * platform/graphics/filters/ImageBufferFilter.h: Added.
261         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
262         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
263
264 2009-11-12  Dmitry Titov  <dimich@chromium.org>
265
266         Reviewed by Alexey Proskuryakov.
267
268         Add postTaskToMainThread to ScriptExecutionContext.
269         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
270         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
271         contexts that live on the main thread.
272         https://bugs.webkit.org/show_bug.cgi?id=31427
273
274         No new tests - simply moving the code.
275
276         * dom/Document.cpp:
277         (WebCore::Document::postTask):
278         * dom/ScriptExecutionContext.cpp:
279         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
280         (WebCore::ScriptExecutionContextTaskTimer::fired):
281         (WebCore::PerformTaskData::PerformTaskData):
282         (WebCore::PerformTaskData::performTask):
283         (WebCore::ScriptExecutionContext::postTaskToMainThread):
284         * dom/ScriptExecutionContext.h:
285
286 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
287
288         Reviewed by Darin Adler.
289
290         Fix crash when removing compositing layers when GC is enabled
291         https://bugs.webkit.org/show_bug.cgi?id=31429
292
293         Workaround <rdar://problem/7390716> by special-casing the removal
294         of all sublayers when GC is enabled.
295
296         * platform/graphics/mac/GraphicsLayerCA.mm:
297         (WebCore::safeSetSublayers):
298         (WebCore::GraphicsLayerCA::updateSublayerList):
299         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
300
301 2009-11-12  Jens Alfke  <snej@chromium.org>
302
303         Reviewed by Dimitri Glazkov.
304
305         The last of the V8 binding optimizations.
306         - Replace string-valued element accessors with a shared getter/setter function.
307         - Change error handling flow of control to avoid extra branches and function calls.
308         https://bugs.webkit.org/show_bug.cgi?id=31443
309         
310         * bindings/scripts/CodeGeneratorV8.pm:
311         * bindings/v8/V8Binding.cpp:
312         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
313         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
314         * bindings/v8/V8Binding.h:
315
316 2009-11-12  Sam Weinig  <sam@webkit.org>
317
318         Reviewed by Oliver Hunt.
319
320         Fix for <rdar://problem/7267951>
321         Canvas methods should reject uses of NaN and Infinity.
322
323         Test: fast/canvas/canvas-with-illegal-args.html
324
325         * html/canvas/CanvasRenderingContext2D.cpp:
326         (WebCore::CanvasRenderingContext2D::scale):
327         (WebCore::CanvasRenderingContext2D::rotate):
328         (WebCore::CanvasRenderingContext2D::translate):
329         (WebCore::CanvasRenderingContext2D::transform):
330         (WebCore::CanvasRenderingContext2D::setTransform):
331
332 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
333
334         Reviewed by Timothy Hatcher.
335
336         Web Inspector: profile timeline panel, fix obvious problems.
337
338         https://bugs.webkit.org/show_bug.cgi?id=31432
339
340         * inspector/front-end/AbstractTimelinePanel.js:
341         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
342         * inspector/front-end/TimelinePanel.js:
343         (WebInspector.TimelinePanel.prototype._setWindowPosition):
344         (WebInspector.TimelineCalculator):
345         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
346         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
347         (WebInspector.TimelineCalculator.prototype.reset):
348         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
349         (WebInspector.TimelineCalculator.prototype.formatValue):
350         (WebInspector.TimelineGraph):
351         (WebInspector.TimelineGraph.prototype.refresh):
352         * inspector/front-end/utilities.js:
353         (Element.prototype.hasStyleClass):
354
355 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
356
357         Reviewed by Timothy Hatcher.
358
359         Web Inspector: preload status bar button glyphs
360         in order to prevent them from flickering.
361
362         https://bugs.webkit.org/show_bug.cgi?id=31439
363
364         * inspector/front-end/inspector.js:
365         (preloadImages):
366
367 2009-11-12  Adam Roben  <aroben@apple.com>
368
369         Replace worldIDs with world objects
370
371         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
372         user scripts/stylesheets and isolated worlds
373
374         Reviewed by Sam Weinig.
375
376         Covered by existing tests.
377
378         * WebCore.base.exp: Update exported symbols to match what now exists
379         and is needed by WebKit.
380
381         * bindings/js/ScheduledAction.cpp:
382         (WebCore::ScheduledAction::execute): Updated for function rename.
383
384         * bindings/js/ScriptController.cpp: Removed code that dealt with
385         worldIDs.
386         (WebCore::ScriptController::createWorld): Added. Returns a new world
387         suitable for use on the main thread.
388         (WebCore::ScriptController::executeScriptInWorld): Renamed from
389         executeScriptInIsolatedWorld, since this works just fine with a
390         "normal" world.
391
392         * bindings/js/ScriptController.h: Added createWorld, removed functions
393         that took worldIDs, renamed executeScriptInIsolatedWorld to
394         executeScriptInWorld.
395
396         * page/Frame.cpp:
397         (WebCore::Frame::injectUserScripts):
398         (WebCore::Frame::injectUserScriptsForWorld):
399         Updated for changes to UserScriptMap and ScriptController.
400
401         * page/Frame.h: Changed injectUserScriptsForWorld to take a
402         DOMWrapperWorld* instead of a worldID.
403
404         * page/PageGroup.cpp:
405         (WebCore::PageGroup::addUserScriptToWorld):
406         (WebCore::PageGroup::addUserStyleSheetToWorld):
407         (WebCore::PageGroup::removeUserScriptFromWorld):
408         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
409         (WebCore::PageGroup::removeUserScriptsFromWorld):
410         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
411         * page/PageGroup.h:
412         Changed these functions to take a DOMWrapperWorld* instead of a
413         worldID. Also updated for changes to UserScript and UserStyleSheet.
414
415         * page/UserScript.h:
416         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
417         never used.
418
419         * page/UserScriptTypes.h:
420         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
421         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
422         worldID as their key type.
423
424
425 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
426
427         Reviewed by Tim Hatcher.
428
429         Fixes <http://webkit.org/b/31260>.
430         Web Inspector: Main Resources Other than HTML are mis-detected.
431         
432         Even if the resource is a main resource, look at its CachedResource type, 
433         because it might be an image, stylesheet, or JavaScript file, and we
434         want to show them all correctly.
435
436         * inspector/InspectorResource.cpp:
437         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
438         (WebCore::InspectorResource::type): 
439         * inspector/InspectorResource.h:
440
441 2009-11-12  Jens Alfke  <snej@chromium.org>
442
443         Reviewed by Dimitri Glazkov.
444
445         Table-driven setup for V8 binding template callback functions. 100k in code savings.
446         https://bugs.webkit.org/show_bug.cgi?id=31420
447
448         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
449             to call configureTemplate().
450         * bindings/v8/V8Binding.cpp:
451         (WebCore::configureTemplate):  New function; does all the standard configuration work.
452         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
453         * bindings/v8/V8Binding.h:
454         * bindings/v8/V8Proxy.cpp:
455         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
456         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
457         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
458         * bindings/v8/V8Proxy.h:
459
460 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
461
462         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
463
464         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
465
466 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
467
468         Reviewed by Dan Bernstein.
469
470         <rdar://problem/7388969> Add DOM API for fullscreen video
471         
472         DOM API for fullscreen <video>.
473
474         Tests: media/media-fullscreen-inline.html
475                media/media-fullscreen-not-in-document.html
476
477         * dom/EventNames.h:
478             Add webkitbeginfullscreen and webkitendfullscreen.
479
480         * html/HTMLAttributeNames.in:
481             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
482
483         * html/HTMLMediaElement.cpp:
484         (WebCore::HTMLMediaElement::parseMappedAttribute):
485             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
486         (WebCore::HTMLMediaElement::enterFullscreen):
487             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
488             actually do enter fullscreen.
489         (WebCore::HTMLMediaElement::exitFullscreen):
490             Schedule webkitendfullscreenEvent event.
491         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
492         (WebCore::HTMLMediaElement::webkitExitFullScreen):
493         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
494         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
495             New, access to fullscreen properties and methods.
496
497         * html/HTMLMediaElement.h:
498         * html/HTMLMediaElement.idl:
499             Declare methods needed for fullscreen API.
500
501         * html/HTMLVideoElement.cpp:
502         (WebCore::HTMLVideoElement::supportsFullscreen):
503             Return false if a movie does not have video.
504
505         * page/DOMWindow.h:
506             Add webkitbeginfullscreen and webkitendfullscreen.
507
508 2009-11-12  Adam Barth  <abarth@webkit.org>
509
510         Reviewed by Dimitri Glazkov.
511
512         [Chromium] Sify compose button alerts error
513         https://bugs.webkit.org/show_bug.cgi?id=31394
514
515         Test: http/tests/security/calling-versus-current.html
516
517         We're supposed to use the calling context for security checks.  In JSC
518         land, this is the lexicalGlobalObject.
519
520         * bindings/v8/V8Proxy.cpp:
521         (WebCore::V8Proxy::canAccessPrivate):
522
523 2009-11-12  Daniel Bates  <dbates@webkit.org>
524
525         Reviewed by Darin Adler.
526
527         https://bugs.webkit.org/show_bug.cgi?id=30291
528
529         Fixes an issue where the returned drop effect is incorrect when
530         effectAllowed == "uninitialized".
531
532         According to section 7.9.2 of the HTML 5 spec.
533         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
534         when effectAllowed = "uninitialized" the resulting dropEffect should be the
535         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
536         other case.
537         
538         No test cases are included because we have an existing test case from
539         bug #24731.
540
541         * dom/Clipboard.cpp:
542         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
543
544 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
545
546         Reviewed by Timothy Hatcher.
547
548         Web Inspector: Do not highlight node on refresh.
549
550         https://bugs.webkit.org/show_bug.cgi?id=31419
551
552         * inspector/front-end/ElementsPanel.js:
553         (WebInspector.ElementsPanel.prototype.reset):
554
555 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
556
557         Reviewed by Timothy Hatcher.
558
559         Web Inspector: Minor timeline fixes.
560
561         https://bugs.webkit.org/show_bug.cgi?id=31417
562
563         * inspector/front-end/TimelinePanel.js:
564         (WebInspector.TimelinePanel.prototype._getRecordDetails):
565         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
566         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
567         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
568
569 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
570
571         SnowLeopard build fix.
572
573         Renamed initWithClient to initWithAuthenticationClient.
574
575         * platform/network/mac/AuthenticationMac.mm:
576         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
577         (WebCore::AuthenticationChallenge::setAuthenticationClient):
578
579 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
580
581         Reviewed by Darin Adler.
582
583         ARIA: add alert type roles
584         https://bugs.webkit.org/show_bug.cgi?id=31392
585
586         Test: platform/mac/accessibility/aria-alerts.html
587
588         * accessibility/AccessibilityObject.h:
589         * accessibility/AccessibilityRenderObject.cpp:
590         * accessibility/mac/AccessibilityObjectWrapper.mm:
591
592 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
593
594         Reviewed by Darin Adler.
595
596         https://bugs.webkit.org/show_bug.cgi?id=31386
597         Make Mac AuthenticationChallenge usable from cross-platform code
598
599         No change in behavior, so no tests.
600
601         * platform/network/ResourceHandle.cpp:
602         (WebCore::ResourceHandle::clearAuthentication):
603         * platform/network/ResourceHandleInternal.h:
604         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
605         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
606         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
607         is identical.
608
609         * platform/network/cf/AuthenticationChallenge.h:
610         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
611         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
612
613         * platform/network/cf/ResourceHandleCFNet.cpp:
614         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
615         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
616         be already set.
617
618         * platform/network/mac/AuthenticationChallenge.h:
619         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
620         best of my understanding.
621         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
622         confusion with "mac" and "web" challenges in ResourceHandleInternal.
623
624         * platform/network/mac/AuthenticationMac.mm:
625         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
626         making it possible to use the latter with NSURLAuthenticationChallenge.
627         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
628         m_nsChallenge renaming.
629         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
630         set it as sender (or unset, if client is null).
631
632         * platform/network/mac/ResourceHandleMac.mm:
633         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
634         authentication challenge sender.
635         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
636         authentication sheet.
637         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
638         using the new setAuthenticationClient() method.
639         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
640         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
641         the original Mac one, not the one we created for use with authentication sheet. I don't
642         know when a connection would cancel authentication in practice, so I haven't tested this.
643
644 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
645
646         Reviewed by Timothy Hatcher.
647
648         Web Inspector: breakpoint sidebar entries should allow click over entire list item
649         https://bugs.webkit.org/show_bug.cgi?id=31411
650
651         No new tests; no new functionality, small usability change. 
652
653         * inspector/front-end/BreakpointsSidebarPane.js:
654         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
655         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
656
657 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
658
659         Reviewed by Timothy Hatcher.
660
661         Web Inspector: breakpoints in named evals are not restored after a reload
662         https://bugs.webkit.org/show_bug.cgi?id=31375
663
664         Manual test added
665
666         * inspector/front-end/ScriptsPanel.js:
667         (WebInspector.ScriptsPanel.prototype.addScript):
668         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
669
670 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
671
672         Reviewed by Kenneth Rohde Christiansen.
673
674         Custom printing shrink factors
675         https://bugs.webkit.org/show_bug.cgi?id=29042
676
677         This reverts commit r49769. The public API for this needs to be reviewed
678         before its inclusion in Qt.
679
680         * page/PrintContext.cpp:
681         (WebCore::PrintContext::begin):
682         * page/Settings.cpp:
683         (WebCore::Settings::Settings):
684         * page/Settings.h:
685
686 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
687
688         Reviewed by Pavel Feldman.
689
690         Web Inspector: Resource errors/warnings not shown in the Resource tree.
691
692         Error/Warning bubbles are not displayed next to the resource in the 
693         Resources panel if those occur before the resource is attached to the tree.
694         https://bugs.webkit.org/show_bug.cgi?id=31404
695
696         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
697
698         * inspector/front-end/AbstractTimelinePanel.js:
699         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
700         * inspector/front-end/ResourcesPanel.js:
701         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
702
703 2009-11-12  Philippe Normand  <pnormand@igalia.com>
704
705         Reviewed by Jan Alonzo.
706
707         https://bugs.webkit.org/show_bug.cgi?id=31047
708         [GTK] Failing test media/video-played-ranges-1.html
709
710         Follow-up of r50726, don't block the UI thread when calling
711         gst_element_get_state(). Also fixed a compilation warning and some
712         static casts.
713
714         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
715         (WebCore::playbackPosition):
716         (WebCore::MediaPlayerPrivate::seek):
717         (WebCore::MediaPlayerPrivate::setRate):
718
719 2009-11-12  Philippe Normand  <pnormand@igalia.com>
720
721         Reviewed by Jan Alonzo.
722
723         https://bugs.webkit.org/show_bug.cgi?id=31047
724         [GTK] Failing test media/video-played-ranges-1.html
725
726         don't pause pipeline if already paused, same for play()
727
728         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
729         (WebCore::MediaPlayerPrivate::play):
730         (WebCore::MediaPlayerPrivate::pause):
731
732 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
733
734         Reviewed by David Levin.
735
736         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
737         Chromium too.
738         https://bugs.webkit.org/show_bug.cgi?id=31292
739
740         No new tests. (Corresponding test for Gtk+ is
741         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
742
743         * page/EventHandler.cpp:
744         * page/chromium/EventHandlerChromium.cpp:
745
746 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
747
748         Reviewed by Eric Seidel.
749
750         Prevent text inside a multi-column block from being split into columns.
751         
752         If the tentative height of a multi-column block was too small, we need to
753         expand the block height and try to layout again, in order to prevent text
754         from being split into different columns.
755
756         CSS Multicolumn text is split awkwardly
757         https://bugs.webkit.org/show_bug.cgi?id=22249
758
759         Test: fast/multicol/single-line.html
760
761         * rendering/RenderBlock.cpp:
762         (WebCore::RenderBlock::layoutColumns):
763         * rendering/RenderBlock.h:
764         * rendering/RenderLineBoxList.cpp:
765         (WebCore::RenderLineBoxList::paint):
766         * rendering/RenderView.h:
767         (WebCore::RenderView::setTruncatedAt):
768         (WebCore::RenderView::setMinimumColumnHeight):
769         (WebCore::RenderView::minimumColumnHeight):
770
771 2009-11-11  Kent Tamura  <tkent@chromium.org>
772
773         Reviewed by Darin Adler.
774
775         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
776         https://bugs.webkit.org/show_bug.cgi?id=31195
777
778         Test: fast/forms/input-file-re-render.html
779
780         * rendering/RenderFileUploadControl.cpp:
781         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
782
783 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
784
785         Reviewed by Dimitri Glazkov.
786
787         Fixing Chromium's POSIX VFS implementation, by adding the required
788         "used file descriptors" logic.
789
790         https://bugs.webkit.org/show_bug.cgi?id=31275
791
792         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
793
794 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
795
796         Reviewed by Oliver Hunt.
797
798         need to implement aria tree roles
799         https://bugs.webkit.org/show_bug.cgi?id=31284
800
801         Tests: platform/mac/accessibility/aria-multiselectable.html
802                platform/mac/accessibility/aria-tree.html
803
804         * accessibility/AccessibilityList.cpp:
805         (WebCore::AccessibilityList::accessibilityIsIgnored):
806         * accessibility/AccessibilityObject.cpp:
807         (WebCore::AccessibilityObject::ariaTreeRows):
808         (WebCore::AccessibilityObject::ariaTreeItemContent):
809         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
810         * accessibility/AccessibilityObject.h:
811         (WebCore::):
812         (WebCore::AccessibilityObject::isTree):
813         (WebCore::AccessibilityObject::isTreeItem):
814         (WebCore::AccessibilityObject::setIsExpanded):
815         (WebCore::AccessibilityObject::canSetExpandedAttribute):
816         (WebCore::AccessibilityObject::hierarchicalLevel):
817         (WebCore::AccessibilityObject::setSelectedRows):
818         (WebCore::AccessibilityObject::performDefaultAction):
819         * accessibility/AccessibilityRenderObject.cpp:
820         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
821         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
822         (WebCore::AccessibilityRenderObject::isExpanded):
823         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
824         (WebCore::AccessibilityRenderObject::elementAttributeValue):
825         (WebCore::AccessibilityRenderObject::setIsExpanded):
826         (WebCore::AccessibilityRenderObject::isSelected):
827         (WebCore::AccessibilityRenderObject::setSelected):
828         (WebCore::AccessibilityRenderObject::setSelectedRows):
829         (WebCore::createARIARoleMap):
830         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
831         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
832         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
833         (WebCore::AccessibilityRenderObject::selectedChildren):
834         * accessibility/AccessibilityRenderObject.h:
835         * accessibility/mac/AccessibilityObjectMac.mm:
836         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
837         * accessibility/mac/AccessibilityObjectWrapper.mm:
838         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
839         (RoleEntry::):
840         (-[AccessibilityObjectWrapper subrole]):
841         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
842         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
843         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
844         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
845         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
846         * html/HTMLAttributeNames.in:
847
848 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
849
850         Build fix after @r50760 with ENABLE_FILTERS.
851
852         * platform/graphics/filters/SourceAlpha.cpp:
853         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
854         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
855           to fillRect.
856
857 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
858
859         Reviewed by Alexey Proskuryakov.
860
861         Fix WebSocket frame parser of frame_type with high-order bit set.
862         https://bugs.webkit.org/show_bug.cgi?id=30668
863
864         If buffer is smaller than frame's length, it should break the loop
865         instead of reading next byte.
866
867         Tests: websocket/tests/frame-length-longer-than-buffer.html
868                websocket/tests/frame-length-skip.html
869
870         * websockets/WebSocketChannel.cpp:
871         (WebCore::WebSocketChannel::didReceiveData):
872
873 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
874
875         Reviewed by Adam Barth.
876
877         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
878         https://bugs.webkit.org/show_bug.cgi?id=31345
879
880         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
881
882         * platform/graphics/chromium/FontCustomPlatformData.cpp:
883         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
884         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
885         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
886
887 2009-11-11  Beth Dakin  <bdakin@apple.com>
888
889         Build fix. No review needed.
890
891         * platform/graphics/gtk/FontGtk.cpp:
892         (WebCore::Font::drawComplexText):
893
894 2009-11-11  Beth Dakin  <bdakin@apple.com>
895
896         Build fix. No review needed.
897
898         * platform/graphics/cairo/FontCairo.cpp:
899         (WebCore::Font::drawGlyphs):
900
901 2009-11-11  Beth Dakin  <bdakin@apple.com>
902
903         Windows build fix. No review needed. 
904
905         * platform/graphics/win/FontCGWin.cpp:
906         (WebCore::Font::drawGlyphs):
907
908 2009-11-11  Beth Dakin  <bdakin@apple.com>
909
910         Reviewed by Simon Fraser.
911
912         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
913         Make -webkit-color-correction work with shadows
914
915         From canvas, just send DeviceColorSpace to setShadow() for now. 
916         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
917         * html/canvas/CanvasRenderingContext2D.cpp:
918         (WebCore::CanvasRenderingContext2D::setShadow):
919         (WebCore::CanvasRenderingContext2D::applyShadow):
920
921         setShadow() and setPlatformShadow() now take a ColorSpace.
922         * platform/graphics/GraphicsContext.cpp:
923         (WebCore::GraphicsContext::setShadow):
924         * platform/graphics/GraphicsContext.h:
925         * platform/graphics/cg/GraphicsContextCG.cpp:
926         (WebCore::createCGColorWithColorSpace): New helper to create a 
927         color in a ColorSpace.
928         (WebCore::setCGFillColor): Call new helper.
929         (WebCore::setCGStrokeColor): Call new helper.
930         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
931         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
932         (WebCore::GraphicsContext::setPlatformShadow):
933
934         Send appropriate ColorSpace to setShadow().
935         * platform/graphics/mac/FontMac.mm:
936         (WebCore::Font::drawGlyphs):
937         * rendering/EllipsisBox.cpp:
938         (WebCore::EllipsisBox::paint):
939         * rendering/InlineFlowBox.cpp:
940         (WebCore::InlineFlowBox::paintTextDecorations):
941         * rendering/InlineTextBox.cpp:
942         (WebCore::paintTextWithShadows):
943         (WebCore::InlineTextBox::paintDecoration):
944         * rendering/RenderBoxModelObject.cpp:
945         (WebCore::RenderBoxModelObject::paintBoxShadow):
946         * rendering/SVGInlineTextBox.cpp:
947         (WebCore::SVGInlineTextBox::paintCharacters):
948         * rendering/SVGRenderSupport.cpp:
949         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
950
951         Attempt to keep ports building.
952         * platform/graphics/cairo/GraphicsContextCairo.cpp:
953         (WebCore::GraphicsContext::setPlatformShadow):
954         * platform/graphics/qt/GraphicsContextQt.cpp:
955         (WebCore::GraphicsContext::setPlatformShadow):
956         * platform/graphics/skia/GraphicsContextSkia.cpp:
957         (WebCore::GraphicsContext::setPlatformShadow):
958         * platform/graphics/wince/GraphicsContextWince.cpp:
959         (WebCore::GraphicsContext::setPlatformShadow):
960         * platform/graphics/wx/GraphicsContextWx.cpp:
961         (WebCore::GraphicsContext::setPlatformShadow):
962
963 2009-11-11  Kent Tamura  <tkent@chromium.org>
964
965         Reviewed by Darin Adler.
966
967         Print the file text of a file upload control in DumpRenderTree for ease of tests.
968         https://bugs.webkit.org/show_bug.cgi?id=31195
969
970         * rendering/RenderFileUploadControl.cpp:
971         (WebCore::RenderFileUploadControl::paintObject):
972         (WebCore::RenderFileUploadControl::fileTextValue):
973         * rendering/RenderFileUploadControl.h:
974         (WebCore::RenderFileUploadControl::isFileUploadControl):
975         (WebCore::toRenderFileUploadControl):
976         * rendering/RenderObject.h:
977         (WebCore::RenderObject::isFileUploadControl):
978         * rendering/RenderTreeAsText.cpp:
979         (WebCore::operator<<):
980
981 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
982
983         Reviewed by Sam Weinig.
984
985         DOM Wrappers for some nodes may not be marked.
986         https://bugs.webkit.org/show_bug.cgi?id=31380
987
988         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
989         the wrapper for the current world only.  This means that wrappers may be GC'ed
990         prematurely, and properties lost.
991
992         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
993
994         * bindings/js/JSAttrCustom.cpp:
995         (WebCore::JSAttr::markChildren):
996         * bindings/js/JSDOMBinding.cpp:
997         (WebCore::markDOMNodeWrapper):
998         * bindings/js/JSDOMBinding.h:
999         * bindings/js/JSNamedNodeMapCustom.cpp:
1000         (WebCore::JSNamedNodeMap::markChildren):
1001         * bindings/js/JSNodeCustom.cpp:
1002         (WebCore::JSNode::markChildren):
1003         * bindings/js/JSSVGElementInstanceCustom.cpp:
1004         (WebCore::JSSVGElementInstance::markChildren):
1005         * bindings/js/JSStyleSheetCustom.cpp:
1006         (WebCore::JSStyleSheet::markChildren):
1007
1008 2009-11-11  Ben Murdoch  <benm@google.com>
1009
1010         Reviewed by Darin Adler.
1011
1012         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1013         https://bugs.webkit.org/show_bug.cgi?id=31384
1014
1015         No functionality change so no tests required.
1016
1017         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1018
1019 2009-11-11  Jens Alfke  <snej@chromium.org>
1020
1021         Reviewed by Dimitri Glazkov.
1022
1023         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1024         - Various inline functions in V8Binding.h made non-inline.
1025         - Some renaming for consistency.
1026         - New function createRawTemplate().
1027         https://bugs.webkit.org/show_bug.cgi?id=31383
1028
1029         * bindings/scripts/CodeGeneratorV8.pm:
1030         * bindings/v8/V8Binding.cpp:
1031         (WebCore::v8DOMWrapperToNative):
1032         (WebCore::v8ValueToWebCoreString):
1033         (WebCore::v8ValueToAtomicWebCoreString):
1034         (WebCore::toInt32):
1035         (WebCore::toWebCoreString):
1036         (WebCore::toWebCoreStringWithNullCheck):
1037         (WebCore::toAtomicWebCoreStringWithNullCheck):
1038         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1039         (WebCore::isUndefinedOrNull):
1040         (WebCore::v8Boolean):
1041         (WebCore::v8UndetectableString):
1042         (WebCore::v8StringOrNull):
1043         (WebCore::v8StringOrUndefined):
1044         (WebCore::v8StringOrFalse):
1045         (WebCore::v8StringToWebCoreString):
1046         (WebCore::v8ExternalString):
1047         (WebCore::createRawTemplate):  New function.
1048         * bindings/v8/V8Binding.h:
1049         (WebCore::v8DOMWrapperTo):
1050         (WebCore::v8DOMWrapperToNode):
1051         (WebCore::v8StringToWebCoreString):
1052         (WebCore::v8StringToAtomicWebCoreString):
1053
1054 2009-11-11  Jens Alfke  <snej@chromium.org>
1055
1056         Reviewed by Dimitri Glazkov.
1057
1058         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1059         event-listener setter into a new subroutine transferHiddenDependency().
1060         https://bugs.webkit.org/show_bug.cgi?id=31377
1061
1062         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1063         * bindings/v8/V8Utilities.cpp:
1064         (WebCore::transferHiddenDependency):  New.
1065         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1066
1067 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1068
1069         Reviewed by Beth Dakin.
1070
1071         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1072         because there is a CG bug preventing this from working.
1073
1074         * platform/graphics/cg/GraphicsContextCG.cpp:
1075         (WebCore::sRGBColorSpaceRef):
1076
1077 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1078
1079         Reviewed by Timothy Hatcher.
1080
1081         Check that if Storage panel exists before calling its methods
1082
1083         https://bugs.webkit.org/show_bug.cgi?id=31343
1084
1085         * inspector/front-end/inspector.js:
1086         (WebInspector.addDatabase):
1087         (WebInspector.addCookieDomain):
1088         (WebInspector.addDOMStorage):
1089         (WebInspector.updateDOMStorage):
1090
1091 2009-11-11  Jens Alfke  <snej@chromium.org>
1092
1093         Reviewed by Dimitri Glazkov.
1094
1095         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1096         times in the generated V8 bindings.
1097         https://bugs.webkit.org/show_bug.cgi?id=31368
1098
1099         * bindings/v8/V8DOMWrapper.cpp:
1100         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1101         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1102
1103 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1104
1105         Reviewed by Timothy Hatcher.
1106
1107         Display the correct summary in the web inspector for the shorthands
1108         border-color, border-width, border-style, margin, and padding.
1109         https://bugs.webkit.org/show_bug.cgi?id=7987
1110
1111         Test: fast/css/shorthands-four-values.html
1112
1113         * css/CSSMutableStyleDeclaration.cpp:
1114         (WebCore::CSSMutableStyleDeclaration::get4Values):
1115         Display the summary information in the same way the shorthand would be
1116         specified in a css rule.
1117
1118 2009-11-11  Jens Alfke  <snej@chromium.org>
1119
1120         Reviewed by Dimitri Glazkov.
1121
1122         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1123         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1124         https://bugs.webkit.org/show_bug.cgi?id=31367
1125
1126         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1127
1128 2009-11-11  Jens Alfke  <snej@chromium.org>
1129
1130         Reviewed by Dimitri Glazkov.
1131
1132         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1133
1134         * bindings/v8/DOMData.cpp:
1135         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1136             so it can be inlined by its caller.
1137         * bindings/v8/DOMData.h:
1138         * bindings/v8/MainThreadDOMData.cpp:
1139         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1140         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1141         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1142             and getStore, which inline both calls together.
1143         * bindings/v8/MainThreadDOMData.h:
1144         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1145         * bindings/v8/V8DOMMap.cpp:
1146         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1147
1148 2009-11-11  Nate Chapin  <japhet@chromium.org>
1149
1150         Reviewed by Dimitri Glazkov.
1151
1152         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1153
1154         https://bugs.webkit.org/show_bug.cgi?id=31357
1155
1156         * platform/KURLGoogle.cpp:
1157         (WebCore::isSchemeFirstChar):
1158         (WebCore::isSchemeChar):
1159         (WebCore::KURL::hasPort):
1160         (WebCore::KURL::removePort):
1161         (WebCore::protocolIsValid):
1162
1163 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1164
1165         Build fix, no reviewed.
1166
1167         Correct setPlatformFillColor and setPlatformStrokeColor calls
1168         to match new ColorSpace-supporting signatures.
1169
1170         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1171           color space to the set[...]Color calls.
1172
1173 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1174
1175         Reviewed by Sam Weinig.
1176
1177         https://bugs.webkit.org/show_bug.cgi?id=31327
1178         Clean up SocketStreamHandleClient interface
1179
1180         No change in behavior.
1181
1182         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1183         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1184         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1185         should be.
1186         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1187         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1188         For ResourceHandle, this method is called when the user cancels authentication sheet,
1189         not when something happens with the stream.
1190
1191         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1192         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1193
1194         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1195         callbacks have no real implementation yet.
1196
1197 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1198
1199         Reviewed by Eric Seidel.
1200
1201         Allow custom memory allocation control for the part of page directory in WebCore
1202         https://bugs.webkit.org/show_bug.cgi?id=31350
1203
1204         Inherits the following classes from Noncopyable because these are instantiated
1205         by 'new' and these are no need to be copyable:
1206
1207         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1208         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1209         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1210         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1211         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1212         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1213         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1214         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1215         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1216
1217         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1218         PropertyWrapper is instantiated by 'new' in 
1219         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1220
1221         * page/DragController.h:
1222         * page/EventHandler.h:
1223         * page/FocusController.h:
1224         * page/FrameView.cpp:
1225         * page/PluginHalter.h:
1226         * page/Settings.h:
1227         * page/UserScript.h:
1228         * page/UserStyleSheet.h:
1229         * page/XSSAuditor.h:
1230         * page/animation/AnimationBase.cpp:
1231
1232 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1233
1234         Reviewed by Kenneth Rohde Christiansen.
1235
1236         https://bugs.webkit.org/show_bug.cgi?id=31323
1237         Fix a few compiler warnings
1238
1239         No new tests as there is no new functionality.
1240
1241         * editing/htmlediting.cpp:
1242         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1243         parentheses to silence gcc 4.4 -Wparentheses warnings
1244
1245 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1246
1247         Reviewed by Mark Rowe.
1248
1249         Set m_hasPendingGeometryChange to true by default, so that
1250         at least one call to NPP_SetWindow is executed, which is
1251         needed by the DRT plugin testing framework.
1252
1253         * plugins/PluginView.cpp:
1254         (WebCore::PluginView::PluginView):
1255
1256 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1257
1258         Rubber-stamped by Kenneth Rohde Christiansen.
1259
1260         https://bugs.webkit.org/show_bug.cgi?id=31348
1261         [Qt] Remove unnecessary LUT creator from WebCore.pro
1262
1263         * WebCore.pro:
1264
1265 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1266
1267         Reviewed by Tor Arne Vestbø.
1268
1269         Introduce a function for querying the input method status
1270         in QWebPageClient.
1271
1272         * platform/qt/QWebPageClient.h:
1273
1274 2009-11-11  Benjamin Otte  <otte@gnome.org>
1275
1276         Reviewed by Jan Alonzo.
1277
1278         [GTK] Black artifacts in youtube.com/html5
1279
1280         Paint the video to the given size. It's the job of the callers to keep
1281         track of aspect ratio. RenderVideo.cpp does it for the <video>
1282         element.
1283         https://bugs.webkit.org/show_bug.cgi?id=30925
1284
1285         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1286         (WebCore::MediaPlayerPrivate::paint):
1287
1288 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1289
1290         Reviewed by Reviewed by Jan Alonzo.
1291
1292         https://bugs.webkit.org/show_bug.cgi?id=30901
1293         [Gtk] Need to de-lint the Atk a11y code
1294
1295         Cleaned up some missed capitalization style-guideline violations.
1296
1297         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1298
1299 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1300
1301         Reviewed by Eric Seidel.
1302
1303         [Qt] Make the default style background color valid.
1304         Currently the color is transparent but invalid, this causes
1305         list boxes in QtWebKit to be drawn with a black background
1306         since r49242.
1307         https://bugs.webkit.org/show_bug.cgi?id=31295
1308
1309         * rendering/style/RenderStyle.h:
1310         (WebCore::InheritedFlags::initialBackgroundColor):
1311         * rendering/style/StyleBackgroundData.cpp:
1312         (WebCore::StyleBackgroundData::StyleBackgroundData):
1313
1314 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1315
1316         Reviewed by Geoff Garen.
1317
1318         Simplify the ownership model for worlds - rather than having a pair of weak references
1319         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1320         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1321         back forward cache.
1322
1323         * WebCore.base.exp:
1324         * bindings/js/JSDOMBinding.cpp:
1325         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1326         * bindings/js/JSDOMBinding.h:
1327         (WebCore::DOMWrapperWorld::forgetDocument):
1328         * bindings/js/ScriptCachedFrameData.cpp:
1329         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1330         (WebCore::ScriptCachedFrameData::restore):
1331         (WebCore::ScriptCachedFrameData::clear):
1332         * bindings/js/ScriptCachedFrameData.h:
1333         * bindings/js/ScriptController.cpp:
1334         (WebCore::ScriptController::~ScriptController):
1335         (WebCore::ScriptController::clearWindowShell):
1336         (WebCore::ScriptController::initScript):
1337         (WebCore::ScriptController::updateDocument):
1338         * bindings/js/ScriptController.h:
1339
1340 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1341
1342         Reviewed by Darin Adler.
1343
1344         rename counter to makeCounterNode in RenderCounter.cpp
1345         https://bugs.webkit.org/show_bug.cgi?id=31289
1346
1347         No new test because this is just a small refactoring.
1348
1349         * rendering/RenderCounter.cpp:
1350         (WebCore::findPlaceForCounter):
1351         (WebCore::makeCounterNode):
1352         (WebCore::RenderCounter::originalText):
1353
1354 2009-11-10  Daniel Bates  <dbates@webkit.org>
1355
1356         Reviewed by Oliver Hunt.
1357
1358         https://bugs.webkit.org/show_bug.cgi?id=30754
1359
1360         Patch 2 of 2.
1361
1362         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1363         needed. This method fired a drag event whenever the mouse moved, but
1364         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1365         model independent of when the mouse moves. See "Among other changes..."
1366         in the change log for patch 1 for more details.
1367
1368         * WebCore.DragSupport.exp:
1369         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1370         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1371         * page/EventHandler.h:
1372
1373 2009-11-10  Daniel Bates  <dbates@webkit.org>
1374
1375         Reviewed by Oliver Hunt.
1376
1377         https://bugs.webkit.org/show_bug.cgi?id=30754
1378
1379         Patch 1 of 2.
1380
1381         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1382         the drag event should always fire before the dragover event.
1383
1384         In fixing this bug, this patch also makes our drag processing model
1385         conform to the HTML 5 spec.
1386
1387         Among the changes, this patch ensures that the drag event isn't fired outside
1388         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1389         Currently, the drag event is fired whenever the mouse button is down and the OS
1390         detects the mouse moved. But, as per the spec, the drag event should
1391         fire approx. every 350ms so long as the mouse button is down.
1392
1393         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1394
1395         * page/EventHandler.cpp:
1396         (WebCore::EventHandler::clear):
1397         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1398         Modified to determine when we are in the correct instance of EventHandler to service the drag
1399         and drop operation.
1400         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1401         into this method.
1402         (WebCore::EventHandler::cancelDragAndDrop):
1403         (WebCore::EventHandler::performDragAndDrop):
1404         (WebCore::EventHandler::clearDragState):
1405         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1406         we should fire both drag and dragover events or only the dragover event.
1407
1408 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1409
1410         Reviewed by Dimitri Glazkov.
1411
1412         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1413         https://bugs.webkit.org/show_bug.cgi?id=31301
1414
1415         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1416
1417         Allowed passing V8Proxy for the calling JS context:
1418         * bindings/v8/V8DOMWrapper.h:
1419         (WebCore::V8DOMWrapper::getXPathNSResolver):
1420         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1421         (WebCore::V8CustomXPathNSResolver::create):
1422         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1423         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1424         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1425         * bindings/v8/custom/V8DocumentCustom.cpp:
1426         (WebCore::CALLBACK_FUNC_DECL):
1427
1428 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1429
1430         Reviewed by Timothy Hatcher.
1431
1432         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1433         https://bugs.webkit.org/show_bug.cgi?id=29972.
1434
1435         Add methods for setting different parts of the URL in href attribute.
1436
1437         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1438                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1439                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1440                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1441                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1442                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1443                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1444
1445         * bindings/js/JSLocationCustom.cpp:
1446         (WebCore::JSLocation::setPort):
1447         * html/HTMLAnchorElement.cpp:
1448         (WebCore::parsePortFromStringPosition):
1449         (WebCore::HTMLAnchorElement::setHash):
1450         (WebCore::HTMLAnchorElement::setHost):
1451         (WebCore::HTMLAnchorElement::setHostname):
1452         (WebCore::HTMLAnchorElement::setPathname):
1453         (WebCore::HTMLAnchorElement::setPort):
1454         (WebCore::HTMLAnchorElement::setProtocol):
1455         (WebCore::HTMLAnchorElement::setSearch):
1456         * html/HTMLAnchorElement.h:
1457         * html/HTMLAnchorElement.idl:
1458         * loader/FrameLoader.cpp:
1459         (WebCore::FrameLoader::iconURL):
1460         * platform/KURL.cpp:
1461         (WebCore::KURL::removePort):
1462         (WebCore::KURL::setPort):
1463         (WebCore::KURL::prettyURL):
1464         (WebCore::protocolIsValid):
1465         * platform/KURL.h:
1466         (WebCore::KURL::canSetHostOrPort):
1467         (WebCore::KURL::canSetPathname):
1468         (WebCore::KURL::hasPort):
1469         * platform/network/soup/ResourceHandleSoup.cpp:
1470         (WebCore::):
1471
1472 2009-11-10  Nate Chapin  <japhet@chromium.org>
1473
1474         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1475
1476         * platform/chromium/PopupMenuChromium.cpp:
1477         (WebCore::PopupContainer::paintBorder):
1478         (WebCore::PopupListBox::paint):
1479         (WebCore::PopupListBox::paintRow):
1480         * platform/graphics/chromium/TransparencyWin.cpp:
1481         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1482         * platform/graphics/skia/GraphicsContextSkia.cpp:
1483         (WebCore::GraphicsContext::fillRect):
1484         (WebCore::GraphicsContext::fillRoundedRect):
1485         (WebCore::GraphicsContext::setPlatformFillColor):
1486         (WebCore::GraphicsContext::setPlatformStrokeColor):
1487         * rendering/RenderMediaControlsChromium.cpp:
1488         (WebCore::paintMediaSlider):
1489         (WebCore::paintMediaVolumeSlider):
1490         (WebCore::paintMediaTimelineContainer):
1491         * rendering/RenderThemeChromiumMac.mm:
1492         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1493
1494 2009-11-10  Brady Eidson  <beidson@apple.com>
1495
1496         Reviewed by Sam Weinig.
1497
1498         Repro crash saving pcmag.com article as a webarchive.
1499         <rdar://problem/7381219> and https://webkit.org/b/31322
1500
1501         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1502
1503         * css/CSSStyleSheet.cpp:
1504         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1505           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1506
1507 2009-11-10  Beth Dakin  <bdakin@apple.com>
1508
1509         Attempt 2 to fix Tiger build. No review needed.
1510
1511         * platform/graphics/cg/GraphicsContextCG.cpp:
1512         (WebCore::deviceRGBColorSpaceRef):
1513         (WebCore::sRGBColorSpaceRef):
1514
1515 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1516
1517         wx build fix. Changes needed after r50760.
1518
1519         * platform/graphics/wx/GraphicsContextWx.cpp:
1520         (WebCore::GraphicsContext::GraphicsContext):
1521         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1522         (WebCore::drawTextWithSpacing):
1523
1524 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1525
1526         Qt build fix.
1527
1528         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1529         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1530
1531 2009-11-10  Beth Dakin  <bdakin@apple.com>
1532
1533         Tiger build fix. No review needed.
1534
1535         * platform/graphics/cg/GraphicsContextCG.cpp:
1536         (WebCore::sRGBColorSpaceRef):
1537
1538 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1539
1540         Reviewed by Dan Bernstein.
1541
1542         https://bugs.webkit.org/show_bug.cgi?id=31312
1543         Decouple authentication panel callbacks from ResourceHandle
1544
1545         No change in functionality.
1546
1547         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1548         ResourceHandle as delegate.
1549
1550         * WebCore.vcproj/WebCore.vcproj:
1551         * platform/network/AuthenticationClient.h: Added.
1552         Added a new interface for listening to authentication panel notifications.
1553
1554         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1555         it wants with the project file.
1556
1557         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1558         interface class.
1559         (WebCore::AuthenticationClient::deref): Ditto.
1560
1561         * platform/network/ResourceHandle.h:
1562         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1563         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1564
1565         * platform/network/cf/AuthenticationCF.cpp:
1566         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1567         (WebCore::AuthenticationChallenge::platformCompare):
1568         * platform/network/cf/AuthenticationChallenge.h:
1569         (WebCore::AuthenticationChallenge::authenticationClient):
1570         * platform/network/chromium/AuthenticationChallenge.h:
1571         (WebCore::AuthenticationChallenge::authenticationClient):
1572         * platform/network/curl/AuthenticationChallenge.h:
1573         (WebCore::AuthenticationChallenge::authenticationClient):
1574         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1575
1576 2009-11-10  Beth Dakin  <bdakin@apple.com>
1577
1578        Second attempted gtk build fix. No review needed.
1579
1580         * html/canvas/CanvasStyle.cpp:
1581         (WebCore::CanvasStyle::applyStrokeColor):
1582
1583
1584 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1585
1586         Reviewed by Geoff Garen.
1587
1588         Fix back/forwards cache with JSC isolated worlds.
1589         https://bugs.webkit.org/show_bug.cgi?id=31310
1590         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1591
1592         Store the global object for all worlds, not just the normal world.
1593         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1594         so we can forget global objects if a world goes away.
1595
1596         * bindings/js/JSDOMBinding.cpp:
1597         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1598         * bindings/js/JSDOMBinding.h:
1599         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1600         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1601         * bindings/js/ScriptCachedFrameData.cpp:
1602         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1603         (WebCore::ScriptCachedFrameData::forgetWorld):
1604         (WebCore::ScriptCachedFrameData::domWindow):
1605         (WebCore::ScriptCachedFrameData::restore):
1606         (WebCore::ScriptCachedFrameData::clear):
1607         * bindings/js/ScriptCachedFrameData.h:
1608         * bindings/js/ScriptController.h:
1609
1610 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1611
1612         [Qt] Unreviewed buildfix after r50760.
1613
1614         * platform/graphics/qt/GraphicsContextQt.cpp:
1615         (WebCore::GraphicsContext::GraphicsContext):
1616
1617 2009-11-10  Beth Dakin  <bdakin@apple.com>
1618
1619         Attempted build fix. (No review needed.)
1620
1621         * GNUmakefile.am: Adding ColorSpace.h
1622
1623 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1624
1625         Reviewed by NOBODY - Build Fix.
1626
1627         Updated function calls to take a ColorSpace argument, passing
1628         in DeviceColorSpace for now - this should be fixed. Also added
1629         ColorSpace.h to WebCore project.
1630
1631         * WebCore.vcproj/WebCore.vcproj:
1632         * platform/graphics/win/FontCGWin.cpp:
1633         (WebCore::Font::drawGlyphs):
1634         * platform/graphics/win/GraphicsContextCGWin.cpp:
1635         (WebCore::GraphicsContext::GraphicsContext):
1636         * platform/win/PopupMenuWin.cpp:
1637         (WebCore::PopupMenu::paint):
1638         * platform/win/WebCoreTextRenderer.cpp:
1639         (WebCore::doDrawTextAtPoint):
1640         * rendering/RenderThemeSafari.cpp:
1641         (WebCore::RenderThemeSafari::paintMenuListButton):
1642
1643 2009-11-10  Jens Alfke  <snej@chromium.org>
1644
1645         Reviewed by Darin Adler.
1646
1647         Optimizations to Element::getAttribute
1648         https://bugs.webkit.org/show_bug.cgi?id=30926
1649
1650         * dom/Element.cpp:
1651         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1652         * dom/NamedAttrMap.cpp:
1653         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1654         * platform/text/PlatformString.h:
1655         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1656
1657 2009-11-10  Beth Dakin  <bdakin@apple.com>
1658
1659         Reviewed by Darin Adler.
1660
1661         Fix for <rdar://problem/7059710> 
1662         -and corresponding-
1663         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1664         color-correction for CSS colors
1665
1666         New exported symbol for GraphicsContext::fillColor() which now 
1667         accepts a ColorSpace as an optional parameter.
1668         * WebCore.base.exp:
1669
1670         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1671         * WebCore.xcodeproj/project.pbxproj:
1672
1673         Computed Style for -webkit-color-correction
1674         * css/CSSComputedStyleDeclaration.cpp:
1675         (WebCore::):
1676         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1677
1678         Parse -webkit-color-correction
1679         * css/CSSParser.cpp:
1680         (WebCore::CSSParser::parseValue):
1681
1682        Map CSS identifiers to the appropriate values of the ColorSpace enum
1683         * css/CSSPrimitiveValueMappings.h:
1684         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1685         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1686
1687         New property -webkit-color-correction
1688         * css/CSSPropertyNames.in:
1689
1690         Map -webkit-color-correction into the RenderStyle.
1691         * css/CSSStyleSelector.cpp:
1692         (WebCore::CSSStyleSelector::applyProperty):
1693
1694         Add new value sRGB.
1695         * css/CSSValueKeywords.in:
1696
1697         Comment out the reference to sRGB since it will now be inherited as 
1698         a value from CSSValueKeywords.
1699         * css/SVGCSSValueKeywords.in:
1700
1701         Definition of the ColorSpace enum.
1702         * platform/graphics/ColorSpace.h: Added.
1703         (WebCore::):
1704
1705         These functions all now take a ColorSpace as a parameter.
1706         * platform/graphics/GraphicsContext.cpp:
1707         (WebCore::GraphicsContext::setStrokeColor):
1708         (WebCore::GraphicsContext::setFillColor):
1709         (WebCore::GraphicsContext::drawHighlightForText):
1710
1711         Return the appropriate ColorSpace.
1712         (WebCore::GraphicsContext::strokeColorSpace):
1713         (WebCore::GraphicsContext::fillColorSpace):
1714
1715         These functions all call other functions which require a ColorSpace 
1716         as a parameter.
1717         (WebCore::GraphicsContext::setStrokePattern):
1718         (WebCore::GraphicsContext::setFillPattern):
1719         (WebCore::GraphicsContext::setStrokeGradient):
1720         (WebCore::GraphicsContext::setFillGradient):
1721
1722         All of the GraphicsContext functions that take a Color should now 
1723         also take a ColorSpace.
1724         * platform/graphics/GraphicsContext.h:
1725
1726         Added new member variables stokeColorSpace and fillColorSpace.
1727         * platform/graphics/GraphicsContextPrivate.h:
1728         (WebCore::GraphicsContextState::GraphicsContextState):
1729
1730         Attempt to keep the Cairo port building with all of the massive 
1731         changes to GraphicsContext.        
1732         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1733         (WebCore::GraphicsContext::fillRect):
1734         (WebCore::GraphicsContext::setPlatformFillColor):
1735         (WebCore::GraphicsContext::setPlatformStrokeColor):
1736         (WebCore::GraphicsContext::fillRoundedRect):
1737
1738         
1739         * platform/graphics/cg/GraphicsContextCG.cpp:
1740         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1741         CGColorSpaceRef for the sRGB color space.
1742         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1743         a CGColorSpaceRef for the device RGB color space.
1744
1745         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1746         sets the fill color to the specified color in the given ColorSpace.
1747         (WebCore::setCGStrokeColor): Same, but for stroke.
1748
1749         (WebCore::setCGFillColorSpace): New static to set the 
1750         CGFillColorSpace to the given ColorSpace
1751         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1752
1753         Send ColorSpaces when appropriate, set ColorSpaces when 
1754         appropriate, and check ColorSpaces when appropriate.
1755         (WebCore::GraphicsContext::GraphicsContext):
1756         (WebCore::GraphicsContext::drawRect):
1757         (WebCore::GraphicsContext::drawLine):
1758         (WebCore::GraphicsContext::fillPath):
1759         (WebCore::GraphicsContext::strokePath):
1760         (WebCore::GraphicsContext::fillRect):
1761         (WebCore::GraphicsContext::fillRoundedRect):
1762         (WebCore::GraphicsContext::strokeRect):
1763         (WebCore::GraphicsContext::drawLineForText):
1764         (WebCore::GraphicsContext::setPlatformStrokeColor):
1765         (WebCore::GraphicsContext::setPlatformFillColor):
1766
1767         Attempt to keep Haiku building.
1768         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1769         (WebCore::GraphicsContext::fillRect):
1770         (WebCore::GraphicsContext::fillRoundedRect):
1771         (WebCore::GraphicsContext::setPlatformStrokeColor):
1772         (WebCore::GraphicsContext::setPlatformFillColor):
1773
1774         Attempt to keep QT building.
1775         * platform/graphics/qt/GraphicsContextQt.cpp:
1776         (WebCore::GraphicsContext::fillRect):
1777         (WebCore::GraphicsContext::fillRoundedRect):
1778         (WebCore::GraphicsContext::setPlatformStrokeColor):
1779         (WebCore::GraphicsContext::setPlatformFillColor):
1780
1781         Attempt to keep Wince building.
1782         * platform/graphics/wince/GraphicsContextWince.cpp:
1783         (WebCore::GraphicsContext::fillRect):
1784         (WebCore::GraphicsContext::setPlatformFillColor):
1785         (WebCore::GraphicsContext::setPlatformStrokeColor):
1786         (WebCore::GraphicsContext::clearRect):
1787         (WebCore::GraphicsContext::fillRoundedRect):
1788         (WebCore::GraphicsContext::setPlatformShadow):
1789
1790         Attempt to keep WX building.
1791         * platform/graphics/wx/GraphicsContextWx.cpp:
1792         (WebCore::GraphicsContext::fillRect):
1793         (WebCore::GraphicsContext::fillRoundedRect):
1794         (WebCore::GraphicsContext::setPlatformStrokeColor):
1795         (WebCore::GraphicsContext::setPlatformFillColor):
1796
1797         Added functions colorSpace() and setColorSpace()
1798         * rendering/style/RenderStyle.h:
1799         (WebCore::InheritedFlags::colorSpace):
1800         (WebCore::InheritedFlags::setColorSpace):
1801
1802         The ColorSpace is stored here.
1803         * rendering/style/StyleRareInheritedData.cpp:
1804         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1805         (WebCore::StyleRareInheritedData::operator==):
1806         * rendering/style/StyleRareInheritedData.h:
1807
1808         All of these call sites call GraphicsContext functions which now 
1809         require ColorSpaces.
1810         * editing/SelectionController.cpp:
1811         (WebCore::SelectionController::paintCaret):
1812         * html/canvas/CanvasRenderingContext2D.cpp:
1813         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1814         * html/canvas/CanvasStyle.cpp:
1815         (WebCore::CanvasStyle::applyStrokeColor):
1816         (WebCore::CanvasStyle::applyFillColor):
1817         * inspector/InspectorController.cpp:
1818         (WebCore::drawOutlinedQuad):
1819         * page/FrameView.cpp:
1820         (WebCore::FrameView::paintContents):
1821         * platform/ScrollbarTheme.h:
1822         (WebCore::ScrollbarTheme::paintScrollCorner):
1823         * platform/ScrollbarThemeComposite.cpp:
1824         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1825         * platform/graphics/Image.cpp:
1826         (WebCore::Image::fillWithSolidColor):
1827         * platform/graphics/mac/FontMac.mm:
1828         (WebCore::Font::drawGlyphs):
1829         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1830         (WebCore::MediaPlayerPrivate::paint):
1831         * rendering/EllipsisBox.cpp:
1832         (WebCore::EllipsisBox::paint):
1833         * rendering/InlineFlowBox.cpp:
1834         (WebCore::InlineFlowBox::paintTextDecorations):
1835         * rendering/InlineTextBox.cpp:
1836         (WebCore::updateGraphicsContext):
1837         (WebCore::paintTextWithShadows):
1838         (WebCore::InlineTextBox::paint):
1839         (WebCore::InlineTextBox::paintSelection):
1840         (WebCore::InlineTextBox::paintCompositionBackground):
1841         (WebCore::InlineTextBox::paintDecoration):
1842         (WebCore::InlineTextBox::paintTextMatchMarker):
1843         (WebCore::InlineTextBox::paintCompositionUnderline):
1844         * rendering/InlineTextBox.h:
1845         * rendering/RenderBlock.cpp:
1846         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1847         (WebCore::RenderBlock::fillVerticalSelectionGap):
1848         (WebCore::RenderBlock::fillLeftSelectionGap):
1849         (WebCore::RenderBlock::fillRightSelectionGap):
1850         * rendering/RenderBoxModelObject.cpp:
1851         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1852         (WebCore::RenderBoxModelObject::paintBoxShadow):
1853         * rendering/RenderFileUploadControl.cpp:
1854         (WebCore::RenderFileUploadControl::paintObject):
1855         * rendering/RenderFrameSet.cpp:
1856         (WebCore::RenderFrameSet::paintColumnBorder):
1857         (WebCore::RenderFrameSet::paintRowBorder):
1858         * rendering/RenderImage.cpp:
1859         (WebCore::RenderImage::paintReplaced):
1860         * rendering/RenderLayer.cpp:
1861         (WebCore::RenderLayer::paintScrollCorner):
1862         (WebCore::RenderLayer::paintResizer):
1863         * rendering/RenderListBox.cpp:
1864         (WebCore::RenderListBox::paintItemForeground):
1865         (WebCore::RenderListBox::paintItemBackground):
1866         * rendering/RenderListMarker.cpp:
1867         (WebCore::RenderListMarker::paint):
1868         * rendering/RenderObject.cpp:
1869         (WebCore::RenderObject::drawLineForBoxSide):
1870         (WebCore::RenderObject::drawArcForBoxSide):
1871         * rendering/RenderReplaced.cpp:
1872         (WebCore::RenderReplaced::paint):
1873         * rendering/RenderScrollbarTheme.cpp:
1874         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1875         * rendering/RenderThemeMac.mm:
1876         (WebCore::RenderThemeMac::paintMenuListButton):
1877         * rendering/RenderView.cpp:
1878         (WebCore::RenderView::paintBoxDecorations):
1879         * rendering/RenderWidget.cpp:
1880         (WebCore::RenderWidget::paint):
1881         * rendering/SVGInlineTextBox.cpp:
1882         (WebCore::SVGInlineTextBox::paintSelection):
1883         * svg/graphics/SVGPaintServerGradient.cpp:
1884         (WebCore::SVGPaintServerGradient::setup):
1885         * svg/graphics/SVGPaintServerSolid.cpp:
1886         (WebCore::SVGPaintServerSolid::setup):
1887
1888 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1889
1890         Reviewed by Timothy Hatcher.
1891
1892         Web Inspector: Speed up syntax highlighter
1893         https://bugs.webkit.org/show_bug.cgi?id=31291
1894
1895         * inspector/front-end/SourceFrame.js:
1896         (WebInspector.SourceFrame.prototype._loaded):
1897         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1898         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1899         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1900         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1901         (WebInspector.CSSSourceSyntaxHighlighter):
1902         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1903
1904 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1905
1906         Reviewed by Eric Seidel.
1907
1908         Remove session storage setting
1909         https://bugs.webkit.org/show_bug.cgi?id=31279
1910
1911         Remove session storage from Settings.  It was added temporarily so we could
1912         disable it by default at runtime in Chromium.  We now disable these things in a
1913         different way, so it's time to remove it.  Qt also depended on this setting for
1914         a short period of time, but after talking to them we agreed that it should be
1915         removed.
1916
1917         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1918
1919         * page/DOMWindow.cpp:
1920         (WebCore::DOMWindow::sessionStorage):
1921         * page/Settings.cpp:
1922         (WebCore::Settings::Settings):
1923         * page/Settings.h:
1924
1925 2009-11-10  Dan Bernstein  <mitz@apple.com>
1926
1927         Reviewed by Eric Carlson and Darin Adler.
1928
1929         WebCore part of making full-screen video pause during scrubbing.
1930
1931         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1932         and HTMLMediaElement::endScrubbing().
1933
1934 2009-11-10  Anton Muhin  <antonm@chromium.org>
1935
1936         Reviewed by Adam Barth.
1937
1938         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1939         https://bugs.webkit.org/show_bug.cgi?id=31051
1940
1941         * bindings/v8/V8GCController.cpp:
1942         (WebCore::V8GCController::gcEpilogue):
1943         (WebCore::V8GCController::checkMemoryUsage):
1944         * bindings/v8/V8GCController.h:
1945         * bindings/v8/V8Proxy.cpp:
1946         (WebCore::V8Proxy::evaluate):
1947         (WebCore::V8Proxy::runScript):
1948         (WebCore::V8Proxy::callFunction):
1949
1950 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1951
1952         Reviewed by Darin Adler.
1953
1954         Allow custom memory allocation control for the part of loader directory in WebCore
1955         https://bugs.webkit.org/show_bug.cgi?id=31161
1956
1957         Inherits the following classes from Noncopyable because these are instantiated
1958         by 'new' and these are no need to be copyable:
1959
1960         class Request - WebCore/loader/loader.cpp:100
1961         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1962         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1963         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1964         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1965         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1966
1967         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1968         MainThreadBridge is instantiated by 'new' in 
1969         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1970
1971         ThreadableLoaderClient's inheriting has been changed to public.
1972
1973         * loader/ImageLoader.cpp:
1974         * loader/ProgressTracker.cpp:
1975         * loader/RedirectScheduler.cpp:
1976         * loader/Request.h:
1977         * loader/ThreadableLoaderClient.h:
1978         * loader/WorkerThreadableLoader.h:
1979         * loader/appcache/ApplicationCacheHost.h:
1980         * loader/appcache/ApplicationCacheStorage.h:
1981
1982 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1983
1984         Reviewed by Eric Seidel.
1985
1986         https://bugs.webkit.org/show_bug.cgi?id=31047
1987         [GTK] Failing test media/video-played-ranges-1.html
1988
1989         WebKit coding style fixes.
1990
1991         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1992         (WebCore::mediaPlayerPrivateMessageCallback):
1993         (WebCore::MediaPlayerPrivate::naturalSize):
1994         (WebCore::MediaPlayerPrivate::paint):
1995         (WebCore::mimeTypeCache):
1996
1997 2009-11-10  Oliver Hunt  <oliver@apple.com>
1998
1999         Remove build failure introduced by earlier build fix.
2000
2001         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2002
2003 2009-11-10  Oliver Hunt  <oliver@apple.com>
2004
2005         Is this the last build fix? grep tells me yes.
2006
2007         * bindings/v8/custom/V8DocumentCustom.cpp:
2008         (WebCore::CALLBACK_FUNC_DECL):
2009
2010 2009-11-10  Oliver Hunt  <oliver@apple.com>
2011
2012         Hopefully the last one.  Why aren't these autogenerated?
2013
2014         * bindings/v8/V8DOMWrapper.cpp:
2015         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2016         (WebCore::V8DOMWrapper::getTemplate):
2017         (WebCore::V8DOMWrapper::convertToV8Object):
2018
2019 2009-11-10  Oliver Hunt  <oliver@apple.com>
2020
2021         Another chrome build fix.
2022
2023         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2024         (WebCore::CALLBACK_FUNC_DECL):
2025
2026 2009-11-10  Oliver Hunt  <oliver@apple.com>
2027
2028         Yet another chrome buildfix
2029
2030         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2031         (WebCore::CALLBACK_FUNC_DECL):
2032         * bindings/v8/custom/V8WebGLArrayCustom.h:
2033         (WebCore::constructCanvasArray):
2034         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2035         (WebCore::CALLBACK_FUNC_DECL):
2036         (WebCore::INDEXED_PROPERTY_GETTER):
2037         (WebCore::INDEXED_PROPERTY_SETTER):
2038         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2039         (WebCore::CALLBACK_FUNC_DECL):
2040         (WebCore::INDEXED_PROPERTY_GETTER):
2041         (WebCore::INDEXED_PROPERTY_SETTER):
2042         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2043         (WebCore::CALLBACK_FUNC_DECL):
2044         (WebCore::INDEXED_PROPERTY_GETTER):
2045         (WebCore::INDEXED_PROPERTY_SETTER):
2046         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2047         (WebCore::CALLBACK_FUNC_DECL):
2048         (WebCore::vertexAttribAndUniformHelperf):
2049         (WebCore::uniformHelperi):
2050         (WebCore::uniformMatrixHelper):
2051         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2052         (WebCore::CALLBACK_FUNC_DECL):
2053         (WebCore::INDEXED_PROPERTY_GETTER):
2054         (WebCore::INDEXED_PROPERTY_SETTER):
2055         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2056         (WebCore::CALLBACK_FUNC_DECL):
2057         (WebCore::INDEXED_PROPERTY_GETTER):
2058         (WebCore::INDEXED_PROPERTY_SETTER):
2059         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2060         (WebCore::CALLBACK_FUNC_DECL):
2061         (WebCore::INDEXED_PROPERTY_GETTER):
2062         (WebCore::INDEXED_PROPERTY_SETTER):
2063         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2064         (WebCore::CALLBACK_FUNC_DECL):
2065         (WebCore::INDEXED_PROPERTY_GETTER):
2066         (WebCore::INDEXED_PROPERTY_SETTER):
2067
2068 2009-11-10  Oliver Hunt  <oliver@apple.com>
2069
2070         Chrome build fix.
2071
2072         * bindings/v8/V8Index.h:
2073
2074 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2075
2076         Reviewed by Reviewed by Jan Alonzo.
2077
2078         https://bugs.webkit.org/show_bug.cgi?id=30901
2079         [Gtk] Need to de-lint the Atk a11y code
2080
2081         Removal of various and sundry style-violating nits.
2082
2083         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2084
2085 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2086
2087         Reviewed by Jan Alonzo.
2088
2089         https://bugs.webkit.org/show_bug.cgi?id=31047
2090         [GTK] Failing test media/video-played-ranges-1.html
2091
2092         Fix playback rate setter by remembering the rate was changed. Also
2093         correctly handle reverse playback by doing a seek from end to
2094         beginning of the media.
2095
2096         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2097         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2098         (WebCore::MediaPlayerPrivate::currentTime):
2099         (WebCore::MediaPlayerPrivate::seek):
2100         (WebCore::MediaPlayerPrivate::hasAudio):
2101         (WebCore::MediaPlayerPrivate::setVolume):
2102         (WebCore::MediaPlayerPrivate::setRate):
2103         (WebCore::MediaPlayerPrivate::updateStates):
2104         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2105
2106 2009-11-10  Oliver Hunt  <oliver@apple.com>
2107
2108         Reviewed by Maciej Stachowiak.
2109
2110         Rename 3D Canvas related classes to use WebGL prefix
2111         https://bugs.webkit.org/show_bug.cgi?id=29095
2112
2113         Automatic rename of all WebGL related types from Canvas* to
2114         WebGL* per more recent version of the WebGL spec.
2115
2116         Due to the automatic rename I've removed the 600+ line change list.
2117
2118 2009-11-09  Dirk Schulze  <krit@webkit.org>
2119
2120         Reviewed by Oliver Hunt.
2121
2122         SVG feDisplacementMap is not implemented
2123         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2124
2125         This is the implementation of the SVG filter effect
2126         feDisplacementMap. 
2127
2128         Test: svg/filters/feDisplacementMap.svg
2129
2130         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2131         (WebCore::FEDisplacementMap::apply):
2132
2133 2009-11-09  Kent Tamura  <tkent@chromium.org>
2134
2135         Reviewed by Darin Adler.
2136
2137         Add a comment about null strings and hash functions.
2138         https://bugs.webkit.org/show_bug.cgi?id=29118
2139
2140         * platform/text/StringHash.h:
2141
2142 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2143
2144         Reviewed by Darin Adler.
2145
2146         Compiler warnings in InspectorResource.h
2147         https://bugs.webkit.org/show_bug.cgi?id=29231
2148
2149         Fix compilation warnings by removing addition operation on an enum type.
2150
2151         * inspector/InspectorResource.h:
2152         (WebCore::InspectorResource::):
2153         (WebCore::InspectorResource::Changes::hasChange):
2154         (WebCore::InspectorResource::Changes::set):
2155         (WebCore::InspectorResource::Changes::setAll):
2156
2157 2009-11-09  Anders Carlsson  <andersca@apple.com>
2158
2159         Reviewed by Darin Adler and Dan Bernstein.
2160
2161         <rdar://problem/7328395>
2162         https://bugs.webkit.org/show_bug.cgi?id=31277
2163
2164         When an object tag's style changes (for example when child nodes are added/removed),
2165         reuse its Frame (if it has one) instead of creating multiple Frames.
2166
2167         Test: fast/dom/HTMLObjectElement/children-changed.html
2168
2169         * loader/FrameLoader.cpp:
2170         (WebCore::FrameLoader::requestObject):
2171
2172 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2173
2174         Reviewed by Kenneth Rohde Christiansen.
2175
2176         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2177         since adjustment of RW-section base address will be needed for all new symbian
2178         tool chains, specifically for arm and gcc compilation targets.
2179         Also, change target address to 0xE00000 to be sufficient for all targets.
2180
2181         * WebCore.pro:
2182
2183 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2184
2185         Reviewed by Timothy Hatcher.
2186
2187         Web Inspector: Crash when inspecting
2188         WebCore\manual-tests\inspector\dom-mutation.html
2189
2190         https://bugs.webkit.org/show_bug.cgi?id=31259
2191
2192         * inspector/InspectorDOMAgent.cpp:
2193         (WebCore::InspectorDOMAgent::handleEvent):
2194
2195 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2196
2197         Reviewed by Kenneth Rohde Christiansen.
2198
2199         [Qt] Few classes have virtual functions but non-virtual destructor
2200         https://bugs.webkit.org/show_bug.cgi?id=31269
2201
2202         No new tests as there is no functional change.
2203
2204         * platform/qt/QWebPageClient.h:
2205         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2206
2207 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2208
2209         Reviewed by Kenneth Rohde Christiansen.
2210
2211         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2212         https://bugs.webkit.org/show_bug.cgi?id=31140
2213
2214         QtNetwork interprets null string as request to remove the header, not add it.
2215         Replace null values with empty values before passing them to QtNetwork.
2216
2217         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2218
2219         * platform/network/qt/ResourceRequestQt.cpp:
2220         (WebCore::ResourceRequest::toNetworkRequest):
2221
2222 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2223
2224         Reviewed by Kevin Ollivier.
2225
2226         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2227         simply ignored before resulting in transparent areas being black in PNG
2228         images for example.
2229         
2230         https://bugs.webkit.org/show_bug.cgi?id=30823
2231
2232         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2233         (WebCore::RGBA32Buffer::asNewNativeImage):
2234
2235 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2236
2237         Reviewed by Kenneth Rohde Christiansen.
2238
2239         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2240         https://bugs.webkit.org/show_bug.cgi?id=31040
2241
2242         No new tests as there is no functional change.
2243
2244         * dom/Document.cpp:
2245         (WebCore::Document::recalcStyleSelector):
2246         * editing/TextIterator.cpp:
2247         (WebCore::pushFullyClippedState):
2248         * editing/VisibleSelection.cpp:
2249         (WebCore::VisibleSelection::appendTrailingWhitespace):
2250         * html/HTMLLinkElement.cpp:
2251         (WebCore::HTMLLinkElement::process):
2252         * loader/RedirectScheduler.cpp:
2253         (WebCore::RedirectScheduler::mustLockBackForwardList):
2254         * loader/appcache/ApplicationCacheGroup.cpp:
2255         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2256         * platform/graphics/qt/FontCacheQt.cpp:
2257         (WebCore::FontPlatformDataCacheKey::computeHash):
2258         * rendering/RenderBlock.cpp:
2259         (WebCore::RenderBlock::handleRunInChild):
2260         * rendering/RenderBox.cpp:
2261         (WebCore::RenderBox::calcHeight):
2262         * rendering/RenderTextControlMultiLine.cpp:
2263         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2264         * rendering/style/RenderStyle.cpp:
2265         (WebCore::RenderStyle::diff):
2266         * svg/SVGAnimateElement.cpp:
2267         (WebCore::parseNumberValueAndUnit):
2268         * svg/SVGAnimationElement.cpp:
2269         (WebCore::SVGAnimationElement::startedActiveInterval):
2270         * svg/SVGPreserveAspectRatio.cpp:
2271         (WebCore::SVGPreserveAspectRatio::getCTM):
2272
2273 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2274
2275         Reviewed by Dimitri Glazkov.
2276
2277         Win chromium is slow to draw transparent texts
2278         https://bugs.webkit.org/show_bug.cgi?id=31258
2279
2280         Clip graphics context to reduce calculation.
2281
2282         No new tests because this change only affects performance.
2283
2284         * platform/graphics/chromium/FontChromiumWin.cpp:
2285         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2286         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2287
2288 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2289
2290         Reviewed by Darin Adler.
2291
2292         showTree(CounterNode*) generates too little info and has too many spaces.
2293         https://bugs.webkit.org/show_bug.cgi?id=31212
2294
2295         No new tests as the change has no functional effect it is just for
2296         improved debugging.
2297
2298         * rendering/CounterNode.cpp:
2299         (WebCore::showTreeAndMark):
2300         Changed to also show addresses of parent, next and previous
2301         siblings.
2302
2303 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2304
2305         Reviewed by Darin Adler.
2306
2307         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2308         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2309
2310         https://bugs.webkit.org/show_bug.cgi?id=31083
2311
2312         No new tests; implementation is unchanged.
2313
2314         * page/Frame.cpp:
2315         (WebCore::Frame::setUseSecureKeyboardEntry):
2316         * page/mac/FrameMac.mm:
2317
2318 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2319
2320         Reviewed by Jan Alonzo.
2321
2322         Make XP_UNIX tests consistent
2323         https://bugs.webkit.org/show_bug.cgi?id=31250
2324
2325         No new tests as there is no functional change.
2326
2327         * plugins/PluginView.cpp:
2328         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2329         instead of the value of the macro
2330
2331         * plugins/gtk/PluginViewGtk.cpp:
2332         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2333         defined instead of using the PLATFORM macro to be consistent
2334         (WebCore::PluginView::getValue): Ditto.
2335
2336 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2337
2338         Reviewed by Darin Adler.
2339
2340         Thunk to the main thread from ~Database to deref Database's m_document.
2341
2342         If the Database was the Document's last referrer, then ~Document occurs on the
2343         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2344         ASSERT in debug builds.
2345
2346         * storage/Database.cpp:
2347         (WebCore::derefDocument):
2348         (WebCore::Database::~Database):
2349
2350 2009-11-09  Mark Mentovai  <mark@chromium.org>
2351
2352         Reviewed by Dan Bernstein.
2353
2354         Track "can have scrollbar" state within FrameView independently of the
2355         individual scrollbar states in ScrollView.
2356
2357         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2358         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2359         edit mode.
2360
2361         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2362         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2363
2364         Test: fast/overflow/scrollbar-restored.html
2365
2366         * WebCore.base.exp:
2367         * page/FrameView.cpp:
2368         (WebCore::FrameView::FrameView):
2369         (WebCore::FrameView::resetScrollbars):
2370         (WebCore::FrameView::setCanHaveScrollbars):
2371         (WebCore::FrameView::updateCanHaveScrollbars):
2372         (WebCore::FrameView::layout):
2373         * page/FrameView.h:
2374         * platform/ScrollView.h:
2375
2376 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2377
2378         Reviewed by Timothy Hatcher.
2379
2380         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2381         https://bugs.webkit.org/show_bug.cgi?id=31257
2382
2383         * inspector/front-end/SourceFrame.js:
2384
2385 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2386
2387         Reviewed by Timothy Hatcher.
2388
2389         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2390         https://bugs.webkit.org/show_bug.cgi?id=31252
2391
2392         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2393
2394         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2395
2396         * inspector/front-end/ConsoleView.js:
2397         (WebInspector.ConsoleView.prototype._promptKeyDown):
2398         * inspector/front-end/utilities.js:
2399         ():
2400         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2401
2402 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2403
2404         Reviewed by Kenneth Rohde Christiansen.
2405
2406         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2407         https://bugs.webkit.org/show_bug.cgi?id=31208
2408
2409         After r42483, the credentials are no longer passed to the network request
2410         in the URL of the request.
2411         Pass the credentials from XMLHTTPRequest to the network request, the same
2412         way that other ports do.
2413
2414         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2415
2416         * platform/network/qt/ResourceHandleQt.cpp:
2417         (WebCore::ResourceHandle::start):
2418         (WebCore::ResourceHandle::loadResourceSynchronously):
2419
2420 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2421
2422         Unreviewed.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=31161
2425
2426         Roll back r50657 because it breaks the MAC builds.
2427
2428         * loader/ImageLoader.cpp:
2429         * loader/ProgressTracker.cpp:
2430         * loader/RedirectScheduler.cpp:
2431         * loader/Request.h:
2432         * loader/ThreadableLoaderClient.h:
2433         * loader/WorkerThreadableLoader.h:
2434         * loader/appcache/ApplicationCacheHost.h:
2435         * loader/appcache/ApplicationCacheStorage.h:
2436         * loader/icon/IconDatabaseClient.h:
2437
2438 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2439
2440         Reviewed by Darin Adler.
2441
2442         Allow custom memory allocation control for the part of loader directory in WebCore
2443         https://bugs.webkit.org/show_bug.cgi?id=31161
2444
2445         Inherits the following classes from Noncopyable because these are instantiated
2446         by 'new' and these are no need to be copyable:
2447
2448         class Request - WebCore/loader/loader.cpp:100
2449         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2450         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2451         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2452         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2453         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2454         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2455
2456         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2457         MainThreadBridge is instantiated by 'new' in 
2458         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2459
2460         ThreadableLoaderClient's inheriting has been changed to public.
2461
2462         * loader/ImageLoader.cpp:
2463         * loader/ProgressTracker.cpp:
2464         * loader/RedirectScheduler.cpp:
2465         * loader/Request.h:
2466         * loader/ThreadableLoaderClient.h:
2467         * loader/WorkerThreadableLoader.h:
2468         * loader/appcache/ApplicationCacheHost.h:
2469         * loader/appcache/ApplicationCacheStorage.h:
2470         * loader/icon/IconDatabaseClient.h:
2471
2472 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2473
2474         Reviewed by Darin Adler.
2475
2476         Allow custom memory allocation control for WebCore's DocLoader
2477         https://bugs.webkit.org/show_bug.cgi?id=31163
2478
2479         Inherits DocLoader class from Noncopyable because it is
2480         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2481         it is no need to be copyable.
2482
2483         * loader/DocLoader.h:
2484
2485 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2486
2487         Reviewed by Darin Adler.
2488
2489         Allow custom memory allocation control for WebCore's Tokenizer
2490         https://bugs.webkit.org/show_bug.cgi?id=31162
2491
2492         Inherits Tokenizer class from Noncopyable because (its child class)
2493         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2494         and it is no need to be copyable.
2495
2496         * dom/Tokenizer.h:
2497
2498 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2499
2500         Reviewed by Darin Adler.
2501
2502         Allow custom memory allocation control for WebCore's DeleteButtonController
2503         https://bugs.webkit.org/show_bug.cgi?id=31105
2504
2505         Inherits DeleteButtonController class from Noncopyable because it is 
2506         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2507         it is no need to be copyable.  
2508
2509         * editing/DeleteButtonController.h:
2510
2511 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2512
2513         Reviewed by Jan Alonzo.
2514
2515         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2516         https://bugs.webkit.org/show_bug.cgi?id=30482
2517
2518         Expose Page::tabKeyCyclesThroughElements as a property of
2519         WebKitWebView.
2520
2521         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2522
2523         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2524         (WebCore::singleCharacterString):
2525
2526 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2527
2528         Reviewed by Xan Lopez.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=25415
2531         [GTK][ATK] Please implement support for get_text_at_offset
2532
2533         Fix a crasher that occurred with text which included newline
2534         chars in the markup.
2535
2536         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2537         (convertUniCharToUTF8):
2538
2539 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2540
2541         Reviewed by Holger Freyther.
2542
2543         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2544         https://bugs.webkit.org/show_bug.cgi?id=31144
2545
2546         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2547         documents that end prematurely but are not considered invalid by QXmlStream.
2548         This is to stay compatible with the libxml2 implementation.
2549         However, that code path would be also hit in situations when it should not,
2550         i.e. the error would have already been caught and handled. As a result, the
2551         same error would be reported twice.
2552
2553         No new tests, because the problem is already covered by
2554         fast/parser/xml-declaration-missing-ending-mark.html.
2555
2556         * dom/XMLTokenizerQt.cpp:
2557         (WebCore::XMLTokenizer::doEnd):
2558
2559 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2560
2561         Reviewed by Pavel Feldman.
2562
2563         Web Inspector: Inspector should support copy() in the command line
2564         https://bugs.webkit.org/show_bug.cgi?id=31238
2565
2566         * inspector/InspectorBackend.cpp:
2567         (WebCore::InspectorBackend::copyText): Added.
2568         * inspector/InspectorBackend.h: Added copyText
2569         * inspector/InspectorBackend.idl: Added copyText
2570         * inspector/front-end/InjectedScript.js:
2571         (InjectedScript._copy): Added.
2572         (InjectedScript._ensureCommandLineAPIInstalled):
2573
2574 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2575
2576         Reviewed by Dimitri Glazkov.
2577
2578         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2579         https://bugs.webkit.org/show_bug.cgi?id=31226
2580
2581         Now checks to see what type of context is active and creates the
2582         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2583
2584         Added support for converting to SharedWorkers and SharedWorkerContexts.
2585
2586         Test: Existing layout tests cover this case (start passing in Chrome).
2587
2588         * bindings/v8/WorkerContextExecutionProxy.cpp:
2589         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2590         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2591         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2592         Added support for SHAREDWORKERCONTEXT.
2593         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2594         Added support for SharedWorker and SharedWorkerContext.
2595
2596 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2597
2598         Reviewed by Dimitri Glazkov.
2599
2600         https://bugs.webkit.org/show_bug.cgi?id=31224
2601         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2602
2603         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2604
2605         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2606         (WebCore::NAMED_PROPERTY_GETTER):
2607
2608 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2609
2610         Reviewed by Timothy Hatcher.
2611
2612         Web Inspector: "Search again" on scripts panel switches
2613         to the script this search started with.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=31243
2616
2617         * inspector/front-end/Panel.js:
2618         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2619
2620 2009-11-08  Kent Tamura  <tkent@chromium.org>
2621
2622         Reviewed by Darin Adler.
2623
2624         Simplify Icon interface.
2625         https://bugs.webkit.org/show_bug.cgi?id=31154
2626
2627         - Remove Icon::createIconForFile().  createIconForFiles() covers
2628           createIconForFile()'s role.
2629         - Remove FileChooser::chooseIcon()
2630         - Change the parameter types of FileChooser constructor and the
2631           factory method, String -> const Vector<String>&, in order to
2632           support initialization with multiple files.
2633         - Remove the icon loading code in IconChromiumWin.cpp, which
2634           doesn't work because of the sandbox.
2635
2636         No tests because it's just a refactoring.
2637
2638         * platform/FileChooser.cpp:
2639         (WebCore::FileChooser::FileChooser):
2640         (WebCore::FileChooser::create):
2641         (WebCore::FileChooser::chooseFile):
2642         (WebCore::FileChooser::chooseFiles):
2643         * platform/FileChooser.h:
2644         * platform/graphics/Icon.h:
2645         * platform/graphics/chromium/IconChromiumLinux.cpp:
2646         * platform/graphics/chromium/IconChromiumMac.cpp:
2647         * platform/graphics/chromium/IconChromiumWin.cpp:
2648         (WebCore::Icon::createIconForFiles):
2649         * platform/graphics/gtk/IconGtk.cpp:
2650         (WebCore::Icon::createIconForFiles):
2651         * platform/graphics/haiku/IconHaiku.cpp:
2652         * platform/graphics/mac/IconMac.mm:
2653         (WebCore::Icon::createIconForFiles):
2654         * platform/graphics/qt/IconQt.cpp:
2655         (WebCore::Icon::createIconForFiles):
2656         * platform/graphics/win/IconWin.cpp:
2657         (WebCore::Icon::createIconForFiles):
2658         * platform/graphics/wx/IconWx.cpp:
2659         * rendering/RenderFileUploadControl.cpp:
2660         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2661
2662 2009-11-08  Daniel Bates  <dbates@webkit.org>
2663
2664         Reviewed by Adam Barth.
2665
2666         https://bugs.webkit.org/show_bug.cgi?id=31098
2667
2668         Allows same-origin plugin-based content to load.
2669
2670         Test: http/tests/security/xssAuditor/object-src-inject.html
2671
2672         * page/XSSAuditor.cpp:
2673         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2674         (WebCore::XSSAuditor::canLoadObject): Ditto.
2675         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2676         (WebCore::XSSAuditor::isSameOriginResource): Added.
2677         * page/XSSAuditor.h:
2678
2679 2009-11-08  David Levin  <levin@chromium.org>
2680
2681         Reviewed by NOBODY (chromium build fix).
2682
2683         * platform/network/HTTPParsers.cpp:
2684         (WebCore::parseDate): Changed this to not
2685         use a date parser that needs ExecState passed.
2686         
2687 2009-11-08  David Levin  <levin@chromium.org>
2688
2689         Unreviewed build fix for chromium.
2690
2691         * platform/graphics/skia/GraphicsContextSkia.cpp:
2692         (WebCore::GraphicsContext::fillPath):
2693         (WebCore::GraphicsContext::fillRect):
2694         (WebCore::GraphicsContext::strokePath):
2695         (WebCore::GraphicsContext::strokeRect):
2696
2697 2009-11-08  David Levin  <levin@chromium.org>
2698
2699         Unreviewed build fix for chromium.
2700
2701         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2702         Clean up GraphicsContext's current concept of ColorSpace
2703
2704         * platform/graphics/skia/GraphicsContextSkia.cpp:
2705         (WebCore::GraphicsContext::fillPath):
2706         (WebCore::GraphicsContext::fillRect):
2707         (WebCore::GraphicsContext::strokePath):
2708         (WebCore::GraphicsContext::strokeRect):
2709
2710 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2711
2712         Reviewed by Timothy Hatcher.
2713
2714         Web Inspector: [REGRESSION] committing style edit
2715         clears elements panel selection.
2716
2717         https://bugs.webkit.org/show_bug.cgi?id=31242
2718
2719         * inspector/front-end/ElementsTreeOutline.js:
2720         (WebInspector.ElementsTreeOutline.prototype.update):
2721         * inspector/front-end/StylesSidebarPane.js:
2722         (WebInspector.StylePropertyTreeElement.prototype.):
2723         (WebInspector.StylePropertyTreeElement.prototype):
2724
2725 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2726
2727         Reviewed by Holger Freyther.
2728
2729         ResourceRequest to be class instead of struct
2730         https://bugs.webkit.org/show_bug.cgi?id=30670
2731
2732         Started as a compilation fix for Symbian where the compiler makes a distinction between
2733         class and struct in function argument signatures.
2734         Changed all forward declarations of ResourceRequest to have class in the forward
2735         declaration instead of struct and changed the definition of ResourceRequest to be class
2736         and added access qualifiers where missing. Additionally two references of friend
2737         struct ResourceRequestBase changed to class instead.
2738
2739         * history/HistoryItem.h:
2740         * inspector/InspectorController.h:
2741         * inspector/InspectorResource.h:
2742         * loader/DocumentThreadableLoader.h:
2743         * loader/FrameLoaderClient.h:
2744         * loader/MainResourceLoader.h:
2745         * loader/ResourceLoadNotifier.h:
2746         * loader/SubresourceLoader.h:
2747         * loader/SubresourceLoaderClient.h:
2748         * loader/ThreadableLoader.h:
2749         * loader/WorkerThreadableLoader.h:
2750         * loader/appcache/ApplicationCache.h:
2751         * loader/appcache/ApplicationCacheHost.h:
2752         * platform/CrossThreadCopier.h:
2753         * platform/network/ResourceHandle.h:
2754         * platform/network/ResourceHandleClient.h:
2755         * platform/network/ResourceRequestBase.h:
2756         * platform/network/cf/ResourceRequest.h:
2757         * platform/network/cf/ResourceRequestCFNet.h:
2758         * platform/network/chromium/ResourceRequest.h:
2759         * platform/network/curl/ResourceRequest.h:
2760         * platform/network/qt/ResourceRequest.h:
2761         * platform/network/soup/ResourceRequest.h:
2762         * xml/XMLHttpRequest.h:
2763
2764 2009-11-08  Dan Bernstein  <mitz@apple.com>
2765
2766         Reviewed by Simon Fraser.
2767
2768         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2769         below FrameView::layout
2770         https://bugs.webkit.org/show_bug.cgi?id=31093
2771
2772         Test: fast/block/positioning/relative-positioned-inline-container.html
2773
2774         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2775         to mark the object for layout, doing so without marking its ancestors.
2776         However, RenderBlock::skipLeadingWhitespace and
2777         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2778         positioned inline container, causing it to be marked for layout without
2779         ever going back to give it layout, and thus layout could end with a
2780         dirty object still in the tree, leading to all sorts of badness.
2781
2782         The fix is to revert setStaticY() to not marking the object dirty, and
2783         instead do it in the call sites that require it, which are in
2784         RenderBlock and RenderFlexibleBox.
2785
2786         * rendering/RenderBlock.cpp:
2787         (WebCore::RenderBlock::adjustPositionedBlock):
2788         * rendering/RenderFlexibleBox.cpp:
2789         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2790         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2791         * rendering/RenderLayer.cpp:
2792         * rendering/RenderLayer.h:
2793         (WebCore::RenderLayer::setStaticY):
2794
2795 2009-11-07  Daniel Bates  <dbates@webkit.org>
2796
2797         Reviewed by Darin Adler.
2798
2799         https://bugs.webkit.org/show_bug.cgi?id=20780
2800         
2801         Fixes an issue where the onchange event handler is not fired when the 
2802         input field is autocompleted.
2803         
2804         We cannot test this using DRT since DRT cannot emulate autocompletion.
2805         So, a manual-test is included.
2806
2807         Tests: manual-tests/autocompletion-fire-onchange.html
2808
2809         * manual-tests/autocompletion-fire-onchange.html: Added.
2810         * rendering/RenderTextControl.cpp:
2811         (WebCore::RenderTextControl::setInnerTextValue):
2812
2813 2009-11-07  Benjamin Otte  <otte@gnome.org>
2814
2815         Reviewed by Holger Freyther.
2816
2817         Mark redrawn areas on image surfaces as dirty.
2818
2819         This is required to conform to the Cairo API, but is currently only
2820         used by debugging tools like cairo-trace.
2821
2822         * platform/graphics/cairo/ImageBufferCairo.cpp:
2823         (WebCore::ImageBuffer::platformTransformColorSpace):
2824         (WebCore::putImageData):
2825
2826 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2827
2828         Reviewed by Xan Lopez.
2829
2830         https://bugs.webkit.org/show_bug.cgi?id=30878
2831         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2832
2833         If the end_offset is -1, use the String length as the end_offset.
2834
2835         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2836         (webkit_accessible_text_get_text):
2837
2838 2009-11-06  Beth Dakin  <bdakin@apple.com>
2839
2840         Reviewed by Adele Peterson.
2841
2842         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2843         GraphicsContext's current concept of ColorSpace
2844
2845         ColorSpace is now called ColorType. The variables on the state we 
2846         appropriately re-named as well. I removed strokeColorSpace() and 
2847         fillColorSpace() from GraphicsContext since they were never called. 
2848
2849         * platform/graphics/GraphicsContext.cpp:
2850         (WebCore::GraphicsContext::setStrokeColor):
2851         (WebCore::GraphicsContext::setFillColor):
2852         (WebCore::GraphicsContext::setStrokePattern):
2853         (WebCore::GraphicsContext::setFillPattern):
2854         (WebCore::GraphicsContext::setStrokeGradient):
2855         (WebCore::GraphicsContext::setFillGradient):
2856         * platform/graphics/GraphicsContext.h:
2857         (WebCore::):
2858         * platform/graphics/GraphicsContextPrivate.h:
2859         (WebCore::GraphicsContextState::GraphicsContextState):
2860         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2861         (WebCore::GraphicsContext::fillPath):
2862         (WebCore::GraphicsContext::strokePath):
2863         * platform/graphics/cg/GraphicsContextCG.cpp:
2864         (WebCore::calculateDrawingMode):
2865         (WebCore::GraphicsContext::drawPath):
2866         (WebCore::GraphicsContext::fillPath):
2867         (WebCore::GraphicsContext::strokePath):
2868         (WebCore::GraphicsContext::fillRect):
2869         (WebCore::GraphicsContext::strokeRect):
2870         * platform/graphics/qt/GraphicsContextQt.cpp:
2871         (WebCore::GraphicsContext::fillPath):
2872         (WebCore::GraphicsContext::strokePath):
2873         (WebCore::GraphicsContext::fillRect):
2874         * platform/graphics/wince/GraphicsContextWince.cpp:
2875         (WebCore::GraphicsContext::fillPath):
2876         (WebCore::GraphicsContext::fillRect):
2877
2878 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2879
2880         Reviewed by Tim Hatcher.
2881
2882         Fixes <http://webkit.org/b/31177>.
2883         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2884         
2885         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2886         places in the inspector can use editing in DataGrid (added a FIXME for
2887         some stuff that needs to be generalized).
2888         
2889         Also added deleting functionality to DataGrid, and implemented it for
2890         Cookies and DOM Storage. The reason this patch is so big is because of
2891         the refactoring of editing code, which won't be used yet in a cross-datagrid
2892         way, but should be able to.
2893         
2894         Additionally, moved the callbacks members from DOMStorageDataGrid to
2895         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2896         make the architecture of DOM Storage look a lot more like the Cookies view.
2897         
2898         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2899         inspector from beeping at you when you delete an element.
2900
2901         * WebCore.gypi: Removed DOMStorageDataGrid.
2902         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2903         * inspector/front-end/CookieItemsView.js:
2904         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2905         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2906         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2907         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2908         * inspector/front-end/DOMStorageItemsView.js:
2909         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2910         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2911         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2912         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2913         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2914         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2915         * inspector/front-end/DataGrid.js:
2916         (WebInspector.DataGrid):
2917         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2918         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2919         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2920         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2921         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2922         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2923         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2924         * inspector/front-end/ElementsTreeOutline.js:
2925         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2926         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2927         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2928
2929 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2930
2931         Qt build fix: added an ExecState parameter.
2932
2933         * bridge/qt/qt_runtime.cpp:
2934         (JSC::Bindings::convertValueToQVariant):
2935         (JSC::Bindings::convertQVariantToValue):
2936
2937 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2938
2939         https://bugs.webkit.org/show_bug.cgi?id=31197
2940         Implemented a timezone cache not based on Mac OS X's notify_check API.
2941
2942         Updated for JavaScriptCore internal API change.
2943
2944         * bridge/qt/qt_runtime.cpp:
2945         (JSC::Bindings::convertValueToQVariant):
2946         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2947
2948         * platform/network/HTTPParsers.cpp:
2949         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2950         (This function probably shouldn't be using a JavaScript date parser
2951         to begin with, but oh well.)
2952
2953 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2954
2955         Reviewed by Adam Barth.
2956
2957         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2958         which affects Chromium only.
2959         
2960         Changes to V8HTMLDocumentCustom.cpp are as below:-
2961         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2962            there was no calling javascript context. We now check for this case
2963            and pass in NULL to the HTMLDocument::open function which can handle
2964            a NULL document parameter.
2965         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2966            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2967            anyway. We now check for this case and return a failure.
2968            
2969         Changes to V8DOMWindowCustom.cpp are as below:-
2970         1. Instead of failing the window.open call made by NPAPI for lack of a
2971            calling javascript context, we now use the entered context as the calling
2972            context.
2973
2974         Tests: plugins/document-open.html
2975                plugins/window-open.html
2976
2977         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2978         (WebCore::CALLBACK_FUNC_DECL):
2979         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2980         (WebCore::CALLBACK_FUNC_DECL):
2981
2982 2009-11-06  Steve Block  <steveblock@google.com>
2983
2984         Reviewed by Eric Seidel.
2985
2986         Geolocation error code UNKNOWN_ERROR is deprecated.
2987         https://bugs.webkit.org/show_bug.cgi?id=31184
2988
2989         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2990
2991         Updated fast/dom/Geolocation/error.html to test this.
2992
2993         * page/PositionError.h: Modified.
2994         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2995         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2996         * page/Geolocation.cpp: Modified.
2997         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2998         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2999         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3000
3001 2009-11-06  Dirk Schulze  <krit@webkit.org>
3002
3003         Reviewed by Nikolas Zimmermann.
3004
3005         feMorphology filter is not implemented
3006         [https://bugs.webkit.org/show_bug.cgi?id=5863]
3007
3008         The Implementation of feMorphology.
3009         
3010         Test: We have allready a test for feMorphology
3011               svg/W3C-SVG-1.1/filters-morph-01-f.svg
3012
3013         * svg/graphics/filters/SVGFEMorphology.cpp:
3014         (WebCore::FEMorphology::apply):
3015
3016 2009-11-06  Steve Block  <steveblock@google.com>
3017
3018         Reviewed by Eric Seidel.
3019
3020         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3021         https://bugs.webkit.org/show_bug.cgi?id=31209
3022
3023         Build fix only. No new tests possible.
3024
3025         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3026
3027 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3028
3029         Reviewed by David Levin.
3030
3031         V8 bindings do not support SharedWorkers as event targets
3032         https://bugs.webkit.org/show_bug.cgi?id=31199
3033
3034         No new tests because existing layout tests suffice (they currently
3035         crash on Chromium)
3036
3037         * bindings/v8/V8DOMWrapper.cpp:
3038         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3039         Added clause to create a DOM wrapper for SharedWorkers.
3040
3041 2009-11-06  Anton Muhin  <antonm@chromium.org>
3042
3043         Reviewed by Adam Barth.
3044
3045         Do not unnecessarly synchronzie in weak reference callbacks.
3046         https://bugs.webkit.org/show_bug.cgi?id=31191
3047
3048         * bindings/v8/DOMData.h:
3049         (WebCore::DOMData::handleWeakObject):
3050
3051 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3052
3053         Reviewed by Pavel Feldman.
3054
3055         Fix resource content search.
3056         https://bugs.webkit.org/show_bug.cgi?id=31202
3057
3058         * inspector/front-end/AbstractTimelinePanel.js:
3059         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3060         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3061         * inspector/front-end/TimelinePanel.js:
3062         (WebInspector.TimelineGraph.prototype.refresh):
3063
3064 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3065
3066         Reviewed by Eric Seidel.
3067
3068         Fix ASSERT(currentStyle = renderStyle()).
3069         https://bugs.webkit.org/show_bug.cgi?id=31152
3070
3071         * dom/Element.cpp:
3072         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3073
3074 2009-11-05  Alpha Lam  <hclam@chromium.org>
3075
3076         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3077
3078         * bindings/v8/V8GCController.cpp:
3079         (WebCore::V8GCController::gcEpilogue):
3080         * bindings/v8/V8GCController.h:
3081         * bindings/v8/V8Proxy.cpp:
3082         (WebCore::V8Proxy::evaluate):
3083         (WebCore::V8Proxy::runScript):
3084         (WebCore::V8Proxy::callFunction):
3085
3086 2009-11-05  Adam Barth  <abarth@webkit.org>
3087
3088         Reviewed by Sam Weinig.
3089
3090         Cross-domain access to stylesheet text should not be allowed
3091         https://bugs.webkit.org/show_bug.cgi?id=20527
3092
3093         Check whether whether the current document can read the cssRules from
3094         the style sheet.  Firefox throws a security error here, but we return
3095         null instead because that's what we usually do in these cases.
3096
3097         Test: http/tests/security/cannot-read-cssrules-redirect.html
3098               http/tests/security/cannot-read-cssrules.html
3099
3100         * css/CSSStyleSheet.cpp:
3101         (WebCore::CSSStyleSheet::cssRules):
3102
3103 2009-11-05  Steve Block  <steveblock@google.com>
3104
3105         Reviewed by Eric Seidel.
3106
3107         If the Geolocation service fails to start, invoke the error callback asynchronously.
3108         https://bugs.webkit.org/show_bug.cgi?id=28276
3109
3110         All Geolocation callbacks must be invoked asynchronously.
3111         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3112
3113         No new tests possible with current LayoutTestController.
3114
3115         * page/Geolocation.cpp:
3116         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3117         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3118         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3119
3120 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3121
3122         Reviewed by Eric Seidel.
3123
3124         Removed the "this is part of the KDE project" comments from 
3125         all *.h, *.cpp, *.idl, and *.pm files.
3126         
3127         https://bugs.webkit.org/show_bug.cgi?id=31167
3128         
3129         The maintenance and architecture page in the project wiki lists
3130         this as a task.
3131         
3132         This change includes no changes or additions to test cases 
3133         since the change affects only comments.
3134
3135         * bindings/scripts/CodeGeneratorV8.pm:
3136         * bindings/scripts/IDLParser.pm:
3137         * bindings/scripts/IDLStructure.pm:
3138         * css/CSSInheritedValue.cpp:
3139         * css/CSSInitialValue.cpp:
3140         * css/CSSMediaRule.cpp:
3141         * css/CSSNamespace.h:
3142         * css/CSSProperty.cpp:
3143         * css/CSSProperty.h:
3144         * css/CSSRuleList.cpp:
3145         * css/CSSRuleList.h:
3146         * css/CSSSelector.h:
3147         * css/CSSValueList.cpp:
3148         * css/FontValue.cpp:
3149         * css/MediaFeatureNames.cpp:
3150         * css/MediaFeatureNames.h:
3151         * css/Pair.h:
3152         * css/SVGCSSStyleSelector.cpp:
3153         * css/ShadowValue.cpp:
3154         * css/StyleSheet.cpp:
3155         * css/StyleSheetList.cpp:
3156         * css/maketokenizer:
3157         * dom/BeforeUnloadEvent.cpp:
3158         * dom/BeforeUnloadEvent.h:
3159         * dom/CSSMappedAttributeDeclaration.cpp:
3160         * dom/EventNames.cpp:
3161         * dom/EventTarget.cpp:
3162         * dom/MappedAttributeEntry.h:
3163         * dom/MouseRelatedEvent.h:
3164         * dom/RangeException.h:
3165         * dom/StyleElement.h:
3166         * dom/Tokenizer.h:
3167         * html/HTMLHeadElement.h:
3168         * html/HTMLHeadingElement.cpp:
3169         * html/HTMLHeadingElement.h:
3170         * html/HTMLHtmlElement.h:
3171         * html/HTMLImageLoader.h:
3172         * html/HTMLMetaElement.h:
3173         * html/HTMLModElement.cpp:
3174         * html/HTMLModElement.h:
3175         * html/HTMLOptionsCollection.cpp:
3176         * html/HTMLPlugInElement.cpp:
3177         * html/HTMLPreElement.cpp:
3178         * html/HTMLPreElement.h:
3179         * html/HTMLTableCellElement.cpp:
3180         * html/HTMLTableCellElement.h:
3181         * html/HTMLTableColElement.cpp:
3182         * html/HTMLTableColElement.h:
3183         * html/HTMLTablePartElement.cpp:
3184         * html/HTMLTablePartElement.h:
3185         * html/HTMLTitleElement.h:
3186         * page/MouseEventWithHitTestResults.h:
3187         * platform/StaticConstructors.h:
3188         * platform/text/AtomicStringImpl.h:
3189         * platform/text/qt/TextBreakIteratorQt.cpp:
3190         * rendering/AutoTableLayout.h:
3191         * rendering/CounterNode.cpp:
3192         * rendering/EllipsisBox.cpp:
3193         * rendering/EllipsisBox.h:
3194         * rendering/FixedTableLayout.cpp:
3195         * rendering/FixedTableLayout.h:
3196         * rendering/HitTestRequest.h:
3197         * rendering/HitTestResult.h:
3198         * rendering/InlineRunBox.h:
3199         * rendering/PointerEventsHitRules.cpp:
3200         * rendering/PointerEventsHitRules.h:
3201         * rendering/RenderBR.cpp:
3202         * rendering/RenderBR.h:
3203         * rendering/RenderButton.cpp:
3204         * rendering/RenderButton.h:
3205         * rendering/RenderFieldset.cpp:
3206         * rendering/RenderFrameSet.cpp:
3207         * rendering/RenderListItem.cpp:
3208         * rendering/RenderTableRow.cpp:
3209         * rendering/RenderView.h:
3210         * rendering/RootInlineBox.h:
3211         * rendering/SVGInlineTextBox.cpp:
3212         * rendering/SVGInlineTextBox.h:
3213         * rendering/TableLayout.h:
3214         * rendering/break_lines.h:
3215         * rendering/style/SVGRenderStyle.cpp:
3216         * rendering/style/SVGRenderStyle.h:
3217         * rendering/style/SVGRenderStyleDefs.cpp:
3218         * rendering/style/SVGRenderStyleDefs.h:
3219         * svg/GradientAttributes.h:
3220         * svg/LinearGradientAttributes.h:
3221         * svg/PatternAttributes.h:
3222         * svg/RadialGradientAttributes.h:
3223         * svg/SVGAElement.cpp:
3224         * svg/SVGAngle.idl:
3225         * svg/SVGAnimateColorElement.cpp:
3226         * svg/SVGAnimateColorElement.h:
3227         * svg/SVGAnimateElement.cpp:
3228         * svg/SVGAnimateElement.h:
3229         * svg/SVGAnimateTransformElement.h:
3230         * svg/SVGAnimatedPathData.cpp:
3231         * svg/SVGAnimatedPathData.h:
3232         * svg/SVGAnimatedPoints.cpp:
3233         * svg/SVGAnimatedPoints.h:
3234         * svg/SVGAnimationElement.cpp:
3235         * svg/SVGCircleElement.cpp:
3236         * svg/SVGClipPathElement.cpp:
3237         * svg/SVGColor.cpp:
3238         * svg/SVGColor.idl:
3239         * svg/SVGComponentTransferFunctionElement.cpp:
3240         * svg/SVGComponentTransferFunctionElement.h:
3241         * svg/SVGCursorElement.cpp:
3242         * svg/SVGDefsElement.cpp:
3243         * svg/SVGDescElement.cpp:
3244         * svg/SVGDescElement.h:
3245         * svg/SVGDocument.idl:
3246         * svg/SVGElement.idl:
3247         * svg/SVGElementInstanceList.cpp:
3248         * svg/SVGElementInstanceList.h:
3249         * svg/SVGEllipseElement.cpp:
3250         * svg/SVGExternalResourcesRequired.cpp:
3251         * svg/SVGFEBlendElement.cpp:
3252         * svg/SVGFEBlendElement.h:
3253         * svg/SVGFEColorMatrixElement.cpp:
3254         * svg/SVGFEColorMatrixElement.h:
3255         * svg/SVGFEComponentTransferElement.cpp:
3256         * svg/SVGFEComponentTransferElement.h:
3257         * svg/SVGFECompositeElement.cpp:
3258         * svg/SVGFECompositeElement.h:
3259         * svg/SVGFEFloodElement.cpp:
3260         * svg/SVGFEFloodElement.h:
3261         * svg/SVGFEFuncAElement.cpp:
3262         * svg/SVGFEFuncAElement.h:
3263         * svg/SVGFEFuncBElement.cpp:
3264         * svg/SVGFEFuncBElement.h:
3265         * svg/SVGFEFuncGElement.cpp:
3266         * svg/SVGFEFuncGElement.h:
3267         * svg/SVGFEFuncRElement.cpp:
3268         * svg/SVGFEFuncRElement.h:
3269         * svg/SVGFEGaussianBlurElement.cpp:
3270         * svg/SVGFEGaussianBlurElement.h:
3271         * svg/SVGFEImageElement.cpp:
3272         * svg/SVGFEMergeElement.cpp:
3273         * svg/SVGFEMergeElement.h:
3274         * svg/SVGFEMergeNodeElement.cpp:
3275         * svg/SVGFEOffsetElement.cpp:
3276         * svg/SVGFEOffsetElement.h:
3277         * svg/SVGFETileElement.cpp:
3278         * svg/SVGFETileElement.h:
3279         * svg/SVGFETurbulenceElement.cpp:
3280         * svg/SVGFETurbulenceElement.h:
3281         * svg/SVGFilterElement.cpp:
3282         * svg/SVGGElement.cpp:
3283         * svg/SVGGradientElement.cpp:
3284         * svg/SVGHKernElement.idl:
3285         * svg/SVGLangSpace.cpp:
3286         * svg/SVGLangSpace.h:
3287         * svg/SVGLength.cpp:
3288         * svg/SVGLength.h:
3289         * svg/SVGLength.idl:
3290         * svg/SVGLengthList.cpp:
3291         * svg/SVGLengthList.h:
3292         * svg/SVGLineElement.cpp:
3293         * svg/SVGLinearGradientElement.h:
3294         * svg/SVGList.h:
3295         * svg/SVGListTraits.h:
3296         * svg/SVGLocatable.h:
3297         * svg/SVGMaskElement.cpp:
3298         * svg/SVGMatrix.idl:
3299         * svg/SVGMetadataElement.cpp:
3300         * svg/SVGMetadataElement.h:
3301         * svg/SVGMetadataElement.idl:
3302         * svg/SVGNumber.idl:
3303         * svg/SVGNumberList.cpp:
3304         * svg/SVGNumberList.h:
3305         * svg/SVGPaint.cpp:
3306         * svg/SVGPathElement.cpp:
3307         * svg/SVGPathSeg.h:
3308         * svg/SVGPathSegArc.cpp:
3309         * svg/SVGPathSegArc.h:
3310         * svg/SVGPathSegClosePath.cpp:
3311         * svg/SVGPathSegClosePath.h:
3312         * svg/SVGPathSegCurvetoCubic.cpp:
3313         * svg/SVGPathSegCurvetoCubic.h:
3314         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3315         * svg/SVGPathSegCurvetoCubicSmooth.h:
3316         * svg/SVGPathSegCurvetoQuadratic.cpp:
3317         * svg/SVGPathSegCurvetoQuadratic.h:
3318         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3319         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3320         * svg/SVGPathSegLineto.cpp:
3321         * svg/SVGPathSegLineto.h:
3322         * svg/SVGPathSegLinetoHorizontal.cpp:
3323         * svg/SVGPathSegLinetoHorizontal.h:
3324         * svg/SVGPathSegLinetoVertical.cpp:
3325         * svg/SVGPathSegLinetoVertical.h:
3326         * svg/SVGPathSegMoveto.cpp:
3327         * svg/SVGPathSegMoveto.h:
3328         * svg/SVGPatternElement.cpp:
3329         * svg/SVGPoint.idl:
3330         * svg/SVGPointList.cpp:
3331         * svg/SVGPointList.h:
3332         * svg/SVGPolyElement.cpp:
3333         * svg/SVGPolygonElement.cpp:
3334         * svg/SVGPolygonElement.h:
3335         * svg/SVGPolylineElement.cpp:
3336         * svg/SVGPolylineElement.h:
3337         * svg/SVGPreserveAspectRatio.cpp:
3338         * svg/SVGPreserveAspectRatio.h:
3339         * svg/SVGRadialGradientElement.h:
3340         * svg/SVGRect.idl:
3341         * svg/SVGRectElement.cpp:
3342         * svg/SVGRenderingIntent.h:
3343         * svg/SVGSVGElement.idl:
3344         * svg/SVGScriptElement.cpp:
3345         * svg/SVGSetElement.cpp:
3346         * svg/SVGSetElement.h:
3347         * svg/SVGStopElement.cpp:
3348         * svg/SVGStringList.cpp:
3349         * svg/SVGStringList.h:
3350         * svg/SVGStylable.cpp:
3351         * svg/SVGStylable.h:
3352         * svg/SVGStyleElement.cpp:
3353         * svg/SVGStyleElement.h:
3354         * svg/SVGStyledElement.h:
3355         * svg/SVGStyledLocatableElement.cpp:
3356         * svg/SVGStyledLocatableElement.h:
3357         * svg/SVGStyledTransformableElement.cpp:
3358         * svg/SVGStyledTransformableElement.h:
3359         * svg/SVGSwitchElement.cpp:
3360         * svg/SVGSymbolElement.cpp:
3361         * svg/SVGTRefElement.cpp:
3362         * svg/SVGTSpanElement.cpp:
3363         * svg/SVGTSpanElement.h:
3364         * svg/SVGTests.h:
3365         * svg/SVGTextElement.cpp:
3366         * svg/SVGTextElement.h:
3367         * svg/SVGTextPathElement.cpp:
3368         * svg/SVGTextPositioningElement.cpp:
3369         * svg/SVGTextPositioningElement.h:
3370         * svg/SVGTitleElement.cpp:
3371         * svg/SVGTitleElement.h:
3372         * svg/SVGTransform.cpp:
3373         * svg/SVGTransform.h:
3374         * svg/SVGTransform.idl:
3375         * svg/SVGTransformList.cpp:
3376         * svg/SVGTransformList.h:
3377         * svg/SVGTransformable.h:
3378         * svg/SVGURIReference.h:
3379         * svg/SVGUnitTypes.h:
3380         * svg/SVGUseElement.cpp:
3381         * svg/SVGViewElement.cpp:
3382         * svg/SVGZoomAndPan.cpp:
3383         * svg/SVGZoomAndPan.h:
3384         * svg/SVGZoomEvent.cpp:
3385
3386 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3387
3388         Reviewed by Dimitri Glazkov.
3389
3390         REGRESSION Clean up security origin usage in DOM Storage.
3391         https://bugs.webkit.org/show_bug.cgi?id=31188
3392
3393         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3394         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3395
3396         Instead of having StorageAreaSync's constructor (which is called in the
3397         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3398         database identifier, simply have StorageAreaImpl pass the identifier into
3399         StorageAreaSync.
3400
3401         No test because there's no change in externally observable behavior.
3402
3403         * storage/StorageAreaImpl.cpp:
3404         (WebCore::StorageAreaImpl::StorageAreaImpl):
3405         * storage/StorageAreaImpl.h:
3406         * storage/StorageAreaSync.cpp:
3407         (WebCore::StorageAreaSync::create):
3408         (WebCore::StorageAreaSync::StorageAreaSync):
3409         * storage/StorageAreaSync.h:
3410
3411 2009-11-05  Scott Violet  <sky@google.com>
3412
3413         Reviewed by Dimitri Glazkov.
3414
3415         Need notification of scrolling frame
3416         https://bugs.webkit.org/show_bug.cgi?id=31145
3417
3418         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3419         the frame scrolls. This will be used to know when history state
3420         needs to be updated.
3421
3422         * loader/FrameLoaderClient.h:
3423         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3424         * page/FrameView.cpp:
3425         (WebCore::FrameView::valueChanged):
3426
3427 2009-11-05  Kenneth Russell  <kbr@google.com>
3428
3429         Reviewed by Dimitri Glazkov.
3430
3431         [V8] Update bindings to use new API for external arrays
3432         https://bugs.webkit.org/show_bug.cgi?id=31181
3433
3434         No new tests; covered by existing WebGL tests.
3435
3436         * bindings/v8/V8DOMWrapper.cpp:
3437         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3438         (WebCore::V8DOMWrapper::getTemplate):
3439         (WebCore::V8DOMWrapper::convertToV8Object):
3440         * bindings/v8/V8DOMWrapper.h:
3441         * bindings/v8/custom/V8CanvasArrayCustom.h:
3442         (WebCore::constructCanvasArray):
3443
3444 2009-11-05  Alpha Lam  <hclam@chromium.org>
3445
3446         Not reviewed, Chromium build fix.
3447
3448         50561 introduces a custom method for SVGMatrix, we need to implement
3449         this in V8.
3450
3451         * bindings/v8/custom/V8CustomBinding.h:
3452         Adding definition for V8SVGMatrixMultiply.
3453         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3454         (WebCore::CALLBACK_FUNC_DECL):
3455         Implement V8SVGMatrixMultiply according to the same method in JSC.
3456
3457 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3458
3459         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3460
3461         * page/DOMWindow.cpp:
3462         (WebCore::DOMWindow::sessionStorage):
3463         * page/Settings.cpp:
3464         (WebCore::Settings::Settings):
3465         (WebCore::Settings::setSessionStorageEnabled):
3466         * page/Settings.h:
3467         (WebCore::Settings::sessionStorageEnabled):
3468
3469 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3470
3471         Reviewed by Timothy Hatcher.
3472
3473         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3474
3475         https://bugs.webkit.org/show_bug.cgi?id=30884
3476
3477         Test: inspector/styles-iframe.html
3478
3479         * inspector/front-end/DOMAgent.js:
3480         (WebInspector.DOMNode):
3481         * inspector/front-end/InjectedScript.js:
3482         (InjectedScript.getStyles):
3483         (InjectedScript.getComputedStyle):
3484         (InjectedScript.addStyleSelector):
3485         * inspector/front-end/TestController.js:
3486         (WebInspector.TestController.prototype.notifyDone):
3487         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3488         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3489         (WebInspector.evaluateForTestInFrontend):
3490
3491 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3492
3493         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3494
3495         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3496         https://bugs.webkit.org/show_bug.cgi?id=31027
3497
3498         Tested by new fast/events/event-listener-map-rehash-crash.html.
3499
3500         EventListenerMap modified to store pointers to listener vectors:
3501         * dom/EventTarget.cpp:
3502         (WebCore::EventTargetData::~EventTargetData):
3503         (WebCore::EventTarget::addEventListener):
3504         (WebCore::EventTarget::removeEventListener):
3505         (WebCore::EventTarget::fireEventListeners):
3506         (WebCore::EventTarget::getEventListeners):
3507         (WebCore::EventTarget::removeAllEventListeners):
3508         * dom/EventTarget.h:
3509
3510         Usages updated after interface changes:
3511         * inspector/InspectorDOMAgent.cpp:
3512         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3513         * svg/SVGUseElement.cpp:
3514         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3515
3516 2009-11-05  Dan Kegel  <dank@chromium.org>
3517
3518         Reviewed by Dmitri Titov.
3519
3520         Add missing initialization for m_createdByParser.
3521         https://bugs.webkit.org/show_bug.cgi?id=31089
3522
3523         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3524
3525         * dom/ProcessingInstruction.cpp:
3526         (WebCore::ProcessingInstruction::ProcessingInstruction):
3527
3528 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3529
3530         Reviewed by Adam Barth.
3531
3532         DOM Storage runtime flag changes
3533         https://bugs.webkit.org/show_bug.cgi?id=30602
3534
3535         Part 2/2.
3536
3537         Revert my changes to Settings and instead implement DOM Storage enabling via
3538         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3539
3540         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3541         LayoutTest visible changes and thus no tests.
3542
3543         * bindings/v8/custom/V8CustomBinding.h:
3544         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3545         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3546         * page/DOMWindow.cpp:
3547         (WebCore::DOMWindow::sessionStorage):
3548         * page/DOMWindow.idl:
3549         * page/Settings.cpp:
3550         (WebCore::Settings::Settings):
3551         * page/Settings.h:
3552         * storage/Storage.cpp:
3553         (WebCore::Storage::setLocalStorageAvailable):
3554         (WebCore::Storage::localStorageAvailable):
3555         (WebCore::Storage::setSessionStorageAvailable):
3556         (WebCore::Storage::sessionStorageAvailable):
3557         * storage/Storage.h:
3558
3559 2009-11-05  Jian Li  <jianli@chromium.org>
3560
3561         Reviewed by Pavel Feldman.
3562
3563         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3564         https://bugs.webkit.org/show_bug.cgi?id=31108
3565
3566         * bindings/v8/V8AbstractEventListener.cpp:
3567         (WebCore::V8AbstractEventListener::invokeEventHandler):
3568         * bindings/v8/V8Utilities.cpp:
3569         (WebCore::reportException):
3570
3571 2009-11-05  Jian Li  <jianli@chromium.org>
3572
3573         Reviewed by Dmitri Titov.
3574
3575         We should not bubble up events if we drag something to an iframe that
3576         has an invalid source.
3577         https://bugs.webkit.org/show_bug.cgi?id=30469
3578
3579         Test: http/tests/misc/bubble-drag-events.html
3580
3581         * page/EventHandler.cpp:
3582         (WebCore::EventHandler::handleDragAndDropForTarget):
3583         (WebCore::EventHandler::updateDragAndDrop):
3584         (WebCore::EventHandler::cancelDragAndDrop):
3585         (WebCore::EventHandler::performDragAndDrop):
3586         * page/EventHandler.h:
3587         (WebCore::EventHandler::):
3588
3589 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3590
3591         Reviewed by Timothy Hatcher.
3592
3593         Web Inspector: speed up Timelines Clear by a factor of thousands.
3594
3595         https://bugs.webkit.org/show_bug.cgi?id=31160
3596
3597         * inspector/front-end/utilities.js:
3598         (Element.prototype.removeChildren):
3599
3600 2009-11-05  Anton Muhin  <antonm@chromium.org>
3601
3602         Reviewed by Adam Barth.
3603
3604         If high memory usage is detected, hint to V8 that it might be due
3605         to external objects retained by V8 objects.
3606         https://bugs.webkit.org/show_bug.cgi?id=31051
3607
3608         * bindings/v8/V8GCController.cpp:
3609         (WebCore::GetMemoryUsageInMB):
3610         (WebCore::V8GCController::gcEpilogue):
3611         (WebCore::V8GCController::checkMemoryUsage):
3612         * bindings/v8/V8GCController.h:
3613         * bindings/v8/V8Proxy.cpp:
3614         (WebCore::V8Proxy::evaluate):
3615         (WebCore::V8Proxy::runScript):
3616         (WebCore::V8Proxy::callFunction):
3617
3618 2009-11-05  Jeff Schiller  <codedread@gmail.com>
3619
3620         Reviewed by Simon Fraser.
3621
3622         Correct order of matrix multiplication for SVGMatrix.
3623         https://bugs.webkit.org/show_bug.cgi?id=16062
3624
3625         Test: svg/dom/SVGMatrix-interface.xhtml
3626
3627         * bindings/js/JSSVGMatrixCustom.cpp:
3628         (WebCore::JSSVGMatrix::multiply):
3629         * svg/SVGMatrix.idl:
3630
3631 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3632
3633         Reviewed by Timothy Hatcher.
3634
3635         Web Inspector: Make resource-related records in timeline
3636         actually take some time.
3637
3638         https://bugs.webkit.org/show_bug.cgi?id=31139
3639
3640         * English.lproj/localizedStrings.js:
3641         * inspector/front-end/TimelinePanel.js:
3642         (WebInspector.TimelinePanel):
3643         (WebInspector.TimelinePanel.prototype._formatRecord):
3644         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3645         (WebInspector.TimelinePanel.prototype.reset):
3646
3647 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>