3d03642d9f89fef7159721a41edb82ccecb669cb
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2
3         Reviewed by Geoff.
4
5         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
6         
7         * platform/network/cf/ResourceHandleCFNet.cpp:
8         (WebCore::addHeadersFromHashMap):
9         Don't set all headers at once since that clears any previous headers set.
10         
11         (WebCore::ResourceHandle::start):
12
13 2006-11-02  Adele Peterson  <adele@apple.com>
14
15         Reviewed by Mitz and Geoff.
16
17         - Fix for:
18         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
19         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
20         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
21
22         Test: fast/forms/textarea-scrollbar.html
23
24         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
25         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
26
27         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
28         * rendering/RenderTextControl.cpp: 
29         (WebCore::RenderTextControl::RenderTextControl):
30         (WebCore::RenderTextControl::setStyle):
31         (WebCore::RenderTextControl::createDivStyle):
32         (WebCore::RenderTextControl::updateFromElement):
33         (WebCore::RenderTextControl::calcHeight):
34         (WebCore::RenderTextControl::baselinePosition):
35         (WebCore::RenderTextControl::nodeAtPoint):
36         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
37         (WebCore::RenderTextControl::scrollWidth):
38         (WebCore::RenderTextControl::scrollHeight):
39         (WebCore::RenderTextControl::scrollLeft):
40         (WebCore::RenderTextControl::scrollTop):
41
42         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
43
44 2006-11-02  John Sullivan  <sullivan@apple.com>
45
46         Reviewed by Geoff Garen
47
48         * editing/Selection.cpp:
49         (WebCore::Selection::showTreeForThis):
50         this debugging method now displays start offset and end offset, at Darin's suggestion
51
52 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
53
54         Reviewed by darin
55
56         <rdar://problem/4062865>
57         Copy/paste of a select element fails to include the options
58         
59         * editing/SelectionController.cpp:
60         (WebCore::SelectionController::modify): Added paragraphBoundary.
61         * editing/htmlediting.cpp:
62         (WebCore::canHaveChildrenForEditing): Added checks for input elements
63         and textareas.  Insertion operations would fail when performed just 
64         before/after one of these elements b/c the content would be put inside 
65         the element.
66         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
67         editable content, and made the code to stop at an root faster (don't check
68         isDescendantOf on every iteration).
69         (WebCore::enclosingNodeOfType): Ditto.
70         (WebCore::enclosingList): Ditto.
71         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
72         inappropriately named.
73         * editing/markup.cpp:
74         (WebCore::startMarkup): Use the text node's value instead of its rendered
75         content for text nodes inside select elements.  One might also turn off
76         annotation when createMarkup enters a select element, but createMarkup
77         is iterative, not recursive, so doing so would be complicated.
78         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
79         descendants of a select element.
80         * editing/visible_units.cpp:
81         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
82         where various replaced elements can't be copied when they are the only
83         thing selected.
84         (WebCore::endOfParagraph): Ditto.
85
86 2006-11-01  Oliver Hunt  <oliver@apple.com>
87
88         Reviewed by Adam.
89
90         Converting more or kcanvas/quartz from Obj-C to C++
91         Minor SVG updates
92         compatibility fixes
93
94         * WebCore.xcodeproj/project.pbxproj:
95         * kcanvas/device/KRenderingPaintServer.h:
96         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
97         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
98         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
99         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
100         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
101         * kcanvas/device/quartz/QuartzSupport.h:
102         * ksvg2/css/SVGCSSStyleSelector.cpp:
103         * ksvg2/misc/KCanvasRenderingStyle.h:
104         * ksvg2/scripts/cssmakeprops:
105         * ksvg2/scripts/cssmakevalues:
106         * ksvg2/scripts/make_names.pl:
107         * ksvg2/svg/SVGAnimateColorElement.cpp:
108         * ksvg2/svg/SVGAnimateTransformElement.cpp:
109         * ksvg2/svg/SVGAnimationElement.cpp:
110         * ksvg2/svg/SVGMaskElement.cpp:
111         * ksvg2/svg/SVGPatternElement.cpp:
112         * ksvg2/svg/svgpathparser.cpp:
113         * platform/Path.cpp:
114         * platform/graphics/svg/SVGResourceImage.h:
115         * rendering/RenderPath.cpp:
116         * rendering/SVGRenderAsText.cpp:
117
118 2006-11-02  Mitz Pettel  <mitz@webkit.org>
119
120         Reviewed by Adele.
121
122         - Fix a regression from r17521: painting of and crash caused by tables
123           with collapsed borders
124
125         * rendering/RenderTable.cpp:
126         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
127         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
128         and 'paintInfo' is the parameter, which we were accidently modifying.
129
130 2006-11-01  Adele Peterson  <adele@apple.com>
131
132         Reviewed by Mitz.
133
134         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
135         REGRESSION: Incomplete repaint of overflow areas when deleting
136
137         Restrict the repaint rect for overflow blocks after the height has been fully computed.
138         Also, adjust the repaint rect coordinates for the scroll offset.
139
140         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
141         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
142
143 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
144
145         Reviewed by Mitz.
146
147         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
148         Rename the "p" member variable of the PaintInfo struct to "context"
149
150         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
151           'context' and 'rect' respectively.
152
153         - Assorted surrounding cleanups.
154
155         * rendering/EllipsisBox.cpp:
156         (WebCore::EllipsisBox::paint):
157         * rendering/EllipsisBox.h:
158         * rendering/InlineBox.cpp:
159         (WebCore::InlineBox::paint):
160         * rendering/InlineFlowBox.cpp:
161         (WebCore::InlineFlowBox::paint):
162         (WebCore::InlineFlowBox::paintBackground):
163         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
164         (WebCore::InlineFlowBox::paintDecorations):
165         * rendering/InlineFlowBox.h:
166         * rendering/InlineRunBox.h:
167         * rendering/InlineTextBox.cpp:
168         (WebCore::InlineTextBox::paint):
169         * rendering/InlineTextBox.h:
170         * rendering/RenderBlock.cpp:
171         (WebCore::RenderBlock::paint):
172         (WebCore::RenderBlock::paintChildren):
173         (WebCore::RenderBlock::paintCaret):
174         (WebCore::RenderBlock::paintObject):
175         (WebCore::RenderBlock::paintFloats):
176         (WebCore::RenderBlock::paintEllipsisBoxes):
177         (WebCore::RenderBlock::paintSelection):
178         (WebCore::RenderBlock::fillSelectionGaps):
179         (WebCore::RenderBlock::fillInlineSelectionGaps):
180         (WebCore::RenderBlock::fillBlockSelectionGaps):
181         (WebCore::RenderBlock::fillHorizontalSelectionGap):
182         (WebCore::RenderBlock::fillVerticalSelectionGap):
183         (WebCore::RenderBlock::fillLeftSelectionGap):
184         (WebCore::RenderBlock::fillRightSelectionGap):
185         * rendering/RenderBox.cpp:
186         (WebCore::RenderBox::paint):
187         (WebCore::RenderBox::paintRootBoxDecorations):
188         (WebCore::RenderBox::paintBoxDecorations):
189         * rendering/RenderBox.h:
190         * rendering/RenderButton.cpp:
191         (WebCore::RenderButton::paintObject):
192         * rendering/RenderFieldset.cpp:
193         (WebCore::RenderFieldset::paintBoxDecorations):
194         * rendering/RenderFileUploadControl.cpp:
195         (WebCore::RenderFileUploadControl::paintObject):
196         * rendering/RenderFlow.cpp:
197         (WebCore::RenderFlow::continuationBefore):
198         (WebCore::RenderFlow::addChildWithContinuation):
199         (WebCore::RenderFlow::addChild):
200         (WebCore::RenderFlow::attachLineBox):
201         (WebCore::RenderFlow::destroy):
202         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
203         (WebCore::RenderFlow::dirtyLineBoxes):
204         (WebCore::RenderFlow::createInlineBox):
205         (WebCore::RenderFlow::paintLines):
206         (WebCore::RenderFlow::getAbsoluteRepaintRect):
207         (WebCore::RenderFlow::lowestPosition):
208         (WebCore::RenderFlow::rightmostPosition):
209         (WebCore::RenderFlow::leftmostPosition):
210         (WebCore::RenderFlow::caretRect):
211         (WebCore::RenderFlow::addFocusRingRects):
212         (WebCore::RenderFlow::paintOutline):
213         (WebCore::RenderFlow::paintOutlineForLine):
214         * rendering/RenderForeignObject.cpp:
215         (WebCore::RenderForeignObject::paint):
216         * rendering/RenderHTMLCanvas.cpp:
217         (WebCore::RenderHTMLCanvas::paint):
218         * rendering/RenderImage.cpp:
219         (WebCore::RenderImage::paint):
220         * rendering/RenderLayer.cpp:
221         (WebCore::RenderLayer::paintLayer):
222         * rendering/RenderListBox.cpp:
223         (WebCore::RenderListBox::paintObject):
224         (WebCore::RenderListBox::paintScrollbar):
225         (WebCore::RenderListBox::paintItemForeground):
226         (WebCore::RenderListBox::paintItemBackground):
227         * rendering/RenderListMarker.cpp:
228         (WebCore::RenderListMarker::paint):
229         * rendering/RenderMenuList.cpp:
230         (WebCore::RenderMenuList::paintObject):
231         * rendering/RenderObject.cpp:
232         (WebCore::RenderObject::paint):
233         * rendering/RenderObject.h:
234         (WebCore::RenderObject::PaintInfo::PaintInfo):
235         (WebCore::RenderObject::paintBoxDecorations):
236         (WebCore::RenderObject::paintingRootForChildren):
237         (WebCore::RenderObject::shouldPaintWithinRoot):
238         (WebCore::RenderObject::printBoxDecorations):
239         * rendering/RenderPath.cpp:
240         (WebCore::RenderPath::paint):
241         * rendering/RenderReplaced.cpp:
242         (WebCore::RenderReplaced::shouldPaint):
243         * rendering/RenderSVGContainer.cpp:
244         (WebCore::RenderSVGContainer::paint):
245         * rendering/RenderSVGContainer.h:
246         * rendering/RenderSVGImage.cpp:
247         (WebCore::RenderSVGImage::paint):
248         * rendering/RenderSVGText.cpp:
249         (WebCore::RenderSVGText::paint):
250         * rendering/RenderSVGText.h:
251         (WebCore::RenderSVGText::renderName):
252         * rendering/RenderTable.cpp:
253         (WebCore::RenderTable::paint):
254         (WebCore::RenderTable::paintBoxDecorations):
255         * rendering/RenderTable.h:
256         * rendering/RenderTableCell.cpp:
257         (WebCore::RenderTableCell::paint):
258         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
259         (WebCore::RenderTableCell::paintBoxDecorations):
260         * rendering/RenderTableCell.h:
261         * rendering/RenderTableRow.cpp:
262         (WebCore::RenderTableRow::paint):
263         * rendering/RenderTableRow.h:
264         * rendering/RenderTableSection.cpp:
265         (WebCore::RenderTableSection::paint):
266         * rendering/RenderTableSection.h:
267         (WebCore::RenderTableSection::getBaseline):
268         (WebCore::RenderTableSection::setNeedCellRecalc):
269         * rendering/RenderText.h:
270         (WebCore::RenderText::renderName):
271         (WebCore::RenderText::paint):
272         (WebCore::RenderText::element):
273         * rendering/RenderTheme.cpp:
274         (WebCore::RenderTheme::paint):
275         (WebCore::RenderTheme::paintBorderOnly):
276         (WebCore::RenderTheme::paintDecorations):
277         * rendering/RenderTheme.h:
278         (WebCore::RenderTheme::RenderTheme):
279         (WebCore::RenderTheme::~RenderTheme):
280         (WebCore::RenderTheme::controlSupportsTints):
281         (WebCore::RenderTheme::adjustRepaintRect):
282         (WebCore::RenderTheme::themeChanged):
283         (WebCore::RenderTheme::supportsHover):
284         (WebCore::RenderTheme::paintCheckbox):
285         (WebCore::RenderTheme::setCheckboxSize):
286         (WebCore::RenderTheme::paintRadio):
287         (WebCore::RenderTheme::setRadioSize):
288         (WebCore::RenderTheme::paintButton):
289         (WebCore::RenderTheme::setButtonSize):
290         (WebCore::RenderTheme::paintTextField):
291         (WebCore::RenderTheme::paintTextArea):
292         (WebCore::RenderTheme::paintMenuList):
293         (WebCore::RenderTheme::paintMenuListButton):
294         * rendering/RenderThemeMac.mm:
295         (WebCore::RenderThemeMac::paintCheckbox):
296         (WebCore::RenderThemeMac::paintRadio):
297         (WebCore::RenderThemeMac::paintButton):
298         (WebCore::RenderThemeMac::paintTextField):
299         (WebCore::RenderThemeMac::paintTextArea):
300         (WebCore::RenderThemeMac::paintMenuList):
301         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
302         (WebCore::RenderThemeMac::paintMenuListButton):
303         * rendering/RenderView.cpp:
304         (WebCore::RenderView::paint):
305         (WebCore::RenderView::paintBoxDecorations):
306         * rendering/RenderView.h:
307         * rendering/RenderWidget.cpp:
308         (WebCore::RenderWidget::paint):
309         * rendering/RenderWidget.h:
310         (WebCore::RenderWidget::isWidget):
311         * rendering/RootInlineBox.cpp:
312         (WebCore::RootInlineBox::paintEllipsisBox):
313         (WebCore::RootInlineBox::paintCustomHighlight):
314         (WebCore::RootInlineBox::paint):
315         (WebCore::RootInlineBox::fillLineSelectionGap):
316         * rendering/RootInlineBox.h:
317         * rendering/SVGInlineFlowBox.cpp:
318         (WebCore::paintSVGInlineFlow):
319
320 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
321
322         Reviewed by Oliver, Brady.
323
324         * platform/network/ResourceResponse.h:
325         (WebCore::ResourceResponse::setLastModifiedDate):
326         (WebCore::ResourceResponse::lastModifiedDate):
327         Add getters and setters for last modified dadte.
328         
329         * platform/network/cf/ResourceResponseCFNet.cpp:
330         (WebCore::getResourceResponse):
331         Fetch the last modified date. Add correct offset to expired date.
332
333 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
334
335         Reviewed by Mitz.
336
337         Added missing "break;" statement in switch statement from r17493.
338
339         Bug 11442: [CSS 3] support for cursor: all-scroll
340         http://bugs.webkit.org/show_bug.cgi?id=11442
341
342         * css/CSSComputedStyleDeclaration.cpp:
343         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
344
345 2006-10-31  Mitz Pettel  <mitz@webkit.org>
346
347         Reviewed by Maciej.
348
349         - fix image dragging
350
351         This is covered by editing/selection/drag-to-contenteditable-iframe.html
352
353         * rendering/HitTestResult.cpp:
354         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
355         HTML IMG elements.
356         (WebCore::HitTestResult::absoluteImageURL): Ditto.
357
358 2006-10-31  Beth Dakin  <bdakin@apple.com>
359
360         Reviewed by Maciej.
361
362         This adds the back-end of the remaining WebElementDictionary 
363         functions into HitTestResult.
364
365         * WebCore.exp:
366         * rendering/HitTestResult.cpp:
367         (WebCore::HitTestResult::title):
368         (WebCore::displayString): This is nearly identical to the 
369         displayString() defined in DOMInternal.mm except that it returns a 
370         String instead of an NSString. The old code path used the 
371         DOMInternal method, so I made a new one here for the new code path.
372         (WebCore::HitTestResult::altDisplayString):
373         (WebCore::HitTestResult::image):
374         (WebCore::HitTestResult::absoluteImageURL):
375         (WebCore::HitTestResult::absoluteLinkURL):
376         (WebCore::HitTestResult::titleDisplayString):
377         (WebCore::HitTestResult::textContent):
378         * rendering/HitTestResult.h:
379
380 2006-10-31  John Sullivan  <sullivan@apple.com>
381
382         * bridge/mac/FrameMac.mm:
383         (WebCore::FrameMac::markMisspellings):
384         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
385
386 2006-10-31  John Sullivan  <sullivan@apple.com>
387
388         Reviewed by Maciej
389         
390         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
391         
392         The foundation of this was in my last checkin. This checkin is all about displaying
393         the correct string in the toolTip.
394
395         * dom/DocumentMarker.h:
396         New description field in this struct.
397
398         * bridge/mac/FrameMac.mm:
399         (WebCore::FrameMac::advanceToNextMisspelling):
400         When adding a grammar marker, supply the appropriate description. Also, added a comment
401         about the remaining work to make grammar checking return sensible answers.
402         (WebCore::FrameMac::markMisspellings):
403         ditto (yes, still needs some refactoring to minimize duplicated code)
404         
405         * dom/Document.h:
406         * dom/Document.cpp:
407         (WebCore::Document::addMarker):
408         Now takes an optional description string
409         (WebCore::Document::markerContainingPoint):
410         New function, returns a pointer to the (first) marker of the specified type whose rect 
411         contains the specified point, or 0 if none.
412         
413         * rendering/HitTestResult.cpp:
414         (WebCore::HitTestResult::spellingToolTip):
415         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
416         and gets the description from the marker.
417
418 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
419
420         Reviewed by Maciej.
421         
422         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
423
424         * loader/mac/FrameLoaderMac.mm:
425         (WebCore::FrameLoader::createWindow):
426         * manual-tests/window-open-features-parsing.html: Updated for clarity.
427
428 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
429
430         Reviewed by Alice.
431
432         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
433         to WebCore::Editor.
434         
435         Layout tests pass.
436         
437         Renamed "may*" to "can*" because "can" is more accurate (these functions
438         aren't just about permission) and it matches WebKit.
439
440         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
441         password field. Now that WebCore fully implements canCopy(), it doesn't just
442         mean "the selection is not in a password field" anymore.
443         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
444         The fact that it's not called anymore may represent a security issue, but I
445         don't see how commented-out code will help reveal the issue, and the
446         bridge is going away, anyway.
447         * editing/SelectionController.h: Changed selection() calls to references
448         to m_sel, to match the rest of the file.
449
450 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
451
452         Reviewed by harrison
453         
454         <rdar://problem/4711063>
455         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
456
457         * editing/ReplaceSelectionCommand.cpp:
458         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
459         insertion and plain text string creation unless we need the string
460         for a BeforeTextInserted event handler or for a plain text only region.
461         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
462         code here from ReplacementFragment's constructor.
463         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
464         FIXME.
465         * editing/ReplaceSelectionCommand.h:
466
467 2006-10-31  Ada Chan  <adachan@apple.com>
468
469         Reviewed by Adam
470
471         Correct forward declarations of the HitTestRequest struct.
472
473         * rendering/EllipsisBox.h:
474         * rendering/InlineBox.h:
475         * rendering/InlineFlowBox.h:
476         * rendering/RenderLayer.h:
477         * rendering/RenderObject.h:
478
479 2006-10-31  John Sullivan  <sullivan@apple.com>
480
481         Reviewed by Beth and Adam
482
483         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
484         next I'll make it use a string that's relevant for a specific grammar error.
485
486         * WebCore.exp:
487         export symbol for spellingToolTip function
488         
489         * rendering/HitTestResult.h:
490         * rendering/HitTestResult.cpp:
491         (WebCore::HitTestResult::spellingToolTip):
492         new function, returns the string to be used in a tool tip that describes the questionable grammar
493         
494         * rendering/InlineTextBox.h:
495         * rendering/InlineTextBox.cpp:
496         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
497         now takes a style and font, needed to compute the rect representing the range containing
498         questionable grammar. Computes the rect and associates it with the marker.
499         (WebCore::InlineTextBox::paintDocumentMarkers):
500         Pass in the style and font now needed by paintSpellingOrGrammarMarker
501
502 2006-10-31  Adele Peterson  <adele@apple.com>
503
504         Removed commented out variable from last checkin.
505
506         * html/HTMLSelectElement.cpp:
507         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
508
509 2006-10-31  Brady Eidson  <beidson@apple.com>
510
511         Build fix (unused variable in release builds)
512
513         * html/HTMLSelectElement.cpp:
514         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
515
516 2006-10-31  Adele Peterson  <adele@apple.com>
517
518         Reviewed by Adam.
519
520         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
521         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
522         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
523
524         Tests: 
525         * LayoutTests/fast/forms/listbox-selection.html
526         * LayoutTests/fast/forms/listbox-onchange.html
527
528         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
529           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
530           And one for onChange, that is updated after onChange is fired.
531           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
532  
533         * html/HTMLSelectElement.cpp:
534         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
535         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
536         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
537         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
538         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
539         (WebCore::HTMLSelectElement::setExtent): Added.
540         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
541         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
542
543         * rendering/RenderListBox.cpp:
544         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
545         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
546         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
547         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
548          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
549          notify the select element from here.
550         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
551         (WebCore::RenderListBox::listIndexIsVisible): Added.
552         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
553
554         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
555         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
556         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
557         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
558         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
559
560 2006-10-31  Beth Dakin  <bdakin@apple.com>
561
562         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
563
564         * rendering/HitTestRequest.h: Added.
565         (WebCore::HitTestRequest::HitTestRequest):
566
567 2006-10-31  Beth Dakin  <bdakin@apple.com>
568
569         Reviewed by Maciej.
570
571         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
572         should be split into HitTestRequest and HitTestResult
573
574         This patch creates a new struct called HitTestRequest that holds 
575         the three boolean values (readonly, active, and mouseMove) that 
576         were formerly a part of HitTestResult. All hitTest() and 
577         nodeAtPoint() functions now take a HitTestRequest in addition to 
578         the HitTestResult.
579
580         * WebCore.exp:
581         * WebCore.xcodeproj/project.pbxproj:
582         * bridge/mac/FrameMac.mm:
583         (WebCore::FrameMac::eventMayStartDrag):
584         (WebCore::FrameMac::handleMouseMoveEvent):
585         * bridge/mac/WebCoreAXObject.mm:
586         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
587         (-[WebCoreAXObject accessibilityHitTest:]):
588         * dom/Document.cpp:
589         (WebCore::Document::elementFromPoint):
590         (WebCore::Document::prepareMouseEvent):
591         * editing/SelectionController.cpp:
592         (WebCore::SelectionController::contains):
593         * page/Frame.cpp:
594         (WebCore::Frame::hitTestResultAtPoint):
595         * page/FrameView.cpp:
596         (WebCore::FrameView::handleWheelEvent):
597         * rendering/EllipsisBox.cpp:
598         (WebCore::EllipsisBox::nodeAtPoint):
599         * rendering/EllipsisBox.h:
600         * rendering/HitTestResult.cpp:
601         (WebCore::HitTestResult::HitTestResult):
602         (WebCore::HitTestResult::operator=):
603         * rendering/HitTestResult.h:
604         * rendering/InlineBox.cpp:
605         (WebCore::InlineBox::nodeAtPoint):
606         * rendering/InlineBox.h:
607         * rendering/InlineFlowBox.cpp:
608         (WebCore::InlineFlowBox::nodeAtPoint):
609         * rendering/InlineFlowBox.h:
610         * rendering/InlineTextBox.cpp:
611         (WebCore::InlineTextBox::nodeAtPoint):
612         * rendering/InlineTextBox.h:
613         * rendering/RenderBlock.cpp:
614         (WebCore::RenderBlock::nodeAtPoint):
615         * rendering/RenderBlock.h:
616         * rendering/RenderBox.cpp:
617         (WebCore::RenderBox::nodeAtPoint):
618         * rendering/RenderBox.h:
619         * rendering/RenderFlow.cpp:
620         (WebCore::RenderFlow::hitTestLines):
621         * rendering/RenderFlow.h:
622         * rendering/RenderForeignObject.cpp:
623         (WebCore::RenderForeignObject::nodeAtPoint):
624         * rendering/RenderForeignObject.h:
625         * rendering/RenderFrameSet.cpp:
626         (WebCore::RenderFrameSet::nodeAtPoint):
627         * rendering/RenderFrameSet.h:
628         * rendering/RenderImage.cpp:
629         (WebCore::RenderImage::nodeAtPoint):
630         * rendering/RenderImage.h:
631         * rendering/RenderInline.cpp:
632         (WebCore::RenderInline::nodeAtPoint):
633         * rendering/RenderInline.h:
634         * rendering/RenderLayer.cpp:
635         (WebCore::RenderLayer::autoscroll):
636         (WebCore::RenderLayer::hitTest):
637         (WebCore::RenderLayer::hitTestLayer):
638         (WebCore::RenderLayer::updateHoverActiveState):
639         * rendering/RenderLayer.h:
640         * rendering/RenderObject.cpp:
641         (WebCore::RenderObject::hitTest):
642         (WebCore::RenderObject::nodeAtPoint):
643         * rendering/RenderObject.h:
644         * rendering/RenderPath.cpp:
645         (WebCore::RenderPath::nodeAtPoint):
646         * rendering/RenderPath.h:
647         * rendering/RenderSVGImage.cpp:
648         (WebCore::RenderSVGImage::nodeAtPoint):
649         * rendering/RenderSVGImage.h:
650         * rendering/RenderSVGText.cpp:
651         (WebCore::RenderSVGText::nodeAtPoint):
652         * rendering/RenderSVGText.h:
653         * rendering/RenderTableRow.cpp:
654         (WebCore::RenderTableRow::nodeAtPoint):
655         * rendering/RenderTableRow.h:
656         * rendering/RenderTableSection.cpp:
657         (WebCore::RenderTableSection::nodeAtPoint):
658         * rendering/RenderTableSection.h:
659         * rendering/RenderText.h:
660         (WebCore::RenderText::nodeAtPoint):
661         * rendering/RenderTextControl.cpp:
662         (WebCore::RenderTextControl::nodeAtPoint):
663         * rendering/RenderTextControl.h:
664         * rendering/RootInlineBox.cpp:
665         (WebCore::RootInlineBox::nodeAtPoint):
666         * rendering/RootInlineBox.h:
667
668 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
669
670         Reviewed by Maciej.
671
672         Bug 11442: [CSS 3] support for cursor: all-scroll
673         http://bugs.webkit.org/show_bug.cgi?id=11442
674
675         * css/CSSComputedStyleDeclaration.cpp:
676         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
677         * css/CSSValueKeywords.in:
678         * css/cssparser.cpp:
679         (WebCore::CSSParser::parseValue):
680         * page/FrameView.cpp:
681         (WebCore::selectCursor):
682         * rendering/RenderStyle.h:
683
684 2006-10-31  Oliver Hunt  <oliver@apple.com>
685
686         Reviewed by Geoff.
687
688         Converting Obj-C++ to C++ in kcanvas
689
690         * WebCore.xcodeproj/project.pbxproj:
691         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
692         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
693         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
694         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
695         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
696         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
697         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
698         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
699         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
700         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
701         * kcanvas/device/quartz/QuartzSupport.h:
702         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
703         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
704         (WebCore::SVGResourceClipper::applyClip):
705         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
706         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
707         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
708
709 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
710
711         Reviewed by harrison
712         
713         <rdar://problem/4808375>
714         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
715         
716         Completely back out r17276 because of performance issues.
717
718         * editing/TextIterator.cpp:
719         (WebCore::TextIterator::TextIterator):
720         (WebCore::TextIterator::advance):
721         (WebCore::TextIterator::handleTextNode):
722         (WebCore::TextIterator::handleTextBox):
723         (WebCore::TextIterator::handleReplacedElement):
724         (WebCore::TextIterator::handleNonTextNode):
725         (WebCore::TextIterator::exitNode):
726         (WebCore::TextIterator::emitCharacter):
727         (WebCore::TextIterator::range):
728         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
729         (WebCore::SimplifiedBackwardsTextIterator::advance):
730         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
731         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
732         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
733         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
734         (WebCore::SimplifiedBackwardsTextIterator::range):
735         (WebCore::CharacterIterator::range):
736         (WebCore::TextIterator::rangeFromLocationAndLength):
737         * editing/TextIterator.h:
738         (WebCore::TextIterator::atEnd):
739         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
740
741 2006-10-31  Darin Adler  <darin@apple.com>
742
743         Reviewed by Brady.
744
745         - got "action dictionary" code out of FrameLoader,
746           replacing with a class called NavigationAction
747
748         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
749         * loader/mac/DocumentLoaderMac.mm:
750         (WebCore::DocumentLoader::triggeringAction): Ditto.
751         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
752
753         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
754
755         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
756         Removed elementForEvent.
757         * loader/mac/FrameLoaderMac.mm:
758         (WebCore::FrameLoader::load): Ditto.
759         (WebCore::FrameLoader::reload): Ditto.
760         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
761         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
762         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
763         (WebCore::FrameLoader::post): Ditto.
764
765         * loader/NavigationAction.h: Added.
766         * loader/NavigationAction.cpp: Added.
767         * loader/mac/NavigationActionMac.mm: Added.
768
769         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
770
771         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
772         * WebCore.exp: Updated.
773
774 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
775
776         Reviewed by Adam.
777
778         Build fix
779
780         * platform/win/CookieJarWin.cpp:
781         (WebCore::cookies):
782
783 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
784
785         Reviewed by Maciej. Landed by Adam.
786
787         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
788
789         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
790         as dicussed with Dave. Also kill the outdated DESIGN document.
791
792         * CMakeLists.txt:
793         * WebCore.xcodeproj/project.pbxproj:
794         * kcanvas/DESIGN: Removed.
795         * kcanvas/KCanvasFilters.cpp:
796         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
797         * kcanvas/KCanvasTreeDebug.h: Ditto.
798         * kcanvas/device/KRenderingPaintServerGradient.cpp:
799         * kcanvas/device/KRenderingPaintServerPattern.cpp:
800         * kcanvas/device/KRenderingPaintServerSolid.cpp:
801         * platform/graphics/svg/SVGResourceClipper.cpp:
802         * rendering/RenderTreeAsText.cpp:
803         * rendering/SVGRenderTreeAsText.cpp: Added.
804         * rendering/SVGRenderTreeAsText.h: Added.
805         (WebCore::operator<<):
806
807 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
808
809         Reviewed by Maciej.
810
811         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
812         Includes some CRLF -> LF fixups.
813
814         * platform/win/CookieJarWin.cpp:
815         (WebCore::cookies):
816
817 2006-10-31  Adam Roben  <aroben@apple.com>
818
819         Reviewed by Steve.
820
821         Fix some incorrect forward declarations.
822
823         * loader/FrameLoader.h:
824         * page/Frame.h:
825
826 2006-10-31  Darin Adler  <darin@apple.com>
827
828         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
829         try to fix the build on the buildbot.
830
831 2006-10-31  Darin Adler  <darin@apple.com>
832
833         * bridge/mac/FrameMac.mm:
834         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
835         (WebCore::FrameMac::markMisspellings): Ditto.
836
837 2006-10-31  John Sullivan  <sullivan@apple.com>
838
839         * bridge/mac/FrameMac.mm:
840         (WebCore::FrameMac::advanceToNextMisspelling):
841         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
842
843 2006-10-30  John Sullivan  <sullivan@apple.com>
844
845         Reviewed by Adam Roben
846         
847         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
848         
849         This patch introduces much of the guts of grammar checking, though still not enough to actually
850         check grammar sensibly, due to:
851           
852         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
853         context passed to grammar checker
854
855         * platform/Logging.h:
856         * platform/Logging.cpp:
857         new log channel SpellingAndGrammar
858
859         * bridge/mac/WebCorePageBridge.mm:
860         (initializeLoggingChannelsIfNecessary):
861         initialize new log channel
862
863         * bridge/mac/FrameMac.mm:
864         (WebCore::FrameMac::advanceToNextMisspelling):
865         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
866         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
867         in the event of a tie), and do further processing with that one (select range; create marker that
868         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
869         (WebCore::FrameMac::markMisspellings):
870         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
871         differently enough to make sharing code between these two functions a little tricky, so I decided to 
872         save that for a later patch.
873         
874         (WebCore::FrameMac::respondToChangedSelection):
875         remove grammar markers when we remove spelling markers        
876
877 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
878
879         Reviewed by Mitz.
880
881         Fix Qt/Linux build with older gcc3.3.4.
882
883         * bindings/js/kjs_window.cpp:
884         (KJS::WindowFunc::callAsFunction):
885
886 2006-10-31  Zack Rusin  <zack@kde.org>
887
888         Reviewed by Mitz.
889
890         Fix the Qt build after last nights changes.
891
892         * WebCore/platform/qt/FrameQt.cpp:
893         * WebCore/platform/qt/EditorClientQt.h:
894         * WebCore/platform/qt/EditorClientQt.cpp:
895         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
896         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
897         * WebCore/CMakeLists.txt:
898         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
899         * WebKitQt/QtLauncher/CMakeLists.txt:
900         * WebKitQt/WebKitPart/CMakeLists.txt:
901
902 2006-10-30  Darin Adler  <darin@apple.com>
903
904         Reviewed by Anders.
905
906         - remove BrowserExtension
907
908         * WebCore.vcproj/WebCore/WebCore.vcproj:
909         * WebCore.xcodeproj/project.pbxproj:
910         * bindings/js/kjs_window.cpp:
911         (KJS::createNewWindow):
912         (KJS::WindowFunc::callAsFunction):
913         * bridge/BrowserExtension.h: Removed.
914         * bridge/mac/BrowserExtensionMac.h: Removed.
915         * bridge/mac/BrowserExtensionMac.mm: Removed.
916         * bridge/mac/FrameMac.mm:
917         (WebCore::FrameMac::FrameMac):
918         (WebCore::FrameMac::submitForm):
919         (WebCore::FrameMac::urlSelected):
920         * bridge/win/BrowserExtensionWin.cpp: Removed.
921         * bridge/win/BrowserExtensionWin.h: Removed.
922         * bridge/win/FrameWin.cpp:
923         (WebCore::FrameWin::FrameWin):
924         * loader/FrameLoader.cpp:
925         (WebCore::FrameLoader::createWindow):
926         * loader/FrameLoader.h:
927         * loader/icon/IconLoader.cpp:
928         * loader/mac/FrameLoaderMac.mm:
929         (WebCore::FrameLoader::safeLoad):
930         (WebCore::FrameLoader::load):
931         (WebCore::FrameLoader::createWindow):
932         * page/Frame.cpp:
933         (WebCore::Frame::urlSelected):
934         (WebCore::Frame::requestFrame):
935         (WebCore::Frame::submitForm):
936         (WebCore::Frame::scheduleHistoryNavigation):
937         (WebCore::Frame::redirectionTimerFired):
938         * page/Frame.h:
939         * page/FrameLoadRequest.h:
940         (WebCore::FrameLoadRequest::FrameLoadRequest):
941         (WebCore::FrameLoadRequest::isEmpty):
942         (WebCore::FrameLoadRequest::resourceRequest):
943         (WebCore::FrameLoadRequest::frameName):
944         (WebCore::FrameLoadRequest::setFrameName):
945         * page/FramePrivate.h:
946         (WebCore::FramePrivate::FramePrivate):
947         (WebCore::FramePrivate::~FramePrivate):
948         * platform/gdk/BrowserExtensionGdk.h: Removed.
949         * platform/gdk/FrameGdk.cpp:
950         (WebCore::FrameGdk::FrameGdk):
951         * platform/gdk/TemporaryLinkStubs.cpp:
952         * platform/network/ResourceRequest.h:
953         (WebCore::ResourceRequest::isEmpty):
954
955 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
956
957         Reviewed by Oliver.
958
959         Modified from original due to earlier reversion
960
961         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
962
963         Better SVG integration in WebKit, Part I.
964
965         The patch is mostly about creating a new platform/graphics directory, and
966         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
967         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
968         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
969
970         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
971         All details of the patch, and upcoming patches can be found in the bug report.
972
973         * CMakeLists.txt:
974         * WebCore.xcodeproj/project.pbxproj:
975         * graphics/svg/SVGResource.cpp: Removed.
976         * graphics/svg/SVGResourceClipper.cpp: Removed.
977         * graphics/svg/SVGResourceClipper.h: Removed.
978         * graphics/svg/SVGResourceImage.h: Removed.
979         * graphics/svg/SVGResourceListener.h: Removed.
980         * graphics/svg/SVGResourceMarker.cpp: Removed.
981         * graphics/svg/SVGResourceMarker.h: Removed.
982         * graphics/svg/SVGResourceMasker.cpp: Removed.
983         * graphics/svg/SVGResourceMasker.h: Removed.
984         * kcanvas/KCanvasClipper.cpp: Removed.
985         * kcanvas/KCanvasClipper.h: Removed.
986         * kcanvas/KCanvasCreator.cpp: Removed.
987         * kcanvas/KCanvasCreator.h: Removed.
988         * kcanvas/KCanvasFilters.cpp:
989         (WebCore::getFilterById):
990         * kcanvas/KCanvasFilters.h:
991         * kcanvas/KCanvasImage.h: Removed.
992         * kcanvas/KCanvasMarker.cpp: Removed.
993         * kcanvas/KCanvasMarker.h: Removed.
994         * kcanvas/KCanvasMasker.cpp: Removed.
995         * kcanvas/KCanvasMasker.h: Removed.
996         * kcanvas/KCanvasResource.cpp: Removed.
997         * kcanvas/KCanvasResource.h: Removed.
998         * kcanvas/KCanvasResourceListener.h: Removed.
999         * kcanvas/KCanvasTreeDebug.cpp:
1000         (WebCore::writeRenderResources):
1001         * kcanvas/device/KRenderingDevice.h:
1002         * kcanvas/device/KRenderingPaintServer.h:
1003         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1004         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1005         (WebCore::KRenderingPaintServerGradient::listener):
1006         (WebCore::KRenderingPaintServerGradient::setListener):
1007         * kcanvas/device/KRenderingPaintServerGradient.h:
1008         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1009         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1010         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1011         (WebCore::KRenderingPaintServerPattern::tile):
1012         (WebCore::KRenderingPaintServerPattern::setTile):
1013         (WebCore::KRenderingPaintServerPattern::listener):
1014         (WebCore::KRenderingPaintServerPattern::setListener):
1015         * kcanvas/device/KRenderingPaintServerPattern.h:
1016         * kcanvas/device/KRenderingPaintServerSolid.h:
1017         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1018         * kcanvas/device/qt/KCanvasClipperQt.h:
1019         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1020         (WebCore::KRenderingDeviceQt::contextForImage):
1021         (WebCore::KRenderingDeviceQt::createResource):
1022         (WebCore::KRenderingDeviceQt::createPaintServer):
1023         * kcanvas/device/qt/KRenderingDeviceQt.h:
1024         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1025         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1026         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1027         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1028         * kcanvas/device/qt/RenderPathQt.h: Removed.
1029         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1030         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1031         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1032         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1033         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1034         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1035         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1036         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1037         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1038         (WebCore::KRenderingDeviceQuartz::contextForImage):
1039         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1040         (WebCore::KRenderingDeviceQuartz::createResource):
1041         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1042         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1043         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1044         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1045         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1046         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1047         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1048         (WebCore::patternCallback):
1049         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1050         * kcanvas/device/quartz/QuartzSupport.mm:
1051         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1052         (WebCore::sharedSolidPaintServer):
1053         * ksvg2/svg/SVGClipPathElement.cpp:
1054         (WebCore::SVGClipPathElement::SVGClipPathElement):
1055         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1056         (WebCore::SVGClipPathElement::canvasResource):
1057         * ksvg2/svg/SVGClipPathElement.h:
1058         * ksvg2/svg/SVGFEImageElement.cpp:
1059         * ksvg2/svg/SVGFilterElement.cpp:
1060         (WebCore::SVGFilterElement::SVGFilterElement):
1061         (WebCore::SVGFilterElement::~SVGFilterElement):
1062         (WebCore::SVGFilterElement::canvasResource):
1063         * ksvg2/svg/SVGFilterElement.h:
1064         * ksvg2/svg/SVGGradientElement.cpp:
1065         (WebCore::SVGGradientElement::SVGGradientElement):
1066         (WebCore::SVGGradientElement::~SVGGradientElement):
1067         (WebCore::SVGGradientElement::canvasResource):
1068         (WebCore::SVGGradientElement::resourceNotification):
1069         * ksvg2/svg/SVGGradientElement.h:
1070         * ksvg2/svg/SVGImageElement.cpp:
1071         * ksvg2/svg/SVGLinearGradientElement.cpp:
1072         (WebCore::SVGLinearGradientElement::buildGradient):
1073         * ksvg2/svg/SVGLinearGradientElement.h:
1074         * ksvg2/svg/SVGMarkerElement.cpp:
1075         (WebCore::SVGMarkerElement::SVGMarkerElement):
1076         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1077         (WebCore::SVGMarkerElement::canvasResource):
1078         * ksvg2/svg/SVGMarkerElement.h:
1079         * ksvg2/svg/SVGMaskElement.cpp:
1080         (WebCore::SVGMaskElement::SVGMaskElement):
1081         (WebCore::SVGMaskElement::~SVGMaskElement):
1082         (WebCore::SVGMaskElement::drawMaskerContent):
1083         (WebCore::SVGMaskElement::canvasResource):
1084         * ksvg2/svg/SVGMaskElement.h:
1085         * ksvg2/svg/SVGPatternElement.cpp:
1086         (WebCore::SVGPatternElement::SVGPatternElement):
1087         (WebCore::SVGPatternElement::~SVGPatternElement):
1088         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1089         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1090         (WebCore::SVGPatternElement::canvasResource):
1091         * ksvg2/svg/SVGPatternElement.h:
1092         * ksvg2/svg/SVGRadialGradientElement.cpp:
1093         (WebCore::SVGRadialGradientElement::buildGradient):
1094         * ksvg2/svg/SVGRadialGradientElement.h:
1095         * ksvg2/svg/SVGStyledElement.h:
1096         (WebCore::SVGStyledElement::canvasResource):
1097         * platform/GraphicsContext.cpp: Removed.
1098         * platform/GraphicsContext.h: Removed.
1099         * platform/GraphicsTypes.cpp: Removed.
1100         * platform/GraphicsTypes.h: Removed.
1101         * platform/graphics/GraphicsContext.cpp:
1102         (WebCore::GraphicsContextState::GraphicsContextState):
1103         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1104         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1105         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1106         (WebCore::GraphicsContext::save):
1107         (WebCore::GraphicsContext::restore):
1108         (WebCore::GraphicsContext::font):
1109         (WebCore::GraphicsContext::setFont):
1110         (WebCore::GraphicsContext::pen):
1111         (WebCore::GraphicsContext::setPen):
1112         (WebCore::GraphicsContext::setFillColor):
1113         (WebCore::GraphicsContext::fillColor):
1114         (WebCore::GraphicsContext::updatingControlTints):
1115         (WebCore::GraphicsContext::setUpdatingControlTints):
1116         (WebCore::GraphicsContext::setPaintingDisabled):
1117         (WebCore::GraphicsContext::paintingDisabled):
1118         (WebCore::GraphicsContext::drawImage):
1119         (WebCore::GraphicsContext::drawText):
1120         (WebCore::GraphicsContext::drawHighlightForText):
1121         (WebCore::GraphicsContext::initFocusRing):
1122         (WebCore::GraphicsContext::clearFocusRing):
1123         (WebCore::GraphicsContext::focusRingBoundingRect):
1124         (WebCore::GraphicsContext::addFocusRingRect):
1125         (WebCore::GraphicsContext::focusRingWidth):
1126         (WebCore::GraphicsContext::focusRingOffset):
1127         (WebCore::GraphicsContext::focusRingRects):
1128         (WebCore::GraphicsContext::drawTiledImage):
1129         * platform/graphics/GraphicsContext.h:
1130         * platform/graphics/GraphicsTypes.cpp:
1131         (WebCore::):
1132         (WebCore::parseCompositeOperator):
1133         (WebCore::compositeOperatorName):
1134         (WebCore::parseLineCap):
1135         (WebCore::lineCapName):
1136         (WebCore::parseLineJoin):
1137         (WebCore::lineJoinName):
1138         * platform/graphics/GraphicsTypes.h:
1139         (WebCore::):
1140         * platform/graphics/svg/SVGResource.cpp: Added.
1141         (WebCore::SVGResource::SVGResource):
1142         (WebCore::SVGResource::~SVGResource):
1143         (WebCore::SVGResource::invalidate):
1144         (WebCore::SVGResource::addClient):
1145         (WebCore::SVGResource::clients):
1146         (WebCore::SVGResource::idInRegistry):
1147         (WebCore::SVGResource::setIdInRegistry):
1148         (WebCore::SVGResource::externalRepresentation):
1149         (WebCore::getResourceById):
1150         (WebCore::getPaintServerById):
1151         (WebCore::operator<<):
1152         * platform/graphics/svg/SVGResource.h: Added.
1153         (WebCore::):
1154         (WebCore::SVGResource::isPaintServer):
1155         (WebCore::SVGResource::isFilter):
1156         (WebCore::SVGResource::isClipper):
1157         (WebCore::SVGResource::isMarker):
1158         (WebCore::SVGResource::isMasker):
1159         (WebCore::SVGResourceListener::~SVGResourceListener):
1160         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1161         (WebCore::SVGResourceClipper::SVGResourceClipper):
1162         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1163         (WebCore::SVGResourceClipper::resetClipData):
1164         (WebCore::SVGResourceClipper::addClipData):
1165         (WebCore::SVGResourceClipper::clipData):
1166         (WebCore::SVGResourceClipper::externalRepresentation):
1167         (WebCore::operator<<):
1168         (WebCore::getClipperById):
1169         * platform/graphics/svg/SVGResourceClipper.h: Added.
1170         (WebCore::ClipDataList::addPath):
1171         (WebCore::SVGResourceClipper::isClipper):
1172         * platform/graphics/svg/SVGResourceImage.h: Added.
1173         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1174         (WebCore::SVGResourceMarker::SVGResourceMarker):
1175         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1176         (WebCore::SVGResourceMarker::setMarker):
1177         (WebCore::SVGResourceMarker::setRef):
1178         (WebCore::SVGResourceMarker::draw):
1179         (WebCore::SVGResourceMarker::externalRepresentation):
1180         (WebCore::getMarkerById):
1181         * platform/graphics/svg/SVGResourceMarker.h: Added.
1182         (WebCore::SVGResourceMarker::refX):
1183         (WebCore::SVGResourceMarker::refY):
1184         (WebCore::SVGResourceMarker::setAngle):
1185         (WebCore::SVGResourceMarker::setAutoAngle):
1186         (WebCore::SVGResourceMarker::angle):
1187         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1188         (WebCore::SVGResourceMarker::useStrokeWidth):
1189         (WebCore::SVGResourceMarker::isMarker):
1190         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1191         (WebCore::SVGResourceMasker::SVGResourceMasker):
1192         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1193         (WebCore::SVGResourceMasker::setMask):
1194         (WebCore::SVGResourceMasker::mask):
1195         (WebCore::SVGResourceMasker::externalRepresentation):
1196         (WebCore::getMaskerById):
1197         * platform/graphics/svg/SVGResourceMasker.h: Added.
1198         (WebCore::SVGResourceMasker::isMasker):
1199         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1200         (WebCore::SVGResourceClipper::applyClip):
1201         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1202         (WebCore::SVGResourceImage::SVGResourceImage):
1203         (WebCore::SVGResourceImage::~SVGResourceImage):
1204         (WebCore::SVGResourceImage::init):
1205         (WebCore::SVGResourceImage::size):
1206         (WebCore::SVGResourceImage::cgLayer):
1207         (WebCore::SVGResourceImage::setCGLayer):
1208         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1209         (WebCore::applyLuminanceToAlphaFilter):
1210         (WebCore::applyExpandAlphatoGrayscaleFilter):
1211         (WebCore::transformImageIntoGrayscaleMask):
1212         (WebCore::SVGResourceMasker::applyMask):
1213         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1214         (WebCore::SVGResourceClipper::applyClip):
1215         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1216         (WebCore::SVGResourceImage::init):
1217         (WebCore::SVGResourceImage::size):
1218         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1219         (WebCore::SVGResourceMasker::applyMask):
1220         * platform/qt/GraphicsContextQt.cpp:
1221         * rendering/RenderPath.cpp:
1222         (WebCore::RenderPath::paint):
1223         (WebCore::DrawMarkersData::DrawMarkersData):
1224         (WebCore::RenderPath::drawMarkersIfNeeded):
1225         * rendering/RenderSVGContainer.cpp:
1226         (WebCore::RenderSVGContainer::paint):
1227         * rendering/RenderSVGImage.cpp:
1228         (WebCore::RenderSVGImage::paint):
1229         * rendering/SVGInlineFlowBox.cpp:
1230         (WebCore::paintSVGInlineFlow):
1231
1232 2006-10-30  John Sullivan  <sullivan@apple.com>
1233
1234         Reviewed by Brady
1235         
1236         - minor cleanup to make future patches clearer
1237
1238         * bridge/mac/FrameMac.mm:
1239         (WebCore::FrameMac::advanceToNextMisspelling):
1240         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1241         with "continue" to better match structure of similar code in markMisspellings; a few
1242         other style tweaks.
1243         
1244         (WebCore::FrameMac::markMisspellings):
1245         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1246         a block just after a break and outdented accordingly.
1247
1248 2006-10-30  John Sullivan  <sullivan@apple.com>
1249
1250         Reviewed by Geoff Garen
1251         
1252         WebCore part of change to push the code that updates the spelling panel
1253         into WebCore, in preparation for some grammar-checking stuff.
1254
1255         * bridge/mac/FrameMac.h:
1256         * bridge/mac/FrameMac.mm:
1257         (WebCore::FrameMac::advanceToNextMisspelling):
1258         no more return value for this method, and update the spelling panel with
1259         the misspelled word here rather than in the WebKit callers.
1260
1261 2006-10-30  Oliver Hunt  <oliver@apple.com>
1262
1263         Reviewed by Anders.
1264
1265         Roll out last patch
1266
1267         * CMakeLists.txt:
1268         * ChangeLog:
1269         * WebCore.xcodeproj/project.pbxproj:
1270         * graphics/svg/SVGResource.cpp:
1271         * graphics/svg/SVGResourceClipper.cpp:
1272         * graphics/svg/SVGResourceClipper.h:
1273         * graphics/svg/SVGResourceImage.h:
1274         * graphics/svg/SVGResourceListener.h:
1275         * graphics/svg/SVGResourceMarker.cpp:
1276         * graphics/svg/SVGResourceMarker.h:
1277         * graphics/svg/SVGResourceMasker.cpp:
1278         * graphics/svg/SVGResourceMasker.h:
1279         * kcanvas/KCanvasClipper.cpp: Added.
1280         (WebCore::operator<<):
1281         (WebCore::KCanvasClipper::KCanvasClipper):
1282         (WebCore::KCanvasClipper::~KCanvasClipper):
1283         (WebCore::KCanvasClipper::resetClipData):
1284         (WebCore::KCanvasClipper::addClipData):
1285         (WebCore::KCanvasClipper::clipData):
1286         (WebCore::KCanvasClipper::externalRepresentation):
1287         (WebCore::getClipperById):
1288         * kcanvas/KCanvasClipper.h: Added.
1289         (WebCore::KCClipData::windRule):
1290         (WebCore::KCClipDataList::KCClipDataList):
1291         (WebCore::KCClipDataList::addPath):
1292         (WebCore::KCanvasClipper::isClipper):
1293         * kcanvas/KCanvasFilters.cpp:
1294         (WebCore::getFilterById):
1295         * kcanvas/KCanvasFilters.h:
1296         * kcanvas/KCanvasImage.h: Added.
1297         (WebCore::KCanvasImage::KCanvasImage):
1298         (WebCore::KCanvasImage::~KCanvasImage):
1299         * kcanvas/KCanvasMarker.cpp: Added.
1300         (WebCore::KCanvasMarker::KCanvasMarker):
1301         (WebCore::KCanvasMarker::~KCanvasMarker):
1302         (WebCore::KCanvasMarker::setMarker):
1303         (WebCore::KCanvasMarker::setRef):
1304         (WebCore::KCanvasMarker::refX):
1305         (WebCore::KCanvasMarker::refY):
1306         (WebCore::KCanvasMarker::setAngle):
1307         (WebCore::KCanvasMarker::angle):
1308         (WebCore::KCanvasMarker::setAutoAngle):
1309         (WebCore::KCanvasMarker::setUseStrokeWidth):
1310         (WebCore::KCanvasMarker::useStrokeWidth):
1311         (WebCore::KCanvasMarker::draw):
1312         (WebCore::KCanvasMarker::externalRepresentation):
1313         (WebCore::getMarkerById):
1314         * kcanvas/KCanvasMarker.h: Added.
1315         (WebCore::KCanvasMarker::isMarker):
1316         * kcanvas/KCanvasMasker.cpp: Added.
1317         (WebCore::KCanvasMasker::KCanvasMasker):
1318         (WebCore::KCanvasMasker::~KCanvasMasker):
1319         (WebCore::KCanvasMasker::setMask):
1320         (WebCore::KCanvasMasker::externalRepresentation):
1321         (WebCore::getMaskerById):
1322         * kcanvas/KCanvasMasker.h: Added.
1323         (WebCore::KCanvasMasker::isMasker):
1324         (WebCore::KCanvasMasker::mask):
1325         * kcanvas/KCanvasResource.cpp: Added.
1326         (WebCore::operator<<):
1327         (WebCore::KCanvasResource::KCanvasResource):
1328         (WebCore::KCanvasResource::~KCanvasResource):
1329         (WebCore::KCanvasResource::addClient):
1330         (WebCore::KCanvasResource::clients):
1331         (WebCore::KCanvasResource::invalidate):
1332         (WebCore::KCanvasResource::idInRegistry):
1333         (WebCore::KCanvasResource::setIdInRegistry):
1334         (WebCore::KCanvasResource::externalRepresentation):
1335         (WebCore::getResourceById):
1336         (WebCore::getPaintServerById):
1337         * kcanvas/KCanvasResource.h:
1338         (WebCore::):
1339         (WebCore::KCanvasResource::isPaintServer):
1340         (WebCore::KCanvasResource::isFilter):
1341         (WebCore::KCanvasResource::isClipper):
1342         (WebCore::KCanvasResource::isMarker):
1343         (WebCore::KCanvasResource::isMasker):
1344         * kcanvas/KCanvasResourceListener.h: Added.
1345         (KCanvasResourceListener::KCanvasResourceListener):
1346         (KCanvasResourceListener::~KCanvasResourceListener):
1347         * kcanvas/KCanvasTreeDebug.cpp:
1348         (WebCore::writeRenderResources):
1349         * kcanvas/device/KRenderingDevice.h:
1350         * kcanvas/device/KRenderingPaintServer.h:
1351         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1352         (WebCore::KRenderingPaintServer::idInRegistry):
1353         (WebCore::KRenderingPaintServer::setIdInRegistry):
1354         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1355         (WebCore::KRenderingPaintServerGradient::listener):
1356         (WebCore::KRenderingPaintServerGradient::setListener):
1357         * kcanvas/device/KRenderingPaintServerGradient.h:
1358         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1359         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1360         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1361         (WebCore::KRenderingPaintServerPattern::tile):
1362         (WebCore::KRenderingPaintServerPattern::setTile):
1363         (WebCore::KRenderingPaintServerPattern::listener):
1364         (WebCore::KRenderingPaintServerPattern::setListener):
1365         * kcanvas/device/KRenderingPaintServerPattern.h:
1366         * kcanvas/device/KRenderingPaintServerSolid.h:
1367         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1368         (WebCore::KCanvasClipperQt::applyClip):
1369         * kcanvas/device/qt/KCanvasClipperQt.h:
1370         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1371         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1372         (WebCore::KRenderingDeviceQt::contextForImage):
1373         (WebCore::KRenderingDeviceQt::createResource):
1374         (WebCore::KRenderingDeviceQt::createPaintServer):
1375         * kcanvas/device/qt/KRenderingDeviceQt.h:
1376         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1377         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1378         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1379         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1380         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1381         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1382         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1383         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1384         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1385         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1386         (WebCore::applyLuminanceToAlphaFilter):
1387         (WebCore::applyExpandAlphatoGrayscaleFilter):
1388         (WebCore::transformImageIntoGrayscaleMask):
1389         (WebCore::KCanvasMaskerQuartz::applyMask):
1390         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1391         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1392         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1393         (WebCore::KCanvasImageQuartz::init):
1394         (WebCore::KCanvasImageQuartz::size):
1395         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1396         (WebCore::KCanvasClipperQuartz::applyClip):
1397         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1398         (WebCore::KCanvasImageQuartz::cgLayer):
1399         (WebCore::KCanvasImageQuartz::setCGLayer):
1400         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1401         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1402         (WebCore::KRenderingDeviceQuartz::contextForImage):
1403         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1404         (WebCore::KRenderingDeviceQuartz::createResource):
1405         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1406         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1407         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1408         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1409         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1410         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1411         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1412         (WebCore::patternCallback):
1413         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1414         * kcanvas/device/quartz/QuartzSupport.mm:
1415         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1416         (WebCore::sharedSolidPaintServer):
1417         * ksvg2/svg/SVGClipPathElement.cpp:
1418         (WebCore::SVGClipPathElement::SVGClipPathElement):
1419         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1420         (WebCore::SVGClipPathElement::canvasResource):
1421         * ksvg2/svg/SVGClipPathElement.h:
1422         * ksvg2/svg/SVGFEImageElement.cpp:
1423         * ksvg2/svg/SVGFilterElement.cpp:
1424         (WebCore::SVGFilterElement::SVGFilterElement):
1425         (WebCore::SVGFilterElement::~SVGFilterElement):
1426         (WebCore::SVGFilterElement::canvasResource):
1427         * ksvg2/svg/SVGFilterElement.h:
1428         * ksvg2/svg/SVGGradientElement.cpp:
1429         (WebCore::SVGGradientElement::SVGGradientElement):
1430         (WebCore::SVGGradientElement::~SVGGradientElement):
1431         (WebCore::SVGGradientElement::canvasResource):
1432         (WebCore::SVGGradientElement::resourceNotification):
1433         * ksvg2/svg/SVGGradientElement.h:
1434         * ksvg2/svg/SVGImageElement.cpp:
1435         * ksvg2/svg/SVGLinearGradientElement.cpp:
1436         (WebCore::SVGLinearGradientElement::buildGradient):
1437         * ksvg2/svg/SVGLinearGradientElement.h:
1438         * ksvg2/svg/SVGMarkerElement.cpp:
1439         (WebCore::SVGMarkerElement::SVGMarkerElement):
1440         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1441         (WebCore::SVGMarkerElement::canvasResource):
1442         * ksvg2/svg/SVGMarkerElement.h:
1443         * ksvg2/svg/SVGMaskElement.cpp:
1444         (WebCore::SVGMaskElement::SVGMaskElement):
1445         (WebCore::SVGMaskElement::~SVGMaskElement):
1446         (WebCore::SVGMaskElement::drawMaskerContent):
1447         (WebCore::SVGMaskElement::canvasResource):
1448         * ksvg2/svg/SVGMaskElement.h:
1449         * ksvg2/svg/SVGPatternElement.cpp:
1450         (WebCore::SVGPatternElement::SVGPatternElement):
1451         (WebCore::SVGPatternElement::~SVGPatternElement):
1452         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1453         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1454         (WebCore::SVGPatternElement::canvasResource):
1455         * ksvg2/svg/SVGPatternElement.h:
1456         * ksvg2/svg/SVGRadialGradientElement.cpp:
1457         (WebCore::SVGRadialGradientElement::buildGradient):
1458         * ksvg2/svg/SVGRadialGradientElement.h:
1459         * ksvg2/svg/SVGStyledElement.h:
1460         (WebCore::SVGStyledElement::canvasResource):
1461         * platform/GraphicsContext.cpp: Added.
1462         (WebCore::GraphicsContextState::GraphicsContextState):
1463         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1464         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1465         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1466         (WebCore::GraphicsContext::save):
1467         (WebCore::GraphicsContext::restore):
1468         (WebCore::GraphicsContext::font):
1469         (WebCore::GraphicsContext::setFont):
1470         (WebCore::GraphicsContext::pen):
1471         (WebCore::GraphicsContext::setPen):
1472         (WebCore::GraphicsContext::setFillColor):
1473         (WebCore::GraphicsContext::fillColor):
1474         (WebCore::GraphicsContext::updatingControlTints):
1475         (WebCore::GraphicsContext::setUpdatingControlTints):
1476         (WebCore::GraphicsContext::setPaintingDisabled):
1477         (WebCore::GraphicsContext::paintingDisabled):
1478         (WebCore::GraphicsContext::drawImage):
1479         (WebCore::GraphicsContext::drawText):
1480         (WebCore::GraphicsContext::drawHighlightForText):
1481         (WebCore::GraphicsContext::initFocusRing):
1482         (WebCore::GraphicsContext::clearFocusRing):
1483         (WebCore::GraphicsContext::focusRingBoundingRect):
1484         (WebCore::GraphicsContext::addFocusRingRect):
1485         (WebCore::GraphicsContext::focusRingWidth):
1486         (WebCore::GraphicsContext::focusRingOffset):
1487         (WebCore::GraphicsContext::focusRingRects):
1488         (WebCore::GraphicsContext::drawTiledImage):
1489         * platform/GraphicsContext.h: Added.
1490         * platform/GraphicsTypes.cpp: Added.
1491         (WebCore::):
1492         (WebCore::parseCompositeOperator):
1493         (WebCore::compositeOperatorName):
1494         (WebCore::parseLineCap):
1495         (WebCore::lineCapName):
1496         (WebCore::parseLineJoin):
1497         (WebCore::lineJoinName):
1498         * platform/GraphicsTypes.h: Added.
1499         (WebCore::):
1500         * platform/graphics/GraphicsContext.cpp:
1501         * platform/graphics/GraphicsContext.h:
1502         * platform/graphics/GraphicsTypes.cpp:
1503         * platform/graphics/GraphicsTypes.h:
1504         * platform/qt/GraphicsContextQt.cpp:
1505         * rendering/RenderPath.cpp:
1506         (WebCore::RenderPath::paint):
1507         (WebCore::DrawMarkersData::DrawMarkersData):
1508         (WebCore::RenderPath::drawMarkersIfNeeded):
1509         * rendering/RenderSVGContainer.cpp:
1510         (WebCore::RenderSVGContainer::paint):
1511         * rendering/RenderSVGImage.cpp:
1512         (WebCore::RenderSVGImage::paint):
1513         * rendering/SVGInlineFlowBox.cpp:
1514         (WebCore::paintSVGInlineFlow):
1515
1516 2006-10-30  John Sullivan  <sullivan@apple.com>
1517
1518         Reviewed by Geoff Garen.
1519         
1520         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1521         grammar-related method.
1522
1523         * bridge/EditorClient.h:
1524         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1525         isGrammarCheckingEnabled()
1526         
1527         * bridge/mac/WebCoreFrameBridge.h:
1528         removed bridge equivalents
1529
1530         * bridge/mac/FrameMac.mm:
1531         (WebCore::FrameMac::advanceToNextMisspelling):
1532         convert bridge-using code to editor()->client()-using code
1533         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1534         ditto
1535         (WebCore::FrameMac::markMisspellings):
1536         ditto
1537         (WebCore::FrameMac::respondToChangedSelection):
1538         ditto
1539         
1540         * editing/Editor.h:
1541         * editing/Editor.cpp:
1542         (WebCore::Editor::client):
1543         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1544         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1545         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1546
1547 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1548
1549         Reviewed by Darin.
1550
1551         Removed a number of editing and selection methods from the bridge.
1552         
1553         I moved cross-platform editing and selection code into Editor and 
1554         SelectionController, respecitvely.
1555
1556         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1557         everything + the kitchen sink.
1558         
1559         Specific comments below for interesting things.
1560         
1561         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1562         a new file so that WebKit can use them, too. Added a helper method for
1563         handling exceptions when selecting a Range.
1564         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1565         WebKit, since they have to do with creating an NSAttributedString for API
1566         consumption, and not much to do with general Frame functionality.
1567         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1568         for now) into the Editor. Eventually, the Frame will not have to notify 
1569         the Editor of what the lastEditCommand was, since the Editor will perform
1570         all EditCommands.
1571         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1572         * editing/SelectionController.cpp:
1573         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1574         and return them. The bridge method to select a DOM range did this implicitly,
1575         since all ObjC DOM operations handle DOM exceptions by throwing them as
1576         ObjC exceptions.
1577         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1578         The two enumerations are numerically identical, but that's an implementation
1579         detail of TextAffinity that clients shouldn't be required to know about.
1580
1581 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1582
1583         Rolling out the following change because this crash:
1584         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1585
1586         And this regression:
1587         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1588
1589     2006-09-06  David Harrison  <harrison@apple.com>
1590
1591         Reviewed and tweaked by Tim H. 
1592
1593         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1594
1595         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1596         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1597         No layout tests affected. Not testable in an automated way that will work on all systems. 
1598
1599         * platform/mac/WebFontCache.mm: 
1600         (+[WebFontCache fontWithFamily:traits:size:]): 
1601
1602 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1603
1604         Reviewed by harrison
1605
1606         <rdar://problem/4808375>
1607         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1608
1609         * editing/TextIterator.cpp:
1610         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1611         when we're going to use them to create a range for an emitted character.
1612         We should further speed TextIterators up by avoiding creating VisiblePositions
1613         for TIs that are only used for the characters they emit (like the one that 
1614         plainText uses).
1615
1616 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1617
1618         Reviewed by Mitz.
1619
1620         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1621         More rendering code cleaning
1622
1623         * WebCore.xcodeproj/project.pbxproj:
1624         * rendering/RenderApplet.cpp:
1625         (WebCore::RenderApplet::RenderApplet):
1626         (WebCore::RenderApplet::createWidgetIfNecessary):
1627         * rendering/RenderApplet.h:
1628         * rendering/RenderArena.cpp:
1629         (WebCore::):
1630         (WebCore::RenderArena::RenderArena):
1631         (WebCore::RenderArena::allocate):
1632         (WebCore::RenderArena::free):
1633         * rendering/RenderArena.h:
1634         * rendering/RenderBR.cpp:
1635         (WebCore::RenderBR::RenderBR):
1636         (WebCore::RenderBR::baselinePosition):
1637         (WebCore::RenderBR::lineHeight):
1638         (WebCore::RenderBR::setStyle):
1639         (WebCore::RenderBR::caretMinOffset):
1640         (WebCore::RenderBR::positionForCoordinates):
1641         (WebCore::RenderBR::inlineBox):
1642         * rendering/RenderBR.h:
1643         * rendering/RenderBlock.cpp:
1644         * rendering/RenderBlock.h:
1645         (WebCore::RenderBlock::maxTopMargin):
1646         (WebCore::RenderBlock::maxBottomMargin):
1647         (WebCore::RenderBlock::initMaxMarginValues):
1648         (WebCore::RenderBlock::containsFloats):
1649         (WebCore::RenderBlock::setHasMarkupTruncation):
1650         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1651         (WebCore::RenderBlock::BlockSelectionInfo::block):
1652         (WebCore::RenderBlock::BlockSelectionInfo::state):
1653         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1654         (WebCore::RenderBlock::CompactInfo::clear):
1655         * rendering/RenderButton.cpp:
1656         (WebCore::RenderButton::removeChild):
1657         (WebCore::RenderButton::paintObject):
1658         * rendering/RenderButton.h:
1659         (WebCore::RenderButton::renderName):
1660         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1661         * rendering/RenderContainer.cpp:
1662         (WebCore::RenderContainer::RenderContainer):
1663         * rendering/RenderContainer.h:
1664         (WebCore::RenderContainer::firstChild):
1665         (WebCore::RenderContainer::lastChild):
1666         (WebCore::RenderContainer::calcMinMaxWidth):
1667         * rendering/RenderCounter.cpp:
1668         (WebCore::RenderCounter::RenderCounter):
1669         (WebCore::toRoman):
1670         (WebCore::toHebrew):
1671         (WebCore::RenderCounter::calcMinMaxWidth):
1672         * rendering/RenderCounter.h:
1673         * rendering/RenderFieldset.cpp:
1674         (WebCore::RenderFieldset::paintBoxDecorations):
1675         (WebCore::RenderFieldset::paintBorderMinusLegend):
1676         (WebCore::RenderFieldset::setStyle):
1677         * rendering/RenderFileUploadControl.cpp:
1678         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1679         (WebCore::RenderFileUploadControl::setStyle):
1680         (WebCore::RenderFileUploadControl::paintObject):
1681         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1682         * rendering/RenderFileUploadControl.h:
1683         (WebCore::RenderFileUploadControl::renderName):
1684         * rendering/RenderFlexibleBox.h:
1685         * rendering/RenderFlow.cpp:
1686         * rendering/RenderFlow.h:
1687         * rendering/RenderForeignObject.cpp:
1688         (WebCore::RenderForeignObject::RenderForeignObject):
1689         (WebCore::RenderForeignObject::paint):
1690         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1691         (WebCore::RenderForeignObject::layout):
1692         (WebCore::RenderForeignObject::nodeAtPoint):
1693         * rendering/RenderForeignObject.h:
1694         (WebCore::RenderForeignObject::renderName):
1695         * rendering/RenderFormElement.cpp:
1696         (WebCore::RenderFormElement::setStyle):
1697         (WebCore::RenderFormElement::layout):
1698         (WebCore::RenderFormElement::textAlignment):
1699         * rendering/RenderFormElement.h:
1700         * rendering/RenderFrame.cpp:
1701         * rendering/RenderFrame.h:
1702         (WebCore::RenderFrame::element):
1703         * rendering/RenderFrameSet.cpp:
1704         * rendering/RenderFrameSet.h:
1705         (WebCore::RenderFrameSet::element):
1706         * rendering/RenderHTMLCanvas.cpp:
1707         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1708         (WebCore::RenderHTMLCanvas::paint):
1709         * rendering/RenderHTMLCanvas.h:
1710         (WebCore::RenderHTMLCanvas::renderName):
1711         * rendering/RenderImage.cpp:
1712         (WebCore::RenderImage::RenderImage):
1713         (WebCore::RenderImage::setStyle):
1714         (WebCore::RenderImage::setContentObject):
1715         (WebCore::RenderImage::setCachedImage):
1716         (WebCore::RenderImage::imageChanged):
1717         (WebCore::RenderImage::paint):
1718         (WebCore::RenderImage::layout):
1719         (WebCore::RenderImage::updateAltText):
1720         * rendering/RenderImage.h:
1721         (WebCore::RenderImage::element):
1722         * rendering/RenderInline.cpp:
1723         (WebCore::RenderInline::RenderInline):
1724         (WebCore::RenderInline::~RenderInline):
1725         (WebCore::RenderInline::setStyle):
1726         (WebCore::RenderInline::addChildToFlow):
1727         (WebCore::RenderInline::cloneInline):
1728         (WebCore::RenderInline::splitInlines):
1729         (WebCore::RenderInline::splitFlow):
1730         (WebCore::RenderInline::paint):
1731         (WebCore::RenderInline::absoluteRects):
1732         (WebCore::RenderInline::calcMinMaxWidth):
1733         (WebCore::RenderInline::requiresLayer):
1734         (WebCore::RenderInline::width):
1735         (WebCore::RenderInline::height):
1736         (WebCore::RenderInline::renderName):
1737         (WebCore::RenderInline::nodeAtPoint):
1738         (WebCore::RenderInline::positionForCoordinates):
1739         * rendering/RenderInline.h:
1740         (WebCore::RenderInline::layout):
1741         * rendering/RenderLayer.cpp:
1742         * rendering/RenderLayer.h:
1743         (WebCore::ClipRects::ClipRects):
1744         (WebCore::RenderLayer::nextSibling):
1745         (WebCore::RenderLayer::root):
1746         (WebCore::RenderLayer::setPos):
1747         (WebCore::RenderLayer::height):
1748         (WebCore::RenderLayer::relativePositionOffset):
1749         * rendering/RenderLineEdit.cpp:
1750         (WebCore::RenderLineEdit::setStyle):
1751         (WebCore::RenderLineEdit::updateFromElement):
1752         (WebCore::RenderLineEdit::selectionStart):
1753         (WebCore::RenderLineEdit::selectionEnd):
1754         (WebCore::RenderLineEdit::setSelectionStart):
1755         (WebCore::RenderLineEdit::setSelectionEnd):
1756         (WebCore::RenderLineEdit::setSelectionRange):
1757         * rendering/RenderLineEdit.h:
1758         * rendering/RenderListBox.cpp:
1759         * rendering/RenderListBox.h:
1760         (WebCore::RenderListBox::renderName):
1761         * rendering/RenderListItem.cpp:
1762         (WebCore::RenderListItem::setStyle):
1763         (WebCore::getParentOfFirstLineBox):
1764         (WebCore::RenderListItem::updateMarkerLocation):
1765         (WebCore::RenderListItem::positionListMarker):
1766         (WebCore::RenderListItem::paint):
1767         * rendering/RenderListItem.h:
1768         * rendering/RenderListMarker.cpp:
1769         * rendering/RenderListMarker.h:
1770         (WebCore::RenderListMarker::renderName):
1771         (WebCore::RenderListMarker::isListMarker):
1772
1773 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1774
1775         Reviewed by Hyatt.
1776
1777         <rdar://problem/4478625> Basic table editing and culling
1778
1779         Refined the criteria for deletable elements, rely on the renderer more.
1780         Corrected the interface positioning for elements that have borders.
1781
1782         * editing/DeleteButtonController.cpp:
1783         (WebCore::isDeletableElement):
1784         (WebCore::DeleteButtonController::show):
1785
1786 2006-10-30  Darin Adler  <darin@apple.com>
1787
1788         - fix build
1789
1790         * loader/ResourceLoader.h: Added header guard.
1791
1792 2006-10-31  Darin Adler  <darin@apple.com>
1793
1794         Reviewed by Adam.
1795
1796         - fix FrameLoader files so they can be built on non-Mac platforms
1797
1798         * page/FramePrivate.h:
1799         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1800         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1801
1802         * page/Page.h:
1803         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1804         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1805         the other day.
1806
1807         * bridge/mac/FrameMac.mm:
1808         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1809         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1810
1811         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1812         around the PolicyCheck definition.
1813
1814         * loader/FormState.cpp: Changed import to include.
1815         * loader/FrameLoader.cpp: Ditto.
1816         * loader/MainResourceLoader.h: Ditto.
1817
1818         * loader/FrameLoaderTypes.h: Added a header guard.
1819
1820         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1821         Added #if PLATFORM(MAC) around Mac-specific details.
1822         * loader/SubresourceLoader.h: Ditto.
1823
1824         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1825         m_loader from m_frameLoader.
1826
1827         * CMakeLists.txt: Updated.
1828         * WebCoreSources.bkl: Updated.
1829
1830 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1831
1832         Reviewed and landed by Anders.
1833
1834         Patch by Zack rusin to fix: 
1835         http://bugs.webkit.org/show_bug.cgi?id=11429
1836
1837         Fix startup crash.
1838
1839         * platform/qt/FrameQtClient.cpp:
1840         (WebCore::FrameQtClientDefault::openURL):
1841
1842 2006-10-30  Zach Rusin  <zack@kde.org>
1843
1844         Reviewed and landed by Anders.
1845
1846         * platform/network/qt/ResourceHandleQt.cpp:
1847         (WebCore::ResourceHandle::receivedResponse):
1848         * platform/qt/FrameQtClient.cpp:
1849         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1850         * platform/qt/LoaderFunctionsQt.cpp:
1851         (WebCore::ServeSynchronousRequest):
1852         More build fixes.
1853
1854 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1855
1856         Reviewed and landed by Anders.
1857         
1858         - fix Qt build
1859         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1860         ResourceHandleClient
1861
1862 2006-10-30  Darin Adler  <darin@apple.com>
1863
1864         Reviewed by John Sullivan.
1865
1866         - work toward removing Objective-C data types from FrameLoader.h:
1867           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1868           and WebCoreResourceHandle
1869         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1870
1871         * page/PageState.h:
1872         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1873
1874         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1875         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1876         double for the date instead of an NSDate.
1877
1878         * bridge/mac/WebCoreFrameBridge.h:
1879         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1880         saveDocumentToPageCache methods.
1881
1882         * bridge/mac/WebCorePageState.h:
1883         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1884         an Objective-C wrapper for PageState.
1885
1886         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1887         NSDate and WebCorePageState.
1888         * loader/FrameLoaderClient.h: Changed NSDate to double.
1889         * loader/mac/FrameLoaderMac.mm:
1890         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1891         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1892         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1893         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1894         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1895         extract the parameters from the response. Changed the open function that takes
1896         a PageState to use the new C++ PageState.
1897         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1898         function; tightened up logic, removing a few cases that could never happen, as
1899         well as the unused reload boolean.
1900
1901         * ForwardingHeaders/kjs/property_map.h: Added.
1902
1903         * WebCore.exp: Updated.
1904         * WebCore.xcodeproj/project.pbxproj: Updated.
1905
1906 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1907
1908         Reviewed by Anders.
1909
1910         - added ResourceResponse class and didReceiveResponse delegate call
1911         
1912         * WebCore.xcodeproj/project.pbxproj: Added new files.
1913         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1914         expiresTimeForResponse: method.
1915         * dom/XMLTokenizer.cpp:
1916         (WebCore::openFunc): Updated to use ResourceResponse.
1917         * loader/FrameLoader.h: Update loadResourceSynchronously to
1918         use ResourceResponse.
1919         * loader/LoaderFunctions.h:
1920         * loader/icon/IconLoader.cpp:
1921         (IconLoader::didReceiveResponse): Updated from receivedResponse
1922         and made cross-platform.
1923         * loader/icon/IconLoader.h: updated for above change
1924         * loader/loader.cpp:
1925         (WebCore::Loader::receivedResponse): reduced to just saving
1926         the PlatformResponse (ideally we'd phase out use of this).
1927         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1928         logic.
1929         * loader/loader.h:
1930         * loader/mac/FrameLoaderMac.mm:
1931         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1932         as ResourceResponse.
1933         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1934         * loader/mac/LoaderFunctionsMac.mm:
1935         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1936         argument.
1937         * platform/network/ResourceHandle.cpp:
1938         * platform/network/ResourceHandle.h: Remove calls for
1939         broken out response pieces.
1940         * platform/network/ResourceHandleClient.h:
1941         (WebCore::ResourceHandleClient::didReceiveResponse): New
1942         delegate method.
1943         * platform/network/ResourceHandleInternal.h:
1944         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1945         storage of response bits, we're not gonna return them
1946         seprately any more.
1947         * platform/network/ResourceResponse.h: Added.
1948         (WebCore::ResourceResponse::ResourceResponse): Freshly
1949         implemented. Same for below.
1950         (WebCore::ResourceResponse::url):
1951         (WebCore::ResourceResponse::mimeType):
1952         (WebCore::ResourceResponse::expectedContentLength):
1953         (WebCore::ResourceResponse::textEncodingName):
1954         (WebCore::ResourceResponse::suggestedFilename):
1955         (WebCore::ResourceResponse::httpStatusCode):
1956         (WebCore::ResourceResponse::setHTTPStatusCode):
1957         (WebCore::ResourceResponse::httpHeaderField):
1958         (WebCore::ResourceResponse::httpHeaderFields):
1959         (WebCore::ResourceResponse::isMultipart):
1960         (WebCore::ResourceResponse::setExpirationDate):
1961         (WebCore::ResourceResponse::expirationDate):
1962         * platform/network/cf/ResourceHandleCFNet.cpp:
1963         (WebCore::didReceiveResponse): Send didReceiveResponse
1964         client method.
1965         * platform/network/cf/ResourceResponseCFNet.h: Added.
1966         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1967         (getResourceResponse): Helper function to get a ResourceResponse 
1968         from CFURLResponseRef.
1969         * platform/network/mac/ResourceHandleMac.mm:
1970         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1971         Don't bother cleaning up fields we no longer have.
1972         (WebCore::ResourceHandle::receivedResponse): Send
1973         didReceiveResponse client method.
1974         * platform/network/mac/ResourceResponseMac.h: Added.
1975         * platform/network/mac/ResourceResponseMac.mm: Added.
1976         (getResourceResponse): Helper function to get a ResourceResponse 
1977         from an NSURLResponse*.
1978         * rendering/HitTestResult.cpp:
1979         * xml/XSLTProcessor.cpp:
1980         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1981         * xml/xmlhttprequest.cpp:
1982         (WebCore::XMLHttpRequest::getResponseText): Store http response
1983         info in the form of a ResourceResponse, change all methods to
1984         account for this.
1985         (WebCore::XMLHttpRequest::getResponseXML):
1986         (WebCore::XMLHttpRequest::XMLHttpRequest):
1987         (WebCore::XMLHttpRequest::open):
1988         (WebCore::XMLHttpRequest::send):
1989         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1990         (WebCore::XMLHttpRequest::getResponseHeader):
1991         (WebCore::XMLHttpRequest::getStatus):
1992         (WebCore::XMLHttpRequest::getStatusText):
1993         (WebCore::XMLHttpRequest::processSyncLoadResults):
1994         (WebCore::XMLHttpRequest::didFinishLoading):
1995         (WebCore::XMLHttpRequest::didReceiveResponse):
1996         (WebCore::XMLHttpRequest::didReceiveData):
1997         * xml/xmlhttprequest.h:
1998
1999 2006-10-29  Darin Adler  <darin@apple.com>
2000
2001         - fix build
2002
2003         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2004         * loader/NetscapePlugInStreamLoader.h: Ditto.
2005         * loader/ResourceLoader.h: Ditto.
2006
2007 2006-10-29  Darin Adler  <darin@apple.com>
2008
2009         - one last name change -- WebFormState.h to FormState.h
2010         - added more empty placeholder platform-independent files
2011           for currently-Mac-specific loader classes
2012
2013         * loader/FormState.cpp: Updated include.
2014         * loader/FrameLoader.cpp: Updated include.
2015         * loader/mac/FrameLoaderMac.mm: Updated include.
2016
2017         * loader/WebFormState.h: Removed.
2018         * loader/FormState.h: Added.
2019
2020         * loader/DocumentLoader.cpp: Added.
2021         * loader/MainResourceLoader.cpp: Added.
2022         * loader/NetscapePlugInStreamLoader.cpp: Added.
2023         * loader/ResourceLoader.cpp: Added.
2024         * loader/SubresourceLoader.cpp: Added.
2025
2026         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2027
2028 2006-10-29  Darin Adler  <darin@apple.com>
2029
2030         - did the do-webcore-rename renames, including a number of changes
2031           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2032           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2033           and improvements to the names of decoder classes and their source
2034           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2035
2036         * CMakeLists.txt:
2037         * WebCore.exp:
2038         * WebCore.vcproj/WebCore/WebCore.vcproj:
2039         * WebCore.xcodeproj/project.pbxproj:
2040         * WebCoreSources.bkl:
2041         * bindings/js/kjs_binding.cpp:
2042         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2043         * bindings/js/kjs_events.cpp:
2044         (KJS::JSAbstractEventListener::handleEvent):
2045         (KJS::JSLazyEventListener::parseCode):
2046         * bindings/js/kjs_html.cpp:
2047         (KJS::JSHTMLElement::implementsCall):
2048         * bindings/js/kjs_traversal.cpp:
2049         (KJS::JSNodeFilterCondition::acceptNode):
2050         * bindings/js/kjs_window.cpp:
2051         (KJS::Window::interpreter):
2052         (KJS::Window::retrieveWindow):
2053         (KJS::Window::retrieve):
2054         (KJS::ScheduledAction::execute):
2055         * bindings/objc/DOMInternal.mm:
2056         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2057         * bridge/mac/FrameMac.mm:
2058         (WebCore::FrameMac::executionContextForDOM):
2059         (WebCore::FrameMac::bindingRootObject):
2060         (WebCore::FrameMac::windowScriptObject):
2061         (WebCore::FrameMac::windowScriptNPObject):
2062         (WebCore::FrameMac::partClearedInBegin):
2063         * bridge/mac/WebCoreEncodings.mm:
2064         * bridge/mac/WebCoreFrameBridge.mm:
2065         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2066         (-[WebCoreFrameBridge stringWithData:]):
2067         (-[WebCoreFrameBridge executionContextForView:]):
2068         * bridge/win/FrameWin.cpp:
2069         * dom/Document.cpp:
2070         (WebCore::Document::inputEncoding):
2071         (WebCore::Document::setCharset):
2072         (WebCore::Document::createHTMLEventListener):
2073         (WebCore::Document::setDecoder):
2074         * dom/Document.h:
2075         (WebCore::Document::decoder):
2076         * dom/EventTargetNode.cpp:
2077         (WebCore::EventTargetNode::dispatchGenericEvent):
2078         * html/HTMLParser.cpp:
2079         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2080         (WebCore::HTMLParser::canvasCreateErrorCheck):
2081         (WebCore::HTMLParser::isInline):
2082         * html/HTMLPlugInElement.cpp:
2083         (WebCore::HTMLPlugInElement::createNPObject):
2084         * html/HTMLScriptElement.cpp:
2085         (WebCore::HTMLScriptElement::evaluateScript):
2086         * html/HTMLTokenizer.cpp:
2087         (WebCore::HTMLTokenizer::parseTag):
2088         (WebCore::HTMLTokenizer::processToken):
2089         * ksvg2/misc/SVGDocumentExtensions.cpp:
2090         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2091         * loader/CachedCSSStyleSheet.cpp:
2092         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2093         (WebCore::CachedCSSStyleSheet::setEncoding):
2094         * loader/CachedCSSStyleSheet.h:
2095         * loader/CachedXBLDocument.cpp:
2096         (WebCore::CachedXBLDocument::CachedXBLDocument):
2097         (WebCore::CachedXBLDocument::setEncoding):
2098         * loader/CachedXBLDocument.h:
2099         * loader/CachedXSLStyleSheet.cpp:
2100         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2101         (WebCore::CachedXSLStyleSheet::setEncoding):
2102         * loader/CachedXSLStyleSheet.h:
2103         * loader/Decoder.cpp: Removed.
2104         * loader/Decoder.h: Removed.
2105         * loader/FrameLoader.cpp:
2106         * loader/FrameLoader.h:
2107         * loader/FrameLoaderClient.h:
2108         * loader/MainResourceLoader.h: Added.
2109         * loader/NetscapePlugInStreamLoader.h: Added.
2110         * loader/Request.h:
2111         (WebCore::Request::cachedResource):
2112         * loader/ResourceLoader.h: Added.
2113         * loader/SubresourceLoader.h: Added.
2114         * loader/TextResourceDecoder.cpp: Added.
2115         (WebCore::TextResourceDecoder::determineContentType):
2116         (WebCore::TextResourceDecoder::defaultEncoding):
2117         (WebCore::TextResourceDecoder::TextResourceDecoder):
2118         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2119         (WebCore::TextResourceDecoder::setEncoding):
2120         (WebCore::TextResourceDecoder::checkForBOM):
2121         (WebCore::TextResourceDecoder::checkForCSSCharset):
2122         (WebCore::TextResourceDecoder::checkForHeadCharset):
2123         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2124         (WebCore::TextResourceDecoder::decode):
2125         (WebCore::TextResourceDecoder::flush):
2126         * loader/TextResourceDecoder.h: Added.
2127         * loader/WebDocumentLoader.h: Removed.
2128         * loader/WebLoader.h: Removed.
2129         * loader/WebMainResourceLoader.h: Removed.
2130         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2131         * loader/WebSubresourceLoader.h: Removed.
2132         * loader/loader.cpp:
2133         (WebCore::Loader::servePendingRequests):
2134         (WebCore::Loader::receivedAllData):
2135         (WebCore::Loader::receivedResponse):
2136         (WebCore::Loader::didReceiveData):
2137         (WebCore::Loader::cancelRequests):
2138         (WebCore::Loader::jobForRequest):
2139         * loader/mac/DocumentLoaderMac.mm:
2140         * loader/mac/FormDataStream.m: Added.
2141         * loader/mac/FrameLoaderMac.mm:
2142         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2143         (WebCore::FrameLoader::addPlugInStreamLoader):
2144         (WebCore::FrameLoader::removePlugInStreamLoader):
2145         (WebCore::FrameLoader::addSubresourceLoader):
2146         (WebCore::FrameLoader::removeSubresourceLoader):
2147         (WebCore::FrameLoader::willSendRequest):
2148         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2149         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2150         (WebCore::FrameLoader::didReceiveResponse):
2151         (WebCore::FrameLoader::didReceiveData):
2152         (WebCore::FrameLoader::didFinishLoad):
2153         (WebCore::FrameLoader::didFailToLoad):
2154         (WebCore::FrameLoader::open):
2155         (WebCore::FrameLoader::willUseArchive):
2156         (WebCore::FrameLoader::isArchiveLoadPending):
2157         * loader/mac/ImageDocumentMac.mm:
2158         * loader/mac/LoaderFunctionsMac.mm:
2159         (WebCore::CheckCacheObjectStatus):
2160         * loader/mac/MainResourceLoaderMac.mm:
2161         (WebCore::MainResourceLoader::MainResourceLoader):
2162         (WebCore::MainResourceLoader::releaseDelegate):
2163         (WebCore::MainResourceLoader::didCancel):
2164         (WebCore::MainResourceLoader::addData):
2165         (WebCore::MainResourceLoader::willSendRequest):
2166         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2167         (WebCore::MainResourceLoader::didReceiveData):
2168         (WebCore::MainResourceLoader::didFinishLoading):
2169         (WebCore::MainResourceLoader::setDefersLoading):
2170         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2171         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2172         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2173         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2174         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2175         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2176         (WebCore::NetscapePlugInStreamLoader::didFail):
2177         (WebCore::NetscapePlugInStreamLoader::didCancel):
2178         * loader/mac/ResourceLoaderMac.mm:
2179         (WebCore::ResourceLoader::ResourceLoader):
2180         (WebCore::ResourceLoader::~ResourceLoader):
2181         (WebCore::ResourceLoader::releaseResources):
2182         (WebCore::ResourceLoader::load):
2183         (WebCore::ResourceLoader::setDefersLoading):
2184         (WebCore::ResourceLoader::frameLoader):
2185         (WebCore::ResourceLoader::addData):
2186         (WebCore::ResourceLoader::resourceData):
2187         (WebCore::ResourceLoader::clearResourceData):
2188         (WebCore::ResourceLoader::willSendRequest):
2189         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2190         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2191         (WebCore::ResourceLoader::didReceiveResponse):
2192         (WebCore::ResourceLoader::didReceiveData):
2193         (WebCore::ResourceLoader::willStopBufferingData):
2194         (WebCore::ResourceLoader::didFinishLoading):
2195         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2196         (WebCore::ResourceLoader::didFail):
2197         (WebCore::ResourceLoader::willCacheResponse):
2198         (WebCore::ResourceLoader::didCancel):
2199         (WebCore::ResourceLoader::cancel):
2200         (WebCore::ResourceLoader::setIdentifier):
2201         (WebCore::ResourceLoader::response):
2202         (WebCore::ResourceLoader::inConnectionCallback):
2203         (WebCore::ResourceLoader::cancelledError):
2204         (WebCore::ResourceLoader::receivedCredential):
2205         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2206         (WebCore::ResourceLoader::receivedCancellation):
2207         (WebCore::ResourceLoader::delegate):
2208         (WebCore::ResourceLoader::releaseDelegate):
2209         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2210         * loader/mac/SubresourceLoaderMac.mm:
2211         (WebCore::SubresourceLoader::SubresourceLoader):
2212         (WebCore::SubresourceLoader::willSendRequest):
2213         (WebCore::SubresourceLoader::didReceiveResponse):
2214         (WebCore::SubresourceLoader::didReceiveData):
2215         (WebCore::SubresourceLoader::didFinishLoading):
2216         (WebCore::SubresourceLoader::didFail):
2217         (WebCore::SubresourceLoader::didCancel):
2218         * loader/mac/WebFormDataStream.h: Removed.
2219         * loader/mac/WebFormDataStream.m: Removed.
2220         * page/Frame.cpp:
2221         (WebCore::Frame::javaScriptEnabled):
2222         (WebCore::Frame::scriptProxy):
2223         (WebCore::Frame::executeScript):
2224         (WebCore::Frame::write):
2225         (WebCore::Frame::userGestureHint):
2226         (WebCore::Frame::saveInterpreterBuiltins):
2227         (WebCore::Frame::restoreInterpreterBuiltins):
2228         (WebCore::Frame::backslashAsCurrencySymbol):
2229         * page/Frame.h:
2230         * page/FramePrivate.h:
2231         * platform/StreamingTextDecoder.cpp: Removed.
2232         * platform/StreamingTextDecoder.h: Removed.
2233         * platform/StreamingTextDecoderICU.cpp: Removed.
2234         * platform/StreamingTextDecoderICU.h: Removed.
2235         * platform/TextCodec.cpp: Added.
2236         * platform/TextCodec.h: Added.
2237         * platform/TextCodecICU.cpp: Added.
2238         * platform/TextCodecICU.h: Added.
2239         * platform/TextCodecLatin1.h:
2240         * platform/TextCodecUTF16.h:
2241         * platform/TextDecoder.h:
2242         * platform/TextEncoding.cpp:
2243         * platform/TextEncodingRegistry.cpp:
2244         * platform/image-decoders/jpeg/jmorecfg.h:
2245         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2246         * platform/mac/StreamingTextDecoderMac.h: Removed.
2247         * platform/mac/TextCodecMac.cpp: Added.
2248         * platform/mac/TextCodecMac.h: Added.
2249         * platform/network/ResourceHandleInternal.h:
2250         * platform/network/mac/ResourceHandleMac.mm:
2251         * platform/qt/FrameQt.cpp:
2252         (WebCore::FrameQt::bindingRootObject):
2253         * platform/qt/LoaderFunctionsQt.cpp:
2254         (WebCore::CheckCacheObjectStatus):
2255         * rendering/RenderObject.cpp:
2256         (WebCore::RenderObject::backslashAsCurrencySymbol):
2257         * xml/XSLTProcessor.cpp:
2258         (WebCore::XSLTProcessor::createDocumentFromSource):
2259         * xml/xmlhttprequest.cpp:
2260         (WebCore::XMLHttpRequest::didReceiveData):
2261         * xml/xmlhttprequest.h:
2262
2263 2006-10-29  Darin Adler  <darin@apple.com>
2264
2265         Rubber stamped by Adam (kinda).
2266
2267         - add Mac suffixes and correct filenames inside loader/mac
2268
2269         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2270
2271         * loader/mac/FrameLoader.mm: Removed.
2272         * loader/mac/WebDocumentLoader.mm: Removed.
2273         * loader/mac/WebLoader.mm: Removed.
2274         * loader/mac/WebMainResourceLoader.mm: Removed.
2275         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2276         * loader/mac/WebSubresourceLoader.mm: Removed.
2277
2278         * loader/mac/FrameLoaderMac.mm: Added.
2279         * loader/mac/DocumentLoaderMac.mm: Added.
2280         * loader/mac/ResourceLoaderMac.mm: Added.
2281         * loader/mac/MainResourceLoaderMac.mm: Added.
2282         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2283         * loader/mac/SubresourceLoaderMac.mm: Removed.
2284
2285 2006-10-29  Darin Adler  <darin@apple.com>
2286
2287         Reviewed by Adam.
2288
2289         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2290           and FrameLoader.cpp mostly ready
2291
2292         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2293         FormState.cpp. Removed WebFormState.mm.
2294
2295         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2296         get this header compiling on non-Mac.
2297         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2298         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2299
2300         * loader/FrameLoaderClient.h: Added some ifdefs.
2301         * loader/WebDocumentLoader.h: Ditto.
2302         * loader/WebLoader.h: Ditto.
2303         * loader/WebMainResourceLoader.h: Ditto.
2304
2305         * loader/mac/WebDocumentLoader.mm:
2306         (WebCore::DocumentLoader::isLoadingInAPISense):
2307         Rewrote to work without bridge, partly to remove the need for ObjC
2308         bridge type in the header, and also because we're tearing down the bridge.
2309
2310         * loader/mac/WebMainResourceLoader.mm:
2311         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2312         m_contentLength and m_bytesReceived.
2313         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2314         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2315
2316         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2317         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2318
2319         * loader/mac/FormState.mm: Removed.
2320         * loader/FormState.cpp: Added.
2321
2322 2006-10-29  Darin Adler  <darin@apple.com>
2323
2324         Rubber stamped by Adam.
2325
2326         - moving towards use of FrameLoader cross-platform; move the headers
2327           for the Mac loader from loader/mac into loader, in preparation for
2328           making them useful on non-Mac
2329
2330         * WebCore.xcodeproj/project.pbxproj:
2331
2332         * loader/mac/FrameLoader.h: Removed.
2333         * loader/mac/WebDocumentLoader.h: Removed.
2334         * loader/mac/WebFormState.h: Removed.
2335         * loader/mac/WebLoader.h: Removed.
2336         * loader/mac/WebMainResourceLoader.h: Removed.
2337         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2338         * loader/mac/WebSubresourceLoader.h: Removed.
2339
2340         * loader/FrameLoader.h: Added.
2341         * loader/WebDocumentLoader.h: Added.
2342         * loader/WebFormState.h: Added.
2343         * loader/WebLoader.h: Added.
2344         * loader/WebMainResourceLoader.h: Added.
2345         * loader/WebNetscapePlugInStreamLoader.h: Added.
2346         * loader/WebSubresourceLoader.h: Added.
2347
2348 2006-10-29  Adam Roben  <aroben@apple.com>
2349
2350         Reviewed by Geoff.
2351
2352         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2353         r17405.
2354
2355         * platform/DeprecatedString.h:
2356
2357 2006-10-29  Beth Dakin  <bdakin@apple.com>
2358
2359         Rubber stamped by Geoff.
2360
2361         This is a followup to my HitTestResult checkin. Most of the 
2362         HitTestResult local variables in the code were named i or info for 
2363         when the class was named NodeInfo. This patch renames all of these 
2364         local variables to result.
2365
2366         * dom/Document.cpp:
2367         (WebCore::Document::prepareMouseEvent):
2368         * html/HTMLAreaElement.cpp:
2369         (WebCore::HTMLAreaElement::mapMouseEvent):
2370         * html/HTMLMapElement.cpp:
2371         (WebCore::HTMLMapElement::mapMouseEvent):
2372         * rendering/EllipsisBox.cpp:
2373         (WebCore::EllipsisBox::nodeAtPoint):
2374         * rendering/EllipsisBox.h:
2375         * rendering/InlineBox.cpp:
2376         (WebCore::InlineBox::nodeAtPoint):
2377         * rendering/InlineFlowBox.cpp:
2378         (WebCore::InlineFlowBox::nodeAtPoint):
2379         * rendering/InlineTextBox.cpp:
2380         (WebCore::InlineTextBox::nodeAtPoint):
2381         * rendering/RenderBlock.cpp:
2382         (WebCore::RenderBlock::isPointInScrollbar):
2383         (WebCore::RenderBlock::nodeAtPoint):
2384         * rendering/RenderBlock.h:
2385         * rendering/RenderBox.cpp:
2386         (WebCore::RenderBox::nodeAtPoint):
2387         * rendering/RenderBox.h:
2388         * rendering/RenderFlow.cpp:
2389         (WebCore::RenderFlow::hitTestLines):
2390         * rendering/RenderFlow.h:
2391         * rendering/RenderForeignObject.cpp:
2392         (WebCore::RenderForeignObject::nodeAtPoint):
2393         * rendering/RenderFrameSet.cpp:
2394         (WebCore::RenderFrameSet::nodeAtPoint):
2395         * rendering/RenderImage.cpp:
2396         (WebCore::RenderImage::nodeAtPoint):
2397         * rendering/RenderInline.cpp:
2398         (WebCore::RenderInline::nodeAtPoint):
2399         * rendering/RenderInline.h:
2400         * rendering/RenderLayer.cpp:
2401         (WebCore::RenderLayer::autoscroll):
2402         (WebCore::RenderLayer::hitTest):
2403         (WebCore::RenderLayer::hitTestLayer):
2404         (WebCore::RenderLayer::updateHoverActiveState):
2405         * rendering/RenderListBox.cpp:
2406         (WebCore::RenderListBox::isPointInScrollbar):
2407         * rendering/RenderObject.cpp:
2408         (WebCore::RenderObject::hitTest):
2409         (WebCore::RenderObject::setInnerNode):
2410         (WebCore::RenderObject::nodeAtPoint):
2411         * rendering/RenderObject.h:
2412         * rendering/RenderPath.cpp:
2413         (WebCore::RenderPath::nodeAtPoint):
2414         * rendering/RenderSVGImage.cpp:
2415         (WebCore::RenderSVGImage::nodeAtPoint):
2416         * rendering/RenderSVGText.cpp:
2417         (WebCore::RenderSVGText::nodeAtPoint):
2418         * rendering/RenderTableRow.cpp:
2419         (WebCore::RenderTableRow::nodeAtPoint):
2420         * rendering/RenderTableRow.h:
2421         * rendering/RenderTableSection.cpp:
2422         (WebCore::RenderTableSection::nodeAtPoint):
2423         * rendering/RenderTableSection.h:
2424         * rendering/RenderTextControl.cpp:
2425         (WebCore::RenderTextControl::nodeAtPoint):
2426         * rendering/RootInlineBox.cpp:
2427         (WebCore::RootInlineBox::nodeAtPoint):
2428         * rendering/RootInlineBox.h:
2429
2430 2006-10-29  Adam Roben  <aroben@apple.com>
2431
2432         More semi-fixes.
2433
2434         * page/Page.cpp: Forgot to wrap the actual definition of
2435         setDefersLoading() in PLATFORM(MAC).
2436         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2437
2438 2006-10-29  Adam Roben  <aroben@apple.com>
2439
2440         Build semi-fix.
2441
2442         Move all FrameLoader-related code in Page.{cpp,h} within #if
2443         PLATFORM(MAC), since this class currently only exists on Mac.
2444
2445         * page/Page.cpp:
2446         * page/Page.h:
2447
2448 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2449
2450         build fix.
2451         
2452         * platform/PlatformString.h:
2453         (WebCore::String::operator NSString*):
2454
2455 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2456
2457         Rolled out accidental commit.
2458         
2459         * platform/AtomicString.h:
2460         (WebCore::AtomicString::AtomicString):
2461         (WebCore::AtomicString::operator NSString*):
2462
2463 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2464
2465         RS by Darin.
2466
2467         Rolled out change to map NULL Strings to nil NSStrings because it caused
2468         even more AppKit crashes. Maybe we should remove the NSString * operator
2469         entirely, since its use is not straight-forward, and require callers to
2470         specify explicitly whether they tolerate NULL.
2471         
2472         * platform/AtomicString.h:
2473         * platform/PlatformString.h:
2474         (WebCore::String::operator NSString*):
2475         * platform/mac/TextFieldMac.mm:
2476         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2477
2478 2006-10-29  Darin Adler  <darin@apple.com>
2479
2480         Reviewed by Geoff.
2481
2482         - fixed storage leak showing up on the buildbot
2483
2484         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2485         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2486
2487 2006-10-29  Darin Adler  <darin@apple.com>
2488
2489         Rubber stamped by Adam.
2490
2491         - renamed WebFrameLoaderClient to match the class name inside it
2492
2493         * loader/mac/WebFrameLoaderClient.h: Removed.
2494         * loader/FrameLoaderClient.h: Moved it here.
2495
2496         * WebCore.xcodeproj/project.pbxproj: Updated project.
2497
2498         * bridge/mac/FrameMac.mm: Updated includes.
2499         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2500         * loader/mac/FrameLoader.mm: Ditto.
2501         * loader/mac/WebLoader.h: Ditto.
2502
2503 2006-10-29  Darin Adler  <darin@apple.com>
2504
2505         Reviewed by Mitz.
2506
2507         - fix crash visible on buildbot and also when running the test
2508           anchor-image-scrolled-x-y.html under libgmalloc
2509
2510         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2511         now that the class is named ResourceHandle.
2512         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2513         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2514         a local RefPtr before calling finishJobAndHandle, since we might get
2515         cancelled inside that function, so we should not rely on m_handle to
2516         keep the ResourceHandle alive.
2517         (WebCore::SubresourceLoader::didFail): Ditto.
2518         (WebCore::SubresourceLoader::didCancel): Ditto.
2519
2520 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2521
2522         - build fix
2523
2524         * platform/network/mac/ResourceHandleMac.mm:
2525
2526 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2527
2528         Rubber stamped by Darin.
2529
2530         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2531
2532         * CMakeLists.txt:
2533         * Projects/gdk/webcore-gdk.bkl:
2534         * WebCore.vcproj/WebCore/WebCore.vcproj:
2535         * WebCore.xcodeproj/project.pbxproj:
2536         * WebCoreSources.bkl:
2537         * bridge/mac/FrameMac.mm:
2538         * bridge/win/FrameWin.cpp:
2539         * dom/XMLTokenizer.cpp:
2540         * loader/Cache.cpp:
2541         * loader/CachedResource.h:
2542         * loader/LoaderFunctions.h:
2543         * loader/icon/IconLoader.cpp:
2544         (IconLoader::startLoading):
2545         (IconLoader::didReceiveData):
2546         (IconLoader::didFinishLoading):
2547         * loader/icon/IconLoader.h:
2548         * loader/loader.cpp:
2549         (WebCore::Loader::servePendingRequests):
2550         (WebCore::Loader::receivedAllData):
2551         (WebCore::Loader::receivedResponse):
2552         (WebCore::Loader::didReceiveData):
2553         (WebCore::Loader::cancelRequests):
2554         (WebCore::Loader::jobForRequest):
2555         * loader/loader.h:
2556         * loader/mac/IconLoaderMac.mm:
2557         (IconLoader::receivedResponse):
2558         * loader/mac/LoaderFunctionsMac.mm:
2559         * loader/mac/WebLoader.h:
2560         * loader/mac/WebSubresourceLoader.h:
2561         * loader/mac/WebSubresourceLoader.mm:
2562         (WebCore::SubresourceLoader::SubresourceLoader):
2563         (WebCore::SubresourceLoader::create):
2564         * platform/gdk/FrameGdk.cpp:
2565         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2566         (WebCore::FrameGdkClientDefault::openURL):
2567         (WebCore::FrameGdkClientDefault::submitForm):
2568         (WebCore::FrameGdkClientDefault::receivedResponse):
2569         (WebCore::FrameGdkClientDefault::didReceiveData):
2570         (WebCore::FrameGdkClientDefault::receivedAllData):
2571         * platform/gdk/FrameGdk.h:
2572         * platform/gdk/TemporaryLinkStubs.cpp:
2573         (WebCore::ServeSynchronousRequest):
2574         (WebCore::ResourceHandle::assembleResponseHeaders):
2575         (WebCore::ResourceHandle::retrieveCharset):
2576         * platform/network/ResourceHandle.cpp: Added.
2577         (WebCore::ResourceHandle::ResourceHandle):
2578         (WebCore::ResourceHandle::create):
2579         (WebCore::ResourceHandle::isErrorPage):
2580         (WebCore::ResourceHandle::error):
2581         (WebCore::ResourceHandle::setError):
2582         (WebCore::ResourceHandle::responseEncoding):
2583         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2584         (WebCore::ResourceHandle::kill):
2585         (WebCore::ResourceHandle::requestHeaders):
2586         (WebCore::ResourceHandle::url):
2587         (WebCore::ResourceHandle::postData):
2588         (WebCore::ResourceHandle::method):
2589         (WebCore::ResourceHandle::client):
2590         * platform/network/ResourceHandle.h: Added.
2591         (WebCore::ResourceHandle::getInternal):
2592         * platform/network/ResourceHandleClient.h: Added.
2593         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2594         (WebCore::ResourceHandleClient::didReceiveData):
2595         (WebCore::ResourceHandleClient::didFinishLoading):
2596         (WebCore::ResourceHandleClient::receivedRedirect):
2597         (WebCore::ResourceHandleClient::receivedResponse):
2598         (WebCore::ResourceHandleClient::receivedAllData):
2599         * platform/network/ResourceHandleInternal.h: Added.
2600         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2601         * platform/network/ResourceLoader.cpp: Removed.
2602         * platform/network/ResourceLoader.h: Removed.
2603         * platform/network/ResourceLoaderClient.h: Removed.
2604         * platform/network/ResourceLoaderInternal.h: Removed.
2605         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2606         (WebCore::willSendRequest):
2607         (WebCore::didReceiveResponse):
2608         (WebCore::didReceiveData):
2609         (WebCore::didFinishLoading):
2610         (WebCore::didFail):
2611         (WebCore::willCacheResponse):
2612         (WebCore::didReceiveChallenge):
2613         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2614         (WebCore::ResourceHandle::~ResourceHandle):
2615         (WebCore::ResourceHandle::start):
2616         (WebCore::ResourceHandle::cancel):
2617         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2618         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2619         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2620         (WebCore::ResourceHandle::~ResourceHandle):
2621         (WebCore::ResourceHandle::start):
2622         (WebCore::ResourceHandle::cancel):
2623         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2624         (WebCore::ResourceHandleManager::ResourceHandleManager):
2625         (WebCore::ResourceHandleManager::get):
2626         (WebCore::ResourceHandleManager::useSimpleTransfer):
2627         (WebCore::writeCallback):
2628         (WebCore::ResourceHandleManager::downloadTimerCallback):
2629         (WebCore::ResourceHandleManager::remove):
2630         (WebCore::ResourceHandleManager::add):
2631         (WebCore::ResourceHandleManager::cancel):
2632         * platform/network/gdk/ResourceHandleManager.h: Added.
2633         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2634         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2635         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2636         * platform/network/mac/ResourceHandleMac.mm: Added.
2637         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2638         (WebCore::ResourceHandle::~ResourceHandle):
2639         (WebCore::ResourceHandle::start):
2640         (WebCore::ResourceHandle::assembleResponseHeaders):
2641         (WebCore::ResourceHandle::retrieveResponseEncoding):
2642         (WebCore::ResourceHandle::receivedResponse):
2643         (WebCore::ResourceHandle::cancel):
2644         (WebCore::ResourceHandle::redirectedToURL):
2645         (WebCore::ResourceHandle::addData):
2646         (WebCore::ResourceHandle::finishJobAndHandle):
2647         (WebCore::ResourceHandle::reportError):
2648         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2649         * platform/network/qt/ResourceHandleManager.cpp: Added.
2650         (WebCore::ResourceHandleManager::ResourceHandleManager):
2651         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2652         (WebCore::ResourceHandleManager::self):
2653         (WebCore::ResourceHandleManager::slotData):
2654         (WebCore::ResourceHandleManager::slotMimetype):
2655         (WebCore::ResourceHandleManager::slotResult):
2656         (WebCore::ResourceHandleManager::remove):
2657         (WebCore::ResourceHandleManager::add):
2658         (WebCore::ResourceHandleManager::cancel):
2659         * platform/network/qt/ResourceHandleManager.h: Added.
2660         * platform/network/qt/ResourceHandleQt.cpp: Added.
2661         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2662         (WebCore::ResourceHandle::~ResourceHandle):
2663         (WebCore::ResourceHandle::start):
2664         (WebCore::ResourceHandle::cancel):
2665         (WebCore::ResourceHandle::assembleResponseHeaders):
2666         (WebCore::ResourceHandle::retrieveResponseEncoding):
2667         (WebCore::ResourceHandle::receivedResponse):
2668         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2669         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2670         * platform/network/qt/ResourceLoaderManager.h: Removed.
2671         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2672         * platform/network/win/ResourceHandleWin.cpp: Added.
2673         (WebCore::):
2674         (WebCore::addToOutstandingJobs):
2675         (WebCore::lookupResourceHandle):
2676         (WebCore::ResourceHandleWndProc):
2677         (WebCore::initializeOffScreenResourceHandleWindow):
2678         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2679         (WebCore::ResourceHandle::~ResourceHandle):
2680         (WebCore::ResourceHandle::onHandleCreated):
2681         (WebCore::ResourceHandle::onRequestRedirected):
2682         (WebCore::ResourceHandle::onRequestComplete):
2683         (WebCore::ResourceHandle::start):
2684         (WebCore::ResourceHandle::fileLoadTimer):
2685         (WebCore::ResourceHandle::cancel):
2686         (WebCore::ResourceHandle::setHasReceivedResponse):
2687         (WebCore::ResourceHandle::hasReceivedResponse):
2688         * platform/network/win/ResourceHandleWin.h: Added.
2689         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2690         * platform/network/win/ResourceLoaderWin.h: Removed.
2691         * platform/qt/FrameQt.cpp:
2692         * platform/qt/FrameQtClient.cpp:
2693         (WebCore::FrameQtClientDefault::openURL):
2694         (WebCore::FrameQtClientDefault::submitForm):
2695         (WebCore::FrameQtClientDefault::receivedResponse):
2696         (WebCore::FrameQtClientDefault::didReceiveData):
2697         (WebCore::FrameQtClientDefault::receivedAllData):
2698         * platform/qt/FrameQtClient.h:
2699         * platform/win/TemporaryLinkStubs.cpp:
2700         (WebCore::ResourceHandle::assembleResponseHeaders):
2701         (WebCore::ResourceHandle::retrieveResponseEncoding):
2702         (WebCore::ServeSynchronousRequest):
2703         * xml/XSLTProcessor.cpp:
2704         * xml/xmlhttprequest.cpp:
2705         (WebCore::XMLHttpRequest::send):
2706         (WebCore::XMLHttpRequest::didFinishLoading):
2707         (WebCore::XMLHttpRequest::receivedRedirect):
2708         (WebCore::XMLHttpRequest::didReceiveData):
2709         * xml/xmlhttprequest.h:
2710
2711 t2006-10-29  Darin Adler  <darin@apple.com>
2712
2713         Reviewed by Maciej.
2714
2715         - eliminate use of NSArray to carry form data around
2716
2717         * WebCore.exp:
2718         * WebCore.xcodeproj/project.pbxproj:
2719         * bridge/mac/FormDataMac.h: Removed.
2720         * bridge/mac/FormDataMac.mm: Removed.
2721         * bridge/mac/FrameMac.h:
2722         * bridge/mac/WebCoreFrameBridge.h:
2723         * bridge/mac/WebCoreFrameBridge.mm:
2724         * html/HTMLFormElement.cpp:
2725         (WebCore::HTMLFormElement::submit):
2726         * loader/FormData.h:
2727         (WebCore::FormData::isEmpty):
2728         * loader/mac/FrameLoader.h:
2729         * loader/mac/FrameLoader.mm:
2730         (WebCore::FrameLoader::load):
2731         (WebCore::FrameLoader::post):
2732         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2733         (WebCore::FrameLoader::loadResourceSynchronously):
2734         * loader/mac/LoaderFunctionsMac.mm:
2735         (WebCore::ServeSynchronousRequest):
2736         * loader/mac/WebFormDataStream.h:
2737         * loader/mac/WebFormDataStream.m:
2738         (WebCore::pairRetain):
2739         (WebCore::pairRelease):
2740         (WebCore::pairEqual):
2741         (WebCore::pairHash):
2742         (WebCore::closeCurrentStream):
2743         (WebCore::scheduleWithPair):
2744         (WebCore::advanceCurrentStream):
2745         (WebCore::openNextStream):
2746         (WebCore::formCreate):
2747         (WebCore::formFinalize):
2748         (WebCore::formOpen):
2749         (WebCore::formRead):
2750         (WebCore::formCanRead):
2751         (WebCore::formClose):
2752         (WebCore::formSchedule):
2753         (WebCore::formUnschedule):
2754         (WebCore::formEventCallback):
2755         (WebCore::setHTTPBody):
2756         * loader/mac/WebSubresourceLoader.h:
2757         * loader/mac/WebSubresourceLoader.mm:
2758         (WebCore::SubresourceLoader::create):
2759         * platform/network/mac/ResourceLoaderMac.mm:
2760
2761 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2762
2763         Reviewed by Darin.
2764
2765         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2766
2767         * loader/mac/WebSubresourceLoader.h:
2768         * loader/mac/WebSubresourceLoader.mm:
2769         (WebCore::SubresourceLoader::create):
2770         * platform/network/mac/ResourceLoaderMac.mm:
2771         (WebCore::ResourceLoader::start):
2772
2773 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2774
2775         Reviewed by Darin.
2776
2777         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2778
2779         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2780         
2781         * WebCore.xcodeproj/project.pbxproj:
2782         * bridge/mac/WebCoreFrameBridge.h:
2783         * loader/mac/FrameLoader.h:
2784         * loader/mac/FrameLoader.mm:
2785         * loader/mac/LoaderFunctionsMac.mm:
2786         * loader/mac/WebLoader.h:
2787         * loader/mac/WebSubresourceLoader.h:
2788         * loader/mac/WebSubresourceLoader.mm:
2789         (WebCore::SubresourceLoader::SubresourceLoader):
2790         (WebCore::SubresourceLoader::create):
2791         (WebCore::SubresourceLoader::willSendRequest):
2792         (WebCore::SubresourceLoader::didReceiveResponse):
2793         (WebCore::SubresourceLoader::didReceiveData):
2794         (WebCore::SubresourceLoader::didFinishLoading):
2795         (WebCore::SubresourceLoader::didFail):
2796         (WebCore::SubresourceLoader::didCancel):
2797         * platform/network/ResourceLoader.h:
2798         * platform/network/ResourceLoaderInternal.h:
2799         * platform/network/mac/ResourceLoaderMac.mm:
2800         (WebCore::ResourceLoader::~ResourceLoader):
2801         (WebCore::ResourceLoader::start):
2802         (WebCore::ResourceLoader::receivedResponse):
2803         (WebCore::ResourceLoader::cancel):
2804         (WebCore::ResourceLoader::redirectedToURL):
2805         (WebCore::ResourceLoader::addData):
2806         (WebCore::ResourceLoader::finishJobAndHandle):
2807         (WebCore::ResourceLoader::reportError):
2808         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2809         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2810         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2811
2812 2006-10-28  Darin Adler  <darin@apple.com>
2813
2814         Reviewed by Maciej.
2815
2816         - eliminated the use of Objective-C for the policy decider
2817           machinery, obviating the need for WebPolicyDecider,
2818           WebCoreFrameLoaderAsDelegate, and
2819           WebCoreMainResourceLoaderAsPolicyDelegate
2820
2821         - grouped the state related to policy decisions into a PolicyCheck
2822           class to simplify the FrameLoader logic
2823
2824         - removed six methods from the bridge, reducing FrameLoader's use of
2825           the bridge to a single method
2826
2827         - changed form state to always use HashMap instead of NSDictionary
2828
2829         - moved the defersLoading flag from WebView to WebCore::Page
2830           and changed code to consistently call it defersLoading rather
2831           than defersCallbacks
2832
2833         - updated for rename of PassRefPtr::release to releaseRef
2834         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2835         - cleaned up kjs_binding.h a bit
2836         - cleaned up FrameMac.h a bit
2837
2838         * loader/mac/WebPolicyDecider.h: Removed.
2839         * loader/mac/WebPolicyDecider.mm: Removed.
2840         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2841
2842         * WebCore.exp:
2843         * bindings/js/kjs_binding.cpp:
2844         (KJS::ScriptInterpreter::ScriptInterpreter):
2845         (KJS::ScriptInterpreter::wasRunByUserGesture):
2846         * bindings/js/kjs_binding.h:
2847         (KJS::ScriptInterpreter::setCurrentEvent):
2848         (KJS::ScriptInterpreter::setInlineCode):
2849         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2850         (KJS::ScriptInterpreter::getCurrentEvent):
2851         (KJS::cacheDOMObject):
2852         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2853         * bridge/AXObjectCache.h:
2854         * bridge/mac/BrowserExtensionMac.mm:
2855         (WebCore::BrowserExtensionMac::createNewWindow):
2856         * bridge/mac/FrameMac.h:
2857         * bridge/mac/FrameMac.mm:
2858         (WebCore::FrameMac::loadRequest):
2859         (WebCore::FrameMac::submitForm):
2860         (WebCore::FrameMac::urlSelected):
2861         (WebCore::FrameMac::userAgent):
2862         (WebCore::FrameMac::passMouseDownEventToWidget):
2863         (WebCore::FrameMac::handleMouseMoveEvent):
2864         * bridge/mac/PageMac.mm:
2865         (WebCore::Page::Page):
2866         * bridge/mac/WebCoreEditCommand.mm:
2867         * bridge/mac/WebCoreFrameBridge.h:
2868         * bridge/mac/WebCoreFrameBridge.mm:
2869         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2870         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2871         * css/CSSComputedStyleDeclaration.cpp:
2872         (WebCore::):
2873         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2874         * css/CSSPrimitiveValue.cpp:
2875         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2876         (WebCore::CSSPrimitiveValue::cleanup):
2877         (WebCore::CSSPrimitiveValue::cssText):
2878         * css/CSSPrimitiveValue.h:
2879         (WebCore::CSSPrimitiveValue::):
2880         * css/CSSValueList.cpp:
2881         (WebCore::CSSValueList::append):
2882         * css/cssparser.cpp:
2883         (WebCore::CSSParser::parseValue):
2884         * css/cssparser.h:
2885         * css/cssstyleselector.cpp:
2886         (WebCore::CSSStyleSelector::applyProperty):
2887         * dom/Document.cpp:
2888         (WebCore::Document::Document):
2889         (WebCore::Document::updateSelection):
2890         (WebCore::Document::implicitClose):
2891         (WebCore::Document::setFocusNode):
2892         * dom/Document.h:
2893         * editing/ReplaceSelectionCommand.h:
2894         * html/HTMLParser.cpp:
2895         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2896         * loader/mac/FrameLoader.h:
2897         (WebCore::PolicyCheck::request):
2898         * loader/mac/FrameLoader.mm:
2899         (WebCore::FrameLoader::~FrameLoader):
2900         (WebCore::FrameLoader::safeLoad):
2901         (WebCore::FrameLoader::load):
2902         (WebCore::FrameLoader::open):
2903         (WebCore::FrameLoader::stopLoading):
2904         (WebCore::setAllDefersLoading):
2905         (WebCore::FrameLoader::setDefersLoading):
2906         (WebCore::FrameLoader::willSendRequest):
2907         (WebCore::FrameLoader::receivedMainResourceError):
2908         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2909         (WebCore::FrameLoader::commitProvisionalLoad):
2910         (WebCore::FrameLoader::checkNavigationPolicy):
2911         (WebCore::FrameLoader::checkContentPolicy):
2912         (WebCore::FrameLoader::cancelContentPolicyCheck):
2913         (WebCore::FrameLoader::stopPolicyCheck):
2914         (WebCore::FrameLoader::checkNewWindowPolicy):
2915         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2916         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2917         (WebCore::FrameLoader::continueAfterContentPolicy):
2918         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2919         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2920         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2921         (WebCore::FrameLoader::closeDocument):
2922         (WebCore::FrameLoader::transitionToCommitted):
2923         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2924         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2925         (WebCore::FrameLoader::post):
2926         (WebCore::FrameLoader::detachFromParent):
2927         (WebCore::FrameLoader::addExtraFieldsToRequest):
2928         (WebCore::PolicyCheck::PolicyCheck):
2929         (WebCore::PolicyCheck::clear):
2930         (WebCore::PolicyCheck::set):
2931         (WebCore::PolicyCheck::call):
2932         (WebCore::PolicyCheck::dropRequest):
2933         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2934         * loader/mac/WebFormState.h:
2935         * loader/mac/WebFormState.mm:
2936         * loader/mac/WebFrameLoaderClient.h:
2937         * loader/mac/WebLoader.h:
2938         (WebCore::WebResourceLoader::defersLoading):
2939         * loader/mac/WebLoader.mm:
2940         (WebCore::WebResourceLoader::WebResourceLoader):
2941         (WebCore::WebResourceLoader::load):
2942         (WebCore::WebResourceLoader::setDefersLoading):
2943         * loader/mac/WebMainResourceLoader.h:
2944         * loader/mac/WebMainResourceLoader.mm:
2945         (WebCore::MainResourceLoader::MainResourceLoader):
2946         (WebCore::MainResourceLoader::releaseDelegate):
2947         (WebCore::MainResourceLoader::didCancel):
2948         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2949         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2950         (WebCore::MainResourceLoader::willSendRequest):
2951         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2952         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2953         (WebCore::MainResourceLoader::didReceiveResponse):
2954         (WebCore::MainResourceLoader::didReceiveData):
2955         (WebCore::MainResourceLoader::didFinishLoading):
2956         (WebCore::MainResourceLoader::didFail):
2957         (WebCore::MainResourceLoader::loadNow):
2958         (WebCore::MainResourceLoader::load):
2959         (WebCore::MainResourceLoader::setDefersLoading):
2960         * page/Frame.cpp:
2961         (WebCore::Frame::paint):
2962         * page/FrameView.cpp:
2963         (WebCore::FrameView::layout):
2964         * page/FrameView.h:
2965         * page/Page.cpp:
2966         (WebCore::Page::setDefersLoading):
2967         * page/Page.h:
2968         (WebCore::Page::defersLoading):
2969         * platform/DeprecatedString.h:
2970         * platform/DeprecatedStringList.h:
2971         * platform/FontFallbackList.h:
2972         * platform/PlatformKeyboardEvent.h:
2973         * platform/PlatformMouseEvent.h:
2974         * platform/PlatformWheelEvent.h:
2975         * platform/mac/ClipboardMac.h:
2976         * platform/mac/ClipboardMac.mm:
2977         (WebCore::ClipboardMac::setDragImage):
2978         (WebCore::ClipboardMac::dragNSImage):
2979         (WebCore::ClipboardMac::sourceOperation):
2980         (WebCore::ClipboardMac::destinationOperation):
2981         * rendering/RenderObject.cpp:
2982         (WebCore::RenderObject::setStyle):
2983         * rendering/break_lines.cpp:
2984         (WebCore::nextBreakablePosition):
2985
2986 2006-10-28  Adam Roben  <aroben@apple.com>
2987
2988         Reviewed by Maciej.
2989
2990         Fix layout tests that broke after r17399. Mitz discovered that the
2991         failures were caused by HitTestResult::m_point being uninitialized
2992         much of the time. HitTestResults are now always constructed with a
2993         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2994         point instead of being passed one explicitly.
2995
2996         * WebCore.exp: Change constructor symbol.
2997         * bridge/mac/FrameMac.mm:
2998         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2999         hitTest().
3000         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3001         * bridge/mac/WebCoreAXObject.mm:
3002         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3003         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3004         * dom/Document.cpp:
3005         (WebCore::Document::elementFromPoint): Ditto.
3006         (WebCore::Document::prepareMouseEvent): Ditto.
3007         * page/Frame.cpp:
3008         (WebCore::Frame::isPointInsideSelection): Ditto.
3009         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3010         * page/FrameView.cpp:
3011         (WebCore::FrameView::handleWheelEvent): Ditto.
3012         * rendering/HitTestResult.cpp:
3013         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3014         passed point.
3015         * rendering/HitTestResult.h: Update constructor declaration.
3016         * rendering/RenderLayer.cpp:
3017         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3018         hitTest().
3019         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3020         HitTestResult instead of being passed one.
3021         (WebCore::RenderLayer::hitTestLayer): Ditto.
3022         * rendering/RenderLayer.h: Update declarations.
3023
3024 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3025
3026         Reviewed by Anders.
3027
3028         Fix Qt/Linux build.
3029
3030         * CMakeLists.txt:
3031         * platform/qt/FrameQtClient.cpp:
3032         (WebCore::numRequests):
3033         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3034         * platform/qt/PopupMenuQt.cpp:
3035         (WebCore::PopupMenu::updateFromElement):
3036
3037 2006-10-28  David Carson  <dacarson@gmail.com>
3038
3039         Tweaked by Sam. Reviewed by Brady.
3040
3041         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3042         Initialize m_modifyBiasSet to false, as it sometimes gets 
3043         used before it has been initalized.
3044
3045         * editing/SelectionController.cpp:
3046         (WebCore::SelectionController::SelectionController):
3047
3048 2006-10-28  Beth Dakin  <bdakin@apple.com>
3049
3050         Reviewed by Darin.
3051
3052         This is the WebCore half of pushing elementAtPoint and the backend 
3053         of WebElementDictionary into WebCore. Most of the changes below are 
3054         to accommodate one of the following:
3055                 
3056         -NodeInfo is now a stand-alone class called HitTestResult. 
3057                 Previously it was defined in RenderObject.h, but not for 
3058                 any particular reason. The WebElementDictionary 
3059                 functionality that was pushed into WebCore has been pushed 
3060                 specifically into the this class. In fact, 
3061                 WebElementDictionary now keeps a HitTestResult as a member 
3062                 varibale.
3063                 
3064         -The enumeration AccessPolicy is now called 
3065                 ClipboardAccessPolicy and is defined in its own header. It 
3066                 was previously defined in ClipboardMac.h, but is now 
3067                 defined independently to avoid including ClipboardMac.h 
3068                 from within FrameMac.h since FrameMac.h is now included in 
3069                 WebElementDictionary.m in WebKit.
3070                 
3071         -Element now has a virtual target() for the sake of 
3072                 NodeInfo::targetFrame() 
3073
3074         * WebCore.exp: Several WebCore functions are newly called from 
3075         WebKit, so they have been added here. 
3076         * WebCore.xcodeproj/project.pbxproj:
3077         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3078         to ClipboardMac.
3079         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3080         * bridge/mac/FrameMac.mm:
3081         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3082         and HitTestResult changes.
3083         (WebCore::FrameMac::eventMayStartDrag): Same.
3084         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3085         (WebCore::FrameMac::dispatchCPPEvent): Same.
3086         (WebCore::FrameMac::mayDHTMLCut): Same.
3087         (WebCore::FrameMac::mayDHTMLCopy): Same.
3088         (WebCore::FrameMac::mayDHTMLPaste): Same.
3089         (WebCore::FrameMac::tryDHTMLCut): Same
3090         (WebCore::FrameMac::tryDHTMLCopy): Same.
3091         (WebCore::FrameMac::tryDHTMLPaste): Same.
3092         * bridge/mac/WebCoreAXObject.mm:
3093         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3094         HitTestResult changes.
3095         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3096         * bridge/mac/WebCoreFrameBridge.h: Same.
3097         * bridge/mac/WebCoreFrameBridge.mm:
3098         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3099         ClipboardAccessPolicy changes.
3100         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3101         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3102         * dom/Document.cpp:
3103         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3104         changes.
3105         (WebCore::Document::prepareMouseEvent): Same.
3106         * dom/Element.h:
3107         (WebCore::Element::target): Now has a virtual target()
3108         * html/HTMLAnchorElement.h: Same.
3109         * html/HTMLAreaElement.cpp:
3110         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3111         changes.
3112         * html/HTMLAreaElement.h: Virtual target()
3113         * html/HTMLBaseElement.h:
3114         (WebCore::HTMLBaseElement::target): Same.
3115         * html/HTMLFormElement.h: Same.
3116         * html/HTMLLinkElement.h: Same.
3117         * html/HTMLMapElement.cpp:
3118         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3119         changes.
3120         * html/HTMLMapElement.h: Same.
3121         * page/Frame.cpp:
3122         (WebCore::Frame::isPointInsideSelection): Same.
3123         (WebCore::Frame::hitTestResultAtPoint): Same. 
3124         * page/Frame.h: Same.
3125         * page/FrameView.cpp:
3126         (WebCore::FrameView::handleWheelEvent): Same.
3127         * platform/mac/ClipboardAccessPolicy.h: Added.
3128         (WebCore::):
3129         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3130         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3131         ClipboardAccessPolicy.
3132         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3133         (WebCore::ClipboardMac::ClipboardMac):
3134         (WebCore::ClipboardMac::setAccessPolicy):
3135         (WebCore::ClipboardMac::clearData):
3136         (WebCore::ClipboardMac::clearAllData):
3137         (WebCore::ClipboardMac::getData):
3138         (WebCore::ClipboardMac::setData):
3139         (WebCore::ClipboardMac::types):
3140         (WebCore::ClipboardMac::setDragImage):
3141         (WebCore::ClipboardMac::setDropEffect):
3142         (WebCore::ClipboardMac::setEffectAllowed):
3143         * rendering/EllipsisBox.cpp:
3144         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3145         changes.
3146         * rendering/EllipsisBox.h:
3147         * rendering/HitTestResult.cpp: Added.
3148         (WebCore::HitTestResult::HitTestResult):
3149         (WebCore::HitTestResult::~HitTestResult):
3150         (WebCore::HitTestResult::operator=):
3151         (WebCore::HitTestResult::setInnerNode):
3152         (WebCore::HitTestResult::setInnerNonSharedNode):
3153         (WebCore::HitTestResult::setURLElement):
3154         (WebCore::HitTestResult::setScrollbar):
3155         (WebCore::HitTestResult::targetFrame):
3156         (WebCore::HitTestResult::boundingBox):
3157         (WebCore::HitTestResult::isSelected):
3158         (WebCore::HitTestResult::title):
3159         * rendering/HitTestResult.h: Added.
3160         (WebCore::HitTestResult::readonly):
3161         (WebCore::HitTestResult::active):
3162         (WebCore::HitTestResult::mouseMove):
3163         (WebCore::HitTestResult::innerNode):
3164         (WebCore::HitTestResult::innerNonSharedNode):
3165         (WebCore::HitTestResult::point):
3166         (WebCore::HitTestResult::URLElement):
3167         (WebCore::HitTestResult::scrollbar):
3168         (WebCore::HitTestResult::setPoint):
3169         (WebCore::HitTestResult::setReadonly):
3170         (WebCore::HitTestResult::setActive):
3171         (WebCore::HitTestResult::setMouseMove):
3172         * rendering/InlineBox.cpp:
3173         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3174         * rendering/InlineBox.h: Same.
3175         * rendering/InlineFlowBox.cpp:
3176         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3177         * rendering/InlineFlowBox.h: Same.
3178         * rendering/InlineTextBox.cpp: 
3179         (WebCore::InlineTextBox::nodeAtPoint): Same.
3180         * rendering/InlineTextBox.h: Same.
3181         * rendering/RenderBlock.cpp:
3182         (WebCore::RenderBlock::isPointInScrollbar): Same.
3183         (WebCore::RenderBlock::nodeAtPoint): Same.
3184         * rendering/RenderBlock.h: Same.
3185         * rendering/RenderBox.cpp:
3186         (WebCore::RenderBox::nodeAtPoint): Same.
3187         * rendering/RenderBox.h: Same.
3188         * rendering/RenderFlow.cpp:
3189         (WebCore::RenderFlow::hitTestLines): Same.
3190         * rendering/RenderFlow.h: Same.
3191         * rendering/RenderForeignObject.cpp:
3192         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3193         * rendering/RenderForeignObject.h: Same.
3194         * rendering/RenderFrameSet.cpp:
3195         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3196         * rendering/RenderFrameSet.h: Same.
3197         * rendering/RenderImage.cpp:
3198         (WebCore::RenderImage::nodeAtPoint): Same.
3199         * rendering/RenderImage.h: Same.
3200         * rendering/RenderInline.cpp:
3201         (WebCore::RenderInline::nodeAtPoint): Same.
3202         * rendering/RenderInline.h: Same.
3203         * rendering/RenderLayer.cpp:
3204         (WebCore::RenderLayer::autoscroll): Same.
3205         (WebCore::RenderLayer::hitTest): Same.
3206         (WebCore::RenderLayer::hitTestLayer): Same.
3207         (WebCore::RenderLayer::updateHoverActiveState): Same.
3208         * rendering/RenderLayer.h: Same.
3209         * rendering/RenderListBox.cpp:
3210         (WebCore::RenderListBox::isPointInScrollbar): Same.
3211         * rendering/RenderListBox.h: Same.
3212         * rendering/RenderObject.cpp:
3213         (WebCore::RenderObject::hitTest): Same.
3214         (WebCore::RenderObject::setInnerNode): Same.
3215         (WebCore::RenderObject::nodeAtPoint): Same.
3216         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3217         declare HitTestResult.
3218         * rendering/RenderPath.cpp:
3219         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3220         changes.
3221         * rendering/RenderPath.h: Same.
3222         * rendering/RenderSVGImage.cpp:
3223         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3224         * rendering/RenderSVGImage.h: Same
3225         * rendering/RenderSVGText.cpp:
3226         (WebCore::RenderSVGText::nodeAtPoint): Same.
3227         * rendering/RenderSVGText.h: Same.
3228         * rendering/RenderTableRow.cpp:
3229         (WebCore::RenderTableRow::nodeAtPoint): Same.
3230         * rendering/RenderTableRow.h: Same.
3231         * rendering/RenderTableSection.cpp:
3232         (WebCore::RenderTableSection::nodeAtPoint): Same.
3233         * rendering/RenderTableSection.h: Same.
3234         * rendering/RenderText.h: Same.
3235         (WebCore::RenderText::nodeAtPoint): Same.
3236         * rendering/RenderTextControl.cpp:
3237         (WebCore::RenderTextControl::nodeAtPoint): Same.
3238         * rendering/RenderTextControl.h: Same.
3239         * rendering/RootInlineBox.cpp:
3240         (WebCore::RootInlineBox::nodeAtPoint): Same.
3241         * rendering/RootInlineBox.h: Same.
3242
3243 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3244
3245         Reviewed by Anders.
3246
3247         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3248         impact of fixing it again.
3249
3250         * bridge/mac/FrameMac.mm:
3251         (WebCore::FrameMac::clear):
3252
3253 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3254
3255         Reviewed by John & Adam.
3256
3257         - assorted speedups to fix perf regression from fixing correctness regression
3258
3259         * WebCore.exp: exported new methods.
3260         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3261         * bridge/mac/WebCoreFrameBridge.h:
3262         * bridge/mac/WebCoreFrameBridge.mm:
3263         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3264         * loader/CachedResource.h:
3265         * loader/mac/CachedResourceMac.mm: Added.
3266         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3267         now cached in the CachedObject.
3268         * loader/mac/FrameLoader.h:
3269         * loader/mac/FrameLoader.mm:
3270         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3271         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3272         * loader/mac/LoaderFunctionsMac.mm:
3273         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3274         just call loadedResourceFromMemoryCache.
3275         * loader/mac/WebFrameLoaderClient.h:
3276
3277 2006-10-27  Oliver Hunt  <oliver@apple.com>
3278
3279         Reviewed by Maciej.
3280
3281         build fix
3282
3283         * dom/Document.cpp:
3284         (WebCore::Document::referrer):
3285
3286 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3287
3288         Reviewed by Maciej.
3289
3290         Moved some WebCoreFrameBridge functions into FrameLoader.
3291         
3292         I had to make FrameLoader.h capable of compiling in C++-only source files
3293         by adding some forward declarations and __OBJC__ #ifdefs.
3294
3295         * WebCore.exp:
3296         * bridge/mac/FrameMac.h:
3297         * bridge/mac/FrameMac.mm:
3298         (WebCore::FrameMac::createEmptyDocument):
3299         (WebCore::FrameMac::tokenizerProcessedData):
3300         * bridge/mac/WebCoreFrameBridge.h:
3301         * bridge/mac/WebCoreFrameBridge.mm:
3302         * dom/Document.cpp:
3303         (WebCore::Document::processHttpEquiv):
3304         (WebCore::Document::referrer):
3305         * loader/LoaderFunctions.h:
3306         * loader/mac/FrameLoader.h:
3307         * loader/mac/FrameLoader.mm:
3308         (WebCore::numRequests):
3309         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3310         (WebCore::FrameLoader::isReloading):
3311         (WebCore::FrameLoader::referrer):
3312         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3313         (WebCore::FrameLoader::startLoadingResource):
3314         * loader/mac/LoaderFunctionsMac.mm:
3315         (WebCore::CheckIfReloading):
3316         * page/Frame.h:
3317         * page/FrameTree.cpp:
3318         (WebCore::FrameTree::isDescendantOf):
3319         (WebCore::FrameTree::traverseNext):
3320         * page/FrameTree.h:
3321         * platform/network/mac/ResourceLoaderMac.mm:
3322         (WebCore::ResourceLoader::start):
3323
3324 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3325
3326         Reviewed by Darin.
3327
3328         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3329
3330         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3331
3332         * editing/DeleteButtonController.cpp:
3333         (WebCore::isDeletableElement):
3334         (WebCore::enclosingDeletableElement):
3335         (WebCore::DeleteButtonController::respondToChangedSelection):
3336
3337 2006-10-27  John Sullivan  <sullivan@apple.com>
3338
3339         Reviewed by Kevin Decker
3340         
3341         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3342         you haven't not finished reading this.
3343
3344         * rendering/InlineTextBox.h:
3345         * rendering/InlineTextBox.cpp:
3346         (WebCore::InlineTextBox::paint):
3347         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3348         considered also.
3349         (WebCore::InlineTextBox::paintDocumentMarkers):
3350         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3351         markers should be painted, instead of a marker type. This avoids walking the collection of
3352         markers multiple times back to back. Now handles grammar markers.
3353
3354 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3355
3356         Reviewed by Beth.
3357
3358         Renamed Copy Files to Copy Generated Headers.
3359         Copy 4 DOM*Internal.h headers.
3360
3361         * WebCore.xcodeproj/project.pbxproj:
3362         * bindings/scripts/CodeGeneratorObjC.pm:
3363
3364 2006-10-27  John Sullivan  <sullivan@apple.com>
3365
3366         Reviewed by Anders
3367
3368         * WebCore.exp:
3369         exported symbol for FrameMac->advanceToNextSpelling()
3370         
3371         * bridge/mac/WebCoreFrameBridge.h:
3372         * bridge/mac/WebCoreFrameBridge.mm:
3373         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3374
3375 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3376
3377         Reviewed by harrison
3378         
3379         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3380         REGRESSION: First newline missing from textarea's value
3381         
3382         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3383         
3384         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3385         (the line break) then a br to prevent the '\n' from collapsing, since the 
3386         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3387         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3388         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3389         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3390         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3391         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3392         the shadow div will be placeholders or collapsed.
3393         
3394         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3395         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3396         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3397         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3398         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3399         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3400         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3401         before it.
3402         
3403         * editing/CompositeEditCommand.cpp:
3404         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3405         a br or '\n' if content inserted just before it will cause it to collapse.
3406         * editing/CompositeEditCommand.h:
3407         * editing/InsertLineBreakCommand.cpp:
3408         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3409         to prevent a collapse as was used for the line break.  Fixed comments.
3410         * editing/InsertTextCommand.cpp:
3411         (WebCore::InsertTextCommand::input): Call the renamed function.
3412         
3413 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3414
3415         Reviewed by Brady.
3416
3417         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3418         String became an empty NSString *, instead of nil. This will become important
3419         as we start using this conversion more.
3420         
3421         Added work-around for AppKit crash that semantic accuracy revealed.
3422         
3423         No testcase because I don't think there's a way to reflect this change
3424         in a webpage yet.
3425
3426         * platform/PlatformString.h:
3427         (WebCore::String::operator NSString*):
3428         * platform/mac/TextFieldMac.mm:
3429         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3430
3431 2006-10-27  David Harrison  <harrison@apple.com>
3432
3433         Reviewed by Maciej,
3434
3435         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3436
3437         * bridge/mac/WebCoreAXObject.mm:
3438         (blockquoteLevel):
3439         Calculate and return the blockquote level of the element.
3440         
3441         (AXAttributeStringSetBlockquoteLevel):
3442         Add, if non-zero, or clear the block quote level attribute.
3443         
3444         (AXAttributedStringAppendText):
3445         Send AXAttributeStringSetBlockquoteLevel.
3446
3447 2006-10-27  Darin Adler  <darin@apple.com>
3448
3449         - fix one error in the Qt build
3450
3451         * platform/qt/GraphicsContextQt.cpp:
3452         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3453         Updated.
3454
3455 2006-10-27  Darin Adler  <darin@apple.com>
3456
3457         Reviewed by Maciej.
3458
3459         * WebCore.exp: Export more symbols needed by WebKit.
3460
3461 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3462
3463         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3464
3465         Fixed layout test crash. Oops.
3466         
3467         * loader/mac/WebDocumentLoader.mm:
3468         (WebCore::canonicalizedTitle):
3469
3470 2006-10-26  John Sullivan  <sullivan@apple.com>
3471
3472         Reviewed by Brady
3473         
3474         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3475         
3476         This restores some of the nil-handling that was implicit before some of the code was converted from
3477         Objective-C to C++.
3478
3479         * bridge/mac/FrameMac.mm:
3480         (WebCore::FrameMac::loadRequest):
3481         handle nil FrameMac
3482         
3483         * bridge/mac/WebCoreFrameBridge.mm:
3484         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3485         handle nil Frame
3486
3487 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3488
3489         Reviewed by Darin, Maciej.
3490
3491         Removed many uses of NSString *.
3492         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
3493         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
3494         
3495         PLT says no performance regression.
3496         
3497         * WebCore.exp:
3498         * bridge/mac/WebCoreFrameBridge.mm:
3499         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3500         * loader/mac/FrameLoader.h:
3501         * loader/mac/FrameLoader.mm:
3502         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3503         (WebCore::FrameLoader::load):
3504         (WebCore::FrameLoader::canShowMIMEType):
3505         (WebCore::FrameLoader::representationExistsForURLScheme):
3506         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3507         (WebCore::FrameLoader::checkContentPolicy):
3508         (WebCore::FrameLoader::reloadAllowingStaleData):
3509         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
3510         (WebCore::FrameLoader::checkNewWindowPolicy):
3511         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3512         (WebCore::FrameLoader::transitionToCommitted):
3513         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3514         (WebCore::FrameLoader::post):
3515         * loader/mac/WebDocumentLoader.h:
3516         * loader/mac/WebDocumentLoader.mm:
3517         (WebCore::DocumentLoader::doesProgressiveLoad):
3518         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3519         (WebCore::DocumentLoader::title):
3520         (WebCore::DocumentLoader::setOverrideEncoding):
3521         (WebCore::DocumentLoader::overrideEncoding):
3522         (WebCore::DocumentLoader::setTitle):
3523         * loader/mac/WebFrameLoaderClient.h:
3524         * loader/mac/WebMainResourceLoader.mm:
3525         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3526
3527 2006-10-26  Timothy Hatcher  <timothy@apple.com>
3528
3529         Reviewed by Adam.
3530
3531         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com