35c63b51cbdc5662b7db1ae5e6949f3d3fb7ec0a
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-10  Timothy Hatcher  <timothy@apple.com>
2
3         Reviewed by Hyatt.
4
5         Check for BHIDDEN in isVisible() also.
6
7         * rendering/RenderStyle.h:
8         (WebCore::BorderValue::isVisible):
9
10 2006-11-10  Timothy Hatcher  <timothy@apple.com>
11
12         Reviewed by Adam.
13
14         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
15
16         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
17
18         * editing/DeleteButtonController.cpp:
19         (WebCore::isDeletableElement):
20         * rendering/RenderStyle.h:
21         (WebCore::BorderValue::isVisible):
22
23 2006-11-10  Adam Roben  <aroben@apple.com>
24
25         Rubberstamped by Anders.
26
27         Back out some accidentally-committed changes from r17711.
28
29         * page/Frame.cpp:
30         (WebCore::Frame::command):
31         (WebCore::FramePrivate::FramePrivate):
32         * page/Frame.h:
33         * page/FramePrivate.h:
34
35 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
36
37         Reviewed by Geoff.
38
39         Add more commands, make toggleBold and toggleItalic executable commands.
40
41         * WebCore.exp:
42         * editing/Editor.cpp:
43         (WebCore::execCopy):
44         (WebCore::execCut):
45         (WebCore::execDelete):
46         (WebCore::execForwardDelete):
47         (WebCore::execPaste):
48         (WebCore::execSelectAll):
49         (WebCore::execToggleBold):
50         (WebCore::execToggleItalic):
51         (WebCore::enabled):
52         (WebCore::canPaste):
53         (WebCore::hasEditableSelection):
54         (WebCore::hasEditableRangeSelection):
55         (WebCore::hasRangeSelection):
56         (WebCore::hasRichlyEditableSelection):
57         (WebCore::CommandEntry::):
58         * editing/Editor.h:
59
60 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
61
62         Reviewed by Maciej, Geoff.
63
64         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
65         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
66
67         * WebCore.exp:
68         * bridge/mac/WebCoreFrameBridge.h:
69         * bridge/mac/WebCoreFrameBridge.mm:
70         * editing/Editor.cpp:
71         (WebCore::execMoveBackward):
72         (WebCore::execMoveBackwardAndModifySelection):
73         (WebCore::execMoveDown):
74         (WebCore::execMoveDownAndModifySelection):
75         (WebCore::execMoveForward):
76         (WebCore::execMoveForwardAndModifySelection):
77         (WebCore::execMoveLeft):
78         (WebCore::execMoveLeftAndModifySelection):
79         (WebCore::execMoveRight):
80         (WebCore::execMoveRightAndModifySelection):
81         (WebCore::execMoveToBeginningOfDocument):
82         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
83         (WebCore::execMoveToBeginningOfSentence):
84         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
85         (WebCore::execMoveToBeginningOfLine):
86         (WebCore::execMoveToBeginningOfLineAndModifySelection):
87         (WebCore::execMoveToBeginningOfParagraph):
88         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
89         (WebCore::execMoveToEndOfDocument):
90         (WebCore::execMoveToEndOfDocumentAndModifySelection):
91         (WebCore::execMoveToEndOfSentence):
92         (WebCore::execMoveToEndOfSentenceAndModifySelection):
93         (WebCore::execMoveToEndOfLine):
94         (WebCore::execMoveToEndOfLineAndModifySelection):
95         (WebCore::execMoveToEndOfParagraph):
96         (WebCore::execMoveToEndOfParagraphAndModifySelection):
97         (WebCore::execMoveParagraphBackwardAndModifySelection):
98         (WebCore::execMoveParagraphForwardAndModifySelection):
99         (WebCore::execMoveUp):
100         (WebCore::execMoveUpAndModifySelection):
101         (WebCore::execMoveWordBackward):
102         (WebCore::execMoveWordBackwardAndModifySelection):
103         (WebCore::execMoveWordForward):
104         (WebCore::execMoveWordForwardAndModifySelection):
105         (WebCore::execMoveWordLeft):
106         (WebCore::execMoveWordLeftAndModifySelection):
107         (WebCore::execMoveWordRight):
108         (WebCore::execMoveWordRightAndModifySelection):
109         (WebCore::enabledAnySelection):
110         (WebCore::createCommandMap):
111         (WebCore::CommandEntry::):
112         (WebCore::Editor::execCommand):
113         * editing/Editor.h:
114
115 2006-11-10  Brady Eidson  <beidson@apple.com>
116
117         Reviewed by Darin
118
119         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
120
121         * WebCore.exp:
122         * WebCore.xcodeproj/project.pbxproj:
123         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
124         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
125         * loader/FrameLoaderClient.h:
126         * loader/icon/IconDatabase.cpp:
127         (WebCore::IconDatabase::sharedIconDatabase):
128         (WebCore::IconDatabase::~IconDatabase):
129         * loader/icon/IconDatabase.h:
130         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
131         (WebCore::IconDatabase::enabled):
132         * loader/icon/IconLoader.cpp:
133         (WebCore::IconLoader::finishLoading):
134         * loader/mac/FrameLoaderMac.mm:
135
136 2006-11-10  Zack Rusin  <zack@kde.org>
137
138         Reviewed and landed by Anders.
139
140         Adjust platform Qt/KDE code to the recent loader
141         changes. 
142
143         * CMakeLists.txt:
144         * loader/DocumentLoader.h:
145         * loader/FrameLoader.cpp:
146         (WebCore::FrameLoader::createEmptyDocument):
147         * loader/FrameLoader.h:
148         * loader/FrameLoaderClient.h:
149         * loader/qt/DocumentLoaderQt.cpp: Added.
150         (WebCore::canonicalizedTitle):
151         (WebCore::DocumentLoader::DocumentLoader):
152         (WebCore::DocumentLoader::frameLoader):
153         (WebCore::DocumentLoader::~DocumentLoader):
154         (WebCore::DocumentLoader::URL):
155         (WebCore::DocumentLoader::unreachableURL):
156         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
157         (WebCore::DocumentLoader::isStopping):
158         (WebCore::DocumentLoader::clearErrors):
159         (WebCore::DocumentLoader::stopLoading):
160         (WebCore::DocumentLoader::setupForReplace):
161         (WebCore::DocumentLoader::commitIfReady):
162         (WebCore::DocumentLoader::finishedLoading):
163         (WebCore::DocumentLoader::setCommitted):
164         (WebCore::DocumentLoader::isCommitted):
165         (WebCore::DocumentLoader::setLoading):
166         (WebCore::DocumentLoader::isLoading):
167         (WebCore::DocumentLoader::doesProgressiveLoad):
168         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
169         (WebCore::DocumentLoader::updateLoading):
170         (WebCore::DocumentLoader::setFrame):
171         (WebCore::DocumentLoader::attachToFrame):
172         (WebCore::DocumentLoader::detachFromFrame):
173         (WebCore::DocumentLoader::prepareForLoadStart):
174         (WebCore::DocumentLoader::loadingStartedTime):
175         (WebCore::DocumentLoader::setIsClientRedirect):
176         (WebCore::DocumentLoader::isClientRedirect):
177         (WebCore::DocumentLoader::setPrimaryLoadComplete):
178         (WebCore::DocumentLoader::isLoadingInAPISense):
179         (WebCore::DocumentLoader::stopRecordingResponses):
180         (WebCore::DocumentLoader::title):
181         (WebCore::DocumentLoader::triggeringAction):
182         (WebCore::DocumentLoader::setTriggeringAction):
183         (WebCore::DocumentLoader::setOverrideEncoding):
184         (WebCore::DocumentLoader::overrideEncoding):
185         (WebCore::DocumentLoader::setTitle):
186         (WebCore::DocumentLoader::URLForHistory):
187         * loader/qt/FrameLoaderClientQt.cpp: Added.
188         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
189         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
190         (WebCore::FrameLoaderClientQt::detachFrameLoader):
191         (WebCore::FrameLoaderClientQt::hasWebView):
192         (WebCore::FrameLoaderClientQt::hasFrameView):
193         (WebCore::FrameLoaderClientQt::hasBackForwardList):
194         (WebCore::FrameLoaderClientQt::resetBackForwardList):
195         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
196         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
197         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
198         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
199         (WebCore::FrameLoaderClientQt::makeDocumentView):
200         (WebCore::FrameLoaderClientQt::makeRepresentation):
201         (WebCore::FrameLoaderClientQt::forceLayout):
202         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
203         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
204         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
205         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
206         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
207         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
208         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
209         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
210         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
211         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
212         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
213         (WebCore::FrameLoaderClientQt::willCloseDocument):
214         (WebCore::FrameLoaderClientQt::detachedFromParent1):
215         (WebCore::FrameLoaderClientQt::detachedFromParent2):
216         (WebCore::FrameLoaderClientQt::detachedFromParent3):
217         (WebCore::FrameLoaderClientQt::detachedFromParent4):
218         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
219         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
220         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
221         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
222         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
223         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
224         (WebCore::FrameLoaderClientQt::dispatchWillClose):
225         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
226         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
227         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
228         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
229         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
230         (WebCore::FrameLoaderClientQt::dispatchShow):
231         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
232         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
233         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
234         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
235         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
236         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
237         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
238         (WebCore::FrameLoaderClientQt::progressStarted):
239         (WebCore::FrameLoaderClientQt::progressCompleted):
240         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
241         (WebCore::FrameLoaderClientQt::willChangeTitle):
242         (WebCore::FrameLoaderClientQt::didChangeTitle):
243         (WebCore::FrameLoaderClientQt::finishedLoading):
244         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
245         (WebCore::FrameLoaderClientQt::setDefersLoading):
246         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
247         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
248         (WebCore::FrameLoaderClientQt::clearArchivedResources):
249         (WebCore::FrameLoaderClientQt::canShowMIMEType):
250         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
251         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
252         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
253         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
254         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
255         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
256         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
257         (WebCore::FrameLoaderClientQt::didFinishLoad):
258         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
259         (WebCore::FrameLoaderClientQt::setTitle):
260         (WebCore::FrameLoaderClientQt::userAgent):
261         * loader/qt/FrameLoaderClientQt.h: Added.
262         * loader/qt/FrameLoaderQt.cpp:
263         (WebCore::FrameLoader::submitForm):
264         (WebCore::FrameLoader::overrideMediaType):
265         (WebCore::FrameLoader::getHistoryLength):
266         (WebCore::FrameLoader::referrer):
267         (WebCore::FrameLoader::detachFromParent):
268         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
269         (WebCore::FrameLoader::goBackOrForward):
270         (WebCore::FrameLoader::historyURL):
271         (WebCore::FrameLoader::didFirstLayout):
272         (WebCore::FrameLoader::canGoBackOrForward):
273         (WebCore::FrameLoader::partClearedInBegin):
274         (WebCore::FrameLoader::saveDocumentState):
275         (WebCore::FrameLoader::restoreDocumentState):
276         (WebCore::FrameLoader::didChangeTitle):
277         (WebCore::FrameLoader::redirectDataToPlugin):
278         (WebCore::PolicyCheck::PolicyCheck):
279         (WebCore::PolicyCheck::clear):
280         (WebCore::PolicyCheck::set):
281         (WebCore::PolicyCheck::call):
282         (WebCore::PolicyCheck::clearRequest):
283         * loader/qt/NavigationActionQt.cpp: Added.
284         (WebCore::navigationType):
285         (WebCore::NavigationAction::NavigationAction):
286         * loader/qt/ResourceLoaderQt.cpp: Added.
287         (WebCore::ResourceLoader::ResourceLoader):
288         (WebCore::ResourceLoader::~ResourceLoader):
289         (WebCore::ResourceLoader::setDefersLoading):
290         (WebCore::ResourceLoader::cancel):
291         (WebCore::ResourceLoader::loadsBlocked):
292         * platform/MimeTypeRegistry.cpp:
293         (WebCore::initialiseSupportedImageMIMETypes):
294         * platform/network/qt/ResourceHandleManager.cpp:
295         (WebCore::ResourceHandleManager::slotResult):
296         (WebCore::ResourceHandleManager::cancel):
297         * platform/qt/ChromeClientQt.cpp: Added.
298         (WebCore::rootWindowForFrame):
299         (WebCore::ChromeClientQt::ChromeClientQt):
300         (WebCore::ChromeClientQt::~ChromeClientQt):
301         (WebCore::ChromeClientQt::setWindowRect):
302         (WebCore::ChromeClientQt::windowRect):
303         (WebCore::ChromeClientQt::pageRect):
304         (WebCore::ChromeClientQt::scaleFactor):
305         (WebCore::ChromeClientQt::focus):
306         (WebCore::ChromeClientQt::unfocus):
307         (WebCore::ChromeClientQt::createWindow):
308         (WebCore::ChromeClientQt::createModalDialog):
309         (WebCore::ChromeClientQt::show):
310         (WebCore::ChromeClientQt::canRunModal):
311         (WebCore::ChromeClientQt::runModal):
312         (WebCore::ChromeClientQt::setToolbarsVisible):
313         (WebCore::ChromeClientQt::toolbarsVisible):
314         (WebCore::ChromeClientQt::setStatusbarVisible):
315         (WebCore::ChromeClientQt::statusbarVisible):
316         (WebCore::ChromeClientQt::setScrollbarsVisible):
317         (WebCore::ChromeClientQt::scrollbarsVisible):
318         (WebCore::ChromeClientQt::setMenubarVisible):
319         (WebCore::ChromeClientQt::menubarVisible):
320         (WebCore::ChromeClientQt::setResizable):
321         * platform/qt/ChromeClientQt.h: Added.
322         * platform/qt/EditorClientQt.cpp:
323         (WebCore::EditorClientQt::shouldBeginEditing):
324         (WebCore::EditorClientQt::shouldEndEditing):
325         (WebCore::EditorClientQt::shouldApplyStyle):
326         (WebCore::EditorClientQt::didBeginEditing):
327         (WebCore::EditorClientQt::respondToChangedContents):
328         (WebCore::EditorClientQt::didEndEditing):
329         * platform/qt/EditorClientQt.h:
330         * platform/qt/FrameQt.cpp:
331         (WebCore::FrameQt::FrameQt):
332         (WebCore::FrameQt::~FrameQt):
333         (WebCore::FrameQt::keyEvent):
334         * platform/qt/FrameQt.h:
335         * platform/qt/FrameQtClient.cpp:
336         (WebCore::FrameQtClientDefault::openURL):
337         (WebCore::FrameQtClientDefault::didReceiveData):
338         (WebCore::FrameQtClientDefault::receivedAllData):
339         * platform/qt/ImageQt.cpp:
340         * platform/qt/MimeTypeRegistryQt.cpp: Added.
341         (WebCore::getMIMETypeForUTI):
342         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
343         * platform/qt/PageQt.cpp:
344         * platform/qt/PlatformKeyboardEventQt.cpp:
345         (WebCore::keyIdentifierForQtKeyCode):
346         * platform/qt/ScreenQt.cpp:
347         * platform/qt/TemporaryLinkStubs.cpp:
348         (WebCore::TextField::TextField):
349         (WebCore::screenDepth):
350         (WebCore::screenDepthPerComponent):
351         (WebCore::screenIsMonochrome):
352         (WebCore::screenRect):
353         (WebCore::screenAvailableRect):
354
355 2006-11-10  Brady Eidson <beidson@apple.com>
356
357         Reviewed by Mitz
358
359         http://bugs.webkit.org/show_bug.cgi?id=11554
360         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
361         in case the icon load fails after some data has been received. 
362
363         * loader/icon/IconLoader.cpp:
364         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
365         on error.  Also, as a loader re-factoring sanity check, added an assertion
366         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
367         is already committed to the DB.  Skip doing that step twice.
368
369 2006-11-09  Oliver Hunt  <oliver@apple.com>
370
371         Reviewed by Brady.
372
373         Pulled MIME type handling out of WebFrameBridge and added
374         a general C++ class to store/query MIME info
375         Added an Obj-C bridge to provide WebKit with access to the
376         MimeTypeRegistry for non-Obj-C++ classes.
377         
378         * WebCore.exp:
379         * WebCore.xcodeproj/project.pbxproj:
380         * bridge/mac/WebCoreFrameBridge.h:
381         * bridge/mac/WebCoreFrameBridge.mm:
382         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
383         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
384         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
385         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
386         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
387         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
388         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
389         * platform/Image.cpp:
390         (WebCore::Image::supportsType):
391         * platform/Image.h:
392         * platform/MimeTypeRegistry.cpp: Added.
393         (WebCore::initialiseSupportedImageMIMETypes):
394         (WebCore::initialiseSupportedNonImageMimeTypes):
395         (WebCore::initialiseMimeTypeRegistry):
396         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
397         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
398         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
399         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
400         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
401         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
402         * platform/MimeTypeRegistry.h: Added.
403         * platform/mac/ImageMac.mm:
404         * platform/mac/MimeTypeRegistryMac.mm: Added.
405         (WebCore::getMIMETypeForUTI):
406         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
407
408 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
409
410         Reviewed by Oliver.
411
412         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
413         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
414         for you and use vsnprintf.
415
416         * bindings/js/kjs_window.cpp:
417         (KJS::Window::isSafeScript):
418         * css/cssparser.cpp:
419         (WebCore::CSSParser::parseColorFromValue):
420         * dom/StyledElement.cpp:
421         (WebCore::StyledElement::addCSSColor):
422         * dom/XMLTokenizer.cpp:
423         (WebCore::XMLTokenizer::handleError):
424         * ksvg2/css/SVGCSSParser.cpp:
425         (WebCore::CSSParser::parseSVGPaint):
426         (WebCore::CSSParser::parseSVGColor):
427         * ksvg2/svg/SVGPathSegArc.h:
428         (WebCore::SVGPathSegArcAbs::toString):
429         (WebCore::SVGPathSegArcRel::toString):
430         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
431         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
432         (WebCore::SVGPathSegCurvetoCubicRel::toString):
433         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
434         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
435         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
436         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
437         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
438         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
439         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
440         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
441         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
442         * ksvg2/svg/SVGPathSegLineto.h:
443         (WebCore::SVGPathSegLinetoAbs::toString):
444         (WebCore::SVGPathSegLinetoRel::toString):
445         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
446         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
447         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
448         * ksvg2/svg/SVGPathSegLinetoVertical.h:
449         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
450         (WebCore::SVGPathSegLinetoVerticalRel::toString):
451         * ksvg2/svg/SVGPathSegMoveto.h:
452         (WebCore::SVGPathSegMovetoAbs::toString):
453         (WebCore::SVGPathSegMovetoRel::toString):
454         * ksvg2/svg/SVGPolyElement.cpp:
455         (WebCore::SVGPolyElement::notifyAttributeChange):
456         * ksvg2/svg/SVGUseElement.cpp:
457         (WebCore::SVGUseElement::closeRenderer):
458         * loader/icon/IconDatabase.cpp:
459         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
460         * loader/icon/SQLDatabase.cpp:
461         (WebCore::SQLDatabase::setSynchronous):
462         * platform/Color.cpp:
463         (WebCore::Color::name):
464         * platform/DeprecatedString.cpp:
465         (WebCore::DeprecatedString::setNum):
466         (WebCore::DeprecatedString::format):
467         * platform/DeprecatedString.h:
468         * platform/PlatformString.h:
469         * platform/String.cpp:
470         (WebCore::String::format):
471         (WebCore::String::number):
472         * platform/mac/KeyEventMac.mm:
473         (WebCore::keyIdentifierForKeyEvent):
474         * platform/win/KeyEventWin.cpp:
475         (WebCore::keyIdentifierForWindowsKeyCode):
476         * rendering/RenderListMarker.cpp:
477         (WebCore::RenderListMarker::calcMinMaxWidth):
478
479 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
480
481         Reviewed by Anders.
482
483         - fixed "Regression: Can't log into gmail.com"
484         - fixed "iBench doesn't report results - tests run but no number is recorded"
485         
486         * platform/network/cf/FormDataStreamCFNet.cpp:
487         (WebCore::setHTTPBody): Removed extra ! character.
488
489 2006-11-09  Beth Dakin  <bdakin@apple.com>
490
491         Reviewed by Hyatt.
492
493         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
494         WebCore::RenderBlock::skipWhitespace
495
496         Note that this will still crash on Debug builds because it will hit 
497         an assertion failure in editing. (One of the reasons there is no 
498         layout test along with this fix.) There is definitely some editing 
499         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
500         id=10144 for updates on the assertion failure bug.
501
502         * rendering/RootInlineBox.cpp:
503         (WebCore::RootInlineBox::childRemoved): It is possible for a 
504         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
505         of just clearing the lineBreakObj of the prevRootBox, cycle through 
506         all prevRootBoxs with the same lineBreakObj. 
507
508 2006-11-09  Adam Roben  <aroben@apple.com>
509
510         Reviewed by Geoff.
511
512         Fix the change in behavior I caused in r17680 with my build fix.
513
514         * rendering/RenderObject.cpp:
515         (WebCore::RenderObject::maxTopMargin):
516         (WebCore::RenderObject::maxBottomMargin):
517
518 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
519
520         Reviewed by Adam, Oliver.
521
522         Move more functions to Editor.
523
524         * bridge/EditorClient.h:
525         * bridge/mac/FrameMac.h:
526         * bridge/mac/FrameMac.mm:
527         * bridge/mac/WebCoreFrameBridge.h:
528         * editing/EditCommand.cpp:
529         (WebCore::EditCommand::apply):
530         (WebCore::EditCommand::unapply):
531         (WebCore::EditCommand::reapply):
532         * editing/Editor.cpp:
533         (WebCore::Editor::respondToChangedContents):
534         (WebCore::dispatchEditableContentChangedEvents):
535         (WebCore::Editor::appliedEditing):
536         (WebCore::Editor::unappliedEditing):
537         (WebCore::Editor::reappliedEditing):
538         * editing/Editor.h:
539         * editing/TypingCommand.cpp:
540         (WebCore::TypingCommand::typingAddedToOpenCommand):
541         * page/Frame.cpp:
542         * page/Frame.h:
543
544 2006-11-09  Darin Adler  <darin@apple.com>
545
546         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
547
548 2006-11-09  Alice Liu  <alice.liu@apple.com>
549
550         Reviewed by Beth Dakin.
551
552         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
553         All existing layout tests pass
554
555         * html/HTMLTableElement.cpp:
556         (WebCore::HTMLTableElement::deleteRow):
557         check lastSection before deleting row
558
559 2006-11-09  Darin Adler  <darin@apple.com>
560
561         - improved version of last night's build fix (should not do using namespace in a header)
562
563         * rendering/RenderObject.h:
564         * rendering/RenderObject.cpp:
565         (WebCore::RenderObject::maxTopMargin):
566         (WebCore::RenderObject::maxBottomMargin):
567
568 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
569
570         Reviewed by Geoff.
571         
572         - added ResourceError class and didFailWithError client method
573
574         * WebCore.xcodeproj/project.pbxproj:
575         * loader/icon/IconLoader.cpp:
576         (WebCore::IconLoader::didFailWithError):
577         (WebCore::IconLoader::didFinishLoading):
578         * loader/icon/IconLoader.h:
579         * loader/loader.cpp:
580         (WebCore::Loader::receivedAllData):
581         (WebCore::Loader::didFailWithError):
582         * loader/loader.h:
583         * loader/mac/SubresourceLoaderMac.mm:
584         (WebCore::SubresourceLoader::didFail):
585         (WebCore::SubresourceLoader::didCancel):
586         * platform/cf/RetainPtr.h:
587         (WebCore::):
588         (WebCore::adoptCFReference):
589         (WebCore::RetainPtr::RetainPtr):
590         (WebCore::::adopt):
591         * platform/network/ResourceError.cpp: Added.
592         * platform/network/ResourceError.h: Added.
593         (WebCore::ResourceError::ResourceError):
594         (WebCore::ResourceError::domain):
595         (WebCore::ResourceError::errorCode):
596         (WebCore::ResourceError::failingURL):
597         (WebCore::ResourceError::localizedDescription):
598         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
599         * platform/network/ResourceHandle.cpp:
600         * platform/network/ResourceHandle.h:
601         * platform/network/ResourceHandleClient.h:
602         (WebCore::ResourceHandleClient::didFailWithError):
603         * platform/network/cf/ResourceHandleCFNet.cpp:
604         (WebCore::didFail):
605         (WebCore::ResourceHandle::cancel):
606         * platform/network/mac/ResourceErrorMac.mm: Added.
607         (-[NSError WebCore]):
608         * platform/network/mac/ResourceHandleMac.mm:
609         (WebCore::ResourceHandle::reportError):
610         * xml/xmlhttprequest.cpp:
611         (WebCore::XMLHttpRequest::didFailWithError):
612         (WebCore::XMLHttpRequest::didFinishLoading):
613         * xml/xmlhttprequest.h:
614
615 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
616
617         Reviewed by Maciej.
618
619         Linux\Gdk fixes.
620
621         * platform/gdk/ChromeClientGdk.h:
622         (WebCore::ChromeClientGdk::~ChromeClientGdk):
623         * platform/gdk/CursorGdk.cpp:
624         (WebCore::Cursor::Cursor):
625         (WebCore::moveCursor):
626         * platform/gdk/FrameGdk.cpp:
627         (WebCore::FrameGdk::FrameGdk):
628         (WebCore::FrameGdk::submitForm):
629         (WebCore::FrameGdk::urlSelected):
630         * platform/gdk/PageGdk.cpp:
631         * platform/gdk/ScreenClientGdk.h: Added.
632         (WebCore::ScreenClientGdk::~ScreenClientGdk):
633         * platform/gdk/ScreenGdk.cpp:
634         (WebCore::ScreenClientGdk::depth):
635         (WebCore::ScreenClientGdk::depthPerComponent):
636         (WebCore::ScreenClientGdk::isMonochrome):
637         (WebCore::ScreenClientGdk::rect):
638         (WebCore::ScreenClientGdk::usableRect):
639         * platform/gdk/TemporaryLinkStubs.cpp:
640         (FrameGdk::historyURL):
641         (ChromeClientGdk::windowRect):
642         (ChromeClientGdk::setWindowRect):
643         (ChromeClientGdk::pageRect):
644         (ChromeClientGdk::scaleFactor):
645         (ChromeClientGdk::focus):
646         (ChromeClientGdk::unfocus):
647         (ChromeClientGdk::createWindow):
648         (ChromeClientGdk::createModalDialog):
649         (ChromeClientGdk::show):
650         (ChromeClientGdk::canRunModal):
651         (ChromeClientGdk::runModal):
652         (ChromeClientGdk::setToolbarsVisible):
653         (ChromeClientGdk::toolbarsVisible):
654         (ChromeClientGdk::setStatusbarVisible):
655         (ChromeClientGdk::statusbarVisible):
656         (ChromeClientGdk::setScrollbarsVisible):
657         (ChromeClientGdk::scrollbarsVisible):
658         (ChromeClientGdk::setMenubarVisible):
659         (ChromeClientGdk::menubarVisible):
660         (ChromeClientGdk::setResizable):
661         * platform/network/ResourceHandleInternal.h:
662         (WebCore::ResourceHandleInternal::client):
663         * platform/network/gdk/ResourceHandleManager.cpp:
664         (WebCore::writeCallback):
665         (WebCore::ResourceHandleManager::downloadTimerCallback):
666         (WebCore::ResourceHandleManager::remove):
667
668 2006-11-08  Adam Roben  <aroben@apple.com>
669
670         Build fix.
671
672         * rendering/RenderObject.h:
673         (WebCore::RenderObject::maxTopMargin):
674         (WebCore::RenderObject::maxBottomMargin):
675
676 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
677
678         Reviewed by Anders Carlsson.
679
680         Made Screen a good platform citizen by removing its reference to Page. This
681         made a class unnecessary, so all screen fuctions are stand-alone now.
682
683         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
684         when computing the screen's available dimensions.
685
686 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
687
688         Reviewed by Mitz.
689
690         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
691         Cleanup RenderObject
692
693         * rendering/RenderObject.cpp:
694         (WebCore::RenderObject::operator delete):
695         (WebCore::RenderObject::createObject):
696         (WebCore::RenderObjectCounter::~RenderObjectCounter):
697         (WebCore::RenderObject::RenderObject):
698         (WebCore::RenderObject::isDescendantOf):
699         (WebCore::RenderObject::isRoot):
700         (WebCore::RenderObject::addChild):
701         (WebCore::RenderObject::removeChildNode):
702         (WebCore::RenderObject::removeChild):
703         (WebCore::RenderObject::appendChildNode):
704         (WebCore::RenderObject::insertChildNode):
705         (WebCore::RenderObject::nextInPreOrder):
706         (WebCore::RenderObject::nextInPreOrderAfterChildren):
707         (WebCore::RenderObject::previousInPreOrder):
708         (WebCore::RenderObject::isEditable):
709         (WebCore::RenderObject::nextEditable):
710         (WebCore::RenderObject::previousEditable):
711         (WebCore::RenderObject::firstLeafChild):
712         (WebCore::RenderObject::lastLeafChild):
713         (WebCore::RenderObject::addLayers):
714         (WebCore::RenderObject::removeLayers):
715         (WebCore::RenderObject::moveLayers):
716         (WebCore::RenderObject::findNextLayer):
717         (WebCore::RenderObject::enclosingLayer):
718         (WebCore::RenderObject::updateFirstLetter):
719         (WebCore::RenderObject::offsetParent):
720         (WebCore::RenderObject::scroll):
721         (WebCore::RenderObject::hasStaticX):
722         (WebCore::RenderObject::setNeedsLayout):
723         (WebCore::RenderObject::setChildNeedsLayout):
724         (WebCore::RenderObject::markContainingBlocksForLayout):
725         (WebCore::RenderObject::containingBlock):
726         (WebCore::RenderObject::containingBlockWidth):
727         (WebCore::RenderObject::containingBlockHeight):
728         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
729         (WebCore::RenderObject::drawBorderArc):
730         (WebCore::RenderObject::drawBorder):
731         (WebCore::RenderObject::paintBorderImage):
732         (WebCore::RenderObject::paintBorder):
733         (WebCore::RenderObject::absoluteRects):
734         (WebCore::RenderObject::addPDFURLRect):
735         (WebCore::RenderObject::addFocusRingRects):
736         (WebCore::RenderObject::paintOutline):
737         (WebCore::RenderObject::repaint):
738         (WebCore::RenderObject::repaintRectangle):
739         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
740         (WebCore::RenderObject::repaintObjectsBeforeLayout):
741         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
742         (WebCore::RenderObject::information):
743         (WebCore::RenderObject::dump):
744         (WebCore::selectStartNode):
745         (WebCore::RenderObject::shouldSelect):
746         (WebCore::RenderObject::draggableNode):
747         (WebCore::RenderObject::createAnonymousBlock):
748         (WebCore::RenderObject::handleDynamicFloatPositionChange):
749         (WebCore::RenderObject::setStyle):
750         (WebCore::RenderObject::setStyleInternal):
751         (WebCore::RenderObject::updateBackgroundImages):
752         (WebCore::RenderObject::absolutePosition):
753         (WebCore::RenderObject::caretRect):
754         (WebCore::RenderObject::paddingTop):
755         (WebCore::RenderObject::paddingBottom):
756         (WebCore::RenderObject::paddingLeft):
757         (WebCore::RenderObject::paddingRight):
758         (WebCore::RenderObject::tabWidth):
759         (WebCore::RenderObject::container):
760         (WebCore::RenderObject::removeFromObjectLists):
761         (WebCore::RenderObject::destroy):
762         (WebCore::RenderObject::arenaDelete):
763         (WebCore::RenderObject::hitTest):
764         (WebCore::RenderObject::setInnerNode):
765         (WebCore::RenderObject::nodeAtPoint):
766         (WebCore::RenderObject::verticalPositionHint):
767         (WebCore::RenderObject::getVerticalPosition):
768         (WebCore::RenderObject::lineHeight):
769         (WebCore::RenderObject::invalidateVerticalPositions):
770         (WebCore::RenderObject::recalcMinMaxWidths):
771         (WebCore::RenderObject::scheduleRelayout):
772         (WebCore::RenderObject::setInlineBoxWrapper):
773         (WebCore::RenderObject::firstLineStyle):
774         (WebCore::RenderObject::getPseudoStyle):
775         (WebCore::RenderObject::getTextDecorationColors):
776         (WebCore::RenderObject::addDashboardRegions):
777         (WebCore::RenderObject::collectDashboardRegions):
778         (WebCore::RenderObject::avoidsFloats):
779         (WebCore::RenderObject::findCounter):
780         (WebCore::RenderObject::backslashAsCurrencySymbol):
781         (WebCore::RenderObject::imageChanged):
782         (WebCore::RenderObject::previousOffset):
783         (WebCore::RenderObject::nextOffset):
784         (WebCore::RenderObject::inlineBox):
785         * rendering/RenderObject.h:
786         (WebCore::):
787         (WebCore::RenderObject::renderName):
788         (WebCore::RenderObject::parent):
789         (WebCore::RenderObject::previousSibling):
790         (WebCore::RenderObject::nextSibling):
791         (WebCore::RenderObject::firstChild):
792         (WebCore::RenderObject::lastChild):
793         (WebCore::RenderObject::getOverflowClipRect):
794         (WebCore::RenderObject::getClipRect):
795         (WebCore::RenderObject::getBaselineOfFirstLineBox):
796         (WebCore::RenderObject::setEdited):
797         (WebCore::RenderObject::setStaticX):
798         (WebCore::RenderObject::setStaticY):
799         (WebCore::RenderObject::setPreviousSibling):
800         (WebCore::RenderObject::setNextSibling):
801         (WebCore::RenderObject::setParent):
802         (WebCore::RenderObject::isInlineBlockOrInlineTable):
803         (WebCore::RenderObject::isRenderView):
804         (WebCore::RenderObject::childrenInline):
805         (WebCore::RenderObject::setChildrenInline):
806         (WebCore::RenderObject::isAnonymousBlock):
807         (WebCore::RenderObject::isDragging):
808         (WebCore::RenderObject::needsLayout):
809         (WebCore::RenderObject::setMinMaxKnown):
810         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
811         (WebCore::RenderObject::setPositioned):
812         (WebCore::RenderObject::setRelPositioned):
813         (WebCore::RenderObject::setFloating):
814         (WebCore::RenderObject::setInline):
815         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
816         (WebCore::RenderObject::setReplaced):
817         (WebCore::RenderObject::PaintInfo::PaintInfo):
818         (WebCore::RenderObject::paintBackgroundExtended):
819         (WebCore::RenderObject::calcWidth):
820         (WebCore::RenderObject::updateFromElement):
821         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
822         (WebCore::RenderObject::setOverrideSize):
823         (WebCore::RenderObject::setPos):
824         (WebCore::RenderObject::setWidth):
825         (WebCore::RenderObject::setHeight):
826         (WebCore::RenderObject::absolutePositionForContent):
827         (WebCore::RenderObject::overflowHeight):
828         (WebCore::RenderObject::overflowWidth):
829         (WebCore::RenderObject::setOverflowHeight):
830         (WebCore::RenderObject::setOverflowWidth):
831         (WebCore::RenderObject::overflowLeft):
832         (WebCore::RenderObject::overflowTop):
833         (WebCore::RenderObject::overflowRect):
834         (WebCore::RenderObject::stopAutoscroll):
835         (WebCore::RenderObject::collapsedMarginTop):
836         (WebCore::RenderObject::collapsedMarginBottom):
837         (WebCore::RenderObject::maxTopMargin):
838         (WebCore::RenderObject::maxBottomMargin):
839         (WebCore::RenderObject::):
840         (WebCore::RenderObject::setTable):
841         (WebCore::RenderObject::isFloatingOrPositioned):
842         (WebCore::RenderObject::containsFloat):
843         (WebCore::RenderObject::setSelectionState):
844         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
845         (WebCore::RenderObject::lowestPosition):
846         (WebCore::RenderObject::rightmostPosition):
847         (WebCore::RenderObject::leftmostPosition):
848         (WebCore::RenderObject::calcVerticalMargins):
849         (WebCore::RenderObject::font):
850
851 2006-11-08  Darin Adler  <darin@apple.com>
852
853         Reviewed by Anders.
854
855         - added event parameters to focus-related functions so we can
856           implement the "option-tab to all links" behavior without relying
857           on a global "current event" -- also makes it work with DOM events
858
859         * page/Frame.h: Removed unneeded includes. Moved some functions
860         that were misplaced into the appropriate sections.
861         * page/Frame.cpp:
862         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
863         PlatformKeyboardEvent to the DOM keyboard event class.
864         (WebCore::Frame::tabsToLinks): Added event parameter.
865         (WebCore::Frame::tabsToAllControls): Ditto.
866         (WebCore::scanForForm): Fixed code that incorrectly assumes
867         that an iframe is an HTMLFrameElement (no longer true since Geoff
868         changed the class hierarchy a bit).
869         (WebCore::Frame::hitTestResultAtPoint): Ditto.
870
871         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
872         that were misplaced into the appropriate sections.
873         * bridge/mac/FrameMac.mm:
874         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
875         a PlatformKeyboardEvent.
876         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
877         and pass event into next/previousFocusNode.
878         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
879         the AppKit current event, if it's a keyboard event. Really just a hack that's
880         needed to preserve some code we can remove once we deal with the last NSView-
881         based form control.
882         (WebCore::isKeyboardOptionTab): Added.
883         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
884         option (alt) key is down.
885         (WebCore::FrameMac::tabsToAllControls): Ditto.
886         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
887         call resetMultipleFormSubmissionProtection() explicitly instead.
888         (WebCore::FrameMac::mouseDown): Ditto.
889
890         * bridge/mac/WebCoreAXObject.mm:
891         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
892         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
893         changed the class hierarchy a bit).
894         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
895         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
896         explicitly instead.
897
898         * page/FrameView.h:
899         * page/FrameView.cpp:
900         (WebCore::FrameView::advanceFocus): Changed function to take an
901         event parameter, and decide the direction based on the shift key
902         modifier instead of a passed-in boolean.
903
904         * dom/Document.h:
905         * dom/Document.cpp:
906         (WebCore::Document::nextFocusNode): Added event parameter.
907         (WebCore::Document::previousFocusNode): Ditto.
908         * dom/Node.h:
909         * dom/Node.cpp:
910         (WebCore::Node::isKeyboardFocusable): Ditto.
911         * html/HTMLAnchorElement.h:
912         * html/HTMLAnchorElement.cpp:
913         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
914         * html/HTMLGenericFormElement.h:
915         * html/HTMLGenericFormElement.cpp:
916         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
917         * html/HTMLInputElement.h:
918         * html/HTMLInputElement.cpp:
919         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
920         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
921         * html/HTMLSelectElement.h:
922         * html/HTMLSelectElement.cpp:
923         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
924         * html/HTMLTextAreaElement.h:
925         * html/HTMLTextAreaElement.cpp:
926         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
927
928         * dom/EventTargetNode.cpp:
929         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
930         advanceFocus function.
931
932         * platform/TextField.h:
933         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
934
935         * platform/mac/WebCoreTextField.h:
936         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
937         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
938         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
939         needed since the default handler in HTMLInputElement takes care of
940         option-tab.
941
942         * platform/mac/SliderMac.mm:
943         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
944         and pass event into tabsToAllControls.
945         (Slider::focusPolicy): Ditto.
946
947         * rendering/RenderLineEdit.cpp:
948         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
949         (WebCore::RenderLineEdit::updateFromElement): Ditto.
950
951 2006-11-08  Brady Eidson  <beidson@apple.com>
952
953         Reviewed by Dave Harrison, Oliver, and Darin 
954         (oh my!  where was superkevin on this one?)
955
956         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
957
958         More "free nil checking" we lost in the transition from ObjC to C++
959
960         * loader/mac/FrameLoaderMac.mm:
961         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
962         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
963
964 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
965
966         Reviewed by Adam.
967
968         Move more code into editor.
969         
970         * WebCore.exp:
971         * bridge/EditorClient.h:
972         * bridge/mac/FrameMac.h:
973         * bridge/mac/FrameMac.mm:
974         * bridge/mac/WebCoreFrameBridge.h:
975         * dom/Document.cpp:
976         (WebCore::Document::relinquishesEditingFocus):
977         (WebCore::Document::acceptsEditingFocus):
978         (WebCore::Document::didBeginEditing):
979         (WebCore::Document::didEndEditing):
980         * editing/Editor.cpp:
981         (WebCore::Editor::indent):
982         (WebCore::Editor::outdent):
983         * editing/Editor.h:
984         * page/Frame.cpp:
985         * page/Frame.h:
986
987 2006-11-08  Beth Dakin  <bdakin@apple.com>
988
989         Reviewed by Adam.
990
991         Add ability to HitTestResult to ask if the inner non-shared node is 
992         content editable.
993
994         * WebCore.exp: Export HitTestResult::isContentEditable()
995         * rendering/HitTestResult.cpp:
996         (WebCore::HitTestResult::isContentEditable):
997         * rendering/HitTestResult.h:
998
999 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1000
1001         Build fix.
1002         
1003         * WebCore.xcodeproj/project.pbxproj:
1004         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
1005
1006 2006-11-08  Timothy Hatcher  <timothy@apple.com>
1007
1008         Reviewed by Darin.
1009
1010         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
1011         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
1012
1013         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
1014
1015         * bindings/objc/DOM.mm:
1016         (WebCore::kit):
1017         (-[DOMNode lineBoxRects]):
1018         (-[DOMRange boundingBox]):
1019         (-[DOMRange lineBoxRects]):
1020         * bindings/objc/DOMPrivate.h:
1021         * dom/Range.cpp:
1022         (WebCore::Range::boundingBox):
1023         (WebCore::Range::addLineBoxRects):
1024         * dom/Range.h:
1025         * rendering/RenderContainer.cpp:
1026         (WebCore::RenderContainer::addLineBoxRects):
1027         * rendering/RenderContainer.h:
1028         * rendering/RenderObject.cpp:
1029         (WebCore::RenderObject::addLineBoxRects):
1030         * rendering/RenderObject.h:
1031         * rendering/RenderText.cpp:
1032         (WebCore::RenderText::addLineBoxRects):
1033         * rendering/RenderText.h:
1034
1035 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
1036
1037         Reviewed by Oliver.
1038         
1039         Move methods from the bridge and frame into editor.
1040         
1041         * WebCore.exp:
1042         * bridge/EditorClient.h:
1043         * bridge/mac/WebCoreFrameBridge.h:
1044         * bridge/mac/WebCoreFrameBridge.mm:
1045         * editing/Editor.cpp:
1046         (WebCore::Editor::removeFormattingAndStyle):
1047         (WebCore::Editor::applyStyle):
1048         (WebCore::Editor::applyParagraphStyle):
1049         (WebCore::Editor::applyStyleToSelection):
1050         (WebCore::Editor::applyParagraphStyleToSelection):
1051         (WebCore::Editor::toggleBold):
1052         (WebCore::Editor::toggleItalic):
1053         (WebCore::Editor::selectionStartHasStyle):
1054         * editing/Editor.h:
1055         * editing/JSEditor.cpp:
1056         * page/Frame.cpp:
1057         * page/Frame.h:
1058
1059 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1060
1061         Reviewed by Beth.
1062         
1063         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
1064         be able to dispatch user events even when off-screen, so we have to support
1065         off-screen windows when handling mouse events.
1066
1067         * platform/Screen.h:
1068         * platform/mac/PlatformMouseEventMac.mm:
1069         (WebCore::globalPoint): Grab the best screen instead of the screen you're
1070         on, since you might be off-screen.
1071         * platform/mac/ScreenMac.mm:
1072         (WebCore::screenForWindow):
1073
1074 2006-11-08  Darin Adler  <darin@apple.com>
1075
1076         - fix bug caused by last-minute change to my check-in last night
1077           that is causing layout tests to hang
1078
1079         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
1080         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
1081         a null string into an empty string before calling completeURL.
1082
1083 2006-11-08  Brady Eidson <beidson@apple.com>
1084
1085         Reviewed by Maciej
1086
1087         If the request has already been aborted, bail out of didFinishLoading()
1088         immediately.  This prevents state change notifications that aren't
1089         needed.
1090
1091         * xml/xmlhttprequest.cpp:
1092         (WebCore::XMLHttpRequest::didFinishLoading):
1093
1094 2006-11-08  Darin Adler  <darin@apple.com>
1095
1096         - another attempt to fix Qt build
1097
1098         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
1099
1100 2006-11-08  Darin Adler  <darin@apple.com>
1101
1102         Reviewed by Geoff.
1103
1104         - stray bits of my FrameLoader patch that I left out by accident
1105
1106         * loader/FrameLoader.cpp:
1107         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
1108         inside the FrameLoader class.
1109         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
1110         (WebCore::FrameLoader::clear): Stop the redirection timer.
1111         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
1112         entire function in an if statement. Use less DeprecatedString.
1113         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
1114         (WebCore::FrameLoader::scheduleRefresh): Ditto.
1115         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
1116         inside the FrameLoader class.
1117         * loader/mac/FrameLoaderMac.mm:
1118         (WebCore::FrameLoader::load): Ditto.
1119         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
1120
1121 2006-11-07  Beth Dakin  <bdakin@apple.com>
1122
1123         Reviewed by Hyatt.
1124
1125         Another go at fix for <rdar://problem/4820814> A crash occurs at 
1126         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1127         iframe at www.macsurfer.com
1128
1129         The fix from yesterday caused a layout test regression which 
1130         exposed an existing bug. The existing bug was that we allowed text 
1131         nodes to stay in the head tag, but other browsers move them to the 
1132         body. The previous fix also caused a performance regression, which 
1133         was seemingly easy to fix by moving the new clause in 
1134         HTMLParser::handleError() to be below the HTMLElement case.
1135
1136         * html/HTMLDocument.cpp:
1137         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
1138         be the child of the document.
1139         * html/HTMLHeadElement.cpp:
1140         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
1141         whitespace text nodes to be children of the head.
1142         * html/HTMLHeadElement.h:
1143         * html/HTMLParser.cpp:
1144         (WebCore::HTMLParser::handleError): Error case for comment nodes.
1145         * page/FrameView.cpp:
1146         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
1147         for the original crash. 
1148
1149 2006-11-07  Darin Adler  <darin@apple.com>
1150
1151         - another attempt to fix Qt build
1152
1153         * loader/icon/IconLoader.h: Added missing include.
1154
1155 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1156
1157         Reviewed by Tim Hatcher.
1158         
1159         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1160         
1161         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1162         so WebCore can handle it all.
1163         
1164         Moved Screen back from page/ to platform/ because it's a platform
1165         abstraction again.
1166
1167         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
1168         since the two were always used together.
1169         
1170         Changed pixel depth queries to query the deepest screen. Darin mentioned
1171         that it might have been a feature, not a bug, to use the main/menubar screen
1172         regardless of the screen you were on. For scaling and flipping that's not
1173         the case, but for querying pixel depth I think it is. You want to know
1174         about the highest pixel depth your content may display on.
1175         
1176         Tests still pass.
1177
1178         * WebCore.exp:
1179         * WebCore.xcodeproj/project.pbxproj:
1180         * page/Page.cpp:
1181         (WebCore::Page::Page):
1182         * page/Page.h:
1183         * page/Screen.cpp: Removed.
1184         * page/Screen.h: Removed.
1185         * page/ScreenClient.h: Removed.
1186         * platform/mac/PlatformMouseEventMac.mm:
1187         (WebCore::globalPoint):
1188         * platform/mac/ScreenMac.mm:
1189         (WebCore::window):
1190         (WebCore::bestScreen):
1191         (WebCore::Screen::depth):
1192         (WebCore::Screen::depthPerComponent):
1193         (WebCore::Screen::isMonochrome):
1194         (WebCore::Screen::rect):
1195         (WebCore::Screen::usableRect):
1196         (WebCore::toUserSpace):
1197         (WebCore::toDeviceSpace):
1198
1199 2006-11-07  Darin Adler  <darin@apple.com>
1200
1201         - try to fix Qt build
1202
1203         * CMakeLists.txt: Updated for some file changes.
1204         * WebCoreSources.bkl: Ditto.
1205
1206 2006-11-07  Darin Adler  <darin@apple.com>
1207
1208         Reviewed by Geoff.
1209
1210         - moved loader code from Frame/FrameMac to FrameLoader
1211
1212         * WebCore.exp:
1213         * WebCore.xcodeproj/project.pbxproj:
1214         * bindings/js/JSXSLTProcessor.h:
1215         * bindings/js/kjs_events.cpp:
1216         (KJS::JSLazyEventListener::parseCode):
1217         * bindings/js/kjs_html.cpp:
1218         (KJS::JSHTMLDocument::putValueProperty):
1219         * bindings/js/kjs_navigator.cpp:
1220         (KJS::Navigator::getValueProperty):
1221         * bindings/js/kjs_proxy.cpp:
1222         (WebCore::KJSProxy::initScriptIfNeeded):
1223         * bindings/js/kjs_window.cpp:
1224         (KJS::Screen::Screen):
1225         (KJS::createNewWindow):
1226         (KJS::Window::getValueProperty):
1227         (KJS::Window::put):
1228         (KJS::Window::isSafeScript):
1229         (KJS::WindowFunc::callAsFunction):
1230         (KJS::ScheduledAction::execute):
1231         (KJS::Location::getValueProperty):
1232         (KJS::Location::put):
1233         (KJS::Location::toString):
1234         (KJS::LocationFunc::callAsFunction):
1235         (KJS::History::getValueProperty):
1236         (KJS::HistoryFunc::callAsFunction):
1237         * bindings/objc/DOM.mm:
1238         (+[DOMNode _nodeWith:WebCore::]):
1239         * bridge/mac/FrameMac.h:
1240         * bridge/mac/FrameMac.mm:
1241         (WebCore::FrameMac::~FrameMac):
1242         (WebCore::FrameMac::setView):
1243         (WebCore::FrameMac::setStatusBarText):
1244         * bridge/mac/WebCoreFrameBridge.h:
1245         * bridge/mac/WebCoreFrameBridge.mm:
1246         (-[WebCoreFrameBridge close]):
1247         (-[WebCoreFrameBridge addData:]):
1248         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
1249         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
1250         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1251         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1252         (-[WebCoreFrameBridge baseURL]):
1253         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
1254         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
1255         (-[WebCoreFrameBridge canProvideDocumentSource]):
1256         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1257         * css/cssparser.cpp:
1258         (WebCore::CSSParser::parseContent):
1259         * dom/DOMImplementation.cpp:
1260         (WebCore::DOMImplementation::createDocument):
1261         (WebCore::DOMImplementation::createHTMLDocument):
1262         * dom/DOMImplementation.h:
1263         * dom/Document.cpp:
1264         (WebCore::Document::readyState):
1265         (WebCore::Document::updateTitle):
1266         (WebCore::Document::open):
1267         (WebCore::Document::close):
1268         (WebCore::Document::implicitClose):
1269         (WebCore::Document::processHttpEquiv):
1270         (WebCore::Document::referrer):
1271         (WebCore::Document::finishedParsing):
1272         * dom/ProcessingInstruction.cpp:
1273         (WebCore::ProcessingInstruction::checkStyleSheet):
1274         * dom/XMLTokenizer.cpp:
1275         (WebCore::XMLTokenizer::endElementNs):
1276         (WebCore::ignorableWhitespaceHandler):
1277         (WebCore::XMLTokenizer::notifyFinished):
1278         * editing/TextIterator.cpp:
1279         (WebCore::TextIterator::rangeFromLocationAndLength):
1280         * html/HTMLAnchorElement.cpp:
1281         (WebCore::HTMLAnchorElement::defaultEventHandler):
1282         * html/HTMLBaseElement.cpp:
1283         (WebCore::HTMLBaseElement::process):
1284         * html/HTMLDocument.cpp:
1285         (WebCore::HTMLDocument::lastModified):
1286         * html/HTMLFormElement.cpp:
1287         (WebCore::HTMLFormElement::formData):
1288         (WebCore::HTMLFormElement::submit):
1289         * html/HTMLFrameElementBase.cpp:
1290         (WebCore::HTMLFrameElementBase::isURLAllowed):
1291         (WebCore::HTMLFrameElementBase::openURL):
1292         (WebCore::HTMLFrameElementBase::willRemove):
1293         * html/HTMLInputElement.cpp:
1294         (WebCore::HTMLInputElement::setValueFromRenderer):
1295         * html/HTMLLinkElement.cpp:
1296         (WebCore::HTMLLinkElement::process):
1297         * html/HTMLParser.cpp:
1298         (WebCore::HTMLParser::handleError):
1299         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
1300         * html/HTMLPreElement.idl:
1301         * html/HTMLScriptElement.cpp:
1302         (WebCore::HTMLScriptElement::parseMappedAttribute):
1303         (WebCore::HTMLScriptElement::insertedIntoDocument):
1304         * html/HTMLTokenizer.cpp:
1305         (WebCore::HTMLTokenizer::scriptExecution):
1306         (WebCore::HTMLTokenizer::parseTag):
1307         (WebCore::HTMLTokenizer::write):
1308         (WebCore::HTMLTokenizer::stopParsing):
1309         (WebCore::HTMLTokenizer::timerFired):
1310         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1311         (WebCore::KCanvasFilterQuartz::prepareFilter):
1312         * ksvg2/svg/SVGAElement.cpp:
1313         (WebCore::SVGAElement::defaultEventHandler):
1314         * ksvg2/svg/SVGElement.cpp:
1315         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
1316         * loader/DocLoader.cpp:
1317         (WebCore::DocLoader::setLoadInProgress):
1318         * loader/FrameLoader.cpp:
1319         (WebCore::FormSubmission::FormSubmission):
1320         (WebCore::ScheduledRedirection::):
1321         (WebCore::ScheduledRedirection::ScheduledRedirection):
1322         (WebCore::cancelAll):
1323         (WebCore::getString):
1324         (WebCore::isBackForwardLoadType):
1325         (WebCore::numRequests):
1326         (WebCore::FrameLoader::FrameLoader):
1327         (WebCore::FrameLoader::~FrameLoader):
1328         (WebCore::FrameLoader::createWindow):
1329         (WebCore::FrameLoader::changeLocation):
1330         (WebCore::FrameLoader::urlSelected):
1331         (WebCore::FrameLoader::requestFrame):
1332         (WebCore::FrameLoader::loadSubframe):
1333         (WebCore::FrameLoader::submitFormAgain):
1334         (WebCore::FrameLoader::submitForm):
1335         (WebCore::FrameLoader::stopLoading):
1336         (WebCore::FrameLoader::stop):
1337         (WebCore::FrameLoader::closeURL):
1338         (WebCore::FrameLoader::cancelRedirection):
1339         (WebCore::FrameLoader::iconURL):
1340         (WebCore::FrameLoader::didOpenURL):
1341         (WebCore::FrameLoader::didExplicitOpen):
1342         (WebCore::FrameLoader::replaceContentsWithScriptResult):
1343         (WebCore::FrameLoader::executeScript):
1344         (WebCore::FrameLoader::cancelAndClear):
1345         (WebCore::FrameLoader::clear):
1346         (WebCore::FrameLoader::receivedFirstData):
1347         (WebCore::FrameLoader::responseMIMEType):
1348         (WebCore::FrameLoader::setResponseMIMEType):
1349         (WebCore::FrameLoader::begin):
1350         (WebCore::FrameLoader::write):
1351         (WebCore::FrameLoader::end):
1352         (WebCore::FrameLoader::endIfNotLoading):
1353         (WebCore::FrameLoader::startIconLoader):
1354         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1355         (WebCore::FrameLoader::gotoAnchor):
1356         (WebCore::FrameLoader::finishedParsing):
1357         (WebCore::FrameLoader::loadDone):
1358         (WebCore::FrameLoader::checkCompleted):
1359         (WebCore::FrameLoader::checkEmitLoadEvent):
1360         (WebCore::FrameLoader::baseURL):
1361         (WebCore::FrameLoader::baseTarget):
1362         (WebCore::FrameLoader::completeURL):
1363         (WebCore::FrameLoader::scheduleRedirection):
1364         (WebCore::FrameLoader::scheduleLocationChange):
1365         (WebCore::FrameLoader::scheduleRefresh):
1366         (WebCore::FrameLoader::isScheduledLocationChangePending):
1367         (WebCore::FrameLoader::scheduleHistoryNavigation):
1368         (WebCore::FrameLoader::redirectionTimerFired):
1369         (WebCore::FrameLoader::encoding):
1370         (WebCore::FrameLoader::requestObject):
1371         (WebCore::FrameLoader::shouldUsePlugin):
1372         (WebCore::FrameLoader::loadPlugin):
1373         (WebCore::FrameLoader::clearRecordedFormValues):
1374         (WebCore::FrameLoader::recordFormValue):
1375         (WebCore::FrameLoader::parentCompleted):
1376         (WebCore::FrameLoader::outgoingReferrer):
1377         (WebCore::FrameLoader::lastModified):
1378         (WebCore::FrameLoader::opener):
1379         (WebCore::FrameLoader::setOpener):
1380         (WebCore::FrameLoader::openedByJavaScript):
1381         (WebCore::FrameLoader::setOpenedByJavaScript):
1382         (WebCore::FrameLoader::handleFallbackContent):
1383         (WebCore::FrameLoader::provisionalLoadStarted):
1384         (WebCore::FrameLoader::userGestureHint):
1385         (WebCore::FrameLoader::didNotOpenURL):
1386         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
1387         (WebCore::FrameLoader::setEncoding):
1388         (WebCore::FrameLoader::addData):
1389         (WebCore::FrameLoader::canCachePage):
1390         (WebCore::FrameLoader::updatePolicyBaseURL):
1391         (WebCore::FrameLoader::setPolicyBaseURL):
1392         (WebCore::FrameLoader::scrollToAnchor):
1393         (WebCore::FrameLoader::isComplete):
1394         (WebCore::FrameLoader::isLoadingMainResource):
1395         (WebCore::FrameLoader::url):
1396         (WebCore::FrameLoader::startRedirectionTimer):
1397         (WebCore::FrameLoader::stopRedirectionTimer):
1398         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
1399         (WebCore::FrameLoader::completed):
1400         (WebCore::FrameLoader::started):
1401         (WebCore::FrameLoader::containsPlugins):
1402         (WebCore::FrameLoader::prepareForLoadStart):
1403         (WebCore::FrameLoader::setupForReplace):
1404         (WebCore::FrameLoader::setupForReplaceByMIMEType):
1405         (WebCore::FrameLoader::finalSetupForReplace):
1406         (WebCore::FrameLoader::load):
1407         (WebCore::FrameLoader::canTarget):
1408         (WebCore::FrameLoader::stopLoadingPlugIns):
1409         (WebCore::FrameLoader::stopLoadingSubresources):
1410         (WebCore::FrameLoader::stopLoadingSubframes):
1411         (WebCore::FrameLoader::stopAllLoaders):
1412         (WebCore::FrameLoader::cancelMainResourceLoad):
1413         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1414         (WebCore::FrameLoader::activeDocumentLoader):
1415         (WebCore::FrameLoader::addPlugInStreamLoader):
1416         (WebCore::FrameLoader::removePlugInStreamLoader):
1417         (WebCore::FrameLoader::hasMainResourceLoader):
1418         (WebCore::FrameLoader::isLoadingSubresources):
1419         (WebCore::FrameLoader::isLoadingPlugIns):
1420         (WebCore::FrameLoader::isLoading):
1421         (WebCore::FrameLoader::addSubresourceLoader):
1422         (WebCore::FrameLoader::removeSubresourceLoader):
1423         (WebCore::FrameLoader::releaseMainResourceLoader):
1424         (WebCore::FrameLoader::setDocumentLoader):
1425         (WebCore::FrameLoader::documentLoader):
1426         (WebCore::FrameLoader::setPolicyDocumentLoader):
1427         (WebCore::FrameLoader::provisionalDocumentLoader):
1428         (WebCore::FrameLoader::setProvisionalDocumentLoader):
1429         (WebCore::FrameLoader::state):
1430         (WebCore::FrameLoader::timeOfLastCompletedLoad):
1431         (WebCore::FrameLoader::setState):
1432         (WebCore::FrameLoader::clearProvisionalLoad):
1433         (WebCore::FrameLoader::markLoadComplete):
1434         (WebCore::FrameLoader::commitProvisionalLoad):
1435         (WebCore::FrameLoader::privateBrowsingEnabled):
1436         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
1437         (WebCore::FrameLoader::clientRedirected):
1438         (WebCore::FrameLoader::shouldReload):
1439         (WebCore::FrameLoader::closeOldDataSources):
1440         (WebCore::FrameLoader::open):
1441         (WebCore::FrameLoader::isStopping):
1442         (WebCore::FrameLoader::finishedLoading):
1443         (WebCore::FrameLoader::URL):
1444         (WebCore::FrameLoader::isArchiveLoadPending):
1445         (WebCore::FrameLoader::isHostedByObjectElement):
1446         (WebCore::FrameLoader::isLoadingMainFrame):
1447         (WebCore::FrameLoader::canShowMIMEType):
1448         (WebCore::FrameLoader::representationExistsForURLScheme):
1449         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
1450         (WebCore::FrameLoader::cancelContentPolicyCheck):
1451         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
1452         (WebCore::FrameLoader::finishedLoadingDocument):
1453         (WebCore::FrameLoader::isReplacing):
1454         (WebCore::FrameLoader::setReplacing):
1455         (WebCore::FrameLoader::revertToProvisional):
1456         (WebCore::FrameLoader::subframeIsLoading):
1457         (WebCore::FrameLoader::willChangeTitle):
1458         (WebCore::FrameLoader::loadType):
1459         (WebCore::FrameLoader::stopPolicyCheck):
1460         (WebCore::FrameLoader::continueAfterContentPolicy):
1461         (WebCore::FrameLoader::continueAfterWillSubmitForm):
1462         (WebCore::FrameLoader::didFirstLayout):
1463         (WebCore::FrameLoader::frameLoadCompleted):
1464         (WebCore::FrameLoader::firstLayoutDone):
1465         (WebCore::FrameLoader::isQuickRedirectComing):
1466         (WebCore::FrameLoader::closeDocument):
1467         (WebCore::FrameLoader::detachChildren):
1468         (WebCore::FrameLoader::checkLoadComplete):
1469         (WebCore::FrameLoader::numPendingOrLoadingRequests):
1470         (WebCore::FrameLoader::setClient):
1471         (WebCore::FrameLoader::client):
1472         (WebCore::FrameLoader::userAgent):
1473         (WebCore::FrameLoader::createEmptyDocument):
1474         (WebCore::FrameLoader::tokenizerProcessedData):
1475         (WebCore::FrameLoader::didTellBridgeAboutLoad):
1476         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
1477         (WebCore::FrameLoader::handledOnloadEvents):
1478         (WebCore::FrameLoader::frameDetached):
1479         (WebCore::FrameLoader::setTitle):
1480         (WebCore::FrameLoaderClient::~FrameLoaderClient):
1481         * loader/FrameLoader.h:
1482         (WebCore::):
1483         * loader/FrameLoaderClient.h:
1484         * loader/PluginDocument.cpp:
1485         (WebCore::PluginTokenizer::createDocumentStructure):
1486         (WebCore::PluginTokenizer::writeRawData):
1487         * loader/ResourceLoader.h:
1488         * loader/TextResourceDecoder.cpp:
1489         (WebCore::TextResourceDecoder::checkForHeadCharset):
1490         * loader/icon/IconLoader.cpp:
1491         (WebCore::IconLoader::startLoading):
1492         (WebCore::IconLoader::finishLoading):
1493         * loader/loader.cpp:
1494         (WebCore::Loader::didReceiveResponse):
1495         * loader/mac/DocumentLoaderMac.mm:
1496         (WebCore::DocumentLoader::~DocumentLoader):
1497         (WebCore::DocumentLoader::stopLoading):
1498         (WebCore::DocumentLoader::finishedLoading):
1499         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1500         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1501         * loader/mac/FrameLoaderMac.mm:
1502         (WebCore::FrameLoader::load):
1503         (WebCore::FrameLoader::startLoading):
1504         (WebCore::FrameLoader::cancelMainResourceLoad):
1505         (WebCore::FrameLoader::receivedMainResourceError):
1506         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1507         (WebCore::FrameLoader::commitProvisionalLoad):
1508         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1509         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1510         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
1511         (WebCore::FrameLoader::detachFromParent):
1512         (WebCore::FrameLoader::addExtraFieldsToRequest):
1513         (WebCore::FrameLoader::loadResourceSynchronously):
1514         (WebCore::FrameLoader::createFrame):
1515         (WebCore::FrameLoader::objectContentType):
1516         (WebCore::nsArray):
1517         (WebCore::FrameLoader::createPlugin):
1518         (WebCore::FrameLoader::redirectDataToPlugin):
1519         (WebCore::FrameLoader::createJavaAppletWidget):
1520         (WebCore::FrameLoader::partClearedInBegin):
1521         (WebCore::FrameLoader::saveDocumentState):
1522         (WebCore::FrameLoader::restoreDocumentState):
1523         (WebCore::FrameLoader::overrideMediaType):
1524         (WebCore::FrameLoader::mainResourceData):
1525         (WebCore::FrameLoader::canGoBackOrForward):
1526         (WebCore::FrameLoader::originalRequestURL):
1527         (WebCore::FrameLoader::getHistoryLength):
1528         (WebCore::FrameLoader::goBackOrForward):
1529         (WebCore::FrameLoader::historyURL):
1530         (WebCore::FrameLoader::didFinishLoad):
1531         * loader/mac/LoaderFunctionsMac.mm:
1532         (WebCore::ServeSynchronousRequest):
1533         (WebCore::CheckCacheObjectStatus):
1534         * loader/mac/ResourceLoaderMac.mm:
1535         (WebCore::ResourceLoader::cancel):
1536         * loader/mac/SubresourceLoaderMac.mm:
1537         (WebCore::SubresourceLoader::create):
1538         * loader/qt/FrameLoaderQt.cpp: Added.
1539         (WebCore::FrameLoader::submitForm):
1540         (WebCore::FrameLoader::urlSelected):
1541         (WebCore::FrameLoader::setTitle):
1542         (WebCore::FrameLoader::createFrame):
1543         (WebCore::FrameLoader::objectContentType):
1544         (WebCore::FrameLoader::createPlugin):
1545         (WebCore::FrameLoader::createJavaAppletWidget):
1546         (WebCore::FrameLoader::originalRequestURL):
1547         * page/DOMWindow.cpp:
1548         (WebCore::DOMWindow::document):
1549         * page/Frame.cpp:
1550         (WebCore::Frame::~Frame):
1551         (WebCore::Frame::reparseConfiguration):
1552         (WebCore::Frame::shouldDragAutoNode):
1553         (WebCore::Frame::prepareForUserAction):
1554         (WebCore::FramePrivate::FramePrivate):
1555         (WebCore::FramePrivate::~FramePrivate):
1556         * page/Frame.h:
1557         * page/FramePrivate.h:
1558         * page/FrameView.cpp:
1559         (WebCore::FrameView::layout):
1560         (WebCore::FrameView::mediaType):
1561         * page/FrameView.h:
1562         * page/PageState.cpp:
1563         (WebCore::PageState::PageState):
1564         (WebCore::PageState::restoreJavaScriptState):
1565         * platform/mac/CookieJar.mm:
1566         (WebCore::setCookies):
1567         * platform/mac/TextCodecMac.cpp:
1568         * platform/mac/WebFontCache.mm:
1569         (+[WebFontCache fontWithFamily:traits:size:]):
1570         * platform/network/cf/ResourceHandleCFNet.cpp:
1571         (WebCore::ResourceHandle::start):
1572         * platform/network/mac/ResourceHandleMac.mm:
1573         (WebCore::ResourceHandle::start):
1574         * platform/qt/FrameQt.cpp:
1575         * platform/qt/FrameQt.h:
1576         * rendering/RenderApplet.cpp:
1577         (WebCore::RenderApplet::createWidgetIfNecessary):
1578         * rendering/RenderBlock.h:
1579         * rendering/RenderPartObject.cpp:
1580         (WebCore::isURLAllowed):
1581         (WebCore::RenderPartObject::updateWidget):
1582         * xml/DOMParser.cpp:
1583         (WebCore::DOMParser::parseFromString):
1584         * xml/XSLTProcessor.cpp:
1585         (WebCore::XSLTProcessor::createDocumentFromSource):
1586         * xml/xmlhttprequest.cpp:
1587         (WebCore::XMLHttpRequest::getResponseXML):
1588
1589 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
1590
1591         Reviewed by Geoff.
1592
1593         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
1594         
1595         * bridge/mac/FrameMac.mm:
1596         (WebCore::FrameMac::registerCommandForUndoOrRedo):
1597         * bridge/mac/WebCoreFrameBridge.h:
1598         * bridge/mac/WebCoreFrameBridge.mm:
1599         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1600         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1601         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
1602         (-[WebCoreFrameBridge selectionGranularity]):
1603         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
1604         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
1605         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
1606         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
1607         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
1608         * editing/SelectionController.cpp:
1609         (WebCore::SelectionController::setModifyBias):
1610         (WebCore::SelectionController::modify):
1611         * editing/SelectionController.h:
1612         (WebCore::SelectionController::):
1613         * editing/TextGranularity.h:
1614
1615 2006-11-07  Brady Eidson  <beidson@apple.com>
1616
1617         Reviewed by Maciej
1618
1619         Changed the check for "top level frame" to something much more valid
1620
1621         * page/Frame.cpp:
1622         (WebCore::Frame::endIfNotLoading):
1623
1624 2006-11-07  Beth Dakin  <bdakin@apple.com>
1625
1626         Reviewed by Hyatt (yesterday).
1627
1628         Here is part of my patch from yesterday that is safe to roll back 
1629         in. It will make the BuildBot happy.
1630
1631         * rendering/HitTestResult.cpp:
1632         (WebCore::HitTestResult::spellingToolTip): Null-check 
1633         m_innerNonSharedNode.
1634
1635 2006-11-07  Darin Adler  <darin@apple.com>
1636
1637         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
1638         Comment grammar fix.
1639
1640 2006-11-07  Darin Adler  <darin@apple.com>
1641
1642         Rolled out change for <rdar://problem/4820814>.
1643
1644         Beth's planning on landing a new change for it soon, but in the mean time
1645         we need layout tests succeeding again.
1646
1647 2006-11-07  Darin Adler  <darin@apple.com>
1648
1649         Reviewed by Brady.
1650
1651         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
1652           crashes on launch in WebCore::ResourceLoader::start
1653
1654         No layout test, because this depends on cached icons, although there's
1655         perhaps a way to write a test for it with some further ingenuity.
1656
1657         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
1658         to make explicit the fact that it can't be successfully copied.
1659         Remove notifyIconChanged function and put the contents in the caller.
1660         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
1661         and clearLoadingState functions to share code. Removed m_url, since the
1662         resource handle already stores the URL. Renamed m_resourceLoader to
1663         m_handle to reflect the class's name change. Removed the 4096-byte
1664         inline buffer from m_data, since the malloc savings is not sufficient
1665         to offset the additional memory use. Removed m_httpStatusCode because
1666         we can instead cancel the load when we get a status code that reflects
1667         failure. Added m_loadIsInProgress boolean because we need to detect
1668         loads that complete during the ResourceHandle::create function call.
1669
1670         * loader/icon/IconLoader.cpp:
1671         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
1672         Don't initialize m_httpStatusCode.
1673         (WebCore::IconLoader::~IconLoader): Updated for name change.
1674         (WebCore::IconLoader::startLoading): Added code to use the
1675         m_loadIsInProgress flag to detect if the load completed while inside
1676         the ResourceHandle::create function. Removed code to set m_url.
1677         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
1678         more code.
1679         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
1680         and finish loading if the HTTP status code indicates failure.
1681         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
1682         the ResourceHandle, since we can't do that any more.
1683         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
1684         so we can share code with the new didReceiveResponse code path.
1685         (WebCore::IconLoader::finishLoading): Moved code here from the
1686         didFinishLoading callback. Pass a URL when calling
1687         commitIconURLToIconDatabase. Call notifyIconChanged directly here
1688         instead of using a separate function. Call clearLoadingState to
1689         share more code with stopLoading.
1690         (WebCore::IconLoader::clearLoadingState): Added.
1691
1692         * loader/mac/IconLoaderMac.mm: Removed.
1693         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
1694
1695 2006-11-06  David Harrison  <harrison@apple.com>
1696
1697         Reviewed by Darin.
1698
1699         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
1700
1701         * editing/pasteboard/3976872-expected.txt:
1702         * editing/pasteboard/4076267-2-expected.txt:
1703         * editing/pasteboard/4076267-3-expected.txt:
1704         * editing/pasteboard/4076267-expected.txt:
1705         * editing/pasteboard/8145-1-expected.txt:
1706         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
1707         * editing/pasteboard/paste-match-style-001-expected.txt:
1708         * editing/pasteboard/paste-match-style-002-expected.txt:
1709         * editing/pasteboard/paste-text-019-expected.txt:
1710         * editing/pasteboard/pasting-tabs-expected.txt:
1711         Updated because pasting text with no newlines does not use intermediate div.
1712         
1713         * editing/markup.cpp:
1714         (WebCore::fillContainerFromString):
1715         First parameter is now a Container so a fragment can be passed.
1716         
1717         (WebCore::createFragmentFromText):
1718         A string with no newlines gets added inline, rather than being put into a paragraph.
1719
1720 2006-11-06  Beth Dakin  <bdakin@apple.com>
1721
1722         Reviewed by Hyatt.
1723
1724         Fix for <rdar://problem/4820814> A crash occurs at 
1725         WebCore::HitTestResult::spellingToolTip() when mousing down on 
1726         iframe at www.macsurfer.com
1727
1728         The bug here is that the source of the iframe is only a comment, 
1729         and we were not properly constructing the frame because it was 
1730         sort-of empty but not.
1731
1732         * html/HTMLDocument.cpp:
1733         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
1734         it is a comment node.
1735         * html/HTMLParser.cpp:
1736         (WebCore::HTMLParser::handleError): if n is a comment node and 
1737         there is no head, we create a head, insert in the document, and add 
1738         the comment node as a child. This is what Firefox does too. 
1739         * page/FrameView.cpp:
1740         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
1741         fix. It is possible to get a mouse event without a target node, so 
1742         we null check it. (Of course, in the case of this bug, it should 
1743         not have been null, but it is a good thing to check for anyway.
1744         * rendering/HitTestResult.cpp:
1745         (WebCore::HitTestResult::spellingToolTip): Null-check 
1746         m_innerNonSharedNode.
1747
1748 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
1749
1750         Reviewed by harrison
1751         
1752         <rdar://problem/4641880>
1753         Setting bullets to existing text grabs subsequent paragraph
1754         
1755         When a selection ends at the start of a paragraph, we rarely paint 
1756         the selection gap before that paragraph, because there often is no gap.  
1757         In a case like this, it's not obvious to the user that the selection 
1758         ends "inside" that paragraph, so it would be confusing if 
1759         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
1760         
1761         * editing/FormatBlockCommand.cpp:
1762         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
1763         the selection to a more appropriate place.  Change the endingSelection
1764         if it ends at the start of a paragraph.
1765         * editing/IndentOutdentCommand.cpp:
1766         (WebCore::IndentOutdentCommand::doApply): Ditto.
1767         * editing/InsertListCommand.cpp:
1768         (WebCore::InsertListCommand::doApply): Ditto.
1769
1770 2006-11-06  Brady Eidson  <beidson@apple.com>
1771
1772         Reviewed by Sarge
1773
1774         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
1775         Toned it down a bit.
1776
1777         * xml/xmlhttprequest.cpp:
1778         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
1779
1780 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1781
1782         Reviewed by Maciej.
1783
1784         Linux\Gdk build fixes.
1785
1786         * loader/icon/IconDatabase.cpp:
1787         * loader/icon/SQLStatement.h:
1788         * platform/gdk/ChromeClientGdk.h: Added.
1789         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1790         * platform/gdk/CursorGdk.cpp:
1791         (WebCore::pointerCursor):
1792         * platform/gdk/FrameGdk.cpp:
1793         (WebCore::doScroll):
1794         (WebCore::FrameGdk::FrameGdk):
1795         (WebCore::FrameGdk::submitForm):
1796         (WebCore::FrameGdk::urlSelected):
1797         (WebCore::FrameGdk::openURL):
1798         (WebCore::FrameGdk::handleGdkEvent):
1799         * platform/gdk/FrameGdk.h:
1800         (WebCore::FrameGdk::client):
1801         * platform/gdk/RenderPopupMenuGdk.cpp:
1802         (WebCore::PopupMenu::updateFromElement):
1803         * platform/gdk/ScreenGdk.cpp:
1804         * platform/gdk/TemporaryLinkStubs.cpp:
1805         (Slider::focusPolicy):
1806         (WebCore::ServeSynchronousRequest):
1807         (FrameGdk::goBackOrForward):
1808         (FrameGdk::getHistoryLength):
1809         (FrameGdk::historyURL):
1810         (ChromeClientGdk::canRunModal):
1811         (ChromeClientGdk::runModal):
1812         (WebCore::systemBeep):
1813         (WebCore::CachedResource::setPlatformResponse):
1814         (Path::transform):
1815         (ResourceLoader::loadsBlocked):
1816         (IconLoader::notifyIconChanged):
1817         * platform/network/gdk/ResourceHandleManager.cpp:
1818         (WebCore::writeCallback):
1819         (WebCore::ResourceHandleManager::downloadTimerCallback):
1820         (WebCore::ResourceHandleManager::remove):
1821         (WebCore::ResourceHandleManager::add):
1822
1823 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1824
1825         build fix.
1826         
1827         * WebCore.xcodeproj/project.pbxproj:
1828
1829 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1830
1831         Reviewed by Maciej, Anders, Darin.
1832
1833         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
1834         Fixed a minor where WebCore would always assume it was displayed on the 
1835         monitor containing the menubar. window.open and window.showModalDialog 
1836         are now cross-platform. 
1837         
1838         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
1839         window-open-features-parsing all pass. I verified the new screen functionality
1840         by running in DRT, and checking whether WebCore knew it was off-screen.
1841         
1842         Some refactoring remains, as all were not pleased by this design. I see
1843         in my future another patch.
1844
1845         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
1846         client, to encapsulate asking the platform questions about the screen occupied by
1847         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
1848         * bridge/mac/WebCoreFrameBridge.mm:
1849         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
1850         functions.
1851         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
1852         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
1853         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
1854         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
1855         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
1856         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
1857         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
1858         (In this case, neither size nor position is specified, so you should
1859         get the default window size and position.)
1860         * page/Screen.cpp: Added. Includes screen-related helper functions used
1861         in WebCore and WebKit.
1862         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
1863         to be duplicated. Renamed "position" to "point" since both were used,
1864         and "point" seemed clearer.
1865         * platform/Screen.h: Removed. Dead Code.
1866         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
1867         initialization.
1868
1869 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
1870
1871         Reviewed by Tim Hatcher.
1872
1873         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
1874         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
1875         
1876         No layout tests added as this must be tested manually by the test
1877         WebCore/manual-tests/contenteditable-link.html
1878
1879         * WebCore.exp: Exported HitTestResult::isLiveLink().
1880         * html/HTMLAnchorElement.cpp:
1881         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
1882         (WebCore::HTMLAnchorElement::defaultEventHandler):
1883         (WebCore::HTMLAnchorElement::isLiveLink):
1884         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
1885         to track shift key status.
1886         * manual-tests/contenteditable-link.html: Added description about link
1887         dragging behaviour.
1888         * rendering/HitTestResult.cpp:
1889         (WebCore::HitTestResult::isLiveLink): Added.
1890         * rendering/HitTestResult.h:
1891
1892 2006-11-06  Brady Eidson  <beidson@apple.com>
1893
1894         Reviewed by Oliver
1895
1896         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
1897         For now, we have to not load favicons when we have no Document - linking directly 
1898         to PDFs being the common case
1899
1900         * loader/icon/IconLoader.cpp:
1901         (WebCore::IconLoader::startLoading): Check for the document and return if none
1902
1903 2006-11-06  Brady Eidson  <beidson@apple.com>
1904
1905         Reviewed by Dave Harrison
1906
1907         <rdar://problem/4801066>
1908         Added a critical null frameLoader() check
1909
1910         * loader/mac/MainResourceLoaderMac.mm:
1911         (WebCore::MainResourceLoader::loadNow):
1912
1913 2006-11-06  David Harrison  <harrison@apple.com>
1914
1915         Reviewed by Darin.
1916
1917         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
1918
1919         Test:
1920         * editing/deleting/delete-br-012.html
1921         
1922         * editing/DeleteSelectionCommand.cpp:
1923         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
1924         Update m_endingPosition when preventing merge.
1925         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
1926
1927 2006-11-06  Mark Rowe  <bdash@webkit.org>
1928
1929         Reviewed by Maciej.
1930
1931         http://bugs.webkit.org/show_bug.cgi?id=11526
1932         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
1933
1934         Update DOMNode::toString to always use className rather than preferring nodeName.
1935
1936         * bindings/js/kjs_dom.cpp:
1937         (KJS::DOMNode::toString): Match the format returned by valueOf.
1938
1939 2006-11-06  Oliver Hunt  <oliver@apple.com>
1940
1941         Reviewed by Maciej.
1942
1943         Fix RTL text in SVG to have correct positioning
1944
1945         * rendering/SVGRootInlineBox.cpp:
1946         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1947
1948 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
1949
1950         Reviewed by Maciej.
1951
1952         http://bugs.webkit.org/show_bug.cgi?id=11517
1953         REGRESSION: Flash clicks/interactivity not working properly
1954
1955         * bridge/mac/FrameMac.mm:
1956         (WebCore::FrameMac::handleMouseMoveEvent):
1957         (WebCore::FrameMac::handleMouseReleaseEvent):
1958         Restore parts of event dispatching that were removed when fixing
1959         bug 7323 - just bypass those for subframes.
1960
1961 2006-11-05  Darin Adler  <darin@apple.com>
1962
1963         - quick attempt to fix the no-SVG build
1964
1965         * platform/graphics/svg/SVGResource.cpp:
1966         * platform/graphics/svg/SVGResource.h:
1967         * platform/graphics/svg/SVGResourceClipper.cpp:
1968         * platform/graphics/svg/SVGResourceClipper.h:
1969         * platform/graphics/svg/SVGResourceImage.h:
1970         * platform/graphics/svg/SVGResourceMarker.cpp:
1971         * platform/graphics/svg/SVGResourceMarker.h:
1972         * platform/graphics/svg/SVGResourceMasker.cpp:
1973         * platform/graphics/svg/SVGResourceMasker.h:
1974         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
1975         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1976         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1977         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
1978         Added #ifdef SVG_SUPPORT to these files.
1979
1980 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
1981
1982         Reviewed & landed by Maciej.
1983
1984         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
1985
1986         * platform/win/ResourceLoaderWin.cpp:
1987         (WebCore::transferJobStatusCallback):
1988         (WebCore::ResourceLoader::start):
1989
1990 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
1991
1992         Reviewed by Oliver.
1993
1994         - moved FormData and FormDataStream to platform/network directory
1995
1996         * WebCore.xcodeproj/project.pbxproj:
1997         * bridge/mac/WebCoreFrameBridge.mm:
1998         * loader/FormData.cpp: Removed.
1999         * loader/FormData.h: Removed.
2000         * loader/mac/FormDataStream.h: Removed.
2001         * loader/mac/FormDataStream.m: Removed.
2002         * loader/mac/FrameLoaderMac.mm:
2003         * loader/mac/SubresourceLoaderMac.mm:
2004         * platform/network/mac/FormDataStreamMac.h: Added.
2005         * platform/network/mac/FormDataStreamMac.mm: Added.
2006         * platform/network/mac/ResourceRequestMac.mm:
2007
2008 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
2009
2010         Fix build breaks
2011
2012         * loader/DocumentLoader.h:
2013         * platform/win/ScreenWin.cpp:
2014
2015 2006-11-05  Darin Adler  <darin@apple.com>
2016
2017         Reviewed by Geoff.
2018
2019         - more preparation for splitting up Frame into sub-pieces
2020         - removed unnecessary includes from Frame.h
2021
2022         * page/Frame.h: Removed unneeded includes and forward declarations.
2023         Added additional forward declarations. Removed the constant
2024         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
2025         Created sections of functions to be moved into Chrome, Editor,
2026         EventHandler, FrameLoader, SelectionController, and the Platform
2027         directory, as well as marking one function for deletion.
2028
2029         * page/FramePrivate.h: Removed the definition of the constructor and
2030         destructor and removed unnecessary includes.
2031
2032         * page/FrameView.h: Removed unneeded forward declarations and friend
2033         declarations. Created a section of functions and data to be moved into
2034         EventHandler.
2035
2036         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
2037         Created sections of functions and data to be moved into Chrome,
2038         Editor, EventHandler, FrameLoader, and the Platform directory.
2039
2040         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
2041         Removed unused methods areScrollbarsVisible,
2042         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
2043
2044         * page/Frame.cpp:
2045         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
2046         to include KURL.h just for the KURL default constructor.
2047         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
2048         (WebCore::FramePrivate::~FramePrivate): Ditto.
2049
2050         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
2051         booleans, scrollbarMoved and cleared funcitons.
2052         (WebCore::FrameView::clear): Moved the code from the cleared
2053         function in here.
2054         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
2055
2056         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
2057         for changes to header.
2058
2059         * editing/SelectionController.cpp:
2060         (WebCore::SelectionController::setSelection):
2061         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2062         Moved NoXPosForVerticalArrowNavigation into this file.
2063
2064         * bindings/js/kjs_events.cpp:
2065         * bindings/js/kjs_html.cpp:
2066         * bindings/js/kjs_window.cpp:
2067         * bridge/mac/WebCoreAXObject.mm:
2068         * bridge/mac/WebCoreFrameBridge.mm:
2069         * css/cssstyleselector.cpp:
2070         * dom/Document.cpp:
2071         * dom/Element.cpp:
2072         * dom/EventTargetNode.cpp:
2073         * dom/MouseRelatedEvent.cpp:
2074         * dom/XMLTokenizer.cpp:
2075         * html/HTMLBaseElement.cpp:
2076         * html/HTMLDocument.cpp:
2077         * html/HTMLEmbedElement.cpp:
2078         * html/HTMLFrameElementBase.cpp:
2079         * html/HTMLGenericFormElement.cpp:
2080         * html/HTMLObjectElement.cpp:
2081         * html/HTMLTokenizer.cpp:
2082         * loader/mac/FrameLoaderMac.mm:
2083         * page/PageState.cpp:
2084         * rendering/RenderApplet.cpp:
2085         * rendering/RenderBlock.cpp:
2086         * rendering/RenderLayer.cpp:
2087         * rendering/RenderObject.cpp:
2088         * rendering/RenderPartObject.cpp:
2089         * rendering/RenderTreeAsText.cpp:
2090         * xml/XSLTProcessor.cpp:
2091         Added includes as needed to keep compiling, since there are fewer
2092         includes in Frame.h.
2093
2094 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
2095
2096         Reviewed by Dave Harrison.
2097
2098         http://bugs.webkit.org/show_bug.cgi?id=11402
2099         REGRESSION: onChange does not work anymore for 1st item in popup
2100
2101         * html/HTMLSelectElement.cpp:
2102         (WebCore::HTMLSelectElement::HTMLSelectElement):
2103         (WebCore::HTMLSelectElement::reset):
2104         Set m_lastOnChangeIndex to -1.
2105
2106 2006-11-04  Darin Adler  <darin@apple.com>
2107
2108         Reviewed by Anders.
2109
2110         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
2111           REGRESSION: Status bar always shows cancelled opening the page
2112
2113         * platform/network/mac/ResourceHandleMac.mm:
2114         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
2115         Since the subresource owns the resource handle, there's no need to cancel.
2116         This arrangement is only temporary, anyway, since Maciej will soon change
2117         things so that the subresource loader uses the resource handle and the
2118         resource handle doesn't know anything about the subresource loader.
2119
2120 2006-11-04  Darin Adler  <darin@apple.com>
2121
2122         Reviewed by Maciej.
2123
2124         - converted more of the loader machinery to work with cross-platform
2125           data structures instead of Macintosh-specific ones
2126
2127           converted most uses of NSURL to KURL and NSEvent to DOM Event in
2128           loader classes
2129
2130           moved download function out of FrameLoader.h to avoid reference to
2131           NSURLConnection
2132
2133           added DOM Event parameters to various functions so that the handlers
2134           can use the DOM Event instead of the global "current NSEvent";
2135           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
2136           HTMLFormElement::submit, FrameLoader::load
2137
2138           moved the setMainFrame call that hands ownership to the Page
2139           into one of the Frame constructors, and removed it from all
2140           the clients
2141
2142           removed const from Event parameter to the urlSelected function
2143           (we rarely use const with DOM elements)
2144
2145           removed some redundant includes and declarations from various
2146           header files
2147
2148           removed NSURL parameter from userAgent function -- if we need it we
2149           can add it back, but converting from NSURL to KURL and back is
2150           inefficient enough that it's best to have it out for now (since it's
2151           been unused for years) -- if we add it back, we can choose an
2152           appropriate parameter type that's always inexpensive to pass
2153
2154           did some basic cleanup in the IconLoader class, including removing
2155           an unnecessary loop that added icon data a byte at a time
2156
2157           renamed safeLoad to load, since it's no different from the other
2158           FrameLoader load functions, safety-wise
2159
2160           fixed some code that was trying to distinguish null frame name from
2161           empty string frame name -- both should be handled the same, but callers
2162           were doing it by checking for empty and turning it into null (in a way
2163           that was causing extra round trips between NSString and WebCore::String)
2164
2165           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
2166           and got rid of case-insensitive compares of methods
2167
2168         * WebCore.exp:
2169         * WebCore.xcodeproj/project.pbxproj:
2170         * bindings/js/kjs_navigator.cpp:
2171         (KJS::Navigator::getValueProperty):
2172         * bridge/mac/FrameMac.h:
2173         * bridge/mac/FrameMac.mm:
2174         (WebCore::FrameMac::submitForm):
2175         (WebCore::FrameMac::urlSelected):
2176         (WebCore::FrameMac::userAgent):
2177         * bridge/mac/FrameViewMac.mm:
2178         * bridge/mac/WebCoreAXObject.mm:
2179         (-[WebCoreAXObject rendererForView:]):
2180         * bridge/mac/WebCorePageBridge.h:
2181         * bridge/mac/WebCorePageBridge.mm:
2182         * bridge/mac/WebCoreSettings.mm:
2183         * bridge/win/FrameWin.cpp:
2184         (WebCore::FrameWin::urlSelected):
2185         (WebCore::FrameWin::submitForm):
2186         * bridge/win/FrameWin.h:
2187         * dom/MouseRelatedEvent.cpp:
2188         * dom/MouseRelatedEvent.h:
2189         * dom/UIEvent.cpp:
2190         (WebCore::UIEvent::~UIEvent):
2191         * dom/UIEvent.h:
2192         * dom/UIEventWithKeyState.h:
2193         * dom/XMLTokenizer.cpp:
2194         (WebCore::openFunc):
2195         * html/HTMLAnchorElement.cpp:
2196         (WebCore::HTMLAnchorElement::defaultEventHandler):
2197         * html/HTMLButtonElement.cpp:
2198         (WebCore::HTMLButtonElement::defaultEventHandler):
2199         * html/HTMLFormElement.cpp:
2200         (WebCore::HTMLFormElement::submitClick):
2201         (WebCore::HTMLFormElement::prepareSubmit):
2202         (WebCore::HTMLFormElement::submit):
2203         * html/HTMLFormElement.h:
2204         * html/HTMLInputElement.cpp:
2205         (WebCore::HTMLInputElement::defaultEventHandler):
2206         * html/HTMLSelectElement.cpp:
2207         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
2208         * loader/DocumentLoader.h:
2209         * loader/FrameLoader.h:
2210         * loader/FrameLoaderClient.h:
2211         * loader/NavigationAction.h:
2212         (WebCore::NavigationAction::event):
2213         * loader/icon/IconLoader.cpp:
2214         (WebCore::IconLoader::create):
2215         (WebCore::IconLoader::startLoading):
2216         (WebCore::IconLoader::didReceiveData):
2217         (WebCore::IconLoader::didFinishLoading):
2218         * loader/icon/IconLoader.h:
2219         * loader/loader.cpp:
2220         * loader/mac/DocumentLoaderMac.mm:
2221         (WebCore::DocumentLoader::URL):
2222         (WebCore::DocumentLoader::unreachableURL):
2223         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
2224         (WebCore::DocumentLoader::URLForHistory):
2225         * loader/mac/FrameLoaderMac.mm:
2226         (WebCore::FrameLoader::load):
2227         (WebCore::FrameLoader::willSendRequest):
2228         (WebCore::FrameLoader::clientRedirected):
2229         (WebCore::FrameLoader::shouldReload):
2230         (WebCore::FrameLoader::notifyIconChanged):
2231         (WebCore::FrameLoader::URL):
2232         (WebCore::FrameLoader::reloadAllowingStaleData):
2233         (WebCore::FrameLoader::reload):
2234         (WebCore::FrameLoader::didChangeTitle):
2235         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2236         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2237         (WebCore::FrameLoader::post):
2238         (WebCore::FrameLoader::addExtraFieldsToRequest):
2239         (WebCore::FrameLoader::loadResourceSynchronously):
2240         * loader/mac/IconLoaderMac.mm:
2241         (WebCore::IconLoader::notifyIconChanged):
2242         * loader/mac/LoaderFunctionsMac.mm:
2243         * loader/mac/MainResourceLoaderMac.mm:
2244         (WebCore::shouldLoadAsEmptyDocument):
2245         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2246         * loader/mac/NavigationActionMac.mm:
2247         (WebCore::navigationType):
2248         (WebCore::NavigationAction::NavigationAction):
2249         * loader/mac/ResourceLoaderMac.mm:
2250         * loader/mac/SubresourceLoaderMac.mm:
2251         * page/Frame.cpp:
2252         (WebCore::Frame::Frame):
2253         (WebCore::Frame::urlSelected):
2254         (WebCore::Frame::submitFormAgain):
2255         (WebCore::Frame::submitForm):
2256         (WebCore::Frame::endIfNotLoading):
2257         (WebCore::Frame::hitTestResultAtPoint):
2258         * page/Frame.h:
2259         * page/FramePrivate.h:
2260         * platform/gdk/FrameGdk.cpp:
2261         (WebCore::FrameGdk::FrameGdk):
2262         (WebCore::FrameGdk::submitForm):
2263         (WebCore::FrameGdk::urlSelected):
2264         * platform/gdk/FrameGdk.h:
2265         * platform/mac/TextFieldMac.mm:
2266         * platform/network/HTTPHeaderMap.h:
2267         * platform/network/ResourceHandle.h:
2268         * platform/network/ResourceHandleClient.h:
2269         * platform/network/ResourceHandleInternal.h:
2270         * platform/network/mac/ResourceHandleMac.mm:
2271         * platform/network/mac/ResourceResponseMac.h:
2272         * platform/network/mac/ResourceResponseMac.mm:
2273         (-[NSURLResponse WebCore]):
2274         * platform/network/win/ResourceHandleWin.cpp:
2275         * platform/qt/FrameQt.cpp:
2276         (WebCore::FrameQt::submitForm):
2277         (WebCore::FrameQt::urlSelected):
2278         * platform/qt/FrameQt.h:
2279         * rendering/RenderLineEdit.cpp:
2280         (WebCore::RenderLineEdit::returnPressed):
2281         * xml/XSLTProcessor.cpp:
2282         (WebCore::docLoaderFunc):
2283         * xml/xmlhttprequest.cpp:
2284
2285 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2286
2287         Reviewed by Adele.
2288
2289         - replaced receivedRedirect with new willSendRequest delegate
2290         - removed most mac-specific loader functions
2291         - use ResourceResponse more in loader code
2292
2293         * WebCore.xcodeproj/project.pbxproj: Add new files.
2294         * bridge/mac/WebCoreFrameBridge.mm:
2295         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
2296         for CachedResource method renames.
2297         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2298         Ditto.
2299         * loader/CachedCSSStyleSheet.cpp:
2300         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
2301         based on ResourceResponse
2302         * loader/CachedImage.cpp:
2303         (WebCore::CachedImage::createImage): adapt for ResourceResponse
2304         * loader/CachedResource.cpp:
2305         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
2306         platform response is now called platformResponse and expiration date
2307         is removed.
2308         (WebCore::CachedResource::~CachedResource): ditto
2309         (WebCore::CachedResource::isExpired): ditto
2310         * loader/CachedResource.h:
2311         (WebCore::CachedResource::platformResponse): ditto
2312         (WebCore::CachedResource::setResponse): ditto
2313         (WebCore::CachedResource::canDelete): ditto
2314         * loader/LoaderFunctions.h:
2315         * loader/loader.cpp:
2316         (WebCore::Loader::receivedResponse): Adjusted for renames.
2317         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
2318         in the CachedResource.
2319         * loader/loader.h:
2320         * loader/mac/FormDataStream.h:
2321         * loader/mac/FormDataStream.m:
2322         (WebCore::getStreamFormDatas): Rearranged things so it's
2323         possible to get a FormData back out of a form data stream.
2324         (WebCore::formCreate): ditto
2325         (WebCore::formFinalize): ditto
2326         (WebCore::httpBodyFromStream): ditto
2327         * loader/mac/ImageDocumentMac.mm:
2328         (WebCore::finishImageLoad): s/response/platformResponse/
2329         * loader/mac/LoaderFunctionsMac.mm:
2330         (WebCore::CheckCacheObjectStatus): ditto
2331         (WebCore::CachedResource::setPlatformResponse): ditto
2332         * loader/mac/SubresourceLoaderMac.mm:
2333         (WebCore::SubresourceLoader::willSendRequest): send redirect
2334         to client appropriately
2335         * platform/network/ResourceHandle.h:
2336         * platform/network/ResourceHandleClient.h:
2337         (WebCore::ResourceHandleClient::willSendRequest): new entry
2338         point for SubresourceLoader, dispatch to client.
2339         * platform/network/ResourceRequest.h:
2340         (WebCore::ResourceRequest::allowHTTPCookies): implemented
2341         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
2342         * platform/network/ResourceResponse.h:
2343         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
2344         date(!)
2345         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
2346         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
2347         (WebCore::openNextStream): ditto
2348         (WebCore::formCreate): ditto
2349         (WebCore::formFinalize): ditto
2350         (WebCore::formCanRead): ditto
2351         (WebCore::formEventCallback): ditto
2352         (WebCore::setHTTPBody): ditto
2353         (WebCore::httpBodyFromStream): ditto
2354         * platform/network/cf/FormDataStreamCFNet.h: Added.
2355         * platform/network/cf/ResourceHandleCFNet.cpp:
2356         (WebCore::willSendRequest): implemented
2357         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
2358         * platform/network/cf/ResourceResponseCFNet.cpp:
2359         (WebCore::getResourceResponse): do nothing for a null response
2360         * platform/network/mac/ResourceHandleMac.mm:
2361         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
2362         * platform/network/mac/ResourceRequestMac.h: Added.
2363         * platform/network/mac/ResourceRequestMac.mm: Added.
2364         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
2365         to a ResourceRequest.
2366         (WebCore::nsURLRequest): Opposite of the above.
2367         * platform/network/cf/ResourceRequestCFNet.h: Added.
2368         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
2369         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
2370         to a ResourceRequest.
2371         (WebCore::cfURLRequest): Opposite of the above.
2372         * xml/xmlhttprequest.cpp:
2373         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
2374         adjusted.
2375         * xml/xmlhttprequest.h:
2376
2377 2006-11-04  Darin Adler  <darin@apple.com>
2378
2379         Change suggested by Mitz.
2380
2381         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
2382           REGRESSION (r17438): Repro crash when opening a web archive
2383
2384         * bridge/mac/WebCorePageState.mm:
2385         (-[WebCorePageState dealloc]): Add null check.
2386         (-[WebCorePageState finalize]): Ditto.
2387
2388 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
2389
2390         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
2391
2392         http://bugs.webkit.org/show_bug.cgi?id=11433
2393         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
2394
2395         * WebCore.vcproj/WebCore/WebCore.vcproj:
2396         Added platform/graphics platform/network and platform/network/win to headers search paths
2397         Created platform/graphics and platform/network filters in hierarchy
2398         Moved GraphicsContext and GraphicsTypes to their respective filters
2399         Added EditorClient.h
2400         Added FrameLoader* files in loader/
2401         Added HitTest* files in rendering/
2402         Added Editor.* files in editing/
2403         Added DeleteButton.* and DeleteButtonController.* in editing/
2404
2405         * bridge/win/ChromeClientWin.h: Added.
2406         (WebCore::ChromeClientWin::~ChromeClientWin):
2407         * bridge/win/EditorClientWin.h: Added.
2408         (WebCore::EditorClientWin::~EditorClientWin):
2409
2410         * bridge/win/FrameWin.cpp:
2411         (WebCore::FrameWin::FrameWin):
2412         (WebCore::FrameWin::urlSelected):
2413         (WebCore::FrameWin::submitForm):
2414         (WebCore::FrameWin::createNewWindow):
2415         * bridge/win/FrameWin.h:
2416         Added EditorClient parameter to constructor
2417         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
2418         Removed openURL() and openURLRequest from class definition
2419
2420         * bridge/win/PageWin.cpp:
2421         * platform/AffineTransform.h:
2422         * platform/cairo/AffineTransformCairo.cpp: Added.
2423         (WebCore::AffineTransform::AffineTransform):
2424         (WebCore::AffineTransform::setMatrix):
2425         (WebCore::AffineTransform::map):
2426         (WebCore::AffineTransform::mapRect):
2427         (WebCore::AffineTransform::isIdentity):
2428         (WebCore::AffineTransform::m11):
2429         (WebCore::AffineTransform::m12):
2430         (WebCore::AffineTransform::m21):
2431         (WebCore::AffineTransform::m22):
2432         (WebCore::AffineTransform::dx):
2433         (WebCore::AffineTransform::dy):
2434         (WebCore::AffineTransform::reset):
2435         (WebCore::AffineTransform::scale):
2436         (WebCore::AffineTransform::rotate):
2437         (WebCore::AffineTransform::translate):
2438         (WebCore::AffineTransform::shear):
2439         (WebCore::AffineTransform::det):
2440         (WebCore::AffineTransform::invert):
2441         (WebCore::AffineTransform::operator cairo_matrix_t):
2442         (WebCore::AffineTransform::operator== ):
2443         (WebCore::AffineTransform::operator*= ):
2444         (WebCore::AffineTransform::operator* ):
2445         * platform/cairo/GraphicsContextCairo.cpp:
2446         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
2447         * platform/network/win/ResourceHandleWin.cpp:
2448         (WebCore::ResourceHandle::onHandleCreated):
2449         (WebCore::ResourceHandle::start):
2450         (WebCore::ResourceHandle::fileLoadTimer):
2451         (WebCore::ResourceHandle::cancel):
2452         * platform/win/TemporaryLinkStubs.cpp:
2453         (WebCore::FrameWin::goBackOrForward):
2454         (WebCore::FrameWin::getHistoryLength):
2455         (WebCore::FrameWin::historyURL):
2456         (WebCore::ServeSynchronousRequest):
2457         (WebCore::ChromeClientWin::canRunModal):
2458         (WebCore::ChromeClientWin::runModal):
2459         (WebCore::EditorClientWin::shouldDeleteRange):
2460         (WebCore::EditorClientWin::shouldShowDeleteInterface):
2461         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
2462         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
2463         (WebCore::EditorClientWin::spellCheckerDocumentTag):
2464         (WebCore::Path::transform):
2465         (WebCore::PopupMenu::updateFromElement):
2466         (WebCore::ResourceLoader::loadsBlocked):
2467         (WebCore::systemBeep):
2468         * rendering/RenderThemeWin.cpp:
2469         (WebCore::RenderThemeWin::paintButton):
2470         (WebCore::RenderThemeWin::paintTextField):
2471
2472 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
2473
2474         Reviewed by Maciej.
2475
2476         http://bugs.webkit.org/show_bug.cgi?id=11448
2477         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
2478
2479         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
2480
2481 2006-11-03  Mark Rowe  <bdash@webkit.org>
2482
2483         Reviewed by Oliver.
2484
2485         Update Windows and Qt project files for file removals in r17585.
2486
2487         * CMakeLists.txt:
2488         * WebCore.vcproj/WebCore/WebCore.vcproj:
2489
2490 2006-11-03  Zack Rusin  <zack@kde.org>
2491
2492         Reviewed by Maciej.
2493
2494         The patch fixes text field drawing on the Qt platform.
2495
2496         * platform/qt/RenderThemeQt.cpp:
2497         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
2498         render the text field
2499
2500 2006-11-03  Oliver Hunt  <oliver@apple.com>
2501
2502         Reviewed by Tim.
2503
2504         Correct incorrect call to SetCursor
2505
2506         * rendering/RenderFrameSet.cpp:
2507         (WebCore::RenderFrameSet::userResize):
2508
2509 2006-11-03  Adele Peterson  <adele@apple.com>
2510
2511         Reviewed by Oliver.
2512
2513         Removed DeprecatedRenderSelect and ListBox classes.
2514
2515         * WebCore.xcodeproj/project.pbxproj:
2516         * css/html4.css:
2517         * html/HTMLOptionElement.h:
2518         * html/HTMLSelectElement.cpp:
2519         (WebCore::HTMLSelectElement::recalcStyle):
2520         (WebCore::HTMLSelectElement::isKeyboardFocusable):
2521         (WebCore::HTMLSelectElement::isMouseFocusable):
2522         (WebCore::HTMLSelectElement::createRenderer):
2523         (WebCore::HTMLSelectElement::setRecalcListItems):
2524         (WebCore::HTMLSelectElement::notifyOptionSelected):
2525         (WebCore::HTMLSelectElement::defaultEventHandler):
2526         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
2527         (WebCore::HTMLSelectElement::updateListBoxSelection):
2528         * html/HTMLSelectElement.h:
2529         * platform/ListBox.h: Removed.
2530         * platform/mac/FontCacheMac.mm:
2531         * platform/mac/ListBoxMac.mm: Removed.
2532         * platform/win/TemporaryLinkStubs.cpp:
2533         * rendering/DeprecatedRenderSelect.cpp: Removed.
2534         * rendering/DeprecatedRenderSelect.h: Removed.
2535
2536 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2537
2538         Not reviewed, fix for accidental commit.
2539
2540         - rolled back more of the accidentall commit that I forgot.
2541
2542         * platform/network/mac/ResourceRequestMac.h: Removed.
2543         * platform/network/mac/ResourceRequestMac.mm: Removed.
2544
2545 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2546
2547         Not reviewed, fix for accidental commit.
2548
2549         - roll back some network changes accidentally committed with a previous patch.
2550
2551         * WebCore.xcodeproj/project.pbxproj:
2552         * bridge/mac/WebCoreFrameBridge.mm:
2553         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2554         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2555         * loader/CachedCSSStyleSheet.cpp:
2556         (WebCore::CachedCSSStyleSheet::checkNotify):
2557         * loader/CachedImage.cpp:
2558         (WebCore::CachedImage::createImage):
2559         * loader/CachedResource.cpp:
2560         (WebCore::CachedResource::CachedResource):
2561         (WebCore::CachedResource::~CachedResource):
2562         (WebCore::CachedResource::setExpireDate):
2563         (WebCore::CachedResource::isExpired):
2564         * loader/CachedResource.h:
2565         (WebCore::CachedResource::response):
2566         * loader/LoaderFunctions.h:
2567         * loader/loader.cpp:
2568         (WebCore::Loader::receivedResponse):
2569         (WebCore::Loader::didReceivedResponse):
2570         * loader/loader.h:
2571         * loader/mac/FormDataStream.h:
2572         * loader/mac/FormDataStream.m:
2573         (WebCore::formCreate):
2574         (WebCore::formFinalize):
2575         * loader/mac/ImageDocumentMac.mm:
2576         (WebCore::finishImageLoad):
2577         * loader/mac/LoaderFunctionsMac.mm:
2578         (WebCore::CheckCacheObjectStatus):
2579         (WebCore::CachedResource::setResponse):
2580         * loader/mac/SubresourceLoaderMac.mm:
2581         (WebCore::SubresourceLoader::willSendRequest):
2582         * platform/network/ResourceHandle.h:
2583         * platform/network/ResourceHandleClient.h:
2584         (WebCore::ResourceHandleClient::receivedRedirect):
2585         * platform/network/ResourceRequest.h:
2586         * platform/network/ResourceResponse.h:
2587         (WebCore::ResourceResponse::ResourceResponse):
2588         * platform/network/mac/ResourceHandleMac.mm:
2589         (WebCore::ResourceHandle::redirectedToURL):
2590         * xml/xmlhttprequest.cpp:
2591         (WebCore::XMLHttpRequest::receivedRedirect):
2592         * xml/xmlhttprequest.h:
2593
2594 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
2595
2596         Rubber-stamped by Oliver.
2597
2598         Remove these, they have been merged with SVGRenderTreeAsText.
2599         
2600         * rendering/SVGRenderAsText.cpp: Removed.
2601         * rendering/SVGRenderAsText.h: Removed.
2602
2603 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
2604
2605         Build fix.
2606         
2607         * platform/network/cf/ResourceHandleCFNet.cpp:
2608         (WebCore::willSendRequest):
2609
2610 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
2611
2612         Reviewed by Darin, Beth.
2613         
2614         First cut at factoring Page's UIDelegate-related functions into Chrome
2615         and ChromeClient.
2616
2617         Layout tests pass.
2618         
2619         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
2620         setBridge method to replace it.
2621         (WebCore::Page::setBridge):
2622
2623         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
2624         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
2625         and, now that it uses PassRefPtr, can't be.
2626         
2627         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
2628
2629         * page/Page.h:
2630         (WebCore::Page::dragCaretController): Made this function non-const so that
2631         m_dragCaretController doesn't have to be mutable.
2632
2633 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
2634
2635         Reviewed by Adele.
2636
2637         http://bugs.webkit.org/show_bug.cgi?id=7323
2638         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
2639
2640         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
2641         in FrameMac.mm. There can be only one drag active at any moment, and having 
2642         this information here was making sharing this information between 
2643         subframes hard.
2644
2645         * bridge/mac/FrameMac.mm:
2646         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
2647         (WebCore::FrameMac::freeClipboard):
2648         (WebCore::FrameMac::dragHysteresisExceeded):
2649         (WebCore::FrameMac::handleMouseMoveEvent):
2650         (WebCore::FrameMac::handleMouseReleaseEvent):
2651         (WebCore::FrameMac::mouseDown):
2652         (WebCore::FrameMac::dragSourceMovedTo):
2653         (WebCore::FrameMac::dragSourceEndedAt):
2654         (WebCore::FrameMac::dispatchDragSrcEvent):
2655         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
2656         Also removed some old code that was forwarding mouse events to subviews to make 
2657         HTML editing work in subframes.
2658
2659         * page/FrameView.cpp:
2660         (WebCore::FrameView::updateDragAndDrop):
2661         (WebCore::FrameView::cancelDragAndDrop):
2662         (WebCore::FrameView::performDragAndDrop):
2663         Forward events to subframes for dispatching - this fixes drag target events.
2664
2665 2006-11-03  Zack Rusin  <zack@kde.org>
2666
2667         Reviewed by Tim.
2668
2669         Fixing compile.
2670
2671         * platform/qt/LoaderFunctionsQt.cpp:
2672         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
2673
2674 2006-11-01  Zack Rusin  <zack@kde.org>
2675
2676         Reviewed by Maciej.
2677
2678         Moving the word/sentence seperators into a file of their own
2679         and implementing findWordBoundary.
2680
2681         * CMakeLists.txt:
2682         * platform/qt/TemporaryLinkStubs.cpp:
2683         * platform/qt/TextBoundaries.cpp: Added.
2684         (WebCore::findNextSentenceFromIndex):
2685         (WebCore::findSentenceBoundary):
2686         (WebCore::findNextWordFromIndex):
2687         (WebCore::findWordBoundary):
2688
2689 2006-11-03  Zack Rusin  <zack@kde.org>
2690
2691         Reviewed by Maciej.
2692
2693         Compile on both KDE and Qt platforms
2694
2695         * CMakeLists.txt: add zlib explicitly
2696         * platform/network/qt/ResourceHandleManager.cpp:
2697         (WebCore::ResourceHandleManager::self):
2698         (WebCore::QtJob::QtJob):
2699         (WebCore::QtJob::timerEvent): Integrate both implementations
2700         so that moc can parse it
2701         (WebCore::ResourceHandleManager::deliverJobData):
2702         (WebCore::ResourceHandleManager::remove):
2703         * platform/network/qt/ResourceHandleManager.h:
2704
2705 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
2706
2707         No review, suggested by Mitz.
2708
2709         - fix a #if to be #ifdef
2710
2711         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
2712
2713 2006-11-03  Zack Rusin  <zack@kde.org>
2714
2715         Reviewed and landed by Maciej.
2716         
2717         Compile on the Qt platform.
2718
2719         * ksvg2/misc/KCanvasRenderingStyle.h:
2720         * platform/qt/RenderThemeQt.cpp:
2721         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
2722
2723 2006-11-03  Zack Rusin  <zack@kde.org>
2724
2725         Reviewed by Hyatt. Landed by Maciej.
2726
2727         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
2728         to graphics context to be able to set consistant state
2729         on the platform specific painter without having to change
2730         fill/stroke/font on every operation. This fixes color/stroke/fill
2731         and font handling in the Qt port.
2732
2733         * platform/graphics/GraphicsContext.cpp:
2734         (WebCore::GraphicsContext::setFont):
2735         (WebCore::GraphicsContext::setPen):
2736         (WebCore::GraphicsContext::setFillColor):
2737         (WebCore::GraphicsContext::setPlatformPen):
2738         (WebCore::GraphicsContext::setPlatformFillColor):
2739         (WebCore::GraphicsContext::setPlatformFont):
2740         * platform/graphics/GraphicsContext.h:
2741         * platform/qt/GraphicsContextQt.cpp:
2742         (WebCore::toQtCompositionMode):
2743         (WebCore::toQtLineCap):
2744         (WebCore::toQtLineJoin):
2745         (WebCore::toQPenStyle):
2746         (WebCore::penToQPen):
2747         (WebCore::TransparencyLayer::TransparencyLayer):
2748         (WebCore::GraphicsContext::addRoundedRectClip):
2749         (WebCore::GraphicsContext::setPlatformFont):
2750         (WebCore::GraphicsContext::setPlatformPen):
2751         (WebCore::GraphicsContext::setPlatformFillColor):
2752         * platform/qt/ScrollViewCanvasQt.cpp:
2753         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
2754         (WebCore::ScrollViewCanvasQt::paintEvent):
2755         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
2756         * platform/qt/ScrollViewCanvasQt.h:
2757
2758 2006-11-02  Adele Peterson  <adele@apple.com>
2759
2760         Reviewed by Anders.
2761
2762         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
2763         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
2764
2765         Test: fast/forms/textarea-no-scroll-on-blur.html
2766
2767         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
2768           On blur, only scroll back to the start for text fields.
2769
2770 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2771
2772         Another build fix.
2773         
2774         * rendering/RenderFileUploadControl.cpp:
2775         (WebCore::RenderFileUploadControl::paintObject):
2776
2777 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2778
2779         Build fix.
2780         
2781         * page/FramePrivate.h:
2782         (WebCore::FramePrivate::FramePrivate):
2783
2784 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
2785
2786         Reviewed by Geoff, landed by Anders.
2787         
2788         Fix dependency problems caused when running move-js-headers.sh
2789         
2790         * move-js-headers.sh:
2791         Use cp -p instead of just cp so that the modification time
2792         of the original files are used.
2793
2794 2006-11-02  Adam Roben  <aroben@apple.com>
2795
2796         Reviewed by Tim H, landed by Anders.
2797
2798         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
2799         REGRESSION: Shadow of file upload button is clipped
2800
2801         * rendering/RenderFileUploadControl.cpp:
2802         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
2803         height to keep from clipping in the shadow
2804
2805 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
2806
2807         Reviewed by Maciej, landed by Anders.
2808
2809         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
2810         content and window. ScrollViewQt already receives correct content
2811         coordinates from QScrollArea.
2812         (WebCore::ScrollView::contentsToWindow):
2813         (WebCore::ScrollView::windowToContents):
2814
2815 2006-11-02  Simon Hausmann  <hausmann@kde.org>
2816
2817         Reviewed by Maciej, landed by Anders
2818
2819         * CMakeLists.txt: Make linkage against KDE libraries conditional
2820         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
2821           Qt base resource handler that supports only requests to the
2822           local filesystem. Used when compiling without KDE support.
2823           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
2824           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
2825         (WebCore::QtJob::QtJob):
2826         (WebCore::QtJob::timerEvent):
2827         (WebCore::ResourceHandleManager::ResourceHandleManager):
2828         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2829         (WebCore::ResourceHandleManager::self):
2830         (WebCore::ResourceHandleManager::remove):
2831         (WebCore::ResourceHandleManager::add):
2832         (WebCore::ResourceHandleManager::cancel):
2833         (WebCore::ResourceHandleManager::deliverJobData):
2834         * platform/network/qt/ResourceHandleManager.h:
2835         * platform/qt/FrameQtClient.cpp:
2836         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
2837         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
2838         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
2839         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
2840           input dialog functions when compiling without KDE support
2841         (WebCore::ServeSynchronousRequest):
2842
2843 2006-11-02  David Carson  <dacarson@gmail.com>
2844
2845         Reviewed by Geoff, landed by Anders.
2846
2847         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
2848         Initializing variable in constructor.
2849
2850         * page/FramePrivate.h:
2851         (WebCore::FramePrivate::FramePrivate):
2852
2853 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2854
2855         Reviewed by Geoff.
2856
2857         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
2858         
2859         * platform/network/cf/ResourceHandleCFNet.cpp:
2860         (WebCore::addHeadersFromHashMap):
2861         Don't set all headers at once since that clears any previous headers set.
2862         
2863         (WebCore::ResourceHandle::start):
2864
2865 2006-11-02  Adele Peterson  <adele@apple.com>
2866
2867         Reviewed by Mitz and Geoff.
2868
2869         - Fix for:
2870         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
2871         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
2872         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
2873
2874         Test: fast/forms/textarea-scrollbar.html
2875
2876         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
2877         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
2878
2879         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
2880         * rendering/RenderTextControl.cpp: 
2881         (WebCore::RenderTextControl::RenderTextControl):
2882         (WebCore::RenderTextControl::setStyle):
2883         (WebCore::RenderTextControl::createDivStyle):
2884         (WebCore::RenderTextControl::updateFromElement):
2885         (WebCore::RenderTextControl::calcHeight):
2886         (WebCore::RenderTextControl::baselinePosition):
2887         (WebCore::RenderTextControl::nodeAtPoint):
2888         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
2889         (WebCore::RenderTextControl::scrollWidth):
2890         (WebCore::RenderTextControl::scrollHeight):
2891         (WebCore::RenderTextControl::scrollLeft):
2892         (WebCore::RenderTextControl::scrollTop):
2893
2894         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
2895
2896 2006-11-02  John Sullivan  <sullivan@apple.com>
2897
2898         Reviewed by Geoff Garen
2899
2900         * editing/Selection.cpp:
2901         (WebCore::Selection::showTreeForThis):
2902         this debugging method now displays start offset and end offset, at Darin's suggestion
2903
2904 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
2905
2906         Reviewed by darin
2907
2908         <rdar://problem/4062865>
2909         Copy/paste of a select element fails to include the options
2910         
2911         * editing/SelectionController.cpp:
2912         (WebCore::SelectionController::modify): Added paragraphBoundary.
2913         * editing/htmlediting.cpp:
2914         (WebCore::canHaveChildrenForEditing): Added checks for input elements
2915         and textareas.  Insertion operations would fail when performed just 
2916         before/after one of these elements b/c the content would be put inside 
2917         the element.
2918         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
2919         editable content, and made the code to stop at an root faster (don't check
2920         isDescendantOf on every iteration).
2921         (WebCore::enclosingNodeOfType): Ditto.
2922         (WebCore::enclosingList): Ditto.
2923         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
2924         inappropriately named.
2925         * editing/markup.cpp:
2926         (WebCore::startMarkup): Use the text node's value instead of its rendered
2927         content for text nodes inside select elements.  One might also turn off
2928         annotation when createMarkup enters a select element, but createMarkup
2929         is iterative, not recursive, so doing so would be complicated.
2930         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
2931         descendants of a select element.
2932         * editing/visible_units.cpp:
2933         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
2934         where various replaced elements can't be copied when they are the only
2935         thing selected.
2936         (WebCore::endOfParagraph): Ditto.
2937
2938 2006-11-01  Oliver Hunt  <oliver@apple.com>
2939
2940         Reviewed by Adam.
2941
2942         Converting more or kcanvas/quartz from Obj-C to C++
2943         Minor SVG updates
2944         compatibility fixes
2945
2946         * WebCore.xcodeproj/project.pbxproj:
2947         * kcanvas/device/KRenderingPaintServer.h:
2948         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
2949         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2950         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
2951         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
2952         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
2953         * kcanvas/device/quartz/QuartzSupport.h:
2954         * ksvg2/css/SVGCSSStyleSelector.cpp:
2955         * ksvg2/misc/KCanvasRenderingStyle.h:
2956         * ksvg2/scripts/cssmakeprops:
2957         * ksvg2/scripts/cssmakevalues:
2958         * ksvg2/scripts/make_names.pl:
2959         * ksvg2/svg/SVGAnimateColorElement.cpp:
2960         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2961         * ksvg2/svg/SVGAnimationElement.cpp:
2962         * ksvg2/svg/SVGMaskElement.cpp:
2963         * ksvg2/svg/SVGPatternElement.cpp:
2964         * ksvg2/svg/svgpathparser.cpp:
2965         * platform/Path.cpp:
2966         * platform/graphics/svg/SVGResourceImage.h:
2967         * rendering/RenderPath.cpp:
2968         * rendering/SVGRenderAsText.cpp:
2969
2970 2006-11-02  Mitz Pettel  <mitz@webkit.org>
2971
2972         Reviewed by Adele.
2973
2974         - Fix a regression from r17521: painting of and crash caused by tables
2975           with collapsed borders
2976
2977         * rendering/RenderTable.cpp:
2978         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
2979         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
2980         and 'paintInfo' is the parameter, which we were accidently modifying.
2981
2982 2006-11-01  Adele Peterson  <adele@apple.com>
2983
2984         Reviewed by Mitz.
2985
2986         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
2987         REGRESSION: Incomplete repaint of overflow areas when deleting
2988
2989         Restrict the repaint rect for overflow blocks after the height has been fully computed.
2990         Also, adjust the repaint rect coordinates for the scroll offset.
2991
2992         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
2993         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
2994
2995 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
2996
2997         Reviewed by Mitz.
2998
2999         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
3000         Rename the "p" member variable of the PaintInfo struct to "context"
3001
3002         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
3003           'context' and 'rect' respectively.
3004
3005         - Assorted surrounding cleanups.
3006
3007         * rendering/EllipsisBox.cpp:
3008         (WebCore::EllipsisBox::paint):
3009         * rendering/EllipsisBox.h:
3010         * rendering/InlineBox.cpp:
3011         (WebCore::InlineBox::paint):
3012         * rendering/InlineFlowBox.cpp:
3013         (WebCore::InlineFlowBox::paint):
3014         (WebCore::InlineFlowBox::paintBackground):
3015         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3016         (WebCore::InlineFlowBox::paintDecorations):
3017         * rendering/InlineFlowBox.h:
3018         * rendering/InlineRunBox.h:
3019         * rendering/InlineTextBox.cpp:
3020         (WebCore::InlineTextBox::paint):
3021         * rendering/InlineTextBox.h:
3022         * rendering/RenderBlock.cpp:
3023         (WebCore::RenderBlock::paint):
3024         (WebCore::RenderBlock::paintChildren):
3025         (WebCore::RenderBlock::paintCaret):
3026         (WebCore::RenderBlock::paintObject):
3027         (WebCore::RenderBlock::paintFloats):
3028         (WebCore::RenderBlock::paintEllipsisBoxes):
3029         (WebCore::RenderBlock::paintSelection):
3030         (WebCore::RenderBlock::fillSelectionGaps):
3031         (WebCore::RenderBlock::fillInlineSelectionGaps):
3032         (WebCore::RenderBlock::fillBlockSelectionGaps):
3033         (WebCore::RenderBlock::fillHorizontalSelectionGap):
3034         (WebCore::RenderBlock::fillVerticalSelectionGap):
3035         (WebCore::RenderBlock::fillLeftSelectionGap):
3036         (WebCore::RenderBlock::fillRightSelectionGap):
3037         * rendering/RenderBox.cpp:
3038         (WebCore::RenderBox::paint):
3039         (WebCore::RenderBox::paintRootBoxDecorations):
3040         (WebCore::RenderBox::paintBoxDecorations):
3041         * rendering/RenderBox.h:
3042         * rendering/RenderButton.cpp:
3043         (WebCore::RenderButton::paintObject):
3044         * rendering/RenderFieldset.cpp:
3045         (WebCore::RenderFieldset::paintBoxDecorations):
3046         * rendering/RenderFileUploadControl.cpp:
3047         (WebCore::RenderFileUploadControl::paintObject):
3048         * rendering/RenderFlow.cpp:
3049         (WebCore::RenderFlow::continuationBefore):
3050         (WebCore::RenderFlow::addChildWithContinuation):
3051         (WebCore::RenderFlow::addChild):
3052         (WebCore::RenderFlow::attachLineBox):
3053         (WebCore::RenderFlow::destroy):
3054         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
3055         (WebCore::RenderFlow::dirtyLineBoxes):
3056         (WebCore::RenderFlow::createInlineBox):
3057         (WebCore::RenderFlow::paintLines):
3058         (WebCore::RenderFlow::getAbsoluteRepaintRect):
3059         (WebCore::RenderFlow::lowestPosition):
3060         (WebCore::RenderFlow::rightmostPosition):
3061         (WebCore::RenderFlow::leftmostPosition):
3062         (WebCore::RenderFlow::caretRect):
3063         (WebCore::RenderFlow::addFocusRingRects):
3064         (WebCore::RenderFlow::paintOutline):
3065         (WebCore::RenderFlow::paintOutlineForLine):
3066         * rendering/RenderForeignObject.cpp:
3067         (WebCore::RenderForeignObject::paint):
3068         * rendering/RenderHTMLCanvas.cpp:
3069         (WebCore::RenderHTMLCanvas::paint):
3070         * rendering/RenderImage.cpp:
3071         (WebCore::RenderImage::paint):
3072         * rendering/RenderLayer.cpp:
3073         (WebCore::RenderLayer::paintLayer):
3074         * rendering/RenderListBox.cpp:
3075         (WebCore::RenderListBox::paintObject):
3076         (WebCore::RenderListBox::paintScrollbar):
3077         (WebCore::RenderListBox::paintItemForeground):
3078         (WebCore::RenderListBox::paintItemBackground):
3079         * rendering/RenderListMarker.cpp:
3080         (WebCore::RenderListMarker::paint):
3081         * rendering/RenderMenuList.cpp:
3082         (WebCore::RenderMenuList::paintObject):
3083         * rendering/RenderObject.cpp:
3084         (WebCore::RenderObject::paint):
3085         * rendering/RenderObject.h:
3086         (WebCore::RenderObject::PaintInfo::PaintInfo):
3087         (WebCore::RenderObject::paintBoxDecorations):
3088         (WebCore::RenderObject::paintingRootForChildren):
3089         (WebCore::RenderObject::shouldPaintWithinRoot):
3090         (WebCore::RenderObject::printBoxDecorations):
3091         * rendering/RenderPath.cpp:
3092         (WebCore::RenderPath::paint):
3093         * rendering/RenderReplaced.cpp:
3094         (WebCore::RenderReplaced::shouldPaint):
3095         * rendering/RenderSVGContainer.cpp:
3096         (WebCore::RenderSVGContainer::paint):
3097         * rendering/RenderSVGContainer.h:
3098         * rendering/RenderSVGImage.cpp:
3099         (WebCore::RenderSVGImage::paint):
3100         * rendering/RenderSVGText.cpp:
3101         (WebCore::RenderSVGText::paint):
3102         * rendering/RenderSVGText.h:
3103         (WebCore::RenderSVGText::renderName):
3104         * rendering/RenderTable.cpp:
3105         (WebCore::RenderTable::paint):
3106         (WebCore::RenderTable::paintBoxDecorations):
3107         * rendering/RenderTable.h:
3108         * rendering/RenderTableCell.cpp:
3109         (WebCore::RenderTableCell::paint):
3110         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3111         (WebCore::RenderTableCell::paintBoxDecorations):
3112         * rendering/RenderTableCell.h:
3113         * rendering/RenderTableRow.cpp:
3114         (WebCore::RenderTableRow::paint):
3115         * rendering/RenderTableRow.h:
3116         * rendering/RenderTableSection.cpp:
3117         (WebCore::RenderTableSection::paint):
3118         * rendering/RenderTableSection.h:
3119         (WebCore::RenderTableSection::getBaseline):
3120         (WebCore::RenderTableSection::setNeedCellRecalc):
3121         * rendering/RenderText.h:
3122         (WebCore::RenderText::renderName):
3123         (WebCore::RenderText::paint):
3124         (WebCore::RenderText::element):
3125         * rendering/RenderTheme.cpp:
3126         (WebCore::RenderTheme::paint):
3127         (WebCore::RenderTheme::paintBorderOnly):
3128         (WebCore::RenderTheme::paintDecorations):
3129         * rendering/RenderTheme.h:
3130         (WebCore::RenderTheme::RenderTheme):
3131         (WebCore::RenderTheme::~RenderTheme):
3132         (WebCore::RenderTheme::controlSupportsTints):
3133         (WebCore::RenderTheme::adjustRepaintRect):
3134         (WebCore::RenderTheme::themeChanged):
3135         (WebCore::RenderTheme::supportsHover):
3136         (WebCore::RenderTheme::paintCheckbox):
3137         (WebCore::RenderTheme::setCheckboxSize):
3138         (WebCore::RenderTheme::paintRadio):
3139         (WebCore::RenderTheme::setRadioSize):
3140         (WebCore::RenderTheme::paintButton):
3141         (WebCore::RenderTheme::setButtonSize):
3142         (WebCore::RenderTheme::paintTextField):
3143         (WebCore::RenderTheme::paintTextArea):
3144         (WebCore::RenderTheme::paintMenuList):
3145         (WebCore::RenderTheme::paintMenuListButton):
3146         * rendering/RenderThemeMac.mm:
3147         (WebCore::RenderThemeMac::paintCheckbox):
3148         (WebCore::RenderThemeMac::paintRadio):
3149         (WebCore::RenderThemeMac::paintButton):
3150         (WebCore::RenderThemeMac::paintTextField):
3151         (WebCore::RenderThemeMac::paintTextArea):
3152         (WebCore::RenderThemeMac::paintMenuList):
3153         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
3154         (WebCore::RenderThemeMac::paintMenuListButton):
3155         * rendering/RenderView.cpp:
3156         (WebCore::RenderView::paint):
3157         (WebCore::RenderView::paintBoxDecorations):
3158         * rendering/RenderView.h:
3159         * rendering/RenderWidget.cpp:
3160         (WebCore::RenderWidget::paint):
3161         * rendering/RenderWidget.h:
3162         (WebCore::RenderWidget::isWidget):
3163         * rendering/RootInlineBox.cpp:
3164         (WebCore::RootInlineBox::paintEllipsisBox):
3165         (WebCore::RootInlineBox::paintCustomHighlight):
3166         (WebCore::RootInlineBox::paint):
3167         (WebCore::RootInlineBox::fillLineSelectionGap):
3168         * rendering/RootInlineBox.h:
3169         * rendering/SVGInlineFlowBox.cpp:
3170         (WebCore::paintSVGInlineFlow):
3171
3172 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
3173
3174         Reviewed by Oliver, Brady.
3175
3176         * platform/network/ResourceResponse.h:
3177         (WebCore::ResourceResponse::setLastModifiedDate):
3178         (WebCore::ResourceResponse::lastModifiedDate):
3179         Add getters and setters for last modified dadte.
3180         
3181         * platform/network/cf/ResourceResponseCFNet.cpp:
3182         (WebCore::getResourceResponse):
3183         Fetch the last modified date. Add correct offset to expired date.
3184
3185 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
3186
3187         Reviewed by Mitz.
3188
3189         Added missing "break;" statement in switch statement from r17493.
3190
3191         Bug 11442: [CSS 3] support for cursor: all-scroll
3192         http://bugs.webkit.org/show_bug.cgi?id=11442
3193
3194         * css/CSSComputedStyleDeclaration.cpp:
3195         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3196
3197 2006-10-31  Mitz Pettel  <mitz@webkit.org>
3198
3199         Reviewed by Maciej.
3200
3201         - fix image dragging
3202
3203         This is covered by editing/selection/drag-to-contenteditable-iframe.html
3204
3205         * rendering/HitTestResult.cpp:
3206         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
3207         HTML IMG elements.
3208         (WebCore::HitTestResult::absoluteImageURL): Ditto.
3209
3210 2006-10-31  Beth Dakin  <bdakin@apple.com>
3211
3212         Reviewed by Maciej.
3213
3214         This adds the back-end of the remaining WebElementDictionary 
3215         functions into HitTestResult.
3216
3217         * WebCore.exp:
3218         * rendering/HitTestResult.cpp:
3219         (WebCore::HitTestResult::title):
3220         (WebCore::displayString): This is nearly identical to the 
3221         displayString() defined in DOMInternal.mm except that it returns a 
3222         String instead of an NSString. The old code path used the 
3223         DOMInternal method, so I made a new one here for the new code path.
3224         (WebCore::HitTestResult::altDisplayString):
3225         (WebCore::HitTestResult::image):
3226         (WebCore::HitTestResult::absoluteImageURL):
3227         (WebCore::HitTestResult::absoluteLinkURL):
3228         (WebCore::HitTestResult::titleDisplayString):
3229         (WebCore::HitTestResult::textContent):
3230         * rendering/HitTestResult.h:
3231
3232 2006-10-31  John Sullivan  <sullivan@apple.com>
3233
3234         * bridge/mac/FrameMac.mm:
3235         (WebCore::FrameMac::markMisspellings):
3236         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
3237
3238 2006-10-31  John Sullivan  <sullivan@apple.com>
3239
3240         Reviewed by Maciej
3241         
3242         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
3243         
3244         The foundation of this was in my last checkin. This checkin is all about displaying
3245         the correct string in the toolTip.
3246
3247         * dom/DocumentMarker.h:
3248         New description field in this struct.
3249
3250         * bridge/mac/FrameMac.mm:
3251         (WebCore::FrameMac::advanceToNextMisspelling):
3252         When adding a grammar marker, supply the appropriate description. Also, added a comment
3253         about the remaining work to make grammar checking return sensible answers.
3254         (WebCore::FrameMac::markMisspellings):
3255         ditto (yes, still needs some refactoring to minimize duplicated code)
3256         
3257         * dom/Document.h:
3258         * dom/Document.cpp:
3259         (WebCore::Document::addMarker):
3260         Now takes an optional description string
3261         (WebCore::Document::markerContainingPoint):
3262         New function, returns a pointer to the (first) marker of the specified type whose rect 
3263         contains the specified point, or 0 if none.
3264         
3265         * rendering/HitTestResult.cpp:
3266         (WebCore::HitTestResult::spellingToolTip):
3267         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
3268         and gets the description from the marker.
3269
3270 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3271
3272         Reviewed by Maciej.
3273         
3274         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
3275
3276         * loader/mac/FrameLoaderMac.mm:
3277         (WebCore::FrameLoader::createWindow):
3278         * manual-tests/window-open-features-parsing.html: Updated for clarity.
3279
3280 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
3281
3282         Reviewed by Alice.
3283
3284         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
3285         to WebCore::Editor.
3286         
3287         Layout tests pass.
3288         
3289         Renamed "may*" to "can*" because "can" is more accurate (these functions
3290         aren't just about permission) and it matches WebKit.
3291
3292         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
3293         password field. Now that WebCore fully implements canCopy(), it doesn't just
3294         mean "the selection is not in a password field" anymore.
3295         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
3296         The fact that it's not called anymore may represent a security issue, but I
3297         don't see how commented-out code will help reveal the issue, and the
3298         bridge is going away, anyway.
3299         * editing/SelectionController.h: Changed selection() calls to references
3300         to m_sel, to match the rest of the file.
3301
3302 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
3303
3304         Reviewed by harrison
3305         
3306         <rdar://problem/4711063>
3307         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
3308
3309         * editing/ReplaceSelectionCommand.cpp:
3310         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
3311         insertion and plain text string creation unless we need the string
3312         for a BeforeTextInserted event handler or for a plain text only region.
3313         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
3314         code here from ReplacementFragment's constructor.
3315         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
3316         FIXME.
3317         * editing/ReplaceSelectionCommand.h:
3318
3319 2006-10-31  Ada Chan  <adachan@apple.com>
3320
3321         Reviewed by Adam
3322
3323         Correct forward declarations of the HitTestRequest struct.
3324
3325         * rendering/EllipsisBox.h:
3326         * rendering/InlineBox.h:
3327         * rendering/InlineFlowBox.h:
3328         * rendering/RenderLayer.h:
3329         * rendering/RenderObject.h:
3330
3331 2006-10-31  John Sullivan  <sullivan@apple.com>
3332
3333         Reviewed by Beth and Adam
3334
3335         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
3336         next I'll make it use a string that's relevant for a specific grammar error.
3337
3338         * WebCore.exp:
3339         export symbol for spellingToolTip function
3340         
3341         * rendering/HitTestResult.h:
3342         * rendering/HitTestResult.cpp:
3343         (WebCore::HitTestResult::spellingToolTip):
3344         new function, returns the string to be used in a tool tip that describes the questionable grammar
3345         
3346         * rendering/InlineTextBox.h:
3347         * rendering/InlineTextBox.cpp:
3348         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3349         now takes a style and font, needed to compute the rect representing the range containing
3350         questionable grammar. Computes the rect and associates it with the marker.
3351         (WebCore::InlineTextBox::paintDocumentMarkers):
3352         Pass in the style and font now needed by paintSpellingOrGrammarMarker
3353
3354 2006-10-31  Adele Peterson  <adele@apple.com>
3355
3356         Removed commented out variable from last checkin.
3357
3358         * html/HTMLSelectElement.cpp:
3359         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3360
3361 2006-10-31  Brady Eidson  <beidson@apple.com>
3362
3363         Build fix (unused variable in release builds)
3364
3365         * html/HTMLSelectElement.cpp:
3366         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3367
3368 2006-10-31  Adele Peterson  <adele@apple.com>
3369
3370         Reviewed by Adam.
3371
3372         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
3373         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
3374         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
3375
3376         Tests: 
3377         * LayoutTests/fast/forms/listbox-selection.html
3378         * LayoutTests/fast/forms/listbox-onchange.html
3379
3380         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
3381           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
3382           And one for onChange, that is updated after onChange is fired.
3383           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
3384  
3385         * html/HTMLSelectElement.cpp:
3386         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
3387         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
3388         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
3389         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
3390         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
3391         (WebCore::HTMLSelectElement::setExtent): Added.
3392         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
3393         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
3394
3395         * rendering/RenderListBox.cpp:
3396         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
3397         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
3398         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
3399         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
3400          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
3401          notify the select element from here.
3402         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
3403         (WebCore::RenderListBox::listIndexIsVisible): Added.
3404         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
3405
3406         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
3407         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
3408         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
3409         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
3410         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
3411
3412 2006-10-31  Beth Dakin  <bdakin@apple.com>
3413
3414         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
3415
3416         * rendering/HitTestRequest.h: Added.
3417         (WebCore::HitTestRequest::HitTestRequest):
3418
3419 2006-10-31  Beth Dakin  <bdakin@apple.com>
3420
3421         Reviewed by Maciej.
3422
3423         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
3424         should be split into HitTestRequest and HitTestResult
3425
3426         This patch creates a new struct called HitTestRequest that holds 
3427         the three boolean values (readonly, active, and mouseMove) that 
3428         were formerly a part of HitTestResult. All hitTest() and 
3429         nodeAtPoint() functions now take a HitTestRequest in addition to 
3430         the HitTestResult.
3431
3432         * WebCore.exp:
3433         * WebCore.xcodeproj/project.pbxproj:
3434         * bridge/mac/FrameMac.mm:
3435         (WebCore::FrameMac::eventMayStartDrag):
3436         (WebCore::FrameMac::handleMouseMoveEvent):
3437         * bridge/mac/WebCoreAXObject.mm:
3438         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
3439         (-[WebCoreAXObject accessibilityHitTest:]):
3440         * dom/Document.cpp:
3441         (WebCore::Document::elementFromPoint):
3442         (WebCore::Document::prepareMouseEvent):
3443         * editing/SelectionController.cpp:
3444         (WebCore::SelectionController::contains):
3445         * page/Frame.cpp:
3446         (WebCore::Frame::hitTestResultAtPoint):
3447         * page/FrameView.cpp:
3448         (WebCore::FrameView::handleWheelEvent):
3449         * rendering/EllipsisBox.cpp:
3450         (WebCore::EllipsisBox::nodeAtPoint):
3451         * rendering/EllipsisBox.h:
3452         * rendering/HitTestResult.cpp:
3453         (WebCore::HitTestResult::HitTestResult):
3454         (WebCore::HitTestResult::operator=):
3455         * rendering/HitTestResult.h:
3456         * rendering/InlineBox.cpp:
3457         (WebCore::InlineBox::nodeAtPoint):
3458         * rendering/InlineBox.h:
3459         * rendering/InlineFlowBox.cpp:
3460         (WebCore::InlineFlowBox::nodeAtPoint):
3461         * rendering/InlineFlowBox.h:
3462         * rendering/InlineTextBox.cpp:
3463         (WebCore::InlineTextBox::nodeAtPoint):
3464         * rendering/InlineTextBox.h:
3465         * rendering/RenderBlock.cpp:
3466         (WebCore::RenderBlock::nodeAtPoint):
3467         * rendering/RenderBlock.h:
3468         * rendering/RenderBox.cpp:
3469         (WebCore::RenderBox::nodeAtPoint):
3470         * rendering/RenderBox.h:
3471         * rendering/RenderFlow.cpp:
3472         (WebCore::RenderFlow::hitTestLines):
3473         * rendering/RenderFlow.h:
3474         * rendering/RenderForeignObject.cpp:
3475         (WebCore::RenderForeignObject::nodeAtPoint):
3476         * rendering/RenderForeignObject.h:
3477         * rendering/RenderFrameSet.cpp:
3478         (WebCore::RenderFrameSet::nodeAtPoint):
3479         * rendering/RenderFrameSet.h:
3480         * rendering/RenderImage.cpp:
3481         (WebCore::RenderImage::nodeAtPoint):
3482         * rendering/RenderImage.h:
3483         * rendering/RenderInline.cpp:
3484         (WebCore::RenderInline::nodeAtPoint):
3485         * rendering/RenderInline.h:
3486         * rendering/RenderLayer.cpp:
3487         (WebCore::RenderLayer::autoscroll):
3488         (WebCore::RenderLayer::hitTest):
3489         (WebCore::RenderLayer::hitTestLayer):
3490         (WebCore::RenderLayer::updateHoverActiveState):
3491         * rendering/RenderLayer.h:
3492         * rendering/RenderObject.cpp:
3493         (WebCore::RenderObject::hitTest):
3494         (WebCore::RenderObject::nodeAtPoint):
3495         * rendering/RenderObject.h:
3496         * rendering/RenderPath.cpp:
3497         (WebCore::RenderPath::nodeAtPoint):
3498         * rendering/RenderPath.h:
3499         * rendering/RenderSVGImage.cpp:
3500         (WebCore::RenderSVGImage::nodeAtPoint):
3501         * rendering/RenderSVGImage.h:
3502         * rendering/RenderSVGText.cpp:
3503         (WebCore::RenderSVGText::nodeAtPoint):
3504         * rendering/RenderSVGText.h:
3505         * rendering/RenderTableRow.cpp:
3506         (WebCore::RenderTableRow::nodeAtPoint):
3507         * rendering/RenderTableRow.h:
3508         * rendering/RenderTableSection.cpp:
3509         (WebCore::RenderTableSection::nodeAtPoint):
3510         * rendering/RenderTableSection.h:
3511         * rendering/RenderText.h:
3512         (WebCore::RenderText::nodeAtPoint):
3513         * rendering/RenderTextControl.cpp:
3514         (WebCore::RenderTextControl::nodeAtPoint):
3515         * rendering/RenderTextControl.h:
3516         * rendering/RootInlineBox.cpp:
3517         (WebCore::RootInlineBox::nodeAtPoint):
3518         * rendering/RootInlineBox.h:
3519
3520 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
3521
3522         Reviewed by Maciej.
3523
3524         Bug 11442: [CSS 3] support for cursor: all-scroll
3525         http://bugs.webkit.org/show_bug.cgi?id=11442
3526
3527         * css/CSSComputedStyleDeclaration.cpp:
3528         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3529         * css/CSSValueKeywords.in:
3530         * css/cssparser.cpp:
3531         (WebCore::CSSParser::parseValue):
3532         * page/FrameView.cpp:
3533         (WebCore::selectCursor):
3534         * rendering/RenderStyle.h:
3535
3536 2006-10-31  Oliver Hunt  <oliver@apple.com>
3537
3538         Reviewed by Geoff.
3539
3540         Converting Obj-C++ to C++ in kcanvas
3541
3542         * WebCore.xcodeproj/project.pbxproj:
3543         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3544         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3545         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
3546         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
3547         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
3548         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3549         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
3550         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3551         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3552         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
3553         * kcanvas/device/quartz/QuartzSupport.h:
3554         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
3555         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
3556         (WebCore::SVGResourceClipper::applyClip):
3557         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
3558         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
3559         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
3560
3561 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
3562
3563         Reviewed by harrison
3564         
3565         <rdar://problem/4808375>
3566         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
3567         
3568         Completely back out r17276 because of performance issues.
3569
3570         * editing/TextIterator.cpp:
3571         (WebCore::TextIterator::TextIterator):
3572         (WebCore::TextIterator::advance):
3573         (WebCore::TextIterator::handleTextNode):
3574         (WebCore::TextIterator::handleTextBox):
3575         (WebCore::TextIterator::handleReplacedElement):
3576         (WebCore::TextIterator::handleNonTextNode):
3577         (WebCore::TextIterator::exitNode):
3578         (WebCore::TextIterator::emitCharacter):
3579         (WebCore::TextIterator::range):
3580         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
3581         (WebCore::SimplifiedBackwardsTextIterator::advance):
3582         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
3583         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
3584         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
3585         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
3586         (WebCore::SimplifiedBackwardsTextIterator::range):
3587         (WebCore::CharacterIterator::range):
3588         (WebCore::TextIterator::rangeFromLocationAndLength):
3589         * editing/TextIterator.h:
3590         (WebCore::TextIterator::atEnd):
3591         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
3592
3593 2006-10-31  Darin Adler  <darin@apple.com>
3594
3595         Reviewed by Brady.
3596
3597         - got "action dictionary" code out of FrameLoader,
3598           replacing with a class called NavigationAction
3599
3600         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
3601         * loader/mac/DocumentLoaderMac.mm:
3602         (WebCore::DocumentLoader::triggeringAction): Ditto.
3603         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
3604
3605         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
3606
3607         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
3608         Removed elementForEvent.
3609         * loader/mac/FrameLoaderMac.mm:
3610         (WebCore::FrameLoader::load): Ditto.
3611         (WebCore::FrameLoader::reload): Ditto.
3612         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
3613         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
3614         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
3615         (WebCore::FrameLoader::post): Ditto.
3616
3617         * loader/NavigationAction.h: Added.
3618         * loader/NavigationAction.cpp: Added.
3619         * loader/mac/NavigationActionMac.mm: Added.
3620
3621         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
3622
3623         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
3624         * WebCore.exp: Updated.
3625
3626 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
3627
3628         Reviewed by Adam.
3629
3630         Build fix
3631
3632         * platform/win/CookieJarWin.cpp:
3633         (WebCore::cookies):
3634
3635 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
3636
3637         Reviewed by Maciej. Landed by Adam.
3638
3639         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
3640
3641         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
3642         as dicussed with Dave. Also kill the outdated DESIGN document.
3643
3644         * CMakeLists.txt:
3645         * WebCore.xcodeproj/project.pbxproj:
3646         * kcanvas/DESIGN: Removed.
3647         * kcanvas/KCanvasFilters.cpp:
3648         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
3649         * kcanvas/KCanvasTreeDebug.h: Ditto.
3650         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3651         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3652         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3653         * platform/graphics/svg/SVGResourceClipper.cpp:
3654         * rendering/RenderTreeAsText.cpp:
3655         * rendering/SVGRenderTreeAsText.cpp: Added.
3656         * rendering/SVGRenderTreeAsText.h: Added.
3657         (WebCore::operator<<):
3658
3659 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
3660
3661         Reviewed by Maciej.
3662
3663         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
3664         Includes some CRLF -> LF fixups.
3665
3666         * platform/win/CookieJarWin.cpp:
3667         (WebCore::cookies):
3668
3669 2006-10-31  Adam Roben  <aroben@apple.com>
3670
3671         Reviewed by Steve.
3672
3673         Fix some incorrect forward declarations.
3674
3675         * loader/FrameLoader.h:
3676         * page/Frame.h:
3677
3678 2006-10-31  Darin Adler  <darin@apple.com>
3679
3680         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
3681         try to fix the build on the buildbot.
3682
3683 2006-10-31  Darin Adler  <darin@apple.com>
3684
3685         * bridge/mac/FrameMac.mm:
3686         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
3687         (WebCore::FrameMac::markMisspellings): Ditto.
3688
3689 2006-10-31  John Sullivan  <sullivan@apple.com>
3690
3691         * bridge/mac/FrameMac.mm:
3692         (WebCore::FrameMac::advanceToNextMisspelling):
3693         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
3694
3695 2006-10-30  John Sullivan  <sullivan@apple.com>
3696
3697         Reviewed by Adam Roben
3698         
3699         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
3700         
3701         This patch introduces much of the guts of grammar checking, though still not enough to actually
3702         check grammar sensibly, due to:
3703           
3704         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
3705         context passed to grammar checker
3706
3707         * platform/Logging.h:
3708         * platform/Logging.cpp:
3709         new log channel SpellingAndGrammar
3710
3711         * bridge/mac/WebCorePageBridge.mm:
3712         (initializeLoggingChannelsIfNecessary):
3713         initialize new log channel
3714
3715         * bridge/mac/FrameMac.mm:
3716         (WebCore::FrameMac::advanceToNextMisspelling):
3717         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
3718         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
3719         in the event of a tie), and do further processing with that one (select range; create marker that
3720         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
3721         (WebCore::FrameMac::markMisspellings):
3722         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
3723         differently enough to make sharing code between these two functions a little tricky, so I decided to 
3724         save that for a later patch.
3725         
3726         (WebCore::FrameMac::respondToChangedSelection):
3727         remove grammar markers when we remove spelling markers        
3728
3729 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
3730
3731         Reviewed by Mitz.
3732
3733         Fix Qt/Linux build with older gcc3.3.4.
3734
3735         * bindings/js/kjs_window.cpp:
3736         (KJS::WindowFunc::callAsFunction):
3737
3738 2006-10-31  Zack Rusin  <zack@kde.org>
3739
3740         Reviewed by Mitz.
3741
3742         Fix the Qt build after last nights changes.
3743
3744         * WebCore/platform/qt/FrameQt.cpp:
3745         * WebCore/platform/qt/EditorClientQt.h:
3746         * WebCore/platform/qt/EditorClientQt.cpp:
3747         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
3748         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
3749         * WebCore/CMakeLists.txt:
3750         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
3751         * WebKitQt/QtLauncher/CMakeLists.txt:
3752         * WebKitQt/WebKitPart/CMakeLists.txt:
3753
3754 2006-10-30  Darin Adler  <darin@apple.com>
3755
3756         Reviewed by Anders.
3757
3758         - remove BrowserExtension
3759
3760         * WebCore.vcproj/WebCore/WebCore.vcproj:
3761         * WebCore.xcodeproj/project.pbxproj:
3762         * bindings/js/kjs_window.cpp:
3763         (KJS::createNewWindow):
3764         (KJS::WindowFunc::callAsFunction):
3765         * bridge/BrowserExtension.h: Removed.
3766         * bridge/mac/BrowserExtensionMac.h: Removed.
3767         * bridge/mac/BrowserExtensionMac.mm: Removed.
3768         * bridge/mac/FrameMac.mm:
3769         (WebCore::FrameMac::FrameMac):
3770         (WebCore::FrameMac::submitForm):
3771         (WebCore::FrameMac::urlSelected):
3772         * bridge/win/BrowserExtensionWin.cpp: Removed.
3773         * bridge/win/BrowserExtensionWin.h: Removed.
3774         * bridge/win/FrameWin.cpp:
3775         (WebCore::FrameWin::FrameWin):
3776         * loader/FrameLoader.cpp:
3777         (WebCore::FrameLoader::createWindow):
3778         * loader/FrameLoader.h:
3779         * loader/icon/IconLoader.cpp:
3780         * loader/mac/FrameLoaderMac.mm:
3781         (WebCore::FrameLoader::safeLoad):
3782         (WebCore::FrameLoader::load):
3783         (WebCore::FrameLoader::createWindow):
3784         * page/Frame.cpp:
3785         (WebCore::Frame::urlSelected):
3786         (WebCore::Frame::requestFrame):
3787         (WebCore::Frame::submitForm):
3788         (WebCore::Frame::scheduleHistoryNavigation):
3789         (WebCore::Frame::redirectionTimerFired):
3790         * page/Frame.h:
3791         * page/FrameLoadRequest.h:
3792         (WebCore::FrameLoadRequest::FrameLoadRequest):
3793         (WebCore::FrameLoadRequest::isEmpty):
3794         (WebCore::FrameLoadRequest::resourceRequest):
3795         (WebCore::FrameLoadRequest::frameName):
3796         (WebCore::FrameLoadRequest::setFrameName):
3797         * page/FramePrivate.h:
3798         (WebCore::FramePrivate::FramePrivate):
3799         (WebCore::FramePrivate::~FramePrivate):
3800         * platform/gdk/BrowserExtensionGdk.h: Removed.
3801         * platform/gdk/FrameGdk.cpp:
3802         (WebCore::FrameGdk::FrameGdk):
3803         * platform/gdk/TemporaryLinkStubs.cpp:
3804         * platform/network/ResourceRequest.h:
3805         (WebCore::ResourceRequest::isEmpty):
3806
3807 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
3808
3809         Reviewed by Oliver.
3810
3811         Modified from original due to earlier reversion
3812
3813         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
3814
3815         Better SVG integration in WebKit, Part I.
3816
3817         The patch is mostly about creating a new platform/graphics directory, and
3818         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
3819         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
3820         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
3821
3822         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
3823         All details of the patch, and upcoming patches can be found in the bug report.
3824
3825         * CMakeLists.txt:
3826         * WebCore.xcodeproj/project.pbxproj:
3827         * graphics/svg/SVGResource.cpp: Removed.
3828         * graphics/svg/SVGResourceClipper.cpp: Removed.
3829         * graphics/svg/SVGResourceClipper.h: Removed.
3830         * graphics/svg/SVGResourceImage.h: Removed.
3831         * graphics/svg/SVGResourceListener.h: Removed.
3832         * graphics/svg/SVGResourceMarker.cpp: Removed.
3833         * graphics/svg/SVGResourceMarker.h: Removed.
3834         * graphics/svg/SVGResourceMasker.cpp: Removed.
3835         * graphics/svg/SVGResourceMasker.h: Removed.
3836         * kcanvas/KCanvasClipper.cpp: Removed.
3837         * kcanvas/KCanvasClipper.h: Removed.
3838         * kcanvas/KCanvasCreator.cpp: Removed.
3839         * kcanvas/KCanvasCreator.h: Removed.
3840         * kcanvas/KCanvasFilters.cpp:
3841         (WebCore::getFilterById):
3842         * kcanvas/KCanvasFilters.h:
3843         * kcanvas/KCanvasImage.h: Removed.
3844         * kcanvas/KCanvasMarker.cpp: Removed.
3845         * kcanvas/KCanvasMarker.h: Removed.
3846         * kcanvas/KCanvasMasker.cpp: Removed.
3847         * kcanvas/KCanvasMasker.h: Removed.
3848         * kcanvas/KCanvasResource.cpp: Removed.
3849         * kcanvas/KCanvasResource.h: Removed.
3850         * kcanvas/KCanvasResourceListener.h: Removed.
3851         * kcanvas/KCanvasTreeDebug.cpp:
3852         (WebCore::writeRenderResources):
3853         * kcanvas/device/KRenderingDevice.h:
3854         * kcanvas/device/KRenderingPaintServer.h:
3855         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
3856         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3857         (WebCore::KRenderingPaintServerGradient::listener):
3858         (WebCore::KRenderingPaintServerGradient::setListener):
3859         * kcanvas/device/KRenderingPaintServerGradient.h:
3860         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3861         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3862         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3863         (WebCore::KRenderingPaintServerPattern::tile):
3864         (WebCore::KRenderingPaintServerPattern::setTile):
3865         (WebCore::KRenderingPaintServerPattern::listener):
3866         (WebCore::KRenderingPaintServerPattern::setListener):
3867         * kcanvas/device/KRenderingPaintServerPattern.h:
3868         * kcanvas/device/KRenderingPaintServerSolid.h:
3869         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
3870         * kcanvas/device/qt/KCanvasClipperQt.h:
3871         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
3872         (WebCore::KRenderingDeviceQt::contextForImage):
3873         (WebCore::KRenderingDeviceQt::createResource):
3874         (WebCore::KRenderingDeviceQt::createPaintServer):
3875         * kcanvas/device/qt/KRenderingDeviceQt.h:
3876         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
3877         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
3878         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
3879         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
3880         * kcanvas/device/qt/RenderPathQt.h: Removed.
3881         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3882         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
3883         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
3884         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
3885         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
3886         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
3887         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
3888         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3889         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3890         (WebCore::KRenderingDeviceQuartz::contextForImage):
3891         (WebCore::KRenderingDeviceQuartz::createPaintServer):
3892         (WebCore::KRenderingDeviceQuartz::createResource):
3893         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3894         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
3895         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
3896         (WebCore::KRenderingPaintServerGradientQuartz::setup):
3897         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3898         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3899         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3900         (WebCore::patternCallback):
3901         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3902         * kcanvas/device/quartz/QuartzSupport.mm:
3903         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3904         (WebCore::sharedSolidPaintServer):
3905         * ksvg2/svg/SVGClipPathElement.cpp:
3906         (WebCore::SVGClipPathElement::SVGClipPathElement):
3907         (WebCore::SVGClipPathElement::~SVGClipPathElement):
3908         (WebCore::SVGClipPathElement::canvasResource):
3909         * ksvg2/svg/SVGClipPathElement.h:
3910         * ksvg2/svg/SVGFEImageElement.cpp:
3911         * ksvg2/svg/SVGFilterElement.cpp:
3912         (WebCore::SVGFilterElement::SVGFilterElement):
3913         (WebCore::SVGFilterElement::~SVGFilterElement):
3914         (WebCore::SVGFilterElement::canvasResource):
3915         * ksvg2/svg/SVGFilterElement.h:
3916         * ksvg2/svg/SVGGradientElement.cpp:
3917         (WebCore::SVGGradientElement::SVGGradientElement):
3918         (WebCore::SVGGradientElement::~SVGGradientElement):
3919         (WebCore::SVGGradientElement::canvasResource):
3920         (WebCore::SVGGradientElement::resourceNotification):
3921         * ksvg2/svg/SVGGradientElement.h:
3922         * ksvg2/svg/SVGImageElement.cpp:
3923         * ksvg2/svg/SVGLinearGradientElement.cpp:
3924         (WebCore::SVGLinearGradientElement::buildGradient):
3925         * ksvg2/svg/SVGLinearGradientElement.h:
3926         * ksvg2/svg/SVGMarkerElement.cpp:
3927         (WebCore::SVGMarkerElement::SVGMarkerElement):
3928         (WebCore::SVGMarkerElement::~SVGMarkerElement):
3929         (WebCore::SVGMarkerElement::canvasResource):
3930         * ksvg2/svg/SVGMarkerElement.h:
3931         * ksvg2/svg/SVGMaskElement.cpp:
3932         (WebCore::SVGMaskElement::SVGMaskElement):
3933         (WebCore::SVGMaskElement::~SVGMaskElement):
3934         (WebCore::SVGMaskElement::drawMaskerContent):
3935         (WebCore::SVGMaskElement::canvasResource):
3936         * ksvg2/svg/SVGMaskElement.h:
3937         * ksvg2/svg/SVGPatternElement.cpp:
3938         (WebCore::SVGPatternElement::SVGPatternElement):
3939         (WebCore::SVGPatternElement::~SVGPatternElement):
3940         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3941         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3942         (WebCore::SVGPatternElement::canvasResource):
3943         * ksvg2/svg/SVGPatternElement.h:
3944         * ksvg2/svg/SVGRadialGradientElement.cpp:
3945         (WebCore::SVGRadialGradientElement::buildGradient):
3946         * ksvg2/svg/SVGRadialGradientElement.h:
3947         * ksvg2/svg/SVGStyledElement.h:
3948         (WebCore::SVGStyledElement::canvasResource):
3949         * platform/GraphicsContext.cpp: Removed.
3950         * platform/GraphicsContext.h: Removed.
3951         * platform/GraphicsTypes.cpp: Removed.
3952         * platform/GraphicsTypes.h: Removed.
3953         * platform/graphics/GraphicsContext.cpp:
3954         (WebCore::GraphicsContextState::GraphicsContextState):
3955         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
3956         (WebCore::GraphicsContext::createGraphicsContextPrivate):
3957         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
3958         (WebCore::GraphicsContext::save):
3959         (WebCore::GraphicsContext::restore):
3960         (WebCore::GraphicsContext::font):
3961         (WebCore::GraphicsContext::setFont):
3962         (WebCore::GraphicsContext::pen):
3963         (WebCore::GraphicsContext::setPen):
3964         (WebCore::GraphicsContext::setFillColor):
3965         (WebCore::GraphicsContext::fillColor):
3966         (WebCore::GraphicsContext::updatingControlTints):
3967         (WebCore::GraphicsContext::setUpdatingControlTints):
3968         (WebCore::GraphicsContext::setPaintingDisabled):
3969         (WebCore::GraphicsContext::paintingDisabled):
3970         (WebCore::GraphicsContext::drawImage):
3971         (WebCore::GraphicsContext::drawText):
3972         (WebCore::GraphicsContext::drawHighlightForText):
3973         (WebCore::GraphicsContext::initFocusRing):
3974         (WebCore::GraphicsContext::clearFocusRing):
3975         (WebCore::GraphicsContext::focusRingBoundingRect):
3976         (WebCore::GraphicsContext::addFocusRingRect):
3977         (WebCore::GraphicsContext::focusRingWidth):
3978         (WebCore::GraphicsContext::focusRingOffset):
3979         (WebCore::GraphicsContext::focusRingRects):
3980         (WebCore::GraphicsContext::drawTiledImage):
3981         * platform/graphics/GraphicsContext.h:
3982         * platform/graphics/GraphicsTypes.cpp:
3983         (WebCore::):
3984         (WebCore::parseCompositeOperator):
3985         (WebCore::compositeOperatorName):
3986         (WebCore::parseLineCap):
3987         (WebCore::lineCapName):
3988         (WebCore::parseLineJoin):
3989         (WebCore::lineJoinName):
3990         * platform/graphics/GraphicsTypes.h:
3991         (WebCore::):
3992         * platform/graphics/svg/SVGResource.cpp: Added.
3993         (WebCore::SVGResource::SVGResource):
3994         (WebCore::SVGResource::~SVGResource):
3995         (WebCore::SVGResource::invalidate):
3996         (WebCore::SVGResource::addClient):
3997         (WebCore::SVGResource::clients):
3998         (WebCore::SVGResource::idInRegistry):
3999         (WebCore::SVGResource::setIdInRegistry):
4000         (WebCore::SVGResource::externalRepresentation):
4001         (WebCore::getResourceById):
4002         (WebCore::getPaintServerById):
4003         (WebCore::operator<<):
4004         * platform/graphics/svg/SVGResource.h: Added.
4005         (WebCore::):
4006         (WebCore::SVGResource::isPaintServer):
4007         (WebCore::SVGResource::isFilter):
4008         (WebCore::SVGResource::isClipper):
4009         (WebCore::SVGResource::isMarker):
4010         (WebCore::SVGResource::isMasker):
4011         (WebCore::SVGResourceListener::~SVGResourceListener):
4012         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
4013         (WebCore::SVGResourceClipper::SVGResourceClipper):
4014         (WebCore::SVGResourceClipper::~SVGResourceClipper):
4015         (WebCore::SVGResourceClipper::resetClipData):
4016         (WebCore::SVGResourceClipper::addClipData):
4017         (WebCore::SVGResourceClipper::clipData):
4018         (WebCore::SVGResourceClipper::externalRepresentation):
4019         (WebCore::operator<<):
4020         (WebCore::getClipperById):
4021         * platform/graphics/svg/SVGResourceClipper.h: Added.
4022         (WebCore::ClipDataList::addPath):
4023         (WebCore::SVGResourceClipper::isClipper):
4024         * platform/graphics/svg/SVGResourceImage.h: Added.
4025         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
4026         (WebCore::SVGResourceMarker::SVGResourceMarker):
4027         (WebCore::SVGResourceMarker::~SVGResourceMarker):
4028         (WebCore::SVGResourceMarker::setMarker):
4029         (WebCore::SVGResourceMarker::setRef):
4030         (WebCore::SVGResourceMarker::draw):
4031         (WebCore::SVGResourceMarker::externalRepresentation):
4032         (WebCore::getMarkerById):
4033         * platform/graphics/svg/SVGResourceMarker.h: Added.
4034         (WebCore::SVGResourceMarker::refX):
4035         (WebCore::SVGResourceMarker::refY):
4036         (WebCore::SVGResourceMarker::setAngle):
4037         (WebCore::SVGResourceMarker::setAutoAngle):
4038         (WebCore::SVGResourceMarker::angle):
4039         (WebCore::SVGResourceMarker::setUseStrokeWidth):
4040         (WebCore::SVGResourceMarker::useStrokeWidth):
4041         (WebCore::SVGResourceMarker::isMarker):
4042         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
4043         (WebCore::SVGResourceMasker::SVGResourceMasker):
4044         (WebCore::SVGResourceMasker::~SVGResourceMasker):
4045         (WebCore::SVGResourceMasker::setMask):
4046         (WebCore::SVGResourceMasker::mask):
4047         (WebCore::SVGResourceMasker::externalRepresentation):
4048         (WebCore::getMaskerById):
4049         * platform/graphics/svg/SVGResourceMasker.h: Added.
4050         (WebCore::SVGResourceMasker::isMasker):
4051         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
4052         (WebCore::SVGResourceClipper::applyClip):
4053         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
4054         (WebCore::SVGResourceImage::SVGResourceImage):
4055         (WebCore::SVGResourceImage::~SVGResourceImage):
4056         (WebCore::SVGResourceImage::init):
4057         (WebCore::SVGResourceImage::size):
4058         (WebCore::SVGResourceImage::cgLayer):
4059         (WebCore::SVGResourceImage::setCGLayer):
4060         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
4061         (WebCore::applyLuminanceToAlphaFilter):
4062         (WebCore::applyExpandAlphatoGrayscaleFilter):
4063         (WebCore::transformImageIntoGrayscaleMask):
4064         (WebCore::SVGResourceMasker::applyMask):
4065         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
4066         (WebCore::SVGResourceClipper::applyClip):
4067         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
4068         (WebCore::SVGResourceImage::init):
4069         (WebCore::SVGResourceImage::size):
4070         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
4071         (WebCore::SVGResourceMasker::applyMask):
4072         * platform/qt/GraphicsContextQt.cpp:
4073         * rendering/RenderPath.cpp:
4074         (WebCore::RenderPath::paint):
4075         (WebCore::DrawMarkersData::DrawMarkersData):
4076         (WebCore::RenderPath::drawMarkersIfNeeded):
4077         * rendering/RenderSVGContainer.cpp:
4078         (WebCore::RenderSVGContainer::paint):
4079         * rendering/RenderSVGImage.cpp:
4080         (WebCore::RenderSVGImage::paint):
4081         * rendering/SVGInlineFlowBox.cpp:
4082         (WebCore::paintSVGInlineFlow):
4083
4084 2006-10-30  John Sullivan  <sullivan@apple.com>
4085
4086         Reviewed by Brady
4087         
4088         - minor cleanup to make future patches clearer
4089
4090         * bridge/mac/FrameMac.mm:
4091         (WebCore::FrameMac::advanceToNextMisspelling):
4092         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
4093         with "continue" to better match structure of similar code in markMisspellings; a few
4094         other style tweaks.
4095         
4096         (WebCore::FrameMac::markMisspellings):
4097         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
4098         a block just after a break and outdented accordingly.
4099
4100 2006-10-30  John Sullivan  <sullivan@apple.com>
4101
4102         Reviewed by Geoff Garen
4103         
4104         WebCore part of change to push the code that updates the spelling panel
4105         into WebCore, in preparation for some grammar-checking stuff.
4106
4107         * bridge/mac/FrameMac.h:
4108         * bridge/mac/FrameMac.mm:
4109         (WebCore::FrameMac::advanceToNextMisspelling):
4110         no more return value for this method, and update the spelling panel with
4111         the misspelled word here rather than in the WebKit callers.
4112
4113 2006-10-30  Oliver Hunt  <oliver@apple.com>
4114
4115         Reviewed by Anders.
4116
4117         Roll out last patch
4118
4119         * CMakeLists.txt:
4120         * ChangeLog:
4121         * WebCore.xcodeproj/project.pbxproj:
4122         * graphics/svg/SVGResource.cpp:
4123         * graphics/svg/SVGResourceClipper.cpp:
4124         * graphics/svg/SVGResourceClipper.h:
4125         * graphics/svg/SVGResourceImage.h:
4126         * graphics/svg/SVGResourceListener.h:
4127         * graphics/svg/SVGResourceMarker.cpp:
4128         * graphics/svg/SVGResourceMarker.h:
4129         * graphics/svg/SVGResourceMasker.cpp:
4130         * graphics/svg/SVGResourceMasker.h:
4131         * kcanvas/KCanvasClipper.cpp: Added.
4132         (WebCore::operator<<):
4133         (WebCore::KCanvasClipper::KCanvasClipper):
4134         (WebCore::KCanvasClipper::~KCanvasClipper):
4135         (WebCore::KCanvasClipper::resetClipData):
4136         (WebCore::KCanvasClipper::addClipData):
4137         (WebCore::KCanvasClipper::clipData):
4138         (WebCore::KCanvasClipper::externalRepresentation):
4139         (WebCore::getClipperById):
4140         * kcanvas/KCanvasClipper.h: Added.
4141         (WebCore::KCClipData::windRule):
4142         (WebCore::KCClipDataList::KCClipDataList):
4143         (WebCore::KCClipDataList::addPath):
4144         (WebCore::KCanvasClipper::isClipper):
4145         * kcanvas/KCanvasFilters.cpp:
4146         (WebCore::getFilterById):
4147         * kcanvas/KCanvasFilters.h:
4148         * kcanvas/KCanvasImage.h: Added.
4149         (WebCore::KCanvasImage::KCanvasImage):
4150         (WebCore::KCanvasImage::~KCanvasImage):
4151         * kcanvas/KCanvasMarker.cpp: Added.
4152         (WebCore::KCanvasMarker::KCanvasMarker):
4153         (WebCore::KCanvasMarker::~KCanvasMarker):
4154         (WebCore::KCanvasMarker::setMarker):
4155         (WebCore::KCanvasMarker::setRef):
4156         (WebCore::KCanvasMarker::refX):
4157         (WebCore::KCanvasMarker::refY):
4158         (WebCore::KCanvasMarker::setAngle):
4159         (WebCore::KCanvasMarker::angle):
4160         (WebCore::KCanvasMarker::setAutoAngle):
4161         (WebCore::KCanvasMarker::setUseStrokeWidth):
4162         (WebCore::KCanvasMarker::useStrokeWidth):
4163         (WebCore::KCanvasMarker::draw):
4164         (WebCore::KCanvasMarker::externalRepresentation):
4165         (WebCore::getMarkerById):
4166         * kcanvas/KCanvasMarker.h: Added.
4167         (WebCore::KCanvasMarker::isMarker):
4168         * kcanvas/KCanvasMasker.cpp: Added.
4169         (WebCore::KCanvasMasker::KCanvasMasker):
4170         (WebCore::KCanvasMasker::~KCanvasMasker):
4171         (WebCore::KCanvasMasker::setMask):
4172         (WebCore::KCanvasMasker::externalRepresentation):
4173         (WebCore::getMaskerById):
4174         * kcanvas/KCanvasMasker.h: Added.