Build fix.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
2
3         Build fix.
4         
5         * page/FramePrivate.h:
6         (WebCore::FramePrivate::FramePrivate):
7
8 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
9
10         Reviewed by Geoff, landed by Anders.
11         
12         Fix dependency problems caused when running move-js-headers.sh
13         
14         * move-js-headers.sh:
15         Use cp -p instead of just cp so that the modification time
16         of the original files are used.
17
18 2006-11-02  Adam Roben  <aroben@apple.com>
19
20         Reviewed by Tim H, landed by Anders.
21
22         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
23         REGRESSION: Shadow of file upload button is clipped
24
25         * rendering/RenderFileUploadControl.cpp:
26         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
27         height to keep from clipping in the shadow
28
29 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
30
31         Reviewed by Maciej, landed by Anders.
32
33         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
34         content and window. ScrollViewQt already receives correct content
35         coordinates from QScrollArea.
36         (WebCore::ScrollView::contentsToWindow):
37         (WebCore::ScrollView::windowToContents):
38
39 2006-11-02  Simon Hausmann  <hausmann@kde.org>
40
41         Reviewed by Maciej, landed by Anders
42
43         * CMakeLists.txt: Make linkage against KDE libraries conditional
44         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
45           Qt base resource handler that supports only requests to the
46           local filesystem. Used when compiling without KDE support.
47           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
48           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
49         (WebCore::QtJob::QtJob):
50         (WebCore::QtJob::timerEvent):
51         (WebCore::ResourceHandleManager::ResourceHandleManager):
52         (WebCore::ResourceHandleManager::~ResourceHandleManager):
53         (WebCore::ResourceHandleManager::self):
54         (WebCore::ResourceHandleManager::remove):
55         (WebCore::ResourceHandleManager::add):
56         (WebCore::ResourceHandleManager::cancel):
57         (WebCore::ResourceHandleManager::deliverJobData):
58         * platform/network/qt/ResourceHandleManager.h:
59         * platform/qt/FrameQtClient.cpp:
60         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
61         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
62         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
63         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
64           input dialog functions when compiling without KDE support
65         (WebCore::ServeSynchronousRequest):
66
67 2006-11-02  David Carson  <dacarson@gmail.com>
68
69         Reviewed by Geoff, landed by Anders.
70
71         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
72         Initializing variable in constructor.
73
74         * page/FramePrivate.h:
75         (WebCore::FramePrivate::FramePrivate):
76
77 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
78
79         Reviewed by Geoff.
80
81         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
82         
83         * platform/network/cf/ResourceHandleCFNet.cpp:
84         (WebCore::addHeadersFromHashMap):
85         Don't set all headers at once since that clears any previous headers set.
86         
87         (WebCore::ResourceHandle::start):
88
89 2006-11-02  Adele Peterson  <adele@apple.com>
90
91         Reviewed by Mitz and Geoff.
92
93         - Fix for:
94         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
95         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
96         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
97
98         Test: fast/forms/textarea-scrollbar.html
99
100         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
101         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
102
103         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
104         * rendering/RenderTextControl.cpp: 
105         (WebCore::RenderTextControl::RenderTextControl):
106         (WebCore::RenderTextControl::setStyle):
107         (WebCore::RenderTextControl::createDivStyle):
108         (WebCore::RenderTextControl::updateFromElement):
109         (WebCore::RenderTextControl::calcHeight):
110         (WebCore::RenderTextControl::baselinePosition):
111         (WebCore::RenderTextControl::nodeAtPoint):
112         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
113         (WebCore::RenderTextControl::scrollWidth):
114         (WebCore::RenderTextControl::scrollHeight):
115         (WebCore::RenderTextControl::scrollLeft):
116         (WebCore::RenderTextControl::scrollTop):
117
118         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
119
120 2006-11-02  John Sullivan  <sullivan@apple.com>
121
122         Reviewed by Geoff Garen
123
124         * editing/Selection.cpp:
125         (WebCore::Selection::showTreeForThis):
126         this debugging method now displays start offset and end offset, at Darin's suggestion
127
128 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
129
130         Reviewed by darin
131
132         <rdar://problem/4062865>
133         Copy/paste of a select element fails to include the options
134         
135         * editing/SelectionController.cpp:
136         (WebCore::SelectionController::modify): Added paragraphBoundary.
137         * editing/htmlediting.cpp:
138         (WebCore::canHaveChildrenForEditing): Added checks for input elements
139         and textareas.  Insertion operations would fail when performed just 
140         before/after one of these elements b/c the content would be put inside 
141         the element.
142         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
143         editable content, and made the code to stop at an root faster (don't check
144         isDescendantOf on every iteration).
145         (WebCore::enclosingNodeOfType): Ditto.
146         (WebCore::enclosingList): Ditto.
147         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
148         inappropriately named.
149         * editing/markup.cpp:
150         (WebCore::startMarkup): Use the text node's value instead of its rendered
151         content for text nodes inside select elements.  One might also turn off
152         annotation when createMarkup enters a select element, but createMarkup
153         is iterative, not recursive, so doing so would be complicated.
154         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
155         descendants of a select element.
156         * editing/visible_units.cpp:
157         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
158         where various replaced elements can't be copied when they are the only
159         thing selected.
160         (WebCore::endOfParagraph): Ditto.
161
162 2006-11-01  Oliver Hunt  <oliver@apple.com>
163
164         Reviewed by Adam.
165
166         Converting more or kcanvas/quartz from Obj-C to C++
167         Minor SVG updates
168         compatibility fixes
169
170         * WebCore.xcodeproj/project.pbxproj:
171         * kcanvas/device/KRenderingPaintServer.h:
172         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
173         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
174         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
175         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
176         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
177         * kcanvas/device/quartz/QuartzSupport.h:
178         * ksvg2/css/SVGCSSStyleSelector.cpp:
179         * ksvg2/misc/KCanvasRenderingStyle.h:
180         * ksvg2/scripts/cssmakeprops:
181         * ksvg2/scripts/cssmakevalues:
182         * ksvg2/scripts/make_names.pl:
183         * ksvg2/svg/SVGAnimateColorElement.cpp:
184         * ksvg2/svg/SVGAnimateTransformElement.cpp:
185         * ksvg2/svg/SVGAnimationElement.cpp:
186         * ksvg2/svg/SVGMaskElement.cpp:
187         * ksvg2/svg/SVGPatternElement.cpp:
188         * ksvg2/svg/svgpathparser.cpp:
189         * platform/Path.cpp:
190         * platform/graphics/svg/SVGResourceImage.h:
191         * rendering/RenderPath.cpp:
192         * rendering/SVGRenderAsText.cpp:
193
194 2006-11-02  Mitz Pettel  <mitz@webkit.org>
195
196         Reviewed by Adele.
197
198         - Fix a regression from r17521: painting of and crash caused by tables
199           with collapsed borders
200
201         * rendering/RenderTable.cpp:
202         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
203         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
204         and 'paintInfo' is the parameter, which we were accidently modifying.
205
206 2006-11-01  Adele Peterson  <adele@apple.com>
207
208         Reviewed by Mitz.
209
210         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
211         REGRESSION: Incomplete repaint of overflow areas when deleting
212
213         Restrict the repaint rect for overflow blocks after the height has been fully computed.
214         Also, adjust the repaint rect coordinates for the scroll offset.
215
216         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
217         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
218
219 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
220
221         Reviewed by Mitz.
222
223         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
224         Rename the "p" member variable of the PaintInfo struct to "context"
225
226         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
227           'context' and 'rect' respectively.
228
229         - Assorted surrounding cleanups.
230
231         * rendering/EllipsisBox.cpp:
232         (WebCore::EllipsisBox::paint):
233         * rendering/EllipsisBox.h:
234         * rendering/InlineBox.cpp:
235         (WebCore::InlineBox::paint):
236         * rendering/InlineFlowBox.cpp:
237         (WebCore::InlineFlowBox::paint):
238         (WebCore::InlineFlowBox::paintBackground):
239         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
240         (WebCore::InlineFlowBox::paintDecorations):
241         * rendering/InlineFlowBox.h:
242         * rendering/InlineRunBox.h:
243         * rendering/InlineTextBox.cpp:
244         (WebCore::InlineTextBox::paint):
245         * rendering/InlineTextBox.h:
246         * rendering/RenderBlock.cpp:
247         (WebCore::RenderBlock::paint):
248         (WebCore::RenderBlock::paintChildren):
249         (WebCore::RenderBlock::paintCaret):
250         (WebCore::RenderBlock::paintObject):
251         (WebCore::RenderBlock::paintFloats):
252         (WebCore::RenderBlock::paintEllipsisBoxes):
253         (WebCore::RenderBlock::paintSelection):
254         (WebCore::RenderBlock::fillSelectionGaps):
255         (WebCore::RenderBlock::fillInlineSelectionGaps):
256         (WebCore::RenderBlock::fillBlockSelectionGaps):
257         (WebCore::RenderBlock::fillHorizontalSelectionGap):
258         (WebCore::RenderBlock::fillVerticalSelectionGap):
259         (WebCore::RenderBlock::fillLeftSelectionGap):
260         (WebCore::RenderBlock::fillRightSelectionGap):
261         * rendering/RenderBox.cpp:
262         (WebCore::RenderBox::paint):
263         (WebCore::RenderBox::paintRootBoxDecorations):
264         (WebCore::RenderBox::paintBoxDecorations):
265         * rendering/RenderBox.h:
266         * rendering/RenderButton.cpp:
267         (WebCore::RenderButton::paintObject):
268         * rendering/RenderFieldset.cpp:
269         (WebCore::RenderFieldset::paintBoxDecorations):
270         * rendering/RenderFileUploadControl.cpp:
271         (WebCore::RenderFileUploadControl::paintObject):
272         * rendering/RenderFlow.cpp:
273         (WebCore::RenderFlow::continuationBefore):
274         (WebCore::RenderFlow::addChildWithContinuation):
275         (WebCore::RenderFlow::addChild):
276         (WebCore::RenderFlow::attachLineBox):
277         (WebCore::RenderFlow::destroy):
278         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
279         (WebCore::RenderFlow::dirtyLineBoxes):
280         (WebCore::RenderFlow::createInlineBox):
281         (WebCore::RenderFlow::paintLines):
282         (WebCore::RenderFlow::getAbsoluteRepaintRect):
283         (WebCore::RenderFlow::lowestPosition):
284         (WebCore::RenderFlow::rightmostPosition):
285         (WebCore::RenderFlow::leftmostPosition):
286         (WebCore::RenderFlow::caretRect):
287         (WebCore::RenderFlow::addFocusRingRects):
288         (WebCore::RenderFlow::paintOutline):
289         (WebCore::RenderFlow::paintOutlineForLine):
290         * rendering/RenderForeignObject.cpp:
291         (WebCore::RenderForeignObject::paint):
292         * rendering/RenderHTMLCanvas.cpp:
293         (WebCore::RenderHTMLCanvas::paint):
294         * rendering/RenderImage.cpp:
295         (WebCore::RenderImage::paint):
296         * rendering/RenderLayer.cpp:
297         (WebCore::RenderLayer::paintLayer):
298         * rendering/RenderListBox.cpp:
299         (WebCore::RenderListBox::paintObject):
300         (WebCore::RenderListBox::paintScrollbar):
301         (WebCore::RenderListBox::paintItemForeground):
302         (WebCore::RenderListBox::paintItemBackground):
303         * rendering/RenderListMarker.cpp:
304         (WebCore::RenderListMarker::paint):
305         * rendering/RenderMenuList.cpp:
306         (WebCore::RenderMenuList::paintObject):
307         * rendering/RenderObject.cpp:
308         (WebCore::RenderObject::paint):
309         * rendering/RenderObject.h:
310         (WebCore::RenderObject::PaintInfo::PaintInfo):
311         (WebCore::RenderObject::paintBoxDecorations):
312         (WebCore::RenderObject::paintingRootForChildren):
313         (WebCore::RenderObject::shouldPaintWithinRoot):
314         (WebCore::RenderObject::printBoxDecorations):
315         * rendering/RenderPath.cpp:
316         (WebCore::RenderPath::paint):
317         * rendering/RenderReplaced.cpp:
318         (WebCore::RenderReplaced::shouldPaint):
319         * rendering/RenderSVGContainer.cpp:
320         (WebCore::RenderSVGContainer::paint):
321         * rendering/RenderSVGContainer.h:
322         * rendering/RenderSVGImage.cpp:
323         (WebCore::RenderSVGImage::paint):
324         * rendering/RenderSVGText.cpp:
325         (WebCore::RenderSVGText::paint):
326         * rendering/RenderSVGText.h:
327         (WebCore::RenderSVGText::renderName):
328         * rendering/RenderTable.cpp:
329         (WebCore::RenderTable::paint):
330         (WebCore::RenderTable::paintBoxDecorations):
331         * rendering/RenderTable.h:
332         * rendering/RenderTableCell.cpp:
333         (WebCore::RenderTableCell::paint):
334         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
335         (WebCore::RenderTableCell::paintBoxDecorations):
336         * rendering/RenderTableCell.h:
337         * rendering/RenderTableRow.cpp:
338         (WebCore::RenderTableRow::paint):
339         * rendering/RenderTableRow.h:
340         * rendering/RenderTableSection.cpp:
341         (WebCore::RenderTableSection::paint):
342         * rendering/RenderTableSection.h:
343         (WebCore::RenderTableSection::getBaseline):
344         (WebCore::RenderTableSection::setNeedCellRecalc):
345         * rendering/RenderText.h:
346         (WebCore::RenderText::renderName):
347         (WebCore::RenderText::paint):
348         (WebCore::RenderText::element):
349         * rendering/RenderTheme.cpp:
350         (WebCore::RenderTheme::paint):
351         (WebCore::RenderTheme::paintBorderOnly):
352         (WebCore::RenderTheme::paintDecorations):
353         * rendering/RenderTheme.h:
354         (WebCore::RenderTheme::RenderTheme):
355         (WebCore::RenderTheme::~RenderTheme):
356         (WebCore::RenderTheme::controlSupportsTints):
357         (WebCore::RenderTheme::adjustRepaintRect):
358         (WebCore::RenderTheme::themeChanged):
359         (WebCore::RenderTheme::supportsHover):
360         (WebCore::RenderTheme::paintCheckbox):
361         (WebCore::RenderTheme::setCheckboxSize):
362         (WebCore::RenderTheme::paintRadio):
363         (WebCore::RenderTheme::setRadioSize):
364         (WebCore::RenderTheme::paintButton):
365         (WebCore::RenderTheme::setButtonSize):
366         (WebCore::RenderTheme::paintTextField):
367         (WebCore::RenderTheme::paintTextArea):
368         (WebCore::RenderTheme::paintMenuList):
369         (WebCore::RenderTheme::paintMenuListButton):
370         * rendering/RenderThemeMac.mm:
371         (WebCore::RenderThemeMac::paintCheckbox):
372         (WebCore::RenderThemeMac::paintRadio):
373         (WebCore::RenderThemeMac::paintButton):
374         (WebCore::RenderThemeMac::paintTextField):
375         (WebCore::RenderThemeMac::paintTextArea):
376         (WebCore::RenderThemeMac::paintMenuList):
377         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
378         (WebCore::RenderThemeMac::paintMenuListButton):
379         * rendering/RenderView.cpp:
380         (WebCore::RenderView::paint):
381         (WebCore::RenderView::paintBoxDecorations):
382         * rendering/RenderView.h:
383         * rendering/RenderWidget.cpp:
384         (WebCore::RenderWidget::paint):
385         * rendering/RenderWidget.h:
386         (WebCore::RenderWidget::isWidget):
387         * rendering/RootInlineBox.cpp:
388         (WebCore::RootInlineBox::paintEllipsisBox):
389         (WebCore::RootInlineBox::paintCustomHighlight):
390         (WebCore::RootInlineBox::paint):
391         (WebCore::RootInlineBox::fillLineSelectionGap):
392         * rendering/RootInlineBox.h:
393         * rendering/SVGInlineFlowBox.cpp:
394         (WebCore::paintSVGInlineFlow):
395
396 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
397
398         Reviewed by Oliver, Brady.
399
400         * platform/network/ResourceResponse.h:
401         (WebCore::ResourceResponse::setLastModifiedDate):
402         (WebCore::ResourceResponse::lastModifiedDate):
403         Add getters and setters for last modified dadte.
404         
405         * platform/network/cf/ResourceResponseCFNet.cpp:
406         (WebCore::getResourceResponse):
407         Fetch the last modified date. Add correct offset to expired date.
408
409 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
410
411         Reviewed by Mitz.
412
413         Added missing "break;" statement in switch statement from r17493.
414
415         Bug 11442: [CSS 3] support for cursor: all-scroll
416         http://bugs.webkit.org/show_bug.cgi?id=11442
417
418         * css/CSSComputedStyleDeclaration.cpp:
419         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
420
421 2006-10-31  Mitz Pettel  <mitz@webkit.org>
422
423         Reviewed by Maciej.
424
425         - fix image dragging
426
427         This is covered by editing/selection/drag-to-contenteditable-iframe.html
428
429         * rendering/HitTestResult.cpp:
430         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
431         HTML IMG elements.
432         (WebCore::HitTestResult::absoluteImageURL): Ditto.
433
434 2006-10-31  Beth Dakin  <bdakin@apple.com>
435
436         Reviewed by Maciej.
437
438         This adds the back-end of the remaining WebElementDictionary 
439         functions into HitTestResult.
440
441         * WebCore.exp:
442         * rendering/HitTestResult.cpp:
443         (WebCore::HitTestResult::title):
444         (WebCore::displayString): This is nearly identical to the 
445         displayString() defined in DOMInternal.mm except that it returns a 
446         String instead of an NSString. The old code path used the 
447         DOMInternal method, so I made a new one here for the new code path.
448         (WebCore::HitTestResult::altDisplayString):
449         (WebCore::HitTestResult::image):
450         (WebCore::HitTestResult::absoluteImageURL):
451         (WebCore::HitTestResult::absoluteLinkURL):
452         (WebCore::HitTestResult::titleDisplayString):
453         (WebCore::HitTestResult::textContent):
454         * rendering/HitTestResult.h:
455
456 2006-10-31  John Sullivan  <sullivan@apple.com>
457
458         * bridge/mac/FrameMac.mm:
459         (WebCore::FrameMac::markMisspellings):
460         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
461
462 2006-10-31  John Sullivan  <sullivan@apple.com>
463
464         Reviewed by Maciej
465         
466         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
467         
468         The foundation of this was in my last checkin. This checkin is all about displaying
469         the correct string in the toolTip.
470
471         * dom/DocumentMarker.h:
472         New description field in this struct.
473
474         * bridge/mac/FrameMac.mm:
475         (WebCore::FrameMac::advanceToNextMisspelling):
476         When adding a grammar marker, supply the appropriate description. Also, added a comment
477         about the remaining work to make grammar checking return sensible answers.
478         (WebCore::FrameMac::markMisspellings):
479         ditto (yes, still needs some refactoring to minimize duplicated code)
480         
481         * dom/Document.h:
482         * dom/Document.cpp:
483         (WebCore::Document::addMarker):
484         Now takes an optional description string
485         (WebCore::Document::markerContainingPoint):
486         New function, returns a pointer to the (first) marker of the specified type whose rect 
487         contains the specified point, or 0 if none.
488         
489         * rendering/HitTestResult.cpp:
490         (WebCore::HitTestResult::spellingToolTip):
491         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
492         and gets the description from the marker.
493
494 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
495
496         Reviewed by Maciej.
497         
498         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
499
500         * loader/mac/FrameLoaderMac.mm:
501         (WebCore::FrameLoader::createWindow):
502         * manual-tests/window-open-features-parsing.html: Updated for clarity.
503
504 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
505
506         Reviewed by Alice.
507
508         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
509         to WebCore::Editor.
510         
511         Layout tests pass.
512         
513         Renamed "may*" to "can*" because "can" is more accurate (these functions
514         aren't just about permission) and it matches WebKit.
515
516         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
517         password field. Now that WebCore fully implements canCopy(), it doesn't just
518         mean "the selection is not in a password field" anymore.
519         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
520         The fact that it's not called anymore may represent a security issue, but I
521         don't see how commented-out code will help reveal the issue, and the
522         bridge is going away, anyway.
523         * editing/SelectionController.h: Changed selection() calls to references
524         to m_sel, to match the rest of the file.
525
526 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
527
528         Reviewed by harrison
529         
530         <rdar://problem/4711063>
531         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
532
533         * editing/ReplaceSelectionCommand.cpp:
534         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
535         insertion and plain text string creation unless we need the string
536         for a BeforeTextInserted event handler or for a plain text only region.
537         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
538         code here from ReplacementFragment's constructor.
539         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
540         FIXME.
541         * editing/ReplaceSelectionCommand.h:
542
543 2006-10-31  Ada Chan  <adachan@apple.com>
544
545         Reviewed by Adam
546
547         Correct forward declarations of the HitTestRequest struct.
548
549         * rendering/EllipsisBox.h:
550         * rendering/InlineBox.h:
551         * rendering/InlineFlowBox.h:
552         * rendering/RenderLayer.h:
553         * rendering/RenderObject.h:
554
555 2006-10-31  John Sullivan  <sullivan@apple.com>
556
557         Reviewed by Beth and Adam
558
559         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
560         next I'll make it use a string that's relevant for a specific grammar error.
561
562         * WebCore.exp:
563         export symbol for spellingToolTip function
564         
565         * rendering/HitTestResult.h:
566         * rendering/HitTestResult.cpp:
567         (WebCore::HitTestResult::spellingToolTip):
568         new function, returns the string to be used in a tool tip that describes the questionable grammar
569         
570         * rendering/InlineTextBox.h:
571         * rendering/InlineTextBox.cpp:
572         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
573         now takes a style and font, needed to compute the rect representing the range containing
574         questionable grammar. Computes the rect and associates it with the marker.
575         (WebCore::InlineTextBox::paintDocumentMarkers):
576         Pass in the style and font now needed by paintSpellingOrGrammarMarker
577
578 2006-10-31  Adele Peterson  <adele@apple.com>
579
580         Removed commented out variable from last checkin.
581
582         * html/HTMLSelectElement.cpp:
583         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
584
585 2006-10-31  Brady Eidson  <beidson@apple.com>
586
587         Build fix (unused variable in release builds)
588
589         * html/HTMLSelectElement.cpp:
590         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
591
592 2006-10-31  Adele Peterson  <adele@apple.com>
593
594         Reviewed by Adam.
595
596         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
597         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
598         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
599
600         Tests: 
601         * LayoutTests/fast/forms/listbox-selection.html
602         * LayoutTests/fast/forms/listbox-onchange.html
603
604         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
605           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
606           And one for onChange, that is updated after onChange is fired.
607           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
608  
609         * html/HTMLSelectElement.cpp:
610         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
611         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
612         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
613         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
614         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
615         (WebCore::HTMLSelectElement::setExtent): Added.
616         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
617         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
618
619         * rendering/RenderListBox.cpp:
620         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
621         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
622         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
623         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
624          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
625          notify the select element from here.
626         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
627         (WebCore::RenderListBox::listIndexIsVisible): Added.
628         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
629
630         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
631         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
632         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
633         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
634         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
635
636 2006-10-31  Beth Dakin  <bdakin@apple.com>
637
638         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
639
640         * rendering/HitTestRequest.h: Added.
641         (WebCore::HitTestRequest::HitTestRequest):
642
643 2006-10-31  Beth Dakin  <bdakin@apple.com>
644
645         Reviewed by Maciej.
646
647         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
648         should be split into HitTestRequest and HitTestResult
649
650         This patch creates a new struct called HitTestRequest that holds 
651         the three boolean values (readonly, active, and mouseMove) that 
652         were formerly a part of HitTestResult. All hitTest() and 
653         nodeAtPoint() functions now take a HitTestRequest in addition to 
654         the HitTestResult.
655
656         * WebCore.exp:
657         * WebCore.xcodeproj/project.pbxproj:
658         * bridge/mac/FrameMac.mm:
659         (WebCore::FrameMac::eventMayStartDrag):
660         (WebCore::FrameMac::handleMouseMoveEvent):
661         * bridge/mac/WebCoreAXObject.mm:
662         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
663         (-[WebCoreAXObject accessibilityHitTest:]):
664         * dom/Document.cpp:
665         (WebCore::Document::elementFromPoint):
666         (WebCore::Document::prepareMouseEvent):
667         * editing/SelectionController.cpp:
668         (WebCore::SelectionController::contains):
669         * page/Frame.cpp:
670         (WebCore::Frame::hitTestResultAtPoint):
671         * page/FrameView.cpp:
672         (WebCore::FrameView::handleWheelEvent):
673         * rendering/EllipsisBox.cpp:
674         (WebCore::EllipsisBox::nodeAtPoint):
675         * rendering/EllipsisBox.h:
676         * rendering/HitTestResult.cpp:
677         (WebCore::HitTestResult::HitTestResult):
678         (WebCore::HitTestResult::operator=):
679         * rendering/HitTestResult.h:
680         * rendering/InlineBox.cpp:
681         (WebCore::InlineBox::nodeAtPoint):
682         * rendering/InlineBox.h:
683         * rendering/InlineFlowBox.cpp:
684         (WebCore::InlineFlowBox::nodeAtPoint):
685         * rendering/InlineFlowBox.h:
686         * rendering/InlineTextBox.cpp:
687         (WebCore::InlineTextBox::nodeAtPoint):
688         * rendering/InlineTextBox.h:
689         * rendering/RenderBlock.cpp:
690         (WebCore::RenderBlock::nodeAtPoint):
691         * rendering/RenderBlock.h:
692         * rendering/RenderBox.cpp:
693         (WebCore::RenderBox::nodeAtPoint):
694         * rendering/RenderBox.h:
695         * rendering/RenderFlow.cpp:
696         (WebCore::RenderFlow::hitTestLines):
697         * rendering/RenderFlow.h:
698         * rendering/RenderForeignObject.cpp:
699         (WebCore::RenderForeignObject::nodeAtPoint):
700         * rendering/RenderForeignObject.h:
701         * rendering/RenderFrameSet.cpp:
702         (WebCore::RenderFrameSet::nodeAtPoint):
703         * rendering/RenderFrameSet.h:
704         * rendering/RenderImage.cpp:
705         (WebCore::RenderImage::nodeAtPoint):
706         * rendering/RenderImage.h:
707         * rendering/RenderInline.cpp:
708         (WebCore::RenderInline::nodeAtPoint):
709         * rendering/RenderInline.h:
710         * rendering/RenderLayer.cpp:
711         (WebCore::RenderLayer::autoscroll):
712         (WebCore::RenderLayer::hitTest):
713         (WebCore::RenderLayer::hitTestLayer):
714         (WebCore::RenderLayer::updateHoverActiveState):
715         * rendering/RenderLayer.h:
716         * rendering/RenderObject.cpp:
717         (WebCore::RenderObject::hitTest):
718         (WebCore::RenderObject::nodeAtPoint):
719         * rendering/RenderObject.h:
720         * rendering/RenderPath.cpp:
721         (WebCore::RenderPath::nodeAtPoint):
722         * rendering/RenderPath.h:
723         * rendering/RenderSVGImage.cpp:
724         (WebCore::RenderSVGImage::nodeAtPoint):
725         * rendering/RenderSVGImage.h:
726         * rendering/RenderSVGText.cpp:
727         (WebCore::RenderSVGText::nodeAtPoint):
728         * rendering/RenderSVGText.h:
729         * rendering/RenderTableRow.cpp:
730         (WebCore::RenderTableRow::nodeAtPoint):
731         * rendering/RenderTableRow.h:
732         * rendering/RenderTableSection.cpp:
733         (WebCore::RenderTableSection::nodeAtPoint):
734         * rendering/RenderTableSection.h:
735         * rendering/RenderText.h:
736         (WebCore::RenderText::nodeAtPoint):
737         * rendering/RenderTextControl.cpp:
738         (WebCore::RenderTextControl::nodeAtPoint):
739         * rendering/RenderTextControl.h:
740         * rendering/RootInlineBox.cpp:
741         (WebCore::RootInlineBox::nodeAtPoint):
742         * rendering/RootInlineBox.h:
743
744 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
745
746         Reviewed by Maciej.
747
748         Bug 11442: [CSS 3] support for cursor: all-scroll
749         http://bugs.webkit.org/show_bug.cgi?id=11442
750
751         * css/CSSComputedStyleDeclaration.cpp:
752         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
753         * css/CSSValueKeywords.in:
754         * css/cssparser.cpp:
755         (WebCore::CSSParser::parseValue):
756         * page/FrameView.cpp:
757         (WebCore::selectCursor):
758         * rendering/RenderStyle.h:
759
760 2006-10-31  Oliver Hunt  <oliver@apple.com>
761
762         Reviewed by Geoff.
763
764         Converting Obj-C++ to C++ in kcanvas
765
766         * WebCore.xcodeproj/project.pbxproj:
767         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
768         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
769         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
770         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
771         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
772         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
773         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
774         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
775         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
776         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
777         * kcanvas/device/quartz/QuartzSupport.h:
778         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
779         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
780         (WebCore::SVGResourceClipper::applyClip):
781         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
782         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
783         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
784
785 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
786
787         Reviewed by harrison
788         
789         <rdar://problem/4808375>
790         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
791         
792         Completely back out r17276 because of performance issues.
793
794         * editing/TextIterator.cpp:
795         (WebCore::TextIterator::TextIterator):
796         (WebCore::TextIterator::advance):
797         (WebCore::TextIterator::handleTextNode):
798         (WebCore::TextIterator::handleTextBox):
799         (WebCore::TextIterator::handleReplacedElement):
800         (WebCore::TextIterator::handleNonTextNode):
801         (WebCore::TextIterator::exitNode):
802         (WebCore::TextIterator::emitCharacter):
803         (WebCore::TextIterator::range):
804         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
805         (WebCore::SimplifiedBackwardsTextIterator::advance):
806         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
807         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
808         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
809         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
810         (WebCore::SimplifiedBackwardsTextIterator::range):
811         (WebCore::CharacterIterator::range):
812         (WebCore::TextIterator::rangeFromLocationAndLength):
813         * editing/TextIterator.h:
814         (WebCore::TextIterator::atEnd):
815         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
816
817 2006-10-31  Darin Adler  <darin@apple.com>
818
819         Reviewed by Brady.
820
821         - got "action dictionary" code out of FrameLoader,
822           replacing with a class called NavigationAction
823
824         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
825         * loader/mac/DocumentLoaderMac.mm:
826         (WebCore::DocumentLoader::triggeringAction): Ditto.
827         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
828
829         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
830
831         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
832         Removed elementForEvent.
833         * loader/mac/FrameLoaderMac.mm:
834         (WebCore::FrameLoader::load): Ditto.
835         (WebCore::FrameLoader::reload): Ditto.
836         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
837         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
838         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
839         (WebCore::FrameLoader::post): Ditto.
840
841         * loader/NavigationAction.h: Added.
842         * loader/NavigationAction.cpp: Added.
843         * loader/mac/NavigationActionMac.mm: Added.
844
845         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
846
847         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
848         * WebCore.exp: Updated.
849
850 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
851
852         Reviewed by Adam.
853
854         Build fix
855
856         * platform/win/CookieJarWin.cpp:
857         (WebCore::cookies):
858
859 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
860
861         Reviewed by Maciej. Landed by Adam.
862
863         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
864
865         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
866         as dicussed with Dave. Also kill the outdated DESIGN document.
867
868         * CMakeLists.txt:
869         * WebCore.xcodeproj/project.pbxproj:
870         * kcanvas/DESIGN: Removed.
871         * kcanvas/KCanvasFilters.cpp:
872         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
873         * kcanvas/KCanvasTreeDebug.h: Ditto.
874         * kcanvas/device/KRenderingPaintServerGradient.cpp:
875         * kcanvas/device/KRenderingPaintServerPattern.cpp:
876         * kcanvas/device/KRenderingPaintServerSolid.cpp:
877         * platform/graphics/svg/SVGResourceClipper.cpp:
878         * rendering/RenderTreeAsText.cpp:
879         * rendering/SVGRenderTreeAsText.cpp: Added.
880         * rendering/SVGRenderTreeAsText.h: Added.
881         (WebCore::operator<<):
882
883 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
884
885         Reviewed by Maciej.
886
887         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
888         Includes some CRLF -> LF fixups.
889
890         * platform/win/CookieJarWin.cpp:
891         (WebCore::cookies):
892
893 2006-10-31  Adam Roben  <aroben@apple.com>
894
895         Reviewed by Steve.
896
897         Fix some incorrect forward declarations.
898
899         * loader/FrameLoader.h:
900         * page/Frame.h:
901
902 2006-10-31  Darin Adler  <darin@apple.com>
903
904         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
905         try to fix the build on the buildbot.
906
907 2006-10-31  Darin Adler  <darin@apple.com>
908
909         * bridge/mac/FrameMac.mm:
910         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
911         (WebCore::FrameMac::markMisspellings): Ditto.
912
913 2006-10-31  John Sullivan  <sullivan@apple.com>
914
915         * bridge/mac/FrameMac.mm:
916         (WebCore::FrameMac::advanceToNextMisspelling):
917         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
918
919 2006-10-30  John Sullivan  <sullivan@apple.com>
920
921         Reviewed by Adam Roben
922         
923         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
924         
925         This patch introduces much of the guts of grammar checking, though still not enough to actually
926         check grammar sensibly, due to:
927           
928         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
929         context passed to grammar checker
930
931         * platform/Logging.h:
932         * platform/Logging.cpp:
933         new log channel SpellingAndGrammar
934
935         * bridge/mac/WebCorePageBridge.mm:
936         (initializeLoggingChannelsIfNecessary):
937         initialize new log channel
938
939         * bridge/mac/FrameMac.mm:
940         (WebCore::FrameMac::advanceToNextMisspelling):
941         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
942         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
943         in the event of a tie), and do further processing with that one (select range; create marker that
944         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
945         (WebCore::FrameMac::markMisspellings):
946         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
947         differently enough to make sharing code between these two functions a little tricky, so I decided to 
948         save that for a later patch.
949         
950         (WebCore::FrameMac::respondToChangedSelection):
951         remove grammar markers when we remove spelling markers        
952
953 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
954
955         Reviewed by Mitz.
956
957         Fix Qt/Linux build with older gcc3.3.4.
958
959         * bindings/js/kjs_window.cpp:
960         (KJS::WindowFunc::callAsFunction):
961
962 2006-10-31  Zack Rusin  <zack@kde.org>
963
964         Reviewed by Mitz.
965
966         Fix the Qt build after last nights changes.
967
968         * WebCore/platform/qt/FrameQt.cpp:
969         * WebCore/platform/qt/EditorClientQt.h:
970         * WebCore/platform/qt/EditorClientQt.cpp:
971         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
972         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
973         * WebCore/CMakeLists.txt:
974         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
975         * WebKitQt/QtLauncher/CMakeLists.txt:
976         * WebKitQt/WebKitPart/CMakeLists.txt:
977
978 2006-10-30  Darin Adler  <darin@apple.com>
979
980         Reviewed by Anders.
981
982         - remove BrowserExtension
983
984         * WebCore.vcproj/WebCore/WebCore.vcproj:
985         * WebCore.xcodeproj/project.pbxproj:
986         * bindings/js/kjs_window.cpp:
987         (KJS::createNewWindow):
988         (KJS::WindowFunc::callAsFunction):
989         * bridge/BrowserExtension.h: Removed.
990         * bridge/mac/BrowserExtensionMac.h: Removed.
991         * bridge/mac/BrowserExtensionMac.mm: Removed.
992         * bridge/mac/FrameMac.mm:
993         (WebCore::FrameMac::FrameMac):
994         (WebCore::FrameMac::submitForm):
995         (WebCore::FrameMac::urlSelected):
996         * bridge/win/BrowserExtensionWin.cpp: Removed.
997         * bridge/win/BrowserExtensionWin.h: Removed.
998         * bridge/win/FrameWin.cpp:
999         (WebCore::FrameWin::FrameWin):
1000         * loader/FrameLoader.cpp:
1001         (WebCore::FrameLoader::createWindow):
1002         * loader/FrameLoader.h:
1003         * loader/icon/IconLoader.cpp:
1004         * loader/mac/FrameLoaderMac.mm:
1005         (WebCore::FrameLoader::safeLoad):
1006         (WebCore::FrameLoader::load):
1007         (WebCore::FrameLoader::createWindow):
1008         * page/Frame.cpp:
1009         (WebCore::Frame::urlSelected):
1010         (WebCore::Frame::requestFrame):
1011         (WebCore::Frame::submitForm):
1012         (WebCore::Frame::scheduleHistoryNavigation):
1013         (WebCore::Frame::redirectionTimerFired):
1014         * page/Frame.h:
1015         * page/FrameLoadRequest.h:
1016         (WebCore::FrameLoadRequest::FrameLoadRequest):
1017         (WebCore::FrameLoadRequest::isEmpty):
1018         (WebCore::FrameLoadRequest::resourceRequest):
1019         (WebCore::FrameLoadRequest::frameName):
1020         (WebCore::FrameLoadRequest::setFrameName):
1021         * page/FramePrivate.h:
1022         (WebCore::FramePrivate::FramePrivate):
1023         (WebCore::FramePrivate::~FramePrivate):
1024         * platform/gdk/BrowserExtensionGdk.h: Removed.
1025         * platform/gdk/FrameGdk.cpp:
1026         (WebCore::FrameGdk::FrameGdk):
1027         * platform/gdk/TemporaryLinkStubs.cpp:
1028         * platform/network/ResourceRequest.h:
1029         (WebCore::ResourceRequest::isEmpty):
1030
1031 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1032
1033         Reviewed by Oliver.
1034
1035         Modified from original due to earlier reversion
1036
1037         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1038
1039         Better SVG integration in WebKit, Part I.
1040
1041         The patch is mostly about creating a new platform/graphics directory, and
1042         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1043         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1044         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1045
1046         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1047         All details of the patch, and upcoming patches can be found in the bug report.
1048
1049         * CMakeLists.txt:
1050         * WebCore.xcodeproj/project.pbxproj:
1051         * graphics/svg/SVGResource.cpp: Removed.
1052         * graphics/svg/SVGResourceClipper.cpp: Removed.
1053         * graphics/svg/SVGResourceClipper.h: Removed.
1054         * graphics/svg/SVGResourceImage.h: Removed.
1055         * graphics/svg/SVGResourceListener.h: Removed.
1056         * graphics/svg/SVGResourceMarker.cpp: Removed.
1057         * graphics/svg/SVGResourceMarker.h: Removed.
1058         * graphics/svg/SVGResourceMasker.cpp: Removed.
1059         * graphics/svg/SVGResourceMasker.h: Removed.
1060         * kcanvas/KCanvasClipper.cpp: Removed.
1061         * kcanvas/KCanvasClipper.h: Removed.
1062         * kcanvas/KCanvasCreator.cpp: Removed.
1063         * kcanvas/KCanvasCreator.h: Removed.
1064         * kcanvas/KCanvasFilters.cpp:
1065         (WebCore::getFilterById):
1066         * kcanvas/KCanvasFilters.h:
1067         * kcanvas/KCanvasImage.h: Removed.
1068         * kcanvas/KCanvasMarker.cpp: Removed.
1069         * kcanvas/KCanvasMarker.h: Removed.
1070         * kcanvas/KCanvasMasker.cpp: Removed.
1071         * kcanvas/KCanvasMasker.h: Removed.
1072         * kcanvas/KCanvasResource.cpp: Removed.
1073         * kcanvas/KCanvasResource.h: Removed.
1074         * kcanvas/KCanvasResourceListener.h: Removed.
1075         * kcanvas/KCanvasTreeDebug.cpp:
1076         (WebCore::writeRenderResources):
1077         * kcanvas/device/KRenderingDevice.h:
1078         * kcanvas/device/KRenderingPaintServer.h:
1079         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1080         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1081         (WebCore::KRenderingPaintServerGradient::listener):
1082         (WebCore::KRenderingPaintServerGradient::setListener):
1083         * kcanvas/device/KRenderingPaintServerGradient.h:
1084         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1085         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1086         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1087         (WebCore::KRenderingPaintServerPattern::tile):
1088         (WebCore::KRenderingPaintServerPattern::setTile):
1089         (WebCore::KRenderingPaintServerPattern::listener):
1090         (WebCore::KRenderingPaintServerPattern::setListener):
1091         * kcanvas/device/KRenderingPaintServerPattern.h:
1092         * kcanvas/device/KRenderingPaintServerSolid.h:
1093         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1094         * kcanvas/device/qt/KCanvasClipperQt.h:
1095         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1096         (WebCore::KRenderingDeviceQt::contextForImage):
1097         (WebCore::KRenderingDeviceQt::createResource):
1098         (WebCore::KRenderingDeviceQt::createPaintServer):
1099         * kcanvas/device/qt/KRenderingDeviceQt.h:
1100         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1101         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1102         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1103         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1104         * kcanvas/device/qt/RenderPathQt.h: Removed.
1105         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1106         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1107         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1108         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1109         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1110         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1111         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1112         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1113         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1114         (WebCore::KRenderingDeviceQuartz::contextForImage):
1115         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1116         (WebCore::KRenderingDeviceQuartz::createResource):
1117         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1118         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1119         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1120         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1121         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1122         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1123         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1124         (WebCore::patternCallback):
1125         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1126         * kcanvas/device/quartz/QuartzSupport.mm:
1127         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1128         (WebCore::sharedSolidPaintServer):
1129         * ksvg2/svg/SVGClipPathElement.cpp:
1130         (WebCore::SVGClipPathElement::SVGClipPathElement):
1131         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1132         (WebCore::SVGClipPathElement::canvasResource):
1133         * ksvg2/svg/SVGClipPathElement.h:
1134         * ksvg2/svg/SVGFEImageElement.cpp:
1135         * ksvg2/svg/SVGFilterElement.cpp:
1136         (WebCore::SVGFilterElement::SVGFilterElement):
1137         (WebCore::SVGFilterElement::~SVGFilterElement):
1138         (WebCore::SVGFilterElement::canvasResource):
1139         * ksvg2/svg/SVGFilterElement.h:
1140         * ksvg2/svg/SVGGradientElement.cpp:
1141         (WebCore::SVGGradientElement::SVGGradientElement):
1142         (WebCore::SVGGradientElement::~SVGGradientElement):
1143         (WebCore::SVGGradientElement::canvasResource):
1144         (WebCore::SVGGradientElement::resourceNotification):
1145         * ksvg2/svg/SVGGradientElement.h:
1146         * ksvg2/svg/SVGImageElement.cpp:
1147         * ksvg2/svg/SVGLinearGradientElement.cpp:
1148         (WebCore::SVGLinearGradientElement::buildGradient):
1149         * ksvg2/svg/SVGLinearGradientElement.h:
1150         * ksvg2/svg/SVGMarkerElement.cpp:
1151         (WebCore::SVGMarkerElement::SVGMarkerElement):
1152         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1153         (WebCore::SVGMarkerElement::canvasResource):
1154         * ksvg2/svg/SVGMarkerElement.h:
1155         * ksvg2/svg/SVGMaskElement.cpp:
1156         (WebCore::SVGMaskElement::SVGMaskElement):
1157         (WebCore::SVGMaskElement::~SVGMaskElement):
1158         (WebCore::SVGMaskElement::drawMaskerContent):
1159         (WebCore::SVGMaskElement::canvasResource):
1160         * ksvg2/svg/SVGMaskElement.h:
1161         * ksvg2/svg/SVGPatternElement.cpp:
1162         (WebCore::SVGPatternElement::SVGPatternElement):
1163         (WebCore::SVGPatternElement::~SVGPatternElement):
1164         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1165         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1166         (WebCore::SVGPatternElement::canvasResource):
1167         * ksvg2/svg/SVGPatternElement.h:
1168         * ksvg2/svg/SVGRadialGradientElement.cpp:
1169         (WebCore::SVGRadialGradientElement::buildGradient):
1170         * ksvg2/svg/SVGRadialGradientElement.h:
1171         * ksvg2/svg/SVGStyledElement.h:
1172         (WebCore::SVGStyledElement::canvasResource):
1173         * platform/GraphicsContext.cpp: Removed.
1174         * platform/GraphicsContext.h: Removed.
1175         * platform/GraphicsTypes.cpp: Removed.
1176         * platform/GraphicsTypes.h: Removed.
1177         * platform/graphics/GraphicsContext.cpp:
1178         (WebCore::GraphicsContextState::GraphicsContextState):
1179         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1180         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1181         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1182         (WebCore::GraphicsContext::save):
1183         (WebCore::GraphicsContext::restore):
1184         (WebCore::GraphicsContext::font):
1185         (WebCore::GraphicsContext::setFont):
1186         (WebCore::GraphicsContext::pen):
1187         (WebCore::GraphicsContext::setPen):
1188         (WebCore::GraphicsContext::setFillColor):
1189         (WebCore::GraphicsContext::fillColor):
1190         (WebCore::GraphicsContext::updatingControlTints):
1191         (WebCore::GraphicsContext::setUpdatingControlTints):
1192         (WebCore::GraphicsContext::setPaintingDisabled):
1193         (WebCore::GraphicsContext::paintingDisabled):
1194         (WebCore::GraphicsContext::drawImage):
1195         (WebCore::GraphicsContext::drawText):
1196         (WebCore::GraphicsContext::drawHighlightForText):
1197         (WebCore::GraphicsContext::initFocusRing):
1198         (WebCore::GraphicsContext::clearFocusRing):
1199         (WebCore::GraphicsContext::focusRingBoundingRect):
1200         (WebCore::GraphicsContext::addFocusRingRect):
1201         (WebCore::GraphicsContext::focusRingWidth):
1202         (WebCore::GraphicsContext::focusRingOffset):
1203         (WebCore::GraphicsContext::focusRingRects):
1204         (WebCore::GraphicsContext::drawTiledImage):
1205         * platform/graphics/GraphicsContext.h:
1206         * platform/graphics/GraphicsTypes.cpp:
1207         (WebCore::):
1208         (WebCore::parseCompositeOperator):
1209         (WebCore::compositeOperatorName):
1210         (WebCore::parseLineCap):
1211         (WebCore::lineCapName):
1212         (WebCore::parseLineJoin):
1213         (WebCore::lineJoinName):
1214         * platform/graphics/GraphicsTypes.h:
1215         (WebCore::):
1216         * platform/graphics/svg/SVGResource.cpp: Added.
1217         (WebCore::SVGResource::SVGResource):
1218         (WebCore::SVGResource::~SVGResource):
1219         (WebCore::SVGResource::invalidate):
1220         (WebCore::SVGResource::addClient):
1221         (WebCore::SVGResource::clients):
1222         (WebCore::SVGResource::idInRegistry):
1223         (WebCore::SVGResource::setIdInRegistry):
1224         (WebCore::SVGResource::externalRepresentation):
1225         (WebCore::getResourceById):
1226         (WebCore::getPaintServerById):
1227         (WebCore::operator<<):
1228         * platform/graphics/svg/SVGResource.h: Added.
1229         (WebCore::):
1230         (WebCore::SVGResource::isPaintServer):
1231         (WebCore::SVGResource::isFilter):
1232         (WebCore::SVGResource::isClipper):
1233         (WebCore::SVGResource::isMarker):
1234         (WebCore::SVGResource::isMasker):
1235         (WebCore::SVGResourceListener::~SVGResourceListener):
1236         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1237         (WebCore::SVGResourceClipper::SVGResourceClipper):
1238         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1239         (WebCore::SVGResourceClipper::resetClipData):
1240         (WebCore::SVGResourceClipper::addClipData):
1241         (WebCore::SVGResourceClipper::clipData):
1242         (WebCore::SVGResourceClipper::externalRepresentation):
1243         (WebCore::operator<<):
1244         (WebCore::getClipperById):
1245         * platform/graphics/svg/SVGResourceClipper.h: Added.
1246         (WebCore::ClipDataList::addPath):
1247         (WebCore::SVGResourceClipper::isClipper):
1248         * platform/graphics/svg/SVGResourceImage.h: Added.
1249         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1250         (WebCore::SVGResourceMarker::SVGResourceMarker):
1251         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1252         (WebCore::SVGResourceMarker::setMarker):
1253         (WebCore::SVGResourceMarker::setRef):
1254         (WebCore::SVGResourceMarker::draw):
1255         (WebCore::SVGResourceMarker::externalRepresentation):
1256         (WebCore::getMarkerById):
1257         * platform/graphics/svg/SVGResourceMarker.h: Added.
1258         (WebCore::SVGResourceMarker::refX):
1259         (WebCore::SVGResourceMarker::refY):
1260         (WebCore::SVGResourceMarker::setAngle):
1261         (WebCore::SVGResourceMarker::setAutoAngle):
1262         (WebCore::SVGResourceMarker::angle):
1263         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1264         (WebCore::SVGResourceMarker::useStrokeWidth):
1265         (WebCore::SVGResourceMarker::isMarker):
1266         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1267         (WebCore::SVGResourceMasker::SVGResourceMasker):
1268         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1269         (WebCore::SVGResourceMasker::setMask):
1270         (WebCore::SVGResourceMasker::mask):
1271         (WebCore::SVGResourceMasker::externalRepresentation):
1272         (WebCore::getMaskerById):
1273         * platform/graphics/svg/SVGResourceMasker.h: Added.
1274         (WebCore::SVGResourceMasker::isMasker):
1275         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1276         (WebCore::SVGResourceClipper::applyClip):
1277         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1278         (WebCore::SVGResourceImage::SVGResourceImage):
1279         (WebCore::SVGResourceImage::~SVGResourceImage):
1280         (WebCore::SVGResourceImage::init):
1281         (WebCore::SVGResourceImage::size):
1282         (WebCore::SVGResourceImage::cgLayer):
1283         (WebCore::SVGResourceImage::setCGLayer):
1284         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1285         (WebCore::applyLuminanceToAlphaFilter):
1286         (WebCore::applyExpandAlphatoGrayscaleFilter):
1287         (WebCore::transformImageIntoGrayscaleMask):
1288         (WebCore::SVGResourceMasker::applyMask):
1289         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1290         (WebCore::SVGResourceClipper::applyClip):
1291         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1292         (WebCore::SVGResourceImage::init):
1293         (WebCore::SVGResourceImage::size):
1294         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1295         (WebCore::SVGResourceMasker::applyMask):
1296         * platform/qt/GraphicsContextQt.cpp:
1297         * rendering/RenderPath.cpp:
1298         (WebCore::RenderPath::paint):
1299         (WebCore::DrawMarkersData::DrawMarkersData):
1300         (WebCore::RenderPath::drawMarkersIfNeeded):
1301         * rendering/RenderSVGContainer.cpp:
1302         (WebCore::RenderSVGContainer::paint):
1303         * rendering/RenderSVGImage.cpp:
1304         (WebCore::RenderSVGImage::paint):
1305         * rendering/SVGInlineFlowBox.cpp:
1306         (WebCore::paintSVGInlineFlow):
1307
1308 2006-10-30  John Sullivan  <sullivan@apple.com>
1309
1310         Reviewed by Brady
1311         
1312         - minor cleanup to make future patches clearer
1313
1314         * bridge/mac/FrameMac.mm:
1315         (WebCore::FrameMac::advanceToNextMisspelling):
1316         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1317         with "continue" to better match structure of similar code in markMisspellings; a few
1318         other style tweaks.
1319         
1320         (WebCore::FrameMac::markMisspellings):
1321         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1322         a block just after a break and outdented accordingly.
1323
1324 2006-10-30  John Sullivan  <sullivan@apple.com>
1325
1326         Reviewed by Geoff Garen
1327         
1328         WebCore part of change to push the code that updates the spelling panel
1329         into WebCore, in preparation for some grammar-checking stuff.
1330
1331         * bridge/mac/FrameMac.h:
1332         * bridge/mac/FrameMac.mm:
1333         (WebCore::FrameMac::advanceToNextMisspelling):
1334         no more return value for this method, and update the spelling panel with
1335         the misspelled word here rather than in the WebKit callers.
1336
1337 2006-10-30  Oliver Hunt  <oliver@apple.com>
1338
1339         Reviewed by Anders.
1340
1341         Roll out last patch
1342
1343         * CMakeLists.txt:
1344         * ChangeLog:
1345         * WebCore.xcodeproj/project.pbxproj:
1346         * graphics/svg/SVGResource.cpp:
1347         * graphics/svg/SVGResourceClipper.cpp:
1348         * graphics/svg/SVGResourceClipper.h:
1349         * graphics/svg/SVGResourceImage.h:
1350         * graphics/svg/SVGResourceListener.h:
1351         * graphics/svg/SVGResourceMarker.cpp:
1352         * graphics/svg/SVGResourceMarker.h:
1353         * graphics/svg/SVGResourceMasker.cpp:
1354         * graphics/svg/SVGResourceMasker.h:
1355         * kcanvas/KCanvasClipper.cpp: Added.
1356         (WebCore::operator<<):
1357         (WebCore::KCanvasClipper::KCanvasClipper):
1358         (WebCore::KCanvasClipper::~KCanvasClipper):
1359         (WebCore::KCanvasClipper::resetClipData):
1360         (WebCore::KCanvasClipper::addClipData):
1361         (WebCore::KCanvasClipper::clipData):
1362         (WebCore::KCanvasClipper::externalRepresentation):
1363         (WebCore::getClipperById):
1364         * kcanvas/KCanvasClipper.h: Added.
1365         (WebCore::KCClipData::windRule):
1366         (WebCore::KCClipDataList::KCClipDataList):
1367         (WebCore::KCClipDataList::addPath):
1368         (WebCore::KCanvasClipper::isClipper):
1369         * kcanvas/KCanvasFilters.cpp:
1370         (WebCore::getFilterById):
1371         * kcanvas/KCanvasFilters.h:
1372         * kcanvas/KCanvasImage.h: Added.
1373         (WebCore::KCanvasImage::KCanvasImage):
1374         (WebCore::KCanvasImage::~KCanvasImage):
1375         * kcanvas/KCanvasMarker.cpp: Added.
1376         (WebCore::KCanvasMarker::KCanvasMarker):
1377         (WebCore::KCanvasMarker::~KCanvasMarker):
1378         (WebCore::KCanvasMarker::setMarker):
1379         (WebCore::KCanvasMarker::setRef):
1380         (WebCore::KCanvasMarker::refX):
1381         (WebCore::KCanvasMarker::refY):
1382         (WebCore::KCanvasMarker::setAngle):
1383         (WebCore::KCanvasMarker::angle):
1384         (WebCore::KCanvasMarker::setAutoAngle):
1385         (WebCore::KCanvasMarker::setUseStrokeWidth):
1386         (WebCore::KCanvasMarker::useStrokeWidth):
1387         (WebCore::KCanvasMarker::draw):
1388         (WebCore::KCanvasMarker::externalRepresentation):
1389         (WebCore::getMarkerById):
1390         * kcanvas/KCanvasMarker.h: Added.
1391         (WebCore::KCanvasMarker::isMarker):
1392         * kcanvas/KCanvasMasker.cpp: Added.
1393         (WebCore::KCanvasMasker::KCanvasMasker):
1394         (WebCore::KCanvasMasker::~KCanvasMasker):
1395         (WebCore::KCanvasMasker::setMask):
1396         (WebCore::KCanvasMasker::externalRepresentation):
1397         (WebCore::getMaskerById):
1398         * kcanvas/KCanvasMasker.h: Added.
1399         (WebCore::KCanvasMasker::isMasker):
1400         (WebCore::KCanvasMasker::mask):
1401         * kcanvas/KCanvasResource.cpp: Added.
1402         (WebCore::operator<<):
1403         (WebCore::KCanvasResource::KCanvasResource):
1404         (WebCore::KCanvasResource::~KCanvasResource):
1405         (WebCore::KCanvasResource::addClient):
1406         (WebCore::KCanvasResource::clients):
1407         (WebCore::KCanvasResource::invalidate):
1408         (WebCore::KCanvasResource::idInRegistry):
1409         (WebCore::KCanvasResource::setIdInRegistry):
1410         (WebCore::KCanvasResource::externalRepresentation):
1411         (WebCore::getResourceById):
1412         (WebCore::getPaintServerById):
1413         * kcanvas/KCanvasResource.h:
1414         (WebCore::):
1415         (WebCore::KCanvasResource::isPaintServer):
1416         (WebCore::KCanvasResource::isFilter):
1417         (WebCore::KCanvasResource::isClipper):
1418         (WebCore::KCanvasResource::isMarker):
1419         (WebCore::KCanvasResource::isMasker):
1420         * kcanvas/KCanvasResourceListener.h: Added.
1421         (KCanvasResourceListener::KCanvasResourceListener):
1422         (KCanvasResourceListener::~KCanvasResourceListener):
1423         * kcanvas/KCanvasTreeDebug.cpp:
1424         (WebCore::writeRenderResources):
1425         * kcanvas/device/KRenderingDevice.h:
1426         * kcanvas/device/KRenderingPaintServer.h:
1427         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1428         (WebCore::KRenderingPaintServer::idInRegistry):
1429         (WebCore::KRenderingPaintServer::setIdInRegistry):
1430         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1431         (WebCore::KRenderingPaintServerGradient::listener):
1432         (WebCore::KRenderingPaintServerGradient::setListener):
1433         * kcanvas/device/KRenderingPaintServerGradient.h:
1434         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1435         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1436         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1437         (WebCore::KRenderingPaintServerPattern::tile):
1438         (WebCore::KRenderingPaintServerPattern::setTile):
1439         (WebCore::KRenderingPaintServerPattern::listener):
1440         (WebCore::KRenderingPaintServerPattern::setListener):
1441         * kcanvas/device/KRenderingPaintServerPattern.h:
1442         * kcanvas/device/KRenderingPaintServerSolid.h:
1443         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1444         (WebCore::KCanvasClipperQt::applyClip):
1445         * kcanvas/device/qt/KCanvasClipperQt.h:
1446         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1447         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1448         (WebCore::KRenderingDeviceQt::contextForImage):
1449         (WebCore::KRenderingDeviceQt::createResource):
1450         (WebCore::KRenderingDeviceQt::createPaintServer):
1451         * kcanvas/device/qt/KRenderingDeviceQt.h:
1452         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1453         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1454         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1455         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1456         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1457         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1458         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1459         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1460         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1461         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1462         (WebCore::applyLuminanceToAlphaFilter):
1463         (WebCore::applyExpandAlphatoGrayscaleFilter):
1464         (WebCore::transformImageIntoGrayscaleMask):
1465         (WebCore::KCanvasMaskerQuartz::applyMask):
1466         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1467         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1468         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1469         (WebCore::KCanvasImageQuartz::init):
1470         (WebCore::KCanvasImageQuartz::size):
1471         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1472         (WebCore::KCanvasClipperQuartz::applyClip):
1473         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1474         (WebCore::KCanvasImageQuartz::cgLayer):
1475         (WebCore::KCanvasImageQuartz::setCGLayer):
1476         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1477         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1478         (WebCore::KRenderingDeviceQuartz::contextForImage):
1479         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1480         (WebCore::KRenderingDeviceQuartz::createResource):
1481         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1482         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1483         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1484         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1485         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1486         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1487         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1488         (WebCore::patternCallback):
1489         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1490         * kcanvas/device/quartz/QuartzSupport.mm:
1491         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1492         (WebCore::sharedSolidPaintServer):
1493         * ksvg2/svg/SVGClipPathElement.cpp:
1494         (WebCore::SVGClipPathElement::SVGClipPathElement):
1495         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1496         (WebCore::SVGClipPathElement::canvasResource):
1497         * ksvg2/svg/SVGClipPathElement.h:
1498         * ksvg2/svg/SVGFEImageElement.cpp:
1499         * ksvg2/svg/SVGFilterElement.cpp:
1500         (WebCore::SVGFilterElement::SVGFilterElement):
1501         (WebCore::SVGFilterElement::~SVGFilterElement):
1502         (WebCore::SVGFilterElement::canvasResource):
1503         * ksvg2/svg/SVGFilterElement.h:
1504         * ksvg2/svg/SVGGradientElement.cpp:
1505         (WebCore::SVGGradientElement::SVGGradientElement):
1506         (WebCore::SVGGradientElement::~SVGGradientElement):
1507         (WebCore::SVGGradientElement::canvasResource):
1508         (WebCore::SVGGradientElement::resourceNotification):
1509         * ksvg2/svg/SVGGradientElement.h:
1510         * ksvg2/svg/SVGImageElement.cpp:
1511         * ksvg2/svg/SVGLinearGradientElement.cpp:
1512         (WebCore::SVGLinearGradientElement::buildGradient):
1513         * ksvg2/svg/SVGLinearGradientElement.h:
1514         * ksvg2/svg/SVGMarkerElement.cpp:
1515         (WebCore::SVGMarkerElement::SVGMarkerElement):
1516         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1517         (WebCore::SVGMarkerElement::canvasResource):
1518         * ksvg2/svg/SVGMarkerElement.h:
1519         * ksvg2/svg/SVGMaskElement.cpp:
1520         (WebCore::SVGMaskElement::SVGMaskElement):
1521         (WebCore::SVGMaskElement::~SVGMaskElement):
1522         (WebCore::SVGMaskElement::drawMaskerContent):
1523         (WebCore::SVGMaskElement::canvasResource):
1524         * ksvg2/svg/SVGMaskElement.h:
1525         * ksvg2/svg/SVGPatternElement.cpp:
1526         (WebCore::SVGPatternElement::SVGPatternElement):
1527         (WebCore::SVGPatternElement::~SVGPatternElement):
1528         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1529         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1530         (WebCore::SVGPatternElement::canvasResource):
1531         * ksvg2/svg/SVGPatternElement.h:
1532         * ksvg2/svg/SVGRadialGradientElement.cpp:
1533         (WebCore::SVGRadialGradientElement::buildGradient):
1534         * ksvg2/svg/SVGRadialGradientElement.h:
1535         * ksvg2/svg/SVGStyledElement.h:
1536         (WebCore::SVGStyledElement::canvasResource):
1537         * platform/GraphicsContext.cpp: Added.
1538         (WebCore::GraphicsContextState::GraphicsContextState):
1539         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1540         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1541         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1542         (WebCore::GraphicsContext::save):
1543         (WebCore::GraphicsContext::restore):
1544         (WebCore::GraphicsContext::font):
1545         (WebCore::GraphicsContext::setFont):
1546         (WebCore::GraphicsContext::pen):
1547         (WebCore::GraphicsContext::setPen):
1548         (WebCore::GraphicsContext::setFillColor):
1549         (WebCore::GraphicsContext::fillColor):
1550         (WebCore::GraphicsContext::updatingControlTints):
1551         (WebCore::GraphicsContext::setUpdatingControlTints):
1552         (WebCore::GraphicsContext::setPaintingDisabled):
1553         (WebCore::GraphicsContext::paintingDisabled):
1554         (WebCore::GraphicsContext::drawImage):
1555         (WebCore::GraphicsContext::drawText):
1556         (WebCore::GraphicsContext::drawHighlightForText):
1557         (WebCore::GraphicsContext::initFocusRing):
1558         (WebCore::GraphicsContext::clearFocusRing):
1559         (WebCore::GraphicsContext::focusRingBoundingRect):
1560         (WebCore::GraphicsContext::addFocusRingRect):
1561         (WebCore::GraphicsContext::focusRingWidth):
1562         (WebCore::GraphicsContext::focusRingOffset):
1563         (WebCore::GraphicsContext::focusRingRects):
1564         (WebCore::GraphicsContext::drawTiledImage):
1565         * platform/GraphicsContext.h: Added.
1566         * platform/GraphicsTypes.cpp: Added.
1567         (WebCore::):
1568         (WebCore::parseCompositeOperator):
1569         (WebCore::compositeOperatorName):
1570         (WebCore::parseLineCap):
1571         (WebCore::lineCapName):
1572         (WebCore::parseLineJoin):
1573         (WebCore::lineJoinName):
1574         * platform/GraphicsTypes.h: Added.
1575         (WebCore::):
1576         * platform/graphics/GraphicsContext.cpp:
1577         * platform/graphics/GraphicsContext.h:
1578         * platform/graphics/GraphicsTypes.cpp:
1579         * platform/graphics/GraphicsTypes.h:
1580         * platform/qt/GraphicsContextQt.cpp:
1581         * rendering/RenderPath.cpp:
1582         (WebCore::RenderPath::paint):
1583         (WebCore::DrawMarkersData::DrawMarkersData):
1584         (WebCore::RenderPath::drawMarkersIfNeeded):
1585         * rendering/RenderSVGContainer.cpp:
1586         (WebCore::RenderSVGContainer::paint):
1587         * rendering/RenderSVGImage.cpp:
1588         (WebCore::RenderSVGImage::paint):
1589         * rendering/SVGInlineFlowBox.cpp:
1590         (WebCore::paintSVGInlineFlow):
1591
1592 2006-10-30  John Sullivan  <sullivan@apple.com>
1593
1594         Reviewed by Geoff Garen.
1595         
1596         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1597         grammar-related method.
1598
1599         * bridge/EditorClient.h:
1600         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1601         isGrammarCheckingEnabled()
1602         
1603         * bridge/mac/WebCoreFrameBridge.h:
1604         removed bridge equivalents
1605
1606         * bridge/mac/FrameMac.mm:
1607         (WebCore::FrameMac::advanceToNextMisspelling):
1608         convert bridge-using code to editor()->client()-using code
1609         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1610         ditto
1611         (WebCore::FrameMac::markMisspellings):
1612         ditto
1613         (WebCore::FrameMac::respondToChangedSelection):
1614         ditto
1615         
1616         * editing/Editor.h:
1617         * editing/Editor.cpp:
1618         (WebCore::Editor::client):
1619         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1620         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1621         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1622
1623 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1624
1625         Reviewed by Darin.
1626
1627         Removed a number of editing and selection methods from the bridge.
1628         
1629         I moved cross-platform editing and selection code into Editor and 
1630         SelectionController, respecitvely.
1631
1632         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1633         everything + the kitchen sink.
1634         
1635         Specific comments below for interesting things.
1636         
1637         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1638         a new file so that WebKit can use them, too. Added a helper method for
1639         handling exceptions when selecting a Range.
1640         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1641         WebKit, since they have to do with creating an NSAttributedString for API
1642         consumption, and not much to do with general Frame functionality.
1643         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1644         for now) into the Editor. Eventually, the Frame will not have to notify 
1645         the Editor of what the lastEditCommand was, since the Editor will perform
1646         all EditCommands.
1647         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1648         * editing/SelectionController.cpp:
1649         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1650         and return them. The bridge method to select a DOM range did this implicitly,
1651         since all ObjC DOM operations handle DOM exceptions by throwing them as
1652         ObjC exceptions.
1653         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1654         The two enumerations are numerically identical, but that's an implementation
1655         detail of TextAffinity that clients shouldn't be required to know about.
1656
1657 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1658
1659         Rolling out the following change because this crash:
1660         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1661
1662         And this regression:
1663         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1664
1665     2006-09-06  David Harrison  <harrison@apple.com>
1666
1667         Reviewed and tweaked by Tim H. 
1668
1669         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1670
1671         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1672         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1673         No layout tests affected. Not testable in an automated way that will work on all systems. 
1674
1675         * platform/mac/WebFontCache.mm: 
1676         (+[WebFontCache fontWithFamily:traits:size:]): 
1677
1678 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1679
1680         Reviewed by harrison
1681
1682         <rdar://problem/4808375>
1683         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1684
1685         * editing/TextIterator.cpp:
1686         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1687         when we're going to use them to create a range for an emitted character.
1688         We should further speed TextIterators up by avoiding creating VisiblePositions
1689         for TIs that are only used for the characters they emit (like the one that 
1690         plainText uses).
1691
1692 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1693
1694         Reviewed by Mitz.
1695
1696         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1697         More rendering code cleaning
1698
1699         * WebCore.xcodeproj/project.pbxproj:
1700         * rendering/RenderApplet.cpp:
1701         (WebCore::RenderApplet::RenderApplet):
1702         (WebCore::RenderApplet::createWidgetIfNecessary):
1703         * rendering/RenderApplet.h:
1704         * rendering/RenderArena.cpp:
1705         (WebCore::):
1706         (WebCore::RenderArena::RenderArena):
1707         (WebCore::RenderArena::allocate):
1708         (WebCore::RenderArena::free):
1709         * rendering/RenderArena.h:
1710         * rendering/RenderBR.cpp:
1711         (WebCore::RenderBR::RenderBR):
1712         (WebCore::RenderBR::baselinePosition):
1713         (WebCore::RenderBR::lineHeight):
1714         (WebCore::RenderBR::setStyle):
1715         (WebCore::RenderBR::caretMinOffset):
1716         (WebCore::RenderBR::positionForCoordinates):
1717         (WebCore::RenderBR::inlineBox):
1718         * rendering/RenderBR.h:
1719         * rendering/RenderBlock.cpp:
1720         * rendering/RenderBlock.h:
1721         (WebCore::RenderBlock::maxTopMargin):
1722         (WebCore::RenderBlock::maxBottomMargin):
1723         (WebCore::RenderBlock::initMaxMarginValues):
1724         (WebCore::RenderBlock::containsFloats):
1725         (WebCore::RenderBlock::setHasMarkupTruncation):
1726         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1727         (WebCore::RenderBlock::BlockSelectionInfo::block):
1728         (WebCore::RenderBlock::BlockSelectionInfo::state):
1729         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1730         (WebCore::RenderBlock::CompactInfo::clear):
1731         * rendering/RenderButton.cpp:
1732         (WebCore::RenderButton::removeChild):
1733         (WebCore::RenderButton::paintObject):
1734         * rendering/RenderButton.h:
1735         (WebCore::RenderButton::renderName):
1736         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1737         * rendering/RenderContainer.cpp:
1738         (WebCore::RenderContainer::RenderContainer):
1739         * rendering/RenderContainer.h:
1740         (WebCore::RenderContainer::firstChild):
1741         (WebCore::RenderContainer::lastChild):
1742         (WebCore::RenderContainer::calcMinMaxWidth):
1743         * rendering/RenderCounter.cpp:
1744         (WebCore::RenderCounter::RenderCounter):
1745         (WebCore::toRoman):
1746         (WebCore::toHebrew):
1747         (WebCore::RenderCounter::calcMinMaxWidth):
1748         * rendering/RenderCounter.h:
1749         * rendering/RenderFieldset.cpp:
1750         (WebCore::RenderFieldset::paintBoxDecorations):
1751         (WebCore::RenderFieldset::paintBorderMinusLegend):
1752         (WebCore::RenderFieldset::setStyle):
1753         * rendering/RenderFileUploadControl.cpp:
1754         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1755         (WebCore::RenderFileUploadControl::setStyle):
1756         (WebCore::RenderFileUploadControl::paintObject):
1757         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1758         * rendering/RenderFileUploadControl.h:
1759         (WebCore::RenderFileUploadControl::renderName):
1760         * rendering/RenderFlexibleBox.h:
1761         * rendering/RenderFlow.cpp:
1762         * rendering/RenderFlow.h:
1763         * rendering/RenderForeignObject.cpp:
1764         (WebCore::RenderForeignObject::RenderForeignObject):
1765         (WebCore::RenderForeignObject::paint):
1766         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1767         (WebCore::RenderForeignObject::layout):
1768         (WebCore::RenderForeignObject::nodeAtPoint):
1769         * rendering/RenderForeignObject.h:
1770         (WebCore::RenderForeignObject::renderName):
1771         * rendering/RenderFormElement.cpp:
1772         (WebCore::RenderFormElement::setStyle):
1773         (WebCore::RenderFormElement::layout):
1774         (WebCore::RenderFormElement::textAlignment):
1775         * rendering/RenderFormElement.h:
1776         * rendering/RenderFrame.cpp:
1777         * rendering/RenderFrame.h:
1778         (WebCore::RenderFrame::element):
1779         * rendering/RenderFrameSet.cpp:
1780         * rendering/RenderFrameSet.h:
1781         (WebCore::RenderFrameSet::element):
1782         * rendering/RenderHTMLCanvas.cpp:
1783         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1784         (WebCore::RenderHTMLCanvas::paint):
1785         * rendering/RenderHTMLCanvas.h:
1786         (WebCore::RenderHTMLCanvas::renderName):
1787         * rendering/RenderImage.cpp:
1788         (WebCore::RenderImage::RenderImage):
1789         (WebCore::RenderImage::setStyle):
1790         (WebCore::RenderImage::setContentObject):
1791         (WebCore::RenderImage::setCachedImage):
1792         (WebCore::RenderImage::imageChanged):
1793         (WebCore::RenderImage::paint):
1794         (WebCore::RenderImage::layout):
1795         (WebCore::RenderImage::updateAltText):
1796         * rendering/RenderImage.h:
1797         (WebCore::RenderImage::element):
1798         * rendering/RenderInline.cpp:
1799         (WebCore::RenderInline::RenderInline):
1800         (WebCore::RenderInline::~RenderInline):
1801         (WebCore::RenderInline::setStyle):
1802         (WebCore::RenderInline::addChildToFlow):
1803         (WebCore::RenderInline::cloneInline):
1804         (WebCore::RenderInline::splitInlines):
1805         (WebCore::RenderInline::splitFlow):
1806         (WebCore::RenderInline::paint):
1807         (WebCore::RenderInline::absoluteRects):
1808         (WebCore::RenderInline::calcMinMaxWidth):
1809         (WebCore::RenderInline::requiresLayer):
1810         (WebCore::RenderInline::width):
1811         (WebCore::RenderInline::height):
1812         (WebCore::RenderInline::renderName):
1813         (WebCore::RenderInline::nodeAtPoint):
1814         (WebCore::RenderInline::positionForCoordinates):
1815         * rendering/RenderInline.h:
1816         (WebCore::RenderInline::layout):
1817         * rendering/RenderLayer.cpp:
1818         * rendering/RenderLayer.h:
1819         (WebCore::ClipRects::ClipRects):
1820         (WebCore::RenderLayer::nextSibling):
1821         (WebCore::RenderLayer::root):
1822         (WebCore::RenderLayer::setPos):
1823         (WebCore::RenderLayer::height):
1824         (WebCore::RenderLayer::relativePositionOffset):
1825         * rendering/RenderLineEdit.cpp:
1826         (WebCore::RenderLineEdit::setStyle):
1827         (WebCore::RenderLineEdit::updateFromElement):
1828         (WebCore::RenderLineEdit::selectionStart):
1829         (WebCore::RenderLineEdit::selectionEnd):
1830         (WebCore::RenderLineEdit::setSelectionStart):
1831         (WebCore::RenderLineEdit::setSelectionEnd):
1832         (WebCore::RenderLineEdit::setSelectionRange):
1833         * rendering/RenderLineEdit.h:
1834         * rendering/RenderListBox.cpp:
1835         * rendering/RenderListBox.h:
1836         (WebCore::RenderListBox::renderName):
1837         * rendering/RenderListItem.cpp:
1838         (WebCore::RenderListItem::setStyle):
1839         (WebCore::getParentOfFirstLineBox):
1840         (WebCore::RenderListItem::updateMarkerLocation):
1841         (WebCore::RenderListItem::positionListMarker):
1842         (WebCore::RenderListItem::paint):
1843         * rendering/RenderListItem.h:
1844         * rendering/RenderListMarker.cpp:
1845         * rendering/RenderListMarker.h:
1846         (WebCore::RenderListMarker::renderName):
1847         (WebCore::RenderListMarker::isListMarker):
1848
1849 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1850
1851         Reviewed by Hyatt.
1852
1853         <rdar://problem/4478625> Basic table editing and culling
1854
1855         Refined the criteria for deletable elements, rely on the renderer more.
1856         Corrected the interface positioning for elements that have borders.
1857
1858         * editing/DeleteButtonController.cpp:
1859         (WebCore::isDeletableElement):
1860         (WebCore::DeleteButtonController::show):
1861
1862 2006-10-30  Darin Adler  <darin@apple.com>
1863
1864         - fix build
1865
1866         * loader/ResourceLoader.h: Added header guard.
1867
1868 2006-10-31  Darin Adler  <darin@apple.com>
1869
1870         Reviewed by Adam.
1871
1872         - fix FrameLoader files so they can be built on non-Mac platforms
1873
1874         * page/FramePrivate.h:
1875         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1876         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1877
1878         * page/Page.h:
1879         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1880         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1881         the other day.
1882
1883         * bridge/mac/FrameMac.mm:
1884         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1885         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1886
1887         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1888         around the PolicyCheck definition.
1889
1890         * loader/FormState.cpp: Changed import to include.
1891         * loader/FrameLoader.cpp: Ditto.
1892         * loader/MainResourceLoader.h: Ditto.
1893
1894         * loader/FrameLoaderTypes.h: Added a header guard.
1895
1896         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1897         Added #if PLATFORM(MAC) around Mac-specific details.
1898         * loader/SubresourceLoader.h: Ditto.
1899
1900         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1901         m_loader from m_frameLoader.
1902
1903         * CMakeLists.txt: Updated.
1904         * WebCoreSources.bkl: Updated.
1905
1906 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1907
1908         Reviewed and landed by Anders.
1909
1910         Patch by Zack rusin to fix: 
1911         http://bugs.webkit.org/show_bug.cgi?id=11429
1912
1913         Fix startup crash.
1914
1915         * platform/qt/FrameQtClient.cpp:
1916         (WebCore::FrameQtClientDefault::openURL):
1917
1918 2006-10-30  Zach Rusin  <zack@kde.org>
1919
1920         Reviewed and landed by Anders.
1921
1922         * platform/network/qt/ResourceHandleQt.cpp:
1923         (WebCore::ResourceHandle::receivedResponse):
1924         * platform/qt/FrameQtClient.cpp:
1925         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1926         * platform/qt/LoaderFunctionsQt.cpp:
1927         (WebCore::ServeSynchronousRequest):
1928         More build fixes.
1929
1930 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1931
1932         Reviewed and landed by Anders.
1933         
1934         - fix Qt build
1935         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1936         ResourceHandleClient
1937
1938 2006-10-30  Darin Adler  <darin@apple.com>
1939
1940         Reviewed by John Sullivan.
1941
1942         - work toward removing Objective-C data types from FrameLoader.h:
1943           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1944           and WebCoreResourceHandle
1945         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1946
1947         * page/PageState.h:
1948         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1949
1950         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1951         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1952         double for the date instead of an NSDate.
1953
1954         * bridge/mac/WebCoreFrameBridge.h:
1955         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1956         saveDocumentToPageCache methods.
1957
1958         * bridge/mac/WebCorePageState.h:
1959         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1960         an Objective-C wrapper for PageState.
1961
1962         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1963         NSDate and WebCorePageState.
1964         * loader/FrameLoaderClient.h: Changed NSDate to double.
1965         * loader/mac/FrameLoaderMac.mm:
1966         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1967         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1968         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1969         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1970         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1971         extract the parameters from the response. Changed the open function that takes
1972         a PageState to use the new C++ PageState.
1973         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1974         function; tightened up logic, removing a few cases that could never happen, as
1975         well as the unused reload boolean.
1976
1977         * ForwardingHeaders/kjs/property_map.h: Added.
1978
1979         * WebCore.exp: Updated.
1980         * WebCore.xcodeproj/project.pbxproj: Updated.
1981
1982 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1983
1984         Reviewed by Anders.
1985
1986         - added ResourceResponse class and didReceiveResponse delegate call
1987         
1988         * WebCore.xcodeproj/project.pbxproj: Added new files.
1989         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1990         expiresTimeForResponse: method.
1991         * dom/XMLTokenizer.cpp:
1992         (WebCore::openFunc): Updated to use ResourceResponse.
1993         * loader/FrameLoader.h: Update loadResourceSynchronously to
1994         use ResourceResponse.
1995         * loader/LoaderFunctions.h:
1996         * loader/icon/IconLoader.cpp:
1997         (IconLoader::didReceiveResponse): Updated from receivedResponse
1998         and made cross-platform.
1999         * loader/icon/IconLoader.h: updated for above change
2000         * loader/loader.cpp:
2001         (WebCore::Loader::receivedResponse): reduced to just saving
2002         the PlatformResponse (ideally we'd phase out use of this).
2003         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
2004         logic.
2005         * loader/loader.h:
2006         * loader/mac/FrameLoaderMac.mm:
2007         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2008         as ResourceResponse.
2009         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2010         * loader/mac/LoaderFunctionsMac.mm:
2011         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2012         argument.
2013         * platform/network/ResourceHandle.cpp:
2014         * platform/network/ResourceHandle.h: Remove calls for
2015         broken out response pieces.
2016         * platform/network/ResourceHandleClient.h:
2017         (WebCore::ResourceHandleClient::didReceiveResponse): New
2018         delegate method.
2019         * platform/network/ResourceHandleInternal.h:
2020         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2021         storage of response bits, we're not gonna return them
2022         seprately any more.
2023         * platform/network/ResourceResponse.h: Added.
2024         (WebCore::ResourceResponse::ResourceResponse): Freshly
2025         implemented. Same for below.
2026         (WebCore::ResourceResponse::url):
2027         (WebCore::ResourceResponse::mimeType):
2028         (WebCore::ResourceResponse::expectedContentLength):
2029         (WebCore::ResourceResponse::textEncodingName):
2030         (WebCore::ResourceResponse::suggestedFilename):
2031         (WebCore::ResourceResponse::httpStatusCode):
2032         (WebCore::ResourceResponse::setHTTPStatusCode):
2033         (WebCore::ResourceResponse::httpHeaderField):
2034         (WebCore::ResourceResponse::httpHeaderFields):
2035         (WebCore::ResourceResponse::isMultipart):
2036         (WebCore::ResourceResponse::setExpirationDate):
2037         (WebCore::ResourceResponse::expirationDate):
2038         * platform/network/cf/ResourceHandleCFNet.cpp:
2039         (WebCore::didReceiveResponse): Send didReceiveResponse
2040         client method.
2041         * platform/network/cf/ResourceResponseCFNet.h: Added.
2042         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2043         (getResourceResponse): Helper function to get a ResourceResponse 
2044         from CFURLResponseRef.
2045         * platform/network/mac/ResourceHandleMac.mm:
2046         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2047         Don't bother cleaning up fields we no longer have.
2048         (WebCore::ResourceHandle::receivedResponse): Send
2049         didReceiveResponse client method.
2050         * platform/network/mac/ResourceResponseMac.h: Added.
2051         * platform/network/mac/ResourceResponseMac.mm: Added.
2052         (getResourceResponse): Helper function to get a ResourceResponse 
2053         from an NSURLResponse*.
2054         * rendering/HitTestResult.cpp:
2055         * xml/XSLTProcessor.cpp:
2056         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2057         * xml/xmlhttprequest.cpp:
2058         (WebCore::XMLHttpRequest::getResponseText): Store http response
2059         info in the form of a ResourceResponse, change all methods to
2060         account for this.
2061         (WebCore::XMLHttpRequest::getResponseXML):
2062         (WebCore::XMLHttpRequest::XMLHttpRequest):
2063         (WebCore::XMLHttpRequest::open):
2064         (WebCore::XMLHttpRequest::send):
2065         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2066         (WebCore::XMLHttpRequest::getResponseHeader):
2067         (WebCore::XMLHttpRequest::getStatus):
2068         (WebCore::XMLHttpRequest::getStatusText):
2069         (WebCore::XMLHttpRequest::processSyncLoadResults):
2070         (WebCore::XMLHttpRequest::didFinishLoading):
2071         (WebCore::XMLHttpRequest::didReceiveResponse):
2072         (WebCore::XMLHttpRequest::didReceiveData):
2073         * xml/xmlhttprequest.h:
2074
2075 2006-10-29  Darin Adler  <darin@apple.com>
2076
2077         - fix build
2078
2079         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2080         * loader/NetscapePlugInStreamLoader.h: Ditto.
2081         * loader/ResourceLoader.h: Ditto.
2082
2083 2006-10-29  Darin Adler  <darin@apple.com>
2084
2085         - one last name change -- WebFormState.h to FormState.h
2086         - added more empty placeholder platform-independent files
2087           for currently-Mac-specific loader classes
2088
2089         * loader/FormState.cpp: Updated include.
2090         * loader/FrameLoader.cpp: Updated include.
2091         * loader/mac/FrameLoaderMac.mm: Updated include.
2092
2093         * loader/WebFormState.h: Removed.
2094         * loader/FormState.h: Added.
2095
2096         * loader/DocumentLoader.cpp: Added.
2097         * loader/MainResourceLoader.cpp: Added.
2098         * loader/NetscapePlugInStreamLoader.cpp: Added.
2099         * loader/ResourceLoader.cpp: Added.
2100         * loader/SubresourceLoader.cpp: Added.
2101
2102         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2103
2104 2006-10-29  Darin Adler  <darin@apple.com>
2105
2106         - did the do-webcore-rename renames, including a number of changes
2107           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2108           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2109           and improvements to the names of decoder classes and their source
2110           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2111
2112         * CMakeLists.txt:
2113         * WebCore.exp:
2114         * WebCore.vcproj/WebCore/WebCore.vcproj:
2115         * WebCore.xcodeproj/project.pbxproj:
2116         * WebCoreSources.bkl:
2117         * bindings/js/kjs_binding.cpp:
2118         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2119         * bindings/js/kjs_events.cpp:
2120         (KJS::JSAbstractEventListener::handleEvent):
2121         (KJS::JSLazyEventListener::parseCode):
2122         * bindings/js/kjs_html.cpp:
2123         (KJS::JSHTMLElement::implementsCall):
2124         * bindings/js/kjs_traversal.cpp:
2125         (KJS::JSNodeFilterCondition::acceptNode):
2126         * bindings/js/kjs_window.cpp:
2127         (KJS::Window::interpreter):
2128         (KJS::Window::retrieveWindow):
2129         (KJS::Window::retrieve):
2130         (KJS::ScheduledAction::execute):
2131         * bindings/objc/DOMInternal.mm:
2132         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2133         * bridge/mac/FrameMac.mm:
2134         (WebCore::FrameMac::executionContextForDOM):
2135         (WebCore::FrameMac::bindingRootObject):
2136         (WebCore::FrameMac::windowScriptObject):
2137         (WebCore::FrameMac::windowScriptNPObject):
2138         (WebCore::FrameMac::partClearedInBegin):
2139         * bridge/mac/WebCoreEncodings.mm:
2140         * bridge/mac/WebCoreFrameBridge.mm:
2141         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2142         (-[WebCoreFrameBridge stringWithData:]):
2143         (-[WebCoreFrameBridge executionContextForView:]):
2144         * bridge/win/FrameWin.cpp:
2145         * dom/Document.cpp:
2146         (WebCore::Document::inputEncoding):
2147         (WebCore::Document::setCharset):
2148         (WebCore::Document::createHTMLEventListener):
2149         (WebCore::Document::setDecoder):
2150         * dom/Document.h:
2151         (WebCore::Document::decoder):
2152         * dom/EventTargetNode.cpp:
2153         (WebCore::EventTargetNode::dispatchGenericEvent):
2154         * html/HTMLParser.cpp:
2155         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2156         (WebCore::HTMLParser::canvasCreateErrorCheck):
2157         (WebCore::HTMLParser::isInline):
2158         * html/HTMLPlugInElement.cpp:
2159         (WebCore::HTMLPlugInElement::createNPObject):
2160         * html/HTMLScriptElement.cpp:
2161         (WebCore::HTMLScriptElement::evaluateScript):
2162         * html/HTMLTokenizer.cpp:
2163         (WebCore::HTMLTokenizer::parseTag):
2164         (WebCore::HTMLTokenizer::processToken):
2165         * ksvg2/misc/SVGDocumentExtensions.cpp:
2166         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2167         * loader/CachedCSSStyleSheet.cpp:
2168         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2169         (WebCore::CachedCSSStyleSheet::setEncoding):
2170         * loader/CachedCSSStyleSheet.h:
2171         * loader/CachedXBLDocument.cpp:
2172         (WebCore::CachedXBLDocument::CachedXBLDocument):
2173         (WebCore::CachedXBLDocument::setEncoding):
2174         * loader/CachedXBLDocument.h:
2175         * loader/CachedXSLStyleSheet.cpp:
2176         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2177         (WebCore::CachedXSLStyleSheet::setEncoding):
2178         * loader/CachedXSLStyleSheet.h:
2179         * loader/Decoder.cpp: Removed.
2180         * loader/Decoder.h: Removed.
2181         * loader/FrameLoader.cpp:
2182         * loader/FrameLoader.h:
2183         * loader/FrameLoaderClient.h:
2184         * loader/MainResourceLoader.h: Added.
2185         * loader/NetscapePlugInStreamLoader.h: Added.
2186         * loader/Request.h:
2187         (WebCore::Request::cachedResource):
2188         * loader/ResourceLoader.h: Added.
2189         * loader/SubresourceLoader.h: Added.
2190         * loader/TextResourceDecoder.cpp: Added.
2191         (WebCore::TextResourceDecoder::determineContentType):
2192         (WebCore::TextResourceDecoder::defaultEncoding):
2193         (WebCore::TextResourceDecoder::TextResourceDecoder):
2194         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2195         (WebCore::TextResourceDecoder::setEncoding):
2196         (WebCore::TextResourceDecoder::checkForBOM):
2197         (WebCore::TextResourceDecoder::checkForCSSCharset):
2198         (WebCore::TextResourceDecoder::checkForHeadCharset):
2199         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2200         (WebCore::TextResourceDecoder::decode):
2201         (WebCore::TextResourceDecoder::flush):
2202         * loader/TextResourceDecoder.h: Added.
2203         * loader/WebDocumentLoader.h: Removed.
2204         * loader/WebLoader.h: Removed.
2205         * loader/WebMainResourceLoader.h: Removed.
2206         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2207         * loader/WebSubresourceLoader.h: Removed.
2208         * loader/loader.cpp:
2209         (WebCore::Loader::servePendingRequests):
2210         (WebCore::Loader::receivedAllData):
2211         (WebCore::Loader::receivedResponse):
2212         (WebCore::Loader::didReceiveData):
2213         (WebCore::Loader::cancelRequests):
2214         (WebCore::Loader::jobForRequest):
2215         * loader/mac/DocumentLoaderMac.mm:
2216         * loader/mac/FormDataStream.m: Added.
2217         * loader/mac/FrameLoaderMac.mm:
2218         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2219         (WebCore::FrameLoader::addPlugInStreamLoader):
2220         (WebCore::FrameLoader::removePlugInStreamLoader):
2221         (WebCore::FrameLoader::addSubresourceLoader):
2222         (WebCore::FrameLoader::removeSubresourceLoader):
2223         (WebCore::FrameLoader::willSendRequest):
2224         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2225         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2226         (WebCore::FrameLoader::didReceiveResponse):
2227         (WebCore::FrameLoader::didReceiveData):
2228         (WebCore::FrameLoader::didFinishLoad):
2229         (WebCore::FrameLoader::didFailToLoad):
2230         (WebCore::FrameLoader::open):
2231         (WebCore::FrameLoader::willUseArchive):
2232         (WebCore::FrameLoader::isArchiveLoadPending):
2233         * loader/mac/ImageDocumentMac.mm:
2234         * loader/mac/LoaderFunctionsMac.mm:
2235         (WebCore::CheckCacheObjectStatus):
2236         * loader/mac/MainResourceLoaderMac.mm:
2237         (WebCore::MainResourceLoader::MainResourceLoader):
2238         (WebCore::MainResourceLoader::releaseDelegate):
2239         (WebCore::MainResourceLoader::didCancel):
2240         (WebCore::MainResourceLoader::addData):
2241         (WebCore::MainResourceLoader::willSendRequest):
2242         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2243         (WebCore::MainResourceLoader::didReceiveData):
2244         (WebCore::MainResourceLoader::didFinishLoading):
2245         (WebCore::MainResourceLoader::setDefersLoading):
2246         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2247         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2248         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2249         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2250         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2251         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2252         (WebCore::NetscapePlugInStreamLoader::didFail):
2253         (WebCore::NetscapePlugInStreamLoader::didCancel):
2254         * loader/mac/ResourceLoaderMac.mm:
2255         (WebCore::ResourceLoader::ResourceLoader):
2256         (WebCore::ResourceLoader::~ResourceLoader):
2257         (WebCore::ResourceLoader::releaseResources):
2258         (WebCore::ResourceLoader::load):
2259         (WebCore::ResourceLoader::setDefersLoading):
2260         (WebCore::ResourceLoader::frameLoader):
2261         (WebCore::ResourceLoader::addData):
2262         (WebCore::ResourceLoader::resourceData):
2263         (WebCore::ResourceLoader::clearResourceData):
2264         (WebCore::ResourceLoader::willSendRequest):
2265         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2266         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2267         (WebCore::ResourceLoader::didReceiveResponse):
2268         (WebCore::ResourceLoader::didReceiveData):
2269         (WebCore::ResourceLoader::willStopBufferingData):
2270         (WebCore::ResourceLoader::didFinishLoading):
2271         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2272         (WebCore::ResourceLoader::didFail):
2273         (WebCore::ResourceLoader::willCacheResponse):
2274         (WebCore::ResourceLoader::didCancel):
2275         (WebCore::ResourceLoader::cancel):
2276         (WebCore::ResourceLoader::setIdentifier):
2277         (WebCore::ResourceLoader::response):
2278         (WebCore::ResourceLoader::inConnectionCallback):
2279         (WebCore::ResourceLoader::cancelledError):
2280         (WebCore::ResourceLoader::receivedCredential):
2281         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2282         (WebCore::ResourceLoader::receivedCancellation):
2283         (WebCore::ResourceLoader::delegate):
2284         (WebCore::ResourceLoader::releaseDelegate):
2285         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2286         * loader/mac/SubresourceLoaderMac.mm:
2287         (WebCore::SubresourceLoader::SubresourceLoader):
2288         (WebCore::SubresourceLoader::willSendRequest):
2289         (WebCore::SubresourceLoader::didReceiveResponse):
2290         (WebCore::SubresourceLoader::didReceiveData):
2291         (WebCore::SubresourceLoader::didFinishLoading):
2292         (WebCore::SubresourceLoader::didFail):
2293         (WebCore::SubresourceLoader::didCancel):
2294         * loader/mac/WebFormDataStream.h: Removed.
2295         * loader/mac/WebFormDataStream.m: Removed.
2296         * page/Frame.cpp:
2297         (WebCore::Frame::javaScriptEnabled):
2298         (WebCore::Frame::scriptProxy):
2299         (WebCore::Frame::executeScript):
2300         (WebCore::Frame::write):
2301         (WebCore::Frame::userGestureHint):
2302         (WebCore::Frame::saveInterpreterBuiltins):
2303         (WebCore::Frame::restoreInterpreterBuiltins):
2304         (WebCore::Frame::backslashAsCurrencySymbol):
2305         * page/Frame.h:
2306         * page/FramePrivate.h:
2307         * platform/StreamingTextDecoder.cpp: Removed.
2308         * platform/StreamingTextDecoder.h: Removed.
2309         * platform/StreamingTextDecoderICU.cpp: Removed.
2310         * platform/StreamingTextDecoderICU.h: Removed.
2311         * platform/TextCodec.cpp: Added.
2312         * platform/TextCodec.h: Added.
2313         * platform/TextCodecICU.cpp: Added.
2314         * platform/TextCodecICU.h: Added.
2315         * platform/TextCodecLatin1.h:
2316         * platform/TextCodecUTF16.h:
2317         * platform/TextDecoder.h:
2318         * platform/TextEncoding.cpp:
2319         * platform/TextEncodingRegistry.cpp:
2320         * platform/image-decoders/jpeg/jmorecfg.h:
2321         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2322         * platform/mac/StreamingTextDecoderMac.h: Removed.
2323         * platform/mac/TextCodecMac.cpp: Added.
2324         * platform/mac/TextCodecMac.h: Added.
2325         * platform/network/ResourceHandleInternal.h:
2326         * platform/network/mac/ResourceHandleMac.mm:
2327         * platform/qt/FrameQt.cpp:
2328         (WebCore::FrameQt::bindingRootObject):
2329         * platform/qt/LoaderFunctionsQt.cpp:
2330         (WebCore::CheckCacheObjectStatus):
2331         * rendering/RenderObject.cpp:
2332         (WebCore::RenderObject::backslashAsCurrencySymbol):
2333         * xml/XSLTProcessor.cpp:
2334         (WebCore::XSLTProcessor::createDocumentFromSource):
2335         * xml/xmlhttprequest.cpp:
2336         (WebCore::XMLHttpRequest::didReceiveData):
2337         * xml/xmlhttprequest.h:
2338
2339 2006-10-29  Darin Adler  <darin@apple.com>
2340
2341         Rubber stamped by Adam (kinda).
2342
2343         - add Mac suffixes and correct filenames inside loader/mac
2344
2345         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2346
2347         * loader/mac/FrameLoader.mm: Removed.
2348         * loader/mac/WebDocumentLoader.mm: Removed.
2349         * loader/mac/WebLoader.mm: Removed.
2350         * loader/mac/WebMainResourceLoader.mm: Removed.
2351         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2352         * loader/mac/WebSubresourceLoader.mm: Removed.
2353
2354         * loader/mac/FrameLoaderMac.mm: Added.
2355         * loader/mac/DocumentLoaderMac.mm: Added.
2356         * loader/mac/ResourceLoaderMac.mm: Added.
2357         * loader/mac/MainResourceLoaderMac.mm: Added.
2358         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2359         * loader/mac/SubresourceLoaderMac.mm: Removed.
2360
2361 2006-10-29  Darin Adler  <darin@apple.com>
2362
2363         Reviewed by Adam.
2364
2365         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2366           and FrameLoader.cpp mostly ready
2367
2368         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2369         FormState.cpp. Removed WebFormState.mm.
2370
2371         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2372         get this header compiling on non-Mac.
2373         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2374         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2375
2376         * loader/FrameLoaderClient.h: Added some ifdefs.
2377         * loader/WebDocumentLoader.h: Ditto.
2378         * loader/WebLoader.h: Ditto.
2379         * loader/WebMainResourceLoader.h: Ditto.
2380
2381         * loader/mac/WebDocumentLoader.mm:
2382         (WebCore::DocumentLoader::isLoadingInAPISense):
2383         Rewrote to work without bridge, partly to remove the need for ObjC
2384         bridge type in the header, and also because we're tearing down the bridge.
2385
2386         * loader/mac/WebMainResourceLoader.mm:
2387         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2388         m_contentLength and m_bytesReceived.
2389         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2390         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2391
2392         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2393         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2394
2395         * loader/mac/FormState.mm: Removed.
2396         * loader/FormState.cpp: Added.
2397
2398 2006-10-29  Darin Adler  <darin@apple.com>
2399
2400         Rubber stamped by Adam.
2401
2402         - moving towards use of FrameLoader cross-platform; move the headers
2403           for the Mac loader from loader/mac into loader, in preparation for
2404           making them useful on non-Mac
2405
2406         * WebCore.xcodeproj/project.pbxproj:
2407
2408         * loader/mac/FrameLoader.h: Removed.
2409         * loader/mac/WebDocumentLoader.h: Removed.
2410         * loader/mac/WebFormState.h: Removed.
2411         * loader/mac/WebLoader.h: Removed.
2412         * loader/mac/WebMainResourceLoader.h: Removed.
2413         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2414         * loader/mac/WebSubresourceLoader.h: Removed.
2415
2416         * loader/FrameLoader.h: Added.
2417         * loader/WebDocumentLoader.h: Added.
2418         * loader/WebFormState.h: Added.
2419         * loader/WebLoader.h: Added.
2420         * loader/WebMainResourceLoader.h: Added.
2421         * loader/WebNetscapePlugInStreamLoader.h: Added.
2422         * loader/WebSubresourceLoader.h: Added.
2423
2424 2006-10-29  Adam Roben  <aroben@apple.com>
2425
2426         Reviewed by Geoff.
2427
2428         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2429         r17405.
2430
2431         * platform/DeprecatedString.h:
2432
2433 2006-10-29  Beth Dakin  <bdakin@apple.com>
2434
2435         Rubber stamped by Geoff.
2436
2437         This is a followup to my HitTestResult checkin. Most of the 
2438         HitTestResult local variables in the code were named i or info for 
2439         when the class was named NodeInfo. This patch renames all of these 
2440         local variables to result.
2441
2442         * dom/Document.cpp:
2443         (WebCore::Document::prepareMouseEvent):
2444         * html/HTMLAreaElement.cpp:
2445         (WebCore::HTMLAreaElement::mapMouseEvent):
2446         * html/HTMLMapElement.cpp:
2447         (WebCore::HTMLMapElement::mapMouseEvent):
2448         * rendering/EllipsisBox.cpp:
2449         (WebCore::EllipsisBox::nodeAtPoint):
2450         * rendering/EllipsisBox.h:
2451         * rendering/InlineBox.cpp:
2452         (WebCore::InlineBox::nodeAtPoint):
2453         * rendering/InlineFlowBox.cpp:
2454         (WebCore::InlineFlowBox::nodeAtPoint):
2455         * rendering/InlineTextBox.cpp:
2456         (WebCore::InlineTextBox::nodeAtPoint):
2457         * rendering/RenderBlock.cpp:
2458         (WebCore::RenderBlock::isPointInScrollbar):
2459         (WebCore::RenderBlock::nodeAtPoint):
2460         * rendering/RenderBlock.h:
2461         * rendering/RenderBox.cpp:
2462         (WebCore::RenderBox::nodeAtPoint):
2463         * rendering/RenderBox.h:
2464         * rendering/RenderFlow.cpp:
2465         (WebCore::RenderFlow::hitTestLines):
2466         * rendering/RenderFlow.h:
2467         * rendering/RenderForeignObject.cpp:
2468         (WebCore::RenderForeignObject::nodeAtPoint):
2469         * rendering/RenderFrameSet.cpp:
2470         (WebCore::RenderFrameSet::nodeAtPoint):
2471         * rendering/RenderImage.cpp:
2472         (WebCore::RenderImage::nodeAtPoint):
2473         * rendering/RenderInline.cpp:
2474         (WebCore::RenderInline::nodeAtPoint):
2475         * rendering/RenderInline.h:
2476         * rendering/RenderLayer.cpp:
2477         (WebCore::RenderLayer::autoscroll):
2478         (WebCore::RenderLayer::hitTest):
2479         (WebCore::RenderLayer::hitTestLayer):
2480         (WebCore::RenderLayer::updateHoverActiveState):
2481         * rendering/RenderListBox.cpp:
2482         (WebCore::RenderListBox::isPointInScrollbar):
2483         * rendering/RenderObject.cpp:
2484         (WebCore::RenderObject::hitTest):
2485         (WebCore::RenderObject::setInnerNode):
2486         (WebCore::RenderObject::nodeAtPoint):
2487         * rendering/RenderObject.h:
2488         * rendering/RenderPath.cpp:
2489         (WebCore::RenderPath::nodeAtPoint):
2490         * rendering/RenderSVGImage.cpp:
2491         (WebCore::RenderSVGImage::nodeAtPoint):
2492         * rendering/RenderSVGText.cpp:
2493         (WebCore::RenderSVGText::nodeAtPoint):
2494         * rendering/RenderTableRow.cpp:
2495         (WebCore::RenderTableRow::nodeAtPoint):
2496         * rendering/RenderTableRow.h:
2497         * rendering/RenderTableSection.cpp:
2498         (WebCore::RenderTableSection::nodeAtPoint):
2499         * rendering/RenderTableSection.h:
2500         * rendering/RenderTextControl.cpp:
2501         (WebCore::RenderTextControl::nodeAtPoint):
2502         * rendering/RootInlineBox.cpp:
2503         (WebCore::RootInlineBox::nodeAtPoint):
2504         * rendering/RootInlineBox.h:
2505
2506 2006-10-29  Adam Roben  <aroben@apple.com>
2507
2508         More semi-fixes.
2509
2510         * page/Page.cpp: Forgot to wrap the actual definition of
2511         setDefersLoading() in PLATFORM(MAC).
2512         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2513
2514 2006-10-29  Adam Roben  <aroben@apple.com>
2515
2516         Build semi-fix.
2517
2518         Move all FrameLoader-related code in Page.{cpp,h} within #if
2519         PLATFORM(MAC), since this class currently only exists on Mac.
2520
2521         * page/Page.cpp:
2522         * page/Page.h:
2523
2524 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2525
2526         build fix.
2527         
2528         * platform/PlatformString.h:
2529         (WebCore::String::operator NSString*):
2530
2531 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2532
2533         Rolled out accidental commit.
2534         
2535         * platform/AtomicString.h:
2536         (WebCore::AtomicString::AtomicString):
2537         (WebCore::AtomicString::operator NSString*):
2538
2539 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2540
2541         RS by Darin.
2542
2543         Rolled out change to map NULL Strings to nil NSStrings because it caused
2544         even more AppKit crashes. Maybe we should remove the NSString * operator
2545         entirely, since its use is not straight-forward, and require callers to
2546         specify explicitly whether they tolerate NULL.
2547         
2548         * platform/AtomicString.h:
2549         * platform/PlatformString.h:
2550         (WebCore::String::operator NSString*):
2551         * platform/mac/TextFieldMac.mm:
2552         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2553
2554 2006-10-29  Darin Adler  <darin@apple.com>
2555
2556         Reviewed by Geoff.
2557
2558         - fixed storage leak showing up on the buildbot
2559
2560         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2561         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2562
2563 2006-10-29  Darin Adler  <darin@apple.com>
2564
2565         Rubber stamped by Adam.
2566
2567         - renamed WebFrameLoaderClient to match the class name inside it
2568
2569         * loader/mac/WebFrameLoaderClient.h: Removed.
2570         * loader/FrameLoaderClient.h: Moved it here.
2571
2572         * WebCore.xcodeproj/project.pbxproj: Updated project.
2573
2574         * bridge/mac/FrameMac.mm: Updated includes.
2575         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2576         * loader/mac/FrameLoader.mm: Ditto.
2577         * loader/mac/WebLoader.h: Ditto.
2578
2579 2006-10-29  Darin Adler  <darin@apple.com>
2580
2581         Reviewed by Mitz.
2582
2583         - fix crash visible on buildbot and also when running the test
2584           anchor-image-scrolled-x-y.html under libgmalloc
2585
2586         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2587         now that the class is named ResourceHandle.
2588         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2589         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2590         a local RefPtr before calling finishJobAndHandle, since we might get
2591         cancelled inside that function, so we should not rely on m_handle to
2592         keep the ResourceHandle alive.
2593         (WebCore::SubresourceLoader::didFail): Ditto.
2594         (WebCore::SubresourceLoader::didCancel): Ditto.
2595
2596 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2597
2598         - build fix
2599
2600         * platform/network/mac/ResourceHandleMac.mm:
2601
2602 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2603
2604         Rubber stamped by Darin.
2605
2606         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2607
2608         * CMakeLists.txt:
2609         * Projects/gdk/webcore-gdk.bkl:
2610         * WebCore.vcproj/WebCore/WebCore.vcproj:
2611         * WebCore.xcodeproj/project.pbxproj:
2612         * WebCoreSources.bkl:
2613         * bridge/mac/FrameMac.mm:
2614         * bridge/win/FrameWin.cpp:
2615         * dom/XMLTokenizer.cpp:
2616         * loader/Cache.cpp:
2617         * loader/CachedResource.h:
2618         * loader/LoaderFunctions.h:
2619         * loader/icon/IconLoader.cpp:
2620         (IconLoader::startLoading):
2621         (IconLoader::didReceiveData):
2622         (IconLoader::didFinishLoading):
2623         * loader/icon/IconLoader.h:
2624         * loader/loader.cpp:
2625         (WebCore::Loader::servePendingRequests):
2626         (WebCore::Loader::receivedAllData):
2627         (WebCore::Loader::receivedResponse):
2628         (WebCore::Loader::didReceiveData):
2629         (WebCore::Loader::cancelRequests):
2630         (WebCore::Loader::jobForRequest):
2631         * loader/loader.h:
2632         * loader/mac/IconLoaderMac.mm:
2633         (IconLoader::receivedResponse):
2634         * loader/mac/LoaderFunctionsMac.mm:
2635         * loader/mac/WebLoader.h:
2636         * loader/mac/WebSubresourceLoader.h:
2637         * loader/mac/WebSubresourceLoader.mm:
2638         (WebCore::SubresourceLoader::SubresourceLoader):
2639         (WebCore::SubresourceLoader::create):
2640         * platform/gdk/FrameGdk.cpp:
2641         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2642         (WebCore::FrameGdkClientDefault::openURL):
2643         (WebCore::FrameGdkClientDefault::submitForm):
2644         (WebCore::FrameGdkClientDefault::receivedResponse):
2645         (WebCore::FrameGdkClientDefault::didReceiveData):
2646         (WebCore::FrameGdkClientDefault::receivedAllData):
2647         * platform/gdk/FrameGdk.h:
2648         * platform/gdk/TemporaryLinkStubs.cpp:
2649         (WebCore::ServeSynchronousRequest):
2650         (WebCore::ResourceHandle::assembleResponseHeaders):
2651         (WebCore::ResourceHandle::retrieveCharset):
2652         * platform/network/ResourceHandle.cpp: Added.
2653         (WebCore::ResourceHandle::ResourceHandle):
2654         (WebCore::ResourceHandle::create):
2655         (WebCore::ResourceHandle::isErrorPage):
2656         (WebCore::ResourceHandle::error):
2657         (WebCore::ResourceHandle::setError):
2658         (WebCore::ResourceHandle::responseEncoding):
2659         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2660         (WebCore::ResourceHandle::kill):
2661         (WebCore::ResourceHandle::requestHeaders):
2662         (WebCore::ResourceHandle::url):
2663         (WebCore::ResourceHandle::postData):
2664         (WebCore::ResourceHandle::method):
2665         (WebCore::ResourceHandle::client):
2666         * platform/network/ResourceHandle.h: Added.
2667         (WebCore::ResourceHandle::getInternal):
2668         * platform/network/ResourceHandleClient.h: Added.
2669         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2670         (WebCore::ResourceHandleClient::didReceiveData):
2671         (WebCore::ResourceHandleClient::didFinishLoading):
2672         (WebCore::ResourceHandleClient::receivedRedirect):
2673         (WebCore::ResourceHandleClient::receivedResponse):
2674         (WebCore::ResourceHandleClient::receivedAllData):
2675         * platform/network/ResourceHandleInternal.h: Added.
2676         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2677         * platform/network/ResourceLoader.cpp: Removed.
2678         * platform/network/ResourceLoader.h: Removed.
2679         * platform/network/ResourceLoaderClient.h: Removed.
2680         * platform/network/ResourceLoaderInternal.h: Removed.
2681         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2682         (WebCore::willSendRequest):
2683         (WebCore::didReceiveResponse):
2684         (WebCore::didReceiveData):
2685         (WebCore::didFinishLoading):
2686         (WebCore::didFail):
2687         (WebCore::willCacheResponse):
2688         (WebCore::didReceiveChallenge):
2689         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2690         (WebCore::ResourceHandle::~ResourceHandle):
2691         (WebCore::ResourceHandle::start):
2692         (WebCore::ResourceHandle::cancel):
2693         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2694         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2695         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2696         (WebCore::ResourceHandle::~ResourceHandle):
2697         (WebCore::ResourceHandle::start):
2698         (WebCore::ResourceHandle::cancel):
2699         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2700         (WebCore::ResourceHandleManager::ResourceHandleManager):
2701         (WebCore::ResourceHandleManager::get):
2702         (WebCore::ResourceHandleManager::useSimpleTransfer):
2703         (WebCore::writeCallback):
2704         (WebCore::ResourceHandleManager::downloadTimerCallback):
2705         (WebCore::ResourceHandleManager::remove):
2706         (WebCore::ResourceHandleManager::add):
2707         (WebCore::ResourceHandleManager::cancel):
2708         * platform/network/gdk/ResourceHandleManager.h: Added.
2709         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2710         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2711         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2712         * platform/network/mac/ResourceHandleMac.mm: Added.
2713         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2714         (WebCore::ResourceHandle::~ResourceHandle):
2715         (WebCore::ResourceHandle::start):
2716         (WebCore::ResourceHandle::assembleResponseHeaders):
2717         (WebCore::ResourceHandle::retrieveResponseEncoding):
2718         (WebCore::ResourceHandle::receivedResponse):
2719         (WebCore::ResourceHandle::cancel):
2720         (WebCore::ResourceHandle::redirectedToURL):
2721         (WebCore::ResourceHandle::addData):
2722         (WebCore::ResourceHandle::finishJobAndHandle):
2723         (WebCore::ResourceHandle::reportError):
2724         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2725         * platform/network/qt/ResourceHandleManager.cpp: Added.
2726         (WebCore::ResourceHandleManager::ResourceHandleManager):
2727         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2728         (WebCore::ResourceHandleManager::self):
2729         (WebCore::ResourceHandleManager::slotData):
2730         (WebCore::ResourceHandleManager::slotMimetype):
2731         (WebCore::ResourceHandleManager::slotResult):
2732         (WebCore::ResourceHandleManager::remove):
2733         (WebCore::ResourceHandleManager::add):
2734         (WebCore::ResourceHandleManager::cancel):
2735         * platform/network/qt/ResourceHandleManager.h: Added.
2736         * platform/network/qt/ResourceHandleQt.cpp: Added.
2737         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2738         (WebCore::ResourceHandle::~ResourceHandle):
2739         (WebCore::ResourceHandle::start):
2740         (WebCore::ResourceHandle::cancel):
2741         (WebCore::ResourceHandle::assembleResponseHeaders):
2742         (WebCore::ResourceHandle::retrieveResponseEncoding):
2743         (WebCore::ResourceHandle::receivedResponse):
2744         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2745         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2746         * platform/network/qt/ResourceLoaderManager.h: Removed.
2747         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2748         * platform/network/win/ResourceHandleWin.cpp: Added.
2749         (WebCore::):
2750         (WebCore::addToOutstandingJobs):
2751         (WebCore::lookupResourceHandle):
2752         (WebCore::ResourceHandleWndProc):
2753         (WebCore::initializeOffScreenResourceHandleWindow):
2754         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2755         (WebCore::ResourceHandle::~ResourceHandle):
2756         (WebCore::ResourceHandle::onHandleCreated):
2757         (WebCore::ResourceHandle::onRequestRedirected):
2758         (WebCore::ResourceHandle::onRequestComplete):
2759         (WebCore::ResourceHandle::start):
2760         (WebCore::ResourceHandle::fileLoadTimer):
2761         (WebCore::ResourceHandle::cancel):
2762         (WebCore::ResourceHandle::setHasReceivedResponse):
2763         (WebCore::ResourceHandle::hasReceivedResponse):
2764         * platform/network/win/ResourceHandleWin.h: Added.
2765         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2766         * platform/network/win/ResourceLoaderWin.h: Removed.
2767         * platform/qt/FrameQt.cpp:
2768         * platform/qt/FrameQtClient.cpp:
2769         (WebCore::FrameQtClientDefault::openURL):
2770         (WebCore::FrameQtClientDefault::submitForm):
2771         (WebCore::FrameQtClientDefault::receivedResponse):
2772         (WebCore::FrameQtClientDefault::didReceiveData):
2773         (WebCore::FrameQtClientDefault::receivedAllData):
2774         * platform/qt/FrameQtClient.h:
2775         * platform/win/TemporaryLinkStubs.cpp:
2776         (WebCore::ResourceHandle::assembleResponseHeaders):
2777         (WebCore::ResourceHandle::retrieveResponseEncoding):
2778         (WebCore::ServeSynchronousRequest):
2779         * xml/XSLTProcessor.cpp:
2780         * xml/xmlhttprequest.cpp:
2781         (WebCore::XMLHttpRequest::send):
2782         (WebCore::XMLHttpRequest::didFinishLoading):
2783         (WebCore::XMLHttpRequest::receivedRedirect):
2784         (WebCore::XMLHttpRequest::didReceiveData):
2785         * xml/xmlhttprequest.h:
2786
2787 t2006-10-29  Darin Adler  <darin@apple.com>
2788
2789         Reviewed by Maciej.
2790
2791         - eliminate use of NSArray to carry form data around
2792
2793         * WebCore.exp:
2794         * WebCore.xcodeproj/project.pbxproj:
2795         * bridge/mac/FormDataMac.h: Removed.
2796         * bridge/mac/FormDataMac.mm: Removed.
2797         * bridge/mac/FrameMac.h:
2798         * bridge/mac/WebCoreFrameBridge.h:
2799         * bridge/mac/WebCoreFrameBridge.mm:
2800         * html/HTMLFormElement.cpp:
2801         (WebCore::HTMLFormElement::submit):
2802         * loader/FormData.h:
2803         (WebCore::FormData::isEmpty):
2804         * loader/mac/FrameLoader.h:
2805         * loader/mac/FrameLoader.mm:
2806         (WebCore::FrameLoader::load):
2807         (WebCore::FrameLoader::post):
2808         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2809         (WebCore::FrameLoader::loadResourceSynchronously):
2810         * loader/mac/LoaderFunctionsMac.mm:
2811         (WebCore::ServeSynchronousRequest):
2812         * loader/mac/WebFormDataStream.h:
2813         * loader/mac/WebFormDataStream.m:
2814         (WebCore::pairRetain):
2815         (WebCore::pairRelease):
2816         (WebCore::pairEqual):
2817         (WebCore::pairHash):
2818         (WebCore::closeCurrentStream):
2819         (WebCore::scheduleWithPair):
2820         (WebCore::advanceCurrentStream):
2821         (WebCore::openNextStream):
2822         (WebCore::formCreate):
2823         (WebCore::formFinalize):
2824         (WebCore::formOpen):
2825         (WebCore::formRead):
2826         (WebCore::formCanRead):
2827         (WebCore::formClose):
2828         (WebCore::formSchedule):
2829         (WebCore::formUnschedule):
2830         (WebCore::formEventCallback):
2831         (WebCore::setHTTPBody):
2832         * loader/mac/WebSubresourceLoader.h:
2833         * loader/mac/WebSubresourceLoader.mm:
2834         (WebCore::SubresourceLoader::create):
2835         * platform/network/mac/ResourceLoaderMac.mm:
2836
2837 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2838
2839         Reviewed by Darin.
2840
2841         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2842
2843         * loader/mac/WebSubresourceLoader.h:
2844         * loader/mac/WebSubresourceLoader.mm:
2845         (WebCore::SubresourceLoader::create):
2846         * platform/network/mac/ResourceLoaderMac.mm:
2847         (WebCore::ResourceLoader::start):
2848
2849 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2850
2851         Reviewed by Darin.
2852
2853         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2854
2855         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2856         
2857         * WebCore.xcodeproj/project.pbxproj:
2858         * bridge/mac/WebCoreFrameBridge.h:
2859         * loader/mac/FrameLoader.h:
2860         * loader/mac/FrameLoader.mm:
2861         * loader/mac/LoaderFunctionsMac.mm:
2862         * loader/mac/WebLoader.h:
2863         * loader/mac/WebSubresourceLoader.h:
2864         * loader/mac/WebSubresourceLoader.mm:
2865         (WebCore::SubresourceLoader::SubresourceLoader):
2866         (WebCore::SubresourceLoader::create):
2867         (WebCore::SubresourceLoader::willSendRequest):
2868         (WebCore::SubresourceLoader::didReceiveResponse):
2869         (WebCore::SubresourceLoader::didReceiveData):
2870         (WebCore::SubresourceLoader::didFinishLoading):
2871         (WebCore::SubresourceLoader::didFail):
2872         (WebCore::SubresourceLoader::didCancel):
2873         * platform/network/ResourceLoader.h:
2874         * platform/network/ResourceLoaderInternal.h:
2875         * platform/network/mac/ResourceLoaderMac.mm:
2876         (WebCore::ResourceLoader::~ResourceLoader):
2877         (WebCore::ResourceLoader::start):
2878         (WebCore::ResourceLoader::receivedResponse):
2879         (WebCore::ResourceLoader::cancel):
2880         (WebCore::ResourceLoader::redirectedToURL):
2881         (WebCore::ResourceLoader::addData):
2882         (WebCore::ResourceLoader::finishJobAndHandle):
2883         (WebCore::ResourceLoader::reportError):
2884         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2885         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2886         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2887
2888 2006-10-28  Darin Adler  <darin@apple.com>
2889
2890         Reviewed by Maciej.
2891
2892         - eliminated the use of Objective-C for the policy decider
2893           machinery, obviating the need for WebPolicyDecider,
2894           WebCoreFrameLoaderAsDelegate, and
2895           WebCoreMainResourceLoaderAsPolicyDelegate
2896
2897         - grouped the state related to policy decisions into a PolicyCheck
2898           class to simplify the FrameLoader logic
2899
2900         - removed six methods from the bridge, reducing FrameLoader's use of
2901           the bridge to a single method
2902
2903         - changed form state to always use HashMap instead of NSDictionary
2904
2905         - moved the defersLoading flag from WebView to WebCore::Page
2906           and changed code to consistently call it defersLoading rather
2907           than defersCallbacks
2908
2909         - updated for rename of PassRefPtr::release to releaseRef
2910         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2911         - cleaned up kjs_binding.h a bit
2912         - cleaned up FrameMac.h a bit
2913
2914         * loader/mac/WebPolicyDecider.h: Removed.
2915         * loader/mac/WebPolicyDecider.mm: Removed.
2916         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2917
2918         * WebCore.exp:
2919         * bindings/js/kjs_binding.cpp:
2920         (KJS::ScriptInterpreter::ScriptInterpreter):
2921         (KJS::ScriptInterpreter::wasRunByUserGesture):
2922         * bindings/js/kjs_binding.h:
2923         (KJS::ScriptInterpreter::setCurrentEvent):
2924         (KJS::ScriptInterpreter::setInlineCode):
2925         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2926         (KJS::ScriptInterpreter::getCurrentEvent):
2927         (KJS::cacheDOMObject):
2928         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2929         * bridge/AXObjectCache.h:
2930         * bridge/mac/BrowserExtensionMac.mm:
2931         (WebCore::BrowserExtensionMac::createNewWindow):
2932         * bridge/mac/FrameMac.h:
2933         * bridge/mac/FrameMac.mm:
2934         (WebCore::FrameMac::loadRequest):
2935         (WebCore::FrameMac::submitForm):
2936         (WebCore::FrameMac::urlSelected):
2937         (WebCore::FrameMac::userAgent):
2938         (WebCore::FrameMac::passMouseDownEventToWidget):
2939         (WebCore::FrameMac::handleMouseMoveEvent):
2940         * bridge/mac/PageMac.mm:
2941         (WebCore::Page::Page):
2942         * bridge/mac/WebCoreEditCommand.mm:
2943         * bridge/mac/WebCoreFrameBridge.h:
2944         * bridge/mac/WebCoreFrameBridge.mm:
2945         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2946         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2947         * css/CSSComputedStyleDeclaration.cpp:
2948         (WebCore::):
2949         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2950         * css/CSSPrimitiveValue.cpp:
2951         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2952         (WebCore::CSSPrimitiveValue::cleanup):
2953         (WebCore::CSSPrimitiveValue::cssText):
2954         * css/CSSPrimitiveValue.h:
2955         (WebCore::CSSPrimitiveValue::):
2956         * css/CSSValueList.cpp:
2957         (WebCore::CSSValueList::append):
2958         * css/cssparser.cpp:
2959         (WebCore::CSSParser::parseValue):
2960         * css/cssparser.h:
2961         * css/cssstyleselector.cpp:
2962         (WebCore::CSSStyleSelector::applyProperty):
2963         * dom/Document.cpp:
2964         (WebCore::Document::Document):
2965         (WebCore::Document::updateSelection):
2966         (WebCore::Document::implicitClose):
2967         (WebCore::Document::setFocusNode):
2968         * dom/Document.h:
2969         * editing/ReplaceSelectionCommand.h:
2970         * html/HTMLParser.cpp:
2971         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2972         * loader/mac/FrameLoader.h:
2973         (WebCore::PolicyCheck::request):
2974         * loader/mac/FrameLoader.mm:
2975         (WebCore::FrameLoader::~FrameLoader):
2976         (WebCore::FrameLoader::safeLoad):
2977         (WebCore::FrameLoader::load):
2978         (WebCore::FrameLoader::open):
2979         (WebCore::FrameLoader::stopLoading):
2980         (WebCore::setAllDefersLoading):
2981         (WebCore::FrameLoader::setDefersLoading):
2982         (WebCore::FrameLoader::willSendRequest):
2983         (WebCore::FrameLoader::receivedMainResourceError):
2984         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2985         (WebCore::FrameLoader::commitProvisionalLoad):
2986         (WebCore::FrameLoader::checkNavigationPolicy):
2987         (WebCore::FrameLoader::checkContentPolicy):
2988         (WebCore::FrameLoader::cancelContentPolicyCheck):
2989         (WebCore::FrameLoader::stopPolicyCheck):
2990         (WebCore::FrameLoader::checkNewWindowPolicy):
2991         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2992         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2993         (WebCore::FrameLoader::continueAfterContentPolicy):
2994         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2995         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2996         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2997         (WebCore::FrameLoader::closeDocument):
2998         (WebCore::FrameLoader::transitionToCommitted):
2999         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
3000         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
3001         (WebCore::FrameLoader::post):
3002         (WebCore::FrameLoader::detachFromParent):
3003         (WebCore::FrameLoader::addExtraFieldsToRequest):
3004         (WebCore::PolicyCheck::PolicyCheck):
3005         (WebCore::PolicyCheck::clear):
3006         (WebCore::PolicyCheck::set):
3007         (WebCore::PolicyCheck::call):
3008         (WebCore::PolicyCheck::dropRequest):
3009         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3010         * loader/mac/WebFormState.h:
3011         * loader/mac/WebFormState.mm:
3012         * loader/mac/WebFrameLoaderClient.h:
3013         * loader/mac/WebLoader.h:
3014         (WebCore::WebResourceLoader::defersLoading):
3015         * loader/mac/WebLoader.mm:
3016         (WebCore::WebResourceLoader::WebResourceLoader):
3017         (WebCore::WebResourceLoader::load):
3018         (WebCore::WebResourceLoader::setDefersLoading):
3019         * loader/mac/WebMainResourceLoader.h:
3020         * loader/mac/WebMainResourceLoader.mm:
3021         (WebCore::MainResourceLoader::MainResourceLoader):
3022         (WebCore::MainResourceLoader::releaseDelegate):
3023         (WebCore::MainResourceLoader::didCancel):
3024         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3025         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3026         (WebCore::MainResourceLoader::willSendRequest):
3027         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3028         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3029         (WebCore::MainResourceLoader::didReceiveResponse):
3030         (WebCore::MainResourceLoader::didReceiveData):
3031         (WebCore::MainResourceLoader::didFinishLoading):
3032         (WebCore::MainResourceLoader::didFail):
3033         (WebCore::MainResourceLoader::loadNow):
3034         (WebCore::MainResourceLoader::load):
3035         (WebCore::MainResourceLoader::setDefersLoading):
3036         * page/Frame.cpp:
3037         (WebCore::Frame::paint):
3038         * page/FrameView.cpp:
3039         (WebCore::FrameView::layout):
3040         * page/FrameView.h:
3041         * page/Page.cpp:
3042         (WebCore::Page::setDefersLoading):
3043         * page/Page.h:
3044         (WebCore::Page::defersLoading):
3045         * platform/DeprecatedString.h:
3046         * platform/DeprecatedStringList.h:
3047         * platform/FontFallbackList.h:
3048         * platform/PlatformKeyboardEvent.h:
3049         * platform/PlatformMouseEvent.h:
3050         * platform/PlatformWheelEvent.h:
3051         * platform/mac/ClipboardMac.h:
3052         * platform/mac/ClipboardMac.mm:
3053         (WebCore::ClipboardMac::setDragImage):
3054         (WebCore::ClipboardMac::dragNSImage):
3055         (WebCore::ClipboardMac::sourceOperation):
3056         (WebCore::ClipboardMac::destinationOperation):
3057         * rendering/RenderObject.cpp:
3058         (WebCore::RenderObject::setStyle):
3059         * rendering/break_lines.cpp:
3060         (WebCore::nextBreakablePosition):
3061
3062 2006-10-28  Adam Roben  <aroben@apple.com>
3063
3064         Reviewed by Maciej.
3065
3066         Fix layout tests that broke after r17399. Mitz discovered that the
3067         failures were caused by HitTestResult::m_point being uninitialized
3068         much of the time. HitTestResults are now always constructed with a
3069         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3070         point instead of being passed one explicitly.
3071
3072         * WebCore.exp: Change constructor symbol.
3073         * bridge/mac/FrameMac.mm:
3074         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3075         hitTest().
3076         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3077         * bridge/mac/WebCoreAXObject.mm:
3078         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3079         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3080         * dom/Document.cpp:
3081         (WebCore::Document::elementFromPoint): Ditto.
3082         (WebCore::Document::prepareMouseEvent): Ditto.
3083         * page/Frame.cpp:
3084         (WebCore::Frame::isPointInsideSelection): Ditto.
3085         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3086         * page/FrameView.cpp:
3087         (WebCore::FrameView::handleWheelEvent): Ditto.
3088         * rendering/HitTestResult.cpp:
3089         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3090         passed point.
3091         * rendering/HitTestResult.h: Update constructor declaration.
3092         * rendering/RenderLayer.cpp:
3093         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3094         hitTest().
3095         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3096         HitTestResult instead of being passed one.
3097         (WebCore::RenderLayer::hitTestLayer): Ditto.
3098         * rendering/RenderLayer.h: Update declarations.
3099
3100 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3101
3102         Reviewed by Anders.
3103
3104         Fix Qt/Linux build.
3105
3106         * CMakeLists.txt:
3107         * platform/qt/FrameQtClient.cpp:
3108         (WebCore::numRequests):
3109         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3110         * platform/qt/PopupMenuQt.cpp:
3111         (WebCore::PopupMenu::updateFromElement):
3112
3113 2006-10-28  David Carson  <dacarson@gmail.com>
3114
3115         Tweaked by Sam. Reviewed by Brady.
3116
3117         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3118         Initialize m_modifyBiasSet to false, as it sometimes gets 
3119         used before it has been initalized.
3120
3121         * editing/SelectionController.cpp:
3122         (WebCore::SelectionController::SelectionController):
3123
3124 2006-10-28  Beth Dakin  <bdakin@apple.com>
3125
3126         Reviewed by Darin.
3127
3128         This is the WebCore half of pushing elementAtPoint and the backend 
3129         of WebElementDictionary into WebCore. Most of the changes below are 
3130         to accommodate one of the following:
3131                 
3132         -NodeInfo is now a stand-alone class called HitTestResult. 
3133                 Previously it was defined in RenderObject.h, but not for 
3134                 any particular reason. The WebElementDictionary 
3135                 functionality that was pushed into WebCore has been pushed 
3136                 specifically into the this class. In fact, 
3137                 WebElementDictionary now keeps a HitTestResult as a member 
3138                 varibale.
3139                 
3140         -The enumeration AccessPolicy is now called 
3141                 ClipboardAccessPolicy and is defined in its own header. It 
3142                 was previously defined in ClipboardMac.h, but is now 
3143                 defined independently to avoid including ClipboardMac.h 
3144                 from within FrameMac.h since FrameMac.h is now included in 
3145                 WebElementDictionary.m in WebKit.
3146                 
3147         -Element now has a virtual target() for the sake of 
3148                 NodeInfo::targetFrame() 
3149
3150         * WebCore.exp: Several WebCore functions are newly called from 
3151         WebKit, so they have been added here. 
3152         * WebCore.xcodeproj/project.pbxproj:
3153         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3154         to ClipboardMac.
3155         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3156         * bridge/mac/FrameMac.mm:
3157         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3158         and HitTestResult changes.
3159         (WebCore::FrameMac::eventMayStartDrag): Same.
3160         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3161         (WebCore::FrameMac::dispatchCPPEvent): Same.
3162         (WebCore::FrameMac::mayDHTMLCut): Same.
3163         (WebCore::FrameMac::mayDHTMLCopy): Same.
3164         (WebCore::FrameMac::mayDHTMLPaste): Same.
3165         (WebCore::FrameMac::tryDHTMLCut): Same
3166         (WebCore::FrameMac::tryDHTMLCopy): Same.
3167         (WebCore::FrameMac::tryDHTMLPaste): Same.
3168         * bridge/mac/WebCoreAXObject.mm:
3169         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3170         HitTestResult changes.
3171         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3172         * bridge/mac/WebCoreFrameBridge.h: Same.
3173         * bridge/mac/WebCoreFrameBridge.mm:
3174         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3175         ClipboardAccessPolicy changes.
3176         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3177         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3178         * dom/Document.cpp:
3179         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3180         changes.
3181         (WebCore::Document::prepareMouseEvent): Same.
3182         * dom/Element.h:
3183         (WebCore::Element::target): Now has a virtual target()
3184         * html/HTMLAnchorElement.h: Same.
3185         * html/HTMLAreaElement.cpp:
3186         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3187         changes.
3188         * html/HTMLAreaElement.h: Virtual target()
3189         * html/HTMLBaseElement.h:
3190         (WebCore::HTMLBaseElement::target): Same.
3191         * html/HTMLFormElement.h: Same.
3192         * html/HTMLLinkElement.h: Same.
3193         * html/HTMLMapElement.cpp:
3194         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3195         changes.
3196         * html/HTMLMapElement.h: Same.
3197         * page/Frame.cpp:
3198         (WebCore::Frame::isPointInsideSelection): Same.
3199         (WebCore::Frame::hitTestResultAtPoint): Same. 
3200         * page/Frame.h: Same.
3201         * page/FrameView.cpp:
3202         (WebCore::FrameView::handleWheelEvent): Same.
3203         * platform/mac/ClipboardAccessPolicy.h: Added.
3204         (WebCore::):
3205         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3206         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3207         ClipboardAccessPolicy.
3208         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3209         (WebCore::ClipboardMac::ClipboardMac):
3210         (WebCore::ClipboardMac::setAccessPolicy):
3211         (WebCore::ClipboardMac::clearData):
3212         (WebCore::ClipboardMac::clearAllData):
3213         (WebCore::ClipboardMac::getData):
3214         (WebCore::ClipboardMac::setData):
3215         (WebCore::ClipboardMac::types):
3216         (WebCore::ClipboardMac::setDragImage):
3217         (WebCore::ClipboardMac::setDropEffect):
3218         (WebCore::ClipboardMac::setEffectAllowed):
3219         * rendering/EllipsisBox.cpp:
3220         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3221         changes.
3222         * rendering/EllipsisBox.h:
3223         * rendering/HitTestResult.cpp: Added.
3224         (WebCore::HitTestResult::HitTestResult):
3225         (WebCore::HitTestResult::~HitTestResult):
3226         (WebCore::HitTestResult::operator=):
3227         (WebCore::HitTestResult::setInnerNode):
3228         (WebCore::HitTestResult::setInnerNonSharedNode):
3229         (WebCore::HitTestResult::setURLElement):
3230         (WebCore::HitTestResult::setScrollbar):
3231         (WebCore::HitTestResult::targetFrame):
3232         (WebCore::HitTestResult::boundingBox):
3233         (WebCore::HitTestResult::isSelected):
3234         (WebCore::HitTestResult::title):
3235         * rendering/HitTestResult.h: Added.
3236         (WebCore::HitTestResult::readonly):
3237         (WebCore::HitTestResult::active):
3238         (WebCore::HitTestResult::mouseMove):
3239         (WebCore::HitTestResult::innerNode):
3240         (WebCore::HitTestResult::innerNonSharedNode):
3241         (WebCore::HitTestResult::point):
3242         (WebCore::HitTestResult::URLElement):
3243         (WebCore::HitTestResult::scrollbar):
3244         (WebCore::HitTestResult::setPoint):
3245         (WebCore::HitTestResult::setReadonly):
3246         (WebCore::HitTestResult::setActive):
3247         (WebCore::HitTestResult::setMouseMove):
3248         * rendering/InlineBox.cpp:
3249         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3250         * rendering/InlineBox.h: Same.
3251         * rendering/InlineFlowBox.cpp:
3252         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3253         * rendering/InlineFlowBox.h: Same.
3254         * rendering/InlineTextBox.cpp: 
3255         (WebCore::InlineTextBox::nodeAtPoint): Same.
3256         * rendering/InlineTextBox.h: Same.
3257         * rendering/RenderBlock.cpp:
3258         (WebCore::RenderBlock::isPointInScrollbar): Same.
3259         (WebCore::RenderBlock::nodeAtPoint): Same.
3260         * rendering/RenderBlock.h: Same.
3261         * rendering/RenderBox.cpp:
3262         (WebCore::RenderBox::nodeAtPoint): Same.
3263         * rendering/RenderBox.h: Same.
3264         * rendering/RenderFlow.cpp:
3265         (WebCore::RenderFlow::hitTestLines): Same.
3266         * rendering/RenderFlow.h: Same.
3267         * rendering/RenderForeignObject.cpp:
3268         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3269         * rendering/RenderForeignObject.h: Same.
3270         * rendering/RenderFrameSet.cpp:
3271         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3272         * rendering/RenderFrameSet.h: Same.
3273         * rendering/RenderImage.cpp:
3274         (WebCore::RenderImage::nodeAtPoint): Same.
3275         * rendering/RenderImage.h: Same.
3276         * rendering/RenderInline.cpp:
3277         (WebCore::RenderInline::nodeAtPoint): Same.
3278         * rendering/RenderInline.h: Same.
3279         * rendering/RenderLayer.cpp:
3280         (WebCore::RenderLayer::autoscroll): Same.
3281         (WebCore::RenderLayer::hitTest): Same.
3282         (WebCore::RenderLayer::hitTestLayer): Same.
3283         (WebCore::RenderLayer::updateHoverActiveState): Same.
3284         * rendering/RenderLayer.h: Same.
3285         * rendering/RenderListBox.cpp:
3286         (WebCore::RenderListBox::isPointInScrollbar): Same.
3287         * rendering/RenderListBox.h: Same.
3288         * rendering/RenderObject.cpp:
3289         (WebCore::RenderObject::hitTest): Same.
3290         (WebCore::RenderObject::setInnerNode): Same.
3291         (WebCore::RenderObject::nodeAtPoint): Same.
3292         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3293         declare HitTestResult.
3294         * rendering/RenderPath.cpp:
3295         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3296         changes.
3297         * rendering/RenderPath.h: Same.
3298         * rendering/RenderSVGImage.cpp:
3299         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3300         * rendering/RenderSVGImage.h: Same
3301         * rendering/RenderSVGText.cpp:
3302         (WebCore::RenderSVGText::nodeAtPoint): Same.
3303         * rendering/RenderSVGText.h: Same.
3304         * rendering/RenderTableRow.cpp:
3305         (WebCore::RenderTableRow::nodeAtPoint): Same.
3306         * rendering/RenderTableRow.h: Same.
3307         * rendering/RenderTableSection.cpp:
3308         (WebCore::RenderTableSection::nodeAtPoint): Same.
3309         * rendering/RenderTableSection.h: Same.
3310         * rendering/RenderText.h: Same.
3311         (WebCore::RenderText::nodeAtPoint): Same.
3312         * rendering/RenderTextControl.cpp:
3313         (WebCore::RenderTextControl::nodeAtPoint): Same.
3314         * rendering/RenderTextControl.h: Same.
3315         * rendering/RootInlineBox.cpp:
3316         (WebCore::RootInlineBox::nodeAtPoint): Same.
3317         * rendering/RootInlineBox.h: Same.
3318
3319 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3320
3321         Reviewed by Anders.
3322
3323         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3324         impact of fixing it again.
3325
3326         * bridge/mac/FrameMac.mm:
3327         (WebCore::FrameMac::clear):
3328
3329 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3330
3331         Reviewed by John & Adam.
3332
3333         - assorted speedups to fix perf regression from fixing correctness regression
3334
3335         * WebCore.exp: exported new methods.
3336         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3337         * bridge/mac/WebCoreFrameBridge.h:
3338         * bridge/mac/WebCoreFrameBridge.mm:
3339         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3340         * loader/CachedResource.h:
3341         * loader/mac/CachedResourceMac.mm: Added.
3342         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3343         now cached in the CachedObject.
3344         * loader/mac/FrameLoader.h:
3345         * loader/mac/FrameLoader.mm:
3346         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3347         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3348         * loader/mac/LoaderFunctionsMac.mm:
3349         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3350         just call loadedResourceFromMemoryCache.
3351         * loader/mac/WebFrameLoaderClient.h:
3352
3353 2006-10-27  Oliver Hunt  <oliver@apple.com>
3354
3355         Reviewed by Maciej.
3356
3357         build fix
3358
3359         * dom/Document.cpp:
3360         (WebCore::Document::referrer):
3361
3362 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3363
3364         Reviewed by Maciej.
3365
3366         Moved some WebCoreFrameBridge functions into FrameLoader.
3367         
3368         I had to make FrameLoader.h capable of compiling in C++-only source files
3369         by adding some forward declarations and __OBJC__ #ifdefs.
3370
3371         * WebCore.exp:
3372         * bridge/mac/FrameMac.h:
3373         * bridge/mac/FrameMac.mm:
3374         (WebCore::FrameMac::createEmptyDocument):
3375         (WebCore::FrameMac::tokenizerProcessedData):
3376         * bridge/mac/WebCoreFrameBridge.h:
3377         * bridge/mac/WebCoreFrameBridge.mm:
3378         * dom/Document.cpp:
3379         (WebCore::Document::processHttpEquiv):
3380         (WebCore::Document::referrer):
3381         * loader/LoaderFunctions.h:
3382         * loader/mac/FrameLoader.h:
3383         * loader/mac/FrameLoader.mm:
3384         (WebCore::numRequests):
3385         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3386         (WebCore::FrameLoader::isReloading):
3387         (WebCore::FrameLoader::referrer):
3388         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3389         (WebCore::FrameLoader::startLoadingResource):
3390         * loader/mac/LoaderFunctionsMac.mm:
3391         (WebCore::CheckIfReloading):
3392         * page/Frame.h:
3393         * page/FrameTree.cpp:
3394         (WebCore::FrameTree::isDescendantOf):
3395         (WebCore::FrameTree::traverseNext):
3396         * page/FrameTree.h:
3397         * platform/network/mac/ResourceLoaderMac.mm:
3398         (WebCore::ResourceLoader::start):
3399
3400 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3401
3402         Reviewed by Darin.
3403
3404         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3405
3406         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3407
3408         * editing/DeleteButtonController.cpp:
3409         (WebCore::isDeletableElement):
3410         (WebCore::enclosingDeletableElement):
3411         (WebCore::DeleteButtonController::respondToChangedSelection):
3412
3413 2006-10-27  John Sullivan  <sullivan@apple.com>
3414
3415         Reviewed by Kevin Decker
3416         
3417         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3418         you haven't not finished reading this.
3419
3420         * rendering/InlineTextBox.h:
3421         * rendering/InlineTextBox.cpp:
3422         (WebCore::InlineTextBox::paint):
3423         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3424         considered also.
3425         (WebCore::InlineTextBox::paintDocumentMarkers):
3426         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3427         markers should be painted, instead of a marker type. This avoids walking the collection of
3428         markers multiple times back to back. Now handles grammar markers.
3429
3430 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3431
3432         Reviewed by Beth.
3433
3434         Renamed Copy Files to Copy Generated Headers.
3435         Copy 4 DOM*Internal.h headers.
3436
3437         * WebCore.xcodeproj/project.pbxproj:
3438         * bindings/scripts/CodeGeneratorObjC.pm:
3439
3440 2006-10-27  John Sullivan  <sullivan@apple.com>
3441
3442         Reviewed by Anders
3443
3444         * WebCore.exp:
3445         exported symbol for FrameMac->advanceToNextSpelling()
3446         
3447         * bridge/mac/WebCoreFrameBridge.h:
3448         * bridge/mac/WebCoreFrameBridge.mm:
3449         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3450
3451 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3452
3453         Reviewed by harrison
3454         
3455         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3456         REGRESSION: First newline missing from textarea's value
3457         
3458         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3459         
3460         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3461         (the line break) then a br to prevent the '\n' from collapsing, since the 
3462         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3463         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3464         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3465         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3466         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3467         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3468         the shadow div will be placeholders or collapsed.
3469         
3470         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3471         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3472         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3473         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3474         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3475         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3476         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3477         before it.
3478         
3479         * editing/CompositeEditCommand.cpp:
3480         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3481         a br or '\n' if content inserted just before it will cause it to collapse.
3482         * editing/CompositeEditCommand.h:
3483         * editing/InsertLineBreakCommand.cpp:
3484         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3485         to prevent a collapse as was used for the line break.  Fixed comments.
3486         * editing/InsertTextCommand.cpp:
3487         (WebCore::InsertTextCommand::input): Call the renamed function.
3488         
3489 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3490
3491         Reviewed by Brady.
3492
3493         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3494         String became an empty NSString *, instead of nil. This will become important
3495         as we start using this conversion more.
3496         
3497         Added work-around for AppKit crash that semantic accuracy revealed.
3498         
3499         No testcase because I don't think there's a way to reflect this change
3500         in a webpage yet.
3501
3502         * platform/PlatformString.h:
3503         (WebCore::String::operator NSString*):
3504         * platform/mac/TextFieldMac.mm:
3505         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3506
3507 2006-10-27  David Harrison  <harrison@apple.com>
3508
3509         Reviewed by Maciej,
3510
3511         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3512
3513         * bridge/mac/WebCoreAXObject.mm:
3514         (blockquoteLevel):
3515         Calculate and return the blockquote level of the element.
3516         
3517         (AXAttributeStringSetBlockquoteLevel):
3518         Add, if non-zero, or clear the block quote level attribute.
3519         
3520         (AXAttributedStringAppendText):
3521         Send AXAttributeStringSetBlockquoteLevel.
3522
3523 2006-10-27  Darin Adler  <darin@apple.com>
3524
3525         - fix one error in the Qt build
3526
3527         * platform/qt/GraphicsContextQt.cpp: