356e0d5d1a2317083f9128a79cb3af81f4098511
[WebKit-https.git] / WebCore / ChangeLog
1 2009-12-18  Brent Fulgham  <bfulgham@webkit.org>
2
3         Build fix, no review.
4
5         * page/win/FrameCairoWin.cpp: Add missing include.
6         * platform/graphics/win/FontCacheWin.cpp:
7         (WebCore::FontCache::createFontPlatformData): Conditionalize
8           Safari-only call.
9
10 2009-12-16  Dumitru Daniliuc  <dumi@chromium.org>
11
12         Reviewed by Dmitry Titov.
13
14         Move some code related to database closing from the destructor to
15         the close() method. This would allow us to do things such as post
16         tasks to other threads when a database closes, which cannot be
17         done now, because we cannot increment the ref count to a database
18         object when we're in its destructor.
19
20         https://bugs.webkit.org/show_bug.cgi?id=32626
21
22         * storage/Database.cpp:
23         (WebCore::Database::~Database):
24         (WebCore::Database::close):
25
26 2009-12-18  Jon Honeycutt  <jhoneycutt@apple.com>
27
28         REGRESSION(r52233): MSAA: Accessibility role of lists is wrong
29
30         https://bugs.webkit.org/show_bug.cgi?id=32736
31
32         Reviewed by Adam Roben.
33
34         Test: platform/win/accessibility/list-role.html
35
36         * accessibility/AccessibilityObject.h:
37         (WebCore::AccessibilityObject::roleValueForMSAA):
38         Return roleValue(), rather than m_role, as subclasses may override it.
39
40         * accessibility/AccessibilityRenderObject.cpp:
41         (WebCore::AccessibilityRenderObject::roleValueForMSAA):
42         Fallback to roleValue(), rather than m_role, as it may be overriden.
43
44 2009-12-17  Jon Honeycutt  <jhoneycutt@apple.com>
45
46         MSAA: Accessibility role of list items is wrong
47
48         https://bugs.webkit.org/show_bug.cgi?id=32688
49
50         Reviewed by Adam Roben.
51
52         Test: platform/win/accessibility/list-item-role.html
53
54         * accessibility/AccessibilityObject.h:
55         (WebCore::):
56         Add a ListItemRole to the enum.
57
58         * accessibility/AccessibilityRenderObject.cpp:
59         (WebCore::msaaRoleForRenderer):
60         Return the role for the RenderObject, or UnknownRole if unknown.
61         (WebCore::AccessibilityRenderObject::roleValueForMSAA):
62         Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
63         back to m_role.
64
65 2009-12-18  Simon Fraser  <simon.fraser@apple.com>
66
67         Reviewed by Darin Adler.
68
69         Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
70         https://bugs.webkit.org/show_bug.cgi?id=31559
71         
72         Fix an array bounds error when accessing the CSS value for a shorthand property that takes
73         a comma-separated list, after the list for one of the component properties has been set to a different length.
74
75         Test: fast/css/shorthand-mismatched-list-crash.html
76
77         * css/CSSMutableStyleDeclaration.cpp:
78         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
79
80 2009-12-18  Simon Fraser  <simon.fraser@apple.com>
81
82         Reviewed by Mark Rowe.
83
84         Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.
85
86         * WebCore.xcodeproj/project.pbxproj:
87
88 2009-12-18  Sam Weinig  <sam@webkit.org>
89
90         Fix mac Geolocation build.
91
92         * DerivedSources.make:
93         * WebCore.ClientBasedGeolocation.exp: Added.
94         * WebCore.xcodeproj/project.pbxproj:
95         * page/Geolocation.h:
96         * page/GeolocationError.h:
97         (WebCore::GeolocationError::GeolocationError):
98         * page/GeolocationPosition.h:
99
100 2009-12-18  Brian Weinstein  <bweinstein@apple.com>
101
102         Reviewed by Adam Roben.
103
104         Fixes <http://webkit.org/b/32613>.
105         REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
106         but should follow the link instead.
107
108         The node itself isn't the only possible node that can be a link (that was the
109         original check), any of its ancestors could be links as well, we need to climb
110         up the tree to see. Created a new function (enclosingAnchorNode), that finds a
111         node's enclosing anchor element (if it exists), that we can share between RenderLayer
112         and Node, and also added tests that test pan scrolling behavior in image maps.
113
114         Tests: platform/win/fast/events/panScroll-image-no-scroll.html
115                platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
116                platform/win/fast/events/panScroll-imageMap-noHref-scroll.html
117
118         * dom/Node.cpp:
119         (WebCore::Node::enclosingAnchorNode):
120         (WebCore::Node::defaultEventHandler):
121         * dom/Node.h:
122         * rendering/RenderLayer.cpp:
123         (WebCore::RenderLayer::hitTest):
124
125 2009-12-18  Benjamin Otte  <otte@gnome.org>
126
127         Reviewed by Xan Lopez.
128
129         [GTK] RemoveDashboard support. It's useless.
130
131         * GNUmakefile.am:
132
133 2009-12-18  Christian Dywan  <christian@twotoasts.de>
134
135         Reviewed by Xan Lopez.
136
137         [GTK] context menu overriding API is very limited
138         https://bugs.webkit.org/show_bug.cgi?id=27546
139
140         Omit SearchWeb from the context menu in the GTK+ port.
141
142         * platform/ContextMenu.cpp:
143         (WebCore::ContextMenu::populate):
144
145 2009-12-18  Sam Weinig  <sam@webkit.org>
146
147         Reviewed by Anders Carlsson.
148
149         Add export the new symbol in WebCoreSystemInterface.
150
151         * WebCore.base.exp:
152         * platform/mac/WebCoreSystemInterface.h:
153         * platform/mac/WebCoreSystemInterface.mm:
154
155 2009-12-18  Sam Weinig  <sam@webkit.org>
156
157         Reviewed by Anders Carlsson.
158
159         Forward declare NSMutableArray when not compiling for Objective-C.
160
161         * platform/mac/WebCoreSystemInterface.h:
162
163 2009-12-18  Gavin Barraclough  <barraclough@apple.com>
164
165         Reviewed by Sam Weinig.
166
167         https://bugs.webkit.org/show_bug.cgi?id=32720
168         Replace UString addition/append with use of JSC::StringBuilder.
169
170         * ForwardingHeaders/runtime/StringBuilder.h: Added.
171         * bindings/js/ScriptString.h:
172         (WebCore::ScriptString::operator+=):
173         * bridge/jni/jni_runtime.cpp:
174         (appendClassName):
175         (JavaMethod::signature):
176         * inspector/InspectorController.cpp:
177         (WebCore::InspectorController::addProfileFinishedMessageToConsole):
178         (WebCore::InspectorController::addStartProfilingMessageToConsole):
179         (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
180
181 2009-12-18  Kenneth Russell  <kbr@google.com>
182
183         Reviewed by Darin Fisher.
184
185         Index validation for drawElements examines too many indices
186         https://bugs.webkit.org/show_bug.cgi?id=32692
187
188         Test: fast/canvas/webgl/bug-32692.html
189
190         * html/canvas/WebGLRenderingContext.cpp:
191         (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
192
193 2009-12-18  Sam Weinig  <sam@webkit.org>
194
195         Reviewed by Anders Carlsson.
196
197         Update WebKitSystemInterface for <rdar://problem/7237059>.        
198
199         * platform/mac/WebCoreSystemInterface.h:
200         * platform/mac/WebCoreSystemInterface.mm:
201
202 2009-12-18  Adam Roben  <aroben@apple.com>
203
204         GTK build fix
205
206         * plugins/gtk/PluginViewGtk.cpp: Added #include.
207
208 2009-12-18  Adam Roben  <aroben@apple.com>
209
210         Chromium build fix
211
212         * platform/chromium/PopupMenuChromium.cpp: Added #include.
213
214 2009-12-18  Adam Roben  <aroben@apple.com>
215
216         Chromium build fix
217
218         * html/HTMLLinkElement.cpp: Added #include.
219
220 2009-12-18  Adam Roben  <aroben@apple.com>
221
222         Qt build fix
223
224         * platform/qt/RenderThemeQt.cpp:
225         * plugins/qt/PluginDataQt.cpp:
226         * plugins/qt/PluginViewQt.cpp:
227         Added #includes.
228
229 2009-12-18  Adam Roben  <aroben@apple.com>
230
231         V8 build fix
232
233         * bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.
234
235 2009-12-18  Adam Roben  <aroben@apple.com>
236
237         GTK (and others?) build fix
238
239         * platform/text/StringImpl.h: Added #include.
240
241 2009-12-18  Adam Roben  <aroben@apple.com>
242
243         Reduce #includes in a few high-use headers
244
245         Removed unnecessary #includes in these headers:
246           - Frame.h
247           - FrameWin.h
248           - Node.h
249           - Page.h
250           - StringImpl.h
251
252         The rest of the patch is all adding #includes to source files that now
253         require them.
254
255         Fixes <http://webkit.org/b/32718>.
256
257         Rubber-stamped by Anders Carlsson.
258
259         * dom/Node.h:
260         * page/Frame.h:
261         * page/Page.h:
262         * page/win/FrameWin.h:
263         * platform/text/StringImpl.h:
264         Removed unnecessary #includes.
265
266         * accessibility/win/AXObjectCacheWin.cpp:
267         * bindings/js/JSDOMWindowBase.cpp:
268         * bindings/js/JSDOMWindowCustom.cpp:
269         * dom/Document.cpp:
270         * dom/InputElement.cpp:
271         * dom/Node.cpp:
272         * dom/SelectElement.cpp:
273         * editing/EditorCommand.cpp:
274         * html/HTMLFormControlElement.cpp:
275         * html/HTMLFormElement.cpp:
276         * html/HTMLMediaElement.cpp:
277         * html/HTMLParser.cpp:
278         * html/HTMLTextAreaElement.cpp:
279         * html/HTMLVideoElement.cpp:
280         * inspector/InspectorController.cpp:
281         * loader/FrameLoader.cpp:
282         * loader/HistoryController.cpp:
283         * loader/appcache/ApplicationCacheGroup.cpp:
284         * page/Console.cpp:
285         * page/EventHandler.cpp:
286         * page/Frame.cpp:
287         * page/FrameView.cpp:
288         * page/Navigator.cpp:
289         * page/PageGroup.cpp:
290         * page/Settings.cpp:
291         * page/mac/EventHandlerMac.mm:
292         * platform/KURL.h:
293         * platform/ScrollbarThemeComposite.cpp:
294         * platform/cf/BinaryPropertyList.cpp:
295         * platform/graphics/mac/GraphicsLayerCA.h:
296         * platform/graphics/win/WKCACFLayerRenderer.cpp:
297         * platform/mac/PopupMenuMac.mm:
298         * platform/mac/WidgetMac.mm:
299         * platform/network/cf/DNSCFNet.cpp:
300         * platform/text/StringImpl.cpp:
301         * platform/win/FileSystemWin.cpp:
302         * platform/win/PlatformScreenWin.cpp:
303         * platform/win/PopupMenuWin.cpp:
304         * platform/win/WidgetWin.cpp:
305         * plugins/PluginView.cpp:
306         * plugins/win/PluginViewWin.cpp:
307         * rendering/InlineTextBox.cpp:
308         * rendering/RenderBox.cpp:
309         * rendering/RenderFileUploadControl.cpp:
310         * rendering/RenderInline.cpp:
311         * rendering/RenderLayerCompositor.cpp:
312         * rendering/RenderObject.cpp:
313         * rendering/RootInlineBox.cpp:
314         * storage/DatabaseTracker.cpp:
315         * storage/DatabaseTracker.h:
316         * storage/SQLTransactionClient.cpp:
317         * svg/graphics/SVGImage.cpp:
318         Added now-needed #includes.
319
320 2009-12-18  Shu Chang  <Chang.Shu@nokia.com>
321
322         Reviewed by Darin Adler.
323
324         Implemented isId as specified by DOM Level 3. See detailed description below.
325         https://bugs.webkit.org/show_bug.cgi?id=5578
326
327         Added isId property and implementation:
328         Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
329                fast/dom/Element/attrisid-extra01.html
330         * dom/Attr.cpp:
331         (WebCore::Attr::isId):
332         * dom/Attr.h:
333         * dom/Attr.idl:
334
335         Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
336         for the reason that id attribute name could be customized to a different
337         string other than "id". A test case is associated to each code change.
338         * dom/Document.cpp:
339         (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
340         * dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
341         (WebCore::Element::setAttribute):
342         (WebCore::Element::setAttributeMap):
343         (WebCore::Element::insertedIntoDocument):
344         (WebCore::Element::removedFromDocument):
345         (WebCore::Element::formatForDebugger):
346         (WebCore::Element::rareIDAttributeName):
347         * dom/Element.h: Added function idAttributeName().
348         (WebCore::Element::idAttributeName):
349         * dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData.
350         (WebCore::ElementRareData::ElementRareData):
351         * dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
352         (WebCore::NamedNodeMap::setNamedItem):
353         (WebCore::NamedNodeMap::removeNamedItem):
354         (WebCore::NamedNodeMap::setAttributes):
355         * dom/Node.cpp: Removed ASSERT as it may not hold any more.
356         (WebCore::Node::querySelector):
357         * dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more.
358         (WebCore::createSelectorNodeList):
359         * dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml
360         (WebCore::StyledElement::parseMappedAttribute):
361         * editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html
362         (WebCore::DeleteButtonController::createDeletionUI):
363         * editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html
364         (WebCore::executeInsertHorizontalRule):
365         * html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html
366         (WebCore::HTMLAppletElement::parseMappedAttribute):
367         (WebCore::HTMLAppletElement::createRenderer):
368         * html/HTMLCollection.cpp:
369         (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html
370         (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
371         * html/HTMLDataGridColElement.cpp:
372         (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html
373         (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
374         * html/HTMLElement.cpp:
375         (WebCore::HTMLElement::parseMappedAttribute):
376         * html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html
377         (WebCore::HTMLFormCollection::getNamedFormItem):
378         (WebCore::HTMLFormCollection::nextNamedItem):
379         (WebCore::HTMLFormCollection::updateNameCache):
380         * html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html
381         (WebCore::HTMLFrameElementBase::parseMappedAttribute):
382         (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
383         * html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html
384         (WebCore::HTMLImageElement::parseMappedAttribute):
385         * html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html
386         (WebCore::HTMLMapElement::parseMappedAttribute):
387         * html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html
388         (WebCore::HTMLNameCollection::itemAfter):
389         * html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html
390         (WebCore::HTMLObjectElement::parseMappedAttribute):
391         * html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html
392         (WebCore::HTMLParamElement::parseMappedAttribute):
393         * loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html
394         (WebCore::CachedFont::getSVGFontById):
395         * rendering/RenderLayerBacking.cpp:
396         (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
397         * rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg
398         (WebCore::writeRenderResources):
399         * svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html
400         (WebCore::SVGElement::insertedIntoDocument):
401         * svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg
402         (WebCore::SVGStyledElement::isKnownAttribute):
403         * wml/WMLElement.cpp:
404         (WebCore::WMLElement::parseMappedAttribute):
405
406 2009-12-18  Simon Hausmann  <simon.hausmann@nokia.com>
407
408         Reviewed by Tor Arne Vestbø.
409
410         [Qt] Clean up the qmake build system to distinguish between trunk builds and package builds
411
412         https://bugs.webkit.org/show_bug.cgi?id=32716
413
414         Introduce standalone_package as config that is set when QTDIR_build is set or when
415         the directory for the generated files is present.
416
417         Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
418         Others remain as they are specific to building inside Qt.
419
420         * WebCore.pro:
421
422 2009-12-18  Simon Hausmann  <simon.hausmann@nokia.com>
423
424         Reviewed by Tor Arne Vestbø.
425
426         [Qt] Fix the build on Symbian.
427
428         Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
429         which is a missing symbol in Qt 4.6.0 on Symbian.
430
431         Functionally they should be equivalent, according to the source.
432
433         * platform/graphics/qt/FontCacheQt.cpp:
434         (WebCore::FontCache::getLastResortFallbackFont):
435
436 2009-12-18  Philippe Normand  <pnormand@igalia.com>
437
438         Reviewed by Xan Lopez.
439
440         [GTK] segfault during controls initialization if not GTK theme is present.
441         https://bugs.webkit.org/show_bug.cgi?id=32705
442
443         Create empty images for the controls if no GTK theme is set.
444
445         * platform/graphics/gtk/ImageGtk.cpp:
446         (WebCore::getThemeIconFileName):
447         (WebCore::loadImageFromFile):
448
449 2009-12-18  Alejandro G. Castro  <alex@igalia.com>
450
451         Reviewed by Darin Adler.
452
453         REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
454         at the beginning.
455         https://bugs.webkit.org/show_bug.cgi?id=31920
456
457         Moving up from a position after the end of the previous lines
458         should use UPSTREAM affinity to render the caret in the previous
459         line.
460
461         Test: editing/selection/wrapped-line-caret-3.html
462
463         * rendering/RenderText.cpp:
464         (WebCore::RenderText::positionForPoint):
465
466 2009-12-17  Eric Seidel  <eric@webkit.org>
467
468         Reviewed by Darin Adler.
469
470         HTMLInputElement::stepMismatch() uses ambiguous overload of pow()
471         https://bugs.webkit.org/show_bug.cgi?id=32675
472
473         Use the double constant 2.0 instead of static_cast<double>(2).
474
475         * html/HTMLInputElement.cpp:
476         (WebCore::HTMLInputElement::stepMismatch):
477
478 2009-12-17  Justin Schuh  <jschuh@chromium.org>
479
480         Reviewed by Dan Bernstein.
481
482         Bug 32357: SVG test case crashes WebKit (invalid font URL)
483         https://bugs.webkit.org/show_bug.cgi?id=32357
484
485         Added check for NULL return value from DocLoader::requestFont()
486
487         * svg/SVGFontFaceUriElement.cpp:
488         (WebCore::SVGFontFaceUriElement::loadFont):
489
490 2009-12-17  Shinichiro Hamaji  <hamaji@chromium.org>
491
492         Reviewed by Dan Bernstein.
493
494         marquee with display:inline causes crash
495         https://bugs.webkit.org/show_bug.cgi?id=32374
496
497         Test: fast/inline/inline-marquee-crash.html
498
499         * html/HTMLMarqueeElement.cpp:
500         (WebCore::HTMLMarqueeElement::start):
501         (WebCore::HTMLMarqueeElement::stop):
502         (WebCore::HTMLMarqueeElement::suspend):
503         (WebCore::HTMLMarqueeElement::resume):
504         (WebCore::HTMLMarqueeElement::renderMarquee):
505         * html/HTMLMarqueeElement.h:
506         * rendering/RenderLayer.cpp:
507         (WebCore::RenderLayer::styleChanged):
508
509 2009-12-17  Zoltan Horvath  <zoltan@webkit.org>
510
511         Reviewed by Darin Adler.
512
513         Allow custom memory allocation control for inspector's classes
514         https://bugs.webkit.org/show_bug.cgi?id=32660                               
515
516         Inherits the following classes from Noncopyable because these are
517         instantiated by 'new' and no need to be copyable:                                           
518
519         class name                  - instantiated at:  WebCore/'location'
520
521         class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72
522         class ConsoleMessage        - inspector/InspectorController.cpp:329 
523         class InspectorController   - page/Page.cpp:119
524
525         * inspector/ConsoleMessage.h:
526         * inspector/InspectorController.h:
527         * inspector/JavaScriptDebugServer.h:
528
529 2009-12-17  Steve Block  <steveblock@google.com>
530
531         Reviewed by Eric Seidel.
532
533         Fixes HTMLInputElement::stepMismatch() to avoid ambiguous overload of pow().
534         https://bugs.webkit.org/show_bug.cgi?id=32675
535
536         Build fix only, no new tests.
537
538         * html/HTMLInputElement.cpp: Modified.
539         (WebCore::HTMLInputElement::stepMismatch): Cast first argument of pow to double to force 'double pow(double, int)'
540
541 2009-12-17  Marc-Antoine Ruel  <maruel@chromium.org>
542
543         Reviewed by Eric Seidel.
544
545         Fix link failure on LTCG builds on Windows for chromium port.
546
547         Reenable SVGAllInOne.cpp. This required some fixups.
548
549         Namely, there was conflicts in constants between HTMLNames and
550         SVGNames, and conflicts between static functions names.
551
552         No new tests as functionality has not changed.
553
554         * WebCore.gyp/WebCore.gyp:
555         * svg/SVGAllInOne.cpp:
556         * svg/SVGFontFaceElement.cpp:
557         (WebCore::SVGFontFaceElement::rebuildFontFace):
558         * svg/SVGGlyphElement.cpp:
559         (WebCore::SVGGlyphElement::invalidateGlyphCache):
560         (WebCore::SVGGlyphElement::buildGlyphIdentifier):
561         * svg/SVGHKernElement.cpp:
562         (WebCore::SVGHKernElement::insertedIntoDocument):
563         (WebCore::SVGHKernElement::removedFromDocument):
564         * svg/SVGStyleElement.cpp:
565         (WebCore::SVGStyleElement::type):
566         (WebCore::SVGStyleElement::setType):
567         (WebCore::SVGStyleElement::media):
568         (WebCore::SVGStyleElement::setMedia):
569         (WebCore::SVGStyleElement::title):
570         (WebCore::SVGStyleElement::setTitle):
571         (WebCore::SVGStyleElement::parseMappedAttribute):
572         * svg/SVGStyledElement.cpp:
573         (WebCore::mapAttributeToCSSProperty):
574         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
575         * svg/SVGStyledElement.h:
576
577 2009-12-17  Adam Roben  <aroben@apple.com>
578
579         Chromium build fix VI
580
581         * svg/animation/SMILTimeContainer.h: Added now-needed #include.
582
583 2009-12-17  Adam Roben  <aroben@apple.com>
584
585         Chromium build fix V
586
587         * platform/KURLGoogle.cpp: Added now-needed #include.
588
589 2009-12-17  Adam Roben  <aroben@apple.com>
590
591         Chromium build fix IV
592
593         * loader/CrossOriginPreflightResultCache.h: Added now-needed
594         #includes.
595
596 2009-12-17  Adam Roben  <aroben@apple.com>
597
598         Chromium build fix III
599
600         * platform/graphics/Font.h: Added now-needed #include.
601
602 2009-12-17  Adam Roben  <aroben@apple.com>
603
604         Chromium build fix II
605
606         * dom/EventTarget.h: Added now-needed #include.
607
608 2009-12-17  Zoltan Horvath  <zoltan@webkit.org>
609
610         Reviewed by Eric Seidel.
611
612         Allow custom memory allocation control for js bindings
613         https://bugs.webkit.org/show_bug.cgi?id=32655
614
615         Inherits the following classes from Noncopyable because these are instantiated 
616         by 'new' and no need to be copyable:
617
618         class name                  - instantiated at:  WebCore/'location'
619
620         class ScriptCachedFrameData - history/CachedFrame.cpp:117
621         class WebCoreJSClientData   - bindings/js/JSDOMWindowBase.cpp:162
622         class ScheduledAction       - bindings/js/ScheduledAction.cpp:58
623
624         * bindings/js/JSDOMBinding.h:
625         * bindings/js/ScheduledAction.h:
626         * bindings/js/ScriptCachedFrameData.h:
627
628 2009-12-17  Adam Roben  <aroben@apple.com>
629
630         Chromium build fix
631
632         * dom/QualifiedName.h: Added now-needed #include of HashTraits.h
633         (which itself #includes HashFunctions.h).
634
635 2009-12-17  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
636
637         Reviewed by Timothy Hatcher.
638
639         Web Inspector: Incorrect Doctype.
640
641         REGRESSION(4.0.4-TOT):Web Inspector: Incorrect Doctype
642         https://bugs.webkit.org/show_bug.cgi?id=32671
643
644         * inspector/InspectorDOMAgent.cpp:
645         (WebCore::InspectorDOMAgent::buildObjectForNode):
646         * inspector/front-end/DOMAgent.js:
647         (WebInspector.DOMNode):
648
649 2009-12-17  Benjamin Otte  <otte@gnome.org>
650
651         Reviewed by Adam Roben.
652
653         Don't include all JSC headers everywhere
654         https://bugs.webkit.org/show_bug.cgi?id=32663
655
656         Remove HashMap HashSet and OwnPtr includes from PlatformString.h.
657         Reduces code size of Gtk build by another 5%.
658
659         * platform/text/PlatformString.h:
660
661 2009-12-17  Adam Roben  <aroben@apple.com>
662
663         Mac/Qt build fixes
664
665         * platform/graphics/mac/Canvas3DLayer.mm:
666         * platform/graphics/mac/GraphicsContext3DMac.cpp:
667         * platform/qt/Localizations.cpp:
668         Added missing #includes.
669
670 2009-12-17  Benjamin Otte  <otte@gnome.org>
671
672         Reviewed by Adam Roben.
673
674         Don't include all JSC headers everywhere
675         https://bugs.webkit.org/show_bug.cgi?id=32663
676
677         PlatformString.h included almost all of JSC via runtime/Identifier.h.
678         This patch gets rid of this include by forward-declaring the required
679         classes instead.
680         This reduces the build size of the object files on a Gtk debug build
681         by 10%. The resulting libwebkit.so gets 5% smaller.
682
683         No new tests as it's just a build improvement.
684
685         * platform/gtk/LocalizedStringsGtk.cpp:
686         include math.h here (it used to be pulled by JSC)
687         * platform/text/PlatformString.h:
688         * platform/text/String.cpp:
689
690 2009-12-17  Evan Martin  <evan@chromium.org>
691
692         Reviewed by Xan Lopez.
693
694         Always use all WebCore include paths in GtkWebKit.
695
696         With this patch, I can disable all optional features and still build.
697
698         * GNUmakefile.am:
699
700 2009-12-17  Yaar Schnitman  <yaar@chromium.org>
701
702         Reviewed by Darin Fisher.
703
704         Added WebPageSerializer to WebKit API.
705
706         https://bugs.webkit.org/show_bug.cgi?id=31737
707
708         * platform/text/StringBuilder.cpp: Added methods to make StringBuilder even more useful for large scale string concatenation.
709         (WebCore::StringBuilder::clear):
710         (WebCore::StringBuilder::length):
711         * platform/text/StringBuilder.h:
712
713 2009-12-10  Philippe Normand  <pnormand@igalia.com>
714
715         Reviewed by Xan Lopez.
716
717         [GTK] Add controls for playing html5 video.
718         https://bugs.webkit.org/show_bug.cgi?id=26304
719
720         Media controls UI, first step. This patch was written by Zan
721         Dobersek. In addition I fixed the compilation errors and
722         re-enabled some of the media tests involving the controls UI.
723
724         * GNUmakefile.am:
725         * css/mediaControlsGtk.css: Added.
726         * platform/graphics/Image.h:
727         * platform/graphics/gtk/ImageGtk.cpp:
728         (WebCore::getThemeIconFileName):
729         (WebCore::loadResourceSharedBuffer):
730         (WebCore::loadImageFromFile):
731         (WebCore::Image::loadPlatformResource):
732         (WebCore::Image::loadPlatformThemeIcon):
733         * platform/gtk/RenderThemeGtk.cpp:
734         (WebCore::getMediaElementFromRenderObject):
735         (WebCore::getIconNameForTextDirection):
736         (WebCore::RenderThemeGtk::initMediaStyling):
737         (WebCore::RenderThemeGtk::RenderThemeGtk):
738         (WebCore::RenderThemeGtk::~RenderThemeGtk):
739         (WebCore::supportsFocus):
740         (WebCore::RenderThemeGtk::baselinePosition):
741         (WebCore::paintMozWidget):
742         (WebCore::setToggleSize):
743         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
744         (WebCore::RenderThemeGtk::gtkContainer):
745         (WebCore::RenderThemeGtk::platformColorsDidChange):
746         (WebCore::RenderThemeGtk::extraMediaControlsStyleSheet):
747         (WebCore::paintMediaButton):
748         (WebCore::RenderThemeGtk::paintMediaFullscreenButton):
749         (WebCore::RenderThemeGtk::paintMediaMuteButton):
750         (WebCore::RenderThemeGtk::paintMediaPlayButton):
751         (WebCore::RenderThemeGtk::paintMediaSeekBackButton):
752         (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
753         (WebCore::RenderThemeGtk::paintMediaSliderTrack):
754         (WebCore::RenderThemeGtk::paintMediaSliderThumb):
755         * platform/gtk/RenderThemeGtk.h:
756
757 2009-12-17  Yael Aharon  <yael.aharon@nokia.com>
758
759         Reviewed by Kenneth Rohde Christiansen.
760
761         [Qt] support navigator.onLine and ononline/onoffline events.
762         https://bugs.webkit.org/show_bug.cgi?id=32555
763
764         Hooked up Bearer Management to NetworkStateNotifier. This solution is available 
765         only if QtMobility's Bearer Management is installed.
766
767         * WebCore.pro:
768         * platform/network/NetworkStateNotifier.h:
769         * platform/network/qt/NetworkStateNotifierPrivate.h: Added.
770         * platform/network/qt/NetworkStateNotifierQt.cpp: Added.
771         (WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
772         (WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
773         (WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate):
774         (WebCore::NetworkStateNotifier::updateState):
775         (WebCore::NetworkStateNotifier::NetworkStateNotifier):
776
777 2009-12-17  Pavel Feldman  <pfeldman@chromium.org>
778
779         Reviewed by Timothy Hatcher.
780
781         Web Inspector: Switch to 11px as default for source-code in WebKit.
782
783         https://bugs.webkit.org/show_bug.cgi?id=32646
784
785         * inspector/front-end/inspector.css:
786
787 2009-12-17  Simon Hausmann  <simon.hausmann@nokia.com>
788
789         Reviewed by Tor Arne Vestbø.
790
791         [Qt] Symbian build fix: Don't include QtXml/qxmlstream.h but omit the prefix, to
792         make sure we pick up the header file from QtCore. That is where the implementation
793         is compiled.
794
795         * dom/XMLTokenizer.h:
796
797 2009-12-17  Martin Robinson  <martin.james.robinson@gmail.com>
798
799         Reviewed by Gustavo Noronha Silva.
800
801         [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
802         https://bugs.webkit.org/show_bug.cgi?id=21599
803
804         Add GRefPtr support for GTK types to WebCore, as JSC does not link against
805         GTK+. Also convert PopupMenu::m_poup from a raw pointer to a GRefPtr.
806
807         No new tests as functionality has not changed.
808
809         * GNUmakefile.am:
810         * platform/PopupMenu.h:
811         * platform/gtk/GRefPtrGtk.cpp: Added.
812         (WTF::refGPtr):
813         (WTF::derefGPtr):
814         * platform/gtk/GRefPtrGtk.h: Added.
815         * platform/gtk/PopupMenuGtk.cpp:
816         (WebCore::PopupMenu::PopupMenu):
817         (WebCore::PopupMenu::~PopupMenu):
818         (WebCore::PopupMenu::show):
819         (WebCore::PopupMenu::hide):
820         (WebCore::PopupMenu::menuRemoveItem):
821
822 2009-12-17  Mikhail Naganov  <mnaganov@chromium.org>
823
824         Reviewed by Pavel Feldman.
825
826         Advice links to source code in CPU profiler to open in debugger,
827         not in resources tab.
828
829         Also work around the case when resources are disabled, but scripts are present.
830
831         https://bugs.webkit.org/show_bug.cgi?id=32610
832
833         * inspector/front-end/Panel.js:
834         (WebInspector.Panel.prototype.updateMainViewWidth):
835         (WebInspector.Panel.prototype.canShowSourceLineForURL):
836         (WebInspector.Panel.prototype.showSourceLineForURL):
837         * inspector/front-end/ProfileDataGridTree.js:
838         (WebInspector.ProfileDataGridNode.prototype.createCell):
839         * inspector/front-end/ResourcesPanel.js:
840         (WebInspector.ResourcesPanel.prototype.canShowSourceLineForURL):
841         (WebInspector.ResourcesPanel.prototype.showSourceLineForURL):
842         * inspector/front-end/ScriptsPanel.js:
843         (WebInspector.ScriptsPanel.prototype.scriptForURL):
844         (WebInspector.ScriptsPanel.prototype.canShowSourceLineForURL):
845         (WebInspector.ScriptsPanel.prototype.showSourceLineForURL):
846         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
847         * inspector/front-end/inspector.js:
848         (WebInspector.documentClick.followLink):
849         (WebInspector.documentClick):
850         (WebInspector._choosePanelToShowSourceLineForURL):
851         (WebInspector.canShowSourceLineForURL):
852         (WebInspector.showSourceLineForURL):
853
854 2009-12-15  Philippe Normand  <pnormand@igalia.com>
855
856         Reviewed by Xan Lopez.
857
858         [GTK] display FPS stats for video element
859         https://bugs.webkit.org/show_bug.cgi?id=32560
860
861         Display FPS statistics if WEBKIT_DEBUG environment variable
862         contains the Media log category. This feature requires a very
863         recent (>= 0.10.18) version of gst-plugins-bad.
864
865         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
866         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
867         (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
868         (WebCore::MediaPlayerPrivate::createGSTPlayBin):
869         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
870
871 2009-11-11  Philippe Normand  <pnormand@igalia.com>
872
873         Reviewed by Gustavo Noronha Silva.
874
875         [GStreamer] Should emit {networkState,readyState,volume,time,size,rate,duration}Changed signals
876         https://bugs.webkit.org/show_bug.cgi?id=30377
877
878         Emit volumeChanged and durationChanged upon notification from
879         GStreamer.
880
881         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
882         (WebCore::mediaPlayerPrivateMessageCallback):
883         (WebCore::mediaPlayerPrivateVolumeCallback):
884         (WebCore::notify_volume_idle_cb):
885         (WebCore::MediaPlayerPrivate::didEnd):
886         (WebCore::MediaPlayerPrivate::durationChanged):
887         (WebCore::MediaPlayerPrivate::createGSTPlayBin):
888         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
889
890 2009-12-16  Philippe Normand  <pnormand@igalia.com>
891
892         Reviewed by Gustavo Noronha Silva.
893
894         [GTK] segfault during volume notification
895         https://bugs.webkit.org/show_bug.cgi?id=32603
896
897         Emit volumeChanged and durationChanged upon notification from
898         GStreamer. Also don't reset the volume property on playbin, it is
899         not needed as it is 1.0 by default both on playbin and in the
900         MediaPlayer.
901
902         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
903         (WebCore::mediaPlayerPrivateMessageCallback):
904         (WebCore::mediaPlayerPrivateVolumeChangedCallback):
905         (WebCore::notifyVolumeIdleCallback):
906         (WebCore::doGstInit):
907         (WebCore::MediaPlayerPrivate::isAvailable):
908         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
909         (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
910         (WebCore::MediaPlayerPrivate::volumeChanged):
911         (WebCore::MediaPlayerPrivate::didEnd):
912         (WebCore::MediaPlayerPrivate::durationChanged):
913         (WebCore::mimeTypeCache):
914         (WebCore::MediaPlayerPrivate::createGSTPlayBin):
915         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
916
917 2009-12-17  Evan Martin  <evan@chromium.org>
918
919         Reviewed by Xan Lopez.
920
921         gtk: always use standard include paths, regardless of settings.
922         WebKit style is to wrap the body of a header in #if ENABLE(FOO),
923         so they're always safe to include whether the features are enabled or
924         not.
925
926         This fixes building with --disable-database and other flags.
927
928         * GNUmakefile.am:
929
930 2009-12-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
931
932         Unreviewed. Build fixes for make distcheck.
933
934         * GNUmakefile.am:
935
936 2009-12-17  Philippe Normand  <pnormand@igalia.com>
937
938         Rubber-stamped by Gustavo Noronha Silva.
939
940         Trivial WebKit coding style fix.
941
942         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
943         (WebCore::MediaPlayerPrivate::paint):
944
945 2009-12-15 MORITA Hajime <morrita@gmail.com>
946
947         Reviewed by Eric Seidel.
948
949         Bug 28306: double-clicking a word inside <b> beside newline select two words
950         https://bugs.webkit.org/show_bug.cgi?id=28306
951         
952         SimplifiedBackwardsTextIterator missed trailing whitespaces just
953         before folding line-break, which is used to detect word
954         boundaries. This fix checks strings on RenderText and expand text
955         range on SimplifiedBackwardsTextIterator to include trailing
956         whitespaces if availble.
957
958         Test: editing/selection/doubleclick-beside-cr-span.html
959
960         * editing/TextIterator.cpp:
961         (WebCore::collapsedSpaceLength):
962         (WebCore::maxOffsetIncludingCollapsedSpaces):
963         (WebCore::SimplifiedBackwardsTextIterator::advance):
964
965 2009-12-16  Fumitoshi Ukai  <ukai@chromium.org>
966
967         Reviewed by Alexey Proskuryakov.
968
969         Fix flakiness in WebSocket handshake console message.
970         https://bugs.webkit.org/show_bug.cgi?id=32598
971
972         In chromium, LayoutTests/websocket/tests/handshake-error.html is
973         flaky, because it outputs the following console message several times:
974           CONSOLE MESSAGE: line 0: Unexpected response code:101
975         Update m_mode in WebSocketHandshake correctly: Once it finds
976         error in handshake message, set m_mode to Failed and don't try
977         reading handshake message again.  If handshake message is not yet
978         fully received, set m_mode to Incomplete, so next didReceiveData()
979         will try to check handshake message again.
980
981         * websockets/WebSocketChannel.cpp:
982         (WebCore::WebSocketChannel::didReceiveData):
983         * websockets/WebSocketHandshake.cpp:
984         (WebCore::WebSocketHandshake::readServerHandshake):
985
986 2009-12-16  Jon Honeycutt  <jhoneycutt@apple.com>
987
988         MSAA: Accessibility role of text nodes is wrong
989
990         https://bugs.webkit.org/show_bug.cgi?id=32631
991         <rdar://problem/7369084>
992
993         Reviewed by Alice Liu.
994
995         Test: platform/win/accessibility/text-role.html
996
997         * accessibility/AccessibilityObject.h:
998         (WebCore::):
999         Add a new role to the enum.
1000         (WebCore::AccessibilityObject::roleValueForMSAA):
1001         Declare a function to return the accessibility role for MSAA; the base
1002         implementation returns the old role value.
1003
1004         * accessibility/AccessibilityRenderObject.cpp:
1005         (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
1006         Initialize m_roleForMSAA.
1007         (WebCore::AccessibilityRenderObject::roleValueForMSAA):
1008         If m_roleForMSAA has been set, return it. If the renderer is a
1009         RenderText, set the role to EditableTextRole to match IE and Firefox.
1010         Otherwise, set the role for MSAA to the old role value.
1011
1012         * accessibility/AccessibilityRenderObject.h:
1013         Add a member to hold the role for MSAA, and declare an override of
1014         roleValueForMSAA().
1015
1016 2009-12-16  Eric Seidel  <eric@webkit.org>
1017
1018         No review, rolling out r52206.
1019         http://trac.webkit.org/changeset/52206
1020         https://bugs.webkit.org/show_bug.cgi?id=31187
1021
1022         This broke pixel tests on Mac.  Presumably the code in
1023         ImageCG is wrong here.
1024
1025         * platform/graphics/BitmapImage.h:
1026         * platform/graphics/GeneratedImage.cpp:
1027         (WebCore::GeneratedImage::drawPattern):
1028         * platform/graphics/GeneratedImage.h:
1029         * platform/graphics/Image.cpp:
1030         (WebCore::Image::drawTiled):
1031         * platform/graphics/Image.h:
1032         * platform/graphics/cairo/ImageCairo.cpp:
1033         (WebCore::Image::drawPattern):
1034         * platform/graphics/cg/ImageCG.cpp:
1035         (WebCore::Image::drawPattern):
1036         * platform/graphics/haiku/ImageHaiku.cpp:
1037         (WebCore::Image::drawPattern):
1038         * platform/graphics/qt/ImageQt.cpp:
1039         (WebCore::Image::drawPattern):
1040         * platform/graphics/skia/ImageSkia.cpp:
1041         (WebCore::Image::drawPattern):
1042         * platform/graphics/wince/GraphicsContextWince.cpp:
1043         (WebCore::GraphicsContext::drawBitmapPattern):
1044         * platform/graphics/wince/ImageBufferWince.cpp:
1045         (WebCore::):
1046         (WebCore::BufferedImage::drawPattern):
1047         * platform/graphics/wx/ImageWx.cpp:
1048         (WebCore::BitmapImage::drawPattern):
1049         (WebCore::Image::drawPattern):
1050
1051 2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>
1052
1053         Reviewed by David Levin.
1054
1055         https://bugs.webkit.org/show_bug.cgi?id=32637
1056         [V8] Generate most named property getters.
1057
1058         Covered by existing tests.
1059
1060         * bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
1061         * bindings/v8/V8DOMWrapper.cpp:
1062         (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.
1063
1064 2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>
1065
1066         Reviewed by Kenneth Rohde Christiansen.
1067
1068         [Qt] Implement combobox delegate for Qt
1069         https://bugs.webkit.org/show_bug.cgi?id=32550
1070
1071         Abstract popup menu factory.
1072
1073         A static method from QtAbstractPopupMenu is used to create its instances. If a factory
1074         has been suplied to class QtAbstractPopupMenu the factory will be used to create the
1075         objects. If not an instance of QtFallbackPopupMenu will be created.
1076
1077         The objective is to make it easy to replace the combobox popup at WebCore layer providing
1078         support to the combobox popup delegation API. Future patches will make it possible to
1079         replace the combobox popup at WebKit layer.
1080
1081         No behavior changes.
1082
1083         * platform/qt/PopupMenuQt.cpp:
1084         (WebCore::PopupMenu::PopupMenu):
1085         * platform/qt/QtAbstractWebPopup.cpp:
1086         (WebCore::QtAbstractWebPopup::setFactory):
1087         (WebCore::QtAbstractWebPopup::create):
1088         * platform/qt/QtAbstractWebPopup.h:
1089         * platform/qt/QtFallbackWebPopup.cpp:
1090
1091 2009-12-16  Mark Rowe  <mrowe@apple.com>
1092
1093         Build fix.  Disable debug variants of WebKit frameworks.
1094
1095         * WebCore.xcodeproj/project.pbxproj:
1096
1097 2009-12-16  Enrica Casucci  <enrica@apple.com>
1098
1099         Reviewed by Eric Seidel.
1100
1101         Right clicking in a table cell creates a selection that extends into the next cell.
1102         <rdar://problem/5565465>
1103         https://bugs.webkit.org/show_bug.cgi?id=32622
1104         
1105         Avoid extending the selection to the next cell if we start from an empty cell.
1106
1107         Test: editing/selection/empty-cell-right-click.html
1108
1109         * editing/TypingCommand.cpp:
1110         (WebCore::TypingCommand::deleteKeyPressed): Replaced the code that check for empty table cell
1111         with a call to the new function.
1112         * editing/VisibleSelection.cpp:
1113         (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Extends the
1114         selection only if we are not starting from an empty table cell.
1115         * editing/htmlediting.cpp:
1116         (WebCore::isEmptyTableCell): Added a function since this check is performed now in two places.
1117         * editing/htmlediting.h: Added isEmptyTableCell declaration.
1118
1119 2009-12-16  Dirk Schulze  <krit@webkit.org>
1120
1121         Reviewed by Nikolas Zimmermann.
1122
1123         feMerge crahses if feMergeNodes attribute in is empty
1124         https://bugs.webkit.org/show_bug.cgi?id=32489
1125
1126         SVGFEMergeElement only stored pointers to all effects of it's nodes
1127         in a list. But it should store the RefPtr otherwise the effects get
1128         dereferenced and WebKit crashes.
1129         I also made a short clean-up in SVGFilterBuilder. No change in
1130         functionality.
1131
1132         Test: I updated svg/custom/empty-merge.svg to cover this problem.
1133
1134         * svg/SVGFEMergeElement.cpp:
1135         (WebCore::SVGFEMergeElement::build):
1136         * svg/graphics/filters/SVGFEMerge.cpp:
1137         (WebCore::FEMerge::FEMerge):
1138         (WebCore::FEMerge::create):
1139         (WebCore::FEMerge::mergeInputs):
1140         (WebCore::FEMerge::setMergeInputs):
1141         * svg/graphics/filters/SVGFEMerge.h:
1142         * svg/graphics/filters/SVGFilterBuilder.cpp:
1143         (WebCore::SVGFilterBuilder::add):
1144
1145 2009-12-16  Brian Weinstein  <bweinstein@apple.com>
1146
1147         Reviewed by Timothy Hatcher.
1148
1149         Part of <http://webkit.org/b/32568>.
1150         Web Inspector: Context Menus should be used in more places.
1151         
1152         Add a context menu entry in the console to clear the console. This
1153         is only shown when there is no user selection of text, because if
1154         there is selection of the text, then we want to give the user the Copy +
1155         Spell Check context menu that they are used to.
1156
1157         * English.lproj/localizedStrings.js: Added "Clear Console".
1158         * inspector/front-end/ConsoleView.js:
1159         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
1160
1161 2009-12-16  Brian Weinstein  <bweinstein@apple.com>
1162
1163         Reviewed by Pavel Feldman.
1164
1165         Fixes <https://bugs.webkit.org/show_bug.cgi?id=32621>.
1166         Web Inspector: [REGRESSION (52095-52100)] Resources filter disappears when switching 
1167         from / to resources panel.
1168
1169         Changed style in sidebar-resizer-vertical, because if the min-height was 100%, we start
1170         to cover the scope bar.
1171
1172         * inspector/front-end/inspector.css:
1173
1174 2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>
1175
1176         Reviewed by Adam Barth.
1177
1178         [V8] Switch all indexers to be generated.
1179         https://bugs.webkit.org/show_bug.cgi?id=32569
1180
1181         Covered by existing tests.
1182
1183         * WebCore.gypi: Remove V8FileListCustom.cpp and V8ClientRecListCustom.cpp,
1184             as they are now generated.
1185         * bindings/v8/V8DOMWrapper.cpp:
1186         (WebCore::V8DOMWrapper::getTemplate): Remove customization of ClientRectList,
1187             FileList, and DataGridColumnList templates.
1188         * bindings/v8/custom/V8ClientRectListCustom.cpp: Removed.
1189         * bindings/v8/custom/V8CustomBinding.h: Remove custom indexer getter decls.
1190         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Remove indexer getter definition.
1191         * bindings/v8/custom/V8FileListCustom.cpp: Removed.
1192
1193 2009-12-16  anton muhin  <antonm@chromium.org>
1194
1195         Reviewed by Darin Adler.
1196
1197         [dom] make dom/Node.cpp compile if DUMP_NODE_STATISTICS is on
1198         https://bugs.webkit.org/show_bug.cgi?id=32617
1199
1200         * dom/Node.cpp:
1201         (WebCore::Node::dumpStatistics):
1202
1203 2009-12-16  Dimitri Glazkov  <dglazkov@chromium.org>
1204
1205         Reviewed by Darin Fisher.
1206
1207         [V8] There is no such thing as HTMLSelectElementCollection.
1208         https://bugs.webkit.org/show_bug.cgi?id=32616
1209
1210         Refactoring, covered by existing tests.
1211
1212         * WebCore.gypi: Removed V8HTMLSelectElementCollectionCustom.cpp
1213         * bindings/v8/V8Collection.h: Removed one-off template.
1214         * bindings/v8/V8DOMWrapper.cpp:
1215         (WebCore::V8DOMWrapper::getTemplate): Renamed all references to HTMLSelectElementCollection
1216             to HTMLSelectElement.
1217         * bindings/v8/custom/V8CustomBinding.h: Renamed custom indexer decls.
1218         * bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Removed.
1219         * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Moved code as-is from
1220             V8HTMLSelectElementCollectionCustom.cpp
1221
1222 2009-12-16  Dan Winship  <danw@gnome.org>
1223
1224         Reviewed by Gustavo Noronha Silva.
1225
1226         [Gtk] Content-Encoding support
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=25855
1229
1230         * platform/network/soup/ResourceHandleSoup.cpp:
1231         (WebCore::startHttp): Don't force "Accept-Encoding: identity" any
1232         more
1233
1234 2009-12-16  Benjamin Otte  <otte@gnome.org>
1235
1236         Reviewed by Darin Adler.
1237
1238         Get rid of the phase argument to Image::drawPattern.
1239         https://bugs.webkit.org/show_bug.cgi?id=31187
1240
1241         The argument can be expressed equally well as part of the
1242         patternTransform. All backends but the Qt one did exactly that
1243         manually anyway.
1244
1245         * platform/graphics/BitmapImage.h:
1246         * platform/graphics/GeneratedImage.cpp:
1247         (WebCore::GeneratedImage::drawPattern):
1248         * platform/graphics/GeneratedImage.h:
1249         * platform/graphics/Image.cpp:
1250         (WebCore::Image::drawTiled):
1251         * platform/graphics/Image.h:
1252         * platform/graphics/cairo/ImageCairo.cpp:
1253         (WebCore::Image::drawPattern):
1254         * platform/graphics/cg/ImageCG.cpp:
1255         (WebCore::Image::drawPattern):
1256         * platform/graphics/haiku/ImageHaiku.cpp:
1257         (WebCore::Image::drawPattern):
1258         * platform/graphics/qt/ImageQt.cpp:
1259         (WebCore::Image::drawPattern):
1260         * platform/graphics/skia/ImageSkia.cpp:
1261         (WebCore::Image::drawPattern):
1262         * platform/graphics/wince/GraphicsContextWince.cpp:
1263         (WebCore::GraphicsContext::drawBitmapPattern):
1264         * platform/graphics/wince/ImageBufferWince.cpp:
1265         (WebCore::):
1266         (WebCore::BufferedImage::drawPattern):
1267         * platform/graphics/wx/ImageWx.cpp:
1268         (WebCore::BitmapImage::drawPattern):
1269         (WebCore::Image::drawPattern):
1270
1271 2009-12-16  Kenneth Russell  <kbr@google.com>
1272
1273         Reviewed by Darin Fisher.
1274
1275         Performance problems with index validation code for drawElements
1276         https://bugs.webkit.org/show_bug.cgi?id=32466
1277
1278         Added a cache of the maximum index for each element type to
1279         WebGLBuffer, querying it before iterating through the indices in
1280         the client-side copy of the buffer's data. Hoisted checks of the
1281         size of the element array itself into validateElementArraySize to
1282         avoid duplicating code.
1283
1284         The performance improvement has been measured with manual tests.
1285         Existing layout tests cover the index validation functionality
1286         and continue to pass as before.
1287
1288         * html/canvas/WebGLBuffer.cpp:
1289         (WebCore::WebGLBuffer::WebGLBuffer):
1290         (WebCore::WebGLBuffer::associateBufferData):
1291         (WebCore::WebGLBuffer::associateBufferSubData):
1292         (WebCore::WebGLBuffer::getCachedMaxIndex):
1293         (WebCore::WebGLBuffer::setCachedMaxIndex):
1294         (WebCore::WebGLBuffer::clearCachedMaxIndices):
1295         * html/canvas/WebGLBuffer.h:
1296         * html/canvas/WebGLRenderingContext.cpp:
1297         (WebCore::WebGLRenderingContext::validateElementArraySize):
1298         (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
1299         (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
1300         (WebCore::WebGLRenderingContext::validateRenderingState):
1301         (WebCore::WebGLRenderingContext::drawElements):
1302         * html/canvas/WebGLRenderingContext.h:
1303
1304 2009-12-16  Zelidrag Hornung  <zelidrag@chromium.org>
1305
1306         Reviewed by Darin Adler.
1307
1308         https://bugs.webkit.org/show_bug.cgi?id=32261
1309         Added ability to separate the autocomplete suggestion previewing from
1310         the actual accepting of the suggested value in HTMLInputElement.
1311         This element (it's single line text incarnation) can now
1312         be put in suggestion mode where renderer might display the suggested
1313         value without making it automatically exposed to JavaScript.
1314
1315         No new tests. This new methods are not exposed yet. It's use will be
1316         platform specific. PopupMenu and Chromium specific changes will be
1317         separated based on Darin Adler's comments.
1318
1319         * dom/InputElement.h:
1320         (WebCore::InputElementData::suggestedValue):
1321         (WebCore::InputElementData::setSuggestedValue):
1322         * html/HTMLInputElement.cpp:
1323         (WebCore::HTMLInputElement::suggestedValue):
1324         (WebCore::HTMLInputElement::setSuggestedValue):
1325         (WebCore::HTMLInputElement::setValue):
1326         (WebCore::HTMLInputElement::setValueFromRenderer):
1327         * html/HTMLInputElement.h:
1328         * rendering/RenderTextControlSingleLine.cpp:
1329         (WebCore::RenderTextControlSingleLine::updateFromElement):
1330         * wml/WMLInputElement.cpp:
1331         (WebCore::WMLInputElement::suggestedValue):
1332         * wml/WMLInputElement.h:
1333
1334 2009-12-16  Pavel Feldman  <pfeldman@chromium.org>
1335
1336         Reviewed by Timothy Hatcher.
1337
1338         Web Inspector: Make Elements tree, properties section and resources
1339         view monospace.
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=32609
1342
1343         * inspector/front-end/ElementsPanel.js:
1344         * inspector/front-end/PropertiesSection.js:
1345         (WebInspector.PropertiesSection):
1346         * inspector/front-end/ResourceView.js:
1347         (WebInspector.ResourceView):
1348         * inspector/front-end/inspector.css:
1349
1350 2009-12-16  Dirk Schulze  <krit@webkit.org>
1351
1352         Reviewed by Darin Adler.
1353
1354         sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
1355         https://bugs.webkit.org/show_bug.cgi?id=32575
1356
1357         On SVG Filters, the rest of the source graphic gets clipped to the filter
1358         rest. This helps us to minimize the size of intermediate ImageBuffers. If
1359         the position moves to the right or to the bottom, we have to adjust the
1360         GraphicContext of this intermediate ImageBuffer.
1361         This patch fixes the adjustment of the context, according to the clipping.
1362
1363         Test: svg/filters/filter-source-position.svg
1364
1365         * svg/graphics/SVGResourceFilter.cpp:
1366         (WebCore::SVGResourceFilter::prepareFilter):
1367
1368 2009-12-16  Enrica Casucci  <enrica@apple.com>
1369
1370         Reviewed by Adele Peterson.
1371
1372         CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
1373         <rdar://problem/7467108>
1374         https://bugs.webkit.org/show_bug.cgi?id=32590
1375
1376         If the element is a button there is no need to look at the children to calculate the caret position.
1377         
1378         Test: editing/selection/button-right-click.html
1379
1380         * dom/Position.cpp:
1381         (WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
1382         when starting from a button element.
1383
1384 2009-12-16  Luiz Agostini  <luiz.agostini@openbossa.org>
1385
1386         Reviewed by Kenneth Rohde Christiansen.
1387
1388         [Qt] Implement combobox delegate for Qt
1389         https://bugs.webkit.org/show_bug.cgi?id=32550
1390
1391         Refactoring of class QWebPopup.
1392
1393         Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
1394         Both new classes are now in corresponding files and files QWebPopup.* have been removed.
1395
1396         Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
1397         in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
1398         public QtWebKit combobox popup delegation API.
1399
1400         Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
1401         It needs to be improved to provide standard features that are missing like style or indentation.
1402
1403         No behavior changes.
1404
1405         * WebCore.pro:
1406         * platform/PopupMenu.h:
1407         * platform/qt/PopupMenuQt.cpp:
1408         (WebCore::PopupMenu::PopupMenu):
1409         * platform/qt/QWebPopup.cpp: Removed.
1410         * platform/qt/QWebPopup.h: Removed.
1411         * platform/qt/QtAbstractWebPopup.cpp: Added.
1412         (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
1413         (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup):
1414         (WebCore::QtAbstractWebPopup::client):
1415         * platform/qt/QtAbstractWebPopup.h: Added.
1416         * platform/qt/QtFallbackWebPopup.cpp: Added.
1417         (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
1418         (WebCore::QtFallbackWebPopup::show):
1419         (WebCore::QtFallbackWebPopup::populate):
1420         (WebCore::QtFallbackWebPopup::showPopup):
1421         (WebCore::QtFallbackWebPopup::hidePopup):
1422         (WebCore::QtFallbackWebPopup::activeChanged):
1423         * platform/qt/QtFallbackWebPopup.h: Added.
1424         (WebCore::QtFallbackWebPopup::hide):
1425
1426 2009-12-15  Pavel Feldman  <pfeldman@chromium.org>
1427
1428         Reviewed by Timothy Hatcher.
1429
1430         Web Inspector: beautify HTTP info section.
1431
1432         https://bugs.webkit.org/show_bug.cgi?id=32583
1433
1434         * English.lproj/localizedStrings.js:
1435         * inspector/front-end/ResourceView.js:
1436         (WebInspector.ResourceView):
1437         (WebInspector.ResourceView.prototype._refreshURL):
1438         (WebInspector.ResourceView.prototype._refreshHTTPInformation):
1439         * inspector/front-end/inspector.css:
1440
1441 2009-12-13  Roland Steiner  <rolandsteiner@chromium.org>
1442
1443         Reviewed by Adam Barth.
1444
1445         Fix crash when encountering illegal HTML within a continuation inside <ruby>.
1446         (https://bugs.webkit.org/show_bug.cgi?id=32316)
1447
1448         Avoid having the anonymous blocks utilized in the ruby renderers being
1449         re-used as continuation blocks.
1450         Avoid having ruby runs collected as "leftover blocks".
1451
1452         Test: fast/ruby/ruby-illegal.html
1453
1454         * rendering/RenderRuby.h:
1455         (WebCore::RenderRubyAsInline::removeLeftoverAnonymousBlock): mustn't be called
1456         (WebCore::RenderRubyAsInline::isRuby): made private
1457         (WebCore::RenderRubyAsInline::renderName): made private
1458         (WebCore::RenderRubyAsInline::createsAnonymousWrapper): return true
1459         (WebCore::RenderRubyAsBlock::removeLeftoverAnonymousBlock): mustn't be called
1460         (WebCore::RenderRubyAsBlock::isRuby): made private
1461         (WebCore::RenderRubyAsBlock::renderName): made private
1462         (WebCore::RenderRubyAsBlock::createsAnonymousWrapper): return true
1463         * rendering/RenderRubyRun.h:
1464         (WebCore::RenderRubyRun::removeLeftoverAnonymousBlock): avoid
1465         (WebCore::RenderRubyRun::isRubyRun): made private
1466         (WebCore::RenderRubyRun::renderName): made private
1467         (WebCore::RenderRubyRun::createsAnonymousWrapper): return true
1468
1469 2009-12-15  Nate Chapin  <japhet@chromium.org>
1470
1471         Reviewed by Darin Adler.
1472
1473         Rename skipCanLoadCheck to skipSecurityCheck in a bunch of places in WebCore/loader.
1474
1475         https://bugs.webkit.org/show_bug.cgi?id=32529
1476
1477         * loader/Cache.cpp:
1478         (WebCore::Cache::requestUserCSSStyleSheet):
1479         * loader/CachedImage.cpp:
1480         (WebCore::CachedImage::load):
1481         * loader/CachedResource.cpp:
1482         (WebCore::CachedResource::load):
1483         * loader/CachedResource.h:
1484         (WebCore::CachedResource::load):
1485         * loader/DocumentThreadableLoader.cpp:
1486         (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
1487         (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
1488         (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
1489         (WebCore::DocumentThreadableLoader::preflightSuccess):
1490         (WebCore::DocumentThreadableLoader::loadRequest):
1491         * loader/DocumentThreadableLoader.h:
1492         * loader/FrameLoaderTypes.h:
1493         (WebCore::):
1494         * loader/Request.cpp:
1495         (WebCore::Request::Request):
1496         * loader/Request.h:
1497         (WebCore::Request::shouldDoSecurityCheck):
1498         * loader/SubresourceLoader.cpp:
1499         (WebCore::SubresourceLoader::create):
1500         * loader/SubresourceLoader.h:
1501         * loader/loader.cpp:
1502         (WebCore::Loader::load):
1503         (WebCore::Loader::Host::servePendingRequests):
1504         * loader/loader.h:
1505
1506 2009-12-15  Dan Bernstein  <mitz@apple.com>
1507
1508         Reviewed by Darin Adler.
1509
1510         <rdar://problem/7470452> Safari/Chromium crashes on complicated @font-face rule
1511         https://bugs.webkit.org/show_bug.cgi?id=32257
1512
1513         Test: fast/css/font-face-unused-source-loaded.html
1514
1515         The loading of a font resource caused a CSSFontFace that had the resource in one of its
1516         sources, but wasn’t using it (due to using an earlier source) to invalidate its
1517         CSSSegmentedFontFaces. This caused FontData for the active source (the one that did not just
1518         finish loading) to be deleted, but that went unnoticed by Font::operator==(), since the
1519         corresponding FontFallbackLists were not in the loading state. The fix is for CSSFontFace to
1520         ignore loads from unused sources.
1521
1522         * css/CSSFontFace.cpp:
1523         (WebCore::CSSFontFace::fontLoaded): Bail out if the loaded source is not the active source.
1524         (WebCore::CSSFontFace::getFontData): Set m_activeSource to the source that supplied the
1525             FontData.
1526         * css/CSSFontFace.h:
1527         (WebCore::CSSFontFace::CSSFontFace): Initialize m_activeSource.
1528
1529 2009-12-15  Yael Aharon  <yael.aharon@nokia.com>
1530
1531         Reviewed by Kenneth Rohde Christiansen.
1532
1533         [Qt] Cannot load flash files from a local file.
1534         https://bugs.webkit.org/show_bug.cgi?id=32572
1535
1536         When loading the main resource and its mime type is application/octet-stream,
1537         use the file extenstion to check if it is a supported plugin.
1538
1539         No new tests were added since any existing swf file can be used as a manual test.
1540
1541         * loader/MainResourceLoader.cpp:
1542         (WebCore::MainResourceLoader::didReceiveResponse):
1543         * loader/MainResourceLoader.h:
1544         * plugins/PluginDatabase.h:
1545
1546 2009-12-15  Brian Weinstein  <bweinstein@apple.com>
1547
1548         Reviewed by Timothy Hatcher.
1549
1550         Fixes <https://bugs.webkit.org/show_bug.cgi?id=18498>.
1551         REGRESSION: Tips are not shown for resources anymore.
1552         
1553         As discussed in the bug, Tips are not coming back, and the feature
1554         will be moved to the audits panel. This patch is to remove the Tips
1555         code and the resources that it needed.
1556
1557         * WebCore.gypi: Removed tips files.
1558         * inspector/front-end/Images/tipBalloon.png: Removed.
1559         * inspector/front-end/Images/tipBalloonBottom.png: Removed.
1560         * inspector/front-end/Images/tipIcon.png: Removed.
1561         * inspector/front-end/Images/tipIconPressed.png: Removed.
1562         * inspector/front-end/Resource.js: Removed tips code.
1563         (WebInspector.Resource.prototype.set finished): 
1564         * inspector/front-end/WebKit.qrc: Removed tips files.
1565         * inspector/front-end/inspector.css: Removes tips style rules.
1566         
1567 2009-12-15  Pavel Feldman  <pfeldman@chromium.org>
1568
1569         Reviewed by Timothy Hatcher.
1570
1571         Web Inspector: Display request headers for main resource
1572         having redirects.
1573
1574         https://bugs.webkit.org/show_bug.cgi?id=32577
1575
1576         * inspector/InspectorController.cpp:
1577         (WebCore::InspectorController::identifierForInitialRequest):
1578         (WebCore::InspectorController::willSendRequest):
1579         * inspector/InspectorResource.cpp:
1580         (WebCore::InspectorResource::InspectorResource):
1581         (WebCore::InspectorResource::appendRedirect):
1582         (WebCore::InspectorResource::createCached):
1583         (WebCore::InspectorResource::updateRequest):
1584         * inspector/InspectorResource.h:
1585         (WebCore::InspectorResource::create):
1586
1587 2009-12-15  Brian Weinstein  <bweinstein@apple.com>
1588
1589         Reviewed by Timothy Hatcher.
1590
1591         Fixes <https://bugs.webkit.org/show_bug.cgi?id=32578>.
1592         Web Inspector: No Need for ?="" now that we have context menus.
1593         
1594         Remove the toggleNewAttributeButton function and callers to it, as
1595         we don't need this behavior anymore, now that we have context menus.
1596
1597         * inspector/front-end/ElementsTreeOutline.js:
1598         (WebInspector.ElementsTreeElement.prototype.set hovered):
1599         (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton):
1600         (WebInspector.ElementsTreeElement.prototype._startEditing):
1601
1602 2009-12-15  Dimitri Glazkov  <dglazkov@chromium.org>
1603
1604         Reviewed by Eric Seidel.
1605
1606         [V8] Generate trivial named property getters.
1607         https://bugs.webkit.org/show_bug.cgi?id=32562
1608
1609         Covered by existing tests.
1610
1611         * bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationNamedPropertyGetter.
1612         * bindings/v8/V8Collection.h:
1613         (WebCore::getNamedPropertyOfCollection): Fixed a booboo by using AtomicString like we're supposed to.
1614         * bindings/v8/V8DOMWrapper.cpp:
1615         (WebCore::V8DOMWrapper::getTemplate): Removed code that's now generated.
1616
1617 2009-12-15  Brian Weinstein  <bweinstein@apple.com>
1618
1619         Reviewed by Timothy Hatcher.
1620
1621         Part of <http://webkit.org/b/32568>.
1622         New Web Inspector: The Context Menu should be used in more places.
1623         
1624         Add support for context menu entries for editing and deleting elements
1625         in the datagrid. This gives support to deleting cookies, and editing and
1626         deleting session storage and local storage.
1627
1628         * English.lproj/localizedStrings.js: Added "Edit" and "Add New" entries (delete was already there)
1629         * inspector/front-end/DataGrid.js:
1630         (WebInspector.DataGrid): Added context menu listener.
1631         (WebInspector.DataGrid.prototype._contextMenuInDataTable):
1632
1633 2009-12-15  Kenneth Russell  <kbr@google.com>
1634
1635         Reviewed by Darin Fisher.
1636
1637         Don't allow default framebuffer to be mutated
1638         https://bugs.webkit.org/show_bug.cgi?id=32391
1639
1640         * html/canvas/WebGLRenderingContext.cpp:
1641         (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
1642         (WebCore::WebGLRenderingContext::framebufferTexture2D):
1643         * platform/graphics/mac/GraphicsContext3DMac.cpp:
1644         (WebCore::GraphicsContext3D::bindFramebuffer):
1645
1646 2009-12-15  Zoltan Horvath  <zoltan@webkit.org>
1647
1648         Reviewed by Darin Adler.
1649
1650         Allow custom memory allocation control for FontPlatformDataCacheKey class
1651         https://bugs.webkit.org/show_bug.cgi?id=32552
1652
1653         Inherits the following struct from FastAllocBase because it is instantiated by 'new':
1654
1655         struct name                     - instantiated at: WebCore/'location'
1656         struct FontPlatformDataCacheKey - platform/graphics/FontCache.cpp:118
1657
1658         * platform/graphics/FontCache.cpp:
1659
1660 2009-12-15  Jian Li  <jianli@chromium.org>
1661
1662         Reviewed by Dmitry Titov.
1663
1664         Bug 31090 - [Chromium] Add DownloadURL format to Chromium clipboard.
1665         https://bugs.webkit.org/show_bug.cgi?id=31090
1666
1667         The proposal to whatwg can be found here:
1668         http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022118.html
1669
1670         * platform/chromium/ChromiumDataObject.cpp:
1671         (WebCore::ChromiumDataObject::clear):
1672         (WebCore::ChromiumDataObject::hasData):
1673         (WebCore::ChromiumDataObject::ChromiumDataObject):
1674         * platform/chromium/ChromiumDataObject.h:
1675         * platform/chromium/ClipboardChromium.cpp:
1676         (WebCore::):
1677         (WebCore::clipboardTypeFromMIMEType):
1678         (WebCore::ClipboardChromium::setData):
1679
1680 2009-12-15  Chris Fleizach  <cfleizach@apple.com>
1681
1682         Reviewed by Darin Adler.
1683
1684         WAI-ARIA: implement treegrid
1685         https://bugs.webkit.org/show_bug.cgi?id=31299
1686
1687         Test: platform/mac/accessibility/aria-treegrid.html
1688
1689         * accessibility/AXObjectCache.cpp:
1690         (WebCore::AXObjectCache::getOrCreate):
1691         * accessibility/AccessibilityARIAGrid.h:
1692         (WebCore::AccessibilityARIAGrid::supportsSelectedRows):
1693         * accessibility/AccessibilityARIAGridRow.cpp:
1694         (WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
1695         (WebCore::AccessibilityARIAGridRow::disclosedRows):
1696         (WebCore::AccessibilityARIAGridRow::disclosedByRow):
1697         * accessibility/AccessibilityARIAGridRow.h:
1698         * accessibility/AccessibilityObject.cpp:
1699         (WebCore::createARIARoleMap):
1700         * accessibility/AccessibilityObject.h:
1701         (WebCore::):
1702         (WebCore::AccessibilityObject::isARIATreeGridRow):
1703         * accessibility/AccessibilityRenderObject.cpp:
1704         (WebCore::AccessibilityRenderObject::isMultiSelectable):
1705         (WebCore::AccessibilityRenderObject::setIsExpanded):
1706         (WebCore::AccessibilityRenderObject::setSelectedRows):
1707         (WebCore::AccessibilityRenderObject::ariaSelectedRows):
1708         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
1709         (WebCore::AccessibilityRenderObject::selectedChildren):
1710         * accessibility/AccessibilityRenderObject.h:
1711         * accessibility/AccessibilityTable.h:
1712         (WebCore::AccessibilityTable::supportsSelectedRows):
1713         * accessibility/mac/AccessibilityObjectWrapper.mm:
1714         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1715         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1716         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1717         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1718
1719 2009-12-15  Zoltan Horvath  <zoltan@webkit.org>
1720
1721         Reviewed by Darin Adler.
1722
1723         Allow custom memory allocation control for EmptyEditorClient and EmptyInspectorClient
1724         https://bugs.webkit.org/show_bug.cgi?id=32557
1725
1726         Inherits the following classes from Noncopyable because these are instantiated
1727         by 'new' and no need to be copyable:
1728
1729         class name                 - instantiated at: WebCore/'location'
1730         class EmptyEditorClient    - svg/graphics/SVGImage.cpp:230
1731         class EmptyInspectorClient - svg/graphics/SVGImage.cpp:241
1732
1733         * loader/EmptyClients.h:
1734
1735 2009-12-15  Zoltan Horvath  <zoltan@webkit.org>
1736
1737         Reviewed by Darin Adler.
1738
1739         Allow custom memory allocation control for WebCore/inspector directory's classes
1740         https://bugs.webkit.org/show_bug.cgi?id=32556
1741
1742         Inherits the following class from Noncopyable because these are instantiated
1743         by 'new' and no need to be copyable:
1744
1745         class name                   - instantiated at: WebCore/'location'
1746         class InspectorFrontend      - inspector/InspectorController.cpp:538
1747         class InspectorTimelineAgent - inspector/InspectorController.cpp:1097
1748
1749         * inspector/InspectorFrontend.h:
1750         * inspector/InspectorTimelineAgent.h:
1751
1752 2009-12-15  Zoltan Horvath  <zoltan@webkit.org>
1753
1754         Reviewed by Darin Adler.
1755
1756         Allow custom memory allocation control for WebCore/platform/network directory's classes
1757         https://bugs.webkit.org/show_bug.cgi?id=32553
1758
1759         Inherits the following class from Noncopyable because it is instantiated
1760         by 'new' and no need to be copyable:
1761
1762         class/struct name                      - instantiated at: WebCore/'location'
1763
1764         struct CrossThreadResourceResponseData - platform/network/ResourceResponseBase.cpp:109
1765
1766         Inherits the following classes from FastAllocBase because these are
1767         instantiated by 'new':
1768
1769         class ResourceResponseBase - (its child class) platform/network/ResourceResponseBase.cpp:90
1770         class ResourceRequestBase  - (its child class) loader/DocumentThreadableLoader.cpp:88
1771
1772         * platform/network/ResourceRequestBase.h:
1773         * platform/network/ResourceResponseBase.h:
1774
1775 2009-12-15  Zoltan Horvath  <zoltan@webkit.org>
1776
1777         Reviewed by Darin Adler.
1778
1779         Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter
1780         https://bugs.webkit.org/show_bug.cgi?id=32549
1781
1782         Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter
1783         classes from Noncopyable because these are instantiated by 'new' and no need to be copyable:
1784
1785         class/struct name              - instantiated at: WebCore/'location'
1786
1787         AnimationControllerPrivate     - page/animation/AnimationController.cpp:439
1788         FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464
1789
1790         * page/animation/AnimationBase.cpp:
1791         * page/animation/AnimationControllerPrivate.h:
1792
1793 2009-12-15  Pavel Feldman  <pfeldman@chromium.org>
1794
1795         Reviewed by Timothy Hatcher.
1796
1797         Web Inspector: Do not lose HTTP redirect information, display it
1798         in the Resources Panel.
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=32551
1801
1802         * inspector/InspectorController.cpp:
1803         (WebCore::InspectorController::populateScriptObjects):
1804         (WebCore::InspectorController::didCommitLoad):
1805         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
1806         (WebCore::InspectorController::identifierForInitialRequest):
1807         (WebCore::InspectorController::willSendRequest):
1808         (WebCore::InspectorController::didReceiveResponse):
1809         (WebCore::InspectorController::didReceiveContentLength):
1810         (WebCore::InspectorController::didFinishLoading):
1811         (WebCore::InspectorController::didFailLoading):
1812         * inspector/InspectorFrontend.cpp:
1813         * inspector/InspectorFrontend.h:
1814         * inspector/InspectorResource.cpp:
1815         (WebCore::InspectorResource::InspectorResource):
1816         (WebCore::InspectorResource::appendRedirect):
1817         (WebCore::InspectorResource::updateScriptObject):
1818         (WebCore::InspectorResource::releaseScriptObject):
1819         (WebCore::InspectorResource::type):
1820         * inspector/InspectorResource.h:
1821         (WebCore::InspectorResource::):
1822         (WebCore::InspectorResource::Changes::setAll):
1823         * inspector/front-end/inspector.js:
1824         (WebInspector._addResource):
1825         (WebInspector.updateResource):
1826
1827 2009-12-15  Holger Hans Peter Freyther  <zecke@selfish.org>
1828
1829         Reviewed by Simon Hausmann.
1830
1831         [Qt] Followup for direct signals and slots connections in QNetworkReplyHandler
1832         https://bugs.webkit.org/show_bug.cgi?id=32113
1833
1834         For Qt versions prior to 4.6.1 we will need to use QueuedConnection
1835         for the signal and slot connection to avoid running into a bug in.
1836
1837         Add a comment that we want to remove one signal to forward
1838         queued items when moving our minimum requirements.
1839
1840         * platform/network/qt/QNetworkReplyHandler.cpp:
1841         (WebCore::QNetworkReplyHandler::start):
1842
1843 2009-12-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1844
1845         Reviewed by Kenneth Rohde Christiansen.
1846
1847         [Qt] Add manual test for JavaScript prompt corner case
1848         https://bugs.webkit.org/show_bug.cgi?id=30914
1849
1850         The patch is based on the work done by Gupta Manish.
1851
1852         Verify behavior of the JavaScript prompt function. Currently
1853         Qt is not behaving like other WebKit ports and Firefox in
1854         regards to accepting the prompt but not entering a text.
1855
1856         * manual-tests/qt/java-script-prompt.html: Added.
1857
1858 2009-12-15  Luiz Agostini  <luiz.agostini@openbossa.org>
1859
1860         Reviewed by Kenneth Rohde Christiansen.
1861
1862         Moving list populate methods from PopupMenuQt to QWebPopup.
1863         
1864         In preparation to future implementation of a delegation API for the combobox.
1865
1866         * platform/PopupMenu.h:
1867         * platform/qt/PopupMenuQt.cpp:
1868         (WebCore::PopupMenu::show):
1869         (WebCore::PopupMenu::hide):
1870         * platform/qt/QWebPopup.cpp:
1871         (WebCore::QWebPopup::show):
1872         (WebCore::QWebPopup::populate):
1873         * platform/qt/QWebPopup.h:
1874         (WebCore::QWebPopup::hide):
1875
1876 2009-12-15  Alexander Pavlov  <apavlov@chromium.org>
1877
1878         Reviewed by Pavel Feldman.
1879
1880         Extract WebInspector.Section from WebInspector.PropertiesSection.
1881         https://bugs.webkit.org/show_bug.cgi?id=32523
1882
1883         * WebCore.gypi:
1884         * WebCore.vcproj/WebCore.vcproj:
1885         * inspector/front-end/PropertiesSection.js:
1886         (WebInspector.PropertiesSection):
1887         * inspector/front-end/Section.js: Added.
1888         (WebInspector.Section):
1889         (WebInspector.Section.prototype.get title):
1890         (WebInspector.Section.prototype.set title):
1891         (WebInspector.Section.prototype.get subtitle):
1892         (WebInspector.Section.prototype.set subtitle):
1893         (WebInspector.Section.prototype.get expanded):
1894         (WebInspector.Section.prototype.set expanded):
1895         (WebInspector.Section.prototype.get populated):
1896         (WebInspector.Section.prototype.set populated):
1897         (WebInspector.Section.prototype.expand):
1898         (WebInspector.Section.prototype.collapse):
1899         (WebInspector.Section.prototype.toggleExpanded):
1900         * inspector/front-end/WebKit.qrc:
1901         * inspector/front-end/inspector.html:
1902
1903 2009-12-15  Eric Seidel  <eric@webkit.org>
1904
1905         No review, rolling out r52140.
1906         http://trac.webkit.org/changeset/52140
1907         https://bugs.webkit.org/show_bug.cgi?id=31299
1908
1909         The commit broke the Leopard bots and unfortunately
1910         Chris wasn't around to fix them, so I'm rolling the change
1911         out after 3 hours so that the bots can roll green again. :)
1912
1913         * accessibility/AXObjectCache.cpp:
1914         (WebCore::AXObjectCache::getOrCreate):
1915         * accessibility/AccessibilityARIAGrid.h:
1916         * accessibility/AccessibilityARIAGridRow.cpp:
1917         * accessibility/AccessibilityARIAGridRow.h:
1918         * accessibility/AccessibilityObject.cpp:
1919         (WebCore::createARIARoleMap):
1920         * accessibility/AccessibilityObject.h:
1921         (WebCore::):
1922         * accessibility/AccessibilityRenderObject.cpp:
1923         (WebCore::AccessibilityRenderObject::isMultiSelect):
1924         (WebCore::AccessibilityRenderObject::setIsExpanded):
1925         (WebCore::AccessibilityRenderObject::setSelectedRows):
1926         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1927         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
1928         (WebCore::AccessibilityRenderObject::selectedChildren):
1929         * accessibility/AccessibilityRenderObject.h:
1930         * accessibility/AccessibilityTable.h:
1931         * accessibility/mac/AccessibilityObjectWrapper.mm:
1932         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1933         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1934         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1935         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1936
1937 2009-12-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1938
1939         Reviewed by Eric Seidel.
1940
1941         [Qt] Remove dead code from FontPlatformDataQt.cpp
1942         https://bugs.webkit.org/show_bug.cgi?id=32540
1943
1944         In r51758 the code that used familyNames was removed
1945         and we should remove the creation of the familyNames
1946         as well.
1947
1948         * platform/graphics/qt/FontPlatformDataQt.cpp:
1949         (WebCore::FontPlatformData::FontPlatformData):
1950
1951 2009-12-15  Dan Bernstein  <mitz@apple.com>
1952
1953         Reviewed by Adam Roben.
1954
1955         WebCore part of <rdar://problem/7173515> Use LOGFONT support in Core
1956         Graphics when available
1957
1958         When using a version of Core Graphics with LOGFONT support, this fixes
1959         <rdar://problem/5764844> First-time launch is painfully slow due to font
1960         plist creation
1961         and <rdar://problem/6576281> 12px synthetic-italics Tahoma text is less
1962         readable in Safari than in Firefox/IE due to poorly-spaced letters
1963
1964         * platform/graphics/win/FontCGWin.cpp:
1965         (WebCore::Font::drawGlyphs): No longer call drawGDIGlyphs for stroked
1966         text.
1967         * platform/graphics/win/FontCacheWin.cpp:
1968         (WebCore::createGDIFont): Added a synthesizeItalic parameter. When set
1969         to true, if italics are desired but the best match lacks italics,
1970         creates and returns a synthetic italics font.
1971         (WebCore::FontCache::createFontPlatformData): Ask to synthesize italics
1972         if needed.
1973         * platform/graphics/win/FontCustomPlatformData.cpp:
1974         (WebCore::FontCustomPlatformData::fontPlatformData): Updated an
1975         assertion, and changed to create the CGFont from the LOGFONT.
1976         (WebCore::createFontCustomPlatformData): Changed cgFont to be a
1977         RetainPtr. Do not create a CGFont from the font data if it can be
1978         created from the LOGFONT in fontPlatformData().
1979         * platform/graphics/win/FontDatabase.cpp:
1980         (WebCore::populateFontDatabase): Avoid font database work if fonts are
1981         not going to be looked up by name.
1982         * platform/graphics/win/FontPlatformDataCGWin.cpp:
1983         (WebCore::FontPlatformData::platformDataInit): Create the CGFont from
1984         a LOGFONT based on the HFONT.
1985
1986 2009-12-14  Chris Fleizach  <cfleizach@apple.com>
1987
1988         Reviewed by Darin Adler.
1989
1990         WAI-ARIA: implement treegrid
1991         https://bugs.webkit.org/show_bug.cgi?id=31299
1992
1993         Test: platform/mac/accessibility/aria-treegrid.html
1994
1995         * accessibility/AXObjectCache.cpp:
1996         (WebCore::AXObjectCache::getOrCreate):
1997         * accessibility/AccessibilityARIAGrid.h:
1998         (WebCore::AccessibilityARIAGrid::supportsSelectedRows):
1999         * accessibility/AccessibilityARIAGridRow.cpp:
2000         (WebCore::AccessibilityARIAGridRow::isARIATreeGridRow):
2001         (WebCore::AccessibilityARIAGridRow::disclosedRows):
2002         (WebCore::AccessibilityARIAGridRow::disclosedByRow):
2003         * accessibility/AccessibilityARIAGridRow.h:
2004         * accessibility/AccessibilityObject.cpp:
2005         (WebCore::createARIARoleMap):
2006         * accessibility/AccessibilityObject.h:
2007         (WebCore::AccessibilityObject::isARIATreeGridRow):
2008         * accessibility/AccessibilityRenderObject.cpp:
2009         (WebCore::AccessibilityRenderObject::isMultiSelectable):
2010         (WebCore::AccessibilityRenderObject::setIsExpanded):
2011         (WebCore::AccessibilityRenderObject::setSelectedRows):
2012         (WebCore::AccessibilityRenderObject::ariaSelectedRows):
2013         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
2014         (WebCore::AccessibilityRenderObject::selectedChildren):
2015         * accessibility/AccessibilityRenderObject.h:
2016         * accessibility/AccessibilityTable.h:
2017         (WebCore::AccessibilityTable::supportsSelectedRows):
2018         * accessibility/mac/AccessibilityObjectWrapper.mm:
2019         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
2020         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2021         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2022         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2023
2024 2009-12-14  Dan Bernstein  <mitz@apple.com>
2025
2026         Reviewed by Darin Adler.
2027
2028         <rdar://problem/7460655> REGRESSION (r47255): Content shifted down at software.opensuse.org
2029         https://bugs.webkit.org/show_bug.cgi?id=32382
2030
2031         Test: fast/block/float/in-margin.html
2032
2033         * rendering/RenderBlock.cpp:
2034         (WebCore::RenderBlock::getClearDelta): Floats that do not intrude into the line (because
2035         they are in the margin) do not need to be cleared.
2036
2037 2009-12-14  Enrica Casucci  <enrica@apple.com>
2038
2039         Reviewed by John Sullivan.
2040
2041         Pressing backspace inside a table cell erases all empty rows below it.
2042         <rdar://problem/5565461>
2043         https://bugs.webkit.org/show_bug.cgi?id=32526
2044
2045         No deletion is performed when the caret selection is on an empty table cell.
2046         
2047         Test: editing/deleting/delete-empty-table.html
2048
2049         * editing/TypingCommand.cpp:
2050         (WebCore::TypingCommand::deleteKeyPressed): Added check for empty table cells in
2051         case of caret selection.
2052
2053 2009-12-14  Andrei Popescu  <andreip@google.com>
2054
2055         Reviewed by Darin Adler.
2056
2057         [Android] Android needs ResourceHandle implementation
2058         https://bugs.webkit.org/show_bug.cgi?id=32515
2059
2060         Adds implementation of ResourceHandle on Android.
2061
2062         No new tests needed, this is platform-specific code, so existing
2063         tests are sufficient.
2064
2065         * platform/network/android/ResourceHandleAndroid.cpp: Added.
2066         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2067         (WebCore::ResourceHandle::~ResourceHandle):
2068         (WebCore::ResourceHandle::start):
2069         (WebCore::ResourceHandle::cancel):
2070         (WebCore::ResourceHandle::bufferedData):
2071         (WebCore::ResourceHandle::supportsBufferedData):
2072         (WebCore::ResourceHandle::setDefersLoading):
2073         (WebCore::ResourceHandle::willLoadFromCache):
2074         (WebCore::ResourceHandle::loadsBlocked):
2075         (WebCore::SyncLoader::SyncLoader):
2076         (WebCore::SyncLoader::~SyncLoader):
2077         (WebCore::SyncLoader::didReceiveResponse):
2078         (WebCore::SyncLoader::didReceiveData):
2079         (WebCore::SyncLoader::didFail):
2080         (WebCore::ResourceHandle::loadResourceSynchronously):
2081         * platform/network/android/ResourceLoaderAndroid.h: Added.
2082         (WebCore::ResourceLoaderAndroid::~ResourceLoaderAndroid):
2083         (WebCore::ResourceLoaderAndroid::ResourceLoaderAndroid):
2084
2085 2009-12-14  Marco Martin  <notmart@gmail.com>
2086
2087         Reviewed by Kenneth Rohde Christiansen.
2088
2089         In the Scrollbar painting of the Qt theme integration,
2090         intersects any previous clip rects with the one needed to paint the scrollbar.
2091         This fixes the painting in QGraphicsview, when the parent of the widget that 
2092         paints the QWebPage has the QGraphicsItem::ItemClipsChildrenToShape set and
2093         a piece of the scrollbar should be cipped away
2094         https://bugs.webkit.org/show_bug.cgi?id=30366
2095
2096         No new tests.
2097
2098         * platform/qt/ScrollbarThemeQt.cpp:
2099         (WebCore::ScrollbarThemeQt::paint):
2100
2101 2009-12-14  Dimitri Glazkov  <dglazkov@chromium.org>
2102
2103         Reviewed by Eric Seidel.
2104
2105         [V8] Generate bindings for trivial indexers.
2106         https://bugs.webkit.org/show_bug.cgi?id=32455
2107
2108         Covered by existing tests.
2109
2110         * bindings/scripts/CodeGeneratorV8.pm:
2111             Added detecting indexers and generating code for them.
2112         * bindings/v8/V8Collection.h: Removed code that's now generated.
2113         * bindings/v8/V8DOMWrapper.cpp:
2114         (WebCore::V8DOMWrapper::getTemplate): Ditto.
2115
2116 2009-12-14  Alexey Proskuryakov  <ap@apple.com>
2117
2118         Reviewed by Dave Hyatt.
2119
2120         https://bugs.webkit.org/show_bug.cgi?id=31660
2121         REGRESSION (r49394): Image load event fires before the document fragment is attached.
2122
2123         Test: fast/images/image-load-event-in-fragment.html
2124
2125         We cannot fire load events immediately after parsing a fragment - an element inserted via
2126         innerHTML or equivalent should be reachable via getElementById() by the time its load event
2127         fires.
2128
2129         * dom/Document.cpp: (WebCore::Document::implicitClose): Call dispatchPendingBeforeLoadEvents()
2130         and dispatchPendingLoadEvents() individually. I'm not sure why these calls are here, just
2131         preserving existing behavior.
2132
2133         * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
2134         * html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
2135         Load events for elements that have just been parsed cannot be dispatched yet, we should give
2136         the elements a chance to be inserted into a document first. There is no compatibility baggage
2137         for beforeload, so it seems OK to dispatch it right away.
2138
2139         * loader/ImageLoader.cpp:
2140         (WebCore::ImageLoader::dispatchPendingBeforeLoadEvents):
2141         (WebCore::ImageLoader::dispatchPendingLoadEvents):
2142         * loader/ImageLoader.h:
2143         Separated dispatchPendingEvents() into individual functions for each event kind.
2144
2145 2009-12-14  Jakob Petsovits  <jpetsovits@rim.com>
2146
2147         Reviewed by Simon Fraser.
2148
2149         Add FloatQuad::isRectilinear() to check whether it can be represented as FloatRect.
2150         https://bugs.webkit.org/show_bug.cgi?id=30442
2151
2152         This enables optimizations for distinguishing between
2153         arbitrary FloatQuads and rectilinear ones.
2154
2155         * platform/graphics/FloatQuad.cpp:
2156         (WebCore::FloatQuad::isRectilinear):
2157         * platform/graphics/FloatQuad.h:
2158
2159 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
2160
2161         Reviewed by Holger Freyther.
2162
2163         [Qt] Add support for keyboard modifiers to TouchEvent
2164
2165         https://bugs.webkit.org/show_bug.cgi?id=32482
2166
2167         Similar to other ui events with keyboard state, get the alt, shift,
2168         meta and ctrl modifiers straight from the platform event.
2169
2170         * dom/TouchEvent.cpp:
2171         (WebCore::TouchEvent::TouchEvent):
2172         (WebCore::TouchEvent::initTouchEvent):
2173         * dom/TouchEvent.h:
2174         (WebCore::TouchEvent::create):
2175         * dom/TouchEvent.idl:
2176         * page/EventHandler.cpp:
2177         (WebCore::EventHandler::handleTouchEvent):
2178         * platform/PlatformTouchEvent.h:
2179         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2180         (WebCore::PlatformTouchEvent::shiftKey):
2181         (WebCore::PlatformTouchEvent::ctrlKey):
2182         (WebCore::PlatformTouchEvent::altKey):
2183         (WebCore::PlatformTouchEvent::metaKey):
2184         * platform/qt/PlatformTouchEventQt.cpp:
2185         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2186
2187 2009-12-14  Benjamin Poulain  <benjamin.poulain@nokia.com>
2188
2189         Reviewed by Kenneth Rohde Christiansen.
2190
2191         [Qt] crash when clicking "Sign out" in GMail
2192         https://bugs.webkit.org/show_bug.cgi?id=32300
2193
2194         When the ResourceLoader cancels the handle we have to make sure not to access
2195         the resource handle afterwards again.
2196         This complete r29515
2197
2198         * platform/network/qt/QNetworkReplyHandler.cpp:
2199         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2200
2201 2009-12-14  Alexander Pavlov  <apavlov@chromium.org>
2202
2203         Reviewed by Pavel Feldman.
2204
2205         Implement InjectedScript.evaluateOnSelf() that evaluates functions in the InjectedScript context.
2206         https://bugs.webkit.org/show_bug.cgi?id=32517
2207
2208         * inspector/front-end/InjectedScript.js:
2209         (InjectedScript.evaluateOnSelf):
2210         * inspector/front-end/InjectedScriptAccess.js:
2211
2212 2009-12-14  Nayan Kumar K  <nayankk@gmail.com>
2213
2214         Reviewed by Darin Adler.
2215
2216         Fix for compilation errors in WML enabled builds.
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=32481
2219
2220         * wml/WMLInputElement.cpp:
2221         (WebCore::WMLInputElement::setValue):
2222         (WebCore::WMLInputElement::setValueForUser):
2223         * wml/WMLInputElement.h:
2224
2225 2009-12-14  Andrei Popescu  <andreip@google.com>
2226
2227         Reviewed by Darin Adler.
2228
2229         [Android] Android needs ResourceError, ResourceResponse and
2230         ResourceRequest implementation.
2231         https://bugs.webkit.org/show_bug.cgi?id=32522
2232
2233         Add implementation of ResourceError, ResourceResponse and ResourceRequest.
2234         No new tests needed, the existing tests should be sufficient.
2235
2236         * platform/network/android/ResourceError.h: Added.
2237         (WebCore::ResourceError::ResourceError):
2238         * platform/network/android/ResourceRequest.h: Added.
2239         (WebCore::ResourceRequest::ResourceRequest):
2240         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2241         (WebCore::ResourceRequest::doUpdateResourceRequest):
2242         (WebCore::ResourceRequest::setUserGesture):
2243         (WebCore::ResourceRequest::getUserGesture):
2244         * platform/network/android/ResourceResponse.h: Added.
2245         (WebCore::ResourceResponse::ResourceResponse):
2246         (WebCore::ResourceResponse::doUpdateResourceResponse):
2247
2248 2009-12-14  Sam Weinig  <sam@webkit.org>
2249
2250         Fix the build.
2251
2252         * page/Geolocation.cpp:
2253         * page/Geolocation.h:
2254
2255 2009-12-13  Sam Weinig  <sam@webkit.org>
2256
2257         Reviewed by Dan Bernstein.
2258
2259         Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
2260         Add client based Geolocation provider
2261
2262         Add first cut of a client based Geolocation provider. This is guarded by
2263         ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
2264         GeolocationControllerClient interface that no-one currently implements,
2265         but will in a subsequent patch.
2266
2267         * GNUmakefile.am:
2268         * WebCore.base.exp:
2269         * WebCore.gypi:
2270         * WebCore.pro:
2271         * WebCore.vcproj/WebCore.vcproj:
2272         * WebCore.xcodeproj/project.pbxproj:
2273         * WebCoreSources.bkl:
2274         * page/Geolocation.cpp:
2275         (WebCore::createGeopositionFromGeolocationPosition):
2276         (WebCore::createPositionErrorFromGeolocationError):
2277         (WebCore::Geolocation::Geolocation):
2278         (WebCore::Geolocation::~Geolocation):
2279         (WebCore::Geolocation::disconnectFrame):
2280         (WebCore::Geolocation::lastPosition):
2281         (WebCore::Geolocation::startRequest):
2282         (WebCore::Geolocation::fatalErrorOccurred):
2283         (WebCore::Geolocation::requestTimedOut):
2284         (WebCore::Geolocation::clearWatch):
2285         (WebCore::Geolocation::handleError):
2286         (WebCore::Geolocation::positionChanged):
2287         (WebCore::Geolocation::makeSuccessCallbacks):
2288         (WebCore::Geolocation::errorOccurred):
2289         (WebCore::Geolocation::geolocationServicePositionChanged):
2290         (WebCore::Geolocation::geolocationServiceErrorOccurred):
2291         (WebCore::Geolocation::startUpdating):
2292         (WebCore::Geolocation::stopUpdating):
2293         * page/Geolocation.h:
2294         * page/GeolocationController.cpp: Added.
2295         (WebCore::GeolocationController::GeolocationController):
2296         (WebCore::GeolocationController::~GeolocationController):
2297         (WebCore::GeolocationController::addObserver):
2298         (WebCore::GeolocationController::removeObserver):
2299         (WebCore::GeolocationController::positionChanged):
2300         (WebCore::GeolocationController::errorOccurred):
2301         (WebCore::GeolocationController::lastPosition):
2302         * page/GeolocationController.h: Added.
2303         * page/GeolocationControllerClient.h: Added.
2304         (WebCore::GeolocationControllerClient::~GeolocationControllerClient):
2305         * page/GeolocationError.h: Added.
2306         (WebCore::GeolocationError::):
2307         (WebCore::GeolocationError::create):
2308         (WebCore::GeolocationError::code):
2309         (WebCore::GeolocationError::message):
2310         * page/GeolocationPosition.h: Added.
2311         (WebCore::GeolocationPosition::create):
2312         (WebCore::GeolocationPosition::timestamp):
2313         (WebCore::GeolocationPosition::latitude):
2314         (WebCore::GeolocationPosition::longitude):
2315         (WebCore::GeolocationPosition::accuracy):
2316         (WebCore::GeolocationPosition::altitude):
2317         (WebCore::GeolocationPosition::altitudeAccuracy):
2318         (WebCore::GeolocationPosition::heading):
2319         (WebCore::GeolocationPosition::speed):
2320         (WebCore::GeolocationPosition::canProvideAltitude):
2321         (WebCore::GeolocationPosition::canProvideAltitudeAccuracy):
2322         (WebCore::GeolocationPosition::canProvideHeading):
2323         (WebCore::GeolocationPosition::canProvideSpeed):
2324         (WebCore::GeolocationPosition::GeolocationPosition):
2325         * page/Geoposition.h:
2326         (WebCore::Geoposition::create):
2327         * page/Page.cpp:
2328         (WebCore::Page::Page):
2329         * page/Page.h:
2330         (WebCore::Page::geolocationController):
2331         * svg/graphics/SVGImage.cpp:
2332         (WebCore::SVGImage::dataChanged):
2333
2334 2009-12-14  Adam Langley  <agl@google.com>
2335
2336         Reviewed by Darin Adler.
2337
2338         Test that an image's size is valid before reading it.
2339
2340         Previously, an image that failed to load (m_failed == true) would
2341         trigger an assertion failure when WebKit tried to get its size.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=32176
2344         http://code.google.com/p/chromium/issues/detail?id=28566
2345
2346         Test: fast/images/size-failure.html
2347
2348         * platform/graphics/ImageSource.cpp:
2349         (WebCore::ImageSource::createFrameAtIndex):
2350
2351 2009-12-14  Dan Bernstein  <mitz@apple.com>
2352
2353         Reviewed by Darin Adler.
2354
2355         <rdar://problem/7458272> REGRESSION (r50470) Reproducible ASSERT in
2356         RenderWidget::setWidgetGeometry()
2357
2358         Test: fast/forms/defer-updateFromElement.html
2359
2360         * html/HTMLFormControlElement.cpp:
2361         (WebCore::updateFromElementCallback): Added this post-attach callback
2362         that invokes updateFromElement().
2363         (WebCore::HTMLFormControlElement::recalcStyle): Instead of calling
2364         updateFromElement(), enqueue a post-attach (in this case, post-style
2365         recalc) callback to do it. updateFromElement() can cause the selection
2366         to change, and in turn trigger synchronous layout, so it must not be
2367         called during style recalc.
2368
2369 2009-12-14  Pavel Feldman  <pfeldman@chromium.org>
2370
2371         Reviewed by Timothy Hatcher.
2372
2373         Web Inspector: [regression] inspector deletes nodes when editing css.
2374
2375         Now all the treeoutlines are focusable, sections and their titles
2376         are also focusable. Change contains couple of drive-by fixes such as
2377         canceling of the attribute edit nuking attr info and maintaining proper
2378         selection while deleting nodes.
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=32460
2381
2382         * inspector/front-end/CallStackSidebarPane.js:
2383         (WebInspector.CallStackSidebarPane.prototype.handleShortcut):
2384         * inspector/front-end/ConsoleView.js:
2385         (WebInspector.ConsoleView.prototype._promptKeyDown):
2386         * inspector/front-end/DataGrid.js:
2387         (WebInspector.DataGrid.prototype._keyDown):
2388         * inspector/front-end/DatabaseQueryView.js:
2389         (WebInspector.DatabaseQueryView):
2390         (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
2391         * inspector/front-end/ElementsPanel.js:
2392         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
2393         (WebInspector.ElementsPanel.prototype.get defaultFocusedElement):
2394         (WebInspector.ElementsPanel.prototype.handleShortcut):
2395         * inspector/front-end/ElementsTreeOutline.js:
2396         (WebInspector.ElementsTreeOutline):
2397         (WebInspector.ElementsTreeOutline.prototype._keyDown):
2398         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
2399         (WebInspector.ElementsTreeElement.prototype._editingCancelled):
2400         * inspector/front-end/Panel.js:
2401         (WebInspector.Panel.prototype.show):
2402         (WebInspector.Panel.prototype.get defaultFocusedElement):
2403         * inspector/front-end/PropertiesSection.js:
2404         (WebInspector.PropertiesSection):
2405         * inspector/front-end/ScriptsPanel.js:
2406         (WebInspector.ScriptsPanel):
2407         (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
2408         (WebInspector.ScriptsPanel.prototype.handleShortcut):
2409         * inspector/front-end/SidebarPane.js:
2410         (WebInspector.SidebarPane):
2411         (WebInspector.SidebarPane.prototype.toggleExpanded):
2412         (WebInspector.SidebarPane.prototype._onTitleKeyDown):
2413         * inspector/front-end/SourceFrame.js:
2414         (WebInspector.SourceFrame.prototype._loaded):
2415         * inspector/front-end/TextPrompt.js:
2416         (WebInspector.TextPrompt):
2417         * inspector/front-end/inspector.css:
2418         * inspector/front-end/inspector.html:
2419         * inspector/front-end/inspector.js:
2420         (WebInspector.loaded):
2421         (WebInspector.documentKeyDown):
2422         (WebInspector.documentCanCopy):
2423         (WebInspector.documentCopy):
2424         (WebInspector._searchFieldManualFocus):
2425         (WebInspector._searchKeyDown):
2426         (WebInspector.startEditing.cleanUpAfterEditing):
2427         (WebInspector.startEditing.keyDownEventListener):
2428         (WebInspector.startEditing):
2429         * inspector/front-end/treeoutline.js:
2430         (TreeOutline):
2431         (TreeOutline._removeChildAtIndex):
2432         (TreeOutline.prototype._treeKeyDown):
2433         (TreeElement.prototype.deselect):
2434         * inspector/front-end/utilities.js:
2435         ():
2436
2437 2009-12-14  Dimitri Glazkov  <dglazkov@chromium.org>
2438
2439         Unreviewed, build fix.
2440
2441         [Chromium] Guard all of JSC's wrapper cache-related members on Document.
2442
2443         * dom/Document.cpp:
2444         (WebCore::Document::createWrapperCache): Widened the guards to the whole method.
2445         * dom/Document.h: Added JSC guards to wrapper cache-related members.
2446
2447 2009-12-14  Chris Fleizach  <cfleizach@apple.com>
2448
2449         Reviewed by Adele Peterson.
2450
2451         AX: there's an infinite loop going on for some webpages - facebook.com
2452         https://bugs.webkit.org/show_bug.cgi?id=32501
2453
2454         The problem is that parentObjectUnignored() cannot be called
2455         while in accessibilityIsIgnored, because it leads to
2456         recursiveness. Specifically, there were checks to determine
2457         if an object was within a ARIA tree. That check should
2458         1) be moved to all platforms, and 2) not call parentObjectUnignored().
2459
2460         Test: accessibility/hang-in-isignored.html
2461
2462         * accessibility/AccessibilityRenderObject.cpp:
2463         (WebCore::AccessibilityRenderObject::isAllowedChildOfTree):
2464         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2465         * accessibility/AccessibilityRenderObject.h:
2466         * accessibility/mac/AccessibilityObjectMac.mm:
2467         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
2468
2469 2009-12-14  Eric Carlson  <eric.carlson@apple.com>
2470
2471         Reviewed by Dan Bernstein.
2472
2473         <rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
2474
2475         Use MediaControllerThemeQuickTime on Leopard.
2476
2477         * rendering/RenderThemeMac.mm:
2478         (WebCore::mediaControllerTheme):
2479
2480 2009-12-14  Adam Roben  <aroben@apple.com>
2481
2482         Move QuartzCore-related build settings into a vsprops file
2483
2484         Fixes <http://webkit.org/b/32518>
2485
2486         Reviewed by Dan Bernstein.
2487
2488         * WebCore.vcproj/WebCore.vcproj: Let VS reformat the files list, added
2489         WebCoreQuartzCore.vsprops to the non-Cairo configurations, moved all
2490         other QuartzCore-related build settings from here...
2491         * WebCore.vcproj/WebCoreQuartzCore.vsprops: ...to here.
2492
2493 2009-12-14  Yael Aharon  <yael.aharon@nokia.com>
2494
2495         Reviewed by Antti Koivisto.
2496
2497         handling scripts can block UI
2498         https://bugs.webkit.org/show_bug.cgi?id=27612
2499
2500         Break execution of external scrips to smaller chunks. 
2501         No new tests since no new functionality was introduced.
2502
2503         * html/HTMLTokenizer.cpp:
2504         (WebCore::HTMLTokenizer::HTMLTokenizer):
2505         (WebCore::HTMLTokenizer::reset):
2506         (WebCore::HTMLTokenizer::notifyFinished):
2507         (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):
2508         (WebCore::HTMLTokenizer::executeExternalScriptsTimerFired):
2509         (WebCore::HTMLTokenizer::continueExecutingExternalScripts):
2510         * html/HTMLTokenizer.h:
2511
2512 2009-12-03  Holger Hans Peter Freyther  <zecke@selfish.org>
2513
2514         Reviewed by Simon Hausmann.
2515
2516         [Qt] Connect QNetworkReply via direct connections.
2517         https://bugs.webkit.org/show_bug.cgi?id=32113
2518
2519         In the past we have switched from auto connections to queued
2520         connections to get some more stability. The problem with the
2521         Queued connections is latency. Even when running simple loading
2522         tests the time it takes to runs highly varies and by using
2523         direct connections these tests produce a stable result.
2524
2525         We will have to look out for crashes coming from within the
2526         QNetworkAccessManager due this patch and address them then.
2527
2528         * platform/network/qt/QNetworkReplyHandler.cpp:
2529         (WebCore::QNetworkReplyHandler::start):
2530
2531 2009-12-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2532
2533         Rubber-stamped by Simon Hausmann.
2534
2535         [Qt] QtWebKit should use QImageReader::setQuality(49)
2536         https://bugs.webkit.org/show_bug.cgi?id=30740
2537
2538         Using QImageReader::setQuality(49) will influence the JPEG
2539         decoder of Qt to use the JDCT_IFAST routines for decompressing. This
2540         is showing a 5% improvement in a reduction that decodes all images
2541         used during the page loading test. The libjpeg documentation mentions
2542         that the IFAST routine is not as accurate as other routines but in
2543         our tests we couldn't see a difference.
2544
2545         * platform/graphics/qt/ImageDecoderQt.cpp:
2546         (WebCore::ImageDecoderQt::setData):
2547
2548 2009-12-13  Geoffrey Garen  <ggaren@apple.com>
2549
2550         Reviewed by Sam Weinig.
2551         
2552         Changed GC from mark-sweep to mark-allocate.
2553
2554         * ForwardingHeaders/runtime/WeakGCMap.h: Added.
2555         * bindings/js/GCController.cpp:
2556         (WebCore::collect):
2557         (WebCore::GCController::gcTimerFired):
2558         (WebCore::GCController::garbageCollectNow): Updated for rename.
2559
2560         * bindings/js/JSDOMBinding.cpp:
2561         (WebCore::removeWrappers):
2562         (WebCore::hasCachedDOMObjectWrapperUnchecked):
2563         (WebCore::hasCachedDOMObjectWrapper):
2564         (WebCore::hasCachedDOMNodeWrapperUnchecked):
2565         (WebCore::forgetDOMObject):
2566         (WebCore::forgetDOMNode):
2567         (WebCore::isObservableThroughDOM):
2568         (WebCore::markDOMNodesForDocument):
2569         (WebCore::markDOMObjectWrapper):
2570         (WebCore::markDOMNodeWrapper):
2571         * bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.
2572         Don't ASSERT that an item must be in the WeakGCMap when its destructor
2573         runs, since it might have been overwritten in the map first.
2574
2575         * bindings/js/JSDocumentCustom.cpp:
2576         (WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
2577         wrapper, to simplify some code.
2578
2579         * bindings/js/JSInspectedObjectWrapper.cpp:
2580         (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
2581         (WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):
2582         * bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these
2583         wrappers.
2584
2585         * bindings/js/JSNodeCustom.cpp:
2586         (WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
2587         a DOM node wrapper instead of a DOM object wrapper.
2588
2589         * bindings/js/JSSVGPODTypeWrapper.h:
2590         (WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
2591         (WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
2592         (WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
2593         (WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity light
2594         on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
2595         of linear lookup through iteration, since that's what hashtables were
2596         invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
2597         from the table, instead of its JS wrapper, to decouple these objects from
2598         GC, and because these objects are refCounted, not solely owned by their
2599         JS wrappers.
2600
2601         * bindings/scripts/CodeGeneratorJS.pm:
2602         * dom/Document.h: Adopted changes above.
2603
2604 2009-12-13  Geoffrey Garen  <ggaren@apple.com>
2605
2606         Windows build fix: Removed an incorrect #ifdef.
2607
2608         * bindings/js/GCController.cpp:
2609
2610 2009-12-13  Charles Reis  <creis@chromium.org>
2611
2612         Reviewed by Adam Barth.
2613
2614         Refactor some security code out of V8 bindings
2615         https://bugs.webkit.org/show_bug.cgi?id=32326
2616
2617         No new tests. There should be no functionality changes in this patch,
2618         since it is only refactoring code.
2619
2620         * WebCore.gyp/WebCore.gyp:
2621         * WebCore.gypi:
2622         * bindings/BindingSecurity.h: Added.
2623         (WebCore::BindingSecurity::BindingSecurity):
2624         (WebCore::::canAccessWindow):
2625         (WebCore::::canAccessFrame):
2626         (WebCore::::checkNodeSecurity):
2627         * bindings/BindingSecurityBase.cpp: Added.
2628         (WebCore::BindingSecurityBase::getDOMWindow):
2629         (WebCore::BindingSecurityBase::getFrame):
2630         (WebCore::BindingSecurityBase::canAccessWindow):
2631         * bindings/BindingSecurityBase.h: Added.
2632         * bindings/GenericBinding.h: Added.
2633         (WebCore::):
2634         * bindings/scripts/CodeGeneratorV8.pm:
2635         * bindings/v8/ScriptController.cpp:
2636         (WebCore::ScriptController::isSafeScript):
2637         * bindings/v8/V8Binding.h:
2638         * bindings/v8/V8BindingState.cpp: Added.
2639         (WebCore::::Only):
2640         (WebCore::::getActiveWindow):
2641         (WebCore::::immediatelyReportUnsafeAccessTo):
2642         * bindings/v8/V8BindingState.h: Added.
2643         (WebCore::):
2644         * bindings/v8/V8Proxy.cpp:
2645         (WebCore::V8Proxy::reportUnsafeAccessTo):
2646         (WebCore::reportUnsafeJavaScriptAccess):
2647         * bindings/v8/V8Proxy.h:
2648         (WebCore::V8Proxy::):
2649         * bindings/v8/custom/V8CustomBinding.cpp:
2650         (WebCore::allowSettingFrameSrcToJavascriptUrl):
2651         (WebCore::INDEXED_ACCESS_CHECK):
2652         (WebCore::NAMED_ACCESS_CHECK):
2653         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2654         (WebCore::V8Custom::WindowSetTimeoutImpl):
2655         (WebCore::ACCESSOR_GETTER):
2656         (WebCore::ACCESSOR_SETTER):
2657         (WebCore::CALLBACK_FUNC_DECL):
2658         (WebCore::V8Custom::ClearTimeoutImpl):
2659         (WebCore::NAMED_ACCESS_CHECK):
2660         (WebCore::INDEXED_ACCESS_CHECK):
2661         * bindings/v8/custom/V8LocationCustom.cpp:
2662         (WebCore::ACCESSOR_GETTER):
2663         (WebCore::CALLBACK_FUNC_DECL):
2664         (WebCore::INDEXED_ACCESS_CHECK):
2665         (WebCore::NAMED_ACCESS_CHECK):
2666
2667 2009-11-30  Holger Hans Peter Freyther  <zecke@selfish.org>
2668
2669         Reviewed by Simon Hausmann.
2670
2671         [Qt] Implement initializeMaximumHTTPConnectionCountPerHost.
2672         https://bugs.webkit.org/show_bug.cgi?id=31849
2673
2674         Qt allows to have three connections per host on Symbian, for
2675         every other platform the limit is set to six connections per
2676         host but the default implementation will only schedule four
2677         connections per host.
2678         In a manual test we seem to get the best loading speed by
2679         going with Qt's limit and schedule two more jobs to allow Qt
2680         to prepare them.
2681
2682         * platform/network/ResourceRequestBase.cpp:
2683         * platform/network/qt/ResourceRequestQt.cpp:
2684         (WebCore::initializeMaximumHTTPConnectionCountPerHost):
2685
2686 2009-12-13  Dan Bernstein  <mitz@apple.com>
2687
2688         Reviewed by Simon Fraser.
2689
2690         <rdar://problem/7341364> Crash at HTMLParser::popOneBlockCommon() after
2691         handling misnested residual style tags
2692
2693         Test: fast/parser/residual-style-close-ref-clone.html
2694
2695         * html/HTMLParser.cpp:
2696         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Gave the
2697         block stack a strong reference to the cloned residual style element. 
2698
2699 2009-12-13  Adele Peterson  <adele@apple.com>
2700
2701         Reviewed by Sam Weinig.
2702
2703         Reverting changes from http://trac.webkit.org/changeset/49585 to fix:
2704         <rdar://problem/7382815> REGRESSION (4.0.4-TOT): Home photo slider is too narrow at http://www.ziprealty.com/
2705         https://bugs.webkit.org/show_bug.cgi?id=32078
2706
2707         * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
2708
2709 2009-12-08  Jeremy Moskovich  <jeremy@chromium.org>
2710
2711         Reviewed by Eric Seidel.
2712
2713         Add code to allow toggling ATSUI/Core Text rendering at runtime in ComplexTextController.
2714         https://bugs.webkit.org/show_bug.cgi?id=31802
2715
2716         The goal here is to allow for a zero runtime hit for ports that decide to select
2717         the API at compile time.
2718         When both USE(ATSUI) and USE(CORE_TEXT) are true, the API is toggled
2719         at runtime.  Core Text is used for OS Versions >= 10.6.
2720
2721         No test since this is already covered by existing pixel tests.
2722
2723         * platform/graphics/SimpleFontData.h:  Change #ifdef to define getNSFont() on Chrome/Mac .
2724         * platform/graphics/mac/ComplexTextController.cpp:
2725         (WebCore::shouldUseATSUIAPI): Cache decision about which API to use.
2726         (WebCore::ComplexTextController::ComplexTextRun::indexAt):
2727         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Stub function to call through
2728         to ATSUI/Core text variants.
2729         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): The actual work for object construction
2730         is delegate to createTextRunFromFontDataATSUI/createTextRunFromFontDataCoreText.
2731         * platform/graphics/mac/ComplexTextController.h:
2732         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
2733         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Small style fix.
2734         (WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataATSUI):
2735         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
2736         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
2737         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
2738         (WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText):
2739         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
2740
2741 2009-12-13  Eric Carlson  <eric.carlson@apple.com>
2742
2743         No review, rolling out r52059 until I can generate new Tiger
2744         test results.
2745
2746         * rendering/RenderThemeMac.mm:
2747         (WebCore::mediaControllerTheme):
2748
2749 2009-12-12  Sam Weinig  <sam@webkit.org>
2750
2751         Rubber-stamped by Dan Bernstein.
2752
2753         Fix the EXPERIMENTAL_SINGLE_VIEW_MODE build.
2754
2755         * Configurations/WebCore.xcconfig:
2756         * page/EventHandler.cpp:
2757         (WebCore::EventHandler::EventHandler):
2758         (WebCore::EventHandler::clearDragState):
2759         * page/mac/DragControllerMac.mm:
2760         (WebCore::DragController::isCopyKeyDown):
2761         * page/mac/EventHandlerMac.mm:
2762         (WebCore::EventHandler::eventActivatedView):
2763         * platform/PlatformKeyboardEvent.h:
2764         * platform/PlatformMouseEvent.h:
2765         * platform/PlatformWheelEvent.h:
2766         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2767         * platform/ScrollView.cpp:
2768         (WebCore::ScrollView::wheelEvent):
2769         * platform/mac/KeyEventMac.mm:
2770         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2771         * platform/mac/PlatformMouseEventMac.mm:
2772         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2773         * platform/mac/PopupMenuMac.mm:
2774         (WebCore::PopupMenu::show):
2775         * platform/mac/WidgetMac.mm:
2776
2777 2009-12-12  Sam Weinig  <sam@webkit.org>
2778
2779         Rubber-stamped by Dan Bernstein.
2780
2781         Fix the !ENABLE(VIDEO) build.
2782
2783         * rendering/RenderLayerCompositor.cpp:
2784         (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
2785
2786 2009-12-12  Sam Weinig  <sam@webkit.org>
2787
2788         Rubber-stamped by Dan Bernstein.
2789
2790         Fix the !ENABLE(DATABASE) build.
2791
2792         * storage/SQLTransactionClient.cpp:
2793         * storage/SQLTransactionClient.h:
2794         * storage/SQLTransactionCoordinator.cpp:
2795         * storage/SQLTransactionCoordinator.h:
2796         * loader/FrameLoader.cpp:
2797         (WebCore::FrameLoader::stopLoading):
2798
2799 2009-12-12  Eric Carlson  <eric.carlson@apple.com>
2800
2801         Reviewed by Dan Bernstein.
2802
2803         <rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows
2804
2805         Use MediaControllerThemeQuickTime on Leopard.
2806
2807         * rendering/RenderThemeMac.mm:
2808         (WebCore::mediaControllerTheme):
2809
2810 2009-12-12  Kenneth Russell  <kbr@google.com>
2811
2812         Reviewed by Oliver Hunt.
2813
2814         Errors in WebGL[T]Array set() and get() methods
2815         https://bugs.webkit.org/show_bug.cgi?id=32456
2816
2817         Test: fast/canvas/webgl/bug-32456.html
2818
2819         * bindings/js/JSWebGLFloatArrayCustom.cpp:
2820         (WebCore::JSWebGLFloatArray::set):
2821         * bindings/js/JSWebGLIntArrayCustom.cpp:
2822         (WebCore::JSWebGLIntArray::set):
2823         * bindings/js/JSWebGLShortArrayCustom.cpp:
2824         (WebCore::JSWebGLShortArray::set):
2825         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
2826         (WebCore::JSWebGLUnsignedByteArray::set):
2827         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2828         (WebCore::JSWebGLUnsignedIntArray::set):
2829         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
2830         (WebCore::JSWebGLUnsignedShortArray::set):
2831         * bindings/v8/custom/V8WebGLArrayCustom.h:
2832         (WebCore::setWebGLArray):
2833         * html/canvas/WebGLFloatArray.idl:
2834         * html/canvas/WebGLUnsignedIntArray.idl:
2835
2836 2009-12-12  Kenneth Russell  <kbr@google.com>
2837
2838         Reviewed by Oliver Hunt.
2839
2840         Update WebGL tests to released versions
2841         https://bugs.webkit.org/show_bug.cgi?id=32457
2842
2843         * manual-tests/webgl/Earth.html:
2844         * manual-tests/webgl/ManyPlanetsDeep.html:
2845         * manual-tests/webgl/SpinningBox.html:
2846         * manual-tests/webgl/TeapotPerPixel.html:
2847         * manual-tests/webgl/TeapotPerVertex.html:
2848         * manual-tests/webgl/resources/CanvasMatrix.js:
2849         (CanvasMatrix4.prototype.getAsWebGLFloatArray):
2850         * manual-tests/webgl/resources/utils3d.js:
2851         (initWebGL.gl.console.window.console.log):
2852         (initWebGL):
2853         (loadShader):
2854         (makeBox):
2855         (makeSphere):
2856         (processLoadObj):
2857         (doLoadObj):
2858         (doLoadImageTexture):
2859
2860 2009-12-12  Christian Dywan  <christian@twotoasts.de>
2861
2862         Reviewed by Dirk Schulze.
2863
2864         Remove the include to SVGFEDisplacementMap.h, it's not needed at all.
2865
2866         * platform/graphics/filters/FEComponentTransfer.h:
2867
2868 2009-12-12  Christian Dywan  <christian@twotoasts.de>
2869
2870         Rubber-stamped by Maciej Stachowiak.
2871
2872         Only include SVGFEDisplacementMap.h if SVG is enabled.
2873
2874         * platform/graphics/filters/FEComponentTransfer.h:
2875
2876 2009-12-12  Dirk Schulze  <krit@webkit.org>
2877
2878         Reviewed by Eric Seidel.
2879
2880         [Cairo][Qt] Alpha blending in SVG filters is wrong
2881         https://bugs.webkit.org/show_bug.cgi?id=32427
2882
2883         This patch is a follow-up to:
2884         http://trac.webkit.org/changeset/51950
2885         It fixes the alpha blending for Cairo and Qt on SVG Filters.
2886
2887         Covered by: * LayoutTests/svg/filters/feGaussianBlur.svg
2888                     * LayoutTests/svg/filters/feComposite.svg
2889                      and others.
2890
2891         * platform/graphics/cairo/ImageBufferCairo.cpp:
2892         (WebCore::ImageBuffer::platformTransformColorSpace):
2893         * platform/graphics/qt/ImageBufferQt.cpp:
2894         (WebCore::ImageBuffer::platformTransformColorSpace):
2895
2896 2009-12-11  Eric Roman  <eroman@chromium.org>
2897
2898         Unreviewed build fix.
2899
2900         [V8] Add a method on ScriptController to get it compiling after http://trac.webkit.org/changeset/52033.
2901
2902         * bindings/v8/ScriptController.cpp:
2903         (WebCore::ScriptController::anyPageIsProcessingUserGesture):
2904         * bindings/v8/ScriptController.h:
2905
2906 2009-12-11  Dimitri Glazkov  <dglazkov@chromium.org>
2907
2908         Unreviewed, build fix.
2909
2910         [V8] Change bindings to catch up with http://trac.webkit.org/changeset/52033.
2911
2912         * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
2913         (WebCore::CALLBACK_FUNC_DECL): Added retrieval of calling frame and passing
2914           to the submit method.
2915
2916 2009-12-11  Sam Weinig  <sam@webkit.org>
2917
2918         Reviewed by Mark Rowe.
2919
2920         Put -umbrella linker flag into a variable so that it can be overridden.
2921
2922         * Configurations/WebCore.xcconfig:
2923
2924 2009-12-11  Shinichiro Hamaji  <hamaji@chromium.org>
2925
2926         Reviewed by Darin Adler.
2927
2928         body with display:inline causes crash
2929         https://bugs.webkit.org/show_bug.cgi?id=32371
2930
2931         Tests: fast/inline/inline-body-crash.html
2932                fast/inline/inline-body-with-scrollbar-crash.html
2933
2934         * page/FrameView.cpp:
2935         (WebCore::FrameView::createScrollbar):
2936         (WebCore::FrameView::layout):
2937
2938 2009-12-11  Brady Eidson  <beidson@apple.com>
2939
2940         Rubberstamped by Sam Weinig.
2941
2942         https://webkit.org/b/22851 - Remove defunct FIXME.
2943
2944         * html/HTMLPlugInElement.cpp:
2945         (WebCore::HTMLPlugInElement::HTMLPlugInElement): This flag was removed completely
2946           from the HTMLFrameOwnerElement chain of classes.
2947
2948 2009-12-11  Darin Adler  <darin@apple.com>
2949
2950         Reviewed by Dan Bernstein.
2951
2952         Small refactoring to get rid of some extra unneeded selection-related work
2953         in RenderLayer::scrollToOffset and separate caret and range selection
2954         logic in FrameView::layout. This may be useful later when changing how
2955         the range selection logic works to fix layout reentrancy problems.
2956
2957         * page/Frame.cpp: Removed invalidateSelection.
2958         * page/Frame.h: Ditto.
2959
2960         * page/FrameView.cpp:
2961         (WebCore::FrameView::layout): Call SelectionController::setNeedsLayout
2962         and Frame::selectionLayoutChanged instead of calling
2963         Frame::invalidateSelection, which was just a function that called
2964         both of those others.
2965
2966         * rendering/RenderLayer.cpp:
2967         (WebCore::RenderLayer::scrollToOffset): Call
2968         SelectionController::setNeedsLayout instead of calling
2969         Frame::invalidateSelection. This call site only needs the caret-related
2970         work in that first function, not the other work formerly done by
2971         Frame::invalidateSelection. The caret works outside the normal
2972         painting and rendering system, and the range selection highlight is
2973         more or less inside it and doesn't need special handling when scrolling.
2974
2975 2009-12-11  Brady Eidson  <beidson@apple.com>
2976
2977         Reviewed by Darin Adler.
2978
2979         <rdar://problem/7342725> and https://webkit.org/b/32383
2980         Selecting article text at sfgate.com results in spurious back/forward entries
2981
2982         If an iframe had a form and that form is submitted by javascript, IE and Opera don't add back/forward entries.
2983         
2984         In the case where the frame was added dynamically via createElement(), Firefox would like to add a back entry
2985         but has a bug that prevents this.
2986
2987         Therefore by a bizarre coincidence, WebKit is the loner and the only engine affected by sfgate.com's technique.
2988
2989         This patch changes us to willfully match IE and Opera and fixes sfgate.com in the process.
2990
2991         Tests: http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
2992                http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html
2993
2994         Capture whether the form was submitted by javascript:
2995         * loader/FormState.cpp:
2996         (WebCore::FormState::FormState):
2997         (WebCore::FormState::create):
2998         * loader/FormState.h:
2999         (WebCore::FormState::formSubmissionTrigger):
3000
3001         When deciding the value of the lockBackForwardList variable, take formSubmissionTrigger() into account:
3002         * loader/RedirectScheduler.cpp:
3003         (WebCore::RedirectScheduler::scheduleFormSubmission):
3004
3005         Rearrange the public HTMLFormElement::submit() method to be called only from DOM or JS bindings,
3006         and figure out the rest of the parameters for an internal submit() call including the formSubmissionTrigger:
3007         * bindings/js/JSHTMLFormElementCustom.cpp:
3008         (WebCore::JSHTMLFormElement::submit):
3009         * html/HTMLFormElement.cpp:
3010         (WebCore::HTMLFormElement::prepareSubmit):
3011         (WebCore::HTMLFormElement::submit):
3012         * html/HTMLFormElement.h:
3013
3014 2009-12-11  Alexey Proskuryakov  <ap@apple.com>
3015
3016         Reviewed by Darin Adler.
3017
3018         https://bugs.webkit.org/show_bug.cgi?id=32445
3019         REGRESSION: http://www.mcafee.com/japan/ displays unstyled
3020
3021         * css/CSSImportRule.cpp:
3022         (WebCore::CSSImportRule::setCSSStyleSheet):
3023         * html/HTMLLinkElement.cpp:
3024         (WebCore::HTMLLinkElement::setCSSStyleSheet):
3025         Add a quirk for mcafee.com/japan (http or https, with or without www).
3026
3027 2009-12-11  Sam Weinig  <sam@webkit.org>
3028
3029         Reviewed by Dan Bernstein.
3030
3031         Make PlatformWheelEvent.h private instead of project.
3032
3033         * WebCore.xcodeproj/project.pbxproj:
3034
3035 2009-12-11  Simon Fraser  <simon.fraser@apple.com>
3036
3037         Reviewed by Darin Adler.
3038
3039         Support reflections on composited layers
3040         https://bugs.webkit.org/show_bug.cgi?id=31885
3041         
3042         First part of supporting composited reflections on compositing layers.
3043         
3044         Rename the m_transformLayer member variable to m_structuralLayer, since it
3045         will get used both for transform layers (for preserve-3d) and to hold a flattening
3046         layer related to reflections, both of which have similar requirements, and are
3047         mutually exclusive.
3048
3049         * platform/graphics/mac/GraphicsLayerCA.h:
3050         primaryLayer(), hostLayerForSublayers() and layerForSuperlayer() all now return
3051         a CALayer, since m_structuralLayer isn't always a WebLayer.
3052         
3053         * platform/graphics/mac/GraphicsLayerCA.mm:
3054         (WebCore::GraphicsLayerCA::commitLayerChanges):
3055         updateLayerPreserves3D() renamed to updateStructuralLayer()
3056         
3057         (WebCore::GraphicsLayerCA::updateLayerNames):
3058         New "update" method for updating layer names.
3059         
3060         (WebCore::GraphicsLayerCA::updateSublayerList):
3061         m_transformLayer -> m_structuralLayer. Also minor refactor to only
3062         allocate newSublayers in one place.
3063         
3064         (WebCore::GraphicsLayerCA::updateLayerSize):
3065         (WebCore::GraphicsLayerCA::removeAnimationFromLayer):
3066         (WebCore::GraphicsLayerCA::hostLayerForSublayers):
3067         (WebCore::GraphicsLayerCA::layerForSuperlayer):
3068         m_transformLayer -> m_structuralLayer
3069         
3070         (WebCore::GraphicsLayerCA::updateStructuralLayer):
3071         Call ensureStructuralLayer() which handles any deltas to the
3072         structural layer type.
3073         
3074         (WebCore::GraphicsLayerCA::ensureStructuralLayer):
3075         Handle changes to the structural layer requirements
3076         
3077         (WebCore::GraphicsLayerCA::structuralLayerPurpose):
3078         Return an enum describing the purpose of the structural layer; for now
3079         this only returns NoStructuralLayer or StructuralLayerForPreserves3D, but
3080         will in future also have a value related to reflections.
3081
3082 2009-12-11  Simon Fraser  <simon.fraser@apple.com>
3083
3084         Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
3085
3086         * page/animation/KeyframeAnimation.cpp:
3087         (WebCore::KeyframeAnimation::pauseAnimation):
3088
3089 2009-12-11  Adam Roben  <aroben@apple.com>
3090
3091         Windows build fix
3092
3093         * platform/graphics/win/WKCACFLayerRenderer.cpp: Removed #include of
3094         non-existent header.
3095
3096 2009-12-11  Simon Fraser  <simon.fraser@apple.com>
3097
3098         Build fix, no review.
3099
3100         Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
3101
3102         * page/animation/KeyframeAnimation.cpp:
3103         (WebCore::KeyframeAnimation::startAnimation):
3104
3105 2009-12-11  Simon Fraser  <simon.fraser@apple.com>
3106
3107         Build fix, no review.
3108
3109         Build fix for platforms where ACCELERATED_COMPOSITING is not defined.
3110
3111         * page/animation/ImplicitAnimation.cpp:
3112         (WebCore::ImplicitAnimation::startAnimation):
3113
3114 2009-12-11  Simon Fraser  <simon.fraser@apple.com>
3115
3116         Reviewed by Darin Adler.
3117
3118         Negative values for animation-delay are ignored (treated as zero)
3119         https://bugs.webkit.org/show_bug.cgi?id=26150
3120         
3121         When we get the m_startTime for an animation or transition, subtract any negative
3122         delay so the animation/transition behaves like it started in the past, per spec.
3123
3124         Tests: animations/negative-delay.html
3125                transitions/negative-delay.html
3126
3127         * page/animation/AnimationBase.cpp:
3128         (WebCore::AnimationBase::updateStateMachine):
3129
3130 2009-12-11  Simon Fraser  <simon.fraser@apple.com>
3131
3132         Reviewed by Dan Bernstein.
3133
3134         Accelerated transitions broken when mixed with paused animations
3135         https://bugs.webkit.org/show_bug.cgi?id=32387
3136
3137         Synchronization of a mixture of accelerated and software animations occurs via
3138         a callback from GraphicsLayerCA, which ends up in
3139         AnimationControllerPrivate::receivedStartTimeResponse(). The time passed in is
3140         the exact time at which the accelerated animations started, so is used as the
3141         start time for all animations and transitions which are marked as waiting.
3142
3143         The bug was that the callback called when re-starting animations that were
3144         paused sent back an old time value, but this was used to start normal
3145         transitions. Therefore the transition would start with a stale start time, and
3146         thus end prematurely.
3147
3148         The fix is to change the way that GraphicsLayerCA handles paused animations.
3149         Rather than setting the beginTime of the animation, it uses a beginTime of 0
3150         and a timeOffset that gets passed down. Thus the callbacks always come with
3151         beginTime for 'now'.
3152
3153         Also clarify the role of AnimationBase::endAnimation() by splitting it into
3154         pauseAnimation() and endAnimation(), and pass down timeOffsets, rather than
3155         beginTimes when starting and pausing.
3156
3157         Manual test only, because the bug requires a non-trivial combination of
3158         animation pausing and transitions which take time, and the bug only shows in
3159         pixel results.
3160         
3161         * manual-tests/animation/transitions-and-paused-animations.html
3162
3163         * page/animation/AnimationBase.cpp:
3164         (WebCore::AnimationBase::updateStateMachine):
3165         * page/animation/AnimationBase.h:
3166         (WebCore::AnimationBase::startAnimation):
3167         (WebCore::AnimationBase::pauseAnimation):
3168         (WebCore::AnimationBase::endAnimation):
3169         * page/animation/ImplicitAnimation.cpp:
3170         (WebCore::ImplicitAnimation::~ImplicitAnimation):
3171         (WebCore::ImplicitAnimation::startAnimation):
3172         (WebCore::ImplicitAnimation::endAnimation):
3173         (WebCore::ImplicitAnimation::onAnimationEnd):
3174         * page/animation/ImplicitAnimation.h:
3175         (WebCore::ImplicitAnimation::pauseAnimation):
3176         * page/animation/KeyframeAnimation.cpp:
3177         (WebCore::KeyframeAnimation::~KeyframeAnimation):
3178         (WebCore::KeyframeAnimation::startAnimation):
3179         (WebCore::KeyframeAnimation::pauseAnimation):
3180         (WebCore::KeyframeAnimation::endAnimation):
3181         (WebCore::KeyframeAnimation::onAnimationEnd):
3182         * page/animation/KeyframeAnimation.h:
3183         * platform/graphics/GraphicsLayer.h:
3184         (WebCore::GraphicsLayer::addAnimation):
3185         (WebCore::GraphicsLayer::pauseAnimation):
3186         * platform/graphics/mac/GraphicsLayerCA.h:
3187         (WebCore::GraphicsLayerCA::LayerAnimation::LayerAnimation):
3188         (WebCore::GraphicsLayerCA::AnimationProcessingAction::AnimationProcessingAction):
3189         * platform/graphics/mac/GraphicsLayerCA.mm:
3190         (WebCore::GraphicsLayerCA::addAnimation):
3191         (WebCore::GraphicsLayerCA::removeAnimationsForKeyframes):
3192         (WebCore::GraphicsLayerCA::pauseAnimation):
3193         (WebCore::GraphicsLayerCA::updateLayerAnimations):
3194         (WebCore::GraphicsLayerCA::setAnimationOnLayer):
3195         (WebCore::GraphicsLayerCA::pauseAnimationOnLayer):
3196         (WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
3197         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
3198         * rendering/RenderLayerBacking.cpp:
3199         (WebCore::RenderLayerBacking::startAnimation):
3200         (WebCore::RenderLayerBacking::startTransition):
3201         (WebCore::RenderLayerBacking::animationPaused):
3202         * rendering/RenderLayerBacking.h:
3203
3204 2009-12-11  Brian Weinstein  <bweinstein@apple.com>
3205
3206         Reviewed by Darin Adler.
3207
3208         Fixes <http://webkit.org/b/32399>.
3209         Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled.
3210         
3211         When we initially figure out the layer that we should begin scrolling, don't try to jump out
3212         of frames/iFrames to look at the owner document. We don't want to jump out of frames, so we
3213         don't need that logic anymore.
3214         
3215         Added a test to make sure that we don't pan scroll if we start to scroll in an empty
3216         iFrame that has a scrollable owner document.
3217
3218         Test: platform/win/fast/events/panScroll-no-iframe-jump.html
3219
3220         * dom/Node.cpp:
3221         (WebCore::Node::defaultEventHandler):
3222
3223 2009-12-11  Brian Weinstein  <bweinstein@apple.com>
3224
3225         Reviewed by Adam Roben.
3226
3227         Fixes <http://webkit.org/b/32303>.
3228         Middle-mouse button not firing mousedown DOM event when autoscroll happens.
3229         
3230         This fix moves the pan scrolling code into Node.cpp, as part of the default event handler.
3231         We get two wins out of this:
3232             1) Mousedown DOM events are now fired before pan scrolling.
3233             2) Calling event.preventDefault() on a middle mouse button will now prevent pan scrolling.
3234         
3235         Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
3236         that when event.preventDefault is called, pan scrolling doesn't happen.
3237
3238         Tests: platform/win/fast/events/panScroll-event-fired.html
3239                platform/win/fast/events/panScroll-preventDefault.html
3240
3241         * dom/Node.cpp:
3242         (WebCore::Node::defaultEventHandler): Moved pan scrolling starting code to here.
3243         * page/EventHandler.cpp:
3244         (WebCore::EventHandler::startPanScrolling): Function to initialize scrolling variables and start timer.
3245         (WebCore::EventHandler::handleMousePressEvent): From here.
3246         * page/EventHandler.h:
3247
3248 2009-12-11  Chris Marrin  <cmarrin@apple.com>
3249
3250         Reviewed by Adam Roben.
3251
3252         Delay load DLLs for accelerated compositing
3253         https://bugs.webkit.org/show_bug.cgi?id=31856
3254         
3255         Change calls that use the data export symbols from
3256         QuartzCore to use the functions in QuartzCoreInterface.
3257         This allows QuartzCore to be delay loaded.
3258
3259         * platform/graphics/win/GraphicsLayerCACF.cpp:
3260         (WebCore::GraphicsLayerCACF::GraphicsLayerCACF):
3261         (WebCore::GraphicsLayerCACF::updateLayerPreserves3D):
3262         (WebCore::GraphicsLayerCACF::updateContentsImage):
3263         * platform/graphics/win/WKCACFLayer.cpp:
3264         (WebCore::toCACFLayerType):
3265         (WebCore::toCACFContentsGravityType):
3266         (WebCore::fromCACFContentsGravityType):
3267         (WebCore::toCACFFilterType):
3268         (WebCore::fromCACFFilterType):
3269         (WebCore::WKCACFLayer::create):
3270         (WebCore::WKCACFLayer::WKCACFLayer):
3271         (WebCore::WKCACFLayer::setContentsGravity):
3272         (WebCore::WKCACFLayer::contentsGravity):
3273         (WebCore::WKCACFLayer::setMagnificationFilter):
3274         (WebCore::WKCACFLayer::magnificationFilter):
3275         (WebCore::WKCACFLayer::setMinificationFilter):
3276         (WebCore::WKCACFLayer::minificationFilter):
3277         * platform/graphics/win/WKCACFLayer.h:
3278         (WebCore::WKCACFLayer::):
3279         * platform/graphics/win/WKCACFLayerRenderer.cpp:
3280         (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
3281         (WebCore::WKCACFLayerRenderer::createRenderer):
3282
3283 2009-12-11  Steve Block  <steveblock@google.com>
3284
3285         Reviewed by Darin Fisher.
3286
3287         Adds an Android-specific implementation of initializeMaximumHTTPConnectionCountPerHost.
3288         https://bugs.webkit.org/show_bug.cgi?id=31810
3289
3290         * platform/network/ResourceRequestBase.cpp: Modified. Disable default implementation
3291             of initializeMaximumHTTPConnectionCountPerHost for Android.
3292         * platform/network/android: Added.
3293         * platform/network/android/ResourceRequestAndroid.cpp: Added.
3294         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Android-specific implementation.
3295
3296 2009-12-11  Kent Tamura  <tkent@chromium.org>
3297
3298         Reviewed by Darin Fisher.
3299
3300         Add acceptTypes() method to FileChooser.
3301         https://bugs.webkit.org/show_bug.cgi?id=32429
3302
3303         This method returns an 'accept' attribute value of the
3304         corresponding INPUT element. A ChromeClient::runOpenPanel()
3305         implementation can refer it through a FileChooser instance to
3306         support type-restricted file selecting.
3307
3308         This makes no user-visible changes for now.
3309
3310         * platform/FileChooser.h:
3311         (WebCore::FileChooser::acceptTypes):
3312         * rendering/RenderFileUploadControl.cpp:
3313         (WebCore::RenderFileUploadControl::acceptTypes):
3314         * rendering/RenderFileUploadControl.h:
3315
3316 2009-12-11  Victor Wang  <victorw@chromium.org>
3317
3318         Reviewed by Darin Fisher.
3319
3320         Changed PopupMenuChromium to keep the value selected from
3321         keyboard when popup is closed.
3322
3323         The problem is Chromium does not fire the onchange event
3324         when the popup is closed if an item is selected via
3325         keyboard by typing the first char of the item. This makes
3326         chromium popup not having consistent behaviours and also
3327         behaves differently from other major browsers.
3328         Calling popup->hide() instead of popup->hidePopup() in
3329         PopupMenu fixes the issues as it does extra step to check
3330         whethere there is a keyboard selection changed when closing
3331         the popup.
3332
3333         https://bugs.webkit.org/show_bug.cgi?id=32403
3334     
3335         TEST: add a manual test as the current layout test shell
3336         does not support sending keyboard events to popup list.
3337
3338         * manual-tests/chromium/select-close-popup-value-change.html: Added.
3339         * platform/chromium/PopupMenuChromium.cpp:
3340         (WebCore::PopupMenu::hide):
3341
3342 2009-12-11  anton muhin  <antonm@chromium.org>
3343
3344         Reviewed by Adam Barth.
3345
3346         [v8] refactor WeakReferenceMap.
3347         Move common bits of functionality to reduce duplication.
3348
3349         https://bugs.webkit.org/show_bug.cgi?id=32389
3350
3351         Should be covered by buildbots.
3352
3353         * bindings/v8/DOMData.h:
3354         (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper):
3355         (WebCore::DOMData::handleWeakObject):
3356         (WebCore::DOMData::removeObjectsFromWrapperMap):
3357         * bindings/v8/DOMDataStore.cpp:
3358         (WebCore::DOMDataStore::weakDOMObjectCallback):
3359         (WebCore::DOMDataStore::weakActiveDOMObjectCallback):
3360         (WebCore::DOMDataStore::weakNodeCallback):
3361         (WebCore::DOMDataStore::weakSVGElementInstanceCallback):
3362         (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
3363         * bindings/v8/DOMDataStore.h:
3364         * bindings/v8/V8DOMMap.cpp:
3365         (WebCore::visitDOMNodesInCurrentThread):
3366         (WebCore::visitDOMObjectsInCurrentThread):
3367         (WebCore::visitActiveDOMObjectsInCurrentThread):
3368         (WebCore::visitDOMSVGElementInstancesInCurrentThread):
3369         (WebCore::visitSVGObjectsInCurrentThread):
3370         * bindings/v8/V8DOMMap.h:
3371         (WebCore::WeakReferenceMap::removeIfPresent):
3372         (WebCore::WeakReferenceMap::clear):
3373         (WebCore::WeakReferenceMap::visit):
3374
3375 2009-12-11  anton muhin  <antonm@chromium.org>
3376         Reviewed by Adam Barth.
3377
3378         [v8] in Debug builds create an additional handle scope
3379         when doing debug build checks.
3380         https://bugs.webkit.org/show_bug.cgi?id=32335
3381
3382         Should be covered by buildbots.
3383
3384         * bindings/v8/V8DOMWrapper.h:
3385         (WebCore::V8DOMWrapper::convertDOMWrapperToNative):
3386         (WebCore::V8DOMWrapper::convertDOMWrapperToNode):
3387
3388 2009-12-11  Pavel Feldman  <pfeldman@chromium.org>
3389
3390         Reviewed by Timothy Hatcher.
3391
3392         Web Inspector: Do not use ContextMenuItem as value type in custom
3393         context menu implementation.
3394
3395         https://bugs.webkit.org/show_bug.cgi?id=32411
3396
3397         * GNUmakefile.am:
3398         * WebCore.gypi:
3399         * WebCore.pro:
3400         * WebCore.vcproj/WebCore.vcproj:
3401         * WebCore.xcodeproj/project.pbxproj:
3402         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3403         (WebCore::JSInspectorFrontendHost::showContextMenu):
3404         * inspector/InspectorFrontendHost.cpp:
3405         (WebCore::InspectorFrontendHost::InspectorFrontendHost):
3406         (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
3407         (WebCore::InspectorFrontendHost::showContextMenu):
3408         (WebCore::InspectorFrontendHost::contextMenuCleared):
3409         * inspector/InspectorFrontendHost.h:
3410         (WebCore::InspectorFrontendHost::MenuProvider::create):
3411         (WebCore::InspectorFrontendHost::MenuProvider::~MenuProvider):
3412         (WebCore::InspectorFrontendHost::MenuProvider::disconnect):
3413         (WebCore::InspectorFrontendHost::MenuProvider::populateContextMenu):
3414         (WebCore::InspectorFrontendHost::MenuProvider::contextMenuCleared):
3415         (WebCore::InspectorFrontendHost::MenuProvider::MenuProvider):
3416         * page/ContextMenuController.cpp:
3417         (WebCore::ContextMenuController::ContextMenuController):
3418         (WebCore::ContextMenuController::clearContextMenu):
3419         (WebCore::ContextMenuController::showContextMenu):
3420         (WebCore::ContextMenuController::contextMenuItemSelected):
3421         * page/ContextMenuController.h:
3422         * page/ContextMenuProvider.h: Added.
3423         (WebCore::ContextMenuProvider::~ContextMenuProvider):
3424         * page/ContextMenuSelectionHandler.h: Removed.
3425
3426 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
3427
3428         Reviewed by Antti Koivisto.
3429
3430         Basic cross-platform implementation of mapping platform touch events
3431         to JavaScript touch events.
3432
3433         https://bugs.webkit.org/show_bug.cgi?id=32114
3434
3435         Test: fast/events/basic-touch-events.html
3436
3437         * page/EventHandler.cpp:
3438         (WebCore::EventHandler::handleTouchEvent):
3439         * page/EventHandler.h:
3440
3441 2009-12-11  Zoltan Horvath  <zoltan@webkit.org>
3442
3443         Reviewed by Darin Adler.
3444
3445         Allow custom memory allocation control for WebCore's EmptyFrameLoaderClient
3446         https://bugs.webkit.org/show_bug.cgi?id=32110
3447
3448         Inherits the following class from Noncopyable because it is
3449         instantiated by 'new' and no need to be copyable:
3450
3451         class name              - instantiated at: WebCore/'location'
3452
3453         class EmptyFrameLoaderClient - svg/graphics/SVGImage.cpp:229
3454
3455         * loader/FrameLoaderClient.h:
3456
3457 2009-12-11  Zoltan Horvath  <zoltan@webkit.org>
3458
3459         Reviewed by Darin Adler.
3460
3461         Allow custom memory allocation control for 3 classes in WebCore's svg and loader directory
3462         https://bugs.webkit.org/show_bug.cgi?id=32106
3463
3464         Inherits the following classes from Noncopyable because these are instantiated 
3465         by 'new' and no need to be copyable:
3466
3467         class/struct name            - instantiated at: WebCore/'location'
3468
3469         class EmptyContextMenuClient - instantiated at: svg/graphics/SVGImage.cpp:232
3470         class EmptyDragClient        - instantiated at: svg/graphics/SVGImage.cpp:237
3471         class SVGImageChromeClient   - instantiated at: svg/graphics/SVGImage.cpp:243
3472
3473         * svg/graphics/SVGImage.cpp:
3474         * loader/EmptyClients.h:
3475
3476 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
3477
3478         Reviewed by Darin Adler.
3479
3480         The values of RuntimeArray are not enumerable
3481         https://bugs.webkit.org/show_bug.cgi?id=29005
3482
3483         The indices of RuntimeArray should be enumerated like for a regular array.
3484
3485         * bridge/runtime_array.cpp:
3486         (JSC::RuntimeArray::getOwnPropertyNames):
3487         * bridge/runtime_array.h:
3488
3489 2009-12-11  Andreas Kling  <andreas.kling@nokia.com>
3490
3491         Reviewed by Simon Hausmann.
3492
3493         [Qt] ImageDecoderQt: Fix retrieval of image file extensions
3494
3495         QImageReader only allows retrieving the format() before actually reading the image.
3496
3497         https://bugs.webkit.org/show_bug.cgi?id=32428
3498
3499         * platform/graphics/qt/ImageDecoderQt.cpp:
3500         (WebCore::ImageDecoderQt::setData):
3501         (WebCore::ImageDecoderQt::internalDecodeSize):
3502
3503 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
3504
3505         Reviewed by Antti Koivisto.
3506
3507         Added interfaces for touch event support in JavaScript.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=32114
3510
3511         The Touch, TouchEvent and TouchList interfaces come straight from
3512         Android's copy of WebKit (eclaire branch).
3513
3514         The PlatformTouchEvent and PlatformTouchPoint code was written by
3515         us.
3516
3517         No new tests added, we are just adding interfaces
3518         with this patch.
3519
3520         * WebCore.pro:
3521         * bindings/js/JSEventCustom.cpp:
3522         (WebCore::toJS):
3523         * dom/Document.cpp:
3524         (WebCore::Document::addListenerTypeIfNeeded):
3525         * dom/Document.h:
3526         (WebCore::Document::):
3527         * dom/Document.idl:
3528         * dom/Element.h:
3529         * dom/Element.idl:
3530         * dom/Event.cpp:
3531         (WebCore::Event::isTouchEvent):
3532         * dom/Event.h:
3533         * dom/EventNames.h:
3534         * dom/Touch.cpp: Added.
3535         (WebCore::contentsX):
3536         (WebCore::contentsY):
3537         (WebCore::Touch::Touch):
3538         (WebCore::Touch::updateLocation):
3539         * dom/Touch.h: Added.
3540         (WebCore::Touch::create):
3541         (WebCore::Touch::frame):
3542         (WebCore::Touch::target):
3543         (WebCore::Touch::identifier):
3544         (WebCore::Touch::clientX):
3545         (WebCore::Touch::clientY):
3546         (WebCore::Touch::screenX):
3547         (WebCore::Touch::screenY):
3548         (WebCore::Touch::pageX):
3549         (WebCore::Touch::pageY):
3550         * dom/Touch.idl: Added.
3551         * dom/TouchEvent.cpp: Added.
3552         (WebCore::TouchEvent::TouchEvent):
3553         (WebCore::TouchEvent::initTouchEvent):
3554         * dom/TouchEvent.h: Added.
3555         (WebCore::TouchEvent::create):
3556         (WebCore::TouchEvent::touches):
3557         (WebCore::TouchEvent::targetTouches):
3558         (WebCore::TouchEvent::changedTouches):
3559         (WebCore::TouchEvent::TouchEvent):
3560         (WebCore::TouchEvent::isTouchEvent):
3561         * dom/TouchEvent.idl: Added.
3562         * dom/TouchList.cpp: Added.
3563         (WebCore::TouchList::item):
3564         * dom/TouchList.h: Added.
3565         (WebCore::TouchList::create):
3566         (WebCore::TouchList::length):
3567         (WebCore::TouchList::append):
3568         (WebCore::TouchList::TouchList):
3569         * dom/TouchList.idl: Added.
3570         * html/HTMLAttributeNames.in:
3571         * html/HTMLElement.cpp:
3572         (WebCore::HTMLElement::parseMappedAttribute):
3573         * page/DOMWindow.h:
3574         * page/DOMWindow.idl:
3575         * platform/PlatformTouchEvent.h: Added.
3576         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
3577         (WebCore::PlatformTouchEvent::touchPoints):
3578         * platform/PlatformTouchPoint.h: Added.
3579         (WebCore::PlatformTouchPoint::):
3580         (WebCore::PlatformTouchPoint::id):
3581         (WebCore::PlatformTouchPoint::state):
3582         (WebCore::PlatformTouchPoint::screenPos):
3583         (WebCore::PlatformTouchPoint::pos):
3584         * platform/qt/PlatformTouchEventQt.cpp: Added.
3585         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
3586         * platform/qt/PlatformTouchPointQt.cpp: Added.
3587         (WebCore::PlatformTouchPoint::PlatformTouchPoint):
3588
3589 2009-12-11  Grace Kloba  <klobag@gmail.com>
3590
3591         Reviewed by Darin Adler.
3592
3593         [Android] Add detachHistoryItem() to AndroidWebHistoryBridge. And the constructor takes
3594         HistoryItem* now. As AndroidWebHistoryBridge holds a dumb pointer of HistoryItem and
3595         HistoryItem holds a RefPtr of AndroidWebHistoryBridge, the dumb pointer needs to be cleared
3596         when HistoryItem is deleted to avoid potential crash.
3597         https://bugs.webkit.org/show_bug.cgi?id=32251
3598
3599         * history/HistoryItem.cpp:
3600         (WebCore::HistoryItem::~HistoryItem):
3601         * history/android/AndroidWebHistoryBridge.h:
3602         (WebCore::AndroidWebHistoryBridge::AndroidWebHistoryBridge):
3603         (WebCore::AndroidWebHistoryBridge::detachHistoryItem):
3604
3605
3606 2009-12-11  Fumitoshi Ukai  <ukai@chromium.org>
3607
3608         Reviewed by Pavel Feldman.
3609
3610         Log WebSocket error to Web Inspector console.
3611         https://bugs.webkit.org/show_bug.cgi?id=32165
3612
3613         * websockets/WebSocketChannel.cpp:
3614         (WebCore::WebSocketChannel::didOpen):
3615         (WebCore::WebSocketChannel::appendToBuffer):
3616         * websockets/WebSocketHandshake.cpp:
3617         (WebCore::WebSocketHandshake::readServerHandshake):
3618         (WebCore::WebSocketHandshake::readHTTPHeaders):
3619         (WebCore::WebSocketHandshake::checkResponseHeaders):
3620
3621 2009-12-10  Adam Barth  <abarth@webkit.org>
3622
3623         Reviewed by Darin Adler.
3624
3625         Mixed content shouldn't trigger for plug-ins without URLs
3626         https://bugs.webkit.org/show_bug.cgi?id=32384
3627
3628         These plug-ins cannot be controlled by active network attackers, so
3629         there's no reason to trigger a mixed content warning.
3630
3631         Test: http/tests/security/mixedContent/empty-url-plugin-in-frame.html
3632
3633         * loader/FrameLoader.cpp:
3634         (WebCore::FrameLoader::isMixedContent):
3635
3636 2009-12-10  Alexey Proskuryakov  <ap@apple.com>
3637
3638         Reviewed by Darin Adler.
3639
3640         https://bugs.webkit.org/show_bug.cgi?id=32140
3641         REGRESSION(r50072): Mailman administrative functionality is broken
3642
3643         Test: http/tests/misc/percent-sign-in-form-field-name.html
3644
3645         * platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent
3646         sign, we never had a good reason to do that.
3647
3648 2009-12-10  Kent Hansen  <kent.hansen@nokia.com>
3649
3650         Reviewed by Geoffrey Garen.
3651
3652         Remove getPropertyAttributes() from JavaScript bindings.
3653         https://bugs.webkit.org/show_bug.cgi?id=31933
3654
3655         The functionality is provided by getOwnPropertyDescriptor().
3656
3657         * WebCore.order:
3658         * bindings/js/JSDOMWindowCustom.cpp:
3659         * bindings/js/JSDOMWindowShell.cpp:
3660         * bindings/js/JSDOMWindowShell.h:
3661         * bindings/scripts/CodeGeneratorJS.pm:
3662         * page/DOMWindow.idl:
3663
3664 2009-12-10  Kenneth Russell  <kbr@google.com>
3665
3666         Reviewed by Oliver Hunt.
3667
3668         Changed WebGLRenderingContext to synthesize GL errors rather than
3669         raising JavaScript exceptions. Removed internal getError() calls
3670         after each graphics call. The GraphicsContext3D maintains the
3671         synthetic exceptions because only it has complete information
3672         about certain conditions requiring them to be raised.
3673
3674         Based on idea from Ilmari Heikkinen, added create3DDebugContext()
3675         to webgl-test.js and changed the WebGL layout tests expecting
3676         error conditions to use it. Updated expected.txt files, which now
3677         implicitly test the OpenGL error as it is part of the exception's
3678         message.
3679
3680         Added new targeted test covering aspects of synthetic errors as
3681         well as regression tests for bugs uncovered during its development.
3682
3683         Test: fast/canvas/webgl/error-reporting.html
3684
3685         * html/canvas/WebGLRenderingContext.cpp:
3686         (WebCore::WebGLRenderingContext::sizeInBytes):
3687         (WebCore::WebGLRenderingContext::activeTexture):
3688         (WebCore::WebGLRenderingContext::attachShader):
3689         (WebCore::WebGLRenderingContext::bindAttribLocation):
3690         (WebCore::WebGLRenderingContext::bindBuffer):
3691         (WebCore::WebGLRenderingContext::bindFramebuffer):
3692         (WebCore::WebGLRenderingContext::bindRenderbuffer):
3693         (WebCore::WebGLRenderingContext::bindTexture):
3694         (WebCore::WebGLRenderingContext::bufferData):
3695         (WebCore::WebGLRenderingContext::bufferSubData):
3696         (WebCore::WebGLRenderingContext::compileShader):
3697         (WebCore::WebGLRenderingContext::createShader):
3698         (WebCore::WebGLRenderingContext::detachShader):
3699         (WebCore::WebGLRenderingContext::disableVertexAttribArray):
3700         (WebCore::WebGLRenderingContext::drawArrays):
3701         (WebCore::WebGLRenderingContext::drawElements):
3702         (WebCore::WebGLRenderingContext::enableVertexAttribArray):
3703         (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
3704         (WebCore::WebGLRenderingContext::framebufferTexture2D):
3705         (WebCore::WebGLRenderingContext::getActiveAttrib):
3706         (WebCore::WebGLRenderingContext::getActiveUniform):
3707         (WebCore::WebGLRenderingContext::getBufferParameter):
3708         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
3709         (WebCore::WebGLRenderingContext::getParameter):
3710         (WebCore::WebGLRenderingContext::getProgramParameter):
3711         (WebCore::WebGLRenderingContext::getProgramInfoLog):
3712         (WebCore::WebGLRenderingContext::getRenderbufferParameter):
3713         (WebCore::WebGLRenderingContext::getShaderParameter):
3714         (WebCore::WebGLRenderingContext::getShaderInfoLog):
3715         (WebCore::WebGLRenderingContext::getShaderSource):
3716         (WebCore::WebGLRenderingContext::getTexParameter):
3717         (WebCore::WebGLRenderingContext::getUniform):
3718         (WebCore::WebGLRenderingContext::getUniformLocation):
3719         (WebCore::WebGLRenderingContext::getVertexAttrib):
3720         (WebCore::WebGLRenderingContext::linkProgram):
3721         (WebCore::WebGLRenderingContext::shaderSource):
3722         (WebCore::WebGLRenderingContext::texImage2D):
3723         (WebCore::WebGLRenderingContext::texSubImage2D):
3724         (WebCore::WebGLRenderingContext::uniform1f):
3725         (WebCore::WebGLRenderingContext::uniform1fv):
3726         (WebCore::WebGLRenderingContext::uniform1i):
3727         (WebCore::WebGLRenderingContext::uniform1iv):
3728         (WebCore::WebGLRenderingContext::uniform2f):
3729         (WebCore::WebGLRenderingContext::uniform2fv):
3730         (WebCore::WebGLRenderingContext::uniform2i):
3731         (WebCore::WebGLRenderingContext::uniform2iv):
3732         (WebCore::WebGLRenderingContext::uniform3f):
3733         (WebCore::WebGLRenderingContext::uniform3fv):
3734         (WebCore::WebGLRenderingContext::uniform3i):
3735         (WebCore::WebGLRenderingContext::uniform3iv):
3736         (WebCore::WebGLRenderingContext::uniform4f):
3737         (WebCore::WebGLRenderingContext::uniform4fv):
3738         (WebCore::WebGLRenderingContext::uniform4i):
3739         (WebCore::WebGLRenderingContext::uniform4iv):
3740         (WebCore::WebGLRenderingContext::uniformMatrix2fv):
3741         (WebCore::WebGLRenderingContext::uniformMatrix3fv):
3742         (WebCore::WebGLRenderingContext::uniformMatrix4fv):
3743         (WebCore::WebGLRenderingContext::useProgram):
3744         (WebCore::WebGLRenderingContext::validateProgram):
3745         (WebCore::WebGLRenderingContext::vertexAttribPointer):
3746         * html/canvas/WebGLRenderingContext.h:
3747         (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall):
3748         * platform/graphics/GraphicsContext3D.h:
3749         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3750         (WebCore::GraphicsContext3D::getActiveAttrib):
3751         (WebCore::GraphicsContext3D::getActiveUniform):
3752         (WebCore::GraphicsContext3D::getError):
3753         (WebCore::GraphicsContext3D::synthesizeGLError):
3754
3755 2009-12-10  Stephen White  <senorblanco@chromium.org>
3756
3757         Reviewed by Dimitri Glazkov.
3758
3759         Fix for assert on Chrome/skia with SVG Filters enabled.
3760         https://bugs.webkit.org/show_bug.cgi?id=32394
3761
3762         Covered by LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b.svg and others.
3763
3764         * platform/graphics/skia/ImageBufferSkia.cpp:
3765         (WebCore::ImageBuffer::platformTransformColorSpace):
3766
3767 2009-12-10  Enrica Casucci  <enrica@apple.com>
3768
3769         Reviewed by Darin Adler.
3770
3771         REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail selecting Bold selects other 2 edit buttons automatically.
3772         <rdar://problem/7442065>
3773         https://bugs.webkit.org/show_bug.cgi?id=32285
3774
3775         When examining the styles of the nodes after the first in a range selection, we take into
3776         cosideration differences in style of txt nodes only.
3777         
3778         Test: editing/execCommand/queryCommandState-02.html
3779
3780         * editing/Editor.cpp:
3781         (WebCore::Editor::selectionHasStyle):
3782
3783 2009-12-10  Oliver Hunt  <oliver@apple.com>
3784
3785         Reviewed by Alexey Proskuryakov.
3786
3787         Crash in XMLTokenizer::popCurrentNode if window.close() is called during parsing
3788         https://bugs.webkit.org/show_bug.cgi?id=31576
3789
3790         Add a RefCounted wrapper object around xmlParserCtxtPtr so we can
3791         maintain it's lifetime more effectively.
3792
3793         Test: fast/parser/xhtml-close-while-parsing.xhtml
3794
3795         * dom/XMLTokenizer.cpp:
3796         (WebCore::XMLTokenizer::popCurrentNode):
3797         * dom/XMLTokenizer.h:
3798         (WebCore::XMLParserContext::context):
3799         (WebCore::XMLParserContext::XMLParserContext):
3800         (WebCore::XMLTokenizer::context):
3801         * dom/XMLTokenizerLibxml2.cpp:
3802         (WebCore::XMLParserContext::createStringParser):
3803         (WebCore::XMLParserContext::createMemoryParser):
3804         (WebCore::XMLParserContext::~XMLParserContext):
3805         (WebCore::XMLTokenizer::~XMLTokenizer):
3806         (WebCore::XMLTokenizer::doWrite):
3807         (WebCore::XMLTokenizer::initializeParserContext):
3808         (WebCore::XMLTokenizer::doEnd):
3809         (WebCore::XMLTokenizer::lineNumber):
3810         (WebCore::XMLTokenizer::columnNumber):
3811         (WebCore::XMLTokenizer::stopParsing):
3812         (WebCore::parseXMLDocumentFragment):
3813         (WebCore::parseAttributes):
3814
3815 2009-12-10  Pavel Feldman  <pfeldman@chromium.org>
3816
3817         Reviewed by Timothy Hatcher.
3818
3819         Web Inspector: debugger shortcuts don't work when
3820         Search field or Console drawer has focus.
3821
3822         https://bugs.webkit.org/show_bug.cgi?id=32392
3823
3824         * inspector/front-end/inspector.js:
3825         (WebInspector.loaded):
3826         (WebInspector.documentKeyDown):
3827         (WebInspector.documentKeyUp):
3828         (WebInspector.searchKeyDown):
3829
3830 2009-12-10  Dimitri Glazkov  <dglazkov@chromium.org>
3831
3832         Reviewed by Adam Barth.
3833
3834         [V8] Events created in isolated worlds may fire in main world.
3835         https://bugs.webkit.org/show_bug.cgi?id=32386
3836
3837         Test: http/tests/security/isolatedWorld/events.html
3838
3839         * WebCore.gypi: Added WorldContextHandle.
3840         * bindings/v8/ScriptEventListener.cpp:
3841         (WebCore::createAttributeEventListener): Added WorldContextHandle params.
3842         * bindings/v8/SharedPersistent.h: Fixed a few style/include issues.
3843         * bindings/v8/V8AbstractEventListener.cpp:
3844         (WebCore::V8AbstractEventListener::V8AbstractEventListener): Added WorldContextHandle params.
3845         (WebCore::V8AbstractEventListener::handleEvent): Adjusted context retrieval to use WorldContextHandle.
3846         (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
3847         * bindings/v8/V8AbstractEventListener.h:
3848         (WebCore::V8AbstractEventListener::worldContext): Added WorldContextHandle params.
3849         * bindings/v8/V8EventListenerList.h:
3850         (WebCore::V8EventListenerList::findOrCreateWrapper): Ditto.
3851         * bindings/v8/V8LazyEventListener.cpp:
3852         (WebCore::V8LazyEventListener::V8LazyEventListener): Ditto.
3853         (WebCore::V8LazyEventListener::prepareListenerObject): Adjusted context retrieval to use WorldContextHandle.
3854         * bindings/v8/V8LazyEventListener.h:
3855         (WebCore::V8LazyEventListener::create): Added WorldContextHandle params.
3856         * bindings/v8/V8Proxy.cpp:
3857         (WebCore::V8Proxy::context): Refactored to use mainWorldContext();
3858         (WebCore::V8Proxy::mainWorldContext): Added.
3859         (WebCore::toV8Context): Changed to use WorldContextHandle.
3860         * bindings/v8/V8Proxy.h: Added mainWorldContext decl.
3861         * bindings/v8/V8Utilities.cpp:
3862         (WebCore::reportException): Added an extra check to avoid crashes during frame teardown.
3863         * bindings/v8/V8WorkerContextEventListener.cpp:
3864         (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Added WorldContextHandle params.
3865         * bindings/v8/V8WorkerContextEventListener.h:
3866         (WebCore::V8WorkerContextEventListener::create): Added WorldContextHandle params.
3867         * bindings/v8/WorldContextHandle.cpp: Added.
3868         * bindings/v8/WorldContextHandle.h: Added.
3869         * bindings/v8/custom/V8CustomEventListener.cpp:
3870         (WebCore::V8EventListener::V8EventListener): Added WorldContextHandle params.
3871         * bindings/v8/custom/V8CustomEventListener.h:
3872         (WebCore::V8EventListener::create): Added WorldContextHandle params.
3873
3874 2009-12-10  Jon Honeycutt  <jhoneycutt@apple.com>
3875
3876         Pass more information about a plug-in to the PluginHalterDelegate
3877
3878         Reviewed by Adam Roben.
3879
3880         * loader/EmptyClients.h:
3881         Remove this unused class.
3882
3883         * page/HaltablePlugin.h:
3884         Add new functions to return the plug-in's name and whether it is
3885         windowed.
3886
3887         * page/PluginHalter.cpp:
3888         (WebCore::PluginHalter::timerFired):
3889         Pass new arguments to the client.
3890
3891         * page/PluginHalterClient.h:
3892         Add new parameters.
3893
3894         * plugins/PluginView.cpp:
3895         (WebCore::PluginView::pluginName):
3896         Return the name from the PluginPackage.
3897
3898         * plugins/PluginView.h:
3899         (WebCore::PluginView::isWindowed):
3900
3901 2009-12-09  Brian Weinstein  <bweinstein@apple.com>
3902
3903         Reviewed by Pavel Feldman.
3904
3905         Fixes <http://webkit.org/b/31738>.
3906         Web Inspector: Console Scope Bar should be on top of console when Console is a Panel.
3907         
3908         When the console is set to be shown as a full panel, move the scope bar to the top
3909         where it looks best. When it is only shown as a drawer, move it to the bottom, where
3910         it originally was. This takes up less space as a drawer, and makes it more discoverable
3911         and usable when it is the full panel.
3912
3913         * inspector/front-end/ConsolePanel.js:
3914         (WebInspector.ConsolePanel.prototype.show): Move filter bar to top.
3915         (WebInspector.ConsolePanel.prototype.hide): Move filter bar back to bottom.
3916         * inspector/front-end/inspector.css:
3917
3918 2009-12-10  Stephen White  <senorblanco@chromium.org>
3919
3920         Reviewed by Dirk Schulze.
3921
3922         Fix for alpha blending in SVG Filters on Chromium/skia.
3923         https://bugs.webkit.org/show_bug.cgi?id=32378
3924
3925         Covered by LayoutTests/svg/filters/feGaussianBlur.svg and others.
3926
3927         * platform/graphics/skia/ImageBufferSkia.cpp:
3928         (WebCore::ImageBuffer::platformTransformColorSpace):
3929
3930 2009-12-10  Pavel Feldman  <pfeldman@chromium.org>
3931
3932         Reviewed by Timothy Hatcher.
3933
3934         Web Inspector: Add context menu actions for DOM tree.
3935
3936         https://bugs.webkit.org/show_bug.cgi?id=32348
3937
3938         * English.lproj/localizedStrings.js:
3939         * inspector/front-end/ContextMenu.js:
3940         (WebInspector.ContextMenu):
3941         (WebInspector.ContextMenu.prototype.show):
3942         (WebInspector.ContextMenu.prototype.appendItem):
3943         (WebInspector.ContextMenu.prototype.appendSeparator):
3944         (WebInspector.ContextMenu.prototype._itemSelected):
3945         (WebInspector.contextMenuItemSelected):
3946         (WebInspector.contextMenuCleared):
3947         * inspector/front-end/ElementsTreeOutline.js:
3948         (WebInspector.ElementsTreeOutline.prototype._onmouseout):
3949         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
3950         (WebInspector.ElementsTreeElement.prototype.ondblclick):
3951         (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent):
3952         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
3953         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
3954         (WebInspector.ElementsTreeElement.prototype._startEditing):
3955         (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
3956         * inspector/front-end/ObjectPropertiesSection.js:
3957         (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
3958         * inspector/front-end/ResourceView.js:
3959         (WebInspector.ResourceView.prototype._toggleURLdecoding):
3960         * inspector/front-end/ResourcesPanel.js:
3961         (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
3962         * inspector/front-end/StylesSidebarPane.js:
3963         (WebInspector.StylePropertyTreeElement.prototype):
3964         * inspector/front-end/inspector.js:
3965         (WebInspector.contextMenuEventFired):
3966         * inspector/front-end/treeoutline.js:
3967         (TreeElement.treeElementDoubleClicked):
3968
3969 2009-12-09  Nikolas Zimmermann  <nzimmermann@rim.com>
3970
3971         Reviewed by Oliver Hunt.
3972
3973         Filters contain some leaks in untested code
3974         https://bugs.webkit.org/show_bug.cgi?id=32325
3975
3976         Fix obvious leak in SVGFE*Lighting classes. Implement the create() idiom for 
3977         all classes in svg/graphics, that were missing it. The lighting filters aren't
3978         implemented so far, but the associated FilterEffect objects are build, which created
3979         these leaks.
3980
3981         This removes the SVG related failures in the leaks bot.
3982
3983         * svg/SVGFEDiffuseLightingElement.cpp:
3984         (WebCore::SVGFEDiffuseLightingElement::findLights):
3985         * svg/SVGFEDiffuseLightingElement.h:
3986         * svg/SVGFEDistantLightElement.cpp:
3987         (WebCore::SVGFEDistantLightElement::lightSource):
3988         * svg/SVGFEDistantLightElement.h:
3989         * svg/SVGFELightElement.h:
3990         * svg/SVGFEPointLightElement.cpp:
3991         (WebCore::SVGFEPointLightElement::lightSource):
3992         * svg/SVGFEPointLightElement.h:
3993         * svg/SVGFESpecularLightingElement.cpp:
3994         (WebCore::SVGFESpecularLightingElement::findLights):
3995         * svg/SVGFESpecularLightingElement.h:
3996         * svg/SVGFESpotLightElement.cpp:
3997         (WebCore::SVGFESpotLightElement::lightSource):
3998         * svg/SVGFESpotLightElement.h:
3999         * svg/graphics/filters/SVGDistantLightSource.h:
4000         (WebCore::DistantLightSource::create):
4001         (WebCore::DistantLightSource::DistantLightSource):
4002         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
4003         (WebCore::FEDiffuseLighting::FEDiffuseLighting):
4004         (WebCore::FEDiffuseLighting::create):
4005         (WebCore::FEDiffuseLighting::setLightSource):
4006         * svg/graphics/filters/SVGFEDiffuseLighting.h:
4007         * svg/graphics/filters/SVGFESpecularLighting.cpp:
4008         (WebCore::FESpecularLighting::FESpecularLighting):
4009         (WebCore::FESpecularLighting::create):
4010         (WebCore::FESpecularLighting::setLightSource):
4011         * svg/graphics/filters/SVGFESpecularLighting.h:
4012         * svg/graphics/filters/SVGLightSource.h:
4013         * svg/graphics/filters/SVGPointLightSource.h:
4014         (WebCore::PointLightSource::create):
4015         (WebCore::PointLightSource::PointLightSource):
4016         * svg/graphics/filters/SVGSpotLightSource.h:
4017         (WebCore::SpotLightSource::create):
4018         (WebCore::SpotLightSource::SpotLightSource):
4019
4020 2009-12-10  Kenneth Russell  <kbr@google.com>
4021
4022         Reviewed by Oliver Hunt.
4023
4024         [Chromium] SporeViewer demo doesn't work in Chromium
4025         https://bugs.webkit.org/show_bug.cgi?id=32364
4026
4027         Test: fast/canvas/webgl/bug-32364.html
4028
4029         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
4030         (WebCore::CALLBACK_FUNC_DECL):
4031         (WebCore::vertexAttribAndUniformHelperf):
4032         (WebCore::uniformHelperi):
4033
4034 2009-12-09  Beth Dakin  <bdakin@apple.com>
4035
4036         Reviewed by Oliver Hunt.
4037
4038         Fix for https://bugs.webkit.org/show_bug.cgi?id=32346 SVG property 
4039         -webkit-shadow should apply shadow on the result after compositing
4040         -and corresponding-
4041         <rdar://problem/7389404>
4042
4043         Set a transparency layer when setting a shadow to apply the shadow 
4044         to the composite.
4045         * rendering/SVGRenderSupport.cpp:
4046         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
4047         (WebCore::SVGRenderBase::finishRenderSVGContent):
4048
4049 2009-12-09  Alexey Proskuryakov  <ap@apple.com>
4050
4051         Reviewed by Darin Adler.
4052
4053         https://bugs.webkit.org/show_bug.cgi?id=32332
4054         WebSocket events should be dispatched synchronously
4055
4056         Updated websocket/tests/simple to test for the new behavior.
4057
4058         When Web Sockets API says that events should be queued for async dispatch, it means something
4059         different. We should keep this in mind when dealing with other HTML5-related specs.
4060
4061         The model for HTML5 is that code running in response to network events (e.g. WebSocket or
4062         XMLHttpRequest algorithms) runs in a separate thread of execution, and thus needs to post
4063         async events as its only way to communicate with client code. As long as network events are
4064         queued themselves (as they are in WebKit), there is no need to queue JS events for async
4065         dispatch.
4066
4067         * websockets/WebSocket.cpp:
4068         (WebCore::WebSocket::didConnect):
4069         (WebCore::WebSocket::didReceiveMessage):
4070         (WebCore::WebSocket::didClose):
4071
4072 2009-12-09  Alexey Proskuryakov  <ap@apple.com>
4073
4074         Reviewed by Oliver Hunt.
4075
4076         https://bugs.webkit.org/show_bug.cgi?id=32355
4077         Assertion failure when opening a WebSocket connection
4078
4079         I couldn't make a reliable test for this. Once the test from bug 32299 is landed, it
4080         will provide partial coverage, as I was frequently seeing the assertion failure with it.
4081
4082         * platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send):
4083         It's not an error if zero is returned from platformSend() - it just means that nothing could
4084         be pushed down to the network layer, and all data was queued for later.
4085         * platform/network/cf/SocketStreamHandleCFNet.cpp:
4086         (WebCore::SocketStreamHandle::readStreamCallback): This will no longer happen with SocketStream,
4087         but a client can potentially destroy the handle from any callback, so we need to check that
4088         this didn't happen.
4089         (WebCore::SocketStreamHandle::writeStreamCallback): Ditto.
4090
4091 2009-12-09  Sam Weinig  <sam@webkit.org>
4092
4093         Roll out 51919 and 51920. They were incorrect and unnecessary right now.
4094
4095         * platform/mac/WebCoreObjCExtras.mm:
4096         (WebCoreObjCScheduleDeallocateOnMainThread):
4097         * platform/network/mac/NetworkStateNotifierMac.cpp:
4098         (WebCore::NetworkStateNotifier::NetworkStateNotifier):
4099
4100 2009-12-09  Steve Block  <steveblock@google.com>
4101
4102         Reviewed by Darin Fisher.
4103
4104         Adds wtf/StdLibExtras.h include for DEFINE_STATIC_LOCAL in V8 ScriptState.
4105         https://bugs.webkit.org/show_bug.cgi?id=32330
4106
4107         Build fix only, no new tests.
4108
4109         * bindings/v8/ScriptState.cpp: Modified. Adds wtf/StdLibExtras.h include.
4110
4111 2009-12-09  Steve Block  <steveblock@google.com>
4112
4113         Reviewed by Darin Adler.
4114
4115         Adds ENABLE(INSPECTOR) guards around script binding methods that use types
4116         defined only when INSPECTOR is enabled.
4117         https://bugs.webkit.org/show_bug.cgi?id=32328
4118
4119         Build fix only, no new tests.
4120
4121         * bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
4122         * bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
4123
4124 2009-12-09  Steve Block  <steveblock@google.com>
4125
4126         Reviewed by Adam Barth.
4127
4128         Adds Android Makefiles for building with V8.
4129         Also updates existing Android Makefiles with latest additions.
4130         https://bugs.webkit.org/show_bug.cgi?id=32278
4131
4132         Build fix only, no new tests.
4133
4134         * Android.derived.jscbindings.mk: Modified.
4135         * Android.derived.mk: Modified.
4136         * Android.derived.v8bindings.mk: Added.
4137         * Android.jscbindings.mk: Modified.
4138         * Android.mk: Modified.
4139         * Android.v8bindings.mk: Added.
4140
4141 2009-12-09  Jonathan Dixon  <joth@chromium.org>
4142
4143         Reviewed by Dimitri Glazkov.
4144
4145         Bug 32338 - [Chromium] Fix Chromium builder by including missing GeolocationServiceChromium
4146         https://bugs.webkit.org/show_bug.cgi?id=32338
4147
4148         Fix build break: re-include file dropped out by merge in http://trac.webkit.org/changeset/51681/trunk/WebCore/WebCore.gypi
4149
4150         * WebCore.gypi: Add missing GeolocationServiceChromium.cpp
4151
4152 2009-12-09  Andreas Kling  <andreas.kling@nokia.com>
4153
4154         Reviewed by Brady Eidson.
4155
4156         Fixed a typo in http://trac.webkit.org/changeset/51644 that broke
4157         the QWebPage autotest.
4158
4159         No new test required.
4160
4161         * loader/FrameLoader.cpp:
4162         (WebCore::FrameLoader::navigateToDifferentDocument):
4163
4164 2009-12-09  Robert Hogan  <robert@roberthogan.net>
4165
4166         Reviewed by Eric Seidel.
4167
4168         Exclude JSSVG*.cpp generated files from --minimal and --no-svg builds.
4169         
4170         https://bugs.webkit.org/show_bug.cgi?id=32286
4171
4172         * WebCore.pro:
4173
4174 2009-12-09  Philippe Normand  <pnormand@igalia.com>
4175
4176         Reviewed by Eric Carlson.
4177
4178         Ogg mimetypes are incorrect
4179         https://bugs.webkit.org/show_bug.cgi?id=27113
4180
4181         The ogg extension is handled by audio/ogg instead of
4182         application/ogg. See
4183         http://wiki.xiph.org/MIME_Types_and_File_Extensions
4184
4185         * platform/MIMETypeRegistry.cpp:
4186         (WebCore::TypeExtensionPair::):
4187
4188 2009-12-09  Sam Weinig  <sam@webkit.org>
4189
4190         Reviewed by Anders Carlsson.
4191
4192         Use the current run loop instead of the main runloop for the NetworkStateNotifier.
4193
4194         * platform/network/mac/NetworkStateNotifierMac.cpp:
4195         (WebCore::NetworkStateNotifier::NetworkStateNotifier):
4196
4197 2009-12-09  Sam Weinig  <sam@webkit.org>
4198
4199         Reviewed by Anders Carlsson.
4200
4201         Use isMainThread() helper instead of pthread_main_np() != 0.
4202
4203         * platform/mac/WebCoreObjCExtras.mm:
4204         (WebCoreObjCScheduleDeallocateOnMainThread):
4205
4206 2009-12-09  Sam Weinig  <sam@webkit.org>
4207
4208         Reviewed by Anders Carlsson.
4209
4210         Add some #ifdefs to allow us to experiment with a single NSView mac WebKit.
4211
4212         * page/Chrome.h:
4213         * page/EventHandler.h:
4214         * page/mac/ChromeMac.mm:
4215         * page/mac/DragControllerMac.mm:
4216         (WebCore::DragController::dragOperation):
4217         * page/mac/EventHandlerMac.mm:
4218         (WebCore::EventHandler::eventLoopHandleMouseDragged):
4219         (WebCore::EventHandler::eventActivatedView):
4220         (WebCore::EventHandler::passMousePressEventToSubframe):
4221         (WebCore::EventHandler::passMouseMoveEventToSubframe):
4222         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
4223         (WebCore::EventHandler::passWheelEventToWidget):
4224         (WebCore::EventHandler::focusDocumentView):
4225         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
4226         (WebCore::EventHandler::createDraggingClipboard):
4227         (WebCore::isKeyboardOptionTab):
4228         (WebCore::EventHandler::invertSenseOfTabsToLinks):
4229         (WebCore::EventHandler::tabsToAllControls):
4230         (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
4231         (WebCore::EventHandler::accessKeyModifiers):
4232         * platform/ScrollView.cpp:
4233         (WebCore::ScrollView::wheelEvent):
4234         * platform/Widget.cpp:
4235         * platform/Widget.h:
4236         * platform/mac/ScrollViewMac.mm:
4237         * platform/mac/WidgetMac.mm:
4238         (WebCore::Widget::Widget):
4239         (WebCore::Widget::~Widget):
4240         (WebCore::Widget::show):
4241         (WebCore::Widget::hide):
4242         (WebCore::Widget::setCursor):
4243         (WebCore::Widget::paint):
4244         (WebCore::Widget::setFocus):
4245         (WebCore::Widget::setIsSelected):
4246         (WebCore::Widget::frameRect):
4247         (WebCore::Widget::setFrameRect):
4248
4249 2009-12-09  Michael Nordman  <michaeln@google.com>
4250
4251         Reviewed by Dimitri Glazkov.
4252
4253         Chromium build fix.
4254
4255         No new tests.
4256
4257         * bindings/v8/DOMData.cpp
4258         * bindings/v8/V8DOMWrapper.cpp
4259         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
4260         (WebCore::vertexAttribAndUniformHelperf):
4261         (WebCore::uniformHelperi):
4262         (WebCore::uniformMatrixHelper):
4263
4264 2009-12-09  Søren Gjesse  <sgjesse@chromium.org>
4265
4266         Reviewed by Pavel Feldman.
4267
4268         [V8] Isolated world reuse failure
4269         https://bugs.webkit.org/show_bug.cgi?id=32306
4270
4271         Fixed bug introduced in r51407: (http://trac.webkit.org/changeset/51407) which caused layout test
4272         LayoutTests/http/tests/security/isolatedWorld/world-reuse.html to fail.
4273
4274         * bindings/v8/V8Proxy.cpp:
4275         (WebCore::V8Proxy::setInjectedScriptContextDebugId):
4276         (WebCore::V8Proxy::contextDebugId):
4277
4278 2009-12-09  Patrick Scott  <phanna@email.unc.edu>
4279