34821b48437fa36f8592e008d2654db60e05dca7
[WebKit-https.git] / WebCore / ChangeLog
1 2011-01-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r74778.
4         http://trac.webkit.org/changeset/74778
5         https://bugs.webkit.org/show_bug.cgi?id=51930
6
7         Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
8         (Requested by bbandix on #webkit).
9
10         * bindings/v8/V8DOMWindowShell.cpp:
11         (WebCore::V8DOMWindowShell::setContext):
12         * bindings/v8/V8DOMWindowShell.h:
13
14 2011-01-05  Yi Shen  <yi.4.shen@nokia.com>
15
16         Reviewed by Andreas Kling.
17
18         [Qt] Animated GIF images does not animate 10x as expected by default.
19         https://bugs.webkit.org/show_bug.cgi?id=36818
20
21         Add a test animated GIF which should be displayed 2 times and stop.
22
23         * manual-tests/animated-gif-looping.html:
24         * manual-tests/resources/animated-2x.gif: Added.
25
26 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
27
28         Reviewed by Martin Robinson.
29
30         [GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
31         https://bugs.webkit.org/show_bug.cgi?id=51923
32
33         Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
34         ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.
35
36         No new tests. This should not change functionality.
37
38         * GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
39         * platform/gtk/ScrollbarThemeGtk.cpp:
40         (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
41         * platform/gtk/ScrollbarThemeGtk.h:
42         * platform/gtk/ScrollbarThemeGtk2.cpp: Added.
43         (WebCore::ScrollbarThemeGtk::updateThemeProperties):
44         (WebCore::ScrollbarThemeGtk::paintTrackBackground):
45         (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
46         (WebCore::ScrollbarThemeGtk::paintThumb):
47         (WebCore::ScrollbarThemeGtk::paintButton):
48         * platform/gtk/ScrollbarThemeGtk3.cpp: Added.
49         (WebCore::ScrollbarThemeGtk::updateThemeProperties):
50         (WebCore::ScrollbarThemeGtk::paintTrackBackground):
51         (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
52         (WebCore::ScrollbarThemeGtk::paintThumb):
53         (WebCore::ScrollbarThemeGtk::paintButton):
54
55 2011-01-05  Patrick Gansterer  <paroga@webkit.org>
56
57         Reviewed by Andreas Kling.
58
59         [CMake] Fix the usage of SOURCE_GROUP
60         https://bugs.webkit.org/show_bug.cgi?id=51739
61
62         * CMakeLists.txt:
63
64 2011-01-05  Andras Becsi  <abecsi@webkit.org>
65
66         Reviewed by Csaba Osztrogonác.
67
68         [Qt][V8] Fix the build after recent changes.
69
70         No new tests needed.
71
72         * WebCore.pro: Add missing files, and remove obsolete ones.
73
74 2011-01-05  Yong Li  <yoli@rim.com>
75
76         Reviewed by Adam Barth.
77
78         Suspend HTMLParserScheduler when page load is deferred to
79         avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
80         from an external script or by events, and is blocked by a modal dialog,
81         WebKit can parse more HTML source and also start another JS execution.
82         
83         https://bugs.webkit.org/show_bug.cgi?id=48077
84
85         Test case: WebCore/manual-tests/bugzilla-48077.html.
86
87         * dom/DocumentParser.cpp:
88         (WebCore::DocumentParser::suspendScheduledTasks):
89         (WebCore::DocumentParser::resumeScheduledTasks):
90         * dom/DocumentParser.h:
91         * html/parser/HTMLDocumentParser.cpp:
92         (WebCore::HTMLDocumentParser::suspendScheduledTasks):
93         (WebCore::HTMLDocumentParser::resumeScheduledTasks):
94         * html/parser/HTMLParserScheduler.cpp:
95         (WebCore::HTMLParserScheduler::HTMLParserScheduler):
96         (WebCore::HTMLParserScheduler::suspend):
97         (WebCore::HTMLParserScheduler::resume):
98         * html/parser/HTMLParserScheduler.h:
99         (WebCore::HTMLParserScheduler::isScheduledForResume):
100         * page/PageGroupLoadDeferrer.cpp:
101         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
102         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
103
104 2011-01-05  Simon Hausmann  <simon.hausmann@nokia.com>
105
106         Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva
107
108         [GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
109         https://bugs.webkit.org/show_bug.cgi?id=51926
110
111         Work around potential upstream bug: Querying a GstBin for the duration,
112         will forward the query to all sink children. Our WebKitWebSrc however
113         is a bin with only source children, therefore the query fails. Until
114         this is changed upstream, this patch works around it as follows,
115         based on suggestion by Philippe Normand and Sebastian Dröge:
116
117         When the initial query fails, attempt the same query on all source
118         pads and take the maximum length reported.
119
120         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
121         (WebCore::MediaPlayerPrivateGStreamer::totalBytes):
122
123 2011-01-05  Philippe Normand  <pnormand@igalia.com>
124
125         Rubber-stamped by Eric Seidel.
126
127         [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
128         https://bugs.webkit.org/show_bug.cgi?id=51810
129
130         Based on a patch by Mart Raudsepp.
131
132         No new tests, build fix only.
133
134         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
135         (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
136         API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
137         introduced in same version as the xoverlay API change.
138
139 2011-01-05  Leo Yang  <leo.yang@torchmobile.com.cn>
140
141         Reviewed by Dirk Schulze.
142
143         Malformed SVG causes crash in updateContainerOffset
144         https://bugs.webkit.org/show_bug.cgi?id=44610
145
146         We should check recursive <use> at the begining of
147         WebCore::SVGUseElement::buildInstanceTree instead
148         of at the end of it because the target element's
149         children may cause infinite recursive <use>.
150
151         Test: svg/custom/recursive-use.svg
152
153         * svg/SVGUseElement.cpp:
154         (WebCore::SVGUseElement::buildInstanceTree):
155         (WebCore::SVGUseElement::hasCycleUseReferencing):
156         * svg/SVGUseElement.h:
157
158 2011-01-04  Antti Koivisto  <antti@apple.com>
159
160         Reviewed by Dan Bernstein.
161
162         https://bugs.webkit.org/show_bug.cgi?id=51907
163         Style selector should only be recalculated when the pending sheet count goes to zero
164         
165         Shark says this is a significant performance improvement on some sites with lots of stylesheets.
166
167         * dom/Document.cpp:
168         (WebCore::Document::removePendingSheet):
169
170 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
171
172         Reviewed by Martin Robinson.
173
174         [GTK] Use GtkStyleContext to get platform colors
175         https://bugs.webkit.org/show_bug.cgi?id=51830
176
177         Use GtkStyleContext API to get platform colors when building with
178         GTK+ 3.x.
179
180         No new tests. This should not change functionality.
181
182         * platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
183         * platform/graphics/gtk/ColorGtk.cpp:
184         (WebCore::Color::Color):
185         (WebCore::Color::operator GdkRGBA):
186         * platform/gtk/RenderThemeGtk3.cpp:
187         (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
188         (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
189         (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
190         (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
191         (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor):
192         (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor):
193         (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor):
194         (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor):
195         (WebCore::RenderThemeGtk::systemColor):
196
197 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
198
199         Unreviewed. Build fix for GTK when using gtk+-3 after r75009.
200
201         * platform/gtk/RenderThemeGtk3.cpp:
202         (WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of
203         adoptGRefPtr which doesn't exist.
204
205 2011-01-05  Alexey Proskuryakov  <ap@apple.com>
206
207         Reviewed by Sam Weinig.
208
209         https://bugs.webkit.org/show_bug.cgi?id=51903
210         Tell UI process which subframe is largest
211
212         * WebCore.exp.in: Exported FrameView::contentsSize().
213
214 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
215
216         Unreviewed. GTK build fix.
217
218         WK2: Support Accessibility
219         https://bugs.webkit.org/show_bug.cgi?id=51859
220
221         * page/FrameView.cpp:
222         (WebCore::FrameView::axObjectCache):
223
224 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
225
226         Unreviewed, rolling out r74992.
227         http://trac.webkit.org/changeset/74992
228         https://bugs.webkit.org/show_bug.cgi?id=51917
229
230         Crash in HTMLDocumentParser::suspendScheduledTasks()
231         (Requested by tkent on #webkit).
232
233         * dom/DocumentParser.cpp:
234         * dom/DocumentParser.h:
235         * html/parser/HTMLDocumentParser.cpp:
236         * html/parser/HTMLDocumentParser.h:
237         * html/parser/HTMLParserScheduler.cpp:
238         (WebCore::HTMLParserScheduler::HTMLParserScheduler):
239         * html/parser/HTMLParserScheduler.h:
240         (WebCore::HTMLParserScheduler::isScheduledForResume):
241         * page/PageGroupLoadDeferrer.cpp:
242         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
243         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
244
245 2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
246
247         Reviewed by Kenneth Rohde Christiansen.
248
249         [Qt] [WK2] Add support for non-trivial context menu action
250         https://bugs.webkit.org/show_bug.cgi?id=51902
251
252         Fix the preprocessor guard for ContextMenuItemTagSelectAll in
253         the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
254         inconsistent with what is defined in ContextMenuItem.h.
255
256         * page/ContextMenuController.cpp:
257         (WebCore::ContextMenuController::contextMenuItemSelected):
258
259 2011-01-04  Tony Gentilcore  <tonyg@chromium.org>
260
261         Reviewed by Ryosuke Niwa.
262
263         Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
264         https://bugs.webkit.org/show_bug.cgi?id=51723
265
266         ScriptElement should also be able to keep its Element+CachedScript in
267         a PendingScript, and then executeScriptSoon can accept a PendingScript.
268         Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
269         PendingScripts, then generic request and execute which operate on
270         PendingScripts can be factored out to avoid code duplicate that we have.
271
272         No new tests because no new functionality.
273
274         * dom/AsyncScriptRunner.cpp:
275         (WebCore::AsyncScriptRunner::~AsyncScriptRunner):
276         (WebCore::AsyncScriptRunner::executeScriptSoon):
277         (WebCore::AsyncScriptRunner::timerFired):
278         * dom/AsyncScriptRunner.h:
279         * dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
280         * dom/HTMLScriptRunner.cpp:
281         (WebCore::HTMLScriptRunner::requestPendingScript):
282
283 2011-01-04  Jeff Miller  <jeffm@apple.com>
284
285         Reviewed by Darin Adler.
286
287         Member variable and method naming cleanup to be consistent with WebKit2.
288         https://bugs.webkit.org/show_bug.cgi?id=51228
289
290         * page/win/EventHandlerWin.cpp:
291         (WebCore::EventHandler::eventActivatedView):
292         Rename activatedWebView() to didActivateWebView().
293         
294         * platform/PlatformMouseEvent.h:
295         Rename m_activatedWebView to m_didActivateWebView.
296         
297         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
298         Initialize platform-specific member variables in PlatformMouseEvent constructors.
299         
300         (WebCore::PlatformMouseEvent::didActivateWebView):
301         Rename activatedWebView() to didActivateWebView().
302
303         * platform/win/PlatformMouseEventWin.cpp:
304         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
305         Rename m_activatedWebView to m_didActivateWebView.
306
307 2011-01-04  Yael Aharon  <yael.aharon@nokia.com>
308
309         Reviewed by Darin Adler.
310
311         CSS3 :nth-child selector and valid whitespace test fails
312         https://bugs.webkit.org/show_bug.cgi?id=36279
313
314         Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.
315
316         Test: fast/css/css3-nth-space.html
317
318         * css/tokenizer.flex:
319
320 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
321
322         Unreviewed. Build fix.
323
324         WK2: Support Accessibility
325         https://bugs.webkit.org/show_bug.cgi?id=51859
326
327         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
328         (fallbackObject):
329
330 2011-01-04  Cosmin Truta  <ctruta@chromium.org>
331
332         Reviewed by Eric Seidel.
333
334         [chromium] PNG compression settings optimized for speed
335         https://bugs.webkit.org/show_bug.cgi?id=51719
336
337         Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
338         it is also the slowest, by a wide margin, on easy-to-compress images.
339         Use a more balanced configuration, based on the libpng compression defaults,
340         but with a faster compression level (3 instead of 6), and a faster filter
341         ("sub" instead of "all").
342
343         No change in behaviour, so no new tests.
344
345         * platform/image-encoders/skia/PNGImageEncoder.cpp:
346         (WebCore::PNGImageEncoder::encode):
347
348 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
349
350         Reviewed by Sam Weinig.
351
352         WK2: Support Accessibility
353         https://bugs.webkit.org/show_bug.cgi?id=51859
354
355         WK2 doesn't use platform scroll views anymore. Accessibility code
356         needs to have its own scroll views. 
357
358         Test: platform/mac/accessibility/webkit-scrollarea.html
359
360         * CMakeLists.txt:
361         * GNUmakefile.am:
362         * WebCore.exp.in:
363         * WebCore.gypi:
364         * WebCore.pro:
365         * WebCore.vcproj/WebCore.vcproj:
366         * WebCore.xcodeproj/project.pbxproj:
367         * accessibility/AXObjectCache.cpp:
368         (WebCore::AXObjectCache::AXObjectCache):
369         (WebCore::AXObjectCache::get):
370         (WebCore::AXObjectCache::getOrCreate):
371         (WebCore::AXObjectCache::rootObject):
372         (WebCore::AXObjectCache::remove):
373         (WebCore::AXObjectCache::handleScrollbarUpdate):
374         * accessibility/AXObjectCache.h:
375         (WebCore::AXObjectCache::handleScrollbarUpdate):
376         * accessibility/AccessibilityARIAGrid.h:
377         * accessibility/AccessibilityAllInOne.cpp:
378         * accessibility/AccessibilityImageMapLink.cpp:
379         * accessibility/AccessibilityImageMapLink.h:
380         * accessibility/AccessibilityListBoxOption.cpp:
381         * accessibility/AccessibilityListBoxOption.h:
382         * accessibility/AccessibilityObject.cpp:
383         (WebCore::AccessibilityObject::updateChildrenIfNecessary):
384         (WebCore::AccessibilityObject::elementAccessibilityHitTest):
385         (WebCore::AccessibilityObject::axObjectCache):
386         (WebCore::AccessibilityObject::focusedUIElement):
387         * accessibility/AccessibilityObject.h:
388         (WebCore::AccessibilityObject::isAccessibilityScrollView):
389         (WebCore::AccessibilityObject::isScrollView):
390         (WebCore::AccessibilityObject::canSetNumericValue):
391         (WebCore::AccessibilityObject::scrollBar):
392         (WebCore::AccessibilityObject::size):
393         (WebCore::AccessibilityObject::setValue):
394         * accessibility/AccessibilityRenderObject.cpp:
395         (WebCore::AccessibilityRenderObject::parentObject):
396         (WebCore::AccessibilityRenderObject::accessibilityHitTest):
397         (WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
398         (WebCore::AccessibilityRenderObject::addChildren):
399         * accessibility/AccessibilityRenderObject.h:
400         * accessibility/AccessibilityScrollView.cpp: Added.
401         (WebCore::AccessibilityScrollView::AccessibilityScrollView):
402         (WebCore::AccessibilityScrollView::create):
403         (WebCore::AccessibilityScrollView::scrollBar):
404         (WebCore::AccessibilityScrollView::children):
405         (WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
406         (WebCore::AccessibilityScrollView::removeChildScrollbar):
407         (WebCore::AccessibilityScrollView::addChildScrollbar):
408         (WebCore::AccessibilityScrollView::addChildren):
409         (WebCore::AccessibilityScrollView::webAreaObject):
410         (WebCore::AccessibilityScrollView::accessibilityHitTest):
411         (WebCore::AccessibilityScrollView::document):
412         (WebCore::AccessibilityScrollView::elementRect):
413         (WebCore::AccessibilityScrollView::parentObject):
414         * accessibility/AccessibilityScrollView.h: Added.
415         (WebCore::AccessibilityScrollView::roleValue):
416         (WebCore::AccessibilityScrollView::scrollView):
417         (WebCore::AccessibilityScrollView::accessibilityIsIgnored):
418         (WebCore::AccessibilityScrollView::isAccessibilityScrollView):
419         (WebCore::toAccessibilityScrollView):
420         * accessibility/AccessibilityScrollbar.cpp:
421         (WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
422         (WebCore::AccessibilityScrollbar::create):
423         (WebCore::AccessibilityScrollbar::elementRect):
424         (WebCore::AccessibilityScrollbar::document):
425         (WebCore::AccessibilityScrollbar::orientation):
426         (WebCore::AccessibilityScrollbar::isEnabled):
427         (WebCore::AccessibilityScrollbar::valueForRange):
428         (WebCore::AccessibilityScrollbar::setValue):
429         * accessibility/AccessibilityScrollbar.h:
430         (WebCore::AccessibilityScrollbar::setParent):
431         (WebCore::AccessibilityScrollbar::canSetValueAttribute):
432         (WebCore::AccessibilityScrollbar::canSetNumericValue):
433         (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
434         (WebCore::AccessibilityScrollbar::parentObject):
435         (WebCore::AccessibilityScrollbar::roleValue):
436         * accessibility/mac/AccessibilityObjectMac.mm:
437         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
438         * accessibility/mac/AccessibilityObjectWrapper.mm:
439         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
440         (-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
441         (-[AccessibilityObjectWrapper position]):
442         (-[AccessibilityObjectWrapper scrollViewParent]):
443         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
444         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
445         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
446         * dom/Document.cpp:
447         (WebCore::Document::axObjectCache):
448         * loader/EmptyClients.h:
449         (WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
450         * loader/FrameLoaderClient.h:
451         * page/FrameView.cpp:
452         (WebCore::FrameView::~FrameView):
453         (WebCore::FrameView::axObjectCache):
454         * page/FrameView.h:
455         * platform/ScrollView.cpp:
456         (WebCore::ScrollView::setHasHorizontalScrollbar):
457         (WebCore::ScrollView::setHasVerticalScrollbar):
458         * platform/Scrollbar.cpp:
459         (WebCore::Scrollbar::~Scrollbar):
460         (WebCore::Scrollbar::scroll):
461         (WebCore::Scrollbar::axObjectCache):
462         * platform/Scrollbar.h:
463         * platform/Widget.h:
464         (WebCore::Widget::axObjectCache):
465
466 2011-01-04  W. James MacLean  <wjmaclean@chromium.org>
467
468         Reviewed by Kenneth Russell.
469
470         [chromium] Add support to compositor to composite to offscreen texture.
471         https://bugs.webkit.org/show_bug.cgi?id=50833
472
473         A patch to extend compositor to be able to composite into an offscreen texture instead
474         of just directly to the display buffer. Builds on RenderSurfaceChromium support.
475         Explicitly resets alpha channel before rendering to display.
476
477         * platform/graphics/chromium/LayerRendererChromium.cpp:
478         (WebCore::LayerRendererChromium::LayerRendererChromium):
479         (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
480         (WebCore::LayerRendererChromium::drawLayers):
481         (WebCore::LayerRendererChromium::setCompositeOffscreen):
482         (WebCore::LayerRendererChromium::useRenderSurface):
483         (WebCore::LayerRendererChromium::setScissorToRect):
484         * platform/graphics/chromium/LayerRendererChromium.h:
485         (WebCore::LayerRendererChromium::isCompositingOffscreen):
486         (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
487
488 2011-01-04  Evan Martin  <evan@chromium.org>
489
490         Reviewed by Tony Chang.
491
492         [chromium] depend on harfbuzz explicitly
493         https://bugs.webkit.org/show_bug.cgi?id=51895
494
495         platform/graphics/chromium uses Harfbuzz directly.  Rather than
496         expecting Skia to adjust the include paths, be explicit about
497         the dependency.
498
499         * WebCore.gyp/WebCore.gyp:
500
501 2011-01-04  Darin Adler  <darin@apple.com>
502
503         Reviewed by Brady Eidson.
504
505         Add back/forward encoding and decoding to WebKit2
506         https://bugs.webkit.org/show_bug.cgi?id=51901
507
508         * WebCore.exp.in: Export functions used in WebKit2.
509
510         * history/HistoryItem.cpp:
511         (WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers.
512         (WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto.
513         (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
514         * history/HistoryItem.h: Ditto.
515         * platform/network/FormData.cpp:
516         (WebCore::encode): Ditto.
517         (WebCore::decode): Ditto.
518         (WebCore::FormData::encodeForBackForward): Ditto.
519         (WebCore::FormData::decodeForBackForward): Ditto.
520         * platform/network/FormData.h: Ditto.
521
522 2011-01-04  Xiaomei Ji  <xji@chromium.org>
523
524         Reviewed by Dan Bernstein.
525
526         Implement sel.modify('move', 'left'/'right', 'lineBoundary').
527         https://bugs.webkit.org/show_bug.cgi?id=33435
528
529         * editing/SelectionController.cpp:
530         (WebCore::SelectionController::modifyMovingRight):
531         (WebCore::SelectionController::modifyMovingLeft):
532         * editing/visible_units.cpp:
533         (WebCore::logicalStartOfLine):
534         (WebCore::logicalEndOfLine):
535         (WebCore::leftBoundaryOfLine):
536         (WebCore::rightBoundaryOfLine):
537         * editing/visible_units.h:
538
539 2011-01-04  Martin Robinson  <mrobinson@igalia.com>
540
541         Reviewed by Xan Lopez.
542
543         [GTK] Use the default CSS text input control border width of relying on the GTK+ theme
544         https://bugs.webkit.org/show_bug.cgi?id=51887
545
546         Do not rely on the GTK+ theme to determine text control borders. This simplifies
547         the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
548         doesn't break the rendering of any theme that I've encountered.
549
550         * platform/gtk/RenderThemeGtk.cpp:
551         (WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but
552         still disable any border radius.
553         * platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the
554         default style of text areas and text input controls.
555         * platform/gtk/RenderThemeGtk2.cpp: Ditto.
556         * platform/gtk/RenderThemeGtk3.cpp: Ditto.
557
558 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
559
560         Reviewed by Darin Adler.
561
562         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
563         https://bugs.webkit.org/show_bug.cgi?id=51846
564
565         No new tests. This should not introduce any functional changes.
566
567         Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
568         all references to PlatformRefPtr in Brew code to RefPtr.
569
570 2011-01-04  David Kilzer  <ddkilzer@apple.com>
571
572         <http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network
573
574         Reviewed by Antti Koivisto.
575
576         This is needed to prevent a WebCore/platform policy violation in
577         my next patch.
578
579         * WebCore.gypi: Updated for moved header.
580         * WebCore.pro: Ditto.
581         * WebCore.vcproj/WebCore.vcproj: Ditto.
582         * WebCore.xcodeproj/project.pbxproj: Ditto.
583         * platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.
584
585 2011-01-04  Brady Eidson  <beidson@apple.com>
586
587         Reviewed by a spell checker.
588
589         * storage/StorageMap.h: mesured?  Really?
590
591 2011-01-04  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
592
593         Reviewed by Xan Lopez.
594
595         [GTK] Port stock icon painting to GtkStyleContext
596         https://bugs.webkit.org/show_bug.cgi?id=51764
597
598         Port stock icon painting for media and search input elements to
599         GtkStyleContext. Also create the initial machinery for accessing
600         style contexts for all GTK+ 3.x based widgets.
601
602         No new tests. This should not change functionality.
603
604         * platform/gtk/RenderThemeGtk.cpp:
605         (WebCore::paintGdkPixbuf):
606         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
607         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
608         (WebCore::RenderThemeGtk::paintMediaButton):
609         * platform/gtk/RenderThemeGtk.h:
610         * platform/gtk/RenderThemeGtk2.cpp:
611         (WebCore::RenderThemeGtk::getStockIcon):
612         * platform/gtk/RenderThemeGtk3.cpp:
613         (WebCore::gtkStyleChangedCallback):
614         (WebCore::styleContextMap):
615         (WebCore::getStyleContext):
616         (WebCore::RenderThemeGtk::paintMenuList):
617
618 2010-12-31  Antti Koivisto  <antti@apple.com>
619
620         Reviewed by Dave Hyatt.
621
622         Scripts should not be executed before preceding stylesheets are loaded
623         https://bugs.webkit.org/show_bug.cgi?id=8852
624
625         Block inline script execution on pending stylesheet loads. This matches
626         other browsers and HTML5.
627
628         Tests: fast/tokenizer/inline-script-stylesheet-write.html
629                fast/tokenizer/inline-script-stylesheet.html
630
631         * dom/PendingScript.cpp:
632         (WebCore::PendingScript::releaseElementAndClear):
633         * dom/PendingScript.h:
634         (WebCore::PendingScript::PendingScript):
635         (WebCore::PendingScript::operator=):
636         (WebCore::PendingScript::startingPosition):
637         (WebCore::PendingScript::setStartingPosition):
638         * html/HTMLLinkElement.cpp:
639         (WebCore::HTMLLinkElement::process):
640         
641         This fixes an unrelated bug with beforeload events that was exposed by the other
642         changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
643         
644         * html/parser/HTMLScriptRunner.cpp:
645         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
646         (WebCore::HTMLScriptRunner::runScript):
647
648 2011-01-04  Xianzhu Wang  <wangxianzhu@google.com>
649
650         Reviewed by Darin Adler.
651
652         Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
653         ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
654         on ARM.
655         https://bugs.webkit.org/show_bug.cgi?id=51861
656
657         By the way, changed other getIntXX() and setIntXX() methods to use
658         more precise integer types.
659
660         * bindings/js/JSDataViewCustom.cpp:
661         (WebCore::setDataViewMember):
662         * bindings/v8/custom/V8DataViewCustom.cpp:
663         (WebCore::V8DataView::getInt8Callback):
664         (WebCore::V8DataView::setInt8Callback):
665         * html/canvas/DataView.cpp:
666         (WebCore::DataView::getInt8):
667         (WebCore::DataView::setInt8):
668         * html/canvas/DataView.h:
669         * html/canvas/DataView.idl:
670
671 2011-01-04  Yong Li  <yoli@rim.com>
672
673         Reviewed by Adam Barth.
674
675         Suspend HTMLParserScheduler when page load is deferred to
676         avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
677         from an external script or by events, and is blocked by a modal dialog,
678         WebKit can parse more HTML source and also start another JS execution.
679         
680         https://bugs.webkit.org/show_bug.cgi?id=48077
681
682         Test case: WebCore/manual-tests/bugzilla-48077.html.
683
684         * dom/DocumentParser.cpp:
685         (WebCore::DocumentParser::suspendScheduledTasks):
686         (WebCore::DocumentParser::resumeScheduledTasks):
687         * dom/DocumentParser.h:
688         * html/parser/HTMLDocumentParser.cpp:
689         (WebCore::HTMLDocumentParser::suspendScheduledTasks):
690         (WebCore::HTMLDocumentParser::resumeScheduledTasks):
691         * html/parser/HTMLParserScheduler.cpp:
692         (WebCore::HTMLParserScheduler::HTMLParserScheduler):
693         (WebCore::HTMLParserScheduler::suspend):
694         (WebCore::HTMLParserScheduler::resume):
695         * html/parser/HTMLParserScheduler.h:
696         (WebCore::HTMLParserScheduler::isScheduledForResume):
697         * page/PageGroupLoadDeferrer.cpp:
698         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
699         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
700
701 2011-01-04  Tony Gentilcore  <tonyg@chromium.org>
702
703         Unreviewed build fix.
704
705         Include glib-object.h for GObject
706         https://bugs.webkit.org/show_bug.cgi?id=51876
707
708         * bindings/gobject/DOMObjectCache.cpp:
709
710 2011-01-04  Ryosuke Niwa  <rniwa@webkit.org>
711
712         Reviewed by Dan Bernstein.
713
714         Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
715         https://bugs.webkit.org/show_bug.cgi?id=50992
716
717         Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
718         does not match. Reused the code added by http://trac.webkit.org/changeset/73553.
719
720         Test: editing/selection/caret-bidi-first-and-last-letters.html
721
722         * rendering/InlineTextBox.cpp:
723         (WebCore::InlineTextBox::offsetForPosition):
724
725 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
726
727         Reviewed by Darin Adler.
728
729         Remove 2 unnecessary includes from Document.h
730         https://bugs.webkit.org/show_bug.cgi?id=51727
731
732         No new tests because no changed functionality.
733
734         * dom/Document.cpp:
735         * dom/Document.h:
736         * editing/Editor.cpp:
737         * editing/SpellChecker.h:
738         * editing/SplitTextNodeCommand.cpp:
739         * editing/TextCheckingHelper.cpp:
740         * page/FrameView.cpp:
741         * page/Page.cpp:
742         * rendering/HitTestResult.cpp:
743         * rendering/InlineTextBox.cpp:
744         * rendering/InlineTextBox.h:
745         * rendering/svg/SVGInlineFlowBox.cpp:
746
747 2011-01-04  Patrick Gansterer  <paroga@webkit.org>
748
749         Unreviewed WinCE build fix.
750
751         * CMakeListsWinCE.txt: Added missing include directories, files and libraries.
752
753 2011-01-04  Yi Shen  <yi.4.shen@nokia.com>
754
755         Reviewed by Simon Hausmann.
756
757         Provide an interface to require using fullscreen mediaplayer
758         https://bugs.webkit.org/show_bug.cgi?id=51133
759
760         Only video should be displayed in fullscreen when 
761         requiresFullscreenForVideoPlayback is specified.
762
763         No new tests because no client implements requiresFullscreenForVideoPlayback yet.
764
765         * html/HTMLMediaElement.cpp:
766         (WebCore::HTMLMediaElement::updatePlayState):
767
768 2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
769
770         Reviewed by Kenneth Rohde Christiansen.
771
772         [Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
773         https://bugs.webkit.org/show_bug.cgi?id=51825
774
775         Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
776         platform independent menu informations.
777
778         * platform/qt/ContextMenuQt.cpp:
779         (WebCore::contextMenuItemVector):
780
781 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
782
783         Unreviewed, rolling out r74960.
784         http://trac.webkit.org/changeset/74960
785         https://bugs.webkit.org/show_bug.cgi?id=51868
786
787         Rollout since we hit an assert after this patch. (Requested by
788         krit on #webkit).
789
790         * svg/SVGUseElement.cpp:
791         (WebCore::SVGUseElement::buildInstanceTree):
792
793 2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>
794
795         Unreviewed, rolling out r74961.
796         http://trac.webkit.org/changeset/74961
797         https://bugs.webkit.org/show_bug.cgi?id=51867
798
799         breaks 32/64-bits debug bots build (Requested by philn-tp on
800         #webkit).
801
802         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
803         (WebCore::GStreamerGWorld::setWindowOverlay):
804
805 2011-01-03  Philippe Normand  <pnormand@igalia.com>
806
807         Rubber-stamped by Eric Seidel.
808
809         [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
810         https://bugs.webkit.org/show_bug.cgi?id=51810
811
812         Based on a patch by Mart Raudsepp.
813
814         No new tests, build fix only.
815
816         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
817         (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
818         API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
819         introduced in same version as the xoverlay API change.
820
821 2011-01-04  Leo Yang  <leo.yang@torchmobile.com.cn>
822
823         Reviewed by Dirk Schulze.
824
825         Malformed SVG causes crash in updateContainerOffset
826         https://bugs.webkit.org/show_bug.cgi?id=44610
827
828         We should check recursive <use> at the begining of
829         WebCore::SVGUseElement::buildInstanceTree instead
830         of at the end of it because the target element's
831         children may cause infinite recursive <use>.
832
833         Test: svg/custom/recursive-use.svg
834
835         * svg/SVGUseElement.cpp:
836         (WebCore::SVGUseElement::buildInstanceTree):
837
838 2011-01-04  Kent Tamura  <tkent@chromium.org>
839
840         Unreviewed, build fix.
841
842         Try to fix Clang build.
843
844         * css/CSSParser.cpp:
845         (WebCore::valueFromSideKeyword):
846         (WebCore::CSSParser::parseLinearGradient):
847
848 2011-01-03  Julie-Jeongeun-Kim  <Jeongeun.Kim@obigo.com>
849
850         Reviewed by Darin Adler.
851
852         HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
853         https://bugs.webkit.org/show_bug.cgi?id=48596
854         
855         border attribute was not parsed in HTMLObjectElement.
856         I added code for it as HTMLImageElement handled.
857
858         new test:fast/html/object-border.html
859
860         * html/HTMLObjectElement.cpp:
861         (WebCore::HTMLObjectElement::parseMappedAttribute):
862
863 2011-01-03  Darin Adler  <darin@apple.com>
864
865         Try to fix Chromium build.
866
867         * history/HistoryItem.cpp:
868         (WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
869         Not sure this ever will be used with V8.
870         (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
871
872 2011-01-03  Darin Adler  <darin@apple.com>
873
874         Try to fix Leopard build.
875
876         * history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
877         size variable.
878
879 2011-01-03  Abhishek Arya  <inferno@chromium.org>
880
881         Reviewed by Darin Adler.
882
883         Fixes before child calculation when adding anonymous childs to table parts.
884         https://bugs.webkit.org/show_bug.cgi?id=50932
885
886         Fix in r74364 was incomplete. When before child is equal to the table part(to
887         which the new child is getting added), it confuses the table part to add it
888         incorrectly as an after child. The patch fixes by passing the before child as
889         the table part's first child.
890
891         Tests: fast/css-generated-content/table-before-after-child-add.html
892                fast/css-generated-content/table-cell-before-after-child-add.html
893                fast/css-generated-content/table-row-before-after-child-add.html
894                fast/css-generated-content/table-row-before-after-child-add.html
895
896         * rendering/RenderTable.cpp:
897         (WebCore::RenderTable::addChild):
898         * rendering/RenderTableRow.cpp:
899         (WebCore::RenderTableRow::addChild):
900         * rendering/RenderTableSection.cpp:
901         (WebCore::RenderTableSection::addChild):
902
903 2011-01-03  Dan Bernstein  <mitz@apple.com>
904
905         Reviewed by Simon Fraser.
906
907         Shrink HTMLTableCellElement
908         https://bugs.webkit.org/show_bug.cgi?id=51858
909
910         * html/HTMLTableCellElement.cpp:
911         (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
912         m_col.
913         * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
914
915 2011-01-03  Darin Adler  <darin@apple.com>
916
917         Fix build.
918
919         * platform/network/FormData.cpp:
920         (WebCore::FormData::create): Roll back uint8_t change.
921         (WebCore::FormData::flatten): Ditto.
922         (WebCore::FormData::flattenToString): Ditto.
923         (WebCore::encode): Ditto.
924         (WebCore::decode): Ditto.
925         (WebCore::FormData::encodeForBackForward):
926         * platform/network/FormData.h: Ditto.
927         * platform/network/mac/FormDataStreamMac.mm:
928         (WebCore::advanceCurrentStream): Ditto.
929
930 2011-01-03  Darin Adler  <darin@apple.com>
931
932         Reviewed by Brady Eidson.
933
934         Add code to encode/decode the back/forward tree
935         https://bugs.webkit.org/show_bug.cgi?id=51853
936
937         * history/HistoryItem.cpp:
938         (WebCore::HistoryItem::encodeBackForwardTree): Added.
939         (WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
940         (WebCore::HistoryItem::decodeBackForwardTree): Added.
941         * history/HistoryItem.h: Added functions above.
942
943         * platform/network/FormData.cpp:
944         (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
945         Vector<char>. This type is used in our newer code for vectors of bytes.
946         (WebCore::FormData::flatten): Ditto.
947         (WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
948         (WebCore::FormData::encodeForBackForward): Added.
949         (WebCore::FormData::decodeForBackForward): Added.
950         * platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
951         Vector<char>. Also made some single-argument constructors explicit.
952         Also added the new functions.
953
954         * platform/network/mac/FormDataStreamMac.mm:
955         (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
956
957 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
958
959         Attempt to fix GTK build.
960
961         * platform/graphics/gtk/FontGtk.cpp:
962         (WebCore::drawGlyphsShadow):
963
964 2011-01-03  Helder Correia  <helder@sencha.com>
965
966         Reviewed by Simon Fraser.
967
968         ContextShadow can avoid code duplication for getting the CTM
969         https://bugs.webkit.org/show_bug.cgi?id=51799
970
971         ContextShadow defines its own getTransformationMatrixFromContext()
972         which does exactly the same as GraphicsContext::getCTM().
973
974         Existing tests: fast/canvas/canvas*shadow*html
975
976         * platform/graphics/ContextShadow.cpp:
977         (WebCore::ContextShadow::mustUseContextShadow):
978         (WebCore::ContextShadow::adjustBlurDistance):
979         (WebCore::ContextShadow::calculateLayerBoundingRect):
980         * platform/graphics/ContextShadow.h:
981         * platform/graphics/cairo/ContextShadowCairo.cpp:
982         (WebCore::ContextShadow::beginShadowLayer):
983         (WebCore::ContextShadow::endShadowLayer):
984         (WebCore::ContextShadow::drawRectShadowWithoutTiling):
985         * platform/graphics/cairo/FontCairo.cpp:
986         (WebCore::drawGlyphsShadow):
987         * platform/graphics/cairo/GraphicsContextCairo.cpp:
988         (WebCore::drawPathShadow):
989         * platform/graphics/cairo/ImageCairo.cpp:
990         (WebCore::BitmapImage::draw):
991         * platform/graphics/gtk/FontGtk.cpp:
992         (WebCore::drawGlyphsShadow):
993         * platform/graphics/qt/ContextShadowQt.cpp:
994         (WebCore::ContextShadow::beginShadowLayer):
995         (WebCore::ContextShadow::endShadowLayer):
996         * platform/graphics/qt/FontQt.cpp:
997         (WebCore::drawTextCommon):
998         * platform/graphics/qt/GraphicsContextQt.cpp:
999         (WebCore::GraphicsContext::fillPath):
1000         (WebCore::GraphicsContext::strokePath):
1001         (WebCore::GraphicsContext::fillRect):
1002         (WebCore::GraphicsContext::fillRoundedRect):
1003         * platform/graphics/qt/ImageQt.cpp:
1004         (WebCore::BitmapImage::draw):
1005         * platform/graphics/qt/StillImageQt.cpp:
1006         (WebCore::StillImage::draw):
1007
1008 2011-01-03  Darin Adler  <darin@apple.com>
1009
1010         Reviewed by Dan Bernstein.
1011
1012         InsertTextCommand::m_charactersAdded is unused
1013         https://bugs.webkit.org/show_bug.cgi?id=51849
1014
1015         * editing/InsertTextCommand.cpp:
1016         (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
1017         (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
1018         * editing/InsertTextCommand.h: Removed charactersAdded function and
1019         m_charactersAdded data member.
1020
1021 2011-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1022
1023         Reviewed by Martin Robinson.
1024
1025         [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
1026         https://bugs.webkit.org/show_bug.cgi?id=51832
1027
1028         Method paintMenuListButton() contains code common to both gtk 2
1029         and 3, so it can be moved to RenderThemeGtk.cpp instead of
1030         duplicating it.
1031
1032         * platform/gtk/RenderThemeGtk.cpp:
1033         (WebCore::RenderThemeGtk::paintMenuListButton):
1034         * platform/gtk/RenderThemeGtk2.cpp:
1035         * platform/gtk/RenderThemeGtk3.cpp:
1036
1037 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1038
1039         Reviewed by Darin Adler.
1040
1041         https://bugs.webkit.org/show_bug.cgi?id=51850
1042         Put CFNetwork loader code inside USE(CFNETWORK)
1043
1044         Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
1045         files to the WebCore Xcode project.
1046
1047         * WebCore.xcodeproj/project.pbxproj:
1048         * loader/cf/ResourceLoaderCFNet.cpp:
1049         * loader/mac/ResourceLoaderMac.mm:
1050         * platform/network/cf/AuthenticationCF.cpp:
1051         * platform/network/cf/AuthenticationCF.h:
1052         * platform/network/cf/CookieJarCFNet.cpp:
1053         * platform/network/cf/CookieStorageCFNet.cpp:
1054         * platform/network/cf/CookieStorageCFNet.h:
1055         * platform/network/cf/CredentialStorageCFNet.cpp:
1056         * platform/network/cf/FormDataStreamCFNet.cpp:
1057         * platform/network/cf/FormDataStreamCFNet.h:
1058         * platform/network/cf/LoaderRunLoopCF.cpp:
1059         * platform/network/cf/LoaderRunLoopCF.h:
1060         * platform/network/cf/ResourceError.h:
1061         * platform/network/cf/ResourceHandleCFNet.cpp:
1062         * platform/network/cf/ResourceRequest.h:
1063         * platform/network/cf/ResourceRequestCFNet.cpp:
1064         * platform/network/cf/ResourceRequestCFNet.h:
1065         * platform/network/cf/ResourceResponse.h:
1066         * platform/network/cf/ResourceResponseCFNet.cpp:
1067         * platform/network/mac/AuthenticationMac.h:
1068         * platform/network/mac/AuthenticationMac.mm:
1069         * platform/network/mac/FormDataStreamMac.h:
1070         * platform/network/mac/FormDataStreamMac.mm:
1071         * platform/network/mac/ResourceError.h:
1072         * platform/network/mac/ResourceHandleMac.mm:
1073         * platform/network/mac/ResourceRequest.h:
1074         * platform/network/mac/ResourceRequestMac.mm:
1075         * platform/network/mac/ResourceResponse.h:
1076         * platform/network/mac/ResourceResponseMac.mm:
1077
1078 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1079
1080         Reviewed by Adam Barth.
1081
1082         [Qt] Add SelectAll option to the context menu for the editor
1083         https://bugs.webkit.org/show_bug.cgi?id=50049
1084
1085         Enable SelectAll for the Qt context menu.
1086
1087         * page/ContextMenuController.cpp:
1088         (WebCore::ContextMenuController::populate):
1089         * platform/ContextMenuItem.h:
1090         * platform/LocalizationStrategy.h:
1091         * platform/LocalizedStrings.cpp:
1092         (WebCore::contextMenuItemTagSelectAll):
1093         * platform/LocalizedStrings.h:
1094
1095 2011-01-03  Dan Bernstein  <mitz@apple.com>
1096
1097         Reviewed by Darin Adler.
1098
1099         Shrink RootInlineBox
1100         https://bugs.webkit.org/show_bug.cgi?id=51847
1101
1102         * rendering/RootInlineBox.cpp:
1103         (WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
1104         accessor.
1105         * rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
1106         unsigned because otherwise MSVC treats it as signed.
1107         (WebCore::RootInlineBox::baselineType): Added a cast.
1108
1109 2011-01-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1110
1111         Reviewed by Martin Robinson.
1112
1113         [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
1114         https://bugs.webkit.org/show_bug.cgi?id=50698
1115
1116         Fix DOM bindings generation to no longer include the now-gone
1117         webkitprivate.h header, including the appropriate replacements
1118         instead.
1119
1120         * bindings/scripts/CodeGeneratorGObject.pm:
1121
1122 2011-01-03  Brady Eidson  <beidson@apple.com>
1123
1124         Reviewed by Darin Adler.
1125
1126         Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
1127
1128         * ForwardingHeaders/wtf/Decoder.h: Added.
1129         * ForwardingHeaders/wtf/Encoder.h: Added.
1130
1131 2011-01-03  Chris Fleizach  <cfleizach@apple.com>
1132
1133         Reviewed by Darin Adler.
1134
1135         AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
1136         https://bugs.webkit.org/show_bug.cgi?id=51833
1137
1138         Make sure the web area returns the contentsSize, not the same size as what is displayed.
1139
1140         Test: platform/mac/accessibility/webarea-size-equals-content-size.html
1141
1142         * accessibility/AccessibilityRenderObject.cpp:
1143         (WebCore::AccessibilityRenderObject::boundingBoxRect):
1144
1145 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
1146
1147         Fix warning in 32-bit builds.
1148
1149         * css/CSSGradientValue.cpp:
1150         (WebCore::CSSLinearGradientValue::createGradient):
1151
1152 2011-01-03  Benjamin C Meyer  <bmeyer@rim.com>
1153
1154         Reviewed by Daniel Bates.
1155
1156         In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
1157         https://bugs.webkit.org/show_bug.cgi?id=51827
1158
1159         * CMakeLists.txt:
1160
1161 2011-01-03  Dan Bernstein  <mitz@apple.com>
1162
1163         Reviewed by Simon Fraser.
1164
1165         Remove the unused RenderTableCell::m_percentageHeight
1166         https://bugs.webkit.org/show_bug.cgi?id=51837
1167
1168         * rendering/RenderTableCell.cpp:
1169         (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
1170         * rendering/RenderTableCell.h: Removed m_percentageHeight.
1171
1172 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
1173
1174         Reviewed by David Hyatt.
1175
1176         Implement -webkit-linear-gradient and -webkit-radial-gradient
1177         https://bugs.webkit.org/show_bug.cgi?id=28152
1178
1179         Add support for -webkit-radial-gradients.
1180
1181         Tests: fast/gradients/css3-radial-gradients.html
1182                fast/gradients/css3-radial-gradients2.html
1183
1184         * css/CSSGradientValue.cpp:
1185         (WebCore::blend): Used to blend colors, which is necessary when truncating
1186         the start of radial gradients.
1187         (WebCore::GradientStop): Small struct to aid gradient stop processing.
1188         (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store
1189         the color so that we can blend it when truncating radial gradients. Changed
1190         to handle both linear and radial gradients.
1191         (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec.
1192         (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change.
1193         (WebCore::distanceToClosestCorner): New utility method.
1194         (WebCore::distanceToFarthestCorner): Ditto.
1195         (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and
1196         fill rules.
1197
1198         * css/CSSGradientValue.h:
1199         (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what
1200         kind of gradient it's dealing with, so add new isFooGradient methods.
1201         (WebCore::CSSGradientValue::isRadialGradient): Ditto.
1202         (WebCore::CSSLinearGradientValue::isLinearGradient):
1203         (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc.
1204         (WebCore::CSSRadialGradientValue::setSizingBehavior):
1205         (WebCore::CSSRadialGradientValue::setEndHorizontalSize):
1206         (WebCore::CSSRadialGradientValue::setEndVerticalSize):
1207         (WebCore::CSSRadialGradientValue::isRadialGradient):
1208
1209         * css/CSSParser.h:
1210         * css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition()
1211         so we can use parseFillPosition() when parsing a gradient function.
1212         * css/CSSParser.cpp:
1213         (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList*
1214         (WebCore::CSSParser::parseFillPosition): Ditto
1215         (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition.
1216         (WebCore::CSSParser::parseTransformOriginShorthand): Ditto
1217         (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing.
1218         (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition.
1219         (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
1220
1221         * css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
1222
1223         * platform/graphics/Gradient.cpp:
1224         (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
1225         * platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients.
1226         (WebCore::Gradient::create):
1227         (WebCore::Gradient::startRadius): Expose radii.
1228         (WebCore::Gradient::endRadius):
1229         (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops.
1230         (WebCore::Gradient::setEndRadius):
1231         (WebCore::Gradient::aspectRatio):
1232         * platform/graphics/cg/GradientCG.cpp:
1233         (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
1234         * platform/graphics/wince/GraphicsContextWinCE.cpp:
1235         (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
1236
1237 2011-01-03  Simon Fraser  <simon.fraser@apple.com>
1238
1239         Reviewed by David Hyatt.
1240
1241         Implement -webkit-linear-gradient and -webkit-radial-gradient
1242         https://bugs.webkit.org/show_bug.cgi?id=28152
1243         
1244         Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
1245         according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
1246
1247         Tests: fast/gradients/css3-color-stop-units.html
1248                fast/gradients/css3-color-stops.html
1249                fast/gradients/css3-gradient-parsing.html
1250                fast/gradients/css3-linear-angle-gradients.html
1251
1252         * css/CSSGradientValue.h:
1253         Add subclasses of CSSGradientValue for linear and radial gradients.
1254         
1255         * css/CSSGradientValue.cpp:
1256         (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache
1257         the gradient sometimes.
1258         (WebCore::compareStops): positions are CSSValues now.
1259         (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called
1260         for old-style gradients.
1261         (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about
1262         missing positions, ensuring that stop position is ordered, and spacing out stops
1263         without positions. Also normalize gradients which use stops outside the 0-1 range
1264         so that platforms can render them correctly.
1265         (WebCore::positionFromValue): Determin the position on the gradient line for percentage,
1266         number and length values.
1267         (WebCore::CSSGradientValue::computeEndPoint):
1268         (WebCore::CSSLinearGradientValue::cssText):
1269         (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle
1270         given an angle.
1271         (WebCore::CSSLinearGradientValue::createGradient):
1272         (WebCore::CSSRadialGradientValue::cssText):
1273         (WebCore::CSSRadialGradientValue::resolveRadius):
1274         (WebCore::CSSRadialGradientValue::createGradient):
1275
1276         * css/CSSParser.cpp:
1277         (WebCore::CSSParser::parseValue): Style fix.
1278         (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage()
1279         (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage()
1280         (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage()
1281         (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient.
1282         (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient,
1283         and fixed to store CSSValues for the stop position.
1284         (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient,
1285         and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate.
1286         (WebCore::valueFromSideKeyword):
1287         (WebCore::parseGradientColorOrKeyword): Color parsing utility.
1288         (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients.
1289         (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients.
1290         (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas.
1291         (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients
1292         and CSS canvas.
1293         * css/CSSParser.h:
1294         * platform/graphics/Gradient.h:
1295         (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients.
1296         (WebCore::Gradient::setP1): Ditto.
1297
1298 2011-01-03  Noam Rosenthal  <noam.rosenthal@nokia.com>
1299
1300         Reviewed by Andreas Kling.
1301
1302         [Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
1303         https://bugs.webkit.org/show_bug.cgi?id=51464
1304
1305         Added a way to bind any QObject created as a plugin to JavaScript, 
1306         by adding a custom member (qtObject) to WebCore::Widget. 
1307         Added a test to tst_qwebpage to make sure plugins created 
1308         as QGraphicsWidget are accessible through JavaScript.
1309
1310         * bindings/js/ScriptControllerQt.cpp:
1311         (WebCore::ScriptController::createScriptInstanceForWidget):
1312         * platform/Widget.h:
1313         * platform/qt/WidgetQt.cpp:
1314         (WebCore::Widget::Widget):
1315         (WebCore::Widget::setBindingObject):
1316         (WebCore::Widget::bindingObject):
1317
1318 2011-01-03  David Hyatt  <hyatt@apple.com>
1319
1320         Reviewed by Simon Fraser.
1321
1322         https://bugs.webkit.org/show_bug.cgi?id=51328
1323
1324         Printing on a page with body { height: 100% } clips out the overflow contents.  This happened
1325         because the computePageRects function was never correct.  It was using the layer's width and height
1326         for the document's width and height, and the layer no longer includes overflow in its width and
1327         height.  It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
1328         assumption in RTL or vertical text environments.
1329
1330         Added printing/page-count-percentage-height.html
1331
1332         * page/PrintContext.cpp:
1333         (WebCore::PrintContext::computePageRects):
1334         (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
1335
1336 2011-01-03  Csaba Osztrogonác  <ossy@webkit.org>
1337
1338         [Qt] Unreviewed buildfix for --minimal build after r74895.
1339
1340         * html/InputType.cpp: Missing include added.
1341         * html/NumberInputType.cpp: Missing include added.
1342
1343 2011-01-02  Darin Adler  <darin@apple.com>
1344
1345         Reviewed by Kent Tamura.
1346
1347         Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
1348         https://bugs.webkit.org/show_bug.cgi?id=51791
1349
1350         * dom/InputElement.h: Make sanitizeValueForTextField public so it can
1351         be called by InputType.
1352
1353         * html/BaseButtonInputType.cpp:
1354         (WebCore::BaseButtonInputType::accessKeyAction): Added.
1355         (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
1356         * html/BaseButtonInputType.h: Ditto.
1357
1358         * html/BaseCheckableInputType.cpp:
1359         (WebCore::BaseCheckableInputType::canSetStringValue): Added.
1360         (WebCore::BaseCheckableInputType::accessKeyAction): Added.
1361         (WebCore::BaseCheckableInputType::fallbackValue): Added.
1362         (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
1363         (WebCore::BaseCheckableInputType::isCheckable): Added.
1364         * html/BaseCheckableInputType.h: Ditto.
1365
1366         * html/BaseDateAndTimeInputType.cpp:
1367         (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
1368         * html/BaseDateAndTimeInputType.h: Ditto.
1369
1370         * html/BaseTextInputType.h: Made more functions private.
1371
1372         * html/ButtonInputType.cpp:
1373         (WebCore::ButtonInputType::isTextButton): Added.
1374         * html/ButtonInputType.h: Ditto.
1375
1376         * html/CheckboxInputType.cpp:
1377         (WebCore::CheckboxInputType::willDispatchClick): Added.
1378         (WebCore::CheckboxInputType::didDispatchClick): Added.
1379         (WebCore::CheckboxInputType::isCheckbox): Added.
1380         * html/CheckboxInputType.h: Ditto.
1381
1382         * html/DateTimeInputType.cpp:
1383         (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
1384         typo in name of this function.
1385         * html/DateTimeInputType.h: Ditto.
1386         * html/DateTimeLocalInputType.cpp:
1387         (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
1388         * html/DateTimeLocalInputType.h: Ditto.
1389
1390         * html/EmailInputType.cpp:
1391         (WebCore::EmailInputType::isEmailField): Added.
1392         * html/EmailInputType.h: Ditto.
1393
1394         * html/FileInputType.cpp:
1395         (WebCore::FileInputType::FileInputType): Added.
1396         (WebCore::FileInputType::canSetStringValue): Added.
1397         (WebCore::FileInputType::canChangeFromAnotherType): Added.
1398         (WebCore::FileInputType::files): Added.
1399         (WebCore::FileInputType::canSetValue): Added.
1400         (WebCore::FileInputType::getTypeSpecificValue): Added.
1401         (WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
1402         (WebCore::FileInputType::setFileList): Added.
1403         (WebCore::FileInputType::isFileUpload): Added.
1404         * html/FileInputType.h: Ditto.
1405
1406         * html/HTMLInputElement.cpp:
1407         (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
1408         renaming and removal.
1409         (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
1410         instead of checking specific type numbers.
1411         (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
1412         Use fastGetAttribute and fixed typo in the name of the
1413         scaledStepValueShouldBeInteger function.
1414         (WebCore::HTMLInputElement::isKeyboardFocusable): Call
1415         InputType::isKeyboardFocusable; moved most of the type-specific
1416         logic there.
1417         (WebCore::HTMLInputElement::shouldUseInputMethod): Call
1418         InputType::shouldUseInputMethod; moved the type-specific logic there.
1419         (WebCore::HTMLInputElement::handleBlurEvent): Call
1420         InputType::handleBlurEvent; moved the type-specific logic there.
1421         (WebCore::HTMLInputElement::setType): Tweak the names and types
1422         in this function.
1423         (WebCore::HTMLInputElement::updateType): Removed the code that
1424         set m_deprecatedTypeNumber. Compare types by comparing the value
1425         from formControlType. Removed file-specific logic and instead call
1426         InputType::canChangeFromAnotherType. Streamlined the logic for
1427         activation callbacks.
1428         (WebCore::HTMLInputElement::accessKeyAction): Call
1429         InputType::accessKeyAction; moved the type-specific logic there.
1430         (WebCore::HTMLInputElement::mapToEntry): Call
1431         InputType::shouldRespectHeightAndWidthAttributes and
1432         InputType::shouldRespectAlignAttribute.
1433         (WebCore::HTMLInputElement::parseMappedAttribute): Updated
1434         for name changes and the removal of m_defaultChecked. Changed the
1435         alt attribute logic to be based on the class of the renderer.
1436         Call InputType::srcAttributeChanged and moved the type-specific
1437         logic there. Call shouldRespectAlignAttribute and
1438         shouldRespectHeightAndWidthAttributes rather than having
1439         type-specific logic here. Call minOrMaxAttributeChanged.
1440         (WebCore::HTMLInputElement::rendererIsNeeded): Call
1441         InputType::rendererIsNeeded; moved the type-specific logic there.
1442         (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
1443         flag, which was redundant with the m_haveType flag. Call
1444         InputType::attach; moved the type-specific logic there.
1445         (WebCore::HTMLInputElement::altText): Use fastGetAttribute.
1446         (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
1447         InputType::canBeSuccessfulSubmitButton; moved the type-specific
1448         logic there.
1449         (WebCore::HTMLInputElement::isActivatedSubmit): Updated for
1450         name changes.
1451         (WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
1452         (WebCore::HTMLInputElement::reset): Updated to use
1453         InputType::storesValueSeparateFromAttribute. Also use
1454         hasAttribute(checkedAttr) rather than m_defaultChecked,
1455         since both are the same. Also updated for name change.
1456         (WebCore::HTMLInputElement::setChecked): Updated for name
1457         changes. Also added call to
1458         InputType::shouldSendChangeEventAfterCheckedChanged and
1459         moved the type-specific logic there.
1460         (WebCore::HTMLInputElement::setIndeterminate): Call
1461         isCheckable to see if indeterminate is allowed.
1462         Also updated for name changes.
1463         (WebCore::HTMLInputElement::copyNonAttributeProperties):
1464         Updated for name changes and removed data members.
1465         (WebCore::HTMLInputElement::value): Call
1466         InputType::getTypeSpecificValue and InputType::fallbackValue.
1467         Moved the type-specific logic there.
1468         (WebCore::HTMLInputElement::valueWithDefault): Call
1469         InputType::defaultValue. Moved the type-specific logic there.
1470         (WebCore::HTMLInputElement::setSuggestedValue): Call
1471         InputType::canSetSuggestedValue. Moved the type-specific logic
1472         there.
1473         (WebCore::HTMLInputElement::setValue): Call
1474         InputType::canSetValue. Moved the type-specific logic there.
1475         Clear the file list if it exists rather than checking the
1476         type explicitly. We could probably do that a more elegant way.
1477         (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
1478         (WebCore::HTMLInputElement::setValueFromRenderer): Use the
1479         isFileUpload function in the assertion.
1480         (WebCore::HTMLInputElement::setFileListFromRenderer): Put most
1481         of the code from this function into FileInputType::setFileList.
1482         (WebCore::HTMLInputElement::preDispatchEventHandler): Changed
1483         to call InputType::willDispatchClick, which does the type-specific
1484         work. Still need to use a single struct for all types, because
1485         the type of the element could change during the event handling.
1486         (WebCore::HTMLInputElement::postDispatchEventHandler): Changed
1487         to call InputType::didDispatchClick.
1488         (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
1489         (WebCore::HTMLInputElement::accept): Use fastGetAttribute.
1490         (WebCore::HTMLInputElement::alt): Use fastGetAttribute.
1491         (WebCore::HTMLInputElement::src): Use fastGetAttribute.
1492         (WebCore::HTMLInputElement::setAutofilled): Updated for name
1493         changes.
1494         (WebCore::HTMLInputElement::files): Use InputType::files.
1495         (WebCore::HTMLInputElement::isAcceptableValue): Use
1496         InputType::isAcceptableValue.
1497         (WebCore::HTMLInputElement::sanitizeValue): Use
1498         InputType::sanitizeValue.
1499         (WebCore::HTMLInputElement::hasUnacceptableValue): Use
1500         InputType::hasUnacceptableValue.
1501         (WebCore::HTMLInputElement::needsActivationCallback): Use
1502         InputType::shouldResetOnDocumentActivation.
1503         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
1504         InputType::willMoveToNewOwnerDocument.
1505         (WebCore::HTMLInputElement::dataList): Use
1506         InputType::shouldRespectListAttribute.
1507         (WebCore::HTMLInputElement::selectedOption): Tweaked logic
1508         and naming a bit.
1509         (WebCore::HTMLInputElement::stepUpFromRenderer): Use
1510         fastGetAttribute.
1511         (WebCore::HTMLInputElement::isSpeechEnabled): Use
1512         InputType::shouldRespectSpeechAttribute.
1513         (WebCore::HTMLInputElement::isTextButton): No longer inline.
1514         Calls through to InputType.
1515         (WebCore::HTMLInputElement::isRadioButton): Ditto.
1516         (WebCore::HTMLInputElement::isSearchField): Ditto.
1517         (WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
1518         (WebCore::HTMLInputElement::isPasswordField): Ditto.
1519         (WebCore::HTMLInputElement::isCheckbox): Ditto.
1520         (WebCore::HTMLInputElement::isText): Ditto.
1521         (WebCore::HTMLInputElement::isEmailField): Ditto.
1522         (WebCore::HTMLInputElement::isFileUpload): Ditto.
1523         (WebCore::HTMLInputElement::isImageButton): Ditto.
1524         (WebCore::HTMLInputElement::isNumberField): Ditto.
1525         (WebCore::HTMLInputElement::isSubmitButton): Ditto.
1526         (WebCore::HTMLInputElement::isTelephoneField): Ditto.
1527         (WebCore::HTMLInputElement::isURLField): Ditto.
1528         (WebCore::HTMLInputElement::isEnumeratable): Ditto.
1529         (WebCore::HTMLInputElement::isChecked): No longer inline.
1530         Calls InputType::isCheckable.
1531         (WebCore::HTMLInputElement::hasSpinButton): No longer inline.
1532         Calls through to InputType.
1533         (WebCore::HTMLInputElement::supportsPlaceholder): No longer
1534         inline. Calls isTextType as before, but with no special case
1535         for ISINDEX. That special case was unneeded since it returns
1536         true from isTextType.
1537         (WebCore::HTMLInputElement::checkedRadioButtons): No longer
1538         inline.
1539         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
1540         No longer inline.
1541
1542         * html/HTMLInputElement.h: Removed multiple unneeded includes.
1543         The big one is probably InputType.h, but also HTMLFormElement.h.
1544         Removed unneeded forward declarations. Made many functions
1545         no longer inline since they now need to make virtual function
1546         dispatches. Removed the unneeded defaultChecked and
1547         webkitdirectory functions. Both are handled by HTML attribute
1548         reflection for DOM bindings, and the callers instead can get
1549         at the attribute. Made updateCheckedRadioButtons public so it
1550         can be called by an InputType class. Removed
1551         DeprecatedInputType, InputTypeMap, createTypeMap,
1552         deprecatedInputType, allowsIndeterminate,
1553         respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
1554         m_imageLoader, m_fileList, m_deprecatedTypeNumber,
1555         m_defaultChecked, and m_inited. Renamed m_checked to
1556         m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
1557         m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
1558         m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
1559         m_isAutofilled.
1560         
1561         * html/HiddenInputType.cpp:
1562         (WebCore::HiddenInputType::accessKeyAction): Added.
1563         (WebCore::HiddenInputType::rendererIsNeeded) Added.:
1564         (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
1565         (WebCore::HiddenInputType::isHiddenType): Added.
1566         (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
1567         * html/HiddenInputType.h: Ditto.
1568
1569         * html/ImageInputType.cpp:
1570         (WebCore::ImageInputType::ImageInputType): Moved out of the header file.
1571         (WebCore::ImageInputType::srcAttributeChanged): Added.
1572         (WebCore::ImageInputType::attach): Added.
1573         (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
1574         (WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
1575         (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
1576         (WebCore::ImageInputType::isImageButton): Added.
1577         (WebCore::ImageInputType::isEnumeratable): Added.
1578         (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
1579         * html/ImageInputType.h: Ditto.
1580
1581         * html/InputType.cpp:
1582         (WebCore::InputType::create): Changed argument type to String. There
1583         is no value in taking an AtomicString here.
1584         (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
1585         this function name.
1586         (WebCore::InputType::canSetStringValue): Added.
1587         (WebCore::InputType::isKeyboardFocusable): Added.
1588         (WebCore::InputType::shouldUseInputMethod): Added.
1589         (WebCore::InputType::handleBlurEvent): Added.
1590         (WebCore::InputType::accessKeyAction): Added.
1591         (WebCore::InputType::attach): Added.
1592         (WebCore::InputType::srcAttributeChanged): Added.
1593         (WebCore::InputType::willMoveToNewOwnerDocument): Added.
1594         (WebCore::InputType::shouldRespectAlignAttribute): Added.
1595         (WebCore::InputType::canChangeFromAnotherType): Added.
1596         (WebCore::InputType::minOrMaxAttributeChanged): Added.
1597         (WebCore::InputType::canBeSuccessfulSubmitButton): Added.
1598         (WebCore::InputType::rendererIsNeeded): Added.
1599         (WebCore::InputType::files): Added.
1600         (WebCore::InputType::getTypeSpecificValue): Added.
1601         (WebCore::InputType::fallbackValue): Added.
1602         (WebCore::InputType::defaultValue): Added.
1603         (WebCore::InputType::canSetSuggestedValue): Added.
1604         (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
1605         (WebCore::InputType::storesValueSeparateFromAttribute): Added.
1606         (WebCore::InputType::canSetValue): Added.
1607         (WebCore::InputType::willDispatchClick): Added.
1608         (WebCore::InputType::didDispatchClick): Added.
1609         (WebCore::InputType::isAcceptableValue): Added.
1610         (WebCore::InputType::sanitizeValue): Added.
1611         (WebCore::InputType::hasUnacceptableValue): Added.
1612         (WebCore::InputType::setFileList): Added.
1613         (WebCore::InputType::shouldResetOnDocumentActivation): Added.
1614         (WebCore::InputType::shouldRespectListAttribute): Added.
1615         (WebCore::InputType::shouldRespectSpeechAttribute): Added.
1616         (WebCore::InputType::isTextButton): Added.
1617         (WebCore::InputType::isRadioButton): Added.
1618         (WebCore::InputType::isSearchField): Added.
1619         (WebCore::InputType::isHiddenType): Added.
1620         (WebCore::InputType::isPasswordField): Added.
1621         (WebCore::InputType::isCheckbox): Added.
1622         (WebCore::InputType::isEmailField): Added.
1623         (WebCore::InputType::isFileUpload): Added.
1624         (WebCore::InputType::isImageButton): Added.
1625         (WebCore::InputType::isNumberField): Added.
1626         (WebCore::InputType::isSubmitButton): Added.
1627         (WebCore::InputType::isTelephoneField): Added.
1628         (WebCore::InputType::isURLField): Added.
1629         (WebCore::InputType::isEnumeratable): Added.
1630         (WebCore::InputType::isCheckable): Added.
1631         (WebCore::InputType::hasSpinButton): Added.
1632         (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
1633
1634         * html/InputType.h: Removed unneeded ExceptionCode.h include and
1635         used a typedef instead as we do when we want for forward declare it.
1636         Added includes and forward declarations needed for new functions.
1637         Added ClickHandlingState structure. Changed the argument to create
1638         to a String rather than AtomicString. Added many virtual functions.
1639         
1640         * html/IsIndexInputType.cpp:
1641         (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
1642         * html/IsIndexInputType.h: Ditto.
1643
1644         * html/NumberInputType.cpp:
1645         (WebCore::NumberInputType::handleBlurEvent): Added.
1646         (WebCore::NumberInputType::isAcceptableValue): Added.
1647         (WebCore::NumberInputType::sanitizeValue): Added.
1648         (WebCore::NumberInputType::hasUnacceptableValue): Added.
1649         (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
1650         (WebCore::NumberInputType::isNumberField): Added.
1651         (WebCore::NumberInputType::hasSpinButton): Added.
1652         * html/NumberInputType.h: Ditto.
1653
1654         * html/PasswordInputType.cpp:
1655         (WebCore::PasswordInputType::shouldUseInputMethod): Added.
1656         (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
1657         (WebCore::PasswordInputType::shouldRespectListAttribute): Added.
1658         (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
1659         (WebCore::PasswordInputType::isPasswordField): Added.
1660         * html/PasswordInputType.h: Ditto.
1661
1662         * html/RadioInputType.cpp:
1663         (WebCore::RadioInputType::isKeyboardFocusable): Added.
1664         (WebCore::RadioInputType::attach): Added.
1665         (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
1666         (WebCore::RadioInputType::willDispatchClick): Added.
1667         (WebCore::RadioInputType::didDispatchClick): Added.
1668         (WebCore::RadioInputType::isRadioButton): Added.
1669         * html/RadioInputType.h: Ditto.
1670
1671         * html/RangeInputType.cpp:
1672         (WebCore::RangeInputType::accessKeyAction): Added.
1673         (WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
1674         (WebCore::RangeInputType::fallbackValue): Added.
1675         (WebCore::RangeInputType::sanitizeValue): Added.
1676         (WebCore::RangeInputType::shouldRespectListAttribute): Added.
1677         * html/RangeInputType.h: Ditto.
1678
1679         * html/ResetInputType.cpp:
1680         (WebCore::ResetInputType::defaultValue): Added.
1681         (WebCore::ResetInputType::isTextButton): Added.
1682         * html/ResetInputType.h: Ditto.
1683
1684         * html/SearchInputType.cpp:
1685         (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
1686         (WebCore::SearchInputType::isSearchField): Added.
1687         * html/SearchInputType.h: Ditto.
1688
1689         * html/SubmitInputType.cpp:
1690         (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
1691         (WebCore::SubmitInputType::defaultValue): Added.
1692         (WebCore::SubmitInputType::isSubmitButton): Added.
1693         (WebCore::SubmitInputType::isTextButton): Added.
1694         * html/SubmitInputType.h: Ditto.
1695
1696         * html/TelephoneInputType.cpp:
1697         (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
1698         (WebCore::TelephoneInputType::isTelephoneField): Added.
1699         * html/TelephoneInputType.h: Ditto.
1700
1701         * html/TextFieldInputType.cpp:
1702         (WebCore::TextFieldInputType::shouldUseInputMethod): Added.
1703         (WebCore::TextFieldInputType::sanitizeValue): Added.
1704         (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
1705         * html/TextFieldInputType.h: Ditto.
1706
1707         * html/TextInputType.cpp:
1708         (WebCore::TextInputType::canSetSuggestedValue): Added.
1709         (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
1710         * html/TextInputType.h: Ditto.
1711
1712         * html/TimeInputType.cpp:
1713         (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
1714         typo in the name of this function.
1715         * html/TimeInputType.h: Ditto.
1716
1717         * html/URLInputType.cpp:
1718         (WebCore::URLInputType::isURLField): Added.
1719         * html/URLInputType.h: Ditto.
1720
1721 2011-01-03  Mihai Parparita  <mihaip@chromium.org>
1722
1723         Unreviewed.
1724
1725         NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
1726         https://bugs.webkit.org/show_bug.cgi?id=51151
1727
1728         Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
1729         so that it can match Safari's (and thus use the same baselines).
1730
1731         No new tests, should be covered by layout tests (which will need
1732         expectation changes)
1733
1734         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1735
1736 2011-01-03  Antonio Gomes  <agomes@rim.com>
1737
1738         Unreviewed build fix for WebKit/Gtk+.
1739
1740         RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
1741         guarded by ENABLE(VIDEO), as it is in its header.
1742
1743         No new tests.
1744
1745         * platform/gtk/RenderThemeGtk2.cpp:
1746
1747 2011-01-02  Dan Bernstein  <mitz@apple.com>
1748
1749         Rubber-stamped by Simon Fraser.
1750
1751         <rdar://problem/8812159> Update copyright strings
1752
1753         * Info.plist:
1754
1755 2011-01-02  Dan Bernstein  <mitz@apple.com>
1756
1757         Reviewed by Sam Weinig.
1758
1759         <rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
1760         https://bugs.webkit.org/show_bug.cgi?id=51623
1761
1762         * editing/Editor.cpp:
1763         (WebCore::Editor::countMatchesForText): Actually remember the original search range end
1764         container and offset and restore them when needed, instead of using two references to the
1765         same Range.
1766         * manual-tests/find-count-matches-after-text-control.html: Added.
1767
1768 2011-01-02  Benjamin Poulain  <benjamin.poulain@nokia.com>
1769
1770         Reviewed by Csaba Osztrogonác.
1771
1772         WebKit 2 does not build on 64bits with a recent GCC
1773         https://bugs.webkit.org/show_bug.cgi?id=51754
1774
1775         Use explicitely 64 bits types for the attributes of DatabaseDetails.
1776
1777         * storage/DatabaseDetails.h:
1778         (WebCore::DatabaseDetails::expectedUsage):
1779         (WebCore::DatabaseDetails::currentUsage):
1780
1781 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1782
1783         Unreviewed WinCE build fix for r74868.
1784
1785         * platform/graphics/wince/ImageBufferWinCE.cpp:
1786         (WebCore::getImageData):
1787
1788 2011-01-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1789
1790         Unreviewed, rolling out r74847.
1791         http://trac.webkit.org/changeset/74847
1792         https://bugs.webkit.org/show_bug.cgi?id=51803
1793
1794         "Preprocessor guards should be in header files" (Requested by
1795         ap on #webkit).
1796
1797         * bindings/js/JSDOMWindowBase.cpp:
1798         * dom/Document.cpp:
1799         (WebCore::Document::recalcStyle):
1800         * html/HTMLDocument.cpp:
1801         * loader/FrameLoader.cpp:
1802         * loader/ResourceLoadNotifier.cpp:
1803         * page/Chrome.cpp:
1804         * page/Console.cpp:
1805         * page/ContextMenuController.cpp:
1806         * page/DOMWindow.cpp:
1807         (WebCore::DOMWindow::dispatchEvent):
1808         * page/EventHandler.cpp:
1809         * page/Page.cpp:
1810         * storage/Database.cpp:
1811         * workers/AbstractWorker.cpp:
1812         * workers/DefaultSharedWorkerRepository.cpp:
1813         * workers/SharedWorker.cpp:
1814         * workers/Worker.cpp:
1815         * workers/WorkerContext.cpp:
1816         * workers/WorkerMessagingProxy.cpp:
1817         * xml/XMLHttpRequest.cpp:
1818         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
1819
1820 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1821
1822         [CMake] Unreviewed build fix.
1823
1824         * CMakeLists.txt:
1825
1826 2011-01-02  Dirk Schulze  <krit@webkit.org>
1827
1828         Reviewed by Simon Fraser.
1829
1830         Clarify ImageBuffer and ImageData relationship
1831         https://bugs.webkit.org/show_bug.cgi?id=51297
1832
1833         Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
1834         since this was a layering violation, and replaced it by ByteArray.
1835
1836         No change of functionality, so no new test added.
1837
1838         * html/ImageData.cpp:
1839         (WebCore::ImageData::create):
1840         (WebCore::ImageData::ImageData):
1841         * html/ImageData.h: Added new constructor with ByteArray input.
1842         (WebCore::ImageData::width):
1843         (WebCore::ImageData::height):
1844         (WebCore::ImageData::data):
1845         * html/canvas/CanvasPixelArray.cpp:
1846         (WebCore::CanvasPixelArray::create):
1847         (WebCore::CanvasPixelArray::CanvasPixelArray):
1848         * html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas.
1849         (WebCore::CanvasPixelArray::data):
1850         (WebCore::CanvasPixelArray::length):
1851         (WebCore::CanvasPixelArray::set):
1852         (WebCore::CanvasPixelArray::get):
1853         * html/canvas/CanvasRenderingContext2D.cpp:
1854         (WebCore::CanvasRenderingContext2D::getImageData):
1855         (WebCore::CanvasRenderingContext2D::putImageData):
1856         * platform/graphics/ImageBuffer.h:
1857         * platform/graphics/cairo/ImageBufferCairo.cpp:
1858         (WebCore::getImageData):
1859         (WebCore::ImageBuffer::getUnmultipliedImageData):
1860         (WebCore::ImageBuffer::getPremultipliedImageData):
1861         (WebCore::putImageData):
1862         (WebCore::ImageBuffer::putUnmultipliedImageData):
1863         (WebCore::ImageBuffer::putPremultipliedImageData):
1864         * platform/graphics/cg/ImageBufferCG.cpp:
1865         (WebCore::getImageData):
1866         (WebCore::ImageBuffer::getUnmultipliedImageData):
1867         (WebCore::ImageBuffer::getPremultipliedImageData):
1868         (WebCore::putImageData):
1869         (WebCore::ImageBuffer::putUnmultipliedImageData):
1870         (WebCore::ImageBuffer::putPremultipliedImageData):
1871         * platform/graphics/filters/FEBlend.cpp:
1872         (WebCore::FEBlend::apply):
1873         * platform/graphics/filters/FEColorMatrix.cpp:
1874         (WebCore::FEColorMatrix::apply):
1875         * platform/graphics/filters/FEComponentTransfer.cpp:
1876         (WebCore::FEComponentTransfer::apply):
1877         * platform/graphics/filters/FEComposite.cpp:
1878         (WebCore::FEComposite::apply):
1879         * platform/graphics/filters/FEConvolveMatrix.cpp:
1880         (WebCore::setDestinationPixels):
1881         (WebCore::FEConvolveMatrix::apply):
1882         * platform/graphics/filters/FEConvolveMatrix.h:
1883         * platform/graphics/filters/FEDisplacementMap.cpp:
1884         (WebCore::FEDisplacementMap::apply):
1885         * platform/graphics/filters/FEGaussianBlur.cpp:
1886         (WebCore::FEGaussianBlur::apply):
1887         * platform/graphics/filters/FELighting.cpp:
1888         (WebCore::FELighting::apply):
1889         * platform/graphics/filters/FEMorphology.cpp:
1890         (WebCore::FEMorphology::apply):
1891         * platform/graphics/filters/FETurbulence.cpp:
1892         (WebCore::FETurbulence::apply):
1893         * platform/graphics/filters/FilterEffect.cpp:
1894         (WebCore::FilterEffect::asImageBuffer):
1895         (WebCore::FilterEffect::asUnmultipliedImage):
1896         (WebCore::FilterEffect::asPremultipliedImage):
1897         (WebCore::FilterEffect::copyImageBytes):
1898         (WebCore::FilterEffect::copyUnmultipliedImage):
1899         (WebCore::FilterEffect::copyPremultipliedImage):
1900         (WebCore::FilterEffect::createUnmultipliedImageResult):
1901         (WebCore::FilterEffect::createPremultipliedImageResult):
1902         * platform/graphics/filters/FilterEffect.h:
1903         * platform/graphics/qt/ImageBufferQt.cpp:
1904         (WebCore::getImageData):
1905         (WebCore::ImageBuffer::getUnmultipliedImageData):
1906         (WebCore::ImageBuffer::getPremultipliedImageData):
1907         (WebCore::putImageData):
1908         (WebCore::ImageBuffer::putUnmultipliedImageData):
1909         (WebCore::ImageBuffer::putPremultipliedImageData):
1910         * platform/graphics/skia/ImageBufferSkia.cpp:
1911         (WebCore::getImageData):
1912         (WebCore::ImageBuffer::getUnmultipliedImageData):
1913         (WebCore::ImageBuffer::getPremultipliedImageData):
1914         (WebCore::putImageData):
1915         (WebCore::ImageBuffer::putUnmultipliedImageData):
1916         (WebCore::ImageBuffer::putPremultipliedImageData):
1917         * platform/graphics/wince/ImageBufferWinCE.cpp:
1918         (WebCore::getImageData):
1919         (WebCore::ImageBuffer::getUnmultipliedImageData):
1920         (WebCore::ImageBuffer::getPremultipliedImageData):
1921         (WebCore::putImageData):
1922         (WebCore::ImageBuffer::putUnmultipliedImageData):
1923         (WebCore::ImageBuffer::putPremultipliedImageData):
1924         * platform/graphics/wx/ImageBufferWx.cpp:
1925         (WebCore::ImageBuffer::getUnmultipliedImageData):
1926         (WebCore::ImageBuffer::getPremultipliedImageData):
1927         (WebCore::ImageBuffer::putUnmultipliedImageData):
1928         (WebCore::ImageBuffer::putPremultipliedImageData):
1929         * rendering/RenderSVGResourceMasker.cpp:
1930         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
1931
1932 2011-01-01  Adam Barth  <abarth@webkit.org>
1933
1934         Reviewed by Eric Seidel.
1935
1936         Move JavaScriptCore to Source
1937         https://bugs.webkit.org/show_bug.cgi?id=51604
1938
1939         Update references to JavaScriptCore.
1940
1941         * Android.derived.jscbindings.mk:
1942         * Android.v8bindings.mk:
1943         * CMakeLists.txt:
1944         * WebCore.gyp/WebCore.gyp:
1945         * WebCore.pro:
1946           - These changes are subtle and might not be 100% correct.
1947         * move-js-headers.sh:
1948
1949 2011-01-01  Adam Barth  <abarth@webkit.org>
1950
1951         Reviewed by Eric Seidel.
1952
1953         forbid sandboxed frames to call top.close() when allow-same-origin is not setted
1954         https://bugs.webkit.org/show_bug.cgi?id=38340
1955
1956         We now pass the ScriptExecutionContext to window.close so it can find
1957         the Frame and check whether navigation is allowed.  This check will
1958         almost always pass because you can only close top-level frames, but the
1959         check will fail when the calling script is sandboxed.
1960
1961         Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
1962                fast/frames/sandboxed-iframe-close-top.html
1963
1964         * page/DOMWindow.cpp:
1965         (WebCore::DOMWindow::close):
1966         * page/DOMWindow.h:
1967         * page/DOMWindow.idl:
1968
1969 2011-01-01  Adam Barth  <abarth@webkit.org>
1970
1971         Reviewed by Eric Seidel.
1972
1973         sandbox iframes have access to top.history methods
1974         https://bugs.webkit.org/show_bug.cgi?id=38152
1975
1976         To enforce the sandbox restrictions on History, we need to pass the
1977         ScriptExecutionContext to WebCore.  This patch leaves the original
1978         History methods in place because they are used directly by folks who
1979         don't care about security checks.
1980
1981         Test: fast/frames/sandboxed-iframe-history-denied.html
1982
1983         * page/History.cpp:
1984         (WebCore::History::back):
1985         (WebCore::History::forward):
1986         (WebCore::History::go):
1987         * page/History.h:
1988         * page/History.idl:
1989
1990 2011-01-01  Adam Barth  <abarth@webkit.org>
1991
1992         Remove empty file.
1993
1994         * Android.mk:
1995         * CMakeLists.txt:
1996         * GNUmakefile.am:
1997         * WebCore.gypi:
1998         * WebCore.pro:
1999         * WebCore.vcproj/WebCore.vcproj:
2000         * WebCore.xcodeproj/project.pbxproj:
2001         * dom/DOMAllInOne.cpp:
2002         * dom/Entity.cpp: Removed.
2003
2004 2011-01-01  Adam Barth  <abarth@webkit.org>
2005
2006         Remove empty file.
2007
2008         * CMakeLists.txt:
2009         * GNUmakefile.am:
2010         * WebCore.pro:
2011         * WebCore.vcproj/WebCore.vcproj:
2012         * WebCore.xcodeproj/project.pbxproj:
2013         * bindings/js/JSBindingsAllInOne.cpp:
2014         * bindings/js/JSPopStateEventCustom.cpp: Removed.
2015
2016 2011-01-01  Adam Barth  <abarth@webkit.org>
2017
2018         Remove empty files.
2019
2020         * GNUmakefile.am:
2021         * WebCore.gypi:
2022         * WebCore.vcproj/WebCore.vcproj:
2023         * WebCore.xcodeproj/project.pbxproj:
2024         * bindings/generic/BindingFrame.h: Removed.
2025         * bindings/generic/BindingLocation.h: Removed.
2026
2027 2011-01-01  Konstantin Tokarev  <annulen@yandex.ru>
2028
2029         Reviewed by Darin Adler.
2030
2031         Don't include Inspector headers when Inspector is disabled
2032         https://bugs.webkit.org/show_bug.cgi?id=51789
2033
2034         * bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
2035         Inspector is enabled
2036         * dom/Document.cpp: Include Inspector headers when
2037         Inspector is enabled
2038         (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
2039         handling
2040         * html/HTMLDocument.cpp: Include Inspector headers when
2041         Inspector is enabled
2042         * loader/FrameLoader.cpp: Include Inspector headers when
2043         Inspector is enabled
2044         * loader/ResourceLoadNotifier.cpp: Include Inspector headers when
2045         Inspector is enabled
2046         * page/Chrome.cpp: Include Inspector headers when
2047         Inspector is enabled
2048         * page/Console.cpp: Include Inspector headers when
2049         Inspector is enabled
2050         * page/ContextMenuController.cpp: Include Inspector headers when
2051         Inspector is enabled
2052         * page/DOMWindow.cpp: Include Inspector headers when
2053         Inspector is enabled
2054         (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
2055         handling
2056         * page/EventHandler.cpp: Include Inspector headers when
2057         Inspector is enabled
2058         * page/Page.cpp: Include Inspector headers when
2059         Inspector is enabled
2060         * storage/Database.cpp: Include Inspector headers when
2061         Inspector is enabled
2062         * workers/AbstractWorker.cpp: Include Inspector headers when
2063         Inspector is enabled
2064         * workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
2065         Inspector is enabled
2066         * workers/SharedWorker.cpp: Include Inspector headers when
2067         Inspector is enabled
2068         * workers/Worker.cpp: Include Inspector headers when
2069         Inspector is enabled
2070         * workers/WorkerContext.cpp: Include Inspector headers when
2071         Inspector is enabled
2072         * workers/WorkerMessagingProxy.cpp: Include Inspector headers when
2073         Inspector is enabled
2074         * xml/XMLHttpRequest.cpp: Include Inspector headers when
2075         Inspector is enabled
2076         (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
2077         InspectorInstrumentationCookie handling
2078
2079 2010-12-31  Adam Barth  <abarth@webkit.org>
2080
2081         Reviewed by Darin Adler.
2082
2083         fast/loader/about-blank-hash-change.html fails on Chromium
2084         https://bugs.webkit.org/show_bug.cgi?id=51788
2085
2086         I'm unable to reproduce the failure locally, so this patch is slightly
2087         speculative.  We need to be slighly more careful how we compare the
2088         fragment identifiers for Chromium because Chromium uses a URL parser
2089         that is more agressive about canonicalization.
2090
2091         * page/Location.cpp:
2092         (WebCore::Location::setHash):
2093
2094 2010-12-31  Martin Robinson  <mrobinson@igalia.com>
2095
2096         Reviewed by Xan Lopez.
2097
2098         [GTK] Use GLib/GIO API for FileSystemGtk implementation
2099         https://bugs.webkit.org/show_bug.cgi?id=51617
2100
2101         Complete implementation of FileSystem platform code for GLib. This
2102         converts remaining API points using POSIX calls to platform-independent
2103         GLib calls and fixes other compilation errors.
2104
2105         No new tests. This code will be tested when an implementation
2106         of beginDragWithFiles is complete.
2107
2108         (WebCore::JSDirectoryEntry::getFile):
2109         (WebCore::JSDirectoryEntry::getDirectory):
2110         * platform/FileSystem.h: Added forward declarations for GLib types to
2111         avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
2112         * platform/gtk/FileSystemGtk.cpp:
2113         (WebCore::openTemporaryFile): Reimplement using only GLib calls.
2114         (WebCore::openFile): Ditto.
2115         (WebCore::closeFile): Ditto.
2116         (WebCore::seekFile): Added implementation.
2117         (WebCore::writeToFile): Reimplement using only GLib calls.
2118         (WebCore::readFromFile): Ditto.
2119
2120 2010-12-31  Darin Adler  <darin@apple.com>
2121
2122         Reviewed by Dan Bernstein.
2123
2124         Some renaming and refactoring of form element code
2125         https://bugs.webkit.org/show_bug.cgi?id=51784
2126
2127         * bindings/js/JSHTMLSelectElementCustom.cpp:
2128         (WebCore::JSHTMLSelectElement::remove): Call new overload of remove
2129         for option elements instead of putting the logic in the binding.
2130
2131         * html/HTMLButtonElement.cpp:
2132         (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
2133         (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
2134         "event" instead of "evt". Also updated for name changes.
2135         (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
2136         (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
2137         (WebCore::HTMLButtonElement::appendFormData): Ditto.
2138         * html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
2139         to match the getter function name. The name still doesn't seem great.
2140
2141         * html/HTMLFormElement.cpp:
2142         (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
2143         (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
2144         instead of m_autocomplete data member.
2145         (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
2146         instead of otherwise-unused isDemoted function.
2147         (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
2148         (WebCore::HTMLFormElement::validateInteractively): Removed code to clear
2149         m_insubmit. This is now handled by the caller, prepareForSubmission.
2150         (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
2151         name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
2152         here from validateInteractively. Removed unneeded check of m_doingsubmit
2153         boolean before setting it.
2154         (WebCore::HTMLFormElement::submit): Factored this function into two.
2155         One for JavaScript and one for non-JavaScript. Neither function needs a frame
2156         argument, because the question being asked, anyPageIsProcessingUserGesture,
2157         is a question asked of an entire page group, not a specific frame or page,
2158         so it's not important which is the active frame.
2159         (WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
2160         (WebCore::HTMLFormElement::reset): Updated for name changes.
2161         (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
2162         acceptAttr and got rid of code to set m_autocomplete.
2163         (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
2164         pointer.
2165         (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
2166         and the vector find function. Added a FIXME about the comment.
2167         (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
2168         function instead of m_autocomplete data member.
2169         (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
2170         (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
2171         (WebCore::HTMLFormElement::autoComplete): Ditto.
2172         * html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
2173         function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
2174         frame argument from the submit function and added a new submitFromJavaScript
2175         variant. Removed the unneeded isDemoted function. Changed the return type
2176         of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
2177         m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
2178         m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
2179         m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
2180
2181         * html/HTMLFormElement.idl: Use the function named submitFromJavaScript
2182         instead of using CallWith=DynamicFrame because we don't need to know
2183         what frame is calling. If we did, it's not clear that the "dynamic"
2184         frame would be the right one anyway.
2185
2186         * html/HTMLSelectElement.cpp:
2187         (WebCore::HTMLSelectElement::remove): Added an overload that takes an option
2188         element, since the JavaScript binding supports this.
2189         * html/HTMLSelectElement.h: Ditto.
2190
2191         * html/ImageInputType.cpp:
2192         (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
2193         * html/ImageInputType.h: Ditto.
2194         * html/SubmitInputType.cpp:
2195         (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
2196
2197 2010-12-31  Daniel Bates  <dbates@rim.com>
2198
2199         Reviewed by Darin Adler.
2200
2201         Pass style for <area> instead of associated <img> when querying whether
2202         the theme draws the focus ring for an <area>
2203         https://bugs.webkit.org/show_bug.cgi?id=51632
2204
2205         Fixes an issue where the style for the associated <img> of an <area>
2206         was passed when considering whether the theme should draw a focus ring
2207         for the <area>. Instead, we should pass the theme the style for the <area>.
2208
2209         It's not possible to test this at this time since there are no themes
2210         that override focus ring drawing for <area>s.
2211
2212         * rendering/RenderImage.cpp:
2213         (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
2214         such that it's called with respect to the focused <area>.
2215
2216 2010-12-31  Darin Adler  <darin@apple.com>
2217
2218         * WebCore.xcodeproj/project.pbxproj: Added back the language.
2219         Developers should be using Xcode 3.2.5 or newer.
2220
2221 2010-12-31  Adam Barth  <abarth@webkit.org>
2222
2223         Reviewed by Eric Seidel.
2224
2225         Move V8 to WebCore Location implementation
2226         https://bugs.webkit.org/show_bug.cgi?id=51768
2227
2228         * bindings/generic/BindingFrame.h:
2229         * bindings/generic/BindingLocation.h:
2230         * bindings/v8/V8Binding.h:
2231         * bindings/v8/V8DOMWindowShell.cpp:
2232         (WebCore::V8DOMWindowShell::setLocation):
2233         * bindings/v8/V8Utilities.cpp:
2234         * bindings/v8/V8Utilities.h:
2235         * bindings/v8/custom/V8LocationCustom.cpp:
2236         (WebCore::V8Location::hashAccessorSetter):
2237         (WebCore::V8Location::hostAccessorSetter):
2238         (WebCore::V8Location::hostnameAccessorSetter):
2239         (WebCore::V8Location::hrefAccessorSetter):
2240         (WebCore::V8Location::pathnameAccessorSetter):
2241         (WebCore::V8Location::portAccessorSetter):
2242         (WebCore::V8Location::protocolAccessorSetter):
2243         (WebCore::V8Location::searchAccessorSetter):
2244         (WebCore::V8Location::reloadCallback):
2245         (WebCore::V8Location::replaceCallback):
2246         (WebCore::V8Location::assignCallback):
2247
2248 2010-12-31  Yi Shen  <yi.4.shen@nokia.com>
2249
2250         Reviewed by Eric Seidel.
2251
2252         Make retrieving extraMediaControlsStyleSheet be page dependent.
2253         https://bugs.webkit.org/show_bug.cgi?id=51752
2254
2255         Use themeForPage to retrieve extraMediaControlsStyleSheet for media
2256         controls.
2257
2258         No new tests because no platform-specific theme implementation uses
2259         the passed page pointer yet.
2260
2261         * css/CSSStyleSelector.cpp:
2262         (WebCore::CSSStyleSelector::styleForElement):
2263
2264 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2265
2266         Reviewed by Pavel Feldman.
2267
2268         Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
2269
2270         https://bugs.webkit.org/show_bug.cgi?id=51709
2271
2272         * inspector/front-end/ResourcesPanel.js:
2273         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
2274
2275 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
2276
2277         Unreviewed build fix after r74800.
2278
2279         * bindings/js/JSDOMWindowCustom.cpp: Add missing header.
2280         * bindings/js/JSLocationCustom.cpp: Ditto.
2281
2282 2010-12-31  Adam Barth  <abarth@webkit.org>
2283
2284         Rubber-stamped by Eric Seidel.
2285
2286         Move HTML and XML parser benchmarks into PerformanceTests/Parser
2287         https://bugs.webkit.org/show_bug.cgi?id=51772
2288
2289         Remove the benchmarks folder now that it's empty.  Future benchmarks
2290         should go in the PerformanceTests directory.
2291
2292         * benchmarks: Removed.
2293         * benchmarks/parser: Removed.
2294         * benchmarks/parser/html-parser.html: Removed.
2295         * benchmarks/parser/resources: Removed.
2296         * benchmarks/parser/resources/html5.html: Removed.
2297         * benchmarks/parser/resources/runner.js: Removed.
2298         * benchmarks/parser/xml-parser.html: Removed.
2299
2300 2010-12-31  Patrick Gansterer  <paroga@webkit.org>
2301
2302         Reviewed by Adam Barth.
2303
2304         Add XML parser benchmark
2305         https://bugs.webkit.org/show_bug.cgi?id=51612
2306
2307         Move the JavaScript code of html parser into a separate file to share it with xml parser.
2308
2309         * benchmarks/parser/html-parser.html:
2310         * benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
2311         (runFunction):
2312         (run):
2313         (start):
2314         * benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
2315
2316 2010-12-29  Zhenyao Mo  <zmo@google.com>
2317
2318         Reviewed by Kenneth Russell.
2319
2320         Update validation of stencil mask and ref values
2321         https://bugs.webkit.org/show_bug.cgi?id=50716
2322
2323         * html/canvas/WebGLRenderingContext.cpp:
2324         (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
2325         (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
2326         (WebCore::WebGLRenderingContext::drawElements): Ditto.
2327         (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
2328         (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
2329         (WebCore::WebGLRenderingContext::stencilMask): Ditto.
2330         (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
2331         (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
2332         * html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
2333
2334 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2335
2336         Reviewed by Xan Lopez.
2337
2338         [GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
2339         https://bugs.webkit.org/show_bug.cgi?id=51755
2340
2341         Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
2342         if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
2343         step to landing support for the new GTK+ 3.x theming API.
2344
2345         No new tests. This should not change functionality.
2346
2347         * GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
2348         * platform/gtk/RenderThemeGtk.cpp:
2349         (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
2350         (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
2351         (WebCore::RenderThemeGtk::paintMediaButton): Ditto.
2352         (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
2353         * platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
2354         it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
2355         * platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
2356         that will eventually be platform-dependent.
2357         * platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
2358
2359 2010-12-30  Justin Schuh  <jschuh@chromium.org>
2360
2361         Reviewed by James Robinson.
2362
2363         Reverting r74292 because it introduced a crash with ruby text.
2364         https://bugs.webkit.org/show_bug.cgi?id=51637
2365
2366         Test: fast/css/counters/counter-ruby-text-cleared.html
2367
2368         * rendering/RenderCounter.cpp:
2369         (WebCore::findPlaceForCounter):
2370         * rendering/RenderObject.cpp:
2371         (WebCore::RenderObject::addChild):
2372         * rendering/RenderObjectChildList.cpp:
2373         (WebCore::RenderObjectChildList::appendChildNode):
2374         (WebCore::RenderObjectChildList::insertChildNode):
2375
2376 2010-12-30  Darin Adler  <darin@apple.com>
2377
2378         Reviewed by David Kilzer.
2379
2380         Remove unused JSBinding source files
2381         https://bugs.webkit.org/show_bug.cgi?id=51762
2382
2383         * bindings/js/JSBinding.h: Removed.
2384         * bindings/js/specialization: Removed.
2385         * bindings/js/specialization/JSBindingState.cpp: Removed.
2386         * bindings/js/specialization/JSBindingState.h: Removed.
2387
2388         * CMakeLists.txt: Removed references to files.
2389         * GNUmakefile.am: Ditto.
2390         * WebCore.gypi: Ditto.
2391         * WebCore.pro: Ditto.
2392         * WebCore.vcproj/WebCore.vcproj: Ditto.
2393         * bindings/js/JSBindingsAllInOne.cpp: Ditto.
2394
2395 2010-12-30  Tony Gentilcore  <tonyg@chromium.org>
2396
2397         Reviewed by Darin Adler.
2398
2399         Remove Document.h include from some headers where it isn't necessary
2400         https://bugs.webkit.org/show_bug.cgi?id=51730
2401
2402         No new tests because no new functionality.
2403
2404         * editing/EditingStyle.cpp:
2405         * editing/EditingStyle.h:
2406         * editing/SelectionController.h:
2407         * editing/visible_units.h:
2408         * html/HTMLAudioElement.h:
2409         * html/HTMLBodyElement.h:
2410         * inspector/InspectorCSSAgent.h:
2411         * inspector/InspectorDOMAgent.h:
2412         * inspector/InspectorInstrumentation.h:
2413         * xml/DOMParser.cpp:
2414         * xml/DOMParser.h:
2415         (WebCore::DOMParser::create):
2416         (WebCore::DOMParser::DOMParser):
2417
2418 2010-12-30  Benjamin C Meyer  <bmeyer@rim.com>
2419
2420         Reviewed by Darin Adler.
2421
2422         bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
2423         which is required when NOTIFICATIONS is enabled.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=51761
2426
2427         * CMakeLists.txt:
2428
2429 2010-12-30  Antti Koivisto  <antti@apple.com>
2430
2431         Not reviewed.
2432
2433         Revert accidental project file change.
2434
2435         * WebCore.xcodeproj/project.pbxproj:
2436
2437 2010-12-30  Antti Koivisto  <antti@apple.com>
2438
2439         Reviewed by Darin Adler.
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=51134
2442         Move loading related code from MemoryCache to CachedResourceLoader
2443
2444         - Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
2445         - Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
2446         - Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
2447         - Add MemoryCache::add
2448         - Refactor the decision on whether to reload, revalidate or use the existing resource to 
2449           a single function, CachedResourceLoader::determineRevalidationPolicy
2450
2451         * css/CSSImageValue.cpp:
2452         (WebCore::CSSImageValue::cachedImage):
2453             
2454             Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
2455             if ever taken (since it passes null CachedResourceLoader pointer).
2456             
2457         * loader/ImageLoader.cpp:
2458         (WebCore::ImageLoader::updateFromElement):
2459         * loader/cache/CachedImage.cpp:
2460         * loader/cache/CachedResource.cpp:
2461         (WebCore::CachedResource::CachedResource):
2462         (WebCore::CachedResource::~CachedResource):
2463         (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
2464         
2465             Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
2466         
2467         (WebCore::CachedResource::setLoadPriority):
2468         
2469             Check for Unresolved value before setting.
2470         
2471         * loader/cache/CachedResource.h:
2472         (WebCore::CachedResource::setOwningCachedResourceLoader):
2473         
2474             Rename to be bit less mysterious.
2475         
2476         * loader/cache/CachedResourceLoader.cpp:
2477         (WebCore::createResource):
2478         
2479             This was moved from MemoryCache.
2480         
2481         (WebCore::CachedResourceLoader::~CachedResourceLoader):
2482         (WebCore::CachedResourceLoader::determineRevalidationPolicy):
2483         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
2484         
2485             This was moved/merged from MemoryCache.
2486         
2487         (WebCore::CachedResourceLoader::canRequest):
2488         (WebCore::CachedResourceLoader::requestResource):
2489         
2490             This combines MemoryCache::requestResource and the existing method.
2491         
2492         (WebCore::CachedResourceLoader::revalidateResource):
2493         
2494             This was moved from MemoryCache.
2495         
2496         (WebCore::CachedResourceLoader::loadResource):
2497         
2498             New method for initiating loading.
2499         
2500         (WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
2501         
2502             Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
2503         
2504         * loader/cache/CachedResourceLoader.h:
2505         * loader/cache/MemoryCache.cpp:
2506         (WebCore::MemoryCache::add):
2507         * loader/cache/MemoryCache.h:
2508         (WebCore::MemoryCache::remove):
2509
2510 2010-12-30  Steve Block  <steveblock@google.com>
2511
2512         Reviewed by Gavin Barraclough.
2513
2514         Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
2515         https://bugs.webkit.org/show_bug.cgi?id=51740
2516
2517         This is a policy decision for Android.
2518
2519         No new tests, simply enabling existing, tested code on Android.
2520
2521         * bindings/js/JSDOMWindowBase.cpp:
2522         (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
2523
2524 2010-12-30  Yael Aharon  <yael.aharon@nokia.com>
2525
2526         Reviewed by Adam Barth.
2527
2528         REGRESSION: fast/dom/cssTarget-crash.html fails
2529         https://bugs.webkit.org/show_bug.cgi?id=20342
2530
2531         Do not reload the page when submitting a form, using "GET" method, and the
2532         form action url matches the location url, except for the fragment.
2533       
2534         Test: fast/forms/submit-change-fragment.html
2535
2536         * loader/FrameLoader.cpp:
2537         (WebCore::FrameLoader::loadURL):
2538         (WebCore::FrameLoader::loadWithDocumentLoader):
2539         (WebCore::FrameLoader::shouldScrollToAnchor):
2540         * loader/FrameLoader.h:
2541
2542 2010-12-30  Darin Adler  <darin@apple.com>
2543
2544         Reviewed by Adam Barth.
2545
2546         Move security logic out of the JavaScript binding for location into the DOM class
2547         https://bugs.webkit.org/show_bug.cgi?id=51714
2548
2549         * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
2550         and JSBinding.h. Later, we'll remove them from other project files and delete
2551         the source files.
2552
2553         * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
2554
2555         * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
2556         function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
2557         function, unused toLexicalFrame function, unused completeURL function, unused
2558         getCachedDOMStructure and cacheDOMStructure overloads, and unused
2559         getCachedDOMConstructor and cacheDOMConstruction functions.
2560         (WebCore::activeDOMWindow): Added.
2561         (WebCore::firstDOMWindow): Added.
2562         (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
2563         JSBindingState, since the latter is an unneeded abstraction.
2564         (WebCore::processingUserGesture): Changed to call ScriptController's function
2565         rather than calling through JSBindingState, which is an unneeded abstraction
2566
2567         * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
2568         activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
2569         named allowsAccessFromFrame functions, which answer the question of whether
2570         script is allowed access *to* a frame.
2571
2572         * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
2573         (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
2574         activeDOMWindow and firstDOMWindow functions.
2575         (WebCore::JSDOMWindow::open): Ditto.
2576         (WebCore::JSDOMWindow::showModalDialog): Ditto.
2577         (WebCore::JSDOMWindow::postMessage): Ditto.
2578
2579         * bindings/js/JSLocationCustom.cpp:
2580         (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
2581         to the Location::setHref function, with it doing the rest of the work. This moves
2582         work out of the DOM binding that belongs in the DOM itself. Eventually such functions
2583         could even be automatically generated by the bindings script.
2584         (WebCore::JSLocation::setProtocol): Ditto.
2585         (WebCore::JSLocation::setHost): Ditto.
2586         (WebCore::JSLocation::setHostname): Ditto.
2587         (WebCore::JSLocation::setPort): Ditto.
2588         (WebCore::JSLocation::setPathname): Ditto.
2589         (WebCore::JSLocation::setSearch): Ditto.
2590         (WebCore::JSLocation::setHash): Ditto.
2591         (WebCore::JSLocation::replace): Ditto.
2592         (WebCore::JSLocation::reload): Ditto.
2593         (WebCore::JSLocation::assign): Ditto.
2594
2595         * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
2596         * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
2597
2598         * page/DOMWindow.cpp:
2599         (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
2600         to use this function for Location::replace, which is the same as setLocation except that
2601         it locks both history and the back/forward list.
2602         * page/DOMWindow.h: Ditto.
2603
2604         * page/Location.cpp:
2605         (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
2606         logic there does not have to be repeated or even refactored.
2607         (WebCore::Location::setProtocol): Ditto.
2608         (WebCore::Location::setHost): Ditto.
2609         (WebCore::Location::setHostname): Ditto.
2610         (WebCore::Location::setPort): Ditto.
2611         (WebCore::Location::setPathname): Ditto.
2612         (WebCore::Location::setSearch): Ditto.
2613         (WebCore::Location::setHash): Ditto.
2614         (WebCore::Location::assign): Ditto.
2615         (WebCore::Location::replace): Ditto.
2616         (WebCore::Location::reload): Added. Security logic was refactored from the code in
2617         JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
2618         possibly unneeded.
2619
2620         * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
2621         (WebCore::Location::create):
2622         (WebCore::Location::frame):
2623
2624 2010-12-30  Alexander Pavlov  <apavlov@chromium.org>
2625
2626         Reviewed by Pavel Feldman.
2627
2628         Web Inspector: Pasting a style property with value should automatically split it into prop/value
2629         https://bugs.webkit.org/show_bug.cgi?id=51581
2630
2631         The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
2632         of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
2633         and the edit focus is transferred to the value field.
2634
2635         * inspector/front-end/StylesSidebarPane.js:
2636         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
2637         (WebInspector.StylePropertyTreeElement.prototype):
2638         * inspector/front-end/inspector.js:
2639         (WebInspector.completeURL): Drive-by: return full URLs as-is.
2640         (WebInspector.startEditing.cleanUpAfterEditing):
2641         (WebInspector.startEditing):
2642         (WebInspector.startEditing.pasteEventListener):
2643         (WebInspector.startEditing.keyDownEventListener):
2644
2645 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
2646
2647         Reviewed by Pavel Feldman.
2648
2649         Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
2650         https://bugs.webkit.org/show_bug.cgi?id=51745
2651
2652         * inspector/front-end/Breakpoint.js:
2653         (WebInspector.Breakpoint.prototype.set enabled):
2654
2655 2010-12-30  Pavel Podivilov  <podivilov@chromium.org>
2656
2657         Reviewed by Pavel Feldman.
2658
2659         Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
2660         https://bugs.webkit.org/show_bug.cgi?id=51748
2661
2662         * inspector/front-end/CallStackSidebarPane.js:
2663         (WebInspector.CallStackSidebarPane.prototype.update):
2664         (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
2665         (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
2666         (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
2667
2668 2010-12-30  Mikhail Naganov  <mnaganov@chromium.org>
2669
2670         Reviewed by Pavel Feldman.
2671
2672         Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
2673
2674         https://bugs.webkit.org/show_bug.cgi?id=51713
2675
2676         * WebCore.gypi:
2677         * WebCore.pro:
2678         * bindings/v8/custom/V8ConsoleCustom.cpp:
2679         (WebCore::V8Console::memoryAccessorGetter):
2680         * bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
2681         (WebCore::V8Performance::memoryAccessorGetter):
2682         * page/Console.idl:
2683         * page/Performance.idl:
2684
2685 2010-12-30  Steve Block  <steveblock@google.com>
2686
2687         Reviewed by Sam Weinig.
2688
2689         Visiting macnn.com often causes SQL spew via geolocation database
2690         https://bugs.webkit.org/show_bug.cgi?id=51557
2691
2692         If the Geolocation position cache database path has not been set, early-out
2693         rather than using an empty path and thus failing to open the database.
2694         This avoids SQL log spew.
2695
2696         Also, avoid starting the database thread until the path has been set, and
2697         shorten the thread name to avoid warnings due to exceeding 30 characters.
2698
2699         No new tests, implementation clean-up only.
2700
2701         * page/GeolocationPositionCache.cpp:
2702         (WebCore::GeolocationPositionCache::addUser):
2703         (WebCore::GeolocationPositionCache::removeUser):
2704         (WebCore::GeolocationPositionCache::setDatabasePath):
2705         (WebCore::GeolocationPositionCache::startBackgroundThread):
2706
2707 2010-12-29  Philippe Normand  <pnormand@igalia.com>
2708
2709         Reviewed by Martin Robinson.
2710
2711         [GTK] minimal build fails at link time due to missing sqlite3 symbols
2712         https://bugs.webkit.org/show_bug.cgi?id=51327
2713
2714         Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
2715
2716         No new tests, build fix only.
2717
2718         * platform/sql/SQLiteAuthorizer.cpp:
2719         * platform/sql/SQLiteDatabase.cpp:
2720         * platform/sql/SQLiteFileSystem.cpp:
2721         * platform/sql/SQLiteStatement.cpp:
2722         * platform/sql/SQLiteTransaction.cpp:
2723
2724 2010-12-30  Justin Schuh  <jschuh@chromium.org>
2725
2726         Reviewed by Dirk Schulze.
2727
2728         Prevent stringToLengthType() from skipping past end-of-string on invalid length unit. 
2729         https://bugs.webkit.org/show_bug.cgi?id=51692
2730
2731         * svg/SVGLength.cpp:
2732         (WebCore::stringToLengthType):
2733         (WebCore::SVGLength::setValueAsString):
2734
2735 2010-12-30  Abhishek Arya  <inferno@chromium.org>
2736
2737         Reviewed by Eric Seidel.
2738
2739         Create a helper function for finding descendent video elements for a node.
2740         https://bugs.webkit.org/show_bug.cgi?id=51696
2741
2742         Test: media/video-element-other-namespace-crash.html
2743
2744         * html/MediaDocument.cpp:
2745         (WebCore::descendentVideoElement): helper function.
2746         (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
2747         (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
2748
2749 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
2750
2751         Reviewed by Yury Semikhatsky.
2752
2753         Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
2754         https://bugs.webkit.org/show_bug.cgi?id=51707
2755
2756         This change brushes up storage agents + removes redundant InspectorBackend class.
2757
2758         * CMakeLists.txt:
2759         * GNUmakefile.am:
2760         * WebCore.gypi:
2761         * WebCore.pro:
2762         * WebCore.vcproj/WebCore.vcproj:
2763         * WebCore.xcodeproj/project.pbxproj:
2764         * inspector/CodeGeneratorInspector.pm:
2765         * inspector/InjectedScriptHost.cpp:
2766         (WebCore::InjectedScriptHost::databaseForId):
2767         (WebCore::InjectedScriptHost::selectDatabase):
2768         (WebCore::InjectedScriptHost::selectDOMStorage):
2769         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2770         * inspector/Inspector.idl:
2771         * inspector/InspectorBackend.cpp: Removed.
2772         * inspector/InspectorBackend.h: Removed.
2773         * inspector/InspectorController.cpp:
2774         (WebCore::InspectorController::InspectorController):
2775         (WebCore::InspectorController::~InspectorController):
2776         (WebCore::InspectorController::connectFrontend):
2777         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
2778         (WebCore::InspectorController::didUseDOMStorage):
2779         (WebCore::InspectorController::setInjectedScriptSource):
2780         (WebCore::InspectorController::dispatchOnInjectedScript):
2781         (WebCore::InspectorController::releaseWrapperObjectGroup):
2782         * inspector/InspectorController.h:
2783         * inspector/InspectorDOMStorageAgent.cpp: Added.
2784         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
2785         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
2786         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
2787         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
2788         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
2789         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2790         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
2791         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
2792         (WebCore::InspectorDOMStorageAgent::create):
2793         (WebCore::InspectorDOMStorageAgent::frontend):
2794         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
2795         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2796         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
2797         (WebCore::InspectorDatabaseAgent::executeSQL):
2798         (WebCore::InspectorDatabaseAgent::databaseForId):
2799         (WebCore::InspectorDatabaseAgent::selectDatabase):
2800         (WebCore::InspectorDatabaseAgent::clearFrontend):
2801         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
2802         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
2803         (WebCore::InspectorDatabaseAgent::create):
2804         (WebCore::InspectorDatabaseAgent::frontend):
2805         * inspector/front-end/ScriptsPanel.js:
2806         (WebInspector.ScriptsPanel.prototype.show):
2807         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
2808         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2809
2810 2010-12-29  Dirk Schulze  <krit@webkit.org>
2811
2812         Reviewed by Darin Adler.
2813
2814         Cleanup SVG code according to the webkit style rules 3
2815         https://bugs.webkit.org/show_bug.cgi?id=51490
2816
2817         Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
2818         Just one file can't be fixed for check-webkit-style.
2819         * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
2820
2821         No changes of functionality, so no new tests. 
2822
2823         * svg/SVGAllInOne.cpp:
2824         * svg/SVGImage.cpp:
2825         * svg/SVGLength.cpp:
2826         (WebCore::SVGLength::setValue):
2827         * svg/SVGPolygonElement.h:
2828         * svg/SVGPolylineElement.h:
2829         * svg/SVGPreserveAspectRatio.cpp:
2830         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
2831         (WebCore::SVGPreserveAspectRatio::transformRect):
2832         * svg/SVGSVGElement.cpp:
2833         (WebCore::SVGSVGElement::viewport):
2834         * svg/SVGSetElement.h:
2835         * svg/SVGStylable.h:
2836         (WebCore::SVGStylable::~SVGStylable):
2837         * svg/SVGStyledLocatableElement.h:
2838         (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
2839         (WebCore::SVGStyledLocatableElement::isStyledLocatable):
2840         * svg/SVGStyledTransformableElement.cpp:
2841         (WebCore::SVGStyledTransformableElement::isKnownAttribute):
2842         * svg/SVGSwitchElement.cpp:
2843         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
2844         * svg/SVGTests.cpp:
2845         (WebCore::SVGTests::parseMappedAttribute):
2846         * svg/SVGTextContentElement.cpp:
2847         (WebCore::SVGTextContentElement::isKnownAttribute):
2848         * svg/SVGTextPathElement.cpp:
2849         * svg/SVGTextPathElement.h:
2850         * svg/SVGTitleElement.h:
2851         (WebCore::SVGTitleElement::rendererIsNeeded):
2852         * svg/SVGTransformDistance.cpp:
2853         (WebCore::SVGTransformDistance::SVGTransformDistance):
2854         (WebCore::SVGTransformDistance::scaledDistance):
2855         (WebCore::SVGTransformDistance::addSVGTransforms):
2856         (WebCore::SVGTransformDistance::addSVGTransform):
2857         (WebCore::SVGTransformDistance::addToSVGTransform):
2858         (WebCore::SVGTransformDistance::isZero):
2859         * svg/SVGTransformList.cpp:
2860         * svg/SVGURIReference.cpp:
2861         (WebCore::SVGURIReference::getTarget):
2862         * svg/SVGVKernElement.h:
2863         * svg/SVGViewSpec.cpp:
2864         (WebCore::SVGViewSpec::parseViewSpec):
2865         * svg/SVGZoomAndPan.h:
2866         (WebCore::SVGZoomAndPan::SVGZoomAndPan):
2867         (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
2868         (WebCore::SVGZoomAndPan::zoomAndPan):
2869         * svg/SVGZoomEvent.h:
2870         (WebCore::SVGZoomEvent::create):
2871         * svg/animation/SMILTime.cpp:
2872         (WebCore::operator*):
2873         * svg/animation/SMILTime.h:
2874         (WebCore::SMILTime::SMILTime):
2875         (WebCore::SMILTime::unresolved):
2876         (WebCore::SMILTime::indefinite):
2877         (WebCore::SMILTime::operator=):
2878         (WebCore::SMILTime::value):
2879         (WebCore::SMILTime::isFinite):
2880         (WebCore::SMILTime::isIndefinite):
2881         (WebCore::SMILTime::isUnresolved):
2882         (WebCore::operator==):
2883         (WebCore::operator!): new operator checks for 0 or infinite values.
2884         (WebCore::operator!=):
2885         (WebCore::operator>):
2886         (WebCore::operator<):
2887         (WebCore::operator>=):
2888         (WebCore::operator<=):
2889         * svg/animation/SMILTimeContainer.h:
2890         (WebCore::SMILTimeContainer::create):
2891         (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
2892         * svg/animation/SVGSMILElement.cpp:
2893         (WebCore::ConditionEventListener::operator==):
2894         (WebCore::SVGSMILElement::repeatingDuration):
2895         (WebCore::SVGSMILElement::resolveInterval):
2896         (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
2897         * svg/animation/SVGSMILElement.h:
2898         (WebCore::SVGSMILElement::timeContainer):
2899         (WebCore::SVGSMILElement::intervalBegin):
2900         (WebCore::SVGSMILElement::intervalEnd):
2901         (WebCore::SVGSMILElement::previousIntervalBegin):
2902         (WebCore::SVGSMILElement::documentOrderIndex):
2903         (WebCore::SVGSMILElement::setDocumentOrderIndex):
2904         * svg/graphics/SVGImage.h:
2905         (WebCore::SVGImage::create):
2906         (WebCore::SVGImage::destroyDecodedData):
2907         (WebCore::SVGImage::decodedSize):
2908         (WebCore::SVGImage::frameAtIndex):
2909         * svg/graphics/filters/SVGFilterBuilder.h:
2910         (WebCore::SVGFilterBuilder::create):
2911         (WebCore::SVGFilterBuilder::lastEffect):
2912         (WebCore::SVGFilterBuilder::getEffectReferences):
2913         (WebCore::SVGFilterBuilder::addBuiltinEffects):
2914
2915 2010-12-29  Abhishek Arya  <inferno@chromium.org>
2916
2917         Reviewed by Darin Adler.
2918
2919         ASSERT(oldchild->parent() == owner) fails.
2920         https://bugs.webkit.org/show_bug.cgi?id=50480
2921
2922         In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
2923         is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
2924         assertion failure when removeChildNode executes on the child(equal to prev or next).
2925         Fix a typo in canMergeContiguousAnonymousBlocks.
2926
2927         Test: fast/multicol/span/double-merge-anonymous-block-crash.html
2928
2929         * rendering/RenderBlock.cpp:
2930         (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
2931         (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
2932
2933 2010-12-29  Justin Schuh  <jschuh@chromium.org>
2934
2935         Reviewed by Darin Adler.
2936
2937         Check SVG element type in FrameView::scrollToAnchor
2938         https://bugs.webkit.org/show_bug.cgi?id=51718
2939
2940         Test: svg/custom/scroll-to-anchor-in-symbol.svg
2941
2942         * page/FrameView.cpp:
2943         (WebCore::FrameView::scrollToAnchor):
2944
2945 2010-12-29  Anton Muhin  <antonm@chromium.org>
2946
2947         Reviewed by Eric Seidel.
2948
2949         [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
2950         https://bugs.webkit.org/show_bug.cgi?id=51704
2951
2952         * bindings/v8/V8DOMWindowShell.cpp:
2953         * bindings/v8/V8DOMWindowShell.h:
2954
2955 2010-12-29  Kenichi Ishibashi  <bashi@google.com>
2956
2957         Reviewed by Darin Adler.
2958
2959         Use a HashMap for m_continuation to save memory
2960         https://bugs.webkit.org/show_bug.cgi?id=43716
2961
2962         Saving memory consumption by applying a HashMap convention to
2963         continuation pointers of RenderInline and RenderBlock classes.
2964
2965         * rendering/RenderBlock.cpp: Removed m_continuation.
2966         (WebCore::RenderBlock::RenderBlock):
2967         (WebCore::RenderBlock::destroy):
2968         (WebCore::RenderBlock::inlineElementContinuation):
2969         (WebCore::RenderBlock::blockElementContinuation):
2970         * rendering/RenderBlock.h: Removed m_continuation.
2971         * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
2972         (WebCore::RenderBoxModelObject::destroy): Added an assertion.
2973         (WebCore::RenderBoxModelObject::continuation): Added.
2974         (WebCore::RenderBoxModelObject::setContinuation): Added.
2975         * rendering/RenderBoxModelObject.h:
2976         * rendering/RenderInline.cpp: Removed m_continuation.
2977         (WebCore::RenderInline::RenderInline):
2978         (WebCore::RenderInline::destroy):
2979         (WebCore::RenderInline::inlineElementContinuation):
2980         * rendering/RenderInline.h: Removed m_continuation.
2981
2982 2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2983
2984         Reviewed by Martin Robinson.
2985
2986         [GTK] Enable building whatever already exists of WebKit2
2987         https://bugs.webkit.org/show_bug.cgi?id=37369
2988
2989         No new functionality added or deleted. Only makefile change. Hence, no tests added.
2990
2991         * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
2992         added them to WebKit/gtk/GNUmakefile.am
2993         * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
2994         and declare WEBKIT_API directly
2995
2996 2010-12-29  Eric Seidel  <eric@webkit.org>
2997
2998         Unreviewed.
2999
3000         Simplify make-hash-tools.pl
3001         https://bugs.webkit.org/show_bug.cgi?id=49922
3002
3003         Added HashTools.h to the project file now that its not autogenerated.
3004         I also sorted the project file using sort-xcode-project-file
3005
3006         * WebCore.xcodeproj/project.pbxproj:
3007
3008 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
3009
3010         Not reviewed: revert r74755 and 74757.
3011
3012 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3013
3014         Reviewed by Sam Weinig.
3015
3016         JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
3017         https://bugs.webkit.org/show_bug.cgi?id=51722
3018
3019         Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
3020         methods the fastcall calling convention, which leads to runtime errors when they are
3021         called from C++. Also remove a bit of unnecessary code duplication.
3022
3023         No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
3024
3025         * bindings/js/JSDataViewCustom.cpp:
3026         (WebCore::getDataViewMember): Remove duplicated code.
3027         (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
3028         (WebCore::JSDataView::getUint8): Ditto.
3029         (WebCore::JSDataView::getFloat32): Ditto.
3030         (WebCore::JSDataView::getFloat64): Ditto.
3031         (WebCore::setDataViewMember): Remove duplicated code.
3032         (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
3033         (WebCore::JSDataView::setUint8): Ditto.
3034
3035 2010-12-29  Dan Bernstein  <mitz@apple.com>
3036
3037         Reviewed by Kenneth Russel.
3038
3039         A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
3040
3041         * html/HTMLCanvasElement.cpp:
3042         (WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
3043         CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
3044         attach-type style recalc.
3045         * html/HTMLCanvasElement.h:
3046         * html/canvas/CanvasRenderingContext2D.cpp:
3047         (WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
3048         r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
3049         (WebCore::CanvasRenderingContext2D::accessFont): Added a call to
3050         Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
3051         and update the font if it is invalid.
3052         * platform/graphics/Font.h:
3053         (WebCore::Font::loadingCustomFonts): Made this private.
3054
3055 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
3056
3057         Not reviewed: Qt build fix.
3058
3059         * inspector/InspectorController.cpp:
3060
3061 2010-12-29  Pavel Feldman  <pfeldman@chromium.org>
3062
3063         Reviewed by Yury Semikhatsky.
3064
3065         Web Inspector: extract Database & DOM Storage
3066         agents; remove InspectorBackend.
3067         https://bugs.webkit.org/show_bug.cgi?id=51707
3068
3069         This change brushes up storage agents + removes redundant
3070         InspectorBackend class.
3071
3072         * CMakeLists.txt:
3073         * GNUmakefile.am:
3074         * WebCore.gypi:
3075         * WebCore.pro:
3076         * WebCore.vcproj/WebCore.vcproj:
3077         * WebCore.xcodeproj/project.pbxproj:
3078         * inspector/CodeGeneratorInspector.pm:
3079         * inspector/InjectedScriptHost.cpp:
3080         (WebCore::InjectedScriptHost::databaseForId):
3081         (WebCore::InjectedScriptHost::selectDatabase):
3082         (WebCore::InjectedScriptHost::selectDOMStorage):
3083         (WebCore::InjectedScriptHost::inspectorDOMAgent):
3084         * inspector/Inspector.idl:
3085         * inspector/InspectorBackend.cpp: Removed.
3086         * inspector/InspectorBackend.h: Removed.
3087         * inspector/InspectorController.cpp:
3088         (WebCore::InspectorController::InspectorController):
3089         (WebCore::InspectorController::~InspectorController):
3090         (WebCore::InspectorController::connectFrontend):
3091         (WebCore::InspectorController::releaseFrontendLifetimeAgents):
3092         (WebCore::InspectorController::didUseDOMStorage):
3093         (WebCore::InspectorController::setInjectedScriptSource):
3094         (WebCore::InspectorController::dispatchOnInjectedScript):
3095         (WebCore::InspectorController::releaseWrapperObjectGroup):
3096         * inspector/InspectorController.h:
3097         * inspector/InspectorDOMStorageAgent.cpp: Added.
3098         (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
3099         (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
3100         (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
3101         (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
3102         (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
3103         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3104         (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
3105         * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
3106         (WebCore::InspectorDOMStorageAgent::create):
3107         (WebCore::InspectorDOMStorageAgent::frontend):
3108         * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
3109         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
3110         (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
3111         (WebCore::InspectorDatabaseAgent::executeSQL):
3112         (WebCore::InspectorDatabaseAgent::databaseForId):
3113         (WebCore::InspectorDatabaseAgent::selectDatabase):
3114         (WebCore::InspectorDatabaseAgent::clearFrontend):
3115         (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
3116         * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
3117         (WebCore::InspectorDatabaseAgent::create):
3118         (WebCore::InspectorDatabaseAgent::frontend):
3119         * inspector/InspectorFrontendClientLocal.cpp:
3120         * inspector/InspectorFrontendClientLocal.h:
3121         * inspector/front-end/ScriptsPanel.js:
3122         (WebInspector.ScriptsPanel.prototype.show):
3123
3124 2010-12-29  Tony Gentilcore  <tonyg@chromium.org>
3125
3126         Reviewed by Eric Seidel.
3127
3128         Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
3129         https://bugs.webkit.org/show_bug.cgi?id=51067
3130
3131         Typically when a script element is removed from the document, the cached script
3132         client is removed. However, during the before load event, the cached script client
3133         hasn't been created yet so it can't be removed.
3134
3135         This patch handles that case by explicitly checking if the script element was
3136         removed during the beforeload event. Also, it avoids caching the Document references
3137         over the arbitrary script execution in the before load event.
3138
3139         Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
3140               fast/dom/HTMLScriptElement/remove-in-beforeload.html
3141
3142         * dom/ScriptElement.cpp:
3143         (WebCore::ScriptElement::requestScript):
3144
3145 2010-12-29  Alexander Pavlov  <apavlov@chromium.org>
3146
3147         Reviewed by Yury Semikhatsky.
3148
3149         Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
3150         https://bugs.webkit.org/show_bug.cgi?id=51703
3151
3152         * inspector/InspectorController.cpp:
3153         (WebCore::InspectorController::drawElementTitle):
3154
3155 2010-12-29  Yael Aharon  <yael.aharon@nokia.com>
3156
3157         Reviewed by Kent Tamura.
3158
3159         [HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
3160         https://bugs.webkit.org/show_bug.cgi?id=29071
3161
3162         Use InputType::rangeUnderflow() and InputType::rangeOverflow()
3163         to determine if a control is in-range or out-of-range.
3164
3165         Tests: fast/css/pseudo-in-range-invalid-value.html
3166                fast/css/pseudo-in-range.html
3167                fast/css/pseudo-out-of-range.html
3168
3169         * css/CSSSelector.cpp:
3170         (WebCore::CSSSelector::pseudoId):
3171         (WebCore::nameToPseudoTypeMap):
3172         (WebCore::CSSSelector::extractPseudoType):
3173         * css/CSSSelector.h:
3174         * css/CSSStyleSelector.cpp:
3175         (WebCore::CSSStyleSelector::canShareStyleWithElement):
3176         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3177         * dom/Element.h:
3178         (WebCore::Element::isInRange):
3179         (WebCore::Element::isOutOfRange):
3180         * html/BaseDateAndTimeInputType.cpp:
3181         (WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
3182         * html/BaseDateAndTimeInputType.h:
3183         * html/HTMLInputElement.cpp:
3184         (WebCore::HTMLInputElement::isInRange):
3185         (WebCore::HTMLInputElement::isOutOfRange):
3186         * html/HTMLInputElement.h:
3187         * html/InputType.cpp:
3188         (WebCore::InputType::supportsRangeLimitation):
3189         * html/InputType.h:
3190         * html/NumberInputType.cpp:
3191         (WebCore::NumberInputType::supportsRangeLimitation):
3192         * html/NumberInputType.h:
3193         * html/RangeInputType.cpp:
3194         (WebCore::RangeInputType::supportsRangeLimitation):
3195         * html/RangeInputType.h:
3196
3197 2010-12-29  Abhishek Arya  <inferno@chromium.org>
3198
3199         Reviewed by Eric Seidel.
3200
3201         When cloning an anonymous block, make sure to set the childrenInline flag based
3202         on the state of the block to be cloned.
3203         https://bugs.webkit.org/show_bug.cgi?id=51489
3204
3205         Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html
3206
3207         * rendering/RenderBlock.cpp:
3208         (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
3209         (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
3210
3211 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3212
3213         Unreviewed build fix for WinCE after r73802.
3214
3215         Reapply parts from r72585:
3216         Port ContextMenuWin.cpp to WinCE
3217         https://bugs.webkit.org/show_bug.cgi?id=48408
3218
3219         * CMakeLists.txt:
3220         * platform/ContextMenu.h:
3221         * platform/win/ContextMenuWin.cpp:
3222         (WebCore::ContextMenu::getContextMenuItems):
3223         (WebCore::ContextMenu::createNativeMenuFromItems):
3224
3225 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3226
3227         Reviewed by Simon Hausmann.
3228
3229         [Qt] Fix compilation with Qt in namespace
3230         https://bugs.webkit.org/show_bug.cgi?id=51701
3231
3232         * platform/graphics/ContextShadow.h:
3233         * platform/graphics/GraphicsContext3D.h:
3234         * platform/network/NetworkingContext.h:
3235         * platform/network/qt/QtNAMThreadSafeProxy.h:
3236         * plugins/PluginView.h:
3237
3238 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
3239
3240         Reviewed by Pavel Feldman.
3241
3242         Web Inspector: A disabled style property should get enabled when edited
3243         https://bugs.webkit.org/show_bug.cgi?id=51679
3244
3245         Test: inspector/styles-disable-then-change.html
3246
3247         * inspector/front-end/CSSStyleModel.js:
3248         (WebInspector.CSSProperty.prototype.setText):
3249         (WebInspector.CSSProperty.prototype.setText.callback):
3250
3251 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3252
3253         Reviewed by Andreas Kling.
3254
3255         [CMake] Remove WebKitGenerators
3256         https://bugs.webkit.org/show_bug.cgi?id=50445
3257
3258         * CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
3259
3260 2010-12-28  Pratik Solanki  <psolanki@apple.com>
3261
3262         Reviewed by Eric Seidel.
3263
3264         https://bugs.webkit.org/show_bug.cgi?id=51522
3265         Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()
3266
3267         * page/win/FrameCGWin.cpp:
3268         (WebCore::imageFromRect):
3269         * platform/graphics/cg/GradientCG.cpp:
3270         (WebCore::Gradient::platformGradient):
3271         * platform/graphics/cg/GraphicsContext3DCG.cpp:
3272         (WebCore::GraphicsContext3D::paintToCanvas):
3273         * platform/graphics/cg/ImageCG.cpp:
3274         (WebCore::BitmapImage::checkForSolidColor):
3275         * platform/graphics/gstreamer/ImageGStreamerCG.mm:
3276         (ImageGStreamer::ImageGStreamer):
3277         * platform/graphics/win/GraphicsContextCGWin.cpp:
3278         (WebCore::CGContextWithHDC):
3279         (WebCore::GraphicsContext::releaseWindowsContext):
3280         (WebCore::GraphicsContext::drawWindowsBitmap):
3281         * platform/graphics/win/ImageCGWin.cpp:
3282         (WebCore::BitmapImage::create):
3283         (WebCore::BitmapImage::getHBITMAPOfSize):
3284         * platform/image-decoders/cg/ImageDecoderCG.cpp:
3285         (WebCore::createColorSpace):
3286         * platform/win/DragImageCGWin.cpp:
3287         (WebCore::allocImage):
3288         (WebCore::createCgContextFromBitmap):
3289         * rendering/RenderThemeMac.mm:
3290         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
3291         (WebCore::RenderThemeMac::paintSliderTrack):
3292         * rendering/RenderThemeSafari.cpp:
3293         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
3294         (WebCore::RenderThemeSafari::paintSliderTrack):
3295
3296 2010-12-28  Daniel Bates  <dbates@rim.com>
3297
3298         Reviewed by Sam Weinig.
3299
3300         Substitute // MARK: for compiler-specific #pragma mark
3301         https://bugs.webkit.org/show_bug.cgi?id=51657
3302
3303         Fix compilation warnings about "#pragma mark" on GTK+ bots by
3304         substituting  "// MARK:" for "#pragma mark", which provides
3305         analogous code-bookmarking functionality under Xcode.
3306
3307         * platform/graphics/cg/PathCG.cpp:
3308         * platform/graphics/mac/WebLayer.mm:
3309
3310 2010-12-28  Jan Erik Hanssen  <jhanssen@sencha.com>
3311
3312         Reviewed by Eric Seidel.
3313
3314         [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
3315         https://bugs.webkit.org/show_bug.cgi?id=51687
3316
3317         Use a const reference instead of a copy of QPainter::combinedTransform() 
3318         in GraphicsContext::getCTM()
3319
3320         * platform/graphics/qt/GraphicsContextQt.cpp:
3321         (WebCore::GraphicsContext::getCTM):
3322
3323 2010-12-28  Takashi Toyoshima  <toyoshim@google.com>
3324
3325         Reviewed by Eric Seidel.
3326
3327         gcc detected 'control reaches end of non-void function' with
3328         -finstrument-functions option.
3329         https://bugs.webkit.org/show_bug.cgi?id=51669
3330
3331         No new tests. These fixes are trivial.
3332
3333         * dom/Element.cpp:
3334         (WebCore::Element::childTypeAllowed):
3335         * inspector/InspectorResourceAgent.cpp:
3336         (WebCore::cachedResourceTypeString):
3337
3338 2010-12-28  Tony Gentilcore  <tonyg@chromium.org>
3339
3340         Reviewed by Eric Seidel.
3341
3342         Remove unused member of PendingScript
3343         https://bugs.webkit.org/show_bug.cgi?id=51684
3344
3345         This was used when HTMLScriptRunner::runScript created a PendingScript
3346         for inline scripts. But now it just calls executeScript() directly.
3347         External scripts always have the minimum starting line number.
3348
3349         No new tests because no changed functionality.
3350
3351         * dom/PendingScript.cpp:
3352         (WebCore::PendingScript::releaseElementAndClear):
3353         * dom/PendingScript.h:
3354         (WebCore::PendingScript::PendingScript):
3355         (WebCore::PendingScript::operator=):
3356         * html/parser/HTMLScriptRunner.cpp:
3357         (WebCore::HTMLScriptRunner::sourceFromPendingScript):
3358
3359 2010-12-20  Antonio Gomes  <agomes@rim.com>
3360
3361         Reviewed by Daniel Bates.
3362
3363         Spatial Navigation: code clean up (Part VI)
3364         https://bugs.webkit.org/show_bug.cgi?id=50666
3365
3366         No new tests needed.
3367
3368         * page/FocusController.cpp:
3369         (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
3370         isElementNode() now that we are bailing out earlier in both the
3371         FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
3372         * page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
3373         and virtualRectForAreaElementAndDirection functions.
3374         (WebCore::FocusController::findFocusCandidateInContainer):
3375         (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted callsites
3376         of canScrollInDirection(), and added an early return if !isElementNode().
3377         (WebCore::FocusController::advanceFocusDirectionally): Adjusted callsite of
3378         virtualRectForAreaElementAndDirection();
3379         * page/SpatialNavigation.cpp:
3380         (WebCore::FocusCandidate::FocusCandidate): Assert if node is not a element node;
3381         (WebCore::isScrollableNode): Renamed from isScrollableContainerNode;
3382         (WebCore::scrollInDirection): Adjusted callsite after function name change;
3383         (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
3384         a documentNode.
3385         (WebCore::canScrollInDirection): Signature changed.
3386         (WebCore::canBeScrolledIntoView): Ditto.
3387         (WebCore::virtualRectForAreaElementAndDirection): Ditto.
3388
3389 2010-12-28  Adrienne Walker  <enne@google.com>
3390
3391         Reviewed by Kenneth Russell.
3392
3393         [chromium] Fix tiled compositor assertion after GPU process recovery.
3394         https://bugs.webkit.org/show_bug.cgi?id=51682
3395
3396         After the GPU process recovers, the layer size is set to IntSize(),
3397         but IntRect::unite() has a special case for empty rects.  This
3398         behavior was causing the layer size to be too small, causing an
3399         out-of-bounds array access elsewhere.
3400
3401         No new tests.
3402
3403         * platform/graphics/chromium/LayerTilerChromium.cpp:
3404         (WebCore::LayerTilerChromium::growLayerToContain):
3405
3406 2010-12-23  Zhenyao Mo  <zmo@google.com>
3407
3408         Reviewed by Kenneth Russell.
3409
3410         Initialize to 0 for undefined values in CopyTexImage2D
3411         https://bugs.webkit.org/show_bug.cgi?id=51421
3412
3413         * html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
3414         (WebCore::WebGLFramebuffer::WebGLFramebuffer):
3415         (WebCore::WebGLFramebuffer::setAttachment):
3416         (WebCore::WebGLFramebuffer::getWidth):
3417         (WebCore::WebGLFramebuffer::getHeight):
3418         (WebCore::WebGLFramebuffer::getColorBufferFormat):
3419         * html/canvas/WebGLFramebuffer.h:
3420         * html/canvas/WebGLRenderingContext.cpp:
3421         (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
3422         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
3423         (WebCore::WebGLRenderingContext::framebufferTexture2D):
3424         (WebCore::WebGLRenderingContext::renderbufferStorage):
3425         (WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
3426         (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
3427         * html/canvas/WebGLRenderingContext.h:
3428         * html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
3429         (WebCore::WebGLTexture::getInternalFormat):
3430         (WebCore::WebGLTexture::getWidth):
3431         (WebCore::WebGLTexture::getHeight):
3432         (WebCore::WebGLTexture::mapTargetToIndex):
3433         (WebCore::WebGLTexture::getLevelInfo):
3434         * html/canvas/WebGLTexture.h:
3435         (WebCore::WebGLTexture::isTexture):
3436         * platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
3437         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
3438         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
3439         * platform/graphics/qt/GraphicsContext3DQt.cpp:
3440         (WebCore::GraphicsContext3D::getInternalFramebufferSize):
3441
3442 2010-12-23  Zhenyao Mo  <zmo@google.com>
3443
3444         Reviewed by Kenneth Russell.
3445
3446         Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
3447         https://bugs.webkit.org/show_bug.cgi?id=39855
3448
3449         * html/canvas/WebGLRenderingContext.cpp:
3450         (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
3451         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
3452         (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
3453         (WebCore::WebGLRenderingContext::scissor): Ditto.
3454         (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
3455         (WebCore::WebGLRenderingContext::texImage2D): Ditto.
3456         (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
3457         (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
3458         (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
3459         (WebCore::WebGLRenderingContext::viewport): Ditto.
3460         (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
3461         * html/canvas/WebGLRenderingContext.h:
3462         * html/canvas/WebGLRenderingContext.idl:
3463
3464 2010-12-28  Abhishek Arya  <inferno@chromium.org>
3465
3466         Reviewed by Kenneth Russell.
3467
3468         Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
3469         process of loading.
3470         https://bugs.webkit.org/show_bug.cgi?id=51681
3471
3472         Test: canvas/philip/tests/2d.text-custom-font-load-crash.html
3473
3474         * html/canvas/CanvasRenderingContext2D.cpp:
3475         (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
3476         * platform/graphics/Font.cpp:
3477         (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
3478         (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
3479         (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
3480         * platform/graphics/Font.h:
3481         (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
3482
3483 2010-12-28  Dimitri Glazkov  <dglazkov@chromium.org>
3484
3485         Reviewed by Eric Seidel.
3486
3487         Combine setShadowRoot and clearShadowRoot into a simpler API
3488         https://bugs.webkit.org/show_bug.cgi?id=50971
3489
3490         No change in behavior, and API is not used yet.
3491
3492         * dom/Element.cpp:
3493         (WebCore::Element::setShadowRoot): Combined clearing and setting of
3494             the shadowRoot, also hooked up with setting and clearing of the
3495             corresponding shadowHost values.
3496         * dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
3497             private.
3498         * dom/Node.h: Made shadow host-related functions public so that
3499             Element::setShadowRoot can access setShadowHost. It seems logical
3500             to make shadowHost public as well to keep the defs together.
3501
3502 2010-12-28  Andrey Kosyakov  <caseq@chromium.org>
3503
3504         Reviewed by Pavel Feldman.
3505
3506         Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
3507         Do not request content for resources with non-numeric identifiers.
3508         https://bugs.webkit.org/show_bug.cgi?id=49727
3509
3510         Test: http/tests/inspector/extensions-resources-redirect.html
3511
3512         * inspector/front-end/NetworkManager.js:
3513         (WebInspector.NetworkManager.prototype._appendRedirect):
3514
3515 2010-12-28  Ilya Tikhonovsky  <loislo@chromium.org>
3516
3517         Unreviewed build fix for Qt.
3518
3519         ResourceTreeModel.js was added.
3520
3521         * inspector/front-end/WebKit.qrc:
3522
3523 2010-12-28  Mikhail Naganov  <mnaganov@chromium.org>
3524
3525         Reviewed by Pavel Feldman.
3526
3527         [Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.
3528
3529         https://bugs.webkit.org/show_bug.cgi?id=51680
3530
3531         * inspector/front-end/ProfilesPanel.js:
3532         (WebInspector.ProfilesPanel.prototype._reset):
3533
3534 2010-12-28  Alexander Pavlov  <apavlov@chromium.org>
3535
3536         Reviewed by Pavel Feldman.
3537
3538         Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
3539         https://bugs.webkit.org/show_bug.cgi?id=51663
3540
3541         The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
3542         optional quotes/apostrophes and spaces are now allowed inside uri(...).
3543
3544         Test: inspector/styles-url-linkify.html
3545
3546         * inspector/front-end/StylesSidebarPane.js:
3547         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
3548         (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
3549
3550 2010-12-21  Ilya Tikhonovsky  <loislo@chromium.org>
3551
3552         Reviewed by Pavel Feldman.
3553
3554         Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.
3555
3556         Domain was changed for Resources, FileSystem etc. related methods.
3557         ResourcesManager was renamed to NetworkManager.
3558         ResourceTreeModel was extracted as separate file.
3559         FileSystem, Database, DOMStorage and ApplicationCache methods were
3560         removed from NetworkManager and added to corresponding classes.
3561
3562         https://bugs.webkit.org/show_bug.cgi?id=51334
3563
3564         * WebCore.gypi:
3565         * WebCore.vcproj/WebCore.vcproj:
3566         * inspector/CodeGeneratorInspector.pm:
3567         * inspector/Inspector.idl:
3568         * inspector/front-end/AuditRules.js:
3569         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
3570         * inspector/front-end/CSSStyleModel.js:
3571         (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
3572         (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
3573         * inspector/front-end/ConsoleView.js:
3574         (WebInspector.ConsoleView.prototype.addMessage):
3575         (WebInspector.ConsoleView.prototype.clearMessages):
3576         * inspector/front-end/DOMAgent.js:
3577         (WebInspector.ApplicationCache.updateApplicationCacheStatus):
3578         (WebInspector.ApplicationCache.updateNetworkState):
3579         * inspector/front-end/DOMStorage.js:
3580         (WebInspector.DOMStorage.addDOMStorage):
3581         (WebInspector.DOMStorage.selectDOMStorage):
3582         (WebInspector.DOMStorage.updateDOMStorage):
3583         * inspector/front-end/Database.js:
3584         (WebInspector.Database.prototype.executeSql):
3585         (WebInspector.Database.addDatabase):
3586         (WebInspector.Database.selectDatabase):
3587         (WebInspector.Database.sqlTransactionSucceeded):
3588         (WebInspector.Database.sqlTransactionFailed):
3589         * inspector/front-end/FileSystemView.js:
3590         (WebInspector.FileSystem.didGetFileSystemPath):
3591         (WebInspector.FileSystem.didGetFileSystemError):
3592         (WebInspector.FileSystem.didGetFileSystemDisabled):
3593         * inspector/front-end/NetworkItemView.js:
3594         (WebInspector.NetworkItemView):
3595         * inspector/front-end/NetworkManager.js: Added.
3596         (WebInspector.NetworkManager):
3597         (WebInspector.NetworkManager.prototype._createResource):
3598         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
3599         (WebInspector.NetworkManager.prototype.willSendRequest):
3600         (WebInspector.NetworkManager.prototype._updateResourceWithRequest):
3601         (WebInspector.NetworkManager.prototype._appendRedirect):
3602         (WebInspector.NetworkManager.prototype.markResourceAsCached):
3603         (WebInspector.NetworkManager.prototype.didReceiveResponse):
3604         (WebInspector.NetworkManager.prototype._updateResourceWithResponse):
3605         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
3606         (WebInspector.NetworkManager.prototype.didFinishLoading):
3607         (WebInspector.NetworkManager.prototype.didFailLoading):
3608         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
3609         (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
3610         (WebInspector.NetworkManager.prototype.setInitialContent):
3611         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
3612         (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
3613         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
3614         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
3615         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
3616         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
3617         (WebInspector.NetworkManager.prototype._processCachedResources):
3618         (WebInspector.NetworkManager.prototype._addFramesRecursively):
3619         (WebInspector.NetworkManager.requestContent):
3620         * inspector/front-end/NetworkPanel.js:
3621         (WebInspector.NetworkPanel.prototype.refreshResource):
3622         * inspector/front-end/Resource.js:
3623         (WebInspector.Resource.prototype._innerRequestContent):
3624         * inspector/front-end/ResourceManager.js: Removed.
3625         * inspector/front-end/ResourceTreeModel.js: Added.
3626         (WebInspector.ResourceTreeModel):
3627         (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
3628         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
3629         (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
3630         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3631         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
3632         (WebInspector.ResourceTreeModel.prototype._clearResources):
3633         (WebInspector.ResourceTreeModel.prototype.forAllResources):
3634         (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
3635         (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
3636         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
3637         (WebInspector.ResourceTreeModel.prototype.resourceForURL):
3638         (WebInspector.ResourceTreeModel.prototype.bindResourceURL):
3639         (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
3640         (WebInspector.ResourceTreeModel.createResource):
3641         * inspector/front-end/ResourceView.js:
3642         (WebInspector.ResourceView.createResourceView):
3643         (WebInspector.ResourceView.resourceViewTypeMatchesResource):
3644         (WebInspector.ResourceView.resourceViewForResource):
3645         (WebInspector.ResourceView.recreateResourceView):
3646         (WebInspector.ResourceView.existingResourceViewForResource):
3647         * inspector/front-end/ResourcesPanel.js:
3648         (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
3649         (WebInspector.ResourcesPanel.prototype.showSourceLine):
3650         (WebInspector.ResourcesPanel.prototype.showResource):
3651         (WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
3652         (WebInspector.ResourcesPanel.prototype.get searchableViews):
3653         (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
3654         (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
3655         * inspector/front-end/ScriptsPanel.js:
3656         (WebInspector.ScriptsPanel.prototype._addScript):
3657         (WebInspector.ScriptsPanel.prototype.reset):
3658         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
3659         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
3660         * inspector/front-end/WebKit.qrc:
3661         * inspector/front-end/inspector.html:
3662         * inspector/front-end/inspector.js:
3663         (WebInspector.forAllResources):
3664         (WebInspector.resourceForURL):
3665
3666 2010-12-27  Helder Correia  <helder@sencha.com>
3667
3668         Reviewed by Ariya Hidayat.
3669
3670         ContextShadow should use AffineTransform instead of TransformationMatrix
3671         https://bugs.webkit.org/show_bug.cgi?id=51661
3672
3673         ContextShadow needs the CTM to make sure shadows are not affected by
3674         transformations when drawing on a canvas. AffineTransform is sufficient
3675         in this case.
3676
3677         Existing tests: fast/canvas/canvas*shadow*html
3678
3679         * platform/graphics/ContextShadow.cpp:
3680         (WebCore::ContextShadow::mustUseContextShadow):
3681         (WebCore::ContextShadow::adjustBlurDistance):
3682         (WebCore::ContextShadow::calculateLayerBoundingRect):
3683         * platform/graphics/ContextShadow.h:
3684         * platform/graphics/cairo/ContextShadowCairo.cpp:
3685         (WebCore::ContextShadow::getTransformationMatrixFromContext):
3686         * platform/graphics/qt/ContextShadowQt.cpp:
3687         (WebCore::ContextShadow::getTransformationMatrixFromContext):
3688
3689 2010-12-27  Daniel Bates  <dbates@rim.com>
3690
3691         Reviewed by Antonio Gomes.
3692
3693         Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
3694         https://bugs.webkit.org/show_bug.cgi?id=51634
3695
3696         Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
3697         to HTMLFrameElementBase::marginWidth() and HTMLFrameElementBase::marginHeight(), respectively.
3698         This will make the names of these getters consistent with the naming convention we use for
3699         getters.
3700
3701         * html/HTMLBodyElement.cpp:
3702         (WebCore::HTMLBodyElement::insertedIntoDocument):
3703         * html/HTMLFrameElementBase.h:
3704         (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
3705         (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
3706         * loader/SubframeLoader.cpp:
3707         (WebCore::SubframeLoader::loadSubframe):
3708         * page/FrameView.cpp:
3709         (WebCore::FrameView::init):
3710         * rendering/RenderEmbeddedObject.cpp:
3711         (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
3712         to marginWidth and marginHeight, respectively. This makes the names of these variables
3713         consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
3714         * rendering/RenderFrame.cpp:
3715         (WebCore::RenderFrame::viewCleared): Ditto.
3716
3717 2010-12-27  Martin Robinson  <mrobinson@igalia.com>
3718
3719         Reviewed by Daniel Bates.
3720
3721         [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
3722         https://bugs.webkit.org/show_bug.cgi?id=51654
3723
3724         Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
3725         on some debug configurations.
3726
3727         No new tests. This is already covered by current slider tests. It isn't crashing on
3728         the bots, but it does crash locally.
3729
3730         * platform/gtk/RenderThemeGtk.cpp:
3731         (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
3732
3733 2010-12-27  Anton Muhin  <antonm@chromium.org>
3734
3735         Reviewed by David Levin.
3736
3737         [v8] Remove unused methods to protect/unprotect wrappers during garbage collection
3738         https://bugs.webkit.org/show_bug.cgi?id=51648
3739
3740         * bindings/v8/ScriptController.cpp:
3741         * bindings/v8/ScriptController.h:
3742         * bindings/v8/V8GCController.cpp:
3743         (WebCore::V8GCController::gcEpilogue):
3744         * bindings/v8/V8GCController.h:
3745
3746 2010-12-27  Yury Semikhatsky  <yurys@chromium.org>
3747
3748         Unreviewed. Removed trailing spaces from a localized
3749         string to make it the same as the one used in the code.
3750
3751         * English.lproj/localizedStrings.js:
3752
3753 2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
3754
3755         Reviewed by Eric Seidel.
3756
3757         Browser is failing 16 baseline test from Selector API Test Suite
3758         https://bugs.webkit.org/show_bug.cgi?id=42968
3759
3760         Throw an exception if there is no argument to querySelector or 
3761         querySelectorAll. This replaces the current behavior of passing the string
3762         "undefined" as the argument.
3763
3764         No new tests, just updating the existing results for 
3765         fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
3766
3767         * dom/Document.idl:
3768         * dom/DocumentFragment.idl:
3769         * dom/Element.idl:
3770
3771 2010-12-26  MORITA Hajime  <morrita@google.com>
3772
3773         Reviewed by Dan Bernstein.
3774
3775         For box-shadow, non-primary shadows should have specified radii.
3776         https://bugs.webkit.org/show_bug.cgi?id=51386
3777
3778         On paintBoxShadow(), the spread value accidentally accumulated accidentally
3779         during the loop, which should be applied individually for radius of each shadow. 
3780         This change makes the radii for rects computed for each shadow.
3781         
3782         Test: fast/box-shadow/spread-multiple-normal.html
3783
3784         * rendering/RenderBoxModelObject.cpp:
3785         (WebCore::RenderBoxModelObject::paintBoxShadow):
3786
3787 2010-12-26  Patrick Gansterer  <paroga@webkit.org>
3788
3789         Reviewed by Eric Seidel.
3790
3791         Improve output of HTML parser benchmark
3792         https://bugs.webkit.org/show_bug.cgi?id=51611
3793
3794         Calculate and show median, min and max values.
3795
3796         * benchmarks/parser/html-parser.html:
3797
3798 2010-12-26  Abhishek Arya  <inferno@chromium.org>
3799
3800         Reviewed by Simon Fraser.
3801
3802         Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer. 
3803         https://bugs.webkit.org/show_bug.cgi?id=48772
3804
3805         Test: fast/multicol/renderer-positioned-assert-crash.html
3806
3807         * rendering/RenderLayer.cpp:
3808         (WebCore::RenderLayer::paintPaginatedChildLayer):
3809         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
3810
3811 2010-12-25  Peter Rybin  <peter.rybin@gmail.com>
3812
3813         Reviewed by Adam Barth.
3814
3815         Adds currentColumn (and currentLine) to SegmentedString. Switches
3816         HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
3817         needs position for a <script> tag.
3818
3819         SegmentedString should provide column position
3820         https://bugs.webkit.org/show_bug.cgi?id=51311
3821
3822         * html/parser/HTMLDocumentParser.cpp:
3823         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
3824         (WebCore::HTMLDocumentParser::textPosition):
3825         * html/parser/HTMLInputStream.h:
3826         (WebCore::HTMLInputStream::current):
3827         (WebCore::InsertionPointRecord::InsertionPointRecord):
3828         (WebCore::InsertionPointRecord::~InsertionPointRecord):
3829         * html/parser/HTMLTreeBuilder.cpp:
3830         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
3831         (WebCore::HTMLTreeBuilder::processScriptStartTag):
3832         * html/parser/HTMLTreeBuilder.h:
3833         (WebCore::HTMLTreeBuilder::create):
3834         * platform/text/SegmentedString.cpp:
3835         (WebCore::SegmentedString::operator=):
3836         (WebCore::SegmentedString::numberOfCharactersConsumedSlow):
3837         (WebCore::SegmentedString::advanceSlowCase):
3838         (WebCore::SegmentedString::currentLine):
3839         (WebCore::SegmentedString::currentColumn):
3840         (WebCore::SegmentedString::setCurrentPosition):
3841         * platform/text/SegmentedString.h:
3842         (WebCore::SegmentedString::SegmentedString):
3843         (WebCore::SegmentedString::advancePastNewline):
3844         (WebCore::SegmentedString::advance):
3845         (WebCore::SegmentedString::numberOfCharactersConsumed):
3846
3847 2010-12-25  Andreas Kling  <kling@webkit.org>
3848
3849         Reviewed by Kenneth Rohde Christiansen.
3850
3851         GraphicsContext: Don't pass StrokeStyle (enum) as const reference
3852         https://bugs.webkit.org/show_bug.cgi?id=51608
3853
3854         * platform/graphics/GraphicsContext.cpp:
3855         (WebCore::GraphicsContext::setStrokeStyle):
3856         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3857         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3858         * platform/graphics/GraphicsContext.h:
3859         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3860         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3861         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3862         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3863         * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
3864         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3865         * platform/graphics/openvg/PainterOpenVG.cpp:
3866         (WebCore::PainterOpenVG::setStrokeStyle):
3867         * platform/graphics/openvg/PainterOpenVG.h:
3868         * platform/graphics/qt/GraphicsContextQt.cpp:
3869         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3870         * platform/graphics/skia/GraphicsContextSkia.cpp:
3871         (WebCore::GraphicsContext::setPlatformStrokeStyle):
3872
3873 2010-12-24  Dan Bernstein  <mitz@apple.com>
3874
3875         Reviewed by Alexey Proskuryakov.
3876
3877         REGRESSION (r74648): XHR layout test failures
3878         https://bugs.webkit.org/show_bug.cgi?id=51603
3879
3880         Reverted r74648.
3881
3882         * WebCore.exp.in:
3883
3884 2010-12-24  Dan Bernstein  <mitz@apple.com>
3885
3886         Try to fix the Qt build after r74648.
3887
3888         * WebCore.gypi:
3889         * WebCore.pro:
3890         * platform/network/qt/CredentialStorageQt.cpp: Added.
3891         (WebCore::CredentialStorage::getFromPersistentStorage):
3892
3893 2010-12-24  Simon Fraser  <simon.fraser@apple.com>
3894
3895         Reviewed by Dan Bernstein.
3896
3897         CSSStyleSelector cleanup
3898         https://bugs.webkit.org/show_bug.cgi?id=51597
3899
3900         Make some methods const. Add assertion to checkOneSelector, with the
3901         intention of later removing the if (!e) check (this is hot code).
3902
3903         * css/CSSStyleSelector.cpp:
3904         (WebCore::CSSStyleSelector::locateCousinList):
3905         (WebCore::CSSStyleSelector::canShareStyleWithElement):
3906         (WebCore::CSSStyleSelector::locateSharedStyle):
3907         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3908         (WebCore::CSSStyleSelector::mmLength):
3909         (WebCore::CSSStyleSelector::inchLength):
3910         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
3911         (WebCore::CSSStyleSelector::hasSelectorForAttribute):
3912         * css/CSSStyleSelector.h:
3913         (WebCore::CSSStyleSelector::fontSelector):
3914
3915 2010-12-24  Dan Bernstein  <mitz@apple.com>
3916
3917         Reviewed by Anders Carlsson.
3918
3919         <rdar://problem/8758386> The web process uses its own credential storage
3920         https://bugs.webkit.org/show_bug.cgi?id=51599
3921
3922         * WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
3923         and Credential::isEmpty().
3924
3925 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3926
3927         Reviewed by Darin Adler.
3928
3929         [V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
3930         https://bugs.webkit.org/show_bug.cgi?id=51595
3931
3932         * WebCore.gypi:
3933         * bindings/v8/V8DOMWrapper.cpp:
3934         * bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
3935         (WebCore::V8EventListener::V8EventListener):
3936         (WebCore::V8EventListener::getListenerFunction):
3937         (WebCore::V8EventListener::callListenerFunction):
3938         * bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
3939         (WebCore::V8EventListener::create):
3940         * bindings/v8/V8EventListenerList.h:
3941         * bindings/v8/V8WorkerContextEventListener.h:
3942         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3943         * bindings/v8/custom/V8LocationCustom.cpp:
3944         * bindings/v8/custom/V8NodeCustom.cpp:
3945         * bindings/v8/custom/V8NotificationCenterCustom.cpp:
3946
3947 2010-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3948
3949         Reviewed by Xan Lopez.
3950
3951         [GTK] Show current time / total in media player
3952         https://bugs.webkit.org/show_bug.cgi?id=51535
3953
3954         * css/mediaControlsGtk.css:
3955         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
3956         * platform/gtk/RenderThemeGtk.cpp:
3957         (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
3958         (WebCore::RenderThemeGtk::paintMediaCurrentTime):
3959         * platform/gtk/RenderThemeGtk.h:
3960
3961 2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3962
3963         Reviewed by Eric Seidel.
3964
3965         Clean up CSSRuleData in CSSStyleSelector.h
3966         https://bugs.webkit.org/show_bug.cgi?id=27753
3967
3968         Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
3969
3970         * css/CSSStyleSelector.cpp:
3971         (WebCore::CSSRuleData::CSSRuleData):
3972         (WebCore::CSSRuleData::~CSSRuleData):
3973         (WebCore::CSSRuleData::position):
3974         (WebCore::CSSRuleData::rule):
3975         (WebCore::CSSRuleData::selector):
3976         (WebCore::CSSRuleData::next):
3977         (WebCore::CSSRuleDataList::CSSRuleDataList):
3978         (WebCore::CSSRuleDataList::~CSSRuleDataList):
3979         (WebCore::CSSRuleDataList::first):
3980         (WebCore::CSSRuleDataList::last):
3981         (WebCore::CSSRuleDataList::append):
3982         * css/CSSStyleSelector.h:
3983
3984 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3985
3986         Unreviewed. Fix compilation on Windows.
3987
3988         * inspector/InspectorStyleSheet.cpp:
3989         (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
3990         * inspector/InspectorStyleSheet.h:
3991
3992 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
3993
3994         Reviewed by Darin Adler.
3995
3996         inspector/debugger-step-out.html crashing intermittently in the bots
3997         https://bugs.webkit.org/show_bug.cgi?id=50868
3998
3999         Use RefPtr rather instead of raw pointers when keeping references
4000         to refcounted objects.
4001
4002         * inspector/InspectorCSSAgent.cpp:
4003         (WebCore::InspectorCSSAgent::getStylesForNode2):
4004         (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
4005         * inspector/InspectorStyleSheet.cpp:
4006         (WebCore::InspectorStyle::create):
4007         (WebCore::InspectorStyle::InspectorStyle):
4008         (WebCore::InspectorStyle::buildObjectForStyle):
4009         (WebCore::InspectorStyle::setPropertyText):
4010         (WebCore::InspectorStyle::toggleProperty):
4011         (WebCore::InspectorStyle::styleText):
4012         (WebCore::InspectorStyle::populateAllProperties):
4013         (WebCore::InspectorStyle::replacePropertyInStyleText):
4014         (WebCore::InspectorStyleSheet::create):
4015         (WebCore::InspectorStyleSheet::InspectorStyleSheet):
4016         (WebCore::InspectorStyleSheetForInlineStyle::create):
4017         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
4018         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
4019         * inspector/InspectorStyleSheet.h:
4020         (WebCore::InspectorStyle::cssStyle):
4021         (WebCore::InspectorStyleSheet::pageStyleSheet):
4022
4023 2010-12-24  Justin Schuh  <jschuh@chromium.org>
4024
4025         Reviewed by Nikolas Zimmermann.
4026
4027         SVGElementInstance::m_useElement should be cleared when use element is removed from document
4028         https://bugs.webkit.org/show_bug.cgi?id=51486
4029
4030         Test: svg/custom/use-instanceRoot-with-use-removed.svg
4031
4032         * svg/SVGElementInstance.cpp:
4033         (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
4034         * svg/SVGElementInstance.h:
4035         (WebCore::SVGElementInstance::clearUseElement):
4036         * svg/SVGUseElement.cpp:
4037         (WebCore::SVGUseElement::removedFromDocument):
4038         (WebCore::ShadowTreeUpdateBlocker::if):
4039         (WebCore::SVGUseElement::detachInstance):
4040         (WebCore::SVGUseElement::detach):
4041         * svg/SVGUseElement.h:
4042
4043 2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>
4044
4045         Reviewed by Yury Semikhatsky.
4046
4047         Web Inspector: Missing Localized Strings
4048         https://bugs.webkit.org/show_bug.cgi?id=51542
4049
4050         Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
4051         "Preserve Log upon Navigation", and "Go to Line".
4052
4053         * English.lproj/localizedStrings.js:
4054
4055 2010-12-24  Alexander Pavlov  <apavlov@chromium.org>
4056
4057         Reviewed by Yury Semikhatsky.
4058
4059         Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
4060         https://bugs.webkit.org/show_bug.cgi?id=51478
4061
4062         Now the element attribute modifications (including "style") are tracked, which results in the
4063         source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
4064         on the "style" attribute modification through the Elements tree. Also, it appears that
4065         a complete "style" attribute removal destroys the inline style declaration
4066         (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).
4067
4068         Test: inspector/elements-delete-inline-style.html
4069
4070         * inspector/InspectorCSSAgent.cpp:
4071         (WebCore::InspectorCSSAgent::didModifyDOMAttr):
4072         * inspector/InspectorCSSAgent.h:
4073         * inspector/InspectorDOMAgent.cpp:
4074         (WebCore::InspectorDOMAgent::didModifyDOMAttr):
4075         * inspector/InspectorDOMAgent.h:
4076         * inspector/InspectorStyleSheet.cpp:
4077         (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
4078         (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
4079         (WebCore::InspectorStyleSheetForInlineStyle::text):
4080         (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
4081         (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
4082         * inspector/InspectorStyleSheet.h:
4083         * inspector/front-end/ElementsTreeOutline.js:
4084         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
4085
4086 2010-12-24  Noel Gordon  <noel.gordon@gmail.com>
4087
4088         Reviewed by Andreas Kling.
4089
4090         [chromium] Fix a style nit in the JPEG encoder
4091         https://bugs.webkit.org/show_bug.cgi?id=51574
4092
4093         * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
4094
4095 2010-12-23  Alexander Pavlov  <apavlov@chromium.org>
4096
4097         Reviewed by Maciej Stachowiak.
4098
4099         Web Inspector: CSS shorthand properties expand unnecessarily
4100         https://bugs.webkit.org/show_bug.cgi?id=36304
4101
4102         "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
4103         http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
4104         standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
4105         This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
4106         appropriately when adding implicit longhands, thus they were added as normal properties
4107         found in the CSS (neither implicit, nor longhands). This is now fixed.
4108
4109         * css/CSSParser.cpp:
4110         (WebCore::CSSParser::parseBorderRadius):
4111
4112 2010-12-24  Justin Schuh  <jschuh@chromium.org>
4113
4114         Reviewed by Darin Adler.
4115
4116         setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
4117         https://bugs.webkit.org/show_bug.cgi?id=51576
4118
4119         Disallowed elements may be pruned from the shadow tree, leaving a null
4120         shadowTreeElement. We should check for that before setting attributes.
4121
4122         Test: svg/custom/animate-disallowed-use-element.svg
4123
4124         * svg/SVGAnimationElement.cpp:
4125         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
4126
4127 2010-12-24  Evan Martin  <evan@chromium.org>
4128
4129         Reviewed by Darin Adler.
4130
4131         TextMetrics::width is an integer, but the member is a float
4132         https://bugs.webkit.org/show_bug.cgi?id=51566
4133
4134         Change the return type to a float.
4135
4136         No tests, fixing a compiler warning.
4137         (I was unable to produce a difference in the values exposed to pages
4138         with a float versus the previous conversion to an integer.)
4139
4140         * html/TextMetrics.h:
4141         (WebCore::TextMetrics::width):
4142
4143 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
4144
4145         Reviewed by Kenneth Rohde Christiansen.
4146
4147         [EFL] Add option to enable Touch Events.
4148         https://bugs.webkit.org/show_bug.cgi?id=49125
4149
4150         Add files for EFL to support TOUCH_EVENTS.
4151
4152         * CMakeLists.txt:
4153         * CMakeListsEfl.txt:
4154         * platform/PlatformTouchEvent.h: Add EFL related constructor.
4155         * platform/PlatformTouchPoint.h: ditto.
4156         * platform/efl/PlatformTouchEventEfl.cpp: Added.
4157         (WebCore::PlatformTouchEvent::PlatformTouchEvent):
4158         * platform/efl/PlatformTouchPointEfl.cpp: Added.
4159         (WebCore::PlatformTouchPoint::PlatformTouchPoint):
4160
4161 2010-12-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4162
4163         Reviewed by Kenneth Rohde Christiansen.
4164
4165         [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
4166         https://bugs.webkit.org/show_bug.cgi?id=51457
4167
4168         WebKit EFL can't play html5 audio because of wrong mime type checking.
4169         So, 'application/octet-stream' is changed with an empty string.
4170
4171         * platform/efl/MIMETypeRegistryEfl.cpp:
4172         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
4173         Returns an empty string instead of application/octet-stream when it can't find proper mime type.
4174
4175 2010-12-24  Justin Schuh  <jschuh@chromium.org>
4176
4177         Reviewed by Darin Adler.
4178
4179         SVGFontFaceElement::rebuildFontFace() should exit when not in document
4180         https://bugs.webkit.org/show_bug.cgi?id=51571
4181
4182         We were hitting a NULL deref crash. Since most of the callers checked
4183         inDocument() anyway, I moved it into the start of rebuildFontFace.
4184
4185         Test: svg/custom/use-invalid-font-face.svg
4186
4187         * svg/SVGFontFaceElement.cpp:
4188         (WebCore::SVGFontFaceElement::parseMappedAttribute):
4189         (WebCore::SVGFontFaceElement::rebuildFontFace):
4190         (WebCore::SVGFontFaceElement::childrenChanged):
4191
4192 2010-12-24  Justin Schuh  <jschuh@chromium.org>
4193
4194         Reviewed by Darin Adler.
4195
4196         Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
4197         https://bugs.webkit.org/show_bug.cgi?id=51564
4198
4199         This check was duplicating an ASSERT for a case fixed in r73927.
4200         Now that the bug is fixed the check is no longer necessary.
4201
4202         Removing dead code, so no new tests needed.
4203
4204         * css/CSSCanvasValue.cpp:
4205         (WebCore::CSSCanvasValue::canvasDestroyed):
4206
4207 2010-12-23  Evan Martin  <evan@chromium.org>
4208
4209         Reviewed by Darin Adler.
4210
4211         ViewportArguments.h uses an enum to intialize a bool
4212         https://bugs.webkit.org/show_bug.cgi?id=50982
4213
4214         Initialize userScalable to true, rather than -1.
4215         No tests; fixes a compiler warning.
4216
4217         * dom/ViewportArguments.h: