338fc58500bcf278af5a4f6e755145c8ba0dae8b
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-03  Mike Belshe  <mike@belshe.com>
2
3         Reviewed by Darin Fisher.
4
5         https://bugs.webkit.org/show_bug.cgi?id=24311
6         Make IDL returning DOMObject use [V8Custom]
7
8         * dom/Document.idl:
9         * html/HTMLCanvasElement.idl:
10
11 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
12
13         Reviewed by Adele Peterson
14
15         https://bugs.webkit.org/show_bug.cgi?id=24313
16         
17         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
18         HitTestResult, then it had better well return |true|. And m_innerBlock
19         could never have been set as the hit node by the superclass, because
20         the superclass knows nothing about m_innerBlock.
21         
22         Test: fast/forms/input-hit-test-border.html
23
24         * rendering/RenderTextControlSingleLine.cpp:
25         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
26
27 2009-03-02  Sam Weinig  <sam@webkit.org>
28
29         Reviewed by Mark Rowe.
30
31         Enable Geolocation (except on Tiger and Leopard).
32
33         * Configurations/WebCore.xcconfig:
34
35 2009-03-02  Ojan Vafai  <ojan@chromium.org>
36
37         Reviewed by Adele Peterson.
38
39         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
40         Null out m_highlightedNode on hideHighlight().
41         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
42
43         * inspector/InspectorController.cpp:
44         (WebCore::InspectorController::hideHighlight):
45
46 2009-03-02  Sam Weinig  <sam@webkit.org>
47
48         Reviewed by Geoffrey Garen.
49
50         Fix for <rdar://problem/6507404> Add Geolocation support.
51
52         This is not yet turned on for any Mac platform.
53
54         * WebCore.xcodeproj/project.pbxproj:
55         * page/Chrome.cpp:
56         (WebCore::Chrome::shouldAllowGeolocationForFrame):
57         * page/Chrome.h:
58         * page/ChromeClient.h:
59         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
60         * page/Geolocation.cpp:
61         (WebCore::Geolocation::Geolocation):
62         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
63         will not be alive at this point.
64         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
65         return a PERMISSION_DENIED if not.
66         (WebCore::Geolocation::watchPosition): Ditto.
67         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
68         to allow geolocation and cache the result. 
69         * page/Geolocation.h:
70         (WebCore::Geolocation::):
71         * platform/GeolocationService.cpp:
72         * platform/GeolocationService.h:
73         (WebCore::GeolocationService::~GeolocationService):
74         (WebCore::GeolocationService::stopUpdating):
75         * platform/mac/GeolocationServiceMac.h: Added.
76         (WebCore::GeolocationServiceMac::lastPosition):
77         (WebCore::GeolocationServiceMac::lastError):
78         * platform/mac/GeolocationServiceMac.mm: Added.
79         (WebCore::GeolocationService::create):
80         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
81         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
82         (WebCore::GeolocationServiceMac::startUpdating):
83         (WebCore::GeolocationServiceMac::stopUpdating):
84         (WebCore::GeolocationServiceMac::suspend):
85         (WebCore::GeolocationServiceMac::resume):
86         (WebCore::GeolocationServiceMac::positionChanged):
87         (WebCore::GeolocationServiceMac::errorOccurred):
88         (-[WebCoreCoreLocationObserver initWithCallback:]):
89         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
90         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
91
92 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
93
94         Build fixes for wxWidgets Mac trunk build.
95
96         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
97         (wxFontProperties::wxFontProperties):
98         (GetTextExtent):
99         * webcore-wx.bkl:
100
101 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
102
103         wxGTK missing header build fix.
104
105         * platform/wx/wxcode/gtk/fontprops.cpp:
106
107 2009-03-02  Dan Bernstein  <mitz@apple.com>
108
109         Reviewed by Adam Roben.
110
111         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
112           REGRESSION: Windows Build Not Selecting Proper Font
113
114         * platform/graphics/win/FontCacheWin.cpp:
115         (WebCore::createGDIFont): Added back code to verify that the created
116         HFONT has the requested face name.
117
118 2009-03-02  Timothy Hatcher  <timothy@apple.com>
119
120         Fixes a regression caused by splitting the input and output of console commands.
121
122         https://bugs.webkit.org/show_bug.cgi?id=24293
123
124         Reviewed by Kevin McCullough.
125
126         * inspector/front-end/Console.js:
127         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
128         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
129
130 2009-03-02  Timothy Hatcher  <timothy@apple.com>
131
132         Make exception messages and logged Error objects display consistently.
133
134         https://bugs.webkit.org/show_bug.cgi?id=18983
135
136         Reviewed by Adam Roben.
137
138         * English.lproj/localizedStrings.js: Remove a string for line numbers.
139         * inspector/front-end/Console.js:
140         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
141         boolean to the ConsoleCommandResult constructor and don't pass level.
142         (WebInspector.Console.prototype._formatnode): Fix a className typo.
143         (WebInspector.Console.prototype._formaterror): Add an error-message
144         classed span around the message to show in red and remove the
145         console-message-url class from the link so it doesn't float right.
146         Instead enclose the link in parentheses and use displayNameForURL
147         to shorten the URL in the link.
148         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
149         how line numbers are shown since link underlining a string with
150         parentheses looks bad.
151         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
152         instead of a level and get line and URL based on that flag.
153         * inspector/front-end/inspector.css: Tweaks to the styles.
154
155 2009-03-02  Ojan Vafai  <ojan@chromium.org>
156
157         Reviewed by Adele Peterson.
158
159         Bug 24048: extra windows button padding doesn't apply when there's no appearance
160         <https://bugs.webkit.org/show_bug.cgi?id=24048>
161
162         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
163
164         No tests added as existing tests already cover this behavior.
165
166         * rendering/RenderButton.cpp:
167         (WebCore::RenderButton::setupInnerStyle):
168         * rendering/RenderTheme.cpp:
169         * rendering/RenderTheme.h:
170         (WebCore::RenderTheme::buttonInternalPaddingLeft):
171         (WebCore::RenderTheme::buttonInternalPaddingRight):
172         (WebCore::RenderTheme::buttonInternalPaddingTop):
173         * rendering/RenderThemeChromiumGtk.cpp:
174         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
175         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
176         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
177         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
178         * rendering/RenderThemeChromiumGtk.h:
179         * rendering/RenderThemeChromiumWin.cpp:
180         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
181         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
182         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
183         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
184         * rendering/RenderThemeChromiumWin.h:
185         * rendering/RenderThemeWin.cpp:
186         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
187         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
188         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
189         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
190         * rendering/RenderThemeWin.h:
191
192 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
193
194         Build fix for Qt port.  Remove unnecessary assert.
195
196         * platform/graphics/qt/ImageBufferQt.cpp:
197         (WebCore::ImageBuffer::putImageData):
198
199 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
200
201         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
202
203         https://bugs.webkit.org/show_bug.cgi?id=24227
204         Ensure that the checkForSolidColor() optimization is correctly triggered
205         for all cases of drawPattern.  Currently, the optimization was not triggered
206         when the check had not been previously performed via a request for the
207         image's NativeImagePtr.
208
209         Implement the Qt version of the checkForSolidColor() method.  Combined with
210         the bug fix this reduces the time it takes to draw a repeating background
211         of a 1x1 image from ~50msecs to ~0msecs on my machine.
212
213         * platform/graphics/BitmapImage.cpp:
214         (WebCore::BitmapImage::BitmapImage):
215         * platform/graphics/BitmapImage.h:
216         (WebCore::BitmapImage::mayFillWithSolidColor):
217         * platform/graphics/Image.h:
218         (WebCore::Image::mayFillWithSolidColor):
219         * platform/graphics/cairo/ImageCairo.cpp:
220         (WebCore::BitmapImage::BitmapImage):
221         (WebCore::BitmapImage::checkForSolidColor):
222         * platform/graphics/cg/ImageCG.cpp:
223         (WebCore::BitmapImage::BitmapImage):
224         (WebCore::BitmapImage::checkForSolidColor):
225         * platform/graphics/qt/ImageQt.cpp:
226         (WebCore::BitmapImage::checkForSolidColor):
227         * platform/graphics/skia/ImageSkia.cpp:
228         (WebCore::BitmapImage::checkForSolidColor):
229         * platform/graphics/wx/ImageWx.cpp:
230         (WebCore::BitmapImage::checkForSolidColor):
231
232 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
233
234         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
235         they show up in the tarball.
236
237         * GNUmakefile.am:
238
239 2009-03-02  Dirk Schulze  <krit@webkit.org>
240
241         Reviewed by Holger Freyther.
242
243         Added putImageData to Qt. Discussed with Ariya Hidayat.
244
245         [Qt] lacks putImageData support in Canvas
246         https://bugs.webkit.org/show_bug.cgi?id=22186
247
248         * platform/graphics/qt/ImageBufferQt.cpp:
249         (WebCore::ImageBuffer::putImageData):
250
251 2009-03-02  Timothy Hatcher  <timothy@apple.com>
252
253         Show exception messages again when evaluating bad expressions in the
254         Web Inspector's console.
255
256         https://bugs.webkit.org/show_bug.cgi?id=19890
257
258         Reviewed by Oliver Hunt.
259
260         * bindings/js/JSQuarantinedObjectWrapper.cpp:
261         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
262         Fix the order in which the exception is set and cleared now that the
263         exception is stored in the shared GlobalData, not per ExecState.
264
265 2009-02-28  Timothy Hatcher  <timothy@apple.com>
266
267         Make input in the Web Inspector console print before any output
268         that might be added by the called function.
269
270         https://bugs.webkit.org/show_bug.cgi?id=19931
271
272         Reviewed by Oliver Hunt.
273
274         * inspector/front-end/Console.js:
275         (WebInspector.Console.prototype._enterKeyPressed): Add the command
276         message before evaluating the result. Associate the originating
277         command to the result, so if they are adjacent there is no divider.
278         (WebInspector.ConsoleCommand): No longer take a result.
279         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
280         code removed since it isn't used now.
281         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
282         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
283         Call the ConsoleMessage toMessageElement and add a style class.
284         * inspector/front-end/inspector.css: Add a new style class for
285         adjacent results to hide the divider. Also tweak the position of
286         the disclosure triangle for objects to not use the left margin.
287
288 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
289
290         Reviewed by Oliver Hunt.
291
292         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
293         <https://bugs.webkit.org/show_bug.cgi?id=24282>
294
295         When fetching an array of elements with a range, attachment views need to be returned
296         instead of the actual attachment.
297
298         * page/mac/AccessibilityObjectWrapper.mm:
299         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
300         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
301
302 2009-03-01  Ojan Vafai  <ojan@chromium.org>
303
304         Reviewed by Eric Seidel.
305
306         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
307         <https://bugs.webkit.org/show_bug.cgi?id=24251>
308         
309         Make RenderObject::positionForCoordinate non-virtual and
310         RenderObject::positionForPoint virtual in preparation for
311         removing positionFor* from RenderObject/RenderText.
312
313         * page/Frame.cpp:
314         (WebCore::Frame::visiblePositionForPoint):
315         * rendering/RenderBR.cpp:
316         (WebCore::RenderBR::positionForPoint):
317         * rendering/RenderBR.h:
318         * rendering/RenderBlock.cpp:
319         (WebCore::RenderBlock::positionForPoint):
320         * rendering/RenderBlock.h:
321         * rendering/RenderBox.cpp:
322         (WebCore::RenderBox::positionForPoint):
323         * rendering/RenderBox.h:
324         * rendering/RenderInline.cpp:
325         (WebCore::RenderInline::positionForPoint):
326         * rendering/RenderInline.h:
327         * rendering/RenderObject.cpp:
328         (WebCore::RenderObject::positionForCoordinates):
329         (WebCore::RenderObject::positionForPoint):
330         * rendering/RenderObject.h:
331         * rendering/RenderReplaced.cpp:
332         (WebCore::RenderReplaced::positionForPoint):
333         * rendering/RenderReplaced.h:
334         * rendering/RenderSVGInlineText.cpp:
335         (WebCore::RenderSVGInlineText::positionForPoint):
336         * rendering/RenderSVGInlineText.h:
337         * rendering/RenderText.cpp:
338         (WebCore::RenderText::positionForPoint):
339         * rendering/RenderText.h:
340
341 2009-03-01  Larry Ewing  <lewing@novell.com>
342
343         Reviewed by Alexey Proskuryakov.
344
345         https://bugs.webkit.org/show_bug.cgi?id=24080
346         NPN_GetValue casting to the wrong type and writing outside bounds
347
348         Make sure to cast the value to the correct type so that only
349         memory owned by the value is written to.
350
351         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
352         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
353         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
354         (PluginView::getValue):
355
356 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
357
358         Reviewed by Simon Fraser.
359
360         https://bugs.webkit.org/show_bug.cgi?id=24197 and
361         https://bugs.webkit.org/show_bug.cgi?id=23512
362
363         The Windows version of cgColor() is conditionally compiled using
364         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
365         can use the OS X version instead of the Windows version.
366
367         Also rename cgColor() -> createCGColor()
368
369         No observable change in behavior, so no test.
370
371         * platform/graphics/Color.h:
372         * platform/graphics/cg/ColorCG.cpp:
373         (WebCore::createCGColor):
374         * platform/graphics/cg/GraphicsContextCG.cpp:
375         (WebCore::GraphicsContext::setPlatformShadow):
376         * platform/graphics/mac/ColorMac.mm:
377         (WebCore::createCGColor):
378         * platform/graphics/mac/GraphicsContextMac.mm:
379         (WebCore::GraphicsContext::drawFocusRing):
380         * platform/graphics/mac/GraphicsLayerCA.mm:
381         (WebCore::setLayerBorderColor):
382         (WebCore::setLayerBackgroundColor):
383         (WebCore::GraphicsLayerCA::setBackgroundColor):
384         * platform/graphics/win/GraphicsContextCGWin.cpp:
385         (WebCore::GraphicsContext::drawFocusRing):
386         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
387         (WebCore::ciColor):
388
389 2009-03-01  David Levin  <levin@chromium.org>
390
391         Reviewed by Alexey Proskuryakov.
392
393         Bug 24271: XMLHttpRequest needs js bindings for Workers.
394         <https://bugs.webkit.org/show_bug.cgi?id=24271>
395
396         Tests: http/tests/xmlhttprequest/workers/methods-async.html
397                http/tests/xmlhttprequest/workers/methods.html
398
399         * bindings/js/JSWorkerContextBase.cpp:
400         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
401         (jsWorkerContextBaseXMLHttpRequest):
402         (setJSWorkerContextBaseXMLHttpRequest):
403         Expose XMLHttpRequest to Workers.
404
405         * bindings/js/JSWorkerContextBase.h:
406
407         * bindings/js/JSXMLHttpRequestConstructor.cpp:
408         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
409         (WebCore::constructXMLHttpRequest):
410         (WebCore::JSXMLHttpRequestConstructor::mark):
411         Removed the dependencies on Document.
412
413         * bindings/js/JSXMLHttpRequestConstructor.h:
414         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
415         * dom/EventException.idl:
416         * dom/EventListener.idl:
417         Chnage to have the NoStaticTables attribute since they are used from XHR.
418
419         * loader/WorkerThreadableLoader.cpp:
420         (WebCore::workerContextDidFinishLoading):
421         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
422         Fixed identifier to be unsigned long.
423
424         * loader/WorkerThreadableLoader.h:
425         * workers/WorkerThread.cpp:
426         (WebCore::WorkerThread::workerThread):
427         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
428
429         * xml/XMLHttpRequestUpload.cpp:
430
431         * xml/XMLHttpRequest.idl:
432         * xml/XMLHttpRequestException.idl:
433         * xml/XMLHttpRequestProgressEvent.idl:
434         * xml/XMLHttpRequestUpload.idl:
435         Chnage to have the NoStaticTables attribute since they are used from XHR.
436
437 2009-03-01  Horia Olaru  <olaru@adobe.com>
438
439         Adding manual debugger test cases for bug.
440
441         https://bugs.webkit.org/show_bug.cgi?id=21073
442
443         Reviewed by Kevin McCullough.
444
445         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
446         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
447         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
448         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
449         * manual-tests/inspector/resources/loop-statements.js: Added.
450
451 2009-03-01  Dan Bernstein  <mitz@apple.com>
452
453         Reviewed by Darin Adler.
454
455         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
456
457         Test: fast/events/scroll-during-zoom-change.html
458
459         * dom/Document.cpp:
460         (WebCore::Document::recalcStyle): Pause scheduled events during style
461         reclaculation. Changes to the zoom property result in scroll events
462         being generated during style recalc, and those events need to be
463         deferred until the render tree is consistent.
464         * page/FrameView.cpp:
465         (WebCore::FrameView::layout): Changed to account for a case in which the
466         post-layout tasks trigger a nested layout, which reactivates the
467         post-layout task timer.
468
469 2009-03-01  Ross Boucher  <rboucher@gmail.com>
470
471         Alphabetically sort scripts in the Script's panel file popup menu.
472
473         https://bugs.webkit.org/show_bug.cgi?id=23395
474
475         Reviewed by Timothy Hatcher.
476
477         * inspector/front-end/ScriptsPanel.js:
478         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
479         * inspector/front-end/utilities.js:
480         (insertionIndexForObjectInListSortedByFunction):
481         (indexOfObjectInListSortedByFunction):
482
483 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
484
485         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
486         when creating databases, localStorage or sessionStorage. Changing document.domain
487         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
488
489         https://bugs.webkit.org/show_bug.cgi?id=23844
490
491         Reviewed by Timothy Hatcher.
492
493         * inspector/InspectorController.cpp:
494         (WebCore::InspectorController::addDOMStorageScriptResource):
495         (WebCore::InspectorController::didUseDOMStorage):
496         * storage/Database.cpp:
497         (WebCore::Database::openDatabase):
498
499 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
500
501         Reviewed by Holger Freyther.
502
503         Avoid leaking errors when reporting GIO errors.
504
505         * platform/network/soup/ResourceHandleSoup.cpp:
506         (WebCore::readCallback):
507         (WebCore::openCallback):
508         (WebCore::queryInfoCallback):
509
510 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
511
512         Reviewed by Holger Freyther.
513
514         Fixes crash when the GIO backend is given the URI for a directory.
515
516         * platform/network/soup/ResourceHandleSoup.cpp:
517         (WebCore::networkErrorForFile):
518
519 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
520
521         Reviewed by Darin Fisher.
522
523         https://bugs.webkit.org/show_bug.cgi?id=24261
524         Fix V8 custom binding scrubbing error.
525
526         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
527         Test: traversal/exception-forwarding.html
528         TesT: traversal/stay-within-root.html
529
530         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
531         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
532         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
533         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
534         (WebCore::toV8): Ditto.
535
536 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
537
538         Reviewed by Darin Fisher.
539
540         https://bugs.webkit.org/show_bug.cgi?id=24261
541         Fix V8 custom binding scrubbing error.
542
543         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
544
545         * WebCore.xcodeproj/project.pbxproj:
546         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
547         (WebCore::cssPropertyName):  Remove dubious checks, left over from
548             incomplete conversion of parameter from pointer to pass-by-ref.
549         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
550         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
551
552 2009-02-28  Xan Lopez  <xan@gnome.org>
553
554         Reviewed by Holger Freyther.
555
556         https://bugs.webkit.org/show_bug.cgi?id=24263
557         [GTK] ref ResourceHandle until we are finished with it
558
559         Add a ref to the ResourceHandle in startHttp so we can keep it
560         alive untill all callbacks have been executed, and unref it when
561         soup tells us it's done with the SoupMessage (in
562         finishedCallback). Fixes a number of crashes when calling
563         didReceiveData whould crash because of the handle dying.
564
565         * platform/network/soup/ResourceHandleSoup.cpp:
566         (WebCore::finishedCallback):
567         (WebCore::ResourceHandle::startHttp):
568
569 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
570
571         Reviewed by Alexey Proskuryakov.
572
573         https://bugs.webkit.org/show_bug.cgi?id=24226
574         [SOUP] HTTP status text is never set
575
576         Set HTTP status text to SoupMessage reason_phrase.
577
578         * platform/network/soup/ResourceHandleSoup.cpp:
579         (WebCore::fillResponseFromMessage):
580
581 2009-02-28  Dan Bernstein  <mitz@apple.com>
582
583         - fix malformed project file
584
585         * WebCore.xcodeproj/project.pbxproj:
586
587 2009-02-28  Dan Bernstein  <mitz@apple.com>
588
589         Reviewed by Oliver Hunt.
590
591         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
592           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
593
594         Test: fast/layers/inline-dirty-z-order-lists.html
595
596         * rendering/RenderBox.cpp:
597         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
598         layer's and its stacking context's z-order lists when the layer's
599         z-index or visibility change from here...
600         * rendering/RenderBoxModelObject.cpp:
601         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
602         it will apply to RenderInline too.
603
604 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
605
606         Reviewed by David Hyatt.
607
608         Don't include TextResourceDecoder.h in Document.h
609
610         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
611         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
612
613         * dom/Document.cpp:
614         (WebCore::Document::displayStringModifiedByEncoding):
615         (WebCore::Document::displayBufferModifiedByEncoding):
616         * dom/Document.h:
617         * WebCore.base.exp:
618
619 2009-02-27  Matt Pennig  <pennig@apple.com>
620
621         Reviewed by David Hyatt.
622
623         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
624         "Fixed elements have 0 as an offsetLeft property"
625         
626         Code also brings offsetLeft/Top in full conformance with the spec.
627         Added two tests, one for fixed-position elements, and one for <html>.
628         
629         Tests: fast/dom/Element/fixed-position-offset-parent.html
630                fast/dom/Element/offsetLeft-offsetTop-html.html
631
632         * rendering/RenderBoxModelObject.cpp:
633         (WebCore::RenderBoxModelObject::offsetLeft):
634         (WebCore::RenderBoxModelObject::offsetTop):
635
636 2009-02-27  Dean Jackson  <dino@apple.com>
637
638         Reviewed by Simon Fraser.
639
640         renderer()->hasTransform() returns true for elements
641         with perspective, but no transform, so test for transform
642         when hit testing. This fixes ASSERT from
643         https://bugs.webkit.org/show_bug.cgi?id=24252
644
645         Test: transforms/no_transform_hit_testing.html
646
647         * rendering/RenderLayer.cpp:
648         (WebCore::RenderLayer::hitTestLayer):
649
650 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
651
652         Reviewed by Darin Fisher.
653
654         Fix scrubbing error -- a reversed condition.
655
656         * bindings/v8/ScriptValue.h:
657         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
658
659 2009-02-27  Jian Li  <jianli@chromium.org>
660
661         Reviewed by Alexey Proskuryakov.
662
663         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
664         https://bugs.webkit.org/show_bug.cgi?id=24152
665
666         * workers/WorkerMessagingProxy.cpp:
667         (WebCore::MessageWorkerContextTask::performTask):
668         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
669         * workers/WorkerMessagingProxy.h:
670         * workers/WorkerObjectProxy.h:
671
672 2009-02-27  Anders Carlsson  <andersca@apple.com>
673
674         Reviewed by David Hyatt.
675
676         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
677         because it leads to assertion failures in the Mac port.
678         
679         * platform/graphics/BitmapImage.cpp:
680         (WebCore::BitmapImage::BitmapImage):
681         * platform/graphics/BitmapImage.h:
682         (WebCore::BitmapImage::mayFillWithSolidColor):
683         * platform/graphics/Image.h:
684         (WebCore::Image::mayFillWithSolidColor):
685         * platform/graphics/cairo/ImageCairo.cpp:
686         (WebCore::BitmapImage::BitmapImage):
687         * platform/graphics/cg/ImageCG.cpp:
688         (WebCore::BitmapImage::BitmapImage):
689         (WebCore::BitmapImage::checkForSolidColor):
690         * platform/graphics/qt/ImageQt.cpp:
691         (WebCore::BitmapImage::checkForSolidColor):
692         * platform/graphics/skia/ImageSkia.cpp:
693         (WebCore::BitmapImage::checkForSolidColor):
694         * platform/graphics/wx/ImageWx.cpp:
695         (WebCore::BitmapImage::checkForSolidColor):
696
697 2009-02-27  Adam Barth  <abarth@webkit.org>
698
699         Reviewed by Eric Seidel.
700
701         https://bugs.webkit.org/show_bug.cgi?id=20249
702
703         Add a preference to allow universal access from local URLs to mitigate
704         some attacks.  Some clients still want to allow this access, so we
705         expose this as a preference.
706
707         * WebCore.base.exp:
708         * dom/Document.cpp:
709         (WebCore::Document::initSecurityContext):
710         * page/SecurityOrigin.cpp:
711         (WebCore::SecurityOrigin::SecurityOrigin):
712         * page/Settings.cpp:
713         (WebCore::Settings::Settings):
714         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
715         * page/Settings.h:
716         (WebCore::Settings::allowUniversalAccessFromFileUrls):
717
718 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
719
720         Reviewed by Eric Seidel.
721
722         https://bugs.webkit.org/show_bug.cgi?id=24229
723         If an image has no alpha channel there is no reason to use SourceOver.
724
725         * platform/graphics/qt/ImageQt.cpp:
726         (WebCore::Image::drawPattern):
727         (WebCore::BitmapImage::draw):
728
729 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
730
731         Reviewed by Eric Seidel and Simon Fraser.
732
733         https://bugs.webkit.org/show_bug.cgi?id=24227
734         Ensure that the checkForSolidColor() optimization is correctly triggered
735         for all cases of drawPattern.  Currently, the optimization was not triggered
736         when the check had not been previously performed via a request for the
737         image's NativeImagePtr.
738
739         Implement the Qt version of the checkForSolidColor() method.  Combined with
740         the bug fix this reduces the time it takes to draw a repeating background
741         of a 1x1 image from ~50msecs to ~0msecs on my machine.
742
743         * platform/graphics/BitmapImage.cpp:
744         (WebCore::BitmapImage::BitmapImage):
745         * platform/graphics/BitmapImage.h:
746         (WebCore::BitmapImage::mayFillWithSolidColor):
747         * platform/graphics/Image.h:
748         (WebCore::Image::mayFillWithSolidColor):
749         * platform/graphics/cairo/ImageCairo.cpp:
750         (WebCore::BitmapImage::BitmapImage):
751         * platform/graphics/cg/ImageCG.cpp:
752         (WebCore::BitmapImage::BitmapImage):
753         (WebCore::BitmapImage::checkForSolidColor):
754         * platform/graphics/qt/ImageQt.cpp:
755         (WebCore::BitmapImage::checkForSolidColor):
756         * platform/graphics/skia/ImageSkia.cpp:
757         (WebCore::BitmapImage::checkForSolidColor):
758         * platform/graphics/wx/ImageWx.cpp:
759         (WebCore::BitmapImage::checkForSolidColor):
760
761 2009-02-27  Dirk Schulze  <krit@webkit.org>
762
763         Reviewed by Zack Rusin.
764
765         Added support for gradients and pattern on Fonts for Qt.
766
767         [Qt] gradients and patterns for FontQt
768         https://bugs.webkit.org/show_bug.cgi?id=24243
769
770         * platform/graphics/qt/FontQt.cpp:
771         (WebCore::Font::drawComplexText):
772
773 2009-02-27  Jian Li  <jianli@chromium.org>
774
775         Reviewed by Alexey Proskuryakov.
776
777         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
778         https://bugs.webkit.org/show_bug.cgi?id=24113
779
780         * workers/WorkerMessagingProxy.cpp:
781
782 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
783
784         Added a refresh button to storage views.
785
786         https://bugs.webkit.org/show_bug.cgi?id=24040
787
788         Reviewed by Timothy Hatcher.
789
790         * inspector/front-end/DOMStorageItemsView.js:
791         (WebInspector.DOMStorageItemsView):
792         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
793         (WebInspector.DOMStorageItemsView.prototype.update):
794         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
795         * inspector/front-end/DatabaseTableView.js:
796         (WebInspector.DatabaseTableView):
797         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
798         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
799         * inspector/front-end/DatabasesPanel.js:
800         (WebInspector.DatabasesPanel):
801         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
802         (WebInspector.DatabasesPanel.prototype.reset):
803         (WebInspector.DatabasesPanel.prototype.showDatabase):
804         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
805         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
806         * inspector/front-end/inspector.css:
807
808 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
809
810         Added support for editing/deleting localStorage and sessionStorage items
811         directly from Web Inspector.
812
813         https://bugs.webkit.org/show_bug.cgi?id=23866.
814
815         Reviewed by Timothy Hatcher.
816
817         * WebCore.vcproj/WebCore.vcproj:
818         * inspector/front-end/DOMStorageDataGrid.js: Added.
819         (WebInspector.DOMStorageDataGrid):
820         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
821         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
822         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
823         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
824         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
825         * inspector/front-end/DOMStorageItemsView.js:
826         (WebInspector.DOMStorageItemsView):
827         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
828         (WebInspector.DOMStorageItemsView.prototype.hide):
829         (WebInspector.DOMStorageItemsView.prototype.update):
830         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
831         * inspector/front-end/DatabasesPanel.js:
832         (WebInspector.DatabasesPanel):
833         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
834         (WebInspector.DatabasesPanel.prototype.reset):
835         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
836         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
837         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
838         * inspector/front-end/WebKit.qrc:
839         * inspector/front-end/inspector.css:
840         * inspector/front-end/inspector.html:
841
842 2009-02-26  Brett Wilson  <brettw@chromium.org>
843
844         Fix Windows transparency for the Chromium port. Implement a helper
845         class for handling transparency on Windows. It allows semitransparent
846         ClearType and semitransparent form controls by making new layers in the
847         background.
848
849         It also replaces the "ThemeHelper" which allows better
850         scaling and transforms on Windows form controls. In addition to the
851         functionality that the ThemeHelper did, but additionally handles the
852         antialiasing properly so that the form controls aren't composited on a
853         white square.
854
855         https://bugs.webkit.org/show_bug.cgi?id=24101
856
857         Reviewed by Eric Seidel.
858
859         * platform/graphics/chromium/FontChromiumWin.cpp:
860         (WebCore::):
861         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
862         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
863         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
864         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
865         (WebCore::Font::drawGlyphs):
866         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
867         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
868         * platform/graphics/chromium/TransparencyWin.cpp: Added.
869         (WebCore::):
870         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
871         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
872         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
873         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
874         (WebCore::TransparencyWin::TransparencyWin):
875         (WebCore::TransparencyWin::~TransparencyWin):
876         (WebCore::TransparencyWin::init):
877         (WebCore::TransparencyWin::computeLayerSize):
878         (WebCore::TransparencyWin::setupLayer):
879         (WebCore::TransparencyWin::setupLayerForNoLayer):
880         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
881         (WebCore::TransparencyWin::setupLayerForTextComposite):
882         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
883         (WebCore::TransparencyWin::setupTransform):
884         (WebCore::TransparencyWin::setupTransformForKeepTransform):
885         (WebCore::TransparencyWin::setupTransformForUntransform):
886         (WebCore::TransparencyWin::setupTransformForScaleTransform):
887         (WebCore::TransparencyWin::setTextCompositeColor):
888         (WebCore::TransparencyWin::initializeNewContext):
889         (WebCore::TransparencyWin::compositeOpaqueComposite):
890         (WebCore::TransparencyWin::compositeTextComposite):
891         (WebCore::TransparencyWin::makeLayerOpaque):
892         * platform/graphics/chromium/TransparencyWin.h: Added.
893         (WebCore::TransparencyWin::):
894         (WebCore::TransparencyWin::context):
895         (WebCore::TransparencyWin::platformContext):
896         (WebCore::TransparencyWin::drawRect):
897         * platform/graphics/skia/GraphicsContextSkia.cpp:
898         (WebCore::GraphicsContext::endTransparencyLayer):
899         * platform/graphics/skia/ImageSkia.cpp:
900         (WebCore::paintSkBitmap):
901         * rendering/RenderThemeChromiumWin.cpp:
902         (WebCore::):
903         (WebCore::RenderThemeChromiumWin::paintButton):
904         (WebCore::RenderThemeChromiumWin::paintMenuList):
905         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
906
907 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
908
909         Reviewed by Eric Seidel.
910
911         https://bugs.webkit.org/show_bug.cgi?id=24211
912         Add ScheduledAction for V8.
913
914         * bindings/v8/ScheduledAction.cpp: Added.
915         (WebCore::ScheduledAction::ScheduledAction):
916         (WebCore::ScheduledAction::~ScheduledAction):
917         (WebCore::ScheduledAction::execute):
918         * bindings/v8/ScheduledAction.h: Added.
919         (WebCore::ScheduledAction::ScheduledAction):
920
921 2009-02-27  Zack Rusin  <zack@kde.org>
922
923         Reviewed by Nikolas Zimmermann.
924
925         Qt: be more reasonable about scrolled lines
926
927         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
928         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
929         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
930         single step scroll
931
932         * platform/qt/WheelEventQt.cpp:
933
934 2009-02-27  Xan Lopez  <xan@gnome.org>
935
936         Rubber-stamped by Alexey Proskuryakov.
937
938         https://bugs.webkit.org/show_bug.cgi?id=24222
939         [GTK] Remove checks for old glib versions
940
941         libsoup, which is a hard dependency, needs at least glib 2.15.3,
942         so remove all glib checks for versions older than that.
943
944         * platform/gtk/ContextMenuGtk.cpp:
945         (WebCore::ContextMenu::ContextMenu):
946         * platform/gtk/ContextMenuItemGtk.cpp:
947         (WebCore::ContextMenuItem::setSubMenu):
948         * platform/gtk/PopupMenuGtk.cpp:
949         (WebCore::PopupMenu::show):
950         * platform/gtk/WidgetGtk.cpp:
951         (WebCore::Widget::retainPlatformWidget):
952         * platform/network/soup/ResourceHandleSoup.cpp:
953
954 2009-02-26  Dirk Schulze  <krit@webkit.org>
955
956         Reviewed by Oliver Hunt.
957
958         Added support for Gradients and Patterns on filled or stroked Fonts
959         in Cairo. I also added support for globalAlpha on FontCairo.
960
961         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
962         https://bugs.webkit.org/show_bug.cgi?id=18617
963
964         * html/CanvasRenderingContext2D.cpp:
965         (WebCore::CanvasRenderingContext2D::drawTextInternal):
966         * platform/graphics/cairo/FontCairo.cpp:
967         (WebCore::Font::drawGlyphs):
968
969 2009-02-26  Stephen White  <senorblanco@chromium.org>
970
971         Reviewed by Eric Seidel.
972
973         https://bugs.webkit.org/show_bug.cgi?id=23957
974
975         Fix for SVG gradient and pattern text for Chromium/skia. 
976         Added accessors for the fill and stroke gradients to
977         GraphicsContext.  Changed the paintSkiaText function to take a
978         GraphicsContext, so we can check for gradients/patterns. 
979         Changed the skiaDrawText function to set the SkPaint shader
980         correctly, and to scale up the gradient shader matrix to
981         encompass the entire text string.  Also offset each glyph
982         separately, rather than transforming the canvas, so that the
983         gradient/pattern stays fixed relative to the text origin.
984
985         * platform/graphics/GraphicsContext.cpp:
986         (WebCore::GraphicsContext::getFillGradient):
987         (WebCore::GraphicsContext::getStrokeGradient):
988         (WebCore::GraphicsContext::getFillPattern):
989         (WebCore::GraphicsContext::getStrokePattern):
990         * platform/graphics/GraphicsContext.h:
991         * platform/graphics/chromium/FontChromiumWin.cpp:
992         (WebCore::Font::drawGlyphs):
993         * platform/graphics/chromium/UniscribeHelper.cpp:
994         (WebCore::UniscribeHelper::draw):
995         * platform/graphics/skia/SkiaFontWin.cpp:
996         (WebCore::windowsCanHandleTextDrawing):
997         (WebCore::skiaDrawText):
998         (WebCore::paintSkiaText):
999         * platform/graphics/skia/SkiaFontWin.h:
1000
1001 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1002
1003         Reviewed by Eric Seidel.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=24208
1006         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1007
1008         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1009         (WebCore::ACCESSOR_GETTER):
1010         (WebCore::CALLBACK_FUNC_DECL):
1011         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1012         (WebCore::CALLBACK_FUNC_DECL):
1013         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1014         (WebCore::ACCESSOR_GETTER):
1015         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1016         (WebCore::CALLBACK_FUNC_DECL):
1017
1018 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1019
1020         Unreviewed build fix for building with GNOME Keyring enabled.
1021
1022         * platform/network/soup/webkit-soup-auth-dialog.c:
1023         (show_auth_dialog):
1024
1025 2009-02-26  Xan Lopez  <xan@gnome.org>
1026
1027         Reviewed by Holger Freyther.
1028
1029         https://bugs.webkit.org/show_bug.cgi?id=16947
1030         [GTK] Missing HTTP Auth challenge
1031
1032         Add HTTP authentication dialog with optional GNOME Keyring
1033         storage.
1034
1035         * GNUmakefile.am:
1036         * platform/network/ResourceHandleInternal.h:
1037         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1038         * platform/network/soup/ResourceHandleSoup.cpp:
1039         (WebCore::currentToplevelCallback):
1040         (WebCore::ResourceHandle::startHttp):
1041         (WebCore::ResourceHandle::start):
1042         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1043         (webkit_soup_auth_dialog_class_init):
1044         (webkit_soup_auth_dialog_init):
1045         (webkit_soup_auth_dialog_session_feature_init):
1046         (free_authData):
1047         (set_password_callback):
1048         (response_callback):
1049         (show_auth_dialog):
1050         (find_password_callback):
1051         (session_authenticate):
1052         (attach):
1053         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1054
1055 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1056
1057         Reviewed by Dave Hyatt.
1058
1059         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1060         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1061         started failing because Ojan's new code was now *correctly* calling through to
1062         SVG asking for the closest text offset in the last line box, instead of
1063         just returning the offset at the end of the last line box when clicking below a box.
1064
1065         But!  The SVG code was wrong, in that it returned the character offset of the last
1066         character when you asked for a character offset after the end of the box, instead
1067         it should return the offset *after* the last character.  This patch fixes
1068         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1069
1070         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1071         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1072         what it is doing (which also makes more obvious what's wrong with it).
1073
1074         * rendering/RenderSVGInlineText.cpp:
1075         (WebCore::RenderSVGInlineText::positionForCoordinates):
1076         * rendering/SVGInlineTextBox.cpp:
1077         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1078         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1079         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1080         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1081         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1082
1083 2009-02-26  Darin Fisher  <darin@chromium.org>
1084
1085         Reviewed by Eric Seidel.
1086
1087         Minor cleanup of ChromiumBridge:
1088         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1089
1090         * platform/chromium/ChromiumBridge.h:
1091         * platform/chromium/MimeTypeRegistryChromium.cpp:
1092         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1093         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1094         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1095
1096 2009-02-26  David Hyatt  <hyatt@apple.com>
1097
1098         Reviewed by Sam Weinig
1099
1100         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1101         the line-height below the descent.
1102
1103         Added fast/inline/vertical-align-text-bottom.html
1104
1105         * rendering/RenderBoxModelObject.cpp:
1106         (WebCore::RenderBoxModelObject::verticalPosition):
1107
1108 2009-02-26  Dirk Schulze  <krit@webkit.org>
1109
1110         Reviewed by Eric Seidel.
1111
1112         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1113         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1114         just to implement this three methods to support SVG Masking now.
1115  
1116         Make SVG Masking platform aware
1117         https://bugs.webkit.org/show_bug.cgi?id=19243
1118
1119         * GNUmakefile.am:
1120         * WebCore.pro:
1121         * WebCore.vcproj/WebCore.vcproj:
1122         * WebCore.xcodeproj/project.pbxproj:
1123         * svg/graphics/SVGResourceMasker.cpp:
1124         (WebCore::SVGResourceMasker::applyMask):
1125         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1126         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1127         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1128         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1129         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1130
1131 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1132
1133         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1134
1135         Test: http/tests/misc/slow-preload-cancel.html
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=24133
1138         Clear all pending preloads in the DocLoader object when we decide to
1139         cancel its all requests.
1140
1141         * loader/DocLoader.cpp:
1142         (WebCore::DocLoader::clearPendingPreloads):
1143         * loader/DocLoader.h:
1144         * loader/loader.cpp:
1145         (WebCore::Loader::cancelRequests):
1146
1147 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1148
1149         Reviewed by Eric Seidel.
1150
1151         https://bugs.webkit.org/show_bug.cgi?id=24182
1152         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1153
1154         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1155         (WebCore::CALLBACK_FUNC_DECL):
1156         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1157         (WebCore::toV8):
1158         (WebCore::CALLBACK_FUNC_DECL):
1159         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1160         (WebCore::toV8):
1161         (WebCore::CALLBACK_FUNC_DECL):
1162
1163 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1164
1165         Reviewed by Darin Adler.
1166
1167         https://bugs.webkit.org/show_bug.cgi?id=23500
1168         KURL::parse() incorrectly compares its result to original string
1169
1170         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
1171
1172 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1173
1174         Reviewed by Kevin McCullough.
1175
1176         Manual test for inspector node highlighting.
1177
1178         * manual-tests/inspector/highlight-nodes.html: Added.
1179
1180 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
1181
1182         Reviewed by Darin Fisher.
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=23973
1185         ScrollView::scrollContents can be invoked during view shutdown.  In
1186         this scenario the FrameView::hostWindow method can return NULL, which
1187         indicates that the frame/page is being destroyed. This causes a crash
1188         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
1189         NULL check for this.  
1190
1191         * platform/ScrollView.cpp:
1192         (WebCore::ScrollView::scrollContents):
1193
1194 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
1195
1196         Reviewed by Dave Hyatt.
1197
1198         https://bugs.webkit.org/show_bug.cgi?id=24003
1199         Fix a crash caused by unsafe type conversion.
1200
1201         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
1202
1203         * rendering/RenderBox.cpp:
1204         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
1205
1206 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1207
1208         Reviewed by Adam Roben.
1209
1210         https://bugs.webkit.org/show_bug.cgi?id=24202
1211         Have drawNodeHighlight clip instead of clearing. This makes it work for
1212         both Safari and Chromium since Chromium draws the inspector highlighting
1213         in the same buffer as the page.
1214
1215         * inspector/InspectorController.cpp:
1216         (WebCore::quadToPath):
1217         (WebCore::drawOutlinedQuad):
1218         (WebCore::drawOutlinedQuadWithClip):
1219         (WebCore::drawHighlightForBox):
1220
1221 2009-02-26  David Hyatt  <hyatt@apple.com>
1222
1223         Reviewed by Dan Bernstein & Darin Adler
1224
1225         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
1226         
1227         Added fast/inline/inline-continuation-borders.html
1228
1229         * rendering/InlineFlowBox.cpp:
1230         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
1231
1232 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
1233
1234         Build fix, no review.
1235         
1236         Try to fix the wx build after r41218.
1237
1238         * WebCoreSources.bkl:
1239
1240 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1241
1242         Reviewed by Darin Adler.
1243
1244         https://bugs.webkit.org/show_bug.cgi?id=19527
1245         ASSERTION FAILED: containerA && containerB
1246
1247         Test: fast/dom/Range/bug-19527.html
1248
1249         * dom/Range.cpp:
1250         (WebCore::Range::isPointInRange):
1251         (WebCore::Range::comparePoint):
1252         Bring the behavior in line with current Firefox, making it impossible for these methods
1253         to pass a null container to compareBoundaryPoints().
1254
1255 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
1256
1257         Reviewed by Holger Freyther.
1258
1259         https://bugs.webkit.org/show_bug.cgi?id=20358
1260
1261         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
1262         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
1263         should set the computed size rather than the specified size, otherwise
1264         the caps just get rendered normal size.
1265
1266 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
1267
1268         Reviewed by George Staikos.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=24062
1271         QNetworkCookieJar expects the url and not the policy url.  Sending the
1272         policy url will cause QNetworkCookieJar to behave incorrectly.  One
1273         example would be a cookie that does not have a path or domain.
1274         QNetworkCookieJar will use the url it is given to fill in default values.
1275         This allows setting cookies on the url of the main frame from an iFrame
1276         when the cookie should be set on the url of the iFrame.
1277
1278         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
1279
1280         * platform/qt/CookieJarQt.cpp:
1281         (WebCore::setCookies):
1282
1283 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
1284
1285         Reviewed by George Staikos.
1286
1287         make WebKit/Qt compile with SVG disabled
1288
1289         * WebCore.pro:
1290         * platform/graphics/qt/FontPlatformDataQt.cpp:
1291
1292 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
1293
1294         Unreviewed build fix. Add WebCore/workers to the list of paths
1295         searched by the bindings generator perl script.
1296
1297         * GNUmakefile.am:
1298
1299 2009-02-25  Sam Weinig  <sam@webkit.org>
1300
1301         Reviewed by Geoffrey Garen.
1302
1303         Add canvas to the list of RenderObjects that can mark a page as
1304         visually not empty.
1305
1306         * rendering/RenderHTMLCanvas.cpp:
1307         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1308
1309 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
1310
1311         Reviewed by Dave Hyatt.
1312
1313         * rendering/RenderBox.cpp:
1314         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
1315         as RenderMedia with controls always has a layer.
1316
1317 2009-02-25  Dan Bernstein  <mitz@apple.com>
1318
1319         Reviewed by Simon Fraser.
1320
1321         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
1322           <rdar://problem/6618196> Paint very slow when horizontally resizing
1323
1324         Test: fast/gradients/background-clipped.html
1325
1326         * rendering/RenderBoxModelObject.cpp:
1327         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
1328         destination rectangle passed to drawTiledImage() with the dirty
1329         rectangle. This makes it more likely for the destination rect to be
1330         contained in a single tile rect, which results in a faster code path
1331         being taken down the road (just drawing a single tile instead of
1332         tiling).
1333
1334 2009-02-25  Ojan Vafai  <ojan@chromium.org>
1335
1336         Reviewed by Eric Seidel.
1337
1338         Fix test regressions from positionForCoordinates patch.
1339         https://bugs.webkit.org/show_bug.cgi?id=24148
1340
1341         * rendering/RenderBlock.cpp:
1342         (WebCore::positionForPointWithInlineChildren):
1343         Remove ASSERT that placeholder text codepath is hitting.
1344
1345 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
1346
1347         Reviewed by Beth Dakin.
1348
1349         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
1350         https://bugs.webkit.org/show_bug.cgi?id=24143
1351
1352         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
1353         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
1354         Make sure the AXObjectWrapper's have an object before calling them
1355         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
1356
1357         Test: platform/mac-snowleopard/accessibility/table-updating.html
1358
1359         * WebCore.base.exp:
1360         * page/AXObjectCache.cpp:
1361         (WebCore::AXObjectCache::~AXObjectCache):
1362         (WebCore::AXObjectCache::get):
1363         (WebCore::AXObjectCache::getOrCreate):
1364         (WebCore::AXObjectCache::removeAXID):
1365         (WebCore::AXObjectCache::handleActiveDescendantChanged):
1366         (WebCore::AXObjectCache::handleAriaRoleChanged):
1367         * page/AXObjectCache.h:
1368         * page/AccessibilityImageMapLink.cpp:
1369         (WebCore::AccessibilityImageMapLink::parentObject):
1370         * page/AccessibilityListBox.cpp:
1371         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
1372         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
1373         * page/AccessibilityListBoxOption.cpp:
1374         (WebCore::AccessibilityListBoxOption::elementRect):
1375         (WebCore::AccessibilityListBoxOption::parentObject):
1376         * page/AccessibilityObject.cpp:
1377         (WebCore::AccessibilityObject::detach):
1378         (WebCore::AccessibilityObject::parentObjectIfExists):
1379         (WebCore::replacedNodeNeedsCharacter):
1380         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
1381         * page/AccessibilityObject.h:
1382         * page/AccessibilityRenderObject.cpp:
1383         (WebCore::AccessibilityRenderObject::firstChild):
1384         (WebCore::AccessibilityRenderObject::lastChild):
1385         (WebCore::AccessibilityRenderObject::previousSibling):
1386         (WebCore::AccessibilityRenderObject::nextSibling):
1387         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
1388         (WebCore::AccessibilityRenderObject::parentObject):
1389         (WebCore::AccessibilityRenderObject::isAttachment):
1390         (WebCore::AccessibilityRenderObject::headingLevel):
1391         (WebCore::AccessibilityRenderObject::anchorElement):
1392         (WebCore::AccessibilityRenderObject::menuForMenuButton):
1393         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
1394         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
1395         (WebCore::AccessibilityRenderObject::internalLinkElement):
1396         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
1397         (WebCore::AccessibilityRenderObject::titleUIElement):
1398         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1399         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
1400         (WebCore::AccessibilityRenderObject::getDocumentLinks):
1401         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
1402         (WebCore::AccessibilityRenderObject::focusedUIElement):
1403         (WebCore::AccessibilityRenderObject::activeDescendant):
1404         (WebCore::AccessibilityRenderObject::observableObject):
1405         (WebCore::AccessibilityRenderObject::childrenChanged):
1406         (WebCore::AccessibilityRenderObject::addChildren):
1407         * page/AccessibilityRenderObject.h:
1408         (WebCore::AccessibilityRenderObject::setRenderObject):
1409         * page/AccessibilityTable.cpp:
1410         (WebCore::AccessibilityTable::addChildren):
1411         (WebCore::AccessibilityTable::headerContainer):
1412         (WebCore::AccessibilityTable::cellForColumnAndRow):
1413         * page/AccessibilityTableCell.cpp:
1414         (WebCore::AccessibilityTableCell::isTableCell):
1415         (WebCore::AccessibilityTableCell::titleUIElement):
1416         * page/AccessibilityTableColumn.cpp:
1417         (WebCore::AccessibilityTableColumn::headerObjectForSection):
1418         * page/AccessibilityTableRow.cpp:
1419         (WebCore::AccessibilityTableRow::isTableRow):
1420         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
1421         * page/mac/AXObjectCacheMac.mm:
1422         (WebCore::AXObjectCache::postNotification):
1423         (WebCore::AXObjectCache::postNotificationToElement):
1424         * page/mac/AccessibilityObjectWrapper.mm:
1425         (textMarkerForVisiblePosition):
1426         (AXLinkElementForNode):
1427         (nsStringForReplacedNode):
1428         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
1429         (-[AccessibilityObjectWrapper accessibilityActionNames]):
1430         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1431         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
1432         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
1433         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1434         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
1435         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
1436         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
1437         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
1438         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1439         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
1440         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1441         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1442         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1443
1444 2009-02-25  Beth Dakin  <bdakin@apple.com>
1445
1446         Reviewed by Geoff Garen.
1447
1448         Re-working of <rdar://problem/6487249> repro crash in 
1449         WebCore::CSSParser::parseFillImage copying entire contents of this 
1450         page
1451         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
1452
1453         Fixes a bunch of layout test failures I caused!
1454
1455         * css/CSSParser.cpp:
1456         (WebCore::CSSParser::parseValue):
1457         (WebCore::CSSParser::parseContent):
1458         (WebCore::CSSParser::parseFillImage):
1459         (WebCore::CSSParser::parseFontFaceSrc):
1460         (WebCore::CSSParser::parseBorderImage):
1461
1462 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
1463
1464         Reviewed by Eric Seidel.
1465
1466         https://bugs.webkit.org/show_bug.cgi?id=24174
1467         Add more V8 custom bindings.
1468
1469         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
1470         (WebCore::hasCSSPropertyNamePrefix):
1471         (WebCore::cssPropertyName):
1472         (WebCore::NAMED_PROPERTY_GETTER):
1473         (WebCore::NAMED_PROPERTY_SETTER):
1474         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
1475         (WebCore::INDEXED_PROPERTY_GETTER):
1476         (WebCore::CALLBACK_FUNC_DECL):
1477         * bindings/v8/custom/V8EventCustom.cpp: Added.
1478         (WebCore::ACCESSOR_SETTER):
1479         (WebCore::ACCESSOR_GETTER):
1480         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
1481         (WebCore::NAMED_PROPERTY_DELETER):
1482         (WebCore::NAMED_PROPERTY_SETTER):
1483         (WebCore::NAMED_PROPERTY_GETTER):
1484         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
1485         (WebCore::NAMED_PROPERTY_GETTER):
1486         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
1487         (WebCore::INDEXED_PROPERTY_GETTER):
1488         (WebCore::NAMED_PROPERTY_GETTER):
1489         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
1490         (WebCore::NAMED_PROPERTY_GETTER):
1491         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
1492         (WebCore::NAMED_PROPERTY_GETTER):
1493
1494 2009-02-25  Scott Violet  <sky@google.com>
1495
1496         Reviewed by Dave Hyatt.
1497
1498         https://bugs.webkit.org/show_bug.cgi?id=24171
1499         Provides a RenderTheme method for getting the scroll bar size and
1500         changes RenderListBox to use it. RenderTheme returns a size of regular,
1501         and Mac's override to return small. Changes ScrollbarThemeChromium to
1502         use the scrollbarsize of the scrollbar when getting the size
1503         instead of passing in no-args.
1504
1505         * platform/chromium/ScrollbarThemeChromium.cpp:
1506         (WebCore::ScrollbarThemeChromium::trackRect):
1507         (WebCore::ScrollbarThemeChromium::buttonSize):
1508         * rendering/RenderListBox.cpp:
1509         (WebCore::RenderListBox::createScrollbar):
1510         * rendering/RenderTheme.h:
1511         (WebCore::RenderTheme::scrollbarControlSizeForPart):
1512         * rendering/RenderThemeChromiumMac.h:
1513         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
1514         * rendering/RenderThemeMac.h:
1515         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
1516
1517 2009-02-25  Beth Dakin  <bdakin@apple.com>
1518
1519         Reviewed by Darin Adler.
1520
1521         Fix for <rdar://problem/6487249> repro crash in 
1522         WebCore::CSSParser::parseFillImage copying entire contents of this 
1523         page
1524         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
1525
1526         * css/CSSParser.cpp:
1527         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
1528
1529 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
1530
1531         Fix the Qt build.
1532
1533         * WebCore.pro:
1534
1535 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
1536
1537         Gtk build fix. Not reviewed.
1538
1539         Add files to the build per r41218.
1540         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
1541
1542         * GNUmakefile.am:
1543         * page/DOMWindow.cpp:
1544
1545 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
1546
1547         Reviewed by Alexey Proskuryakov.
1548
1549         https://bugs.webkit.org/show_bug.cgi?id=24043
1550         When faced with URLs with unsupported protocol on Gtk port,
1551         report the error through an idle function and return true, so
1552         a proper resource handle is created.
1553
1554         * platform/network/soup/ResourceHandleSoup.cpp:
1555         (WebCore::reportUnknownProtocolError):
1556         (WebCore::ResourceHandle::start):
1557
1558 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
1559
1560         Windows build fix.
1561         Use struct to forward declare ResourceRequest.
1562
1563         * history/HistoryItem.h:
1564         * inspector/InspectorController.h:
1565         * loader/DocumentThreadableLoader.h:
1566         * loader/FrameLoaderClient.h:
1567         * loader/MainResourceLoader.h:
1568         * loader/SubresourceLoader.h:
1569         * loader/SubresourceLoaderClient.h:
1570         * loader/ThreadableLoader.h:
1571         * loader/WorkerThreadableLoader.h:
1572         * platform/CrossThreadCopier.h:
1573         * platform/network/ResourceHandle.h:
1574         * platform/network/ResourceHandleClient.h:
1575         * platform/network/ResourceRequestBase.h:
1576         * platform/network/cf/ResourceRequestCFNet.h:
1577         * xml/XMLHttpRequest.h:
1578
1579 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
1580
1581         Partial Windows build fix.
1582         
1583         * DerivedSources.cpp:
1584         * WebCore.vcproj/WebCore.vcproj:
1585
1586 2009-02-25  Dirk Schulze  <krit@webkit.org>
1587
1588         Reviewed by Oliver Hunt.
1589
1590         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
1591         calculate the behavior of arcTo and draws it with lineTo and arc.
1592
1593         [QT] implement Canvas arcTo
1594         https://bugs.webkit.org/show_bug.cgi?id=23873
1595
1596         * platform/graphics/qt/PathQt.cpp:
1597         (WebCore::Path::addArcTo):
1598
1599 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
1600
1601         Reviewed by Dan Bernstein
1602
1603         Remove idl files from Resources, and sort.
1604         
1605         * WebCore.xcodeproj/project.pbxproj:
1606
1607 2009-02-25  Chris Marrin  <cmarrin@apple.com>
1608
1609         Reviewed by Simon Fraser.
1610
1611         https://bugs.webkit.org/show_bug.cgi?id=23943
1612
1613         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
1614         the window object. Also added WebKitPoint object, which is passed in and out
1615         of these functions.
1616
1617         Test: fast/dom/Window/webkitConvertPoint.html
1618
1619         * DerivedSources.make:
1620         * WebCore.pro:
1621         * WebCore.vcproj/WebCore.vcproj:
1622         * WebCore.xcodeproj/project.pbxproj:
1623         * WebCoreSources.bkl:
1624         * bindings/js/JSDOMWindowBase.cpp:
1625         (jsDOMWindowBaseWebKitPoint):
1626         (setJSDOMWindowBaseWebKitPoint):
1627         * bindings/js/JSWebKitPointConstructor.cpp: Added.
1628         (WebCore::):
1629         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
1630         (WebCore::constructWebKitPoint):
1631         (WebCore::JSWebKitPointConstructor::getConstructData):
1632         * bindings/js/JSWebKitPointConstructor.h: Added.
1633         (WebCore::JSWebKitPointConstructor::classInfo):
1634         * dom/Node.cpp:
1635         (WebCore::Node::convertToPage):
1636         (WebCore::Node::convertFromPage):
1637         * dom/Node.h:
1638         * page/DOMWindow.cpp:
1639         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
1640         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
1641         * page/DOMWindow.h:
1642         * page/DOMWindow.idl:
1643         * page/WebKitPoint.h: Added.
1644         (WebCore::WebKitPoint::create):
1645         (WebCore::WebKitPoint::x):
1646         (WebCore::WebKitPoint::y):
1647         (WebCore::WebKitPoint::setX):
1648         (WebCore::WebKitPoint::setY):
1649         (WebCore::WebKitPoint::WebKitPoint):
1650         * page/WebKitPoint.idl: Added.
1651
1652 2009-02-25  Jian Li  <jianli@chromium.org>
1653
1654         Reviewed by Alexey Proskuryakov.
1655
1656         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
1657         https://bugs.webkit.org/show_bug.cgi?id=24145
1658
1659         * platform/CrossThreadCopier.cpp:
1660         * platform/CrossThreadCopier.h:
1661
1662 2009-02-25  David Levin  <levin@chromium.org>
1663
1664         Reviewed by Alexey Proskuryakov.
1665
1666         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
1667         <https://bugs.webkit.org/show_bug.cgi?id=23688>
1668
1669         No observable change in behavior, so no test.
1670
1671         * loader/ThreadableLoader.cpp:
1672         (WebCore::ThreadableLoader::loadResourceSynchronously):
1673         * loader/ThreadableLoaderClientWrapper.h:
1674         (WebCore::ThreadableLoaderClientWrapper::clearClient):
1675         (WebCore::ThreadableLoaderClientWrapper::done):
1676         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
1677         (WebCore::ThreadableLoaderClientWrapper::didFail):
1678         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
1679         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
1680         Expose whether the loader is done (based on what callbacks were done).
1681
1682         * loader/WorkerThreadableLoader.cpp:
1683         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
1684         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
1685         Each loader is given its own mode so that only its callbacks get through the run loop.
1686
1687         The xhr spec says that the readystatechange events are synchronous, so in the case of a
1688         nested sync xhr no readystatechange events should be fired for the outer xhr.
1689
1690         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1691
1692         * loader/WorkerThreadableLoader.h:
1693         (WebCore::WorkerThreadableLoader::create):
1694         (WebCore::WorkerThreadableLoader::done):
1695
1696         * workers/WorkerRunLoop.cpp:
1697         (WebCore::WorkerRunLoop::WorkerRunLoop):
1698         * workers/WorkerRunLoop.h:
1699         (WebCore::WorkerRunLoop::createUniqueId):
1700         Simple method to create a uniqueId on demand with respect to the run loop.
1701
1702         * workers/WorkerThread.h:
1703
1704 2009-02-25  David Levin  <levin@chromium.org>
1705
1706         Reviewed by Alexey Proskuryakov.
1707
1708         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
1709         <https://bugs.webkit.org/show_bug.cgi?id=24089>
1710
1711         Make threadable loader callbacks to happen during the sync load call.
1712
1713         Changes the behavior of sync xhr for insecure redirects in two ways:
1714         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
1715         + Throws a network exception which is what other browsers do and what the spec
1716         says to do (http://www.w3.org/TR/XMLHttpRequest/).
1717
1718         * loader/DocumentThreadableLoader.cpp:
1719         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
1720         * loader/DocumentThreadableLoader.h:
1721         * loader/ThreadableLoader.cpp:
1722         (WebCore::ThreadableLoader::loadResourceSynchronously):
1723         * loader/ThreadableLoader.h:
1724         * xml/XMLHttpRequest.cpp:
1725         (WebCore::XMLHttpRequest::XMLHttpRequest):
1726         (WebCore::XMLHttpRequest::loadRequestSynchronously):
1727         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
1728         (WebCore::XMLHttpRequest::didFail):
1729         (WebCore::XMLHttpRequest::didFailRedirectCheck):
1730         * xml/XMLHttpRequest.h:
1731
1732 2009-02-24  Chris Marrin  <cmarrin@apple.com>
1733
1734         Reviewed by David Hyatt.
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=23368
1737
1738         Added logic to correctly hit test accelerated layers.
1739
1740         Tests: animations/animation-hit-test-transform.html
1741                animations/animation-hit-test.html
1742                transitions/transition-hit-test-transform.html
1743                transitions/transition-hit-test.html
1744
1745         * page/animation/KeyframeAnimation.cpp:
1746         (WebCore::KeyframeAnimation::animate):
1747         * rendering/RenderLayer.cpp:
1748         (WebCore::RenderLayer::hitTestLayer):
1749         (WebCore::RenderLayer::updateClipRects):
1750         * rendering/RenderLayerBacking.cpp:
1751         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
1752
1753 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
1754
1755         Reviewed by Darin Adler.
1756
1757         https://bugs.webkit.org/show_bug.cgi?id=24067
1758         REGRESSION: Crash in WebCore::Document::initSecurityContext
1759
1760         The crash started to happen when we removed a check for frame->document() being null.
1761         However, the original document shouldn't be null here, because it is needed to alias
1762         security origins. So, this patch fixes the crash by correcting security origin behavior.
1763
1764         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
1765         This tests for not crashing, and for inheriting the domain from the document being replaced.
1766         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
1767         domain to remove a prefix from.
1768
1769         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
1770         clearing the frame, so that Document::initSecurityContext() could access the old one.
1771
1772 2009-02-25  Jay Campan  <jcampan@google.com>
1773
1774         Reviewed by Darin Fisher.
1775
1776         https://bugs.webkit.org/show_bug.cgi?id=24066
1777
1778         Items in drop-downs were not painted correctly.  Makes sure the
1779         PopupListBox invalidates in the coordinates of the window as this is
1780         FramelessScrollView::invalidateRect paints to.
1781
1782         * platform/chromium/PopupMenuChromium.cpp:
1783         (WebCore::PopupListBox::invalidateRow):
1784
1785 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
1786
1787         Reviewed by Anders Carlsson
1788
1789         https://bugs.webkit.org/show_bug.cgi?id=15081
1790         
1791         Make display:none work for applet, emebed and object elements
1792         by calling rendererIsNeeded() on superclasses.
1793
1794         Tests: fast/replaced/applet-display-none.html
1795                fast/replaced/embed-display-none.html
1796                fast/replaced/object-display-none.html
1797
1798         * html/HTMLAppletElement.cpp:
1799         (WebCore::HTMLAppletElement::rendererIsNeeded):
1800         * html/HTMLElement.cpp:
1801         (WebCore::HTMLElement::rendererIsNeeded):
1802         * html/HTMLEmbedElement.cpp:
1803         (WebCore::HTMLEmbedElement::rendererIsNeeded):
1804         * html/HTMLObjectElement.cpp:
1805         (WebCore::HTMLObjectElement::rendererIsNeeded):
1806
1807 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
1808
1809         Reviewed by Dave Hyatt
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=24137
1812         
1813         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
1814         taking perspective and transform-style: preserve-3d into account.
1815         
1816         In order to support transform-style: preserve-3d, which keeps elements in a
1817         3d space, we have to carry along an accumulated matrix in TransformState.
1818         We also need to apply the perspective from the parent, if any, with the
1819         appropriate origin.
1820
1821         * GNUmakefile.am:
1822         * WebCore.base.exp:
1823         * WebCore.pro:
1824         * WebCore.scons:
1825         * WebCore.vcproj/WebCore.vcproj:
1826         * WebCore.xcodeproj/project.pbxproj:
1827         * WebCoreSources.bkl:
1828         * css/CSSComputedStyleDeclaration.cpp:
1829         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1830         * platform/graphics/transforms/TransformationMatrix.cpp:
1831         (WebCore::TransformationMatrix::translate):
1832         (WebCore::TransformationMatrix::translate3d):
1833         (WebCore::TransformationMatrix::translateRight3d):
1834         * platform/graphics/transforms/TransformationMatrix.h:
1835         * rendering/RenderBox.cpp:
1836         (WebCore::RenderBox::mapLocalToAbsolutePoint):
1837         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
1838         * rendering/RenderBox.h:
1839         * rendering/RenderLayer.cpp:
1840         (WebCore::RenderLayer::updateTransform):
1841         (WebCore::RenderLayer::perspectiveTransform):
1842         (WebCore::RenderLayer::perspectiveOrigin):
1843         * rendering/RenderLayer.h:
1844         * rendering/RenderLayerBacking.cpp:
1845         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
1846         * rendering/RenderLayerCompositor.cpp:
1847         (WebCore::requiresCompositingLayerForTransform):
1848         (WebCore::RenderLayerCompositor::layerHas3DContent):
1849         * rendering/RenderObject.cpp:
1850         (WebCore::RenderObject::localToAbsolute):
1851         (WebCore::RenderObject::absoluteToLocal):
1852         (WebCore::RenderObject::mapLocalToAbsolutePoint):
1853         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
1854         * rendering/RenderObject.h:
1855         * rendering/RenderTableCell.cpp:
1856         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
1857         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
1858         * rendering/RenderTableCell.h:
1859         * rendering/RenderView.cpp:
1860         (WebCore::RenderView::mapLocalToAbsolutePoint):
1861         (WebCore::RenderView::mapAbsoluteToLocalPoint):
1862         * rendering/RenderView.h:
1863         * rendering/TransformState.cpp: Added.
1864         (WebCore::TransformState::move):
1865         (WebCore::TransformState::applyTransform):
1866         (WebCore::TransformState::flatten):
1867         * rendering/TransformState.h: Added.
1868         (WebCore::TransformState::):
1869         (WebCore::TransformState::TransformState):
1870         (WebCore::TransformState::move):
1871         * rendering/style/RenderStyle.h:
1872         (WebCore::InheritedFlags::hasPerspective):
1873
1874 2009-02-24  Sam Weinig  <sam@webkit.org>
1875
1876         Reviewed by David Hyatt.
1877
1878         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
1879         Regression (r40837): JavaScript image popup doesn't work
1880
1881         Make the getClientRects and getBoundingClientRect methods return rects
1882         relative to the viewport.
1883
1884         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
1885
1886         * dom/Element.cpp:
1887         (WebCore::Element::getClientRects):
1888         (WebCore::Element::getBoundingClientRect):
1889
1890 2009-02-24  Ojan Vafai  <ojan@chromium.org>
1891
1892         Reviewed by Eric Seidel.
1893
1894         SVG pages don't have a body or an html element! 
1895         Don't return early if there is no body.
1896
1897         * editing/VisiblePosition.cpp:
1898         (WebCore::VisiblePosition::canonicalPosition):
1899
1900 2009-02-23  David Hyatt  <hyatt@apple.com>
1901
1902         Reviewed by Eric Seidel
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
1905         
1906         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
1907         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
1908         reflections or masks).
1909         
1910         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
1911         The only difference is that the clip has to be pushed and popped when painting the object's children.
1912         
1913         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
1914         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
1915         use the new functions.
1916         
1917         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
1918         
1919         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
1920         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
1921         
1922         Masks are now treated like normal flow layers (just like reflections).
1923
1924         A couple of test cases have been added to fast/overflow to test the stacking order. 
1925
1926         * rendering/InlineFlowBox.cpp:
1927         (WebCore::InlineFlowBox::nodeAtPoint):
1928         (WebCore::InlineFlowBox::paint):
1929         * rendering/RenderBlock.cpp:
1930         (WebCore::RenderBlock::repaintOverhangingFloats):
1931         (WebCore::RenderBlock::paint):
1932         (WebCore::RenderBlock::paintChildren):
1933         (WebCore::RenderBlock::paintObject):
1934         (WebCore::RenderBlock::paintFloats):
1935         (WebCore::RenderBlock::insertFloatingObject):
1936         (WebCore::RenderBlock::floatRect):
1937         (WebCore::RenderBlock::lowestPosition):
1938         (WebCore::RenderBlock::rightmostPosition):
1939         (WebCore::RenderBlock::leftmostPosition):
1940         (WebCore::RenderBlock::addOverhangingFloats):
1941         (WebCore::RenderBlock::nodeAtPoint):
1942         (WebCore::RenderBlock::hitTestContents):
1943         * rendering/RenderBox.cpp:
1944         (WebCore::RenderBox::nodeAtPoint):
1945         (WebCore::RenderBox::pushContentsClip):
1946         (WebCore::RenderBox::popContentsClip):
1947         * rendering/RenderBox.h:
1948         (WebCore::RenderBox::paintObject):
1949         * rendering/RenderBoxModelObject.cpp:
1950         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
1951         * rendering/RenderBoxModelObject.h:
1952         * rendering/RenderLayer.cpp:
1953         (WebCore::RenderLayer::paintLayer):
1954         (WebCore::RenderLayer::hitTestLayer):
1955         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
1956         (WebCore::RenderLayer::isSelfPaintingLayer):
1957         * rendering/RenderLayer.h:
1958         * rendering/RenderTable.cpp:
1959         (WebCore::RenderTable::paint):
1960         (WebCore::RenderTable::paintObject):
1961         (WebCore::RenderTable::nodeAtPoint):
1962         * rendering/RenderTable.h:
1963         * rendering/RenderTableCell.cpp:
1964         (WebCore::RenderTableCell::paint):
1965         * rendering/RenderTableRow.cpp:
1966         (WebCore::RenderTableRow::nodeAtPoint):
1967         (WebCore::RenderTableRow::paint):
1968         * rendering/RenderTableRow.h:
1969         * rendering/RenderTableSection.cpp:
1970         (WebCore::RenderTableSection::paint):
1971         (WebCore::RenderTableSection::paintObject):
1972         (WebCore::RenderTableSection::nodeAtPoint):
1973         * rendering/RenderTableSection.h:
1974         * rendering/RenderTreeAsText.cpp:
1975         (WebCore::write):
1976         (WebCore::writeLayers):
1977
1978 2009-02-24  David Levin  <levin@chromium.org>
1979
1980         Reviewed by NOBODY (build fix).
1981
1982         Attempted build fix for wx-mac.
1983
1984         * WebCoreSources.bkl:
1985
1986 2009-02-24  David Levin  <levin@chromium.org>
1987
1988         Reviewed by NOBODY (build fix).
1989
1990         Attempted build fixes for qt-linux and wx-mac.
1991
1992         * WebCore.pro:
1993         * webcore-base.bkl:
1994
1995 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
1996
1997         Reviewed by Sam Weinig.
1998
1999         Fix null pointer error. If the node is the Document, then ownerDocument() 
2000         returns null, document() does not.
2001
2002         * editing/VisiblePosition.cpp:
2003         (WebCore::VisiblePosition::canonicalPosition):
2004
2005 2009-02-24  Jian Li  <jianli@chromium.org>
2006
2007         Reviewed by NOBODY (attempted build fixes).
2008
2009         Fix build break for Windows and Linux.
2010
2011         * GNUmakefile.am:
2012         * WebCore.vcproj/WebCore.vcproj:
2013
2014 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2015
2016         Reviewed by Eric Seidel.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=24131
2019         Fix-up COM/RefCounted dichotomy in Chromium port.
2020
2021         * page/chromium/AccessibilityObjectWrapper.h:
2022         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2023         explicit setting of recount.
2024
2025 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2026
2027         Reviewed by Eric Seidel.
2028
2029         https://bugs.webkit.org/show_bug.cgi?id=24141
2030         Add clarity to V8 interceptor helper function.
2031
2032         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2033         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2034         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2035         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2036         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2037
2038 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2039
2040         Reviewed by Eric Seidel
2041
2042         Minor numeric cleanup: convert float literals to doubles.
2043         
2044         * platform/graphics/transforms/RotateTransformOperation.cpp:
2045         (WebCore::RotateTransformOperation::blend):
2046
2047 2009-02-24  Mark Mentovai  <mark@chromium.org>
2048
2049         Reviewed by Eric Seidel.
2050
2051         https://bugs.webkit.org/show_bug.cgi?id=24139
2052         Add missing include.
2053
2054         * bindings/v8/ScriptInstance.h:
2055
2056 2009-02-24  Jian Li  <jianli@chromium.org>
2057
2058         Reviewed by Alexey Proskuryakov.
2059
2060         Move worker related files from dom directory to worker directory under WebCore.
2061         https://bugs.webkit.org/show_bug.cgi?id=24123
2062
2063         * DerivedSources.make:
2064         * GNUmakefile.am:
2065         * WebCore.pro:
2066         * WebCore.scons:
2067         * WebCore.vcproj/MigrateIDLAndScripts:
2068         * WebCore.vcproj/WebCore.vcproj:
2069         * WebCore.xcodeproj/project.pbxproj:
2070         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2071         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2072         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2073         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2074         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2075         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2076         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2077         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2078         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2079         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2080         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2081         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2082         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2083         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2084         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2085         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2086         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2087         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2088         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2089         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2090
2091 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2092
2093         Reviewed by Dave Hyatt.
2094
2095         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2096         around divs inside editable regions.
2097         https://bugs.webkit.org/show_bug.cgi?id=23605
2098
2099         Fix clicks outside editable regions from focusing the editable region.
2100         https://bugs.webkit.org/show_bug.cgi?id=23607
2101
2102         Removed editing/selection/contenteditable-click-outside.html as it's
2103         not as useful as our new tests.
2104
2105         Clean up RenderBlock::positionForCoordinates to remove dead code,
2106         duplicate code, and generally make it more readable.
2107
2108         Tests: editing/selection/click-in-margins-inside-editable-div.html
2109                editing/selection/click-in-padding-with-multiple-line-boxes.html
2110                editing/selection/click-outside-editable-div.html
2111
2112         * editing/VisiblePosition.cpp:
2113         (WebCore::VisiblePosition::canonicalPosition):
2114         * rendering/RenderBlock.cpp:
2115         (WebCore::positionForPointRespectingEditingBoundaries):
2116         (WebCore::positionForPointWithInlineChildren):
2117         (WebCore::RenderBlock::positionForCoordinates):
2118         (WebCore::RenderBlock::updateFirstLetter):
2119
2120 2009-02-24  Sam Weinig  <sam@webkit.org>
2121
2122         Reviewed by Geoffrey Garen.
2123
2124         Related to <rdar://problem/6590295>
2125         Allow disabling javascript: urls.
2126
2127         * WebCore.base.exp:
2128         * html/HTMLAnchorElement.cpp:
2129         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2130         * loader/FrameLoader.cpp:
2131         (WebCore::FrameLoader::executeIfJavaScriptURL):
2132         * page/Page.cpp:
2133         (WebCore::Page::Page):
2134         (WebCore::Page::setJavaScriptURLsAreAllowed):
2135         (WebCore::Page::javaScriptURLsAreAllowed):
2136         * page/Page.h:
2137
2138 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2139
2140         Fix build when ACCELERATED_COMPOSITING is turned on
2141         (overflowList() -> normalFlowList()).
2142     
2143         * rendering/RenderLayerBacking.cpp:
2144         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2145         (WebCore::RenderLayerBacking::paintIntoLayer):
2146         * rendering/RenderLayerCompositor.cpp:
2147         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2148         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2149         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2150         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2151         (WebCore::RenderLayerCompositor::layerHas3DContent):
2152
2153 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2154
2155         Reviewed by Darin Adler
2156         
2157         https://bugs.webkit.org/show_bug.cgi?id=24135
2158         
2159         Round the FloatPoint returned by absoluteToLocal(), rather than
2160         truncating it.
2161
2162         * dom/MouseRelatedEvent.cpp:
2163         (WebCore::MouseRelatedEvent::receivedTarget):
2164
2165 2009-02-24  Beth Dakin  <bdakin@apple.com>
2166
2167         Reviewed by Sam Weinig.
2168
2169         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
2170         Ordered list item marker misaligned when line height is not 1.2 
2171         -and corresponding <rdar://problem/6602506>
2172
2173         This is a regression from http://trac.webkit.org/changeset/40880 
2174         where createInlineBox was taken off of RenderObject and moved to 
2175         RenderBox. The problem was that the RenderBox version still needs 
2176         to be virtual because there is still an existing implementation in 
2177         RenderListMarker. 
2178
2179         * rendering/RenderBox.h:
2180         * rendering/RenderListMarker.cpp:
2181         (WebCore::RenderListMarker::createInlineBox):
2182         * rendering/RenderListMarker.h:
2183
2184 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2185
2186         Reviewed by Eric Seidel.
2187
2188         https://bugs.webkit.org/show_bug.cgi?id=24128
2189         Upstream more V8 custom bindings: constructors, XSLTProcessor.
2190
2191         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
2192         (WebCore::CALLBACK_FUNC_DECL):
2193         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
2194         (WebCore::CALLBACK_FUNC_DECL):
2195         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
2196         (WebCore::CALLBACK_FUNC_DECL):
2197         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
2198         (WebCore::CALLBACK_FUNC_DECL):
2199         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
2200         (WebCore::CALLBACK_FUNC_DECL):
2201         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
2202         (WebCore::CALLBACK_FUNC_DECL):
2203
2204 2009-02-24  David Levin  <levin@chromium.org>
2205
2206         Reviewed by Alexey Proskuryakov.
2207
2208         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
2209         <https://bugs.webkit.org/show_bug.cgi?id=24090>
2210
2211         No observable change in behavior, so no test.
2212
2213         * dom/WorkerMessagingProxy.cpp:
2214         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
2215         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
2216         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
2217
2218         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
2219
2220         * dom/WorkerMessagingProxy.h:
2221         * loader/ThreadableLoader.cpp:
2222         (WebCore::ThreadableLoader::create):
2223         * loader/WorkerThreadableLoader.cpp:
2224         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2225         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2226         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
2227         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2228         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
2229         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
2230         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
2231         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2232         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
2233         Changed these methods to post task using a mode.
2234
2235         * loader/WorkerThreadableLoader.h:
2236         (WebCore::WorkerThreadableLoader::create):
2237
2238 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
2239
2240         Reviewed by Darin Adler.
2241
2242         https://bugs.webkit.org/show_bug.cgi?id=24091
2243         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
2244
2245         Test: http/tests/appcache/access-via-redirect.php
2246
2247         * loader/appcache/ApplicationCacheGroup.cpp:
2248         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
2249         not the original one.
2250
2251 2009-02-24  Jian Li  <jianli@chromium.org>
2252
2253         Reviewed by Alexey Proskuryakov.
2254
2255         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
2256         https://bugs.webkit.org/show_bug.cgi?id=24112
2257
2258         * bindings/js/WorkerScriptController.cpp:
2259         * dom/WorkerContext.cpp:
2260
2261 2009-02-23  Antti Koivisto  <antti@apple.com>
2262
2263         Reviewed by Oliver Hunt.
2264
2265         <rdar://problem/6613796> Extended text codecs registered on webview creation
2266
2267         Comparing a text encoding with string "GBK" ended up constructing
2268         TextEncoding("GBK") which in turn initialized all extended
2269         text codecs.
2270
2271         * platform/text/TextCodecICU.cpp:
2272         (WebCore::TextCodecICU::decode):
2273
2274 2009-02-23  Sam Weinig  <sam@webkit.org>
2275
2276         Fix Qt build.
2277
2278         * bridge/qt/qt_runtime.cpp:
2279         (JSC::Bindings::valueRealType):
2280
2281 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
2282
2283         Reviewed by Darin Adler.
2284
2285         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
2286
2287         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
2288         element created with createElement could have a wrong nodeName (createElement sets the string as the
2289         localName without checking for a prefix).
2290
2291         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
2292         and will always succeed.
2293         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
2294         to ensure that).
2295
2296         Test: fast/dom/cloneNode.html
2297
2298         * dom/Element.cpp:
2299         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
2300         always return an element.
2301
2302         * html/HTMLElement.cpp:
2303         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
2304
2305 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
2306
2307         Reviewed by Eric Seidel.
2308
2309         https://bugs.webkit.org/show_bug.cgi?id=24109
2310         Upstream V8 Script abstractions, all except ScriptController.
2311
2312         * bindings/v8/ScriptCachedFrameData.h: Added.
2313         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
2314         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
2315         (WebCore::ScriptCachedFrameData::restore):
2316         (WebCore::ScriptCachedFrameData::clear):
2317         (WebCore::ScriptCachedFrameData::domWindow):
2318         * bindings/v8/ScriptCallFrame.cpp: Added.
2319         (WebCore::ScriptCallFrame::ScriptCallFrame):
2320         (WebCore::ScriptCallFrame::~ScriptCallFrame):
2321         (WebCore::ScriptCallFrame::argumentAt):
2322         * bindings/v8/ScriptCallFrame.h: Added.
2323         (WebCore::ScriptCallFrame::functionName):
2324         (WebCore::ScriptCallFrame::sourceURL):
2325         (WebCore::ScriptCallFrame::lineNumber):
2326         (WebCore::ScriptCallFrame::argumentCount):
2327         * bindings/v8/ScriptCallStack.cpp: Added.
2328         (WebCore::ScriptCallStack::ScriptCallStack):
2329         (WebCore::ScriptCallStack::~ScriptCallStack):
2330         (WebCore::ScriptCallStack::at):
2331         * bindings/v8/ScriptCallStack.h: Added.
2332         (WebCore::ScriptCallStack::size):
2333         * bindings/v8/ScriptInstance.cpp: Added.
2334         (WebCore::V8ScriptInstance::V8ScriptInstance):
2335         (WebCore::V8ScriptInstance::~V8ScriptInstance):
2336         (WebCore::V8ScriptInstance::instance):
2337         (WebCore::V8ScriptInstance::clear):
2338         (WebCore::V8ScriptInstance::set):
2339         * bindings/v8/ScriptInstance.h: Added.
2340         (WebCore::V8ScriptInstance::create):
2341         * bindings/v8/ScriptSourceCode.h: Added.
2342         (WebCore::ScriptSourceCode::ScriptSourceCode):
2343         (WebCore::ScriptSourceCode::isEmpty):
2344         (WebCore::ScriptSourceCode::source):
2345         (WebCore::ScriptSourceCode::url):
2346         (WebCore::ScriptSourceCode::startLine):
2347         * bindings/v8/ScriptState.h: Added.
2348         (WebCore::ScriptState::hadException):
2349         (WebCore::ScriptState::setException):
2350         (WebCore::ScriptState::exception):
2351         * bindings/v8/ScriptString.h: Added.
2352         (WebCore::ScriptString::ScriptString):
2353         (WebCore::ScriptString::operator String):
2354         (WebCore::ScriptString::isNull):
2355         (WebCore::ScriptString::size):
2356         (WebCore::ScriptString::operator=):
2357         (WebCore::ScriptString::operator+=):
2358         * bindings/v8/ScriptValue.cpp: Added.
2359         (WebCore::ScriptValue::getString):
2360         * bindings/v8/ScriptValue.h: Added.
2361         (WebCore::ScriptValue::ScriptValue):
2362         (WebCore::ScriptValue::operator=):
2363         (WebCore::ScriptValue::operator==):
2364         (WebCore::ScriptValue::operator!=):
2365         (WebCore::ScriptValue::isNull):
2366         (WebCore::ScriptValue::isUndefined):
2367         (WebCore::ScriptValue::clear):
2368         (WebCore::ScriptValue::~ScriptValue):
2369         (WebCore::ScriptValue::v8Value):
2370
2371 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
2372
2373         Reviewed by Timothy Hatcher.
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=24106
2376         The Qt port is crashing on exit because the tear down procedure involves
2377         the WebCore::InspectorController trying to access the JS execution context
2378         for a page that is being deleted.  This patch amends the inspector so
2379         that it does not try and access the execution context of the WebCore::Page
2380         in the midst of deletion.
2381
2382         * inspector/InspectorController.cpp:
2383         (WebCore::InspectorController::inspectedPageDestroyed):
2384         (WebCore::InspectorController::stopUserInitiatedProfiling):
2385
2386 2009-02-23  David Levin  <levin@chromium.org>
2387
2388         Reviewed by Alexey Proskuryakov.
2389
2390         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
2391         <https://bugs.webkit.org/show_bug.cgi?id=24088>
2392
2393         No observable change in behavior, so no test.
2394
2395         * loader/DocumentThreadableLoader.cpp:
2396         (WebCore::DocumentThreadableLoader::create):
2397         * loader/ThreadableLoaderClient.h:
2398         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
2399         * loader/ThreadableLoaderClientWrapper.h:
2400         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2401         * loader/WorkerThreadableLoader.cpp:
2402         (WebCore::workerContextDidFailRedirectCheck):
2403         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2404         * loader/WorkerThreadableLoader.h:
2405         * xml/XMLHttpRequest.cpp:
2406         (WebCore::XMLHttpRequest::didFinishLoading):
2407         * xml/XMLHttpRequest.h:
2408
2409 2009-02-23  David Levin  <levin@chromium.org>
2410
2411         Reviewed by Alexey Proskuryakov.
2412
2413         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
2414         <https://bugs.webkit.org/show_bug.cgi?id=24047>
2415
2416         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
2417         using only MessageQueue::waitForMessageFilteredWithTimeout instead
2418         of three different MessageQueue methods.
2419
2420         No observable change in behavior, so no test.
2421
2422         * dom/WorkerRunLoop.cpp:
2423         (WebCore::ModePredicate::operator()):
2424         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
2425         (WebCore::WorkerRunLoop::runInMode):
2426         * dom/WorkerRunLoop.h:
2427
2428 2009-02-23  David Hyatt  <hyatt@apple.com>
2429
2430         In preparation for making layers for multicol objects (so that they can properly split child layers
2431         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
2432         of RenderLayer to use the term "normal flow" instead.
2433
2434         Reviewed by Cameron Zwarich
2435
2436         * rendering/RenderLayer.cpp:
2437         (WebCore::RenderLayer::RenderLayer):
2438         (WebCore::RenderLayer::~RenderLayer):
2439         (WebCore::RenderLayer::setHasVisibleContent):
2440         (WebCore::RenderLayer::enclosingCompositingLayer):
2441         (WebCore::RenderLayer::addChild):
2442         (WebCore::RenderLayer::removeChild):
2443         (WebCore::RenderLayer::paintLayer):
2444         (WebCore::RenderLayer::hitTestLayer):
2445         (WebCore::RenderLayer::dirtyNormalFlowList):
2446         (WebCore::RenderLayer::updateNormalFlowList):
2447         (WebCore::RenderLayer::collectLayers):
2448         (WebCore::RenderLayer::updateLayerListsIfNeeded):
2449         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2450         (WebCore::RenderLayer::styleChanged):
2451         * rendering/RenderLayer.h:
2452         (WebCore::RenderLayer::isNormalFlowOnly):
2453         (WebCore::RenderLayer::normalFlowList):
2454         * rendering/RenderTreeAsText.cpp:
2455         (WebCore::writeLayers):
2456
2457 2009-02-23  David Hyatt  <hyatt@apple.com>
2458
2459         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
2460         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
2461         column rules (rather than ending up above the background of the box but behind the column rules).
2462
2463         Reviewed by Eric Seidel
2464
2465         Added fast/multicol/column-rules-stacking.html
2466
2467         * rendering/RenderBlock.cpp:
2468         (WebCore::RenderBlock::paintColumnRules):
2469         (WebCore::RenderBlock::paintColumnContents):
2470         (WebCore::RenderBlock::paintObject):
2471         * rendering/RenderBlock.h:
2472
2473 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
2474
2475         Reviewed by David Hyatt.
2476
2477         No testcases have been added or modified since this patch should not result in
2478         a behavior change for ports that have layout tests enabled.
2479
2480         Currently, the implementation of GraphicsContext::drawLineForText amongst
2481         the various ports differ in that some of them are honoring the context's
2482         strokeStyle when drawing a text-decoration and some of them are not.
2483         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
2484         but the Cairo implementation does and has an explicit workaround that
2485         sets the strokeStyle() temporarily.
2486
2487         This patch fixes so that all ports are consistent by explicitly making sure
2488         to set the GraphicsContext strokeStyle to SolidStroke whenever
2489         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
2490         should always use a solid stroke.
2491
2492         This patch addresses these bugs:
2493         https://bugs.webkit.org/show_bug.cgi?id=19364
2494         https://bugs.webkit.org/show_bug.cgi?id=15659
2495
2496         * rendering/InlineFlowBox.cpp:
2497         (WebCore::InlineFlowBox::paintTextDecorations):
2498         * rendering/InlineTextBox.cpp:
2499         (WebCore::InlineTextBox::paintDecoration):
2500
2501 2009-02-23  Scott Violet  <sky@google.com>
2502
2503         Reviewed by Eric Seidel.
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=24098
2506         Bugs in ClipboardChromium
2507
2508         Fixes the following bugs in ClipboardChromium:
2509         * It's possible for the extension to be empty, resulting in a bad file
2510           name, for example, 'foo.' or just '.'.
2511         * We weren't restricting the size of the file to MAX_PATH.
2512         * We weren't removing characters that are invalid for file system names.
2513
2514         * platform/chromium/ClipboardChromium.cpp:
2515         (WebCore::writeImageToDataObject):
2516         * platform/chromium/ClipboardChromium.h:
2517         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
2518         (WebCore::ClipboardChromium::validateFileName):
2519         * platform/chromium/ClipboardChromiumMac.cpp: Added.
2520         (WebCore::ClipboardChromium::validateFileName):
2521         * platform/chromium/ClipboardChromiumWin.cpp: Added.
2522         (WebCore::isInvalidFileCharacter):
2523         (WebCore::ClipboardChromium::validateFileName):
2524
2525 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
2526
2527         Reviewed by Simon Hausmann.
2528
2529         Fix the Copyright notices in a few files
2530
2531         * platform/qt/RenderThemeQt.h:
2532
2533 2009-02-23  Xan Lopez  <xan@gnome.org>
2534
2535         Reviewed by Alexey Proskuryakov.
2536
2537         https://bugs.webkit.org/show_bug.cgi?id=22624
2538         [SOUP][GTK] Need API to get SoupSession from WebKit.
2539
2540         Allow to retrieve the Soup session and modify the code to take
2541         into account users changing features on it.
2542
2543         * platform/network/ResourceHandle.h:
2544         * platform/network/soup/CookieJarSoup.cpp:
2545         (WebCore::defaultCookieJar):
2546         (WebCore::setDefaultCookieJar):
2547         * platform/network/soup/CookieJarSoup.h:
2548         * platform/network/soup/ResourceHandleSoup.cpp:
2549         (WebCore::createSoupSession):
2550         (WebCore::ensureSessionIsInitialized):
2551         (WebCore::ResourceHandle::startHttp):
2552         (WebCore::ResourceHandle::cancel):
2553         (WebCore::ResourceHandle::defaultSession):
2554
2555 2009-02-23  Xan Lopez  <xan@gnome.org>
2556
2557         Reviewed by Alexey Proskuryakov.
2558
2559         https://bugs.webkit.org/show_bug.cgi?id=22624
2560         [SOUP][GTK] Need API to get SoupSession from WebKit.
2561
2562         Remove CURL support.
2563
2564         * GNUmakefile.am:
2565
2566 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
2567
2568         Reviewed by Mark Rowe.
2569
2570         Test: fast/dom/empty-hash-and-search.html
2571
2572         https://bugs.webkit.org/show_bug.cgi?id=21147
2573         hash property returns incorrect value for links w/o hash
2574
2575         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
2576
2577         * platform/KURL.cpp:
2578         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
2579         (WebCore::KURL::prettyURL): Append the query with the question mark.
2580
2581         * page/Location.cpp:
2582         (WebCore::Location::search): Return an empty string if query is empty or missing.
2583         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
2584
2585         * dom/WorkerLocation.cpp:
2586         (WebCore::WorkerLocation::search):
2587         (WebCore::WorkerLocation::hash):
2588         Match document.location fixes above.
2589
2590         * html/HTMLAnchorElement.cpp:
2591         (WebCore::HTMLAnchorElement::hash):
2592         (WebCore::HTMLAnchorElement::search):
2593         Return an empty string for empty and missing parts.
2594
2595 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
2596
2597         Reviewed by Darin Adler.
2598
2599         https://bugs.webkit.org/show_bug.cgi?id=20184
2600         SELECT with no name generates invalid query string
2601
2602         Test: fast/forms/select-no-name.html
2603
2604         * html/HTMLSelectElement.cpp:
2605         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
2606
2607 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
2608
2609         Apply review comments for the previous check-in (forgot to save the file, oops).
2610
2611         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
2612
2613 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
2614
2615         Reviewed by Darin Adler.
2616
2617         https://bugs.webkit.org/show_bug.cgi?id=15707
2618         Crash when manipulating document from within an iframe onload function
2619
2620         Test: fast/dom/onload-open.html
2621
2622         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
2623         the current node, because anything can happen when dispatching events.
2624
2625 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
2626
2627         Reviewed by Darin Adler.
2628
2629         https://bugs.webkit.org/show_bug.cgi?id=18970
2630         Numerically named input fields cause document.forms loop problems
2631
2632         Test: fast/forms/numeric-input-name.html
2633
2634         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
2635         latter overrides properties.
2636
2637 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
2638
2639         Reviewed by Sam Weinig.
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=24059
2642         Tokenizer::write() return value is never used
2643
2644         * dom/Tokenizer.h:
2645         * dom/XMLTokenizer.cpp:
2646         (WebCore::XMLTokenizer::write):
2647         * dom/XMLTokenizer.h:
2648         * html/HTMLTokenizer.cpp:
2649         (WebCore::HTMLTokenizer::write):
2650         * html/HTMLTokenizer.h:
2651         * loader/FTPDirectoryDocument.cpp:
2652         (WebCore::FTPDirectoryTokenizer::write):
2653         * loader/ImageDocument.cpp:
2654         (WebCore::ImageTokenizer::write):
2655         * loader/MediaDocument.cpp:
2656         (WebCore::MediaTokenizer::write):
2657         * loader/PluginDocument.cpp:
2658         (WebCore::PluginTokenizer::write):
2659         * loader/TextDocument.cpp:
2660         (WebCore::TextTokenizer::write):
2661         Made write() return void, not bool.
2662
2663 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
2664
2665         Reviewed by Sam Weinig.
2666
2667         Updated for JavaScriptCore changes to timeout checking.
2668
2669         * bindings/js/JSCustomPositionCallback.cpp:
2670         (WebCore::JSCustomPositionCallback::handleEvent):
2671         * bindings/js/JSCustomPositionErrorCallback.cpp:
2672         (WebCore::JSCustomPositionErrorCallback::handleEvent):
2673         * bindings/js/JSCustomSQLStatementCallback.cpp:
2674         (WebCore::JSCustomSQLStatementCallback::handleEvent):
2675         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
2676         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
2677         * bindings/js/JSCustomSQLTransactionCallback.cpp:
2678         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
2679         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
2680         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
2681         * bindings/js/JSCustomVoidCallback.cpp:
2682         (WebCore::JSCustomVoidCallback::handleEvent):
2683         * bindings/js/JSCustomXPathNSResolver.cpp:
2684         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
2685         * bindings/js/JSDOMWindowBase.cpp:
2686         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
2687         (WebCore::JSDOMWindowBase::commonJSGlobalData):
2688         * bindings/js/JSEventListener.cpp:
2689         (WebCore::JSAbstractEventListener::handleEvent):
2690         * bindings/js/ScheduledAction.cpp:
2691         (WebCore::ScheduledAction::executeFunctionInContext):
2692         * bindings/js/ScriptController.cpp:
2693         (WebCore::ScriptController::evaluate):
2694         * bindings/js/WorkerScriptController.cpp:
2695         (WebCore::WorkerScriptController::evaluate):
2696         (WebCore::WorkerScriptController::forbidExecution):
2697         * bindings/objc/WebScriptObject.mm:
2698         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2699         (-[WebScriptObject evaluateWebScript:]):
2700         * bridge/NP_jsobject.cpp:
2701         (_NPN_InvokeDefault):
2702         (_NPN_Invoke):
2703         (_NPN_Evaluate):
2704         (_NPN_Construct):
2705         * bridge/jni/jni_jsobject.mm:
2706         (JavaJSObject::call):
2707         (JavaJSObject::eval):
2708
2709 2009-02-21  Hironori Bono  <hbono@chromium.org>
2710
2711         Reviewed by Alexey Proskuryakov.
2712
2713         https://bugs.webkit.org/show_bug.cgi?id=23786
2714         [Chromium] line-break characters in a complex text are treated as zero-width spaces
2715
2716         This change prevents the UniscribeHelper class from treating the line-break characters
2717         as whitespaces.
2718
2719         Tests: fast/text/international/bidi-linebreak-001.html
2720                fast/text/international/bidi-linebreak-002.html
2721                fast/text/international/bidi-linebreak-003.html
2722
2723         * platform/graphics/chromium/UniscribeHelper.cpp:
2724         (WebCore::UniscribeHelper::adjustSpaceAdvances):
2725         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
2726         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
2727         so does when Chromium renders a simple text.
2728
2729 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
2730
2731         Reviewed by Alexey Proskuryakov.
2732
2733         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
2734
2735         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
2736         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
2737         unneeded.
2738
2739         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
2740         enables us to use some generated QualifiedName.
2741
2742         * bindings/js/JSOptionConstructor.cpp:
2743         (WebCore::constructHTMLOptionElement):
2744         * dom/Document.cpp:
2745         (WebCore::Document::setTitle):
2746         * dom/XMLTokenizer.cpp:
2747         (WebCore::createXHTMLParserErrorHeader):
2748         (WebCore::XMLTokenizer::insertErrorMessageBlock):
2749         * editing/CompositeEditCommand.cpp:
2750         (WebCore::createBlockPlaceholderElement):
2751         * editing/htmlediting.cpp:
2752         (WebCore::createTabSpanElement):
2753         * html/HTMLSelectElement.cpp:
2754         (WebCore::HTMLSelectElement::setLength):
2755         * loader/FTPDirectoryDocument.cpp:
2756         (WebCore::FTPDirectoryTokenizer::appendEntry):
2757         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
2758         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
2759         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
2760         * loader/ImageDocument.cpp:
2761         (WebCore::ImageDocument::createDocumentStructure):
2762         * loader/MediaDocument.cpp:
2763         (WebCore::MediaTokenizer::createDocumentStructure):
2764         * loader/PluginDocument.cpp:
2765         (WebCore::PluginTokenizer::createDocumentStructure):
2766         * loader/TextDocument.cpp:
2767         (WebCore::TextTokenizer::write):
2768         * page/Frame.cpp:
2769         (WebCore::Frame::selectionComputedStyle):
2770         (WebCore::Frame::styleForSelectionStart):
2771         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
2772
2773         * xml/XPathFunctions.cpp:
2774         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
2775         * page/DragController.cpp:
2776         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
2777
2778 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
2779
2780         Reviewed by Eric Seidel.
2781
2782         https://bugs.webkit.org/show_bug.cgi?id=24060
2783         Fix up to accommodate for CanvasPixelArray return.
2784
2785         * platform/graphics/skia/ImageBufferSkia.cpp:
2786         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
2787         (WebCore::ImageBuffer::putImageData): Ditto.
2788
2789 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
2790
2791         Simon Fraser
2792
2793         https://bugs.webkit.org/show_bug.cgi?id=24042
2794         Bug 24042: MediaPlayer should cache plug-in proxy
2795
2796         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
2797         MediaPlayer will always have created the private media player object before
2798         the plug-in is instantiated and calls back with the proxy object. This is not
2799         true on all platforms because of threading latency, so MediaPlayer should
2800         cache the plug-in proxy so it can pass it to the media engine at a later time.
2801
2802         * platform/graphics/MediaPlayer.cpp:
2803         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
2804         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
2805         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
2806         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
2807         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
2808         (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
2809         * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
2810
2811 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
2812
2813         Simon Fraser.
2814
2815         https://bugs.webkit.org/show_bug.cgi?id=24063
2816         Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
2817
2818         * html/HTMLMediaElement.cpp:
2819         (WebCore::HTMLMediaElement::HTMLMediaElement):  Rename m_loadRestrictions to m_Restrictions.
2820         Initialize m_internalCall.
2821         (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
2822         (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
2823         (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
2824         (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
2825         (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
2826         (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
2827         (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
2828         (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
2829         (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
2830         (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
2831         * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
2832         add RequireUserGestureRateChangeRestriction.
2833
2834 2009-02-20  Darin Fisher  <darin@chromium.org>
2835
2836         Fix build bustage in FileSystemWin.cpp.
2837
2838         Need to return CString() instead of 0 since there are now two CString
2839         constructors that take a pointer type.
2840
2841         * platform/win/FileSystemWin.cpp:
2842         (WebCore::openTemporaryFile):
2843
2844 2009-02-20  Dimitri Glazkov  <dglazkov@chromium.org>
2845
2846         Reviewed by Sam Weinig.
2847
2848         https://bugs.webkit.org/show_bug.cgi?id=23999
2849         Change license headers to accurately reflect code history.
2850
2851         * platform/ContentType.cpp:
2852         * platform/ContentType.h:
2853
2854 2009-02-18  Dimitri Glazkov  <dglazkov@chromium.org>
2855
2856         Reviewed by Antti Koivisto.
2857
2858         https://bugs.webkit.org/show_bug.cgi?id=23999
2859         Split off MIME type parsing into its own class.
2860
2861         * GNUmakefile.am: Added ContentType sources.
2862         * WebCore.pro: Ditto.
2863         * WebCore.scons: Ditto.
2864         * WebCore.vcproj/WebCore.vcproj: Ditto.
2865         * WebCore.xcodeproj/project.pbxproj: Ditto.
2866         * WebCoreSources.bkl: Ditto.
2867         * html/HTMLMediaElement.cpp: Changed to use ContentType.
2868         (WebCore::HTMLMediaElement::selectMediaURL):
2869         * platform/ContentType.cpp: Added.
2870         (WebCore::ContentType::ContentType):
2871         (WebCore::ContentType::parameter):
2872         (WebCore::ContentType::type):
2873         * platform/ContentType.h: Added.
2874         (WebCore::ContentType::raw):
2875         * platform/MIMETypeRegistry.cpp:
2876         * platform/MIMETypeRegistry.h:
2877         * platform/graphics/MediaPlayer.cpp:
2878         (WebCore::MediaPlayer::load):
2879         * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
2880         * rendering/style/RenderStyleConstants.h: Ditto.
2881         (WebCore::):
2882
2883 2009-02-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2884
2885         Unreviewed build fix.
2886
2887         Use CString() instead of 0.
2888
2889         * platform/gtk/FileSystemGtk.cpp:
2890         (WebCore::openTemporaryFile):
2891         * platform/qt/FileSystemQt.cpp:
2892         (WebCore::openTemporaryFile):
2893
2894 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
2895
2896         Reviewed by Holger Freyther.
2897
2898         When dealing with local files, use a path instead of an URI. GFile
2899         has problems decoding URIs with percent signs on them.
2900
2901         * platform/network/soup/ResourceHandleSoup.cpp:
2902         (WebCore::ResourceHandle::startGio):
2903
2904 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
2905
2906         Reviewed by Holger Freyther.
2907
2908         Protect the ResourceHandle instance from being destroyed by
2909         didReceiveData inside the GIO readCallback call, so that
2910         cancelling caused by scripts is handled correctly.
2911
2912         * platform/network/soup/ResourceHandleSoup.cpp:
2913         (WebCore::readCallback):
2914
2915 2009-02-20  David Kilzer  <ddkilzer@apple.com>
2916
2917         Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors
2918
2919         Reviewed by Sam Weinig.
2920
2921         * loader/icon/IconDatabaseNone.cpp:
2922         (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL().
2923         (WebCore::IconDatabase::open): Commented out unused parameter.
2924         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto.
2925         (WebCore::IconDatabase::iconForPageURL): Ditto.
2926         (WebCore::IconDatabase::iconURLForPageURL): Ditto.
2927         (WebCore::IconDatabase::defaultIcon): Ditto.
2928         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2929         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2930         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
2931         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2932         (WebCore::IconDatabase::setEnabled): Ditto.
2933         (WebCore::IconDatabase::pageURLMappingCount): Added stub.
2934         (WebCore::IconDatabase::retainedPageURLCount): Ditto.
2935         (WebCore::IconDatabase::iconRecordCount): Ditto.
2936         (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
2937
2938 2009-02-20  David Kilzer  <ddkilzer@apple.com>
2939
2940         Add comment to generated code when shadowing a built-in object
2941
2942         Reviewed by Sam Weinig.
2943
2944         * bindings/scripts/CodeGeneratorJS.pm: Added comment to
2945         generated code output.
2946
2947 2009-02-20  Avi Drissman  <avi@chromium.org>
2948
2949         Reviewed by Eric Seidel.
2950
2951         https://bugs.webkit.org/show_bug.cgi?id=24036
2952         Keyboard events need disambiguation on the Linux platform too.
2953
2954         * platform/chromium/PlatformKeyboardEventChromium.cpp:
2955         (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
2956
2957 2009-02-19  Darin Fisher  <darin@chromium.org>
2958
2959         Reviewed by Eric Seidel.
2960
2961         https://bugs.webkit.org/show_bug.cgi?id=24046
2962
2963         Several improvements to CString:
2964         1- Make it possible to initialize a CString from a CStringBuffer
2965         2- Make it possible to get a CStringBuffer from a CString
2966         3- Change CStringBuffer::data() to return a const pointer to ward off mutation
2967         4- Remove unused releaseBuffer() methods.
2968         5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.
2969
2970         * platform/text/CString.cpp:
2971         (WebCore::CString::init):
2972         (WebCore::CString::mutableData):
2973         (WebCore::CString::newUninitialized):
2974         (WebCore::CString::copyBufferIfNeeded):
2975         * platform/text/CString.h:
2976         (WebCore::CStringBuffer::data):
2977         (WebCore::CStringBuffer::length):
2978         (WebCore::CStringBuffer::create):
2979         (WebCore::CStringBuffer::mutableData):
2980         (WebCore::CString::CString):
2981         (WebCore::CString::buffer):
2982
2983 2009-02-19  Dmitry Titov  <dimich@chromium.org>
2984
2985         Reviewed by Alexey Proskuryakov.
2986
2987         https://bugs.webkit.org/show_bug.cgi?id=24017
2988         Remove some usage of Document in Worker.
2989
2990         * dom/WorkerContext.h:
2991         (WebCore::WorkerContext::userAgent):
2992         * dom/Document.cpp:
2993         (WebCore::Document::userAgent):
2994         * dom/Document.h:
2995         * dom/ScriptExecutionContext.h:
2996         Added virtual ScriptExecutionContext::userAgent(const KURL&).
2997         Document implementation uses FrameLoader::userAgent and
2998         WorkerContext receives the string on creation and stores it in a member.
2999
3000         * dom/Worker.cpp:
3001         (WebCore::Worker::Worker):
3002         (WebCore::Worker::notifyFinished):
3003         * dom/Worker.h:
3004         (WebCore::Worker::create):
3005         Instead of Document the Worker constructor now gets a ScriptExecutionContext.
3006         Start using some methods on SEC (like completeURL() and userAgent()).
3007         For others, explicitly case to Document and add a FIXME.
3008         Remove Worker::document() too.
3009
3010 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3011
3012         Rubber-stamped by Holger Freyther.
3013
3014         Do not set httpStatus to SOUP_STATUS_OK when serving local files
3015         to match other ports' behavior, fixing xmlhttprequest test
3016         regressions.
3017
3018         * platform/network/soup/ResourceHandleSoup.cpp:
3019         (WebCore::queryInfoCallback):
3020
3021 2009-02-19  Dan Bernstein  <mitz@apple.com>
3022
3023         Reviewed by Sam Weinig.
3024
3025         - WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
3026           Do not send loader callbacks during CSS styling
3027
3028         Undo the iChat-specific quirk added in
3029         <http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
3030         cache client callbacks during attach() and recalcStyle().
3031
3032         * WebCore.base.exp: Removed
3033         Settings::setNeedsIChatMemoryCacheCallsQuirk().
3034         * dom/ContainerNode.cpp:
3035         (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory
3036         cache client callbacks and remember to enable them afterwards if needed.
3037         (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory
3038         cache client callbacks if they were disabled in
3039         suspendPostAttachCallbacks().
3040         (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and
3041         resumePostAttachCallbacks().
3042         * dom/ContainerNode.h: Made suspendPostAttachCallbacks()
3043         and resumePostAttachCallbacks() non-static.
3044         * dom/Document.cpp:
3045         (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific
3046         workaround.
3047         * page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and
3048         related code.
3049         (WebCore::Settings::Settings):
3050         * page/Settings.h:
3051
3052 2009-02-19  Holger Hans Peter Freyther  <zecke@selfish.org>
3053
3054         Unreviewed build fix.
3055
3056         Build fix after r41092. Make the memoryUsage method
3057         public. It will be shadowed by cf/mac and for curl/soup/qt
3058         the implementation from ResourceResponseBase will be used.
3059
3060         * platform/network/ResourceResponseBase.h:
3061         (WebCore::ResourceResponseBase::memoryUsage):
3062
3063 2009-02-19  Beth Dakin  <bdakin@apple.com>
3064
3065         Reviewed by Dave Hyatt.
3066
3067         Fix for <rdar://problem/6077775> Should be able to specify
3068         inactive ::selection color
3069
3070         This patch makes the ::selction pseudo-element work with
3071         the :window-inactive pseudo type. This was, a user can specify a
3072         different ::selection style when a window is inactive.
3073
3074         * css/CSSStyleSelector.cpp:
3075         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
3076         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3077         * rendering/RenderObject.cpp:
3078         (WebCore::RenderObject::selectionBackgroundColor):
3079         (WebCore::RenderObject::selectionForegroundColor):
3080
3081 2009-02-19  Sam Weinig  <sam@webkit.org>
3082
3083         Reviewed by Beth Dakin.
3084
3085         Patch for https://bugs.webkit.org/show_bug.cgi?id=24044
3086         Update querySelector/querySelectorAll to match the latest spec
3087
3088         Update querySelector and querySelectorAll to match the latest version
3089         of the Selectors API spec.  We now stringify null and undefined to "null"
3090         and "undefined" respectively instead of to "".
3091
3092         Test: fast/dom/SelectorAPI/undefined-null-stringify.html
3093
3094         * dom/Document.idl:
3095         * dom/DocumentFragment.idl:
3096         * dom/Element.idl:
3097
3098 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3099
3100         Reviewed by Geoffrey Garen.
3101
3102         https://bugs.webkit.org/show_bug.cgi?id=23732
3103         Rework CachedResource overhead accounting to allow platforms to diverge
3104         in numbers.
3105
3106         * loader/CachedResource.cpp:
3107         (WebCore::CachedResource::overheadSize): Changed to ask ResourceResponse
3108         for its size and to use actual URL size.
3109         * platform/network/ResourceResponseBase.h:
3110         (WebCore::ResourceResponseBase::size): Added default size method.
3111         * platform/network/cf/ResourceResponse.h:
3112         (WebCore::ResourceResponse::size): Added Win/CF size method
3113         * platform/network/mac/ResourceResponse.h:
3114         (WebCore::ResourceResponse::size): Added Mac size method.
3115
3116 2009-02-19  Anders Carlsson  <andersca@apple.com>
3117
3118         Reviewed by Kevin Decker.
3119
3120         - Fix for <rdar://problem/6604968>
3121
3122         On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
3123         after the call to -[NSView displayRectIgnoringOpacity:inContext:].
3124
3125         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
3126         (WebCore::MediaPlayerPrivate::paint):
3127
3128 2009-02-19  David Hyatt  <hyatt@apple.com>
3129
3130         Fix a bug where reflections didn't work properly if opacity was < 1.  Make sure that replaced elements
3131         also consider reflections to be part of their visual overflow.  This had already been done for blocks
3132         and lines, but it wasn't being done yet for replaced elements.
3133
3134         Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
3135         transparency layer early.  Since the reflected object paints twice, we don't want to end the transparency
3136         layer it pushed until we're done painting the real object (rather than the reflection).
3137
3138         Reviewed by Dan Bernstein
3139
3140         Added fast/reflections/reflection-masks-opacity.html
3141
3142         * rendering/RenderLayer.cpp:
3143         (WebCore::RenderLayer::paintLayer):
3144         * rendering/RenderPartObject.cpp:
3145         (WebCore::RenderPartObject::layout):
3146         * rendering/RenderReplaced.cpp:
3147         (WebCore::RenderReplaced::layout):
3148         (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect):
3149         * rendering/RenderReplaced.h:
3150
3151 2009-02-19  David Levin  <levin@chromium.org>
3152
3153         Reviewed by Alexey Proskuryakov.
3154
3155         Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode.
3156         <https://bugs.webkit.org/show_bug.cgi?id=23980>
3157
3158         WorkerRunLoop has the ability to run in a mode which filters the tasks to be run.
3159         * When WorkerRunLoop::runInMode is called, only task for that mode will run.
3160         * When WorkerRunLoop::run is called (or the default mode is used), then all tasks
3161           will run regardless of their posted mode.
3162
3163         Here's a demonstration of the api:
3164
3165             RefPtr<NameResolution> nameResolution = NameResolution::create(workerRunLoop);
3166
3167             //  Internally nameResolution will do workerRunLoop.postTaskForMode(task, "MyCoolMode")
3168             //  for any tasks that need to be run during this loop.
3169             nameResolution->setTaskMode("MyCoolMode");
3170
3171             nameResolution->start();
3172             while (!nameResolution->done()) {
3173                 // Only tasks which are posted for "MyCoolMode" will run.
3174                 workerRunLoop.runInMode(context, "MyCoolMode");
3175             }
3176
3177         No observable change in behavior, so no test.
3178
3179         * dom/WorkerRunLoop.cpp:
3180         (WebCore::ModePredicate::ModePredicate):
3181         (WebCore::ModePredicate::operator()):
3182         (WebCore::WorkerRunLoop::WorkerRunLoop):
3183         (WebCore::WorkerRunLoop::~WorkerRunLoop):
3184         (WebCore::WorkerRunLoop::setSharedTimer):
3185         (WebCore::WorkerRunLoop::resetSharedTimer):
3186         (WebCore::WorkerRunLoop::run):
3187         (WebCore::WorkerRunLoop::runInMode):
3188         (WebCore::WorkerRunLoop::postTask):
3189         (WebCore::WorkerRunLoop::postTaskForMode):
3190         * dom/WorkerRunLoop.h:
3191         (WebCore::WorkerRunLoop::Task::create):
3192         (WebCore::WorkerRunLoop::Task::mode):
3193         (WebCore::WorkerRunLoop::Task::performTask):
3194         (WebCore::WorkerRunLoop::Task::Task):
3195
3196 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3197
3198         Reviewed by Eric Seidel.
3199
3200         https://bugs.webkit.org/show_bug.cgi?id=24034
3201         Fix up Selection->VisibleSelection change.
3202
3203         * page/chromium/EventHandlerChromium.cpp:
3204         (WebCore::EventHandler::passMousePressEventToSubframe): Renamed Selection
3205         to VisibleSelection.
3206
3207 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3208
3209         Reviewed by Eric Seidel.
3210
3211         https://bugs.webkit.org/show_bug.cgi?id=24041
3212         Correct Skia type conversion issues, fix Chromium Linux build.
3213
3214         * platform/graphics/chromium/FontLinux.cpp:
3215         (WebCore::Font::drawGlyphs): changed parameters to RGBA32, not WebCore::Color.
3216
3217 2009-02-19  Jungshik Shin <jshin@chromium.org>
3218
3219         Reviewed by Eric Seidel.
3220
3221         https://bugs.webkit.org/show_bug.cgi?id=20531
3222         Chromium-part follow-up to the patch landed in r40636
3223         for bug 20531.
3224         Remove a static member function alternateFamilyName
3225         from Chromium's Win/Linux ports of FontCache. In r40636,
3226         alternateFamilyName was customized using #ifdef PLATFORM(WIN_OS).
3227         So, there's no more need for the static member function per
3228         platform.
3229
3230         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
3231         * platform/graphics/chromium/FontCacheLinux.cpp:
3232
3233 2009-02-19  Simon Fraser  <simon.fraser@apple.com>
3234
3235         Reviewed by Adele Peterson.
3236
3237         Call documentWillBecomeInactive() from Document::detach to ensure that
3238         media elements are shut down, because they may be kept alive by references
3239         from JS past document teardown.
3240
3241         documentWillBecomeInactive() calls  renderView()->willMoveOffscreen(), so no
3242         need to do that in detach() as well.
3243
3244         We no longer need to call documentWillBecomeInactive() from ~Page() (which
3245         was added for <https://bugs.webkit.org/show_bug.cgi?id=21116>), since this
3246         supersedes that change.
3247
3248         * dom/Document.cpp:
3249         (WebCore::Document::detach):
3250         * page/Page.cpp:
3251         (WebCore::Page::~Page):
3252
3253 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3254
3255         Reviewed by Eric Seidel.
3256
3257         https://bugs.webkit.org/show_bug.cgi?id=24028
3258         Fix up Skia path changes.
3259
3260         * platform/graphics/skia/GraphicsContextSkia.cpp:
3261         (WebCore::GraphicsContext::strokePath): Removed illegal indirection.
3262         * platform/graphics/skia/PathSkia.cpp:
3263         (WebCore::boundingBoxForCurrentStroke): Changed call name.
3264
3265 2009-02-19  Gustavo Noronha Silva  <gns@gnome.org>
3266
3267         Reviewed by Alexey Proskuryakov.
3268
3269         Ignore ports on local URLs. This fixes a regression in
3270         fast/loader/file-URL-with-port-number.html
3271
3272         * platform/network/soup/ResourceHandleSoup.cpp:
3273         (WebCore::ResourceHandle::startGio):
3274
3275 2009-02-19  Gustavo Noronha Silva  <gns@gnome.org>
3276
3277         Reviewed by Alexey Proskuryakov.
3278
3279         https://bugs.webkit.org/show_bug.cgi?id=24011
3280         KURL's setPort doesn't unset port if 0 is given
3281
3282         Make setPort remove port if 0 is given to it, as promised by the
3283         comment in KURL's header.
3284
3285         * platform/KURL.cpp:
3286         (WebCore::KURL::setPort):
3287
3288 2009-02-18  Dan Bernstein  <mitz@apple.com>
3289
3290         Reviewed by Brady Eidson.
3291
3292         - WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
3293
3294         The crash results from re-entry into
3295         CSSMutableStyleDeclaration::setCssText, which in turn is caused by
3296         the first style change causing a cached image to load from the memory
3297         cache, causing load delegate dispatch, and iChat's delegate method
3298         calling back into WebKit.
3299
3300         The workaround is to use defer delegate callbacks for memory cache. In
3301         this case, deferring callbacks during image load event dispatch was
3302         found to be sufficient.
3303
3304         The crash is a regression. See also the discussion in
3305         <https://bugs.webkit.org/show_bug.cgi?id=22521>.
3306
3307         * WebCore.base.exp: Added
3308         Settings::setNeedsIChatMemoryCacheCallsQuirk().
3309         * dom/Document.cpp:
3310         (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is
3311         enabled, defer memory cache callbacks during image load event dispatch.
3312         * page/Settings.cpp:
3313         (WebCore::Settings::Settings): Initialize
3314         m_needsIChatMemoryCacheCallsQuirk.
3315         (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this
3316         setter.
3317         * page/Settings.h:
3318         (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.
3319
3320 2009-02-18  Adam Roben  <aroben@apple.com>
3321
3322         Export WebCore::handCursor and Cursor.h
3323
3324         Reviewed by John Sullivan.
3325
3326         * WebCore.base.exp: Added WebCore::handCursor.
3327         * WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.
3328
3329 2009-02-18  Ojan Vafai  <ojan@chromium.org>
3330
3331         Reviewed by Alexey Proskuryakov.
3332
3333         https://bugs.webkit.org/show_bug.cgi?id=23992
3334         REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do
3335
3336         Unable to reduce to a layout test.
3337
3338         * page/Frame.cpp:
3339         (WebCore::Frame::contentRenderer):
3340
3341 2009-02-18  Evan Stade  <estade@chromium.org>
3342
3343         Reviewed by Eric Seidel.
3344
3345         https://bugs.webkit.org/show_bug.cgi?id=23861
3346         Stroke font outlines on chromium linux
3347
3348         TEST=LayoutTests/svg/custom/pointer-events-text.svg
3349
3350         * platform/graphics/chromium/FontLinux.cpp:
3351         (WebCore::Font::drawGlyphs):
3352
3353 2009-02-18  Evan Stade  <estade@chromium.org>
3354
3355         Reviewed by Eric Seidel.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=23860
3358         Resync some graphics/skia files with their chromium counterparts
3359
3360         This comes from chromium patches <http://codereview.chromium.org/17633>
3361         and <http://codereview.chromium.org/17454>
3362
3363         * platform/graphics/skia/GraphicsContextSkia.cpp:
3364         (WebCore::GraphicsContext::clipPath):
3365         (WebCore::GraphicsContext::fillPath):
3366         * platform/graphics/skia/PlatformContextSkia.cpp:
3367         (PlatformContextSkia::addPath):
3368         (PlatformContextSkia::currentPath):
3369         * platform/graphics/skia/PlatformContextSkia.h:
3370
3371 2009-02-18  Gustavo Noronha Silva  <gns@gnome.org>
3372
3373         Unreviewed.
3374
3375         Build fix after r41060.
3376
3377         * GNUmakefile.am:
3378
3379 2009-02-18  Dimitri Glazkov  <dglazkov@chromium.org>
3380
3381         Reviewed by Eric Seidel.
3382
3383         https://bugs.webkit.org/show_bug.cgi?id=24005
3384         Add an include to fix Chromium build.
3385
3386         * page/animation/AnimationController.cpp: Add UnusedParam.h include.
3387
3388 2009-02-18  Gustavo Noronha Silva  <gns@gnome.org>
3389
3390         Reviewed by Holger Freyther.
3391
3392         Fix symbols.filter location, and add other missing files to the
3393         autotools build, so that make dist works.
3394
3395         * GNUmakefile.am:
3396
3397 2009-02-18  Zan Dobersek  <zandobersek@gmail.com>
3398
3399         Rubber-stamped by Holger Hans Peter Freyther.
3400
3401         Allow POST method for local requests.
3402
3403         * platform/network/soup/ResourceHandleSoup.cpp:
3404         (WebCore::ResourceHandle::startGio):
3405
3406 2009-02-18  Gustavo Noronha Silva  <gns@gnome.org>
3407
3408         Reviewed by Holger Hans Peter Freyther.
3409
3410         Use KURL in startGio instead of passing a string with the URL, so
3411         that we can handle removing refs and queries more elegantly. This
3412         is fixing more regressions that came from the curl->soup switch.
3413
3414         Original work by Zan Dobersek.
3415
3416         * platform/network/ResourceHandle.h:
3417         * platform/network/soup/ResourceHandleSoup.cpp:
3418         (WebCore::ResourceHandle::start):
3419         (WebCore::ResourceHandle::startGio):
3420
3421 2009-02-18  Holger Hans Peter Freyther  <zecke@selfish.org>
3422
3423         Reviewed by Alexey Proskuryakov.
3424
3425         Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp
3426
3427         The implementation is needed to have synchronous loading, e.g. for
3428         JavaScript interaction. This is fixing various regressions that
3429         came from the curl->soup switch.
3430
3431         * platform/network/soup/ResourceHandleSoup.cpp:
3432         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
3433         (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
3434         (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
3435         (WebCore::WebCoreSynchronousLoader::didReceiveData):
3436         (WebCore::WebCoreSynchronousLoader::didFinishLoading):
3437         (WebCore::WebCoreSynchronousLoader::didFail):
3438         (WebCore::WebCoreSynchronousLoader::run):
3439         (WebCore::ResourceHandle::loadResourceSynchronously):
3440
3441 2009-02-18  Xan Lopez  <xan@gnome.org>
3442
3443         Reviewed by Mark Rowe.
3444
3445         https://bugs.webkit.org/show_bug.cgi?id=23989
3446
3447         Based on a patch by Bo Yang  <techrazy.yang@gmail.com>
3448
3449         Make the cursor cache global, that's all we really need and
3450         otherwise we can miss cursor transitions in some situations (see
3451         the bug for one testcase). Also remove some now useless code.
3452
3453         * platform/Widget.h:
3454         * platform/gtk/WidgetGtk.cpp:
3455         (WebCore::Widget::Widget):
3456         (WebCore::Widget::~Widget):
3457         (WebCore::Widget::setCursor):
3458
3459 2009-02-17  Adam Roben  <aroben@apple.com>
3460
3461         Windows build fix
3462
3463         * loader/FrameLoader.cpp:
3464         (WebCore::toPlugInElement): Don't rely on #if being processed before
3465         ASSERT.
3466
3467 2009-02-17  David Levin  <levin@chromium.org>
3468
3469         Reviewed by Alexey Proskuryakov.
3470
3471         Bug 23977: Unnecessary timer related headers in files.
3472         <https://bugs.webkit.org/show_bug.cgi?id=23977>
3473
3474         No observable change in behavior, so no test.
3475
3476         * dom/Document.cpp:
3477         * dom/WorkerRunLoop.cpp:
3478         * dom/WorkerRunLoop.h:
3479
3480 2009-02-17  Peter Abrahamsen  <rainhead@gmail.com>
3481
3482         Reviewed by Sam Weinig.
3483
3484         https://bugs.webkit.org/show_bug.cgi?id=23958
3485         <rdar://problem/6587815>
3486
3487         Updated XMLHttpRequest with new header names from the latest Access
3488         Control draft: http://www.w3.org/TR/access-control/
3489         - Access-Control-Origin becomes Access-Control-Allow-Origin
3490         - Access-Control-Credentials becomes Access-Control-Allow-Credentials
3491
3492         * xml/XMLHttpRequest.cpp:
3493         (WebCore::XMLHttpRequest::accessControlCheck):
3494
3495 2009-02-17  Kevin Ollivier  <kevino@theolliviers.com>
3496
3497         wx build fix. Add missing constructor used for empty values.
3498
3499         * platform/graphics/wx/FontPlatformData.h:
3500         (WebCore::FontPlatformData::FontPlatformData):
3501
3502 2009-02-17  Antti Koivisto  <antti@apple.com>
3503
3504         Reviewed by Dave Kilzer.
3505
3506         <rdar://problem/6592446> dynamically updating page doesn't seem to draw when updated
3507
3508         Need update after callback.
3509
3510         * bindings/js/JSCustomPositionCallback.cpp:
3511         (WebCore::JSCustomPositionCallback::handleEvent):
3512         * bindings/js/JSCustomPositionErrorCallback.cpp:
3513         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3514
3515 2009-02-17  Eric Carlson  <eric.carlson@apple.com>
3516
3517         Reviewed by Antti Koivisto.
3518
3519         https://bugs.webkit.org/show_bug.cgi?id=23917
3520         Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
3521         element.
3522
3523         * DerivedSources.make: add media element proxy exports to .exp file when feature is defined.
3524
3525         * WebCore.VideoProxy.exp: New, define the informal protocol exported by a media element proxy.
3526
3527         * WebCore.xcodeproj/project.pbxproj: Add MediaPlayerProxy.h.
3528
3529         * html/HTMLMediaElement.cpp:
3530         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_needWidgetUpdate.
3531         (WebCore::HTMLMediaElement::attributeChanged): Don't detach+attach when PLUGIN_PROXY_FOR_VIDEO, the
3532         proxy plug-in handles the poster frame.
3533         (WebCore::HTMLMediaElement::rendererIsNeeded): New logic for PLUGIN_PROXY_FOR_VIDEO.
3534         (WebCore::HTMLMediaElement::createRenderer): Create RenderPartObject when PLUGIN_PROXY_FOR_VIDEO.
3535         (WebCore::HTMLMediaElement::attach): Set m_needWidgetUpdate when PLUGIN_PROXY_FOR_VIDEO
3536         (WebCore::HTMLMediaElement::load): Don't reallocate MediaPlayer when PLUGIN_PROXY_FOR_VIDEO, we keep the
3537         same plug-in for the life of the element.
3538         (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): update m_networkState when media player
3539         network state changes to EMPTY, otherwise we can get out of sync with engine.
3540         (WebCore::HTMLMediaElement::defaultEventHandler): pass event to widget when PLUGIN_PROXY_FOR_VIDEO
3541         (WebCore::HTMLMediaElement::deliverNotification): New, deliver notification from proxy plug-in to
3542         media player.
3543         (WebCore::HTMLMediaElement::setMediaPlayerProxy): New, pass proxy object to media player.
3544         (WebCore::HTMLMediaElement::initialURL): New, return the url from the "src" attr or the appropriate
3545         <source> element to be used as the initial url for the proxy.
3546         (WebCore::HTMLMediaElement::finishParsingChildren): New, allocate MediaPlayer and update widget.
3547         * html/HTMLMediaElement.h: Declare new methods for proxy, add m_needWidgetUpdate.
3548         (WebCore::HTMLMediaElement::setNeedWidgetUpdate):
3549
3550         * html/HTMLVideoElement.cpp:
3551         (WebCore::HTMLVideoElement::attach): Poster image is handled by proxy when PLUGIN_PROXY_FOR_VIDEO.
3552         (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
3553         * html/HTMLVideoElement.h:
3554
3555         * loader/FrameLoader.cpp:
3556         (WebCore::toPlugInElement): Allow cast if element is <video> or <audio>
3557
3558         * platform/graphics/MediaPlayer.cpp:
3559         (WebCore::MediaPlayer::MediaPlayer): Remove white space.
3560         (WebCore::MediaPlayer::setPoster): New, forward call to private player.
3561         (WebCore::MediaPlayer::deliverNotification): Ditto.
3562         (WebCore::MediaPlayer::setMediaPlayerProxy): Ditto.
3563         * platform/graphics/MediaPlayer.h:
3564         (WebCore::MediaPlayer::mediaPlayerClient):
3565
3566         * platform/graphics/mac/MediaPlayerProxy.h: New, defines media player proxy interface.
3567
3568         * rendering/RenderPart.cpp:
3569         (WebCore::RenderPart::RenderPart): Change constructor to take Element* instead of Node* as a
3570         non-element node doesn't need a renderer
3571         * rendering/RenderPart.h: Ditto.
3572
3573         * rendering/RenderPartObject.cpp:
3574         (WebCore::RenderPartObject::RenderPartObject): Ditto.
3575         (WebCore::RenderPartObject::updateWidget): Package params for proxy plug-in when element is
3576         <video> or <audio>.
3577         * rendering/RenderPartObject.h:
3578
3579 2009-02-17  David Hyatt  <hyatt@apple.com>
3580
3581         Reviewed by Eric Seidel
3582
3583         Fix for https://bugs.webkit.org/show_bug.cgi?id=23985
3584
3585         Don't allow legends to be anything but display:block.
3586
3587         Added fast/forms/inline-ignored-on-legend.html
3588
3589         * GNUmakefile.am:
3590         * WebCore.pro:
3591         * WebCore.vcproj/WebCore.vcproj:
3592         * WebCore.xcodeproj/project.pbxproj:
3593         * WebCoreSources.bkl:
3594         * css/html4.css:
3595         * html/HTMLLegendElement.cpp:
3596         * html/HTMLLegendElement.h:
3597         * rendering/RenderLegend.cpp: Removed.
3598         * rendering/RenderLegend.h: Removed.
3599         * wml/WMLInsertedLegendElement.cpp:
3600         * wml/WMLInsertedLegendElement.h:
3601
3602 2009-02-13  Brett Wilson  <brettw@dhcp-172-22-71-167.mtv.corp.google.com>
3603
3604         Reviewed by Simon Fraser.
3605
3606         https://bugs.webkit.org/attachment.cgi?id=27666
3607         Fix Chromium build build: forgotten include in RenderObject, sync
3608         RenderTheme to the recent changes in RenderObject.
3609
3610         * rendering/RenderObject.cpp:
3611         * rendering/RenderThemeChromiumMac.mm:
3612         (WebCore::RenderThemeChromiumMac::updatePressedState):
3613
3614 2009-02-17  Gustavo Noronha Silva  <gns@gnome.org>
3615
3616         Reviewed by Darin Adler.
3617
3618         https://bugs.webkit.org/show_bug.cgi?id=22966
3619         crash when destroying a webview that opened a page containing <script>
3620         tags
3621
3622         Fix m_group being set to 0 instead of to m_singlePageGroup when
3623         GroupName is set to empty
3624
3625         * page/Page.cpp:
3626         (WebCore::Page::setGroupName):
3627
3628 2009-02-16  Beth Dakin  <bdakin@apple.com>
3629
3630         Reviewed by Sam Weinig.
3631
3632         Fix for <rdar://problem/6386623>
3633
3634         I made m_numParsedProperties and m_maxParsedProperties unsigned
3635         instead of int, and then added an early return from addPropery() if
3636         m_maxParsedProperties exceeds the max value.
3637
3638         * css/CSSParser.cpp:
3639         (WebCore::CSSParser::addProperty):
3640         (WebCore::CSSParser::rollbackLastProperties):
3641         (WebCore::CSSParser::clearProperties):
3642         (WebCore::CSSParser::createFontFaceRule):
3643         (WebCore::CSSParser::deleteFontFaceOnlyValues):
3644         * css/CSSParser.h:
3645
3646 2009-02-16  Justin Garcia  <justin.garcia@apple.com>
3647
3648         Reviewed by Mark Rowe.
3649
3650         https://bugs.webkit.org/show_bug.cgi?id=16309
3651         HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
3652
3653         When we originally implemented this command, MSDN documentation said that IE set the
3654         id attribute of inserted lists to the third argument to execCommand, but IE doesn't
3655         do this nor do any other browsers.
3656
3657         * editing/EditorCommand.cpp:
3658         (WebCore::executeInsertOrderedList):
3659         (WebCore::executeInsertUnorderedList):
3660         * editing/IndentOutdentCommand.cpp:
3661         (WebCore::IndentOutdentCommand::outdentParagraph):
3662         * editing/InsertListCommand.cpp:
3663         (WebCore::InsertListCommand::insertList):
3664         (WebCore::InsertListCommand::InsertListCommand):
3665         (WebCore::InsertListCommand::doApply):
3666         * editing/InsertListCommand.h:
3667         (WebCore::InsertListCommand::create):
3668
3669 2009-02-16  Dan Bernstein  <mitz@apple.com>
3670
3671         Reviewed by Geoffrey Garen.
3672
3673         - fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
3674
3675         Test: platform/mac/fast/events/pointer-events-dashboard.html
3676
3677         * css/CSSStyleSelector.cpp:
3678         (WebCore::CSSStyleSelector::applyProperty): Do not apply the
3679         pointer-events property in Dashboard backwards compatibility mode,
3680         in order to work around misuse of that property by the Stocks widget.
3681
3682 2009-02-16  Justin Garcia  <justin.garcia@apple.com>
3683
3684         Reviewed by Eric Seidel.
3685
3686         https://bugs.webkit.org/show_bug.cgi?id=15381
3687         execCommand justify modifies the contentEditable node
3688
3689         * editing/CompositeEditCommand.cpp:
3690         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just
3691         the body element, but any root editable element.
3692
3693 2009-02-16  Chris Fleizach  <cfleizach@apple.com>
3694
3695         Reviewed by Adele Peterson.
3696
3697         Bug 23979: AX: alt tag not returned for <input type="image">
3698         https://bugs.webkit.org/show_bug.cgi?id=23979
3699
3700         Test: accessibility/input-image-alt.html
3701
3702         * page/AccessibilityRenderObject.cpp:
3703         (WebCore::AccessibilityRenderObject::accessibilityDescription):
3704
3705 2009-02-16  Kevin Watters  <kevinwatters@gmail.com>
3706
3707         Reviewed by Kevin Ollivier.
3708
3709         The ref data is not properly set unless we use the CreateMatrix function.
3710
3711         https://bugs.webkit.org/show_bug.cgi?id=23978
3712
3713         * platform/graphics/wx/TransformationMatrixWx.cpp:
3714         (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
3715
3716 2009-02-16  Dan Bernstein  <mitz@apple.com>
3717
3718         Reviewed by John Sullivan.
3719
3720         - fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
3721
3722         * platform/graphics/FontCache.cpp:
3723         (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the
3724         FontPlatformData(float, bool, bool) constructor.
3725         * platform/graphics/mac/FontCacheMac.mm:
3726         (WebCore::FontCache::createFontPlatformData): Changed to pass a valid
3727         NSFont to the FontPlatformData constructor, instead of implicitly
3728         passing 0 and then calling setFont().
3729         * platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter
3730         of the constructor mandatory.
3731
3732 2009-02-15  David Kilzer  <ddkilzer@apple.com>
3733
3734         Move duplicate caretWidth constants to RenderObject.h
3735
3736         Reviewed by Dan Bernstein.
3737
3738         No test since no change in behavior.
3739
3740         * rendering/RenderBlock.cpp:
3741         (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
3742         * rendering/RenderBox.cpp:
3743         (WebCore::RenderBox::localCaretRect): Ditto.
3744         * rendering/RenderObject.h: Added caretWidth definition.
3745         * rendering/RenderText.cpp:
3746         (WebCore::RenderText::localCaretRect): Removed caretWidth.
3747
3748 2009-02-13  Dimitri Glazkov  <dglazkov@chromium.org>
3749
3750         Reviewed by Eric Seidel.
3751
3752         https://bugs.webkit.org/show_bug.cgi?id=23955
3753         V8HTMLPlugInCustom returns undefined, which fools interceptors.
3754
3755         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
3756         (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value.
3757         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
3758         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
3759         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
3760
3761 2009-02-13  Dimitri Glazkov  <dglazkov@chromium.org>
3762
3763         Reviewed by Eric Seidel.
3764
3765         https://bugs.webkit.org/show_bug.cgi?id=23954
3766         Add V8 custom bindings for CanvasRenderingContext2D.
3767
3768         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Added.
3769         (WebCore::toV8):
3770         (WebCore::toCanvasStyle):
3771         (WebCore::ACCESSOR_GETTER):
3772         (WebCore::ACCESSOR_SETTER):
3773
3774 2009-02-13  Anders Carlsson  <andersca@apple.com>
3775
3776         Reviewed by Darin Adler and Dan Bernstein.
3777
3778         <rdar://problem/6583187>
3779
3780         * page/NavigatorBase.cpp:
3781         Handle PPC64 and X86_64 as well.
3782
3783 2009-02-13  Darin Adler  <darin@apple.com>
3784
3785         Reviewed by Mark Rowe.
3786
3787         Fix broken tokenizer regression test that reflected a lifetime bug
3788         in the document.write optimization. The test failure was trivial to
3789         reproduce in COLLECT_ON_EVERY_ALLOCATION mode.
3790
3791         * bindings/js/JSHTMLDocumentCustom.cpp:
3792         (WebCore::documentWrite): Convert strings to String rather than passing
3793         the pointer and length to SegmentedString. The optimization is thus
3794         mostly gone. However, there are two ways to bring it back: 1) Apply
3795         the patch that makes UString and String share the same buffers.
3796         2) Add a UString feature to SegmentedString; simple to do but might
3797         risk slowing down normal document parsing.
3798
3799 2009-02-13  Adam Treat  <adam.treat@torchmobile.com>
3800
3801         Caught by Darin Adler.
3802
3803         No reason to check m_tokenizer twice for 0 in a row.
3804
3805         * dom/Document.cpp:
3806         (WebCore::Document::write):
3807
3808 2009-02-13  Lyon Chen  <lyon.chen@torchmobile.com>
3809
3810         Reviewed by Dave Hyatt.
3811
3812         Take into account y() + height() when calculating getLowerRightCorner.
3813
3814         * dom/ContainerNode.cpp:
3815         (WebCore::ContainerNode::getLowerRightCorner):
3816
3817 2009-02-13  Antti Koivisto  <antti@apple.com>
3818
3819         Reviewed by Dave Hyatt.
3820
3821         Most of this code was in RenderBox, restore the copyright lines.
3822
3823         * rendering/RenderBoxModelObject.cpp:
3824         * rendering/RenderBoxModelObject.h:
3825
3826 2009-02-13  David Hyatt  <hyatt@apple.com>
3827
3828         Get rid of printBoxDecorations, since it is dead code.
3829
3830         Reviewed by Dan Bernstein
3831
3832         * rendering/RenderObject.h:
3833
3834 2009-02-13  Adam Treat  <adam.treat@torchmobile.com>
3835
3836         Reviewed by Darin Adler.
3837
3838         https://bugs.webkit.org/show_bug.cgi?id=23952
3839         Add Document::write overload which takes a SegmentedString since this
3840         is what the tokenizer expects anyway.  Modified JSHTMLDocument so it once
3841         again calls Document::write instead of injecting the string directly into
3842         the tokenizer.  This ensures that all document.write's are funneled through
3843         one method again, but should still be just as fast for JSHTMLDocumentCustom.
3844
3845         * bindings/js/JSHTMLDocumentCustom.cpp:
3846         (WebCore::documentWrite):
3847         * dom/Document.cpp:
3848         (WebCore::Document::write):
3849         * dom/Document.h:
3850
3851 2009-02-13  David Hyatt  <hyatt@apple.com>
3852
3853         Reviewed by Simon Fraser
3854
3855         Remove updateWidgetPosition on RenderObject.  Change RenderView's set of widgets
3856         to have a tighter type: RenderWidget instead of RenderObject.  Devirtualize
3857         updateWidgetPosition, since all RenderWidgets (except for applets) are now
3858         RenderParts also.
3859
3860         * rendering/RenderObject.cpp:
3861         * rendering/RenderObject.h:
3862         * rendering/RenderPart.cpp:
3863         * rendering/RenderPart.h:
3864         * rendering/RenderView.cpp:
3865         (WebCore::RenderView::updateWidgetPositions):
3866         (WebCore::RenderView::addWidget):
3867         (WebCore::RenderView::removeWidget):
3868         * rendering/RenderView.h:
3869         * rendering/RenderWidget.cpp:
3870         (WebCore::RenderWidget::updateWidgetPosition):
3871         * rendering/RenderWidget.h:
3872
3873 2009-02-13  David Hyatt  <hyatt@apple.com>
3874
3875         Reviewed by Eric Seidel
3876
3877         Remove isEditable() on RenderObject.  It is dead code.
3878
3879         * rendering/RenderObject.cpp:
3880         * rendering/RenderObject.h:
3881
3882 2009-02-13  David Hyatt  <hyatt@apple.com>
3883
3884         Reviewed by Eric Seidel
3885
3886         Add isTextControl() to RenderObject.  Patch call sites thats asked isTextField() || isTextArea() to just use
3887         isTextControl() instead.
3888
3889         Add a toRenderTextControl converter for doing checked casting to RenderTextControls.
3890
3891         * dom/Document.cpp:
3892         (WebCore::Document::setFocusedNode):
3893         * dom/InputElement.cpp:
3894         (WebCore::InputElement::updateSelectionRange):
3895         * editing/ReplaceSelectionCommand.cpp:
3896         (WebCore::ReplacementFragment::ReplacementFragment):
3897         * editing/TextIterator.cpp:
3898         (WebCore::TextIterator::handleReplacedElement):
3899         * html/HTMLInputElement.cpp:
3900         (WebCore::HTMLInputElement::selectionStart):
3901         (WebCore::HTMLInputElement::selectionEnd):
3902         (WebCore::HTMLInputElement::setSelectionStart):
3903         (WebCore::HTMLInputElement::setSelectionEnd):
3904         (WebCore::HTMLInputElement::select):
3905         (WebCore::HTMLInputElement::defaultEventHandler):
3906         (WebCore::HTMLInputElement::selection):
3907         * html/HTMLTextAreaElement.cpp:
3908         (WebCore::HTMLTextAreaElement::selectionStart):
3909         (WebCore::HTMLTextAreaElement::selectionEnd):
3910         (WebCore::HTMLTextAreaElement::setSelectionStart):
3911         (WebCore::HTMLTextAreaElement::setSelectionEnd):
3912         (WebCore::HTMLTextAreaElement::select):
3913         (WebCore::HTMLTextAreaElement::setSelectionRange):
3914         (WebCore::HTMLTextAreaElement::appendFormData):
3915         (WebCore::HTMLTextAreaElement::updateValue):
3916         (WebCore::HTMLTextAreaElement::selection):
3917         * page/AccessibilityRenderObject.cpp:
3918         (WebCore::AccessibilityRenderObject::isNativeTextControl):
3919         (WebCore::AccessibilityRenderObject::text):
3920         (WebCore::AccessibilityRenderObject::selectedText):
3921         (WebCore::AccessibilityRenderObject::selectedTextRange):
3922         (WebCore::AccessibilityRenderObject::setSelectedTextRange):
3923         (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
3924         (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
3925         (WebCore::AccessibilityRenderObject::observableObject):
3926         * page/Frame.cpp:
3927         (WebCore::Frame::notifyRendererOfSelectionChange):
3928         * rendering/RenderObject.h:
3929         (WebCore::RenderObject::isTextControl):
3930         (WebCore::objectIsRelayoutBoundary):
3931         * rendering/RenderTextControl.h:
3932         (WebCore::RenderTextControl::isTextControl):
3933         (WebCore::toRenderTextControl):
3934         * rendering/TextControlInnerElements.cpp:
3935         (WebCore::TextControlInnerTextElement::defaultEventHandler):
3936         * wml/WMLInputElement.cpp:
3937         (WebCore::WMLInputElement::select):
3938         (WebCore::WMLInputElement::defaultEventHandler):
3939         (WebCore::WMLInputElement::isConformedToInputMask):
3940
3941 2009-02-13  David Hyatt  <hyatt@apple.com>
3942
3943         Get rid of isEdited/setEdited on RenderObject.  Devirtualize isEdited/setEdited on RenderTextControl.
3944         Callers were already asking if the renderer was a text field (or a text area), so it was especially
3945         pointless to waste a second virtual function call after making one just to determine the object type.
3946
3947         Reviewed by Simon Fraser
3948
3949         * dom/Document.cpp:
3950         (WebCore::Document::setFocusedNode):
3951         * html/HTMLInputElement.cpp:
3952         (WebCore::HTMLInputElement::defaultEventHandler):
3953         * rendering/RenderObject.h:
3954         * rendering/RenderTextControl.h:
3955         (WebCore::RenderTextControl::isEdited):
3956         (WebCore::RenderTextControl::setEdited):
3957
3958 2009-02-13  Scott Violet  <sky@google.com>
3959
3960         Reviewed by Eric Seidel.
3961
3962         https://bugs.webkit.org/show_bug.cgi?id=23934
3963         Skia platform doesn't render text decoration shadows.
3964
3965         Makes Skia render text decoration shadows correctly. We weren't
3966         preparing the SkPaint correctly and didn't have a couple of checks
3967         CG has. Additionally makes the fillColor/strokeColor methods
3968         consistent.
3969
3970         This behavior is covered by existing layout tests (see bug for list).
3971
3972         * platform/graphics/chromium/FontChromiumWin.cpp:
3973         (WebCore::Font::drawGlyphs):
3974         (WebCore::Font::drawComplexText):
3975         * platform/graphics/skia/GraphicsContextSkia.cpp:
3976         (WebCore::GraphicsContext::drawLineForText):
3977         * platform/graphics/skia/PlatformContextSkia.cpp:
3978         (PlatformContextSkia::effectiveFillColor):
3979         (PlatformContextSkia::effectiveStrokeColor):
3980         * platform/graphics/skia/PlatformContextSkia.h:
3981
3982 2009-02-12  Darin Fisher  <darin@chromium.org>
3983
3984         Reviewed by Eric Seidel.
3985
3986         https://bugs.webkit.org/show_bug.cgi?id=23944
3987         KURLGoogle's pre-parsed canonicalSpec constructor should take a CString
3988
3989         * platform/KURL.h:
3990         * platform/KURLGoogle.cpp:
3991         (WebCore::KURLGooglePrivate::setUtf8):
3992         (WebCore::KURLGooglePrivate::setAscii):
3993         (WebCore::KURLGooglePrivate::init):
3994         (WebCore::KURLGooglePrivate::replaceComponents):
3995         (WebCore::KURL::KURL):
3996         * platform/KURLGooglePrivate.h:
3997
3998 2009-02-13  David Hyatt  <hyatt@apple.com>
3999
4000         Remove leftmost/rightmost/lowestPosition from RenderObject.  They only need to be called on boxes.
4001
4002         Reviewed by Dan Bernstein
4003
4004         * rendering/RenderBlock.cpp:
4005         (WebCore::RenderBlock::lowestPosition):
4006         (WebCore::RenderBlock::rightmostPosition):
4007         (WebCore::RenderBlock::leftmostPosition):
4008         * rendering/RenderLayer.cpp:
4009         (WebCore::RenderLayer::computeScrollDimensions):
4010         * rendering/RenderMedia.cpp:
4011         (WebCore::RenderMedia::lowestPosition):
4012         (WebCore::RenderMedia::rightmostPosition):
4013         (WebCore::RenderMedia::leftmostPosition):
4014         * rendering/RenderObject.h:
4015         * rendering/RenderTableSection.cpp:
4016         (WebCore::RenderTableSection::lowestPosition):
4017         (WebCore::RenderTableSection::rightmostPosition):
4018         (WebCore::RenderTableSection::leftmostPosition):
4019
4020 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
4021
4022         Fix build with ACCELERATED_COMPOSITING turned on.
4023
4024         toRenderBox()->x() asserts for a layer on an inline; use
4025         m_owningLayer->renderBoxX() instead.
4026
4027         * rendering/RenderLayerBacking.cpp:
4028         (WebCore::RenderLayerBacking::paintIntoLayer):
4029
4030 2009-02-12  Darin Adler  <darin@apple.com>
4031
4032         Reviewed by Oliver Hunt.
4033
4034         Speed up document.write a bit.
4035
4036         * bindings/js/JSHTMLDocumentCustom.cpp:
4037         (WebCore::documentWrite): Added. Uses SegmentedString to avoid conversion from
4038         UString to String and to avoid appending strings. Also added code to handle
4039         newlines efficiently.
4040         (WebCore::JSHTMLDocument::write): Changed to use documentWrite.
4041         (WebCore::JSHTMLDocument::writeln): Ditto.
4042
4043         * dom/Document.cpp:
4044         (WebCore::Document::prepareToWrite): Added. Refactored the initialization part
4045         of write into a separate function for use in the JavaScript binding.
4046         (WebCore::Document::write): Changed to call prepareToWrite.
4047
4048         * dom/Document.h: Added declaration for prepareToWrite.
4049
4050 2009-02-13  Prasanth Ullattil  <pullatti@trolltech.com>
4051
4052         Reviewed by Simon Hausmann.
4053
4054         Fixes crash in the Qt port on Windows with comboboxes
4055
4056         The focusWidget in the input context is not reset properly.
4057         The QApplication::setFocusWidget() wont reset the IC if the reason is
4058         PopupFocusReason, this is not ideal. For the time being we are going
4059         to do this from webkit itself.
4060
4061         * platform/qt/QWebPopup.cpp:
4062         (WebCore::QWebPopup::hidePopup):
4063
4064 2009-02-12  Kevin Ollivier  <kevino@theolliviers.com>
4065
4066         wx build fix, typo while tweaking last patch for commit.
4067
4068         * platform/wx/wxcode/gtk/fontprops.cpp:
4069         (GetTextExtent):
4070
4071 2009-02-12  miggilin  <mr.diggilin@gmail.com>
4072
4073         Reviewed by Kevin Ollivier.
4074
4075         Use Cairo/PANGO to fix text measurements and implement proper
4076         non-kerned text drawing on wxGTK.
4077
4078         https://bugs.webkit.org/show_bug.cgi?id=17727
4079
4080         * platform/graphics/GlyphBuffer.h:
4081         * platform/graphics/wx/FontPlatformDataWx.cpp:
4082         (WebCore::fontWeightToWxFontWeight):
4083         * platform/graphics/wx/SimpleFontDataWx.cpp:
4084         (WebCore::SimpleFontData::platformWidthForGlyph):
4085         * platform/wx/wxcode/fontprops.h:
4086         * platform/wx/wxcode/gtk/fontprops.cpp:
4087         (wxFontProperties::wxFontProperties):
4088         (GetTextExtent):
4089         * platform/wx/wxcode/gtk/non-kerned-drawing.cpp:
4090         (WebCore::pangoFontMap):
4091         (WebCore::createPangoFontForFont):
4092         (WebCore::createScaledFontForFont):
4093         (WebCore::pango_font_get_glyph):
4094         (WebCore::drawTextWithSpacing):
4095         * platform/wx/wxcode/non-kerned-drawing.h:
4096
4097 2009-02-12  Chris Marrin  <cmarrin@apple.com>
4098
4099         Reviewed by Simon Fraser
4100
4101         https://bugs.webkit.org/show_bug.cgi?id=23942
4102
4103         Hook up 3D CSS transforms to the accelerated compositor backend.
4104         Not enabled by default.
4105
4106         * page/animation/AnimationBase.cpp:
4107         (WebCore::blendFunc):
4108         (WebCore::ensurePropertyMap):
4109         * page/animation/CompositeAnimation.cpp:
4110         (WebCore::CompositeAnimationPrivate::updateTransitions):
4111         * page/animation/ImplicitAnimation.cpp:
4112         (WebCore::ImplicitAnimation::willNeedService):
4113         * page/animation/KeyframeAnimation.cpp:
4114         (WebCore::KeyframeAnimation::willNeedService):
4115         * platform/graphics/GraphicsLayer.cpp:
4116         (WebCore::GraphicsLayer::TransformValueList::makeFunctionList):
4117         (WebCore::GraphicsLayer::dumpProperties):
4118         * platform/graphics/mac/GraphicsLayerCA.mm:
4119         (WebCore::copyTransform):
4120         (WebCore::getValueFunctionNameForTransformOperation):
4121         (WebCore::GraphicsLayerCA::animateTransform):
4122         * rendering/RenderBox.cpp:
4123         (WebCore::RenderBox::updateBoxModelInfoFromStyle):
4124         * rendering/RenderLayer.cpp:
4125         (WebCore::RenderLayer::updateTransform):
4126         (WebCore::RenderLayer::hasTransformStyle3D):
4127         (WebCore::RenderLayer::hasPerspective):
4128         (WebCore::RenderLayer::perspectiveTransform):
4129         * rendering/RenderLayer.h:
4130         * rendering/RenderLayerBacking.cpp:
4131         (WebCore::RenderLayerBacking::updateGraphicsLayers):
4132         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
4133         (WebCore::RenderLayerBacking::computeTransformOrigin):
4134         (WebCore::RenderLayerBacking::computePerspectiveOrigin):
4135         * rendering/RenderLayerBacking.h:
4136         * rendering/RenderLayerCompositor.cpp:
4137         (WebCore::RenderLayerCompositor::has3DContent):
4138         (WebCore::requiresCompositingLayerForTransform):
4139         (WebCore::RenderLayerCompositor::requiresCompositingLayer):
4140         (WebCore::RenderLayerCompositor::layerHas3DContent):
4141         * rendering/RenderLayerCompositor.h:
4142
4143 2009-02-12  David Hyatt  <hyatt@apple.com>
4144
4145         Reviewed by Eric Seidel
4146
4147         Get rid of containingBlockHeight(), since it had only one implementation (despite being virtual) and just returned
4148         containingBlock()->availableHeight().  The latter reads better anyway.  Rename containingBlockWidth() to
4149         containingBlockWidthForContent() and move it to RenderBoxModelObject.
4150
4151         * rendering/RenderBlock.cpp:
4152         (WebCore::RenderBlock::localCaretRect):
4153         * rendering/RenderBox.cpp:
4154         (WebCore::RenderBox::containingBlockWidthForContent):
4155         (WebCore::RenderBox::calcWidth):
4156         (WebCore::RenderBox::calcReplacedWidthUsing):
4157         * rendering/RenderBox.h:
4158         * rendering/RenderBoxModelObject.cpp:
4159         (WebCore::RenderBoxModelObject::relativePositionOffsetX):
4160         (WebCore::RenderBoxModelObject::relativePositionOffsetY):
4161         (WebCore::RenderBoxModelObject::containingBlockWidthForContent):
4162         * rendering/RenderBoxModelObject.h:
4163         * rendering/RenderInline.cpp:
4164         (WebCore::RenderInline::marginLeft):
4165         (WebCore::RenderInline::marginRight):
4166         * rendering/RenderObject.cpp:
4167         * rendering/RenderObject.h:
4168         * rendering/RenderSVGContainer.cpp:
4169         (WebCore::RenderSVGContainer::calcReplacedWidth):
4170
4171 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
4172
4173         Fix non-Mac builds by adding Matrix3DTransformOperation.* and
4174         PerspectiveTransformOperation.*. Cleaned out some cruft in
4175         the WebCore.vcproj fle.
4176
4177         * GNUmakefile.am:
4178         * WebCore.pro:
4179         * WebCore.scons:
4180         * WebCore.vcproj/WebCore.vcproj:
4181
4182 2009-02-12  David Smith  <catfish.man@gmail.com>
4183
4184         Reviewed by Dave Hyatt.
4185
4186         Fix https://bugs.webkit.org/show_bug.cgi?id=23935
4187         Nested :not() and non-simple selectors in :not() should be invalid
4188
4189         * css/CSSGrammar.y: Reject nested :not()
4190         * css/CSSStyleSelector.cpp:
4191         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ASSERT() rather than checking, since the parser enforces it now
4192
4193 2009-02-12  Kevin Ollivier  <kevino@theolliviers.com>
4194
4195         wx build fixes.
4196
4197         * WebCoreSources.bkl:
4198
4199 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
4200
4201         Fix build with ACCELERATED_COMPOSITING turned on.
4202
4203         Need to cast toRenderBox() in order to call overflowClipRect().
4204
4205         * rendering/RenderLayerBacking.cpp:
4206         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
4207
4208 2009-02-12  Oliver Hunt  <oliver@apple.com>
4209
4210         Reviewed by NOBODY (Build fix).
4211
4212         Fix windows build.
4213
4214         * css/CSSParser.h:
4215
4216 2009-02-12  David Hyatt  <hyatt@apple.com>
4217
4218         Rename getOverflowClipRect and getClipRect to overflowClipRect and clipRect.  Move them to RenderBox, since these methods
4219         only apply to boxes.  Devirtualize clipRect, since it was not subclassed.  Move controlClip stuff to RenderBox also.
4220
4221         Reviewed by Simon Fraser
4222
4223         * editing/Editor.cpp:
4224         (WebCore::Editor::insideVisibleArea):
4225         * rendering/RenderBox.cpp:
4226         (WebCore::RenderBox::overflowClipRect):
4227         (WebCore::RenderBox::clipRect):
4228         * rendering/RenderBox.h:
4229         (WebCore::RenderBox::hasControlClip):
4230         (WebCore::RenderBox::controlClipRect):
4231         * rendering/RenderForeignObject.cpp:
4232         (WebCore::RenderForeignObject::paint):
4233         * rendering/RenderLayer.cpp:
4234         (WebCore::RenderLayer::calculateClipRects):
4235         (WebCore::RenderLayer::calculateRects):
4236         * rendering/RenderLayerBacking.cpp:
4237         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
4238         * rendering/RenderObject.h:
4239         (WebCore::RenderObject::hasClip):
4240         (WebCore::RenderObject::hasOverflowClip):
4241         * rendering/RenderTable.cpp:
4242         (WebCore::RenderTable::overflowClipRect):
4243         * rendering/RenderTable.h:
4244
4245 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
4246
4247         Fix build with ACCELERATED_COMPOSITING turned on (simple copy/paste error)
4248
4249         * platform/graphics/mac/GraphicsLayerCA.mm:
4250         (WebCore::GraphicsLayerCA::setBasicAnimation):
4251
4252 2009-02-12  Julien Chaffraix  <jchaffraix@webkit.org>
4253
4254         Not reviewed.
4255
4256         Release build fix when VIDEO is disabled (it should also
4257         help the builds with WORKERS or XSLT disabled).
4258
4259         * bindings/js/JSDOMWindowBase.cpp:
4260         (jsDOMWindowBaseAudio): Added an UNUSED_PARAM for exec and slot when
4261         VIDEO is disabled.
4262         (jsDOMWindowBaseWorker): Ditto for WORKERS.
4263         (jsDOMWindowBaseXSLTProcessor): Ditto for XSLT.
4264
4265 2009-02-12  Eric Carlson  <eric.carlson@apple.com>
4266
4267         Reviewed by Simon Fraser.
4268
4269         https://bugs.webkit.org/show_bug.cgi?id=23923
4270         Implement mediaPlayerVolumeChanged so a media engine can report autonomous volume changes.
4271         Supporting this requires that we know when we are processing a media engine callback so
4272         we don't turn around and tell the media player to change the volume when it is reporting
4273         a volume change.
4274
4275         * html/HTMLMediaElement.cpp:
4276         (WebCore::HTMLMediaElement::HTMLMediaElement): initialize m_processingMediaPlayerCallback
4277         (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): call begin/endProcessingMediaPlayerCallback
4278         (WebCore::HTMLMediaElement::setNetworkState): logic split out of mediaPlayerNetworkStateChanged
4279         to make it easier to maintain m_processingMediaPlayerCallback.
4280         (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): call begin/endProcessingMediaPlayerCallback
4281         (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
4282         (WebCore::HTMLMediaElement::mediaPlayerRepaint): Ditto.
4283         (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): New
4284         (WebCore::HTMLMediaElement::updateVolume): Don't change media engine volume if we are processing
4285         a callback from the engine.