Reviewed by Darin
[WebKit-https.git] / WebCore / ChangeLog
1 2006-12-05  John Sullivan  <sullivan@apple.com>
2
3         Reviewed by Darin
4
5         Grammar/Spelling code re-homing, baby step one: put isGrammarCheckingEnabled in Editor
6         since that's where isContinousSpellCheckingEnabled lives.
7
8         * editing/Editor.h:
9         * editing/Editor.cpp:
10         (WebCore::Editor::isGrammarCheckingEnabled):
11         new method, calls through to client a la isContinuousSpellCheckingEnabled
12
13         * bridge/mac/FrameMac.mm:
14         (WebCore::FrameMac::advanceToNextMisspelling):
15         call editor() rather than editor()->client()
16         (WebCore::FrameMac::markMisspellings):
17         ditto
18
19         * platform/ContextMenu.cpp:
20         (WebCore::ContextMenu::populate):
21         ditto
22
23 2006-12-05  Darin Adler  <darin@apple.com>
24
25         Reviewed by Geoff.
26
27         - a little cleanup
28
29         * html/HTMLInputElement.h: Removed unneeded includes of RenderObject.h
30         and RenderStyle.h.
31         * html/HTMLSelectElement.h: Removed unneeded include of RenderStyle.h.
32         * ksvg2/svg/SVGStyledElement.h: Removed unneeded include of RenderStyle.h.
33
34         * ksvg2/svg/SVGSVGElement.h: Remove unneeded parameter to createSVGPoint.
35         * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGPoint):
36         Ditto.
37
38         * ksvg2/scripts/generateJSBindings.pl: Removed unused script.
39
40 2006-12-05  Darin Adler  <darin@apple.com>
41
42         * doc: Removed empty directory. It's not clear this is a good place for
43         documentation, so lets add it back later if we actually start using it.
44
45 2006-12-05  Anders Carlsson  <acarlsson@apple.com>
46
47         Reviewed by Brady, Darin.
48
49         * loader/loader.cpp:
50         (WebCore::Loader::receivedAllData):
51         Remove ref() call that was left around by mistake.
52
53 2006-12-05  Sam Weinig  <sam@webkit.org>
54
55         Reviewed by Tim H.
56
57         Fix for http://bugs.webkit.org/show_bug.cgi?id=11758
58         Don't compile custom SVG and XSLT bindings in non-svg build
59
60         * bindings/js/JSSVGNumber.cpp:
61         * bindings/js/JSSVGNumber.h:
62         * bindings/js/JSSVGPoint.cpp:
63         * bindings/js/JSSVGPoint.h:
64         * bindings/js/JSSVGRect.cpp:
65         * bindings/js/JSSVGRect.h:
66         * bindings/js/JSXSLTProcessor.cpp:
67         * bindings/js/JSXSLTProcessor.h:
68
69 2006-12-04  John Sullivan  <sullivan@apple.com>
70
71         Reviewed by Darin
72
73         WebCore part of fix for:
74         <rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"
75
76         The context menu mechanism is currently in flux; the old mechanism is still in place, but an
77         up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
78         test the new mechanism because it doesn't work well enough yet. Also, some of this code 
79         should move from Frame to Editor, but that will wait for another checkin.
80
81         * page/Frame.h:
82         added pure virtual function declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()
83
84         * bridge/mac/FrameMac.h:
85         added virtual functions declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()
86
87         * bridge/mac/FrameMac.mm:
88         (WebCore::FrameMac::isSelectionMisspelled):
89         now updates spelling panel (whether or not it's showing), since this is now needed to make -[NSSSpellChecker
90         ignoreWord:inSpellDocumentWithTag:] work correctly
91         (WebCore::isRangeUngrammatical):
92         new function, helper used by both isSelectionUngrammatical() and guessesForUngrammaticalSelection()
93         (WebCore::FrameMac::isSelectionUngrammatical):
94         new function, calls isRangeUngrammatical
95         (WebCore::FrameMac::guessesForUngrammaticalSelection):
96         ditto
97
98         * platform/ContextMenu.cpp:
99         (WebCore::ContextMenu::populate):
100         now considers bad grammar as well as misspellings
101         
102         * platform/ContextMenuItem.h:
103         added ContextMenuItemTagIgnoreGrammar
104         
105 2006-12-05  Kirby White  <KWhiteRight@gmail.com>
106
107         Reviewed, tweaked and landed by Alexey.
108
109         <http://bugs.webkit.org/show_bug.cgi?id=11639> Form buttons don't look different when clicked
110
111         * rendering/RenderThemeWin.cpp:
112         (WebCore::RenderThemeWin::determineState): Moved test for active 
113         state before test for hover state, since active should override hover 
114         when both are true.
115
116         * platform/gdk/RenderThemeGdk.cpp: 
117         (WebCore::RenderThemeGdk::determineState): Same fix.
118
119 2006-12-05  Kirby White  <KWhiteRight@gmail.com>
120
121         Reviewed and landed by Alexey.
122
123         http://bugs.webkit.org/show_bug.cgi?id=11681
124         Don't select the first option when resetting a listbox-style form 
125         control (i.e., a multi-select control or one with size > 1) that
126         has no default selection.
127
128         Test: fast/dom/HTMLSelectElement/listbox-select-reset.html
129
130         * html/HTMLSelectElement.cpp:
131         (WebCore::HTMLSelectElement::reset):
132
133 2006-12-05  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
134
135         Reviewed and landed by Alexey.
136
137         http://bugs.webkit.org/show_bug.cgi?id=11752
138         [CSS 3] missing support for cursor selector 'copy'
139
140         * Resources/copyCursor.png: Added.
141         * WebCore.xcodeproj/project.pbxproj:
142         * css/CSSComputedStyleDeclaration.cpp:
143         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
144         * css/CSSValueKeywords.in:
145         * manual-tests/cursor.html:
146         * page/EventHandler.cpp:
147         (WebCore::selectCursor):
148         * platform/Cursor.h:
149         * platform/mac/CursorMac.mm:
150         (WebCore::copyCursor):
151         * rendering/RenderStyle.h:
152         (WebCore::):
153
154 2006-12-04  Beth Dakin  <bdakin@apple.com>
155
156         Reviewed by Geoff.
157
158         Fix from last check-in. This line was badbad.
159
160         * platform/mac/ContextMenuMac.mm:
161         (WebCore::ContextMenu::~ContextMenu):
162
163 2006-12-04  Beth Dakin  <bdakin@apple.com>
164
165         Reviewed by Geoff.
166
167         With the new changes to ContextMenuItems, WebCore context menus 
168         stopped appearing at all. And then when I got them to appear, they 
169         crashed. This fixes both of these problems.
170
171         * platform/mac/ContextMenuItemMac.mm:
172         (WebCore::ContextMenuItem::ContextMenuItem): keyEquivalent cannot 
173         be nil. This was causing Obj-C to throw an exception preventing the 
174         menus from popping up at all. 
175         * platform/mac/ContextMenuMac.mm:
176         (+[WebCoreMenuTarget sharedMenuTarget]): Re-name our static 
177         MenuTarget so that it is more clear that it is a static and shared 
178         WebCoreMenuTarget.
179         (WebCore::ContextMenu::ContextMenu): Initialize the 
180         WebCoreMenuTarget's controller in the ContextMenu constructor 
181         instead of in getNSMenuItem since the controller will only possibly 
182         change when a new ContextMenu has been created.
183         (WebCore::ContextMenu::~ContextMenu): Set the target's controller 
184         to 0.
185         (WebCore::getNSMenuItem): A lot of this work is being done other 
186         places now. Call new class method on WebCoreMenuTarget to get the 
187         shared target.
188         (WebCore::ContextMenu::appendItem): We should not be releasing the 
189         menuItem here! This caused the crashes I saw.
190         (WebCore::ContextMenu::insertItem): Same.
191
192 2006-12-04  Anders Carlsson  <acarlsson@apple.com>
193
194         Fix the build.
195         
196         * loader/mac/SubresourceLoaderMac.mm:
197         (WebCore::SubresourceLoader::~SubresourceLoader):
198         Add back the destructor.
199
200 2006-12-04  Anders Carlsson  <acarlsson@apple.com>
201
202         Reviewed by Darin.
203         
204         Change all ResourceHandleClients to be SubresourceLoaderClients instead. Also,
205         make SubresourceLoader a ResourceHandleClient. This is a first step towards turning ResourceHandle into a 
206         standalone class which doesn't need to know about SubresourceLoader.
207
208         * WebCore.xcodeproj/project.pbxproj:
209         * loader/ResourceLoader.cpp:
210         (WebCore::ResourceLoader::~ResourceLoader):
211         (WebCore::ResourceLoader::ResourceLoader):
212         (WebCore::ResourceLoader::setDefersLoading):
213         * loader/SubresourceLoader.cpp:
214         (WebCore::SubresourceLoader::SubresourceLoader):
215         (WebCore::SubresourceLoader::~SubresourceLoader):
216         (WebCore::SubresourceLoader::create):
217         (WebCore::SubresourceLoader::willSendRequest):
218         (WebCore::SubresourceLoader::didReceiveResponse):
219         (WebCore::SubresourceLoader::didReceiveData):
220         (WebCore::SubresourceLoader::didFinishLoading):
221         (WebCore::SubresourceLoader::didFailWithError):
222         (WebCore::SubresourceLoader::receivedAllData):
223         * loader/SubresourceLoader.h:
224         (WebCore::SubresourceLoader::loaderAsResourceHandleClient):
225         (WebCore::SubresourceLoader::handle):
226         * loader/SubresourceLoaderClient.h: Added.
227         (WebCore::SubresourceLoaderClient::~SubresourceLoaderClient):
228         (WebCore::SubresourceLoaderClient::willSendRequest):
229         (WebCore::SubresourceLoaderClient::didReceiveResponse):
230         (WebCore::SubresourceLoaderClient::didReceiveData):
231         (WebCore::SubresourceLoaderClient::didFinishLoading):
232         (WebCore::SubresourceLoaderClient::didFailWithError):
233         (WebCore::SubresourceLoaderClient::receivedAllData):
234         * loader/icon/IconLoader.cpp:
235         (WebCore::IconLoader::startLoading):
236         (WebCore::IconLoader::stopLoading):
237         (WebCore::IconLoader::didReceiveResponse):
238         (WebCore::IconLoader::didReceiveData):
239         (WebCore::IconLoader::didFailWithError):
240         (WebCore::IconLoader::didFinishLoading):
241         (WebCore::IconLoader::clearLoadingState):
242         * loader/icon/IconLoader.h:
243         * loader/loader.cpp:
244         (WebCore::Loader::servePendingRequests):
245         (WebCore::Loader::receivedAllData):
246         (WebCore::Loader::didFailWithError):
247         (WebCore::Loader::didReceiveResponse):
248         (WebCore::Loader::didReceiveData):
249         (WebCore::Loader::cancelRequests):
250         * loader/loader.h:
251         * loader/mac/SubresourceLoaderMac.mm:
252         (WebCore::SubresourceLoader::SubresourceLoader):
253         (WebCore::SubresourceLoader::create):
254         (WebCore::SubresourceLoader::willSendRequest):
255         (WebCore::SubresourceLoader::didReceiveResponse):
256         (WebCore::SubresourceLoader::didReceiveData):
257         (WebCore::SubresourceLoader::didFinishLoading):
258         (WebCore::SubresourceLoader::didFail):
259         (WebCore::SubresourceLoader::didCancel):
260         * platform/network/ResourceHandle.cpp:
261         (WebCore::ResourceHandle::ResourceHandle):
262         (WebCore::ResourceHandle::create):
263         * platform/network/ResourceHandle.h:
264         * platform/network/ResourceHandleClient.h:
265         * platform/network/ResourceHandleInternal.h:
266         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
267         * platform/network/mac/ResourceHandleMac.mm:
268         (WebCore::ResourceHandle::start):
269         (WebCore::ResourceHandle::finishJobAndHandle):
270         (WebCore::ResourceHandle::loader):
271         * xml/xmlhttprequest.cpp:
272         (WebCore::XMLHttpRequest::send):
273         (WebCore::XMLHttpRequest::didFailWithError):
274         (WebCore::XMLHttpRequest::didFinishLoading):
275         (WebCore::XMLHttpRequest::willSendRequest):
276         (WebCore::XMLHttpRequest::didReceiveResponse):
277         (WebCore::XMLHttpRequest::didReceiveData):
278         * xml/xmlhttprequest.h:
279
280 2006-12-04  Darin Adler  <darin@apple.com>
281
282         Reviewed by Adele.
283
284         - fix another part of http://bugs.webkit.org/show_bug.cgi?id=11628
285           REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window
286
287         This fixes command-return when the focus is on a link.
288         Despite the title of the bug, Mitz wanted me to fix both, and I will not
289         say no to him!
290
291         Test: fast/events/simulated-key-state.html
292
293         * dom/EventTargetNode.cpp:
294         (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Instead of always passing
295         false for all the key state in simulated mouse events, pass the state from the
296         first underlying event in the chain that has key state; in the case in the bug,
297         the keyboard event will be the underlying event itself and we'll propagate the
298         alt key modifier to the mouse event, resulting in the effect we want. It's nice
299         that JavaScript also gets to see the proper modifiers in the mouse event.
300
301         * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
302         Added code to pass in an underlying event to dispatchSimulatedClick. After looking
303         at all the other callers, this seems to be the only one that needs to pass an
304         event that is currently passing 0. Also removed the code that only simulated a
305         click when the event has a PlatformKeyboardEvent -- no reason for that and it
306         prevented me from writing a layout test for the fix. 
307
308         * dom/UIEventWithKeyState.h: Added findEventWithKeyState function that walks the
309         underlyingEvent chain to find the first event that has key state. This already
310         existed in WebKit, but I wanted to use it in dispatchSimulatedMouseEvent.
311         * dom/UIEventWithKeyState.cpp: Added.
312
313         * CMakeLists.txt: Added UIEventWithKeyState.cpp.
314         * WebCore.vcproj/WebCore/WebCore.vcproj: Added UIEventWithKeyState.cpp.
315         * WebCore.xcodeproj/project.pbxproj: Added UIEventWithKeyState.cpp.
316         * WebCoreSources.bkl: Added UIEventWithKeyState.cpp.
317
318         * WebCore.exp: Added findEventWithKeyState, used by WebKit.
319
320 2006-12-04  Kevin McCullough  <KMcCullough@apple.com>
321
322         Reviewed by Darin.
323
324         - removed the guards for the "multiple forms submission" issue, which may not be
325           an issue anymore and the guards prevent perfectly legitimate websites from
326           working correctly.
327
328         * bridge/mac/FrameMac.mm:
329         (WebCore::FrameMac::setView):
330         * bridge/mac/WebCoreAXObject.mm:
331         (-[WebCoreAXObject accessibilityPerformAction:]):
332         * bridge/win/FrameWin.cpp:
333         (WebCore::FrameWin::keyPress):
334         * config.h:
335         * loader/FrameLoader.cpp:
336         (WebCore::FrameLoader::submitForm):
337         * loader/FrameLoader.h:
338         * loader/mac/FrameLoaderMac.mm:
339         (WebCore::FrameLoader::receivedMainResourceError):
340         * loader/qt/FrameLoaderQt.cpp:
341         (WebCore::FrameLoader::submitForm):
342         * page/Frame.cpp:
343         (WebCore::Frame::setView):
344         * page/mac/EventHandlerMac.mm:
345         (WebCore::EventHandler::keyEvent):
346         (WebCore::EventHandler::mouseDown):
347         * platform/qt/FrameQt.cpp:
348         (WebCore::FrameQt::keyEvent):
349
350 2006-12-02  Geoffrey Garen  <ggaren@apple.com>
351
352         Reviewed by Darin Adler.
353         
354         Added support for Dashboard backward compatibility mode.
355         
356         * html/CanvasRenderingContext2D.cpp:
357         (WebCore::CanvasRenderingContext2D::stroke): Added support for old behavior
358         of automatically clearing the stroke path buffer after a call to stroke().
359         * html/HTMLCanvasElement.cpp: Added supoprt for old behavior of the canvas
360         tag being self-closing.
361         (WebCore::HTMLCanvasElement::endTagRequirement):
362         (WebCore::HTMLCanvasElement::tagPriority):
363         * html/HTMLCanvasElement.h:
364         * html/HTMLParser.cpp: Ditto.
365         (WebCore::HTMLParser::canvasCreateErrorCheck):
366         * xml/xmlhttprequest.cpp: Added support for old behavior of silently ignoring
367         a call to setRequestHeader() if it preceded a call to open() or followed a call
368         to send().
369         (WebCore::XMLHttpRequest::setRequestHeader):
370
371 2006-12-04  Darin Adler  <darin@apple.com>
372
373         Reviewed by Alice.
374
375         * bridge/EditorClient.h: Removed "_web_" prefix from
376         C++ userVisibleString member function. Alice will probably change
377         this so it's not on the editor client any more later.
378
379         * editing/Editor.h: Removed "_web_" prefix from
380         C++ userVisibleString member function.
381         * editing/Editor.cpp: Tweaked formatting a bit. Removed Mac-specific
382         code from this file.
383
384         * editing/mac/EditorMac.mm:
385         (WebCore::Editor::newGeneralClipboard): Removed unnneded local variable.
386         (WebCore::Editor::userVisibleString): Moved this function here.
387
388         * platform/Pasteboard.h: Added some FIXMEs. Removed unneeded includes.
389         Made Pasteboard noncopyable. Removed use of "protected" where we should
390         be using "private". Removed s_generalPasteboard.
391         * platform/mac/PasteboardMac.mm: Added some FIXMEs. Removed the
392         s_generalPasteboard global. Removed the unused destructor. Updated call
393         to userVisibleString for name change. Tweaked formatting.
394
395 2006-12-04  Alice Liu  <alice.liu@apple.com>
396
397         Reviewed by Oliver.
398
399         Moved some constants from EventHandlerMac.mm to EventHandler.cpp
400         Added some platform-specific data members and functions.
401
402         * page/EventHandler.cpp:
403         * page/EventHandler.h:
404         * page/mac/EventHandlerMac.mm:
405         * platform/PlatformMouseEvent.h:
406         (WebCore::):
407         (WebCore::PlatformMouseEvent::timestamp):
408         (WebCore::PlatformMouseEvent::activatedWebView):
409         (WebCore::PlatformMouseEvent::type):
410
411 2006-12-04  Anders Carlsson  <acarlsson@apple.com>
412
413         Reviewed by Darin, Geoff.
414
415         Get rid of ResourceHandle::kill(), all it did was to balance out a ref() in ResourceHandle::start().
416         We use RefPtrs to ResourceHandle instead.
417
418         * loader/icon/IconLoader.cpp:
419         (WebCore::IconLoader::~IconLoader):
420         (WebCore::IconLoader::stopLoading):
421         (WebCore::IconLoader::didReceiveResponse):
422         * loader/loader.cpp:
423         (WebCore::Loader::servePendingRequests):
424         (WebCore::Loader::cancelRequests):
425         (WebCore::Loader::jobForRequest):
426         * loader/loader.h:
427         * platform/network/ResourceHandle.cpp:
428         * platform/network/ResourceHandle.h:
429         * platform/network/mac/ResourceHandleMac.mm:
430         (WebCore::ResourceHandle::start):
431         (WebCore::ResourceHandle::finishJobAndHandle):
432         (WebCore::ResourceHandle::reportError):
433         * xml/xmlhttprequest.cpp:
434         (WebCore::XMLHttpRequest::abort):
435         (WebCore::XMLHttpRequest::didFinishLoading):
436
437 2006-12-04  Oliver Hunt  <oliver@apple.com>
438
439         Build fix for non-SVG builds
440
441         * bindings/js/JSSVGPoint.cpp:
442         (WebCore::JSSVGPointProtoFunc::callAsFunction):
443
444 2006-12-04  Darin Adler  <darin@apple.com>
445
446         Reviewed by Beth.
447
448         - fix http://bugs.webkit.org/show_bug.cgi?id=11632
449           AKA <rdar://problem/4858866> REGRESSION (r17770): Overflow areas' scrollbars don't work
450
451         No test case added at the moment, but Beth said she'd investigate
452         adding one after the fact.
453
454         * page/mac/EventHandlerMac.mm:
455         (WebCore::EventHandler::passMousePressEventToScrollbar):
456         Fix obvious-in-retrospect copy and paste error -- call
457         passMouseDownEventToWidget instead of passWheelEventToWidget.
458
459 2006-12-04  Don Gibson  <dgibson77@gmail.com>
460
461         Reviewed and landed by Alexey.
462
463         http://bugs.webkit.org/show_bug.cgi?id=11738:
464         Make link clicking work again on Windows.
465
466         This re-implements a few functions that used to be part of FrameWin in
467         their new loader-based locations, and copies a few things from the Mac
468         and Qt event handling code that aren't strictly necessary but are
469         pretty simple.
470
471         * WebCore.vcproj/WebCore/WebCore.vcproj:
472         * bridge/win/ChromeClientWin.h:
473         * bridge/win/ContextMenuClientWin.h:
474         * bridge/win/EditorClientWin.h:
475         * bridge/win/FrameWin.cpp:
476         (WebCore::FrameWin::client):
477         * bridge/win/FrameWin.h:
478         * loader/win/DocumentLoaderWin.cpp: Added.
479         (WebCore::DocumentLoader::setTitle):
480         * loader/win/FrameLoaderClientWin.cpp: Added.
481         (WebCore::FrameLoaderClientWin::userAgent):
482         * loader/win/FrameLoaderClientWin.h:
483         * loader/win/FrameLoaderWin.cpp: Added.
484         (WebCore::FrameLoader::urlSelected):
485         (WebCore::FrameLoader::submitForm):
486         (WebCore::FrameLoader::setTitle):
487         * page/win/EventHandlerWin.cpp: Added.
488         (WebCore::EventHandler::passMousePressEventToSubframe):
489         (WebCore::EventHandler::passMouseMoveEventToSubframe):
490         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
491         (WebCore::EventHandler::passWheelEventToSubframe):
492         (WebCore::EventHandler::passMousePressEventToScrollbar):
493         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
494         * platform/win/TemporaryLinkStubs.cpp:
495         (WebCore::EventHandler::tabsToLinks):
496         (WebCore::EventHandler::tabsToAllControls):
497         (WebCore::EventHandler::lastEventIsMouseUp):
498         (WebCore::EventHandler::passSubframeEventToSubframe):
499         (WebCore::EventHandler::passMouseDownEventToWidget):
500         (WebCore::EventHandler::passWheelEventToWidget):
501         (WebCore::FrameLoader::getHistoryLength):
502         (WebCore::FrameLoader::historyURL):
503         (WebCore::FrameLoader::createFrame):
504         (WebCore::FrameLoaderClientWin::setTitle):
505
506 2006-12-04  Don Gibson  <dgibson77@gmail.com>
507
508         Reviewed by Mitz.
509
510         http://bugs.webkit.org/show_bug.cgi?id=11748:
511         Windows build bustage.
512
513         * WebCore.vcproj/WebCore/WebCore.vcproj:
514         * platform/ContextMenuItem.h:
515         * platform/win/TemporaryLinkStubs.cpp:
516         (WebCore::ContextMenuItem::ContextMenuItem):
517         (WebCore::ContextMenuItem::platformDescription):
518         (WebCore::ContextMenuItem::action):
519         (WebCore::ContextMenuItem::setAction):
520         (WebCore::ContextMenuItem::title):
521         (WebCore::ContextMenuItem::setTitle):
522         (WebCore::ContextMenuItem::platformSubMenu):
523         (WebCore::ContextMenuItem::setSubMenu):
524
525 2006-12-04  John Sullivan  <sullivan@apple.com>
526
527         Reviewed by Anders
528
529         Moved EditorMac.mm to its appropriate location
530
531         * platform/mac/EditorMac.mm: Removed.
532         * editing/mac/EditorMac.mm: Added
533
534         * WebCore.xcodeproj/project.pbxproj:
535         updated for this change
536
537 2006-12-04  Rob Buis  <buis@kde.org>
538
539         Reviewed by dhyatt.
540
541         Patch by pmax.
542
543         http://bugs.webkit.org/show_bug.cgi?id=3280
544         With LEGEND element, align=right value is not supported
545         http://bugs.webkit.org/show_bug.cgi?id=11544
546         <legend> rendering doesn't take align into account
547
548         Allow aligning for legends in both RTL and LTR mode.
549
550         * rendering/RenderFieldset.cpp:
551         (WebCore::RenderFieldset::layoutLegend):
552
553 2006-12-03  Mark Rowe  <bdash@webkit.org>
554
555         Reviewed by Alexey.
556
557         http://bugs.webkit.org/show_bug.cgi?id=11730
558         Bug 11730: Meta HTTP Refresh that contains a fraction / decimal get ignored.
559
560         * dom/Document.cpp:
561         (WebCore::Document::processHttpEquiv): Parse the refresh interval as a double rather than an integer.
562
563 2006-12-03  Nikolas Zimmermann  <zimmermann@kde.org>
564
565         Reviewed by Oliver.
566
567         Fix following bugs:
568         http://bugs.webkit.org/show_bug.cgi?id=11734
569         http://bugs.webkit.org/show_bug.cgi?id=11685
570
571         SVGPoint/SVGRect/SVGNumber were missing put() support.
572         SVGPoint.matrixTransform() was missing.
573
574         In SVG DOM there are no cases where a readwrite property
575         exists of type SVGRect/SVGNumber/SVGPoint. Only function
576         calls returns instances of these objects. It would make
577         no sense to be able to write "someObj.getBbox().x = 100", and
578         modify the actual stored internal value of "someObj".
579
580         The only cases where these modification makes sense, is
581         when these SVGPoint/SVGRect/SVGNumber objects are created
582         via document.rootElement.createSVGPoint/Rect/Number (SVGSVGElement interface).
583
584         Result: The current implementation, where we just modify the stored FloatPoint/FloatRect/double
585         values in the JSSVGPoint/Rect/Number wrappers directly, is sufficient.
586
587         Patch created by Rob & me - co production.
588         Long live the great carto.next examples! :-)
589
590         * CMakeLists.txt:
591         * DerivedSources.make:
592         * bindings/js/JSSVGNumber.cpp:
593         (WebCore::):
594         (WebCore::JSSVGNumber::getOwnPropertySlot):
595         (WebCore::JSSVGNumber::getValueProperty):
596         (WebCore::JSSVGNumber::put):
597         (WebCore::JSSVGNumber::putValueProperty):
598         * bindings/js/JSSVGNumber.h:
599         (WebCore::JSSVGNumber::):
600         (WebCore::JSSVGNumber::impl):
601         * bindings/js/JSSVGPoint.cpp:
602         (WebCore::JSSVGPoint::JSSVGPoint):
603         (WebCore::JSSVGPoint::put):
604         (WebCore::JSSVGPoint::putValueProperty):
605         (WebCore::JSSVGPointProtoFunc::callAsFunction):
606         * bindings/js/JSSVGPoint.h:
607         (WebCore::JSSVGPoint::):
608         * bindings/js/JSSVGRect.cpp:
609         (WebCore::JSSVGRect::put):
610         (WebCore::JSSVGRect::putValueProperty):
611         * bindings/js/JSSVGRect.h:
612         * bindings/objc/DOMSVGPoint.mm:
613         (-[DOMSVGPoint matrixTransform:]):
614         * platform/graphics/FloatPoint.cpp:
615         (WebCore::FloatPoint::matrixTransform):
616         * platform/graphics/FloatPoint.h:
617
618 2006-12-03  Nikolas Zimmermann  <zimmermann@kde.org>
619
620         Reviewed by Dave.
621
622         Another missing piece in the platform/graphics move.
623
624         * WebCore.xcodeproj/project.pbxproj:
625         * platform/ImageAnimationObserver.h: Moved to platform/graphics.
626
627 2006-12-03  Rob Buis  <buis@kde.org>
628
629         Reviewed by Oliver.
630
631         http://bugs.webkit.org/show_bug.cgi?id=11667
632         SVG: method .getTransformToElement(elt) in SVGLocatable not implemented
633
634         Implement getTransformToElement functionality. Introduce virtual
635         baseclass SVGLocatable to allow one implementation of the functionality.
636         Finally cleanup some code.
637
638         * ksvg2/svg/SVGLocatable.cpp:
639         (WebCore::SVGLocatable::getTransformToElement):
640         * ksvg2/svg/SVGLocatable.h:
641         * ksvg2/svg/SVGStyledLocatableElement.cpp:
642         (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
643         (WebCore::SVGStyledLocatableElement::nearestViewportElement):
644         (WebCore::SVGStyledLocatableElement::farthestViewportElement):
645         (WebCore::SVGStyledLocatableElement::getCTM):
646         (WebCore::SVGStyledLocatableElement::getScreenCTM):
647         * ksvg2/svg/SVGStyledLocatableElement.h:
648         * ksvg2/svg/SVGStyledTransformableElement.cpp:
649         (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
650         (WebCore::SVGStyledTransformableElement::localMatrix):
651         (WebCore::SVGStyledTransformableElement::getCTM):
652         (WebCore::SVGStyledTransformableElement::getScreenCTM):
653         (WebCore::SVGStyledTransformableElement::updateLocalTransform):
654         (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
655         (WebCore::SVGStyledTransformableElement::nearestViewportElement):
656         (WebCore::SVGStyledTransformableElement::farthestViewportElement):
657         * ksvg2/svg/SVGStyledTransformableElement.h:
658         * ksvg2/svg/SVGTextElement.h:
659         * ksvg2/svg/SVGTransformable.h:
660
661 2006-12-03  Nikolas Zimmermann  <zimmermann@kde.org>
662
663         Reviewed by Rob.
664
665         Move some files around, which have been forgotton in the platform/graphics move.
666
667         * CMakeLists.txt:
668         * WebCore.xcodeproj/project.pbxproj:
669         * platform/mac/GraphicsContextMac.mm: Moved to platform/graphics/mac.
670         * platform/qt/GraphicsContextQt.cpp: Moved to platform/grahpics/qt.
671
672 2006-12-03  Nikolas Zimmermann  <zimmermann@kde.org>
673
674         Reviewed by Mitz.
675
676         Fix non-svg build.
677
678         * platform/graphics/GraphicsContext.h:
679         * platform/mac/GraphicsContextMac.mm:
680
681 2006-12-02  John Sullivan  <sullivan@apple.com>
682
683         Reviewed by Tim Omernick
684
685         Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
686         the find-next-instance functions with the mark-all-instances functions.
687
688         * bridge/mac/FrameMac.mm:
689         (WebCore::findFirstMisspellingInRange):
690         added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops
691         through the entire range and marks each misspelling
692         (WebCore::findFirstGrammarDetailInRange):
693         extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given
694         ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin
695         to the one in findFirstMisspellingInRange.
696         (WebCore::findFirstBadGrammarInRange):
697         added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange
698         (WebCore::FrameMac::advanceToNextMisspelling):
699         pass "false" for new markAll parameters
700         (WebCore::markAllMisspellingsInRange):
701         now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code
702         (WebCore::markAllBadGrammarInRange):
703         now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code
704
705 2006-12-02  Mitz Pettel  <mitz@webkit.org>
706
707         Reviewed by Hyatt.
708
709         - fix http://bugs.webkit.org/show_bug.cgi?id=11672
710           REGRESSION (r17068): Repro crash due to painting without layout
711
712         Test: fast/dynamic/containing-block-change.html
713
714         * rendering/RenderObject.cpp:
715         (WebCore::RenderObject::setStyle): Changed the logic used
716         to find absolutely positioned descendant's current containing block to
717         match the changes made to containingBlock() in the fix for bug 9347.
718
719 2006-12-02  MorganL  <morganl.webkit@yahoo.com>
720
721         Reviewed by Darin.
722
723         http://bugs.webkit.org/show_bug.cgi?id=11709
724         DeprecatedString::format is broken on Windows
725
726         Use _vscprintf on Windows to compute the length of the buffer that
727         vsnprintf would need.
728
729         * platform/DeprecatedString.cpp:
730         (WebCore::DeprecatedString::format):
731         * platform/String.cpp:
732         (WebCore::String::format):
733
734 2006-12-01  Beth Dakin  <bdakin@apple.com>
735
736         Reviewed by Adam.
737
738         Support for sub-menus in WebCore context menus. This also re-
739         architects the ContextMenuItem class so that it is more like
740         ContextMenu in that the class is now really just a wrapper for the
741         platformDescription
742
743         * WebCore.exp:
744         * WebCore.xcodeproj/project.pbxproj:
745         * page/ContextMenuController.cpp:
746         (WebCore::ContextMenuController::contextMenuItemSelected): Add
747         place-holders for new tags for the sub-menu items. I will flesh
748         these out in a separate check-in.
749         * platform/ContextMenu.cpp:
750         (WebCore::createFontSubMenu):
751         (WebCore::createSpellingAndGrammarSubMenu):
752         (WebCore::createSpellingSubMenu):
753         (WebCore::createSpeechSubMenu):
754         (WebCore::createWritingDirectionSubMenu):
755         (WebCore::ContextMenu::populate): Call the above functions to add
756         the appropriate sub-menus to editing context menus.
757         * platform/ContextMenu.h:
758         * platform/ContextMenuItem.h:
759         (WebCore::): New tags in the ContextMenuAction enumeration.
760         (WebCore::ContextMenuItem::parentMenu):
761         (WebCore::ContextMenuItem::setType):
762         * platform/PlatformMenuDescription.h: Added. This defines
763         PlatformMenuDesciption. It needs to be its own header because we
764        have to include it from ContextMenu.h and ContextMenuItem.h
765         * platform/mac/ContextMenuItemMac.mm: Lots of adjustments here to
766         make this class basically just be a wrapper for NSMenuItem.
767         (WebCore::ContextMenuItem::ContextMenuItem):
768         (WebCore::ContextMenuItem::~ContextMenuItem):
769         (WebCore::ContextMenuItem::platformDescription):
770         (WebCore::ContextMenuItem::action):
771         (WebCore::ContextMenuItem::title):
772         (WebCore::ContextMenuItem::platformSubMenu):
773         (WebCore::ContextMenuItem::setAction):
774         (WebCore::ContextMenuItem::setTitle):
775         (WebCore::ContextMenuItem::setSubMenu):
776         * platform/mac/ContextMenuMac.mm:
777         (WebCore::ContextMenu::ContextMenu):
778         (WebCore::getNSMenuItem): Now we only have to get the
779         platformDescription of the ContextMenuItem and then set its target
780         and action.
781         (WebCore::ContextMenu::itemCount):
782
783 2006-12-01  Kevin McCullough  <KMcCullough@apple.com>
784
785         Reviewed by .
786
787         - accidentally checked in with previous checkin
788
789         * platform/qt/FrameQt.cpp:
790         (WebCore::FrameQt::keyEvent):
791
792 2006-12-01  Kevin McCullough  <KMcCullough@apple.com>
793
794         Reviewed by Adam.
795
796         - better solution to the ambiguous reference
797
798         * platform/Widget.h:
799         (WebCore::Widget::handleMouseMoveEvent):
800         (WebCore::Widget::handleMouseReleaseEvent):
801         * platform/qt/FrameQt.cpp:
802         (WebCore::FrameQt::keyEvent):
803         * platform/win/PlatformScrollBar.h:
804         * platform/win/TemporaryLinkStubs.cpp:
805         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
806         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
807
808 2006-12-01  Justin Garcia  <justin.garcia@apple.com>
809
810         Reviewed by john
811         
812         <rdar://problem/4826940>
813         Selection change performed even when delete delegate replies NO (11415)
814
815         No layout test for the bug fix, because there's no way to register a custom
816         editing delegate from a layout test.  Layout tests are effected by the change
817         to avoid sending unnecessary shouldChangeSelections, however. 
818
819         * editing/Editor.cpp:
820         (WebCore::Editor::appliedEditing): Don't bother sending shouldChangeSelection
821         if the editing operation didn't change the selection.  Still call
822         setSelection though, because it does work in this case that's necessary,
823         like clearing the typing style.
824         (WebCore::Editor::unappliedEditing): Ditto.
825         (WebCore::Editor::reappliedEditing): Ditto.
826         * editing/TypingCommand.cpp:
827         (WebCore::TypingCommand::deleteKeyPressed): Don't set the starting
828         selection if the editing delegate returns NO from shouldDeleteRange.
829         Notice we now call setStartingSelection in the case where
830         the current selection was a range selection.  This is fine because
831         it's a no-op (the starting selection is already the current selection).
832         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
833
834 2006-12-01  John Sullivan  <sullivan@apple.com>
835
836         Reviewed by Darin
837         
838         Move subrange helper function from spellchecking code to TextIterator
839
840         * editing/TextIterator.h:
841         added TextIterator::subrange
842         * editing/TextIterator.cpp:
843         (WebCore::CharacterIterator::advance):
844         early return if count is <= 0; assert that it's not < 0
845         (WebCore::TextIterator::subrange):
846         new function, moved from FrameMac.mmm
847
848         * bridge/mac/FrameMac.mm:
849         moved subrange() function to TextIterator
850         (WebCore::FrameMac::advanceToNextMisspelling):
851         use TextIterator::subrange
852         (WebCore::markAllMisspellingsInRange):
853         ditto
854         (WebCore::markAllBadGrammarInRange):
855         ditto
856
857 2006-12-01  Darin Adler  <darin@apple.com>
858
859         Reviewed by Mitz.
860
861         - fix http://bugs.webkit.org/show_bug.cgi?id=11628
862           REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window
863
864         I couldn't think of an easy way to make a regression test for this, but maybe
865         I'll get an idea later about how to do it.
866
867         The main thing I did was add a concept of a DOM event having an "underlying event".
868         That allows the DOM activate event to contain inside it the original keyboard event
869         that triggered the form submission, and thus allows WebKit to see the modifier keys
870         from that original event. The code that uses the underlying event is in WebKit, but
871         the code to set it up is here in WebCore.
872
873         - also do some clean-up to related event handling code
874
875         * bindings/js/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): Updated for the
876         name change of cancelBubble.
877
878         * dom/Event.h: Removed a useless comment. Fixed some whitespace and formatting.
879         Renamed getCancelBubble to cancelBubble to match the DOM -- I suspect the old
880         name predated the use of the m_ prefix on data members. Added the underlying event,
881         and a getter and setter.
882         * dom/Event.cpp:
883         (WebCore::Event::setTarget): Updated to take a PassRefPtr.
884         (WebCore::Event::setUnderlyingEvent): Added.
885
886         * dom/EventTargetNode.h: Added an optional underlyingEvent parameter to
887         dispatchUIEvent, one of the overloads of dispatchMouseEvent, and
888         dispatchSimulatedMouseEvent. Added a new dispatchSimulatedClick function here that
889         mostly replaces the click function in HTMLElement.
890         * dom/EventTargetNode.cpp:
891         (WebCore::EventTargetNode::dispatchGenericEvent): Updated for the name change
892         of cancelBubble.
893         (WebCore::EventTargetNode::dispatchUIEvent): Added an underlying event parameter,
894         which gets attached to the UIEvent object after it's created.
895         (WebCore::EventTargetNode::dispatchMouseEvent): Tweaked formatting and parameter
896         name for the version that creates a mouse event for a real platform mouse event.
897         Added an underlying event parameter to the main version, and attached it to all
898         three of the events that can be dispatched.
899         (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Added an underlying
900         event parameter, passed it along to dispatchMouseEvent.
901         (WebCore::EventTargetNode::dispatchSimulatedClick): Moved this here from HTMLElement
902         and renamed it from click. Added an underlyingEvent parameter, and passed that along
903         in all three of the calls to dispatchSimulatedMouseEvent.
904
905         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldClose): Updated call to
906         setTarget that no longer needs a get().
907         * ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
908
909         * html/HTMLAnchorElement.cpp:
910         (WebCore::HTMLAnchorElement::defaultEventHandler): Converted a call to click
911         to a call to dispatchSimulatedClick.
912         (WebCore::HTMLAnchorElement::accessKeyAction): Ditto.
913         * html/HTMLButtonElement.cpp:
914         (WebCore::HTMLButtonElement::accessKeyAction): Ditto.
915         * html/HTMLElement.h: Removed the parameters to click and made it non-virtual.
916         We could move it down to the input and button elements, now that it's just
917         a single function call, but it's also OK to just leave it here.
918         * html/HTMLElement.cpp:
919         (WebCore::HTMLElement::click): Removed the parameters and changed this to just
920         call dispatchSimulatedClick. The real work is now in dispatchSimulatedClick.
921         (WebCore::HTMLElement::accessKeyAction): Converted a call to click to a call to
922         dispatchSimulatedClick.
923         * html/HTMLFormElement.cpp:
924         (WebCore::HTMLFormElement::submitClick): Ditto. But unlike accessKeyAction callers,
925         pass the event along as the underlying event.
926         * html/HTMLInputElement.h:
927         * html/HTMLInputElement.cpp: Removed override of virtual click function. The
928         special cases for the file control and hidden input elements aren't needed.
929         (WebCore::HTMLInputElement::accessKeyAction): Converted a call to click to a call to
930         dispatchSimulatedClick.
931         (WebCore::HTMLInputElement::defaultEventHandler): Converted calls to click to calls to
932         dispatchSimulatedClick, passing along the event as the underlying event.
933         * html/HTMLLabelElement.cpp:
934         (WebCore::HTMLLabelElement::defaultEventHandler): Converted a call to click to a call
935         to dispatchSimulatedClick, passing the event along as the underlying event. Also
936         changed the local variable for the element to a RefPtr since the code assumes it's
937         still around after calling arbitrary JavaScript code.
938         * html/HTMLSelectElement.cpp:
939         (WebCore::HTMLSelectElement::accessKeyAction): Converted a call to click to a call to
940         dispatchSimulatedClick.
941
942         * rendering/RenderFileUploadControl.h:
943         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):
944         Removed unneeded ignored parameter to the click function, and also made it non-virtual.
945
946         * loader/NavigationAction.h: Removed unneeded includes.
947         * loader/NavigationAction.cpp: Moved all the code here from NavigationActionMac.mm,
948         since none of it is Mac-specific any more.
949         * loader/mac/NavigationActionMac.mm: Removed.
950         * WebCore.xcodeproj/project.pbxproj: Updated for removed file.
951
952         * ksvg2/svg/SVGAElement.cpp: Removed an unnecessary include.
953
954         * loader/FrameLoader.cpp: Added a newly-needed incluude.
955         * loader/mac/DocumentLoaderMac.mm: Ditto.
956         * loader/mac/FrameLoaderMac.mm: Ditto.
957         * rendering/RenderWidget.cpp: Ditto.
958
959 2006-12-01  John Sullivan  <sullivan@apple.com>
960
961         Reviewed by Darin
962
963         - fixed <rdar://problem/4811175> Many false reports of bad grammar appear, caused by 
964           insufficient context passed to grammar checker
965
966         * bridge/mac/FrameMac.mm:
967         (WebCore::markAllMisspellingsInRange):
968         new function, extracted from markMisspellings -- ignores grammar
969         (WebCore::markAllBadGrammarInRange):
970         new function, extracted from markMisspellings -- ignores spelling, and operates on
971         appropriately-sized chunks of text
972         (WebCore::FrameMac::markMisspellings):
973         now calls markAllMisspellingsInRange and (optionally) markAllBadGrammarInRange rather
974         than trying to interweave the spelling and grammar logic
975
976 2006-12-01  John Sullivan  <sullivan@apple.com>
977
978         Reviewed by Darin
979
980         With these changes, grammar checking works correctly for the one-by-one case.
981         It still doesn't work correctly for the check-as-you-type case; I need to make these
982         same kinds of changes in markMisspellings, and refactor to share more code between
983         the two cases, but I wanted to get this working code in before modifying it further.
984
985         The major change here is that advanceToNextMisspelling used to look at small chunks of
986         text at a time, checking each one for both misspellings and questionable grammar. But
987         grammar checking needs at least paragraph-sized chunks of text to have enough context
988         to work correctly, so the old mechanism was causing many spurious complaints of bad
989         grammar (e.g., almost every word seemed to be at the start of a sentence so the checker
990         would complain about missing capitalization). So now the spell checker runs in the
991         specified range first. Then the grammar checker runs on the same range (stopping at the
992         next misspelling, if any), but expanded to paragraph-aligned boundaries.
993
994         * bridge/mac/FrameMac.mm:
995         (WebCore::findFirstMisspellingInRange):
996         new function, extracted from advanceToNextMisspelling, and ignores grammar
997         (WebCore::paragraphAlignedRangeForRange):
998         new function, used by findNextBadGrammarInRange
999         (WebCore::findFirstBadGrammarInRange):
1000         new function, extracted from advanceToNextMisspelling, and rewritten to use paragraph-aligned
1001         chunks, and ignores spelling
1002         (WebCore::subrange):
1003         new helper function, used by advanceToNextMisspelling
1004         (WebCore::FrameMac::advanceToNextMisspelling):
1005         now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately
1006         instead of trying to interweave the spelling and grammar logic
1007
1008 2006-12-01  Don Gibson  <dgibson77@gmail.com>
1009
1010         Reviewed by Mitz.
1011
1012         http://bugs.webkit.org/show_bug.cgi?id=11732:
1013         Windows build bustage.
1014
1015         * WebCore.vcproj/WebCore/WebCore.vcproj:
1016         * bridge/win/ChromeClientWin.h:
1017         * bridge/win/ContextMenuClientWin.h:
1018         * bridge/win/EditorClientWin.h:
1019         * bridge/win/FrameWin.cpp:
1020         (WebCore::FrameWin::FrameWin):
1021         (WebCore::FrameWin::keyPress):
1022         * bridge/win/FrameWin.h:
1023         * loader/win/FrameLoaderClientWin.h:
1024         * platform/ContextMenu.h:
1025         * platform/Widget.h:
1026         * platform/win/PlatformScrollBar.h:
1027         * platform/win/TemporaryLinkStubs.cpp:
1028         (WebCore::ChromeClientWin::chromeDestroyed):
1029         (WebCore::ChromeClientWin::addMessageToConsole):
1030         (WebCore::ContextMenu::ContextMenu):
1031         (WebCore::ContextMenu::~ContextMenu):
1032         (WebCore::ContextMenu::appendItem):
1033         (WebCore::ContextMenuClientWin::contextMenuDestroyed):
1034         (WebCore::ContextMenuClientWin::contextMenuItemSelected):
1035         (WebCore::ContextMenuItem::~ContextMenuItem):
1036         (WebCore::Editor::newGeneralClipboard):
1037         (WebCore::EditorClientWin::pageDestroyed):
1038         (WebCore::EditorClientWin::smartInsertDeleteEnabled):
1039         (WebCore::EditorClientWin::shouldInsertNode):
1040         (WebCore::FrameLoader::createPlugin):
1041         (WebCore::FrameLoaderClientWin::frameLoaderDestroyed):
1042         (WebCore::FrameLoaderClientWin::hasWebView):
1043         (WebCore::FrameLoaderClientWin::canHandleRequest):
1044         (WebCore::FrameWin::unfocusWindow):
1045         (WebCore::FrameWin::bindingRootObject):
1046         (WebCore::FrameWin::issueCopyCommand):
1047         (WebCore::FrameWin::markMisspellings):
1048         (WebCore::FrameWin::issueTransposeCommand):
1049         (WebCore::FrameWin::markedTextRange):
1050         (WebCore::FrameWin::respondToChangedSelection):
1051         (WebCore::FrameWin::markMisspellingsInAdjacentWords):
1052         (WebCore::FrameWin::isSelectionMisspelled):
1053         (WebCore::FrameWin::guessesForMisspelledSelection):
1054         (WebCore::Pasteboard::generalPasteboard):
1055         (WebCore::Pasteboard::writeSelection):
1056         (WebCore::Pasteboard::clearTypes):
1057         (WebCore::Pasteboard::canSmartReplace):
1058         (WebCore::Pasteboard::documentFragment):
1059         (WebCore::Pasteboard::plainText):
1060         (WebCore::Pasteboard::Pasteboard):
1061         (WebCore::Pasteboard::~Pasteboard):
1062         (WebCore::Pasteboard::registerSelectionPasteboardTypes):
1063         (WebCore::Pasteboard::replaceNBSP):
1064         (WebCore::Pasteboard::createHandle):
1065         (WebCore::Pasteboard::createCF_HTMLFromRange):
1066
1067 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
1068
1069         Rubber Stamped by Anders Carlsson.
1070
1071         Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
1072         suggested a command, and conflicted with a different meaning for 'focusNode'
1073         in the Mozilla selection API.
1074
1075 2006-11-30  John Sullivan  <sullivan@apple.com>
1076
1077         Reviewed by Justin
1078
1079         With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
1080         That revealed another problem in the layout tests involving bad parameters passed to the Range
1081         constructors.
1082         
1083         With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
1084         no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
1085         I'm going to update the results for that test and file a separate radar about it, which Justin will
1086         investigate.
1087
1088         * dom/Position.h:
1089         removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.
1090         
1091         * dom/Range.cpp:
1092         (WebCore::Range::Range):
1093         Call setStart and setEnd in the two Range constructors that take parameters, rather than just 
1094         directly setting the instance variables. This makes Range perform the boundary checks and
1095         compensations that the DOM spec requires.
1096         
1097         * editing/CompositeEditCommand.cpp:
1098         (WebCore::CompositeEditCommand::moveParagraphs):
1099         Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.
1100         
1101         * editing/TextIterator.cpp:
1102         (WebCore::TextIterator::TextIterator):
1103         Assert that the boundary points of the range are valid.
1104
1105 2006-11-30  Lou Amadio  <lamadio@apple.com>
1106
1107         Reviewed by Dave Hyatt
1108         Cleaned up generated files.
1109
1110         * html/HTMLElement.cpp:
1111         (WebCore::HTMLElement::isRecognizedTagName):
1112                 Uses the new method for retrieving the list of supported tags
1113         * ksvg2/scripts/make_names.pl:
1114                 Generates tag lists without using macros.
1115
1116 2006-11-30  Adam Roben  <aroben@apple.com>
1117
1118         Reviewed by Beth.
1119
1120         Store ContextMenu's NSMutableArray inside a RetainPtr so that we
1121         will retain/release it correctly.
1122
1123         * WebCore.exp:
1124         * platform/ContextMenu.cpp:
1125         (WebCore::ContextMenu::populate): Added a FIXME.
1126         * platform/ContextMenu.h:
1127         * platform/mac/ContextMenuMac.mm: 
1128         (WebCore::ContextMenu::ContextMenu):
1129         (WebCore::ContextMenu::~ContextMenu):
1130         (WebCore::getNSMenuItem):
1131         (WebCore::ContextMenu::appendItem):
1132         (WebCore::ContextMenu::itemCount):
1133         (WebCore::ContextMenu::insertItem):
1134         (WebCore::ContextMenu::setPlatformDescription):
1135         (WebCore::ContextMenu::platformDescription):
1136
1137 2006-11-30  Nikolas Zimmermann  <zimmermann@kde.org>
1138
1139         Reviewed by Eric. Rubber stamped by Oliver.
1140
1141         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10383
1142      
1143         This is the final patch after the long "die kcanvas" journey.
1144
1145         All old kcanvas code is gone now, and properly integrated within
1146         WebCore (stuff like GraphicsContext changes etc.). It shares
1147         the platform/ design concept: no subclassing, but instead
1148         implementing parts of the classes/methods per-platform.
1149
1150         This commit removes the last pieces: KRenderingDevice & KRenderingDeviceContext.
1151         This layer was just obsolete, given the powerful GraphicsContext API we have
1152         since quite a while now. All the ugly pushContext/popContext stuff is gone now.
1153
1154         LayoutTests affected: svg/W3C-SVG-1.1/pservers-grad-11-b.svg
1155         Radial gradients as fill color for texts, work again!
1156         Though "Gradient on text stroke" remains broken. Funny thing:
1157         With this patch, if you "select" the text using the mouse, as
1158         soon as the selection rectangle is drawn, you see the correct
1159         gradient on stroke rendering - at least a hint where it breaks!
1160
1161         All svg layout tests have subtle text rendering changes - with and without this
1162         patch, it seems it was forgotton to update svg pixel test baseline, a while ago.
1163
1164         * CMakeLists.txt:
1165         * WebCore.xcodeproj/project.pbxproj:
1166         * kcanvas/device/KRenderingDevice.cpp: Removed.
1167         * kcanvas/device/KRenderingDevice.h: Removed.
1168         * kcanvas/device/qt/KRenderingDeviceQt.cpp: Removed.
1169         * kcanvas/device/qt/KRenderingDeviceQt.h: Removed.
1170         * kcanvas/device/qt/RenderPathQt.cpp: Moved to platform/graphics/qt
1171         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Moved to platform/graphics/svg/cg/RenderPathCg.cpp
1172         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Removed.
1173         * kcanvas/device/quartz/KRenderingDeviceQuartz.h: Removed.
1174         * kcanvas/device/quartz/QuartzSupport.cpp: Moved to platform/graphics/svg/cg/CgSupport.cpp
1175         * kcanvas/device/quartz/QuartzSupport.h: Moved to platform/graphics/svg/cg/CgSupport.h
1176         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1177         (WebCore::sharedSolidPaintServer):
1178         * ksvg2/misc/KCanvasRenderingStyle.h:
1179         * ksvg2/svg/SVGAElement.cpp:
1180         * ksvg2/svg/SVGClipPathElement.cpp:
1181         * ksvg2/svg/SVGFEBlendElement.cpp:
1182         (WebCore::SVGFEBlendElement::filterEffect):
1183         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1184         (WebCore::SVGFEColorMatrixElement::filterEffect):
1185         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
1186         (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
1187         (WebCore::SVGFEComponentTransferElement::parseMappedAttribute):
1188         (WebCore::SVGFEComponentTransferElement::filterEffect):
1189         * ksvg2/svg/SVGFECompositeElement.cpp:
1190         (WebCore::SVGFECompositeElement::SVGFECompositeElement):
1191         (WebCore::SVGFECompositeElement::filterEffect):
1192         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1193         (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
1194         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
1195         (WebCore::SVGFEDiffuseLightingElement::updateLights):
1196         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1197         (WebCore::SVGFEDisplacementMapElement::filterEffect):
1198         * ksvg2/svg/SVGFEDistantLightElement.cpp:
1199         (WebCore::SVGFEDistantLightElement::SVGFEDistantLightElement):
1200         (WebCore::SVGFEDistantLightElement::lightSource):
1201         * ksvg2/svg/SVGFEFloodElement.cpp:
1202         (WebCore::SVGFEFloodElement::SVGFEFloodElement):
1203         (WebCore::SVGFEFloodElement::parseMappedAttribute):
1204         (WebCore::SVGFEFloodElement::filterEffect):
1205         * ksvg2/svg/SVGFEFuncAElement.cpp:
1206         * ksvg2/svg/SVGFEFuncBElement.cpp:
1207         * ksvg2/svg/SVGFEFuncGElement.cpp:
1208         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
1209         * ksvg2/svg/SVGFEFuncRElement.cpp:
1210         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1211         (WebCore::SVGFEGaussianBlurElement::filterEffect):
1212         * ksvg2/svg/SVGFEImageElement.cpp:
1213         (WebCore::SVGFEImageElement::SVGFEImageElement):
1214         (WebCore::SVGFEImageElement::parseMappedAttribute):
1215         (WebCore::SVGFEImageElement::notifyFinished):
1216         (WebCore::SVGFEImageElement::filterEffect):
1217         * ksvg2/svg/SVGFELightElement.cpp:
1218         * ksvg2/svg/SVGFEMergeElement.cpp:
1219         (WebCore::SVGFEMergeElement::filterEffect):
1220         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
1221         * ksvg2/svg/SVGFEOffsetElement.cpp:
1222         (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
1223         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1224         (WebCore::SVGFEOffsetElement::filterEffect):
1225         * ksvg2/svg/SVGFEPointLightElement.cpp:
1226         (WebCore::SVGFEPointLightElement::lightSource):
1227         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1228         (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
1229         (WebCore::SVGFESpecularLightingElement::filterEffect):
1230         (WebCore::SVGFESpecularLightingElement::updateLights):
1231         * ksvg2/svg/SVGFESpotLightElement.cpp:
1232         (WebCore::SVGFESpotLightElement::SVGFESpotLightElement):
1233         (WebCore::SVGFESpotLightElement::lightSource):
1234         * ksvg2/svg/SVGFETileElement.cpp:
1235         (WebCore::SVGFETileElement::SVGFETileElement):
1236         (WebCore::SVGFETileElement::parseMappedAttribute):
1237         (WebCore::SVGFETileElement::filterEffect):
1238         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1239         (WebCore::SVGFETurbulenceElement::filterEffect):
1240         * ksvg2/svg/SVGFilterElement.cpp:
1241         (WebCore::SVGFilterElement::canvasResource):
1242         * ksvg2/svg/SVGGradientElement.cpp:
1243         (WebCore::SVGGradientElement::canvasResource):
1244         * ksvg2/svg/SVGLinearGradientElement.cpp:
1245         * ksvg2/svg/SVGMarkerElement.cpp:
1246         * ksvg2/svg/SVGMaskElement.cpp:
1247         (WebCore::SVGMaskElement::parseMappedAttribute):
1248         (WebCore::SVGMaskElement::drawMaskerContent):
1249         (WebCore::SVGMaskElement::canvasResource):
1250         * ksvg2/svg/SVGPatternElement.cpp:
1251         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1252         (WebCore::SVGPatternElement::canvasResource):
1253         * ksvg2/svg/SVGStyledElement.cpp:
1254         * ksvg2/svg/SVGStyledElement.h:
1255         * platform/graphics/GraphicsContext.h:
1256         * platform/graphics/svg/SVGPaintServer.h:
1257         * platform/graphics/svg/SVGPaintServerGradient.cpp:
1258         (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
1259         * platform/graphics/svg/SVGPaintServerGradient.h:
1260         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
1261         * platform/graphics/svg/SVGPaintServerPattern.h:
1262         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
1263         * platform/graphics/svg/SVGPaintServerSolid.h:
1264         * platform/graphics/svg/SVGResource.cpp:
1265         * platform/graphics/svg/SVGResource.h:
1266         * platform/graphics/svg/SVGResourceClipper.h:
1267         * platform/graphics/svg/SVGResourceFilter.h:
1268         * platform/graphics/svg/SVGResourceMasker.h:
1269         * platform/graphics/svg/cg/RenderPathCg.cpp: Added.
1270         * platform/graphics/svg/cg/SVGPaintServerCg.cpp:
1271         (WebCore::SVGPaintServer::draw):
1272         (WebCore::SVGPaintServer::teardown):
1273         (WebCore::SVGPaintServer::renderPath):
1274         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
1275         (WebCore::SVGPaintServerGradient::teardown):
1276         (WebCore::SVGPaintServerGradient::renderPath):
1277         (WebCore::SVGPaintServerGradient::setup):
1278         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
1279         (WebCore::SVGPaintServerPattern::setup):
1280         (WebCore::SVGPaintServerPattern::teardown):
1281         * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
1282         (WebCore::SVGPaintServerSolid::setup):
1283         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
1284         (WebCore::SVGResourceClipper::applyClip):
1285         * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
1286         (WebCore::SVGResourceFilter::SVGResourceFilter):
1287         (WebCore::SVGResourceFilter::createFilterEffect):
1288         (WebCore::SVGResourceFilter::prepareFilter):
1289         (WebCore::SVGResourceFilter::applyFilter):
1290         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
1291         (WebCore::SVGResourceMasker::applyMask):
1292         * platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
1293         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
1294         (WebCore::SVGPaintServerLinearGradient::setup):
1295         * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
1296         (WebCore::SVGPaintServerPattern::setup):
1297         * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
1298         (WebCore::SVGPaintServer::draw):
1299         (WebCore::SVGPaintServer::teardown):
1300         (WebCore::SVGPaintServer::renderPath):
1301         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
1302         (WebCore::setup):
1303         * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
1304         (WebCore::SVGPaintServerSolid::setup):
1305         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1306         (WebCore::SVGResourceClipper::applyClip):
1307         * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
1308         (WebCore::SVGResourceFilter::createFilterEffect):
1309         (WebCore::SVGResourceFilter::prepareFilter):
1310         (WebCore::SVGResourceFilter::applyFilter):
1311         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
1312         (WebCore::SVGResourceMasker::applyMask):
1313         * platform/qt/GraphicsContextQt.cpp:
1314         (WebCore::GraphicsContext::beginPath):
1315         (WebCore::GraphicsContext::addPath):
1316         (WebCore::GraphicsContext::setFillRule):
1317         (WebCore::GraphicsContext::currentPath):
1318         (WebCore::GraphicsContext::strokeRect):
1319         (WebCore::contextForImage):
1320         * rendering/RenderForeignObject.cpp:
1321         (WebCore::RenderForeignObject::paint):
1322         * rendering/RenderPath.cpp:
1323         (WebCore::RenderPath::paint):
1324         * rendering/RenderSVGContainer.cpp:
1325         (WebCore::RenderSVGContainer::paint):
1326         * rendering/RenderSVGImage.cpp:
1327         (WebCore::RenderSVGImage::paint):
1328         * rendering/RenderSVGImage.h:
1329         * rendering/RenderSVGInline.cpp:
1330         (WebCore::RenderSVGInline::RenderSVGInline):
1331         (WebCore::RenderSVGInline::createInlineBox):
1332         * rendering/RenderSVGInlineText.cpp:
1333         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
1334         * rendering/RenderSVGTSpan.cpp:
1335         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
1336         * rendering/RenderSVGText.cpp:
1337         (WebCore::RenderSVGText::paint):
1338         * rendering/SVGInlineFlowBox.cpp:
1339         (WebCore::paintSVGInlineFlow):
1340         * rendering/SVGRenderTreeAsText.cpp:
1341         (WebCore::writeStyle):
1342
1343 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
1344
1345         Reviewed by Beth Dakin.
1346         
1347         Fixed up garbage collection at window close time.
1348
1349         * bindings/js/kjs_proxy.cpp: Don't garbage collect in the KJSProxy
1350         destructor, since the global object hasn't been freed yet.
1351         * bindings/js/kjs_proxy.h:
1352         * loader/FrameLoader.cpp:
1353         (WebCore::FrameLoader::detachFromParent): Made this function cross-
1354         platform.
1355         * loader/FrameLoader.h:
1356         * loader/mac/FrameLoaderMac.mm:
1357         (WebCore::FrameLoader::setTitle): Moved this function to FrameLoaderMac,
1358         since it's Mac-only.
1359         (WebCore::FrameLoader::closeBridge):
1360         * page/Page.cpp:
1361         (WebCore::Page::~Page): Don't garbage collect in the Page destructor,
1362         since the Interpreter destructor will do it for us.
1363
1364 2006-11-30  Brady Eidson  <beidson@apple.com>
1365
1366         Reviewed by Tim's rubberstamp
1367
1368         Amazingly, DocumentLoader.h survived all this time without a header guard...
1369
1370         * loader/DocumentLoader.h:  Added header guard
1371
1372 2006-11-30  Timothy Hatcher  <timothy@apple.com>
1373
1374         Reviewed by Brady and Eric.
1375
1376         XMLHttpRequest fails in a page loaded with WebFrame's loadHTMLString: or loadData:
1377         http://bugs.webkit.org/show_bug.cgi?id=11723
1378
1379         Allow cross-domain XMLHTTPRequest for applewebdata URLs. No automated way to test,
1380         tested in Safari's debug Snippet Editor.
1381
1382         * xml/xmlhttprequest.cpp:
1383         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1384
1385 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
1386
1387         Reviewed by Brady.
1388
1389         Get rid of PlatformResponse, the platform specific response object is stored inside of 
1390         the ResourceResponse object now. This also gets rid of receivedResponse in ResourceHandleClient.
1391         
1392         * bridge/mac/WebCoreFrameBridge.mm:
1393         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
1394         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
1395         * loader/CachedResource.cpp:
1396         (WebCore::CachedResource::CachedResource):
1397         (WebCore::CachedResource::~CachedResource):
1398         * loader/CachedResource.h:
1399         (WebCore::CachedResource::response):
1400         * loader/loader.cpp:
1401         * loader/loader.h:
1402         * loader/mac/ImageDocumentMac.mm:
1403         (WebCore::finishImageLoad):
1404         * loader/mac/LoaderFunctionsMac.mm:
1405         (WebCore::CheckCacheObjectStatus):
1406         * loader/mac/SubresourceLoaderMac.mm:
1407         (WebCore::SubresourceLoader::didReceiveResponse):
1408         * platform/network/ResourceHandle.h:
1409         * platform/network/ResourceResponse.h:
1410         (WebCore::ResourceResponse::nsURLResponse):
1411         (WebCore::ResourceResponse::cfURLResponse):
1412         * platform/network/mac/ResourceHandleMac.mm:
1413         (WebCore::ResourceHandle::didReceiveResponse):
1414
1415 2006-11-29  Justin Garcia  <justin.garcia@apple.com>
1416
1417         Reviewed by sullivan
1418         
1419         <rdar://problem/4845371>
1420         In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message
1421         
1422         * editing/DeleteSelectionCommand.cpp:
1423         (WebCore::DeleteSelectionCommand::initializeStartEnd): The start/end were
1424         being inflated even when they were the start/end of a partially selected
1425         special element.
1426
1427 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
1428
1429         Reviewed by Oliver.
1430
1431         Fix fast/dom/xmlhttprequest-get layout test failure.
1432         
1433         * platform/network/mac/ResourceResponseMac.mm:
1434         Initialize the status code to 0 for non-http responses.
1435         
1436 2006-11-29  Geoffrey Garen  <ggaren@apple.com>
1437
1438         Reviewed by Anders Carlsson.
1439         
1440         Fixed http://bugs.webkit.org/show_bug.cgi?id=11712
1441         REGRESSION: Crash when clicking JS link on crateandbarrel.com (window.open("http[...]"))
1442         
1443         This was an accidental commit by Anders.
1444
1445         Chrome can't use the FrameView at window.open time, because it doesn't
1446         exist yet.
1447         
1448         * page/Chrome.cpp:
1449         (WebCore::Chrome::pageRect):
1450
1451 2006-11-29  Geoffrey Garen  <ggaren@apple.com>
1452
1453         Reviewed by Mitz Pettel.
1454         
1455         Fixed http://bugs.webkit.org/show_bug.cgi?id=11710
1456         REGRESSION (r17906): Crash in WebCore::FrameMac
1457
1458         Added null checks for EditorClient, since it can be NULL when the page
1459         has been destroyed. Removed external access to EditorClient, since it's
1460         an implementation detail of the Editor.
1461
1462         No test case because this crash depends on window tear-down. Layout tests
1463         pass.
1464         
1465 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
1466
1467         Fix build.
1468         
1469         * platform/network/mac/ResourceHandleMac.mm:
1470         (WebCore::ResourceHandle::receivedResponse):
1471         Fix tyop.
1472
1473 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
1474
1475         Reviewed by Darin.
1476
1477         Have ResourceResponse hold on to the platform object and do lazy
1478         initialization of the data members.
1479         
1480         * WebCore.xcodeproj/project.pbxproj:
1481         * loader/mac/FrameLoaderMac.mm:
1482         (WebCore::FrameLoader::loadResourceSynchronously):
1483         * platform/network/ResourceRequest.cpp:
1484         (WebCore::ResourceRequest::updatePlatformRequest):
1485         (WebCore::ResourceRequest::updateResourceRequest):
1486         * platform/network/ResourceResponse.cpp: Added.
1487         (WebCore::ResourceResponse::url):
1488         (WebCore::ResourceResponse::mimeType):
1489         (WebCore::ResourceResponse::expectedContentLength):
1490         (WebCore::ResourceResponse::textEncodingName):
1491         (WebCore::ResourceResponse::suggestedFilename):
1492         (WebCore::ResourceResponse::httpStatusCode):
1493         (WebCore::ResourceResponse::setHTTPStatusCode):
1494         (WebCore::ResourceResponse::httpStatusText):
1495         (WebCore::ResourceResponse::setHTTPStatusText):
1496         (WebCore::ResourceResponse::httpHeaderField):
1497         (WebCore::ResourceResponse::httpHeaderFields):
1498         (WebCore::ResourceResponse::setExpirationDate):
1499         (WebCore::ResourceResponse::expirationDate):
1500         (WebCore::ResourceResponse::setLastModifiedDate):
1501         (WebCore::ResourceResponse::lastModifiedDate):
1502         (WebCore::ResourceResponse::updateResourceResponse):
1503         * platform/network/ResourceResponse.h:
1504         (WebCore::ResourceResponse::ResourceResponse):
1505         (WebCore::ResourceResponse::isMultipart):
1506         * platform/network/mac/ResourceHandleMac.mm:
1507         (WebCore::ResourceHandle::receivedResponse):
1508         (WebCore::ResourceHandle::willSendRequest):
1509         * platform/network/mac/ResourceResponseMac.h: Removed.
1510         * platform/network/mac/ResourceResponseMac.mm:
1511         (-[NSURLResponse WebCore]):
1512
1513 2006-11-28  Alice Liu  <alice.liu@apple.com>
1514
1515         Reviewed by Maciej.
1516
1517         A fix for a couple failing layout tests involving copy/cut in iframes.
1518
1519         * bridge/EditorClient.h:
1520         Add frame parameter to dataForArchivedSelectionInFrame instead of
1521         just getting the webview's selectedFrame.
1522
1523         * platform/mac/PasteboardMac.mm:
1524         (Pasteboard::writeSelection):
1525         Pass in the frame
1526
1527 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
1528
1529         Reviewed by Beth Dakin.
1530
1531         Fixed <rdar://problem/4844855> Should clarify when to create clients in 
1532         the WebCore client API
1533         
1534         All clients must now be supplied as constructor arguments. This clarifies 
1535         when you need to create clients, and also guarantees that objects can't 
1536         (for the most part) be in a clientless state.
1537
1538         Layout tests pass. No leaks reported.
1539         
1540         * bridge/mac/WebCoreFrameBridge.mm: I had to move some initialization up into
1541         WebKit to resolve circular dependencies at init time.
1542
1543 2006-11-28  Adam Roben  <aroben@apple.com>
1544
1545         Reviewed by Ada.
1546
1547         Add platform-specific constructor/destructor to ContextMenu so we can
1548         properly retain/release the platform menu description.
1549
1550         * platform/ContextMenu.h:
1551         (WebCore::ContextMenu::platformDescription):
1552         * platform/mac/ContextMenuMac.mm:
1553         (WebCore::ContextMenu::ContextMenu):
1554         (WebCore::ContextMenu::~ContextMenu):
1555         (WebCore::getNSMenuItem):
1556         (WebCore::ContextMenu::appendItem):
1557         (WebCore::ContextMenu::itemCount):
1558         (WebCore::ContextMenu::insertItem):
1559         (WebCore::ContextMenu::setPlatformDescription):
1560
1561 2006-11-28  Adam Roben  <aroben@apple.com>
1562
1563         Build fix.
1564
1565         * platform/network/mac/ResourceRequestMac.mm:
1566
1567 2006-11-28  David Harrison  <harrison@apple.com>
1568
1569         Reviewed by Adele.
1570
1571         <rdar://problem/4852804> selection color does not get drawn over the missing image rectangle
1572
1573         Test:
1574         * editing/selection/select-missing-image.html: Added.
1575
1576         * rendering/RenderImage.cpp:
1577         (WebCore::RenderImage::paint):
1578         Draw the selection tint even if the image itself is not available.
1579
1580 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
1581
1582         Reviewed by Maciej.
1583
1584         Have ResourceRequest hold on to the platform object so we don't
1585         have to convert back and forth when nothing in the object changes.
1586
1587         * WebCore.exp:
1588         * WebCore.xcodeproj/project.pbxproj:
1589         * loader/mac/FrameLoaderMac.mm:
1590         (WebCore::FrameLoader::continueAfterNavigationPolicy):
1591         * page/Chrome.cpp:
1592         (WebCore::Chrome::pageRect):
1593         * platform/network/ResourceRequest.cpp: Added.
1594         (WebCore::ResourceRequest::isEmpty):
1595         (WebCore::ResourceRequest::url):
1596         (WebCore::ResourceRequest::setURL):
1597         (WebCore::ResourceRequest::cachePolicy):
1598         (WebCore::ResourceRequest::setCachePolicy):
1599         (WebCore::ResourceRequest::timeoutInterval):
1600         (WebCore::ResourceRequest::setTimeoutInterval):
1601         (WebCore::ResourceRequest::mainDocumentURL):
1602         (WebCore::ResourceRequest::setMainDocumentURL):
1603         (WebCore::ResourceRequest::httpMethod):
1604         (WebCore::ResourceRequest::setHTTPMethod):
1605         (WebCore::ResourceRequest::httpHeaderFields):
1606         (WebCore::ResourceRequest::httpHeaderField):
1607         (WebCore::ResourceRequest::setHTTPHeaderField):
1608         (WebCore::ResourceRequest::httpBody):
1609         (WebCore::ResourceRequest::setHTTPBody):
1610         (WebCore::ResourceRequest::allowHTTPCookies):
1611         (WebCore::ResourceRequest::setAllowHTTPCookies):
1612         (WebCore::ResourceRequest::updatePlatformRequest):
1613         (WebCore::ResourceRequest::updateResourceRequest):
1614         (WebCore::ResourceRequest::addHTTPHeaderField):
1615         (WebCore::ResourceRequest::addHTTPHeaderFields):
1616         * platform/network/ResourceRequest.h:
1617         (WebCore::ResourceRequest::ResourceRequest):
1618         * platform/network/mac/ResourceHandleMac.mm:
1619         (WebCore::ResourceHandle::willSendRequest):
1620         * platform/network/mac/ResourceRequestMac.h: Removed.
1621         * platform/network/mac/ResourceRequestMac.mm:
1622         (WebCore::ResourceRequest::nsURLRequest):
1623         (WebCore::ResourceRequest::doUpdateResourceRequest):
1624         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1625
1626 2006-11-28  Adam Roben  <aroben@apple.com>
1627
1628         Reviewed by Beth.
1629
1630         More WebCore context menu work (still not turned on, however).
1631
1632         Split ContextMenuItem into its own files and make it a class.
1633
1634         * WebCore.exp: Updated symbols.
1635         * WebCore.xcodeproj/project.pbxproj: Added new ContextMenuItem files.
1636         * platform/ContextMenu.cpp:
1637         (WebCore::ContextMenu::populate): Code cleanup.
1638         * platform/ContextMenu.h: Split ContextMenuItem into a separate file,
1639         removed redundant "Menu" part of platformMenuDescription(),
1640         setPlatformMenuDescription().
1641         (WebCore::ContextMenu::ContextMenu):
1642         (WebCore::ContextMenu::hitTestResult):
1643         (WebCore::ContextMenu::platformDescription):
1644         * platform/ContextMenuItem.h: Added. Made ContextMenuItem a
1645         full-fledged class.
1646         (WebCore::):
1647         (WebCore::ContextMenuItem::ContextMenuItem):
1648         (WebCore::ContextMenuItem::menu):
1649         (WebCore::ContextMenuItem::platformDescription):
1650         (WebCore::ContextMenuItem::type):
1651         (WebCore::ContextMenuItem::action):
1652         (WebCore::ContextMenuItem::title):
1653         * platform/mac/ContextMenuItemMac.mm: Added.
1654         (WebCore::ContextMenuItem::ContextMenuItem):
1655         * platform/mac/ContextMenuMac.mm: Updated for ContextMenuItem changes.
1656         (-[MenuTarget forwardContextMenuAction:]):
1657         (getNSMenuItem): Handle separator items.
1658         (ContextMenu::appendItem):
1659         (ContextMenu::itemCount):
1660         (ContextMenu::insertItem):
1661         (ContextMenu::setPlatformDescription):
1662         * page/ContextMenuController.h: Updated declaration, added getter.
1663         (WebCore::ContextMenuController::contextMenu):
1664
1665         Added some more context menu plumbing.
1666
1667         * dom/EventTargetNode.cpp:
1668         (WebCore::EventTargetNode::defaultEventHandler): Added code to call the
1669         ContextMenuController when a context menu event is received.
1670         * page/ContextMenuClient.h: New client method declaration.
1671         * page/ContextMenuController.cpp:
1672         (WebCore::ContextMenuController::handleContextMenuEvent): Set the event
1673         defaultHandled after handling it.
1674         (WebCore::ContextMenuController::contextMenuItemSelected): Take a
1675         ContextMenuItem instead of a separate action and title.
1676
1677         Changed event-handling methods to return bools to signify whether the
1678         event was handled or not. This is needed so we can know whether to hand
1679         the event off to the OS. Also restructured some code to use early
1680         returns instead of nesting ifs.
1681
1682         * page/EventHandler.cpp:
1683         (WebCore::EventHandler::handleMousePressEventDoubleClick):
1684         (WebCore::EventHandler::handleMousePressEventTripleClick):
1685         (WebCore::EventHandler::handleMousePressEventSingleClick):
1686         (WebCore::EventHandler::handleMousePressEvent):
1687         (WebCore::EventHandler::handleMouseMoveEvent):
1688         (WebCore::EventHandler::handleMouseReleaseEvent):
1689         (WebCore::EventHandler::handleMouseDoubleClickEvent):
1690         (WebCore::EventHandler::handleWheelEvent):
1691         (WebCore::EventHandler::canMouseDownStartSelect):
1692         * page/EventHandler.h:
1693         * page/FrameView.cpp:
1694         (WebCore::FrameView::handleMouseMoveEvent):
1695         (WebCore::FrameView::handleMouseReleaseEvent):
1696         * page/FrameView.h:
1697         * platform/ScrollBar.h: More bool return values.
1698         (WebCore::Scrollbar::handleMouseMoveEvent):
1699         (WebCore::Scrollbar::handleMouseOutEvent):
1700         * platform/Widget.h: Ditto.
1701         (WebCore::Widget::handleMouseMoveEvent):
1702         (WebCore::Widget::handleMouseReleaseEvent):
1703
1704         Reverted the changes made in r17805 so that we can have fewer header
1705         #includes.
1706
1707         * page/Page.cpp:
1708         (WebCore::Page::Page):
1709         * page/Page.h: Ditto.
1710         (WebCore::Page::dragCaretController):
1711         (WebCore::Page::chrome):
1712         (WebCore::Page::contextMenuController):
1713
1714 2006-11-28  Alice Liu  <alice.liu@apple.com>
1715
1716         Reviewed by Justin and Adam.
1717
1718         All layout tests pass as they do without this patch
1719
1720         * WebCore.exp:
1721         Exposed functions in Editor and removed functions in FrameMac due to changes in WebHTMLView.m
1722
1723         * WebCore.xcodeproj/project.pbxproj:
1724         Added Pasteboard.h, PasteboardMac.mm, WebNSAttributedStringExtras.h&mm, EditorMac.mm
1725
1726         * bridge/EditorClient.h:
1727         Added smartInsertDeleteEnabled and shouldInsertNode and some mac-specific functions
1728
1729         * bridge/mac/FrameMac.h:
1730         * bridge/mac/FrameMac.mm:
1731         Removed dispatchCPPEvent and [can|try]DHTML[cut|copy|paste] since the Editor's are called now
1732
1733         * dom/CharacterData.h:
1734         (WebCore::CharacterData::isCharacterDataNode):
1735         * dom/Node.h:
1736         (WebCore::Node::isCharacterDataNode):
1737         Added a type-identifying function to Node and the proper subclass
1738
1739         * dom/Clipboard.h:
1740         Exposed setAccessPolicy as public
1741         
1742         * editing/Editor.h:
1743         * editing/Editor.cpp:
1744         Implemented the following
1745         (WebCore::Editor::canDHTMLCut):
1746         (WebCore::Editor::canDHTMLCopy):
1747         (WebCore::Editor::canDHTMLPaste):
1748         (WebCore::Editor::canSmartCopyOrDelete):
1749         (WebCore::Editor::deleteSelection):
1750         (WebCore::Editor::pasteAsPlainTextWithPasteboard):
1751         (WebCore::Editor::pasteWithPasteboard):
1752         (WebCore::Editor::canSmartReplaceWithPasteboard):
1753         (WebCore::Editor::shouldInsertFragment):
1754         (WebCore::Editor::replaceSelectionWithFragment):
1755         (WebCore::Editor::replaceSelectionWithText):
1756         (WebCore::Editor::selectedRange):
1757         (WebCore::Editor::shouldDeleteRange):
1758         (WebCore::Editor::tryDHTMLCopy):
1759         (WebCore::Editor::tryDHTMLCut):
1760         (WebCore::Editor::tryDHTMLPaste):
1761         (WebCore::Editor::writeSelectionToPasteboard):
1762         (WebCore::Editor::dispatchCPPEvent):
1763         (WebCore::Editor::cut):
1764         (WebCore::Editor::copy):
1765         (WebCore::Editor::paste):
1766                 
1767         * platform/mac/ClipboardAccessPolicy.h: Removed.
1768         Not removed, but moved to dom/ClipboardAccessPolicy.h
1769         
1770         * platform/mac/EditorMac.mm: Added.
1771         (WebCore::Editor::newGeneralClipboard):
1772
1773         * platform/Pasteboard.h: Added.
1774         * platform/mac/PasteboardMac.mm: Added.
1775         The pasteboard class follows a singleton pattern
1776         (Pasteboard::generalPasteboard):
1777         (Pasteboard::~Pasteboard):
1778         (Pasteboard::Pasteboard):
1779         (Pasteboard::clearTypes):
1780         (Pasteboard::writeSelection):
1781         (Pasteboard::selectionPasteboardTypes):
1782         (Pasteboard::canSmartReplace):
1783         (Pasteboard::plainText):
1784         (Pasteboard::documentFragment):
1785         
1786         * platform/mac/WebNSAttributedStringExtras.h: Added.
1787         * platform/mac/WebNSAttributedStringExtras.mm: Added.
1788         Added select portions of this file from WebKit because the pasteboard needed the following function:
1789         (-[NSAttributedString _web_attributedStringByStrippingAttachmentCharacters]):
1790
1791 2006-11-28  Justin Garcia  <justin.garcia@apple.com>
1792
1793         Reviewed by harrison
1794
1795         <rdar://problem/4397952>
1796         Cannot select buttons at the end of a document, preventing copy/paste
1797         
1798         There were no VisiblePositions before/after buttons because editingIgnoresContent
1799         returned false for buttons. 
1800
1801         * dom/Position.cpp:
1802         (WebCore::Position::upstream): Fixed a comment.
1803         (WebCore::Position::downstream): Ditto.
1804         * editing/DeleteSelectionCommand.cpp:
1805         (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
1806         * editing/htmlediting.cpp:
1807         (WebCore::editingIgnoresContent): It's unnecessary to prefer renderer 
1808         checks over tag name checks because it seems that a node of a tag name 
1809         that we do not ignore content for can't have a renderer of a type that we do.
1810         (WebCore::canHaveChildrenForEditing): Added selects, buttons, applets, and embeds.
1811         * editing/visible_units.cpp:
1812         (WebCore::previousLinePosition): Migrate to enclosingBlock.  Fixes a bug where the
1813         caret would get stuck moving up/down a line from a caret just before an 
1814         input element.
1815         (WebCore::nextLinePosition): Ditto.
1816
1817 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
1818
1819         Reviewed by Adam.
1820
1821         Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref 
1822         calls cause .5% PLT regression.
1823         
1824         Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
1825         from the Frame to the Page, since it's only responsible for
1826         Webview-level delegate calls.
1827         
1828         I don't really love this design, but it fixes the regression and allows
1829         a single WebKit object to implement multiple client interfaces.
1830         
1831         Layout tests pass.
1832
1833 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
1834
1835         Try fixing the build.
1836         
1837         * platform/graphics/IntRect.cpp:
1838         (WebCore::IntRect::IntRect):
1839
1840 2006-11-27  Beth Dakin  <bdakin@apple.com>
1841
1842         Reviewed by Adam.
1843
1844         Getting rid of some of the critical FIXMEs in ContextMenu.cpp.
1845
1846         * bridge/mac/FrameMac.h: Two new spell checker functions from 
1847         WebKit. (We will be able to delete the WebKit versions once we 
1848         switch over to WebCore context menus.)
1849         * bridge/mac/FrameMac.mm:
1850         (WebCore::FrameMac::isSelectionMisspelled):
1851         (WebCore::core): Convert from NSArray of Strings to a Vector of 
1852         Strings.
1853         (WebCore::FrameMac::guessesForMisspelledSelection):
1854         * loader/FrameLoader.cpp:
1855         (WebCore::FrameLoader::canHandleRequest):
1856         * loader/FrameLoader.h: Make canHandleRequest available through the 
1857         FrameLoader.
1858         * loader/FrameLoaderClient.h: canHandleRequest takes a 
1859         ResourceRequest instead of an NSURLRequest.
1860         * loader/mac/FrameLoaderMac.mm:
1861         (WebCore::FrameLoader::continueAfterNavigationPolicy): Same
1862         * page/Frame.h: New spell checker functions moved to Frame. These 
1863         should be moved some place better some day, but FrameMac currently 
1864         seems to be the place to be for spell checker stuff.
1865         * platform/ContextMenu.cpp:
1866         (WebCore::ContextMenu::populate): Use new FrameLoader and spell 
1867         checking functionality to get rid of two if (true) statements. Also 
1868         add spelling guesses to the editing context menus.
1869
1870 2006-11-27  Alexey Proskuryakov  <ap@webkit.org>
1871
1872         Reviewed by Hyatt.
1873
1874         http://bugs.webkit.org/show_bug.cgi?id=11694
1875         XSLT output method does not default to HTML when the target document is HTML
1876
1877         Test: fast/xsl/default-html.html
1878
1879         * xml/XSLTProcessor.cpp:
1880         (WebCore::XSLTProcessor::transformToString): Make mimeType an input/output parameter, 
1881         serving as a hint when the stylesheet doesn't specify the output method.
1882         (WebCore::XSLTProcessor::transformToFragment): Set mimeType to text/html if the target
1883         document is HTML.
1884
1885 2006-11-27  Oliver Hunt  <oliver@apple.com>
1886
1887         Reviewed by Adam.
1888
1889         Fixes a crash in SVG caused by an attempt to 
1890         perform css overflow clipping by preventing
1891         the css overflow clip from being set in SVG.
1892         
1893         <rdar:/problems/4839568>
1894
1895         * WebCore.xcodeproj/project.pbxproj:
1896         * rendering/RenderForeignObject.cpp:
1897         (WebCore::RenderForeignObject::RenderForeignObject):
1898         * rendering/RenderForeignObject.h:
1899         * rendering/RenderSVGBlock.cpp: Added.
1900         (WebCore::RenderSVGBlock::RenderSVGBlock):
1901         (WebCore::RenderSVGBlock::setStyle):
1902         * rendering/RenderSVGBlock.h: Added.
1903         * rendering/RenderSVGText.cpp:
1904         (WebCore::RenderSVGText::RenderSVGText):
1905         * rendering/RenderSVGText.h:
1906
1907 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
1908
1909         Reviewed by Adam.
1910
1911         Add an explicit IntRect constructor that takes a FloatRect.
1912         
1913         * platform/graphics/IntRect.cpp:
1914         (WebCore::IntRect::IntRect):
1915         * platform/graphics/IntRect.h:
1916
1917 2006-11-27  Ada Chan  <adachan@apple.com>
1918
1919         Reviewed by Adam.
1920
1921         Moved WebCoreCache up to WebKit.
1922
1923         * WebCore.exp:
1924         * WebCore.xcodeproj/project.pbxproj:
1925         * bridge/mac/WebCoreCache.h: Removed.
1926         * bridge/mac/WebCoreCache.mm: Removed.
1927
1928 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
1929
1930         Reviewed by Adam.
1931
1932         Move addMessageToConsole to Chrome.
1933         
1934         * bindings/js/kjs_events.cpp:
1935         (KJS::JSAbstractEventListener::handleEvent):
1936         * bindings/js/kjs_proxy.cpp:
1937         (WebCore::KJSProxy::evaluate):
1938         * bindings/js/kjs_window.cpp:
1939         (KJS::Window::isSafeScript):
1940         (KJS::ScheduledAction::execute):
1941         * bridge/mac/FrameMac.h:
1942         * bridge/mac/FrameMac.mm:
1943         * bridge/mac/WebCoreFrameBridge.h:
1944         * page/Chrome.cpp:
1945         (WebCore::Chrome::addMessageToConsole):
1946         * page/Chrome.h:
1947         * page/ChromeClient.h:
1948         * page/Frame.h:
1949
1950 2006-11-27  Adele Peterson  <adele@apple.com>
1951
1952         Reviewed by Hyatt.
1953
1954         - Fix for http://bugs.webkit.org/show_bug.cgi?id=8062
1955           Caret color in new text field should take background color and foreground color into consideration
1956
1957         * editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
1958           Use the foreground color of the rootEditableElement to determine the caret color.  This will work well for text controls in web pages (since the root is always the actual form control)
1959           as well as in editable WebViews, like in Mail, which will just pick up the color from the body element.
1960
1961 2006-11-26  Simon Hausmann  <hausmann@kde.org>
1962
1963         Reviewed by Maciej.
1964
1965         http://bugs.webkit.org/show_bug.cgi?id=11693
1966         Fix the Qt build, adapt to various enum/class renamings.
1967
1968         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1969         (WebCore::KRenderingDeviceQt::createResource):
1970         (WebCore::KRenderingDeviceQt::createPaintServer):
1971         * kcanvas/device/qt/KRenderingDeviceQt.h:
1972         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
1973         (WebCore::SVGPaintServerLinearGradient::setup):
1974         * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
1975         (WebCore::SVGPaintServer::renderPath):
1976         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
1977         (WebCore::setup):
1978         * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
1979         (WebCore::SVGPaintServerSolid::setup):
1980
1981 2006-11-24  Rob Buis  <buis@kde.org>
1982
1983         Reviewed by Mitz.
1984
1985         http://bugs.webkit.org/show_bug.cgi?id=11666
1986         .getScreenCTM() returns wrong values
1987
1988         Take into account the local transform matrix too and
1989         so fix getScreenCTM/getCTM for <text>.
1990
1991         * ksvg2/svg/SVGStyledTransformableElement.cpp:
1992         (SVGStyledTransformableElement::getCTM):
1993         (SVGStyledTransformableElement::getScreenCTM):
1994         * ksvg2/svg/SVGTextElement.cpp:
1995         (WebCore::SVGTextElement::getScreenCTM):
1996         (WebCore::SVGTextElement::getCTM):
1997         * ksvg2/svg/SVGTransformable.cpp:
1998         (WebCore::SVGTransformable::getCTM):
1999         (WebCore::SVGTransformable::getScreenCTM):
2000         * ksvg2/svg/SVGTransformable.h:
2001
2002 2006-11-22  Rob Buis  <buis@kde.org>
2003
2004         Reviewed by Eric.
2005
2006         http://bugs.webkit.org/show_bug.cgi?id=11661
2007         SVG: stroke not sensitive to mouse events (hit testing fails)
2008
2009         Use mapAbsolutePointToLocal when hit-testing strokes.
2010
2011         * rendering/RenderPath.cpp:
2012         (WebCore::RenderPath::fillContains):
2013         (WebCore::RenderPath::nodeAtPoint):
2014
2015 2006-11-21  Anders Carlsson  <acarlsson@apple.com>
2016
2017         Reviewed by Mitz.
2018
2019         General SVG cleanup. Change some enums to match the style guidelines, use PLATFORM(CG) instead of PLATFORM(MAC).
2020         Remove config.h inluce from AffineTransform.h
2021         
2022         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp:
2023         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2024         (WebCore::KRenderingDeviceQuartz::createResource):
2025         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2026         (WebCore::sharedSolidPaintServer):
2027         * ksvg2/svg/SVGFilterElement.cpp:
2028         (WebCore::SVGFilterElement::canvasResource):
2029         * ksvg2/svg/SVGLinearGradientElement.cpp:
2030         (WebCore::SVGLinearGradientElement::buildGradient):
2031         * ksvg2/svg/SVGLinearGradientElement.h:
2032         (WebCore::SVGLinearGradientElement::gradientType):
2033         * ksvg2/svg/SVGPatternElement.cpp:
2034         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2035         (WebCore::SVGPatternElement::canvasResource):
2036         * ksvg2/svg/SVGRadialGradientElement.cpp:
2037         (WebCore::SVGRadialGradientElement::buildGradient):
2038         * ksvg2/svg/SVGRadialGradientElement.h:
2039         (WebCore::SVGRadialGradientElement::gradientType):
2040         * platform/graphics/AffineTransform.h:
2041         * platform/graphics/svg/SVGPaintServer.h:
2042         (WebCore::):
2043         * platform/graphics/svg/SVGPaintServerGradient.cpp:
2044         (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
2045         (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
2046         * platform/graphics/svg/SVGPaintServerGradient.h:
2047         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
2048         (WebCore::SVGPaintServerLinearGradient::type):
2049         * platform/graphics/svg/SVGPaintServerPattern.h:
2050         (WebCore::SVGPaintServerPattern::type):
2051         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
2052         (WebCore::SVGPaintServerRadialGradient::type):
2053         * platform/graphics/svg/SVGPaintServerSolid.h:
2054         (WebCore::SVGPaintServerSolid::type):
2055         * platform/graphics/svg/SVGResource.h:
2056         (WebCore::):
2057         * platform/graphics/svg/cg/SVGPaintServerCg.cpp:
2058         (WebCore::SVGPaintServer::renderPath):
2059         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
2060         (WebCore::SVGPaintServerGradient::updateQuartzGradientCache):
2061         (WebCore::SVGPaintServerGradient::teardown):
2062         (WebCore::SVGPaintServerGradient::renderPath):
2063         (WebCore::SVGPaintServerGradient::setup):
2064         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
2065         (WebCore::SVGPaintServerPattern::setup):
2066         * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
2067         (WebCore::SVGPaintServerSolid::setup):
2068         * rendering/RenderPath.cpp:
2069         (WebCore::RenderPath::paint):
2070         * rendering/SVGInlineFlowBox.cpp:
2071         (WebCore::paintSVGInlineFlow):
2072
2073 2006-11-21  Nikolas Zimmermann  <zimmermann@kde.org>
2074
2075         Reviewed by Oliver.
2076
2077         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11658
2078
2079         Move KRenderingPaintServer* classes to the location
2080         of all other resources (platform/graphics/svg).
2081
2082         Soon the whole platform/graphics/svg stuff will bemoved
2083         into ksvg2/ itself, as discussed with Darin.
2084
2085         * CMakeLists.txt:
2086         * WebCore.xcodeproj/project.pbxproj:
2087         * kcanvas/device/KRenderingDevice.h:
2088         * kcanvas/device/KRenderingPaintServer.h: Removed.
2089         * kcanvas/device/KRenderingPaintServerGradient.cpp: Removed.
2090         * kcanvas/device/KRenderingPaintServerGradient.h: Removed.
2091         * kcanvas/device/KRenderingPaintServerPattern.cpp: Removed.
2092         * kcanvas/device/KRenderingPaintServerPattern.h: Removed.
2093         * kcanvas/device/KRenderingPaintServerSolid.cpp: Removed.
2094         * kcanvas/device/KRenderingPaintServerSolid.h: Removed.
2095         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: Removed.
2096         * kcanvas/device/qt/KRenderingPaintServerGradientQt.h: Removed.
2097         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: Removed.
2098         * kcanvas/device/qt/KRenderingPaintServerPatternQt.h: Removed.
2099         * kcanvas/device/qt/KRenderingPaintServerQt.cpp: Removed.
2100         * kcanvas/device/qt/KRenderingPaintServerQt.h: Removed.
2101         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: Removed.
2102         * kcanvas/device/qt/KRenderingPaintServerSolidQt.h: Removed.
2103         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2104         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp:
2105         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2106         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2107         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Removed.
2108         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Removed.
2109         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h: Removed.
2110         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2111         (WebCore::sharedSolidPaintServer):
2112         (WebCore::KSVGPainterFactory::fillPaintServer):
2113         (WebCore::KSVGPainterFactory::strokePaintServer):
2114         * ksvg2/misc/KCanvasRenderingStyle.h:
2115         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2116         * ksvg2/svg/SVGFEOffsetElement.cpp:
2117         * ksvg2/svg/SVGGradientElement.cpp:
2118         (WebCore::SVGGradientElement::canvasResource):
2119         (WebCore::SVGGradientElement::resourceNotification):
2120         (WebCore::SVGGradientElement::rebuildStops):
2121         * ksvg2/svg/SVGGradientElement.h:
2122         * ksvg2/svg/SVGLinearGradientElement.cpp:
2123         (WebCore::SVGLinearGradientElement::buildGradient):
2124         * ksvg2/svg/SVGLinearGradientElement.h:
2125         (WebCore::SVGLinearGradientElement::gradientType):
2126         * ksvg2/svg/SVGPatternElement.cpp:
2127         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2128         (WebCore::SVGPatternElement::canvasResource):
2129         * ksvg2/svg/SVGPatternElement.h:
2130         * ksvg2/svg/SVGRadialGradientElement.cpp:
2131         (WebCore::SVGRadialGradientElement::buildGradient):
2132         * ksvg2/svg/SVGRadialGradientElement.h:
2133         (WebCore::SVGRadialGradientElement::gradientType):
2134         * platform/graphics/svg/SVGPaintServer.cpp: Added.
2135         (WebCore::SVGPaintServer::SVGPaintServer):
2136         (WebCore::SVGPaintServer::~SVGPaintServer):
2137         (WebCore::SVGPaintServer::activeClient):
2138         (WebCore::SVGPaintServer::setActiveClient):
2139         (WebCore::SVGPaintServer::isPaintingText):
2140         (WebCore::SVGPaintServer::setPaintingText):
2141         (WebCore::operator<<):
2142         (WebCore::getPaintServerById):
2143         * platform/graphics/svg/SVGPaintServer.h: Added.
2144         (WebCore::):
2145         (WebCore::SVGPaintServer::isPaintServer):
2146         * platform/graphics/svg/SVGPaintServerGradient.cpp: Added.
2147         (WebCore::compareStopOffset):
2148         (WebCore::operator<<):
2149         (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
2150         (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
2151         (WebCore::SVGPaintServerGradient::gradientStops):
2152         (WebCore::SVGPaintServerGradient::setGradientStops):
2153         (WebCore::SVGPaintServerGradient::spreadMethod):
2154         (WebCore::SVGPaintServerGradient::setGradientSpreadMethod):
2155         (WebCore::SVGPaintServerGradient::boundingBoxMode):
2156         (WebCore::SVGPaintServerGradient::setBoundingBoxMode):
2157         (WebCore::SVGPaintServerGradient::gradientTransform):
2158         (WebCore::SVGPaintServerGradient::setGradientTransform):
2159         (WebCore::SVGPaintServerGradient::listener):
2160         (WebCore::SVGPaintServerGradient::setListener):
2161         (WebCore::SVGPaintServerGradient::externalRepresentation):
2162         * platform/graphics/svg/SVGPaintServerGradient.h: Added.
2163         (WebCore::):
2164         (WebCore::SVGPaintServerGradient::):
2165         (WebCore::makeGradientStop):
2166         * platform/graphics/svg/SVGPaintServerLinearGradient.cpp: Added.
2167         (WebCore::SVGPaintServerLinearGradient::SVGPaintServerLinearGradient):
2168         (WebCore::SVGPaintServerLinearGradient::~SVGPaintServerLinearGradient):
2169         (WebCore::SVGPaintServerLinearGradient::gradientStart):
2170         (WebCore::SVGPaintServerLinearGradient::setGradientStart):
2171         (WebCore::SVGPaintServerLinearGradient::gradientEnd):
2172         (WebCore::SVGPaintServerLinearGradient::setGradientEnd):
2173         (WebCore::SVGPaintServerLinearGradient::externalRepresentation):
2174         * platform/graphics/svg/SVGPaintServerLinearGradient.h: Added.
2175         (WebCore::SVGPaintServerLinearGradient::type):
2176         * platform/graphics/svg/SVGPaintServerPattern.cpp: Added.
2177         (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
2178         (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern):
2179         (WebCore::SVGPaintServerPattern::bbox):
2180         (WebCore::SVGPaintServerPattern::setBbox):
2181         (WebCore::SVGPaintServerPattern::boundingBoxMode):
2182         (WebCore::SVGPaintServerPattern::setBoundingBoxMode):
2183         (WebCore::SVGPaintServerPattern::tile):
2184         (WebCore::SVGPaintServerPattern::setTile):
2185         (WebCore::SVGPaintServerPattern::patternTransform):
2186         (WebCore::SVGPaintServerPattern::setPatternTransform):
2187         (WebCore::SVGPaintServerPattern::listener):
2188         (WebCore::SVGPaintServerPattern::setListener):
2189         (WebCore::SVGPaintServerPattern::externalRepresentation):
2190         * platform/graphics/svg/SVGPaintServerPattern.h: Added.
2191         (WebCore::SVGPaintServerPattern::type):
2192         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp: Added.
2193         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
2194         (WebCore::SVGPaintServerRadialGradient::~SVGPaintServerRadialGradient):
2195         (WebCore::SVGPaintServerRadialGradient::gradientCenter):
2196         (WebCore::SVGPaintServerRadialGradient::setGradientCenter):
2197         (WebCore::SVGPaintServerRadialGradient::gradientFocal):
2198         (WebCore::SVGPaintServerRadialGradient::setGradientFocal):
2199         (WebCore::SVGPaintServerRadialGradient::gradientRadius):
2200         (WebCore::SVGPaintServerRadialGradient::setGradientRadius):
2201         (WebCore::SVGPaintServerRadialGradient::externalRepresentation):
2202         * platform/graphics/svg/SVGPaintServerRadialGradient.h: Added.
2203         (WebCore::SVGPaintServerRadialGradient::type):
2204         * platform/graphics/svg/SVGPaintServerSolid.cpp: Added.
2205         (WebCore::SVGPaintServerSolid::SVGPaintServerSolid):
2206         (WebCore::SVGPaintServerSolid::~SVGPaintServerSolid):
2207         (WebCore::SVGPaintServerSolid::color):
2208         (WebCore::SVGPaintServerSolid::setColor):
2209         (WebCore::SVGPaintServerSolid::externalRepresentation):
2210         * platform/graphics/svg/SVGPaintServerSolid.h: Added.
2211         (WebCore::SVGPaintServerSolid::type):
2212         * platform/graphics/svg/SVGResource.cpp:
2213         * platform/graphics/svg/SVGResource.h:
2214         * platform/graphics/svg/SVGResourceClipper.cpp:
2215         * platform/graphics/svg/SVGResourceMarker.cpp:
2216         * platform/graphics/svg/SVGResourceMasker.cpp:
2217         * platform/graphics/svg/cg/SVGPaintServerCg.cpp: Added.
2218         (WebCore::SVGPaintServer::draw):
2219         (WebCore::SVGPaintServer::teardown):
2220         (WebCore::SVGPaintServer::renderPath):
2221         (WebCore::SVGPaintServer::strokePath):
2222         (WebCore::SVGPaintServer::clipToStrokePath):
2223         (WebCore::SVGPaintServer::fillPath):
2224         (WebCore::SVGPaintServer::clipToFillPath):
2225         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: Added.
2226         (WebCore::cgGradientCallback):
2227         (WebCore::CGShadingRefForLinearGradient):
2228         (WebCore::CGShadingRefForRadialGradient):
2229         (WebCore::SVGPaintServerGradient::invalidateCaches):
2230         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
2231         (WebCore::SVGPaintServerGradient::updateQuartzGradientCache):
2232         (WebCore::SVGPaintServerGradient::teardown):
2233         (WebCore::SVGPaintServerGradient::renderPath):
2234         (WebCore::SVGPaintServerGradient::setup):
2235         (WebCore::SVGPaintServerGradient::invalidate):
2236         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: Added.
2237         (WebCore::patternCallback):
2238         (WebCore::SVGPaintServerPattern::setup):
2239         (WebCore::SVGPaintServerPattern::teardown):
2240         * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: Added.
2241         (WebCore::SVGPaintServerSolid::setup):
2242         * platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp: Added.
2243         (WebCore::SVGPaintServerGradient::fillColorArray):
2244         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp: Added.
2245         (WebCore::SVGPaintServerLinearGradient::setup):
2246         * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp: Added.
2247         (WebCore::SVGPaintServerPattern::setup):
2248         * platform/graphics/svg/qt/SVGPaintServerQt.cpp: Added.
2249         (WebCore::SVGPaintServer::setPenProperties):
2250         (WebCore::SVGPaintServer::draw):
2251         (WebCore::SVGPaintServer::teardown):
2252         (WebCore::SVGPaintServer::renderPath):
2253         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp: Added.
2254         (WebCore::setup):
2255         * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp: Added.
2256         (WebCore::SVGPaintServerSolid::setup):
2257         * rendering/RenderPath.cpp:
2258         (WebCore::RenderPath::paint):
2259         * rendering/SVGInlineFlowBox.cpp:
2260         (WebCore::paintSVGInlineFlow):
2261         * rendering/SVGRenderTreeAsText.cpp:
2262         (WebCore::writeStyle):
2263         (WebCore::writeRenderResources):
2264
2265 2006-11-21  Alex Taylor  <darwin@techvisual.co.nz>
2266
2267         Reviewed by Mitz.
2268
2269         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11587
2270
2271         Adds calculations for bottom right radius's position
2272         which was being drawn incorrectly.
2273
2274         * rendering/RenderObject.cpp:
2275         (WebCore::RenderObject::paintBorder):
2276
2277 2006-11-20  Rob Buis  <buis@kde.org>
2278
2279         Reviewed by Maciej.
2280
2281         http://bugs.webkit.org/show_bug.cgi?id=11519
2282         REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html
2283
2284         Transport disabled state from DOM element to the shadow
2285         DOM/render object.
2286
2287         * rendering/RenderFileUploadControl.cpp:
2288         (WebCore::RenderFileUploadControl::updateFromElement):
2289         * rendering/RenderTheme.h:
2290
2291 2006-11-20  Anders Carlsson  <acarlsson@apple.com>
2292
2293         Reviewed by Maciej.
2294
2295         * loader/TextResourceDecoder.cpp:
2296         (WebCore::findXMLEncoding):
2297         Use CString instead of DeprecatedCString.
2298         
2299         * platform/CString.cpp:
2300         (WebCore::CString::find):
2301         * platform/CString.h:
2302         (WebCore::CString::data):
2303         Add find method, make data method inline.
2304         
2305         * platform/TextStream.cpp:
2306         * platform/TextStream.h:
2307         Remove DeprecatedCString functions.
2308
2309 2006-11-20  Anders Carlsson  <acarlsson@apple.com>
2310
2311         Reviewed by Maciej.
2312
2313         Use CString instead of DeprecatedCString.
2314         
2315         * html/FormDataList.cpp:
2316         (WebCore::FormDataList::appendString):
2317         (WebCore::fixLineBreaks):
2318         (WebCore::FormDataList::appendFile):
2319
2320 2006-11-20  Samuel Weinig  <sam@webkit.org>
2321
2322         Reviewed by Alexey.
2323
2324         Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
2325         Fix Windows build
2326
2327         * WebCore.vcproj/WebCore/WebCore.vcproj:
2328         * bridge/win/ContextMenuClientWin.h:
2329         * bridge/win/EditorClientWin.h:
2330         * bridge/win/FrameWin.h:
2331         * platform/win/TemporaryLinkStubs.cpp:
2332         (WebCore::ContextMenu::show):
2333         (WebCore::ContextMenuClientWin::copyLinkToClipboard):
2334         (WebCore::ContextMenuClientWin::downloadURL):
2335         (WebCore::ContextMenuClientWin::copyImageToClipboard):
2336         (WebCore::ContextMenuClientWin::lookUpInDictionary):
2337         (WebCore::EditorClientWin::shouldInsertText):
2338         (WebCore::FrameLoader::reload):
2339         (WebCore::FrameWin::ignoreSpelling):
2340         (WebCore::FrameWin::learnSpelling):
2341
2342 2006-11-20  Alexey Proskuryakov  <ap@webkit.org>
2343
2344         Reviewed by Maciej.
2345
2346         http://bugs.webkit.org/show_bug.cgi?id=10736
2347         XMLHttpRequest.responseXML should be null on error
2348
2349         * dom/XMLTokenizer.cpp:
2350         (WebCore::XMLTokenizer::wellFormed):
2351         * dom/XMLTokenizer.h:
2352         (WebCore::Tokenizer::wellFormed):
2353         * dom/Document.cpp:
2354         (WebCore::Document::Document):
2355         (WebCore::Document::implicitClose):
2356         * dom/Document.h:
2357         (WebCore::Document::wellFormed):
2358         Tell whether XMLTokenizer saw an error. Always true (success) for HTML.
2359
2360         * xml/xmlhttprequest.cpp:
2361         (WebCore::XMLHttpRequest::getResponseXML): Set the document to null if it's not well-formed.
2362
2363 2006-11-20  Alexey Proskuryakov  <ap@webkit.org>
2364
2365         Reviewed by Sam Weinig.
2366
2367         http://bugs.webkit.org/show_bug.cgi?id=11633
2368         Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone
2369
2370         * dom/Document.cpp:
2371         (WebCore::Document::Document):
2372         (WebCore::Document::setXMLVersion):
2373         (WebCore::Document::setXMLStandalone):
2374         * dom/Document.h:
2375         (WebCore::Document::xmlEncoding):
2376         (WebCore::Document::xmlVersion):
2377         (WebCore::Document::xmlStandalone):
2378         (WebCore::Document::setXMLEncoding):
2379         * dom/Document.idl:
2380         * dom/XMLTokenizer.cpp:
2381         (WebCore::XMLTokenizer::startDocument):
2382         (WebCore::startDocumentHandler):
2383         (WebCore::XMLTokenizer::initializeParserContext):
2384         Added support for these properties, getting them from an libxml2 context.
2385
2386         * html/HTMLDocument.cpp:
2387         (WebCore::HTMLDocument::HTMLDocument):
2388         HTMLDocument is the only kind of document that doesn't have xmlVersion default to "1.0".
2389
2390         * bindings/scripts/CodeGeneratorJS.pm:
2391         * bindings/scripts/CodeGeneratorObjC.pm:
2392         Added WK_ucfirst to properly uppercase xmlVersion and xmlStandalone.
2393
2394 2006-11-20  Nikolas Zimmermann  <zimmermann@kde.org>
2395
2396         Reviewed by Rob.
2397
2398         Fix Qt/Linux build.
2399
2400         * platform/qt/ContextMenuClientQt.cpp:
2401         (WebCore::ContextMenuClientQt::ref):
2402         (WebCore::ContextMenuClientQt::deref):
2403         (WebCore::ContextMenuClientQt::copyLinkToClipboard):
2404         (WebCore::ContextMenuClientQt::downloadURL):
2405         (WebCore::ContextMenuClientQt::copyImageToClipboard):
2406         (WebCore::ContextMenuClientQt::lookUpInDictionary):
2407         * platform/qt/ContextMenuClientQt.h:
2408         * platform/qt/ContextMenuQt.cpp:
2409         (WebCore::ContextMenu::appendItem):
2410         (WebCore::ContextMenu::show):
2411         (WebCore::ContextMenu::itemCount):
2412         (WebCore::ContextMenu::insertItem):
2413         * platform/qt/EditorClientQt.cpp:
2414         (WebCore::EditorClientQt::shouldInsertText):
2415         * platform/qt/EditorClientQt.h:
2416         * platform/qt/FrameQt.cpp:
2417         (WebCore::FrameQt::ignoreSpelling):
2418         (WebCore::FrameQt::learnSpelling):
2419         * platform/qt/FrameQt.h:
2420         * platform/qt/TemporaryLinkStubs.cpp:
2421         (FrameLoader::reload):
2422
2423 2006-11-20  Samuel Weinig  <sam@webkit.org>
2424
2425         Reviewed by Maciej.
2426
2427         Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
2428         Fix Win32 build
2429
2430         * config.h: add #define NOMINMAX for windows build
2431         * platform/win/FontCacheWin.cpp:
2432         (WebCore::FontCache::createFontPlatformData):
2433         * platform/win/TemporaryLinkStubs.cpp: add definitions for 
2434         new cursors.
2435         (WebCore::aliasCursor):
2436         (WebCore::noDropCursor):
2437         (WebCore::progressCursor):
2438
2439 2006-11-19  Beth Dakin  <bdakin@apple.com>
2440
2441         Reviewed by Adam.
2442
2443         Implementation of actions for the new context menus.
2444
2445         * WebCore.exp:
2446         * WebCore.xcodeproj/project.pbxproj:
2447         * bridge/EditorClient.h: Declaration of shouldInsertText.
2448         * bridge/mac/FrameMac.h: Two new spelling functions.
2449         * bridge/mac/FrameMac.mm:
2450         (WebCore::FrameMac::ignoreSpelling):
2451         (WebCore::FrameMac::learnSpelling):
2452         * editing/Editor.cpp:
2453         (WebCore::Editor::shouldInsertText): Call into the client.
2454         * editing/Editor.h:
2455         * editing/EditorInsertAction.h: Added.
2456         (WebCore::): The WebCore equivalent of WebViewInsertAction. This is 
2457         defined in its own header so that we can use it from Editor.h and 
2458         EditorClient.h without having one of the above include the other.
2459         * page/ContextMenuClient.h: A few currently WebKit-implemented 
2460         function needed for menu actions.
2461         * page/ContextMenuController.cpp:
2462         (WebCore::makeGoogleSearchURL):
2463         (WebCore::ContextMenuController::contextMenuActionSelected): The 
2464         actions!
2465         * page/ContextMenuController.h:
2466         * page/Frame.h: New pure-virtual spelling functions.
2467         * platform/ContextMenu.cpp:
2468         (WebCore::ContextMenu::controller): Get the controller from the 
2469         menu.
2470         * platform/ContextMenu.h:
2471         * platform/mac/ContextMenuMac.mm:
2472         (-[MenuTarget 
2473         forwardContextMenuAction:initWithContextMenuController:WebCore::]): 
2474         Use the controller instead of the menu
2475         (-[MenuTarget WebCore::]):
2476         (-[MenuTarget setMenuController:WebCore::]):
2477         (-[MenuTarget forwardContextMenuAction:]):
2478         (getNSMenuItem):
2479         (ContextMenu::show):
2480         (ContextMenu::hide):
2481
2482 2006-11-19  Simon Hausmann  <hausmann@kde.org>
2483
2484         Reviewed by Zack.
2485
2486         http://bugs.webkit.org/show_bug.cgi?id=11649
2487         Fix CMake files for Qt-only build without KDE cmake files.
2488         Fix Qt/KDE build for the SVG support.
2489         Fix Qt-only build in the resource handler.
2490
2491         * CMakeLists.txt:
2492         * platform/graphics/svg/qt/SVGResourceFilterQt.cpp: Added.
2493         (WebCore::SVGResourceFilter::SVGResourceFilter):
2494         (WebCore::SVGResourceFilter::~SVGResourceFilter):
2495         (WebCore::SVGResourceFilter::prepareFilter):
2496         (WebCore::SVGResourceFilter::applyFilter):
2497         * platform/network/qt/ResourceHandleManager.cpp:
2498         (WebCore::ResourceHandleManager::cancel):
2499         (WebCore::ResourceHandleManager::slotData):
2500         (WebCore::ResourceHandleManager::slotMimetype):
2501         (WebCore::ResourceHandleManager::slotResult):
2502         (WebCore::ResourceHandleManager::deliverJobData):
2503         * platform/network/qt/ResourceHandleManager.h:
2504         * platform/network/qt/ResourceHandleQt.cpp:
2505         * platform/qt/CursorQt.cpp:
2506         (WebCore::noDropCursor):
2507         (WebCore::progressCursor):
2508         (WebCore::aliasCursor):
2509
2510 2006-11-19  Mitz Pettel  <mitz@webkit.org>
2511
2512         Reviewed by Maciej.
2513
2514         - http://bugs.webkit.org/show_bug.cgi?id=11626
2515           Automate test for rdar://problem/4056100
2516
2517         * manual-tests/delete-into-nested-block.html: Removed.
2518
2519 2006-11-19  Nikolas Zimmermann  <zimmermann@kde.org>
2520
2521         Reviewed by Oliver.
2522
2523         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11596
2524
2525         Split up KCanvasFilters & KCanvasFilterQuartz into several
2526         new classes (SVGFEBlend, SVGFEComposite...) and move them
2527         into platform/graphics/svg. This is still a temporary location,
2528         as discussed with Darin; the whole platform/graphics/svg directory
2529         will probably be moved into ksvg2/ in near future.
2530
2531         This finally removes the duplicated enumerations in the svg filter
2532         classes and within kcanvas. ksvg2/ and platform/graphics/svg share
2533         their enums now. As KCanvasFilters is gone now, The kcanvas/ subdirectory
2534         is empty.
2535
2536         * CMakeLists.txt:
2537         * WebCore.xcodeproj/project.pbxproj:
2538         * bindings/scripts/CodeGeneratorJS.pm:
2539         * kcanvas/KCanvasFilters.cpp: Removed.
2540         * kcanvas/KCanvasFilters.h: Removed.
2541         * kcanvas/device/KRenderingDevice.h:
2542         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2543         (WebCore::KRenderingDeviceQt::createFilterEffect):
2544         * kcanvas/device/qt/KRenderingDeviceQt.h:
2545         * kcanvas/device/quartz/KCanvasFilterQuartz.h: Removed.
2546         * kcanvas/device/quartz/KCanvasFilterQuartz.mm: Removed.
2547         * kcanvas/device/quartz/KCanvasItemQuartz.cpp:
2548         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp:
2549         (WebCore::KRenderingDeviceQuartz::createResource):
2550         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2551         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2552         * kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel: Removed.
2553         * kcanvas/device/quartz/filters/WKArithmeticFilter.h: Removed.
2554         * kcanvas/device/quartz/filters/WKArithmeticFilter.m: Removed.
2555         * kcanvas/device/quartz/filters/WKComponentMergeFilter.cikernel: Removed.
2556         * kcanvas/device/quartz/filters/WKComponentMergeFilter.h: Removed.
2557         * kcanvas/device/quartz/filters/WKComponentMergeFilter.m: Removed.
2558         * kcanvas/device/quartz/filters/WKDiffuseLightingFilter.cikernel: Removed.
2559         * kcanvas/device/quartz/filters/WKDiffuseLightingFilter.h: Removed.
2560         * kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: Removed.
2561         * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.cikernel: Removed.
2562         * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.h: Removed.
2563         * kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: Removed.
2564         * kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Removed.
2565         * kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Removed.
2566         * kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Removed.
2567         * kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel: Removed.
2568         * kcanvas/device/quartz/filters/WKDistantLightFilter.h: Removed.
2569         * kcanvas/device/quartz/filters/WKDistantLightFilter.m: Removed.
2570         * kcanvas/device/quartz/filters/WKGammaTransferFilter.cikernel: Removed.
2571         * kcanvas/device/quartz/filters/WKGammaTransferFilter.h: Removed.
2572         * kcanvas/device/quartz/filters/WKGammaTransferFilter.m: Removed.
2573         * kcanvas/device/quartz/filters/WKIdentityTransferFilter.h: Removed.
2574         * kcanvas/device/quartz/filters/WKIdentityTransferFilter.m: Removed.
2575         * kcanvas/device/quartz/filters/WKLinearTransferFilter.cikernel: Removed.
2576         * kcanvas/device/quartz/filters/WKLinearTransferFilter.h: Removed.
2577         * kcanvas/device/quartz/filters/WKLinearTransferFilter.m: Removed.
2578         * kcanvas/device/quartz/filters/WKNormalMapFilter.cikernel: Removed.
2579         * kcanvas/device/quartz/filters/WKNormalMapFilter.h: Removed.
2580         * kcanvas/device/quartz/filters/WKNormalMapFilter.m: Removed.
2581         * kcanvas/device/quartz/filters/WKPointLightFilter.cikernel: Removed.
2582         * kcanvas/device/quartz/filters/WKPointLightFilter.h: Removed.
2583         * kcanvas/device/quartz/filters/WKPointLightFilter.m: Removed.
2584         * kcanvas/device/quartz/filters/WKSpecularLightingFilter.cikernel: Removed.
2585         * kcanvas/device/quartz/filters/WKSpecularLightingFilter.h: Removed.
2586         * kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: Removed.
2587         * kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel: Removed.
2588         * kcanvas/device/quartz/filters/WKSpotLightFilter.h: Removed.
2589         * kcanvas/device/quartz/filters/WKSpotLightFilter.m: Removed.
2590         * kcanvas/device/quartz/filters/WKTableTransferFilter.cikernel: Removed.
2591         * kcanvas/device/quartz/filters/WKTableTransferFilter.h: Removed.
2592         * kcanvas/device/quartz/filters/WKTableTransferFilter.m: Removed.
2593         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2594         (WebCore::SVGComponentTransferFunctionElement::transferFunction):
2595         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
2596         * ksvg2/svg/SVGFEBlendElement.cpp:
2597         (WebCore::SVGFEBlendElement::filterEffect):
2598         * ksvg2/svg/SVGFEBlendElement.h:
2599         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2600         (WebCore::SVGFEColorMatrixElement::filterEffect):
2601         * ksvg2/svg/SVGFEColorMatrixElement.h:
2602         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2603         (WebCore::SVGFEComponentTransferElement::filterEffect):
2604         * ksvg2/svg/SVGFEComponentTransferElement.h:
2605         * ksvg2/svg/SVGFECompositeElement.cpp:
2606         (WebCore::SVGFECompositeElement::filterEffect):
2607         * ksvg2/svg/SVGFECompositeElement.h:
2608         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2609         (WebCore::SVGFEDiffuseLightingElement::filterEffect):
2610         (WebCore::SVGFEDiffuseLightingElement::updateLights):
2611         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
2612         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2613         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
2614         (WebCore::SVGFEDisplacementMapElement::filterEffect):
2615         * ksvg2/svg/SVGFEDisplacementMapElement.h:
2616         * ksvg2/svg/SVGFEDistantLightElement.cpp:
2617         (WebCore::SVGFEDistantLightElement::lightSource):
2618         * ksvg2/svg/SVGFEDistantLightElement.h:
2619         * ksvg2/svg/SVGFEFloodElement.cpp:
2620         (WebCore::SVGFEFloodElement::filterEffect):
2621         * ksvg2/svg/SVGFEFloodElement.h:
2622         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2623         (WebCore::SVGFEGaussianBlurElement::filterEffect):
2624         * ksvg2/svg/SVGFEGaussianBlurElement.h:
2625         * ksvg2/svg/SVGFEImageElement.cpp:
2626         (WebCore::SVGFEImageElement::filterEffect):
2627         * ksvg2/svg/SVGFEImageElement.h:
2628         * ksvg2/svg/SVGFELightElement.h:
2629         * ksvg2/svg/SVGFEMergeElement.cpp:
2630         (WebCore::SVGFEMergeElement::filterEffect):
2631         * ksvg2/svg/SVGFEMergeElement.h:
2632         * ksvg2/svg/SVGFEOffsetElement.cpp:
2633         (WebCore::SVGFEOffsetElement::filterEffect):
2634         * ksvg2/svg/SVGFEOffsetElement.h:
2635         * ksvg2/svg/SVGFEPointLightElement.cpp:
2636         (WebCore::SVGFEPointLightElement::lightSource):
2637         * ksvg2/svg/SVGFEPointLightElement.h:
2638         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2639         (WebCore::SVGFESpecularLightingElement::filterEffect):
2640         (WebCore::SVGFESpecularLightingElement::updateLights):
2641         * ksvg2/svg/SVGFESpecularLightingElement.h:
2642         * ksvg2/svg/SVGFESpotLightElement.cpp:
2643         (WebCore::SVGFESpotLightElement::lightSource):
2644         * ksvg2/svg/SVGFESpotLightElement.h:
2645         * ksvg2/svg/SVGFETileElement.cpp:
2646         (WebCore::SVGFETileElement::filterEffect):
2647         * ksvg2/svg/SVGFETileElement.h:
2648         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2649         (WebCore::SVGFETurbulenceElement::filterEffect):
2650         * ksvg2/svg/SVGFETurbulenceElement.h:
2651         (WebCore::):
2652         * ksvg2/svg/SVGFilterElement.cpp:
2653         (WebCore::SVGFilterElement::canvasResource):
2654         * ksvg2/svg/SVGFilterElement.h:
2655         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
2656         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
2657         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
2658         * platform/graphics/FloatPoint3D.cpp: Added.
2659         (WebCore::FloatPoint3D::FloatPoint3D):
2660         (WebCore::FloatPoint3D::x):
2661         (WebCore::FloatPoint3D::setX):
2662         (WebCore::FloatPoint3D::y):
2663         (WebCore::FloatPoint3D::setY):
2664         (WebCore::FloatPoint3D::z):
2665         (WebCore::FloatPoint3D::setZ):
2666         (WebCore::FloatPoint3D::normalize):
2667         * platform/graphics/FloatPoint3D.h: Added.
2668         * platform/graphics/svg/SVGResourceFilter.cpp: Added.
2669         (WebCore::SVGResourceFilter::clearEffects):
2670         (WebCore::SVGResourceFilter::addFilterEffect):
2671         (WebCore::SVGResourceFilter::filterBBoxForItemBBox):
2672         (WebCore::SVGResourceFilter::externalRepresentation):
2673         (WebCore::getFilterById):
2674         * platform/graphics/svg/SVGResourceFilter.h: Added.
2675         (WebCore::SVGResourceFilter::isFilter):
2676         (WebCore::SVGResourceFilter::filterBoundingBoxMode):
2677         (WebCore::SVGResourceFilter::setFilterBoundingBoxMode):
2678         (WebCore::SVGResourceFilter::effectBoundingBoxMode):
2679         (WebCore::SVGResourceFilter::setEffectBoundingBoxMode):
2680         (WebCore::SVGResourceFilter::filterRect):
2681         (WebCore::SVGResourceFilter::setFilterRect):
2682         * platform/graphics/svg/SVGResourceImage.h:
2683         * platform/graphics/svg/SVGResourceListener.h:
2684         (SVGResourceListener::SVGResourceListener):
2685         (SVGResourceListener::~SVGResourceListener):
2686         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
2687         * platform/graphics/svg/cg/SVGResourceFilterCg.mm: Added.
2688         (WebCore::SVGResourceFilter::SVGResourceFilter):
2689         (WebCore::SVGResourceFilter::~SVGResourceFilter):
2690         (WebCore::SVGResourceFilter::prepareFilter):
2691         (WebCore::SVGResourceFilter::applyFilter):
2692         (WebCore::SVGResourceFilter::getCIFilterStack):
2693         (WebCore::SVGResourceFilter::imageForName):
2694         (WebCore::SVGResourceFilter::setImageForName):
2695         (WebCore::SVGResourceFilter::setOutputImage):
2696         (WebCore::alphaImageForImage):
2697         (WebCore::SVGResourceFilter::inputImage):
2698         * platform/graphics/svg/cg/SVGResourceMaskerCg.h: Removed.
2699         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
2700         * platform/graphics/svg/filters/SVGDistantLightSource.h: Added.
2701         (WebCore::SVGDistantLightSource::SVGDistantLightSource):
2702         (WebCore::SVGDistantLightSource::azimuth):
2703         (WebCore::SVGDistantLightSource::elevation):
2704         * platform/graphics/svg/filters/SVGFEBlend.cpp: Added.
2705         (WebCore::SVGFEBlend::in2):
2706         (WebCore::SVGFEBlend::setIn2):
2707         (WebCore::SVGFEBlend::blendMode):
2708         (WebCore::SVGFEBlend::setBlendMode):
2709         (WebCore::operator<<):
2710         (WebCore::SVGFEBlend::externalRepresentation):
2711         * platform/graphics/svg/filters/SVGFEBlend.h: Added.
2712         (WebCore::):
2713         * platform/graphics/svg/filters/SVGFEColorMatrix.cpp: Added.
2714         (WebCore::SVGFEColorMatrix::type):
2715         (WebCore::SVGFEColorMatrix::setType):
2716         (WebCore::SVGFEColorMatrix::values):
2717         (WebCore::SVGFEColorMatrix::setValues):
2718         (WebCore::operator<<):
2719         (WebCore::SVGFEColorMatrix::externalRepresentation):
2720         * platform/graphics/svg/filters/SVGFEColorMatrix.h: Added.
2721         (WebCore::):
2722         * platform/graphics/svg/filters/SVGFEComponentTransfer.cpp: Added.
2723         (WebCore::SVGFEComponentTransfer::redFunction):
2724         (WebCore::SVGFEComponentTransfer::setRedFunction):
2725         (WebCore::SVGFEComponentTransfer::greenFunction):
2726         (WebCore::SVGFEComponentTransfer::setGreenFunction):
2727         (WebCore::SVGFEComponentTransfer::blueFunction):
2728         (WebCore::SVGFEComponentTransfer::setBlueFunction):
2729         (WebCore::SVGFEComponentTransfer::alphaFunction):
2730         (WebCore::SVGFEComponentTransfer::setAlphaFunction):
2731         (WebCore::operator<<):
2732         (WebCore::SVGFEComponentTransfer::externalRepresentation):
2733         * platform/graphics/svg/filters/SVGFEComponentTransfer.h: Added.
2734         (WebCore::):
2735         (WebCore::SVGComponentTransferFunction::SVGComponentTransferFunction):
2736         * platform/graphics/svg/filters/SVGFEComposite.cpp: Added.
2737         (WebCore::SVGFEComposite::in2):
2738         (WebCore::SVGFEComposite::setIn2):
2739         (WebCore::SVGFEComposite::operation):
2740         (WebCore::SVGFEComposite::setOperation):
2741         (WebCore::SVGFEComposite::k1):
2742         (WebCore::SVGFEComposite::setK1):
2743         (WebCore::SVGFEComposite::k2):
2744         (WebCore::SVGFEComposite::setK2):
2745         (WebCore::SVGFEComposite::k3):
2746         (WebCore::SVGFEComposite::setK3):
2747         (WebCore::SVGFEComposite::k4):
2748         (WebCore::SVGFEComposite::setK4):
2749         (WebCore::SVGFEComposite::externalRepresentation):
2750         * platform/graphics/svg/filters/SVGFEComposite.h: Added.
2751         (WebCore::):
2752         * platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp: Added.
2753         (WebCore::SVGFEConvolveMatrix::kernelSize):
2754         (WebCore::SVGFEConvolveMatrix::setKernelSize):
2755         (WebCore::SVGFEConvolveMatrix::kernel):
2756         (WebCore::SVGFEConvolveMatrix::setKernel):
2757         (WebCore::SVGFEConvolveMatrix::divisor):
2758         (WebCore::SVGFEConvolveMatrix::setDivisor):
2759         (WebCore::SVGFEConvolveMatrix::bias):
2760         (WebCore::SVGFEConvolveMatrix::setBias):
2761         (WebCore::SVGFEConvolveMatrix::targetOffset):
2762         (WebCore::SVGFEConvolveMatrix::setTargetOffset):
2763         (WebCore::SVGFEConvolveMatrix::edgeMode):
2764         (WebCore::SVGFEConvolveMatrix::setEdgeMode):
2765         (WebCore::SVGFEConvolveMatrix::kernelUnitLength):
2766         (WebCore::SVGFEConvolveMatrix::setKernelUnitLength):
2767         (WebCore::SVGFEConvolveMatrix::preserveAlpha):
2768         (WebCore::SVGFEConvolveMatrix::setPreserveAlpha):
2769         (WebCore::operator<<):
2770         (WebCore::SVGFEConvolveMatrix::externalRepresentation):
2771         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h: Added.
2772         (WebCore::):
2773         * platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp: Added.
2774         (WebCore::SVGFEDiffuseLighting::SVGFEDiffuseLighting):
2775         (WebCore::SVGFEDiffuseLighting::~SVGFEDiffuseLighting):
2776         (WebCore::SVGFEDiffuseLighting::lightingColor):
2777         (WebCore::SVGFEDiffuseLighting::setLightingColor):
2778         (WebCore::SVGFEDiffuseLighting::surfaceScale):
2779         (WebCore::SVGFEDiffuseLighting::setSurfaceScale):
2780         (WebCore::SVGFEDiffuseLighting::diffuseConstant):
2781         (WebCore::SVGFEDiffuseLighting::setDiffuseConstant):
2782         (WebCore::SVGFEDiffuseLighting::kernelUnitLengthX):
2783         (WebCore::SVGFEDiffuseLighting::setKernelUnitLengthX):
2784         (WebCore::SVGFEDiffuseLighting::kernelUnitLengthY):
2785         (WebCore::SVGFEDiffuseLighting::setKernelUnitLengthY):
2786         (WebCore::SVGFEDiffuseLighting::lightSource):
2787         (WebCore::SVGFEDiffuseLighting::setLightSource):
2788         (WebCore::SVGFEDiffuseLighting::externalRepresentation):
2789         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h: Added.
2790         * platform/graphics/svg/filters/SVGFEDisplacementMap.cpp: Added.
2791         (WebCore::SVGFEDisplacementMap::SVGFEDisplacementMap):
2792         (WebCore::SVGFEDisplacementMap::in2):
2793         (WebCore::SVGFEDisplacementMap::setIn2):
2794         (WebCore::SVGFEDisplacementMap::xChannelSelector):
2795         (WebCore::SVGFEDisplacementMap::setXChannelSelector):
2796         (WebCore::SVGFEDisplacementMap::yChannelSelector):
2797         (WebCore::SVGFEDisplacementMap::setYChannelSelector):
2798         (WebCore::SVGFEDisplacementMap::scale):
2799         (WebCore::SVGFEDisplacementMap::setScale):
2800         (WebCore::operator<<):
2801         (WebCore::SVGFEDisplacementMap::externalRepresentation):
2802         * platform/graphics/svg/filters/SVGFEDisplacementMap.h: Added.
2803         (WebCore::):
2804         * platform/graphics/svg/filters/SVGFEFlood.cpp: Added.
2805         (WebCore::SVGFEFlood::floodColor):
2806         (WebCore::SVGFEFlood::setFloodColor):
2807         (WebCore::SVGFEFlood::floodOpacity):
2808         (WebCore::SVGFEFlood::setFloodOpacity):
2809         (WebCore::SVGFEFlood::externalRepresentation):
2810         * platform/graphics/svg/filters/SVGFEFlood.h: Added.
2811         * platform/graphics/svg/filters/SVGFEGaussianBlur.cpp: Added.
2812         (WebCore::SVGFEGaussianBlur::stdDeviationX):
2813         (WebCore::SVGFEGaussianBlur::setStdDeviationX):
2814         (WebCore::SVGFEGaussianBlur::stdDeviationY):
2815         (WebCore::SVGFEGaussianBlur::setStdDeviationY):
2816         (WebCore::SVGFEGaussianBlur::externalRepresentation):
2817         * platform/graphics/svg/filters/SVGFEGaussianBlur.h: Added.
2818         * platform/graphics/svg/filters/SVGFEImage.cpp: Added.
2819         (WebCore::SVGFEImage::SVGFEImage):
2820         (WebCore::SVGFEImage::~SVGFEImage):
2821         (WebCore::SVGFEImage::cachedImage):
2822         (WebCore::SVGFEImage::setCachedImage):
2823         (WebCore::SVGFEImage::externalRepresentation):
2824         * platform/graphics/svg/filters/SVGFEImage.h: Added.
2825         * platform/graphics/svg/filters/SVGFEMerge.cpp: Added.
2826         (WebCore::SVGFEMerge::mergeInputs):
2827         (WebCore::SVGFEMerge::setMergeInputs):
2828         (WebCore::SVGFEMerge::externalRepresentation):
2829         * platform/graphics/svg/filters/SVGFEMerge.h: Added.
2830         * platform/graphics/svg/filters/SVGFEMorphology.cpp: Added.
2831         (WebCore::SVGFEMorphology::morphologyOperator):
2832         (WebCore::SVGFEMorphology::setMorphologyOperator):
2833         (WebCore::SVGFEMorphology::radiusX):
2834         (WebCore::SVGFEMorphology::setRadiusX):
2835         (WebCore::SVGFEMorphology::radiusY):
2836         (WebCore::SVGFEMorphology::setRadiusY):
2837         (WebCore::operator<<):
2838         (WebCore::SVGFEMorphology::externalRepresentation):
2839         * platform/graphics/svg/filters/SVGFEMorphology.h: Added.
2840         (WebCore::):
2841         * platform/graphics/svg/filters/SVGFEOffset.cpp: Added.
2842         (WebCore::SVGFEOffset::dx):
2843         (WebCore::SVGFEOffset::setDx):
2844         (WebCore::SVGFEOffset::dy):
2845         (WebCore::SVGFEOffset::setDy):
2846         (WebCore::SVGFEOffset::externalRepresentation):
2847         * platform/graphics/svg/filters/SVGFEOffset.h: Added.
2848         * platform/graphics/svg/filters/SVGFESpecularLighting.cpp: Added.
2849         (WebCore::SVGFESpecularLighting::SVGFESpecularLighting):
2850         (WebCore::SVGFESpecularLighting::~SVGFESpecularLighting):
2851         (WebCore::SVGFESpecularLighting::lightingColor):
2852         (WebCore::SVGFESpecularLighting::setLightingColor):
2853         (WebCore::SVGFESpecularLighting::surfaceScale):
2854         (WebCore::SVGFESpecularLighting::setSurfaceScale):
2855         (WebCore::SVGFESpecularLighting::specularConstant):
2856         (WebCore::SVGFESpecularLighting::setSpecularConstant):
2857         (WebCore::SVGFESpecularLighting::specularExponent):
2858         (WebCore::SVGFESpecularLighting::setSpecularExponent):
2859         (WebCore::SVGFESpecularLighting::kernelUnitLengthX):
2860         (WebCore::SVGFESpecularLighting::setKernelUnitLengthX):
2861         (WebCore::SVGFESpecularLighting::kernelUnitLengthY):
2862         (WebCore::SVGFESpecularLighting::setKernelUnitLengthY):
2863         (WebCore::SVGFESpecularLighting::lightSource):
2864         (WebCore::SVGFESpecularLighting::setLightSource):
2865         (WebCore::SVGFESpecularLighting::externalRepresentation):
2866         * platform/graphics/svg/filters/SVGFESpecularLighting.h: Added.
2867         * platform/graphics/svg/filters/SVGFETile.h: Added.
2868         * platform/graphics/svg/filters/SVGFETurbulence.cpp: Added.
2869         (WebCore::SVGFETurbulence::type):
2870         (WebCore::SVGFETurbulence::setType):
2871         (WebCore::SVGFETurbulence::baseFrequencyY):
2872         (WebCore::SVGFETurbulence::setBaseFrequencyY):
2873         (WebCore::SVGFETurbulence::baseFrequencyX):
2874         (WebCore::SVGFETurbulence::setBaseFrequencyX):
2875         (WebCore::SVGFETurbulence::seed):
2876         (WebCore::SVGFETurbulence::setSeed):
2877         (WebCore::SVGFETurbulence::numOctaves):
2878         (WebCore::SVGFETurbulence::setNumOctaves):
2879         (WebCore::SVGFETurbulence::stitchTiles):
2880         (WebCore::SVGFETurbulence::setStitchTiles):
2881         (WebCore::operator<<):
2882         (WebCore::SVGFETurbulence::externalRepresentation):
2883         * platform/graphics/svg/filters/SVGFETurbulence.h: Added.
2884         (WebCore::):
2885         * platform/graphics/svg/filters/SVGFilterEffect.cpp: Added.
2886         (WebCore::SVGFilterEffect::subRegion):
2887         (WebCore::SVGFilterEffect::setSubRegion):
2888         (WebCore::SVGFilterEffect::in):
2889         (WebCore::SVGFilterEffect::setIn):
2890         (WebCore::SVGFilterEffect::result):
2891         (WebCore::SVGFilterEffect::setResult):
2892         (WebCore::SVGFilterEffect::externalRepresentation):
2893         (WebCore::operator<<):
2894         * platform/graphics/svg/filters/SVGFilterEffect.h: Added.
2895         (WebCore::):
2896         (WebCore::SVGFilterEffect::SVGFilterEffect):
2897         (WebCore::SVGFilterEffect::~SVGFilterEffect):
2898         (WebCore::SVGFilterEffect::effectType):
2899         * platform/graphics/svg/filters/SVGLightSource.cpp: Added.
2900         (WebCore::operator<<):
2901         (WebCore::SVGPointLightSource::externalRepresentation):
2902         (WebCore::SVGSpotLightSource::externalRepresentation):
2903         (WebCore::SVGDistantLightSource::externalRepresentation):
2904         * platform/graphics/svg/filters/SVGLightSource.h: Added.
2905         (WebCore::):
2906         (WebCore::SVGLightSource::SVGLightSource):
2907         (WebCore::SVGLightSource::~SVGLightSource):
2908         (WebCore::SVGLightSource::type):
2909         * platform/graphics/svg/filters/SVGPointLightSource.h: Added.
2910         (WebCore::SVGPointLightSource::SVGPointLightSource):
2911         (WebCore::SVGPointLightSource::position):
2912         * platform/graphics/svg/filters/SVGSpotLightSource.h: Added.
2913         (WebCore::SVGSpotLightSource::SVGSpotLightSource):
2914         (WebCore::SVGSpotLightSource::position):
2915         (WebCore::SVGSpotLightSource::direction):
2916         (WebCore::SVGSpotLightSource::specularExponent):
2917         (WebCore::SVGSpotLightSource::limitingConeAngle):
2918         * platform/graphics/svg/filters/cg/SVGFEBlendCg.mm: Added.
2919         (WebCore::SVGFEBlend::getCIFilter):
2920         * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm: Added.
2921         (WebCore::SVGFEColorMatrix::getCIFilter):
2922         * platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm: Added.
2923         (WebCore::genImageFromTable):
2924         (WebCore::setParametersForComponentFunc):
2925         (WebCore::filterForComponentFunc):
2926         (WebCore::getFilterForFunc):
2927         (WebCore::SVGFEComponentTransfer::getFunctionFilter):
2928         (WebCore::SVGFEComponentTransfer::getCIFilter):
2929         * platform/graphics/svg/filters/cg/SVGFECompositeCg.mm: Added.
2930         (WebCore::SVGFEComposite::getCIFilter):
2931         * platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm: Added.
2932         (WebCore::SVGFEDiffuseLighting::getCIFilter):
2933         * platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm: Added.
2934         (WebCore::SVGFEDisplacementMap::getCIFilter):
2935         * platform/graphics/svg/filters/cg/SVGFEFloodCg.mm: Added.
2936         (WebCore::SVGFEFlood::getCIFilter):
2937         * platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm: Added.
2938         (WebCore::SVGFEGaussianBlur::getCIFilter):
2939         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h: Added.
2940         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm: Added.
2941         (WebCore::getVectorForChannel):
2942         (WebCore::ciColor):
2943         (WebCore::getPointLightVectors):
2944         (WebCore::getLightVectors):
2945         (WebCore::getNormalMap):
2946         * platform/graphics/svg/filters/cg/SVGFEImageCg.mm: Added.
2947         (WebCore::SVGFEImage::getCIFilter):
2948         * platform/graphics/svg/filters/cg/SVGFEMergeCg.mm: Added.
2949         (WebCore::SVGFEMerge::getCIFilter):
2950         * platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm: Added.
2951         (WebCore::SVGFEOffset::getCIFilter):
2952         * platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm: Added.
2953         (WebCore::SVGFESpecularLighting::getCIFilter):
2954         * platform/graphics/svg/filters/cg/SVGFETileCg.mm: Added.
2955         (WebCore::SVGFETile::getCIFilter):
2956         * platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm: Added.
2957         (WebCore::SVGFilterEffect::getCIFilter):
2958         * rendering/RenderPath.cpp:
2959         (WebCore::RenderPath::getAbsoluteRepaintRect):
2960         (WebCore::RenderPath::paint):
2961         * rendering/RenderSVGContainer.cpp:
2962         (WebCore::RenderSVGContainer::paint):
2963         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
2964         * rendering/RenderSVGImage.cpp:
2965         (WebCore::RenderSVGImage::paint):
2966         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
2967         * rendering/SVGInlineFlowBox.cpp:
2968         (WebCore::paintSVGInlineFlow):
2969
2970 2006-11-18  Rob Buis  <buis@kde.org>
2971
2972         Reviewed by Maciej.
2973
2974         http://bugs.webkit.org/show_bug.cgi?id=11321
2975         Element with :target pseudo-class still matched after fragment identifier change
2976
2977         Make sure the page does a style recalculation and possible rendering
2978         when navigating back from a page with an anchor to a page without
2979         an anchor.
2980
2981         * loader/FrameLoader.cpp:
2982         (WebCore::FrameLoader::gotoAnchor):
2983
2984 2006-11-18  Don Gibson  <dgibson77@gmail.com>
2985
2986         Reviewed by Sam Weinig.
2987
2988         http://bugs.webkit.org/show_bug.cgi?id=11634:
2989         Fix segfault on startup for Windows build.  Also fix segfault when
2990         typing in a URL.
2991         Clean up some of the style of the patch that landed in r17816.
2992
2993         * WebCore.vcproj/WebCore/WebCore.vcproj:
2994         * bridge/win/ChromeClientWin.h:
2995         (WebCore::ChromeClientWin::~ChromeClientWin):
2996         (WebCore::ChromeClientWin::ref):
2997         (WebCore::ChromeClientWin::deref):
2998         * bridge/win/ContextMenuClientWin.h:
2999         (WebCore::ContextMenuClientWin::~ContextMenuClientWin):
3000         (WebCore::ContextMenuClientWin::ref):
3001         (WebCore::ContextMenuClientWin::deref):
3002         * bridge/win/EditorClientWin.h:
3003         (WebCore::EditorClientWin::~EditorClientWin):
3004         (WebCore::EditorClientWin::ref):
3005         (WebCore::EditorClientWin::deref):
3006         * bridge/win/FrameWin.cpp:
3007         (WebCore::FrameWin::FrameWin):
3008         * bridge/win/FrameWin.h:
3009         (WebCore::Win):
3010         * loader/win/FrameLoaderClientWin.h: Added.
3011         (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin):
3012         (WebCore::FrameLoaderClientWin::ref):
3013         (WebCore::FrameLoaderClientWin::deref):
3014         * platform/win/TemporaryLinkStubs.cpp:
3015         (WebCore::ChromeClientWin::createWindow):
3016         (WebCore::ChromeClientWin::createModalDialog):
3017         (WebCore::EditorClientWin::selectWordBeforeMenuEvent):
3018         (WebCore::EditorClientWin::isEditable):
3019         (WebCore::EditorClientWin::shouldBeginEditing):
3020         (WebCore::EditorClientWin::shouldEndEditing):
3021         (WebCore::EditorClientWin::shouldApplyStyle):
3022         (WebCore::EditorClientWin::didBeginEditing):
3023         (WebCore::EditorClientWin::respondToChangedContents):
3024         (WebCore::EditorClientWin::didEndEditing):
3025         (WebCore::EditorClientWin::registerCommandForUndo):
3026         (WebCore::EditorClientWin::registerCommandForRedo):
3027         (WebCore::EditorClientWin::clearUndoRedoOperations):
3028         (WebCore::EditorClientWin::canUndo):
3029         (WebCore::EditorClientWin::canRedo):
3030         (WebCore::EditorClientWin::undo):
3031         (WebCore::EditorClientWin::redo):
3032         (WebCore::FrameLoader::createFrame):
3033         (WebCore::FrameLoader::createPlugin):
3034         (WebCore::FrameLoaderClientWin::hasWebView):
3035         (WebCore::FrameLoaderClientWin::hasFrameView):
3036         (WebCore::FrameLoaderClientWin::hasBackForwardList):
3037         (WebCore::FrameLoaderClientWin::resetBackForwardList):
3038         (WebCore::FrameLoaderClientWin::provisionalItemIsTarget):
3039         (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache):
3040         (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache):
3041         (WebCore::FrameLoaderClientWin::privateBrowsingEnabled):
3042         (WebCore::FrameLoaderClientWin::makeDocumentView):
3043         (WebCore::FrameLoaderClientWin::makeRepresentation):
3044         (WebCore::FrameLoaderClientWin::forceLayout):
3045         (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML):
3046         (WebCore::FrameLoaderClientWin::updateHistoryForCommit):
3047         (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation):
3048         (WebCore::FrameLoaderClientWin::updateHistoryForReload):
3049         (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad):
3050         (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad):
3051         (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect):
3052         (WebCore::FrameLoaderClientWin::setCopiesOnScroll):
3053         (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset):
3054         (WebCore::FrameLoaderClientWin::resetAfterLoadError):
3055         (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError):
3056         (WebCore::FrameLoaderClientWin::willCloseDocument):
3057         (WebCore::FrameLoaderClientWin::detachedFromParent1):
3058         (WebCore::FrameLoaderClientWin::detachedFromParent2):
3059         (WebCore::FrameLoaderClientWin::detachedFromParent3):
3060         (WebCore::FrameLoaderClientWin::detachedFromParent4):
3061         (WebCore::FrameLoaderClientWin::loadedFromPageCache):
3062         (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents):
3063         (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad):
3064         (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect):
3065         (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect):
3066         (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage):
3067         (WebCore::FrameLoaderClientWin::dispatchWillClose):
3068         (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon):
3069         (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad):
3070         (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle):
3071         (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad):
3072         (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad):
3073         (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout):
3074         (WebCore::FrameLoaderClientWin::dispatchShow):
3075         (WebCore::FrameLoaderClientWin::cancelPolicyCheck):
3076         (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm):
3077         (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource):
3078         (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache):
3079         (WebCore::FrameLoaderClientWin::isLoadingFromPageCache):
3080         (WebCore::FrameLoaderClientWin::revertToProvisionalState):
3081         (WebCore::FrameLoaderClientWin::clearUnarchivingState):
3082         (WebCore::FrameLoaderClientWin::progressStarted):
3083         (WebCore::FrameLoaderClientWin::progressCompleted):
3084         (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady):
3085         (WebCore::FrameLoaderClientWin::willChangeTitle):
3086         (WebCore::FrameLoaderClientWin::didChangeTitle):
3087         (WebCore::FrameLoaderClientWin::finishedLoading):
3088         (WebCore::FrameLoaderClientWin::finalSetupForReplace):
3089         (WebCore::FrameLoaderClientWin::setDefersLoading):
3090         (WebCore::FrameLoaderClientWin::isArchiveLoadPending):
3091         (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad):
3092         (WebCore::FrameLoaderClientWin::clearArchivedResources):
3093         (WebCore::FrameLoaderClientWin::canShowMIMEType):
3094         (WebCore::FrameLoaderClientWin::representationExistsForURLScheme):
3095         (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme):
3096         (WebCore::FrameLoaderClientWin::frameLoadCompleted):
3097         (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState):
3098         (WebCore::FrameLoaderClientWin::provisionalLoadStarted):
3099         (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent):
3100         (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll):
3101         (WebCore::FrameLoaderClientWin::didFinishLoad):
3102         (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement):
3103         (WebCore::FrameLoaderClientWin::setTitle):
3104         (WebCore::FrameLoaderClientWin::userAgent):
3105
3106 2006-11-18  Alexey Proskuryakov  <ap@webkit.org>
3107
3108         Reviewed by Rob (yay!).
3109
3110         http://bugs.webkit.org/show_bug.cgi?id=11640
3111         XMLHttpRequest produces undefined:undefined HTTP authentication
3112
3113         * bindings/js/JSXMLHttpRequest.cpp:
3114         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
3115         Treat undefined credentials as missing ones.
3116
3117 2006-11-17  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
3118
3119         Reviewed by Tim H.
3120
3121         http://bugs.webkit.org/show_bug.cgi?id=11638
3122         [CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles
3123
3124         * Resources/aliasCursor.png: Added.
3125         * Resources/noDropCursor.png: Added.
3126         * Resources/progressCursor.png: Added.
3127         * WebCore.xcodeproj/project.pbxproj:
3128         * css/CSSComputedStyleDeclaration.cpp:
3129         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3130         * css/CSSValueKeywords.in:
3131         * manual-tests/cursor.html:
3132         * page/EventHandler.cpp:
3133         (WebCore::selectCursor):
3134         * platform/Cursor.h:
3135         * platform/mac/CursorMac.mm:
3136         (WebCore::handCursor):
3137         (WebCore::aliasCursor):
3138         (WebCore::progressCursor):
3139         (WebCore::noDropCursor):
3140         * rendering/RenderStyle.h:
3141         (WebCore::):
3142
3143 2006-11-18  Steve Falkenburg  <sfalken@apple.com>
3144
3145         Reviewed by Adam.
3146
3147         Properly adjust CFAbsoluteTime to time_t to fix date calculations.
3148         
3149         Compare lastModified w/ MAX_TIME_T when setting last modified date
3150         instead of comparing expiration against MAX_TIME_T.
3151
3152         * platform/network/cf/ResourceResponseCFNet.cpp:
3153         (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment
3154
3155 2006-11-17  Anders Carlsson  <acarlsson@apple.com>
3156
3157         Reviewed by Geoff.
3158
3159         More conversions from DeprecatedValueList to Vector and HashSet.
3160         
3161         * css/CSSValueList.cpp:
3162         (WebCore::CSSValueList::~CSSValueList):
3163         (WebCore::CSSValueList::append):
3164         (WebCore::CSSValueList::cssText):
3165         * css/CSSValueList.h:
3166         (WebCore::CSSValueList::length):
3167         (WebCore::CSSValueList::item):
3168         * dom/Document.cpp:
3169         (WebCore::Document::attachNodeIterator):
3170         (WebCore::Document::notifyBeforeNodeRemoval):
3171         * dom/Document.h:
3172         * ksvg2/svg/SVGGradientElement.cpp:
3173         (WebCore::SVGGradientElement::notifyAttributeChange):
3174         * ksvg2/svg/SVGPatternElement.cpp:
3175         (WebCore::SVGPatternElement::notifyClientsToRepaint):
3176         * platform/graphics/svg/SVGResource.cpp:
3177         (WebCore::SVGResource::invalidate):
3178         (WebCore::SVGResource::addClient):
3179         * platform/graphics/svg/SVGResource.h:
3180         * rendering/RenderBlock.h:
3181
3182 === Safari-521.31 ===
3183
3184 2006-11-17  Timothy Hatcher  <timothy@apple.com>
3185
3186         Reviewed by Harrison.
3187
3188         <rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
3189
3190         Disable the delete button controller when cloning nodes, Mail does this before saving a draft.
3191
3192         * dom/ContainerNode.cpp:
3193         (WebCore::ContainerNode::cloneChildNodes):
3194         * editing/markup.cpp:
3195         (WebCore::createFragmentFromNodes):
3196
3197 2006-11-17  Justin Garcia  <justin.garcia@apple.com>
3198
3199         Reviewed by harrison
3200         
3201         <rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
3202         <rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
3203
3204         * editing/ReplaceSelectionCommand.cpp:
3205         (WebCore::isMailPasteAsQuotationNode): Added.  Checks for the node
3206         that Mail wraps around an incoming fragment when it wants it to be pasted
3207         with quoting (no merging should be done).
3208         (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added
3209         this virtual method in order to adjust the nodes that ReplaceSelectionCommand
3210         tracks.
3211         (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content
3212         inside a Mail Paste as Quotation node.  Allow merging from Mail blockquotes.
3213         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into
3214         a Mail blockquote, we ignore the parts of the source document's default style
3215         that are overriden by styles from the Mail blockquote.  This is necessary in order
3216         for text that's black (because black is the source document's default font color) 
3217         to appear blue/green/whatever when it's pasted into a Mail blockquote.
3218         (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted
3219         Mail Paste as Quotation node into a normal Mail blockquote.  This will prevent
3220         a copied blockquote that was inserted into the document using Paste as Quotation
3221         from triggering Paste as Quotation behavior when it's pasted.
3222         (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
3223         * editing/ReplaceSelectionCommand.h:
3224         * editing/markup.cpp:
3225         (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine.
3226         (WebCore::removeEnclosingMailBlockquoteStyle): Added.
3227         (WebCore::startMarkup): When wrapping text nodes in style spans, leave out
3228         styles that Mail blockquotes contribute, so that Mail blockquote styles can
3229         be differentiated from styles that the user has applied.  When creating markup
3230         for elements, do the same thing.
3231         (WebCore::createMarkup): Call the new subroutine.
3232
3233 2006-11-17  Rob Buis  <buis@kde.org>
3234
3235         Reviewed by Mitz.
3236
3237         http://bugs.webkit.org/show_bug.cgi?id=11635
3238         Bug 11635: Fix potential issue with non-xslt build
3239
3240         Fix the issue and do style guideline corrections.
3241
3242         * dom/ProcessingInstruction.cpp:
3243         (WebCore::ProcessingInstruction::checkStyleSheet):
3244         (WebCore::ProcessingInstruction::sheetLoaded):
3245         (WebCore::ProcessingInstruction::setCSSStyleSheet):
3246         (WebCore::ProcessingInstruction::setXSLStyleSheet):
3247         (WebCore::ProcessingInstruction::parseStyleSheet):
3248
3249 2006-11-17  Timothy Hatcher  <timothy@apple.com>
3250
3251         Reviewed by Harrison.
3252
3253         <rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it
3254
3255         Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
3256         This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
3257
3258         * editing/EditCommand.cpp:
3259         (WebCore::EditCommand::apply):
3260         (WebCore::EditCommand::unapply):
3261         (WebCore::EditCommand::reapply):
3262         (WebCore::applyCommand):
3263         * editing/EditCommand.h:
3264
3265 2006-11-17  Zack Rusin  <zack@kde.org>
3266
3267         Reviewed by Mitz. Landed by Niko.
3268
3269         Making platform Qt/KDE compile and work after
3270         the latest api changes. Reported as
3271         http://bugs.webkit.org/show_bug.cgi?id=11617
3272
3273         * CMakeLists.txt:
3274         * page/qt/EventHandlerQt.cpp: Added.
3275         (WebCore::isKeyboardOptionTab):
3276         (WebCore::EventHandler::tabsToLinks):
3277         (WebCore::EventHandler::tabsToAllControls):
3278         (WebCore::EventHandler::freeClipboard):
3279         (WebCore::EventHandler::focusDocumentView):
3280         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
3281         (WebCore::EventHandler::passMouseDownEventToWidget):
3282         (WebCore::EventHandler::lastEventIsMouseUp):
3283         (WebCore::EventHandler::dragHysteresisExceeded):
3284         (WebCore::EventHandler::handleDrag):
3285         (WebCore::EventHandler::handleMouseUp):
3286         (WebCore::EventHandler::passSubframeEventToSubframe):
3287         (WebCore::EventHandler::passWheelEventToWidget):
3288         (WebCore::EventHandler::shouldDragAutoNode):
3289         (WebCore::EventHandler::dispatchDragSrcEvent):
3290         (WebCore::EventHandler::passMousePressEventToSubframe):
3291         (WebCore::EventHandler::passMouseMoveEventToSubframe):
3292         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
3293         (WebCore::EventHandler::passWheelEventToSubframe):
3294         (WebCore::EventHandler::passMousePressEventToScrollbar):
3295         * platform/ContextMenu.h:
3296         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
3297         (WebCore::SVGResourceClipper::applyClip):
3298         * platform/qt/ContextMenuClientQt.cpp: Added.
3299         (WebCore::ContextMenuClientQt::addCustomContextMenuItems):
3300         (WebCore::ContextMenuClientQt::ref):
3301         (WebCore::ContextMenuClientQt::deref):
3302         * platform/qt/ContextMenuClientQt.h: Added.
3303         * platform/qt/ContextMenuQt.cpp: Added.
3304         (WebCore::ContextMenu::appendItem):
3305         (WebCore::ContextMenu::itemCount):
3306         (WebCore::ContextMenu::insertItem):
3307         (WebCore::ContextMenu::setPlatformMenuDescription):
3308         * platform/qt/EditorClientQt.cpp:
3309         (WebCore::EditorClientQt::selectWordBeforeMenuEvent):
3310         (WebCore::EditorClientQt::isEditable):
3311         (WebCore::EditorClientQt::registerCommandForUndo):
3312         (WebCore::EditorClientQt::registerCommandForRedo):
3313         (WebCore::EditorClientQt::clearUndoRedoOperations):
3314         (WebCore::EditorClientQt::canUndo):
3315         (WebCore::EditorClientQt::canRedo):
3316         (WebCore::EditorClientQt::undo):
3317         (WebCore::EditorClientQt::redo):
3318         * platform/qt/EditorClientQt.h:
3319         * platform/qt/ScrollViewCanvasQt.cpp:
3320         (WebCore::ScrollViewCanvasQt::mousePressEvent):
3321         * platform/qt/TemporaryLinkStubs.cpp:
3322         (FrameView::updateBorder):
3323
3324 2006-11-17  David Harrison  <harrison@apple.com>
3325
3326         Reviewed by Adele.
3327
3328         <rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer
3329
3330         Replace an assert with a fixme that refers to this bug.
3331         
3332         * page/Frame.cpp:
3333         (WebCore::Frame::revealSelection):
3334
3335 2006-11-16  Rob Buis  <buis@kde.org>
3336
3337         Reviewed and landed by Brady
3338
3339         Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 -
3340         REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
3341         Fix the regression by setting m_loadCompleted correctly.
3342
3343         * css/CSSStyleSheet.cpp:
3344         (WebCore::CSSStyleSheet::checkLoaded):
3345         * dom/Node.h:
3346         (WebCore::Node::sheetLoaded):
3347         * dom/ProcessingInstruction.cpp:
3348         (WebCore::ProcessingInstruction::sheetLoaded):
3349         * dom/ProcessingInstruction.h:
3350         * html/HTMLLinkElement.cpp:
3351         (WebCore::HTMLLinkElement::sheetLoaded):
3352         * html/HTMLLinkElement.h:
3353         * html/HTMLStyleElement.cpp:
3354         (WebCore::HTMLStyleElement::sheetLoaded):
3355         * html/HTMLStyleElement.h:
3356
3357 2006-11-16  David Harrison  <harrison@apple.com>
3358
3359         Reviewed by Beth.
3360
3361         <rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message
3362
3363         The problem was triggered by the fact that the parent div was changing both
3364         in position and in height. The renderer normally bifurcates its logic for
3365         x-position changes vs height changes.
3366
3367         Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.
3368
3369         Test added:
3370         * manual-tests/delete-into-nested-block.html
3371         
3372         * rendering/RenderBlock.cpp:
3373         (WebCore::RenderBlock::layoutBlockChildren):
3374         (WebCore::RenderBlock::positionNewFloats):
3375         * rendering/RenderBox.cpp:
3376         (WebCore::RenderBox::repaintDuringLayoutIfMoved):
3377         * rendering/RenderBox.h:
3378         * rendering/RenderFlexibleBox.cpp:
3379         (WebCore::RenderFlexibleBox::placeChild):
3380         * rendering/RenderObject.cpp:
3381         (WebCore::RenderObject::repaintDuringLayoutIfMoved):
3382         * rendering/RenderObject.h:
3383         * rendering/RenderTableSection.cpp:
3384         (WebCore::RenderTableSection::layoutRows):
3385
3386 2006-11-16  Adele Peterson  <adele@apple.com>
3387
3388         Reviewed by Adam.
3389
3390         Slider cleanup.  Let the theme set the size of the slider thumb.
3391
3392         * rendering/RenderSlider.cpp:
3393         (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle.
3394         (WebCore::RenderSlider::createThumbStyle):
3395         (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
3396         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize):  Added.
3397         * rendering/RenderTheme.h: ditto.
3398         * rendering/RenderThemeMac.h: ditto.
3399         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.
3400
3401 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
3402
3403         Reviewed by Darin.
3404
3405         Use Vector instead of DeprecatedValueList in a few places.
3406         
3407         * bindings/js/kjs_dom.cpp:
3408         (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
3409         (KJS::DOMNamedNodesCollection::lengthGetter):
3410         (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
3411         * bindings/js/kjs_dom.h:
3412         * bindings/js/kjs_html.cpp:
3413         (KJS::JSHTMLDocument::namedItemGetter):
3414         (KJS::JSHTMLElement::classInfo):
3415         (KJS::JSHTMLElement::accessors):
3416         (KJS::JSHTMLCollection::getNamedItems):
3417         * bindings/objc/DOM.mm:
3418         * bridge/mac/FrameMac.mm:
3419         (WebCore::FrameMac::dashboardRegionsDictionary):
3420         * css/CSSStyleDeclaration.cpp:
3421         (WebCore::CSSStyleDeclaration::diff):
3422         * html/HTMLCollection.cpp:
3423         (WebCore::HTMLCollection::namedItems):
3424         * html/HTMLCollection.h:
3425         * kcanvas/KCanvasFilters.cpp:
3426         (WebCore::KCanvasFilter::externalRepresentation):
3427         * kcanvas/KCanvasFilters.h:
3428         (WebCore::KCanvasFEColorMatrix::values):
3429         (WebCore::KCanvasFEColorMatrix::setValues):
3430         (WebCore::KCanvasFEConvolveMatrix::kernel):
3431         (WebCore::KCanvasFEConvolveMatrix::setKernel):
3432         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3433         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
3434         (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
3435         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3436         (WebCore::SVGFEColorMatrixElement::filterEffect):
3437         * platform/graphics/svg/SVGResourceClipper.h:
3438         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
3439         (WebCore::SVGResourceClipper::applyClip):
3440         * platform/network/FormData.h:
3441         * rendering/RenderPath.h:
3442         * rendering/SVGRenderTreeAsText.h:
3443         (WebCore::operator<<):
3444
3445 2006-11-16  Anders Carlsson  <acarlsson@apple.com>
3446
3447         Reviewed by Tim.
3448
3449         * editing/markup.cpp:
3450         (WebCore::createMarkup):
3451         Add null-checks for the frame, it might not exist for all documents.
3452         
3453 2006-11-16  Don Gibson  <dgibson77@gmail.com>
3454
3455         Reviewed and landed by ap.
3456
3457         http://bugs.webkit.org/show_bug.cgi?id=11509:
3458         Windows build bustage.
3459
3460         Also reorganizes WebCore.vcproj to add files whose absence wasn't
3461         causing compile errors, but which should have been there, and to
3462         make the include directory ordering (and contents) sane.
3463         Also reorganizes TemporaryLinkStubs.cpp to put headers and
3464         function groups in alphabetical order, and ensure that all functions
3465         in the file call notImplemented().
3466
3467         * WebCore.vcproj/WebCore/WebCore.vcproj:
3468         * bridge/win/ChromeClientWin.h:
3469         (WebCore::ChromeClientWin::ref):
3470         (WebCore::ChromeClientWin::deref):
3471         * bridge/win/ContextMenuClientWin.h: Added.
3472         (WebCore::ContextMenuClientWin::~ContextMenuClientWin):
3473         (WebCore::ContextMenuClientWin::ref):
3474         (WebCore::ContextMenuClientWin::deref):
3475         * bridge/win/EditorClientWin.h:
3476         * bridge/win/FrameWin.cpp:
3477         (WebCore::FrameWin::~FrameWin):
3478         (WebCore::FrameWin::keyPress):
3479         * bridge/win/FrameWin.h:
3480         * bridge/win/PageWin.cpp: Removed.
3481         * editing/EditCommand.h:
3482         * loader/FormState.h:
3483         * loader/FrameLoader.h:
3484         * page/EventHandler.cpp:
3485         * platform/MimeTypeRegistry.cpp:
3486         (WebCore::initialiseSupportedImageMIMETypes):
3487         * platform/graphics/win/ImageWin.cpp:
3488         * platform/network/ResourceError.cpp:
3489         * platform/network/ResourceHandleInternal.h:
3490         * platform/network/win/ResourceHandleWin.cpp:
3491         (WebCore::ResourceHandle::onHandleCreated):
3492         (WebCore::ResourceHandle::onRequestRedirected):
3493         (WebCore::ResourceHandle::start):
3494         (WebCore::ResourceHandle::cancel):
3495         * platform/win/ScreenWin.cpp:
3496         (WebCore::monitorInfo):
3497         (WebCore::screenRect):
3498         (WebCore::screenAvailableRect):
3499         (WebCore::screenDepth):
3500         * platform/win/SoundWin.cpp: Added.
3501         (WebCore::systemBeep):
3502         * platform/win/TemporaryLinkStubs.cpp:
3503         (WebCore::CacheObjectExpiresTime):
3504         (WebCore::CheckCacheObjectStatus):
3505         (WebCore::CheckIfReloading):
3506         (WebCore::defaultLanguage):
3507         (WebCore::fileButtonChooseFileLabel):
3508         (WebCore::fileButtonNoFileSelectedLabel):
3509         (WebCore::findNextSentenceFromIndex):
3510         (WebCore::findNextWordFromIndex):
3511         (WebCore::findSentenceBoundary):
3512         (WebCore::findWordBoundary):
3513         (WebCore::focusRingColor):
3514         (WebCore::historyContains):
3515         (WebCore::inputElementAltText):
3516         (WebCore::IsResponseURLEqualToURL):
3517         (WebCore::cellCursor):
3518         (WebCore::contextMenuCursor):
3519         (WebCore::moveCursor):
3520         (WebCore::verticalTextCursor):
3521         (WebCore::refreshPlugins):
3522         (WebCore::resetButtonDefaultLabel):
3523     &n