2eacedb8ca7b6338bc5d345c0d7d6e4ecd0ffaa3
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-02  Adam Roben  <aroben@apple.com>
2
3         Reviewed by Maciej.
4
5         Let Windows determine which mouse button is pressed.
6
7         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
8         * platform/win/MouseEventWin.cpp:
9         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
10         parameter to determine which mouse button is pressed.
11
12 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
13
14         Reviewed by anders
15         
16         Build fix
17         
18         * editing/SelectionController.cpp:
19         (WebCore::SelectionController::empty):
20         * editing/SelectionController.h:
21
22 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
23
24         Reviewed by john
25         
26         <rdar://problem/4755287>
27         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
28
29         * editing/markup.cpp:
30         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
31         elements).  Don't skip blocks that aren't containers (like horizontal rules).
32
33 2006-10-03  Darin Adler  <darin@apple.com>
34
35         Reviewed by Justin Garcia.
36
37         - correct mistaken code that would restart blinking every
38           time "invalidateSelection" is called even if the caret
39           has not moved
40
41         * editing/SelectionController.h:
42         * editing/SelectionController.cpp:
43         (WebCore::SelectionController::setSelection): Update for name change.
44         (WebCore::SelectionController::recomputeCaretRect): New function.
45         Computes caret rect and does any necessary invalidation if the rect
46         changes.
47         (WebCore::SelectionController::invalidateCaretRect): Renamed from
48         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
49         calls recomputeCaretRect as a side effect.
50
51         * page/Frame.cpp:
52         (WebCore::Frame::invalidateSelection): Remove unneeded call to
53         clearCaretRectIfNeeded.
54         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
55         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
56         recomputeCaretRect function and not restart blinking if caret has
57         not changed position.
58         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
59         are not needed since selectionLayoutChanged already checks these.
60
61         * page/FramePrivate.h: Removed unused m_blinkCaret.
62
63 2006-10-02  Beth Dakin  <bdakin@apple.com>
64
65         Reviewed by Adam.
66
67         Build fix. Add counters to vcproj.
68
69         * WebCore.vcproj/WebCore/WebCore.vcproj:
70
71 2006-10-02  Brady Eidson  <beidson@apple.com>
72
73         Reviewed by Adele
74
75         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
76         icon data out because we don't correctly check SQL error conditions.
77
78         * loader/icon/IconDataCache.cpp:
79         (WebCore::IconDataCache::writeToDatabase):
80
81 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
82
83         Reviewed by Hyatt.
84
85         Added method to find out whether a layout has occurred.
86
87         * page/FrameView.cpp:
88         (WebCore::FrameView::didFirstLayout):
89         * page/FrameView.h:
90
91 2006-10-02  Beth Dakin  <bdakin@apple.com>
92
93         Reviewed by Darin.
94
95         Initial implementation of CSS2 counters. See http://
96         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
97
98         * WebCore.xcodeproj/project.pbxproj:
99         * css/CSSComputedStyleDeclaration.cpp: 
100         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
101         the increment/reset list now that this is implemented.
102         * css/CSSPrimitiveValue.cpp:
103         (WebCore::CSSPrimitiveValue::cssText): 
104         * css/Counter.h:
105         (WebCore::Counter::Counter):
106         (WebCore::Counter::~Counter):
107         (WebCore::Counter::identifier):
108         (WebCore::Counter::listStyle):
109         (WebCore::Counter::separator):
110         (WebCore::Counter::listStyleNumber):
111         (WebCore::Counter::setIdentifier):
112         (WebCore::Counter::setListStyle):
113         (WebCore::Counter::setSeparator):
114         * css/cssparser.cpp:
115         (WebCore::CSSParser::addProperty): Take care of reset/increment
116         (WebCore::CSSParser::parseValue):
117         (WebCore::CSSParser::parseContent): content can now take counters
118         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
119         counters()
120         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
121         counter-increment
122         * css/cssparser.h:
123         * css/cssstyleselector.cpp:
124         (WebCore::CSSStyleSelector::matchUARules):
125         (WebCore::CSSStyleSelector::applyProperty):
126         * platform/PlatformString.h:
127         * platform/String.cpp:
128         (WebCore::String::insert): Implemented a version of insert that 
129         accepts a UChar* and a length.
130         * platform/StringImpl.cpp:
131         (WebCore::StringImpl::insert): Same as above.
132         * platform/StringImpl.h:
133         * rendering/CounterListItem.h: Added.
134         * rendering/CounterNode.cpp: Added.
135         (WebCore::CounterNode::CounterNode):
136         (WebCore::CounterNode::insertAfter):
137         (WebCore::CounterNode::removeChild):
138         (WebCore::CounterNode::remove):
139         (WebCore::CounterNode::setUsesSeparator):
140         (WebCore::CounterNode::recountAndGetNext):
141         (WebCore::CounterNode::recountTree):
142         (WebCore::CounterNode::setSelfDirty):
143         (WebCore::CounterNode::setParentDirty):
144         * rendering/CounterNode.h: Added.
145         (WebCore::CounterNode::~CounterNode):
146         (WebCore::CounterNode::parent):
147         (WebCore::CounterNode::previousSibling):
148         (WebCore::CounterNode::nextSibling):
149         (WebCore::CounterNode::firstChild):
150         (WebCore::CounterNode::lastChild):
151         (WebCore::CounterNode::value):
152         (WebCore::CounterNode::setValue):
153         (WebCore::CounterNode::count):
154         (WebCore::CounterNode::setCount):
155         (WebCore::CounterNode::setHasSeparator):
156         (WebCore::CounterNode::isReset):
157         (WebCore::CounterNode::hasSeparator):
158         (WebCore::CounterNode::willNeedLayout):
159         (WebCore::CounterNode::setWillNeedLayout):
160         (WebCore::CounterNode::isRoot):
161         (WebCore::CounterNode::setRenderer):
162         (WebCore::CounterNode::renderer):
163         * rendering/CounterResetNode.cpp: Added.
164         (WebCore::CounterResetNode::CounterResetNode):
165         (WebCore::CounterResetNode::insertAfter):
166         (WebCore::CounterResetNode::removeChild):
167         (WebCore::CounterResetNode::recountAndGetNext):
168         (WebCore::CounterResetNode::setParentDirty):
169         (WebCore::CounterResetNode::updateTotal):
170         * rendering/CounterResetNode.h: Added.
171         (WebCore::CounterResetNode::firstChild):
172         (WebCore::CounterResetNode::lastChild):
173         (WebCore::CounterResetNode::isReset):
174         (WebCore::CounterResetNode::total):
175         * rendering/RenderContainer.cpp:
176         (WebCore::RenderContainer::updatePseudoChildForObject): Account for 
177         counter content.
178         * rendering/RenderCounter.cpp: Added.
179         (WebCore::RenderCounter::RenderCounter):
180         (WebCore::RenderCounter::layout):
181         (WebCore::toRoman):
182         (WebCore::toLetterString):
183         (WebCore::toHebrew):
184         (WebCore::RenderCounter::convertValueToType):
185         (WebCore::RenderCounter::calcMinMaxWidth):
186         * rendering/RenderCounter.h: Added.
187         (WebCore::RenderCounter::renderName):
188         (WebCore::RenderCounter::isCounter):
189         * rendering/RenderObject.cpp:
190         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to 
191         maps of CounterNodes
192         (WebCore::RenderObject::RenderObject):
193         (WebCore::RenderObject::destroy): Destroy the maps.
194         (WebCore::RenderObject::findCounter): Finds/creates counters.
195         * rendering/RenderObject.h:
196         (WebCore::RenderObject::isCounter):
197         * rendering/RenderStyle.cpp:
198         (WebCore::StyleVisualData::StyleVisualData):
199         (WebCore::RenderStyle::arenaDelete):
200         (WebCore::RenderStyle::RenderStyle):
201         (WebCore::RenderStyle::diff):
202         (WebCore::RenderStyle::setContent):
203         (WebCore::ContentData::clearContent):
204         (WebCore::RenderStyle::counterDataEquivalent):
205         (WebCore::hasCounter):
206         (WebCore::RenderStyle::hasCounterReset):
207         (WebCore::RenderStyle::hasCounterIncrement):
208         (WebCore::readCounter):
209         (WebCore::RenderStyle::counterReset):
210         (WebCore::RenderStyle::counterIncrement):
211         * rendering/RenderStyle.h:
212         (WebCore::StyleVisualData::operator==):
213         (WebCore::CounterData::CounterData):
214         (WebCore::CounterData::identifier):
215         (WebCore::CounterData::listStyle):
216         (WebCore::CounterData::separator):
217         (WebCore::ContentData::contentCounter):
218         (WebCore::ContentData::):
219         (WebCore::RenderStyle::counterIncrement):
220         (WebCore::RenderStyle::counterReset):
221         (WebCore::RenderStyle::setCounterIncrement):
222         (WebCore::RenderStyle::setCounterReset):
223         (WebCore::RenderStyle::setCounterResetList):
224         (WebCore::RenderStyle::setCounterIncrementList):
225         (WebCore::RenderStyle::counterResetValueList):
226         (WebCore::RenderStyle::counterIncrementValueList):
227
228 2006-10-02  Adele Peterson  <adele@apple.com>
229
230         Reviewed by Adam.
231
232         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
233
234         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
235         by using "-webkit-appearance:none".
236
237         * css/html4.css:
238
239 2006-10-02  David Harrison  <harrison@apple.com>
240
241         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
242         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
243         Left the layout test.
244         
245         * rendering/bidi.cpp:
246         (WebCore::checkMidpoints):
247
248 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
249
250         Reviewed by eseidel.  Landed by eseidel.
251
252         Fix Qt/Linux build.
253
254         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
255         (WebCore::supportedKeySizes):
256
257 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
258
259         Reviewed by eseidel & mjs.  Landed by eseidel.
260
261         Fix Qt/Linux build with older gcc 3.3.4.
262         http://bugs.webkit.org/show_bug.cgi?id=11116
263
264         As discussed with Maciej, the GCC_ROOT_NS_HACK
265         can be completely removed, as well as the friendship
266         between cacheGlobalObject & the JS* objects.
267
268         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
269         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
270         (png_read_filter_row_mmx_avg):
271         * platform/image-decoders/png/pngvcrd.c: Ditto.
272         (png_mmx_support):
273         (png_read_filter_row_mmx_avg):
274
275 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
276
277         Rubber stamped by Alexey.
278
279         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
280
281         * css/CSSGrammar.y:
282
283 2006-10-01  Eric Seidel  <eric@webkit.org>
284
285         Reviewed by mjs.
286
287         Eliminate a few more hotspots in SVG drawing code.
288         
289         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
290
291         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
292         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
293         * platform/mac/ColorMac.mm:
294         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
295
296 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
297
298         Reviewed by Maciej.
299         
300         More frame/iframe merging.
301         
302         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
303         false, so this was dead code.
304         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
305         than attach(), is the correct place for setInViewSourceMode, because
306         openURL() is the function that creates our frame.
307         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
308         code that did the same thing in other places.
309         - Made FRAME's attach() method suffuciently generic so that IFRAME could
310         call up to it, rather than skipping its superclass and calling up directly 
311         to ELEMENT.
312         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
313         - Replaced ad hoc frame loading code in FRAME::attach() with call to
314         openURL(), the designated frame loading function.
315
316         Layout tests pass. I added a layout test for viewsource mode, since I
317         broke it in the course of writing this patch.
318
319 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
320
321         Reviewed by Geoff.
322
323         * dom/Document.cpp:
324         (WebCore::Document::recalcStyleSelector):
325         * dom/Document.h:
326         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
327         
328         * dom/Node.h:
329         Remove DeprecatedStringList class forward declaration.
330         
331         * editing/markup.cpp:
332         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
333         
334         * kcanvas/KCanvasTreeDebug.cpp:
335         * kcanvas/KCanvasTreeDebug.h:
336         Remove unused functions.
337         
338         * loader/loader.cpp:
339         * page/Frame.cpp:
340         * page/Frame.h:
341         * page/FrameView.h:
342         Fixup DeprecatedStringList.h includes.
343
344 2006-09-30  David Harrison  <harrison@apple.com>
345
346         Reviewed by John Sullivan.
347
348         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
349
350         Problem was that the decision to trim was based only on whether the character
351         is a soft hyphen, which caused pretty much any Japanese character to go.
352         Changed to decide based on whether the character is ignorable whitespace.
353         
354         Test:
355         * fast/text/international/wrap-CJK-001.html
356
357         * rendering/bidi.cpp:
358         (WebCore::isTrimmableChar):
359         New. Checks whether character is whitespace that can be ignored
360         according to the text node's style.
361         trimmed from the end of wrapped line.
362         (WebCore::checkMidpoints):
363         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
364
365 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
366
367         Reviewed by Mitz Pettel.
368
369         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
370
371         * ksvg2/svg/SVGColor.cpp:
372         (WebCore::SVGColor::setRGBColor):
373         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
374         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
375         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
376         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
377         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
378         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
379         (SVGFESpecularLightingElement::parseMappedAttribute):
380         * ksvg2/svg/SVGFETurbulenceElement.cpp:
381         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
382         * ksvg2/svg/SVGLengthList.cpp:
383         * ksvg2/svg/SVGNumberList.cpp:
384         (SVGNumberList::parse):
385         * ksvg2/svg/SVGNumberList.h:
386         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
387         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
388         * ksvg2/svg/SVGStringList.cpp:
389         (WebCore::SVGStringList::reset):
390         * ksvg2/svg/SVGStringList.h:
391         * ksvg2/svg/SVGTransformable.cpp:
392         (SVGTransformable::parseTransformAttribute):
393
394 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
395
396         Reviewed by Eric, tweaked and landed by ap.
397
398         Fix Qt/Linux build.
399
400         * CMakeLists.txt:
401         * platform/qt/PlatformScrollBar.h:
402         * platform/qt/TemporaryLinkStubs.cpp:
403         (WebCore::ScrollBar::ScrollBar):
404         (WebCore::PlatformScrollBar::PlatformScrollBar):
405         (FrameView::passMousePressEventToSubframe):
406         (FrameView::passMouseMoveEventToSubframe):
407         (FrameView::passMouseReleaseEventToSubframe):
408         (FrameView::passWheelEventToSubframe):
409         (FrameView::passMousePressEventToScrollbar):
410         * ksvg2/svg/SVGDocument.h:
411
412 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
413
414         Reviewed by Darin.
415
416         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
417         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
418
419         No test case added (probably requires new DumpRenderTree functionality)
420
421         * rendering/RenderImage.cpp:
422         (WebCore::RenderImage::imageChanged): Added early return if the document is
423         being destroyed.
424
425 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
426
427         Reviewed by Hyatt.
428
429         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
430         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
431         
432         Make sure we only break after a space (and not any other valid line-break) if
433         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
434         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
435         twice in quick succession.
436
437         * rendering/bidi.cpp:
438         (WebCore::RenderBlock::findNextLineBreak): 
439
440 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
441
442         Reviewed by Maciej and Darin.
443
444         http://bugs.webkit.org/show_bug.cgi?id=4372
445         JavaScript document.write page form does not submit in Safari
446
447         Test: fast/forms/document-write.html
448
449         * page/Frame.cpp:
450         (WebCore::Frame::submitForm): Don't check for parsing().
451
452 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
453
454         Build fix.
455
456         * bridge/mac/FrameViewMac.mm: Add missing #imports.
457
458 2006-10-01  Dave Hyatt  <hyatt@apple.com>
459
460         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
461        
462         Reviewed by mitz
463
464         * bridge/mac/FrameMac.mm:
465         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
466         * bridge/mac/FrameViewMac.mm:
467         (WebCore::FrameView::passMousePressEventToScrollbar):
468         * page/FrameView.cpp:
469         (WebCore::FrameView::handleMousePressEvent):
470         (WebCore::FrameView::setMousePressed):
471         * page/FrameView.h:
472         * platform/win/TemporaryLinkStubs.cpp:
473         (FrameView::passMousePressEventToScrollbar):
474
475 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
476
477         Reviewed by Darin.
478
479         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
480         Add more SVG Objective-C DOM bindings
481
482         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
483           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
484           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
485           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
486           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, 
487           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
488
489         * DerivedSources.make:
490         * WebCore.xcodeproj/project.pbxproj:
491         * bindings/objc/DOMInternal.h:
492         * bindings/objc/DOMSVG.h:
493         * bindings/scripts/CodeGeneratorObjC.pm:
494         * ksvg2/svg/SVGAElement.idl:
495         * ksvg2/svg/SVGAnimateColorElement.idl:
496         * ksvg2/svg/SVGAnimateElement.idl:
497         * ksvg2/svg/SVGAnimateTransformElement.idl:
498         * ksvg2/svg/SVGAnimatedPathData.idl:
499         * ksvg2/svg/SVGAnimatedPoints.idl:
500         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
501         * ksvg2/svg/SVGAnimationElement.idl:
502         * ksvg2/svg/SVGCircleElement.idl:
503         * ksvg2/svg/SVGClipPathElement.idl:
504         * ksvg2/svg/SVGColor.idl:
505         * ksvg2/svg/SVGCursorElement.idl:
506         * ksvg2/svg/SVGDefsElement.idl:
507         * ksvg2/svg/SVGDescElement.idl:
508         * ksvg2/svg/SVGDocument.idl:
509         * ksvg2/svg/SVGEllipseElement.idl:
510         * ksvg2/svg/SVGPointList.idl:
511         * ksvg2/svg/SVGPreserveAspectRatio.idl:
512         * ksvg2/svg/SVGRect.idl:
513         * ksvg2/svg/SVGSVGElement.idl:
514
515 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
516
517         Reviewed by Adele.
518
519         - fix build
520
521         * platform/FloatRect.h:
522         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
523         but more appropriate for path-type stuff.
524         * platform/cg/PathCG.cpp:
525         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
526
527 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
528
529         Reviewed by Darin.
530
531         http://bugs.webkit.org/show_bug.cgi?id=11011
532         External CSS is parsed as iso-8859-1 even though the main document is utf-8
533
534         Test: fast/encoding/css-charset-default.xhtml
535
536         * loader/CachedResourceClient.h:
537         (WebCore::CachedResourceClient::setCSSStyleSheet):
538         (WebCore::CachedResourceClient::setXSLStyleSheet):
539         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
540         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
541
542         * css/CSSImportRule.cpp:
543         (WebCore::CSSImportRule::setCSSStyleSheet):
544         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
545         * css/CSSImportRule.h:
546
547         * css/CSSStyleSheet.cpp:
548         (WebCore::CSSStyleSheet::CSSStyleSheet):
549         * css/CSSStyleSheet.h:
550         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
551         member. Changed some String parameters to const String&.
552
553         * css/StyleSheet.cpp:
554         (WebCore::StyleSheet::StyleSheet):
555         * css/StyleSheet.h:
556         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
557
558         * css/StyleSheetList.cpp:
559         (WebCore::StyleSheetList::length):
560         (WebCore::StyleSheetList::item):
561         * css/StyleSheetList.h:
562         Special-casing implicit stylesheets seemed to be dead code, removed.
563
564         * dom/Document.cpp:
565         (WebCore::Document::setCSSStyleSheet):
566         (WebCore::Document::recalcStyleSelector):
567         * dom/Document.h:
568         Renamed setStyleSheet() to setCSSStyleSheet().
569
570         * dom/ProcessingInstruction.cpp:
571         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
572         (WebCore::ProcessingInstruction::setCSSStyleSheet):
573         (WebCore::ProcessingInstruction::setXSLStyleSheet):
574         (WebCore::ProcessingInstruction::parseStyleSheet):
575         * dom/ProcessingInstruction.h:
576
577         * html/HTMLLinkElement.cpp:
578         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute 
579         is not specified.
580         (WebCore::HTMLLinkElement::setCSSStyleSheet):
581         * html/HTMLLinkElement.h:
582
583         * html/HTMLStyleElement.cpp:
584         (WebCore::HTMLStyleElement::childrenChanged):
585         * ksvg2/svg/SVGStyleElement.cpp:
586         (WebCore::SVGStyleElement::childrenChanged):
587         Inherit URL and charset from the document.
588
589         * loader/Cache.cpp:
590         (WebCore::Cache::requestCSSStyleSheet):
591         * loader/Cache.h:
592         Adjust for setStyleSheet() renaming.
593
594         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
595         * loader/CachedCSSStyleSheet.cpp:
596         (WebCore::CachedCSSStyleSheet::ref):
597         (WebCore::CachedCSSStyleSheet::deref):
598         (WebCore::CachedCSSStyleSheet::checkNotify):
599         Pass the encoding to setCSSStyleSheet().
600
601         * loader/CachedXSLStyleSheet.cpp:
602         (WebCore::CachedXSLStyleSheet::ref):
603         (WebCore::CachedXSLStyleSheet::checkNotify):
604         * loader/DocLoader.cpp:
605         (WebCore::DocLoader::requestCSSStyleSheet):
606         * loader/DocLoader.h:
607         * page/Frame.cpp:
608         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
609         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
610         * xml/XSLImportRule.cpp:
611         (WebCore::XSLImportRule::setXSLStyleSheet):
612         (WebCore::XSLImportRule::loadSheet):
613         * xml/XSLImportRule.h:
614         Adjust for setStyleSheet() renaming.
615
616 2006-09-30  Rob Buis  <buis@kde.org>
617
618         Reviewed by eseidel.
619
620         http://bugs.webkit.org/show_bug.cgi?id=11096
621         Hit testing for polylines fails
622
623         Fix Path::contains so it handles filled, non-closed paths too.
624
625         * platform/cg/PathCG.cpp:
626         (WebCore::Path::contains):
627
628 2006-09-30  Dave Hyatt  <hyatt@apple.com>
629
630         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
631         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
632         subframes while the mouse is down.
633       
634         Reviewed by mitzpettel
635
636         * bridge/mac/FrameMac.h:
637         * bridge/mac/FrameMac.mm:
638         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
639         (WebCore::FrameMac::passWheelEventToWidget):
640         * bridge/mac/FrameViewMac.mm:
641         (WebCore::FrameView::passMousePressEventToSubframe):
642         (WebCore::FrameView::passMouseMoveEventToSubframe):
643         (WebCore::FrameView::passMouseReleaseEventToSubframe):
644         (WebCore::FrameView::passWheelEventToSubframe):
645         * page/Frame.cpp:
646         * page/Frame.h:
647         * page/FrameView.cpp:
648         (WebCore::subframeForTargetNode):
649         (WebCore::FrameView::handleMousePressEvent):
650         (WebCore::FrameView::handleMouseDoubleClickEvent):
651         (WebCore::FrameView::handleMouseMoveEvent):
652         (WebCore::FrameView::handleMouseReleaseEvent):
653         (WebCore::FrameView::handleWheelEvent):
654         * page/FrameView.h:
655         * platform/ScrollBar.h:
656         (WebCore::ScrollBar::handleMouseMoveEvent):
657         (WebCore::ScrollBar::handleMouseOutEvent):
658         * platform/Widget.h:
659         (WebCore::Widget::handleMouseMoveEvent):
660         (WebCore::Widget::handleMouseReleaseEvent):
661         * platform/win/TemporaryLinkStubs.cpp:
662         (FrameView::passMousePressEventToSubframe):
663         (FrameView::passMouseMoveEventToSubframe):
664         (FrameView::passMouseReleaseEventToSubframe):
665         (FrameView::passWheelEventToSubframe):
666         (Widget::capturingMouse):
667         (Widget::setCapturingMouse):
668         (Widget::capturingTarget):
669         (Widget::capturingChild):
670         (Widget::setCapturingChild):
671         * rendering/RenderView.cpp:
672         (WebCore::RenderView::paintBoxDecorations):
673
674 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
675
676         Reviewed by Adele.
677
678         Fixes windows bustage:
679         http://bugs.webkit.org/show_bug.cgi?id=11093
680
681         * platform/win/PlatformScrollBar.h:
682         * platform/win/TemporaryLinkStubs.cpp:
683         (PlatformScrollBar::PlatformScrollBar):
684         (ScrollBar::ScrollBar):
685
686 2006-09-29  David Hyatt  <hyatt@apple.com>
687
688         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
689         in RenderObject::NodeInfo (and then propagating that Widget to
690         MouseEventWithHitTestResults).
691
692         This allows RenderListBox and RenderBlock to do the same thing when the
693         mouse is over the scrollbar.
694
695         Also land fix to support font-size: 0.
696
697         Reviewed by mjs (scrollbar), eric (font-size)
698
699         * dom/Document.cpp:
700         (WebCore::Document::prepareMouseEvent):
701         * page/Frame.cpp:
702         (WebCore::Frame::passWidgetMouseDownEventToWidget):
703         * page/FrameView.cpp:
704         (WebCore::selectCursor):
705         (WebCore::FrameView::handleMouseMoveEvent):
706         (WebCore::FrameView::dispatchMouseEvent):
707         * page/MouseEventWithHitTestResults.cpp:
708         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
709         * page/MouseEventWithHitTestResults.h:
710         (WebCore::MouseEventWithHitTestResults::scrollbar):
711         * rendering/RenderBlock.cpp:
712         (WebCore::RenderBlock::isPointInScrollbar):
713         (WebCore::RenderBlock::nodeAtPoint):
714         * rendering/RenderBlock.h:
715         * rendering/RenderLayer.cpp:
716         (WebCore::RenderLayer::hitTest):
717         * rendering/RenderLayer.h:
718         (WebCore::RenderLayer::getHiddenBehavior):
719         * rendering/RenderListBox.cpp:
720         (WebCore::RenderListBox::RenderListBox):
721         (WebCore::RenderListBox::~RenderListBox):
722         (WebCore::RenderListBox::isPointInScrollbar):
723         * rendering/RenderListBox.h:
724         * rendering/RenderObject.h:
725         (WebCore::RenderObject::NodeInfo::NodeInfo):
726         (WebCore::RenderObject::NodeInfo::scrollbar):
727         (WebCore::RenderObject::NodeInfo::setScrollbar):
728
729 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
730
731         Reviewed by Adele.
732
733         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
734
735         * platform/win/ScrollViewWin.cpp:
736         (WebCore::ScrollView::convertToContainingWindow):
737         (WebCore::ScrollView::convertFromContainingWindow):
738         * platform/win/WidgetWin.cpp:
739         (WebCore::Widget::convertToContainingWindow):
740         (WebCore::Widget::convertFromContainingWindow):
741
742 2006-09-29  Adele Peterson  <adele@apple.com>
743
744         Updated with new argument for PlatformScrollBar.
745
746         * platform/win/TemporaryLinkStubs.cpp:
747         (PlatformScrollBar::PlatformScrollBar):
748
749 2006-09-29  Adele Peterson  <adele@apple.com>
750
751         Reviewed by Hyatt.
752
753         Fixing build bustage with cast to int.
754
755         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
756
757 2006-09-29  Adele Peterson  <adele@apple.com>
758
759         Fixing accidental include.
760
761         * rendering/RenderListBox.cpp:
762
763 2006-09-29  Adele Peterson  <adele@apple.com>
764
765         Adding RenderListBox files.
766
767         * WebCore.vcproj/WebCore/WebCore.vcproj:
768
769 2006-09-29  Adele Peterson  <adele@apple.com>
770
771         Reviewed by Adam.
772
773         Initial implementation of engine-based list box control.
774
775         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
776
777         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
778         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
779         (WebCore::FrameMac::FrameMac):
780         (WebCore::FrameMac::handleMousePressEvent):
781         (WebCore::FrameMac::handleMouseMoveEvent):
782         (WebCore::FrameMac::mouseDown):
783
784         * page/Frame.cpp:
785         (WebCore::Frame::handleMouseMoveEvent):
786         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
787         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
788         (WebCore::Frame::autoscrollTimerFired): ditto.
789         (WebCore::Frame::stopAutoscrollTimer): ditto.
790         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
791         * page/Frame.h:
792         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
793
794         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
795         (WebCore::FrameViewPrivate::reset):
796         (WebCore::FrameView::currentMousePosition):
797         (WebCore::FrameView::handleMousePressEvent):
798         (WebCore::FrameView::handleMouseDoubleClickEvent):
799         (WebCore::selectCursor):
800         (WebCore::FrameView::handleMouseMoveEvent):
801         (WebCore::FrameView::handleMouseReleaseEvent):
802         * page/FrameView.h:
803
804         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
805         * platform/ScrollBar.h:
806         (WebCore::):
807         (WebCore::ScrollBar::controlSize):
808         * platform/mac/PlatformScrollBar.h:
809         * platform/mac/PlatformScrollBarMac.mm:
810         (NSControlSizeForScrollBarControlSize):
811         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
812         (WebCore::PlatformScrollBar::PlatformScrollBar):
813
814         * rendering/RenderBlock.h:
815         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
816         * rendering/RenderLayer.h:
817         * rendering/RenderObject.cpp:
818         (WebCore::RenderObject::shouldAutoscroll):
819         (WebCore::RenderObject::autoscroll):
820         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
821
822         * css/html4.css: Added properties for new list boxes.
823
824         * html/HTMLOptionElement.cpp:
825         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
826         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
827         * html/HTMLOptionElement.h: Added disabled method.
828
829         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
830         (WebCore::HTMLSelectElement::recalcStyle):
831         (WebCore::HTMLSelectElement::lastSelectedListIndex):
832         (WebCore::HTMLSelectElement::deselectItems):
833         (WebCore::HTMLSelectElement::setSelectedIndex):
834         (WebCore::HTMLSelectElement::isKeyboardFocusable):
835         (WebCore::HTMLSelectElement::isMouseFocusable):
836         (WebCore::HTMLSelectElement::createRenderer):
837         (WebCore::HTMLSelectElement::recalcListItems):
838         (WebCore::HTMLSelectElement::setRecalcListItems):
839         (WebCore::HTMLSelectElement::reset):
840         (WebCore::HTMLSelectElement::notifyOptionSelected):
841         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
842         (WebCore::HTMLSelectElement::nextSelectableListIndex):
843         (WebCore::HTMLSelectElement::previousSelectableListIndex):
844         * html/HTMLSelectElement.h:
845
846         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
847         (WebCore::RenderTheme::paint):
848         (WebCore::RenderTheme::paintBorderOnly):
849         (WebCore::RenderTheme::paintDecorations):
850         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
851         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
852         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
853         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
854         (WebCore::RenderTheme::isControlStyled):
855         (WebCore::RenderTheme::supportsFocusRing):
856         * rendering/RenderTheme.h:
857         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
858
859         * rendering/RenderListBox.cpp: Added.
860         (WebCore::RenderListBox::RenderListBox):
861         (WebCore::RenderListBox::~RenderListBox):
862         (WebCore::RenderListBox::setStyle):
863         (WebCore::RenderListBox::updateFromElement):
864         (WebCore::RenderListBox::calcMinMaxWidth):
865         (WebCore::RenderListBox::size):
866         (WebCore::RenderListBox::numItems):
867         (WebCore::RenderListBox::calcHeight):
868         (WebCore::RenderListBox::baselinePosition):
869         (WebCore::RenderListBox::itemBoundingBoxRect):
870         (WebCore::RenderListBox::paintObject):
871         (WebCore::RenderListBox::paintScrollbar):
872         (WebCore::RenderListBox::paintItemForeground):
873         (WebCore::RenderListBox::paintItemBackground):
874         (WebCore::RenderListBox::scrollBarTarget):
875         (WebCore::RenderListBox::isPointInScrollbar):
876         (WebCore::RenderListBox::optionAtPoint):
877         (WebCore::RenderListBox::autoscroll):
878         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
879         (WebCore::RenderListBox::scroll):
880         (WebCore::RenderListBox::valueChanged):
881         * rendering/RenderListBox.h: Added.
882         (WebCore::RenderListBox::isListBox):
883         (WebCore::RenderListBox::selectionChanged):
884         (WebCore::RenderListBox::setSelectionChanged):
885         (WebCore::RenderListBox::canHaveChildren):
886         (WebCore::RenderListBox::renderName):
887         (WebCore::RenderListBox::setOptionsChanged):
888         (WebCore::RenderListBox::shouldAutoscroll):
889         (WebCore::RenderListBox::listIndexIsVisible):
890
891 2006-09-29  Beth Dakin  <bdakin@apple.com>
892
893         Reviewed by Darin.
894
895         We had a bug where html4.css was ignoring Media Queries. In the end 
896         the problem was that we were trying to send a char* to the 
897         MediaQueryEvaluator constructor that expects a String, but the 
898         char* got interpreted as a bool, the wrong constructor was called, 
899         and the media type was never set.
900
901         No test case possible since this only affects html4.css
902
903         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
904         char*
905         (WebCore::MediaQueryEvaluator):
906         * css/MediaQueryEvaluator.h: Same.
907
908 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
909
910         Reviewed by John, Maciej.
911         
912         Integrated some frame and iframe code. I'm trying to fix up frame ownership
913         and loading. Reducing the number of different code paths involved
914         seemed like a good first step.
915         
916         As a side effect, I fixed a bug where FRAME elements would report their
917         src attributes as relative, rather than compelete, URLs. (IFRAME elements
918         had the correct complete URL behavior.)
919
920         * html/HTMLFrameElement.cpp:
921         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
922         (WebCore::HTMLFrameElement::openURL):
923             (1) Removed checks that requestFrame does for us
924             (2) Added isURLAllowed check, to have one clear bottleneck for it
925             (3) Added viewsource check, to have one clear bottleneck for it
926         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
927         method, instead of finding our content frame in our own unique way.
928         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
929         since openURL does this for us now.
930         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
931         This is what FF does, and it made no sense to have different behaviors
932         for FRAME and IFRAME elements.
933         * html/HTMLIFrameElement.cpp:
934         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
935         code.
936         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
937         HTMLFrameElement now does everything we need.
938
939 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
940
941         Reviewed by Hyatt.
942
943         Fix Qt/Linux build.
944
945         * CMakeLists.txt:
946         * platform/qt/ScrollViewQt.cpp:
947         (WebCore::ScrollView::convertToContainingWindow):
948         (WebCore::ScrollView::convertFromContainingWindow):
949         * platform/qt/TemporaryLinkStubs.cpp:
950         (WebCore::signedPublicKeyAndChallengeString):
951         * platform/qt/WidgetQt.cpp:
952         (WebCore::Widget::convertToContainingWindow):
953         (WebCore::Widget::convertFromContainingWindow):
954
955 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
956
957         Reviewed by Tim H.
958
959         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
960         Simplify Internal methods for the auto-generated Objective-C DOM code
961
962         - Auto-generate the internal methods for more Objective-C classes.
963
964         * WebCore.xcodeproj/project.pbxproj:
965         * bindings/objc/DOM.mm:
966         * bindings/objc/DOMCSS.mm:
967         (-[DOMStyleSheet WebCore::]):
968         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
969         (-[DOMCSSRule WebCore::]):
970         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
971         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
972         (-[DOMCSSValue WebCore::]):
973         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
974         (+[DOMCSSValue _CSSValueWith:WebCore::]):
975         * bindings/objc/DOMHTMLAppletElement.mm:
976         (-[DOMHTMLAppletElement WebCore::]):
977         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
978         * bindings/objc/DOMHTMLEmbedElement.mm:
979         (-[DOMHTMLEmbedElement WebCore::]):
980         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
981         * bindings/objc/DOMInternal.h:
982         * bindings/objc/DOMInternal.mm:
983         * bindings/scripts/CodeGeneratorObjC.pm:
984         * css/CSSCharsetRule.idl:
985         * css/CSSFontFaceRule.idl:
986         * css/CSSImportRule.idl:
987         * css/CSSMediaRule.idl:
988         * css/CSSPageRule.idl:
989         * css/CSSPrimitiveValue.idl:
990         * css/CSSStyleRule.idl:
991         * css/CSSStyleSheet.idl:
992         * css/CSSUnknownRule.idl:
993         * css/CSSValueList.idl:
994         * dom/KeyboardEvent.idl:
995         * dom/MouseEvent.idl:
996         * dom/MutationEvent.idl:
997         * dom/NodeIterator.idl:
998         * dom/OverflowEvent.idl:
999         * dom/UIEvent.idl:
1000         * dom/WheelEvent.idl:
1001
1002 2006-09-29  David Harrison  <harrison@apple.com>
1003
1004         Reviewed by John Sullivan.
1005
1006         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
1007         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
1008
1009         Test added
1010         * fast/text/attributed-substring-from-range-001.html
1011
1012         * bridge/mac/FrameMac.mm:
1013         (WebCore::FrameMac::attributedString):
1014         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
1015         Also, add validation of the range.
1016
1017 2006-09-29  Rob Buis  <buis@kde.org>
1018
1019         Reviewed by Maciej.
1020
1021         http://bugs.webkit.org/show_bug.cgi?id=10893
1022         InsertRule can not handle @import statements
1023
1024         Allow @import as part of a css rule.
1025
1026         * css/CSSGrammar.y:
1027
1028 2006-09-28  David Hyatt  <hyatt@apple.com>
1029
1030         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
1031
1032         * bridge/mac/FrameMac.mm:
1033         (WebCore::FrameMac::eventMayStartDrag):
1034         (WebCore::FrameMac::dragHysteresisExceeded):
1035         (WebCore::FrameMac::mouseDown):
1036         (WebCore::FrameMac::shouldDragAutoNode):
1037         (WebCore::FrameMac::sendContextMenuEvent):
1038         * bridge/mac/WebCoreFrameBridge.mm:
1039         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1040
1041 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1042
1043         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
1044         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
1045         view.
1046        
1047         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
1048         the patch after review, once I realized that these new functions essentially do the same thing.)
1049
1050         * dom/EventTargetNode.cpp:
1051         (WebCore::EventTargetNode::dispatchMouseEvent):
1052         (WebCore::EventTargetNode::dispatchWheelEvent):
1053         * page/Frame.cpp:
1054         (WebCore::Frame::selectClosestWordFromMouseEvent):
1055         (WebCore::Frame::handleMousePressEventTripleClick):
1056         (WebCore::Frame::handleMousePressEventSingleClick):
1057         (WebCore::Frame::handleMouseMoveEvent):
1058         (WebCore::Frame::handleMouseReleaseEvent):
1059         * page/FrameView.cpp:
1060         (WebCore::FrameView::handleMousePressEvent):
1061         (WebCore::selectCursor):
1062         (WebCore::FrameView::dispatchDragEvent):
1063         (WebCore::FrameView::prepareMouseEvent):
1064         (WebCore::FrameView::handleWheelEvent):
1065         * platform/ScrollView.h:
1066         * platform/Widget.cpp:
1067         (WebCore::Widget::convertToContainingWindow):
1068         * platform/Widget.h:
1069         * platform/mac/ScrollViewMac.mm:
1070         (WebCore::ScrollView::convertToContainingWindow):
1071         (WebCore::ScrollView::convertFromContainingWindow):
1072         * platform/mac/WidgetMac.mm:
1073         (WebCore::Widget::convertToContainingWindow):
1074         (WebCore::Widget::convertFromContainingWindow):
1075         * platform/win/ScrollViewWin.cpp:
1076         (WebCore::ScrollView::convertToContainingWindow):
1077         (WebCore::ScrollView::convertFromContainingWindow):
1078         * rendering/RenderLayer.cpp:
1079         (WebCore::RenderLayer::resize):
1080
1081 2006-09-28  Alice Liu  <alice.liu@apple.com>
1082
1083         Build fix by adding missing files for CommandByName
1084
1085         * WebCore.xcodeproj/project.pbxproj:
1086
1087 2006-09-28  Alice Liu  <alice.liu@apple.com>
1088
1089         Adding CommandByName files to the vcproj
1090
1091         * WebCore.vcproj/WebCore/WebCore.vcproj:
1092
1093 2006-09-28  Alice Liu  <alice.liu@apple.com>
1094
1095         Reviewed by Adam Roben.
1096
1097         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc. 
1098         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
1099         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
1100
1101         * editing/CommandByName.cpp: Added.
1102         Added a command class that hangs off the frame so the frame can call commands more easily.  
1103         (WebCore::Frame::commandImp):
1104         (WebCore::Frame::execCopy):
1105         (WebCore::Frame::execCut):
1106         (WebCore::Frame::execDelete):
1107         (WebCore::Frame::execForwardDelete):
1108         (WebCore::Frame::execPaste):
1109         (WebCore::Frame::execMoveLeft):
1110         (WebCore::Frame::execMoveRight):
1111         (WebCore::Frame::execMoveUp):
1112         (WebCore::Frame::execMoveDown):
1113         (WebCore::Frame::execSelectAll):
1114         (WebCore::Frame::execSelectLeft):
1115         (WebCore::Frame::execSelectRight):
1116         (WebCore::Frame::execSelectUp):
1117         (WebCore::Frame::execSelectDown):
1118         (WebCore::Frame::enabled):
1119         (WebCore::Frame::enabledAnySelection):
1120         (WebCore::Frame::enabledAnyEditableSelection):
1121         (WebCore::Frame::enabledPaste):
1122         (WebCore::Frame::enabledAnyRangeSelection):
1123         (WebCore::Frame::enabledAnyEditableRangeSelection):
1124         (WebCore::Frame::createCommandDictionary):
1125         (WebCore::Frame::Command::):
1126         (WebCore:::m_frame):
1127         (WebCore::CommandByName::execCommand):
1128         * editing/CommandByName.h: Added.
1129         * page/Frame.cpp:
1130         Added implementation of accessor for CommandByName member
1131         (WebCore::Frame::command):
1132         * page/Frame.h:
1133         Added accessor for CommandByName member
1134         * page/FramePrivate.h:
1135         Added a CommandByName member
1136         (WebCore::FramePrivate::FramePrivate):
1137         * platform/PlatformMouseEvent.h:
1138         Changed constructor prototype
1139         * platform/StringImpl.cpp:
1140         Exposing getWordBreakIterator to be used elsewhere
1141         (WebCore::getWordBreakIterator):
1142         * platform/StringImpl.h:
1143         Exposing getWordBreakIterator to be used elsewhere
1144         * platform/win/MouseEventWin.cpp:
1145         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
1146         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1147
1148 2006-09-28  Adam Roben  <aroben@apple.com>
1149
1150         Reviewed by Adele.
1151
1152         Remove no-longer-used PopUpButton.
1153
1154         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
1155         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
1156         PopUpButtonMac.mm
1157         * platform/PopUpButton.h: Removed.
1158         * platform/mac/PopUpButtonMac.mm: Removed.
1159         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
1160         * rendering/DeprecatedRenderSelect.cpp: Change #include of
1161         PopUpButton.h to ListBox.h
1162
1163 2006-09-28  Darin Adler  <darin@apple.com>
1164
1165         Reviewed by Alice.
1166
1167         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
1168           10% perf. regression (copying strings while decoding)
1169
1170         Use Vector<UChar> instead of String when building up the decoded string in
1171         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
1172         String grows the buffer every single time that append is called. Using
1173         Vector::append instead of String::append also avoids constructing a string
1174         each time just to append and a questionable copy that is done inside the
1175         String::append function which also contributed to the slowness.
1176
1177         * platform/PlatformString.h:
1178         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
1179         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
1180         allocation.
1181         * platform/StringImpl.h:
1182         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
1183
1184         * platform/StreamingTextDecoder.h:
1185         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
1186         Change to use a Vector<UChar> instead of a String, since vectors have better
1187         resizing performance (they store a separate capacity).
1188
1189         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
1190         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
1191         Change to use Vector<UChar> instead of String and then create a string at
1192         the end of the process using the new adopt function.
1193
1194 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
1195
1196         Reviewed by Tim H.
1197
1198         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
1199         Auto-generate more SVG Objective-C bindings
1200
1201         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
1202           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
1203           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
1204           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
1205           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
1206           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
1207           and DOMSVGTransformable.
1208
1209         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
1210           parent interfaces and the SVG animated classes.
1211
1212         - Corrects CodeGenerator.pm to only skip the first parent for the main 
1213           interface.
1214
1215         * DerivedSources.make:
1216         * WebCore.xcodeproj/project.pbxproj:
1217         * bindings/objc/DOMInternal.h:
1218         * bindings/objc/DOMSVG.h:
1219         * bindings/scripts/CodeGenerator.pm:
1220         * bindings/scripts/CodeGeneratorObjC.pm:
1221         * ksvg2/svg/SVGAnimatedAngle.idl:
1222         * ksvg2/svg/SVGAnimatedBoolean.idl:
1223         * ksvg2/svg/SVGAnimatedEnumeration.idl:
1224         * ksvg2/svg/SVGAnimatedInteger.idl:
1225         * ksvg2/svg/SVGAnimatedLength.idl:
1226         * ksvg2/svg/SVGAnimatedLengthList.idl:
1227         * ksvg2/svg/SVGAnimatedNumber.idl:
1228         * ksvg2/svg/SVGAnimatedPathData.idl:
1229         * ksvg2/svg/SVGAnimatedString.idl:
1230         * ksvg2/svg/SVGAnimatedTransformList.idl:
1231         * ksvg2/svg/SVGExternalResourcesRequired.idl:
1232         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
1233         * ksvg2/svg/SVGFitToViewBox.idl:
1234         * ksvg2/svg/SVGLangSpace.idl:
1235         * ksvg2/svg/SVGLocatable.idl:
1236         * ksvg2/svg/SVGMetadataElement.idl:
1237         * ksvg2/svg/SVGStringList.idl:
1238         * ksvg2/svg/SVGStylable.idl:
1239         * ksvg2/svg/SVGStyleElement.idl:
1240         * ksvg2/svg/SVGTests.idl:
1241         * ksvg2/svg/SVGTransformable.idl:
1242         * ksvg2/svg/SVGURIReference.idl:
1243         * ksvg2/svg/SVGUnitTypes.idl:
1244         * ksvg2/svg/SVGZoomAndPan.idl:
1245
1246 2006-09-28  Brady Eidson  <beidson@apple.com>
1247
1248         Reviewed by Mitz Pettel!!!
1249
1250         Change the error code check for common functions from SQLResultOk to SQLResultDone 
1251
1252         * loader/icon/IconDatabase.cpp:
1253         (WebCore::IconDatabase::forgetPageURLQuery):
1254         (WebCore::IconDatabase::setIconIDForPageURLQuery):
1255         (WebCore::IconDatabase::addIconForIconURLQuery):
1256
1257 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1258
1259         Just eliminate MapWindowPoints usage and use the HWND as
1260         the viewport.
1261
1262         * platform/win/MouseEventWin.cpp:
1263         (WebCore::positionForEvent):
1264         * platform/win/ScrollViewWin.cpp:
1265         (WebCore::ScrollView::viewportToContents):
1266         (WebCore::ScrollView::contentsToViewport):
1267
1268 2006-09-27  David Hyatt  <hyatt@apple.com>
1269
1270         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
1271         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
1272         scrollbars to provide hover feedback if needed.
1273
1274         Reviewed by Eric
1275
1276         * page/FrameView.cpp:
1277         (WebCore::selectCursor):
1278         (WebCore::FrameView::handleMouseMoveEvent):
1279         * platform/ScrollBar.h:
1280         (WebCore::ScrollBar::mouseMoved):
1281
1282 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
1283
1284         Reviewed by Maciej and Adam, landed by Adam
1285
1286         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
1287         Windows build is busted
1288
1289         * platform/win/TemporaryLinkStubs.cpp:
1290         (ScrollView::paint):
1291         (ScrollView::themeChanged):
1292
1293 2006-09-27  Eric Seidel  <eric@eseidel.com>
1294
1295         Reviewed by mitz.
1296
1297         paths with no fill specified default to black but do not recieve paint-related mouse events
1298         http://bugs.webkit.org/show_bug.cgi?id=11069
1299         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
1300
1301         Test: svg/custom/hover-default-fill.svg
1302
1303         * kcanvas/RenderPath.cpp:
1304         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
1305         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
1306         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1307         (WebCore::KSVGPainterFactory::isFilled): remove null check
1308         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
1309         (WebCore::KSVGPainterFactory::isStroked): remove null check
1310         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
1311         * ksvg2/svg/SVGPaint.cpp:
1312         (WebCore::SVGPaint::defaultFill): added.
1313         (WebCore::SVGPaint::defaultStroke): added.
1314         * ksvg2/svg/SVGPaint.h:
1315
1316 2006-09-27  Rob Buis  <buis@kde.org>
1317
1318         Reviewed by eseidel.
1319
1320         http://bugs.webkit.org/show_bug.cgi?id=11015
1321         SVG handles em units incorrectly
1322
1323         Calculate viewport coordinates at layout time, since
1324         at this point the font size is known and lengths depending
1325         on font sizes can be calculated correctly.
1326
1327         * kcanvas/RenderSVGContainer.cpp:
1328         (WebCore::RenderSVGContainer::layout):
1329         (WebCore::RenderSVGContainer::viewport):
1330         (WebCore::RenderSVGContainer::calcViewport):
1331         * kcanvas/RenderSVGContainer.h:
1332         * ksvg2/svg/SVGLength.cpp:
1333         (WebCore::SVGLength::updateValue):
1334         * ksvg2/svg/SVGMarkerElement.cpp:
1335         (WebCore::SVGMarkerElement::createRenderer):
1336         * ksvg2/svg/SVGSVGElement.cpp:
1337         (WebCore::SVGSVGElement::createRenderer):
1338         (WebCore::SVGSVGElement::attributeChanged):
1339         * ksvg2/svg/SVGSVGElement.h:
1340
1341 2006-09-27  Eric Seidel  <eric@eseidel.com>
1342
1343         Reviewed by darin.
1344
1345         Change our invalid-fill error behavior to match Opera (and soon Firefox)
1346         http://bugs.webkit.org/show_bug.cgi?id=11017
1347
1348         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1349         (WebCore::KSVGPainterFactory::isFilled):
1350         (WebCore::KSVGPainterFactory::fillPaintServer):
1351         (WebCore::KSVGPainterFactory::isStroked):
1352         (WebCore::KSVGPainterFactory::strokePaintServer):
1353
1354 2006-09-27  Brady Eidson  <beidson@apple.com>
1355
1356         Build fix
1357
1358         * loader/icon/IconDatabase.cpp:
1359         (WebCore::readySQLStatement):
1360
1361 2006-09-27  Brady Eidson  <beidson@apple.com>
1362
1363         Reviewed by Adam
1364
1365         In very specific circumstances, prepared SQLStatements can become invalid without
1366         any warning.  This checks for that state and re-prepares the statement and also
1367         adds more aggressive error-checking everywhere these statements are used.
1368
1369         * loader/icon/IconDatabase.cpp:
1370         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
1371         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
1372         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
1373         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
1374         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
1375         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
1376         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
1377         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
1378         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
1379         * loader/icon/SQLStatement.cpp:
1380         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
1381         * loader/icon/SQLStatement.h:
1382
1383 2006-09-26  Darin Adler  <darin@apple.com>
1384
1385         Reviewed by Steve.
1386
1387         - clean up options for font code path
1388
1389         * platform/Font.h:
1390         * platform/Font.cpp:
1391         (WebCore::Font::setCodePath): Added. Replaces boolean version.
1392         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
1393
1394         * platform/mac/WebCoreTextRenderer.mm:
1395         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
1396
1397 2006-09-26  John Sullivan  <sullivan@apple.com>
1398
1399         Reviewed by Darin
1400
1401         * bridge/mac/WebCoreFrameBridge.h:
1402         * bridge/mac/WebCoreFrameBridge.mm:
1403         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
1404         Added limit parameter, passed down to Frame
1405         
1406         * page/Frame.h:
1407         * page/Frame.cpp:
1408         (WebCore::Frame::markAllMatchesForText):
1409         Added limit parameter. Stop the search if it hits limit.
1410
1411 2006-09-26  Sean Gies  <seangies@apple.com>
1412
1413         Reviewed by Brady Eidson.
1414
1415         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
1416
1417 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
1418
1419         Reviewed by john
1420         
1421         <rdar://problem/4747695> 
1422         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
1423         
1424         * editing/DeleteSelectionCommand.cpp:
1425         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
1426         to select special elements that are fully selected after expansion
1427         moves to positions that are visually distinct from the originals.
1428         * editing/InsertListCommand.cpp:
1429         (WebCore::InsertListCommand::doApply): If the content of the list 
1430         item will be moved into another list, put it in a list item.
1431
1432 2006-09-26  Geoffrey Garen <ggaren@apple.com>
1433
1434         Reviewed by Darin.
1435         
1436         Temporary work-around for frame lifetime issue.
1437
1438         * page/Frame.cpp:
1439         (WebCore::Frame::clear):
1440         (WebCore::Frame::disconnectOwnerElement):
1441
1442 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1443
1444         Reviewed by Tim H.
1445
1446         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1447         Auto-generate DOMSVGElement for the Objective-C bindings
1448
1449         - Auto-generates DOMSVGElement.
1450
1451         - Make SVGExceptions work like all the other ExceptionCode
1452           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1453           and SVGExceptionMax.
1454
1455         * DerivedSources.make:
1456         * WebCore.xcodeproj/project.pbxproj:
1457         * bindings/js/kjs_binding.cpp:
1458         (KJS::):
1459         (KJS::setDOMException):
1460         * bindings/objc/DOMInternal.h:
1461         * bindings/objc/DOMInternal.mm:
1462         (raiseDOMException):
1463         * bindings/objc/DOMSVG.h:
1464         * bindings/objc/DOMSVGExecption.h: Added.
1465         * ksvg2/ksvg.h:
1466         * ksvg2/svg/SVGElement.cpp:
1467         (WebCore::SVGElement::setId):
1468         (WebCore::SVGElement::setXmlbase):
1469         * ksvg2/svg/SVGElement.h:
1470         * ksvg2/svg/SVGElement.idl:
1471         * ksvg2/svg/SVGException.h: Added.
1472         (WebCore::):
1473
1474 2006-09-26  Eric Seidel  <eric@eseidel.com>
1475
1476         Reviewed by Tim H.
1477         
1478         viewbox parser does not allow <tab> as a delimiter
1479         http://bugs.webkit.org/show_bug.cgi?id=11014
1480
1481         Test: svg/hixie/viewbox/003.xml
1482
1483         * ksvg2/svg/svgpathparser.cpp:
1484         (WebCore::isWhitespace): new function
1485         (WebCore::skipOptionalSpaces):
1486         (WebCore::skipOptionalSpacesOrComma):
1487
1488 2006-09-26  Eric Seidel  <eric@eseidel.com>
1489
1490         Reviewed by Tim H.
1491
1492         SVGDocument::createElement does not create elements in the SVG namespace
1493         http://bugs.webkit.org/show_bug.cgi?id=10932
1494         
1495         Test: svg/custom/createelement.svg
1496
1497         * ksvg2/svg/SVGDocument.cpp:
1498         (WebCore::SVGDocument::createElement):
1499         * ksvg2/svg/SVGDocument.h:
1500
1501 2006-09-26  Eric Seidel  <eric@eseidel.com>
1502
1503         Reviewed by Tim H.
1504         
1505         RenderPath::nodeAtPoint does not respect stroke width
1506         http://bugs.webkit.org/show_bug.cgi?id=10829
1507
1508         Test: svg/custom/stroke-width-click.svg
1509
1510         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1511         (WebCore::RenderPath::strokeContains):
1512         * kcanvas/device/quartz/QuartzSupport.h:
1513         * kcanvas/device/quartz/QuartzSupport.mm:
1514
1515 2006-09-26  Eric Seidel  <eric@eseidel.com>
1516
1517         Reviewed by mitz.
1518
1519         Bring animation back to life
1520         http://bugs.webkit.org/show_bug.cgi?id=11021
1521         
1522         Register/unregister SVGSVGElements as time containers on insertion/removal.
1523         Replace uses of DeprecatedString with String in SVGAnimationElement
1524         Various whitespace clean-up.
1525
1526         * ksvg2/misc/KSVGTimeScheduler.cpp:
1527         (WebCore::SVGTimer::notifyAll):
1528         * ksvg2/misc/SVGDocumentExtensions.cpp:
1529         (WebCore::SVGDocumentExtensions::startAnimations):
1530         (WebCore::SVGDocumentExtensions::pauseAnimations):
1531         (WebCore::SVGDocumentExtensions::unpauseAnimations):
1532         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1533         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1534         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1535         * ksvg2/svg/SVGAnimateTransformElement.h:
1536         * ksvg2/svg/SVGAnimationElement.cpp:
1537         (WebCore::SVGAnimationElement::SVGAnimationElement):
1538         (WebCore::SVGAnimationElement::parseMappedAttribute):
1539         (WebCore::SVGAnimationElement::parseClockValue):
1540         (WebCore::SVGAnimationElement::targetAttribute):
1541         (WebCore::SVGAnimationElement::setTargetAttribute):
1542         (WebCore::SVGAnimationElement::attributeName):
1543         * ksvg2/svg/SVGAnimationElement.h:
1544         (WebCore::SVGAnimationElement::rendererIsNeeded):
1545         * ksvg2/svg/SVGSVGElement.cpp:
1546         (WebCore::SVGSVGElement::getScreenCTM):
1547         (WebCore::SVGSVGElement::createRenderer):
1548         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
1549         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
1550         * ksvg2/svg/SVGSVGElement.h:
1551         * ksvg2/svg/SVGSetElement.cpp:
1552         (WebCore::SVGSetElement::handleTimerEvent):
1553         * ksvg2/svg/SVGURIReference.cpp:
1554         (WebCore::SVGURIReference::getTarget):
1555         * ksvg2/svg/SVGURIReference.h:
1556
1557 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
1558
1559         Reviewed by mitzpettel.
1560
1561         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
1562         No-SVG build broken since r16549
1563         
1564         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
1565
1566         * css/cssparser.cpp:
1567         (WebCore::CSSParser::parseValue):
1568         * css/cssstyleselector.cpp:
1569         (WebCore::CSSStyleSelector::applyProperty):
1570         * page/FrameView.cpp:
1571         (WebCore::selectCursor):
1572         * platform/qt/GraphicsContextQt.cpp:
1573
1574 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
1575
1576         Reviewed by Maciej.
1577
1578         http://bugs.webkit.org/show_bug.cgi?id=10820
1579         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
1580         
1581         (Originally written by Eric Seidel).
1582         
1583         * bindings/js/kjs_window.cpp:
1584         (KJS::floatFeature):
1585         * ksvg2/svg/SVGAngle.cpp:
1586         (SVGAngle::setValueAsString):
1587         * ksvg2/svg/SVGAnimationElement.cpp:
1588         (SVGAnimationElement::parseMappedAttribute):
1589         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1590         (SVGComponentTransferFunctionElement::parseMappedAttribute):
1591         * ksvg2/svg/SVGFECompositeElement.cpp:
1592         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1593         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1594         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1595         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1596         (SVGFEDisplacementMapElement::parseMappedAttribute):
1597         * ksvg2/svg/SVGFELightElement.cpp:
1598         (SVGFELightElement::parseMappedAttribute):
1599         * ksvg2/svg/SVGFEOffsetElement.cpp:
1600         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1601         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1602         (SVGFESpecularLightingElement::parseMappedAttribute):
1603         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1604         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1605         * ksvg2/svg/SVGStopElement.cpp:
1606         (SVGStopElement::parseMappedAttribute):
1607         * platform/AtomicString.h:
1608         (WebCore::AtomicString::toDouble):
1609         * platform/PlatformString.h:
1610         * platform/String.cpp:
1611         (WebCore::String::toDouble):
1612         * platform/StringImpl.cpp:
1613         (WebCore::StringImpl::toDouble):
1614         * platform/StringImpl.h:
1615         * rendering/DeprecatedSlider.cpp:
1616         (WebCore::DeprecatedSlider::updateFromElement):
1617         * xml/XPathGrammar.y:
1618
1619 2006-09-25  David Harrison  <harrison@apple.com>
1620
1621         Reviewed by Tim Omernick and Tim Hatcher.
1622
1623         <rdar://problem/4717965> Text Field text parameterized attributes should work
1624         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
1625
1626         * bridge/mac/WebCoreAXObject.mm:
1627         (-[WebCoreAXObject accessibilityAttributeValue:]):
1628         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
1629         
1630         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1631         Cleaned up. Added text field and text area parameterzed attributes.
1632         
1633         (-[WebCoreAXObject doAXLineForTextMarker:]):
1634         Fixed to be zero-based and to deal with the first position properly.
1635         
1636         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
1637         Minor formatting.
1638         
1639         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
1640         (-[WebCoreAXObject indexForTextMarker:]):
1641         (-[WebCoreAXObject textMarkerRangeForRange:]):
1642         (-[WebCoreAXObject rangeForTextMarkerRange:]):
1643         New utility methods.
1644         
1645         (-[WebCoreAXObject doAXLineForIndex:]):
1646         (-[WebCoreAXObject doAXRangeForLine:]):
1647         (-[WebCoreAXObject doAXStringForRange:]):
1648         (-[WebCoreAXObject doAXRangeForPosition:]):
1649         (-[WebCoreAXObject doAXRangeForIndex:]):
1650         (-[WebCoreAXObject doAXBoundsForRange:]):
1651         (-[WebCoreAXObject doAXAttributedStringForRange:]):
1652         (-[WebCoreAXObject doAXRTFForRange:]):
1653         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
1654         Implement text field and text area parameterized attributes.
1655          
1656         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1657         Added text field and text area parameterzed attributes.
1658
1659         * rendering/RenderTextControl.h:
1660         Made indexForVisiblePosition() and visiblePositionForIndex() public.
1661
1662 2006-09-25  Adam Roben  <aroben@apple.com>
1663
1664         Reviewed by Brady.
1665
1666         Build fixes.
1667
1668         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
1669         * platform/ResourceLoader.h: Store whether a particular job
1670         has received a response within the ResourceLoader object itself, since
1671         it's possible that we will enter the InternetReadFileExA while loop
1672         twice for the same job.
1673         * platform/ResourceLoaderInternal.h: Add private instance variable to
1674         store whether we've received a response.
1675         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1676         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
1677         directives.
1678         * platform/win/ResourceLoaderWin.cpp: 
1679         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
1680         whether it has received a response instead of assuming it hasn't.
1681         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
1682         (WebCore::ResourceLoader::hasReceivedResponse): Added.
1683         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
1684         setProportion
1685         (ScrollBar::setProportion):
1686
1687 2006-09-25  Brady Eidson  <beidson@apple.com>
1688
1689         Requested by ggaren
1690
1691         Disabled IconDatabase logging by default
1692
1693         * platform/Logging.cpp:
1694         (WebCore::):
1695
1696 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
1697
1698         Build fix
1699
1700         * platform/cf/ResourceLoaderCFNet.cpp:
1701         (WebCore::willCacheResponse):
1702
1703 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
1704
1705         Reviewed by john
1706         
1707         <http://bugs.webkit.org/show_bug.cgi?id=11002>
1708         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
1709         
1710         * editing/IndentOutdentCommand.cpp:
1711         (WebCore::IndentOutdentCommand::indentRegion): Special case
1712         an empty root editable element.
1713
1714 2006-09-25  Brady Eidson  <beidson@apple.com>
1715
1716         Reviewed by Steve
1717
1718         Math error in SystemTimeWin
1719
1720         * platform/win/SystemTimeWin.cpp:
1721         (WebCore::currentTime):
1722
1723 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
1724
1725         Reviewed by Eric.
1726
1727         Whitespace cleanup; rename *job variables to *loader.
1728
1729         * bindings/js/JSXMLHttpRequest.cpp:
1730         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
1731         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
1732         (KJS::JSXMLHttpRequestConstructorImp::construct):
1733         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
1734         (KJS::JSXMLHttpRequest::getValueProperty):
1735         (KJS::JSXMLHttpRequest::put):
1736         (KJS::JSXMLHttpRequest::putValueProperty):
1737         (KJS::JSXMLHttpRequest::mark):
1738         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
1739         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
1740         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
1741         * bindings/js/JSXMLHttpRequest.h:
1742         (KJS::JSXMLHttpRequest::toBoolean):
1743         * xml/xmlhttprequest.cpp:
1744         (WebCore::XMLHttpRequest::XMLHttpRequest):
1745         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1746         (WebCore::XMLHttpRequest::send):
1747         (WebCore::XMLHttpRequest::abort):
1748         (WebCore::XMLHttpRequest::receivedAllData):
1749         (WebCore::XMLHttpRequest::receivedData):
1750         * xml/xmlhttprequest.h:
1751         (WebCore::):
1752
1753 2006-09-25  Timothy Hatcher  <timothy@apple.com>
1754
1755         Reviewed by Brady.
1756
1757         - Deprecate the rest of the old-style methods that are not generated.
1758         - Add @property syntax to DOMRange.
1759
1760         * WebCore.xcodeproj/project.pbxproj:
1761         * bindings/objc/DOM.mm:
1762         (-[DOMRange setStart:offset:]):
1763         (-[DOMRange setEnd:offset:]):
1764         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1765         (-[DOMRange setStart::]):
1766         (-[DOMRange setEnd::]):
1767         (-[DOMRange compareBoundaryPoints::]):
1768         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1769         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1770         (-[DOMDocument createNodeIterator::::]):
1771         (-[DOMDocument createTreeWalker::::]):
1772         * bindings/objc/DOMCSS.h:
1773         * bindings/objc/DOMCSS.mm:
1774         (-[DOMDocument getComputedStyle:pseudoElement:]):
1775         (-[DOMDocument getComputedStyle::]):
1776         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1777         * bindings/objc/DOMExtensions.h:
1778         * bindings/objc/DOMHTML.h:
1779         * bindings/objc/DOMRange.h:
1780         * bindings/objc/DOMTraversal.h:
1781
1782 2006-09-25  Eric Seidel  <eric@eseidel.com>
1783
1784         Reviewed by mjs.
1785         
1786         Outermost <svg> element should clip to viewport
1787         http://bugs.webkit.org/show_bug.cgi?id=11007
1788
1789         Test: svg/custom/viewport-clip.svg
1790
1791         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1792
1793 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1794
1795         Reviewed by Maciej.
1796
1797         * css/MediaList.cpp:
1798         Remove unused header.
1799         
1800         * dom/Document.cpp:
1801         (WebCore::Document::clear):
1802         Use clear instead of iterating through the list of event listeners, removing each one.
1803         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1804         
1805         * html/HTMLKeygenElement.cpp:
1806         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1807         (WebCore::HTMLKeygenElement::appendFormData):
1808         Update due to changes in the SSL key generator.
1809         
1810         * ksvg2/svg/SVGAngle.cpp:
1811         Remove unused header.
1812         
1813         * ksvg2/svg/SVGAnimationElement.cpp:
1814         (SVGAnimationElement::parseMappedAttribute):
1815         Rename methods and pass Strings instead of DeprecatedStrings to
1816         parseSeparatedList.
1817         
1818         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1819         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1820         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1821         * ksvg2/svg/SVGFEMergeElement.cpp:
1822         * ksvg2/svg/SVGFEOffsetElement.cpp:
1823         Remove unused headers.
1824         
1825         * ksvg2/svg/SVGHelper.cpp:
1826         (WebCore::SVGHelper::parseSeparatedList):
1827         * ksvg2/svg/SVGHelper.h:
1828         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
1829         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1830         
1831         * ksvg2/svg/SVGLengthList.cpp:
1832         (WebCore::SVGLengthList::parse):
1833         * ksvg2/svg/SVGLengthList.h:
1834         Use Vector<String> instead of DeprecatedStringList.
1835         
1836         * loader/Cache.cpp:
1837         (WebCore::Cache::requestImage):
1838         (WebCore::Cache::requestStyleSheet):
1839         (WebCore::Cache::requestScript):
1840         (WebCore::Cache::requestXSLStyleSheet):
1841         (WebCore::Cache::requestXBLDocument):
1842         (WebCore::Cache::remove):
1843         (WebCore::Cache::get):
1844         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1845         
1846         * loader/DocLoader.cpp:
1847         (WebCore::DocLoader::needReload):
1848         * loader/DocLoader.h:
1849         Use a HashSet instead of DeprecatedStringList.
1850         
1851         * page/FrameView.h:
1852         Remove declarations that have no functions.
1853         
1854         * platform/SSLKeyGenerator.h:
1855         * platform/mac/SSLKeyGeneratorMac.mm:
1856         (WebCore::supportedKeySizes):
1857         (WebCore::signedPublicKeyAndChallengeString):
1858         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1859         DeprecatedString.
1860
1861 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1862
1863         Shunt the RenderTheme world transform adoption between
1864         Cairo and Windows into getWindowsContext and move the method
1865         out of GraphicsContextCairo and into GraphicsContextWin.
1866
1867         * ChangeLog:
1868         * WebCore.vcproj/WebCore/WebCore.vcproj:
1869         * platform/cairo/GraphicsContextCairo.cpp:
1870         * platform/win/GraphicsContextWin.cpp: Added.
1871         (WebCore::GraphicsContext::getWindowsContext):
1872         (WebCore::GraphicsContext::releaseWindowsContext):
1873         * rendering/RenderThemeWin.cpp:
1874         (WebCore::prepareForDrawing):
1875
1876 2006-09-24  Eric Seidel  <eric@eseidel.com>
1877
1878         Reviewed by hyatt.
1879
1880         <svg:a> cannot be styled with a:hover
1881         http://bugs.webkit.org/show_bug.cgi?id=11005
1882         
1883         Test: svg/hixie/cascade/002.xml
1884
1885         * css/cssstyleselector.cpp:
1886         (WebCore::checkPseudoState):
1887
1888 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1889
1890         Reviewed by Tim H.
1891
1892         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1893         SVG needs Obj-C DOM bindings
1894
1895         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The 
1896           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1897           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and 
1898           DOMSVGTransformList.
1899
1900         * DerivedSources.make:
1901         * WebCore.xcodeproj/project.pbxproj:
1902         * bindings/objc/DOMInternal.h:
1903         * bindings/objc/DOMSVG.h: Added.
1904         * ksvg2/svg/SVGAngle.idl:
1905         * ksvg2/svg/SVGLength.idl:
1906         * ksvg2/svg/SVGLengthList.idl:
1907         * ksvg2/svg/SVGMatrix.idl:
1908         * ksvg2/svg/SVGPathSeg.idl:
1909         * ksvg2/svg/SVGPathSegList.idl:
1910         * ksvg2/svg/SVGTransform.idl:
1911         * ksvg2/svg/SVGTransformList.idl:
1912
1913 2006-09-24  Rob Buis  <buis@kde.org>
1914
1915         Reviewed by eseidel.
1916
1917         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1918         WebKit does not handle fallback custom cursors
1919         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1920         WebKit does not properly handle SVG <cursor> element
1921
1922         Add support for svg cursor images. Also make sure hotspot
1923         settings are handled correctly. Add tests for handling of css3
1924         cursor syntax with hotspots in strict and quirks mode. Finally
1925         implement fallback.
1926
1927         * WebCore.xcodeproj/project.pbxproj:
1928         * css/CSSComputedStyleDeclaration.cpp:
1929         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1930         * css/CSSCursorImageValue.cpp: Added.
1931         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1932         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1933         * css/CSSCursorImageValue.h: Added.
1934         (WebCore::CSSCursorImageValue::hotspot):
1935         * css/cssparser.cpp:
1936         (WebCore::CSSParser::parseValue):
1937         * css/cssstyleselector.cpp:
1938         (WebCore::CSSStyleSelector::applyProperty):
1939         * ksvg2/svg/SVGCursorElement.cpp:
1940         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1941         * manual-tests/css3-cursor-fallback-strict.html: Added.
1942         * manual-tests/cursorfallback.xml: Added.
1943         * page/FrameView.cpp:
1944         (WebCore::selectCursor):
1945         * platform/Cursor.h:
1946         * platform/mac/CursorMac.mm:
1947         (WebCore::createCustomCursor):
1948         (WebCore::Cursor::Cursor):
1949         * platform/qt/CursorQt.cpp:
1950         (WebCore::Cursor::Cursor):
1951         * rendering/RenderStyle.cpp:
1952         (WebCore::StyleInheritedData::StyleInheritedData):
1953         (WebCore::StyleInheritedData::operator==):
1954         (WebCore::RenderStyle::diff):
1955         (WebCore::RenderStyle::addCursor):
1956         (WebCore::RenderStyle::addSVGCursor):
1957         (WebCore::RenderStyle::setCursorList):
1958         (WebCore::RenderStyle::clearCursorList):
1959         * rendering/RenderStyle.h:
1960         (WebCore::CursorData::CursorData):
1961         (WebCore::CursorList::operator[]):
1962         (WebCore::CursorList::size):
1963         (WebCore::CursorList::append):
1964         (WebCore::RenderStyle::cursors):
1965
1966 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1967
1968         Reviewed by Tim H.
1969
1970         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1971         Auto-generate the internal methods interfaces for the Objective-C bindings
1972
1973         - Auto-generate the internal method declarations into their own files
1974           named in the form DOMFooBarInternal.h for class DOMFooBar.
1975
1976         - Remove all use of DOM_cast from code.
1977
1978         - Assorted cleanups.
1979
1980         * WebCore.xcodeproj/project.pbxproj:
1981         * bindings/objc/DOM.mm:
1982         (-[DOMNode _initWithNode:WebCore::]):
1983         (-[DOMNode WebCore::]):
1984         (-[DOMRange dealloc]):
1985         (-[DOMRange finalize]):
1986         (-[DOMRange _initWithRange:WebCore::]):
1987         (-[DOMRange WebCore::]):
1988         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1989         (-[DOMNodeFilter WebCore::]):
1990         (-[DOMNodeFilter dealloc]):
1991         (-[DOMNodeFilter finalize]):
1992         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1993         (-[DOMNodeIterator WebCore::]):
1994         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1995         (-[DOMTreeWalker WebCore::]):
1996         * bindings/objc/DOMAbstractView.mm:
1997         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1998         * bindings/objc/DOMCSS.mm:
1999         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2000         (-[DOMCSSRule _initWithRule:WebCore::]):
2001         (-[DOMCSSValue _initWithValue:WebCore::]):
2002         * bindings/objc/DOMEvents.mm:
2003         (-[DOMEvent _initWithEvent:WebCore::]):
2004         * bindings/objc/DOMHTMLAppletElement.mm:
2005         (-[DOMHTMLAppletElement align]):
2006         (-[DOMHTMLAppletElement setAlign:]):
2007         (-[DOMHTMLAppletElement alt]):
2008         (-[DOMHTMLAppletElement setAlt:]):
2009         (-[DOMHTMLAppletElement archive]):
2010         (-[DOMHTMLAppletElement setArchive:]):
2011         (-[DOMHTMLAppletElement code]):
2012         (-[DOMHTMLAppletElement setCode:]):
2013         (-[DOMHTMLAppletElement codeBase]):
2014         (-[DOMHTMLAppletElement setCodeBase:]):
2015         (-[DOMHTMLAppletElement height]):
2016         (-[DOMHTMLAppletElement setHeight:]):
2017         (-[DOMHTMLAppletElement hspace]):
2018         (-[DOMHTMLAppletElement setHspace:]):
2019         (-[DOMHTMLAppletElement name]):
2020         (-[DOMHTMLAppletElement setName:]):
2021         (-[DOMHTMLAppletElement object]):
2022         (-[DOMHTMLAppletElement setObject:]):
2023         (-[DOMHTMLAppletElement vspace]):
2024         (-[DOMHTMLAppletElement setVspace:]):
2025         (-[DOMHTMLAppletElement width]):
2026         (-[DOMHTMLAppletElement setWidth:]):
2027         * bindings/objc/DOMInternal.h:
2028         (getDOMWrapper):
2029         (addDOMWrapper):
2030         (raiseOnDOMError):
2031         * bindings/objc/DOMXPath.mm:
2032         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2033         * bindings/scripts/CodeGeneratorObjC.pm:
2034
2035 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2036
2037         Reviewed by eseidel.
2038
2039         Fix Qt/Linux build after Dave's Scrollbar changes.
2040
2041         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
2042         * platform/qt/TemporaryLinkStubs.cpp:
2043         (WebCore::ScrollBar::setProportion):
2044         (WebCore::PlatformScrollBar::updateThumbPosition):
2045         (WebCore::PlatformScrollBar::updateThumbProportion):
2046
2047 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2048
2049         Reviewed by eseidel.
2050
2051         Qt/Linux build system changes: enable xpath/xslt by default.
2052         Offer possibility to change all of these using 'ccmake'.
2053
2054         * CMakeLists.txt:
2055
2056 2006-09-24  Dave Hyatt  <hyatt@apple.com>
2057
2058         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
2059         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
2060         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
2061
2062         * platform/ScrollBar.cpp:
2063         (WebCore::ScrollBar::setValue):
2064         (WebCore::ScrollBar::setProportion):
2065         * platform/ScrollBar.h:
2066         (WebCore::ScrollBar::value):
2067         * platform/mac/PlatformScrollBar.h:
2068         * platform/mac/PlatformScrollBarMac.mm:
2069         (WebCore::PlatformScrollBar::updateThumbPosition):
2070         (WebCore::PlatformScrollBar::updateThumbProportion):
2071         * platform/win/PlatformScrollBar.h:
2072         * platform/win/TemporaryLinkStubs.cpp:
2073         (PlatformScrollBar::updateThumbPosition):
2074         (PlatformScrollBar::updateThumbProportion):
2075         * rendering/RenderLayer.cpp:
2076         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2077
2078 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
2079
2080         Reviewed by Eric.
2081
2082         http://bugs.webkit.org/show_bug.cgi?id=4872
2083         XMLHttpRequest fails to throw an exception when there is a security violation
2084         (mismatching domains)
2085
2086         Raise an exception if there is a security violation, and also in cases required by
2087         the current draft of XHR specification.
2088
2089         * bindings/js/JSXMLHttpRequest.cpp:
2090         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
2091         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
2092         reports one, and also if there were too few arguments passed. 
2093
2094         * bindings/js/kjs_binding.cpp:
2095         (KJS::setDOMException): Added support for custom XHR exceptions.
2096
2097         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
2098         exception code range for XHR exceptions.
2099
2100         * xml/xmlhttprequest.cpp:
2101         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
2102         (WebCore::XMLHttpRequest::send):
2103         (WebCore::XMLHttpRequest::setRequestHeader):
2104         (WebCore::XMLHttpRequest::getStatus):
2105         (WebCore::XMLHttpRequest::getStatusText):
2106         (WebCore::XMLHttpRequest::processSyncLoadResults):
2107         (WebCore::XMLHttpRequest::receivedAllData):
2108         (WebCore::XMLHttpRequest::receivedData):
2109
2110 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
2111
2112         Reviewed by Jeff Jenkins.
2113
2114         Tweak CF types.
2115
2116         * platform/cf/ResourceLoaderCFNet.cpp:
2117         (WebCore::willCacheResponse):
2118
2119 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
2120
2121         Reviewed by darin
2122
2123         <http://bugs.webkit.org/show_bug.cgi?id=8029>
2124         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
2125
2126         * dom/Document.cpp:
2127         (WebCore::Document::clearSelectionIfNeeded):
2128         * dom/Element.cpp:
2129         (WebCore::Element::contains):
2130         * dom/Node.cpp:
2131         (WebCore::Node::traverseNextNode):
2132         (WebCore::Node::traverseNextSibling):
2133         (WebCore::Node::traversePreviousNodePostOrder):
2134         (WebCore::Node::checkAddChild):
2135         (WebCore::Node::isDescendantOf):
2136         * dom/Node.h:
2137         * dom/NodeIterator.cpp:
2138         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
2139         * editing/ApplyStyleCommand.cpp:
2140         (WebCore::ApplyStyleCommand::applyBlockStyle):
2141         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2142         (WebCore::ApplyStyleCommand::applyInlineStyle):
2143         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
2144         * editing/CompositeEditCommand.cpp:
2145         (WebCore::CompositeEditCommand::mergeIdenticalElements):
2146         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2147         * editing/DeleteSelectionCommand.cpp:
2148         (WebCore::updatePositionForNodeRemoval):
2149         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2150         (WebCore::DeleteSelectionCommand::mergeParagraphs):
2151         * editing/FormatBlockCommand.cpp:
2152         (WebCore::FormatBlockCommand::doApply):
2153         * editing/IndentOutdentCommand.cpp:
2154         (WebCore::enclosingListOrBlockquote):
2155         * editing/Selection.cpp:
2156         (WebCore::Selection::validate):
2157         * editing/SelectionController.cpp:
2158         (WebCore::SelectionController::nodeWillBeRemoved):
2159         * editing/TextIterator.cpp:
2160         (WebCore::SimplifiedBackwardsTextIterator::advance):
2161         * editing/VisiblePosition.cpp:
2162         (WebCore::VisiblePosition::next):
2163         (WebCore::VisiblePosition::previous):
2164         (WebCore::VisiblePosition::canonicalPosition):
2165         (WebCore::isFirstVisiblePositionInNode):
2166         (WebCore::isLastVisiblePositionInNode):
2167         * editing/htmlediting.cpp:
2168         (WebCore::firstEditablePositionAfterPositionInRoot):
2169         (WebCore::lastEditablePositionBeforePositionInRoot):
2170         (WebCore::enclosingNodeWithTag):
2171         (WebCore::enclosingList):
2172         (WebCore::enclosingListChild):
2173         * editing/markup.cpp:
2174         (WebCore::createMarkup):
2175
2176 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2177
2178         Reviewed by Darin.
2179
2180         - Added @property syntax to non-generated headers
2181           inside #ifndef BUILDING_ON_TIGER.
2182         - Changed the DOMEventTarget protocol to have have new versions
2183           of addEventListener and removeEventListener with named parameters.
2184           These old style methods can be removed once Mail changes to use
2185           the new methods <rdar://problem/4746649>.
2186
2187         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
2188         * bindings/objc/DOM.mm:
2189         (-[DOMNode addEventListener:listener:useCapture:]):
2190         (-[DOMNode addEventListener:::]): call the new method
2191         (-[DOMNode removeEventListener:listener:useCapture:]):
2192         (-[DOMNode removeEventListener:::]): call the new method
2193         * bindings/objc/DOMAbstractView.h:
2194         * bindings/objc/DOMEventTarget.h:
2195         * bindings/objc/DOMHTMLAppletElement.h:
2196         * bindings/objc/DOMHTMLEmbedElement.h:
2197         * bindings/objc/DOMHTMLOptionElement.h:
2198         * bindings/objc/DOMObject.h:
2199         * bindings/objc/DOMRGBColor.h:
2200
2201 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2202
2203         Reviewed by Eric.
2204
2205         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
2206
2207         * platform/qt/FrameQt.cpp:
2208         * platform/qt/GraphicsContextQt.cpp:
2209         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
2210         (WebCore::GraphicsContext::origin):
2211         * platform/qt/PlatformScrollBar.h: Added.
2212         (WebCore::PlatformScrollBar::isWidget):
2213         * platform/qt/WidgetQt.cpp:
2214         (WebCore::Widget::invalidate):
2215         (WebCore::Widget::invalidateRect):
2216
2217 2006-09-22  Dave Hyatt <hyatt@apple.com>
2218
2219         Super-minor tweaks to the systemFont function on Mac.
2220         Set the generic family to None rather than to Serif, and
2221         don't waste time setting the computed size, since that is
2222         set from the specified size over in CSSStyleSelector anyway.
2223
2224         * rendering/RenderThemeMac.mm:
2225         (WebCore::RenderThemeMac::systemFont):
2226
2227 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2228
2229         Reviewed by Brady.
2230
2231         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
2232         take floats. There was already an implicit conversion to float/double
2233         when calling CGContextTranslateCTM or cairo_translate.
2234
2235         * platform/GraphicsContext.h:
2236         * platform/cairo/GraphicsContextCairo.cpp:
2237         (WebCore::GraphicsContext::translate):
2238         * platform/cg/GraphicsContextCG.cpp:
2239         (WebCore::GraphicsContext::translate):
2240
2241 2006-09-22  Brady Eidson  <beidson@apple.com>
2242
2243         Reviewed by Sfalken
2244
2245         Add redirect and other cleanup to ResourceLoaderWin.cpp
2246         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
2247         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
2248
2249         * WebCore.xcodeproj/project.pbxproj:
2250         * platform/ResourceLoader.h:
2251         * platform/win/ResourceLoaderWin.cpp:
2252         (WebCore::ResourceLoaderWndProc):
2253         (WebCore::initializeOffScreenResourceLoaderWindow):
2254         (WebCore::ResourceLoader::onHandleCreated):
2255         (WebCore::ResourceLoader::onRequestRedirected):
2256         (WebCore::ResourceLoader::onRequestComplete):
2257         (WebCore::transferJobStatusCallback):
2258
2259 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
2260
2261         Reviewed by Geoff.
2262
2263         http://bugs.webkit.org/show_bug.cgi?id=10803
2264         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
2265
2266         * page/FrameView.cpp:
2267         (WebCore::FrameView::hoverTimerFired): Use the current event.
2268
2269 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2270
2271         Reviewed by Anders.
2272
2273         Fix (last) svg memory leak.
2274
2275         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
2276         (SVGTransformable::parseTransformAttribute):
2277
2278 2006-09-22  Eric Seidel  <eric@eseidel.com>
2279
2280         No review necessary, just removing a dead file.
2281
2282         Remove unused file (added previously by mistake) to make room for real implementation.
2283
2284         * platform/mac/BitmapImageMac.mm: Removed.
2285
2286 2006-09-22  Dave Hyatt <hyatt@apple.com>
2287
2288         Move PlatformScrollBar.h down into the platforms.
2289         
2290         Reviewed by andersca
2291
2292         * platform/PlatformScrollBar.h: Removed.
2293         * platform/win/PlatformScrollBar.h: Added.
2294         * platform/mac/PlatformScrollBar.h: Added.
2295
2296 2006-09-22   Dave Hyatt  <hyatt@apple.com>
2297
2298         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
2299         any widget subsystems that don't have any underlying native objects backing the widgets.
2300
2301         Reviewed by anders
2302
2303         * platform/Widget.h:
2304         * platform/mac/WidgetMac.mm:
2305         (WebCore::Widget::invalidate):
2306         (WebCore::Widget::invalidateRect):
2307         * platform/win/TemporaryLinkStubs.cpp:
2308         (Widget::invalidate):
2309         (Widget::invalidateRect):
2310
2311 2006-09-22  Rob Buis  <buis@kd.org>
2312
2313         Reviewed by eseidel.
2314
2315         http://bugs.webkit.org/show_bug.cgi?id=10901
2316         Merge build fixes from unity
2317
2318         * CMakeLists.txt:
2319
2320 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2321
2322         Reviewed by eseidel.
2323
2324         http://bugs.webkit.org/show_bug.cgi?id=10977
2325         SVGDocument does not expose 'rootElement' property
2326
2327         Enable 'rootElement' property.
2328
2329         * ksvg2/svg/SVGDocument.idl:
2330
2331 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
2332
2333         Tweak includes.
2334
2335         * platform/ResourceLoaderInternal.h:
2336
2337 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2338
2339         build fixed. band happy.
2340         
2341         * platform/cg/GraphicsContextCG.cpp:
2342         (WebCore::GraphicsContext::translate):
2343         * platform/mac/WidgetMac.mm:
2344
2345 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2346
2347         Reviewed by Maciej.
2348         
2349         Some Widget refactoring.
2350
2351         * WebCore.vcproj/WebCore/WebCore.vcproj:
2352         * bridge/mac/FrameMac.mm:
2353         * bridge/win/FrameWin.cpp:
2354         (WebCore::FrameWin::runJavaScriptAlert):
2355         (WebCore::FrameWin::runJavaScriptConfirm):
2356         * bridge/win/PageWin.cpp:
2357         (WebCore::Page::Page):
2358         (WebCore::rootWindowForFrame):
2359         * html/CanvasRenderingContext2D.cpp:
2360         (WebCore::CanvasRenderingContext2D::translate):
2361         * page/FrameView.cpp:
2362         (WebCore::FrameView::isFrameView):
2363         * page/Page.h:
2364         (WebCore::Page::setInstanceHandle):
2365         (WebCore::Page::instanceHandle):
2366         * platform/GraphicsContext.h:
2367         * platform/ScrollView.h:
2368         * platform/Widget.h:
2369         * platform/cairo/GraphicsContextCairo.cpp:
2370         (WebCore::GraphicsContext::translate):
2371         (WebCore::GraphicsContext::origin):
2372         * platform/mac/WidgetMac.mm:
2373         (WebCore::Widget::clearFocus):
2374         * platform/win/ResourceLoaderWin.cpp:
2375         (WebCore::initializeOffScreenResourceLoaderWindow):
2376         * platform/win/ScreenWin.cpp:
2377         (WebCore::monitorInfo):
2378         * platform/win/ScrollViewWin.cpp:
2379         (WebCore::ScrollView::updateContents):
2380         (WebCore::ScrollView::visibleWidth):
2381         (WebCore::ScrollView::visibleHeight):
2382         (WebCore::ScrollView::visibleContentRect):
2383         (WebCore::ScrollView::viewportToContents):
2384         (WebCore::ScrollView::contentsToViewport):
2385         (WebCore::ScrollView::scrollBy):
2386         (WebCore::ScrollView::updateScrollInfo):
2387         (WebCore::ScrollView::updateScrollBars):
2388         * platform/win/SharedTimerWin.cpp:
2389         (WebCore::initializeOffScreenTimerWindow):
2390         * platform/win/TemporaryLinkStubs.cpp:
2391         (FrameView::updateBorder):
2392         (ScrollView::paint):
2393         (GraphicsContext::clip):
2394         * platform/win/WidgetWin.cpp:
2395         (WebCore::Widget::Widget):
2396         (WebCore::Widget::parentWindow):
2397         (WebCore::Widget::setParentWindow):
2398         (WebCore::Widget::frameGeometry):
2399         (WebCore::Widget::hasFocus):
2400         (WebCore::Widget::setFocus):
2401         (WebCore::Widget::show):
2402         (WebCore::Widget::hide):
2403         (WebCore::Widget::setFrameGeometry):
2404
2405 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2406
2407         Reviewed by Tim H.
2408
2409         * platform/TextEncoding.cpp:
2410         (WebCore::TextEncoding::backslashAsCurrencySymbol):
2411         Add comment clarifying why backslashAsCurrencySymbol is needed.
2412
2413 2006-09-21  Sean Gies  <seangies@apple.com>
2414
2415         Reviewed by Adam Roben.
2416
2417         Add utility functions to get and release HDC from GraphicsContext.
2418
2419         * platform/GraphicsContext.h: Add utilities to get and release HDC.
2420         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
2421         * rendering/RenderThemeWin.cpp: Switch to new utilities.
2422
2423 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
2424
2425         Reviewed by anders
2426         
2427         <rdar://problem/4426622>
2428         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
2429
2430         * editing/htmlediting.cpp:
2431         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
2432         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
2433         Got rid of uses of DepricatedString.
2434
2435 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2436
2437         Reviewed by eseidel.
2438
2439         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2440
2441         * page/Frame.cpp:
2442         (WebCore::Frame::endIfNotLoading):
2443
2444 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2445
2446         Reviewed by eseidel.
2447
2448         Fix Qt/Linux build.
2449
2450         * CMakeLists.txt:
2451         * kcanvas/device/qt/KCanvasClipperQt.h:
2452         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2453         * platform/qt/FrameQt.cpp:
2454         (WebCore::FrameQt::isLoadTypeReload):
2455         (WebCore::FrameQt::originalRequestURL):
2456         * platform/qt/FrameQt.h:
2457         * platform/qt/GraphicsContextQt.cpp:
2458         (WebCore::GraphicsContext::concatCTM):
2459         * platform/qt/ScrollViewQt.cpp:
2460         (WebCore::ScrollView::wheelEvent):
2461         * platform/qt/TemporaryLinkStubs.cpp:
2462         (WebCore::IconDatabase::setIconURLForPageURL):
2463
2464 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2465
2466         Reviewed by john
2467         
2468         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2469         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2470
2471         * editing/MoveSelectionCommand.cpp:
2472         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2473         to the position-to-move-to's document, not the fragment's document.  The 
2474         fragment's document is the document used to create the fragment and is irrelavant.
2475
2476 === Safari-521.27 ===
2477
2478 2006-09-21  Brady Eidson  <beidson@apple.com>
2479
2480         Reviewed by Anders
2481
2482         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2483         This fixes Spinneret so it won't crash on its first load!
2484
2485         * page/Frame.cpp:
2486         (WebCore::Frame::endIfNotLoading):
2487
2488 2006-09-21  Brady Eidson  <beidson@apple.com>
2489
2490         Build fix
2491
2492         * platform/win/TemporaryLinkStubs.cpp:
2493         (ScrollView::wheelEvent):
2494
2495 2006-09-20  Rob Buis  <buis@kde.org>
2496
2497         Reviewed by eseidel.
2498
2499         http://bugs.webkit.org/show_bug.cgi?id=10946
2500         new marker code draws end-marker in wrong place
2501
2502         Keep track of the start of the subpath so we can handle
2503         closeTo/moveTo correctly.
2504
2505         * kcanvas/RenderPath.cpp:
2506         (WebCore::DrawMarkersData::DrawMarkersData):
2507         (WebCore::updateMarkerDataForElement):
2508
2509 2006-09-21  David Hyatt <hyatt@apple.com>
2510
2511         Wheel scrolling prep for Win32.
2512
2513         WARNING: NO TEST CASES ADDED OR CHANGED
2514
2515         * platform/PlatformWheelEvent.h:
2516         * platform/ScrollBar.h:
2517         * platform/ScrollView.h:
2518         * platform/mac/ScrollViewMac.mm:
2519         (WebCore::ScrollView::wheelEvent):
2520         * rendering/RenderLayer.cpp:
2521
2522 2006-09-20  Timothy Hatcher  <timothy@apple.com>
2523
2524         Reviewed by Hyatt.
2525
2526         Bug 10917: REGRESSION (r16027): iFrame transparency broken
2527         http://bugs.webkit.org/show_bug.cgi?id=10917
2528
2529         Don't paint the base background color if we transparent.
2530
2531         * rendering/RenderBox.cpp:
2532         (WebCore::RenderBox::paintBackgroundExtended):
2533
2534 2006-09-20  Adam Roben  <aroben@apple.com>
2535
2536         Reviewed by andersca.
2537
2538         * platform/FileChooser.h: Remove no-longer-necessary namespace std
2539
2540 2006-09-20  Eric Seidel  <eric@eseidel.com>
2541
2542         Reviewed by beth.
2543
2544         Cleanup style in KCanvas.
2545         Remove extra white-space, unneeded arguments, etc.
2546
2547         * WebCore.xcodeproj/project.pbxproj:
2548         * kcanvas/KCanvasClipper.cpp:
2549         (WebCore::operator<<):
2550         (WebCore::KCanvasClipper::externalRepresentation):
2551         * kcanvas/KCanvasClipper.h:
2552         * kcanvas/KCanvasFilters.cpp:
2553         (WebCore::KCanvasFilter::externalRepresentation):
2554         (WebCore::operator<<):
2555         (WebCore::KCanvasFilterEffect::externalRepresentation):
2556         (WebCore::KCPointLightSource::externalRepresentation):
2557         (WebCore::KCSpotLightSource::externalRepresentation):
2558         (WebCore::KCDistantLightSource::externalRepresentation):
2559         (WebCore::KCanvasFEBlend::externalRepresentation):
2560         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
2561         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
2562         (WebCore::KCanvasFEComposite::externalRepresentation):
2563         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
2564         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
2565         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
2566         (WebCore::KCanvasFEFlood::externalRepresentation):
2567         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
2568         (WebCore::KCanvasFEImage::externalRepresentation):
2569         (WebCore::KCanvasFEMerge::externalRepresentation):
2570         (WebCore::KCanvasFEMorphology::externalRepresentation):
2571         (WebCore::KCanvasFEOffset::externalRepresentation):
2572         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
2573         (WebCore::KCanvasFETile::externalRepresentation):
2574         (WebCore::KCanvasFETurbulence::externalRepresentation):
2575         * kcanvas/KCanvasFilters.h:
2576         (WebCore::KCanvasFEDiffuseLighting::lightSource):
2577         (WebCore::KCanvasFESpecularLighting::lightSource):
2578         * kcanvas/KCanvasImage.h:
2579         * kcanvas/KCanvasMarker.cpp:
2580         (WebCore::KCanvasMarker::externalRepresentation):
2581         * kcanvas/KCanvasMarker.h:
2582         * kcanvas/KCanvasResource.cpp:
2583         (WebCore::operator<<):
2584         * kcanvas/KCanvasResource.h:
2585         * kcanvas/KCanvasTreeDebug.cpp:
2586         (WebCore::operator<<):
2587         (WebCore::writeIndent):
2588         (WebCore::writeStyle):
2589         (WebCore::write):
2590         (WebCore::writeRenderResources):
2591         * kcanvas/KCanvasTreeDebug.h:
2592         (WebCore::operator<<):
2593         * kcanvas/RenderForeignObject.cpp:
2594         (WebCore::RenderForeignObject::paint):
2595         * kcanvas/RenderPath.cpp:
2596         (WebCore::RenderPath::paint):
2597         (WebCore::drawStartAndMidMarkers):
2598         * kcanvas/RenderSVGContainer.cpp:
2599         (WebCore::RenderSVGContainer::paint):
2600         * kcanvas/RenderSVGImage.cpp:
2601         (WebCore::RenderSVGImage::translateForAttributes):
2602         * kcanvas/RenderSVGImage.h:
2603         * kcanvas/device/KRenderingDevice.cpp:
2604         (WebCore::KRenderingDevice::currentContext):
2605         (WebCore::KRenderingDevice::popContext):
2606         (WebCore::KRenderingDevice::pushContext):
2607         * kcanvas/device/KRenderingDevice.h:
2608         * kcanvas/device/KRenderingFillPainter.h:
2609         * kcanvas/device/KRenderingPaintServer.h:
2610         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2611         (WebCore::KRenderingPaintServer::activeClient):
2612         (WebCore::KRenderingPaintServer::setActiveClient):
2613         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2614         (WebCore::operator<<):
2615         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
2616         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
2617         (WebCore::KRenderingPaintServerGradient::listener):
2618         (WebCore::KRenderingPaintServerGradient::setListener):
2619         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
2620         * kcanvas/device/KRenderingPaintServerGradient.h:
2621         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2622         (WebCore::KRenderingPaintServerPattern::tile):
2623         (WebCore::KRenderingPaintServerPattern::setTile):
2624         (WebCore::KRenderingPaintServerPattern::listener):
2625         (WebCore::KRenderingPaintServerPattern::setListener):
2626         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
2627         * kcanvas/device/KRenderingPaintServerPattern.h:
2628         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2629         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
2630         * kcanvas/device/KRenderingPaintServerSolid.h:
2631         * kcanvas/device/KRenderingStrokePainter.cpp:
2632         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2633         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2634         * kcanvas/device/KRenderingStrokePainter.h:
2635         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2636         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2637         (WebCore::KCanvasFilterQuartz::prepareFilter):
2638         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2639         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2640         (WebCore::KCanvasMaskerQuartz::applyMask):
2641         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2642         (WebCore::KCanvasImageQuartz::init):
2643         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2644         (WebCore::KCanvasClipperQuartz::applyClip):
2645         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2646         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2647         (WebCore::KRenderingDeviceQuartz::quartzContext):
2648         (WebCore::KRenderingDeviceQuartz::contextForImage):
2649         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2650         (WebCore::KRenderingDeviceQuartz::createResource):
2651         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2652         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2653         (WebCore::CGShadingRefForLinearGradient):
2654         (WebCore::CGShadingRefForRadialGradient):
2655         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2656         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2657         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2658         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2659         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
2660         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
2661         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
2662         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
2663         (WebCore::KRenderingPaintServerSolidQuartz::draw):
2664         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2665         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2666         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2667         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2668         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
2669         * kcanvas/device/quartz/QuartzSupport.h:
2670         * kcanvas/device/quartz/QuartzSupport.mm:
2671         (WebCore::applyStrokeStyleToContext):
2672
2673 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2674
2675         Reviewed by Dave Hyatt.
2676
2677         * dom/WheelEvent.cpp:
2678         (WebCore::WheelEvent::WheelEvent):
2679         Use lroundf instead of lround since deltas are floats.
2680
2681 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
2682
2683         Reviewed by eseidel.  Landed by eseidel.
2684
2685         Test: svg/custom/pattern-y-offset.svg
2686
2687         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2688         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2689
2690 2006-09-20  David Hyatt  <hyatt@apple.com>
2691
2692         Add a new wheelEvent method to ScrollView.  Platforms that wish
2693         to handle the wheel event for the scroll view themselves can then
2694         do so there.  (Mac lets the underlying NSScrollView do it for now.)
2695
2696         * page/FrameView.cpp:
2697         (WebCore::FrameView::handleWheelEvent):
2698         * platform/ScrollView.h:
2699         (WebCore::ScrollView::wheelEvent):
2700
2701 2006-09-20  Brady Eidson  <beidson@apple.com>
2702
2703         Reviewed by Tim Omernick
2704
2705         Part of fixing a crash Tim O showed me that I missed in a release build.
2706         WebKit should be able to call through the bridge to WebCore no matter what -
2707         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
2708
2709         * bridge/mac/WebCoreIconDatabaseBridge.h:
2710         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2711         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2712         (-[WebCoreIconDatabaseBridge isOpen]):
2713         (-[WebCoreIconDatabaseBridge removeAllIcons]):
2714         (-[WebCoreIconDatabaseBridge _isEmpty]):
2715         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2716         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2717         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2718         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2719         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2720         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2721         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2722         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2723         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2724         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2725         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2726         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
2727         (-[WebCoreIconDatabaseBridge _setEnabled:]):
2728         (-[WebCoreIconDatabaseBridge _isEnabled]):
2729
2730 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2731
2732         Reviewed by Darin.
2733
2734         Add String::split which returns a Vector of Strings and use it instead of 
2735         DeprecatedStringList.
2736         
2737         * bindings/js/kjs_events.cpp:
2738         (KJS::Clipboard::getValueProperty):
2739         * bindings/js/kjs_window.cpp:
2740         (KJS::parseModalDialogFeatures):
2741         * css/MediaList.cpp:
2742         (WebCore::MediaList::setMediaText):
2743         * dom/Clipboard.h:
2744         * html/HTMLFormElement.cpp:
2745         (WebCore::HTMLFormElement::formData):
2746         * html/HTMLLinkElement.cpp:
2747         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2748         * platform/PlatformString.h:
2749         * platform/String.cpp:
2750         (WebCore::String::split):
2751         * platform/StringImpl.cpp:
2752         * platform/StringImpl.h:
2753         * platform/mac/ClipboardMac.h:
2754         * platform/mac/ClipboardMac.mm:
2755         (WebCore::ClipboardMac::types):
2756
2757 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2758
2759         Reviewed by harrison
2760
2761         * css/cssstyleselector.cpp:
2762         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call 
2763         HTMLElement::isContentEditable just to check the Frame's editability, since
2764         it calls updateRenderering, which can get us into infinite recursion.
2765
2766 2006-09-20  Brady Eidson  <beidson@apple.com>
2767
2768         Reviewed by Darin
2769
2770         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2771
2772         * loader/icon/IconDatabase.cpp:
2773         (WebCore::IconDatabase::IconDatabase): Disabled by default
2774         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2775         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2776         (WebCore::IconDatabase::iconForPageURL): Ditto
2777         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2778         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2779         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2780         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2781         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2782         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2783         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2784         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2785
2786 2006-09-20  Adam Roben  <aroben@apple.com>
2787
2788         Reviewed by Adele.
2789
2790         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2791         REGRESSION: file upload control with direction:rtl or text-align:right
2792         draws button on top of filename/icon
2793
2794         * rendering/RenderFileUploadControl.cpp:
2795         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2796         match direction
2797         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2798         the filename and icon in RTL
2799
2800 2006-09-20  Alice Liu  <alice.liu@apple.com>
2801
2802         Reviewed by Adam Roben.
2803
2804         fixed windows build
2805
2806         * dom/WheelEvent.cpp:
2807         (WebCore::WheelEvent::WheelEvent):
2808         changed lrint to lround
2809
2810 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2811
2812         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2813         for the Objective-C bindings.  If it is found that isHorizontal
2814         is not used, we should remove it again but also remove it's
2815         declaration from PublicDOMInterfaces.h
2816
2817         * dom/WheelEvent.h:
2818         (WebCore::WheelEvent::isHorizontal):
2819         * dom/WheelEvent.idl:
2820
2821 2006-09-20  David Hyatt  <hyatt@apple.com>
2822
2823         Fix for 10945, WheelEvent should support two dimensions at once, since
2824         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2825         to allow for diagonal scrolling.
2826
2827         Reviewed by Eric
2828
2829         * dom/EventTargetNode.cpp:
2830         (WebCore::EventTargetNode::dispatchWheelEvent):
2831         * dom/WheelEvent.cpp:
2832         (WebCore::WheelEvent::WheelEvent):
2833         (WebCore::WheelEvent::initWheelEvent):
2834         * dom/WheelEvent.h:
2835         (WebCore::WheelEvent::wheelDelta):
2836         (WebCore::WheelEvent::wheelDeltaX):
2837         (WebCore::WheelEvent::wheelDeltaY):
2838         * dom/WheelEvent.idl:
2839         * page/FrameView.cpp:
2840         (WebCore::FrameView::handleWheelEvent):
2841         * platform/PlatformWheelEvent.h:
2842         (WebCore::PlatformWheelEvent::deltaX):
2843         (WebCore::PlatformWheelEvent::deltaY):
2844         (WebCore::PlatformWheelEvent::normalize):
2845         * platform/mac/WheelEventMac.mm:
2846         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2847
2848 2006-09-19  Eric Seidel  <eric@eseidel.com>
2849
2850         Reviewed by hyatt.
2851
2852         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2853         
2854         No tests were harmed in the making of this patch.
2855
2856         * WebCore.xcodeproj/project.pbxproj:
2857         * kcanvas/KCanvasClipper.cpp: Added.
2858         (WebCore::operator<<):
2859         * kcanvas/KCanvasClipper.h: Added.
2860         * kcanvas/KCanvasFilters.h:
2861         * kcanvas/KCanvasImage.h:
2862         * kcanvas/KCanvasMarker.cpp: Added.
2863         * kcanvas/KCanvasMarker.h: Added.
2864         * kcanvas/KCanvasMasker.cpp: Added.
2865         (WebCore::KCanvasMasker::KCanvasMasker):
2866         (WebCore::KCanvasMasker::setMask):
2867         (WebCore::KCanvasMasker::externalRepresentation):
2868         (WebCore::getMaskerById):
2869         * kcanvas/KCanvasMasker.h: Added.
2870         * kcanvas/KCanvasResource.cpp: Added.
2871         (WebCore::KCanvasResource::invalidate):
2872         (WebCore::KCanvasResource::externalRepresentation):
2873         (WebCore::getResourceById):
2874         (WebCore::getPaintServerById):
2875         * kcanvas/KCanvasResource.h: Added.
2876         * kcanvas/KCanvasResources.cpp: Removed.
2877         * kcanvas/KCanvasResources.h: Removed.
2878         * kcanvas/RenderPath.cpp:
2879         * kcanvas/RenderSVGContainer.cpp:
2880         * kcanvas/RenderSVGImage.cpp:
2881         * kcanvas/RenderSVGText.cpp:
2882         * kcanvas/device/KRenderingPaintServer.h:
2883         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2884         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2885         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2886         * ksvg2/svg/SVGClipPathElement.h:
2887         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2888         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2889         * ksvg2/svg/SVGFECompositeElement.cpp:
2890         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2891         * ksvg2/svg/SVGFELightElement.cpp:
2892         * ksvg2/svg/SVGFEOffsetElement.cpp:
2893         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2894         * ksvg2/svg/SVGFilterElement.cpp:
2895         * ksvg2/svg/SVGLinearGradientElement.cpp:
2896         * ksvg2/svg/SVGMarkerElement.h:
2897         * ksvg2/svg/SVGMaskElement.h:
2898
2899 2006-09-19  Brady Eidson <beidson@apple.com>
2900
2901         Reviewed by Sarge Decker
2902
2903         <rdar://problem/4739892> and <rdar://problem/4729797>
2904         - WebCore::IconDatabase needs to have and respect an enabled() flag
2905         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2906
2907         * bridge/mac/WebCoreIconDatabaseBridge.h:
2908         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2909         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2910         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2911         * loader/icon/IconDatabase.cpp:
2912         (WebCore::IconDatabase::IconDatabase):
2913         (WebCore::IconDatabase::open): Don't open if disabled
2914         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2915         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2916         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2917         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2918         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2919         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2920         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2921         (WebCore::IconDatabase::releaseIconURL):
2922         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2923         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2924         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2925         (WebCore::IconDatabase::setEnabled): Added
2926         * loader/icon/IconDatabase.h:
2927         (WebCore::IconDatabase::enabled): Added
2928         * page/Frame.cpp:
2929         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2930         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2931
2932 2006-09-20  David Hyatt  <hyatt@apple.com>
2933
2934         Massage mouse wheel handling so that it is more cross-platform.  Make
2935         all the work happen in handleWheelEvent on the FrameView.
2936
2937         Reviewed by bradee-oh
2938
2939         * bridge/mac/FrameMac.mm:
2940         (WebCore::FrameMac::wheelEvent):
2941         * page/FrameView.cpp:
2942         (WebCore::FrameView::handleWheelEvent):
2943         * platform/PlatformWheelEvent.h:
2944         (WebCore::PlatformWheelEvent::platformDelta):
2945         (WebCore::PlatformWheelEvent::delta):
2946         * platform/mac/WheelEventMac.mm:
2947         (WebCore::platformDeltaForEvent):
2948         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2949         * rendering/RenderLayer.cpp:
2950         (WebCore::RenderLayer::scroll):
2951         * rendering/RenderObject.cpp:
2952         (WebCore::RenderObject::scroll):
2953
2954 2006-09-19  Eric Seidel  <eric@eseidel.com>
2955
2956         Reviewed by adele.
2957
2958         Improve test output for filters with bounding-box relative sizes.
2959         http://bugs.webkit.org/show_bug.cgi?id=8585
2960
2961         Many test results updated.
2962
2963         * kcanvas/KCanvasFilters.cpp:
2964         (WebCore::KCanvasFilter::externalRepresentation):
2965
2966 2006-09-19  Eric Seidel  <eric@eseidel.com>
2967
2968         Reviewed by adele.
2969         
2970         Markers should clip to their viewport.
2971         http://bugs.webkit.org/show_bug.cgi?id=5967
2972
2973         Test: svg/custom/marker-overflow-clip.svg
2974
2975         * kcanvas/KCanvasResources.cpp:
2976         (WebCore::KCanvasMarker::KCanvasMarker):
2977         (WebCore::KCanvasMarker::setMarker):
2978         (WebCore::KCanvasMarker::draw):
2979         * kcanvas/KCanvasResources.h:
2980         (WebCore::KCanvasMasker::mask):
2981         * ksvg2/svg/SVGMarkerElement.cpp:
2982         (WebCore::SVGMarkerElement::SVGMarkerElement):
2983         (WebCore::SVGMarkerElement::parseMappedAttribute):
2984         (WebCore::SVGMarkerElement::canvasResource):
2985         (WebCore::SVGMarkerElement::createRenderer):
2986
2987 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2988
2989         Reviewed by eseidel
2990
2991         Backing out my recent change.
2992
2993         * css/cssstyleselector.cpp:
2994         (WebCore::CSSStyleSelector::adjustRenderStyle): 
2995
2996 2006-09-19  Brady Eidson  <beidson@apple.com>
2997
2998         Reviewed by Kevin McCullough
2999
3000         http://bugs.webkit.org/show_bug.cgi?id=10940
3001         Opening a PDF in a new tab/window creates a documentless-frame
3002         and we deref the document without checking its validity
3003
3004         * page/Frame.cpp:
3005         (WebCore::Frame::iconURL):
3006
3007 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3008
3009         Reviewed by harrison
3010         
3011         <rdar://problem/4735272>
3012         Can not click into link in programmatically editable content
3013
3014         * css/cssstyleselector.cpp:
3015         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
3016         userModify to implement document wide editability.
3017
3018 2006-09-19  MorganL  <morlmor@yahoo.com>
3019
3020         Reviewed by Darin and landed by Brady
3021
3022         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
3023         Build broken when SVG is not enabled.
3024
3025         * dom/XMLTokenizer.cpp:
3026         (WebCore::XMLTokenizer::startElementNs):
3027
3028 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3029
3030         Reviewed by harrison
3031         
3032         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
3033
3034         Pasting plain text results in a match style paste, and the insertion
3035         position is whitespace normal, which clobbers the whitespace:pre on 
3036         tab spans.  Skip changes to the whitespace mode when computing a style
3037         change for tab spans or the text nodes inside tab spans.
3038
3039         * editing/ApplyStyleCommand.cpp:
3040         (WebCore::StyleChange::init): Don't change the whitespace mode inside
3041         tab spans.
3042
3043 2006-09-19  David Hyatt  <hyatt@apple.com>
3044
3045         Fix for bug 5298, shape=default not supported for image maps.  Implement
3046         support for it.
3047
3048         Reviewed by timo
3049
3050         * html/HTMLAreaElement.cpp:
3051         (WebCore::HTMLAreaElement::getRegion):
3052         * html/HTMLMapElement.cpp:
3053         (WebCore::HTMLMapElement::mapMouseEvent):
3054
3055 2006-09-19  Adam Roben  <aroben@apple.com>
3056
3057         Reviewed by Adele.
3058
3059         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
3060         "no file selected" placeholder text missing from file upload control
3061
3062         * WebCore.xcodeproj/project.pbxproj:
3063         * rendering/RenderFileUploadControl.cpp: Remove class
3064         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
3065         defaultWidthNumChars
3066         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
3067         RenderBlock constructor instead of RenderFlexibleBox, 
3068         (WebCore::RenderFileUploadControl::setStyle): Remove references to
3069         m_fileBox.
3070         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
3071         instead of updateIconAndFileName() (which has been removed)
3072         (WebCore::RenderFileUploadControl::updateFromElement): Remove
3073         references to m_fileBox, don't call updateIconAndFilename()
3074         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
3075         without using m_fileBox
3076         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
3077         now-unnecessary display:box rule.
3078         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
3079         to paintingDisabled() now that Icon::paint() does it, and add code to
3080         paint the filename directly.
3081         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
3082         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
3083         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
3084         subclass of RenderBlock instead of RenderFlexibleBox, remove
3085         updateIconAndFilename() method, remove m_fileBox instance variable.
3086
3087 2006-09-19  Eric Seidel  <eric@eseidel.com>
3088
3089         Reviewed by hyatt.
3090
3091         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
3092         http://bugs.webkit.org/show_bug.cgi?id=10846
3093         
3094         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
3095
3096         * dom/XMLTokenizer.cpp:
3097         (WebCore::XMLTokenizer::XMLTokenizer):
3098         (WebCore::XMLTokenizer::startElementNs):
3099         (WebCore::XMLTokenizer::endElementNs):
3100
3101 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
3102
3103         Reviewed by eseidel.  Landed by eseidel.
3104         
3105         Build fix only, no tests affected.
3106
3107         * platform/gdk/FontPlatformDataGdk.cpp:
3108         (WebCore::FontPlatformData::FontPlatformData):
3109         (WebCore::FontPlatformData::~FontPlatformData):
3110         * platform/gdk/FrameGdk.h:
3111         * platform/gdk/TemporaryLinkStubs.cpp:
3112         (FrameGdk::isLoadTypeReload):
3113         (FrameGdk::originalRequestURL):
3114         (IconDatabase::setIconURLForPageURL):
3115
3116 2006-09-19  David Hyatt  <hyatt@apple.com>
3117
3118         Refine the fix for 9805 to really get all the complex cases right.
3119
3120         Reviewed by Eric
3121
3122         * rendering/RenderBlock.cpp:
3123         (WebCore::RenderBlock::clearFloatsIfNeeded):
3124         (WebCore::RenderBlock::handleBottomOfBlock):
3125
3126 2006-09-18  David Hyatt  <hyatt@apple.com>
3127
3128         Fix for 9805, <hr> not positioned properly following a previous empty sibling
3129         that had clear:both set on it.  Update self-collapsing block clearance
3130         behavior to match what is specified in the latest draft of CSS2.1.
3131
3132         Reviewed by Eric
3133
3134         Added fast/block/margin-collapse/empty-clear-blocks.html
3135
3136         * rendering/RenderBlock.cpp:
3137         (WebCore::RenderBlock::clearFloatsIfNeeded):
3138         (WebCore::RenderBlock::handleBottomOfBlock):
3139
3140 2006-09-18  MorganL  <morlmor@yahoo.com>
3141
3142         Reviewed by Brady, landed by Brady
3143
3144         Send receivedResponse callback to ResourceLoaderClient when loading
3145         file URLs.
3146
3147         See http://bugs.webkit.org/show_bug.cgi?id=10845
3148
3149         * platform/win/ResourceLoaderWin.cpp:
3150         (WebCore::ResourceLoader::fileLoadTimer):
3151
3152 2006-09-18  Brady Eidson  <beidson@apple.com>
3153
3154         Reviewed by Anders
3155
3156         <rdar://problem/3028061> - WebKit never updates favicon
3157         The WebKit enforced expiration date for icons has worked for some time, but the
3158         move to the new Icon Loader broke the "always get the icon if the user refreshes the page" 
3159         functionality.  This patch fixes that up, along with some other architectural improvements,
3160         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
3161
3162         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
3163         * bridge/mac/FrameMac.mm:
3164         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
3165         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
3166         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
3167         * dom/Document.h: Added m_iconURL
3168         (WebCore::Document::iconURL): Added
3169         (WebCore::Document::setIconURL): Ditto
3170         * html/HTMLLinkElement.cpp:
3171         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
3172         * page/Frame.cpp:
3173         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
3174         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
3175         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
3176         * page/FramePrivate.h: Nuked IconURL
3177         * platform/win/TemporaryLinkStubs.cpp:
3178         (FrameWin::isLoadTypeReload):
3179
3180 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
3181
3182         Reviewed by Tim H.
3183
3184         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
3185           it is it turns out that AppKit uses it.
3186
3187         * bindings/objc/DOMPrivate.h:
3188         * bindings/objc/DOMRGBColor.mm:
3189         (-[DOMRGBColor _color]):
3190
3191 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
3192
3193         Reviewed by Tim H.
3194
3195         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
3196         Yet Another Objective-C Bindings Patch
3197
3198         - Whitespace cleanup for IDLParser.pm
3199
3200         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
3201           and DOMAbstractView into their own files.
3202
3203         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
3204           it is not used and a public method is available now.
3205
3206         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
3207           as it not used.
3208
3209         - Auto-generate method isContentEditable for DOMNode.
3210
3211         - General cleanup of bindings code including removing unneeded #imports
3212           and whitespace cleanup
3213
3214         * WebCore.xcodeproj/project.pbxproj:
3215         * bindings/objc/DOM.mm:
3216         (addElementClass):
3217         (elementClass):
3218         (-[DOMNode _initWithNode:WebCore::]):
3219         (+[DOMNode _nodeWith:WebCore::]):
3220         (-[DOMNode WebCore::]):
3221         (-[DOMNode KJS::Bindings::]):
3222         (-[DOMNode addEventListener:::]):
3223         (-[DOMNode removeEventListener:::]):
3224         (-[DOMNode dispatchEvent:]):
3225         (-[DOMElement image]):
3226         (-[DOMElement _font]):
3227         (-[DOMElement _imageTIFFRepresentation]):
3228         (-[DOMElement _getURLAttribute:]):
3229         (-[DOMElement _NPObject]):
3230         (-[DOMElement isFocused]):
3231         (-[DOMRange dealloc]):
3232         (-[DOMRange finalize]):
3233         (-[DOMRange description]):
3234         (-[DOMRange startContainer]):
3235         (-[DOMRange startOffset]):
3236         (-[DOMRange endContainer]):
3237         (-[DOMRange endOffset]):
3238         (-[DOMRange collapsed]):
3239         (-[DOMRange commonAncestorContainer]):
3240         (-[DOMRange setStart::]):
3241         (-[DOMRange setEnd::]):
3242         (-[DOMRange setStartBefore:]):
3243         (-[DOMRange setStartAfter:]):
3244         (-[DOMRange setEndBefore:]):
3245         (-[DOMRange setEndAfter:]):
3246         (-[DOMRange collapse:]):
3247         (-[DOMRange selectNode:]):
3248         (-[DOMRange selectNodeContents:]):
3249         (-[DOMRange compareBoundaryPoints::]):
3250         (-[DOMRange deleteContents]):
3251         (-[DOMRange extractContents]):
3252         (-[DOMRange cloneContents]):
3253         (-[DOMRange insertNode:]):
3254         (-[DOMRange surroundContents:]):
3255         (-[DOMRange cloneRange]):
3256         (-[DOMRange toString]):
3257         (-[DOMRange detach]):
3258         (-[DOMRange _initWithRange:WebCore::]):
3259         (+[DOMRange _rangeWith:WebCore::]):
3260         (-[DOMRange WebCore::]):
3261         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
3262         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
3263         (-[DOMNodeFilter WebCore::]):
3264         (-[DOMNodeFilter dealloc]):
3265         (-[DOMNodeFilter finalize]):
3266         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
3267         (-[DOMNodeIterator WebCore::]):
3268         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
3269         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
3270         (-[DOMTreeWalker WebCore::]):
3271         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
3272         (ObjCNodeFilterCondition::acceptNode):
3273         (-[DOMDocument createNodeIterator::::]):
3274         (-[DOMDocument createTreeWalker::::]):
3275         (ObjCEventListener::find):
3276         (ObjCEventListener::create):
3277         (ObjCEventListener::handleEvent):
3278         * bindings/objc/DOMAbstractView.h: Added.
3279         * bindings/objc/DOMAbstractView.mm: Added.
3280         (-[DOMAbstractView document]):
3281         (-[DOMAbstractView WebCore::]):
3282         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
3283         (+[DOMAbstractView _abstractViewWith:WebCore::]):
3284         * bindings/objc/DOMCSS.mm:
3285         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
3286         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
3287         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
3288         (-[DOMCSSRule _initWithRule:WebCore::]):
3289         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
3290         (-[DOMCSSValue _initWithValue:WebCore::]):
3291         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3292         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
3293         (-[DOMDocument getComputedStyle::]):
3294         (-[DOMDocument getMatchedCSSRules::]):
3295         * bindings/objc/DOMCore.h:
3296         * bindings/objc/DOMEventException.h: Added.
3297         * bindings/objc/DOMEvents.h:
3298         * bindings/objc/DOMEvents.mm:
3299         * bindings/objc/DOMException.h: Added.
3300         * bindings/objc/DOMHTML.mm:
3301         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
3302         (viewForElement):
3303         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
3304         (-[DOMHTMLInputElement _selectedRange]):
3305         (-[DOMHTMLInputElement _setAutofilled:]):
3306         * bindings/objc/DOMInternal.h:
3307         * bindings/objc/DOMObject.h:
3308         * bindings/objc/DOMPrivate.h:
3309         * bindings/objc/DOMRange.h:
3310         * bindings/objc/DOMRangeException.h: Added.
3311         * bindings/objc/DOMViews.h:
3312         * bindings/objc/DOMViews.mm: Removed.
3313         * bindings/objc/DOMXPath.h:
3314         * bindings/objc/DOMXPathException.h: Added.
3315         * bindings/scripts/IDLParser.pm:
3316         * dom/Node.idl:
3317
3318 2006-09-18  Brady Eidson  <beidson@apple.com>
3319
3320         Windows build fix
3321
3322         * platform/win/TemporaryLinkStubs.cpp:
3323         (IconDatabase::setIconURLForPageURL):
3324
3325 2006-09-18  David Hyatt  <hyatt@apple.com>
3326
3327         Fix for bug 3969, hr width doesn't update when it clears a float.  This
3328         was also a problem with tables and overflow sections.
3329
3330         Reviewed by Eric
3331
3332         Added fast/block/float/width-update-after-clear.html
3333
3334         * rendering/RenderBlock.cpp:
3335         (WebCore::RenderBlock::collapseMargins):
3336         (WebCore::RenderBlock::clearFloatsIfNeeded):
3337
3338 2006-09-18  Brady Eidson  <beidson@apple.com>
3339
3340         Reviewed by John
3341
3342         http://bugs.webkit.org/show_bug.cgi?id=10907
3343         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
3344
3345         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
3346         * bridge/win/FrameWin.h: Added originalRequestURL()
3347         * loader/icon/IconLoader.cpp:
3348         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
3349         * page/Frame.cpp:
3350         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
3351         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
3352         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
3353         * page/Frame.h: Added pure virtual originalRequestURL()
3354         * platform/win/TemporaryLinkStubs.cpp:
3355         (FrameWin::originalRequestURL): Added
3356
3357 2006-09-18  Rob Buis  <buis@kde.org>
3358
3359         Reviewed by Maciej.
3360
3361         http://bugs.webkit.org/show_bug.cgi?id=10807
3362         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
3363
3364         Make sure the paint method is not exited without popping
3365         context and transparency layer.
3366
3367         WARNING: NO TEST CASES ADDED OR CHANGED
3368
3369         * kcanvas/RenderSVGImage.cpp:
3370         (WebCore::RenderSVGImage::paint):
3371
3372 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
3373
3374         Reviewed by Eric.
3375         
3376         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
3377         REGRESSION: WebKit can't be built with SVG disabled
3378         
3379         * bindings/scripts/CodeGeneratorObjC.pm:
3380         For each file generated add a #ifdef <something>_SUPPORT / #endif
3381         pair if the idl file has a Conditional extended attribute
3382
3383 2006-09-17  Eric Seidel  <eric@eseidel.com>
3384
3385         Reviewed by ap.
3386         
3387         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
3388         http://bugs.webkit.org/show_bug.cgi?id=10813
3389
3390         * bridge/mac/WebCoreFrameBridge.mm:
3391         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
3392
3393 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3394
3395         Reviewed by Hyatt.
3396
3397         http://bugs.webkit.org/show_bug.cgi?id=10779
3398         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
3399
3400         No test possible.
3401
3402         * platform/Image.cpp:
3403         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
3404         maybe the rest just hasn't been loaded yet.
3405         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
3406         to start animating before we get at least two frames.
3407
3408 2006-09-17  Brady Eidson <beidson@apple.com>
3409
3410         Reviewed by Sarge
3411
3412         IconLoader now gracefully handles the condition where there's no document in the frame
3413         (ie. PDFs)
3414
3415         * loader/icon/IconLoader.cpp:
3416         (IconLoader::startLoading):
3417
3418 2006-09-17  David Hyatt  <hyatt@apple.com>
3419
3420         Fix for bug 10899, rework how CSS keywords work to be smarter about
3421         using the correct size when generic families change (e.g., monospace to
3422         serif and vice versa).
3423
3424         Reviewed by aroben
3425
3426         Added fast/text/basic/generic-family-changes.html
3427
3428         * css/cssstyleselector.cpp:
3429         (WebCore::CSSStyleSelector::applyProperty):
3430         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
3431         (WebCore::CSSStyleSelector::fontSizeForKeyword):
3432         * css/cssstyleselector.h:
3433         * dom/Document.cpp:
3434         (WebCore::Document::recalcStyle):
3435         * platform/FontDescription.h:
3436         (WebCore::FontDescription::FontDescription):
3437         (WebCore::FontDescription::keywordSize):
3438         (WebCore::FontDescription::setKeywordSize):
3439         (WebCore::FontDescription::operator==):
3440
3441 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3442
3443         Reviewed by Brady.
3444
3445         http://bugs.webkit.org/show_bug.cgi?id=10852
3446         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
3447
3448         Test: http/tests/xmlhttprequest/xhr-onunload.html
3449
3450         * xml/xmlhttprequest.cpp:
3451         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
3452
3453         * loader/icon/IconLoader.cpp:
3454         (IconLoader::startLoading): Fix a similar latent bug here.
3455
3456 2006-09-17  Adam Roben  <aroben@apple.com>
3457
3458         Build fix.
3459
3460         * loader/icon/IconDatabase.cpp:
3461
3462 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
3463
3464         Reviewed by Brady.
3465
3466         Add simplifyWhiteSpace and stripWhiteSpace to the String class. 
3467         Change the XSLT Parameter Map to use Strings instead of StringImpls.
3468         General cleanup.
3469
3470         * bindings/js/JSXSLTProcessor.cpp:
3471         (KJS::XSLTProcessorProtoFunc::callAsFunction):
3472         * bindings/js/kjs_events.cpp:
3473         (KJS::JSAbstractEventListener::handleEvent):
3474         * bindings/js/kjs_window.cpp:
3475         (KJS::ScheduledAction::execute):
3476         * css/MediaList.cpp:
3477         (WebCore::MediaList::setMediaText):
3478         * dom/Document.cpp:
3479         (WebCore::Document::processHttpEquiv):
3480         * editing/ApplyStyleCommand.cpp:
3481         (WebCore::StyleChange::init):
3482         * html/HTMLDocument.cpp:
3483         (WebCore::parseDocTypeDeclaration):
3484         * html/HTMLLinkElement.cpp:
3485         (WebCore::HTMLLinkElement::parseMappedAttribute):
3486         * html/HTMLObjectElement.cpp:
3487         (WebCore::HTMLObjectElement::HTMLObjectElement):
3488         (WebCore::HTMLObjectElement::parseMappedAttribute):
3489         (WebCore::HTMLObjectElement::attach):
3490         (WebCore::HTMLObjectElement::setComplete):
3491         (WebCore::HTMLObjectElement::detach):
3492         (WebCore::HTMLObjectElement::recalcStyle):
3493         (WebCore::HTMLObjectElement::childrenChanged):
3494         (WebCore::HTMLObjectElement::isImageType):
3495         * html/HTMLObjectElement.h:
3496         * html/HTMLOptionElement.cpp:
3497         (WebCore::HTMLOptionElement::value):
3498         * html/HTMLSelectElement.cpp:
3499         (WebCore::HTMLSelectElement::appendFormData):
3500         * html/HTMLTokenizer.cpp:
3501         (WebCore::HTMLTokenizer::parseTag):
3502         * ksvg2/svg/SVGColor.cpp:
3503         (WebCore::SVGColor::setRGBColor):
3504         * ksvg2/svg/SVGDescElement.cpp:
3505         (WebCore::SVGDescElement::description):
3506         * platform/PlatformString.h:
3507         * platform/String.cpp:
3508         (WebCore::String::stripWhiteSpace):
3509         (WebCore::String::simplifyWhiteSpace):
3510         * platform/StringImpl.cpp:
3511         (WebCore::isSpace):
3512         (WebCore::parseLength):
3513         (WebCore::StringImpl::stripWhiteSpace):
3514         (WebCore::StringImpl::simplifyWhiteSpace):
3515         (WebCore::StringImpl::toInt):
3516         * platform/StringImpl.h:
3517         * platform/mac/ClipboardMac.mm:
3518         (WebCore::cocoaTypeFromMIMEType):
3519         * rendering/RenderPartObject.cpp:
3520         (WebCore::RenderPartObject::updateWidget):
3521         * xml/XPathFunctions.cpp:
3522         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
3523         * xml/XPathGrammar.y:
3524         * xml/XPathStep.cpp:
3525         (WebCore::XPath::Step::nodeTestMatches):
3526         * xml/XSLStyleSheet.cpp:
3527         (WebCore::XSLStyleSheet::loadChildSheets):
3528         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
3529         * xml/XSLTProcessor.cpp:
3530         (WebCore::xsltParamArrayFromParameterMap):
3531         (WebCore::XSLTProcessor::setParameter):
3532         (WebCore::XSLTProcessor::getParameter):
3533         (WebCore::XSLTProcessor::removeParameter):
3534         * xml/XSLTProcessor.h:
3535         * xml/xmlhttprequest.cpp:
3536         (WebCore::XMLHttpRequest::getStatusText):
3537
3538 2006-09-17  David Hyatt  <hyatt@apple.com>
3539
3540         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
3541         are declared right before the fieldsets.  It turns out fieldsets in other
3542         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
3543         adding that behavior to fieldset fixes the bug.
3544
3545         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
3546         and fieldsets all subclass.
3547
3548         Reviewed by anders
3549
3550         Added fast/forms/float-before-fieldset.html
3551
3552         * rendering/RenderFieldset.h:
3553         (WebCore::RenderFieldset::avoidsFloats):
3554         * rendering/RenderFlexibleBox.h:
3555         (WebCore::RenderFlexibleBox::avoidsFloats):
3556         * rendering/RenderObject.cpp:
3557         (WebCore::RenderObject::avoidsFloats):
3558         * rendering/RenderObject.h:
3559         * rendering/RenderTable.h:
3560         (WebCore::RenderTable::avoidsFloats):
3561
3562 2006-09-17  David Hyatt  <hyatt@apple.com>
3563
3564         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
3565         "rules" attributes on tables.
3566
3567         Reviewed by bradee-oh
3568
3569         Well-covered by existing layout tests.
3570
3571         * html/HTMLTableCellElement.cpp:
3572         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
3573         * html/HTMLTableColElement.cpp:
3574         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
3575         * html/HTMLTableColElement.h:
3576         * html/HTMLTableElement.cpp:
3577         (WebCore::HTMLTableElement::HTMLTableElement):
3578         (WebCore::HTMLTableElement::~HTMLTableElement):
3579         (WebCore::HTMLTableElement::setCaption):
3580         (WebCore::HTMLTableElement::setTHead):
3581         (WebCore::HTMLTableElement::setTFoot):
3582         (WebCore::HTMLTableElement::setTBody):
3583         (WebCore::HTMLTableElement::createTHead):
3584         (WebCore::HTMLTableElement::deleteTHead):
3585         (WebCore::HTMLTableElement::createTFoot):
3586         (WebCore::HTMLTableElement::deleteTFoot):
3587         (WebCore::HTMLTableElement::createCaption):
3588         (WebCore::HTMLTableElement::deleteCaption):
3589         (WebCore::HTMLTableElement::insertRow):
3590         (WebCore::HTMLTableElement::deleteRow):
3591         (WebCore::HTMLTableElement::addChild):
3592         (WebCore::HTMLTableElement::childrenChanged):
3593         (WebCore::HTMLTableElement::mapToEntry):
3594         (WebCore::HTMLTableElement::parseMappedAttribute):
3595         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
3596         (WebCore::HTMLTableElement::getSharedCellDecl):
3597         (WebCore::HTMLTableElement::getSharedGroupDecl):
3598         (WebCore::HTMLTableElement::attach):
3599         * html/HTMLTableElement.h:
3600         (WebCore::HTMLTableElement::caption):
3601         (WebCore::HTMLTableElement::tHead):
3602         (WebCore::HTMLTableElement::tFoot):
3603         (WebCore::HTMLTableElement::):
3604         * html/HTMLTableRowElement.h:
3605         * html/HTMLTableSectionElement.cpp:
3606         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
3607         * html/HTMLTableSectionElement.h:
3608
3609 2006-09-17  David Hyatt  <hyatt@apple.com>
3610
3611         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
3612         specify their own new font-family list.  Make sure to always
3613         reset the generic family along with the family list when mapping in
3614         new font-family values.
3615
3616         Reviewed by bradee-oh
3617
3618         fast/text/basic/generic-family-reset.html
3619
3620         * css/cssstyleselector.cpp:
3621         (WebCore::CSSStyleSelector::applyProperty):
3622
3623 2006-09-16  Brady Eidson <beidson@apple.com>
3624
3625         Reviewed by Hyatt
3626
3627         Pruning code relating to WebKit's icon loader
3628
3629         * bridge/mac/WebCoreIconDatabaseBridge.h:
3630         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3631         * loader/icon/IconDatabase.h:
3632         * page/Frame.cpp:
3633         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to 
3634         its new home
3635
3636 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3637
3638         Reviewed by Tim H.
3639
3640         Patch for http://bugs.webkit.org/show_bug.cgi?id=10885
3641         Auto-generate DOMHTMLDocument for the Objective-C bindings
3642
3643         * DerivedSources.make:
3644         * WebCore.xcodeproj/project.pbxproj:
3645         * bindings/objc/DOMExtensions.h:
3646         * bindings/objc/DOMHTML.mm:
3647         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
3648         * bindings/objc/DOMHTMLDocument.h: Removed.
3649         * bindings/objc/DOMHTMLDocument.mm: Removed.
3650         * bindings/objc/PublicDOMInterfaces.h:
3651         * bindings/scripts/CodeGeneratorObjC.pm:
3652         * html/HTMLDocument.idl:
3653         * platform/DeprecatedString.h:
3654         (WebCore::DeprecatedString::operator NSString*):
3655
3656 2006-09-16  Rob Buis  <buis@kde.org>
3657
3658         Reviewed by Eric.
3659
3660         http://bugs.webkit.org/show_bug.cgi?id=10866
3661         Code in kcanvas/ should not use Private
3662
3663         Remove Private classes and tweak coding style.
3664
3665         WARNING: NO TEST CASES ADDED OR CHANGED
3666
3667         * kcanvas/RenderPath.cpp:
3668         (WebCore::RenderPath::RenderPath):
3669         (WebCore::RenderPath::~RenderPath):
3670         (WebCore::RenderPath::localTransform):
3671         (WebCore::RenderPath::setLocalTransform):
3672         (WebCore::RenderPath::fillContains):
3673         (WebCore::RenderPath::relativeBBox):
3674         (WebCore::RenderPath::setPath):
3675         (WebCore::RenderPath::path):
3676         (WebCore::RenderPath::layout):
3677         * kcanvas/RenderPath.h:
3678         * kcanvas/RenderSVGContainer.cpp:
3679         (WebCore::RenderSVGContainer::RenderSVGContainer):
3680         (WebCore::RenderSVGContainer::~RenderSVGContainer):
3681         (WebCore::RenderSVGContainer::drawsContents):
3682         (WebCore::RenderSVGContainer::setDrawsContents):
3683         (WebCore::RenderSVGContainer::localTransform):
3684         (WebCore::RenderSVGContainer::setLocalTransform):
3685         (WebCore::RenderSVGContainer::layout):
3686         (WebCore::RenderSVGContainer::paint):
3687         (WebCore::RenderSVGContainer::setViewport):
3688         (WebCore::RenderSVGContainer::viewport):
3689         (WebCore::RenderSVGContainer::setViewBox):
3690         (WebCore::RenderSVGContainer::viewBox):
3691         (WebCore::RenderSVGContainer::setAlign):
3692         (WebCore::RenderSVGContainer::align):
3693         (WebCore::RenderSVGContainer::fillContains):
3694         (WebCore::RenderSVGContainer::strokeContains):
3695         (WebCore::RenderSVGContainer::setSlice):
3696         (WebCore::RenderSVGContainer::slice):
3697         * kcanvas/RenderSVGContainer.h:
3698         * kcanvas/device/KRenderingFillPainter.cpp:
3699         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
3700         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
3701         (WebCore::KRenderingFillPainter::fillRule):
3702         (WebCore::KRenderingFillPainter::setFillRule):
3703         (WebCore::KRenderingFillPainter::opacity):
3704         (WebCore::KRenderingFillPainter::setOpacity):
3705         * kcanvas/device/KRenderingFillPainter.h:
3706         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3707         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
3708         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
3709         (WebCore::KRenderingPaintServerGradient::gradientStops):
3710         (WebCore::KRenderingPaintServerGradient::setGradientStops):
3711         (WebCore::KRenderingPaintServerGradient::spreadMethod):
3712         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
3713         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
3714         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
3715         (WebCore::KRenderingPaintServerGradient::gradientTransform):
3716         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
3717         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
3718         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
3719         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
3720         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
3721         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
3722         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
3723         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
3724         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
3725         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
3726         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
3727         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
3728         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
3729         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
3730         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
3731         (WebCore::KRenderingPaintServerGradient::listener):
3732         (WebCore::KRenderingPaintServerGradient::setListener):
3733         * kcanvas/device/KRenderingPaintServerGradient.h:
3734         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3735         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3736         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3737         (WebCore::KRenderingPaintServerPattern::setBbox):
3738         (WebCore::KRenderingPaintServerPattern::bbox):
3739         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
3740         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
3741         (WebCore::KRenderingPaintServerPattern::tile):
3742         (WebCore::KRenderingPaintServerPattern::setTile):
3743         (WebCore::KRenderingPaintServerPattern::patternTransform):
3744         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
3745         (WebCore::KRenderingPaintServerPattern::listener):
3746         (WebCore::KRenderingPaintServerPattern::setListener):
3747         * kcanvas/device/KRenderingPaintServerPattern.h:
3748         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3749         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
3750         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
3751         (WebCore::KRenderingPaintServerSolid::color):
3752         (WebCore::KRenderingPaintServerSolid::setColor):
3753         * kcanvas/device/KRenderingPaintServerSolid.h:
3754         * kcanvas/device/KRenderingStrokePainter.cpp:
3755         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
3756         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
3757         (WebCore::KRenderingStrokePainter::strokeWidth):
3758         (WebCore::KRenderingStrokePainter::setStrokeWidth):
3759         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3760         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3761         (WebCore::KRenderingStrokePainter::strokeCapStyle):
3762         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
3763         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
3764         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
3765         (WebCore::KRenderingStrokePainter::dashOffset):
3766         (WebCore::KRenderingStrokePainter::setDashOffset):
3767         (WebCore::KRenderingStrokePainter::dashArray):
3768         (WebCore::KRenderingStrokePainter::setDashArray):
3769         (WebCore::KRenderingStrokePainter::opacity):
3770         (WebCore::KRenderingStrokePainter::setOpacity):
3771         (WebCore::KRenderingStrokePainter::dirty):
3772         (WebCore::KRenderingStrokePainter::setDirty):
3773         * kcanvas/device/KRenderingStrokePainter.h:
3774
3775 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
3776
3777         Reviewed by Anders.
3778
3779         http://bugs.webkit.org/show_bug.cgi?id=10887
3780         Fix build error
3781
3782         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
3783
3784 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3785
3786         Reviewed by Anders.
3787
3788         Fix for http://bugs.webkit.org/show_bug.cgi?id=10886
3789         REGRESSION (r16387): Reproducible crash when mousing over HTML document
3790
3791         - Special case method [DOMNode ownerDocument] to call document() instead
3792           or ownerDocument() to return to the old behavior. 
3793
3794         * WebCore.xcodeproj/project.pbxproj:
3795         * bindings/scripts/CodeGeneratorObjC.pm:
3796
3797 2006-09-15  Brady Eidson  <beidson@apple.com>
3798
3799         Reviewed by Tim Hatcher
3800
3801         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
3802         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
3803
3804         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
3805         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
3806         (WebCore::IconDatabase::open): Make sure the directory exists
3807
3808 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3809
3810         Reviewed by Brady.
3811
3812         Make new style ObjC methods public API.
3813
3814         * WebCore.xcodeproj/project.pbxproj:
3815         * bindings/objc/DOMPrivate.h:
3816         * bindings/objc/PublicDOMInterfaces.h:
3817
3818 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3819
3820         Reviewed by Tim H.
3821
3822         Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
3823         Auto-generate DOMNode for the Objective-C bindings
3824
3825         * DerivedSources.make:
3826         * WebCore.xcodeproj/project.pbxproj:
3827         * bindings/objc/DOM.mm:
3828         (-[DOMNode boundingBox]):
3829         (-[DOMNode lineBoxRects]):
3830         * bindings/objc/DOMEvents.h:
3831         * bindings/objc/DOMExtensions.h:
3832         * bindings/objc/DOMNode.h: Removed.
3833         * bindings/objc/DOMNode.mm: Removed.
3834         * bindings/objc/PublicDOMInterfaces.h:
3835         * bindings/scripts/CodeGeneratorObjC.pm:
3836         * dom/Node.idl:
3837
3838 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3839
3840         Reviewed by Justin.
3841
3842         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
3843
3844         * bridge/mac/WebCoreFrameBridge.h:
3845         * bridge/mac/WebCoreFrameBridge.mm:
3846         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
3847         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
3848         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
3849         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
3850         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
3851         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
3852         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3853         (-[WebCoreFrameBridge increaseSelectionListLevel]):
3854         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
3855         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
3856         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
3857         (-[WebCoreFrameBridge insertLineBreak]):
3858         (-[WebCoreFrameBridge insertParagraphSeparator]):
3859         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
3860         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
3861         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
3862         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
3863         (createMouseEventFromDraggingInfo):
3864         * editing/SelectionController.cpp:
3865         (WebCore::SelectionController::moveTo):
3866         (WebCore::SelectionController::setSelection):
3867         (WebCore::SelectionController::modify):
3868         (WebCore::SelectionController::setBase):
3869         (WebCore::SelectionController::setExtent):
3870         * editing/SelectionController.h:
3871         * page/Frame.cpp:
3872         (WebCore::Frame::revealSelection):
3873         (WebCore::Frame::revealCaret):
3874         * page/Frame.h:
3875
3876 2006-09-15  Brady Eidson  <beidson@apple.com>
3877
3878         Reviewed by Anders
3879
3880         Added the ability to get a mutable char* from a CString, which will copy the internal
3881         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
3882         referrer of that buffer.
3883
3884         * platform/CString.cpp:
3885         (WebCore::CString::mutableData):
3886         (WebCore::CString::copyBufferIfNeeded):
3887         * platform/CString.h:
3888
3889 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
3890
3891         Reviewed by harrison
3892         
3893         <rdar://problem/4674869>
3894         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
3895
3896         * editing/SelectionController.cpp:
3897         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
3898         * editing/visible_units.cpp:
3899         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
3900         position before it, not after it.
3901
3902 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3903
3904         Reviewed by Adam.
3905
3906         http://bugs.webkit.org/show_bug.cgi?id=10864
3907         Bug 10864: Linux\GDK build fixes
3908
3909         * Projects/gdk/webcore-gdk.bkl:
3910         * WebCoreSources.bkl:
3911         * platform/gdk/FontCacheGdk.cpp:
3912         * platform/gdk/FontDataGdk.cpp:
3913         (WebCore::FontData::platformInit):
3914         * platform/gdk/FontGdk.cpp:
3915         (WebCore::Font::drawGlyphs):
3916         * platform/gdk/FrameGdk.cpp:
3917         (WebCore::FrameGdk::handleGdkEvent):
3918         * platform/gdk/FrameGdk.h:
3919         * platform/gdk/ImageGdk.cpp: Added.
3920         (WebCore::Image::initPlatformData):
3921         (WebCore::Image::invalidatePlatformData):
3922         (WebCore::Image::loadPlatformResource):
3923         (WebCore::Image::supportsType):
3924         * platform/gdk/RenderPopupMenuGdk.cpp:
3925         (WebCore::RenderPopupMenuGdk::hidePopup):
3926         * platform/gdk/RenderPopupMenuGdk.h:
3927         * platform/gdk/ScreenGdk.cpp:
3928         (WebCore::drawableForPage):
3929         (WebCore::screenRect):
3930         (WebCore::screenDepth):
3931         (WebCore::usableScreenRect):
3932         (WebCore::scaleFactor):
3933         * platform/gdk/SystemTimeLinux.cpp:
3934         (WebCore::currentTime):
3935         * platform/gdk/TemporaryLinkStubs.cpp:
3936         (FrameGdk::bindingRootObject):
3937         (FrameGdk::markMisspellings):
3938         (WebCore::screenDepthPerComponent):
3939         (WebCore::screenIsMonochrome):
3940         (WebCore::fileButtonChooseFileLabel):
3941         (WebCore::fileButtonNoFileSelectedLabel):
3942         (FrameGdk::shouldChangeSelection):
3943         (FrameGdk::respondToChangedSelection):
3944         (FrameGdk::respondToChangedContents):
3945         (Path::contains):
3946         (PlatformScrollBar::PlatformScrollBar):
3947         (PlatformScrollBar::~PlatformScrollBar):
3948         (PlatformScrollBar::width):
3949         (PlatformScrollBar::height):
3950         (PlatformScrollBar::setEnabled):
3951         (PlatformScrollBar::paint):
3952         (PlatformScrollBar::setScrollBarValue):
3953         (PlatformScrollBar::setKnobProportion):
3954         (PlatformScrollBar::setRect):
3955         (ScrollBar::ScrollBar):
3956         (FileChooser::FileChooser):
3957         (FileChooser::~FileChooser):
3958         (FileChooser::openFileChooser):
3959         (FileChooser::basenameForWidth):
3960         (FileChooser::uploadControlDetaching):
3961         (FileChooser::chooseFile):
3962         (Icon::Icon):
3963         (Icon::~Icon):
3964         (Icon::newIconForFile):
3965         (Icon::paint):
3966         (IconLoader::stopLoading):
3967         (IconLoader::startLoading):
3968         (IconLoader::createForFrame):
3969         (IconDatabase::isIconExpiredForIconURL):
3970         (IconDatabase::hasEntryForIconURL):
3971         (IconDatabase::sharedIconDatabase):
3972         * platform/gdk/WidgetGdk.cpp:
3973         * webcore-base.bkl:
3974
3975 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3976
3977         Reviewed by Eric.
3978
3979         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10835
3980         Fix svg memory leaks.
3981
3982         Reworked SVGList to deal with RefPtr's for ptr types
3983         which makes manual refcounting unnecessary, and is much safer.
3984
3985         Removing all virtual functions (nullItem) from SVGList, and
3986         also remove SVGListBase. Switch to a similar concept like
3987         Vector/VectorTraits (see new file SVGListTraits.h).
3988
3989         Credits go to Eric/Maciej for the inspiration.
3990
3991         * CMakeLists.txt: Add SVGListTraits.cpp to build
3992         * WebCore.xcodeproj/project.pbxproj: Ditto.
3993         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
3994         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
3995         (WebCore::RenderSVGText::translationForAttributes):
3996         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
3997         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3998         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
3999         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
4000         * ksvg2/svg/SVGElementInstanceList.h:
4001         * ksvg2/svg/SVGLengthList.cpp: Ditto.
4002         (WebCore::SVGLengthList::SVGLengthList):
4003         * ksvg2/svg/SVGLengthList.h: Ditto.
4004         * ksvg2/svg/SVGList.h: Rewrote, as described above.
4005         (WebCore::SVGListTypeOperations::nullItem):
4006         (WebCore::SVGList::SVGList):
4007         (WebCore::SVGList::~SVGList):
4008         (WebCore::SVGList::clear):
4009         (WebCore::SVGList::getFirst):
4010         (WebCore::SVGList::getLast):
4011         (WebCore::SVGList::getItem):
4012         (WebCore::SVGList::replaceItem):
4013         (WebCore::SVGList::removeItem):
4014         * ksvg2/svg/SVGListTraits.cpp: Added.
4015         * ksvg2/svg/SVGListTraits.h: Added.
4016         (WebCore::):
4017         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
4018         (WebCore::SVGPathElement::toPathData):
4019         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
4020         (WebCore::SVGPathSegList::SVGPathSegList):
4021         * ksvg2/svg/SVGPathSegList.h: Ditto.
4022         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
4023         (SVGTransform::SVGTransform):
4024         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
4025         (SVGTransformList::SVGTransformList):
4026         (SVGTransformList::createSVGTransformFromMatrix):
4027         (SVGTransformList::consolidate):
4028         * ksvg2/svg/SVGTransformList.h: Ditto.
4029         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
4030         (SVGTransformable::parseTransformAttribute):
4031
4032 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
4033
4034         Reviewed by eseidel.  Landed by eseidel.
4035
4036         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
4037         be able to see javascript errors for instance.
4038
4039         * CMakeLists.txt:
4040         * platform/qt/FrameQt.h:
4041         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
4042         (WebCore::FrameQt::bindingRootObject):
4043         * platform/qt/TemporaryLinkStubs.cp
4044         (WebCore::IconDatabase::hasEntryForIconURL):
4045         (WebCore::IconDatabase::sharedIconDatabase):
4046
4047 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
4048
4049         Reviewed by Tim H.
4050
4051         Patch for http://bugs.webkit.org/show_bug.cgi?id=10869
4052         Auto-generate the internal methods for the Objective-C bindings
4053
4054         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
4055           implementations where standard.  For cases where a custom implementation was
4056           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
4057
4058         - Some general cleanup of some of the non-generated bindings, to bring them in-
4059           line with what the generated bindings look like.
4060
4061         * bindings/objc/DOM.mm:
4062         (-[DOMNode description]):
4063         * bindings/objc/DOMCSS.mm:
4064         (-[DOMCSSPrimitiveValue WebCore::]):
4065         (-[DOMDocument getComputedStyle::]):
4066         (-[DOMDocument getMatchedCSSRules::]):
4067         * bindings/objc/DOMEvents.mm:
4068         (-[DOMEvent WebCore::]):
4069         * bindings/objc/DOMHTML.mm:
4070         * bindings/objc/DOMHTMLDocument.mm:
4071         (-[DOMHTMLDocument title]):
4072         (-[DOMHTMLDocument setTitle:]):
4073         (-[DOMHTMLDocument referrer]):
4074         (-[DOMHTMLDocument domain]):
4075         (-[DOMHTMLDocument URL]):
4076         (-[DOMHTMLDocument body]):
4077         (-[DOMHTMLDocument setBody:]):
4078         (-[DOMHTMLDocument images]):
4079         (-[DOMHTMLDocument applets]):
4080         (-[DOMHTMLDocument links]):
4081         (-[DOMHTMLDocument forms]):
4082         (-[DOMHTMLDocument anchors]):
4083         (-[DOMHTMLDocument cookie]):
4084         (-[DOMHTMLDocument setCookie:]):
4085         (-[DOMHTMLDocument open]):
4086         (-[DOMHTMLDocument close]):
4087         (-[DOMHTMLDocument write:]):
4088         (-[DOMHTMLDocument writeln:]):
4089         (-[DOMHTMLDocument getElementById:]):
4090         (-[DOMHTMLDocument getElementsByName:]):
4091         (-[DOMHTMLDocument WebCore::]):
4092         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
4093         * bindings/objc/DOMHTMLOptionElement.mm:
4094         (-[DOMHTMLOptionElement form]):
4095         (-[DOMHTMLOptionElement defaultSelected]):
4096         (-[DOMHTMLOptionElement setDefaultSelected:]):
4097         (-[DOMHTMLOptionElement text]):
4098         (-[DOMHTMLOptionElement index]):
4099         (-[DOMHTMLOptionElement disabled]):
4100         (-[DOMHTMLOptionElement setDisabled:]):
4101         (-[DOMHTMLOptionElement label]):
4102         (-[DOMHTMLOptionElement setLabel:]):
4103         (-[DOMHTMLOptionElement selected]):
4104         (-[DOMHTMLOptionElement setSelected:]):
4105         (-[DOMHTMLOptionElement value]):
4106         (-[DOMHTMLOptionElement setValue:]):
4107         (-[DOMHTMLOptionElement WebCore::]):
4108         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
4109         * bindings/objc/DOMInternal.h:
4110         * bindings/objc/DOMNode.mm:
4111         (-[DOMNode dealloc]):
4112         (-[DOMNode finalize]):
4113         (-[DOMNode nodeName]):
4114         (-[DOMNode nodeValue]):
4115         (-[DOMNode setNodeValue:]):
4116         (-[DOMNode nodeType]):
4117         (-[DOMNode parentNode]):
4118         (-[DOMNode childNodes]):
4119         (-[DOMNode firstChild]):
4120         (-[DOMNode lastChild]):
4121         (-[DOMNode previousSibling]):
4122         (-[DOMNode nextSibling]):
4123         (-[DOMNode attributes]):
4124         (-[DOMNode ownerDocument]):
4125         (-[DOMNode insertBefore::]):
4126         (-[DOMNode replaceChild::]):
4127         (-[DOMNode removeChild:]):
4128         (-[DOMNode appendChild:]):
4129         (-[DOMNode hasChildNodes]):
4130         (-[DOMNode cloneNode:]):
4131         (-[DOMNode normalize]):
4132         (-[DOMNode isSupported::]):
4133         (-[DOMNode namespaceURI]):
4134         (-[DOMNode prefix]):
4135         (-[DOMNode setPrefix:]):
4136         (-[DOMNode localName]):
4137         (-[DOMNode hasAttributes]):
4138         (-[DOMNode isSameNode:]):
4139         (-[DOMNode isEqualNode:]):
4140         (-[DOMNode isDefaultNamespace:]):
4141         (-[DOMNode lookupPrefix:]):
4142         (-[DOMNode lookupNamespaceURI:]):
4143         (-[DOMNode textContent]):
4144         (-[DOMNode setTextContent:]):
4145         (-[DOMNode boundingBox]):
4146         (-[DOMNode lineBoxRects]):
4147         * bindings/objc/DOMObject.mm:
4148         (-[DOMObject _init]):
4149         * bindings/objc/DOMXPath.mm:
4150         (-[DOMNativeXPathNSResolver dealloc]):
4151         (-[DOMNativeXPathNSResolver finalize]):
4152         (-[DOMNativeXPathNSResolver WebCore::]):
4153         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
4154         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
4155         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
4156         * bindings/scripts/CodeGeneratorObjC.pm:
4157         * bridge/mac/WebCoreFrameBridge.mm:
4158         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
4159         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
4160         * css/CSSCharsetRule.idl:
4161         * css/CSSFontFaceRule.idl:
4162         * css/CSSImportRule.idl:
4163         * css/CSSMediaRule.idl:
4164         * css/CSSPageRule.idl:
4165         * css/CSSPrimitiveValue.idl:
4166         * css/CSSRule.idl:
4167         * css/CSSStyleRule.idl:
4168         * css/CSSStyleSheet.idl:
4169         * css/CSSUnknownRule.idl:
4170         * css/CSSValue.idl:
4171         * css/CSSValueList.idl:
4172         * css/StyleSheet.idl:
4173         * dom/Event.idl:
4174         * dom/KeyboardEvent.idl:
4175         * dom/MouseEvent.idl:
4176         * dom/MutationEvent.idl:
4177         * dom/NodeIterator.idl:
4178         * dom/OverflowEvent.idl:
4179         * dom/TreeWalker.idl:
4180         * dom/UIEvent.idl:
4181         * dom/WheelEvent.idl:
4182
4183 2006-09-15  Adam Roben  <aroben@apple.com>
4184
4185         Reviewed by timothy.
4186
4187         Fixes http://bugs.webkit.org/show_bug.cgi?id=10865
4188         New file upload control should match the width of the old one
4189
4190         Make width of new file upload control match the old one as closely as
4191         possible.
4192
4193         * rendering/RenderFileUploadControl.cpp:
4194
4195 2006-09-15  Timothy Hatcher  <timothy@apple.com>
4196
4197         Reviewed by Eric.
4198
4199         Remove the SVG IDL files from the Copy Resources phase.
4200
4201         * WebCore.xcodeproj/project.pbxproj:
4202
4203 2006-09-15  Brady Eidson  <beidson@apple.com>
4204
4205         Reviewed by Eric Siedel
4206
4207         Dumped the use of CGColorRef and directly use the floating point data from
4208         WebCore::Color
4209
4210         This fixes the performance regression found between 16285 and 16286
4211
4212         * platform/mac/FontMac.mm:
4213         (WebCore::Font::drawComplexText):
4214         (WebCore::Font::drawGlyphs):
4215
4216 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
4217
4218         Reviewed by Adam.
4219
4220         http://bugs.webkit.org/show_bug.cgi?id=10838
4221         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
4222
4223         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
4224         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
4225         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
4226
4227         * bridge/mac/FrameMac.mm:
4228         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
4229         will be called from Frame::clear
4230         * page/Frame.cpp:
4231         (WebCore::Frame::~Frame): Use cancelAndClear.
4232         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
4233         FrameMac can use.
4234         * page/Frame.h:
4235
4236 2006-09-14  Brady Eidson  <beidson@apple.com>
4237
4238         Reviewed by Maciej's rubber stamp
4239
4240         Exact same fix I just made, but in the other method I horked up
4241         Also added a reference to the bugzilla in comments
4242
4243         * page/Frame.cpp:
4244         (WebCore::Frame::endIfNotLoading):
4245         (WebCore::Frame::stop):
4246
4247 2006-09-14  Brady Eidson  <beidson@apple.com>
4248
4249         Reviewed by Maciej
4250
4251         Fixed a bad iFrame crash, resolving some of the layout test badness
4252
4253         * page/Frame.cpp:
4254         (WebCore::Frame::endIfNotLoading):
4255         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
4256
4257 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
4258
4259         Reviewed by harrison
4260         
4261         <rdar://problem/4655880> Up/Down arrows skip over To Do
4262
4263         * bridge/mac/WebCoreFrameBridge.mm:
4264         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
4265         * dom/Node.cpp: Removed the unused inSameRootEditableElement.