2009-03-04 Simon Fraser <simon.fraser@apple.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-04  Adam Langley  <agl@google.com>
2
3         Reviewed by Darin Fisher.
4
5         r41362 mistakenly added functions "RenderThemeWin::" into
6         RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
7         them to void return types. This patch switches them back to ints.
8
9         https://bugs.webkit.org/show_bug.cgi?id=24360
10
11         * rendering/RenderThemeChromiumLinux.cpp:
12         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft):
13         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight):
14         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop):
15         (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
16
17 2009-03-04  Adam Langley  <agl@google.com>
18
19         Reviewed by Darin Fisher.
20
21         Chromium Linux: change some metrics to better match Windows after
22         r41416. Aesthetically this may be worse, but web-compat is king.
23
24         Also, the previous code had an off by one error when drawing
25         scrollbars which caused the scrollbar to overflow it's bounds by 1px
26         at the right and bottom edges.
27
28         https://bugs.webkit.org/show_bug.cgi?id=24369
29
30         * rendering/RenderThemeChromiumLinux.cpp:
31         (WebCore::):
32         (WebCore::RenderThemeChromiumLinux::systemFont):
33         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
34         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
35
36 2009-03-04  Eric Seidel  <eric@webkit.org>
37
38         Reviewed by Adam Roben.
39
40         Add an ASSERT to better demonstrate the cause of the crash in
41         https://bugs.webkit.org/show_bug.cgi?id=23736
42
43         * loader/DocLoader.cpp:
44         (WebCore::DocLoader::~DocLoader):
45
46 2009-03-04  David Levin  <levin@chromium.org>
47
48         Reviewed by Alexey Proskuryakov.
49
50         Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
51         <https://bugs.webkit.org/show_bug.cgi?id=24337>
52
53         Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
54                http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
55
56         * loader/mac/ResourceLoaderMac.mm:
57         (WebCore::ResourceLoader::willCacheResponse):
58         An identifier is only asssigned if resource load callbacks are done.  So don't send
59         willCacheResponse which uses identifier if resource load callbacks aren't being sent.
60
61 2009-03-04  David Levin  <levin@chromium.org>
62
63         Reviewed by Alexey Proskuryakov.
64
65         Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
66         <https://bugs.webkit.org/show_bug.cgi?id=24330>
67
68         Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
69
70         * dom/ExceptionCode.cpp:
71         (WebCore::xmlHttpRequestExceptionNames):
72         Added missing ABORT_ERR whose absence caused an assert.
73
74         * loader/WorkerThreadableLoader.cpp:
75         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
76         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
77         Add more logic to handle the termination case for sync xhr.
78
79 2009-03-04  Eric Carlson  <eric.carlson@apple.com>
80
81         Reviewed by Antti Koivisto.
82
83         https://bugs.webkit.org/show_bug.cgi?id=24364
84         Add support for HTMLMediaElement canPlayType method. Make
85         MediaPlayer::supportsType take a ContentType instead of a
86         separate mime type and codecs parameter.
87
88         Test: media/video-can-play-type.html
89
90         * dom/DOMImplementation.cpp:
91         (WebCore::DOMImplementation::createDocument):
92         * html/HTMLMediaElement.cpp:
93         (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method.
94         (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType.
95         (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type.
96         (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
97         * html/HTMLMediaElement.h: Add prototype.
98         * html/HTMLMediaElement.idl: Ditto.
99         * platform/graphics/MediaPlayer.cpp:
100         (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type.
101         (WebCore::MediaPlayer::supportsType): Ditto.
102         * platform/graphics/MediaPlayer.h:
103
104 2009-03-04  Antti Koivisto  <antti@apple.com>
105
106         Reviewed by Dave Hyatt.
107
108         https://bugs.webkit.org/show_bug.cgi?id=24359
109         Repaint throttling mechanism
110         
111         Excessive repainting can slow down page loadind. This implements a timer
112         based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
113         enabled by default.
114
115         * loader/FrameLoader.cpp:
116         (WebCore::FrameLoader::checkCompleted):
117         * page/EventHandler.cpp:
118         (WebCore::EventHandler::dispatchDragEvent):
119         (WebCore::EventHandler::dispatchMouseEvent):
120         (WebCore::EventHandler::keyEvent):
121         (WebCore::EventHandler::handleTextInputEvent):
122         * page/FrameView.cpp:
123         (WebCore::FrameView::FrameView):
124         (WebCore::FrameView::reset):
125         (WebCore::FrameView::repaintContentRectangle):
126         (WebCore::FrameView::beginDeferredRepaints):
127         (WebCore::FrameView::endDeferredRepaints):
128         (WebCore::FrameView::checkStopDelayingDeferredRepaints):
129         (WebCore::FrameView::doDeferredRepaints):
130         (WebCore::FrameView::updateDeferredRepaintDelay):
131         (WebCore::FrameView::resetDeferredRepaintDelay):
132         (WebCore::FrameView::adjustedDeferredRepaintDelay):
133         (WebCore::FrameView::deferredRepaintTimerFired):
134         (WebCore::FrameView::paintContents):
135         * page/FrameView.h:
136
137 2009-03-04  Sam Weinig  <sam@webkit.org>
138
139         Rubber-stamped by Antti Koivisto.
140
141         Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
142
143         * dom/Document.cpp:
144         (WebCore::Document::Document):
145         * dom/Document.h:
146         (WebCore::Document::haveStylesheetsLoaded):
147         * html/HTMLTokenizer.cpp:
148         (WebCore::HTMLTokenizer::scriptHandler):
149         * loader/Cache.cpp:
150         (WebCore::Cache::requestResource):
151         * loader/CachedCSSStyleSheet.cpp:
152         (WebCore::CachedCSSStyleSheet::checkNotify):
153         * loader/DocLoader.h:
154         * loader/FrameLoader.cpp:
155         (WebCore::FrameLoader::FrameLoader):
156         (WebCore::FrameLoader::requestFrame):
157         (WebCore::FrameLoader::stopLoading):
158         (WebCore::FrameLoader::begin):
159         (WebCore::FrameLoader::write):
160         (WebCore::FrameLoader::endIfNotLoadingMainResource):
161         (WebCore::FrameLoader::checkCompleted):
162         (WebCore::FrameLoader::requestObject):
163         (WebCore::FrameLoader::loadItem):
164         * loader/FrameLoader.h:
165
166 2009-03-02  Xan Lopez  <xan@gnome.org>
167
168         Reviewed by Mark Rowe.
169
170         https://bugs.webkit.org/show_bug.cgi?id=24287
171         [GTK] Move auth dialog feature to WebKit/
172
173         Remove WebKitSoupAuthDialog files from build and stop using it.
174
175         * GNUmakefile.am:
176         * platform/network/soup/ResourceHandleSoup.cpp:
177         (WebCore::ensureSessionIsInitialized):
178         * platform/network/soup/webkit-soup-auth-dialog.c: Removed.
179         * platform/network/soup/webkit-soup-auth-dialog.h: Removed.
180
181 2009-03-04  Simon Fraser  <simon.fraser@apple.com>
182
183         Reviewed by Dave Hyatt
184         
185         https://bugs.webkit.org/show_bug.cgi?id=24361
186         
187         Reinstate code that sets result.innerNode when hitTest() returns true,
188         but never filled in the innerNode. Fixes hit testing of generated content.
189
190         Test: fast/css-generated-content/hit-test-generated-content.html
191
192         * rendering/RenderLayer.cpp:
193         (WebCore::RenderLayer::hitTestContents):
194
195 2009-03-04  Adam Barth  <abath@webkit.org>
196
197         Reviewed by Alexey Proskuryakov.
198
199         https://bugs.webkit.org/show_bug.cgi?id=24356
200
201         Fix WebKit style for allowUniversalAccessFromFileURLs.
202
203         * WebCore.base.exp:
204         * dom/Document.cpp:
205         (WebCore::Document::initSecurityContext):
206         * page/Settings.cpp:
207         (WebCore::Settings::Settings):
208         (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
209         * page/Settings.h:
210         (WebCore::Settings::allowUniversalAccessFromFileURLs):
211
212 2009-03-04  Brady Eidson  <beidson@apple.com>
213
214         Reviewed by Darin Adler
215
216         <rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
217
218         I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
219         consolidated some of the various decision making pieces of the Cache into the new method
220         FrameLoader::cachePolicy().
221
222         Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader 
223         is reloading.  If it is, we'd evict any existing resource then recreate it.  Quick looks uses the
224         same URL for this image every time and expects it to be reloaded with each new card.
225
226         The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
227         is "ReloadIgnoringCacheData".  This check was lost in the consolidation to the new method.  
228
229         * loader/FrameLoader.cpp:
230         (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible
231           condition for returning CachePolicyReload.
232
233 2009-03-04  Timothy Hatcher  <timothy@apple.com>
234
235         * English.lproj/localizedStrings.js: Update strings to include "DATABASES",
236         "LOCAL STORAGE" and "SESSION STORAGE".
237
238 2009-03-04  Timothy Hatcher  <timothy@apple.com>
239
240         Fix a regression where the Web Inspector console would not animate
241         in or out correctly.
242
243         Reviewed by Anders Carlsson.
244
245         * inspector/front-end/inspector.css: Move a z-index to a child element
246         to get the correct stacking order during the animation.
247
248 2009-03-03  David Hyatt  <hyatt@apple.com>
249
250         https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
251
252         Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
253         the final position against the y position estimate until after the clear has happened.  This gets rid
254         of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
255
256         Reviewed by Dan Bernstein
257
258         Added fast/block/float/nested-clearance.html
259
260         * rendering/RenderBlock.cpp:
261         (WebCore::RenderBlock::collapseMargins):
262         (WebCore::RenderBlock::clearFloatsIfNeeded):
263         (WebCore::RenderBlock::estimateVerticalPosition):
264         (WebCore::RenderBlock::layoutBlockChildren):
265         (WebCore::RenderBlock::getClearDelta):
266         * rendering/RenderBlock.h:
267
268 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
269
270         Reviewed by Simon Hausmann.
271
272         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
273         instead of QMatrix. This allows perspective transformations since QTransform is
274         a true 3x3 matrix.
275
276         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
277         (WebCore::GraphicsContext::getCTM):
278         (WebCore::GraphicsContext::restorePlatformState):
279         (WebCore::GraphicsContext::fillPath):
280         (WebCore::GraphicsContext::strokePath):
281         (WebCore::GraphicsContext::fillRect):
282         (WebCore::GraphicsContext::translate):
283         (WebCore::GraphicsContext::rotate):
284         (WebCore::GraphicsContext::scale):
285         (WebCore::GraphicsContext::concatCTM):
286         * platform/graphics/qt/ImageQt.cpp:
287         (WebCore::Image::drawPattern):
288         * platform/graphics/qt/PathQt.cpp:
289         (WebCore::Path::translate):
290         (WebCore::Path::transform):
291         * platform/graphics/qt/PatternQt.cpp:
292         (WebCore::Pattern::createPlatformPattern):
293         * platform/graphics/qt/TransformationMatrixQt.cpp:
294         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
295         to QMatrix with one to QTransform.
296         * platform/graphics/transforms/TransformationMatrix.h:
297         * platform/graphics/qt/FontQt.cpp:
298
299 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
300
301         Reviewed by Simon Hausmann.
302
303         https://bugs.webkit.org/show_bug.cgi?id=24151
304         Fix Qt/S60 build break
305
306         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
307         * platform/qt/FileSystemQt.cpp: Ditto
308         (WebCore::unloadModule):
309
310 2009-03-03  Mike Belshe  <mike@belshe.com>
311
312         Reviewed by Alexey Proskuryakov.
313
314         https://bugs.webkit.org/show_bug.cgi?id=21939
315         Uninitialized ExceptionCode in DOMWindow::postMessage
316
317         * dom/MessagePort.cpp:
318         (WebCore::MessagePort::postMessage):
319
320 2009-03-03  David Kilzer  <ddkilzer@apple.com>
321
322         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
323
324         Reviewed by Mark Rowe.
325
326         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
327         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
328         sure various build phase scripts work with the installhdrs build
329         phase.
330
331         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
332         based on PLATFORM_NAME to work around the missing definition on
333         Tiger.
334         * Configurations/WebCore.xcconfig: Added
335         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
336         the "Generate Derived Sources" script.  Added
337         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
338
339         * WebCore.xcodeproj/project.pbxproj:
340         - Added shell code to prevent running "Check For Global
341           Initializers", "Check For Exit Time Destructors" and "Check
342           For Weak VTables" scripts during the installhdrs build phase.
343         - Made "Generate Derived Sources" work for the installhdrs build
344           phase.  Also simplified setting of CREATE_HASH_TABLE by using
345           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
346
347 2009-03-02  Adam Langley  <agl@google.com>
348
349         Reviewed by Darin Fisher.
350
351         Chromium Linux: Switch to using Skia to render widgets.
352
353         In order to sandbox the Chromium renderer on Linux we need to remove
354         the X connection. GTK cannot render without an X connection so, for
355         now, we render widgets ourselves.
356
357         Previously didn't use anti-alias fonts in order to match Windows font
358         rendering exactly. This was helpful when bootstrapping our layout
359         tests. Now, however, we are ready to enable it.
360
361         https://bugs.webkit.org/show_bug.cgi?id=24244
362
363         * platform/chromium/ScrollbarThemeChromium.cpp:
364         (WebCore::ScrollbarThemeChromium::buttonSize):
365         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
366         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
367         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
368         (WebCore::ScrollbarThemeChromium::paintButton):
369         (WebCore::ScrollbarThemeChromium::paintThumb):
370         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
371         (WebCore::FontPlatformData::setupPaint):
372         * platform/graphics/skia/PlatformContextSkia.cpp:
373         (PlatformContextSkia::PlatformContextSkia):
374         (PlatformContextSkia::~PlatformContextSkia):
375         * platform/graphics/skia/PlatformContextSkia.h:
376         * rendering/RenderThemeChromiumGtk.cpp: Removed.
377         * rendering/RenderThemeChromiumGtk.h: Removed.
378         * rendering/RenderThemeChromiumLinux.cpp: Added.
379         * rendering/RenderThemeChromiumLinux.h: Added.
380
381 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
382
383         Reviewed by Darin Fisher.
384
385         https://bugs.webkit.org/show_bug.cgi?id=24261
386         Fix return types.
387
388         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
389
390         * bindings/v8/V8Binding.h:
391         (WebCore::toInt32): change return type to int
392         (WebCore::toFloat): change return type to float.
393
394 2009-03-03  Anders Carlsson  <andersca@apple.com>
395
396         Reviewed by John Sullivan.
397
398         https://bugs.webkit.org/show_bug.cgi?id=22884
399         <rdar://problem/6449783>
400         modified layout test crashes Safari
401
402         Null check NPStream before dereferencing it.
403         
404         * plugins/PluginView.cpp:
405         (WebCore::PluginView::destroyStream):
406
407 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
408
409         Reviewed by Simon Fraser.
410
411         Fix for <rdar://problem/6641045>
412         Don't call QTKit to get movie properties until movie metadata has been loaded.
413
414         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
415         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
416         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
417         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
418         (WebCore::MediaPlayerPrivate::play): Ditto.
419         (WebCore::MediaPlayerPrivate::pause): Ditto.
420         (WebCore::MediaPlayerPrivate::duration): Ditto.
421         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
422         (WebCore::MediaPlayerPrivate::seek): Ditto.
423         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
424         (WebCore::MediaPlayerPrivate::paused): Ditto.
425         (WebCore::MediaPlayerPrivate::seeking): Ditto.
426         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
427         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
428         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
429         (WebCore::MediaPlayerPrivate::setRate): Ditto.
430         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
431         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
432         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
433
434 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
435
436         - Spelling fix.
437
438         * page/Console.cpp:
439         (WebCore::Console::profile):
440
441 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
442
443         Reviewed by Darin Fisher.
444
445         https://bugs.webkit.org/show_bug.cgi?id=23657
446         Remove Database API callback IDLs from the project. 
447         They were removed in r40633.
448
449         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
450
451 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
452
453         Reviewed by Oliver Hunt.
454
455         <rdar://problem/6639110> console.profile() doesn't work without a title
456
457         * page/Console.cpp:
458         (WebCore::Console::profile): If there is no title assume this is a user
459         initiated profile and give it the next incremented title name.
460
461 2009-03-03  Timothy Hatcher  <timothy@apple.com>
462
463         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
464         the console code and refactored things to have fewer code paths and duplication.
465
466         rdar://problem/6367127
467         https://bugs.webkit.org/show_bug.cgi?id=24329
468
469         Reviewed by Kevin McCullough.
470
471         Test: manual-tests/inspector/console-dir.html
472
473         * bindings/js/JSInspectedObjectWrapper.cpp:
474         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
475         to fix an ASSERT about using a wrapper from the wrong ExecState.
476         * bindings/js/JSQuarantinedObjectWrapper.cpp:
477         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
478         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
479         * inspector/front-end/Console.js:
480         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
481         When forceObjectFormat is true, the only formatter used is _formatobject.
482         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
483         (WebInspector.Console.prototype._formatstring): Ditto.
484         (WebInspector.Console.prototype._formatregexp): Ditto.
485         (WebInspector.Console.prototype._formatarray): Ditto.
486         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
487         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
488         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
489         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
490         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
491         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
492         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
493         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
494         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
495         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
496         * inspector/front-end/utilities.js:
497         (Object.type): Return "node" for Node objects.
498         (Object.describe): Handle the "node" type.
499         * page/Console.cpp:
500         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
501         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
502         * page/Console.h:
503         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
504
505 2009-03-03  Scott Violet  <sky@google.com>
506
507         Reviewed by Eric Seidel.
508
509         https://bugs.webkit.org/show_bug.cgi?id=24325
510         Crash on replacing document contents during drop.
511
512         Makes sure a node is in the document during a move before using it.
513
514         Test: fast/events/crash-on-mutate-during-drop.html
515
516         * editing/MoveSelectionCommand.cpp:
517         (WebCore::MoveSelectionCommand::doApply):
518
519 2009-03-03  Jungshik Shin <jshin@chromium.org>
520
521         Reviewed by Eric Seidel.
522
523         https://bugs.webkit.org/show_bug.cgi?id=23028
524         Enable dynamic web font support to Chromium on Windows.
525         Files that were omitted by mistake in the latest patch
526         that was landed.
527
528         * loader/CachedFont.cpp:
529         (WebCore::CachedFont::~CachedFont):
530         (WebCore::CachedFont::ensureCustomFontData):
531         (WebCore::CachedFont::platformDataFromCustomData):
532         (WebCore::CachedFont::allClientsRemoved):
533         * platform/graphics/chromium/FontCustomPlatformData.cpp:
534         (WebCore::EOTStream::EOTStream):
535         (WebCore::createFontCustomPlatformData):
536         * platform/graphics/win/FontCustomPlatformData.cpp:
537         (WebCore::EOTStream::EOTStream):
538         (WebCore::createFontCustomPlatformData):
539
540 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
541
542         Reviewed by Alexey Proskuryakov.
543
544         https://bugs.webkit.org/show_bug.cgi?id=16826
545         [Gtk] Implement WebKitDownload
546
547         Make the Soup backend able to handle requests without a frame,
548         since we may have such things now that we support downloads.
549
550         * platform/network/ResourceHandleInternal.h:
551         * platform/network/soup/ResourceHandleSoup.cpp:
552         (WebCore::ResourceHandle::start):
553
554 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
555
556         Reviewed by Eric Seidel.
557
558         https://bugs.webkit.org/show_bug.cgi?id=24331
559         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
560
561         * bindings/v8/custom/V8AttrCustom.cpp: Added.
562         * bindings/v8/custom/V8CustomBinding.cpp: Added.
563         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
564         * bindings/v8/custom/V8ElementCustom.cpp: Added.
565         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
566         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
567
568 2009-03-03  Brady Eidson  <beidson@apple.com>
569
570         Reviewed by Darin Adler
571
572         <rdar://problem/6616664> - Quick looks of various file types is broken
573
574         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
575         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
576         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
577
578         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
579         before that patch.
580
581         * loader/FrameLoader.cpp:
582         (WebCore::FrameLoader::addExtraFieldsToRequest):
583
584         * platform/network/ResourceRequestBase.cpp:
585         (WebCore::ResourceRequestBase::setMainDocumentURL):
586
587 2009-03-03  Chris Marrin  <cmarrin@apple.com>
588
589         Reviewed by Simon Fraser.
590
591         https://bugs.webkit.org/show_bug.cgi?id=24256
592
593         Added a WebCoreForceSoftwareAnimation flag.
594
595         * platform/graphics/mac/GraphicsLayerCA.mm:
596         (WebCore::forceSoftwareAnimation):
597         (WebCore::GraphicsLayerCA::setOpacity):
598         (WebCore::GraphicsLayerCA::animateTransform):
599         (WebCore::GraphicsLayerCA::animateFloat):
600
601 2009-03-02  Chris Marrin  <cmarrin@apple.com>
602
603         Reviewed by Sam Weinig.
604
605         https://bugs.webkit.org/show_bug.cgi?id=24257
606
607         Added prototype properties for several classes with constructors that
608         were missing them, including the one mentioned in the bug.
609
610         Test: fast/dom/Window/custom-constructors.html
611
612         * bindings/js/JSAudioConstructor.cpp:
613         (WebCore::JSAudioConstructor::JSAudioConstructor):
614         * bindings/js/JSDOMWindowBase.cpp:
615         (jsDOMWindowBaseWebKitCSSMatrix):
616         * bindings/js/JSImageConstructor.cpp:
617         (WebCore::JSImageConstructor::JSImageConstructor):
618         * bindings/js/JSOptionConstructor.cpp:
619         (WebCore::JSOptionConstructor::JSOptionConstructor):
620         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
621         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
622         * bindings/js/JSWebKitCSSMatrixConstructor.h:
623         * bindings/js/JSWebKitPointConstructor.cpp:
624         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
625         * bindings/js/JSWorkerConstructor.cpp:
626         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
627
628 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
629
630         Reviewed by Darin Fisher.
631
632         https://bugs.webkit.org/show_bug.cgi?id=24321
633         Add V8 bindings headers.
634
635         * bindings/v8/V8Binding.h: Added.
636         * bindings/v8/V8Proxy.h: Added.
637         * bindings/v8/custom/V8CustomBinding.h: Added.
638         * bindings/v8/custom/V8CustomEventListener.h: Added.
639
640 2009-03-03  Jungshik Shin <jshin@chromium.org>
641
642         Reviewed by Eric Seidel.
643
644         https://bugs.webkit.org/show_bug.cgi?id=23803
645         Fix an 'off-by-1' error in ChromiumWin's font fallback.
646
647         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
648         (WebCore::FontCache::getFontDataForCharacters):
649
650 2009-03-03  Jungshik Shin  <jshin@chromium.org>
651
652         Reviewed by Eric Seidel.
653
654         http://bugs.webkit.org/show_bug.cgi?id=23028
655         Enable dynamic web font support to Chromium on Windows: Part 1
656         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
657           from platform/graphics/win because both Windows port and Chromium Windows
658           port will use them.
659         - Adjust WebCore.vcproj accordingly.
660
661         * WebCore.vcproj/WebCore.vcproj:
662         * platform/graphics/opentype: Added.
663         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
664         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
665         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
666         * platform/graphics/win/OpenTypeUtilities.h: Removed.
667
668 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
669
670         Reviewed by Dave Hyatt
671
672         https://bugs.webkit.org/show_bug.cgi?id=24312
673         
674         Take 3D transforms into account when hit testing:
675         
676         1. Maintain a bit on each RenderLayer that is set when the layer
677            has 3d descendants, so that we know when to fall into the slow
678            hit testing path.
679            
680         2. Make a ref-counted HitTestingTransformState, which is used to store
681            an accumulated transform, and the hit test point, and hitTestRect
682            in the plane of the ancestor non-3d ('flattening') layer.
683            
684            It's ref-counted so we can heap allocate it (to avoid stack bloat),
685            and avoid copying when hitTestLayer calls itself after applying the transform.
686            
687         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
688            3D transforms, or to do deep depth-testing when traversing a preserves-3d
689            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
690            layer, which allows for correct depth testing.
691            
692            The existing early-return codepath is unaffected when there are no 3d transforms
693            and no preserve-3d.
694
695         * rendering/RenderLayer.cpp:
696         (WebCore::RenderLayer::RenderLayer):
697         (WebCore::RenderLayer::updateTransform):
698         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
699         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
700         (WebCore::RenderLayer::hitTest):
701         (WebCore::computeZOffset):
702         (WebCore::RenderLayer::createLocalTransformState):
703         (WebCore::RenderLayer::hitTestLayer):
704         (WebCore::RenderLayer::hitTestContents):
705         * rendering/RenderLayer.h:
706         (WebCore::RenderLayer::preserves3D):
707         (WebCore::RenderLayer::has3DTransform):
708         (WebCore::RenderLayer::setHas3DTransformedDescendant):
709         (WebCore::RenderLayer::has3DTransformedDescendant):
710         * rendering/RenderLayerBacking.cpp:
711         * rendering/TransformState.cpp:
712         (WebCore::TransformState::flatten):
713         (WebCore::TransformState::mappedPoint):
714         (WebCore::HitTestingTransformState::move):
715         (WebCore::HitTestingTransformState::applyTransform):
716         (WebCore::HitTestingTransformState::flatten):
717         (WebCore::HitTestingTransformState::mappedPoint):
718         (WebCore::HitTestingTransformState::mappedQuad):
719         * rendering/TransformState.h:
720         (WebCore::TransformState::TransformState):
721         (WebCore::HitTestingTransformState::create):
722         (WebCore::HitTestingTransformState::move):
723         (WebCore::HitTestingTransformState::HitTestingTransformState):
724
725 2009-03-03  Brett Wilson  <brettw@chromium.org>
726
727         Fix uninitialized memory reads in the Chromium Windows transparency
728         code that were identified by Purify,
729
730         Reviewed by Darin Fisher.
731
732         * platform/graphics/chromium/TransparencyWin.cpp:
733         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
734         (WebCore::TransparencyWin::initializeNewContext):
735
736 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
737
738         Reviewed by Dave Hyatt
739
740         https://bugs.webkit.org/show_bug.cgi?id=24312
741         
742         Factor the code that compute a transform relative to the container
743         into RenderObject::transformFromContainer().
744         
745         * rendering/RenderBox.cpp:
746         (WebCore::RenderBox::mapLocalToAbsolutePoint):
747         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
748         * rendering/RenderObject.cpp:
749         (WebCore::RenderObject::transformFromContainer):
750         * rendering/RenderObject.h:
751
752 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
753
754         Reviewed by Dave Hyatt
755
756         https://bugs.webkit.org/show_bug.cgi?id=24317
757         
758         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
759         the superclass found a node, otherwise we set the innerNode of the
760         HitTestResult, but don't actually report that we found a hit.
761
762         * rendering/RenderTextControlMultiLine.cpp:
763         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
764
765 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
766
767         Reviewed by Anders Carlsson.
768
769         https://bugs.webkit.org/show_bug.cgi?id=23707
770         resizing plugins does not work, because the plugin never gets informed
771
772         Make gtk plugins resize correctly, by sending them the setwindow event
773         correctly. Also ensure that all plugin eventing is done with correct
774         locking/calling. Mostly copied from mac implementation.
775
776         manual test: manual-tests/gtk/plugin-resize-scroll.html
777
778         * plugins/PluginView.h:
779         * plugins/gtk/PluginViewGtk.cpp:
780         (WebCore::PluginView::dispatchNPEvent):
781         ensure locking/calling for NPEvents
782         (WebCore::PluginView::updatePluginWidget):
783         if something changed, let setNPWindowIfNeeded handle it
784         (WebCore::PluginView::paint):
785         (WebCore::PluginView::handleKeyboardEvent):
786         (WebCore::PluginView::handleMouseEvent):
787         ensure calling conventions
788         (WebCore::PluginView::setNPWindowRect):
789         just pass control to setNPWindowIfNeeded
790         (WebCore::PluginView::setNPWindowIfNeeded):
791         event the plugin correctly of new window
792         (WebCore::PluginView::init):
793         init through the new setup
794
795 2009-03-03  Mike Belshe  <mike@belshe.com>
796
797         Reviewed by Darin Fisher.
798
799         https://bugs.webkit.org/show_bug.cgi?id=24311
800         Make IDL returning DOMObject use [V8Custom]
801
802         * dom/Document.idl:
803         * html/HTMLCanvasElement.idl:
804
805 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
806
807         Reviewed by Adele Peterson
808
809         https://bugs.webkit.org/show_bug.cgi?id=24313
810         
811         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
812         HitTestResult, then it had better well return |true|. And m_innerBlock
813         could never have been set as the hit node by the superclass, because
814         the superclass knows nothing about m_innerBlock.
815         
816         Test: fast/forms/input-hit-test-border.html
817
818         * rendering/RenderTextControlSingleLine.cpp:
819         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
820
821 2009-03-02  Sam Weinig  <sam@webkit.org>
822
823         Reviewed by Mark Rowe.
824
825         Enable Geolocation (except on Tiger and Leopard).
826
827         * Configurations/WebCore.xcconfig:
828
829 2009-03-02  Ojan Vafai  <ojan@chromium.org>
830
831         Reviewed by Adele Peterson.
832
833         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
834         Null out m_highlightedNode on hideHighlight().
835         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
836
837         * inspector/InspectorController.cpp:
838         (WebCore::InspectorController::hideHighlight):
839
840 2009-03-02  Sam Weinig  <sam@webkit.org>
841
842         Reviewed by Geoffrey Garen.
843
844         Fix for <rdar://problem/6507404> Add Geolocation support.
845
846         This is not yet turned on for any Mac platform.
847
848         * WebCore.xcodeproj/project.pbxproj:
849         * page/Chrome.cpp:
850         (WebCore::Chrome::shouldAllowGeolocationForFrame):
851         * page/Chrome.h:
852         * page/ChromeClient.h:
853         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
854         * page/Geolocation.cpp:
855         (WebCore::Geolocation::Geolocation):
856         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
857         will not be alive at this point.
858         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
859         return a PERMISSION_DENIED if not.
860         (WebCore::Geolocation::watchPosition): Ditto.
861         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
862         to allow geolocation and cache the result. 
863         * page/Geolocation.h:
864         (WebCore::Geolocation::):
865         * platform/GeolocationService.cpp:
866         * platform/GeolocationService.h:
867         (WebCore::GeolocationService::~GeolocationService):
868         (WebCore::GeolocationService::stopUpdating):
869         * platform/mac/GeolocationServiceMac.h: Added.
870         (WebCore::GeolocationServiceMac::lastPosition):
871         (WebCore::GeolocationServiceMac::lastError):
872         * platform/mac/GeolocationServiceMac.mm: Added.
873         (WebCore::GeolocationService::create):
874         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
875         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
876         (WebCore::GeolocationServiceMac::startUpdating):
877         (WebCore::GeolocationServiceMac::stopUpdating):
878         (WebCore::GeolocationServiceMac::suspend):
879         (WebCore::GeolocationServiceMac::resume):
880         (WebCore::GeolocationServiceMac::positionChanged):
881         (WebCore::GeolocationServiceMac::errorOccurred):
882         (-[WebCoreCoreLocationObserver initWithCallback:]):
883         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
884         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
885
886 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
887
888         Build fixes for wxWidgets Mac trunk build.
889
890         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
891         (wxFontProperties::wxFontProperties):
892         (GetTextExtent):
893         * webcore-wx.bkl:
894
895 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
896
897         wxGTK missing header build fix.
898
899         * platform/wx/wxcode/gtk/fontprops.cpp:
900
901 2009-03-02  Dan Bernstein  <mitz@apple.com>
902
903         Reviewed by Adam Roben.
904
905         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
906           REGRESSION: Windows Build Not Selecting Proper Font
907
908         * platform/graphics/win/FontCacheWin.cpp:
909         (WebCore::createGDIFont): Added back code to verify that the created
910         HFONT has the requested face name.
911
912 2009-03-02  Timothy Hatcher  <timothy@apple.com>
913
914         Fixes a regression caused by splitting the input and output of console commands.
915
916         https://bugs.webkit.org/show_bug.cgi?id=24293
917
918         Reviewed by Kevin McCullough.
919
920         * inspector/front-end/Console.js:
921         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
922         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
923
924 2009-03-02  Timothy Hatcher  <timothy@apple.com>
925
926         Make exception messages and logged Error objects display consistently.
927
928         https://bugs.webkit.org/show_bug.cgi?id=18983
929
930         Reviewed by Adam Roben.
931
932         * English.lproj/localizedStrings.js: Remove a string for line numbers.
933         * inspector/front-end/Console.js:
934         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
935         boolean to the ConsoleCommandResult constructor and don't pass level.
936         (WebInspector.Console.prototype._formatnode): Fix a className typo.
937         (WebInspector.Console.prototype._formaterror): Add an error-message
938         classed span around the message to show in red and remove the
939         console-message-url class from the link so it doesn't float right.
940         Instead enclose the link in parentheses and use displayNameForURL
941         to shorten the URL in the link.
942         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
943         how line numbers are shown since link underlining a string with
944         parentheses looks bad.
945         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
946         instead of a level and get line and URL based on that flag.
947         * inspector/front-end/inspector.css: Tweaks to the styles.
948
949 2009-03-02  Ojan Vafai  <ojan@chromium.org>
950
951         Reviewed by Adele Peterson.
952
953         Bug 24048: extra windows button padding doesn't apply when there's no appearance
954         <https://bugs.webkit.org/show_bug.cgi?id=24048>
955
956         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
957
958         No tests added as existing tests already cover this behavior.
959
960         * rendering/RenderButton.cpp:
961         (WebCore::RenderButton::setupInnerStyle):
962         * rendering/RenderTheme.cpp:
963         * rendering/RenderTheme.h:
964         (WebCore::RenderTheme::buttonInternalPaddingLeft):
965         (WebCore::RenderTheme::buttonInternalPaddingRight):
966         (WebCore::RenderTheme::buttonInternalPaddingTop):
967         * rendering/RenderThemeChromiumGtk.cpp:
968         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
969         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
970         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
971         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
972         * rendering/RenderThemeChromiumGtk.h:
973         * rendering/RenderThemeChromiumWin.cpp:
974         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
975         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
976         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
977         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
978         * rendering/RenderThemeChromiumWin.h:
979         * rendering/RenderThemeWin.cpp:
980         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
981         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
982         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
983         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
984         * rendering/RenderThemeWin.h:
985
986 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
987
988         Build fix for Qt port.  Remove unnecessary assert.
989
990         * platform/graphics/qt/ImageBufferQt.cpp:
991         (WebCore::ImageBuffer::putImageData):
992
993 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
994
995         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
996
997         https://bugs.webkit.org/show_bug.cgi?id=24227
998         Ensure that the checkForSolidColor() optimization is correctly triggered
999         for all cases of drawPattern.  Currently, the optimization was not triggered
1000         when the check had not been previously performed via a request for the
1001         image's NativeImagePtr.
1002
1003         Implement the Qt version of the checkForSolidColor() method.  Combined with
1004         the bug fix this reduces the time it takes to draw a repeating background
1005         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1006
1007         * platform/graphics/BitmapImage.cpp:
1008         (WebCore::BitmapImage::BitmapImage):
1009         * platform/graphics/BitmapImage.h:
1010         (WebCore::BitmapImage::mayFillWithSolidColor):
1011         * platform/graphics/Image.h:
1012         (WebCore::Image::mayFillWithSolidColor):
1013         * platform/graphics/cairo/ImageCairo.cpp:
1014         (WebCore::BitmapImage::BitmapImage):
1015         (WebCore::BitmapImage::checkForSolidColor):
1016         * platform/graphics/cg/ImageCG.cpp:
1017         (WebCore::BitmapImage::BitmapImage):
1018         (WebCore::BitmapImage::checkForSolidColor):
1019         * platform/graphics/qt/ImageQt.cpp:
1020         (WebCore::BitmapImage::checkForSolidColor):
1021         * platform/graphics/skia/ImageSkia.cpp:
1022         (WebCore::BitmapImage::checkForSolidColor):
1023         * platform/graphics/wx/ImageWx.cpp:
1024         (WebCore::BitmapImage::checkForSolidColor):
1025
1026 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
1027
1028         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
1029         they show up in the tarball.
1030
1031         * GNUmakefile.am:
1032
1033 2009-03-02  Dirk Schulze  <krit@webkit.org>
1034
1035         Reviewed by Holger Freyther.
1036
1037         Added putImageData to Qt. Discussed with Ariya Hidayat.
1038
1039         [Qt] lacks putImageData support in Canvas
1040         https://bugs.webkit.org/show_bug.cgi?id=22186
1041
1042         * platform/graphics/qt/ImageBufferQt.cpp:
1043         (WebCore::ImageBuffer::putImageData):
1044
1045 2009-03-02  Timothy Hatcher  <timothy@apple.com>
1046
1047         Show exception messages again when evaluating bad expressions in the
1048         Web Inspector's console.
1049
1050         https://bugs.webkit.org/show_bug.cgi?id=19890
1051
1052         Reviewed by Oliver Hunt.
1053
1054         * bindings/js/JSQuarantinedObjectWrapper.cpp:
1055         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
1056         Fix the order in which the exception is set and cleared now that the
1057         exception is stored in the shared GlobalData, not per ExecState.
1058
1059 2009-02-28  Timothy Hatcher  <timothy@apple.com>
1060
1061         Make input in the Web Inspector console print before any output
1062         that might be added by the called function.
1063
1064         https://bugs.webkit.org/show_bug.cgi?id=19931
1065
1066         Reviewed by Oliver Hunt.
1067
1068         * inspector/front-end/Console.js:
1069         (WebInspector.Console.prototype._enterKeyPressed): Add the command
1070         message before evaluating the result. Associate the originating
1071         command to the result, so if they are adjacent there is no divider.
1072         (WebInspector.ConsoleCommand): No longer take a result.
1073         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
1074         code removed since it isn't used now.
1075         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
1076         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
1077         Call the ConsoleMessage toMessageElement and add a style class.
1078         * inspector/front-end/inspector.css: Add a new style class for
1079         adjacent results to hide the divider. Also tweak the position of
1080         the disclosure triangle for objects to not use the left margin.
1081
1082 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
1083
1084         Reviewed by Oliver Hunt.
1085
1086         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
1087         <https://bugs.webkit.org/show_bug.cgi?id=24282>
1088
1089         When fetching an array of elements with a range, attachment views need to be returned
1090         instead of the actual attachment.
1091
1092         * page/mac/AccessibilityObjectWrapper.mm:
1093         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1094         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1095
1096 2009-03-01  Ojan Vafai  <ojan@chromium.org>
1097
1098         Reviewed by Eric Seidel.
1099
1100         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
1101         <https://bugs.webkit.org/show_bug.cgi?id=24251>
1102         
1103         Make RenderObject::positionForCoordinate non-virtual and
1104         RenderObject::positionForPoint virtual in preparation for
1105         removing positionFor* from RenderObject/RenderText.
1106
1107         * page/Frame.cpp:
1108         (WebCore::Frame::visiblePositionForPoint):
1109         * rendering/RenderBR.cpp:
1110         (WebCore::RenderBR::positionForPoint):
1111         * rendering/RenderBR.h:
1112         * rendering/RenderBlock.cpp:
1113         (WebCore::RenderBlock::positionForPoint):
1114         * rendering/RenderBlock.h:
1115         * rendering/RenderBox.cpp:
1116         (WebCore::RenderBox::positionForPoint):
1117         * rendering/RenderBox.h:
1118         * rendering/RenderInline.cpp:
1119         (WebCore::RenderInline::positionForPoint):
1120         * rendering/RenderInline.h:
1121         * rendering/RenderObject.cpp:
1122         (WebCore::RenderObject::positionForCoordinates):
1123         (WebCore::RenderObject::positionForPoint):
1124         * rendering/RenderObject.h:
1125         * rendering/RenderReplaced.cpp:
1126         (WebCore::RenderReplaced::positionForPoint):
1127         * rendering/RenderReplaced.h:
1128         * rendering/RenderSVGInlineText.cpp:
1129         (WebCore::RenderSVGInlineText::positionForPoint):
1130         * rendering/RenderSVGInlineText.h:
1131         * rendering/RenderText.cpp:
1132         (WebCore::RenderText::positionForPoint):
1133         * rendering/RenderText.h:
1134
1135 2009-03-01  Larry Ewing  <lewing@novell.com>
1136
1137         Reviewed by Alexey Proskuryakov.
1138
1139         https://bugs.webkit.org/show_bug.cgi?id=24080
1140         NPN_GetValue casting to the wrong type and writing outside bounds
1141
1142         Make sure to cast the value to the correct type so that only
1143         memory owned by the value is written to.
1144
1145         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
1146         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
1147         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
1148         (PluginView::getValue):
1149
1150 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
1151
1152         Reviewed by Simon Fraser.
1153
1154         https://bugs.webkit.org/show_bug.cgi?id=24197 and
1155         https://bugs.webkit.org/show_bug.cgi?id=23512
1156
1157         The Windows version of cgColor() is conditionally compiled using
1158         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
1159         can use the OS X version instead of the Windows version.
1160
1161         Also rename cgColor() -> createCGColor()
1162
1163         No observable change in behavior, so no test.
1164
1165         * platform/graphics/Color.h:
1166         * platform/graphics/cg/ColorCG.cpp:
1167         (WebCore::createCGColor):
1168         * platform/graphics/cg/GraphicsContextCG.cpp:
1169         (WebCore::GraphicsContext::setPlatformShadow):
1170         * platform/graphics/mac/ColorMac.mm:
1171         (WebCore::createCGColor):
1172         * platform/graphics/mac/GraphicsContextMac.mm:
1173         (WebCore::GraphicsContext::drawFocusRing):
1174         * platform/graphics/mac/GraphicsLayerCA.mm:
1175         (WebCore::setLayerBorderColor):
1176         (WebCore::setLayerBackgroundColor):
1177         (WebCore::GraphicsLayerCA::setBackgroundColor):
1178         * platform/graphics/win/GraphicsContextCGWin.cpp:
1179         (WebCore::GraphicsContext::drawFocusRing):
1180         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
1181         (WebCore::ciColor):
1182
1183 2009-03-01  David Levin  <levin@chromium.org>
1184
1185         Reviewed by Alexey Proskuryakov.
1186
1187         Bug 24271: XMLHttpRequest needs js bindings for Workers.
1188         <https://bugs.webkit.org/show_bug.cgi?id=24271>
1189
1190         Tests: http/tests/xmlhttprequest/workers/methods-async.html
1191                http/tests/xmlhttprequest/workers/methods.html
1192
1193         * bindings/js/JSWorkerContextBase.cpp:
1194         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
1195         (jsWorkerContextBaseXMLHttpRequest):
1196         (setJSWorkerContextBaseXMLHttpRequest):
1197         Expose XMLHttpRequest to Workers.
1198
1199         * bindings/js/JSWorkerContextBase.h:
1200
1201         * bindings/js/JSXMLHttpRequestConstructor.cpp:
1202         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
1203         (WebCore::constructXMLHttpRequest):
1204         (WebCore::JSXMLHttpRequestConstructor::mark):
1205         Removed the dependencies on Document.
1206
1207         * bindings/js/JSXMLHttpRequestConstructor.h:
1208         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
1209         * dom/EventException.idl:
1210         * dom/EventListener.idl:
1211         Change to have the NoStaticTables attribute since they are used from XHR.
1212
1213         * loader/WorkerThreadableLoader.cpp:
1214         (WebCore::workerContextDidFinishLoading):
1215         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
1216         Fixed identifier to be unsigned long.
1217
1218         * loader/WorkerThreadableLoader.h:
1219         * workers/WorkerThread.cpp:
1220         (WebCore::WorkerThread::workerThread):
1221         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
1222
1223         * xml/XMLHttpRequestUpload.cpp:
1224
1225         * xml/XMLHttpRequest.idl:
1226         * xml/XMLHttpRequestException.idl:
1227         * xml/XMLHttpRequestProgressEvent.idl:
1228         * xml/XMLHttpRequestUpload.idl:
1229         Change to have the NoStaticTables attribute since they are used from XHR.
1230
1231 2009-03-01  Horia Olaru  <olaru@adobe.com>
1232
1233         Adding manual debugger test cases for bug.
1234
1235         https://bugs.webkit.org/show_bug.cgi?id=21073
1236
1237         Reviewed by Kevin McCullough.
1238
1239         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
1240         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
1241         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
1242         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
1243         * manual-tests/inspector/resources/loop-statements.js: Added.
1244
1245 2009-03-01  Dan Bernstein  <mitz@apple.com>
1246
1247         Reviewed by Darin Adler.
1248
1249         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
1250
1251         Test: fast/events/scroll-during-zoom-change.html
1252
1253         * dom/Document.cpp:
1254         (WebCore::Document::recalcStyle): Pause scheduled events during style
1255         reclaculation. Changes to the zoom property result in scroll events
1256         being generated during style recalc, and those events need to be
1257         deferred until the render tree is consistent.
1258         * page/FrameView.cpp:
1259         (WebCore::FrameView::layout): Changed to account for a case in which the
1260         post-layout tasks trigger a nested layout, which reactivates the
1261         post-layout task timer.
1262
1263 2009-03-01  Ross Boucher  <rboucher@gmail.com>
1264
1265         Alphabetically sort scripts in the Script's panel file popup menu.
1266
1267         https://bugs.webkit.org/show_bug.cgi?id=23395
1268
1269         Reviewed by Timothy Hatcher.
1270
1271         * inspector/front-end/ScriptsPanel.js:
1272         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1273         * inspector/front-end/utilities.js:
1274         (insertionIndexForObjectInListSortedByFunction):
1275         (indexOfObjectInListSortedByFunction):
1276
1277 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1278
1279         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1280         when creating databases, localStorage or sessionStorage. Changing document.domain
1281         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1282
1283         https://bugs.webkit.org/show_bug.cgi?id=23844
1284
1285         Reviewed by Timothy Hatcher.
1286
1287         * inspector/InspectorController.cpp:
1288         (WebCore::InspectorController::addDOMStorageScriptResource):
1289         (WebCore::InspectorController::didUseDOMStorage):
1290         * storage/Database.cpp:
1291         (WebCore::Database::openDatabase):
1292
1293 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1294
1295         Reviewed by Holger Freyther.
1296
1297         Avoid leaking errors when reporting GIO errors.
1298
1299         * platform/network/soup/ResourceHandleSoup.cpp:
1300         (WebCore::readCallback):
1301         (WebCore::openCallback):
1302         (WebCore::queryInfoCallback):
1303
1304 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1305
1306         Reviewed by Holger Freyther.
1307
1308         Fixes crash when the GIO backend is given the URI for a directory.
1309
1310         * platform/network/soup/ResourceHandleSoup.cpp:
1311         (WebCore::networkErrorForFile):
1312
1313 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1314
1315         Reviewed by Darin Fisher.
1316
1317         https://bugs.webkit.org/show_bug.cgi?id=24261
1318         Fix V8 custom binding scrubbing error.
1319
1320         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1321         Test: traversal/exception-forwarding.html
1322         TesT: traversal/stay-within-root.html
1323
1324         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1325         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1326         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1327         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1328         (WebCore::toV8): Ditto.
1329
1330 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1331
1332         Reviewed by Darin Fisher.
1333
1334         https://bugs.webkit.org/show_bug.cgi?id=24261
1335         Fix V8 custom binding scrubbing error.
1336
1337         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1338
1339         * WebCore.xcodeproj/project.pbxproj:
1340         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1341         (WebCore::cssPropertyName):  Remove dubious checks, left over from
1342             incomplete conversion of parameter from pointer to pass-by-ref.
1343         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
1344         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
1345
1346 2009-02-28  Xan Lopez  <xan@gnome.org>
1347
1348         Reviewed by Holger Freyther.
1349
1350         https://bugs.webkit.org/show_bug.cgi?id=24263
1351         [GTK] ref ResourceHandle until we are finished with it
1352
1353         Add a ref to the ResourceHandle in startHttp so we can keep it
1354         alive untill all callbacks have been executed, and unref it when
1355         soup tells us it's done with the SoupMessage (in
1356         finishedCallback). Fixes a number of crashes when calling
1357         didReceiveData whould crash because of the handle dying.
1358
1359         * platform/network/soup/ResourceHandleSoup.cpp:
1360         (WebCore::finishedCallback):
1361         (WebCore::ResourceHandle::startHttp):
1362
1363 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
1364
1365         Reviewed by Alexey Proskuryakov.
1366
1367         https://bugs.webkit.org/show_bug.cgi?id=24226
1368         [SOUP] HTTP status text is never set
1369
1370         Set HTTP status text to SoupMessage reason_phrase.
1371
1372         * platform/network/soup/ResourceHandleSoup.cpp:
1373         (WebCore::fillResponseFromMessage):
1374
1375 2009-02-28  Dan Bernstein  <mitz@apple.com>
1376
1377         - fix malformed project file
1378
1379         * WebCore.xcodeproj/project.pbxproj:
1380
1381 2009-02-28  Dan Bernstein  <mitz@apple.com>
1382
1383         Reviewed by Oliver Hunt.
1384
1385         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
1386           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
1387
1388         Test: fast/layers/inline-dirty-z-order-lists.html
1389
1390         * rendering/RenderBox.cpp:
1391         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
1392         layer's and its stacking context's z-order lists when the layer's
1393         z-index or visibility change from here...
1394         * rendering/RenderBoxModelObject.cpp:
1395         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
1396         it will apply to RenderInline too.
1397
1398 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
1399
1400         Reviewed by David Hyatt.
1401
1402         Don't include TextResourceDecoder.h in Document.h
1403
1404         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
1405         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
1406
1407         * dom/Document.cpp:
1408         (WebCore::Document::displayStringModifiedByEncoding):
1409         (WebCore::Document::displayBufferModifiedByEncoding):
1410         * dom/Document.h:
1411         * WebCore.base.exp:
1412
1413 2009-02-27  Matt Pennig  <pennig@apple.com>
1414
1415         Reviewed by David Hyatt.
1416
1417         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
1418         "Fixed elements have 0 as an offsetLeft property"
1419         
1420         Code also brings offsetLeft/Top in full conformance with the spec.
1421         Added two tests, one for fixed-position elements, and one for <html>.
1422         
1423         Tests: fast/dom/Element/fixed-position-offset-parent.html
1424                fast/dom/Element/offsetLeft-offsetTop-html.html
1425
1426         * rendering/RenderBoxModelObject.cpp:
1427         (WebCore::RenderBoxModelObject::offsetLeft):
1428         (WebCore::RenderBoxModelObject::offsetTop):
1429
1430 2009-02-27  Dean Jackson  <dino@apple.com>
1431
1432         Reviewed by Simon Fraser.
1433
1434         renderer()->hasTransform() returns true for elements
1435         with perspective, but no transform, so test for transform
1436         when hit testing. This fixes ASSERT from
1437         https://bugs.webkit.org/show_bug.cgi?id=24252
1438
1439         Test: transforms/no_transform_hit_testing.html
1440
1441         * rendering/RenderLayer.cpp:
1442         (WebCore::RenderLayer::hitTestLayer):
1443
1444 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1445
1446         Reviewed by Darin Fisher.
1447
1448         Fix scrubbing error -- a reversed condition.
1449
1450         * bindings/v8/ScriptValue.h:
1451         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
1452
1453 2009-02-27  Jian Li  <jianli@chromium.org>
1454
1455         Reviewed by Alexey Proskuryakov.
1456
1457         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
1458         https://bugs.webkit.org/show_bug.cgi?id=24152
1459
1460         * workers/WorkerMessagingProxy.cpp:
1461         (WebCore::MessageWorkerContextTask::performTask):
1462         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
1463         * workers/WorkerMessagingProxy.h:
1464         * workers/WorkerObjectProxy.h:
1465
1466 2009-02-27  Anders Carlsson  <andersca@apple.com>
1467
1468         Reviewed by David Hyatt.
1469
1470         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
1471         because it leads to assertion failures in the Mac port.
1472         
1473         * platform/graphics/BitmapImage.cpp:
1474         (WebCore::BitmapImage::BitmapImage):
1475         * platform/graphics/BitmapImage.h:
1476         (WebCore::BitmapImage::mayFillWithSolidColor):
1477         * platform/graphics/Image.h:
1478         (WebCore::Image::mayFillWithSolidColor):
1479         * platform/graphics/cairo/ImageCairo.cpp:
1480         (WebCore::BitmapImage::BitmapImage):
1481         * platform/graphics/cg/ImageCG.cpp:
1482         (WebCore::BitmapImage::BitmapImage):
1483         (WebCore::BitmapImage::checkForSolidColor):
1484         * platform/graphics/qt/ImageQt.cpp:
1485         (WebCore::BitmapImage::checkForSolidColor):
1486         * platform/graphics/skia/ImageSkia.cpp:
1487         (WebCore::BitmapImage::checkForSolidColor):
1488         * platform/graphics/wx/ImageWx.cpp:
1489         (WebCore::BitmapImage::checkForSolidColor):
1490
1491 2009-02-27  Adam Barth  <abarth@webkit.org>
1492
1493         Reviewed by Eric Seidel.
1494
1495         https://bugs.webkit.org/show_bug.cgi?id=20249
1496
1497         Add a preference to allow universal access from local URLs to mitigate
1498         some attacks.  Some clients still want to allow this access, so we
1499         expose this as a preference.
1500
1501         * WebCore.base.exp:
1502         * dom/Document.cpp:
1503         (WebCore::Document::initSecurityContext):
1504         * page/SecurityOrigin.cpp:
1505         (WebCore::SecurityOrigin::SecurityOrigin):
1506         * page/Settings.cpp:
1507         (WebCore::Settings::Settings):
1508         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
1509         * page/Settings.h:
1510         (WebCore::Settings::allowUniversalAccessFromFileUrls):
1511
1512 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1513
1514         Reviewed by Eric Seidel.
1515
1516         https://bugs.webkit.org/show_bug.cgi?id=24229
1517         If an image has no alpha channel there is no reason to use SourceOver.
1518
1519         * platform/graphics/qt/ImageQt.cpp:
1520         (WebCore::Image::drawPattern):
1521         (WebCore::BitmapImage::draw):
1522
1523 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1524
1525         Reviewed by Eric Seidel and Simon Fraser.
1526
1527         https://bugs.webkit.org/show_bug.cgi?id=24227
1528         Ensure that the checkForSolidColor() optimization is correctly triggered
1529         for all cases of drawPattern.  Currently, the optimization was not triggered
1530         when the check had not been previously performed via a request for the
1531         image's NativeImagePtr.
1532
1533         Implement the Qt version of the checkForSolidColor() method.  Combined with
1534         the bug fix this reduces the time it takes to draw a repeating background
1535         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1536
1537         * platform/graphics/BitmapImage.cpp:
1538         (WebCore::BitmapImage::BitmapImage):
1539         * platform/graphics/BitmapImage.h:
1540         (WebCore::BitmapImage::mayFillWithSolidColor):
1541         * platform/graphics/Image.h:
1542         (WebCore::Image::mayFillWithSolidColor):
1543         * platform/graphics/cairo/ImageCairo.cpp:
1544         (WebCore::BitmapImage::BitmapImage):
1545         * platform/graphics/cg/ImageCG.cpp:
1546         (WebCore::BitmapImage::BitmapImage):
1547         (WebCore::BitmapImage::checkForSolidColor):
1548         * platform/graphics/qt/ImageQt.cpp:
1549         (WebCore::BitmapImage::checkForSolidColor):
1550         * platform/graphics/skia/ImageSkia.cpp:
1551         (WebCore::BitmapImage::checkForSolidColor):
1552         * platform/graphics/wx/ImageWx.cpp:
1553         (WebCore::BitmapImage::checkForSolidColor):
1554
1555 2009-02-27  Dirk Schulze  <krit@webkit.org>
1556
1557         Reviewed by Zack Rusin.
1558
1559         Added support for gradients and pattern on Fonts for Qt.
1560
1561         [Qt] gradients and patterns for FontQt
1562         https://bugs.webkit.org/show_bug.cgi?id=24243
1563
1564         * platform/graphics/qt/FontQt.cpp:
1565         (WebCore::Font::drawComplexText):
1566
1567 2009-02-27  Jian Li  <jianli@chromium.org>
1568
1569         Reviewed by Alexey Proskuryakov.
1570
1571         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
1572         https://bugs.webkit.org/show_bug.cgi?id=24113
1573
1574         * workers/WorkerMessagingProxy.cpp:
1575
1576 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1577
1578         Added a refresh button to storage views.
1579
1580         https://bugs.webkit.org/show_bug.cgi?id=24040
1581
1582         Reviewed by Timothy Hatcher.
1583
1584         * inspector/front-end/DOMStorageItemsView.js:
1585         (WebInspector.DOMStorageItemsView):
1586         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1587         (WebInspector.DOMStorageItemsView.prototype.update):
1588         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1589         * inspector/front-end/DatabaseTableView.js:
1590         (WebInspector.DatabaseTableView):
1591         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
1592         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
1593         * inspector/front-end/DatabasesPanel.js:
1594         (WebInspector.DatabasesPanel):
1595         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1596         (WebInspector.DatabasesPanel.prototype.reset):
1597         (WebInspector.DatabasesPanel.prototype.showDatabase):
1598         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1599         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1600         * inspector/front-end/inspector.css:
1601
1602 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1603
1604         Added support for editing/deleting localStorage and sessionStorage items
1605         directly from Web Inspector.
1606
1607         https://bugs.webkit.org/show_bug.cgi?id=23866.
1608
1609         Reviewed by Timothy Hatcher.
1610
1611         * WebCore.vcproj/WebCore.vcproj:
1612         * inspector/front-end/DOMStorageDataGrid.js: Added.
1613         (WebInspector.DOMStorageDataGrid):
1614         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
1615         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
1616         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
1617         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
1618         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
1619         * inspector/front-end/DOMStorageItemsView.js:
1620         (WebInspector.DOMStorageItemsView):
1621         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1622         (WebInspector.DOMStorageItemsView.prototype.hide):
1623         (WebInspector.DOMStorageItemsView.prototype.update):
1624         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1625         * inspector/front-end/DatabasesPanel.js:
1626         (WebInspector.DatabasesPanel):
1627         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1628         (WebInspector.DatabasesPanel.prototype.reset):
1629         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1630         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
1631         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1632         * inspector/front-end/WebKit.qrc:
1633         * inspector/front-end/inspector.css:
1634         * inspector/front-end/inspector.html:
1635
1636 2009-02-26  Brett Wilson  <brettw@chromium.org>
1637
1638         Fix Windows transparency for the Chromium port. Implement a helper
1639         class for handling transparency on Windows. It allows semitransparent
1640         ClearType and semitransparent form controls by making new layers in the
1641         background.
1642
1643         It also replaces the "ThemeHelper" which allows better
1644         scaling and transforms on Windows form controls. In addition to the
1645         functionality that the ThemeHelper did, but additionally handles the
1646         antialiasing properly so that the form controls aren't composited on a
1647         white square.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=24101
1650
1651         Reviewed by Eric Seidel.
1652
1653         * platform/graphics/chromium/FontChromiumWin.cpp:
1654         (WebCore::):
1655         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1656         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1657         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1658         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
1659         (WebCore::Font::drawGlyphs):
1660         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
1661         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
1662         * platform/graphics/chromium/TransparencyWin.cpp: Added.
1663         (WebCore::):
1664         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1665         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
1666         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
1667         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
1668         (WebCore::TransparencyWin::TransparencyWin):
1669         (WebCore::TransparencyWin::~TransparencyWin):
1670         (WebCore::TransparencyWin::init):
1671         (WebCore::TransparencyWin::computeLayerSize):
1672         (WebCore::TransparencyWin::setupLayer):
1673         (WebCore::TransparencyWin::setupLayerForNoLayer):
1674         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
1675         (WebCore::TransparencyWin::setupLayerForTextComposite):
1676         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1677         (WebCore::TransparencyWin::setupTransform):
1678         (WebCore::TransparencyWin::setupTransformForKeepTransform):
1679         (WebCore::TransparencyWin::setupTransformForUntransform):
1680         (WebCore::TransparencyWin::setupTransformForScaleTransform):
1681         (WebCore::TransparencyWin::setTextCompositeColor):
1682         (WebCore::TransparencyWin::initializeNewContext):
1683         (WebCore::TransparencyWin::compositeOpaqueComposite):
1684         (WebCore::TransparencyWin::compositeTextComposite):
1685         (WebCore::TransparencyWin::makeLayerOpaque):
1686         * platform/graphics/chromium/TransparencyWin.h: Added.
1687         (WebCore::TransparencyWin::):
1688         (WebCore::TransparencyWin::context):
1689         (WebCore::TransparencyWin::platformContext):
1690         (WebCore::TransparencyWin::drawRect):
1691         * platform/graphics/skia/GraphicsContextSkia.cpp:
1692         (WebCore::GraphicsContext::endTransparencyLayer):
1693         * platform/graphics/skia/ImageSkia.cpp:
1694         (WebCore::paintSkBitmap):
1695         * rendering/RenderThemeChromiumWin.cpp:
1696         (WebCore::):
1697         (WebCore::RenderThemeChromiumWin::paintButton):
1698         (WebCore::RenderThemeChromiumWin::paintMenuList):
1699         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1700
1701 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1702
1703         Reviewed by Eric Seidel.
1704
1705         https://bugs.webkit.org/show_bug.cgi?id=24211
1706         Add ScheduledAction for V8.
1707
1708         * bindings/v8/ScheduledAction.cpp: Added.
1709         (WebCore::ScheduledAction::ScheduledAction):
1710         (WebCore::ScheduledAction::~ScheduledAction):
1711         (WebCore::ScheduledAction::execute):
1712         * bindings/v8/ScheduledAction.h: Added.
1713         (WebCore::ScheduledAction::ScheduledAction):
1714
1715 2009-02-27  Zack Rusin  <zack@kde.org>
1716
1717         Reviewed by Nikolas Zimmermann.
1718
1719         Qt: be more reasonable about scrolled lines
1720
1721         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
1722         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
1723         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
1724         single step scroll
1725
1726         * platform/qt/WheelEventQt.cpp:
1727
1728 2009-02-27  Xan Lopez  <xan@gnome.org>
1729
1730         Rubber-stamped by Alexey Proskuryakov.
1731
1732         https://bugs.webkit.org/show_bug.cgi?id=24222
1733         [GTK] Remove checks for old glib versions
1734
1735         libsoup, which is a hard dependency, needs at least glib 2.15.3,
1736         so remove all glib checks for versions older than that.
1737
1738         * platform/gtk/ContextMenuGtk.cpp:
1739         (WebCore::ContextMenu::ContextMenu):
1740         * platform/gtk/ContextMenuItemGtk.cpp:
1741         (WebCore::ContextMenuItem::setSubMenu):
1742         * platform/gtk/PopupMenuGtk.cpp:
1743         (WebCore::PopupMenu::show):
1744         * platform/gtk/WidgetGtk.cpp:
1745         (WebCore::Widget::retainPlatformWidget):
1746         * platform/network/soup/ResourceHandleSoup.cpp:
1747
1748 2009-02-26  Dirk Schulze  <krit@webkit.org>
1749
1750         Reviewed by Oliver Hunt.
1751
1752         Added support for Gradients and Patterns on filled or stroked Fonts
1753         in Cairo. I also added support for globalAlpha on FontCairo.
1754
1755         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
1756         https://bugs.webkit.org/show_bug.cgi?id=18617
1757
1758         * html/CanvasRenderingContext2D.cpp:
1759         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1760         * platform/graphics/cairo/FontCairo.cpp:
1761         (WebCore::Font::drawGlyphs):
1762
1763 2009-02-26  Stephen White  <senorblanco@chromium.org>
1764
1765         Reviewed by Eric Seidel.
1766
1767         https://bugs.webkit.org/show_bug.cgi?id=23957
1768
1769         Fix for SVG gradient and pattern text for Chromium/skia. 
1770         Added accessors for the fill and stroke gradients to
1771         GraphicsContext.  Changed the paintSkiaText function to take a
1772         GraphicsContext, so we can check for gradients/patterns. 
1773         Changed the skiaDrawText function to set the SkPaint shader
1774         correctly, and to scale up the gradient shader matrix to
1775         encompass the entire text string.  Also offset each glyph
1776         separately, rather than transforming the canvas, so that the
1777         gradient/pattern stays fixed relative to the text origin.
1778
1779         * platform/graphics/GraphicsContext.cpp:
1780         (WebCore::GraphicsContext::getFillGradient):
1781         (WebCore::GraphicsContext::getStrokeGradient):
1782         (WebCore::GraphicsContext::getFillPattern):
1783         (WebCore::GraphicsContext::getStrokePattern):
1784         * platform/graphics/GraphicsContext.h:
1785         * platform/graphics/chromium/FontChromiumWin.cpp:
1786         (WebCore::Font::drawGlyphs):
1787         * platform/graphics/chromium/UniscribeHelper.cpp:
1788         (WebCore::UniscribeHelper::draw):
1789         * platform/graphics/skia/SkiaFontWin.cpp:
1790         (WebCore::windowsCanHandleTextDrawing):
1791         (WebCore::skiaDrawText):
1792         (WebCore::paintSkiaText):
1793         * platform/graphics/skia/SkiaFontWin.h:
1794
1795 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1796
1797         Reviewed by Eric Seidel.
1798
1799         https://bugs.webkit.org/show_bug.cgi?id=24208
1800         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1801
1802         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1803         (WebCore::ACCESSOR_GETTER):
1804         (WebCore::CALLBACK_FUNC_DECL):
1805         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1806         (WebCore::CALLBACK_FUNC_DECL):
1807         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1808         (WebCore::ACCESSOR_GETTER):
1809         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1810         (WebCore::CALLBACK_FUNC_DECL):
1811
1812 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1813
1814         Unreviewed build fix for building with GNOME Keyring enabled.
1815
1816         * platform/network/soup/webkit-soup-auth-dialog.c:
1817         (show_auth_dialog):
1818
1819 2009-02-26  Xan Lopez  <xan@gnome.org>
1820
1821         Reviewed by Holger Freyther.
1822
1823         https://bugs.webkit.org/show_bug.cgi?id=16947
1824         [GTK] Missing HTTP Auth challenge
1825
1826         Add HTTP authentication dialog with optional GNOME Keyring
1827         storage.
1828
1829         * GNUmakefile.am:
1830         * platform/network/ResourceHandleInternal.h:
1831         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1832         * platform/network/soup/ResourceHandleSoup.cpp:
1833         (WebCore::currentToplevelCallback):
1834         (WebCore::ResourceHandle::startHttp):
1835         (WebCore::ResourceHandle::start):
1836         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1837         (webkit_soup_auth_dialog_class_init):
1838         (webkit_soup_auth_dialog_init):
1839         (webkit_soup_auth_dialog_session_feature_init):
1840         (free_authData):
1841         (set_password_callback):
1842         (response_callback):
1843         (show_auth_dialog):
1844         (find_password_callback):
1845         (session_authenticate):
1846         (attach):
1847         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1848
1849 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1850
1851         Reviewed by Dave Hyatt.
1852
1853         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1854         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1855         started failing because Ojan's new code was now *correctly* calling through to
1856         SVG asking for the closest text offset in the last line box, instead of
1857         just returning the offset at the end of the last line box when clicking below a box.
1858
1859         But!  The SVG code was wrong, in that it returned the character offset of the last
1860         character when you asked for a character offset after the end of the box, instead
1861         it should return the offset *after* the last character.  This patch fixes
1862         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1863
1864         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1865         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1866         what it is doing (which also makes more obvious what's wrong with it).
1867
1868         * rendering/RenderSVGInlineText.cpp:
1869         (WebCore::RenderSVGInlineText::positionForCoordinates):
1870         * rendering/SVGInlineTextBox.cpp:
1871         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1872         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1873         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1874         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1875         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1876
1877 2009-02-26  Darin Fisher  <darin@chromium.org>
1878
1879         Reviewed by Eric Seidel.
1880
1881         Minor cleanup of ChromiumBridge:
1882         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1883
1884         * platform/chromium/ChromiumBridge.h:
1885         * platform/chromium/MimeTypeRegistryChromium.cpp:
1886         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1887         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1888         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1889
1890 2009-02-26  David Hyatt  <hyatt@apple.com>
1891
1892         Reviewed by Sam Weinig
1893
1894         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1895         the line-height below the descent.
1896
1897         Added fast/inline/vertical-align-text-bottom.html
1898
1899         * rendering/RenderBoxModelObject.cpp:
1900         (WebCore::RenderBoxModelObject::verticalPosition):
1901
1902 2009-02-26  Dirk Schulze  <krit@webkit.org>
1903
1904         Reviewed by Eric Seidel.
1905
1906         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1907         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1908         just to implement this three methods to support SVG Masking now.
1909  
1910         Make SVG Masking platform aware
1911         https://bugs.webkit.org/show_bug.cgi?id=19243
1912
1913         * GNUmakefile.am:
1914         * WebCore.pro:
1915         * WebCore.vcproj/WebCore.vcproj:
1916         * WebCore.xcodeproj/project.pbxproj:
1917         * svg/graphics/SVGResourceMasker.cpp:
1918         (WebCore::SVGResourceMasker::applyMask):
1919         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1920         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1921         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1922         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1923         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1924
1925 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1926
1927         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1928
1929         Test: http/tests/misc/slow-preload-cancel.html
1930
1931         https://bugs.webkit.org/show_bug.cgi?id=24133
1932         Clear all pending preloads in the DocLoader object when we decide to
1933         cancel its all requests.
1934
1935         * loader/DocLoader.cpp:
1936         (WebCore::DocLoader::clearPendingPreloads):
1937         * loader/DocLoader.h:
1938         * loader/loader.cpp:
1939         (WebCore::Loader::cancelRequests):
1940
1941 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1942
1943         Reviewed by Eric Seidel.
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=24182
1946         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1947
1948         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1949         (WebCore::CALLBACK_FUNC_DECL):
1950         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1951         (WebCore::toV8):
1952         (WebCore::CALLBACK_FUNC_DECL):
1953         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1954         (WebCore::toV8):
1955         (WebCore::CALLBACK_FUNC_DECL):
1956
1957 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1958
1959         Reviewed by Darin Adler.
1960
1961         https://bugs.webkit.org/show_bug.cgi?id=23500
1962         KURL::parse() incorrectly compares its result to original string
1963
1964         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
1965
1966 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1967
1968         Reviewed by Kevin McCullough.
1969
1970         Manual test for inspector node highlighting.
1971
1972         * manual-tests/inspector/highlight-nodes.html: Added.
1973
1974 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
1975
1976         Reviewed by Darin Fisher.
1977
1978         https://bugs.webkit.org/show_bug.cgi?id=23973
1979         ScrollView::scrollContents can be invoked during view shutdown.  In
1980         this scenario the FrameView::hostWindow method can return NULL, which
1981         indicates that the frame/page is being destroyed. This causes a crash
1982         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
1983         NULL check for this.  
1984
1985         * platform/ScrollView.cpp:
1986         (WebCore::ScrollView::scrollContents):
1987
1988 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
1989
1990         Reviewed by Dave Hyatt.
1991
1992         https://bugs.webkit.org/show_bug.cgi?id=24003
1993         Fix a crash caused by unsafe type conversion.
1994
1995         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
1996
1997         * rendering/RenderBox.cpp:
1998         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
1999
2000 2009-02-26  Ojan Vafai  <ojan@chromium.org>
2001
2002         Reviewed by Adam Roben.
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=24202
2005         Have drawNodeHighlight clip instead of clearing. This makes it work for
2006         both Safari and Chromium since Chromium draws the inspector highlighting
2007         in the same buffer as the page.
2008
2009         * inspector/InspectorController.cpp:
2010         (WebCore::quadToPath):
2011         (WebCore::drawOutlinedQuad):
2012         (WebCore::drawOutlinedQuadWithClip):
2013         (WebCore::drawHighlightForBox):
2014
2015 2009-02-26  David Hyatt  <hyatt@apple.com>
2016
2017         Reviewed by Dan Bernstein & Darin Adler
2018
2019         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
2020         
2021         Added fast/inline/inline-continuation-borders.html
2022
2023         * rendering/InlineFlowBox.cpp:
2024         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
2025
2026 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
2027
2028         Build fix, no review.
2029         
2030         Try to fix the wx build after r41218.
2031
2032         * WebCoreSources.bkl:
2033
2034 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
2035
2036         Reviewed by Darin Adler.
2037
2038         https://bugs.webkit.org/show_bug.cgi?id=19527
2039         ASSERTION FAILED: containerA && containerB
2040
2041         Test: fast/dom/Range/bug-19527.html
2042
2043         * dom/Range.cpp:
2044         (WebCore::Range::isPointInRange):
2045         (WebCore::Range::comparePoint):
2046         Bring the behavior in line with current Firefox, making it impossible for these methods
2047         to pass a null container to compareBoundaryPoints().
2048
2049 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
2050
2051         Reviewed by Holger Freyther.
2052
2053         https://bugs.webkit.org/show_bug.cgi?id=20358
2054
2055         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
2056         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
2057         should set the computed size rather than the specified size, otherwise
2058         the caps just get rendered normal size.
2059
2060 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
2061
2062         Reviewed by George Staikos.
2063
2064         https://bugs.webkit.org/show_bug.cgi?id=24062
2065         QNetworkCookieJar expects the url and not the policy url.  Sending the
2066         policy url will cause QNetworkCookieJar to behave incorrectly.  One
2067         example would be a cookie that does not have a path or domain.
2068         QNetworkCookieJar will use the url it is given to fill in default values.
2069         This allows setting cookies on the url of the main frame from an iFrame
2070         when the cookie should be set on the url of the iFrame.
2071
2072         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
2073
2074         * platform/qt/CookieJarQt.cpp:
2075         (WebCore::setCookies):
2076
2077 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
2078
2079         Reviewed by George Staikos.
2080
2081         make WebKit/Qt compile with SVG disabled
2082
2083         * WebCore.pro:
2084         * platform/graphics/qt/FontPlatformDataQt.cpp:
2085
2086 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
2087
2088         Unreviewed build fix. Add WebCore/workers to the list of paths
2089         searched by the bindings generator perl script.
2090
2091         * GNUmakefile.am:
2092
2093 2009-02-25  Sam Weinig  <sam@webkit.org>
2094
2095         Reviewed by Geoffrey Garen.
2096
2097         Add canvas to the list of RenderObjects that can mark a page as
2098         visually not empty.
2099
2100         * rendering/RenderHTMLCanvas.cpp:
2101         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2102
2103 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
2104
2105         Reviewed by Dave Hyatt.
2106
2107         * rendering/RenderBox.cpp:
2108         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
2109         as RenderMedia with controls always has a layer.
2110
2111 2009-02-25  Dan Bernstein  <mitz@apple.com>
2112
2113         Reviewed by Simon Fraser.
2114
2115         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
2116           <rdar://problem/6618196> Paint very slow when horizontally resizing
2117
2118         Test: fast/gradients/background-clipped.html
2119
2120         * rendering/RenderBoxModelObject.cpp:
2121         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
2122         destination rectangle passed to drawTiledImage() with the dirty
2123         rectangle. This makes it more likely for the destination rect to be
2124         contained in a single tile rect, which results in a faster code path
2125         being taken down the road (just drawing a single tile instead of
2126         tiling).
2127
2128 2009-02-25  Ojan Vafai  <ojan@chromium.org>
2129
2130         Reviewed by Eric Seidel.
2131
2132         Fix test regressions from positionForCoordinates patch.
2133         https://bugs.webkit.org/show_bug.cgi?id=24148
2134
2135         * rendering/RenderBlock.cpp:
2136         (WebCore::positionForPointWithInlineChildren):
2137         Remove ASSERT that placeholder text codepath is hitting.
2138
2139 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
2140
2141         Reviewed by Beth Dakin.
2142
2143         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
2144         https://bugs.webkit.org/show_bug.cgi?id=24143
2145
2146         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
2147         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
2148         Make sure the AXObjectWrapper's have an object before calling them
2149         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
2150
2151         Test: platform/mac-snowleopard/accessibility/table-updating.html
2152
2153         * WebCore.base.exp:
2154         * page/AXObjectCache.cpp:
2155         (WebCore::AXObjectCache::~AXObjectCache):
2156         (WebCore::AXObjectCache::get):
2157         (WebCore::AXObjectCache::getOrCreate):
2158         (WebCore::AXObjectCache::removeAXID):
2159         (WebCore::AXObjectCache::handleActiveDescendantChanged):
2160         (WebCore::AXObjectCache::handleAriaRoleChanged):
2161         * page/AXObjectCache.h:
2162         * page/AccessibilityImageMapLink.cpp:
2163         (WebCore::AccessibilityImageMapLink::parentObject):
2164         * page/AccessibilityListBox.cpp:
2165         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
2166         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
2167         * page/AccessibilityListBoxOption.cpp:
2168         (WebCore::AccessibilityListBoxOption::elementRect):
2169         (WebCore::AccessibilityListBoxOption::parentObject):
2170         * page/AccessibilityObject.cpp:
2171         (WebCore::AccessibilityObject::detach):
2172         (WebCore::AccessibilityObject::parentObjectIfExists):
2173         (WebCore::replacedNodeNeedsCharacter):
2174         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
2175         * page/AccessibilityObject.h:
2176         * page/AccessibilityRenderObject.cpp:
2177         (WebCore::AccessibilityRenderObject::firstChild):
2178         (WebCore::AccessibilityRenderObject::lastChild):
2179         (WebCore::AccessibilityRenderObject::previousSibling):
2180         (WebCore::AccessibilityRenderObject::nextSibling):
2181         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
2182         (WebCore::AccessibilityRenderObject::parentObject):
2183         (WebCore::AccessibilityRenderObject::isAttachment):
2184         (WebCore::AccessibilityRenderObject::headingLevel):
2185         (WebCore::AccessibilityRenderObject::anchorElement):
2186         (WebCore::AccessibilityRenderObject::menuForMenuButton):
2187         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
2188         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
2189         (WebCore::AccessibilityRenderObject::internalLinkElement):
2190         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
2191         (WebCore::AccessibilityRenderObject::titleUIElement):
2192         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2193         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
2194         (WebCore::AccessibilityRenderObject::getDocumentLinks):
2195         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2196         (WebCore::AccessibilityRenderObject::focusedUIElement):
2197         (WebCore::AccessibilityRenderObject::activeDescendant):
2198         (WebCore::AccessibilityRenderObject::observableObject):
2199         (WebCore::AccessibilityRenderObject::childrenChanged):
2200         (WebCore::AccessibilityRenderObject::addChildren):
2201         * page/AccessibilityRenderObject.h:
2202         (WebCore::AccessibilityRenderObject::setRenderObject):
2203         * page/AccessibilityTable.cpp:
2204         (WebCore::AccessibilityTable::addChildren):
2205         (WebCore::AccessibilityTable::headerContainer):
2206         (WebCore::AccessibilityTable::cellForColumnAndRow):
2207         * page/AccessibilityTableCell.cpp:
2208         (WebCore::AccessibilityTableCell::isTableCell):
2209         (WebCore::AccessibilityTableCell::titleUIElement):
2210         * page/AccessibilityTableColumn.cpp:
2211         (WebCore::AccessibilityTableColumn::headerObjectForSection):
2212         * page/AccessibilityTableRow.cpp:
2213         (WebCore::AccessibilityTableRow::isTableRow):
2214         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
2215         * page/mac/AXObjectCacheMac.mm:
2216         (WebCore::AXObjectCache::postNotification):
2217         (WebCore::AXObjectCache::postNotificationToElement):
2218         * page/mac/AccessibilityObjectWrapper.mm:
2219         (textMarkerForVisiblePosition):
2220         (AXLinkElementForNode):
2221         (nsStringForReplacedNode):
2222         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
2223         (-[AccessibilityObjectWrapper accessibilityActionNames]):
2224         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2225         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
2226         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
2227         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
2228         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
2229         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
2230         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
2231         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
2232         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
2233         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
2234         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
2235         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
2236         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
2237
2238 2009-02-25  Beth Dakin  <bdakin@apple.com>
2239
2240         Reviewed by Geoff Garen.
2241
2242         Re-working of <rdar://problem/6487249> repro crash in 
2243         WebCore::CSSParser::parseFillImage copying entire contents of this 
2244         page
2245         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2246
2247         Fixes a bunch of layout test failures I caused!
2248
2249         * css/CSSParser.cpp:
2250         (WebCore::CSSParser::parseValue):
2251         (WebCore::CSSParser::parseContent):
2252         (WebCore::CSSParser::parseFillImage):
2253         (WebCore::CSSParser::parseFontFaceSrc):
2254         (WebCore::CSSParser::parseBorderImage):
2255
2256 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
2257
2258         Reviewed by Eric Seidel.
2259
2260         https://bugs.webkit.org/show_bug.cgi?id=24174
2261         Add more V8 custom bindings.
2262
2263         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
2264         (WebCore::hasCSSPropertyNamePrefix):
2265         (WebCore::cssPropertyName):
2266         (WebCore::NAMED_PROPERTY_GETTER):
2267         (WebCore::NAMED_PROPERTY_SETTER):
2268         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2269         (WebCore::INDEXED_PROPERTY_GETTER):
2270         (WebCore::CALLBACK_FUNC_DECL):
2271         * bindings/v8/custom/V8EventCustom.cpp: Added.
2272         (WebCore::ACCESSOR_SETTER):
2273         (WebCore::ACCESSOR_GETTER):
2274         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2275         (WebCore::NAMED_PROPERTY_DELETER):
2276         (WebCore::NAMED_PROPERTY_SETTER):
2277         (WebCore::NAMED_PROPERTY_GETTER):
2278         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2279         (WebCore::NAMED_PROPERTY_GETTER):
2280         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2281         (WebCore::INDEXED_PROPERTY_GETTER):
2282         (WebCore::NAMED_PROPERTY_GETTER):
2283         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2284         (WebCore::NAMED_PROPERTY_GETTER):
2285         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2286         (WebCore::NAMED_PROPERTY_GETTER):
2287
2288 2009-02-25  Scott Violet  <sky@google.com>
2289
2290         Reviewed by Dave Hyatt.
2291
2292         https://bugs.webkit.org/show_bug.cgi?id=24171
2293         Provides a RenderTheme method for getting the scroll bar size and
2294         changes RenderListBox to use it. RenderTheme returns a size of regular,
2295         and Mac's override to return small. Changes ScrollbarThemeChromium to
2296         use the scrollbarsize of the scrollbar when getting the size
2297         instead of passing in no-args.
2298
2299         * platform/chromium/ScrollbarThemeChromium.cpp:
2300         (WebCore::ScrollbarThemeChromium::trackRect):
2301         (WebCore::ScrollbarThemeChromium::buttonSize):
2302         * rendering/RenderListBox.cpp:
2303         (WebCore::RenderListBox::createScrollbar):
2304         * rendering/RenderTheme.h:
2305         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2306         * rendering/RenderThemeChromiumMac.h:
2307         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2308         * rendering/RenderThemeMac.h:
2309         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2310
2311 2009-02-25  Beth Dakin  <bdakin@apple.com>
2312
2313         Reviewed by Darin Adler.
2314
2315         Fix for <rdar://problem/6487249> repro crash in 
2316         WebCore::CSSParser::parseFillImage copying entire contents of this 
2317         page
2318         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2319
2320         * css/CSSParser.cpp:
2321         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2322
2323 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2324
2325         Fix the Qt build.
2326
2327         * WebCore.pro:
2328
2329 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2330
2331         Gtk build fix. Not reviewed.
2332
2333         Add files to the build per r41218.
2334         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2335
2336         * GNUmakefile.am:
2337         * page/DOMWindow.cpp:
2338
2339 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
2340
2341         Reviewed by Alexey Proskuryakov.
2342
2343         https://bugs.webkit.org/show_bug.cgi?id=24043
2344         When faced with URLs with unsupported protocol on Gtk port,
2345         report the error through an idle function and return true, so
2346         a proper resource handle is created.
2347
2348         * platform/network/soup/ResourceHandleSoup.cpp:
2349         (WebCore::reportUnknownProtocolError):
2350         (WebCore::ResourceHandle::start):
2351
2352 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2353
2354         Windows build fix.
2355         Use struct to forward declare ResourceRequest.
2356
2357         * history/HistoryItem.h:
2358         * inspector/InspectorController.h:
2359         * loader/DocumentThreadableLoader.h:
2360         * loader/FrameLoaderClient.h:
2361         * loader/MainResourceLoader.h:
2362         * loader/SubresourceLoader.h:
2363         * loader/SubresourceLoaderClient.h:
2364         * loader/ThreadableLoader.h:
2365         * loader/WorkerThreadableLoader.h:
2366         * platform/CrossThreadCopier.h:
2367         * platform/network/ResourceHandle.h:
2368         * platform/network/ResourceHandleClient.h:
2369         * platform/network/ResourceRequestBase.h:
2370         * platform/network/cf/ResourceRequestCFNet.h:
2371         * xml/XMLHttpRequest.h:
2372
2373 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2374
2375         Partial Windows build fix.
2376         
2377         * DerivedSources.cpp:
2378         * WebCore.vcproj/WebCore.vcproj:
2379
2380 2009-02-25  Dirk Schulze  <krit@webkit.org>
2381
2382         Reviewed by Oliver Hunt.
2383
2384         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
2385         calculate the behavior of arcTo and draws it with lineTo and arc.
2386
2387         [QT] implement Canvas arcTo
2388         https://bugs.webkit.org/show_bug.cgi?id=23873
2389
2390         * platform/graphics/qt/PathQt.cpp:
2391         (WebCore::Path::addArcTo):
2392
2393 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
2394
2395         Reviewed by Dan Bernstein
2396
2397         Remove idl files from Resources, and sort.
2398         
2399         * WebCore.xcodeproj/project.pbxproj:
2400
2401 2009-02-25  Chris Marrin  <cmarrin@apple.com>
2402
2403         Reviewed by Simon Fraser.
2404
2405         https://bugs.webkit.org/show_bug.cgi?id=23943
2406
2407         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
2408         the window object. Also added WebKitPoint object, which is passed in and out
2409         of these functions.
2410
2411         Test: fast/dom/Window/webkitConvertPoint.html
2412
2413         * DerivedSources.make:
2414         * WebCore.pro:
2415         * WebCore.vcproj/WebCore.vcproj:
2416         * WebCore.xcodeproj/project.pbxproj:
2417         * WebCoreSources.bkl:
2418         * bindings/js/JSDOMWindowBase.cpp:
2419         (jsDOMWindowBaseWebKitPoint):
2420         (setJSDOMWindowBaseWebKitPoint):
2421         * bindings/js/JSWebKitPointConstructor.cpp: Added.
2422         (WebCore::):
2423         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2424         (WebCore::constructWebKitPoint):
2425         (WebCore::JSWebKitPointConstructor::getConstructData):
2426         * bindings/js/JSWebKitPointConstructor.h: Added.
2427         (WebCore::JSWebKitPointConstructor::classInfo):
2428         * dom/Node.cpp:
2429         (WebCore::Node::convertToPage):
2430         (WebCore::Node::convertFromPage):
2431         * dom/Node.h:
2432         * page/DOMWindow.cpp:
2433         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
2434         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
2435         * page/DOMWindow.h:
2436         * page/DOMWindow.idl:
2437         * page/WebKitPoint.h: Added.
2438         (WebCore::WebKitPoint::create):
2439         (WebCore::WebKitPoint::x):
2440         (WebCore::WebKitPoint::y):
2441         (WebCore::WebKitPoint::setX):
2442         (WebCore::WebKitPoint::setY):
2443         (WebCore::WebKitPoint::WebKitPoint):
2444         * page/WebKitPoint.idl: Added.
2445
2446 2009-02-25  Jian Li  <jianli@chromium.org>
2447
2448         Reviewed by Alexey Proskuryakov.
2449
2450         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
2451         https://bugs.webkit.org/show_bug.cgi?id=24145
2452
2453         * platform/CrossThreadCopier.cpp:
2454         * platform/CrossThreadCopier.h:
2455
2456 2009-02-25  David Levin  <levin@chromium.org>
2457
2458         Reviewed by Alexey Proskuryakov.
2459
2460         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
2461         <https://bugs.webkit.org/show_bug.cgi?id=23688>
2462
2463         No observable change in behavior, so no test.
2464
2465         * loader/ThreadableLoader.cpp:
2466         (WebCore::ThreadableLoader::loadResourceSynchronously):
2467         * loader/ThreadableLoaderClientWrapper.h:
2468         (WebCore::ThreadableLoaderClientWrapper::clearClient):
2469         (WebCore::ThreadableLoaderClientWrapper::done):
2470         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
2471         (WebCore::ThreadableLoaderClientWrapper::didFail):
2472         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2473         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
2474         Expose whether the loader is done (based on what callbacks were done).
2475
2476         * loader/WorkerThreadableLoader.cpp:
2477         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2478         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2479         Each loader is given its own mode so that only its callbacks get through the run loop.
2480
2481         The xhr spec says that the readystatechange events are synchronous, so in the case of a
2482         nested sync xhr no readystatechange events should be fired for the outer xhr.
2483
2484         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2485
2486         * loader/WorkerThreadableLoader.h:
2487         (WebCore::WorkerThreadableLoader::create):
2488         (WebCore::WorkerThreadableLoader::done):
2489
2490         * workers/WorkerRunLoop.cpp:
2491         (WebCore::WorkerRunLoop::WorkerRunLoop):
2492         * workers/WorkerRunLoop.h:
2493         (WebCore::WorkerRunLoop::createUniqueId):
2494         Simple method to create a uniqueId on demand with respect to the run loop.
2495
2496         * workers/WorkerThread.h:
2497
2498 2009-02-25  David Levin  <levin@chromium.org>
2499
2500         Reviewed by Alexey Proskuryakov.
2501
2502         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
2503         <https://bugs.webkit.org/show_bug.cgi?id=24089>
2504
2505         Make threadable loader callbacks to happen during the sync load call.
2506
2507         Changes the behavior of sync xhr for insecure redirects in two ways:
2508         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
2509         + Throws a network exception which is what other browsers do and what the spec
2510         says to do (http://www.w3.org/TR/XMLHttpRequest/).
2511
2512         * loader/DocumentThreadableLoader.cpp:
2513         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2514         * loader/DocumentThreadableLoader.h:
2515         * loader/ThreadableLoader.cpp:
2516         (WebCore::ThreadableLoader::loadResourceSynchronously):
2517         * loader/ThreadableLoader.h:
2518         * xml/XMLHttpRequest.cpp:
2519         (WebCore::XMLHttpRequest::XMLHttpRequest):
2520         (WebCore::XMLHttpRequest::loadRequestSynchronously):
2521         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
2522         (WebCore::XMLHttpRequest::didFail):
2523         (WebCore::XMLHttpRequest::didFailRedirectCheck):
2524         * xml/XMLHttpRequest.h:
2525
2526 2009-02-24  Chris Marrin  <cmarrin@apple.com>
2527
2528         Reviewed by David Hyatt.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=23368
2531
2532         Added logic to correctly hit test accelerated layers.
2533
2534         Tests: animations/animation-hit-test-transform.html
2535                animations/animation-hit-test.html
2536                transitions/transition-hit-test-transform.html
2537                transitions/transition-hit-test.html
2538
2539         * page/animation/KeyframeAnimation.cpp:
2540         (WebCore::KeyframeAnimation::animate):
2541         * rendering/RenderLayer.cpp:
2542         (WebCore::RenderLayer::hitTestLayer):
2543         (WebCore::RenderLayer::updateClipRects):
2544         * rendering/RenderLayerBacking.cpp:
2545         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2546
2547 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
2548
2549         Reviewed by Darin Adler.
2550
2551         https://bugs.webkit.org/show_bug.cgi?id=24067
2552         REGRESSION: Crash in WebCore::Document::initSecurityContext
2553
2554         The crash started to happen when we removed a check for frame->document() being null.
2555         However, the original document shouldn't be null here, because it is needed to alias
2556         security origins. So, this patch fixes the crash by correcting security origin behavior.
2557
2558         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
2559         This tests for not crashing, and for inheriting the domain from the document being replaced.
2560         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
2561         domain to remove a prefix from.
2562
2563         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
2564         clearing the frame, so that Document::initSecurityContext() could access the old one.
2565
2566 2009-02-25  Jay Campan  <jcampan@google.com>
2567
2568         Reviewed by Darin Fisher.
2569
2570         https://bugs.webkit.org/show_bug.cgi?id=24066
2571
2572         Items in drop-downs were not painted correctly.  Makes sure the
2573         PopupListBox invalidates in the coordinates of the window as this is
2574         FramelessScrollView::invalidateRect paints to.
2575
2576         * platform/chromium/PopupMenuChromium.cpp:
2577         (WebCore::PopupListBox::invalidateRow):
2578
2579 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2580
2581         Reviewed by Anders Carlsson
2582
2583         https://bugs.webkit.org/show_bug.cgi?id=15081
2584         
2585         Make display:none work for applet, emebed and object elements
2586         by calling rendererIsNeeded() on superclasses.
2587
2588         Tests: fast/replaced/applet-display-none.html
2589                fast/replaced/embed-display-none.html
2590                fast/replaced/object-display-none.html
2591
2592         * html/HTMLAppletElement.cpp:
2593         (WebCore::HTMLAppletElement::rendererIsNeeded):
2594         * html/HTMLElement.cpp:
2595         (WebCore::HTMLElement::rendererIsNeeded):
2596         * html/HTMLEmbedElement.cpp:
2597         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2598         * html/HTMLObjectElement.cpp:
2599         (WebCore::HTMLObjectElement::rendererIsNeeded):
2600
2601 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2602
2603         Reviewed by Dave Hyatt
2604
2605         https://bugs.webkit.org/show_bug.cgi?id=24137
2606         
2607         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
2608         taking perspective and transform-style: preserve-3d into account.
2609         
2610         In order to support transform-style: preserve-3d, which keeps elements in a
2611         3d space, we have to carry along an accumulated matrix in TransformState.
2612         We also need to apply the perspective from the parent, if any, with the
2613         appropriate origin.
2614
2615         * GNUmakefile.am:
2616         * WebCore.base.exp:
2617         * WebCore.pro:
2618         * WebCore.scons:
2619         * WebCore.vcproj/WebCore.vcproj:
2620         * WebCore.xcodeproj/project.pbxproj:
2621         * WebCoreSources.bkl:
2622         * css/CSSComputedStyleDeclaration.cpp:
2623         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2624         * platform/graphics/transforms/TransformationMatrix.cpp:
2625         (WebCore::TransformationMatrix::translate):
2626         (WebCore::TransformationMatrix::translate3d):
2627         (WebCore::TransformationMatrix::translateRight3d):
2628         * platform/graphics/transforms/TransformationMatrix.h:
2629         * rendering/RenderBox.cpp:
2630         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2631         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2632         * rendering/RenderBox.h:
2633         * rendering/RenderLayer.cpp:
2634         (WebCore::RenderLayer::updateTransform):
2635         (WebCore::RenderLayer::perspectiveTransform):
2636         (WebCore::RenderLayer::perspectiveOrigin):
2637         * rendering/RenderLayer.h:
2638         * rendering/RenderLayerBacking.cpp:
2639         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2640         * rendering/RenderLayerCompositor.cpp:
2641         (WebCore::requiresCompositingLayerForTransform):
2642         (WebCore::RenderLayerCompositor::layerHas3DContent):
2643         * rendering/RenderObject.cpp:
2644         (WebCore::RenderObject::localToAbsolute):
2645         (WebCore::RenderObject::absoluteToLocal):
2646         (WebCore::RenderObject::mapLocalToAbsolutePoint):
2647         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2648         * rendering/RenderObject.h:
2649         * rendering/RenderTableCell.cpp:
2650         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
2651         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
2652         * rendering/RenderTableCell.h:
2653         * rendering/RenderView.cpp:
2654         (WebCore::RenderView::mapLocalToAbsolutePoint):
2655         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2656         * rendering/RenderView.h:
2657         * rendering/TransformState.cpp: Added.
2658         (WebCore::TransformState::move):
2659         (WebCore::TransformState::applyTransform):
2660         (WebCore::TransformState::flatten):
2661         * rendering/TransformState.h: Added.
2662         (WebCore::TransformState::):
2663         (WebCore::TransformState::TransformState):
2664         (WebCore::TransformState::move):
2665         * rendering/style/RenderStyle.h:
2666         (WebCore::InheritedFlags::hasPerspective):
2667
2668 2009-02-24  Sam Weinig  <sam@webkit.org>
2669
2670         Reviewed by David Hyatt.
2671
2672         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
2673         Regression (r40837): JavaScript image popup doesn't work
2674
2675         Make the getClientRects and getBoundingClientRect methods return rects
2676         relative to the viewport.
2677
2678         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
2679
2680         * dom/Element.cpp:
2681         (WebCore::Element::getClientRects):
2682         (WebCore::Element::getBoundingClientRect):
2683
2684 2009-02-24  Ojan Vafai  <ojan@chromium.org>
2685
2686         Reviewed by Eric Seidel.
2687
2688         SVG pages don't have a body or an html element! 
2689         Don't return early if there is no body.
2690
2691         * editing/VisiblePosition.cpp:
2692         (WebCore::VisiblePosition::canonicalPosition):
2693
2694 2009-02-23  David Hyatt  <hyatt@apple.com>
2695
2696         Reviewed by Eric Seidel
2697
2698         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
2699         
2700         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
2701         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
2702         reflections or masks).
2703         
2704         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
2705         The only difference is that the clip has to be pushed and popped when painting the object's children.
2706         
2707         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
2708         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
2709         use the new functions.
2710         
2711         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
2712         
2713         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
2714         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
2715         
2716         Masks are now treated like normal flow layers (just like reflections).
2717
2718         A couple of test cases have been added to fast/overflow to test the stacking order. 
2719
2720         * rendering/InlineFlowBox.cpp:
2721         (WebCore::InlineFlowBox::nodeAtPoint):
2722         (WebCore::InlineFlowBox::paint):
2723         * rendering/RenderBlock.cpp:
2724         (WebCore::RenderBlock::repaintOverhangingFloats):
2725         (WebCore::RenderBlock::paint):
2726         (WebCore::RenderBlock::paintChildren):
2727         (WebCore::RenderBlock::paintObject):
2728         (WebCore::RenderBlock::paintFloats):
2729         (WebCore::RenderBlock::insertFloatingObject):
2730         (WebCore::RenderBlock::floatRect):
2731         (WebCore::RenderBlock::lowestPosition):
2732         (WebCore::RenderBlock::rightmostPosition):
2733         (WebCore::RenderBlock::leftmostPosition):
2734         (WebCore::RenderBlock::addOverhangingFloats):
2735         (WebCore::RenderBlock::nodeAtPoint):
2736         (WebCore::RenderBlock::hitTestContents):
2737         * rendering/RenderBox.cpp:
2738         (WebCore::RenderBox::nodeAtPoint):
2739         (WebCore::RenderBox::pushContentsClip):
2740         (WebCore::RenderBox::popContentsClip):
2741         * rendering/RenderBox.h:
2742         (WebCore::RenderBox::paintObject):
2743         * rendering/RenderBoxModelObject.cpp:
2744         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
2745         * rendering/RenderBoxModelObject.h:
2746         * rendering/RenderLayer.cpp:
2747         (WebCore::RenderLayer::paintLayer):
2748         (WebCore::RenderLayer::hitTestLayer):
2749         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2750         (WebCore::RenderLayer::isSelfPaintingLayer):
2751         * rendering/RenderLayer.h:
2752         * rendering/RenderTable.cpp:
2753         (WebCore::RenderTable::paint):
2754         (WebCore::RenderTable::paintObject):
2755         (WebCore::RenderTable::nodeAtPoint):
2756         * rendering/RenderTable.h:
2757         * rendering/RenderTableCell.cpp:
2758         (WebCore::RenderTableCell::paint):
2759         * rendering/RenderTableRow.cpp:
2760         (WebCore::RenderTableRow::nodeAtPoint):
2761         (WebCore::RenderTableRow::paint):
2762         * rendering/RenderTableRow.h:
2763         * rendering/RenderTableSection.cpp:
2764         (WebCore::RenderTableSection::paint):
2765         (WebCore::RenderTableSection::paintObject):
2766         (WebCore::RenderTableSection::nodeAtPoint):
2767         * rendering/RenderTableSection.h:
2768         * rendering/RenderTreeAsText.cpp:
2769         (WebCore::write):
2770         (WebCore::writeLayers):
2771
2772 2009-02-24  David Levin  <levin@chromium.org>
2773
2774         Reviewed by NOBODY (build fix).
2775
2776         Attempted build fix for wx-mac.
2777
2778         * WebCoreSources.bkl:
2779
2780 2009-02-24  David Levin  <levin@chromium.org>
2781
2782         Reviewed by NOBODY (build fix).
2783
2784         Attempted build fixes for qt-linux and wx-mac.
2785
2786         * WebCore.pro:
2787         * webcore-base.bkl:
2788
2789 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
2790
2791         Reviewed by Sam Weinig.
2792
2793         Fix null pointer error. If the node is the Document, then ownerDocument() 
2794         returns null, document() does not.
2795
2796         * editing/VisiblePosition.cpp:
2797         (WebCore::VisiblePosition::canonicalPosition):
2798
2799 2009-02-24  Jian Li  <jianli@chromium.org>
2800
2801         Reviewed by NOBODY (attempted build fixes).
2802
2803         Fix build break for Windows and Linux.
2804
2805         * GNUmakefile.am:
2806         * WebCore.vcproj/WebCore.vcproj:
2807
2808 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2809
2810         Reviewed by Eric Seidel.
2811
2812         https://bugs.webkit.org/show_bug.cgi?id=24131
2813         Fix-up COM/RefCounted dichotomy in Chromium port.
2814
2815         * page/chromium/AccessibilityObjectWrapper.h:
2816         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2817         explicit setting of recount.
2818
2819 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2820
2821         Reviewed by Eric Seidel.
2822
2823         https://bugs.webkit.org/show_bug.cgi?id=24141
2824         Add clarity to V8 interceptor helper function.
2825
2826         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2827         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2828         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2829         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2830         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2831
2832 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2833
2834         Reviewed by Eric Seidel
2835
2836         Minor numeric cleanup: convert float literals to doubles.
2837         
2838         * platform/graphics/transforms/RotateTransformOperation.cpp:
2839         (WebCore::RotateTransformOperation::blend):
2840
2841 2009-02-24  Mark Mentovai  <mark@chromium.org>
2842
2843         Reviewed by Eric Seidel.
2844
2845         https://bugs.webkit.org/show_bug.cgi?id=24139
2846         Add missing include.
2847
2848         * bindings/v8/ScriptInstance.h:
2849
2850 2009-02-24  Jian Li  <jianli@chromium.org>
2851
2852         Reviewed by Alexey Proskuryakov.
2853
2854         Move worker related files from dom directory to worker directory under WebCore.
2855         https://bugs.webkit.org/show_bug.cgi?id=24123
2856
2857         * DerivedSources.make:
2858         * GNUmakefile.am:
2859         * WebCore.pro:
2860         * WebCore.scons:
2861         * WebCore.vcproj/MigrateIDLAndScripts:
2862         * WebCore.vcproj/WebCore.vcproj:
2863         * WebCore.xcodeproj/project.pbxproj:
2864         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2865         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2866         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2867         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2868         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2869         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2870         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2871         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2872         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2873         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2874         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2875         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2876         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2877         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2878         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2879         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2880         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2881         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2882         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2883         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2884
2885 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2886
2887         Reviewed by Dave Hyatt.
2888
2889         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2890         around divs inside editable regions.
2891         https://bugs.webkit.org/show_bug.cgi?id=23605
2892
2893         Fix clicks outside editable regions from focusing the editable region.
2894         https://bugs.webkit.org/show_bug.cgi?id=23607
2895
2896         Removed editing/selection/contenteditable-click-outside.html as it's
2897         not as useful as our new tests.
2898
2899         Clean up RenderBlock::positionForCoordinates to remove dead code,
2900         duplicate code, and generally make it more readable.
2901
2902         Tests: editing/selection/click-in-margins-inside-editable-div.html
2903                editing/selection/click-in-padding-with-multiple-line-boxes.html
2904                editing/selection/click-outside-editable-div.html
2905
2906         * editing/VisiblePosition.cpp:
2907         (WebCore::VisiblePosition::canonicalPosition):
2908         * rendering/RenderBlock.cpp:
2909         (WebCore::positionForPointRespectingEditingBoundaries):
2910         (WebCore::positionForPointWithInlineChildren):
2911         (WebCore::RenderBlock::positionForCoordinates):
2912         (WebCore::RenderBlock::updateFirstLetter):
2913
2914 2009-02-24  Sam Weinig  <sam@webkit.org>
2915
2916         Reviewed by Geoffrey Garen.
2917
2918         Related to <rdar://problem/6590295>
2919         Allow disabling javascript: urls.
2920
2921         * WebCore.base.exp:
2922         * html/HTMLAnchorElement.cpp:
2923         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2924         * loader/FrameLoader.cpp:
2925         (WebCore::FrameLoader::executeIfJavaScriptURL):
2926         * page/Page.cpp:
2927         (WebCore::Page::Page):
2928         (WebCore::Page::setJavaScriptURLsAreAllowed):
2929         (WebCore::Page::javaScriptURLsAreAllowed):
2930         * page/Page.h:
2931
2932 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2933
2934         Fix build when ACCELERATED_COMPOSITING is turned on
2935         (overflowList() -> normalFlowList()).
2936     
2937         * rendering/RenderLayerBacking.cpp:
2938         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2939         (WebCore::RenderLayerBacking::paintIntoLayer):
2940         * rendering/RenderLayerCompositor.cpp:
2941         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2942         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2943         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2944         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2945         (WebCore::RenderLayerCompositor::layerHas3DContent):
2946
2947 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2948
2949         Reviewed by Darin Adler
2950         
2951         https://bugs.webkit.org/show_bug.cgi?id=24135
2952         
2953         Round the FloatPoint returned by absoluteToLocal(), rather than
2954         truncating it.
2955
2956         * dom/MouseRelatedEvent.cpp:
2957         (WebCore::MouseRelatedEvent::receivedTarget):
2958
2959 2009-02-24  Beth Dakin  <bdakin@apple.com>
2960
2961         Reviewed by Sam Weinig.
2962
2963         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
2964         Ordered list item marker misaligned when line height is not 1.2 
2965         -and corresponding <rdar://problem/6602506>
2966
2967         This is a regression from http://trac.webkit.org/changeset/40880 
2968         where createInlineBox was taken off of RenderObject and moved to 
2969         RenderBox. The problem was that the RenderBox version still needs 
2970         to be virtual because there is still an existing implementation in 
2971         RenderListMarker. 
2972
2973         * rendering/RenderBox.h:
2974         * rendering/RenderListMarker.cpp:
2975         (WebCore::RenderListMarker::createInlineBox):
2976         * rendering/RenderListMarker.h:
2977
2978 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2979
2980         Reviewed by Eric Seidel.
2981
2982         https://bugs.webkit.org/show_bug.cgi?id=24128
2983         Upstream more V8 custom bindings: constructors, XSLTProcessor.
2984
2985         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
2986         (WebCore::CALLBACK_FUNC_DECL):
2987         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
2988         (WebCore::CALLBACK_FUNC_DECL):
2989         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
2990         (WebCore::CALLBACK_FUNC_DECL):
2991         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
2992         (WebCore::CALLBACK_FUNC_DECL):
2993         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
2994         (WebCore::CALLBACK_FUNC_DECL):
2995         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
2996         (WebCore::CALLBACK_FUNC_DECL):
2997
2998 2009-02-24  David Levin  <levin@chromium.org>
2999
3000         Reviewed by Alexey Proskuryakov.
3001
3002         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
3003         <https://bugs.webkit.org/show_bug.cgi?id=24090>
3004
3005         No observable change in behavior, so no test.
3006
3007         * dom/WorkerMessagingProxy.cpp:
3008         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
3009         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
3010         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
3011
3012         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
3013
3014         * dom/WorkerMessagingProxy.h:
3015         * loader/ThreadableLoader.cpp:
3016         (WebCore::ThreadableLoader::create):
3017         * loader/WorkerThreadableLoader.cpp:
3018         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
3019         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
3020         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
3021         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
3022         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
3023         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
3024         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
3025         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3026         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
3027         Changed these methods to post task using a mode.
3028
3029         * loader/WorkerThreadableLoader.h:
3030         (WebCore::WorkerThreadableLoader::create):
3031
3032 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
3033
3034         Reviewed by Darin Adler.
3035
3036         https://bugs.webkit.org/show_bug.cgi?id=24091
3037         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
3038
3039         Test: http/tests/appcache/access-via-redirect.php
3040
3041         * loader/appcache/ApplicationCacheGroup.cpp:
3042         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
3043         not the original one.
3044
3045 2009-02-24  Jian Li  <jianli@chromium.org>
3046
3047         Reviewed by Alexey Proskuryakov.
3048
3049         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
3050         https://bugs.webkit.org/show_bug.cgi?id=24112
3051
3052         * bindings/js/WorkerScriptController.cpp:
3053         * dom/WorkerContext.cpp:
3054
3055 2009-02-23  Antti Koivisto  <antti@apple.com>
3056
3057         Reviewed by Oliver Hunt.
3058
3059         <rdar://problem/6613796> Extended text codecs registered on webview creation
3060
3061         Comparing a text encoding with string "GBK" ended up constructing
3062         TextEncoding("GBK") which in turn initialized all extended
3063         text codecs.
3064
3065         * platform/text/TextCodecICU.cpp:
3066         (WebCore::TextCodecICU::decode):
3067
3068 2009-02-23  Sam Weinig  <sam@webkit.org>
3069
3070         Fix Qt build.
3071
3072         * bridge/qt/qt_runtime.cpp:
3073         (JSC::Bindings::valueRealType):
3074
3075 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
3076
3077         Reviewed by Darin Adler.
3078
3079         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
3080
3081         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
3082         element created with createElement could have a wrong nodeName (createElement sets the string as the
3083         localName without checking for a prefix).
3084
3085         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
3086         and will always succeed.
3087         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
3088         to ensure that).
3089
3090         Test: fast/dom/cloneNode.html
3091
3092         * dom/Element.cpp:
3093         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
3094         always return an element.
3095
3096         * html/HTMLElement.cpp:
3097         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
3098
3099 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
3100
3101         Reviewed by Eric Seidel.
3102
3103         https://bugs.webkit.org/show_bug.cgi?id=24109
3104         Upstream V8 Script abstractions, all except ScriptController.
3105
3106         * bindings/v8/ScriptCachedFrameData.h: Added.
3107         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
3108         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
3109         (WebCore::ScriptCachedFrameData::restore):
3110         (WebCore::ScriptCachedFrameData::clear):
3111         (WebCore::ScriptCachedFrameData::domWindow):
3112         * bindings/v8/ScriptCallFrame.cpp: Added.
3113         (WebCore::ScriptCallFrame::ScriptCallFrame):
3114         (WebCore::ScriptCallFrame::~ScriptCallFrame):
3115         (WebCore::ScriptCallFrame::argumentAt):
3116         * bindings/v8/ScriptCallFrame.h: Added.
3117         (WebCore::ScriptCallFrame::functionName):
3118         (WebCore::ScriptCallFrame::sourceURL):
3119         (WebCore::ScriptCallFrame::lineNumber):
3120         (WebCore::ScriptCallFrame::argumentCount):
3121         * bindings/v8/ScriptCallStack.cpp: Added.
3122         (WebCore::ScriptCallStack::ScriptCallStack):
3123         (WebCore::ScriptCallStack::~ScriptCallStack):
3124         (WebCore::ScriptCallStack::at):
3125         * bindings/v8/ScriptCallStack.h: Added.
3126         (WebCore::ScriptCallStack::size):
3127         * bindings/v8/ScriptInstance.cpp: Added.
3128         (WebCore::V8ScriptInstance::V8ScriptInstance):
3129         (WebCore::V8ScriptInstance::~V8ScriptInstance):
3130         (WebCore::V8ScriptInstance::instance):
3131         (WebCore::V8ScriptInstance::clear):
3132         (WebCore::V8ScriptInstance::set):
3133         * bindings/v8/ScriptInstance.h: Added.
3134         (WebCore::V8ScriptInstance::create):
3135         * bindings/v8/ScriptSourceCode.h: Added.
3136         (WebCore::ScriptSourceCode::ScriptSourceCode):
3137         (WebCore::ScriptSourceCode::isEmpty):
3138         (WebCore::ScriptSourceCode::source):
3139         (WebCore::ScriptSourceCode::url):
3140         (WebCore::ScriptSourceCode::startLine):
3141         * bindings/v8/ScriptState.h: Added.
3142         (WebCore::ScriptState::hadException):
3143         (WebCore::ScriptState::setException):
3144         (WebCore::ScriptState::exception):
3145         * bindings/v8/ScriptString.h: Added.
3146         (WebCore::ScriptString::ScriptString):
3147         (WebCore::ScriptString::operator String):
3148         (WebCore::ScriptString::isNull):
3149         (WebCore::ScriptString::size):
3150         (WebCore::ScriptString::operator=):
3151         (WebCore::ScriptString::operator+=):
3152         * bindings/v8/ScriptValue.cpp: Added.
3153         (WebCore::ScriptValue::getString):
3154         * bindings/v8/ScriptValue.h: Added.
3155         (WebCore::ScriptValue::ScriptValue):
3156         (WebCore::ScriptValue::operator=):
3157         (WebCore::ScriptValue::operator==):
3158         (WebCore::ScriptValue::operator!=):
3159         (WebCore::ScriptValue::isNull):
3160         (WebCore::ScriptValue::isUndefined):
3161         (WebCore::ScriptValue::clear):
3162         (WebCore::ScriptValue::~ScriptValue):
3163         (WebCore::ScriptValue::v8Value):
3164
3165 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3166
3167         Reviewed by Timothy Hatcher.
3168
3169         https://bugs.webkit.org/show_bug.cgi?id=24106
3170         The Qt port is crashing on exit because the tear down procedure involves
3171         the WebCore::InspectorController trying to access the JS execution context
3172         for a page that is being deleted.  This patch amends the inspector so
3173         that it does not try and access the execution context of the WebCore::Page
3174         in the midst of deletion.
3175
3176         * inspector/InspectorController.cpp:
3177         (WebCore::InspectorController::inspectedPageDestroyed):
3178         (WebCore::InspectorController::stopUserInitiatedProfiling):
3179
3180 2009-02-23  David Levin  <levin@chromium.org>
3181
3182         Reviewed by Alexey Proskuryakov.
3183
3184         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
3185         <https://bugs.webkit.org/show_bug.cgi?id=24088>
3186
3187         No observable change in behavior, so no test.
3188
3189         * loader/DocumentThreadableLoader.cpp:
3190         (WebCore::DocumentThreadableLoader::create):
3191         * loader/ThreadableLoaderClient.h:
3192         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
3193         * loader/ThreadableLoaderClientWrapper.h:
3194         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
3195         * loader/WorkerThreadableLoader.cpp:
3196         (WebCore::workerContextDidFailRedirectCheck):
3197         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
3198         * loader/WorkerThreadableLoader.h:
3199         * xml/XMLHttpRequest.cpp:
3200         (WebCore::XMLHttpRequest::didFinishLoading):
3201         * xml/XMLHttpRequest.h:
3202
3203 2009-02-23  David Levin  <levin@chromium.org>
3204
3205         Reviewed by Alexey Proskuryakov.
3206
3207         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
3208         <https://bugs.webkit.org/show_bug.cgi?id=24047>
3209
3210         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
3211         using only MessageQueue::waitForMessageFilteredWithTimeout instead
3212         of three different MessageQueue methods.
3213
3214         No observable change in behavior, so no test.
3215
3216         * dom/WorkerRunLoop.cpp:
3217         (WebCore::ModePredicate::operator()):
3218         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
3219         (WebCore::WorkerRunLoop::runInMode):
3220         * dom/WorkerRunLoop.h:
3221
3222 2009-02-23  David Hyatt  <hyatt@apple.com>
3223
3224         In preparation for making layers for multicol objects (so that they can properly split child layers
3225         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
3226         of RenderLayer to use the term "normal flow" instead.
3227
3228         Reviewed by Cameron Zwarich
3229
3230         * rendering/RenderLayer.cpp:
3231         (WebCore::RenderLayer::RenderLayer):
3232         (WebCore::RenderLayer::~RenderLayer):
3233         (WebCore::RenderLayer::setHasVisibleContent):
3234         (WebCore::RenderLayer::enclosingCompositingLayer):
3235         (WebCore::RenderLayer::addChild):
3236         (WebCore::RenderLayer::removeChild):
3237         (WebCore::RenderLayer::paintLayer):
3238         (WebCore::RenderLayer::hitTestLayer):
3239         (WebCore::RenderLayer::dirtyNormalFlowList):
3240         (WebCore::RenderLayer::updateNormalFlowList):
3241         (WebCore::RenderLayer::collectLayers):
3242         (WebCore::RenderLayer::updateLayerListsIfNeeded):
3243         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
3244         (WebCore::RenderLayer::styleChanged):
3245         * rendering/RenderLayer.h:
3246         (WebCore::RenderLayer::isNormalFlowOnly):
3247         (WebCore::RenderLayer::normalFlowList):
3248         * rendering/RenderTreeAsText.cpp:
3249         (WebCore::writeLayers):
3250
3251 2009-02-23  David Hyatt  <hyatt@apple.com>
3252
3253         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
3254         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
3255         column rules (rather than ending up above the background of the box but behind the column rules).
3256
3257         Reviewed by Eric Seidel
3258
3259         Added fast/multicol/column-rules-stacking.html
3260
3261         * rendering/RenderBlock.cpp:
3262         (WebCore::RenderBlock::paintColumnRules):
3263         (WebCore::RenderBlock::paintColumnContents):
3264         (WebCore::RenderBlock::paintObject):
3265         * rendering/RenderBlock.h:
3266
3267 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3268
3269         Reviewed by David Hyatt.
3270
3271         No testcases have been added or modified since this patch should not result in
3272         a behavior change for ports that have layout tests enabled.
3273
3274         Currently, the implementation of GraphicsContext::drawLineForText amongst
3275         the various ports differ in that some of them are honoring the context's
3276         strokeStyle when drawing a text-decoration and some of them are not.
3277         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3278         but the Cairo implementation does and has an explicit workaround that
3279         sets the strokeStyle() temporarily.
3280
3281         This patch fixes so that all ports are consistent by explicitly making sure
3282         to set the GraphicsContext strokeStyle to SolidStroke whenever
3283         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3284         should always use a solid stroke.
3285
3286         This patch addresses these bugs:
3287         https://bugs.webkit.org/show_bug.cgi?id=19364
3288         https://bugs.webkit.org/show_bug.cgi?id=15659
3289
3290         * rendering/InlineFlowBox.cpp:
3291         (WebCore::InlineFlowBox::paintTextDecorations):
3292         * rendering/InlineTextBox.cpp:
3293         (WebCore::InlineTextBox::paintDecoration):
3294
3295 2009-02-23  Scott Violet  <sky@google.com>
3296
3297         Reviewed by Eric Seidel.
3298
3299         https://bugs.webkit.org/show_bug.cgi?id=24098
3300         Bugs in ClipboardChromium
3301
3302         Fixes the following bugs in ClipboardChromium:
3303         * It's possible for the extension to be empty, resulting in a bad file
3304           name, for example, 'foo.' or just '.'.
3305         * We weren't restricting the size of the file to MAX_PATH.
3306         * We weren't removing characters that are invalid for file system names.
3307
3308         * platform/chromium/ClipboardChromium.cpp:
3309         (WebCore::writeImageToDataObject):
3310         * platform/chromium/ClipboardChromium.h:
3311         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3312         (WebCore::ClipboardChromium::validateFileName):
3313         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3314         (WebCore::ClipboardChromium::validateFileName):
3315         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3316         (WebCore::isInvalidFileCharacter):
3317         (WebCore::ClipboardChromium::validateFileName):
3318
3319 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3320
3321         Reviewed by Simon Hausmann.
3322
3323         Fix the Copyright notices in a few files
3324
3325         * platform/qt/RenderThemeQt.h:
3326
3327 2009-02-23  Xan Lopez  <xan@gnome.org>
3328
3329         Reviewed by Alexey Proskuryakov.
3330
3331         https://bugs.webkit.org/show_bug.cgi?id=22624
3332         [SOUP][GTK] Need API to get SoupSession from WebKit.
3333
3334         Allow to retrieve the Soup session and modify the code to take
3335         into account users changing features on it.
3336
3337         * platform/network/ResourceHandle.h:
3338         * platform/network/soup/CookieJarSoup.cpp:
3339         (WebCore::defaultCookieJar):
3340         (WebCore::setDefaultCookieJar):
3341         * platform/network/soup/CookieJarSoup.h:
3342         * platform/network/soup/ResourceHandleSoup.cpp:
3343         (WebCore::createSoupSession):
3344         (WebCore::ensureSessionIsInitialized):
3345         (WebCore::ResourceHandle::startHttp):
3346         (WebCore::ResourceHandle::cancel):
3347         (WebCore::ResourceHandle::defaultSession):
3348
3349 2009-02-23  Xan Lopez  <xan@gnome.org>
3350
3351         Reviewed by Alexey Proskuryakov.
3352
3353         https://bugs.webkit.org/show_bug.cgi?id=22624
3354         [SOUP][GTK] Need API to get SoupSession from WebKit.
3355
3356         Remove CURL support.
3357
3358         * GNUmakefile.am:
3359
3360 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3361
3362         Reviewed by Mark Rowe.
3363
3364         Test: fast/dom/empty-hash-and-search.html
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=21147
3367         hash property returns incorrect value for links w/o hash
3368
3369         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
3370
3371         * platform/KURL.cpp:
3372         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
3373         (WebCore::KURL::prettyURL): Append the query with the question mark.
3374
3375         * page/Location.cpp:
3376         (WebCore::Location::search): Return an empty string if query is empty or missing.
3377         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
3378
3379         * dom/WorkerLocation.cpp:
3380         (WebCore::WorkerLocation::search):
3381         (WebCore::WorkerLocation::hash):
3382         Match document.location fixes above.
3383
3384         * html/HTMLAnchorElement.cpp:
3385         (WebCore::HTMLAnchorElement::hash):
3386         (WebCore::HTMLAnchorElement::search):
3387         Return an empty string for empty and missing parts.
3388
3389 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3390
3391         Reviewed by Darin Adler.
3392
3393         https://bugs.webkit.org/show_bug.cgi?id=20184
3394         SELECT with no name generates invalid query string
3395
3396         Test: fast/forms/select-no-name.html
3397
3398         * html/HTMLSelectElement.cpp:
3399         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
3400
3401 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3402
3403         Apply review comments for the previous check-in (forgot to save the file, oops).
3404
3405         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
3406
3407 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3408
3409         Reviewed by Darin Adler.
3410
3411         https://bugs.webkit.org/show_bug.cgi?id=15707
3412         Crash when manipulating document from within an iframe onload function
3413
3414         Test: fast/dom/onload-open.html
3415
3416         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
3417         the current node, because anything can happen when dispatching events.
3418
3419 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3420
3421         Reviewed by Darin Adler.
3422
3423         https://bugs.webkit.org/show_bug.cgi?id=18970
3424         Numerically named input fields cause document.forms loop problems
3425
3426         Test: fast/forms/numeric-input-name.html
3427
3428         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
3429         latter overrides properties.
3430
3431 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3432
3433         Reviewed by Sam Weinig.
3434
3435         https://bugs.webkit.org/show_bug.cgi?id=24059
3436         Tokenizer::write() return value is never used
3437
3438         * dom/Tokenizer.h:
3439         * dom/XMLTokenizer.cpp:
3440         (WebCore::XMLTokenizer::write):
3441         * dom/XMLTokenizer.h:
3442         * html/HTMLTokenizer.cpp:
3443         (WebCore::HTMLTokenizer::write):
3444         * html/HTMLTokenizer.h:
3445         * loader/FTPDirectoryDocument.cpp:
3446         (WebCore::FTPDirectoryTokenizer::write):
3447         * loader/ImageDocument.cpp:
3448         (WebCore::ImageTokenizer::write):
3449         * loader/MediaDocument.cpp:
3450         (WebCore::MediaTokenizer::write):
3451         * loader/PluginDocument.cpp:
3452         (WebCore::PluginTokenizer::write):
3453         * loader/TextDocument.cpp:
3454         (WebCore::TextTokenizer::write):
3455         Made write() return void, not bool.
3456
3457 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
3458
3459         Reviewed by Sam Weinig.
3460
3461         Updated for JavaScriptCore changes to timeout checking.
3462
3463         * bindings/js/JSCustomPositionCallback.cpp:
3464         (WebCore::JSCustomPositionCallback::handleEvent):
3465         * bindings/js/JSCustomPositionErrorCallback.cpp:
3466         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3467         * bindings/js/JSCustomSQLStatementCallback.cpp:
3468         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3469         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3470         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3471         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3472         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3473         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3474         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3475         * bindings/js/JSCustomVoidCallback.cpp:
3476         (WebCore::JSCustomVoidCallback::handleEvent):
3477         * bindings/js/JSCustomXPathNSResolver.cpp:
3478         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3479         * bindings/js/JSDOMWindowBase.cpp:
3480         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
3481         (WebCore::JSDOMWindowBase::commonJSGlobalData):
3482         * bindings/js/JSEventListener.cpp:
3483         (WebCore::JSAbstractEventListener::handleEvent):
3484         * bindings/js/ScheduledAction.cpp:
3485         (WebCore::ScheduledAction::executeFunctionInContext):
3486         * bindings/js/ScriptController.cpp:
3487         (WebCore::ScriptController::evaluate):
3488         * bindings/js/WorkerScriptController.cpp:
3489         (WebCore::WorkerScriptController::evaluate):
3490         (WebCore::WorkerScriptController::forbidExecution):
3491         * bindings/objc/WebScriptObject.mm:
3492         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3493         (-[WebScriptObject evaluateWebScript:]):
3494         * bridge/NP_jsobject.cpp:
3495         (_NPN_InvokeDefault):
3496         (_NPN_Invoke):
3497         (_NPN_Evaluate):
3498         (_NPN_Construct):
3499         * bridge/jni/jni_jsobject.mm:
3500         (JavaJSObject::call):
3501         (JavaJSObject::eval):
3502
3503 2009-02-21  Hironori Bono  <hbono@chromium.org>
3504
3505         Reviewed by Alexey Proskuryakov.
3506
3507         https://bugs.webkit.org/show_bug.cgi?id=23786
3508         [Chromium] line-break characters in a complex text are treated as zero-width spaces
3509
3510         This change prevents the UniscribeHelper class from treating the line-break characters
3511         as whitespaces.
3512
3513         Tests: fast/text/international/bidi-linebreak-001.html
3514                fast/text/international/bidi-linebreak-002.html
3515                fast/text/international/bidi-linebreak-003.html
3516
3517         * platform/graphics/chromium/UniscribeHelper.cpp:
3518         (WebCore::UniscribeHelper::adjustSpaceAdvances):
3519         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
3520         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
3521         so does when Chromium renders a simple text.
3522
3523 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
3524
3525         Reviewed by Alexey Proskuryakov.
3526
3527         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
3528
3529         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
3530         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
3531         unneeded.
3532
3533         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
3534         enables us to use some generated QualifiedName.
3535
3536         * bindings/js/JSOptionConstructor.cpp:
3537         (WebCore::constructHTMLOptionElement):
3538         * dom/Document.cpp:
3539         (WebCore::Document::setTitle):
3540         * dom/XMLTokenizer.cpp:
3541         (WebCore::createXHTMLParserErrorHeader):
3542         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3543         * editing/CompositeEditCommand.cpp:
3544         (WebCore::createBlockPlaceholderElement):
3545         * editing/htmlediting.cpp:
3546         (WebCore::createTabSpanElement):
3547         * html/HTMLSelectElement.cpp:
3548         (WebCore::HTMLSelectElement::setLength):
3549         * loader/FTPDirectoryDocument.cpp:
3550         (WebCore::FTPDirectoryTokenizer::appendEntry):
3551         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
3552         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
3553         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
3554         * loader/ImageDocument.cpp:
3555         (WebCore::ImageDocument::createDocumentStructure):
3556         * loader/MediaDocument.cpp:
3557         (WebCore::MediaTokenizer::createDocumentStructure):
3558         * loader/PluginDocument.cpp:
3559         (WebCore::PluginTokenizer::createDocumentStructure):
3560         * loader/TextDocument.cpp:
3561         (WebCore::TextTokenizer::write):
3562         * page/Frame.cpp:
3563         (WebCore::Frame::selectionComputedStyle):
3564         (WebCore::Frame::styleForSelectionStart):
3565         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
3566
3567         * xml/XPathFunctions.cpp:
3568         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
3569         * page/DragController.cpp:
3570         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
3571
3572 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3573
3574         Reviewed by Eric Seidel.
3575
3576         https://bugs.webkit.org/show_bug.cgi?id=24060
3577         Fix up to accommodate for CanvasPixelArray return.
3578
3579         * platform/graphics/skia/ImageBufferSkia.cpp:
3580         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
3581         (WebCore::ImageBuffer::putImageData): Ditto.
3582
3583 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3584
3585         Simon Fraser
3586
3587         https://bugs.webkit.org/show_bug.cgi?id=24042
3588         Bug 24042: MediaPlayer should cache plug-in proxy
3589
3590         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
3591         MediaPlayer will always have created the private media player object before
3592         the plug-in is instantiated and calls back with the proxy object. This is not
3593         true on all platforms because of threading latency, so MediaPlayer should
3594         cache the plug-in proxy so it can pass it to the media engine at a later time.
3595
3596         * platform/graphics/MediaPlayer.cpp:
3597         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
3598         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
3599         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
3600         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
3601         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
3602         (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
3603         * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
3604
3605 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3606
3607         Simon Fraser.
3608
3609         https://bugs.webkit.org/show_bug.cgi?id=24063
3610         Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element