Reviewed by Maciej.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
2
3         Reviewed by Maciej.
4
5         http://bugs.webkit.org/show_bug.cgi?id=11517
6         REGRESSION: Flash clicks/interactivity not working properly
7
8         * bridge/mac/FrameMac.mm:
9         (WebCore::FrameMac::handleMouseMoveEvent):
10         (WebCore::FrameMac::handleMouseReleaseEvent):
11         Restore parts of event dispatching that were removed when fixing
12         bug 7323 - just bypass those for subframes.
13
14 2006-11-05  Darin Adler  <darin@apple.com>
15
16         - quick attempt to fix the no-SVG build
17
18         * platform/graphics/svg/SVGResource.cpp:
19         * platform/graphics/svg/SVGResource.h:
20         * platform/graphics/svg/SVGResourceClipper.cpp:
21         * platform/graphics/svg/SVGResourceClipper.h:
22         * platform/graphics/svg/SVGResourceImage.h:
23         * platform/graphics/svg/SVGResourceMarker.cpp:
24         * platform/graphics/svg/SVGResourceMarker.h:
25         * platform/graphics/svg/SVGResourceMasker.cpp:
26         * platform/graphics/svg/SVGResourceMasker.h:
27         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
28         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
29         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
30         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
31         Added #ifdef SVG_SUPPORT to these files.
32
33 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
34
35         Reviewed & landed by Maciej.
36
37         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
38
39         * platform/win/ResourceLoaderWin.cpp:
40         (WebCore::transferJobStatusCallback):
41         (WebCore::ResourceLoader::start):
42
43 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
44
45         Reviewed by Oliver.
46
47         - moved FormData and FormDataStream to platform/network directory
48
49         * WebCore.xcodeproj/project.pbxproj:
50         * bridge/mac/WebCoreFrameBridge.mm:
51         * loader/FormData.cpp: Removed.
52         * loader/FormData.h: Removed.
53         * loader/mac/FormDataStream.h: Removed.
54         * loader/mac/FormDataStream.m: Removed.
55         * loader/mac/FrameLoaderMac.mm:
56         * loader/mac/SubresourceLoaderMac.mm:
57         * platform/network/mac/FormDataStreamMac.h: Added.
58         * platform/network/mac/FormDataStreamMac.mm: Added.
59         * platform/network/mac/ResourceRequestMac.mm:
60
61 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
62
63         Fix build breaks
64
65         * loader/DocumentLoader.h:
66         * platform/win/ScreenWin.cpp:
67
68 2006-11-05  Darin Adler  <darin@apple.com>
69
70         Reviewed by Geoff.
71
72         - more preparation for splitting up Frame into sub-pieces
73         - removed unnecessary includes from Frame.h
74
75         * page/Frame.h: Removed unneeded includes and forward declarations.
76         Added additional forward declarations. Removed the constant
77         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
78         Created sections of functions to be moved into Chrome, Editor,
79         EventHandler, FrameLoader, SelectionController, and the Platform
80         directory, as well as marking one function for deletion.
81
82         * page/FramePrivate.h: Removed the definition of the constructor and
83         destructor and removed unnecessary includes.
84
85         * page/FrameView.h: Removed unneeded forward declarations and friend
86         declarations. Created a section of functions and data to be moved into
87         EventHandler.
88
89         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
90         Created sections of functions and data to be moved into Chrome,
91         Editor, EventHandler, FrameLoader, and the Platform directory.
92
93         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
94         Removed unused methods areScrollbarsVisible,
95         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
96
97         * page/Frame.cpp:
98         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
99         to include KURL.h just for the KURL default constructor.
100         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
101         (WebCore::FramePrivate::~FramePrivate): Ditto.
102
103         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
104         booleans, scrollbarMoved and cleared funcitons.
105         (WebCore::FrameView::clear): Moved the code from the cleared
106         function in here.
107         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
108
109         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
110         for changes to header.
111
112         * editing/SelectionController.cpp:
113         (WebCore::SelectionController::setSelection):
114         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
115         Moved NoXPosForVerticalArrowNavigation into this file.
116
117         * bindings/js/kjs_events.cpp:
118         * bindings/js/kjs_html.cpp:
119         * bindings/js/kjs_window.cpp:
120         * bridge/mac/WebCoreAXObject.mm:
121         * bridge/mac/WebCoreFrameBridge.mm:
122         * css/cssstyleselector.cpp:
123         * dom/Document.cpp:
124         * dom/Element.cpp:
125         * dom/EventTargetNode.cpp:
126         * dom/MouseRelatedEvent.cpp:
127         * dom/XMLTokenizer.cpp:
128         * html/HTMLBaseElement.cpp:
129         * html/HTMLDocument.cpp:
130         * html/HTMLEmbedElement.cpp:
131         * html/HTMLFrameElementBase.cpp:
132         * html/HTMLGenericFormElement.cpp:
133         * html/HTMLObjectElement.cpp:
134         * html/HTMLTokenizer.cpp:
135         * loader/mac/FrameLoaderMac.mm:
136         * page/PageState.cpp:
137         * rendering/RenderApplet.cpp:
138         * rendering/RenderBlock.cpp:
139         * rendering/RenderLayer.cpp:
140         * rendering/RenderObject.cpp:
141         * rendering/RenderPartObject.cpp:
142         * rendering/RenderTreeAsText.cpp:
143         * xml/XSLTProcessor.cpp:
144         Added includes as needed to keep compiling, since there are fewer
145         includes in Frame.h.
146
147 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
148
149         Reviewed by Dave Harrison.
150
151         http://bugs.webkit.org/show_bug.cgi?id=11402
152         REGRESSION: onChange does not work anymore for 1st item in popup
153
154         * html/HTMLSelectElement.cpp:
155         (WebCore::HTMLSelectElement::HTMLSelectElement):
156         (WebCore::HTMLSelectElement::reset):
157         Set m_lastOnChangeIndex to -1.
158
159 2006-11-04  Darin Adler  <darin@apple.com>
160
161         Reviewed by Anders.
162
163         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
164           REGRESSION: Status bar always shows cancelled opening the page
165
166         * platform/network/mac/ResourceHandleMac.mm:
167         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
168         Since the subresource owns the resource handle, there's no need to cancel.
169         This arrangement is only temporary, anyway, since Maciej will soon change
170         things so that the subresource loader uses the resource handle and the
171         resource handle doesn't know anything about the subresource loader.
172
173 2006-11-04  Darin Adler  <darin@apple.com>
174
175         Reviewed by Maciej.
176
177         - converted more of the loader machinery to work with cross-platform
178           data structures instead of Macintosh-specific ones
179
180           converted most uses of NSURL to KURL and NSEvent to DOM Event in
181           loader classes
182
183           moved download function out of FrameLoader.h to avoid reference to
184           NSURLConnection
185
186           added DOM Event parameters to various functions so that the handlers
187           can use the DOM Event instead of the global "current NSEvent";
188           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
189           HTMLFormElement::submit, FrameLoader::load
190
191           moved the setMainFrame call that hands ownership to the Page
192           into one of the Frame constructors, and removed it from all
193           the clients
194
195           removed const from Event parameter to the urlSelected function
196           (we rarely use const with DOM elements)
197
198           removed some redundant includes and declarations from various
199           header files
200
201           removed NSURL parameter from userAgent function -- if we need it we
202           can add it back, but converting from NSURL to KURL and back is
203           inefficient enough that it's best to have it out for now (since it's
204           been unused for years) -- if we add it back, we can choose an
205           appropriate parameter type that's always inexpensive to pass
206
207           did some basic cleanup in the IconLoader class, including removing
208           an unnecessary loop that added icon data a byte at a time
209
210           renamed safeLoad to load, since it's no different from the other
211           FrameLoader load functions, safety-wise
212
213           fixed some code that was trying to distinguish null frame name from
214           empty string frame name -- both should be handled the same, but callers
215           were doing it by checking for empty and turning it into null (in a way
216           that was causing extra round trips between NSString and WebCore::String)
217
218           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
219           and got rid of case-insensitive compares of methods
220
221         * WebCore.exp:
222         * WebCore.xcodeproj/project.pbxproj:
223         * bindings/js/kjs_navigator.cpp:
224         (KJS::Navigator::getValueProperty):
225         * bridge/mac/FrameMac.h:
226         * bridge/mac/FrameMac.mm:
227         (WebCore::FrameMac::submitForm):
228         (WebCore::FrameMac::urlSelected):
229         (WebCore::FrameMac::userAgent):
230         * bridge/mac/FrameViewMac.mm:
231         * bridge/mac/WebCoreAXObject.mm:
232         (-[WebCoreAXObject rendererForView:]):
233         * bridge/mac/WebCorePageBridge.h:
234         * bridge/mac/WebCorePageBridge.mm:
235         * bridge/mac/WebCoreSettings.mm:
236         * bridge/win/FrameWin.cpp:
237         (WebCore::FrameWin::urlSelected):
238         (WebCore::FrameWin::submitForm):
239         * bridge/win/FrameWin.h:
240         * dom/MouseRelatedEvent.cpp:
241         * dom/MouseRelatedEvent.h:
242         * dom/UIEvent.cpp:
243         (WebCore::UIEvent::~UIEvent):
244         * dom/UIEvent.h:
245         * dom/UIEventWithKeyState.h:
246         * dom/XMLTokenizer.cpp:
247         (WebCore::openFunc):
248         * html/HTMLAnchorElement.cpp:
249         (WebCore::HTMLAnchorElement::defaultEventHandler):
250         * html/HTMLButtonElement.cpp:
251         (WebCore::HTMLButtonElement::defaultEventHandler):
252         * html/HTMLFormElement.cpp:
253         (WebCore::HTMLFormElement::submitClick):
254         (WebCore::HTMLFormElement::prepareSubmit):
255         (WebCore::HTMLFormElement::submit):
256         * html/HTMLFormElement.h:
257         * html/HTMLInputElement.cpp:
258         (WebCore::HTMLInputElement::defaultEventHandler):
259         * html/HTMLSelectElement.cpp:
260         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
261         * loader/DocumentLoader.h:
262         * loader/FrameLoader.h:
263         * loader/FrameLoaderClient.h:
264         * loader/NavigationAction.h:
265         (WebCore::NavigationAction::event):
266         * loader/icon/IconLoader.cpp:
267         (WebCore::IconLoader::create):
268         (WebCore::IconLoader::startLoading):
269         (WebCore::IconLoader::didReceiveData):
270         (WebCore::IconLoader::didFinishLoading):
271         * loader/icon/IconLoader.h:
272         * loader/loader.cpp:
273         * loader/mac/DocumentLoaderMac.mm:
274         (WebCore::DocumentLoader::URL):
275         (WebCore::DocumentLoader::unreachableURL):
276         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
277         (WebCore::DocumentLoader::URLForHistory):
278         * loader/mac/FrameLoaderMac.mm:
279         (WebCore::FrameLoader::load):
280         (WebCore::FrameLoader::willSendRequest):
281         (WebCore::FrameLoader::clientRedirected):
282         (WebCore::FrameLoader::shouldReload):
283         (WebCore::FrameLoader::notifyIconChanged):
284         (WebCore::FrameLoader::URL):
285         (WebCore::FrameLoader::reloadAllowingStaleData):
286         (WebCore::FrameLoader::reload):
287         (WebCore::FrameLoader::didChangeTitle):
288         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
289         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
290         (WebCore::FrameLoader::post):
291         (WebCore::FrameLoader::addExtraFieldsToRequest):
292         (WebCore::FrameLoader::loadResourceSynchronously):
293         * loader/mac/IconLoaderMac.mm:
294         (WebCore::IconLoader::notifyIconChanged):
295         * loader/mac/LoaderFunctionsMac.mm:
296         * loader/mac/MainResourceLoaderMac.mm:
297         (WebCore::shouldLoadAsEmptyDocument):
298         (WebCore::MainResourceLoader::continueAfterContentPolicy):
299         * loader/mac/NavigationActionMac.mm:
300         (WebCore::navigationType):
301         (WebCore::NavigationAction::NavigationAction):
302         * loader/mac/ResourceLoaderMac.mm:
303         * loader/mac/SubresourceLoaderMac.mm:
304         * page/Frame.cpp:
305         (WebCore::Frame::Frame):
306         (WebCore::Frame::urlSelected):
307         (WebCore::Frame::submitFormAgain):
308         (WebCore::Frame::submitForm):
309         (WebCore::Frame::endIfNotLoading):
310         (WebCore::Frame::hitTestResultAtPoint):
311         * page/Frame.h:
312         * page/FramePrivate.h:
313         * platform/gdk/FrameGdk.cpp:
314         (WebCore::FrameGdk::FrameGdk):
315         (WebCore::FrameGdk::submitForm):
316         (WebCore::FrameGdk::urlSelected):
317         * platform/gdk/FrameGdk.h:
318         * platform/mac/TextFieldMac.mm:
319         * platform/network/HTTPHeaderMap.h:
320         * platform/network/ResourceHandle.h:
321         * platform/network/ResourceHandleClient.h:
322         * platform/network/ResourceHandleInternal.h:
323         * platform/network/mac/ResourceHandleMac.mm:
324         * platform/network/mac/ResourceResponseMac.h:
325         * platform/network/mac/ResourceResponseMac.mm:
326         (-[NSURLResponse WebCore]):
327         * platform/network/win/ResourceHandleWin.cpp:
328         * platform/qt/FrameQt.cpp:
329         (WebCore::FrameQt::submitForm):
330         (WebCore::FrameQt::urlSelected):
331         * platform/qt/FrameQt.h:
332         * rendering/RenderLineEdit.cpp:
333         (WebCore::RenderLineEdit::returnPressed):
334         * xml/XSLTProcessor.cpp:
335         (WebCore::docLoaderFunc):
336         * xml/xmlhttprequest.cpp:
337
338 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
339
340         Reviewed by Adele.
341
342         - replaced receivedRedirect with new willSendRequest delegate
343         - removed most mac-specific loader functions
344         - use ResourceResponse more in loader code
345
346         * WebCore.xcodeproj/project.pbxproj: Add new files.
347         * bridge/mac/WebCoreFrameBridge.mm:
348         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
349         for CachedResource method renames.
350         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
351         Ditto.
352         * loader/CachedCSSStyleSheet.cpp:
353         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
354         based on ResourceResponse
355         * loader/CachedImage.cpp:
356         (WebCore::CachedImage::createImage): adapt for ResourceResponse
357         * loader/CachedResource.cpp:
358         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
359         platform response is now called platformResponse and expiration date
360         is removed.
361         (WebCore::CachedResource::~CachedResource): ditto
362         (WebCore::CachedResource::isExpired): ditto
363         * loader/CachedResource.h:
364         (WebCore::CachedResource::platformResponse): ditto
365         (WebCore::CachedResource::setResponse): ditto
366         (WebCore::CachedResource::canDelete): ditto
367         * loader/LoaderFunctions.h:
368         * loader/loader.cpp:
369         (WebCore::Loader::receivedResponse): Adjusted for renames.
370         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
371         in the CachedResource.
372         * loader/loader.h:
373         * loader/mac/FormDataStream.h:
374         * loader/mac/FormDataStream.m:
375         (WebCore::getStreamFormDatas): Rearranged things so it's
376         possible to get a FormData back out of a form data stream.
377         (WebCore::formCreate): ditto
378         (WebCore::formFinalize): ditto
379         (WebCore::httpBodyFromStream): ditto
380         * loader/mac/ImageDocumentMac.mm:
381         (WebCore::finishImageLoad): s/response/platformResponse/
382         * loader/mac/LoaderFunctionsMac.mm:
383         (WebCore::CheckCacheObjectStatus): ditto
384         (WebCore::CachedResource::setPlatformResponse): ditto
385         * loader/mac/SubresourceLoaderMac.mm:
386         (WebCore::SubresourceLoader::willSendRequest): send redirect
387         to client appropriately
388         * platform/network/ResourceHandle.h:
389         * platform/network/ResourceHandleClient.h:
390         (WebCore::ResourceHandleClient::willSendRequest): new entry
391         point for SubresourceLoader, dispatch to client.
392         * platform/network/ResourceRequest.h:
393         (WebCore::ResourceRequest::allowHTTPCookies): implemented
394         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
395         * platform/network/ResourceResponse.h:
396         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
397         date(!)
398         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
399         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
400         (WebCore::openNextStream): ditto
401         (WebCore::formCreate): ditto
402         (WebCore::formFinalize): ditto
403         (WebCore::formCanRead): ditto
404         (WebCore::formEventCallback): ditto
405         (WebCore::setHTTPBody): ditto
406         (WebCore::httpBodyFromStream): ditto
407         * platform/network/cf/FormDataStreamCFNet.h: Added.
408         * platform/network/cf/ResourceHandleCFNet.cpp:
409         (WebCore::willSendRequest): implemented
410         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
411         * platform/network/cf/ResourceResponseCFNet.cpp:
412         (WebCore::getResourceResponse): do nothing for a null response
413         * platform/network/mac/ResourceHandleMac.mm:
414         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
415         * platform/network/mac/ResourceRequestMac.h: Added.
416         * platform/network/mac/ResourceRequestMac.mm: Added.
417         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
418         to a ResourceRequest.
419         (WebCore::nsURLRequest): Opposite of the above.
420         * platform/network/cf/ResourceRequestCFNet.h: Added.
421         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
422         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
423         to a ResourceRequest.
424         (WebCore::cfURLRequest): Opposite of the above.
425         * xml/xmlhttprequest.cpp:
426         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
427         adjusted.
428         * xml/xmlhttprequest.h:
429
430 2006-11-04  Darin Adler  <darin@apple.com>
431
432         Change suggested by Mitz.
433
434         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
435           REGRESSION (r17438): Repro crash when opening a web archive
436
437         * bridge/mac/WebCorePageState.mm:
438         (-[WebCorePageState dealloc]): Add null check.
439         (-[WebCorePageState finalize]): Ditto.
440
441 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
442
443         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
444
445         http://bugs.webkit.org/show_bug.cgi?id=11433
446         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
447
448         * WebCore.vcproj/WebCore/WebCore.vcproj:
449         Added platform/graphics platform/network and platform/network/win to headers search paths
450         Created platform/graphics and platform/network filters in hierarchy
451         Moved GraphicsContext and GraphicsTypes to their respective filters
452         Added EditorClient.h
453         Added FrameLoader* files in loader/
454         Added HitTest* files in rendering/
455         Added Editor.* files in editing/
456         Added DeleteButton.* and DeleteButtonController.* in editing/
457
458         * bridge/win/ChromeClientWin.h: Added.
459         (WebCore::ChromeClientWin::~ChromeClientWin):
460         * bridge/win/EditorClientWin.h: Added.
461         (WebCore::EditorClientWin::~EditorClientWin):
462
463         * bridge/win/FrameWin.cpp:
464         (WebCore::FrameWin::FrameWin):
465         (WebCore::FrameWin::urlSelected):
466         (WebCore::FrameWin::submitForm):
467         (WebCore::FrameWin::createNewWindow):
468         * bridge/win/FrameWin.h:
469         Added EditorClient parameter to constructor
470         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
471         Removed openURL() and openURLRequest from class definition
472
473         * bridge/win/PageWin.cpp:
474         * platform/AffineTransform.h:
475         * platform/cairo/AffineTransformCairo.cpp: Added.
476         (WebCore::AffineTransform::AffineTransform):
477         (WebCore::AffineTransform::setMatrix):
478         (WebCore::AffineTransform::map):
479         (WebCore::AffineTransform::mapRect):
480         (WebCore::AffineTransform::isIdentity):
481         (WebCore::AffineTransform::m11):
482         (WebCore::AffineTransform::m12):
483         (WebCore::AffineTransform::m21):
484         (WebCore::AffineTransform::m22):
485         (WebCore::AffineTransform::dx):
486         (WebCore::AffineTransform::dy):
487         (WebCore::AffineTransform::reset):
488         (WebCore::AffineTransform::scale):
489         (WebCore::AffineTransform::rotate):
490         (WebCore::AffineTransform::translate):
491         (WebCore::AffineTransform::shear):
492         (WebCore::AffineTransform::det):
493         (WebCore::AffineTransform::invert):
494         (WebCore::AffineTransform::operator cairo_matrix_t):
495         (WebCore::AffineTransform::operator== ):
496         (WebCore::AffineTransform::operator*= ):
497         (WebCore::AffineTransform::operator* ):
498         * platform/cairo/GraphicsContextCairo.cpp:
499         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
500         * platform/network/win/ResourceHandleWin.cpp:
501         (WebCore::ResourceHandle::onHandleCreated):
502         (WebCore::ResourceHandle::start):
503         (WebCore::ResourceHandle::fileLoadTimer):
504         (WebCore::ResourceHandle::cancel):
505         * platform/win/TemporaryLinkStubs.cpp:
506         (WebCore::FrameWin::goBackOrForward):
507         (WebCore::FrameWin::getHistoryLength):
508         (WebCore::FrameWin::historyURL):
509         (WebCore::ServeSynchronousRequest):
510         (WebCore::ChromeClientWin::canRunModal):
511         (WebCore::ChromeClientWin::runModal):
512         (WebCore::EditorClientWin::shouldDeleteRange):
513         (WebCore::EditorClientWin::shouldShowDeleteInterface):
514         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
515         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
516         (WebCore::EditorClientWin::spellCheckerDocumentTag):
517         (WebCore::Path::transform):
518         (WebCore::PopupMenu::updateFromElement):
519         (WebCore::ResourceLoader::loadsBlocked):
520         (WebCore::systemBeep):
521         * rendering/RenderThemeWin.cpp:
522         (WebCore::RenderThemeWin::paintButton):
523         (WebCore::RenderThemeWin::paintTextField):
524
525 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
526
527         Reviewed by Maciej.
528
529         http://bugs.webkit.org/show_bug.cgi?id=11448
530         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
531
532         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
533
534 2006-11-03  Mark Rowe  <bdash@webkit.org>
535
536         Reviewed by Oliver.
537
538         Update Windows and Qt project files for file removals in r17585.
539
540         * CMakeLists.txt:
541         * WebCore.vcproj/WebCore/WebCore.vcproj:
542
543 2006-11-03  Zack Rusin  <zack@kde.org>
544
545         Reviewed by Maciej.
546
547         The patch fixes text field drawing on the Qt platform.
548
549         * platform/qt/RenderThemeQt.cpp:
550         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
551         render the text field
552
553 2006-11-03  Oliver Hunt  <oliver@apple.com>
554
555         Reviewed by Tim.
556
557         Correct incorrect call to SetCursor
558
559         * rendering/RenderFrameSet.cpp:
560         (WebCore::RenderFrameSet::userResize):
561
562 2006-11-03  Adele Peterson  <adele@apple.com>
563
564         Reviewed by Oliver.
565
566         Removed DeprecatedRenderSelect and ListBox classes.
567
568         * WebCore.xcodeproj/project.pbxproj:
569         * css/html4.css:
570         * html/HTMLOptionElement.h:
571         * html/HTMLSelectElement.cpp:
572         (WebCore::HTMLSelectElement::recalcStyle):
573         (WebCore::HTMLSelectElement::isKeyboardFocusable):
574         (WebCore::HTMLSelectElement::isMouseFocusable):
575         (WebCore::HTMLSelectElement::createRenderer):
576         (WebCore::HTMLSelectElement::setRecalcListItems):
577         (WebCore::HTMLSelectElement::notifyOptionSelected):
578         (WebCore::HTMLSelectElement::defaultEventHandler):
579         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
580         (WebCore::HTMLSelectElement::updateListBoxSelection):
581         * html/HTMLSelectElement.h:
582         * platform/ListBox.h: Removed.
583         * platform/mac/FontCacheMac.mm:
584         * platform/mac/ListBoxMac.mm: Removed.
585         * platform/win/TemporaryLinkStubs.cpp:
586         * rendering/DeprecatedRenderSelect.cpp: Removed.
587         * rendering/DeprecatedRenderSelect.h: Removed.
588
589 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
590
591         Not reviewed, fix for accidental commit.
592
593         - rolled back more of the accidentall commit that I forgot.
594
595         * platform/network/mac/ResourceRequestMac.h: Removed.
596         * platform/network/mac/ResourceRequestMac.mm: Removed.
597
598 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
599
600         Not reviewed, fix for accidental commit.
601
602         - roll back some network changes accidentally committed with a previous patch.
603
604         * WebCore.xcodeproj/project.pbxproj:
605         * bridge/mac/WebCoreFrameBridge.mm:
606         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
607         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
608         * loader/CachedCSSStyleSheet.cpp:
609         (WebCore::CachedCSSStyleSheet::checkNotify):
610         * loader/CachedImage.cpp:
611         (WebCore::CachedImage::createImage):
612         * loader/CachedResource.cpp:
613         (WebCore::CachedResource::CachedResource):
614         (WebCore::CachedResource::~CachedResource):
615         (WebCore::CachedResource::setExpireDate):
616         (WebCore::CachedResource::isExpired):
617         * loader/CachedResource.h:
618         (WebCore::CachedResource::response):
619         * loader/LoaderFunctions.h:
620         * loader/loader.cpp:
621         (WebCore::Loader::receivedResponse):
622         (WebCore::Loader::didReceivedResponse):
623         * loader/loader.h:
624         * loader/mac/FormDataStream.h:
625         * loader/mac/FormDataStream.m:
626         (WebCore::formCreate):
627         (WebCore::formFinalize):
628         * loader/mac/ImageDocumentMac.mm:
629         (WebCore::finishImageLoad):
630         * loader/mac/LoaderFunctionsMac.mm:
631         (WebCore::CheckCacheObjectStatus):
632         (WebCore::CachedResource::setResponse):
633         * loader/mac/SubresourceLoaderMac.mm:
634         (WebCore::SubresourceLoader::willSendRequest):
635         * platform/network/ResourceHandle.h:
636         * platform/network/ResourceHandleClient.h:
637         (WebCore::ResourceHandleClient::receivedRedirect):
638         * platform/network/ResourceRequest.h:
639         * platform/network/ResourceResponse.h:
640         (WebCore::ResourceResponse::ResourceResponse):
641         * platform/network/mac/ResourceHandleMac.mm:
642         (WebCore::ResourceHandle::redirectedToURL):
643         * xml/xmlhttprequest.cpp:
644         (WebCore::XMLHttpRequest::receivedRedirect):
645         * xml/xmlhttprequest.h:
646
647 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
648
649         Rubber-stamped by Oliver.
650
651         Remove these, they have been merged with SVGRenderTreeAsText.
652         
653         * rendering/SVGRenderAsText.cpp: Removed.
654         * rendering/SVGRenderAsText.h: Removed.
655
656 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
657
658         Build fix.
659         
660         * platform/network/cf/ResourceHandleCFNet.cpp:
661         (WebCore::willSendRequest):
662
663 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
664
665         Reviewed by Darin, Beth.
666         
667         First cut at factoring Page's UIDelegate-related functions into Chrome
668         and ChromeClient.
669
670         Layout tests pass.
671         
672         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
673         setBridge method to replace it.
674         (WebCore::Page::setBridge):
675
676         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
677         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
678         and, now that it uses PassRefPtr, can't be.
679         
680         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
681
682         * page/Page.h:
683         (WebCore::Page::dragCaretController): Made this function non-const so that
684         m_dragCaretController doesn't have to be mutable.
685
686 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
687
688         Reviewed by Adele.
689
690         http://bugs.webkit.org/show_bug.cgi?id=7323
691         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
692
693         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
694         in FrameMac.mm. There can be only one drag active at any moment, and having 
695         this information here was making sharing this information between 
696         subframes hard.
697
698         * bridge/mac/FrameMac.mm:
699         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
700         (WebCore::FrameMac::freeClipboard):
701         (WebCore::FrameMac::dragHysteresisExceeded):
702         (WebCore::FrameMac::handleMouseMoveEvent):
703         (WebCore::FrameMac::handleMouseReleaseEvent):
704         (WebCore::FrameMac::mouseDown):
705         (WebCore::FrameMac::dragSourceMovedTo):
706         (WebCore::FrameMac::dragSourceEndedAt):
707         (WebCore::FrameMac::dispatchDragSrcEvent):
708         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
709         Also removed some old code that was forwarding mouse events to subviews to make 
710         HTML editing work in subframes.
711
712         * page/FrameView.cpp:
713         (WebCore::FrameView::updateDragAndDrop):
714         (WebCore::FrameView::cancelDragAndDrop):
715         (WebCore::FrameView::performDragAndDrop):
716         Forward events to subframes for dispatching - this fixes drag target events.
717
718 2006-11-03  Zack Rusin  <zack@kde.org>
719
720         Reviewed by Tim.
721
722         Fixing compile.
723
724         * platform/qt/LoaderFunctionsQt.cpp:
725         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
726
727 2006-11-01  Zack Rusin  <zack@kde.org>
728
729         Reviewed by Maciej.
730
731         Moving the word/sentence seperators into a file of their own
732         and implementing findWordBoundary.
733
734         * CMakeLists.txt:
735         * platform/qt/TemporaryLinkStubs.cpp:
736         * platform/qt/TextBoundaries.cpp: Added.
737         (WebCore::findNextSentenceFromIndex):
738         (WebCore::findSentenceBoundary):
739         (WebCore::findNextWordFromIndex):
740         (WebCore::findWordBoundary):
741
742 2006-11-03  Zack Rusin  <zack@kde.org>
743
744         Reviewed by Maciej.
745
746         Compile on both KDE and Qt platforms
747
748         * CMakeLists.txt: add zlib explicitly
749         * platform/network/qt/ResourceHandleManager.cpp:
750         (WebCore::ResourceHandleManager::self):
751         (WebCore::QtJob::QtJob):
752         (WebCore::QtJob::timerEvent): Integrate both implementations
753         so that moc can parse it
754         (WebCore::ResourceHandleManager::deliverJobData):
755         (WebCore::ResourceHandleManager::remove):
756         * platform/network/qt/ResourceHandleManager.h:
757
758 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
759
760         No review, suggested by Mitz.
761
762         - fix a #if to be #ifdef
763
764         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
765
766 2006-11-03  Zack Rusin  <zack@kde.org>
767
768         Reviewed and landed by Maciej.
769         
770         Compile on the Qt platform.
771
772         * ksvg2/misc/KCanvasRenderingStyle.h:
773         * platform/qt/RenderThemeQt.cpp:
774         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
775
776 2006-11-03  Zack Rusin  <zack@kde.org>
777
778         Reviewed by Hyatt. Landed by Maciej.
779
780         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
781         to graphics context to be able to set consistant state
782         on the platform specific painter without having to change
783         fill/stroke/font on every operation. This fixes color/stroke/fill
784         and font handling in the Qt port.
785
786         * platform/graphics/GraphicsContext.cpp:
787         (WebCore::GraphicsContext::setFont):
788         (WebCore::GraphicsContext::setPen):
789         (WebCore::GraphicsContext::setFillColor):
790         (WebCore::GraphicsContext::setPlatformPen):
791         (WebCore::GraphicsContext::setPlatformFillColor):
792         (WebCore::GraphicsContext::setPlatformFont):
793         * platform/graphics/GraphicsContext.h:
794         * platform/qt/GraphicsContextQt.cpp:
795         (WebCore::toQtCompositionMode):
796         (WebCore::toQtLineCap):
797         (WebCore::toQtLineJoin):
798         (WebCore::toQPenStyle):
799         (WebCore::penToQPen):
800         (WebCore::TransparencyLayer::TransparencyLayer):
801         (WebCore::GraphicsContext::addRoundedRectClip):
802         (WebCore::GraphicsContext::setPlatformFont):
803         (WebCore::GraphicsContext::setPlatformPen):
804         (WebCore::GraphicsContext::setPlatformFillColor):
805         * platform/qt/ScrollViewCanvasQt.cpp:
806         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
807         (WebCore::ScrollViewCanvasQt::paintEvent):
808         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
809         * platform/qt/ScrollViewCanvasQt.h:
810
811 2006-11-02  Adele Peterson  <adele@apple.com>
812
813         Reviewed by Anders.
814
815         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
816         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
817
818         Test: fast/forms/textarea-no-scroll-on-blur.html
819
820         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
821           On blur, only scroll back to the start for text fields.
822
823 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
824
825         Another build fix.
826         
827         * rendering/RenderFileUploadControl.cpp:
828         (WebCore::RenderFileUploadControl::paintObject):
829
830 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
831
832         Build fix.
833         
834         * page/FramePrivate.h:
835         (WebCore::FramePrivate::FramePrivate):
836
837 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
838
839         Reviewed by Geoff, landed by Anders.
840         
841         Fix dependency problems caused when running move-js-headers.sh
842         
843         * move-js-headers.sh:
844         Use cp -p instead of just cp so that the modification time
845         of the original files are used.
846
847 2006-11-02  Adam Roben  <aroben@apple.com>
848
849         Reviewed by Tim H, landed by Anders.
850
851         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
852         REGRESSION: Shadow of file upload button is clipped
853
854         * rendering/RenderFileUploadControl.cpp:
855         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
856         height to keep from clipping in the shadow
857
858 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
859
860         Reviewed by Maciej, landed by Anders.
861
862         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
863         content and window. ScrollViewQt already receives correct content
864         coordinates from QScrollArea.
865         (WebCore::ScrollView::contentsToWindow):
866         (WebCore::ScrollView::windowToContents):
867
868 2006-11-02  Simon Hausmann  <hausmann@kde.org>
869
870         Reviewed by Maciej, landed by Anders
871
872         * CMakeLists.txt: Make linkage against KDE libraries conditional
873         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
874           Qt base resource handler that supports only requests to the
875           local filesystem. Used when compiling without KDE support.
876           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
877           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
878         (WebCore::QtJob::QtJob):
879         (WebCore::QtJob::timerEvent):
880         (WebCore::ResourceHandleManager::ResourceHandleManager):
881         (WebCore::ResourceHandleManager::~ResourceHandleManager):
882         (WebCore::ResourceHandleManager::self):
883         (WebCore::ResourceHandleManager::remove):
884         (WebCore::ResourceHandleManager::add):
885         (WebCore::ResourceHandleManager::cancel):
886         (WebCore::ResourceHandleManager::deliverJobData):
887         * platform/network/qt/ResourceHandleManager.h:
888         * platform/qt/FrameQtClient.cpp:
889         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
890         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
891         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
892         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
893           input dialog functions when compiling without KDE support
894         (WebCore::ServeSynchronousRequest):
895
896 2006-11-02  David Carson  <dacarson@gmail.com>
897
898         Reviewed by Geoff, landed by Anders.
899
900         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
901         Initializing variable in constructor.
902
903         * page/FramePrivate.h:
904         (WebCore::FramePrivate::FramePrivate):
905
906 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
907
908         Reviewed by Geoff.
909
910         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
911         
912         * platform/network/cf/ResourceHandleCFNet.cpp:
913         (WebCore::addHeadersFromHashMap):
914         Don't set all headers at once since that clears any previous headers set.
915         
916         (WebCore::ResourceHandle::start):
917
918 2006-11-02  Adele Peterson  <adele@apple.com>
919
920         Reviewed by Mitz and Geoff.
921
922         - Fix for:
923         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
924         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
925         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
926
927         Test: fast/forms/textarea-scrollbar.html
928
929         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
930         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
931
932         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
933         * rendering/RenderTextControl.cpp: 
934         (WebCore::RenderTextControl::RenderTextControl):
935         (WebCore::RenderTextControl::setStyle):
936         (WebCore::RenderTextControl::createDivStyle):
937         (WebCore::RenderTextControl::updateFromElement):
938         (WebCore::RenderTextControl::calcHeight):
939         (WebCore::RenderTextControl::baselinePosition):
940         (WebCore::RenderTextControl::nodeAtPoint):
941         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
942         (WebCore::RenderTextControl::scrollWidth):
943         (WebCore::RenderTextControl::scrollHeight):
944         (WebCore::RenderTextControl::scrollLeft):
945         (WebCore::RenderTextControl::scrollTop):
946
947         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
948
949 2006-11-02  John Sullivan  <sullivan@apple.com>
950
951         Reviewed by Geoff Garen
952
953         * editing/Selection.cpp:
954         (WebCore::Selection::showTreeForThis):
955         this debugging method now displays start offset and end offset, at Darin's suggestion
956
957 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
958
959         Reviewed by darin
960
961         <rdar://problem/4062865>
962         Copy/paste of a select element fails to include the options
963         
964         * editing/SelectionController.cpp:
965         (WebCore::SelectionController::modify): Added paragraphBoundary.
966         * editing/htmlediting.cpp:
967         (WebCore::canHaveChildrenForEditing): Added checks for input elements
968         and textareas.  Insertion operations would fail when performed just 
969         before/after one of these elements b/c the content would be put inside 
970         the element.
971         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
972         editable content, and made the code to stop at an root faster (don't check
973         isDescendantOf on every iteration).
974         (WebCore::enclosingNodeOfType): Ditto.
975         (WebCore::enclosingList): Ditto.
976         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
977         inappropriately named.
978         * editing/markup.cpp:
979         (WebCore::startMarkup): Use the text node's value instead of its rendered
980         content for text nodes inside select elements.  One might also turn off
981         annotation when createMarkup enters a select element, but createMarkup
982         is iterative, not recursive, so doing so would be complicated.
983         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
984         descendants of a select element.
985         * editing/visible_units.cpp:
986         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
987         where various replaced elements can't be copied when they are the only
988         thing selected.
989         (WebCore::endOfParagraph): Ditto.
990
991 2006-11-01  Oliver Hunt  <oliver@apple.com>
992
993         Reviewed by Adam.
994
995         Converting more or kcanvas/quartz from Obj-C to C++
996         Minor SVG updates
997         compatibility fixes
998
999         * WebCore.xcodeproj/project.pbxproj:
1000         * kcanvas/device/KRenderingPaintServer.h:
1001         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
1002         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
1003         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
1004         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
1005         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
1006         * kcanvas/device/quartz/QuartzSupport.h:
1007         * ksvg2/css/SVGCSSStyleSelector.cpp:
1008         * ksvg2/misc/KCanvasRenderingStyle.h:
1009         * ksvg2/scripts/cssmakeprops:
1010         * ksvg2/scripts/cssmakevalues:
1011         * ksvg2/scripts/make_names.pl:
1012         * ksvg2/svg/SVGAnimateColorElement.cpp:
1013         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1014         * ksvg2/svg/SVGAnimationElement.cpp:
1015         * ksvg2/svg/SVGMaskElement.cpp:
1016         * ksvg2/svg/SVGPatternElement.cpp:
1017         * ksvg2/svg/svgpathparser.cpp:
1018         * platform/Path.cpp:
1019         * platform/graphics/svg/SVGResourceImage.h:
1020         * rendering/RenderPath.cpp:
1021         * rendering/SVGRenderAsText.cpp:
1022
1023 2006-11-02  Mitz Pettel  <mitz@webkit.org>
1024
1025         Reviewed by Adele.
1026
1027         - Fix a regression from r17521: painting of and crash caused by tables
1028           with collapsed borders
1029
1030         * rendering/RenderTable.cpp:
1031         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
1032         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
1033         and 'paintInfo' is the parameter, which we were accidently modifying.
1034
1035 2006-11-01  Adele Peterson  <adele@apple.com>
1036
1037         Reviewed by Mitz.
1038
1039         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
1040         REGRESSION: Incomplete repaint of overflow areas when deleting
1041
1042         Restrict the repaint rect for overflow blocks after the height has been fully computed.
1043         Also, adjust the repaint rect coordinates for the scroll offset.
1044
1045         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
1046         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
1047
1048 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
1049
1050         Reviewed by Mitz.
1051
1052         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
1053         Rename the "p" member variable of the PaintInfo struct to "context"
1054
1055         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
1056           'context' and 'rect' respectively.
1057
1058         - Assorted surrounding cleanups.
1059
1060         * rendering/EllipsisBox.cpp:
1061         (WebCore::EllipsisBox::paint):
1062         * rendering/EllipsisBox.h:
1063         * rendering/InlineBox.cpp:
1064         (WebCore::InlineBox::paint):
1065         * rendering/InlineFlowBox.cpp:
1066         (WebCore::InlineFlowBox::paint):
1067         (WebCore::InlineFlowBox::paintBackground):
1068         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
1069         (WebCore::InlineFlowBox::paintDecorations):
1070         * rendering/InlineFlowBox.h:
1071         * rendering/InlineRunBox.h:
1072         * rendering/InlineTextBox.cpp:
1073         (WebCore::InlineTextBox::paint):
1074         * rendering/InlineTextBox.h:
1075         * rendering/RenderBlock.cpp:
1076         (WebCore::RenderBlock::paint):
1077         (WebCore::RenderBlock::paintChildren):
1078         (WebCore::RenderBlock::paintCaret):
1079         (WebCore::RenderBlock::paintObject):
1080         (WebCore::RenderBlock::paintFloats):
1081         (WebCore::RenderBlock::paintEllipsisBoxes):
1082         (WebCore::RenderBlock::paintSelection):
1083         (WebCore::RenderBlock::fillSelectionGaps):
1084         (WebCore::RenderBlock::fillInlineSelectionGaps):
1085         (WebCore::RenderBlock::fillBlockSelectionGaps):
1086         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1087         (WebCore::RenderBlock::fillVerticalSelectionGap):
1088         (WebCore::RenderBlock::fillLeftSelectionGap):
1089         (WebCore::RenderBlock::fillRightSelectionGap):
1090         * rendering/RenderBox.cpp:
1091         (WebCore::RenderBox::paint):
1092         (WebCore::RenderBox::paintRootBoxDecorations):
1093         (WebCore::RenderBox::paintBoxDecorations):
1094         * rendering/RenderBox.h:
1095         * rendering/RenderButton.cpp:
1096         (WebCore::RenderButton::paintObject):
1097         * rendering/RenderFieldset.cpp:
1098         (WebCore::RenderFieldset::paintBoxDecorations):
1099         * rendering/RenderFileUploadControl.cpp:
1100         (WebCore::RenderFileUploadControl::paintObject):
1101         * rendering/RenderFlow.cpp:
1102         (WebCore::RenderFlow::continuationBefore):
1103         (WebCore::RenderFlow::addChildWithContinuation):
1104         (WebCore::RenderFlow::addChild):
1105         (WebCore::RenderFlow::attachLineBox):
1106         (WebCore::RenderFlow::destroy):
1107         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
1108         (WebCore::RenderFlow::dirtyLineBoxes):
1109         (WebCore::RenderFlow::createInlineBox):
1110         (WebCore::RenderFlow::paintLines):
1111         (WebCore::RenderFlow::getAbsoluteRepaintRect):
1112         (WebCore::RenderFlow::lowestPosition):
1113         (WebCore::RenderFlow::rightmostPosition):
1114         (WebCore::RenderFlow::leftmostPosition):
1115         (WebCore::RenderFlow::caretRect):
1116         (WebCore::RenderFlow::addFocusRingRects):
1117         (WebCore::RenderFlow::paintOutline):
1118         (WebCore::RenderFlow::paintOutlineForLine):
1119         * rendering/RenderForeignObject.cpp:
1120         (WebCore::RenderForeignObject::paint):
1121         * rendering/RenderHTMLCanvas.cpp:
1122         (WebCore::RenderHTMLCanvas::paint):
1123         * rendering/RenderImage.cpp:
1124         (WebCore::RenderImage::paint):
1125         * rendering/RenderLayer.cpp:
1126         (WebCore::RenderLayer::paintLayer):
1127         * rendering/RenderListBox.cpp:
1128         (WebCore::RenderListBox::paintObject):
1129         (WebCore::RenderListBox::paintScrollbar):
1130         (WebCore::RenderListBox::paintItemForeground):
1131         (WebCore::RenderListBox::paintItemBackground):
1132         * rendering/RenderListMarker.cpp:
1133         (WebCore::RenderListMarker::paint):
1134         * rendering/RenderMenuList.cpp:
1135         (WebCore::RenderMenuList::paintObject):
1136         * rendering/RenderObject.cpp:
1137         (WebCore::RenderObject::paint):
1138         * rendering/RenderObject.h:
1139         (WebCore::RenderObject::PaintInfo::PaintInfo):
1140         (WebCore::RenderObject::paintBoxDecorations):
1141         (WebCore::RenderObject::paintingRootForChildren):
1142         (WebCore::RenderObject::shouldPaintWithinRoot):
1143         (WebCore::RenderObject::printBoxDecorations):
1144         * rendering/RenderPath.cpp:
1145         (WebCore::RenderPath::paint):
1146         * rendering/RenderReplaced.cpp:
1147         (WebCore::RenderReplaced::shouldPaint):
1148         * rendering/RenderSVGContainer.cpp:
1149         (WebCore::RenderSVGContainer::paint):
1150         * rendering/RenderSVGContainer.h:
1151         * rendering/RenderSVGImage.cpp:
1152         (WebCore::RenderSVGImage::paint):
1153         * rendering/RenderSVGText.cpp:
1154         (WebCore::RenderSVGText::paint):
1155         * rendering/RenderSVGText.h:
1156         (WebCore::RenderSVGText::renderName):
1157         * rendering/RenderTable.cpp:
1158         (WebCore::RenderTable::paint):
1159         (WebCore::RenderTable::paintBoxDecorations):
1160         * rendering/RenderTable.h:
1161         * rendering/RenderTableCell.cpp:
1162         (WebCore::RenderTableCell::paint):
1163         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
1164         (WebCore::RenderTableCell::paintBoxDecorations):
1165         * rendering/RenderTableCell.h:
1166         * rendering/RenderTableRow.cpp:
1167         (WebCore::RenderTableRow::paint):
1168         * rendering/RenderTableRow.h:
1169         * rendering/RenderTableSection.cpp:
1170         (WebCore::RenderTableSection::paint):
1171         * rendering/RenderTableSection.h:
1172         (WebCore::RenderTableSection::getBaseline):
1173         (WebCore::RenderTableSection::setNeedCellRecalc):
1174         * rendering/RenderText.h:
1175         (WebCore::RenderText::renderName):
1176         (WebCore::RenderText::paint):
1177         (WebCore::RenderText::element):
1178         * rendering/RenderTheme.cpp:
1179         (WebCore::RenderTheme::paint):
1180         (WebCore::RenderTheme::paintBorderOnly):
1181         (WebCore::RenderTheme::paintDecorations):
1182         * rendering/RenderTheme.h:
1183         (WebCore::RenderTheme::RenderTheme):
1184         (WebCore::RenderTheme::~RenderTheme):
1185         (WebCore::RenderTheme::controlSupportsTints):
1186         (WebCore::RenderTheme::adjustRepaintRect):
1187         (WebCore::RenderTheme::themeChanged):
1188         (WebCore::RenderTheme::supportsHover):
1189         (WebCore::RenderTheme::paintCheckbox):
1190         (WebCore::RenderTheme::setCheckboxSize):
1191         (WebCore::RenderTheme::paintRadio):
1192         (WebCore::RenderTheme::setRadioSize):
1193         (WebCore::RenderTheme::paintButton):
1194         (WebCore::RenderTheme::setButtonSize):
1195         (WebCore::RenderTheme::paintTextField):
1196         (WebCore::RenderTheme::paintTextArea):
1197         (WebCore::RenderTheme::paintMenuList):
1198         (WebCore::RenderTheme::paintMenuListButton):
1199         * rendering/RenderThemeMac.mm:
1200         (WebCore::RenderThemeMac::paintCheckbox):
1201         (WebCore::RenderThemeMac::paintRadio):
1202         (WebCore::RenderThemeMac::paintButton):
1203         (WebCore::RenderThemeMac::paintTextField):
1204         (WebCore::RenderThemeMac::paintTextArea):
1205         (WebCore::RenderThemeMac::paintMenuList):
1206         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
1207         (WebCore::RenderThemeMac::paintMenuListButton):
1208         * rendering/RenderView.cpp:
1209         (WebCore::RenderView::paint):
1210         (WebCore::RenderView::paintBoxDecorations):
1211         * rendering/RenderView.h:
1212         * rendering/RenderWidget.cpp:
1213         (WebCore::RenderWidget::paint):
1214         * rendering/RenderWidget.h:
1215         (WebCore::RenderWidget::isWidget):
1216         * rendering/RootInlineBox.cpp:
1217         (WebCore::RootInlineBox::paintEllipsisBox):
1218         (WebCore::RootInlineBox::paintCustomHighlight):
1219         (WebCore::RootInlineBox::paint):
1220         (WebCore::RootInlineBox::fillLineSelectionGap):
1221         * rendering/RootInlineBox.h:
1222         * rendering/SVGInlineFlowBox.cpp:
1223         (WebCore::paintSVGInlineFlow):
1224
1225 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
1226
1227         Reviewed by Oliver, Brady.
1228
1229         * platform/network/ResourceResponse.h:
1230         (WebCore::ResourceResponse::setLastModifiedDate):
1231         (WebCore::ResourceResponse::lastModifiedDate):
1232         Add getters and setters for last modified dadte.
1233         
1234         * platform/network/cf/ResourceResponseCFNet.cpp:
1235         (WebCore::getResourceResponse):
1236         Fetch the last modified date. Add correct offset to expired date.
1237
1238 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
1239
1240         Reviewed by Mitz.
1241
1242         Added missing "break;" statement in switch statement from r17493.
1243
1244         Bug 11442: [CSS 3] support for cursor: all-scroll
1245         http://bugs.webkit.org/show_bug.cgi?id=11442
1246
1247         * css/CSSComputedStyleDeclaration.cpp:
1248         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1249
1250 2006-10-31  Mitz Pettel  <mitz@webkit.org>
1251
1252         Reviewed by Maciej.
1253
1254         - fix image dragging
1255
1256         This is covered by editing/selection/drag-to-contenteditable-iframe.html
1257
1258         * rendering/HitTestResult.cpp:
1259         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
1260         HTML IMG elements.
1261         (WebCore::HitTestResult::absoluteImageURL): Ditto.
1262
1263 2006-10-31  Beth Dakin  <bdakin@apple.com>
1264
1265         Reviewed by Maciej.
1266
1267         This adds the back-end of the remaining WebElementDictionary 
1268         functions into HitTestResult.
1269
1270         * WebCore.exp:
1271         * rendering/HitTestResult.cpp:
1272         (WebCore::HitTestResult::title):
1273         (WebCore::displayString): This is nearly identical to the 
1274         displayString() defined in DOMInternal.mm except that it returns a 
1275         String instead of an NSString. The old code path used the 
1276         DOMInternal method, so I made a new one here for the new code path.
1277         (WebCore::HitTestResult::altDisplayString):
1278         (WebCore::HitTestResult::image):
1279         (WebCore::HitTestResult::absoluteImageURL):
1280         (WebCore::HitTestResult::absoluteLinkURL):
1281         (WebCore::HitTestResult::titleDisplayString):
1282         (WebCore::HitTestResult::textContent):
1283         * rendering/HitTestResult.h:
1284
1285 2006-10-31  John Sullivan  <sullivan@apple.com>
1286
1287         * bridge/mac/FrameMac.mm:
1288         (WebCore::FrameMac::markMisspellings):
1289         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
1290
1291 2006-10-31  John Sullivan  <sullivan@apple.com>
1292
1293         Reviewed by Maciej
1294         
1295         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
1296         
1297         The foundation of this was in my last checkin. This checkin is all about displaying
1298         the correct string in the toolTip.
1299
1300         * dom/DocumentMarker.h:
1301         New description field in this struct.
1302
1303         * bridge/mac/FrameMac.mm:
1304         (WebCore::FrameMac::advanceToNextMisspelling):
1305         When adding a grammar marker, supply the appropriate description. Also, added a comment
1306         about the remaining work to make grammar checking return sensible answers.
1307         (WebCore::FrameMac::markMisspellings):
1308         ditto (yes, still needs some refactoring to minimize duplicated code)
1309         
1310         * dom/Document.h:
1311         * dom/Document.cpp:
1312         (WebCore::Document::addMarker):
1313         Now takes an optional description string
1314         (WebCore::Document::markerContainingPoint):
1315         New function, returns a pointer to the (first) marker of the specified type whose rect 
1316         contains the specified point, or 0 if none.
1317         
1318         * rendering/HitTestResult.cpp:
1319         (WebCore::HitTestResult::spellingToolTip):
1320         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
1321         and gets the description from the marker.
1322
1323 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
1324
1325         Reviewed by Maciej.
1326         
1327         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
1328
1329         * loader/mac/FrameLoaderMac.mm:
1330         (WebCore::FrameLoader::createWindow):
1331         * manual-tests/window-open-features-parsing.html: Updated for clarity.
1332
1333 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
1334
1335         Reviewed by Alice.
1336
1337         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
1338         to WebCore::Editor.
1339         
1340         Layout tests pass.
1341         
1342         Renamed "may*" to "can*" because "can" is more accurate (these functions
1343         aren't just about permission) and it matches WebKit.
1344
1345         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
1346         password field. Now that WebCore fully implements canCopy(), it doesn't just
1347         mean "the selection is not in a password field" anymore.
1348         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
1349         The fact that it's not called anymore may represent a security issue, but I
1350         don't see how commented-out code will help reveal the issue, and the
1351         bridge is going away, anyway.
1352         * editing/SelectionController.h: Changed selection() calls to references
1353         to m_sel, to match the rest of the file.
1354
1355 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
1356
1357         Reviewed by harrison
1358         
1359         <rdar://problem/4711063>
1360         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
1361
1362         * editing/ReplaceSelectionCommand.cpp:
1363         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
1364         insertion and plain text string creation unless we need the string
1365         for a BeforeTextInserted event handler or for a plain text only region.
1366         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
1367         code here from ReplacementFragment's constructor.
1368         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
1369         FIXME.
1370         * editing/ReplaceSelectionCommand.h:
1371
1372 2006-10-31  Ada Chan  <adachan@apple.com>
1373
1374         Reviewed by Adam
1375
1376         Correct forward declarations of the HitTestRequest struct.
1377
1378         * rendering/EllipsisBox.h:
1379         * rendering/InlineBox.h:
1380         * rendering/InlineFlowBox.h:
1381         * rendering/RenderLayer.h:
1382         * rendering/RenderObject.h:
1383
1384 2006-10-31  John Sullivan  <sullivan@apple.com>
1385
1386         Reviewed by Beth and Adam
1387
1388         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
1389         next I'll make it use a string that's relevant for a specific grammar error.
1390
1391         * WebCore.exp:
1392         export symbol for spellingToolTip function
1393         
1394         * rendering/HitTestResult.h:
1395         * rendering/HitTestResult.cpp:
1396         (WebCore::HitTestResult::spellingToolTip):
1397         new function, returns the string to be used in a tool tip that describes the questionable grammar
1398         
1399         * rendering/InlineTextBox.h:
1400         * rendering/InlineTextBox.cpp:
1401         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1402         now takes a style and font, needed to compute the rect representing the range containing
1403         questionable grammar. Computes the rect and associates it with the marker.
1404         (WebCore::InlineTextBox::paintDocumentMarkers):
1405         Pass in the style and font now needed by paintSpellingOrGrammarMarker
1406
1407 2006-10-31  Adele Peterson  <adele@apple.com>
1408
1409         Removed commented out variable from last checkin.
1410
1411         * html/HTMLSelectElement.cpp:
1412         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1413
1414 2006-10-31  Brady Eidson  <beidson@apple.com>
1415
1416         Build fix (unused variable in release builds)
1417
1418         * html/HTMLSelectElement.cpp:
1419         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1420
1421 2006-10-31  Adele Peterson  <adele@apple.com>
1422
1423         Reviewed by Adam.
1424
1425         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
1426         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
1427         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
1428
1429         Tests: 
1430         * LayoutTests/fast/forms/listbox-selection.html
1431         * LayoutTests/fast/forms/listbox-onchange.html
1432
1433         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
1434           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
1435           And one for onChange, that is updated after onChange is fired.
1436           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
1437  
1438         * html/HTMLSelectElement.cpp:
1439         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
1440         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
1441         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
1442         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
1443         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
1444         (WebCore::HTMLSelectElement::setExtent): Added.
1445         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
1446         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
1447
1448         * rendering/RenderListBox.cpp:
1449         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
1450         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
1451         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
1452         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
1453          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
1454          notify the select element from here.
1455         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
1456         (WebCore::RenderListBox::listIndexIsVisible): Added.
1457         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
1458
1459         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
1460         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
1461         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
1462         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
1463         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
1464
1465 2006-10-31  Beth Dakin  <bdakin@apple.com>
1466
1467         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
1468
1469         * rendering/HitTestRequest.h: Added.
1470         (WebCore::HitTestRequest::HitTestRequest):
1471
1472 2006-10-31  Beth Dakin  <bdakin@apple.com>
1473
1474         Reviewed by Maciej.
1475
1476         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
1477         should be split into HitTestRequest and HitTestResult
1478
1479         This patch creates a new struct called HitTestRequest that holds 
1480         the three boolean values (readonly, active, and mouseMove) that 
1481         were formerly a part of HitTestResult. All hitTest() and 
1482         nodeAtPoint() functions now take a HitTestRequest in addition to 
1483         the HitTestResult.
1484
1485         * WebCore.exp:
1486         * WebCore.xcodeproj/project.pbxproj:
1487         * bridge/mac/FrameMac.mm:
1488         (WebCore::FrameMac::eventMayStartDrag):
1489         (WebCore::FrameMac::handleMouseMoveEvent):
1490         * bridge/mac/WebCoreAXObject.mm:
1491         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
1492         (-[WebCoreAXObject accessibilityHitTest:]):
1493         * dom/Document.cpp:
1494         (WebCore::Document::elementFromPoint):
1495         (WebCore::Document::prepareMouseEvent):
1496         * editing/SelectionController.cpp:
1497         (WebCore::SelectionController::contains):
1498         * page/Frame.cpp:
1499         (WebCore::Frame::hitTestResultAtPoint):
1500         * page/FrameView.cpp:
1501         (WebCore::FrameView::handleWheelEvent):
1502         * rendering/EllipsisBox.cpp:
1503         (WebCore::EllipsisBox::nodeAtPoint):
1504         * rendering/EllipsisBox.h:
1505         * rendering/HitTestResult.cpp:
1506         (WebCore::HitTestResult::HitTestResult):
1507         (WebCore::HitTestResult::operator=):
1508         * rendering/HitTestResult.h:
1509         * rendering/InlineBox.cpp:
1510         (WebCore::InlineBox::nodeAtPoint):
1511         * rendering/InlineBox.h:
1512         * rendering/InlineFlowBox.cpp:
1513         (WebCore::InlineFlowBox::nodeAtPoint):
1514         * rendering/InlineFlowBox.h:
1515         * rendering/InlineTextBox.cpp:
1516         (WebCore::InlineTextBox::nodeAtPoint):
1517         * rendering/InlineTextBox.h:
1518         * rendering/RenderBlock.cpp:
1519         (WebCore::RenderBlock::nodeAtPoint):
1520         * rendering/RenderBlock.h:
1521         * rendering/RenderBox.cpp:
1522         (WebCore::RenderBox::nodeAtPoint):
1523         * rendering/RenderBox.h:
1524         * rendering/RenderFlow.cpp:
1525         (WebCore::RenderFlow::hitTestLines):
1526         * rendering/RenderFlow.h:
1527         * rendering/RenderForeignObject.cpp:
1528         (WebCore::RenderForeignObject::nodeAtPoint):
1529         * rendering/RenderForeignObject.h:
1530         * rendering/RenderFrameSet.cpp:
1531         (WebCore::RenderFrameSet::nodeAtPoint):
1532         * rendering/RenderFrameSet.h:
1533         * rendering/RenderImage.cpp:
1534         (WebCore::RenderImage::nodeAtPoint):
1535         * rendering/RenderImage.h:
1536         * rendering/RenderInline.cpp:
1537         (WebCore::RenderInline::nodeAtPoint):
1538         * rendering/RenderInline.h:
1539         * rendering/RenderLayer.cpp:
1540         (WebCore::RenderLayer::autoscroll):
1541         (WebCore::RenderLayer::hitTest):
1542         (WebCore::RenderLayer::hitTestLayer):
1543         (WebCore::RenderLayer::updateHoverActiveState):
1544         * rendering/RenderLayer.h:
1545         * rendering/RenderObject.cpp:
1546         (WebCore::RenderObject::hitTest):
1547         (WebCore::RenderObject::nodeAtPoint):
1548         * rendering/RenderObject.h:
1549         * rendering/RenderPath.cpp:
1550         (WebCore::RenderPath::nodeAtPoint):
1551         * rendering/RenderPath.h:
1552         * rendering/RenderSVGImage.cpp:
1553         (WebCore::RenderSVGImage::nodeAtPoint):
1554         * rendering/RenderSVGImage.h:
1555         * rendering/RenderSVGText.cpp:
1556         (WebCore::RenderSVGText::nodeAtPoint):
1557         * rendering/RenderSVGText.h:
1558         * rendering/RenderTableRow.cpp:
1559         (WebCore::RenderTableRow::nodeAtPoint):
1560         * rendering/RenderTableRow.h:
1561         * rendering/RenderTableSection.cpp:
1562         (WebCore::RenderTableSection::nodeAtPoint):
1563         * rendering/RenderTableSection.h:
1564         * rendering/RenderText.h:
1565         (WebCore::RenderText::nodeAtPoint):
1566         * rendering/RenderTextControl.cpp:
1567         (WebCore::RenderTextControl::nodeAtPoint):
1568         * rendering/RenderTextControl.h:
1569         * rendering/RootInlineBox.cpp:
1570         (WebCore::RootInlineBox::nodeAtPoint):
1571         * rendering/RootInlineBox.h:
1572
1573 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
1574
1575         Reviewed by Maciej.
1576
1577         Bug 11442: [CSS 3] support for cursor: all-scroll
1578         http://bugs.webkit.org/show_bug.cgi?id=11442
1579
1580         * css/CSSComputedStyleDeclaration.cpp:
1581         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1582         * css/CSSValueKeywords.in:
1583         * css/cssparser.cpp:
1584         (WebCore::CSSParser::parseValue):
1585         * page/FrameView.cpp:
1586         (WebCore::selectCursor):
1587         * rendering/RenderStyle.h:
1588
1589 2006-10-31  Oliver Hunt  <oliver@apple.com>
1590
1591         Reviewed by Geoff.
1592
1593         Converting Obj-C++ to C++ in kcanvas
1594
1595         * WebCore.xcodeproj/project.pbxproj:
1596         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
1597         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1598         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
1599         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
1600         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
1601         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1602         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
1603         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1604         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1605         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
1606         * kcanvas/device/quartz/QuartzSupport.h:
1607         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
1608         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
1609         (WebCore::SVGResourceClipper::applyClip):
1610         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
1611         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
1612         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
1613
1614 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
1615
1616         Reviewed by harrison
1617         
1618         <rdar://problem/4808375>
1619         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
1620         
1621         Completely back out r17276 because of performance issues.
1622
1623         * editing/TextIterator.cpp:
1624         (WebCore::TextIterator::TextIterator):
1625         (WebCore::TextIterator::advance):
1626         (WebCore::TextIterator::handleTextNode):
1627         (WebCore::TextIterator::handleTextBox):
1628         (WebCore::TextIterator::handleReplacedElement):
1629         (WebCore::TextIterator::handleNonTextNode):
1630         (WebCore::TextIterator::exitNode):
1631         (WebCore::TextIterator::emitCharacter):
1632         (WebCore::TextIterator::range):
1633         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
1634         (WebCore::SimplifiedBackwardsTextIterator::advance):
1635         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
1636         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
1637         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
1638         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
1639         (WebCore::SimplifiedBackwardsTextIterator::range):
1640         (WebCore::CharacterIterator::range):
1641         (WebCore::TextIterator::rangeFromLocationAndLength):
1642         * editing/TextIterator.h:
1643         (WebCore::TextIterator::atEnd):
1644         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
1645
1646 2006-10-31  Darin Adler  <darin@apple.com>
1647
1648         Reviewed by Brady.
1649
1650         - got "action dictionary" code out of FrameLoader,
1651           replacing with a class called NavigationAction
1652
1653         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
1654         * loader/mac/DocumentLoaderMac.mm:
1655         (WebCore::DocumentLoader::triggeringAction): Ditto.
1656         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
1657
1658         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
1659
1660         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
1661         Removed elementForEvent.
1662         * loader/mac/FrameLoaderMac.mm:
1663         (WebCore::FrameLoader::load): Ditto.
1664         (WebCore::FrameLoader::reload): Ditto.
1665         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
1666         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
1667         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
1668         (WebCore::FrameLoader::post): Ditto.
1669
1670         * loader/NavigationAction.h: Added.
1671         * loader/NavigationAction.cpp: Added.
1672         * loader/mac/NavigationActionMac.mm: Added.
1673
1674         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
1675
1676         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
1677         * WebCore.exp: Updated.
1678
1679 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
1680
1681         Reviewed by Adam.
1682
1683         Build fix
1684
1685         * platform/win/CookieJarWin.cpp:
1686         (WebCore::cookies):
1687
1688 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1689
1690         Reviewed by Maciej. Landed by Adam.
1691
1692         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
1693
1694         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
1695         as dicussed with Dave. Also kill the outdated DESIGN document.
1696
1697         * CMakeLists.txt:
1698         * WebCore.xcodeproj/project.pbxproj:
1699         * kcanvas/DESIGN: Removed.
1700         * kcanvas/KCanvasFilters.cpp:
1701         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
1702         * kcanvas/KCanvasTreeDebug.h: Ditto.
1703         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1704         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1705         * kcanvas/device/KRenderingPaintServerSolid.cpp:
1706         * platform/graphics/svg/SVGResourceClipper.cpp:
1707         * rendering/RenderTreeAsText.cpp:
1708         * rendering/SVGRenderTreeAsText.cpp: Added.
1709         * rendering/SVGRenderTreeAsText.h: Added.
1710         (WebCore::operator<<):
1711
1712 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
1713
1714         Reviewed by Maciej.
1715
1716         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
1717         Includes some CRLF -> LF fixups.
1718
1719         * platform/win/CookieJarWin.cpp:
1720         (WebCore::cookies):
1721
1722 2006-10-31  Adam Roben  <aroben@apple.com>
1723
1724         Reviewed by Steve.
1725
1726         Fix some incorrect forward declarations.
1727
1728         * loader/FrameLoader.h:
1729         * page/Frame.h:
1730
1731 2006-10-31  Darin Adler  <darin@apple.com>
1732
1733         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
1734         try to fix the build on the buildbot.
1735
1736 2006-10-31  Darin Adler  <darin@apple.com>
1737
1738         * bridge/mac/FrameMac.mm:
1739         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
1740         (WebCore::FrameMac::markMisspellings): Ditto.
1741
1742 2006-10-31  John Sullivan  <sullivan@apple.com>
1743
1744         * bridge/mac/FrameMac.mm:
1745         (WebCore::FrameMac::advanceToNextMisspelling):
1746         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
1747
1748 2006-10-30  John Sullivan  <sullivan@apple.com>
1749
1750         Reviewed by Adam Roben
1751         
1752         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
1753         
1754         This patch introduces much of the guts of grammar checking, though still not enough to actually
1755         check grammar sensibly, due to:
1756           
1757         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
1758         context passed to grammar checker
1759
1760         * platform/Logging.h:
1761         * platform/Logging.cpp:
1762         new log channel SpellingAndGrammar
1763
1764         * bridge/mac/WebCorePageBridge.mm:
1765         (initializeLoggingChannelsIfNecessary):
1766         initialize new log channel
1767
1768         * bridge/mac/FrameMac.mm:
1769         (WebCore::FrameMac::advanceToNextMisspelling):
1770         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
1771         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
1772         in the event of a tie), and do further processing with that one (select range; create marker that
1773         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
1774         (WebCore::FrameMac::markMisspellings):
1775         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
1776         differently enough to make sharing code between these two functions a little tricky, so I decided to 
1777         save that for a later patch.
1778         
1779         (WebCore::FrameMac::respondToChangedSelection):
1780         remove grammar markers when we remove spelling markers        
1781
1782 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
1783
1784         Reviewed by Mitz.
1785
1786         Fix Qt/Linux build with older gcc3.3.4.
1787
1788         * bindings/js/kjs_window.cpp:
1789         (KJS::WindowFunc::callAsFunction):
1790
1791 2006-10-31  Zack Rusin  <zack@kde.org>
1792
1793         Reviewed by Mitz.
1794
1795         Fix the Qt build after last nights changes.
1796
1797         * WebCore/platform/qt/FrameQt.cpp:
1798         * WebCore/platform/qt/EditorClientQt.h:
1799         * WebCore/platform/qt/EditorClientQt.cpp:
1800         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1801         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1802         * WebCore/CMakeLists.txt:
1803         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
1804         * WebKitQt/QtLauncher/CMakeLists.txt:
1805         * WebKitQt/WebKitPart/CMakeLists.txt:
1806
1807 2006-10-30  Darin Adler  <darin@apple.com>
1808
1809         Reviewed by Anders.
1810
1811         - remove BrowserExtension
1812
1813         * WebCore.vcproj/WebCore/WebCore.vcproj:
1814         * WebCore.xcodeproj/project.pbxproj:
1815         * bindings/js/kjs_window.cpp:
1816         (KJS::createNewWindow):
1817         (KJS::WindowFunc::callAsFunction):
1818         * bridge/BrowserExtension.h: Removed.
1819         * bridge/mac/BrowserExtensionMac.h: Removed.
1820         * bridge/mac/BrowserExtensionMac.mm: Removed.
1821         * bridge/mac/FrameMac.mm:
1822         (WebCore::FrameMac::FrameMac):
1823         (WebCore::FrameMac::submitForm):
1824         (WebCore::FrameMac::urlSelected):
1825         * bridge/win/BrowserExtensionWin.cpp: Removed.
1826         * bridge/win/BrowserExtensionWin.h: Removed.
1827         * bridge/win/FrameWin.cpp:
1828         (WebCore::FrameWin::FrameWin):
1829         * loader/FrameLoader.cpp:
1830         (WebCore::FrameLoader::createWindow):
1831         * loader/FrameLoader.h:
1832         * loader/icon/IconLoader.cpp:
1833         * loader/mac/FrameLoaderMac.mm:
1834         (WebCore::FrameLoader::safeLoad):
1835         (WebCore::FrameLoader::load):
1836         (WebCore::FrameLoader::createWindow):
1837         * page/Frame.cpp:
1838         (WebCore::Frame::urlSelected):
1839         (WebCore::Frame::requestFrame):
1840         (WebCore::Frame::submitForm):
1841         (WebCore::Frame::scheduleHistoryNavigation):
1842         (WebCore::Frame::redirectionTimerFired):
1843         * page/Frame.h:
1844         * page/FrameLoadRequest.h:
1845         (WebCore::FrameLoadRequest::FrameLoadRequest):
1846         (WebCore::FrameLoadRequest::isEmpty):
1847         (WebCore::FrameLoadRequest::resourceRequest):
1848         (WebCore::FrameLoadRequest::frameName):
1849         (WebCore::FrameLoadRequest::setFrameName):
1850         * page/FramePrivate.h:
1851         (WebCore::FramePrivate::FramePrivate):
1852         (WebCore::FramePrivate::~FramePrivate):
1853         * platform/gdk/BrowserExtensionGdk.h: Removed.
1854         * platform/gdk/FrameGdk.cpp:
1855         (WebCore::FrameGdk::FrameGdk):
1856         * platform/gdk/TemporaryLinkStubs.cpp:
1857         * platform/network/ResourceRequest.h:
1858         (WebCore::ResourceRequest::isEmpty):
1859
1860 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1861
1862         Reviewed by Oliver.
1863
1864         Modified from original due to earlier reversion
1865
1866         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1867
1868         Better SVG integration in WebKit, Part I.
1869
1870         The patch is mostly about creating a new platform/graphics directory, and
1871         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1872         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1873         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1874
1875         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1876         All details of the patch, and upcoming patches can be found in the bug report.
1877
1878         * CMakeLists.txt:
1879         * WebCore.xcodeproj/project.pbxproj:
1880         * graphics/svg/SVGResource.cpp: Removed.
1881         * graphics/svg/SVGResourceClipper.cpp: Removed.
1882         * graphics/svg/SVGResourceClipper.h: Removed.
1883         * graphics/svg/SVGResourceImage.h: Removed.
1884         * graphics/svg/SVGResourceListener.h: Removed.
1885         * graphics/svg/SVGResourceMarker.cpp: Removed.
1886         * graphics/svg/SVGResourceMarker.h: Removed.
1887         * graphics/svg/SVGResourceMasker.cpp: Removed.
1888         * graphics/svg/SVGResourceMasker.h: Removed.
1889         * kcanvas/KCanvasClipper.cpp: Removed.
1890         * kcanvas/KCanvasClipper.h: Removed.
1891         * kcanvas/KCanvasCreator.cpp: Removed.
1892         * kcanvas/KCanvasCreator.h: Removed.
1893         * kcanvas/KCanvasFilters.cpp:
1894         (WebCore::getFilterById):
1895         * kcanvas/KCanvasFilters.h:
1896         * kcanvas/KCanvasImage.h: Removed.
1897         * kcanvas/KCanvasMarker.cpp: Removed.
1898         * kcanvas/KCanvasMarker.h: Removed.
1899         * kcanvas/KCanvasMasker.cpp: Removed.
1900         * kcanvas/KCanvasMasker.h: Removed.
1901         * kcanvas/KCanvasResource.cpp: Removed.
1902         * kcanvas/KCanvasResource.h: Removed.
1903         * kcanvas/KCanvasResourceListener.h: Removed.
1904         * kcanvas/KCanvasTreeDebug.cpp:
1905         (WebCore::writeRenderResources):
1906         * kcanvas/device/KRenderingDevice.h:
1907         * kcanvas/device/KRenderingPaintServer.h:
1908         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1909         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1910         (WebCore::KRenderingPaintServerGradient::listener):
1911         (WebCore::KRenderingPaintServerGradient::setListener):
1912         * kcanvas/device/KRenderingPaintServerGradient.h:
1913         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1914         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1915         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1916         (WebCore::KRenderingPaintServerPattern::tile):
1917         (WebCore::KRenderingPaintServerPattern::setTile):
1918         (WebCore::KRenderingPaintServerPattern::listener):
1919         (WebCore::KRenderingPaintServerPattern::setListener):
1920         * kcanvas/device/KRenderingPaintServerPattern.h:
1921         * kcanvas/device/KRenderingPaintServerSolid.h:
1922         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1923         * kcanvas/device/qt/KCanvasClipperQt.h:
1924         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1925         (WebCore::KRenderingDeviceQt::contextForImage):
1926         (WebCore::KRenderingDeviceQt::createResource):
1927         (WebCore::KRenderingDeviceQt::createPaintServer):
1928         * kcanvas/device/qt/KRenderingDeviceQt.h:
1929         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1930         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1931         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1932         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1933         * kcanvas/device/qt/RenderPathQt.h: Removed.
1934         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1935         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1936         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1937         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1938         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1939         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1940         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1941         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1942         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1943         (WebCore::KRenderingDeviceQuartz::contextForImage):
1944         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1945         (WebCore::KRenderingDeviceQuartz::createResource):
1946         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1947         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1948         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1949         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1950         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1951         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1952         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1953         (WebCore::patternCallback):
1954         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1955         * kcanvas/device/quartz/QuartzSupport.mm:
1956         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1957         (WebCore::sharedSolidPaintServer):
1958         * ksvg2/svg/SVGClipPathElement.cpp:
1959         (WebCore::SVGClipPathElement::SVGClipPathElement):
1960         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1961         (WebCore::SVGClipPathElement::canvasResource):
1962         * ksvg2/svg/SVGClipPathElement.h:
1963         * ksvg2/svg/SVGFEImageElement.cpp:
1964         * ksvg2/svg/SVGFilterElement.cpp:
1965         (WebCore::SVGFilterElement::SVGFilterElement):
1966         (WebCore::SVGFilterElement::~SVGFilterElement):
1967         (WebCore::SVGFilterElement::canvasResource):
1968         * ksvg2/svg/SVGFilterElement.h:
1969         * ksvg2/svg/SVGGradientElement.cpp:
1970         (WebCore::SVGGradientElement::SVGGradientElement):
1971         (WebCore::SVGGradientElement::~SVGGradientElement):
1972         (WebCore::SVGGradientElement::canvasResource):
1973         (WebCore::SVGGradientElement::resourceNotification):
1974         * ksvg2/svg/SVGGradientElement.h:
1975         * ksvg2/svg/SVGImageElement.cpp:
1976         * ksvg2/svg/SVGLinearGradientElement.cpp:
1977         (WebCore::SVGLinearGradientElement::buildGradient):
1978         * ksvg2/svg/SVGLinearGradientElement.h:
1979         * ksvg2/svg/SVGMarkerElement.cpp:
1980         (WebCore::SVGMarkerElement::SVGMarkerElement):
1981         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1982         (WebCore::SVGMarkerElement::canvasResource):
1983         * ksvg2/svg/SVGMarkerElement.h:
1984         * ksvg2/svg/SVGMaskElement.cpp:
1985         (WebCore::SVGMaskElement::SVGMaskElement):
1986         (WebCore::SVGMaskElement::~SVGMaskElement):
1987         (WebCore::SVGMaskElement::drawMaskerContent):
1988         (WebCore::SVGMaskElement::canvasResource):
1989         * ksvg2/svg/SVGMaskElement.h:
1990         * ksvg2/svg/SVGPatternElement.cpp:
1991         (WebCore::SVGPatternElement::SVGPatternElement):
1992         (WebCore::SVGPatternElement::~SVGPatternElement):
1993         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1994         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1995         (WebCore::SVGPatternElement::canvasResource):
1996         * ksvg2/svg/SVGPatternElement.h:
1997         * ksvg2/svg/SVGRadialGradientElement.cpp:
1998         (WebCore::SVGRadialGradientElement::buildGradient):
1999         * ksvg2/svg/SVGRadialGradientElement.h:
2000         * ksvg2/svg/SVGStyledElement.h:
2001         (WebCore::SVGStyledElement::canvasResource):
2002         * platform/GraphicsContext.cpp: Removed.
2003         * platform/GraphicsContext.h: Removed.
2004         * platform/GraphicsTypes.cpp: Removed.
2005         * platform/GraphicsTypes.h: Removed.
2006         * platform/graphics/GraphicsContext.cpp:
2007         (WebCore::GraphicsContextState::GraphicsContextState):
2008         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
2009         (WebCore::GraphicsContext::createGraphicsContextPrivate):
2010         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
2011         (WebCore::GraphicsContext::save):
2012         (WebCore::GraphicsContext::restore):
2013         (WebCore::GraphicsContext::font):
2014         (WebCore::GraphicsContext::setFont):
2015         (WebCore::GraphicsContext::pen):
2016         (WebCore::GraphicsContext::setPen):
2017         (WebCore::GraphicsContext::setFillColor):
2018         (WebCore::GraphicsContext::fillColor):
2019         (WebCore::GraphicsContext::updatingControlTints):
2020         (WebCore::GraphicsContext::setUpdatingControlTints):
2021         (WebCore::GraphicsContext::setPaintingDisabled):
2022         (WebCore::GraphicsContext::paintingDisabled):
2023         (WebCore::GraphicsContext::drawImage):
2024         (WebCore::GraphicsContext::drawText):
2025         (WebCore::GraphicsContext::drawHighlightForText):
2026         (WebCore::GraphicsContext::initFocusRing):
2027         (WebCore::GraphicsContext::clearFocusRing):
2028         (WebCore::GraphicsContext::focusRingBoundingRect):
2029         (WebCore::GraphicsContext::addFocusRingRect):
2030         (WebCore::GraphicsContext::focusRingWidth):
2031         (WebCore::GraphicsContext::focusRingOffset):
2032         (WebCore::GraphicsContext::focusRingRects):
2033         (WebCore::GraphicsContext::drawTiledImage):
2034         * platform/graphics/GraphicsContext.h:
2035         * platform/graphics/GraphicsTypes.cpp:
2036         (WebCore::):
2037         (WebCore::parseCompositeOperator):
2038         (WebCore::compositeOperatorName):
2039         (WebCore::parseLineCap):
2040         (WebCore::lineCapName):
2041         (WebCore::parseLineJoin):
2042         (WebCore::lineJoinName):
2043         * platform/graphics/GraphicsTypes.h:
2044         (WebCore::):
2045         * platform/graphics/svg/SVGResource.cpp: Added.
2046         (WebCore::SVGResource::SVGResource):
2047         (WebCore::SVGResource::~SVGResource):
2048         (WebCore::SVGResource::invalidate):
2049         (WebCore::SVGResource::addClient):
2050         (WebCore::SVGResource::clients):
2051         (WebCore::SVGResource::idInRegistry):
2052         (WebCore::SVGResource::setIdInRegistry):
2053         (WebCore::SVGResource::externalRepresentation):
2054         (WebCore::getResourceById):
2055         (WebCore::getPaintServerById):
2056         (WebCore::operator<<):
2057         * platform/graphics/svg/SVGResource.h: Added.
2058         (WebCore::):
2059         (WebCore::SVGResource::isPaintServer):
2060         (WebCore::SVGResource::isFilter):
2061         (WebCore::SVGResource::isClipper):
2062         (WebCore::SVGResource::isMarker):
2063         (WebCore::SVGResource::isMasker):
2064         (WebCore::SVGResourceListener::~SVGResourceListener):
2065         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
2066         (WebCore::SVGResourceClipper::SVGResourceClipper):
2067         (WebCore::SVGResourceClipper::~SVGResourceClipper):
2068         (WebCore::SVGResourceClipper::resetClipData):
2069         (WebCore::SVGResourceClipper::addClipData):
2070         (WebCore::SVGResourceClipper::clipData):
2071         (WebCore::SVGResourceClipper::externalRepresentation):
2072         (WebCore::operator<<):
2073         (WebCore::getClipperById):
2074         * platform/graphics/svg/SVGResourceClipper.h: Added.
2075         (WebCore::ClipDataList::addPath):
2076         (WebCore::SVGResourceClipper::isClipper):
2077         * platform/graphics/svg/SVGResourceImage.h: Added.
2078         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
2079         (WebCore::SVGResourceMarker::SVGResourceMarker):
2080         (WebCore::SVGResourceMarker::~SVGResourceMarker):
2081         (WebCore::SVGResourceMarker::setMarker):
2082         (WebCore::SVGResourceMarker::setRef):
2083         (WebCore::SVGResourceMarker::draw):
2084         (WebCore::SVGResourceMarker::externalRepresentation):
2085         (WebCore::getMarkerById):
2086         * platform/graphics/svg/SVGResourceMarker.h: Added.
2087         (WebCore::SVGResourceMarker::refX):
2088         (WebCore::SVGResourceMarker::refY):
2089         (WebCore::SVGResourceMarker::setAngle):
2090         (WebCore::SVGResourceMarker::setAutoAngle):
2091         (WebCore::SVGResourceMarker::angle):
2092         (WebCore::SVGResourceMarker::setUseStrokeWidth):
2093         (WebCore::SVGResourceMarker::useStrokeWidth):
2094         (WebCore::SVGResourceMarker::isMarker):
2095         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
2096         (WebCore::SVGResourceMasker::SVGResourceMasker):
2097         (WebCore::SVGResourceMasker::~SVGResourceMasker):
2098         (WebCore::SVGResourceMasker::setMask):
2099         (WebCore::SVGResourceMasker::mask):
2100         (WebCore::SVGResourceMasker::externalRepresentation):
2101         (WebCore::getMaskerById):
2102         * platform/graphics/svg/SVGResourceMasker.h: Added.
2103         (WebCore::SVGResourceMasker::isMasker):
2104         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
2105         (WebCore::SVGResourceClipper::applyClip):
2106         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
2107         (WebCore::SVGResourceImage::SVGResourceImage):
2108         (WebCore::SVGResourceImage::~SVGResourceImage):
2109         (WebCore::SVGResourceImage::init):
2110         (WebCore::SVGResourceImage::size):
2111         (WebCore::SVGResourceImage::cgLayer):
2112         (WebCore::SVGResourceImage::setCGLayer):
2113         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
2114         (WebCore::applyLuminanceToAlphaFilter):
2115         (WebCore::applyExpandAlphatoGrayscaleFilter):
2116         (WebCore::transformImageIntoGrayscaleMask):
2117         (WebCore::SVGResourceMasker::applyMask):
2118         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
2119         (WebCore::SVGResourceClipper::applyClip):
2120         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
2121         (WebCore::SVGResourceImage::init):
2122         (WebCore::SVGResourceImage::size):
2123         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
2124         (WebCore::SVGResourceMasker::applyMask):
2125         * platform/qt/GraphicsContextQt.cpp:
2126         * rendering/RenderPath.cpp:
2127         (WebCore::RenderPath::paint):
2128         (WebCore::DrawMarkersData::DrawMarkersData):
2129         (WebCore::RenderPath::drawMarkersIfNeeded):
2130         * rendering/RenderSVGContainer.cpp:
2131         (WebCore::RenderSVGContainer::paint):
2132         * rendering/RenderSVGImage.cpp:
2133         (WebCore::RenderSVGImage::paint):
2134         * rendering/SVGInlineFlowBox.cpp:
2135         (WebCore::paintSVGInlineFlow):
2136
2137 2006-10-30  John Sullivan  <sullivan@apple.com>
2138
2139         Reviewed by Brady
2140         
2141         - minor cleanup to make future patches clearer
2142
2143         * bridge/mac/FrameMac.mm:
2144         (WebCore::FrameMac::advanceToNextMisspelling):
2145         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
2146         with "continue" to better match structure of similar code in markMisspellings; a few
2147         other style tweaks.
2148         
2149         (WebCore::FrameMac::markMisspellings):
2150         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
2151         a block just after a break and outdented accordingly.
2152
2153 2006-10-30  John Sullivan  <sullivan@apple.com>
2154
2155         Reviewed by Geoff Garen
2156         
2157         WebCore part of change to push the code that updates the spelling panel
2158         into WebCore, in preparation for some grammar-checking stuff.
2159
2160         * bridge/mac/FrameMac.h:
2161         * bridge/mac/FrameMac.mm:
2162         (WebCore::FrameMac::advanceToNextMisspelling):
2163         no more return value for this method, and update the spelling panel with
2164         the misspelled word here rather than in the WebKit callers.
2165
2166 2006-10-30  Oliver Hunt  <oliver@apple.com>
2167
2168         Reviewed by Anders.
2169
2170         Roll out last patch
2171
2172         * CMakeLists.txt:
2173         * ChangeLog:
2174         * WebCore.xcodeproj/project.pbxproj:
2175         * graphics/svg/SVGResource.cpp:
2176         * graphics/svg/SVGResourceClipper.cpp:
2177         * graphics/svg/SVGResourceClipper.h:
2178         * graphics/svg/SVGResourceImage.h:
2179         * graphics/svg/SVGResourceListener.h:
2180         * graphics/svg/SVGResourceMarker.cpp:
2181         * graphics/svg/SVGResourceMarker.h:
2182         * graphics/svg/SVGResourceMasker.cpp:
2183         * graphics/svg/SVGResourceMasker.h:
2184         * kcanvas/KCanvasClipper.cpp: Added.
2185         (WebCore::operator<<):
2186         (WebCore::KCanvasClipper::KCanvasClipper):
2187         (WebCore::KCanvasClipper::~KCanvasClipper):
2188         (WebCore::KCanvasClipper::resetClipData):
2189         (WebCore::KCanvasClipper::addClipData):
2190         (WebCore::KCanvasClipper::clipData):
2191         (WebCore::KCanvasClipper::externalRepresentation):
2192         (WebCore::getClipperById):
2193         * kcanvas/KCanvasClipper.h: Added.
2194         (WebCore::KCClipData::windRule):
2195         (WebCore::KCClipDataList::KCClipDataList):
2196         (WebCore::KCClipDataList::addPath):
2197         (WebCore::KCanvasClipper::isClipper):
2198         * kcanvas/KCanvasFilters.cpp:
2199         (WebCore::getFilterById):
2200         * kcanvas/KCanvasFilters.h:
2201         * kcanvas/KCanvasImage.h: Added.
2202         (WebCore::KCanvasImage::KCanvasImage):
2203         (WebCore::KCanvasImage::~KCanvasImage):
2204         * kcanvas/KCanvasMarker.cpp: Added.
2205         (WebCore::KCanvasMarker::KCanvasMarker):
2206         (WebCore::KCanvasMarker::~KCanvasMarker):
2207         (WebCore::KCanvasMarker::setMarker):
2208         (WebCore::KCanvasMarker::setRef):
2209         (WebCore::KCanvasMarker::refX):
2210         (WebCore::KCanvasMarker::refY):
2211         (WebCore::KCanvasMarker::setAngle):
2212         (WebCore::KCanvasMarker::angle):
2213         (WebCore::KCanvasMarker::setAutoAngle):
2214         (WebCore::KCanvasMarker::setUseStrokeWidth):
2215         (WebCore::KCanvasMarker::useStrokeWidth):
2216         (WebCore::KCanvasMarker::draw):
2217         (WebCore::KCanvasMarker::externalRepresentation):
2218         (WebCore::getMarkerById):
2219         * kcanvas/KCanvasMarker.h: Added.
2220         (WebCore::KCanvasMarker::isMarker):
2221         * kcanvas/KCanvasMasker.cpp: Added.
2222         (WebCore::KCanvasMasker::KCanvasMasker):
2223         (WebCore::KCanvasMasker::~KCanvasMasker):
2224         (WebCore::KCanvasMasker::setMask):
2225         (WebCore::KCanvasMasker::externalRepresentation):
2226         (WebCore::getMaskerById):
2227         * kcanvas/KCanvasMasker.h: Added.
2228         (WebCore::KCanvasMasker::isMasker):
2229         (WebCore::KCanvasMasker::mask):
2230         * kcanvas/KCanvasResource.cpp: Added.
2231         (WebCore::operator<<):
2232         (WebCore::KCanvasResource::KCanvasResource):
2233         (WebCore::KCanvasResource::~KCanvasResource):
2234         (WebCore::KCanvasResource::addClient):
2235         (WebCore::KCanvasResource::clients):
2236         (WebCore::KCanvasResource::invalidate):
2237         (WebCore::KCanvasResource::idInRegistry):
2238         (WebCore::KCanvasResource::setIdInRegistry):
2239         (WebCore::KCanvasResource::externalRepresentation):
2240         (WebCore::getResourceById):
2241         (WebCore::getPaintServerById):
2242         * kcanvas/KCanvasResource.h:
2243         (WebCore::):
2244         (WebCore::KCanvasResource::isPaintServer):
2245         (WebCore::KCanvasResource::isFilter):
2246         (WebCore::KCanvasResource::isClipper):
2247         (WebCore::KCanvasResource::isMarker):
2248         (WebCore::KCanvasResource::isMasker):
2249         * kcanvas/KCanvasResourceListener.h: Added.
2250         (KCanvasResourceListener::KCanvasResourceListener):
2251         (KCanvasResourceListener::~KCanvasResourceListener):
2252         * kcanvas/KCanvasTreeDebug.cpp:
2253         (WebCore::writeRenderResources):
2254         * kcanvas/device/KRenderingDevice.h:
2255         * kcanvas/device/KRenderingPaintServer.h:
2256         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2257         (WebCore::KRenderingPaintServer::idInRegistry):
2258         (WebCore::KRenderingPaintServer::setIdInRegistry):
2259         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2260         (WebCore::KRenderingPaintServerGradient::listener):
2261         (WebCore::KRenderingPaintServerGradient::setListener):
2262         * kcanvas/device/KRenderingPaintServerGradient.h:
2263         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2264         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
2265         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
2266         (WebCore::KRenderingPaintServerPattern::tile):
2267         (WebCore::KRenderingPaintServerPattern::setTile):
2268         (WebCore::KRenderingPaintServerPattern::listener):
2269         (WebCore::KRenderingPaintServerPattern::setListener):
2270         * kcanvas/device/KRenderingPaintServerPattern.h:
2271         * kcanvas/device/KRenderingPaintServerSolid.h:
2272         * kcanvas/device/qt/KCanvasClipperQt.cpp:
2273         (WebCore::KCanvasClipperQt::applyClip):
2274         * kcanvas/device/qt/KCanvasClipperQt.h:
2275         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
2276         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2277         (WebCore::KRenderingDeviceQt::contextForImage):
2278         (WebCore::KRenderingDeviceQt::createResource):
2279         (WebCore::KRenderingDeviceQt::createPaintServer):
2280         * kcanvas/device/qt/KRenderingDeviceQt.h:
2281         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
2282         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
2283         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
2284         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
2285         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2286         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
2287         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2288         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2289         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
2290         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2291         (WebCore::applyLuminanceToAlphaFilter):
2292         (WebCore::applyExpandAlphatoGrayscaleFilter):
2293         (WebCore::transformImageIntoGrayscaleMask):
2294         (WebCore::KCanvasMaskerQuartz::applyMask):
2295         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2296         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
2297         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
2298         (WebCore::KCanvasImageQuartz::init):
2299         (WebCore::KCanvasImageQuartz::size):
2300         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2301         (WebCore::KCanvasClipperQuartz::applyClip):
2302         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
2303         (WebCore::KCanvasImageQuartz::cgLayer):
2304         (WebCore::KCanvasImageQuartz::setCGLayer):
2305         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2306         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2307         (WebCore::KRenderingDeviceQuartz::contextForImage):
2308         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2309         (WebCore::KRenderingDeviceQuartz::createResource):
2310         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2311         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
2312         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
2313         (WebCore::KRenderingPaintServerGradientQuartz::setup):
2314         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2315         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2316         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2317         (WebCore::patternCallback):
2318         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2319         * kcanvas/device/quartz/QuartzSupport.mm:
2320         * ksvg2/misc/KCanvasRenderingStyle.cpp:
2321         (WebCore::sharedSolidPaintServer):
2322         * ksvg2/svg/SVGClipPathElement.cpp:
2323         (WebCore::SVGClipPathElement::SVGClipPathElement):
2324         (WebCore::SVGClipPathElement::~SVGClipPathElement):
2325         (WebCore::SVGClipPathElement::canvasResource):
2326         * ksvg2/svg/SVGClipPathElement.h:
2327         * ksvg2/svg/SVGFEImageElement.cpp:
2328         * ksvg2/svg/SVGFilterElement.cpp:
2329         (WebCore::SVGFilterElement::SVGFilterElement):
2330         (WebCore::SVGFilterElement::~SVGFilterElement):
2331         (WebCore::SVGFilterElement::canvasResource):
2332         * ksvg2/svg/SVGFilterElement.h:
2333         * ksvg2/svg/SVGGradientElement.cpp:
2334         (WebCore::SVGGradientElement::SVGGradientElement):
2335         (WebCore::SVGGradientElement::~SVGGradientElement):
2336         (WebCore::SVGGradientElement::canvasResource):
2337         (WebCore::SVGGradientElement::resourceNotification):
2338         * ksvg2/svg/SVGGradientElement.h:
2339         * ksvg2/svg/SVGImageElement.cpp:
2340         * ksvg2/svg/SVGLinearGradientElement.cpp:
2341         (WebCore::SVGLinearGradientElement::buildGradient):
2342         * ksvg2/svg/SVGLinearGradientElement.h:
2343         * ksvg2/svg/SVGMarkerElement.cpp:
2344         (WebCore::SVGMarkerElement::SVGMarkerElement):
2345         (WebCore::SVGMarkerElement::~SVGMarkerElement):
2346         (WebCore::SVGMarkerElement::canvasResource):
2347         * ksvg2/svg/SVGMarkerElement.h:
2348         * ksvg2/svg/SVGMaskElement.cpp:
2349         (WebCore::SVGMaskElement::SVGMaskElement):
2350         (WebCore::SVGMaskElement::~SVGMaskElement):
2351         (WebCore::SVGMaskElement::drawMaskerContent):
2352         (WebCore::SVGMaskElement::canvasResource):
2353         * ksvg2/svg/SVGMaskElement.h:
2354         * ksvg2/svg/SVGPatternElement.cpp:
2355         (WebCore::SVGPatternElement::SVGPatternElement):
2356         (WebCore::SVGPatternElement::~SVGPatternElement):
2357         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2358         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
2359         (WebCore::SVGPatternElement::canvasResource):
2360         * ksvg2/svg/SVGPatternElement.h:
2361         * ksvg2/svg/SVGRadialGradientElement.cpp:
2362         (WebCore::SVGRadialGradientElement::buildGradient):
2363         * ksvg2/svg/SVGRadialGradientElement.h:
2364         * ksvg2/svg/SVGStyledElement.h:
2365         (WebCore::SVGStyledElement::canvasResource):
2366         * platform/GraphicsContext.cpp: Added.
2367         (WebCore::GraphicsContextState::GraphicsContextState):
2368         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
2369         (WebCore::GraphicsContext::createGraphicsContextPrivate):
2370         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
2371         (WebCore::GraphicsContext::save):
2372         (WebCore::GraphicsContext::restore):
2373         (WebCore::GraphicsContext::font):
2374         (WebCore::GraphicsContext::setFont):
2375         (WebCore::GraphicsContext::pen):
2376         (WebCore::GraphicsContext::setPen):
2377         (WebCore::GraphicsContext::setFillColor):
2378         (WebCore::GraphicsContext::fillColor):
2379         (WebCore::GraphicsContext::updatingControlTints):
2380         (WebCore::GraphicsContext::setUpdatingControlTints):
2381         (WebCore::GraphicsContext::setPaintingDisabled):
2382         (WebCore::GraphicsContext::paintingDisabled):
2383         (WebCore::GraphicsContext::drawImage):
2384         (WebCore::GraphicsContext::drawText):
2385         (WebCore::GraphicsContext::drawHighlightForText):
2386         (WebCore::GraphicsContext::initFocusRing):
2387         (WebCore::GraphicsContext::clearFocusRing):
2388         (WebCore::GraphicsContext::focusRingBoundingRect):
2389         (WebCore::GraphicsContext::addFocusRingRect):
2390         (WebCore::GraphicsContext::focusRingWidth):
2391         (WebCore::GraphicsContext::focusRingOffset):
2392         (WebCore::GraphicsContext::focusRingRects):
2393         (WebCore::GraphicsContext::drawTiledImage):
2394         * platform/GraphicsContext.h: Added.
2395         * platform/GraphicsTypes.cpp: Added.
2396         (WebCore::):
2397         (WebCore::parseCompositeOperator):
2398         (WebCore::compositeOperatorName):
2399         (WebCore::parseLineCap):
2400         (WebCore::lineCapName):
2401         (WebCore::parseLineJoin):
2402         (WebCore::lineJoinName):
2403         * platform/GraphicsTypes.h: Added.
2404         (WebCore::):
2405         * platform/graphics/GraphicsContext.cpp:
2406         * platform/graphics/GraphicsContext.h:
2407         * platform/graphics/GraphicsTypes.cpp:
2408         * platform/graphics/GraphicsTypes.h:
2409         * platform/qt/GraphicsContextQt.cpp:
2410         * rendering/RenderPath.cpp:
2411         (WebCore::RenderPath::paint):
2412         (WebCore::DrawMarkersData::DrawMarkersData):
2413         (WebCore::RenderPath::drawMarkersIfNeeded):
2414         * rendering/RenderSVGContainer.cpp:
2415         (WebCore::RenderSVGContainer::paint):
2416         * rendering/RenderSVGImage.cpp:
2417         (WebCore::RenderSVGImage::paint):
2418         * rendering/SVGInlineFlowBox.cpp:
2419         (WebCore::paintSVGInlineFlow):
2420
2421 2006-10-30  John Sullivan  <sullivan@apple.com>
2422
2423         Reviewed by Geoff Garen.
2424         
2425         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
2426         grammar-related method.
2427
2428         * bridge/EditorClient.h:
2429         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
2430         isGrammarCheckingEnabled()
2431         
2432         * bridge/mac/WebCoreFrameBridge.h:
2433         removed bridge equivalents
2434
2435         * bridge/mac/FrameMac.mm:
2436         (WebCore::FrameMac::advanceToNextMisspelling):
2437         convert bridge-using code to editor()->client()-using code
2438         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
2439         ditto
2440         (WebCore::FrameMac::markMisspellings):
2441         ditto
2442         (WebCore::FrameMac::respondToChangedSelection):
2443         ditto
2444         
2445         * editing/Editor.h:
2446         * editing/Editor.cpp:
2447         (WebCore::Editor::client):
2448         new method, returns EditorClient pointer. In an ideal world all the code that needed to
2449         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
2450         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
2451
2452 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
2453
2454         Reviewed by Darin.
2455
2456         Removed a number of editing and selection methods from the bridge.
2457         
2458         I moved cross-platform editing and selection code into Editor and 
2459         SelectionController, respecitvely.
2460
2461         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
2462         everything + the kitchen sink.
2463         
2464         Specific comments below for interesting things.
2465         
2466         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
2467         a new file so that WebKit can use them, too. Added a helper method for
2468         handling exceptions when selecting a Range.
2469         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
2470         WebKit, since they have to do with creating an NSAttributedString for API
2471         consumption, and not much to do with general Frame functionality.
2472         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
2473         for now) into the Editor. Eventually, the Frame will not have to notify 
2474         the Editor of what the lastEditCommand was, since the Editor will perform
2475         all EditCommands.
2476         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
2477         * editing/SelectionController.cpp:
2478         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
2479         and return them. The bridge method to select a DOM range did this implicitly,
2480         since all ObjC DOM operations handle DOM exceptions by throwing them as
2481         ObjC exceptions.
2482         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
2483         The two enumerations are numerically identical, but that's an implementation
2484         detail of TextAffinity that clients shouldn't be required to know about.
2485
2486 2006-10-30  Timothy Hatcher  <timothy@apple.com>
2487
2488         Rolling out the following change because this crash:
2489         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
2490
2491         And this regression:
2492         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
2493
2494     2006-09-06  David Harrison  <harrison@apple.com>
2495
2496         Reviewed and tweaked by Tim H. 
2497
2498         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
2499
2500         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
2501         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
2502         No layout tests affected. Not testable in an automated way that will work on all systems. 
2503
2504         * platform/mac/WebFontCache.mm: 
2505         (+[WebFontCache fontWithFamily:traits:size:]): 
2506
2507 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
2508
2509         Reviewed by harrison
2510
2511         <rdar://problem/4808375>
2512         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
2513
2514         * editing/TextIterator.cpp:
2515         (WebCore::TextIterator::exitNode): Only create VisiblePositions
2516         when we're going to use them to create a range for an emitted character.
2517         We should further speed TextIterators up by avoiding creating VisiblePositions
2518         for TIs that are only used for the characters they emit (like the one that 
2519         plainText uses).
2520
2521 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
2522
2523         Reviewed by Mitz.
2524
2525         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
2526         More rendering code cleaning
2527
2528         * WebCore.xcodeproj/project.pbxproj:
2529         * rendering/RenderApplet.cpp:
2530         (WebCore::RenderApplet::RenderApplet):
2531         (WebCore::RenderApplet::createWidgetIfNecessary):
2532         * rendering/RenderApplet.h:
2533         * rendering/RenderArena.cpp:
2534         (WebCore::):
2535         (WebCore::RenderArena::RenderArena):
2536         (WebCore::RenderArena::allocate):
2537         (WebCore::RenderArena::free):
2538         * rendering/RenderArena.h:
2539         * rendering/RenderBR.cpp:
2540         (WebCore::RenderBR::RenderBR):
2541         (WebCore::RenderBR::baselinePosition):
2542         (WebCore::RenderBR::lineHeight):
2543         (WebCore::RenderBR::setStyle):
2544         (WebCore::RenderBR::caretMinOffset):
2545         (WebCore::RenderBR::positionForCoordinates):
2546         (WebCore::RenderBR::inlineBox):
2547         * rendering/RenderBR.h:
2548         * rendering/RenderBlock.cpp:
2549         * rendering/RenderBlock.h:
2550         (WebCore::RenderBlock::maxTopMargin):
2551         (WebCore::RenderBlock::maxBottomMargin):
2552         (WebCore::RenderBlock::initMaxMarginValues):
2553         (WebCore::RenderBlock::containsFloats):
2554         (WebCore::RenderBlock::setHasMarkupTruncation):
2555         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
2556         (WebCore::RenderBlock::BlockSelectionInfo::block):
2557         (WebCore::RenderBlock::BlockSelectionInfo::state):
2558         (WebCore::RenderBlock::FloatingObject::FloatingObject):
2559         (WebCore::RenderBlock::CompactInfo::clear):
2560         * rendering/RenderButton.cpp:
2561         (WebCore::RenderButton::removeChild):
2562         (WebCore::RenderButton::paintObject):
2563         * rendering/RenderButton.h:
2564         (WebCore::RenderButton::renderName):
2565         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
2566         * rendering/RenderContainer.cpp:
2567         (WebCore::RenderContainer::RenderContainer):
2568         * rendering/RenderContainer.h:
2569         (WebCore::RenderContainer::firstChild):
2570         (WebCore::RenderContainer::lastChild):
2571         (WebCore::RenderContainer::calcMinMaxWidth):
2572         * rendering/RenderCounter.cpp:
2573         (WebCore::RenderCounter::RenderCounter):
2574         (WebCore::toRoman):
2575         (WebCore::toHebrew):
2576         (WebCore::RenderCounter::calcMinMaxWidth):
2577         * rendering/RenderCounter.h:
2578         * rendering/RenderFieldset.cpp:
2579         (WebCore::RenderFieldset::paintBoxDecorations):
2580         (WebCore::RenderFieldset::paintBorderMinusLegend):
2581         (WebCore::RenderFieldset::setStyle):
2582         * rendering/RenderFileUploadControl.cpp:
2583         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
2584         (WebCore::RenderFileUploadControl::setStyle):
2585         (WebCore::RenderFileUploadControl::paintObject):
2586         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
2587         * rendering/RenderFileUploadControl.h:
2588         (WebCore::RenderFileUploadControl::renderName):
2589         * rendering/RenderFlexibleBox.h:
2590         * rendering/RenderFlow.cpp:
2591         * rendering/RenderFlow.h:
2592         * rendering/RenderForeignObject.cpp:
2593         (WebCore::RenderForeignObject::RenderForeignObject):
2594         (WebCore::RenderForeignObject::paint):
2595         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
2596         (WebCore::RenderForeignObject::layout):
2597         (WebCore::RenderForeignObject::nodeAtPoint):
2598         * rendering/RenderForeignObject.h:
2599         (WebCore::RenderForeignObject::renderName):
2600         * rendering/RenderFormElement.cpp:
2601         (WebCore::RenderFormElement::setStyle):
2602         (WebCore::RenderFormElement::layout):
2603         (WebCore::RenderFormElement::textAlignment):
2604         * rendering/RenderFormElement.h:
2605         * rendering/RenderFrame.cpp:
2606         * rendering/RenderFrame.h:
2607         (WebCore::RenderFrame::element):
2608         * rendering/RenderFrameSet.cpp:
2609         * rendering/RenderFrameSet.h:
2610         (WebCore::RenderFrameSet::element):
2611         * rendering/RenderHTMLCanvas.cpp:
2612         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
2613         (WebCore::RenderHTMLCanvas::paint):
2614         * rendering/RenderHTMLCanvas.h:
2615         (WebCore::RenderHTMLCanvas::renderName):
2616         * rendering/RenderImage.cpp:
2617         (WebCore::RenderImage::RenderImage):
2618         (WebCore::RenderImage::setStyle):
2619         (WebCore::RenderImage::setContentObject):
2620         (WebCore::RenderImage::setCachedImage):
2621         (WebCore::RenderImage::imageChanged):
2622         (WebCore::RenderImage::paint):
2623         (WebCore::RenderImage::layout):
2624         (WebCore::RenderImage::updateAltText):
2625         * rendering/RenderImage.h:
2626         (WebCore::RenderImage::element):
2627         * rendering/RenderInline.cpp:
2628         (WebCore::RenderInline::RenderInline):
2629         (WebCore::RenderInline::~RenderInline):
2630         (WebCore::RenderInline::setStyle):
2631         (WebCore::RenderInline::addChildToFlow):
2632         (WebCore::RenderInline::cloneInline):
2633         (WebCore::RenderInline::splitInlines):
2634         (WebCore::RenderInline::splitFlow):
2635         (WebCore::RenderInline::paint):
2636         (WebCore::RenderInline::absoluteRects):
2637         (WebCore::RenderInline::calcMinMaxWidth):
2638         (WebCore::RenderInline::requiresLayer):
2639         (WebCore::RenderInline::width):
2640         (WebCore::RenderInline::height):
2641         (WebCore::RenderInline::renderName):
2642         (WebCore::RenderInline::nodeAtPoint):
2643         (WebCore::RenderInline::positionForCoordinates):
2644         * rendering/RenderInline.h:
2645         (WebCore::RenderInline::layout):
2646         * rendering/RenderLayer.cpp:
2647         * rendering/RenderLayer.h:
2648         (WebCore::ClipRects::ClipRects):
2649         (WebCore::RenderLayer::nextSibling):
2650         (WebCore::RenderLayer::root):
2651         (WebCore::RenderLayer::setPos):
2652         (WebCore::RenderLayer::height):
2653         (WebCore::RenderLayer::relativePositionOffset):
2654         * rendering/RenderLineEdit.cpp:
2655         (WebCore::RenderLineEdit::setStyle):
2656         (WebCore::RenderLineEdit::updateFromElement):
2657         (WebCore::RenderLineEdit::selectionStart):
2658         (WebCore::RenderLineEdit::selectionEnd):
2659         (WebCore::RenderLineEdit::setSelectionStart):
2660         (WebCore::RenderLineEdit::setSelectionEnd):
2661         (WebCore::RenderLineEdit::setSelectionRange):
2662         * rendering/RenderLineEdit.h:
2663         * rendering/RenderListBox.cpp:
2664         * rendering/RenderListBox.h:
2665         (WebCore::RenderListBox::renderName):
2666         * rendering/RenderListItem.cpp:
2667         (WebCore::RenderListItem::setStyle):
2668         (WebCore::getParentOfFirstLineBox):
2669         (WebCore::RenderListItem::updateMarkerLocation):
2670         (WebCore::RenderListItem::positionListMarker):
2671         (WebCore::RenderListItem::paint):
2672         * rendering/RenderListItem.h:
2673         * rendering/RenderListMarker.cpp:
2674         * rendering/RenderListMarker.h:
2675         (WebCore::RenderListMarker::renderName):
2676         (WebCore::RenderListMarker::isListMarker):
2677
2678 2006-10-30  Timothy Hatcher  <timothy@apple.com>
2679
2680         Reviewed by Hyatt.
2681
2682         <rdar://problem/4478625> Basic table editing and culling
2683
2684         Refined the criteria for deletable elements, rely on the renderer more.
2685         Corrected the interface positioning for elements that have borders.
2686
2687         * editing/DeleteButtonController.cpp:
2688         (WebCore::isDeletableElement):
2689         (WebCore::DeleteButtonController::show):
2690
2691 2006-10-30  Darin Adler  <darin@apple.com>
2692
2693         - fix build
2694
2695         * loader/ResourceLoader.h: Added header guard.
2696
2697 2006-10-31  Darin Adler  <darin@apple.com>
2698
2699         Reviewed by Adam.
2700
2701         - fix FrameLoader files so they can be built on non-Mac platforms
2702
2703         * page/FramePrivate.h:
2704         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
2705         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
2706
2707         * page/Page.h:
2708         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
2709         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
2710         the other day.
2711
2712         * bridge/mac/FrameMac.mm:
2713         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
2714         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
2715
2716         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
2717         around the PolicyCheck definition.
2718
2719         * loader/FormState.cpp: Changed import to include.
2720         * loader/FrameLoader.cpp: Ditto.
2721         * loader/MainResourceLoader.h: Ditto.
2722
2723         * loader/FrameLoaderTypes.h: Added a header guard.
2724
2725         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
2726         Added #if PLATFORM(MAC) around Mac-specific details.
2727         * loader/SubresourceLoader.h: Ditto.
2728
2729         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
2730         m_loader from m_frameLoader.
2731
2732         * CMakeLists.txt: Updated.
2733         * WebCoreSources.bkl: Updated.
2734
2735 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
2736
2737         Reviewed and landed by Anders.
2738
2739         Patch by Zack rusin to fix: 
2740         http://bugs.webkit.org/show_bug.cgi?id=11429
2741
2742         Fix startup crash.
2743
2744         * platform/qt/FrameQtClient.cpp:
2745         (WebCore::FrameQtClientDefault::openURL):
2746
2747 2006-10-30  Zach Rusin  <zack@kde.org>
2748
2749         Reviewed and landed by Anders.
2750
2751         * platform/network/qt/ResourceHandleQt.cpp:
2752         (WebCore::ResourceHandle::receivedResponse):
2753         * platform/qt/FrameQtClient.cpp:
2754         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
2755         * platform/qt/LoaderFunctionsQt.cpp:
2756         (WebCore::ServeSynchronousRequest):
2757         More build fixes.
2758
2759 2006-10-30  Simon Hausmann  <hausmann@kde.org>
2760
2761         Reviewed and landed by Anders.
2762         
2763         - fix Qt build
2764         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
2765         ResourceHandleClient
2766
2767 2006-10-30  Darin Adler  <darin@apple.com>
2768
2769         Reviewed by John Sullivan.
2770
2771         - work toward removing Objective-C data types from FrameLoader.h:
2772           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
2773           and WebCoreResourceHandle
2774         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
2775
2776         * page/PageState.h:
2777         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
2778
2779         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
2780         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
2781         double for the date instead of an NSDate.
2782
2783         * bridge/mac/WebCoreFrameBridge.h:
2784         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
2785         saveDocumentToPageCache methods.
2786
2787         * bridge/mac/WebCorePageState.h:
2788         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
2789         an Objective-C wrapper for PageState.
2790
2791         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
2792         NSDate and WebCorePageState.
2793         * loader/FrameLoaderClient.h: Changed NSDate to double.
2794         * loader/mac/FrameLoaderMac.mm:
2795         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
2796         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
2797         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
2798         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
2799         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
2800         extract the parameters from the response. Changed the open function that takes
2801         a PageState to use the new C++ PageState.
2802         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
2803         function; tightened up logic, removing a few cases that could never happen, as
2804         well as the unused reload boolean.
2805
2806         * ForwardingHeaders/kjs/property_map.h: Added.
2807
2808         * WebCore.exp: Updated.
2809         * WebCore.xcodeproj/project.pbxproj: Updated.
2810
2811 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2812
2813         Reviewed by Anders.
2814
2815         - added ResourceResponse class and didReceiveResponse delegate call
2816         
2817         * WebCore.xcodeproj/project.pbxproj: Added new files.
2818         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
2819         expiresTimeForResponse: method.
2820         * dom/XMLTokenizer.cpp:
2821         (WebCore::openFunc): Updated to use ResourceResponse.
2822         * loader/FrameLoader.h: Update loadResourceSynchronously to
2823         use ResourceResponse.
2824         * loader/LoaderFunctions.h:
2825         * loader/icon/IconLoader.cpp:
2826         (IconLoader::didReceiveResponse): Updated from receivedResponse
2827         and made cross-platform.
2828         * loader/icon/IconLoader.h: updated for above change
2829         * loader/loader.cpp:
2830         (WebCore::Loader::receivedResponse): reduced to just saving
2831         the PlatformResponse (ideally we'd phase out use of this).
2832         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
2833         logic.
2834         * loader/loader.h:
2835         * loader/mac/FrameLoaderMac.mm:
2836         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2837         as ResourceResponse.
2838         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2839         * loader/mac/LoaderFunctionsMac.mm:
2840         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2841         argument.
2842         * platform/network/ResourceHandle.cpp:
2843         * platform/network/ResourceHandle.h: Remove calls for
2844         broken out response pieces.
2845         * platform/network/ResourceHandleClient.h:
2846         (WebCore::ResourceHandleClient::didReceiveResponse): New
2847         delegate method.
2848         * platform/network/ResourceHandleInternal.h:
2849         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2850         storage of response bits, we're not gonna return them
2851         seprately any more.
2852         * platform/network/ResourceResponse.h: Added.
2853         (WebCore::ResourceResponse::ResourceResponse): Freshly
2854         implemented. Same for below.
2855         (WebCore::ResourceResponse::url):
2856         (WebCore::ResourceResponse::mimeType):
2857         (WebCore::ResourceResponse::expectedContentLength):
2858         (WebCore::ResourceResponse::textEncodingName):
2859         (WebCore::ResourceResponse::suggestedFilename):
2860         (WebCore::ResourceResponse::httpStatusCode):
2861         (WebCore::ResourceResponse::setHTTPStatusCode):
2862         (WebCore::ResourceResponse::httpHeaderField):
2863         (WebCore::ResourceResponse::httpHeaderFields):
2864         (WebCore::ResourceResponse::isMultipart):
2865         (WebCore::ResourceResponse::setExpirationDate):
2866         (WebCore::ResourceResponse::expirationDate):
2867         * platform/network/cf/ResourceHandleCFNet.cpp:
2868         (WebCore::didReceiveResponse): Send didReceiveResponse
2869         client method.
2870         * platform/network/cf/ResourceResponseCFNet.h: Added.
2871         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2872         (getResourceResponse): Helper function to get a ResourceResponse 
2873         from CFURLResponseRef.
2874         * platform/network/mac/ResourceHandleMac.mm:
2875         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2876         Don't bother cleaning up fields we no longer have.
2877         (WebCore::ResourceHandle::receivedResponse): Send
2878         didReceiveResponse client method.
2879         * platform/network/mac/ResourceResponseMac.h: Added.
2880         * platform/network/mac/ResourceResponseMac.mm: Added.
2881         (getResourceResponse): Helper function to get a ResourceResponse 
2882         from an NSURLResponse*.
2883         * rendering/HitTestResult.cpp:
2884         * xml/XSLTProcessor.cpp:
2885         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2886         * xml/xmlhttprequest.cpp:
2887         (WebCore::XMLHttpRequest::getResponseText): Store http response
2888         info in the form of a ResourceResponse, change all methods to
2889         account for this.
2890         (WebCore::XMLHttpRequest::getResponseXML):
2891         (WebCore::XMLHttpRequest::XMLHttpRequest):
2892         (WebCore::XMLHttpRequest::open):
2893         (WebCore::XMLHttpRequest::send):
2894         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2895         (WebCore::XMLHttpRequest::getResponseHeader):
2896         (WebCore::XMLHttpRequest::getStatus):
2897         (WebCore::XMLHttpRequest::getStatusText):
2898         (WebCore::XMLHttpRequest::processSyncLoadResults):
2899         (WebCore::XMLHttpRequest::didFinishLoading):
2900         (WebCore::XMLHttpRequest::didReceiveResponse):
2901         (WebCore::XMLHttpRequest::didReceiveData):
2902         * xml/xmlhttprequest.h:
2903
2904 2006-10-29  Darin Adler  <darin@apple.com>
2905
2906         - fix build
2907
2908         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2909         * loader/NetscapePlugInStreamLoader.h: Ditto.
2910         * loader/ResourceLoader.h: Ditto.
2911
2912 2006-10-29  Darin Adler  <darin@apple.com>
2913
2914         - one last name change -- WebFormState.h to FormState.h
2915         - added more empty placeholder platform-independent files
2916           for currently-Mac-specific loader classes
2917
2918         * loader/FormState.cpp: Updated include.
2919         * loader/FrameLoader.cpp: Updated include.
2920         * loader/mac/FrameLoaderMac.mm: Updated include.
2921
2922         * loader/WebFormState.h: Removed.
2923         * loader/FormState.h: Added.
2924
2925         * loader/DocumentLoader.cpp: Added.
2926         * loader/MainResourceLoader.cpp: Added.
2927         * loader/NetscapePlugInStreamLoader.cpp: Added.
2928         * loader/ResourceLoader.cpp: Added.
2929         * loader/SubresourceLoader.cpp: Added.
2930
2931         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2932
2933 2006-10-29  Darin Adler  <darin@apple.com>
2934
2935         - did the do-webcore-rename renames, including a number of changes
2936           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2937           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2938           and improvements to the names of decoder classes and their source
2939           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2940
2941         * CMakeLists.txt:
2942         * WebCore.exp:
2943         * WebCore.vcproj/WebCore/WebCore.vcproj:
2944         * WebCore.xcodeproj/project.pbxproj:
2945         * WebCoreSources.bkl:
2946         * bindings/js/kjs_binding.cpp:
2947         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2948         * bindings/js/kjs_events.cpp:
2949         (KJS::JSAbstractEventListener::handleEvent):
2950         (KJS::JSLazyEventListener::parseCode):
2951         * bindings/js/kjs_html.cpp:
2952         (KJS::JSHTMLElement::implementsCall):
2953         * bindings/js/kjs_traversal.cpp:
2954         (KJS::JSNodeFilterCondition::acceptNode):
2955         * bindings/js/kjs_window.cpp:
2956         (KJS::Window::interpreter):
2957         (KJS::Window::retrieveWindow):
2958         (KJS::Window::retrieve):
2959         (KJS::ScheduledAction::execute):
2960         * bindings/objc/DOMInternal.mm:
2961         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2962         * bridge/mac/FrameMac.mm:
2963         (WebCore::FrameMac::executionContextForDOM):
2964         (WebCore::FrameMac::bindingRootObject):
2965         (WebCore::FrameMac::windowScriptObject):
2966         (WebCore::FrameMac::windowScriptNPObject):
2967         (WebCore::FrameMac::partClearedInBegin):
2968         * bridge/mac/WebCoreEncodings.mm:
2969         * bridge/mac/WebCoreFrameBridge.mm:
2970         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2971         (-[WebCoreFrameBridge stringWithData:]):
2972         (-[WebCoreFrameBridge executionContextForView:]):
2973         * bridge/win/FrameWin.cpp:
2974         * dom/Document.cpp:
2975         (WebCore::Document::inputEncoding):
2976         (WebCore::Document::setCharset):
2977         (WebCore::Document::createHTMLEventListener):
2978         (WebCore::Document::setDecoder):
2979         * dom/Document.h:
2980         (WebCore::Document::decoder):
2981         * dom/EventTargetNode.cpp:
2982         (WebCore::EventTargetNode::dispatchGenericEvent):
2983         * html/HTMLParser.cpp:
2984         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2985         (WebCore::HTMLParser::canvasCreateErrorCheck):
2986         (WebCore::HTMLParser::isInline):
2987         * html/HTMLPlugInElement.cpp:
2988         (WebCore::HTMLPlugInElement::createNPObject):
2989         * html/HTMLScriptElement.cpp:
2990         (WebCore::HTMLScriptElement::evaluateScript):
2991         * html/HTMLTokenizer.cpp:
2992         (WebCore::HTMLTokenizer::parseTag):
2993         (WebCore::HTMLTokenizer::processToken):
2994         * ksvg2/misc/SVGDocumentExtensions.cpp:
2995         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2996         * loader/CachedCSSStyleSheet.cpp:
2997         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2998         (WebCore::CachedCSSStyleSheet::setEncoding):
2999         * loader/CachedCSSStyleSheet.h:
3000         * loader/CachedXBLDocument.cpp:
3001         (WebCore::CachedXBLDocument::CachedXBLDocument):
3002         (WebCore::CachedXBLDocument::setEncoding):
3003         * loader/CachedXBLDocument.h:
3004         * loader/CachedXSLStyleSheet.cpp:
3005         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
3006         (WebCore::CachedXSLStyleSheet::setEncoding):
3007         * loader/CachedXSLStyleSheet.h:
3008         * loader/Decoder.cpp: Removed.
3009         * loader/Decoder.h: Removed.
3010         * loader/FrameLoader.cpp:
3011         * loader/FrameLoader.h:
3012         * loader/FrameLoaderClient.h:
3013         * loader/MainResourceLoader.h: Added.
3014         * loader/NetscapePlugInStreamLoader.h: Added.
3015         * loader/Request.h:
3016         (WebCore::Request::cachedResource):
3017         * loader/ResourceLoader.h: Added.
3018         * loader/SubresourceLoader.h: Added.
3019         * loader/TextResourceDecoder.cpp: Added.
3020         (WebCore::TextResourceDecoder::determineContentType):
3021         (WebCore::TextResourceDecoder::defaultEncoding):
3022         (WebCore::TextResourceDecoder::TextResourceDecoder):
3023         (WebCore::TextResourceDecoder::~TextResourceDecoder):
3024         (WebCore::TextResourceDecoder::setEncoding):
3025         (WebCore::TextResourceDecoder::checkForBOM):
3026         (WebCore::TextResourceDecoder::checkForCSSCharset):
3027         (WebCore::TextResourceDecoder::checkForHeadCharset):
3028         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
3029         (WebCore::TextResourceDecoder::decode):
3030         (WebCore::TextResourceDecoder::flush):
3031         * loader/TextResourceDecoder.h: Added.
3032         * loader/WebDocumentLoader.h: Removed.
3033         * loader/WebLoader.h: Removed.
3034         * loader/WebMainResourceLoader.h: Removed.
3035         * loader/WebNetscapePlugInStreamLoader.h: Removed.
3036         * loader/WebSubresourceLoader.h: Removed.
3037         * loader/loader.cpp:
3038         (WebCore::Loader::servePendingRequests):
3039         (WebCore::Loader::receivedAllData):
3040         (WebCore::Loader::receivedResponse):
3041         (WebCore::Loader::didReceiveData):
3042         (WebCore::Loader::cancelRequests):
3043         (WebCore::Loader::jobForRequest):
3044         * loader/mac/DocumentLoaderMac.mm:
3045         * loader/mac/FormDataStream.m: Added.
3046         * loader/mac/FrameLoaderMac.mm:
3047         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3048         (WebCore::FrameLoader::addPlugInStreamLoader):
3049         (WebCore::FrameLoader::removePlugInStreamLoader):
3050         (WebCore::FrameLoader::addSubresourceLoader):
3051         (WebCore::FrameLoader::removeSubresourceLoader):
3052         (WebCore::FrameLoader::willSendRequest):
3053         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
3054         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
3055         (WebCore::FrameLoader::didReceiveResponse):
3056         (WebCore::FrameLoader::didReceiveData):
3057         (WebCore::FrameLoader::didFinishLoad):
3058         (WebCore::FrameLoader::didFailToLoad):
3059         (WebCore::FrameLoader::open):
3060         (WebCore::FrameLoader::willUseArchive):
3061         (WebCore::FrameLoader::isArchiveLoadPending):
3062         * loader/mac/ImageDocumentMac.mm:
3063         * loader/mac/LoaderFunctionsMac.mm:
3064         (WebCore::CheckCacheObjectStatus):
3065         * loader/mac/MainResourceLoaderMac.mm:
3066         (WebCore::MainResourceLoader::MainResourceLoader):
3067         (WebCore::MainResourceLoader::releaseDelegate):
3068         (WebCore::MainResourceLoader::didCancel):
3069         (WebCore::MainResourceLoader::addData):
3070         (WebCore::MainResourceLoader::willSendRequest):
3071         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3072         (WebCore::MainResourceLoader::didReceiveData):
3073         (WebCore::MainResourceLoader::didFinishLoading):
3074         (WebCore::MainResourceLoader::setDefersLoading):
3075         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
3076         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
3077         (WebCore::NetscapePlugInStreamLoader::releaseResources):
3078         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
3079         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
3080         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
3081         (WebCore::NetscapePlugInStreamLoader::didFail):
3082         (WebCore::NetscapePlugInStreamLoader::didCancel):
3083         * loader/mac/ResourceLoaderMac.mm:
3084         (WebCore::ResourceLoader::ResourceLoader):
3085         (WebCore::ResourceLoader::~ResourceLoader):
3086         (WebCore::ResourceLoader::releaseResources):
3087         (WebCore::ResourceLoader::load):
3088         (WebCore::ResourceLoader::setDefersLoading):
3089         (WebCore::ResourceLoader::frameLoader):
3090         (WebCore::ResourceLoader::addData):
3091         (WebCore::ResourceLoader::resourceData):
3092         (WebCore::ResourceLoader::clearResourceData):
3093         (WebCore::ResourceLoader::willSendRequest):
3094         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
3095         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
3096         (WebCore::ResourceLoader::didReceiveResponse):
3097         (WebCore::ResourceLoader::didReceiveData):
3098         (WebCore::ResourceLoader::willStopBufferingData):
3099         (WebCore::ResourceLoader::didFinishLoading):
3100         (WebCore::ResourceLoader::didFinishLoadingOnePart):
3101         (WebCore::ResourceLoader::didFail):
3102         (WebCore::ResourceLoader::willCacheResponse):
3103         (WebCore::ResourceLoader::didCancel):
3104         (WebCore::ResourceLoader::cancel):
3105         (WebCore::ResourceLoader::setIdentifier):
3106         (WebCore::ResourceLoader::response):
3107         (WebCore::ResourceLoader::inConnectionCallback):
3108         (WebCore::ResourceLoader::cancelledError):
3109         (WebCore::ResourceLoader::receivedCredential):
3110         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
3111         (WebCore::ResourceLoader::receivedCancellation):
3112         (WebCore::ResourceLoader::delegate):
3113         (WebCore::ResourceLoader::releaseDelegate):
3114         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
3115         * loader/mac/SubresourceLoaderMac.mm:
3116         (WebCore::SubresourceLoader::SubresourceLoader):
3117         (WebCore::SubresourceLoader::willSendRequest):
3118         (WebCore::SubresourceLoader::didReceiveResponse):
3119         (WebCore::SubresourceLoader::didReceiveData):
3120         (WebCore::SubresourceLoader::didFinishLoading):
3121         (WebCore::SubresourceLoader::didFail):
3122         (WebCore::SubresourceLoader::didCancel):
3123         * loader/mac/WebFormDataStream.h: Removed.
3124         * loader/mac/WebFormDataStream.m: Removed.
3125         * page/Frame.cpp:
3126         (WebCore::Frame::javaScriptEnabled):
3127         (WebCore::Frame::scriptProxy):
3128         (WebCore::Frame::executeScript):
3129         (WebCore::Frame::write):
3130         (WebCore::Frame::userGestureHint):
3131         (WebCore::Frame::saveInterpreterBuiltins):
3132         (WebCore::Frame::restoreInterpreterBuiltins):
3133         (WebCore::Frame::backslashAsCurrencySymbol):
3134         * page/Frame.h:
3135         * page/FramePrivate.h:
3136         * platform/StreamingTextDecoder.cpp: Removed.
3137         * platform/StreamingTextDecoder.h: Removed.
3138         * platform/StreamingTextDecoderICU.cpp: Removed.
3139         * platform/StreamingTextDecoderICU.h: Removed.
3140         * platform/TextCodec.cpp: Added.
3141         * platform/TextCodec.h: Added.
3142         * platform/TextCodecICU.cpp: Added.
3143         * platform/TextCodecICU.h: Added.
3144         * platform/TextCodecLatin1.h:
3145         * platform/TextCodecUTF16.h:
3146         * platform/TextDecoder.h:
3147         * platform/TextEncoding.cpp:
3148         * platform/TextEncodingRegistry.cpp:
3149         * platform/image-decoders/jpeg/jmorecfg.h:
3150         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
3151         * platform/mac/StreamingTextDecoderMac.h: Removed.
3152         * platform/mac/TextCodecMac.cpp: Added.
3153         * platform/mac/TextCodecMac.h: Added.
3154         * platform/network/ResourceHandleInternal.h:
3155         * platform/network/mac/ResourceHandleMac.mm:
3156         * platform/qt/FrameQt.cpp:
3157         (WebCore::FrameQt::bindingRootObject):
3158         * platform/qt/LoaderFunctionsQt.cpp:
3159         (WebCore::CheckCacheObjectStatus):
3160         * rendering/RenderObject.cpp:
3161         (WebCore::RenderObject::backslashAsCurrencySymbol):
3162         * xml/XSLTProcessor.cpp:
3163         (WebCore::XSLTProcessor::createDocumentFromSource):
3164         * xml/xmlhttprequest.cpp:
3165         (WebCore::XMLHttpRequest::didReceiveData):
3166         * xml/xmlhttprequest.h:
3167
3168 2006-10-29  Darin Adler  <darin@apple.com>
3169
3170         Rubber stamped by Adam (kinda).
3171
3172         - add Mac suffixes and correct filenames inside loader/mac
3173
3174         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
3175
3176         * loader/mac/FrameLoader.mm: Removed.
3177         * loader/mac/WebDocumentLoader.mm: Removed.
3178         * loader/mac/WebLoader.mm: Removed.
3179         * loader/mac/WebMainResourceLoader.mm: Removed.
3180         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
3181         * loader/mac/WebSubresourceLoader.mm: Removed.
3182
3183         * loader/mac/FrameLoaderMac.mm: Added.
3184         * loader/mac/DocumentLoaderMac.mm: Added.
3185         * loader/mac/ResourceLoaderMac.mm: Added.
3186         * loader/mac/MainResourceLoaderMac.mm: Added.
3187         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
3188         * loader/mac/SubresourceLoaderMac.mm: Removed.
3189
3190 2006-10-29  Darin Adler  <darin@apple.com>
3191
3192         Reviewed by Adam.
3193
3194         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
3195           and FrameLoader.cpp mostly ready
3196
3197         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
3198         FormState.cpp. Removed WebFormState.mm.
3199
3200         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
3201         get this header compiling on non-Mac.
3202         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
3203         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
3204
3205         * loader/FrameLoaderClient.h: Added some ifdefs.
3206         * loader/WebDocumentLoader.h: Ditto.
3207         * loader/WebLoader.h: Ditto.
3208         * loader/WebMainResourceLoader.h: Ditto.
3209
3210         * loader/mac/WebDocumentLoader.mm:
3211         (WebCore::DocumentLoader::isLoadingInAPISense):
3212         Rewrote to work without bridge, partly to remove the need for ObjC
3213         bridge type in the header, and also because we're tearing down the bridge.
3214
3215         * loader/mac/WebMainResourceLoader.mm:
3216         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
3217         m_contentLength and m_bytesReceived.
3218         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
3219         (WebCore::MainResourceLoader::didReceiveData): Ditto.
3220
3221         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
3222         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
3223
3224         * loader/mac/FormState.mm: Removed.
3225         * loader/FormState.cpp: Added.
3226
3227 2006-10-29  Darin Adler  <darin@apple.com>
3228
3229         Rubber stamped by Adam.
3230
3231         - moving towards use of FrameLoader cross-platform; move the headers
3232           for the Mac loader from loader/mac into loader, in preparation for
3233           making them useful on non-Mac
3234
3235         * WebCore.xcodeproj/project.pbxproj:
3236
3237         * loader/mac/FrameLoader.h: Removed.
3238         * loader/mac/WebDocumentLoader.h: Removed.
3239         * loader/mac/WebFormState.h: Removed.
3240         * loader/mac/WebLoader.h: Removed.
3241         * loader/mac/WebMainResourceLoader.h: Removed.
3242         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
3243         * loader/mac/WebSubresourceLoader.h: Removed.
3244
3245         * loader/FrameLoader.h: Added.
3246         * loader/WebDocumentLoader.h: Added.
3247         * loader/WebFormState.h: Added.
3248         * loader/WebLoader.h: Added.
3249         * loader/WebMainResourceLoader.h: Added.
3250         * loader/WebNetscapePlugInStreamLoader.h: Added.
3251         * loader/WebSubresourceLoader.h: Added.
3252
3253 2006-10-29  Adam Roben  <aroben@apple.com>
3254
3255         Reviewed by Geoff.
3256
3257         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
3258         r17405.
3259
3260         * platform/DeprecatedString.h:
3261
3262 2006-10-29  Beth Dakin  <bdakin@apple.com>
3263
3264         Rubber stamped by Geoff.
3265
3266         This is a followup to my HitTestResult checkin. Most of the 
3267         HitTestResult local variables in the code were named i or info for 
3268         when the class was named NodeInfo. This patch renames all of these 
3269         local variables to result.
3270
3271         * dom/Document.cpp:
3272         (WebCore::Document::prepareMouseEvent):
3273         * html/HTMLAreaElement.cpp:
3274         (WebCore::HTMLAreaElement::mapMouseEvent):
3275         * html/HTMLMapElement.cpp:
3276         (WebCore::HTMLMapElement::mapMouseEvent):
3277         * rendering/EllipsisBox.cpp:
3278         (WebCore::EllipsisBox::nodeAtPoint):
3279         * rendering/EllipsisBox.h:
3280         * rendering/InlineBox.cpp:
3281         (WebCore::InlineBox::nodeAtPoint):
3282         * rendering/InlineFlowBox.cpp:
3283         (WebCore::InlineFlowBox::nodeAtPoint):
3284         * rendering/InlineTextBox.cpp:
3285         (WebCore::InlineTextBox::nodeAtPoint):
3286         * rendering/RenderBlock.cpp:
3287         (WebCore::RenderBlock::isPointInScrollbar):
3288         (WebCore::RenderBlock::nodeAtPoint):
3289         * rendering/RenderBlock.h:
3290         * rendering/RenderBox.cpp:
3291         (WebCore::RenderBox::nodeAtPoint):
3292         * rendering/RenderBox.h:
3293         * rendering/RenderFlow.cpp:
3294         (WebCore::RenderFlow::hitTestLines):
3295         * rendering/RenderFlow.h:
3296         * rendering/RenderForeignObject.cpp:
3297         (WebCore::RenderForeignObject::nodeAtPoint):
3298         * rendering/RenderFrameSet.cpp:
3299         (WebCore::RenderFrameSet::nodeAtPoint):
3300         * rendering/RenderImage.cpp:
3301         (WebCore::RenderImage::nodeAtPoint):
3302         * rendering/RenderInline.cpp:
3303         (WebCore::RenderInline::nodeAtPoint):
3304         * rendering/RenderInline.h:
3305         * rendering/RenderLayer.cpp:
3306         (WebCore::RenderLayer::autoscroll):
3307         (WebCore::RenderLayer::hitTest):
3308         (WebCore::RenderLayer::hitTestLayer):
3309         (WebCore::RenderLayer::updateHoverActiveState):
3310         * rendering/RenderListBox.cpp:
3311         (WebCore::RenderListBox::isPointInScrollbar):
3312         * rendering/RenderObject.cpp:
3313         (WebCore::RenderObject::hitTest):
3314         (WebCore::RenderObject::setInnerNode):
3315         (WebCore::RenderObject::nodeAtPoint):
3316         * rendering/RenderObject.h:
3317         * rendering/RenderPath.cpp:
3318         (WebCore::RenderPath::nodeAtPoint):
3319         * rendering/RenderSVGImage.cpp:
3320         (WebCore::RenderSVGImage::nodeAtPoint):
3321         * rendering/RenderSVGText.cpp:
3322         (WebCore::RenderSVGText::nodeAtPoint):
3323         * rendering/RenderTableRow.cpp:
3324         (WebCore::RenderTableRow::nodeAtPoint):
3325         * rendering/RenderTableRow.h:
3326         * rendering/RenderTableSection.cpp:
3327         (WebCore::RenderTableSection::nodeAtPoint):
3328         * rendering/RenderTableSection.h:
3329         * rendering/RenderTextControl.cpp:
3330         (WebCore::RenderTextControl::nodeAtPoint):
3331         * rendering/RootInlineBox.cpp:
3332         (WebCore::RootInlineBox::nodeAtPoint):
3333         * rendering/RootInlineBox.h:
3334
3335 2006-10-29  Adam Roben  <aroben@apple.com>
3336
3337         More semi-fixes.
3338
3339         * page/Page.cpp: Forgot to wrap the actual definition of
3340         setDefersLoading() in PLATFORM(MAC).
3341         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
3342
3343 2006-10-29  Adam Roben  <aroben@apple.com>
3344
3345         Build semi-fix.
3346
3347         Move all FrameLoader-related code in Page.{cpp,h} within #if
3348         PLATFORM(MAC), since this class currently only exists on Mac.
3349
3350         * page/Page.cpp:
3351         * page/Page.h:
3352
3353 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
3354
3355         build fix.
3356         
3357         * platform/PlatformString.h:
3358         (WebCore::String::operator NSString*):
3359
3360 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
3361
3362         Rolled out accidental commit.
3363         
3364         * platform/AtomicString.h:
3365         (WebCore::AtomicString::AtomicString):
3366         (WebCore::AtomicString::operator NSString*):
3367
3368 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
3369
3370         RS by Darin.
3371
3372         Rolled out change to map NULL Strings to nil NSStrings because it caused
3373         even more AppKit crashes. Maybe we should remove the NSString * operator
3374         entirely, since its use is not straight-forward, and require callers to
3375         specify explicitly whether they tolerate NULL.
3376         
3377         * platform/AtomicString.h:
3378         * platform/PlatformString.h:
3379         (WebCore::String::operator NSString*):
3380         * platform/mac/TextFieldMac.mm:
3381         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3382
3383 2006-10-29  Darin Adler  <darin@apple.com>
3384
3385         Reviewed by Geoff.
3386
3387         - fixed storage leak showing up on the buildbot
3388
3389         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
3390         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
3391
3392 2006-10-29  Darin Adler  <darin@apple.com>
3393
3394         Rubber stamped by Adam.
3395
3396         - renamed WebFrameLoaderClient to match the class name inside it
3397
3398         * loader/mac/WebFrameLoaderClient.h: Removed.
3399         * loader/FrameLoaderClient.h: Moved it here.
3400
3401         * WebCore.xcodeproj/project.pbxproj: Updated project.
3402
3403         * bridge/mac/FrameMac.mm: Updated includes.
3404         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
3405         * loader/mac/FrameLoader.mm: Ditto.
3406         * loader/mac/WebLoader.h: Ditto.
3407
3408 2006-10-29  Darin Adler  <darin@apple.com>
3409
3410         Reviewed by Mitz.
3411
3412         - fix crash visible on buildbot and also when running the test
3413           anchor-image-scrolled-x-y.html under libgmalloc
3414
3415         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
3416         now that the class is named ResourceHandle.
3417         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
3418         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
3419         a local RefPtr before calling finishJobAndHandle, since we might get
3420         cancelled inside that function, so we should not rely on m_handle to
3421         keep the ResourceHandle alive.
3422         (WebCore::SubresourceLoader::didFail): Ditto.
3423         (WebCore::SubresourceLoader::didCancel): Ditto.
3424
3425 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
3426
3427         - build fix
3428
3429         * platform/network/mac/ResourceHandleMac.mm:
3430
3431 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
3432
3433         Rubber stamped by Darin.
3434
3435         - renamed ResourceLoader to ResourceHandle (and same for related classes)
3436
3437         * CMakeLists.txt:
3438         * Projects/gdk/webcore-gdk.bkl:
3439         * WebCore.vcproj/WebCore/WebCore.vcproj:
3440         * WebCore.xcodeproj/project.pbxproj:
3441         * WebCoreSources.bkl:
3442         * bridge/mac/FrameMac.mm:
3443         * bridge/win/FrameWin.cpp:
3444         * dom/XMLTokenizer.cpp:
3445         * loader/Cache.cpp:
3446         * loader/CachedResource.h:
3447         * loader/LoaderFunctions.h:
3448         * loader/icon/IconLoader.cpp:
3449         (IconLoader::startLoading):
3450         (IconLoader::didReceiveData):
3451         (IconLoader::didFinishLoading):
3452         * loader/icon/IconLoader.h:
3453         * loader/loader.cpp:
3454         (WebCore::Loader::servePendingRequests):
3455         (WebCore::Loader::receivedAllData):
3456         (WebCore::Loader::receivedResponse):
3457         (WebCore::Loader::didReceiveData):
3458         (WebCore::Loader::cancelRequests):
3459         (WebCore::Loader::jobForRequest):
3460         * loader/loader.h:
3461         * loader/mac/IconLoaderMac.mm:
3462         (IconLoader::receivedResponse):
3463         * loader/mac/LoaderFunctionsMac.mm:
3464         * loader/mac/WebLoader.h:
3465         * loader/mac/WebSubresourceLoader.h:
3466         * loader/mac/WebSubresourceLoader.mm:
3467         (WebCore::SubresourceLoader::SubresourceLoader):
3468         (WebCore::SubresourceLoader::create):
3469         * platform/gdk/FrameGdk.cpp:
3470         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
3471         (WebCore::FrameGdkClientDefault::openURL):
3472         (WebCore::FrameGdkClientDefault::submitForm):
3473         (WebCore::FrameGdkClientDefault::receivedResponse):
3474         (WebCore::FrameGdkClientDefault::didReceiveData):
3475         (WebCore::FrameGdkClientDefault::receivedAllData):
3476         * platform/gdk/FrameGdk.h:
3477         * platform/gdk/TemporaryLinkStubs.cpp:
3478         (WebCore::ServeSynchronousRequest):
3479         (WebCore::ResourceHandle::assembleResponseHeaders):
3480         (WebCore::ResourceHandle::retrieveCharset):
3481         * platform/network/ResourceHandle.cpp: Added.
3482         (WebCore::ResourceHandle::ResourceHandle):
3483         (WebCore::ResourceHandle::create):
3484         (WebCore::ResourceHandle::isErrorPage):
3485         (WebCore::ResourceHandle::error):
3486         (WebCore::ResourceHandle::setError):
3487         (WebCore::ResourceHandle::responseEncoding):
3488         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
3489         (WebCore::ResourceHandle::kill):
3490         (WebCore::ResourceHandle::requestHeaders):
3491         (WebCore::ResourceHandle::url):
3492         (WebCore::ResourceHandle::postData):
3493         (WebCore::ResourceHandle::method):
3494         (WebCore::ResourceHandle::client):
3495         * platform/network/ResourceHandle.h: Added.
3496         (WebCore::ResourceHandle::getInternal):
3497         * platform/network/ResourceHandleClient.h: Added.
3498         (WebCore::ResourceHandleClient::~ResourceHandleClient):
3499         (WebCore::ResourceHandleClient::didReceiveData):
3500         (WebCore::ResourceHandleClient::didFinishLoading):
3501         (WebCore::ResourceHandleClient::receivedRedirect):
3502         (WebCore::ResourceHandleClient::receivedResponse):
3503         (WebCore::ResourceHandleClient::receivedAllData):
3504         * platform/network/ResourceHandleInternal.h: Added.
3505         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3506         * platform/network/ResourceLoader.cpp: Removed.
3507         * platform/network/ResourceLoader.h: Removed.
3508         * platform/network/ResourceLoaderClient.h: Removed.
3509         * platform/network/ResourceLoaderInternal.h: Removed.
3510         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
3511         (WebCore::willSendRequest):
3512         (WebCore::didReceiveResponse):
3513         (WebCore::didReceiveData):
3514         (WebCore::didFinishLoading):
3515         (WebCore::didFail):
3516         (WebCore::willCacheResponse):
3517         (WebCore::didReceiveChallenge):
3518         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3519         (WebCore::ResourceHandle::~ResourceHandle):
3520         (WebCore::ResourceHandle::start):
3521         (WebCore::ResourceHandle::cancel):
3522         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
3523         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
3524         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3525         (WebCore::ResourceHandle::~ResourceHandle):
3526         (WebCore::ResourceHandle::start):
3527         (WebCore::ResourceHandle::cancel):
3528         * platform/network/gdk/ResourceHandleManager.cpp: Added.
3529         (WebCore::ResourceHandleManager::ResourceHandleManager):
3530         (WebCore::ResourceHandleManager::get):
3531         (WebCore::ResourceHandleManager::useSimpleTransfer):
3532         (WebCore::writeCallback):
3533         (WebCore::ResourceHandleManager::downloadTimerCallback):
3534         (WebCore::ResourceHandleManager::remove):
3535         (WebCore::ResourceHandleManager::add):
3536         (WebCore::ResourceHandleManager::cancel):
3537         * platform/network/gdk/ResourceHandleManager.h: Added.
3538         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
3539         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
3540         * platform/network/gdk/ResourceLoaderManager.h: Removed.
3541         * platform/network/mac/ResourceHandleMac.mm: Added.
3542         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
3543         (WebCore::ResourceHandle::~ResourceHandle):
3544         (WebCore::ResourceHandle::start):
3545         (WebCore::ResourceHandle::assembleRespon