Reviewed by Mitz.
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-14  Nikolas Zimmermann  <zimmermann@kde.org>
2
3         Reviewed by Mitz.
4
5         Fix Qt/Linux build & some little fixes:
6
7         - Adapt to Maciej's FrameLoadRequest changes.
8         - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
9         - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
10         - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
11
12         * loader/CachedCSSStyleSheet.cpp:
13         (WebCore::CachedCSSStyleSheet::checkNotify):
14         * loader/CachedResource.h:
15         (WebCore::CachedResource::CachedResource):
16         * loader/loader.cpp:
17         (WebCore::Loader::receivedAllData):
18         (WebCore::Loader::receivedResponse):
19         * platform/qt/BrowserExtensionQt.cpp:
20         (WebCore::BrowserExtensionQt::createNewWindow):
21         * platform/qt/BrowserExtensionQt.h:
22         * platform/qt/FrameQt.cpp:
23         (WebCore::FrameQt::submitForm):
24         (WebCore::FrameQt::urlSelected):
25         (WebCore::FrameQt::openURLRequest):
26         * platform/qt/FrameQt.h:
27         * platform/qt/GraphicsContextQt.cpp:
28         (WebCore::GraphicsContext::setURLForRect):
29         * platform/qt/TemporaryLinkStubs.cpp:
30         (WebCore::CacheObjectExpiresTime):
31         (WebCore::ResponseIsMultipart):
32         (WebCore::CachedResource::setResponse):
33         (WebCore::CachedResource::setAllData):
34
35 2006-10-14  David Carson  <dacarson@gmail.com>
36
37         Reviewed by Maciej.
38
39         Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
40         Removed Mac platform dependance, changed WebCore functions to
41         use PlatformResponse/PlatformData rather than NSURLResponse/
42         NSData. 
43
44         * loader/CachedCSSStyleSheet.cpp:
45         (WebCore::CachedCSSStyleSheet::checkNotify):
46         * loader/CachedImage.cpp:
47         (WebCore::CachedImage::createImage):
48         * loader/CachedResource.cpp:
49         (WebCore::CachedResource::~CachedResource):
50         * loader/CachedResource.h:
51         (WebCore::CachedResource::CachedResource):
52         (WebCore::CachedResource::response):
53         (WebCore::CachedResource::allData):
54         * loader/LoaderFunctions.h:
55         * loader/loader.cpp:
56         (WebCore::Loader::receivedResponse):
57         * loader/mac/LoaderFunctionsMac.mm:
58         (WebCore::ResponseMIMEType):
59         (WebCore::ResponseIsMultipart):
60         (WebCore::CacheObjectExpiresTime):
61         (WebCore::CachedResource::setResponse):
62         (WebCore::CachedResource::setAllData):
63         * platform/qt/TemporaryLinkStubs.cpp:
64         (WebCore::CacheObjectExpiresTime):
65         (WebCore::ResponseIsMultipart):
66         (WebCore::ResponseMIMEType):
67         (WebCore::CachedResource::setResponse):
68         (WebCore::CachedResource::setAllData):
69         * platform/win/TemporaryLinkStubs.cpp:
70         (WebCore::CacheObjectExpiresTime):
71         (WebCore::ResponseIsMultipart):
72         (WebCore::ResponseMIMEType):
73         (WebCore::CachedResource::setResponse):
74         (WebCore::CachedResource::setAllData):
75
76 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
77
78         Reviewed by Maciej.
79
80         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
81         Pure virtual classes require non-pure destructor, who knew.
82
83         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
84         so that other platforms can also use CURL, if they wish.
85
86         Silence compiler warning about unused variable in SharedTimerLinux.cpp
87
88         * platform/ResourceLoaderInternal.h:
89         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
90         * platform/gdk/FrameGdk.h:
91         (WebCore::FrameGdkClient::~FrameGdkClient):
92         * platform/gdk/ResourceLoaderManager.cpp:
93         (WebCore::ResourceLoaderManager::downloadTimerCallback):
94         * platform/gdk/SharedTimerLinux.cpp:
95         (WebCore::stopSharedTimer):
96
97 2006-10-13  Beth Dakin  <bdakin@apple.com>
98
99         Reviewed by Geoff.
100
101         Build fix from my last check-in. Make hasOutlineAnnotation() non-
102         inline so that we don't have to include Document.h in 
103         RenderObject.h
104         Doing so causes a build failure in WebKit, and it probably isn't a 
105         good idea anyway.
106
107         * rendering/RenderObject.cpp:
108         (WebCore::RenderObject::hasOutlineAnnotation):
109         * rendering/RenderObject.h:
110         (WebCore::RenderObject::hasOutline):
111
112 2006-10-13  Beth Dakin  <bdakin@apple.com>
113
114         Patch written mostly by Ken Kraisler, but also by me.
115
116         Reviewed by Hyatt.
117
118         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
119         problem/3391162> PDF created by printing should have live 
120         hyperlinks
121
122         * platform/GraphicsContext.cpp:
123         (WebCore::GraphicsContext::focusRingBoundingRect):
124         * platform/GraphicsContext.h:
125         * platform/cairo/GraphicsContextCairo.cpp:
126         (WebCore::GraphicsContext::setURLForRect):
127         * platform/cg/GraphicsContextCG.cpp:
128         (WebCore::GraphicsContext::setURLForRect): Implement method to add 
129         URL link to PDF document.
130         * rendering/InlineFlowBox.cpp:
131         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
132         querying the outline width
133         * rendering/RenderBlock.cpp:
134         (WebCore::RenderBlock::paintObject): Same as above.
135         * rendering/RenderFlow.cpp:
136         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
137         (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
138         pdf url rects, and outline painting.
139         * rendering/RenderFlow.h:
140         * rendering/RenderObject.cpp:
141         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
142         link to a rectanglular region.
143         (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
144         well as focus ring painting.
145         * rendering/RenderObject.h:
146         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
147         element is a link and we are printing.
148         (WebCore::RenderObject::hasOutline): Returns true is the style has 
149         an outline and hasOutlineAnnotation() is true.
150         * rendering/RenderStyle.h:
151         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
152         greater than 0 and outlineStyle is greater than BHIDDEN.
153
154 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
155
156         Reviewed by ggaren and harrison
157         
158         <rdar://problem/4744008>
159         9A270: Mail crashes when I try to paste large items from Safari
160
161         * editing/ReplaceSelectionCommand.cpp:
162         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
163         Even though we put nodes in the hash map in pre-order, they don't necessary
164         come out of the iterator that way.  If a node is a redundant style span
165         and one of its pruned ancestors comes off the hash map after it, and that
166         ancestor is a redundant style span or font tag, we will try to remove it
167         even though it has already been removed and we'll crash.
168         The test case added with the fix depends on our hash map implementation
169         because it requires that a particular redundant style span come out of 
170         the iterator before its parent. So, it may eventually not provide 
171         coverage for the fix.
172
173 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
174
175         Reviewed by Darin.
176
177         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
178
179         * WebCore.xcodeproj/project.pbxproj:
180         * bindings/js/kjs_window.cpp:
181         (KJS::createNewWindow):
182         (KJS::WindowFunc::callAsFunction):
183         * bridge/BrowserExtension.h:
184         * bridge/mac/BrowserExtensionMac.h:
185         * bridge/mac/BrowserExtensionMac.mm:
186         (WebCore::BrowserExtensionMac::createNewWindow):
187         * bridge/mac/FrameMac.h:
188         * bridge/mac/FrameMac.mm:
189         (WebCore::FrameMac::submitForm):
190         (WebCore::FrameMac::openURLRequest):
191         (WebCore::FrameMac::urlSelected):
192         * bridge/win/BrowserExtensionWin.h:
193         * page/Frame.cpp:
194         (WebCore::Frame::changeLocation):
195         (WebCore::Frame::urlSelected):
196         (WebCore::Frame::requestFrame):
197         (WebCore::Frame::submitForm):
198         * page/Frame.h:
199         * page/FrameLoadRequest.h: Added.
200         (WebCore::FrameLoadRequest::FrameLoadRequest):
201         (WebCore::FrameLoadRequest::lockHistory):
202         (WebCore::FrameLoadRequest::setLockHistory):
203         * page/ResourceRequest.h:
204         (WebCore::ResourceRequest::ResourceRequest):
205
206 2006-10-13  John Sullivan  <sullivan@apple.com>
207
208         Reviewed by Maciej
209
210         * loader/mac/WebFrameLoader.mm:
211         (-[WebFrameLoader loadDocumentLoader:]):
212         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
213         happen when loading a page during a decidePolicyForNavigationAction callback.
214
215 2006-10-13  Dave Hyatt  <hyatt@apple.com>
216
217         Transparency layer work.
218
219         Reviewed by aroben
220
221         * platform/GraphicsContext.h:
222         * platform/cg/GraphicsContextCG.cpp:
223         (WebCore::GraphicsContext::beginTransparencyLayer):
224         (WebCore::GraphicsContext::endTransparencyLayer):
225         * platform/cg/GraphicsContextPlatformPrivate.h:
226         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
227         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
228
229 2006-10-13  Rob Buis  <buis@kde.org>
230
231         Reviewed by Mitz.
232
233         http://bugs.webkit.org/show_bug.cgi?id=11217
234         Cleanup svg coding style
235
236         Cleanup coding style in svg paint server classes.
237
238         * ksvg2/svg/SVGGradientElement.cpp:
239         (WebCore::SVGGradientElement::SVGGradientElement):
240         (WebCore::SVGGradientElement::parseMappedAttribute):
241         (WebCore::SVGGradientElement::notifyAttributeChange):
242         (WebCore::SVGGradientElement::canvasResource):
243         (WebCore::SVGGradientElement::rebuildStops):
244         * ksvg2/svg/SVGGradientElement.h:
245         * ksvg2/svg/SVGLinearGradientElement.cpp:
246         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
247         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
248         (WebCore::SVGLinearGradientElement::buildGradient):
249         * ksvg2/svg/SVGLinearGradientElement.h:
250         * ksvg2/svg/SVGPatternElement.cpp:
251         (WebCore::SVGPatternElement::SVGPatternElement):
252         (WebCore::SVGPatternElement::parseMappedAttribute):
253         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
254         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
255         (WebCore::SVGPatternElement::notifyClientsToRepaint):
256         (WebCore::SVGPatternElement::notifyAttributeChange):
257         (WebCore::SVGPatternElement::canvasResource):
258         (WebCore::SVGPatternElement::getCTM):
259         * ksvg2/svg/SVGPatternElement.h:
260         (WebCore::SVGPatternElement::rendererIsNeeded):
261         * ksvg2/svg/SVGRadialGradientElement.cpp:
262         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
263         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
264         (WebCore::SVGRadialGradientElement::buildGradient):
265         * ksvg2/svg/SVGRadialGradientElement.h:
266         * ksvg2/svg/SVGStopElement.cpp:
267         (WebCore::SVGStopElement::SVGStopElement):
268         (WebCore::SVGStopElement::parseMappedAttribute):
269         * ksvg2/svg/SVGStopElement.h:
270
271 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
272
273         Reviewed by Darin, John.
274
275         - Merged more frame and iframe code
276         - Fixed a bug where iframes returned incorrect values for renderer-dependent 
277         properties during javascript: loads because they didn't have renderers at 
278         load time
279         
280         PLT insists this is a small performance win. Don't believe its lies.
281
282         * bindings/js/kjs_html.cpp:
283         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
284         width and height, for consistency with the rest of the DOM.
285         * dom/ContainerNode.cpp:
286         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
287         queue that gets drained after the render tree is fully constructed. Currently,
288         this is only used for frame loading.
289         (WebCore::ContainerNode::attach):
290         * dom/ContainerNode.h:
291         * html/HTMLFrameElement.cpp:
292         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
293         attach() because loading iframes during attach() causes a crash. 
294         Moved frame loading logic into insertedIntoDocument(). That's a more 
295         logical place for it because  document insertion is what 
296         triggers frame loading. Made frame loading a post-attach callback, instead
297         of an immediate action, to fix the incorrect values bug.
298         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
299         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
300         require this call, once I remove the call from WebKit.
301         (WebCore::HTMLFrameElement::setLocation):
302         (WebCore::HTMLFrameElement::width):
303         (WebCore::HTMLFrameElement::height):
304         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
305         killing of puppies.
306         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
307         (WebCore::HTMLIFrameElement::rendererIsNeeded):
308         (WebCore::HTMLIFrameElement::createRenderer):
309         (WebCore::HTMLIFrameElement::insertedIntoDocument):
310         (WebCore::HTMLIFrameElement::removedFromDocument):
311         (WebCore::HTMLIFrameElement::attach):
312         * page/FrameView.h: Removed unused method.
313
314 2006-10-13  David Harrison  <harrison@apple.com>
315
316         Reviewed by Justin.
317
318         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
319
320         Tests added or changed:
321         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
322         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
323         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
324         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
325         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
326
327         * dom/Text.cpp:
328         (WebCore::Text::splitText):
329         Comment changes.
330         
331         * editing/ApplyStyleCommand.cpp:
332         (WebCore::isUnstyledStyleSpan):
333         Renamed from isEmptyStyleSpan.
334         
335         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
336         Rename emptySpans local to unstyledSpans.
337         
338         (WebCore::dummySpanAncestorForNode):
339         New. To locate Apple style span created when splitting a text node.
340         
341         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
342         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
343         of dummy span's parents, rather than traversing up from start and
344         end locations. Old algorithm would miss empty spans in the bug case.
345         
346         (WebCore::ApplyStyleCommand::applyInlineStyle):
347         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
348         
349         (WebCore::ApplyStyleCommand::removeCSSStyle):
350         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
351         
352         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
353         Comment changes.
354         
355         * editing/ApplyStyleCommand.h:
356         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
357           
358         * editing/ReplaceSelectionCommand.cpp:
359         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
360         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
361         Use !node->hasChildNodes() instead of !node->firstChild().
362         
363         * editing/SplitTextNodeCommand.cpp:
364         (WebCore::SplitTextNodeCommand::doApply):
365         Comment changes.
366         
367         * rendering/RenderTreeAsText.cpp:
368         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
369         (WebCore::operator<<):
370         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
371
372 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
373
374         Reviewed by Eric.
375
376         Fix Qt/Linux build after Adele's popup menu changes.
377
378         * CMakeLists.txt:
379         * platform/qt/FileChooserQt.cpp:
380         (WebCore::FileChooser::disconnectUploadControl):
381         * platform/qt/PopupMenuQt.cpp: Added.
382         (WebCore::PopupMenu::PopupMenu):
383         (WebCore::PopupMenu::~PopupMenu):
384         (WebCore::PopupMenu::clear):
385         (WebCore::PopupMenu::populate):
386         (WebCore::PopupMenu::show):
387         (WebCore::PopupMenu::hide):
388         (WebCore::PopupMenu::addSeparator):
389         (WebCore::PopupMenu::addGroupLabel):
390         (WebCore::PopupMenu::addOption):
391         * platform/qt/RenderPopupMenuQt.cpp: Removed.
392         * platform/qt/RenderPopupMenuQt.h: Removed.
393         * platform/qt/RenderThemeQt.cpp:
394
395 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
396
397         Reviewed by Darin.
398
399         fixed build failure 
400
401         * WebCore.xcodeproj/project.pbxproj:
402         * loader/mac/WebFrameLoader.mm:
403
404 2006-10-13  Darin Adler  <darin@apple.com>
405
406         Reviewed by Adele.
407
408         - converted WebFormState from Objective-C to C++
409
410         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
411
412         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
413         Added UChar.h and FrameLoaderTypes.h.
414
415         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
416
417         * loader/mac/WebFormState.h: Converted class to C++.
418         * loader/mac/WebFormState.mm: Ditto.
419
420         * loader/mac/WebFrameLoader.h:
421         * loader/mac/WebFrameLoader.mm:
422         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
423         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
424         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
425         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
426         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
427         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
428         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
429         (-[WebFrameLoader continueAfterNavigationPolicy:]):
430         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
431         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
432         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
433         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
434         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
435
436 2006-10-13  Adele Peterson  <adele@apple.com>
437
438         Reviewed by Maciej.
439
440         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
441
442         * rendering/RenderListBox.cpp:
443         (WebCore::RenderListBox::paintItemForeground):
444         * rendering/RenderTheme.cpp:
445         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
446         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
447         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
448         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
449         * rendering/RenderThemeMac.h:
450         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
451
452 2006-10-13  Rob Buis  <buis@kde.org>
453
454         Reviewed by Mitz.
455
456         http://bugs.webkit.org/show_bug.cgi?id=11217
457         Cleanup svg coding style
458
459         Cleanup coding style in svg structure classes.
460
461         * ksvg2/svg/SVGDefsElement.cpp:
462         (WebCore::SVGDefsElement::SVGDefsElement):
463         * ksvg2/svg/SVGDefsElement.h:
464         * ksvg2/svg/SVGDescElement.cpp:
465         (WebCore::SVGDescElement::SVGDescElement):
466         * ksvg2/svg/SVGDescElement.h:
467         * ksvg2/svg/SVGDocument.cpp:
468         * ksvg2/svg/SVGDocument.h:
469         * ksvg2/svg/SVGElementInstance.cpp:
470         (WebCore::SVGElementInstance::SVGElementInstance):
471         (WebCore::SVGElementInstance::correspondingElement):
472         (WebCore::SVGElementInstance::correspondingUseElement):
473         (WebCore::SVGElementInstance::parentNode):
474         (WebCore::SVGElementInstance::childNodes):
475         (WebCore::SVGElementInstance::previousSibling):
476         (WebCore::SVGElementInstance::nextSibling):
477         (WebCore::SVGElementInstance::firstChild):
478         (WebCore::SVGElementInstance::lastChild):
479         * ksvg2/svg/SVGElementInstance.h:
480         * ksvg2/svg/SVGElementInstanceList.cpp:
481         * ksvg2/svg/SVGElementInstanceList.h:
482         * ksvg2/svg/SVGGElement.cpp:
483         (WebCore::SVGGElement::SVGGElement):
484         (WebCore::SVGGElement::parseMappedAttribute):
485         (WebCore::SVGDummyElement::SVGDummyElement):
486         * ksvg2/svg/SVGGElement.h:
487         (WebCore::SVGGElement::rendererIsNeeded):
488         * ksvg2/svg/SVGImageElement.cpp:
489         (WebCore::SVGImageElement::createRenderer):
490         * ksvg2/svg/SVGImageElement.h:
491         * ksvg2/svg/SVGSVGElement.cpp:
492         (WebCore::SVGSVGElement::SVGSVGElement):
493         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
494         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
495         (WebCore::SVGSVGElement::currentScale):
496         (WebCore::SVGSVGElement::setCurrentScale):
497         (WebCore::SVGSVGElement::currentTranslate):
498         (WebCore::SVGSVGElement::parseMappedAttribute):
499         (WebCore::SVGSVGElement::suspendRedraw):
500         (WebCore::SVGSVGElement::unsuspendRedraw):
501         (WebCore::SVGSVGElement::unsuspendRedrawAll):
502         (WebCore::SVGSVGElement::forceRedraw):
503         (WebCore::SVGSVGElement::getIntersectionList):
504         (WebCore::SVGSVGElement::getEnclosureList):
505         (WebCore::SVGSVGElement::checkIntersection):
506         (WebCore::SVGSVGElement::checkEnclosure):
507         (WebCore::SVGSVGElement::deselectAll):
508         (WebCore::SVGSVGElement::createSVGLength):
509         (WebCore::SVGSVGElement::createSVGAngle):
510         (WebCore::SVGSVGElement::createSVGMatrix):
511         (WebCore::SVGSVGElement::createSVGTransform):
512         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
513         (WebCore::SVGSVGElement::getCTM):
514         (WebCore::SVGSVGElement::getScreenCTM):
515         (WebCore::SVGSVGElement::setCurrentTime):
516         * ksvg2/svg/SVGSVGElement.h:
517         (WebCore::SVGSVGElement::rendererIsNeeded):
518         * ksvg2/svg/SVGSwitchElement.cpp:
519         (WebCore::SVGSwitchElement::SVGSwitchElement):
520         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
521         * ksvg2/svg/SVGSwitchElement.h:
522         (WebCore::SVGSwitchElement::rendererIsNeeded):
523         * ksvg2/svg/SVGSymbolElement.cpp:
524         (WebCore::SVGSymbolElement::SVGSymbolElement):
525         (WebCore::SVGSymbolElement::parseMappedAttribute):
526         * ksvg2/svg/SVGSymbolElement.h:
527         (WebCore::SVGSymbolElement::shouldAttachChild):
528         * ksvg2/svg/SVGTitleElement.cpp:
529         (WebCore::SVGTitleElement::SVGTitleElement):
530         * ksvg2/svg/SVGTitleElement.h:
531         * ksvg2/svg/SVGUseElement.cpp:
532         (WebCore::SVGUseElement::parseMappedAttribute):
533         (WebCore::SVGUseElement::closeRenderer):
534         * ksvg2/svg/SVGUseElement.h:
535         (WebCore::SVGUseElement::rendererIsNeeded):
536
537 2006-10-12  Adele Peterson  <adele@apple.com>
538
539         Reviewed by Anders.
540
541         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
542           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
543         
544          Test: fast/forms/listbox-width-change.html
545
546         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
547           When the options change, call setNeedsLayoutAndMinMaxRecalc.
548
549 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
550
551         Reviewed by Oliver.
552
553         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
554
555         * WebCore.xcodeproj/project.pbxproj:
556         * bridge/mac/WebCoreFrameBridge.h:
557         * bridge/mac/WebCoreFrameBridge.mm:
558         (stringByCollapsingNonPrintingCharacters):
559         (-[WebCoreFrameBridge setTitle:]):
560         (-[WebCoreFrameBridge didFirstLayout]):
561         (-[WebCoreFrameBridge notifyIconChanged:]):
562         (-[WebCoreFrameBridge originalRequestURL]):
563         (-[WebCoreFrameBridge isLoadTypeReload]):
564         (-[WebCoreFrameBridge frameDetached]):
565         (-[WebCoreFrameBridge tokenizerProcessedData]):
566         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
567         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
568         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
569         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
570         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
571         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
572         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
573         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
574         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
575         (-[WebCoreFrameBridge incomingReferrer]):
576         (-[WebCoreFrameBridge isReloading]):
577         (-[WebCoreFrameBridge handledOnloadEvents]):
578         (-[WebCoreFrameBridge mainResourceURLResponse]):
579         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
580         * loader/mac/LoaderNSURLExtras.h:
581         * loader/mac/LoaderNSURLRequestExtras.h: Added.
582         * loader/mac/LoaderNSURLRequestExtras.m: Added.
583         (isConditionalRequest):
584         (setHTTPReferrer):
585         * loader/mac/WebFrameLoader.mm:
586         * loader/mac/WebSubresourceLoader.mm:
587
588 2006-10-12  Adele Peterson  <adele@apple.com>
589
590         RS by Geoff.
591
592         Renamed menuListIsDetaching to disconnectMenuList, 
593         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
594         These names match similar methods in WebCore a little better.
595
596         * platform/FileChooser.h:
597         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
598         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
599         (WebCore::FileChooser::disconnectUploadControl):
600         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
601         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
602         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
603
604 2006-10-12  Adele Peterson  <adele@apple.com>
605
606         Reviewed by Maciej.
607
608         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
609
610         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
611
612         * bridge/mac/FrameMac.h:
613         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
614         * bridge/mac/WebCoreFrameBridge.h:
615
616         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
617
618 2006-10-12  Adele Peterson  <adele@apple.com>
619
620         Reviewed by Alice.
621
622         - Fix for <rdar://problem/4707372> 
623           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
624
625         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
626         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
627         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
628           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
629
630 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
631
632         Reviewed by Maciej.
633
634         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
635         document.open(); document.write(..); and NO document.close(). On the Qt platform this
636         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
637         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
638
639         Hmpf, this took me nine hours to debug today.
640         Result: Couldn't find the real fix, going for a workaround for now.
641         
642         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
643
644         * platform/qt/FrameQt.cpp:
645         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
646         * platform/qt/FrameQtClient.cpp:
647         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
648
649 2006-10-12  Adam Roben  <aroben@apple.com>
650
651         Reviewed by Adele.
652
653         Move popup menu code out of rendering/ and into platform/.
654         RenderPopupMenu becomes PopupMenu, the
655         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
656         virtual methods go away, RenderTheme gets to stop worrying about popup
657         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
658
659         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
660         * WebCore.xcodeproj/project.pbxproj: Ditto.
661         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
662         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
663         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
664         from RenderMenuList::showPopup/hidePopup.
665         (WebCore::PopupMenu::create): New static creation method to hand back a
666         PassRefPtr<PopupMenu>.
667         (WebCore::PopupMenu::addItems): This platform-independent method should
668         be called by PopupMenu::populate when the platform-specific
669         implementation is ready to receive the menu items. Fixed an ASSERT
670         while I was at it.
671         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
672         need for virtual methods.
673         (WebCore::PopupMenu::wasClicked):
674         (WebCore::PopupMenu::setWasClicked):
675         (WebCore::PopupMenu::popupHandle):
676         * platform/mac/PopupMenuMac.mm: Moved from
677         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
678         (WebCore::PopupMenu::PopupMenu):
679         (WebCore::PopupMenu::~PopupMenu):
680         (WebCore::PopupMenu::clear):
681         (WebCore::PopupMenu::populate):
682         (WebCore::PopupMenu::show):
683         (WebCore::PopupMenu::hide):
684         (WebCore::PopupMenu::addSeparator):
685         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
686         RenderStyle anymore, just pick up the style from our RenderMenuList.
687         (WebCore::PopupMenu::addOption): Ditto.
688         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
689         (PopupMenu::PopupMenu):
690         (PopupMenu::~PopupMenu):
691         (PopupMenu::clear):
692         (PopupMenu::populate):
693         (PopupMenu::show):
694         (PopupMenu::hide):
695         (PopupMenu::addSeparator):
696         (PopupMenu::addGroupLabel):
697         (PopupMenu::addOption):
698         * rendering/RenderMenuList.cpp:
699         (WebCore::RenderMenuList::~RenderMenuList):
700         (WebCore::RenderMenuList::showPopup): Use nice new simple
701         PopupMenu::create to make the popup.
702         (WebCore::RenderMenuList::hidePopup):
703         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
704         RenderPopupMenu*.
705         (WebCore::RenderMenuList::popup):
706         * rendering/RenderPopupMenu.cpp: Removed.
707         * rendering/RenderPopupMenu.h: Removed.
708         * rendering/RenderPopupMenuMac.h: Removed.
709         * rendering/RenderPopupMenuMac.mm: Removed.
710         * rendering/RenderPopupMenuWin.h: Removed.
711         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
712         * rendering/RenderTheme.h: Ditto.
713         * rendering/RenderThemeMac.h: Ditto.
714         * rendering/RenderThemeMac.mm: Ditto.
715         * rendering/RenderThemeWin.cpp: Ditto.
716         * rendering/RenderThemeWin.h: Ditto.
717
718 2006-10-12  Adele Peterson  <adele@apple.com>
719
720         Reviewed by Dave Harrison.
721
722         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
723
724         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
725         Make subtree layouts work for textareas as well as text fields.
726
727 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
728
729         Reviewed by MacDome.
730
731         Finally found a way to remove our begin() trickery in FrameQt.
732         The (probably misnamed) Frame::setEncoding() function automatically
733         calls Frame::receivedFirstData() which calls being on the working
734         url, which has been passed to didOpenUrl(). Took me some hours
735         to figure out that the missing charset logic, forced us to do hacks.
736
737         * platform/ResourceLoader.h:
738         * platform/ResourceLoaderInternal.h:
739         * platform/qt/FrameQt.cpp:
740         (WebCore::FrameQt::tokenizerProcessedData):
741         * platform/qt/FrameQt.h:
742         * platform/qt/FrameQtClient.cpp:
743         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
744         (WebCore::FrameQtClientDefault::openURL):
745         (WebCore::FrameQtClientDefault::submitForm):
746         (WebCore::FrameQtClientDefault::receivedData):
747         (WebCore::FrameQtClientDefault::receivedAllData):
748         * platform/qt/FrameQtClient.h:
749         * platform/qt/ResourceLoaderManager.cpp:
750         (WebCore::ResourceLoaderManager::slotData):
751         (WebCore::ResourceLoaderManager::slotMimetype):
752         (WebCore::ResourceLoaderManager::slotResult):
753         (WebCore::ResourceLoaderManager::remove):
754         * platform/qt/ResourceLoaderQt.cpp:
755         (WebCore::ResourceLoader::retrieveCharset):
756         (WebCore::ResourceLoader::extractCharsetFromHeaders):
757
758 2006-10-12  Adam Roben  <aroben@apple.com>
759
760         Reviewed by Hyatt.
761
762         Bandaid-ing a null-dereference crash until a real fix is made.
763
764         * page/FrameView.cpp:
765         (WebCore::FrameView::windowClipRect):
766
767 2006-10-12  Rob Buis  <buis@kde.org>
768
769         Reviewed by Mitz.
770
771         http://bugs.webkit.org/show_bug.cgi?id=11217
772         Cleanup svg coding style
773
774         Cleanup coding style in svg text classes.
775
776         * ksvg2/svg/SVGTRefElement.cpp:
777         (WebCore::SVGTRefElement::SVGTRefElement):
778         (WebCore::SVGTRefElement::updateReferencedText):
779         (WebCore::SVGTRefElement::parseMappedAttribute):
780         (WebCore::SVGTRefElement::childShouldCreateRenderer):
781         (WebCore::SVGTRefElement::createRenderer):
782         * ksvg2/svg/SVGTRefElement.h:
783         (WebCore::SVGTRefElement::rendererIsNeeded):
784         * ksvg2/svg/SVGTSpanElement.cpp:
785         (WebCore::SVGTSpanElement::SVGTSpanElement):
786         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
787         (WebCore::SVGTSpanElement::createRenderer):
788         * ksvg2/svg/SVGTSpanElement.h:
789         (WebCore::SVGTSpanElement::rendererIsNeeded):
790         * ksvg2/svg/SVGTextContentElement.cpp:
791         (WebCore::SVGTextContentElement::SVGTextContentElement):
792         (WebCore::SVGTextContentElement::parseMappedAttribute):
793         * ksvg2/svg/SVGTextContentElement.h:
794         * ksvg2/svg/SVGTextElement.cpp:
795         (WebCore::SVGTextElement::SVGTextElement):
796         (WebCore::SVGTextElement::localMatrix):
797         (WebCore::SVGTextElement::parseMappedAttribute):
798         (WebCore::SVGTextElement::updateLocalTransform):
799         (WebCore::SVGTextElement::nearestViewportElement):
800         (WebCore::SVGTextElement::farthestViewportElement):
801         (WebCore::SVGTextElement::getScreenCTM):
802         (WebCore::SVGTextElement::getCTM):
803         (WebCore::SVGTextElement::createRenderer):
804         (WebCore::SVGTextElement::childShouldCreateRenderer):
805         * ksvg2/svg/SVGTextElement.h:
806         (WebCore::SVGTextElement::getTransformToElement):
807         (WebCore::SVGTextElement::rendererIsNeeded):
808         * ksvg2/svg/SVGTextPositioningElement.cpp:
809         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
810         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
811         * ksvg2/svg/SVGTextPositioningElement.h:
812
813 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
814
815         Reviewed by Maciej.
816
817         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
818
819         * platform/qt/FrameQt.cpp:
820         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
821         * platform/qt/FrameQtClient.cpp:
822         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
823         * platform/qt/FrameQtClient.h:
824
825 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
826
827         Reviewed by Eric.
828
829         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
830
831         * page/FramePrivate.h: Add m_responseMIMEType
832         * page/ResourceRequest.h: Remove m_responseMIMEType
833         * page/Frame.cpp:
834         (WebCore::Frame::setResponseMIMEType): added
835         (WebCore::Frame::responseMIMEType): added
836         (WebCore::Frame::begin): get MIME type from the right place
837         (WebCore::Frame::write): ditto
838         * page/Frame.h:
839         * bindings/js/kjs_window.cpp:
840         (KJS::createNewWindow): updated to use new Frame methods
841         (KJS::WindowFunc::callAsFunction): ditto
842         * bridge/mac/WebCoreFrameBridge.mm:
843         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
844         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
845         * loader/PluginDocument.cpp:
846         (WebCore::PluginTokenizer::createDocumentStructure): ditto
847
848 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
849
850         Reviewed by Eric.
851         
852         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
853
854         We really need some way to test loadHTMLString since it keeps breaking!
855         
856         * loader/mac/WebFrameLoader.mm:
857         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
858
859 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
860
861         Reviewed by Eric.
862
863         Fix Qt/Linux build.
864
865         * CMakeLists.txt:
866         * platform/qt/FileChooserQt.cpp:
867         (WebCore::FileChooser::create):
868
869 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
870
871         Reviewed by Maciej.
872
873         Update Gdk\Linux build for recent changes, based on Qt code
874
875         * platform/gdk/FrameGdk.cpp:
876         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
877         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
878         (WebCore::FrameGdkClientDefault::setFrame):
879         (WebCore::FrameGdkClientDefault::openURL):
880         (WebCore::FrameGdkClientDefault::submitForm):
881         (WebCore::FrameGdkClientDefault::receivedResponse):
882         (WebCore::FrameGdkClientDefault::receivedData):
883         (WebCore::FrameGdkClientDefault::receivedAllData):
884         (WebCore::FrameGdk::FrameGdk):
885         (WebCore::FrameGdk::openURL):
886         (WebCore::FrameGdk::submitForm):
887         (WebCore::FrameGdk::urlSelected):
888         * platform/gdk/FrameGdk.h:
889         * platform/gdk/TemporaryLinkStubs.cpp:
890         (FrameGdk::createJavaAppletWidget):
891         (FileChooser::create):
892
893 2006-10-12  Dave Hyatt  <hyatt@apple.com>
894
895         Patch to add more clipping retrieval functionality for widgets.
896        
897         Reviewed by mjs
898
899         * page/Frame.h:
900         Remove windowResizerRect.  This is in the wrong place.
901         
902         * page/FrameView.cpp:
903         (WebCore::FrameView::windowClipRect):
904         (WebCore::FrameView::windowClipRectForLayer):
905         Break out windowClipRect into helper functions that can be called separately (to make
906         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
907         layer and get the right clip.
908         
909         * page/FrameView.h:
910         Add the new windowClipRect helper methods.
911         
912         * platform/ScrollBar.h:
913         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
914         clip rects for themselves depending on how they are used.
915         
916         * platform/ScrollView.h:
917         Stub out methods for talking to a double buffer backing store on Win32.
918         
919         * platform/Widget.h:
920         Add the ability to query for invalidation suppression.
921         
922         * rendering/RenderLayer.cpp:
923         (WebCore::RenderLayer::windowClipRect):
924         (WebCore::RenderLayer::paintOverflowControls):
925         (WebCore::RenderLayer::calculateRects):
926         (WebCore::RenderLayer::childrenClipRect):
927         (WebCore::RenderLayer::selfClipRect):
928         * rendering/RenderLayer.h:
929         Enhance layers so that they can return either their foreground or background
930         document clip rects.  Make sure a layer scrollbar can return a proper clip.
931         
932         * rendering/RenderListBox.cpp:
933         (WebCore::RenderListBox::windowClipRect):
934         * rendering/RenderListBox.h:
935         Make sure a list box scrollbar can return a proper clip.
936         
937         * rendering/RenderObject.cpp:
938         (WebCore::RenderObject::enclosingLayer):
939         * rendering/RenderObject.h:
940         Make enclosingLayer const.
941         
942 2006-10-11  Darin Adler  <darin@apple.com>
943
944         Reviewed by John.
945
946         - some changes to prepare for converting more code to C++
947
948         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
949         self-sufficient.
950
951         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
952         Needed since the class is used in this header (for some work I have not landed yet).
953
954         * loader/mac/LoaderNSURLExtras.h:
955         * loader/mac/WebFormDataStream.h:
956         Added extern "C" so this code can be used from C++.
957
958         * loader/mac/LoaderNSURLExtras.m:
959         * loader/mac/WebDataProtocol.mm:
960         * loader/mac/WebDocumentLoader.mm:
961         * loader/mac/WebFormDataStream.m:
962         * loader/mac/WebLoader.mm:
963         * loader/mac/WebMainResourceLoader.mm:
964         * loader/mac/WebNetscapePlugInStreamLoader.mm:
965         * loader/mac/WebPolicyDecider.mm:
966         * loader/mac/WebSubresourceLoader.mm:
967         Added missing includes of config.h.
968
969 2006-10-11  John Sullivan  <sullivan@apple.com>
970         
971         Darin wrote this code; we tested it; I give it the thumbs up.
972         
973         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
974
975         The hash table to look up an element class given a QualifiedName was
976         not working at all.
977
978         * dom/QualifiedName.h:
979         (WebCore::QualifiedName::impl):
980         Added. This new accessor method for impl is needed if we want to use
981         a QualifiedName as a hash table key without doing the kind of specialization
982         we do for String. Maybe later we can do the String thing.
983
984         * bindings/objc/DOM.mm:
985         (WebCore::addElementClass):
986         Use QualifiedName.impl instead of the QualifiedName pointer itself.
987         The QualifiedName pointer is *not* unique so almost nothing would be found
988         in this hash table!
989         (WebCore::elementClass):
990         ditto
991         
992 2006-10-11  Adam Roben  <aroben@apple.com>
993
994         Rubberstamped by Anders.
995
996         Clean up FileChooser::create and Icon::newIconForFile.
997
998         * WebCore.xcodeproj/project.pbxproj:
999         * platform/mac/FileChooserMac.mm:
1000         (WebCore::FileChooser::create):
1001         * platform/mac/IconMac.mm:
1002         (WebCore::Icon::newIconForFile):
1003
1004 2006-10-11  Oliver Hunt  <oliver@apple.com>
1005
1006         Reviewed by Adam.
1007
1008         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
1009         Corrects canvas tag to not throw JS exception when drawing
1010         zero sized rects, arcs, etc
1011
1012         * html/CanvasRenderingContext2D.cpp:
1013         (WebCore::CanvasRenderingContext2D::arcTo):
1014         (WebCore::CanvasRenderingContext2D::arc):
1015         (WebCore::CanvasRenderingContext2D::rect):
1016         (WebCore::CanvasRenderingContext2D::clearRect):
1017         (WebCore::CanvasRenderingContext2D::fillRect):
1018         (WebCore::CanvasRenderingContext2D::strokeRect):
1019
1020 2006-10-11  Rob Buis  <buis@kde.org>
1021
1022         Reviewed by Mitz.
1023
1024         http://bugs.webkit.org/show_bug.cgi?id=11221
1025         REGRESSION: iExploder crash due to style="cursor: url()"
1026
1027         Take better care of empty cursor lists.
1028
1029         Test: fast/css/invalid-cursor-property-crash.html
1030
1031         * css/cssparser.cpp:
1032         (WebCore::CSSParser::parseValue):
1033
1034 2006-10-11  Adam Roben  <aroben@apple.com>
1035
1036         Fixing Windows for real this time.
1037
1038         * platform/win/TemporaryLinkStubs.cpp:
1039         (FileChooser::create):
1040
1041 2006-10-11  Adam Roben  <aroben@apple.com>
1042
1043         Fix Windows build.
1044
1045         * platform/win/TemporaryLinkStubs.cpp:
1046         (FileChooser::create):
1047
1048 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
1049
1050         Reviewed by Hyatt.
1051         
1052         http://bugs.webkit.org/show_bug.cgi?id=4377
1053         
1054         Respect css visibility semantics for layers too
1055
1056         * rendering/RenderContainer.cpp:
1057         (WebCore::RenderContainer::removeChildNode):
1058         (WebCore::RenderContainer::appendChildNode):
1059         (WebCore::RenderContainer::insertChildNode):
1060         * rendering/RenderLayer.cpp:
1061         (WebCore::RenderLayer::RenderLayer):
1062         (WebCore::RenderLayer::updateLayerPositions):
1063         (WebCore::RenderLayer::setHasVisibleContent):
1064         (WebCore::RenderLayer::dirtyVisibleContentStatus):
1065         (WebCore::RenderLayer::childVisibilityChanged):
1066         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
1067         (WebCore::RenderLayer::updateVisibilityStatus):
1068         (WebCore::RenderLayer::addChild):
1069         (WebCore::RenderLayer::removeChild):
1070         (WebCore::RenderLayer::updateZOrderLists):
1071         (WebCore::RenderLayer::collectLayers):
1072         * rendering/RenderLayer.h:
1073         (WebCore::RenderLayer::hasVisibleContent):
1074         * rendering/RenderObject.cpp:
1075         (WebCore::RenderObject::setStyle):
1076
1077 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1078
1079         Reviewed by Oliver.
1080
1081         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
1082
1083         * WebCore.xcodeproj/project.pbxproj:
1084         * platform/cf/RetainPtr.h: Added.
1085         (WTF::):
1086         (WTF::RetainPtr::RetainPtr):
1087         (WTF::RetainPtr::~RetainPtr):
1088         (WTF::RetainPtr::get):
1089         (WTF::RetainPtr::operator*):
1090         (WTF::RetainPtr::operator->):
1091         (WTF::RetainPtr::operator!):
1092         (WTF::RetainPtr::operator UnspecifiedBoolType):
1093         (WTF::::operator):
1094         (WTF::::swap):
1095         (WTF::swap):
1096         (WTF::operator==):
1097         (WTF::operator!=):
1098         (WTF::static_pointer_cast):
1099         (WTF::const_pointer_cast):
1100         (WTF::getPtr):
1101         
1102         - use it in WidgetMac so it gets tested in at least one place
1103         
1104         * platform/mac/WidgetMac.mm:
1105         (WebCore::Widget::Widget):
1106         (WebCore::Widget::~Widget):
1107         (WebCore::Widget::setEnabled):
1108         (WebCore::Widget::isEnabled):
1109         (WebCore::Widget::setCursor):
1110         (WebCore::Widget::getView):
1111         (WebCore::Widget::setView):
1112         (WebCore::Widget::getOuterView):
1113
1114 2006-10-10  Brady Eidson  <beidson@apple.com>
1115
1116         Reviewed by Maciej.
1117
1118         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
1119
1120         * bridge/mac/WebCoreFrameBridge.h:
1121         * bridge/mac/WebCoreFrameBridge.mm:
1122         (-[WebCoreFrameBridge initMainFrameWithPage:]):
1123         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
1124         (-[WebCoreFrameBridge dealloc]):
1125         (-[WebCoreFrameBridge close]):
1126         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1127         (-[WebCoreFrameBridge frameLoader]):
1128         * loader/mac/WebFrameLoader.h:
1129         * loader/mac/WebFrameLoader.mm:
1130         (-[WebFrameLoader initWithFrameBridge:]):
1131         (-[WebFrameLoader setFrameLoaderClient:]):
1132
1133 2006-10-10  Adam Roben  <aroben@apple.com>
1134
1135         Reviewed by Oliver.
1136
1137         Make FileChooser ref-counted.
1138
1139         * platform/FileChooser.h:
1140         * platform/mac/FileChooserMac.mm:
1141         (WebCore::FileChooser::create):
1142         * rendering/RenderFileUploadControl.cpp:
1143         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1144         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1145         * rendering/RenderFileUploadControl.h:
1146
1147 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
1148
1149         Reviewed by Tim H.
1150
1151         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
1152         Even More auto-generated Objective-C DOM bindings changes
1153
1154         - Auto-generate DOMSVGPathElement.
1155
1156         - Auto-generate the internal interfaces even for classes that have
1157           custom internal implementations.  Change IDL property from ObjCNoInternal
1158           to ObjCCustomInternalImpl to indicate the change.
1159
1160         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
1161
1162         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
1163           and make DOM binding possible.
1164
1165         - Assorted cleanups.
1166
1167         * DerivedSources.make:
1168         * WebCore.xcodeproj/project.pbxproj:
1169         * bindings/objc/DOM.mm:
1170         (WebCore::addElementClass):
1171         (WebCore::createElementClassMap):
1172         (WebCore::elementClass):
1173         (-[DOMNode description]):
1174         (+[DOMNode _nodeWith:WebCore::]):
1175         (-[DOMNode addEventListener:listener:useCapture:]):
1176         (-[DOMNode removeEventListener:listener:useCapture:]):
1177         (-[DOMElement _NPObject]):
1178         (WebCore::ObjCEventListener::handleEvent):
1179         * bindings/objc/DOMEvents.mm:
1180         (+[DOMEvent _eventWith:WebCore::]):
1181         * bindings/objc/DOMInternal.h:
1182         * bindings/objc/DOMRGBColor.mm:
1183         (-[DOMRGBColor WebCore::]):
1184         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
1185         * bindings/scripts/CodeGeneratorObjC.pm:
1186         * css/CSSRule.idl:
1187         * css/CSSValue.idl:
1188         * css/StyleSheet.idl:
1189         * dom/Event.cpp:
1190         (WebCore::Event::isSVGZoomEvent):
1191         * dom/Event.h:
1192         * dom/Event.idl:
1193         * dom/Node.idl:
1194         * ksvg2/events/SVGZoomEvent.cpp:
1195         (WebCore::SVGZoomEvent::isSVGZoomEvent):
1196         * ksvg2/events/SVGZoomEvent.h:
1197         * ksvg2/svg/SVGAnimatedAngle.idl:
1198         * ksvg2/svg/SVGCircleElement.idl:
1199         * ksvg2/svg/SVGClipPathElement.idl:
1200         * ksvg2/svg/SVGPathElement.idl:
1201         * ksvg2/svg/SVGPathSeg.idl:
1202
1203 2006-10-10  Oliver Hunt  <oliver@apple.com>
1204
1205         rubber stamped by Anders.
1206
1207         More buildbot bustage
1208
1209         * kcanvas/SVGInlineFlowBox.cpp:
1210         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1211
1212 2006-10-10  Oliver Hunt  <oliver@apple.com>
1213
1214         Reviewed by Anders 
1215
1216         Unbreak build bots
1217
1218         * dom/Text.cpp:
1219         * kcanvas/RenderSVGText.cpp:
1220         (WebCore::RenderSVGText::layout):
1221         * kcanvas/SVGInlineFlowBox.cpp:
1222         (WebCore::placePositionedBoxesHorizontally):
1223         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1224
1225 2006-10-10  Oliver Hunt  <oliver@apple.com>
1226
1227         Reviewed by hyatt.
1228
1229         Fixes bugs #6423, #6559, #10380 and #10839 
1230
1231         * WebCore.xcodeproj/project.pbxproj:
1232         * css/svg.css:
1233         * dom/Text.cpp:
1234         (WebCore::Text::createRenderer):
1235         * kcanvas/RenderSVGInline.cpp: Added.
1236         (WebCore::RenderSVGInline::RenderSVGInline):
1237         (WebCore::RenderSVGInline::createInlineBox):
1238         * kcanvas/RenderSVGInline.h: Added.
1239         (WebCore::RenderSVGInline::renderName):
1240         (WebCore::RenderSVGInline::requiresLayer):
1241         * kcanvas/RenderSVGInlineText.cpp: Added.
1242         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
1243         (WebCore::RenderSVGInlineText::absoluteRects):
1244         (WebCore::RenderSVGInlineText::selectionRect):
1245         * kcanvas/RenderSVGInlineText.h: Added.
1246         (WebCore::RenderSVGInlineText::renderName):
1247         (WebCore::RenderSVGInlineText::requiresLayer):
1248         * kcanvas/RenderSVGTSpan.cpp: Added.
1249         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
1250         (WebCore::RenderSVGTSpan::absoluteRects):
1251         * kcanvas/RenderSVGTSpan.h: Added.
1252         (WebCore::RenderSVGTSpan::renderName):
1253         * kcanvas/RenderSVGText.cpp:
1254         (WebCore::RenderSVGText::RenderSVGText):
1255         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
1256         (WebCore::RenderSVGText::layout):
1257         (WebCore::RenderSVGText::createInlineBox):
1258         (WebCore::RenderSVGText::nodeAtPoint):
1259         (WebCore::RenderSVGText::absoluteRects):
1260         (WebCore::RenderSVGText::paint):
1261         (WebCore::RenderSVGText::relativeBBox):
1262         * kcanvas/RenderSVGText.h:
1263         (WebCore::RenderSVGText::renderName):
1264         * kcanvas/SVGInlineFlowBox.cpp: Added.
1265         (WebCore::SVGInlineFlowBox::paint):
1266         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
1267         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
1268         (WebCore::paintSVGInlineFlow):
1269         (WebCore::translateBox):
1270         (WebCore::placePositionedBoxesHorizontally):
1271         (WebCore::placeSVGFlowHorizontally):
1272         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1273         (WebCore::placeSVGFlowVertically):
1274         * kcanvas/SVGInlineFlowBox.h: Added.
1275         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
1276         * kcanvas/SVGRootInlineBox.cpp: Added.
1277         (WebCore::SVGRootInlineBox::paint):
1278         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1279         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
1280         * kcanvas/SVGRootInlineBox.h: Added.
1281         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
1282         * ksvg2/svg/SVGTRefElement.cpp:
1283         (SVGTRefElement::createRenderer):
1284         * ksvg2/svg/SVGTSpanElement.cpp:
1285         (SVGTSpanElement::createRenderer):
1286         * rendering/InlineFlowBox.h:
1287
1288 2006-10-10  Adam Roben  <aroben@apple.com>
1289
1290         Reviewed by Adele.
1291
1292         Improve popup menu behavior.
1293
1294         * html/HTMLSelectElement.cpp:
1295         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
1296         m_lastOnChangeIndex so we know when to fire onChange.
1297         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
1298         specify whether we should fire onChange.
1299         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
1300         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
1301         onChange when using the Enter key to change the selection.
1302         * html/HTMLSelectElement.h:
1303         * rendering/RenderMenuList.cpp:
1304         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
1305         into its own method.
1306         (WebCore::RenderMenuList::setTextFromOption): New method.
1307         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
1308         onChange instead of calling it directly here.
1309         * rendering/RenderMenuList.h:
1310
1311 2006-10-10  Adele Peterson  <adele@apple.com>
1312
1313         Reviewed by Beth. 
1314
1315
1316         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
1317           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
1318
1319         Moved autoscroll code to the Frame class
1320
1321         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
1322         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
1323         (WebCore::FrameMac::FrameMac):
1324         (WebCore::FrameMac::handleMousePressEvent):
1325         (WebCore::FrameMac::eventMayStartDrag):
1326         (WebCore::FrameMac::handleMouseMoveEvent):
1327         (WebCore::FrameMac::mouseDown):
1328
1329         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
1330         Now we scroll our views in WebCore.
1331
1332         * page/Frame.cpp:
1333         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
1334         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
1335         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
1336         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
1337         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
1338         (WebCore::Frame::mouseDownMayStartDrag): Added.
1339         (WebCore::Frame::setMouseDownMayStartDrag): Added.
1340         (WebCore::Frame::autoscrollRenderer): Added
1341         (WebCore::Frame::setAutoscrollRenderer): Added.
1342         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
1343         (WebCore::Frame::autoscrollTimerFired): ditto.
1344         (WebCore::Frame::stopAutoscrollTimer): ditto. 
1345         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
1346
1347         * page/FramePrivate.h:
1348         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
1349
1350         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
1351         (WebCore::FrameView::handleMousePressEvent):
1352         (WebCore::FrameView::handleMouseDoubleClickEvent):
1353         (WebCore::FrameView::handleMouseMoveEvent):
1354         (WebCore::FrameView::handleMouseReleaseEvent):
1355
1356         * rendering/RenderLayer.cpp:
1357         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).  
1358          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
1359
1360         * rendering/RenderListBox.cpp:
1361         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
1362
1363         * rendering/RenderObject.cpp:
1364         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
1365         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
1366
1367 2006-10-10  Darin Adler  <darin@apple.com>
1368
1369         Rubber stamped by Maciej.
1370
1371         - convert many of the loader source files to Objective-C++ to prepare
1372           to convert some of them to C++
1373
1374         * WebCore.xcodeproj/project.pbxproj:
1375         * loader/mac/WebDataProtocol.m: Removed.
1376         * loader/mac/WebDocumentLoader.m: Removed.
1377         * loader/mac/WebFormState.m: Removed.
1378         * loader/mac/WebFrameLoader.m: Removed.
1379         * loader/mac/WebLoader.m: Removed.
1380         * loader/mac/WebMainResourceLoader.m: Removed.
1381         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
1382         * loader/mac/WebPolicyDecider.m: Removed.
1383         * loader/mac/WebSubresourceLoader.m: Removed.
1384         * loader/mac/WebDataProtocol.mm: Added.
1385         * loader/mac/WebDocumentLoader.mm: Added.
1386         * loader/mac/WebFormState.mm: Added.
1387         * loader/mac/WebFrameLoader.mm: Added.
1388         * loader/mac/WebLoader.mm: Added.
1389         * loader/mac/WebMainResourceLoader.mm: Added.
1390         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
1391         * loader/mac/WebPolicyDecider.mm: Added.
1392         * loader/mac/WebSubresourceLoader.mm: Added.
1393
1394 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1395
1396         Reviewed by Mitz.
1397
1398         - fixed REGRESSION (r16960): crash on navigating to site
1399         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
1400         
1401         * loader/mac/WebFrameLoader.m:
1402         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1403         Add back a mistakenly removed retain.
1404
1405 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1406
1407         Not reviewed, build fix.
1408
1409         - fixed release build
1410
1411         * WebCore.xcodeproj/project.pbxproj:
1412
1413 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1414
1415         Rubber stamped by Eric.
1416
1417         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
1418
1419         * WebCore.exp:
1420         * WebCore.xcodeproj/project.pbxproj:
1421         * loader/mac/LoaderNSURLExtras.m: Added.
1422         * loader/mac/WebDataProtocol.m: Added.
1423         * loader/mac/WebDocumentLoader.m: Added.
1424         * loader/mac/WebFormDataStream.m: Added.
1425         * loader/mac/WebFrameLoader.m: Added.
1426         * loader/mac/WebLoader.m: Added.
1427         (-[NSURLProtocol didReceiveResponse:]):
1428         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
1429         * loader/mac/WebMainResourceLoader.m: Added.
1430         (-[WebMainResourceLoader didReceiveResponse:]):
1431         * loader/mac/WebPolicyDecider.m: Added.
1432         * loader/mac/WebSubresourceLoader.h: Added.
1433         * loader/mac/WebSubresourceLoader.m: Added.
1434
1435 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1436
1437         Reviewed by Oliver (sort of?)
1438
1439         - WebCore part of moving down NSURL extras
1440
1441         * WebCore.exp:
1442         * platform/mac/WebCoreSystemInterface.h:
1443         * platform/mac/WebCoreSystemInterface.mm:
1444
1445 2006-10-09  Rob Buis  <buis@kde.org>
1446
1447         Reviewed by Mitz.
1448
1449         http://bugs.webkit.org/show_bug.cgi?id=11217
1450         Cleanup svg coding style
1451
1452         Cleanup coding style in svg animation classes.
1453
1454         * ksvg2/svg/SVGAnimateColorElement.cpp:
1455         (WebCore::SVGAnimateColorElement::handleTimerEvent):
1456         * ksvg2/svg/SVGAnimateElement.cpp:
1457         (WebCore::SVGAnimateElement::SVGAnimateElement):
1458         (WebCore::SVGAnimateElement::handleTimerEvent):
1459         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1460         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
1461         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
1462         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1463         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1464         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
1465         (WebCore::SVGAnimateTransformElement::initialMatrix):
1466         (WebCore::SVGAnimateTransformElement::transformMatrix):
1467         * ksvg2/svg/SVGAnimateTransformElement.h:
1468         * ksvg2/svg/SVGAnimatedPathData.cpp:
1469         * ksvg2/svg/SVGAnimatedPathData.h:
1470         * ksvg2/svg/SVGAnimatedPoints.cpp:
1471         * ksvg2/svg/SVGAnimatedPoints.h:
1472         * ksvg2/svg/SVGAnimationElement.cpp:
1473         (WebCore::SVGAnimationElement::targetElement):
1474
1475 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
1476
1477         Reviewed by Oliver.
1478
1479         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
1480
1481         * bridge/mac/WebCoreFrameBridge.h:
1482         * bridge/mac/WebCoreFrameBridge.mm:
1483         (-[WebCoreFrameBridge isMainFrame]):
1484
1485 2006-10-09  Adam Roben  <aroben@apple.com>
1486
1487         Backing out accidental commit.
1488
1489         * page/Frame.cpp:
1490         (WebCore::Frame::finishedParsing):
1491
1492 2006-10-09  Adam Roben  <aroben@apple.com>
1493
1494         Reviewed by Darin.
1495
1496         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
1497         this could cause recursive calls to the destructor. RefPtr now also
1498         inherits from Noncopyable.
1499
1500         * dom/NodeFilter.h:
1501         * dom/Traversal.h:
1502         * page/DOMWindow.h:
1503         * page/Frame.cpp:
1504         (WebCore::Frame::finishedParsing):
1505         * page/Frame.h:
1506         * page/Plugin.h:
1507         * platform/FontFallbackList.h:
1508         * platform/Icon.h:
1509         * platform/Shared.h:
1510         (WebCore::Shared::Shared):
1511         (WebCore::Shared::ref):
1512         (WebCore::Shared::deref):
1513         (WebCore::Shared::hasOneRef):
1514         (WebCore::Shared::refCount):
1515         * platform/StringImpl.h:
1516
1517 2006-10-09  Oliver Hunt <ohunt@apple.com>
1518
1519         Reviewed by Anders.
1520
1521         Correcting ifdef's
1522
1523         * html/CanvasGradient.cpp:
1524         (WebCore::CanvasGradient::CanvasGradient):
1525         (WebCore::CanvasGradient::~CanvasGradient):
1526         (WebCore::CanvasGradient::addColorStop):
1527         * html/CanvasGradient.h:
1528         * html/CanvasPattern.cpp:
1529         (WebCore::CanvasPattern::CanvasPattern):
1530         (WebCore::CanvasPattern::~CanvasPattern):
1531         * html/CanvasPattern.h:
1532         * html/CanvasRenderingContext2D.cpp:
1533         (WebCore::CanvasRenderingContext2D::fill):
1534         (WebCore::CanvasRenderingContext2D::stroke):
1535         (WebCore::CanvasRenderingContext2D::fillRect):
1536         (WebCore::CanvasRenderingContext2D::setShadow):
1537         (WebCore::CanvasRenderingContext2D::applyShadow):
1538         (WebCore::CanvasRenderingContext2D::drawImage):
1539         (WebCore::CanvasRenderingContext2D::createPattern):
1540         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
1541         (WebCore::CanvasRenderingContext2D::applyFillPattern):
1542         * html/CanvasRenderingContext2D.h:
1543         * html/CanvasStyle.cpp:
1544         (WebCore::CanvasStyle::applyStrokeColor):
1545         (WebCore::CanvasStyle::applyFillColor):
1546         * html/HTMLCanvasElement.cpp:
1547         (WebCore::HTMLCanvasElement::paint):
1548         (WebCore::HTMLCanvasElement::createDrawingContext):
1549         * html/HTMLCanvasElement.h:
1550
1551 2006-10-09  Adam Roben  <aroben@apple.com>
1552
1553         Reviewed by Maciej.
1554
1555         Fix a possible recursive destructor call.
1556
1557         * page/Frame.cpp:
1558         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
1559         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
1560         we're already being destroyed.
1561
1562 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
1563
1564         Reviewed by Tim H.
1565
1566         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
1567         Assorted Objective-C bindings changes
1568
1569         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, 
1570           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, 
1571           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, 
1572           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, 
1573           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, 
1574           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, 
1575           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, 
1576           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, 
1577           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
1578
1579         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
1580           DOMHTMLObjectElement.
1581
1582         - Auto-generate the internal methods for classes with ivars (notably 
1583           DOMNodeIterator and DOMTreeWalker)
1584
1585         - Put more methods in the WebCore namespace and factor out the  
1586           displayString method into DOMInternal.h as done by Darin in his 
1587           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
1588
1589         * DerivedSources.make:
1590         * WebCore.xcodeproj/project.pbxproj:
1591         * bindings/objc/DOM.mm:
1592         (-[DOMNode _initWithNode:WebCore::]):
1593         (+[DOMNode _nodeWith:WebCore::]):
1594         (-[DOMNode addEventListener:listener:useCapture:]):
1595         (-[DOMNode removeEventListener:listener:useCapture:]):
1596         (-[DOMNode dispatchEvent:]):
1597         (-[DOMElement _imageTIFFRepresentation]):
1598         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1599         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
1600         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1601         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1602         * bindings/objc/DOMCSS.mm:
1603         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1604         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1605         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
1606         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1607         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
1608         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1609         * bindings/objc/DOMEvents.mm:
1610         (-[DOMEvent _initWithEvent:WebCore::]):
1611         (+[DOMEvent _eventWith:WebCore::]):
1612         * bindings/objc/DOMExtensions.h:
1613         * bindings/objc/DOMHTML.mm:
1614         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
1615         * bindings/objc/DOMInternal.h:
1616         (-[DOMNodeFilter WebCore::]):
1617         * bindings/objc/DOMInternal.mm:
1618         (-[WebScriptObject _init]):
1619         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1620         (WebCore::displayString):
1621         * bindings/objc/DOMObject.mm:
1622         (-[DOMObject dealloc]):
1623         (-[DOMObject finalize]):
1624         * bindings/objc/DOMRGBColor.mm:
1625         (-[DOMRGBColor dealloc]):
1626         (-[DOMRGBColor finalize]):
1627         (-[DOMRGBColor color]):
1628         (-[DOMRGBColor _initWithRGB:WebCore::]):
1629         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
1630         * bindings/objc/DOMSVG.h:
1631         * bindings/objc/DOMSVGPathSegInternal.h: Added.
1632         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
1633         (-[DOMSVGPathSeg WebCore::]):
1634         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
1635         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
1636         * bindings/objc/DOMXPath.mm:
1637         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1638         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
1639         * bindings/objc/PublicDOMInterfaces.h:
1640         * bindings/scripts/CodeGeneratorObjC.pm:
1641         * dom/NodeIterator.idl:
1642         * dom/TreeWalker.idl:
1643         * html/HTMLInputElement.idl:
1644         * html/HTMLObjectElement.idl:
1645         * ksvg2/svg/SVGDocument.idl:
1646         * ksvg2/svg/SVGElement.idl:
1647         * ksvg2/svg/SVGPathSeg.idl:
1648         * ksvg2/svg/SVGPathSegArcAbs.idl:
1649         * ksvg2/svg/SVGPathSegArcRel.idl:
1650         * ksvg2/svg/SVGPathSegClosePath.idl:
1651         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
1652         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
1653         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
1654         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
1655         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
1656         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
1657         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
1658         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
1659         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
1660         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
1661         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
1662         * ksvg2/svg/SVGPathSegLinetoRel.idl:
1663         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
1664         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
1665         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
1666         * ksvg2/svg/SVGPathSegMovetoRel.idl:
1667
1668 2006-10-09  Don Gibson  <dgibson77@gmail.com>
1669
1670         Unreviewed build fix.
1671
1672         Fix windows build bustage.
1673
1674         * platform/win/TemporaryLinkStubs.cpp:
1675
1676 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1677
1678         Reviewed by Geoff.
1679
1680         Fix memory leaks discovered via valgrind. Gdk build fixes.
1681
1682         * Projects/gdk/webcore-gdk.bkl:
1683         * make-generated-sources.sh:
1684         * platform/cairo/ImageCairo.cpp:
1685         (WebCore::Image::draw):
1686         * platform/gdk/FrameGdk.cpp:
1687         (WebCore::FrameGdk::handleGdkEvent):
1688         * platform/gdk/FrameGdk.h:
1689         * platform/gdk/PlatformScrollBar.h:
1690         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
1691         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
1692
1693 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
1694
1695         Reviewed by Beth.
1696
1697         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
1698
1699         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
1700         (WebCore::GlyphMap::fillPage):
1701
1702 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
1703
1704         Unreviewed build fix.
1705
1706         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
1707
1708         * platform/qt/FrameQt.cpp:
1709         (WebCore::FrameQt::createJavaAppletWidget):
1710         * platform/qt/FrameQt.h:
1711         * platform/qt/TemporaryLinkStubs.cpp:
1712
1713 2006-10-09  Brady Eidson  <beidson@apple.com>
1714
1715         Reviewed by Maciej
1716
1717         Tiny changes to help reorganize WebFrameLoader code in WebKit
1718
1719         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
1720         * bridge/mac/WebCoreIconDatabaseBridge.mm:
1721         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
1722
1723 2006-10-09  Adam Roben  <aroben@apple.com>
1724
1725         Reviewed by Adele.
1726
1727         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
1728         already called frome ~FrameMac.
1729
1730         * page/Frame.cpp:
1731         (WebCore::Frame::~Frame):
1732
1733 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1734
1735         * bridge/win/FrameWin.h:
1736         Add function declaration.
1737         
1738 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1739
1740         * platform/win/TemporaryLinkStubs.cpp:
1741         (FrameWin::createJavaAppletWidget):
1742         Try fixing the Win32 build.
1743
1744 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
1745
1746         Reviewed by Adam.
1747
1748         Move applet widget creation to Frame and get rid of JavaAppletWidget.
1749         * WebCore.xcodeproj/project.pbxproj:
1750         * bridge/JavaAppletWidget.h: Removed.
1751         * bridge/mac/FrameMac.h:
1752         * bridge/mac/FrameMac.mm:
1753         (WebCore::FrameMac::createJavaAppletWidget):
1754         * bridge/mac/JavaAppletWidget.mm: Removed.
1755         * page/Frame.h:
1756         * rendering/RenderApplet.cpp:
1757         (WebCore::RenderApplet::createWidgetIfNecessary):
1758
1759 2006-10-09  Mitz Pettel  <mitz@webkit.org>
1760
1761         Reviewed by Darin.
1762
1763         - http://bugs.webkit.org/show_bug.cgi?id=11220
1764           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
1765
1766         Subversion does not support resource forks and HFS metadata, so
1767         the resources for this test need to be on a disk image.
1768
1769         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
1770         * manual-tests/resources/plain-text-paste.dmg: Added.
1771         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
1772         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
1773         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
1774         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
1775         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
1776         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
1777         * manual-tests/resources/plain-text-paste/3.gif: Removed.
1778         * manual-tests/resources/plain-text-paste/4.txt: Removed.
1779         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
1780
1781 2006-10-09  Rob Buis  <buis@kde.org>
1782
1783         Reviewed by Darin.
1784
1785         http://bugs.webkit.org/show_bug.cgi?id=11217
1786         Cleanup svg coding style
1787
1788         Cleanup coding style in filter classes.
1789
1790         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1791         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
1792         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
1793         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
1794         * ksvg2/svg/SVGFEBlendElement.cpp:
1795         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
1796         (WebCore::SVGFEBlendElement::parseMappedAttribute):
1797         (WebCore::SVGFEBlendElement::filterEffect):
1798         * ksvg2/svg/SVGFEBlendElement.h:
1799         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1800         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
1801         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
1802         (WebCore::SVGFEColorMatrixElement::filterEffect):
1803         * ksvg2/svg/SVGFEColorMatrixElement.h:
1804         * ksvg2/svg/SVGFECompositeElement.cpp:
1805         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1806         * ksvg2/svg/SVGFECompositeElement.h:
1807         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1808         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
1809         * ksvg2/svg/SVGFEDisplacementMapElement.h:
1810         * ksvg2/svg/SVGFEFloodElement.cpp:
1811         (WebCore::SVGFEFloodElement::filterEffect):
1812         * ksvg2/svg/SVGFEFuncAElement.cpp:
1813         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
1814         * ksvg2/svg/SVGFEFuncBElement.cpp:
1815         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
1816         * ksvg2/svg/SVGFEFuncGElement.cpp:
1817         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
1818         * ksvg2/svg/SVGFEFuncRElement.cpp:
1819         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
1820         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
1821         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
1822         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
1823         (WebCore::SVGFEGaussianBlurElement::filterEffect):
1824         * ksvg2/svg/SVGFEGaussianBlurElement.h:
1825         * ksvg2/svg/SVGFELightElement.cpp:
1826         (WebCore::SVGFELightElement::SVGFELightElement):
1827         (WebCore::SVGFELightElement::parseMappedAttribute):
1828         * ksvg2/svg/SVGFELightElement.h:
1829         * ksvg2/svg/SVGFEMergeElement.cpp:
1830         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
1831
1832 2006-10-09  Rob Buis  <buis@kde.org>
1833
1834         Reviewed by olliej.
1835
1836         http://bugs.webkit.org/show_bug.cgi?id=11217
1837         Cleanup svg coding style
1838
1839         Cleanup coding style in SVGPath* classes.
1840
1841         * ksvg2/svg/SVGPathElement.cpp:
1842         (WebCore::SVGPathElement::SVGPathElement):
1843         (WebCore::SVGPathElement::getPointAtLength):
1844         (WebCore::SVGPathElement::createSVGPathSegClosePath):
1845         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
1846         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
1847         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
1848         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
1849         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
1850         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
1851         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
1852         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
1853         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
1854         (WebCore::SVGPathElement::createSVGPathSegArcRel):
1855         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
1856         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
1857         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
1858         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
1859         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
1860         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
1861         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
1862         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
1863         (WebCore::SVGPathElement::svgMoveTo):
1864         (WebCore::SVGPathElement::svgLineTo):
1865         (WebCore::SVGPathElement::svgLineToHorizontal):
1866         (WebCore::SVGPathElement::svgLineToVertical):
1867         (WebCore::SVGPathElement::svgCurveToCubic):
1868         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
1869         (WebCore::SVGPathElement::svgCurveToQuadratic):
1870         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
1871         (WebCore::SVGPathElement::svgArcTo):
1872         (WebCore::SVGPathElement::parseMappedAttribute):
1873         (WebCore::SVGPathElement::pathSegList):
1874         (WebCore::SVGPathElement::normalizedPathSegList):
1875         (WebCore::SVGPathElement::animatedPathSegList):
1876         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
1877         (WebCore::SVGPathElement::toPathData):
1878         * ksvg2/svg/SVGPathElement.h:
1879         (WebCore::SVGPathElement::rendererIsNeeded):
1880         * ksvg2/svg/SVGPathSeg.h:
1881         * ksvg2/svg/SVGPathSegArc.cpp:
1882
1883 2006-10-09  Rob Buis  <buis@kde.org>
1884
1885         Reviewed by aroben.
1886
1887         http://bugs.webkit.org/show_bug.cgi?id=11217
1888         Cleanup svg coding style
1889
1890         Cleanup coding style in svg shape classes.
1891
1892         * ksvg2/svg/SVGCircleElement.cpp:
1893         (WebCore::SVGCircleElement::SVGCircleElement):
1894         (WebCore::SVGCircleElement::parseMappedAttribute):
1895         (WebCore::SVGCircleElement::pushAttributeContext):
1896         * ksvg2/svg/SVGCircleElement.h:
1897         (WebCore::SVGCircleElement::rendererIsNeeded):
1898         * ksvg2/svg/SVGEllipseElement.cpp:
1899         * ksvg2/svg/SVGEllipseElement.h:
1900         (WebCore::SVGEllipseElement::rendererIsNeeded):
1901         * ksvg2/svg/SVGLineElement.cpp:
1902         (WebCore::SVGLineElement::parseMappedAttribute):
1903         (WebCore::SVGLineElement::pushAttributeContext):
1904         * ksvg2/svg/SVGLineElement.h:
1905         (WebCore::SVGLineElement::rendererIsNeeded):
1906         * ksvg2/svg/SVGPolyElement.cpp:
1907         (WebCore::SVGPolyElement::SVGPolyElement):
1908         (WebCore::SVGPolyElement::points):
1909         (WebCore::SVGPolyElement::animatedPoints):
1910         (WebCore::SVGPolyElement::parseMappedAttribute):
1911         (WebCore::SVGPolyElement::notifyAttributeChange):
1912         * ksvg2/svg/SVGPolyElement.h:
1913         (WebCore::SVGPolyElement::rendererIsNeeded):
1914         * ksvg2/svg/SVGPolygonElement.cpp:
1915         (WebCore::SVGPolygonElement::SVGPolygonElement):
1916         (WebCore::SVGPolygonElement::toPathData):
1917         * ksvg2/svg/SVGPolygonElement.h:
1918         * ksvg2/svg/SVGPolylineElement.cpp:
1919         (WebCore::SVGPolylineElement::SVGPolylineElement):
1920         (WebCore::SVGPolylineElement::toPathData):
1921         * ksvg2/svg/SVGPolylineElement.h:
1922         * ksvg2/svg/SVGRectElement.cpp:
1923         (WebCore::SVGRectElement::parseMappedAttribute):
1924         (WebCore::SVGRectElement::pushAttributeContext):
1925         * ksvg2/svg/SVGRectElement.h:
1926         (WebCore::SVGRectElement::rendererIsNeeded):
1927
1928 2006-10-08  Darin Adler  <darin@apple.com>
1929
1930         Reviewed by Maciej.
1931
1932         - added a bit more WebCoreSystemInterface
1933
1934             wkGetNSURLResponseCalculatedExpiration
1935             wkGetNSURLResponseLastModifiedDate
1936             wkGetNSURLResponseMustRevalidate
1937
1938         * WebCore.exp: Added the new symbols.
1939         * platform/mac/WebCoreSystemInterface.h: Ditto.
1940         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1941
1942         - quiet down the code generation script
1943
1944         * bindings/scripts/CodeGenerator.pm:
1945
1946 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1947
1948         Reviewed by Darin.
1949
1950         - more code laundering - add wkSupportsMultipartXMixedReplace
1951
1952         * WebCore.exp:
1953         * platform/mac/WebCoreSystemInterface.h:
1954         * platform/mac/WebCoreSystemInterface.mm:
1955
1956 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1957
1958         Reviewed by Darin and Oliver.
1959
1960         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
1961
1962         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
1963         (WebCore::GraphicsContext::drawConvexPolygon):
1964
1965 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1966
1967         Reviewed by Darin.
1968
1969         * page/Frame.cpp:
1970         (WebCore::Frame::submitForm):
1971         No need to use latin1() here.
1972
1973 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
1974
1975         Reviewed by Darin.
1976
1977         Kill warnings when generating IDL files on Qt/Linux, as the
1978         SOURCE_ROOT environment variable is not defined (and not needed) for us.
1979
1980         * bindings/scripts/CodeGenerator.pm:
1981
1982 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
1983
1984         Reviewed by Darin.
1985
1986         - split didNotOpenURL: into general and page-cache-specific parts
1987
1988         * bridge/mac/WebCoreFrameBridge.h:
1989         * bridge/mac/WebCoreFrameBridge.mm:
1990         (-[WebCoreFrameBridge didNotOpenURL:]):
1991         (-[WebCoreFrameBridge invalidatePageCache:]):
1992
1993 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
1994
1995         Reviewed by Darin.
1996
1997         * loader/loader.cpp:
1998         Remove DeprecatedStringList.h include.
1999         
2000         * page/Frame.cpp:
2001         (WebCore::Frame::submitForm):
2002         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
2003
2004 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
2005
2006         Reviewed by Darin.
2007
2008         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
2009         Yet another round of Objective-C SVG DOM bindings auto-generation
2010
2011         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, 
2012           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
2013           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, 
2014           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, 
2015           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, 
2016           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, 
2017           DOMSVGZoomAndPan and DOMSVGZoomEvent.
2018
2019         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
2020           using the new [ConvertFromString] property.
2021
2022         - Add forward declarations for NS* types to auto-generated classes.
2023
2024         * DerivedSources.make:
2025         * WebCore.xcodeproj/project.pbxproj:
2026         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
2027         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
2028         * bindings/objc/DOMInternal.h:
2029         * bindings/objc/DOMSVG.h:
2030         * bindings/scripts/CodeGeneratorObjC.pm:
2031         * html/HTMLAppletElement.idl:
2032         * html/HTMLEmbedElement.idl:
2033         * ksvg2/svg/SVGPatternElement.idl:
2034         * ksvg2/svg/SVGPolygonElement.idl:
2035         * ksvg2/svg/SVGPolylineElement.idl:
2036         * ksvg2/svg/SVGRadialGradientElement.idl:
2037         * ksvg2/svg/SVGRenderingIntent.idl:
2038         * ksvg2/svg/SVGScriptElement.idl:
2039         * ksvg2/svg/SVGSetElement.idl:
2040         * ksvg2/svg/SVGStopElement.idl:
2041         * ksvg2/svg/SVGSwitchElement.idl:
2042         * ksvg2/svg/SVGSymbolElement.idl:
2043         * ksvg2/svg/SVGTRefElement.idl:
2044         * ksvg2/svg/SVGTSpanElement.idl:
2045         * ksvg2/svg/SVGTextContentElement.idl:
2046         * ksvg2/svg/SVGTextElement.idl:
2047         * ksvg2/svg/SVGTextPositioningElement.idl:
2048         * ksvg2/svg/SVGTitleElement.idl:
2049         * ksvg2/svg/SVGUseElement.idl:
2050         * ksvg2/svg/SVGViewElement.idl:
2051         * ksvg2/svg/SVGZoomEvent.idl:
2052
2053 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2054
2055         Reviewed by Maciej.
2056
2057         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.        
2058         * loader/loader.cpp:
2059         (WebCore::Loader::servePendingRequests):
2060         
2061 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2062
2063         Reviewed by Darin.
2064
2065         Convert a bunch of RefPtr<StringImpl> to String.
2066         
2067         * bridge/mac/FrameMac.h:
2068         * bridge/mac/FrameMac.mm:
2069         (WebCore::FrameMac::didTellBridgeAboutLoad):
2070         (WebCore::FrameMac::haveToldBridgeAboutLoad):
2071         * dom/BeforeUnloadEvent.cpp:
2072         (WebCore::BeforeUnloadEvent::storeResult):
2073         * dom/BeforeUnloadEvent.h:
2074         (WebCore::BeforeUnloadEvent::result):
2075         * dom/Document.cpp:
2076         (WebCore::Document::createEntityReference):
2077         * dom/Entity.cpp:
2078         (WebCore::Entity::Entity):
2079         (WebCore::Entity::nodeName):
2080         (WebCore::Entity::toString):
2081         * dom/Entity.h:
2082         (WebCore::Entity::publicId):
2083         (WebCore::Entity::systemId):
2084         (WebCore::Entity::notationName):
2085         * dom/EntityReference.cpp:
2086         (WebCore::EntityReference::EntityReference):
2087         (WebCore::EntityReference::nodeName):
2088         (WebCore::EntityReference::cloneNode):
2089         (WebCore::EntityReference::toString):
2090         * dom/EntityReference.h:
2091         * dom/KeyboardEvent.cpp:
2092         (WebCore::KeyboardEvent::KeyboardEvent):
2093         (WebCore::KeyboardEvent::initKeyboardEvent):
2094         * dom/KeyboardEvent.h:
2095         (WebCore::KeyboardEvent::keyIdentifier):
2096         * dom/MutationEvent.cpp:
2097         (WebCore::MutationEvent::MutationEvent):
2098         (WebCore::MutationEvent::initMutationEvent):
2099         * dom/MutationEvent.h:
2100         (WebCore::MutationEvent::prevValue):
2101         (WebCore::MutationEvent::newValue):
2102         (WebCore::MutationEvent::attrName):
2103         * dom/Notation.cpp:
2104         (WebCore::Notation::Notation):
2105         (WebCore::Notation::nodeName):
2106         * dom/Notation.h:
2107         (WebCore::Notation::publicId):
2108         (WebCore::Notation::systemId):
2109         * dom/ProcessingInstruction.cpp:
2110         (WebCore::ProcessingInstruction::ProcessingInstruction):
2111         (WebCore::ProcessingInstruction::setData):
2112         (WebCore::ProcessingInstruction::nodeName):
2113         (WebCore::ProcessingInstruction::nodeValue):
2114         (WebCore::ProcessingInstruction::cloneNode):
2115         (WebCore::ProcessingInstruction::checkStyleSheet):
2116         (WebCore::ProcessingInstruction::toString):
2117         * dom/ProcessingInstruction.h:
2118         (WebCore::ProcessingInstruction::target):
2119         (WebCore::ProcessingInstruction::data):
2120         (WebCore::ProcessingInstruction::localHref):
2121
2122 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2123
2124         Reviewed by Tim H.
2125
2126         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
2127         10 more SVG Objective-C auto-generated bindings
2128
2129         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
2130           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
2131           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
2132           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
2133
2134         - Auto-generate the text method for DOMRange.
2135
2136         * DerivedSources.make:
2137         * WebCore.xcodeproj/project.pbxproj:
2138         * bindings/objc/DOM.mm:
2139         * bindings/objc/DOMExtensions.h:
2140         * bindings/objc/DOMInternal.h:
2141         * bindings/objc/DOMPrivate.h:
2142         * bindings/objc/DOMRGBColor.mm:
2143         * bindings/objc/DOMSVG.h:
2144         * bindings/objc/PublicDOMInterfaces.h:
2145         * bindings/scripts/CodeGeneratorObjC.pm:
2146         * dom/Range.idl:
2147         * ksvg2/svg/SVGFilterElement.cpp:
2148         * ksvg2/svg/SVGFilterElement.h:
2149         * ksvg2/svg/SVGFilterElement.idl:
2150         * ksvg2/svg/SVGForeignObjectElement.idl:
2151         * ksvg2/svg/SVGGElement.idl:
2152         * ksvg2/svg/SVGGradientElement.idl:
2153         * ksvg2/svg/SVGImageElement.idl:
2154         * ksvg2/svg/SVGLineElement.idl:
2155         * ksvg2/svg/SVGLinearGradientElement.idl:
2156         * ksvg2/svg/SVGMarkerElement.idl:
2157         * ksvg2/svg/SVGMaskElement.idl:
2158         * ksvg2/svg/SVGPaint.idl:
2159
2160 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2161
2162         Reviewed by Tim H.
2163
2164         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
2165         Auto-generate a few more Objective-C DOM interfaces
2166
2167         - Fully auto-generate DOMAbstractView and DOMRange.
2168
2169         - Auto-generate just the interface for DOMRGBColor.
2170
2171         - Add DOMRanges.h as the new top level file for Ranges
2172           module.
2173
2174         - Add DOMRanges.h and DOMXPath.h to DOM.mm
2175
2176         * DerivedSources.make:
2177         * WebCore.xcodeproj/project.pbxproj:
2178         * bindings/objc/DOM.h:
2179         * bindings/objc/DOM.mm:
2180         * bindings/objc/DOMAbstractView.h: Removed.
2181         * bindings/objc/DOMAbstractView.mm: Removed.
2182         * bindings/objc/DOMInternal.h:
2183         * bindings/objc/DOMPrivate.h:
2184         * bindings/objc/DOMRGBColor.h: Removed.
2185         * bindings/objc/DOMRGBColor.mm:
2186         * bindings/objc/DOMRange.h: Removed.
2187         * bindings/objc/DOMRanges.h: Added.
2188         * bindings/objc/PublicDOMInterfaces.h:
2189         * bindings/scripts/CodeGeneratorObjC.pm:
2190         * css/RGBColor.idl:
2191         * dom/Range.idl:
2192         * page/AbstractView.idl: Added.
2193
2194 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
2195
2196         Reviewed by Eric.
2197
2198         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
2199         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
2200
2201         Return null when there is no frame. This matches Firefox.
2202
2203         * bindings/js/kjs_html.cpp:
2204         (KJS::JSHTMLDocument::getValueProperty):
2205
2206 2006-10-07  David Hyatt  <hyatt@apple.com>
2207
2208         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
2209         scrollbar joins properly.
2210
2211         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
2212         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
2213
2214         Reviewed by mitz
2215
2216         * page/FrameView.cpp:
2217         (WebCore::selectCursor):
2218         (WebCore::FrameView::handleMouseMoveEvent):
2219         * platform/mac/PlatformScrollBar.h:
2220         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2221         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2222         * rendering/RenderLayer.cpp:
2223         (WebCore::RenderLayer::RenderLayer):
2224         (WebCore::RenderLayer::~RenderLayer):
2225         (WebCore::RenderLayer::updateLayerPositions):
2226         (WebCore::scrollCornerRect):
2227         (WebCore::RenderLayer::positionOverflowControls):
2228         (WebCore::RenderLayer::paintOverflowControls):
2229         (WebCore::RenderLayer::isPointInResizeControl):
2230         (WebCore::RenderLayer::paintLayer):
2231         * rendering/RenderLayer.h:
2232
2233 2006-10-07  Mark Rowe  <bdash@webkit.org>
2234
2235         Reviewed by Mitz.
2236
2237         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
2238         matching recent ResourceLoader changes.
2239
2240         * platform/gdk/FrameGdk.cpp:
2241         (WebCore::FrameGdk::openURL):
2242         (WebCore::FrameGdk::urlSelected):
2243         * platform/gdk/PlatformScrollBar.h:
2244         * platform/gdk/ResourceLoaderCurl.cpp:
2245         (WebCore::ResourceLoader::start):
2246         * platform/gdk/ScrollViewGdk.cpp:
2247         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2248         (WebCore::ScrollView::resizeContents):
2249         (WebCore::ScrollView::scrollBy):
2250         (WebCore::ScrollView::hScrollbarMode):
2251         (WebCore::ScrollView::vScrollbarMode):
2252         (WebCore::ScrollView::suppressScrollbars):
2253         (WebCore::ScrollView::setHScrollbarMode):
2254         (WebCore::ScrollView::setVScrollbarMode):
2255         (WebCore::ScrollView::setScrollbarsMode):
2256         * platform/gdk/TemporaryLinkStubs.cpp:
2257         (FrameView::passMousePressEventToScrollbar):
2258         (Widget::removeFromParent):
2259         (ScrollView::addChild):
2260         (ScrollView::updateScrollbars):
2261         (ScrollView::scrollbarUnderMouse):
2262         (PlatformScrollbar::PlatformScrollbar):
2263         (PlatformScrollbar::~PlatformScrollbar):
2264         (PlatformScrollbar::width):
2265         (PlatformScrollbar::height):
2266         (PlatformScrollbar::setEnabled):
2267         (PlatformScrollbar::paint):
2268         (PlatformScrollbar::updateThumbPosition):
2269         (PlatformScrollbar::updateThumbProportion):
2270         (PlatformScrollbar::setRect):
2271         (Scrollbar::Scrollbar):
2272         (Scrollbar::setSteps):
2273         (Scrollbar::scroll):
2274         (Scrollbar::setValue):
2275         (Scrollbar::setProportion):
2276
2277 2006-10-06  Dave Hyatt  <hyatt@apple.com>
2278
2279         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
2280
2281         * page/FrameView.cpp:
2282         (WebCore::FrameView::windowClipRect):
2283         * page/FrameView.h:
2284         * platform/ScrollView.h:
2285         * platform/Widget.cpp:
2286         (WebCore::Widget::windowClipRect):
2287         * platform/Widget.h:
2288         (WebCore::Widget::geometryChanged):
2289         (WebCore::Widget::handleMouseMoveEvent):
2290         (WebCore::Widget::handleMouseReleaseEvent):
2291         * platform/mac/ScrollViewMac.mm:
2292         (WebCore::ScrollView::addChild):
2293         * rendering/RenderLayer.cpp:
2294         (WebCore::RenderLayer::documentClipRect):
2295         * rendering/RenderLayer.h:
2296
2297 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
2298
2299         Reviewed by Adam.
2300
2301         Add another method we'll need for scrollbar dodging
2302
2303         * platform/ScrollView.h:
2304         * platform/win/TemporaryLinkStubs.cpp:
2305         (ScrollView::resizerOverlapsContent):
2306
2307 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
2308
2309         Reviewed by Tim H.
2310
2311         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
2312         Auto-generate the interfaces even for Objective-C DOM 
2313         bindings that need custom implementations
2314
2315         - Fully auto-generate DOMEventTarget, DOMNodeFilter and 
2316           DOMHTMLOptionElement.
2317
2318         - Auto-generate just the interface for DOMHTMLAppletElement,
2319           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
2320           using the new IDL property ObjCCustomImplementation.
2321
2322         * DerivedSources.make:
2323         * WebCore.xcodeproj/project.pbxproj:
2324         * bindings/objc/DOMEventTarget.h: Removed.
2325         * bindings/objc/DOMHTMLAppletElement.h: Removed.
2326         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
2327         * bindings/objc/DOMHTMLOptionElement.h: Removed.
2328         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
2329         * bindings/objc/DOMInternal.h:
2330         * bindings/objc/DOMNodeFilter.h: Removed.
2331         * bindings/objc/DOMSVGNumber.h: Removed.
2332         * bindings/objc/DOMSVGPoint.h: Removed.
2333         * bindings/objc/DOMSVGPoint.mm:
2334         (-[DOMSVGPoint matrixTransform:]):
2335         * bindings/objc/DOMSVGRect.h: Removed.
2336         * bindings/objc/PublicDOMInterfaces.h:
2337         * bindings/scripts/CodeGeneratorObjC.pm:
2338         * dom/EventTarget.idl:
2339         * html/HTMLAppletElement.idl:
2340         * html/HTMLEmbedElement.idl:
2341         * html/HTMLOptionElement.idl:
2342         * ksvg2/svg/SVGNumber.idl:
2343         * ksvg2/svg/SVGPoint.idl:
2344         * ksvg2/svg/SVGRect.idl:
2345
2346 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
2347
2348         Reviewed by Tim H.
2349
2350         Make Qt/Linux compile again completly.
2351
2352         * platform/qt/WidgetQt.cpp:
2353         (WebCore::Widget::removeFromParent):
2354
2355 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
2356
2357         Reviewed by Tim H.
2358
2359         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
2360
2361         * platform/qt/PlatformScrollBar.h:
2362         * platform/qt/ScrollViewQt.cpp:
2363         (WebCore::ScrollView::hScrollbarMode):
2364         (WebCore::ScrollView::vScrollbarMode):
2365         (WebCore::ScrollView::suppressScrollbars):
2366         (WebCore::ScrollView::setHScrollbarMode):
2367         (WebCore::ScrollView::setVScrollbarMode):
2368         (WebCore::ScrollView::setScrollbarsMode):
2369         (WebCore::ScrollView::scrollbarUnderMouse):
2370         * platform/qt/TemporaryLinkStubs.cpp:
2371         (WebCore::Scrollbar::Scrollbar):
2372         (WebCore::Scrollbar::setSteps):
2373         (WebCore::Scrollbar::scroll):
2374         (WebCore::Scrollbar::setValue):
2375         (WebCore::Scrollbar::setProportion):
2376         (WebCore::PlatformScrollbar::PlatformScrollbar):
2377         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2378         (WebCore::PlatformScrollbar::width):
2379         (WebCore::PlatformScrollbar::height):
2380         (WebCore::PlatformScrollbar::setEnabled):
2381         (WebCore::PlatformScrollbar::paint):
2382         (WebCore::PlatformScrollbar::updateThumbPosition):
2383         (WebCore::PlatformScrollbar::updateThumbProportion):
2384         (WebCore::PlatformScrollbar::setRect):
2385         (FrameView::passMousePressEventToScrollbar):
2386
2387 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
2388
2389         Reviewed by Tim H.
2390
2391         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
2392         Another round of Objective-C SVG DOM bindings auto-generation
2393
2394         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, 
2395           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, 
2396           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, 
2397           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
2398           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, 
2399           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, 
2400           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, 
2401           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, 
2402           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, 
2403           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, 
2404           DOMSVGFETileElement, DOMSVGFETurbulenceElement, 
2405           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. 
2406
2407         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
2408           and DOMSVGRect.
2409
2410         - IDL clean up.
2411
2412         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
2413           in it's macro declaration and definition.
2414
2415         * DerivedSources.make:
2416         * WebCore.xcodeproj/project.pbxproj:
2417         * bindings/objc/DOMCSS.mm:
2418         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2419         * bindings/objc/DOMInternal.h:
2420         * bindings/objc/DOMSVG.h:
2421         * bindings/objc/DOMSVGNumber.h: Added.
2422         * bindings/objc/DOMSVGNumber.mm: Added.
2423         (-[DOMSVGNumber dealloc]):
2424         (-[DOMSVGNumber finalize]):
2425         (-[DOMSVGNumber value]):
2426         (-[DOMSVGNumber setValue:]):
2427         (-[DOMSVGNumber _SVGNumber]):
2428         (-[DOMSVGNumber _initWithFloat:]):
2429         (+[DOMSVGNumber _SVGNumberWith:]):
2430         * bindings/objc/DOMSVGPoint.h: Added.
2431         * bindings/objc/DOMSVGPoint.mm: Added.
2432         (-[DOMSVGPoint dealloc]):
2433         (-[DOMSVGPoint finalize]):
2434         (-[DOMSVGPoint x]):
2435         (-[DOMSVGPoint setX:]):
2436         (-[DOMSVGPoint y]):
2437         (-[DOMSVGPoint setY:]):
2438         (-[DOMSVGPoint WebCore::]):
2439         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
2440         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
2441         * bindings/objc/DOMSVGRect.h: Added.
2442         * bindings/objc/DOMSVGRect.mm: Added.
2443         (-[DOMSVGRect dealloc]):
2444         (-[DOMSVGRect finalize]):
2445         (-[DOMSVGRect x]):
2446         (-[DOMSVGRect setX:]):
2447         (-[DOMSVGRect y]):
2448         (-[DOMSVGRect setY:]):
2449         (-[DOMSVGRect width]):
2450         (-[DOMSVGRect setWidth:]):
2451         (-[DOMSVGRect height]):
2452         (-[DOMSVGRect setHeight:]):
2453         (-[DOMSVGRect WebCore::]):
2454         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
2455         (+[DOMSVGRect _SVGRectWith:WebCore::]):
2456         * bindings/scripts/CodeGeneratorObjC.pm:
2457         * ksvg2/svg/SVGAnimatedNumberList.idl:
2458         * ksvg2/svg/SVGAnimatedRect.idl:
2459         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
2460         * ksvg2/svg/SVGCursorElement.idl:
2461         * ksvg2/svg/SVGFEBlendElement.idl:
2462         * ksvg2/svg/SVGFEColorMatrixElement.idl:
2463         * ksvg2/svg/SVGFEComponentTransferElement.idl:
2464         * ksvg2/svg/SVGFECompositeElement.idl:
2465         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
2466         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
2467         * ksvg2/svg/SVGFEDistantLightElement.idl:
2468         * ksvg2/svg/SVGFEFloodElement.idl:
2469         * ksvg2/svg/SVGFEFuncAElement.idl:
2470         * ksvg2/svg/SVGFEFuncBElement.idl:
2471         * ksvg2/svg/SVGFEFuncGElement.idl:
2472         * ksvg2/svg/SVGFEFuncRElement.idl:
2473         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
2474         * ksvg2/svg/SVGFEImageElement.idl:
2475         * ksvg2/svg/SVGFEMergeElement.idl:
2476         * ksvg2/svg/SVGFEMergeNodeElement.idl:
2477         * ksvg2/svg/SVGFEOffsetElement.idl:
2478         * ksvg2/svg/SVGFEPointLightElement.idl:
2479         * ksvg2/svg/SVGFESpecularLightingElement.idl:
2480         * ksvg2/svg/SVGFESpotLightElement.idl:
2481         * ksvg2/svg/SVGFETileElement.idl:
2482         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2483         * ksvg2/svg/SVGFETurbulenceElement.h:
2484         * ksvg2/svg/SVGFETurbulenceElement.idl:
2485         * ksvg2/svg/SVGNumberList.idl:
2486
2487 2006-10-06  Adam Roben  <aroben@apple.com>
2488
2489         Backing out my previous change.
2490
2491         * WebCore.xcodeproj/project.pbxproj:
2492         * page/FrameView.cpp:
2493         (WebCore::FrameView::adjustViewSize):
2494
2495 2006-10-06  Adam Roben  <aroben@apple.com>
2496
2497         Build fix.
2498
2499         * WebCore.xcodeproj/project.pbxproj:
2500         * page/FrameView.cpp:
2501         (WebCore::FrameView::windowResizerRect):
2502
2503 2006-10-06  Adam Roben  <aroben@apple.com>
2504
2505         Reviewed by Maciej.
2506
2507         More loader tweaks.
2508
2509         * platform/ResourceLoader.h:
2510         * platform/ResourceLoaderInternal.h:
2511         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2512         * platform/win/TemporaryLinkStubs.cpp:
2513         (WebCore::ResourceLoader::newHTTPRequest):
2514
2515 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
2516
2517         Reviewed by aroben.
2518
2519         Stub out some methods that we'll be able to use to dodge a window resizer.
2520
2521         * bridge/win/FrameWin.h:
2522         * page/Frame.h:
2523         (WebCore::Frame::windowResizerRect):
2524         * page/FrameView.h:
2525         * platform/ScrollView.h:
2526         (WebCore::ScrollView::windowResizerRect):
2527         * platform/Widget.h:
2528         * platform/win/TemporaryLinkStubs.cpp:
2529         (FrameView::windowResizerRect):
2530         (Widget::setParent):
2531         (Widget::parent):
2532         (FrameWin::windowResizerRect):
2533
2534 2006-10-05  Dave Hyatt  <hyatt@apple.com>
2535
2536         Stub out setFrameGeometry.
2537         
2538         * platform/ScrollView.h:
2539
2540 2006-10-05  Adele Peterson  <adele@apple.com>
2541
2542         Reverting autoscroll fix.  I need to rework this a little.
2543
2544         * page/Frame.cpp:
2545         (WebCore::Frame::handleAutoscroll):
2546         (WebCore::Frame::autoscrollTimerFired):
2547         (WebCore::Frame::stopAutoscrollTimer):
2548         * page/Frame.h:
2549         * rendering/RenderLayer.cpp:
2550         (WebCore::RenderLayer::~RenderLayer):
2551         * rendering/RenderListBox.cpp:
2552         (WebCore::RenderListBox::~RenderListBox):
2553
2554 2006-10-05  Alice  <alice.liu@apple.com>
2555
2556         Reviewed by Adam.
2557
2558         Fixed <rdar://problem/4731778>
2559
2560         * editing/CommandByName.cpp:
2561         (WebCore::Frame::Command::):
2562         was calling the wrong enabledFn for arrow selection and navigation
2563
2564 2006-10-05  Adele Peterson  <adele@apple.com>
2565
2566         Reviewed by Maciej.
2567
2568         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
2569           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
2570
2571         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
2572         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
2573
2574         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
2575         (WebCore::Frame::handleAutoscroll):
2576         (WebCore::Frame::autoscrollTimerFired):
2577         (WebCore::Frame::autoscrollRenderer):
2578         (WebCore::Frame::setAutoscrollRenderer):
2579         (WebCore::Frame::stopAutoscrollTimer):
2580         * page/Frame.h:
2581
2582 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2583
2584         Reviewed by Eric.
2585
2586         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
2587         Properly include PlatformScrollBar.h in WbCore.vcproj.
2588         Clean up WidgetWin.cpp a bit.
2589
2590         * WebCore.vcproj/WebCore/WebCore.vcproj:
2591         * platform/Widget.h:
2592         * platform/win/PlatformScrollBar.h:
2593         * platform/win/ScrollViewWin.cpp:
2594         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2595         (WebCore::ScrollView::resizeContents):
2596         (WebCore::ScrollView::scrollBy):
2597         (WebCore::ScrollView::hScrollbarMode):
2598         (WebCore::ScrollView::vScrollbarMode):
2599         (WebCore::ScrollView::suppressScrollbars):
2600         (WebCore::ScrollView::setHScrollbarMode):
2601         (WebCore::ScrollView::setVScrollbarMode):
2602         (WebCore::ScrollView::setScrollbarsMode):
2603         (WebCore::ScrollView::updateScrollbars):
2604         * platform/win/TemporaryLinkStubs.cpp:
2605         (FrameView::passMousePressEventToScrollbar):
2606         (Widget::removeFromParent):
2607         (ScrollView::scrollbarUnderMouse):
2608         (PlatformScrollbar::PlatformScrollbar):
2609         (PlatformScrollbar::~PlatformScrollbar):
2610         (PlatformScrollbar::width):
2611         (PlatformScrollbar::height):
2612         (PlatformScrollbar::setEnabled):
2613         (PlatformScrollbar::paint):
2614         (PlatformScrollbar::updateThumbPosition):
2615         (PlatformScrollbar::updateThumbProportion):
2616         (PlatformScrollbar::setRect):
2617         (Scrollbar::Scrollbar):
2618         (Scrollbar::setSteps):
2619         (Scrollbar::scroll):
2620         (Scrollbar::setValue):
2621         (Scrollbar::setProportion):
2622         * platform/win/WidgetWin.cpp:
2623         (WebCore::WidgetPrivate::WidgetPrivate):
2624         (WebCore::Widget::Widget):
2625         (WebCore::Widget::setContainingWindow):
2626         (WebCore::Widget::containingWindow):
2627
2628 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2629
2630         build fix.
2631         
2632         * WebCore.xcodeproj/project.pbxproj:
2633         * bridge/mac/BrowserExtensionMac.mm:
2634         (WebCore::BrowserExtensionMac::createNewWindow):
2635         * bridge/mac/FrameMac.mm:
2636         (WebCore::FrameMac::createFrame):
2637         * bridge/mac/FrameViewMac.mm:
2638         (WebCore::FrameView::passMousePressEventToScrollbar):
2639         * bridge/mac/WebCoreFrameBridge.mm:
2640         (-[WebCoreFrameBridge installInFrame:]):
2641         * bridge/mac/WebCoreFrameView.h:
2642         * platform/ScrollBar.cpp:
2643         * platform/Widget.h:
2644         * platform/mac/PlatformScrollBar.h:
2645         * platform/mac/PlatformScrollBarMac.mm:
2646         (NSControlSizeForScrollBarControlSize):
2647         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
2648         (-[WebCoreScrollBar detachPlatformScrollbar]):
2649         (-[WebCoreScrollBar scroll:]):
2650         (-[WebCoreScrollBar widget]):
2651         (WebCore::PlatformScrollbar::PlatformScrollbar):
2652         (WebCore::PlatformScrollbar::~PlatformScrollbar):
2653         (WebCore::PlatformScrollbar::updateThumbPosition):
2654         (WebCore::PlatformScrollbar::updateThumbProportion):
2655         (WebCore::PlatformScrollbar::scrollbarHit):
2656         (WebCore::PlatformScrollbar::width):
2657         (WebCore::PlatformScrollbar::height):
2658         (WebCore::PlatformScrollbar::setRect):
2659         (WebCore::PlatformScrollbar::setEnabled):
2660         (WebCore::PlatformScrollbar::paint):
2661         * platform/mac/ScrollViewMac.mm:
2662         (WebCore::ScrollView::setVScrollbarMode):
2663         (WebCore::ScrollView::setHScrollbarMode):
2664         (WebCore::ScrollView::setScrollbarsMode):
2665         (WebCore::ScrollView::vScrollbarMode):
2666         (WebCore::ScrollView::hScrollbarMode):
2667         (WebCore::ScrollView::suppressScrollbars):
2668         (WebCore::ScrollView::scrollbarUnderMouse):
2669         * platform/mac/WidgetMac.mm:
2670         (WebCore::Widget::removeFromParent):
2671         * rendering/RenderLayer.cpp:
2672         (WebCore::RenderLayer::destroyScrollbar):
2673
2674 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2675
2676         build fix.
2677         
2678         * platform/Widget.h:
2679         * rendering/RenderLayer.cpp:
2680         (WebCore::RenderLayer::destroyScrollbar):
2681
2682 2006-10-06  Mitz Pettel  <mitz@webkit.org>
2683
2684         http://bugs.webkit.org/show_bug.cgi?id=8276
2685         Fix broken manual test added back in r13990.
2686
2687         Add resource forks for test resources.
2688
2689         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
2690         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
2691         * manual-tests/resources/plain-text-paste/._4.txt: Added.
2692         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
2693
2694 2006-10-05  David Hyatt  <hyatt@apple.com>
2695
2696         Rename addClip to clip.
2697
2698         Reviewed by darin
2699
2700         * kcanvas/RenderForeignObject.cpp:
2701         (WebCore::RenderForeignObject::paint):
2702         * kcanvas/RenderSVGContainer.cpp:
2703         (WebCore::RenderSVGContainer::paint):
2704         * kcanvas/RenderSVGImage.cpp:
2705         (WebCore::RenderSVGImage::paint):
2706         * platform/GraphicsContext.h:
2707         * platform/cairo/GraphicsContextCairo.cpp:
2708         (WebCore::GraphicsContext::clip):
2709         * platform/cg/GraphicsContextCG.cpp:
2710         (WebCore::GraphicsContext::savePlatformState):
2711         (WebCore::GraphicsContext::restorePlatformState):
2712         (WebCore::GraphicsContext::clip):
2713         (WebCore::GraphicsContext::addRoundedRectClip):
2714         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2715         (WebCore::GraphicsContext::scale):
2716         (WebCore::GraphicsContext::rotate):
2717         (WebCore::GraphicsContext::translate):
2718         (WebCore::GraphicsContext::concatCTM):
2719         * platform/cg/GraphicsContextPlatformPrivate.h:
2720         (WebCore::GraphicsContextPlatformPrivate::save):
2721         (WebCore::GraphicsContextPlatformPrivate::restore):
2722         (WebCore::GraphicsContextPlatformPrivate::clip):
2723         (WebCore::GraphicsContextPlatformPrivate::scale):
2724         (WebCore::GraphicsContextPlatformPrivate::rotate):
2725         (WebCore::GraphicsContextPlatformPrivate::translate):
2726         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
2727         * platform/qt/GraphicsContextQt.cpp:
2728         (WebCore::GraphicsContext::clip):
2729         (WebCore::GraphicsContext::addInnerRoundedRectClip):
2730         (WebCore::GraphicsContext::addRoundedRectClip):
2731         * rendering/InlineFlowBox.cpp:
2732         (WebCore::InlineFlowBox::paintBackground):
2733         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
2734         * rendering/InlineTextBox.cpp:
2735         (WebCore::InlineTextBox::paintSelection):
2736         (WebCore::InlineTextBox::paintTextMatchMarker):
2737         * rendering/RenderBox.cpp:
2738         (WebCore::RenderBox::paintBackgroundExtended):
2739         * rendering/RenderButton.cpp:
2740         (WebCore::RenderButton::paintObject):
2741         * rendering/RenderFileUploadControl.cpp:
2742         (WebCore::RenderFileUploadControl::paintObject):
2743         * rendering/RenderLayer.cpp:
2744         (WebCore::RenderLayer::beginTransparencyLayers):
2745         (WebCore::setClip):
2746         * rendering/RenderListBox.cpp:
2747         (WebCore::RenderListBox::paintObject):
2748         * rendering/RenderMenuList.cpp:
2749         (WebCore::RenderMenuList::paintObject):
2750         * rendering/RenderTableCell.cpp:
2751         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
2752
2753 2006-10-05  Mitz Pettel  <mitz@webkit.org>
2754
2755         Reviewed by Darin.
2756
2757         - http://bugs.webkit.org/show_bug.cgi?id=10386
2758           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
2759
2760         * CMakeLists.txt:
2761         * WebCore.vcproj/WebCore/WebCore.vcproj:
2762         * WebCoreSources.bkl:
2763         * rendering/RenderImageButton.cpp: Removed.
2764         * rendering/RenderImageButton.h: Removed.
2765
2766 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
2767
2768         Reviewed by Darin.
2769
2770         - http://bugs.webkit.org/show_bug.cgi?id=11067
2771           manual-tests/scrollbar-hittest2.html is invalid
2772
2773         * manual-tests/scrollbar-hittest2.html:
2774
2775 2006-10-05  David Carson  <dacarson@gmail.com>
2776
2777         Reviewed by Darin.
2778
2779         http://bugs.webkit.org/show_bug.cgi?id=11152
2780         Adjust the tokenizer chunk size to be smaller for
2781         mobile devices, and also decrease the yield timer
2782         for the tokenizer so that it can resume earlier.
2783
2784         * html/HTMLTokenizer.cpp:
2785         * config.h:
2786
2787 2006-10-05  Adam Roben  <aroben@apple.com>
2788
2789         Removing accidentally-checked-in do-nothing code.
2790
2791         * html/HTMLInputElement.cpp:
2792         (WebCore::HTMLInputElement::defaultEventHandler):
2793
2794 2006-10-05  David Carson  <dacarson@gmail.com>
2795
2796         Reviewed by Mitz.
2797
2798         http://bugs.webkit.org/show_bug.cgi?id=11158
2799         Initialize class variables
2800
2801         * rendering/RenderLayer.cpp:
2802         (WebCore::RenderLayer::RenderLayer):
2803
2804 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2805
2806         Reviewed by Darin, landed by Adam.
2807
2808         http://bugs.webkit.org/show_bug.cgi?id=11176
2809         Fix win32 build, adapt to Maciej's ResourceLoader changes.
2810
2811         * platform/win/ResourceLoaderWin.cpp:
2812         (WebCore::ResourceLoader::start):
2813
2814 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
2815
2816         Reviewed by Darin.
2817
2818         http://bugs.webkit.org/show_bug.cgi?id=10989
2819         Provide a way for embedders to implement BrowserExtensionWin
2820
2821         * WebCore.vcproj/WebCore/WebCore.vcproj:
2822         * bridge/win/BrowserExtensionWin.cpp: Added.
2823         (BrowserExtensionWin::BrowserExtensionWin):
2824         (BrowserExtensionWin::setTypedIconURL):
2825         (BrowserExtensionWin::setIconURL):
2826         (BrowserExtensionWin::getHistoryLength):
2827         (BrowserExtensionWin::canRunModal):
2828         (BrowserExtensionWin::createNewWindow):
2829         (BrowserExtensionWin::canRunModalNow):
2830         (BrowserExtensionWin::runModal):
2831         (BrowserExtensionWin::goBackOrForward):
2832         (BrowserExtensionWin::historyURL):
2833         * bridge/win/BrowserExtensionWin.h:
2834         * bridge/win/FrameWin.cpp:
2835         (WebCore::FrameWin::createNewWindow):
2836         * bridge/win/FrameWin.h:
2837         * platform/win/TemporaryLinkStubs.cpp:
2838
2839 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
2840
2841         Reviewed by Darin.
2842         
2843         Fixed <rdar://problem/4766987>
2844         
2845         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
2846         except for file names.
2847         
2848         - fixed RenderLayer to properly tear down scrollbars, removing them from
2849         their parents.
2850
2851         * bindings/js/kjs_window.cpp:
2852         (KJS::showModalDialog):
2853         (KJS::setWindowFeature):
2854         (KJS::parseWindowFeatures):
2855         * bridge/BrowserExtension.h:
2856         * dom/Document.cpp:
2857         (WebCore::Document::setInPageCache):
2858         * html/HTMLFrameElement.cpp:
2859         (WebCore::HTMLFrameElement::init):
2860         (WebCore::HTMLFrameElement::parseMappedAttribute):
2861         * html/HTMLFrameElement.h:
2862         (WebCore::HTMLFrameElement::scrollingMode):
2863         * page/Frame.cpp:
2864         (WebCore::Frame::finishedParsing):
2865         (WebCore::Frame::scrollbarsVisible):
2866         * page/FrameView.cpp:
2867         (WebCore::FrameViewPrivate::FrameViewPrivate):
2868         (WebCore::FrameViewPrivate::reset):
2869         (WebCore::FrameView::~FrameView):
2870         (WebCore::FrameView::resetScrollbars):
2871         (WebCore::FrameView::clear):
2872         (WebCore::FrameView::initScrollbars):
2873         (WebCore::FrameView::applyOverflowToViewport):
2874         (WebCore::FrameView::layout):
2875         (WebCore::FrameView::handleMousePressEvent):
2876         (WebCore::selectCursor):
2877         (WebCore::FrameView::handleMouseMoveEvent):
2878         (WebCore::FrameView::setScrollbarsMode):
2879         (WebCore::FrameView::setVScrollbarMode):
2880         (WebCore::FrameView::setHScrollbarMode):
2881         (WebCore::FrameView::restoreScrollbar):
2882         (WebCore::FrameView::dispatchMouseEvent):
2883         (WebCore::FrameView::scrollbarMoved):
2884         * page/FrameView.h:
2885         * page/MouseEventWithHitTestResults.cpp:
2886         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
2887         * page/MouseEventWithHitTestResults.h:
2888         (WebCore::MouseEventWithHitTestResults::scrollbar):
2889         * platform/ScrollBar.cpp:
2890         (WebCore::Scrollbar::Scrollbar):
2891         (WebCore::Scrollbar::setValue):
2892         (WebCore::Scrollbar::setProportion):
2893         (WebCore::Scrollbar::setSteps):
2894         (WebCore::Scrollbar::scroll):
2895         * platform/ScrollBar.h:
2896         (WebCore::):
2897         (WebCore::ScrollbarClient::~ScrollbarClient):
2898         (WebCore::Scrollbar::~Scrollbar):
2899         (WebCore::Scrollbar::orientation):
2900         (WebCore::Scrollbar::controlSize):
2901         (WebCore::Scrollbar::hasPlatformScrollbars):
2902         (WebCore::Scrollbar::client):
2903         * platform/ScrollBarMode.h:
2904         (WebCore::):
2905         * platform/ScrollView.h:
2906         * rendering/RenderBlock.cpp:
2907         (WebCore::RenderBlock::isPointInScrollbar):
2908         * rendering/RenderLayer.cpp:
2909         (WebCore::RenderLayer::RenderLayer):
2910         (WebCore::RenderLayer::~RenderLayer):
2911         (WebCore::RenderLayer::scrollToOffset):
2912         (WebCore::RenderLayer::horizontaScrollbarWidget):
2913         (WebCore::RenderLayer::verticalScrollbarWidget):
2914         (WebCore::RenderLayer::valueChanged):
2915         (WebCore::RenderLayer::createScrollbar):
2916         (WebCore::RenderLayer::destroyScrollbar):
2917         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2918         (WebCore::RenderLayer::setHasVerticalScrollbar):
2919         (WebCore::RenderLayer::verticalScrollbarWidth):
2920         (WebCore::RenderLayer::horizontalScrollbarHeight):
2921         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2922         * rendering/RenderLayer.h:
2923         (WebCore::RenderLayer::horizontalScrollbar):
2924         (WebCore::RenderLayer::verticalScrollbar):
2925         * rendering/RenderListBox.cpp:
2926         (WebCore::RenderListBox::~RenderListBox):
2927         (WebCore::RenderListBox::calcMinMaxWidth):
2928         (WebCore::RenderListBox::isPointInScrollbar):
2929         (WebCore::RenderListBox::optionAtPoint):
2930         (WebCore::RenderListBox::valueChanged):
2931         * rendering/RenderListBox.h:
2932         * rendering/RenderObject.h:
2933         (WebCore::RenderObject::NodeInfo::scrollbar):
2934         (WebCore::RenderObject::NodeInfo::setScrollbar):
2935
2936 2006-10-05  Don Gibson  <dgibson77@gmail.com>
2937
2938         Reviewed by Adam.
2939
2940         http://bugs.webkit.org/show_bug.cgi?id=11138
2941         Incorrect mouse event generation on Windows
2942
2943         * platform/win/MouseEventWin.cpp:
2944         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2945         (1) Set mouse button even for non-click-related messages.
2946         (2) Track clicks correctly for all buttons, not just the left button.
2947
2948 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
2949
2950         Reviewed and landed by ap.
2951
2952         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
2953
2954         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
2955         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
2956         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
2957         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
2958         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
2959         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
2960         (WebCore::KRenderingPaintServerPatternQt::renderPath):
2961         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
2962         (WebCore::KRenderingPaintServerQt::setPenProperties):
2963         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
2964         (WebCore::KRenderingPaintServerSolidQt::setup):
2965         (WebCore::KRenderingPaintServerSolidQt::renderPath):
2966         * kcanvas/device/qt/RenderPathQt.cpp:
2967         (WebCore::getPathStroke):
2968
2969 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
2970
2971         Reviewed by Darin.
2972
2973         http://bugs.webkit.org/show_bug.cgi?id=11054
2974         REGRESSION: Traditional Chinese encoding in login authentication
2975
2976         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
2977         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
2978         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
2979
2980         * platform/StreamingTextDecoderICU.cpp:
2981         (WebCore::TextCodecICU::registerEncodingNames):
2982
2983 2006-10-05  Eric Seidel  <eric@eseidel.com>
2984
2985         Reviewed by mjs.
2986
2987         Removed dead code.
2988         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
2989
2990         * WebCore.xcodeproj/project.pbxproj:
2991         * ksvg2/ecma/GlobalObject.cpp: Removed.
2992         * ksvg2/ecma/GlobalObject.h: Removed.
2993
2994 2006-10-05  Adam Roben  <aroben@apple.com>
2995
2996         Reviewed by Maciej.
2997
2998         Small ResourceLoaderInternal tweak.
2999
3000         * platform/ResourceLoaderInternal.h:
3001         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3002
3003 2006-10-05  Eric Seidel  <eric@eseidel.com>
3004
3005         Reviewed by mjs.
3006
3007         More incremental KCanvas cleanup and optimization.
3008         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
3009         Optimized dash array usage to not malloc.
3010         Also removed un-needed KSVGRenderingStyle includes.
3011
3012         * kcanvas/KCanvasTreeDebug.cpp:
3013         (WebCore::operator<<):
3014         * kcanvas/RenderPath.cpp:
3015         (WebCore::RenderPath::nodeAtPoint):
3016         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
3017         (WebCore::RenderPath::strokeBBox):
3018         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3019         (WebCore::KRenderingPaintServerGradientQuartz::setup):
3020         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
3021         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3022         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3023         (WebCore::KRenderingPaintServerSolidQuartz::setup):
3024         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
3025         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3026         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
3027         * kcanvas/device/quartz/QuartzSupport.mm:
3028         (WebCore::applyStrokeStyleToContext):
3029         * ksvg2/css/SVGRenderStyle.h:
3030         (WebCore::SVGRenderStyle::hasStroke):
3031         (WebCore::SVGRenderStyle::hasFill):
3032         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3033         (WebCore::KSVGPainterFactory::fillPaintServer):
3034         (WebCore::KSVGPainterFactory::strokePaintServer):
3035         * ksvg2/misc/KCanvasRenderingStyle.h:
3036
3037 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
3038
3039         Reviewed by Adam.
3040
3041         - changed ResourceLoader to be refcounted
3042
3043         It keeps a ref on itself while loading as well. This makes
3044         for a much saner memory management model than the previous.
3045
3046         * bridge/mac/WebCoreResourceLoaderImp.mm:
3047         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
3048         * dom/XMLTokenizer.cpp:
3049         (WebCore::openFunc):
3050         * loader/icon/IconLoader.cpp:
3051         (IconLoader::IconLoader):
3052         (IconLoader::~IconLoader):
3053         (IconLoader::startLoading):
3054         (IconLoader::stopLoading):
3055         (IconLoader::receivedData):
3056         * loader/icon/IconLoader.h:
3057         * loader/loader.cpp:
3058         (WebCore::Loader::servePendingRequests):
3059         * platform/ResourceLoader.cpp:
3060         (WebCore::ResourceLoader::create):
3061         (WebCore::ResourceLoader::kill):
3062         * platform/ResourceLoader.h:
3063         * platform/ResourceLoaderInternal.h:
3064         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3065         * platform/mac/ResourceLoaderMac.mm:
3066         (WebCore::ResourceLoader::start):
3067         * xml/XSLTProcessor.cpp:
3068         (WebCore::docLoaderFunc):
3069         * xml/xmlhttprequest.cpp:
3070         (WebCore::XMLHttpRequest::send):
3071         * xml/xmlhttprequest.h:
3072
3073 2006-10-05  Eric Seidel  <eric@eseidel.com>
3074
3075         Reviewed by mjs.
3076
3077         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
3078         http://bugs.webkit.org/show_bug.cgi?id=11163
3079         
3080         No SVG performance tests yet.
3081
3082         * kcanvas/RenderForeignObject.cpp:
3083         (WebCore::RenderForeignObject::paint):
3084         * kcanvas/RenderSVGContainer.cpp:
3085         (WebCore::RenderSVGContainer::paint):
3086         * kcanvas/RenderSVGImage.cpp:
3087         (WebCore::RenderSVGImage::paint):
3088         * kcanvas/RenderSVGText.cpp:
3089         (WebCore::RenderSVGText::paint):
3090
3091 2006-10-05  Dave Hyatt  <hyatt@apple.com>
3092
3093         Stub out some stuff for widget focusability.
3094
3095         Reviewed by maciej
3096  
3097         * page/FrameView.cpp:
3098         (WebCore::FrameView::dispatchMouseEvent):
3099         * platform/ScrollView.h:
3100         * platform/Widget.h:
3101
3102 2006-10-05  Adam Roben  <aroben@apple.com>
3103
3104         Reviewed by Maciej and Tim H.
3105
3106         Copy some WebKit frame lifetime logic into WebCore -- just a step
3107         along the path to frame lifetime being handled completely in WebCore.
3108
3109         * bridge/mac/FrameMac.mm:
3110         (WebCore::FrameMac::setView): Move platform-independent parts of this
3111         method into Frame.
3112         * page/Frame.cpp:
3113         (WebCore::Frame::setView): Adding platform-independent parts of
3114         FrameMac::setView
3115         (WebCore::Frame::detachChildren): New method to accomplish what
3116         -[WebFrameBridge _detachChildren] currently does.
3117         (WebCore::Frame::clear): Call detachChildren
3118         * page/Frame.h: Add declaration for detachChildren
3119
3120 2006-10-04  Alice Liu  <alice.liu@apple.com>
3121
3122         Reviewed by Darin.
3123
3124         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
3125
3126         * xml/xmlhttprequest.cpp:
3127         (WebCore::XMLHttpRequest::setRequestHeader):
3128         removed exception set when the request is not open yet
3129
3130 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
3131
3132         Reviewed by John Sullivan.
3133
3134         <rdar://problem/4654328>
3135         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
3136         
3137         * loader/PluginDocument.cpp:
3138         (WebCore::PluginTokenizer::writeRawData):
3139         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
3140
3141 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
3142
3143         Reviewed by Tim H.
3144
3145         http://bugs.webkit.org/show_bug.cgi?id=11130
3146         Convert "undefined" to AE missing value
3147
3148         * bridge/mac/WebCoreFrameBridge.mm:
3149         (aeDescFromJSValue): return missing value for UndefinedType.
3150
3151 2006-10-03  Dave Hyatt  <hyatt@apple.com>
3152
3153         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
3154         the windowToContents/contentsToWindow functions.
3155         
3156         Reviewed by anders
3157
3158         * bridge/mac/FrameMac.mm:
3159         (WebCore::FrameMac::eventMayStartDrag):
3160         (WebCore::FrameMac::dragHysteresisExceeded):
3161         (WebCore::FrameMac::mouseDown):
3162         (WebCore::FrameMac::shouldDragAutoNode):
3163         (WebCore::FrameMac::sendContextMenuEvent):
3164         * bridge/mac/FrameViewMac.mm:
3165         (WebCore::FrameView::passMousePressEventToScrollbar):
3166         * bridge/mac/WebCoreFrameBridge.mm:
3167         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
3168         * dom/EventTargetNode.cpp:
3169         (WebCore::EventTargetNode::dispatchMouseEvent):
3170         (WebCore::EventTargetNode::dispatchWheelEvent):
3171         * page/Frame.cpp:
3172         (WebCore::Frame::selectClosestWordFromMouseEvent):
3173         (WebCore::Frame::handleMousePressEventTripleClick):
3174         (WebCore::Frame::handleMousePressEventSingleClick):
3175         (WebCore::Frame::handleMouseMoveEvent):
3176         (WebCore::Frame::handleMouseReleaseEvent):
3177         * page/FrameView.cpp:
3178         (WebCore::FrameView::handleMousePressEvent):
3179         (WebCore::FrameView::handleMouseDoubleClickEvent):
3180         (WebCore::selectCursor):
3181         (WebCore::FrameView::handleMouseMoveEvent):
3182         (WebCore::FrameView::handleMouseReleaseEvent):
3183         (WebCore::FrameView::dispatchDragEvent):
3184         (WebCore::FrameView::prepareMouseEvent):
3185         (WebCore::FrameView::handleWheelEvent):
3186         * page/FrameView.h:
3187         * platform/ScrollBar.cpp:
3188         (WebCore::ScrollBar::setValue):
3189         * platform/ScrollView.h:
3190         * platform/Widget.h:
3191         (WebCore::Widget::scrolled):
3192         * platform/mac/ScrollViewMac.mm:
3193         (WebCore::ScrollView::contentsToWindow):
3194         (WebCore::ScrollView::windowToContents):
3195         (WebCore::ScrollView::scrollbarUnderMouse):
3196         * platform/mac/WidgetMac.mm:
3197         * rendering/RenderLayer.cpp:
3198         (WebCore::RenderLayer::resize):
3199         (WebCore::RenderLayer::positionScrollbars):
3200         * rendering/RenderReplaced.cpp:
3201         (WebCore::RenderReplaced::shouldPaint):
3202         * rendering/RenderView.cpp:
3203         * rendering/RenderView.h:
3204         * rendering/RenderWidget.cpp:
3205         (WebCore::RenderWidget::setWidget):
3206
3207 2006-09-26  David Smith  <catfish.man@gmail.com>
3208
3209         Reviewed by Timothy.
3210
3211         http://bugs.webkit.org/show_bug.cgi?id=3723
3212         Add -scrollDOMRangeToVisible:
3213
3214         No automated tests are possible as this code path isn't reachable from JavaScript.
3215
3216         * bridge/mac/WebCoreFrameBridge.h:
3217         * bridge/mac/WebCoreFrameBridge.mm:
3218         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
3219
3220 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
3221
3222         Reviewed by Timothy.
3223
3224         <http://bugs.webkit.org/show_bug.cgi?id=10338>
3225         When contentEditable, cursor doesn't change to hand
3226         
3227         Allow the behaviour of editable links to be specified by a WebPreference
3228         The preference WebKitEditableLinkBehavior has four options:
3229          - AlwaysLive: Safari 2.0 behaviour
3230          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
3231          - LiveWhenNotFocused: Editable links are live only when their editable block is not
3232              focused, or when the shift key is pressed
3233          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
3234          
3235         No layout tests, just a modification of a manual-test as it isn't possible to test
3236         this automatically.
3237
3238         * bridge/mac/WebCoreSettings.h:
3239         * bridge/mac/WebCoreSettings.mm:
3240         (-[WebCoreSettings setEditableLinkBehavior:]):
3241         (-[WebCoreSettings editableLinkBehavior]):
3242         * html/HTMLAnchorElement.cpp:
3243         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3244         (WebCore::HTMLAnchorElement::defaultEventHandler):
3245         (WebCore::HTMLAnchorElement::setActive):
3246         * html/HTMLAnchorElement.h:
3247         * manual-tests/contenteditable-link.html:
3248         * page/FrameView.cpp:
3249         (WebCore::nodeIsNotBeingEdited):
3250         (WebCore::selectCursor):
3251         * page/Settings.h:
3252         (WebCore::Settings::):
3253         (WebCore::Settings::Settings):
3254         (WebCore::Settings::editableLinkBehavior):
3255         (WebCore::Settings::setEditableLinkBehavior):
3256
3257 2006-10-03  Beth Dakin  <bdakin@apple.com>
3258
3259         Reviewed Darin.
3260
3261         No test cases needed.
3262
3263         Implemented a version of StringImpl::append that takes a UChar* and 
3264         a length.
3265
3266         * platform/StringImpl.cpp:
3267         (WebCore::StringImpl::append):
3268         (WebCore::StringImpl::insert): Call new append instead of making a 
3269         new StringImpl.
3270         * platform/StringImpl.h:
3271
3272 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
3273
3274         Reviewed by Darin.
3275
3276         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
3277         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
3278
3279         * platform/win/ResourceLoaderWin.cpp:
3280         (WebCore::ResourceLoader::onHandleCreated):
3281
3282 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
3283
3284         Feared, loathed, reviewed by Darin.
3285
3286         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
3287         into FRAME, plus other cleanup.
3288         
3289         No new behavior, so no new test. Layout tests pass. Basic browsing and
3290         Mail editing seem to work.
3291         
3292         * dom/Node.cpp:
3293         (WebCore::Node::detach): Removed random commented-out code.
3294         * html/HTMLFrameElement.cpp:
3295         (WebCore::HTMLFrameElement::isURLAllowed): 
3296         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
3297         (2) Renamed newURL to completeURL because the difference between newURL
3298         and URLString is that newURL is a KURL that is the complete version of URLString,
3299         not that it is new.
3300         (WebCore::HTMLFrameElement::willRemove): 
3301         (1) Removed close() call and moved close() code into willRemove(), also removing 
3302         close() call from detach(), since willRemove is the well-defined place 
3303         from DOM tear-down, not detach().
3304         (2) Removed manual renderer detach code because the DOM is not responsible
3305         for managing the render tree. I confirmed that this change not
3306         regress <rdar://problem/4132581>.
3307         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
3308         lost their content frames after being removed from the DOM. That's our 
3309         current behavior, but it's going to change in future rounds of refactoring.
3310         This also fixes <rdar://problem/4750835>.
3311         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
3312         attach/detach, because the render tree should not be in charge of deciding
3313         when to load.
3314         * html/HTMLFrameElement.h:
3315         * html/HTMLIFrameElement.cpp:
3316         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
3317         because the renderer is a renderPartObject, not a renderPart.
3318         * html/HTMLIFrameElement.h:
3319
3320 2006-10-03  Mark Rowe  <bdash@webkit.org>
3321
3322         Reviewed by Mitz.
3323
3324         http://bugs.webkit.org/show_bug.cgi?id=11137
3325         Bug 11137: GdkLauncher dies with "pure virtual method called" if
3326         window is closed while page still loading
3327
3328         * platform/gdk/FrameGdk.cpp:
3329         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
3330         methods to be called before the FrameGdk portion of "this" is torn down.
3331
3332 2006-10-03  Adam Roben  <aroben@apple.com>
3333
3334         Reviewed by Darin.
3335
3336         Handle tab key presses in the DOM.
3337
3338         * dom/EventTargetNode.cpp:
3339         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
3340         * page/FrameView.cpp:
3341         (WebCore::FrameView::advanceFocus): Rename and reimplement
3342         focusNextPrevNode. Now we just call Element::focus().
3343         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
3344         it public.
3345
3346 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3347
3348         Reviewed by mjs
3349         
3350         <rdar://problem/4760612>
3351         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
3352         
3353         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
3354         
3355         * dom/Range.cpp:
3356         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
3357         positions are non-null since most of it's callers would be in a bad state if the positions 
3358         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
3359         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
3360         from entering compareBoundaryPoints and hitting the assert.
3361
3362 2006-10-03  Adele Peterson  <adele@apple.com>
3363
3364         Reviewed by Geoff.
3365
3366         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
3367
3368         * html/HTMLSelectElement.cpp:
3369         (WebCore::HTMLSelectElement::recalcStyle):
3370         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3371         (WebCore::HTMLSelectElement::isMouseFocusable):
3372         (WebCore::HTMLSelectElement::createRenderer):
3373         (WebCore::HTMLSelectElement::setRecalcListItems):
3374         (WebCore::HTMLSelectElement::notifyOptionSelected):
3375         (WebCore::HTMLSelectElement::defaultEventHandler):
3376
3377 2006-10-04  Darin Adler  <darin@apple.com>
3378
3379         Reviewed by Geoff.
3380
3381         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
3382           Caret disappears when you're typing
3383
3384         * editing/SelectionController.cpp:
3385         (WebCore::SelectionController::setSelection): Remove unnecessary call to
3386         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
3387         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
3388         to false so we can get the old caret repaint rect. Later we need to change the
3389         design so getting the rect doesn't have a side effect of causing a layout without
3390         invalidation.
3391
3392 2006-10-03  David Harrison  <harrison@apple.com>
3393
3394         Reviewed by Maciej.
3395
3396         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
3397
3398         Updated test:
3399         * fast/text/justified-text-rect.html
3400
3401         * bridge/mac/WebCoreFrameBridge.mm:
3402         (-[WebCoreFrameBridge convertToNSRange:]):
3403         (-[WebCoreFrameBridge convertToDOMRange:]):
3404         Make the selection's root editable element (or the document itself) be
3405         the basis for NSRange conversions. This supports "shadow DOM" like
3406         that for text fields and text areas.
3407         
3408         * editing/CompositeEditCommand.cpp:
3409         (WebCore::CompositeEditCommand::moveParagraphs):
3410         Pass the document element as the scope.
3411         
3412         * editing/TextIterator.cpp:
3413         (WebCore::TextIterator::rangeFromLocationAndLength):
3414         Make the first parameter the scope.
3415         
3416         * editing/TextIterator.h:
3417         Make the first parameter of rangeFromLocationAndLength() the scope.
3418
3419 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
3420
3421         Reviewed by Eric.
3422
3423         Fix Qt/Linux build.
3424
3425         * CMakeLists.txt: Add counter related files.
3426
3427 2006-10-03  Mark Rowe  <bdash@webkit.org>
3428
3429         Reviewed by Eric.
3430
3431         http://bugs.webkit.org/show_bug.cgi?id=10981
3432         Linux/GDK build fixes
3433
3434         Based on a patch by Krzysztof Kowalczyk.
3435
3436         * WebCoreSources.bkl:
3437         * platform/gdk/FrameGdk.cpp:
3438         (WebCore::doScroll):
3439         (WebCore::FrameGdk::handleGdkEvent):
3440         * platform/gdk/PlatformScrollBar.h: Added.
3441         (WebCore::PlatformScrollBar::isWidget):
3442         * platform/gdk/ScrollViewGdk.cpp:
3443         * platform/gdk/TemporaryLinkStubs.cpp:
3444         (FrameView::passMousePressEventToScrollbar):
3445         (FrameView::passMousePressEventToSubframe):
3446         (FrameView::passMouseReleaseEventToSubframe):
3447         (FrameView::passMouseMoveEventToSubframe):
3448         (FrameView::passWheelEventToSubframe):
3449         (Cursor::Cursor):
3450         (Widget::invalidate):
3451         (Widget::invalidateRect):
3452         (ScrollView::wheelEvent):
3453         (ScrollView::convertToContainingWindow):
3454         (ScrollView::convertFromContainingWindow):
3455         (GraphicsContext::clip):
3456         (PlatformScrollBar::PlatformScrollBar):
3457         (PlatformScrollBar::updateThumbPosition):
3458         (PlatformScrollBar::updateThumbProportion):
3459         (ScrollBar::ScrollBar):
3460         (ScrollBar::setProportion):
3461         (WebCore::supportedKeySizes):
3462         (WebCore::signedPublicKeyAndChallengeString):
3463         * platform/gdk/WheelEventGdk.cpp:
3464         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3465         * platform/gdk/WidgetGdk.cpp:
3466         (WebCore::Widget::convertToContainingWindow):
3467         (WebCore::Widget::convertFromContainingWindow):
3468
3469 2006-10-02  Adam Roben  <aroben@apple.com>
3470
3471         Reviewed by Maciej.
3472
3473         Let Windows determine which mouse button is pressed.
3474
3475         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
3476         * platform/win/MouseEventWin.cpp:
3477         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
3478         parameter to determine which mouse button is pressed.
3479
3480 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3481
3482         Reviewed by anders
3483         
3484         Build fix
3485         
3486         * editing/SelectionController.cpp:
3487         (WebCore::SelectionController::empty):
3488         * editing/SelectionController.h:
3489
3490 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3491
3492         Reviewed by john
3493         
3494         <rdar://problem/4755287>
3495         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
3496
3497         * editing/markup.cpp:
3498         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
3499         elements).  Don't skip blocks that aren't containers (like horizontal rules).
3500
3501 2006-10-03  Darin Adler  <darin@apple.com>
3502
3503         Reviewed by Justin Garcia.
3504
3505         - correct mistaken code that would restart blinking every
3506           time "invalidateSelection" is called even if the caret
3507           has not moved
3508
3509         * editing/SelectionController.h:
3510         * editing/SelectionController.cpp:
3511         (WebCore::SelectionController::setSelection): Update for name change.
3512         (WebCore::SelectionController::recomputeCaretRect): New function.
3513         Computes caret rect and does any necessary invalidation if the rect
3514         changes.
3515         (WebCore::SelectionController::invalidateCaretRect): Renamed from
3516         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
3517         calls recomputeCaretRect as a side effect.
3518
3519         * page/Frame.cpp:
3520         (WebCore::Frame::invalidateSelection): Remove unneeded call to
3521         clearCaretRectIfNeeded.
3522         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
3523         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
3524         recomputeCaretRect function and not restart blinking if caret has
3525         not changed position.
3526         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
3527         are not needed since selectionLayoutChanged already checks these.
3528
3529         * page/FramePrivate.h: Removed unused m_blinkCaret.
3530
3531 2006-10-02  Beth Dakin  <bdakin@apple.com>
3532
3533         Reviewed by Adam.
3534
3535         Build fix. Add counters to vcproj.
3536
3537         * WebCore.vcproj/WebCore/WebCore.vcproj:
3538
3539 2006-10-02  Brady Eidson  <beidson@apple.com>
3540
3541         Reviewed by Adele
3542
3543         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
3544         icon data out because we don't correctly check SQL error conditions.
3545
3546         * loader/icon/IconDataCache.cpp:
3547         (WebCore::IconDataCache::writeToDatabase):
3548
3549 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
3550
3551         Reviewed by Hyatt.
3552
3553         Added method to find out whether a layout has occurred.
3554
3555         * page/FrameView.cpp:
3556         (WebCore::FrameView::didFirstLayout):
3557         * page/FrameView.h:
3558
3559 2006-10-02  Beth Dakin  <bdakin@apple.com>
3560
3561         Reviewed by Darin.
3562
3563         Initial implementation of CSS2 counters. See http://
3564         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
3565
3566         * WebCore.xcodeproj/project.pbxproj:
3567         * css/CSSComputedStyleDeclaration.cpp: 
3568         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 
3569         the increment/reset list now that this is implemented.
3570         * css/CSSPrimitiveValue.cpp:
3571         (WebCore::CSSPrimitiveValue::cssText): 
3572         * css/Counter.h:
3573         (WebCore::Counter::Counter):
3574         (WebCore::Counter::~Counter):
3575         (WebCore::Counter::identifier):
3576         (WebCore::Counter::listStyle):
3577         (WebCore::Counter::separator):
3578         (WebCore::Counter::listStyleNumber):
3579         (WebCore::Counter::setIdentifier):
3580         (WebCore::Counter::setListStyle):
3581         (WebCore::Counter::setSeparator):
3582         * css/cssparser.cpp:
3583         (WebCore::CSSParser::addProperty): Take care of reset/increment
3584         (WebCore::CSSParser::parseValue):
3585         (WebCore::CSSParser::parseContent): content can now take counters
3586         (WebCore::CSSParser::parseCounterContent): Parse counter() and 
3587         counters()
3588         (WebCore::CSSParser::parseCounter): Parse counter-reset and 
3589         counter-increment
3590         * css/cssparser.h:
3591         * css/cssstyleselector.cpp:
3592         (WebCore::CSSStyleSelector::matchUARules):
3593         (WebCore::CSSStyleSelector::applyProperty):
3594         * platform/PlatformString.h:
3595         * platform/String.cpp:
3596         (WebCore::String::insert): Implemented a version of insert that 
3597         accepts a UChar* and a length.
3598         * platform/StringImpl.cpp:
3599         (WebCore::StringImpl::insert): Same as above.
3600         * platform/StringImpl.h:
3601         * rendering/CounterListItem.h: Added.
3602         * rendering/CounterNode.cpp: Added.
3603         (WebCore::CounterNode::CounterNode):
3604         (WebCore::CounterNode::insertAfter):