2010-11-17 Andreas Kling <kling@webkit.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-11-17  Andreas Kling  <kling@webkit.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         ScrollView: Decouple actualVisibleContentRect from visibleContentRect
6
7         Added actualVisibleContentRect() which will return the override provided
8         by setActualVisibleContentRect() or fall back to visibleContentRect()
9         if no override has been set.
10
11         This is similar to what the iPhone does.
12
13         * platform/ScrollView.cpp:
14         (WebCore::ScrollView::visibleContentRect):
15         * platform/ScrollView.h:
16         (WebCore::ScrollView::actualVisibleContentRect):
17         (WebCore::ScrollView::setActualVisibleContentRect): IntRect -> const IntRect&
18
19 2010-11-17  Tony Chang  <tony@chromium.org>
20
21         Reviewed by Adam Barth.
22
23         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
24         https://bugs.webkit.org/show_bug.cgi?id=49036
25
26         No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html
27
28         In http://codereview.chromium.org/11574, the forked chromium test
29         plugin changed how it testGetIntIdentifier to work around a change
30         caused by a silverlight specific plugin fix:
31         http://codereview.chromium.org/11569/diff/1/2
32
33         It's not clear to me that this change is needed anymore since
34         silverlight has had multiple releases, testing without this patch
35         works on a test windows build, and safari win seems to run silverlight
36         without this either.  Since there's no test for this behavior, I'm
37         rolling it out so we can match the upstream test.
38
39         * bindings/v8/V8NPUtils.cpp:
40         (WebCore::convertV8ObjectToNPVariant):
41
42 2010-11-17  Andreas Kling  <kling@webkit.org>
43
44         Reviewed by Kenneth Rohde Christiansen.
45
46         ScrollView: Let visibleContentRect() return the contentsSize() if paintsEntireContents()
47
48         * platform/ScrollView.cpp:
49         (WebCore::ScrollView::visibleContentRect):
50
51 2010-11-17  James Simonsen  <simonjam@chromium.org>
52
53         Reviewed by Tony Chang.
54
55         [chromium] Fix negative letter spacing in complex text on linux
56         https://bugs.webkit.org/show_bug.cgi?id=49563
57
58         Test: fast/text/atsui-negative-spacing-features.html
59
60         * platform/graphics/chromium/FontLinux.cpp: Make spacing signed.
61
62 2010-11-17  Andreas Kling  <kling@webkit.org>
63
64         Reviewed by Kenneth Rohde Christiansen.
65
66         ScrollView: Avoid unnecessary work in setScrollPosition() when scrolling is delegated.
67
68         * platform/ScrollView.cpp:
69         (WebCore::ScrollView::setScrollPosition): If delegatesScrolling(), we never use the
70         newScrollPosition, so move that calculation below the delegation path.
71
72 2010-11-17  Dave Hyatt  <hyatt@apple.com>
73
74         Reviewed by Sam Weinig.
75
76         https://bugs.webkit.org/show_bug.cgi?id=48537
77
78         Fonts with no vertical metrics should synthesize baselines when they appear
79         on lines that do use fonts with vertical metrics.  Basically we want to make
80         sure that English text behaves like vertical-align:middle, i.e., its baseline
81         should be treated as though it cuts through the middle of the ascent+descent.
82         
83         The way this works is that each line in the line box tree is labeled as having
84         a baseline type that is either ideographic or alphabetic for the purposes of
85         vertical alignment.  A line becomes ideographic if any font with vertical tables
86         is either explicitly specified as the primary font or in any of the used fonts
87         in the text on that line.
88         
89         This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
90         and passed to the ascent and descent methods of the fonts that are examined.
91         The underlying Font code selects an appropriate baseline given the type passed in.
92         
93         This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
94         to instead carry around the cached vertical positions for RenderInlines in a new
95         VerticalPositionCache object.  This cache only lives for a single layout
96         operation, but it does cache information across all the lines built and placed during the
97         layout.
98         
99         This matches the old behavior, since every call to layoutInlineChildren invalidated
100         all of the vertical positions in all of the RenderInlines anyway.
101         
102         The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
103         positions for both alphabetic and ideographic baseline types.
104         
105         The vertical-align computation has now been moved out of RenderBoxModelObject and
106         RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
107         This function has been changed to no longer be recursive when checking parents,
108         and it now relies on the fact that the parent vertical alignment computation result
109         has already been stored in the logicalTop() of that parent's line box.  By checking
110         the line box logicalTop() value instead of recurring, the performance of first lines
111         now significantly improves to no longer have O(n^2) behavior in the depth of the line
112         box tree on the first line.
113         
114         All of the baselinePosition functions on the various RenderObjects have been amended
115         to take a FontBaseline as the first argument.  This patch does not attempt to fix up
116         MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.
117         
118         The RenderTableCell baselinePosition virtual method has been made non-virtual and had
119         all arguments removed, since it actually had no real connection with the rest of the 
120         baseline positioning system.  Cell baseline positioning works by calling firstLineBoxBaseline,
121         and that method has been patched to use the cached baselineType for the first line box
122         when computing the baseline of that line.
123          
124         Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html.
125
126         * WebCore.xcodeproj/project.pbxproj:
127         * mathml/RenderMathMLFraction.cpp:
128         (WebCore::RenderMathMLFraction::baselinePosition):
129         * mathml/RenderMathMLFraction.h:
130         * mathml/RenderMathMLOperator.cpp:
131         (WebCore::RenderMathMLOperator::baselinePosition):
132         * mathml/RenderMathMLOperator.h:
133         * mathml/RenderMathMLRow.cpp:
134         (WebCore::RenderMathMLRow::baselinePosition):
135         * mathml/RenderMathMLRow.h:
136         * mathml/RenderMathMLSubSup.cpp:
137         (WebCore::RenderMathMLSubSup::baselinePosition):
138         * mathml/RenderMathMLSubSup.h:
139         * mathml/RenderMathMLUnderOver.cpp:
140         (WebCore::RenderMathMLUnderOver::layout):
141         (WebCore::RenderMathMLUnderOver::baselinePosition):
142         * mathml/RenderMathMLUnderOver.h:
143         * platform/graphics/SimpleFontData.h:
144         * rendering/InlineBox.h:
145         (WebCore::InlineBox::baselinePosition):
146         * rendering/InlineFlowBox.cpp:
147         (WebCore::verticalPositionForBox):
148         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
149         (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
150         * rendering/InlineFlowBox.h:
151         * rendering/InlineTextBox.cpp:
152         (WebCore::InlineTextBox::baselinePosition):
153         * rendering/InlineTextBox.h:
154         * rendering/RenderBlock.cpp:
155         (WebCore::RenderBlock::baselinePosition):
156         (WebCore::RenderBlock::firstLineBoxBaseline):
157         (WebCore::RenderBlock::lastLineBoxBaseline):
158         * rendering/RenderBlock.h:
159         * rendering/RenderBlockLineLayout.cpp:
160         (WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
161         (WebCore::RenderBlock::layoutInlineChildren):
162         * rendering/RenderBox.cpp:
163         (WebCore::RenderBox::baselinePosition):
164         * rendering/RenderBox.h:
165         * rendering/RenderBoxModelObject.cpp:
166         * rendering/RenderBoxModelObject.h:
167         * rendering/RenderFileUploadControl.cpp:
168         (WebCore::RenderFileUploadControl::paintObject):
169         * rendering/RenderInline.cpp:
170         (WebCore::RenderInline::RenderInline):
171         (WebCore::RenderInline::baselinePosition):
172         * rendering/RenderInline.h:
173         * rendering/RenderListBox.cpp:
174         (WebCore::RenderListBox::baselinePosition):
175         * rendering/RenderListBox.h:
176         * rendering/RenderListMarker.cpp:
177         (WebCore::RenderListMarker::baselinePosition):
178         * rendering/RenderListMarker.h:
179         * rendering/RenderSlider.cpp:
180         (WebCore::RenderSlider::baselinePosition):
181         * rendering/RenderSlider.h:
182         * rendering/RenderTableCell.cpp:
183         (WebCore::RenderTableCell::baselinePosition):
184         * rendering/RenderTableCell.h:
185         * rendering/RenderTextControlMultiLine.cpp:
186         (WebCore::RenderTextControlMultiLine::baselinePosition):
187         * rendering/RenderTextControlMultiLine.h:
188         * rendering/RootInlineBox.cpp:
189         (WebCore::RootInlineBox::alignBoxesInBlockDirection):
190         * rendering/RootInlineBox.h:
191         (WebCore::RootInlineBox::baselinePosition):
192         * rendering/VerticalPositionCache.h: Added.
193         (WebCore::VerticalPositionCache::VerticalPositionCache):
194         (WebCore::VerticalPositionCache::get):
195         (WebCore::VerticalPositionCache::set):
196         * rendering/svg/SVGInlineTextBox.cpp:
197         (WebCore::SVGInlineTextBox::calculateBoundaries):
198
199 2010-11-17  Sam Weinig  <sam@webkit.org>
200
201         Reviewed by Anders Carlsson.
202
203         Add stubbed out ScrollAnimator for the Mac
204         https://bugs.webkit.org/show_bug.cgi?id=49678
205
206         * WebCore.xcodeproj/project.pbxproj:
207         Add ScrollAnimator.h/cpp.
208
209         * platform/mac/ScrollAnimatorMac.cpp: Added.
210         (WebCore::ScrollAnimator::create):
211         (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
212         (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
213         (WebCore::ScrollAnimatorMac::scroll):
214         (WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
215         * platform/mac/ScrollAnimatorMac.h: Added.
216         ScrollAnimatorMac just calls through to the base class for now.
217
218 2010-11-17  Cris Neckar  <cdn@chromium.org>
219
220         Reviewed by Adam Barth.
221
222         Modified codepath for object fallback content which has failed to load.
223         Refactored CachedResource error handling to use more granular statuses instead of a boolean value.
224         https://bugs.webkit.org/show_bug.cgi?id=46921
225
226         Test: fast/html/object-image-nested-fallback.html
227
228         * html/HTMLObjectElement.cpp:
229         (WebCore::HTMLObjectElement::renderFallbackContent):
230         * loader/cache/CachedCSSStyleSheet.cpp:
231         (WebCore::CachedCSSStyleSheet::error):
232         * loader/cache/CachedCSSStyleSheet.h:
233         * loader/cache/CachedFont.cpp:
234         (WebCore::CachedFont::ensureCustomFontData):
235         (WebCore::CachedFont::error):
236         * loader/cache/CachedFont.h:
237         * loader/cache/CachedImage.cpp:
238         (WebCore::CachedImage::data):
239         (WebCore::CachedImage::error):
240         * loader/cache/CachedImage.h:
241         * loader/cache/CachedResource.cpp:
242         (WebCore::CachedResource::CachedResource):
243         (WebCore::CachedResource::canUseCacheValidator):
244         (WebCore::CachedResource::mustRevalidate):
245         * loader/cache/CachedResource.h:
246         (WebCore::CachedResource::error):
247         (WebCore::CachedResource::httpStatusCodeError):
248         (WebCore::CachedResource::errorOccurred):
249         * loader/cache/CachedScript.cpp:
250         (WebCore::CachedScript::error):
251         * loader/cache/CachedScript.h:
252         * loader/cache/CachedXSLStyleSheet.cpp:
253         (WebCore::CachedXSLStyleSheet::error):
254         * loader/cache/CachedXSLStyleSheet.h:
255         * loader/loader.cpp:
256         (WebCore::Loader::load):
257         (WebCore::Loader::didFinishLoading):
258         (WebCore::Loader::didFail):
259         (WebCore::Loader::didReceiveData):
260
261 2010-11-16  Zhenyao Mo  <zmo@google.com>
262
263         Reviewed by Kenneth Russell.
264
265         WebGLRenderingContext needs to zero textures and renderbuffers
266         https://bugs.webkit.org/show_bug.cgi?id=49355
267
268         Test: fast/canvas/webgl/uninitialized-test.html
269
270         * html/canvas/WebGLFramebuffer.cpp:
271         (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed.
272         (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
273         * html/canvas/WebGLFramebuffer.h: Modify onAccess function signature.
274         * html/canvas/WebGLRenderingContext.cpp:
275         (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter.
276         (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto.
277         (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
278         (WebCore::WebGLRenderingContext::drawArrays): Ditto.
279         (WebCore::WebGLRenderingContext::drawElements): Ditto.
280         (WebCore::WebGLRenderingContext::readPixels): Ditto.
281         (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
282
283 2010-11-17  Ryosuke Niwa  <rniwa@webkit.org>
284
285         Reviewed by Darin Adler.
286
287         Merge ScriptElement and ScriptElementData
288         https://bugs.webkit.org/show_bug.cgi?id=49647
289
290         Merged two classes.
291
292         * dom/AsyncScriptRunner.cpp:
293         (WebCore::AsyncScriptRunner::executeScriptSoon): Takes ScriptElement* instead of ScriptElementData*.
294         (WebCore::AsyncScriptRunner::timerFired): Uses ScriptElement* instead of ScriptElementData*.
295         * dom/AsyncScriptRunner.h:
296         * dom/ScriptElement.cpp:
297         (WebCore::ScriptElement::ScriptElement): Merged with ScriptElementData::ScriptElementData.
298         (WebCore::ScriptElement::~ScriptElement): Merged with ScriptElementData::~ScriptElementData.
299         (WebCore::ScriptElement::insertedIntoDocument): Calls createdByParser, isAsynchronous, requestScript, and scriptContent.
300         (WebCore::ScriptElement::removedFromDocument): Calls stopLoadRequest.
301         (WebCore::ScriptElement::childrenChanged): Calls createdByParser and accesses m_element.
302         (WebCore::ScriptElement::finishParsingChildren): Calls scriptContent.
303         (WebCore::ScriptElement::handleSourceAttribute): Calls ignoresLoadRequest and requestScript.
304         (WebCore::ScriptElement::requestScript): Moved from ScriptElementData; calls dispatchErrorEvent.
305         (WebCore::ScriptElement::evaluateScript): Moved from ScriptElementData.
306         (WebCore::ScriptElement::executeScript): Ditto.
307         (WebCore::ScriptElement::stopLoadRequest): Ditto.
308         (WebCore::ScriptElement::execute): Moved from ScriptElementData; calls dispatchErrorEvent and dispatchLoadEvent.
309         (WebCore::ScriptElement::notifyFinished): Moved from ScriptElementData.
310         (WebCore::ScriptElement::ignoresLoadRequest): Ditto.
311         (WebCore::ScriptElement::shouldExecuteAsJavaScript): Moved from ScriptElementData; calls typeAttributeValue, languageAttributeValue,
312         forAttributeValue, and eventAttributeValue.
313         (WebCore::ScriptElement::scriptCharset): Moved from ScriptElementData.
314         (WebCore::ScriptElement::scriptContent): Ditto.
315         (WebCore::ScriptElement::isAsynchronous): Moved from ScriptElementData; calls sourceAttributeValue and asyncAttributeValue.
316         (WebCore::ScriptElement::isDeferred): Moved from ScriptElementData; calls sourceAttributeValue, asyncAttributeValue,
317         and deferAttributeValue.
318         * dom/ScriptElement.h:
319         (WebCore::ScriptElement::element):
320         (WebCore::ScriptElement::haveFiredLoadEvent):
321         (WebCore::ScriptElement::setHaveFiredLoadEvent):
322         (WebCore::ScriptElement::createdByParser):
323         (WebCore::ScriptElement::isEvaluated):
324
325 2010-11-17  Tenghui Zhu  <ztenghui@google.com>
326
327         Reviewed by Jeremy Orlow.
328
329         profileCallback and profileEndCallback  should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
330         https://bugs.webkit.org/show_bug.cgi?id=49623
331
332         No new tests. Just a compiling error fix.
333
334         * bindings/v8/custom/V8ConsoleCustom.cpp:
335           Add the guard ENABLE_JAVA_SCRIPT_DEBUGGER to profileCallback and profileEndCallback
336
337 2010-11-17  John Knottenbelt  <jknotten@chromium.org>
338
339         Reviewed by Jeremy Orlow.
340
341         Introduce GeoNotifierVector typedef for increased readability
342         https://bugs.webkit.org/show_bug.cgi?id=49597
343
344         * page/Geolocation.cpp:
345         (WebCore::Geolocation::Watchers::getNotifiersVector):
346         (WebCore::Geolocation::sendError):
347         (WebCore::Geolocation::sendPosition):
348         (WebCore::Geolocation::stopTimer):
349         (WebCore::Geolocation::stopTimersForOneShots):
350         (WebCore::Geolocation::stopTimersForWatchers):
351         (WebCore::Geolocation::cancelRequests):
352         (WebCore::Geolocation::cancelAllRequests):
353         (WebCore::Geolocation::handleError):
354         (WebCore::Geolocation::makeSuccessCallbacks):
355         * page/Geolocation.h:
356
357 2010-11-17  John Knottenbelt  <jknotten@chromium.org>
358
359         Reviewed by Jeremy Orlow.
360
361         Convert correctly between GeolocationPosition and Geoposition
362         timestamp formats.
363         https://bugs.webkit.org/show_bug.cgi?id=48518
364
365         Test: fast/dom/Geolocation/timestamp.html
366
367         * page/Geolocation.cpp:
368         (WebCore::createGeoposition):
369
370 2010-11-17  Chang Shu  <chang.shu@nokia.com>
371
372         Reviewed by Antonio Gomes.
373
374         [Mac] Suppress single select popup menu when spatial navigation is enabled on Mac.
375         This makes spatial navigation work properly for single select box.
376
377         Test: fast/events/spatial-navigation/snav-single-select.html
378
379         * dom/SelectElement.cpp:
380         (WebCore::nextValidIndex):
381         (WebCore::SelectElement::menuListDefaultEventHandler):
382
383 2010-11-17  Satish Sampath  <satish@chromium.org>
384
385         Reviewed by Jeremy Orlow.
386
387         Clear the speech input mock explicitly before each test.
388         https://bugs.webkit.org/show_bug.cgi?id=49660
389
390         * platform/mock/SpeechInputClientMock.cpp:
391         (WebCore::SpeechInputClientMock::clearResults): Added clearResults method.
392         * platform/mock/SpeechInputClientMock.h:
393
394 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
395
396         [Chromium] Unreviewed, fix Chromium-Mac build from r72189.
397
398         * css/CSSPrimitiveValue.cpp:
399         (WebCore::CSSPrimitiveValue::getDoubleValue):
400
401 2010-11-17  Hans Wennborg  <hans@chromium.org>
402
403         Reviewed by Jeremy Orlow.
404
405         IndexedDB: IDBKey::whereSyntax should impose conditions on all columns
406         https://bugs.webkit.org/show_bug.cgi?id=49601
407
408         The WHERE clause should specifiy a condition for each key column to
409         make sure that the ObjectStoreData_composit index can be used when
410         querying the object store based on key. Not using the index causes
411         severe performance degradation for common IDB operations.
412
413         * storage/IDBKey.cpp:
414         (WebCore::IDBKey::whereSyntax):
415
416 2010-11-17  Eric Uhrhane  <ericu@chromium.org>
417
418         Reviewed by David Levin.
419
420         [Chromium] implementation of async FileWriter for workers
421         https://bugs.webkit.org/show_bug.cgi?id=47681
422
423         Tests are in a separate changelist.
424
425         * platform/CrossThreadCopier.h: Changed CrossThreadCopier[Base] to support PassRefPtrs
426
427 2010-11-17  Alejandro G. Castro  <alex@igalia.com>
428
429         Reviewed by Martin Robinson.
430
431         [gtk] r69119 modified just the gtk2 version of the
432         scrolled_window_paint function but not the gtk3 version
433         https://bugs.webkit.org/show_bug.cgi?id=49585
434
435         Use gtk_paint_shadow the same as the actual code from GTK+. Avoid
436         using state and use the same values we are using for gtk2 in the
437         paint function.
438
439         * platform/gtk/ScrollbarThemeGtk.cpp:
440         (WebCore::ScrollbarThemeGtk::paintButton): Initialized the
441         depressed attribute of the state variable to avoid using it
442         without initialization.
443         * platform/gtk/gtk3drawing.c:
444         (moz_gtk_scrolled_window_paint):
445
446 2010-11-16  Alexander Pavlov  <apavlov@chromium.org>
447
448         Reviewed by Simon Fraser.
449
450         CSSPrimitiveValue.getFloatValue does not convert sizes
451         https://bugs.webkit.org/show_bug.cgi?id=35770
452
453         Implemented all same-category unit conversions (length, angle, time, frequency) and retained
454         absolute-relative (cm, mm, in, pt, pc) length conversions intact.
455         Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.
456
457         * css/CSSPrimitiveValue.cpp:
458         (WebCore::unitCategory):
459         (WebCore::conversionToCanonicalUnitsScaleFactor):
460         (WebCore::CSSPrimitiveValue::getDoubleValue):
461         (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
462         (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
463         (WebCore::CSSPrimitiveValue::getIdent):
464         * css/CSSPrimitiveValue.h:
465         (WebCore::CSSPrimitiveValue::getFloatValue):
466         (WebCore::CSSPrimitiveValue::getIntValue):
467
468 2010-11-17  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
469
470         Reviewed by Andreas Kling.
471
472         Document::nodesFromRect() has wrong source code documentation
473         https://bugs.webkit.org/show_bug.cgi?id=49610
474
475         * dom/Document.h: fix nodesFromRect() documentation
476
477 2010-11-17  Alexis Menard  <alexis.menard@nokia.com>, Simon Hausmann  <simon.hausmann@nokia.com>
478
479         Reviewed by Kenneth Christiansen, Tor Arne Vestbø.
480
481         [Qt] Add support for use GStreamer with the Qt build
482
483         Make it possible to use gstreamer with the Qt build via the USE_GSTREAMER macro. The
484         integration is rather basic at this point, allowing for software based rendering
485         only at the moment. AC integration and fullscreen playback is still missing.
486
487         * WebCore.pro: Added a bunch of gstreamer files to the build and guard it as a
488         build option with the USE_GSTREAMER macro.
489         * platform/graphics/MediaPlayer.cpp:
490         (WebCore::installedMediaEngines): Don't use the generic media player registration
491         when using GStreamer. These #ifdefs should be removed, but the gstreamer folks want
492         to be able to build with gstreamer _and_ another backend simultaenously.
493         * platform/graphics/gstreamer/ImageGStreamer.h:
494         * platform/graphics/gstreamer/ImageGStreamerQt.cpp: Added.
495         (ImageGStreamer::createImage):
496         (ImageGStreamer::ImageGStreamer):
497         (ImageGStreamer::~ImageGStreamer):
498         * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Added.
499         * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: Added.
500         (FullScreenVideoWindow::FullScreenVideoWindow):
501         (FullScreenVideoWindow::keyPressEvent):
502         (FullScreenVideoWindow::event):
503         (PlatformVideoWindow::PlatformVideoWindow):
504         (PlatformVideoWindow::~PlatformVideoWindow):
505         (PlatformVideoWindow::prepareForOverlay):
506
507 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
508
509         Reviewed by Pavel Feldman.
510
511         Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
512         https://bugs.webkit.org/show_bug.cgi?id=49602
513
514         * inspector/InspectorStyleSheet.cpp:
515         (WebCore::InspectorStyle::setPropertyText):
516         * inspector/front-end/StylesSidebarPane.js:
517         (WebInspector.StylePropertyTreeElement.prototype.get name):
518         (WebInspector.StylePropertyTreeElement.prototype.get priority):
519         (WebInspector.StylePropertyTreeElement.prototype.get value):
520
521 2010-11-16  Adam Roben  <aroben@apple.com>
522
523         Move QTMovieWin's settings into a vsprops file
524
525         Fixes <http://webkit.org/b/49644> QTMovieWin should use a vsprops file
526
527         Reviewed by Steve Falkenburg.
528
529         * WebCore.vcproj/QTMovieWin.vcproj:
530         * WebCore.vcproj/QTMovieWinCommon.vsprops: Added.
531
532 2010-11-16  Andy Estes  <aestes@apple.com>
533
534         Reviewed by Dave Hyatt.
535
536         WebKit mishandles line boxes where the content height exceeds the
537         specified line-height.
538         https://bugs.webkit.org/show_bug.cgi?id=49410
539
540         If a line height is explicitly specified on a text box and fallback
541         fonts are in use, only the primary font should be considered when
542         computing the box's ascent and descent. This prevents the inline box
543         from being sized larger than the specified line height.
544
545         This patch also fixes a math error when computing a used font's descent
546         in the case where line height isn't explicitly set. This change results
547         in a number of layout tests needing re-baselining.
548
549         Test: fast/css/line-height-determined-by-primary-font.html
550
551         * rendering/InlineFlowBox.cpp:
552         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
553
554 2010-11-15  Ryosuke Niwa  <rniwa@webkit.org>
555
556         Reviewed by Darin Adler.
557
558         ScriptElementData should be a private member of ScriptElement
559         https://bugs.webkit.org/show_bug.cgi?id=49578
560
561         Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser,
562         and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData.
563
564         No tests are added since this is a cleanup.
565
566         * dom/ScriptElement.h:
567         (WebCore::ScriptElement::haveFiredLoadEvent): Added.
568         (WebCore::ScriptElement::setHaveFiredLoadEvent): Added.
569         (WebCore::ScriptElement::createdByParser): Added.
570         (WebCore::ScriptElement::isEvaluated): Added.
571         * html/HTMLScriptElement.cpp:
572         (WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent.
573         (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated.
574         * html/HTMLScriptElement.h:
575         (WebCore::HTMLScriptElement::text): Calls scriptContent.
576         (WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent.
577         * svg/SVGScriptElement.cpp:
578         (WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser.
579         (WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser.
580         (WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent.
581         (WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto.
582         (WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent.
583         (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser,
584         haveFiredLoadEvent, and setHaveFiredLoadEvent.
585
586 2010-11-16  Antti Koivisto  <antti@apple.com>
587
588         Reviewed by Darin Adler.
589
590         https://bugs.webkit.org/show_bug.cgi?id=49320
591         Minor ResourceLoadScheduler cleanups
592
593         * loader/ResourceLoadScheduler.cpp:
594         (WebCore::ResourceLoadScheduler::scheduleLoad):
595         (WebCore::ResourceLoadScheduler::servePendingRequests):
596         (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
597         (WebCore::ResourceLoadScheduler::HostInformation::remove):
598         (WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
599         * loader/ResourceLoadScheduler.h:
600
601 2010-11-16  Dave Hyatt  <hyatt@apple.com>
602
603         Reviewed by Sam Weinig.
604
605         Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that
606         line should be ideographic or alphabetic.  Add a requiresIdeographicsBaseline recursive function to
607         InlineFlowBox that scans for the use of any vertical fonts.
608
609         * rendering/InlineFlowBox.cpp:
610         (WebCore::InlineFlowBox::requiresIdeographicBaseline):
611         * rendering/InlineFlowBox.h:
612         * rendering/RootInlineBox.cpp:
613         (WebCore::RootInlineBox::RootInlineBox):
614         (WebCore::RootInlineBox::alignBoxesInBlockDirection):
615         * rendering/RootInlineBox.h:
616         (WebCore::RootInlineBox::baselineType):
617
618 2010-11-16  Dave Hyatt  <hyatt@apple.com>
619
620         Reviewed by Sam Weinig.
621
622         Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an
623         alphabetic and ideographic baseline can be requested.
624
625         * WebCore.xcodeproj/project.pbxproj:
626         * platform/graphics/Font.h:
627         (WebCore::Font::ascent):
628         (WebCore::Font::descent):
629         * platform/graphics/FontBaseline.h: Added.
630         * platform/graphics/SimpleFontData.h:
631         (WebCore::SimpleFontData::ascent):
632         (WebCore::SimpleFontData::descent):
633         (WebCore::SimpleFontData::height):
634
635 2010-11-16  Antti Koivisto  <koivisto@iki.fi>
636
637         Reviewed by Adam Barth.
638
639         https://bugs.webkit.org/show_bug.cgi?id=31223
640         Make primitive values immutable.
641         
642         Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception.
643     
644         Reasoning:
645         - these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering
646         - computed style is immutable in all cases, and it wasn't
647         - no other engine seems to support mutable primitives, as a result there is no content using these APIs
648         - mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value
649         - allowing mutation of primitive values makes optimizations harder
650
651         * css/CSSPrimitiveValue.cpp:
652         (WebCore::CSSPrimitiveValue::setFloatValue):
653         (WebCore::CSSPrimitiveValue::setStringValue):
654
655 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
656
657         Reviewed by Adam Roben.
658
659         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
660         https://bugs.webkit.org/show_bug.cgi?id=49632
661
662         * WebCore.vcproj/QTMovieWin.vcproj:
663         * WebCore.vcproj/WebCore.make:
664         * WebCore.vcproj/WebCore.sln:
665         * WebCore.vcproj/WebCore.vcproj:
666
667 2010-11-16  Anders Carlsson  <andersca@apple.com>
668
669         Reviewed by John Sullivan.
670
671         Set the original URL for downloads
672         https://bugs.webkit.org/show_bug.cgi?id=49628
673
674         Export symbols needed by WebKit2.
675
676         * WebCore.exp.in:
677
678 2010-11-16  Dave Hyatt  <hyatt@apple.com>
679
680         Reviewed by Dan Bernstein.
681
682         https://bugs.webkit.org/show_bug.cgi?id=11004
683         
684         font-size:0 is ignored.  Remove the minimum font size of 1 in CSSStyleSelector.
685         Change the pref value for minimum font size from 1 to 0.  Make sure to never use the NSFont's size,
686         since it doesn't honor a size of 0.  Instead pass the size in to the FontPlatformData(NSFont*) version
687         of the constructor rather than using [NSFont pointSize].
688
689         https://bugs.webkit.org/show_bug.cgi?id=49582
690         
691         Negative leading is not handled correctly.  There are two bugs here.  The first is that
692         maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
693         set them before so that we can allow them to be < 0.
694         
695         The second issue is that we should understand where fonts will end up relative to
696         our baseline (excluding line height), and only allow those boxes to impact ascent and
697         descent if the actual font box (without factoring in line height) is above or below the
698         root line box baseline.
699
700         Added fast/css/negative-leading.html
701         
702         These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
703
704         * WebCore.exp.in:
705         * css/CSSStyleSelector.cpp:
706         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
707         * platform/graphics/cocoa/FontPlatformData.h:
708         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
709         (WebCore::FontPlatformData::FontPlatformData):
710         * platform/graphics/mac/FontCacheMac.mm:
711         (WebCore::FontCache::getFontDataForCharacters):
712         (WebCore::FontCache::createFontPlatformData):
713         * platform/graphics/mac/SimpleFontDataMac.mm:
714         (WebCore::SimpleFontData::smallCapsFontData):
715         * rendering/InlineFlowBox.cpp:
716         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
717         * rendering/InlineFlowBox.h:
718         * rendering/RootInlineBox.cpp:
719         (WebCore::RootInlineBox::alignBoxesInBlockDirection):
720
721 2010-11-16  Darin Adler  <darin@apple.com>
722
723         https://bugs.webkit.org/show_bug.cgi?id=49611
724         REGRESSION (r72115): 5 layout tests are broken
725
726         * loader/FrameLoader.cpp:
727         (WebCore::FrameLoader::loadFrameRequest): Roll change from
728         https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll
729         it back in after fixing the failing tests.
730
731 2010-11-16  Dan Bernstein  <mitz@apple.com>
732
733         Reviewed by Simon Fraser.
734
735         <rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
736         https://bugs.webkit.org/show_bug.cgi?id=49579
737
738         r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged()
739         got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s
740         childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not.
741         Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix
742         is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and
743         just keep it for when it is needed.
744
745         Tests: fast/block/float/015.html
746                fast/images/style-access-during-imageChanged-style-freeze.html
747
748         * dom/Document.cpp:
749         (WebCore::Document::isPendingStyleRecalc): Added.
750         * dom/Document.h:
751         * rendering/RenderImage.cpp:
752         (WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc
753         is coming (indicating that current style() is stale).
754
755 2010-11-11  Zhenyao Mo  <zmo@google.com>
756
757         Reviewed by Kenneth Russell.
758
759         Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
760         https://bugs.webkit.org/show_bug.cgi?id=47196
761
762         * html/canvas/WebGLRenderingContext.cpp:
763         (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading.
764         (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
765         * platform/graphics/GraphicsContext3D.cpp:
766         (WebCore::GraphicsContext3D::extractImageData): Ditto.
767         * platform/graphics/GraphicsContext3D.h:
768         * platform/graphics/ImageSource.cpp:
769         (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter.
770         (WebCore::ImageSource::setData): Ditto.
771         * platform/graphics/ImageSource.h:
772         * platform/graphics/cg/GraphicsContext3DCG.cpp:
773         (WebCore::GraphicsContext3D::getImageData): Ditto.
774         * platform/graphics/cg/ImageSourceCG.cpp:
775         (WebCore::ImageSource::ImageSource): Ditto.
776         * platform/graphics/qt/GraphicsContext3DQt.cpp:
777         (WebCore::GraphicsContext3D::getImageData): Ditto.
778         * platform/graphics/qt/ImageDecoderQt.cpp:
779         (WebCore::ImageDecoder::create): Ditto.
780         (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
781         * platform/graphics/qt/ImageDecoderQt.h:
782         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
783         (WebCore::GraphicsContext3D::getImageData): Ditto.
784         * platform/image-decoders/ImageDecoder.cpp:
785         (WebCore::ImageDecoder::create): Ditto.
786         * platform/image-decoders/ImageDecoder.h:
787         (WebCore::ImageDecoder::ImageDecoder): Ditto.
788         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
789         (WebCore::BMPImageDecoder::BMPImageDecoder):
790         * platform/image-decoders/bmp/BMPImageDecoder.h:
791         * platform/image-decoders/gif/GIFImageDecoder.cpp:
792         (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
793         * platform/image-decoders/gif/GIFImageDecoder.h:
794         * platform/image-decoders/ico/ICOImageDecoder.cpp:
795         (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto.
796         (WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
797         * platform/image-decoders/ico/ICOImageDecoder.h:
798         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
799         (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
800         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
801         * platform/image-decoders/png/PNGImageDecoder.cpp:
802         (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto.
803         (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
804         * platform/image-decoders/png/PNGImageDecoder.h:
805         * platform/image-decoders/webp/WEBPImageDecoder.cpp:
806         (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
807         * platform/image-decoders/webp/WEBPImageDecoder.h:
808
809 2010-11-16  Eric Carlson  <eric.carlson@apple.com>
810
811         Unreviewed attempt to fix GTK build after http://trac.webkit.org/changeset/72117
812
813         * platform/graphics/MediaPlayer.cpp:
814         (WebCore::installedMediaEngines):
815
816 2010-11-12  Zhenyao Mo  <zmo@google.com>
817
818         Reviewed by Kenneth Russell.
819
820         Refactor GL backend flags
821         https://bugs.webkit.org/show_bug.cgi?id=49460
822
823         * html/canvas/WebGLRenderingContext.cpp:
824         (WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags().
825         (WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags().
826         (WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags.
827         (WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member.
828         (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
829         * html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation.
830         (WebCore::WebGLRenderingContext::isGLES2Compliant):
831         (WebCore::WebGLRenderingContext::isGLES2NPOTStrict):
832         (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses):
833         (WebCore::WebGLRenderingContext::isResourceSafe):
834         (WebCore::WebGLRenderingContext::isDepthStencilSupported):
835         * platform/graphics/Extensions3D.h: Add NPOT extension.
836         * platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level.
837         * platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions.
838         * platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level.
839
840 2010-11-16  Kenneth Russell  <kbr@google.com>
841
842         Reviewed by Dimitri Glazkov.
843
844         WebIDL conversions from string to number and array to number should not generate TypeError
845         https://bugs.webkit.org/show_bug.cgi?id=49218
846
847         Recent SVG-related changes to the StrictTypeChecking extended attribute in
848         CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and
849         ECMA-262 specifications. In particular, when an attribute or function argument is specified
850         as a number type (floating-point or integer), passing in a String or object is not supposed
851         to raise an exception.
852
853         The original intent of the StrictTypeChecking extended attribute was to properly raise
854         TypeError when an interface type is required, but the supplied object does not implement the
855         interface type (http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has
856         silently passed null to the C++ bindings in this case. The handling of strings in the
857         original StrictTypeChecking implementation was also incorrect, raising exceptions when it
858         should not.
859
860         The semantics of StrictTypeChecking have been changed to enforce only the restrictions on
861         interface types. The V8 custom bindings for WebGL have been updated to match the behavior of
862         the autogenerated code.
863
864         Test: fast/canvas/webgl/type-conversion-test.html
865
866         * bindings/scripts/CodeGeneratorJS.pm:
867         * bindings/scripts/CodeGeneratorV8.pm:
868         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
869         (WebCore::getObjectParameter):
870         (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
871         (WebCore::V8WebGLRenderingContext::getParameterCallback):
872         (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
873         (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
874         (WebCore::vertexAttribAndUniformHelperf):
875
876 2010-11-16  Alexey Proskuryakov  <ap@apple.com>
877
878         Windows build fix.
879
880         * DerivedSources.cpp: Removing CSS Variables generated files.
881
882 2010-11-16  Eric Carlson  <eric.carlson@apple.com>
883
884         Reviewed by John Sullivan.
885
886         getMIMEType(s)ForExtension should consult system mapping
887         https://bugs.webkit.org/show_bug.cgi?id=49497
888
889         No new tests possible.
890
891         * platform/MIMETypeRegistry.cpp:
892         (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension. 
893         Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling
894         constains() and then get().
895         (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto.
896
897 2010-11-16  Eric Carlson  <eric.carlson@apple.com>
898
899         Reviewed by Darin Adler.
900
901         Rename QTKit based media engine class name
902         https://bugs.webkit.org/show_bug.cgi?id=36663
903
904         No new tests as this just renames a class and restructures existing code.
905
906         * platform/graphics/MediaPlayer.cpp:
907         (WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the
908         number of #ifs in the code.
909
910         * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit.
911         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
912         (WebCore::MediaPlayerPrivateQTKit::create):
913         (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
914         (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
915         (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
916         (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
917         (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
918         (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
919         (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
920         (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
921         (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
922         (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
923         (WebCore::MediaPlayerPrivateQTKit::currentRenderingMode):
924         (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
925         (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
926         (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
927         (WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering):
928         (WebCore::MediaPlayerPrivateQTKit::createQTTime):
929         (WebCore::MediaPlayerPrivateQTKit::resumeLoad):
930         (WebCore::MediaPlayerPrivateQTKit::load):
931         (WebCore::MediaPlayerPrivateQTKit::loadInternal):
932         (WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
933         (WebCore::MediaPlayerPrivateQTKit::platformMedia):
934         (WebCore::MediaPlayerPrivateQTKit::platformLayer):
935         (WebCore::MediaPlayerPrivateQTKit::play):
936         (WebCore::MediaPlayerPrivateQTKit::pause):
937         (WebCore::MediaPlayerPrivateQTKit::duration):
938         (WebCore::MediaPlayerPrivateQTKit::currentTime):
939         (WebCore::MediaPlayerPrivateQTKit::seek):
940         (WebCore::MediaPlayerPrivateQTKit::doSeek):
941         (WebCore::MediaPlayerPrivateQTKit::cancelSeek):
942         (WebCore::MediaPlayerPrivateQTKit::seekTimerFired):
943         (WebCore::MediaPlayerPrivateQTKit::paused):
944         (WebCore::MediaPlayerPrivateQTKit::seeking):
945         (WebCore::MediaPlayerPrivateQTKit::naturalSize):
946         (WebCore::MediaPlayerPrivateQTKit::hasVideo):
947         (WebCore::MediaPlayerPrivateQTKit::hasAudio):
948         (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
949         (WebCore::MediaPlayerPrivateQTKit::setVolume):
950         (WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions):
951         (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
952         (WebCore::MediaPlayerPrivateQTKit::setRate):
953         (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
954         (WebCore::MediaPlayerPrivateQTKit::buffered):
955         (WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):
956         (WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded):
957         (WebCore::MediaPlayerPrivateQTKit::bytesLoaded):
958         (WebCore::MediaPlayerPrivateQTKit::totalBytes):
959         (WebCore::MediaPlayerPrivateQTKit::cancelLoad):
960         (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
961         (WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup):
962         (WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
963         (WebCore::MediaPlayerPrivateQTKit::updateStates):
964         (WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
965         (WebCore::MediaPlayerPrivateQTKit::rateChanged):
966         (WebCore::MediaPlayerPrivateQTKit::sizeChanged):
967         (WebCore::MediaPlayerPrivateQTKit::timeChanged):
968         (WebCore::MediaPlayerPrivateQTKit::didEnd):
969         (WebCore::MediaPlayerPrivateQTKit::setSize):
970         (WebCore::MediaPlayerPrivateQTKit::setVisible):
971         (WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame):
972         (WebCore::MediaPlayerPrivateQTKit::repaint):
973         (WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext):
974         (WebCore::MediaPlayerPrivateQTKit::paint):
975         (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes):
976         (WebCore::MediaPlayerPrivateQTKit::supportsType):
977         (WebCore::MediaPlayerPrivateQTKit::isAvailable):
978         (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):
979         (WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks):
980         (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
981         (WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged):
982         (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin):
983         (WebCore::MediaPlayerPrivateQTKit::movieLoadType):
984         (WebCore::MediaPlayerPrivateQTKit::setPreload):
985         (WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue):
986         (-[WebCoreMovieObserver initWithCallback:]):
987
988 2010-11-16  Alexey Proskuryakov  <ap@apple.com>
989
990         Reviewed by Dave Hyatt.
991
992         https://bugs.webkit.org/show_bug.cgi?id=49483
993         Remove CSS Variable support
994
995         * Android.derived.jscbindings.mk:
996         * Android.derived.v8bindings.mk:
997         * Android.mk:
998         * CMakeLists.txt:
999         * DerivedSources.make:
1000         * GNUmakefile.am:
1001         * WebCore.gypi:
1002         * WebCore.pri:
1003         * WebCore.pro:
1004         * WebCore.vcproj/WebCore.vcproj:
1005         * WebCore.xcodeproj/project.pbxproj:
1006         * bindings/js/JSCSSRuleCustom.cpp:
1007         (WebCore::toJS):
1008         * bindings/v8/custom/V8DOMWindowCustom.cpp
1009         * bindings/objc/DOMCSS.mm:
1010         (kitClass):
1011         * bindings/scripts/CodeGeneratorJS.pm:
1012         * css/CSSComputedStyleDeclaration.cpp:
1013         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1014         * css/CSSGrammar.y:
1015         * css/CSSMutableStyleDeclaration.cpp:
1016         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
1017         (WebCore::CSSMutableStyleDeclaration::removeProperty):
1018         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
1019         (WebCore::CSSMutableStyleDeclaration::copy):
1020         * css/CSSMutableStyleDeclaration.h:
1021         (WebCore::CSSMutableStyleDeclaration::create):
1022         * css/CSSParser.cpp:
1023         (WebCore::CSSParser::CSSParser):
1024         (WebCore::CSSParser::~CSSParser):
1025         (WebCore::CSSParser::parseValue):
1026         (WebCore::CSSParser::lex):
1027         (WebCore::CSSParser::recheckAtKeyword):
1028         (WebCore::CSSParser::text):
1029         (WebCore::CSSParser::createMediaRule):
1030         (WebCore::CSSParser::createKeyframesRule):
1031         (WebCore::CSSParser::createStyleRule):
1032         (WebCore::CSSParser::createFontFaceRule):
1033         (WebCore::CSSParser::addNamespace):
1034         (WebCore::CSSParser::createPageRule):
1035         * css/CSSParser.h:
1036         * css/CSSParserValues.cpp:
1037         (WebCore::CSSParserValueList::addValue):
1038         (WebCore::CSSParserValueList::deleteValueAt):
1039         (WebCore::CSSParserValue::createCSSValue):
1040         * css/CSSParserValues.h:
1041         (WebCore::CSSParserValueList::CSSParserValueList):
1042         * css/CSSPrimitiveValue.cpp:
1043         (WebCore::CSSPrimitiveValue::cleanup):
1044         (WebCore::CSSPrimitiveValue::getStringValue):
1045         (WebCore::CSSPrimitiveValue::cssText):
1046         (WebCore::CSSPrimitiveValue::parserValue):
1047         * css/CSSPrimitiveValue.h:
1048         * css/CSSProperty.cpp:
1049         (WebCore::CSSProperty::cssText):
1050         * css/CSSPropertyNames.in:
1051         * css/CSSRule.h:
1052         * css/CSSRule.idl:
1053         * css/CSSStyleDeclaration.cpp:
1054         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
1055         * css/CSSStyleSelector.cpp:
1056         (WebCore::CSSStyleSelector::addMatchedDeclaration):
1057         (WebCore::CSSRuleSet::addRulesFromSheet):
1058         (WebCore::CSSStyleSelector::applyProperty):
1059         * css/CSSStyleSelector.h:
1060         * css/CSSValue.h:
1061         * css/CSSVariableDependentValue.cpp: Removed.
1062         * css/CSSVariableDependentValue.h: Removed.
1063         * css/CSSVariablesDeclaration.cpp: Removed.
1064         * css/CSSVariablesDeclaration.h: Removed.
1065         * css/CSSVariablesDeclaration.idl: Removed.
1066         * css/CSSVariablesRule.cpp: Removed.
1067         * css/CSSVariablesRule.h: Removed.
1068         * css/CSSVariablesRule.idl: Removed.
1069         * css/StyleBase.h:
1070         (WebCore::StyleBase::isMediaRule):
1071         * css/tokenizer.flex:
1072         * page/DOMWindow.idl:
1073
1074 2010-11-16  Darin Adler  <darin@apple.com>
1075
1076         Reviewed by Sam Weinig.
1077
1078         https://bugs.webkit.org/show_bug.cgi?id=48603
1079         Boolean logic mistake in local file check
1080
1081         * loader/FrameLoader.cpp:
1082         (WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass
1083         before accepting a local file load.
1084
1085 2010-11-15  Darin Adler  <darin@apple.com>
1086
1087         Reviewed by Sam Weinig.
1088
1089         Harden additional string functions against large lengths
1090         https://bugs.webkit.org/show_bug.cgi?id=49574
1091
1092         * platform/text/TextCodecUTF16.cpp:
1093         (WebCore::TextCodecUTF16::encode): Check for length that is
1094         too large for size_t.
1095
1096         * platform/text/TextStream.cpp:
1097         (WebCore::TextStream::operator<<): Check for length that is
1098         too large for size_t.
1099
1100 2010-11-16  Pavel Feldman  <pfeldman@chromium.org>
1101
1102         Not reviewed. Touching inspector controller to make gtk / qt happier.
1103
1104         * inspector/InspectorController.cpp:
1105
1106 2010-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1107
1108         Reviewed by Martin Robinson.
1109
1110         [GTK] Use gdk_pixbuf_get_from_surface() when available
1111         https://bugs.webkit.org/show_bug.cgi?id=49532
1112
1113         * platform/graphics/gtk/GdkCairoUtilities.cpp:
1114         (cairoImageSurfaceToGdkPixbuf):
1115
1116 2010-11-16  Pavel Feldman  <pfeldman@chromium.org>
1117
1118         Reviewed by Yury Semikhatsky.
1119
1120         Web Inspector: init front-end UI upon DOMContentLoaded, not load event.
1121         https://bugs.webkit.org/show_bug.cgi?id=49596
1122
1123         * inspector/front-end/inspector.js:
1124         (windowLoaded):
1125
1126 2010-11-15  Alexander Pavlov  <apavlov@chromium.org>
1127
1128         Reviewed by Pavel Feldman.
1129
1130         Web Inspector: Migrate frontend to the new CSS editing/retrieval API
1131         https://bugs.webkit.org/show_bug.cgi?id=49492
1132
1133         Test: inspector/styles-new-API.html
1134
1135         * inspector/front-end/AuditRules.js:
1136         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
1137         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine):
1138         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
1139         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
1140         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
1141         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
1142         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
1143         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
1144         * inspector/front-end/CSSStyleModel.js:
1145         (WebInspector.CSSStyleModel.prototype.getStylesAsync):
1146         (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
1147         (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync):
1148         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
1149         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
1150         (WebInspector.CSSStyleModel.prototype.addRule):
1151         (WebInspector.CSSStyleModel.prototype.addRule.callback):
1152         (WebInspector.CSSStyleDeclaration):
1153         (WebInspector.CSSStyleDeclaration.prototype.propertyAt):
1154         (WebInspector.CSSStyleDeclaration.prototype.pastLastSourcePropertyIndex):
1155         (WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
1156         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
1157         (WebInspector.CSSStyleDeclaration.prototype.appendProperty):
1158         (WebInspector.CSSRule):
1159         (WebInspector.CSSProperty.prototype.get propertyText):
1160         (WebInspector.CSSProperty.prototype.setText):
1161         (WebInspector.CSSProperty.prototype.setDisabled):
1162         (WebInspector.CSSStyleSheet):
1163         (WebInspector.CSSStyleSheet.createForId):
1164         (WebInspector.CSSStyleSheet.prototype.getText):
1165         (WebInspector.CSSStyleSheet.prototype.setText):
1166         * inspector/front-end/Settings.js:
1167         * inspector/front-end/StylesSidebarPane.js:
1168         (WebInspector.StylePropertiesSection.prototype.onpopulate):
1169         (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
1170         (WebInspector.StylePropertiesSection.prototype._debugShowStyle.removeStyleBox):
1171         (WebInspector.StylePropertiesSection.prototype._debugShowStyle):
1172         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
1173         (WebInspector.StylePropertyTreeElement.prototype):
1174         (WebInspector.StylePropertyTreeElement.prototype.):
1175         * inspector/front-end/inspector.css:
1176         (.styles-section .properties li.not-parsed-ok):
1177         (.styles-section .properties li.not-parsed-ok::before):
1178         (.styles-section .properties .inactive):
1179
1180 2010-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1181
1182         Unreviewed, rolling out r72082.
1183         http://trac.webkit.org/changeset/72082
1184         https://bugs.webkit.org/show_bug.cgi?id=49594
1185
1186         "broken SnowLeopard build" (Requested by apavlov on #webkit).
1187
1188         * css/CSSPrimitiveValue.cpp:
1189         (WebCore::scaleFactorForConversion):
1190         (WebCore::CSSPrimitiveValue::getDoubleValue):
1191         (WebCore::CSSPrimitiveValue::getIdent):
1192         * css/CSSPrimitiveValue.h:
1193         (WebCore::CSSPrimitiveValue::getFloatValue):
1194         (WebCore::CSSPrimitiveValue::getIntValue):
1195
1196 2010-11-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1197
1198         Unreviewed, rolling out r72087.
1199         http://trac.webkit.org/changeset/72087
1200         https://bugs.webkit.org/show_bug.cgi?id=49593
1201
1202         "broken build" (Requested by apavlov on #webkit).
1203
1204         * css/CSSPrimitiveValue.cpp:
1205         (WebCore::unitCategory):
1206
1207 2010-11-15  Pavel Feldman  <pfeldman@chromium.org>
1208
1209         Reviewed by Yury Semikhatsky.
1210
1211         Web Inspector: rename StoragePanel to ResourcesPanel.
1212         https://bugs.webkit.org/show_bug.cgi?id=49534
1213
1214         * WebCore.gypi:
1215         * WebCore.vcproj/WebCore.vcproj:
1216         * inspector/front-end/DatabaseQueryView.js:
1217         (WebInspector.DatabaseQueryView.prototype._queryFinished):
1218         * inspector/front-end/DatabaseTableView.js:
1219         (WebInspector.DatabaseTableView.prototype._queryFinished):
1220         * inspector/front-end/ExtensionServer.js:
1221         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
1222         * inspector/front-end/Images/storageIcon.png: Removed.
1223         * inspector/front-end/ResourceManager.js:
1224         (WebInspector.ResourceManager.prototype.setOverrideContent):
1225         (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
1226         (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
1227         (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
1228         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1229         (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
1230         * inspector/front-end/StoragePanel.js: Removed.
1231         * inspector/front-end/WebKit.qrc:
1232         * inspector/front-end/inspector.css:
1233         (.resources.panel .sidebar):
1234         (.resources.panel .sidebar li):
1235         (.resources.panel .sidebar li.parent):
1236         (.resources.panel .sidebar li.selected):
1237         (.resources.panel .sidebar li.selected .selection):
1238         (.resources.panel .sidebar :focus li.selected .selection):
1239         (body.inactive .resources.panel .sidebar li.selected .selection):
1240         (.resources.panel .sidebar .icon):
1241         (.resources.panel .base-storage-tree-element-title):
1242         (.resources.panel .status):
1243         (.resources.panel li .status .bubble):
1244         * inspector/front-end/inspector.html:
1245         * inspector/front-end/inspector.js:
1246         (WebInspector._createPanels):
1247         (WebInspector.openResource):
1248         (WebInspector.showPanel):
1249         (WebInspector.selectDatabase):
1250         (WebInspector.selectDOMStorage):
1251         (WebInspector.addDatabase):
1252         (WebInspector.addDOMStorage):
1253         (WebInspector.updateDOMStorage):
1254         (WebInspector.updateApplicationCacheStatus):
1255         (WebInspector.didGetFileSystemPath):
1256         (WebInspector.didGetFileSystemError):
1257         (WebInspector.didGetFileSystemDisabled):
1258         (WebInspector.updateNetworkState):
1259         (WebInspector._choosePanelToShowSourceLine):
1260
1261 2010-11-16  Alexander Pavlov  <apavlov@chromium.org>
1262
1263         Unreviewed SnowLeopard build fix.
1264
1265         * css/CSSPrimitiveValue.cpp:
1266         (WebCore::unitCategory):
1267
1268 2010-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1269
1270         Reviewed by Andreas Kling.
1271
1272         Viewport meta tag: Fix geometry computation
1273
1274         Available width and height should also be divided by the device pixel ratio.
1275
1276         * dom/ViewportArguments.cpp:
1277         (WebCore::computeViewportAttributes):
1278         * platform/network/qt/DnsPrefetchHelper.cpp:
1279
1280 2010-11-12  Alexander Pavlov  <apavlov@chromium.org>
1281
1282         Reviewed by Simon Fraser.
1283
1284         CSSPrimitiveValue.getFloatValue does not convert sizes
1285         https://bugs.webkit.org/show_bug.cgi?id=35770
1286
1287         Implemented all same-category unit conversions (length, angle, time, frequency) and retained
1288         absolute-relative (cm, mm, in, pt, pc) length conversions intact.
1289         Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.
1290
1291         * css/CSSPrimitiveValue.cpp:
1292         (WebCore::unitCategory):
1293         (WebCore::scaleFactorForConversion):
1294         (WebCore::CSSPrimitiveValue::getDoubleValue):
1295         (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
1296         (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
1297         * css/CSSPrimitiveValue.h:
1298
1299 2010-11-15  Pavel Feldman  <pfeldman@chromium.org>
1300
1301         Reviewed by Yury Semikhatsky.
1302
1303         Web Inspector: extract HTML title setter in treeoutline.js.
1304         https://bugs.webkit.org/show_bug.cgi?id=49540
1305
1306         * inspector/front-end/ElementsTreeOutline.js:
1307         (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
1308         (WebInspector.ElementsTreeElement.prototype.updateTitle):
1309         * inspector/front-end/treeoutline.js:
1310         (TreeElement.prototype.get titleHTML):
1311         (TreeElement.prototype.set titleHTML):
1312         (TreeElement.prototype._setListItemNodeContent):
1313
1314 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
1315
1316         Reviewed by Jeremy Orlow.
1317
1318         Assert that DeviceOrientationClientMock is used by only one controller.
1319         https://bugs.webkit.org/show_bug.cgi?id=48506
1320
1321         This is a design constraint of the DeviceOrientationClientMock because the
1322         m_controller field can only store a pointer to a single instance of the
1323         corresponding DeviceOrientationController.
1324
1325         * platform/mock/DeviceOrientationClientMock.cpp:
1326         (WebCore::DeviceOrientationClientMock::setController):
1327
1328 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1329
1330         Reviewed by Adam Barth.
1331
1332         fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
1333         https://bugs.webkit.org/show_bug.cgi?id=48634
1334         
1335         Specify the capacity when calling CFDataCreateMutable, which can signal
1336         malloc failures (by returning NULL), unlike CFDataSetLength.
1337
1338         * platform/image-decoders/cg/ImageDecoderCG.cpp:
1339         (WebCore::RGBA32Buffer::setSize):
1340
1341 2010-11-15  Rob Buis  <rwlbuis@gmail.com>
1342
1343         Reviewed by Dirk Schulze and Darin Adler.
1344
1345         requiredFeatures does not adapt to SVGStringList changes
1346         https://bugs.webkit.org/show_bug.cgi?id=40887
1347
1348         Centralize the const_cast handling and only do it if needed.
1349         Remove the const_cast in all svgAttributeChanged functions and move
1350         it to SVGTest::handleAttributeChange. Add an early return to
1351         handleAttributeChange to avoid unnecessary const_casts.
1352
1353         No tests necessary as functionality has not changed.
1354
1355         * svg/SVGCircleElement.cpp:
1356         (WebCore::SVGCircleElement::svgAttributeChanged):
1357         * svg/SVGEllipseElement.cpp:
1358         (WebCore::SVGEllipseElement::svgAttributeChanged):
1359         * svg/SVGForeignObjectElement.cpp:
1360         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
1361         * svg/SVGGElement.cpp:
1362         (WebCore::SVGGElement::svgAttributeChanged):
1363         * svg/SVGImageElement.cpp:
1364         (WebCore::SVGImageElement::svgAttributeChanged):
1365         * svg/SVGLineElement.cpp:
1366         (WebCore::SVGLineElement::svgAttributeChanged):
1367         * svg/SVGPathElement.cpp:
1368         (WebCore::SVGPathElement::svgAttributeChanged):
1369         * svg/SVGPolyElement.cpp:
1370         (WebCore::SVGPolyElement::svgAttributeChanged):
1371         * svg/SVGRectElement.cpp:
1372         (WebCore::SVGRectElement::svgAttributeChanged):
1373         * svg/SVGSVGElement.cpp:
1374         (WebCore::SVGSVGElement::svgAttributeChanged):
1375         * svg/SVGTests.cpp:
1376         (WebCore::SVGTests::handleAttributeChange):
1377         * svg/SVGTests.h:
1378         * svg/SVGTextContentElement.cpp:
1379         (WebCore::SVGTextContentElement::svgAttributeChanged):
1380         * svg/SVGUseElement.cpp:
1381         (WebCore::SVGUseElement::svgAttributeChanged):
1382
1383 2010-11-15  Dimitri Glazkov  <dglazkov@chromium.org>
1384
1385         Reviewed by Darin Adler.
1386
1387         REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
1388         https://bugs.webkit.org/show_bug.cgi?id=49569
1389
1390         Test: fast/events/remove-shadow-host-crash.html
1391
1392         * rendering/TextControlInnerElements.h:
1393         (WebCore::TextControlInnerElement::isShadowNode):
1394         (WebCore::TextControlInnerElement::shadowParentNode):
1395
1396 2010-11-12  Ryosuke Niwa  <rniwa@webkit.org>
1397
1398         Reviewed by Darin Adler.
1399
1400         ScriptElement rather than HTMLScriptElement and SVGScriptElement should have ScriptElementData
1401         https://bugs.webkit.org/show_bug.cgi?id=49469
1402
1403         Moved m_data, scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript from
1404         HTMLScriptElement and SVGScriptElement to ScriptElementData.
1405
1406         Also made insertedIntoDocument, removedFromDocument, childrenChanged, finishParsingChildren,
1407         and handleSourceAttribute of ScriptElement non-static.
1408
1409         No new tests are added since this is a cleanup.
1410
1411         * dom/ScriptElement.cpp:
1412         (WebCore::ScriptElement::scriptCharset): Added.
1413         (WebCore::ScriptElement::scriptContent): Added.
1414         (WebCore::ScriptElement::shouldExecuteAsJavaScript): Added.
1415         (WebCore::ScriptElement::executeScript): Added.
1416         (WebCore::ScriptElement::insertedIntoDocument): Made non-static. Accesses m_data.
1417         (WebCore::ScriptElement::removedFromDocument): Ditto.
1418         (WebCore::ScriptElement::childrenChanged): Ditto.
1419         (WebCore::ScriptElement::finishParsingChildren): Ditto.
1420         (WebCore::ScriptElement::handleSourceAttribute): Ditto.
1421         * dom/ScriptElement.h: Moved the declaration of ScriptElement after that of ScriptElementData
1422         because ScriptElement has to instantiate ScriptElementData.
1423         (WebCore::ScriptElement::ScriptElement): Initializes m_data.
1424         * html/HTMLScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript.
1425         (WebCore::HTMLScriptElement::HTMLScriptElement): Initializes ScriptElement instead of ScriptElementData.
1426         (WebCore::HTMLScriptElement::childrenChanged): Calls ScriptElement::childrenChanged.
1427         (WebCore::HTMLScriptElement::parseMappedAttribute): Calls ScriptElement::handleSourceAttribute.
1428         (WebCore::HTMLScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
1429         (WebCore::HTMLScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument.
1430         (WebCore::HTMLScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
1431         * html/HTMLScriptElement.h:
1432         * svg/SVGScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript.
1433         (WebCore::SVGScriptElement::SVGScriptElement): Initializes ScriptElement instead of ScriptElementData.
1434         (WebCore::SVGScriptElement::svgAttributeChanged): Calls ScriptElement::handleSourceAttribute.
1435         (WebCore::SVGScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument.
1436         (WebCore::SVGScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
1437         (WebCore::SVGScriptElement::childrenChanged): Calls ScriptElement::childrenChanged.
1438         (WebCore::SVGScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
1439         * svg/SVGScriptElement.h:
1440
1441 2010-11-15  Kent Tamura  <tkent@chromium.org>
1442
1443         Reviewed by Darin Adler.
1444
1445         Refactor HTMLInputElement: Move a part of HTMLInputElement::
1446         defaultEventHandler() to InputTypes.
1447         https://bugs.webkit.org/show_bug.cgi?id=48317
1448
1449         Move out the followings to InputTypes:
1450          - click event processing,
1451          - the first keydown event processing, and
1452          - DOMActivate event processing.
1453
1454         Move m_xPos and m_yPos from HTMLInputElement to ImageInputType as
1455         m_clickLocation. It's ok to move them because they should be valid only
1456         when HTMLInputElement::m_activeSubmit is true. For type=image,
1457         m_activeSubmit is true only in DOMActivate event handling. So we reset
1458         m_clickLocation in handleDOMActivateEvent() with Event::underlyingEvent().
1459
1460         No new tests because this is just a refactoring.
1461
1462         * html/BaseDateAndTimeInputType.cpp:
1463         (WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
1464         * html/BaseDateAndTimeInputType.h:
1465         * html/FileInputType.cpp:
1466         (WebCore::FileInputType::handleDOMActivateEvent):
1467         * html/FileInputType.h:
1468         * html/HTMLInputElement.cpp:
1469         (WebCore::HTMLInputElement::HTMLInputElement):
1470         (WebCore::HTMLInputElement::defaultEventHandler):
1471         * html/HTMLInputElement.h:
1472         * html/ImageInputType.cpp:
1473         (WebCore::ImageInputType::appendFormData):
1474         (WebCore::ImageInputType::handleDOMActivateEvent):
1475         * html/ImageInputType.h:
1476         * html/InputType.cpp:
1477         (WebCore::InputType::handleClickEvent):
1478         (WebCore::InputType::handleDOMActivateEvent):
1479         (WebCore::InputType::handleKeydownEvent):
1480         * html/InputType.h:
1481         * html/NumberInputType.cpp:
1482         (WebCore::NumberInputType::handleKeydownEvent):
1483         * html/NumberInputType.h:
1484         * html/RadioInputType.cpp:
1485         (WebCore::RadioInputType::handleClickEvent):
1486         * html/RadioInputType.h:
1487         * html/RangeInputType.cpp:
1488         (WebCore::RangeInputType::handleKeydownEvent):
1489         * html/RangeInputType.h:
1490         * html/ResetInputType.cpp:
1491         (WebCore::ResetInputType::handleDOMActivateEvent):
1492         * html/ResetInputType.h:
1493         * html/SubmitInputType.cpp:
1494         (WebCore::SubmitInputType::handleDOMActivateEvent):
1495         * html/SubmitInputType.h:
1496         * html/TextFieldInputType.cpp:
1497         (WebCore::TextFieldInputType::handleKeydownEvent):
1498         (WebCore::TextFieldInputType::handleKeydownEventForSpinButton):
1499         * html/TextFieldInputType.h:
1500
1501 2010-11-15  Chris Rogers  <crogers@google.com>
1502
1503         Reviewed by Kenneth Russell.
1504
1505         Add AudioNode custom bindings
1506         https://bugs.webkit.org/show_bug.cgi?id=49119
1507
1508         No new tests since audio API is not yet implemented.
1509
1510         * bindings/js/JSAudioNodeCustom.cpp: Added.
1511         (WebCore::JSAudioNode::connect):
1512         (WebCore::JSAudioNode::disconnect):
1513         * bindings/v8/custom/V8AudioNodeCustom.cpp: Added.
1514         (WebCore::V8AudioNode::connectCallback):
1515         (WebCore::V8AudioNode::disconnectCallback):
1516         * webaudio/AudioNode.idl:
1517
1518 2010-11-15  Dave Hyatt  <hyatt@apple.com>
1519
1520         Reviewed by Dan Bernstein.
1521
1522         https://bugs.webkit.org/show_bug.cgi?id=49570
1523         
1524         Put italics specialization check back in CSSFontSelector.  I had to back it out, since it broke
1525         a layout test, and the issue was that local font fallback fonts should not be considered by the
1526         specialization check (since you never want to pick a fallback over an actual @font-face rule if
1527         the @font-face rule can handle it).
1528  
1529         * css/CSSFontFace.h:
1530         (WebCore::CSSFontFace::create):
1531         (WebCore::CSSFontFace::isLocalFallback):
1532         (WebCore::CSSFontFace::CSSFontFace):
1533         * css/CSSFontSelector.cpp:
1534         (WebCore::CSSFontSelector::addFontFaceRule):
1535         (WebCore::compareFontFaces):
1536
1537 2010-11-15  Adele Peterson  <adele@apple.com>
1538
1539         Reviewed by Darin Adler.
1540
1541         Fix for: https://bugs.webkit.org/show_bug.cgi?id=49452
1542         Placeholder should not be swapped in and out of the text control's inner text element
1543
1544         There's no need to swap the placeholder text in and out of the inner text element.  Instead, just paint the text.
1545         This reduces complexity and makes it easier to make independent decisions about the placeholder text and the text control value.
1546
1547         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):
1548         Since updatePlaceholderVisibility checks the value, set the value before calling updatePlaceholderVisibility.
1549         * rendering/RenderTextControl.cpp:
1550         (WebCore::RenderTextControl::updatePlaceholderVisibility): Remove code that set the inner text value with the placeholder text.
1551         (WebCore::RenderTextControl::paintObject):  Paint the placeholder text during the background phase.
1552         * rendering/RenderTextControl.h:
1553         * rendering/RenderTextControlMultiLine.cpp:
1554         (WebCore::RenderTextControlMultiLine::nodeAtPoint): Remove custom hit testing that tried to avoid hitting the placeholder text at the wrong time.
1555         (WebCore::RenderTextControlMultiLine::updateFromElement):  Remove code that set the inner text value with the placeholder text.
1556         (WebCore::RenderTextControlMultiLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
1557         (WebCore::RenderTextControlMultiLine::textBoxInsetLeft): Added.
1558         (WebCore::RenderTextControlMultiLine::textBoxInsetRight): Added.
1559         * rendering/RenderTextControlMultiLine.h:
1560         * rendering/RenderTextControlSingleLine.cpp:
1561         (WebCore::RenderTextControlSingleLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
1562         (WebCore::RenderTextControlSingleLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
1563         (WebCore::RenderTextControlSingleLine::textBoxInsetLeft): Added.
1564         (WebCore::RenderTextControlSingleLine::textBoxInsetRight): Added.
1565         * rendering/RenderTextControlSingleLine.h:
1566         * rendering/TextControlInnerElements.cpp: Removed custom hit testing that tried to avoid hitting the placeholder text at the wrong time.
1567
1568 2010-11-15  Andreas Kling  <kling@webkit.org>
1569
1570         Unreviewed buildfix (Qt WebKit2 minimal)
1571
1572         * platform/qt/CookieJarQt.cpp: Add missing <QStringList> include.
1573
1574 2010-11-15  Chris Rogers  <crogers@google.com>
1575
1576         Reviewed by Kenneth Russell.
1577
1578         Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
1579         https://bugs.webkit.org/show_bug.cgi?id=49357
1580
1581         No new tests since audio API is not yet implemented.
1582
1583         * bindings/js/JSEventCustom.cpp:
1584         (WebCore::toJS):
1585         * bindings/js/JSEventTarget.cpp:
1586         (WebCore::toJS):
1587         * bindings/v8/V8DOMWrapper.cpp:
1588         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
1589         * bindings/v8/custom/V8EventCustom.cpp:
1590         (WebCore::toV8):
1591         * dom/Event.cpp:
1592         (WebCore::Event::isAudioProcessingEvent):
1593         * dom/Event.h:
1594         * dom/EventNames.h:
1595         * dom/EventTarget.cpp:
1596         (WebCore::EventTarget::toJavaScriptAudioNode):
1597         * dom/EventTarget.h:
1598
1599 2010-11-15  Alexey Proskuryakov  <ap@apple.com>
1600
1601         Reviewed by Darin Adler.
1602
1603         A minor style fix in StyledElement.cpp.
1604
1605         * dom/StyledElement.cpp:
1606         (WebCore::StyledElement::addCSSProperty):
1607         (WebCore::StyledElement::addCSSImageProperty):
1608
1609 2010-11-15  Alexey Proskuryakov  <ap@apple.com>
1610
1611         Reviewed by Darin Adler.
1612
1613         https://bugs.webkit.org/show_bug.cgi?id=49565
1614         Remove Attr.style accessor
1615
1616         * dom/Attr.idl: Only keep the accessor for Objective C API. Inspector doesn't seem to need
1617         it any more.
1618
1619 2010-11-15  Beth Dakin  <bdakin@apple.com>
1620
1621         Reviewed by Darin Adler.
1622
1623         Fix for https://bugs.webkit.org/show_bug.cgi?id=49555 
1624         Frame::scalePage() should treat the origin as an absolute 
1625         coordinate
1626         -and corresponding-
1627         <rdar://problem/8667138>
1628
1629         * page/Frame.cpp:
1630         (WebCore::Frame::scalePage):
1631
1632 2010-11-15  Dan Bernstein  <mitz@apple.com>
1633
1634         Reviewed by Darin Adler.
1635
1636         <rdar://problem/8662770> Error image has incorrect size when a custom font is used
1637
1638         Test: fast/images/style-access-during-imageChanged-crash.html
1639
1640         * rendering/RenderImage.cpp:
1641         (WebCore::RenderImage::RenderImage): Added initialization of m_needsToSetSizeForAltText.
1642         (WebCore::RenderImage::imageSizeForError): Factored the non-alt-text dependent size computation
1643         out of setImageSizeForAltText() into this function.
1644         (WebCore::RenderImage::setImageSizeForAltText): Changed to use imageSizeForError().
1645         (WebCore::RenderImage::styleDidChange): Added. If m_needsToSetSizeForAltText is true, sets the
1646         intrinsic size and calls imageDimensionsChanged() as needed to cause layout or invalidation.
1647         (WebCore::RenderImage::imageChanged): Moved some code from here...
1648         (WebCore::RenderImage::imageDimensionsChanged): ...to here.
1649         * rendering/RenderImage.h:
1650
1651 2010-11-15  Anders Carlsson  <andersca@apple.com>
1652
1653         Reviewed by Dimitri Glazkov.
1654
1655         ASSERTION (r72003): Assertion failure when running layout tests
1656         https://bugs.webkit.org/show_bug.cgi?id=49561
1657
1658         r72003 added the 'formaction' URL attribute to HTMLButtonElement and HTMLInputElement,
1659         but did not add the attribute to the isURLAttribute which lead to assertion failures
1660         when running the layout tests with a debug build.
1661
1662         * html/HTMLButtonElement.cpp:
1663         (WebCore::HTMLButtonElement::isURLAttribute):
1664         * html/HTMLButtonElement.h:
1665         * html/HTMLInputElement.cpp:
1666         (WebCore::HTMLInputElement::isURLAttribute):
1667
1668 2010-11-15  Alexey Proskuryakov  <ap@apple.com>
1669
1670         Reviewed by Darin Adler.
1671
1672         https://bugs.webkit.org/show_bug.cgi?id=49559
1673         DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString
1674
1675         No observable change in behavior, so no tests.
1676
1677         * page/DOMWindow.idl: Added ConvertUndefinedOrNullToNullString.
1678
1679 2010-11-15  Andreas Kling  <kling@webkit.org>
1680
1681         Reviewed by Tor Arne Vestbø.
1682
1683         [Qt] Make WTF_USE_MEEGOTOUCH available for WebKit2 as well
1684
1685         Move this into WebCore/features.pri which is used by both WebCore and WebKit2.
1686
1687         * WebCore.pro:
1688         * features.pri:
1689
1690 2010-11-15  Martin Robinson  <mrobinson@igalia.com>
1691
1692         Build fix for GTK+.
1693
1694         * GNUmakefile.am: Add some missing generated files to the source list.
1695
1696 2010-11-15  Kenneth Russell  <kbr@google.com>
1697
1698         Reviewed by James Robinson.
1699
1700         [chromium] Avoid copying of SkBitmap in LayerRendererChromium
1701         https://bugs.webkit.org/show_bug.cgi?id=49560
1702
1703         Ran CSS 3D content to test. No other new tests.
1704
1705         * platform/graphics/chromium/LayerRendererChromium.cpp:
1706         (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
1707
1708 2010-11-15  Vangelis Kokkevis  <vangelis@chromium.org>
1709
1710         Reviewed by Kenneth Russell.
1711
1712         [chromium] Fixes layer opacity implementation of composited layers
1713         https://bugs.webkit.org/show_bug.cgi?id=49233
1714
1715         This introduces a fairly drastic change in how LayerRendererChromium draws
1716         composited layers. Layers that have non-zero opacity as well as layers that
1717         clip their descendants (and have non-trivial transforms) are now first
1718         rendered onto off-screen surfaces (RenderSurfaceChromium's). The compositing
1719         operation now consists of two distinct phases: First a hierarchical traversal
1720         of the layer tree to compute the layer transforms, determine what the necessary
1721         RenderSurfaces are and sort layer that preserve-3d based on their z-value. A second
1722         pass goes through all the RenderSurfaces discovered by the first pass and updates
1723         their contents.
1724         Additional significant side-effects of this change are:
1725         1. Depth buffer and depth testing is no longer used. Drawing relies on a painter's
1726            algorithm to render layers with the preserves-3d property from back to front using
1727            the Z coordinate of their center. This will further be improved in the future with
1728            the intoduction of a BSP tree to properly deal with intersecting layers.
1729         2. Compositor no longer uses the stencil buffer to do clipping. Clipping is now performed
1730            by rendering layer subtrees into an offscreen buffer and setting the appropriate
1731            scissor and viewport transformation.
1732
1733         Tests: abs-position-inside-opacity.html (for the opacity implementation)
1734                and the rest of the compositing layout tests to verify that
1735                everything still works.
1736
1737         * WebCore.gypi:
1738         * platform/graphics/chromium/ContentLayerChromium.cpp:
1739         (WebCore::ContentLayerChromium::cleanupResources):
1740         (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
1741         (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
1742         (WebCore::ContentLayerChromium::updateContents):
1743         * platform/graphics/chromium/LayerChromium.cpp:
1744         (WebCore::LayerChromium::LayerChromium):
1745         (WebCore::LayerChromium::cleanupResources):
1746         (WebCore::LayerChromium::createRenderSurface):
1747         (WebCore::LayerChromium::descendantsDrawContent):
1748         (WebCore::LayerChromium::descendantsDrawContentRecursive):
1749         * platform/graphics/chromium/LayerChromium.h:
1750         (WebCore::LayerChromium::drawTransform):
1751         (WebCore::LayerChromium::layerRenderer):
1752         * platform/graphics/chromium/LayerRendererChromium.cpp:
1753         (WebCore::orthoMatrix):
1754         (WebCore::isScaleOrTranslation):
1755         (WebCore::LayerRendererChromium::compareLayerZ):
1756         (WebCore::LayerRendererChromium::LayerRendererChromium):
1757         (WebCore::LayerRendererChromium::prepareToDrawLayers):
1758         (WebCore::LayerRendererChromium::drawLayers):
1759         (WebCore::LayerRendererChromium::updateLayersRecursive):
1760         (WebCore::LayerRendererChromium::useRenderSurface):
1761         (WebCore::LayerRendererChromium::drawLayer):
1762         (WebCore::LayerRendererChromium::setScissorToRect):
1763         (WebCore::LayerRendererChromium::setDrawViewportRect):
1764         (WebCore::LayerRendererChromium::initializeSharedObjects):
1765         (WebCore::LayerRendererChromium::cleanupSharedObjects):
1766         * platform/graphics/chromium/LayerRendererChromium.h:
1767         * platform/graphics/chromium/RenderSurfaceChromium.cpp: Added.
1768         (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
1769         (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium):
1770         (WebCore::RenderSurfaceChromium::cleanupResources):
1771         (WebCore::RenderSurfaceChromium::layerRenderer):
1772         (WebCore::RenderSurfaceChromium::prepareContentsTexture):
1773         * platform/graphics/chromium/RenderSurfaceChromium.h: Added.
1774         (WebCore::RenderSurfaceChromium::contentRectCenter):
1775         (WebCore::RenderSurfaceChromium::contentRect):
1776         * platform/graphics/chromium/VideoLayerChromium.cpp:
1777         (WebCore::VideoLayerChromium::cleanupResources):
1778
1779 2010-11-15  Martin Robinson  <mrobinson@igalia.com>
1780
1781         Reviewed by Andreas Kling.
1782
1783         [GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds
1784         https://bugs.webkit.org/show_bug.cgi?id=49549
1785
1786         No new tests. This can be verified by loading any existing vertical text test
1787         in GtkLauncher and noticing the lack of CRITICAL GLib exceptions. There's currently
1788         no automatic way of verifying custom cursors.
1789
1790         * platform/gtk/GtkVersioning.c:
1791         (gdk_pixbuf_get_from_surface): Reverse a sanity check in this method to be correct.
1792
1793 2010-11-12  Jer Noble  <jer.noble@apple.com>
1794
1795         Reviewed by Brady Eidson.
1796
1797         Can't view HTML5 video when running Safari with an authenticated proxy server
1798         <rdar://problem/8351926>
1799         
1800         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1801         (WebCore::MediaPlayerPrivate::createQTMovie):
1802
1803 2010-11-14  Abhishek Arya  <inferno@chromium.org>
1804
1805         Reviewed by Dimitri Glazkov.
1806
1807         Event dispatch call can blow away the node's renderer initialized
1808         before the call in updateSelectionForMouseDrag function. We need
1809         to initialize it after the call.
1810         https://bugs.webkit.org/show_bug.cgi?id=49524
1811
1812         * page/EventHandler.cpp:
1813         (WebCore::EventHandler::updateSelectionForMouseDrag):
1814
1815 2010-11-15  Patrick Gansterer  <paroga@webkit.org>
1816
1817         Reviewed by Martin Robinson.
1818
1819         Make ContextShadow compile on all platforms
1820         https://bugs.webkit.org/show_bug.cgi?id=49535
1821
1822         Add a void* typedef for PlatformImage and PlatformContext for unsupported platforms
1823         and move them into the WebCore namespace like all other Platform* typedefs.
1824
1825         * platform/graphics/ContextShadow.h:
1826
1827 2010-11-15  Renata Hodovan  <reni@webkit.org>
1828
1829         Reviewed by Andreas Kling.
1830
1831         SVGFEImageElement doesn't support dynamic invalidation
1832         https://bugs.webkit.org/show_bug.cgi?id=49536
1833
1834         The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.
1835
1836         Tests: svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html
1837                svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html
1838
1839         * svg/SVGFEImageElement.cpp:
1840         (WebCore::SVGFEImageElement::svgAttributeChanged):
1841         * svg/SVGFEImageElement.h:
1842
1843 2010-11-15  Yael Aharon  <yael.aharon@nokia.com>
1844
1845         Reviewed by Antonio Gomes.
1846
1847         [Qt] Focus ring does not show on focused links.
1848         https://bugs.webkit.org/show_bug.cgi?id=49515
1849
1850         After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer
1851         visible in Qt.
1852         The reason is that Qt always returned true in RenderTheme::supportsFocusRing(),
1853         but until r69766, we did not check that for links. Qt draws its own focus ring
1854         for controls that it draws, but not for links.
1855         Change the return value to false if the style's appearance is not something that Qt
1856         draws by itself or does not support.
1857         Added a Qt specific test result for the new test added in r69766.
1858
1859         * platform/qt/RenderThemeQt.cpp:
1860         (WebCore::RenderThemeQt::supportsFocusRing):
1861
1862 2010-11-15  Dai Mikurube  <dmikurube@google.com>
1863
1864         Reviewed by Kent Tamura.
1865
1866         Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
1867         https://bugs.webkit.org/show_bug.cgi?id=49240
1868
1869         Tests: fast/forms/formaction-attribute.html
1870                fast/forms/formmethod-attribute-button-html.html
1871                fast/forms/formmethod-attribute-input-html.html
1872                fast/forms/formtarget-attribute-button-html.html
1873                fast/forms/formtarget-attribute-input-html.html
1874                fast/forms/mailto/formenctype-attribute-button-html.html
1875                fast/forms/mailto/formenctype-attribute-input-html.html
1876                fast/forms/submit-form-attributes.html
1877
1878         * html/HTMLAttributeNames.in: Added formaction, formmethod, formtarget and formenctype attributes
1879         * html/HTMLButtonElement.idl:
1880         * html/HTMLInputElement.idl:
1881         * loader/FormSubmission.cpp: Modified to check the pressed button and its attributes
1882         (WebCore::FormSubmission::Attributes::copyFrom):
1883         (WebCore::FormSubmission::create):
1884         * loader/FormSubmission.h:
1885
1886 2010-11-15  Pavel Feldman  <pfeldman@chromium.org>
1887
1888         Reviewed by Yury Semikhatsky.
1889
1890         Web Inspector: Do not hide default Ctrl+A behavior on non-Mac.
1891         https://bugs.webkit.org/show_bug.cgi?id=49527
1892
1893         * inspector/front-end/TextPrompt.js:
1894         (WebInspector.TextPrompt.prototype._onKeyDown):
1895
1896 2010-11-15  Ilya Sherman  <isherman@chromium.org>
1897
1898         Reviewed by Kent Tamura.
1899
1900         Add capability for displaying warnings to autofill popup
1901         Warnings are displayed in dark gray italic.
1902         https://bugs.webkit.org/show_bug.cgi?id=49291
1903         http://code.google.com/p/chromium/issues/detail?id=58509
1904
1905         * platform/chromium/PopupMenuChromium.cpp:
1906         (WebCore::PopupListBox::getRowFont):
1907           Use item-specific font, not just the generic menu font.
1908         (WebCore::PopupListBox::selectIndex):
1909           Updated to clear the selection when hovering over a non-selectable item.
1910         * platform/chromium/PopupMenuChromium.h: Minor cleanup
1911
1912 2010-11-14  David Hyatt  <hyatt@apple.com>
1913
1914         Back out the italics portion of the previous patch until I can figure out why it
1915         doesn't work.
1916
1917         * css/CSSFontSelector.cpp:
1918         (WebCore::compareFontFaces):
1919
1920 2010-11-14  Kent Tamura  <tkent@chromium.org>
1921
1922         Reviewed by Dimitri Glazkov.
1923
1924         Improve API for form validation message strings
1925         https://bugs.webkit.org/show_bug.cgi?id=34945
1926         
1927         This change introduces three new functions;
1928         validationMessageTypeMismatchFor*Text(). The implementation for each
1929         platform is just a call to validationMessageTypeMismatchText().
1930
1931         Some validationMessage*() functions have new parameters.  The parameters
1932         are ignored in all platforms for now.
1933
1934         This change doesn't change any behavior. However a platform can add
1935         additional information to validation messages.  e.g. Changing "type
1936         mismatch" to "Please specify an e-mail address" for <input type=email>.
1937
1938         * html/EmailInputType.cpp:
1939         (WebCore::EmailInputType::typeMismatchText): Call validationMessageTypeMismatchForEmailText()
1940           or validationMessageTypeMismatchForMultipleEmailText().
1941         * html/EmailInputType.h:
1942         * html/HTMLFormControlElement.h: Add maxLength() and value() to access them from ValidityState.
1943         * html/HTMLInputElement.cpp: Add the following functions to pass extra
1944           information to validation message string functions.
1945         (WebCore::HTMLInputElement::minimumString):
1946         (WebCore::HTMLInputElement::maximumString):
1947         (WebCore::HTMLInputElement::stepBaseString):
1948         (WebCore::HTMLInputElement::stepString):
1949         (WebCore::HTMLInputElement::typeMismatchText):
1950         * html/HTMLInputElement.h:
1951         * html/HTMLTextAreaElement.h:
1952         * html/InputType.cpp:
1953         (WebCore::InputType::typeMismatchText): Call validationMessageTypeMismatchText().
1954         * html/InputType.h:
1955         * html/URLInputType.cpp:
1956         (WebCore::URLInputType::typeMismatchText): Call validationMessageTypeMismatchForURLText().
1957         * html/URLInputType.h:
1958         * html/ValidityState.cpp:
1959         (WebCore::ValidityState::validationMessage):
1960         * platform/LocalizedStrings.cpp:
1961         (WebCore::validationMessageTypeMismatchForEmailText):
1962         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
1963         (WebCore::validationMessageTypeMismatchForURLText):
1964         (WebCore::validationMessageTooLongText):
1965         (WebCore::validationMessageRangeUnderflowText):
1966         (WebCore::validationMessageRangeOverflowText):
1967         (WebCore::validationMessageStepMismatchText):
1968         * platform/LocalizedStrings.h:
1969           - Add validationMessageTypeMismatchForEmailText(),
1970             validationMessageTypeMismatchForMultipleEmailText() and
1971             validationMessageTypeMismatchForURLText()
1972           - Add length parameters to validationMessageTooLongText().
1973           - Add the minimum value parameter to validationMessageRangeUnderflowText()
1974           - Add the maximum value parameter to validationMessageRangeOverflowText()
1975           - Add parameters of the base value and the step value to validationMessageStepMismatchText()
1976         * platform/android/LocalizedStringsAndroid.cpp:
1977         (WebCore::validationMessageTypeMismatchForEmailText):
1978         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
1979         (WebCore::validationMessageTypeMismatchForURLText):
1980         (WebCore::validationMessageTooLongText):
1981         (WebCore::validationMessageRangeUnderflowText):
1982         (WebCore::validationMessageRangeOverflowText):
1983         (WebCore::validationMessageStepMismatchText):
1984         * platform/brew/LocalizedStringsBrew.cpp:
1985         (WebCore::validationMessageTypeMismatchForEmailText):
1986         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
1987         (WebCore::validationMessageTypeMismatchForURLText):
1988         (WebCore::validationMessageTooLongText):
1989         (WebCore::validationMessageRangeUnderflowText):
1990         (WebCore::validationMessageRangeOverflowText):
1991         (WebCore::validationMessageStepMismatchText):
1992         * platform/efl/LocalizedStringsEfl.cpp:
1993         (WebCore::validationMessageRangeOverflowText):
1994         (WebCore::validationMessageRangeUnderflowText):
1995         (WebCore::validationMessageStepMismatchText):
1996         (WebCore::validationMessageTooLongText):
1997         (WebCore::validationMessageTypeMismatchForEmailText):
1998         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
1999         (WebCore::validationMessageTypeMismatchForURLText):
2000         * platform/gtk/LocalizedStringsGtk.cpp:
2001         (WebCore::validationMessageTypeMismatchForEmailText):
2002         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
2003         (WebCore::validationMessageTypeMismatchForURLText):
2004         (WebCore::validationMessageTooLongText):
2005         (WebCore::validationMessageRangeUnderflowText):
2006         (WebCore::validationMessageRangeOverflowText):
2007         (WebCore::validationMessageStepMismatchText):
2008         * platform/haiku/LocalizedStringsHaiku.cpp:
2009         (WebCore::validationMessageTypeMismatchForEmailText):
2010         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
2011         (WebCore::validationMessageTypeMismatchForURLText):
2012         (WebCore::validationMessageTooLongText):
2013         (WebCore::validationMessageRangeUnderflowText):
2014         (WebCore::validationMessageRangeOverflowText):
2015         (WebCore::validationMessageStepMismatchText):
2016         * platform/wx/LocalizedStringsWx.cpp:
2017         (WebCore::validationMessageTypeMismatchForEmailText):
2018         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
2019         (WebCore::validationMessageTypeMismatchForURLText):
2020         (WebCore::validationMessageTooLongText):
2021         (WebCore::validationMessageRangeUnderflowText):
2022         (WebCore::validationMessageRangeOverflowText):
2023         (WebCore::validationMessageStepMismatchText):
2024
2025 2010-11-14  Kent Tamura  <tkent@chromium.org>
2026
2027         Reviewed by Andreas Kling.
2028
2029         KeyboardEvent::keyIdentifier() should return "const String&"
2030         https://bugs.webkit.org/show_bug.cgi?id=49426
2031
2032         No new tests. This shouldn't change the current behavior.
2033
2034         * dom/KeyboardEvent.h:
2035         (WebCore::KeyboardEvent::keyIdentifier): Change the return type; String -> const String&
2036         * dom/SelectElement.cpp:
2037         (WebCore::SelectElement::menuListDefaultEventHandler):
2038           Change the type of a variable to have keyIdentifier(); String -> const String&
2039         (WebCore::SelectElement::listBoxDefaultEventHandler): ditto.
2040         * html/HTMLInputElement.cpp:
2041         (WebCore::HTMLInputElement::defaultEventHandler): ditto.
2042         (WebCore::HTMLInputElement::handleKeyEventForRange): ditto.
2043         * page/EventHandler.cpp:
2044         (WebCore::EventHandler::handleKeyboardSelectionMovement): ditto.
2045
2046 2010-11-14  Kenichi Ishibashi  <bashi@google.com>
2047
2048         Reviewed by Kent Tamura.
2049
2050         [HTML5] "form" attribute support for form control elements
2051         https://bugs.webkit.org/show_bug.cgi?id=47813
2052
2053         Adds a list of form-associated elements with form attribute into
2054         the Document class to support form attribute.
2055         Adds a function to determine the right place to locate
2056         form-associated elements with form attribute into
2057         m_associatedElements of HTMLFormElement class.
2058
2059         Tests: fast/forms/form-attribute-elements-order.html
2060                fast/forms/form-attribute-elements-order2.html
2061                fast/forms/form-attribute-elements.html
2062                fast/forms/form-attribute.html
2063
2064         * dom/Document.cpp:
2065         (WebCore::Document::registerFormElementWithFormAttribute): Added.
2066         (WebCore::Document::unregisterFormElementWithFormAttribute): Added.
2067         (WebCore::Document::resetFormElementsOwner): Added.
2068         * dom/Document.h: Added the list for elements with form attribute.
2069         * html/HTMLAttributeNames.in: Added form attribute.
2070         * html/HTMLFormControlElement.cpp:
2071         (WebCore::HTMLFormControlElement::insertedIntoTree): Modified to handle
2072         form attribute.
2073         (WebCore::HTMLFormControlElement::removedFromTree): Ditto.
2074         (WebCore::HTMLFormControlElement::resetFormOwner): Added.
2075         (WebCore::HTMLFormControlElement::attributeChanged): Added.
2076         * html/HTMLFormControlElement.h:
2077         * html/HTMLFormElement.cpp:
2078         (WebCore::HTMLFormElement::HTMLFormElement): Modified to initialize
2079         newly-added variables.
2080         (WebCore::HTMLFormElement::insertedIntoDocument): Modified to reset
2081         form owner of form-associated elements.
2082         (WebCore::HTMLFormElement::removedFromDocument): Ditto.
2083         (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Added.
2084         (WebCore::HTMLFormElement::formElementIndex): Modified to treat
2085         form-associated elements with form attribute separately.
2086         (WebCore::HTMLFormElement::removeFormElement): Modified to handle
2087         form-associated elements with form attribute.
2088         * html/HTMLFormElement.h: Added three variables to handle form attribute.
2089         * html/HTMLOutputElement.cpp: Removed "FIXME" comment.
2090         (WebCore::HTMLOutputElement::parseMappedAttribute):
2091         * html/HTMLOutputElement.h: Removed setForm().
2092
2093 2010-11-14  David Hyatt  <hyatt@apple.com>
2094
2095         Reviewed by Dan Bernstein.
2096
2097         https://bugs.webkit.org/show_bug.cgi?id=49521
2098
2099         REGRESSION svg/W3C-SVG-1.1/fonts-desc-02-t.svg broken by r71979.
2100         
2101         Refine the font selection function for @font-face to be smarter about what fonts it prefers.  If
2102         a font is labeled as only supporting small-caps, then prefer it to one that claims to support both
2103         normal and small-caps.  The specialized font is more likely to be true small-caps and to not rely
2104         on synthesis.
2105         
2106         Added the same logic for italic as well.  Prefer the font that is specifically restricted to
2107         italic to one that claims it can support anything.
2108
2109         * css/CSSFontSelector.cpp:
2110         (WebCore::compareFontFaces):
2111
2112 2010-11-14  Ryuan Choi  <ryuan.choi@samsung.com>
2113
2114         Reviewed by Martin Robinson.
2115
2116         [EFL] add pango support
2117         https://bugs.webkit.org/show_bug.cgi?id=46029
2118
2119         Include pango related files.
2120         No new tests; functionality is unchanged.
2121
2122         * CMakeListsEfl.txt:
2123
2124 2010-11-12  Tenghui Zhu  <ztenghui@google.com>
2125
2126         Reviewed by Andreas Kling.
2127
2128         [V8] Code generation script error in generating the SVGStaticListPropertyTearOff
2129         https://bugs.webkit.org/show_bug.cgi?id=49463
2130
2131         * bindings/scripts/CodeGeneratorV8.pm: The svgNativeType is the one containing
2132         the SVGStaticListPropertyTearOff string, not the svgListPropertyType.
2133
2134 2010-11-14  Patrick Gansterer  <paroga@webkit.org>
2135
2136         Reviewed by Andreas Kling.
2137
2138         Sort CMakeLists.txt
2139         https://bugs.webkit.org/show_bug.cgi?id=49507
2140
2141         * CMakeLists.txt:
2142
2143 2010-11-13  Patrick Gansterer  <paroga@webkit.org>
2144
2145         Reviewed by Yury Semikhatsky.
2146
2147         Buildfix for !ENABLE(INSPECTOR)
2148         https://bugs.webkit.org/show_bug.cgi?id=49500
2149
2150         Also unify the position of the condition in the cpp files.
2151
2152         * inspector/ConsoleMessage.cpp:
2153         * inspector/InspectorResourceAgent.cpp:
2154         * inspector/InspectorState.cpp:
2155         * inspector/ScriptCallFrame.cpp:
2156         * inspector/ScriptCallStack.cpp:
2157
2158 2010-11-13  David Hyatt  <hyatt@apple.com>
2159
2160         Reviewed by Anders Carlsson.
2161
2162         https://bugs.webkit.org/show_bug.cgi?id=49506
2163
2164         Repaint is broken across writing mode boundaries.  It's not enough to add in flipped offsets.  You have
2165         to flip the rect itself.
2166
2167         Added fast/repaint/repaint-across-writing-mode-boundary.html
2168
2169         * rendering/RenderBox.cpp:
2170         (WebCore::RenderBox::computeRectForRepaint):
2171
2172 2010-11-13  David Hyatt  <hyatt@apple.com>
2173
2174         Reviewed by Dan Bernstein.
2175
2176         https://bugs.webkit.org/show_bug.cgi?id=49505
2177         
2178         REGRESSION: @font-face doesn't work with the small-caps variant.  This was broken by the addition of SVG fonts
2179         support long ago.  This patch fixes the SVG code so that it doesn't break non-SVG fonts.
2180
2181         Added fast/blockflow/broken-ideograph-small-caps.html
2182
2183         * css/CSSFontFace.cpp:
2184         (WebCore::CSSFontFace::hasSVGFontFaceSource):
2185         * css/CSSFontFace.h:
2186         * css/CSSFontFaceSource.cpp:
2187         (WebCore::CSSFontFaceSource::getFontData):
2188         * css/CSSFontFaceSource.h:
2189         * css/CSSFontSelector.cpp:
2190         (WebCore::CSSFontSelector::addFontFaceRule):
2191         (WebCore::CSSFontSelector::getFontData):
2192
2193 2010-11-13  Dan Bernstein  <mitz@apple.com>
2194
2195         Reviewed by Dave Hyatt.
2196
2197         fast/text/hyphen* tests have different results on Leopard
2198         https://bugs.webkit.org/show_bug.cgi?id=43296
2199
2200         * platform/text/mac/TextBreakIteratorInternalICUMac.mm:
2201         (WebCore::topLanguagePreference): Changed to look up the value of the AppleLanguages default
2202         through the normal NSUserDefaults search order rather than skipping the application domain.
2203         This makes this function respect DumpRenderTree’s setting of the default in the application
2204         domain.
2205
2206 2010-11-13  David Hyatt  <hyatt@apple.com>
2207
2208         Reviewed by Dan Bernstein.
2209
2210         https://bugs.webkit.org/show_bug.cgi?id=49499
2211         
2212         broken-ideographic-font.html causes layout test flakiness in release builds.  The reason for this is
2213         that the custom font data for m_brokenIdeographFontData was never getting pruned out of the tree.
2214         The same problem exists for custom small caps fonts, so I made sure that the small caps fonts get
2215         pruned as well.  In addition, custom small caps fonts were never getting deleted either.
2216         
2217         I also made allowsLigatures in FontPlatformData orientation-independent, and the callers check it
2218         instead.
2219         
2220         Unskip fast/blockflow/broken-ideographic-font.html
2221
2222         * platform/graphics/SimpleFontData.cpp:
2223         (WebCore::SimpleFontData::~SimpleFontData):
2224         * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
2225         (WebCore::SimpleFontData::platformDestroy):
2226         (WebCore::SimpleFontData::smallCapsFontData):
2227         * platform/graphics/chromium/SimpleFontDataLinux.cpp:
2228         (WebCore::SimpleFontData::platformDestroy):
2229         (WebCore::SimpleFontData::smallCapsFontData):
2230         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
2231         (WebCore::FontPlatformData::allowsLigatures):
2232         * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
2233         (WebCore::SimpleFontData::platformDestroy):
2234         (WebCore::SimpleFontData::smallCapsFontData):
2235         * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
2236         (WebCore::SimpleFontData::platformDestroy):
2237         (WebCore::SimpleFontData::smallCapsFontData):
2238         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
2239         (WebCore::disableLigatures):
2240         * platform/graphics/mac/SimpleFontDataCoreText.cpp:
2241         (WebCore::SimpleFontData::getCFStringAttributes):
2242         * platform/graphics/mac/SimpleFontDataMac.mm:
2243         (WebCore::SimpleFontData::platformDestroy):
2244         * platform/graphics/win/SimpleFontDataWin.cpp:
2245         (WebCore::SimpleFontData::platformDestroy):
2246         (WebCore::SimpleFontData::smallCapsFontData):
2247         * platform/graphics/wx/SimpleFontDataWx.cpp:
2248         (WebCore::SimpleFontData::platformDestroy):
2249         (WebCore::SimpleFontData::smallCapsFontData):
2250
2251 2010-11-13  David Hyatt  <hyatt@apple.com>
2252
2253         https://bugs.webkit.org/show_bug.cgi?id=49496
2254
2255         Fix broken-ideographic-font.html.  I had the font installed locally on my machine, and this covered up
2256         the fact that CoreText was implicitly using it as fallback in the vertical case only.  The bots don't have
2257         the font installed locally, and so they showed the bug.
2258
2259         Make sure the GlyphPage is filled with horizontal glyphs for a broken ideograph font, so that CoreText is
2260         willing to fill.
2261
2262         * platform/graphics/mac/SimpleFontDataCoreText.cpp:
2263         (WebCore::SimpleFontData::getCFStringAttributes):
2264
2265 2010-11-13  David Hyatt  <hyatt@apple.com>
2266
2267         Reviewed by Dan Bernstein.
2268
2269         https://bugs.webkit.org/show_bug.cgi?id=49464
2270         
2271         Fix bugs with the orientation of fonts when the font is brought in via fallback, when the font contains no
2272         vertical tables, or when the font is loaded via font-face in both horizontal and vertical forms.
2273         
2274         (1) Include orientation as part of the @font-face hashtables so that the fonts are treated as
2275         distinct when used in horizontal and vertical forms.
2276         
2277         (2) Let the orientation member of FontPlatformData represent the desired orientation rather than
2278         the supported one.  Add an orientation member to SimpleFontData that represents the actual
2279         supported orientation of the font.
2280         
2281         (3) For fonts with no vertical tables, add a brokenIdeographicsFont accessor that is invoked when
2282         CJK ideographs are encountered.  This is essentially identical to the small caps fallback mechanism
2283         but invoked only for ideographs.  The special ideograph font locks the orientation to vertical and
2284         renders the glyphs upright even when the font has no vertical tables.  Punctuation and such will
2285         still look funny, and really this is a bug in the font, but at least this way it will be apparent
2286         that the font is to blame.
2287
2288         Added fast/blockflow/broken-ideographic-font.html and fast/blockflow/vertical-font-fallback.html.
2289
2290         * css/CSSFontFaceSource.cpp:
2291         (WebCore::CSSFontFaceSource::getFontData):
2292         * css/CSSSegmentedFontFace.cpp:
2293         (WebCore::CSSSegmentedFontFace::getFontData):
2294         * platform/graphics/Font.cpp:
2295         (WebCore::Font::isCJKIdeograph):
2296         * platform/graphics/Font.h:
2297         * platform/graphics/FontFastPath.cpp:
2298         (WebCore::Font::glyphDataForCharacter):
2299         * platform/graphics/SimpleFontData.cpp:
2300         (WebCore::SimpleFontData::SimpleFontData):
2301         (WebCore::SimpleFontData::~SimpleFontData):
2302         (WebCore::SimpleFontData::brokenIdeographFontData):
2303         * platform/graphics/SimpleFontData.h:
2304         (WebCore::SimpleFontData::orientation):
2305         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
2306         (WebCore::FontPlatformData::FontPlatformData):
2307         * platform/graphics/mac/FontMac.mm:
2308         (WebCore::showGlyphsWithAdvances):
2309         * platform/graphics/mac/SimpleFontDataMac.mm:
2310         (WebCore::SimpleFontData::platformInit):
2311         (WebCore::SimpleFontData::platformBoundsForGlyph):
2312         (WebCore::SimpleFontData::platformWidthForGlyph):
2313
2314 2010-11-13  Rob Buis  <rwlbuis@gmail.com>
2315
2316         Reviewed by Dirk Schulze.
2317
2318         requiredFeatures does not adapt to SVGStringList changes
2319         https://bugs.webkit.org/show_bug.cgi?id=40887
2320
2321         Centralize logic of handling of SVGElement validity changes.
2322         The logic is to detach the SVGElement when changing from valid
2323         to invalid, and to attach when changing from invalid to valid.
2324
2325         Tests: svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures.html
2326                svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures.html
2327                svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures.html
2328                svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures.html
2329                svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures.html
2330                svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures.html
2331                svg/dynamic-updates/SVGGElement-dom-requiredFeatures.html
2332                svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures.html
2333                svg/dynamic-updates/SVGImageElement-dom-requiredFeatures.html
2334                svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures.html
2335                svg/dynamic-updates/SVGLineElement-dom-requiredFeatures.html
2336                svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures.html
2337                svg/dynamic-updates/SVGPathElement-dom-requiredFeatures.html
2338                svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures.html
2339                svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures.html
2340                svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures.html
2341                svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures.html
2342                svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures.html
2343                svg/dynamic-updates/SVGRectElement-dom-requiredFeatures.html
2344                svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures.html
2345                svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures.html
2346                svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures.html
2347                svg/dynamic-updates/SVGTextElement-dom-requiredFeatures.html
2348                svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures.html
2349                svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html
2350                svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures.html
2351
2352         * svg/SVGCircleElement.cpp:
2353         (WebCore::SVGCircleElement::svgAttributeChanged):
2354         * svg/SVGEllipseElement.cpp:
2355         (WebCore::SVGEllipseElement::svgAttributeChanged):
2356         * svg/SVGForeignObjectElement.cpp:
2357         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
2358         * svg/SVGGElement.cpp:
2359         (WebCore::SVGGElement::svgAttributeChanged):
2360         * svg/SVGImageElement.cpp:
2361         (WebCore::SVGImageElement::svgAttributeChanged):
2362         * svg/SVGLineElement.cpp:
2363         (WebCore::SVGLineElement::svgAttributeChanged):
2364         * svg/SVGPathElement.cpp:
2365         (WebCore::SVGPathElement::svgAttributeChanged):
2366         * svg/SVGPolyElement.cpp:
2367         (WebCore::SVGPolyElement::svgAttributeChanged):
2368         * svg/SVGRectElement.cpp:
2369         (WebCore::SVGRectElement::svgAttributeChanged):
2370         * svg/SVGSVGElement.cpp:
2371         (WebCore::SVGSVGElement::svgAttributeChanged):
2372         * svg/SVGTests.cpp:
2373         (WebCore::knownAttribute):
2374         (WebCore::SVGTests::isKnownAttribute):
2375         (WebCore::SVGTests::handleAttributeChange): Centralized handling of SVGElement validity changes.
2376         * svg/SVGTests.h:
2377         * svg/SVGTextContentElement.cpp:
2378         (WebCore::SVGTextContentElement::svgAttributeChanged):
2379         (WebCore::SVGTextContentElement::isKnownAttribute):
2380         * svg/SVGTextContentElement.h:
2381         * svg/SVGUseElement.cpp:
2382         (WebCore::SVGUseElement::svgAttributeChanged):
2383
2384 2010-11-13  Andrey Kosyakov  <caseq@chromium.org>
2385
2386         Reviewed by Pavel Feldman.
2387
2388         Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view
2389         https://bugs.webkit.org/show_bug.cgi?id=49493
2390
2391         * inspector/front-end/NetworkPanel.js:
2392         (WebInspector.NetworkPanel.prototype._showResource):
2393         * inspector/front-end/ResourceView.js:
2394         (WebInspector.ResourceView):
2395         (WebInspector.ResourceView.prototype.selectContentTab):
2396         (WebInspector.ResourceView.prototype._selectTab):
2397         (WebInspector.ResourceView.prototype._refreshCookies):
2398         (WebInspector.ResourceCookiesTab.prototype.show):
2399         * inspector/front-end/StoragePanel.js:
2400         (WebInspector.StoragePanel.prototype.showResource):
2401         * inspector/front-end/TabbedPane.js:
2402         (WebInspector.TabbedPane.prototype.appendTab):
2403         (WebInspector.TabbedPane.prototype.hasTab):
2404         (WebInspector.TabbedPane.prototype.selectTabById):
2405         (WebInspector.TabbedPane.prototype._hideTab):
2406         (WebInspector.TabbedPane.prototype._showTab):
2407         * inspector/front-end/inspector.css:
2408         (.resource-view-cookies):
2409         (.resource-view-cookies.visible):
2410
2411 2010-11-13  Yury Semikhatsky  <yurys@chromium.org>
2412
2413         Reviewed by Pavel Feldman.
2414
2415         REGRESSION(71515): Web Inspector: Safari crash calling console.log when Log JavaScript Exceptions to Console is checked
2416         https://bugs.webkit.org/show_bug.cgi?id=49362
2417
2418         * page/Console.cpp:
2419         (WebCore::Console::addMessage): avoid accessing ScriptArguments and ScriptCallStack after their ownership
2420         has been passed to the inspector.
2421
2422 2010-11-13  Yury Semikhatsky  <yurys@chromium.org>
2423
2424         Reviewed by Pavel Feldman.
2425
2426         Web Inspector: DOM event listener name is cropped in Elements panel
2427         https://bugs.webkit.org/show_bug.cgi?id=49387
2428
2429         * inspector/front-end/inspector.css:
2430         (.event-bar): use margin-left instead of left to fit child node into its parent
2431
2432 2010-11-13  Ilya Sherman  <isherman@chromium.org>
2433
2434         Reviewed by Shinichiro Hamaji.
2435
2436         Fixes regression from previous patch -- computes y offsets for elements
2437         that are scrolled out of the window.
2438         https://bugs.webkit.org/show_bug.cgi?id=49306
2439
2440         * manual-tests/select-scroll.html: Added.
2441         * platform/chromium/PopupMenuChromium.cpp:
2442         (WebCore::PopupListBox::layout):
2443
2444 2010-11-12  Daniel Bates  <dbates@rim.com>
2445
2446         Reviewed by Adam Barth.
2447
2448         Transferred <iframe>s may not have a unique internal name
2449         https://bugs.webkit.org/show_bug.cgi?id=48768
2450
2451         Fixes an issue where an <iframe> that is transferred from
2452         document A to document B, where A != B, may not have a
2453         unique internal name in B.
2454
2455         Test: fast/frames/iframe-reparenting-unique-name.html
2456
2457         * html/HTMLFrameElementBase.cpp:
2458         (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Inlined code from
2459         HTMLFrameElementBase::setName() so that we can remove setName(), which
2460         was only called being called by HTMLFrameElementBase::setNameAndOpenURL().
2461         * html/HTMLFrameElementBase.h: Removed HTMLFrameElementBase::setName().
2462         * html/HTMLFrameOwnerElement.h: Removed HTMLFrameOwnerElement::setName().
2463         * page/Frame.cpp:
2464         (WebCore::Frame::transferChildFrameToNewDocument): Modified to call FrameTree::transferChild().
2465         * page/FrameTree.cpp:
2466         (WebCore::FrameTree::transferChild): Added.
2467         (WebCore::FrameTree::appendChild): Moved the majority of the code into FrameTree::actuallyAppendChild().
2468         (WebCore::FrameTree::actuallyAppendChild): Added.
2469         * page/FrameTree.h:
2470
2471 2010-11-12  Joseph Pecoraro  <joepeck@webkit.org>
2472
2473         Reviewed by Alexey Proskuryakov.
2474
2475         Some FrameLoader.h Cleanup
2476         https://bugs.webkit.org/show_bug.cgi?id=49484
2477
2478         Removed function signatures without any implementation. The functions
2479         used to exist, and were nicely refactored into PageCache in r60688 and
2480         the signatures were left behind.
2481
2482         Removed function signature setLoadType. Added in r17238 back when the
2483         file was named WebFrameLoader, and the implementation was lost during
2484         the transition from its mm implementation.
2485
2486         Removed function signature updateHistoryAfterClientRedirect. Implementation
2487         and call points were removed in r18541 but the signature was left behind,
2488         and jumped files!
2489
2490         Removed unused debug variable m_didDispatchDidCommitLoad. It was added
2491         and used in Assertions in r28399. It was removed soon after, in r28464
2492         because they were, "firing like crazy. Not sure why yet." It was
2493         never used again.
2494
2495         Added const qualifier and moved interruptionForPolicyChangeError to
2496         be more like its buddies.
2497
2498         * loader/FrameLoader.cpp:
2499         (WebCore::FrameLoader::FrameLoader):
2500         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2501         (WebCore::FrameLoader::interruptionForPolicyChangeError):
2502         (WebCore::FrameLoader::dispatchDidCommitLoad):
2503         * loader/FrameLoader.h:
2504
2505 2010-11-12  Yael Aharon  <yael.aharon@nokia.com>
2506
2507         Reviewed by David Hyatt.
2508
2509         Spatial Navigation: Cannot focus on some ContainerNode
2510         https://bugs.webkit.org/show_bug.cgi?id=48393
2511
2512         ContainerNode::getLowerRightCorner() assumes that the lowest right corner of its last child 
2513         is its own lowest right corner. If that child is an empty text node after an image, it does 
2514         not have size and position information, so we should go to the previous child.
2515
2516         Tests: fast/events/spatial-navigation/snav-container-only-white-space.html
2517                fast/events/spatial-navigation/snav-container-white-space.html
2518
2519         * dom/ContainerNode.cpp:
2520         (WebCore::ContainerNode::getLowerRightCorner):
2521
2522 2010-11-12  James Simonsen  <simonjam@chromium.org>
2523
2524         Reviewed by Darin Fisher.
2525
2526         [Web Timing] Rename interfaces:
2527         - Navigation -> PerformanceNavigation
2528         - Timing -> PerformanceTiming
2529         https://bugs.webkit.org/show_bug.cgi?id=48919
2530
2531         * DerivedSources.cpp:
2532         * DerivedSources.make:
2533         * GNUmakefile.am:
2534         * WebCore.gypi:
2535         * WebCore.vcproj/WebCore.vcproj:
2536         * WebCore.xcodeproj/project.pbxproj:
2537         * page/Performance.cpp:
2538         (WebCore::Performance::navigation):
2539         (WebCore::Performance::timing):
2540         * page/Performance.h:
2541         * page/Performance.idl:
2542         * page/PerformanceNavigation.cpp: Renamed from WebCore/page/Navigation.cpp.
2543         (WebCore::PerformanceNavigation::PerformanceNavigation):
2544         (WebCore::PerformanceNavigation::frame):
2545         (WebCore::PerformanceNavigation::disconnectFrame):
2546         (WebCore::PerformanceNavigation::type):
2547         (WebCore::PerformanceNavigation::redirectCount):
2548         * page/PerformanceNavigation.h: Renamed from WebCore/page/Navigation.h.
2549         (WebCore::PerformanceNavigation::create):
2550         * page/PerformanceNavigation.idl: Renamed from WebCore/page/Navigation.idl.
2551         * page/PerformanceTiming.cpp: Renamed from WebCore/page/Timing.cpp.
2552         (WebCore::toIntegerMilliseconds):
2553         (WebCore::getPossiblySkewedTimeInKnownRange):
2554         (WebCore::PerformanceTiming::PerformanceTiming):
2555         (WebCore::PerformanceTiming::frame):
2556         (WebCore::PerformanceTiming::disconnectFrame):
2557         (WebCore::PerformanceTiming::navigationStart):
2558         (WebCore::PerformanceTiming::unloadEventEnd):
2559         (WebCore::PerformanceTiming::redirectStart):
2560         (WebCore::PerformanceTiming::redirectEnd):
2561         (WebCore::PerformanceTiming::fetchStart):
2562         (WebCore::PerformanceTiming::domainLookupStart):
2563         (WebCore::PerformanceTiming::domainLookupEnd):
2564         (WebCore::PerformanceTiming::connectStart):
2565         (WebCore::PerformanceTiming::connectEnd):
2566         (WebCore::PerformanceTiming::requestStart):
2567         (WebCore::PerformanceTiming::requestEnd):
2568         (WebCore::PerformanceTiming::responseStart):
2569         (WebCore::PerformanceTiming::responseEnd):
2570         (WebCore::PerformanceTiming::domLoading):
2571         (WebCore::PerformanceTiming::domInteractive):
2572         (WebCore::PerformanceTiming::domContentLoaded):
2573         (WebCore::PerformanceTiming::domComplete):
2574         (WebCore::PerformanceTiming::loadEventStart):
2575         (WebCore::PerformanceTiming::loadEventEnd):
2576         (WebCore::PerformanceTiming::documentLoader):
2577         (WebCore::PerformanceTiming::documentTiming):
2578         (WebCore::PerformanceTiming::documentLoadTiming):
2579         (WebCore::PerformanceTiming::resourceLoadTiming):
2580         (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
2581         * page/PerformanceTiming.h: Renamed from WebCore/page/Timing.h.
2582         (WebCore::PerformanceTiming::create):
2583         * page/PerformanceTiming.idl: Renamed from WebCore/page/Timing.idl.
2584
2585 2010-11-12  Eric Carlson  <eric.carlson@apple.com>
2586
2587         Reviewed by Simon Fraser.
2588
2589         Remove unused code from HTMLMediaElement
2590         https://bugs.webkit.org/show_bug.cgi?id=49451
2591
2592         Just removing code, so no new tests.
2593
2594         * html/HTMLMediaElement.cpp: Removed unused functions.
2595         * html/HTMLMediaElement.h:
2596
2597 2010-11-12  Ryosuke Niwa  <rniwa@webkit.org>
2598
2599         Unreviewed Xcode project fix.
2600
2601         * WebCore.xcodeproj/project.pbxproj:
2602
2603 2010-11-12  Alexey Proskuryakov  <ap@apple.com>
2604
2605         Reviewed by Simon Fraser.
2606
2607         https://bugs.webkit.org/show_bug.cgi?id=49473
2608         WebKitCSSMatrix shouldn't inherit from StyleBase
2609
2610         No change in behavior, so no tests.
2611
2612         * css/WebKitCSSMatrix.cpp:
2613         (WebCore::WebKitCSSMatrix::WebKitCSSMatrix): We don't inherit from StyleBase any more, so
2614         no need to initialize always-null parent.
2615         (WebCore::WebKitCSSMatrix::setMatrixValue): Since there was never a parent, useStrictParsing()
2616         just returned true.
2617
2618         * css/WebKitCSSMatrix.h: Just inherit from RefCounted<WebKitCSSMatrix>. Removed unused default
2619         constructor and copy constructor.
2620
2621         * html/canvas/WebGLRenderingContext.h: Removed an unnneded forward declaration.
2622
2623 2010-11-12  Helder Correia  <helder@sencha.com>
2624
2625         Reviewed by Andreas Kling.
2626
2627         [Qt] Path::addArc() does not set right angle direction on full arcs
2628         https://bugs.webkit.org/show_bug.cgi?id=49138
2629
2630         Ensure correctness of nonzero winding rule for full arc paths.
2631         Invert the sign of the span if the direction is counterclockwise.
2632
2633         Test: fast/canvas/canvas-arc-360-winding.html
2634
2635         * platform/graphics/qt/PathQt.cpp:
2636         (WebCore::Path::addArc):
2637
2638 2010-11-05  Dimitri Glazkov  <dglazkov@chromium.org>
2639
2640         Reviewed by Darin Adler.
2641
2642         Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
2643         https://bugs.webkit.org/show_bug.cgi?id=46015
2644
2645         Test: fast/events/shadow-boundary-crossing-2.html
2646
2647         This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
2648         for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
2649
2650         This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
2651         appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
2652
2653         * Android.mk: Added EventContext, WindowEventContext files.
2654         * CMakeLists.txt: Ditto.
2655         * GNUmakefile.am: Ditto.
2656         * WebCore.gypi: Ditto.
2657         * WebCore.pro: Ditto.
2658         * WebCore.xcodeproj/project.pbxproj: Ditto.
2659         * WebCore.vcproj/WebCore.vcproj: Ditto.
2660         * dom/ContainerNode.cpp:
2661         (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
2662         * dom/EventContext.cpp: Added.
2663         * dom/EventContext.h: Added.
2664         * dom/Node.cpp:
2665         (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware.
2666         (WebCore::Node::createRendererIfNeeded): Ditto.
2667         (WebCore::Node::parentOrHostNode): Added new helper method.
2668         (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware.
2669         (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one.
2670         (WebCore::Node::getEventAncestors): Renamed and refactored to collect a vector of EventContexts.
2671         (WebCore::Node::topEventContext): Added.
2672         (WebCore::eventHasListeners): Changed to use EventContexts.
2673         (WebCore::Node::dispatchGenericEvent): Ditto.
2674         * dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
2675             and changed signature of eventAncestors to use EventContexts.
2676         * dom/Text.cpp:
2677         (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
2678         * dom/WindowEventContext.cpp: Added.
2679         * dom/WindowEventContext.h: Added.
2680         * inspector/InspectorDOMAgent.cpp:
2681         (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
2682         * page/EventHandler.cpp:
2683         (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
2684         * rendering/RenderTextControlMultiLine.cpp:
2685         (WebCore::RenderTextControlMultiLine::subtreeHasChanged): Removed event invocation that's
2686             no longer necessary.
2687         * rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent
2688         is deleted.
2689         * rendering/TextControlInnerElements.cpp:
2690         (WebCore::TextControlInnerTextElement::defaultEventHandler): Flipped the condition back
2691             from where it was prior to r60418.
2692         * svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
2693         * svg/SVGElement.h: Ditto.
2694
2695 2010-11-12  Ryuan Choi  <ryuan.choi@samsung.com>
2696
2697         Reviewed by Martin Robinson.
2698
2699         [GTK] Remove unnecessary header for FontPlatformDataPango.cpp
2700         https://bugs.webkit.org/show_bug.cgi?id=46029
2701
2702         Remove unnecessary header includes.
2703         No new tests, as there's no functionality.
2704
2705         * platform/graphics/pango/FontPlatformDataPango.cpp:
2706
2707 2010-11-11  Abhishek Arya  <inferno@chromium.org>
2708
2709         Reviewed by Adam Barth.
2710
2711         Not allow drag and drop across different origins.
2712         https://bugs.webkit.org/show_bug.cgi?id=49098
2713
2714         Test: http/tests/security/drag-drop-different-origin.html
2715
2716         * page/DragController.cpp:
2717         (WebCore::DragController::tryDocumentDrag):
2718         * page/SecurityOrigin.cpp:
2719         (WebCore::SecurityOrigin::canDropOnTarget):
2720         * page/SecurityOrigin.h:
2721
2722 2010-11-11  Alexander Pavlov  <apavlov@chromium.org>
2723
2724         Reviewed by Yury Semikhatsky.
2725
2726         Web Inspector: Inspect element tooltip obscures element metrics
2727         https://bugs.webkit.org/show_bug.cgi?id=47822
2728
2729         * inspector/InspectorController.cpp:
2730         (WebCore::InspectorController::drawNodeHighlight):
2731         (WebCore::InspectorController::drawElementTitle):
2732
2733 2010-11-12  Luiz Agostini  <luiz.agostini@openbossa.org>
2734
2735         Reviewed by Kenneth Rohde Christiansen.
2736
2737         [Qt] Button's background style from default Qt Mobile Theme  is overriding facebook's button style
2738         https://bugs.webkit.org/show_bug.cgi?id=48198
2739
2740         Instead of creating gradients that goes from white to grey and cover the whole element the gradients
2741         are created by varying the alpha channel of a dark color. This way the effect will not override the
2742         background color of the elements.
2743
2744         * css/themeQtMobile.css:
2745
2746 2010-11-12  Justin Schuh  <jschuh@chromium.org>
2747
2748         Reviewed by Adam Barth.
2749
2750         Use a RefPtr inside ContainerNode::willRemove loop
2751         https://bugs.webkit.org/show_bug.cgi?id=49237
2752
2753         Test: fast/innerHTML/innerHTML-iframe.html
2754
2755         * dom/ContainerNode.cpp:
2756         (WebCore::ContainerNode::willRemove):
2757
2758 2010-11-12  Pavel Feldman  <pfeldman@chromium.org>
2759
2760         Reviewed by Yury Semikhatsky.
2761
2762         Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
2763         https://bugs.webkit.org/show_bug.cgi?id=49130
2764
2765         * English.lproj/localizedStrings.js:
2766         * inspector/front-end/BreakpointManager.js:
2767         (WebInspector.BreakpointManager.prototype.debuggerPaused):
2768         (WebInspector.Breakpoint.jsBreakpointId):
2769         (WebInspector.Breakpoint.prototype.get id):
2770         * inspector/front-end/BreakpointsSidebarPane.js:
2771         (WebInspector.EventListenerBreakpointsSidebarPane):
2772         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
2773         * inspector/front-end/CallStackSidebarPane.js:
2774         (WebInspector.CallStackSidebarPane.prototype._breakpointHit): don't call populateStatusMessage for JS breakpoints
2775         since there is no specific message in that case.
2776         * inspector/front-end/ScriptsPanel.js:
2777         (WebInspector.ScriptsPanel):
2778         (WebInspector.ScriptsPanel.prototype.reset):
2779         * inspector/front-end/inspector.css:
2780         (#elements-sidebar):
2781         (.pane > .body):
2782         (#scripts-sidebar):
2783         (li.breakpoint-hit .breakpoint-hit-marker):
2784
2785 2010-11-12  Andrey Kosyakov  <caseq@chromium.org>
2786
2787         Reviewed by Yury Semikhatsky.
2788
2789         Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
2790         https://bugs.webkit.org/show_bug.cgi?id=49441
2791
2792         * inspector/front-end/ExtensionAPI.js:
2793         (WebInspector.injectedExtensionAPI.PanelImpl):
2794         (WebInspector.injectedExtensionAPI):
2795         (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPane):
2796         (WebInspector.injectedExtensionAPI.AuditCategoryImpl):
2797         (WebInspector.injectedExtensionAPI.AuditResultImpl):
2798         (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity):
2799         (WebInspector.injectedExtensionAPI.):
2800
2801 2010-11-12  Renata Hodovan  <reni@webkit.org>
2802
2803         Reviewed by Nikolas Zimmermann.
2804
2805         SVGFEDisplacementMapElement doesn't support dynamic invalidation
2806         https://bugs.webkit.org/show_bug.cgi?id=49430
2807
2808         The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.
2809
2810         Tests: svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr.html
2811                svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr.html
2812                svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr.html
2813                svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.html
2814                svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.html
2815                svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop.html
2816                svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop.html
2817                svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop.html
2818                svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.html
2819                svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.html
2820
2821         * svg/SVGFEDisplacementMapElement.cpp:
2822         (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
2823         * svg/SVGFEDisplacementMapElement.h:
2824
2825 2010-11-12  Andrey Kosyakov  <caseq@chromium.org>
2826
2827         Reviewed by Yury Semikhatsky.
2828
2829         Web Inspector: [refactoring] do not use absolute positioning for tabbed panes
2830         https://bugs.webkit.org/show_bug.cgi?id=49439
2831
2832         * inspector/front-end/TabbedPane.js:
2833         (WebInspector.TabbedPane):
2834         (WebInspector.TabbedPane.prototype.appendTab):
2835         * inspector/front-end/inspector.css:
2836         (.resource-view.visible):
2837         (.resource-view .tabbed-pane-header):
2838         (.resource-view-cookies):
2839         (.tabbed-pane):
2840         (.tabbed-pane-content):
2841         * inspector/front-end/networkPanel.css:
2842
2843 2010-11-12  John Knottenbelt  <jknotten@chromium.org>
2844
2845         Reviewed by Steve Block.
2846
2847         Rename GeolocationControllerClient to GeolocationClient.
2848         https://bugs.webkit.org/show_bug.cgi?id=49259
2849
2850         No new tests, renaming only.
2851
2852         * GNUmakefile.am:
2853         * WebCore.gypi:
2854         * WebCore.order:
2855         * WebCore.vcproj/WebCore.vcproj:
2856         * WebCore.xcodeproj/project.pbxproj:
2857         * page/GeolocationClient.h: Renamed from WebCore/page/GeolocationControllerClient.h.
2858         (WebCore::GeolocationClient::~GeolocationClient):
2859         * page/GeolocationController.cpp:
2860         (WebCore::GeolocationController::GeolocationController):
2861         * page/GeolocationController.h:
2862         * page/Page.h:
2863
2864 2010-11-12  Ilya Sherman  <isherman@chromium.org>
2865
2866         Reviewed by Eric Seidel.
2867
2868         Remove some trailing whitespace
2869         https://bugs.webkit.org/show_bug.cgi?id=49433
2870
2871         * platform/PopupMenuClient.h:
2872         * platform/chromium/PopupMenuChromium.cpp:
2873         (WebCore::PopupContainer::show):
2874         (WebCore::PopupListBox::paintRow):
2875         (WebCore::PopupListBox::scrollToRevealRow):
2876         * platform/chromium/PopupMenuChromium.h:
2877         * platform/chromium/SearchPopupMenuChromium.cpp:
2878         * rendering/RenderMenuList.h:
2879         (WebCore::RenderMenuList::toRenderMenuList):
2880         * rendering/RenderTextControlSingleLine.h:
2881         (WebCore::toRenderTextControlSingleLine):
2882
2883 2010-11-12  Ryosuke Niwa  <rniwa@webkit.org>
2884
2885         Reviewed by Csaba Osztrogonác.
2886
2887         [qt] script-clone tests added in r71895 fails on qt platform
2888         https://bugs.webkit.org/show_bug.cgi?id=49429
2889
2890         Fixed parseEndElement to call ScriptElement's executeScript as supposed to that of ScriptController.
2891
2892         * dom/XMLDocumentParserQt.cpp:
2893         (WebCore::XMLDocumentParser::parseEndElement):
2894
2895 2010-11-05  MORITA Hajime  <morrita@google.com>
2896
2897         Reviewed by Kent Tamura.
2898
2899         Refactoring: Return values of TextCheckingHelper::paragraphAlignedRange should form a class.
2900         https://bugs.webkit.org/show_bug.cgi?id=49053
2901
2902         Replaced paragraphAlignedRange() function call into
2903         TextCheckingParagraph class. The class encapsulates a range of a
2904         paragraph, and its relation within associated checking range.
2905         Instance variables of the class are computed lazily. So we can save unnecessary
2906         memory allocation and DOM tree traversal.
2907         
2908         No new tests, no behavior change. 
2909
2910         * editing/Editor.cpp:
2911         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced paragraphAlignedRange() call.
2912         (WebCore::Editor::changeBackToReplacedString): Replaced paragraphAlignedRange() call.
2913         * editing/TextCheckingHelper.cpp:
2914         (WebCore::expandToParagraphBoundary):
2915         (WebCore::TextCheckingParagraph::TextCheckingParagraph):
2916         (WebCore::TextCheckingParagraph::~TextCheckingParagraph):
2917         (WebCore::TextCheckingParagraph::expandRangeToNextEnd):
2918         (WebCore::TextCheckingParagraph::invalidateParagraphRangeValues):
2919         (WebCore::TextCheckingParagraph::rangeLength):
2920         (WebCore::TextCheckingParagraph::paragraphRange):
2921         (WebCore::TextCheckingParagraph::subrange):
2922         (WebCore::TextCheckingParagraph::offsetTo):
2923         (WebCore::TextCheckingParagraph::isEmpty):
2924         (WebCore::TextCheckingParagraph::offsetAsRange):
2925         (WebCore::TextCheckingParagraph::text):
2926         (WebCore::TextCheckingParagraph::checkingStart):
2927         (WebCore::TextCheckingParagraph::checkingEnd):
2928         (WebCore::TextCheckingParagraph::checkingLength):
2929         (WebCore::TextCheckingHelper::findFirstBadGrammar): Replaced paragraphAlignedRange() call.
2930         (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Replaced paragraphAlignedRange() call.
2931         * editing/TextCheckingHelper.h:
2932         (WebCore::TextCheckingParagraph::textLength):
2933         (WebCore::TextCheckingParagraph::textSubstring):
2934         (WebCore::TextCheckingParagraph::textCharacters):
2935         (WebCore::TextCheckingParagraph::textCharAt):
2936         (WebCore::TextCheckingParagraph::checkingSubstring):
2937         (WebCore::TextCheckingParagraph::checkingRangeMatches):
2938         (WebCore::TextCheckingParagraph::isCheckingRangeCoveredBy):
2939         (WebCore::TextCheckingParagraph::checkingRangeCovers):
2940         (WebCore::TextCheckingParagraph::checkingRange):
2941         (WebCore::TextCheckingParagraph::isTextEmpty):
2942         (WebCore::TextCheckingParagraph::isRangeEmpty):
2943
2944 2010-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2945
2946         Reviewed by Darin Adler.
2947
2948         Script runs more than once after a clone
2949         https://bugs.webkit.org/show_bug.cgi?id=48966
2950
2951         The bug was caused by cloneElementWithoutChildren's not propagating isEvaluated flag,
2952         which indicates whether or not the script has already started, and the fact
2953         neither HTMLScriptRunner nor XMLDocumentParser was setting isEvaluated flag to true.
2954
2955         Fixed the bug by making cloneElementWithoutChildren call a virtual cloneElementWithoutAttributesAndChildren,
2956         and override it in HTMLScriptElement and SVGScriptElement to propagate isEvaluated flag,
2957         and replacing direct access to ScriptController by a call to new ScriptElementData::executeScript,
2958         which updates the isEvaluated flag properly.
2959
2960         See also: http://www.whatwg.org/specs/web-apps/current-work/#already-started
2961
2962         Tests: fast/dom/script-clone-rerun-self.html
2963                fast/dom/script-clone-rerun.html
2964                svg/dom/SVGScriptElement/script-clone-rerun-self.svg
2965                svg/dom/SVGScriptElement/script-clone-rerun.svg
2966
2967         * dom/Element.cpp:
2968         (WebCore::Element::cloneElementWithoutChildren): Calls cloneElementWithoutChildren.
2969         (WebCore::Element::cloneElementWithoutAttributesAndChildren): Extracted from cloneElementWithoutChildren.
2970         * dom/Element.h:
2971         * dom/ScriptElement.cpp:
2972         (WebCore::ScriptElementData::ScriptElementData): Added isEvaluated flag to the argument list.
2973         (WebCore::ScriptElementData::evaluateScript): Extracted from HTMLScriptRunner::executeScript.
2974         (WebCore::ScriptElementData::executeScript): Renamed evaluated to isEvaluated.
2975         (WebCore::ScriptElementData::ignoresLoadRequest): Renamed evaluated to isEvaluated.
2976         * dom/ScriptElement.h: Renamed evaluated to isEvaluated.
2977         (WebCore::ScriptElementData::isEvaluated): Added.
2978         * dom/XMLDocumentParserLibxml2.cpp:
2979         (WebCore::XMLDocumentParser::endElementNs): Calls ScriptElement::executeScript.
2980         * html/HTMLScriptElement.cpp:
2981         (WebCore::HTMLScriptElement::HTMLScriptElement): Added isEvaluated flag to the argument list.
2982         (WebCore::HTMLScriptElement::create): Calls the constructor with the isEvaluated flag set to false.
2983         (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated.
2984         (WebCore::HTMLScriptElement::executeScript): Added; calls ScriptElementData::executeScript.
2985         * html/HTMLScriptElement.h:
2986         * html/parser/HTMLScriptRunner.cpp:
2987         (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Added an assertion that was lost
2988         in extracting ScriptElementData::executeScript.
2989         (WebCore::HTMLScriptRunner::runScript): Calls ScriptElementData::executeScript.
2990         * html/parser/HTMLScriptRunner.h:
2991         * svg/SVGScriptElement.cpp:
2992         (WebCore::SVGScriptElement::SVGScriptElement): Added isEvaluated flag to the argument list.
2993         (WebCore::SVGScriptElement::create): Calls the constructor with the isEvaluated flag set to false.
2994         (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated.
2995         (WebCore::SVGScriptElement::executeScript): Added; calls ScriptElementData::executeScript.
2996         * svg/SVGScriptElement.h:
2997
2998 2010-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2999
3000         Reviewed by Darin Adler.
3001
3002         REGRESSION: window.print in onload doesn't fire if there's an img
3003         https://bugs.webkit.org/show_bug.cgi?id=48195
3004
3005         This issue was introduced in
3006         https://bugs.webkit.org/show_bug.cgi?id=43658
3007         This happens because FrameLoader::isLoading() is false while an
3008         image is still loading. Now, window.print() happens after all
3009         resources are loaded.
3010
3011         Also changed the name of a member variable as Darin suggested in Bug 43658.
3012
3013         Added a manual test as DRT doesn't support window.print() yet.
3014
3015         * loader/DocumentLoader.cpp:
3016         (WebCore::DocumentLoader::DocumentLoader):
3017         (WebCore::DocumentLoader::updateLoading):
3018         * loader/DocumentLoader.h:
3019         * page/DOMWindow.cpp:
3020         (WebCore::DOMWindow::DOMWindow):
3021         (WebCore::DOMWindow::print):
3022         (WebCore::DOMWindow::finishedLoading):
3023         * page/DOMWindow.h:
3024
3025 2010-11-11  James Simonsen  <simonjam@chromium.org>
3026
3027         Reviewed by Tony Chang.
3028
3029         [chromium] Support letter spacing and fix whitespace wrapping on linux
3030
3031         When lines wrapped on RTL text, the whitespace was inserted before
3032         the first character on the new line instead of at the end of the
3033         previous line. This has been fixed.
3034
3035         The missing cluster information needed for letter spacing was hidden in
3036         harfbuzz's attributes struct.
3037
3038         https://bugs.webkit.org/show_bug.cgi?id=49405
3039
3040         * platform/graphics/chromium/FontLinux.cpp:
3041         (WebCore::TextRunWalker::letterSpacing): Added.
3042         (WebCore::TextRunWalker::isWordBreak): No need for isRTL.
3043         (WebCore::TextRunWalker::setPadding): Ditto.
3044         (WebCore::TextRunWalker::setGlyphXPositions): Support letter spacing. No whitespace before RTL text on new line.
3045         (WebCore::glyphIndexForXPositionInScriptRun): Support letter spacing.
3046
3047 2010-11-11  Kavita Kanetkar  <kkanetkar@chromium.org>
3048
3049         Reviewed by Dumitru Daniliuc.
3050
3051         FileSystem: Fix a link error for non-chromium WebKit build
3052         https://bugs.webkit.org/show_bug.cgi?id=49296
3053
3054         * WebCore.xcodeproj/project.pbxproj:
3055         * inspector/InspectorFileSystemAgent.cpp:
3056         (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem):
3057         (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntry):
3058         (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntries):
3059         (WebCore::InspectorFileSystemAgentCallbacks::didCreateFileWriter):
3060         (WebCore::InspectorFileSystemAgentCallbacks::didFail):
3061         (WebCore::InspectorFileSystemAgent::revealFolderInOS):
3062
3063 2010-11-11  Nate Chapin  <japhet@chromium.org>
3064
3065         Reviewed by Antti Koivisto.
3066
3067         Cleanup after http://trac.webkit.org/changeset/71562, namely:
3068         Make deferred request handle simpler.
3069         Don't perform callbacks associated with network load starting
3070         (e.g., willSendRequest) until the load is in fact sent to the network.
3071         Make ResourceLoadScheduler a friend of ResourceLoader and make
3072         ResourceLoader::start() protected to try to ensure loads actually
3073         go through the scheduler.
3074         https://bugs.webkit.org/show_bug.cgi?id=49351
3075
3076         Behavior should be covered by existing tests.
3077
3078         * loader/NetscapePlugInStreamLoader.cpp:
3079         (WebCore::NetscapePlugInStreamLoader::create):
3080         * loader/ResourceLoadScheduler.cpp:
3081         (WebCore::ResourceLoadScheduler::servePendingRequests):
3082         * loader/ResourceLoadScheduler.h:
3083         (WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
3084         * loader/ResourceLoader.cpp:
3085         (WebCore::ResourceLoader::init):
3086         (WebCore::ResourceLoader::start):
3087         (WebCore::ResourceLoader::setDefersLoading):
3088         (WebCore::ResourceLoader::didCancel):
3089         * loader/ResourceLoader.h:
3090         (WebCore::ResourceLoader::reachedTerminalState):
3091         (WebCore::ResourceLoader::request):
3092         * loader/SubresourceLoader.cpp:
3093         (WebCore::SubresourceLoader::create):
3094         * loader/loader.cpp:
3095         (WebCore::Loader::load):
3096         (WebCore::Loader::willSendRequest):
3097         * loader/loader.h:
3098
3099 2010-11-11  Carol Szabo <carol.szabo@nokia.com>
3100
3101         Reviewed by Kent Tamura.
3102
3103         css2:order of counters in out-of flow content
3104         https://bugs.webkit.org/show_bug.cgi?id=32412
3105
3106         Tests: fast/css/content/content-none.html
3107                fast/css/content/content-normal.html
3108
3109         * css/CSSParser.cpp:
3110         (WebCore::CSSParser::parseContent):
3111         Added support for none, normal, open-quote, no-open-quote, etc.
3112         identifiers in terms of parsing only, as this has effect on the
3113         evaluation of counters. No further implementation needed for 
3114         none and normal, the others are parsed but do not work as expected.
3115
3116 2010-11-11  Julie-Jeongeun-Kim  <jiyuluna@gmail.com>
3117
3118         Reviewed by Kent Tamura.
3119
3120         SelectionStart, selectionEnd properties return wrong values when the selection is in a read-only input or textarea element
3121         https://bugs.webkit.org/show_bug.cgi?id=25444
3122
3123         'rootEditableElement()' is checked on RenderTextControl::indexForVisiblePosition.
3124         It means that just editable elements can get selection information.
3125         ReadOnly element is not editable element. So, it just returns and can't get correct selection information.
3126         INPUT and TEXTAREA elements can be read-only but 'indexForVisiblePosition' doesn't accept them.
3127         So, Selectable elements, INPUT and TEXTAREA, checking is added for that case.
3128         Even if they are read-only, they are selectable.
3129
3130         new tests:fast/forms/selection-start-end-readonly.html
3131
3132         * html/HTMLInputElement.idl:
3133         * rendering/RenderTextControl.cpp:
3134         (WebCore::RenderTextControl::isSelectableElement):
3135         (WebCore::RenderTextControl::indexForVisiblePosition):
3136         * rendering/RenderTextControl.h:
3137
3138 2010-11-11  Adam Barth  <abarth@webkit.org>
3139
3140         Reviewed by David Levin.
3141
3142         Add some RefPtrs to be on the safe side
3143         https://bugs.webkit.org/show_bug.cgi?id=49301
3144
3145         Hopefully no behavior change.
3146
3147         * html/parser/HTMLTreeBuilder.cpp:
3148         (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
3149
3150 2010-11-11  Chris Rogers  <crogers@google.com>
3151
3152         Reviewed by Kenneth Russell.
3153
3154         Fix Accelerate.framework issues in VectorMath 32-bit ppc & i386 vs. other architectures (64-bit, ARM, etc.).
3155         On the Mac we use the highly optimized versions in Accelerate.framework
3156         In 32-bit mode (__ppc__ or __i386__) <Accelerate/Accelerate.h> includes <vecLib/vDSP_translate.h> which defines macros
3157         of the same name as our namespaced function names, so we must handle this case differently.
3158         Other architectures (64bit, ARM, etc.) do not include this header file.
3159         
3160         https://bugs.webkit.org/show_bug.cgi?id=49112
3161
3162         No new tests since audio API is not yet implemented.
3163
3164         * platform/audio/VectorMath.cpp:
3165         (WebCore::VectorMath::vsmul):
3166         (WebCore::VectorMath::vadd):
3167
3168 2010-11-11  Dan Bernstein  <mitz@apple.com>
3169
3170         Reviewed by Darin Adler.
3171
3172         <rdar://problem/8657116> fast/text/justification-padding-mid-word.html fails on Windows
3173         https://bugs.webkit.org/show_bug.cgi?id=49378
3174
3175         * platform/graphics/win/UniscribeController.cpp:
3176         (WebCore::UniscribeController::shapeAndPlaceItem): For all characters that need to be treated
3177         as zero-width spaces, substitute the space glyph with zero advance. Apply justification padding
3178         and word spacing only at characters treated as (non-zero-width) spaces.
3179
3180 2010-11-11  Darin Adler  <darin@apple.com>
3181
3182         Reviewed by Sam Weinig.
3183
3184         Harden some string functions against large lengths
3185         https://bugs.webkit.org/show_bug.cgi?id=49293
3186
3187         * rendering/RenderText.cpp:
3188         (WebCore::makeCapitalized): Check before incrementing length.
3189
3190 2010-11-10  Zhenyao Mo  <zmo@google.com>
3191
3192         Reviewed by Kenneth Russell.
3193
3194         bufferData/bufferSubData should not crash with null data input
3195         https://bugs.webkit.org/show_bug.cgi?id=49350
3196
3197         * html/canvas/WebGLRenderingContext.cpp: return early if input data is null.
3198         (WebCore::WebGLRenderingContext::bufferData):
3199         (WebCore::WebGLRenderingContext::bufferSubData):
3200
3201 2010-11-10  Zhenyao Mo  <zmo@google.com>
3202
3203         Reviewed by Kenneth Russell.
3204
3205         Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
3206         https://bugs.webkit.org/show_bug.cgi?id=47196
3207
3208         This is the first patch for this bug.  We add constants and methods, but haven't hooked it up with texture uploading yet.  Also, in order to check in constants.html, we need to remove out-dated constants, and update affected tests correspondingly.
3209
3210         Test: fast/canvas/webgl/constants.html
3211
3212         * html/canvas/WebGLRenderingContext.cpp:
3213         (WebCore::WebGLRenderingContext::WebGLRenderingContext): Move init code to initializeNewContext.
3214         (WebCore::WebGLRenderingContext::initializeNewContext): Ditto.
3215         (WebCore::WebGLRenderingContext::getParameter): Implement UNPACK_COLORSPACE_CONVERSION_WEBGL.
3216         (WebCore::WebGLRenderingContext::pixelStorei): Ditto.
3217         * html/canvas/WebGLRenderingContext.h: Add a member to track UNPACK_COLORSPACE_CONVERSION_WEBGL setting.
3218         * html/canvas/WebGLRenderingContext.idl: Update constants.
3219         * platform/graphics/GraphicsContext3D.h: Update constants.
3220
3221 2010-11-11  Chris Marrin  <cmarrin@apple.com>
3222
3223         Reviewed by James Robinson.
3224
3225         Add multisampling support to DrawingBuffer.
3226         https://bugs.webkit.org/show_bug.cgi?id=49206
3227
3228         Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample
3229         extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer.
3230
3231         This re-lands changes rolled out by http://trac.webkit.org/changeset/71839. It includes
3232         the change from http://trac.webkit.org/changeset/71831 and additional changes to 
3233         DrawingBufferChromium.cpp which cause the broken canvas tests to pass.
3234
3235         * platform/graphics/Extensions3D.h:
3236         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3237         (WebCore::DrawingBuffer::DrawingBuffer):
3238         (WebCore::DrawingBuffer::~DrawingBuffer):
3239         (WebCore::DrawingBuffer::publishToPlatformLayer):
3240         (WebCore::DrawingBuffer::didReset):
3241         (WebCore::DrawingBuffer::platformColorBuffer):
3242         * platform/graphics/chromium/Extensions3DChromium.h:
3243         (WebCore::Extensions3DChromium::blitFramebuffer):
3244         (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
3245         * platform/graphics/gpu/DrawingBuffer.cpp:
3246         (WebCore::DrawingBuffer::create):
3247         (WebCore::DrawingBuffer::clear):
3248         (WebCore::DrawingBuffer::reset):
3249         (WebCore::DrawingBuffer::commit):
3250         (WebCore::DrawingBuffer::bind):
3251         * platform/graphics/gpu/DrawingBuffer.h:
3252         (WebCore::DrawingBuffer::multisample):
3253         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
3254         (WebCore::DrawingBuffer::DrawingBuffer):
3255         (WebCore::DrawingBuffer::didReset):
3256         (WebCore::DrawingBuffer::platformColorBuffer):
3257         * platform/graphics/opengl/Extensions3DOpenGL.cpp:
3258         (WebCore::Extensions3DOpenGL::supports):
3259         (WebCore::Extensions3DOpenGL::blitFramebuffer):
3260         (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample):
3261         * platform/graphics/opengl/Extensions3DOpenGL.h:
3262         * platform/graphics/skia/ImageBufferSkia.cpp:
3263         (WebCore::ImageBuffer::draw):
3264
3265 2010-11-11  David Hyatt  <hyatt@apple.com>
3266
3267         Reviewed by Simon Fraser.
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=48664
3270         
3271         Make repaint invalidation work with flipped blocks ("rl" and "bt" writing modes).
3272         
3273         This patch disables the layout state for flipped blocks, since the paint offset isn't right.
3274         
3275         Bugs in the overflow sides for lines have been fixed.  before/AfterSideVisible/LayoutOverflowForLine
3276         now respect flipping (and don't incorrectly change sides).  This is a very confusing aspect of
3277         the overflow stuff (and at some point we should consider renaming top/left/right/bottom since they
3278         aren't physical).
3279         
3280         offsetFromContainer and mapLocalToContainer remain physical and refer to the top left offset.
3281         This means at every step up you convert to the correct physical coordinate.  It also means these
3282         functions will be unreliable during layout for flipped blocks.  At first glance, this seems to be
3283         more or less ok.
3284         
3285         computeRectForRepaint now delays flipping conversions until you cross a writing-mode boundary.  This
3286         allows for documents to be fully flipped and repaint during layout can still be reliable.  This is
3287         critical for incremental line layout repainting.
3288         
3289         Added new tests in fast/repaint and also rebaselined the tests in that directory because I'm tired
3290         of all the stale results and failures.
3291
3292         * editing/SelectionController.cpp:
3293         (WebCore::SelectionController::absoluteBoundsForLocalRect):
3294         (WebCore::SelectionController::paintCaret):
3295         * rendering/InlineTextBox.cpp:
3296         (WebCore::InlineTextBox::selectionRect):
3297         * rendering/RenderBlock.cpp:
3298         (WebCore::RenderBlock::layoutBlock):
3299         (WebCore::RenderBlock::layoutOnlyPositionedObjects):
3300         (WebCore::RenderBlock::paintSelection):
3301         * rendering/RenderBlockLineLayout.cpp:
3302         (WebCore::RenderBlock::beforeSideVisibleOverflowForLine):
3303         (WebCore::RenderBlock::afterSideVisibleOverflowForLine):
3304         (WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
3305         (WebCore::RenderBlock::afterSideLayoutOverflowForLine):
3306         * rendering/RenderBox.cpp:
3307         (WebCore::RenderBox::layout):
3308         (WebCore::RenderBox::mapLocalToContainer):
3309         (WebCore::RenderBox::offsetFromContainer):
3310         (WebCore::RenderBox::clippedOverflowRectForRepaint):
3311         (WebCore::RenderBox::computeRectForRepaint):
3312         (WebCore::RenderBox::flipForWritingMode):
3313         (WebCore::RenderBox::locationOffsetIncludingFlipping):
3314         * rendering/RenderBox.h:
3315         * rendering/RenderFlexibleBox.cpp:
3316         (WebCore::RenderFlexibleBox::layoutBlock):
3317         * rendering/RenderInline.cpp:
3318         (WebCore::RenderInline::clippedOverflowRectForRepaint):
3319         * rendering/RenderSlider.cpp:
3320         (WebCore::RenderSlider::layout):
3321         * rendering/RenderTable.cpp:
3322         (WebCore::RenderTable::layout):
3323         * rendering/RenderTableRow.cpp:
3324         (WebCore::RenderTableRow::layout):
3325         * rendering/RenderTableSection.cpp:
3326         (WebCore::RenderTableSection::layout):
3327         (WebCore::RenderTableSection::layoutRows):
3328         * rendering/RenderView.cpp:
3329         (WebCore::RenderView::computeRectForRepaint):
3330         * rendering/ShadowElement.cpp:
3331         (WebCore::ShadowBlockElement::layoutAsPart):
3332
3333 2010-11-11  Chris Marrin  <cmarrin@apple.com>
3334
3335         Reviewed by Simon Fraser.
3336
3337         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
3338         https://bugs.webkit.org/show_bug.cgi?id=49388
3339
3340         Renamed GraphicsLayerCA.* to GraphicsLayerMac.*
3341
3342         * WebCore.xcodeproj/project.pbxproj:
3343         * platform/graphics/mac/GraphicsLayerCA.h: Removed.
3344         * platform/graphics/mac/GraphicsLayerCA.mm: Removed.
3345         * platform/graphics/mac/GraphicsLayerMac.h: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.h.
3346         * platform/graphics/mac/GraphicsLayerMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.mm.
3347
3348 2010-11-11  Kenneth Russell  <kbr@google.com>
3349
3350         Reviewed by James Robinson.
3351
3352         [chromium] Missing adoptPtr in GraphicsContext3DSkia.cpp
3353         https://bugs.webkit.org/show_bug.cgi?id=49359
3354
3355         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
3356         (WebCore::GraphicsContext3D::getImageData):
3357
3358 2010-11-11  Dan Bernstein  <mitz@apple.com>
3359
3360         Reviewed by Adam Roben.
3361
3362         <rdar://problem/8113511> Enable auto-hyphenation
3363
3364         * WebCore.vcproj/WebCore.vcproj: Included HyphenationCF.cpp instead of Hyphenation.cpp.
3365         * platform/text/cf/HyphenationCF.cpp: Added functions and definitions for Windows to look up CFStringGetHyphenationLocationBeforeIndex
3366         and CFStringIsHyphenationAvailableForLocale at runtime.
3367         (wkCFStringGetHyphenationLocationBeforeIndex):
3368         (wkCFStringIsHyphenationAvailableForLocale):
3369         (WebCore::lastHyphenLocation): Added a cast.
3370
3371 2010-11-11  Eric Carlson  <eric.carlson@apple.com>
3372
3373         Reviewed by Eric Seidel.
3374
3375         video-pause-immediately.html sometimes fails
3376         https://bugs.webkit.org/show_bug.cgi?id=49397
3377
3378         * html/HTMLMediaElement.cpp:
3379         (WebCore::HTMLMediaElement::playInternal): Don't bother calling invalidateCachedTime, it
3380         will be called from updatePlayState.
3381         (WebCore::HTMLMediaElement::pauseInternal): Don't bother calling refreshCachedTime, it
3382         will be called from updatePlayState.
3383         (WebCore::HTMLMediaElement::updatePlayState): Call refreshCachedTime after telling the media
3384         engine to pause so we cache the post-paused time.
3385
3386 2010-11-11  Mihai Parparita  <mihaip@chromium.org>
3387
3388         Unreviewed rollout. 
3389         
3390         Roll out r71827 and r71831, which caused many GPU canvas test failures.
3391
3392         * platform/graphics/Extensions3D.h:
3393         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3394         (WebCore::DrawingBuffer::reset):
3395         (WebCore::DrawingBuffer::getRenderingResultsAsTexture):
3396         * platform/graphics/chromium/Extensions3DChromium.h:
3397         * platform/graphics/gpu/DrawingBuffer.cpp:
3398         (WebCore::DrawingBuffer::create):
3399         (WebCore::DrawingBuffer::clear):
3400         (WebCore::DrawingBuffer::bind):
3401         * platform/graphics/gpu/DrawingBuffer.h:
3402         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
3403         (WebCore::SharedGraphicsContext3D::create):
3404         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
3405         (WebCore::DrawingBuffer::DrawingBuffer):
3406         (WebCore::DrawingBuffer::reset):
3407         * platform/graphics/opengl/Extensions3DOpenGL.cpp:
3408         (WebCore::Extensions3DOpenGL::supports):
3409         * platform/graphics/opengl/Extensions3DOpenGL.h:
3410         * platform/graphics/skia/ImageBufferSkia.cpp:
3411         (WebCore::ImageBuffer::draw):
3412
3413 2010-11-11  Eric Carlson  <eric.carlson@apple.com>
3414
3415         Restore the portion of the ChangeLog removed in my last commit.
3416
3417 2010-11-11  Eric Carlson  <eric.carlson@apple.com>
3418
3419         Unreviewed Leoaprd build fix.
3420
3421         * html/HTMLMediaElement.cpp:
3422         (WebCore::HTMLMediaElement::invalidateCachedTime): Make the const a double.
3423
3424 2010-11-11  Dirk Schulze  <krit@webkit.org>
3425
3426         Unreviewed Qt build fix.
3427
3428         SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
3429         https://bugs.webkit.org/show_bug.cgi?id=49284
3430
3431         * svg/SVGAnimationElement.cpp:
3432         (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
3433         (WebCore::SVGAnimationElement::startedActiveInterval):
3434
3435 2010-11-11  Hans Wennborg  <hans@chromium.org>
3436
3437         Reviewed by Jeremy Orlow.
3438
3439         IndexedDB: signal IDBFactoryBackendInterface destruction to embedder
3440         https://bugs.webkit.org/show_bug.cgi?id=49313
3441
3442         Define IDBFactoryBackendInterface destructor out-of-line to allow
3443         for embedder-specific implementation. For Chromium, have the
3444         destructor call ChromiumBridge::idbShutdown().
3445
3446         * platform/chromium/ChromiumBridge.h:
3447         * storage/IDBFactoryBackendInterface.cpp:
3448         (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
3449         * storage/IDBFactoryBackendInterface.h:
3450         * storage/chromium/IDBFactoryBackendInterface.cpp:
3451         (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
3452
3453 2010-11-11  Dirk Schulze  <krit@webkit.org>
3454
3455         Reviewed by Nikolas Zimmermann.
3456
3457         SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
3458         https://bugs.webkit.org/show_bug.cgi?id=49284
3459
3460         Add support for from-to and from-by animations in combination with calcMode 'spline' for SVGAnimations.
3461
3462         Tests: svg/animations/animate-calcMode-spline-by.html
3463                svg/animations/animate-calcMode-spline-from-by.html
3464                svg/animations/animate-calcMode-spline-from-to.html
3465                svg/animations/animate-calcMode-spline-to.html
3466                svg/animations/animate-calcMode-spline-values.html
3467
3468         * svg/SVGAnimationElement.cpp:
3469         (WebCore::SVGAnimationElement::calculateKeyTimesIndex): Added to share more code.
3470         (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
3471         (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
3472         (WebCore::SVGAnimationElement::startedActiveInterval):
3473         (WebCore::SVGAnimationElement::updateAnimation):
3474         * svg/SVGAnimationElement.h:
3475
3476 2010-11-10  Chris Marrin  <cmarrin@apple.com>
3477
3478         Reviewed by James Robinson.
3479
3480         Add multisampling support to DrawingBuffer.
3481         https://bugs.webkit.org/show_bug.cgi?id=49206
3482
3483         Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample
3484         extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer.
3485
3486         * platform/graphics/Extensions3D.h:
3487         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3488         (WebCore::DrawingBuffer::platformColorBuffer):
3489         * platform/graphics/chromium/Extensions3DChromium.h:
3490         (WebCore::Extensions3DChromium::blitFramebuffer):
3491         (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
3492         * platform/graphics/gpu/DrawingBuffer.cpp:
3493         (WebCore::DrawingBuffer::create):
3494         (WebCore::DrawingBuffer::clear):
3495         (WebCore::DrawingBuffer::reset):
3496         (WebCore::DrawingBuffer::commit):
3497         (WebCore::DrawingBuffer::bind):
3498         * platform/graphics/gpu/DrawingBuffer.h:
3499         (WebCore::DrawingBuffer::multisample):
3500         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
3501         (WebCore::DrawingBuffer::DrawingBuffer):
3502         (WebCore::DrawingBuffer::platformLayer):
3503         (WebCore::DrawingBuffer::platformColorBuffer):
3504         * platform/graphics/opengl/Extensions3DOpenGL.cpp:
3505         (WebCore::Extensions3DOpenGL::supports):
3506         (WebCore::Extensions3DOpenGL::blitFramebuffer):
3507         (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample):
3508         * platform/graphics/opengl/Extensions3DOpenGL.h:
3509         * platform/graphics/skia/ImageBufferSkia.cpp:
3510         (WebCore::ImageBuffer::draw):
3511
3512 2010-11-11  Eric Carlson  <eric.carlson@apple.com>
3513
3514         Build fix after r71824.
3515
3516         * html/HTMLMediaElement.cpp:
3517         (WebCore::HTMLMediaElement::invalidateCachedTime): Use an explicit cast from double to float.
3518         (WebCore::HTMLMediaElement::currentTime): Ditto.
3519
3520 2010-11-11  Eric Carlson  <eric.carlson@apple.com>
3521
3522         Reviewed by Antti Koivisto.
3523
3524