1 2009-11-13 Hironori Bono <hbono@chromium.org>
3 Reviewed by Oliver Hunt.
5 Implement composition events introduced in DOM Level 3.
6 This change adds a new IDL which defines the composition events, adds a class which
7 implements the composition events, and sends the composition events according to
9 https://bugs.webkit.org/show_bug.cgi?id=26310
11 Test: fast/events/ime-composition-events-001.html
13 * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
14 * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
15 * WebCore.gypi: ditto.
17 * WebCore.vcproj/WebCore.vcproj: ditto.
18 * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
19 * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
20 * bindings/js/JSEventCustom.cpp:
21 (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
22 * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
23 * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
24 * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
25 (WebCore::V8DOMWrapper::convertEventToV8Object):
26 * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
27 * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
28 * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
29 (WebCore::CompositionEvent::CompositionEvent):
30 (WebCore::CompositionEvent::~CompositionEvent):
31 (WebCore::CompositionEvent::initCompositionEvent):
32 (WebCore::CompositionEvent::isCompositionEvent):
33 * dom/CompositionEvent.h: Declares the CompositionEvent class.
34 (WebCore::CompositionEvent::create):
35 (WebCore::CompositionEvent::data):
36 * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
38 (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
40 * dom/EventNames.h: Added composition{start,update,end} to eventNames.
42 (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
43 (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
45 2009-11-13 Jens Alfke <snej@chromium.org>
47 Reviewed by Dimitri Glazkov.
49 Fix a link error in unofficial GCC 4.4 builds on Linux.
50 https://bugs.webkit.org/show_bug.cgi?id=31477
52 * bindings/v8/V8Binding.cpp: Add explicit instantiations of v8StringToWebCoreString template.
54 2009-11-13 Eric Seidel <eric@webkit.org>
56 No review, build fix only.
58 Fix Debug build after http://trac.webkit.org/changeset/50960.
60 The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
61 https://bugs.webkit.org/show_bug.cgi?id=31213
63 * rendering/CounterNode.cpp:
64 (WebCore::showTreeAndMark):
65 * rendering/RenderCounter.cpp:
66 (WebCore::destroyCounterNodeChildren):
68 2009-11-13 Dirk Schulze <krit@webkit.org>
70 Reviewed by Gustavo Noronha.
72 [CAIRO] shadow support for Canvas and SVG
73 [https://bugs.webkit.org/show_bug.cgi?id=30960]
75 We currently fill a path with solid color instead of filling
76 a clipping path. This causes problems on some composite operators,
77 since Cairo modifies the area outside the path.
78 This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
80 Thanks to Benjamin Otte for tracking the bug down.
82 * platform/graphics/cairo/GraphicsContextCairo.cpp:
83 (WebCore::setPlatformFill):
85 2009-11-12 Dumitru Daniliuc <dumi@chromium.org>
87 Reviewed by Dimitri Glazkov.
89 Adding Chromium's DatabaseTracker implementation.
91 https://bugs.webkit.org/show_bug.cgi?id=31440
93 * WebCore.gyp/WebCore.gyp:
95 * storage/DatabaseTracker.h:
96 * storage/chromium/DatabaseTrackerChromium.cpp:
97 (WebCore::DatabaseTracker::fullPathForDatabase):
98 (WebCore::DatabaseTracker::getMaxSizeForDatabase):
99 * storage/chromium/QuotaTracker.cpp:
100 (WebCore::QuotaTracker::updateDatabaseSize):
101 * storage/chromium/QuotaTracker.h:
103 2009-11-13 Carol Szabo <carol.szabo@nokia.com>
105 Reviewed by Darin Adler.
107 The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
108 https://bugs.webkit.org/show_bug.cgi?id=31213
109 Added tree navigation methods that permit full implementation of CSS2.1
110 counter feature without using recursion proportional to the counter
112 No new tests because I did not find any bug that is fixed by this
113 commit yet, this just reduces the size of the patch for 11031 and
114 helps respond to some concerns regarding that patch.
116 * rendering/CounterNode.cpp:
117 (WebCore::CounterNode::CounterNode):
119 (WebCore::CounterNode::nextInPreOrderAfterChildren):
120 (WebCore::CounterNode::nextInPreOrder):
121 Added to support non-recursive tree traversal necessary for
122 efficient full implementation of CSS2.1 counters.
124 (WebCore::CounterNode::lastDescendant):
125 (WebCore::CounterNode::previousInPreOrder):
126 Moved this methods such that they occupy a place similar to that of
127 identically named methods on the render tree. This allows for their
128 broader use needed in full implementation of CSS2.1 counters.
130 (WebCore::CounterNode::resetRenderer):
131 (WebCore::CounterNode::resetRenderers):
132 (WebCore::CounterNode::recount):
133 (WebCore::CounterNode::insertAfter):
134 (WebCore::CounterNode::removeChild):
135 Changed such that insertion/removal of a counter, triggers not only
136 recalculation of PrefixWidths, but also reassesment of values in
137 counter nodes. This is the basis full implementation of CSS2.1
138 counters. It does not change current behavior by much because of
139 changes needed to the recalculation algorithm, but those are comming
140 in the patch for 11031.
141 (WebCore::showTreeAndMark):
142 * rendering/CounterNode.h:
143 * rendering/RenderCounter.cpp:
145 Only changed argument type to prepare for implementation of Darin
146 Adler's recommendation for the patch to 11031.
148 (WebCore::RenderCounter::invalidate):
149 (WebCore::destroyCounterNodeChildren):
150 (WebCore::RenderCounter::destroyCounterNodes):
151 * rendering/RenderCounter.h:
152 * rendering/RenderObjectChildList.cpp:
153 (WebCore::invalidateCountersInContainer):
154 (WebCore::RenderObjectChildList::invalidateCounters):
155 * rendering/RenderObjectChildList.h:
156 Added the ability to restrict invalidation to counters with a given
158 Also invalidated counters that are on the child container itself
159 which were missed by the previous algorithm, but were a valid case.
161 2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
163 Reviewed by Dimitri Glazkov.
165 [V8] Protect SVG animated properties from destruction in bindings.
166 https://bugs.webkit.org/show_bug.cgi?id=31474
168 See http://crbug.com/26719.
170 Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
173 Made sure we keep a reference to SVG properties while setting a
175 * bindings/scripts/CodeGeneratorV8.pm:
176 * bindings/v8/V8Proxy.h:
177 (WebCore::V8Proxy::withSVGContext):
179 2009-11-13 Brent Fulgham <bfulgham@webkit.org>
181 Reviewed by Alexey Proskuryakov.
183 [CAIRO] shadow support for Canvas and SVG.
184 [https://bugs.webkit.org/show_bug.cgi?id=30960]
186 Incorporate Benjamin Otte's recommendations to avoid
187 a buffer overrun, and small performance improvement.
189 * platform/graphics/cairo/GraphicsContextCairo.cpp:
190 (WebCore::copyContextProperties): Correctly size output
191 storage for cairo_get_dash to avoid buffer overrun.
192 (WebCore::drawPathShadow): Prefer cairo_fill_extents
193 to slower cairo_stroke_extents when not drawing shadows.
195 2009-11-13 Dumitru Daniliuc <dumi@chromium.org>
197 Reviewed by Dimitri Glazkov.
199 Do not register Chromium's HTML5 DB VFS as the default
200 VFS. Otherwise, other sqlite DB users in the same process will
203 https://bugs.webkit.org/show_bug.cgi?id=31462
205 * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
206 (WebCore::SQLiteFileSystem::openDatabase):
207 * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
208 (WebCore::SQLiteFileSystem::registerSQLiteVFS):
209 * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
210 (WebCore::SQLiteFileSystem::registerSQLiteVFS):
212 2009-11-13 Alexey Proskuryakov <ap@apple.com>
216 * platform/network/cf/SocketStreamHandleCFNet.cpp:
217 (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
218 avoiding a sign mismatch warning.
220 2009-11-13 Alexey Proskuryakov <ap@apple.com>
224 * platform/network/cf/SocketStreamHandleCFNet.cpp:
225 (WebCore::SocketStreamHandle::readStreamCallback):
226 (WebCore::SocketStreamHandle::writeStreamCallback):
227 Use ASSERT_UNUSED for unused stream parameter.
229 2009-11-12 Alexey Proskuryakov <ap@apple.com>
231 Reviewed by Darin Adler.
233 https://bugs.webkit.org/show_bug.cgi?id=31441
234 Implement SocketStreamHandleCFNet
236 Existing WebSocket tests now pass on Mac. No proxy support yet.
238 * platform/network/SocketStreamHandleClient.h:
239 * platform/network/cf/SocketStreamHandle.h:
240 (WebCore::SocketStreamHandle::shouldUseSSL):
241 (WebCore::SocketStreamHandle::refAuthenticationClient):
242 (WebCore::SocketStreamHandle::derefAuthenticationClient):
243 (WebCore::SocketStreamHandle::):
244 * platform/network/cf/SocketStreamHandleCFNet.cpp:
245 (WebCore::SocketStreamHandle::SocketStreamHandle):
246 (WebCore::SocketStreamHandle::chooseProxy):
247 (WebCore::SocketStreamHandle::createStreams):
248 (WebCore::SocketStreamHandle::copyCFStreamDescription):
249 (WebCore::SocketStreamHandle::readStreamCallback):
250 (WebCore::SocketStreamHandle::writeStreamCallback):
251 (WebCore::SocketStreamHandle::~SocketStreamHandle):
252 (WebCore::SocketStreamHandle::platformSend):
253 (WebCore::SocketStreamHandle::platformClose):
254 (WebCore::SocketStreamHandle::receivedCredential):
255 (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
256 (WebCore::SocketStreamHandle::receivedCancellation):
258 2009-11-12 Pavel Feldman <pfeldman@chromium.org>
260 Reviewed by Timothy Hatcher.
262 Web Inspector: preload status bar button glyphs
263 in order to prevent them from flickering (take 2).
265 https://bugs.webkit.org/show_bug.cgi?id=31439
267 * inspector/front-end/inspector.js:
270 2009-11-13 Pavel Feldman <pfeldman@chromium.org>
272 Reviewed by Adam Barth.
274 Chromium: [REGRESSION] Crash while stopping on a breakpoint.
277 https://bugs.webkit.org/show_bug.cgi?id=31467
279 * bindings/v8/V8Proxy.cpp:
280 (WebCore::V8Proxy::canAccessPrivate):
282 2009-11-13 Dirk Schulze <krit@webkit.org>
284 Reviewed by Gustavo Noronha.
286 [CAIRO] shadow support for Canvas and SVG
287 [https://bugs.webkit.org/show_bug.cgi?id=30960]
289 This is the fix of a regression, caused by the shadow patch
290 from the bug above. Reinserted the save and restore calls
291 that were accidently removed by the previous patch.
293 * platform/graphics/cairo/GraphicsContextCairo.cpp:
294 (WebCore::setPlatformFill):
295 (WebCore::setPlatformStroke):
297 2009-11-13 Pavel Feldman <pfeldman@chromium.org>
299 Not reviewed. Reverting r50908 since it makes inspector tests
302 https://bugs.webkit.org/show_bug.cgi?id=31439
304 * inspector/front-end/inspector.js:
306 2009-11-13 Mikhail Naganov <mnaganov@chromium.org>
308 Reviewed by Timothy Hatcher.
310 Enable 'console.profile()' and 'console.profileEnd()'
311 regardless of JAVASCRIPT_DEBUGGER.
313 https://bugs.webkit.org/show_bug.cgi?id=31293
316 * bindings/js/JSConsoleCustom.cpp:
317 (WebCore::JSConsole::profile):
318 (WebCore::JSConsole::profileEnd):
319 * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
320 (WebCore::CALLBACK_FUNC_DECL):
321 * bindings/v8/custom/V8CustomBinding.h:
324 2009-11-12 David Levin <levin@chromium.org>
330 * bindings/v8/ScriptController.h:
331 (WebCore::ScriptController::evaluateInWorld): Add a dummy
332 method which isn't called in chromium to make things compile.
334 2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
336 Reviewed by Adam Barth.
338 The document-open.html test was flaky at times. The test invokes the layout test plugin
339 which in its destroy stream handler opens a new document. This basically tears down the
340 stream and the associated plugin instance, which causes a crash when the plugin stream
341 dereferences an invalid m_client pointer which points to the PluginView instance which
342 is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
343 and check for the same.
345 https://bugs.webkit.org/show_bug.cgi?id=31067
347 * plugins/PluginStream.cpp:
348 (WebCore::PluginStream::stop):
349 (WebCore::PluginStream::destroyStream):
351 2009-11-12 Dumitru Daniliuc <dumi@chromium.org>
353 Reviewed by Dimitri Glazkov.
355 Renaming some parameters passed to DB-related methods to better
356 indicate their purpose.
358 https://bugs.webkit.org/show_bug.cgi?id=31449
360 * platform/chromium/ChromiumBridge.h:
362 2009-11-12 Simon Fraser <simon.fraser@apple.com>
364 Reviewed by Dan Bernstein.
366 Transformed reflected elements are clipped inside element with opacity
367 https://bugs.webkit.org/show_bug.cgi?id=30957
369 transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
370 each clip rect into painting space before taking the unions. This, however, did not work
371 correctly with combinations of reflections and transforms. Fixed by unioning the
372 clipRect and mapping through transforms along the way.
374 Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
375 where the transparency layers are.
377 Test: fast/reflections/opacity-reflection-transform.html
379 * rendering/RenderLayer.cpp:
380 (WebCore::expandClipRectForDescendantsAndReflection):
381 (WebCore::transparencyClipBox):
382 (WebCore::RenderLayer::beginTransparencyLayers):
384 2009-11-12 Adam Barth <abarth@webkit.org>
386 Reviewed by Darin Fisher.
388 Improve SecurityOrigin::toString comment
389 https://bugs.webkit.org/show_bug.cgi?id=31041
391 * page/SecurityOrigin.h:
393 2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
395 Reviewed by Darin Adler.
397 externalRepresentation should take Frame as the argument
398 https://bugs.webkit.org/show_bug.cgi?id=31393
400 No new tests as this is just a refactoring.
403 * rendering/RenderTreeAsText.cpp:
404 (WebCore::externalRepresentation):
405 * rendering/RenderTreeAsText.h:
407 2009-11-12 Ben Murdoch <benm@google.com>
409 Reviewed by Dimitri Glazkov.
411 [Android] The Android specific files in page/Android are out of date.
412 https://bugs.webkit.org/show_bug.cgi?id=31437
416 * page/android/DragControllerAndroid.cpp:
417 (WebCore::DragController::dragOperation): Added.
418 (WebCore::DragController::cleanupAfterSystemDrag):
419 * page/android/EventHandlerAndroid.cpp:
420 (WebCore::EventHandler::accessKeyModifiers): Added.
421 * page/android/InspectorControllerAndroid.cpp: Removed.
423 2009-11-12 Brent Fulgham <bfulgham@webkit.org>
425 Reviewed by Simon Fraser.
427 [CAIRO] shadow support for Canvas and SVG.
428 [https://bugs.webkit.org/show_bug.cgi?id=30960]
430 Implement Canvas/SVG shadow support for Cairo. This patch
431 uses the filter code from SVG Filters. That means that it is
432 necessary to activate filters to see the shadows.
434 Test: fast/canvas/canvas-shadow.html
437 * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
438 * platform/graphics/GraphicsContext.h:
439 * platform/graphics/cairo/GraphicsContextCairo.cpp:
440 (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
441 (WebCore::setPlatformFill):
442 (WebCore::setPlatformStroke):
443 (WebCore::copyContextProperties):
444 (WebCore::drawPathShadow):
445 (WebCore::GraphicsContext::fillPath):
446 (WebCore::GraphicsContext::strokePath):
447 (WebCore::GraphicsContext::drawPath):
448 (WebCore::GraphicsContext::setPlatformShadow):
449 (WebCore::GraphicsContext::createPlatformShadow):
450 * platform/graphics/cairo/ImageCairo.cpp:
451 (WebCore::BitmapImage::draw): Add filter effect.
452 * platform/graphics/filters/Filter.h: Correct 'const' signatures.
453 * platform/graphics/filters/ImageBufferFilter.cpp: Added.
454 * platform/graphics/filters/ImageBufferFilter.h: Added.
455 * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
456 * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
458 2009-11-12 Dmitry Titov <dimich@chromium.org>
460 Reviewed by Alexey Proskuryakov.
462 Add postTaskToMainThread to ScriptExecutionContext.
463 Move the code to post task to the main thread into a new method on ScriptExecutionContext,
464 to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
465 contexts that live on the main thread.
466 https://bugs.webkit.org/show_bug.cgi?id=31427
468 No new tests - simply moving the code.
471 (WebCore::Document::postTask):
472 * dom/ScriptExecutionContext.cpp:
473 (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
474 (WebCore::ScriptExecutionContextTaskTimer::fired):
475 (WebCore::PerformTaskData::PerformTaskData):
476 (WebCore::PerformTaskData::performTask):
477 (WebCore::ScriptExecutionContext::postTaskToMainThread):
478 * dom/ScriptExecutionContext.h:
480 2009-11-12 Simon Fraser <simon.fraser@apple.com>
482 Reviewed by Darin Adler.
484 Fix crash when removing compositing layers when GC is enabled
485 https://bugs.webkit.org/show_bug.cgi?id=31429
487 Workaround <rdar://problem/7390716> by special-casing the removal
488 of all sublayers when GC is enabled.
490 * platform/graphics/mac/GraphicsLayerCA.mm:
491 (WebCore::safeSetSublayers):
492 (WebCore::GraphicsLayerCA::updateSublayerList):
493 (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
495 2009-11-12 Jens Alfke <snej@chromium.org>
497 Reviewed by Dimitri Glazkov.
499 The last of the V8 binding optimizations.
500 - Replace string-valued element accessors with a shared getter/setter function.
501 - Change error handling flow of control to avoid extra branches and function calls.
502 https://bugs.webkit.org/show_bug.cgi?id=31443
504 * bindings/scripts/CodeGeneratorV8.pm:
505 * bindings/v8/V8Binding.cpp:
506 (WebCore::getElementStringAttr): Body of string-valued Element getter function.
507 (WebCore::setElementStringAttr): Body of string-valued Element setter function.
508 * bindings/v8/V8Binding.h:
510 2009-11-12 Sam Weinig <sam@webkit.org>
512 Reviewed by Oliver Hunt.
514 Fix for <rdar://problem/7267951>
515 Canvas methods should reject uses of NaN and Infinity.
517 Test: fast/canvas/canvas-with-illegal-args.html
519 * html/canvas/CanvasRenderingContext2D.cpp:
520 (WebCore::CanvasRenderingContext2D::scale):
521 (WebCore::CanvasRenderingContext2D::rotate):
522 (WebCore::CanvasRenderingContext2D::translate):
523 (WebCore::CanvasRenderingContext2D::transform):
524 (WebCore::CanvasRenderingContext2D::setTransform):
526 2009-11-12 Pavel Feldman <pfeldman@chromium.org>
528 Reviewed by Timothy Hatcher.
530 Web Inspector: profile timeline panel, fix obvious problems.
532 https://bugs.webkit.org/show_bug.cgi?id=31432
534 * inspector/front-end/AbstractTimelinePanel.js:
535 (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
536 * inspector/front-end/TimelinePanel.js:
537 (WebInspector.TimelinePanel.prototype._setWindowPosition):
538 (WebInspector.TimelineCalculator):
539 (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
540 (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
541 (WebInspector.TimelineCalculator.prototype.reset):
542 (WebInspector.TimelineCalculator.prototype.updateBoundaries):
543 (WebInspector.TimelineCalculator.prototype.formatValue):
544 (WebInspector.TimelineGraph):
545 (WebInspector.TimelineGraph.prototype.refresh):
546 * inspector/front-end/utilities.js:
547 (Element.prototype.hasStyleClass):
549 2009-11-12 Pavel Feldman <pfeldman@chromium.org>
551 Reviewed by Timothy Hatcher.
553 Web Inspector: preload status bar button glyphs
554 in order to prevent them from flickering.
556 https://bugs.webkit.org/show_bug.cgi?id=31439
558 * inspector/front-end/inspector.js:
561 2009-11-12 Adam Roben <aroben@apple.com>
563 Replace worldIDs with world objects
565 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
566 user scripts/stylesheets and isolated worlds
568 Reviewed by Sam Weinig.
570 Covered by existing tests.
572 * WebCore.base.exp: Update exported symbols to match what now exists
573 and is needed by WebKit.
575 * bindings/js/ScheduledAction.cpp:
576 (WebCore::ScheduledAction::execute): Updated for function rename.
578 * bindings/js/ScriptController.cpp: Removed code that dealt with
580 (WebCore::ScriptController::createWorld): Added. Returns a new world
581 suitable for use on the main thread.
582 (WebCore::ScriptController::executeScriptInWorld): Renamed from
583 executeScriptInIsolatedWorld, since this works just fine with a
586 * bindings/js/ScriptController.h: Added createWorld, removed functions
587 that took worldIDs, renamed executeScriptInIsolatedWorld to
588 executeScriptInWorld.
591 (WebCore::Frame::injectUserScripts):
592 (WebCore::Frame::injectUserScriptsForWorld):
593 Updated for changes to UserScriptMap and ScriptController.
595 * page/Frame.h: Changed injectUserScriptsForWorld to take a
596 DOMWrapperWorld* instead of a worldID.
598 * page/PageGroup.cpp:
599 (WebCore::PageGroup::addUserScriptToWorld):
600 (WebCore::PageGroup::addUserStyleSheetToWorld):
601 (WebCore::PageGroup::removeUserScriptFromWorld):
602 (WebCore::PageGroup::removeUserStyleSheetFromWorld):
603 (WebCore::PageGroup::removeUserScriptsFromWorld):
604 (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
606 Changed these functions to take a DOMWrapperWorld* instead of a
607 worldID. Also updated for changes to UserScript and UserStyleSheet.
610 * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
613 * page/UserScriptTypes.h:
614 * page/UserStyleSheetTypes.h: Changed UserScriptMap and
615 UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
616 worldID as their key type.
619 2009-11-12 Brian Weinstein <bweinstein@apple.com>
621 Reviewed by Tim Hatcher.
623 Fixes <http://webkit.org/b/31260>.
624 Web Inspector: Main Resources Other than HTML are mis-detected.
626 Even if the resource is a main resource, look at its CachedResource type,
627 because it might be an image, stylesheet, or JavaScript file, and we
628 want to show them all correctly.
630 * inspector/InspectorResource.cpp:
631 (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
632 (WebCore::InspectorResource::type):
633 * inspector/InspectorResource.h:
635 2009-11-12 Jens Alfke <snej@chromium.org>
637 Reviewed by Dimitri Glazkov.
639 Table-driven setup for V8 binding template callback functions. 100k in code savings.
640 https://bugs.webkit.org/show_bug.cgi?id=31420
642 * bindings/scripts/CodeGeneratorV8.pm: Change generated ConfigureXXXTemplate fn
643 to call configureTemplate().
644 * bindings/v8/V8Binding.cpp:
645 (WebCore::configureTemplate): New function; does all the standard configuration work.
646 (WebCore::createCallback): De-inlined wrapper for FunctionTemplate creation.
647 * bindings/v8/V8Binding.h:
648 * bindings/v8/V8Proxy.cpp:
649 (WebCore::batchConfigureAttributes): Just wrapped the very long fn parameter list.
650 (WebCore::batchConfigureCallbacks): New function, used by configureTemplate.
651 (WebCore::batchConfigureConstants): Just wrapped the very long fn parameter list.
652 * bindings/v8/V8Proxy.h:
654 2009-11-12 Dumitru Daniliuc <dumi@chromium.org>
656 Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
658 * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
660 2009-11-12 Eric Carlson <eric.carlson@apple.com>
662 Reviewed by Dan Bernstein.
664 <rdar://problem/7388969> Add DOM API for fullscreen video
666 DOM API for fullscreen <video>.
668 Tests: media/media-fullscreen-inline.html
669 media/media-fullscreen-not-in-document.html
672 Add webkitbeginfullscreen and webkitendfullscreen.
674 * html/HTMLAttributeNames.in:
675 Add onwebkitbeginfullscreen and onwebkitendfullscreen.
677 * html/HTMLMediaElement.cpp:
678 (WebCore::HTMLMediaElement::parseMappedAttribute):
679 Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
680 (WebCore::HTMLMediaElement::enterFullscreen):
681 Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
682 actually do enter fullscreen.
683 (WebCore::HTMLMediaElement::exitFullscreen):
684 Schedule webkitendfullscreenEvent event.
685 (WebCore::HTMLMediaElement::webkitEnterFullScreen):
686 (WebCore::HTMLMediaElement::webkitExitFullScreen):
687 (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
688 (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
689 New, access to fullscreen properties and methods.
691 * html/HTMLMediaElement.h:
692 * html/HTMLMediaElement.idl:
693 Declare methods needed for fullscreen API.
695 * html/HTMLVideoElement.cpp:
696 (WebCore::HTMLVideoElement::supportsFullscreen):
697 Return false if a movie does not have video.
700 Add webkitbeginfullscreen and webkitendfullscreen.
702 2009-11-12 Adam Barth <abarth@webkit.org>
704 Reviewed by Dimitri Glazkov.
706 [Chromium] Sify compose button alerts error
707 https://bugs.webkit.org/show_bug.cgi?id=31394
709 Test: http/tests/security/calling-versus-current.html
711 We're supposed to use the calling context for security checks. In JSC
712 land, this is the lexicalGlobalObject.
714 * bindings/v8/V8Proxy.cpp:
715 (WebCore::V8Proxy::canAccessPrivate):
717 2009-11-12 Daniel Bates <dbates@webkit.org>
719 Reviewed by Darin Adler.
721 https://bugs.webkit.org/show_bug.cgi?id=30291
723 Fixes an issue where the returned drop effect is incorrect when
724 effectAllowed == "uninitialized".
726 According to section 7.9.2 of the HTML 5 spec.
727 <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
728 when effectAllowed = "uninitialized" the resulting dropEffect should be the
729 user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
732 No test cases are included because we have an existing test case from
736 (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
738 2009-11-12 Pavel Feldman <pfeldman@chromium.org>
740 Reviewed by Timothy Hatcher.
742 Web Inspector: Do not highlight node on refresh.
744 https://bugs.webkit.org/show_bug.cgi?id=31419
746 * inspector/front-end/ElementsPanel.js:
747 (WebInspector.ElementsPanel.prototype.reset):
749 2009-11-12 Pavel Feldman <pfeldman@chromium.org>
751 Reviewed by Timothy Hatcher.
753 Web Inspector: Minor timeline fixes.
755 https://bugs.webkit.org/show_bug.cgi?id=31417
757 * inspector/front-end/TimelinePanel.js:
758 (WebInspector.TimelinePanel.prototype._getRecordDetails):
759 (WebInspector.TimelineRecordTreeElement.prototype.onattach):
760 (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
761 (WebInspector.TimelineRecordTreeElement.prototype.refresh):
763 2009-11-12 Alexey Proskuryakov <ap@apple.com>
765 SnowLeopard build fix.
767 Renamed initWithClient to initWithAuthenticationClient.
769 * platform/network/mac/AuthenticationMac.mm:
770 (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
771 (WebCore::AuthenticationChallenge::setAuthenticationClient):
773 2009-11-12 Chris Fleizach <cfleizach@apple.com>
775 Reviewed by Darin Adler.
777 ARIA: add alert type roles
778 https://bugs.webkit.org/show_bug.cgi?id=31392
780 Test: platform/mac/accessibility/aria-alerts.html
782 * accessibility/AccessibilityObject.h:
783 * accessibility/AccessibilityRenderObject.cpp:
784 * accessibility/mac/AccessibilityObjectWrapper.mm:
786 2009-11-11 Alexey Proskuryakov <ap@apple.com>
788 Reviewed by Darin Adler.
790 https://bugs.webkit.org/show_bug.cgi?id=31386
791 Make Mac AuthenticationChallenge usable from cross-platform code
793 No change in behavior, so no tests.
795 * platform/network/ResourceHandle.cpp:
796 (WebCore::ResourceHandle::clearAuthentication):
797 * platform/network/ResourceHandleInternal.h:
798 (WebCore::ResourceHandleInternal::ResourceHandleInternal):
799 Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
800 NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
803 * platform/network/cf/AuthenticationChallenge.h:
804 (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
805 Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
807 * platform/network/cf/ResourceHandleCFNet.cpp:
808 (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
809 of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
812 * platform/network/mac/AuthenticationChallenge.h:
813 (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
814 best of my understanding.
815 (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
816 confusion with "mac" and "web" challenges in ResourceHandleInternal.
818 * platform/network/mac/AuthenticationMac.mm:
819 (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
820 making it possible to use the latter with NSURLAuthenticationChallenge.
821 (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
822 m_nsChallenge renaming.
823 (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
824 set it as sender (or unset, if client is null).
826 * platform/network/mac/ResourceHandleMac.mm:
827 (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
828 authentication challenge sender.
829 (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
830 authentication sheet.
831 (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
832 using the new setAuthenticationClient() method.
833 (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
834 Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
835 the original Mac one, not the one we created for use with authentication sheet. I don't
836 know when a connection would cancel authentication in practice, so I haven't tested this.
838 2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>
840 Reviewed by Timothy Hatcher.
842 Web Inspector: breakpoint sidebar entries should allow click over entire list item
843 https://bugs.webkit.org/show_bug.cgi?id=31411
845 No new tests; no new functionality, small usability change.
847 * inspector/front-end/BreakpointsSidebarPane.js:
848 (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
849 (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
851 2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>
853 Reviewed by Timothy Hatcher.
855 Web Inspector: breakpoints in named evals are not restored after a reload
856 https://bugs.webkit.org/show_bug.cgi?id=31375
860 * inspector/front-end/ScriptsPanel.js:
861 (WebInspector.ScriptsPanel.prototype.addScript):
862 * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
864 2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>
866 Reviewed by Kenneth Rohde Christiansen.
868 Custom printing shrink factors
869 https://bugs.webkit.org/show_bug.cgi?id=29042
871 This reverts commit r49769. The public API for this needs to be reviewed
872 before its inclusion in Qt.
874 * page/PrintContext.cpp:
875 (WebCore::PrintContext::begin):
877 (WebCore::Settings::Settings):
880 2009-11-12 Alexander Pavlov <apavlov@chromium.org>
882 Reviewed by Pavel Feldman.
884 Web Inspector: Resource errors/warnings not shown in the Resource tree.
886 Error/Warning bubbles are not displayed next to the resource in the
887 Resources panel if those occur before the resource is attached to the tree.
888 https://bugs.webkit.org/show_bug.cgi?id=31404
890 Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
892 * inspector/front-end/AbstractTimelinePanel.js:
893 (WebInspector.AbstractTimelinePanel.prototype.removeItem):
894 * inspector/front-end/ResourcesPanel.js:
895 (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
897 2009-11-12 Philippe Normand <pnormand@igalia.com>
899 Reviewed by Jan Alonzo.
901 https://bugs.webkit.org/show_bug.cgi?id=31047
902 [GTK] Failing test media/video-played-ranges-1.html
904 Follow-up of r50726, don't block the UI thread when calling
905 gst_element_get_state(). Also fixed a compilation warning and some
908 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
909 (WebCore::playbackPosition):
910 (WebCore::MediaPlayerPrivate::seek):
911 (WebCore::MediaPlayerPrivate::setRate):
913 2009-11-12 Philippe Normand <pnormand@igalia.com>
915 Reviewed by Jan Alonzo.
917 https://bugs.webkit.org/show_bug.cgi?id=31047
918 [GTK] Failing test media/video-played-ranges-1.html
920 don't pause pipeline if already paused, same for play()
922 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
923 (WebCore::MediaPlayerPrivate::play):
924 (WebCore::MediaPlayerPrivate::pause):
926 2009-11-12 Kinuko Yasuda <kinuko@google.com>
928 Reviewed by David Levin.
930 Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
932 https://bugs.webkit.org/show_bug.cgi?id=31292
934 No new tests. (Corresponding test for Gtk+ is
935 platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
937 * page/EventHandler.cpp:
938 * page/chromium/EventHandlerChromium.cpp:
940 2009-11-12 Yuta Kitamura <yutak@chromium.org>
942 Reviewed by Eric Seidel.
944 Prevent text inside a multi-column block from being split into columns.
946 If the tentative height of a multi-column block was too small, we need to
947 expand the block height and try to layout again, in order to prevent text
948 from being split into different columns.
950 CSS Multicolumn text is split awkwardly
951 https://bugs.webkit.org/show_bug.cgi?id=22249
953 Test: fast/multicol/single-line.html
955 * rendering/RenderBlock.cpp:
956 (WebCore::RenderBlock::layoutColumns):
957 * rendering/RenderBlock.h:
958 * rendering/RenderLineBoxList.cpp:
959 (WebCore::RenderLineBoxList::paint):
960 * rendering/RenderView.h:
961 (WebCore::RenderView::setTruncatedAt):
962 (WebCore::RenderView::setMinimumColumnHeight):
963 (WebCore::RenderView::minimumColumnHeight):
965 2009-11-11 Kent Tamura <tkent@chromium.org>
967 Reviewed by Darin Adler.
969 Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
970 https://bugs.webkit.org/show_bug.cgi?id=31195
972 Test: fast/forms/input-file-re-render.html
974 * rendering/RenderFileUploadControl.cpp:
975 (WebCore::RenderFileUploadControl::RenderFileUploadControl):
977 2009-11-09 Dumitru Daniliuc <dumi@chromium.org>
979 Reviewed by Dimitri Glazkov.
981 Fixing Chromium's POSIX VFS implementation, by adding the required
982 "used file descriptors" logic.
984 https://bugs.webkit.org/show_bug.cgi?id=31275
986 * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
988 2009-11-11 Chris Fleizach <cfleizach@apple.com>
990 Reviewed by Oliver Hunt.
992 need to implement aria tree roles
993 https://bugs.webkit.org/show_bug.cgi?id=31284
995 Tests: platform/mac/accessibility/aria-multiselectable.html
996 platform/mac/accessibility/aria-tree.html
998 * accessibility/AccessibilityList.cpp:
999 (WebCore::AccessibilityList::accessibilityIsIgnored):
1000 * accessibility/AccessibilityObject.cpp:
1001 (WebCore::AccessibilityObject::ariaTreeRows):
1002 (WebCore::AccessibilityObject::ariaTreeItemContent):
1003 (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
1004 * accessibility/AccessibilityObject.h:
1006 (WebCore::AccessibilityObject::isTree):
1007 (WebCore::AccessibilityObject::isTreeItem):
1008 (WebCore::AccessibilityObject::setIsExpanded):
1009 (WebCore::AccessibilityObject::canSetExpandedAttribute):
1010 (WebCore::AccessibilityObject::hierarchicalLevel):
1011 (WebCore::AccessibilityObject::setSelectedRows):
1012 (WebCore::AccessibilityObject::performDefaultAction):
1013 * accessibility/AccessibilityRenderObject.cpp:
1014 (WebCore::AccessibilityRenderObject::hierarchicalLevel):
1015 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1016 (WebCore::AccessibilityRenderObject::isExpanded):
1017 (WebCore::AccessibilityRenderObject::setElementAttributeValue):
1018 (WebCore::AccessibilityRenderObject::elementAttributeValue):
1019 (WebCore::AccessibilityRenderObject::setIsExpanded):
1020 (WebCore::AccessibilityRenderObject::isSelected):
1021 (WebCore::AccessibilityRenderObject::setSelected):
1022 (WebCore::AccessibilityRenderObject::setSelectedRows):
1023 (WebCore::createARIARoleMap):
1024 (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
1025 (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
1026 (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
1027 (WebCore::AccessibilityRenderObject::selectedChildren):
1028 * accessibility/AccessibilityRenderObject.h:
1029 * accessibility/mac/AccessibilityObjectMac.mm:
1030 (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1031 * accessibility/mac/AccessibilityObjectWrapper.mm:
1032 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1034 (-[AccessibilityObjectWrapper subrole]):
1035 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1036 (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1037 (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
1038 (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1039 (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1040 * html/HTMLAttributeNames.in:
1042 2009-11-11 Brent Fulgham <bfulgham@webkit.org>
1044 Build fix after @r50760 with ENABLE_FILTERS.
1046 * platform/graphics/filters/SourceAlpha.cpp:
1047 (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
1048 * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
1051 2009-11-11 Fumitoshi Ukai <ukai@chromium.org>
1053 Reviewed by Alexey Proskuryakov.
1055 Fix WebSocket frame parser of frame_type with high-order bit set.
1056 https://bugs.webkit.org/show_bug.cgi?id=30668
1058 If buffer is smaller than frame's length, it should break the loop
1059 instead of reading next byte.
1061 Tests: websocket/tests/frame-length-longer-than-buffer.html
1062 websocket/tests/frame-length-skip.html
1064 * websockets/WebSocketChannel.cpp:
1065 (WebCore::WebSocketChannel::didReceiveData):
1067 2009-11-11 Yusuke Sato <yusukes@chromium.org>
1069 Reviewed by Adam Barth.
1071 [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
1072 https://bugs.webkit.org/show_bug.cgi?id=31345
1074 Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
1076 * platform/graphics/chromium/FontCustomPlatformData.cpp:
1077 (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
1078 (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
1079 (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
1081 2009-11-11 Beth Dakin <bdakin@apple.com>
1083 Build fix. No review needed.
1085 * platform/graphics/gtk/FontGtk.cpp:
1086 (WebCore::Font::drawComplexText):
1088 2009-11-11 Beth Dakin <bdakin@apple.com>
1090 Build fix. No review needed.
1092 * platform/graphics/cairo/FontCairo.cpp:
1093 (WebCore::Font::drawGlyphs):
1095 2009-11-11 Beth Dakin <bdakin@apple.com>
1097 Windows build fix. No review needed.
1099 * platform/graphics/win/FontCGWin.cpp:
1100 (WebCore::Font::drawGlyphs):
1102 2009-11-11 Beth Dakin <bdakin@apple.com>
1104 Reviewed by Simon Fraser.
1106 Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
1107 Make -webkit-color-correction work with shadows
1109 From canvas, just send DeviceColorSpace to setShadow() for now.
1110 Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
1111 * html/canvas/CanvasRenderingContext2D.cpp:
1112 (WebCore::CanvasRenderingContext2D::setShadow):
1113 (WebCore::CanvasRenderingContext2D::applyShadow):
1115 setShadow() and setPlatformShadow() now take a ColorSpace.
1116 * platform/graphics/GraphicsContext.cpp:
1117 (WebCore::GraphicsContext::setShadow):
1118 * platform/graphics/GraphicsContext.h:
1119 * platform/graphics/cg/GraphicsContextCG.cpp:
1120 (WebCore::createCGColorWithColorSpace): New helper to create a
1121 color in a ColorSpace.
1122 (WebCore::setCGFillColor): Call new helper.
1123 (WebCore::setCGStrokeColor): Call new helper.
1124 (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
1125 * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1126 (WebCore::GraphicsContext::setPlatformShadow):
1128 Send appropriate ColorSpace to setShadow().
1129 * platform/graphics/mac/FontMac.mm:
1130 (WebCore::Font::drawGlyphs):
1131 * rendering/EllipsisBox.cpp:
1132 (WebCore::EllipsisBox::paint):
1133 * rendering/InlineFlowBox.cpp:
1134 (WebCore::InlineFlowBox::paintTextDecorations):
1135 * rendering/InlineTextBox.cpp:
1136 (WebCore::paintTextWithShadows):
1137 (WebCore::InlineTextBox::paintDecoration):
1138 * rendering/RenderBoxModelObject.cpp:
1139 (WebCore::RenderBoxModelObject::paintBoxShadow):
1140 * rendering/SVGInlineTextBox.cpp:
1141 (WebCore::SVGInlineTextBox::paintCharacters):
1142 * rendering/SVGRenderSupport.cpp:
1143 (WebCore::SVGRenderBase::prepareToRenderSVGContent):
1145 Attempt to keep ports building.
1146 * platform/graphics/cairo/GraphicsContextCairo.cpp:
1147 (WebCore::GraphicsContext::setPlatformShadow):
1148 * platform/graphics/qt/GraphicsContextQt.cpp:
1149 (WebCore::GraphicsContext::setPlatformShadow):
1150 * platform/graphics/skia/GraphicsContextSkia.cpp:
1151 (WebCore::GraphicsContext::setPlatformShadow):
1152 * platform/graphics/wince/GraphicsContextWince.cpp:
1153 (WebCore::GraphicsContext::setPlatformShadow):
1154 * platform/graphics/wx/GraphicsContextWx.cpp:
1155 (WebCore::GraphicsContext::setPlatformShadow):
1157 2009-11-11 Kent Tamura <tkent@chromium.org>
1159 Reviewed by Darin Adler.
1161 Print the file text of a file upload control in DumpRenderTree for ease of tests.
1162 https://bugs.webkit.org/show_bug.cgi?id=31195
1164 * rendering/RenderFileUploadControl.cpp:
1165 (WebCore::RenderFileUploadControl::paintObject):
1166 (WebCore::RenderFileUploadControl::fileTextValue):
1167 * rendering/RenderFileUploadControl.h:
1168 (WebCore::RenderFileUploadControl::isFileUploadControl):
1169 (WebCore::toRenderFileUploadControl):
1170 * rendering/RenderObject.h:
1171 (WebCore::RenderObject::isFileUploadControl):
1172 * rendering/RenderTreeAsText.cpp:
1173 (WebCore::operator<<):
1175 2009-11-11 Gavin Barraclough <barraclough@apple.com>
1177 Reviewed by Sam Weinig.
1179 DOM Wrappers for some nodes may not be marked.
1180 https://bugs.webkit.org/show_bug.cgi?id=31380
1182 Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
1183 the wrapper for the current world only. This means that wrappers may be GC'ed
1184 prematurely, and properties lost.
1186 Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
1188 * bindings/js/JSAttrCustom.cpp:
1189 (WebCore::JSAttr::markChildren):
1190 * bindings/js/JSDOMBinding.cpp:
1191 (WebCore::markDOMNodeWrapper):
1192 * bindings/js/JSDOMBinding.h:
1193 * bindings/js/JSNamedNodeMapCustom.cpp:
1194 (WebCore::JSNamedNodeMap::markChildren):
1195 * bindings/js/JSNodeCustom.cpp:
1196 (WebCore::JSNode::markChildren):
1197 * bindings/js/JSSVGElementInstanceCustom.cpp:
1198 (WebCore::JSSVGElementInstance::markChildren):
1199 * bindings/js/JSStyleSheetCustom.cpp:
1200 (WebCore::JSStyleSheet::markChildren):
1202 2009-11-11 Ben Murdoch <benm@google.com>
1204 Reviewed by Darin Adler.
1206 bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1207 https://bugs.webkit.org/show_bug.cgi?id=31384
1209 No functionality change so no tests required.
1211 * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1213 2009-11-11 Jens Alfke <snej@chromium.org>
1215 Reviewed by Dimitri Glazkov.
1217 The Big De-Inlining. 450k code size reduction (32-bit x86.)
1218 - Various inline functions in V8Binding.h made non-inline.
1219 - Some renaming for consistency.
1220 - New function createRawTemplate().
1221 https://bugs.webkit.org/show_bug.cgi?id=31383
1223 * bindings/scripts/CodeGeneratorV8.pm:
1224 * bindings/v8/V8Binding.cpp:
1225 (WebCore::v8DOMWrapperToNative):
1226 (WebCore::v8ValueToWebCoreString):
1227 (WebCore::v8ValueToAtomicWebCoreString):
1229 (WebCore::toWebCoreString):
1230 (WebCore::toWebCoreStringWithNullCheck):
1231 (WebCore::toAtomicWebCoreStringWithNullCheck):
1232 (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1233 (WebCore::isUndefinedOrNull):
1234 (WebCore::v8Boolean):
1235 (WebCore::v8UndetectableString):
1236 (WebCore::v8StringOrNull):
1237 (WebCore::v8StringOrUndefined):
1238 (WebCore::v8StringOrFalse):
1239 (WebCore::v8StringToWebCoreString):
1240 (WebCore::v8ExternalString):
1241 (WebCore::createRawTemplate): New function.
1242 * bindings/v8/V8Binding.h:
1243 (WebCore::v8DOMWrapperTo):
1244 (WebCore::v8DOMWrapperToNode):
1245 (WebCore::v8StringToWebCoreString):
1246 (WebCore::v8StringToAtomicWebCoreString):
1248 2009-11-11 Jens Alfke <snej@chromium.org>
1250 Reviewed by Dimitri Glazkov.
1252 More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1253 event-listener setter into a new subroutine transferHiddenDependency().
1254 https://bugs.webkit.org/show_bug.cgi?id=31377
1256 * bindings/scripts/CodeGeneratorV8.pm: Replace boilerplate with call to transferHiddenDependency().
1257 * bindings/v8/V8Utilities.cpp:
1258 (WebCore::transferHiddenDependency): New.
1259 * bindings/v8/V8Utilities.h: Declaration of transferHiddenDependency.
1261 2009-11-11 Brian Weinstein <bweinstein@apple.com>
1263 Reviewed by Beth Dakin.
1265 If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1266 because there is a CG bug preventing this from working.
1268 * platform/graphics/cg/GraphicsContextCG.cpp:
1269 (WebCore::sRGBColorSpaceRef):
1271 2009-11-11 Pavel Feldman <pfeldman@chromium.org>
1273 Reviewed by Timothy Hatcher.
1275 Check that if Storage panel exists before calling its methods
1277 https://bugs.webkit.org/show_bug.cgi?id=31343
1279 * inspector/front-end/inspector.js:
1280 (WebInspector.addDatabase):
1281 (WebInspector.addCookieDomain):
1282 (WebInspector.addDOMStorage):
1283 (WebInspector.updateDOMStorage):
1285 2009-11-11 Jens Alfke <snej@chromium.org>
1287 Reviewed by Dimitri Glazkov.
1289 De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1290 times in the generated V8 bindings.
1291 https://bugs.webkit.org/show_bug.cgi?id=31368
1293 * bindings/v8/V8DOMWrapper.cpp:
1294 (WebCore::V8DOMWrapper::convertNodeToV8Object): Moved body here from .h file
1295 * bindings/v8/V8DOMWrapper.h: Removed inline method body.
1297 2009-11-11 Jessie Berlin <jberlin@webkit.org>
1299 Reviewed by Timothy Hatcher.
1301 Display the correct summary in the web inspector for the shorthands
1302 border-color, border-width, border-style, margin, and padding.
1303 https://bugs.webkit.org/show_bug.cgi?id=7987
1305 Test: fast/css/shorthands-four-values.html
1307 * css/CSSMutableStyleDeclaration.cpp:
1308 (WebCore::CSSMutableStyleDeclaration::get4Values):
1309 Display the summary information in the same way the shorthand would be
1310 specified in a css rule.
1312 2009-11-11 Jens Alfke <snej@chromium.org>
1314 Reviewed by Dimitri Glazkov.
1316 Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1317 meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1318 https://bugs.webkit.org/show_bug.cgi?id=31367
1320 * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1322 2009-11-11 Jens Alfke <snej@chromium.org>
1324 Reviewed by Dimitri Glazkov.
1326 Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1328 * bindings/v8/DOMData.cpp:
1329 (WebCore::DOMData::getCurrent): Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1330 so it can be inlined by its caller.
1331 * bindings/v8/DOMData.h:
1332 * bindings/v8/MainThreadDOMData.cpp:
1333 (WebCore::MainThreadDOMData::getCurrent): Moved here from DOMData.cpp.
1334 (WebCore::MainThreadDOMData::getMainThreadStore): Added UNLIKELY macro to improve codegen.
1335 (WebCore::MainThreadDOMData::getCurrentMainThreadStore): Combination of getCurrentMainThread
1336 and getStore, which inline both calls together.
1337 * bindings/v8/MainThreadDOMData.h:
1338 (WebCore::MainThreadDOMData::getStore): Broke out nonvirtual getMainThreadStore for inlineability.
1339 * bindings/v8/V8DOMMap.cpp:
1340 (WebCore::getDOMNodeMap): Call new getCurrentMainThreadStore, which is faster.
1342 2009-11-11 Nate Chapin <japhet@chromium.org>
1344 Reviewed by Dimitri Glazkov.
1346 Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1348 https://bugs.webkit.org/show_bug.cgi?id=31357
1350 * platform/KURLGoogle.cpp:
1351 (WebCore::isSchemeFirstChar):
1352 (WebCore::isSchemeChar):
1353 (WebCore::KURL::hasPort):
1354 (WebCore::KURL::removePort):
1355 (WebCore::protocolIsValid):
1357 2009-11-11 Brent Fulgham <bfulgham@webkit.org>
1359 Build fix, no reviewed.
1361 Correct setPlatformFillColor and setPlatformStrokeColor calls
1362 to match new ColorSpace-supporting signatures.
1364 * platform/graphics/win/GraphicsContextCairoWin.cpp: Add the
1365 color space to the set[...]Color calls.
1367 2009-11-10 Alexey Proskuryakov <ap@apple.com>
1369 Reviewed by Sam Weinig.
1371 https://bugs.webkit.org/show_bug.cgi?id=31327
1372 Clean up SocketStreamHandleClient interface
1374 No change in behavior.
1376 * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1377 (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1378 the only client (WebSocketChannel), and it's not clear what this callback's semantics
1380 (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1381 (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1382 For ResourceHandle, this method is called when the user cancels authentication sheet,
1383 not when something happens with the stream.
1385 * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1386 reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1388 * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1389 callbacks have no real implementation yet.
1391 2009-11-11 Zoltan Horvath <zoltan@webkit.org>
1393 Reviewed by Eric Seidel.
1395 Allow custom memory allocation control for the part of page directory in WebCore
1396 https://bugs.webkit.org/show_bug.cgi?id=31350
1398 Inherits the following classes from Noncopyable because these are instantiated
1399 by 'new' and these are no need to be copyable:
1401 class DragController - instantiated at: WebCore/page/Page.cpp:107
1402 class FocusController - instantiated at: WebCore/page/Page.cpp:109
1403 class Settings - instantiated at: WebCore/page/Page.cpp:116
1404 class PluginHalter - instantiated at: WebCore/page/Page.cpp:160
1405 struct ScheduledEvent - instantiated at: WebCore/page/FrameView.cpp:1275
1406 class UserScript - instantiated at: WebCore/page/PageGroup.cpp:208
1407 struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1408 class XSSAuditor - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1409 class UserStyleSheet - instantiated at: WebCore/page/PageGroup.cpp:222
1411 Inherits PropertyWrapperBase class from Noncopyable because (its child class)
1412 PropertyWrapper is instantiated by 'new' in
1413 WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1415 * page/DragController.h:
1416 * page/EventHandler.h:
1417 * page/FocusController.h:
1418 * page/FrameView.cpp:
1419 * page/PluginHalter.h:
1421 * page/UserScript.h:
1422 * page/UserStyleSheet.h:
1423 * page/XSSAuditor.h:
1424 * page/animation/AnimationBase.cpp:
1426 2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1428 Reviewed by Kenneth Rohde Christiansen.
1430 https://bugs.webkit.org/show_bug.cgi?id=31323
1431 Fix a few compiler warnings
1433 No new tests as there is no new functionality.
1435 * editing/htmlediting.cpp:
1436 (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1437 parentheses to silence gcc 4.4 -Wparentheses warnings
1439 2009-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
1441 Reviewed by Mark Rowe.
1443 Set m_hasPendingGeometryChange to true by default, so that
1444 at least one call to NPP_SetWindow is executed, which is
1445 needed by the DRT plugin testing framework.
1447 * plugins/PluginView.cpp:
1448 (WebCore::PluginView::PluginView):
1450 2009-11-11 Csaba Osztrogonác <ossy@webkit.org>
1452 Rubber-stamped by Kenneth Rohde Christiansen.
1454 https://bugs.webkit.org/show_bug.cgi?id=31348
1455 [Qt] Remove unnecessary LUT creator from WebCore.pro
1459 2009-11-11 Simon Hausmann <simon.hausmann@nokia.com>
1461 Reviewed by Tor Arne Vestbø.
1463 Introduce a function for querying the input method status
1466 * platform/qt/QWebPageClient.h:
1468 2009-11-11 Benjamin Otte <otte@gnome.org>
1470 Reviewed by Jan Alonzo.
1472 [GTK] Black artifacts in youtube.com/html5
1474 Paint the video to the given size. It's the job of the callers to keep
1475 track of aspect ratio. RenderVideo.cpp does it for the <video>
1477 https://bugs.webkit.org/show_bug.cgi?id=30925
1479 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1480 (WebCore::MediaPlayerPrivate::paint):
1482 2009-11-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>
1484 Reviewed by Reviewed by Jan Alonzo.
1486 https://bugs.webkit.org/show_bug.cgi?id=30901
1487 [Gtk] Need to de-lint the Atk a11y code
1489 Cleaned up some missed capitalization style-guideline violations.
1491 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1493 2009-11-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
1495 Reviewed by Eric Seidel.
1497 [Qt] Make the default style background color valid.
1498 Currently the color is transparent but invalid, this causes
1499 list boxes in QtWebKit to be drawn with a black background
1501 https://bugs.webkit.org/show_bug.cgi?id=31295
1503 * rendering/style/RenderStyle.h:
1504 (WebCore::InheritedFlags::initialBackgroundColor):
1505 * rendering/style/StyleBackgroundData.cpp:
1506 (WebCore::StyleBackgroundData::StyleBackgroundData):
1508 2009-11-10 Gavin Barraclough <barraclough@apple.com>
1510 Reviewed by Geoff Garen.
1512 Simplify the ownership model for worlds - rather than having a pair of weak references
1513 between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1514 ref pointer to the former. This reduces complexity & cost of the caching entries in the
1518 * bindings/js/JSDOMBinding.cpp:
1519 (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1520 * bindings/js/JSDOMBinding.h:
1521 (WebCore::DOMWrapperWorld::forgetDocument):
1522 * bindings/js/ScriptCachedFrameData.cpp:
1523 (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1524 (WebCore::ScriptCachedFrameData::restore):
1525 (WebCore::ScriptCachedFrameData::clear):
1526 * bindings/js/ScriptCachedFrameData.h:
1527 * bindings/js/ScriptController.cpp:
1528 (WebCore::ScriptController::~ScriptController):
1529 (WebCore::ScriptController::clearWindowShell):
1530 (WebCore::ScriptController::initScript):
1531 (WebCore::ScriptController::updateDocument):
1532 * bindings/js/ScriptController.h:
1534 2009-11-10 Shinichiro Hamaji <hamaji@chromium.org>
1536 Reviewed by Darin Adler.
1538 rename counter to makeCounterNode in RenderCounter.cpp
1539 https://bugs.webkit.org/show_bug.cgi?id=31289
1541 No new test because this is just a small refactoring.
1543 * rendering/RenderCounter.cpp:
1544 (WebCore::findPlaceForCounter):
1545 (WebCore::makeCounterNode):
1546 (WebCore::RenderCounter::originalText):
1548 2009-11-10 Daniel Bates <dbates@webkit.org>
1550 Reviewed by Oliver Hunt.
1552 https://bugs.webkit.org/show_bug.cgi?id=30754
1556 Removed method EventHandler::dragSourceMovedTo, since it is no longer
1557 needed. This method fired a drag event whenever the mouse moved, but
1558 section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1559 model independent of when the mouse moves. See "Among other changes..."
1560 in the change log for patch 1 for more details.
1562 * WebCore.DragSupport.exp:
1563 * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1564 (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1565 * page/EventHandler.h:
1567 2009-11-10 Daniel Bates <dbates@webkit.org>
1569 Reviewed by Oliver Hunt.
1571 https://bugs.webkit.org/show_bug.cgi?id=30754
1575 As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1576 the drag event should always fire before the dragover event.
1578 In fixing this bug, this patch also makes our drag processing model
1579 conform to the HTML 5 spec.
1581 Among the changes, this patch ensures that the drag event isn't fired outside
1582 of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1583 Currently, the drag event is fired whenever the mouse button is down and the OS
1584 detects the mouse moved. But, as per the spec, the drag event should
1585 fire approx. every 350ms so long as the mouse button is down.
1587 Test: fast/events/drag-and-drop-fire-drag-dragover.html
1589 * page/EventHandler.cpp:
1590 (WebCore::EventHandler::clear):
1591 (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1592 Modified to determine when we are in the correct instance of EventHandler to service the drag
1594 (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1596 (WebCore::EventHandler::cancelDragAndDrop):
1597 (WebCore::EventHandler::performDragAndDrop):
1598 (WebCore::EventHandler::clearDragState):
1599 * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1600 we should fire both drag and dragover events or only the dragover event.
1602 2009-11-10 Vitaly Repeshko <vitalyr@chromium.org>
1604 Reviewed by Dimitri Glazkov.
1606 [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1607 https://bugs.webkit.org/show_bug.cgi?id=31301
1609 Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1611 Allowed passing V8Proxy for the calling JS context:
1612 * bindings/v8/V8DOMWrapper.h:
1613 (WebCore::V8DOMWrapper::getXPathNSResolver):
1614 * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1615 (WebCore::V8CustomXPathNSResolver::create):
1616 (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1617 (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1618 * bindings/v8/custom/V8CustomXPathNSResolver.h:
1619 * bindings/v8/custom/V8DocumentCustom.cpp:
1620 (WebCore::CALLBACK_FUNC_DECL):
1622 2009-11-10 Yael Aharon <yael.aharon@nokia.com>
1624 Reviewed by Timothy Hatcher.
1626 Implement URL decomposition IDL attributes for HTMLAnchorElement.
1627 https://bugs.webkit.org/show_bug.cgi?id=29972.
1629 Add methods for setting different parts of the URL in href attribute.
1631 Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1632 fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1633 fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1634 fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1635 fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1636 fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1637 fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1639 * bindings/js/JSLocationCustom.cpp:
1640 (WebCore::JSLocation::setPort):
1641 * html/HTMLAnchorElement.cpp:
1642 (WebCore::parsePortFromStringPosition):
1643 (WebCore::HTMLAnchorElement::setHash):
1644 (WebCore::HTMLAnchorElement::setHost):
1645 (WebCore::HTMLAnchorElement::setHostname):
1646 (WebCore::HTMLAnchorElement::setPathname):
1647 (WebCore::HTMLAnchorElement::setPort):
1648 (WebCore::HTMLAnchorElement::setProtocol):
1649 (WebCore::HTMLAnchorElement::setSearch):
1650 * html/HTMLAnchorElement.h:
1651 * html/HTMLAnchorElement.idl:
1652 * loader/FrameLoader.cpp:
1653 (WebCore::FrameLoader::iconURL):
1654 * platform/KURL.cpp:
1655 (WebCore::KURL::removePort):
1656 (WebCore::KURL::setPort):
1657 (WebCore::KURL::prettyURL):
1658 (WebCore::protocolIsValid):
1660 (WebCore::KURL::canSetHostOrPort):
1661 (WebCore::KURL::canSetPathname):
1662 (WebCore::KURL::hasPort):
1663 * platform/network/soup/ResourceHandleSoup.cpp:
1666 2009-11-10 Nate Chapin <japhet@chromium.org>
1668 Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1670 * platform/chromium/PopupMenuChromium.cpp:
1671 (WebCore::PopupContainer::paintBorder):
1672 (WebCore::PopupListBox::paint):
1673 (WebCore::PopupListBox::paintRow):
1674 * platform/graphics/chromium/TransparencyWin.cpp:
1675 (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1676 * platform/graphics/skia/GraphicsContextSkia.cpp:
1677 (WebCore::GraphicsContext::fillRect):
1678 (WebCore::GraphicsContext::fillRoundedRect):
1679 (WebCore::GraphicsContext::setPlatformFillColor):
1680 (WebCore::GraphicsContext::setPlatformStrokeColor):
1681 * rendering/RenderMediaControlsChromium.cpp:
1682 (WebCore::paintMediaSlider):
1683 (WebCore::paintMediaVolumeSlider):
1684 (WebCore::paintMediaTimelineContainer):
1685 * rendering/RenderThemeChromiumMac.mm:
1686 (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1688 2009-11-10 Brady Eidson <beidson@apple.com>
1690 Reviewed by Sam Weinig.
1692 Repro crash saving pcmag.com article as a webarchive.
1693 <rdar://problem/7381219> and https://webkit.org/b/31322
1695 Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1697 * css/CSSStyleSheet.cpp:
1698 (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1699 of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1701 2009-11-10 Beth Dakin <bdakin@apple.com>
1703 Attempt 2 to fix Tiger build. No review needed.
1705 * platform/graphics/cg/GraphicsContextCG.cpp:
1706 (WebCore::deviceRGBColorSpaceRef):
1707 (WebCore::sRGBColorSpaceRef):
1709 2009-11-10 Kevin Ollivier <kevino@theolliviers.com>
1711 wx build fix. Changes needed after r50760.
1713 * platform/graphics/wx/GraphicsContextWx.cpp:
1714 (WebCore::GraphicsContext::GraphicsContext):
1715 * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1716 (WebCore::drawTextWithSpacing):
1718 2009-11-10 Alexey Proskuryakov <ap@apple.com>
1722 * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1723 that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1725 2009-11-10 Beth Dakin <bdakin@apple.com>
1727 Tiger build fix. No review needed.
1729 * platform/graphics/cg/GraphicsContextCG.cpp:
1730 (WebCore::sRGBColorSpaceRef):
1732 2009-11-10 Alexey Proskuryakov <ap@apple.com>
1734 Reviewed by Dan Bernstein.
1736 https://bugs.webkit.org/show_bug.cgi?id=31312
1737 Decouple authentication panel callbacks from ResourceHandle
1739 No change in functionality.
1741 SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1742 ResourceHandle as delegate.
1744 * WebCore.vcproj/WebCore.vcproj:
1745 * platform/network/AuthenticationClient.h: Added.
1746 Added a new interface for listening to authentication panel notifications.
1748 * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1749 it wants with the project file.
1751 (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1753 (WebCore::AuthenticationClient::deref): Ditto.
1755 * platform/network/ResourceHandle.h:
1756 (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1757 (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1759 * platform/network/cf/AuthenticationCF.cpp:
1760 (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1761 (WebCore::AuthenticationChallenge::platformCompare):
1762 * platform/network/cf/AuthenticationChallenge.h:
1763 (WebCore::AuthenticationChallenge::authenticationClient):
1764 * platform/network/chromium/AuthenticationChallenge.h:
1765 (WebCore::AuthenticationChallenge::authenticationClient):
1766 * platform/network/curl/AuthenticationChallenge.h:
1767 (WebCore::AuthenticationChallenge::authenticationClient):
1768 Keeping a reference to AuthenticationClient, not to ResourceHandle.
1770 2009-11-10 Beth Dakin <bdakin@apple.com>
1772 Second attempted gtk build fix. No review needed.
1774 * html/canvas/CanvasStyle.cpp:
1775 (WebCore::CanvasStyle::applyStrokeColor):
1778 2009-11-10 Gavin Barraclough <barraclough@apple.com>
1780 Reviewed by Geoff Garen.
1782 Fix back/forwards cache with JSC isolated worlds.
1783 https://bugs.webkit.org/show_bug.cgi?id=31310
1784 <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1786 Store the global object for all worlds, not just the normal world.
1787 Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1788 so we can forget global objects if a world goes away.
1790 * bindings/js/JSDOMBinding.cpp:
1791 (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1792 * bindings/js/JSDOMBinding.h:
1793 (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1794 (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1795 * bindings/js/ScriptCachedFrameData.cpp:
1796 (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1797 (WebCore::ScriptCachedFrameData::forgetWorld):
1798 (WebCore::ScriptCachedFrameData::domWindow):
1799 (WebCore::ScriptCachedFrameData::restore):
1800 (WebCore::ScriptCachedFrameData::clear):
1801 * bindings/js/ScriptCachedFrameData.h:
1802 * bindings/js/ScriptController.h:
1804 2009-11-10 Csaba Osztrogonác <ossy@webkit.org>
1806 [Qt] Unreviewed buildfix after r50760.
1808 * platform/graphics/qt/GraphicsContextQt.cpp:
1809 (WebCore::GraphicsContext::GraphicsContext):
1811 2009-11-10 Beth Dakin <bdakin@apple.com>
1813 Attempted build fix. (No review needed.)
1815 * GNUmakefile.am: Adding ColorSpace.h
1817 2009-11-10 Brian Weinstein <bweinstein@apple.com>
1819 Reviewed by NOBODY - Build Fix.
1821 Updated function calls to take a ColorSpace argument, passing
1822 in DeviceColorSpace for now - this should be fixed. Also added
1823 ColorSpace.h to WebCore project.
1825 * WebCore.vcproj/WebCore.vcproj:
1826 * platform/graphics/win/FontCGWin.cpp:
1827 (WebCore::Font::drawGlyphs):
1828 * platform/graphics/win/GraphicsContextCGWin.cpp:
1829 (WebCore::GraphicsContext::GraphicsContext):
1830 * platform/win/PopupMenuWin.cpp:
1831 (WebCore::PopupMenu::paint):
1832 * platform/win/WebCoreTextRenderer.cpp:
1833 (WebCore::doDrawTextAtPoint):
1834 * rendering/RenderThemeSafari.cpp:
1835 (WebCore::RenderThemeSafari::paintMenuListButton):
1837 2009-11-10 Jens Alfke <snej@chromium.org>
1839 Reviewed by Darin Adler.
1841 Optimizations to Element::getAttribute
1842 https://bugs.webkit.org/show_bug.cgi?id=30926
1845 (WebCore::Element::getAttribute): User case-insensitive compare instead of lowercasing the name.
1846 * dom/NamedAttrMap.cpp:
1847 (WebCore::NamedNodeMap::getAttributeItem): Avoid redundant compares, and do fast/likely compares first.
1848 * platform/text/PlatformString.h:
1849 (WebCore::equalPossiblyIgnoringCase): New inline method, used by both of the above.
1851 2009-11-10 Beth Dakin <bdakin@apple.com>
1853 Reviewed by Darin Adler.
1855 Fix for <rdar://problem/7059710>
1857 https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1858 color-correction for CSS colors
1860 New exported symbol for GraphicsContext::fillColor() which now
1861 accepts a ColorSpace as an optional parameter.
1864 Added a new file, ColorSpace.h, to define the ColorSpace enum.
1865 * WebCore.xcodeproj/project.pbxproj:
1867 Computed Style for -webkit-color-correction
1868 * css/CSSComputedStyleDeclaration.cpp:
1870 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1872 Parse -webkit-color-correction
1873 * css/CSSParser.cpp:
1874 (WebCore::CSSParser::parseValue):
1876 Map CSS identifiers to the appropriate values of the ColorSpace enum
1877 * css/CSSPrimitiveValueMappings.h:
1878 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1879 (WebCore::CSSPrimitiveValue::operator ColorSpace):
1881 New property -webkit-color-correction
1882 * css/CSSPropertyNames.in:
1884 Map -webkit-color-correction into the RenderStyle.
1885 * css/CSSStyleSelector.cpp:
1886 (WebCore::CSSStyleSelector::applyProperty):
1889 * css/CSSValueKeywords.in:
1891 Comment out the reference to sRGB since it will now be inherited as
1892 a value from CSSValueKeywords.
1893 * css/SVGCSSValueKeywords.in:
1895 Definition of the ColorSpace enum.
1896 * platform/graphics/ColorSpace.h: Added.
1899 These functions all now take a ColorSpace as a parameter.
1900 * platform/graphics/GraphicsContext.cpp:
1901 (WebCore::GraphicsContext::setStrokeColor):
1902 (WebCore::GraphicsContext::setFillColor):
1903 (WebCore::GraphicsContext::drawHighlightForText):
1905 Return the appropriate ColorSpace.
1906 (WebCore::GraphicsContext::strokeColorSpace):
1907 (WebCore::GraphicsContext::fillColorSpace):
1909 These functions all call other functions which require a ColorSpace
1911 (WebCore::GraphicsContext::setStrokePattern):
1912 (WebCore::GraphicsContext::setFillPattern):
1913 (WebCore::GraphicsContext::setStrokeGradient):
1914 (WebCore::GraphicsContext::setFillGradient):
1916 All of the GraphicsContext functions that take a Color should now
1917 also take a ColorSpace.
1918 * platform/graphics/GraphicsContext.h:
1920 Added new member variables stokeColorSpace and fillColorSpace.
1921 * platform/graphics/GraphicsContextPrivate.h:
1922 (WebCore::GraphicsContextState::GraphicsContextState):
1924 Attempt to keep the Cairo port building with all of the massive
1925 changes to GraphicsContext.
1926 * platform/graphics/cairo/GraphicsContextCairo.cpp:
1927 (WebCore::GraphicsContext::fillRect):
1928 (WebCore::GraphicsContext::setPlatformFillColor):
1929 (WebCore::GraphicsContext::setPlatformStrokeColor):
1930 (WebCore::GraphicsContext::fillRoundedRect):
1933 * platform/graphics/cg/GraphicsContextCG.cpp:
1934 (WebCore::sRGBColorSpaceRef): New static function that returns a
1935 CGColorSpaceRef for the sRGB color space.
1936 (WebCore::deviceRGBColorSpaceRef): New static function that returns
1937 a CGColorSpaceRef for the device RGB color space.
1939 (WebCore::setCGFillColor): Now takes a ColorSpace parameter and
1940 sets the fill color to the specified color in the given ColorSpace.
1941 (WebCore::setCGStrokeColor): Same, but for stroke.
1943 (WebCore::setCGFillColorSpace): New static to set the
1944 CGFillColorSpace to the given ColorSpace
1945 (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1947 Send ColorSpaces when appropriate, set ColorSpaces when
1948 appropriate, and check ColorSpaces when appropriate.
1949 (WebCore::GraphicsContext::GraphicsContext):
1950 (WebCore::GraphicsContext::drawRect):
1951 (WebCore::GraphicsContext::drawLine):
1952 (WebCore::GraphicsContext::fillPath):
1953 (WebCore::GraphicsContext::strokePath):
1954 (WebCore::GraphicsContext::fillRect):
1955 (WebCore::GraphicsContext::fillRoundedRect):
1956 (WebCore::GraphicsContext::strokeRect):
1957 (WebCore::GraphicsContext::drawLineForText):
1958 (WebCore::GraphicsContext::setPlatformStrokeColor):
1959 (WebCore::GraphicsContext::setPlatformFillColor):
1961 Attempt to keep Haiku building.
1962 * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1963 (WebCore::GraphicsContext::fillRect):
1964 (WebCore::GraphicsContext::fillRoundedRect):
1965 (WebCore::GraphicsContext::setPlatformStrokeColor):
1966 (WebCore::GraphicsContext::setPlatformFillColor):
1968 Attempt to keep QT building.
1969 * platform/graphics/qt/GraphicsContextQt.cpp:
1970 (WebCore::GraphicsContext::fillRect):
1971 (WebCore::GraphicsContext::fillRoundedRect):
1972 (WebCore::GraphicsContext::setPlatformStrokeColor):
1973 (WebCore::GraphicsContext::setPlatformFillColor):
1975 Attempt to keep Wince building.
1976 * platform/graphics/wince/GraphicsContextWince.cpp:
1977 (WebCore::GraphicsContext::fillRect):
1978 (WebCore::GraphicsContext::setPlatformFillColor):
1979 (WebCore::GraphicsContext::setPlatformStrokeColor):
1980 (WebCore::GraphicsContext::clearRect):
1981 (WebCore::GraphicsContext::fillRoundedRect):
1982 (WebCore::GraphicsContext::setPlatformShadow):
1984 Attempt to keep WX building.
1985 * platform/graphics/wx/GraphicsContextWx.cpp:
1986 (WebCore::GraphicsContext::fillRect):
1987 (WebCore::GraphicsContext::fillRoundedRect):
1988 (WebCore::GraphicsContext::setPlatformStrokeColor):
1989 (WebCore::GraphicsContext::setPlatformFillColor):
1991 Added functions colorSpace() and setColorSpace()
1992 * rendering/style/RenderStyle.h:
1993 (WebCore::InheritedFlags::colorSpace):
1994 (WebCore::InheritedFlags::setColorSpace):
1996 The ColorSpace is stored here.
1997 * rendering/style/StyleRareInheritedData.cpp:
1998 (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1999 (WebCore::StyleRareInheritedData::operator==):
2000 * rendering/style/StyleRareInheritedData.h:
2002 All of these call sites call GraphicsContext functions which now
2003 require ColorSpaces.
2004 * editing/SelectionController.cpp:
2005 (WebCore::SelectionController::paintCaret):
2006 * html/canvas/CanvasRenderingContext2D.cpp:
2007 (WebCore::CanvasRenderingContext2D::drawTextInternal):
2008 * html/canvas/CanvasStyle.cpp:
2009 (WebCore::CanvasStyle::applyStrokeColor):
2010 (WebCore::CanvasStyle::applyFillColor):
2011 * inspector/InspectorController.cpp:
2012 (WebCore::drawOutlinedQuad):
2013 * page/FrameView.cpp:
2014 (WebCore::FrameView::paintContents):
2015 * platform/ScrollbarTheme.h:
2016 (WebCore::ScrollbarTheme::paintScrollCorner):
2017 * platform/ScrollbarThemeComposite.cpp:
2018 (WebCore::ScrollbarThemeComposite::paintScrollCorner):
2019 * platform/graphics/Image.cpp:
2020 (WebCore::Image::fillWithSolidColor):
2021 * platform/graphics/mac/FontMac.mm:
2022 (WebCore::Font::drawGlyphs):
2023 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2024 (WebCore::MediaPlayerPrivate::paint):
2025 * rendering/EllipsisBox.cpp:
2026 (WebCore::EllipsisBox::paint):
2027 * rendering/InlineFlowBox.cpp:
2028 (WebCore::InlineFlowBox::paintTextDecorations):
2029 * rendering/InlineTextBox.cpp:
2030 (WebCore::updateGraphicsContext):
2031 (WebCore::paintTextWithShadows):
2032 (WebCore::InlineTextBox::paint):
2033 (WebCore::InlineTextBox::paintSelection):
2034 (WebCore::InlineTextBox::paintCompositionBackground):
2035 (WebCore::InlineTextBox::paintDecoration):
2036 (WebCore::InlineTextBox::paintTextMatchMarker):
2037 (WebCore::InlineTextBox::paintCompositionUnderline):
2038 * rendering/InlineTextBox.h:
2039 * rendering/RenderBlock.cpp:
2040 (WebCore::RenderBlock::fillHorizontalSelectionGap):
2041 (WebCore::RenderBlock::fillVerticalSelectionGap):
2042 (WebCore::RenderBlock::fillLeftSelectionGap):
2043 (WebCore::RenderBlock::fillRightSelectionGap):
2044 * rendering/RenderBoxModelObject.cpp:
2045 (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2046 (WebCore::RenderBoxModelObject::paintBoxShadow):
2047 * rendering/RenderFileUploadControl.cpp:
2048 (WebCore::RenderFileUploadControl::paintObject):
2049 * rendering/RenderFrameSet.cpp:
2050 (WebCore::RenderFrameSet::paintColumnBorder):
2051 (WebCore::RenderFrameSet::paintRowBorder):
2052 * rendering/RenderImage.cpp:
2053 (WebCore::RenderImage::paintReplaced):
2054 * rendering/RenderLayer.cpp:
2055 (WebCore::RenderLayer::paintScrollCorner):
2056 (WebCore::RenderLayer::paintResizer):
2057 * rendering/RenderListBox.cpp:
2058 (WebCore::RenderListBox::paintItemForeground):
2059 (WebCore::RenderListBox::paintItemBackground):
2060 * rendering/RenderListMarker.cpp:
2061 (WebCore::RenderListMarker::paint):
2062 * rendering/RenderObject.cpp:
2063 (WebCore::RenderObject::drawLineForBoxSide):
2064 (WebCore::RenderObject::drawArcForBoxSide):
2065 * rendering/RenderReplaced.cpp:
2066 (WebCore::RenderReplaced::paint):
2067 * rendering/RenderScrollbarTheme.cpp:
2068 (WebCore::RenderScrollbarTheme::paintScrollCorner):
2069 * rendering/RenderThemeMac.mm:
2070 (WebCore::RenderThemeMac::paintMenuListButton):
2071 * rendering/RenderView.cpp:
2072 (WebCore::RenderView::paintBoxDecorations):
2073 * rendering/RenderWidget.cpp:
2074 (WebCore::RenderWidget::paint):
2075 * rendering/SVGInlineTextBox.cpp:
2076 (WebCore::SVGInlineTextBox::paintSelection):
2077 * svg/graphics/SVGPaintServerGradient.cpp:
2078 (WebCore::SVGPaintServerGradient::setup):
2079 * svg/graphics/SVGPaintServerSolid.cpp:
2080 (WebCore::SVGPaintServerSolid::setup):
2082 2009-11-10 Keishi Hattori <casey.hattori@gmail.com>
2084 Reviewed by Timothy Hatcher.
2086 Web Inspector: Speed up syntax highlighter
2087 https://bugs.webkit.org/show_bug.cgi?id=31291
2089 * inspector/front-end/SourceFrame.js:
2090 (WebInspector.SourceFrame.prototype._loaded):
2091 (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
2092 (WebInspector.SourceSyntaxHighlighter.prototype.process):
2093 (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
2094 (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
2095 (WebInspector.CSSSourceSyntaxHighlighter):
2096 (WebInspector.JavaScriptSourceSyntaxHighlighter):
2098 2009-11-09 Jeremy Orlow <jorlow@chromium.org>
2100 Reviewed by Eric Seidel.
2102 Remove session storage setting
2103 https://bugs.webkit.org/show_bug.cgi?id=31279
2105 Remove session storage from Settings. It was added temporarily so we could
2106 disable it by default at runtime in Chromium. We now disable these things in a
2107 different way, so it's time to remove it. Qt also depended on this setting for
2108 a short period of time, but after talking to them we agreed that it should be
2111 This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
2113 * page/DOMWindow.cpp:
2114 (WebCore::DOMWindow::sessionStorage):
2115 * page/Settings.cpp:
2116 (WebCore::Settings::Settings):
2119 2009-11-10 Dan Bernstein <mitz@apple.com>
2121 Reviewed by Eric Carlson and Darin Adler.
2123 WebCore part of making full-screen video pause during scrubbing.
2125 * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
2126 and HTMLMediaElement::endScrubbing().
2128 2009-11-10 Anton Muhin <antonm@chromium.org>
2130 Reviewed by Adam Barth.
2132 Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
2133 https://bugs.webkit.org/show_bug.cgi?id=31051
2135 * bindings/v8/V8GCController.cpp:
2136 (WebCore::V8GCController::gcEpilogue):
2137 (WebCore::V8GCController::checkMemoryUsage):
2138 * bindings/v8/V8GCController.h:
2139 * bindings/v8/V8Proxy.cpp:
2140 (WebCore::V8Proxy::evaluate):
2141 (WebCore::V8Proxy::runScript):
2142 (WebCore::V8Proxy::callFunction):
2144 2009-11-10 Zoltan Horvath <zoltan@webkit.org>
2146 Reviewed by Darin Adler.
2148 Allow custom memory allocation control for the part of loader directory in WebCore
2149 https://bugs.webkit.org/show_bug.cgi?id=31161
2151 Inherits the following classes from Noncopyable because these are instantiated
2152 by 'new' and these are no need to be copyable:
2154 class Request - WebCore/loader/loader.cpp:100
2155 struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2156 class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2157 class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
2158 class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2159 struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2161 Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2162 MainThreadBridge is instantiated by 'new' in
2163 WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2165 ThreadableLoaderClient's inheriting has been changed to public.
2167 * loader/ImageLoader.cpp:
2168 * loader/ProgressTracker.cpp:
2169 * loader/RedirectScheduler.cpp:
2171 * loader/ThreadableLoaderClient.h:
2172 * loader/WorkerThreadableLoader.h:
2173 * loader/appcache/ApplicationCacheHost.h:
2174 * loader/appcache/ApplicationCacheStorage.h:
2176 2009-11-10 Philippe Normand <pnormand@igalia.com>
2178 Reviewed by Eric Seidel.
2180 https://bugs.webkit.org/show_bug.cgi?id=31047
2181 [GTK] Failing test media/video-played-ranges-1.html
2183 WebKit coding style fixes.
2185 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2186 (WebCore::mediaPlayerPrivateMessageCallback):
2187 (WebCore::MediaPlayerPrivate::naturalSize):
2188 (WebCore::MediaPlayerPrivate::paint):
2189 (WebCore::mimeTypeCache):
2191 2009-11-10 Oliver Hunt <oliver@apple.com>
2193 Remove build failure introduced by earlier build fix.
2195 * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2197 2009-11-10 Oliver Hunt <oliver@apple.com>
2199 Is this the last build fix? grep tells me yes.
2201 * bindings/v8/custom/V8DocumentCustom.cpp:
2202 (WebCore::CALLBACK_FUNC_DECL):
2204 2009-11-10 Oliver Hunt <oliver@apple.com>
2206 Hopefully the last one. Why aren't these autogenerated?
2208 * bindings/v8/V8DOMWrapper.cpp:
2209 (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2210 (WebCore::V8DOMWrapper::getTemplate):
2211 (WebCore::V8DOMWrapper::convertToV8Object):
2213 2009-11-10 Oliver Hunt <oliver@apple.com>
2215 Another chrome build fix.
2217 * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2218 (WebCore::CALLBACK_FUNC_DECL):
2220 2009-11-10 Oliver Hunt <oliver@apple.com>
2222 Yet another chrome buildfix
2224 * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2225 (WebCore::CALLBACK_FUNC_DECL):
2226 * bindings/v8/custom/V8WebGLArrayCustom.h:
2227 (WebCore::constructCanvasArray):
2228 * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2229 (WebCore::CALLBACK_FUNC_DECL):
2230 (WebCore::INDEXED_PROPERTY_GETTER):
2231 (WebCore::INDEXED_PROPERTY_SETTER):
2232 * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2233 (WebCore::CALLBACK_FUNC_DECL):
2234 (WebCore::INDEXED_PROPERTY_GETTER):
2235 (WebCore::INDEXED_PROPERTY_SETTER):
2236 * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2237 (WebCore::CALLBACK_FUNC_DECL):
2238 (WebCore::INDEXED_PROPERTY_GETTER):
2239 (WebCore::INDEXED_PROPERTY_SETTER):
2240 * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2241 (WebCore::CALLBACK_FUNC_DECL):
2242 (WebCore::vertexAttribAndUniformHelperf):
2243 (WebCore::uniformHelperi):
2244 (WebCore::uniformMatrixHelper):
2245 * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2246 (WebCore::CALLBACK_FUNC_DECL):
2247 (WebCore::INDEXED_PROPERTY_GETTER):
2248 (WebCore::INDEXED_PROPERTY_SETTER):
2249 * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2250 (WebCore::CALLBACK_FUNC_DECL):
2251 (WebCore::INDEXED_PROPERTY_GETTER):
2252 (WebCore::INDEXED_PROPERTY_SETTER):
2253 * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2254 (WebCore::CALLBACK_FUNC_DECL):
2255 (WebCore::INDEXED_PROPERTY_GETTER):
2256 (WebCore::INDEXED_PROPERTY_SETTER):
2257 * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2258 (WebCore::CALLBACK_FUNC_DECL):
2259 (WebCore::INDEXED_PROPERTY_GETTER):
2260 (WebCore::INDEXED_PROPERTY_SETTER):
2262 2009-11-10 Oliver Hunt <oliver@apple.com>
2266 * bindings/v8/V8Index.h:
2268 2009-11-10 Joanmarie Diggs <joanmarie.diggs@gmail.com>
2270 Reviewed by Reviewed by Jan Alonzo.
2272 https://bugs.webkit.org/show_bug.cgi?id=30901
2273 [Gtk] Need to de-lint the Atk a11y code
2275 Removal of various and sundry style-violating nits.
2277 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2279 2009-11-10 Philippe Normand <pnormand@igalia.com>
2281 Reviewed by Jan Alonzo.
2283 https://bugs.webkit.org/show_bug.cgi?id=31047
2284 [GTK] Failing test media/video-played-ranges-1.html
2286 Fix playback rate setter by remembering the rate was changed. Also
2287 correctly handle reverse playback by doing a seek from end to
2288 beginning of the media.
2290 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2291 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2292 (WebCore::MediaPlayerPrivate::currentTime):
2293 (WebCore::MediaPlayerPrivate::seek):
2294 (WebCore::MediaPlayerPrivate::hasAudio):
2295 (WebCore::MediaPlayerPrivate::setVolume):
2296 (WebCore::MediaPlayerPrivate::setRate):
2297 (WebCore::MediaPlayerPrivate::updateStates):
2298 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2300 2009-11-10 Oliver Hunt <oliver@apple.com>
2302 Reviewed by Maciej Stachowiak.
2304 Rename 3D Canvas related classes to use WebGL prefix
2305 https://bugs.webkit.org/show_bug.cgi?id=29095
2307 Automatic rename of all WebGL related types from Canvas* to
2308 WebGL* per more recent version of the WebGL spec.
2310 Due to the automatic rename I've removed the 600+ line change list.
2312 2009-11-09 Dirk Schulze <krit@webkit.org>
2314 Reviewed by Oliver Hunt.
2316 SVG feDisplacementMap is not implemented
2317 [https://bugs.webkit.org/show_bug.cgi?id=31255]
2319 This is the implementation of the SVG filter effect
2322 Test: svg/filters/feDisplacementMap.svg
2324 * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2325 (WebCore::FEDisplacementMap::apply):
2327 2009-11-09 Kent Tamura <tkent@chromium.org>
2329 Reviewed by Darin Adler.
2331 Add a comment about null strings and hash functions.
2332 https://bugs.webkit.org/show_bug.cgi?id=29118
2334 * platform/text/StringHash.h:
2336 2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
2338 Reviewed by Darin Adler.
2340 Compiler warnings in InspectorResource.h
2341 https://bugs.webkit.org/show_bug.cgi?id=29231
2343 Fix compilation warnings by removing addition operation on an enum type.
2345 * inspector/InspectorResource.h:
2346 (WebCore::InspectorResource::):
2347 (WebCore::InspectorResource::Changes::hasChange):
2348 (WebCore::InspectorResource::Changes::set):
2349 (WebCore::InspectorResource::Changes::setAll):
2351 2009-11-09 Anders Carlsson <andersca@apple.com>
2353 Reviewed by Darin Adler and Dan Bernstein.
2355 <rdar://problem/7328395>
2356 https://bugs.webkit.org/show_bug.cgi?id=31277
2358 When an object tag's style changes (for example when child nodes are added/removed),
2359 reuse its Frame (if it has one) instead of creating multiple Frames.
2361 Test: fast/dom/HTMLObjectElement/children-changed.html
2363 * loader/FrameLoader.cpp:
2364 (WebCore::FrameLoader::requestObject):
2366 2009-11-09 Norbert Leser <norbert.leser@nokia.com>
2368 Reviewed by Kenneth Rohde Christiansen.
2370 Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2371 since adjustment of RW-section base address will be needed for all new symbian
2372 tool chains, specifically for arm and gcc compilation targets.
2373 Also, change target address to 0xE00000 to be sufficient for all targets.
2377 2009-11-09 Pavel Feldman <pfeldman@chromium.org>
2379 Reviewed by Timothy Hatcher.
2381 Web Inspector: Crash when inspecting
2382 WebCore\manual-tests\inspector\dom-mutation.html
2384 https://bugs.webkit.org/show_bug.cgi?id=31259
2386 * inspector/InspectorDOMAgent.cpp:
2387 (WebCore::InspectorDOMAgent::handleEvent):
2389 2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2391 Reviewed by Kenneth Rohde Christiansen.
2393 [Qt] Few classes have virtual functions but non-virtual destructor
2394 https://bugs.webkit.org/show_bug.cgi?id=31269
2396 No new tests as there is no functional change.
2398 * platform/qt/QWebPageClient.h:
2399 (QWebPageClient::~QWebPageClient): Add virtual destructor.
2401 2009-11-09 Yael Aharon <yael.aharon@nokia.com>
2403 Reviewed by Kenneth Rohde Christiansen.
2405 [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2406 https://bugs.webkit.org/show_bug.cgi?id=31140
2408 QtNetwork interprets null string as request to remove the header, not add it.
2409 Replace null values with empty values before passing them to QtNetwork.
2411 Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2413 * platform/network/qt/ResourceRequestQt.cpp:
2414 (WebCore::ResourceRequest::toNetworkRequest):
2416 2009-11-09 Vadim Zeitlin <vadim@wxwidgets.org>
2418 Reviewed by Kevin Ollivier.
2420 [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2421 simply ignored before resulting in transparent areas being black in PNG
2424 https://bugs.webkit.org/show_bug.cgi?id=30823
2426 * platform/image-decoders/wx/ImageDecoderWx.cpp:
2427 (WebCore::RGBA32Buffer::asNewNativeImage):
2429 2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2431 Reviewed by Kenneth Rohde Christiansen.
2433 Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2434 https://bugs.webkit.org/show_bug.cgi?id=31040
2436 No new tests as there is no functional change.
2439 (WebCore::Document::recalcStyleSelector):
2440 * editing/TextIterator.cpp:
2441 (WebCore::pushFullyClippedState):
2442 * editing/VisibleSelection.cpp:
2443 (WebCore::VisibleSelection::appendTrailingWhitespace):
2444 * html/HTMLLinkElement.cpp:
2445 (WebCore::HTMLLinkElement::process):
2446 * loader/RedirectScheduler.cpp:
2447 (WebCore::RedirectScheduler::mustLockBackForwardList):
2448 * loader/appcache/ApplicationCacheGroup.cpp:
2449 (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2450 * platform/graphics/qt/FontCacheQt.cpp:
2451 (WebCore::FontPlatformDataCacheKey::computeHash):
2452 * rendering/RenderBlock.cpp:
2453 (WebCore::RenderBlock::handleRunInChild):
2454 * rendering/RenderBox.cpp:
2455 (WebCore::RenderBox::calcHeight):
2456 * rendering/RenderTextControlMultiLine.cpp:
2457 (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2458 * rendering/style/RenderStyle.cpp:
2459 (WebCore::RenderStyle::diff):
2460 * svg/SVGAnimateElement.cpp:
2461 (WebCore::parseNumberValueAndUnit):
2462 * svg/SVGAnimationElement.cpp:
2463 (WebCore::SVGAnimationElement::startedActiveInterval):
2464 * svg/SVGPreserveAspectRatio.cpp:
2465 (WebCore::SVGPreserveAspectRatio::getCTM):
2467 2009-11-09 Shinichiro Hamaji <hamaji@chromium.org>
2469 Reviewed by Dimitri Glazkov.
2471 Win chromium is slow to draw transparent texts
2472 https://bugs.webkit.org/show_bug.cgi?id=31258
2474 Clip graphics context to reduce calculation.
2476 No new tests because this change only affects performance.
2478 * platform/graphics/chromium/FontChromiumWin.cpp:
2479 (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2480 (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2482 2009-11-09 Carol Szabo <carol.szabo@nokia.com>
2484 Reviewed by Darin Adler.
2486 showTree(CounterNode*) generates too little info and has too many spaces.
2487 https://bugs.webkit.org/show_bug.cgi?id=31212
2489 No new tests as the change has no functional effect it is just for
2492 * rendering/CounterNode.cpp:
2493 (WebCore::showTreeAndMark):
2494 Changed to also show addresses of parent, next and previous
2497 2009-11-09 Stuart Morgan <stuartmorgan@chromium.org>
2499 Reviewed by Darin Adler.
2501 Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2502 enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2504 https://bugs.webkit.org/show_bug.cgi?id=31083
2506 No new tests; implementation is unchanged.
2509 (WebCore::Frame::setUseSecureKeyboardEntry):
2510 * page/mac/FrameMac.mm:
2512 2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2514 Reviewed by Jan Alonzo.
2516 Make XP_UNIX tests consistent
2517 https://bugs.webkit.org/show_bug.cgi?id=31250
2519 No new tests as there is no functional change.
2521 * plugins/PluginView.cpp:
2522 (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2523 instead of the value of the macro
2525 * plugins/gtk/PluginViewGtk.cpp:
2526 (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2527 defined instead of using the PLATFORM macro to be consistent
2528 (WebCore::PluginView::getValue): Ditto.
2530 2009-11-09 Kevin Watters <kevinwatters@gmail.com>
2532 Reviewed by Darin Adler.
2534 Thunk to the main thread from ~Database to deref Database's m_document.
2536 If the Database was the Document's last referrer, then ~Document occurs on the
2537 Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2538 ASSERT in debug builds.
2540 * storage/Database.cpp:
2541 (WebCore::derefDocument):
2542 (WebCore::Database::~Database):
2544 2009-11-09 Mark Mentovai <mark@chromium.org>
2546 Reviewed by Dan Bernstein.
2548 Track "can have scrollbar" state within FrameView independently of the
2549 individual scrollbar states in ScrollView.
2551 rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2552 REGRESSION (r48064): mint.com loses scrollbars after coming out of
2555 rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2556 REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2558 Test: fast/overflow/scrollbar-restored.html
2561 * page/FrameView.cpp:
2562 (WebCore::FrameView::FrameView):
2563 (WebCore::FrameView::resetScrollbars):
2564 (WebCore::FrameView::setCanHaveScrollbars):
2565 (WebCore::FrameView::updateCanHaveScrollbars):
2566 (WebCore::FrameView::layout):
2568 * platform/ScrollView.h:
2570 2009-11-09 Keishi Hattori <casey.hattori@gmail.com>
2572 Reviewed by Timothy Hatcher.
2574 Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2575 https://bugs.webkit.org/show_bug.cgi?id=31257
2577 * inspector/front-end/SourceFrame.js:
2579 2009-11-09 Alexander Pavlov <apavlov@chromium.org>
2581 Reviewed by Timothy Hatcher.
2583 Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2584 https://bugs.webkit.org/show_bug.cgi?id=31252
2586 Route F1-F12 keypresses in the Console view to the current panel if there is one.
2588 Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2590 * inspector/front-end/ConsoleView.js:
2591 (WebInspector.ConsoleView.prototype._promptKeyDown):
2592 * inspector/front-end/utilities.js:
2594 * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2596 2009-11-09 Yael Aharon <yael.aharon@nokia.com>
2598 Reviewed by Kenneth Rohde Christiansen.
2600 [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2601 https://bugs.webkit.org/show_bug.cgi?id=31208
2603 After r42483, the credentials are no longer passed to the network request
2604 in the URL of the request.
2605 Pass the credentials from XMLHTTPRequest to the network request, the same
2606 way that other ports do.
2608 After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2610 * platform/network/qt/ResourceHandleQt.cpp:
2611 (WebCore::ResourceHandle::start):
2612 (WebCore::ResourceHandle::loadResourceSynchronously):
2614 2009-11-09 Zoltan Horvath <zoltan@webkit.org>
2618 https://bugs.webkit.org/show_bug.cgi?id=31161
2620 Roll back r50657 because it breaks the MAC builds.
2622 * loader/ImageLoader.cpp:
2623 * loader/ProgressTracker.cpp:
2624 * loader/RedirectScheduler.cpp:
2626 * loader/ThreadableLoaderClient.h:
2627 * loader/WorkerThreadableLoader.h:
2628 * loader/appcache/ApplicationCacheHost.h:
2629 * loader/appcache/ApplicationCacheStorage.h:
2630 * loader/icon/IconDatabaseClient.h:
2632 2009-11-09 Zoltan Horvath <zoltan@webkit.org>
2634 Reviewed by Darin Adler.
2636 Allow custom memory allocation control for the part of loader directory in WebCore
2637 https://bugs.webkit.org/show_bug.cgi?id=31161
2639 Inherits the following classes from Noncopyable because these are instantiated
2640 by 'new' and these are no need to be copyable:
2642 class Request - WebCore/loader/loader.cpp:100
2643 struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2644 class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2645 class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2646 class ApplicationCacheHost - WebCore/loader/DocumentLoader.cpp:151
2647 class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2648 struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2650 Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2651 MainThreadBridge is instantiated by 'new' in
2652 WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2654 ThreadableLoaderClient's inheriting has been changed to public.
2656 * loader/ImageLoader.cpp:
2657 * loader/ProgressTracker.cpp:
2658 * loader/RedirectScheduler.cpp:
2660 * loader/ThreadableLoaderClient.h:
2661 * loader/WorkerThreadableLoader.h:
2662 * loader/appcache/ApplicationCacheHost.h:
2663 * loader/appcache/ApplicationCacheStorage.h:
2664 * loader/icon/IconDatabaseClient.h:
2666 2009-11-09 Zoltan Horvath <zoltan@webkit.org>
2668 Reviewed by Darin Adler.
2670 Allow custom memory allocation control for WebCore's DocLoader
2671 https://bugs.webkit.org/show_bug.cgi?id=31163
2673 Inherits DocLoader class from Noncopyable because it is
2674 instantiated by 'new' in WebCore/dom/Document.cpp:370 and
2675 it is no need to be copyable.
2677 * loader/DocLoader.h:
2679 2009-11-09 Zoltan Horvath <zoltan@webkit.org>
2681 Reviewed by Darin Adler.
2683 Allow custom memory allocation control for WebCore's Tokenizer
2684 https://bugs.webkit.org/show_bug.cgi?id=31162
2686 Inherits Tokenizer class from Noncopyable because (its child class)
2687 ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
2688 and it is no need to be copyable.
2692 2009-11-09 Zoltan Horvath <zoltan@webkit.org>
2694 Reviewed by Darin Adler.
2696 Allow custom memory allocation control for WebCore's DeleteButtonController
2697 https://bugs.webkit.org/show_bug.cgi?id=31105
2699 Inherits DeleteButtonController class from Noncopyable because it is
2700 instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2701 it is no need to be copyable.
2703 * editing/DeleteButtonController.h:
2705 2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
2707 Reviewed by Jan Alonzo.
2709 [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2710 https://bugs.webkit.org/show_bug.cgi?id=30482
2712 Expose Page::tabKeyCyclesThroughElements as a property of
2715 No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2717 * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2718 (WebCore::singleCharacterString):
2720 2009-11-09 Joanmarie Diggs <joanmarie.diggs@gmail.com>
2722 Reviewed by Xan Lopez.
2724 https://bugs.webkit.org/show_bug.cgi?id=25415
2725 [GTK][ATK] Please implement support for get_text_at_offset
2727 Fix a crasher that occurred with text which included newline
2728 chars in the markup.
2730 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2731 (convertUniCharToUTF8):
2733 2009-11-05 Jakub Wieczorek <faw217@gmail.com>
2735 Reviewed by Holger Freyther.
2737 [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2738 https://bugs.webkit.org/show_bug.cgi?id=31144
2740 XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2741 documents that end prematurely but are not considered invalid by QXmlStream.
2742 This is to stay compatible with the libxml2 implementation.
2743 However, that code path would be also hit in situations when it should not,
2744 i.e. the error would have already been caught and handled. As a result, the
2745 same error would be reported twice.
2747 No new tests, because the problem is already covered by
2748 fast/parser/xml-declaration-missing-ending-mark.html.
2750 * dom/XMLTokenizerQt.cpp:
2751 (WebCore::XMLTokenizer::doEnd):
2753 2009-11-08 Keishi Hattori <casey.hattori@gmail.com>
2755 Reviewed by Pavel Feldman.
2757 Web Inspector: Inspector should support copy() in the command line
2758 https://bugs.webkit.org/show_bug.cgi?id=31238
2760 * inspector/InspectorBackend.cpp:
2761 (WebCore::InspectorBackend::copyText): Added.
2762 * inspector/InspectorBackend.h: Added copyText
2763 * inspector/InspectorBackend.idl: Added copyText
2764 * inspector/front-end/InjectedScript.js:
2765 (InjectedScript._copy): Added.
2766 (InjectedScript._ensureCommandLineAPIInstalled):
2768 2009-11-08 Drew Wilson <atwilson@chromium.org>
2770 Reviewed by Dimitri Glazkov.
2772 V8 WorkerContextExecutionProxy does not handle SharedWorkers
2773 https://bugs.webkit.org/show_bug.cgi?id=31226
2775 Now checks to see what type of context is active and creates the
2776 appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2778 Added support for converting to SharedWorkers and SharedWorkerContexts.
2780 Test: Existing layout tests cover this case (start passing in Chrome).
2782 * bindings/v8/WorkerContextExecutionProxy.cpp:
2783 (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2784 Now generates the right type of DOMWrapper for SharedWorkerContexts.
2785 (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2786 Added support for SHAREDWORKERCONTEXT.
2787 (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2788 Added support for SharedWorker and SharedWorkerContext.
2790 2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>
2792 Reviewed by Dimitri Glazkov.
2794 https://bugs.webkit.org/show_bug.cgi?id=31224
2795 [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2797 Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2799 * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2800 (WebCore::NAMED_PROPERTY_GETTER):
2802 2009-11-08 Pavel Feldman <pfeldman@chromium.org>
2804 Reviewed by Timothy Hatcher.
2806 Web Inspector: "Search again" on scripts panel switches
2807 to the script this search started with.
2809 https://bugs.webkit.org/show_bug.cgi?id=31243
2811 * inspector/front-end/Panel.js:
2812 (WebInspector.Panel.prototype.jumpToNextSearchResult):
2814 2009-11-08 Kent Tamura <tkent@chromium.org>
2816 Reviewed by Darin Adler.
2818 Simplify Icon interface.
2819 https://bugs.webkit.org/show_bug.cgi?id=31154
2821 - Remove Icon::createIconForFile(). createIconForFiles() covers
2822 createIconForFile()'s role.
2823 - Remove FileChooser::chooseIcon()
2824 - Change the parameter types of FileChooser constructor and the
2825 factory method, String -> const Vector<String>&, in order to
2826 support initialization with multiple files.
2827 - Remove the icon loading code in IconChromiumWin.cpp, which
2828 doesn't work because of the sandbox.
2830 No tests because it's just a refactoring.
2832 * platform/FileChooser.cpp:
2833 (WebCore::FileChooser::FileChooser):
2834 (WebCore::FileChooser::create):
2835 (WebCore::FileChooser::chooseFile):
2836 (WebCore::FileChooser::chooseFiles):
2837 * platform/FileChooser.h:
2838 * platform/graphics/Icon.h:
2839 * platform/graphics/chromium/IconChromiumLinux.cpp:
2840 * platform/graphics/chromium/IconChromiumMac.cpp:
2841 * platform/graphics/chromium/IconChromiumWin.cpp:
2842 (WebCore::Icon::createIconForFiles):
2843 * platform/graphics/gtk/IconGtk.cpp:
2844 (WebCore::Icon::createIconForFiles):
2845 * platform/graphics/haiku/IconHaiku.cpp:
2846 * platform/graphics/mac/IconMac.mm:
2847 (WebCore::Icon::createIconForFiles):
2848 * platform/graphics/qt/IconQt.cpp:
2849 (WebCore::Icon::createIconForFiles):
2850 * platform/graphics/win/IconWin.cpp:
2851 (WebCore::Icon::createIconForFiles):
2852 * platform/graphics/wx/IconWx.cpp:
2853 * rendering/RenderFileUploadControl.cpp:
2854 (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2856 2009-11-08 Daniel Bates <dbates@webkit.org>
2858 Reviewed by Adam Barth.
2860 https://bugs.webkit.org/show_bug.cgi?id=31098
2862 Allows same-origin plugin-based content to load.
2864 Test: http/tests/security/xssAuditor/object-src-inject.html
2866 * page/XSSAuditor.cpp:
2867 (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2868 (WebCore::XSSAuditor::canLoadObject): Ditto.
2869 (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2870 (WebCore::XSSAuditor::isSameOriginResource): Added.
2871 * page/XSSAuditor.h:
2873 2009-11-08 David Levin <levin@chromium.org>
2875 Reviewed by NOBODY (chromium build fix).
2877 * platform/network/HTTPParsers.cpp:
2878 (WebCore::parseDate): Changed this to not
2879 use a date parser that needs ExecState passed.
2881 2009-11-08 David Levin <levin@chromium.org>
2883 Unreviewed build fix for chromium.
2885 * platform/graphics/skia/GraphicsContextSkia.cpp:
2886 (WebCore::GraphicsContext::fillPath):
2887 (WebCore::GraphicsContext::fillRect):
2888 (WebCore::GraphicsContext::strokePath):
2889 (WebCore::GraphicsContext::strokeRect):
2891 2009-11-08 David Levin <levin@chromium.org>
2893 Unreviewed build fix for chromium.
2895 Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2896 Clean up GraphicsContext's current concept of ColorSpace
2898 * platform/graphics/skia/GraphicsContextSkia.cpp:
2899 (WebCore::GraphicsContext::fillPath):
2900 (WebCore::GraphicsContext::fillRect):
2901 (WebCore::GraphicsContext::strokePath):
2902 (WebCore::GraphicsContext::strokeRect):
2904 2009-11-08 Pavel Feldman <pfeldman@chromium.org>
2906 Reviewed by Timothy Hatcher.
2908 Web Inspector: [REGRESSION] committing style edit
2909 clears elements panel selection.
2911 https://bugs.webkit.org/show_bug.cgi?id=31242
2913 * inspector/front-end/ElementsTreeOutline.js:
2914 (WebInspector.ElementsTreeOutline.prototype.update):
2915 * inspector/front-end/StylesSidebarPane.js:
2916 (WebInspector.StylePropertyTreeElement.prototype.):
2917 (WebInspector.StylePropertyTreeElement.prototype):
2919 2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
2921 Reviewed by Holger Freyther.
2923 ResourceRequest to be class instead of struct
2924 https://bugs.webkit.org/show_bug.cgi?id=30670
2926 Started as a compilation fix for Symbian where the compiler makes a distinction between
2927 class and struct in function argument signatures.
2928 Changed all forward declarations of ResourceRequest to have class in the forward
2929 declaration instead of struct and changed the definition of ResourceRequest to be class
2930 and added access qualifiers where missing. Additionally two references of friend
2931 struct ResourceRequestBase changed to class instead.
2933 * history/HistoryItem.h:
2934 * inspector/InspectorController.h:
2935 * inspector/InspectorResource.h:
2936 * loader/DocumentThreadableLoader.h:
2937 * loader/FrameLoaderClient.h:
2938 * loader/MainResourceLoader.h:
2939 * loader/ResourceLoadNotifier.h:
2940 * loader/SubresourceLoader.h:
2941 * loader/SubresourceLoaderClient.h:
2942 * loader/ThreadableLoader.h:
2943 * loader/WorkerThreadableLoader.h:
2944 * loader/appcache/ApplicationCache.h:
2945 * loader/appcache/ApplicationCacheHost.h:
2946 * platform/CrossThreadCopier.h:
2947 * platform/network/ResourceHandle.h:
2948 * platform/network/ResourceHandleClient.h:
2949 * platform/network/ResourceRequestBase.h:
2950 * platform/network/cf/ResourceRequest.h:
2951 * platform/network/cf/ResourceRequestCFNet.h:
2952 * platform/network/chromium/ResourceRequest.h:
2953 * platform/network/curl/ResourceRequest.h:
2954 * platform/network/qt/ResourceRequest.h:
2955 * platform/network/soup/ResourceRequest.h:
2956 * xml/XMLHttpRequest.h:
2958 2009-11-08 Dan Bernstein <mitz@apple.com>
2960 Reviewed by Simon Fraser.
2962 <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2963 below FrameView::layout
2964 https://bugs.webkit.org/show_bug.cgi?id=31093
2966 Test: fast/block/positioning/relative-positioned-inline-container.html
2968 In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2969 to mark the object for layout, doing so without marking its ancestors.
2970 However, RenderBlock::skipLeadingWhitespace and
2971 RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2972 positioned inline container, causing it to be marked for layout without
2973 ever going back to give it layout, and thus layout could end with a
2974 dirty object still in the tree, leading to all sorts of badness.
2976 The fix is to revert setStaticY() to not marking the object dirty, and
2977 instead do it in the call sites that require it, which are in
2978 RenderBlock and RenderFlexibleBox.
2980 * rendering/RenderBlock.cpp:
2981 (WebCore::RenderBlock::adjustPositionedBlock):
2982 * rendering/RenderFlexibleBox.cpp:
2983 (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2984 (WebCore::RenderFlexibleBox::layoutVerticalBox):
2985 * rendering/RenderLayer.cpp:
2986 * rendering/RenderLayer.h:
2987 (WebCore::RenderLayer::setStaticY):
2989 2009-11-07 Daniel Bates <dbates@webkit.org>
2991 Reviewed by Darin Adler.
2993 https://bugs.webkit.org/show_bug.cgi?id=20780
2995 Fixes an issue where the onchange event handler is not fired when the
2996 input field is autocompleted.
2998 We cannot test this using DRT since DRT cannot emulate autocompletion.
2999 So, a manual-test is included.
3001 Tests: manual-tests/autocompletion-fire-onchange.html
3003 * manual-tests/autocompletion-fire-onchange.html: Added.
3004 * rendering/RenderTextControl.cpp:
3005 (WebCore::RenderTextControl::setInnerTextValue):
3007 2009-11-07 Benjamin Otte <otte@gnome.org>
3009 Reviewed by Holger Freyther.
3011 Mark redrawn areas on image surfaces as dirty.
3013 This is required to conform to the Cairo API, but is currently only
3014 used by debugging tools like cairo-trace.
3016 * platform/graphics/cairo/ImageBufferCairo.cpp:
3017 (WebCore::ImageBuffer::platformTransformColorSpace):
3018 (WebCore::putImageData):
3020 2009-11-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
3022 Reviewed by Xan Lopez.
3024 https://bugs.webkit.org/show_bug.cgi?id=30878
3025 [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
3027 If the end_offset is -1, use the String length as the end_offset.
3029 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3030 (webkit_accessible_text_get_text):
3032 2009-11-06 Beth Dakin <bdakin@apple.com>
3034 Reviewed by Adele Peterson.
3036 Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up
3037 GraphicsContext's current concept of ColorSpace
3039 ColorSpace is now called ColorType. The variables on the state we
3040 appropriately re-named as well. I removed strokeColorSpace() and
3041 fillColorSpace() from GraphicsContext since they were never called.
3043 * platform/graphics/GraphicsContext.cpp:
3044 (WebCore::GraphicsContext::setStrokeColor):
3045 (WebCore::GraphicsContext::setFillColor):
3046 (WebCore::GraphicsContext::setStrokePattern):
3047 (WebCore::GraphicsContext::setFillPattern):
3048 (WebCore::GraphicsContext::setStrokeGradient):
3049 (WebCore::GraphicsContext::setFillGradient):
3050 * platform/graphics/GraphicsContext.h:
3052 * platform/graphics/GraphicsContextPrivate.h:
3053 (WebCore::GraphicsContextState::GraphicsContextState):
3054 * platform/graphics/cairo/GraphicsContextCairo.cpp:
3055 (WebCore::GraphicsContext::fillPath):
3056 (WebCore::GraphicsContext::strokePath):
3057 * platform/graphics/cg/GraphicsContextCG.cpp:
3058 (WebCore::calculateDrawingMode):
3059 (WebCore::GraphicsContext::drawPath):
3060 (WebCore::GraphicsContext::fillPath):
3061 (WebCore::GraphicsContext::strokePath):
3062 (WebCore::GraphicsContext::fillRect):
3063 (WebCore::GraphicsContext::strokeRect):
3064 * platform/graphics/qt/GraphicsContextQt.cpp:
3065 (WebCore::GraphicsContext::fillPath):
3066 (WebCore::GraphicsContext::strokePath):
3067 (WebCore::GraphicsContext::fillRect):
3068 * platform/graphics/wince/GraphicsContextWince.cpp:
3069 (WebCore::GraphicsContext::fillPath):
3070 (WebCore::GraphicsContext::fillRect):
3072 2009-11-06 Brian Weinstein <bweinstein@apple.com>
3074 Reviewed by Tim Hatcher.
3076 Fixes <http://webkit.org/b/31177>.
3077 Web Inspector: Bind backspace to delete cookies and DOM Storage.
3079 Refactor editing code from DOMStorageDataGrid to DataGrid, so other
3080 places in the inspector can use editing in DataGrid (added a FIXME for
3081 some stuff that needs to be generalized).
3083 Also added deleting functionality to DataGrid, and implemented it for
3084 Cookies and DOM Storage. The reason this patch is so big is because of
3085 the refactoring of editing code, which won't be used yet in a cross-datagrid
3086 way, but should be able to.
3088 Additionally, moved the callbacks members from DOMStorageDataGrid to
3089 DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
3090 make the architecture of DOM Storage look a lot more like the Cookies view.
3092 Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
3093 inspector from beeping at you when you delete an element.
3095 * WebCore.gypi: Removed DOMStorageDataGrid.
3096 * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
3097 * inspector/front-end/CookieItemsView.js:
3098 (WebInspector.CookieItemsView.prototype.dataGridForCookies):
3099 (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
3100 (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
3101 * inspector/front-end/DOMStorageDataGrid.js: Removed.
3102 * inspector/front-end/DOMStorageItemsView.js:
3103 (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
3104 (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
3105 (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
3106 (WebInspector.DOMStorageItemsView.prototype._editingCallback):
3107 (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
3108 (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
3109 * inspector/front-end/DataGrid.js:
3110 (WebInspector.DataGrid):
3111 (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
3112 (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
3113 (WebInspector.DataGrid.prototype._startEditing): Ditto.
3114 (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
3115 (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
3116 (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
3117 (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
3118 * inspector/front-end/ElementsTreeOutline.js:
3119 (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
3120 * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
3121 * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
3123 2009-11-06 Geoffrey Garen <ggaren@apple.com>
3125 Qt build fix: added an ExecState parameter.
3127 * bridge/qt/qt_runtime.cpp:
3128 (JSC::Bindings::convertValueToQVariant):
3129 (JSC::Bindings::convertQVariantToValue):
3131 2009-11-06 Geoffrey Garen <ggaren@apple.com>
3133 https://bugs.webkit.org/show_bug.cgi?id=31197
3134 Implemented a timezone cache not based on Mac OS X's notify_check API.
3136 Updated for JavaScriptCore internal API change.
3138 * bridge/qt/qt_runtime.cpp:
3139 (JSC::Bindings::convertValueToQVariant):
3140 (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
3142 * platform/network/HTTPParsers.cpp:
3143 (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
3144 (This function probably shouldn't be using a JavaScript date parser
3145 to begin with, but oh well.)
3147 2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
3149 Reviewed by Adam Barth.
3151 The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
3152 which affects Chromium only.
3154 Changes to V8HTMLDocumentCustom.cpp are as below:-
3155 1. The HTMLDocumentOpen function would cause a crash in Chromium if
3156 there was no calling javascript context. We now check for this case
3157 and pass in NULL to the HTMLDocument::open function which can handle
3158 a NULL document parameter.
3159 2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
3160 had ASSERTS for a NULL caller frame, which was bogus as it would crash
3161 anyway. We now check for this case and return a failure.
3163 Changes to V8DOMWindowCustom.cpp are as below:-
3164 1. Instead of failing the window.open call made by NPAPI for lack of a
3165 calling javascript context, we now use the entered context as the calling
3168 Tests: plugins/document-open.html
3169 plugins/window-open.html
3171 * bindings/v8/custom/V8DOMWindowCustom.cpp:
3172 (WebCore::CALLBACK_FUNC_DECL):
3173 * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3174 (WebCore::CALLBACK_FUNC_DECL):
3176 2009-11-06 Steve Block <steveblock@google.com>
3178 Reviewed by Eric Seidel.
3180 Geolocation error code UNKNOWN_ERROR is deprecated.
3181 https://bugs.webkit.org/show_bug.cgi?id=31184
3183 Remove this error code from PositionError, both for use from C++ code and from the JS object.
3185 Updated fast/dom/Geolocation/error.html to test this.
3187 * page/PositionError.h: Modified.
3188 (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
3189 * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
3190 * page/Geolocation.cpp: Modified.
3191 (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3192 * platform/gtk/GeolocationServiceGtk.cpp: Modified.
3193 (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3195 2009-11-06 Dirk Schulze <krit@webkit.org>
3197 Reviewed by Nikolas Zimmermann.
3199 feMorphology filter is not implemented
3200 [https://bugs.webkit.org/show_bug.cgi?id=5863]
3202 The Implementation of feMorphology.
3204 Test: We have allready a test for feMorphology
3205 svg/W3C-SVG-1.1/filters-morph-01-f.svg
3207 * svg/graphics/filters/SVGFEMorphology.cpp:
3208 (WebCore::FEMorphology::apply):
3210 2009-11-06 Steve Block <steveblock@google.com>
3212 Reviewed by Eric Seidel.
3214 V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3215 https://bugs.webkit.org/show_bug.cgi?id=31209
3217 Build fix only. No new tests possible.
3219 * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3221 2009-11-06 Drew Wilson <atwilson@chromium.org>
3223 Reviewed by David Levin.
3225 V8 bindings do not support SharedWorkers as event targets
3226 https://bugs.webkit.org/show_bug.cgi?id=31199
3228 No new tests because existing layout tests suffice (they currently
3231 * bindings/v8/V8DOMWrapper.cpp:
3232 (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3233 Added clause to create a DOM wrapper for SharedWorkers.
3235 2009-11-06 Anton Muhin <antonm@chromium.org>
3237 Reviewed by Adam Barth.
3239 Do not unnecessarly synchronzie in weak reference callbacks.
3240 https://bugs.webkit.org/show_bug.cgi?id=31191
3242 * bindings/v8/DOMData.h:
3243 (WebCore::DOMData::handleWeakObject):
3245 2009-11-06 Alexander Pavlov <apavlov@chromium.org>
3247 Reviewed by Pavel Feldman.
3249 Fix resource content search.
3250 https://bugs.webkit.org/show_bug.cgi?id=31202
3252 * inspector/front-end/AbstractTimelinePanel.js:
3253 (WebInspector.AbstractTimelinePanel.prototype.refresh):
3254 (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3255 * inspector/front-end/TimelinePanel.js:
3256 (WebInspector.TimelineGraph.prototype.refresh):
3258 2009-11-05 Yuta Kitamura <yutak@chromium.org>
3260 Reviewed by Eric Seidel.
3262 Fix ASSERT(currentStyle = renderStyle()).
3263 https://bugs.webkit.org/show_bug.cgi?id=31152
3266 (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3268 2009-11-05 Alpha Lam <hclam@chromium.org>
3270 Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3272 * bindings/v8/V8GCController.cpp:
3273 (WebCore::V8GCController::gcEpilogue):
3274 * bindings/v8/V8GCController.h:
3275 * bindings/v8/V8Proxy.cpp:
3276 (WebCore::V8Proxy::evaluate):
3277 (WebCore::V8Proxy::runScript):
3278 (WebCore::V8Proxy::callFunction):
3280 2009-11-05 Adam Barth <abarth@webkit.org>
3282 Reviewed by Sam Weinig.
3284 Cross-domain access to stylesheet text should not be allowed
3285 https://bugs.webkit.org/show_bug.cgi?id=20527
3287 Check whether whether the current document can read the cssRules from
3288 the style sheet. Firefox throws a security error here, but we return
3289 null instead because that's what we usually do in these cases.
3291 Test: http/tests/security/cannot-read-cssrules-redirect.html
3292 http/tests/security/cannot-read-cssrules.html
3294 * css/CSSStyleSheet.cpp:
3295 (WebCore::CSSStyleSheet::cssRules):
3297 2009-11-05 Steve Block <steveblock@google.com>
3299 Reviewed by Eric Seidel.
3301 If the Geolocation service fails to start, invoke the error callback asynchronously.
3302 https://bugs.webkit.org/show_bug.cgi?id=28276
3304 All Geolocation callbacks must be invoked asynchronously.
3305 See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3307 No new tests possible with current LayoutTestController.
3309 * page/Geolocation.cpp:
3310 (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3311 (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3312 (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3314 2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
3316 Reviewed by Eric Seidel.
3318 Removed the "this is part of the KDE project" comments from
3319 all *.h, *.cpp, *.idl, and *.pm files.
3321 https://bugs.webkit.org/show_bug.cgi?id=31167
3323 The maintenance and architecture page in the project wiki lists
3326 This change includes no changes or additions to test cases
3327 since the change affects only comments.
3329 * bindings/scripts/CodeGeneratorV8.pm:
3330 * bindings/scripts/IDLParser.pm:
3331 * bindings/scripts/IDLStructure.pm:
3332 * css/CSSInheritedValue.cpp:
3333 * css/CSSInitialValue.cpp:
3334 * css/CSSMediaRule.cpp:
3335 * css/CSSNamespace.h:
3336 * css/CSSProperty.cpp:
3337 * css/CSSProperty.h:
3338 * css/CSSRuleList.cpp:
3339 * css/CSSRuleList.h:
3340 * css/CSSSelector.h:
3341 * css/CSSValueList.cpp:
3342 * css/FontValue.cpp:
3343 * css/MediaFeatureNames.cpp:
3344 * css/MediaFeatureNames.h:
3346 * css/SVGCSSStyleSelector.cpp:
3347 * css/ShadowValue.cpp:
3348 * css/StyleSheet.cpp:
3349 * css/StyleSheetList.cpp:
3350 * css/maketokenizer:
3351 * dom/BeforeUnloadEvent.cpp:
3352 * dom/BeforeUnloadEvent.h:
3353 * dom/CSSMappedAttributeDeclaration.cpp:
3354 * dom/EventNames.cpp:
3355 * dom/EventTarget.cpp:
3356 * dom/MappedAttributeEntry.h:
3357 * dom/MouseRelatedEvent.h:
3358 * dom/RangeException.h:
3359 * dom/StyleElement.h:
3361 * html/HTMLHeadElement.h:
3362 * html/HTMLHeadingElement.cpp:
3363 * html/HTMLHeadingElement.h:
3364 * html/HTMLHtmlElement.h:
3365 * html/HTMLImageLoader.h:
3366 * html/HTMLMetaElement.h:
3367 * html/HTMLModElement.cpp:
3368 * html/HTMLModElement.h:
3369 * html/HTMLOptionsCollection.cpp:
3370 * html/HTMLPlugInElement.cpp:
3371 * html/HTMLPreElement.cpp:
3372 * html/HTMLPreElement.h:
3373 * html/HTMLTableCellElement.cpp:
3374 * html/HTMLTableCellElement.h:
3375 * html/HTMLTableColElement.cpp:
3376 * html/HTMLTableColElement.h:
3377 * html/HTMLTablePartElement.cpp:
3378 * html/HTMLTablePartElement.h:
3379 * html/HTMLTitleElement.h:
3380 * page/MouseEventWithHitTestResults.h:
3381 * platform/StaticConstructors.h:
3382 * platform/text/AtomicStringImpl.h:
3383 * platform/text/qt/TextBreakIteratorQt.cpp:
3384 * rendering/AutoTableLayout.h:
3385 * rendering/CounterNode.cpp:
3386 * rendering/EllipsisBox.cpp:
3387 * rendering/EllipsisBox.h:
3388 * rendering/FixedTableLayout.cpp:
3389 * rendering/FixedTableLayout.h:
3390 * rendering/HitTestRequest.h:
3391 * rendering/HitTestResult.h:
3392 * rendering/InlineRunBox.h:
3393 * rendering/PointerEventsHitRules.cpp:
3394 * rendering/PointerEventsHitRules.h:
3395 * rendering/RenderBR.cpp:
3396 * rendering/RenderBR.h:
3397 * rendering/RenderButton.cpp:
3398 * rendering/RenderButton.h:
3399 * rendering/RenderFieldset.cpp:
3400 * rendering/RenderFrameSet.cpp:
3401 * rendering/RenderListItem.cpp:
3402 * rendering/RenderTableRow.cpp:
3403 * rendering/RenderView.h:
3404 * rendering/RootInlineBox.h:
3405 * rendering/SVGInlineTextBox.cpp:
3406 * rendering/SVGInlineTextBox.h:
3407 * rendering/TableLayout.h:
3408 * rendering/break_lines.h:
3409 * rendering/style/SVGRenderStyle.cpp:
3410 * rendering/style/SVGRenderStyle.h:
3411 * rendering/style/SVGRenderStyleDefs.cpp:
3412 * rendering/style/SVGRenderStyleDefs.h:
3413 * svg/GradientAttributes.h:
3414 * svg/LinearGradientAttributes.h:
3415 * svg/PatternAttributes.h:
3416 * svg/RadialGradientAttributes.h:
3417 * svg/SVGAElement.cpp:
3419 * svg/SVGAnimateColorElement.cpp:
3420 * svg/SVGAnimateColorElement.h:
3421 * svg/SVGAnimateElement.cpp:
3422 * svg/SVGAnimateElement.h:
3423 * svg/SVGAnimateTransformElement.h:
3424 * svg/SVGAnimatedPathData.cpp:
3425 * svg/SVGAnimatedPathData.h:
3426 * svg/SVGAnimatedPoints.cpp:
3427 * svg/SVGAnimatedPoints.h:
3428 * svg/SVGAnimationElement.cpp:
3429 * svg/SVGCircleElement.cpp:
3430 * svg/SVGClipPathElement.cpp:
3433 * svg/SVGComponentTransferFunctionElement.cpp:
3434 * svg/SVGComponentTransferFunctionElement.h:
3435 * svg/SVGCursorElement.cpp:
3436 * svg/SVGDefsElement.cpp:
3437 * svg/SVGDescElement.cpp:
3438 * svg/SVGDescElement.h:
3439 * svg/SVGDocument.idl:
3440 * svg/SVGElement.idl:
3441 * svg/SVGElementInstanceList.cpp:
3442 * svg/SVGElementInstanceList.h:
3443 * svg/SVGEllipseElement.cpp:
3444 * svg/SVGExternalResourcesRequired.cpp:
3445 * svg/SVGFEBlendElement.cpp:
3446 * svg/SVGFEBlendElement.h:
3447 * svg/SVGFEColorMatrixElement.cpp:
3448 * svg/SVGFEColorMatrixElement.h:
3449 * svg/SVGFEComponentTransferElement.cpp:
3450 * svg/SVGFEComponentTransferElement.h:
3451 * svg/SVGFECompositeElement.cpp:
3452 * svg/SVGFECompositeElement.h:
3453 * svg/SVGFEFloodElement.cpp:
3454 * svg/SVGFEFloodElement.h:
3455 * svg/SVGFEFuncAElement.cpp:
3456 * svg/SVGFEFuncAElement.h:
3457 * svg/SVGFEFuncBElement.cpp:
3458 * svg/SVGFEFuncBElement.h:
3459 * svg/SVGFEFuncGElement.cpp:
3460 * svg/SVGFEFuncGElement.h:
3461 * svg/SVGFEFuncRElement.cpp:
3462 * svg/SVGFEFuncRElement.h:
3463 * svg/SVGFEGaussianBlurElement.cpp:
3464 * svg/SVGFEGaussianBlurElement.h:
3465 * svg/SVGFEImageElement.cpp:
3466 * svg/SVGFEMergeElement.cpp:
3467 * svg/SVGFEMergeElement.h:
3468 * svg/SVGFEMergeNodeElement.cpp:
3469 * svg/SVGFEOffsetElement.cpp:
3470 * svg/SVGFEOffsetElement.h:
3471 * svg/SVGFETileElement.cpp:
3472 * svg/SVGFETileElement.h:
3473 * svg/SVGFETurbulenceElement.cpp:
3474 * svg/SVGFETurbulenceElement.h:
3475 * svg/SVGFilterElement.cpp:
3476 * svg/SVGGElement.cpp:
3477 * svg/SVGGradientElement.cpp:
3478 * svg/SVGHKernElement.idl:
3479 * svg/SVGLangSpace.cpp:
3480 * svg/SVGLangSpace.h:
3481 * svg/SVGLength.cpp:
3483 * svg/SVGLength.idl:
3484 * svg/SVGLengthList.cpp:
3485 * svg/SVGLengthList.h:
3486 * svg/SVGLineElement.cpp:
3487 * svg/SVGLinearGradientElement.h:
3489 * svg/SVGListTraits.h:
3490 * svg/SVGLocatable.h:
3491 * svg/SVGMaskElement.cpp:
3492 * svg/SVGMatrix.idl:
3493 * svg/SVGMetadataElement.cpp:
3494 * svg/SVGMetadataElement.h:
3495 * svg/SVGMetadataElement.idl:
3496 * svg/SVGNumber.idl:
3497 * svg/SVGNumberList.cpp:
3498 * svg/SVGNumberList.h:
3500 * svg/SVGPathElement.cpp:
3502 * svg/SVGPathSegArc.cpp:
3503 * svg/SVGPathSegArc.h:
3504 * svg/SVGPathSegClosePath.cpp:
3505 * svg/SVGPathSegClosePath.h:
3506 * svg/SVGPathSegCurvetoCubic.cpp:
3507 * svg/SVGPathSegCurvetoCubic.h:
3508 * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3509 * svg/SVGPathSegCurvetoCubicSmooth.h:
3510 * svg/SVGPathSegCurvetoQuadratic.cpp:
3511 * svg/SVGPathSegCurvetoQuadratic.h:
3512 * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3513 * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3514 * svg/SVGPathSegLineto.cpp:
3515 * svg/SVGPathSegLineto.h:
3516 * svg/SVGPathSegLinetoHorizontal.cpp:
3517 * svg/SVGPathSegLinetoHorizontal.h:
3518 * svg/SVGPathSegLinetoVertical.cpp:
3519 * svg/SVGPathSegLinetoVertical.h:
3520 * svg/SVGPathSegMoveto.cpp:
3521 * svg/SVGPathSegMoveto.h:
3522 * svg/SVGPatternElement.cpp:
3524 * svg/SVGPointList.cpp:
3525 * svg/SVGPointList.h:
3526 * svg/SVGPolyElement.cpp:
3527 * svg/SVGPolygonElement.cpp:
3528 * svg/SVGPolygonElement.h:
3529 * svg/SVGPolylineElement.cpp:
3530 * svg/SVGPolylineElement.h:
3531 * svg/SVGPreserveAspectRatio.cpp:
3532 * svg/SVGPreserveAspectRatio.h:
3533 * svg/SVGRadialGradientElement.h:
3535 * svg/SVGRectElement.cpp:
3536 * svg/SVGRenderingIntent.h:
3537 * svg/SVGSVGElement.idl:
3538 * svg/SVGScriptElement.cpp:
3539 * svg/SVGSetElement.cpp:
3540 * svg/SVGSetElement.h:
3541 * svg/SVGStopElement.cpp:
3542 * svg/SVGStringList.cpp:
3543 * svg/SVGStringList.h:
3544 * svg/SVGStylable.cpp:
3545 * svg/SVGStylable.h:
3546 * svg/SVGStyleElement.cpp:
3547 * svg/SVGStyleElement.h:
3548 * svg/SVGStyledElement.h:
3549 * svg/SVGStyledLocatableElement.cpp:
3550 * svg/SVGStyledLocatableElement.h:
3551 * svg/SVGStyledTransformableElement.cpp:
3552 * svg/SVGStyledTransformableElement.h:
3553 * svg/SVGSwitchElement.cpp:
3554 * svg/SVGSymbolElement.cpp:
3555 * svg/SVGTRefElement.cpp:
3556 * svg/SVGTSpanElement.cpp:
3557 * svg/SVGTSpanElement.h:
3559 * svg/SVGTextElement.cpp:
3560 * svg/SVGTextElement.h:
3561 * svg/SVGTextPathElement.cpp:
3562 * svg/SVGTextPositioningElement.cpp:
3563 * svg/SVGTextPositioningElement.h:
3564 * svg/SVGTitleElement.cpp:
3565 * svg/SVGTitleElement.h:
3566 * svg/SVGTransform.cpp:
3567 * svg/SVGTransform.h:
3568 * svg/SVGTransform.idl:
3569 * svg/SVGTransformList.cpp:
3570 * svg/SVGTransformList.h:
3571 * svg/SVGTransformable.h:
3572 * svg/SVGURIReference.h:
3573 * svg/SVGUnitTypes.h:
3574 * svg/SVGUseElement.cpp:
3575 * svg/SVGViewElement.cpp:
3576 * svg/SVGZoomAndPan.cpp:
3577 * svg/SVGZoomAndPan.h:
3578 * svg/SVGZoomEvent.cpp:
3580 2009-11-05 Jeremy Orlow <jorlow@chromium.org>
3582 Reviewed by Dimitri Glazkov.
3584 REGRESSION Clean up security origin usage in DOM Storage.
3585 https://bugs.webkit.org/show_bug.cgi?id=31188
3587 Clean up security origin usage in DOM Storage. This fixes a bug in my
3588 refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3590 Instead of having StorageAreaSync's constructor (which is called in the
3591 constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3592 database identifier, simply have StorageAreaImpl pass the identifier into
3595 No test because there's no change in externally observable behavior.
3597 * storage/StorageAreaImpl.cpp:
3598 (WebCore::StorageAreaImpl::StorageAreaImpl):
3599 * storage/StorageAreaImpl.h:
3600 * storage/StorageAreaSync.cpp:
3601 (WebCore::StorageAreaSync::create):
3602 (WebCore::StorageAreaSync::StorageAreaSync):
3603 * storage/StorageAreaSync.h:
3605 2009-11-05 Scott Violet <sky@google.com>
3607 Reviewed by Dimitri Glazkov.
3609 Need notification of scrolling frame
3610 https://bugs.webkit.org/show_bug.cgi?id=31145
3612 Adds FrameLoaderClient::didChangeScrollOffset that is called when
3613 the frame scrolls. This will be used to know when history state
3614 needs to be updated.
3616 * loader/FrameLoaderClient.h:
3617 (WebCore::FrameLoaderClient::didChangeScrollOffset):
3618 * page/FrameView.cpp:
3619 (WebCore::FrameView::valueChanged):
3621 2009-11-05 Kenneth Russell <kbr@google.com>
3623 Reviewed by Dimitri Glazkov.
3625 [V8] Update bindings to use new API for external arrays
3626 https://bugs.webkit.org/show_bug.cgi?id=31181
3628 No new tests; covered by existing WebGL tests.
3630 * bindings/v8/V8DOMWrapper.cpp:
3631 (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3632 (WebCore::V8DOMWrapper::getTemplate):
3633 (WebCore::V8DOMWrapper::convertToV8Object):
3634 * bindings/v8/V8DOMWrapper.h:
3635 * bindings/v8/custom/V8CanvasArrayCustom.h:
3636 (WebCore::constructCanvasArray):
3638 2009-11-05 Alpha Lam <hclam@chromium.org>
3640 Not reviewed, Chromium build fix.
3642 50561 introduces a custom method for SVGMatrix, we need to implement
3645 * bindings/v8/custom/V8CustomBinding.h:
3646 Adding definition for V8SVGMatrixMultiply.
3647 * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3648 (WebCore::CALLBACK_FUNC_DECL):
3649 Implement V8SVGMatrixMultiply according to the same method in JSC.
3651 2009-11-05 Jeremy Orlow <jorlow@chromium.org>
3653 Revert 50569 since it broke QT. Build fix and just a revert, so no review.
3655 * page/DOMWindow.cpp:
3656 (WebCore::DOMWindow::sessionStorage):
3657 * page/Settings.cpp:
3658 (WebCore::Settings::Settings):
3659 (WebCore::Settings::setSessionStorageEnabled):
3661 (WebCore::Settings::sessionStorageEnabled):
3663 2009-11-05 Pavel Feldman <pfeldman@chromium.org>
3665 Reviewed by Timothy Hatcher.
3667 REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3669 https://bugs.webkit.org/show_bug.cgi?id=30884
3671 Test: inspector/styles-iframe.html
3673 * inspector/front-end/DOMAgent.js:
3674 (WebInspector.DOMNode):
3675 * inspector/front-end/InjectedScript.js:
3676 (InjectedScript.getStyles):
3677 (InjectedScript.getComputedStyle):
3678 (InjectedScript.addStyleSelector):
3679 * inspector/front-end/TestController.js:
3680 (WebInspector.TestController.prototype.notifyDone):
3681 (WebInspector.TestController.prototype.runAfterPendingDispatches):
3682 (WebInspector.evaluateForTestInFrontend.invokeMethod):
3683 (WebInspector.evaluateForTestInFrontend):
3685 2009-11-05 Vitaly Repeshko <vitalyr@chromium.org>
3687 Reviewed by Geoffrey Garen and Dimitri Glazkov.
3689 Rehashing of EventListenerMap leads to loss of EvenListenerList.
3690 https://bugs.webkit.org/show_bug.cgi?id=31027
3692 Tested by new fast/events/event-listener-map-rehash-crash.html.
3694 EventListenerMap modified to store pointers to listener vectors:
3695 * dom/EventTarget.cpp:
3696 (WebCore::EventTargetData::~EventTargetData):
3697 (WebCore::EventTarget::addEventListener):
3698 (WebCore::EventTarget::removeEventListener):
3699 (WebCore::EventTarget::fireEventListeners):
3700 (WebCore::EventTarget::getEventListeners):
3701 (WebCore::EventTarget::removeAllEventListeners):
3702 * dom/EventTarget.h:
3704 Usages updated after interface changes:
3705 * inspector/InspectorDOMAgent.cpp:
3706 (WebCore::InspectorDOMAgent::getEventListenersForNode):
3707 * svg/SVGUseElement.cpp:
3708 (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3710 2009-11-05 Dan Kegel <dank@chromium.org>
3712 Reviewed by Dmitri Titov.
3714 Add missing initialization for m_createdByParser.
3715 https://bugs.webkit.org/show_bug.cgi?id=31089
3717 Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3719 * dom/ProcessingInstruction.cpp:
3720 (WebCore::ProcessingInstruction::ProcessingInstruction):
3722 2009-11-04 Jeremy Orlow <jorlow@chromium.org>
3724 Reviewed by Adam Barth.
3726 DOM Storage runtime flag changes
3727 https://bugs.webkit.org/show_bug.cgi?id=30602
3731 Revert my changes to Settings and instead implement DOM Storage enabling via
3732 the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3734 This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3735 LayoutTest visible changes and thus no tests.
3737 * bindings/v8/custom/V8CustomBinding.h:
3738 * bindings/v8/custom/V8DOMWindowCustom.cpp:
3739 (WebCore::ACCESSOR_RUNTIME_ENABLER):
3740 * page/DOMWindow.cpp:
3741 (WebCore::DOMWindow::sessionStorage):
3742 * page/DOMWindow.idl:
3743 * page/Settings.cpp:
3744 (WebCore::Settings::Settings):
3746 * storage/Storage.cpp:
3747 (WebCore::Storage::setLocalStorageAvailable):
3748 (WebCore::Storage::localStorageAvailable):
3749 (WebCore::Storage::setSessionStorageAvailable):
3750 (WebCore::Storage::sessionStorageAvailable):
3751 * storage/Storage.h:
3753 2009-11-05 Jian Li <jianli@chromium.org>
3755 Reviewed by Pavel Feldman.
3757 Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3758 https://bugs.webkit.org/show_bug.cgi?id=31108
3760 * bindings/v8/V8AbstractEventListener.cpp:
3761 (WebCore::V8AbstractEventListener::invokeEventHandler):
3762 * bindings/v8/V8Utilities.cpp:
3763 (WebCore::reportException):
3765 2009-11-05 Jian Li <jianli@chromium.org>
3767 Reviewed by Dmitri Titov.
3769 We should not bubble up events if we drag something to an iframe that
3770 has an invalid source.
3771 https://bugs.webkit.org/show_bug.cgi?id=30469
3773 Test: http/tests/misc/bubble-drag-events.html
3775 * page/EventHandler.cpp:
3776 (WebCore::EventHandler::handleDragAndDropForTarget):
3777 (WebCore::EventHandler::updateDragAndDrop):
3778 (WebCore::EventHandler::cancelDragAndDrop):
3779 (WebCore::EventHandler::performDragAndDrop):
3780 * page/EventHandler.h:
3781 (WebCore::EventHandler::):
3783 2009-11-05 Pavel Feldman <pfeldman@chromium.org>
3785 Reviewed by Timothy Hatcher.
3787 Web Inspector: speed up Timelines Clear by a factor of thousands.
3789 https://bugs.webkit.org/show_bug.cgi?id=31160
3791 * inspector/front-end/utilities.js:
3792 (Element.prototype.removeChildren):
3794 2009-11-05 Anton Muhin <antonm@chromium.org>
3796 Reviewed by Adam Barth.
3798 If high memory usage is detected, hint to V8 that it might be due
3799 to external objects retained by V8 objects.
3800 https://bugs.webkit.org/show_bug.cgi?id=31051
3802 * bindings/v8/V8GCController.cpp:
3803 (WebCore::GetMemoryUsageInMB):
3804 (WebCore::V8GCController::gcEpilogue):
3805 (WebCore::V8GCController::checkMemoryUsage):
3806 * bindings/v8/V8GCController.h:
3807 * bindings/v8/V8Proxy.cpp:
3808 (WebCore::V8Proxy::evaluate):
3809 (WebCore::V8Proxy::runScript):
3810 (WebCore::V8Proxy::callFunction):
3812 2009-11-05 Jeff Schiller <codedread@gmail.com>
3814 Reviewed by Simon Fraser.
3816 Correct order of matrix multiplication for SVGMatrix.
3817 https://bugs.webkit.org/show_bug.cgi?id=16062
3819 Test: svg/dom/SVGMatrix-interface.xhtml
3821 * bindings/js/JSSVGMatrixCustom.cpp:
3822 (WebCore::JSSVGMatrix::multiply):
3823 * svg/SVGMatrix.idl:
3825 2009-11-04 Pavel Feldman <pfeldman@chromium.org>
3827 Reviewed by Timothy Hatcher.
3829 Web Inspector: Make resource-related records in timeline
3830 actually take some time.
3832 https://bugs.webkit.org/show_bug.cgi?id=31139
3834 * English.lproj/localizedStrings.js:
3835 * inspector/front-end/TimelinePanel.js:
3836 (WebInspector.TimelinePanel):
3837 (WebInspector.TimelinePanel.prototype._formatRecord):
3838 (WebInspector.TimelinePanel.prototype._getRecordDetails):
3839 (WebInspector.TimelinePanel.prototype.reset):
3841 2009-11-04 Jeremy Orlow <jorlow@chromium.org>
3843 Reviewed by Darin Fisher.
3845 Simplify LocalStorageThread
3846 https://bugs.webkit.org/show_bug.cgi?id=30935
3848 This is a re-submit of 50519. LocalStorageTask should have never been ref
3849 counted. I've removed that and switched a PassRefPtr over to a PassOwnPtr.
3851 On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3852 of the method names a bit more clear. Assert proper thread usage. Join rather
3853 than detaching the thread and doing an ad-hoc form of join. Avoid touching
3854 variables on the background thread when simple to do so. Also create a generic
3855 scheduleTask function rather than one for each task.
3857 No behavior should have changed.
3859 * storage/LocalStorageTask.h:
3860 * storage/LocalStorageThread.cpp:
3861 (WebCore::LocalStorageThread::create):
3862 (WebCore::LocalStorageThread::LocalStorageThread):
3863 (WebCore::LocalStorageThread::~LocalStorageThread):
3864 (WebCore::LocalStorageThread::start):
3865 (WebCore::LocalStorageThread::threadEntryPointCallback):
3866 (WebCore::LocalStorageThread::threadEntryPoint):
3867 (WebCore::LocalStorageThread::scheduleTask):
3868 (WebCore::LocalStorageThread::terminate):
3869 (WebCore::LocalStorageThread::performTerminate):
3870 * storage/LocalStorageThread.h:
3871 * storage/StorageSyncManager.cpp:
3872 (WebCore::StorageSyncManager::StorageSyncManager):
3873 (WebCore::StorageSyncManager::~StorageSyncManager):
3874 (WebCore::StorageSyncManager::scheduleImport):
3875 (WebCore::StorageSyncManager::scheduleSync):
3876 * storage/StorageSyncManager.h:
3878 2009-11-04 Jeremy Orlow <jorlow@chromium.org>
3880 Reviewed by Darin Fisher.
3882 Calling databaseIdentifier on LocalStorage's background thread is not safe.
3883 https://bugs.webkit.org/show_bug.cgi?id=31149
3885 Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
3886 is not safe. databaseIdentifier does a bunch of string concatenation which
3887 ref-counts StringImpls in some cases. This was caught by valgrind thread
3888 sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
3890 There's no way to test for such racyness, unfortunately.
3892 * storage/StorageAreaSync.cpp:
3893 (WebCore::StorageAreaSync::StorageAreaSync):
3894 (WebCore::StorageAreaSync::performImport):
3895 * storage/StorageAreaSync.h:
3896 * storage/StorageSyncManager.cpp:
3897 (WebCore::StorageSyncManager::fullDatabaseFilename):
3898 * storage/StorageSyncManager.h:
3900 2009-11-03 Jeremy Orlow <jorlow@chromium.org>
3902 Reviewed by Darin Fisher.
3904 Clean up StorageAreaSync
3905 https://bugs.webkit.org/show_bug.cgi?id=31100
3907 Major fixes: Break the ref count cycle for StorageArea on the main
3908 thread, not the background thread since the latter is not safe.
3909 Length() needs to block on the import completing.
3911 Small fixes: setItem needs to handle the copy on write case even if it
3912 has an exception. setItem and removeItem should just bail from the
3913 the function if the value hasn't changed rather than wrapping the end
3914 in an if block. Clear should only send an event if it wasn't already
3915 cleared. StorageAreaSync should assert that the final sync was
3918 * storage/StorageAreaImpl.cpp:
3919 (WebCore::StorageAreaImpl::length):
3920 Forgot to block on the import.
3921 (WebCore::StorageAreaImpl::key):
3922 (WebCore::StorageAreaImpl::setItem):
3923 Handle the copy on write case even when there's an exception.
3924 (WebCore::StorageAreaImpl::removeItem):
3925 (WebCore::StorageAreaImpl::clear):
3926 * storage/StorageAreaSync.cpp:
3927 (WebCore::StorageAreaSync::~StorageAreaSync):
3928 (WebCore::StorageAreaSync::scheduleFinalSync):
3929 (WebCore::StorageAreaSync::performImport):
3930 (WebCore::StorageAreaSync::markImported):
3931 (WebCore::StorageAreaSync::blockUntilImportComplete):
3932 * storage/StorageAreaSync.h:
3934 2009-11-05 Zoltan Horvath <zoltan@webkit.org>
3936 Reviewed by Eric Seidel.
3938 Allow custom memory allocation control for WebCore's CachedResource
3939 https://bugs.webkit.org/show_bug.cgi?id=31114
3941 Inherits CachedResource class from Noncopyable because its (its child
3942 class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
3943 and it is no need to be copyable.
3945 * loader/CachedResource.h:
3947 2009-11-04 Mark Mentovai <mark@chromium.org>
3949 Reviewed by Mark Rowe.
3951 Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
3952 is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
3953 which is true when targeting 10.6 or later.
3955 HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
3956 is present in the CGInterpolationQuality enum, and must be handled
3957 by a switch that has cases for each enumerated value.
3959 USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
3960 on 10.6 or later, and that CoreGraphics will understand when
3961 InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
3963 * platform/graphics/cg/GraphicsContextCG.cpp:
3964 (WebCore::GraphicsContext::setImageInterpolationQuality):
3965 (WebCore::GraphicsContext::imageInterpolationQuality):
3967 2009-11-04 Dan Kegel <dank@chromium.org>
3969 Reviewed by Alexey Proskuryakov.
3971 Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
3972 https://bugs.webkit.org/show_bug.cgi?id=31138
3974 Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
3977 (WebCore::Page::userStyleSheetLocationChanged):
3979 2009-11-04 Timothy Hatcher <timothy@apple.com>
3981 Update the Web Inspector Timeline panel to better match the mock-up.
3983 https://bugs.webkit.org/show_bug.cgi?id=31150
3985 Reviewed by Pavel Feldman.
3987 * inspector/front-end/TimelinePanel.js:
3988 (WebInspector.TimelinePanel.prototype._getRecordDetails):
3989 (WebInspector.TimelinePanel.prototype._dragWindow):
3990 (WebInspector.TimelinePanel.prototype._resizeWindowLeft):
3991 (WebInspector.TimelinePanel.prototype._resizeWindowRight):
3992 (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
3993 (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3994 (WebInspector.TimelineRecordTreeElement.prototype.refresh):
3995 (WebInspector.TimelineCategoryGraph):
3996 * inspector/front-end/inspector.css:
3998 2009-11-05 Justin Garcia <justin.garcia@apple.com>
4000 Reviewed by Adele Peterson.
4002 https://bugs.webkit.org/show_bug.cgi?id=25439
4003 Deleting when in front of a block image removes character from previous paragraph
4005 Added editing/deleting/25439-{1,2,3}.html
4007 * editing/DeleteSelectionCommand.cpp:
4008 (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot
4009 be made inline with other content. Instead of merging, just move the caret to just before
4010 the selection we deleted.
4011 * editing/htmlediting.cpp:
4012 (WebCore::firstInSpecialElement): Added a FIXME. This function begins iterating up from pos.node(), which
4013 doesn't necessarily contain pos (suppose pos was [img, 0]).
4014 (WebCore::lastInSpecialElement): Ditto.
4015 (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp. Added a check for non-inline images.
4016 * editing/htmlediting.h:
4017 * editing/visible_units.cpp:
4018 (WebCore::startOfParagraph): Use moved/renamed function. Removed FIXME. The problem causing
4019 5027702 is now squarely in first/lastInSpecialElement
4020 (WebCore::endOfParagraph): Ditto.
4022 2009-11-04 Enrica Casucci <enrica@apple.com>
4024 Reviewed by Adele Peterson.
4026 Hang in Mail on attempting to change indent level.
4027 <rdar://problem/7131805>
4028 https://bugs.webkit.org/show_bug.cgi?id=31127
4030 The hang was caused by an infinite loop inside outdentRegion.
4031 The code did not account for the fact that, when a list item
4032 contains multiple paragraphs, outdent moves all paragraphs at
4033 once, invalidating some of the positions we keep track of in the loop.
4034 Some code refactoring has also been done to minimize duplicated code.
4036 Test: editing/execCommand/outdent-multiparagraph-list.html
4038 * editing/IndentOutdentCommand.cpp:
4039 (WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
4040 outdentRegion to doApply.
4041 (WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
4042 (WebCore::IndentOutdentCommand::doApply): Some code refactoring.
4043 * editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
4044 indentRegion and outdentRegion.
4046 2009-11-04 Alpha Lam <hclam@chromium.org>
4048 Reviewed by Eric Carlson.
4050 Volume slider doesn't have a thumb
4051 https://bugs.webkit.org/show_bug.cgi?id=31135
4053 Fixed an incorrect if statement that prevents volume slider
4056 The statement checks if the slider value equals to the current
4057 volume value of the media control to avoid updating the volume
4058 slider. Updating the volume slider control shouldn't be within
4059 this condition because we explicitly set them to be equals
4060 during creation of the controls and also when mouse events are
4061 received on the volume control.
4063 No new tests because existing code breaks:
4064 LayoutTests/media/video-volume-slider.html
4066 It should now start passing on Chromium.
4068 * rendering/MediaControlElements.cpp:
4069 (WebCore::MediaControlVolumeSliderElement::update):
4070 Update the volume slider regardless of the current volume value
4071 of the media control.
4073 2009-11-04 Jenn Braithwaite <jennb@chromium.org>
4075 Reviewed by David Levin.
4077 Need to properly disable applicationCache at runtime
4078 https://bugs.webkit.org/show_bug.cgi?id=30417
4080 Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
4082 No new exposed functionality, so no new tests.
4084 * bindings/v8/RuntimeEnabledFeatures.cpp:
4085 * bindings/v8/RuntimeEnabledFeatures.h:
4086 (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
4087 (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
4088 * bindings/v8/custom/V8CustomBinding.h:
4089 * bindings/v8/custom/V8DOMWindowCustom.cpp:
4090 (WebCore::ACCESSOR_RUNTIME_ENABLER):
4091 * page/DOMWindow.idl:
4093 2009-11-04 Alexey Proskuryakov <ap@apple.com>
4095 Reviewed by Dan Bernstein.
4097 https://bugs.webkit.org/show_bug.cgi?id=31143
4098 Assertion failure in CredentialStorage::set() when proxy credentials are being set
4100 No test, cannot test proxy behavior.
4102 * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
4103 possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
4104 add "://" to origin set, which is weird, but safe.
4106 2009-11-04 Patrick Mueller <Patrick_Mueller@us.ibm.com>
4108 Reviewed by Timothy Hatcher.
4110 Web Inspector: Leftover Breakpoints in the Sidebar Pane
4111 https://bugs.webkit.org/show_bug.cgi?id=30659
4115 * inspector/front-end/ScriptsPanel.js:
4116 (WebInspector.ScriptsPanel.prototype.addScript):
4118 2009-11-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
4120 Reviewed by Timothy Hatcher.
4122 WebInspector: Use a different method to identify the webkit port in
4123 InspectorBackent::platform().
4124 This corrects the inspector expected behavior with Qt on Windows.
4125 https://bugs.webkit.org/show_bug.cgi?id=31116
4127 * inspector/InspectorBackend.cpp:
4128 (WebCore::InspectorBackend::platform):
4129 (WebCore::InspectorBackend::port):
4130 * inspector/InspectorBackend.h:
4131 * inspector/InspectorBackend.idl:
4132 * inspector/front-end/InspectorControllerStub.js:
4133 (.WebInspector.InspectorControllerStub.prototype.port):
4134 * inspector/front-end/inspector.css:
4135 * inspector/front-end/inspector.js:
4136 (WebInspector.loaded):
4137 (WebInspector.toolbarDragStart):
4139 2009-11-04 Benjamin Otte <otte@gnome.org>
4141 Reviewed by Gustavo Noronha.
4143 Update Cairo requirement to 1.6.
4145 Also remove all conditional code and workarounds for older versions of
4147 In particular, gain image quality by removing the use of
4148 CAIRO_FILTER_NEAREST when rendering images and use the default
4149 bilinear filter instead.
4150 https://bugs.webkit.org/show_bug.cgi?id=19266
4152 * platform/graphics/cairo/GraphicsContextCairo.cpp:
4153 (WebCore::GraphicsContext::clipOut):
4154 * platform/graphics/cairo/ImageCairo.cpp:
4155 (WebCore::BitmapImage::draw):
4156 (WebCore::BitmapImage::drawPattern):
4157 * platform/graphics/cairo/PathCairo.cpp:
4158 (WebCore::Path::isEmpty):
4159 (WebCore::Path::boundingRect):
4160 * platform/gtk/RenderThemeGtk.cpp:
4161 (WebCore::paintMozWidget):
4163 2009-11-04 Kevin Ollivier <kevino@theolliviers.com>
4165 wx build fix. Restore removed string conversion after cleanup.
4167 * platform/graphics/wx/FontPlatformDataWx.cpp:
4168 (WebCore::FontPlatformData::computeHash):
4170 2009-11-04 Chris Fleizach <cfleizach@apple.com>
4172 Reviewed by Beth Dakin.
4174 Need to implement ARIA role="combobox"
4175 https://bugs.webkit.org/show_bug.cgi?id=31096
4177 Test: accessibility/aria-combobox.html
4179 * accessibility/AccessibilityObject.h:
4180 (WebCore::AccessibilityObject::isComboBox):
4181 (WebCore::AccessibilityObject::isExpanded):
4182 (WebCore::AccessibilityObject::expandObject):
4183 (WebCore::AccessibilityObject::increment):
4184 (WebCore::AccessibilityObject::decrement):
4185 * accessibility/AccessibilityRenderObject.cpp:
4186 (WebCore::AccessibilityRenderObject::expandObject):
4187 (WebCore::AccessibilityRenderObject::isExpanded):
4188 (WebCore::createARIARoleMap):
4189 * accessibility/AccessibilityRenderObject.h:
4190 * accessibility/mac/AccessibilityObjectWrapper.mm:
4191 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
4192 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
4193 (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
4194 * html/HTMLAttributeNames.in:
4196 2009-11-04 Kelly Norton <knorton@google.com>
4198 Reviewed by Pavel Feldman.
4200 Fixes naming inconsistencies in TimelineRecordFactory.
4201 https://bugs.webkit.org/show_bug.cgi?id=31132
4203 * inspector/InspectorTimelineAgent.cpp:
4204 (WebCore::InspectorTimelineAgent::willPaint):
4205 (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
4206 (WebCore::InspectorTimelineAgent::willLoadXHR):
4207 (WebCore::InspectorTimelineAgent::willEvaluateScript):
4208 (WebCore::InspectorTimelineAgent::willSendResourceRequest):
4209 (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
4210 (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
4211 * inspector/TimelineRecordFactory.cpp:
4212 (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
4213 (WebCore::TimelineRecordFactory::createXHRLoadRecord):
4214 (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
4215 (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
4216 (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
4217 (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
4218 (WebCore::TimelineRecordFactory::createResourceFinishRecord):
4219 (WebCore::TimelineRecordFactory::createPaintRecord):
4220 * inspector/TimelineRecordFactory.h:
4222 2009-11-04 Eric Z. Ayers <zundel@google.com>
4224 Reviewed by Pavel Feldman.
4226 Followon to bug 31080, which protects Timeline
4227 instrumentation in the case where InspectorTimelineAgent
4228 is enabled or disabled during an event dispatch.
4230 https://bugs.webkit.org/show_bug.cgi?id=31121
4232 * bindings/v8/V8Proxy.cpp:
4233 (WebCore::V8Proxy::evaluate):
4235 (WebCore::Document::recalcStyle):
4237 (WebCore::Node::dispatchGenericEvent):
4238 * html/HTMLTokenizer.cpp:
4239 (WebCore::HTMLTokenizer::write):
4240 * page/DOMWindow.cpp:
4241 (WebCore::DOMWindow::inspectorTimelineAgent):
4242 (WebCore::DOMWindow::dispatchEvent):
4244 * page/FrameView.cpp:
4245 (WebCore::FrameView::layout):
4246 (WebCore::FrameView::paintContents):
4247 * xml/XMLHttpRequest.cpp:
4248 (WebCore::XMLHttpRequest::callReadyStateChangeListener):
4250 2009-11-04 Jeremy Orlow <jorlow@chromium.org>
4252 Revert 50519 while I work out what went wrong.
4254 * storage/LocalStorageThread.cpp:
4255 (WebCore::LocalStorageThread::create):
4256 (WebCore::LocalStorageThread::LocalStorageThread):
4257 (WebCore::LocalStorageThread::start):
4258 (WebCore::LocalStorageThread::localStorageThreadStart):
4259 (WebCore::LocalStorageThread::localStorageThread):
4260 (WebCore::LocalStorageThread::scheduleImport):
4261 (WebCore::LocalStorageThread::scheduleSync):
4262 (WebCore::LocalStorageThread::terminate):
4263 (WebCore::LocalStorageThread::performTerminate):
4264 * storage/LocalStorageThread.h:
4265 * storage/StorageSyncManager.cpp:
4266 (WebCore::StorageSyncManager::StorageSyncManager):
4267 (WebCore::StorageSyncManager::~StorageSyncManager):
4268 (WebCore::StorageSyncManager::scheduleImport):
4269 (WebCore::StorageSyncManager::scheduleSync):
4270 * storage/StorageSyncManager.h:
4272 2009-11-04 Pavel Feldman <pfeldman@chromium.org>
4274 Reviewed by Timothy Hatcher.
4276 Web Inspector: Add basic support for resource events and marks.
4277 Couple of drive-by fixes. Enabling the panel!
4279 https://bugs.webkit.org/show_bug.cgi?id=31130
4281 * English.lproj/localizedStrings.js:
4282 * inspector/front-end/TimelinePanel.js:
4283 (WebInspector.TimelinePanel):
4284 (WebInspector.TimelinePanel.prototype._formatRecord):
4285 (WebInspector.TimelinePanel.prototype._getRecordDetails):
4286 (WebInspector.TimelinePanel.prototype.reset):
4287 (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
4288 (WebInspector.TimelineRecordTreeElement.prototype.onattach):
4289 * inspector/front-end/inspector.js:
4290 (WebInspector._createPanels):
4292 2009-11-03 Jeremy Orlow <jorlow@chromium.org>
4294 Reviewed by Darin Fisher.
4296 Simplify LocalStorageThread