WebCore/ChangeLog

   1 2006-11-03  Zack Rusin  <zack@kde.org>
   2
   3         Reviewed and landed by Maciej.
   4
   5         Compile on the Qt platform.
   6
   7         * ksvg2/misc/KCanvasRenderingStyle.h:
   8         * platform/qt/RenderThemeQt.cpp:
   9         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
  10
  11 2006-11-03  Zack Rusin  <zack@kde.org>
  12
  13         Reviewed by Hyatt. Landed by Maciej.
  14
  15         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
  16         to graphics context to be able to set consistant state
  17         on the platform specific painter without having to change
  18         fill/stroke/font on every operation. This fixes color/stroke/fill
  19         and font handling in the Qt port.
  20
  21         * platform/graphics/GraphicsContext.cpp:
  22         (WebCore::GraphicsContext::setFont):
  23         (WebCore::GraphicsContext::setPen):
  24         (WebCore::GraphicsContext::setFillColor):
  25         (WebCore::GraphicsContext::setPlatformPen):
  26         (WebCore::GraphicsContext::setPlatformFillColor):
  27         (WebCore::GraphicsContext::setPlatformFont):
  28         * platform/graphics/GraphicsContext.h:
  29         * platform/qt/GraphicsContextQt.cpp:
  30         (WebCore::toQtCompositionMode):
  31         (WebCore::toQtLineCap):
  32         (WebCore::toQtLineJoin):
  33         (WebCore::toQPenStyle):
  34         (WebCore::penToQPen):
  35         (WebCore::TransparencyLayer::TransparencyLayer):
  36         (WebCore::GraphicsContext::addRoundedRectClip):
  37         (WebCore::GraphicsContext::setPlatformFont):
  38         (WebCore::GraphicsContext::setPlatformPen):
  39         (WebCore::GraphicsContext::setPlatformFillColor):
  40         * platform/qt/ScrollViewCanvasQt.cpp:
  41         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
  42         (WebCore::ScrollViewCanvasQt::paintEvent):
  43         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
  44         * platform/qt/ScrollViewCanvasQt.h:
  45
  46 2006-11-02  Adele Peterson  <adele@apple.com>
  47
  48         Reviewed by Anders.
  49
  50         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
  51         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
  52
  53         Test: fast/forms/textarea-no-scroll-on-blur.html
  54
  55         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
  56           On blur, only scroll back to the start for text fields.
  57
  58 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
  59
  60         Another build fix.
  61
  62         * rendering/RenderFileUploadControl.cpp:
  63         (WebCore::RenderFileUploadControl::paintObject):
  64
  65 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
  66
  67         Build fix.
  68
  69         * page/FramePrivate.h:
  70         (WebCore::FramePrivate::FramePrivate):
  71
  72 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
  73
  74         Reviewed by Geoff, landed by Anders.
  75
  76         Fix dependency problems caused when running move-js-headers.sh
  77
  78         * move-js-headers.sh:
  79         Use cp -p instead of just cp so that the modification time
  80         of the original files are used.
  81
  82 2006-11-02  Adam Roben  <aroben@apple.com>
  83
  84         Reviewed by Tim H, landed by Anders.
  85
  86         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
  87         REGRESSION: Shadow of file upload button is clipped
  88
  89         * rendering/RenderFileUploadControl.cpp:
  90         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
  91         height to keep from clipping in the shadow
  92
  93 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
  94
  95         Reviewed by Maciej, landed by Anders.
  96
  97         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
  98         content and window. ScrollViewQt already receives correct content
  99         coordinates from QScrollArea.
 100         (WebCore::ScrollView::contentsToWindow):
 101         (WebCore::ScrollView::windowToContents):
 102
 103 2006-11-02  Simon Hausmann  <hausmann@kde.org>
 104
 105         Reviewed by Maciej, landed by Anders
 106
 107         * CMakeLists.txt: Make linkage against KDE libraries conditional
 108         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
 109           Qt base resource handler that supports only requests to the
 110           local filesystem. Used when compiling without KDE support.
 111           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
 112           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
 113         (WebCore::QtJob::QtJob):
 114         (WebCore::QtJob::timerEvent):
 115         (WebCore::ResourceHandleManager::ResourceHandleManager):
 116         (WebCore::ResourceHandleManager::~ResourceHandleManager):
 117         (WebCore::ResourceHandleManager::self):
 118         (WebCore::ResourceHandleManager::remove):
 119         (WebCore::ResourceHandleManager::add):
 120         (WebCore::ResourceHandleManager::cancel):
 121         (WebCore::ResourceHandleManager::deliverJobData):
 122         * platform/network/qt/ResourceHandleManager.h:
 123         * platform/qt/FrameQtClient.cpp:
 124         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
 125         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
 126         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
 127         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
 128           input dialog functions when compiling without KDE support
 129         (WebCore::ServeSynchronousRequest):
 130
 131 2006-11-02  David Carson  <dacarson@gmail.com>
 132
 133         Reviewed by Geoff, landed by Anders.
 134
 135         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
 136         Initializing variable in constructor.
 137
 138         * page/FramePrivate.h:
 139         (WebCore::FramePrivate::FramePrivate):
 140
 141 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
 142
 143         Reviewed by Geoff.
 144
 145         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
 146
 147         * platform/network/cf/ResourceHandleCFNet.cpp:
 148         (WebCore::addHeadersFromHashMap):
 149         Don't set all headers at once since that clears any previous headers set.
 150
 151         (WebCore::ResourceHandle::start):
 152
 153 2006-11-02  Adele Peterson  <adele@apple.com>
 154
 155         Reviewed by Mitz and Geoff.
 156
 157         - Fix for:
 158         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
 159         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
 160         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
 161
 162         Test: fast/forms/textarea-scrollbar.html
 163
 164         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
 165         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
 166
 167         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
 168         * rendering/RenderTextControl.cpp:
 169         (WebCore::RenderTextControl::RenderTextControl):
 170         (WebCore::RenderTextControl::setStyle):
 171         (WebCore::RenderTextControl::createDivStyle):
 172         (WebCore::RenderTextControl::updateFromElement):
 173         (WebCore::RenderTextControl::calcHeight):
 174         (WebCore::RenderTextControl::baselinePosition):
 175         (WebCore::RenderTextControl::nodeAtPoint):
 176         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
 177         (WebCore::RenderTextControl::scrollWidth):
 178         (WebCore::RenderTextControl::scrollHeight):
 179         (WebCore::RenderTextControl::scrollLeft):
 180         (WebCore::RenderTextControl::scrollTop):
 181
 182         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
 183
 184 2006-11-02  John Sullivan  <sullivan@apple.com>
 185
 186         Reviewed by Geoff Garen
 187
 188         * editing/Selection.cpp:
 189         (WebCore::Selection::showTreeForThis):
 190         this debugging method now displays start offset and end offset, at Darin's suggestion
 191
 192 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
 193
 194         Reviewed by darin
 195
 196         <rdar://problem/4062865>
 197         Copy/paste of a select element fails to include the options
 198
 199         * editing/SelectionController.cpp:
 200         (WebCore::SelectionController::modify): Added paragraphBoundary.
 201         * editing/htmlediting.cpp:
 202         (WebCore::canHaveChildrenForEditing): Added checks for input elements
 203         and textareas.  Insertion operations would fail when performed just
 204         before/after one of these elements b/c the content would be put inside
 205         the element.
 206         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
 207         editable content, and made the code to stop at an root faster (don't check
 208         isDescendantOf on every iteration).
 209         (WebCore::enclosingNodeOfType): Ditto.
 210         (WebCore::enclosingList): Ditto.
 211         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
 212         inappropriately named.
 213         * editing/markup.cpp:
 214         (WebCore::startMarkup): Use the text node's value instead of its rendered
 215         content for text nodes inside select elements.  One might also turn off
 216         annotation when createMarkup enters a select element, but createMarkup
 217         is iterative, not recursive, so doing so would be complicated.
 218         (WebCore::createMarkup): Add markup for unrendered nodes if they are
 219         descendants of a select element.
 220         * editing/visible_units.cpp:
 221         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
 222         where various replaced elements can't be copied when they are the only
 223         thing selected.
 224         (WebCore::endOfParagraph): Ditto.
 225
 226 2006-11-01  Oliver Hunt  <oliver@apple.com>
 227
 228         Reviewed by Adam.
 229
 230         Converting more or kcanvas/quartz from Obj-C to C++
 231         Minor SVG updates
 232         compatibility fixes
 233
 234         * WebCore.xcodeproj/project.pbxproj:
 235         * kcanvas/device/KRenderingPaintServer.h:
 236         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
 237         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
 238         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
 239         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
 240         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
 241         * kcanvas/device/quartz/QuartzSupport.h:
 242         * ksvg2/css/SVGCSSStyleSelector.cpp:
 243         * ksvg2/misc/KCanvasRenderingStyle.h:
 244         * ksvg2/scripts/cssmakeprops:
 245         * ksvg2/scripts/cssmakevalues:
 246         * ksvg2/scripts/make_names.pl:
 247         * ksvg2/svg/SVGAnimateColorElement.cpp:
 248         * ksvg2/svg/SVGAnimateTransformElement.cpp:
 249         * ksvg2/svg/SVGAnimationElement.cpp:
 250         * ksvg2/svg/SVGMaskElement.cpp:
 251         * ksvg2/svg/SVGPatternElement.cpp:
 252         * ksvg2/svg/svgpathparser.cpp:
 253         * platform/Path.cpp:
 254         * platform/graphics/svg/SVGResourceImage.h:
 255         * rendering/RenderPath.cpp:
 256         * rendering/SVGRenderAsText.cpp:
 257
 258 2006-11-02  Mitz Pettel  <mitz@webkit.org>
 259
 260         Reviewed by Adele.
 261
 262         - Fix a regression from r17521: painting of and crash caused by tables
 263           with collapsed borders
 264
 265         * rendering/RenderTable.cpp:
 266         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
 267         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
 268         and 'paintInfo' is the parameter, which we were accidently modifying.
 269
 270 2006-11-01  Adele Peterson  <adele@apple.com>
 271
 272         Reviewed by Mitz.
 273
 274         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
 275         REGRESSION: Incomplete repaint of overflow areas when deleting
 276
 277         Restrict the repaint rect for overflow blocks after the height has been fully computed.
 278         Also, adjust the repaint rect coordinates for the scroll offset.
 279
 280         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
 281         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
 282
 283 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
 284
 285         Reviewed by Mitz.
 286
 287         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
 288         Rename the "p" member variable of the PaintInfo struct to "context"
 289
 290         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
 291           'context' and 'rect' respectively.
 292
 293         - Assorted surrounding cleanups.
 294
 295         * rendering/EllipsisBox.cpp:
 296         (WebCore::EllipsisBox::paint):
 297         * rendering/EllipsisBox.h:
 298         * rendering/InlineBox.cpp:
 299         (WebCore::InlineBox::paint):
 300         * rendering/InlineFlowBox.cpp:
 301         (WebCore::InlineFlowBox::paint):
 302         (WebCore::InlineFlowBox::paintBackground):
 303         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
 304         (WebCore::InlineFlowBox::paintDecorations):
 305         * rendering/InlineFlowBox.h:
 306         * rendering/InlineRunBox.h:
 307         * rendering/InlineTextBox.cpp:
 308         (WebCore::InlineTextBox::paint):
 309         * rendering/InlineTextBox.h:
 310         * rendering/RenderBlock.cpp:
 311         (WebCore::RenderBlock::paint):
 312         (WebCore::RenderBlock::paintChildren):
 313         (WebCore::RenderBlock::paintCaret):
 314         (WebCore::RenderBlock::paintObject):
 315         (WebCore::RenderBlock::paintFloats):
 316         (WebCore::RenderBlock::paintEllipsisBoxes):
 317         (WebCore::RenderBlock::paintSelection):
 318         (WebCore::RenderBlock::fillSelectionGaps):
 319         (WebCore::RenderBlock::fillInlineSelectionGaps):
 320         (WebCore::RenderBlock::fillBlockSelectionGaps):
 321         (WebCore::RenderBlock::fillHorizontalSelectionGap):
 322         (WebCore::RenderBlock::fillVerticalSelectionGap):
 323         (WebCore::RenderBlock::fillLeftSelectionGap):
 324         (WebCore::RenderBlock::fillRightSelectionGap):
 325         * rendering/RenderBox.cpp:
 326         (WebCore::RenderBox::paint):
 327         (WebCore::RenderBox::paintRootBoxDecorations):
 328         (WebCore::RenderBox::paintBoxDecorations):
 329         * rendering/RenderBox.h:
 330         * rendering/RenderButton.cpp:
 331         (WebCore::RenderButton::paintObject):
 332         * rendering/RenderFieldset.cpp:
 333         (WebCore::RenderFieldset::paintBoxDecorations):
 334         * rendering/RenderFileUploadControl.cpp:
 335         (WebCore::RenderFileUploadControl::paintObject):
 336         * rendering/RenderFlow.cpp:
 337         (WebCore::RenderFlow::continuationBefore):
 338         (WebCore::RenderFlow::addChildWithContinuation):
 339         (WebCore::RenderFlow::addChild):
 340         (WebCore::RenderFlow::attachLineBox):
 341         (WebCore::RenderFlow::destroy):
 342         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
 343         (WebCore::RenderFlow::dirtyLineBoxes):
 344         (WebCore::RenderFlow::createInlineBox):
 345         (WebCore::RenderFlow::paintLines):
 346         (WebCore::RenderFlow::getAbsoluteRepaintRect):
 347         (WebCore::RenderFlow::lowestPosition):
 348         (WebCore::RenderFlow::rightmostPosition):
 349         (WebCore::RenderFlow::leftmostPosition):
 350         (WebCore::RenderFlow::caretRect):
 351         (WebCore::RenderFlow::addFocusRingRects):
 352         (WebCore::RenderFlow::paintOutline):
 353         (WebCore::RenderFlow::paintOutlineForLine):
 354         * rendering/RenderForeignObject.cpp:
 355         (WebCore::RenderForeignObject::paint):
 356         * rendering/RenderHTMLCanvas.cpp:
 357         (WebCore::RenderHTMLCanvas::paint):
 358         * rendering/RenderImage.cpp:
 359         (WebCore::RenderImage::paint):
 360         * rendering/RenderLayer.cpp:
 361         (WebCore::RenderLayer::paintLayer):
 362         * rendering/RenderListBox.cpp:
 363         (WebCore::RenderListBox::paintObject):
 364         (WebCore::RenderListBox::paintScrollbar):
 365         (WebCore::RenderListBox::paintItemForeground):
 366         (WebCore::RenderListBox::paintItemBackground):
 367         * rendering/RenderListMarker.cpp:
 368         (WebCore::RenderListMarker::paint):
 369         * rendering/RenderMenuList.cpp:
 370         (WebCore::RenderMenuList::paintObject):
 371         * rendering/RenderObject.cpp:
 372         (WebCore::RenderObject::paint):
 373         * rendering/RenderObject.h:
 374         (WebCore::RenderObject::PaintInfo::PaintInfo):
 375         (WebCore::RenderObject::paintBoxDecorations):
 376         (WebCore::RenderObject::paintingRootForChildren):
 377         (WebCore::RenderObject::shouldPaintWithinRoot):
 378         (WebCore::RenderObject::printBoxDecorations):
 379         * rendering/RenderPath.cpp:
 380         (WebCore::RenderPath::paint):
 381         * rendering/RenderReplaced.cpp:
 382         (WebCore::RenderReplaced::shouldPaint):
 383         * rendering/RenderSVGContainer.cpp:
 384         (WebCore::RenderSVGContainer::paint):
 385         * rendering/RenderSVGContainer.h:
 386         * rendering/RenderSVGImage.cpp:
 387         (WebCore::RenderSVGImage::paint):
 388         * rendering/RenderSVGText.cpp:
 389         (WebCore::RenderSVGText::paint):
 390         * rendering/RenderSVGText.h:
 391         (WebCore::RenderSVGText::renderName):
 392         * rendering/RenderTable.cpp:
 393         (WebCore::RenderTable::paint):
 394         (WebCore::RenderTable::paintBoxDecorations):
 395         * rendering/RenderTable.h:
 396         * rendering/RenderTableCell.cpp:
 397         (WebCore::RenderTableCell::paint):
 398         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
 399         (WebCore::RenderTableCell::paintBoxDecorations):
 400         * rendering/RenderTableCell.h:
 401         * rendering/RenderTableRow.cpp:
 402         (WebCore::RenderTableRow::paint):
 403         * rendering/RenderTableRow.h:
 404         * rendering/RenderTableSection.cpp:
 405         (WebCore::RenderTableSection::paint):
 406         * rendering/RenderTableSection.h:
 407         (WebCore::RenderTableSection::getBaseline):
 408         (WebCore::RenderTableSection::setNeedCellRecalc):
 409         * rendering/RenderText.h:
 410         (WebCore::RenderText::renderName):
 411         (WebCore::RenderText::paint):
 412         (WebCore::RenderText::element):
 413         * rendering/RenderTheme.cpp:
 414         (WebCore::RenderTheme::paint):
 415         (WebCore::RenderTheme::paintBorderOnly):
 416         (WebCore::RenderTheme::paintDecorations):
 417         * rendering/RenderTheme.h:
 418         (WebCore::RenderTheme::RenderTheme):
 419         (WebCore::RenderTheme::~RenderTheme):
 420         (WebCore::RenderTheme::controlSupportsTints):
 421         (WebCore::RenderTheme::adjustRepaintRect):
 422         (WebCore::RenderTheme::themeChanged):
 423         (WebCore::RenderTheme::supportsHover):
 424         (WebCore::RenderTheme::paintCheckbox):
 425         (WebCore::RenderTheme::setCheckboxSize):
 426         (WebCore::RenderTheme::paintRadio):
 427         (WebCore::RenderTheme::setRadioSize):
 428         (WebCore::RenderTheme::paintButton):
 429         (WebCore::RenderTheme::setButtonSize):
 430         (WebCore::RenderTheme::paintTextField):
 431         (WebCore::RenderTheme::paintTextArea):
 432         (WebCore::RenderTheme::paintMenuList):
 433         (WebCore::RenderTheme::paintMenuListButton):
 434         * rendering/RenderThemeMac.mm:
 435         (WebCore::RenderThemeMac::paintCheckbox):
 436         (WebCore::RenderThemeMac::paintRadio):
 437         (WebCore::RenderThemeMac::paintButton):
 438         (WebCore::RenderThemeMac::paintTextField):
 439         (WebCore::RenderThemeMac::paintTextArea):
 440         (WebCore::RenderThemeMac::paintMenuList):
 441         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
 442         (WebCore::RenderThemeMac::paintMenuListButton):
 443         * rendering/RenderView.cpp:
 444         (WebCore::RenderView::paint):
 445         (WebCore::RenderView::paintBoxDecorations):
 446         * rendering/RenderView.h:
 447         * rendering/RenderWidget.cpp:
 448         (WebCore::RenderWidget::paint):
 449         * rendering/RenderWidget.h:
 450         (WebCore::RenderWidget::isWidget):
 451         * rendering/RootInlineBox.cpp:
 452         (WebCore::RootInlineBox::paintEllipsisBox):
 453         (WebCore::RootInlineBox::paintCustomHighlight):
 454         (WebCore::RootInlineBox::paint):
 455         (WebCore::RootInlineBox::fillLineSelectionGap):
 456         * rendering/RootInlineBox.h:
 457         * rendering/SVGInlineFlowBox.cpp:
 458         (WebCore::paintSVGInlineFlow):
 459
 460 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
 461
 462         Reviewed by Oliver, Brady.
 463
 464         * platform/network/ResourceResponse.h:
 465         (WebCore::ResourceResponse::setLastModifiedDate):
 466         (WebCore::ResourceResponse::lastModifiedDate):
 467         Add getters and setters for last modified dadte.
 468
 469         * platform/network/cf/ResourceResponseCFNet.cpp:
 470         (WebCore::getResourceResponse):
 471         Fetch the last modified date. Add correct offset to expired date.
 472
 473 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
 474
 475         Reviewed by Mitz.
 476
 477         Added missing "break;" statement in switch statement from r17493.
 478
 479         Bug 11442: [CSS 3] support for cursor: all-scroll
 480         http://bugs.webkit.org/show_bug.cgi?id=11442
 481
 482         * css/CSSComputedStyleDeclaration.cpp:
 483         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 484
 485 2006-10-31  Mitz Pettel  <mitz@webkit.org>
 486
 487         Reviewed by Maciej.
 488
 489         - fix image dragging
 490
 491         This is covered by editing/selection/drag-to-contenteditable-iframe.html
 492
 493         * rendering/HitTestResult.cpp:
 494         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
 495         HTML IMG elements.
 496         (WebCore::HitTestResult::absoluteImageURL): Ditto.
 497
 498 2006-10-31  Beth Dakin  <bdakin@apple.com>
 499
 500         Reviewed by Maciej.
 501
 502         This adds the back-end of the remaining WebElementDictionary
 503         functions into HitTestResult.
 504
 505         * WebCore.exp:
 506         * rendering/HitTestResult.cpp:
 507         (WebCore::HitTestResult::title):
 508         (WebCore::displayString): This is nearly identical to the
 509         displayString() defined in DOMInternal.mm except that it returns a
 510         String instead of an NSString. The old code path used the
 511         DOMInternal method, so I made a new one here for the new code path.
 512         (WebCore::HitTestResult::altDisplayString):
 513         (WebCore::HitTestResult::image):
 514         (WebCore::HitTestResult::absoluteImageURL):
 515         (WebCore::HitTestResult::absoluteLinkURL):
 516         (WebCore::HitTestResult::titleDisplayString):
 517         (WebCore::HitTestResult::textContent):
 518         * rendering/HitTestResult.h:
 519
 520 2006-10-31  John Sullivan  <sullivan@apple.com>
 521
 522         * bridge/mac/FrameMac.mm:
 523         (WebCore::FrameMac::markMisspellings):
 524         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
 525
 526 2006-10-31  John Sullivan  <sullivan@apple.com>
 527
 528         Reviewed by Maciej
 529
 530         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
 531
 532         The foundation of this was in my last checkin. This checkin is all about displaying
 533         the correct string in the toolTip.
 534
 535         * dom/DocumentMarker.h:
 536         New description field in this struct.
 537
 538         * bridge/mac/FrameMac.mm:
 539         (WebCore::FrameMac::advanceToNextMisspelling):
 540         When adding a grammar marker, supply the appropriate description. Also, added a comment
 541         about the remaining work to make grammar checking return sensible answers.
 542         (WebCore::FrameMac::markMisspellings):
 543         ditto (yes, still needs some refactoring to minimize duplicated code)
 544
 545         * dom/Document.h:
 546         * dom/Document.cpp:
 547         (WebCore::Document::addMarker):
 548         Now takes an optional description string
 549         (WebCore::Document::markerContainingPoint):
 550         New function, returns a pointer to the (first) marker of the specified type whose rect
 551         contains the specified point, or 0 if none.
 552
 553         * rendering/HitTestResult.cpp:
 554         (WebCore::HitTestResult::spellingToolTip):
 555         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
 556         and gets the description from the marker.
 557
 558 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
 559
 560         Reviewed by Maciej.
 561
 562         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
 563
 564         * loader/mac/FrameLoaderMac.mm:
 565         (WebCore::FrameLoader::createWindow):
 566         * manual-tests/window-open-features-parsing.html: Updated for clarity.
 567
 568 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
 569
 570         Reviewed by Alice.
 571
 572         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
 573         to WebCore::Editor.
 574
 575         Layout tests pass.
 576
 577         Renamed "may*" to "can*" because "can" is more accurate (these functions
 578         aren't just about permission) and it matches WebKit.
 579
 580         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
 581         password field. Now that WebCore fully implements canCopy(), it doesn't just
 582         mean "the selection is not in a password field" anymore.
 583         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
 584         The fact that it's not called anymore may represent a security issue, but I
 585         don't see how commented-out code will help reveal the issue, and the
 586         bridge is going away, anyway.
 587         * editing/SelectionController.h: Changed selection() calls to references
 588         to m_sel, to match the rest of the file.
 589
 590 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
 591
 592         Reviewed by harrison
 593
 594         <rdar://problem/4711063>
 595         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
 596
 597         * editing/ReplaceSelectionCommand.cpp:
 598         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
 599         insertion and plain text string creation unless we need the string
 600         for a BeforeTextInserted event handler or for a plain text only region.
 601         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
 602         code here from ReplacementFragment's constructor.
 603         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
 604         FIXME.
 605         * editing/ReplaceSelectionCommand.h:
 606
 607 2006-10-31  Ada Chan  <adachan@apple.com>
 608
 609         Reviewed by Adam
 610
 611         Correct forward declarations of the HitTestRequest struct.
 612
 613         * rendering/EllipsisBox.h:
 614         * rendering/InlineBox.h:
 615         * rendering/InlineFlowBox.h:
 616         * rendering/RenderLayer.h:
 617         * rendering/RenderObject.h:
 618
 619 2006-10-31  John Sullivan  <sullivan@apple.com>
 620
 621         Reviewed by Beth and Adam
 622
 623         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
 624         next I'll make it use a string that's relevant for a specific grammar error.
 625
 626         * WebCore.exp:
 627         export symbol for spellingToolTip function
 628
 629         * rendering/HitTestResult.h:
 630         * rendering/HitTestResult.cpp:
 631         (WebCore::HitTestResult::spellingToolTip):
 632         new function, returns the string to be used in a tool tip that describes the questionable grammar
 633
 634         * rendering/InlineTextBox.h:
 635         * rendering/InlineTextBox.cpp:
 636         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
 637         now takes a style and font, needed to compute the rect representing the range containing
 638         questionable grammar. Computes the rect and associates it with the marker.
 639         (WebCore::InlineTextBox::paintDocumentMarkers):
 640         Pass in the style and font now needed by paintSpellingOrGrammarMarker
 641
 642 2006-10-31  Adele Peterson  <adele@apple.com>
 643
 644         Removed commented out variable from last checkin.
 645
 646         * html/HTMLSelectElement.cpp:
 647         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 648
 649 2006-10-31  Brady Eidson  <beidson@apple.com>
 650
 651         Build fix (unused variable in release builds)
 652
 653         * html/HTMLSelectElement.cpp:
 654         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 655
 656 2006-10-31  Adele Peterson  <adele@apple.com>
 657
 658         Reviewed by Adam.
 659
 660         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
 661         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
 662         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
 663
 664         Tests:
 665         * LayoutTests/fast/forms/listbox-selection.html
 666         * LayoutTests/fast/forms/listbox-onchange.html
 667
 668         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
 669           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
 670           And one for onChange, that is updated after onChange is fired.
 671           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
 672
 673         * html/HTMLSelectElement.cpp:
 674         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
 675         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
 676         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
 677         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
 678         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
 679         (WebCore::HTMLSelectElement::setExtent): Added.
 680         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
 681         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
 682
 683         * rendering/RenderListBox.cpp:
 684         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
 685         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
 686         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
 687         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
 688          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
 689          notify the select element from here.
 690         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
 691         (WebCore::RenderListBox::listIndexIsVisible): Added.
 692         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
 693
 694         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction,
 695         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
 696         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
 697         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
 698         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
 699
 700 2006-10-31  Beth Dakin  <bdakin@apple.com>
 701
 702         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
 703
 704         * rendering/HitTestRequest.h: Added.
 705         (WebCore::HitTestRequest::HitTestRequest):
 706
 707 2006-10-31  Beth Dakin  <bdakin@apple.com>
 708
 709         Reviewed by Maciej.
 710
 711         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
 712         should be split into HitTestRequest and HitTestResult
 713
 714         This patch creates a new struct called HitTestRequest that holds
 715         the three boolean values (readonly, active, and mouseMove) that
 716         were formerly a part of HitTestResult. All hitTest() and
 717         nodeAtPoint() functions now take a HitTestRequest in addition to
 718         the HitTestResult.
 719
 720         * WebCore.exp:
 721         * WebCore.xcodeproj/project.pbxproj:
 722         * bridge/mac/FrameMac.mm:
 723         (WebCore::FrameMac::eventMayStartDrag):
 724         (WebCore::FrameMac::handleMouseMoveEvent):
 725         * bridge/mac/WebCoreAXObject.mm:
 726         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
 727         (-[WebCoreAXObject accessibilityHitTest:]):
 728         * dom/Document.cpp:
 729         (WebCore::Document::elementFromPoint):
 730         (WebCore::Document::prepareMouseEvent):
 731         * editing/SelectionController.cpp:
 732         (WebCore::SelectionController::contains):
 733         * page/Frame.cpp:
 734         (WebCore::Frame::hitTestResultAtPoint):
 735         * page/FrameView.cpp:
 736         (WebCore::FrameView::handleWheelEvent):
 737         * rendering/EllipsisBox.cpp:
 738         (WebCore::EllipsisBox::nodeAtPoint):
 739         * rendering/EllipsisBox.h:
 740         * rendering/HitTestResult.cpp:
 741         (WebCore::HitTestResult::HitTestResult):
 742         (WebCore::HitTestResult::operator=):
 743         * rendering/HitTestResult.h:
 744         * rendering/InlineBox.cpp:
 745         (WebCore::InlineBox::nodeAtPoint):
 746         * rendering/InlineBox.h:
 747         * rendering/InlineFlowBox.cpp:
 748         (WebCore::InlineFlowBox::nodeAtPoint):
 749         * rendering/InlineFlowBox.h:
 750         * rendering/InlineTextBox.cpp:
 751         (WebCore::InlineTextBox::nodeAtPoint):
 752         * rendering/InlineTextBox.h:
 753         * rendering/RenderBlock.cpp:
 754         (WebCore::RenderBlock::nodeAtPoint):
 755         * rendering/RenderBlock.h:
 756         * rendering/RenderBox.cpp:
 757         (WebCore::RenderBox::nodeAtPoint):
 758         * rendering/RenderBox.h:
 759         * rendering/RenderFlow.cpp:
 760         (WebCore::RenderFlow::hitTestLines):
 761         * rendering/RenderFlow.h:
 762         * rendering/RenderForeignObject.cpp:
 763         (WebCore::RenderForeignObject::nodeAtPoint):
 764         * rendering/RenderForeignObject.h:
 765         * rendering/RenderFrameSet.cpp:
 766         (WebCore::RenderFrameSet::nodeAtPoint):
 767         * rendering/RenderFrameSet.h:
 768         * rendering/RenderImage.cpp:
 769         (WebCore::RenderImage::nodeAtPoint):
 770         * rendering/RenderImage.h:
 771         * rendering/RenderInline.cpp:
 772         (WebCore::RenderInline::nodeAtPoint):
 773         * rendering/RenderInline.h:
 774         * rendering/RenderLayer.cpp:
 775         (WebCore::RenderLayer::autoscroll):
 776         (WebCore::RenderLayer::hitTest):
 777         (WebCore::RenderLayer::hitTestLayer):
 778         (WebCore::RenderLayer::updateHoverActiveState):
 779         * rendering/RenderLayer.h:
 780         * rendering/RenderObject.cpp:
 781         (WebCore::RenderObject::hitTest):
 782         (WebCore::RenderObject::nodeAtPoint):
 783         * rendering/RenderObject.h:
 784         * rendering/RenderPath.cpp:
 785         (WebCore::RenderPath::nodeAtPoint):
 786         * rendering/RenderPath.h:
 787         * rendering/RenderSVGImage.cpp:
 788         (WebCore::RenderSVGImage::nodeAtPoint):
 789         * rendering/RenderSVGImage.h:
 790         * rendering/RenderSVGText.cpp:
 791         (WebCore::RenderSVGText::nodeAtPoint):
 792         * rendering/RenderSVGText.h:
 793         * rendering/RenderTableRow.cpp:
 794         (WebCore::RenderTableRow::nodeAtPoint):
 795         * rendering/RenderTableRow.h:
 796         * rendering/RenderTableSection.cpp:
 797         (WebCore::RenderTableSection::nodeAtPoint):
 798         * rendering/RenderTableSection.h:
 799         * rendering/RenderText.h:
 800         (WebCore::RenderText::nodeAtPoint):
 801         * rendering/RenderTextControl.cpp:
 802         (WebCore::RenderTextControl::nodeAtPoint):
 803         * rendering/RenderTextControl.h:
 804         * rendering/RootInlineBox.cpp:
 805         (WebCore::RootInlineBox::nodeAtPoint):
 806         * rendering/RootInlineBox.h:
 807
 808 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
 809
 810         Reviewed by Maciej.
 811
 812         Bug 11442: [CSS 3] support for cursor: all-scroll
 813         http://bugs.webkit.org/show_bug.cgi?id=11442
 814
 815         * css/CSSComputedStyleDeclaration.cpp:
 816         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
 817         * css/CSSValueKeywords.in:
 818         * css/cssparser.cpp:
 819         (WebCore::CSSParser::parseValue):
 820         * page/FrameView.cpp:
 821         (WebCore::selectCursor):
 822         * rendering/RenderStyle.h:
 823
 824 2006-10-31  Oliver Hunt  <oliver@apple.com>
 825
 826         Reviewed by Geoff.
 827
 828         Converting Obj-C++ to C++ in kcanvas
 829
 830         * WebCore.xcodeproj/project.pbxproj:
 831         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
 832         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
 833         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
 834         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
 835         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
 836         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
 837         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
 838         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
 839         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
 840         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
 841         * kcanvas/device/quartz/QuartzSupport.h:
 842         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
 843         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
 844         (WebCore::SVGResourceClipper::applyClip):
 845         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
 846         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
 847         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
 848
 849 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
 850
 851         Reviewed by harrison
 852
 853         <rdar://problem/4808375>
 854         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
 855
 856         Completely back out r17276 because of performance issues.
 857
 858         * editing/TextIterator.cpp:
 859         (WebCore::TextIterator::TextIterator):
 860         (WebCore::TextIterator::advance):
 861         (WebCore::TextIterator::handleTextNode):
 862         (WebCore::TextIterator::handleTextBox):
 863         (WebCore::TextIterator::handleReplacedElement):
 864         (WebCore::TextIterator::handleNonTextNode):
 865         (WebCore::TextIterator::exitNode):
 866         (WebCore::TextIterator::emitCharacter):
 867         (WebCore::TextIterator::range):
 868         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
 869         (WebCore::SimplifiedBackwardsTextIterator::advance):
 870         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
 871         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
 872         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
 873         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
 874         (WebCore::SimplifiedBackwardsTextIterator::range):
 875         (WebCore::CharacterIterator::range):
 876         (WebCore::TextIterator::rangeFromLocationAndLength):
 877         * editing/TextIterator.h:
 878         (WebCore::TextIterator::atEnd):
 879         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
 880
 881 2006-10-31  Darin Adler  <darin@apple.com>
 882
 883         Reviewed by Brady.
 884
 885         - got "action dictionary" code out of FrameLoader,
 886           replacing with a class called NavigationAction
 887
 888         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
 889         * loader/mac/DocumentLoaderMac.mm:
 890         (WebCore::DocumentLoader::triggeringAction): Ditto.
 891         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
 892
 893         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
 894
 895         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
 896         Removed elementForEvent.
 897         * loader/mac/FrameLoaderMac.mm:
 898         (WebCore::FrameLoader::load): Ditto.
 899         (WebCore::FrameLoader::reload): Ditto.
 900         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
 901         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
 902         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
 903         (WebCore::FrameLoader::post): Ditto.
 904
 905         * loader/NavigationAction.h: Added.
 906         * loader/NavigationAction.cpp: Added.
 907         * loader/mac/NavigationActionMac.mm: Added.
 908
 909         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
 910
 911         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
 912         * WebCore.exp: Updated.
 913
 914 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
 915
 916         Reviewed by Adam.
 917
 918         Build fix
 919
 920         * platform/win/CookieJarWin.cpp:
 921         (WebCore::cookies):
 922
 923 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
 924
 925         Reviewed by Maciej. Landed by Adam.
 926
 927         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
 928
 929         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
 930         as dicussed with Dave. Also kill the outdated DESIGN document.
 931
 932         * CMakeLists.txt:
 933         * WebCore.xcodeproj/project.pbxproj:
 934         * kcanvas/DESIGN: Removed.
 935         * kcanvas/KCanvasFilters.cpp:
 936         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
 937         * kcanvas/KCanvasTreeDebug.h: Ditto.
 938         * kcanvas/device/KRenderingPaintServerGradient.cpp:
 939         * kcanvas/device/KRenderingPaintServerPattern.cpp:
 940         * kcanvas/device/KRenderingPaintServerSolid.cpp:
 941         * platform/graphics/svg/SVGResourceClipper.cpp:
 942         * rendering/RenderTreeAsText.cpp:
 943         * rendering/SVGRenderTreeAsText.cpp: Added.
 944         * rendering/SVGRenderTreeAsText.h: Added.
 945         (WebCore::operator<<):
 946
 947 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
 948
 949         Reviewed by Maciej.
 950
 951         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
 952         Includes some CRLF -> LF fixups.
 953
 954         * platform/win/CookieJarWin.cpp:
 955         (WebCore::cookies):
 956
 957 2006-10-31  Adam Roben  <aroben@apple.com>
 958
 959         Reviewed by Steve.
 960
 961         Fix some incorrect forward declarations.
 962
 963         * loader/FrameLoader.h:
 964         * page/Frame.h:
 965
 966 2006-10-31  Darin Adler  <darin@apple.com>
 967
 968         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
 969         try to fix the build on the buildbot.
 970
 971 2006-10-31  Darin Adler  <darin@apple.com>
 972
 973         * bridge/mac/FrameMac.mm:
 974         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
 975         (WebCore::FrameMac::markMisspellings): Ditto.
 976
 977 2006-10-31  John Sullivan  <sullivan@apple.com>
 978
 979         * bridge/mac/FrameMac.mm:
 980         (WebCore::FrameMac::advanceToNextMisspelling):
 981         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
 982
 983 2006-10-30  John Sullivan  <sullivan@apple.com>
 984
 985         Reviewed by Adam Roben
 986
 987         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
 988
 989         This patch introduces much of the guts of grammar checking, though still not enough to actually
 990         check grammar sensibly, due to:
 991
 992         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
 993         context passed to grammar checker
 994
 995         * platform/Logging.h:
 996         * platform/Logging.cpp:
 997         new log channel SpellingAndGrammar
 998
 999         * bridge/mac/WebCorePageBridge.mm:
1000         (initializeLoggingChannelsIfNecessary):
1001         initialize new log channel
1002
1003         * bridge/mac/FrameMac.mm:
1004         (WebCore::FrameMac::advanceToNextMisspelling):
1005         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
1006         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
1007         in the event of a tie), and do further processing with that one (select range; create marker that
1008         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
1009         (WebCore::FrameMac::markMisspellings):
1010         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
1011         differently enough to make sharing code between these two functions a little tricky, so I decided to
1012         save that for a later patch.
1013
1014         (WebCore::FrameMac::respondToChangedSelection):
1015         remove grammar markers when we remove spelling markers
1016
1017 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
1018
1019         Reviewed by Mitz.
1020
1021         Fix Qt/Linux build with older gcc3.3.4.
1022
1023         * bindings/js/kjs_window.cpp:
1024         (KJS::WindowFunc::callAsFunction):
1025
1026 2006-10-31  Zack Rusin  <zack@kde.org>
1027
1028         Reviewed by Mitz.
1029
1030         Fix the Qt build after last nights changes.
1031
1032         * WebCore/platform/qt/FrameQt.cpp:
1033         * WebCore/platform/qt/EditorClientQt.h:
1034         * WebCore/platform/qt/EditorClientQt.cpp:
1035         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1036         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1037         * WebCore/CMakeLists.txt:
1038         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
1039         * WebKitQt/QtLauncher/CMakeLists.txt:
1040         * WebKitQt/WebKitPart/CMakeLists.txt:
1041
1042 2006-10-30  Darin Adler  <darin@apple.com>
1043
1044         Reviewed by Anders.
1045
1046         - remove BrowserExtension
1047
1048         * WebCore.vcproj/WebCore/WebCore.vcproj:
1049         * WebCore.xcodeproj/project.pbxproj:
1050         * bindings/js/kjs_window.cpp:
1051         (KJS::createNewWindow):
1052         (KJS::WindowFunc::callAsFunction):
1053         * bridge/BrowserExtension.h: Removed.
1054         * bridge/mac/BrowserExtensionMac.h: Removed.
1055         * bridge/mac/BrowserExtensionMac.mm: Removed.
1056         * bridge/mac/FrameMac.mm:
1057         (WebCore::FrameMac::FrameMac):
1058         (WebCore::FrameMac::submitForm):
1059         (WebCore::FrameMac::urlSelected):
1060         * bridge/win/BrowserExtensionWin.cpp: Removed.
1061         * bridge/win/BrowserExtensionWin.h: Removed.
1062         * bridge/win/FrameWin.cpp:
1063         (WebCore::FrameWin::FrameWin):
1064         * loader/FrameLoader.cpp:
1065         (WebCore::FrameLoader::createWindow):
1066         * loader/FrameLoader.h:
1067         * loader/icon/IconLoader.cpp:
1068         * loader/mac/FrameLoaderMac.mm:
1069         (WebCore::FrameLoader::safeLoad):
1070         (WebCore::FrameLoader::load):
1071         (WebCore::FrameLoader::createWindow):
1072         * page/Frame.cpp:
1073         (WebCore::Frame::urlSelected):
1074         (WebCore::Frame::requestFrame):
1075         (WebCore::Frame::submitForm):
1076         (WebCore::Frame::scheduleHistoryNavigation):
1077         (WebCore::Frame::redirectionTimerFired):
1078         * page/Frame.h:
1079         * page/FrameLoadRequest.h:
1080         (WebCore::FrameLoadRequest::FrameLoadRequest):
1081         (WebCore::FrameLoadRequest::isEmpty):
1082         (WebCore::FrameLoadRequest::resourceRequest):
1083         (WebCore::FrameLoadRequest::frameName):
1084         (WebCore::FrameLoadRequest::setFrameName):
1085         * page/FramePrivate.h:
1086         (WebCore::FramePrivate::FramePrivate):
1087         (WebCore::FramePrivate::~FramePrivate):
1088         * platform/gdk/BrowserExtensionGdk.h: Removed.
1089         * platform/gdk/FrameGdk.cpp:
1090         (WebCore::FrameGdk::FrameGdk):
1091         * platform/gdk/TemporaryLinkStubs.cpp:
1092         * platform/network/ResourceRequest.h:
1093         (WebCore::ResourceRequest::isEmpty):
1094
1095 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1096
1097         Reviewed by Oliver.
1098
1099         Modified from original due to earlier reversion
1100
1101         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1102
1103         Better SVG integration in WebKit, Part I.
1104
1105         The patch is mostly about creating a new platform/graphics directory, and
1106         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1107         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1108         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1109
1110         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1111         All details of the patch, and upcoming patches can be found in the bug report.
1112
1113         * CMakeLists.txt:
1114         * WebCore.xcodeproj/project.pbxproj:
1115         * graphics/svg/SVGResource.cpp: Removed.
1116         * graphics/svg/SVGResourceClipper.cpp: Removed.
1117         * graphics/svg/SVGResourceClipper.h: Removed.
1118         * graphics/svg/SVGResourceImage.h: Removed.
1119         * graphics/svg/SVGResourceListener.h: Removed.
1120         * graphics/svg/SVGResourceMarker.cpp: Removed.
1121         * graphics/svg/SVGResourceMarker.h: Removed.
1122         * graphics/svg/SVGResourceMasker.cpp: Removed.
1123         * graphics/svg/SVGResourceMasker.h: Removed.
1124         * kcanvas/KCanvasClipper.cpp: Removed.
1125         * kcanvas/KCanvasClipper.h: Removed.
1126         * kcanvas/KCanvasCreator.cpp: Removed.
1127         * kcanvas/KCanvasCreator.h: Removed.
1128         * kcanvas/KCanvasFilters.cpp:
1129         (WebCore::getFilterById):
1130         * kcanvas/KCanvasFilters.h:
1131         * kcanvas/KCanvasImage.h: Removed.
1132         * kcanvas/KCanvasMarker.cpp: Removed.
1133         * kcanvas/KCanvasMarker.h: Removed.
1134         * kcanvas/KCanvasMasker.cpp: Removed.
1135         * kcanvas/KCanvasMasker.h: Removed.
1136         * kcanvas/KCanvasResource.cpp: Removed.
1137         * kcanvas/KCanvasResource.h: Removed.
1138         * kcanvas/KCanvasResourceListener.h: Removed.
1139         * kcanvas/KCanvasTreeDebug.cpp:
1140         (WebCore::writeRenderResources):
1141         * kcanvas/device/KRenderingDevice.h:
1142         * kcanvas/device/KRenderingPaintServer.h:
1143         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1144         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1145         (WebCore::KRenderingPaintServerGradient::listener):
1146         (WebCore::KRenderingPaintServerGradient::setListener):
1147         * kcanvas/device/KRenderingPaintServerGradient.h:
1148         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1149         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1150         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1151         (WebCore::KRenderingPaintServerPattern::tile):
1152         (WebCore::KRenderingPaintServerPattern::setTile):
1153         (WebCore::KRenderingPaintServerPattern::listener):
1154         (WebCore::KRenderingPaintServerPattern::setListener):
1155         * kcanvas/device/KRenderingPaintServerPattern.h:
1156         * kcanvas/device/KRenderingPaintServerSolid.h:
1157         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1158         * kcanvas/device/qt/KCanvasClipperQt.h:
1159         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1160         (WebCore::KRenderingDeviceQt::contextForImage):
1161         (WebCore::KRenderingDeviceQt::createResource):
1162         (WebCore::KRenderingDeviceQt::createPaintServer):
1163         * kcanvas/device/qt/KRenderingDeviceQt.h:
1164         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1165         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1166         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1167         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1168         * kcanvas/device/qt/RenderPathQt.h: Removed.
1169         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1170         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1171         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1172         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1173         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1174         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1175         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1176         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1177         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1178         (WebCore::KRenderingDeviceQuartz::contextForImage):
1179         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1180         (WebCore::KRenderingDeviceQuartz::createResource):
1181         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1182         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1183         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1184         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1185         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1186         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1187         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1188         (WebCore::patternCallback):
1189         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1190         * kcanvas/device/quartz/QuartzSupport.mm:
1191         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1192         (WebCore::sharedSolidPaintServer):
1193         * ksvg2/svg/SVGClipPathElement.cpp:
1194         (WebCore::SVGClipPathElement::SVGClipPathElement):
1195         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1196         (WebCore::SVGClipPathElement::canvasResource):
1197         * ksvg2/svg/SVGClipPathElement.h:
1198         * ksvg2/svg/SVGFEImageElement.cpp:
1199         * ksvg2/svg/SVGFilterElement.cpp:
1200         (WebCore::SVGFilterElement::SVGFilterElement):
1201         (WebCore::SVGFilterElement::~SVGFilterElement):
1202         (WebCore::SVGFilterElement::canvasResource):
1203         * ksvg2/svg/SVGFilterElement.h:
1204         * ksvg2/svg/SVGGradientElement.cpp:
1205         (WebCore::SVGGradientElement::SVGGradientElement):
1206         (WebCore::SVGGradientElement::~SVGGradientElement):
1207         (WebCore::SVGGradientElement::canvasResource):
1208         (WebCore::SVGGradientElement::resourceNotification):
1209         * ksvg2/svg/SVGGradientElement.h:
1210         * ksvg2/svg/SVGImageElement.cpp:
1211         * ksvg2/svg/SVGLinearGradientElement.cpp:
1212         (WebCore::SVGLinearGradientElement::buildGradient):
1213         * ksvg2/svg/SVGLinearGradientElement.h:
1214         * ksvg2/svg/SVGMarkerElement.cpp:
1215         (WebCore::SVGMarkerElement::SVGMarkerElement):
1216         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1217         (WebCore::SVGMarkerElement::canvasResource):
1218         * ksvg2/svg/SVGMarkerElement.h:
1219         * ksvg2/svg/SVGMaskElement.cpp:
1220         (WebCore::SVGMaskElement::SVGMaskElement):
1221         (WebCore::SVGMaskElement::~SVGMaskElement):
1222         (WebCore::SVGMaskElement::drawMaskerContent):
1223         (WebCore::SVGMaskElement::canvasResource):
1224         * ksvg2/svg/SVGMaskElement.h:
1225         * ksvg2/svg/SVGPatternElement.cpp:
1226         (WebCore::SVGPatternElement::SVGPatternElement):
1227         (WebCore::SVGPatternElement::~SVGPatternElement):
1228         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1229         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1230         (WebCore::SVGPatternElement::canvasResource):
1231         * ksvg2/svg/SVGPatternElement.h:
1232         * ksvg2/svg/SVGRadialGradientElement.cpp:
1233         (WebCore::SVGRadialGradientElement::buildGradient):
1234         * ksvg2/svg/SVGRadialGradientElement.h:
1235         * ksvg2/svg/SVGStyledElement.h:
1236         (WebCore::SVGStyledElement::canvasResource):
1237         * platform/GraphicsContext.cpp: Removed.
1238         * platform/GraphicsContext.h: Removed.
1239         * platform/GraphicsTypes.cpp: Removed.
1240         * platform/GraphicsTypes.h: Removed.
1241         * platform/graphics/GraphicsContext.cpp:
1242         (WebCore::GraphicsContextState::GraphicsContextState):
1243         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1244         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1245         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1246         (WebCore::GraphicsContext::save):
1247         (WebCore::GraphicsContext::restore):
1248         (WebCore::GraphicsContext::font):
1249         (WebCore::GraphicsContext::setFont):
1250         (WebCore::GraphicsContext::pen):
1251         (WebCore::GraphicsContext::setPen):
1252         (WebCore::GraphicsContext::setFillColor):
1253         (WebCore::GraphicsContext::fillColor):
1254         (WebCore::GraphicsContext::updatingControlTints):
1255         (WebCore::GraphicsContext::setUpdatingControlTints):
1256         (WebCore::GraphicsContext::setPaintingDisabled):
1257         (WebCore::GraphicsContext::paintingDisabled):
1258         (WebCore::GraphicsContext::drawImage):
1259         (WebCore::GraphicsContext::drawText):
1260         (WebCore::GraphicsContext::drawHighlightForText):
1261         (WebCore::GraphicsContext::initFocusRing):
1262         (WebCore::GraphicsContext::clearFocusRing):
1263         (WebCore::GraphicsContext::focusRingBoundingRect):
1264         (WebCore::GraphicsContext::addFocusRingRect):
1265         (WebCore::GraphicsContext::focusRingWidth):
1266         (WebCore::GraphicsContext::focusRingOffset):
1267         (WebCore::GraphicsContext::focusRingRects):
1268         (WebCore::GraphicsContext::drawTiledImage):
1269         * platform/graphics/GraphicsContext.h:
1270         * platform/graphics/GraphicsTypes.cpp:
1271         (WebCore::):
1272         (WebCore::parseCompositeOperator):
1273         (WebCore::compositeOperatorName):
1274         (WebCore::parseLineCap):
1275         (WebCore::lineCapName):
1276         (WebCore::parseLineJoin):
1277         (WebCore::lineJoinName):
1278         * platform/graphics/GraphicsTypes.h:
1279         (WebCore::):
1280         * platform/graphics/svg/SVGResource.cpp: Added.
1281         (WebCore::SVGResource::SVGResource):
1282         (WebCore::SVGResource::~SVGResource):
1283         (WebCore::SVGResource::invalidate):
1284         (WebCore::SVGResource::addClient):
1285         (WebCore::SVGResource::clients):
1286         (WebCore::SVGResource::idInRegistry):
1287         (WebCore::SVGResource::setIdInRegistry):
1288         (WebCore::SVGResource::externalRepresentation):
1289         (WebCore::getResourceById):
1290         (WebCore::getPaintServerById):
1291         (WebCore::operator<<):
1292         * platform/graphics/svg/SVGResource.h: Added.
1293         (WebCore::):
1294         (WebCore::SVGResource::isPaintServer):
1295         (WebCore::SVGResource::isFilter):
1296         (WebCore::SVGResource::isClipper):
1297         (WebCore::SVGResource::isMarker):
1298         (WebCore::SVGResource::isMasker):
1299         (WebCore::SVGResourceListener::~SVGResourceListener):
1300         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1301         (WebCore::SVGResourceClipper::SVGResourceClipper):
1302         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1303         (WebCore::SVGResourceClipper::resetClipData):
1304         (WebCore::SVGResourceClipper::addClipData):
1305         (WebCore::SVGResourceClipper::clipData):
1306         (WebCore::SVGResourceClipper::externalRepresentation):
1307         (WebCore::operator<<):
1308         (WebCore::getClipperById):
1309         * platform/graphics/svg/SVGResourceClipper.h: Added.
1310         (WebCore::ClipDataList::addPath):
1311         (WebCore::SVGResourceClipper::isClipper):
1312         * platform/graphics/svg/SVGResourceImage.h: Added.
1313         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1314         (WebCore::SVGResourceMarker::SVGResourceMarker):
1315         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1316         (WebCore::SVGResourceMarker::setMarker):
1317         (WebCore::SVGResourceMarker::setRef):
1318         (WebCore::SVGResourceMarker::draw):
1319         (WebCore::SVGResourceMarker::externalRepresentation):
1320         (WebCore::getMarkerById):
1321         * platform/graphics/svg/SVGResourceMarker.h: Added.
1322         (WebCore::SVGResourceMarker::refX):
1323         (WebCore::SVGResourceMarker::refY):
1324         (WebCore::SVGResourceMarker::setAngle):
1325         (WebCore::SVGResourceMarker::setAutoAngle):
1326         (WebCore::SVGResourceMarker::angle):
1327         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1328         (WebCore::SVGResourceMarker::useStrokeWidth):
1329         (WebCore::SVGResourceMarker::isMarker):
1330         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1331         (WebCore::SVGResourceMasker::SVGResourceMasker):
1332         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1333         (WebCore::SVGResourceMasker::setMask):
1334         (WebCore::SVGResourceMasker::mask):
1335         (WebCore::SVGResourceMasker::externalRepresentation):
1336         (WebCore::getMaskerById):
1337         * platform/graphics/svg/SVGResourceMasker.h: Added.
1338         (WebCore::SVGResourceMasker::isMasker):
1339         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1340         (WebCore::SVGResourceClipper::applyClip):
1341         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1342         (WebCore::SVGResourceImage::SVGResourceImage):
1343         (WebCore::SVGResourceImage::~SVGResourceImage):
1344         (WebCore::SVGResourceImage::init):
1345         (WebCore::SVGResourceImage::size):
1346         (WebCore::SVGResourceImage::cgLayer):
1347         (WebCore::SVGResourceImage::setCGLayer):
1348         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1349         (WebCore::applyLuminanceToAlphaFilter):
1350         (WebCore::applyExpandAlphatoGrayscaleFilter):
1351         (WebCore::transformImageIntoGrayscaleMask):
1352         (WebCore::SVGResourceMasker::applyMask):
1353         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1354         (WebCore::SVGResourceClipper::applyClip):
1355         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1356         (WebCore::SVGResourceImage::init):
1357         (WebCore::SVGResourceImage::size):
1358         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1359         (WebCore::SVGResourceMasker::applyMask):
1360         * platform/qt/GraphicsContextQt.cpp:
1361         * rendering/RenderPath.cpp:
1362         (WebCore::RenderPath::paint):
1363         (WebCore::DrawMarkersData::DrawMarkersData):
1364         (WebCore::RenderPath::drawMarkersIfNeeded):
1365         * rendering/RenderSVGContainer.cpp:
1366         (WebCore::RenderSVGContainer::paint):
1367         * rendering/RenderSVGImage.cpp:
1368         (WebCore::RenderSVGImage::paint):
1369         * rendering/SVGInlineFlowBox.cpp:
1370         (WebCore::paintSVGInlineFlow):
1371
1372 2006-10-30  John Sullivan  <sullivan@apple.com>
1373
1374         Reviewed by Brady
1375
1376         - minor cleanup to make future patches clearer
1377
1378         * bridge/mac/FrameMac.mm:
1379         (WebCore::FrameMac::advanceToNextMisspelling):
1380         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1381         with "continue" to better match structure of similar code in markMisspellings; a few
1382         other style tweaks.
1383
1384         (WebCore::FrameMac::markMisspellings):
1385         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1386         a block just after a break and outdented accordingly.
1387
1388 2006-10-30  John Sullivan  <sullivan@apple.com>
1389
1390         Reviewed by Geoff Garen
1391
1392         WebCore part of change to push the code that updates the spelling panel
1393         into WebCore, in preparation for some grammar-checking stuff.
1394
1395         * bridge/mac/FrameMac.h:
1396         * bridge/mac/FrameMac.mm:
1397         (WebCore::FrameMac::advanceToNextMisspelling):
1398         no more return value for this method, and update the spelling panel with
1399         the misspelled word here rather than in the WebKit callers.
1400
1401 2006-10-30  Oliver Hunt  <oliver@apple.com>
1402
1403         Reviewed by Anders.
1404
1405         Roll out last patch
1406
1407         * CMakeLists.txt:
1408         * ChangeLog:
1409         * WebCore.xcodeproj/project.pbxproj:
1410         * graphics/svg/SVGResource.cpp:
1411         * graphics/svg/SVGResourceClipper.cpp:
1412         * graphics/svg/SVGResourceClipper.h:
1413         * graphics/svg/SVGResourceImage.h:
1414         * graphics/svg/SVGResourceListener.h:
1415         * graphics/svg/SVGResourceMarker.cpp:
1416         * graphics/svg/SVGResourceMarker.h:
1417         * graphics/svg/SVGResourceMasker.cpp:
1418         * graphics/svg/SVGResourceMasker.h:
1419         * kcanvas/KCanvasClipper.cpp: Added.
1420         (WebCore::operator<<):
1421         (WebCore::KCanvasClipper::KCanvasClipper):
1422         (WebCore::KCanvasClipper::~KCanvasClipper):
1423         (WebCore::KCanvasClipper::resetClipData):
1424         (WebCore::KCanvasClipper::addClipData):
1425         (WebCore::KCanvasClipper::clipData):
1426         (WebCore::KCanvasClipper::externalRepresentation):
1427         (WebCore::getClipperById):
1428         * kcanvas/KCanvasClipper.h: Added.
1429         (WebCore::KCClipData::windRule):
1430         (WebCore::KCClipDataList::KCClipDataList):
1431         (WebCore::KCClipDataList::addPath):
1432         (WebCore::KCanvasClipper::isClipper):
1433         * kcanvas/KCanvasFilters.cpp:
1434         (WebCore::getFilterById):
1435         * kcanvas/KCanvasFilters.h:
1436         * kcanvas/KCanvasImage.h: Added.
1437         (WebCore::KCanvasImage::KCanvasImage):
1438         (WebCore::KCanvasImage::~KCanvasImage):
1439         * kcanvas/KCanvasMarker.cpp: Added.
1440         (WebCore::KCanvasMarker::KCanvasMarker):
1441         (WebCore::KCanvasMarker::~KCanvasMarker):
1442         (WebCore::KCanvasMarker::setMarker):
1443         (WebCore::KCanvasMarker::setRef):
1444         (WebCore::KCanvasMarker::refX):
1445         (WebCore::KCanvasMarker::refY):
1446         (WebCore::KCanvasMarker::setAngle):
1447         (WebCore::KCanvasMarker::angle):
1448         (WebCore::KCanvasMarker::setAutoAngle):
1449         (WebCore::KCanvasMarker::setUseStrokeWidth):
1450         (WebCore::KCanvasMarker::useStrokeWidth):
1451         (WebCore::KCanvasMarker::draw):
1452         (WebCore::KCanvasMarker::externalRepresentation):
1453         (WebCore::getMarkerById):
1454         * kcanvas/KCanvasMarker.h: Added.
1455         (WebCore::KCanvasMarker::isMarker):
1456         * kcanvas/KCanvasMasker.cpp: Added.
1457         (WebCore::KCanvasMasker::KCanvasMasker):
1458         (WebCore::KCanvasMasker::~KCanvasMasker):
1459         (WebCore::KCanvasMasker::setMask):
1460         (WebCore::KCanvasMasker::externalRepresentation):
1461         (WebCore::getMaskerById):
1462         * kcanvas/KCanvasMasker.h: Added.
1463         (WebCore::KCanvasMasker::isMasker):
1464         (WebCore::KCanvasMasker::mask):
1465         * kcanvas/KCanvasResource.cpp: Added.
1466         (WebCore::operator<<):
1467         (WebCore::KCanvasResource::KCanvasResource):
1468         (WebCore::KCanvasResource::~KCanvasResource):
1469         (WebCore::KCanvasResource::addClient):
1470         (WebCore::KCanvasResource::clients):
1471         (WebCore::KCanvasResource::invalidate):
1472         (WebCore::KCanvasResource::idInRegistry):
1473         (WebCore::KCanvasResource::setIdInRegistry):
1474         (WebCore::KCanvasResource::externalRepresentation):
1475         (WebCore::getResourceById):
1476         (WebCore::getPaintServerById):
1477         * kcanvas/KCanvasResource.h:
1478         (WebCore::):
1479         (WebCore::KCanvasResource::isPaintServer):
1480         (WebCore::KCanvasResource::isFilter):
1481         (WebCore::KCanvasResource::isClipper):
1482         (WebCore::KCanvasResource::isMarker):
1483         (WebCore::KCanvasResource::isMasker):
1484         * kcanvas/KCanvasResourceListener.h: Added.
1485         (KCanvasResourceListener::KCanvasResourceListener):
1486         (KCanvasResourceListener::~KCanvasResourceListener):
1487         * kcanvas/KCanvasTreeDebug.cpp:
1488         (WebCore::writeRenderResources):
1489         * kcanvas/device/KRenderingDevice.h:
1490         * kcanvas/device/KRenderingPaintServer.h:
1491         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1492         (WebCore::KRenderingPaintServer::idInRegistry):
1493         (WebCore::KRenderingPaintServer::setIdInRegistry):
1494         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1495         (WebCore::KRenderingPaintServerGradient::listener):
1496         (WebCore::KRenderingPaintServerGradient::setListener):
1497         * kcanvas/device/KRenderingPaintServerGradient.h:
1498         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1499         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1500         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1501         (WebCore::KRenderingPaintServerPattern::tile):
1502         (WebCore::KRenderingPaintServerPattern::setTile):
1503         (WebCore::KRenderingPaintServerPattern::listener):
1504         (WebCore::KRenderingPaintServerPattern::setListener):
1505         * kcanvas/device/KRenderingPaintServerPattern.h:
1506         * kcanvas/device/KRenderingPaintServerSolid.h:
1507         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1508         (WebCore::KCanvasClipperQt::applyClip):
1509         * kcanvas/device/qt/KCanvasClipperQt.h:
1510         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1511         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1512         (WebCore::KRenderingDeviceQt::contextForImage):
1513         (WebCore::KRenderingDeviceQt::createResource):
1514         (WebCore::KRenderingDeviceQt::createPaintServer):
1515         * kcanvas/device/qt/KRenderingDeviceQt.h:
1516         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1517         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1518         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1519         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1520         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1521         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1522         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1523         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1524         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1525         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1526         (WebCore::applyLuminanceToAlphaFilter):
1527         (WebCore::applyExpandAlphatoGrayscaleFilter):
1528         (WebCore::transformImageIntoGrayscaleMask):
1529         (WebCore::KCanvasMaskerQuartz::applyMask):
1530         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1531         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1532         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1533         (WebCore::KCanvasImageQuartz::init):
1534         (WebCore::KCanvasImageQuartz::size):
1535         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1536         (WebCore::KCanvasClipperQuartz::applyClip):
1537         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1538         (WebCore::KCanvasImageQuartz::cgLayer):
1539         (WebCore::KCanvasImageQuartz::setCGLayer):
1540         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1541         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1542         (WebCore::KRenderingDeviceQuartz::contextForImage):
1543         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1544         (WebCore::KRenderingDeviceQuartz::createResource):
1545         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1546         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1547         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1548         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1549         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1550         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1551         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1552         (WebCore::patternCallback):
1553         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1554         * kcanvas/device/quartz/QuartzSupport.mm:
1555         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1556         (WebCore::sharedSolidPaintServer):
1557         * ksvg2/svg/SVGClipPathElement.cpp:
1558         (WebCore::SVGClipPathElement::SVGClipPathElement):
1559         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1560         (WebCore::SVGClipPathElement::canvasResource):
1561         * ksvg2/svg/SVGClipPathElement.h:
1562         * ksvg2/svg/SVGFEImageElement.cpp:
1563         * ksvg2/svg/SVGFilterElement.cpp:
1564         (WebCore::SVGFilterElement::SVGFilterElement):
1565         (WebCore::SVGFilterElement::~SVGFilterElement):
1566         (WebCore::SVGFilterElement::canvasResource):
1567         * ksvg2/svg/SVGFilterElement.h:
1568         * ksvg2/svg/SVGGradientElement.cpp:
1569         (WebCore::SVGGradientElement::SVGGradientElement):
1570         (WebCore::SVGGradientElement::~SVGGradientElement):
1571         (WebCore::SVGGradientElement::canvasResource):
1572         (WebCore::SVGGradientElement::resourceNotification):
1573         * ksvg2/svg/SVGGradientElement.h:
1574         * ksvg2/svg/SVGImageElement.cpp:
1575         * ksvg2/svg/SVGLinearGradientElement.cpp:
1576         (WebCore::SVGLinearGradientElement::buildGradient):
1577         * ksvg2/svg/SVGLinearGradientElement.h:
1578         * ksvg2/svg/SVGMarkerElement.cpp:
1579         (WebCore::SVGMarkerElement::SVGMarkerElement):
1580         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1581         (WebCore::SVGMarkerElement::canvasResource):
1582         * ksvg2/svg/SVGMarkerElement.h:
1583         * ksvg2/svg/SVGMaskElement.cpp:
1584         (WebCore::SVGMaskElement::SVGMaskElement):
1585         (WebCore::SVGMaskElement::~SVGMaskElement):
1586         (WebCore::SVGMaskElement::drawMaskerContent):
1587         (WebCore::SVGMaskElement::canvasResource):
1588         * ksvg2/svg/SVGMaskElement.h:
1589         * ksvg2/svg/SVGPatternElement.cpp:
1590         (WebCore::SVGPatternElement::SVGPatternElement):
1591         (WebCore::SVGPatternElement::~SVGPatternElement):
1592         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1593         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1594         (WebCore::SVGPatternElement::canvasResource):
1595         * ksvg2/svg/SVGPatternElement.h:
1596         * ksvg2/svg/SVGRadialGradientElement.cpp:
1597         (WebCore::SVGRadialGradientElement::buildGradient):
1598         * ksvg2/svg/SVGRadialGradientElement.h:
1599         * ksvg2/svg/SVGStyledElement.h:
1600         (WebCore::SVGStyledElement::canvasResource):
1601         * platform/GraphicsContext.cpp: Added.
1602         (WebCore::GraphicsContextState::GraphicsContextState):
1603         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1604         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1605         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1606         (WebCore::GraphicsContext::save):
1607         (WebCore::GraphicsContext::restore):
1608         (WebCore::GraphicsContext::font):
1609         (WebCore::GraphicsContext::setFont):
1610         (WebCore::GraphicsContext::pen):
1611         (WebCore::GraphicsContext::setPen):
1612         (WebCore::GraphicsContext::setFillColor):
1613         (WebCore::GraphicsContext::fillColor):
1614         (WebCore::GraphicsContext::updatingControlTints):
1615         (WebCore::GraphicsContext::setUpdatingControlTints):
1616         (WebCore::GraphicsContext::setPaintingDisabled):
1617         (WebCore::GraphicsContext::paintingDisabled):
1618         (WebCore::GraphicsContext::drawImage):
1619         (WebCore::GraphicsContext::drawText):
1620         (WebCore::GraphicsContext::drawHighlightForText):
1621         (WebCore::GraphicsContext::initFocusRing):
1622         (WebCore::GraphicsContext::clearFocusRing):
1623         (WebCore::GraphicsContext::focusRingBoundingRect):
1624         (WebCore::GraphicsContext::addFocusRingRect):
1625         (WebCore::GraphicsContext::focusRingWidth):
1626         (WebCore::GraphicsContext::focusRingOffset):
1627         (WebCore::GraphicsContext::focusRingRects):
1628         (WebCore::GraphicsContext::drawTiledImage):
1629         * platform/GraphicsContext.h: Added.
1630         * platform/GraphicsTypes.cpp: Added.
1631         (WebCore::):
1632         (WebCore::parseCompositeOperator):
1633         (WebCore::compositeOperatorName):
1634         (WebCore::parseLineCap):
1635         (WebCore::lineCapName):
1636         (WebCore::parseLineJoin):
1637         (WebCore::lineJoinName):
1638         * platform/GraphicsTypes.h: Added.
1639         (WebCore::):
1640         * platform/graphics/GraphicsContext.cpp:
1641         * platform/graphics/GraphicsContext.h:
1642         * platform/graphics/GraphicsTypes.cpp:
1643         * platform/graphics/GraphicsTypes.h:
1644         * platform/qt/GraphicsContextQt.cpp:
1645         * rendering/RenderPath.cpp:
1646         (WebCore::RenderPath::paint):
1647         (WebCore::DrawMarkersData::DrawMarkersData):
1648         (WebCore::RenderPath::drawMarkersIfNeeded):
1649         * rendering/RenderSVGContainer.cpp:
1650         (WebCore::RenderSVGContainer::paint):
1651         * rendering/RenderSVGImage.cpp:
1652         (WebCore::RenderSVGImage::paint):
1653         * rendering/SVGInlineFlowBox.cpp:
1654         (WebCore::paintSVGInlineFlow):
1655
1656 2006-10-30  John Sullivan  <sullivan@apple.com>
1657
1658         Reviewed by Geoff Garen.
1659
1660         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1661         grammar-related method.
1662
1663         * bridge/EditorClient.h:
1664         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1665         isGrammarCheckingEnabled()
1666
1667         * bridge/mac/WebCoreFrameBridge.h:
1668         removed bridge equivalents
1669
1670         * bridge/mac/FrameMac.mm:
1671         (WebCore::FrameMac::advanceToNextMisspelling):
1672         convert bridge-using code to editor()->client()-using code
1673         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1674         ditto
1675         (WebCore::FrameMac::markMisspellings):
1676         ditto
1677         (WebCore::FrameMac::respondToChangedSelection):
1678         ditto
1679
1680         * editing/Editor.h:
1681         * editing/Editor.cpp:
1682         (WebCore::Editor::client):
1683         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1684         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1685         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1686
1687 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1688
1689         Reviewed by Darin.
1690
1691         Removed a number of editing and selection methods from the bridge.
1692
1693         I moved cross-platform editing and selection code into Editor and
1694         SelectionController, respecitvely.
1695
1696         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1697         everything + the kitchen sink.
1698
1699         Specific comments below for interesting things.
1700
1701         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1702         a new file so that WebKit can use them, too. Added a helper method for
1703         handling exceptions when selecting a Range.
1704         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into
1705         WebKit, since they have to do with creating an NSAttributedString for API
1706         consumption, and not much to do with general Frame functionality.
1707         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1708         for now) into the Editor. Eventually, the Frame will not have to notify
1709         the Editor of what the lastEditCommand was, since the Editor will perform
1710         all EditCommands.
1711         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1712         * editing/SelectionController.cpp:
1713         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1714         and return them. The bridge method to select a DOM range did this implicitly,
1715         since all ObjC DOM operations handle DOM exceptions by throwing them as
1716         ObjC exceptions.
1717         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1718         The two enumerations are numerically identical, but that's an implementation
1719         detail of TextAffinity that clients shouldn't be required to know about.
1720
1721 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1722
1723         Rolling out the following change because this crash:
1724         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
1725
1726         And this regression:
1727         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1728
1729     2006-09-06  David Harrison  <harrison@apple.com>
1730
1731         Reviewed and tweaked by Tim H.
1732
1733         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation
1734
1735         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
1736         to trigger a search that will include auto activation. No PLT or iBench perf impact.
1737         No layout tests affected. Not testable in an automated way that will work on all systems.
1738
1739         * platform/mac/WebFontCache.mm:
1740         (+[WebFontCache fontWithFamily:traits:size:]):
1741
1742 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1743
1744         Reviewed by harrison
1745
1746         <rdar://problem/4808375>
1747         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1748
1749         * editing/TextIterator.cpp:
1750         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1751         when we're going to use them to create a range for an emitted character.
1752         We should further speed TextIterators up by avoiding creating VisiblePositions
1753         for TIs that are only used for the characters they emit (like the one that
1754         plainText uses).
1755
1756 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1757
1758         Reviewed by Mitz.
1759
1760         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1761         More rendering code cleaning
1762
1763         * WebCore.xcodeproj/project.pbxproj:
1764         * rendering/RenderApplet.cpp:
1765         (WebCore::RenderApplet::RenderApplet):
1766         (WebCore::RenderApplet::createWidgetIfNecessary):
1767         * rendering/RenderApplet.h:
1768         * rendering/RenderArena.cpp:
1769         (WebCore::):
1770         (WebCore::RenderArena::RenderArena):
1771         (WebCore::RenderArena::allocate):
1772         (WebCore::RenderArena::free):
1773         * rendering/RenderArena.h:
1774         * rendering/RenderBR.cpp:
1775         (WebCore::RenderBR::RenderBR):
1776         (WebCore::RenderBR::baselinePosition):
1777         (WebCore::RenderBR::lineHeight):
1778         (WebCore::RenderBR::setStyle):
1779         (WebCore::RenderBR::caretMinOffset):
1780         (WebCore::RenderBR::positionForCoordinates):
1781         (WebCore::RenderBR::inlineBox):
1782         * rendering/RenderBR.h:
1783         * rendering/RenderBlock.cpp:
1784         * rendering/RenderBlock.h:
1785         (WebCore::RenderBlock::maxTopMargin):
1786         (WebCore::RenderBlock::maxBottomMargin):
1787         (WebCore::RenderBlock::initMaxMarginValues):
1788         (WebCore::RenderBlock::containsFloats):
1789         (WebCore::RenderBlock::setHasMarkupTruncation):
1790         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1791         (WebCore::RenderBlock::BlockSelectionInfo::block):
1792         (WebCore::RenderBlock::BlockSelectionInfo::state):
1793         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1794         (WebCore::RenderBlock::CompactInfo::clear):
1795         * rendering/RenderButton.cpp:
1796         (WebCore::RenderButton::removeChild):
1797         (WebCore::RenderButton::paintObject):
1798         * rendering/RenderButton.h:
1799         (WebCore::RenderButton::renderName):
1800         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1801         * rendering/RenderContainer.cpp:
1802         (WebCore::RenderContainer::RenderContainer):
1803         * rendering/RenderContainer.h:
1804         (WebCore::RenderContainer::firstChild):
1805         (WebCore::RenderContainer::lastChild):
1806         (WebCore::RenderContainer::calcMinMaxWidth):
1807         * rendering/RenderCounter.cpp:
1808         (WebCore::RenderCounter::RenderCounter):
1809         (WebCore::toRoman):
1810         (WebCore::toHebrew):
1811         (WebCore::RenderCounter::calcMinMaxWidth):
1812         * rendering/RenderCounter.h:
1813         * rendering/RenderFieldset.cpp:
1814         (WebCore::RenderFieldset::paintBoxDecorations):
1815         (WebCore::RenderFieldset::paintBorderMinusLegend):
1816         (WebCore::RenderFieldset::setStyle):
1817         * rendering/RenderFileUploadControl.cpp:
1818         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1819         (WebCore::RenderFileUploadControl::setStyle):
1820         (WebCore::RenderFileUploadControl::paintObject):
1821         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1822         * rendering/RenderFileUploadControl.h:
1823         (WebCore::RenderFileUploadControl::renderName):
1824         * rendering/RenderFlexibleBox.h:
1825         * rendering/RenderFlow.cpp:
1826         * rendering/RenderFlow.h:
1827         * rendering/RenderForeignObject.cpp:
1828         (WebCore::RenderForeignObject::RenderForeignObject):
1829         (WebCore::RenderForeignObject::paint):
1830         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1831         (WebCore::RenderForeignObject::layout):
1832         (WebCore::RenderForeignObject::nodeAtPoint):
1833         * rendering/RenderForeignObject.h:
1834         (WebCore::RenderForeignObject::renderName):
1835         * rendering/RenderFormElement.cpp:
1836         (WebCore::RenderFormElement::setStyle):
1837         (WebCore::RenderFormElement::layout):
1838         (WebCore::RenderFormElement::textAlignment):
1839         * rendering/RenderFormElement.h:
1840         * rendering/RenderFrame.cpp:
1841         * rendering/RenderFrame.h:
1842         (WebCore::RenderFrame::element):
1843         * rendering/RenderFrameSet.cpp:
1844         * rendering/RenderFrameSet.h:
1845         (WebCore::RenderFrameSet::element):
1846         * rendering/RenderHTMLCanvas.cpp:
1847         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1848         (WebCore::RenderHTMLCanvas::paint):
1849         * rendering/RenderHTMLCanvas.h:
1850         (WebCore::RenderHTMLCanvas::renderName):
1851         * rendering/RenderImage.cpp:
1852         (WebCore::RenderImage::RenderImage):
1853         (WebCore::RenderImage::setStyle):
1854         (WebCore::RenderImage::setContentObject):
1855         (WebCore::RenderImage::setCachedImage):
1856         (WebCore::RenderImage::imageChanged):
1857         (WebCore::RenderImage::paint):
1858         (WebCore::RenderImage::layout):
1859         (WebCore::RenderImage::updateAltText):
1860         * rendering/RenderImage.h:
1861         (WebCore::RenderImage::element):
1862         * rendering/RenderInline.cpp:
1863         (WebCore::RenderInline::RenderInline):
1864         (WebCore::RenderInline::~RenderInline):
1865         (WebCore::RenderInline::setStyle):
1866         (WebCore::RenderInline::addChildToFlow):
1867         (WebCore::RenderInline::cloneInline):
1868         (WebCore::RenderInline::splitInlines):
1869         (WebCore::RenderInline::splitFlow):
1870         (WebCore::RenderInline::paint):
1871         (WebCore::RenderInline::absoluteRects):
1872         (WebCore::RenderInline::calcMinMaxWidth):
1873         (WebCore::RenderInline::requiresLayer):
1874         (WebCore::RenderInline::width):
1875         (WebCore::RenderInline::height):
1876         (WebCore::RenderInline::renderName):
1877         (WebCore::RenderInline::nodeAtPoint):
1878         (WebCore::RenderInline::positionForCoordinates):
1879         * rendering/RenderInline.h:
1880         (WebCore::RenderInline::layout):
1881         * rendering/RenderLayer.cpp:
1882         * rendering/RenderLayer.h:
1883         (WebCore::ClipRects::ClipRects):
1884         (WebCore::RenderLayer::nextSibling):
1885         (WebCore::RenderLayer::root):
1886         (WebCore::RenderLayer::setPos):
1887         (WebCore::RenderLayer::height):
1888         (WebCore::RenderLayer::relativePositionOffset):
1889         * rendering/RenderLineEdit.cpp:
1890         (WebCore::RenderLineEdit::setStyle):
1891         (WebCore::RenderLineEdit::updateFromElement):
1892         (WebCore::RenderLineEdit::selectionStart):
1893         (WebCore::RenderLineEdit::selectionEnd):
1894         (WebCore::RenderLineEdit::setSelectionStart):
1895         (WebCore::RenderLineEdit::setSelectionEnd):
1896         (WebCore::RenderLineEdit::setSelectionRange):
1897         * rendering/RenderLineEdit.h:
1898         * rendering/RenderListBox.cpp:
1899         * rendering/RenderListBox.h:
1900         (WebCore::RenderListBox::renderName):
1901         * rendering/RenderListItem.cpp:
1902         (WebCore::RenderListItem::setStyle):
1903         (WebCore::getParentOfFirstLineBox):
1904         (WebCore::RenderListItem::updateMarkerLocation):
1905         (WebCore::RenderListItem::positionListMarker):
1906         (WebCore::RenderListItem::paint):
1907         * rendering/RenderListItem.h:
1908         * rendering/RenderListMarker.cpp:
1909         * rendering/RenderListMarker.h:
1910         (WebCore::RenderListMarker::renderName):
1911         (WebCore::RenderListMarker::isListMarker):
1912
1913 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1914
1915         Reviewed by Hyatt.
1916
1917         <rdar://problem/4478625> Basic table editing and culling
1918
1919         Refined the criteria for deletable elements, rely on the renderer more.
1920         Corrected the interface positioning for elements that have borders.
1921
1922         * editing/DeleteButtonController.cpp:
1923         (WebCore::isDeletableElement):
1924         (WebCore::DeleteButtonController::show):
1925
1926 2006-10-30  Darin Adler  <darin@apple.com>
1927
1928         - fix build
1929
1930         * loader/ResourceLoader.h: Added header guard.
1931
1932 2006-10-31  Darin Adler  <darin@apple.com>
1933
1934         Reviewed by Adam.
1935
1936         - fix FrameLoader files so they can be built on non-Mac platforms
1937
1938         * page/FramePrivate.h:
1939         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1940         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1941
1942         * page/Page.h:
1943         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1944         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1945         the other day.
1946
1947         * bridge/mac/FrameMac.mm:
1948         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1949         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1950
1951         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1952         around the PolicyCheck definition.
1953
1954         * loader/FormState.cpp: Changed import to include.
1955         * loader/FrameLoader.cpp: Ditto.
1956         * loader/MainResourceLoader.h: Ditto.
1957
1958         * loader/FrameLoaderTypes.h: Added a header guard.
1959
1960         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1961         Added #if PLATFORM(MAC) around Mac-specific details.
1962         * loader/SubresourceLoader.h: Ditto.
1963
1964         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1965         m_loader from m_frameLoader.
1966
1967         * CMakeLists.txt: Updated.
1968         * WebCoreSources.bkl: Updated.
1969
1970 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1971
1972         Reviewed and landed by Anders.
1973
1974         Patch by Zack rusin to fix:
1975         http://bugs.webkit.org/show_bug.cgi?id=11429
1976
1977         Fix startup crash.
1978
1979         * platform/qt/FrameQtClient.cpp:
1980         (WebCore::FrameQtClientDefault::openURL):
1981
1982 2006-10-30  Zach Rusin  <zack@kde.org>
1983
1984         Reviewed and landed by Anders.
1985
1986         * platform/network/qt/ResourceHandleQt.cpp:
1987         (WebCore::ResourceHandle::receivedResponse):
1988         * platform/qt/FrameQtClient.cpp:
1989         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1990         * platform/qt/LoaderFunctionsQt.cpp:
1991         (WebCore::ServeSynchronousRequest):
1992         More build fixes.
1993
1994 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1995
1996         Reviewed and landed by Anders.
1997
1998         - fix Qt build
1999         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
2000         ResourceHandleClient
2001
2002 2006-10-30  Darin Adler  <darin@apple.com>
2003
2004         Reviewed by John Sullivan.
2005
2006         - work toward removing Objective-C data types from FrameLoader.h:
2007           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
2008           and WebCoreResourceHandle
2009         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
2010
2011         * page/PageState.h:
2012         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
2013
2014         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
2015         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
2016         double for the date instead of an NSDate.
2017
2018         * bridge/mac/WebCoreFrameBridge.h:
2019         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
2020         saveDocumentToPageCache methods.
2021
2022         * bridge/mac/WebCorePageState.h:
2023         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
2024         an Objective-C wrapper for PageState.
2025
2026         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
2027         NSDate and WebCorePageState.
2028         * loader/FrameLoaderClient.h: Changed NSDate to double.
2029         * loader/mac/FrameLoaderMac.mm:
2030         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
2031         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
2032         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
2033         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
2034         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
2035         extract the parameters from the response. Changed the open function that takes
2036         a PageState to use the new C++ PageState.
2037         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
2038         function; tightened up logic, removing a few cases that could never happen, as
2039         well as the unused reload boolean.
2040
2041         * ForwardingHeaders/kjs/property_map.h: Added.
2042
2043         * WebCore.exp: Updated.
2044         * WebCore.xcodeproj/project.pbxproj: Updated.
2045
2046 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2047
2048         Reviewed by Anders.
2049
2050         - added ResourceResponse class and didReceiveResponse delegate call
2051
2052         * WebCore.xcodeproj/project.pbxproj: Added new files.
2053         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
2054         expiresTimeForResponse: method.
2055         * dom/XMLTokenizer.cpp:
2056         (WebCore::openFunc): Updated to use ResourceResponse.
2057         * loader/FrameLoader.h: Update loadResourceSynchronously to
2058         use ResourceResponse.
2059         * loader/LoaderFunctions.h:
2060         * loader/icon/IconLoader.cpp:
2061         (IconLoader::didReceiveResponse): Updated from receivedResponse
2062         and made cross-platform.
2063         * loader/icon/IconLoader.h: updated for above change
2064         * loader/loader.cpp:
2065         (WebCore::Loader::receivedResponse): reduced to just saving
2066         the PlatformResponse (ideally we'd phase out use of this).
2067         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse
2068         logic.
2069         * loader/loader.h:
2070         * loader/mac/FrameLoaderMac.mm:
2071         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2072         as ResourceResponse.
2073         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2074         * loader/mac/LoaderFunctionsMac.mm:
2075         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2076         argument.
2077         * platform/network/ResourceHandle.cpp:
2078         * platform/network/ResourceHandle.h: Remove calls for
2079         broken out response pieces.
2080         * platform/network/ResourceHandleClient.h:
2081         (WebCore::ResourceHandleClient::didReceiveResponse): New
2082         delegate method.
2083         * platform/network/ResourceHandleInternal.h:
2084         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2085         storage of response bits, we're not gonna return them
2086         seprately any more.
2087         * platform/network/ResourceResponse.h: Added.
2088         (WebCore::ResourceResponse::ResourceResponse): Freshly
2089         implemented. Same for below.
2090         (WebCore::ResourceResponse::url):
2091         (WebCore::ResourceResponse::mimeType):
2092         (WebCore::ResourceResponse::expectedContentLength):
2093         (WebCore::ResourceResponse::textEncodingName):
2094         (WebCore::ResourceResponse::suggestedFilename):
2095         (WebCore::ResourceResponse::httpStatusCode):
2096         (WebCore::ResourceResponse::setHTTPStatusCode):
2097         (WebCore::ResourceResponse::httpHeaderField):
2098         (WebCore::ResourceResponse::httpHeaderFields):
2099         (WebCore::ResourceResponse::isMultipart):
2100         (WebCore::ResourceResponse::setExpirationDate):
2101         (WebCore::ResourceResponse::expirationDate):
2102         * platform/network/cf/ResourceHandleCFNet.cpp:
2103         (WebCore::didReceiveResponse): Send didReceiveResponse
2104         client method.
2105         * platform/network/cf/ResourceResponseCFNet.h: Added.
2106         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2107         (getResourceResponse): Helper function to get a ResourceResponse
2108         from CFURLResponseRef.
2109         * platform/network/mac/ResourceHandleMac.mm:
2110         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2111         Don't bother cleaning up fields we no longer have.
2112         (WebCore::ResourceHandle::receivedResponse): Send
2113         didReceiveResponse client method.
2114         * platform/network/mac/ResourceResponseMac.h: Added.
2115         * platform/network/mac/ResourceResponseMac.mm: Added.
2116         (getResourceResponse): Helper function to get a ResourceResponse
2117         from an NSURLResponse*.
2118         * rendering/HitTestResult.cpp:
2119         * xml/XSLTProcessor.cpp:
2120         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2121         * xml/xmlhttprequest.cpp:
2122         (WebCore::XMLHttpRequest::getResponseText): Store http response
2123         info in the form of a ResourceResponse, change all methods to
2124         account for this.
2125         (WebCore::XMLHttpRequest::getResponseXML):
2126         (WebCore::XMLHttpRequest::XMLHttpRequest):
2127         (WebCore::XMLHttpRequest::open):
2128         (WebCore::XMLHttpRequest::send):
2129         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2130         (WebCore::XMLHttpRequest::getResponseHeader):
2131         (WebCore::XMLHttpRequest::getStatus):
2132         (WebCore::XMLHttpRequest::getStatusText):
2133         (WebCore::XMLHttpRequest::processSyncLoadResults):
2134         (WebCore::XMLHttpRequest::didFinishLoading):
2135         (WebCore::XMLHttpRequest::didReceiveResponse):
2136         (WebCore::XMLHttpRequest::didReceiveData):
2137         * xml/xmlhttprequest.h:
2138
2139 2006-10-29  Darin Adler  <darin@apple.com>
2140
2141         - fix build
2142
2143         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2144         * loader/NetscapePlugInStreamLoader.h: Ditto.
2145         * loader/ResourceLoader.h: Ditto.
2146
2147 2006-10-29  Darin Adler  <darin@apple.com>
2148
2149         - one last name change -- WebFormState.h to FormState.h
2150         - added more empty placeholder platform-independent files
2151           for currently-Mac-specific loader classes
2152
2153         * loader/FormState.cpp: Updated include.
2154         * loader/FrameLoader.cpp: Updated include.
2155         * loader/mac/FrameLoaderMac.mm: Updated include.
2156
2157         * loader/WebFormState.h: Removed.
2158         * loader/FormState.h: Added.
2159
2160         * loader/DocumentLoader.cpp: Added.
2161         * loader/MainResourceLoader.cpp: Added.
2162         * loader/NetscapePlugInStreamLoader.cpp: Added.
2163         * loader/ResourceLoader.cpp: Added.
2164         * loader/SubresourceLoader.cpp: Added.
2165
2166         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2167
2168 2006-10-29  Darin Adler  <darin@apple.com>
2169
2170         - did the do-webcore-rename renames, including a number of changes
2171           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2172           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2173           and improvements to the names of decoder classes and their source
2174           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2175
2176         * CMakeLists.txt:
2177         * WebCore.exp:
2178         * WebCore.vcproj/WebCore/WebCore.vcproj:
2179         * WebCore.xcodeproj/project.pbxproj:
2180         * WebCoreSources.bkl:
2181         * bindings/js/kjs_binding.cpp:
2182         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2183         * bindings/js/kjs_events.cpp:
2184         (KJS::JSAbstractEventListener::handleEvent):
2185         (KJS::JSLazyEventListener::parseCode):
2186         * bindings/js/kjs_html.cpp:
2187         (KJS::JSHTMLElement::implementsCall):
2188         * bindings/js/kjs_traversal.cpp:
2189         (KJS::JSNodeFilterCondition::acceptNode):
2190         * bindings/js/kjs_window.cpp:
2191         (KJS::Window::interpreter):
2192         (KJS::Window::retrieveWindow):
2193         (KJS::Window::retrieve):
2194         (KJS::ScheduledAction::execute):
2195         * bindings/objc/DOMInternal.mm:
2196         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2197         * bridge/mac/FrameMac.mm:
2198         (WebCore::FrameMac::executionContextForDOM):
2199         (WebCore::FrameMac::bindingRootObject):
2200         (WebCore::FrameMac::windowScriptObject):
2201         (WebCore::FrameMac::windowScriptNPObject):
2202         (WebCore::FrameMac::partClearedInBegin):
2203         * bridge/mac/WebCoreEncodings.mm:
2204         * bridge/mac/WebCoreFrameBridge.mm:
2205         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2206         (-[WebCoreFrameBridge stringWithData:]):
2207         (-[WebCoreFrameBridge executionContextForView:]):
2208         * bridge/win/FrameWin.cpp:
2209         * dom/Document.cpp:
2210         (WebCore::Document::inputEncoding):
2211         (WebCore::Document::setCharset):
2212         (WebCore::Document::createHTMLEventListener):
2213         (WebCore::Document::setDecoder):
2214         * dom/Document.h:
2215         (WebCore::Document::decoder):
2216         * dom/EventTargetNode.cpp:
2217         (WebCore::EventTargetNode::dispatchGenericEvent):
2218         * html/HTMLParser.cpp:
2219         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2220         (WebCore::HTMLParser::canvasCreateErrorCheck):
2221         (WebCore::HTMLParser::isInline):
2222         * html/HTMLPlugInElement.cpp:
2223         (WebCore::HTMLPlugInElement::createNPObject):
2224         * html/HTMLScriptElement.cpp:
2225         (WebCore::HTMLScriptElement::evaluateScript):
2226         * html/HTMLTokenizer.cpp:
2227         (WebCore::HTMLTokenizer::parseTag):
2228         (WebCore::HTMLTokenizer::processToken):
2229         * ksvg2/misc/SVGDocumentExtensions.cpp:
2230         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2231         * loader/CachedCSSStyleSheet.cpp:
2232         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2233         (WebCore::CachedCSSStyleSheet::setEncoding):
2234         * loader/CachedCSSStyleSheet.h:
2235         * loader/CachedXBLDocument.cpp:
2236         (WebCore::CachedXBLDocument::CachedXBLDocument):
2237         (WebCore::CachedXBLDocument::setEncoding):
2238         * loader/CachedXBLDocument.h:
2239         * loader/CachedXSLStyleSheet.cpp:
2240         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2241         (WebCore::CachedXSLStyleSheet::setEncoding):
2242         * loader/CachedXSLStyleSheet.h:
2243         * loader/Decoder.cpp: Removed.
2244         * loader/Decoder.h: Removed.
2245         * loader/FrameLoader.cpp:
2246         * loader/FrameLoader.h:
2247         * loader/FrameLoaderClient.h:
2248         * loader/MainResourceLoader.h: Added.
2249         * loader/NetscapePlugInStreamLoader.h: Added.
2250         * loader/Request.h:
2251         (WebCore::Request::cachedResource):
2252         * loader/ResourceLoader.h: Added.
2253         * loader/SubresourceLoader.h: Added.
2254         * loader/TextResourceDecoder.cpp: Added.
2255         (WebCore::TextResourceDecoder::determineContentType):
2256         (WebCore::TextResourceDecoder::defaultEncoding):
2257         (WebCore::TextResourceDecoder::TextResourceDecoder):
2258         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2259         (WebCore::TextResourceDecoder::setEncoding):
2260         (WebCore::TextResourceDecoder::checkForBOM):
2261         (WebCore::TextResourceDecoder::checkForCSSCharset):
2262         (WebCore::TextResourceDecoder::checkForHeadCharset):
2263         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2264         (WebCore::TextResourceDecoder::decode):
2265         (WebCore::TextResourceDecoder::flush):
2266         * loader/TextResourceDecoder.h: Added.
2267         * loader/WebDocumentLoader.h: Removed.
2268         * loader/WebLoader.h: Removed.
2269         * loader/WebMainResourceLoader.h: Removed.
2270         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2271         * loader/WebSubresourceLoader.h: Removed.
2272         * loader/loader.cpp:
2273         (WebCore::Loader::servePendingRequests):
2274         (WebCore::Loader::receivedAllData):
2275         (WebCore::Loader::receivedResponse):
2276         (WebCore::Loader::didReceiveData):
2277         (WebCore::Loader::cancelRequests):
2278         (WebCore::Loader::jobForRequest):
2279         * loader/mac/DocumentLoaderMac.mm:
2280         * loader/mac/FormDataStream.m: Added.
2281         * loader/mac/FrameLoaderMac.mm:
2282         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2283         (WebCore::FrameLoader::addPlugInStreamLoader):
2284         (WebCore::FrameLoader::removePlugInStreamLoader):
2285         (WebCore::FrameLoader::addSubresourceLoader):
2286         (WebCore::FrameLoader::removeSubresourceLoader):
2287         (WebCore::FrameLoader::willSendRequest):
2288         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2289         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2290         (WebCore::FrameLoader::didReceiveResponse):
2291         (WebCore::FrameLoader::didReceiveData):
2292         (WebCore::FrameLoader::didFinishLoad):
2293         (WebCore::FrameLoader::didFailToLoad):
2294         (WebCore::FrameLoader::open):
2295         (WebCore::FrameLoader::willUseArchive):
2296         (WebCore::FrameLoader::isArchiveLoadPending):
2297         * loader/mac/ImageDocumentMac.mm:
2298         * loader/mac/LoaderFunctionsMac.mm:
2299         (WebCore::CheckCacheObjectStatus):
2300         * loader/mac/MainResourceLoaderMac.mm:
2301         (WebCore::MainResourceLoader::MainResourceLoader):
2302         (WebCore::MainResourceLoader::releaseDelegate):
2303         (WebCore::MainResourceLoader::didCancel):
2304         (WebCore::MainResourceLoader::addData):
2305         (WebCore::MainResourceLoader::willSendRequest):
2306         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2307         (WebCore::MainResourceLoader::didReceiveData):
2308         (WebCore::MainResourceLoader::didFinishLoading):
2309         (WebCore::MainResourceLoader::setDefersLoading):
2310         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2311         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2312         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2313         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2314         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2315         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2316         (WebCore::NetscapePlugInStreamLoader::didFail):
2317         (WebCore::NetscapePlugInStreamLoader::didCancel):
2318         * loader/mac/ResourceLoaderMac.mm:
2319         (WebCore::ResourceLoader::ResourceLoader):
2320         (WebCore::ResourceLoader::~ResourceLoader):
2321         (WebCore::ResourceLoader::releaseResources):
2322         (WebCore::ResourceLoader::load):
2323         (WebCore::ResourceLoader::setDefersLoading):
2324         (WebCore::ResourceLoader::frameLoader):
2325         (WebCore::ResourceLoader::addData):
2326         (WebCore::ResourceLoader::resourceData):
2327         (WebCore::ResourceLoader::clearResourceData):
2328         (WebCore::ResourceLoader::willSendRequest):
2329         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2330         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2331         (WebCore::ResourceLoader::didReceiveResponse):
2332         (WebCore::ResourceLoader::didReceiveData):
2333         (WebCore::ResourceLoader::willStopBufferingData):
2334         (WebCore::ResourceLoader::didFinishLoading):
2335         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2336         (WebCore::ResourceLoader::didFail):
2337         (WebCore::ResourceLoader::willCacheResponse):
2338         (WebCore::ResourceLoader::didCancel):
2339         (WebCore::ResourceLoader::cancel):
2340         (WebCore::ResourceLoader::setIdentifier):
2341         (WebCore::ResourceLoader::response):
2342         (WebCore::ResourceLoader::inConnectionCallback):
2343         (WebCore::ResourceLoader::cancelledError):
2344         (WebCore::ResourceLoader::receivedCredential):
2345         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2346         (WebCore::ResourceLoader::receivedCancellation):
2347         (WebCore::ResourceLoader::delegate):
2348         (WebCore::ResourceLoader::releaseDelegate):
2349         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2350         * loader/mac/SubresourceLoaderMac.mm:
2351         (WebCore::SubresourceLoader::SubresourceLoader):
2352         (WebCore::SubresourceLoader::willSendRequest):
2353         (WebCore::SubresourceLoader::didReceiveResponse):
2354         (WebCore::SubresourceLoader::didReceiveData):
2355         (WebCore::SubresourceLoader::didFinishLoading):
2356         (WebCore::SubresourceLoader::didFail):
2357         (WebCore::SubresourceLoader::didCancel):
2358         * loader/mac/WebFormDataStream.h: Removed.
2359         * loader/mac/WebFormDataStream.m: Removed.
2360         * page/Frame.cpp:
2361         (WebCore::Frame::javaScriptEnabled):
2362         (WebCore::Frame::scriptProxy):
2363         (WebCore::Frame::executeScript):
2364         (WebCore::Frame::write):
2365         (WebCore::Frame::userGestureHint):
2366         (WebCore::Frame::saveInterpreterBuiltins):
2367         (WebCore::Frame::restoreInterpreterBuiltins):
2368         (WebCore::Frame::backslashAsCurrencySymbol):
2369         * page/Frame.h:
2370         * page/FramePrivate.h:
2371         * platform/StreamingTextDecoder.cpp: Removed.
2372         * platform/StreamingTextDecoder.h: Removed.
2373         * platform/StreamingTextDecoderICU.cpp: Removed.
2374         * platform/StreamingTextDecoderICU.h: Removed.
2375         * platform/TextCodec.cpp: Added.
2376         * platform/TextCodec.h: Added.
2377         * platform/TextCodecICU.cpp: Added.
2378         * platform/TextCodecICU.h: Added.
2379         * platform/TextCodecLatin1.h:
2380         * platform/TextCodecUTF16.h:
2381         * platform/TextDecoder.h:
2382         * platform/TextEncoding.cpp:
2383         * platform/TextEncodingRegistry.cpp:
2384         * platform/image-decoders/jpeg/jmorecfg.h:
2385         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2386         * platform/mac/StreamingTextDecoderMac.h: Removed.
2387         * platform/mac/TextCodecMac.cpp: Added.
2388         * platform/mac/TextCodecMac.h: Added.
2389         * platform/network/ResourceHandleInternal.h:
2390         * platform/network/mac/ResourceHandleMac.mm:
2391         * platform/qt/FrameQt.cpp:
2392         (WebCore::FrameQt::bindingRootObject):
2393         * platform/qt/LoaderFunctionsQt.cpp:
2394         (WebCore::CheckCacheObjectStatus):
2395         * rendering/RenderObject.cpp:
2396         (WebCore::RenderObject::backslashAsCurrencySymbol):
2397         * xml/XSLTProcessor.cpp:
2398         (WebCore::XSLTProcessor::createDocumentFromSource):
2399         * xml/xmlhttprequest.cpp:
2400         (WebCore::XMLHttpRequest::didReceiveData):
2401         * xml/xmlhttprequest.h:
2402
2403 2006-10-29  Darin Adler  <darin@apple.com>
2404
2405         Rubber stamped by Adam (kinda).
2406
2407         - add Mac suffixes and correct filenames inside loader/mac
2408
2409         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2410
2411         * loader/mac/FrameLoader.mm: Removed.
2412         * loader/mac/WebDocumentLoader.mm: Removed.
2413         * loader/mac/WebLoader.mm: Removed.
2414         * loader/mac/WebMainResourceLoader.mm: Removed.
2415         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2416         * loader/mac/WebSubresourceLoader.mm: Removed.
2417
2418         * loader/mac/FrameLoaderMac.mm: Added.
2419         * loader/mac/DocumentLoaderMac.mm: Added.
2420         * loader/mac/ResourceLoaderMac.mm: Added.
2421         * loader/mac/MainResourceLoaderMac.mm: Added.
2422         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2423         * loader/mac/SubresourceLoaderMac.mm: Removed.
2424
2425 2006-10-29  Darin Adler  <darin@apple.com>
2426
2427         Reviewed by Adam.
2428
2429         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2430           and FrameLoader.cpp mostly ready
2431
2432         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2433         FormState.cpp. Removed WebFormState.mm.
2434
2435         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2436         get this header compiling on non-Mac.
2437         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2438         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2439
2440         * loader/FrameLoaderClient.h: Added some ifdefs.
2441         * loader/WebDocumentLoader.h: Ditto.
2442         * loader/WebLoader.h: Ditto.
2443         * loader/WebMainResourceLoader.h: Ditto.
2444
2445         * loader/mac/WebDocumentLoader.mm:
2446         (WebCore::DocumentLoader::isLoadingInAPISense):
2447         Rewrote to work without bridge, partly to remove the need for ObjC
2448         bridge type in the header, and also because we're tearing down the bridge.
2449
2450         * loader/mac/WebMainResourceLoader.mm:
2451         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2452         m_contentLength and m_bytesReceived.
2453         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2454         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2455
2456         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2457         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2458
2459         * loader/mac/FormState.mm: Removed.
2460         * loader/FormState.cpp: Added.
2461
2462 2006-10-29  Darin Adler  <darin@apple.com>
2463
2464         Rubber stamped by Adam.
2465
2466         - moving towards use of FrameLoader cross-platform; move the headers
2467           for the Mac loader from loader/mac into loader, in preparation for
2468           making them useful on non-Mac
2469
2470         * WebCore.xcodeproj/project.pbxproj:
2471
2472         * loader/mac/FrameLoader.h: Removed.
2473         * loader/mac/WebDocumentLoader.h: Removed.
2474         * loader/mac/WebFormState.h: Removed.
2475         * loader/mac/WebLoader.h: Removed.
2476         * loader/mac/WebMainResourceLoader.h: Removed.
2477         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2478         * loader/mac/WebSubresourceLoader.h: Removed.
2479
2480         * loader/FrameLoader.h: Added.
2481         * loader/WebDocumentLoader.h: Added.
2482         * loader/WebFormState.h: Added.
2483         * loader/WebLoader.h: Added.
2484         * loader/WebMainResourceLoader.h: Added.
2485         * loader/WebNetscapePlugInStreamLoader.h: Added.
2486         * loader/WebSubresourceLoader.h: Added.
2487
2488 2006-10-29  Adam Roben  <aroben@apple.com>
2489
2490         Reviewed by Geoff.
2491
2492         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2493         r17405.
2494
2495         * platform/DeprecatedString.h:
2496
2497 2006-10-29  Beth Dakin  <bdakin@apple.com>
2498
2499         Rubber stamped by Geoff.
2500
2501         This is a followup to my HitTestResult checkin. Most of the
2502         HitTestResult local variables in the code were named i or info for
2503         when the class was named NodeInfo. This patch renames all of these
2504         local variables to result.
2505
2506         * dom/Document.cpp:
2507         (WebCore::Document::prepareMouseEvent):
2508         * html/HTMLAreaElement.cpp:
2509         (WebCore::HTMLAreaElement::mapMouseEvent):
2510         * html/HTMLMapElement.cpp:
2511         (WebCore::HTMLMapElement::mapMouseEvent):
2512         * rendering/EllipsisBox.cpp:
2513         (WebCore::EllipsisBox::nodeAtPoint):
2514         * rendering/EllipsisBox.h:
2515         * rendering/InlineBox.cpp:
2516         (WebCore::InlineBox::nodeAtPoint):
2517         * rendering/InlineFlowBox.cpp:
2518         (WebCore::InlineFlowBox::nodeAtPoint):
2519         * rendering/InlineTextBox.cpp:
2520         (WebCore::InlineTextBox::nodeAtPoint):
2521         * rendering/RenderBlock.cpp:
2522         (WebCore::RenderBlock::isPointInScrollbar):
2523         (WebCore::RenderBlock::nodeAtPoint):
2524         * rendering/RenderBlock.h:
2525         * rendering/RenderBox.cpp:
2526         (WebCore::RenderBox::nodeAtPoint):
2527         * rendering/RenderBox.h:
2528         * rendering/RenderFlow.cpp:
2529         (WebCore::RenderFlow::hitTestLines):
2530         * rendering/RenderFlow.h:
2531         * rendering/RenderForeignObject.cpp:
2532         (WebCore::RenderForeignObject::nodeAtPoint):
2533         * rendering/RenderFrameSet.cpp:
2534         (WebCore::RenderFrameSet::nodeAtPoint):
2535         * rendering/RenderImage.cpp:
2536         (WebCore::RenderImage::nodeAtPoint):
2537         * rendering/RenderInline.cpp:
2538         (WebCore::RenderInline::nodeAtPoint):
2539         * rendering/RenderInline.h:
2540         * rendering/RenderLayer.cpp:
2541         (WebCore::RenderLayer::autoscroll):
2542         (WebCore::RenderLayer::hitTest):
2543         (WebCore::RenderLayer::hitTestLayer):
2544         (WebCore::RenderLayer::updateHoverActiveState):
2545         * rendering/RenderListBox.cpp:
2546         (WebCore::RenderListBox::isPointInScrollbar):
2547         * rendering/RenderObject.cpp:
2548         (WebCore::RenderObject::hitTest):
2549         (WebCore::RenderObject::setInnerNode):
2550         (WebCore::RenderObject::nodeAtPoint):
2551         * rendering/RenderObject.h:
2552         * rendering/RenderPath.cpp:
2553         (WebCore::RenderPath::nodeAtPoint):
2554         * rendering/RenderSVGImage.cpp:
2555         (WebCore::RenderSVGImage::nodeAtPoint):
2556         * rendering/RenderSVGText.cpp:
2557         (WebCore::RenderSVGText::nodeAtPoint):
2558         * rendering/RenderTableRow.cpp:
2559         (WebCore::RenderTableRow::nodeAtPoint):
2560         * rendering/RenderTableRow.h:
2561         * rendering/RenderTableSection.cpp:
2562         (WebCore::RenderTableSection::nodeAtPoint):
2563         * rendering/RenderTableSection.h:
2564         * rendering/RenderTextControl.cpp:
2565         (WebCore::RenderTextControl::nodeAtPoint):
2566         * rendering/RootInlineBox.cpp:
2567         (WebCore::RootInlineBox::nodeAtPoint):
2568         * rendering/RootInlineBox.h:
2569
2570 2006-10-29  Adam Roben  <aroben@apple.com>
2571
2572         More semi-fixes.
2573
2574         * page/Page.cpp: Forgot to wrap the actual definition of
2575         setDefersLoading() in PLATFORM(MAC).
2576         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2577
2578 2006-10-29  Adam Roben  <aroben@apple.com>
2579
2580         Build semi-fix.
2581
2582         Move all FrameLoader-related code in Page.{cpp,h} within #if
2583         PLATFORM(MAC), since this class currently only exists on Mac.
2584
2585         * page/Page.cpp:
2586         * page/Page.h:
2587
2588 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2589
2590         build fix.
2591
2592         * platform/PlatformString.h:
2593         (WebCore::String::operator NSString*):
2594
2595 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2596
2597         Rolled out accidental commit.
2598
2599         * platform/AtomicString.h:
2600         (WebCore::AtomicString::AtomicString):
2601         (WebCore::AtomicString::operator NSString*):
2602
2603 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2604
2605         RS by Darin.
2606
2607         Rolled out change to map NULL Strings to nil NSStrings because it caused
2608         even more AppKit crashes. Maybe we should remove the NSString * operator
2609         entirely, since its use is not straight-forward, and require callers to
2610         specify explicitly whether they tolerate NULL.
2611
2612         * platform/AtomicString.h:
2613         * platform/PlatformString.h:
2614         (WebCore::String::operator NSString*):
2615         * platform/mac/TextFieldMac.mm:
2616         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2617
2618 2006-10-29  Darin Adler  <darin@apple.com>
2619
2620         Reviewed by Geoff.
2621
2622         - fixed storage leak showing up on the buildbot
2623
2624         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2625         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2626
2627 2006-10-29  Darin Adler  <darin@apple.com>
2628
2629         Rubber stamped by Adam.
2630
2631         - renamed WebFrameLoaderClient to match the class name inside it
2632
2633         * loader/mac/WebFrameLoaderClient.h: Removed.
2634         * loader/FrameLoaderClient.h: Moved it here.
2635
2636         * WebCore.xcodeproj/project.pbxproj: Updated project.
2637
2638         * bridge/mac/FrameMac.mm: Updated includes.
2639         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2640         * loader/mac/FrameLoader.mm: Ditto.
2641         * loader/mac/WebLoader.h: Ditto.
2642
2643 2006-10-29  Darin Adler  <darin@apple.com>
2644
2645         Reviewed by Mitz.
2646
2647         - fix crash visible on buildbot and also when running the test
2648           anchor-image-scrolled-x-y.html under libgmalloc
2649
2650         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2651         now that the class is named ResourceHandle.
2652         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2653         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2654         a local RefPtr before calling finishJobAndHandle, since we might get
2655         cancelled inside that function, so we should not rely on m_handle to
2656         keep the ResourceHandle alive.
2657         (WebCore::SubresourceLoader::didFail): Ditto.
2658         (WebCore::SubresourceLoader::didCancel): Ditto.
2659
2660 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2661
2662         - build fix
2663
2664         * platform/network/mac/ResourceHandleMac.mm:
2665
2666 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2667
2668         Rubber stamped by Darin.
2669
2670         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2671
2672         * CMakeLists.txt:
2673         * Projects/gdk/webcore-gdk.bkl:
2674         * WebCore.vcproj/WebCore/WebCore.vcproj:
2675         * WebCore.xcodeproj/project.pbxproj:
2676         * WebCoreSources.bkl:
2677         * bridge/mac/FrameMac.mm:
2678         * bridge/win/FrameWin.cpp:
2679         * dom/XMLTokenizer.cpp:
2680         * loader/Cache.cpp:
2681         * loader/CachedResource.h:
2682         * loader/LoaderFunctions.h:
2683         * loader/icon/IconLoader.cpp:
2684         (IconLoader::startLoading):
2685         (IconLoader::didReceiveData):
2686         (IconLoader::didFinishLoading):
2687         * loader/icon/IconLoader.h:
2688         * loader/loader.cpp:
2689         (WebCore::Loader::servePendingRequests):
2690         (WebCore::Loader::receivedAllData):
2691         (WebCore::Loader::receivedResponse):
2692         (WebCore::Loader::didReceiveData):
2693         (WebCore::Loader::cancelRequests):
2694         (WebCore::Loader::jobForRequest):
2695         * loader/loader.h:
2696         * loader/mac/IconLoaderMac.mm:
2697         (IconLoader::receivedResponse):
2698         * loader/mac/LoaderFunctionsMac.mm:
2699         * loader/mac/WebLoader.h:
2700         * loader/mac/WebSubresourceLoader.h:
2701         * loader/mac/WebSubresourceLoader.mm:
2702         (WebCore::SubresourceLoader::SubresourceLoader):
2703         (WebCore::SubresourceLoader::create):
2704         * platform/gdk/FrameGdk.cpp:
2705         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2706         (WebCore::FrameGdkClientDefault::openURL):
2707         (WebCore::FrameGdkClientDefault::submitForm):
2708         (WebCore::FrameGdkClientDefault::receivedResponse):
2709         (WebCore::FrameGdkClientDefault::didReceiveData):
2710         (WebCore::FrameGdkClientDefault::receivedAllData):
2711         * platform/gdk/FrameGdk.h:
2712         * platform/gdk/TemporaryLinkStubs.cpp:
2713         (WebCore::ServeSynchronousRequest):
2714         (WebCore::ResourceHandle::assembleResponseHeaders):
2715         (WebCore::ResourceHandle::retrieveCharset):
2716         * platform/network/ResourceHandle.cpp: Added.
2717         (WebCore::ResourceHandle::ResourceHandle):
2718         (WebCore::ResourceHandle::create):
2719         (WebCore::ResourceHandle::isErrorPage):
2720         (WebCore::ResourceHandle::error):
2721         (WebCore::ResourceHandle::setError):
2722         (WebCore::ResourceHandle::responseEncoding):
2723         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2724         (WebCore::ResourceHandle::kill):
2725         (WebCore::ResourceHandle::requestHeaders):
2726         (WebCore::ResourceHandle::url):
2727         (WebCore::ResourceHandle::postData):
2728         (WebCore::ResourceHandle::method):
2729         (WebCore::ResourceHandle::client):
2730         * platform/network/ResourceHandle.h: Added.
2731         (WebCore::ResourceHandle::getInternal):
2732         * platform/network/ResourceHandleClient.h: Added.
2733         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2734         (WebCore::ResourceHandleClient::didReceiveData):
2735         (WebCore::ResourceHandleClient::didFinishLoading):
2736         (WebCore::ResourceHandleClient::receivedRedirect):
2737         (WebCore::ResourceHandleClient::receivedResponse):
2738         (WebCore::ResourceHandleClient::receivedAllData):
2739         * platform/network/ResourceHandleInternal.h: Added.
2740         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2741         * platform/network/ResourceLoader.cpp: Removed.
2742         * platform/network/ResourceLoader.h: Removed.
2743         * platform/network/ResourceLoaderClient.h: Removed.
2744         * platform/network/ResourceLoaderInternal.h: Removed.
2745         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2746         (WebCore::willSendRequest):
2747         (WebCore::didReceiveResponse):
2748         (WebCore::didReceiveData):
2749         (WebCore::didFinishLoading):
2750         (WebCore::didFail):
2751         (WebCore::willCacheResponse):
2752         (WebCore::didReceiveChallenge):
2753         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2754         (WebCore::ResourceHandle::~ResourceHandle):
2755         (WebCore::ResourceHandle::start):
2756         (WebCore::ResourceHandle::cancel):
2757         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2758         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2759         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2760         (WebCore::ResourceHandle::~ResourceHandle):
2761         (WebCore::ResourceHandle::start):
2762         (WebCore::ResourceHandle::cancel):
2763         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2764         (WebCore::ResourceHandleManager::ResourceHandleManager):
2765         (WebCore::ResourceHandleManager::get):
2766         (WebCore::ResourceHandleManager::useSimpleTransfer):
2767         (WebCore::writeCallback):
2768         (WebCore::ResourceHandleManager::downloadTimerCallback):
2769         (WebCore::ResourceHandleManager::remove):
2770         (WebCore::ResourceHandleManager::add):
2771         (WebCore::ResourceHandleManager::cancel):
2772         * platform/network/gdk/ResourceHandleManager.h: Added.
2773         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2774         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2775         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2776         * platform/network/mac/ResourceHandleMac.mm: Added.
2777         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2778         (WebCore::ResourceHandle::~ResourceHandle):
2779         (WebCore::ResourceHandle::start):
2780         (WebCore::ResourceHandle::assembleResponseHeaders):
2781         (WebCore::ResourceHandle::retrieveResponseEncoding):
2782         (WebCore::ResourceHandle::receivedResponse):
2783         (WebCore::ResourceHandle::cancel):
2784         (WebCore::ResourceHandle::redirectedToURL):
2785         (WebCore::ResourceHandle::addData):
2786         (WebCore::ResourceHandle::finishJobAndHandle):
2787         (WebCore::ResourceHandle::reportError):
2788         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2789         * platform/network/qt/ResourceHandleManager.cpp: Added.
2790         (WebCore::ResourceHandleManager::ResourceHandleManager):
2791         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2792         (WebCore::ResourceHandleManager::self):
2793         (WebCore::ResourceHandleManager::slotData):
2794         (WebCore::ResourceHandleManager::slotMimetype):
2795         (WebCore::ResourceHandleManager::slotResult):
2796         (WebCore::ResourceHandleManager::remove):
2797         (WebCore::ResourceHandleManager::add):
2798         (WebCore::ResourceHandleManager::cancel):
2799         * platform/network/qt/ResourceHandleManager.h: Added.
2800         * platform/network/qt/ResourceHandleQt.cpp: Added.
2801         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2802         (WebCore::ResourceHandle::~ResourceHandle):
2803         (WebCore::ResourceHandle::start):
2804         (WebCore::ResourceHandle::cancel):
2805         (WebCore::ResourceHandle::assembleResponseHeaders):
2806         (WebCore::ResourceHandle::retrieveResponseEncoding):
2807         (WebCore::ResourceHandle::receivedResponse):
2808         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2809         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2810         * platform/network/qt/ResourceLoaderManager.h: Removed.
2811         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2812         * platform/network/win/ResourceHandleWin.cpp: Added.
2813         (WebCore::):
2814         (WebCore::addToOutstandingJobs):
2815         (WebCore::lookupResourceHandle):
2816         (WebCore::ResourceHandleWndProc):
2817         (WebCore::initializeOffScreenResourceHandleWindow):
2818         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2819         (WebCore::ResourceHandle::~ResourceHandle):
2820         (WebCore::ResourceHandle::onHandleCreated):
2821         (WebCore::ResourceHandle::onRequestRedirected):
2822         (WebCore::ResourceHandle::onRequestComplete):
2823         (WebCore::ResourceHandle::start):
2824         (WebCore::ResourceHandle::fileLoadTimer):
2825         (WebCore::ResourceHandle::cancel):
2826         (WebCore::ResourceHandle::setHasReceivedResponse):
2827         (WebCore::ResourceHandle::hasReceivedResponse):
2828         * platform/network/win/ResourceHandleWin.h: Added.
2829         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2830         * platform/network/win/ResourceLoaderWin.h: Removed.
2831         * platform/qt/FrameQt.cpp:
2832         * platform/qt/FrameQtClient.cpp:
2833         (WebCore::FrameQtClientDefault::openURL):
2834         (WebCore::FrameQtClientDefault::submitForm):
2835         (WebCore::FrameQtClientDefault::receivedResponse):
2836         (WebCore::FrameQtClientDefault::didReceiveData):
2837         (WebCore::FrameQtClientDefault::receivedAllData):
2838         * platform/qt/FrameQtClient.h:
2839         * platform/win/TemporaryLinkStubs.cpp:
2840         (WebCore::ResourceHandle::assembleResponseHeaders):
2841         (WebCore::ResourceHandle::retrieveResponseEncoding):
2842         (WebCore::ServeSynchronousRequest):
2843         * xml/XSLTProcessor.cpp:
2844         * xml/xmlhttprequest.cpp:
2845         (WebCore::XMLHttpRequest::send):
2846         (WebCore::XMLHttpRequest::didFinishLoading):
2847         (WebCore::XMLHttpRequest::receivedRedirect):
2848         (WebCore::XMLHttpRequest::didReceiveData):
2849         * xml/xmlhttprequest.h:
2850
2851 t2006-10-29  Darin Adler  <darin@apple.com>
2852
2853         Reviewed by Maciej.
2854
2855         - eliminate use of NSArray to carry form data around
2856
2857         * WebCore.exp:
2858         * WebCore.xcodeproj/project.pbxproj:
2859         * bridge/mac/FormDataMac.h: Removed.
2860         * bridge/mac/FormDataMac.mm: Removed.
2861         * bridge/mac/FrameMac.h:
2862         * bridge/mac/WebCoreFrameBridge.h:
2863         * bridge/mac/WebCoreFrameBridge.mm:
2864         * html/HTMLFormElement.cpp:
2865         (WebCore::HTMLFormElement::submit):
2866         * loader/FormData.h:
2867         (WebCore::FormData::isEmpty):
2868         * loader/mac/FrameLoader.h:
2869         * loader/mac/FrameLoader.mm:
2870         (WebCore::FrameLoader::load):
2871         (WebCore::FrameLoader::post):
2872         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2873         (WebCore::FrameLoader::loadResourceSynchronously):
2874         * loader/mac/LoaderFunctionsMac.mm:
2875         (WebCore::ServeSynchronousRequest):
2876         * loader/mac/WebFormDataStream.h:
2877         * loader/mac/WebFormDataStream.m:
2878         (WebCore::pairRetain):
2879         (WebCore::pairRelease):
2880         (WebCore::pairEqual):
2881         (WebCore::pairHash):
2882         (WebCore::closeCurrentStream):
2883         (WebCore::scheduleWithPair):
2884         (WebCore::advanceCurrentStream):
2885         (WebCore::openNextStream):
2886         (WebCore::formCreate):
2887         (WebCore::formFinalize):
2888         (WebCore::formOpen):
2889         (WebCore::formRead):
2890         (WebCore::formCanRead):
2891         (WebCore::formClose):
2892         (WebCore::formSchedule):
2893         (WebCore::formUnschedule):
2894         (WebCore::formEventCallback):
2895         (WebCore::setHTTPBody):
2896         * loader/mac/WebSubresourceLoader.h:
2897         * loader/mac/WebSubresourceLoader.mm:
2898         (WebCore::SubresourceLoader::create):
2899         * platform/network/mac/ResourceLoaderMac.mm:
2900
2901 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2902
2903         Reviewed by Darin.
2904
2905         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2906
2907         * loader/mac/WebSubresourceLoader.h:
2908         * loader/mac/WebSubresourceLoader.mm:
2909         (WebCore::SubresourceLoader::create):
2910         * platform/network/mac/ResourceLoaderMac.mm:
2911         (WebCore::ResourceLoader::start):
2912
2913 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2914
2915         Reviewed by Darin.
2916
2917         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2918
2919         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2920
2921         * WebCore.xcodeproj/project.pbxproj:
2922         * bridge/mac/WebCoreFrameBridge.h:
2923         * loader/mac/FrameLoader.h:
2924         * loader/mac/FrameLoader.mm:
2925         * loader/mac/LoaderFunctionsMac.mm:
2926         * loader/mac/WebLoader.h:
2927         * loader/mac/WebSubresourceLoader.h:
2928         * loader/mac/WebSubresourceLoader.mm:
2929         (WebCore::SubresourceLoader::SubresourceLoader):
2930         (WebCore::SubresourceLoader::create):
2931         (WebCore::SubresourceLoader::willSendRequest):
2932         (WebCore::SubresourceLoader::didReceiveResponse):
2933         (WebCore::SubresourceLoader::didReceiveData):
2934         (WebCore::SubresourceLoader::didFinishLoading):
2935         (WebCore::SubresourceLoader::didFail):
2936         (WebCore::SubresourceLoader::didCancel):
2937         * platform/network/ResourceLoader.h:
2938         * platform/network/ResourceLoaderInternal.h:
2939         * platform/network/mac/ResourceLoaderMac.mm:
2940         (WebCore::ResourceLoader::~ResourceLoader):
2941         (WebCore::ResourceLoader::start):
2942         (WebCore::ResourceLoader::receivedResponse):
2943         (WebCore::ResourceLoader::cancel):
2944         (WebCore::ResourceLoader::redirectedToURL):
2945         (WebCore::ResourceLoader::addData):
2946         (WebCore::ResourceLoader::finishJobAndHandle):
2947         (WebCore::ResourceLoader::reportError):
2948         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2949         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2950         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2951
2952 2006-10-28  Darin Adler  <darin@apple.com>
2953
2954         Reviewed by Maciej.
2955
2956         - eliminated the use of Objective-C for the policy decider
2957           machinery, obviating the need for WebPolicyDecider,
2958           WebCoreFrameLoaderAsDelegate, and
2959           WebCoreMainResourceLoaderAsPolicyDelegate
2960
2961         - grouped the state related to policy decisions into a PolicyCheck
2962           class to simplify the FrameLoader logic
2963
2964         - removed six methods from the bridge, reducing FrameLoader's use of
2965           the bridge to a single method
2966
2967         - changed form state to always use HashMap instead of NSDictionary
2968
2969         - moved the defersLoading flag from WebView to WebCore::Page
2970           and changed code to consistently call it defersLoading rather
2971           than defersCallbacks
2972
2973         - updated for rename of PassRefPtr::release to releaseRef
2974         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2975         - cleaned up kjs_binding.h a bit
2976         - cleaned up FrameMac.h a bit
2977
2978         * loader/mac/WebPolicyDecider.h: Removed.
2979         * loader/mac/WebPolicyDecider.mm: Removed.
2980         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2981
2982         * WebCore.exp:
2983         * bindings/js/kjs_binding.cpp:
2984         (KJS::ScriptInterpreter::ScriptInterpreter):
2985         (KJS::ScriptInterpreter::wasRunByUserGesture):
2986         * bindings/js/kjs_binding.h:
2987         (KJS::ScriptInterpreter::setCurrentEvent):
2988         (KJS::ScriptInterpreter::setInlineCode):
2989         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2990         (KJS::ScriptInterpreter::getCurrentEvent):
2991         (KJS::cacheDOMObject):
2992         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2993         * bridge/AXObjectCache.h:
2994         * bridge/mac/BrowserExtensionMac.mm:
2995         (WebCore::BrowserExtensionMac::createNewWindow):
2996         * bridge/mac/FrameMac.h:
2997         * bridge/mac/FrameMac.mm:
2998         (WebCore::FrameMac::loadRequest):
2999         (WebCore::FrameMac::submitForm):
3000         (WebCore::FrameMac::urlSelected):
3001         (WebCore::FrameMac::userAgent):
3002         (WebCore::FrameMac::passMouseDownEventToWidget):
3003         (WebCore::FrameMac::handleMouseMoveEvent):
3004         * bridge/mac/PageMac.mm:
3005         (WebCore::Page::Page):
3006         * bridge/mac/WebCoreEditCommand.mm:
3007         * bridge/mac/WebCoreFrameBridge.h:
3008         * bridge/mac/WebCoreFrameBridge.mm:
3009         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3010         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3011         * css/CSSComputedStyleDeclaration.cpp:
3012         (WebCore::):
3013         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3014         * css/CSSPrimitiveValue.cpp:
3015         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3016         (WebCore::CSSPrimitiveValue::cleanup):
3017         (WebCore::CSSPrimitiveValue::cssText):
3018         * css/CSSPrimitiveValue.h:
3019         (WebCore::CSSPrimitiveValue::):
3020         * css/CSSValueList.cpp:
3021         (WebCore::CSSValueList::append):
3022         * css/cssparser.cpp:
3023         (WebCore::CSSParser::parseValue):
3024         * css/cssparser.h:
3025         * css/cssstyleselector.cpp:
3026         (WebCore::CSSStyleSelector::applyProperty):
3027         * dom/Document.cpp:
3028         (WebCore::Document::Document):
3029         (WebCore::Document::updateSelection):
3030         (WebCore::Document::implicitClose):
3031         (WebCore::Document::setFocusNode):
3032         * dom/Document.h:
3033         * editing/ReplaceSelectionCommand.h:
3034         * html/HTMLParser.cpp:
3035         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
3036         * loader/mac/FrameLoader.h:
3037         (WebCore::PolicyCheck::request):
3038         * loader/mac/FrameLoader.mm:
3039         (WebCore::FrameLoader::~FrameLoader):
3040         (WebCore::FrameLoader::safeLoad):
3041         (WebCore::FrameLoader::load):
3042         (WebCore::FrameLoader::open):
3043         (WebCore::FrameLoader::stopLoading):
3044         (WebCore::setAllDefersLoading):
3045         (WebCore::FrameLoader::setDefersLoading):
3046         (WebCore::FrameLoader::willSendRequest):
3047         (WebCore::FrameLoader::receivedMainResourceError):
3048         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
3049         (WebCore::FrameLoader::commitProvisionalLoad):
3050         (WebCore::FrameLoader::checkNavigationPolicy):
3051         (WebCore::FrameLoader::checkContentPolicy):
3052         (WebCore::FrameLoader::cancelContentPolicyCheck):
3053         (WebCore::FrameLoader::stopPolicyCheck):
3054         (WebCore::FrameLoader::checkNewWindowPolicy):
3055         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3056         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3057         (WebCore::FrameLoader::continueAfterContentPolicy):
3058         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3059         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
3060         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3061         (WebCore::FrameLoader::closeDocument):
3062         (WebCore::FrameLoader::transitionToCommitted):
3063         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
3064         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
3065         (WebCore::FrameLoader::post):
3066         (WebCore::FrameLoader::detachFromParent):
3067         (WebCore::FrameLoader::addExtraFieldsToRequest):
3068         (WebCore::PolicyCheck::PolicyCheck):
3069         (WebCore::PolicyCheck::clear):
3070         (WebCore::PolicyCheck::set):
3071         (WebCore::PolicyCheck::call):
3072         (WebCore::PolicyCheck::dropRequest):
3073         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3074         * loader/mac/WebFormState.h:
3075         * loader/mac/WebFormState.mm:
3076         * loader/mac/WebFrameLoaderClient.h:
3077         * loader/mac/WebLoader.h:
3078         (WebCore::WebResourceLoader::defersLoading):
3079         * loader/mac/WebLoader.mm:
3080         (WebCore::WebResourceLoader::WebResourceLoader):
3081         (WebCore::WebResourceLoader::load):
3082         (WebCore::WebResourceLoader::setDefersLoading):
3083         * loader/mac/WebMainResourceLoader.h:
3084         * loader/mac/WebMainResourceLoader.mm:
3085         (WebCore::MainResourceLoader::MainResourceLoader):
3086         (WebCore::MainResourceLoader::releaseDelegate):
3087         (WebCore::MainResourceLoader::didCancel):
3088         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3089         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3090         (WebCore::MainResourceLoader::willSendRequest):
3091         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3092         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3093         (WebCore::MainResourceLoader::didReceiveResponse):
3094         (WebCore::MainResourceLoader::didReceiveData):
3095         (WebCore::MainResourceLoader::didFinishLoading):
3096         (WebCore::MainResourceLoader::didFail):
3097         (WebCore::MainResourceLoader::loadNow):
3098         (WebCore::MainResourceLoader::load):
3099         (WebCore::MainResourceLoader::setDefersLoading):
3100         * page/Frame.cpp:
3101         (WebCore::Frame::paint):
3102         * page/FrameView.cpp:
3103         (WebCore::FrameView::layout):
3104         * page/FrameView.h:
3105         * page/Page.cpp:
3106         (WebCore::Page::setDefersLoading):
3107         * page/Page.h:
3108         (WebCore::Page::defersLoading):
3109         * platform/DeprecatedString.h:
3110         * platform/DeprecatedStringList.h:
3111         * platform/FontFallbackList.h:
3112         * platform/PlatformKeyboardEvent.h:
3113         * platform/PlatformMouseEvent.h:
3114         * platform/PlatformWheelEvent.h:
3115         * platform/mac/ClipboardMac.h:
3116         * platform/mac/ClipboardMac.mm:
3117         (WebCore::ClipboardMac::setDragImage):
3118         (WebCore::ClipboardMac::dragNSImage):
3119         (WebCore::ClipboardMac::sourceOperation):
3120         (WebCore::ClipboardMac::destinationOperation):
3121         * rendering/RenderObject.cpp:
3122         (WebCore::RenderObject::setStyle):
3123         * rendering/break_lines.cpp:
3124         (WebCore::nextBreakablePosition):
3125
3126 2006-10-28  Adam Roben  <aroben@apple.com>
3127
3128         Reviewed by Maciej.
3129
3130         Fix layout tests that broke after r17399. Mitz discovered that the
3131         failures were caused by HitTestResult::m_point being uninitialized
3132         much of the time. HitTestResults are now always constructed with a
3133         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3134         point instead of being passed one explicitly.
3135
3136         * WebCore.exp: Change constructor symbol.
3137         * bridge/mac/FrameMac.mm:
3138         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3139         hitTest().
3140         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3141         * bridge/mac/WebCoreAXObject.mm:
3142         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3143         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3144         * dom/Document.cpp:
3145         (WebCore::Document::elementFromPoint): Ditto.
3146         (WebCore::Document::prepareMouseEvent): Ditto.
3147         * page/Frame.cpp:
3148         (WebCore::Frame::isPointInsideSelection): Ditto.
3149         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3150         * page/FrameView.cpp:
3151         (WebCore::FrameView::handleWheelEvent): Ditto.
3152         * rendering/HitTestResult.cpp:
3153         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3154         passed point.
3155         * rendering/HitTestResult.h: Update constructor declaration.
3156         * rendering/RenderLayer.cpp:
3157         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3158         hitTest().
3159         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3160         HitTestResult instead of being passed one.
3161         (WebCore::RenderLayer::hitTestLayer): Ditto.
3162         * rendering/RenderLayer.h: Update declarations.
3163
3164 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3165
3166         Reviewed by Anders.
3167
3168         Fix Qt/Linux build.
3169
3170         * CMakeLists.txt:
3171         * platform/qt/FrameQtClient.cpp:
3172         (WebCore::numRequests):
3173         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3174         * platform/qt/PopupMenuQt.cpp:
3175         (WebCore::PopupMenu::updateFromElement):
3176
3177 2006-10-28  David Carson  <dacarson@gmail.com>
3178
3179         Tweaked by Sam. Reviewed by Brady.
3180
3181         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3182         Initialize m_modifyBiasSet to false, as it sometimes gets
3183         used before it has been initalized.
3184
3185         * editing/SelectionController.cpp:
3186         (WebCore::SelectionController::SelectionController):
3187
3188 2006-10-28  Beth Dakin  <bdakin@apple.com>
3189
3190         Reviewed by Darin.
3191
3192         This is the WebCore half of pushing elementAtPoint and the backend
3193         of WebElementDictionary into WebCore. Most of the changes below are
3194         to accommodate one of the following:
3195
3196         -NodeInfo is now a stand-alone class called HitTestResult.
3197                 Previously it was defined in RenderObject.h, but not for
3198                 any particular reason. The WebElementDictionary
3199                 functionality that was pushed into WebCore has been pushed
3200                 specifically into the this class. In fact,
3201                 WebElementDictionary now keeps a HitTestResult as a member
3202                 varibale.
3203
3204         -The enumeration AccessPolicy is now called
3205                 ClipboardAccessPolicy and is defined in its own header. It
3206                 was previously defined in ClipboardMac.h, but is now
3207                 defined independently to avoid including ClipboardMac.h
3208                 from within FrameMac.h since FrameMac.h is now included in
3209                 WebElementDictionary.m in WebKit.
3210
3211         -Element now has a virtual target() for the sake of
3212                 NodeInfo::targetFrame()
3213
3214         * WebCore.exp: Several WebCore functions are newly called from
3215         WebKit, so they have been added here.
3216         * WebCore.xcodeproj/project.pbxproj:
3217         * bindings/objc/DOM.mm: Must include Image.h because of adjustments
3218         to ClipboardMac.
3219         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3220         * bridge/mac/FrameMac.mm:
3221         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy
3222         and HitTestResult changes.
3223         (WebCore::FrameMac::eventMayStartDrag): Same.
3224         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3225         (WebCore::FrameMac::dispatchCPPEvent): Same.
3226         (WebCore::FrameMac::mayDHTMLCut): Same.
3227         (WebCore::FrameMac::mayDHTMLCopy): Same.
3228         (WebCore::FrameMac::mayDHTMLPaste): Same.
3229         (WebCore::FrameMac::tryDHTMLCut): Same
3230         (WebCore::FrameMac::tryDHTMLCopy): Same.
3231         (WebCore::FrameMac::tryDHTMLPaste): Same.
3232         * bridge/mac/WebCoreAXObject.mm:
3233         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to
3234         HitTestResult changes.
3235         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3236         * bridge/mac/WebCoreFrameBridge.h: Same.
3237         * bridge/mac/WebCoreFrameBridge.mm:
3238         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for
3239         ClipboardAccessPolicy changes.
3240         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3241         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3242         * dom/Document.cpp:
3243         (WebCore::Document::elementFromPoint): Adjust for HitTestResult
3244         changes.
3245         (WebCore::Document::prepareMouseEvent): Same.
3246         * dom/Element.h:
3247         (WebCore::Element::target): Now has a virtual target()
3248         * html/HTMLAnchorElement.h: Same.
3249         * html/HTMLAreaElement.cpp:
3250         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult
3251         changes.
3252         * html/HTMLAreaElement.h: Virtual target()
3253         * html/HTMLBaseElement.h:
3254         (WebCore::HTMLBaseElement::target): Same.
3255         * html/HTMLFormElement.h: Same.
3256         * html/HTMLLinkElement.h: Same.
3257         * html/HTMLMapElement.cpp:
3258         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult
3259         changes.
3260         * html/HTMLMapElement.h: Same.
3261         * page/Frame.cpp:
3262         (WebCore::Frame::isPointInsideSelection): Same.
3263         (WebCore::Frame::hitTestResultAtPoint): Same.
3264         * page/Frame.h: Same.
3265         * page/FrameView.cpp:
3266         (WebCore::FrameView::handleWheelEvent): Same.
3267         * platform/mac/ClipboardAccessPolicy.h: Added.
3268         (WebCore::):
3269         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy,
3270         include ClipboardAccessPolicy.h, and rename AccessPolicy to
3271         ClipboardAccessPolicy.
3272         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3273         (WebCore::ClipboardMac::ClipboardMac):
3274         (WebCore::ClipboardMac::setAccessPolicy):
3275         (WebCore::ClipboardMac::clearData):
3276         (WebCore::ClipboardMac::clearAllData):
3277         (WebCore::ClipboardMac::getData):
3278         (WebCore::ClipboardMac::setData):
3279         (WebCore::ClipboardMac::types):
3280         (WebCore::ClipboardMac::setDragImage):
3281         (WebCore::ClipboardMac::setDropEffect):
3282         (WebCore::ClipboardMac::setEffectAllowed):
3283         * rendering/EllipsisBox.cpp:
3284         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult
3285         changes.
3286         * rendering/EllipsisBox.h:
3287         * rendering/HitTestResult.cpp: Added.
3288         (WebCore::HitTestResult::HitTestResult):
3289         (WebCore::HitTestResult::~HitTestResult):
3290         (WebCore::HitTestResult::operator=):
3291         (WebCore::HitTestResult::setInnerNode):
3292         (WebCore::HitTestResult::setInnerNonSharedNode):
3293         (WebCore::HitTestResult::setURLElement):
3294         (WebCore::HitTestResult::setScrollbar):
3295         (WebCore::HitTestResult::targetFrame):
3296         (WebCore::HitTestResult::boundingBox):
3297         (WebCore::HitTestResult::isSelected):
3298         (WebCore::HitTestResult::title):
3299         * rendering/HitTestResult.h: Added.
3300         (WebCore::HitTestResult::readonly):
3301         (WebCore::HitTestResult::active):
3302         (WebCore::HitTestResult::mouseMove):
3303         (WebCore::HitTestResult::innerNode):
3304         (WebCore::HitTestResult::innerNonSharedNode):
3305         (WebCore::HitTestResult::point):
3306         (WebCore::HitTestResult::URLElement):
3307         (WebCore::HitTestResult::scrollbar):
3308         (WebCore::HitTestResult::setPoint):
3309         (WebCore::HitTestResult::setReadonly):
3310         (WebCore::HitTestResult::setActive):
3311         (WebCore::HitTestResult::setMouseMove):
3312         * rendering/InlineBox.cpp:
3313         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3314         * rendering/InlineBox.h: Same.
3315         * rendering/InlineFlowBox.cpp:
3316         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3317         * rendering/InlineFlowBox.h: Same.
3318         * rendering/InlineTextBox.cpp:
3319         (WebCore::InlineTextBox::nodeAtPoint): Same.
3320         * rendering/InlineTextBox.h: Same.
3321         * rendering/RenderBlock.cpp:
3322         (WebCore::RenderBlock::isPointInScrollbar): Same.
3323         (WebCore::RenderBlock::nodeAtPoint): Same.
3324         * rendering/RenderBlock.h: Same.
3325         * rendering/RenderBox.cpp:
3326         (WebCore::RenderBox::nodeAtPoint): Same.
3327         * rendering/RenderBox.h: Same.
3328         * rendering/RenderFlow.cpp:
3329         (WebCore::RenderFlow::hitTestLines): Same.
3330         * rendering/RenderFlow.h: Same.
3331         * rendering/RenderForeignObject.cpp:
3332         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3333         * rendering/RenderForeignObject.h: Same.
3334         * rendering/RenderFrameSet.cpp:
3335         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3336         * rendering/RenderFrameSet.h: Same.
3337         * rendering/RenderImage.cpp:
3338         (WebCore::RenderImage::nodeAtPoint): Same.
3339         * rendering/RenderImage.h: Same.
3340         * rendering/RenderInline.cpp:
3341         (WebCore::RenderInline::nodeAtPoint): Same.
3342         * rendering/RenderInline.h: Same.
3343         * rendering/RenderLayer.cpp:
3344         (WebCore::RenderLayer::autoscroll): Same.
3345         (WebCore::RenderLayer::hitTest): Same.
3346         (WebCore::RenderLayer::hitTestLayer): Same.
3347         (WebCore::RenderLayer::updateHoverActiveState): Same.
3348         * rendering/RenderLayer.h: Same.
3349         * rendering/RenderListBox.cpp:
3350         (WebCore::RenderListBox::isPointInScrollbar): Same.
3351         * rendering/RenderListBox.h: Same.
3352         * rendering/RenderObject.cpp:
3353         (WebCore::RenderObject::hitTest): Same.
3354         (WebCore::RenderObject::setInnerNode): Same.
3355         (WebCore::RenderObject::nodeAtPoint): Same.
3356         * rendering/RenderObject.h: Remove NodeInfo class and forward
3357         declare HitTestResult.
3358         * rendering/RenderPath.cpp:
3359         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult
3360         changes.
3361         * rendering/RenderPath.h: Same.
3362         * rendering/RenderSVGImage.cpp:
3363         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3364         * rendering/RenderSVGImage.h: Same
3365         * rendering/RenderSVGText.cpp:
3366         (WebCore::RenderSVGText::nodeAtPoint): Same.
3367         * rendering/RenderSVGText.h: Same.
3368         * rendering/RenderTableRow.cpp:
3369         (WebCore::RenderTableRow::nodeAtPoint): Same.
3370         * rendering/RenderTableRow.h: Same.
3371         * rendering/RenderTableSection.cpp:
3372         (WebCore::RenderTableSection::nodeAtPoint): Same.
3373         * rendering/RenderTableSection.h: Same.
3374         * rendering/RenderText.h: Same.
3375         (WebCore::RenderText::nodeAtPoint): Same.
3376         * rendering/RenderTextControl.cpp:
3377         (WebCore::RenderTextControl::nodeAtPoint): Same.
3378         * rendering/RenderTextControl.h: Same.
3379         * rendering/RootInlineBox.cpp:
3380         (WebCore::RootInlineBox::nodeAtPoint): Same.
3381         * rendering/RootInlineBox.h: Same.
3382
3383 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3384
3385         Reviewed by Anders.
3386
3387         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3388         impact of fixing it again.
3389
3390         * bridge/mac/FrameMac.mm:
3391         (WebCore::FrameMac::clear):
3392
3393 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3394
3395         Reviewed by John & Adam.
3396
3397         - assorted speedups to fix perf regression from fixing correctness regression
3398
3399         * WebCore.exp: exported new methods.
3400         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3401         * bridge/mac/WebCoreFrameBridge.h:
3402         * bridge/mac/WebCoreFrameBridge.mm:
3403         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3404         * loader/CachedResource.h:
3405         * loader/mac/CachedResourceMac.mm: Added.
3406         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3407         now cached in the CachedObject.
3408         * loader/mac/FrameLoader.h:
3409         * loader/mac/FrameLoader.mm:
3410         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3411         the WebKit side do faster dispatch for clients that implement the fast path delegate.
3412         * loader/mac/LoaderFunctionsMac.mm:
3413         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3414         just call loadedResourceFromMemoryCache.
3415         * loader/mac/WebFrameLoaderClient.h:
3416
3417 2006-10-27  Oliver Hunt  <oliver@apple.com>
3418
3419         Reviewed by Maciej.
3420
3421         build fix
3422
3423         * dom/Document.cpp:
3424         (WebCore::Document::referrer):
3425
3426 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3427
3428         Reviewed by Maciej.
3429
3430         Moved some WebCoreFrameBridge functions into FrameLoader.
3431
3432         I had to make FrameLoader.h capable of compiling in C++-only source files
3433         by adding some forward declarations and __OBJC__ #ifdefs.
3434
3435         * WebCore.exp:
3436         * bridge/mac/FrameMac.h:
3437         * bridge/mac/FrameMac.mm:
3438         (WebCore::FrameMac::createEmptyDocument):
3439         (WebCore::FrameMac::tokenizerProcessedData):
3440         * bridge/mac/WebCoreFrameBridge.h:
3441         * bridge/mac/WebCoreFrameBridge.mm:
3442         * dom/Document.cpp:
3443         (WebCore::Document::processHttpEquiv):
3444         (WebCore::Document::referrer):
3445         * loader/LoaderFunctions.h:
3446         * loader/mac/FrameLoader.h:
3447         * loader/mac/FrameLoader.mm:
3448         (WebCore::numRequests):
3449         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3450         (WebCore::FrameLoader::isReloading):
3451         (WebCore::FrameLoader::referrer):
3452         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3453         (WebCore::FrameLoader::startLoadingResource):
3454         * loader/mac/LoaderFunctionsMac.mm:
3455         (WebCore::CheckIfReloading):
3456         * page/Frame.h:
3457         * page/FrameTree.cpp:
3458         (WebCore::FrameTree::isDescendantOf):
3459         (WebCore::FrameTree::traverseNext):
3460         * page/FrameTree.h:
3461         * platform/network/mac/ResourceLoaderMac.mm:
3462         (WebCore::ResourceLoader::start):
3463
3464 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3465
3466         Reviewed by Darin.
3467
3468         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3469
3470         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3471
3472         * editing/DeleteButtonController.cpp:
3473         (WebCore::isDeletableElement):
3474         (WebCore::enclosingDeletableElement):
3475         (WebCore::DeleteButtonController::respondToChangedSelection):
3476
3477 2006-10-27  John Sullivan  <sullivan@apple.com>
3478
3479         Reviewed by Kevin Decker
3480
3481         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3482         you haven't not finished reading this.
3483
3484         * rendering/InlineTextBox.h:
3485         * rendering/InlineTextBox.cpp:
3486         (WebCore::InlineTextBox::paint):
3487         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3488         considered also.
3489         (WebCore::InlineTextBox::paintDocumentMarkers):
3490         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3491         markers should be painted, instead of a marker type. This avoids walking the collection of
3492         markers multiple times back to back. Now handles grammar markers.
3493
3494 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3495
3496         Reviewed by Beth.
3497
3498         Renamed Copy Files to Copy Generated Headers.
3499         Copy 4 DOM*Internal.h headers.
3500
3501         * WebCore.xcodeproj/project.pbxproj:
3502         * bindings/scripts/CodeGeneratorObjC.pm:
3503
3504 2006-10-27  John Sullivan  <sullivan@apple.com>
3505
3506         Reviewed by Anders
3507
3508         * WebCore.exp:
3509         exported symbol for FrameMac->advanceToNextSpelling()
3510
3511         * bridge/mac/WebCoreFrameBridge.h:
3512         * bridge/mac/WebCoreFrameBridge.mm:
3513         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3514
3515 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3516
3517         Reviewed by harrison
3518
3519         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3520         REGRESSION: First newline missing from textarea's value
3521
3522         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3523
3524         Before my change in r17223, return (an InsertLineBreak) would insert a '\n'
3525         (the line break) then a br to prevent the '\n' from collapsing, since the
3526         insertion is being done at the end of a block (the textarea's shadow div).  Then,
3527         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
3528         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed
3529         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
3530         serialize as "foobar" because when serializing RenderTextControl intentionally asks
3531         textContent to not convert brs to newlines.  It seems to think that the only brs in
3532  &