1c78544864ddafd271b3f925caab737b33c5e022
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-15  Adam Roben  <aroben@apple.com>
2
3         Reviewed by Anders.
4
5         Change m_contextMenu to an OwnPtr.
6
7         * WebCore.xcodeproj/project.pbxproj:
8         * page/ContextMenuController.cpp:
9         (WebCore::ContextMenuController::handleContextMenuEvent):
10         * page/ContextMenuController.h:
11
12 2006-11-15  Adam Roben  <aroben@apple.com>
13
14         Reviewed by Anders.
15
16         Add new ContextMenuController and ContextMenuClient classes, and move
17         context menu responsibilities from Chrome and ChromeClient to them.
18
19         * WebCore.exp:
20         * WebCore.xcodeproj/project.pbxproj: Add new files to project, and
21         alphabetize some others.
22         * page/Chrome.cpp: Remove context menu-related code.
23         * page/Chrome.h: Ditto.
24         * page/ChromeClient.h:
25         * page/ContextMenuClient.h: Added.
26         * page/ContextMenuController.cpp: Added.
27         (WebCore::ContextMenuController::ContextMenuController):
28         (WebCore::ContextMenuController::~ContextMenuController):
29         (WebCore::ContextMenuController::handleContextMenuEvent):
30         (WebCore::ContextMenuController::contextMenuActionSelected):
31         * page/ContextMenuController.h: Added.
32         (WebCore::ContextMenuController::client):
33         * page/Page.cpp: Every Page now has a ContextMenuController.
34         (WebCore::Page::Page):
35         * page/Page.h: Made m_dragCaretController and m_chrome objects instead
36         of pointers to objects.
37         (WebCore::Page::contextMenuController):
38         * platform/ContextMenu.cpp:
39         (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the
40         delegate to add its menu items, and moved the code from the static
41         addDefaultItems function into this method.
42         * platform/ContextMenu.h:
43         (WebCore::ContextMenu::show): Added an empty method body since this
44         method is now called from ContextMenuController (although no one calls
45         into ContextMenuController yet, so it's OK for this to be empty).
46         (WebCore::ContextMenu::hide): Ditto.
47
48 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
49
50         Reviewed by Darin.
51
52         Add null checks on the node filter, they can be null if no filter was passed to the respective
53         create functions.
54         
55         * bindings/js/JSNodeIteratorCustom.cpp:
56         (WebCore::JSNodeIterator::mark):
57         * bindings/js/JSTreeWalkerCustom.cpp:
58         (WebCore::JSTreeWalker::mark):
59
60 2006-11-15  Oliver Hunt  <oliver@apple.com>
61
62         Reviewed by Anders.
63
64         Allow <embed> and <object> tags to include non-plugin
65         content when plugins are disabled
66
67         Fixes <rdar://problems/4839488>
68
69         * html/HTMLEmbedElement.cpp:
70         (WebCore::HTMLEmbedElement::rendererIsNeeded):
71         * html/HTMLObjectElement.cpp:
72         (WebCore::HTMLObjectElement::rendererIsNeeded):
73         * loader/FrameLoader.cpp:
74         (WebCore::FrameLoader::requestObject):
75
76 2006-11-15  Adele Peterson  <adele@apple.com>
77
78         Build fix.  Another type problem that I don't see locally.
79
80         * rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
81
82 2006-11-15  Adele Peterson  <adele@apple.com>
83
84         Reviewed by Adam.
85
86         Adding MathExtras header.
87
88         * rendering/RenderSlider.cpp:
89
90 2006-11-15  Timothy Hatcher  <timothy@apple.com>
91
92         Reviewed by Harrison.
93
94         <rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
95
96         * Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected
97           by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
98
99         * Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before
100           the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
101
102         * Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
103
104         * editing/DeleteButtonController.cpp:
105         (WebCore::DeleteButtonController::DeleteButtonController):
106         (WebCore::isDeletableElement):
107         (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state
108         (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state
109         (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed
110         (WebCore::DeleteButtonController::deleteTarget): check the enabled state
111         * editing/DeleteButtonController.h:
112         (WebCore::DeleteButtonController::disable):
113         (WebCore::DeleteButtonController::enable):
114         (WebCore::DeleteButtonController::enabled):
115         * editing/EditCommand.cpp:
116         (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end
117         (WebCore::EditCommand::unapply): ditto
118         (WebCore::EditCommand::reapply): ditto
119
120 2006-11-15  Adele Peterson  <adele@apple.com>
121
122         Reviewed by Adam.
123
124         New implementation of slider control.
125
126         * WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
127         * rendering/DeprecatedSlider.cpp: Removed.
128         * rendering/DeprecatedSlider.h: Removed.
129         * platform/Slider.h: Removed.
130         * platform/mac/SliderMac.mm: Removed.
131         * platform/win/TemporaryLinkStubs.cpp:
132
133         * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
134         * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
135         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): 
136         * rendering/RenderStyle.cpp:
137         (WebCore::):
138         (WebCore::pseudoBit):
139         * rendering/RenderStyle.h: (WebCore::RenderStyle::):
140
141         * css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
142
143         * html/HTMLInputElement.cpp:
144         (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements.
145         (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
146
147         * page/EventHandler.cpp:  Added concept of a node that will capture all mouse events.  This will be used by the slider thumb, so it can
148           continue to capture mouse move events during the drag, even though those events aren't directly over the slider.
149         (WebCore::EventHandler::EventHandler):
150         (WebCore::EventHandler::setCapturingMouseEventsNode):
151         (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
152         * page/EventHandler.h:
153
154         * rendering/RenderSlider.cpp: Added.
155         (WebCore::HTMLSliderThumbElement::isShadowNode):
156         (WebCore::HTMLSliderThumbElement::shadowParentNode):
157         (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode.
158         (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
159         (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag.
160         (WebCore::RenderSlider::RenderSlider):
161         (WebCore::RenderSlider::~RenderSlider):
162         (WebCore::RenderSlider::baselinePosition):
163         (WebCore::RenderSlider::calcMinMaxWidth):
164         (WebCore::RenderSlider::setStyle):
165         (WebCore::RenderSlider::createThumbStyle):
166         (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track.
167         (WebCore::RenderSlider::updateFromElement):
168         (WebCore::RenderSlider::mouseEventIsInThumb):
169         (WebCore::RenderSlider::setValueForPosition):
170         (WebCore::RenderSlider::setPositionFromValue):
171         (WebCore::RenderSlider::positionForOffset):
172         (WebCore::RenderSlider::valueChanged):
173         (WebCore::RenderSlider::currentPosition):
174         (WebCore::RenderSlider::setCurrentPosition):
175         (WebCore::RenderSlider::trackSize):
176         (WebCore::RenderSlider::forwardEvent):
177         (WebCore::RenderSlider::inDragMode):
178         * rendering/RenderSlider.h: Added.
179         (WebCore::RenderSlider::renderName):
180
181          * rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.
182         (WebCore::RenderTheme::adjustStyle):
183         (WebCore::RenderTheme::paint):
184         (WebCore::RenderTheme::paintBorderOnly):
185         (WebCore::RenderTheme::paintDecorations):
186         (WebCore::RenderTheme::adjustSliderTrackStyle):
187         (WebCore::RenderTheme::adjustSliderThumbStyle):
188         * rendering/RenderTheme.h:
189         (WebCore::RenderTheme::paintSliderTrack):
190         (WebCore::RenderTheme::paintSliderThumb):
191         * rendering/RenderThemeMac.h:
192         * rendering/RenderThemeMac.mm:
193         (WebCore::RenderThemeMac::RenderThemeMac):
194         (WebCore::TrackGradientInterpolate):
195         (WebCore::RenderThemeMac::paintSliderTrack):
196         (WebCore::RenderThemeMac::paintSliderThumb):
197         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
198         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
199
200 2006-11-15  Beth Dakin  <bdakin@apple.com>
201
202         Reviewed by Adam.
203
204         Oops! Forgot to add this!
205
206         * platform/mac/ContextMenuMac.mm: Added.
207         (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]):
208         (-[MenuTarget WebCore::]):
209         (-[MenuTarget setMenu:WebCore::]):
210         (-[MenuTarget forwardContextMenuAction:]):
211         (getNSMenuItem):
212         (ContextMenu::appendItem):
213         (ContextMenu::itemCount):
214         (ContextMenu::insertItem):
215         (ContextMenu::setPlatformMenuDescription):
216
217 2006-11-15  Beth Dakin  <bdakin@apple.com>
218         &   Adam Roben  <aroben@apple.com>
219
220         Reviewed by Adam and Beth.
221
222         Initial cut at pushing Context Menus into WebCore. Nobody actually 
223         calls this code just yet.
224
225         * WebCore.exp:
226         * WebCore.xcodeproj/project.pbxproj:
227         * page/Chrome.cpp:
228         (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to 
229         call into addContextMenuItems on the UIDelegate.
230         * page/Chrome.h:
231         * page/ChromeClient.h:
232         * platform/ContextMenu.cpp: Added.
233         (WebCore::addDefaultItems):
234         (WebCore::ContextMenu::populate):
235         * platform/ContextMenu.h: Added.
236         (WebCore::):
237         (WebCore::ContextMenuItem::ContextMenuItem):
238         (WebCore::ContextMenu::ContextMenu):
239         (WebCore::ContextMenu::hitTestResult):
240         (WebCore::ContextMenu::platformMenuDescription):
241
242 2006-11-15  Adele Peterson  <adele@apple.com>
243
244         Reviewed by Hyatt.
245
246         - Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
247
248         * css/html4.css: Removed "-webkit-user-select: ignore" for labels.
249
250 2006-11-15  David Harrison  <harrison@apple.com>
251
252         Reviewed by Darin.
253
254         <rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
255
256         Test:
257         * manual-tests/keep_spelling_markers.html:
258         Updated to include checking for this bug.
259         
260         * bridge/mac/FrameMac.mm:
261         (WebCore::FrameMac::advanceToNextMisspelling):
262         it.advance() even when current string is a single space.
263
264 2006-11-15  Brady Eidson  <beidson@apple.com>
265
266         Reviewed by lamadio
267
268         Backing out macro expansion
269
270         * WebCore.xcodeproj/project.pbxproj:
271         * html/HTMLElement.cpp:
272         (WebCore::HTMLElement::isRecognizedTagName):
273         * ksvg2/scripts/make_names.pl:
274
275 2006-11-15  David Harrison  <harrison@apple.com>
276
277         Reviewed by Darin.
278
279         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
280
281         The remaining problem was the password fields would return their contents
282         even though they did not advertise that they could. Apparently, VoiceOver
283         does not read the ads.
284
285         * bridge/mac/WebCoreAXObject.mm:
286         (isPasswordFieldElement):
287         (-[WebCoreAXObject isPasswordField]):
288         (-[WebCoreAXObject textMarkerForVisiblePosition:]):
289         (-[WebCoreAXObject accessibilityAttributeValue:]):
290         (-[WebCoreAXObject doAXStringForRange:]):
291
292 2006-11-13  Lou Amadio  <lamadio@apple.com>
293
294         Reviewed by Darin Adler, Maciej Stachowiak
295
296         Cleanup: Expanded macros in generated files
297
298         * html/HTMLElement.cpp:
299         (WebCore::HTMLElement::isRecognizedTagName):
300         * ksvg2/scripts/make_names.pl:
301
302 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
303
304         Reviewed by Geoff.
305
306         Use Vector instead of DeprecatedPtrList.
307         
308         * editing/ApplyStyleCommand.cpp:
309         (WebCore::ApplyStyleCommand::applyBlockStyle):
310         * editing/BreakBlockquoteCommand.cpp:
311         * rendering/RenderFlow.cpp:
312         (WebCore::RenderFlow::paintOutline):
313
314 2006-11-15  Adam Roben  <aroben@apple.com>
315
316         Build fix.
317
318         * page/EventHandler.h:
319
320 2006-11-14  Beth Dakin  <bdakin@apple.com>
321
322         Reviewed by Geoff.
323
324         Move things off the bridge, and move sendContextMenuEvent() from 
325         EventHandlerMac to EventHandler.
326
327         * WebCore.exp:
328         * WebCore.xcodeproj/project.pbxproj:
329         * bridge/EditorClient.h:
330         * bridge/mac/WebCoreFrameBridge.h:
331         * editing/Editor.cpp:
332         (WebCore::Editor::selectWordBeforeMenuEvent):
333         (WebCore::Editor::clientIsEditable):
334         * editing/Editor.h:
335         * page/EventHandler.cpp:
336         (WebCore::EventHandler::sendContextMenuEvent):
337         * page/EventHandler.h:
338         * page/mac/EventHandlerMac.mm:
339
340 2006-11-14  Timothy Hatcher  <timothy@apple.com>
341
342         Reviewed by Harrison.
343
344         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
345
346         Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
347
348         * bridge/mac/WebCoreSettings.mm:
349         (-[WebCoreSettings setEditableLinkBehavior:]):
350         * html/HTMLAnchorElement.cpp:
351         (WebCore::HTMLAnchorElement::defaultEventHandler):
352         (WebCore::HTMLAnchorElement::setActive):
353         (WebCore::HTMLAnchorElement::isLiveLink):
354         * page/FrameView.cpp:
355         (WebCore::selectCursor):
356         * page/Settings.h:
357         (WebCore::Settings::):
358
359 2006-11-14  Mark Rowe  <bdash@webkit.org>
360
361         Reviewed by Oliver.
362
363         Build fix
364
365         * bindings/scripts/CodeGenerator.pm:
366
367 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
368
369         Turns out I wasn't forcing DWARF on the world at all, 
370         it's now the default!
371
372         * WebCore.xcodeproj/project.pbxproj:
373
374 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
375
376         I must stop trying to force DWARF on the world.
377         
378         * WebCore.xcodeproj/project.pbxproj:
379
380 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
381
382         Reviewed by harrison
383         
384         <rdar://problem/4806874>
385         Missing background image after paste
386         
387         * editing/markup.cpp:
388         (WebCore::createMarkup): If the body is fully selected, add a 
389         div with its CSS properties to the markup.  Migrated a use of 
390         enclosingBlockFlowElement to enclosingBlock to fix an infinite 
391         loop when pasting <div><input></div>.
392
393 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
394
395         Reviewed by Adam.
396
397         Add Undo/Redo to execCommand.
398         
399         * editing/Editor.cpp:
400         (WebCore::execRedo):
401         (WebCore::execUndo):
402         (WebCore::canRedo):
403         (WebCore::canUndo):
404         (WebCore::CommandEntry::):
405
406 2006-11-14  Darin Adler  <darin@apple.com>
407
408         Reviewed by Anders.
409
410         - created EventHandler class, moved event handling code from both
411           Frame and FrameView in there
412
413         - added ScrollTypes.h header so you can include the scroller-related
414           enums without all of Scrollbar.h
415
416         * page/EventHandler.cpp: Added.
417         * page/EventHandler.h: Added.
418         * page/mac/EventHandlerMac.mm: Added.
419
420         * platform/ScrollBarMode.h: Removed.
421         * platform/ScrollTypes.h: Added.
422
423         * WebCore.exp:
424         * WebCore.xcodeproj/project.pbxproj:
425         * bridge/mac/FrameMac.h:
426         * bridge/mac/FrameMac.mm:
427         (WebCore::FrameMac::FrameMac):
428         (WebCore::FrameMac::~FrameMac):
429         (WebCore::FrameMac::bridgeForWidget):
430         (WebCore::FrameMac::imageFromRect):
431         * bridge/mac/FrameViewMac.mm:
432         * bridge/mac/WebCoreFrameBridge.mm:
433         (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]):
434         (-[WebCoreFrameBridge nextKeyView]):
435         (-[WebCoreFrameBridge previousKeyView]):
436         (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
437         (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
438         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
439         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
440         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
441         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
442         (-[WebCoreFrameBridge dragSourceMovedTo:]):
443         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
444         * dom/Document.cpp:
445         (WebCore::Document::hoveredNodeDetached):
446         * dom/Element.h:
447         * dom/EventTargetNode.cpp:
448         (WebCore::EventTargetNode::defaultEventHandler):
449         * editing/SelectionController.cpp:
450         (WebCore::SelectionController::SelectionController):
451         * editing/SelectionController.h:
452         (WebCore::SelectionController::setCaretBlinkingSuspended):
453         (WebCore::SelectionController::isCaretBlinkingSuspended):
454         * html/HTMLAnchorElement.cpp:
455         (WebCore::HTMLAnchorElement::isKeyboardFocusable):
456         * html/HTMLFrameElementBase.cpp:
457         (WebCore::HTMLFrameElementBase::setFocus):
458         * html/HTMLFrameElementBase.h:
459         * html/HTMLGenericFormElement.cpp:
460         (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
461         * html/HTMLInputElement.cpp:
462         (WebCore::HTMLInputElement::defaultEventHandler):
463         * html/HTMLSelectElement.cpp:
464         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
465         * loader/FrameLoader.cpp:
466         (WebCore::FrameLoader::clear):
467         (WebCore::FrameLoader::open):
468
469         * page/Frame.cpp:
470         (WebCore::Frame::caretBlinkTimerFired):
471         (WebCore::Frame::frameForWidget):
472         (WebCore::Frame::eventHandler):
473         (WebCore::Frame::setProhibitsScrolling):
474         (WebCore::FramePrivate::FramePrivate):
475         * page/Frame.h:
476         * page/FramePrivate.h:
477         * page/FrameView.cpp:
478         (WebCore::FrameViewPrivate::FrameViewPrivate):
479         (WebCore::FrameViewPrivate::reset):
480         (WebCore::FrameView::FrameView):
481         (WebCore::FrameView::~FrameView):
482         (WebCore::FrameView::clear):
483         (WebCore::FrameView::adjustViewSize):
484         (WebCore::FrameView::addRepaintInfo):
485         (WebCore::FrameView::layout):
486         (WebCore::FrameView::scrollPointRecursively):
487         (WebCore::FrameView::setContentsPos):
488         (WebCore::FrameView::scheduleRelayoutOfSubtree):
489         (WebCore::FrameView::scheduleEvent):
490         (WebCore::FrameView::updateOverflowStatus):
491         (WebCore::FrameView::dispatchScheduledEvents):
492         (WebCore::FrameView::windowClipRectForLayer):
493         (WebCore::FrameView::handleMouseMoveEvent):
494         (WebCore::FrameView::handleMouseReleaseEvent):
495         * page/FrameView.h:
496         * page/PageState.cpp:
497         (WebCore::PageState::PageState):
498         (WebCore::PageState::restore):
499         * page/PageState.h:
500         * platform/ScrollBar.h:
501         * platform/ScrollView.h:
502         * platform/mac/ClipboardMac.mm:
503         * platform/mac/PopupMenuMac.mm:
504         (WebCore::PopupMenu::show):
505         * platform/mac/SliderMac.mm:
506         (-[WebCoreSlider becomeFirstResponder]):
507         (-[WebCoreSlider nextKeyView]):
508         (-[WebCoreSlider previousKeyView]):
509         (-[WebCoreSlider canBecomeKeyView]):
510         (Slider::focusPolicy):
511         * platform/mac/WebCoreTextField.mm:
512         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
513         (-[WebCoreTextFieldController setHasFocus:]):
514         (-[WebCoreSearchField nextKeyView]):
515         (-[WebCoreSearchField previousKeyView]):
516         (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
517         * platform/mac/WidgetMac.mm:
518         (WebCore::Widget::hasFocus):
519         (WebCore::Widget::clearFocus):
520         * rendering/RenderFrameSet.cpp:
521         (WebCore::RenderFrameSet::setResizing):
522         * rendering/RenderLayer.cpp:
523         (WebCore::RenderLayer::autoscroll):
524         (WebCore::RenderLayer::resize):
525         (WebCore::RenderLayer::updateOverflowStatus):
526         * rendering/RenderLayer.h:
527         * rendering/RenderListBox.cpp:
528         (WebCore::RenderListBox::autoscroll):
529         * rendering/RenderObject.cpp:
530         (WebCore::RenderObject::draggableNode):
531         (WebCore::RenderObject::destroy):
532         * rendering/RenderObject.h:
533         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
534         * rendering/RenderPartObject.cpp:
535         (WebCore::RenderPartObject::viewCleared):
536
537 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
538
539         Reviewed by Darin.
540
541         Let the editor client handle undo/redo.
542         
543         * WebCore.exp:
544         * WebCore.xcodeproj/project.pbxproj:
545         * bridge/EditorClient.h:
546         * bridge/mac/FrameMac.h:
547         * bridge/mac/FrameMac.mm:
548         (WebCore::FrameMac::canUndo):
549         (WebCore::FrameMac::canRedo):
550         * bridge/mac/WebCoreEditCommand.h: Removed.
551         * bridge/mac/WebCoreEditCommand.mm: Removed.
552         * bridge/mac/WebCoreFrameBridge.h:
553         * bridge/mac/WebCoreFrameBridge.mm:
554         * editing/Editor.cpp:
555         (WebCore::Editor::appliedEditing):
556         (WebCore::Editor::unappliedEditing):
557         (WebCore::Editor::reappliedEditing):
558         * editing/JSEditor.cpp:
559         * loader/FrameLoader.cpp:
560         (WebCore::FrameLoader::closeURL):
561         * page/Frame.cpp:
562         * page/Frame.h:
563         * rendering/RenderTextControl.cpp:
564         (WebCore::RenderTextControl::updateFromElement):
565
566 2006-11-14  Nikolas Zimmermann  <zimmermann@kde.org>
567
568         Reviewed and landed by Brady
569
570         Fix Qt/Linux build.
571
572         * ChangeLog:
573         * loader/qt/FrameLoaderQt.cpp:
574         (WebCore::FrameLoader::submitForm):
575         * platform/network/qt/ResourceHandleManager.cpp:
576         (WebCore::ResourceHandleManager::add):
577         * platform/qt/FrameQtClient.cpp:
578         (WebCore::FrameQtClientDefault::submitForm):
579         * platform/qt/FrameQtClient.h:
580
581 2006-11-14  Brady Eidson  <beidson@apple.com>
582
583         Reviewed by Anders
584
585         Cleanup of my patch last night and merging with aroben-style changes from this morning
586         (More ref-counted FormData stuff)
587
588         * html/HTMLFormElement.cpp:
589         (WebCore::HTMLFormElement::submit):
590         * loader/FrameLoader.cpp:
591         (WebCore::FrameLoader::submitForm):
592         * platform/network/ResourceHandle.cpp:
593         (WebCore::ResourceHandle::postData):
594         * platform/network/ResourceHandle.h:
595         * platform/network/cf/FormDataStreamCFNet.cpp:
596         (WebCore::setHTTPBody):
597         * platform/network/mac/FormDataStreamMac.h:
598         * platform/network/mac/FormDataStreamMac.mm:
599         (WebCore::getStreamFormDatas):
600         (WebCore::formCreate):
601         (WebCore::formFinalize):
602         (WebCore::setHTTPBody):
603         (WebCore::httpBodyFromStream):
604         * platform/network/mac/ResourceRequestMac.mm:
605         (WebCore::getResourceRequest):
606
607 2006-11-14  Rob Buis  <buis@kde.org>
608
609         Reviewed by Darin.
610
611         http://bugs.webkit.org/show_bug.cgi?id=11575
612         Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
613
614         Test: fast/css/css-imports.html
615
616         * css/CSSImportRule.cpp:
617         (WebCore::CSSImportRule::insertedIntoParent):
618         Fix the crash by testing for null pointer.
619
620 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
621
622         Reviewed by Tim H.
623
624         Test for http://bugs.webkit.org/show_bug.cgi?id=3387
625         Redundant keydown, keypress, keyup events sent for arrow keys
626
627         * manual-tests/arrow-key-events.html: Added.
628
629 2006-11-14  Darin Adler  <darin@apple.com>
630
631         Reviewed by Adam.
632
633         Fix up usages of FormData within CFNet loader code.
634
635         * platform/network/ResourceRequest.h:
636         (WebCore::ResourceRequest::httpBody):
637         * platform/network/cf/FormDataStreamCFNet.cpp:
638         (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the
639         streamFormDatas HashMap.
640         (WebCore::formCreate):
641         (WebCore::formFinalize): Removed delete because the remove() will deref
642         and delete if necessary.
643         (WebCore::setHTTPBody): Changed parameter to PassRefPtr.
644         (WebCore::httpBodyFromStream):
645         * platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
646         * platform/network/cf/ResourceRequestCFNet.cpp:
647         (WebCore::getResourceRequest):
648
649 2006-11-14  Greg Jackson  <gjspanner@gmail.com>
650
651         Reviewed by Darin.
652
653         Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
654         rather than overriding it based on platform detection.
655
656         * bindings/js/kjs_navigator.cpp:
657
658 2006-11-13  Brady Eidson  <beidson@apple.com>
659
660         Reviewed by Maciej
661
662         Made FormData Shared, and pass it around as such.
663
664         * WebCore.xcodeproj/project.pbxproj: Reordered some items
665         * html/HTMLFormElement.cpp:
666         (WebCore::HTMLFormElement::formData):
667         (WebCore::HTMLFormElement::submit):
668         * html/HTMLFormElement.h:
669         * loader/FrameLoader.cpp:
670         (WebCore::FormSubmission::FormSubmission):
671         (WebCore::FrameLoader::submitForm):
672         * loader/FrameLoader.h:
673         * loader/mac/FrameLoaderMac.mm:
674         (WebCore::FrameLoader::post):
675         (WebCore::FrameLoader::loadResourceSynchronously):
676         * loader/mac/SubresourceLoaderMac.mm:
677         (WebCore::SubresourceLoader::create):
678         * platform/network/FormData.h: Made FormData shared
679         * platform/network/ResourceHandle.h:
680         * platform/network/ResourceHandle.cpp:
681         (WebCore::ResourceHandle::postData): 
682         * platform/network/ResourceRequest.h:
683         (WebCore::ResourceRequest::httpBody):
684         (WebCore::ResourceRequest::setHTTPBody): 
685         * platform/network/mac/ResourceRequestMac.mm:
686         (WebCore::getResourceRequest):
687         (WebCore::nsURLRequest): 
688
689         * platform/network/mac/FormDataStreamMac.h:
690         * platform/network/mac/FormDataStreamMac.mm:
691         (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s
692         (WebCore::formCreate):
693         (WebCore::formFinalize):
694         (WebCore::setHTTPBody):
695         (WebCore::httpBodyFromStream):
696
697         * xml/xmlhttprequest.cpp:
698         (WebCore::XMLHttpRequest::send):
699
700 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
701
702         Reviewed by harrison
703         
704         <rdar://problem/4828264>
705         In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)
706         
707         The start of the selection is in an editable area, and the end is in an 
708         input field inside that editable area.  The code that should pull the end
709         of such a selection outside the input field didn't escape shadow nodes,
710         it would leave a dangling end, causing the crash in toRange.
711         
712         * editing/Selection.cpp:
713         (WebCore::Selection::adjustForEditableContent):  Added an ASSERT and a fixup
714         to prevent crashes like this in future Release builds.
715         * editing/htmlediting.cpp:
716         (WebCore::firstEditablePositionAfterPositionInRoot): Let this function 
717         escape shadow nodes.  We might eventually push this code down into 
718         next/previous{VisuallyDistinct}Canditate.
719         (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
720
721 2006-11-13  Justin Garcia  <justin.garcia@apple.com>
722
723         Reviewed by darin
724         
725         * editing/DeleteSelectionCommand.cpp:
726         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
727         * editing/Editor.cpp:
728         (WebCore::Editor::appliedEditing):
729         * editing/Editor.h:
730         (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
731
732 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
733
734         Reviewed by Oliver
735         
736         <rdar://problem/4820026>
737         copy/paste of news.google.com yields text from hidden select element options
738
739         We were adding descendants of unrendered select elements. 
740
741         * editing/markup.cpp:
742         (WebCore::createMarkup): Don't traverse into nodes without renderers, unless 
743         they are grandfathered in by a rendered select element.
744         
745 2006-11-12  Simon Hausmann  <hausmann@kde.org>
746
747         Reviewed by Sam Weinig.
748
749         Fix Qt build. Missing AbstractShared implementation.
750         http://bugs.webkit.org/show_bug.cgi?id=11581
751
752         * loader/qt/FrameLoaderClientQt.cpp:
753         (WebCore::FrameLoaderClientQt::ref):
754         (WebCore::FrameLoaderClientQt::deref):
755         * loader/qt/FrameLoaderClientQt.h:
756         * platform/qt/ChromeClientQt.cpp:
757         (WebCore::ChromeClientQt::ref):
758         (WebCore::ChromeClientQt::deref):
759         * platform/qt/ChromeClientQt.h:
760         * platform/qt/EditorClientQt.cpp:
761         (WebCore::EditorClientQt::ref):
762         (WebCore::EditorClientQt::deref):
763         * platform/qt/EditorClientQt.h:
764
765 2006-11-13  Mark Rowe  <bdash@webkit.org>
766
767         Reviewed by Mitz.
768
769         Fix some Linux/Gdk build issues noted by Alp Toker.
770
771         * Projects/gdk/webcore-gdk.bkl:
772         * WebCoreSources.bkl:
773         * platform/graphics/gdk/ImageGdk.cpp:
774         (WebCore::Image::loadPlatformResource):
775
776 2006-11-12  Brady Eidson <beidson@apple.com>
777
778         Reviewed by Anders
779
780         Logging channel plumbing for future work
781
782         * platform/Logging.cpp:
783         (WebCore::):
784         * platform/Logging.h:
785         * platform/mac/LoggingMac.mm:
786         (WebCore::InitializeLoggingChannelsIfNecessary):
787
788 2006-11-12  Mark Rowe  <bdash@webkit.org>
789
790         Reviewed by Mitz.
791
792         Linux/Gdk compilation fixes, and bakefile cleanups.  Based on patches by
793         Alp Toker.
794
795         * Projects/gdk/webcore-gdk.bkl:
796         * WebCoreSources.bkl:
797         * page/PageState.cpp:
798         * platform/gdk/ChromeClientGdk.h:
799         (WebCore::ChromeClientGdk::ref):
800         (WebCore::ChromeClientGdk::deref):
801         * platform/gdk/FrameGdk.cpp:
802         (WebCore::FrameGdkClientDefault::openURL):
803         (WebCore::FrameGdkClientDefault::didReceiveData):
804         (WebCore::FrameGdkClientDefault::receivedAllData):
805         (WebCore::FrameGdk::FrameGdk):
806         (WebCore::FrameGdk::~FrameGdk):
807         * platform/gdk/FrameGdk.h:
808         * platform/gdk/KeyEventGdk.cpp:
809         (WebCore::keyIdentifierForGdkKeyCode):
810         * platform/gdk/ScreenClientGdk.h: Removed.
811         * platform/gdk/TemporaryLinkStubs.cpp:
812         (FrameGdk::canPaste):
813         (FrameGdk::originalRequestURL):
814         (TextField::TextField):
815         * platform/network/gdk/ResourceHandleManager.cpp:
816         (WebCore::ResourceHandleManager::downloadTimerCallback):
817         (WebCore::ResourceHandleManager::add):
818         (WebCore::ResourceHandleManager::cancel):
819         * webcore-base.bkl:
820
821 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
822
823         Reviewed by Maciej Stachowiak.
824         
825         - Fixed loader crash by clarifying ownership of WebKit client objects. 
826         WebCore objects own their WebKit clients, and ref and deref through 
827         virtual methods, leaving WebKit free to use whatever client / reference-counting 
828         implementation it likes.
829         
830         * WebCore.exp:
831         * WebCore.xcodeproj/project.pbxproj:
832         * bridge/EditorClient.h: Fixed up function prototypes for style.
833         * loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
834         was to implement an alternative ownership model.
835         (WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
836         (WebCore::FrameLoader::setClient): This function now takes ownership
837         (WebCore::FrameLoader::client):
838         * loader/FrameLoader.h:
839         * loader/FrameLoaderClient.h:
840         * page/ChromeClient.h:
841         * platform/AbstractShared.h: Added. This is the virtual function-based refcounting
842         complement to Shared.
843         (WebCore::AbstractShared::~AbstractShared):
844
845 2006-11-11  George Staikos  <staikos@kde.org>
846
847         Reviewed by Maciej.
848
849         Fix uninitialized variable.
850
851         * rendering/RenderStyle.h:
852
853 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
854
855         Reviewed/landed by Adam.
856
857         Complete cleanup of the CMakeLists.txt.
858         Now all files to be built are sorted in alphabetic order.
859
860         General style cleanup, remove all tabs etc.
861
862         * CMakeLists.txt:
863
864 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
865
866         Reviewed by Maciej Stachowiak.
867         
868         Added missing initializer to ResourceRequest -- fixes some loader crashes
869         due to assuming a request always has a non-null httpMethod.
870
871         * platform/network/ResourceRequest.h:
872         (WebCore::ResourceRequest::ResourceRequest):
873
874 2006-11-11  Brady Eidson <beidson@apple.com>
875
876         Reviewed by Maciej
877
878         Fixed header guard
879
880         * loader/FrameLoaderClient.h:
881
882 2006-11-11  Darin Adler  <darin@apple.com>
883
884         - attempt to fix Qt build
885
886         * platform/qt/CursorQt.cpp:
887         (WebCore::verticalTextCursor): Added. Just returns pointer cursor.
888         (WebCore::cellCursor): Ditto.
889         (WebCore::contextMenuCursor): Ditto.
890
891 2006-11-11  Rob Buis  <buis@kde.org>
892
893         Reviewed by hyatt.
894
895         http://bugs.webkit.org/show_bug.cgi?id=10893
896         InsertRule can not handle @import statements
897
898         Allow @import as part of a css rule.
899
900         * css/CSSGrammar.y:
901         * css/CSSImportRule.cpp:
902         (WebCore::CSSImportRule::insertedIntoParent):
903         * css/CSSStyleSheet.cpp:
904         (WebCore::CSSStyleSheet::CSSStyleSheet):
905         (WebCore::CSSStyleSheet::checkLoaded):
906         * css/CSSStyleSheet.h:
907         (WebCore::CSSStyleSheet::loadCompleted):
908
909 2006-11-11  Alexey Proskuryakov  <ap@webkit.org>
910
911         Attempt to fix Qt build.
912
913         * CMakeLists.txt: PathQt.cpp is in graphics/qt now.
914
915 2006-11-11  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>
916
917         Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
918
919         [CSS 3] support for vertical-text, cell and context-menu cursors
920         http://bugs.webkit.org/show_bug.cgi?id=11494
921
922         * Resources/cellCursor.png: Added.
923         * Resources/contextMenuCursor.png: Added.
924         * Resources/verticalTextCursor.png: Added.
925         * WebCore.xcodeproj/project.pbxproj:
926         * css/CSSComputedStyleDeclaration.cpp:
927         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
928         * css/CSSValueKeywords.in:
929         * manual-tests/cursor.html:
930         * page/FrameView.cpp:
931         (WebCore::selectCursor):
932         * platform/Cursor.h:
933         * platform/mac/CursorMac.mm:
934         (WebCore::verticalTextCursor):
935         (WebCore::cellCursor):
936         (WebCore::contextMenuCursor):
937         * rendering/RenderStyle.h:
938         (WebCore::):
939
940 2006-11-11  Nikolas Zimmermann  <zimmermann@kde.org>
941
942         Reviewed by aroben and ap, landed by ap.
943
944         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
945
946         Group graphics related files in platform/graphics.
947         Move certain files from certain subdirectories
948         into platform/graphics/{win,mac,cg,gdk,qt}
949
950         * CMakeLists.txt:
951         * WebCore.xcodeproj/project.pbxproj:
952         * platform/AffineTransform.cpp: Removed.
953         * platform/AffineTransform.h: Removed.
954         * platform/Color.cpp: Removed.
955         * platform/Color.h: Removed.
956         * platform/FloatPoint.cpp: Removed.
957         * platform/FloatPoint.h: Removed.
958         * platform/FloatRect.cpp: Removed.
959         * platform/FloatRect.h: Removed.
960         * platform/FloatSize.cpp: Removed.
961         * platform/FloatSize.h: Removed.
962         * platform/Icon.h: Removed.
963         * platform/Image.cpp: Removed.
964         * platform/Image.h: Removed.
965         * platform/ImageSource.h: Removed.
966         * platform/IntPoint.h: Removed.
967         * platform/IntRect.cpp: Removed.
968         * platform/IntRect.h: Removed.
969         * platform/IntSize.h: Removed.
970         * platform/IntSizeHash.h: Removed.
971         * platform/Path.cpp: Removed.
972         * platform/Path.h: Removed.
973         * platform/Pen.cpp: Removed.
974         * platform/Pen.h: Removed.
975         * platform/cairo/AffineTransformCairo.cpp: Removed.
976         * platform/cairo/GraphicsContextCairo.cpp: Removed.
977         * platform/cairo/ImageCairo.cpp: Removed.
978         * platform/cairo/ImageSourceCairo.cpp: Removed.
979         * platform/cairo/cairo/AUTHORS: Removed.
980         * platform/cairo/cairo/COPYING: Removed.
981         * platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
982         * platform/cairo/cairo/COPYING-MPL-1.1: Removed.
983         * platform/cairo/cairo/INSTALL: Removed.
984         * platform/cairo/cairo/NEWS: Removed.
985         * platform/cairo/cairo/README: Removed.
986         * platform/cairo/cairo/TODO: Removed.
987         * platform/cairo/cairo/src/Makefile.in: Removed.
988         * platform/cairo/cairo/src/cairo-arc-private.h: Removed.
989         * platform/cairo/cairo/src/cairo-arc.c: Removed.
990         * platform/cairo/cairo/src/cairo-array.c: Removed.
991         * platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
992         * platform/cairo/cairo/src/cairo-atsui.h: Removed.
993         * platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
994         * platform/cairo/cairo/src/cairo-beos.h: Removed.
995         * platform/cairo/cairo/src/cairo-cache-private.h: Removed.
996         * platform/cairo/cairo/src/cairo-cache.c: Removed.
997         * platform/cairo/cairo/src/cairo-clip-private.h: Removed.
998         * platform/cairo/cairo/src/cairo-clip.c: Removed.
999         * platform/cairo/cairo/src/cairo-color.c: Removed.
1000         * platform/cairo/cairo/src/cairo-debug.c: Removed.
1001         * platform/cairo/cairo/src/cairo-debug.h: Removed.
1002         * platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
1003         * platform/cairo/cairo/src/cairo-directfb.h: Removed.
1004         * platform/cairo/cairo/src/cairo-features.h: Removed.
1005         * platform/cairo/cairo/src/cairo-features.h.in: Removed.
1006         * platform/cairo/cairo/src/cairo-fixed.c: Removed.
1007         * platform/cairo/cairo/src/cairo-font-options.c: Removed.
1008         * platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
1009         * platform/cairo/cairo/src/cairo-font-subset.c: Removed.
1010         * platform/cairo/cairo/src/cairo-font.c: Removed.
1011         * platform/cairo/cairo/src/cairo-ft-font.c: Removed.
1012         * platform/cairo/cairo/src/cairo-ft-private.h: Removed.
1013         * platform/cairo/cairo/src/cairo-ft.h: Removed.
1014         * platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
1015         * platform/cairo/cairo/src/cairo-glitz.h: Removed.
1016         * platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
1017         * platform/cairo/cairo/src/cairo-gstate.c: Removed.
1018         * platform/cairo/cairo/src/cairo-hash-private.h: Removed.
1019         * platform/cairo/cairo/src/cairo-hash.c: Removed.
1020         * platform/cairo/cairo/src/cairo-hull.c: Removed.
1021         * platform/cairo/cairo/src/cairo-image-surface.c: Removed.
1022         * platform/cairo/cairo/src/cairo-matrix.c: Removed.
1023         * platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
1024         * platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
1025         * platform/cairo/cairo/src/cairo-output-stream.c: Removed.
1026         * platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
1027         * platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
1028         * platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
1029         * platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
1030         * platform/cairo/cairo/src/cairo-path-data.c: Removed.
1031         * platform/cairo/cairo/src/cairo-path-fill.c: Removed.
1032         * platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
1033         * platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
1034         * platform/cairo/cairo/src/cairo-path.c: Removed.
1035         * platform/cairo/cairo/src/cairo-pattern.c: Removed.
1036         * platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
1037         * platform/cairo/cairo/src/cairo-pdf.h: Removed.
1038         * platform/cairo/cairo/src/cairo-pen.c: Removed.
1039         * platform/cairo/cairo/src/cairo-platform.h: Removed.
1040         * platform/cairo/cairo/src/cairo-png.c: Removed.
1041         * platform/cairo/cairo/src/cairo-polygon.c: Removed.
1042         * platform/cairo/cairo/src/cairo-private.h: Removed.
1043         * platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
1044         * platform/cairo/cairo/src/cairo-ps.h: Removed.
1045         * platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
1046         * platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
1047         * platform/cairo/cairo/src/cairo-quartz.h: Removed.
1048         * platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
1049         * platform/cairo/cairo/src/cairo-quartz2.h: Removed.
1050         * platform/cairo/cairo/src/cairo-region.c: Removed.
1051         * platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
1052         * platform/cairo/cairo/src/cairo-slope.c: Removed.
1053         * platform/cairo/cairo/src/cairo-spline.c: Removed.
1054         * platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
1055         * platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
1056         * platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
1057         * platform/cairo/cairo/src/cairo-surface.c: Removed.
1058         * platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
1059         * platform/cairo/cairo/src/cairo-svg.h: Removed.
1060         * platform/cairo/cairo/src/cairo-traps.c: Removed.
1061         * platform/cairo/cairo/src/cairo-unicode.c: Removed.
1062         * platform/cairo/cairo/src/cairo-wideint.c: Removed.
1063         * platform/cairo/cairo/src/cairo-wideint.h: Removed.
1064         * platform/cairo/cairo/src/cairo-win32-font.c: Removed.
1065         * platform/cairo/cairo/src/cairo-win32-private.h: Removed.
1066         * platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
1067         * platform/cairo/cairo/src/cairo-win32.h: Removed.
1068         * platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
1069         * platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
1070         * platform/cairo/cairo/src/cairo-xcb.h: Removed.
1071         * platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
1072         * platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
1073         * platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
1074         * platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
1075         * platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
1076         * platform/cairo/cairo/src/cairo-xlib.h: Removed.
1077         * platform/cairo/cairo/src/cairo.c: Removed.
1078         * platform/cairo/cairo/src/cairo.h: Removed.
1079         * platform/cairo/cairo/src/cairoint.h: Removed.
1080         * platform/cairo/cairo/src/test-fallback-surface.c: Removed.
1081         * platform/cairo/cairo/src/test-fallback-surface.h: Removed.
1082         * platform/cairo/cairo/src/test-meta-surface.c: Removed.
1083         * platform/cairo/cairo/src/test-meta-surface.h: Removed.
1084         * platform/cairo/cairo/src/test-paginated-surface.c: Removed.
1085         * platform/cairo/cairo/src/test-paginated-surface.h: Removed.
1086         * platform/cairo/pixman/AUTHORS: Removed.
1087         * platform/cairo/pixman/COPYING: Removed.
1088         * platform/cairo/pixman/README: Removed.
1089         * platform/cairo/pixman/src/Makefile.in: Removed.
1090         * platform/cairo/pixman/src/fbcompose.c: Removed.
1091         * platform/cairo/pixman/src/fbedge.c: Removed.
1092         * platform/cairo/pixman/src/fbedgeimp.h: Removed.
1093         * platform/cairo/pixman/src/fbmmx.c: Removed.
1094         * platform/cairo/pixman/src/fbmmx.h: Removed.
1095         * platform/cairo/pixman/src/fbpict.c: Removed.
1096         * platform/cairo/pixman/src/fbpict.h: Removed.
1097         * platform/cairo/pixman/src/fbtrap.c: Removed.
1098         * platform/cairo/pixman/src/icblt.c: Removed.
1099         * platform/cairo/pixman/src/icbltone.c: Removed.
1100         * platform/cairo/pixman/src/iccolor.c: Removed.
1101         * platform/cairo/pixman/src/icformat.c: Removed.
1102         * platform/cairo/pixman/src/icimage.c: Removed.
1103         * platform/cairo/pixman/src/icimage.h: Removed.
1104         * platform/cairo/pixman/src/icint.h: Removed.
1105         * platform/cairo/pixman/src/icpixels.c: Removed.
1106         * platform/cairo/pixman/src/icrect.c: Removed.
1107         * platform/cairo/pixman/src/icrop.h: Removed.
1108         * platform/cairo/pixman/src/icstipple.c: Removed.
1109         * platform/cairo/pixman/src/ictransform.c: Removed.
1110         * platform/cairo/pixman/src/ictrap.c: Removed.
1111         * platform/cairo/pixman/src/ictri.c: Removed.
1112         * platform/cairo/pixman/src/icutil.c: Removed.
1113         * platform/cairo/pixman/src/pixman-remap.h: Removed.
1114         * platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
1115         * platform/cairo/pixman/src/pixman.h: Removed.
1116         * platform/cairo/pixman/src/pixregion.c: Removed.
1117         * platform/cairo/pixman/src/pixregionint.h: Removed.
1118         * platform/cairo/pixman/src/renderedge.c: Removed.
1119         * platform/cairo/pixman/src/renderedge.h: Removed.
1120         * platform/cairo/pixman/src/slim_internal.h: Removed.
1121         * platform/cairo/rgb24-hacks.txt: Removed.
1122         * platform/cairo/scale-removal.txt: Removed.
1123         * platform/cg/AffineTransformCG.cpp: Removed.
1124         * platform/cg/FloatPointCG.cpp: Removed.
1125         * platform/cg/FloatRectCG.cpp: Removed.
1126         * platform/cg/FloatSizeCG.cpp: Removed.
1127         * platform/cg/GraphicsContextCG.cpp: Removed.
1128         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
1129         * platform/cg/ImageCG.cpp: Removed.
1130         * platform/cg/ImageSourceCG.cpp: Removed.
1131         * platform/cg/IntPointCG.cpp: Removed.
1132         * platform/cg/IntRectCG.cpp: Removed.
1133         * platform/cg/IntSizeCG.cpp: Removed.
1134         * platform/cg/PDFDocumentImage.cpp: Removed.
1135         * platform/cg/PDFDocumentImage.h: Removed.
1136         * platform/cg/PathCG.cpp: Removed.
1137         * platform/gdk/ImageGdk.cpp: Removed.
1138         * platform/mac/ColorMac.mm: Removed.
1139         * platform/mac/FloatPointMac.mm: Removed.
1140         * platform/mac/FloatRectMac.mm: Removed.
1141         * platform/mac/FloatSizeMac.mm: Removed.
1142         * platform/mac/GraphicsContextMac.mm:
1143         * platform/mac/IconMac.mm: Removed.
1144         * platform/mac/ImageMac.mm: Removed.
1145         * platform/mac/IntPointMac.mm: Removed.
1146         * platform/mac/IntRectMac.mm: Removed.
1147         * platform/mac/IntSizeMac.mm: Removed.
1148         * platform/qt/AffineTransformQt.cpp: Removed.
1149         * platform/qt/ColorQt.cpp: Removed.
1150         * platform/qt/FloatPointQt.cpp: Removed.
1151         * platform/qt/FloatRectQt.cpp: Removed.
1152         * platform/qt/IconQt.cpp: Removed.
1153         * platform/qt/ImageQt.cpp: Removed.
1154         * platform/qt/ImageSourceQt.cpp: Removed.
1155         * platform/qt/IntPointQt.cpp: Removed.
1156         * platform/qt/IntRectQt.cpp: Removed.
1157         * platform/qt/IntSizeQt.cpp: Removed.
1158         * platform/qt/PathQt.cpp: Removed.
1159         * platform/win/ImageWin.cpp: Removed.
1160         * platform/win/IntPointWin.cpp: Removed.
1161         * platform/win/IntRectWin.cpp: Removed.
1162         * platform/win/IntSizeWin.cpp: Removed.
1163
1164 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
1165
1166         Reviewed by hyatt.
1167
1168         A layout test was added when this bug was fixed, so none needed now.
1169         
1170         Cleanup after:
1171         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
1172         http://bugs.webkit.org/show_bug.cgi?id=11570
1173         
1174         * rendering/RenderStyle.h:
1175         (WebCore::RenderStyle::isSpace): Removed.
1176         * rendering/RenderText.cpp:
1177         (WebCore::isSpace): Added.
1178         (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
1179
1180 2006-11-11  Graham Dennis  <graham.dennis@gmail.com>
1181
1182         Reviewed by mitz.
1183         
1184         REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
1185         http://bugs.webkit.org/show_bug.cgi?id=11570
1186
1187         * rendering/RenderStyle.h:
1188         (WebCore::RenderStyle::isSpace): Added.
1189         * rendering/RenderText.cpp:
1190         (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, 
1191         treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'
1192
1193 2006-11-10  Zalan Bujtas <zalan.bujtas@nokia.com>
1194
1195         Reviewed by Maciej.
1196
1197         Added basic types for symbian platform.
1198         http://bugs.webkit.org/show_bug.cgi?id=11540
1199
1200         * config.h:
1201         * platform/AtomicString.h:
1202         (WebCore::AtomicString::AtomicString):
1203         (WebCore::AtomicString::operator TPtrC):
1204         * platform/DeprecatedString.cpp:
1205         (WebCore::initializeHandleNodeBlock):
1206         * platform/DeprecatedString.h: char _internalBuffer has to be in front of
1207           the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with
1208           bitfields and breaks byte aligment
1209         * platform/FloatPoint.h:
1210         * platform/FloatRect.h:
1211         * platform/IntPoint.h:
1212         * platform/IntRect.h:
1213         * platform/IntSize.h:
1214         * platform/PlatformString.h:
1215         (WebCore::String::operator TPtrC):
1216         (WebCore::String::des):
1217         * platform/StringImpl.h:
1218         * platform/symbian/DeprecatedStringSymbian.cpp: Added.
1219         (WebCore::DeprecatedString::setBufferFromDes):
1220         (WebCore::DeprecatedString::fromDes):
1221         (WebCore::DeprecatedString::des):
1222         (WebCore::DeprecatedString::des8):
1223         * platform/symbian/FloatPointSymbian.cpp: Added.
1224         (WebCore::FloatPoint::FloatPoint):
1225         (WebCore::FloatPoint::operator TPoint):
1226         * platform/symbian/FloatRectSymbian.cpp: Added.
1227         (WebCore::FloatRect::FloatRect):
1228         (WebCore::FloatRect::operator TRect):
1229         (WebCore::FloatRect::rect):
1230         * platform/symbian/IntPointSymbian.cpp: Added.
1231         (WebCore::IntPoint::IntPoint):
1232         (WebCore::IntPoint::operator TPoint):
1233         * platform/symbian/IntRectSymbian.cpp: Added.
1234         (WebCore::IntRect::IntRect):
1235         (WebCore::IntRect::operator TRect):
1236         (WebCore::IntRect::Rect):
1237         * platform/symbian/IntSizeSymbian.cpp: Added.
1238         (WebCore::IntSize::IntSize):
1239         (WebCore::IntSize::operator TSize):
1240         * platform/symbian/StringImplSymbian.cpp: Added.
1241         (WebCore::StringImpl::StringImpl):
1242         (WebCore::StringImpl::des):
1243         * platform/symbian/StringSymbian.cpp: Added.
1244         (WebCore::String::String):
1245
1246 2006-11-10  Zack Rusin  <zack@kde.org>
1247
1248         Reviewed by Anders.
1249
1250         Adjust to the changes Brady made in the Qt code.
1251
1252         * loader/qt/FrameLoaderClientQt.cpp:
1253         (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
1254         * loader/qt/FrameLoaderClientQt.h:
1255
1256 2006-11-10  Justin Garcia  <justin.garcia@apple.com>
1257
1258         Reviewed by harrison
1259         
1260         <rdar://problem/4069359>
1261         Deleting hyperlink text, then typing uses link typing style but loses the link itself
1262         
1263         The removed anchor element needs to stick around temporarily, in the same way
1264         that the typing style hangs off the caret until the user moves it.  Also text
1265         insertion around anchors didn't match TextEdit.
1266
1267         * editing/DeleteSelectionCommand.cpp:
1268         (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added.
1269         (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
1270         * editing/DeleteSelectionCommand.h:
1271         * editing/EditCommand.cpp:
1272         (WebCore::EditCommand::apply): Clear the removed anchor after any top level
1273         editing command that doesn't preserve the typing style (matches TextEdit).
1274         * editing/Editor.cpp:
1275         (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call 
1276         setSelection with a message telling it to clear the typing style 
1277         (and the saved anchor) here.  Save/restore the saved anchor because of this.
1278         * editing/Editor.h:
1279         (WebCore::Editor::removedAnchor): Getter.
1280         (WebCore::Editor::setRemovedAnchor): Setter.
1281         * editing/InsertTextCommand.cpp:
1282         (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor
1283         if one exists.
1284         * editing/SelectionController.cpp:
1285         (WebCore::SelectionController::setSelection): Clear the removed anchor whenever
1286         we make a selection change that clears the typing style.
1287         (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
1288         * editing/htmlediting.cpp:
1289         (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and
1290         made some changes to match TextEdit's behavior.  First, insert content
1291         inside the anchor when the caret is after it, unless the caret is at the
1292         end of the document, or if the caret is before it and at the start of a 
1293         paragraph.
1294
1295 === Safari-521.30 ===
1296
1297 2006-11-10  Timothy Hatcher  <timothy@apple.com>
1298
1299         Reviewed by Hyatt.
1300
1301         Check for BHIDDEN in isVisible() also.
1302
1303         * rendering/RenderStyle.h:
1304         (WebCore::BorderValue::isVisible):
1305
1306 2006-11-10  Timothy Hatcher  <timothy@apple.com>
1307
1308         Reviewed by Adam.
1309
1310         <rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders
1311
1312         Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().
1313
1314         * editing/DeleteButtonController.cpp:
1315         (WebCore::isDeletableElement):
1316         * rendering/RenderStyle.h:
1317         (WebCore::BorderValue::isVisible):
1318
1319 2006-11-10  Adam Roben  <aroben@apple.com>
1320
1321         Rubberstamped by Anders.
1322
1323         Back out some accidentally-committed changes from r17711.
1324
1325         * page/Frame.cpp:
1326         (WebCore::Frame::command):
1327         (WebCore::FramePrivate::FramePrivate):
1328         * page/Frame.h:
1329         * page/FramePrivate.h:
1330
1331 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1332
1333         Reviewed by Geoff.
1334
1335         Add more commands, make toggleBold and toggleItalic executable commands.
1336
1337         * WebCore.exp:
1338         * editing/Editor.cpp:
1339         (WebCore::execCopy):
1340         (WebCore::execCut):
1341         (WebCore::execDelete):
1342         (WebCore::execForwardDelete):
1343         (WebCore::execPaste):
1344         (WebCore::execSelectAll):
1345         (WebCore::execToggleBold):
1346         (WebCore::execToggleItalic):
1347         (WebCore::enabled):
1348         (WebCore::canPaste):
1349         (WebCore::hasEditableSelection):
1350         (WebCore::hasEditableRangeSelection):
1351         (WebCore::hasRangeSelection):
1352         (WebCore::hasRichlyEditableSelection):
1353         (WebCore::CommandEntry::):
1354         * editing/Editor.h:
1355
1356 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
1357
1358         Reviewed by Maciej, Geoff.
1359
1360         Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
1361         the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.
1362
1363         * WebCore.exp:
1364         * bridge/mac/WebCoreFrameBridge.h:
1365         * bridge/mac/WebCoreFrameBridge.mm:
1366         * editing/Editor.cpp:
1367         (WebCore::execMoveBackward):
1368         (WebCore::execMoveBackwardAndModifySelection):
1369         (WebCore::execMoveDown):
1370         (WebCore::execMoveDownAndModifySelection):
1371         (WebCore::execMoveForward):
1372         (WebCore::execMoveForwardAndModifySelection):
1373         (WebCore::execMoveLeft):
1374         (WebCore::execMoveLeftAndModifySelection):
1375         (WebCore::execMoveRight):
1376         (WebCore::execMoveRightAndModifySelection):
1377         (WebCore::execMoveToBeginningOfDocument):
1378         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
1379         (WebCore::execMoveToBeginningOfSentence):
1380         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
1381         (WebCore::execMoveToBeginningOfLine):
1382         (WebCore::execMoveToBeginningOfLineAndModifySelection):
1383         (WebCore::execMoveToBeginningOfParagraph):
1384         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
1385         (WebCore::execMoveToEndOfDocument):
1386         (WebCore::execMoveToEndOfDocumentAndModifySelection):
1387         (WebCore::execMoveToEndOfSentence):
1388         (WebCore::execMoveToEndOfSentenceAndModifySelection):
1389         (WebCore::execMoveToEndOfLine):
1390         (WebCore::execMoveToEndOfLineAndModifySelection):
1391         (WebCore::execMoveToEndOfParagraph):
1392         (WebCore::execMoveToEndOfParagraphAndModifySelection):
1393         (WebCore::execMoveParagraphBackwardAndModifySelection):
1394         (WebCore::execMoveParagraphForwardAndModifySelection):
1395         (WebCore::execMoveUp):
1396         (WebCore::execMoveUpAndModifySelection):
1397         (WebCore::execMoveWordBackward):
1398         (WebCore::execMoveWordBackwardAndModifySelection):
1399         (WebCore::execMoveWordForward):
1400         (WebCore::execMoveWordForwardAndModifySelection):
1401         (WebCore::execMoveWordLeft):
1402         (WebCore::execMoveWordLeftAndModifySelection):
1403         (WebCore::execMoveWordRight):
1404         (WebCore::execMoveWordRightAndModifySelection):
1405         (WebCore::enabledAnySelection):
1406         (WebCore::createCommandMap):
1407         (WebCore::CommandEntry::):
1408         (WebCore::Editor::execCommand):
1409         * editing/Editor.h:
1410
1411 2006-11-10  Brady Eidson  <beidson@apple.com>
1412
1413         Reviewed by Darin
1414
1415         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
1416
1417         * WebCore.exp:
1418         * WebCore.xcodeproj/project.pbxproj:
1419         * bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
1420         * bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
1421         * loader/FrameLoaderClient.h:
1422         * loader/icon/IconDatabase.cpp:
1423         (WebCore::IconDatabase::sharedIconDatabase):
1424         (WebCore::IconDatabase::~IconDatabase):
1425         * loader/icon/IconDatabase.h:
1426         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
1427         (WebCore::IconDatabase::enabled):
1428         * loader/icon/IconLoader.cpp:
1429         (WebCore::IconLoader::finishLoading):
1430         * loader/mac/FrameLoaderMac.mm:
1431
1432 2006-11-10  Zack Rusin  <zack@kde.org>
1433
1434         Reviewed and landed by Anders.
1435
1436         Adjust platform Qt/KDE code to the recent loader
1437         changes. 
1438
1439         * CMakeLists.txt:
1440         * loader/DocumentLoader.h:
1441         * loader/FrameLoader.cpp:
1442         (WebCore::FrameLoader::createEmptyDocument):
1443         * loader/FrameLoader.h:
1444         * loader/FrameLoaderClient.h:
1445         * loader/qt/DocumentLoaderQt.cpp: Added.
1446         (WebCore::canonicalizedTitle):
1447         (WebCore::DocumentLoader::DocumentLoader):
1448         (WebCore::DocumentLoader::frameLoader):
1449         (WebCore::DocumentLoader::~DocumentLoader):
1450         (WebCore::DocumentLoader::URL):
1451         (WebCore::DocumentLoader::unreachableURL):
1452         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
1453         (WebCore::DocumentLoader::isStopping):
1454         (WebCore::DocumentLoader::clearErrors):
1455         (WebCore::DocumentLoader::stopLoading):
1456         (WebCore::DocumentLoader::setupForReplace):
1457         (WebCore::DocumentLoader::commitIfReady):
1458         (WebCore::DocumentLoader::finishedLoading):
1459         (WebCore::DocumentLoader::setCommitted):
1460         (WebCore::DocumentLoader::isCommitted):
1461         (WebCore::DocumentLoader::setLoading):
1462         (WebCore::DocumentLoader::isLoading):
1463         (WebCore::DocumentLoader::doesProgressiveLoad):
1464         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
1465         (WebCore::DocumentLoader::updateLoading):
1466         (WebCore::DocumentLoader::setFrame):
1467         (WebCore::DocumentLoader::attachToFrame):
1468         (WebCore::DocumentLoader::detachFromFrame):
1469         (WebCore::DocumentLoader::prepareForLoadStart):
1470         (WebCore::DocumentLoader::loadingStartedTime):
1471         (WebCore::DocumentLoader::setIsClientRedirect):
1472         (WebCore::DocumentLoader::isClientRedirect):
1473         (WebCore::DocumentLoader::setPrimaryLoadComplete):
1474         (WebCore::DocumentLoader::isLoadingInAPISense):
1475         (WebCore::DocumentLoader::stopRecordingResponses):
1476         (WebCore::DocumentLoader::title):
1477         (WebCore::DocumentLoader::triggeringAction):
1478         (WebCore::DocumentLoader::setTriggeringAction):
1479         (WebCore::DocumentLoader::setOverrideEncoding):
1480         (WebCore::DocumentLoader::overrideEncoding):
1481         (WebCore::DocumentLoader::setTitle):
1482         (WebCore::DocumentLoader::URLForHistory):
1483         * loader/qt/FrameLoaderClientQt.cpp: Added.
1484         (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
1485         (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt):
1486         (WebCore::FrameLoaderClientQt::detachFrameLoader):
1487         (WebCore::FrameLoaderClientQt::hasWebView):
1488         (WebCore::FrameLoaderClientQt::hasFrameView):
1489         (WebCore::FrameLoaderClientQt::hasBackForwardList):
1490         (WebCore::FrameLoaderClientQt::resetBackForwardList):
1491         (WebCore::FrameLoaderClientQt::provisionalItemIsTarget):
1492         (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache):
1493         (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache):
1494         (WebCore::FrameLoaderClientQt::privateBrowsingEnabled):
1495         (WebCore::FrameLoaderClientQt::makeDocumentView):
1496         (WebCore::FrameLoaderClientQt::makeRepresentation):
1497         (WebCore::FrameLoaderClientQt::forceLayout):
1498         (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML):
1499         (WebCore::FrameLoaderClientQt::updateHistoryForCommit):
1500         (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation):
1501         (WebCore::FrameLoaderClientQt::updateHistoryForReload):
1502         (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad):
1503         (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad):
1504         (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect):
1505         (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
1506         (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset):
1507         (WebCore::FrameLoaderClientQt::resetAfterLoadError):
1508         (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError):
1509         (WebCore::FrameLoaderClientQt::willCloseDocument):
1510         (WebCore::FrameLoaderClientQt::detachedFromParent1):
1511         (WebCore::FrameLoaderClientQt::detachedFromParent2):
1512         (WebCore::FrameLoaderClientQt::detachedFromParent3):
1513         (WebCore::FrameLoaderClientQt::detachedFromParent4):
1514         (WebCore::FrameLoaderClientQt::loadedFromPageCache):
1515         (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
1516         (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad):
1517         (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect):
1518         (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
1519         (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
1520         (WebCore::FrameLoaderClientQt::dispatchWillClose):
1521         (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
1522         (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1523         (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1524         (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
1525         (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
1526         (WebCore::FrameLoaderClientQt::dispatchShow):
1527         (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
1528         (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
1529         (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource):
1530         (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache):
1531         (WebCore::FrameLoaderClientQt::isLoadingFromPageCache):
1532         (WebCore::FrameLoaderClientQt::revertToProvisionalState):
1533         (WebCore::FrameLoaderClientQt::clearUnarchivingState):
1534         (WebCore::FrameLoaderClientQt::progressStarted):
1535         (WebCore::FrameLoaderClientQt::progressCompleted):
1536         (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
1537         (WebCore::FrameLoaderClientQt::willChangeTitle):
1538         (WebCore::FrameLoaderClientQt::didChangeTitle):
1539         (WebCore::FrameLoaderClientQt::finishedLoading):
1540         (WebCore::FrameLoaderClientQt::finalSetupForReplace):
1541         (WebCore::FrameLoaderClientQt::setDefersLoading):
1542         (WebCore::FrameLoaderClientQt::isArchiveLoadPending):
1543         (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad):
1544         (WebCore::FrameLoaderClientQt::clearArchivedResources):
1545         (WebCore::FrameLoaderClientQt::canShowMIMEType):
1546         (WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
1547         (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
1548         (WebCore::FrameLoaderClientQt::frameLoadCompleted):
1549         (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState):
1550         (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
1551         (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent):
1552         (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll):
1553         (WebCore::FrameLoaderClientQt::didFinishLoad):
1554         (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement):
1555         (WebCore::FrameLoaderClientQt::setTitle):
1556         (WebCore::FrameLoaderClientQt::userAgent):
1557         * loader/qt/FrameLoaderClientQt.h: Added.
1558         * loader/qt/FrameLoaderQt.cpp:
1559         (WebCore::FrameLoader::submitForm):
1560         (WebCore::FrameLoader::overrideMediaType):
1561         (WebCore::FrameLoader::getHistoryLength):
1562         (WebCore::FrameLoader::referrer):
1563         (WebCore::FrameLoader::detachFromParent):
1564         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1565         (WebCore::FrameLoader::goBackOrForward):
1566         (WebCore::FrameLoader::historyURL):
1567         (WebCore::FrameLoader::didFirstLayout):
1568         (WebCore::FrameLoader::canGoBackOrForward):
1569         (WebCore::FrameLoader::partClearedInBegin):
1570         (WebCore::FrameLoader::saveDocumentState):
1571         (WebCore::FrameLoader::restoreDocumentState):
1572         (WebCore::FrameLoader::didChangeTitle):
1573         (WebCore::FrameLoader::redirectDataToPlugin):
1574         (WebCore::PolicyCheck::PolicyCheck):
1575         (WebCore::PolicyCheck::clear):
1576         (WebCore::PolicyCheck::set):
1577         (WebCore::PolicyCheck::call):
1578         (WebCore::PolicyCheck::clearRequest):
1579         * loader/qt/NavigationActionQt.cpp: Added.
1580         (WebCore::navigationType):
1581         (WebCore::NavigationAction::NavigationAction):
1582         * loader/qt/ResourceLoaderQt.cpp: Added.
1583         (WebCore::ResourceLoader::ResourceLoader):
1584         (WebCore::ResourceLoader::~ResourceLoader):
1585         (WebCore::ResourceLoader::setDefersLoading):
1586         (WebCore::ResourceLoader::cancel):
1587         (WebCore::ResourceLoader::loadsBlocked):
1588         * platform/MimeTypeRegistry.cpp:
1589         (WebCore::initialiseSupportedImageMIMETypes):
1590         * platform/network/qt/ResourceHandleManager.cpp:
1591         (WebCore::ResourceHandleManager::slotResult):
1592         (WebCore::ResourceHandleManager::cancel):
1593         * platform/qt/ChromeClientQt.cpp: Added.
1594         (WebCore::rootWindowForFrame):
1595         (WebCore::ChromeClientQt::ChromeClientQt):
1596         (WebCore::ChromeClientQt::~ChromeClientQt):
1597         (WebCore::ChromeClientQt::setWindowRect):
1598         (WebCore::ChromeClientQt::windowRect):
1599         (WebCore::ChromeClientQt::pageRect):
1600         (WebCore::ChromeClientQt::scaleFactor):
1601         (WebCore::ChromeClientQt::focus):
1602         (WebCore::ChromeClientQt::unfocus):
1603         (WebCore::ChromeClientQt::createWindow):
1604         (WebCore::ChromeClientQt::createModalDialog):
1605         (WebCore::ChromeClientQt::show):
1606         (WebCore::ChromeClientQt::canRunModal):
1607         (WebCore::ChromeClientQt::runModal):
1608         (WebCore::ChromeClientQt::setToolbarsVisible):
1609         (WebCore::ChromeClientQt::toolbarsVisible):
1610         (WebCore::ChromeClientQt::setStatusbarVisible):
1611         (WebCore::ChromeClientQt::statusbarVisible):
1612         (WebCore::ChromeClientQt::setScrollbarsVisible):
1613         (WebCore::ChromeClientQt::scrollbarsVisible):
1614         (WebCore::ChromeClientQt::setMenubarVisible):
1615         (WebCore::ChromeClientQt::menubarVisible):
1616         (WebCore::ChromeClientQt::setResizable):
1617         * platform/qt/ChromeClientQt.h: Added.
1618         * platform/qt/EditorClientQt.cpp:
1619         (WebCore::EditorClientQt::shouldBeginEditing):
1620         (WebCore::EditorClientQt::shouldEndEditing):
1621         (WebCore::EditorClientQt::shouldApplyStyle):
1622         (WebCore::EditorClientQt::didBeginEditing):
1623         (WebCore::EditorClientQt::respondToChangedContents):
1624         (WebCore::EditorClientQt::didEndEditing):
1625         * platform/qt/EditorClientQt.h:
1626         * platform/qt/FrameQt.cpp:
1627         (WebCore::FrameQt::FrameQt):
1628         (WebCore::FrameQt::~FrameQt):
1629         (WebCore::FrameQt::keyEvent):
1630         * platform/qt/FrameQt.h:
1631         * platform/qt/FrameQtClient.cpp:
1632         (WebCore::FrameQtClientDefault::openURL):
1633         (WebCore::FrameQtClientDefault::didReceiveData):
1634         (WebCore::FrameQtClientDefault::receivedAllData):
1635         * platform/qt/ImageQt.cpp:
1636         * platform/qt/MimeTypeRegistryQt.cpp: Added.
1637         (WebCore::getMIMETypeForUTI):
1638         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1639         * platform/qt/PageQt.cpp:
1640         * platform/qt/PlatformKeyboardEventQt.cpp:
1641         (WebCore::keyIdentifierForQtKeyCode):
1642         * platform/qt/ScreenQt.cpp:
1643         * platform/qt/TemporaryLinkStubs.cpp:
1644         (WebCore::TextField::TextField):
1645         (WebCore::screenDepth):
1646         (WebCore::screenDepthPerComponent):
1647         (WebCore::screenIsMonochrome):
1648         (WebCore::screenRect):
1649         (WebCore::screenAvailableRect):
1650
1651 2006-11-10  Brady Eidson <beidson@apple.com>
1652
1653         Reviewed by Mitz
1654
1655         http://bugs.webkit.org/show_bug.cgi?id=11554
1656         Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
1657         in case the icon load fails after some data has been received. 
1658
1659         * loader/icon/IconLoader.cpp:
1660         (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB
1661         on error.  Also, as a loader re-factoring sanity check, added an assertion
1662         (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon 
1663         is already committed to the DB.  Skip doing that step twice.
1664
1665 2006-11-09  Oliver Hunt  <oliver@apple.com>
1666
1667         Reviewed by Brady.
1668
1669         Pulled MIME type handling out of WebFrameBridge and added
1670         a general C++ class to store/query MIME info
1671         Added an Obj-C bridge to provide WebKit with access to the
1672         MimeTypeRegistry for non-Obj-C++ classes.
1673         
1674         * WebCore.exp:
1675         * WebCore.xcodeproj/project.pbxproj:
1676         * bridge/mac/WebCoreFrameBridge.h:
1677         * bridge/mac/WebCoreFrameBridge.mm:
1678         * bridge/mac/WebMimeTypeRegistryBridge.h: Added.
1679         * bridge/mac/WebMimeTypeRegistryBridge.mm: Added.
1680         (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]):
1681         (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]):
1682         (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]):
1683         (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]):
1684         (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
1685         * platform/Image.cpp:
1686         (WebCore::Image::supportsType):
1687         * platform/Image.h:
1688         * platform/MimeTypeRegistry.cpp: Added.
1689         (WebCore::initialiseSupportedImageMIMETypes):
1690         (WebCore::initialiseSupportedNonImageMimeTypes):
1691         (WebCore::initialiseMimeTypeRegistry):
1692         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType):
1693         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType):
1694         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType):
1695         (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes):
1696         (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes):
1697         (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
1698         * platform/MimeTypeRegistry.h: Added.
1699         * platform/mac/ImageMac.mm:
1700         * platform/mac/MimeTypeRegistryMac.mm: Added.
1701         (WebCore::getMIMETypeForUTI):
1702         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
1703
1704 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1705
1706         Reviewed by Oliver.
1707
1708         - rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search
1709         for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size
1710         for you and use vsnprintf.
1711
1712         * bindings/js/kjs_window.cpp:
1713         (KJS::Window::isSafeScript):
1714         * css/cssparser.cpp:
1715         (WebCore::CSSParser::parseColorFromValue):
1716         * dom/StyledElement.cpp:
1717         (WebCore::StyledElement::addCSSColor):
1718         * dom/XMLTokenizer.cpp:
1719         (WebCore::XMLTokenizer::handleError):
1720         * ksvg2/css/SVGCSSParser.cpp:
1721         (WebCore::CSSParser::parseSVGPaint):
1722         (WebCore::CSSParser::parseSVGColor):
1723         * ksvg2/svg/SVGPathSegArc.h:
1724         (WebCore::SVGPathSegArcAbs::toString):
1725         (WebCore::SVGPathSegArcRel::toString):
1726         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
1727         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
1728         (WebCore::SVGPathSegCurvetoCubicRel::toString):
1729         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
1730         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
1731         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
1732         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
1733         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
1734         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
1735         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
1736         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
1737         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
1738         * ksvg2/svg/SVGPathSegLineto.h:
1739         (WebCore::SVGPathSegLinetoAbs::toString):
1740         (WebCore::SVGPathSegLinetoRel::toString):
1741         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
1742         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
1743         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
1744         * ksvg2/svg/SVGPathSegLinetoVertical.h:
1745         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
1746         (WebCore::SVGPathSegLinetoVerticalRel::toString):
1747         * ksvg2/svg/SVGPathSegMoveto.h:
1748         (WebCore::SVGPathSegMovetoAbs::toString):
1749         (WebCore::SVGPathSegMovetoRel::toString):
1750         * ksvg2/svg/SVGPolyElement.cpp:
1751         (WebCore::SVGPolyElement::notifyAttributeChange):
1752         * ksvg2/svg/SVGUseElement.cpp:
1753         (WebCore::SVGUseElement::closeRenderer):
1754         * loader/icon/IconDatabase.cpp:
1755         (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
1756         * loader/icon/SQLDatabase.cpp:
1757         (WebCore::SQLDatabase::setSynchronous):
1758         * platform/Color.cpp:
1759         (WebCore::Color::name):
1760         * platform/DeprecatedString.cpp:
1761         (WebCore::DeprecatedString::setNum):
1762         (WebCore::DeprecatedString::format):
1763         * platform/DeprecatedString.h:
1764         * platform/PlatformString.h:
1765         * platform/String.cpp:
1766         (WebCore::String::format):
1767         (WebCore::String::number):
1768         * platform/mac/KeyEventMac.mm:
1769         (WebCore::keyIdentifierForKeyEvent):
1770         * platform/win/KeyEventWin.cpp:
1771         (WebCore::keyIdentifierForWindowsKeyCode):
1772         * rendering/RenderListMarker.cpp:
1773         (WebCore::RenderListMarker::calcMinMaxWidth):
1774
1775 2006-11-09  Maciej Stachowiak  <mjs@apple.com>
1776
1777         Reviewed by Anders.
1778
1779         - fixed "Regression: Can't log into gmail.com"
1780         - fixed "iBench doesn't report results - tests run but no number is recorded"
1781         
1782         * platform/network/cf/FormDataStreamCFNet.cpp:
1783         (WebCore::setHTTPBody): Removed extra ! character.
1784
1785 2006-11-09  Beth Dakin  <bdakin@apple.com>
1786
1787         Reviewed by Hyatt.
1788
1789         Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in 
1790         WebCore::RenderBlock::skipWhitespace
1791
1792         Note that this will still crash on Debug builds because it will hit 
1793         an assertion failure in editing. (One of the reasons there is no 
1794         layout test along with this fix.) There is definitely some editing 
1795         wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
1796         id=10144 for updates on the assertion failure bug.
1797
1798         * rendering/RootInlineBox.cpp:
1799         (WebCore::RootInlineBox::childRemoved): It is possible for a 
1800         prevRootBox and its prevRootBox to share a lineBreakObj. So instead 
1801         of just clearing the lineBreakObj of the prevRootBox, cycle through 
1802         all prevRootBoxs with the same lineBreakObj. 
1803
1804 2006-11-09  Adam Roben  <aroben@apple.com>
1805
1806         Reviewed by Geoff.
1807
1808         Fix the change in behavior I caused in r17680 with my build fix.
1809
1810         * rendering/RenderObject.cpp:
1811         (WebCore::RenderObject::maxTopMargin):
1812         (WebCore::RenderObject::maxBottomMargin):
1813
1814 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
1815
1816         Reviewed by Adam, Oliver.
1817
1818         Move more functions to Editor.
1819
1820         * bridge/EditorClient.h:
1821         * bridge/mac/FrameMac.h:
1822         * bridge/mac/FrameMac.mm:
1823         * bridge/mac/WebCoreFrameBridge.h:
1824         * editing/EditCommand.cpp:
1825         (WebCore::EditCommand::apply):
1826         (WebCore::EditCommand::unapply):
1827         (WebCore::EditCommand::reapply):
1828         * editing/Editor.cpp:
1829         (WebCore::Editor::respondToChangedContents):
1830         (WebCore::dispatchEditableContentChangedEvents):
1831         (WebCore::Editor::appliedEditing):
1832         (WebCore::Editor::unappliedEditing):
1833         (WebCore::Editor::reappliedEditing):
1834         * editing/Editor.h:
1835         * editing/TypingCommand.cpp:
1836         (WebCore::TypingCommand::typingAddedToOpenCommand):
1837         * page/Frame.cpp:
1838         * page/Frame.h:
1839
1840 2006-11-09  Darin Adler  <darin@apple.com>
1841
1842         * rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
1843
1844 2006-11-09  Alice Liu  <alice.liu@apple.com>
1845
1846         Reviewed by Beth Dakin.
1847
1848         Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
1849         All existing layout tests pass
1850
1851         * html/HTMLTableElement.cpp:
1852         (WebCore::HTMLTableElement::deleteRow):
1853         check lastSection before deleting row
1854
1855 2006-11-09  Darin Adler  <darin@apple.com>
1856
1857         - improved version of last night's build fix (should not do using namespace in a header)
1858
1859         * rendering/RenderObject.h:
1860         * rendering/RenderObject.cpp:
1861         (WebCore::RenderObject::maxTopMargin):
1862         (WebCore::RenderObject::maxBottomMargin):
1863
1864 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
1865
1866         Reviewed by Geoff.
1867         
1868         - added ResourceError class and didFailWithError client method
1869
1870         * WebCore.xcodeproj/project.pbxproj:
1871         * loader/icon/IconLoader.cpp:
1872         (WebCore::IconLoader::didFailWithError):
1873         (WebCore::IconLoader::didFinishLoading):
1874         * loader/icon/IconLoader.h:
1875         * loader/loader.cpp:
1876         (WebCore::Loader::receivedAllData):
1877         (WebCore::Loader::didFailWithError):
1878         * loader/loader.h:
1879         * loader/mac/SubresourceLoaderMac.mm:
1880         (WebCore::SubresourceLoader::didFail):
1881         (WebCore::SubresourceLoader::didCancel):
1882         * platform/cf/RetainPtr.h:
1883         (WebCore::):
1884         (WebCore::adoptCFReference):
1885         (WebCore::RetainPtr::RetainPtr):
1886         (WebCore::::adopt):
1887         * platform/network/ResourceError.cpp: Added.
1888         * platform/network/ResourceError.h: Added.
1889         (WebCore::ResourceError::ResourceError):
1890         (WebCore::ResourceError::domain):
1891         (WebCore::ResourceError::errorCode):
1892         (WebCore::ResourceError::failingURL):
1893         (WebCore::ResourceError::localizedDescription):
1894         (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
1895         * platform/network/ResourceHandle.cpp:
1896         * platform/network/ResourceHandle.h:
1897         * platform/network/ResourceHandleClient.h:
1898         (WebCore::ResourceHandleClient::didFailWithError):
1899         * platform/network/cf/ResourceHandleCFNet.cpp:
1900         (WebCore::didFail):
1901         (WebCore::ResourceHandle::cancel):
1902         * platform/network/mac/ResourceErrorMac.mm: Added.
1903         (-[NSError WebCore]):
1904         * platform/network/mac/ResourceHandleMac.mm:
1905         (WebCore::ResourceHandle::reportError):
1906         * xml/xmlhttprequest.cpp:
1907         (WebCore::XMLHttpRequest::didFailWithError):
1908         (WebCore::XMLHttpRequest::didFinishLoading):
1909         * xml/xmlhttprequest.h:
1910
1911 2006-11-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1912
1913         Reviewed by Maciej.
1914
1915         Linux\Gdk fixes.
1916
1917         * platform/gdk/ChromeClientGdk.h:
1918         (WebCore::ChromeClientGdk::~ChromeClientGdk):
1919         * platform/gdk/CursorGdk.cpp:
1920         (WebCore::Cursor::Cursor):
1921         (WebCore::moveCursor):
1922         * platform/gdk/FrameGdk.cpp:
1923         (WebCore::FrameGdk::FrameGdk):
1924         (WebCore::FrameGdk::submitForm):
1925         (WebCore::FrameGdk::urlSelected):
1926         * platform/gdk/PageGdk.cpp:
1927         * platform/gdk/ScreenClientGdk.h: Added.
1928         (WebCore::ScreenClientGdk::~ScreenClientGdk):
1929         * platform/gdk/ScreenGdk.cpp:
1930         (WebCore::ScreenClientGdk::depth):
1931         (WebCore::ScreenClientGdk::depthPerComponent):
1932         (WebCore::ScreenClientGdk::isMonochrome):
1933         (WebCore::ScreenClientGdk::rect):
1934         (WebCore::ScreenClientGdk::usableRect):
1935         * platform/gdk/TemporaryLinkStubs.cpp:
1936         (FrameGdk::historyURL):
1937         (ChromeClientGdk::windowRect):
1938         (ChromeClientGdk::setWindowRect):
1939         (ChromeClientGdk::pageRect):
1940         (ChromeClientGdk::scaleFactor):
1941         (ChromeClientGdk::focus):
1942         (ChromeClientGdk::unfocus):
1943         (ChromeClientGdk::createWindow):
1944         (ChromeClientGdk::createModalDialog):
1945         (ChromeClientGdk::show):
1946         (ChromeClientGdk::canRunModal):
1947         (ChromeClientGdk::runModal):
1948         (ChromeClientGdk::setToolbarsVisible):
1949         (ChromeClientGdk::toolbarsVisible):
1950         (ChromeClientGdk::setStatusbarVisible):
1951         (ChromeClientGdk::statusbarVisible):
1952         (ChromeClientGdk::setScrollbarsVisible):
1953         (ChromeClientGdk::scrollbarsVisible):
1954         (ChromeClientGdk::setMenubarVisible):
1955         (ChromeClientGdk::menubarVisible):
1956         (ChromeClientGdk::setResizable):
1957         * platform/network/ResourceHandleInternal.h:
1958         (WebCore::ResourceHandleInternal::client):
1959         * platform/network/gdk/ResourceHandleManager.cpp:
1960         (WebCore::writeCallback):
1961         (WebCore::ResourceHandleManager::downloadTimerCallback):
1962         (WebCore::ResourceHandleManager::remove):
1963
1964 2006-11-08  Adam Roben  <aroben@apple.com>
1965
1966         Build fix.
1967
1968         * rendering/RenderObject.h:
1969         (WebCore::RenderObject::maxTopMargin):
1970         (WebCore::RenderObject::maxBottomMargin):
1971
1972 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
1973
1974         Reviewed by Anders Carlsson.
1975
1976         Made Screen a good platform citizen by removing its reference to Page. This
1977         made a class unnecessary, so all screen fuctions are stand-alone now.
1978
1979         * bindings/js/kjs_window.cpp: Removed unnecessary subtractions
1980         when computing the screen's available dimensions.
1981
1982 2006-11-08  Sam Weinig  <sam.weinig@gmail.com>
1983
1984         Reviewed by Mitz.
1985
1986         Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
1987         Cleanup RenderObject
1988
1989         * rendering/RenderObject.cpp:
1990         (WebCore::RenderObject::operator delete):
1991         (WebCore::RenderObject::createObject):
1992         (WebCore::RenderObjectCounter::~RenderObjectCounter):
1993         (WebCore::RenderObject::RenderObject):
1994         (WebCore::RenderObject::isDescendantOf):
1995         (WebCore::RenderObject::isRoot):
1996         (WebCore::RenderObject::addChild):
1997         (WebCore::RenderObject::removeChildNode):
1998         (WebCore::RenderObject::removeChild):
1999         (WebCore::RenderObject::appendChildNode):
2000         (WebCore::RenderObject::insertChildNode):
2001         (WebCore::RenderObject::nextInPreOrder):
2002         (WebCore::RenderObject::nextInPreOrderAfterChildren):
2003         (WebCore::RenderObject::previousInPreOrder):
2004         (WebCore::RenderObject::isEditable):
2005         (WebCore::RenderObject::nextEditable):
2006         (WebCore::RenderObject::previousEditable):
2007         (WebCore::RenderObject::firstLeafChild):
2008         (WebCore::RenderObject::lastLeafChild):
2009         (WebCore::RenderObject::addLayers):
2010         (WebCore::RenderObject::removeLayers):
2011         (WebCore::RenderObject::moveLayers):
2012         (WebCore::RenderObject::findNextLayer):
2013         (WebCore::RenderObject::enclosingLayer):
2014         (WebCore::RenderObject::updateFirstLetter):
2015         (WebCore::RenderObject::offsetParent):
2016         (WebCore::RenderObject::scroll):
2017         (WebCore::RenderObject::hasStaticX):
2018         (WebCore::RenderObject::setNeedsLayout):
2019         (WebCore::RenderObject::setChildNeedsLayout):
2020         (WebCore::RenderObject::markContainingBlocksForLayout):
2021         (WebCore::RenderObject::containingBlock):
2022         (WebCore::RenderObject::containingBlockWidth):
2023         (WebCore::RenderObject::containingBlockHeight):
2024         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
2025         (WebCore::RenderObject::drawBorderArc):
2026         (WebCore::RenderObject::drawBorder):
2027         (WebCore::RenderObject::paintBorderImage):
2028         (WebCore::RenderObject::paintBorder):
2029         (WebCore::RenderObject::absoluteRects):
2030         (WebCore::RenderObject::addPDFURLRect):
2031         (WebCore::RenderObject::addFocusRingRects):
2032         (WebCore::RenderObject::paintOutline):
2033         (WebCore::RenderObject::repaint):
2034         (WebCore::RenderObject::repaintRectangle):
2035         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2036         (WebCore::RenderObject::repaintObjectsBeforeLayout):
2037         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
2038         (WebCore::RenderObject::information):
2039         (WebCore::RenderObject::dump):
2040         (WebCore::selectStartNode):
2041         (WebCore::RenderObject::shouldSelect):
2042         (WebCore::RenderObject::draggableNode):
2043         (WebCore::RenderObject::createAnonymousBlock):
2044         (WebCore::RenderObject::handleDynamicFloatPositionChange):
2045         (WebCore::RenderObject::setStyle):
2046         (WebCore::RenderObject::setStyleInternal):
2047         (WebCore::RenderObject::updateBackgroundImages):
2048         (WebCore::RenderObject::absolutePosition):
2049         (WebCore::RenderObject::caretRect):
2050         (WebCore::RenderObject::paddingTop):
2051         (WebCore::RenderObject::paddingBottom):
2052         (WebCore::RenderObject::paddingLeft):
2053         (WebCore::RenderObject::paddingRight):
2054         (WebCore::RenderObject::tabWidth):
2055         (WebCore::RenderObject::container):
2056         (WebCore::RenderObject::removeFromObjectLists):
2057         (WebCore::RenderObject::destroy):
2058         (WebCore::RenderObject::arenaDelete):
2059         (WebCore::RenderObject::hitTest):
2060         (WebCore::RenderObject::setInnerNode):
2061         (WebCore::RenderObject::nodeAtPoint):
2062         (WebCore::RenderObject::verticalPositionHint):
2063         (WebCore::RenderObject::getVerticalPosition):
2064         (WebCore::RenderObject::lineHeight):
2065         (WebCore::RenderObject::invalidateVerticalPositions):
2066         (WebCore::RenderObject::recalcMinMaxWidths):
2067         (WebCore::RenderObject::scheduleRelayout):
2068         (WebCore::RenderObject::setInlineBoxWrapper):
2069         (WebCore::RenderObject::firstLineStyle):
2070         (WebCore::RenderObject::getPseudoStyle):
2071         (WebCore::RenderObject::getTextDecorationColors):
2072         (WebCore::RenderObject::addDashboardRegions):
2073         (WebCore::RenderObject::collectDashboardRegions):
2074         (WebCore::RenderObject::avoidsFloats):
2075         (WebCore::RenderObject::findCounter):
2076         (WebCore::RenderObject::backslashAsCurrencySymbol):
2077         (WebCore::RenderObject::imageChanged):
2078         (WebCore::RenderObject::previousOffset):
2079         (WebCore::RenderObject::nextOffset):
2080         (WebCore::RenderObject::inlineBox):
2081         * rendering/RenderObject.h:
2082         (WebCore::):
2083         (WebCore::RenderObject::renderName):
2084         (WebCore::RenderObject::parent):
2085         (WebCore::RenderObject::previousSibling):
2086         (WebCore::RenderObject::nextSibling):
2087         (WebCore::RenderObject::firstChild):
2088         (WebCore::RenderObject::lastChild):
2089         (WebCore::RenderObject::getOverflowClipRect):
2090         (WebCore::RenderObject::getClipRect):
2091         (WebCore::RenderObject::getBaselineOfFirstLineBox):
2092         (WebCore::RenderObject::setEdited):
2093         (WebCore::RenderObject::setStaticX):
2094         (WebCore::RenderObject::setStaticY):
2095         (WebCore::RenderObject::setPreviousSibling):
2096         (WebCore::RenderObject::setNextSibling):
2097         (WebCore::RenderObject::setParent):
2098         (WebCore::RenderObject::isInlineBlockOrInlineTable):
2099         (WebCore::RenderObject::isRenderView):
2100         (WebCore::RenderObject::childrenInline):
2101         (WebCore::RenderObject::setChildrenInline):
2102         (WebCore::RenderObject::isAnonymousBlock):
2103         (WebCore::RenderObject::isDragging):
2104         (WebCore::RenderObject::needsLayout):
2105         (WebCore::RenderObject::setMinMaxKnown):
2106         (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
2107         (WebCore::RenderObject::setPositioned):
2108         (WebCore::RenderObject::setRelPositioned):
2109         (WebCore::RenderObject::setFloating):
2110         (WebCore::RenderObject::setInline):
2111         (WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
2112         (WebCore::RenderObject::setReplaced):
2113         (WebCore::RenderObject::PaintInfo::PaintInfo):
2114         (WebCore::RenderObject::paintBackgroundExtended):
2115         (WebCore::RenderObject::calcWidth):
2116         (WebCore::RenderObject::updateFromElement):
2117         (WebCore::RenderObject::RepaintInfo::RepaintInfo):
2118         (WebCore::RenderObject::setOverrideSize):
2119         (WebCore::RenderObject::setPos):
2120         (WebCore::RenderObject::setWidth):
2121         (WebCore::RenderObject::setHeight):
2122         (WebCore::RenderObject::absolutePositionForContent):
2123         (WebCore::RenderObject::overflowHeight):
2124         (WebCore::RenderObject::overflowWidth):
2125         (WebCore::RenderObject::setOverflowHeight):
2126         (WebCore::RenderObject::setOverflowWidth):
2127         (WebCore::RenderObject::overflowLeft):
2128         (WebCore::RenderObject::overflowTop):
2129         (WebCore::RenderObject::overflowRect):
2130         (WebCore::RenderObject::stopAutoscroll):
2131         (WebCore::RenderObject::collapsedMarginTop):
2132         (WebCore::RenderObject::collapsedMarginBottom):
2133         (WebCore::RenderObject::maxTopMargin):
2134         (WebCore::RenderObject::maxBottomMargin):
2135         (WebCore::RenderObject::):
2136         (WebCore::RenderObject::setTable):
2137         (WebCore::RenderObject::isFloatingOrPositioned):
2138         (WebCore::RenderObject::containsFloat):
2139         (WebCore::RenderObject::setSelectionState):
2140         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
2141         (WebCore::RenderObject::lowestPosition):
2142         (WebCore::RenderObject::rightmostPosition):
2143         (WebCore::RenderObject::leftmostPosition):
2144         (WebCore::RenderObject::calcVerticalMargins):
2145         (WebCore::RenderObject::font):
2146
2147 2006-11-08  Darin Adler  <darin@apple.com>
2148
2149         Reviewed by Anders.
2150
2151         - added event parameters to focus-related functions so we can
2152           implement the "option-tab to all links" behavior without relying
2153           on a global "current event" -- also makes it work with DOM events
2154
2155         * page/Frame.h: Removed unneeded includes. Moved some functions
2156         that were misplaced into the appropriate sections.
2157         * page/Frame.cpp:
2158         (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
2159         PlatformKeyboardEvent to the DOM keyboard event class.
2160         (WebCore::Frame::tabsToLinks): Added event parameter.
2161         (WebCore::Frame::tabsToAllControls): Ditto.
2162         (WebCore::scanForForm): Fixed code that incorrectly assumes
2163         that an iframe is an HTMLFrameElement (no longer true since Geoff
2164         changed the class hierarchy a bit).
2165         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2166
2167         * bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
2168         that were misplaced into the appropriate sections.
2169         * bridge/mac/FrameMac.mm:
2170         (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
2171         a PlatformKeyboardEvent.
2172         (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
2173         and pass event into next/previousFocusNode.
2174         (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
2175         the AppKit current event, if it's a keyboard event. Really just a hack that's
2176         needed to preserve some code we can remove once we deal with the last NSView-
2177         based form control.
2178         (WebCore::isKeyboardOptionTab): Added.
2179         (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
2180         option (alt) key is down.
2181         (WebCore::FrameMac::tabsToAllControls): Ditto.
2182         (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
2183         call resetMultipleFormSubmissionProtection() explicitly instead.
2184         (WebCore::FrameMac::mouseDown): Ditto.
2185
2186         * bridge/mac/WebCoreAXObject.mm:
2187         (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
2188         assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
2189         changed the class hierarchy a bit).
2190         (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
2191         prepareForUserAction() to call resetMultipleFormSubmissionProtection()
2192         explicitly instead.
2193
2194         * page/FrameView.h:
2195         * page/FrameView.cpp:
2196         (WebCore::FrameView::advanceFocus): Changed function to take an
2197         event parameter, and decide the direction based on the shift key
2198         modifier instead of a passed-in boolean.
2199
2200         * dom/Document.h:
2201         * dom/Document.cpp:
2202         (WebCore::Document::nextFocusNode): Added event parameter.
2203         (WebCore::Document::previousFocusNode): Ditto.
2204         * dom/Node.h:
2205         * dom/Node.cpp:
2206         (WebCore::Node::isKeyboardFocusable): Ditto.
2207         * html/HTMLAnchorElement.h:
2208         * html/HTMLAnchorElement.cpp:
2209         (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
2210         * html/HTMLGenericFormElement.h:
2211         * html/HTMLGenericFormElement.cpp:
2212         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
2213         * html/HTMLInputElement.h:
2214         * html/HTMLInputElement.cpp:
2215         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
2216         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
2217         * html/HTMLSelectElement.h:
2218         * html/HTMLSelectElement.cpp:
2219         (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
2220         * html/HTMLTextAreaElement.h:
2221         * html/HTMLTextAreaElement.cpp:
2222         (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
2223
2224         * dom/EventTargetNode.cpp:
2225         (WebCore::EventTargetNode::defaultEventHandler): Pass event to the
2226         advanceFocus function.
2227
2228         * platform/TextField.h:
2229         * platform/mac/TextFieldMac.mm: Removed the non-search field code.
2230
2231         * platform/mac/WebCoreTextField.h:
2232         * platform/mac/WebCoreTextField.mm: Removed the non-search field code.
2233         (-[WebCoreTextFieldController controlTextDidChange:]): Removed the
2234         call to FrameMac::handleKeyboardOptionTabInView, which is no longer
2235         needed since the default handler in HTMLInputElement takes care of
2236         option-tab.
2237
2238         * platform/mac/SliderMac.mm:
2239         (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
2240         and pass event into tabsToAllControls.
2241         (Slider::focusPolicy): Ditto.
2242
2243         * rendering/RenderLineEdit.cpp:
2244         (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
2245         (WebCore::RenderLineEdit::updateFromElement): Ditto.
2246
2247 2006-11-08  Brady Eidson  <beidson@apple.com>
2248
2249         Reviewed by Dave Harrison, Oliver, and Darin 
2250         (oh my!  where was superkevin on this one?)
2251
2252         <rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
2253
2254         More "free nil checking" we lost in the transition from ObjC to C++
2255
2256         * loader/mac/FrameLoaderMac.mm:
2257         (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
2258         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
2259
2260 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2261
2262         Reviewed by Adam.
2263
2264         Move more code into editor.
2265         
2266         * WebCore.exp:
2267         * bridge/EditorClient.h:
2268         * bridge/mac/FrameMac.h:
2269         * bridge/mac/FrameMac.mm:
2270         * bridge/mac/WebCoreFrameBridge.h:
2271         * dom/Document.cpp:
2272         (WebCore::Document::relinquishesEditingFocus):
2273         (WebCore::Document::acceptsEditingFocus):
2274         (WebCore::Document::didBeginEditing):
2275         (WebCore::Document::didEndEditing):
2276         * editing/Editor.cpp:
2277         (WebCore::Editor::indent):
2278         (WebCore::Editor::outdent):
2279         * editing/Editor.h:
2280         * page/Frame.cpp:
2281         * page/Frame.h:
2282
2283 2006-11-08  Beth Dakin  <bdakin@apple.com>
2284
2285         Reviewed by Adam.
2286
2287         Add ability to HitTestResult to ask if the inner non-shared node is 
2288         content editable.
2289
2290         * WebCore.exp: Export HitTestResult::isContentEditable()
2291         * rendering/HitTestResult.cpp:
2292         (WebCore::HitTestResult::isContentEditable):
2293         * rendering/HitTestResult.h:
2294
2295 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2296
2297         Build fix.
2298         
2299         * WebCore.xcodeproj/project.pbxproj:
2300         Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
2301
2302 2006-11-08  Timothy Hatcher  <timothy@apple.com>
2303
2304         Reviewed by Darin.
2305
2306         <rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
2307         <rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
2308
2309         Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
2310
2311         * bindings/objc/DOM.mm:
2312         (WebCore::kit):
2313         (-[DOMNode lineBoxRects]):
2314         (-[DOMRange boundingBox]):
2315         (-[DOMRange lineBoxRects]):
2316         * bindings/objc/DOMPrivate.h:
2317         * dom/Range.cpp:
2318         (WebCore::Range::boundingBox):
2319         (WebCore::Range::addLineBoxRects):
2320         * dom/Range.h:
2321         * rendering/RenderContainer.cpp:
2322         (WebCore::RenderContainer::addLineBoxRects):
2323         * rendering/RenderContainer.h:
2324         * rendering/RenderObject.cpp:
2325         (WebCore::RenderObject::addLineBoxRects):
2326         * rendering/RenderObject.h:
2327         * rendering/RenderText.cpp:
2328         (WebCore::RenderText::addLineBoxRects):
2329         * rendering/RenderText.h:
2330
2331 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
2332
2333         Reviewed by Oliver.
2334         
2335         Move methods from the bridge and frame into editor.
2336         
2337         * WebCore.exp:
2338         * bridge/EditorClient.h:
2339         * bridge/mac/WebCoreFrameBridge.h:
2340         * bridge/mac/WebCoreFrameBridge.mm:
2341         * editing/Editor.cpp:
2342         (WebCore::Editor::removeFormattingAndStyle):
2343         (WebCore::Editor::applyStyle):
2344         (WebCore::Editor::applyParagraphStyle):
2345         (WebCore::Editor::applyStyleToSelection):
2346         (WebCore::Editor::applyParagraphStyleToSelection):
2347         (WebCore::Editor::toggleBold):
2348         (WebCore::Editor::toggleItalic):
2349         (WebCore::Editor::selectionStartHasStyle):
2350         * editing/Editor.h:
2351         * editing/JSEditor.cpp:
2352         * page/Frame.cpp:
2353         * page/Frame.h:
2354
2355 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
2356
2357         Reviewed by Beth.
2358         
2359         Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
2360         be able to dispatch user events even when off-screen, so we have to support
2361         off-screen windows when handling mouse events.
2362
2363         * platform/Screen.h:
2364         * platform/mac/PlatformMouseEventMac.mm:
2365         (WebCore::globalPoint): Grab the best screen instead of the screen you're
2366         on, since you might be off-screen.
2367         * platform/mac/ScreenMac.mm:
2368         (WebCore::screenForWindow):
2369
2370 2006-11-08  Darin Adler  <darin@apple.com>
2371
2372         - fix bug caused by last-minute change to my check-in last night
2373           that is causing layout tests to hang
2374
2375         * dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
2376         * loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
2377         a null string into an empty string before calling completeURL.
2378
2379 2006-11-08  Brady Eidson <beidson@apple.com>
2380
2381         Reviewed by Maciej
2382
2383         If the request has already been aborted, bail out of didFinishLoading()
2384         immediately.  This prevents state change notifications that aren't
2385         needed.
2386
2387         * xml/xmlhttprequest.cpp:
2388         (WebCore::XMLHttpRequest::didFinishLoading):
2389
2390 2006-11-08  Darin Adler  <darin@apple.com>
2391
2392         - another attempt to fix Qt build
2393
2394         * loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
2395
2396 2006-11-08  Darin Adler  <darin@apple.com>
2397
2398         Reviewed by Geoff.
2399
2400         - stray bits of my FrameLoader patch that I left out by accident
2401
2402         * loader/FrameLoader.cpp:
2403         (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
2404         inside the FrameLoader class.
2405         (WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
2406         (WebCore::FrameLoader::clear): Stop the redirection timer.
2407         (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
2408         entire function in an if statement. Use less DeprecatedString.
2409         (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
2410         (WebCore::FrameLoader::scheduleRefresh): Ditto.
2411         (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
2412         inside the FrameLoader class.
2413         * loader/mac/FrameLoaderMac.mm:
2414         (WebCore::FrameLoader::load): Ditto.
2415         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
2416
2417 2006-11-07  Beth Dakin  <bdakin@apple.com>
2418
2419         Reviewed by Hyatt.
2420
2421         Another go at fix for <rdar://problem/4820814> A crash occurs at 
2422         WebCore::HitTestResult::spellingToolTip() when mousing down on 
2423         iframe at www.macsurfer.com
2424
2425         The fix from yesterday caused a layout test regression which 
2426         exposed an existing bug. The existing bug was that we allowed text 
2427         nodes to stay in the head tag, but other browsers move them to the 
2428         body. The previous fix also caused a performance regression, which 
2429         was seemingly easy to fix by moving the new clause in 
2430         HTMLParser::handleError() to be below the HTMLElement case.
2431
2432         * html/HTMLDocument.cpp:
2433         (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to 
2434         be the child of the document.
2435         * html/HTMLHeadElement.cpp:
2436         (WebCore::HTMLHeadElement::childAllowed): Do not allow non-
2437         whitespace text nodes to be children of the head.
2438         * html/HTMLHeadElement.h:
2439         * html/HTMLParser.cpp:
2440         (WebCore::HTMLParser::handleError): Error case for comment nodes.
2441         * page/FrameView.cpp:
2442         (WebCore::FrameView::handleMousePressEvent): Safety-net null check 
2443         for the original crash. 
2444
2445 2006-11-07  Darin Adler  <darin@apple.com>
2446
2447         - another attempt to fix Qt build
2448
2449         * loader/icon/IconLoader.h: Added missing include.
2450
2451 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
2452
2453         Reviewed by Tim Hatcher.
2454         
2455         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
2456         
2457         None of Screen's responsibilities require up-calls to WebKit or delegates, 
2458         so WebCore can handle it all.
2459         
2460         Moved Screen back from page/ to platform/ because it's a platform
2461         abstraction again.
2462
2463         Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
2464         since the two were always used together.
2465         
2466         Changed pixel depth queries to query the deepest screen. Darin mentioned
2467         that it might have been a feature, not a bug, to use the main/menubar screen
2468         regardless of the screen you were on. For scaling and flipping that's not
2469         the case, but for querying pixel depth I think it is. You want to know
2470         about the highest pixel depth your content may display on.
2471         
2472         Tests still pass.
2473
2474         * WebCore.exp:
2475         * WebCore.xcodeproj/project.pbxproj:
2476         * page/Page.cpp:
2477         (WebCore::Page::Page):
2478         * page/Page.h:
2479         * page/Screen.cpp: Removed.
2480         * page/Screen.h: Removed.
2481         * page/ScreenClient.h: Removed.
2482         * platform/mac/PlatformMouseEventMac.mm:
2483         (WebCore::globalPoint):
2484         * platform/mac/ScreenMac.mm:
2485         (WebCore::window):
2486         (WebCore::bestScreen):
2487         (WebCore::Screen::depth):
2488         (WebCore::Screen::depthPerComponent):
2489         (WebCore::Screen::isMonochrome):
2490         (WebCore::Screen::rect):
2491         (WebCore::Screen::usableRect):
2492         (WebCore::toUserSpace):
2493         (WebCore::toDeviceSpace):
2494
2495 2006-11-07  Darin Adler  <darin@apple.com>
2496
2497         - try to fix Qt build
2498
2499         * CMakeLists.txt: Updated for some file changes.
2500         * WebCoreSources.bkl: Ditto.
2501
2502 2006-11-07  Darin Adler  <darin@apple.com>
2503
2504         Reviewed by Geoff.
2505
2506         - moved loader code from Frame/FrameMac to FrameLoader
2507
2508         * WebCore.exp:
2509         * WebCore.xcodeproj/project.pbxproj:
2510         * bindings/js/JSXSLTProcessor.h:
2511         * bindings/js/kjs_events.cpp:
2512         (KJS::JSLazyEventListener::parseCode):
2513         * bindings/js/kjs_html.cpp:
2514         (KJS::JSHTMLDocument::putValueProperty):
2515         * bindings/js/kjs_navigator.cpp:
2516         (KJS::Navigator::getValueProperty):
2517         * bindings/js/kjs_proxy.cpp:
2518         (WebCore::KJSProxy::initScriptIfNeeded):
2519         * bindings/js/kjs_window.cpp:
2520         (KJS::Screen::Screen):
2521         (KJS::createNewWindow):
2522         (KJS::Window::getValueProperty):
2523         (KJS::Window::put):
2524         (KJS::Window::isSafeScript):
2525         (KJS::WindowFunc::callAsFunction):
2526         (KJS::ScheduledAction::execute):
2527         (KJS::Location::getValueProperty):
2528         (KJS::Location::put):
2529         (KJS::Location::toString):
2530         (KJS::LocationFunc::callAsFunction):
2531         (KJS::History::getValueProperty):
2532         (KJS::HistoryFunc::callAsFunction):
2533         * bindings/objc/DOM.mm:
2534         (+[DOMNode _nodeWith:WebCore::]):
2535         * bridge/mac/FrameMac.h:
2536         * bridge/mac/FrameMac.mm:
2537         (WebCore::FrameMac::~FrameMac):
2538         (WebCore::FrameMac::setView):
2539         (WebCore::FrameMac::setStatusBarText):
2540         * bridge/mac/WebCoreFrameBridge.h:
2541         * bridge/mac/WebCoreFrameBridge.mm:
2542         (-[WebCoreFrameBridge close]):
2543         (-[WebCoreFrameBridge addData:]):
2544         (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
2545         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
2546         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2547         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2548         (-[WebCoreFrameBridge baseURL]):
2549         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2550         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
2551         (-[WebCoreFrameBridge canProvideDocumentSource]):
2552         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
2553         * css/cssparser.cpp:
2554         (WebCore::CSSParser::parseContent):
2555         * dom/DOMImplementation.cpp:
2556         (WebCore::DOMImplementation::createDocument):
2557         (WebCore::DOMImplementation::createHTMLDocument):
2558         * dom/DOMImplementation.h:
2559         * dom/Document.cpp:
2560         (WebCore::Document::readyState):
2561         (WebCore::Document::updateTitle):
2562         (WebCore::Document::open):
2563         (WebCore::Document::close):
2564         (WebCore::Document::implicitClose):
2565         (WebCore::Document::processHttpEquiv):
2566         (WebCore::Document::referrer):
2567         (WebCore::Document::finishedParsing):
2568         * dom/ProcessingInstruction.cpp:
2569         (WebCore::ProcessingInstruction::checkStyleSheet):
2570         * dom/XMLTokenizer.cpp:
2571         (WebCore::XMLTokenizer::endElementNs):
2572         (WebCore::ignorableWhitespaceHandler):
2573         (WebCore::XMLTokenizer::notifyFinished):
2574         * editing/TextIterator.cpp:
2575         (WebCore::TextIterator::rangeFromLocationAndLength):
2576         * html/HTMLAnchorElement.cpp:
2577         (WebCore::HTMLAnchorElement::defaultEventHandler):
2578         * html/HTMLBaseElement.cpp:
2579         (WebCore::HTMLBaseElement::process):
2580         * html/HTMLDocument.cpp:
2581         (WebCore::HTMLDocument::lastModified):
2582         * html/HTMLFormElement.cpp:
2583         (WebCore::HTMLFormElement::formData):
2584         (WebCore::HTMLFormElement::submit):
2585         * html/HTMLFrameElementBase.cpp:
2586         (WebCore::HTMLFrameElementBase::isURLAllowed):
2587         (WebCore::HTMLFrameElementBase::openURL):
2588         (WebCore::HTMLFrameElementBase::willRemove):
2589         * html/HTMLInputElement.cpp:
2590         (WebCore::HTMLInputElement::setValueFromRenderer):
2591         * html/HTMLLinkElement.cpp:
2592         (WebCore::HTMLLinkElement::process):
2593         * html/HTMLParser.cpp:
2594         (WebCore::HTMLParser::handleError):
2595         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2596         * html/HTMLPreElement.idl:
2597         * html/HTMLScriptElement.cpp:
2598         (WebCore::HTMLScriptElement::parseMappedAttribute):
2599         (WebCore::HTMLScriptElement::insertedIntoDocument):
2600         * html/HTMLTokenizer.cpp:
2601         (WebCore::HTMLTokenizer::scriptExecution):
2602         (WebCore::HTMLTokenizer::parseTag):
2603         (WebCore::HTMLTokenizer::write):
2604         (WebCore::HTMLTokenizer::stopParsing):
2605         (WebCore::HTMLTokenizer::timerFired):
2606         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2607         (WebCore::KCanvasFilterQuartz::prepareFilter):
2608         * ksvg2/svg/SVGAElement.cpp:
2609         (WebCore::SVGAElement::defaultEventHandler):
2610         * ksvg2/svg/SVGElement.cpp:
2611         (WebCore::SVGElement::sendSVGLoadEventIfPossible):
2612         * loader/DocLoader.cpp:
2613         (WebCore::DocLoader::setLoadInProgress):
2614         * loader/FrameLoader.cpp:
2615         (WebCore::FormSubmission::FormSubmission):
2616         (WebCore::ScheduledRedirection::):
2617         (WebCore::ScheduledRedirection::ScheduledRedirection):
2618         (WebCore::cancelAll):
2619         (WebCore::getString):
2620         (WebCore::isBackForwardLoadType):
2621         (WebCore::numRequests):
2622         (WebCore::FrameLoader::FrameLoader):
2623         (WebCore::FrameLoader::~FrameLoader):
2624         (WebCore::FrameLoader::createWindow):
2625         (WebCore::FrameLoader::changeLocation):
2626         (WebCore::FrameLoader::urlSelected):
2627         (WebCore::FrameLoader::requestFrame):
2628         (WebCore::FrameLoader::loadSubframe):
2629         (WebCore::FrameLoader::submitFormAgain):
2630         (WebCore::FrameLoader::submitForm):
2631         (WebCore::FrameLoader::stopLoading):
2632         (WebCore::FrameLoader::stop):
2633         (WebCore::FrameLoader::closeURL):
2634         (WebCore::FrameLoader::cancelRedirection):
2635         (WebCore::FrameLoader::iconURL):
2636         (WebCore::FrameLoader::didOpenURL):
2637         (WebCore::FrameLoader::didExplicitOpen):
2638         (WebCore::FrameLoader::replaceContentsWithScriptResult):
2639         (WebCore::FrameLoader::executeScript):
2640         (WebCore::FrameLoader::cancelAndClear):
2641         (WebCore::FrameLoader::clear):
2642         (WebCore::FrameLoader::receivedFirstData):
2643         (WebCore::FrameLoader::responseMIMEType):
2644         (WebCore::FrameLoader::setResponseMIMEType):
2645         (WebCore::FrameLoader::begin):
2646         (WebCore::FrameLoader::write):
2647         (WebCore::FrameLoader::end):
2648         (WebCore::FrameLoader::endIfNotLoading):
2649         (WebCore::FrameLoader::startIconLoader):
2650         (WebCore::FrameLoader::commitIconURLToIconDatabase):
2651         (WebCore::FrameLoader::gotoAnchor):
2652         (WebCore::FrameLoader::finishedParsing):
2653         (WebCore::FrameLoader::loadDone):
2654         (WebCore::FrameLoader::checkCompleted):
2655         (WebCore::FrameLoader::checkEmitLoadEvent):
2656         (WebCore::FrameLoader::baseURL):
2657         (WebCore::FrameLoader::baseTarget):
2658         (WebCore::FrameLoader::completeURL):
2659         (WebCore::FrameLoader::scheduleRedirection):
2660         (WebCore::FrameLoader::scheduleLocationChange):
2661         (WebCore::FrameLoader::scheduleRefresh):
2662         (WebCore::FrameLoader::isScheduledLocationChangePending):
2663         (WebCore::FrameLoader::scheduleHistoryNavigation):
2664         (WebCore::FrameLoader::redirectionTimerFired):
2665         (WebCore::FrameLoader::encoding):
2666         (WebCore::FrameLoader::requestObject):
2667         (WebCore::FrameLoader::shouldUsePlugin):
2668         (WebCore::FrameLoader::loadPlugin):
2669         (WebCore::FrameLoader::clearRecordedFormValues):
2670         (WebCore::FrameLoader::recordFormValue):
2671         (WebCore::FrameLoader::parentCompleted):
2672         (WebCore::FrameLoader::outgoingReferrer):
2673         (WebCore::FrameLoader::lastModified):
2674         (WebCore::FrameLoader::opener):
2675         (WebCore::FrameLoader::setOpener):
2676         (WebCore::FrameLoader::openedByJavaScript):
2677         (WebCore::FrameLoader::setOpenedByJavaScript):
2678         (WebCore::FrameLoader::handleFallbackContent):
2679         (WebCore::FrameLoader::provisionalLoadStarted):
2680         (WebCore::FrameLoader::userGestureHint):
2681         (WebCore::FrameLoader::didNotOpenURL):
2682         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
2683         (WebCore::FrameLoader::setEncoding):
2684         (WebCore::FrameLoader::addData):
2685         (WebCore::FrameLoader::canCachePage):
2686         (WebCore::FrameLoader::updatePolicyBaseURL):
2687         (WebCore::FrameLoader::setPolicyBaseURL):
2688         (WebCore::FrameLoader::scrollToAnchor):
2689         (WebCore::FrameLoader::isComplete):
2690         (WebCore::FrameLoader::isLoadingMainResource):
2691         (WebCore::FrameLoader::url):
2692         (WebCore::FrameLoader::startRedirectionTimer):
2693         (WebCore::FrameLoader::stopRedirectionTimer):
2694         (WebCore::FrameLoader::updateBaseURLForEmptyDocument):
2695         (WebCore::FrameLoader::completed):
2696         (WebCore::FrameLoader::started):
2697         (WebCore::FrameLoader::containsPlugins):
2698         (WebCore::FrameLoader::prepareForLoadStart):
2699         (WebCore::FrameLoader::setupForReplace):
2700         (WebCore::FrameLoader::setupForReplaceByMIMEType):
2701         (WebCore::FrameLoader::finalSetupForReplace):
2702         (WebCore::FrameLoader::load):
2703         (WebCore::FrameLoader::canTarget):
2704         (WebCore::FrameLoader::stopLoadingPlugIns):
2705         (WebCore::FrameLoader::stopLoadingSubresources):
2706         (WebCore::FrameLoader::stopLoadingSubframes):
2707         (WebCore::FrameLoader::stopAllLoaders):
2708         (WebCore::FrameLoader::cancelMainResourceLoad):
2709         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2710         (WebCore::FrameLoader::activeDocumentLoader):
2711         (WebCore::FrameLoader::addPlugInStreamLoader):
2712         (WebCore::FrameLoader::removePlugInStreamLoader):
2713         (WebCore::FrameLoader::hasMainResourceLoader):
2714         (WebCore::FrameLoader::isLoadingSubresources):
2715         (WebCore::FrameLoader::isLoadingPlugIns):
2716         (WebCore::FrameLoader::isLoading):
2717         (WebCore::FrameLoader::addSubresourceLoader):
2718         (WebCore::FrameLoader::removeSubresourceLoader):
2719         (WebCore::FrameLoader::releaseMainResourceLoader):
2720         (WebCore::FrameLoader::setDocumentLoader):
2721         (WebCore::FrameLoader::documentLoader):
2722         (WebCore::FrameLoader::setPolicyDocumentLoader):
2723         (WebCore::FrameLoader::provisionalDocumentLoader):
2724         (WebCore::FrameLoader::setProvisionalDocumentLoader):
2725         (WebCore::FrameLoader::state):
2726         (WebCore::FrameLoader::timeOfLastCompletedLoad):
2727         (WebCore::FrameLoader::setState):
2728         (WebCore::FrameLoader::clearProvisionalLoad):
2729         (WebCore::FrameLoader::markLoadComplete):
2730         (WebCore::FrameLoader::commitProvisionalLoad):
2731         (WebCore::FrameLoader::privateBrowsingEnabled):
2732         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
2733         (WebCore::FrameLoader::clientRedirected):
2734         (WebCore::FrameLoader::shouldReload):
2735         (WebCore::FrameLoader::closeOldDataSources):
2736         (WebCore::FrameLoader::open):
2737         (WebCore::FrameLoader::isStopping):
2738         (WebCore::FrameLoader::finishedLoading):
2739         (WebCore::FrameLoader::URL):
2740         (WebCore::FrameLoader::isArchiveLoadPending):
2741         (WebCore::FrameLoader::isHostedByObjectElement):
2742         (WebCore::FrameLoader::isLoadingMainFrame):
2743         (WebCore::FrameLoader::canShowMIMEType):
2744         (WebCore::FrameLoader::representationExistsForURLScheme):
2745         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
2746         (WebCore::FrameLoader::cancelContentPolicyCheck):
2747         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
2748         (WebCore::FrameLoader::finishedLoadingDocument):
2749         (WebCore::FrameLoader::isReplacing):
2750         (WebCore::FrameLoader::setReplacing):
2751         (WebCore::FrameLoader::revertToProvisional):
2752         (WebCore::FrameLoader::subframeIsLoading):
2753         (WebCore::FrameLoader::willChangeTitle):
2754         (WebCore::FrameLoader::loadType):
2755         (WebCore::FrameLoader::stopPolicyCheck):
2756         (WebCore::FrameLoader::continueAfterContentPolicy):
2757         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2758         (WebCore::FrameLoader::didFirstLayout):
2759         (WebCore::FrameLoader::frameLoadCompleted):
2760         (WebCore::FrameLoader::firstLayoutDone):
2761         (WebCore::FrameLoader::isQuickRedirectComing):
2762         (WebCore::FrameLoader::closeDocument):
2763         (WebCore::FrameLoader::detachChildren):
2764         (WebCore::FrameLoader::checkLoadComplete):
2765         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2766         (WebCore::FrameLoader::setClient):
2767         (WebCore::FrameLoader::client):
2768         (WebCore::FrameLoader::userAgent):
2769         (WebCore::FrameLoader::createEmptyDocument):
2770         (WebCore::FrameLoader::tokenizerProcessedData):
2771         (WebCore::FrameLoader::didTellBridgeAboutLoad):
2772         (WebCore::FrameLoader::haveToldBridgeAboutLoad):
2773         (WebCore::FrameLoader::handledOnloadEvents):
2774         (WebCore::FrameLoader::frameDetached):
2775         (WebCore::FrameLoader::setTitle):
2776         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2777         * loader/FrameLoader.h:
2778         (WebCore::):
2779         * loader/FrameLoaderClient.h:
2780         * loader/PluginDocument.cpp:
2781         (WebCore::PluginTokenizer::createDocumentStructure):
2782         (WebCore::PluginTokenizer::writeRawData):
2783         * loader/ResourceLoader.h:
2784         * loader/TextResourceDecoder.cpp:
2785         (WebCore::TextResourceDecoder::checkForHeadCharset):
2786         * loader/icon/IconLoader.cpp:
2787         (WebCore::IconLoader::startLoading):
2788         (WebCore::IconLoader::finishLoading):
2789         * loader/loader.cpp:
2790         (WebCore::Loader::didReceiveResponse):
2791         * loader/mac/DocumentLoaderMac.mm:
2792         (WebCore::DocumentLoader::~DocumentLoader):
2793         (WebCore::DocumentLoader::stopLoading):
2794         (WebCore::DocumentLoader::finishedLoading):
2795         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
2796         (WebCore::DocumentLoader::setPrimaryLoadComplete):
2797         * loader/mac/FrameLoaderMac.mm:
2798         (WebCore::FrameLoader::load):
2799         (WebCore::FrameLoader::startLoading):
2800         (WebCore::FrameLoader::cancelMainResourceLoad):
2801         (WebCore::FrameLoader::receivedMainResourceError):
2802         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
2803         (WebCore::FrameLoader::commitProvisionalLoad):
2804         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2805         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2806         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2807         (WebCore::FrameLoader::detachFromParent):
2808         (WebCore::FrameLoader::addExtraFieldsToRequest):
2809         (WebCore::FrameLoader::loadResourceSynchronously):
2810         (WebCore::FrameLoader::createFrame):
2811         (WebCore::FrameLoader::objectContentType):
2812         (WebCore::nsArray):
2813         (WebCore::FrameLoader::createPlugin):
2814         (WebCore::FrameLoader::redirectDataToPlugin):
2815         (WebCore::FrameLoader::createJavaAppletWidget):
2816         (WebCore::FrameLoader::partClearedInBegin):
2817         (WebCore::FrameLoader::saveDocumentState):
2818         (WebCore::FrameLoader::restoreDocumentState):
2819         (WebCore::FrameLoader::overrideMediaType):
2820         (WebCore::FrameLoader::mainResourceData):
2821         (WebCore::FrameLoader::canGoBackOrForward):
2822         (WebCore::FrameLoader::originalRequestURL):
2823         (WebCore::FrameLoader::getHistoryLength):
2824         (WebCore::FrameLoader::goBackOrForward):
2825         (WebCore::FrameLoader::historyURL):
2826         (WebCore::FrameLoader::didFinishLoad):
2827         * loader/mac/LoaderFunctionsMac.mm:
2828         (WebCore::ServeSynchronousRequest):
2829         (WebCore::CheckCacheObjectStatus):
2830         * loader/mac/ResourceLoaderMac.mm:
2831         (WebCore::ResourceLoader::cancel):
2832         * loader/mac/SubresourceLoaderMac.mm:
2833         (WebCore::SubresourceLoader::create):
2834         * loader/qt/FrameLoaderQt.cpp: Added.
2835         (WebCore::FrameLoader::submitForm):
2836         (WebCore::FrameLoader::urlSelected):
2837         (WebCore::FrameLoader::setTitle):
2838         (WebCore::FrameLoader::createFrame):
2839         (WebCore::FrameLoader::objectContentType):
2840         (WebCore::FrameLoader::createPlugin):
2841         (WebCore::FrameLoader::createJavaAppletWidget):
2842         (WebCore::FrameLoader::originalRequestURL):
2843         * page/DOMWindow.cpp:
2844         (WebCore::DOMWindow::document):
2845         * page/Frame.cpp:
2846         (WebCore::Frame::~Frame):
2847         (WebCore::Frame::reparseConfiguration):
2848         (WebCore::Frame::shouldDragAutoNode):
2849         (WebCore::Frame::prepareForUserAction):
2850         (WebCore::FramePrivate::FramePrivate):
2851         (WebCore::FramePrivate::~FramePrivate):
2852         * page/Frame.h:
2853         * page/FramePrivate.h:
2854         * page/FrameView.cpp:
2855         (WebCore::FrameView::layout):
2856         (WebCore::FrameView::mediaType):
2857         * page/FrameView.h:
2858         * page/PageState.cpp:
2859         (WebCore::PageState::PageState):
2860         (WebCore::PageState::restoreJavaScriptState):
2861         * platform/mac/CookieJar.mm:
2862         (WebCore::setCookies):
2863         * platform/mac/TextCodecMac.cpp:
2864         * platform/mac/WebFontCache.mm:
2865         (+[WebFontCache fontWithFamily:traits:size:]):
2866         * platform/network/cf/ResourceHandleCFNet.cpp:
2867         (WebCore::ResourceHandle::start):
2868         * platform/network/mac/ResourceHandleMac.mm:
2869         (WebCore::ResourceHandle::start):
2870         * platform/qt/FrameQt.cpp:
2871         * platform/qt/FrameQt.h:
2872         * rendering/RenderApplet.cpp:
2873         (WebCore::RenderApplet::createWidgetIfNecessary):
2874         * rendering/RenderBlock.h:
2875         * rendering/RenderPartObject.cpp:
2876         (WebCore::isURLAllowed):
2877         (WebCore::RenderPartObject::updateWidget):
2878         * xml/DOMParser.cpp:
2879         (WebCore::DOMParser::parseFromString):
2880         * xml/XSLTProcessor.cpp:
2881         (WebCore::XSLTProcessor::createDocumentFromSource):
2882         * xml/xmlhttprequest.cpp:
2883         (WebCore::XMLHttpRequest::getResponseXML):
2884
2885 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
2886
2887         Reviewed by Geoff.
2888
2889         Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
2890         
2891         * bridge/mac/FrameMac.mm:
2892         (WebCore::FrameMac::registerCommandForUndoOrRedo):
2893         * bridge/mac/WebCoreFrameBridge.h:
2894         * bridge/mac/WebCoreFrameBridge.mm:
2895         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2896         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
2897         (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
2898         (-[WebCoreFrameBridge selectionGranularity]):
2899         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
2900         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
2901         (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
2902         (-[WebCoreFrameBridge applyStyle:withUndoAction:]):
2903         (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
2904         * editing/SelectionController.cpp:
2905         (WebCore::SelectionController::setModifyBias):
2906         (WebCore::SelectionController::modify):
2907         * editing/SelectionController.h:
2908         (WebCore::SelectionController::):
2909         * editing/TextGranularity.h:
2910
2911 2006-11-07  Brady Eidson  <beidson@apple.com>
2912
2913         Reviewed by Maciej
2914
2915         Changed the check for "top level frame" to something much more valid
2916
2917         * page/Frame.cpp:
2918         (WebCore::Frame::endIfNotLoading):
2919
2920 2006-11-07  Beth Dakin  <bdakin@apple.com>
2921
2922         Reviewed by Hyatt (yesterday).
2923
2924         Here is part of my patch from yesterday that is safe to roll back 
2925         in. It will make the BuildBot happy.
2926
2927         * rendering/HitTestResult.cpp:
2928         (WebCore::HitTestResult::spellingToolTip): Null-check 
2929         m_innerNonSharedNode.
2930
2931 2006-11-07  Darin Adler  <darin@apple.com>
2932
2933         * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
2934         Comment grammar fix.
2935
2936 2006-11-07  Darin Adler  <darin@apple.com>
2937
2938         Rolled out change for <rdar://problem/4820814>.
2939
2940         Beth's planning on landing a new change for it soon, but in the mean time
2941         we need layout tests succeeding again.
2942
2943 2006-11-07  Darin Adler  <darin@apple.com>
2944
2945         Reviewed by Brady.
2946
2947         - fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher
2948           crashes on launch in WebCore::ResourceLoader::start
2949
2950         No layout test, because this depends on cached icons, although there's
2951         perhaps a way to write a test for it with some further ingenuity.
2952
2953         * loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
2954         to make explicit the fact that it can't be successfully copied.
2955         Remove notifyIconChanged function and put the contents in the caller.
2956         This eliminates the need for IconLoaderMac.mm. Added finishedLoading
2957         and clearLoadingState functions to share code. Removed m_url, since the
2958         resource handle already stores the URL. Renamed m_resourceLoader to
2959         m_handle to reflect the class's name change. Removed the 4096-byte
2960         inline buffer from m_data, since the malloc savings is not sufficient
2961         to offset the additional memory use. Removed m_httpStatusCode because
2962         we can instead cancel the load when we get a status code that reflects
2963         failure. Added m_loadIsInProgress boolean because we need to detect
2964         loads that complete during the ResourceHandle::create function call.
2965
2966         * loader/icon/IconLoader.cpp:
2967         (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
2968         Don't initialize m_httpStatusCode.
2969         (WebCore::IconLoader::~IconLoader): Updated for name change.
2970         (WebCore::IconLoader::startLoading): Added code to use the
2971         m_loadIsInProgress flag to detect if the load completed while inside
2972         the ResourceHandle::create function. Removed code to set m_url.
2973         (WebCore::IconLoader::stopLoading): Call clearLoadingState to share
2974         more code.
2975         (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
2976         and finish loading if the HTTP status code indicates failure.
2977         (WebCore::IconLoader::didReceiveData): Removed assertion that checks
2978         the ResourceHandle, since we can't do that any more.
2979         (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
2980         so we can share code with the new didReceiveResponse code path.
2981         (WebCore::IconLoader::finishLoading): Moved code here from the
2982         didFinishLoading callback. Pass a URL when calling
2983         commitIconURLToIconDatabase. Call notifyIconChanged directly here
2984         instead of using a separate function. Call clearLoadingState to
2985         share more code with stopLoading.
2986         (WebCore::IconLoader::clearLoadingState): Added.
2987
2988         * loader/mac/IconLoaderMac.mm: Removed.
2989         * WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
2990
2991 2006-11-06  David Harrison  <harrison@apple.com>
2992
2993         Reviewed by Darin.
2994
2995         <rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
2996
2997         * editing/pasteboard/3976872-expected.txt:
2998         * editing/pasteboard/4076267-2-expected.txt:
2999         * editing/pasteboard/4076267-3-expected.txt:
3000         * editing/pasteboard/4076267-expected.txt:
3001         * editing/pasteboard/8145-1-expected.txt:
3002         * editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
3003         * editing/pasteboard/paste-match-style-001-expected.txt:
3004         * editing/pasteboard/paste-match-style-002-expected.txt:
3005         * editing/pasteboard/paste-text-019-expected.txt:
3006         * editing/pasteboard/pasting-tabs-expected.txt:
3007         Updated because pasting text with no newlines does not use intermediate div.
3008         
3009         * editing/markup.cpp:
3010         (WebCore::fillContainerFromString):
3011         First parameter is now a Container so a fragment can be passed.
3012         
3013         (WebCore::createFragmentFromText):
3014         A string with no newlines gets added inline, rather than being put into a paragraph.
3015
3016 2006-11-06  Beth Dakin  <bdakin@apple.com>
3017
3018         Reviewed by Hyatt.
3019
3020         Fix for <rdar://problem/4820814> A crash occurs at 
3021         WebCore::HitTestResult::spellingToolTip() when mousing down on 
3022         iframe at www.macsurfer.com
3023
3024         The bug here is that the source of the iframe is only a comment, 
3025         and we were not properly constructing the frame because it was 
3026         sort-of empty but not.
3027
3028         * html/HTMLDocument.cpp:
3029         (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if 
3030         it is a comment node.
3031         * html/HTMLParser.cpp:
3032         (WebCore::HTMLParser::handleError): if n is a comment node and 
3033         there is no head, we create a head, insert in the document, and add 
3034         the comment node as a child. This is what Firefox does too. 
3035         * page/FrameView.cpp:
3036         (WebCore::FrameView::handleMousePressEvent): Safe-guard for the 
3037         fix. It is possible to get a mouse event without a target node, so 
3038         we null check it. (Of course, in the case of this bug, it should 
3039         not have been null, but it is a good thing to check for anyway.
3040         * rendering/HitTestResult.cpp:
3041         (WebCore::HitTestResult::spellingToolTip): Null-check 
3042         m_innerNonSharedNode.
3043
3044 2006-11-06  Justin Garcia  <justin.garcia@apple.com>
3045
3046         Reviewed by harrison
3047         
3048         <rdar://problem/4641880>
3049         Setting bullets to existing text grabs subsequent paragraph
3050         
3051         When a selection ends at the start of a paragraph, we rarely paint 
3052         the selection gap before that paragraph, because there often is no gap.  
3053         In a case like this, it's not obvious to the user that the selection 
3054         ends "inside" that paragraph, so it would be confusing if 
3055         InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
3056         
3057         * editing/FormatBlockCommand.cpp:
3058         (WebCore::FormatBlockCommand::doApply): Moved the check for editability of
3059         the selection to a more appropriate place.  Change the endingSelection
3060         if it ends at the start of a paragraph.
3061         * editing/IndentOutdentCommand.cpp:
3062         (WebCore::IndentOutdentCommand::doApply): Ditto.
3063         * editing/InsertListCommand.cpp:
3064         (WebCore::InsertListCommand::doApply): Ditto.
3065
3066 2006-11-06  Brady Eidson  <beidson@apple.com>
3067
3068         Reviewed by Sarge
3069
3070         <rdar://problem/4822911> - ASSERTION was a little overzealous.  
3071         Toned it down a bit.
3072
3073         * xml/xmlhttprequest.cpp:
3074         (WebCore::XMLHttpRequest::didFinishLoading):  Toned down assertion
3075
3076 2006-11-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3077
3078         Reviewed by Maciej.
3079
3080         Linux\Gdk build fixes.
3081
3082         * loader/icon/IconDatabase.cpp:
3083         * loader/icon/SQLStatement.h:
3084         * platform/gdk/ChromeClientGdk.h: Added.
3085         (WebCore::ChromeClientGdk::~ChromeClientGdk):
3086         * platform/gdk/CursorGdk.cpp:
3087         (WebCore::pointerCursor):
3088         * platform/gdk/FrameGdk.cpp:
3089         (WebCore::doScroll):
3090         (WebCore::FrameGdk::FrameGdk):
3091         (WebCore::FrameGdk::submitForm):
3092         (WebCore::FrameGdk::urlSelected):
3093         (WebCore::FrameGdk::openURL):
3094         (WebCore::FrameGdk::handleGdkEvent):
3095         * platform/gdk/FrameGdk.h:
3096         (WebCore::FrameGdk::client):
3097         * platform/gdk/RenderPopupMenuGdk.cpp:
3098         (WebCore::PopupMenu::updateFromElement):
3099         * platform/gdk/ScreenGdk.cpp:
3100         * platform/gdk/TemporaryLinkStubs.cpp:
3101         (Slider::focusPolicy):
3102         (WebCore::ServeSynchronousRequest):
3103         (FrameGdk::goBackOrForward):
3104         (FrameGdk::getHistoryLength):
3105         (FrameGdk::historyURL):
3106         (ChromeClientGdk::canRunModal):
3107         (ChromeClientGdk::runModal):
3108         (WebCore::systemBeep):
3109         (WebCore::CachedResource::setPlatformResponse):
3110         (Path::transform):
3111         (ResourceLoader::loadsBlocked):
3112         (IconLoader::notifyIconChanged):
3113         * platform/network/gdk/ResourceHandleManager.cpp:
3114         (WebCore::writeCallback):
3115         (WebCore::ResourceHandleManager::downloadTimerCallback):
3116         (WebCore::ResourceHandleManager::remove):
3117         (WebCore::ResourceHandleManager::add):
3118
3119 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3120
3121         build fix.
3122         
3123         * WebCore.xcodeproj/project.pbxproj:
3124
3125 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
3126
3127         Reviewed by Maciej, Anders, Darin.
3128
3129         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
3130         Fixed a minor where WebCore would always assume it was displayed on the 
3131         monitor containing the menubar. window.open and window.showModalDialog 
3132         are now cross-platform. 
3133         
3134         Layout tests, manual-tests/show-modal-dialog, and manual-tests/
3135         window-open-features-parsing all pass. I verified the new screen functionality
3136         by running in DRT, and checking whether WebCore knew it was off-screen.
3137         
3138         Some refactoring remains, as all were not pleased by this design. I see
3139         in my future another patch.
3140
3141         * bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
3142         client, to encapsulate asking the platform questions about the screen occupied by
3143         the page. (Previously, we always assumed we were on screen 0, which was a bug.)
3144         * bridge/mac/WebCoreFrameBridge.mm:
3145         (createMouseEventFromDraggingInfo): Reversed argument order, to match other
3146         functions.
3147         (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
3148         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
3149         * bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
3150         * bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
3151         * bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
3152         * bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
3153         * manual-tests/window-open-features-parsing.html: Updated for accuracy.
3154         (In this case, neither size nor position is specified, so you should
3155         get the default window size and position.)
3156         * page/Screen.cpp: Added. Includes screen-related helper functions used
3157         in WebCore and WebKit.
3158         * platform/PlatformMouseEvent.h: Exported common code so it doesn't have
3159         to be duplicated. Renamed "position" to "point" since both were used,
3160         and "point" seemed clearer.
3161         * platform/Screen.h: Removed. Dead Code.
3162         * platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
3163         initialization.
3164
3165 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
3166
3167         Reviewed by Tim Hatcher.
3168
3169         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
3170         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
3171         
3172         No layout tests added as this must be tested manually by the test
3173         WebCore/manual-tests/contenteditable-link.html
3174
3175         * WebCore.exp: Exported HitTestResult::isLiveLink().
3176         * html/HTMLAnchorElement.cpp:
3177         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3178         (WebCore::HTMLAnchorElement::defaultEventHandler):
3179         (WebCore::HTMLAnchorElement::isLiveLink):
3180         * html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
3181         to track shift key status.
3182         * manual-tests/contenteditable-link.html: Added description about link
3183         dragging behaviour.
3184         * rendering/HitTestResult.cpp:
3185         (WebCore::HitTestResult::isLiveLink): Added.
3186         * rendering/HitTestResult.h:
3187
3188 2006-11-06  Brady Eidson  <beidson@apple.com>
3189
3190         Reviewed by Oliver
3191
3192         Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
3193         For now, we have to not load favicons when we have no Document - linking directly 
3194         to PDFs being the common case
3195
3196         * loader/icon/IconLoader.cpp:
3197         (WebCore::IconLoader::startLoading): Check for the document and return if none
3198
3199 2006-11-06  Brady Eidson  <beidson@apple.com>
3200
3201         Reviewed by Dave Harrison
3202
3203         <rdar://problem/4801066>
3204         Added a critical null frameLoader() check
3205
3206         * loader/mac/MainResourceLoaderMac.mm:
3207         (WebCore::MainResourceLoader::loadNow):
3208
3209 2006-11-06  David Harrison  <harrison@apple.com>
3210
3211         Reviewed by Darin.
3212
3213         <rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
3214
3215         Test:
3216         * editing/deleting/delete-br-012.html
3217         
3218         * editing/DeleteSelectionCommand.cpp:
3219         (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
3220         Update m_endingPosition when preventing merge.
3221         Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
3222
3223 2006-11-06  Mark Rowe  <bdash@webkit.org>
3224
3225         Reviewed by Maciej.
3226
3227         http://bugs.webkit.org/show_bug.cgi?id=11526
3228         Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
3229
3230         Update DOMNode::toString to always use className rather than preferring nodeName.
3231
3232         * bindings/js/kjs_dom.cpp:
3233         (KJS::DOMNode::toString): Match the format returned by valueOf.
3234
3235 2006-11-06  Oliver Hunt  <oliver@apple.com>
3236
3237         Reviewed by Maciej.
3238
3239         Fix RTL text in SVG to have correct positioning
3240
3241         * rendering/SVGRootInlineBox.cpp:
3242         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
3243
3244 2006-11-06  Alexey Proskuryakov  <ap@webkit.org>
3245
3246         Reviewed by Maciej.
3247
3248         http://bugs.webkit.org/show_bug.cgi?id=11517
3249         REGRESSION: Flash clicks/interactivity not working properly
3250
3251         * bridge/mac/FrameMac.mm:
3252         (WebCore::FrameMac::handleMouseMoveEvent):
3253         (WebCore::FrameMac::handleMouseReleaseEvent):
3254         Restore parts of event dispatching that were removed when fixing
3255         bug 7323 - just bypass those for subframes.
3256
3257 2006-11-05  Darin Adler  <darin@apple.com>
3258
3259         - quick attempt to fix the no-SVG build
3260
3261         * platform/graphics/svg/SVGResource.cpp:
3262         * platform/graphics/svg/SVGResource.h:
3263         * platform/graphics/svg/SVGResourceClipper.cpp:
3264         * platform/graphics/svg/SVGResourceClipper.h:
3265         * platform/graphics/svg/SVGResourceImage.h:
3266         * platform/graphics/svg/SVGResourceMarker.cpp:
3267         * platform/graphics/svg/SVGResourceMarker.h:
3268         * platform/graphics/svg/SVGResourceMasker.cpp:
3269         * platform/graphics/svg/SVGResourceMasker.h:
3270         * platform/graphics/svg/cg/SVGResourceMaskerCg.h:
3271         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
3272         * platform/graphics/svg/qt/SVGResourceImageQt.cpp:
3273         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
3274         Added #ifdef SVG_SUPPORT to these files.
3275
3276 2006-11-05  MorganL  <morganl.webkit@yahoo.com>
3277
3278         Reviewed & landed by Maciej.
3279
3280         Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
3281
3282         * platform/win/ResourceLoaderWin.cpp:
3283         (WebCore::transferJobStatusCallback):
3284         (WebCore::ResourceLoader::start):
3285
3286 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
3287
3288         Reviewed by Oliver.
3289
3290         - moved FormData and FormDataStream to platform/network directory
3291
3292         * WebCore.xcodeproj/project.pbxproj:
3293         * bridge/mac/WebCoreFrameBridge.mm:
3294         * loader/FormData.cpp: Removed.
3295         * loader/FormData.h: Removed.
3296         * loader/mac/FormDataStream.h: Removed.
3297         * loader/mac/FormDataStream.m: Removed.
3298         * loader/mac/FrameLoaderMac.mm:
3299         * loader/mac/SubresourceLoaderMac.mm:
3300         * platform/network/mac/FormDataStreamMac.h: Added.
3301         * platform/network/mac/FormDataStreamMac.mm: Added.
3302         * platform/network/mac/ResourceRequestMac.mm:
3303
3304 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
3305
3306         Fix build breaks
3307
3308         * loader/DocumentLoader.h:
3309         * platform/win/ScreenWin.cpp:
3310
3311 2006-11-05  Darin Adler  <darin@apple.com>
3312
3313         Reviewed by Geoff.
3314
3315         - more preparation for splitting up Frame into sub-pieces
3316         - removed unnecessary includes from Frame.h
3317
3318         * page/Frame.h: Removed unneeded includes and forward declarations.
3319         Added additional forward declarations. Removed the constant
3320         NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
3321         Created sections of functions to be moved into Chrome, Editor,
3322         EventHandler, FrameLoader, SelectionController, and the Platform
3323         directory, as well as marking one function for deletion.
3324
3325         * page/FramePrivate.h: Removed the definition of the constructor and
3326         destructor and removed unnecessary includes.
3327
3328         * page/FrameView.h: Removed unneeded forward declarations and friend
3329         declarations. Created a section of functions and data to be moved into
3330         EventHandler.
3331
3332         * bridge/mac/FrameMac.h: Removed unneeded forward declarations.
3333         Created sections of functions and data to be moved into Chrome,
3334         Editor, EventHandler, FrameLoader, and the Platform directory.
3335
3336         * bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
3337         Removed unused methods areScrollbarsVisible,
3338         nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
3339
3340         * page/Frame.cpp:
3341         (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
3342         to include KURL.h just for the KURL default constructor.
3343         (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
3344         (WebCore::FramePrivate::~FramePrivate): Ditto.
3345
3346         * page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
3347         booleans, scrollbarMoved and cleared funcitons.
3348         (WebCore::FrameView::clear): Moved the code from the cleared
3349         function in here.
3350         (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
3351
3352         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
3353         for changes to header.
3354
3355         * editing/SelectionController.cpp:
3356         (WebCore::SelectionController::setSelection):
3357         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
3358         Moved NoXPosForVerticalArrowNavigation into this file.
3359
3360         * bindings/js/kjs_events.cpp:
3361         * bindings/js/kjs_html.cpp:
3362         * bindings/js/kjs_window.cpp:
3363         * bridge/mac/WebCoreAXObject.mm:
3364         * bridge/mac/WebCoreFrameBridge.mm:
3365         * css/cssstyleselector.cpp:
3366         * dom/Document.cpp:
3367         * dom/Element.cpp:
3368         * dom/EventTargetNode.cpp:
3369         * dom/MouseRelatedEvent.cpp:
3370         * dom/XMLTokenizer.cpp:
3371         * html/HTMLBaseElement.cpp:
3372         * html/HTMLDocument.cpp:
3373         * html/HTMLEmbedElement.cpp:
3374         * html/HTMLFrameElementBase.cpp:
3375         * html/HTMLGenericFormElement.cpp:
3376         * html/HTMLObjectElement.cpp:
3377         * html/HTMLTokenizer.cpp:
3378         * loader/mac/FrameLoaderMac.mm:
3379         * page/PageState.cpp:
3380         * rendering/RenderApplet.cpp:
3381         * rendering/RenderBlock.cpp:
3382         * rendering/RenderLayer.cpp:
3383         * rendering/RenderObject.cpp:
3384         * rendering/RenderPartObject.cpp:
3385         * rendering/RenderTreeAsText.cpp:
3386         * xml/XSLTProcessor.cpp:
3387         Added includes as needed to keep compiling, since there are fewer
3388         includes in Frame.h.
3389
3390 2006-11-05  Alexey Proskuryakov  <ap@nypop.com>
3391
3392         Reviewed by Dave Harrison.
3393
3394         http://bugs.webkit.org/show_bug.cgi?id=11402
3395         REGRESSION: onChange does not work anymore for 1st item in popup
3396
3397         * html/HTMLSelectElement.cpp:
3398         (WebCore::HTMLSelectElement::HTMLSelectElement):
3399         (WebCore::HTMLSelectElement::reset):
3400         Set m_lastOnChangeIndex to -1.
3401
3402 2006-11-04  Darin Adler  <darin@apple.com>
3403
3404         Reviewed by Anders.
3405
3406         - fix http://bugs.webkit.org/show_bug.cgi?id=11453
3407           REGRESSION: Status bar always shows cancelled opening the page
3408
3409         * platform/network/mac/ResourceHandleMac.mm:
3410         (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
3411         Since the subresource owns the resource handle, there's no need to cancel.
3412         This arrangement is only temporary, anyway, since Maciej will soon change
3413         things so that the subresource loader uses the resource handle and the
3414         resource handle doesn't know anything about the subresource loader.
3415
3416 2006-11-04  Darin Adler  <darin@apple.com>
3417
3418         Reviewed by Maciej.
3419
3420         - converted more of the loader machinery to work with cross-platform
3421           data structures instead of Macintosh-specific ones
3422
3423           converted most uses of NSURL to KURL and NSEvent to DOM Event in
3424           loader classes
3425
3426           moved download function out of FrameLoader.h to avoid reference to
3427           NSURLConnection
3428
3429           added DOM Event parameters to various functions so that the handlers
3430           can use the DOM Event instead of the global "current NSEvent";
3431           includes Frame::submitForm, HTMLFormElement::prepareSubmit,
3432           HTMLFormElement::submit, FrameLoader::load
3433
3434           moved the setMainFrame call that hands ownership to the Page
3435           into one of the Frame constructors, and removed it from all
3436           the clients
3437
3438           removed const from Event parameter to the urlSelected function
3439           (we rarely use const with DOM elements)
3440
3441           removed some redundant includes and declarations from various
3442           header files
3443
3444           removed NSURL parameter from userAgent function -- if we need it we
3445           can add it back, but converting from NSURL to KURL and back is
3446           inefficient enough that it's best to have it out for now (since it's
3447           been unused for years) -- if we add it back, we can choose an
3448           appropriate parameter type that's always inexpensive to pass
3449
3450           did some basic cleanup in the IconLoader class, including removing
3451           an unnecessary loop that added icon data a byte at a time
3452
3453           renamed safeLoad to load, since it's no different from the other
3454           FrameLoader load functions, safety-wise
3455
3456           fixed some code that was trying to distinguish null frame name from
3457           empty string frame name -- both should be handled the same, but callers
3458           were doing it by checking for empty and turning it into null (in a way
3459           that was causing extra round trips between NSString and WebCore::String)
3460
3461           corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
3462           and got rid of case-insensitive compares of methods
3463
3464         * WebCore.exp:
3465         * WebCore.xcodeproj/project.pbxproj:
3466         * bindings/js/kjs_navigator.cpp:
3467         (KJS::Navigator::getValueProperty):
3468         * bridge/mac/FrameMac.h:
3469         * bridge/mac/FrameMac.mm:
3470         (WebCore::FrameMac::submitForm):
3471         (WebCore::FrameMac::urlSelected):
3472         (WebCore::FrameMac::userAgent):
3473         * bridge/mac/FrameViewMac.mm:
3474         * bridge/mac/WebCoreAXObject.mm:
3475         (-[WebCoreAXObject rendererForView:]):
3476         * bridge/mac/WebCorePageBridge.h:
3477         * bridge/mac/WebCorePageBridge.mm:
3478         * bridge/mac/WebCoreSettings.mm:
3479         * bridge/win/FrameWin.cpp:
3480         (WebCore::FrameWin::urlSelected):
3481         (WebCore::FrameWin::submitForm):
3482         * bridge/win/FrameWin.h:
3483         * dom/MouseRelatedEvent.cpp:
3484         * dom/MouseRelatedEvent.h:
3485         * dom/UIEvent.cpp:
3486         (WebCore::UIEvent::~UIEvent):
3487         * dom/UIEvent.h:
3488         * dom/UIEventWithKeyState.h:
3489         * dom/XMLTokenizer.cpp:
3490         (WebCore::openFunc):
3491         * html/HTMLAnchorElement.cpp:
3492         (WebCore::HTMLAnchorElement::defaultEventHandler):
3493         * html/HTMLButtonElement.cpp:
3494         (WebCore::HTMLButtonElement::defaultEventHandler):
3495         * html/HTMLFormElement.cpp:
3496         (WebCore::HTMLFormElement::submitClick):
3497         (WebCore::HTMLFormElement::prepareSubmit):
3498         (WebCore::HTMLFormElement::submit):
3499         * html/HTMLFormElement.h:
3500         * html/HTMLInputElement.cpp:
3501         (WebCore::HTMLInputElement::defaultEventHandler):
3502         * html/HTMLSelectElement.cpp:
3503         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
3504         * loader/DocumentLoader.h:
3505         * loader/FrameLoader.h:
3506         * loader/FrameLoaderClient.h:
3507         * loader/NavigationAction.h:
3508         (WebCore::NavigationAction::event):
3509         * loader/icon/IconLoader.cpp:
3510         (WebCore::IconLoader::create):
3511         (WebCore::IconLoader::startLoading):
3512         (WebCore::IconLoader::didReceiveData):
3513         (WebCore::IconLoader::didFinishLoading):
3514         * loader/icon/IconLoader.h:
3515         * loader/loader.cpp:
3516         * loader/mac/DocumentLoaderMac.mm:
3517         (WebCore::DocumentLoader::URL):
3518         (WebCore::DocumentLoader::unreachableURL):
3519         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
3520         (WebCore::DocumentLoader::URLForHistory):
3521         * loader/mac/FrameLoaderMac.mm:
3522         (WebCore::FrameLoader::load):
3523         (WebCore::FrameLoader::willSendRequest):
3524         (WebCore::FrameLoader::clientRedirected):
3525         (WebCore::FrameLoader::shouldReload):
3526         (WebCore::FrameLoader::notifyIconChanged):
3527         (WebCore::FrameLoader::URL):
3528         (WebCore::FrameLoader::reloadAllowingStaleData):
3529         (WebCore::FrameLoader::reload):
3530         (WebCore::FrameLoader::didChangeTitle):
3531         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3532         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3533         (WebCore::FrameLoader::post):
3534         (WebCore::FrameLoader::addExtraFieldsToRequest):
3535         (WebCore::FrameLoader::loadResourceSynchronously):
3536         * loader/mac/IconLoaderMac.mm:
3537         (WebCore::IconLoader::notifyIconChanged):
3538         * loader/mac/LoaderFunctionsMac.mm:
3539         * loader/mac/MainResourceLoaderMac.mm:
3540         (WebCore::shouldLoadAsEmptyDocument):
3541         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3542         * loader/mac/NavigationActionMac.mm:
3543         (WebCore::navigationType):
3544         (WebCore::NavigationAction::NavigationAction):
3545         * loader/mac/ResourceLoaderMac.mm:
3546         * loader/mac/SubresourceLoaderMac.mm:
3547         * page/Frame.cpp:
3548         (WebCore::Frame::Frame):
3549         (WebCore::Frame::urlSelected):
3550         (WebCore::Frame::submitFormAgain):
3551         (WebCore::Frame::submitForm):
3552         (WebCore::Frame::endIfNotLoading):
3553         (WebCore::Frame::hitTestResultAtPoint):
3554         * page/Frame.h:
3555         * page/FramePrivate.h:
3556         * platform/gdk/FrameGdk.cpp:
3557         (WebCore::FrameGdk::FrameGdk):
3558         (WebCore::FrameGdk::submitForm):
3559         (WebCore::FrameGdk::urlSelected):
3560         * platform/gdk/FrameGdk.h:
3561         * platform/mac/TextFieldMac.mm:
3562         * platform/network/HTTPHeaderMap.h:
3563         * platform/network/ResourceHandle.h:
3564         * platform/network/ResourceHandleClient.h:
3565         * platform/network/ResourceHandleInternal.h:
3566         * platform/network/mac/ResourceHandleMac.mm:
3567         * platform/network/mac/ResourceResponseMac.h:
3568         * platform/network/mac/ResourceResponseMac.mm:
3569         (-[NSURLResponse WebCore]):
3570         * platform/network/win/ResourceHandleWin.cpp:
3571         * platform/qt/FrameQt.cpp:
3572         (WebCore::FrameQt::submitForm):
3573         (WebCore::FrameQt::urlSelected):
3574         * platform/qt/FrameQt.h:
3575         * rendering/RenderLineEdit.cpp:
3576         (WebCore::RenderLineEdit::returnPressed):
3577         * xml/XSLTProcessor.cpp:
3578         (WebCore::docLoaderFunc):
3579         * xml/xmlhttprequest.cpp:
3580
3581 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3582
3583         Reviewed by Adele.
3584
3585         - replaced receivedRedirect with new willSendRequest delegate
3586         - removed most mac-specific loader functions
3587         - use ResourceResponse more in loader code
3588
3589         * WebCore.xcodeproj/project.pbxproj: Add new files.
3590         * bridge/mac/WebCoreFrameBridge.mm:
3591         (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
3592         for CachedResource method renames.
3593         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3594         Ditto.
3595         * loader/CachedCSSStyleSheet.cpp:
3596         (WebCore::CachedCSSStyleSheet::checkNotify): simplified
3597         based on ResourceResponse
3598         * loader/CachedImage.cpp:
3599         (WebCore::CachedImage::createImage): adapt for ResourceResponse
3600         * loader/CachedResource.cpp:
3601         (WebCore::CachedResource::CachedResource): store a ResourceResponse;
3602         platform response is now called platformResponse and expiration date
3603         is removed.
3604         (WebCore::CachedResource::~CachedResource): ditto
3605         (WebCore::CachedResource::isExpired): ditto
3606         * loader/CachedResource.h:
3607         (WebCore::CachedResource::platformResponse): ditto
3608         (WebCore::CachedResource::setResponse): ditto
3609         (WebCore::CachedResource::canDelete): ditto
3610         * loader/LoaderFunctions.h:
3611         * loader/loader.cpp:
3612         (WebCore::Loader::receivedResponse): Adjusted for renames.
3613         (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
3614         in the CachedResource.
3615         * loader/loader.h:
3616         * loader/mac/FormDataStream.h:
3617         * loader/mac/FormDataStream.m:
3618         (WebCore::getStreamFormDatas): Rearranged things so it's
3619         possible to get a FormData back out of a form data stream.
3620         (WebCore::formCreate): ditto
3621         (WebCore::formFinalize): ditto
3622         (WebCore::httpBodyFromStream): ditto
3623         * loader/mac/ImageDocumentMac.mm:
3624         (WebCore::finishImageLoad): s/response/platformResponse/
3625         * loader/mac/LoaderFunctionsMac.mm:
3626         (WebCore::CheckCacheObjectStatus): ditto
3627         (WebCore::CachedResource::setPlatformResponse): ditto
3628         * loader/mac/SubresourceLoaderMac.mm:
3629         (WebCore::SubresourceLoader::willSendRequest): send redirect
3630         to client appropriately
3631         * platform/network/ResourceHandle.h:
3632         * platform/network/ResourceHandleClient.h:
3633         (WebCore::ResourceHandleClient::willSendRequest): new entry
3634         point for SubresourceLoader, dispatch to client.
3635         * platform/network/ResourceRequest.h:
3636         (WebCore::ResourceRequest::allowHTTPCookies): implemented
3637         (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
3638         * platform/network/ResourceResponse.h:
3639         (WebCore::ResourceResponse::ResourceResponse): initialize expiration
3640         date(!)
3641         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
3642         (WebCore::getStreamFormDatas): Added this, ported from NSURL version.
3643         (WebCore::openNextStream): ditto
3644         (WebCore::formCreate): ditto
3645         (WebCore::formFinalize): ditto
3646         (WebCore::formCanRead): ditto
3647         (WebCore::formEventCallback): ditto
3648         (WebCore::setHTTPBody): ditto
3649         (WebCore::httpBodyFromStream): ditto
3650         * platform/network/cf/FormDataStreamCFNet.h: Added.
3651         * platform/network/cf/ResourceHandleCFNet.cpp:
3652         (WebCore::willSendRequest): implemented
3653         (WebCore::ResourceHandle::start): use new ResourceRequest stuff
3654         * platform/network/cf/ResourceResponseCFNet.cpp:
3655         (WebCore::getResourceResponse): do nothing for a null response
3656         * platform/network/mac/ResourceHandleMac.mm:
3657         (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
3658         * platform/network/mac/ResourceRequestMac.h: Added.
3659         * platform/network/mac/ResourceRequestMac.mm: Added.
3660         (WebCore::getResourceRequest): Added way to convert an NSURLRequest
3661         to a ResourceRequest.
3662         (WebCore::nsURLRequest): Opposite of the above.
3663         * platform/network/cf/ResourceRequestCFNet.h: Added.
3664         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
3665         (WebCore::getResourceRequest): Added way to convert an CFURLRequest
3666         to a ResourceRequest.
3667         (WebCore::cfURLRequest): Opposite of the above.
3668         * xml/xmlhttprequest.cpp:
3669         (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
3670         adjusted.
3671         * xml/xmlhttprequest.h:
3672
3673 2006-11-04  Darin Adler  <darin@apple.com>
3674
3675         Change suggested by Mitz.
3676
3677         - fix http://bugs.webkit.org/show_bug.cgi?id=11514
3678           REGRESSION (r17438): Repro crash when opening a web archive
3679
3680         * bridge/mac/WebCorePageState.mm:
3681         (-[WebCorePageState dealloc]): Add null check.
3682         (-[WebCorePageState finalize]): Ditto.
3683
3684 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
3685
3686         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
3687
3688         http://bugs.webkit.org/show_bug.cgi?id=11433
3689         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
3690
3691         * WebCore.vcproj/WebCore/WebCore.vcproj:
3692         Added platform/graphics platform/network and platform/network/win to headers search paths
3693         Created platform/graphics and platform/network filters in hierarchy
3694         Moved GraphicsContext and GraphicsTypes to their respective filters
3695         Added EditorClient.h
3696         Added FrameLoader* files in loader/
3697         Added HitTest* files in rendering/
3698         Added Editor.* files in editing/
3699         Added DeleteButton.* and DeleteButtonController.* in editing/
3700
3701         * bridge/win/ChromeClientWin.h: Added.
3702         (WebCore::ChromeClientWin::~ChromeClientWin):
3703         * bridge/win/EditorClientWin.h: Added.
3704         (WebCore::EditorClientWin::~EditorClientWin):
3705
3706         * bridge/win/FrameWin.cpp:
3707         (WebCore::FrameWin::FrameWin):
3708         (WebCore::FrameWin::urlSelected):
3709         (WebCore::FrameWin::submitForm):
3710         (WebCore::FrameWin::createNewWindow):
3711         * bridge/win/FrameWin.h:
3712         Added EditorClient parameter to constructor
3713         Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
3714         Removed openURL() and openURLRequest from class definition
3715
3716         * bridge/win/PageWin.cpp:
3717         * platform/AffineTransform.h:
3718         * platform/cairo/AffineTransformCairo.cpp: Added.
3719         (WebCore::AffineTransform::AffineTransform):
3720         (WebCore::AffineTransform::setMatrix):
3721         (WebCore::AffineTransform::map):
3722         (WebCore::AffineTransform::mapRect):
3723         (WebCore::AffineTransform::isIdentity):
3724         (WebCore::AffineTransform::m11):
3725         (WebCore::AffineTransform::m12):
3726         (WebCore::AffineTransform::m21):
3727         (WebCore::AffineTransform::m22):
3728         (WebCore::AffineTransform::dx):
3729         (WebCore::AffineTransform::dy):
3730         (WebCore::AffineTransform::reset):
3731         (WebCore::AffineTransform::scale):
3732         (WebCore::AffineTransform::rotate):
3733         (WebCore::AffineTransform::translate):
3734         (WebCore::AffineTransform::shear):
3735         (WebCore::AffineTransform::det):
3736         (WebCore::AffineTransform::invert):
3737         (WebCore::AffineTransform::operator cairo_matrix_t):
3738         (WebCore::AffineTransform::operator== ):
3739         (WebCore::AffineTransform::operator*= ):
3740         (WebCore::AffineTransform::operator* ):
3741         * platform/cairo/GraphicsContextCairo.cpp:
3742         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3743         * platform/network/win/ResourceHandleWin.cpp:
3744         (WebCore::ResourceHandle::onHandleCreated):
3745         (WebCore::ResourceHandle::start):
3746         (WebCore::ResourceHandle::fileLoadTimer):
3747         (WebCore::ResourceHandle::cancel):
3748         * platform/win/TemporaryLinkStubs.cpp:
3749         (WebCore::FrameWin::goBackOrForward):
3750         (WebCore::FrameWin::getHistoryLength):
3751         (WebCore::FrameWin::historyURL):
3752         (WebCore::ServeSynchronousRequest):
3753         (WebCore::ChromeClientWin::canRunModal):
3754         (WebCore::ChromeClientWin::runModal):
3755         (WebCore::EditorClientWin::shouldDeleteRange):
3756         (WebCore::EditorClientWin::shouldShowDeleteInterface):
3757         (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
3758         (WebCore::EditorClientWin::isGrammarCheckingEnabled):
3759         (WebCore::EditorClientWin::spellCheckerDocumentTag):
3760         (WebCore::Path::transform):
3761         (WebCore::PopupMenu::updateFromElement):
3762         (WebCore::ResourceLoader::loadsBlocked):
3763         (WebCore::systemBeep):
3764         * rendering/RenderThemeWin.cpp:
3765         (WebCore::RenderThemeWin::paintButton):
3766         (WebCore::RenderThemeWin::paintTextField):
3767
3768 2006-11-04  Alexey Proskuryakov  <ap@nypop.com>
3769
3770         Reviewed by Maciej.
3771
3772         http://bugs.webkit.org/show_bug.cgi?id=11448
3773         &lang; and &rang; entities are mapped to the incorrect Unicode codepoint
3774
3775         * html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
3776
3777 2006-11-03  Mark Rowe  <bdash@webkit.org>
3778
3779         Reviewed by Oliver.
3780
3781         Update Windows and Qt project files for file removals in r17585.
3782
3783         * CMakeLists.txt:
3784         * WebCore.vcproj/WebCore/WebCore.vcproj:
3785
3786 2006-11-03  Zack Rusin  <zack@kde.org>
3787
3788         Reviewed by Maciej.
3789
3790         The patch fixes text field drawing on the Qt platform.
3791
3792         * platform/qt/RenderThemeQt.cpp:
3793         (WebCore::RenderThemeQt::paintTextField): Use the style to correctly
3794         render the text field
3795
3796 2006-11-03  Oliver Hunt  <oliver@apple.com>
3797
3798         Reviewed by Tim.
3799
3800         Correct incorrect call to SetCursor
3801
3802         * rendering/RenderFrameSet.cpp:
3803         (WebCore::RenderFrameSet::userResize):
3804
3805 2006-11-03  Adele Peterson  <adele@apple.com>
3806
3807         Reviewed by Oliver.
3808
3809         Removed DeprecatedRenderSelect and ListBox classes.
3810
3811         * WebCore.xcodeproj/project.pbxproj:
3812         * css/html4.css:
3813         * html/HTMLOptionElement.h:
3814         * html/HTMLSelectElement.cpp:
3815         (WebCore::HTMLSelectElement::recalcStyle):
3816         (WebCore::HTMLSelectElement::isKeyboardFocusable):
3817         (WebCore::HTMLSelectElement::isMouseFocusable):
3818         (WebCore::HTMLSelectElement::createRenderer):
3819         (WebCore::HTMLSelectElement::setRecalcListItems):
3820         (WebCore::HTMLSelectElement::notifyOptionSelected):
3821         (WebCore::HTMLSelectElement::defaultEventHandler):
3822         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
3823         (WebCore::HTMLSelectElement::updateListBoxSelection):
3824         * html/HTMLSelectElement.h:
3825         * platform/ListBox.h: Removed.
3826         * platform/mac/FontCacheMac.mm:
3827         * platform/mac/ListBoxMac.mm: Removed.
3828         * platform/win/TemporaryLinkStubs.cpp:
3829         * rendering/DeprecatedRenderSelect.cpp: Removed.
3830         * rendering/DeprecatedRenderSelect.h: Removed.
3831
3832 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3833
3834         Not reviewed, fix for accidental commit.
3835
3836         - rolled back more of the accidentall commit that I forgot.
3837
3838         * platform/network/mac/ResourceRequestMac.h: Removed.
3839         * platform/network/mac/ResourceRequestMac.mm: Removed.
3840
3841 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
3842
3843         Not reviewed, fix for accidental commit.
3844
3845         - roll back some network changes accidentally committed with a previous patch.
3846
3847         * WebCore.xcodeproj/project.pbxproj:
3848         * bridge/mac/WebCoreFrameBridge.mm:
3849         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3850         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3851         * loader/CachedCSSStyleSheet.cpp:
3852         (WebCore::CachedCSSStyleSheet::checkNotify):
3853         * loader/CachedImage.cpp:
3854         (WebCore::CachedImage::createImage):
3855         * loader/CachedResource.cpp:
3856         (WebCore::CachedResource::CachedResource):
3857         (WebCore::CachedResource::~CachedResource):
3858         (WebCore::CachedResource::setExpireDate):
3859         (WebCore::CachedResource::isExpired):
3860         * loader/CachedResource.h:
3861         (WebCore::CachedResource::response):
3862         * loader/LoaderFunctions.h:
3863         * loader/loader.cpp:
3864         (WebCore::Loader::receivedResponse):
3865         (WebCore::Loader::didReceivedResponse):
3866         * loader/loader.h:
3867         * loader/mac/FormDataStream.h:
3868         * loader/mac/FormDataStream.m:
3869         (WebCore::formCreate):
3870         (WebCore::formFinalize):
3871         * loader/mac/ImageDocumentMac.mm:
3872         (WebCore::finishImageLoad):
3873         * loader/mac/LoaderFunctionsMac.mm:
3874         (WebCore::CheckCacheObjectStatus):
3875         (WebCore::CachedResource::setResponse):
3876         * loader/mac/SubresourceLoaderMac.mm:
3877         (WebCore::SubresourceLoader::willSendRequest):
3878         * platform/network/ResourceHandle.h:
3879         * platform/network/ResourceHandleClient.h:
3880         (WebCore::ResourceHandleClient::receivedRedirect):
3881         * platform/network/ResourceRequest.h:
3882         * platform/network/ResourceResponse.h:
3883         (WebCore::ResourceResponse::ResourceResponse):
3884         * platform/network/mac/ResourceHandleMac.mm:
3885         (WebCore::ResourceHandle::redirectedToURL):
3886         * xml/xmlhttprequest.cpp:
3887         (WebCore::XMLHttpRequest::receivedRedirect):
3888         * xml/xmlhttprequest.h:
3889
3890 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3891
3892         Rubber-stamped by Oliver.
3893
3894         Remove these, they have been merged with SVGRenderTreeAsText.
3895         
3896         * rendering/SVGRenderAsText.cpp: Removed.
3897         * rendering/SVGRenderAsText.h: Removed.
3898
3899 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
3900
3901         Build fix.
3902         
3903         * platform/network/cf/ResourceHandleCFNet.cpp:
3904         (WebCore::willSendRequest):
3905
3906 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
3907
3908         Reviewed by Darin, Beth.
3909         
3910         First cut at factoring Page's UIDelegate-related functions into Chrome
3911         and ChromeClient.
3912
3913         Layout tests pass.
3914         
3915         * bridge/mac/PageMac.mm: Removed platform-specific constructor, added
3916         setBridge method to replace it.
3917         (WebCore::Page::setBridge):
3918
3919         * bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact
3920         that WebCorePageBridge.h doesn't need to be included by ObjC-only files,
3921         and, now that it uses PassRefPtr, can't be.
3922         
3923         * page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
3924
3925         * page/Page.h:
3926         (WebCore::Page::dragCaretController): Made this function non-const so that
3927         m_dragCaretController doesn't have to be mutable.
3928
3929 2006-11-03  Alexey Proskuryakov  <ap@nypop.com>
3930
3931         Reviewed by Adele.
3932
3933         http://bugs.webkit.org/show_bug.cgi?id=7323
3934         REGRESSION (10.4.4): ondrag* events don't fire on page in a frame
3935
3936         * bridge/mac/FrameMac.h: Moved drag source information to a static variable
3937         in FrameMac.mm. There can be only one drag active at any moment, and having 
3938         this information here was making sharing this information between 
3939         subframes hard.
3940
3941         * bridge/mac/FrameMac.mm:
3942         (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo.
3943         (WebCore::FrameMac::freeClipboard):
3944         (WebCore::FrameMac::dragHysteresisExceeded):
3945         (WebCore::FrameMac::handleMouseMoveEvent):
3946         (WebCore::FrameMac::handleMouseReleaseEvent):
3947         (WebCore::FrameMac::mouseDown):
3948         (WebCore::FrameMac::dragSourceMovedTo):
3949         (WebCore::FrameMac::dragSourceEndedAt):
3950         (WebCore::FrameMac::dispatchDragSrcEvent):
3951         Access drag source info via sharedDragInfo - this fixes drag source even dispatching.
3952         Also removed some old code that was forwarding mouse events to subviews to make 
3953         HTML editing work in subframes.
3954
3955         * page/FrameView.cpp:
3956         (WebCore::FrameView::updateDragAndDrop):
3957         (WebCore::FrameView::cancelDragAndDrop):
3958         (WebCore::FrameView::performDragAndDrop):
3959         Forward events to subframes for dispatching - this fixes drag target events.
3960
3961 2006-11-03  Zack Rusin  <zack@kde.org>
3962
3963         Reviewed by Tim.
3964
3965         Fixing compile.
3966
3967         * platform/qt/LoaderFunctionsQt.cpp:
3968         (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
3969
3970 2006-11-01  Zack Rusin  <zack@kde.org>
3971
3972         Reviewed by Maciej.
3973
3974         Moving the word/sentence seperators into a file of their own
3975         and implementing findWordBoundary.
3976
3977         * CMakeLists.txt:
3978         * platform/qt/TemporaryLinkStubs.cpp:
3979         * platform/qt/TextBoundaries.cpp: Added.
3980         (WebCore::findNextSentenceFromIndex):
3981         (WebCore::findSentenceBoundary):
3982         (WebCore::findNextWordFromIndex):
3983         (WebCore::findWordBoundary):
3984
3985 2006-11-03  Zack Rusin  <zack@kde.org>
3986
3987         Reviewed by Maciej.
3988
3989         Compile on both KDE and Qt platforms
3990
3991         * CMakeLists.txt: add zlib explicitly
3992         * platform/network/qt/ResourceHandleManager.cpp:
3993         (WebCore::ResourceHandleManager::self):
3994         (WebCore::QtJob::QtJob):
3995         (WebCore::QtJob::timerEvent): Integrate both implementations
3996         so that moc can parse it
3997         (WebCore::ResourceHandleManager::deliverJobData):
3998         (WebCore::ResourceHandleManager::remove):
3999         * platform/network/qt/ResourceHandleManager.h:
4000
4001 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
4002
4003         No review, suggested by Mitz.
4004
4005         - fix a #if to be #ifdef
4006
4007         * platform/graphics/svg/cg/SVGResourceImageCg.cpp:
4008
4009 2006-11-03  Zack Rusin  <zack@kde.org>
4010
4011         Reviewed and landed by Maciej.
4012         
4013         Compile on the Qt platform.
4014
4015         * ksvg2/misc/KCanvasRenderingStyle.h:
4016         * platform/qt/RenderThemeQt.cpp:
4017         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
4018
4019 2006-11-03  Zack Rusin  <zack@kde.org>
4020
4021         Reviewed by Hyatt. Landed by Maciej.
4022
4023         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
4024         to graphics context to be able to set consistant state
4025         on the platform specific painter without having to change
4026         fill/stroke/font on every operation. This fixes color/stroke/fill
4027         and font handling in the Qt port.
4028
4029         * platform/graphics/GraphicsContext.cpp:
4030         (WebCore::GraphicsContext::setFont):
4031         (WebCore::GraphicsContext::setPen):
4032         (WebCore::GraphicsContext::setFillColor):
4033         (WebCore::GraphicsContext::setPlatformPen):
4034         (WebCore::GraphicsContext::setPlatformFillColor):
4035         (WebCore::GraphicsContext::setPlatformFont):
4036         * platform/graphics/GraphicsContext.h:
4037         * platform/qt/GraphicsContextQt.cpp:
4038         (WebCore::toQtCompositionMode):
4039         (WebCore::toQtLineCap):
4040         (WebCore::toQtLineJoin):
4041         (WebCore::toQPenStyle):
4042         (WebCore::penToQPen):
4043         (WebCore::TransparencyLayer::TransparencyLayer):
4044         (WebCore::GraphicsContext::addRoundedRectClip):
4045         (WebCore::GraphicsContext::setPlatformFont):
4046         (WebCore::GraphicsContext::setPlatformPen):
4047         (WebCore::GraphicsContext::setPlatformFillColor):
4048         * platform/qt/ScrollViewCanvasQt.cpp:
4049         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
4050         (WebCore::ScrollViewCanvasQt::paintEvent):
4051         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
4052         * platform/qt/ScrollViewCanvasQt.h:
4053
4054 2006-11-02  Adele Peterson  <adele@apple.com>
4055
4056         Reviewed by Anders.
4057
4058         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
4059         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
4060
4061         Test: fast/forms/textarea-no-scroll-on-blur.html
4062
4063         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
4064           On blur, only scroll back to the start for text fields.
4065
4066 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
4067
4068         Another build fix.
4069         
4070         * rendering/RenderFileUploadControl.cpp:
4071         (WebCore::RenderFileUploadControl::paintObject):
4072
4073 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
4074
4075         Build fix.
4076         
4077         * page/FramePrivate.h:
4078         (WebCore::FramePrivate::FramePrivate):
4079
4080 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
4081
4082         Reviewed by Geoff, landed by Anders.
4083         
4084         Fix dependency problems caused when running move-js-headers.sh
4085         
4086         * move-js-headers.sh:
4087         Use cp -p instead of just cp so that the modification time
4088         of the original files are used.
4089
4090 2006-11-02  Adam Roben  <aroben@apple.com>
4091
4092         Reviewed by Tim H, landed by Anders.
4093
4094         Fixes http://bugs.webkit.org/show_bug.cgi?id=10840
4095         REGRESSION: Shadow of file upload button is clipped
4096
4097         * rendering/RenderFileUploadControl.cpp:
4098         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
4099         height to keep from clipping in the shadow
4100
4101 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
4102
4103         Reviewed by Maciej, landed by Anders.
4104
4105         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
4106         content and window. ScrollViewQt already receives correct content
4107         coordinates from QScrollArea.
4108         (WebCore::ScrollView::contentsToWindow):
4109         (WebCore::ScrollView::windowToContents):
4110
4111 2006-11-02  Simon Hausmann  <hausmann@kde.org>
4112
4113         Reviewed by Maciej, landed by Anders
4114
4115         * CMakeLists.txt: Make linkage against KDE libraries conditional
4116         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
4117           Qt base resource handler that supports only requests to the
4118           local filesystem. Used when compiling without KDE support.
4119           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
4120           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
4121         (WebCore::QtJob::QtJob):
4122         (WebCore::QtJob::timerEvent):
4123         (WebCore::ResourceHandleManager::ResourceHandleManager):
4124         (WebCore::ResourceHandleManager::~ResourceHandleManager):
4125         (WebCore::ResourceHandleManager::self):
4126         (WebCore::ResourceHandleManager::remove):
4127         (WebCore::ResourceHandleManager::add):
4128         (WebCore::ResourceHandleManager::cancel):
4129         (WebCore::ResourceHandleManager::deliverJobData):
4130         * platform/network/qt/ResourceHandleManager.h:
4131         * platform/qt/FrameQtClient.cpp:
4132         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
4133         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
4134         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
4135         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
4136           input dialog functions when compiling without KDE support
4137         (WebCore::ServeSynchronousRequest):
4138
4139 2006-11-02  David Carson  <dacarson@gmail.com>
4140
4141         Reviewed by Geoff, landed by Anders.
4142
4143         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
4144         Initializing variable in constructor.
4145
4146         * page/FramePrivate.h:
4147         (WebCore::FramePrivate::FramePrivate):
4148
4149 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
4150
4151         Reviewed by Geoff.
4152
4153         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
4154         
4155         * platform/network/cf/ResourceHandleCFNet.cpp:
4156         (WebCore::addHeadersFromHashMap):
4157         Don't set all headers at once since that clears any previous headers set.
4158         
4159         (WebCore::ResourceHandle::start):
4160
4161 2006-11-02  Adele Peterson  <adele@apple.com>
4162
4163         Reviewed by Mitz and Geoff.
4164
4165         - Fix for:
4166         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
4167         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
4168         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
4169
4170         Test: fast/forms/textarea-scrollbar.html
4171
4172         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
4173         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
4174
4175         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
4176         * rendering/RenderTextControl.cpp: 
4177         (WebCore::RenderTextControl::RenderTextControl):
4178         (WebCore::RenderTextControl::setStyle):
4179         (WebCore::RenderTextControl::createDivStyle):
4180         (WebCore::RenderTextControl::updateFromElement):
4181         (WebCore::RenderTextControl::calcHeight):
4182         (WebCore::RenderTextControl::baselinePosition):
4183         (WebCore::RenderTextControl::nodeAtPoint):
4184         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
4185         (WebCore::RenderTextControl::scrollWidth):
4186         (WebCore::RenderTextControl::scrollHeight):
4187         (WebCore::RenderTextControl::scrollLeft):
4188         (WebCore::RenderTextControl::scrollTop):
4189
4190         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
4191
4192 2006-11-02  John Sullivan  <sullivan@apple.com>
4193
4194         Reviewed by Geoff Garen
4195
4196         * editing/Selection.cpp:
4197         (WebCore::Selection::showTreeForThis):
4198         this debugging method now displays start offset and end offset, at Darin's suggestion
4199