Reviewed by mjs
[WebKit-https.git] / WebCore / ChangeLog
1 2006-04-05  Justin Garcia  <justin.garcia@apple.com>
2
3         Reviewed by mjs
4
5         I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
6         so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
7         implicit removes.
8
9         * editing/ReplaceSelectionCommand.cpp:
10         (WebCore::ReplaceSelectionCommand::doApply):
11
12 2006-04-05  Maciej Stachowiak  <mjs@apple.com>
13
14         Reviewed by Anders.
15
16         - autogenerate bindings for all of the methods and properties of Document
17         http://bugzilla.opendarwin.org/show_bug.cgi?id=8163
18
19         - also removed document.actualEncoding since it is not in any spec
20         or implemented by any other browser
21         
22         * DerivedSources.make: add JSDocument.h to results
23         * WebCore.xcodeproj/project.pbxproj: Added new files to project
24         * bindings/scripts/CodeGeneratorJS.pm: Support for new stuff needed by Document.
25         * dom/Document.cpp:
26         (WebCore::Document::readyState): moved impl here from JS bindings
27         (WebCore::Document::inputEncoding): ditto
28         (WebCore::Document::defaultCharset): ditto
29         (WebCore::Document::setCharset): ditto
30         * dom/Document.h:
31         (WebCore::Document::charset): added, synonym for inputEncoding.
32         (WebCore::Document::characterSet): ditto
33         * dom/Document.idl: Added. Full interface for the Document object.
34         * khtml/ecma/JSXMLHttpRequest.cpp:
35         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): JSDocument, not DOMDocument
36         * khtml/ecma/JSXSLTProcessor.cpp:
37         (KJS::XSLTProcessorProtoFunc::callAsFunction): ditto
38         * khtml/ecma/kjs_binding.cpp:
39         (KJS::jsStringOrFalse): Added this convenience for the method on Document
40         that bizzarely returns false on failure and a string otherwise.
41         * khtml/ecma/kjs_binding.h:
42         * khtml/ecma/kjs_css.cpp:
43         (KJS::toJS): renamed for consistency
44         * khtml/ecma/kjs_css.h:
45         * khtml/ecma/kjs_dom.cpp:
46         - removed all traces of DOMDocument
47         (KJS::toJS): JSDocument, not DOMDocument
48         * khtml/ecma/kjs_dom.h:
49         * khtml/ecma/kjs_html.cpp:
50         (KJS::):
51         (KJS::JSHTMLDocument::JSHTMLDocument): inherit from JSDocument
52         (KJS::JSHTMLDocument::getOwnPropertySlot): ditto
53         (KJS::JSHTMLDocument::put): ditto
54         * khtml/ecma/kjs_html.h:
55         * khtml/ecma/kjs_traversal.cpp:
56         (KJS::toJS): added overloads
57         (KJS::toNodeFilter): handle JS functions as well as impl NodeFilter objects
58         * khtml/ecma/kjs_traversal.h:
59         * platform/AtomicString.h:
60         (WebCore::AtomicString::AtomicString): Allow implicit conversion from String.
61
62 2006-04-05  Justin Garcia  <justin.garcia@apple.com>
63
64         Reviewed by darin
65         
66         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
67         Hitting an assert on undo paste
68         
69         ReplaceSelectionCommand was doing a combination of undoable and non-undoable 
70         removes from the ReplacementFragment.  On Undo Paste, the undoable removes 
71         couldn't be undone because the tree was in a different state than it was
72         at the time of the remove.  This patch makes all the removes from the fragment 
73         non-undoable.  We could make them all undoable, but I can't think of any reason 
74         why we'd want the fragment to be reconstructed on an Undo Paste.
75
76         * editing/AppendNodeCommand.cpp:
77         (WebCore::AppendNodeCommand::doApply):
78         Assert that the node to append isn't already in a tree, since if it is, it will 
79         be removed in a non-undoable way.
80         * editing/InsertNodeBeforeCommand.cpp:
81         (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
82         * editing/ReplaceSelectionCommand.cpp:
83         (WebCore::ReplaceSelectionCommand::doApply): 
84         Nodes were being moved from the fragment to the document with undoable inserts.  
85         Undoable inserts implicitly remove the node (in a non-undoable way) from its 
86         old location if it is already in a tree.  I now explicitly remove the nodes 
87         from the fragment before inserting them into the document to make it clear that 
88         they are being removed in a non-non-undoable way.  I also changed the one undoable 
89         remove from the fragment to a non-undoable remove.
90         * editing/ReplaceSelectionCommand.h: 
91         Made ReplacementFragment's non-undoable removeNode public.
92
93 2006-04-05  Darin Adler  <darin@apple.com>
94
95         - fixed the build
96
97         * WebCore.xcodeproj/project.pbxproj: Oops! Resolved merge conflict.
98
99 2006-04-05  Darin Adler  <darin@apple.com>
100
101         Reviewed by Maciej.
102
103         - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8049
104           StringImpl hash traits deleted value creates an init routine for WebCore
105           <rdar://problem/4442248> REGRESSION: WebCore has init routines (8049)
106
107         * platform/StringHash.h: Added. Moved hash functions and such for
108         WebCore::String and friends into this file so we don't have to include
109         the hash traits header everywhere. Changed hashing for WebCore::StringImpl
110         and WebCore::String so that they use a raw pointer for the underlying
111         storage type, taking advantage of the new feature added in JavaScriptCore.
112
113         * platform/AtomicString.h: Moved StrHash specialization to StringHash.h.
114         * platform/PlatformString.h: Moved StrHash specialization to StringHash.h.
115         * platform/StringImpl.h: Moved StrHash, CaseInsensitiveHash, and HashTraits
116         to StringHash.h. Left DefaultHash behind so that you can't get the wrong
117         hash function by accident if you forget to include "StringHash.h".
118
119         * platform/StringImpl.cpp: Added include of StringHash.h and removed
120         RefPtr<StringImpl> HashTraits<RefPtr<StringImpl> >::_deleted, which is
121         the object with a global initializer causing all the trouble!
122
123         * kwq/AccessibilityObjectCache.h: Changed hash function to be IntHash
124         instead of PtrHash.
125
126         * dom/StyledElement.cpp: Changed MappedAttributeKeyTraits to inherit from
127         the generic traits in KXMLCore so we get a StorageType. Also cleaned up a
128         tiny bit by adding default values to the MappedAttributeKey constructor.
129
130         * platform/CharsetNames.cpp: Changed hash traits here to be a new
131         TextEncodingIDHashTraits struct rather than defining new default traits
132         for the integer type since more integer types have default traits in
133         HashTraits.h now. Also added a specialization so this class will share
134         the underlying implementation (since InvalidEncoding happens to be -1).
135
136         * bridge/mac/FrameMac.h:
137         * dom/Document.h:
138         * dom/xml_tokenizer.h:
139         * khtml/xsl/XSLTProcessor.h:
140         * kwq/JavaAppletWidget.h:
141         * page/FramePrivate.h:
142         * page/Page.cpp:
143         * platform/AtomicString.cpp:
144         * platform/TransferJob.h:
145         * rendering/render_applet.h:
146         Added include of StringHash.h.
147
148         * WebCore.xcodeproj/project.pbxproj: Added StringHash.h. Remove unneeded
149         CREATE_HASH_TABLE variable in build settings. Re-sorted some file lists.
150         Added quotes to the CREATE_HASH_TABLE initialization in the rule that
151         builds generated files. Removed various unneeded build settings for that
152         target as well.
153
154         * ForwardingHeaders/kxmlcore/HashTraits.h: Added.
155
156         - other minor cleanup
157
158         * bridge/mac/FrameMac.mm: Sorted includes.
159         * dom/Node.cpp: Removed bogus symbol after #endif.
160
161         * khtml/xsl/XSLTProcessor.cpp: Sorted includes. Removed redundant using
162         namespace WebCore.
163         * loader/Cache.cpp: Ditto.
164
165 2006-04-05  Beth Dakin  <bdakin@apple.com>
166
167         Reviewed by Darin.
168
169         Fix for <rdar://problem/4502311> text-transform:capitalize needs to 
170         treat nbsp as a regular space when ICU changes
171
172         There will be future changes in ICU to match the Unicode 4.1 
173         standard which no longer recognizes &nbsp as a word separator. We 
174         need to work around this with text-transform:capitalize because 
175         words after non-breaking spaces still need to be capitalized.
176
177         No layout tests added because existing layout tests cover this.
178
179         * platform/StringImpl.cpp:
180         (WebCore::StringImpl::capitalize): If the character is a non-
181         breaking space, add a regular space to our temporary buffer, 
182         otherwise, just copy the character in.
183
184 2006-04-05  Alexey Proskuryakov  <ap@nypop.com>
185
186         Reviewed by Darin.
187
188         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8110
189           Define navigator.vendorSub (bcms.gov.uk doesn't allow access to login page)
190
191         Test: fast/dom/navigator-vendorSub.html
192
193         * khtml/ecma/kjs_navigator.cpp:
194         (KJS::Navigator::getValueProperty): Return an empty string for vendorSub property.
195         * khtml/ecma/kjs_navigator.h:
196
197 2006-04-04  Darin Adler  <darin@apple.com>
198
199         Reviewed by Justin (editing parts) and Adele (the rest).
200
201         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8182
202           some text-field-related layout tests are failing
203
204         The smart paste code was getting confused and adding extra spaces.
205
206         * editing/ReplaceSelectionCommand.cpp:
207         (WebCore::ReplaceSelectionCommand::doApply): Use isStartOfParagraph instead of
208         isStartOfLine.
209         (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto.
210
211         * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::enclosingEmptyListItem):
212         Change to call isStart/EndOfParagraph instead of Line.
213
214         * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
215         Add a comment about how isStartOfLine is almost certainly wrong here.
216
217         - clean up some loose ends in the Frame class from the recent renaming
218
219         * page/Frame.h: Removed declarations of deleteMe1, deleteMe2, and
220         handleMouseMoveEventPart2.
221         * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): Removed
222         handleMouseMoveEventPart2 by renaming it to handleMouseMoveEvent and removing
223         handleMouseMoveEvent itself.
224
225         - invoke the makefile directly, removing the generate-derived-sources script
226
227         * WebCore.vcproj/WebCore/build-generated-files.sh: Call make directly.
228         * WebCore.xcodeproj/project.pbxproj: Ditto.
229         * generate-derived-sources: Removed.
230
231 2006-04-04  Adele Peterson  <adele@apple.com>
232
233         Reviewed by Justin.
234
235         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8158
236         REGRESSION: Clicking past RTL text in a new text field puts the caret on the wrong side of the text
237
238         Tests:
239         editing/selection/caret-rtl.html
240         editing/selection/caret-rtl-2.html
241
242         * rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
243         When calculating the position for the beginning or end of an InlineTextBox,
244         we now use offsetForPosition instead of just using m_start and m_len, because
245         offsetForPosition will take rtl text into account.  I also made some formatting
246         changes.
247
248 2006-04-04  David Hyatt  <hyatt@apple.com>
249
250         Fix for bug 8065, inline blocks incorrectly loses spaces between them.
251
252         Reviewed by beth
253
254         * dom/Text.cpp:
255         (WebCore::Text::rendererIsNeeded):
256
257 2006-04-04  Adele Peterson  <adele@apple.com>
258
259         Reviewed by Hyatt.
260
261         - Fix for:
262         http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
263         REGRESSION (NativeTextField): table contents misaligned in Netflix queue
264
265         http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
266         REGRESSION: Native text field fails to wrap inside table
267
268         http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
269         REGRESSION: text fields at connect.apple.com spill out of the containing box
270
271         Test: fast/forms/input-table.html
272
273         Rewrote calcMinMaxWidth for text fields so it considers width, 
274         min-width, and max-width settings as well as the size attribute.
275
276         * rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
277
278 2006-04-04  Beth Dakin  <bdakin@apple.com>
279
280         Reviewed by Darin.
281
282         This is a followup to my fix for <rdar://problem/4493218>
283         
284         This patch re-names computeIntLength() and computerShortLength() to 
285         be computeLengthInt() and computeLengthShort(), respectively, to 
286         match the pre-existing computeLengthFloat(). This patch also adds 
287         the slightly confusing-ly named computeLengthIntForLength() which 
288         uses the max and min values of a 28-bit integer as bounds for 
289         overflow. This function is necessary because Length objects expect 
290         28-bit integers. 
291
292         * css/css_valueimpl.cpp:
293         (WebCore::CSSPrimitiveValue::computeLengthInt):
294         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
295         (WebCore::CSSPrimitiveValue::computeLengthShort):
296         * css/css_valueimpl.h:
297         * css/cssstyleselector.cpp:
298         (WebCore::convertToLength):
299         (WebCore::CSSStyleSelector::applyProperty):
300         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
301         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
302
303 2006-04-04  Timothy Hatcher  <timothy@apple.com>
304
305         Reviewed by Darin.
306
307         The Debug and Release frameworks are now built with install paths relative to the build products directory.
308         This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore. 
309
310         * WebCore.xcodeproj/project.pbxproj:
311
312 2006-04-04  Justin Garcia  <justin.garcia@apple.com>
313
314         Reviewed by darin
315         
316         <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
317         REGRESSION: Line disappears when deleting
318         
319         Rewrote moveNodesAfterNode to address these problems:
320         It moved nodes without preserving their style. 
321         It traversed over siblings looking for a br to know when
322         to stop merging.  If the br was burried inside a span, it 
323         wouldn't find it.  If the text is whitespace:pre, it wouldn't
324         stop.
325         In theory it would crash if the "enclosingInlineElements" of the start of the
326         selection to delete and the end of the selection to delete were the
327         same.  We think that this will fix these:
328         <rdar://problems/3950559&4498113>
329         CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
330         CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
331         But we haven't been able to construct a reproducible case.
332         
333         * editing/CompositeEditCommand.cpp:
334         (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand.
335         (WebCore::CompositeEditCommand::prune): Ditto.
336         * editing/CompositeEditCommand.h:
337         * editing/DeleteSelectionCommand.cpp:
338         (WebCore::DeleteSelectionCommand::mergeParagraphs):
339         (WebCore::DeleteSelectionCommand::doApply):
340         * editing/DeleteSelectionCommand.h:
341         * editing/ReplaceSelectionCommand.cpp:
342         (WebCore::ReplaceSelectionCommand::doApply):
343         * editing/ReplaceSelectionCommand.h:
344         (WebCore::):
345         * editing/markup.cpp:
346         (WebCore::createMarkup): 
347         Was crashing when passed a collapsed range.  I early return an empty string instead.
348
349 2006-04-04  John Sullivan  <sullivan@apple.com>
350
351         Reviewed by Adele Peterson.
352         
353         - WebCore part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
354
355         * bridge/mac/WebCoreSettings.h:
356         * bridge/mac/WebCoreSettings.mm:
357         (-[WebCoreSettings setPrivateBrowsingEnabled:]):
358         (-[WebCoreSettings privateBrowsingEnabled]):
359         Teach WebCoreSettings about private browsing (WebKit knew, but WebCore didn't)
360         
361         * kwq/KWQKHTMLSettings.h:
362         (KHTMLSettings::privateBrowsingEnabled):
363         (KHTMLSettings::setPrivateBrowsingEnabled):
364         Teach KHTMLSettings about private browsing
365         
366         * kwq/KWQLineEdit.mm:
367         Fix wrong class in a category method declaration; the compiler didn't seem to mind.
368         
369         * kwq/WebCoreTextField.mm:
370         (-[KWQSearchFieldCell _addStringToRecentSearches:]):
371         Override this method to bail out if private browsing is enabled.
372
373 2006-04-04  Trey Matteson  <trey@usa.net>
374
375         Reviewed by Hyatt.
376
377         http://bugzilla.opendarwin.org/show_bug.cgi?id=7951
378         REGRESSION: Safari crashes when printing a google map w/directions
379
380         Tests: none, because I believe it only happens when printing, due to the relayouts
381
382         * rendering/RenderTable.cpp:
383         (WebCore::RenderTable::recalcSectionsIfNeeded): Add new utility to let the cells
384         ensure the sections' grid data is up to date.
385         * rendering/RenderTable.h:
386         * rendering/RenderTableCell.cpp:
387         (WebCore::RenderTableCell::calcMinMaxWidth):  Call above method.
388
389 2006-04-03  Justin Haygood <jhaygood@spsu.edu>
390
391         Reviewed by eseidel.  Landed by eseidel.
392         
393         - WIN32: maximumScroll() is the maximum scroll delta, not the maximum scroll position. Update to use
394           the real maximum scroll position.
395         http://bugzilla.opendarwin.org/show_bug.cgi?id=8160
396
397         * platform/win/ScrollViewWin.cpp:
398         (WebCore::ScrollView::updateScrollBars):
399
400 2006-04-04  Eric Seidel  <eseidel@apple.com>
401
402         Reviewed by andersca.
403
404         Work-around spaces-in-pathnames issue in gnumake on win32.
405         http://bugzilla.opendarwin.org/show_bug.cgi?id=8173
406
407         * WebCore.vcproj/WebCore/build-generated-files.sh:
408
409 2006-04-03  Darin Adler  <darin@apple.com>
410
411         - tried to fix build again
412
413         * WebCore.xcodeproj/project.pbxproj: Removed JSStyleSheet files.
414         * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
415
416 2006-04-03  Darin Adler  <darin@apple.com>
417
418         - fixed properties on a bunch of files
419           (removed allow-tabs and svn:executable from many)
420
421         * css/css_base.cpp:
422         * html/html_headimpl.cpp:
423         * khtml/ecma/kjs_traversal.cpp:
424         * kwq/DeprecatedPtrListImpl.cpp:
425         * kwq/DeprecatedValueListImpl.cpp:
426         * loader/CachedScript.h:
427         * platform/ArrayImpl.cpp:
428         * platform/StringImpl.cpp:
429         * rendering/DataRef.h:
430         * rendering/RenderContainer.cpp:
431         * rendering/RenderTableCell.cpp:
432         * rendering/bidi.h:
433         * rendering/render_list.cpp:
434         * rendering/render_style.cpp:
435         * rendering/table_layout.h:
436         Converted tabs to spaces.
437
438 2006-04-03  Alexey Proskuryakov  <ap@nypop.com>
439
440         Reviewed by Darin.
441
442         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7118
443           Property values with extra items do not get treated as invalid (they should)
444
445         Tests: fast/css/invalidation-errors.html
446                fast/css/invalidation-errors-2.html
447                fast/css/invalidation-errors-3.html
448
449         * css/CSSGrammar.y: Rollback the properties added by parseValue() when it returns false.
450         * css/cssparser.h: Moved shorthand counting to ShorthandScope, a new class in cssparser.cpp.
451         * css/cssparser.cpp:
452         (WebCore::CSSParser::rollbackLastProperties): Added.
453         (WebCore::CSSParser::parseValue): Return false if there are too many properties in the list.
454         (WebCore::CSSParser::parseBackgroundShorthand): Use ShorthandScope.
455         (WebCore::CSSParser::parseShorthand): Ditto.
456         (WebCore::CSSParser::parse4Values): Ditto.
457
458 2006-04-03  Darin Adler  <darin@apple.com>
459
460         - changed StyleSheet back to hand-generated since the generated toJS
461           function was not making the right type of wrapper for CSS style sheets
462           (fixes failing layout tests)
463
464         * DerivedSources.make: Removed JSStyleSheet.h.
465         * css/StyleSheet.idl: Removed.
466         * khtml/ecma/kjs_css.cpp: Added DOMStyleSheet back in.
467         * khtml/ecma/kjs_css.h: Ditto.
468
469 2006-04-03  Darin Adler  <darin@apple.com>
470
471         - fixed Macintosh build
472
473         * WebCore.xcodeproj/project.pbxproj: Fixed paths of some files that were absolute
474         paths from my machine.
475
476 2006-04-03  Darin Adler  <darin@apple.com>
477
478         - try to fix Windows build
479
480         * WebCore.vcproj/WebCore/WebCore.vcproj: Add three new generated files as source files.
481
482 2006-04-03  Darin Adler  <darin@apple.com>
483
484         Reviewed by Maciej.
485
486         - get RTL right for bug http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
487           REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus
488
489         * rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent):
490         Scroll to the right if RTL.
491
492 2006-04-03  Darin Adler  <darin@apple.com>
493
494         Reviewed by Maciej.
495
496         - http://bugzilla.opendarwin.org/show_bug.cgi?id=8147
497           convert derived sources script to a Makefile
498
499         * DerivedSources.make: Added.
500         * css/CSSPrimitiveValue.idl: Added.
501         * css/Counter.idl: Added.
502         * css/StyleSheet.idl: Added.
503
504         * WebCore.xcodeproj/project.pbxproj: Added new generated files, IDLs, and the makefile.
505         * bindings/scripts/CodeGeneratorJS.pm:
506
507         * generate-derived-sources: Added license header. Removed most of the script, except for
508         a single invocation of make.
509
510         * khtml/ecma/kjs_css.h: Removed DOMStyleSheet, DOMCSSPrimitiveValue,
511         CSSPrimitiveValueConstructor, and DOMCounter.
512         * khtml/ecma/kjs_css.cpp:
513         (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): Changed to use JSStyleSheet as the base class.
514         (KJS::DOMCSSStyleSheet::getOwnPropertySlot): Ditto.
515         (KJS::DOMCSSValueProtoFunc::callAsFunction): Added.
516         (KJS::toJS): Changed to use JSCSSPrimitiveValue.
517         (KJS::DOMRGBColor::getValueProperty): Changed to call toJS instead of making a
518         DOMCSSPrimitiveValue directly.
519
520 2006-04-03  Justin Garcia  <justin.garcia@apple.com>
521
522         Reviewed by harrison
523         
524         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
525         REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page
526         
527         The frame's selection is only set after all sub-commands have been 
528         performed.  When we send the khtmlBeforeTextInsertedEvent to the root 
529         editable element we were using frame->selection(), which may no longer 
530         be in the document.
531         
532         Had to move the construction of the ReplacementFragment to when the
533         replace operation is applied, because endingSelection isn't the 
534         endingSelection of the last operation when the replace operation
535         is constructed.
536
537         * editing/ReplaceSelectionCommand.cpp:
538         (WebCore::ReplacementFragment::ReplacementFragment):
539         (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
540         (WebCore::ReplaceSelectionCommand::doApply):
541         * editing/ReplaceSelectionCommand.h:
542
543 2006-04-03  Beth Dakin  <bdakin@apple.com>
544
545         Reviewed by Hyatt.
546
547         Fix for <rdar://problem/4495644> crash when mousing over links at 
548         nationalrealestateinvestors.com in 
549         WebCore::RenderBlock::findNextLineBreak
550
551         This is a fix for a repro crasher where a rootLineBox had a stale 
552         pointer to a render object.
553
554         * rendering/RenderFlow.cpp:
555         (WebCore::RenderFlow::dirtyLinesFromChangedChild): Only break from 
556         the function because of selfNeedsLayout() if we are not an inline 
557         flow, because if we are, we will not re-layout before bad things 
558         can happen.
559
560 2006-04-03  Timothy Hatcher  <timothy@apple.com>
561
562         Reviewed by Maciej.
563
564         Removing idl files and some scripts from the WebCore target to prevent
565         them from being copied into the Resources.
566
567         * WebCore.xcodeproj/project.pbxproj:
568
569 2006-04-03  Dave Hyatt  <hyatt@apple.com>
570
571         Implement basic theme support on Win32.  Still much to do, but
572         the backgrounds of buttons, textfields, checkboxes and radio
573         controls now draw correctly.  Still work to do for the Classic look
574         and to get the foreground defaults of the controls correct.
575
576         Reviewed by anders
577
578         * dom/Node.h:
579         (WebCore::Node::isReadOnly):
580         * html/HTMLInputElement.h:
581         (WebCore::HTMLInputElement::isReadOnly):
582         * platform/win/IntRectWin.cpp:
583         (WebCore::IntRect::operator RECT):
584         * rendering/RenderTheme.cpp:
585         (WebCore::RenderTheme::isControlStyled):
586         (WebCore::RenderTheme::stateChanged):
587         (WebCore::RenderTheme::isReadOnly):
588         (WebCore::RenderTheme::isHovered):
589         * rendering/RenderTheme.h:
590         (WebCore::RenderTheme::supportsHover):
591         * rendering/RenderThemeMac.h:
592         * rendering/RenderThemeMac.mm:
593         (WebCore::RenderThemeMac::isControlStyled):
594         * rendering/RenderThemeWin.cpp:
595         (WebCore::m_textFieldTheme):
596         (WebCore::RenderThemeWin::~RenderThemeWin):
597         (WebCore::RenderThemeWin::close):
598         (WebCore::RenderThemeWin::supportsFocus):
599         (WebCore::RenderThemeWin::determineState):
600         (WebCore::RenderThemeWin::getThemeData):
601         (WebCore::RenderThemeWin::paintButton):
602         (WebCore::RenderThemeWin::setCheckboxSize):
603         (WebCore::RenderThemeWin::setRadioSize):
604         (WebCore::RenderThemeWin::paintTextField):
605         * rendering/RenderThemeWin.h:
606         (WebCore::ThemeData::m_state):
607         (WebCore::RenderThemeWin::supportsHover):
608         (WebCore::RenderThemeWin::paintCheckbox):
609         (WebCore::RenderThemeWin::paintRadio):
610
611 2006-04-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
612
613         Reviewed by Beth.
614
615         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8085
616           REGRESSION: Main menu positioned incorrectly on eia.org and fedex.com/us
617
618         Test: fast/dom/Element/offsetTop-table-cell.html
619
620         * rendering/RenderObject.cpp:
621         (WebCore::RenderObject::offsetTop): Skip table rows when adding up
622         the offsets, since a table cell's yPos() is relative to the table
623         section, not the row.
624
625 2006-04-03  Mitz Pettel  <opendarwin.org@mitzpettel.com>
626
627         Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html
628
629         Reviewed by Darin.
630
631         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7943
632           Layer outline does not repaint
633
634         * rendering/RenderLayer.cpp:
635         (WebCore::RenderLayer::paintLayer): Use the outlineRect for the
636         outline phase and do it only if the outlineRect isn't empty.
637         (WebCore::RenderLayer::calculateRects): Actually add the outline width to the
638         outline rect.
639
640 2006-04-03  Adele Peterson  <adele@apple.com>
641
642         Reviewed by Justin.
643
644         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8104
645         REGRESSION (NativeTextField): New text fields should not allow pasting newlines
646
647         Test: fast/forms/input-truncate-newline.html
648
649         * html/HTMLInputElement.cpp:
650         (WebCore::minPosition): Added helper function.
651         (WebCore::HTMLInputElement::defaultEventHandler): Searches for /r or /n and 
652          truncates the text to be inserted to the earliest newline.
653
654 2006-04-03  Alexey Proskuryakov  <ap@nypop.com>
655
656         Fixed a comment (forgot to save the file before the previous commit).
657
658         * xml/xmlhttprequest.cpp:
659         (WebCore::XMLHttpRequest::open):
660
661 2006-04-03  Alexey Proskuryakov  <ap@nypop.com>
662
663         Reviewed by Darin.
664
665         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8099
666           REGRESSION: XMLHttpRequest lowercase post requests broken
667
668         Test: http/tests/xmlhttprequest/methods-lower-case.html
669
670         * xml/xmlhttprequest.cpp:
671         (WebCore::XMLHttpRequest::open): Uppercase some HTTP method names, to match a Firefox quirk.
672         (WebCore::XMLHttpRequest::send): Account for the above change.
673
674 2006-04-02  Graham Dennis  <Graham.Dennis@gmail.com>
675
676         Reviewed by Darin.
677
678         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8032
679           REGRESSION: Focus ring not completely redrawn after a Delete changes its size
680
681         * rendering/RenderObject.cpp:
682         (WebCore::RenderObject::repaintAfterLayoutIfNeeded): When an element changes size, the
683         delta rectangles that need to be invalidated must be inflated by the outline size to ensure
684         that the previous outline is erased, and the space where the new outline is to be drawn is
685         also invalidated. This behaviour is identical to the behaviour of borders that was fixed in
686         bug 6301.
687         * manual-tests/outline-repaint-glitch.html: Added. Manual testcase.
688         This is just an outline version of border-repaint-glitch.html
689
690 2006-04-02  Trey Matteson  <trey@usa.net>
691
692         Reviewed by Maciej.
693
694         Support for fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
695         REGRESSION: 404s are not displayed
696
697         * bridge/mac/WebCoreFrameBridge.mm:
698         (-[WebCoreFrameBridge currentForm]): Nuke redundant nil check.
699         (-[WebCoreFrameBridge frameElement]): Tweak to not rely on our document, which
700         gives a correct result even at the start of our loading process.
701         * bindings/objc/DOM.mm:
702         (-[DOMDocument _ownerElement]): Nuke redundant nil check.
703
704 2006-04-02  David Kilzer  <ddkilzer@kilzer.net>
705
706         Reviewed by Maciej.
707
708         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8079
709         REGRESSION: Redraw from page cache does not show visited links
710
711         * page/Frame.cpp: (WebCore::Frame::reparseConfiguration): Added back
712         updateStyleSelector call that was removed as part of the patch for bug 7907.
713
714 2006-04-02  Maciej Stachowiak  <mjs@apple.com>
715
716         Reviewed by Hyatt.
717
718         - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
719         - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
720         (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
721         - fixed tab and shift tab don't select the right things
722         http://bugzilla.opendarwin.org/show_bug.cgi?id=5685
723
724         * bridge/mac/FrameMac.mm:
725         (WebCore::FrameMac::nextKeyViewInFrame):
726         * bridge/mac/WebCoreFrameBridge.h:
727
728 2006-04-02  Darin Adler  <darin@apple.com>
729
730         - add a few stubs to get Windows closer to building
731
732         * platform/win/TemporaryLinkStubs.cpp:
733         (WebCore::focusRingColor):
734         (WebCore::setFocusRingColorChangeFunction):
735         (Frame::setNeedsReapplyStyles):
736
737 2006-04-02  Darin Adler  <darin@apple.com>
738
739         - fix the build
740
741         * WebCore.xcodeproj/project.pbxproj: Removed a bunch of files that should not have been
742         mentioned at all, and a bunch of others that should be in the project but not in the target.
743
744 2006-04-02  Darin Adler  <darin@apple.com>
745
746         Reviewed by Adele.
747
748         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8123
749           focus ring on new text field doesn't look like the old one
750
751         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7685
752           Focus ring color should change to match graphite when system theme is graphite
753
754         - some cleanup to how we parse user agent style sheets
755
756         * css/CSSValueKeywords.in: Added -webkit-focus-ring-color.
757
758         * css/cssstyleselector.cpp:
759         (WebCore::parseUASheet): Parse an array of chars instead of UTF-16.
760         Cuts the size of the style sheet in half.
761         (WebCore::CSSStyleSelector::applyProperty): Allow negative value for
762         outline-offset. Changed shadow parsing to use getColorFromPrimitiveValue
763         instead of repeating the same logic.
764         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Added a case
765         for the focus ring color.
766         * rendering/render_style.h: (WebCore::RenderStyle::setOutlineOffset):
767         Changed to allow negative values.
768
769         * css/html4.css: Removed a lot of excess spaces. Changed color of focus
770         to -webkit-focus-ring-color. Changed width of focus to 5px.
771         Added an outline-offset for <input type=text> of -2px.
772
773         * css/cssparser.cpp:
774         (WebCore::CSSParser::parseValue): Added focus ring color as an outline color all
775         the time, and as any other color when not in strict mode. I'm confused about what's
776         best for this whole strict mode policy, and I may need advice on Hyatt to perfect
777         this one later.
778         (WebCore::CSSParser::parseColorFromValue): Removed code to pin r, g, and b because
779         the functions in platform already take care of that. Kept the pinning of a, though
780         because that's done in floating point before converting to an integer.
781         (WebCore::CSSParser::parseShadow): Allow focus ring color when not in strict mode.
782
783         * bridge/mac/FrameMac.h: Eliminated the virtual detachFromView function.
784         * bridge/mac/FrameMac.mm:
785         (WebCore::FrameMac::FrameMac): Eliminated code to maintain the frame instances list.
786         (WebCore::FrameMac::~FrameMac): Ditto.
787         (WebCore::Frame::setNeedsReapplyStyles): Added.
788
789         * bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
790         * platform/mac/WebCoreTextRendererFactory.mm:
791         (-[WebCoreTextRendererFactory clearCaches]):
792         Changed to call the new Page::setNeedsReapplyStylesForSettingsChange instead of using the
793         obsolete Frame::instances.
794
795         * page/Frame.h: Removed instances, mutableInstances, and detachFromView.
796         * page/Frame.cpp: Ditto.
797
798         * page/FrameTree.cpp:
799         (WebCore::FrameTree::~FrameTree): Call setView(0) instead of detachFromView().
800         (WebCore::FrameTree::removeChild): Ditto.
801
802         * page/Page.h:
803         * page/Page.cpp:
804         (WebCore::Page::init): Added a set of pages instead of a page count. Also
805         register a function for when the focus ring color changes the first time this
806         is called.
807         (WebCore::Page::~Page): Call setView(0) instead of detachFromView. Also update
808         to manager the set of pages.
809         (WebCore::Page::setNeedsReapplyStyles): Call setNeedsReapplyStyles on all frames.
810         (WebCore::Page::setNeedsReapplyStylesForSettingsChange): Call setNeedsReapplyStyles
811         on all frames with the passed-in settings.
812
813         * css/make-css-file-arrays.pl: Changed to run the C preprocessor on the
814         input files and to generate an array of char instead of unsigned short.
815
816         * platform/PlatformString.h: Added a constructor that takes a char* and
817         a length.
818         * platform/String.cpp: (WebCore::String::String): Ditto.
819
820         * WebCore.xcodeproj/project.pbxproj: Just some tweaks; adding in a few files like
821         the user agent style sheets.
822
823         * platform/Color.h: Removed all use of DeprecatedString. Cleaned up a bit.
824         Added focusRingColor and setFocusRingColorChangeFunction.
825         * platform/Color.cpp:
826         (WebCore::makeRGB): Rewrote using max and min.
827         (WebCore::makeRGBA): Ditto.
828         (WebCore::parseHexColor): Cleaned up a bit; changed partway to String instead of
829         DeprecatedString.
830         (WebCore::Color::Color): Changed to use String and to call setNamedColor to save code.
831         (WebCore::Color::setNamedColor): Changed to use String in the interface.
832
833         * platform/mac/ColorMac.mm:
834         (WebCore::observeTheme): Added. Function used to start up the observer.
835         (WebCore::setFocusRingColorChangeFunction): Added. Used to get a call back so we can
836         update all the views when the color changes (including recomputing style to get the
837         color change in).
838         (WebCore::setFocusRingColorChangeFunction): Added. Returns one of the two focus
839         ring colors. Both of these match what AppKit uses -- neither matches what we used
840         to have in the html4.css file.
841         (+[WebCoreControlTintObserver controlTintDidChange]): Added. Used to update when
842         the appearance is changed from blue to graphite and back. We keep a global so we
843         don't have to call over to AppKit every time; that's probably overkill but we need
844         the obsever for the color change function anyway.
845
846 2006-04-02  Mitz Pettel  <opendarwin.org@mitzpettel.com>
847
848         Test: fast/inline-block/overflow-clip.html
849
850         Reviewed by Darin.
851
852         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8118
853           REGRESSION (r13595): Inline block's clipped overflow increases table row height
854
855         * rendering/render_line.cpp:
856         (WebCore::InlineFlowBox::placeBoxesVertically): Don't look at interior overflow
857         when calculating the contribution to the inline's vertical overflows.
858
859 2006-04-02  Eric Seidel  <eseidel@apple.com>
860
861         Reviewed by andersca.
862
863         Make WebCore safe against KJS::Node in JavaScriptCore private headers.
864
865         * editing/ReplaceSelectionCommand.h:
866         * khtml/ecma/JSXMLSerializer.cpp:
867         (KJS::XMLSerializerProtoFunc::callAsFunction):
868         * khtml/ecma/JSXSLTProcessor.cpp:
869         (KJS::XSLTProcessorProtoFunc::callAsFunction):
870         * khtml/ecma/kjs_binding.cpp:
871         (KJS::ScriptInterpreter::forgetDOMNodeForDocument):
872         (KJS::ScriptInterpreter::putDOMNodeForDocument):
873         * khtml/ecma/kjs_dom.cpp:
874         (KJS::DOMNode::DOMNode):
875         (KJS::DOMNode::mark):
876         (KJS::DOMNode::getValueProperty):
877         (KJS::DOMNode::putValueProperty):
878         (KJS::DOMNodeProtoFunc::callAsFunction):
879         (KJS::toNode):
880         (KJS::DOMEventTargetNode::DOMEventTargetNode):
881         (KJS::DOMDocumentProtoFunc::callAsFunction):
882         (KJS::DOMElement::putValueProperty):
883         (KJS::DOMElementProtoFunc::callAsFunction):
884         (KJS::checkNodeSecurity):
885         (KJS::toJS):
886         (KJS::getRuntimeObject):
887         (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
888         (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
889         * khtml/ecma/kjs_events.cpp:
890         (KJS::JSLazyEventListener::JSLazyEventListener):
891         (KJS::ClipboardProtoFunc::callAsFunction):
892         * khtml/ecma/kjs_html.cpp:
893         (KJS::JSHTMLDocument::namedItemGetter):
894         (KJS::JSHTMLElement::framesetNameGetter):
895         (KJS::JSHTMLElement::getOwnPropertySlot):
896         (KJS::JSHTMLElement::pushEventHandlerScope):
897         (KJS::JSHTMLCollection::callAsFunction):
898         (KJS::JSHTMLCollection::getNamedItems):
899         (KJS::JSHTMLSelectCollection::put):
900         * khtml/ecma/kjs_traversal.cpp:
901         (KJS::JSNodeFilterCondition::acceptNode):
902         * khtml/ecma/kjs_window.cpp:
903         (KJS::Window::put):
904         * kwq/KWQPageState.mm:
905         (-[KWQPageState WebCore::]):
906
907 2006-04-01  Darin Adler  <darin@apple.com>
908
909         Reviewed by Eric.
910
911         - removed a bunch of unneeded ForwardingHeaders and WebCore+SVG headers
912
913         * ForwardingHeaders/kcanvas: Removed.
914         * ForwardingHeaders/kcanvas/KCanvas.h: Removed.
915         * ForwardingHeaders/kdom: Removed.
916         * ForwardingHeaders/kdom/DOMString.h: Removed.
917         * ForwardingHeaders/kdom/Helper.h: Removed.
918         * ForwardingHeaders/kdom/KDOMSettings.h: Removed.
919         * ForwardingHeaders/kdom/Namespace.h: Removed.
920         * ForwardingHeaders/kdom/cache: Removed.
921         * ForwardingHeaders/kdom/cache/KDOMCachedImage.h: Removed.
922         * ForwardingHeaders/kdom/cache/KDOMCachedObject.h: Removed.
923         * ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h: Removed.
924         * ForwardingHeaders/kdom/cache/KDOMCachedScript.h: Removed.
925         * ForwardingHeaders/kdom/cache/KDOMLoader.h: Removed.
926         * ForwardingHeaders/kdom/core: Removed.
927         * ForwardingHeaders/kdom/core/DOMConfiguration.h: Removed.
928         * ForwardingHeaders/kdom/core/DOMException.h: Removed.
929         * ForwardingHeaders/kdom/core/DOMList.h: Removed.
930         * ForwardingHeaders/kdom/core/DOMString.h: Removed.
931         * ForwardingHeaders/kdom/core/NamedAttrMap.h: Removed.
932         * ForwardingHeaders/kdom/core/ProcessingInstruction.h: Removed.
933         * ForwardingHeaders/kdom/core/domattrs.h: Removed.
934         * ForwardingHeaders/kdom/ecma: Removed.
935         * ForwardingHeaders/kdom/ecma/GlobalObject.h: Removed.
936         * ForwardingHeaders/kdom/events: Removed.
937         * ForwardingHeaders/kdom/events/Event.h: Removed.
938         * ForwardingHeaders/kdom/events/EventListener.h: Removed.
939         * ForwardingHeaders/kdom/events/EventTarget.h: Removed.
940         * ForwardingHeaders/kdom/events/KeyboardEvent.h: Removed.
941         * ForwardingHeaders/kdom/events/MouseEvent.h: Removed.
942         * ForwardingHeaders/kdom/events/UIEvent.h: Removed.
943         * ForwardingHeaders/kdom/events/kdomevents.h: Removed.
944         * ForwardingHeaders/kdom/kdom.h: Removed.
945         * ForwardingHeaders/kdom/parser: Removed.
946         * ForwardingHeaders/kdom/parser/KDOMParser.h: Removed.
947         * ForwardingHeaders/ksvg2: Removed.
948         * ForwardingHeaders/ksvg2/KSVGPart.h: Removed.
949         * ForwardingHeaders/ksvg2/KSVGView.h: Removed.
950         * ForwardingHeaders/ksvg2/css: Removed.
951         * ForwardingHeaders/ksvg2/css/CSSPropertyNames.h: Removed.
952         * ForwardingHeaders/ksvg2/css/CSSValueKeywords.h: Removed.
953         * WebCore+SVG/KDOMHeaders.h: Removed.
954         * WebCore+SVG/Namespace.h: Removed.
955         * WebCore+SVG/kdom.h: Removed.
956
957         * WebCore.xcodeproj/project.pbxproj: Removed headers.
958
959         * kcanvas/KCanvasCreator.cpp:
960         * kcanvas/KCanvasResources.cpp:
961         * kcanvas/KCanvasTreeDebug.cpp:
962         * kcanvas/RenderPath.cpp:
963         * kcanvas/RenderSVGImage.cpp:
964         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
965         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
966         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
967         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
968         * ksvg2/css/SVGCSSStyleSelector.cpp:
969         * ksvg2/events/SVGZoomEvent.h:
970         * ksvg2/misc/KCanvasRenderingStyle.cpp:
971         * ksvg2/misc/KSVGTimeScheduler.cpp:
972         * ksvg2/misc/SVGImageLoader.cpp:
973         * ksvg2/svg/SVGAElement.cpp:
974         * ksvg2/svg/SVGAnimationElement.cpp:
975         * ksvg2/svg/SVGCircleElement.cpp:
976         * ksvg2/svg/SVGClipPathElement.cpp:
977         * ksvg2/svg/SVGCursorElement.cpp:
978         * ksvg2/svg/SVGCursorElement.h:
979         * ksvg2/svg/SVGDOMImplementation.cpp:
980         * ksvg2/svg/SVGDocument.cpp:
981         * ksvg2/svg/SVGDocument.h:
982         * ksvg2/svg/SVGElement.cpp:
983         * ksvg2/svg/SVGEllipseElement.cpp:
984         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
985         * ksvg2/svg/SVGExternalResourcesRequired.h:
986         * ksvg2/svg/SVGFEBlendElement.cpp:
987         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
988         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
989         * ksvg2/svg/SVGFECompositeElement.cpp:
990         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
991         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
992         * ksvg2/svg/SVGFEFloodElement.cpp:
993         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
994         * ksvg2/svg/SVGFEImageElement.cpp:
995         * ksvg2/svg/SVGFEImageElement.h:
996         * ksvg2/svg/SVGFELightElement.cpp:
997         * ksvg2/svg/SVGFEMergeElement.cpp:
998         * ksvg2/svg/SVGFEOffsetElement.cpp:
999         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1000         * ksvg2/svg/SVGFETileElement.cpp:
1001         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1002         * ksvg2/svg/SVGFilterElement.cpp:
1003         * ksvg2/svg/SVGGradientElement.cpp:
1004         * ksvg2/svg/SVGHelper.cpp:
1005         * ksvg2/svg/SVGImageElement.cpp:
1006         * ksvg2/svg/SVGLangSpace.cpp:
1007         * ksvg2/svg/SVGLength.cpp:
1008         * ksvg2/svg/SVGLineElement.cpp:
1009         * ksvg2/svg/SVGLinearGradientElement.cpp:
1010         * ksvg2/svg/SVGList.h:
1011         * ksvg2/svg/SVGLocatable.cpp:
1012         * ksvg2/svg/SVGMarkerElement.cpp:
1013         * ksvg2/svg/SVGMarkerElement.h:
1014         * ksvg2/svg/SVGMaskElement.cpp:
1015         * ksvg2/svg/SVGPathElement.cpp:
1016         * ksvg2/svg/SVGPatternElement.cpp:
1017         * ksvg2/svg/SVGPolyElement.cpp:
1018         * ksvg2/svg/SVGPolygonElement.cpp:
1019         * ksvg2/svg/SVGPolylineElement.cpp:
1020         * ksvg2/svg/SVGRadialGradientElement.cpp:
1021         * ksvg2/svg/SVGRectElement.cpp:
1022         * ksvg2/svg/SVGSVGElement.cpp:
1023         * ksvg2/svg/SVGStopElement.cpp:
1024         * ksvg2/svg/SVGStyleElement.cpp:
1025         * ksvg2/svg/SVGStyledElement.cpp:
1026         * ksvg2/svg/SVGStyledLocatableElement.cpp:
1027         * ksvg2/svg/SVGStyledTransformableElement.cpp:
1028         * ksvg2/svg/SVGTextElement.cpp:
1029         * ksvg2/svg/SVGTransformable.cpp:
1030         * ksvg2/svg/SVGUseElement.cpp:
1031         * ksvg2/svg/SVGViewElement.cpp:
1032         Updated includes.
1033
1034 2006-04-01  Darin Adler  <darin@apple.com>
1035
1036         Reviewed by Maciej.
1037
1038         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8089
1039           REGRESSION: Caret position is off in native text field with text-align:right
1040
1041         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8082
1042           REGRESSION: Empty RTL text fields place the caret on the left side
1043
1044         Need a way to make a test for this. No obvious way at the moment.
1045
1046         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect):
1047         Consider border, padding, and the width of the caret properly in the
1048         calculation of the caret's X position.
1049
1050         * rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect):
1051         Fixed some similar issues and rewrote this function for clarity.
1052         However, I suspect this function was and remains broken and is almost
1053         never called.
1054
1055 2006-04-01  Darin Adler  <darin@apple.com>
1056
1057         Reviewed by Justin.
1058
1059         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
1060           REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus
1061
1062         Test: fast/forms/input-text-scroll-left-on-blur.html
1063
1064         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Pass blur events
1065         through to the RenderTextField, as well as mouse, drag, and wheel events.
1066         * rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll all the way to
1067         the left on a blur.
1068
1069         - unrelated small changes
1070
1071         * html/HTMLTextFieldInnerElement.cpp: Removed excess includes.
1072         (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Tweaked comments a bit.
1073
1074         * dom/Element.cpp:
1075         (WebCore::Element::scrollIntoView): Removed unneeded this-> before function call.
1076         (WebCore::Element::scrollIntoViewIfNeeded): Ditto.
1077
1078         * page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): Removed obsolete comment.
1079
1080 2006-03-31  Maciej Stachowiak  <mjs@apple.com>
1081
1082         Reviewed by Adele.
1083         
1084         <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)
1085
1086         * editing/ReplaceSelectionCommand.cpp:
1087         (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into
1088         an empty editable subtree.
1089
1090 2006-04-01  Darin Adler  <darin@apple.com>
1091
1092         Reviewed by Maciej.
1093
1094         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8063
1095           REGRESSION: double clicking in new text fields won't select whole words
1096
1097         Test: fast/forms/input-text-double-click.html
1098
1099         * editing/visible_units.cpp: (WebCore::nextBoundary): Set the end of the range by
1100         calling selectNodeContents rather than by calling setEndAfter. The problem with
1101         setEndAfter is that it doesn't do anything when the parent of the node is 0, and
1102         also it's not really what we want, since the boundary node is one with editable
1103         contents -- we want to stay inside the boundary node.
1104
1105         * editing/Selection.cpp: (WebCore::Selection::validate): Fix a tiny formatting glitch
1106         I noticed at the same time.
1107
1108 2006-03-31  John Sullivan  <sullivan@apple.com>
1109
1110         Reviewed by Tim Hatcher.
1111         
1112         - fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word 
1113         doesn't select it or offer corrections (first click only)
1114
1115         * bridge/mac/FrameMac.mm:
1116         (WebCore::FrameMac::sendContextMenuEvent):
1117         Rolled in this one-line change that Hyatt wrote ages ago.
1118
1119 2006-03-31  Beth Dakin  <bdakin@apple.com>
1120
1121         Reviewed by John.
1122
1123         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8108
1124         REGRESSION (r13590-r13593): Floating table's cells don't paint 
1125         their background
1126
1127         This is a regression from my painting patch yesterday. Just a silly 
1128         error I didn't catch.
1129
1130         * rendering/RenderTable.cpp:
1131         (WebCore::RenderTable::paint): Change the phase of our new 
1132         PaintInfo, not our old one.
1133
1134 2006-03-31  Tim Omernick  <timo@apple.com>
1135
1136         Reviewed by Adele.
1137
1138         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
1139         <rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute
1140         
1141         * rendering/RenderTextField.cpp:
1142         (WebCore::RenderTextField::createDivStyle):
1143         Set user modify based on the form element's readOnly().
1144         (WebCore::RenderTextField::updateFromElement):
1145         ditto
1146
1147 2006-03-31  Adele Peterson  <adele@apple.com>
1148
1149         Reviewed by Tim Omernick.
1150
1151         Updating shadowAncestorNode so it doesn't check for rootEditableElement.  Now we just walk
1152         up the tree to look for a shadowNode, and then we find the shadowParent.
1153
1154         * dom/Node.cpp: (WebCore::Node::shadowAncestorNode):
1155         * rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange):
1156          Updated assertion to check for shadowAncestorNode instead of rootEditableElement.
1157
1158 2006-03-31  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1159
1160         Reviewed by John Sullivan.
1161         
1162         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8101
1163           REGSRESSION: Fix for bug 7031 causes 30 layout tests to fail
1164
1165         * rendering/render_line.cpp:
1166         (WebCore::InlineFlowBox::placeBoxesVertically): Change top and bottom positions
1167         only if childAffectsTopBottomPos is true.
1168         * rendering/RenderFlow.cpp:
1169         (WebCore::RenderFlow::paintLines): Redo a part of the patch for bug 7031 that
1170         wasn't committed with the rest of the patch.
1171
1172 2006-03-31  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1173
1174         Reviewed by Darin, landed by Beth.
1175
1176         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8081
1177         REGRESSION: Drop-down menu has gap at top
1178
1179         * rendering/RenderBox.cpp:
1180         (WebCore::RenderBox::calcAbsoluteVerticalValues): When calculating 
1181         the hypothetical vertical position in normal flow, skip table rows 
1182         in the ancestor chain, since a table cell's Y position is relative 
1183         to the table section, not the row.
1184
1185 2006-03-31  Dave Hyatt <hyatt@apple.com>
1186
1187         Fix the border drawing for themes on Win32.
1188
1189         Reviewed by adele
1190
1191         * rendering/RenderBox.cpp:
1192         (WebCore::RenderBox::paintBoxDecorations):
1193         * rendering/RenderTheme.cpp:
1194         (WebCore::RenderTheme::paintBorderOnly):
1195         * rendering/RenderTheme.h:
1196
1197 2006-03-31  Darin Adler  <darin@apple.com>
1198
1199         Reviewed by John Sullivan.
1200
1201         * khtml/ecma/kjs_binding.cpp: Added names for VALIDATION_ERR and
1202         TYPE_MISMATCH_ERR; new DOM Level 3 errors that need to be listed in
1203         the mapping from error code to error name.
1204
1205         * dom/Element.idl: Removed comment from bad old days where we had to
1206         touch these files to make them rebuild.
1207
1208 2006-03-30  Maciej Stachowiak  <mjs@apple.com>
1209
1210         - fixed Windows build breakage from previous change
1211
1212         * platform/ScrollView.h:
1213         * platform/win/FontWin.cpp:
1214         (WebCore::Font::drawLineForText):
1215         * platform/win/ScrollViewWin.cpp:
1216         (WebCore::ScrollView::scrollOffset):
1217         (WebCore::ScrollView::scrollBy):
1218
1219 2006-03-30  Maciej Stachowiak  <mjs@apple.com>
1220
1221         Reviewed by Eric.
1222         
1223         - various Point / Size related cleanup
1224         
1225         First, I clarified the semantics of some operations to keep a
1226         better distinction between IntPoint and IntSize:
1227         
1228         * platform/IntPoint.h:
1229         (WebCore::IntPoint::move): new convenience to move a point by separate
1230         x and y deltas.
1231         (WebCore::operator+=): You can't add a point to a point, you can only add
1232         a size to a point.
1233         (WebCore::operator+): ditto
1234         (WebCore::operator-): point - point = size; point - size = point
1235         (WebCore::operator-=): only allow subtracting a size for the mutating version
1236         * platform/IntRect.h:
1237         (WebCore::IntRect::move): tweaked to use IntPoint::move, also, move by an IntSize,
1238         not an IntPoint.
1239         * platform/IntSize.h:
1240         (WebCore::IntSize::shrunkTo): analog to expandedTo
1241         (WebCore::IntSize::clampNegativeToZero): a handy helper
1242         (WebCore::operator-): Added unary minus operator
1243
1244         Made the same changes for FloatPoint:
1245         
1246         * platform/FloatPoint.h:
1247         (WebCore::FloatPoint::move):
1248         (WebCore::operator+=):
1249         (WebCore::operator-=):
1250         (WebCore::operator+):
1251         (WebCore::operator-):
1252         * platform/FloatRect.h:
1253         (WebCore::FloatRect::move):
1254         * platform/FloatSize.h:
1255         (WebCore::operator-):
1256
1257         Then I changed a bunch of stuff to pass around IntPoint instead of separate x and y
1258         coordinates. The main one was:
1259         
1260         * platform/ScrollView.h:
1261         * platform/mac/ScrollViewMac.mm:
1262         (WebCore::ScrollView::scrollOffset): new method, return an IntSize
1263         (WebCore::ScrollView::contentsToViewport): take and return an IntPoint
1264         (WebCore::ScrollView::viewportToContents): take and return an IntPoint
1265         * platform/win/ScrollViewWin.cpp:
1266         (WebCore::ScrollView::updateContents): handle things in terms of scrollOffset,
1267         not scrollPoint
1268         (WebCore::ScrollView::visibleContentRect):
1269         (WebCore::ScrollView::contentsX):
1270         (WebCore::ScrollView::contentsY):
1271         (WebCore::ScrollView::viewportToContents):
1272         (WebCore::ScrollView::contentsToViewport):
1273         (WebCore::scrollOffset):
1274         (WebCore::ScrollView::maximumScroll):
1275         (WebCore::ScrollView::scrollBy):
1276         (WebCore::ScrollView::updateScrollBars):
1277
1278         The rest is mainly updates for these changes.
1279
1280         * bridge/mac/FrameMac.h:
1281         * bridge/mac/FrameMac.mm:
1282         (WebCore::FrameMac::eventMayStartDrag):
1283         (WebCore::FrameMac::dragHysteresisExceeded):
1284         (WebCore::FrameMac::handleMouseMoveEvent):
1285         (WebCore::FrameMac::mouseDown):
1286         (WebCore::FrameMac::shouldDragAutoNode):
1287         (WebCore::FrameMac::sendContextMenuEvent):
1288         * bridge/mac/WebCoreFrameBridge.mm:
1289         (-[WebCoreFrameBridge isPointInsideSelection:]):
1290         * dom/EventTargetNode.cpp:
1291         (WebCore::EventTargetNode::dispatchMouseEvent):
1292         (WebCore::EventTargetNode::dispatchWheelEvent):
1293         * khtml/ecma/kjs_window.cpp:
1294         (KJS::WindowFunc::callAsFunction):
1295         * page/Frame.cpp:
1296         (WebCore::Frame::shouldDragAutoNode):
1297         (WebCore::Frame::isPointInsideSelection):
1298         (WebCore::Frame::selectClosestWordFromMouseEvent):
1299         (WebCore::Frame::handleMousePressEventDoubleClick):
1300         (WebCore::Frame::handleMousePressEventTripleClick):
1301         (WebCore::Frame::handleMousePressEventSingleClick):
1302         (WebCore::Frame::handleMouseMoveEventPart2):
1303         (WebCore::Frame::handleMouseReleaseEvent):
1304         * page/Frame.h:
1305         * page/FrameView.cpp:
1306         (WebCore::FrameView::dispatchDragEvent):
1307         (WebCore::FrameView::prepareMouseEvent):
1308         (WebCore::FrameView::handleWheelEvent):
1309         * rendering/RenderLayer.cpp:
1310         (WebCore::RenderLayer::scrollRectToVisible):
1311         * rendering/RenderObject.cpp:
1312         (WebCore::RenderObject::draggableNode):
1313         * rendering/RenderObject.h:
1314         (WebCore::RenderObject::positionForPoint):
1315         * rendering/render_list.cpp:
1316         (WebCore::RenderListMarker::paint):
1317
1318 2006-03-30  Maciej Stachowiak  <mjs@apple.com>
1319
1320         - fixed windows build
1321
1322         * platform/win/TemporaryLinkStubs.cpp:
1323         (Widget::unlockDrawingFocus):
1324
1325 2006-03-31  Eric Seidel  <eseidel@apple.com>
1326
1327         Reviewed by mjs.
1328
1329         A bit more code cleanup.
1330
1331         * bridge/mac/WebCoreScriptDebugger.mm:
1332         (-[WebCoreScriptCallFrame evaluateWebScript:]):
1333         * html/HTMLFormElement.cpp:
1334         (WebCore::HTMLFormElement::submit):
1335         * html/HTMLInputElement.cpp:
1336         (WebCore::HTMLInputElement::setValue):
1337         * kwq/WebCoreTextField.mm:
1338         (-[KWQTextFieldController textView:shouldHandleEvent:]):
1339         (-[KWQSecureTextField selectText:]):
1340         * page/Frame.cpp:
1341         (WebCore::Frame::submitForm):
1342         * platform/Widget.h:
1343         * platform/mac/WidgetMac.mm:
1344         * rendering/render_frames.cpp:
1345         (WebCore::RenderFrameSet::userResize):
1346
1347 2006-03-30  Maciej Stachowiak  <mjs@apple.com>
1348
1349         Reviewed by Eric.
1350
1351         * bridge/mac/FrameMac.mm:
1352         (WebCore::FrameMac::wheelEvent):
1353         (WebCore::FrameMac::eventMayStartDrag):
1354         (WebCore::FrameMac::handleMouseMoveEvent):
1355         (WebCore::FrameMac::sendContextMenuEvent):
1356         * bridge/mac/WebCoreFrameBridge.mm:
1357         (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
1358         * dom/Document.cpp:
1359         (WebCore::Document::elementFromPoint):
1360         (WebCore::Document::prepareMouseEvent):
1361         * dom/Document.h:
1362         * kwq/WebCoreAXObject.mm:
1363         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
1364         (-[WebCoreAXObject accessibilityHitTest:]):
1365         * manual-tests/frame-hover.html: Added.
1366         * manual-tests/resources/hover-subframe-1.html: Added.
1367         * manual-tests/resources/hover-subframe-2.html: Added.
1368         * page/Frame.cpp:
1369         (WebCore::Frame::isPointInsideSelection):
1370         * page/FrameView.cpp:
1371         (WebCore::FrameView::prepareMouseEvent):
1372         (WebCore::FrameView::handleWheelEvent):
1373         * platform/IntRect.h:
1374         (WebCore::IntRect::contains):
1375         * rendering/RenderLayer.cpp:
1376         (WebCore::isSubframeCanvas):
1377         (WebCore::frameVisibleRect):
1378         (WebCore::RenderLayer::hitTest):
1379         (WebCore::shouldApplyImplicitCapture):
1380         (WebCore::RenderLayer::hitTestLayer):
1381         * rendering/RenderLayer.h:
1382
1383 2006-03-30  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1384
1385         Tests: fast/repaint/flexible-box-overflow.html fast/repaint/flexible-box-overflow-horizontal.html
1386
1387         Reviewed by Darin.
1388         
1389         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8056
1390           Flexible boxes do not repaint their top, left and children's overflows
1391
1392         * rendering/RenderBlock.cpp:
1393         (WebCore::RenderBlock::layoutBlockChildren):
1394         * rendering/RenderFlexibleBox.cpp:
1395         (WebCore::FlexBoxIterator::next):
1396         (WebCore::RenderFlexibleBox::layoutHorizontalBox): Update top overflow when
1397         determining vertical positions. Update horizontal overflows after horizontal
1398         positions are determined.
1399         (WebCore::RenderFlexibleBox::layoutVerticalBox):  Update left overflow when
1400         determining horizontal positions. Update vertical overflows after vertical
1401         positions are determined.
1402         (WebCore::RenderFlexibleBox::allowedChildFlex):
1403
1404 2006-03-30  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1405
1406         Tests: fast/repaint/text-shadow.html fast/repaint/text-shadow-horizontal.html
1407
1408         Reviewed by Darin.
1409
1410         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7301
1411           Text shadow does not repaint correctly
1412
1413         * rendering/InlineTextBox.cpp:
1414         (WebCore::InlineTextBox::paint): Paint the text box if it is within the maximum
1415         possible horizontal shadow overflow of the damage rect.
1416         * rendering/InlineTextBox.h: Removed unused function checkVerticalPoint().
1417         * rendering/RenderFlow.cpp:
1418         (WebCore::RenderFlow::paintLines): Use the vertical overflows instead of the
1419         selection vertical bounds.
1420         (WebCore::RenderFlow::hitTestLines):
1421         * rendering/render_line.cpp:
1422         (WebCore::InlineFlowBox::placeBoxesHorizontally): Include overflow due to text shadow
1423         in leftPosition and rightPosition and keep track of the maximum horizontal shadow
1424         on the inline.
1425         (WebCore::InlineFlowBox::verticallyAlignBoxes):
1426         (WebCore::InlineFlowBox::placeBoxesVertically): Include overflow due to shadow and
1427         inline-blocks' overflow in topPosition and bottomPosition but not in the selection
1428         vertical bounds.
1429         (WebCore::RootInlineBox::selectionTop):
1430         * rendering/render_line.h:
1431         (WebCore::InlineFlowBox:::InlineRunBox):
1432         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
1433         (WebCore::InlineFlowBox::maxHorizontalShadow):
1434         (WebCore::RootInlineBox::setVerticalSelectionPositions):
1435         (WebCore::RootInlineBox::selectionBottom):
1436         (WebCore::RootInlineBox::selectionHeight):
1437
1438 2006-03-30  Beth Dakin  <bdakin@apple.com>
1439
1440         Reviewed by Hyatt.
1441
1442         Fix for <rdar://problem/4472371> REGRESSION(417.9-TOT): Focus ring 
1443         around link in overflow:auto div isn't clipped to div
1444
1445         Focus rings around the children off overflow:auto divs were not 
1446         being appropriately clipped because they were being painted with 
1447         the div's outlineRect, when they should be painted separately. This 
1448         patch adds two new PaintPhases -- PaintPhaseSelfOutline and 
1449         PaintPhaseChildOutlines -- to address this problem.
1450
1451         This patch also changes the name of PaintAction back to PaintPhase. 
1452         Because Hyatt said so.
1453
1454         * kcanvas/KCanvasResources.cpp:
1455         (WebCore::KCanvasMarker::draw):
1456         * kcanvas/RenderPath.cpp:
1457         (WebCore::RenderPath::paint):
1458         * kcanvas/RenderSVGImage.cpp:
1459         (WebCore::RenderSVGImage::paint):
1460         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1461         (WebCore::KCanvasContainerQuartz::paint):
1462         * ksvg2/svg/SVGMaskElement.cpp:
1463         (WebCore::SVGMaskElement::drawMaskerContent):
1464         * ksvg2/svg/SVGPatternElement.cpp:
1465         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1466         * rendering/InlineTextBox.cpp:
1467         (WebCore::InlineTextBox::paint):
1468         * rendering/RenderBlock.cpp:
1469         (WebCore::RenderBlock::paint):
1470         (WebCore::RenderBlock::paintChildren):
1471         (WebCore::RenderBlock::paintObject):
1472         (WebCore::RenderBlock::paintFloats):
1473         (WebCore::RenderBlock::paintEllipsisBoxes):
1474         (WebCore::RenderBlock::paintSelection):
1475         * rendering/RenderBox.cpp:
1476         (WebCore::RenderBox::setStyle):
1477         * rendering/RenderCanvas.cpp:
1478         (WebCore::RenderCanvas::paint):
1479         * rendering/RenderFlow.cpp:
1480         (WebCore::RenderFlow::paintLines):
1481         * rendering/RenderHTMLCanvas.cpp:
1482         (WebCore::RenderHTMLCanvas::paint):
1483         * rendering/RenderImage.cpp:
1484         (WebCore::RenderImage::paint):
1485         * rendering/RenderLayer.cpp:
1486         (WebCore::RenderLayer::paintLayer):
1487         * rendering/RenderObject.cpp:
1488         (WebCore::RenderObject::maximalOutlineSize):
1489         * rendering/RenderObject.h:
1490         (WebCore::):
1491         (WebCore::RenderObject::PaintInfo::PaintInfo):
1492         * rendering/RenderTable.cpp:
1493         (WebCore::RenderTable::paint):
1494         * rendering/RenderTableCell.cpp:
1495         (WebCore::RenderTableCell::paint):
1496         * rendering/RenderTableRow.cpp:
1497         (WebCore::RenderTableRow::paint):
1498         * rendering/RenderTableSection.cpp:
1499         (WebCore::RenderTableSection::paint):
1500         * rendering/render_button.cpp:
1501         (WebCore::RenderButton::paintObject):
1502         * rendering/render_line.cpp:
1503         (WebCore::InlineBox::paint):
1504         (WebCore::InlineFlowBox::paint):
1505         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
1506         (WebCore::RootInlineBox::paintEllipsisBox):
1507         * rendering/render_list.cpp:
1508         (WebCore::RenderListMarker::paint):
1509         * rendering/render_replaced.cpp:
1510         (WebCore::RenderReplaced::shouldPaint):
1511         (WebCore::RenderWidget::paint):
1512
1513 2006-03-30  Tim Omernick  <timo@apple.com>
1514
1515         Manual test case for the Java aspect of <rdar://problem/4212626> REGRESSION: LIVECONNECT:
1516         JavaScript type for Java Strings is function, not object
1517
1518         * manual-tests/java-string-object-type.html: Added.
1519         * manual-tests/resources/StringTypeTest.class: Added.
1520         * manual-tests/resources/StringTypeTest.java: Added.
1521
1522 2006-03-30  Eric Seidel  <eseidel@apple.com>
1523
1524         Reviewed by hyatt.
1525
1526         Fix text form controls, and add basic submit support!
1527
1528         * bridge/win/FrameWin.cpp:
1529         (WebCore::FrameWin::submitForm):
1530         * bridge/win/FrameWin.h:
1531         * platform/win/KeyEventWin.cpp:
1532         (WebCore::keyIdentifierForWindowsKeyCode):
1533         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
1534         * platform/win/TemporaryLinkStubs.cpp:
1535         (FrameWin::incomingReferrer):
1536         * platform/win/TransferJobWin.cpp:
1537         (WebCore::TransferJob::start):
1538
1539 2006-03-30  Adele Peterson  <adele@apple.com>
1540
1541         Reviewed by Justin.
1542
1543         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8083
1544         REGRESSION: Repro crash when dragging to select over a new text field
1545
1546         * editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent):
1547         When searching for non-editable content, if the end of the selection is in a 
1548         shadow tree, then we need to jump out of that first.
1549
1550 2006-03-30  Justin Garcia  <justin.garcia@apple.com>
1551
1552         Reviewed by darin
1553         
1554         http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
1555         REGRESSION: Plain-text mode needed for contenteditable area used in new text field
1556
1557         * bridge/mac/WebCoreFrameBridge.h:
1558         * bridge/mac/WebCoreFrameBridge.mm:
1559         (-[WebCoreFrameBridge isSelectionEditable]):
1560         (-[WebCoreFrameBridge isSelectionRichlyEditable]):
1561         * css/CSSComputedStyleDeclaration.cpp:
1562         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1563         * css/CSSValueKeywords.in:
1564         * css/cssparser.cpp:
1565         (WebCore::CSSParser::parseValue):
1566         * dom/Node.cpp:
1567         (WebCore::Node::isContentRichlyEditable):
1568         * dom/Node.h:
1569         * editing/EditCommand.cpp:
1570         (WebCore::EditCommand::apply):
1571         * editing/JSEditor.cpp:
1572         * editing/ReplaceSelectionCommand.cpp:
1573         (WebCore::ReplacementFragment::ReplacementFragment):
1574         (WebCore::ReplaceSelectionCommand::doApply):
1575         * editing/Selection.h:
1576         (WebCore::Selection::rootEditableElement):
1577         (WebCore::Selection::isContentEditable):
1578         (WebCore::Selection::isContentRichlyEditable):
1579         * editing/SelectionController.h:
1580         (WebCore::SelectionController::rootEditableElement):
1581         (WebCore::SelectionController::isContentEditable):
1582         (WebCore::SelectionController::isContentRichlyEditable):
1583         * html/HTMLElement.cpp:
1584         (WebCore::HTMLElement::isContentEditable):
1585         (WebCore::HTMLElement::contentEditable):
1586         (WebCore::HTMLElement::setContentEditable):
1587         * rendering/RenderTextField.cpp:
1588         (WebCore::RenderTextField::createDivStyle):
1589         * rendering/render_style.h:
1590         (WebCore::):
1591         
1592 2006-03-30  David Harrison  <harrison@apple.com>
1593
1594         Reviewed by Justin.
1595
1596         <rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"
1597
1598         * editing/DeleteSelectionCommand.cpp:
1599         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1600         Formatting.
1601         (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
1602         Generalize check that preserves nesting when deleting to the beginning of an ancestor block.
1603
1604         * editing/deleting/delete-block-merge-contents-022.html: Added.
1605         * editing/deleting/delete-block-merge-contents-023.html: Added.
1606         * editing/deleting/delete-block-merge-contents-024.html: Added.
1607
1608 2006-03-30  Mitz Pettel  <opendarwin.org@mitzpettel.com>
1609
1610         Reviewed by Darin.
1611
1612         - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8076
1613           REGRESSION: native text fields are reversed on "visual Hebrew" pages
1614
1615         * fast/forms/visual-hebrew-text-field-expected.checksum: Added.
1616         * fast/forms/visual-hebrew-text-field-expected.png: Added.
1617         * fast/forms/visual-hebrew-text-field-expected.txt: Added.
1618         * fast/forms/visual-hebrew-text-field.html: Added.
1619
1620 2006-03-30  Alexey Proskuryakov  <ap@nypop.com>
1621
1622         Reviewed by John Sullivan.
1623
1624         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8051
1625           Empty forms are submitted incorrectly
1626
1627         Test: fast/forms/empty-get.html
1628
1629         * platform/KURL.cpp:
1630         (KURL::setQuery): Add a question mark for empty query strings, too.
1631
1632 2006-03-30  Dave Hyatt <hyatt@apple.com>
1633
1634         Roll out the fix to 7102 and reopen it to get Spinneret working
1635         again.
1636
1637         Reviewed by justin
1638
1639         * page/Frame.cpp:
1640         (WebCore::Frame::didOpenURL):
1641         (WebCore::Frame::receivedFirstData):
1642         (WebCore::Frame::begin):
1643
1644 2006-03-30  Dave Hyatt <hyatt@apple.com>
1645
1646         Land support for JPEG image decoding on Win32.
1647
1648         * WebCore.vcproj/WebCore/WebCore.vcproj:
1649         * platform/cairo/ImageSourceCairo.cpp:
1650         (WebCore::createDecoder):
1651         (WebCore::ImageSource::frameHasAlphaAtIndex):
1652         * platform/image-decoders/ImageDecoder.h:
1653         (WebCore::RGBA32Buffer::setRGBA):
1654         (WebCore::ImageDecoder::supportsAlpha):
1655         * platform/image-decoders/gif/GIFImageDecoder.cpp:
1656         (WebCore::GIFImageDecoder::haveDecodedRow):
1657         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1658         (WebCore::JPEGImageReader::JPEGImageReader):
1659         (WebCore::JPEGImageReader::close):
1660         (WebCore::JPEGImageReader::skipBytes):
1661         (WebCore::JPEGImageReader::decode):
1662         (WebCore::JPEGImageReader::info):
1663         (WebCore::JPEGImageReader::samples):
1664         (WebCore::JPEGImageReader::decoder):
1665         (WebCore::error_exit):
1666         (WebCore::init_source):
1667         (WebCore::skip_input_data):
1668         (WebCore::fill_input_buffer):
1669         (WebCore::term_source):
1670         (WebCore::JPEGImageDecoder::decode):
1671         (WebCore::JPEGImageDecoder::outputScanlines):
1672         (WebCore::JPEGImageDecoder::jpegComplete):
1673         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
1674         (WebCore::JPEGImageDecoder::supportsAlpha):
1675         (WebCore::JPEGImageDecoder::setSize):
1676         * platform/image-decoders/png/PNGImageDecoder.cpp:
1677         (WebCore::PNGImageDecoder::rowAvailable):
1678
1679 2006-03-29  Justin Garcia  <justin.garcia@apple.com>
1680
1681         Reviewed by darin
1682         
1683         <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
1684         REGRESSION: selectionRect includes next/previous replaced elements
1685         Also fixes: <rdar://problems/4402375&4474871&4492934>
1686         
1687         In the case where a selection starts at the end or ends at the start
1688         of o, o->selectionState() != SelectionNone, but o isn't really selected.  
1689         Constraining the selection with upstream and downstream eliminates these
1690         types of endpoints, but constraining endpoints that occur at the 
1691         start or end of a paragraph creates positions inside containers - some 
1692         of which the selection painting code isn't equipped to handle.
1693
1694         * dom/Document.cpp:
1695         (WebCore::Document::updateSelection):
1696         * rendering/render_replaced.cpp:
1697         (WebCore::RenderReplaced::shouldPaint):
1698         (WebCore::RenderReplaced::selectionRect):
1699         (WebCore::RenderReplaced::setSelectionState):
1700         (WebCore::RenderWidget::setSelectionState):
1701
1702 2006-03-29  Adele Peterson  <adele@apple.com>
1703
1704         Reviewed by Hyatt.
1705
1706         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
1707         Switch to use new text field implementation for <input type="text">
1708
1709         * css/html4.css: Added default style info for new text fields.
1710         * rendering/RenderTextField.cpp:
1711         (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla.
1712         (WebCore::RenderTextField::updateFromElement): Removed some outdated comments.  Cleaned up the way we add text nodes to the div.
1713         (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior.
1714         (WebCore::RenderTextField::setSelectionEnd): ditto.
1715         (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange.
1716         (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred.
1717         (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
1718         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from 
1719          the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
1720         * rendering/RenderThemeMac.mm:
1721         (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border.
1722         (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css. 
1723          We also add intrinsic margins here if the font size is large enough.
1724         * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
1725          No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
1726         * html/HTMLInputElement.cpp:
1727         (WebCore::HTMLInputElement::isKeyboardFocusable): ditto.
1728         (WebCore::HTMLInputElement::focus): ditto.
1729         (WebCore::HTMLInputElement::selectionStart): ditto.
1730         (WebCore::HTMLInputElement::selectionEnd): ditto.
1731         (WebCore::HTMLInputElement::setSelectionStart): ditto.
1732         (WebCore::HTMLInputElement::setSelectionEnd): ditto.
1733         (WebCore::HTMLInputElement::select): ditto.
1734         (WebCore::HTMLInputElement::setSelectionRange): ditto.
1735         (WebCore::HTMLInputElement::createRenderer): ditto.
1736         (WebCore::HTMLInputElement::defaultEventHandler): ditto.
1737         (WebCore::HTMLInputElement::isMouseFocusable): Added.  Old text fields relied on the widget to provide a focus policy.  
1738          A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
1739         * html/HTMLInputElement.h: Added isMouseFocusable.
1740         * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable):
1741          Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
1742         * dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.
1743
1744 2006-03-29  Darin Adler  <darin@apple.com>
1745
1746         Reviewed by Eric.
1747
1748         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8026
1749           A particular animated SVG crashes in filter code
1750           <rdar://problem/4494775> A particular animated SVG crashes in filter code
1751
1752         - fix some code that is not handling references correctly for GC
1753
1754         Test: svg/custom/empty-merge.svg
1755
1756         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1757         (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): Use KWQRetainNSRelease to
1758         properly retain a reference to an Objective-C object in a C++ class.
1759         (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): Use KWQRelease instead of
1760         release.
1761         (WebCore::KCanvasFilterQuartz::prepareFilter): Use KWQRetain instead of retain.
1762         (WebCore::KCanvasFilterQuartz::applyFilter): Use KWQRelease instead of release.
1763         (WebCore::KCanvasFilterQuartz::imageForName): Use objectForKey: instead of
1764         valueForKey: on the dictionary to sidestep a bug in valueForKey: on empty strings
1765         and because what we're doing with a dictionary here has nothing to do with
1766         key value encoding.
1767
1768         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1769         (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
1770         Use KWQRelease instead of release.
1771         (WebCore::KRenderingDeviceContextQuartz::nsGraphicsContext): Use KWQRetain
1772         instead of retain to properly retain a reference to an Objective-C object
1773         in a C++ class.
1774
1775         * platform/mac/ImageMac.mm:
1776         (WebCore::Image::invalidateNativeData): Use CFRelease instead of release.
1777         (WebCore::Image::getNSImage): Use KWQRetainNSRelease to properly retain
1778         a reference to an Objective-C object in a C++ class.
1779
1780 2006-03-29  Geoffrey Garen  <ggaren@apple.com>
1781
1782         Reviewed by Darin.
1783
1784         - WebCore side of fix for <rdar://problem/4308243> 8F36 Regression: 
1785         crash in malloc_consolidate if you use a .PAC file
1786
1787         (1) To ensure thread-safe deallocation, set the "unsafe to destroy on 
1788         non-main threads" bit in the DOMObject constructor.
1789
1790         (2) Made all binding objects inherit from DOMObject, because the
1791         WebCore data structures they wrap are not thread-safe. "DOMObject" is
1792         a slightly awkward name for things like the Window object, but the 
1793         DOM spec is considering adding a Window object, and creating a whole
1794         new base class for this purpose seemed like overkill.
1795
1796         * khtml/ecma/JSDOMParser.h:
1797         * khtml/ecma/JSXMLHttpRequest.h:
1798         * khtml/ecma/JSXMLSerializer.cpp:
1799         (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
1800         * khtml/ecma/JSXMLSerializer.h:
1801         * khtml/ecma/JSXSLTProcessor.h:
1802         * khtml/ecma/kjs_binding.h:
1803         (KJS::DOMObject::DOMObject): Unset the "safe to collect on non-main
1804         threads bit" to ensure thread-safe deallocation.
1805         * khtml/ecma/kjs_html.h:
1806         * khtml/ecma/kjs_navigator.cpp:
1807         (KJS::Navigator::Navigator):
1808         (KJS::PluginBase::PluginBase):
1809         * khtml/ecma/kjs_navigator.h:
1810         * khtml/ecma/kjs_proxy.cpp:
1811         * khtml/ecma/kjs_window.cpp:
1812         (KJS::History::History):
1813         (KJS::FrameArray::FrameArray):
1814         (KJS::Screen::Screen):
1815         (KJS::Window::Window):
1816         (KJS::BarInfo::BarInfo):
1817         * khtml/ecma/kjs_window.h:
1818
1819 2006-03-29  Geoffrey Garen  <ggaren@apple.com>
1820
1821         Reviewed by Darin.
1822
1823         - Fixed <rdar://problem/4477126> TOT REGRESSION: with release
1824         build, maps.google.com zoom slider always zooms fully out
1825
1826         There were 2 problems: (1) A syntax error in the UIEvent IDL file
1827         prevented some things from showing up in the bindings; (2)
1828         MouseEvent had a duplicate isSimulated property that shadowed
1829         MouseRelatedEvent's isSimulated property, and MouseEvent failed to
1830         initialize MouseRelatedEvent's isSimulated property.
1831
1832         * dom/UIEvent.idl:
1833         * dom/dom2_eventsimpl.cpp:
1834         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
1835         (WebCore::MouseEvent::MouseEvent):
1836         * dom/dom2_eventsimpl.h:
1837
1838 2006-03-29  Tim Omernick  <timo@apple.com>
1839
1840         Reviewed by Darin.
1841
1842         * html/HTMLInputElement.cpp:
1843         (WebCore::HTMLInputElement::setInputType):
1844         If the input type is dynamically changed, reevaluate whether the element maintains its state
1845         (this decision is based on the input's type).  Fixes an assertion error when leaving a page
1846         with a text field that had been dynamically changed to a password field.
1847
1848 2006-03-29  Alexey Proskuryakov  <ap@nypop.com>
1849
1850         Reviewed by Darin.
1851
1852         - http://bugzilla.opendarwin.org/show_bug.cgi?id=8055
1853           Fix most CSS grammar conflicts.
1854
1855         Gets the number of shift/reduce and reduce/reduce conflicts down from 37+4 to 7+0.
1856
1857         I have fixed the reduce/reduce conflicts, then noticed that two of the fixes
1858         were already made in KDE tree (the other two are different because declaration
1859         blocks are described in quite different ways). Shift/reduce fixes are just
1860         merged from KDE, r332845 by Michael Matz.
1861
1862         * css/CSSGrammar.y:
1863
1864 2006-03-29  Alexey Proskuryakov  <ap@nypop.com>
1865
1866         Reviewed by Darin.
1867
1868         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7157
1869           An asterisk in a CSS property name breaks CSS handling 
1870           (Many layout problems at letras.terra.com.br)
1871
1872         Test: fast/css/error-in-last-decl.html
1873
1874         * css/CSSGrammar.y: Added a rule for the case when the last CSS rule 
1875           has a syntax error, and doesn't end with a semicolon.
1876
1877 2006-03-29  Darin Adler  <darin@apple.com>
1878
1879         Reviewed by Anders.
1880
1881         - another cut at fixing the buildbot
1882
1883         * generate-derived-sources: Fix if statement that was always following
1884         the Windows case. I believe this is the main problem.
1885
1886         * WebCore.xcodeproj/project.pbxproj: Added CharsetData.h and added CharsetData.cpp
1887         to the target.
1888         * WebCore.vcproj/WebCore/WebCore.vcproj: Similar changes.
1889
1890         * platform/CharsetData.h: Added.
1891         * platform/CharsetNames.cpp: Moved the actual character set data out into a
1892         separate source file instead of include a .cpp file.
1893
1894         * platform/make-charset-table.pl: Changed to generate a file that can stand alone.
1895
1896 2006-03-29  Darin Adler  <darin@apple.com>
1897
1898         - an attempt to fix the buildbot
1899
1900         * platform/mac/mac-encodings.txt: Touched this file so the character encodings
1901         files will be regenerated.
1902
1903 2006-03-29  Darin Adler  <darin@apple.com>
1904
1905         - a quick cut at fixing the windows build
1906
1907         * WebCore.vcproj/WebCore/WebCore.vcproj: Added a few recently-added files.
1908
1909 2006-03-29  Maciej Stachowiak  <mjs@apple.com>
1910
1911         Reviewed by Anders.
1912         
1913         - fixed  <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating
1914         
1915         Also fixed other issues with contains. The problem that caused the bug was:
1916         - contains should return true for the element itself, unlike isAncestor
1917         
1918         Other problems I fixed:
1919         - contains shouldn't be present on non-Element nodes
1920         - contains should return false when passed a non-Element node
1921         - contains should return false when passed a non-Node
1922
1923         * bindings/scripts/CodeGeneratorJS.pm: Handle Element as a parameter.
1924         * dom/Element.cpp:
1925         (WebCore::Element::contains): Added new implementation.
1926         * dom/Element.h: Added prototype for contains.
1927         * dom/Element.idl: Added IDL declaration for contains.
1928         * khtml/ecma/kjs_dom.cpp:
1929         (KJS::DOMNodeProtoFunc::callAsFunction): Added old wrong contains().
1930
1931 2006-03-28  Beth Dakin  <bdakin@apple.com>
1932
1933         Reviewed by Maciej
1934
1935         Fix for <rdar://problem/4493218> repro crash in 
1936         khtml::RenderBlock::repaintFloatingDescendants with giant 
1937         cellspacing value
1938
1939         Some callers of CSSPrimitiveValue::computeLength() expect an int, 
1940         and others a short. This patch splits computeLength() into 
1941         computeIntLength() and computeShortLength() so that the appropriate 
1942         bounds can be checked. 
1943
1944         * css/css_valueimpl.cpp:
1945         (WebCore::CSSPrimitiveValue::computeIntLength): Return 0 if not 
1946         within int bounds.
1947         (WebCore::CSSPrimitiveValue::computeShortLength): Return 0 if not 
1948         within short bounds.
1949         * css/css_valueimpl.h:
1950         * css/cssstyleselector.cpp:
1951         (WebCore::convertToLength): Switch to appropriate computeLength() 
1952         call.
1953         (WebCore::CSSStyleSelector::applyProperty): Same.
1954         (WebCore::CSSStyleSelector::mapBackgroundXPosition): Same.
1955         (WebCore::CSSStyleSelector::mapBackgroundYPosition): Same.
1956         * rendering/RenderBlock.cpp:
1957         (WebCore::RenderBlock::repaintFloatingDescendants): Nil check 
1958         m_floatingObjects and add an assertion. This is not necessary for 
1959         the fix, it is just because we are not sure that it is safe not to 
1960         nil-check, and we want to prevent potential problems in release 
1961         builds, and catch them with the assertion in debug builds.
1962         (WebCore::RenderBlock::addOverhangingFloats): Same as above.
1963
1964 2006-03-28  Alexey Proskuryakov  <ap@nypop.com>
1965
1966         Reviewed by Maciej.
1967
1968         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4616
1969           Setting nodeValue on a textnode with collapsed whitespace only has no visual effect
1970
1971         Test: fast/dom/space-to-text.html
1972
1973         * dom/CharacterData.cpp:
1974         (WebCore::CharacterData::setData): Create a renderer if it's needed, but missing.
1975         (WebCore::CharacterData::appendData): Ditto.
1976         (WebCore::CharacterData::insertData): Ditto.
1977         (WebCore::CharacterData::replaceData): Ditto.
1978
1979 2006-03-28  Tim Omernick  <timo@apple.com>
1980
1981         Reviewed by Maciej.
1982
1983         <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating
1984         to another page while selecting inside textarea inside iframe
1985
1986         * kwq/WebCoreTextArea.mm:
1987         (-[WebCoreTextArea mouseDown:]):
1988         Guard super's -mouseDown: with calls to Widget::beforeMouseDown() and Widget::afterMouseDown().
1989         Other widgets do this to protect against being removed from the page and deallocated while handling
1990         mouse down events.
1991         (-[WebCoreTextView mouseDown:]):
1992         ditto
1993
1994         * manual-tests/textarea-iframe-navigation.html: Added.
1995         * manual-tests/textarea-iframe-navigation2.html: Added.
1996         Manual test case for this fix.
1997
1998 2006-03-28  Eric Seidel  <eseidel@apple.com>
1999
2000         Reviewed by darin.
2001
2002         <rdar://problem/4402170> CrashTracer: 499 crashes in Safari at com.apple.WebCore: DOM::DocumentImpl::open + 16
2003
2004         * dom/Document.cpp:
2005         (WebCore::Document::write): Fix unreproducible infinite recursion.
2006
2007 2006-03-28  Eric Seidel  <eseidel@apple.com>
2008
2009         Reviewed by darin.
2010
2011         Remove global initializers.
2012
2013         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2014         * ksvg2/svg/SVGAngle.cpp:
2015         * ksvg2/svg/SVGColor.cpp:
2016         * ksvg2/svg/SVGLength.cpp:
2017
2018 2006-03-28  Eric Seidel  <eseidel@apple.com>
2019
2020         Reviewed by darin.
2021
2022         Switch UIEvent, MouseEvent and KeyboardEvent over to
2023         be new auto-generated bindings.
2024         http://bugzilla.opendarwin.org/show_bug.cgi?id=7928
2025
2026         Updated test: fast/dom/prototype-chain.html
2027
2028         * WebCore.xcodeproj/project.pbxproj:
2029         * bindings/objc/DOMEvents.mm:
2030         (-[DOMEvent ::]):
2031         (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
2032         * bindings/scripts/CodeGeneratorJS.pm:
2033         * dom/EventTargetNode.cpp:
2034         (WebCore::EventTargetNode::dispatchMouseEvent):
2035         * dom/KeyboardEvent.idl: Added.
2036         * dom/MouseEvent.idl: Added.
2037         * dom/UIEvent.idl: Added.
2038         * dom/WheelEvent.idl:
2039         * dom/dom2_eventsimpl.cpp:
2040         (WebCore::MouseEvent::MouseEvent):
2041         (WebCore::MouseEvent::initMouseEvent):
2042         * dom/dom2_eventsimpl.h:
2043         (WebCore::MouseEvent::relatedTarget):
2044         (WebCore::MouseEvent::clipboard):
2045         * generate-derived-sources:
2046         * khtml/ecma/kjs_dom.cpp:
2047         (KJS::toEventTargetNode):
2048         * khtml/ecma/kjs_dom.h:
2049         * khtml/ecma/kjs_events.cpp:
2050         (KJS::toJS):
2051         * khtml/ecma/kjs_events.h:
2052
2053 2006-03-28  Darin Adler  <darin@apple.com>
2054
2055         Reviewed by Eric.
2056
2057         - replace getDocument with document in a few places that Geoff missed
2058
2059         * WebCore.xcodeproj/project.pbxproj:
2060         * dom/Attr.cpp:
2061         (WebCore::Attr::createTextChild):
2062         (WebCore::Attr::setValue):
2063         (WebCore::Attr::cloneNode):
2064         * dom/Attribute.cpp:
2065         (WebCore::Attribute::createAttrIfNeeded):
2066         * dom/Element.cpp:
2067         (WebCore::Element::cloneNode):
2068         (WebCore::inHTMLDocument):
2069         (WebCore::Element::setAttribute):
2070         (WebCore::Element::setAttributeMap):
2071         (WebCore::Element::createStyleForRenderer):
2072         (WebCore::Element::createRenderer):
2073         (WebCore::Element::recalcStyle):
2074         (WebCore::Element::dispatchAttrRemovalEvent):
2075         (WebCore::Element::dispatchAttrAdditionEvent):
2076         (WebCore::Element::updateId):
2077         (WebCore::Element::removeAttributeNode):
2078         (WebCore::Element::focus):
2079         (WebCore::Element::blur):
2080         * dom/NamedAttrMap.cpp:
2081         (WebCore::inHTMLDocument):
2082         (WebCore::NamedAttrMap::setNamedItem):
2083         * dom/NamedMappedAttrMap.cpp:
2084         (WebCore::NamedMappedAttrMap::parseClassAttribute):
2085         * dom/StyledElement.cpp:
2086         (WebCore::StyledElement::createInlineStyleDecl):
2087         (WebCore::StyledElement::parseMappedAttribute):
2088         (WebCore::StyledElement::createMappedDecl):
2089
2090         - added missing include that seems to be breaking the Windows build
2091
2092         * platform/String.cpp: Include <stdarg.h>.
2093
2094 2006-03-28  Geoffrey Garen  <ggaren@apple.com>
2095
2096         Reviewed by Beth.
2097
2098         - Global replace of getDocument() with document(). Darin suggested this
2099         in his review of my EventTargetNode patch. It matches the style of
2100         methods like ownerDocument().
2101
2102         - Changed getDocument() to document(); changed data member document to
2103         m_document; changed stack variable document to doc.
2104
2105         * bindings/objc/DOM.mm:
2106         (-[DOMNode ownerDocument]):
2107         (-[DOMNode KJS::Bindings::]):
2108         (-[DOMElement _getURLAttribute:]):
2109         * bindings/objc/DOMHTML.mm:
2110         (-[DOMHTMLElement titleDisplayString]):
2111         (-[DOMHTMLInputElement altDisplayString]):
2112         (-[DOMHTMLAnchorElement blur]):
2113         (-[DOMHTMLAnchorElement focus]):
2114         (-[DOMHTMLImageElement altDisplayString]):
2115         (-[DOMHTMLAppletElement altDisplayString]):
2116         (-[DOMHTMLAreaElement altDisplayString]):
2117         * bindings/objc/DOMInternal.mm:
2118         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2119         * bridge/mac/FrameMac.mm:
2120         (WebCore::FrameMac::attributedString):
2121         * bridge/mac/FrameViewMac.mm:
2122         (WebCore::FrameView::updateDashboardRegions):
2123         * bridge/mac/WebCoreFrameBridge.mm:
2124         (-[WebCoreFrameBridge initSubframeWithRenderer:]):
2125         (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
2126         (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
2127         * css/CSSComputedStyleDeclaration.cpp:
2128         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2129         * css/css_base.cpp:
2130         (WebCore::StyleBase::baseURL):
2131         * css/css_stylesheetimpl.cpp:
2132         (WebCore::CSSStyleSheet::CSSStyleSheet):
2133         * css/cssstyleselector.cpp:
2134         (WebCore::CSSStyleSelector::initForStyleResolve):
2135         (WebCore::CSSStyleSelector::canShareStyleWithElement):
2136         (WebCore::CSSStyleSelector::locateSharedStyle):
2137         (WebCore::CSSStyleSelector::createStyleForElement):
2138         (WebCore::CSSStyleSelector::createPseudoStyleForElement):
2139         (WebCore::CSSStyleSelector::adjustRenderStyle):
2140         (WebCore::CSSStyleSelector::styleRulesForElement):
2141         (WebCore::CSSStyleSelector::checkOneSelector):
2142         (WebCore::CSSStyleSelector::applyProperty):
2143         (WebCore::CSSStyleSelector::mapBackgroundImage):
2144         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
2145         * dom/AbstractView.cpp:
2146         (WebCore::AbstractView::AbstractView):
2147         * dom/CDATASection.cpp:
2148         (WebCore::CDATASection::cloneNode):
2149         (WebCore::CDATASection::createNew):
2150         * dom/CharacterData.cpp:
2151         (WebCore::CharacterData::setData):
2152         (WebCore::CharacterData::insertData):
2153         (WebCore::CharacterData::deleteData):
2154         (WebCore::CharacterData::replaceData):
2155         (WebCore::CharacterData::dispatchModifiedEvent):
2156         * dom/Comment.cpp:
2157         (WebCore::Comment::cloneNode):
2158         * dom/ContainerNode.cpp:
2159         (WebCore::ContainerNode::insertBefore):
2160         (WebCore::ContainerNode::replaceChild):
2161         (WebCore::ContainerNode::removeChild):
2162         (WebCore::ContainerNode::appendChild):
2163         (WebCore::ContainerNode::addChild):
2164         (WebCore::ContainerNode::getUpperLeftCorner):
2165         (WebCore::dispatchChildInsertionEvents):
2166         (WebCore::dispatchChildRemovalEvents):
2167         * dom/DOMImplementation.cpp:
2168         (WebCore::DOMImplementation::createDocument):
2169         * dom/Document.cpp:
2170         (WebCore::Document::Document):
2171         (WebCore::Document::~Document):
2172         (WebCore::Document::createDocumentFragment):
2173         (WebCore::Document::adoptNode):
2174         (WebCore::Document::createElementNS):
2175         (WebCore::Document::nodeAbsIndex):
2176         (WebCore::Document::setFocusNode):
2177         (WebCore::Document::topDocument):
2178         * dom/DocumentFragment.cpp:
2179         (WebCore::DocumentFragment::cloneNode):
2180         * dom/EventTargetNode.cpp:
2181         (WebCore::EventTargetNode::~EventTargetNode):
2182         (WebCore::EventTargetNode::insertedIntoDocument):
2183         (WebCore::EventTargetNode::removedFromDocument):
2184         (WebCore::EventTargetNode::addEventListener):
2185         (WebCore::EventTargetNode::removeEventListener):
2186         (WebCore::EventTargetNode::dispatchGenericEvent):
2187         (WebCore::EventTargetNode::dispatchEvent):
2188         (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
2189         (WebCore::EventTargetNode::dispatchWindowEvent):
2190         (WebCore::EventTargetNode::dispatchUIEvent):
2191         (WebCore::EventTargetNode::dispatchKeyEvent):
2192         (WebCore::EventTargetNode::dispatchMouseEvent):
2193         (WebCore::EventTargetNode::dispatchWheelEvent):
2194         (WebCore::EventTargetNode::removeHTMLEventListener):
2195         * dom/Node.cpp:
2196         (WebCore::Node::Node):
2197         (WebCore::Node::setDocument):
2198         (WebCore::Node::setChanged):
2199         (WebCore::Node::checkSetPrefix):
2200         (WebCore::Node::checkAddChild):
2201         (WebCore::Node::attach):
2202         (WebCore::Node::detach):
2203         (WebCore::Node::createRendererIfNeeded):
2204         (WebCore::Node::rendererIsNeeded):
2205         (WebCore::Node::getElementsByTagNameNS):
2206         (WebCore::Node::ownerDocument):
2207         (WebCore::Node::setTextContent):
2208         * dom/Node.h:
2209         (WebCore::Node::document):
2210         (WebCore::Node::inDocument):
2211         * dom/NodeList.cpp:
2212         (WebCore::NodeList::itemById):
2213         * dom/Position.cpp:
2214         (WebCore::Position::documentElement):
2215         * dom/Range.cpp:
2216         (WebCore::Range::commonAncestorContainer):
2217         (WebCore::Range::setStart):
2218         (WebCore::Range::setEnd):
2219         (WebCore::Range::compareBoundaryPoints):
2220         (WebCore::Range::insertNode):
2221         (WebCore::Range::text):
2222         (WebCore::Range::setStartAfter):
2223         (WebCore::Range::setEndBefore):
2224         (WebCore::Range::setEndAfter):
2225         (WebCore::Range::surroundContents):
2226         (WebCore::Range::setStartBefore):
2227         (WebCore::rangeOfContents):
2228         * dom/Text.cpp:
2229         (WebCore::Text::cloneNode):
2230         (WebCore::Text::createNew):
2231         * dom/dom2_eventsimpl.cpp:
2232         (WebCore::MouseRelatedEvent::receivedTarget):
2233         * dom/dom2_traversalimpl.cpp:
2234         (WebCore::NodeIterator::NodeIterator):
2235         * dom/dom_elementimpl.cpp:
2236         (WebCore::Attribute::createAttrIfNeeded):
2237         (WebCore::Attr::createTextChild):
2238         (WebCore::Attr::setValue):
2239         (WebCore::Attr::cloneNode):
2240         (WebCore::Element::cloneNode):
2241         (WebCore::inHTMLDocument):
2242         (WebCore::Element::setAttribute):
2243         (WebCore::Element::setAttributeMap):
2244         (WebCore::Element::createStyleForRenderer):
2245         (WebCore::Element::createRenderer):
2246         (WebCore::Element::recalcStyle):
2247         (WebCore::Element::dispatchAttrRemovalEvent):
2248         (WebCore::Element::dispatchAttrAdditionEvent):
2249         (WebCore::Element::updateId):
2250         (WebCore::Element::removeAttributeNode):
2251         (WebCore::Element::focus):
2252         (WebCore::Element::blur):
2253         (WebCore::NamedAttrMap::setNamedItem):
2254         (WebCore::NamedMappedAttrMap::parseClassAttribute):
2255         (WebCore::StyledElement::createInlineStyleDecl):
2256         (WebCore::StyledElement::parseMappedAttribute):
2257         (WebCore::StyledElement::createMappedDecl):
2258         * dom/dom_xmlimpl.cpp:
2259         (WebCore::EntityReference::cloneNode):
2260         (WebCore::ProcessingInstruction::cloneNode):
2261         (WebCore::ProcessingInstruction::checkStyleSheet):
2262         (WebCore::ProcessingInstruction::sheetLoaded):
2263         (WebCore::ProcessingInstruction::setStyleSheet):
2264         * dom/xml_tokenizer.cpp:
2265         (WebCore::XMLTokenizer::XMLTokenizer):
2266         * editing/ReplaceSelectionCommand.cpp:
2267         (WebCore::ReplacementFragment::ReplacementFragment):
2268         (WebCore::ReplaceSelectionCommand::fixupNodeStyles):
2269         (WebCore::styleForNode):
2270         * editing/Selection.cpp:
2271         (WebCore::Selection::toRange):
2272         * editing/SelectionController.cpp:
2273         (WebCore::SelectionController::~SelectionController):
2274         (WebCore::SelectionController::setSelection):
2275         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
2276         (WebCore::SelectionController::frame):
2277         (WebCore::SelectionController::layout):
2278         (WebCore::SelectionController::needsCaretRepaint):
2279         * editing/TextIterator.cpp:
2280         (WebCore::TextIterator::range):
2281         (WebCore::SimplifiedBackwardsTextIterator::range):
2282         * editing/VisiblePosition.cpp:
2283         (WebCore::VisiblePosition::init):
2284         (WebCore::makeRange):
2285         * editing/markup.cpp:
2286         (WebCore::startMarkup):
2287         (WebCore::shouldSelfClose):
2288         (WebCore::markup):
2289         (WebCore::createMarkup):
2290         * editing/visible_units.cpp:
2291         (WebCore::previousBoundary):
2292         (WebCore::nextBoundary):
2293         (WebCore::previousLinePosition):
2294         (WebCore::nextLinePosition):
2295         (WebCore::inSameDocument):
2296         * html/HTMLCollection.cpp:
2297         (WebCore::HTMLCollection::HTMLCollection):
2298         (WebCore::HTMLCollection::resetCollectionInfo):
2299         * html/HTMLElement.cpp:
2300         (WebCore::HTMLElement::nodeName):
2301         (WebCore::HTMLElement::cloneNode):
2302         (WebCore::HTMLElement::innerText):
2303         (WebCore::HTMLElement::createContextualFragment):
2304         (WebCore::HTMLElement::setInnerText):
2305         (WebCore::HTMLElement::setOuterText):
2306         (WebCore::HTMLElement::isContentEditable):
2307         (WebCore::HTMLElement::contentEditable):
2308         (WebCore::HTMLElement::toString):
2309         (WebCore::HTMLElement::childAllowed):
2310         (WebCore::HTMLElement::setHTMLEventListener):
2311         * html/HTMLFormElement.cpp:
2312         (WebCore::HTMLFormElement::formWouldHaveSecureSubmission):
2313         (WebCore::HTMLFormElement::attach):
2314         (WebCore::HTMLFormElement::insertedIntoDocument):
2315         (WebCore::HTMLFormElement::removedFromDocument):
2316         (WebCore::HTMLFormElement::formData):
2317         (WebCore::HTMLFormElement::prepareSubmit):
2318         (WebCore::HTMLFormElement::submit):
2319         (WebCore::HTMLFormElement::reset):
2320         (WebCore::HTMLFormElement::parseMappedAttribute):
2321         (WebCore::HTMLFormElement::registerFormElement):
2322         (WebCore::HTMLFormElement::removeFormElement):
2323         * html/HTMLGenericFormElement.cpp:
2324         (WebCore::HTMLGenericFormElement::attach):
2325         (WebCore::HTMLGenericFormElement::insertedIntoTree):
2326         (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
2327         * html/HTMLInputElement.cpp:
2328         (WebCore::HTMLInputElement::~HTMLInputElement):
2329         (WebCore::HTMLInputElement::isKeyboardFocusable):
2330         (WebCore::HTMLInputElement::focus):
2331         (WebCore::HTMLInputElement::setInputType):
2332         (WebCore::HTMLInputElement::parseMappedAttribute):
2333         (WebCore::HTMLInputElement::attach):
2334         (WebCore::HTMLInputElement::setChecked):
2335         (WebCore::HTMLInputElement::preDispatchEventHandler):
2336         (WebCore::HTMLInputElement::defaultEventHandler):
2337         (WebCore::HTMLInputElement::src):
2338         * html/HTMLKeygenElement.cpp:
2339         (WebCore::HTMLKeygenElement::appendFormData):
2340         * html/HTMLLabelElement.cpp:
2341         (WebCore::HTMLLabelElement::formElement):
2342         * html/HTMLOptionElement.cpp:
2343         (WebCore::HTMLOptionElement::text):
2344         (WebCore::HTMLOptionElement::setText):
2345         * html/HTMLParser.cpp:
2346         (WebCore::HTMLParser::HTMLParser):
2347         * html/HTMLSelectElement.cpp:
2348         (WebCore::HTMLSelectElement::~HTMLSelectElement):
2349         * html/HTMLTextAreaElement.cpp:
2350         (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement):
2351         (WebCore::HTMLTextAreaElement::setDefaultValue):
2352         * html/HTMLTokenizer.cpp:
2353         (WebCore::HTMLTokenizer::HTMLTokenizer):
2354         * html/html_baseimpl.cpp:
2355         (WebCore::HTMLBodyElement::createLinkDecl):
2356         (WebCore::HTMLBodyElement::mapToEntry):
2357         (WebCore::HTMLBodyElement::parseMappedAttribute):
2358         (WebCore::HTMLBodyElement::insertedIntoDocument):
2359         (WebCore::HTMLFrameElement::isURLAllowed):
2360         (WebCore::HTMLFrameElement::openURL):
2361         (WebCore::HTMLFrameElement::attach):
2362         (WebCore::HTMLFrameElement::close):
2363         (WebCore::HTMLFrameElement::contentFrame):
2364         (WebCore::HTMLFrameElement::frameWidth):
2365         (WebCore::HTMLFrameElement::frameHeight):
2366         (WebCore::HTMLFrameSetElement::parseMappedAttribute):
2367         (WebCore::HTMLIFrameElement::parseMappedAttribute):
2368         (WebCore::HTMLIFrameElement::insertedIntoDocument):
2369         (WebCore::HTMLIFrameElement::removedFromDocument):
2370         (WebCore::HTMLIFrameElement::attach):
2371         (WebCore::HTMLIFrameElement::src):
2372         * html/html_blockimpl.cpp:
2373         (WebCore::HTMLParagraphElement::checkDTD):
2374         * html/html_headimpl.cpp:
2375         (WebCore::HTMLBaseElement::removedFromDocument):
2376         (WebCore::HTMLBaseElement::process):
2377         (WebCore::HTMLLinkElement::setDisabledState):
2378         (WebCore::HTMLLinkElement::parseMappedAttribute):
2379         (WebCore::HTMLLinkElement::process):
2380         (WebCore::HTMLLinkElement::setStyleSheet):
2381         (WebCore::HTMLLinkElement::sheetLoaded):
2382         (WebCore::HTMLLinkElement::href):
2383         (WebCore::HTMLMetaElement::process):
2384         (WebCore::HTMLScriptElement::childrenChanged):
2385         (WebCore::HTMLScriptElement::parseMappedAttribute):
2386         (WebCore::HTMLScriptElement::insertedIntoDocument):
2387         (WebCore::HTMLScriptElement::evaluateScript):
2388         (WebCore::HTMLScriptElement::setText):
2389         (WebCore::HTMLScriptElement::src):
2390         (WebCore::HTMLStyleElement::insertedIntoDocument):
2391         (WebCore::HTMLStyleElement::removedFromDocument):
2392         (WebCore::HTMLStyleElement::childrenChanged):
2393         (WebCore::HTMLStyleElement::sheetLoaded):
2394         (WebCore::HTMLTitleElement::insertedIntoDocument):
2395         (WebCore::HTMLTitleElement::removedFromDocument):
2396         (WebCore::HTMLTitleElement::childrenChanged):
2397         (WebCore::HTMLTitleElement::setText):
2398         * html/html_imageimpl.cpp:
2399         (WebCore::HTMLImageLoader::~HTMLImageLoader):
2400         (WebCore::HTMLImageLoader::updateFromElement):
2401         (WebCore::HTMLImageLoader::notifyFinished):
2402         (WebCore::HTMLImageElement::parseMappedAttribute):
2403         (WebCore::HTMLImageElement::insertedIntoDocument):
2404         (WebCore::HTMLImageElement::removedFromDocument):
2405         (WebCore::HTMLImageElement::width):
2406         (WebCore::HTMLImageElement::height):
2407         (WebCore::HTMLImageElement::src):
2408         (WebCore::HTMLMapElement::~HTMLMapElement):
2409         (WebCore::HTMLMapElement::parseMappedAttribute):
2410         (WebCore::HTMLAreaElement::href):
2411         * html/html_inlineimpl.cpp:
2412         (WebCore::HTMLAnchorElement::isKeyboardFocusable):
2413         (WebCore::HTMLAnchorElement::defaultEventHandler):
2414         (WebCore::HTMLAnchorElement::href):
2415         (WebCore::HTMLAnchorElement::blur):
2416         (WebCore::HTMLAnchorElement::focus):
2417         * html/html_objectimpl.cpp:
2418         (WebCore::HTMLAppletElement::parseMappedAttribute):
2419         (WebCore::HTMLAppletElement::insertedIntoDocument):
2420         (WebCore::HTMLAppletElement::removedFromDocument):
2421         (WebCore::HTMLAppletElement::createRenderer):
2422         (WebCore::HTMLAppletElement::getAppletInstance):
2423         (WebCore::HTMLEmbedElement::getEmbedInstance):
2424         (WebCore::HTMLEmbedElement::parseMappedAttribute):
2425         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2426         (WebCore::HTMLEmbedElement::insertedIntoDocument):
2427         (WebCore::HTMLEmbedElement::removedFromDocument):
2428         (WebCore::HTMLObjectElement::getObjectInstance):
2429         (WebCore::HTMLObjectElement::parseMappedAttribute):
2430         (WebCore::HTMLObjectElement::rendererIsNeeded):
2431         (WebCore::HTMLObjectElement::insertedIntoDocument):
2432         (WebCore::HTMLObjectElement::removedFromDocument):
2433         (WebCore::HTMLObjectElement::updateDocNamedItem):
2434         (WebCore::HTMLParamElement::parseMappedAttribute):
2435         * html/html_tableimpl.cpp:
2436         (WebCore::HTMLTableElement::createTHead):
2437         (WebCore::HTMLTableElement::createTFoot):
2438         (WebCore::HTMLTableElement::createCaption):
2439         (WebCore::HTMLTableElement::insertRow):
2440         (WebCore::HTMLTableElement::addChild):
2441         (WebCore::HTMLTableElement::mapToEntry):
2442         (WebCore::HTMLTableElement::parseMappedAttribute):
2443         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
2444         (WebCore::HTMLTableElement::getSharedCellDecl):
2445         (WebCore::HTMLTablePartElement::mapToEntry):
2446         (WebCore::HTMLTablePartElement::parseMappedAttribute):
2447         (WebCore::HTMLTableSectionElement::insertRow):
2448         (WebCore::HTMLTableRowElement::insertCell):
2449         * khtml/ecma/kjs_dom.cpp:
2450         (KJS::DOMNode::~DOMNode):
2451         (KJS::DOMNode::mark):
2452         (KJS::DOMElement::getValueProperty):
2453         (KJS::DOMElementProtoFunc::callAsFunction):
2454         (KJS::checkNodeSecurity):
2455         (KJS::toJS):
2456         * khtml/ecma/kjs_html.cpp:
2457         (KJS::JSHTMLElement::implementsCall):
2458         (KJS::JSHTMLElement::bodyGetter):
2459         (KJS::JSHTMLElement::anchorGetter):
2460         (KJS::JSHTMLElement::getValueProperty):
2461         (KJS::JSHTMLElement::bodySetter):
2462         * khtml/ecma/kjs_traversal.cpp:
2463         (KJS::JSNodeFilterCondition::acceptNode):
2464         * khtml/ecma/kjs_views.cpp:
2465         (KJS::DOMAbstractViewProtoFunc::callAsFunction):
2466         * khtml/xbl/xbl_binding.cpp:
2467         (XBL::XBLBindingChain::failed):
2468         (XBL::m_nextBinding):
2469         (XBL::XBLBinding::setXBLDocument):
2470         * khtml/xbl/xbl_protobinding.cpp:
2471         (XBL::XBLPrototypeBinding::document):
2472         * khtml/xsl/XSLStyleSheet.cpp:
2473         (WebCore::XSLStyleSheet::XSLStyleSheet):
2474         * khtml/xsl/XSLTProcessor.cpp:
2475         (WebCore::XSLTProcessor::createDocumentFromSource):
2476         (WebCore::xmlDocPtrFromNode):
2477         (WebCore::XSLTProcessor::transformToString):
2478         * ksvg2/svg/SVGAElement.cpp:
2479         (SVGAElement::defaultEventHandler):
2480         * ksvg2/svg/SVGAnimateColorElement.cpp:
2481         (SVGAnimateColorElement::handleTimerEvent):
2482         * ksvg2/svg/SVGAnimateElement.cpp:
2483         (SVGAnimateElement::handleTimerEvent):
2484         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2485         (SVGAnimateTransformElement::handleTimerEvent):
2486         * ksvg2/svg/SVGAnimationElement.cpp:
2487         (SVGAnimationElement::closeRenderer):
2488         * ksvg2/svg/SVGClipPathElement.cpp:
2489         (SVGClipPathElement::canvasResource):
2490         * ksvg2/svg/SVGElement.cpp:
2491         (WebCore::SVGElement::addSVGEventListener):
2492         * ksvg2/svg/SVGGradientElement.cpp:
2493         (SVGGradientElement::rebuildStops):
2494         * ksvg2/svg/SVGHelper.cpp:
2495         (SVGHelper::PercentageOfViewport):
2496         * ksvg2/svg/SVGLinearGradientElement.cpp:
2497         (SVGLinearGradientElement::buildGradient):
2498         * ksvg2/svg/SVGPatternElement.cpp:
2499         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
2500         * ksvg2/svg/SVGRadialGradientElement.cpp:
2501         (WebCore::SVGRadialGradientElement::buildGradient):
2502         * ksvg2/svg/SVGSVGElement.cpp:
2503         (WebCore::SVGSVGElement::setCurrentScale):
2504         (WebCore::SVGSVGElement::addSVGWindowEventListner):
2505         * ksvg2/svg/SVGSetElement.cpp:
2506         (SVGSetElement::handleTimerEvent):
2507         * ksvg2/svg/SVGStyleElement.cpp:
2508         (SVGStyleElement::childrenChanged):
2509         * ksvg2/svg/SVGStyledElement.cpp:
2510         (WebCore::SVGStyledElement::canvas):
2511         * ksvg2/svg/SVGTitleElement.cpp:
2512         (WebCore::SVGTitleElement::closeRenderer):
2513         (WebCore::SVGTitleElement::insertedIntoDocument):
2514         (WebCore::SVGTitleElement::removedFromDocument):
2515         (WebCore::SVGTitleElement::childrenChanged):
2516         * ksvg2/svg/SVGUseElement.cpp:
2517         (SVGUseElement::closeRenderer):
2518         * kwq/WebCoreAXObject.mm:
2519         (-[WebCoreAXObject accessibilityPerformAction:]):
2520         (-[WebCoreAXObject accessibilityAttributeValue:]):
2521         * page/Frame.cpp:
2522         (WebCore::parentFromOwnerRenderer):
2523         (WebCore::Frame::frameForNode):
2524         (WebCore::Frame::clearDocumentFocus):
2525         * page/FrameView.cpp:
2526         (WebCore::FrameView::dispatchMouseEvent):
2527         * rendering/RenderBox.cpp:
2528         (WebCore::RenderBox::setStyle):
2529         * rendering/RenderCanvas.cpp:
2530         (WebCore::RenderCanvas::RenderCanvas):
2531         (WebCore::RenderCanvas::paintBoxDecorations):
2532         (WebCore::RenderCanvas::repaintViewRectangle):
2533         * rendering/RenderImage.cpp:
2534         (WebCore::RenderImage::imageMap):
2535         * rendering/RenderLayer.cpp:
2536         (WebCore::RenderLayer::setHasHorizontalScrollbar):
2537         (WebCore::RenderLayer::setHasVerticalScrollbar):
2538         * rendering/RenderObject.cpp:
2539         (WebCore::RenderObject::createObject):
2540         (WebCore::RenderObject::RenderObject):
2541         (WebCore::RenderObject::isRoot):
2542         (WebCore::RenderObject::backslashAsCurrencySymbol):
2543         * rendering/RenderObject.h:
2544         (WebCore::RenderObject::document):
2545         * rendering/RenderTheme.cpp:
2546         (WebCore::RenderTheme::isFocused):
2547         * rendering/render_applet.cpp:
2548         (WebCore::RenderApplet::createWidgetIfNecessary):
2549         * rendering/render_replaced.cpp:
2550         (WebCore::RenderWidget::RenderWidget):
2551         (WebCore::RenderWidget::focusIn):
2552         (WebCore::RenderWidget::focusOut):
2553
2554 2006-03-28  Darin Adler  <darin@apple.com>
2555
2556         Reviewed by Geoff.
2557
2558         - added a build step that checks for init routines
2559
2560         * WebCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that
2561         was replaced by the generate-derived-sources script a while back. Added a custom
2562         build phase that invokes the check-for-global-initializers script.
2563
2564 2006-03-28  Timothy Hatcher  <timothy@apple.com>
2565
2566         Reviewed by Maciej.
2567
2568         Moved the derived sources script to an agregate target. Fixes internal builds.
2569
2570         * WebCore.xcodeproj/project.pbxproj:
2571         * generate-derived-sources: was missing a use of $CREATE_HASH_TABLE
2572
2573 2006-03-28  Eric Seidel  <eseidel@apple.com>
2574
2575         Reviewed by hyatt.
2576         
2577         Build fix.
2578
2579         * dom/xml_tokenizer.cpp:
2580         (WebCore::XMLTokenizer::error):
2581
2582 2006-03-28  Michael Emmel  <mike.emmel@gmail.com>
2583
2584         Reviewed, tweaked, landed by Darin.
2585
2586         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8023
2587           Attribute.h missing class predeclaration
2588
2589         * dom/Attribute.h: Add declarations for classes so that the friend
2590         declaration is not the only one. There's an issue with either an earlier
2591         or later version of gcc, which is why we see this only on certain platforms.
2592
2593         * dom/Attr.cpp:
2594         (WebCore::Attr::Attr):
2595         (WebCore::Attr::~Attr):
2596         * dom/NamedAttrMap.cpp:
2597         (WebCore::NamedAttrMap::clearAttributes):
2598         (WebCore::NamedAttrMap::addAttribute):
2599         (WebCore::NamedAttrMap::removeAttribute):
2600         Change places where practical to use attr() instead of m_impl in the vain
2601         hope of removing the need for the friend declarations.
2602
2603 2006-03-27  Eric Seidel  <eseidel@apple.com>
2604
2605         Reviewed by darin.
2606
2607         Replace more DeprecatedString with String.
2608         Add String::sprintf() and String::number()
2609         http://bugzilla.opendarwin.org/show_bug.cgi?id=8009
2610
2611         * bindings/objc/DOMHTML.mm:
2612         (-[DOMHTMLTextAreaElement setCols:]):
2613         (-[DOMHTMLTextAreaElement setRows:]):
2614         (-[DOMHTMLOListElement setStart:]):
2615         (-[DOMHTMLPreElement setWidth:]):
2616         (-[DOMHTMLImageElement setHeight:]):
2617         (-[DOMHTMLImageElement setHspace:]):
2618         (-[DOMHTMLImageElement setVspace:]):
2619         (-[DOMHTMLImageElement setWidth:]):
2620         (-[DOMHTMLObjectElement setHspace:]):
2621         (-[DOMHTMLObjectElement setTabIndex:]):
2622         (-[DOMHTMLObjectElement setVspace:]):
2623         (-[DOMHTMLAppletElement setHspace:]):
2624         (-[DOMHTMLAppletElement setVspace:]):
2625         (-[DOMHTMLAreaElement setTabIndex:]):
2626         (-[DOMHTMLTableColElement setSpan:]):
2627         (-[DOMHTMLTableCellElement setColSpan:]):
2628         (-[DOMHTMLTableCellElement setRowSpan:]):
2629         (-[DOMHTMLEmbedElement setHeight:]):
2630         (-[DOMHTMLEmbedElement setWidth:]):
2631         * bindings/objc/DOMInternal.mm:
2632         (String::String):
2633         * css/CSSComputedStyleDeclaration.cpp:
2634         (WebCore::numberAsString):
2635         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2636         * css/css_valueimpl.cpp:
2637         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2638         (WebCore::CSSPrimitiveValue::cssText):
2639         * dom/Position.cpp:
2640         (WebCore::Position::formatForDebugger):
2641         * dom/Range.cpp:
2642         (WebCore::Range::formatForDebugger):
2643         * dom/StyledElement.cpp:
2644         (WebCore::StyledElement::addCSSColor):
2645         * dom/xml_tokenizer.cpp:
2646         (WebCore::XMLTokenizer::error):
2647         * editing/ApplyStyleCommand.cpp:
2648         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2649         * html/HTMLGenericFormElement.cpp:
2650         (WebCore::HTMLGenericFormElement::findMatchingState):
2651         (WebCore::HTMLGenericFormElement::setTabIndex):
2652         * html/HTMLInputElement.cpp:
2653         (WebCore::HTMLInputElement::setMaxLength):
2654         (WebCore::HTMLInputElement::setSize):
2655         * html/HTMLSelectElement.cpp:
2656         (WebCore::HTMLSelectElement::setSize):
2657         * html/HTMLTextAreaElement.cpp:
2658         (WebCore::HTMLTextAreaElement::setCols):
2659         (WebCore::HTMLTextAreaElement::setRows):
2660         * html/html_baseimpl.cpp:
2661         (WebCore::HTMLBodyElement::insertedIntoDocument):
2662         * html/html_blockimpl.cpp:
2663         (WebCore::HTMLHRElement::parseMappedAttribute):
2664         (WebCore::HTMLPreElement::setWidth):
2665         * html/html_imageimpl.cpp:
2666         (WebCore::HTMLImageElement::width):
2667         (WebCore::HTMLImageElement::height):
2668         (WebCore::HTMLImageElement::setBorder):
2669         (WebCore::HTMLImageElement::setHeight):
2670         (WebCore::HTMLImageElement::setHspace):
2671         (WebCore::HTMLImageElement::setVspace):
2672         (WebCore::HTMLImageElement::setWidth):
2673         (WebCore::HTMLAreaElement::setTabIndex):
2674         * html/html_inlineimpl.cpp:
2675         (WebCore::HTMLAnchorElement::setTabIndex):
2676         * html/html_listimpl.cpp:
2677         (WebCore::HTMLOListElement::setStart):
2678         (WebCore::HTMLLIElement::setValue):
2679         * html/html_objectimpl.cpp:
2680         (WebCore::HTMLObjectElement::setTabIndex):
2681         * html/html_tableimpl.cpp:
2682         (WebCore::HTMLTableElement::parseMappedAttribute):
2683         (WebCore::HTMLTableCellElement::setColSpan):
2684         (WebCore::HTMLTableCellElement::setRowSpan):
2685         (WebCore::HTMLTableColElement::setSpan):
2686         * khtml/ecma/kjs_window.cpp:
2687         (KJS::Window::isSafeScript):
2688         (KJS::Location::getValueProperty):
2689         * ksvg2/css/SVGCSSParser.cpp:
2690         (WebCore::CSSParser::parseSVGPaint):
2691         (WebCore::CSSParser::parseSVGColor):
2692         * ksvg2/svg/SVGAngle.cpp:
2693         (SVGAngle::setValueAsString):
2694         (SVGAngle::valueAsString):
2695         * ksvg2/svg/SVGAngle.h:
2696         * ksvg2/svg/SVGLength.cpp:
2697         (SVGLength::setValueAsString):
2698         (SVGLength::valueAsString):
2699         * ksvg2/svg/SVGLength.h:
2700         * ksvg2/svg/SVGPathSeg.h:
2701         (WebCore::SVGPathSeg::pathSegTypeAsLetter):
2702         (WebCore::SVGPathSeg::toString):
2703         * ksvg2/svg/SVGPathSegArc.h:
2704         (WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
2705         (WebCore::SVGPathSegArcAbs::toString):
2706         (WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
2707         (WebCore::SVGPathSegArcRel::toString):
2708         * ksvg2/svg/SVGPathSegClosePath.h:
2709         (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter):
2710         (WebCore::SVGPathSegClosePath::toString):
2711         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
2712         (WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
2713         (WebCore::SVGPathSegCurvetoCubicAbs::toString):
2714         (WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
2715         (WebCore::SVGPathSegCurvetoCubicRel::toString):
2716         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
2717         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
2718         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
2719         (WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
2720         (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
2721         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
2722         (WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
2723         (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
2724         (WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
2725         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
2726         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
2727         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
2728         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
2729         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
2730         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
2731         * ksvg2/svg/SVGPathSegLineto.h:
2732         (WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
2733         (WebCore::SVGPathSegLinetoAbs::toString):
2734         (WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
2735         (WebCore::SVGPathSegLinetoRel::toString):
2736         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
2737         (WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
2738         (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
2739         (WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
2740         (WebCore::SVGPathSegLinetoHorizontalRel::toString):
2741         * ksvg2/svg/SVGPathSegLinetoVertical.h:
2742         (WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
2743         (WebCore::SVGPathSegLinetoVerticalAbs::toString):
2744         (WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
2745         (WebCore::SVGPathSegLinetoVerticalRel::toString):
2746         * ksvg2/svg/SVGPathSegMoveto.h:
2747         (WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
2748         (WebCore::SVGPathSegMovetoAbs::toString):
2749         (WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
2750         (WebCore::SVGPathSegMovetoRel::toString):
2751         * ksvg2/svg/SVGPolyElement.cpp:
2752         (SVGPolyElement::notifyAttributeChange):
2753         * ksvg2/svg/SVGStopElement.cpp:
2754         (SVGStopElement::parseMappedAttribute):
2755         * ksvg2/svg/SVGUseElement.cpp:
2756         (SVGUseElement::closeRenderer):
2757         * platform/AtomicString.h:
2758         (WebCore::AtomicString::toInt):
2759         * platform/Color.cpp:
2760         (WebCore::Color::name):
2761         * platform/Color.h:
2762         * platform/PlatformString.h:
2763         * platform/String.cpp:
2764         (WebCore::String::sprintf):
2765         (WebCore::String::number):
2766         * platform/StringImpl.cpp:
2767         (WebCore::StringImpl::StringImpl):
2768         (WebCore::StringImpl::initWithChar):
2769         (WebCore::StringImpl::initWithQChar):
2770         (WebCore::StringImpl::containsOnlyWhitespace):
2771         * platform/mac/KeyEventMac.mm:
2772         (WebCore::keyIdentifierForKeyEvent):
2773         * rendering/render_form.cpp:
2774         (WebCore::RenderSlider::updateFromElement):
2775         (WebCore::RenderSlider::valueChanged):
2776
2777 2006-03-28  Justin Garcia  <justin.garcia@apple.com>
2778
2779         Reviewed by mjs
2780         
2781         <http://bugzilla.opendarwin.org/attachment.cgi?id=7322>
2782         REGRESSION: Select All does not highlight table if it's last in the document
2783         
2784         * rendering/RenderCanvas.cpp:
2785         (WebCore::rendererAfterPosition): 
2786         Added, returns the render object that a pre-order traversal over a range 
2787         of render objects ending at the input position should stop at.
2788         (WebCore::RenderCanvas::selectionRect): 
2789         Stop at rendererAfterPosition(m_selectionEnd, m_selectionEndPos), moved code 
2790         for traversal to nextInPreOrder. Also, the travesal doesn't need to fetch the
2791         next object before doing work, since the work it does will never change what 
2792         the next object in the traversal will be.
2793         (WebCore::RenderCanvas::setSelection): Ditto.
2794         * rendering/RenderObject.cpp:
2795         (WebCore::RenderObject::nextInPreOrder): Renamed from nextRenderer, cleaned up the logic a little.
2796         (WebCore::RenderObject::nextInPreOrderAfterChildren): Added.
2797         (WebCore::RenderObject::previousInPreOrder): Renamed from previousRenderer.
2798         (WebCore::RenderObject::childAt): Added.
2799         * rendering/RenderObject.h:
2800         * rendering/RenderText.cpp:
2801         (WebCore::RenderText::setText):
2802
2803 2006-03-28  Maciej Stachowiak  <mjs@apple.com>
2804
2805         Reviewed by Justin.
2806         
2807         - fixed <rdar://problem/4483851> REGRESSION: parse mode gets set to strict after going back from non-HTML content (7102)
2808
2809         Reshuffled things to arrange for m_doc to be cleared somewhat earlier than before.
2810         
2811         * page/Frame.cpp:
2812         (WebCore::Frame::didOpenURL):
2813         (WebCore::Frame::receivedFirstData):
2814         (WebCore::Frame::begin):
2815         (WebCore::Frame::endIfNotLoading): 
2816         * manual-tests/accidental-strict-mode.html: Added. I don't think an
2817         automated test is possible.
2818
2819 2006-03-28  Eric Seidel  <eseidel@apple.com>
2820
2821         Reviewed by mjs.
2822
2823         Convert a couple DeprecatedPtrList<T> to Vector<T*> and HashSet<T*>
2824
2825         * bridge/mac/FrameMac.h:
2826         * bridge/mac/FrameMac.mm:
2827         (WebCore::regExpForLabels):
2828         (WebCore::FrameMac::addPluginRootObject):
2829         (WebCore::FrameMac::cleanupPluginRootObjects):
2830         * loader/Cache.cpp:
2831         (WebCore::Cache::init):
2832         (WebCore::Cache::clear):
2833         (WebCore::Cache::remove):
2834         * loader/Cache.h:
2835         * loader/DocLoader.cpp:
2836         (WebCore::DocLoader::DocLoader):
2837         (WebCore::DocLoader::~DocLoader):
2838
2839 2006-03-27  Eric Seidel  <eseidel@apple.com>
2840
2841         Reviewed by mjs.
2842
2843         Give StringImpl a little privacy.
2844         http://bugzilla.opendarwin.org/show_bug.cgi?id=8022
2845
2846         * dom/CharacterData.cpp:
2847         (WebCore::CharacterData::length):
2848         (WebCore::CharacterData::appendData):
2849         (WebCore::CharacterData::replaceData):
2850         (WebCore::CharacterData::checkCharDataOperation):
2851         (WebCore::CharacterData::rendererIsNeeded):
2852         * dom/Range.cpp:
2853         (WebCore::Range::compareBoundaryPoints):
2854         * dom/Text.cpp:
2855         (WebCore::Text::splitText):
2856         * html/HTMLTokenizer.cpp:
2857         (WebCore::HTMLTokenizer::processToken):
2858         * platform/AtomicString.cpp:
2859         (WebCore::operator==):
2860         * platform/String.cpp:
2861         (WebCore::String::operator[]):
2862         (WebCore::String::length):
2863         (WebCore::String::percentage):
2864         (WebCore::String::unicode):
2865         (WebCore::String::deprecatedString):
2866         (WebCore::String::isEmpty):
2867         * platform/StringImpl.cpp:
2868         (WebCore::equal):
2869         (WebCore::equalIgnoringCase):
2870         * platform/StringImpl.h:
2871         * rendering/InlineTextBox.cpp:
2872         (WebCore::InlineTextBox::selectionRect):
2873         (WebCore::InlineTextBox::paint):
2874         (WebCore::InlineTextBox::paintSelection):
2875         (WebCore::InlineTextBox::paintMarkedTextBackground):
2876         (WebCore::InlineTextBox::paintTextMatchMarker):
2877         (WebCore::InlineTextBox::offsetForPosition):
2878         (WebCore::InlineTextBox::positionForOffset):
2879         * rendering/RenderText.cpp:
2880         (WebCore::RenderText::widthFromCache):
2881         (WebCore::RenderText::calcMinMaxWidth):
2882         (WebCore::RenderText::width):
2883
2884 2006-03-27  Maciej Stachowiak  <mjs@apple.com>
2885
2886         Reviewed by Beth.
2887
2888         - fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)
2889
2890         * rendering/RenderBlock.cpp:
2891         (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects
2892         as well as their overflowRects.
2893         * platform/IntRect.h:
2894         (WebCore::unionRect): useful helper
2895         * platform/FloatRect.h:
2896         (WebCore::unionRect): added same for FloatRect just because
2897
2898 2006-03-27  Darin Adler  <darin@apple.com>
2899
2900         Based on a patch by Michael Emmel <mike.emmel@gmail.com>.
2901
2902         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8012
2903           TransferJob.cpp includes non-existent "String.h" (capital S)
2904
2905         * platform/TransferJob.cpp: Remove unneeded include of "String.h".
2906
2907 2006-03-27  David Harrison  <harrison@apple.com>
2908
2909         Reviewed by Darin.
2910
2911         <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)
2912
2913         Better fix than previous checkin, since maxDeepOffset is really an editing hack.
2914
2915         * editing/selection/selectNodeContents-textNode.html: Added.
2916
2917         * dom/Range.cpp:
2918         (WebCore::Range::selectNodeContents):
2919         Use maxOffset if offsetInCharacters, otherwise use childNodeCount.
2920
2921 2006-03-27  Darin Adler  <darin@apple.com>
2922
2923         Based on a patch by Michael Emmel <mike.emmel@gmail.com>.
2924
2925         - fix compilation for Linux
2926           http://bugzilla.opendarwin.org/show_bug.cgi?id=8013
2927
2928         * rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked
2929         formatting a bit and removed some extraneous WebCore:: prefixes.
2930
2931 2006-03-27  John Sullivan  <sullivan@apple.com>
2932
2933         Reviewed by Darin Adler and Tim Omernick
2934         
2935         - fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly 
2936         confirmed while typing on Safari.
2937
2938         * bindings/objc/DOMHTML.mm:
2939         (-[DOMHTMLInputElement _displayedValue]):
2940         Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but
2941         for now it fixes this regression.
2942
2943 2006-03-27  Alexander Kellett  <lypanov@kde.org>
2944
2945         Reviewed by darin
2946
2947         Implement the IE extension insertAdjacentElement
2948         http://bugzilla.opendarwin.org/show_bug.cgi?id=6520
2949
2950         * bindings/scripts/CodeGeneratorJS.pm:
2951         * dom/Element.cpp:
2952         (WebCore::ElementImpl::insertAdjacentElement):
2953         * dom/Element.h:
2954         * dom/Element.idl:
2955
2956 2006-03-27  David Harrison  <harrison@apple.com>
2957
2958         Reviewed by Tim Hatcher.
2959
2960         <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)
2961
2962         Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
2963         nodes.  Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
2964         selectNodeContents on a text node.
2965
2966         Test cases added: None.  Manual AX testing is way too awkward, and automated testing
2967         is not possible.  See following bug...
2968             <rdar://problem/4256882> Need automated testing support for accessibility APIs
2969
2970         * dom/Range.cpp:
2971         (WebCore::Range::selectNodeContents):
2972         Use maxDeepOffset instead of childNodeCount, so that text node content is selected.
2973
2974 2006-03-27  Graham Dennis  <Graham.Dennis@gmail.com>
2975
2976         Reviewed by darin
2977         
2978         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
2979         REGRESSION: Extraneous focus ring drawn at the end of the page
2980         
2981         * platform/GraphicsContext.cpp:
2982         (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.
2983
2984 2006-03-27  Maciej Stachowiak  <mjs@apple.com>
2985
2986         Reviewed by Anders.
2987         
2988         - fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/
2989
2990         * manual-tests/empty-script-crash.html: Added.
2991
2992 2006-03-27  Maciej Stachowiak  <mjs@apple.com>
2993
2994         Build fix:
2995         
2996         - reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node
2997         It turns out that the behavior we had was standards-compliant and
2998         Moz will be changing to match.
2999         
3000         Also added a note so this doesn't get reverted again.
3001
3002         * dom/EventTargetNode.cpp:
3003         (WebCore::EventTargetNode::dispatchGenericEvent):
3004
3005 2006-03-26  Justin Garcia  <justin.garcia@apple.com>
3006
3007         Reviewed by darn
3008         
3009         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
3010         Add EditActions and WebUndoActions for CreateLink and Unlink
3011
3012         * bridge/mac/WebCoreFrameBridge.h:
3013         * editing/CreateLinkCommand.h:
3014         (WebCore::CreateLinkCommand::editingAction):
3015         * editing/EditAction.h:
3016         * editing/UnlinkCommand.h:
3017         (WebCore::UnlinkCommand::editingAction):
3018
3019 2006-03-26  Eric Seidel  <eseidel@apple.com>
3020
3021         Reviewed by mjs.
3022
3023         Fix win32 build.
3024
3025         * WebCore.vcproj/WebCore/WebCore.vcproj:
3026         * editing/CompositeEditCommand.cpp:
3027         * editing/InsertTextCommand.cpp:
3028         * generate-derived-sources:
3029
3030 2006-03-26  Eric Seidel  <eseidel@apple.com>
3031
3032         * dom/Element.cpp: fix include case, fixing build.
3033
3034 2006-03-25  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3035
3036         Reviewed by darin.  Landed by eseidel.
3037
3038         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7916
3039           Box repaint rect does not include the left overflow
3040
3041         * manual-tests/left-overflow-repaint.html: Added.
3042         * rendering/RenderBlock.cpp:
3043         (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight
3044         to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
3045         * rendering/RenderBox.cpp:
3046         (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
3047         * rendering/RenderFlow.cpp:
3048         (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
3049         * rendering/RenderTableCell.cpp: Removed subclass implementation of
3050         getAbsoluteRepaintRect().
3051         * rendering/RenderTableCell.h:
3052         * rendering/bidi.cpp:
3053         (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.
3054
3055 2006-03-25  Eric Seidel  <eseidel@apple.com>
3056
3057         Reviewed by andersca.
3058
3059         Build fix.
3060
3061         * bindings/scripts/CodeGeneratorJS.pm: include Element.h
3062
3063 2006-03-25  Eric Seidel  <eseidel@apple.com>
3064
3065         Reviewed by andersca.
3066
3067         Split dom_elementimpl.* into multiple files (one per class).
3068         http://bugzilla.opendarwin.org/show_bug.cgi?id=7978
3069
3070         * ForwardingHeaders/kdom/core/Attr.h: Removed.
3071         * ForwardingHeaders/kdom/core/Element.h: Removed.
3072         * ForwardingHeaders/kdom/core/XMLElement.h: Removed.
3073         * WebCore.xcodeproj/project.pbxproj:
3074         * bindings/objc/DOM.mm:
3075         * bindings/objc/DOMHTML.mm:
3076         * bindings/scripts/CodeGeneratorJS.pm:
3077         * dom/AbstractView.cpp:
3078         * dom/Attr.cpp: Added.
3079         * dom/Attr.h: Added.
3080         * dom/Attribute.cpp: Added.
3081         * dom/Attribute.h: Added.
3082         * dom/CSSMappedAttributeDeclaration.cpp: Added.
3083         * dom/CSSMappedAttributeDeclaration.h: Added.
3084         * dom/DOMImplementation.cpp:
3085         * dom/Document.h:
3086         * dom/DocumentType.cpp:
3087         * dom/Element.cpp: Added.
3088         (WebCore::Element::Element):
3089         (WebCore::Element::~Element):
3090         * dom/Element.h: Added.
3091         * dom/EventNames.cpp:
3092         * dom/EventTargetNode.cpp:
3093         * dom/MappedAttribute.cpp: Added.
3094         * dom/MappedAttribute.h: Added.
3095         * dom/MappedAttributeEntry.h: Added.
3096         (WebCore::):
3097         * dom/NameNodeList.cpp:
3098         (WebCore::NameNodeList::NameNodeList):
3099         (WebCore::NameNodeList::item):
3100         (WebCore::NameNodeList::nodeMatches):
3101         * dom/NamedAttrMap.cpp: Added.
3102         * dom/NamedAttrMap.h: Added.
3103         * dom/NamedMappedAttrMap.cpp: Added.
3104         (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
3105         * dom/NamedMappedAttrMap.h: Added.
3106         * dom/Node.cpp:
3107         * dom/NodeList.cpp:
3108         * dom/Position.cpp:
3109         * dom/StyledElement.cpp: Added.
3110         * dom/StyledElement.h: Added.
3111         * dom/dom_elementimpl.cpp: Removed.
3112         * dom/dom_elementimpl.h: Removed.
3113         * editing/BreakBlockquoteCommand.cpp:
3114         * editing/CompositeEditCommand.cpp:
3115         * editing/DeleteFromTextNodeCommand.cpp:
3116         * editing/DeleteSelectionCommand.cpp:
3117         * editing/InsertLineBreakCommand.cpp:
3118         * editing/InsertParagraphSeparatorCommand.cpp:
3119         * editing/InsertTextCommand.cpp:
3120         * editing/MergeIdenticalElementsCommand.cpp:
3121         * editing/ModifySelectionListLevelCommand.cpp:
3122         * editing/MoveSelectionCommand.cpp:
3123         * editing/RemoveCSSPropertyCommand.cpp:
3124         * editing/RemoveNodeAttributeCommand.cpp:
3125         * editing/Selection.cpp:
3126         * editing/SelectionController.cpp:
3127         * editing/SetNodeAttributeCommand.cpp:
3128         * editing/SplitElementCommand.cpp:
3129         * editing/SplitTextNodeContainingElementCommand.cpp:
3130         * editing/TextIterator.cpp:
3131         * editing/TypingCommand.cpp:
3132         * editing/VisiblePosition.cpp:
3133         * editing/visible_units.cpp:
3134         * html/HTMLElement.h:
3135         * html/HTMLTokenizer.h:
3136         * html/html_baseimpl.cpp:
3137         * kcanvas/RenderSVGImage.cpp:
3138         * khtml/ecma/kjs_views.cpp:
3139         * khtml/ecma/kjs_window.cpp:
3140         (KJS::Window::getValueProperty):
3141         * khtml/xbl/xbl_binding_manager.cpp:
3142         * khtml/xbl/xbl_tokenizer.cpp:
3143         * ksvg2/misc/SVGImageLoader.cpp:
3144         * ksvg2/svg/SVGAElement.cpp:
3145         * ksvg2/svg/SVGAnimateTransformElement.cpp:
3146         * ksvg2/svg/SVGAnimationElement.cpp:
3147         * ksvg2/svg/SVGCircleElement.cpp:
3148         * ksvg2/svg/SVGClipPathElement.cpp:
3149         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
3150         * ksvg2/svg/SVGCursorElement.cpp:
3151         * ksvg2/svg/SVGElement.cpp:
3152         (WebCore::SVGElement::SVGElement):
3153         * ksvg2/svg/SVGElement.h:
3154         * ksvg2/svg/SVGEllipseElement.cpp:
3155         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
3156         * ksvg2/svg/SVGFEBlendElement.cpp:
3157         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3158         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3159         * ksvg2/svg/SVGFECompositeElement.cpp:
3160         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3161         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
3162         * ksvg2/svg/SVGFEFloodElement.cpp:
3163         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3164         * ksvg2/svg/SVGFEImageElement.cpp:
3165         * ksvg2/svg/SVGFELightElement.cpp:
3166         * ksvg2/svg/SVGFEMergeElement.cpp:
3167         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
3168         * ksvg2/svg/SVGFEOffsetElement.cpp:
3169         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
3170         * ksvg2/svg/SVGFETileElement.cpp:
3171         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3172         * ksvg2/svg/SVGFilterElement.cpp:
3173         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
3174         * ksvg2/svg/SVGFitToViewBox.cpp:
3175         * ksvg2/svg/SVGGradientElement.cpp:
3176         * ksvg2/svg/SVGImageElement.cpp:
3177         * ksvg2/svg/SVGLangSpace.cpp:
3178         * ksvg2/svg/SVGLineElement.cpp:
3179         * ksvg2/svg/SVGLinearGradientElement.cpp:
3180         * ksvg2/svg/SVGMarkerElement.cpp:
3181         * ksvg2/svg/SVGMaskElement.cpp:
3182         * ksvg2/svg/SVGPathElement.cpp:
3183         * ksvg2/svg/SVGPatternElement.cpp:
3184         * ksvg2/svg/SVGPolyElement.cpp:
3185         * ksvg2/svg/SVGRadialGradientElement.cpp:
3186         * ksvg2/svg/SVGRectElement.cpp:
3187         * ksvg2/svg/SVGSVGElement.cpp:
3188         * ksvg2/svg/SVGScriptElement.cpp:
3189         * ksvg2/svg/SVGStopElement.cpp:
3190         * ksvg2/svg/SVGStyledElement.cpp:
3191         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3192         * ksvg2/svg/SVGSwitchElement.cpp:
3193         * ksvg2/svg/SVGTests.cpp:
3194         * ksvg2/svg/SVGTextContentElement.cpp:
3195         * ksvg2/svg/SVGTextPositioningElement.cpp:
3196         * ksvg2/svg/SVGTransformable.cpp:
3197         * ksvg2/svg/SVGURIReference.cpp:
3198         * ksvg2/svg/SVGUseElement.cpp:
3199         * ksvg2/svg/SVGViewElement.cpp:
3200         * ksvg2/svg/SVGZoomAndPan.cpp:
3201         * kwq/WebCoreTextArea.mm:
3202         * platform/Widget.h:
3203         * rendering/RenderBlock.cpp:
3204         * rendering/RenderCanvas.cpp:
3205         * rendering/RenderContainer.cpp:
3206         * rendering/RenderObject.cpp:
3207         * rendering/RenderTextField.cpp:
3208         * rendering/RenderThemeMac.mm:
3209         * rendering/bidi.cpp:
3210         * rendering/render_replaced.cpp:
3211
3212 2006-03-25  Eric Seidel  <eseidel@apple.com>
3213
3214         Reviewed by mjs.
3215
3216         Fix RenderStyle creation to avoid floating RenderStyle objects.
3217         This also fixes a bug, were SVG to ever start sharing RenderStyles
3218         between elements, code would have crashed as there were improperly
3219         paired style->deref() statements in SVG code.
3220         http://bugzilla.opendarwin.org/show_bug.cgi?id=7976
3221
3222         No test possible (no functionality change).
3223
3224         * css/cssstyleselector.cpp:
3225         (WebCore::CSSStyleSelector::createStyleForElement):
3226         (WebCore::CSSStyleSelector::createPseudoStyleForElement):
3227         * css/cssstyleselector.h:
3228         * dom/Node.cpp:
3229         (WebCore::Node::createRendererIfNeeded):
3230         (WebCore::Node::createStyleForRenderer):
3231         * dom/Node.h:
3232         * dom/dom_elementimpl.cpp:
3233         (WebCore::Element::createStyleForRenderer):
3234         (WebCore::Element::recalcStyle):
3235         * dom/dom_elementimpl.h:
3236         * ksvg2/svg/SVGClipPathElement.cpp:
3237         (SVGClipPathElement::canvasResource):
3238         * ksvg2/svg/SVGFEFloodElement.cpp:
3239         (SVGFEFloodElement::filterEffect):
3240         * ksvg2/svg/SVGGradientElement.cpp:
3241         (SVGGradientElement::rebuildStops):
3242         * rendering/RenderObject.cpp:
3243         (WebCore::RenderObject::createObject):
3244         (WebCore::RenderObject::RenderObject):
3245         (WebCore::selectStartNode):
3246         (WebCore::RenderObject::draggableNode):
3247         (WebCore::RenderObject::getPseudoStyle):
3248
3249 2006-03-23  Eric Seidel  <eseidel@apple.com>
3250
3251         Reviewed by mjs.
3252
3253         Shave .2% on PLT by removing bogus strcmp.
3254         http://bugzilla.opendarwin.org/show_bug.cgi?id=7938
3255
3256         Test: fast/parser/tag-with-exclamation-point.html
3257
3258         * html/HTMLTokenizer.cpp:
3259         (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp
3260
3261 2006-03-25  Justin Garcia  <justin.garcia@apple.com>
3262
3263         Reviewed by harrison
3264         
3265         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
3266         TinyMCE: execCommand("Unlink") unimplemented
3267         
3268         Added code to push partially selected anchor elements down before 
3269         creating or removing links to create fully selected chunks that can be removed.
3270         Changed __create_link_command_h__ to CreateLinkCommand_h
3271         Gave styled element application/removal its own ApplyStyleCommand constructor.
3272         Still need to add new EditActions (7974).
3273         
3274         * WebCore.xcodeproj/project.pbxproj:
3275         * editing/ApplyStyleCommand.cpp:
3276         (WebCore::ApplyStyleCommand::ApplyStyleCommand):
3277         (WebCore::ApplyStyleCommand::applyBlockStyle):
3278         (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
3279         * editing/ApplyStyleCommand.h:
3280         * editing/CompositeEditCommand.cpp:
3281         (WebCore::CompositeEditCommand::applyStyle):
3282         (WebCore::CompositeEditCommand::applyStyledElement):
3283         (WebCore::CompositeEditCommand::removeStyledElement):
3284         (WebCore::enclosingAnchorElement):
3285         (WebCore::CompositeEditCommand::pushAnchorElementDown):
3286         (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
3287         * editing/CompositeEditCommand.h:
3288         * editing/CreateLinkCommand.cpp:
3289         (WebCore::CreateLinkCommand::doApply):
3290         * editing/CreateLinkCommand.h:
3291         * editing/JSEditor.cpp:
3292         * editing/Selection.cpp:
3293         (WebCore::Selection::selectionFromContentsOfNode):
3294         * editing/Selection.h:
3295         * editing/UnlinkCommand.cpp: Added.
3296         (WebCore::UnlinkCommand::UnlinkCommand):
3297         (WebCore::UnlinkCommand::doApply):
3298         * editing/UnlinkCommand.h: Added.
3299         * page/Frame.cpp:
3300         (WebCore::Frame::selectContentsOfNode):
3301         (WebCore::Frame::computeAndSetTypingStyle):
3302         (WebCore::Frame::applyStyle):
3303         (WebCore::Frame::applyParagraphStyle):
3304
3305 2006-03-24  Justin Garcia  <justin.garcia@apple.com>
3306
3307         Reviewed by harrison
3308         
3309         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
3310         REGRESSION: Content with an interchange newline lost when pasted at the end of the document
3311         
3312         There's no safe place in the document to keep the fragment while pasting, so I avoid
3313         isProbablyBlock by saving whether or not something was blockFlow during the test 
3314         insertion.
3315
3316         * editing/ReplaceSelectionCommand.cpp:
3317         (WebCore::ReplacementFragment::ReplacementFragment):
3318         (WebCore::ReplacementFragment::~ReplacementFragment):
3319         (WebCore::ReplacementFragment::firstChild):
3320         (WebCore::ReplacementFragment::lastChild):
3321         (WebCore::ReplacementFragment::mergeStartNode):
3322         (WebCore::ReplacementFragment::enclosingBlock):
3323         (WebCore::ReplacementFragment::insertFragmentForTestRendering):
3324         (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment):
3325         (WebCore::ReplacementFragment::isBlockFlow):
3326         (WebCore::ReplaceSelectionCommand::fixupNodeStyles):
3327         (WebCore::styleForNode):
3328         (WebCore::ReplacementFragment::saveRenderingInfo):
3329         (WebCore::ReplacementFragment::removeUnrenderedNodes):
3330         (WebCore::ReplacementFragment::renderedBlocks):
3331         (WebCore::ReplacementFragment::removeStyleNodes):
3332         (WebCore::RenderingInfo::RenderingInfo):
3333         (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
3334         (WebCore::ReplaceSelectionCommand::doApply):
3335         * editing/ReplaceSelectionCommand.h:
3336         (WebCore::RenderingInfo::isBlockFlow):
3337         (WebCore::ReplacementFragment::renderingInfo):
3338         (WebCore::ReplacementFragment::nodes):
3339         
3340 2006-03-24  Eric Seidel  <eseidel@apple.com>
3341
3342         Reviewed by justing.
3343
3344         * generate-derived-sources: fix clean builds on mac.
3345         
3346 2006-03-24  Darin Adler  <darin@apple.com>
3347
3348         Reviewed by Dave Harrison.
3349
3350         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7942
3351           nightlies after r13387 break js createcontextualfragment
3352
3353         Test: fast/dom/Range/create-contextual-fragment.html
3354
3355         * dom/Range.idl: Add createContextualFragment.
3356
3357 2006-03-24  Eric Seidel  <eseidel@apple.com>
3358
3359         Reviewed by mjs.
3360
3361         Fix win32 build.
3362         Unify mac/win dependency handling.
3363         Fix class vs. struct linker problem for win32.
3364
3365         * WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
3366         * WebCore.vcproj/WebCore/build-generated-files.sh:
3367         * bridge/win/BrowserExtensionWin.h:
3368         * bridge/win/FrameWin.h:
3369         * generate-derived-sources:
3370         * kwq/AccessibilityObjectCache.h:
3371         * platform/GraphicsContext.cpp:
3372         (WebCore::GraphicsContext::createGraphicsContextPrivate):
3373         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
3374         * platform/GraphicsContext.h:
3375         * platform/cairo/GraphicsContextCairo.cpp:
3376         * platform/mac/GraphicsContextMac.mm:
3377         * platform/win/TemporaryLinkStubs.cpp:
3378         (QLineEdit::selectedText):
3379         (FrameWin::createPlugin):
3380         (BrowserExtensionWin::setTypedIconURL):
3381
3382 2006-03-23  Darin Adler  <darin@apple.com>
3383
3384         Reviewed by Adele.
3385
3386         - fix <rdar://problem/4484787> KWQAccObject dangles under GC
3387
3388         * kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore
3389         namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject
3390         to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change
3391         from CF dictionaries to HashMap and HashSet.
3392         * kwq/AccessibilityObjectCache.mm:
3393         (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects
3394         and call CFRelease on all of them.
3395         (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting
3396         them in the HashMap, rather than assuming that retain == CFRetain. This is what
3397         fixes the GC issue.
3398         (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing.
3399         (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable
3400         for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before.
3401         (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet.
3402         (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes.
3403         (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto.
3404         (WebCore::AccessibilityObjectCache::childrenChanged): Ditto.
3405         (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto.
3406         (WebCore::AccessibilityObjectCache::postNotification): Ditto.
3407
3408         * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]):
3409         Change to use functions by new names.
3410
3411         * dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace.
3412         getAccObjectCache and ownerElement are const member functions, and m_accCache
3413         is a mutable data member.
3414         * dom/Document.cpp:
3415         (WebCore::Document::getAccObjectCache): Make const.
3416         (WebCore::Document::ownerElement): Make const.
3417
3418         * kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
3419         * kwq/WebCoreAXObject.mm:
3420         (-[WebCoreAXObject anchorElement]): Update for function name change.
3421         (-[WebCoreAXObject firstChild]): Ditto.
3422         (-[WebCoreAXObject lastChild]): Ditto.
3423         (-[WebCoreAXObject previousSibling]): Ditto.
3424         (-[WebCoreAXObject nextSibling]): Ditto.
3425         (-[WebCoreAXObject parentObject]): Ditto.
3426         (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto.
3427         (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto.
3428         (AXLinkElementForNode): Ditto.
3429         (AXAttributedStringAppendReplaced): Ditto.
3430         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3431         (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto.
3432         (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto.
3433         (-[WebCoreAXObject axObjectID]): Change field name to m_id.
3434         (-[WebCoreAXObject setAXObjectID:]): Ditto.
3435         (-[WebCoreAXObject removeAXObjectID]): Ditto.
3436
3437         * rendering/RenderContainer.cpp:
3438         (WebCore::RenderContainer::removeChildNode): Remove ifdefs.
3439         (WebCore::RenderContainer::appendChildNode): Ditto.
3440         (WebCore::RenderContainer::insertChildNode): Ditto.
3441         * rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.
3442
3443 2006-03-23  Darin Adler  <darin@apple.com>
3444
3445         Reviewed by Maciej.
3446
3447         - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
3448           REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)
3449
3450         Test: fast/js/function-names.html
3451
3452         * dom/Document.h: Add function name parameter to createHTMLEventListener.
3453         * dom/Document.cpp:
3454         (WebCore::Document::createHTMLEventListener): Pass function name when calling
3455         createHTMLEventHandler.
3456         (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name
3457         when calling createHTMLEventListener.
3458
3459         * html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute
3460         name as function name when calling createHTMLEventListener.
3461
3462         * khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
3463         * khtml/ecma/kjs_events.cpp:
3464         (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name.
3465         (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.
3466
3467         * khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and
3468         createSVGEventHandler.
3469         * khtml/ecma/kjs_proxy.cpp:
3470         (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating
3471         a JSLazyEventListener.
3472         (WebCore::KJSProxy::createSVGEventHandler): Ditto.
3473
3474         * ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to
3475         JSSVGLazyEventListener.
3476         * ksvg2/events/JSSVGLazyEventListener.cpp:
3477         (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name
3478         on to the base class constructor.
3479
3480         * ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
3481         * ksvg2/misc/SVGDocumentExtensions.cpp:
3482         (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when
3483         calling createSVGEventHandler.
3484
3485         * ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
3486         * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner):
3487         Pass attribute name as function name when calling createSVGEventListener.
3488
3489         * WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.
3490
3491 2006-03-23  Tim Omernick  <timo@apple.com>
3492
3493         Reviewed by Darin.
3494
3495         <http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
3496         REGRESSION: imdb.com search button looks wrong because "Submit" is drawn
3497
3498         * html/HTMLInputElement.cpp:
3499         (WebCore::HTMLInputElement::valueWithDefault):
3500         Only use the default button title if no title was specified; previously we'd use the default
3501         button title if the specified title was empty, which is not what Firefox does.
3502         
3503 2006-03-23  Darin Adler  <darin@apple.com>
3504
3505         Reviewed by Beth.
3506
3507         - fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
3508
3509         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
3510         For max-height of none, set it to Length(undefinedLength, Fixed), which
3511         is the correct value (same as the default). Also did some formatting fixes
3512         to the height section.
3513
3514 2006-03-23  Beth Dakin  <bdakin@apple.com>
3515
3516         Reviewed by Darin
3517
3518         Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431 
3519         REGRESSION: style change where :hover changes only an :after style 
3520         doesn't work
3521
3522         * dom/Node.cpp:
3523         (WebCore::Node::diff): Need to call diff() on the before and after 
3524         styles if we have them.
3525
3526 2006-03-23  Adele Peterson  <adele@apple.com>
3527
3528         Reviewed by Hyatt.
3529
3530         - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935
3531         <rdar://problem/4489010>
3532         Infinite recursion in table code when button or new text fields get display:table-row
3533
3534         Test:
3535         fast/forms/button-table-styles.html
3536
3537         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle):
3538         The theme should disallow table display styles form elements. 
3539
3540 2006-03-23  Darin Adler  <darin@apple.com>
3541
3542         * generate-derived-sources: Tweaked formatting a tiny bit and removed a stray
3543         touch that was left in here.