1872f14aa9a0f8bed2815f6cf4db396e9d953e89
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
2
3         Reviewed by Geoff, landed by Anders.
4         
5         Fix dependency problems caused when running move-js-headers.sh
6         
7         * move-js-headers.sh:
8         Use cp -p instead of just cp so that the modification time
9         of the original files are used.
10
11 2006-11-02  Adam Roben  <aroben@apple.com>
12
13         Reviewed by Tim H, landed by Anders.
14
15         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
16         REGRESSION: Shadow of file upload button is clipped
17
18         * rendering/RenderFileUploadControl.cpp:
19         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
20         height to keep from clipping in the shadow
21
22 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
23
24         Reviewed by Maciej, landed by Anders.
25
26         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
27         content and window. ScrollViewQt already receives correct content
28         coordinates from QScrollArea.
29         (WebCore::ScrollView::contentsToWindow):
30         (WebCore::ScrollView::windowToContents):
31
32 2006-11-02  Simon Hausmann  <hausmann@kde.org>
33
34         Reviewed by Maciej, landed by Anders
35
36         * CMakeLists.txt: Make linkage against KDE libraries conditional
37         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
38           Qt base resource handler that supports only requests to the
39           local filesystem. Used when compiling without KDE support.
40           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
41           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
42         (WebCore::QtJob::QtJob):
43         (WebCore::QtJob::timerEvent):
44         (WebCore::ResourceHandleManager::ResourceHandleManager):
45         (WebCore::ResourceHandleManager::~ResourceHandleManager):
46         (WebCore::ResourceHandleManager::self):
47         (WebCore::ResourceHandleManager::remove):
48         (WebCore::ResourceHandleManager::add):
49         (WebCore::ResourceHandleManager::cancel):
50         (WebCore::ResourceHandleManager::deliverJobData):
51         * platform/network/qt/ResourceHandleManager.h:
52         * platform/qt/FrameQtClient.cpp:
53         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
54         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
55         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
56         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
57           input dialog functions when compiling without KDE support
58         (WebCore::ServeSynchronousRequest):
59
60 2006-11-02  David Carson  <dacarson@gmail.com>
61
62         Reviewed by Geoff, landed by Anders.
63
64         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
65         Initializing variable in constructor.
66
67         * page/FramePrivate.h:
68         (WebCore::FramePrivate::FramePrivate):
69
70 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
71
72         Reviewed by Geoff.
73
74         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
75         
76         * platform/network/cf/ResourceHandleCFNet.cpp:
77         (WebCore::addHeadersFromHashMap):
78         Don't set all headers at once since that clears any previous headers set.
79         
80         (WebCore::ResourceHandle::start):
81
82 2006-11-02  Adele Peterson  <adele@apple.com>
83
84         Reviewed by Mitz and Geoff.
85
86         - Fix for:
87         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
88         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
89         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
90
91         Test: fast/forms/textarea-scrollbar.html
92
93         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
94         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
95
96         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
97         * rendering/RenderTextControl.cpp: 
98         (WebCore::RenderTextControl::RenderTextControl):
99         (WebCore::RenderTextControl::setStyle):
100         (WebCore::RenderTextControl::createDivStyle):
101         (WebCore::RenderTextControl::updateFromElement):
102         (WebCore::RenderTextControl::calcHeight):
103         (WebCore::RenderTextControl::baselinePosition):
104         (WebCore::RenderTextControl::nodeAtPoint):
105         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
106         (WebCore::RenderTextControl::scrollWidth):
107         (WebCore::RenderTextControl::scrollHeight):
108         (WebCore::RenderTextControl::scrollLeft):
109         (WebCore::RenderTextControl::scrollTop):
110
111         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
112
113 2006-11-02  John Sullivan  <sullivan@apple.com>
114
115         Reviewed by Geoff Garen
116
117         * editing/Selection.cpp:
118         (WebCore::Selection::showTreeForThis):
119         this debugging method now displays start offset and end offset, at Darin's suggestion
120
121 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
122
123         Reviewed by darin
124
125         <rdar://problem/4062865>
126         Copy/paste of a select element fails to include the options
127         
128         * editing/SelectionController.cpp:
129         (WebCore::SelectionController::modify): Added paragraphBoundary.
130         * editing/htmlediting.cpp:
131         (WebCore::canHaveChildrenForEditing): Added checks for input elements
132         and textareas.  Insertion operations would fail when performed just 
133         before/after one of these elements b/c the content would be put inside 
134         the element.
135         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
136         editable content, and made the code to stop at an root faster (don't check
137         isDescendantOf on every iteration).
138         (WebCore::enclosingNodeOfType): Ditto.
139         (WebCore::enclosingList): Ditto.
140         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
141         inappropriately named.
142         * editing/markup.cpp:
143         (WebCore::startMarkup): Use the text node's value instead of its rendered
144         content for text nodes inside select elements.  One might also turn off
145         annotation when createMarkup enters a select element, but createMarkup
146         is iterative, not recursive, so doing so would be complicated.
147         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
148         descendants of a select element.
149         * editing/visible_units.cpp:
150         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
151         where various replaced elements can't be copied when they are the only
152         thing selected.
153         (WebCore::endOfParagraph): Ditto.
154
155 2006-11-01  Oliver Hunt  <oliver@apple.com>
156
157         Reviewed by Adam.
158
159         Converting more or kcanvas/quartz from Obj-C to C++
160         Minor SVG updates
161         compatibility fixes
162
163         * WebCore.xcodeproj/project.pbxproj:
164         * kcanvas/device/KRenderingPaintServer.h:
165         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
166         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
167         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
168         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
169         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
170         * kcanvas/device/quartz/QuartzSupport.h:
171         * ksvg2/css/SVGCSSStyleSelector.cpp:
172         * ksvg2/misc/KCanvasRenderingStyle.h:
173         * ksvg2/scripts/cssmakeprops:
174         * ksvg2/scripts/cssmakevalues:
175         * ksvg2/scripts/make_names.pl:
176         * ksvg2/svg/SVGAnimateColorElement.cpp:
177         * ksvg2/svg/SVGAnimateTransformElement.cpp:
178         * ksvg2/svg/SVGAnimationElement.cpp:
179         * ksvg2/svg/SVGMaskElement.cpp:
180         * ksvg2/svg/SVGPatternElement.cpp:
181         * ksvg2/svg/svgpathparser.cpp:
182         * platform/Path.cpp:
183         * platform/graphics/svg/SVGResourceImage.h:
184         * rendering/RenderPath.cpp:
185         * rendering/SVGRenderAsText.cpp:
186
187 2006-11-02  Mitz Pettel  <mitz@webkit.org>
188
189         Reviewed by Adele.
190
191         - Fix a regression from r17521: painting of and crash caused by tables
192           with collapsed borders
193
194         * rendering/RenderTable.cpp:
195         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
196         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
197         and 'paintInfo' is the parameter, which we were accidently modifying.
198
199 2006-11-01  Adele Peterson  <adele@apple.com>
200
201         Reviewed by Mitz.
202
203         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
204         REGRESSION: Incomplete repaint of overflow areas when deleting
205
206         Restrict the repaint rect for overflow blocks after the height has been fully computed.
207         Also, adjust the repaint rect coordinates for the scroll offset.
208
209         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
210         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
211
212 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
213
214         Reviewed by Mitz.
215
216         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
217         Rename the "p" member variable of the PaintInfo struct to "context"
218
219         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
220           'context' and 'rect' respectively.
221
222         - Assorted surrounding cleanups.
223
224         * rendering/EllipsisBox.cpp:
225         (WebCore::EllipsisBox::paint):
226         * rendering/EllipsisBox.h:
227         * rendering/InlineBox.cpp:
228         (WebCore::InlineBox::paint):
229         * rendering/InlineFlowBox.cpp:
230         (WebCore::InlineFlowBox::paint):
231         (WebCore::InlineFlowBox::paintBackground):
232         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
233         (WebCore::InlineFlowBox::paintDecorations):
234         * rendering/InlineFlowBox.h:
235         * rendering/InlineRunBox.h:
236         * rendering/InlineTextBox.cpp:
237         (WebCore::InlineTextBox::paint):
238         * rendering/InlineTextBox.h:
239         * rendering/RenderBlock.cpp:
240         (WebCore::RenderBlock::paint):
241         (WebCore::RenderBlock::paintChildren):
242         (WebCore::RenderBlock::paintCaret):
243         (WebCore::RenderBlock::paintObject):
244         (WebCore::RenderBlock::paintFloats):
245         (WebCore::RenderBlock::paintEllipsisBoxes):
246         (WebCore::RenderBlock::paintSelection):
247         (WebCore::RenderBlock::fillSelectionGaps):
248         (WebCore::RenderBlock::fillInlineSelectionGaps):
249         (WebCore::RenderBlock::fillBlockSelectionGaps):
250         (WebCore::RenderBlock::fillHorizontalSelectionGap):
251         (WebCore::RenderBlock::fillVerticalSelectionGap):
252         (WebCore::RenderBlock::fillLeftSelectionGap):
253         (WebCore::RenderBlock::fillRightSelectionGap):
254         * rendering/RenderBox.cpp:
255         (WebCore::RenderBox::paint):
256         (WebCore::RenderBox::paintRootBoxDecorations):
257         (WebCore::RenderBox::paintBoxDecorations):
258         * rendering/RenderBox.h:
259         * rendering/RenderButton.cpp:
260         (WebCore::RenderButton::paintObject):
261         * rendering/RenderFieldset.cpp:
262         (WebCore::RenderFieldset::paintBoxDecorations):
263         * rendering/RenderFileUploadControl.cpp:
264         (WebCore::RenderFileUploadControl::paintObject):
265         * rendering/RenderFlow.cpp:
266         (WebCore::RenderFlow::continuationBefore):
267         (WebCore::RenderFlow::addChildWithContinuation):
268         (WebCore::RenderFlow::addChild):
269         (WebCore::RenderFlow::attachLineBox):
270         (WebCore::RenderFlow::destroy):
271         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
272         (WebCore::RenderFlow::dirtyLineBoxes):
273         (WebCore::RenderFlow::createInlineBox):
274         (WebCore::RenderFlow::paintLines):
275         (WebCore::RenderFlow::getAbsoluteRepaintRect):
276         (WebCore::RenderFlow::lowestPosition):
277         (WebCore::RenderFlow::rightmostPosition):
278         (WebCore::RenderFlow::leftmostPosition):
279         (WebCore::RenderFlow::caretRect):
280         (WebCore::RenderFlow::addFocusRingRects):
281         (WebCore::RenderFlow::paintOutline):
282         (WebCore::RenderFlow::paintOutlineForLine):
283         * rendering/RenderForeignObject.cpp:
284         (WebCore::RenderForeignObject::paint):
285         * rendering/RenderHTMLCanvas.cpp:
286         (WebCore::RenderHTMLCanvas::paint):
287         * rendering/RenderImage.cpp:
288         (WebCore::RenderImage::paint):
289         * rendering/RenderLayer.cpp:
290         (WebCore::RenderLayer::paintLayer):
291         * rendering/RenderListBox.cpp:
292         (WebCore::RenderListBox::paintObject):
293         (WebCore::RenderListBox::paintScrollbar):
294         (WebCore::RenderListBox::paintItemForeground):
295         (WebCore::RenderListBox::paintItemBackground):
296         * rendering/RenderListMarker.cpp:
297         (WebCore::RenderListMarker::paint):
298         * rendering/RenderMenuList.cpp:
299         (WebCore::RenderMenuList::paintObject):
300         * rendering/RenderObject.cpp:
301         (WebCore::RenderObject::paint):
302         * rendering/RenderObject.h:
303         (WebCore::RenderObject::PaintInfo::PaintInfo):
304         (WebCore::RenderObject::paintBoxDecorations):
305         (WebCore::RenderObject::paintingRootForChildren):
306         (WebCore::RenderObject::shouldPaintWithinRoot):
307         (WebCore::RenderObject::printBoxDecorations):
308         * rendering/RenderPath.cpp:
309         (WebCore::RenderPath::paint):
310         * rendering/RenderReplaced.cpp:
311         (WebCore::RenderReplaced::shouldPaint):
312         * rendering/RenderSVGContainer.cpp:
313         (WebCore::RenderSVGContainer::paint):
314         * rendering/RenderSVGContainer.h:
315         * rendering/RenderSVGImage.cpp:
316         (WebCore::RenderSVGImage::paint):
317         * rendering/RenderSVGText.cpp:
318         (WebCore::RenderSVGText::paint):
319         * rendering/RenderSVGText.h:
320         (WebCore::RenderSVGText::renderName):
321         * rendering/RenderTable.cpp:
322         (WebCore::RenderTable::paint):
323         (WebCore::RenderTable::paintBoxDecorations):
324         * rendering/RenderTable.h:
325         * rendering/RenderTableCell.cpp:
326         (WebCore::RenderTableCell::paint):
327         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
328         (WebCore::RenderTableCell::paintBoxDecorations):
329         * rendering/RenderTableCell.h:
330         * rendering/RenderTableRow.cpp:
331         (WebCore::RenderTableRow::paint):
332         * rendering/RenderTableRow.h:
333         * rendering/RenderTableSection.cpp:
334         (WebCore::RenderTableSection::paint):
335         * rendering/RenderTableSection.h:
336         (WebCore::RenderTableSection::getBaseline):
337         (WebCore::RenderTableSection::setNeedCellRecalc):
338         * rendering/RenderText.h:
339         (WebCore::RenderText::renderName):
340         (WebCore::RenderText::paint):
341         (WebCore::RenderText::element):
342         * rendering/RenderTheme.cpp:
343         (WebCore::RenderTheme::paint):
344         (WebCore::RenderTheme::paintBorderOnly):
345         (WebCore::RenderTheme::paintDecorations):
346         * rendering/RenderTheme.h:
347         (WebCore::RenderTheme::RenderTheme):
348         (WebCore::RenderTheme::~RenderTheme):
349         (WebCore::RenderTheme::controlSupportsTints):
350         (WebCore::RenderTheme::adjustRepaintRect):
351         (WebCore::RenderTheme::themeChanged):
352         (WebCore::RenderTheme::supportsHover):
353         (WebCore::RenderTheme::paintCheckbox):
354         (WebCore::RenderTheme::setCheckboxSize):
355         (WebCore::RenderTheme::paintRadio):
356         (WebCore::RenderTheme::setRadioSize):
357         (WebCore::RenderTheme::paintButton):
358         (WebCore::RenderTheme::setButtonSize):
359         (WebCore::RenderTheme::paintTextField):
360         (WebCore::RenderTheme::paintTextArea):
361         (WebCore::RenderTheme::paintMenuList):
362         (WebCore::RenderTheme::paintMenuListButton):
363         * rendering/RenderThemeMac.mm:
364         (WebCore::RenderThemeMac::paintCheckbox):
365         (WebCore::RenderThemeMac::paintRadio):
366         (WebCore::RenderThemeMac::paintButton):
367         (WebCore::RenderThemeMac::paintTextField):
368         (WebCore::RenderThemeMac::paintTextArea):
369         (WebCore::RenderThemeMac::paintMenuList):
370         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
371         (WebCore::RenderThemeMac::paintMenuListButton):
372         * rendering/RenderView.cpp:
373         (WebCore::RenderView::paint):
374         (WebCore::RenderView::paintBoxDecorations):
375         * rendering/RenderView.h:
376         * rendering/RenderWidget.cpp:
377         (WebCore::RenderWidget::paint):
378         * rendering/RenderWidget.h:
379         (WebCore::RenderWidget::isWidget):
380         * rendering/RootInlineBox.cpp:
381         (WebCore::RootInlineBox::paintEllipsisBox):
382         (WebCore::RootInlineBox::paintCustomHighlight):
383         (WebCore::RootInlineBox::paint):
384         (WebCore::RootInlineBox::fillLineSelectionGap):
385         * rendering/RootInlineBox.h:
386         * rendering/SVGInlineFlowBox.cpp:
387         (WebCore::paintSVGInlineFlow):
388
389 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
390
391         Reviewed by Oliver, Brady.
392
393         * platform/network/ResourceResponse.h:
394         (WebCore::ResourceResponse::setLastModifiedDate):
395         (WebCore::ResourceResponse::lastModifiedDate):
396         Add getters and setters for last modified dadte.
397         
398         * platform/network/cf/ResourceResponseCFNet.cpp:
399         (WebCore::getResourceResponse):
400         Fetch the last modified date. Add correct offset to expired date.
401
402 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
403
404         Reviewed by Mitz.
405
406         Added missing "break;" statement in switch statement from r17493.
407
408         Bug 11442: [CSS 3] support for cursor: all-scroll
409         http://bugs.webkit.org/show_bug.cgi?id=11442
410
411         * css/CSSComputedStyleDeclaration.cpp:
412         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
413
414 2006-10-31  Mitz Pettel  <mitz@webkit.org>
415
416         Reviewed by Maciej.
417
418         - fix image dragging
419
420         This is covered by editing/selection/drag-to-contenteditable-iframe.html
421
422         * rendering/HitTestResult.cpp:
423         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
424         HTML IMG elements.
425         (WebCore::HitTestResult::absoluteImageURL): Ditto.
426
427 2006-10-31  Beth Dakin  <bdakin@apple.com>
428
429         Reviewed by Maciej.
430
431         This adds the back-end of the remaining WebElementDictionary 
432         functions into HitTestResult.
433
434         * WebCore.exp:
435         * rendering/HitTestResult.cpp:
436         (WebCore::HitTestResult::title):
437         (WebCore::displayString): This is nearly identical to the 
438         displayString() defined in DOMInternal.mm except that it returns a 
439         String instead of an NSString. The old code path used the 
440         DOMInternal method, so I made a new one here for the new code path.
441         (WebCore::HitTestResult::altDisplayString):
442         (WebCore::HitTestResult::image):
443         (WebCore::HitTestResult::absoluteImageURL):
444         (WebCore::HitTestResult::absoluteLinkURL):
445         (WebCore::HitTestResult::titleDisplayString):
446         (WebCore::HitTestResult::textContent):
447         * rendering/HitTestResult.h:
448
449 2006-10-31  John Sullivan  <sullivan@apple.com>
450
451         * bridge/mac/FrameMac.mm:
452         (WebCore::FrameMac::markMisspellings):
453         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
454
455 2006-10-31  John Sullivan  <sullivan@apple.com>
456
457         Reviewed by Maciej
458         
459         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
460         
461         The foundation of this was in my last checkin. This checkin is all about displaying
462         the correct string in the toolTip.
463
464         * dom/DocumentMarker.h:
465         New description field in this struct.
466
467         * bridge/mac/FrameMac.mm:
468         (WebCore::FrameMac::advanceToNextMisspelling):
469         When adding a grammar marker, supply the appropriate description. Also, added a comment
470         about the remaining work to make grammar checking return sensible answers.
471         (WebCore::FrameMac::markMisspellings):
472         ditto (yes, still needs some refactoring to minimize duplicated code)
473         
474         * dom/Document.h:
475         * dom/Document.cpp:
476         (WebCore::Document::addMarker):
477         Now takes an optional description string
478         (WebCore::Document::markerContainingPoint):
479         New function, returns a pointer to the (first) marker of the specified type whose rect 
480         contains the specified point, or 0 if none.
481         
482         * rendering/HitTestResult.cpp:
483         (WebCore::HitTestResult::spellingToolTip):
484         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
485         and gets the description from the marker.
486
487 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
488
489         Reviewed by Maciej.
490         
491         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
492
493         * loader/mac/FrameLoaderMac.mm:
494         (WebCore::FrameLoader::createWindow):
495         * manual-tests/window-open-features-parsing.html: Updated for clarity.
496
497 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
498
499         Reviewed by Alice.
500
501         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
502         to WebCore::Editor.
503         
504         Layout tests pass.
505         
506         Renamed "may*" to "can*" because "can" is more accurate (these functions
507         aren't just about permission) and it matches WebKit.
508
509         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
510         password field. Now that WebCore fully implements canCopy(), it doesn't just
511         mean "the selection is not in a password field" anymore.
512         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
513         The fact that it's not called anymore may represent a security issue, but I
514         don't see how commented-out code will help reveal the issue, and the
515         bridge is going away, anyway.
516         * editing/SelectionController.h: Changed selection() calls to references
517         to m_sel, to match the rest of the file.
518
519 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
520
521         Reviewed by harrison
522         
523         <rdar://problem/4711063>
524         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
525
526         * editing/ReplaceSelectionCommand.cpp:
527         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
528         insertion and plain text string creation unless we need the string
529         for a BeforeTextInserted event handler or for a plain text only region.
530         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
531         code here from ReplacementFragment's constructor.
532         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
533         FIXME.
534         * editing/ReplaceSelectionCommand.h:
535
536 2006-10-31  Ada Chan  <adachan@apple.com>
537
538         Reviewed by Adam
539
540         Correct forward declarations of the HitTestRequest struct.
541
542         * rendering/EllipsisBox.h:
543         * rendering/InlineBox.h:
544         * rendering/InlineFlowBox.h:
545         * rendering/RenderLayer.h:
546         * rendering/RenderObject.h:
547
548 2006-10-31  John Sullivan  <sullivan@apple.com>
549
550         Reviewed by Beth and Adam
551
552         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
553         next I'll make it use a string that's relevant for a specific grammar error.
554
555         * WebCore.exp:
556         export symbol for spellingToolTip function
557         
558         * rendering/HitTestResult.h:
559         * rendering/HitTestResult.cpp:
560         (WebCore::HitTestResult::spellingToolTip):
561         new function, returns the string to be used in a tool tip that describes the questionable grammar
562         
563         * rendering/InlineTextBox.h:
564         * rendering/InlineTextBox.cpp:
565         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
566         now takes a style and font, needed to compute the rect representing the range containing
567         questionable grammar. Computes the rect and associates it with the marker.
568         (WebCore::InlineTextBox::paintDocumentMarkers):
569         Pass in the style and font now needed by paintSpellingOrGrammarMarker
570
571 2006-10-31  Adele Peterson  <adele@apple.com>
572
573         Removed commented out variable from last checkin.
574
575         * html/HTMLSelectElement.cpp:
576         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
577
578 2006-10-31  Brady Eidson  <beidson@apple.com>
579
580         Build fix (unused variable in release builds)
581
582         * html/HTMLSelectElement.cpp:
583         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
584
585 2006-10-31  Adele Peterson  <adele@apple.com>
586
587         Reviewed by Adam.
588
589         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
590         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
591         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
592
593         Tests: 
594         * LayoutTests/fast/forms/listbox-selection.html
595         * LayoutTests/fast/forms/listbox-onchange.html
596
597         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
598           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
599           And one for onChange, that is updated after onChange is fired.
600           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
601  
602         * html/HTMLSelectElement.cpp:
603         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
604         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
605         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
606         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
607         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
608         (WebCore::HTMLSelectElement::setExtent): Added.
609         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
610         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
611
612         * rendering/RenderListBox.cpp:
613         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
614         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
615         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
616         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
617          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
618          notify the select element from here.
619         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
620         (WebCore::RenderListBox::listIndexIsVisible): Added.
621         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
622
623         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
624         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
625         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
626         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
627         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
628
629 2006-10-31  Beth Dakin  <bdakin@apple.com>
630
631         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
632
633         * rendering/HitTestRequest.h: Added.
634         (WebCore::HitTestRequest::HitTestRequest):
635
636 2006-10-31  Beth Dakin  <bdakin@apple.com>
637
638         Reviewed by Maciej.
639
640         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
641         should be split into HitTestRequest and HitTestResult
642
643         This patch creates a new struct called HitTestRequest that holds 
644         the three boolean values (readonly, active, and mouseMove) that 
645         were formerly a part of HitTestResult. All hitTest() and 
646         nodeAtPoint() functions now take a HitTestRequest in addition to 
647         the HitTestResult.
648
649         * WebCore.exp:
650         * WebCore.xcodeproj/project.pbxproj:
651         * bridge/mac/FrameMac.mm:
652         (WebCore::FrameMac::eventMayStartDrag):
653         (WebCore::FrameMac::handleMouseMoveEvent):
654         * bridge/mac/WebCoreAXObject.mm:
655         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
656         (-[WebCoreAXObject accessibilityHitTest:]):
657         * dom/Document.cpp:
658         (WebCore::Document::elementFromPoint):
659         (WebCore::Document::prepareMouseEvent):
660         * editing/SelectionController.cpp:
661         (WebCore::SelectionController::contains):
662         * page/Frame.cpp:
663         (WebCore::Frame::hitTestResultAtPoint):
664         * page/FrameView.cpp:
665         (WebCore::FrameView::handleWheelEvent):
666         * rendering/EllipsisBox.cpp:
667         (WebCore::EllipsisBox::nodeAtPoint):
668         * rendering/EllipsisBox.h:
669         * rendering/HitTestResult.cpp:
670         (WebCore::HitTestResult::HitTestResult):
671         (WebCore::HitTestResult::operator=):
672         * rendering/HitTestResult.h:
673         * rendering/InlineBox.cpp:
674         (WebCore::InlineBox::nodeAtPoint):
675         * rendering/InlineBox.h:
676         * rendering/InlineFlowBox.cpp:
677         (WebCore::InlineFlowBox::nodeAtPoint):
678         * rendering/InlineFlowBox.h:
679         * rendering/InlineTextBox.cpp:
680         (WebCore::InlineTextBox::nodeAtPoint):
681         * rendering/InlineTextBox.h:
682         * rendering/RenderBlock.cpp:
683         (WebCore::RenderBlock::nodeAtPoint):
684         * rendering/RenderBlock.h:
685         * rendering/RenderBox.cpp:
686         (WebCore::RenderBox::nodeAtPoint):
687         * rendering/RenderBox.h:
688         * rendering/RenderFlow.cpp:
689         (WebCore::RenderFlow::hitTestLines):
690         * rendering/RenderFlow.h:
691         * rendering/RenderForeignObject.cpp:
692         (WebCore::RenderForeignObject::nodeAtPoint):
693         * rendering/RenderForeignObject.h:
694         * rendering/RenderFrameSet.cpp:
695         (WebCore::RenderFrameSet::nodeAtPoint):
696         * rendering/RenderFrameSet.h:
697         * rendering/RenderImage.cpp:
698         (WebCore::RenderImage::nodeAtPoint):
699         * rendering/RenderImage.h:
700         * rendering/RenderInline.cpp:
701         (WebCore::RenderInline::nodeAtPoint):
702         * rendering/RenderInline.h:
703         * rendering/RenderLayer.cpp:
704         (WebCore::RenderLayer::autoscroll):
705         (WebCore::RenderLayer::hitTest):
706         (WebCore::RenderLayer::hitTestLayer):
707         (WebCore::RenderLayer::updateHoverActiveState):
708         * rendering/RenderLayer.h:
709         * rendering/RenderObject.cpp:
710         (WebCore::RenderObject::hitTest):
711         (WebCore::RenderObject::nodeAtPoint):
712         * rendering/RenderObject.h:
713         * rendering/RenderPath.cpp:
714         (WebCore::RenderPath::nodeAtPoint):
715         * rendering/RenderPath.h:
716         * rendering/RenderSVGImage.cpp:
717         (WebCore::RenderSVGImage::nodeAtPoint):
718         * rendering/RenderSVGImage.h:
719         * rendering/RenderSVGText.cpp:
720         (WebCore::RenderSVGText::nodeAtPoint):
721         * rendering/RenderSVGText.h:
722         * rendering/RenderTableRow.cpp:
723         (WebCore::RenderTableRow::nodeAtPoint):
724         * rendering/RenderTableRow.h:
725         * rendering/RenderTableSection.cpp:
726         (WebCore::RenderTableSection::nodeAtPoint):
727         * rendering/RenderTableSection.h:
728         * rendering/RenderText.h:
729         (WebCore::RenderText::nodeAtPoint):
730         * rendering/RenderTextControl.cpp:
731         (WebCore::RenderTextControl::nodeAtPoint):
732         * rendering/RenderTextControl.h:
733         * rendering/RootInlineBox.cpp:
734         (WebCore::RootInlineBox::nodeAtPoint):
735         * rendering/RootInlineBox.h:
736
737 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
738
739         Reviewed by Maciej.
740
741         Bug 11442: [CSS 3] support for cursor: all-scroll
742         http://bugs.webkit.org/show_bug.cgi?id=11442
743
744         * css/CSSComputedStyleDeclaration.cpp:
745         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
746         * css/CSSValueKeywords.in:
747         * css/cssparser.cpp:
748         (WebCore::CSSParser::parseValue):
749         * page/FrameView.cpp:
750         (WebCore::selectCursor):
751         * rendering/RenderStyle.h:
752
753 2006-10-31  Oliver Hunt  <oliver@apple.com>
754
755         Reviewed by Geoff.
756
757         Converting Obj-C++ to C++ in kcanvas
758
759         * WebCore.xcodeproj/project.pbxproj:
760         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
761         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
762         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
763         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
764         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
765         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
766         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
767         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
768         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
769         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
770         * kcanvas/device/quartz/QuartzSupport.h:
771         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
772         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
773         (WebCore::SVGResourceClipper::applyClip):
774         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
775         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
776         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
777
778 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
779
780         Reviewed by harrison
781         
782         <rdar://problem/4808375>
783         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
784         
785         Completely back out r17276 because of performance issues.
786
787         * editing/TextIterator.cpp:
788         (WebCore::TextIterator::TextIterator):
789         (WebCore::TextIterator::advance):
790         (WebCore::TextIterator::handleTextNode):
791         (WebCore::TextIterator::handleTextBox):
792         (WebCore::TextIterator::handleReplacedElement):
793         (WebCore::TextIterator::handleNonTextNode):
794         (WebCore::TextIterator::exitNode):
795         (WebCore::TextIterator::emitCharacter):
796         (WebCore::TextIterator::range):
797         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
798         (WebCore::SimplifiedBackwardsTextIterator::advance):
799         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
800         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
801         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
802         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
803         (WebCore::SimplifiedBackwardsTextIterator::range):
804         (WebCore::CharacterIterator::range):
805         (WebCore::TextIterator::rangeFromLocationAndLength):
806         * editing/TextIterator.h:
807         (WebCore::TextIterator::atEnd):
808         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
809
810 2006-10-31  Darin Adler  <darin@apple.com>
811
812         Reviewed by Brady.
813
814         - got "action dictionary" code out of FrameLoader,
815           replacing with a class called NavigationAction
816
817         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
818         * loader/mac/DocumentLoaderMac.mm:
819         (WebCore::DocumentLoader::triggeringAction): Ditto.
820         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
821
822         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
823
824         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
825         Removed elementForEvent.
826         * loader/mac/FrameLoaderMac.mm:
827         (WebCore::FrameLoader::load): Ditto.
828         (WebCore::FrameLoader::reload): Ditto.
829         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
830         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
831         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
832         (WebCore::FrameLoader::post): Ditto.
833
834         * loader/NavigationAction.h: Added.
835         * loader/NavigationAction.cpp: Added.
836         * loader/mac/NavigationActionMac.mm: Added.
837
838         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
839
840         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
841         * WebCore.exp: Updated.
842
843 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
844
845         Reviewed by Adam.
846
847         Build fix
848
849         * platform/win/CookieJarWin.cpp:
850         (WebCore::cookies):
851
852 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
853
854         Reviewed by Maciej. Landed by Adam.
855
856         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
857
858         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
859         as dicussed with Dave. Also kill the outdated DESIGN document.
860
861         * CMakeLists.txt:
862         * WebCore.xcodeproj/project.pbxproj:
863         * kcanvas/DESIGN: Removed.
864         * kcanvas/KCanvasFilters.cpp:
865         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
866         * kcanvas/KCanvasTreeDebug.h: Ditto.
867         * kcanvas/device/KRenderingPaintServerGradient.cpp:
868         * kcanvas/device/KRenderingPaintServerPattern.cpp:
869         * kcanvas/device/KRenderingPaintServerSolid.cpp:
870         * platform/graphics/svg/SVGResourceClipper.cpp:
871         * rendering/RenderTreeAsText.cpp:
872         * rendering/SVGRenderTreeAsText.cpp: Added.
873         * rendering/SVGRenderTreeAsText.h: Added.
874         (WebCore::operator<<):
875
876 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
877
878         Reviewed by Maciej.
879
880         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
881         Includes some CRLF -> LF fixups.
882
883         * platform/win/CookieJarWin.cpp:
884         (WebCore::cookies):
885
886 2006-10-31  Adam Roben  <aroben@apple.com>
887
888         Reviewed by Steve.
889
890         Fix some incorrect forward declarations.
891
892         * loader/FrameLoader.h:
893         * page/Frame.h:
894
895 2006-10-31  Darin Adler  <darin@apple.com>
896
897         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
898         try to fix the build on the buildbot.
899
900 2006-10-31  Darin Adler  <darin@apple.com>
901
902         * bridge/mac/FrameMac.mm:
903         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
904         (WebCore::FrameMac::markMisspellings): Ditto.
905
906 2006-10-31  John Sullivan  <sullivan@apple.com>
907
908         * bridge/mac/FrameMac.mm:
909         (WebCore::FrameMac::advanceToNextMisspelling):
910         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
911
912 2006-10-30  John Sullivan  <sullivan@apple.com>
913
914         Reviewed by Adam Roben
915         
916         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
917         
918         This patch introduces much of the guts of grammar checking, though still not enough to actually
919         check grammar sensibly, due to:
920           
921         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
922         context passed to grammar checker
923
924         * platform/Logging.h:
925         * platform/Logging.cpp:
926         new log channel SpellingAndGrammar
927
928         * bridge/mac/WebCorePageBridge.mm:
929         (initializeLoggingChannelsIfNecessary):
930         initialize new log channel
931
932         * bridge/mac/FrameMac.mm:
933         (WebCore::FrameMac::advanceToNextMisspelling):
934         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
935         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
936         in the event of a tie), and do further processing with that one (select range; create marker that
937         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
938         (WebCore::FrameMac::markMisspellings):
939         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
940         differently enough to make sharing code between these two functions a little tricky, so I decided to 
941         save that for a later patch.
942         
943         (WebCore::FrameMac::respondToChangedSelection):
944         remove grammar markers when we remove spelling markers        
945
946 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
947
948         Reviewed by Mitz.
949
950         Fix Qt/Linux build with older gcc3.3.4.
951
952         * bindings/js/kjs_window.cpp:
953         (KJS::WindowFunc::callAsFunction):
954
955 2006-10-31  Zack Rusin  <zack@kde.org>
956
957         Reviewed by Mitz.
958
959         Fix the Qt build after last nights changes.
960
961         * WebCore/platform/qt/FrameQt.cpp:
962         * WebCore/platform/qt/EditorClientQt.h:
963         * WebCore/platform/qt/EditorClientQt.cpp:
964         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
965         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
966         * WebCore/CMakeLists.txt:
967         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
968         * WebKitQt/QtLauncher/CMakeLists.txt:
969         * WebKitQt/WebKitPart/CMakeLists.txt:
970
971 2006-10-30  Darin Adler  <darin@apple.com>
972
973         Reviewed by Anders.
974
975         - remove BrowserExtension
976
977         * WebCore.vcproj/WebCore/WebCore.vcproj:
978         * WebCore.xcodeproj/project.pbxproj:
979         * bindings/js/kjs_window.cpp:
980         (KJS::createNewWindow):
981         (KJS::WindowFunc::callAsFunction):
982         * bridge/BrowserExtension.h: Removed.
983         * bridge/mac/BrowserExtensionMac.h: Removed.
984         * bridge/mac/BrowserExtensionMac.mm: Removed.
985         * bridge/mac/FrameMac.mm:
986         (WebCore::FrameMac::FrameMac):
987         (WebCore::FrameMac::submitForm):
988         (WebCore::FrameMac::urlSelected):
989         * bridge/win/BrowserExtensionWin.cpp: Removed.
990         * bridge/win/BrowserExtensionWin.h: Removed.
991         * bridge/win/FrameWin.cpp:
992         (WebCore::FrameWin::FrameWin):
993         * loader/FrameLoader.cpp:
994         (WebCore::FrameLoader::createWindow):
995         * loader/FrameLoader.h:
996         * loader/icon/IconLoader.cpp:
997         * loader/mac/FrameLoaderMac.mm:
998         (WebCore::FrameLoader::safeLoad):
999         (WebCore::FrameLoader::load):
1000         (WebCore::FrameLoader::createWindow):
1001         * page/Frame.cpp:
1002         (WebCore::Frame::urlSelected):
1003         (WebCore::Frame::requestFrame):
1004         (WebCore::Frame::submitForm):
1005         (WebCore::Frame::scheduleHistoryNavigation):
1006         (WebCore::Frame::redirectionTimerFired):
1007         * page/Frame.h:
1008         * page/FrameLoadRequest.h:
1009         (WebCore::FrameLoadRequest::FrameLoadRequest):
1010         (WebCore::FrameLoadRequest::isEmpty):
1011         (WebCore::FrameLoadRequest::resourceRequest):
1012         (WebCore::FrameLoadRequest::frameName):
1013         (WebCore::FrameLoadRequest::setFrameName):
1014         * page/FramePrivate.h:
1015         (WebCore::FramePrivate::FramePrivate):
1016         (WebCore::FramePrivate::~FramePrivate):
1017         * platform/gdk/BrowserExtensionGdk.h: Removed.
1018         * platform/gdk/FrameGdk.cpp:
1019         (WebCore::FrameGdk::FrameGdk):
1020         * platform/gdk/TemporaryLinkStubs.cpp:
1021         * platform/network/ResourceRequest.h:
1022         (WebCore::ResourceRequest::isEmpty):
1023
1024 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1025
1026         Reviewed by Oliver.
1027
1028         Modified from original due to earlier reversion
1029
1030         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1031
1032         Better SVG integration in WebKit, Part I.
1033
1034         The patch is mostly about creating a new platform/graphics directory, and
1035         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1036         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1037         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1038
1039         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1040         All details of the patch, and upcoming patches can be found in the bug report.
1041
1042         * CMakeLists.txt:
1043         * WebCore.xcodeproj/project.pbxproj:
1044         * graphics/svg/SVGResource.cpp: Removed.
1045         * graphics/svg/SVGResourceClipper.cpp: Removed.
1046         * graphics/svg/SVGResourceClipper.h: Removed.
1047         * graphics/svg/SVGResourceImage.h: Removed.
1048         * graphics/svg/SVGResourceListener.h: Removed.
1049         * graphics/svg/SVGResourceMarker.cpp: Removed.
1050         * graphics/svg/SVGResourceMarker.h: Removed.
1051         * graphics/svg/SVGResourceMasker.cpp: Removed.
1052         * graphics/svg/SVGResourceMasker.h: Removed.
1053         * kcanvas/KCanvasClipper.cpp: Removed.
1054         * kcanvas/KCanvasClipper.h: Removed.
1055         * kcanvas/KCanvasCreator.cpp: Removed.
1056         * kcanvas/KCanvasCreator.h: Removed.
1057         * kcanvas/KCanvasFilters.cpp:
1058         (WebCore::getFilterById):
1059         * kcanvas/KCanvasFilters.h:
1060         * kcanvas/KCanvasImage.h: Removed.
1061         * kcanvas/KCanvasMarker.cpp: Removed.
1062         * kcanvas/KCanvasMarker.h: Removed.
1063         * kcanvas/KCanvasMasker.cpp: Removed.
1064         * kcanvas/KCanvasMasker.h: Removed.
1065         * kcanvas/KCanvasResource.cpp: Removed.
1066         * kcanvas/KCanvasResource.h: Removed.
1067         * kcanvas/KCanvasResourceListener.h: Removed.
1068         * kcanvas/KCanvasTreeDebug.cpp:
1069         (WebCore::writeRenderResources):
1070         * kcanvas/device/KRenderingDevice.h:
1071         * kcanvas/device/KRenderingPaintServer.h:
1072         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1073         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1074         (WebCore::KRenderingPaintServerGradient::listener):
1075         (WebCore::KRenderingPaintServerGradient::setListener):
1076         * kcanvas/device/KRenderingPaintServerGradient.h:
1077         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1078         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1079         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1080         (WebCore::KRenderingPaintServerPattern::tile):
1081         (WebCore::KRenderingPaintServerPattern::setTile):
1082         (WebCore::KRenderingPaintServerPattern::listener):
1083         (WebCore::KRenderingPaintServerPattern::setListener):
1084         * kcanvas/device/KRenderingPaintServerPattern.h:
1085         * kcanvas/device/KRenderingPaintServerSolid.h:
1086         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1087         * kcanvas/device/qt/KCanvasClipperQt.h:
1088         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1089         (WebCore::KRenderingDeviceQt::contextForImage):
1090         (WebCore::KRenderingDeviceQt::createResource):
1091         (WebCore::KRenderingDeviceQt::createPaintServer):
1092         * kcanvas/device/qt/KRenderingDeviceQt.h:
1093         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1094         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1095         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1096         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1097         * kcanvas/device/qt/RenderPathQt.h: Removed.
1098         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1099         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1100         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1101         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1102         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1103         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1104         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1105         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1106         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1107         (WebCore::KRenderingDeviceQuartz::contextForImage):
1108         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1109         (WebCore::KRenderingDeviceQuartz::createResource):
1110         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1111         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1112         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1113         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1114         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1115         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1116         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1117         (WebCore::patternCallback):
1118         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1119         * kcanvas/device/quartz/QuartzSupport.mm:
1120         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1121         (WebCore::sharedSolidPaintServer):
1122         * ksvg2/svg/SVGClipPathElement.cpp:
1123         (WebCore::SVGClipPathElement::SVGClipPathElement):
1124         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1125         (WebCore::SVGClipPathElement::canvasResource):
1126         * ksvg2/svg/SVGClipPathElement.h:
1127         * ksvg2/svg/SVGFEImageElement.cpp:
1128         * ksvg2/svg/SVGFilterElement.cpp:
1129         (WebCore::SVGFilterElement::SVGFilterElement):
1130         (WebCore::SVGFilterElement::~SVGFilterElement):
1131         (WebCore::SVGFilterElement::canvasResource):
1132         * ksvg2/svg/SVGFilterElement.h:
1133         * ksvg2/svg/SVGGradientElement.cpp:
1134         (WebCore::SVGGradientElement::SVGGradientElement):
1135         (WebCore::SVGGradientElement::~SVGGradientElement):
1136         (WebCore::SVGGradientElement::canvasResource):
1137         (WebCore::SVGGradientElement::resourceNotification):
1138         * ksvg2/svg/SVGGradientElement.h:
1139         * ksvg2/svg/SVGImageElement.cpp:
1140         * ksvg2/svg/SVGLinearGradientElement.cpp:
1141         (WebCore::SVGLinearGradientElement::buildGradient):
1142         * ksvg2/svg/SVGLinearGradientElement.h:
1143         * ksvg2/svg/SVGMarkerElement.cpp:
1144         (WebCore::SVGMarkerElement::SVGMarkerElement):
1145         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1146         (WebCore::SVGMarkerElement::canvasResource):
1147         * ksvg2/svg/SVGMarkerElement.h:
1148         * ksvg2/svg/SVGMaskElement.cpp:
1149         (WebCore::SVGMaskElement::SVGMaskElement):
1150         (WebCore::SVGMaskElement::~SVGMaskElement):
1151         (WebCore::SVGMaskElement::drawMaskerContent):
1152         (WebCore::SVGMaskElement::canvasResource):
1153         * ksvg2/svg/SVGMaskElement.h:
1154         * ksvg2/svg/SVGPatternElement.cpp:
1155         (WebCore::SVGPatternElement::SVGPatternElement):
1156         (WebCore::SVGPatternElement::~SVGPatternElement):
1157         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1158         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1159         (WebCore::SVGPatternElement::canvasResource):
1160         * ksvg2/svg/SVGPatternElement.h:
1161         * ksvg2/svg/SVGRadialGradientElement.cpp:
1162         (WebCore::SVGRadialGradientElement::buildGradient):
1163         * ksvg2/svg/SVGRadialGradientElement.h:
1164         * ksvg2/svg/SVGStyledElement.h:
1165         (WebCore::SVGStyledElement::canvasResource):
1166         * platform/GraphicsContext.cpp: Removed.
1167         * platform/GraphicsContext.h: Removed.
1168         * platform/GraphicsTypes.cpp: Removed.
1169         * platform/GraphicsTypes.h: Removed.
1170         * platform/graphics/GraphicsContext.cpp:
1171         (WebCore::GraphicsContextState::GraphicsContextState):
1172         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1173         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1174         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1175         (WebCore::GraphicsContext::save):
1176         (WebCore::GraphicsContext::restore):
1177         (WebCore::GraphicsContext::font):
1178         (WebCore::GraphicsContext::setFont):
1179         (WebCore::GraphicsContext::pen):
1180         (WebCore::GraphicsContext::setPen):
1181         (WebCore::GraphicsContext::setFillColor):
1182         (WebCore::GraphicsContext::fillColor):
1183         (WebCore::GraphicsContext::updatingControlTints):
1184         (WebCore::GraphicsContext::setUpdatingControlTints):
1185         (WebCore::GraphicsContext::setPaintingDisabled):
1186         (WebCore::GraphicsContext::paintingDisabled):
1187         (WebCore::GraphicsContext::drawImage):
1188         (WebCore::GraphicsContext::drawText):
1189         (WebCore::GraphicsContext::drawHighlightForText):
1190         (WebCore::GraphicsContext::initFocusRing):
1191         (WebCore::GraphicsContext::clearFocusRing):
1192         (WebCore::GraphicsContext::focusRingBoundingRect):
1193         (WebCore::GraphicsContext::addFocusRingRect):
1194         (WebCore::GraphicsContext::focusRingWidth):
1195         (WebCore::GraphicsContext::focusRingOffset):
1196         (WebCore::GraphicsContext::focusRingRects):
1197         (WebCore::GraphicsContext::drawTiledImage):
1198         * platform/graphics/GraphicsContext.h:
1199         * platform/graphics/GraphicsTypes.cpp:
1200         (WebCore::):
1201         (WebCore::parseCompositeOperator):
1202         (WebCore::compositeOperatorName):
1203         (WebCore::parseLineCap):
1204         (WebCore::lineCapName):
1205         (WebCore::parseLineJoin):
1206         (WebCore::lineJoinName):
1207         * platform/graphics/GraphicsTypes.h:
1208         (WebCore::):
1209         * platform/graphics/svg/SVGResource.cpp: Added.
1210         (WebCore::SVGResource::SVGResource):
1211         (WebCore::SVGResource::~SVGResource):
1212         (WebCore::SVGResource::invalidate):
1213         (WebCore::SVGResource::addClient):
1214         (WebCore::SVGResource::clients):
1215         (WebCore::SVGResource::idInRegistry):
1216         (WebCore::SVGResource::setIdInRegistry):
1217         (WebCore::SVGResource::externalRepresentation):
1218         (WebCore::getResourceById):
1219         (WebCore::getPaintServerById):
1220         (WebCore::operator<<):
1221         * platform/graphics/svg/SVGResource.h: Added.
1222         (WebCore::):
1223         (WebCore::SVGResource::isPaintServer):
1224         (WebCore::SVGResource::isFilter):
1225         (WebCore::SVGResource::isClipper):
1226         (WebCore::SVGResource::isMarker):
1227         (WebCore::SVGResource::isMasker):
1228         (WebCore::SVGResourceListener::~SVGResourceListener):
1229         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1230         (WebCore::SVGResourceClipper::SVGResourceClipper):
1231         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1232         (WebCore::SVGResourceClipper::resetClipData):
1233         (WebCore::SVGResourceClipper::addClipData):
1234         (WebCore::SVGResourceClipper::clipData):
1235         (WebCore::SVGResourceClipper::externalRepresentation):
1236         (WebCore::operator<<):
1237         (WebCore::getClipperById):
1238         * platform/graphics/svg/SVGResourceClipper.h: Added.
1239         (WebCore::ClipDataList::addPath):
1240         (WebCore::SVGResourceClipper::isClipper):
1241         * platform/graphics/svg/SVGResourceImage.h: Added.
1242         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1243         (WebCore::SVGResourceMarker::SVGResourceMarker):
1244         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1245         (WebCore::SVGResourceMarker::setMarker):
1246         (WebCore::SVGResourceMarker::setRef):
1247         (WebCore::SVGResourceMarker::draw):
1248         (WebCore::SVGResourceMarker::externalRepresentation):
1249         (WebCore::getMarkerById):
1250         * platform/graphics/svg/SVGResourceMarker.h: Added.
1251         (WebCore::SVGResourceMarker::refX):
1252         (WebCore::SVGResourceMarker::refY):
1253         (WebCore::SVGResourceMarker::setAngle):
1254         (WebCore::SVGResourceMarker::setAutoAngle):
1255         (WebCore::SVGResourceMarker::angle):
1256         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1257         (WebCore::SVGResourceMarker::useStrokeWidth):
1258         (WebCore::SVGResourceMarker::isMarker):
1259         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1260         (WebCore::SVGResourceMasker::SVGResourceMasker):
1261         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1262         (WebCore::SVGResourceMasker::setMask):
1263         (WebCore::SVGResourceMasker::mask):
1264         (WebCore::SVGResourceMasker::externalRepresentation):
1265         (WebCore::getMaskerById):
1266         * platform/graphics/svg/SVGResourceMasker.h: Added.
1267         (WebCore::SVGResourceMasker::isMasker):
1268         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1269         (WebCore::SVGResourceClipper::applyClip):
1270         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1271         (WebCore::SVGResourceImage::SVGResourceImage):
1272         (WebCore::SVGResourceImage::~SVGResourceImage):
1273         (WebCore::SVGResourceImage::init):
1274         (WebCore::SVGResourceImage::size):
1275         (WebCore::SVGResourceImage::cgLayer):
1276         (WebCore::SVGResourceImage::setCGLayer):
1277         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1278         (WebCore::applyLuminanceToAlphaFilter):
1279         (WebCore::applyExpandAlphatoGrayscaleFilter):
1280         (WebCore::transformImageIntoGrayscaleMask):
1281         (WebCore::SVGResourceMasker::applyMask):
1282         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1283         (WebCore::SVGResourceClipper::applyClip):
1284         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1285         (WebCore::SVGResourceImage::init):
1286         (WebCore::SVGResourceImage::size):
1287         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1288         (WebCore::SVGResourceMasker::applyMask):
1289         * platform/qt/GraphicsContextQt.cpp:
1290         * rendering/RenderPath.cpp:
1291         (WebCore::RenderPath::paint):
1292         (WebCore::DrawMarkersData::DrawMarkersData):
1293         (WebCore::RenderPath::drawMarkersIfNeeded):
1294         * rendering/RenderSVGContainer.cpp:
1295         (WebCore::RenderSVGContainer::paint):
1296         * rendering/RenderSVGImage.cpp:
1297         (WebCore::RenderSVGImage::paint):
1298         * rendering/SVGInlineFlowBox.cpp:
1299         (WebCore::paintSVGInlineFlow):
1300
1301 2006-10-30  John Sullivan  <sullivan@apple.com>
1302
1303         Reviewed by Brady
1304         
1305         - minor cleanup to make future patches clearer
1306
1307         * bridge/mac/FrameMac.mm:
1308         (WebCore::FrameMac::advanceToNextMisspelling):
1309         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1310         with "continue" to better match structure of similar code in markMisspellings; a few
1311         other style tweaks.
1312         
1313         (WebCore::FrameMac::markMisspellings):
1314         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1315         a block just after a break and outdented accordingly.
1316
1317 2006-10-30  John Sullivan  <sullivan@apple.com>
1318
1319         Reviewed by Geoff Garen
1320         
1321         WebCore part of change to push the code that updates the spelling panel
1322         into WebCore, in preparation for some grammar-checking stuff.
1323
1324         * bridge/mac/FrameMac.h:
1325         * bridge/mac/FrameMac.mm:
1326         (WebCore::FrameMac::advanceToNextMisspelling):
1327         no more return value for this method, and update the spelling panel with
1328         the misspelled word here rather than in the WebKit callers.
1329
1330 2006-10-30  Oliver Hunt  <oliver@apple.com>
1331
1332         Reviewed by Anders.
1333
1334         Roll out last patch
1335
1336         * CMakeLists.txt:
1337         * ChangeLog:
1338         * WebCore.xcodeproj/project.pbxproj:
1339         * graphics/svg/SVGResource.cpp:
1340         * graphics/svg/SVGResourceClipper.cpp:
1341         * graphics/svg/SVGResourceClipper.h:
1342         * graphics/svg/SVGResourceImage.h:
1343         * graphics/svg/SVGResourceListener.h:
1344         * graphics/svg/SVGResourceMarker.cpp:
1345         * graphics/svg/SVGResourceMarker.h:
1346         * graphics/svg/SVGResourceMasker.cpp:
1347         * graphics/svg/SVGResourceMasker.h:
1348         * kcanvas/KCanvasClipper.cpp: Added.
1349         (WebCore::operator<<):
1350         (WebCore::KCanvasClipper::KCanvasClipper):
1351         (WebCore::KCanvasClipper::~KCanvasClipper):
1352         (WebCore::KCanvasClipper::resetClipData):
1353         (WebCore::KCanvasClipper::addClipData):
1354         (WebCore::KCanvasClipper::clipData):
1355         (WebCore::KCanvasClipper::externalRepresentation):
1356         (WebCore::getClipperById):
1357         * kcanvas/KCanvasClipper.h: Added.
1358         (WebCore::KCClipData::windRule):
1359         (WebCore::KCClipDataList::KCClipDataList):
1360         (WebCore::KCClipDataList::addPath):
1361         (WebCore::KCanvasClipper::isClipper):
1362         * kcanvas/KCanvasFilters.cpp:
1363         (WebCore::getFilterById):
1364         * kcanvas/KCanvasFilters.h:
1365         * kcanvas/KCanvasImage.h: Added.
1366         (WebCore::KCanvasImage::KCanvasImage):
1367         (WebCore::KCanvasImage::~KCanvasImage):
1368         * kcanvas/KCanvasMarker.cpp: Added.
1369         (WebCore::KCanvasMarker::KCanvasMarker):
1370         (WebCore::KCanvasMarker::~KCanvasMarker):
1371         (WebCore::KCanvasMarker::setMarker):
1372         (WebCore::KCanvasMarker::setRef):
1373         (WebCore::KCanvasMarker::refX):
1374         (WebCore::KCanvasMarker::refY):
1375         (WebCore::KCanvasMarker::setAngle):
1376         (WebCore::KCanvasMarker::angle):
1377         (WebCore::KCanvasMarker::setAutoAngle):
1378         (WebCore::KCanvasMarker::setUseStrokeWidth):
1379         (WebCore::KCanvasMarker::useStrokeWidth):
1380         (WebCore::KCanvasMarker::draw):
1381         (WebCore::KCanvasMarker::externalRepresentation):
1382         (WebCore::getMarkerById):
1383         * kcanvas/KCanvasMarker.h: Added.
1384         (WebCore::KCanvasMarker::isMarker):
1385         * kcanvas/KCanvasMasker.cpp: Added.
1386         (WebCore::KCanvasMasker::KCanvasMasker):
1387         (WebCore::KCanvasMasker::~KCanvasMasker):
1388         (WebCore::KCanvasMasker::setMask):
1389         (WebCore::KCanvasMasker::externalRepresentation):
1390         (WebCore::getMaskerById):
1391         * kcanvas/KCanvasMasker.h: Added.
1392         (WebCore::KCanvasMasker::isMasker):
1393         (WebCore::KCanvasMasker::mask):
1394         * kcanvas/KCanvasResource.cpp: Added.
1395         (WebCore::operator<<):
1396         (WebCore::KCanvasResource::KCanvasResource):
1397         (WebCore::KCanvasResource::~KCanvasResource):
1398         (WebCore::KCanvasResource::addClient):
1399         (WebCore::KCanvasResource::clients):
1400         (WebCore::KCanvasResource::invalidate):
1401         (WebCore::KCanvasResource::idInRegistry):
1402         (WebCore::KCanvasResource::setIdInRegistry):
1403         (WebCore::KCanvasResource::externalRepresentation):
1404         (WebCore::getResourceById):
1405         (WebCore::getPaintServerById):
1406         * kcanvas/KCanvasResource.h:
1407         (WebCore::):
1408         (WebCore::KCanvasResource::isPaintServer):
1409         (WebCore::KCanvasResource::isFilter):
1410         (WebCore::KCanvasResource::isClipper):
1411         (WebCore::KCanvasResource::isMarker):
1412         (WebCore::KCanvasResource::isMasker):
1413         * kcanvas/KCanvasResourceListener.h: Added.
1414         (KCanvasResourceListener::KCanvasResourceListener):
1415         (KCanvasResourceListener::~KCanvasResourceListener):
1416         * kcanvas/KCanvasTreeDebug.cpp:
1417         (WebCore::writeRenderResources):
1418         * kcanvas/device/KRenderingDevice.h:
1419         * kcanvas/device/KRenderingPaintServer.h:
1420         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1421         (WebCore::KRenderingPaintServer::idInRegistry):
1422         (WebCore::KRenderingPaintServer::setIdInRegistry):
1423         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1424         (WebCore::KRenderingPaintServerGradient::listener):
1425         (WebCore::KRenderingPaintServerGradient::setListener):
1426         * kcanvas/device/KRenderingPaintServerGradient.h:
1427         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1428         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1429         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1430         (WebCore::KRenderingPaintServerPattern::tile):
1431         (WebCore::KRenderingPaintServerPattern::setTile):
1432         (WebCore::KRenderingPaintServerPattern::listener):
1433         (WebCore::KRenderingPaintServerPattern::setListener):
1434         * kcanvas/device/KRenderingPaintServerPattern.h:
1435         * kcanvas/device/KRenderingPaintServerSolid.h:
1436         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1437         (WebCore::KCanvasClipperQt::applyClip):
1438         * kcanvas/device/qt/KCanvasClipperQt.h:
1439         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1440         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1441         (WebCore::KRenderingDeviceQt::contextForImage):
1442         (WebCore::KRenderingDeviceQt::createResource):
1443         (WebCore::KRenderingDeviceQt::createPaintServer):
1444         * kcanvas/device/qt/KRenderingDeviceQt.h:
1445         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1446         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1447         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1448         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1449         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1450         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1451         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1452         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1453         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1454         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1455         (WebCore::applyLuminanceToAlphaFilter):
1456         (WebCore::applyExpandAlphatoGrayscaleFilter):
1457         (WebCore::transformImageIntoGrayscaleMask):
1458         (WebCore::KCanvasMaskerQuartz::applyMask):
1459         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1460         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1461         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1462         (WebCore::KCanvasImageQuartz::init):
1463         (WebCore::KCanvasImageQuartz::size):
1464         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1465         (WebCore::KCanvasClipperQuartz::applyClip):
1466         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1467         (WebCore::KCanvasImageQuartz::cgLayer):
1468         (WebCore::KCanvasImageQuartz::setCGLayer):
1469         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1470         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1471         (WebCore::KRenderingDeviceQuartz::contextForImage):
1472         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1473         (WebCore::KRenderingDeviceQuartz::createResource):
1474         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1475         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1476         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1477         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1478         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1479         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1480         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1481         (WebCore::patternCallback):
1482         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1483         * kcanvas/device/quartz/QuartzSupport.mm:
1484         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1485         (WebCore::sharedSolidPaintServer):
1486         * ksvg2/svg/SVGClipPathElement.cpp:
1487         (WebCore::SVGClipPathElement::SVGClipPathElement):
1488         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1489         (WebCore::SVGClipPathElement::canvasResource):
1490         * ksvg2/svg/SVGClipPathElement.h:
1491         * ksvg2/svg/SVGFEImageElement.cpp:
1492         * ksvg2/svg/SVGFilterElement.cpp:
1493         (WebCore::SVGFilterElement::SVGFilterElement):
1494         (WebCore::SVGFilterElement::~SVGFilterElement):
1495         (WebCore::SVGFilterElement::canvasResource):
1496         * ksvg2/svg/SVGFilterElement.h:
1497         * ksvg2/svg/SVGGradientElement.cpp:
1498         (WebCore::SVGGradientElement::SVGGradientElement):
1499         (WebCore::SVGGradientElement::~SVGGradientElement):
1500         (WebCore::SVGGradientElement::canvasResource):
1501         (WebCore::SVGGradientElement::resourceNotification):
1502         * ksvg2/svg/SVGGradientElement.h:
1503         * ksvg2/svg/SVGImageElement.cpp:
1504         * ksvg2/svg/SVGLinearGradientElement.cpp:
1505         (WebCore::SVGLinearGradientElement::buildGradient):
1506         * ksvg2/svg/SVGLinearGradientElement.h:
1507         * ksvg2/svg/SVGMarkerElement.cpp:
1508         (WebCore::SVGMarkerElement::SVGMarkerElement):
1509         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1510         (WebCore::SVGMarkerElement::canvasResource):
1511         * ksvg2/svg/SVGMarkerElement.h:
1512         * ksvg2/svg/SVGMaskElement.cpp:
1513         (WebCore::SVGMaskElement::SVGMaskElement):
1514         (WebCore::SVGMaskElement::~SVGMaskElement):
1515         (WebCore::SVGMaskElement::drawMaskerContent):
1516         (WebCore::SVGMaskElement::canvasResource):
1517         * ksvg2/svg/SVGMaskElement.h:
1518         * ksvg2/svg/SVGPatternElement.cpp:
1519         (WebCore::SVGPatternElement::SVGPatternElement):
1520         (WebCore::SVGPatternElement::~SVGPatternElement):
1521         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1522         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1523         (WebCore::SVGPatternElement::canvasResource):
1524         * ksvg2/svg/SVGPatternElement.h:
1525         * ksvg2/svg/SVGRadialGradientElement.cpp:
1526         (WebCore::SVGRadialGradientElement::buildGradient):
1527         * ksvg2/svg/SVGRadialGradientElement.h:
1528         * ksvg2/svg/SVGStyledElement.h:
1529         (WebCore::SVGStyledElement::canvasResource):
1530         * platform/GraphicsContext.cpp: Added.
1531         (WebCore::GraphicsContextState::GraphicsContextState):
1532         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1533         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1534         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1535         (WebCore::GraphicsContext::save):
1536         (WebCore::GraphicsContext::restore):
1537         (WebCore::GraphicsContext::font):
1538         (WebCore::GraphicsContext::setFont):
1539         (WebCore::GraphicsContext::pen):
1540         (WebCore::GraphicsContext::setPen):
1541         (WebCore::GraphicsContext::setFillColor):
1542         (WebCore::GraphicsContext::fillColor):
1543         (WebCore::GraphicsContext::updatingControlTints):
1544         (WebCore::GraphicsContext::setUpdatingControlTints):
1545         (WebCore::GraphicsContext::setPaintingDisabled):
1546         (WebCore::GraphicsContext::paintingDisabled):
1547         (WebCore::GraphicsContext::drawImage):
1548         (WebCore::GraphicsContext::drawText):
1549         (WebCore::GraphicsContext::drawHighlightForText):
1550         (WebCore::GraphicsContext::initFocusRing):
1551         (WebCore::GraphicsContext::clearFocusRing):
1552         (WebCore::GraphicsContext::focusRingBoundingRect):
1553         (WebCore::GraphicsContext::addFocusRingRect):
1554         (WebCore::GraphicsContext::focusRingWidth):
1555         (WebCore::GraphicsContext::focusRingOffset):
1556         (WebCore::GraphicsContext::focusRingRects):
1557         (WebCore::GraphicsContext::drawTiledImage):
1558         * platform/GraphicsContext.h: Added.
1559         * platform/GraphicsTypes.cpp: Added.
1560         (WebCore::):
1561         (WebCore::parseCompositeOperator):
1562         (WebCore::compositeOperatorName):
1563         (WebCore::parseLineCap):
1564         (WebCore::lineCapName):
1565         (WebCore::parseLineJoin):
1566         (WebCore::lineJoinName):
1567         * platform/GraphicsTypes.h: Added.
1568         (WebCore::):
1569         * platform/graphics/GraphicsContext.cpp:
1570         * platform/graphics/GraphicsContext.h:
1571         * platform/graphics/GraphicsTypes.cpp:
1572         * platform/graphics/GraphicsTypes.h:
1573         * platform/qt/GraphicsContextQt.cpp:
1574         * rendering/RenderPath.cpp:
1575         (WebCore::RenderPath::paint):
1576         (WebCore::DrawMarkersData::DrawMarkersData):
1577         (WebCore::RenderPath::drawMarkersIfNeeded):
1578         * rendering/RenderSVGContainer.cpp:
1579         (WebCore::RenderSVGContainer::paint):
1580         * rendering/RenderSVGImage.cpp:
1581         (WebCore::RenderSVGImage::paint):
1582         * rendering/SVGInlineFlowBox.cpp:
1583         (WebCore::paintSVGInlineFlow):
1584
1585 2006-10-30  John Sullivan  <sullivan@apple.com>
1586
1587         Reviewed by Geoff Garen.
1588         
1589         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1590         grammar-related method.
1591
1592         * bridge/EditorClient.h:
1593         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1594         isGrammarCheckingEnabled()
1595         
1596         * bridge/mac/WebCoreFrameBridge.h:
1597         removed bridge equivalents
1598
1599         * bridge/mac/FrameMac.mm:
1600         (WebCore::FrameMac::advanceToNextMisspelling):
1601         convert bridge-using code to editor()->client()-using code
1602         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1603         ditto
1604         (WebCore::FrameMac::markMisspellings):
1605         ditto
1606         (WebCore::FrameMac::respondToChangedSelection):
1607         ditto
1608         
1609         * editing/Editor.h:
1610         * editing/Editor.cpp:
1611         (WebCore::Editor::client):
1612         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1613         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1614         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1615
1616 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1617
1618         Reviewed by Darin.
1619
1620         Removed a number of editing and selection methods from the bridge.
1621         
1622         I moved cross-platform editing and selection code into Editor and 
1623         SelectionController, respecitvely.
1624
1625         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1626         everything + the kitchen sink.
1627         
1628         Specific comments below for interesting things.
1629         
1630         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1631         a new file so that WebKit can use them, too. Added a helper method for
1632         handling exceptions when selecting a Range.
1633         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1634         WebKit, since they have to do with creating an NSAttributedString for API
1635         consumption, and not much to do with general Frame functionality.
1636         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1637         for now) into the Editor. Eventually, the Frame will not have to notify 
1638         the Editor of what the lastEditCommand was, since the Editor will perform
1639         all EditCommands.
1640         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1641         * editing/SelectionController.cpp:
1642         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1643         and return them. The bridge method to select a DOM range did this implicitly,
1644         since all ObjC DOM operations handle DOM exceptions by throwing them as
1645         ObjC exceptions.
1646         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1647         The two enumerations are numerically identical, but that's an implementation
1648         detail of TextAffinity that clients shouldn't be required to know about.
1649
1650 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1651
1652         Rolling out the following change because this crash:
1653         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1654
1655         And this regression:
1656         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1657
1658     2006-09-06  David Harrison  <harrison@apple.com>
1659
1660         Reviewed and tweaked by Tim H. 
1661
1662         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1663
1664         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1665         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1666         No layout tests affected. Not testable in an automated way that will work on all systems. 
1667
1668         * platform/mac/WebFontCache.mm: 
1669         (+[WebFontCache fontWithFamily:traits:size:]): 
1670
1671 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1672
1673         Reviewed by harrison
1674
1675         <rdar://problem/4808375>
1676         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1677
1678         * editing/TextIterator.cpp:
1679         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1680         when we're going to use them to create a range for an emitted character.
1681         We should further speed TextIterators up by avoiding creating VisiblePositions
1682         for TIs that are only used for the characters they emit (like the one that 
1683         plainText uses).
1684
1685 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1686
1687         Reviewed by Mitz.
1688
1689         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1690         More rendering code cleaning
1691
1692         * WebCore.xcodeproj/project.pbxproj:
1693         * rendering/RenderApplet.cpp:
1694         (WebCore::RenderApplet::RenderApplet):
1695         (WebCore::RenderApplet::createWidgetIfNecessary):
1696         * rendering/RenderApplet.h:
1697         * rendering/RenderArena.cpp:
1698         (WebCore::):
1699         (WebCore::RenderArena::RenderArena):
1700         (WebCore::RenderArena::allocate):
1701         (WebCore::RenderArena::free):
1702         * rendering/RenderArena.h:
1703         * rendering/RenderBR.cpp:
1704         (WebCore::RenderBR::RenderBR):
1705         (WebCore::RenderBR::baselinePosition):
1706         (WebCore::RenderBR::lineHeight):
1707         (WebCore::RenderBR::setStyle):
1708         (WebCore::RenderBR::caretMinOffset):
1709         (WebCore::RenderBR::positionForCoordinates):
1710         (WebCore::RenderBR::inlineBox):
1711         * rendering/RenderBR.h:
1712         * rendering/RenderBlock.cpp:
1713         * rendering/RenderBlock.h:
1714         (WebCore::RenderBlock::maxTopMargin):
1715         (WebCore::RenderBlock::maxBottomMargin):
1716         (WebCore::RenderBlock::initMaxMarginValues):
1717         (WebCore::RenderBlock::containsFloats):
1718         (WebCore::RenderBlock::setHasMarkupTruncation):
1719         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1720         (WebCore::RenderBlock::BlockSelectionInfo::block):
1721         (WebCore::RenderBlock::BlockSelectionInfo::state):
1722         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1723         (WebCore::RenderBlock::CompactInfo::clear):
1724         * rendering/RenderButton.cpp:
1725         (WebCore::RenderButton::removeChild):
1726         (WebCore::RenderButton::paintObject):
1727         * rendering/RenderButton.h:
1728         (WebCore::RenderButton::renderName):
1729         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1730         * rendering/RenderContainer.cpp:
1731         (WebCore::RenderContainer::RenderContainer):
1732         * rendering/RenderContainer.h:
1733         (WebCore::RenderContainer::firstChild):
1734         (WebCore::RenderContainer::lastChild):
1735         (WebCore::RenderContainer::calcMinMaxWidth):
1736         * rendering/RenderCounter.cpp:
1737         (WebCore::RenderCounter::RenderCounter):
1738         (WebCore::toRoman):
1739         (WebCore::toHebrew):
1740         (WebCore::RenderCounter::calcMinMaxWidth):
1741         * rendering/RenderCounter.h:
1742         * rendering/RenderFieldset.cpp:
1743         (WebCore::RenderFieldset::paintBoxDecorations):
1744         (WebCore::RenderFieldset::paintBorderMinusLegend):
1745         (WebCore::RenderFieldset::setStyle):
1746         * rendering/RenderFileUploadControl.cpp:
1747         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1748         (WebCore::RenderFileUploadControl::setStyle):
1749         (WebCore::RenderFileUploadControl::paintObject):
1750         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1751         * rendering/RenderFileUploadControl.h:
1752         (WebCore::RenderFileUploadControl::renderName):
1753         * rendering/RenderFlexibleBox.h:
1754         * rendering/RenderFlow.cpp:
1755         * rendering/RenderFlow.h:
1756         * rendering/RenderForeignObject.cpp:
1757         (WebCore::RenderForeignObject::RenderForeignObject):
1758         (WebCore::RenderForeignObject::paint):
1759         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1760         (WebCore::RenderForeignObject::layout):
1761         (WebCore::RenderForeignObject::nodeAtPoint):
1762         * rendering/RenderForeignObject.h:
1763         (WebCore::RenderForeignObject::renderName):
1764         * rendering/RenderFormElement.cpp:
1765         (WebCore::RenderFormElement::setStyle):
1766         (WebCore::RenderFormElement::layout):
1767         (WebCore::RenderFormElement::textAlignment):
1768         * rendering/RenderFormElement.h:
1769         * rendering/RenderFrame.cpp:
1770         * rendering/RenderFrame.h:
1771         (WebCore::RenderFrame::element):
1772         * rendering/RenderFrameSet.cpp:
1773         * rendering/RenderFrameSet.h:
1774         (WebCore::RenderFrameSet::element):
1775         * rendering/RenderHTMLCanvas.cpp:
1776         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1777         (WebCore::RenderHTMLCanvas::paint):
1778         * rendering/RenderHTMLCanvas.h:
1779         (WebCore::RenderHTMLCanvas::renderName):
1780         * rendering/RenderImage.cpp:
1781         (WebCore::RenderImage::RenderImage):
1782         (WebCore::RenderImage::setStyle):
1783         (WebCore::RenderImage::setContentObject):
1784         (WebCore::RenderImage::setCachedImage):
1785         (WebCore::RenderImage::imageChanged):
1786         (WebCore::RenderImage::paint):
1787         (WebCore::RenderImage::layout):
1788         (WebCore::RenderImage::updateAltText):
1789         * rendering/RenderImage.h:
1790         (WebCore::RenderImage::element):
1791         * rendering/RenderInline.cpp:
1792         (WebCore::RenderInline::RenderInline):
1793         (WebCore::RenderInline::~RenderInline):
1794         (WebCore::RenderInline::setStyle):
1795         (WebCore::RenderInline::addChildToFlow):
1796         (WebCore::RenderInline::cloneInline):
1797         (WebCore::RenderInline::splitInlines):
1798         (WebCore::RenderInline::splitFlow):
1799         (WebCore::RenderInline::paint):
1800         (WebCore::RenderInline::absoluteRects):
1801         (WebCore::RenderInline::calcMinMaxWidth):
1802         (WebCore::RenderInline::requiresLayer):
1803         (WebCore::RenderInline::width):
1804         (WebCore::RenderInline::height):
1805         (WebCore::RenderInline::renderName):
1806         (WebCore::RenderInline::nodeAtPoint):
1807         (WebCore::RenderInline::positionForCoordinates):
1808         * rendering/RenderInline.h:
1809         (WebCore::RenderInline::layout):
1810         * rendering/RenderLayer.cpp:
1811         * rendering/RenderLayer.h:
1812         (WebCore::ClipRects::ClipRects):
1813         (WebCore::RenderLayer::nextSibling):
1814         (WebCore::RenderLayer::root):
1815         (WebCore::RenderLayer::setPos):
1816         (WebCore::RenderLayer::height):
1817         (WebCore::RenderLayer::relativePositionOffset):
1818         * rendering/RenderLineEdit.cpp:
1819         (WebCore::RenderLineEdit::setStyle):
1820         (WebCore::RenderLineEdit::updateFromElement):
1821         (WebCore::RenderLineEdit::selectionStart):
1822         (WebCore::RenderLineEdit::selectionEnd):
1823         (WebCore::RenderLineEdit::setSelectionStart):
1824         (WebCore::RenderLineEdit::setSelectionEnd):
1825         (WebCore::RenderLineEdit::setSelectionRange):
1826         * rendering/RenderLineEdit.h:
1827         * rendering/RenderListBox.cpp:
1828         * rendering/RenderListBox.h:
1829         (WebCore::RenderListBox::renderName):
1830         * rendering/RenderListItem.cpp:
1831         (WebCore::RenderListItem::setStyle):
1832         (WebCore::getParentOfFirstLineBox):
1833         (WebCore::RenderListItem::updateMarkerLocation):
1834         (WebCore::RenderListItem::positionListMarker):
1835         (WebCore::RenderListItem::paint):
1836         * rendering/RenderListItem.h:
1837         * rendering/RenderListMarker.cpp:
1838         * rendering/RenderListMarker.h:
1839         (WebCore::RenderListMarker::renderName):
1840         (WebCore::RenderListMarker::isListMarker):
1841
1842 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1843
1844         Reviewed by Hyatt.
1845
1846         <rdar://problem/4478625> Basic table editing and culling
1847
1848         Refined the criteria for deletable elements, rely on the renderer more.
1849         Corrected the interface positioning for elements that have borders.
1850
1851         * editing/DeleteButtonController.cpp:
1852         (WebCore::isDeletableElement):
1853         (WebCore::DeleteButtonController::show):
1854
1855 2006-10-30  Darin Adler  <darin@apple.com>
1856
1857         - fix build
1858
1859         * loader/ResourceLoader.h: Added header guard.
1860
1861 2006-10-31  Darin Adler  <darin@apple.com>
1862
1863         Reviewed by Adam.
1864
1865         - fix FrameLoader files so they can be built on non-Mac platforms
1866
1867         * page/FramePrivate.h:
1868         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1869         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1870
1871         * page/Page.h:
1872         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1873         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1874         the other day.
1875
1876         * bridge/mac/FrameMac.mm:
1877         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1878         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1879
1880         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1881         around the PolicyCheck definition.
1882
1883         * loader/FormState.cpp: Changed import to include.
1884         * loader/FrameLoader.cpp: Ditto.
1885         * loader/MainResourceLoader.h: Ditto.
1886
1887         * loader/FrameLoaderTypes.h: Added a header guard.
1888
1889         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1890         Added #if PLATFORM(MAC) around Mac-specific details.
1891         * loader/SubresourceLoader.h: Ditto.
1892
1893         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1894         m_loader from m_frameLoader.
1895
1896         * CMakeLists.txt: Updated.
1897         * WebCoreSources.bkl: Updated.
1898
1899 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1900
1901         Reviewed and landed by Anders.
1902
1903         Patch by Zack rusin to fix: 
1904         http://bugs.webkit.org/show_bug.cgi?id=11429
1905
1906         Fix startup crash.
1907
1908         * platform/qt/FrameQtClient.cpp:
1909         (WebCore::FrameQtClientDefault::openURL):
1910
1911 2006-10-30  Zach Rusin  <zack@kde.org>
1912
1913         Reviewed and landed by Anders.
1914
1915         * platform/network/qt/ResourceHandleQt.cpp:
1916         (WebCore::ResourceHandle::receivedResponse):
1917         * platform/qt/FrameQtClient.cpp:
1918         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1919         * platform/qt/LoaderFunctionsQt.cpp:
1920         (WebCore::ServeSynchronousRequest):
1921         More build fixes.
1922
1923 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1924
1925         Reviewed and landed by Anders.
1926         
1927         - fix Qt build
1928         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1929         ResourceHandleClient
1930
1931 2006-10-30  Darin Adler  <darin@apple.com>
1932
1933         Reviewed by John Sullivan.
1934
1935         - work toward removing Objective-C data types from FrameLoader.h:
1936           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1937           and WebCoreResourceHandle
1938         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1939
1940         * page/PageState.h:
1941         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1942
1943         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1944         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1945         double for the date instead of an NSDate.
1946
1947         * bridge/mac/WebCoreFrameBridge.h:
1948         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1949         saveDocumentToPageCache methods.
1950
1951         * bridge/mac/WebCorePageState.h:
1952         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1953         an Objective-C wrapper for PageState.
1954
1955         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1956         NSDate and WebCorePageState.
1957         * loader/FrameLoaderClient.h: Changed NSDate to double.
1958         * loader/mac/FrameLoaderMac.mm:
1959         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1960         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1961         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1962         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1963         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1964         extract the parameters from the response. Changed the open function that takes
1965         a PageState to use the new C++ PageState.
1966         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1967         function; tightened up logic, removing a few cases that could never happen, as
1968         well as the unused reload boolean.
1969
1970         * ForwardingHeaders/kjs/property_map.h: Added.
1971
1972         * WebCore.exp: Updated.
1973         * WebCore.xcodeproj/project.pbxproj: Updated.
1974
1975 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1976
1977         Reviewed by Anders.
1978
1979         - added ResourceResponse class and didReceiveResponse delegate call
1980         
1981         * WebCore.xcodeproj/project.pbxproj: Added new files.
1982         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1983         expiresTimeForResponse: method.
1984         * dom/XMLTokenizer.cpp:
1985         (WebCore::openFunc): Updated to use ResourceResponse.
1986         * loader/FrameLoader.h: Update loadResourceSynchronously to
1987         use ResourceResponse.
1988         * loader/LoaderFunctions.h:
1989         * loader/icon/IconLoader.cpp:
1990         (IconLoader::didReceiveResponse): Updated from receivedResponse
1991         and made cross-platform.
1992         * loader/icon/IconLoader.h: updated for above change
1993         * loader/loader.cpp:
1994         (WebCore::Loader::receivedResponse): reduced to just saving
1995         the PlatformResponse (ideally we'd phase out use of this).
1996         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1997         logic.
1998         * loader/loader.h:
1999         * loader/mac/FrameLoaderMac.mm:
2000         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2001         as ResourceResponse.
2002         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2003         * loader/mac/LoaderFunctionsMac.mm:
2004         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2005         argument.
2006         * platform/network/ResourceHandle.cpp:
2007         * platform/network/ResourceHandle.h: Remove calls for
2008         broken out response pieces.
2009         * platform/network/ResourceHandleClient.h:
2010         (WebCore::ResourceHandleClient::didReceiveResponse): New
2011         delegate method.
2012         * platform/network/ResourceHandleInternal.h:
2013         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2014         storage of response bits, we're not gonna return them
2015         seprately any more.
2016         * platform/network/ResourceResponse.h: Added.
2017         (WebCore::ResourceResponse::ResourceResponse): Freshly
2018         implemented. Same for below.
2019         (WebCore::ResourceResponse::url):
2020         (WebCore::ResourceResponse::mimeType):
2021         (WebCore::ResourceResponse::expectedContentLength):
2022         (WebCore::ResourceResponse::textEncodingName):
2023         (WebCore::ResourceResponse::suggestedFilename):
2024         (WebCore::ResourceResponse::httpStatusCode):
2025         (WebCore::ResourceResponse::setHTTPStatusCode):
2026         (WebCore::ResourceResponse::httpHeaderField):
2027         (WebCore::ResourceResponse::httpHeaderFields):
2028         (WebCore::ResourceResponse::isMultipart):
2029         (WebCore::ResourceResponse::setExpirationDate):
2030         (WebCore::ResourceResponse::expirationDate):
2031         * platform/network/cf/ResourceHandleCFNet.cpp:
2032         (WebCore::didReceiveResponse): Send didReceiveResponse
2033         client method.
2034         * platform/network/cf/ResourceResponseCFNet.h: Added.
2035         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2036         (getResourceResponse): Helper function to get a ResourceResponse 
2037         from CFURLResponseRef.
2038         * platform/network/mac/ResourceHandleMac.mm:
2039         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2040         Don't bother cleaning up fields we no longer have.
2041         (WebCore::ResourceHandle::receivedResponse): Send
2042         didReceiveResponse client method.
2043         * platform/network/mac/ResourceResponseMac.h: Added.
2044         * platform/network/mac/ResourceResponseMac.mm: Added.
2045         (getResourceResponse): Helper function to get a ResourceResponse 
2046         from an NSURLResponse*.
2047         * rendering/HitTestResult.cpp:
2048         * xml/XSLTProcessor.cpp:
2049         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2050         * xml/xmlhttprequest.cpp:
2051         (WebCore::XMLHttpRequest::getResponseText): Store http response
2052         info in the form of a ResourceResponse, change all methods to
2053         account for this.
2054         (WebCore::XMLHttpRequest::getResponseXML):
2055         (WebCore::XMLHttpRequest::XMLHttpRequest):
2056         (WebCore::XMLHttpRequest::open):
2057         (WebCore::XMLHttpRequest::send):
2058         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2059         (WebCore::XMLHttpRequest::getResponseHeader):
2060         (WebCore::XMLHttpRequest::getStatus):
2061         (WebCore::XMLHttpRequest::getStatusText):
2062         (WebCore::XMLHttpRequest::processSyncLoadResults):
2063         (WebCore::XMLHttpRequest::didFinishLoading):
2064         (WebCore::XMLHttpRequest::didReceiveResponse):
2065         (WebCore::XMLHttpRequest::didReceiveData):
2066         * xml/xmlhttprequest.h:
2067
2068 2006-10-29  Darin Adler  <darin@apple.com>
2069
2070         - fix build
2071
2072         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2073         * loader/NetscapePlugInStreamLoader.h: Ditto.
2074         * loader/ResourceLoader.h: Ditto.
2075
2076 2006-10-29  Darin Adler  <darin@apple.com>
2077
2078         - one last name change -- WebFormState.h to FormState.h
2079         - added more empty placeholder platform-independent files
2080           for currently-Mac-specific loader classes
2081
2082         * loader/FormState.cpp: Updated include.
2083         * loader/FrameLoader.cpp: Updated include.
2084         * loader/mac/FrameLoaderMac.mm: Updated include.
2085
2086         * loader/WebFormState.h: Removed.
2087         * loader/FormState.h: Added.
2088
2089         * loader/DocumentLoader.cpp: Added.
2090         * loader/MainResourceLoader.cpp: Added.
2091         * loader/NetscapePlugInStreamLoader.cpp: Added.
2092         * loader/ResourceLoader.cpp: Added.
2093         * loader/SubresourceLoader.cpp: Added.
2094
2095         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2096
2097 2006-10-29  Darin Adler  <darin@apple.com>
2098
2099         - did the do-webcore-rename renames, including a number of changes
2100           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2101           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2102           and improvements to the names of decoder classes and their source
2103           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2104
2105         * CMakeLists.txt:
2106         * WebCore.exp:
2107         * WebCore.vcproj/WebCore/WebCore.vcproj:
2108         * WebCore.xcodeproj/project.pbxproj:
2109         * WebCoreSources.bkl:
2110         * bindings/js/kjs_binding.cpp:
2111         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2112         * bindings/js/kjs_events.cpp:
2113         (KJS::JSAbstractEventListener::handleEvent):
2114         (KJS::JSLazyEventListener::parseCode):
2115         * bindings/js/kjs_html.cpp:
2116         (KJS::JSHTMLElement::implementsCall):
2117         * bindings/js/kjs_traversal.cpp:
2118         (KJS::JSNodeFilterCondition::acceptNode):
2119         * bindings/js/kjs_window.cpp:
2120         (KJS::Window::interpreter):
2121         (KJS::Window::retrieveWindow):
2122         (KJS::Window::retrieve):
2123         (KJS::ScheduledAction::execute):
2124         * bindings/objc/DOMInternal.mm:
2125         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2126         * bridge/mac/FrameMac.mm:
2127         (WebCore::FrameMac::executionContextForDOM):
2128         (WebCore::FrameMac::bindingRootObject):
2129         (WebCore::FrameMac::windowScriptObject):
2130         (WebCore::FrameMac::windowScriptNPObject):
2131         (WebCore::FrameMac::partClearedInBegin):
2132         * bridge/mac/WebCoreEncodings.mm:
2133         * bridge/mac/WebCoreFrameBridge.mm:
2134         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2135         (-[WebCoreFrameBridge stringWithData:]):
2136         (-[WebCoreFrameBridge executionContextForView:]):
2137         * bridge/win/FrameWin.cpp:
2138         * dom/Document.cpp:
2139         (WebCore::Document::inputEncoding):
2140         (WebCore::Document::setCharset):
2141         (WebCore::Document::createHTMLEventListener):
2142         (WebCore::Document::setDecoder):
2143         * dom/Document.h:
2144         (WebCore::Document::decoder):
2145         * dom/EventTargetNode.cpp:
2146         (WebCore::EventTargetNode::dispatchGenericEvent):
2147         * html/HTMLParser.cpp:
2148         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2149         (WebCore::HTMLParser::canvasCreateErrorCheck):
2150         (WebCore::HTMLParser::isInline):
2151         * html/HTMLPlugInElement.cpp:
2152         (WebCore::HTMLPlugInElement::createNPObject):
2153         * html/HTMLScriptElement.cpp:
2154         (WebCore::HTMLScriptElement::evaluateScript):
2155         * html/HTMLTokenizer.cpp:
2156         (WebCore::HTMLTokenizer::parseTag):
2157         (WebCore::HTMLTokenizer::processToken):
2158         * ksvg2/misc/SVGDocumentExtensions.cpp:
2159         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2160         * loader/CachedCSSStyleSheet.cpp:
2161         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2162         (WebCore::CachedCSSStyleSheet::setEncoding):
2163         * loader/CachedCSSStyleSheet.h:
2164         * loader/CachedXBLDocument.cpp:
2165         (WebCore::CachedXBLDocument::CachedXBLDocument):
2166         (WebCore::CachedXBLDocument::setEncoding):
2167         * loader/CachedXBLDocument.h:
2168         * loader/CachedXSLStyleSheet.cpp:
2169         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2170         (WebCore::CachedXSLStyleSheet::setEncoding):
2171         * loader/CachedXSLStyleSheet.h:
2172         * loader/Decoder.cpp: Removed.
2173         * loader/Decoder.h: Removed.
2174         * loader/FrameLoader.cpp:
2175         * loader/FrameLoader.h:
2176         * loader/FrameLoaderClient.h:
2177         * loader/MainResourceLoader.h: Added.
2178         * loader/NetscapePlugInStreamLoader.h: Added.
2179         * loader/Request.h:
2180         (WebCore::Request::cachedResource):
2181         * loader/ResourceLoader.h: Added.
2182         * loader/SubresourceLoader.h: Added.
2183         * loader/TextResourceDecoder.cpp: Added.
2184         (WebCore::TextResourceDecoder::determineContentType):
2185         (WebCore::TextResourceDecoder::defaultEncoding):
2186         (WebCore::TextResourceDecoder::TextResourceDecoder):
2187         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2188         (WebCore::TextResourceDecoder::setEncoding):
2189         (WebCore::TextResourceDecoder::checkForBOM):
2190         (WebCore::TextResourceDecoder::checkForCSSCharset):
2191         (WebCore::TextResourceDecoder::checkForHeadCharset):
2192         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2193         (WebCore::TextResourceDecoder::decode):
2194         (WebCore::TextResourceDecoder::flush):
2195         * loader/TextResourceDecoder.h: Added.
2196         * loader/WebDocumentLoader.h: Removed.
2197         * loader/WebLoader.h: Removed.
2198         * loader/WebMainResourceLoader.h: Removed.
2199         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2200         * loader/WebSubresourceLoader.h: Removed.
2201         * loader/loader.cpp:
2202         (WebCore::Loader::servePendingRequests):
2203         (WebCore::Loader::receivedAllData):
2204         (WebCore::Loader::receivedResponse):
2205         (WebCore::Loader::didReceiveData):
2206         (WebCore::Loader::cancelRequests):
2207         (WebCore::Loader::jobForRequest):
2208         * loader/mac/DocumentLoaderMac.mm:
2209         * loader/mac/FormDataStream.m: Added.
2210         * loader/mac/FrameLoaderMac.mm:
2211         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2212         (WebCore::FrameLoader::addPlugInStreamLoader):
2213         (WebCore::FrameLoader::removePlugInStreamLoader):
2214         (WebCore::FrameLoader::addSubresourceLoader):
2215         (WebCore::FrameLoader::removeSubresourceLoader):
2216         (WebCore::FrameLoader::willSendRequest):
2217         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2218         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2219         (WebCore::FrameLoader::didReceiveResponse):
2220         (WebCore::FrameLoader::didReceiveData):
2221         (WebCore::FrameLoader::didFinishLoad):
2222         (WebCore::FrameLoader::didFailToLoad):
2223         (WebCore::FrameLoader::open):
2224         (WebCore::FrameLoader::willUseArchive):
2225         (WebCore::FrameLoader::isArchiveLoadPending):
2226         * loader/mac/ImageDocumentMac.mm:
2227         * loader/mac/LoaderFunctionsMac.mm:
2228         (WebCore::CheckCacheObjectStatus):
2229         * loader/mac/MainResourceLoaderMac.mm:
2230         (WebCore::MainResourceLoader::MainResourceLoader):
2231         (WebCore::MainResourceLoader::releaseDelegate):
2232         (WebCore::MainResourceLoader::didCancel):
2233         (WebCore::MainResourceLoader::addData):
2234         (WebCore::MainResourceLoader::willSendRequest):
2235         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2236         (WebCore::MainResourceLoader::didReceiveData):
2237         (WebCore::MainResourceLoader::didFinishLoading):
2238         (WebCore::MainResourceLoader::setDefersLoading):
2239         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2240         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2241         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2242         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2243         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2244         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2245         (WebCore::NetscapePlugInStreamLoader::didFail):
2246         (WebCore::NetscapePlugInStreamLoader::didCancel):
2247         * loader/mac/ResourceLoaderMac.mm:
2248         (WebCore::ResourceLoader::ResourceLoader):
2249         (WebCore::ResourceLoader::~ResourceLoader):
2250         (WebCore::ResourceLoader::releaseResources):
2251         (WebCore::ResourceLoader::load):
2252         (WebCore::ResourceLoader::setDefersLoading):
2253         (WebCore::ResourceLoader::frameLoader):
2254         (WebCore::ResourceLoader::addData):
2255         (WebCore::ResourceLoader::resourceData):
2256         (WebCore::ResourceLoader::clearResourceData):
2257         (WebCore::ResourceLoader::willSendRequest):
2258         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2259         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2260         (WebCore::ResourceLoader::didReceiveResponse):
2261         (WebCore::ResourceLoader::didReceiveData):
2262         (WebCore::ResourceLoader::willStopBufferingData):
2263         (WebCore::ResourceLoader::didFinishLoading):
2264         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2265         (WebCore::ResourceLoader::didFail):
2266         (WebCore::ResourceLoader::willCacheResponse):
2267         (WebCore::ResourceLoader::didCancel):
2268         (WebCore::ResourceLoader::cancel):
2269         (WebCore::ResourceLoader::setIdentifier):
2270         (WebCore::ResourceLoader::response):
2271         (WebCore::ResourceLoader::inConnectionCallback):
2272         (WebCore::ResourceLoader::cancelledError):
2273         (WebCore::ResourceLoader::receivedCredential):
2274         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2275         (WebCore::ResourceLoader::receivedCancellation):
2276         (WebCore::ResourceLoader::delegate):
2277         (WebCore::ResourceLoader::releaseDelegate):
2278         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2279         * loader/mac/SubresourceLoaderMac.mm:
2280         (WebCore::SubresourceLoader::SubresourceLoader):
2281         (WebCore::SubresourceLoader::willSendRequest):
2282         (WebCore::SubresourceLoader::didReceiveResponse):
2283         (WebCore::SubresourceLoader::didReceiveData):
2284         (WebCore::SubresourceLoader::didFinishLoading):
2285         (WebCore::SubresourceLoader::didFail):
2286         (WebCore::SubresourceLoader::didCancel):
2287         * loader/mac/WebFormDataStream.h: Removed.
2288         * loader/mac/WebFormDataStream.m: Removed.
2289         * page/Frame.cpp:
2290         (WebCore::Frame::javaScriptEnabled):
2291         (WebCore::Frame::scriptProxy):
2292         (WebCore::Frame::executeScript):
2293         (WebCore::Frame::write):
2294         (WebCore::Frame::userGestureHint):
2295         (WebCore::Frame::saveInterpreterBuiltins):
2296         (WebCore::Frame::restoreInterpreterBuiltins):
2297         (WebCore::Frame::backslashAsCurrencySymbol):
2298         * page/Frame.h:
2299         * page/FramePrivate.h:
2300         * platform/StreamingTextDecoder.cpp: Removed.
2301         * platform/StreamingTextDecoder.h: Removed.
2302         * platform/StreamingTextDecoderICU.cpp: Removed.
2303         * platform/StreamingTextDecoderICU.h: Removed.
2304         * platform/TextCodec.cpp: Added.
2305         * platform/TextCodec.h: Added.
2306         * platform/TextCodecICU.cpp: Added.
2307         * platform/TextCodecICU.h: Added.
2308         * platform/TextCodecLatin1.h:
2309         * platform/TextCodecUTF16.h:
2310         * platform/TextDecoder.h:
2311         * platform/TextEncoding.cpp:
2312         * platform/TextEncodingRegistry.cpp:
2313         * platform/image-decoders/jpeg/jmorecfg.h:
2314         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2315         * platform/mac/StreamingTextDecoderMac.h: Removed.
2316         * platform/mac/TextCodecMac.cpp: Added.
2317         * platform/mac/TextCodecMac.h: Added.
2318         * platform/network/ResourceHandleInternal.h:
2319         * platform/network/mac/ResourceHandleMac.mm:
2320         * platform/qt/FrameQt.cpp:
2321         (WebCore::FrameQt::bindingRootObject):
2322         * platform/qt/LoaderFunctionsQt.cpp:
2323         (WebCore::CheckCacheObjectStatus):
2324         * rendering/RenderObject.cpp:
2325         (WebCore::RenderObject::backslashAsCurrencySymbol):
2326         * xml/XSLTProcessor.cpp:
2327         (WebCore::XSLTProcessor::createDocumentFromSource):
2328         * xml/xmlhttprequest.cpp:
2329         (WebCore::XMLHttpRequest::didReceiveData):
2330         * xml/xmlhttprequest.h:
2331
2332 2006-10-29  Darin Adler  <darin@apple.com>
2333
2334         Rubber stamped by Adam (kinda).
2335
2336         - add Mac suffixes and correct filenames inside loader/mac
2337
2338         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2339
2340         * loader/mac/FrameLoader.mm: Removed.
2341         * loader/mac/WebDocumentLoader.mm: Removed.
2342         * loader/mac/WebLoader.mm: Removed.
2343         * loader/mac/WebMainResourceLoader.mm: Removed.
2344         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2345         * loader/mac/WebSubresourceLoader.mm: Removed.
2346
2347         * loader/mac/FrameLoaderMac.mm: Added.
2348         * loader/mac/DocumentLoaderMac.mm: Added.
2349         * loader/mac/ResourceLoaderMac.mm: Added.
2350         * loader/mac/MainResourceLoaderMac.mm: Added.
2351         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2352         * loader/mac/SubresourceLoaderMac.mm: Removed.
2353
2354 2006-10-29  Darin Adler  <darin@apple.com>
2355
2356         Reviewed by Adam.
2357
2358         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2359           and FrameLoader.cpp mostly ready
2360
2361         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2362         FormState.cpp. Removed WebFormState.mm.
2363
2364         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2365         get this header compiling on non-Mac.
2366         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2367         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2368
2369         * loader/FrameLoaderClient.h: Added some ifdefs.
2370         * loader/WebDocumentLoader.h: Ditto.
2371         * loader/WebLoader.h: Ditto.
2372         * loader/WebMainResourceLoader.h: Ditto.
2373
2374         * loader/mac/WebDocumentLoader.mm:
2375         (WebCore::DocumentLoader::isLoadingInAPISense):
2376         Rewrote to work without bridge, partly to remove the need for ObjC
2377         bridge type in the header, and also because we're tearing down the bridge.
2378
2379         * loader/mac/WebMainResourceLoader.mm:
2380         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2381         m_contentLength and m_bytesReceived.
2382         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2383         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2384
2385         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2386         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2387
2388         * loader/mac/FormState.mm: Removed.
2389         * loader/FormState.cpp: Added.
2390
2391 2006-10-29  Darin Adler  <darin@apple.com>
2392
2393         Rubber stamped by Adam.
2394
2395         - moving towards use of FrameLoader cross-platform; move the headers
2396           for the Mac loader from loader/mac into loader, in preparation for
2397           making them useful on non-Mac
2398
2399         * WebCore.xcodeproj/project.pbxproj:
2400
2401         * loader/mac/FrameLoader.h: Removed.
2402         * loader/mac/WebDocumentLoader.h: Removed.
2403         * loader/mac/WebFormState.h: Removed.
2404         * loader/mac/WebLoader.h: Removed.
2405         * loader/mac/WebMainResourceLoader.h: Removed.
2406         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2407         * loader/mac/WebSubresourceLoader.h: Removed.
2408
2409         * loader/FrameLoader.h: Added.
2410         * loader/WebDocumentLoader.h: Added.
2411         * loader/WebFormState.h: Added.
2412         * loader/WebLoader.h: Added.
2413         * loader/WebMainResourceLoader.h: Added.
2414         * loader/WebNetscapePlugInStreamLoader.h: Added.
2415         * loader/WebSubresourceLoader.h: Added.
2416
2417 2006-10-29  Adam Roben  <aroben@apple.com>
2418
2419         Reviewed by Geoff.
2420
2421         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2422         r17405.
2423
2424         * platform/DeprecatedString.h:
2425
2426 2006-10-29  Beth Dakin  <bdakin@apple.com>
2427
2428         Rubber stamped by Geoff.
2429
2430         This is a followup to my HitTestResult checkin. Most of the 
2431         HitTestResult local variables in the code were named i or info for 
2432         when the class was named NodeInfo. This patch renames all of these 
2433         local variables to result.
2434
2435         * dom/Document.cpp:
2436         (WebCore::Document::prepareMouseEvent):
2437         * html/HTMLAreaElement.cpp:
2438         (WebCore::HTMLAreaElement::mapMouseEvent):
2439         * html/HTMLMapElement.cpp:
2440         (WebCore::HTMLMapElement::mapMouseEvent):
2441         * rendering/EllipsisBox.cpp:
2442         (WebCore::EllipsisBox::nodeAtPoint):
2443         * rendering/EllipsisBox.h:
2444         * rendering/InlineBox.cpp:
2445         (WebCore::InlineBox::nodeAtPoint):
2446         * rendering/InlineFlowBox.cpp:
2447         (WebCore::InlineFlowBox::nodeAtPoint):
2448         * rendering/InlineTextBox.cpp:
2449         (WebCore::InlineTextBox::nodeAtPoint):
2450         * rendering/RenderBlock.cpp:
2451         (WebCore::RenderBlock::isPointInScrollbar):
2452         (WebCore::RenderBlock::nodeAtPoint):
2453         * rendering/RenderBlock.h:
2454         * rendering/RenderBox.cpp:
2455         (WebCore::RenderBox::nodeAtPoint):
2456         * rendering/RenderBox.h:
2457         * rendering/RenderFlow.cpp:
2458         (WebCore::RenderFlow::hitTestLines):
2459         * rendering/RenderFlow.h:
2460         * rendering/RenderForeignObject.cpp:
2461         (WebCore::RenderForeignObject::nodeAtPoint):
2462         * rendering/RenderFrameSet.cpp:
2463         (WebCore::RenderFrameSet::nodeAtPoint):
2464         * rendering/RenderImage.cpp:
2465         (WebCore::RenderImage::nodeAtPoint):
2466         * rendering/RenderInline.cpp:
2467         (WebCore::RenderInline::nodeAtPoint):
2468         * rendering/RenderInline.h:
2469         * rendering/RenderLayer.cpp:
2470         (WebCore::RenderLayer::autoscroll):
2471         (WebCore::RenderLayer::hitTest):
2472         (WebCore::RenderLayer::hitTestLayer):
2473         (WebCore::RenderLayer::updateHoverActiveState):
2474         * rendering/RenderListBox.cpp:
2475         (WebCore::RenderListBox::isPointInScrollbar):
2476         * rendering/RenderObject.cpp:
2477         (WebCore::RenderObject::hitTest):
2478         (WebCore::RenderObject::setInnerNode):
2479         (WebCore::RenderObject::nodeAtPoint):
2480         * rendering/RenderObject.h:
2481         * rendering/RenderPath.cpp:
2482         (WebCore::RenderPath::nodeAtPoint):
2483         * rendering/RenderSVGImage.cpp:
2484         (WebCore::RenderSVGImage::nodeAtPoint):
2485         * rendering/RenderSVGText.cpp:
2486         (WebCore::RenderSVGText::nodeAtPoint):
2487         * rendering/RenderTableRow.cpp:
2488         (WebCore::RenderTableRow::nodeAtPoint):
2489         * rendering/RenderTableRow.h:
2490         * rendering/RenderTableSection.cpp:
2491         (WebCore::RenderTableSection::nodeAtPoint):
2492         * rendering/RenderTableSection.h:
2493         * rendering/RenderTextControl.cpp:
2494         (WebCore::RenderTextControl::nodeAtPoint):
2495         * rendering/RootInlineBox.cpp:
2496         (WebCore::RootInlineBox::nodeAtPoint):
2497         * rendering/RootInlineBox.h:
2498
2499 2006-10-29  Adam Roben  <aroben@apple.com>
2500
2501         More semi-fixes.
2502
2503         * page/Page.cpp: Forgot to wrap the actual definition of
2504         setDefersLoading() in PLATFORM(MAC).
2505         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2506
2507 2006-10-29  Adam Roben  <aroben@apple.com>
2508
2509         Build semi-fix.
2510
2511         Move all FrameLoader-related code in Page.{cpp,h} within #if
2512         PLATFORM(MAC), since this class currently only exists on Mac.
2513
2514         * page/Page.cpp:
2515         * page/Page.h:
2516
2517 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2518
2519         build fix.
2520         
2521         * platform/PlatformString.h:
2522         (WebCore::String::operator NSString*):
2523
2524 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2525
2526         Rolled out accidental commit.
2527         
2528         * platform/AtomicString.h:
2529         (WebCore::AtomicString::AtomicString):
2530         (WebCore::AtomicString::operator NSString*):
2531
2532 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2533
2534         RS by Darin.
2535
2536         Rolled out change to map NULL Strings to nil NSStrings because it caused
2537         even more AppKit crashes. Maybe we should remove the NSString * operator
2538         entirely, since its use is not straight-forward, and require callers to
2539         specify explicitly whether they tolerate NULL.
2540         
2541         * platform/AtomicString.h:
2542         * platform/PlatformString.h:
2543         (WebCore::String::operator NSString*):
2544         * platform/mac/TextFieldMac.mm:
2545         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2546
2547 2006-10-29  Darin Adler  <darin@apple.com>
2548
2549         Reviewed by Geoff.
2550
2551         - fixed storage leak showing up on the buildbot
2552
2553         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2554         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2555
2556 2006-10-29  Darin Adler  <darin@apple.com>
2557
2558         Rubber stamped by Adam.
2559
2560         - renamed WebFrameLoaderClient to match the class name inside it
2561
2562         * loader/mac/WebFrameLoaderClient.h: Removed.
2563         * loader/FrameLoaderClient.h: Moved it here.
2564
2565         * WebCore.xcodeproj/project.pbxproj: Updated project.
2566
2567         * bridge/mac/FrameMac.mm: Updated includes.
2568         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2569         * loader/mac/FrameLoader.mm: Ditto.
2570         * loader/mac/WebLoader.h: Ditto.
2571
2572 2006-10-29  Darin Adler  <darin@apple.com>
2573
2574         Reviewed by Mitz.
2575
2576         - fix crash visible on buildbot and also when running the test
2577           anchor-image-scrolled-x-y.html under libgmalloc
2578
2579         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2580         now that the class is named ResourceHandle.
2581         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2582         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2583         a local RefPtr before calling finishJobAndHandle, since we might get
2584         cancelled inside that function, so we should not rely on m_handle to
2585         keep the ResourceHandle alive.
2586         (WebCore::SubresourceLoader::didFail): Ditto.
2587         (WebCore::SubresourceLoader::didCancel): Ditto.
2588
2589 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2590
2591         - build fix
2592
2593         * platform/network/mac/ResourceHandleMac.mm:
2594
2595 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2596
2597         Rubber stamped by Darin.
2598
2599         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2600
2601         * CMakeLists.txt:
2602         * Projects/gdk/webcore-gdk.bkl:
2603         * WebCore.vcproj/WebCore/WebCore.vcproj:
2604         * WebCore.xcodeproj/project.pbxproj:
2605         * WebCoreSources.bkl:
2606         * bridge/mac/FrameMac.mm:
2607         * bridge/win/FrameWin.cpp:
2608         * dom/XMLTokenizer.cpp:
2609         * loader/Cache.cpp:
2610         * loader/CachedResource.h:
2611         * loader/LoaderFunctions.h:
2612         * loader/icon/IconLoader.cpp:
2613         (IconLoader::startLoading):
2614         (IconLoader::didReceiveData):
2615         (IconLoader::didFinishLoading):
2616         * loader/icon/IconLoader.h:
2617         * loader/loader.cpp:
2618         (WebCore::Loader::servePendingRequests):
2619         (WebCore::Loader::receivedAllData):
2620         (WebCore::Loader::receivedResponse):
2621         (WebCore::Loader::didReceiveData):
2622         (WebCore::Loader::cancelRequests):
2623         (WebCore::Loader::jobForRequest):
2624         * loader/loader.h:
2625         * loader/mac/IconLoaderMac.mm:
2626         (IconLoader::receivedResponse):
2627         * loader/mac/LoaderFunctionsMac.mm:
2628         * loader/mac/WebLoader.h:
2629         * loader/mac/WebSubresourceLoader.h:
2630         * loader/mac/WebSubresourceLoader.mm:
2631         (WebCore::SubresourceLoader::SubresourceLoader):
2632         (WebCore::SubresourceLoader::create):
2633         * platform/gdk/FrameGdk.cpp:
2634         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2635         (WebCore::FrameGdkClientDefault::openURL):
2636         (WebCore::FrameGdkClientDefault::submitForm):
2637         (WebCore::FrameGdkClientDefault::receivedResponse):
2638         (WebCore::FrameGdkClientDefault::didReceiveData):
2639         (WebCore::FrameGdkClientDefault::receivedAllData):
2640         * platform/gdk/FrameGdk.h:
2641         * platform/gdk/TemporaryLinkStubs.cpp:
2642         (WebCore::ServeSynchronousRequest):
2643         (WebCore::ResourceHandle::assembleResponseHeaders):
2644         (WebCore::ResourceHandle::retrieveCharset):
2645         * platform/network/ResourceHandle.cpp: Added.
2646         (WebCore::ResourceHandle::ResourceHandle):
2647         (WebCore::ResourceHandle::create):
2648         (WebCore::ResourceHandle::isErrorPage):
2649         (WebCore::ResourceHandle::error):
2650         (WebCore::ResourceHandle::setError):
2651         (WebCore::ResourceHandle::responseEncoding):
2652         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2653         (WebCore::ResourceHandle::kill):
2654         (WebCore::ResourceHandle::requestHeaders):
2655         (WebCore::ResourceHandle::url):
2656         (WebCore::ResourceHandle::postData):
2657         (WebCore::ResourceHandle::method):
2658         (WebCore::ResourceHandle::client):
2659         * platform/network/ResourceHandle.h: Added.
2660         (WebCore::ResourceHandle::getInternal):
2661         * platform/network/ResourceHandleClient.h: Added.
2662         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2663         (WebCore::ResourceHandleClient::didReceiveData):
2664         (WebCore::ResourceHandleClient::didFinishLoading):
2665         (WebCore::ResourceHandleClient::receivedRedirect):
2666         (WebCore::ResourceHandleClient::receivedResponse):
2667         (WebCore::ResourceHandleClient::receivedAllData):
2668         * platform/network/ResourceHandleInternal.h: Added.
2669         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2670         * platform/network/ResourceLoader.cpp: Removed.
2671         * platform/network/ResourceLoader.h: Removed.
2672         * platform/network/ResourceLoaderClient.h: Removed.
2673         * platform/network/ResourceLoaderInternal.h: Removed.
2674         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2675         (WebCore::willSendRequest):
2676         (WebCore::didReceiveResponse):
2677         (WebCore::didReceiveData):
2678         (WebCore::didFinishLoading):
2679         (WebCore::didFail):
2680         (WebCore::willCacheResponse):
2681         (WebCore::didReceiveChallenge):
2682         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2683         (WebCore::ResourceHandle::~ResourceHandle):
2684         (WebCore::ResourceHandle::start):
2685         (WebCore::ResourceHandle::cancel):
2686         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2687         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2688         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2689         (WebCore::ResourceHandle::~ResourceHandle):
2690         (WebCore::ResourceHandle::start):
2691         (WebCore::ResourceHandle::cancel):
2692         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2693         (WebCore::ResourceHandleManager::ResourceHandleManager):
2694         (WebCore::ResourceHandleManager::get):
2695         (WebCore::ResourceHandleManager::useSimpleTransfer):
2696         (WebCore::writeCallback):
2697         (WebCore::ResourceHandleManager::downloadTimerCallback):
2698         (WebCore::ResourceHandleManager::remove):
2699         (WebCore::ResourceHandleManager::add):
2700         (WebCore::ResourceHandleManager::cancel):
2701         * platform/network/gdk/ResourceHandleManager.h: Added.
2702         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2703         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2704         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2705         * platform/network/mac/ResourceHandleMac.mm: Added.
2706         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2707         (WebCore::ResourceHandle::~ResourceHandle):
2708         (WebCore::ResourceHandle::start):
2709         (WebCore::ResourceHandle::assembleResponseHeaders):
2710         (WebCore::ResourceHandle::retrieveResponseEncoding):
2711         (WebCore::ResourceHandle::receivedResponse):
2712         (WebCore::ResourceHandle::cancel):
2713         (WebCore::ResourceHandle::redirectedToURL):
2714         (WebCore::ResourceHandle::addData):
2715         (WebCore::ResourceHandle::finishJobAndHandle):
2716         (WebCore::ResourceHandle::reportError):
2717         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2718         * platform/network/qt/ResourceHandleManager.cpp: Added.
2719         (WebCore::ResourceHandleManager::ResourceHandleManager):
2720         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2721         (WebCore::ResourceHandleManager::self):
2722         (WebCore::ResourceHandleManager::slotData):
2723         (WebCore::ResourceHandleManager::slotMimetype):
2724         (WebCore::ResourceHandleManager::slotResult):
2725         (WebCore::ResourceHandleManager::remove):
2726         (WebCore::ResourceHandleManager::add):
2727         (WebCore::ResourceHandleManager::cancel):
2728         * platform/network/qt/ResourceHandleManager.h: Added.
2729         * platform/network/qt/ResourceHandleQt.cpp: Added.
2730         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2731         (WebCore::ResourceHandle::~ResourceHandle):
2732         (WebCore::ResourceHandle::start):
2733         (WebCore::ResourceHandle::cancel):
2734         (WebCore::ResourceHandle::assembleResponseHeaders):
2735         (WebCore::ResourceHandle::retrieveResponseEncoding):
2736         (WebCore::ResourceHandle::receivedResponse):
2737         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2738         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2739         * platform/network/qt/ResourceLoaderManager.h: Removed.
2740         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2741         * platform/network/win/ResourceHandleWin.cpp: Added.
2742         (WebCore::):
2743         (WebCore::addToOutstandingJobs):
2744         (WebCore::lookupResourceHandle):
2745         (WebCore::ResourceHandleWndProc):
2746         (WebCore::initializeOffScreenResourceHandleWindow):
2747         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2748         (WebCore::ResourceHandle::~ResourceHandle):
2749         (WebCore::ResourceHandle::onHandleCreated):
2750         (WebCore::ResourceHandle::onRequestRedirected):
2751         (WebCore::ResourceHandle::onRequestComplete):
2752         (WebCore::ResourceHandle::start):
2753         (WebCore::ResourceHandle::fileLoadTimer):
2754         (WebCore::ResourceHandle::cancel):
2755         (WebCore::ResourceHandle::setHasReceivedResponse):
2756         (WebCore::ResourceHandle::hasReceivedResponse):
2757         * platform/network/win/ResourceHandleWin.h: Added.
2758         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2759         * platform/network/win/ResourceLoaderWin.h: Removed.
2760         * platform/qt/FrameQt.cpp:
2761         * platform/qt/FrameQtClient.cpp:
2762         (WebCore::FrameQtClientDefault::openURL):
2763         (WebCore::FrameQtClientDefault::submitForm):
2764         (WebCore::FrameQtClientDefault::receivedResponse):
2765         (WebCore::FrameQtClientDefault::didReceiveData):
2766         (WebCore::FrameQtClientDefault::receivedAllData):
2767         * platform/qt/FrameQtClient.h:
2768         * platform/win/TemporaryLinkStubs.cpp:
2769         (WebCore::ResourceHandle::assembleResponseHeaders):
2770         (WebCore::ResourceHandle::retrieveResponseEncoding):
2771         (WebCore::ServeSynchronousRequest):
2772         * xml/XSLTProcessor.cpp:
2773         * xml/xmlhttprequest.cpp:
2774         (WebCore::XMLHttpRequest::send):
2775         (WebCore::XMLHttpRequest::didFinishLoading):
2776         (WebCore::XMLHttpRequest::receivedRedirect):
2777         (WebCore::XMLHttpRequest::didReceiveData):
2778         * xml/xmlhttprequest.h:
2779
2780 t2006-10-29  Darin Adler  <darin@apple.com>
2781
2782         Reviewed by Maciej.
2783
2784         - eliminate use of NSArray to carry form data around
2785
2786         * WebCore.exp:
2787         * WebCore.xcodeproj/project.pbxproj:
2788         * bridge/mac/FormDataMac.h: Removed.
2789         * bridge/mac/FormDataMac.mm: Removed.
2790         * bridge/mac/FrameMac.h:
2791         * bridge/mac/WebCoreFrameBridge.h:
2792         * bridge/mac/WebCoreFrameBridge.mm:
2793         * html/HTMLFormElement.cpp:
2794         (WebCore::HTMLFormElement::submit):
2795         * loader/FormData.h:
2796         (WebCore::FormData::isEmpty):
2797         * loader/mac/FrameLoader.h:
2798         * loader/mac/FrameLoader.mm:
2799         (WebCore::FrameLoader::load):
2800         (WebCore::FrameLoader::post):
2801         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2802         (WebCore::FrameLoader::loadResourceSynchronously):
2803         * loader/mac/LoaderFunctionsMac.mm:
2804         (WebCore::ServeSynchronousRequest):
2805         * loader/mac/WebFormDataStream.h:
2806         * loader/mac/WebFormDataStream.m:
2807         (WebCore::pairRetain):
2808         (WebCore::pairRelease):
2809         (WebCore::pairEqual):
2810         (WebCore::pairHash):
2811         (WebCore::closeCurrentStream):
2812         (WebCore::scheduleWithPair):
2813         (WebCore::advanceCurrentStream):
2814         (WebCore::openNextStream):
2815         (WebCore::formCreate):
2816         (WebCore::formFinalize):
2817         (WebCore::formOpen):
2818         (WebCore::formRead):
2819         (WebCore::formCanRead):
2820         (WebCore::formClose):
2821         (WebCore::formSchedule):
2822         (WebCore::formUnschedule):
2823         (WebCore::formEventCallback):
2824         (WebCore::setHTTPBody):
2825         * loader/mac/WebSubresourceLoader.h:
2826         * loader/mac/WebSubresourceLoader.mm:
2827         (WebCore::SubresourceLoader::create):
2828         * platform/network/mac/ResourceLoaderMac.mm:
2829
2830 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2831
2832         Reviewed by Darin.
2833
2834         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2835
2836         * loader/mac/WebSubresourceLoader.h:
2837         * loader/mac/WebSubresourceLoader.mm:
2838         (WebCore::SubresourceLoader::create):
2839         * platform/network/mac/ResourceLoaderMac.mm:
2840         (WebCore::ResourceLoader::start):
2841
2842 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2843
2844         Reviewed by Darin.
2845
2846         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2847
2848         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2849         
2850         * WebCore.xcodeproj/project.pbxproj:
2851         * bridge/mac/WebCoreFrameBridge.h:
2852         * loader/mac/FrameLoader.h:
2853         * loader/mac/FrameLoader.mm:
2854         * loader/mac/LoaderFunctionsMac.mm:
2855         * loader/mac/WebLoader.h:
2856         * loader/mac/WebSubresourceLoader.h:
2857         * loader/mac/WebSubresourceLoader.mm:
2858         (WebCore::SubresourceLoader::SubresourceLoader):
2859         (WebCore::SubresourceLoader::create):
2860         (WebCore::SubresourceLoader::willSendRequest):
2861         (WebCore::SubresourceLoader::didReceiveResponse):
2862         (WebCore::SubresourceLoader::didReceiveData):
2863         (WebCore::SubresourceLoader::didFinishLoading):
2864         (WebCore::SubresourceLoader::didFail):
2865         (WebCore::SubresourceLoader::didCancel):
2866         * platform/network/ResourceLoader.h:
2867         * platform/network/ResourceLoaderInternal.h:
2868         * platform/network/mac/ResourceLoaderMac.mm:
2869         (WebCore::ResourceLoader::~ResourceLoader):
2870         (WebCore::ResourceLoader::start):
2871         (WebCore::ResourceLoader::receivedResponse):
2872         (WebCore::ResourceLoader::cancel):
2873         (WebCore::ResourceLoader::redirectedToURL):
2874         (WebCore::ResourceLoader::addData):
2875         (WebCore::ResourceLoader::finishJobAndHandle):
2876         (WebCore::ResourceLoader::reportError):
2877         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2878         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2879         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2880
2881 2006-10-28  Darin Adler  <darin@apple.com>
2882
2883         Reviewed by Maciej.
2884
2885         - eliminated the use of Objective-C for the policy decider
2886           machinery, obviating the need for WebPolicyDecider,
2887           WebCoreFrameLoaderAsDelegate, and
2888           WebCoreMainResourceLoaderAsPolicyDelegate
2889
2890         - grouped the state related to policy decisions into a PolicyCheck
2891           class to simplify the FrameLoader logic
2892
2893         - removed six methods from the bridge, reducing FrameLoader's use of
2894           the bridge to a single method
2895
2896         - changed form state to always use HashMap instead of NSDictionary
2897
2898         - moved the defersLoading flag from WebView to WebCore::Page
2899           and changed code to consistently call it defersLoading rather
2900           than defersCallbacks
2901
2902         - updated for rename of PassRefPtr::release to releaseRef
2903         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2904         - cleaned up kjs_binding.h a bit
2905         - cleaned up FrameMac.h a bit
2906
2907         * loader/mac/WebPolicyDecider.h: Removed.
2908         * loader/mac/WebPolicyDecider.mm: Removed.
2909         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2910
2911         * WebCore.exp:
2912         * bindings/js/kjs_binding.cpp:
2913         (KJS::ScriptInterpreter::ScriptInterpreter):
2914         (KJS::ScriptInterpreter::wasRunByUserGesture):
2915         * bindings/js/kjs_binding.h:
2916         (KJS::ScriptInterpreter::setCurrentEvent):
2917         (KJS::ScriptInterpreter::setInlineCode):
2918         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2919         (KJS::ScriptInterpreter::getCurrentEvent):
2920         (KJS::cacheDOMObject):
2921         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2922         * bridge/AXObjectCache.h:
2923         * bridge/mac/BrowserExtensionMac.mm:
2924         (WebCore::BrowserExtensionMac::createNewWindow):
2925         * bridge/mac/FrameMac.h:
2926         * bridge/mac/FrameMac.mm:
2927         (WebCore::FrameMac::loadRequest):
2928         (WebCore::FrameMac::submitForm):
2929         (WebCore::FrameMac::urlSelected):
2930         (WebCore::FrameMac::userAgent):
2931         (WebCore::FrameMac::passMouseDownEventToWidget):
2932         (WebCore::FrameMac::handleMouseMoveEvent):
2933         * bridge/mac/PageMac.mm:
2934         (WebCore::Page::Page):
2935         * bridge/mac/WebCoreEditCommand.mm:
2936         * bridge/mac/WebCoreFrameBridge.h:
2937         * bridge/mac/WebCoreFrameBridge.mm:
2938         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2939         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2940         * css/CSSComputedStyleDeclaration.cpp:
2941         (WebCore::):
2942         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2943         * css/CSSPrimitiveValue.cpp:
2944         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2945         (WebCore::CSSPrimitiveValue::cleanup):
2946         (WebCore::CSSPrimitiveValue::cssText):
2947         * css/CSSPrimitiveValue.h:
2948         (WebCore::CSSPrimitiveValue::):
2949         * css/CSSValueList.cpp:
2950         (WebCore::CSSValueList::append):
2951         * css/cssparser.cpp:
2952         (WebCore::CSSParser::parseValue):
2953         * css/cssparser.h:
2954         * css/cssstyleselector.cpp:
2955         (WebCore::CSSStyleSelector::applyProperty):
2956         * dom/Document.cpp:
2957         (WebCore::Document::Document):
2958         (WebCore::Document::updateSelection):
2959         (WebCore::Document::implicitClose):
2960         (WebCore::Document::setFocusNode):
2961         * dom/Document.h:
2962         * editing/ReplaceSelectionCommand.h:
2963         * html/HTMLParser.cpp:
2964         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2965         * loader/mac/FrameLoader.h:
2966         (WebCore::PolicyCheck::request):
2967         * loader/mac/FrameLoader.mm:
2968         (WebCore::FrameLoader::~FrameLoader):
2969         (WebCore::FrameLoader::safeLoad):
2970         (WebCore::FrameLoader::load):
2971         (WebCore::FrameLoader::open):
2972         (WebCore::FrameLoader::stopLoading):
2973         (WebCore::setAllDefersLoading):
2974         (WebCore::FrameLoader::setDefersLoading):
2975         (WebCore::FrameLoader::willSendRequest):
2976         (WebCore::FrameLoader::receivedMainResourceError):
2977         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2978         (WebCore::FrameLoader::commitProvisionalLoad):
2979         (WebCore::FrameLoader::checkNavigationPolicy):
2980         (WebCore::FrameLoader::checkContentPolicy):
2981         (WebCore::FrameLoader::cancelContentPolicyCheck):
2982         (WebCore::FrameLoader::stopPolicyCheck):
2983         (WebCore::FrameLoader::checkNewWindowPolicy):
2984         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2985         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2986         (WebCore::FrameLoader::continueAfterContentPolicy):
2987         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2988         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2989         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2990         (WebCore::FrameLoader::closeDocument):
2991         (WebCore::FrameLoader::transitionToCommitted):
2992         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2993         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2994         (WebCore::FrameLoader::post):
2995         (WebCore::FrameLoader::detachFromParent):
2996         (WebCore::FrameLoader::addExtraFieldsToRequest):
2997         (WebCore::PolicyCheck::PolicyCheck):
2998         (WebCore::PolicyCheck::clear):
2999         (WebCore::PolicyCheck::set):
3000         (WebCore::PolicyCheck::call):
3001         (WebCore::PolicyCheck::dropRequest):
3002         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3003         * loader/mac/WebFormState.h:
3004         * loader/mac/WebFormState.mm:
3005         * loader/mac/WebFrameLoaderClient.h:
3006         * loader/mac/WebLoader.h:
3007         (WebCore::WebResourceLoader::defersLoading):
3008         * loader/mac/WebLoader.mm:
3009         (WebCore::WebResourceLoader::WebResourceLoader):
3010         (WebCore::WebResourceLoader::load):
3011         (WebCore::WebResourceLoader::setDefersLoading):
3012         * loader/mac/WebMainResourceLoader.h:
3013         * loader/mac/WebMainResourceLoader.mm:
3014         (WebCore::MainResourceLoader::MainResourceLoader):
3015         (WebCore::MainResourceLoader::releaseDelegate):
3016         (WebCore::MainResourceLoader::didCancel):
3017         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3018         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3019         (WebCore::MainResourceLoader::willSendRequest):
3020         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3021         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3022         (WebCore::MainResourceLoader::didReceiveResponse):
3023         (WebCore::MainResourceLoader::didReceiveData):
3024         (WebCore::MainResourceLoader::didFinishLoading):
3025         (WebCore::MainResourceLoader::didFail):
3026         (WebCore::MainResourceLoader::loadNow):
3027         (WebCore::MainResourceLoader::load):
3028         (WebCore::MainResourceLoader::setDefersLoading):
3029         * page/Frame.cpp:
3030         (WebCore::Frame::paint):
3031         * page/FrameView.cpp:
3032         (WebCore::FrameView::layout):
3033         * page/FrameView.h:
3034         * page/Page.cpp:
3035         (WebCore::Page::setDefersLoading):
3036         * page/Page.h:
3037         (WebCore::Page::defersLoading):
3038         * platform/DeprecatedString.h:
3039         * platform/DeprecatedStringList.h:
3040         * platform/FontFallbackList.h:
3041         * platform/PlatformKeyboardEvent.h:
3042         * platform/PlatformMouseEvent.h:
3043         * platform/PlatformWheelEvent.h:
3044         * platform/mac/ClipboardMac.h:
3045         * platform/mac/ClipboardMac.mm:
3046         (WebCore::ClipboardMac::setDragImage):
3047         (WebCore::ClipboardMac::dragNSImage):
3048         (WebCore::ClipboardMac::sourceOperation):
3049         (WebCore::ClipboardMac::destinationOperation):
3050         * rendering/RenderObject.cpp:
3051         (WebCore::RenderObject::setStyle):
3052         * rendering/break_lines.cpp:
3053         (WebCore::nextBreakablePosition):
3054
3055 2006-10-28  Adam Roben  <aroben@apple.com>
3056
3057         Reviewed by Maciej.
3058
3059         Fix layout tests that broke after r17399. Mitz discovered that the
3060         failures were caused by HitTestResult::m_point being uninitialized
3061         much of the time. HitTestResults are now always constructed with a
3062         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3063         point instead of being passed one explicitly.
3064
3065         * WebCore.exp: Change constructor symbol.
3066         * bridge/mac/FrameMac.mm:
3067         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3068         hitTest().
3069         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3070         * bridge/mac/WebCoreAXObject.mm:
3071         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3072         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3073         * dom/Document.cpp:
3074         (WebCore::Document::elementFromPoint): Ditto.
3075         (WebCore::Document::prepareMouseEvent): Ditto.
3076         * page/Frame.cpp:
3077         (WebCore::Frame::isPointInsideSelection): Ditto.
3078         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3079         * page/FrameView.cpp:
3080         (WebCore::FrameView::handleWheelEvent): Ditto.
3081         * rendering/HitTestResult.cpp:
3082         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3083         passed point.
3084         * rendering/HitTestResult.h: Update constructor declaration.
3085         * rendering/RenderLayer.cpp:
3086         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3087         hitTest().
3088         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3089         HitTestResult instead of being passed one.
3090         (WebCore::RenderLayer::hitTestLayer): Ditto.
3091         * rendering/RenderLayer.h: Update declarations.
3092
3093 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3094
3095         Reviewed by Anders.
3096
3097         Fix Qt/Linux build.
3098
3099         * CMakeLists.txt:
3100         * platform/qt/FrameQtClient.cpp:
3101         (WebCore::numRequests):
3102         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3103         * platform/qt/PopupMenuQt.cpp:
3104         (WebCore::PopupMenu::updateFromElement):
3105
3106 2006-10-28  David Carson  <dacarson@gmail.com>
3107
3108         Tweaked by Sam. Reviewed by Brady.
3109
3110         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3111         Initialize m_modifyBiasSet to false, as it sometimes gets 
3112         used before it has been initalized.
3113
3114         * editing/SelectionController.cpp:
3115         (WebCore::SelectionController::SelectionController):
3116
3117 2006-10-28  Beth Dakin  <bdakin@apple.com>
3118
3119         Reviewed by Darin.
3120
3121         This is the WebCore half of pushing elementAtPoint and the backend 
3122         of WebElementDictionary into WebCore. Most of the changes below are 
3123         to accommodate one of the following:
3124                 
3125         -NodeInfo is now a stand-alone class called HitTestResult. 
3126                 Previously it was defined in RenderObject.h, but not for 
3127                 any particular reason. The WebElementDictionary 
3128                 functionality that was pushed into WebCore has been pushed 
3129                 specifically into the this class. In fact, 
3130                 WebElementDictionary now keeps a HitTestResult as a member 
3131                 varibale.
3132                 
3133         -The enumeration AccessPolicy is now called 
3134                 ClipboardAccessPolicy and is defined in its own header. It 
3135                 was previously defined in ClipboardMac.h, but is now 
3136                 defined independently to avoid including ClipboardMac.h 
3137                 from within FrameMac.h since FrameMac.h is now included in 
3138                 WebElementDictionary.m in WebKit.
3139                 
3140         -Element now has a virtual target() for the sake of 
3141                 NodeInfo::targetFrame() 
3142
3143         * WebCore.exp: Several WebCore functions are newly called from 
3144         WebKit, so they have been added here. 
3145         * WebCore.xcodeproj/project.pbxproj:
3146         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3147         to ClipboardMac.
3148         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3149         * bridge/mac/FrameMac.mm:
3150         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3151         and HitTestResult changes.
3152         (WebCore::FrameMac::eventMayStartDrag): Same.
3153         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3154         (WebCore::FrameMac::dispatchCPPEvent): Same.
3155         (WebCore::FrameMac::mayDHTMLCut): Same.
3156         (WebCore::FrameMac::mayDHTMLCopy): Same.
3157         (WebCore::FrameMac::mayDHTMLPaste): Same.
3158         (WebCore::FrameMac::tryDHTMLCut): Same
3159         (WebCore::FrameMac::tryDHTMLCopy): Same.
3160         (WebCore::FrameMac::tryDHTMLPaste): Same.
3161         * bridge/mac/WebCoreAXObject.mm:
3162         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3163         HitTestResult changes.
3164         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3165         * bridge/mac/WebCoreFrameBridge.h: Same.
3166         * bridge/mac/WebCoreFrameBridge.mm:
3167         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3168         ClipboardAccessPolicy changes.
3169         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3170         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3171         * dom/Document.cpp:
3172         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3173         changes.
3174         (WebCore::Document::prepareMouseEvent): Same.
3175         * dom/Element.h:
3176         (WebCore::Element::target): Now has a virtual target()
3177         * html/HTMLAnchorElement.h: Same.
3178         * html/HTMLAreaElement.cpp:
3179         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3180         changes.
3181         * html/HTMLAreaElement.h: Virtual target()
3182         * html/HTMLBaseElement.h:
3183         (WebCore::HTMLBaseElement::target): Same.
3184         * html/HTMLFormElement.h: Same.
3185         * html/HTMLLinkElement.h: Same.
3186         * html/HTMLMapElement.cpp:
3187         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3188         changes.
3189         * html/HTMLMapElement.h: Same.
3190         * page/Frame.cpp:
3191         (WebCore::Frame::isPointInsideSelection): Same.
3192         (WebCore::Frame::hitTestResultAtPoint): Same. 
3193         * page/Frame.h: Same.
3194         * page/FrameView.cpp:
3195         (WebCore::FrameView::handleWheelEvent): Same.
3196         * platform/mac/ClipboardAccessPolicy.h: Added.
3197         (WebCore::):
3198         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3199         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3200         ClipboardAccessPolicy.
3201         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3202         (WebCore::ClipboardMac::ClipboardMac):
3203         (WebCore::ClipboardMac::setAccessPolicy):
3204         (WebCore::ClipboardMac::clearData):
3205         (WebCore::ClipboardMac::clearAllData):
3206         (WebCore::ClipboardMac::getData):
3207         (WebCore::ClipboardMac::setData):
3208         (WebCore::ClipboardMac::types):
3209         (WebCore::ClipboardMac::setDragImage):
3210         (WebCore::ClipboardMac::setDropEffect):
3211         (WebCore::ClipboardMac::setEffectAllowed):
3212         * rendering/EllipsisBox.cpp:
3213         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3214         changes.
3215         * rendering/EllipsisBox.h:
3216         * rendering/HitTestResult.cpp: Added.
3217         (WebCore::HitTestResult::HitTestResult):
3218         (WebCore::HitTestResult::~HitTestResult):
3219         (WebCore::HitTestResult::operator=):
3220         (WebCore::HitTestResult::setInnerNode):
3221         (WebCore::HitTestResult::setInnerNonSharedNode):
3222         (WebCore::HitTestResult::setURLElement):
3223         (WebCore::HitTestResult::setScrollbar):
3224         (WebCore::HitTestResult::targetFrame):
3225         (WebCore::HitTestResult::boundingBox):
3226         (WebCore::HitTestResult::isSelected):
3227         (WebCore::HitTestResult::title):
3228         * rendering/HitTestResult.h: Added.
3229         (WebCore::HitTestResult::readonly):
3230         (WebCore::HitTestResult::active):
3231         (WebCore::HitTestResult::mouseMove):
3232         (WebCore::HitTestResult::innerNode):
3233         (WebCore::HitTestResult::innerNonSharedNode):
3234         (WebCore::HitTestResult::point):
3235         (WebCore::HitTestResult::URLElement):
3236         (WebCore::HitTestResult::scrollbar):
3237         (WebCore::HitTestResult::setPoint):
3238         (WebCore::HitTestResult::setReadonly):
3239         (WebCore::HitTestResult::setActive):
3240         (WebCore::HitTestResult::setMouseMove):
3241         * rendering/InlineBox.cpp:
3242         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3243         * rendering/InlineBox.h: Same.
3244         * rendering/InlineFlowBox.cpp:
3245         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3246         * rendering/InlineFlowBox.h: Same.
3247         * rendering/InlineTextBox.cpp: 
3248         (WebCore::InlineTextBox::nodeAtPoint): Same.
3249         * rendering/InlineTextBox.h: Same.
3250         * rendering/RenderBlock.cpp:
3251         (WebCore::RenderBlock::isPointInScrollbar): Same.
3252         (WebCore::RenderBlock::nodeAtPoint): Same.
3253         * rendering/RenderBlock.h: Same.
3254         * rendering/RenderBox.cpp:
3255         (WebCore::RenderBox::nodeAtPoint): Same.
3256         * rendering/RenderBox.h: Same.
3257         * rendering/RenderFlow.cpp:
3258         (WebCore::RenderFlow::hitTestLines): Same.
3259         * rendering/RenderFlow.h: Same.
3260         * rendering/RenderForeignObject.cpp:
3261         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3262         * rendering/RenderForeignObject.h: Same.
3263         * rendering/RenderFrameSet.cpp:
3264         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3265         * rendering/RenderFrameSet.h: Same.
3266         * rendering/RenderImage.cpp:
3267         (WebCore::RenderImage::nodeAtPoint): Same.
3268         * rendering/RenderImage.h: Same.
3269         * rendering/RenderInline.cpp:
3270         (WebCore::RenderInline::nodeAtPoint): Same.
3271         * rendering/RenderInline.h: Same.
3272         * rendering/RenderLayer.cpp:
3273         (WebCore::RenderLayer::autoscroll): Same.
3274         (WebCore::RenderLayer::hitTest): Same.
3275         (WebCore::RenderLayer::hitTestLayer): Same.
3276         (WebCore::RenderLayer::updateHoverActiveState): Same.
3277         * rendering/RenderLayer.h: Same.
3278         * rendering/RenderListBox.cpp:
3279         (WebCore::RenderListBox::isPointInScrollbar): Same.
3280         * rendering/RenderListBox.h: Same.
3281         * rendering/RenderObject.cpp:
3282         (WebCore::RenderObject::hitTest): Same.
3283         (WebCore::RenderObject::setInnerNode): Same.
3284         (WebCore::RenderObject::nodeAtPoint): Same.
3285         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3286         declare HitTestResult.
3287         * rendering/RenderPath.cpp:
3288         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3289         changes.
3290         * rendering/RenderPath.h: Same.
3291         * rendering/RenderSVGImage.cpp:
3292         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3293         * rendering/RenderSVGImage.h: Same
3294         * rendering/RenderSVGText.cpp:
3295         (WebCore::RenderSVGText::nodeAtPoint): Same.
3296         * rendering/RenderSVGText.h: Same.
3297         * rendering/RenderTableRow.cpp:
3298         (WebCore::RenderTableRow::nodeAtPoint): Same.
3299         * rendering/RenderTableRow.h: Same.
3300         * rendering/RenderTableSection.cpp:
3301         (WebCore::RenderTableSection::nodeAtPoint): Same.
3302         * rendering/RenderTableSection.h: Same.
3303         * rendering/RenderText.h: Same.
3304         (WebCore::RenderText::nodeAtPoint): Same.
3305         * rendering/RenderTextControl.cpp:
3306         (WebCore::RenderTextControl::nodeAtPoint): Same.
3307         * rendering/RenderTextControl.h: Same.
3308         * rendering/RootInlineBox.cpp:
3309         (WebCore::RootInlineBox::nodeAtPoint): Same.
3310         * rendering/RootInlineBox.h: Same.
3311
3312 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3313
3314         Reviewed by Anders.
3315
3316         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3317         impact of fixing it again.
3318
3319         * bridge/mac/FrameMac.mm:
3320         (WebCore::FrameMac::clear):
3321
3322 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3323
3324         Reviewed by John & Adam.
3325
3326         - assorted speedups to fix perf regression from fixing correctness regression
3327
3328         * WebCore.exp: exported new methods.
3329         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3330         * bridge/mac/WebCoreFrameBridge.h:
3331         * bridge/mac/WebCoreFrameBridge.mm:
3332         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3333         * loader/CachedResource.h:
3334         * loader/mac/CachedResourceMac.mm: Added.
3335         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3336         now cached in the CachedObject.
3337         * loader/mac/FrameLoader.h:
3338         * loader/mac/FrameLoader.mm:
3339         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3340         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3341         * loader/mac/LoaderFunctionsMac.mm:
3342         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3343         just call loadedResourceFromMemoryCache.
3344         * loader/mac/WebFrameLoaderClient.h:
3345
3346 2006-10-27  Oliver Hunt  <oliver@apple.com>
3347
3348         Reviewed by Maciej.
3349
3350         build fix
3351
3352         * dom/Document.cpp:
3353         (WebCore::Document::referrer):
3354
3355 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3356
3357         Reviewed by Maciej.
3358
3359         Moved some WebCoreFrameBridge functions into FrameLoader.
3360         
3361         I had to make FrameLoader.h capable of compiling in C++-only source files
3362         by adding some forward declarations and __OBJC__ #ifdefs.
3363
3364         * WebCore.exp:
3365         * bridge/mac/FrameMac.h:
3366         * bridge/mac/FrameMac.mm:
3367         (WebCore::FrameMac::createEmptyDocument):
3368         (WebCore::FrameMac::tokenizerProcessedData):
3369         * bridge/mac/WebCoreFrameBridge.h:
3370         * bridge/mac/WebCoreFrameBridge.mm:
3371         * dom/Document.cpp:
3372         (WebCore::Document::processHttpEquiv):
3373         (WebCore::Document::referrer):
3374         * loader/LoaderFunctions.h:
3375         * loader/mac/FrameLoader.h:
3376         * loader/mac/FrameLoader.mm:
3377         (WebCore::numRequests):
3378         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3379         (WebCore::FrameLoader::isReloading):
3380         (WebCore::FrameLoader::referrer):
3381         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3382         (WebCore::FrameLoader::startLoadingResource):
3383         * loader/mac/LoaderFunctionsMac.mm:
3384         (WebCore::CheckIfReloading):
3385         * page/Frame.h:
3386         * page/FrameTree.cpp:
3387         (WebCore::FrameTree::isDescendantOf):
3388         (WebCore::FrameTree::traverseNext):
3389         * page/FrameTree.h:
3390         * platform/network/mac/ResourceLoaderMac.mm:
3391         (WebCore::ResourceLoader::start):
3392
3393 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3394
3395         Reviewed by Darin.
3396
3397         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3398
3399         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3400
3401         * editing/DeleteButtonController.cpp:
3402         (WebCore::isDeletableElement):
3403         (WebCore::enclosingDeletableElement):
3404         (WebCore::DeleteButtonController::respondToChangedSelection):
3405
3406 2006-10-27  John Sullivan  <sullivan@apple.com>
3407
3408         Reviewed by Kevin Decker
3409         
3410         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3411         you haven't not finished reading this.
3412
3413         * rendering/InlineTextBox.h:
3414         * rendering/InlineTextBox.cpp:
3415         (WebCore::InlineTextBox::paint):
3416         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3417         considered also.
3418         (WebCore::InlineTextBox::paintDocumentMarkers):
3419         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3420         markers should be painted, instead of a marker type. This avoids walking the collection of
3421         markers multiple times back to back. Now handles grammar markers.
3422
3423 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3424
3425         Reviewed by Beth.
3426
3427         Renamed Copy Files to Copy Generated Headers.
3428         Copy 4 DOM*Internal.h headers.
3429
3430         * WebCore.xcodeproj/project.pbxproj:
3431         * bindings/scripts/CodeGeneratorObjC.pm:
3432
3433 2006-10-27  John Sullivan  <sullivan@apple.com>
3434
3435         Reviewed by Anders
3436
3437         * WebCore.exp:
3438         exported symbol for FrameMac->advanceToNextSpelling()
3439         
3440         * bridge/mac/WebCoreFrameBridge.h:
3441         * bridge/mac/WebCoreFrameBridge.mm:
3442         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3443
3444 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3445
3446         Reviewed by harrison
3447         
3448         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3449         REGRESSION: First newline missing from textarea's value
3450         
3451         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3452         
3453         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3454         (the line break) then a br to prevent the '\n' from collapsing, since the 
3455         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3456         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3457         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3458         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3459         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3460         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3461         the shadow div will be placeholders or collapsed.
3462         
3463         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3464         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3465         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3466         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3467         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3468         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3469         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3470         before it.
3471         
3472         * editing/CompositeEditCommand.cpp:
3473         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3474         a br or '\n' if content inserted just before it will cause it to collapse.
3475         * editing/CompositeEditCommand.h:
3476         * editing/InsertLineBreakCommand.cpp:
3477         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3478         to prevent a collapse as was used for the line break.  Fixed comments.
3479         * editing/InsertTextCommand.cpp:
3480         (WebCore::InsertTextCommand::input): Call the renamed function.
3481         
3482 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3483
3484         Reviewed by Brady.
3485
3486         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3487         String became an empty NSString *, instead of nil. This will become important
3488         as we start using this conversion more.
3489         
3490         Added work-around for AppKit crash that semantic accuracy revealed.
3491         
3492         No testcase because I don't think there's a way to reflect this change
3493         in a webpage yet.
3494
3495         * platform/PlatformString.h:
3496         (WebCore::String::operator NSString*):
3497         * platform/mac/TextFieldMac.mm:
3498         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3499
3500 2006-10-27  David Harrison  <harrison@apple.com>
3501
3502         Reviewed by Maciej,
3503
3504         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3505
3506         * bridge/mac/WebCoreAXObject.mm:
3507         (blockquoteLevel):
3508         Calculate and return the blockquote level of the element.
3509         
3510         (AXAttributeStringSetBlockquoteLevel):
3511         Add, if non-zero, or clear the block quote level attribute.
3512         
3513         (AXAttributedStringAppendText):
3514         Send AXAttributeStringSetBlockquoteLevel.
3515
3516 2006-10-27  Darin Adler  <darin@apple.com>
3517
3518         - fix one error in the Qt build
3519
3520         * platform/qt/GraphicsContextQt.cpp:
3521         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3522         Updated.
3523
3524 2006-10-27  Darin Adler  <darin@apple.com>
3525
3526         Reviewed by Maciej.
3527
3528         * WebCore.exp: Export more symbols needed by WebKit.
3529
3530 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3531