WebCore/ChangeLog

   1 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
   2
   3         Reviewed by Dimitri Glazkov.
   4
   5         [V8] Protect SVG animated properties from destruction in bindings.
   6         https://bugs.webkit.org/show_bug.cgi?id=31474
   7
   8         See http://crbug.com/26719.
   9
  10         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
  11         under Valgrind.
  12
  13         Made sure we keep a reference to SVG properties while setting a
  14         context:
  15         * bindings/scripts/CodeGeneratorV8.pm:
  16         * bindings/v8/V8Proxy.h:
  17         (WebCore::V8Proxy::withSVGContext):
  18
  19 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
  20
  21         Reviewed by Alexey Proskuryakov.
  22
  23         [CAIRO] shadow support for Canvas and SVG.
  24         [https://bugs.webkit.org/show_bug.cgi?id=30960]
  25
  26         Incorporate Benjamin Otte's recommendations to avoid
  27         a buffer overrun, and small performance improvement.
  28
  29         * platform/graphics/cairo/GraphicsContextCairo.cpp:
  30         (WebCore::copyContextProperties): Correctly size output
  31          storage for cairo_get_dash to avoid buffer overrun.
  32         (WebCore::drawPathShadow): Prefer cairo_fill_extents
  33          to slower cairo_stroke_extents when not drawing shadows.
  34
  35 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
  36
  37         Reviewed by Dimitri Glazkov.
  38
  39         Do not register Chromium's HTML5 DB VFS as the default
  40         VFS. Otherwise, other sqlite DB users in the same process will
  41         stop working.
  42
  43         https://bugs.webkit.org/show_bug.cgi?id=31462
  44
  45         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
  46         (WebCore::SQLiteFileSystem::openDatabase):
  47         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
  48         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
  49         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
  50         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
  51
  52 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
  53
  54         Windows build fix
  55
  56         * platform/network/cf/SocketStreamHandleCFNet.cpp:
  57         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
  58         avoiding a sign mismatch warning.
  59
  60 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
  61
  62         Release build fix.
  63
  64         * platform/network/cf/SocketStreamHandleCFNet.cpp:
  65         (WebCore::SocketStreamHandle::readStreamCallback):
  66         (WebCore::SocketStreamHandle::writeStreamCallback):
  67         Use ASSERT_UNUSED for unused stream parameter.
  68
  69 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
  70
  71         Reviewed by Darin Adler.
  72
  73         https://bugs.webkit.org/show_bug.cgi?id=31441
  74         Implement SocketStreamHandleCFNet
  75
  76         Existing WebSocket tests now pass on Mac. No proxy support yet.
  77
  78         * platform/network/SocketStreamHandleClient.h:
  79         * platform/network/cf/SocketStreamHandle.h:
  80         (WebCore::SocketStreamHandle::shouldUseSSL):
  81         (WebCore::SocketStreamHandle::refAuthenticationClient):
  82         (WebCore::SocketStreamHandle::derefAuthenticationClient):
  83         (WebCore::SocketStreamHandle::):
  84         * platform/network/cf/SocketStreamHandleCFNet.cpp:
  85         (WebCore::SocketStreamHandle::SocketStreamHandle):
  86         (WebCore::SocketStreamHandle::chooseProxy):
  87         (WebCore::SocketStreamHandle::createStreams):
  88         (WebCore::SocketStreamHandle::copyCFStreamDescription):
  89         (WebCore::SocketStreamHandle::readStreamCallback):
  90         (WebCore::SocketStreamHandle::writeStreamCallback):
  91         (WebCore::SocketStreamHandle::~SocketStreamHandle):
  92         (WebCore::SocketStreamHandle::platformSend):
  93         (WebCore::SocketStreamHandle::platformClose):
  94         (WebCore::SocketStreamHandle::receivedCredential):
  95         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
  96         (WebCore::SocketStreamHandle::receivedCancellation):
  97
  98 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
  99
 100         Reviewed by Timothy Hatcher.
 101
 102         Web Inspector: preload status bar button glyphs
 103         in order to prevent them from flickering (take 2).
 104
 105         https://bugs.webkit.org/show_bug.cgi?id=31439
 106
 107         * inspector/front-end/inspector.js:
 108         (preloadImages):
 109
 110 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
 111
 112         Reviewed by Adam Barth.
 113
 114         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
 115         Rolling back r50890.
 116
 117         https://bugs.webkit.org/show_bug.cgi?id=31467
 118
 119         * bindings/v8/V8Proxy.cpp:
 120         (WebCore::V8Proxy::canAccessPrivate):
 121
 122 2009-11-13  Dirk Schulze  <krit@webkit.org>
 123
 124         Reviewed by Gustavo Noronha.
 125
 126         [CAIRO] shadow support for Canvas and SVG
 127         [https://bugs.webkit.org/show_bug.cgi?id=30960]
 128
 129         This is the fix of a regression, caused by the shadow patch
 130         from the bug above. Reinserted the save and restore calls
 131         that were accidently removed by the previous patch.
 132
 133         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 134         (WebCore::setPlatformFill):
 135         (WebCore::setPlatformStroke):
 136
 137 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
 138
 139         Not reviewed. Reverting r50908 since it makes inspector tests
 140         time out.
 141
 142         https://bugs.webkit.org/show_bug.cgi?id=31439
 143
 144         * inspector/front-end/inspector.js:
 145
 146 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
 147
 148         Reviewed by Timothy Hatcher.
 149
 150         Enable 'console.profile()' and 'console.profileEnd()'
 151         regardless of JAVASCRIPT_DEBUGGER.
 152
 153         https://bugs.webkit.org/show_bug.cgi?id=31293
 154
 155         * WebCore.gypi:
 156         * bindings/js/JSConsoleCustom.cpp:
 157         (WebCore::JSConsole::profile):
 158         (WebCore::JSConsole::profileEnd):
 159         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
 160         (WebCore::CALLBACK_FUNC_DECL):
 161         * bindings/v8/custom/V8CustomBinding.h:
 162         * page/Console.idl:
 163
 164 2009-11-12  David Levin  <levin@chromium.org>
 165
 166         Reviewed by NOBODY.
 167
 168         Chromium build fix.
 169
 170         * bindings/v8/ScriptController.h:
 171         (WebCore::ScriptController::evaluateInWorld): Add a dummy
 172          method which isn't called in chromium to make things compile.
 173
 174 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
 175
 176         Reviewed by Adam Barth.
 177
 178         The document-open.html test was flaky at times. The test invokes the layout test plugin
 179         which in its destroy stream handler opens a new document. This basically tears down the
 180         stream and the associated plugin instance, which causes a crash when the plugin stream
 181         dereferences an invalid m_client pointer which points to the PluginView instance which
 182         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
 183         and check for the same.
 184
 185         https://bugs.webkit.org/show_bug.cgi?id=31067
 186
 187         * plugins/PluginStream.cpp:
 188         (WebCore::PluginStream::stop):
 189         (WebCore::PluginStream::destroyStream):
 190
 191 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
 192
 193         Reviewed by Dimitri Glazkov.
 194
 195         Renaming some parameters passed to DB-related methods to better
 196         indicate their purpose.
 197
 198         https://bugs.webkit.org/show_bug.cgi?id=31449
 199
 200         * platform/chromium/ChromiumBridge.h:
 201
 202 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 203
 204         Reviewed by Dan Bernstein.
 205
 206         Transformed reflected elements are clipped inside element with opacity
 207         https://bugs.webkit.org/show_bug.cgi?id=30957
 208
 209         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
 210         each clip rect into painting space before taking the unions. This, however, did not work
 211         correctly with combinations of reflections and transforms. Fixed by unioning the
 212         clipRect and mapping through transforms along the way.
 213
 214         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
 215         where the transparency layers are.
 216
 217         Test: fast/reflections/opacity-reflection-transform.html
 218
 219         * rendering/RenderLayer.cpp:
 220         (WebCore::expandClipRectForDescendantsAndReflection):
 221         (WebCore::transparencyClipBox):
 222         (WebCore::RenderLayer::beginTransparencyLayers):
 223
 224 2009-11-12  Adam Barth  <abarth@webkit.org>
 225
 226         Reviewed by Darin Fisher.
 227
 228         Improve SecurityOrigin::toString comment
 229         https://bugs.webkit.org/show_bug.cgi?id=31041
 230
 231         * page/SecurityOrigin.h:
 232
 233 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
 234
 235         Reviewed by Darin Adler.
 236
 237         externalRepresentation should take Frame as the argument
 238         https://bugs.webkit.org/show_bug.cgi?id=31393
 239
 240         No new tests as this is just a refactoring.
 241
 242         * WebCore.base.exp:
 243         * rendering/RenderTreeAsText.cpp:
 244         (WebCore::externalRepresentation):
 245         * rendering/RenderTreeAsText.h:
 246
 247 2009-11-12  Ben Murdoch  <benm@google.com>
 248
 249         Reviewed by Dimitri Glazkov.
 250
 251         [Android] The Android specific files in page/Android are out of date.
 252         https://bugs.webkit.org/show_bug.cgi?id=31437
 253
 254         No tests required.
 255
 256         * page/android/DragControllerAndroid.cpp:
 257         (WebCore::DragController::dragOperation): Added.
 258         (WebCore::DragController::cleanupAfterSystemDrag):
 259         * page/android/EventHandlerAndroid.cpp:
 260         (WebCore::EventHandler::accessKeyModifiers): Added.
 261         * page/android/InspectorControllerAndroid.cpp: Removed.
 262
 263 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
 264
 265         Reviewed by Simon Fraser.
 266
 267         [CAIRO] shadow support for Canvas and SVG.
 268         [https://bugs.webkit.org/show_bug.cgi?id=30960]
 269
 270         Implement Canvas/SVG shadow support for Cairo.  This patch
 271         uses the filter code from SVG Filters.  That means that it is
 272         necessary to activate filters to see the shadows.
 273
 274         Test: fast/canvas/canvas-shadow.html
 275
 276         * GNUmakefile.am:
 277         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
 278         * platform/graphics/GraphicsContext.h:
 279         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 280         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
 281         (WebCore::setPlatformFill):
 282         (WebCore::setPlatformStroke):
 283         (WebCore::copyContextProperties):
 284         (WebCore::drawPathShadow):
 285         (WebCore::GraphicsContext::fillPath):
 286         (WebCore::GraphicsContext::strokePath):
 287         (WebCore::GraphicsContext::drawPath):
 288         (WebCore::GraphicsContext::setPlatformShadow):
 289         (WebCore::GraphicsContext::createPlatformShadow):
 290         * platform/graphics/cairo/ImageCairo.cpp:
 291         (WebCore::BitmapImage::draw): Add filter effect.
 292         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
 293         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
 294         * platform/graphics/filters/ImageBufferFilter.h: Added.
 295         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
 296         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
 297
 298 2009-11-12  Dmitry Titov  <dimich@chromium.org>
 299
 300         Reviewed by Alexey Proskuryakov.
 301
 302         Add postTaskToMainThread to ScriptExecutionContext.
 303         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
 304         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
 305         contexts that live on the main thread.
 306         https://bugs.webkit.org/show_bug.cgi?id=31427
 307
 308         No new tests - simply moving the code.
 309
 310         * dom/Document.cpp:
 311         (WebCore::Document::postTask):
 312         * dom/ScriptExecutionContext.cpp:
 313         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
 314         (WebCore::ScriptExecutionContextTaskTimer::fired):
 315         (WebCore::PerformTaskData::PerformTaskData):
 316         (WebCore::PerformTaskData::performTask):
 317         (WebCore::ScriptExecutionContext::postTaskToMainThread):
 318         * dom/ScriptExecutionContext.h:
 319
 320 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
 321
 322         Reviewed by Darin Adler.
 323
 324         Fix crash when removing compositing layers when GC is enabled
 325         https://bugs.webkit.org/show_bug.cgi?id=31429
 326
 327         Workaround <rdar://problem/7390716> by special-casing the removal
 328         of all sublayers when GC is enabled.
 329
 330         * platform/graphics/mac/GraphicsLayerCA.mm:
 331         (WebCore::safeSetSublayers):
 332         (WebCore::GraphicsLayerCA::updateSublayerList):
 333         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
 334
 335 2009-11-12  Jens Alfke  <snej@chromium.org>
 336
 337         Reviewed by Dimitri Glazkov.
 338
 339         The last of the V8 binding optimizations.
 340         - Replace string-valued element accessors with a shared getter/setter function.
 341         - Change error handling flow of control to avoid extra branches and function calls.
 342         https://bugs.webkit.org/show_bug.cgi?id=31443
 343
 344         * bindings/scripts/CodeGeneratorV8.pm:
 345         * bindings/v8/V8Binding.cpp:
 346         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
 347         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
 348         * bindings/v8/V8Binding.h:
 349
 350 2009-11-12  Sam Weinig  <sam@webkit.org>
 351
 352         Reviewed by Oliver Hunt.
 353
 354         Fix for <rdar://problem/7267951>
 355         Canvas methods should reject uses of NaN and Infinity.
 356
 357         Test: fast/canvas/canvas-with-illegal-args.html
 358
 359         * html/canvas/CanvasRenderingContext2D.cpp:
 360         (WebCore::CanvasRenderingContext2D::scale):
 361         (WebCore::CanvasRenderingContext2D::rotate):
 362         (WebCore::CanvasRenderingContext2D::translate):
 363         (WebCore::CanvasRenderingContext2D::transform):
 364         (WebCore::CanvasRenderingContext2D::setTransform):
 365
 366 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 367
 368         Reviewed by Timothy Hatcher.
 369
 370         Web Inspector: profile timeline panel, fix obvious problems.
 371
 372         https://bugs.webkit.org/show_bug.cgi?id=31432
 373
 374         * inspector/front-end/AbstractTimelinePanel.js:
 375         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
 376         * inspector/front-end/TimelinePanel.js:
 377         (WebInspector.TimelinePanel.prototype._setWindowPosition):
 378         (WebInspector.TimelineCalculator):
 379         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
 380         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
 381         (WebInspector.TimelineCalculator.prototype.reset):
 382         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
 383         (WebInspector.TimelineCalculator.prototype.formatValue):
 384         (WebInspector.TimelineGraph):
 385         (WebInspector.TimelineGraph.prototype.refresh):
 386         * inspector/front-end/utilities.js:
 387         (Element.prototype.hasStyleClass):
 388
 389 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 390
 391         Reviewed by Timothy Hatcher.
 392
 393         Web Inspector: preload status bar button glyphs
 394         in order to prevent them from flickering.
 395
 396         https://bugs.webkit.org/show_bug.cgi?id=31439
 397
 398         * inspector/front-end/inspector.js:
 399         (preloadImages):
 400
 401 2009-11-12  Adam Roben  <aroben@apple.com>
 402
 403         Replace worldIDs with world objects
 404
 405         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
 406         user scripts/stylesheets and isolated worlds
 407
 408         Reviewed by Sam Weinig.
 409
 410         Covered by existing tests.
 411
 412         * WebCore.base.exp: Update exported symbols to match what now exists
 413         and is needed by WebKit.
 414
 415         * bindings/js/ScheduledAction.cpp:
 416         (WebCore::ScheduledAction::execute): Updated for function rename.
 417
 418         * bindings/js/ScriptController.cpp: Removed code that dealt with
 419         worldIDs.
 420         (WebCore::ScriptController::createWorld): Added. Returns a new world
 421         suitable for use on the main thread.
 422         (WebCore::ScriptController::executeScriptInWorld): Renamed from
 423         executeScriptInIsolatedWorld, since this works just fine with a
 424         "normal" world.
 425
 426         * bindings/js/ScriptController.h: Added createWorld, removed functions
 427         that took worldIDs, renamed executeScriptInIsolatedWorld to
 428         executeScriptInWorld.
 429
 430         * page/Frame.cpp:
 431         (WebCore::Frame::injectUserScripts):
 432         (WebCore::Frame::injectUserScriptsForWorld):
 433         Updated for changes to UserScriptMap and ScriptController.
 434
 435         * page/Frame.h: Changed injectUserScriptsForWorld to take a
 436         DOMWrapperWorld* instead of a worldID.
 437
 438         * page/PageGroup.cpp:
 439         (WebCore::PageGroup::addUserScriptToWorld):
 440         (WebCore::PageGroup::addUserStyleSheetToWorld):
 441         (WebCore::PageGroup::removeUserScriptFromWorld):
 442         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
 443         (WebCore::PageGroup::removeUserScriptsFromWorld):
 444         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
 445         * page/PageGroup.h:
 446         Changed these functions to take a DOMWrapperWorld* instead of a
 447         worldID. Also updated for changes to UserScript and UserStyleSheet.
 448
 449         * page/UserScript.h:
 450         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
 451         never used.
 452
 453         * page/UserScriptTypes.h:
 454         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
 455         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
 456         worldID as their key type.
 457
 458
 459 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
 460
 461         Reviewed by Tim Hatcher.
 462
 463         Fixes <http://webkit.org/b/31260>.
 464         Web Inspector: Main Resources Other than HTML are mis-detected.
 465
 466         Even if the resource is a main resource, look at its CachedResource type,
 467         because it might be an image, stylesheet, or JavaScript file, and we
 468         want to show them all correctly.
 469
 470         * inspector/InspectorResource.cpp:
 471         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
 472         (WebCore::InspectorResource::type):
 473         * inspector/InspectorResource.h:
 474
 475 2009-11-12  Jens Alfke  <snej@chromium.org>
 476
 477         Reviewed by Dimitri Glazkov.
 478
 479         Table-driven setup for V8 binding template callback functions. 100k in code savings.
 480         https://bugs.webkit.org/show_bug.cgi?id=31420
 481
 482         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
 483             to call configureTemplate().
 484         * bindings/v8/V8Binding.cpp:
 485         (WebCore::configureTemplate):  New function; does all the standard configuration work.
 486         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
 487         * bindings/v8/V8Binding.h:
 488         * bindings/v8/V8Proxy.cpp:
 489         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
 490         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
 491         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
 492         * bindings/v8/V8Proxy.h:
 493
 494 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
 495
 496         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
 497
 498         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
 499
 500 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
 501
 502         Reviewed by Dan Bernstein.
 503
 504         <rdar://problem/7388969> Add DOM API for fullscreen video
 505
 506         DOM API for fullscreen <video>.
 507
 508         Tests: media/media-fullscreen-inline.html
 509                media/media-fullscreen-not-in-document.html
 510
 511         * dom/EventNames.h:
 512             Add webkitbeginfullscreen and webkitendfullscreen.
 513
 514         * html/HTMLAttributeNames.in:
 515             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
 516
 517         * html/HTMLMediaElement.cpp:
 518         (WebCore::HTMLMediaElement::parseMappedAttribute):
 519             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
 520         (WebCore::HTMLMediaElement::enterFullscreen):
 521             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
 522             actually do enter fullscreen.
 523         (WebCore::HTMLMediaElement::exitFullscreen):
 524             Schedule webkitendfullscreenEvent event.
 525         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
 526         (WebCore::HTMLMediaElement::webkitExitFullScreen):
 527         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
 528         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
 529             New, access to fullscreen properties and methods.
 530
 531         * html/HTMLMediaElement.h:
 532         * html/HTMLMediaElement.idl:
 533             Declare methods needed for fullscreen API.
 534
 535         * html/HTMLVideoElement.cpp:
 536         (WebCore::HTMLVideoElement::supportsFullscreen):
 537             Return false if a movie does not have video.
 538
 539         * page/DOMWindow.h:
 540             Add webkitbeginfullscreen and webkitendfullscreen.
 541
 542 2009-11-12  Adam Barth  <abarth@webkit.org>
 543
 544         Reviewed by Dimitri Glazkov.
 545
 546         [Chromium] Sify compose button alerts error
 547         https://bugs.webkit.org/show_bug.cgi?id=31394
 548
 549         Test: http/tests/security/calling-versus-current.html
 550
 551         We're supposed to use the calling context for security checks.  In JSC
 552         land, this is the lexicalGlobalObject.
 553
 554         * bindings/v8/V8Proxy.cpp:
 555         (WebCore::V8Proxy::canAccessPrivate):
 556
 557 2009-11-12  Daniel Bates  <dbates@webkit.org>
 558
 559         Reviewed by Darin Adler.
 560
 561         https://bugs.webkit.org/show_bug.cgi?id=30291
 562
 563         Fixes an issue where the returned drop effect is incorrect when
 564         effectAllowed == "uninitialized".
 565
 566         According to section 7.9.2 of the HTML 5 spec.
 567         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
 568         when effectAllowed = "uninitialized" the resulting dropEffect should be the
 569         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
 570         other case.
 571
 572         No test cases are included because we have an existing test case from
 573         bug #24731.
 574
 575         * dom/Clipboard.cpp:
 576         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
 577
 578 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 579
 580         Reviewed by Timothy Hatcher.
 581
 582         Web Inspector: Do not highlight node on refresh.
 583
 584         https://bugs.webkit.org/show_bug.cgi?id=31419
 585
 586         * inspector/front-end/ElementsPanel.js:
 587         (WebInspector.ElementsPanel.prototype.reset):
 588
 589 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
 590
 591         Reviewed by Timothy Hatcher.
 592
 593         Web Inspector: Minor timeline fixes.
 594
 595         https://bugs.webkit.org/show_bug.cgi?id=31417
 596
 597         * inspector/front-end/TimelinePanel.js:
 598         (WebInspector.TimelinePanel.prototype._getRecordDetails):
 599         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
 600         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
 601         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
 602
 603 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
 604
 605         SnowLeopard build fix.
 606
 607         Renamed initWithClient to initWithAuthenticationClient.
 608
 609         * platform/network/mac/AuthenticationMac.mm:
 610         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
 611         (WebCore::AuthenticationChallenge::setAuthenticationClient):
 612
 613 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
 614
 615         Reviewed by Darin Adler.
 616
 617         ARIA: add alert type roles
 618         https://bugs.webkit.org/show_bug.cgi?id=31392
 619
 620         Test: platform/mac/accessibility/aria-alerts.html
 621
 622         * accessibility/AccessibilityObject.h:
 623         * accessibility/AccessibilityRenderObject.cpp:
 624         * accessibility/mac/AccessibilityObjectWrapper.mm:
 625
 626 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
 627
 628         Reviewed by Darin Adler.
 629
 630         https://bugs.webkit.org/show_bug.cgi?id=31386
 631         Make Mac AuthenticationChallenge usable from cross-platform code
 632
 633         No change in behavior, so no tests.
 634
 635         * platform/network/ResourceHandle.cpp:
 636         (WebCore::ResourceHandle::clearAuthentication):
 637         * platform/network/ResourceHandleInternal.h:
 638         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
 639         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
 640         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
 641         is identical.
 642
 643         * platform/network/cf/AuthenticationChallenge.h:
 644         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
 645         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
 646
 647         * platform/network/cf/ResourceHandleCFNet.cpp:
 648         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
 649         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
 650         be already set.
 651
 652         * platform/network/mac/AuthenticationChallenge.h:
 653         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
 654         best of my understanding.
 655         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
 656         confusion with "mac" and "web" challenges in ResourceHandleInternal.
 657
 658         * platform/network/mac/AuthenticationMac.mm:
 659         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
 660         making it possible to use the latter with NSURLAuthenticationChallenge.
 661         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
 662         m_nsChallenge renaming.
 663         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
 664         set it as sender (or unset, if client is null).
 665
 666         * platform/network/mac/ResourceHandleMac.mm:
 667         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
 668         authentication challenge sender.
 669         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
 670         authentication sheet.
 671         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
 672         using the new setAuthenticationClient() method.
 673         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
 674         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
 675         the original Mac one, not the one we created for use with authentication sheet. I don't
 676         know when a connection would cancel authentication in practice, so I haven't tested this.
 677
 678 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
 679
 680         Reviewed by Timothy Hatcher.
 681
 682         Web Inspector: breakpoint sidebar entries should allow click over entire list item
 683         https://bugs.webkit.org/show_bug.cgi?id=31411
 684
 685         No new tests; no new functionality, small usability change.
 686
 687         * inspector/front-end/BreakpointsSidebarPane.js:
 688         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
 689         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
 690
 691 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
 692
 693         Reviewed by Timothy Hatcher.
 694
 695         Web Inspector: breakpoints in named evals are not restored after a reload
 696         https://bugs.webkit.org/show_bug.cgi?id=31375
 697
 698         Manual test added
 699
 700         * inspector/front-end/ScriptsPanel.js:
 701         (WebInspector.ScriptsPanel.prototype.addScript):
 702         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
 703
 704 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
 705
 706         Reviewed by Kenneth Rohde Christiansen.
 707
 708         Custom printing shrink factors
 709         https://bugs.webkit.org/show_bug.cgi?id=29042
 710
 711         This reverts commit r49769. The public API for this needs to be reviewed
 712         before its inclusion in Qt.
 713
 714         * page/PrintContext.cpp:
 715         (WebCore::PrintContext::begin):
 716         * page/Settings.cpp:
 717         (WebCore::Settings::Settings):
 718         * page/Settings.h:
 719
 720 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
 721
 722         Reviewed by Pavel Feldman.
 723
 724         Web Inspector: Resource errors/warnings not shown in the Resource tree.
 725
 726         Error/Warning bubbles are not displayed next to the resource in the
 727         Resources panel if those occur before the resource is attached to the tree.
 728         https://bugs.webkit.org/show_bug.cgi?id=31404
 729
 730         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
 731
 732         * inspector/front-end/AbstractTimelinePanel.js:
 733         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
 734         * inspector/front-end/ResourcesPanel.js:
 735         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
 736
 737 2009-11-12  Philippe Normand  <pnormand@igalia.com>
 738
 739         Reviewed by Jan Alonzo.
 740
 741         https://bugs.webkit.org/show_bug.cgi?id=31047
 742         [GTK] Failing test media/video-played-ranges-1.html
 743
 744         Follow-up of r50726, don't block the UI thread when calling
 745         gst_element_get_state(). Also fixed a compilation warning and some
 746         static casts.
 747
 748         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
 749         (WebCore::playbackPosition):
 750         (WebCore::MediaPlayerPrivate::seek):
 751         (WebCore::MediaPlayerPrivate::setRate):
 752
 753 2009-11-12  Philippe Normand  <pnormand@igalia.com>
 754
 755         Reviewed by Jan Alonzo.
 756
 757         https://bugs.webkit.org/show_bug.cgi?id=31047
 758         [GTK] Failing test media/video-played-ranges-1.html
 759
 760         don't pause pipeline if already paused, same for play()
 761
 762         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
 763         (WebCore::MediaPlayerPrivate::play):
 764         (WebCore::MediaPlayerPrivate::pause):
 765
 766 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
 767
 768         Reviewed by David Levin.
 769
 770         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
 771         Chromium too.
 772         https://bugs.webkit.org/show_bug.cgi?id=31292
 773
 774         No new tests. (Corresponding test for Gtk+ is
 775         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
 776
 777         * page/EventHandler.cpp:
 778         * page/chromium/EventHandlerChromium.cpp:
 779
 780 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
 781
 782         Reviewed by Eric Seidel.
 783
 784         Prevent text inside a multi-column block from being split into columns.
 785
 786         If the tentative height of a multi-column block was too small, we need to
 787         expand the block height and try to layout again, in order to prevent text
 788         from being split into different columns.
 789
 790         CSS Multicolumn text is split awkwardly
 791         https://bugs.webkit.org/show_bug.cgi?id=22249
 792
 793         Test: fast/multicol/single-line.html
 794
 795         * rendering/RenderBlock.cpp:
 796         (WebCore::RenderBlock::layoutColumns):
 797         * rendering/RenderBlock.h:
 798         * rendering/RenderLineBoxList.cpp:
 799         (WebCore::RenderLineBoxList::paint):
 800         * rendering/RenderView.h:
 801         (WebCore::RenderView::setTruncatedAt):
 802         (WebCore::RenderView::setMinimumColumnHeight):
 803         (WebCore::RenderView::minimumColumnHeight):
 804
 805 2009-11-11  Kent Tamura  <tkent@chromium.org>
 806
 807         Reviewed by Darin Adler.
 808
 809         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
 810         https://bugs.webkit.org/show_bug.cgi?id=31195
 811
 812         Test: fast/forms/input-file-re-render.html
 813
 814         * rendering/RenderFileUploadControl.cpp:
 815         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
 816
 817 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
 818
 819         Reviewed by Dimitri Glazkov.
 820
 821         Fixing Chromium's POSIX VFS implementation, by adding the required
 822         "used file descriptors" logic.
 823
 824         https://bugs.webkit.org/show_bug.cgi?id=31275
 825
 826         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
 827
 828 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
 829
 830         Reviewed by Oliver Hunt.
 831
 832         need to implement aria tree roles
 833         https://bugs.webkit.org/show_bug.cgi?id=31284
 834
 835         Tests: platform/mac/accessibility/aria-multiselectable.html
 836                platform/mac/accessibility/aria-tree.html
 837
 838         * accessibility/AccessibilityList.cpp:
 839         (WebCore::AccessibilityList::accessibilityIsIgnored):
 840         * accessibility/AccessibilityObject.cpp:
 841         (WebCore::AccessibilityObject::ariaTreeRows):
 842         (WebCore::AccessibilityObject::ariaTreeItemContent):
 843         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
 844         * accessibility/AccessibilityObject.h:
 845         (WebCore::):
 846         (WebCore::AccessibilityObject::isTree):
 847         (WebCore::AccessibilityObject::isTreeItem):
 848         (WebCore::AccessibilityObject::setIsExpanded):
 849         (WebCore::AccessibilityObject::canSetExpandedAttribute):
 850         (WebCore::AccessibilityObject::hierarchicalLevel):
 851         (WebCore::AccessibilityObject::setSelectedRows):
 852         (WebCore::AccessibilityObject::performDefaultAction):
 853         * accessibility/AccessibilityRenderObject.cpp:
 854         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
 855         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
 856         (WebCore::AccessibilityRenderObject::isExpanded):
 857         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
 858         (WebCore::AccessibilityRenderObject::elementAttributeValue):
 859         (WebCore::AccessibilityRenderObject::setIsExpanded):
 860         (WebCore::AccessibilityRenderObject::isSelected):
 861         (WebCore::AccessibilityRenderObject::setSelected):
 862         (WebCore::AccessibilityRenderObject::setSelectedRows):
 863         (WebCore::createARIARoleMap):
 864         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
 865         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
 866         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
 867         (WebCore::AccessibilityRenderObject::selectedChildren):
 868         * accessibility/AccessibilityRenderObject.h:
 869         * accessibility/mac/AccessibilityObjectMac.mm:
 870         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
 871         * accessibility/mac/AccessibilityObjectWrapper.mm:
 872         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
 873         (RoleEntry::):
 874         (-[AccessibilityObjectWrapper subrole]):
 875         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
 876         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
 877         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
 878         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
 879         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
 880         * html/HTMLAttributeNames.in:
 881
 882 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
 883
 884         Build fix after @r50760 with ENABLE_FILTERS.
 885
 886         * platform/graphics/filters/SourceAlpha.cpp:
 887         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
 888         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
 889           to fillRect.
 890
 891 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
 892
 893         Reviewed by Alexey Proskuryakov.
 894
 895         Fix WebSocket frame parser of frame_type with high-order bit set.
 896         https://bugs.webkit.org/show_bug.cgi?id=30668
 897
 898         If buffer is smaller than frame's length, it should break the loop
 899         instead of reading next byte.
 900
 901         Tests: websocket/tests/frame-length-longer-than-buffer.html
 902                websocket/tests/frame-length-skip.html
 903
 904         * websockets/WebSocketChannel.cpp:
 905         (WebCore::WebSocketChannel::didReceiveData):
 906
 907 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
 908
 909         Reviewed by Adam Barth.
 910
 911         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
 912         https://bugs.webkit.org/show_bug.cgi?id=31345
 913
 914         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
 915
 916         * platform/graphics/chromium/FontCustomPlatformData.cpp:
 917         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
 918         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
 919         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
 920
 921 2009-11-11  Beth Dakin  <bdakin@apple.com>
 922
 923         Build fix. No review needed.
 924
 925         * platform/graphics/gtk/FontGtk.cpp:
 926         (WebCore::Font::drawComplexText):
 927
 928 2009-11-11  Beth Dakin  <bdakin@apple.com>
 929
 930         Build fix. No review needed.
 931
 932         * platform/graphics/cairo/FontCairo.cpp:
 933         (WebCore::Font::drawGlyphs):
 934
 935 2009-11-11  Beth Dakin  <bdakin@apple.com>
 936
 937         Windows build fix. No review needed.
 938
 939         * platform/graphics/win/FontCGWin.cpp:
 940         (WebCore::Font::drawGlyphs):
 941
 942 2009-11-11  Beth Dakin  <bdakin@apple.com>
 943
 944         Reviewed by Simon Fraser.
 945
 946         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
 947         Make -webkit-color-correction work with shadows
 948
 949         From canvas, just send DeviceColorSpace to setShadow() for now.
 950         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
 951         * html/canvas/CanvasRenderingContext2D.cpp:
 952         (WebCore::CanvasRenderingContext2D::setShadow):
 953         (WebCore::CanvasRenderingContext2D::applyShadow):
 954
 955         setShadow() and setPlatformShadow() now take a ColorSpace.
 956         * platform/graphics/GraphicsContext.cpp:
 957         (WebCore::GraphicsContext::setShadow):
 958         * platform/graphics/GraphicsContext.h:
 959         * platform/graphics/cg/GraphicsContextCG.cpp:
 960         (WebCore::createCGColorWithColorSpace): New helper to create a
 961         color in a ColorSpace.
 962         (WebCore::setCGFillColor): Call new helper.
 963         (WebCore::setCGStrokeColor): Call new helper.
 964         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
 965         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
 966         (WebCore::GraphicsContext::setPlatformShadow):
 967
 968         Send appropriate ColorSpace to setShadow().
 969         * platform/graphics/mac/FontMac.mm:
 970         (WebCore::Font::drawGlyphs):
 971         * rendering/EllipsisBox.cpp:
 972         (WebCore::EllipsisBox::paint):
 973         * rendering/InlineFlowBox.cpp:
 974         (WebCore::InlineFlowBox::paintTextDecorations):
 975         * rendering/InlineTextBox.cpp:
 976         (WebCore::paintTextWithShadows):
 977         (WebCore::InlineTextBox::paintDecoration):
 978         * rendering/RenderBoxModelObject.cpp:
 979         (WebCore::RenderBoxModelObject::paintBoxShadow):
 980         * rendering/SVGInlineTextBox.cpp:
 981         (WebCore::SVGInlineTextBox::paintCharacters):
 982         * rendering/SVGRenderSupport.cpp:
 983         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
 984
 985         Attempt to keep ports building.
 986         * platform/graphics/cairo/GraphicsContextCairo.cpp:
 987         (WebCore::GraphicsContext::setPlatformShadow):
 988         * platform/graphics/qt/GraphicsContextQt.cpp:
 989         (WebCore::GraphicsContext::setPlatformShadow):
 990         * platform/graphics/skia/GraphicsContextSkia.cpp:
 991         (WebCore::GraphicsContext::setPlatformShadow):
 992         * platform/graphics/wince/GraphicsContextWince.cpp:
 993         (WebCore::GraphicsContext::setPlatformShadow):
 994         * platform/graphics/wx/GraphicsContextWx.cpp:
 995         (WebCore::GraphicsContext::setPlatformShadow):
 996
 997 2009-11-11  Kent Tamura  <tkent@chromium.org>
 998
 999         Reviewed by Darin Adler.
1000
1001         Print the file text of a file upload control in DumpRenderTree for ease of tests.
1002         https://bugs.webkit.org/show_bug.cgi?id=31195
1003
1004         * rendering/RenderFileUploadControl.cpp:
1005         (WebCore::RenderFileUploadControl::paintObject):
1006         (WebCore::RenderFileUploadControl::fileTextValue):
1007         * rendering/RenderFileUploadControl.h:
1008         (WebCore::RenderFileUploadControl::isFileUploadControl):
1009         (WebCore::toRenderFileUploadControl):
1010         * rendering/RenderObject.h:
1011         (WebCore::RenderObject::isFileUploadControl):
1012         * rendering/RenderTreeAsText.cpp:
1013         (WebCore::operator<<):
1014
1015 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
1016
1017         Reviewed by Sam Weinig.
1018
1019         DOM Wrappers for some nodes may not be marked.
1020         https://bugs.webkit.org/show_bug.cgi?id=31380
1021
1022         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
1023         the wrapper for the current world only.  This means that wrappers may be GC'ed
1024         prematurely, and properties lost.
1025
1026         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
1027
1028         * bindings/js/JSAttrCustom.cpp:
1029         (WebCore::JSAttr::markChildren):
1030         * bindings/js/JSDOMBinding.cpp:
1031         (WebCore::markDOMNodeWrapper):
1032         * bindings/js/JSDOMBinding.h:
1033         * bindings/js/JSNamedNodeMapCustom.cpp:
1034         (WebCore::JSNamedNodeMap::markChildren):
1035         * bindings/js/JSNodeCustom.cpp:
1036         (WebCore::JSNode::markChildren):
1037         * bindings/js/JSSVGElementInstanceCustom.cpp:
1038         (WebCore::JSSVGElementInstance::markChildren):
1039         * bindings/js/JSStyleSheetCustom.cpp:
1040         (WebCore::JSStyleSheet::markChildren):
1041
1042 2009-11-11  Ben Murdoch  <benm@google.com>
1043
1044         Reviewed by Darin Adler.
1045
1046         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
1047         https://bugs.webkit.org/show_bug.cgi?id=31384
1048
1049         No functionality change so no tests required.
1050
1051         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
1052
1053 2009-11-11  Jens Alfke  <snej@chromium.org>
1054
1055         Reviewed by Dimitri Glazkov.
1056
1057         The Big De-Inlining. 450k code size reduction (32-bit x86.)
1058         - Various inline functions in V8Binding.h made non-inline.
1059         - Some renaming for consistency.
1060         - New function createRawTemplate().
1061         https://bugs.webkit.org/show_bug.cgi?id=31383
1062
1063         * bindings/scripts/CodeGeneratorV8.pm:
1064         * bindings/v8/V8Binding.cpp:
1065         (WebCore::v8DOMWrapperToNative):
1066         (WebCore::v8ValueToWebCoreString):
1067         (WebCore::v8ValueToAtomicWebCoreString):
1068         (WebCore::toInt32):
1069         (WebCore::toWebCoreString):
1070         (WebCore::toWebCoreStringWithNullCheck):
1071         (WebCore::toAtomicWebCoreStringWithNullCheck):
1072         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
1073         (WebCore::isUndefinedOrNull):
1074         (WebCore::v8Boolean):
1075         (WebCore::v8UndetectableString):
1076         (WebCore::v8StringOrNull):
1077         (WebCore::v8StringOrUndefined):
1078         (WebCore::v8StringOrFalse):
1079         (WebCore::v8StringToWebCoreString):
1080         (WebCore::v8ExternalString):
1081         (WebCore::createRawTemplate):  New function.
1082         * bindings/v8/V8Binding.h:
1083         (WebCore::v8DOMWrapperTo):
1084         (WebCore::v8DOMWrapperToNode):
1085         (WebCore::v8StringToWebCoreString):
1086         (WebCore::v8StringToAtomicWebCoreString):
1087
1088 2009-11-11  Jens Alfke  <snej@chromium.org>
1089
1090         Reviewed by Dimitri Glazkov.
1091
1092         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
1093         event-listener setter into a new subroutine transferHiddenDependency().
1094         https://bugs.webkit.org/show_bug.cgi?id=31377
1095
1096         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
1097         * bindings/v8/V8Utilities.cpp:
1098         (WebCore::transferHiddenDependency):  New.
1099         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
1100
1101 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
1102
1103         Reviewed by Beth Dakin.
1104
1105         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
1106         because there is a CG bug preventing this from working.
1107
1108         * platform/graphics/cg/GraphicsContextCG.cpp:
1109         (WebCore::sRGBColorSpaceRef):
1110
1111 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
1112
1113         Reviewed by Timothy Hatcher.
1114
1115         Check that if Storage panel exists before calling its methods
1116
1117         https://bugs.webkit.org/show_bug.cgi?id=31343
1118
1119         * inspector/front-end/inspector.js:
1120         (WebInspector.addDatabase):
1121         (WebInspector.addCookieDomain):
1122         (WebInspector.addDOMStorage):
1123         (WebInspector.updateDOMStorage):
1124
1125 2009-11-11  Jens Alfke  <snej@chromium.org>
1126
1127         Reviewed by Dimitri Glazkov.
1128
1129         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
1130         times in the generated V8 bindings.
1131         https://bugs.webkit.org/show_bug.cgi?id=31368
1132
1133         * bindings/v8/V8DOMWrapper.cpp:
1134         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
1135         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
1136
1137 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
1138
1139         Reviewed by Timothy Hatcher.
1140
1141         Display the correct summary in the web inspector for the shorthands
1142         border-color, border-width, border-style, margin, and padding.
1143         https://bugs.webkit.org/show_bug.cgi?id=7987
1144
1145         Test: fast/css/shorthands-four-values.html
1146
1147         * css/CSSMutableStyleDeclaration.cpp:
1148         (WebCore::CSSMutableStyleDeclaration::get4Values):
1149         Display the summary information in the same way the shorthand would be
1150         specified in a css rule.
1151
1152 2009-11-11  Jens Alfke  <snej@chromium.org>
1153
1154         Reviewed by Dimitri Glazkov.
1155
1156         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
1157         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
1158         https://bugs.webkit.org/show_bug.cgi?id=31367
1159
1160         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
1161
1162 2009-11-11  Jens Alfke  <snej@chromium.org>
1163
1164         Reviewed by Dimitri Glazkov.
1165
1166         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
1167
1168         * bindings/v8/DOMData.cpp:
1169         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
1170             so it can be inlined by its caller.
1171         * bindings/v8/DOMData.h:
1172         * bindings/v8/MainThreadDOMData.cpp:
1173         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
1174         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
1175         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
1176             and getStore, which inline both calls together.
1177         * bindings/v8/MainThreadDOMData.h:
1178         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
1179         * bindings/v8/V8DOMMap.cpp:
1180         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
1181
1182 2009-11-11  Nate Chapin  <japhet@chromium.org>
1183
1184         Reviewed by Dimitri Glazkov.
1185
1186         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
1187
1188         https://bugs.webkit.org/show_bug.cgi?id=31357
1189
1190         * platform/KURLGoogle.cpp:
1191         (WebCore::isSchemeFirstChar):
1192         (WebCore::isSchemeChar):
1193         (WebCore::KURL::hasPort):
1194         (WebCore::KURL::removePort):
1195         (WebCore::protocolIsValid):
1196
1197 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1198
1199         Build fix, no reviewed.
1200
1201         Correct setPlatformFillColor and setPlatformStrokeColor calls
1202         to match new ColorSpace-supporting signatures.
1203
1204         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1205           color space to the set[...]Color calls.
1206
1207 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1208
1209         Reviewed by Sam Weinig.
1210
1211         https://bugs.webkit.org/show_bug.cgi?id=31327
1212         Clean up SocketStreamHandleClient interface
1213
1214         No change in behavior.
1215
1216         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1217         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1218         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1219         should be.
1220         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1221         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1222         For ResourceHandle, this method is called when the user cancels authentication sheet,
1223         not when something happens with the stream.
1224
1225         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1226         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1227
1228         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1229         callbacks have no real implementation yet.
1230
1231 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1232
1233         Reviewed by Eric Seidel.
1234
1235         Allow custom memory allocation control for the part of page directory in WebCore
1236         https://bugs.webkit.org/show_bug.cgi?id=31350
1237
1238         Inherits the following classes from Noncopyable because these are instantiated
1239         by 'new' and these are no need to be copyable:
1240
1241         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1242         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1243         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1244         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1245         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1246         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1247         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1248         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1249         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1250
1251         Inherits PropertyWrapperBase class from Noncopyable because (its child class)
1252         PropertyWrapper is instantiated by 'new' in
1253         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1254
1255         * page/DragController.h:
1256         * page/EventHandler.h:
1257         * page/FocusController.h:
1258         * page/FrameView.cpp:
1259         * page/PluginHalter.h:
1260         * page/Settings.h:
1261         * page/UserScript.h:
1262         * page/UserStyleSheet.h:
1263         * page/XSSAuditor.h:
1264         * page/animation/AnimationBase.cpp:
1265
1266 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1267
1268         Reviewed by Kenneth Rohde Christiansen.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=31323
1271         Fix a few compiler warnings
1272
1273         No new tests as there is no new functionality.
1274
1275         * editing/htmlediting.cpp:
1276         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1277         parentheses to silence gcc 4.4 -Wparentheses warnings
1278
1279 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1280
1281         Reviewed by Mark Rowe.
1282
1283         Set m_hasPendingGeometryChange to true by default, so that
1284         at least one call to NPP_SetWindow is executed, which is
1285         needed by the DRT plugin testing framework.
1286
1287         * plugins/PluginView.cpp:
1288         (WebCore::PluginView::PluginView):
1289
1290 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1291
1292         Rubber-stamped by Kenneth Rohde Christiansen.
1293
1294         https://bugs.webkit.org/show_bug.cgi?id=31348
1295         [Qt] Remove unnecessary LUT creator from WebCore.pro
1296
1297         * WebCore.pro:
1298
1299 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1300
1301         Reviewed by Tor Arne Vestbø.
1302
1303         Introduce a function for querying the input method status
1304         in QWebPageClient.
1305
1306         * platform/qt/QWebPageClient.h:
1307
1308 2009-11-11  Benjamin Otte  <otte@gnome.org>
1309
1310         Reviewed by Jan Alonzo.
1311
1312         [GTK] Black artifacts in youtube.com/html5
1313
1314         Paint the video to the given size. It's the job of the callers to keep
1315         track of aspect ratio. RenderVideo.cpp does it for the <video>
1316         element.
1317         https://bugs.webkit.org/show_bug.cgi?id=30925
1318
1319         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1320         (WebCore::MediaPlayerPrivate::paint):
1321
1322 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1323
1324         Reviewed by Reviewed by Jan Alonzo.
1325
1326         https://bugs.webkit.org/show_bug.cgi?id=30901
1327         [Gtk] Need to de-lint the Atk a11y code
1328
1329         Cleaned up some missed capitalization style-guideline violations.
1330
1331         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1332
1333 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1334
1335         Reviewed by Eric Seidel.
1336
1337         [Qt] Make the default style background color valid.
1338         Currently the color is transparent but invalid, this causes
1339         list boxes in QtWebKit to be drawn with a black background
1340         since r49242.
1341         https://bugs.webkit.org/show_bug.cgi?id=31295
1342
1343         * rendering/style/RenderStyle.h:
1344         (WebCore::InheritedFlags::initialBackgroundColor):
1345         * rendering/style/StyleBackgroundData.cpp:
1346         (WebCore::StyleBackgroundData::StyleBackgroundData):
1347
1348 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1349
1350         Reviewed by Geoff Garen.
1351
1352         Simplify the ownership model for worlds - rather than having a pair of weak references
1353         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1354         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1355         back forward cache.
1356
1357         * WebCore.base.exp:
1358         * bindings/js/JSDOMBinding.cpp:
1359         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1360         * bindings/js/JSDOMBinding.h:
1361         (WebCore::DOMWrapperWorld::forgetDocument):
1362         * bindings/js/ScriptCachedFrameData.cpp:
1363         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1364         (WebCore::ScriptCachedFrameData::restore):
1365         (WebCore::ScriptCachedFrameData::clear):
1366         * bindings/js/ScriptCachedFrameData.h:
1367         * bindings/js/ScriptController.cpp:
1368         (WebCore::ScriptController::~ScriptController):
1369         (WebCore::ScriptController::clearWindowShell):
1370         (WebCore::ScriptController::initScript):
1371         (WebCore::ScriptController::updateDocument):
1372         * bindings/js/ScriptController.h:
1373
1374 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1375
1376         Reviewed by Darin Adler.
1377
1378         rename counter to makeCounterNode in RenderCounter.cpp
1379         https://bugs.webkit.org/show_bug.cgi?id=31289
1380
1381         No new test because this is just a small refactoring.
1382
1383         * rendering/RenderCounter.cpp:
1384         (WebCore::findPlaceForCounter):
1385         (WebCore::makeCounterNode):
1386         (WebCore::RenderCounter::originalText):
1387
1388 2009-11-10  Daniel Bates  <dbates@webkit.org>
1389
1390         Reviewed by Oliver Hunt.
1391
1392         https://bugs.webkit.org/show_bug.cgi?id=30754
1393
1394         Patch 2 of 2.
1395
1396         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1397         needed. This method fired a drag event whenever the mouse moved, but
1398         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1399         model independent of when the mouse moves. See "Among other changes..."
1400         in the change log for patch 1 for more details.
1401
1402         * WebCore.DragSupport.exp:
1403         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1404         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1405         * page/EventHandler.h:
1406
1407 2009-11-10  Daniel Bates  <dbates@webkit.org>
1408
1409         Reviewed by Oliver Hunt.
1410
1411         https://bugs.webkit.org/show_bug.cgi?id=30754
1412
1413         Patch 1 of 2.
1414
1415         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1416         the drag event should always fire before the dragover event.
1417
1418         In fixing this bug, this patch also makes our drag processing model
1419         conform to the HTML 5 spec.
1420
1421         Among the changes, this patch ensures that the drag event isn't fired outside
1422         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1423         Currently, the drag event is fired whenever the mouse button is down and the OS
1424         detects the mouse moved. But, as per the spec, the drag event should
1425         fire approx. every 350ms so long as the mouse button is down.
1426
1427         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1428
1429         * page/EventHandler.cpp:
1430         (WebCore::EventHandler::clear):
1431         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1432         Modified to determine when we are in the correct instance of EventHandler to service the drag
1433         and drop operation.
1434         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1435         into this method.
1436         (WebCore::EventHandler::cancelDragAndDrop):
1437         (WebCore::EventHandler::performDragAndDrop):
1438         (WebCore::EventHandler::clearDragState):
1439         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1440         we should fire both drag and dragover events or only the dragover event.
1441
1442 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1447         https://bugs.webkit.org/show_bug.cgi?id=31301
1448
1449         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1450
1451         Allowed passing V8Proxy for the calling JS context:
1452         * bindings/v8/V8DOMWrapper.h:
1453         (WebCore::V8DOMWrapper::getXPathNSResolver):
1454         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1455         (WebCore::V8CustomXPathNSResolver::create):
1456         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1457         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1458         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1459         * bindings/v8/custom/V8DocumentCustom.cpp:
1460         (WebCore::CALLBACK_FUNC_DECL):
1461
1462 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1463
1464         Reviewed by Timothy Hatcher.
1465
1466         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1467         https://bugs.webkit.org/show_bug.cgi?id=29972.
1468
1469         Add methods for setting different parts of the URL in href attribute.
1470
1471         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1472                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1473                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1474                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1475                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1476                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1477                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1478
1479         * bindings/js/JSLocationCustom.cpp:
1480         (WebCore::JSLocation::setPort):
1481         * html/HTMLAnchorElement.cpp:
1482         (WebCore::parsePortFromStringPosition):
1483         (WebCore::HTMLAnchorElement::setHash):
1484         (WebCore::HTMLAnchorElement::setHost):
1485         (WebCore::HTMLAnchorElement::setHostname):
1486         (WebCore::HTMLAnchorElement::setPathname):
1487         (WebCore::HTMLAnchorElement::setPort):
1488         (WebCore::HTMLAnchorElement::setProtocol):
1489         (WebCore::HTMLAnchorElement::setSearch):
1490         * html/HTMLAnchorElement.h:
1491         * html/HTMLAnchorElement.idl:
1492         * loader/FrameLoader.cpp:
1493         (WebCore::FrameLoader::iconURL):
1494         * platform/KURL.cpp:
1495         (WebCore::KURL::removePort):
1496         (WebCore::KURL::setPort):
1497         (WebCore::KURL::prettyURL):
1498         (WebCore::protocolIsValid):
1499         * platform/KURL.h:
1500         (WebCore::KURL::canSetHostOrPort):
1501         (WebCore::KURL::canSetPathname):
1502         (WebCore::KURL::hasPort):
1503         * platform/network/soup/ResourceHandleSoup.cpp:
1504         (WebCore::):
1505
1506 2009-11-10  Nate Chapin  <japhet@chromium.org>
1507
1508         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1509
1510         * platform/chromium/PopupMenuChromium.cpp:
1511         (WebCore::PopupContainer::paintBorder):
1512         (WebCore::PopupListBox::paint):
1513         (WebCore::PopupListBox::paintRow):
1514         * platform/graphics/chromium/TransparencyWin.cpp:
1515         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1516         * platform/graphics/skia/GraphicsContextSkia.cpp:
1517         (WebCore::GraphicsContext::fillRect):
1518         (WebCore::GraphicsContext::fillRoundedRect):
1519         (WebCore::GraphicsContext::setPlatformFillColor):
1520         (WebCore::GraphicsContext::setPlatformStrokeColor):
1521         * rendering/RenderMediaControlsChromium.cpp:
1522         (WebCore::paintMediaSlider):
1523         (WebCore::paintMediaVolumeSlider):
1524         (WebCore::paintMediaTimelineContainer):
1525         * rendering/RenderThemeChromiumMac.mm:
1526         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1527
1528 2009-11-10  Brady Eidson  <beidson@apple.com>
1529
1530         Reviewed by Sam Weinig.
1531
1532         Repro crash saving pcmag.com article as a webarchive.
1533         <rdar://problem/7381219> and https://webkit.org/b/31322
1534
1535         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1536
1537         * css/CSSStyleSheet.cpp:
1538         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1539           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1540
1541 2009-11-10  Beth Dakin  <bdakin@apple.com>
1542
1543         Attempt 2 to fix Tiger build. No review needed.
1544
1545         * platform/graphics/cg/GraphicsContextCG.cpp:
1546         (WebCore::deviceRGBColorSpaceRef):
1547         (WebCore::sRGBColorSpaceRef):
1548
1549 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1550
1551         wx build fix. Changes needed after r50760.
1552
1553         * platform/graphics/wx/GraphicsContextWx.cpp:
1554         (WebCore::GraphicsContext::GraphicsContext):
1555         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1556         (WebCore::drawTextWithSpacing):
1557
1558 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1559
1560         Qt build fix.
1561
1562         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1563         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1564
1565 2009-11-10  Beth Dakin  <bdakin@apple.com>
1566
1567         Tiger build fix. No review needed.
1568
1569         * platform/graphics/cg/GraphicsContextCG.cpp:
1570         (WebCore::sRGBColorSpaceRef):
1571
1572 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1573
1574         Reviewed by Dan Bernstein.
1575
1576         https://bugs.webkit.org/show_bug.cgi?id=31312
1577         Decouple authentication panel callbacks from ResourceHandle
1578
1579         No change in functionality.
1580
1581         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1582         ResourceHandle as delegate.
1583
1584         * WebCore.vcproj/WebCore.vcproj:
1585         * platform/network/AuthenticationClient.h: Added.
1586         Added a new interface for listening to authentication panel notifications.
1587
1588         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1589         it wants with the project file.
1590
1591         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1592         interface class.
1593         (WebCore::AuthenticationClient::deref): Ditto.
1594
1595         * platform/network/ResourceHandle.h:
1596         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1597         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1598
1599         * platform/network/cf/AuthenticationCF.cpp:
1600         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1601         (WebCore::AuthenticationChallenge::platformCompare):
1602         * platform/network/cf/AuthenticationChallenge.h:
1603         (WebCore::AuthenticationChallenge::authenticationClient):
1604         * platform/network/chromium/AuthenticationChallenge.h:
1605         (WebCore::AuthenticationChallenge::authenticationClient):
1606         * platform/network/curl/AuthenticationChallenge.h:
1607         (WebCore::AuthenticationChallenge::authenticationClient):
1608         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1609
1610 2009-11-10  Beth Dakin  <bdakin@apple.com>
1611
1612        Second attempted gtk build fix. No review needed.
1613
1614         * html/canvas/CanvasStyle.cpp:
1615         (WebCore::CanvasStyle::applyStrokeColor):
1616
1617
1618 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1619
1620         Reviewed by Geoff Garen.
1621
1622         Fix back/forwards cache with JSC isolated worlds.
1623         https://bugs.webkit.org/show_bug.cgi?id=31310
1624         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1625
1626         Store the global object for all worlds, not just the normal world.
1627         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1628         so we can forget global objects if a world goes away.
1629
1630         * bindings/js/JSDOMBinding.cpp:
1631         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1632         * bindings/js/JSDOMBinding.h:
1633         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1634         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1635         * bindings/js/ScriptCachedFrameData.cpp:
1636         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1637         (WebCore::ScriptCachedFrameData::forgetWorld):
1638         (WebCore::ScriptCachedFrameData::domWindow):
1639         (WebCore::ScriptCachedFrameData::restore):
1640         (WebCore::ScriptCachedFrameData::clear):
1641         * bindings/js/ScriptCachedFrameData.h:
1642         * bindings/js/ScriptController.h:
1643
1644 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1645
1646         [Qt] Unreviewed buildfix after r50760.
1647
1648         * platform/graphics/qt/GraphicsContextQt.cpp:
1649         (WebCore::GraphicsContext::GraphicsContext):
1650
1651 2009-11-10  Beth Dakin  <bdakin@apple.com>
1652
1653         Attempted build fix. (No review needed.)
1654
1655         * GNUmakefile.am: Adding ColorSpace.h
1656
1657 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1658
1659         Reviewed by NOBODY - Build Fix.
1660
1661         Updated function calls to take a ColorSpace argument, passing
1662         in DeviceColorSpace for now - this should be fixed. Also added
1663         ColorSpace.h to WebCore project.
1664
1665         * WebCore.vcproj/WebCore.vcproj:
1666         * platform/graphics/win/FontCGWin.cpp:
1667         (WebCore::Font::drawGlyphs):
1668         * platform/graphics/win/GraphicsContextCGWin.cpp:
1669         (WebCore::GraphicsContext::GraphicsContext):
1670         * platform/win/PopupMenuWin.cpp:
1671         (WebCore::PopupMenu::paint):
1672         * platform/win/WebCoreTextRenderer.cpp:
1673         (WebCore::doDrawTextAtPoint):
1674         * rendering/RenderThemeSafari.cpp:
1675         (WebCore::RenderThemeSafari::paintMenuListButton):
1676
1677 2009-11-10  Jens Alfke  <snej@chromium.org>
1678
1679         Reviewed by Darin Adler.
1680
1681         Optimizations to Element::getAttribute
1682         https://bugs.webkit.org/show_bug.cgi?id=30926
1683
1684         * dom/Element.cpp:
1685         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1686         * dom/NamedAttrMap.cpp:
1687         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1688         * platform/text/PlatformString.h:
1689         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1690
1691 2009-11-10  Beth Dakin  <bdakin@apple.com>
1692
1693         Reviewed by Darin Adler.
1694
1695         Fix for <rdar://problem/7059710>
1696         -and corresponding-
1697         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1698         color-correction for CSS colors
1699
1700         New exported symbol for GraphicsContext::fillColor() which now
1701         accepts a ColorSpace as an optional parameter.
1702         * WebCore.base.exp:
1703
1704         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1705         * WebCore.xcodeproj/project.pbxproj:
1706
1707         Computed Style for -webkit-color-correction
1708         * css/CSSComputedStyleDeclaration.cpp:
1709         (WebCore::):
1710         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1711
1712         Parse -webkit-color-correction
1713         * css/CSSParser.cpp:
1714         (WebCore::CSSParser::parseValue):
1715
1716        Map CSS identifiers to the appropriate values of the ColorSpace enum
1717         * css/CSSPrimitiveValueMappings.h:
1718         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1719         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1720
1721         New property -webkit-color-correction
1722         * css/CSSPropertyNames.in:
1723
1724         Map -webkit-color-correction into the RenderStyle.
1725         * css/CSSStyleSelector.cpp:
1726         (WebCore::CSSStyleSelector::applyProperty):
1727
1728         Add new value sRGB.
1729         * css/CSSValueKeywords.in:
1730
1731         Comment out the reference to sRGB since it will now be inherited as
1732         a value from CSSValueKeywords.
1733         * css/SVGCSSValueKeywords.in:
1734
1735         Definition of the ColorSpace enum.
1736         * platform/graphics/ColorSpace.h: Added.
1737         (WebCore::):
1738
1739         These functions all now take a ColorSpace as a parameter.
1740         * platform/graphics/GraphicsContext.cpp:
1741         (WebCore::GraphicsContext::setStrokeColor):
1742         (WebCore::GraphicsContext::setFillColor):
1743         (WebCore::GraphicsContext::drawHighlightForText):
1744
1745         Return the appropriate ColorSpace.
1746         (WebCore::GraphicsContext::strokeColorSpace):
1747         (WebCore::GraphicsContext::fillColorSpace):
1748
1749         These functions all call other functions which require a ColorSpace
1750         as a parameter.
1751         (WebCore::GraphicsContext::setStrokePattern):
1752         (WebCore::GraphicsContext::setFillPattern):
1753         (WebCore::GraphicsContext::setStrokeGradient):
1754         (WebCore::GraphicsContext::setFillGradient):
1755
1756         All of the GraphicsContext functions that take a Color should now
1757         also take a ColorSpace.
1758         * platform/graphics/GraphicsContext.h:
1759
1760         Added new member variables stokeColorSpace and fillColorSpace.
1761         * platform/graphics/GraphicsContextPrivate.h:
1762         (WebCore::GraphicsContextState::GraphicsContextState):
1763
1764         Attempt to keep the Cairo port building with all of the massive
1765         changes to GraphicsContext.
1766         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1767         (WebCore::GraphicsContext::fillRect):
1768         (WebCore::GraphicsContext::setPlatformFillColor):
1769         (WebCore::GraphicsContext::setPlatformStrokeColor):
1770         (WebCore::GraphicsContext::fillRoundedRect):
1771
1772
1773         * platform/graphics/cg/GraphicsContextCG.cpp:
1774         (WebCore::sRGBColorSpaceRef): New static function that returns a
1775         CGColorSpaceRef for the sRGB color space.
1776         (WebCore::deviceRGBColorSpaceRef): New static function that returns
1777         a CGColorSpaceRef for the device RGB color space.
1778
1779         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and
1780         sets the fill color to the specified color in the given ColorSpace.
1781         (WebCore::setCGStrokeColor): Same, but for stroke.
1782
1783         (WebCore::setCGFillColorSpace): New static to set the
1784         CGFillColorSpace to the given ColorSpace
1785         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1786
1787         Send ColorSpaces when appropriate, set ColorSpaces when
1788         appropriate, and check ColorSpaces when appropriate.
1789         (WebCore::GraphicsContext::GraphicsContext):
1790         (WebCore::GraphicsContext::drawRect):
1791         (WebCore::GraphicsContext::drawLine):
1792         (WebCore::GraphicsContext::fillPath):
1793         (WebCore::GraphicsContext::strokePath):
1794         (WebCore::GraphicsContext::fillRect):
1795         (WebCore::GraphicsContext::fillRoundedRect):
1796         (WebCore::GraphicsContext::strokeRect):
1797         (WebCore::GraphicsContext::drawLineForText):
1798         (WebCore::GraphicsContext::setPlatformStrokeColor):
1799         (WebCore::GraphicsContext::setPlatformFillColor):
1800
1801         Attempt to keep Haiku building.
1802         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1803         (WebCore::GraphicsContext::fillRect):
1804         (WebCore::GraphicsContext::fillRoundedRect):
1805         (WebCore::GraphicsContext::setPlatformStrokeColor):
1806         (WebCore::GraphicsContext::setPlatformFillColor):
1807
1808         Attempt to keep QT building.
1809         * platform/graphics/qt/GraphicsContextQt.cpp:
1810         (WebCore::GraphicsContext::fillRect):
1811         (WebCore::GraphicsContext::fillRoundedRect):
1812         (WebCore::GraphicsContext::setPlatformStrokeColor):
1813         (WebCore::GraphicsContext::setPlatformFillColor):
1814
1815         Attempt to keep Wince building.
1816         * platform/graphics/wince/GraphicsContextWince.cpp:
1817         (WebCore::GraphicsContext::fillRect):
1818         (WebCore::GraphicsContext::setPlatformFillColor):
1819         (WebCore::GraphicsContext::setPlatformStrokeColor):
1820         (WebCore::GraphicsContext::clearRect):
1821         (WebCore::GraphicsContext::fillRoundedRect):
1822         (WebCore::GraphicsContext::setPlatformShadow):
1823
1824         Attempt to keep WX building.
1825         * platform/graphics/wx/GraphicsContextWx.cpp:
1826         (WebCore::GraphicsContext::fillRect):
1827         (WebCore::GraphicsContext::fillRoundedRect):
1828         (WebCore::GraphicsContext::setPlatformStrokeColor):
1829         (WebCore::GraphicsContext::setPlatformFillColor):
1830
1831         Added functions colorSpace() and setColorSpace()
1832         * rendering/style/RenderStyle.h:
1833         (WebCore::InheritedFlags::colorSpace):
1834         (WebCore::InheritedFlags::setColorSpace):
1835
1836         The ColorSpace is stored here.
1837         * rendering/style/StyleRareInheritedData.cpp:
1838         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1839         (WebCore::StyleRareInheritedData::operator==):
1840         * rendering/style/StyleRareInheritedData.h:
1841
1842         All of these call sites call GraphicsContext functions which now
1843         require ColorSpaces.
1844         * editing/SelectionController.cpp:
1845         (WebCore::SelectionController::paintCaret):
1846         * html/canvas/CanvasRenderingContext2D.cpp:
1847         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1848         * html/canvas/CanvasStyle.cpp:
1849         (WebCore::CanvasStyle::applyStrokeColor):
1850         (WebCore::CanvasStyle::applyFillColor):
1851         * inspector/InspectorController.cpp:
1852         (WebCore::drawOutlinedQuad):
1853         * page/FrameView.cpp:
1854         (WebCore::FrameView::paintContents):
1855         * platform/ScrollbarTheme.h:
1856         (WebCore::ScrollbarTheme::paintScrollCorner):
1857         * platform/ScrollbarThemeComposite.cpp:
1858         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1859         * platform/graphics/Image.cpp:
1860         (WebCore::Image::fillWithSolidColor):
1861         * platform/graphics/mac/FontMac.mm:
1862         (WebCore::Font::drawGlyphs):
1863         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1864         (WebCore::MediaPlayerPrivate::paint):
1865         * rendering/EllipsisBox.cpp:
1866         (WebCore::EllipsisBox::paint):
1867         * rendering/InlineFlowBox.cpp:
1868         (WebCore::InlineFlowBox::paintTextDecorations):
1869         * rendering/InlineTextBox.cpp:
1870         (WebCore::updateGraphicsContext):
1871         (WebCore::paintTextWithShadows):
1872         (WebCore::InlineTextBox::paint):
1873         (WebCore::InlineTextBox::paintSelection):
1874         (WebCore::InlineTextBox::paintCompositionBackground):
1875         (WebCore::InlineTextBox::paintDecoration):
1876         (WebCore::InlineTextBox::paintTextMatchMarker):
1877         (WebCore::InlineTextBox::paintCompositionUnderline):
1878         * rendering/InlineTextBox.h:
1879         * rendering/RenderBlock.cpp:
1880         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1881         (WebCore::RenderBlock::fillVerticalSelectionGap):
1882         (WebCore::RenderBlock::fillLeftSelectionGap):
1883         (WebCore::RenderBlock::fillRightSelectionGap):
1884         * rendering/RenderBoxModelObject.cpp:
1885         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1886         (WebCore::RenderBoxModelObject::paintBoxShadow):
1887         * rendering/RenderFileUploadControl.cpp:
1888         (WebCore::RenderFileUploadControl::paintObject):
1889         * rendering/RenderFrameSet.cpp:
1890         (WebCore::RenderFrameSet::paintColumnBorder):
1891         (WebCore::RenderFrameSet::paintRowBorder):
1892         * rendering/RenderImage.cpp:
1893         (WebCore::RenderImage::paintReplaced):
1894         * rendering/RenderLayer.cpp:
1895         (WebCore::RenderLayer::paintScrollCorner):
1896         (WebCore::RenderLayer::paintResizer):
1897         * rendering/RenderListBox.cpp:
1898         (WebCore::RenderListBox::paintItemForeground):
1899         (WebCore::RenderListBox::paintItemBackground):
1900         * rendering/RenderListMarker.cpp:
1901         (WebCore::RenderListMarker::paint):
1902         * rendering/RenderObject.cpp:
1903         (WebCore::RenderObject::drawLineForBoxSide):
1904         (WebCore::RenderObject::drawArcForBoxSide):
1905         * rendering/RenderReplaced.cpp:
1906         (WebCore::RenderReplaced::paint):
1907         * rendering/RenderScrollbarTheme.cpp:
1908         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1909         * rendering/RenderThemeMac.mm:
1910         (WebCore::RenderThemeMac::paintMenuListButton):
1911         * rendering/RenderView.cpp:
1912         (WebCore::RenderView::paintBoxDecorations):
1913         * rendering/RenderWidget.cpp:
1914         (WebCore::RenderWidget::paint):
1915         * rendering/SVGInlineTextBox.cpp:
1916         (WebCore::SVGInlineTextBox::paintSelection):
1917         * svg/graphics/SVGPaintServerGradient.cpp:
1918         (WebCore::SVGPaintServerGradient::setup):
1919         * svg/graphics/SVGPaintServerSolid.cpp:
1920         (WebCore::SVGPaintServerSolid::setup):
1921
1922 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1923
1924         Reviewed by Timothy Hatcher.
1925
1926         Web Inspector: Speed up syntax highlighter
1927         https://bugs.webkit.org/show_bug.cgi?id=31291
1928
1929         * inspector/front-end/SourceFrame.js:
1930         (WebInspector.SourceFrame.prototype._loaded):
1931         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1932         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1933         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1934         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1935         (WebInspector.CSSSourceSyntaxHighlighter):
1936         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1937
1938 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1939
1940         Reviewed by Eric Seidel.
1941
1942         Remove session storage setting
1943         https://bugs.webkit.org/show_bug.cgi?id=31279
1944
1945         Remove session storage from Settings.  It was added temporarily so we could
1946         disable it by default at runtime in Chromium.  We now disable these things in a
1947         different way, so it's time to remove it.  Qt also depended on this setting for
1948         a short period of time, but after talking to them we agreed that it should be
1949         removed.
1950
1951         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1952
1953         * page/DOMWindow.cpp:
1954         (WebCore::DOMWindow::sessionStorage):
1955         * page/Settings.cpp:
1956         (WebCore::Settings::Settings):
1957         * page/Settings.h:
1958
1959 2009-11-10  Dan Bernstein  <mitz@apple.com>
1960
1961         Reviewed by Eric Carlson and Darin Adler.
1962
1963         WebCore part of making full-screen video pause during scrubbing.
1964
1965         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1966         and HTMLMediaElement::endScrubbing().
1967
1968 2009-11-10  Anton Muhin  <antonm@chromium.org>
1969
1970         Reviewed by Adam Barth.
1971
1972         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1973         https://bugs.webkit.org/show_bug.cgi?id=31051
1974
1975         * bindings/v8/V8GCController.cpp:
1976         (WebCore::V8GCController::gcEpilogue):
1977         (WebCore::V8GCController::checkMemoryUsage):
1978         * bindings/v8/V8GCController.h:
1979         * bindings/v8/V8Proxy.cpp:
1980         (WebCore::V8Proxy::evaluate):
1981         (WebCore::V8Proxy::runScript):
1982         (WebCore::V8Proxy::callFunction):
1983
1984 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1985
1986         Reviewed by Darin Adler.
1987
1988         Allow custom memory allocation control for the part of loader directory in WebCore
1989         https://bugs.webkit.org/show_bug.cgi?id=31161
1990
1991         Inherits the following classes from Noncopyable because these are instantiated
1992         by 'new' and these are no need to be copyable:
1993
1994         class Request - WebCore/loader/loader.cpp:100
1995         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1996         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1997         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1998         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1999         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2000
2001         Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2002         MainThreadBridge is instantiated by 'new' in
2003         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2004
2005         ThreadableLoaderClient's inheriting has been changed to public.
2006
2007         * loader/ImageLoader.cpp:
2008         * loader/ProgressTracker.cpp:
2009         * loader/RedirectScheduler.cpp:
2010         * loader/Request.h:
2011         * loader/ThreadableLoaderClient.h:
2012         * loader/WorkerThreadableLoader.h:
2013         * loader/appcache/ApplicationCacheHost.h:
2014         * loader/appcache/ApplicationCacheStorage.h:
2015
2016 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2017
2018         Reviewed by Eric Seidel.
2019
2020         https://bugs.webkit.org/show_bug.cgi?id=31047
2021         [GTK] Failing test media/video-played-ranges-1.html
2022
2023         WebKit coding style fixes.
2024
2025         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2026         (WebCore::mediaPlayerPrivateMessageCallback):
2027         (WebCore::MediaPlayerPrivate::naturalSize):
2028         (WebCore::MediaPlayerPrivate::paint):
2029         (WebCore::mimeTypeCache):
2030
2031 2009-11-10  Oliver Hunt  <oliver@apple.com>
2032
2033         Remove build failure introduced by earlier build fix.
2034
2035         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2036
2037 2009-11-10  Oliver Hunt  <oliver@apple.com>
2038
2039         Is this the last build fix? grep tells me yes.
2040
2041         * bindings/v8/custom/V8DocumentCustom.cpp:
2042         (WebCore::CALLBACK_FUNC_DECL):
2043
2044 2009-11-10  Oliver Hunt  <oliver@apple.com>
2045
2046         Hopefully the last one.  Why aren't these autogenerated?
2047
2048         * bindings/v8/V8DOMWrapper.cpp:
2049         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
2050         (WebCore::V8DOMWrapper::getTemplate):
2051         (WebCore::V8DOMWrapper::convertToV8Object):
2052
2053 2009-11-10  Oliver Hunt  <oliver@apple.com>
2054
2055         Another chrome build fix.
2056
2057         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
2058         (WebCore::CALLBACK_FUNC_DECL):
2059
2060 2009-11-10  Oliver Hunt  <oliver@apple.com>
2061
2062         Yet another chrome buildfix
2063
2064         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2065         (WebCore::CALLBACK_FUNC_DECL):
2066         * bindings/v8/custom/V8WebGLArrayCustom.h:
2067         (WebCore::constructCanvasArray):
2068         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2069         (WebCore::CALLBACK_FUNC_DECL):
2070         (WebCore::INDEXED_PROPERTY_GETTER):
2071         (WebCore::INDEXED_PROPERTY_SETTER):
2072         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2073         (WebCore::CALLBACK_FUNC_DECL):
2074         (WebCore::INDEXED_PROPERTY_GETTER):
2075         (WebCore::INDEXED_PROPERTY_SETTER):
2076         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2077         (WebCore::CALLBACK_FUNC_DECL):
2078         (WebCore::INDEXED_PROPERTY_GETTER):
2079         (WebCore::INDEXED_PROPERTY_SETTER):
2080         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
2081         (WebCore::CALLBACK_FUNC_DECL):
2082         (WebCore::vertexAttribAndUniformHelperf):
2083         (WebCore::uniformHelperi):
2084         (WebCore::uniformMatrixHelper):
2085         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2086         (WebCore::CALLBACK_FUNC_DECL):
2087         (WebCore::INDEXED_PROPERTY_GETTER):
2088         (WebCore::INDEXED_PROPERTY_SETTER):
2089         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2090         (WebCore::CALLBACK_FUNC_DECL):
2091         (WebCore::INDEXED_PROPERTY_GETTER):
2092         (WebCore::INDEXED_PROPERTY_SETTER):
2093         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2094         (WebCore::CALLBACK_FUNC_DECL):
2095         (WebCore::INDEXED_PROPERTY_GETTER):
2096         (WebCore::INDEXED_PROPERTY_SETTER):
2097         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2098         (WebCore::CALLBACK_FUNC_DECL):
2099         (WebCore::INDEXED_PROPERTY_GETTER):
2100         (WebCore::INDEXED_PROPERTY_SETTER):
2101
2102 2009-11-10  Oliver Hunt  <oliver@apple.com>
2103
2104         Chrome build fix.
2105
2106         * bindings/v8/V8Index.h:
2107
2108 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2109
2110         Reviewed by Reviewed by Jan Alonzo.
2111
2112         https://bugs.webkit.org/show_bug.cgi?id=30901
2113         [Gtk] Need to de-lint the Atk a11y code
2114
2115         Removal of various and sundry style-violating nits.
2116
2117         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2118
2119 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2120
2121         Reviewed by Jan Alonzo.
2122
2123         https://bugs.webkit.org/show_bug.cgi?id=31047
2124         [GTK] Failing test media/video-played-ranges-1.html
2125
2126         Fix playback rate setter by remembering the rate was changed. Also
2127         correctly handle reverse playback by doing a seek from end to
2128         beginning of the media.
2129
2130         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
2131         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2132         (WebCore::MediaPlayerPrivate::currentTime):
2133         (WebCore::MediaPlayerPrivate::seek):
2134         (WebCore::MediaPlayerPrivate::hasAudio):
2135         (WebCore::MediaPlayerPrivate::setVolume):
2136         (WebCore::MediaPlayerPrivate::setRate):
2137         (WebCore::MediaPlayerPrivate::updateStates):
2138         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2139
2140 2009-11-10  Oliver Hunt  <oliver@apple.com>
2141
2142         Reviewed by Maciej Stachowiak.
2143
2144         Rename 3D Canvas related classes to use WebGL prefix
2145         https://bugs.webkit.org/show_bug.cgi?id=29095
2146
2147         Automatic rename of all WebGL related types from Canvas* to
2148         WebGL* per more recent version of the WebGL spec.
2149
2150         Due to the automatic rename I've removed the 600+ line change list.
2151
2152 2009-11-09  Dirk Schulze  <krit@webkit.org>
2153
2154         Reviewed by Oliver Hunt.
2155
2156         SVG feDisplacementMap is not implemented
2157         [https://bugs.webkit.org/show_bug.cgi?id=31255]
2158
2159         This is the implementation of the SVG filter effect
2160         feDisplacementMap.
2161
2162         Test: svg/filters/feDisplacementMap.svg
2163
2164         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
2165         (WebCore::FEDisplacementMap::apply):
2166
2167 2009-11-09  Kent Tamura  <tkent@chromium.org>
2168
2169         Reviewed by Darin Adler.
2170
2171         Add a comment about null strings and hash functions.
2172         https://bugs.webkit.org/show_bug.cgi?id=29118
2173
2174         * platform/text/StringHash.h:
2175
2176 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2177
2178         Reviewed by Darin Adler.
2179
2180         Compiler warnings in InspectorResource.h
2181         https://bugs.webkit.org/show_bug.cgi?id=29231
2182
2183         Fix compilation warnings by removing addition operation on an enum type.
2184
2185         * inspector/InspectorResource.h:
2186         (WebCore::InspectorResource::):
2187         (WebCore::InspectorResource::Changes::hasChange):
2188         (WebCore::InspectorResource::Changes::set):
2189         (WebCore::InspectorResource::Changes::setAll):
2190
2191 2009-11-09  Anders Carlsson  <andersca@apple.com>
2192
2193         Reviewed by Darin Adler and Dan Bernstein.
2194
2195         <rdar://problem/7328395>
2196         https://bugs.webkit.org/show_bug.cgi?id=31277
2197
2198         When an object tag's style changes (for example when child nodes are added/removed),
2199         reuse its Frame (if it has one) instead of creating multiple Frames.
2200
2201         Test: fast/dom/HTMLObjectElement/children-changed.html
2202
2203         * loader/FrameLoader.cpp:
2204         (WebCore::FrameLoader::requestObject):
2205
2206 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2207
2208         Reviewed by Kenneth Rohde Christiansen.
2209
2210         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2211         since adjustment of RW-section base address will be needed for all new symbian
2212         tool chains, specifically for arm and gcc compilation targets.
2213         Also, change target address to 0xE00000 to be sufficient for all targets.
2214
2215         * WebCore.pro:
2216
2217 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2218
2219         Reviewed by Timothy Hatcher.
2220
2221         Web Inspector: Crash when inspecting
2222         WebCore\manual-tests\inspector\dom-mutation.html
2223
2224         https://bugs.webkit.org/show_bug.cgi?id=31259
2225
2226         * inspector/InspectorDOMAgent.cpp:
2227         (WebCore::InspectorDOMAgent::handleEvent):
2228
2229 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2230
2231         Reviewed by Kenneth Rohde Christiansen.
2232
2233         [Qt] Few classes have virtual functions but non-virtual destructor
2234         https://bugs.webkit.org/show_bug.cgi?id=31269
2235
2236         No new tests as there is no functional change.
2237
2238         * platform/qt/QWebPageClient.h:
2239         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2240
2241 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2242
2243         Reviewed by Kenneth Rohde Christiansen.
2244
2245         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2246         https://bugs.webkit.org/show_bug.cgi?id=31140
2247
2248         QtNetwork interprets null string as request to remove the header, not add it.
2249         Replace null values with empty values before passing them to QtNetwork.
2250
2251         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2252
2253         * platform/network/qt/ResourceRequestQt.cpp:
2254         (WebCore::ResourceRequest::toNetworkRequest):
2255
2256 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2257
2258         Reviewed by Kevin Ollivier.
2259
2260         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2261         simply ignored before resulting in transparent areas being black in PNG
2262         images for example.
2263
2264         https://bugs.webkit.org/show_bug.cgi?id=30823
2265
2266         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2267         (WebCore::RGBA32Buffer::asNewNativeImage):
2268
2269 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2270
2271         Reviewed by Kenneth Rohde Christiansen.
2272
2273         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2274         https://bugs.webkit.org/show_bug.cgi?id=31040
2275
2276         No new tests as there is no functional change.
2277
2278         * dom/Document.cpp:
2279         (WebCore::Document::recalcStyleSelector):
2280         * editing/TextIterator.cpp:
2281         (WebCore::pushFullyClippedState):
2282         * editing/VisibleSelection.cpp:
2283         (WebCore::VisibleSelection::appendTrailingWhitespace):
2284         * html/HTMLLinkElement.cpp:
2285         (WebCore::HTMLLinkElement::process):
2286         * loader/RedirectScheduler.cpp:
2287         (WebCore::RedirectScheduler::mustLockBackForwardList):
2288         * loader/appcache/ApplicationCacheGroup.cpp:
2289         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2290         * platform/graphics/qt/FontCacheQt.cpp:
2291         (WebCore::FontPlatformDataCacheKey::computeHash):
2292         * rendering/RenderBlock.cpp:
2293         (WebCore::RenderBlock::handleRunInChild):
2294         * rendering/RenderBox.cpp:
2295         (WebCore::RenderBox::calcHeight):
2296         * rendering/RenderTextControlMultiLine.cpp:
2297         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2298         * rendering/style/RenderStyle.cpp:
2299         (WebCore::RenderStyle::diff):
2300         * svg/SVGAnimateElement.cpp:
2301         (WebCore::parseNumberValueAndUnit):
2302         * svg/SVGAnimationElement.cpp:
2303         (WebCore::SVGAnimationElement::startedActiveInterval):
2304         * svg/SVGPreserveAspectRatio.cpp:
2305         (WebCore::SVGPreserveAspectRatio::getCTM):
2306
2307 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2308
2309         Reviewed by Dimitri Glazkov.
2310
2311         Win chromium is slow to draw transparent texts
2312         https://bugs.webkit.org/show_bug.cgi?id=31258
2313
2314         Clip graphics context to reduce calculation.
2315
2316         No new tests because this change only affects performance.
2317
2318         * platform/graphics/chromium/FontChromiumWin.cpp:
2319         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2320         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2321
2322 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2323
2324         Reviewed by Darin Adler.
2325
2326         showTree(CounterNode*) generates too little info and has too many spaces.
2327         https://bugs.webkit.org/show_bug.cgi?id=31212
2328
2329         No new tests as the change has no functional effect it is just for
2330         improved debugging.
2331
2332         * rendering/CounterNode.cpp:
2333         (WebCore::showTreeAndMark):
2334         Changed to also show addresses of parent, next and previous
2335         siblings.
2336
2337 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2338
2339         Reviewed by Darin Adler.
2340
2341         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2342         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2343
2344         https://bugs.webkit.org/show_bug.cgi?id=31083
2345
2346         No new tests; implementation is unchanged.
2347
2348         * page/Frame.cpp:
2349         (WebCore::Frame::setUseSecureKeyboardEntry):
2350         * page/mac/FrameMac.mm:
2351
2352 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2353
2354         Reviewed by Jan Alonzo.
2355
2356         Make XP_UNIX tests consistent
2357         https://bugs.webkit.org/show_bug.cgi?id=31250
2358
2359         No new tests as there is no functional change.
2360
2361         * plugins/PluginView.cpp:
2362         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2363         instead of the value of the macro
2364
2365         * plugins/gtk/PluginViewGtk.cpp:
2366         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2367         defined instead of using the PLATFORM macro to be consistent
2368         (WebCore::PluginView::getValue): Ditto.
2369
2370 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2371
2372         Reviewed by Darin Adler.
2373
2374         Thunk to the main thread from ~Database to deref Database's m_document.
2375
2376         If the Database was the Document's last referrer, then ~Document occurs on the
2377         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2378         ASSERT in debug builds.
2379
2380         * storage/Database.cpp:
2381         (WebCore::derefDocument):
2382         (WebCore::Database::~Database):
2383
2384 2009-11-09  Mark Mentovai  <mark@chromium.org>
2385
2386         Reviewed by Dan Bernstein.
2387
2388         Track "can have scrollbar" state within FrameView independently of the
2389         individual scrollbar states in ScrollView.
2390
2391         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2392         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2393         edit mode.
2394
2395         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2396         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2397
2398         Test: fast/overflow/scrollbar-restored.html
2399
2400         * WebCore.base.exp:
2401         * page/FrameView.cpp:
2402         (WebCore::FrameView::FrameView):
2403         (WebCore::FrameView::resetScrollbars):
2404         (WebCore::FrameView::setCanHaveScrollbars):
2405         (WebCore::FrameView::updateCanHaveScrollbars):
2406         (WebCore::FrameView::layout):
2407         * page/FrameView.h:
2408         * platform/ScrollView.h:
2409
2410 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2411
2412         Reviewed by Timothy Hatcher.
2413
2414         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2415         https://bugs.webkit.org/show_bug.cgi?id=31257
2416
2417         * inspector/front-end/SourceFrame.js:
2418
2419 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2420
2421         Reviewed by Timothy Hatcher.
2422
2423         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2424         https://bugs.webkit.org/show_bug.cgi?id=31252
2425
2426         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2427
2428         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2429
2430         * inspector/front-end/ConsoleView.js:
2431         (WebInspector.ConsoleView.prototype._promptKeyDown):
2432         * inspector/front-end/utilities.js:
2433         ():
2434         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2435
2436 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2437
2438         Reviewed by Kenneth Rohde Christiansen.
2439
2440         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2441         https://bugs.webkit.org/show_bug.cgi?id=31208
2442
2443         After r42483, the credentials are no longer passed to the network request
2444         in the URL of the request.
2445         Pass the credentials from XMLHTTPRequest to the network request, the same
2446         way that other ports do.
2447
2448         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2449
2450         * platform/network/qt/ResourceHandleQt.cpp:
2451         (WebCore::ResourceHandle::start):
2452         (WebCore::ResourceHandle::loadResourceSynchronously):
2453
2454 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2455
2456         Unreviewed.
2457
2458         https://bugs.webkit.org/show_bug.cgi?id=31161
2459
2460         Roll back r50657 because it breaks the MAC builds.
2461
2462         * loader/ImageLoader.cpp:
2463         * loader/ProgressTracker.cpp:
2464         * loader/RedirectScheduler.cpp:
2465         * loader/Request.h:
2466         * loader/ThreadableLoaderClient.h:
2467         * loader/WorkerThreadableLoader.h:
2468         * loader/appcache/ApplicationCacheHost.h:
2469         * loader/appcache/ApplicationCacheStorage.h:
2470         * loader/icon/IconDatabaseClient.h:
2471
2472 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2473
2474         Reviewed by Darin Adler.
2475
2476         Allow custom memory allocation control for the part of loader directory in WebCore
2477         https://bugs.webkit.org/show_bug.cgi?id=31161
2478
2479         Inherits the following classes from Noncopyable because these are instantiated
2480         by 'new' and these are no need to be copyable:
2481
2482         class Request - WebCore/loader/loader.cpp:100
2483         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2484         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2485         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2486         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2487         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2488         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2489
2490         Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
2491         MainThreadBridge is instantiated by 'new' in
2492         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2493
2494         ThreadableLoaderClient's inheriting has been changed to public.
2495
2496         * loader/ImageLoader.cpp:
2497         * loader/ProgressTracker.cpp:
2498         * loader/RedirectScheduler.cpp:
2499         * loader/Request.h:
2500         * loader/ThreadableLoaderClient.h:
2501         * loader/WorkerThreadableLoader.h:
2502         * loader/appcache/ApplicationCacheHost.h:
2503         * loader/appcache/ApplicationCacheStorage.h:
2504         * loader/icon/IconDatabaseClient.h:
2505
2506 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2507
2508         Reviewed by Darin Adler.
2509
2510         Allow custom memory allocation control for WebCore's DocLoader
2511         https://bugs.webkit.org/show_bug.cgi?id=31163
2512
2513         Inherits DocLoader class from Noncopyable because it is
2514         instantiated by 'new' in WebCore/dom/Document.cpp:370 and
2515         it is no need to be copyable.
2516
2517         * loader/DocLoader.h:
2518
2519 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2520
2521         Reviewed by Darin Adler.
2522
2523         Allow custom memory allocation control for WebCore's Tokenizer
2524         https://bugs.webkit.org/show_bug.cgi?id=31162
2525
2526         Inherits Tokenizer class from Noncopyable because (its child class)
2527         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
2528         and it is no need to be copyable.
2529
2530         * dom/Tokenizer.h:
2531
2532 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2533
2534         Reviewed by Darin Adler.
2535
2536         Allow custom memory allocation control for WebCore's DeleteButtonController
2537         https://bugs.webkit.org/show_bug.cgi?id=31105
2538
2539         Inherits DeleteButtonController class from Noncopyable because it is
2540         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2541         it is no need to be copyable.
2542
2543         * editing/DeleteButtonController.h:
2544
2545 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2546
2547         Reviewed by Jan Alonzo.
2548
2549         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2550         https://bugs.webkit.org/show_bug.cgi?id=30482
2551
2552         Expose Page::tabKeyCyclesThroughElements as a property of
2553         WebKitWebView.
2554
2555         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2556
2557         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2558         (WebCore::singleCharacterString):
2559
2560 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2561
2562         Reviewed by Xan Lopez.
2563
2564         https://bugs.webkit.org/show_bug.cgi?id=25415
2565         [GTK][ATK] Please implement support for get_text_at_offset
2566
2567         Fix a crasher that occurred with text which included newline
2568         chars in the markup.
2569
2570         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2571         (convertUniCharToUTF8):
2572
2573 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2574
2575         Reviewed by Holger Freyther.
2576
2577         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2578         https://bugs.webkit.org/show_bug.cgi?id=31144
2579
2580         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2581         documents that end prematurely but are not considered invalid by QXmlStream.
2582         This is to stay compatible with the libxml2 implementation.
2583         However, that code path would be also hit in situations when it should not,
2584         i.e. the error would have already been caught and handled. As a result, the
2585         same error would be reported twice.
2586
2587         No new tests, because the problem is already covered by
2588         fast/parser/xml-declaration-missing-ending-mark.html.
2589
2590         * dom/XMLTokenizerQt.cpp:
2591         (WebCore::XMLTokenizer::doEnd):
2592
2593 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2594
2595         Reviewed by Pavel Feldman.
2596
2597         Web Inspector: Inspector should support copy() in the command line
2598         https://bugs.webkit.org/show_bug.cgi?id=31238
2599
2600         * inspector/InspectorBackend.cpp:
2601         (WebCore::InspectorBackend::copyText): Added.
2602         * inspector/InspectorBackend.h: Added copyText
2603         * inspector/InspectorBackend.idl: Added copyText
2604         * inspector/front-end/InjectedScript.js:
2605         (InjectedScript._copy): Added.
2606         (InjectedScript._ensureCommandLineAPIInstalled):
2607
2608 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2609
2610         Reviewed by Dimitri Glazkov.
2611
2612         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2613         https://bugs.webkit.org/show_bug.cgi?id=31226
2614
2615         Now checks to see what type of context is active and creates the
2616         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2617
2618         Added support for converting to SharedWorkers and SharedWorkerContexts.
2619
2620         Test: Existing layout tests cover this case (start passing in Chrome).
2621
2622         * bindings/v8/WorkerContextExecutionProxy.cpp:
2623         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2624         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2625         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2626         Added support for SHAREDWORKERCONTEXT.
2627         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2628         Added support for SharedWorker and SharedWorkerContext.
2629
2630 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2631
2632         Reviewed by Dimitri Glazkov.
2633
2634         https://bugs.webkit.org/show_bug.cgi?id=31224
2635         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2636
2637         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2638
2639         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2640         (WebCore::NAMED_PROPERTY_GETTER):
2641
2642 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2643
2644         Reviewed by Timothy Hatcher.
2645
2646         Web Inspector: "Search again" on scripts panel switches
2647         to the script this search started with.
2648
2649         https://bugs.webkit.org/show_bug.cgi?id=31243
2650
2651         * inspector/front-end/Panel.js:
2652         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2653
2654 2009-11-08  Kent Tamura  <tkent@chromium.org>
2655
2656         Reviewed by Darin Adler.
2657
2658         Simplify Icon interface.
2659         https://bugs.webkit.org/show_bug.cgi?id=31154
2660
2661         - Remove Icon::createIconForFile().  createIconForFiles() covers
2662           createIconForFile()'s role.
2663         - Remove FileChooser::chooseIcon()
2664         - Change the parameter types of FileChooser constructor and the
2665           factory method, String -> const Vector<String>&, in order to
2666           support initialization with multiple files.
2667         - Remove the icon loading code in IconChromiumWin.cpp, which
2668           doesn't work because of the sandbox.
2669
2670         No tests because it's just a refactoring.
2671
2672         * platform/FileChooser.cpp:
2673         (WebCore::FileChooser::FileChooser):
2674         (WebCore::FileChooser::create):
2675         (WebCore::FileChooser::chooseFile):
2676         (WebCore::FileChooser::chooseFiles):
2677         * platform/FileChooser.h:
2678         * platform/graphics/Icon.h:
2679         * platform/graphics/chromium/IconChromiumLinux.cpp:
2680         * platform/graphics/chromium/IconChromiumMac.cpp:
2681         * platform/graphics/chromium/IconChromiumWin.cpp:
2682         (WebCore::Icon::createIconForFiles):
2683         * platform/graphics/gtk/IconGtk.cpp:
2684         (WebCore::Icon::createIconForFiles):
2685         * platform/graphics/haiku/IconHaiku.cpp:
2686         * platform/graphics/mac/IconMac.mm:
2687         (WebCore::Icon::createIconForFiles):
2688         * platform/graphics/qt/IconQt.cpp:
2689         (WebCore::Icon::createIconForFiles):
2690         * platform/graphics/win/IconWin.cpp:
2691         (WebCore::Icon::createIconForFiles):
2692         * platform/graphics/wx/IconWx.cpp:
2693         * rendering/RenderFileUploadControl.cpp:
2694         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2695
2696 2009-11-08  Daniel Bates  <dbates@webkit.org>
2697
2698         Reviewed by Adam Barth.
2699
2700         https://bugs.webkit.org/show_bug.cgi?id=31098
2701
2702         Allows same-origin plugin-based content to load.
2703
2704         Test: http/tests/security/xssAuditor/object-src-inject.html
2705
2706         * page/XSSAuditor.cpp:
2707         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2708         (WebCore::XSSAuditor::canLoadObject): Ditto.
2709         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2710         (WebCore::XSSAuditor::isSameOriginResource): Added.
2711         * page/XSSAuditor.h:
2712
2713 2009-11-08  David Levin  <levin@chromium.org>
2714
2715         Reviewed by NOBODY (chromium build fix).
2716
2717         * platform/network/HTTPParsers.cpp:
2718         (WebCore::parseDate): Changed this to not
2719         use a date parser that needs ExecState passed.
2720
2721 2009-11-08  David Levin  <levin@chromium.org>
2722
2723         Unreviewed build fix for chromium.
2724
2725         * platform/graphics/skia/GraphicsContextSkia.cpp:
2726         (WebCore::GraphicsContext::fillPath):
2727         (WebCore::GraphicsContext::fillRect):
2728         (WebCore::GraphicsContext::strokePath):
2729         (WebCore::GraphicsContext::strokeRect):
2730
2731 2009-11-08  David Levin  <levin@chromium.org>
2732
2733         Unreviewed build fix for chromium.
2734
2735         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2736         Clean up GraphicsContext's current concept of ColorSpace
2737
2738         * platform/graphics/skia/GraphicsContextSkia.cpp:
2739         (WebCore::GraphicsContext::fillPath):
2740         (WebCore::GraphicsContext::fillRect):
2741         (WebCore::GraphicsContext::strokePath):
2742         (WebCore::GraphicsContext::strokeRect):
2743
2744 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2745
2746         Reviewed by Timothy Hatcher.
2747
2748         Web Inspector: [REGRESSION] committing style edit
2749         clears elements panel selection.
2750
2751         https://bugs.webkit.org/show_bug.cgi?id=31242
2752
2753         * inspector/front-end/ElementsTreeOutline.js:
2754         (WebInspector.ElementsTreeOutline.prototype.update):
2755         * inspector/front-end/StylesSidebarPane.js:
2756         (WebInspector.StylePropertyTreeElement.prototype.):
2757         (WebInspector.StylePropertyTreeElement.prototype):
2758
2759 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2760
2761         Reviewed by Holger Freyther.
2762
2763         ResourceRequest to be class instead of struct
2764         https://bugs.webkit.org/show_bug.cgi?id=30670
2765
2766         Started as a compilation fix for Symbian where the compiler makes a distinction between
2767         class and struct in function argument signatures.
2768         Changed all forward declarations of ResourceRequest to have class in the forward
2769         declaration instead of struct and changed the definition of ResourceRequest to be class
2770         and added access qualifiers where missing. Additionally two references of friend
2771         struct ResourceRequestBase changed to class instead.
2772
2773         * history/HistoryItem.h:
2774         * inspector/InspectorController.h:
2775         * inspector/InspectorResource.h:
2776         * loader/DocumentThreadableLoader.h:
2777         * loader/FrameLoaderClient.h:
2778         * loader/MainResourceLoader.h:
2779         * loader/ResourceLoadNotifier.h:
2780         * loader/SubresourceLoader.h:
2781         * loader/SubresourceLoaderClient.h:
2782         * loader/ThreadableLoader.h:
2783         * loader/WorkerThreadableLoader.h:
2784         * loader/appcache/ApplicationCache.h:
2785         * loader/appcache/ApplicationCacheHost.h:
2786         * platform/CrossThreadCopier.h:
2787         * platform/network/ResourceHandle.h:
2788         * platform/network/ResourceHandleClient.h:
2789         * platform/network/ResourceRequestBase.h:
2790         * platform/network/cf/ResourceRequest.h:
2791         * platform/network/cf/ResourceRequestCFNet.h:
2792         * platform/network/chromium/ResourceRequest.h:
2793         * platform/network/curl/ResourceRequest.h:
2794         * platform/network/qt/ResourceRequest.h:
2795         * platform/network/soup/ResourceRequest.h:
2796         * xml/XMLHttpRequest.h:
2797
2798 2009-11-08  Dan Bernstein  <mitz@apple.com>
2799
2800         Reviewed by Simon Fraser.
2801
2802         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2803         below FrameView::layout
2804         https://bugs.webkit.org/show_bug.cgi?id=31093
2805
2806         Test: fast/block/positioning/relative-positioned-inline-container.html
2807
2808         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2809         to mark the object for layout, doing so without marking its ancestors.
2810         However, RenderBlock::skipLeadingWhitespace and
2811         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2812         positioned inline container, causing it to be marked for layout without
2813         ever going back to give it layout, and thus layout could end with a
2814         dirty object still in the tree, leading to all sorts of badness.
2815
2816         The fix is to revert setStaticY() to not marking the object dirty, and
2817         instead do it in the call sites that require it, which are in
2818         RenderBlock and RenderFlexibleBox.
2819
2820         * rendering/RenderBlock.cpp:
2821         (WebCore::RenderBlock::adjustPositionedBlock):
2822         * rendering/RenderFlexibleBox.cpp:
2823         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2824         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2825         * rendering/RenderLayer.cpp:
2826         * rendering/RenderLayer.h:
2827         (WebCore::RenderLayer::setStaticY):
2828
2829 2009-11-07  Daniel Bates  <dbates@webkit.org>
2830
2831         Reviewed by Darin Adler.
2832
2833         https://bugs.webkit.org/show_bug.cgi?id=20780
2834
2835         Fixes an issue where the onchange event handler is not fired when the
2836         input field is autocompleted.
2837
2838         We cannot test this using DRT since DRT cannot emulate autocompletion.
2839         So, a manual-test is included.
2840
2841         Tests: manual-tests/autocompletion-fire-onchange.html
2842
2843         * manual-tests/autocompletion-fire-onchange.html: Added.
2844         * rendering/RenderTextControl.cpp:
2845         (WebCore::RenderTextControl::setInnerTextValue):
2846
2847 2009-11-07  Benjamin Otte  <otte@gnome.org>
2848
2849         Reviewed by Holger Freyther.
2850
2851         Mark redrawn areas on image surfaces as dirty.
2852
2853         This is required to conform to the Cairo API, but is currently only
2854         used by debugging tools like cairo-trace.
2855
2856         * platform/graphics/cairo/ImageBufferCairo.cpp:
2857         (WebCore::ImageBuffer::platformTransformColorSpace):
2858         (WebCore::putImageData):
2859
2860 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2861
2862         Reviewed by Xan Lopez.
2863
2864         https://bugs.webkit.org/show_bug.cgi?id=30878
2865         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2866
2867         If the end_offset is -1, use the String length as the end_offset.
2868
2869         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2870         (webkit_accessible_text_get_text):
2871
2872 2009-11-06  Beth Dakin  <bdakin@apple.com>
2873
2874         Reviewed by Adele Peterson.
2875
2876         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up
2877         GraphicsContext's current concept of ColorSpace
2878
2879         ColorSpace is now called ColorType. The variables on the state we
2880         appropriately re-named as well. I removed strokeColorSpace() and
2881         fillColorSpace() from GraphicsContext since they were never called.
2882
2883         * platform/graphics/GraphicsContext.cpp:
2884         (WebCore::GraphicsContext::setStrokeColor):
2885         (WebCore::GraphicsContext::setFillColor):
2886         (WebCore::GraphicsContext::setStrokePattern):
2887         (WebCore::GraphicsContext::setFillPattern):
2888         (WebCore::GraphicsContext::setStrokeGradient):
2889         (WebCore::GraphicsContext::setFillGradient):
2890         * platform/graphics/GraphicsContext.h:
2891         (WebCore::):
2892         * platform/graphics/GraphicsContextPrivate.h:
2893         (WebCore::GraphicsContextState::GraphicsContextState):
2894         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2895         (WebCore::GraphicsContext::fillPath):
2896         (WebCore::GraphicsContext::strokePath):
2897         * platform/graphics/cg/GraphicsContextCG.cpp:
2898         (WebCore::calculateDrawingMode):
2899         (WebCore::GraphicsContext::drawPath):
2900         (WebCore::GraphicsContext::fillPath):
2901         (WebCore::GraphicsContext::strokePath):
2902         (WebCore::GraphicsContext::fillRect):
2903         (WebCore::GraphicsContext::strokeRect):
2904         * platform/graphics/qt/GraphicsContextQt.cpp:
2905         (WebCore::GraphicsContext::fillPath):
2906         (WebCore::GraphicsContext::strokePath):
2907         (WebCore::GraphicsContext::fillRect):
2908         * platform/graphics/wince/GraphicsContextWince.cpp:
2909         (WebCore::GraphicsContext::fillPath):
2910         (WebCore::GraphicsContext::fillRect):
2911
2912 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2913
2914         Reviewed by Tim Hatcher.
2915
2916         Fixes <http://webkit.org/b/31177>.
2917         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2918
2919         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2920         places in the inspector can use editing in DataGrid (added a FIXME for
2921         some stuff that needs to be generalized).
2922
2923         Also added deleting functionality to DataGrid, and implemented it for
2924         Cookies and DOM Storage. The reason this patch is so big is because of
2925         the refactoring of editing code, which won't be used yet in a cross-datagrid
2926         way, but should be able to.
2927
2928         Additionally, moved the callbacks members from DOMStorageDataGrid to
2929         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
2930         make the architecture of DOM Storage look a lot more like the Cookies view.
2931
2932         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
2933         inspector from beeping at you when you delete an element.
2934
2935         * WebCore.gypi: Removed DOMStorageDataGrid.
2936         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2937         * inspector/front-end/CookieItemsView.js:
2938         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2939         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2940         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2941         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2942         * inspector/front-end/DOMStorageItemsView.js:
2943         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2944         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2945         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2946         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2947         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2948         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2949         * inspector/front-end/DataGrid.js:
2950         (WebInspector.DataGrid):
2951         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2952         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2953         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2954         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2955         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2956         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2957         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2958         * inspector/front-end/ElementsTreeOutline.js:
2959         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2960         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2961         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2962
2963 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2964
2965         Qt build fix: added an ExecState parameter.
2966
2967         * bridge/qt/qt_runtime.cpp:
2968         (JSC::Bindings::convertValueToQVariant):
2969         (JSC::Bindings::convertQVariantToValue):
2970
2971 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2972
2973         https://bugs.webkit.org/show_bug.cgi?id=31197
2974         Implemented a timezone cache not based on Mac OS X's notify_check API.
2975
2976         Updated for JavaScriptCore internal API change.
2977
2978         * bridge/qt/qt_runtime.cpp:
2979         (JSC::Bindings::convertValueToQVariant):
2980         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2981
2982         * platform/network/HTTPParsers.cpp:
2983         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2984         (This function probably shouldn't be using a JavaScript date parser
2985         to begin with, but oh well.)
2986
2987 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2988
2989         Reviewed by Adam Barth.
2990
2991         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2992         which affects Chromium only.
2993
2994         Changes to V8HTMLDocumentCustom.cpp are as below:-
2995         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2996            there was no calling javascript context. We now check for this case
2997            and pass in NULL to the HTMLDocument::open function which can handle
2998            a NULL document parameter.
2999         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
3000            had ASSERTS for a NULL caller frame, which was bogus as it would crash
3001            anyway. We now check for this case and return a failure.
3002
3003         Changes to V8DOMWindowCustom.cpp are as below:-
3004         1. Instead of failing the window.open call made by NPAPI for lack of a
3005            calling javascript context, we now use the entered context as the calling
3006            context.
3007
3008         Tests: plugins/document-open.html
3009                plugins/window-open.html
3010
3011         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3012         (WebCore::CALLBACK_FUNC_DECL):
3013         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3014         (WebCore::CALLBACK_FUNC_DECL):
3015
3016 2009-11-06  Steve Block  <steveblock@google.com>
3017
3018         Reviewed by Eric Seidel.
3019
3020         Geolocation error code UNKNOWN_ERROR is deprecated.
3021         https://bugs.webkit.org/show_bug.cgi?id=31184
3022
3023         Remove this error code from PositionError, both for use from C++ code and from the JS object.
3024
3025         Updated fast/dom/Geolocation/error.html to test this.
3026
3027         * page/PositionError.h: Modified.
3028         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
3029         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
3030         * page/Geolocation.cpp: Modified.
3031         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3032         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
3033         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
3034
3035 2009-11-06  Dirk Schulze  <krit@webkit.org>
3036
3037         Reviewed by Nikolas Zimmermann.
3038
3039         feMorphology filter is not implemented
3040         [https://bugs.webkit.org/show_bug.cgi?id=5863]
3041
3042         The Implementation of feMorphology.
3043
3044         Test: We have allready a test for feMorphology
3045               svg/W3C-SVG-1.1/filters-morph-01-f.svg
3046
3047         * svg/graphics/filters/SVGFEMorphology.cpp:
3048         (WebCore::FEMorphology::apply):
3049
3050 2009-11-06  Steve Block  <steveblock@google.com>
3051
3052         Reviewed by Eric Seidel.
3053
3054         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
3055         https://bugs.webkit.org/show_bug.cgi?id=31209
3056
3057         Build fix only. No new tests possible.
3058
3059         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
3060
3061 2009-11-06  Drew Wilson  <atwilson@chromium.org>
3062
3063         Reviewed by David Levin.
3064
3065         V8 bindings do not support SharedWorkers as event targets
3066         https://bugs.webkit.org/show_bug.cgi?id=31199
3067
3068         No new tests because existing layout tests suffice (they currently
3069         crash on Chromium)
3070
3071         * bindings/v8/V8DOMWrapper.cpp:
3072         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3073         Added clause to create a DOM wrapper for SharedWorkers.
3074
3075 2009-11-06  Anton Muhin  <antonm@chromium.org>
3076
3077         Reviewed by Adam Barth.
3078
3079         Do not unnecessarly synchronzie in weak reference callbacks.
3080         https://bugs.webkit.org/show_bug.cgi?id=31191
3081
3082         * bindings/v8/DOMData.h:
3083         (WebCore::DOMData::handleWeakObject):
3084
3085 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
3086
3087         Reviewed by Pavel Feldman.
3088
3089         Fix resource content search.
3090         https://bugs.webkit.org/show_bug.cgi?id=31202
3091
3092         * inspector/front-end/AbstractTimelinePanel.js:
3093         (WebInspector.AbstractTimelinePanel.prototype.refresh):
3094         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
3095         * inspector/front-end/TimelinePanel.js:
3096         (WebInspector.TimelineGraph.prototype.refresh):
3097
3098 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
3099
3100         Reviewed by Eric Seidel.
3101
3102         Fix ASSERT(currentStyle = renderStyle()).
3103         https://bugs.webkit.org/show_bug.cgi?id=31152
3104
3105         * dom/Element.cpp:
3106         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
3107
3108 2009-11-05  Alpha Lam  <hclam@chromium.org>
3109
3110         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
3111
3112         * bindings/v8/V8GCController.cpp:
3113         (WebCore::V8GCController::gcEpilogue):
3114         * bindings/v8/V8GCController.h:
3115         * bindings/v8/V8Proxy.cpp:
3116         (WebCore::V8Proxy::evaluate):
3117         (WebCore::V8Proxy::runScript):
3118         (WebCore::V8Proxy::callFunction):
3119
3120 2009-11-05  Adam Barth  <abarth@webkit.org>
3121
3122         Reviewed by Sam Weinig.
3123
3124         Cross-domain access to stylesheet text should not be allowed
3125         https://bugs.webkit.org/show_bug.cgi?id=20527
3126
3127         Check whether whether the current document can read the cssRules from
3128         the style sheet.  Firefox throws a security error here, but we return
3129         null instead because that's what we usually do in these cases.
3130
3131         Test: http/tests/security/cannot-read-cssrules-redirect.html
3132               http/tests/security/cannot-read-cssrules.html
3133
3134         * css/CSSStyleSheet.cpp:
3135         (WebCore::CSSStyleSheet::cssRules):
3136
3137 2009-11-05  Steve Block  <steveblock@google.com>
3138
3139         Reviewed by Eric Seidel.
3140
3141         If the Geolocation service fails to start, invoke the error callback asynchronously.
3142         https://bugs.webkit.org/show_bug.cgi?id=28276
3143
3144         All Geolocation callbacks must be invoked asynchronously.
3145         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
3146
3147         No new tests possible with current LayoutTestController.
3148
3149         * page/Geolocation.cpp:
3150         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
3151         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
3152         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
3153
3154 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3155
3156         Reviewed by Eric Seidel.
3157
3158         Removed the "this is part of the KDE project" comments from
3159         all *.h, *.cpp, *.idl, and *.pm files.
3160
3161         https://bugs.webkit.org/show_bug.cgi?id=31167
3162
3163         The maintenance and architecture page in the project wiki lists
3164         this as a task.
3165
3166         This change includes no changes or additions to test cases
3167         since the change affects only comments.
3168
3169         * bindings/scripts/CodeGeneratorV8.pm:
3170         * bindings/scripts/IDLParser.pm:
3171         * bindings/scripts/IDLStructure.pm:
3172         * css/CSSInheritedValue.cpp:
3173         * css/CSSInitialValue.cpp:
3174         * css/CSSMediaRule.cpp:
3175         * css/CSSNamespace.h:
3176         * css/CSSProperty.cpp:
3177         * css/CSSProperty.h:
3178         * css/CSSRuleList.cpp:
3179         * css/CSSRuleList.h:
3180         * css/CSSSelector.h:
3181         * css/CSSValueList.cpp:
3182         * css/FontValue.cpp:
3183         * css/MediaFeatureNames.cpp:
3184         * css/MediaFeatureNames.h:
3185         * css/Pair.h:
3186         * css/SVGCSSStyleSelector.cpp:
3187         * css/ShadowValue.cpp:
3188         * css/StyleSheet.cpp:
3189         * css/StyleSheetList.cpp:
3190         * css/maketokenizer:
3191         * dom/BeforeUnloadEvent.cpp:
3192         * dom/BeforeUnloadEvent.h:
3193         * dom/CSSMappedAttributeDeclaration.cpp:
3194         * dom/EventNames.cpp:
3195         * dom/EventTarget.cpp:
3196         * dom/MappedAttributeEntry.h:
3197         * dom/MouseRelatedEvent.h:
3198         * dom/RangeException.h:
3199         * dom/StyleElement.h:
3200         * dom/Tokenizer.h:
3201         * html/HTMLHeadElement.h:
3202         * html/HTMLHeadingElement.cpp:
3203         * html/HTMLHeadingElement.h:
3204         * html/HTMLHtmlElement.h:
3205         * html/HTMLImageLoader.h:
3206         * html/HTMLMetaElement.h:
3207         * html/HTMLModElement.cpp:
3208         * html/HTMLModElement.h:
3209         * html/HTMLOptionsCollection.cpp:
3210         * html/HTMLPlugInElement.cpp:
3211         * html/HTMLPreElement.cpp:
3212         * html/HTMLPreElement.h:
3213         * html/HTMLTableCellElement.cpp:
3214         * html/HTMLTableCellElement.h:
3215         * html/HTMLTableColElement.cpp:
3216         * html/HTMLTableColElement.h:
3217         * html/HTMLTablePartElement.cpp:
3218         * html/HTMLTablePartElement.h:
3219         * html/HTMLTitleElement.h:
3220         * page/MouseEventWithHitTestResults.h:
3221         * platform/StaticConstructors.h:
3222         * platform/text/AtomicStringImpl.h:
3223         * platform/text/qt/TextBreakIteratorQt.cpp:
3224         * rendering/AutoTableLayout.h:
3225         * rendering/CounterNode.cpp:
3226         * rendering/EllipsisBox.cpp:
3227         * rendering/EllipsisBox.h:
3228         * rendering/FixedTableLayout.cpp:
3229         * rendering/FixedTableLayout.h:
3230         * rendering/HitTestRequest.h:
3231         * rendering/HitTestResult.h:
3232         * rendering/InlineRunBox.h:
3233         * rendering/PointerEventsHitRules.cpp:
3234         * rendering/PointerEventsHitRules.h:
3235         * rendering/RenderBR.cpp:
3236         * rendering/RenderBR.h:
3237         * rendering/RenderButton.cpp:
3238         * rendering/RenderButton.h:
3239         * rendering/RenderFieldset.cpp:
3240         * rendering/RenderFrameSet.cpp:
3241         * rendering/RenderListItem.cpp:
3242         * rendering/RenderTableRow.cpp:
3243         * rendering/RenderView.h:
3244         * rendering/RootInlineBox.h:
3245         * rendering/SVGInlineTextBox.cpp:
3246         * rendering/SVGInlineTextBox.h:
3247         * rendering/TableLayout.h:
3248         * rendering/break_lines.h:
3249         * rendering/style/SVGRenderStyle.cpp:
3250         * rendering/style/SVGRenderStyle.h:
3251         * rendering/style/SVGRenderStyleDefs.cpp:
3252         * rendering/style/SVGRenderStyleDefs.h:
3253         * svg/GradientAttributes.h:
3254         * svg/LinearGradientAttributes.h:
3255         * svg/PatternAttributes.h:
3256         * svg/RadialGradientAttributes.h:
3257         * svg/SVGAElement.cpp:
3258         * svg/SVGAngle.idl:
3259         * svg/SVGAnimateColorElement.cpp:
3260         * svg/SVGAnimateColorElement.h:
3261         * svg/SVGAnimateElement.cpp:
3262         * svg/SVGAnimateElement.h:
3263         * svg/SVGAnimateTransformElement.h:
3264         * svg/SVGAnimatedPathData.cpp:
3265         * svg/SVGAnimatedPathData.h:
3266         * svg/SVGAnimatedPoints.cpp:
3267         * svg/SVGAnimatedPoints.h:
3268         * svg/SVGAnimationElement.cpp:
3269         * svg/SVGCircleElement.cpp:
3270         * svg/SVGClipPathElement.cpp:
3271         * svg/SVGColor.cpp:
3272         * svg/SVGColor.idl:
3273         * svg/SVGComponentTransferFunctionElement.cpp:
3274         * svg/SVGComponentTransferFunctionElement.h:
3275         * svg/SVGCursorElement.cpp:
3276         * svg/SVGDefsElement.cpp:
3277         * svg/SVGDescElement.cpp:
3278         * svg/SVGDescElement.h:
3279         * svg/SVGDocument.idl:
3280         * svg/SVGElement.idl:
3281         * svg/SVGElementInstanceList.cpp:
3282         * svg/SVGElementInstanceList.h:
3283         * svg/SVGEllipseElement.cpp:
3284         * svg/SVGExternalResourcesRequired.cpp:
3285         * svg/SVGFEBlendElement.cpp:
3286         * svg/SVGFEBlendElement.h:
3287         * svg/SVGFEColorMatrixElement.cpp:
3288         * svg/SVGFEColorMatrixElement.h:
3289         * svg/SVGFEComponentTransferElement.cpp:
3290         * svg/SVGFEComponentTransferElement.h:
3291         * svg/SVGFECompositeElement.cpp:
3292         * svg/SVGFECompositeElement.h:
3293         * svg/SVGFEFloodElement.cpp:
3294         * svg/SVGFEFloodElement.h:
3295         * svg/SVGFEFuncAElement.cpp:
3296         * svg/SVGFEFuncAElement.h:
3297         * svg/SVGFEFuncBElement.cpp:
3298         * svg/SVGFEFuncBElement.h:
3299         * svg/SVGFEFuncGElement.cpp:
3300         * svg/SVGFEFuncGElement.h:
3301         * svg/SVGFEFuncRElement.cpp:
3302         * svg/SVGFEFuncRElement.h:
3303         * svg/SVGFEGaussianBlurElement.cpp:
3304         * svg/SVGFEGaussianBlurElement.h:
3305         * svg/SVGFEImageElement.cpp:
3306         * svg/SVGFEMergeElement.cpp:
3307         * svg/SVGFEMergeElement.h:
3308         * svg/SVGFEMergeNodeElement.cpp:
3309         * svg/SVGFEOffsetElement.cpp:
3310         * svg/SVGFEOffsetElement.h:
3311         * svg/SVGFETileElement.cpp:
3312         * svg/SVGFETileElement.h:
3313         * svg/SVGFETurbulenceElement.cpp:
3314         * svg/SVGFETurbulenceElement.h:
3315         * svg/SVGFilterElement.cpp:
3316         * svg/SVGGElement.cpp:
3317         * svg/SVGGradientElement.cpp:
3318         * svg/SVGHKernElement.idl:
3319         * svg/SVGLangSpace.cpp:
3320         * svg/SVGLangSpace.h:
3321         * svg/SVGLength.cpp:
3322         * svg/SVGLength.h:
3323         * svg/SVGLength.idl:
3324         * svg/SVGLengthList.cpp:
3325         * svg/SVGLengthList.h:
3326         * svg/SVGLineElement.cpp:
3327         * svg/SVGLinearGradientElement.h:
3328         * svg/SVGList.h:
3329         * svg/SVGListTraits.h:
3330         * svg/SVGLocatable.h:
3331         * svg/SVGMaskElement.cpp:
3332         * svg/SVGMatrix.idl:
3333         * svg/SVGMetadataElement.cpp:
3334         * svg/SVGMetadataElement.h:
3335         * svg/SVGMetadataElement.idl:
3336         * svg/SVGNumber.idl:
3337         * svg/SVGNumberList.cpp:
3338         * svg/SVGNumberList.h:
3339         * svg/SVGPaint.cpp:
3340         * svg/SVGPathElement.cpp:
3341         * svg/SVGPathSeg.h:
3342         * svg/SVGPathSegArc.cpp:
3343         * svg/SVGPathSegArc.h:
3344         * svg/SVGPathSegClosePath.cpp:
3345         * svg/SVGPathSegClosePath.h:
3346         * svg/SVGPathSegCurvetoCubic.cpp:
3347         * svg/SVGPathSegCurvetoCubic.h:
3348         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3349         * svg/SVGPathSegCurvetoCubicSmooth.h:
3350         * svg/SVGPathSegCurvetoQuadratic.cpp:
3351         * svg/SVGPathSegCurvetoQuadratic.h:
3352         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3353         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3354         * svg/SVGPathSegLineto.cpp:
3355         * svg/SVGPathSegLineto.h:
3356         * svg/SVGPathSegLinetoHorizontal.cpp:
3357         * svg/SVGPathSegLinetoHorizontal.h:
3358         * svg/SVGPathSegLinetoVertical.cpp:
3359         * svg/SVGPathSegLinetoVertical.h:
3360         * svg/SVGPathSegMoveto.cpp:
3361         * svg/SVGPathSegMoveto.h:
3362         * svg/SVGPatternElement.cpp:
3363         * svg/SVGPoint.idl:
3364         * svg/SVGPointList.cpp:
3365         * svg/SVGPointList.h:
3366         * svg/SVGPolyElement.cpp:
3367         * svg/SVGPolygonElement.cpp:
3368         * svg/SVGPolygonElement.h:
3369         * svg/SVGPolylineElement.cpp:
3370         * svg/SVGPolylineElement.h:
3371         * svg/SVGPreserveAspectRatio.cpp:
3372         * svg/SVGPreserveAspectRatio.h:
3373         * svg/SVGRadialGradientElement.h:
3374         * svg/SVGRect.idl:
3375         * svg/SVGRectElement.cpp:
3376         * svg/SVGRenderingIntent.h:
3377         * svg/SVGSVGElement.idl:
3378         * svg/SVGScriptElement.cpp:
3379         * svg/SVGSetElement.cpp:
3380         * svg/SVGSetElement.h:
3381         * svg/SVGStopElement.cpp:
3382         * svg/SVGStringList.cpp:
3383         * svg/SVGStringList.h:
3384         * svg/SVGStylable.cpp:
3385         * svg/SVGStylable.h:
3386         * svg/SVGStyleElement.cpp:
3387         * svg/SVGStyleElement.h:
3388         * svg/SVGStyledElement.h:
3389         * svg/SVGStyledLocatableElement.cpp:
3390         * svg/SVGStyledLocatableElement.h:
3391         * svg/SVGStyledTransformableElement.cpp:
3392         * svg/SVGStyledTransformableElement.h:
3393         * svg/SVGSwitchElement.cpp:
3394         * svg/SVGSymbolElement.cpp:
3395         * svg/SVGTRefElement.cpp:
3396         * svg/SVGTSpanElement.cpp:
3397         * svg/SVGTSpanElement.h:
3398         * svg/SVGTests.h:
3399         * svg/SVGTextElement.cpp:
3400         * svg/SVGTextElement.h:
3401         * svg/SVGTextPathElement.cpp:
3402         * svg/SVGTextPositioningElement.cpp:
3403         * svg/SVGTextPositioningElement.h:
3404         * svg/SVGTitleElement.cpp:
3405         * svg/SVGTitleElement.h:
3406         * svg/SVGTransform.cpp:
3407         * svg/SVGTransform.h:
3408         * svg/SVGTransform.idl:
3409         * svg/SVGTransformList.cpp:
3410         * svg/SVGTransformList.h:
3411         * svg/SVGTransformable.h:
3412         * svg/SVGURIReference.h:
3413         * svg/SVGUnitTypes.h:
3414         * svg/SVGUseElement.cpp:
3415         * svg/SVGViewElement.cpp:
3416         * svg/SVGZoomAndPan.cpp:
3417         * svg/SVGZoomAndPan.h:
3418         * svg/SVGZoomEvent.cpp:
3419
3420 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3421
3422         Reviewed by Dimitri Glazkov.
3423
3424         REGRESSION Clean up security origin usage in DOM Storage.
3425         https://bugs.webkit.org/show_bug.cgi?id=31188
3426
3427         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3428         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3429
3430         Instead of having StorageAreaSync's constructor (which is called in the
3431         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3432         database identifier, simply have StorageAreaImpl pass the identifier into
3433         StorageAreaSync.
3434
3435         No test because there's no change in externally observable behavior.
3436
3437         * storage/StorageAreaImpl.cpp:
3438         (WebCore::StorageAreaImpl::StorageAreaImpl):
3439         * storage/StorageAreaImpl.h:
3440         * storage/StorageAreaSync.cpp:
3441         (WebCore::StorageAreaSync::create):
3442         (WebCore::StorageAreaSync::StorageAreaSync):
3443         * storage/StorageAreaSync.h:
3444
3445 2009-11-05  Scott Violet  <sky@google.com>
3446
3447         Reviewed by Dimitri Glazkov.
3448
3449         Need notification of scrolling frame
3450         https://bugs.webkit.org/show_bug.cgi?id=31145
3451
3452         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3453         the frame scrolls. This will be used to know when history state
3454         needs to be updated.
3455
3456         * loader/FrameLoaderClient.h:
3457         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3458         * page/FrameView.cpp:
3459         (WebCore::FrameView::valueChanged):
3460
3461 2009-11-05  Kenneth Russell  <kbr@google.com>
3462
3463         Reviewed by Dimitri Glazkov.
3464
3465         [V8] Update bindings to use new API for external arrays
3466         https://bugs.webkit.org/show_bug.cgi?id=31181
3467
3468         No new tests; covered by existing WebGL tests.
3469
3470         * bindings/v8/V8DOMWrapper.cpp:
3471         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3472         (WebCore::V8DOMWrapper::getTemplate):
3473         (WebCore::V8DOMWrapper::convertToV8Object):
3474         * bindings/v8/V8DOMWrapper.h:
3475         * bindings/v8/custom/V8CanvasArrayCustom.h:
3476         (WebCore::constructCanvasArray):
3477
3478 2009-11-05  Alpha Lam  <hclam@chromium.org>
3479
3480         Not reviewed, Chromium build fix.
3481
3482         50561 introduces a custom method for SVGMatrix, we need to implement
3483         this in V8.
3484
3485         * bindings/v8/custom/V8CustomBinding.h:
3486         Adding definition for V8SVGMatrixMultiply.
3487         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3488         (WebCore::CALLBACK_FUNC_DECL):
3489         Implement V8SVGMatrixMultiply according to the same method in JSC.
3490
3491 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3492
3493         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3494
3495         * page/DOMWindow.cpp:
3496         (WebCore::DOMWindow::sessionStorage):
3497         * page/Settings.cpp:
3498         (WebCore::Settings::Settings):
3499         (WebCore::Settings::setSessionStorageEnabled):
3500         * page/Settings.h:
3501         (WebCore::Settings::sessionStorageEnabled):
3502
3503 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3504
3505         Reviewed by Timothy Hatcher.
3506
3507         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=30884
3510
3511         Test: inspector/styles-iframe.html
3512
3513         * inspector/front-end/DOMAgent.js:
3514         (WebInspector.DOMNode):
3515         * inspector/front-end/InjectedScript.js:
3516         (InjectedScript.getStyles):
3517         (InjectedScript.getComputedStyle):
3518         (InjectedScript.addStyleSelector):
3519         * inspector/front-end/TestController.js:
3520         (WebInspector.TestController.prototype.notifyDone):
3521         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3522         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3523         (WebInspector.evaluateForTestInFrontend):
3524
3525 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3526
3527         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3528
3529         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3530         https://bugs.webkit.org/show_bug.cgi?id=31027
3531
3532         Tested by new fast/events/event-listener-map-rehash-crash.html.
3533
3534         EventListenerMap modified to store pointers to listener vectors:
3535         * dom/EventTarget.cpp:
3536         (WebCore::EventTargetData::~EventTargetData):
3537         (WebCore::EventTarget::addEventListener):
3538         (WebCore::EventTarget::removeEventListener):
3539         (WebCore::EventTarget::fireEventListeners):
3540         (WebCore::EventTarget::getEventListeners):
3541         (WebCore::EventTarget::removeAllEventListeners):
3542         * dom/EventTarget.h:
3543
3544         Usages updated after interface changes:
3545         * inspector/InspectorDOMAgent.cpp:
3546         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3547         * svg/SVGUseElement.cpp:
3548         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3549
3550 2009-11-05  Dan Kegel  <dank@chromium.org>
3551
3552         Reviewed by Dmitri Titov.
3553
3554         Add missing initialization for m_createdByParser.
3555         https://bugs.webkit.org/show_bug.cgi?id=31089
3556
3557         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3558
3559         * dom/ProcessingInstruction.cpp:
3560         (WebCore::ProcessingInstruction::ProcessingInstruction):
3561
3562 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3563
3564         Reviewed by Adam Barth.
3565
3566         DOM Storage runtime flag changes
3567         https://bugs.webkit.org/show_bug.cgi?id=30602
3568
3569         Part 2/2.
3570
3571         Revert my changes to Settings and instead implement DOM Storage enabling via
3572         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3573
3574         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3575         LayoutTest visible changes and thus no tests.
3576
3577         * bindings/v8/custom/V8CustomBinding.h:
3578         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3579         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3580         * page/DOMWindow.cpp:
3581         (WebCore::DOMWindow::sessionStorage):
3582         * page/DOMWindow.idl:
3583         * page/Settings.cpp:
3584         (WebCore::Settings::Settings):
3585         * page/Settings.h:
3586         * storage/Storage.cpp:
3587         (WebCore::Storage::setLocalStorageAvailable):
3588         (WebCore::Storage::localStorageAvailable):
3589         (WebCore::Storage::setSessionStorageAvailable):
3590         (WebCore::Storage::sessionStorageAvailable):
3591         * storage/Storage.h:
3592
3593 2009-11-05  Jian Li  <jianli@chromium.org>
3594
3595         Reviewed by Pavel Feldman.
3596
3597         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3598         https://bugs.webkit.org/show_bug.cgi?id=31108
3599
3600         * bindings/v8/V8AbstractEventListener.cpp:
3601         (WebCore::V8AbstractEventListener::invokeEventHandler):
3602         * bindings/v8/V8Utilities.cpp:
3603         (WebCore::reportException):
3604
3605 2009-11-05  Jian Li  <jianli@chromium.org>
3606
3607         Reviewed by Dmitri Titov.
3608
3609         We should not bubble up events if we drag something to an iframe that
3610         has an invalid source.
3611         https://bugs.webkit.org/show_bug.cgi?id=30469
3612
3613         Test: http/tests/misc/bubble-drag-events.html
3614
3615         * page/EventHandler.cpp:
3616         (WebCore::EventHandler::handleDragAndDropForTarget):
3617         (WebCore::EventHandler::updateDragAndDrop):
3618         (WebCore::EventHandler::cancelDragAndDrop):
3619         (WebCore::EventHandler::performDragAndDrop):
3620         * page/EventHandler.h:
3621         (WebCore::EventHandler::):
3622
3623 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3624
3625         Reviewed by Timothy Hatcher.
3626
3627         Web Inspector: speed up Timelines Clear by a factor of thousands.
3628
3629         https://bugs.webkit.org/show_bug.cgi?id=31160
3630
3631         * inspector/front-end/utilities.js:
3632         (Element.prototype.removeChildren):
3633
3634 2009-11-05  Anton Muhin  <antonm@chromium.org>
3635
3636         Reviewed by Adam Barth.
3637
3638         If high memory usage is detected, hint to V8 that it might be due
3639         to external objects retained by V8 objects.
3640         https://bugs.webkit.org/show_bug.cgi?id=31051
3641
3642         * bindings/v8/V8GCController.cpp:
3643         (WebCore::GetMemoryUsageInMB):
3644         (WebCore::V8GCController::gcEpilogue):
3645         (WebCore::V8GCController::checkMemoryUsage):
3646         * bindings/v8/V8GCController.h: