16f7296a87ad8986690caee2e0655b72280695f3
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-23  Jens Alfke  <snej@chromium.org>
2
3         Reviewed by Geoffrey Garen.
4
5         Change incorrect calls to the constructor "EventNames()" to the correct accessor
6         "eventNames()". This saves ~100 AtomicString lookups each time.
7         https://bugs.webkit.org/show_bug.cgi?id=31811
8
9         * dom/EventNames.h:  Make constructor private to prevent this from happening again.
10         * history/CachedFrame.cpp:
11         (WebCore::CachedFrameBase::restore):  EventNames() --> eventNames()
12         * html/HTMLFormControlElement.cpp:
13         (WebCore::HTMLFormControlElement::checkValidity):  EventNames() --> eventNames()
14         * loader/FrameLoader.cpp:
15         (WebCore::FrameLoader::stopLoading):  EventNames() --> eventNames()
16         (WebCore::FrameLoader::pageHidden):  EventNames() --> eventNames()
17         * page/DOMWindow.cpp:
18         (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):  EventNames() --> eventNames()
19
20 2009-11-23  Adam Langley  <agl@google.com>
21
22         Reviewed by Dmitry Titov.
23
24         Chromium Linux: Limit the stroke width and mitre limit.
25
26         Limit the stroke width and mitre limit that we'll pass into Skia to
27         avoid overflowing Skia's uint16_t glyph widths.
28
29         http://code.google.com/p/chromium/issues/detail?id=28250
30         https://bugs.webkit.org/show_bug.cgi?id=31747
31
32         * platform/graphics/skia/PlatformContextSkia.cpp:
33         (scalarBound):
34         (PlatformContextSkia::setupPaintForStroking):
35
36 2009-11-23  Alexey Proskuryakov  <ap@apple.com>
37
38         Reviewed by Oliver Hunt.
39
40         https://bugs.webkit.org/show_bug.cgi?id=31812
41         WebSocket code uses RefPtr::get() where it shouldn't
42
43         No change in funcitonality, just coding style correction.
44
45         * websockets/WebSocket.cpp:
46         (WebCore::WebSocket::~WebSocket):
47         * websockets/WebSocketChannel.cpp:
48         (WebCore::WebSocketChannel::connect):
49         (WebCore::WebSocketChannel::send):
50         (WebCore::WebSocketChannel::bufferedAmount):
51         (WebCore::WebSocketChannel::close):
52         (WebCore::WebSocketChannel::disconnect):
53         (WebCore::WebSocketChannel::didOpen):
54         (WebCore::WebSocketChannel::didClose):
55         (WebCore::WebSocketChannel::didReceiveData):
56         (WebCore::WebSocketChannel::didFail):
57
58 2009-11-23  Alexey Proskuryakov  <ap@apple.com>
59
60         Build fix.
61
62         * platform/network/cf/SocketStreamHandleCFNet.cpp:
63         (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): pacExecutionCallbackMainThread
64         is static, so it can't use member variables directly.
65
66 2009-11-23  Alexey Proskuryakov  <ap@apple.com>
67
68         Reviewed by Brady Eidson.
69
70         https://bugs.webkit.org/show_bug.cgi?id=31748
71         Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport
72
73         * platform/network/cf/SocketStreamHandle.h: Removed names from some void* arguments, since
74         they didn't carry useful information.
75
76         * platform/network/cf/SocketStreamHandleCFNet.cpp:
77         (WebCore::SocketStreamHandle::SocketStreamHandle): When we need an http-style URL, we actually
78         always need https.
79         (WebCore::SocketStreamHandle::scheduleStreams): Factored out from constructor, since streams
80         only get scheduled after PAC is fetched and executed asynchronously.
81         (WebCore::SocketStreamHandle::copyPACExecutionDescription): Return a description for event
82         source.
83         (WebCore::MainThreadPACCallbackInfo::MainThreadPACCallbackInfo): Forward callback to main thread.
84         (WebCore::SocketStreamHandle::pacExecutionCallback): Ditto.
85         (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): Ditto. To avoid code duplication,
86         we make the call even on Mac.
87         (WebCore::SocketStreamHandle::executePACFileURL): Make an async call to CFNetworkExecuteProxyAutoConfigurationURL.
88         (WebCore::SocketStreamHandle::removePACRunLoopSource): Once PAC execution is done or aborted,
89         we need to get rid of the event source.
90         (WebCore::SocketStreamHandle::chooseProxy): Use stored m_httpsURL.get.
91         (WebCore::SocketStreamHandle::chooseProxyFromArray): Factored out from chooseProxy - the
92         array may come directly from system configuration, or from PAC.
93         (WebCore::SocketStreamHandle::chooseProxy): Tiger version of this function is now completely
94         separate.
95         (WebCore::SocketStreamHandle::~SocketStreamHandle): Run loop source should be destroyed
96         before we get to the destructor.
97         (WebCore::SocketStreamHandle::platformClose): Destroy the run loop source, if PAC execution
98         is still in progress.
99
100 2009-11-23  Oliver Hunt  <oliver@apple.com>
101
102         Reviewed by Geoff Garen.
103
104         Don't leak the CGImage we create when drawing a sub image.
105
106         * platform/graphics/cg/ImageCG.cpp:
107         (WebCore::BitmapImage::draw):
108
109 2009-11-23  Adam Barth  <abarth@webkit.org>
110
111         Reviewed by Dimitri Glazkov.
112
113         [V8] Don't crash when OOM in creating isolated world
114         https://bugs.webkit.org/show_bug.cgi?id=31805
115
116         We need to add some more null checks to avoid crashing.  No new tests
117         because we don't have a good way to test out-of-memory bugs.
118
119         * bindings/v8/V8Proxy.cpp:
120         (WebCore::V8Proxy::evaluateInIsolatedWorld):
121         (WebCore::V8Proxy::evaluateInNewContext):
122         (WebCore::V8Proxy::setInjectedScriptContextDebugId):
123         * bindings/v8/V8Proxy.h:
124
125 2009-11-23  Dirk Schulze  <krit@webkit.org>
126
127         Reviewed by Nikolas Zimmermann.
128
129         This is the implementation of the filterRes attribute. It
130         helps the SVG developer to set the quality of a filter by
131         giving the width or height of filter.
132         This patch also sets the filter resolution to lower values
133         if a intermediate ImageBuffer size is bigger than the given
134         maximal size.
135         The maximal size is set to 5000x5000 by default. This is a
136         subjectiv decission. Everthing greater than this values gets
137         sensible slower. Values of 10000x10000 crashed on WebKitGtk.
138         For mobil devices a maximum size of 100x100 or 200x200 seems
139         to be reasonable.
140         The important fact on filter resolution is, that the output
141         size is still the size given by the <filter> element.
142
143         Tests: svg/filters/big-sized-filter-2.svg
144                svg/filters/big-sized-filter.svg
145                svg/filters/filterRes.svg
146
147         * platform/graphics/FloatRect.cpp:
148         (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
149         * platform/graphics/FloatRect.h:
150         (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
151         * platform/graphics/cairo/GraphicsContextCairo.cpp:
152         (WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for
153         calculation.
154         * platform/graphics/filters/FEBlend.cpp:
155         (WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
156         * platform/graphics/filters/FEColorMatrix.cpp:
157         (WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
158         * platform/graphics/filters/FEComponentTransfer.cpp:
159         (WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern
160         calculations.
161         * platform/graphics/filters/FEComposite.cpp:
162         (WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
163         * platform/graphics/filters/FEGaussianBlur.cpp:
164         (WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
165         * platform/graphics/filters/Filter.h: Add the abbility to change the quality
166         of a filter output.
167         (WebCore::Filter::filterResolution):
168         (WebCore::Filter::setFilterResolution):
169         (WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion
170         as well as the scaledSubRegion. It also searches for the biggest effect size.
171         We have to change the filter resolution, if one intermediate ImageBuffer size
172         doesn't fit in the maximal image size.
173         * platform/graphics/filters/FilterEffect.cpp:
174         (WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get
175         the right part of a previous effect result.
176         (WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get
177         the right part of a previous effect result.
178         (WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create
179         a new intermediate ImageBuffer for the result of the current effect.
180         * platform/graphics/filters/FilterEffect.h:
181         (WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the
182         filter effect.
183         (WebCore::FilterEffect::setScaledSubRegion):
184         (WebCore::FilterEffect::effectBoundaries): The original values of the
185         EffectElement for a second subRegion calculation.
186         (WebCore::FilterEffect::setEffectBoundaries):
187         * platform/graphics/filters/ImageBufferFilter.cpp:
188         (WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
189         * platform/graphics/filters/ImageBufferFilter.h:
190         (WebCore::ImageBufferFilter::maxImageSize):
191         (WebCore::ImageBufferFilter::calculateEffectSubRegion):
192         * platform/graphics/filters/SourceAlpha.cpp:
193         (WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect
194         intern calculations.
195         * platform/graphics/filters/SourceGraphic.cpp:
196         (WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect
197         intern calculations.
198         * svg/SVGFilterElement.cpp:
199         (WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute.
200         (WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current
201         filterResolution.
202         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
203         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save
204         values to effectBoundaries of the filter effect
205         * svg/graphics/SVGResourceFilter.cpp:
206         (WebCore::SVGResourceFilter::SVGResourceFilter):
207         (WebCore::shouldProcessFilter): Return signal if a neccessary value is zero.
208         (WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size
209         fits into the maximal image size, modifys scale factors if not and return a
210         bool: fits.
211         (WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to
212         filterResolution (given by FilterElement or calculated on to big image sizes).
213         Set the scale level to SVGFilter.
214         (WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter
215         is wrong.
216         * svg/graphics/SVGResourceFilter.h:
217         (WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement.
218         (WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides
219         a FilterResolution?
220         (WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal.
221         (WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
222         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
223         (WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations.
224         Kernel values are scaled to current filter resolution too.
225         * svg/graphics/filters/SVGFEFlood.cpp:
226         (WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
227         * svg/graphics/filters/SVGFEMerge.cpp:
228         (WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations.
229         Kernel values are scaled to current filter resolution too.
230         * svg/graphics/filters/SVGFEMorphology.cpp:
231         (WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations.
232         Kernel values are scaled to current filter resolution too.
233         * svg/graphics/filters/SVGFEOffset.cpp:
234         (WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
235         * svg/graphics/filters/SVGFETile.cpp:
236         (WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
237         * svg/graphics/filters/SVGFilter.cpp:
238         (WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests,
239         scaledSubRegion according to the current filterResolution and get the maximal image size.
240         * svg/graphics/filters/SVGFilter.h:
241         (WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement. 
242         (WebCore::SVGFilter::filterRegion): Use virtual for clarification.
243         (WebCore::SVGFilter::sourceImageRect): Use virtual for clarification.
244         (WebCore::SVGFilter::maxImageSize): Get the maximal image size.
245
246 2009-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
247
248         Reviewed by Kenneth Rohde Christiansen.
249
250         [Qt] Wrong runtime instance objects of wrapped QObjects may be used if
251         the wrapped object died before the gc removed the instance.
252
253         https://bugs.webkit.org/show_bug.cgi?id=31681
254
255         Before using a cached instance, verify that its wrapped QObject is
256         still alive.
257
258         * bridge/qt/qt_instance.cpp:
259         (JSC::Bindings::QtInstance::getQtInstance):
260         * bridge/qt/qt_instance.h:
261         (JSC::Bindings::QtInstance::hashKey):
262
263 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
264
265         Reviewed by Oliver Hunt.
266
267         ARIA: support aria-flowto
268         https://bugs.webkit.org/show_bug.cgi?id=31762
269
270         Test: platform/mac/accessibility/aria-flowto.html
271
272         * accessibility/AccessibilityObject.h:
273         (WebCore::AccessibilityObject::ariaOwnsElements):
274         (WebCore::AccessibilityObject::supportsARIAFlowTo):
275         (WebCore::AccessibilityObject::ariaFlowToElements):
276         * accessibility/AccessibilityRenderObject.cpp:
277         (WebCore::AccessibilityRenderObject::linkedUIElements):
278         (WebCore::AccessibilityRenderObject::supportsARIAFlowTo):
279         (WebCore::AccessibilityRenderObject::ariaFlowToElements):
280         * accessibility/AccessibilityRenderObject.h:
281         * html/HTMLAttributeNames.in:
282
283 2009-11-22  Nikolas Zimmermann  <nzimmermann@rim.com>
284
285         Not reviewed. Build fix for WML enabled builds.
286         Adopt WebCore API changes.
287
288         * wml/WMLAElement.cpp:
289         (WebCore::WMLAElement::defaultEventHandler):
290         * wml/WMLInputElement.cpp:
291         (WebCore::WMLInputElement::defaultEventHandler):
292
293 2009-11-22  Pavel Feldman  <pfeldman@chromium.org>
294
295         Reviewed by Timothy Hatcher.
296
297         Web Inspector: Introduce sidebar background on timeline panel in order
298         to prevent it from flickering on scroll.
299
300         https://bugs.webkit.org/show_bug.cgi?id=31789
301
302         * inspector/front-end/TimelinePanel.js:
303         (WebInspector.TimelinePanel):
304         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
305         (WebInspector.TimelinePanel.prototype._onScroll):
306         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
307         * inspector/front-end/inspector.css:
308
309 2009-11-22  Pavel Feldman  <pfeldman@chromium.org>
310
311         Reviewed by Timothy Hatcher.
312
313         Web Inspector: Reimplement TimelinePanel to make it fast:
314         - Extract grid and overview into separate files
315         - Make timeline create only divs for visible rows
316
317         https://bugs.webkit.org/show_bug.cgi?id=31784
318
319         * WebCore.gypi:
320         * WebCore.vcproj/WebCore.vcproj:
321         * inspector/front-end/AbstractTimelinePanel.js:
322         (WebInspector.AbstractTimelinePanel.prototype.createInterface):
323         (WebInspector.AbstractTimelinePanel.prototype.refresh):
324         (WebInspector.AbstractTimelinePanel.prototype.set calculator):
325         * inspector/front-end/TimelineGrid.js: Added.
326         (WebInspector.TimelineGrid):
327         (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
328         (WebInspector.TimelineGrid.prototype.updateDividers):
329         (WebInspector.TimelineGrid.prototype.addEventDivider):
330         (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
331         * inspector/front-end/TimelineOverviewPane.js: Added.
332         (WebInspector.TimelineOverviewPane):
333         (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked):
334         (WebInspector.TimelineOverviewPane.prototype.update):
335         (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth):
336         (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
337         (WebInspector.TimelineOverviewPane.prototype.reset):
338         (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
339         (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging):
340         (WebInspector.TimelineOverviewPane.prototype._dragWindow):
341         (WebInspector.TimelineOverviewPane.prototype._windowDragging):
342         (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
343         (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
344         (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
345         (WebInspector.TimelineOverviewPane.prototype._endWindowDragging):
346         (WebInspector.TimelineOverviewCalculator):
347         (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
348         (WebInspector.TimelineOverviewCalculator.prototype.reset):
349         (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
350         (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan):
351         (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
352         (WebInspector.TimelineCategoryTreeElement):
353         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
354         (WebInspector.TimelineCategoryGraph):
355         (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
356         (WebInspector.TimelineCategoryGraph.prototype.addChunk):
357         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
358         (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
359         * inspector/front-end/TimelinePanel.js:
360         (WebInspector.TimelinePanel):
361         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
362         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
363         (WebInspector.TimelinePanel.prototype._formatRecord):
364         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
365         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
366         (WebInspector.TimelinePanel.prototype.resize):
367         (WebInspector.TimelinePanel.prototype.reset):
368         (WebInspector.TimelinePanel.prototype.show):
369         (WebInspector.TimelinePanel.prototype._onScroll):
370         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
371         (WebInspector.TimelinePanel.prototype._refresh):
372         (WebInspector.TimelinePanel.prototype._refreshRecords):
373         (WebInspector.TimelinePanel.prototype._adjustScrollPosition):
374         (WebInspector.TimelineCategory):
375         (WebInspector.TimelineCalculator):
376         (WebInspector.TimelineCalculator.prototype.get boundarySpan):
377         (WebInspector.TimelineRecordListRow):
378         (WebInspector.TimelineRecordListRow.prototype.update):
379         (WebInspector.TimelineRecordGraphRow):
380         (WebInspector.TimelineRecordGraphRow.prototype.update):
381         * inspector/front-end/WebKit.qrc:
382         * inspector/front-end/inspector.css:
383         * inspector/front-end/inspector.html:
384
385 2009-11-22  Chris Evans  <cevans@chromium.org>
386
387         Reviewed by Adam Barth.
388
389         Disable access to file:/// directory listings
390         https://bugs.webkit.org/show_bug.cgi?id=31329
391
392         Deny access to directory listings. This needs doing in WebKit for
393         WebKit clients that do permit top-level navigation to file:///dir.
394         This matches Firefox, plus the existing Safari implementation (which
395         does not support any directory access at all). It will fix the
396         LayoutTest named below for Chromium.
397
398         Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
399
400         * page/SecurityOrigin.cpp: Deny access to directory listings.
401         (WebCore::SecurityOrigin::SecurityOrigin):
402         (WebCore::SecurityOrigin::canRequest):
403
404 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
405
406         Reviewed by Timothy Hatcher.
407
408         Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
409         https://bugs.webkit.org/show_bug.cgi?id=31400
410
411         Handle the following when on a Mac:
412
413           Ctrl+P = Previous (like Up arrow)
414           Ctrl+N = Next (like Down arrow)
415
416         No longer rerun autocompletion when just pushing a modifier key
417         like Control, Alt, Shift, or Meta.
418
419         Improved arrow key behavior with Multiline code in the Console, with the following behavior:
420
421           Up   = Previous Command if on First Line (caret moves to the end of the first line)
422                  otherwise default caret movement in text.
423           Down = Next Command if on Last Line (caret naturally moves to the end)
424                  otherwise default caret movement in text.
425
426         * inspector/front-end/TextPrompt.js:
427         (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts
428         (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line
429         (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line
430         (WebInspector.TextPrompt.prototype._upKeyPressed):
431         (WebInspector.TextPrompt.prototype._downKeyPressed):
432         (WebInspector.TextPrompt.prototype._moveBackInHistory):
433         (WebInspector.TextPrompt.prototype._moveForwardInHistory):
434
435 2009-11-21  Jessie Berlin  <jberlin@webkit.org>
436
437         Reviewed by Timothy Hatcher.
438
439         Adds a tooltip containing the full url of the resource to each element
440         in the Resources panel so that it is possible to quickly see the query
441         parameters.
442         https://bugs.webkit.org/show_bug.cgi?id=19103
443
444         * inspector/front-end/ResourcesPanel.js:
445         (WebInspector.ResourceSidebarTreeElement.prototype.refresh):
446         Set the tooltip to be the resource's url.
447
448 2009-11-21  Simon Fraser  <simon.fraser@apple.com>
449
450         Reviewed by Dan Bernstein.
451
452         CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
453         https://bugs.webkit.org/show_bug.cgi?id=31588
454         
455         In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
456         so that findRule() and deleteRule() work with these keywords.
457
458         * css/WebKitCSSKeyframesRule.cpp:
459         (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
460
461 2009-11-21  Daniel Bates  <dbates@webkit.org>
462
463         Reviewed by Eric Seidel.
464
465         https://bugs.webkit.org/show_bug.cgi?id=31647
466
467         Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
468
469         No functionality was changed. So, no new tests.
470
471         * dom/KeyboardEvent.cpp:
472         (WebCore::KeyboardEvent::~KeyboardEvent):
473         * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
474         (WebCore::KeyboardEvent::keyEvent):
475
476 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
477
478         Reviewed by Beth Dakin.
479
480         WAI-ARIA: add support for aria-owns
481         https://bugs.webkit.org/show_bug.cgi?id=31702
482
483         Re-organized how accessibilityAttributeNames are returned so 
484         that it's possible for an element to add an attribute based on 
485         a dynamic value. In this case, we only want to add AXOwn if the 
486         element actually supports aria-owns.
487   
488         Test: platform/mac/accessibility/aria-owns.html
489
490         * accessibility/AccessibilityObject.h:
491         (WebCore::AccessibilityObject::supportsARIAOwns):
492         (WebCore::AccessibilityObject::ariaOwnsElements):
493         * accessibility/AccessibilityRenderObject.cpp:
494         (WebCore::AccessibilityRenderObject::ariaOwnsElements):
495         (WebCore::AccessibilityRenderObject::supportsARIAOwns):
496         * accessibility/AccessibilityRenderObject.h:
497         * accessibility/mac/AccessibilityObjectWrapper.mm:
498         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
499         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
500         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
501         * html/HTMLAttributeNames.in:
502
503 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
504
505         Reviewed by Simon Fraser.
506
507         <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
508
509         * css/mediaControls.css:
510             Define closed caption toggle button.
511
512         * rendering/RenderMedia.cpp:
513         (WebCore::RenderMedia::updateControls):
514             Create closed caption toggle button in display order.
515
516         * rendering/RenderThemeMac.mm:
517         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
518             Don't require MediaControllerThemeQuickTime theme for captions toggle button.
519             No need to check if the movie has video, a closed captions track is a video
520             track.
521
522 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
523
524         Reviewed by Timothy Hatcher.
525
526         Web Inspector: Running code in the Console that ends with a
527         single line comment no longer produces a parse error.
528
529         * inspector/front-end/InjectedScript.js:
530         (InjectedScript._evaluateOn):
531
532 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
533
534         Reviewed by Beth Dakin.
535
536         WAI-ARIA: add support for 'math' role
537         https://bugs.webkit.org/show_bug.cgi?id=31706
538
539         * accessibility/AccessibilityObject.cpp:
540         * accessibility/AccessibilityObject.h:
541         * accessibility/mac/AccessibilityObjectWrapper.mm:
542
543 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
544
545         Reviewed by Kenneth Rohde Christiansen.
546
547         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
548         https://bugs.webkit.org/show_bug.cgi?id=30460
549
550         Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
551         It already refreshes plugins and reloads pages when necessary.
552
553         Tests: plugins/reloadplugins-and-pages.html
554                plugins/reloadplugins-no-pages.html
555
556         * plugins/PluginInfoStore.cpp:
557         (WebCore::refreshPlugins):
558
559 2009-11-20  Oliver Hunt  <oliver@apple.com>
560
561         Reviewed by Dave Hyatt.
562
563         <rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
564
565         Expose WebCore object serialization to WebKit.
566
567         * WebCore.base.exp:
568         * bindings/js/SerializedScriptValue.cpp:
569         (WebCore::SerializedScriptValue::~SerializedScriptValue):
570         (WebCore::SerializedScriptValue::create):
571         (WebCore::SerializedScriptValue::deserialize):
572         * bindings/js/SerializedScriptValue.h:
573
574 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
575
576         Reviewed by Tim Hatcher.
577
578         Fixes <http://webkit.org/b/31741>.
579         Web Inspector: User Entered Data on the console should show up no matter what filters.
580         
581         Always show .console-user-command-result, no matter what the filter say
582         we should do with the other classes.
583
584         * inspector/front-end/inspector.css:
585
586 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
587
588         Reviewed by Tim Hatcher.
589
590         Fixes <http://webkit.org/b/31700>.
591         Web Inspector: isMac should be in one central location + Cached.
592         
593         We should cache the value of isMac, and make the indexOf call in one
594         single location, because we are calling it from multiple places, and saving
595         the result can save us time, and make the call sites simpler.
596
597         * inspector/front-end/AbstractTimelinePanel.js:
598         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
599         * inspector/front-end/ConsoleView.js:
600         (WebInspector.ConsoleView.prototype._updateFilter):
601         * inspector/front-end/ElementsPanel.js:
602         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
603         * inspector/front-end/ScriptsPanel.js:
604         (WebInspector.ScriptsPanel):
605         * inspector/front-end/SourceFrame.js:
606         (WebInspector.SourceFrame.prototype._loaded):
607         * inspector/front-end/inspector.js:
608         (WebInspector.documentKeyDown):
609         (WebInspector.isMac):
610
611 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
612
613         Removed .DS_Store accidentally added in last (r51245).
614
615 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
616
617         Reviewed by Timothy Hatcher.
618
619         Web Inspector: Add Console Only Layout Mode
620         https://bugs.webkit.org/show_bug.cgi?id=30282
621
622         Adds a Console Panel, which allows for a Full size Console. This
623         extends the Drawer to the size of a Panel. This also fixes previous
624         resize issues with the Drawer.
625
626         * inspector/front-end/ConsolePanel.js: added.
627         (WebInspector.ConsolePanel):
628         (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
629         (WebInspector.ConsolePanel.prototype.show):
630         (WebInspector.ConsolePanel.prototype.hide):
631         * inspector/front-end/Drawer.js:
632         (WebInspector.Drawer):
633         (WebInspector.Drawer.prototype.set visibleView):
634         (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
635         (WebInspector.Drawer.prototype.show.animationFinished):
636         (WebInspector.Drawer.prototype.show):
637         (WebInspector.Drawer.prototype.hide.animationFinished):
638         (WebInspector.Drawer.prototype.hide):
639         (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
640         (WebInspector.Drawer.prototype.enterPanelMode):
641         (WebInspector.Drawer.prototype.exitPanelMode):
642         (WebInspector.Drawer.prototype.immediatelyExitPanelMode):
643         (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
644         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
645         (WebInspector.Drawer.prototype._animateDrawerHeight):
646         (WebInspector.Drawer.prototype._animationDuration):
647         (WebInspector.Drawer.prototype._startStatusBarDragging):
648         (WebInspector.Drawer.prototype._statusBarDragging):
649         (WebInspector.Drawer.prototype._endStatusBarDragging):
650
651         Miscellaneous changes and cleanup.
652
653         * English.lproj/localizedStrings.js: "Console" toolbar title.
654         * inspector/front-end/ConsoleView.js: removed unnecessary element reordering  
655         * inspector/front-end/Images/consoleIcon.png: added.
656         * inspector/front-end/inspector.css: added icon.
657         * inspector/front-end/inspector.html:
658         * inspector/front-end/inspector.js:
659         (WebInspector._createPanels): create console panel
660         (WebInspector.windowResize): resize drawer if necessary
661         (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
662         (WebInspector.animateStyle): start animation interval, returns the interval key
663         (WebInspector.toggleAttach): resize drawer if necessary
664         (WebInspector.showConsolePanel): restore the panel when the inspector restarts
665         (WebInspector.showProfileForURL): style fix
666
667         Restore the panel when the inspector restarts.
668
669         * inspector/InspectorController.cpp:
670         (WebCore::InspectorController::setWindowVisible):
671         (WebCore::InspectorController::specialPanelForJSName):
672         * inspector/InspectorFrontend.cpp:
673         (WebCore::InspectorFrontend::showPanel):
674
675         Build files.
676
677         * WebCore.gypi:
678         * WebCore.vcproj/WebCore.vcproj:
679         * inspector/front-end/WebKit.qrc:
680
681 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
682
683         Reviewed by Tim Hatcher.
684
685         Fixes <http://webkit.org/b/31699>.
686         Web Inspector: Should Cache Values of InspectorController.platform() and port().
687
688         Refactor the Inspector to cache the value of InspectorController.platform
689         and InspectorController.port, because those need to call into C++, they are
690         being called more and more as we add platform specific keyboard shortcuts, and
691         they shouldn't change in the lifecycle of the Web Inspector.
692
693         * inspector/front-end/AbstractTimelinePanel.js:
694         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
695         * inspector/front-end/ConsoleView.js:
696         (WebInspector.ConsoleView.prototype._updateFilter):
697         * inspector/front-end/ElementsPanel.js:
698         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
699         * inspector/front-end/ScriptsPanel.js:
700         (WebInspector.ScriptsPanel):
701         * inspector/front-end/SourceFrame.js:
702         (WebInspector.SourceFrame.prototype._loaded):
703         * inspector/front-end/inspector.js:
704         (WebInspector.get platform):
705         (WebInspector.get port):
706         (WebInspector.loaded):
707         (WebInspector.documentKeyDown):
708         (WebInspector.toolbarDragStart):
709
710 2009-11-20  Dirk Schulze  <krit@webkit.org>
711
712         Unreviewed build fix for filters enabled builds.
713
714         * platform/graphics/filters/FEColorMatrix.cpp:
715         (WebCore::FEColorMatrix::apply):
716         * platform/graphics/filters/FEComposite.cpp:
717         (WebCore::FEComposite::apply):
718         * platform/graphics/filters/SourceGraphic.cpp:
719         (WebCore::SourceGraphic::apply):
720         * svg/graphics/SVGResourceFilter.cpp:
721         (WebCore::SVGResourceFilter::applyFilter):
722         * svg/graphics/filters/SVGFEMerge.cpp:
723         (WebCore::FEMerge::apply):
724         * svg/graphics/filters/SVGFEOffset.cpp:
725         (WebCore::FEOffset::apply):
726         * svg/graphics/filters/SVGFETile.cpp:
727         (WebCore::FETile::apply):
728
729 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
730
731         Reviewed by Simon Fraser.
732
733         <rdar://problem/7389945> QTKit based media engine should not claim to support 
734         fullscreen on Leopard
735
736         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
737         (WebCore::MediaPlayerPrivate::supportsFullscreen):
738             Only return true on SnowLeopard for now.
739
740         * rendering/RenderThemeMac.mm:
741         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
742             No need to special case MediaFullscreenButtonPart as the default implementation 
743             asks the media engine if it supports fullscreen.
744
745 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
746
747         Reviewed by Simon Hausmann.
748
749         Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
750                  Girish Ramakrishnan <girish@forwardbias.in>
751         
752         [Qt] Implement support for rendering plugins on Qt/Mac when a page is used
753         without a QWebView or when inside QGraphicsWebView.
754         
755         Currently, the code provides the cgcontext of the PlatformPluginWidget to
756         the plugin. This approach does not work when we are printing, or using
757         QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
758         up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
759         of the QPaintDevice's context.
760         
761         To solve all cases and keep the code simple, we render the plugin to an
762         offscreen pixmap in all cases. This way, the plugin always renders to the
763         CGContext of the pixmap and we then use QPainter to blit the pixmap into
764         the QPaintDevice. We also create a fake window and set it's WindowRef in
765         NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
766         
767         Now, that's the theory. In practice, ATM, mouse events do not work when using
768         the fake window. So, setPlatformPluginWidget() is still called when using QWebView
769         so that there are no regressions after this patch. Once we get mouse events
770         working, setPlatformPluginWidget will be removed.
771         
772         https://bugs.webkit.org/show_bug.cgi?id=31183
773
774         * plugins/PluginView.cpp:
775         (WebCore::PluginView::PluginView):
776         * plugins/PluginView.h:
777         * plugins/mac/PluginViewMac.cpp:
778         (WebCore::PluginView::platformStart):
779         (WebCore::PluginView::platformDestroy):
780         (WebCore::PluginView::setNPWindowIfNeeded):
781         (WebCore::PluginView::updatePluginWidget):
782         (WebCore::PluginView::paint):
783         (WebCore::PluginView::invalidateRect):
784
785 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
786
787         Reviewed by Timothy Hatcher.
788
789         Web Inspector: Resync Resources Backend and Frontend
790         https://bugs.webkit.org/show_bug.cgi?id=31705
791
792         * inspector/front-end/Resource.js: resync enum values with backend
793         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
794
795 2009-11-19  Steve Block  <steveblock@google.com>
796
797         Reviewed by Darin Fisher.
798
799         Android port lacks configuration in Platform.h and config.h.
800         https://bugs.webkit.org/show_bug.cgi?id=31671
801
802         Build change only. No new tests possible.
803
804         * config.h: Modified. Added Android-specific configuration.
805
806 2009-11-20  Roland Steiner  <rolandsteiner@chromium.org>
807
808         Reviewed by Darin Adler.
809
810         Change default stylesheet to reset text indentation for ruby elements by default.
811         (https://bugs.webkit.org/show_bug.cgi?id=31247)
812
813         Test: fast/ruby/ruby-text-indent.html
814
815         * css/html.css: reset text-indent on <ruby> and <rt> elements
816
817 2009-11-19  Brian Weinstein  <bweinstein@apple.com>
818
819         Reviewed by Darin Adler.
820
821         Fixes <http://webkit.org/b/22754>.
822         Web Inspector: Keyboard shortcut for Element finder.
823
824         Use Command + Shift + C as a shortcut for Node Search, to 
825         match the Firebug shortcut to do the same thing.
826
827         * inspector/front-end/ElementsPanel.js:
828         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
829
830 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
831
832         Reviewed by Darin Adler.
833
834         https://bugs.webkit.org/show_bug.cgi?id=31690
835         Make SocketStreamHandleCFNet work on Windows
836
837         * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
838
839         * platform/network/ResourceHandle.h: Removed loaderRunLoop().
840
841         * platform/network/cf/LoaderRunLoopCF.cpp: Added.
842         (WebCore::emptyPerform):
843         (WebCore::runLoaderThread):
844         (WebCore::loaderRunLoop):
845         * platform/network/cf/LoaderRunLoopCF.h: Added.
846         Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
847         it's needed for more than just resource loading.
848
849         * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
850
851         * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
852
853         * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
854         main thread.
855         * platform/network/cf/SocketStreamHandleCFNet.cpp:
856         (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
857         inoperable main run loop.
858
859         (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo): 
860         (WebCore::SocketStreamHandle::readStreamCallback):
861         (WebCore::SocketStreamHandle::writeStreamCallback):
862         (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
863         (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
864         Forward stream events to main thread on Windows.
865
866 2009-11-19  Avi Drissman  <avi@chromium.org>
867
868         Reviewed by Darin Adler.
869
870         Quick style fix.
871         https://bugs.webkit.org/show_bug.cgi?id=27777
872
873         * platform/graphics/cg/PDFDocumentImage.cpp:
874
875 2009-11-19  Beth Dakin  <bdakin@apple.com>
876
877        Build fix. No review needed.
878
879         * platform/chromium/ScrollbarThemeChromium.cpp:
880         (WebCore::ScrollbarThemeChromium::paintTickmarks):
881         * rendering/RenderMediaControlsChromium.cpp:
882         (WebCore::paintMediaButton):
883
884 2009-11-19  Beth Dakin  <bdakin@apple.com>
885       
886        Build fix. No review needed.
887
888         * rendering/RenderThemeChromiumSkia.cpp:
889         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
890         (WebCore::RenderThemeChromiumSkia::paintRadio):
891         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
892         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
893         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
894
895 2009-11-19  Beth Dakin  <bdakin@apple.com>
896
897        Build fix. No review needed.
898
899         * platform/graphics/qt/StillImageQt.cpp:
900         (WebCore::StillImage::draw):
901         * platform/graphics/qt/StillImageQt.h:
902
903 2009-11-19  Beth Dakin  <bdakin@apple.com>
904
905        Build fix. No review needed.
906
907         * rendering/RenderThemeWin.cpp:
908         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
909         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
910         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
911
912 2009-11-19  Beth Dakin  <bdakin@apple.com>
913
914        Build fix. No review needed.
915
916         * plugins/PluginView.cpp:
917         (WebCore::PluginView::paintMissingPluginIcon):
918
919 2009-11-19  Beth Dakin  <bdakin@apple.com>
920
921         Build fix. No review needed.
922
923         * platform/graphics/win/ImageCGWin.cpp:
924         (WebCore::BitmapImage::getHBITMAPOfSize):
925         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
926
927 2009-11-19  Beth Dakin  <bdakin@apple.com>
928
929         Reviewed by Darin Adler.
930
931         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
932         color-correction work with untagged images
933
934         Image's draw(), drawPattern(), and fillWithSolidColor() functions 
935         now take a ColorSpace. A bunch of classes inherit from Image, so 
936         draw() and drawPattern() functions there must also take a 
937         ColorSpace.
938         * platform/graphics/Image.cpp:
939         (WebCore::Image::fillWithSolidColor):
940         (WebCore::Image::drawTiled):
941         * platform/graphics/Image.h:
942         * platform/graphics/BitmapImage.h:
943         * platform/graphics/GeneratedImage.cpp:
944         (WebCore::GeneratedImage::draw):
945         (WebCore::GeneratedImage::drawPattern):
946         * platform/graphics/GeneratedImage.h:
947         * platform/graphics/cg/PDFDocumentImage.cpp:
948         (WebCore::PDFDocumentImage::draw):
949         * platform/graphics/cg/PDFDocumentImage.h:
950         * svg/graphics/SVGImage.cpp:
951         (WebCore::SVGImage::draw):
952         * svg/graphics/SVGImage.h:
953
954         All of the drawImage() functions and drawTiled() functions of 
955         GraphicsContext now take a ColorSpace.
956         * platform/graphics/GraphicsContext.cpp:
957         (WebCore::GraphicsContext::drawImage):
958         (WebCore::GraphicsContext::drawTiledImage):
959         * platform/graphics/GraphicsContext.h:
960
961         This is where the actual work is done.
962         * platform/graphics/cg/ImageCG.cpp:
963         (WebCore::imageWithColorSpace): New static function that returns a 
964         copy of the given image in the given ColorSpace *IF* we should use 
965         the given ColorSpace. We will ignore the color space if the image 
966         is tagged and return 0. 
967         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to 
968         call imageWithColorSpace(). 
969         (WebCore::Image::drawPattern): Same.
970
971         Attempt to keep all ports building. 
972         * platform/graphics/cairo/ImageCairo.cpp:
973         (WebCore::BitmapImage::draw):
974         (WebCore::Image::drawPattern):
975         * platform/graphics/haiku/ImageHaiku.cpp:
976         (WebCore::BitmapImage::draw):
977         (WebCore::Image::drawPattern):
978         * platform/graphics/qt/ImageQt.cpp:
979         (WebCore::Image::drawPattern):
980         (WebCore::BitmapImage::draw):
981         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
982         * platform/graphics/skia/ImageSkia.cpp:
983         (WebCore::Image::drawPattern):
984         (WebCore::BitmapImage::draw):
985         (WebCore::BitmapImageSingleFrameSkia::draw):
986         * platform/graphics/wx/ImageWx.cpp:
987         (WebCore::BitmapImage::draw):
988         (WebCore::BitmapImage::drawPattern):
989
990         Callers of GraphicsContext's drawImage() and drawTiled() functions 
991         now need to send a ColorSpace.
992         * html/HTMLCanvasElement.cpp:
993         (WebCore::HTMLCanvasElement::paint):
994         * html/canvas/CanvasRenderingContext2D.cpp:
995         (WebCore::CanvasRenderingContext2D::drawImage):
996         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
997         * platform/ScrollView.cpp:
998         (WebCore::ScrollView::wheelEvent):
999         * platform/graphics/filters/FEColorMatrix.cpp:
1000         (WebCore::FEColorMatrix::apply):
1001         * platform/graphics/filters/FEComposite.cpp:
1002         (WebCore::FEComposite::apply):
1003         * platform/graphics/filters/SourceGraphic.cpp:
1004         (WebCore::SourceGraphic::apply):
1005         * platform/mac/ScrollbarThemeMac.mm:
1006         (WebCore::ScrollbarThemeMac::paint):
1007         * rendering/RenderBoxModelObject.cpp:
1008         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1009         (WebCore::RenderBoxModelObject::paintNinePieceImage):
1010         * rendering/RenderImage.cpp:
1011         (WebCore::RenderImage::paintReplaced):
1012         * rendering/RenderLayer.cpp:
1013         (WebCore::RenderLayer::paintResizer):
1014         * rendering/RenderListMarker.cpp:
1015         (WebCore::RenderListMarker::paint):
1016         * rendering/RenderSVGImage.cpp:
1017         (WebCore::RenderSVGImage::paint):
1018         * rendering/RenderWidget.cpp:
1019         (WebCore::RenderWidget::paint):
1020         * svg/graphics/SVGPaintServerPattern.cpp:
1021         (WebCore::SVGPaintServerPattern::setup):
1022         * svg/graphics/SVGResourceFilter.cpp:
1023         (WebCore::SVGResourceFilter::applyFilter):
1024         * svg/graphics/filters/SVGFEMerge.cpp:
1025         (WebCore::FEMerge::apply):
1026         * svg/graphics/filters/SVGFEOffset.cpp:
1027         (WebCore::FEOffset::apply):
1028         * svg/graphics/filters/SVGFETile.cpp:
1029         (WebCore::FETile::apply):
1030
1031 2009-11-19  Avi Drissman  <avi@chromium.org>
1032
1033         Reviewed by Darin Adler.
1034
1035         Properly create a CGImageRef on non-PLATFORM(MAC).
1036         https://bugs.webkit.org/show_bug.cgi?id=27777
1037
1038         * platform/graphics/cg/ImageSourceCG.cpp:
1039         (WebCore::sharedBufferGetBytesAtPosition):
1040         (WebCore::sharedBufferRelease):
1041         (WebCore::ImageSource::setData):
1042         * platform/graphics/cg/ImageSourceCG.h:
1043         * platform/graphics/cg/PDFDocumentImage.cpp:
1044         (WebCore::PDFDocumentImage::dataChanged):
1045
1046 2009-11-19  Oliver Hunt  <oliver@apple.com>
1047
1048         Reviewed by Dave Hyatt.
1049
1050         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
1051         https://bugs.webkit.org/show_bug.cgi?id=31656
1052
1053         Make sure we're a child of the painting root before drawing overflow features.
1054
1055         * manual-tests/user-drag-with-decorations.html: Added.
1056         * rendering/RenderBlock.cpp:
1057         (WebCore::RenderBlock::paint):
1058
1059 2009-11-19  Dmitry Titov  <dimich@chromium.org>
1060
1061         Not reviewed, attempt to fix Chromium build.
1062
1063         * rendering/RenderMediaControlsChromium.cpp:
1064         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
1065
1066 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
1067
1068         Reviewed by Darin Adler.
1069
1070         Do not assert when a high number is used for roman numerals in lists.
1071         https://bugs.webkit.org/show_bug.cgi?id=31652
1072
1073         Test: fast/lists/ol-start-roman.html
1074
1075         * rendering/RenderListMarker.cpp:
1076         (WebCore::toRoman): Increase the char array size.
1077
1078 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1079
1080         Rubber-stamped by Oliver Hunt.
1081
1082         Add translatable strings to cover validationMessage, after
1083         r51172. Already covered by existing test.
1084
1085         * platform/gtk/LocalizedStringsGtk.cpp:
1086         (WebCore::validationMessageValueMissingText):
1087         (WebCore::validationMessageTypeMismatchText):
1088         (WebCore::validationMessagePatternMismatchText):
1089         (WebCore::validationMessageTooLongText):
1090         (WebCore::validationMessageRangeUnderflowText):
1091         (WebCore::validationMessageRangeOverflowText):
1092         (WebCore::validationMessageStepMismatchText):
1093
1094 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1095
1096         Reviewed by Darin Adler.
1097
1098         Remove HAVE(FLOAT_H) guard
1099         https://bugs.webkit.org/show_bug.cgi?id=31661
1100
1101         WebCore has a dependency on float.h, there is
1102         no need to guard float.h.
1103
1104         No new tests as there is no functional change.
1105
1106         * html/HTMLInputElement.cpp: Remove include directive
1107         for float.h as it is included in MathExtras.h already.
1108
1109 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
1110
1111         Reviewed by Pavel Feldman.
1112
1113         Instrumentation should account for painting in compositing layers
1114         https://bugs.webkit.org/show_bug.cgi?id=31674
1115
1116         Add calls to InspectorTimelineAgent for painting into compositing layers,
1117         which is not accounted for in FrameView::paintContents().
1118
1119         * rendering/RenderLayerBacking.cpp:
1120         (WebCore::RenderLayerBacking::paintIntoLayer):
1121         Avoid fetching the FrameView multiple times.
1122         
1123         (WebCore::inspectorTimelineAgent):
1124         (WebCore::RenderLayerBacking::paintContents):
1125
1126 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
1127
1128         Reviewed by Dan Bernstein.
1129
1130         <rdar://problem/7035231>
1131         Support closed caption in <video> element
1132
1133         Test: media/media-captions.html
1134
1135         * WebCore.base.exp:
1136         * accessibility/AccessibilityMediaControls.cpp:
1137         (WebCore::AccessibilityMediaControl::controlTypeName):
1138             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
1139
1140         * css/CSSPrimitiveValueMappings.h:
1141         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1142             Add MediaToggleClosedCaptionsButtonPart.
1143
1144         * css/CSSSelector.cpp:
1145         (WebCore::CSSSelector::extractPseudoType):
1146             Define and match mediaControlsToggleClosedCaptionsButton.
1147
1148         * css/CSSSelector.h:
1149         (WebCore::CSSSelector::):
1150         * css/CSSStyleSelector.cpp:
1151         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1152             Define and match PseudoMediaControlsToggleClosedCaptions.
1153
1154         * css/CSSValueKeywords.in:
1155             Define and use media-toggle-closed-captions-button.
1156
1157         * css/mediaControls.css:
1158         * css/mediaControlsQuickTime.css:
1159             Add webkit-media-controls-toggle-closed-captions-button.
1160
1161         * html/HTMLMediaElement.cpp:
1162         (WebCore::HTMLMediaElement::HTMLMediaElement): 
1163             Initialize m_closedCaptionsVisible.
1164         (WebCore::HTMLMediaElement::loadInternal): 
1165             Set m_closedCaptionsVisible to false.
1166         (WebCore::HTMLMediaElement::hasClosedCaptions): 
1167         (WebCore::HTMLMediaElement::closedCaptionsVisible): 
1168         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): 
1169             New, captions internal methods.
1170         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): 
1171         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): 
1172         (WebCore::HTMLMediaElement::webkitHasClosedCaptions): 
1173             New, captions DOM API.
1174
1175         * html/HTMLMediaElement.h:
1176         * html/HTMLMediaElement.idl:
1177             Declare methods needed for captions API.
1178
1179         * platform/ThemeTypes.h:
1180             Add MediaToggleClosedCaptionsButtonPart.
1181
1182         * platform/android/LocalizedStringsAndroid.cpp:
1183         (WebCore::localizedMediaControlElementString):
1184         (WebCore::localizedMediaControlElementHelpText):
1185         (WebCore::localizedMediaTimeDescription):
1186             Add empty implmentations.
1187
1188         * platform/graphics/MediaPlayer.cpp:
1189         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
1190         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
1191             New, empty implementations of media engine closed caption functions.
1192         (WebCore::MediaPlayer::hasClosedCaptions):
1193         (WebCore::MediaPlayer::setClosedCaptionsVisible):
1194             New, call media engine closed caption functions.
1195
1196         * platform/graphics/MediaPlayer.h:
1197         * platform/graphics/MediaPlayerPrivate.h:
1198         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
1199         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
1200             Declare new media engine methods.
1201
1202         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1203         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1204         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
1205         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
1206             New, QTKit implementation of closed caption methods.
1207
1208         * platform/gtk/LocalizedStringsGtk.cpp:
1209         (WebCore::localizedMediaControlElementString):
1210         (WebCore::localizedMediaControlElementHelpText):
1211             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
1212
1213         * platform/mac/WebCoreSystemInterface.h:
1214         * platform/mac/WebCoreSystemInterface.mm:
1215             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
1216
1217         * rendering/MediaControlElements.cpp:
1218         (WebCore::MediaControlInputElement::MediaControlInputElement):
1219             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
1220         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
1221         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
1222         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
1223             New, implement the closed caption toggle button,
1224
1225         * rendering/MediaControlElements.h:
1226             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
1227             declare MediaControlToggleClosedCaptionsButtonElement.
1228
1229         * rendering/RenderMedia.cpp:
1230         (WebCore::RenderMedia::styleDidChange):
1231         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
1232         (WebCore::RenderMedia::createStatusDisplay):
1233         (WebCore::RenderMedia::updateControls):
1234         (WebCore::RenderMedia::forwardEvent):
1235         * rendering/RenderMedia.h:
1236             Deal with m_toggleClosedCaptionsButton.
1237
1238         * rendering/RenderTheme.cpp:
1239         (WebCore::RenderTheme::paint):
1240             Deal with MediaToggleClosedCaptionsButtonPart.
1241
1242         * rendering/RenderTheme.h:
1243         * rendering/RenderThemeMac.h:
1244             Declare paintMediaToggleClosedCaptionsButton.
1245
1246         * rendering/RenderThemeMac.mm:
1247         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
1248             New.
1249         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
1250             Don't render captions toggle button unless we are using the new theme, the
1251             movie has captions, and the movie is in a <video> element since we currently
1252             rely on QTKit to render the captions.
1253
1254         * rendering/style/RenderStyleConstants.h:
1255             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
1256
1257 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1258
1259         wx build fix. Add missing header.
1260
1261         * platform/wx/LocalizedStringsWx.cpp:
1262
1263 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
1264
1265         Reviewed by Darin Adler.
1266
1267         https://bugs.webkit.org/show_bug.cgi?id=31634
1268         Ignore realm for proxy protection spaces
1269
1270         Only affects WebSocket proxy authentication, cannot be tested in DRT.
1271
1272         * platform/network/ProtectionSpace.cpp:
1273         (WebCore::operator==):
1274         * platform/network/ProtectionSpaceHash.h:
1275         (WebCore::ProtectionSpaceHash::hash):
1276
1277 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
1278
1279         Reviewed by Simon Hausmann.
1280
1281         [Qt] Normalize signal and slot signatures.
1282
1283         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1284         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1285
1286 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
1287
1288         Reviewed by Pavel Feldman.
1289
1290         Store cookie domains in the WebInspector object
1291
1292         The cookie domains have been moved from StoragePanel into WebInspector.
1293         Also, the document URLs are now passed inside the WebInspector.addResource()
1294         payload rather than pushed directly from InspectorController.
1295         https://bugs.webkit.org/show_bug.cgi?id=31627
1296
1297         * inspector/InspectorController.cpp:
1298         (WebCore::InspectorController::populateScriptObjects):
1299         (WebCore::InspectorController::didFinishLoading):
1300         * inspector/InspectorFrontend.cpp:
1301         * inspector/InspectorFrontend.h:
1302         * inspector/InspectorResource.cpp:
1303         (WebCore::InspectorResource::createScriptObject):
1304         (WebCore::InspectorResource::updateScriptObject):
1305         * inspector/front-end/StoragePanel.js:
1306         (WebInspector.StoragePanel.prototype.reset):
1307         (WebInspector.StoragePanel.prototype.addCookieDomain):
1308         * inspector/front-end/inspector.js:
1309         (WebInspector.addResource):
1310         (WebInspector.addCookieDomain):
1311         (WebInspector.reset):
1312
1313 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1314
1315         Reviewed by Darin Adler.
1316
1317         Allow custom memory allocation control for the other part of platform directory in WebCore
1318         https://bugs.webkit.org/show_bug.cgi?id=31585
1319
1320         Inherits the following classes from FastAllocBase because these are
1321         instantiated by 'new':
1322
1323         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
1324         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
1325         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
1326         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
1327
1328         Inherits the following classes from Noncopyable because these are
1329         instantiated by 'new' and no need to be copyable:
1330
1331         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
1332         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
1333         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
1334
1335         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
1336         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
1337
1338         * platform/graphics/MediaPlayerPrivate.h:
1339         * platform/graphics/Path.h:
1340         * platform/graphics/qt/FontPlatformData.h:
1341         * platform/graphics/transforms/TransformationMatrix.h:
1342         * platform/image-decoders/ImageDecoder.h:
1343         * platform/network/NetworkStateNotifier.h:
1344         * platform/network/ResourceRequestBase.h:
1345         * platform/qt/CursorQt.cpp:
1346         * platform/text/RegularExpression.h:
1347
1348 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1349
1350         Unreviewed.
1351
1352         [Qt] Build fix for QtWebKit after r51172.
1353
1354         * platform/qt/Localizations.cpp:
1355         (WebCore::validationMessageValueMissingText):
1356         (WebCore::validationMessageTypeMismatchText):
1357         (WebCore::validationMessagePatternMismatchText):
1358         (WebCore::validationMessageTooLongText):
1359         (WebCore::validationMessageRangeUnderflowText):
1360         (WebCore::validationMessageRangeOverflowText):
1361         (WebCore::validationMessageStepMismatchText):
1362
1363 2009-11-18  Dan Bernstein  <mitz@apple.com>
1364
1365         Reviewed by Simon Fraser.
1366
1367         Fixed <rdar://problem/7398987> Assertion failure in
1368         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
1369         enclosed by a transformed layer
1370
1371         Tests: fast/layers/clip-rects-transformed-2.html
1372                fast/layers/clip-rects-transformed.html
1373
1374         * rendering/RenderLayer.cpp:
1375         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
1376         that is either transformed or composited. During painting and hit
1377         testing, when a transformed or composited layer is hit, it becomes the
1378         new root layer, which ultimately gets passed to calculateRects().
1379         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
1380         root layer to calculateRects(), and return the bounding box of the
1381         transformed rectangle.
1382         (WebCore::RenderLayer::selfClipRect): Ditto.
1383         * rendering/RenderLayer.h:
1384
1385 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1386
1387         Reviewed by Kenneth Rohde Christiansen.
1388
1389         [Qt] Remove support for Qt v4.3 or older versions
1390         https://bugs.webkit.org/show_bug.cgi?id=29469
1391
1392         No new tests as there is no change if compiled with 
1393         Qt v4.4 or later version.
1394
1395         * WebCore.pro:
1396         * dom/XMLTokenizerQt.cpp:
1397         (WebCore::EntityResolver::resolveUndeclaredEntity):
1398         (WebCore::XMLTokenizer::XMLTokenizer):
1399         (WebCore::XMLTokenizer::~XMLTokenizer):
1400         (WebCore::XMLTokenizer::doWrite):
1401         (WebCore::XMLTokenizer::startDocument):
1402         (WebCore::XMLTokenizer::parseDtd):
1403         * platform/graphics/qt/FontQt.cpp:
1404         * platform/graphics/qt/FontQt43.cpp: Removed.
1405         * platform/graphics/qt/ImageQt.cpp:
1406         * platform/network/ResourceHandleInternal.h:
1407         * platform/network/qt/QNetworkReplyHandler.cpp:
1408         * platform/network/qt/QNetworkReplyHandler.h:
1409         * platform/network/qt/ResourceHandleQt.cpp:
1410         (WebCore::ResourceHandle::start):
1411         (WebCore::ResourceHandle::cancel):
1412         (WebCore::ResourceHandle::loadResourceSynchronously):
1413         (WebCore::ResourceHandle::setDefersLoading):
1414         * platform/network/qt/ResourceRequest.h:
1415         * platform/network/qt/ResourceRequestQt.cpp:
1416         * platform/qt/ClipboardQt.cpp:
1417         (WebCore::ClipboardQt::clearData):
1418         * platform/qt/CookieJarQt.cpp:
1419         (WebCore::cookieJar):
1420         (WebCore::setCookies):
1421         (WebCore::cookies):
1422         (WebCore::cookiesEnabled):
1423         * platform/qt/PlatformKeyboardEventQt.cpp:
1424         (WebCore::keyIdentifierForQtKeyCode):
1425         (WebCore::windowsKeyCodeForKeyEvent):
1426         * platform/text/qt/TextBoundaries.cpp:
1427         * platform/text/qt/TextBreakIteratorQt.cpp:
1428         * plugins/qt/PluginDataQt.cpp:
1429         (WebCore::PluginData::initPlugins):
1430
1431 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
1432
1433         Reviewed by Darin Adler.
1434
1435         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
1436         Support for validationMessage attribute, as per HTML5 specs.
1437
1438         Test: fast/forms/validationMessage.html
1439
1440         * html/HTMLButtonElement.idl: validationMessage attribute
1441         * html/HTMLFieldSetElement.idl: validationMessage attribute
1442         * html/HTMLFormControlElement.cpp:
1443         * html/HTMLFormControlElement.h:
1444         * html/HTMLInputElement.idl: validationMessage attribute
1445         * html/HTMLSelectElement.idl: validationMessage attribute
1446         * html/HTMLTextAreaElement.idl: validationMessage attribute
1447         * html/ValidityState.cpp: new method to retrieve pertinent localized text
1448         * html/ValidityState.h:
1449         * page/mac/WebCoreViewFactory.h:
1450         * platform/LocalizedStrings.h:
1451         * platform/android/LocalizedStringsAndroid.cpp:
1452         * platform/gtk/LocalizedStringsGtk.cpp:
1453         * platform/haiku/LocalizedStringsHaiku.cpp:
1454         * platform/mac/LocalizedStringsMac.mm:
1455         * platform/wx/LocalizedStringsWx.cpp:
1456
1457 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1458
1459         Unreviewed.
1460
1461         Fix a typo. Remove the trailing semicolon
1462         from an include directive after r51137.
1463
1464         No new tests as there is no functional change.
1465
1466         * platform/qt/QWebPageClient.h:
1467
1468 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1469
1470         Unreviewed.
1471
1472         [Qt] Build fix for QtWebKit after r51159.
1473
1474         Include float.h for DBL_MANT_DIG. Not sure why this
1475         is not a problem for other ports.
1476
1477         * html/HTMLInputElement.cpp:
1478
1479 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
1480
1481         Reviewed by Darin Adler.
1482
1483         Bug 31574 -  Crashing bug when removing <ruby> element
1484         (https://bugs.webkit.org/show_bug.cgi?id=31574)
1485
1486         Cause of the bug:
1487         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
1488         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
1489         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
1490         4.) this triggers the special handling of child removal in RenderRubyRun that
1491             causes it to destroy itself
1492         5.) On returning from all this the renderer crashes when accessing a member
1493             or virtual function on this now illegal object.
1494
1495         I therefore added a flag that tracks if the ruby run is being destroyed.
1496         If so, avoid doing the special handling in removeChild that caused this.
1497         It's not the most elegant solution, but the easiest to implement without
1498         touching unrelated code. Also, it's self-documenting.
1499
1500         Test: fast/ruby/ruby-remove.html
1501
1502         * rendering/RenderRubyRun.cpp:
1503         (WebCore::RenderRubyRun::RenderRubyRun):
1504         (WebCore::RenderRubyRun::destroy):
1505         (WebCore::RenderRubyRun::removeChild):
1506         * rendering/RenderRubyRun.h:
1507
1508 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1509
1510         Reviewed by Kenneth Rohde Christiansen.
1511
1512         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
1513         https://bugs.webkit.org/show_bug.cgi?id=31643
1514
1515         No new tests as there is no functional change.
1516
1517         * WebCore.pro:
1518
1519 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1520
1521         Reviewed by Eric Seidel.
1522
1523         Implement TextBoundaries for WINCE port.
1524         https://bugs.webkit.org/show_bug.cgi?id=27371
1525
1526         * platform/text/wince/TextBoundariesWince.cpp: Added.
1527
1528 2009-11-18  Yong Li  <yong.li@torchmobile.com>
1529
1530         Reviewed by Eric Seidel.
1531
1532         Implement TextBreakIterator for WINCE port.
1533         https://bugs.webkit.org/show_bug.cgi?id=27371
1534
1535         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
1536
1537 2009-11-18  Kent Tamura  <tkent@chromium.org>
1538
1539         Reviewed by Darin Adler.
1540
1541         Add support for ValidityState.typeMismatch for the following INPUT types:
1542           date datetime datetime-local month time week
1543         https://bugs.webkit.org/show_bug.cgi?id=31342
1544
1545         Tests: fast/forms/ValidityState-typeMismatch-date.html
1546                fast/forms/ValidityState-typeMismatch-datetime.html
1547                fast/forms/ValidityState-typeMismatch-datetimelocal.html
1548                fast/forms/ValidityState-typeMismatch-month.html
1549                fast/forms/ValidityState-typeMismatch-time.html
1550                fast/forms/ValidityState-typeMismatch-week.html
1551
1552         * html/HTMLInputElement.cpp:
1553         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
1554           validity of the specified type and string using the ISODateTime class.
1555         * html/HTMLInputElement.h:
1556         * html/ValidityState.cpp:
1557         (WebCore::ValidityState::typeMismatch): Check the type validity
1558           for date, datetime, datetime-local, month, time and week with
1559           HTMLInputElemtn::formStringToISODateTime()
1560
1561 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
1562
1563         Reviewed by Oliver Hunt.
1564
1565         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
1566         https://bugs.webkit.org/show_bug.cgi?id=31237
1567         
1568         Also speeds up Dromaeo DOM Core tests by 1.31x.
1569
1570         * bindings/js/JSNodeCustom.cpp:
1571         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
1572         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
1573         with wrappers would do marking; there should be only one in the typical case (the root of the
1574         detached subtree).
1575         * dom/Node.cpp:
1576         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
1577         * dom/Node.h: ditto
1578
1579 2009-11-18  Darin Adler  <darin@apple.com>
1580
1581         Reviewed by Sam Weinig.
1582
1583         Get rid of the redundant strokeType and fillType data members on
1584         a GraphicsContext as well as the FillOrStrokeType enum. Use
1585         null pointers instead.
1586
1587         * platform/graphics/GraphicsContext.cpp:
1588         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
1589         and gradient.
1590         (WebCore::GraphicsContext::setFillColor): Ditto.
1591         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
1592         (WebCore::GraphicsContext::setFillPattern): Ditto.
1593         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
1594         (WebCore::GraphicsContext::setFillGradient): Ditto.
1595
1596         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
1597
1598         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1599         (WebCore::setPlatformFill): Use null checks on fillPattern and
1600         fillGraident instead of a switch statement.
1601         (WebCore::setPlatformStroke): Ditto.
1602
1603         * platform/graphics/cg/GraphicsContextCG.cpp:
1604         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
1605         (WebCore::GraphicsContext::applyFillPattern): Ditto.
1606         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
1607         to see if there is a pattern instead of fillType and strokeType.
1608         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
1609         fillPattern, and strokePattern instead of fillType and strokeType.
1610         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
1611         is used in the pattern and gradient case probably erroneously. Moved
1612         gradient code inside an if statement. Streamlined pattern code and
1613         use an if statement. No switch any more.
1614         (WebCore::GraphicsContext::strokePath): Ditto.
1615         (WebCore::GraphicsContext::fillRect): Ditto.
1616         (WebCore::GraphicsContext::strokeRect): Ditto.
1617
1618         * platform/graphics/qt/GraphicsContextQt.cpp:
1619         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
1620         fillGraident instead of a switch statement.
1621         (WebCore::GraphicsContext::strokePath): Ditto.
1622         (WebCore::GraphicsContext::fillRect): Ditto.
1623
1624         * platform/graphics/wince/GraphicsContextWince.cpp:
1625         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
1626         (WebCore::GraphicsContext::fillRect): Ditto.
1627
1628 2009-11-18  Kent Tamura  <tkent@chromium.org>
1629
1630         Reviewed by Darin Adler.
1631
1632         Support for step attribute and ValidityStae.stepMismatch for
1633         type=number and range.  stepMismatch will be false if the
1634         difference between the current value and a multiple of the step
1635         value is very small.
1636
1637         Change the behavior of RenderSlider so that it always has a value
1638         rounded to the step attribute value.
1639
1640         https://bugs.webkit.org/show_bug.cgi?id=31331
1641
1642         Tests: fast/forms/ValidityState-stepMismatch-number.html
1643                fast/forms/ValidityState-stepMismatch-range.html
1644                fast/forms/ValidityState-stepMismatch-unsupported.html
1645                fast/forms/input-step.html
1646
1647         * html/HTMLAttributeNames.in: Add "step".
1648         * html/HTMLInputElement.cpp:
1649         (WebCore::HTMLInputElement::stepMismatch):
1650         (WebCore::HTMLInputElement::getStepParameters):
1651         (WebCore::HTMLInputElement::getAllowedValueStep):
1652         * html/HTMLInputElement.h:
1653         * html/HTMLInputElement.idl: Add "step".
1654         * html/ValidityState.cpp:
1655         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
1656         * html/ValidityState.h:
1657         * rendering/RenderSlider.cpp:
1658         (WebCore::SliderRange::SliderRange):
1659         (WebCore::SliderRange::clampValue):
1660
1661 2009-11-18  Dmitry Titov  <dimich@chromium.org>
1662
1663         Reviewed by Darin Adler.
1664
1665         Need to ASSERT(isMainThread()) in ThreadShared methods.
1666         https://bugs.webkit.org/show_bug.cgi?id=31637
1667
1668         Added ASSERT(IsMainThread()) to all following methods:
1669         * platform/TreeShared.h:
1670         (WebCore::TreeShared::TreeShared):
1671         (WebCore::TreeShared::~TreeShared):
1672         (WebCore::TreeShared::ref):
1673         (WebCore::TreeShared::deref):
1674         (WebCore::TreeShared::setParent):
1675         (WebCore::TreeShared::parent):
1676
1677 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1678
1679         Reviewed by Eric Seidel.
1680
1681         Add plugin visibility manual test
1682
1683         https://bugs.webkit.org/show_bug.cgi?id=31542
1684
1685         * manual-tests/plugins/windowed.html:
1686         * manual-tests/plugins/windowless.html:
1687
1688 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
1689
1690         Reviewed by Pavel Feldman.
1691
1692         Web Inspector - remember last script displayed in Scripts panel
1693         https://bugs.webkit.org/show_bug.cgi?id=27552
1694
1695         Manual test added
1696         
1697         * inspector/front-end/ScriptsPanel.js:
1698         (WebInspector.ScriptsPanel.prototype.showScript):
1699         (WebInspector.ScriptsPanel.prototype.showResource):
1700         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
1701         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1702         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
1703         (WebInspector.ScriptsPanel.prototype._goBack):
1704         (WebInspector.ScriptsPanel.prototype._goForward):
1705         * manual-tests/inspector/remember-last-script.html: Added.
1706
1707 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1708
1709         Reviewed by Dimitri Glazkov.
1710
1711         Win chromium is slow to draw transparent texts
1712         https://bugs.webkit.org/show_bug.cgi?id=31258
1713
1714         Create bounded transparency layers instead of just clipping.
1715
1716         No new tests because this is just a performance improvement.
1717
1718         * platform/graphics/chromium/FontChromiumWin.cpp:
1719         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1720
1721 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
1722
1723         Reviewed by Eric Seidel.
1724
1725         [Qt] Add support for displaying deleteButton.
1726         https://bugs.webkit.org/show_bug.cgi?id=31560
1727
1728         Test: LayoutTests/editing/deleting/5408255.html
1729
1730         * WebCore.qrc:
1731         * platform/graphics/qt/ImageQt.cpp:
1732         (loadResourcePixmap):
1733
1734 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1735
1736         Reviewed by Eric Seidel.
1737
1738         Fix Qt build without JavaScript debugger.
1739
1740         https://bugs.webkit.org/show_bug.cgi?id=31575
1741
1742         * page/Console.idl:
1743
1744 2009-11-18  Daniel Bates  <dbates@webkit.org>
1745
1746         Reviewed by Dave Hyatt.
1747
1748         https://bugs.webkit.org/show_bug.cgi?id=24971
1749         And
1750         <rdar://problem/7138265>
1751
1752         Fixes an issue where setting the height of a table row programmatically
1753         (via JavaScript) causes the table to be improperly rendered because the
1754         height of each row in the table is not recalculated with respect to the
1755         CSS height property.
1756
1757         In particular, programmatically setting the height of some table row causes
1758         the rows of that table to be rendered with a height equal to the minimum
1759         height required by the cells in that row, regardless of any specified cell
1760         heights. Instead, when RenderTableSection::recalcCells is called, the height
1761         of each row should be set to the CSS height property just as we do in
1762         RenderTableSection::addChild.
1763
1764         Test: fast/table/row-height-recalc2.html
1765
1766         * rendering/RenderTableSection.cpp:
1767         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
1768         (WebCore::RenderTableSection::addChild): Moved code that set row height into
1769         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1770         (WebCore::RenderTableSection::recalcCells): Modified to call
1771         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
1772
1773 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
1774
1775         Reviewed by Darin Adler.
1776
1777         Allow custom memory allocation control for the part of platform directory in WebCore
1778         https://bugs.webkit.org/show_bug.cgi?id=31473
1779
1780         Inherits the following classes from FastAllocBase because these are
1781         instantiated by 'new':
1782
1783         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
1784         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
1785         struct Length                - instantiated at WebCore/platform/Length.cpp:103
1786         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
1787         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
1788         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
1789
1790         Inherits the following classes from Noncopyable because these are
1791         instantiated by 'new' and no need to be copyable:
1792
1793         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
1794         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
1795         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
1796         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
1797
1798         * platform/ContextMenuItem.h:
1799         * platform/DeprecatedPtrList.h:
1800         * platform/DeprecatedPtrListImpl.cpp:
1801         * platform/Length.h:
1802         * platform/PlatformKeyboardEvent.h:
1803         * platform/animation/AnimationList.h:
1804         * platform/graphics/Color.h:
1805         * platform/graphics/FontCache.h:
1806         * platform/graphics/GraphicsContextPrivate.h:
1807         * platform/graphics/MediaPlayer.cpp:
1808
1809 2009-11-18  Daniel Bates  <dbates@webkit.org>
1810
1811         Reviewed by Darin Adler.
1812
1813         https://bugs.webkit.org/show_bug.cgi?id=31186
1814
1815         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
1816         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
1817         These are more descriptive names so as to clear an ambiguity surrounding
1818         their usage. Also, renames associated setters and getters so that they
1819         coincide with the renamed fields.
1820
1821         No functionality was changed. So, no tests were included.
1822
1823         * bindings/objc/DOMHTML.mm:
1824         (-[DOMHTMLInputElement _isEdited]):
1825         (-[DOMHTMLTextAreaElement _isEdited]):
1826         * dom/Document.cpp:
1827         (WebCore::Document::setFocusedNode):
1828         * html/HTMLInputElement.cpp:
1829         (WebCore::HTMLInputElement::defaultEventHandler):
1830         * rendering/RenderTextControl.cpp:
1831         (WebCore::RenderTextControl::RenderTextControl):
1832         (WebCore::RenderTextControl::setInnerTextValue):
1833         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
1834         (WebCore::RenderTextControl::subtreeHasChanged):
1835         * rendering/RenderTextControl.h:
1836         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
1837         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
1838         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
1839         * rendering/RenderTextControlSingleLine.cpp:
1840         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
1841         * wml/WMLInputElement.cpp:
1842         (WebCore::WMLInputElement::defaultEventHandler):
1843
1844 2009-11-18  Tony Chang  <tony@chromium.org>
1845
1846         Reviewed by Adam Barth.
1847
1848         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
1849         https://bugs.webkit.org/show_bug.cgi?id=31499
1850
1851         No new tests, just a build cleanup.
1852
1853         * WebCore.gypi:
1854         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
1855         * bindings/v8/custom/V8CustomBinding.h:
1856
1857 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1858
1859         Reviewed by Kevin Ollivier.
1860
1861         Enable wx plugin support using the Windows implementation as a base.
1862         
1863         https://bugs.webkit.org/show_bug.cgi?id=31636
1864
1865         * platform/graphics/GraphicsContext.h:
1866         (WebCore::GraphicsContext::inTransparencyLayer):
1867         * platform/graphics/wx/GraphicsContextWx.cpp:
1868         (WebCore::GraphicsContext::getWindowsContext):
1869         (WebCore::GraphicsContext::releaseWindowsContext):
1870         * platform/wx/FileSystemWx.cpp:
1871         (WebCore::unloadModule):
1872         (WebCore::listDirectory):
1873         * plugins/PluginDatabase.cpp:
1874         * plugins/PluginView.cpp:
1875         (WebCore::PluginView::stop):
1876         (WebCore::PluginView::PluginView):
1877         * plugins/PluginView.h:
1878         * plugins/win/PluginViewWin.cpp:
1879         (windowHandleForPageClient):
1880         (WebCore::PluginView::handleMouseEvent):
1881         (WebCore::PluginView::platformStart):
1882         (WebCore::PluginView::snapshot):
1883         * wscript:
1884
1885 2009-11-18  Andrei Popescu  <andreip@google.com>
1886
1887         Reviewed by Dimitri Glazkov.
1888
1889         [Android] Add shared timer and sound utilities to platform/android
1890         https://bugs.webkit.org/show_bug.cgi?id=31584
1891
1892         No new tests required, this is platform specific code.
1893
1894         * platform/android/SharedTimerAndroid.cpp: Added.
1895         (WebCore::setSharedTimerFiredFunction):
1896         (WebCore::setSharedTimerFireTime):
1897         (WebCore::stopSharedTimer):
1898         * platform/android/SoundAndroid.cpp: Added.
1899         (WebCore::systemBeep):
1900
1901 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
1902
1903         Reviewed by Timothy Hatcher.
1904
1905         Fix profile tree nodes loss after focus / restore actions.
1906
1907         Focusing on a node is currently implemented via nodes reattaching
1908         with some caching involved. It seems that not all code was updated
1909         to handle this scenario correctly.
1910
1911         https://bugs.webkit.org/show_bug.cgi?id=31553
1912
1913         * inspector/front-end/BottomUpProfileDataGridTree.js:
1914         (WebInspector.BottomUpProfileDataGridNode):
1915         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
1916         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
1917         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
1918         * inspector/front-end/DataGrid.js:
1919         (WebInspector.DataGrid.prototype.insertChild):
1920         (WebInspector.DataGridNode.prototype._detach):
1921         (WebInspector.DataGridNode.prototype.savePosition):
1922         (WebInspector.DataGridNode.prototype.restorePosition):
1923         * inspector/front-end/TopDownProfileDataGridTree.js:
1924         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
1925         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
1926
1927 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
1928
1929         Reviewed by Kenneth Rohde Christiansen.
1930
1931         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
1932         include it 
1933         https://bugs.webkit.org/show_bug.cgi?id=31527
1934
1935         No new tests as this is just a coding style fix that affects the 
1936         build of some not yet submitted patches (i.e. for bug 30173).
1937
1938         * platform/qt/QWebPageClient.h:
1939
1940 2009-11-18  Nicolas Roard   <nicolas@roard.com>
1941
1942         Reviewed by Dimitri Glazkov.
1943
1944         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
1945         https://bugs.webkit.org/show_bug.cgi?id=31504
1946
1947         * inspector/InspectorTimelineAgent.h:Added the guard.
1948
1949 2009-11-18  Jens Alfke  <snej@chromium.org>
1950
1951         Build fix to my previous checkin, for Windows Chromium
1952
1953         * svg/SVGAnimatedProperty.h:
1954         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
1955
1956 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
1957
1958         Reviewed by Pavel Feldman.
1959
1960         Web Inspector: Directly Access <head> Instead of Searching for It
1961         https://bugs.webkit.org/show_bug.cgi?id=31641
1962         
1963         Changed old access of the head element (document.getElementsByTagName)
1964         to just use the document.head accessor.
1965
1966         * inspector/front-end/FontView.js:
1967         (WebInspector.FontView):
1968         * inspector/front-end/InjectedScript.js:
1969         (InjectedScript.addStyleSelector):
1970         * inspector/front-end/SourceFrame.js:
1971         (WebInspector.SourceFrame.prototype._loaded):
1972         * inspector/front-end/inspector.js:
1973         (windowLoaded):
1974
1975 2009-11-18  Sam Weinig  <sam@webkit.org>
1976
1977         Reviewed by Anders Carlsson.
1978
1979         Fix two Geolocation assertions.
1980
1981         * page/Chrome.cpp:
1982         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
1983         is not called from JS. 
1984         * page/Geolocation.cpp:
1985         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
1986         a RefPtr first.
1987
1988 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
1989
1990         Case sensitive file system build fix.
1991
1992         * platform/network/Credential.h: It's not WTF, just wtf.
1993
1994 2009-11-18  Aaron Golden  <agolden@apple.com>
1995
1996         Reviewed by Alexey Proskuryakov.
1997
1998         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
1999         objects and WebCore::Credential objects without losing certificate information.
2000
2001         * platform/network/Credential.cpp:
2002         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
2003         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
2004         (WebCore::Credential::identity): Accessor for the m_identity property
2005         (WebCore::Credential::certificates): Accessor for the m_certificates property
2006         (WebCore::Credential::type):  Accessor for the m_type property
2007         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
2008         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
2009         * platform/network/mac/AuthenticationMac.mm:
2010         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
2011         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
2012
2013 2009-11-18  Dmitry Titov  <dimich@chromium.org>
2014
2015         Reviewed by Eric Seidel.
2016
2017         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
2018         https://bugs.webkit.org/show_bug.cgi?id=31615
2019
2020         * dom/Document.cpp:
2021         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
2022         (WebCore::ScriptExecutionContextTaskTimer::fired):
2023         (WebCore::PerformTaskContext::PerformTaskContext):
2024         (WebCore::performTask):
2025         (WebCore::Document::postTask):
2026         * dom/ScriptExecutionContext.cpp:
2027         * dom/ScriptExecutionContext.h:
2028
2029 2009-11-18  Jens Alfke  <snej@chromium.org>
2030
2031         Reviewed by Darin Adler.
2032
2033         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
2034         by causing the right v8-to-WebCore conversion function to be called for every parameter.
2035         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
2036         To enforce correctness, I added a mode that disables implicit
2037         String-->AtomicString conversions while compiling the generated bindings.
2038         https://bugs.webkit.org/show_bug.cgi?id=31168
2039
2040         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
2041         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
2042         * bindings/v8/V8Binding.h:  Add V8Parameter class.
2043         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
2044         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
2045         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
2046         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
2047         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
2048
2049 2009-11-18  Darin Adler  <darin@apple.com>
2050
2051         Reviewed by Dan Bernstein.
2052
2053         Move FillOrStrokeType out of public header.
2054
2055         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
2056         some years we published Apple changes, sorted forward declarations,
2057         removed FillOrStrokeType enum.
2058         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
2059         to cover some years we published Apple changes, sorted includes,
2060         moved FillOrStrokeType enum here.
2061
2062 2009-11-18  Chris Marrin  <cmarrin@apple.com>
2063
2064         Reviewed by Simon Fraser.
2065
2066         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
2067         https://bugs.webkit.org/show_bug.cgi?id=31601
2068
2069         These are used to debug accelerated compositing layers. I removed
2070         the platform specific code from GraphicsLayerCA.mm and added calls
2071         to GraphicsLayerClient to get it from the higher levels. The values 
2072         now get cached in RenderLayerCompositing and are queried from there
2073         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
2074
2075         * WebCore.base.exp:
2076         * page/FrameView.cpp:
2077         (WebCore::FrameView::updateCompositingLayers):
2078         * page/Settings.cpp:
2079         (WebCore::Settings::Settings):
2080         (WebCore::Settings::setShowDebugBorders):
2081         (WebCore::Settings::setShowRepaintCounter):
2082         * page/Settings.h:
2083         (WebCore::Settings::showDebugBorders):
2084         (WebCore::Settings::showRepaintCounter):
2085         * platform/graphics/GraphicsLayer.h:
2086         (WebCore::GraphicsLayer::showDebugBorders):
2087         (WebCore::GraphicsLayer::showRepaintCounter):
2088         * platform/graphics/GraphicsLayerClient.h:
2089         * platform/graphics/mac/GraphicsLayerCA.mm:
2090         * rendering/RenderLayerBacking.cpp:
2091         (WebCore::RenderLayerBacking::showDebugBorders):
2092         (WebCore::RenderLayerBacking::showRepaintCounter):
2093         * rendering/RenderLayerBacking.h:
2094         * rendering/RenderLayerCompositor.cpp:
2095         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
2096         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
2097         * rendering/RenderLayerCompositor.h:
2098         (WebCore::RenderLayerCompositor::showDebugBorders):
2099         (WebCore::RenderLayerCompositor::showRepaintCounter):
2100
2101 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
2102
2103         Reviewed by Timothy Hatcher.
2104
2105         Web Inspector: Get rid of metrics and properties sidebars'
2106         flickering.
2107
2108         https://bugs.webkit.org/show_bug.cgi?id=31629
2109
2110         * inspector/front-end/MetricsSidebarPane.js:
2111         * inspector/front-end/PropertiesSidebarPane.js:
2112
2113 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
2114
2115         Reviewed by Pavel Feldman.
2116
2117         Fixes <http://webkit.org/b/31606>.
2118         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
2119         
2120         This implements Enter starting editing mode in an editable DataGrid. If the
2121         DataGrid is editable and the user hits return, startEditing the first child
2122         of the selected node. Also refactored some editing functions to take an 
2123         event target instead of the event itself, because the functions only needed
2124         the target. Lastly, added had return in editing mode stop propogation, because
2125         when enter was hit to confirm text, it would propagate back to the datagrid
2126         and try to start editing again.
2127
2128         * inspector/front-end/DataGrid.js:
2129         (WebInspector.DataGrid.prototype._ondblclick):
2130         (WebInspector.DataGrid.prototype._startEditing):
2131         (WebInspector.DataGrid.prototype.handleKeyEvent):
2132         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
2133         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
2134         (WebInspector.DataGrid.prototype._clickInDataTable):
2135         * inspector/front-end/inspector.js:
2136         (WebInspector.startEditing.element.handleKeyEvent):
2137         (WebInspector.startEditing):
2138
2139 2009-11-18  Ben Murdoch  <benm@google.com>
2140
2141         Reviewed by Darin Adler.
2142
2143         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
2144         https://bugs.webkit.org/show_bug.cgi?id=31593
2145
2146         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
2147
2148         * html/HTMLAnchorElement.cpp:
2149         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
2150
2151 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
2152
2153         Not reviewed. Touch InspectorController so that frontend
2154         JS files are deployed on Windows.
2155
2156         * inspector/InspectorController.cpp:
2157
2158 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
2159
2160         Reviewed by Timothy Hatcher.
2161
2162         Web Inspector: clone timeline records array instead of
2163         copying reference on invalidate all.
2164
2165         https://bugs.webkit.org/show_bug.cgi?id=31596
2166
2167         * inspector/front-end/AbstractTimelinePanel.js:
2168         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
2169
2170 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
2171
2172         Reviewed by Dan Bernstein.
2173
2174         Elements don't drop out of compositing layers when animation ends
2175         https://bugs.webkit.org/show_bug.cgi?id=31613
2176         <rdar://problem/7402913>
2177
2178         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
2179         are compositing anyway for other reasons. Doing so can cause those layers
2180         to stay in compositing mode even after animations finish, because needsToBeComposited()
2181         continues to return true.
2182         
2183         No new tests because it's not possible to determine which elements are in
2184         compositing layers from DRT output.
2185
2186         * rendering/RenderLayerCompositor.cpp:
2187         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2188
2189 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
2190
2191         Reviewed by Tor Arne Vestbø.
2192
2193         [Qt] Mac Plugins: Remove null timer
2194         
2195         A null timer was used to send mouse move events. Instead, we now use
2196         move events to send nullEvent. This brings down CPU usage by 20-30%.
2197         
2198         https://bugs.webkit.org/show_bug.cgi?id=31624
2199
2200         * plugins/PluginView.h:
2201         * plugins/mac/PluginViewMac.cpp:
2202         (WebCore::PluginView::platformStart):
2203         (WebCore::PluginView::handleMouseEvent):
2204
2205 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
2206
2207         Reviewed by Simon Hausmann.
2208
2209         [Qt] WebKit crashes when loading certain SVG images
2210
2211         Check if the familly exist before creating the PlatformData from it.
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=29443
2214
2215         Test: svg/text/text-font-invalid.html
2216
2217         * platform/graphics/qt/FontFallbackListQt.cpp:
2218         (WebCore::FontFallbackList::fontDataAt):
2219
2220 2009-11-17  Nicolas Weber  <thakis@chromium.org>
2221
2222         Reviewed by Darin Fisher.
2223
2224         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
2225         after navigation.
2226         https://bugs.webkit.org/show_bug.cgi?id=31609
2227
2228         * platform/chromium/PopupMenuChromium.cpp:
2229         (WebCore::PopupContainer::showExternal): Set parent for external
2230         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
2231         its parent's client.
2232
2233 2009-11-17  Hayato Ito  <hayato@google.com>
2234
2235         Reviewed by Darin Adler.
2236
2237         Avoid infinite mutual recursion when deeply nested tags are loaded
2238         https://bugs.webkit.org/show_bug.cgi?id=30651
2239
2240         Test: fast/parser/block-nesting-cap-table.html
2241
2242         * html/HTMLParser.cpp:
2243         (WebCore::HTMLParser::parseToken):
2244         (WebCore::tagPriorityOfNode):
2245         (WebCore::HTMLParser::limitBlockDepth):
2246         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
2247         (WebCore::HTMLParser::insertNode):
2248         * html/HTMLParser.h:
2249
2250 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
2251
2252         Rubber-stamped by Alexey Proskuryakov.
2253
2254         Final clean-ups for minor coding standard violations.
2255         https://bugs.webkit.org/show_bug.cgi?id=26102.
2256
2257         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2258
2259 2009-11-17  Johnny Ding  <jnd@chromium.org>
2260
2261         Reviewed by Darin Adler.
2262
2263         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
2264         https://bugs.webkit.org/show_bug.cgi?id=31567
2265
2266         * dom/ScriptElement.cpp:
2267         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
2268
2269 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2270
2271         Reviewed by Timothy Hatcher.
2272
2273         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2274         - Updated DRT to show/close inspector for all tests under /inspector
2275         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2276           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2277         - Removed reload on each inspector test
2278         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2279         inspector for those.
2280         - Reimplemented timeline tests in order to get rid of reload there.
2281         - Moved tests that don't require harness into the fast group.
2282
2283         https://bugs.webkit.org/show_bug.cgi?id=31472
2284
2285         * WebCore.Inspector.exp:
2286         * inspector/front-end/TimelinePanel.js:
2287         (WebInspector.TimelinePanel.prototype._formatRecord):
2288
2289 2009-11-17  Andrei Popescu  <andreip@google.com>
2290
2291         Reviewed by Dimitri Glazkov.
2292
2293         [Android] Android is missing the implementation of the GeolocationService iface.
2294         https://bugs.webkit.org/show_bug.cgi?id=31554
2295
2296         No new tests required as this is platform specific code.
2297
2298         * platform/android/GeolocationServiceAndroid.cpp: Added.
2299         (WebCore::GeolocationServiceAndroid::create):
2300         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
2301         (WebCore::GeolocationServiceAndroid::startUpdating):
2302         (WebCore::GeolocationServiceAndroid::stopUpdating):
2303         (WebCore::GeolocationServiceAndroid::suspend):
2304         (WebCore::GeolocationServiceAndroid::resume):
2305         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
2306         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
2307         (WebCore::GeolocationServiceAndroid::timerFired):
2308         (WebCore::GeolocationServiceAndroid::isPositionMovement):
2309         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
2310         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
2311         * platform/android/GeolocationServiceAndroid.h: Added.
2312         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
2313         (WebCore::GeolocationServiceAndroid::lastPosition):
2314         (WebCore::GeolocationServiceAndroid::lastError):
2315         * platform/android/GeolocationServiceBridge.cpp: Added.
2316         (WebCore::):
2317         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
2318         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
2319         (WebCore::GeolocationServiceBridge::start):
2320         (WebCore::GeolocationServiceBridge::stop):
2321         (WebCore::GeolocationServiceBridge::setEnableGps):
2322         (WebCore::GeolocationServiceBridge::newLocationAvailable):
2323         (WebCore::GeolocationServiceBridge::newErrorAvailable):
2324         (WebCore::GeolocationServiceBridge::toGeoposition):
2325         (WebCore::GeolocationServiceBridge::startJavaImplementation):
2326         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
2327         * platform/android/GeolocationServiceBridge.h: Added.
2328
2329 2009-11-16  Kent Tamura  <tkent@chromium.org>
2330
2331         Unreviewd build fix.
2332
2333         - Fix typo in WebCore.vcproj.
2334         - Intlude limits.h for INT_MAX.
2335         - Enclose with parenthesis to suspress warning.
2336
2337         * WebCore.vcproj/WebCore.vcproj:
2338         * html/ISODateTime.cpp:
2339         (WebCore::ISODateTime::addDay):
2340
2341 2009-11-16  Robin Dunn  <robin@alldunn.com>
2342
2343         Reviewed by Kevin Ollivier.
2344
2345         Make sure wx scrollbar drawing code factors in transforms when switching backends,
2346         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
2347         
2348         https://bugs.webkit.org/show_bug.cgi?id=31570
2349
2350         * platform/wx/ScrollbarThemeWx.cpp:
2351         (WebCore::ScrollbarThemeWx::minimumThumbLength):
2352         (WebCore::ScrollbarThemeWx::splitTrack):
2353         (WebCore::ScrollbarThemeWx::forwardButtonRect):
2354         * platform/wx/ScrollbarThemeWx.h:
2355         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
2356         (wxRenderer_DrawScrollbar):
2357         * platform/wx/wxcode/scrollbar_render.h:
2358         (calcThumbStartAndLength):
2359         * platform/wx/wxcode/win/scrollbar_render.cpp:
2360         (wxRenderer_DrawScrollbar):
2361
2362 2009-11-16  Kent Tamura  <tkent@chromium.org>
2363
2364         Reviewed by David Levin.
2365
2366         Introduce WebCore::ISODateTime class.
2367         https://bugs.webkit.org/show_bug.cgi?id=31340
2368
2369         This class represents a value of date/time types of the HTML5 INPUT
2370         element, and has some parsing methods for ISO 8601.
2371
2372         This change has no tests because the class is not used yet.
2373
2374         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
2375         * WebCore.gypi: ditto.
2376         * WebCore.pro: ditto.
2377         * WebCore.vcproj/WebCore.vcproj: ditto.
2378         * WebCore.xcodeproj/project.pbxproj: ditto.
2379         * WebCoreSources.bkl: ditto.
2380         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
2381         (WebCore::isLeapYear):
2382         (WebCore::maxDayOfMonth):
2383         (WebCore::dayOfWeek):
2384         (WebCore::ISODateTime::maxWeekNumberInYear):
2385         (WebCore::countDigits):
2386         (WebCore::toInt):
2387         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
2388         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
2389         (WebCore::ISODateTime::addMinute): ditto.
2390         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
2391         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
2392         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
2393         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
2394         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
2395         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
2396         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
2397         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
2398         (WebCore::ISODateTime::ISODateTime):
2399         (WebCore::ISODateTime::millisecond):
2400         (WebCore::ISODateTime::second):
2401         (WebCore::ISODateTime::minute):
2402         (WebCore::ISODateTime::hour):
2403         (WebCore::ISODateTime::monthDay):
2404         (WebCore::ISODateTime::month):
2405         (WebCore::ISODateTime::fullYear):
2406         (WebCore::ISODateTime::week):
2407
2408 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2409
2410         Fix a typo in previous commit.
2411
2412         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
2413
2414 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2415
2416         Fix a typo in previous commit.
2417
2418         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2419
2420 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2421
2422         Tiger build fix.
2423
2424         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
2425         differently in Tiger CFNetwork.
2426
2427 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
2428
2429         Reviewed by Darin Fisher.
2430
2431         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
2432
2433         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
2434
2435         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
2436
2437         * platform/KURLGoogle.cpp:
2438         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
2439
2440 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2441
2442         Rubber-stamped by Jon Honeycutt.
2443
2444         A better Windows build fix
2445
2446         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2447         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
2448
2449 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
2450
2451         Reviewed by Darin Adler.
2452
2453         Rename protocolIsValid to isValidProtocol.
2454         https://bugs.webkit.org/show_bug.cgi?id=31503
2455
2456         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
2457
2458         No new tests since no new functionality was introduced.
2459
2460         * html/HTMLAnchorElement.cpp:
2461         (WebCore::HTMLAnchorElement::setProtocol):
2462         * platform/KURL.cpp:
2463         (WebCore::isValidProtocol):
2464         * platform/KURL.h:
2465         * platform/KURLGoogle.cpp:
2466         (WebCore::isValidProtocol):
2467
2468 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2469
2470         Reviewed by Beth Dakin.
2471
2472         AX: aria-labelledby duplicates some of its WAI-ARIA label
2473         https://bugs.webkit.org/show_bug.cgi?id=31565
2474
2475         Test: accessibility/aria-labelledby-overrides-label.html
2476
2477         * accessibility/AccessibilityRenderObject.cpp:
2478         (WebCore::AccessibilityRenderObject::hasTextAlternative):
2479         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
2480         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2481         * accessibility/AccessibilityRenderObject.h:
2482
2483 2009-11-16  Nate Chapin  <japhet@chromium.org>
2484
2485         Reviewed by Darin Fisher.
2486
2487         Handle the case of a null NPObject* in NPN_SetException in
2488         the V8 bindings.  This allow out of process plugins calling
2489         NPN_SetException to just send null instead of sending an
2490         NPObject* that would be an address in a different 
2491         process's memory space.
2492
2493         https://bugs.webkit.org/show_bug.cgi?id=31561
2494
2495         * bindings/v8/NPV8Object.cpp:
2496         (_NPN_SetException): Allow null NPObject* and just throw a general error.
2497
2498 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2499
2500         Windows build fix.
2501
2502         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2503         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
2504
2505 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
2506
2507         Reviewed by Kenneth Rohde Christiansen.
2508
2509         [Qt] ASSERT failure while running DRT
2510         https://bugs.webkit.org/show_bug.cgi?id=30978
2511
2512         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
2513         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
2514
2515         * bridge/qt/qt_instance.cpp:
2516         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
2517         * bridge/qt/qt_runtime.h:
2518         (JSC::Bindings::QtRuntimeMethod::createStructure):
2519
2520 2009-11-16  Mark Rowe  <mrowe@apple.com>
2521
2522         Attempt to fix the build.  Land a file that was missing from r51049.
2523
2524         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
2525         (WebCore::setWebGLArrayFromArray):
2526
2527 2009-11-16  Kenneth Russell  <kbr@google.com>
2528
2529         Reviewed by Oliver Hunt.
2530
2531         Update API of WebGLArray and friends
2532         https://bugs.webkit.org/show_bug.cgi?id=31175
2533
2534         * bindings/js/JSWebGLArrayCustom.cpp:
2535         (WebCore::toJS):
2536         * bindings/js/JSWebGLArrayHelper.h: Added.
2537         (WebCore::setWebGLArrayFromArray):
2538         * bindings/js/JSWebGLByteArrayCustom.cpp:
2539         (WebCore::JSWebGLByteArray::set):
2540         * bindings/js/JSWebGLFloatArrayCustom.cpp:
2541         (WebCore::JSWebGLFloatArray::set):
2542         * bindings/js/JSWebGLIntArrayCustom.cpp:
2543         (WebCore::JSWebGLIntArray::set):
2544         * bindings/js/JSWebGLShortArrayCustom.cpp:
2545         (WebCore::JSWebGLShortArray::set):
2546         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
2547         (WebCore::JSWebGLUnsignedByteArray::set):
2548         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2549         (WebCore::JSWebGLUnsignedIntArray::set):
2550         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
2551         (WebCore::JSWebGLUnsignedShortArray::set):
2552         * bindings/scripts/CodeGeneratorV8.pm:
2553         * bindings/v8/V8DOMWrapper.cpp:
2554         (WebCore::V8DOMWrapper::convertToV8Object):
2555         * bindings/v8/custom/V8CustomBinding.h:
2556         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2557         (WebCore::CALLBACK_FUNC_DECL):
2558         * bindings/v8/custom/V8WebGLArrayCustom.h:
2559         (WebCore::constructWebGLArray):
2560         (WebCore::getWebGLArrayElement):
2561         (WebCore::setWebGLArrayFromArray):
2562         (WebCore::setWebGLArray):
2563         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2564         (WebCore::CALLBACK_FUNC_DECL):
2565         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2566         (WebCore::CALLBACK_FUNC_DECL):
2567         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2568         (WebCore::CALLBACK_FUNC_DECL):
2569         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2570         (WebCore::CALLBACK_FUNC_DECL):
2571         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2572         (WebCore::CALLBACK_FUNC_DECL):
2573         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2574         (WebCore::CALLBACK_FUNC_DECL):
2575         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2576         (WebCore::CALLBACK_FUNC_DECL):
2577         * html/canvas/WebGLArray.cpp:
2578         (WebCore::WebGLArray::WebGLArray):
2579         (WebCore::WebGLArray::~WebGLArray):
2580         (WebCore::WebGLArray::setImpl):
2581         * html/canvas/WebGLArray.h:
2582         (WebCore::WebGLArray::isByteArray):
2583         (WebCore::WebGLArray::isUnsignedByteArray):
2584         (WebCore::WebGLArray::isShortArray):
2585         (WebCore::WebGLArray::isUnsignedShortArray):
2586         (WebCore::WebGLArray::isIntArray):
2587         (WebCore::WebGLArray::isUnsignedIntArray):
2588         (WebCore::WebGLArray::isFloatArray):
2589         (WebCore::WebGLArray::buffer):
2590         (WebCore::WebGLArray::baseAddress):
2591         (WebCore::WebGLArray::byteOffset):
2592         * html/canvas/WebGLArray.idl:
2593         * html/canvas/WebGLArrayBuffer.cpp:
2594         (WebCore::WebGLArrayBuffer::create):
2595         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
2596         (WebCore::WebGLArrayBuffer::data):
2597         (WebCore::WebGLArrayBuffer::byteLength):
2598         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
2599         * html/canvas/WebGLArrayBuffer.h:
2600         * html/canvas/WebGLByteArray.cpp:
2601         (WebCore::WebGLByteArray::create):
2602         (WebCore::WebGLByteArray::byteLength):
2603         (WebCore::WebGLByteArray::slice):
2604         (WebCore::WebGLByteArray::set):
2605         * html/canvas/WebGLByteArray.h:
2606         (WebCore::WebGLByteArray::isByteArray):
2607         (WebCore::WebGLByteArray::data):
2608         (WebCore::WebGLByteArray::set):
2609         (WebCore::WebGLByteArray::get):
2610         (WebCore::WebGLByteArray::item):
2611         * html/canvas/WebGLByteArray.idl:
2612         * html/canvas/WebGLFloatArray.cpp:
2613         (WebCore::WebGLFloatArray::create):
2614         (WebCore::WebGLFloatArray::WebGLFloatArray):
2615         (WebCore::WebGLFloatArray::length):
2616         (WebCore::WebGLFloatArray::byteLength):
2617         (WebCore::WebGLFloatArray::slice):
2618         (WebCore::WebGLFloatArray::set):
2619         * html/canvas/WebGLFloatArray.h:
2620         (WebCore::WebGLFloatArray::isFloatArray):
2621         (WebCore::WebGLFloatArray::data):
2622         (WebCore::WebGLFloatArray::set):
2623         (WebCore::WebGLFloatArray::get):
2624         (WebCore::WebGLFloatArray::item):
2625         * html/canvas/WebGLFloatArray.idl:
2626         * html/canvas/WebGLIntArray.cpp:
2627         (WebCore::WebGLIntArray::create):
2628         (WebCore::WebGLIntArray::WebGLIntArray):
2629         (WebCore::WebGLIntArray::length):
2630         (WebCore::WebGLIntArray::byteLength):
2631         (WebCore::WebGLIntArray::slice):
2632         (WebCore::WebGLIntArray::set):
2633         * html/canvas/WebGLIntArray.h:
2634         (WebCore::WebGLIntArray::isIntArray):
2635         (WebCore::WebGLIntArray::data):
2636         (WebCore::WebGLIntArray::set):
2637         (WebCore::WebGLIntArray::get):
2638         (WebCore::WebGLIntArray::item):
2639         * html/canvas/WebGLIntArray.idl:
2640         * html/canvas/WebGLShortArray.cpp:
2641         (WebCore::WebGLShortArray::create):
2642         (WebCore::WebGLShortArray::WebGLShortArray):
2643         (WebCore::WebGLShortArray::length):
2644         (WebCore::WebGLShortArray::byteLength):
2645         (WebCore::WebGLShortArray::slice):
2646         (WebCore::WebGLShortArray::set):
2647         * html/canvas/WebGLShortArray.h:
2648         (WebCore::WebGLShortArray::isShortArray):
2649         (WebCore::WebGLShortArray::data):
2650         (WebCore::WebGLShortArray::set):
2651         (WebCore::WebGLShortArray::get):
2652         (WebCore::WebGLShortArray::item):
2653         * html/canvas/WebGLShortArray.idl:
2654         * html/canvas/WebGLUnsignedByteArray.cpp:
2655         (WebCore::WebGLUnsignedByteArray::create):
2656         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
2657         (WebCore::WebGLUnsignedByteArray::length):
2658         (WebCore::WebGLUnsignedByteArray::byteLength):
2659         (WebCore::WebGLUnsignedByteArray::slice):
2660         (WebCore::WebGLUnsignedByteArray::set):
2661         * html/canvas/WebGLUnsignedByteArray.h:
2662         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
2663         (WebCore::WebGLUnsignedByteArray::data):
2664         (WebCore::WebGLUnsignedByteArray::set):
2665         (WebCore::WebGLUnsignedByteArray::get):
2666         (WebCore::WebGLUnsignedByteArray::item):
2667         * html/canvas/WebGLUnsignedByteArray.idl:
2668         * html/canvas/WebGLUnsignedIntArray.cpp:
2669         (WebCore::WebGLUnsignedIntArray::create):
2670         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
2671         (WebCore::WebGLUnsignedIntArray::length):
2672         (WebCore::WebGLUnsignedIntArray::byteLength):
2673         (WebCore::WebGLUnsignedIntArray::slice):
2674         (WebCore::WebGLUnsignedIntArray::set):
2675         * html/canvas/WebGLUnsignedIntArray.h:
2676         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
2677         (WebCore::WebGLUnsignedIntArray::data):
2678         (WebCore::WebGLUnsignedIntArray::set):
2679         (WebCore::WebGLUnsignedIntArray::get):
2680         (WebCore::WebGLUnsignedIntArray::item):
2681         * html/canvas/WebGLUnsignedIntArray.idl:
2682         * html/canvas/WebGLUnsignedShortArray.cpp:
2683         (WebCore::WebGLUnsignedShortArray::create):
2684         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
2685         (WebCore::WebGLUnsignedShortArray::length):
2686         (WebCore::WebGLUnsignedShortArray::byteLength):
2687         (WebCore::WebGLUnsignedShortArray::slice):
2688         (WebCore::WebGLUnsignedShortArray::set):
2689         * html/canvas/WebGLUnsignedShortArray.h:
2690         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
2691         (WebCore::WebGLUnsignedShortArray::data):
2692         (WebCore::WebGLUnsignedShortArray::set):
2693         (WebCore::WebGLUnsignedShortArray::get):
2694         (WebCore::WebGLUnsignedShortArray::item):
2695         * html/canvas/WebGLUnsignedShortArray.idl:
2696         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2697         (WebCore::GraphicsContext3D::bufferData):
2698         (WebCore::GraphicsContext3D::bufferSubData):
2699
2700 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2701
2702         Windows build fix.
2703
2704         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
2705
2706 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
2707
2708         Reviewed by Oliver Hunt.
2709
2710         Enable support for webkit-box-shadow in Cairo builds.
2711         https://bugs.webkit.org/show_bug.cgi?id=26102.
2712
2713         Covered by existing fast/box-shadow tests.
2714
2715         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
2716           support for fillRect shadows.
2717
2718 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2719
2720         Windows build fix.
2721
2722         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
2723         in WebKitSupportLibrary.
2724
2725 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
2726
2727         Reviewed by Darin Adler.
2728
2729         https://bugs.webkit.org/show_bug.cgi?id=31494
2730         Add unauthenticated proxy support to SocketStreamHandleCFNet
2731
2732         Cannot be tested in DRT.
2733
2734         * platform/network/cf/SocketStreamHandleCFNet.cpp:
2735         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
2736         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
2737
2738 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2739
2740         Reviewed by Antti Koivisto.
2741
2742         [Qt] Broken back/forward after using ErrorPageExtension to set error page
2743         https://bugs.webkit.org/show_bug.cgi?id=30573
2744
2745         Make FrameLoader::checkLoadCompleteForThisFrame method
2746         to check for any working DocumentLoader instance (through
2747         activeDocumentLoader()) instead of only checking for
2748         'm_provisionalDocumentLoader' in order to decide to if
2749         it is going to reset of not the back and forward history.
2750         after an error page has been loaded.
2751
2752         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
2753
2754         * loader/FrameLoader.cpp:
2755         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
2756
2757 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
2758
2759         Reviewed by Darin Adler.
2760
2761         Need to implement ARIA role="directory"
2762         https://bugs.webkit.org/show_bug.cgi?id=31516
2763
2764         Test: platform/mac/accessibility/aria-directory.html
2765
2766         * accessibility/AXObjectCache.cpp:
2767         (WebCore::AXObjectCache::getOrCreate):
2768         * accessibility/AccessibilityList.cpp:
2769         (WebCore::AccessibilityList::isOrderedList):
2770         * accessibility/AccessibilityRenderObject.cpp:
2771         (WebCore::createARIARoleMap):
2772
2773 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
2774
2775         Reviewed by George Staikos.
2776         
2777         Compare UChars single unit at a time as opposed to the uint32_t
2778         approach as casting to unaligned addresses may cause a bus failure
2779         on ARMv5 and below. This change replicates the same defines that
2780         exists in AtomicString.cpp
2781
2782         https://bugs.webkit.org/show_bug.cgi?id=31475
2783         
2784         * platform/text/StringHash.h:
2785         (WebCore::StringHash::equal):
2786
2787 2009-11-15  Evan Martin  <evan@chromium.org>
2788
2789         Reviewed by Adam Barth.
2790
2791         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
2792
2793         https://bugs.webkit.org/show_bug.cgi?id=31490
2794
2795         * bindings/v8/V8DOMWrapper.cpp:
2796
2797 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2798
2799         Reviewed by Adam Barth.
2800
2801         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
2802
2803         * platform/haiku/FileChooserHaiku.cpp:
2804
2805 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
2806
2807         Reviewed by Adam Barth.
2808
2809         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
2810
2811         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
2812         (WebCore::GraphicsContext::setPlatformStrokeColor):
2813
2814 2009-11-15  Daniel Bates  <dbates@webkit.org>
2815
2816         No review, rolling out r50999.
2817         http://trac.webkit.org/changeset/50999
2818
2819         Need to fix some issues in the Windows build. Missed some places where
2820         RenderTextControl::isEdited is called.
2821
2822         * bindings/objc/DOMHTML.mm:
2823         (-[DOMHTMLInputElement _isEdited]):
2824         (-[DOMHTMLTextAreaElement _isEdited]):
2825         * dom/Document.cpp:
2826         (WebCore::Document::setFocusedNode):
2827         * html/HTMLInputElement.cpp:
2828         (WebCore::HTMLInputElement::defaultEventHandler):
2829         * rendering/RenderTextControl.cpp:
2830         (WebCore::RenderTextControl::RenderTextControl):
2831         (WebCore::RenderTextControl::setInnerTextValue):
2832         (WebCore::RenderTextControl::setUserEdited):
2833         (WebCore::RenderTextControl::subtreeHasChanged):
2834         * rendering/RenderTextControl.h:
2835         (WebCore::RenderTextControl::isEdited):
2836         (WebCore::RenderTextControl::setEdited):
2837         (WebCore::RenderTextControl::isUserEdited):
2838         * rendering/RenderTextControlSingleLine.cpp:
2839         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2840         * wml/WMLInputElement.cpp:
2841         (WebCore::WMLInputElement::defaultEventHandler):
2842
2843 2009-11-15  Daniel Bates  <dbates@webkit.org>
2844
2845         Reviewed by Darin Adler.
2846
2847         https://bugs.webkit.org/show_bug.cgi?id=31186
2848
2849         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2850         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2851         These are more descriptive names so as to clear an ambiguity surrounding
2852         their usage. Also, renames associated setters and getters so that they
2853         coincide with the renamed fields.
2854
2855         No functionality was changed. So, no tests were included.
2856
2857         * bindings/objc/DOMHTML.mm:
2858         (-[DOMHTMLInputElement _isEdited]):
2859         (-[DOMHTMLTextAreaElement _isEdited]):
2860         * dom/Document.cpp:
2861         (WebCore::Document::setFocusedNode):
2862         * html/HTMLInputElement.cpp:
2863         (WebCore::HTMLInputElement::defaultEventHandler):
2864         * rendering/RenderTextControl.cpp:
2865         (WebCore::RenderTextControl::RenderTextControl):
2866         (WebCore::RenderTextControl::setInnerTextValue):
2867         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2868         (WebCore::RenderTextControl::subtreeHasChanged):
2869         * rendering/RenderTextControl.h:
2870         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2871         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2872         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2873         * rendering/RenderTextControlSingleLine.cpp:
2874         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2875         * wml/WMLInputElement.cpp:
2876         (WebCore::WMLInputElement::defaultEventHandler):
2877
2878 2009-11-14  Adele Peterson  <adele@apple.com>
2879
2880         Reviewed by Dan Bernstein.
2881
2882         Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
2883
2884         Test: fast/overflow/line-clamp.html
2885
2886         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
2887         * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
2888         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
2889
2890         * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
2891         Use the line count value if available.  Otherwise, convert the percentage to the line count, as we did before.  Also,
2892         if there is anchor as the last child box, still allow adding the ellipsis.
2893
2894         * rendering/RenderLayer.cpp:
2895         (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
2896         (WebCore::RenderLayer::scrollRectToVisible): ditto.
2897
2898         * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
2899         * rendering/style/LineClampValue.h: Added.
2900         (WebCore::LineClampValue::LineClampValue):
2901         (WebCore::LineClampValue::value):
2902         (WebCore::LineClampValue::isPercentage):
2903         (WebCore::LineClampValue::isNone):
2904         (WebCore::LineClampValue::operator==):
2905         (WebCore::LineClampValue::operator!=):
2906         * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
2907
2908         * rendering/style/RenderStyle.h: Use LineClampValue.
2909         (WebCore::InheritedFlags::lineClamp):
2910         (WebCore::InheritedFlags::setLineClamp):
2911         (WebCore::InheritedFlags::initialLineClamp):
2912         * rendering/style/StyleRareNonInheritedData.h:
2913
2914 2009-11-14  Eric Carlson  <eric.carlson@apple.com>
2915
2916         Reviewed by Oliver Hunt.
2917
2918         <rdar://problem/7287487> 
2919         Do not use QuickTime version to detect media controller theme
2920
2921         * WebCore.base.exp: Export wkMediaControllerThemeAvailable
2922         * platform/mac/WebCoreSystemInterface.h: Ditto.
2923         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2924
2925         * rendering/RenderThemeMac.mm:
2926         (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
2927         QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
2928
2929 2009-11-14  Kent Tamura  <tkent@chromium.org>
2930
2931         Reviewed by Darin Adler.
2932
2933         - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
2934           They have no dedicated UI and no type validation for now.
2935         - Clean up setInputType() and formControlType() of HTMLInputElement.
2936         https://bugs.webkit.org/show_bug.cgi?id=29004
2937
2938         Test: fast/forms/input-type-change3.html
2939
2940         * html/HTMLInputElement.cpp:
2941         (WebCore::HTMLInputElement::valueMissing):
2942         (WebCore::HTMLInputElement::patternMismatch):
2943         (WebCore::HTMLInputElement::tooLong):
2944         (WebCore::createTypeMap):
2945         (WebCore::HTMLInputElement::setInputType):
2946         (WebCore::createFormControlTypes):
2947         (WebCore::HTMLInputElement::formControlType):
2948         (WebCore::HTMLInputElement::saveFormControlState):
2949         (WebCore::HTMLInputElement::restoreFormControlState):
2950         (WebCore::HTMLInputElement::accessKeyAction):
2951         (WebCore::HTMLInputElement::rendererIsNeeded):
2952         (WebCore::HTMLInputElement::createRenderer):
2953         (WebCore::HTMLInputElement::appendFormData):
2954         (WebCore::HTMLInputElement::isTextField):
2955         (WebCore::HTMLInputElement::valueWithDefault):
2956         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2957         (WebCore::HTMLInputElement::defaultEventHandler):
2958         (WebCore::HTMLInputElement::isRequiredFormControl):
2959         (WebCore::HTMLInputElement::dataList):
2960         * html/HTMLInputElement.h:
2961         (WebCore::HTMLInputElement::):
2962
2963 2009-11-13  Chris Fleizach  <cfleizach@apple.com>
2964
2965         Reviewed by Darin Adler.
2966
2967         WAI-ARIA: checkbox does not determine its label from text content
2968         https://bugs.webkit.org/show_bug.cgi?id=31456
2969
2970         Test: accessibility/aria-checkbox-text.html
2971
2972         * accessibility/AccessibilityRenderObject.cpp:
2973         (WebCore::AccessibilityRenderObject::title):
2974
2975 2009-11-13  Dimitri Glazkov  <dglazkov@chromium.org>
2976
2977         Unreviewed, build fix.
2978
2979         [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
2980         This is just enough changes to unbreak the port.
2981
2982         * bindings/v8/ScriptController.cpp:
2983         (WebCore::mainThreadNormalWorld):
2984         * bindings/v8/V8Proxy.cpp:
2985         (WebCore::V8Proxy::initContextIfNeeded):
2986         * loader/FrameLoaderClient.h:
2987
2988 2009-11-13  Aaron Boodman  <aa@chromium.org>
2989
2990         Unreviewed fix for Chromium build.
2991
2992         * loader/FrameLoaderClient.h:
2993         (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
2994         Provide an empty implementation of this method because I don't know
2995         what it is supposed to do on Chromium.
2996
2997 2009-11-13  Aaron Boodman  <aa@chromium.org>
2998
2999         Unreviewed fix for Chromium build.
3000
3001         * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
3002         public, as Chromium's V8Proxy calls it.
3003
3004 2009-11-13  Aaron Boodman  <aa@chromium.org>
3005
3006         Unreviewed fix to Chromium build.
3007
3008         * bindings/v8/ScriptController.cpp:
3009         (WebCore::ScriptController::getAllWorlds): 
3010
3011 2009-11-13  Aaron Boodman  <aa@chromium.org>
3012
3013         Unreviewed fix for Chromium build.
3014
3015         * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
3016
3017 2009-11-13  Adam Barth  <abarth@webkit.org>
3018
3019         Unreviewed partial build fix for Chromium.  Should fix failure #4.
3020
3021         * bindings/v8/ScriptController.cpp:
3022         (WebCore::ScriptController::getAllWorlds):
3023         * bindings/v8/ScriptController.h:
3024         * bindings/v8/V8Proxy.cpp:
3025         (WebCore::V8Proxy::initContextIfNeeded):
3026
3027 2009-11-13  Adam Barth  <abarth@webkit.org>
3028
3029         Unreviewed partial build fix for Chromium.
3030
3031         * bindings/v8/ScriptController.h:
3032         (WebCore::ScriptController::getAllWorlds):
3033
3034 2009-11-13  Eric Seidel  <eric@webkit.org>
3035
3036         No review, build fix only.
3037
3038         Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
3039
3040         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
3041         https://bugs.webkit.org/show_bug.cgi?id=31468
3042
3043         * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
3044         * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
3045
3046 2009-11-12  Jeremy Orlow  <jorlow@chromium.org>
3047
3048         Reviewed by Dmitry Titov.
3049
3050         LocalStorage quota should include key sizes in its count
3051         https://bugs.webkit.org/show_bug.cgi?id=31451
3052
3053         * storage/StorageMap.cpp:
3054         (WebCore::StorageMap::setItem):
3055             Count keys in the quota when adding a new item.
3056         (WebCore::StorageMap::removeItem):
3057             Remove the key's length from the quota if we're removing the item.
3058         (WebCore::StorageMap::importItem):
3059             Assume that we're adding things for the first time.
3060             Count keys in the quota.
3061
3062 2009-11-13  Dominik Röttsches  <dominik.roettsches@access-company.com>
3063
3064         Reviewed by Eric Seidel.
3065
3066         Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
3067         https://bugs.webkit.org/show_bug.cgi?id=31468
3068
3069         Moving TextBoundariesICU.cpp to TextBoundaries.cpp
3070         by removing the direct ICU dependency and replacing it
3071         with WTF functions and WebCore's own TextBreakIterator
3072         abstractions.
3073
3074         * GNUmakefile.am:
3075         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
3076         * platform/text/TextBoundaries.cpp: Added.
3077         (WebCore::findNextWordFromIndex):
3078         (WebCore::findWordBoundary):
3079         * platform/text/TextBoundariesICU.cpp: Removed.
3080         * platform/text/TextBreakIterator.h:
3081         * platform/text/TextBreakIteratorICU.cpp:
3082         (WebCore::textBreakLast):
3083         (WebCore::textBreakPrevious):
3084
3085 2009-11-13  Shinichiro Hamaji  <hamaji@chromium.org>
3086
3087         Reviewed by Darin Adler.
3088
3089         WebCore::externalRepresentation should update layout before getting render object
3090         https://bugs.webkit.org/show_bug.cgi?id=31459
3091
3092         * rendering/RenderTreeAsText.cpp:
3093         (WebCore::externalRepresentation):
3094
3095 2009-11-13  Adam Roben  <aroben@apple.com>
3096
3097         Tell FrameLoaderClient when window objects in isolated worlds are
3098         cleared
3099
3100         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3101         window objects in isolated worlds are cleared
3102
3103         Test: http/tests/security/isolatedWorld/didClearWindowObject.html
3104
3105         Reviewed by Dave Hyatt.
3106
3107         * bindings/js/JSDOMBinding.h:
3108         (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
3109         worlds in m_worldSet to the passed-in Vector.
3110
3111         * bindings/js/ScriptController.cpp:
3112         (WebCore::ScriptController::getAllWorlds): Added. Calls through to
3113         WebCoreJSClientData.
3114         (WebCore::ScriptController::initScript): Changed to call
3115         FrameLoader::dispatchDidClearWindowObjectInWorld.
3116
3117         * bindings/js/ScriptController.h: Added getAllWorlds.
3118
3119         * loader/EmptyClients.h:
3120         (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
3121         Updated for FrameLoaderClient change.
3122
3123         * loader/FrameLoader.cpp:
3124         (WebCore::FrameLoader::receivedFirstData):
3125         (WebCore::FrameLoader::begin):
3126         Changed to call dispatchDidClearWindowObjectsInAllWorlds.
3127
3128         (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
3129         Added. Retrieves all the worlds, then calls through to
3130         dispatchDidClearWindowObjectInWorld for each one.
3131         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
3132         dispatchWindowObjectAvailable. Calls up to the client, then, if the
3133         world is the mainThreadNormalWorld(), tells the Inspector about it,
3134         too.
3135
3136         * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
3137         dispatchDidClearWindowObjectInWorld. Added
3138         dispatchDidClearWindowObjectsInAllWorlds.
3139
3140         * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
3141         dispatchDidClearWindowObjectForWorld.
3142
3143 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
3144
3145         Reviewed by Dimitri Glazkov.
3146
3147         [V8] Fix SVG context assignment for pod types.
3148         https://bugs.webkit.org/show_bug.cgi?id=31497
3149
3150         I broke this in r50958.
3151
3152         Tested by svg/custom/viewport-update2.svg.
3153
3154         * bindings/scripts/CodeGeneratorV8.pm:
3155
3156 2009-11-13  Andrei Popescu  <andreip@google.com>
3157
3158         Reviewed by Dmitry Titov.
3159
3160         Bring the platform/android files inline with Android 2.0
3161         https://bugs.webkit.org/show_bug.cgi?id=31423
3162
3163         No new tests required: these are all Android-specific files.
3164
3165         * platform/android/ClipboardAndroid.cpp:
3166         (WebCore::ClipboardAndroid::files):
3167         * platform/android/ClipboardAndroid.h:
3168         * platform/android/FileChooserAndroid.cpp:
3169         (WebCore::FileChooser::basenameForWidth):
3170         (WebCore::fileButtonChooseFileLabel):
3171         * platform/android/KeyEventAndroid.cpp:
3172         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3173         * platform/android/LocalizedStringsAndroid.cpp:
3174         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
3175         (WebCore::contextMenuItemTagDownloadLinkToDisk):
3176         (WebCore::contextMenuItemTagCopyLinkToClipboard):
3177         (WebCore::contextMenuItemTagOpenImageInNewWindow):
3178         (WebCore::contextMenuItemTagDownloadImageToDisk):
3179         (WebCore::contextMenuItemTagCopyImageToClipboard):
3180         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
3181         (WebCore::contextMenuItemTagCopy):
3182         (WebCore::contextMenuItemTagGoBack):
3183         (WebCore::contextMenuItemTagGoForward):
3184         (WebCore::contextMenuItemTagStop):
3185         (WebCore::contextMenuItemTagReload):
3186         (WebCore::contextMenuItemTagCut):
3187         (WebCore::contextMenuItemTagPaste):
3188         (WebCore::contextMenuItemTagNoGuessesFound):
3189         (WebCore::contextMenuItemTagIgnoreSpelling):
3190         (WebCore::contextMenuItemTagLearnSpelling):
3191         (WebCore::contextMenuItemTagSearchWeb):
3192         (WebCore::contextMenuItemTagLookUpInDictionary):
3193         (WebCore::contextMenuItemTagOpenLink):
3194         (WebCore::contextMenuItemTagIgnoreGrammar):
3195         (WebCore::contextMenuItemTagSpellingMenu):
3196         (WebCore::contextMenuItemTagShowSpellingPanel):
3197         (WebCore::contextMenuItemTagCheckSpelling):
3198         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
3199         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
3200         (WebCore::contextMenuItemTagFontMenu):
3201         (WebCore::contextMenuItemTagBold):
3202         (WebCore::contextMenuItemTagItalic):
3203         (WebCore::contextMenuItemTagUnderline):
3204         (WebCore::contextMenuItemTagOutline):
3205         (WebCore::contextMenuItemTagWritingDirectionMenu):
3206         (WebCore::contextMenuItemTagTextDirectionMenu):
3207         (WebCore::contextMenuItemTagDefaultDirection):
3208         (WebCore::contextMenuItemTagLeftToRight):
3209         (WebCore::contextMenuItemTagRightToLeft):
3210         (WebCore::mediaElementLoadingStateText):
3211         (WebCore::mediaElementLiveBroadcastStateText):
3212         (WebCore::searchableIndexIntroduction):
3213         (WebCore::resetButtonDefaultLabel):
3214         (WebCore::submitButtonDefaultLabel):
3215         (WebCore::inputElementAltText):
3216         * platform/android/RenderThemeAndroid.cpp:
3217         (WebCore::RenderTheme::themeForPage):
3218         (WebCore::RenderThemeAndroid::baselinePosition):
3219         (WebCore::RenderThemeAndroid::paintButton):
3220         (WebCore::adjustMenuListStyleCommon):
3221         (WebCore::RenderThemeAndroid::paintCombo):
3222         * platform/android/ScreenAndroid.cpp:
3223         * platform/android/ScrollViewAndroid.cpp:
3224         (WebCore::ScrollView::platformOffscreenContentRectangle):
3225         * platform/android/TemporaryLinkStubs.cpp:
3226         (JSC::Bindings::dispatchJNICall):
3227         * platform/android/WidgetAndroid.cpp:
3228         (WebCore::Widget::setFrameRect):
3229
3230 2009-11-13  Norbert Leser  <norbert.leser&nokia.com>
3231
3232         Reviewed by Eric Seidel.
3233
3234         Added macros for USERINCLUDE paths within symbian blocks
3235         to guarantee inclusion of respective header files from local path
3236         first (to avoid clashes with same names of header files in system include path).
3237
3238         * WebCore.pro:
3239
3240 2009-11-13  Hironori Bono  <hbono@chromium.org>
3241
3242         Reviewed by Oliver Hunt.
3243
3244         Implement composition events introduced in DOM Level 3.
3245         This change adds a new IDL which defines the composition events, adds a class which
3246         implements the composition events, and sends the composition events according to
3247         the specification.
3248         https://bugs.webkit.org/show_bug.cgi?id=26310
3249
3250         Test: fast/events/ime-composition-events-001.html
3251
3252         * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
3253         * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
3254         * WebCore.gypi: ditto.
3255         * WebCore.pro: ditto
3256         * WebCore.vcproj/WebCore.vcproj: ditto.
3257         * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
3258         * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
3259         * bindings/js/JSEventCustom.cpp:
3260         (WebCore::toJS): Call isCompositionEvent() to create the CompositionEvent wrapper.
3261         * bindings/v8/DOMObjectsInclude.h: Added "JSCompositionEvent.h".
3262         * bindings/v8/DerivedSourcesAllInOne.cpp: Added "JSCompositionEvent.cpp".
3263         * bindings/v8/V8DOMWrapper.cpp: Call isCompositionEvent() to identify an event as a CompositionEvent.
3264         (WebCore::V8DOMWrapper::convertEventToV8Object):
3265         * bindings/v8/V8Index.cpp: Added "V8CompositionEvent.h".
3266         * bindings/v8/V8Index.h: Added V8Index::COMPOSITIONEVENT.
3267         * dom/CompositionEvent.cpp: Implements the CompositionEvent class.
3268         (WebCore::CompositionEvent::CompositionEvent):
3269         (WebCore::CompositionEvent::~CompositionEvent):
3270         (WebCore::CompositionEvent::initCompositionEvent):
3271         (WebCore::CompositionEvent::isCompositionEvent):
3272         * dom/CompositionEvent.h: Declares the CompositionEvent class.
3273         (WebCore::CompositionEvent::create):
3274         (WebCore::CompositionEvent::data):
3275         * dom/CompositionEvent.idl: Added the IDL of DOM CompositionEvent.
3276         * dom/Event.cpp:
3277         (WebCore::Event::isCompositionEvent): Added a method to identify an event is a CompositionEvent.
3278         * dom/Event.h:
3279         * dom/EventNames.h: Added composition{start,update,end} to eventNames.
3280         * editing/Editor.cpp:
3281         (WebCore::Editor::confirmComposition): Sent a CompositionEnd event.
3282         (WebCore::Editor::setComposition): Sent a Composition{Start,Update,End} event.
3283
3284 2009-11-13  Jens Alfke  <snej@chromium.org>
3285
3286         Reviewed by Dimitri Glazkov.
3287
3288         Fix a link error in unofficial GCC 4.4 builds on Linux.
3289         https://bugs.webkit.org/show_bug.cgi?id=31477
3290
3291         * bindings/v8/V8Binding.cpp:  Add explicit instantiations of v8StringToWebCoreString template.
3292
3293 2009-11-13  Eric Seidel  <eric@webkit.org>
3294
3295         No review, build fix only.
3296
3297         Fix Debug build after http://trac.webkit.org/changeset/50960.
3298
3299         The CounterNode class does not support all methods necessary to efficiently update the counter tree as needed per CSS2.1
3300         https://bugs.webkit.org/show_bug.cgi?id=31213
3301
3302         * rendering/CounterNode.cpp:
3303         (WebCore::showTreeAndMark):
3304         * rendering/RenderCounter.cpp:
3305         (WebCore::destroyCounterNodeChildren):
3306
3307 2009-11-13  Dirk Schulze  <krit@webkit.org>
3308
3309         Reviewed by Gustavo Noronha.
3310
3311         [CAIRO] shadow support for Canvas and SVG
3312         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3313
3314         We currently fill a path with solid color instead of filling
3315         a clipping path. This causes problems on some composite operators,
3316         since Cairo modifies the area outside the path.
3317         This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
3318
3319         Thanks to Benjamin Otte for tracking the bug down.
3320
3321         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3322         (WebCore::setPlatformFill):
3323
3324 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3325
3326         Reviewed by Dimitri Glazkov.
3327
3328         Adding Chromium's DatabaseTracker implementation.
3329
3330         https://bugs.webkit.org/show_bug.cgi?id=31440
3331
3332         * WebCore.gyp/WebCore.gyp:
3333         * WebCore.gypi:
3334         * storage/DatabaseTracker.h:
3335         * storage/chromium/DatabaseTrackerChromium.cpp:
3336         (WebCore::DatabaseTracker::fullPathForDatabase):
3337         (WebCore::DatabaseTracker::getMaxSizeForDatabase):
3338         * storage/chromium/QuotaTracker.cpp:
3339         (WebCore::QuotaTracker::updateDatabaseSize):
3340         * storage/chromium/QuotaTracker.h:
3341
3342 2009-11-13  Carol Szabo  <carol.szabo@nokia.com>
3343
3344         Reviewed by Darin Adler.
3345
3346         The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
3347         https://bugs.webkit.org/show_bug.cgi?id=31213
3348         Added tree navigation methods that permit full implementation of CSS2.1
3349         counter feature without using recursion proportional to the counter
3350         tree depth.
3351         No new tests because I did not find any bug that is fixed by this
3352         commit yet, this just reduces the size of the patch for 11031 and
3353         helps respond to some concerns regarding that patch.
3354
3355         * rendering/CounterNode.cpp:
3356         (WebCore::CounterNode::CounterNode):
3357
3358         (WebCore::CounterNode::nextInPreOrderAfterChildren):
3359         (WebCore::CounterNode::nextInPreOrder):
3360         Added to support non-recursive tree traversal necessary for
3361         efficient full implementation of CSS2.1 counters.
3362
3363         (WebCore::CounterNode::lastDescendant):
3364         (WebCore::CounterNode::previousInPreOrder):
3365         Moved this methods such that they occupy a place similar to that of
3366         identically named methods on the render tree. This allows for their
3367         broader use needed in full implementation of CSS2.1 counters.
3368
3369         (WebCore::CounterNode::resetRenderer):
3370         (WebCore::CounterNode::resetRenderers):
3371         (WebCore::CounterNode::recount):
3372         (WebCore::CounterNode::insertAfter):
3373         (WebCore::CounterNode::removeChild):
3374         Changed such that insertion/removal of a counter, triggers not only
3375         recalculation of PrefixWidths, but also reassesment of values in
3376         counter nodes. This is the basis full implementation of CSS2.1
3377         counters. It does not change current behavior by much because of
3378         changes needed to the recalculation algorithm, but those are comming
3379         in the patch for 11031.
3380         (WebCore::showTreeAndMark):
3381         * rendering/CounterNode.h:
3382         * rendering/RenderCounter.cpp:
3383         (WebCore::counter):
3384         Only changed argument type to prepare for implementation of Darin
3385         Adler's recommendation for the patch to 11031.
3386
3387         (WebCore::RenderCounter::invalidate):
3388         (WebCore::destroyCounterNodeChildren):
3389         (WebCore::RenderCounter::destroyCounterNodes):
3390         * rendering/RenderCounter.h:
3391         * rendering/RenderObjectChildList.cpp:
3392         (WebCore::invalidateCountersInContainer):
3393         (WebCore::RenderObjectChildList::invalidateCounters):
3394         * rendering/RenderObjectChildList.h:
3395         Added the ability to restrict invalidation to counters with a given
3396         identifier.
3397         Also invalidated counters that are on the child container itself
3398         which were missed by the previous algorithm, but were a valid case.
3399
3400 2009-11-13  Vitaly Repeshko  <vitalyr@chromium.org>
3401
3402         Reviewed by Dimitri Glazkov.
3403
3404         [V8] Protect SVG animated properties from destruction in bindings.
3405         https://bugs.webkit.org/show_bug.cgi?id=31474
3406
3407         See http://crbug.com/26719.
3408
3409         Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
3410         under Valgrind.
3411
3412         Made sure we keep a reference to SVG properties while setting a
3413         context:
3414         * bindings/scripts/CodeGeneratorV8.pm:
3415         * bindings/v8/V8Proxy.h:
3416         (WebCore::V8Proxy::withSVGContext):
3417
3418 2009-11-13  Brent Fulgham  <bfulgham@webkit.org>
3419
3420         Reviewed by Alexey Proskuryakov.
3421
3422         [CAIRO] shadow support for Canvas and SVG.
3423         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3424
3425         Incorporate Benjamin Otte's recommendations to avoid
3426         a buffer overrun, and small performance improvement.
3427
3428         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3429         (WebCore::copyContextProperties): Correctly size output
3430          storage for cairo_get_dash to avoid buffer overrun.
3431         (WebCore::drawPathShadow): Prefer cairo_fill_extents
3432          to slower cairo_stroke_extents when not drawing shadows.
3433
3434 2009-11-13  Dumitru Daniliuc  <dumi@chromium.org>
3435
3436         Reviewed by Dimitri Glazkov.
3437
3438         Do not register Chromium's HTML5 DB VFS as the default
3439         VFS. Otherwise, other sqlite DB users in the same process will
3440         stop working.
3441
3442         https://bugs.webkit.org/show_bug.cgi?id=31462
3443
3444         * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
3445         (WebCore::SQLiteFileSystem::openDatabase):
3446         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
3447         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
3448         * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
3449         (WebCore::SQLiteFileSystem::registerSQLiteVFS):
3450
3451 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
3452
3453         Windows build fix
3454
3455         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3456         (WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
3457         avoiding a sign mismatch warning.
3458
3459 2009-11-13  Alexey Proskuryakov  <ap@apple.com>
3460
3461         Release build fix.
3462
3463         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3464         (WebCore::SocketStreamHandle::readStreamCallback):
3465         (WebCore::SocketStreamHandle::writeStreamCallback):
3466         Use ASSERT_UNUSED for unused stream parameter.
3467
3468 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
3469
3470         Reviewed by Darin Adler.
3471
3472         https://bugs.webkit.org/show_bug.cgi?id=31441
3473         Implement SocketStreamHandleCFNet
3474
3475         Existing WebSocket tests now pass on Mac. No proxy support yet.
3476
3477         * platform/network/SocketStreamHandleClient.h:
3478         * platform/network/cf/SocketStreamHandle.h:
3479         (WebCore::SocketStreamHandle::shouldUseSSL):
3480         (WebCore::SocketStreamHandle::refAuthenticationClient):
3481         (WebCore::SocketStreamHandle::derefAuthenticationClient):
3482         (WebCore::SocketStreamHandle::):
3483         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3484         (WebCore::SocketStreamHandle::SocketStreamHandle):
3485         (WebCore::SocketStreamHandle::chooseProxy):
3486         (WebCore::SocketStreamHandle::createStreams):
3487         (WebCore::SocketStreamHandle::copyCFStreamDescription):
3488         (WebCore::SocketStreamHandle::readStreamCallback):
3489         (WebCore::SocketStreamHandle::writeStreamCallback):
3490         (WebCore::SocketStreamHandle::~SocketStreamHandle):
3491         (WebCore::SocketStreamHandle::platformSend):
3492         (WebCore::SocketStreamHandle::platformClose):
3493         (WebCore::SocketStreamHandle::receivedCredential):
3494         (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
3495         (WebCore::SocketStreamHandle::receivedCancellation):
3496
3497 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
3498
3499         Reviewed by Timothy Hatcher.
3500
3501         Web Inspector: preload status bar button glyphs
3502         in order to prevent them from flickering (take 2).
3503
3504         https://bugs.webkit.org/show_bug.cgi?id=31439
3505
3506         * inspector/front-end/inspector.js:
3507         (preloadImages):
3508
3509 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3510
3511         Reviewed by Adam Barth.
3512
3513         Chromium: [REGRESSION] Crash while stopping on a breakpoint.
3514         Rolling back r50890.
3515
3516         https://bugs.webkit.org/show_bug.cgi?id=31467
3517
3518         * bindings/v8/V8Proxy.cpp:
3519         (WebCore::V8Proxy::canAccessPrivate):
3520
3521 2009-11-13  Dirk Schulze  <krit@webkit.org>
3522
3523         Reviewed by Gustavo Noronha.
3524
3525         [CAIRO] shadow support for Canvas and SVG
3526         [https://bugs.webkit.org/show_bug.cgi?id=30960]
3527         
3528         This is the fix of a regression, caused by the shadow patch
3529         from the bug above. Reinserted the save and restore calls
3530         that were accidently removed by the previous patch.
3531
3532         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3533         (WebCore::setPlatformFill):
3534         (WebCore::setPlatformStroke):
3535
3536 2009-11-13  Pavel Feldman  <pfeldman@chromium.org>
3537
3538         Not reviewed. Reverting r50908 since it makes inspector tests
3539         time out.
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=31439
3542
3543         * inspector/front-end/inspector.js:
3544
3545 2009-11-13  Mikhail Naganov  <mnaganov@chromium.org>
3546
3547         Reviewed by Timothy Hatcher.
3548
3549         Enable 'console.profile()' and 'console.profileEnd()'
3550         regardless of JAVASCRIPT_DEBUGGER.
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=31293
3553
3554         * WebCore.gypi:
3555         * bindings/js/JSConsoleCustom.cpp:
3556         (WebCore::JSConsole::profile):
3557         (WebCore::JSConsole::profileEnd):
3558         * bindings/v8/custom/V8ConsoleCustom.cpp: Added.
3559         (WebCore::CALLBACK_FUNC_DECL):
3560         * bindings/v8/custom/V8CustomBinding.h:
3561         * page/Console.idl:
3562
3563 2009-11-12  David Levin  <levin@chromium.org>
3564
3565         Reviewed by NOBODY.
3566
3567         Chromium build fix.
3568
3569         * bindings/v8/ScriptController.h:
3570         (WebCore::ScriptController::evaluateInWorld): Add a dummy
3571          method which isn't called in chromium to make things compile.
3572
3573 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3574
3575         Reviewed by Adam Barth.
3576         
3577         The document-open.html test was flaky at times. The test invokes the layout test plugin
3578         which in its destroy stream handler opens a new document. This basically tears down the
3579         stream and the associated plugin instance, which causes a crash when the plugin stream
3580         dereferences an invalid m_client pointer which points to the PluginView instance which
3581         is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
3582         and check for the same.
3583        
3584         https://bugs.webkit.org/show_bug.cgi?id=31067
3585
3586         * plugins/PluginStream.cpp:
3587         (WebCore::PluginStream::stop):
3588         (WebCore::PluginStream::destroyStream):
3589
3590 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
3591
3592         Reviewed by Dimitri Glazkov.
3593
3594         Renaming some parameters passed to DB-related methods to better
3595         indicate their purpose.