2010-09-22 Chris Rogers <crogers@google.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2010-09-22  Chris Rogers  <crogers@google.com>
2
3         Reviewed by James Robinson.
4
5         Add HRTFKernel files
6         https://bugs.webkit.org/show_bug.cgi?id=45863
7
8         No new tests since audio API is not yet implemented.
9
10         * platform/audio/HRTFKernel.cpp: Added.
11         (WebCore::extractAverageGroupDelay):
12         (WebCore::HRTFKernel::HRTFKernel):
13         (WebCore::HRTFKernel::createImpulseResponse):
14         (WebCore::HRTFKernel::createInterpolatedKernel):
15         * platform/audio/HRTFKernel.h: Added.
16         (WebCore::HRTFKernel::create):
17         (WebCore::HRTFKernel::fftFrame):
18         (WebCore::HRTFKernel::fftSize):
19         (WebCore::HRTFKernel::frameDelay):
20         (WebCore::HRTFKernel::sampleRate):
21         (WebCore::HRTFKernel::nyquist):
22         (WebCore::HRTFKernel::HRTFKernel):
23
24 2010-09-22  Kent Tamura  <tkent@chromium.org>
25
26         Reviewed by Chris Fleizach.
27
28         Support keyboard operations for <input type=range>.
29         https://bugs.webkit.org/show_bug.cgi?id=45803
30
31         Increasing the value with Up/Right arrow keys by its step value,
32         and decreasing with Down/Left arrow keys. If an input element has
33         step=any attribute, increasing/decreasing by 1/100 of max-min.
34
35         Note: This change is not useful on Mac because users can't set
36         focus on range controls.
37
38         Test: fast/forms/range-keyoperation.html
39
40         * html/HTMLInputElement.cpp:
41         (WebCore::HTMLInputElement::defaultEventHandler):
42           Calls handleKeyEventForRange() for RANGE and key events.
43         (WebCore::HTMLInputElement::handleKeyEventForRange):
44         * html/HTMLInputElement.h: Add handleKeyEventForRange() declaration.
45
46 2010-09-22  Mario Sanchez Prada  <msanchez@igalia.com>
47
48         Reviewed by Chris Fleizach.
49
50         [Gtk] Incorrect exposure of list items whose children are elements
51         https://bugs.webkit.org/show_bug.cgi?id=45383
52
53         Set ATK_ROLE_LIST_ITEM looking for the role of the parent object
54
55         Test: platform/gtk/accessibility/list-items-always-exposed.html
56
57         * accessibility/gtk/AccessibilityObjectAtk.cpp:
58         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
59         Always include objects with ListItemRole in accessibility for GTK.
60         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
61         (getInterfaceMaskFromObject): Add some specific code to handle the
62         special case of list markers by implementing AtkText when needed.
63
64 2010-09-22  Dirk Schulze  <krit@webkit.org>
65
66         Reviewed by Nikolas Zimmermann.
67
68         Make FilterEffects independent of SVG
69         https://bugs.webkit.org/show_bug.cgi?id=46177
70
71         Moving all FilterEffects from svg/graphics/filters to platform/graphics/filters, now that they
72         are independent of SVG. Removed the SVG prefix of the files and updated the headers.
73
74         * Android.mk:
75         * CMakeLists.txt:
76         * GNUmakefile.am:
77         * WebCore.gypi:
78         * WebCore.pro:
79         * WebCore.vcproj/WebCore.vcproj:
80         * WebCore.xcodeproj/project.pbxproj:
81         * platform/graphics/filters/DistantLightSource.h: Copied from WebCore/svg/graphics/filters/SVGDistantLightSource.h.
82         * platform/graphics/filters/FEConvolveMatrix.cpp: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp.
83         * platform/graphics/filters/FEConvolveMatrix.h: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h.
84         * platform/graphics/filters/FEDiffuseLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.cpp.
85         * platform/graphics/filters/FEDiffuseLighting.h: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h.
86         * platform/graphics/filters/FEDisplacementMap.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.cpp.
87         * platform/graphics/filters/FEDisplacementMap.h: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.h.
88         * platform/graphics/filters/FEFlood.cpp: Copied from WebCore/svg/graphics/filters/SVGFEFlood.cpp.
89         * platform/graphics/filters/FEFlood.h: Copied from WebCore/svg/graphics/filters/SVGFEFlood.h.
90         * platform/graphics/filters/FELighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFELighting.cpp.
91         * platform/graphics/filters/FELighting.h: Copied from WebCore/svg/graphics/filters/SVGFELighting.h.
92         * platform/graphics/filters/FEMerge.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMerge.cpp.
93         * platform/graphics/filters/FEMerge.h: Copied from WebCore/svg/graphics/filters/SVGFEMerge.h.
94         * platform/graphics/filters/FEMorphology.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.cpp.
95         * platform/graphics/filters/FEMorphology.h: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.h.
96         * platform/graphics/filters/FEOffset.cpp: Copied from WebCore/svg/graphics/filters/SVGFEOffset.cpp.
97         * platform/graphics/filters/FEOffset.h: Copied from WebCore/svg/graphics/filters/SVGFEOffset.h.
98         * platform/graphics/filters/FESpecularLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.cpp.
99         * platform/graphics/filters/FESpecularLighting.h: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.h.
100         * platform/graphics/filters/FETile.cpp: Copied from WebCore/svg/graphics/filters/SVGFETile.cpp.
101         * platform/graphics/filters/FETile.h: Copied from WebCore/svg/graphics/filters/SVGFETile.h.
102         * platform/graphics/filters/FETurbulence.cpp: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.cpp.
103         * platform/graphics/filters/FETurbulence.h: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.h.
104         * platform/graphics/filters/LightSource.cpp: Copied from WebCore/svg/graphics/filters/SVGLightSource.cpp.
105         * platform/graphics/filters/LightSource.h: Copied from WebCore/svg/graphics/filters/SVGLightSource.h.
106         * platform/graphics/filters/PointLightSource.h: Copied from WebCore/svg/graphics/filters/SVGPointLightSource.h.
107         * platform/graphics/filters/SpotLightSource.h: Copied from WebCore/svg/graphics/filters/SVGSpotLightSource.h.
108         * svg/SVGFEConvolveMatrixElement.h:
109         * svg/SVGFEDiffuseLightingElement.cpp:
110         * svg/SVGFEDisplacementMapElement.h:
111         * svg/SVGFEDistantLightElement.cpp:
112         * svg/SVGFEFloodElement.h:
113         * svg/SVGFELightElement.h:
114         * svg/SVGFEMergeElement.h:
115         * svg/SVGFEMorphologyElement.h:
116         * svg/SVGFEOffsetElement.h:
117         * svg/SVGFEPointLightElement.cpp:
118         * svg/SVGFESpecularLightingElement.h:
119         * svg/SVGFESpotLightElement.cpp:
120         * svg/SVGFETileElement.h:
121         * svg/SVGFETurbulenceElement.h:
122         * svg/graphics/filters/SVGDistantLightSource.h: Removed.
123         * svg/graphics/filters/SVGFEConvolveMatrix.cpp: Removed.
124         * svg/graphics/filters/SVGFEConvolveMatrix.h: Removed.
125         * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Removed.
126         * svg/graphics/filters/SVGFEDiffuseLighting.h: Removed.
127         * svg/graphics/filters/SVGFEDisplacementMap.cpp: Removed.
128         * svg/graphics/filters/SVGFEDisplacementMap.h: Removed.
129         * svg/graphics/filters/SVGFEFlood.cpp: Removed.
130         * svg/graphics/filters/SVGFEFlood.h: Removed.
131         * svg/graphics/filters/SVGFELighting.cpp: Removed.
132         * svg/graphics/filters/SVGFELighting.h: Removed.
133         * svg/graphics/filters/SVGFEMerge.cpp: Removed.
134         * svg/graphics/filters/SVGFEMerge.h: Removed.
135         * svg/graphics/filters/SVGFEMorphology.cpp: Removed.
136         * svg/graphics/filters/SVGFEMorphology.h: Removed.
137         * svg/graphics/filters/SVGFEOffset.cpp: Removed.
138         * svg/graphics/filters/SVGFEOffset.h: Removed.
139         * svg/graphics/filters/SVGFESpecularLighting.cpp: Removed.
140         * svg/graphics/filters/SVGFESpecularLighting.h: Removed.
141         * svg/graphics/filters/SVGFETile.cpp: Removed.
142         * svg/graphics/filters/SVGFETile.h: Removed.
143         * svg/graphics/filters/SVGFETurbulence.cpp: Removed.
144         * svg/graphics/filters/SVGFETurbulence.h: Removed.
145         * svg/graphics/filters/SVGLightSource.cpp: Removed.
146         * svg/graphics/filters/SVGLightSource.h: Removed.
147         * svg/graphics/filters/SVGPointLightSource.h: Removed.
148         * svg/graphics/filters/SVGSpotLightSource.h: Removed.
149
150 2010-09-22  Patrick Gansterer  <paroga@webkit.org>
151
152         Reviewed by Adam Roben.
153
154         [WIN] Add internetHandle to WebCoreSynchronousLoader.
155         https://bugs.webkit.org/show_bug.cgi?id=46185
156
157         For loading content via network the WebCoreSynchronousLoader needs its own (synchronous) internetHandle.
158         This also adds asynchronousInternetHandle() to create a static asynchronous internetHandle.
159
160         * platform/network/win/ResourceHandleWin.cpp:
161         (WebCore::createInternetHandle):
162         (WebCore::asynchronousInternetHandle):
163         (WebCore::WebCoreSynchronousLoader::internetHandle):
164         (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Create synchronous internetHandle.
165         (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Delete synchronous internetHandle.
166
167 2010-09-22  Kwang Yul Seo  <skyul@company100.net>
168
169         Reviewed by Chris Fleizach.
170
171         [chromium] Remove unused sys/types.h in VDMXParser.cpp
172         https://bugs.webkit.org/show_bug.cgi?id=46136
173
174         sys/types.h is not needed here.
175
176         * platform/graphics/chromium/VDMXParser.cpp:
177
178 2010-09-22  Kwang Yul Seo  <skyul@company100.net>
179
180         Reviewed by Kent Tamura.
181
182         [BREWMP] Change the home directory path to the WebKit module directory
183         https://bugs.webkit.org/show_bug.cgi?id=45895
184
185         AEEFS_HOME_DIR denotes the currently running application's directory. 
186         Change it to fs:/~<clsid> to use the WebKit module directory as home.
187
188         * platform/brew/FileSystemBrew.cpp:
189         (WebCore::homeDirectoryPath):
190
191 2010-09-22  Kwang Yul Seo  <skyul@company100.net>
192
193         Reviewed by Kent Tamura.
194
195         [BREWMP] Add dummy Pasteboard
196         https://bugs.webkit.org/show_bug.cgi?id=46107
197
198         Pasteboard is not supported yet. Add dummy implementation to avoid link errors.
199
200         * platform/brew/PasteboardBrew.cpp: Added.
201         (WebCore::Pasteboard::generalPasteboard):
202         (WebCore::Pasteboard::Pasteboard):
203         (WebCore::Pasteboard::clear):
204         (WebCore::Pasteboard::writeSelection):
205         (WebCore::Pasteboard::writePlainText):
206         (WebCore::Pasteboard::writeURL):
207         (WebCore::Pasteboard::writeImage):
208         (WebCore::Pasteboard::canSmartReplace):
209         (WebCore::Pasteboard::plainText):
210         (WebCore::Pasteboard::documentFragment):
211
212 2010-09-21  Ryosuke Niwa  <rniwa@webkit.org>
213
214         Reviewed by Kent Tamura.
215
216         Each EntityMaskIn* needs explanation
217         https://bugs.webkit.org/show_bug.cgi?id=44833
218
219         Added a description as to why we escape nbsp when serializing HTML documents but not when serializing XML documents.
220
221         * editing/markup.cpp:
222
223 2010-09-21  Ryosuke Niwa  <rniwa@webkit.org>
224
225         Reviewed by Kent Tamura.
226
227         cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged
228         https://bugs.webkit.org/show_bug.cgi?id=46205
229
230         Cleanup required to fix the bug 27818. Added the style extraction mechanism to removeInlineStyleFromElement
231         and removeCSSStyle and replaced the call to extractInlineStyleToPushDown by a call to removeInlineStyleFromElement.
232
233         * editing/ApplyStyleCommand.cpp:
234         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle argument.
235         (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle argument.
236         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement instead of
237         extractInlineStyleToPushDown which has been deleted.
238         * editing/ApplyStyleCommand.h:
239
240 2010-09-21  Andrew Wilson  <atwilson@chromium.org>
241
242         Unreviewed, rolling out r67982.
243         http://trac.webkit.org/changeset/67982
244         https://bugs.webkit.org/show_bug.cgi?id=45156
245
246         Causes crashes on chromium testshell
247
248         * WebCore.gypi:
249         * accessibility/chromium/AXObjectCacheChromium.cpp:
250         (WebCore::AXObjectCache::postPlatformNotification):
251         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
252         (WebCore::AXObjectCache::handleScrolledToAnchor):
253         * dom/Document.cpp:
254         (WebCore::Document::implicitClose):
255         (WebCore::Document::setFocusedNode):
256         * editing/SelectionController.h:
257         * editing/chromium/SelectionControllerChromium.cpp: Removed.
258         * page/FrameView.cpp:
259         (WebCore::FrameView::layout):
260         * page/chromium/ChromeClientChromium.h:
261
262 2010-09-21  Cosmin Truta  <ctruta@chromium.org>
263
264         Reviewed by James Robinson.
265
266         RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
267         https://bugs.webkit.org/show_bug.cgi?id=46120
268
269         Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.
270
271         * rendering/RenderImage.h:
272         (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
273         * html/HTMLImageElement.cpp:
274         (HTMLImageElement::createRenderer): Fixed indentation.
275
276 2010-09-21  Kenneth Russell  <kbr@google.com>
277
278         Reviewed by James Robinson.
279
280         [chromium] Remove GLES2Context and WebGLES2Context
281         https://bugs.webkit.org/show_bug.cgi?id=46131
282
283         Removed now-obsolete GLES2Context and WebGLES2Context classes, and
284         dependency on command buffer client code from WebCore. Built and
285         tested 3D CSS and WebGL content on Mac OS X to test.
286
287         * WebCore.gypi:
288         * platform/chromium/GLES2Context.h: Removed.
289         * platform/graphics/skia/ImageSkia.cpp:
290
291 2010-09-21  Geoffrey Garen  <ggaren@apple.com>
292
293         Try to fix the Windows build.
294
295         * loader/Cache.cpp:
296         (WebCore::Cache::makeResourcePurgeable):
297         (WebCore::Cache::evict): Cast to int before using unary '-', to avoid an
298         MSVC warning.
299
300 2010-09-21  Pratik Solanki  <psolanki@apple.com>
301
302         Reviewed by Geoffrey Garen and Darin Adler.
303
304         Use purgeable memory to keep more dead resources in cache
305         https://bugs.webkit.org/show_bug.cgi?id=44806
306         <rdar://problem/8350901>
307
308         This changes the behavior of dead resources in the WebCore cache to be the following if
309         shouldMakeResourcePurgeableOnEviction() returns true.
310
311         1. Dead resources in the cache are kept in non-purgeable memory.
312         2. When we prune dead resources, instead of freeing them, we mark their memory as purgeable
313         and keep the resources until the kernel reclaims the purgeable memory.
314
315         By leaving the in-cache dead resources in dirty resident memory, we decrease the likelihood
316         of the kernel claiming that memory and forcing us to refetch the resource (for example when
317         a user presses back).
318
319         And by having an unbounded number of resource objects using purgeable memory, we can use
320         as much memory as is available on the machine. The trade-off is that the CachedResource
321         object (and its member variables) are allocated in non-purgeable TC-malloc'd memory so
322         we would see slightly more memory use due to this.
323
324         * loader/Cache.cpp:
325         (WebCore::Cache::resourceForURL): Adjust sizes appropriately if we made resource memory
326         non-purgeable.
327         (WebCore::Cache::pruneDeadResources): When removing dead resources, try first to mark their
328         memory as purgeable. If not, evict the resource.
329         (WebCore::Cache::makeResourcePurgeable): Added. Try to mark resource
330         memory as purgeable. If successful, adjust the sizes so that we don't
331         factor this resources size in the Cache size calculation.
332         (WebCore::Cache::evict): Don't decrement size if we already did it in makeResourcePurgeable.
333         (WebCore::Cache::dumpLRULists): Extra debug logging.
334         * loader/Cache.h:
335         (WebCore::Cache::shouldMakeResourcePurgeableOnEviction): Added. Indicates if the new
336         behaviour is enabled.
337         * loader/CachedCSSStyleSheet.cpp:
338         (WebCore::CachedCSSStyleSheet::allClientsRemoved): Do not mark memory as purgeable. The
339         Cache class takes care of this.
340         * loader/CachedImage.cpp:
341         (WebCore::CachedImage::destroyDecodedData): Ditto.
342         * loader/CachedScript.cpp:
343         (WebCore::CachedScript::destroyDecodedData): Ditto.
344
345 2010-09-21  Dan Bernstein  <mitz@apple.com>
346
347         Reviewed by Darin Adler.
348
349         <rdar://problem/7729077> Extending the selection to sentence boundary after a line break may select extra character
350         https://bugs.webkit.org/show_bug.cgi?id=46232
351
352         Test: editing/selection/extend-by-sentence-002.html
353
354         * editing/visible_units.cpp:
355         (WebCore::nextBoundary): The text iterator’s range end can be the position after
356         the line break, in which case the next visible is actually after the first character
357         of the next sentence. Instead, advance the text iterator past the newline character
358         and return the beginning of its range, which is guaranteed to still be before the
359         next sentence.
360
361 2010-09-21  Robert Hogan  <robert@webkit.org>
362
363         Rubber-stamped by Ariya Hidayat.
364
365         [Qt] Build fix against qt trunk
366
367         * platform/graphics/qt/ContextShadow.cpp:
368         (WebCore::ContextShadow::beginShadowLayer):
369
370 2010-09-21  Tony Chang  <tony@chromium.org>
371
372         Unreviewed, QT build fix.
373
374         * platform/qt/ClipboardQt.cpp:
375         (WebCore::ClipboardQt::ClipboardQt):
376
377 2010-09-21  Andy Estes  <aestes@apple.com>
378
379         Reviewed by Darin Adler.
380
381         REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
382         https://bugs.webkit.org/show_bug.cgi?id=46134
383
384         * WebCore.exp.in: Export __ZN7WebCore32applicationIsAOLInstantMessengerEv.
385         * platform/mac/RuntimeApplicationChecks.h:
386         * platform/mac/RuntimeApplicationChecks.mm:
387         (WebCore::applicationIsAOLInstantMessenger): Determine if the embedding
388         application is AOL Instant Messenger by checking the bundle identifier.
389
390 2010-09-21  Chris Guillory   <chris.guillory@google.com>
391
392         Reviewed by Chris Fleizach.
393
394         Send webkit accessibility notifications to Chromium.
395         https://bugs.webkit.org/show_bug.cgi?id=45156
396
397         * WebCore.gypi:
398         * accessibility/chromium/AXObjectCacheChromium.cpp:
399         (WebCore::AXObjectCache::postPlatformNotification):
400         (WebCore::AXObjectCache::handleFocusedUIElementChanged):
401         (WebCore::AXObjectCache::handleScrolledToAnchor):
402         * dom/Document.cpp:
403         (WebCore::Document::implicitClose):
404         (WebCore::Document::setFocusedNode):
405         * editing/SelectionController.h:
406         * editing/chromium/SelectionControllerChromium.cpp: Added.
407         (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
408         * page/FrameView.cpp:
409         (WebCore::FrameView::layout):
410         * page/chromium/ChromeClientChromium.h:
411
412 2010-09-21  Alejandro G. Castro  <alex@igalia.com>
413
414         Reviewed by Martin Robinson.
415
416         [gtk] Move copyContextProperties outside the GraphicsContextCairo
417         https://bugs.webkit.org/show_bug.cgi?id=46179.
418
419         Moved the copyContextProperties function to the CairoUtilities so
420         we can use it outside GraphicsContextCairo. We moved also the old
421         gtk CairoUtilities file to GdkCairoUtilities and added the new
422         file in the cairo directory.
423
424         * GNUmakefile.am:
425         * platform/graphics/cairo/CairoUtilities.cpp: Added.
426         (WebCore::copyContextProperties):
427         * platform/graphics/cairo/CairoUtilities.h: Added.
428         * platform/graphics/cairo/GraphicsContextCairo.cpp:
429         * platform/graphics/gtk/CairoUtilities.cpp: Removed.
430         * platform/graphics/gtk/CairoUtilities.h: Removed.
431         * platform/graphics/gtk/GdkCairoUtilities.cpp: Added.
432         (getCairoSurfacePixel):
433         (getGdkPixbufPixel):
434         (cairoImageSurfaceToGdkPixbuf):
435         * platform/graphics/gtk/GdkCairoUtilities.h: Added.
436         * platform/graphics/gtk/ImageBufferGtk.cpp:
437         * platform/graphics/gtk/ImageGtk.cpp:
438
439 2010-09-21  Vangelis Kokkevis  <vangelis@chromium.org>
440
441         Reviewed by James Robinson.
442
443         [chromium] Cleaned up LayerRendererChromium::prepareToDrawLayers
444         logic to avoid unnecessary copy operations if the existing root layer
445         contents aren't useful for scrolling. Also removed call to updateLayersRecursive()
446         as the composited layer update is actually happening in the drawLayers() method.
447         https://bugs.webkit.org/show_bug.cgi?id=46199
448
449
450         * platform/graphics/chromium/LayerRendererChromium.cpp:
451         (WebCore::LayerRendererChromium::prepareToDrawLayers):
452
453 2010-09-21  Daniel Cheng  <dcheng@chromium.org>
454
455         Reviewed by Tony Chang.
456
457         Change Clipboard to use an enum instead of isForDragging = true/false
458         https://bugs.webkit.org/show_bug.cgi?id=46004
459
460         No new tests, since it's just a refactoring change.
461
462         * bindings/js/JSClipboardCustom.cpp:
463         (WebCore::JSClipboard::setDragImage):
464         * bindings/v8/custom/V8ClipboardCustom.cpp:
465         (WebCore::V8Clipboard::setDragImageCallback):
466         * dom/Clipboard.cpp:
467         (WebCore::Clipboard::Clipboard):
468         (WebCore::Clipboard::setDropEffect):
469         (WebCore::Clipboard::setEffectAllowed):
470         * dom/Clipboard.h:
471         (WebCore::Clipboard::isForCopyAndPaste):
472         (WebCore::Clipboard::isForDragAndDrop):
473         * editing/android/EditorAndroid.cpp:
474         (WebCore::Editor::newGeneralClipboard):
475         * editing/brew/EditorBrew.cpp:
476         (WebCore::Editor::newGeneralClipboard):
477         * editing/chromium/EditorChromium.cpp:
478         (WebCore::Editor::newGeneralClipboard):
479         * editing/haiku/EditorHaiku.cpp:
480         (WebCore::Editor::newGeneralClipboard):
481         * editing/mac/EditorMac.mm:
482         (WebCore::Editor::newGeneralClipboard):
483         * editing/wx/EditorWx.cpp:
484         (WebCore::Editor::newGeneralClipboard):
485         * page/chromium/EventHandlerChromium.cpp:
486         (WebCore::EventHandler::createDraggingClipboard):
487         * page/efl/EventHandlerEfl.cpp:
488         (WebCore::EventHandler::createDraggingClipboard):
489         * page/gtk/EventHandlerGtk.cpp:
490         (WebCore::EventHandler::createDraggingClipboard):
491         * page/haiku/EventHandlerHaiku.cpp:
492         (WebCore::EventHandler::createDraggingClipboard):
493         * page/mac/EventHandlerMac.mm:
494         (WebCore::EventHandler::createDraggingClipboard):
495         * page/qt/EventHandlerQt.cpp:
496         (WebCore::EventHandler::createDraggingClipboard):
497         * page/win/EventHandlerWin.cpp:
498         (WebCore::EventHandler::createDraggingClipboard):
499         * page/wx/EventHandlerWx.cpp:
500         (WebCore::EventHandler::createDraggingClipboard):
501         * platform/android/ClipboardAndroid.cpp:
502         (WebCore::ClipboardAndroid::ClipboardAndroid):
503         (WebCore::ClipboardAndroid::clearData):
504         (WebCore::ClipboardAndroid::clearAllData):
505         (WebCore::ClipboardAndroid::setData):
506         * platform/android/ClipboardAndroid.h:
507         * platform/brew/ClipboardBrew.cpp:
508         (WebCore::ClipboardBrew::ClipboardBrew):
509         (WebCore::ClipboardBrew::clearData):
510         (WebCore::ClipboardBrew::clearAllData):
511         (WebCore::ClipboardBrew::setData):
512         * platform/brew/ClipboardBrew.h:
513         * platform/chromium/ClipboardChromium.cpp:
514         (WebCore::Clipboard::create):
515         (WebCore::ClipboardChromium::ClipboardChromium):
516         (WebCore::ClipboardChromium::create):
517         (WebCore::ClipboardChromium::getData):
518         * platform/chromium/ClipboardChromium.h:
519         * platform/efl/ClipboardEfl.cpp:
520         (WebCore::Editor::newGeneralClipboard):
521         (WebCore::ClipboardEfl::ClipboardEfl):
522         * platform/efl/ClipboardEfl.h:
523         (WebCore::ClipboardEfl::create):
524         * platform/gtk/ClipboardGtk.cpp:
525         (WebCore::Editor::newGeneralClipboard):
526         (WebCore::Clipboard::create):
527         (WebCore::ClipboardGtk::ClipboardGtk):
528         (WebCore::dataObjectTypeFromHTMLClipboardType):
529         (WebCore::ClipboardGtk::clearData):
530         (WebCore::ClipboardGtk::getData):
531         (WebCore::ClipboardGtk::setData):
532         * platform/gtk/ClipboardGtk.h:
533         (WebCore::ClipboardGtk::create):
534         * platform/haiku/ClipboardHaiku.cpp:
535         (WebCore::Clipboard::create):
536         (WebCore::ClipboardHaiku::ClipboardHaiku):
537         * platform/haiku/ClipboardHaiku.h:
538         (WebCore::ClipboardHaiku::create):
539         * platform/mac/ClipboardMac.h:
540         (WebCore::ClipboardMac::create):
541         * platform/mac/ClipboardMac.mm:
542         (WebCore::Clipboard::create):
543         (WebCore::ClipboardMac::ClipboardMac):
544         * platform/qt/ClipboardQt.cpp:
545         (WebCore::ClipboardQt::ClipboardQt):
546         (WebCore::ClipboardQt::~ClipboardQt):
547         (WebCore::ClipboardQt::clearData):
548         (WebCore::ClipboardQt::clearAllData):
549         (WebCore::ClipboardQt::setData):
550         (WebCore::ClipboardQt::declareAndWriteDragImage):
551         (WebCore::ClipboardQt::writeURL):
552         (WebCore::ClipboardQt::writeRange):
553         (WebCore::ClipboardQt::writePlainText):
554         * platform/qt/ClipboardQt.h:
555         (WebCore::ClipboardQt::create):
556         * platform/win/ClipboardWin.cpp:
557         (WebCore::Clipboard::create):
558         (WebCore::ClipboardWin::ClipboardWin):
559         (WebCore::ClipboardWin::clearData):
560         (WebCore::ClipboardWin::clearAllData):
561         (WebCore::ClipboardWin::setData):
562         (WebCore::ClipboardWin::setExternalDataObject):
563         * platform/win/ClipboardWin.h:
564         (WebCore::ClipboardWin::create):
565         * platform/win/EditorWin.cpp:
566         (WebCore::Editor::newGeneralClipboard):
567         * platform/wx/ClipboardWx.cpp:
568         (WebCore::ClipboardWx::ClipboardWx):
569         * platform/wx/ClipboardWx.h:
570         (WebCore::ClipboardWx::create):
571
572 2010-09-21  Abhishek Arya  <inferno@chromium.org>
573
574         Reviewed by Dave Hyatt.
575
576         Take isValueList() checks out of the asserts for memory safety.
577         https://bugs.webkit.org/show_bug.cgi?id=46194
578
579         Test: editing/execCommand/apply-style-text-decoration-crash.html
580
581         * editing/ApplyStyleCommand.cpp:
582         (WebCore::StyleChange::extractTextStyles):
583         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
584
585 2010-09-21  Vangelis Kokkevis  <vangelis@chromium.org>
586
587         Reviewed by Kenneth Russell.
588
589         [chromium] Fixing double translation of composited layers when scrolling.
590         The scrolling transform is now applied by a separate layer maintained in
591         the RenderLayerCompositor.
592         https://bugs.webkit.org/show_bug.cgi?id=46193
593
594         * platform/graphics/chromium/LayerRendererChromium.cpp:
595         (WebCore::LayerRendererChromium::drawLayers):
596
597 2010-09-21  David Hyatt  <hyatt@apple.com>
598
599         Reviewed by Dan Bernstein.
600
601         https://bugs.webkit.org/show_bug.cgi?id=46196, add marginStart/Before/End/After accessors to RenderBoxModelObject.
602
603         * rendering/RenderBox.cpp:
604         (WebCore::RenderBox::marginBefore):
605         (WebCore::RenderBox::marginAfter):
606         (WebCore::RenderBox::marginStart):
607         (WebCore::RenderBox::marginEnd):
608         * rendering/RenderBox.h:
609         * rendering/RenderBoxModelObject.h:
610         * rendering/RenderInline.cpp:
611         (WebCore::computeMargin):
612         (WebCore::RenderInline::marginLeft):
613         (WebCore::RenderInline::marginRight):
614         (WebCore::RenderInline::marginTop):
615         (WebCore::RenderInline::marginBottom):
616         (WebCore::RenderInline::marginStart):
617         (WebCore::RenderInline::marginEnd):
618         * rendering/RenderInline.h:
619         (WebCore::RenderInline::marginBefore):
620         (WebCore::RenderInline::marginAfter):
621
622 2010-09-21  David Hyatt  <hyatt@apple.com>
623
624         Reviewed by Dan Bernstein.
625
626         https://bugs.webkit.org/show_bug.cgi?id=46190, add borderStart/Before/End/After accessors to RenderBoxModelObject.
627
628         * rendering/RenderBoxModelObject.h:
629         (WebCore::RenderBoxModelObject::borderBefore):
630         (WebCore::RenderBoxModelObject::borderAfter):
631         (WebCore::RenderBoxModelObject::borderStart):
632         (WebCore::RenderBoxModelObject::borderEnd):
633         (WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
634         (WebCore::RenderBoxModelObject::borderAndPaddingLogicalWidth):
635         * rendering/RenderTableCell.cpp:
636         (WebCore::RenderTableCell::borderStart):
637         (WebCore::RenderTableCell::borderEnd):
638         (WebCore::RenderTableCell::borderBefore):
639         (WebCore::RenderTableCell::borderAfter):
640         * rendering/RenderTableCell.h:
641
642 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
643
644         Reviewed by Xan Lopez.
645
646         [GTK] 'make dist' should be fixed in preparation for the next release
647         https://bugs.webkit.org/show_bug.cgi?id=46129
648
649         * GNUmakefile.am: Update the sources list to include missing headers.
650
651 2010-09-21  David Hyatt  <hyatt@apple.com>
652
653         Reviewed by John Sullivan.
654
655         https://bugs.webkit.org/show_bug.cgi?id=46188, make the cross-platform setPrinting method match the Mac version of the method.
656         Specifically don't pass the page size down to subframes of the one you're printing.
657
658         * page/Frame.cpp:
659         (WebCore::Frame::setPrinting):
660
661 2010-09-21  Patrick Gansterer  <paroga@webkit.org>
662
663         Reviewed by Adam Roben.
664
665         Use WTF::Vector for storing formData in ResourceHandleWin.
666         https://bugs.webkit.org/show_bug.cgi?id=46180
667
668         * platform/network/ResourceHandleInternal.h:
669         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
670         * platform/network/win/ResourceHandleWin.cpp:
671         (WebCore::ResourceHandle::onHandleCreated):
672         (WebCore::ResourceHandle::onRequestComplete):
673
674 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
675
676         Reviewed by Andreas Kling.
677
678         [Qt] Check if the reply has been deleted before finishing a network request
679         https://bugs.webkit.org/show_bug.cgi?id=46174
680
681         A crash can happen with the following sequence:
682         1. QNetworkReplyHandler::abort() emits reply->deleteLater()
683         2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
684         3. event loop would call reply->deleteLater()
685         However a crash occurs since m_reply == 0 on step 2.
686
687         * platform/network/qt/QNetworkReplyHandler.cpp:
688         (WebCore::QNetworkReplyHandler::finish):
689
690 2010-09-21  Jochen Eisinger  <jochen@chromium.org>
691
692         Reviewed by Jeremy Orlow.
693
694         Use @ to concatenate the database name and the database identifier when building
695         the filename to use for indexed databases. That character is valid for filenames
696         but cannot occur in a database identifier derived from a security origin.
697         https://bugs.webkit.org/show_bug.cgi?id=46178
698
699         * storage/IDBFactoryBackendImpl.cpp:
700         (WebCore::IDBFactoryBackendImpl::databaseFileName):
701
702 2010-09-21  Steve Block  <steveblock@google.com>
703
704         Reviewed by Jeremy Orlow.
705
706         DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
707         https://bugs.webkit.org/show_bug.cgi?id=45891
708
709         Tested by existing DeviceOrientation tests.
710
711         * dom/DeviceMotionClient.h:
712         * dom/DeviceMotionController.cpp:
713         (WebCore::DeviceMotionController::~DeviceMotionController):
714         * dom/DeviceMotionController.h:
715         * dom/DeviceOrientationClient.h:
716         * dom/DeviceOrientationController.cpp:
717         (WebCore::DeviceOrientationController::~DeviceOrientationController):
718         * dom/DeviceOrientationController.h:
719         * loader/EmptyClients.h:
720         (WebCore::EmptyDeviceMotionClient::deviceOrientationControllerDestroyed):
721         (WebCore::EmptyDeviceOrientationClient::deviceOrientationControllerDestroyed):
722         * platform/mock/DeviceOrientationClientMock.h:
723         (WebCore::DeviceOrientationClientMock::deviceOrientationControllerDestroyed):
724
725 2010-09-21  Jochen Eisinger  <jochen@chromium.org>
726
727         Reviewed by Jeremy Orlow.
728
729         Factor out the file name used for a given indexed database to a static method.
730         https://bugs.webkit.org/show_bug.cgi?id=46090
731
732         * storage/IDBFactoryBackendImpl.cpp:
733         (WebCore::openSQLiteDatabase):
734         (WebCore::IDBFactoryBackendImpl::databaseFileName):
735         * storage/IDBFactoryBackendImpl.h:
736
737 2010-09-21  Dirk Schulze  <krit@webkit.org>
738
739         SVG Filter cleanup
740         https://bugs.webkit.org/show_bug.cgi?id=45612
741
742         Unreviewed change of epsilon back to a more tolerant value in RenderTreeAsText and made it a static const.
743         This should turn the bots green again.
744
745         * rendering/RenderTreeAsText.cpp:
746         (WebCore::hasFractions):
747
748 2010-09-21  David Hyatt  <hyatt@apple.com>
749
750         Reviewed by Dan Bernstein.
751
752         https://bugs.webkit.org/show_bug.cgi?id=46125, convert table cell intrinsic padding from top/bottom-based
753         to before/after-based.  A vertical text table can have intrinsic padding built into the left/right
754         direction (and this allows the base class logical padding methods on RenderBoxModelObject to be safe to use).
755
756         * rendering/RenderTableCell.cpp:
757         (WebCore::RenderTableCell::RenderTableCell):
758         (WebCore::RenderTableCell::paddingTop):
759         (WebCore::RenderTableCell::paddingBottom):
760         (WebCore::RenderTableCell::paddingLeft):
761         (WebCore::RenderTableCell::paddingRight):
762         (WebCore::RenderTableCell::paddingBefore):
763         (WebCore::RenderTableCell::paddingAfter):
764         * rendering/RenderTableCell.h:
765         (WebCore::RenderTableCell::setIntrinsicPaddingBefore):
766         (WebCore::RenderTableCell::setIntrinsicPaddingAfter):
767         (WebCore::RenderTableCell::setIntrinsicPadding):
768         (WebCore::RenderTableCell::intrinsicPaddingBefore):
769         (WebCore::RenderTableCell::intrinsicPaddingAfter):
770         * rendering/RenderTableSection.cpp:
771         (WebCore::RenderTableSection::calcRowHeight):
772         (WebCore::RenderTableSection::layoutRows):
773         * rendering/RenderTreeAsText.cpp:
774         (WebCore::RenderTreeAsText::writeRenderObject):
775         (WebCore::writeTextRun):
776
777 2010-09-21  Dirk Schulze  <krit@webkit.org>
778
779         Reviewed by Nikolas Zimmermann.
780
781         SVG Filter cleanup
782         https://bugs.webkit.org/show_bug.cgi?id=45612
783
784         Second cleanup patch. Modified files to follow webkit style. Removed dependencies
785         to SVG of most of the filter effects and prepared them to move from WebCore/svg/graphics/filters
786         to WebCore/platform/graphics/filters/.
787         Renamed calculateDrawingIntRect and calculateDrawingRect to requestedRegionOfInputImageData and
788         drawingRegionOfInputImage to clarify the functionality and make both functions distinguishable.
789
790         * platform/graphics/filters/FEBlend.cpp:
791         (WebCore::FEBlend::apply):
792         * platform/graphics/filters/FEBlend.h:
793         * platform/graphics/filters/FEColorMatrix.cpp:
794         (WebCore::FEColorMatrix::apply):
795         * platform/graphics/filters/FEColorMatrix.h:
796         * platform/graphics/filters/FEComponentTransfer.cpp:
797         (WebCore::FEComponentTransfer::apply):
798         * platform/graphics/filters/FEComponentTransfer.h:
799         (WebCore::ComponentTransferFunction::ComponentTransferFunction):
800         * platform/graphics/filters/FEComposite.cpp:
801         (WebCore::FEComposite::apply):
802         * platform/graphics/filters/FEComposite.h:
803         * platform/graphics/filters/FEGaussianBlur.cpp:
804         (WebCore::FEGaussianBlur::apply):
805         * platform/graphics/filters/FEGaussianBlur.h:
806         * platform/graphics/filters/Filter.h:
807         * platform/graphics/filters/FilterEffect.cpp:
808         (WebCore::FilterEffect::requestedRegionOfInputImageData):
809         (WebCore::FilterEffect::drawingRegionOfInputImage):
810         (WebCore::FilterEffect::effectContext):
811         * platform/graphics/filters/FilterEffect.h:
812         * platform/graphics/filters/ImageBufferFilter.cpp:
813         * platform/graphics/filters/ImageBufferFilter.h:
814         * platform/graphics/filters/SourceAlpha.cpp:
815         (WebCore::SourceAlpha::apply):
816         * platform/graphics/filters/SourceAlpha.h:
817         (WebCore::SourceAlpha::isSourceInput):
818         (WebCore::SourceAlpha::SourceAlpha):
819         * platform/graphics/filters/SourceGraphic.cpp:
820         (WebCore::SourceGraphic::apply):
821         * platform/graphics/filters/SourceGraphic.h:
822         (WebCore::SourceGraphic::isSourceInput):
823         (WebCore::SourceGraphic::SourceGraphic):
824         * rendering/RenderTreeAsText.cpp:
825         (WebCore::hasFractions):
826         (WebCore::operator<<):
827         * rendering/RenderTreeAsText.h:
828         (WebCore::operator<<):
829         * rendering/SVGRenderTreeAsText.cpp:
830         * rendering/SVGRenderTreeAsText.h:
831         * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
832         (WebCore::FEConvolveMatrix::apply):
833         * svg/graphics/filters/SVGFEConvolveMatrix.h:
834         * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
835         * svg/graphics/filters/SVGFEDiffuseLighting.h:
836         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
837         (WebCore::FEDisplacementMap::apply):
838         * svg/graphics/filters/SVGFEDisplacementMap.h:
839         * svg/graphics/filters/SVGFEFlood.cpp:
840         (WebCore::FEFlood::apply):
841         (WebCore::FEFlood::externalRepresentation):
842         * svg/graphics/filters/SVGFEFlood.h:
843         * svg/graphics/filters/SVGFEImage.cpp:
844         (WebCore::FEImage::apply):
845         * svg/graphics/filters/SVGFEImage.h:
846         * svg/graphics/filters/SVGFELighting.cpp:
847         (WebCore::FELighting::apply):
848         * svg/graphics/filters/SVGFELighting.h:
849         * svg/graphics/filters/SVGFEMerge.cpp:
850         (WebCore::FEMerge::apply):
851         * svg/graphics/filters/SVGFEMerge.h:
852         * svg/graphics/filters/SVGFEMorphology.cpp:
853         (WebCore::FEMorphology::apply):
854         * svg/graphics/filters/SVGFEMorphology.h:
855         * svg/graphics/filters/SVGFEOffset.cpp:
856         (WebCore::FEOffset::apply):
857         * svg/graphics/filters/SVGFEOffset.h:
858         * svg/graphics/filters/SVGFESpecularLighting.cpp:
859         * svg/graphics/filters/SVGFESpecularLighting.h:
860         * svg/graphics/filters/SVGFETile.cpp:
861         (WebCore::FETile::apply):
862         * svg/graphics/filters/SVGFETile.h:
863         * svg/graphics/filters/SVGFETurbulence.cpp:
864         (WebCore::FETurbulence::apply):
865         * svg/graphics/filters/SVGFETurbulence.h:
866
867 2010-09-20  Philippe Normand  <pnormand@igalia.com>
868
869         Reviewed by Eric Carlson.
870
871         [GTK] enhanced context menu for media elements
872         https://bugs.webkit.org/show_bug.cgi?id=45021
873
874         New items in the media Element context menu:
875         - play/pause
876         - mute/unmute
877         - controls display control
878         - switch to fullscreen (for video only)
879         - loop playback control
880         - copy media url to clipboard
881         - open in new window
882
883         Test: media/context-menu-actions.html
884
885         * page/ContextMenuController.cpp:
886         (WebCore::ContextMenuController::contextMenuItemSelected):
887         * platform/ContextMenu.cpp:
888         (WebCore::ContextMenu::populate):
889         (WebCore::ContextMenu::checkOrEnableIfNeeded):
890         * platform/ContextMenuItem.h:
891         * platform/LocalizationStrategy.h:
892         * platform/LocalizedStrings.cpp:
893         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
894         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
895         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
896         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
897         (WebCore::contextMenuItemTagToggleMediaControls):
898         (WebCore::contextMenuItemTagToggleMediaLoop):
899         (WebCore::contextMenuItemTagEnterVideoFullscreen):
900         (WebCore::contextMenuItemTagMediaPlay):
901         (WebCore::contextMenuItemTagMediaPause):
902         (WebCore::contextMenuItemTagMediaMute):
903         * platform/LocalizedStrings.h:
904         * platform/android/LocalizedStringsAndroid.cpp:
905         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
906         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
907         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
908         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
909         (WebCore::contextMenuItemTagToggleMediaControls):
910         (WebCore::contextMenuItemTagToggleMediaLoop):
911         (WebCore::contextMenuItemTagEnterVideoFullscreen):
912         (WebCore::contextMenuItemTagMediaPlay):
913         (WebCore::contextMenuItemTagMediaPause):
914         (WebCore::contextMenuItemTagMediaMute):
915         * platform/brew/LocalizedStringsBrew.cpp:
916         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
917         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
918         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
919         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
920         (WebCore::contextMenuItemTagToggleMediaControls):
921         (WebCore::contextMenuItemTagToggleMediaLoop):
922         (WebCore::contextMenuItemTagEnterVideoFullscreen):
923         (WebCore::contextMenuItemTagMediaPlay):
924         (WebCore::contextMenuItemTagMediaPause):
925         (WebCore::contextMenuItemTagMediaMute):
926         * platform/efl/LocalizedStringsEfl.cpp:
927         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
928         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
929         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
930         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
931         (WebCore::contextMenuItemTagToggleMediaControls):
932         (WebCore::contextMenuItemTagToggleMediaLoop):
933         (WebCore::contextMenuItemTagEnterVideoFullscreen):
934         (WebCore::contextMenuItemTagMediaPlay):
935         (WebCore::contextMenuItemTagMediaPause):
936         (WebCore::contextMenuItemTagMediaMute):
937         * platform/gtk/ContextMenuItemGtk.cpp:
938         (WebCore::gtkStockIDFromContextMenuAction):
939         * platform/gtk/LocalizedStringsGtk.cpp:
940         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
941         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
942         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
943         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
944         (WebCore::contextMenuItemTagToggleMediaControls):
945         (WebCore::contextMenuItemTagToggleMediaLoop):
946         (WebCore::contextMenuItemTagEnterVideoFullscreen):
947         (WebCore::contextMenuItemTagMediaPlay):
948         (WebCore::contextMenuItemTagMediaPause):
949         (WebCore::contextMenuItemTagMediaMute):
950         * platform/haiku/LocalizedStringsHaiku.cpp:
951         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
952         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
953         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
954         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
955         (WebCore::contextMenuItemTagToggleMediaControls):
956         (WebCore::contextMenuItemTagToggleMediaLoop):
957         (WebCore::contextMenuItemTagEnterVideoFullscreen):
958         (WebCore::contextMenuItemTagMediaPlay):
959         (WebCore::contextMenuItemTagMediaPause):
960         (WebCore::contextMenuItemTagMediaMute):
961         * platform/wx/LocalizedStringsWx.cpp:
962         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
963         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
964         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
965         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
966         (WebCore::contextMenuItemTagToggleMediaControls):
967         (WebCore::contextMenuItemTagToggleMediaLoop):
968         (WebCore::contextMenuItemTagEnterVideoFullscreen):
969         (WebCore::contextMenuItemTagMediaPlay):
970         (WebCore::contextMenuItemTagMediaPause):
971         (WebCore::contextMenuItemTagMediaMute):
972         * rendering/HitTestResult.cpp:
973         (WebCore::HitTestResult::absoluteMediaURL):
974         (WebCore::HitTestResult::mediaSupportsFullscreen):
975         (WebCore::HitTestResult::mediaElement):
976         (WebCore::HitTestResult::toggleMediaControlsDisplay):
977         (WebCore::HitTestResult::toggleMediaLoopPlayback):
978         (WebCore::HitTestResult::enterFullscreenForVideo):
979         (WebCore::HitTestResult::mediaControlsEnabled):
980         (WebCore::HitTestResult::mediaLoopEnabled):
981         (WebCore::HitTestResult::mediaPlaying):
982         (WebCore::HitTestResult::toggleMediaPlayState):
983         (WebCore::HitTestResult::mediaHasAudio):
984         (WebCore::HitTestResult::mediaMuted):
985         (WebCore::HitTestResult::toggleMediaMuteState):
986         * rendering/HitTestResult.h:
987
988 2010-09-20  Kwang Yul Seo  <skyul@company100.net>
989
990         Reviewed by Daniel Bates.
991
992         [BREWMP] Handle tab key
993         https://bugs.webkit.org/show_bug.cgi?id=46104
994
995         In Brew MP, AVK_FUNCTION is the key code for tab.
996         Process AVK_FUNCTION as tab in PlatformKeyboardEvent.
997
998         * platform/brew/PlatformKeyboardEventBrew.cpp:
999         (WebCore::keyIdentifierForBrewKeyCode):
1000         (WebCore::windowsKeyCodeForKeyEvent):
1001
1002 2010-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1003
1004         Unreviewed, rolling out r67918.
1005         http://trac.webkit.org/changeset/67918
1006         https://bugs.webkit.org/show_bug.cgi?id=46162
1007
1008         Broke chromium win compile (Requested by jamesr on #webkit).
1009
1010         * WebCore.gyp/WebCore.gyp:
1011         * WebCore.gypi:
1012         * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Renamed from WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp.
1013         (WebCore::GlyphPage::fill):
1014
1015 2010-09-20  Daniel Bates  <dbates@rim.com>
1016
1017         Reviewed by Dan Bernstein.
1018
1019         Cleanup: Extract common border radii expansion code in
1020         RenderBoxModelObject::paintBoxShadow() into function
1021         https://bugs.webkit.org/show_bug.cgi?id=45934
1022
1023         Extracted code for expanding and clamping the border radii
1024         into common function to remove duplicate code.
1025
1026         No functionality was changed. So, no new tests.
1027
1028         * rendering/RenderBoxModelObject.cpp:
1029         (WebCore::uniformlyExpandBorderRadii): Added.
1030         (WebCore::RenderBoxModelObject::paintBoxShadow): Moved common code to uniformlyExpandBorderRadii().
1031
1032 2010-09-20  Kwang Yul Seo  <skyul@company100.net>
1033
1034         Reviewed by James Robinson.
1035
1036         Make sure skia is not Chromium specific
1037         https://bugs.webkit.org/show_bug.cgi?id=39672
1038
1039         GGlyphPageTreeNodeLinux does not depend on Linux or Chromium.
1040         Move GGlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
1041         GlyphPageTreeNodeSkia.cpp so that other ports can use it.
1042
1043         * WebCore.gyp/WebCore.gyp:
1044         * WebCore.gypi:
1045         * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
1046         * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
1047
1048 2010-09-20  Kinuko Yasuda  <kinuko@chromium.org>
1049
1050         Reviewed by David Levin.
1051
1052         Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
1053         https://bugs.webkit.org/show_bug.cgi?id=46021
1054
1055         Added NoStaticTables attributes to IDLs except for ones for Callbacks.
1056         (As NoStaticTables only affects non-callback interfaces.)
1057
1058         * fileapi/DOMFileSystem.idl:
1059         * fileapi/DirectoryEntry.idl:
1060         * fileapi/DirectoryReader.idl:
1061         * fileapi/Entry.idl:
1062         * fileapi/EntryArray.idl:
1063         * fileapi/FileEntry.idl:
1064         * fileapi/Flags.idl:
1065         * fileapi/Metadata.idl:
1066
1067 2010-09-20  Nico Weber  <thakis@chromium.org>
1068
1069         Reviewed by Adam Barth.
1070
1071         Fix "operands of ? are integers of different signs" clang warnings
1072         https://bugs.webkit.org/show_bug.cgi?id=46157
1073
1074         * platform/graphics/mac/ComplexTextController.cpp:
1075         (WebCore::ComplexTextController::advance):
1076         * rendering/RenderBox.cpp:
1077         (WebCore::RenderBox::calcHeight):
1078
1079 2010-09-20  Vangelis Kokkevis  <vangelis@chromium.org>
1080
1081         Unreviewed, rolling out r67906.
1082         http://trac.webkit.org/changeset/67906
1083         https://bugs.webkit.org/show_bug.cgi?id=46139
1084
1085         Change causes chromium to crash when switching pages
1086
1087         * platform/graphics/chromium/ContentLayerChromium.h:
1088         * platform/graphics/chromium/LayerChromium.h:
1089
1090 2010-09-19  Antonio Gomes  <agomes@rim.com>
1091
1092         Reviewed by Ojan Vafai.
1093
1094         SelectionController::modify should ask EditingBehavior for platform specific behavior
1095         https://bugs.webkit.org/show_bug.cgi?id=41975
1096
1097         As a follow up of the refactoring work in bug 39854, patch makes SelectionController::modify()
1098         stop accessing EditingBehaviorType values directly, and replaces its use by the EditingBehavior
1099         class.
1100
1101         Since the "Settings*" parameter of the private SelectionController::modify() method becomes unneeded
1102         with this change (it was used to query the editingBehaviorType), patch merges two modify() methods.
1103
1104         No behavior change, so no new tests.
1105
1106         * editing/EditingBehavior.h:
1107         (WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
1108         * editing/SelectionController.cpp:
1109         (WebCore::SelectionController::modify):
1110         * editing/SelectionController.h:
1111
1112 2010-09-20  Vangelis Kokkevis  <vangelis@chromium.org>
1113
1114         Reviewed by James Robinson.
1115
1116         [chromium] Making destructors of LayerChromium and ContentLayerChromium virtual
1117         so that the derived class' destructor code gets called.
1118         https://bugs.webkit.org/show_bug.cgi?id=46139
1119
1120         * platform/graphics/chromium/ContentLayerChromium.h:
1121         * platform/graphics/chromium/LayerChromium.h:
1122
1123 2010-09-20  Darin Adler  <darin@apple.com>
1124
1125         Reviewed by James Robinson.
1126
1127         Deprecate the inputType function on HTMLInputElement
1128         https://bugs.webkit.org/show_bug.cgi?id=46023
1129
1130         * html/HTMLInputElement.cpp:
1131         (WebCore::HTMLInputElement::HTMLInputElement): Use m_deprecatedTypeNumber.
1132         (WebCore::HTMLInputElement::isValidValue): Use deprecatedInputType.
1133         (WebCore::HTMLInputElement::typeMismatch): Ditto.
1134         (WebCore::HTMLInputElement::valueMissing): Ditto.
1135         (WebCore::HTMLInputElement::rangeUnderflow): Ditto.
1136         (WebCore::HTMLInputElement::rangeOverflow): Ditto.
1137         (WebCore::HTMLInputElement::minimum): Ditto.
1138         (WebCore::HTMLInputElement::maximum): Ditto.
1139         (WebCore::HTMLInputElement::stepBase): Ditto.
1140         (WebCore::HTMLInputElement::stepMismatch): Ditto.
1141         (WebCore::HTMLInputElement::getStepParameters): Ditto.
1142         (WebCore::HTMLInputElement::getAllowedValueStep): Ditto.
1143         (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
1144         (WebCore::HTMLInputElement::shouldUseInputMethod): Ditto.
1145         (WebCore::HTMLInputElement::handleBlurEvent): Ditto.
1146         (WebCore::HTMLInputElement::setType): Added a comment.
1147         (WebCore::HTMLInputElement::updateType): Replaced the setInputType function
1148         with this. The type is always the type attribute value, so there is no value
1149         in passing the type string in, and this is an internal implementation detail,
1150         not a public function.
1151         (WebCore::createFormControlTypes): Use deprecatedNumberOfTypes.
1152         (WebCore::HTMLInputElement::formControlType): Use deprecatedInputType.
1153         (WebCore::HTMLInputElement::saveFormControlState): Ditto.
1154         (WebCore::HTMLInputElement::restoreFormControlState): Ditto.
1155         (WebCore::HTMLInputElement::accessKeyAction): Ditto.
1156         (WebCore::HTMLInputElement::mapToEntry): Ditto.
1157         (WebCore::HTMLInputElement::parseMappedAttribute): Ditto.
1158         (WebCore::HTMLInputElement::rendererIsNeeded): Ditto.
1159         (WebCore::HTMLInputElement::createRenderer): Ditto.
1160         (WebCore::HTMLInputElement::attach): Ditto.
1161         (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Ditto.
1162         (WebCore::HTMLInputElement::appendFormData): Ditto.
1163         (WebCore::HTMLInputElement::isTextField): Ditto.
1164         (WebCore::HTMLInputElement::isTextType): Ditto.
1165         (WebCore::HTMLInputElement::setChecked): Ditto.
1166         (WebCore::HTMLInputElement::value): Ditto.
1167         (WebCore::HTMLInputElement::valueWithDefault): Ditto.
1168         (WebCore::HTMLInputElement::setSuggestedValue): Ditto.
1169         (WebCore::HTMLInputElement::setValue): Ditto.
1170         (WebCore::HTMLInputElement::parseToDouble): Ditto.
1171         (WebCore::HTMLInputElement::valueAsDate): Ditto.
1172         (WebCore::HTMLInputElement::setValueAsDate): Ditto.
1173         (WebCore::HTMLInputElement::valueAsNumber): Ditto.
1174         (WebCore::HTMLInputElement::setValueAsNumber): Ditto.
1175         (WebCore::HTMLInputElement::serializeForDateTimeTypes): Ditto.
1176         (WebCore::HTMLInputElement::serialize): Ditto.
1177         (WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
1178         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Ditto.
1179         (WebCore::HTMLInputElement::preDispatchEventHandler): Ditto.
1180         (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
1181         (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
1182         (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Ditto.
1183         (WebCore::HTMLInputElement::files): Ditto.
1184         (WebCore::HTMLInputElement::isAcceptableValue): Ditto.
1185         (WebCore::HTMLInputElement::sanitizeValue): Ditto.
1186         (WebCore::HTMLInputElement::hasUnacceptableValue): Ditto.
1187         (WebCore::HTMLInputElement::needsActivationCallback): Ditto.
1188         (WebCore::HTMLInputElement::isRequiredFormControl): Ditto.
1189         (WebCore::HTMLInputElement::recalcWillValidate): Ditto.
1190         (WebCore::HTMLInputElement::parseToDateComponents): Ditto.
1191         (WebCore::HTMLInputElement::dataList): Ditto.
1192         (WebCore::HTMLInputElement::isSpeechEnabled): Ditto.
1193
1194         * html/HTMLInputElement.h: Renamed InputType to DeprecatedInputType since it
1195         should not be used outside this class. Renamed numberOfTypes to
1196         dprecatedNumberOfTypes for the same reason. Changed all code to use
1197         deprecatedInputType function instead of m_type. Renamed inputType function
1198         to deprecatedInputType. Replaced public setInputType function with private
1199         updateType function. Renamed m_type data member to m_deprecatedTypeNumber.
1200
1201         * rendering/MediaControlElements.cpp:
1202         (WebCore::MediaControlInputElement::MediaControlInputElement):
1203         * rendering/RenderFileUploadControl.cpp:
1204         (WebCore::RenderFileUploadControl::updateFromElement):
1205         Use setType instead of setInputType.
1206
1207 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1208
1209         Unreviewed; an attempt to fix Windows build.
1210
1211         * WebCore.vcproj/WebCore.vcproj:
1212
1213 2010-09-20  Simon Fraser  <simon.fraser@apple.com>
1214
1215         Reviewed by Dan Bernstein.
1216
1217         When PDF image is directly composited, it does not display
1218         https://bugs.webkit.org/show_bug.cgi?id=46144
1219         
1220         In the "direct image compositing" code path, we set the image directly
1221         as the contents of the GraphicsLayer. However, this only works with
1222         bitmap images, so we have to check that the image is a bitmap image.
1223
1224         Test: compositing/images/direct-pdf-image.html
1225
1226         * rendering/RenderLayerBacking.cpp:
1227         (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
1228
1229 2010-09-20  Simon Fraser  <simon.fraser@apple.com>
1230
1231         Reviewed by Darin Adler.
1232
1233         Crash when div with content set to image gets composited (Vimeo).
1234         https://bugs.webkit.org/show_bug.cgi?id=46140
1235         
1236         When CSS specifies that the content of an element is an image, we make
1237         a RenderImage, and setStyle() before setting the image resource. In this
1238         case the compositing code can attempt to access the cached image, which
1239         would crash with a null deref.
1240         
1241         Fix by null-checking m_imageResource.
1242
1243         Test: compositing/images/content-image.html
1244
1245         * rendering/RenderImage.h:
1246         (WebCore::RenderImage::cachedImage):
1247
1248 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1249
1250         Reviewed by Dimitri Glazkov.
1251
1252         Hashchange event is no longer a simple event, needs to be its own interface
1253         https://bugs.webkit.org/show_bug.cgi?id=36335
1254         
1255         Add HashChangeEvent.idl and supporting files/changes.
1256
1257         Test: fast/loader/hashchange-event-properties.html
1258
1259         The original version of this patch was written by
1260         Steven Lai <s3lance@hotmail.com>.
1261
1262         * CMakeLists.txt:
1263         * DerivedSources.cpp:
1264         * DerivedSources.make:
1265         * GNUmakefile.am:
1266         * WebCore.gypi:
1267         * WebCore.pri:
1268         * WebCore.vcproj/WebCore.vcproj:
1269         * WebCore.xcodeproj/project.pbxproj:
1270         * bindings/js/JSEventCustom.cpp:
1271         (WebCore::toJS):
1272         * bindings/v8/custom/V8EventCustom.cpp:
1273         (WebCore::toV8):
1274         * dom/Document.cpp:
1275         (WebCore::Document::enqueueHashchangeEvent):
1276         * dom/Event.cpp:
1277         (WebCore::Event::isHashChangeEvent):
1278         * dom/Event.h:
1279         * dom/HashChangeEvent.h: Added.
1280         (WebCore::HashChangeEvent::isHashChangeEvent):
1281         (WebCore::HashChangeEvent::create):
1282         (WebCore::HashChangeEvent::initHashChangeEvent):
1283         (WebCore::HashChangeEvent::oldURL):
1284         (WebCore::HashChangeEvent::newURL):
1285         (WebCore::HashChangeEvent::HashChangeEvent):
1286         * dom/HashChangeEvent.idl: Added.
1287         * page/DOMWindow.idl:
1288
1289 2010-09-20  Andy Estes  <aestes@apple.com>
1290
1291         Reviewed by Adam Barth.
1292
1293         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1294         https://bugs.webkit.org/show_bug.cgi?id=40961
1295
1296         Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
1297         legacy behavior when the start of a new token is encountered before the
1298         current token is finished parsing. The legacy behavior is to emit the
1299         current token as if it were properly closed and being parsing the new
1300         token.
1301
1302         Test: fast/parser/pre-html5-parser-quirks.html
1303
1304         * html/parser/HTMLDocumentParser.cpp:
1305         (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate
1306         m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
1307         (WebCore::usePreHTMLParserQuirks): Add a helper function to return the
1308         value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
1309         * html/parser/HTMLPreloadScanner.cpp:
1310         (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate
1311         m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
1312         * html/parser/HTMLTokenizer.cpp:
1313         (WebCore::HTMLTokenizer::HTMLTokenizer):
1314         (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an
1315         unexpected '<' is encountered in certain states, emit the current token
1316         and reprocess the '<' as the start of a new token.
1317         * html/parser/HTMLTokenizer.h:
1318         (WebCore::HTMLTokenizer::create):
1319         * html/parser/HTMLViewSourceParser.cpp:
1320         (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate
1321         m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
1322         * page/Settings.cpp:
1323         (WebCore::Settings::Settings):
1324         * page/Settings.h:
1325         (WebCore::Settings::setUsePreHTML5ParserQuirks):
1326         (WebCore::Settings::usePreHTML5ParserQuirks):
1327
1328 2010-09-20  David Hyatt  <hyatt@apple.com>
1329
1330         Reviewed by Dan Bernstein.
1331
1332         https://bugs.webkit.org/show_bug.cgi?id=46132, add an isVerticalBlockFlow() method to RenderStyle and
1333         patch callers so that they don't have to check both top-to-bottom and bottom-to-top block flow.
1334
1335         * rendering/RenderBox.cpp:
1336         (WebCore::RenderBox::availableLogicalWidth):
1337         * rendering/style/RenderStyle.cpp:
1338         (WebCore::RenderStyle::logicalWidth):
1339         (WebCore::RenderStyle::logicalHeight):
1340         (WebCore::RenderStyle::logicalMinWidth):
1341         (WebCore::RenderStyle::logicalMaxWidth):
1342         (WebCore::RenderStyle::logicalMinHeight):
1343         (WebCore::RenderStyle::logicalMaxHeight):
1344         (WebCore::RenderStyle::borderStartWidth):
1345         (WebCore::RenderStyle::borderEndWidth):
1346         (WebCore::RenderStyle::marginStart):
1347         (WebCore::RenderStyle::marginEnd):
1348         (WebCore::RenderStyle::paddingStart):
1349         (WebCore::RenderStyle::paddingEnd):
1350         * rendering/style/RenderStyle.h:
1351         (WebCore::InheritedFlags::isVerticalBlockFlow):
1352
1353 2010-09-20  David Hyatt  <hyatt@apple.com>
1354
1355         Reviewed by Dan Bernstein.
1356
1357         https://bugs.webkit.org/show_bug.cgi?id=46124, add support for logical padding accessors to
1358         RenderBoxModelObject.
1359
1360         Added fast/blockflow/percentage-padding.html even though it fails, so that when more of layout is patched
1361         we can see it start passing.
1362
1363         * rendering/RenderBoxModelObject.cpp:
1364         (WebCore::RenderBoxModelObject::paddingTop):
1365         (WebCore::RenderBoxModelObject::paddingBottom):
1366         (WebCore::RenderBoxModelObject::paddingLeft):
1367         (WebCore::RenderBoxModelObject::paddingRight):
1368         (WebCore::RenderBoxModelObject::paddingBefore):
1369         (WebCore::RenderBoxModelObject::paddingAfter):
1370         (WebCore::RenderBoxModelObject::paddingStart):
1371         (WebCore::RenderBoxModelObject::paddingEnd):
1372         * rendering/RenderBoxModelObject.h:
1373
1374 2010-09-20  David Hyatt  <hyatt@apple.com>
1375
1376         Reviewed by Dan Bernstein.
1377
1378         https://bugs.webkit.org/show_bug.cgi?id=46126, add availableLogicalWidth() to RenderBox.
1379         
1380         * rendering/RenderBlock.cpp:
1381         (WebCore::RenderBlock::availableWidth):
1382         (WebCore::RenderBlock::availableLogicalWidth):
1383         * rendering/RenderBlock.h:
1384         * rendering/RenderBox.cpp:
1385         (WebCore::RenderBox::availableLogicalWidth):
1386         * rendering/RenderBox.h:
1387         (WebCore::RenderBox::availableWidth):
1388
1389 2010-09-20  Kenneth Russell  <kbr@google.com>
1390
1391         Reviewed by James Robinson.
1392
1393         [chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
1394         https://bugs.webkit.org/show_bug.cgi?id=45912
1395
1396         Switched Chromium's compositor to use GraphicsContext3D to issue
1397         its OpenGL rendering calls rather than the Chromium-specific
1398         GLES2Context and command buffer OpenGL implementation.
1399
1400         The in-process software rendering path for GraphicsContext3D does
1401         not yet work with the compositor, at least not on Mac OS X. This
1402         will be worked on in subsequent bugs.
1403
1404         Tested manually with 3D CSS, WebGL and video content on Mac OS X
1405         and Linux. No new tests.
1406
1407         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
1408         (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
1409         (WebCore::Canvas2DLayerChromium::updateContents):
1410         * platform/graphics/chromium/CanvasLayerChromium.cpp:
1411         (WebCore::CanvasLayerChromium::SharedValues::SharedValues):
1412         (WebCore::CanvasLayerChromium::SharedValues::~SharedValues):
1413         (WebCore::CanvasLayerChromium::draw):
1414         * platform/graphics/chromium/CanvasLayerChromium.h:
1415         * platform/graphics/chromium/ContentLayerChromium.cpp:
1416         (WebCore::ContentLayerChromium::SharedValues::SharedValues):
1417         (WebCore::ContentLayerChromium::SharedValues::~SharedValues):
1418         (WebCore::ContentLayerChromium::~ContentLayerChromium):
1419         (WebCore::ContentLayerChromium::updateTextureRect):
1420         (WebCore::ContentLayerChromium::draw):
1421         * platform/graphics/chromium/ContentLayerChromium.h:
1422         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1423         (WebCore::DrawingBuffer::publishToPlatformLayer):
1424         * platform/graphics/chromium/LayerChromium.cpp:
1425         (WebCore::loadShader):
1426         (WebCore::LayerChromium::SharedValues::SharedValues):
1427         (WebCore::LayerChromium::SharedValues::~SharedValues):
1428         (WebCore::LayerChromium::createShaderProgram):
1429         (WebCore::LayerChromium::layerRendererContext):
1430         (WebCore::LayerChromium::drawTexturedQuad):
1431         (WebCore::LayerChromium::drawDebugBorder):
1432         (WebCore::LayerChromium::drawAsMask):
1433         (WebCore::LayerChromium::prepareForDraw):
1434         * platform/graphics/chromium/LayerChromium.h:
1435         (WebCore::LayerChromium::SharedValues::context):
1436         * platform/graphics/chromium/LayerRendererChromium.cpp:
1437         (WebCore::LayerRendererChromium::create):
1438         (WebCore::LayerRendererChromium::LayerRendererChromium):
1439         (WebCore::LayerRendererChromium::context):
1440         (WebCore::LayerRendererChromium::debugGLCall):
1441         (WebCore::LayerRendererChromium::useShader):
1442         (WebCore::LayerRendererChromium::prepareToDrawLayers):
1443         (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
1444         (WebCore::LayerRendererChromium::drawLayers):
1445         (WebCore::LayerRendererChromium::finish):
1446         (WebCore::LayerRendererChromium::present):
1447         (WebCore::LayerRendererChromium::getFramebufferPixels):
1448         (WebCore::LayerRendererChromium::createLayerTexture):
1449         (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer):
1450         (WebCore::LayerRendererChromium::drawLayersRecursive):
1451         (WebCore::LayerRendererChromium::drawLayer):
1452         (WebCore::LayerRendererChromium::scissorToRect):
1453         (WebCore::LayerRendererChromium::makeContextCurrent):
1454         (WebCore::LayerRendererChromium::resizeOnscreenContent):
1455         (WebCore::LayerRendererChromium::initializeSharedObjects):
1456         (WebCore::LayerRendererChromium::cleanupSharedObjects):
1457         * platform/graphics/chromium/LayerRendererChromium.h:
1458         * platform/graphics/chromium/VideoLayerChromium.cpp:
1459         (WebCore::VideoLayerChromium::createTextureRect):
1460         (WebCore::VideoLayerChromium::updateTextureRect):
1461         * platform/graphics/chromium/WebGLLayerChromium.cpp:
1462         (WebCore::WebGLLayerChromium::updateContents):
1463         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
1464         (WebCore::SharedGraphicsContext3D::flush):
1465         (WebCore::SharedGraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM):
1466         (WebCore::SharedGraphicsContext3D::copyTextureToParentTextureCHROMIUM):
1467         * platform/graphics/gpu/SharedGraphicsContext3D.h:
1468
1469 2010-09-20  David Hyatt  <hyatt@apple.com>
1470
1471         Reviewed by Dan Bernstein.
1472
1473         https://bugs.webkit.org/show_bug.cgi?id=46119, add logical accessors to RenderStyle.  Not used by any RenderObjects yet, so no tests
1474         until then.
1475
1476         * rendering/style/RenderStyle.cpp:
1477         (WebCore::RenderStyle::logicalWidth):
1478         (WebCore::RenderStyle::logicalHeight):
1479         (WebCore::RenderStyle::logicalMinWidth):
1480         (WebCore::RenderStyle::logicalMaxWidth):
1481         (WebCore::RenderStyle::logicalMinHeight):
1482         (WebCore::RenderStyle::logicalMaxHeight):
1483         (WebCore::RenderStyle::borderBeforeWidth):
1484         (WebCore::RenderStyle::borderAfterWidth):
1485         (WebCore::RenderStyle::borderStartWidth):
1486         (WebCore::RenderStyle::borderEndWidth):
1487         (WebCore::RenderStyle::marginBefore):
1488         (WebCore::RenderStyle::marginAfter):
1489         (WebCore::RenderStyle::marginStart):
1490         (WebCore::RenderStyle::marginEnd):
1491         (WebCore::RenderStyle::paddingBefore):
1492         (WebCore::RenderStyle::paddingAfter):
1493         (WebCore::RenderStyle::paddingStart):
1494         (WebCore::RenderStyle::paddingEnd):
1495         * rendering/style/RenderStyle.h:
1496
1497 2010-09-20  David Hyatt  <hyatt@apple.com>
1498
1499         Reviewed by Dan Bernstein.
1500
1501         https://bugs.webkit.org/show_bug.cgi?id=46116, implement block-flow-aware logical properties.
1502         
1503         This patch adds all the logical properties from the CSS3 Writing Mode draft for margins, padding, border,
1504         width and height.
1505
1506         Added fast/css/logical-property-resolution.html
1507
1508         * css/CSSComputedStyleDeclaration.cpp:
1509         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1510         * css/CSSParser.cpp:
1511         (WebCore::CSSParser::parseValue):
1512         * css/CSSProperty.cpp:
1513         (WebCore::resolveToPhysicalProperty):
1514         (WebCore::CSSProperty::resolveDirectionAwareProperty):
1515         * css/CSSProperty.h:
1516         * css/CSSPropertyNames.in:
1517         * css/CSSStyleSelector.cpp:
1518         (WebCore::CSSStyleSelector::applyDeclarations):
1519         (WebCore::CSSStyleSelector::applyProperty):
1520
1521 2010-09-20  David Hyatt  <hyatt@apple.com>
1522
1523         Reviewed by Beth Dakin.
1524
1525         https://bugs.webkit.org/show_bug.cgi?id=46114, two tables repaint tests failing on bots.
1526
1527         Patch layoutRows to apply the layout delta when setting a new cell location prior to laying out the cell.
1528         
1529         The layout delta is then removed after layout has happened when the repaint check is done.  This change
1530         makes cell layout match block child layout, and now the cells have the correct new location up front
1531         when laying out (a necessity for pagination).
1532
1533         * rendering/RenderTableSection.cpp:
1534         (WebCore::RenderTableSection::layoutRows):
1535
1536 2010-09-20  Jacob Dinu  <dinu.jacob@nokia.com>
1537
1538         Reviewed by Adam Barth.
1539
1540         When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
1541         that all initialzations are done before calling client dispatchDidCommitLoad to avoid
1542         client from accessing incorrect data.
1543         https://bugs.webkit.org/show_bug.cgi?id=41155
1544
1545         * loader/FrameLoader.cpp:
1546         (WebCore::FrameLoader::commitProvisionalLoad):
1547         (WebCore::FrameLoader::transitionToCommitted):
1548
1549 2010-09-20  Simon Fraser  <simon.fraser@apple.com>
1550
1551         Reviewed by Adam Roben.
1552
1553         REGRESSION: alternating animation direction doesn't work on Windows
1554         https://bugs.webkit.org/show_bug.cgi?id=46017
1555         
1556         Animation-direction on Windows was broken because bitfields on
1557         Windows are signed.
1558         
1559         Fixed by making m_direction an unsigned in the bitfield, and
1560         casting in the accessor.
1561
1562         Test: animations/animation-direction.html
1563
1564         * platform/animation/Animation.h:
1565         (WebCore::Animation::direction):
1566
1567 2010-09-20  Enrica Casucci  <enrica@apple.com>
1568
1569         Reviewed by Sam Weinig.
1570
1571         Pasteboard doesn't work in WebKit2.
1572         https://bugs.webkit.org/show_bug.cgi?id=42317
1573         <rdar://problem/7660537>
1574
1575         * loader/EmptyClients.h:
1576         (WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
1577         be a Vector of RefPtr.
1578         * page/EditorClient.h:
1579         * platform/mac/PasteboardMac.mm:
1580         (WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.
1581
1582 2010-09-20  Yong Li  <yoli@rim.com>
1583
1584         Reviewed by Alexey Proskuryakov.
1585
1586         https://bugs.webkit.org/show_bug.cgi?id=39966
1587         Make compareBorders() a consistent compare function which can beused by qsort().
1588
1589         New test case added: LayoutTests/tables/sort-collapsed-border-styles.html
1590
1591         * rendering/RenderTableCell.cpp:
1592         (WebCore::compareBorders):
1593         (WebCore::chooseBorder):
1594         (WebCore::RenderTableCell::collapsedLeftBorder):
1595         (WebCore::RenderTableCell::collapsedRightBorder):
1596         (WebCore::RenderTableCell::collapsedTopBorder):
1597         (WebCore::RenderTableCell::collapsedBottomBorder):
1598         (WebCore::compareBorderStylesForQSort):
1599
1600 2010-09-20  Patrick Gansterer  <paroga@paroga.com>
1601
1602         Reviewed by Adam Roben.
1603
1604         [WINCE] Buildfix for PluginViewWin.cpp
1605         https://bugs.webkit.org/show_bug.cgi?id=46033
1606
1607         * plugins/win/PluginViewWin.cpp:
1608         (WebCore::PluginView::paintIntoTransformedContext):
1609         (WebCore::PluginView::snapshot):
1610
1611 2010-09-18  David Hyatt  <hyatt@apple.com>
1612
1613         Reviewed by Sam Weinig.
1614
1615         https://bugs.webkit.org/show_bug.cgi?id=46030, aintitcool.com doesn't paginate correctly when printed.
1616         
1617         This happens because the site always has a document width that will exceed the page width.
1618         We incorrectly apply a double scale instead of clipping after the first scale still doesn't fit.
1619         The fix for the issue is to cap the right layout overflow to the page width and to just clip out
1620         any additional excess.  This is the code in FrameView.cpp.
1621         
1622         This patch also cleans up table cell invalidation to reduce the # of relayouts.  This change is not
1623         a correctness fix.  It's just performance.
1624         
1625         I'm not sure how to write a test for this, since the double scale is an artifact of how WebKit mac calls
1626         back in when really printing.
1627
1628         * page/FrameView.cpp:
1629         (WebCore::FrameView::forceLayoutForPagination):
1630         * rendering/RenderBlock.cpp:
1631         (WebCore::RenderBlock::layoutBlockChild):
1632         (WebCore::RenderBlock::layoutPositionedObjects):
1633         (WebCore::RenderBlock::positionNewFloats):
1634         * rendering/RenderBlock.h:
1635         (WebCore::RenderBlock::markForPaginationRelayout):
1636         * rendering/RenderFlexibleBox.cpp:
1637         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
1638         (WebCore::RenderFlexibleBox::layoutVerticalBox):
1639         * rendering/RenderTableSection.cpp:
1640         (WebCore::RenderTableSection::layoutRows):
1641
1642 2010-09-20  Ilya Tikhonovsky  <loislo@chromium.org>
1643
1644         Reviewed by Pavel Feldman.
1645
1646         Web Inspector: merge Inspector client runtime events into the serialized inspector state object.
1647
1648         Drive-by rename getBackendSettings -> getInspectorState to better reflect the nature of the data.
1649
1650         https://bugs.webkit.org/show_bug.cgi?id=45974
1651
1652         * inspector/Inspector.idl:
1653         * inspector/InspectorClient.h:
1654         (WebCore::InspectorClient::updateInspectorStateCookie):
1655         * inspector/InspectorController.cpp:
1656         (WebCore::InspectorController::saveApplicationSettings):
1657         (WebCore::InspectorController::getInspectorState):
1658         (WebCore::InspectorController::updateInspectorStateCookie):
1659         (WebCore::InspectorController::restoreInspectorStateFromCookie):
1660         (WebCore::InspectorController::getSettings):
1661         (WebCore::InspectorController::setMonitoringXHREnabled):
1662         (WebCore::InspectorController::restoreDebugger):
1663         (WebCore::InspectorController::restoreProfiler):
1664         (WebCore::InspectorController::setResourceTrackingEnabled):
1665         (WebCore::InspectorController::ensureSettingsLoaded):
1666         (WebCore::InspectorController::startTimelineProfiler):
1667         (WebCore::InspectorController::stopTimelineProfiler):
1668         (WebCore::InspectorController::enableProfiler):
1669         (WebCore::InspectorController::disableProfiler):
1670         (WebCore::InspectorController::enableDebuggerFromFrontend):
1671         (WebCore::InspectorController::disableDebugger):
1672         * inspector/InspectorController.h:
1673         * inspector/front-end/ConsoleView.js:
1674         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
1675         * inspector/front-end/ResourcesPanel.js:
1676         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
1677         * inspector/front-end/Settings.js:
1678         (WebInspector.Settings.initialize):
1679         * inspector/front-end/inspector.js:
1680         (WebInspector.doLoadedDone.populateInspectorState):
1681         (WebInspector.doLoadedDone):
1682
1683 2010-09-20  Dirk Schulze  <krit@webkit.org>
1684
1685         Reviewed by Nikolas Zimmermann.
1686
1687         SVG Filter cleanup
1688         https://bugs.webkit.org/show_bug.cgi?id=45612
1689         
1690         All effect inputs are stored in a Vector in FilterEffect instead of passing them via constructors to every effect type.
1691         This simplifies the primitive subregion logic and centralizes it in determineFilterPrimitiveSubregion.
1692         Just SourceGraphic, SourceAlpha and FETile still calculate filter primitive subregions on
1693         their own. Working on it in a followup patch.
1694         The subregions code is SVG specific and moving this calculation to FilterEffect is an
1695         intermediate step before moving it to RenderSVGResourceFilterPrimitive in a following patch.
1696         The new FilterEffectVector will also make it possible to add code to determine the
1697         smallest used region of an effect and will help save memory and resources in the future.
1698         subRegion got renamed to filterPrimitiveSubregion to match the name scheme. scaledSubRegion got
1699         renamed to repaintRectInLocalCoordinates since this is its proper meaning.
1700         Removed unnecessary member variables and functions from FilterEffect.
1701
1702         No new tests added since the functionality didn't change.
1703
1704         * platform/graphics/cairo/GraphicsContextCairo.cpp: scaledSubRegion was renamed to repaintRectInLocalCoordinates.
1705         (WebCore::GraphicsContext::createShadowMask):
1706         * platform/graphics/filters/FEBlend.cpp: Removed Filter effect inputs from constructor.
1707         (WebCore::FEBlend::FEBlend):
1708         (WebCore::FEBlend::create):
1709         (WebCore::FEBlend::apply): Call inputFilterEffects to get input filter primitives.
1710         (WebCore::FEBlend::externalRepresentation): Call inputFilterEffects to get input filter primitives.
1711         * platform/graphics/filters/FEBlend.h:
1712         * platform/graphics/filters/FEColorMatrix.cpp: Ditto.
1713         (WebCore::FEColorMatrix::FEColorMatrix):
1714         (WebCore::FEColorMatrix::create):
1715         (WebCore::FEColorMatrix::apply):
1716         (WebCore::FEColorMatrix::externalRepresentation):
1717         * platform/graphics/filters/FEColorMatrix.h:
1718         * platform/graphics/filters/FEComponentTransfer.cpp: Ditto.
1719         (WebCore::FEComponentTransfer::FEComponentTransfer):
1720         (WebCore::FEComponentTransfer::create):
1721         (WebCore::FEComponentTransfer::apply):
1722         (WebCore::FEComponentTransfer::externalRepresentation):
1723         * platform/graphics/filters/FEComponentTransfer.h:
1724         * platform/graphics/filters/FEComposite.cpp: Ditto.
1725         (WebCore::FEComposite::FEComposite):
1726         (WebCore::FEComposite::create):
1727         (WebCore::FEComposite::apply):
1728         (WebCore::FEComposite::externalRepresentation):
1729         * platform/graphics/filters/FEComposite.h:
1730         * platform/graphics/filters/FEGaussianBlur.cpp: Ditto.
1731         (WebCore::FEGaussianBlur::FEGaussianBlur):
1732         (WebCore::FEGaussianBlur::create):
1733         (WebCore::FEGaussianBlur::apply):
1734         (WebCore::FEGaussianBlur::externalRepresentation):
1735         * platform/graphics/filters/FEGaussianBlur.h:
1736         * platform/graphics/filters/Filter.h:
1737         (WebCore::Filter::determineFilterPrimitiveSubregion): Renamed from calculateEffectSubRegion to match name scheme.
1738         * platform/graphics/filters/FilterEffect.cpp:
1739         (WebCore::FilterEffect::FilterEffect):
1740         (WebCore::FilterEffect::determineFilterPrimitiveSubregion): The main place for subregion calculation.
1741         (WebCore::FilterEffect::calculateDrawingIntRect): Takes repaintRectInLocalCoordinates now.
1742         (WebCore::FilterEffect::calculateDrawingRect): ditto.
1743         (WebCore::FilterEffect::getEffectContext): Check if ImageBuffer was created.
1744         * platform/graphics/filters/FilterEffect.h: Changed names to match name scheme. Removed unnecessary member variables and functions.
1745             Seperate SVG specific member variables and functions. Will get removed in followup patches.
1746         (WebCore::FilterEffect::resultImage):
1747         (WebCore::FilterEffect::setEffectBuffer):
1748         (WebCore::FilterEffect::inputEffect):
1749         (WebCore::FilterEffect::inputEffects):
1750         (WebCore::FilterEffect::numberOfinputEffects):
1751         (WebCore::FilterEffect::isAlphaImage):
1752         (WebCore::FilterEffect::setIsAlphaImage):
1753         (WebCore::FilterEffect::repaintRectInLocalCoordinates):
1754         (WebCore::FilterEffect::setRepaintRectInLocalCoordinates):
1755         (WebCore::FilterEffect::isSourceInput):
1756         (WebCore::FilterEffect::hasX):
1757         (WebCore::FilterEffect::setHasX):
1758         (WebCore::FilterEffect::hasY):
1759         (WebCore::FilterEffect::setHasY):
1760         (WebCore::FilterEffect::hasWidth):
1761         (WebCore::FilterEffect::setHasWidth):
1762         (WebCore::FilterEffect::hasHeight):
1763         (WebCore::FilterEffect::setHasHeight):
1764         (WebCore::FilterEffect::filterPrimitiveSubregion):
1765         (WebCore::FilterEffect::setFilterPrimitiveSubregion):
1766         (WebCore::FilterEffect::effectBoundaries):
1767         (WebCore::FilterEffect::setEffectBoundaries):
1768         * platform/graphics/filters/SourceAlpha.cpp:
1769         (WebCore::SourceAlpha::determineFilterPrimitiveSubregion): Renamed to match name scheme.
1770         * platform/graphics/filters/SourceAlpha.h:
1771         (WebCore::SourceAlpha::isSourceInput):
1772         * platform/graphics/filters/SourceGraphic.cpp:
1773         (WebCore::SourceGraphic::determineFilterPrimitiveSubregion): Ditto.
1774         * platform/graphics/filters/SourceGraphic.h:
1775         (WebCore::SourceGraphic::isSourceInput):
1776         * rendering/RenderSVGResourceFilter.cpp: Adapt to renames in FilterEffect.
1777         (WebCore::RenderSVGResourceFilter::applyResource):
1778         (WebCore::RenderSVGResourceFilter::postApplyResource):
1779         * svg/SVGFEBlendElement.cpp: Constructor of FEBlend doesn't take input effects. Adding them afterwards.
1780         (WebCore::SVGFEBlendElement::build):
1781         * svg/SVGFEColorMatrixElement.cpp: Ditto.
1782         (WebCore::SVGFEColorMatrixElement::build):
1783         * svg/SVGFEComponentTransferElement.cpp: Ditto.
1784         (WebCore::SVGFEComponentTransferElement::build):
1785         * svg/SVGFECompositeElement.cpp: Ditto.
1786         (WebCore::SVGFECompositeElement::build):
1787         * svg/SVGFEConvolveMatrixElement.cpp: Ditto.
1788         (WebCore::SVGFEConvolveMatrixElement::build):
1789         * svg/SVGFEDiffuseLightingElement.cpp: Ditto.
1790         (WebCore::SVGFEDiffuseLightingElement::build):
1791         * svg/SVGFEDisplacementMapElement.cpp: Ditto.
1792         (WebCore::SVGFEDisplacementMapElement::build):
1793         * svg/SVGFEGaussianBlurElement.cpp: Ditto.
1794         (WebCore::SVGFEGaussianBlurElement::build):
1795         * svg/SVGFEMergeElement.cpp: Ditto.
1796         (WebCore::SVGFEMergeElement::build):
1797         * svg/SVGFEMorphologyElement.cpp: Ditto.
1798         (WebCore::SVGFEMorphologyElement::build):
1799         * svg/SVGFEOffsetElement.cpp: Ditto.
1800         (WebCore::SVGFEOffsetElement::build):
1801         * svg/SVGFESpecularLightingElement.cpp: Ditto.
1802         (WebCore::SVGFESpecularLightingElement::build):
1803         * svg/SVGFETileElement.cpp: Ditto.
1804         (WebCore::SVGFETileElement::build):
1805         * svg/graphics/filters/SVGFEConvolveMatrix.cpp: Ditto.
1806         (WebCore::FEConvolveMatrix::FEConvolveMatrix):
1807         (WebCore::FEConvolveMatrix::create):
1808         (WebCore::FEConvolveMatrix::apply):
1809         (WebCore::FEConvolveMatrix::externalRepresentation):
1810         * svg/graphics/filters/SVGFEConvolveMatrix.h:
1811         * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
1812         (WebCore::FEDiffuseLighting::FEDiffuseLighting):
1813         (WebCore::FEDiffuseLighting::create):
1814         (WebCore::FEDiffuseLighting::externalRepresentation):
1815         * svg/graphics/filters/SVGFEDiffuseLighting.h:
1816         * svg/graphics/filters/SVGFEDisplacementMap.cpp: Ditto.
1817         (WebCore::FEDisplacementMap::FEDisplacementMap):
1818         (WebCore::FEDisplacementMap::create):
1819         (WebCore::FEDisplacementMap::apply):
1820         (WebCore::FEDisplacementMap::externalRepresentation):
1821         * svg/graphics/filters/SVGFEDisplacementMap.h:
1822         * svg/graphics/filters/SVGFEFlood.cpp: Ditto.
1823         (WebCore::FEFlood::apply):
1824         * svg/graphics/filters/SVGFEImage.cpp: Ditto.
1825         (WebCore::FEImage::apply):
1826         * svg/graphics/filters/SVGFELighting.cpp: Ditto.
1827         (WebCore::FELighting::FELighting):
1828         (WebCore::FELighting::apply):
1829         * svg/graphics/filters/SVGFELighting.h:
1830         * svg/graphics/filters/SVGFEMerge.cpp: Ditto.
1831         (WebCore::FEMerge::FEMerge):
1832         (WebCore::FEMerge::create):
1833         (WebCore::FEMerge::apply):
1834         (WebCore::FEMerge::externalRepresentation):
1835         * svg/graphics/filters/SVGFEMerge.h:
1836         * svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
1837         (WebCore::FEMorphology::FEMorphology):
1838         (WebCore::FEMorphology::create):
1839         (WebCore::FEMorphology::apply):
1840         (WebCore::FEMorphology::externalRepresentation):
1841         * svg/graphics/filters/SVGFEMorphology.h:
1842         * svg/graphics/filters/SVGFEOffset.cpp: Ditto.
1843         (WebCore::FEOffset::FEOffset):
1844         (WebCore::FEOffset::create):
1845         (WebCore::FEOffset::apply):
1846         (WebCore::FEOffset::externalRepresentation):
1847         * svg/graphics/filters/SVGFEOffset.h:
1848         * svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
1849         (WebCore::FESpecularLighting::FESpecularLighting):
1850         (WebCore::FESpecularLighting::create):
1851         (WebCore::FESpecularLighting::externalRepresentation):
1852         * svg/graphics/filters/SVGFESpecularLighting.h:
1853         * svg/graphics/filters/SVGFETile.cpp: Ditto.
1854         (WebCore::FETile::FETile):
1855         (WebCore::FETile::create):
1856         (WebCore::FETile::determineFilterPrimitiveSubregion): Renamed to match name scheme.
1857         (WebCore::FETile::apply):
1858         (WebCore::FETile::externalRepresentation):
1859         * svg/graphics/filters/SVGFETile.h:
1860         * svg/graphics/filters/SVGFilter.cpp: Renamed itemBox to targetBoundingBox to match name scheme.
1861         (WebCore::SVGFilter::SVGFilter):
1862         (WebCore::SVGFilter::determineFilterPrimitiveSubregion): Renamed to match name scheme.
1863         (WebCore::SVGFilter::create):
1864         * svg/graphics/filters/SVGFilter.h:
1865         (WebCore::SVGFilter::sourceImageRect):
1866
1867 2010-09-20  Pavel Podivilov  <podivilov@chromium.org>
1868
1869         Reviewed by Pavel Feldman.
1870
1871         Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
1872         https://bugs.webkit.org/show_bug.cgi?id=45897
1873
1874         * inspector/front-end/BreakpointsSidebarPane.js:
1875         (WebInspector.BreakpointItem):
1876         (WebInspector.JSBreakpointItem):
1877         (WebInspector.DOMBreakpointItem):
1878         (WebInspector.DOMBreakpointItem.prototype.compareTo):
1879         (WebInspector.DOMBreakpointItem.prototype._breakpointClicked):
1880         * inspector/front-end/ElementsPanel.js:
1881         (WebInspector.ElementsPanel.prototype.hide):
1882         (WebInspector.ElementsPanel.prototype.reset):
1883         (WebInspector.ElementsPanel.prototype.setDocument.selectNode):
1884         (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs):
1885         (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
1886         (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
1887         * inspector/front-end/ElementsTreeOutline.js:
1888         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
1889         (WebInspector.ElementsTreeOutline.prototype._onmousemove):
1890         (WebInspector.ElementsTreeOutline.prototype._onmouseout):
1891         * inspector/front-end/inspector.js:
1892         (WebInspector.highlightDOMNode):
1893         (WebInspector.highlightDOMNodeForTwoSeconds):
1894         (WebInspector.wireElementWithDOMNode):
1895         (WebInspector._updateFocusedNode):
1896         (WebInspector.reset):
1897         (WebInspector.updateFocusedNode):
1898
1899 2010-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1900
1901         Unreviewed, rolling out r67749.
1902         http://trac.webkit.org/changeset/67749
1903         https://bugs.webkit.org/show_bug.cgi?id=46068
1904
1905         breaking ToT chromium canary build (Requested by shans on
1906         #webkit).
1907
1908         * bindings/v8/V8DOMWindowShell.cpp:
1909         (WebCore::V8DOMWindowShell::createNewContext):
1910         * bindings/v8/V8Proxy.cpp:
1911         (WebCore::V8Proxy::registeredExtensionWithV8):
1912         (WebCore::V8Proxy::registerExtension):
1913         * bindings/v8/V8Proxy.h:
1914         * loader/EmptyClients.h:
1915         * loader/FrameLoaderClient.h:
1916
1917 2010-09-19  Gavin Barraclough  <barraclough@apple.com>
1918
1919         Reviewed by Oliver Hunt.
1920
1921         Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.
1922
1923         These methods implement the same conversion (see discussion in the notes
1924         of sections of 9.5 and 9.6 of the spec), only differing in how the result
1925         is interpretted.
1926
1927         Removing JSValue::toInt32 (since this has weird, non-spec function).
1928         A couple of places in the binding are using this method, so adding
1929         finiteInt32Value to the bindings to maintain current behaviour.
1930
1931         Test: fast/js/toInt32UInt32.html
1932
1933         * bindings/js/JSDOMBinding.h:
1934         (WebCore::finiteInt32Value):
1935         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
1936         (WebCore::JSHTMLOptionsCollection::add):
1937         * bindings/js/JSSQLResultSetRowListCustom.cpp:
1938         (WebCore::JSSQLResultSetRowList::item):
1939         * bindings/js/JSSVGPODListCustom.h:
1940         (WebCore::JSSVGPODListCustom::getItem):
1941         (WebCore::JSSVGPODListCustom::insertItemBefore):
1942         (WebCore::JSSVGPODListCustom::replaceItem):
1943         (WebCore::JSSVGPODListCustom::removeItem):
1944         * bindings/js/JSSVGPathSegListCustom.cpp:
1945         (WebCore::JSSVGPathSegList::getItem):
1946         (WebCore::JSSVGPathSegList::insertItemBefore):
1947         (WebCore::JSSVGPathSegList::replaceItem):
1948         (WebCore::JSSVGPathSegList::removeItem):
1949
1950 2010-09-19  Andreas Kling  <andreas.kling@nokia.com>
1951
1952         Reviewed by Kenneth Rohde Christiansen.
1953
1954         [Qt] clipBoundingRect() should return rect relevant to current layer
1955         https://bugs.webkit.org/show_bug.cgi?id=46059
1956
1957         r65791 inadvertently changed clipBoundingRect() to always use the GC painter
1958         without checking the TransparencyLayer stack first.
1959
1960         * platform/graphics/qt/GraphicsContextQt.cpp:
1961         (WebCore::GraphicsContextPlatformPrivate::p):
1962         (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
1963
1964 2010-09-19  Sam Weinig  <sam@webkit.org>
1965
1966         Reviewed by Anders Carlsson.
1967
1968         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
1969         https://bugs.webkit.org/show_bug.cgi?id=46054
1970
1971         * WebCore.exp.in:
1972         * WebCore.xcodeproj/project.pbxproj:
1973
1974 2010-09-19  Patrick Gansterer  <paroga@paroga.com>
1975
1976         Unreviewed.
1977
1978         [WINCE] Buildfix for Gradient after r67801.
1979
1980         * platform/graphics/Gradient.h:
1981         * platform/graphics/wince/GradientWinCE.cpp:
1982         (WebCore::Gradient::getStops):
1983
1984 2010-09-19  Kent Tamura  <tkent@chromium.org>
1985
1986         Reviewed by Dimitri Glazkov.
1987
1988         [Chromium] Add is<input type>() functions to WebInputElement
1989         https://bugs.webkit.org/show_bug.cgi?id=46035
1990
1991         * html/HTMLInputElement.h:
1992         (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
1993
1994 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
1995
1996         Reviewed by Antonio Gomes.
1997
1998         [Qt] Path: Remove unused member variable
1999         https://bugs.webkit.org/show_bug.cgi?id=46048
2000
2001         Path::m_lastMoveToIndex is not used for anything, so remove it.
2002
2003         * platform/graphics/Path.h:
2004         * platform/graphics/qt/PathQt.cpp:
2005         (WebCore::Path::Path):
2006         (WebCore::Path::operator=):
2007         (WebCore::Path::moveTo):
2008
2009 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2010
2011         Reviewed by Darin Adler.
2012
2013         Use AtomicString insted of String in XMLDocumentParser
2014         https://bugs.webkit.org/show_bug.cgi?id=45990
2015
2016         Create AtomicString as early as possible.
2017         This can avoid unnecessary memcpy of String content.
2018
2019         * dom/XMLDocumentParser.h:
2020         * dom/XMLDocumentParserLibxml2.cpp:
2021         (WebCore::toAtomicString):
2022         (WebCore::handleElementNamespaces):
2023         (WebCore::handleElementAttributes):
2024         (WebCore::XMLDocumentParser::startElementNs):
2025
2026 2010-09-18  Erik Arvidsson  <arv@chromium.org>
2027
2028         Reviewed by Nate Chapin.
2029
2030         [Chromium] fast/dom/dataset-gc.html is failing
2031         https://bugs.webkit.org/show_bug.cgi?id=45426
2032
2033         * bindings/scripts/CodeGeneratorV8.pm:
2034         * bindings/v8/custom/V8DOMStringMapCustom.cpp:
2035         (WebCore::toV8):
2036         * dom/DOMStringMap.h:
2037         * dom/DatasetDOMStringMap.h:
2038         (WebCore::DatasetDOMStringMap::element):
2039
2040 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
2041
2042         Reviewed by Oliver Hunt.
2043
2044         Gradient: Fast-path for the ideal case in sortStopsIfNecessary()
2045         https://bugs.webkit.org/show_bug.cgi?id=46045
2046
2047         Avoid calling std::stable_sort for 2-stop gradients that are already in order.
2048
2049         * platform/graphics/Gradient.cpp:
2050         (WebCore::Gradient::sortStopsIfNecessary):
2051
2052 2010-09-18  Kwang Yul Seo  <skyul@company100.net>
2053
2054         Reviewed by Andreas Kling.
2055
2056         [BREWMP] Fix a typo in key code name
2057         https://bugs.webkit.org/show_bug.cgi?id=46003
2058
2059         AVK_CLR is the right Brew MP key code name for VK_BACK.
2060
2061         * platform/brew/PlatformKeyboardEventBrew.cpp:
2062         (WebCore::windowsKeyCodeForKeyEvent):
2063
2064 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
2065
2066         Reviewed by Oliver Hunt.
2067
2068         Gradient: Pre-reserve space for 2 color stops
2069         https://bugs.webkit.org/show_bug.cgi?id=46044
2070
2071         Most gradients have only 2 color stops, pre-reserve space for these in m_stops
2072         to avoid growing the vector dynamically in the common case.
2073
2074         * platform/graphics/Gradient.h:
2075
2076 2010-09-18  Dimitri Glazkov  <dglazkov@chromium.org>
2077
2078         Unreviewed, rolling out r67792.
2079         http://trac.webkit.org/changeset/67792
2080         https://bugs.webkit.org/show_bug.cgi?id=45976
2081
2082         Broke over a hundred SVG tests.
2083
2084         * platform/graphics/GraphicsContext.cpp:
2085         (WebCore::GraphicsContext::drawImage):
2086         (WebCore::GraphicsContext::drawImageBuffer):
2087         * platform/graphics/GraphicsContext.h:
2088
2089 2010-09-18  Mihai Parparita  <mihaip@chromium.org>
2090
2091         Reviewed by Simon Fraser.
2092
2093         webkitAnimationEnd event doesn't fire when skipping over final iteration
2094         https://bugs.webkit.org/show_bug.cgi?id=46010
2095         
2096         It's possible for AnimationBase::fireAnimationEventsIfNeeded to decide
2097         that the animation is ended while we're in the looping state, if the
2098         animation timer never fires during an iteration. That then fails the
2099         assert in AnimationBase::updateStateMachine (we don't expect
2100         AnimationStateInputEndTimerFired while in the looping state). Jump the
2101         state to AnimationStateEnding, which is more accurate.
2102
2103         Test: animations/animation-end-event-short-iterations.html
2104
2105         * page/animation/AnimationBase.cpp:
2106         (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
2107
2108 2010-09-18  Kwang Yul Seo  <skyul@company100.net>
2109
2110         Reviewed by Andreas Kling.
2111
2112         [BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
2113         https://bugs.webkit.org/show_bug.cgi?id=46005
2114
2115         The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.
2116
2117         * platform/brew/PlatformKeyboardEventBrew.cpp:
2118         (WebCore::keyIdentifierForBrewKeyCode):
2119
2120 2010-09-18  Matthew Delaney  <mdelaney@apple.com>
2121
2122         Reviewed by Oliver Hunt.
2123
2124         Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
2125         https://bugs.webkit.org/show_bug.cgi?id=45976
2126
2127         Specifying a -1 width or height for either the source or destination rectangle in drawImage
2128         get improperly drawn with -1 replaced as the corresponding image width or height. This was because
2129         the value -1 was being passed around to signal non-specified widths and heights and thus was
2130         interpreted lower down in the drawImage implementation which disallowed any calls that actually
2131         wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
2132         -1 in-band signaling to denote default behavior.
2133
2134         Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html
2135                canvas/philip/tests/2d.drawImage.negativeOneSource.html
2136
2137         * platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have
2138         the desired replaces for unspecified widths and heights earlier on.
2139         * platform/graphics/GraphicsContext.h: Removed faulty default value.
2140
2141 2010-09-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2142
2143         Reviewed by Kenneth Rohde Christiansen.
2144
2145         Enable Platform Strategies on Qt
2146
2147         [Qt] Turn on PLATFORM_STRATEGIES
2148         https://bugs.webkit.org/show_bug.cgi?id=45831
2149
2150         * WebCore.pro: Adding/removing implementation files
2151         * platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was
2152         moved from platform/qt/Localizations.cpp
2153         (WebCore::defaultLanguage): Moved from Localizations.cpp
2154         * platform/qt/Localizations.cpp: Removed (code is now inside
2155         WebCoreSupport/WebPlatformStrategies.cpp)
2156         * plugins/qt/PluginDataQt.cpp: Removed (idem)
2157
2158 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2159
2160         Reviewed by Darin Adler.
2161
2162         Rename Wince files to WinCE
2163         https://bugs.webkit.org/show_bug.cgi?id=37287
2164
2165         * loader/icon/wince/IconDatabaseWinCE.cpp: Copied from WebCore/loader/icon/wince/IconDatabaseWince.cpp.
2166         * loader/icon/wince/IconDatabaseWince.cpp: Removed.
2167         * page/wince/FrameWinCE.cpp: Copied from WebCore/page/wince/FrameWince.cpp.
2168         * page/wince/FrameWince.cpp: Removed.
2169         * platform/graphics/MediaPlayer.cpp:
2170         * platform/graphics/wince/ColorWinCE.cpp: Copied from WebCore/platform/graphics/wince/ColorWince.cpp.
2171         * platform/graphics/wince/ColorWince.cpp: Removed.
2172         * platform/graphics/wince/FontCacheWinCE.cpp: Copied from WebCore/platform/graphics/wince/FontCacheWince.cpp.
2173         * platform/graphics/wince/FontCacheWince.cpp: Removed.
2174         * platform/graphics/wince/FontWinCE.cpp: Copied from WebCore/platform/graphics/wince/FontWince.cpp.
2175         * platform/graphics/wince/FontWince.cpp: Removed.
2176         * platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp: Copied from WebCore/platform/graphics/wince/GlyphPageTreeNodeWince.cpp.
2177         * platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Removed.
2178         * platform/graphics/wince/GradientWinCE.cpp: Copied from WebCore/platform/graphics/wince/GradientWince.cpp.
2179         * platform/graphics/wince/GradientWince.cpp: Removed.
2180         * platform/graphics/wince/GraphicsContextWinCE.cpp: Copied from WebCore/platform/graphics/wince/GraphicsContextWince.cpp.
2181         * platform/graphics/wince/GraphicsContextWince.cpp: Removed.
2182         * platform/graphics/wince/ImageBufferWinCE.cpp: Copied from WebCore/platform/graphics/wince/ImageBufferWince.cpp.
2183         * platform/graphics/wince/ImageBufferWince.cpp: Removed.
2184         * platform/graphics/wince/MediaPlayerPrivateWinCE.h: Copied from WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h.
2185         * platform/graphics/wince/MediaPlayerPrivateWince.h: Removed.
2186         * platform/graphics/wince/PathWinCE.cpp: Copied from WebCore/platform/graphics/wince/PathWince.cpp.
2187         * platform/graphics/wince/PathWince.cpp: Removed.
2188         * platform/graphics/wince/PlatformPathWinCE.cpp: Copied from WebCore/platform/graphics/wince/PlatformPathWince.cpp.
2189         * platform/graphics/wince/PlatformPathWinCE.h: Copied from WebCore/platform/graphics/wince/PlatformPathWince.h.
2190         * platform/graphics/wince/PlatformPathWince.cpp: Removed.
2191         * platform/graphics/wince/PlatformPathWince.h: Removed.
2192         * platform/graphics/wince/SimpleFontDataWinCE.cpp: Copied from WebCore/platform/graphics/wince/SimpleFontDataWince.cpp.
2193         * platform/graphics/wince/SimpleFontDataWince.cpp: Removed.
2194         * platform/graphics/wince/WinCEGraphicsExtras.h: Copied from WebCore/platform/graphics/wince/WinceGraphicsExtras.h.
2195         * platform/graphics/wince/WinceGraphicsExtras.h: Removed.
2196         * platform/text/wince/TextBoundariesWinCE.cpp: Copied from WebCore/platform/text/wince/TextBoundariesWince.cpp.
2197         * platform/text/wince/TextBoundariesWince.cpp: Removed.
2198         * platform/text/wince/TextBreakIteratorWinCE.cpp: Copied from WebCore/platform/text/wince/TextBreakIteratorWince.cpp.
2199         * platform/text/wince/TextBreakIteratorWince.cpp: Removed.
2200         * platform/wince/CursorWinCE.cpp: Copied from WebCore/platform/wince/CursorWince.cpp.
2201         * platform/wince/CursorWince.cpp: Removed.
2202         * platform/wince/DragDataWinCE.cpp: Copied from WebCore/platform/wince/DragDataWince.cpp.
2203         * platform/wince/DragDataWince.cpp: Removed.
2204         * platform/wince/DragImageWinCE.cpp: Copied from WebCore/platform/wince/DragImageWince.cpp.
2205         * platform/wince/DragImageWince.cpp: Removed.
2206         * platform/wince/EditorWinCE.cpp: Copied from WebCore/platform/wince/EditorWince.cpp.
2207         (WebCore::Editor::newGeneralClipboard):
2208         * platform/wince/EditorWince.cpp: Removed.
2209         * platform/wince/FileChooserWinCE.cpp: Copied from WebCore/platform/wince/FileChooserWince.cpp.
2210         * platform/wince/FileChooserWince.cpp: Removed.
2211         * platform/wince/FileSystemWinCE.cpp: Copied from WebCore/platform/wince/FileSystemWince.cpp.
2212         * platform/wince/FileSystemWince.cpp: Removed.
2213         * platform/wince/KURLWinCE.cpp: Copied from WebCore/platform/wince/KURLWince.cpp.
2214         * platform/wince/KURLWince.cpp: Removed.
2215         * platform/wince/KeygenWinCE.cpp: Copied from WebCore/platform/wince/KeygenWince.cpp.
2216         * platform/wince/KeygenWince.cpp: Removed.
2217         * platform/wince/MIMETypeRegistryWinCE.cpp: Copied from WebCore/platform/wince/MIMETypeRegistryWince.cpp.
2218         * platform/wince/MIMETypeRegistryWince.cpp: Removed.
2219         * platform/wince/PasteboardWinCE.cpp: Copied from WebCore/platform/wince/PasteboardWince.cpp.
2220         * platform/wince/PasteboardWince.cpp: Removed.
2221         * platform/wince/SearchPopupMenuWinCE.cpp: Copied from WebCore/platform/wince/SearchPopupMenuWince.cpp.
2222         * platform/wince/SearchPopupMenuWince.cpp: Removed.
2223         * platform/wince/SharedTimerWinCE.cpp: Copied from WebCore/platform/wince/SharedTimerWince.cpp.
2224         * platform/wince/SharedTimerWince.cpp: Removed.
2225         * rendering/RenderThemeWinCE.cpp: Copied from WebCore/rendering/RenderThemeWince.cpp.
2226         (WebCore::RenderThemeWinCE::create):
2227         (WebCore::RenderTheme::themeForPage):
2228         (WebCore::RenderThemeWinCE::RenderThemeWinCE):
2229         (WebCore::RenderThemeWinCE::~RenderThemeWinCE):
2230         (WebCore::RenderThemeWinCE::platformActiveSelectionBackgroundColor):
2231         (WebCore::RenderThemeWinCE::platformInactiveSelectionBackgroundColor):
2232         (WebCore::RenderThemeWinCE::platformActiveSelectionForegroundColor):
2233         (WebCore::RenderThemeWinCE::platformInactiveSelectionForegroundColor):
2234         (WebCore::RenderThemeWinCE::supportsFocus):
2235         (WebCore::RenderThemeWinCE::supportsFocusRing):
2236         (WebCore::RenderThemeWinCE::determineClassicState):
2237         (WebCore::RenderThemeWinCE::getThemeData):
2238         (WebCore::RenderThemeWinCE::paintButton):
2239         (WebCore::RenderThemeWinCE::setCheckboxSize):
2240         (WebCore::RenderThemeWinCE::paintTextField):
2241         (WebCore::RenderThemeWinCE::adjustMenuListStyle):
2242         (WebCore::RenderThemeWinCE::paintMenuList):
2243         (WebCore::RenderThemeWinCE::paintMenuListButton):
2244         (WebCore::RenderThemeWinCE::systemFont):
2245         (WebCore::RenderThemeWinCE::themeChanged):
2246         (WebCore::RenderThemeWinCE::extraDefaultStyleSheet):
2247         (WebCore::RenderThemeWinCE::extraQuirksStyleSheet):
2248         (WebCore::RenderThemeWinCE::supportsHover):
2249         (WebCore::RenderThemeWinCE::systemColor):
2250         (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
2251         (WebCore::RenderThemeWinCE::adjustButtonInnerStyle):
2252         (WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
2253         (WebCore::RenderThemeWinCE::paintSearchField):
2254         (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
2255         (WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
2256         (WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
2257         (WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
2258         (WebCore::RenderThemeWinCE::paintSearchFieldResultsDecoration):
2259         (WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
2260         (WebCore::RenderThemeWinCE::paintSearchFieldResultsButton):
2261         (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
2262         (WebCore::RenderThemeWinCE::paintSliderTrack):
2263         (WebCore::RenderThemeWinCE::paintSliderThumb):
2264         (WebCore::RenderThemeWinCE::paintMediaFullscreenButton):
2265         (WebCore::RenderThemeWinCE::paintMediaMuteButton):
2266         (WebCore::RenderThemeWinCE::paintMediaPlayButton):
2267         (WebCore::RenderThemeWinCE::paintMediaSeekBackButton):
2268         (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):
2269         (WebCore::RenderThemeWinCE::paintMediaSliderTrack):
2270         (WebCore::RenderThemeWinCE::paintMediaSliderThumb):
2271         * rendering/RenderThemeWinCE.h: Copied from WebCore/rendering/RenderThemeWince.h.
2272         * rendering/RenderThemeWince.cpp: Removed.
2273         * rendering/RenderThemeWince.h: Removed.
2274         * storage/wince/DatabaseThreadWinCE.cpp: Copied from WebCore/storage/wince/DatabaseThreadWince.cpp.
2275         * storage/wince/DatabaseThreadWinCE.h: Copied from WebCore/storage/wince/DatabaseThreadWince.h.
2276         * storage/wince/DatabaseThreadWince.cpp: Removed.
2277         * storage/wince/DatabaseThreadWince.h: Removed.
2278         * storage/wince/LocalStorageThreadWinCE.cpp: Copied from WebCore/storage/wince/LocalStorageThreadWince.cpp.
2279         * storage/wince/LocalStorageThreadWinCE.h: Copied from WebCore/storage/wince/LocalStorageThreadWince.h.
2280         * storage/wince/LocalStorageThreadWince.cpp: Removed.
2281         * storage/wince/LocalStorageThreadWince.h: Removed.
2282
2283 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2284
2285         Reviewed by Eric Seidel.
2286
2287         Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
2288         https://bugs.webkit.org/show_bug.cgi?id=45900
2289
2290         PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
2291         Move them into plaform sepcific build system.
2292
2293         * CMakeLists.txt:
2294         * CMakeListsEfl.txt:
2295
2296 2010-09-18  Andreas Kling  <andreas.kling@nokia.com>
2297
2298         Reviewed by Simon Hausmann.
2299
2300         [Qt] Don't copy clip path to TransparencyLayer
2301         https://bugs.webkit.org/show_bug.cgi?id=45965
2302
2303         We don't need to copy the GC's clip path to the TransparencyLayer since it will
2304         clip anyway when ending the layer.
2305
2306         * platform/graphics/qt/TransparencyLayer.h:
2307         (WebCore::TransparencyLayer::TransparencyLayer):
2308
2309 2010-09-18  Patrick Gansterer  <paroga@paroga.com>
2310
2311         Unreviewed.
2312
2313         [WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.
2314
2315         * page/wince/FrameWince.cpp:
2316         (WebCore::computePageRectsForFrame):
2317         (WebCore::imageFromSelection):
2318
2319 2010-09-18  Kent Tamura  <tkent@chromium.org>
2320
2321         Unreviewed, a trivial change.
2322
2323         Run sort-Xcode-project-file.
2324
2325         * WebCore.xcodeproj/project.pbxproj:
2326
2327 2010-09-18  Dan Bernstein  <mitz@apple.com>
2328
2329         Reviewed by Eric Seidel.
2330
2331         REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
2332         https://bugs.webkit.org/show_bug.cgi?id=46031
2333
2334         * page/Frame.cpp:
2335         (WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
2336         (WebCore::parentTextZoomFactor): Ditto.
2337
2338 2010-09-17  Sam Weinig  <sam@webkit.org>
2339
2340         Reviewed by Jon Honeycutt.
2341
2342         Need a way to load data (as plain text) in a WKPage
2343         <rdar://problem/8424239>
2344
2345         * WebCore.exp.in:
2346
2347 2010-09-17  David Hyatt  <hyatt@apple.com>
2348
2349         Reviewed by Sam Weinig.
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.
2352         
2353         Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
2354         when appropriate.  An image on a line did this, but a block-level image did not.
2355
2356         Added fast/multicol/image-inside-nested-blocks-with-border.html
2357
2358         * rendering/RenderBlock.cpp:
2359         (WebCore::RenderBlock::layoutBlockChild):
2360
2361 2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>
2362
2363         Unreviewed, build fix.
2364
2365         Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().
2366
2367         * page/EventHandler.cpp:
2368         (WebCore::EventHandler::handleTouchEvent): Removed a helper function,
2369             added direct calls to frame->pageZoomFactor().
2370
2371 2010-09-17  David Hyatt  <hyatt@apple.com>
2372
2373         Reviewed by Simon Fraser.
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
2376
2377         Make printing store the page height in the RenderView and push that into the layout state to
2378         use the new pagination model.  The old pagination model is retained because it is still used
2379         for embedded WebViews.
2380
2381         * page/FrameView.cpp:
2382         (WebCore::FrameView::reset):
2383         (WebCore::FrameView::layout):
2384         (WebCore::FrameView::forceLayout):
2385         (WebCore::FrameView::forceLayoutForPagination):
2386         (WebCore::FrameView::adjustPageHeight):
2387         * page/FrameView.h:
2388         * page/PrintContext.cpp:
2389         (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
2390         * rendering/RenderBlock.cpp:
2391         (WebCore::RenderBlock::paintChildren):
2392         * rendering/RenderBox.cpp:
2393         (WebCore::RenderBox::calcHeight):
2394         * rendering/RenderImage.cpp:
2395         (WebCore::RenderImage::paintReplaced):
2396         * rendering/RenderLineBoxList.cpp:
2397         (WebCore::RenderLineBoxList::paint):
2398         * rendering/RenderVideo.cpp:
2399         (WebCore::RenderVideo::paintReplaced):
2400         * rendering/RenderView.cpp:
2401         (WebCore::RenderView::RenderView):
2402         (WebCore::RenderView::layout):
2403         (WebCore::RenderView::paint):
2404         (WebCore::RenderView::setBestTruncatedAt):
2405         * rendering/RenderView.h:
2406         (WebCore::RenderView::popLayoutState):
2407         (WebCore::RenderView::pageHeight):
2408         (WebCore::RenderView::setPageHeight):
2409         (WebCore::RenderView::bestTruncatedAt):
2410         (WebCore::RenderView::truncatedAt):
2411         (WebCore::RenderView::setTruncatedAt):
2412         (WebCore::RenderView::printRect):
2413         (WebCore::RenderView::setPrintRect):
2414         (WebCore::RenderView::pushLayoutState):
2415         (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
2416         (WebCore::LayoutStateMaintainer::push):
2417         (WebCore::LayoutStateMaintainer::pop):
2418
2419 2010-09-17  Dan Bernstein  <mitz@apple.com>
2420
2421         Reviewed by Simon Fraser.
2422
2423         Canvas sizing ignores intrinsic size
2424         https://bugs.webkit.org/show_bug.cgi?id=46024
2425
2426         Updated fast/replaced/table-percent-height.html
2427
2428         * rendering/RenderEmbeddedObject.cpp:
2429         (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
2430         for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
2431         width is auto and height is specified).
2432         * rendering/RenderImage.cpp:
2433         (WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
2434         RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
2435         which we don’t want.
2436         (WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().
2437         * rendering/RenderImage.h:
2438         * rendering/RenderReplaced.cpp:
2439         (WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
2440         (WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
2441         is{Width,Height}Specified().
2442         (WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
2443         up here so other replaced objects could use this logic.
2444         (WebCore::RenderReplaced::calcReplacedHeight): Ditto.
2445         (WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
2446         (WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
2447         (WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
2448         of the logic.
2449         (WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.
2450         * rendering/RenderReplaced.h:
2451         (WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
2452         to allow RenderVideo to call through.
2453         (WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.
2454         * rendering/RenderVideo.cpp:
2455         (WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
2456         the way other RenderReplaced objects do.
2457         (WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
2458         which matches what used to be here, skipping over the RenderImage implementation.
2459         (WebCore::RenderVideo::calcReplacedHeight): Ditto.
2460         (WebCore::RenderVideo::minimumReplacedHeight): Ditto.
2461         * rendering/RenderVideo.h:
2462
2463 2010-09-17  Darin Adler  <darin@apple.com>
2464
2465         Build fix for platforms that compile Touch.
2466
2467         * dom/Touch.cpp:
2468         (WebCore::contentsX):
2469         (WebCore::contentsY):
2470         Get zoom factor from Frame rather than FrameView.
2471
2472 2010-09-17  Darin Adler  <darin@apple.com>
2473
2474         Reviewed by Sam Weinig.
2475
2476         REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
2477         https://bugs.webkit.org/show_bug.cgi?id=42863
2478
2479         Moved zoom level back from FrameView to Frame.
2480         I had forgotten that FrameView's lifetime is much shorter than
2481         Frame's, and until that is fixed it's best to leave this on Frame.
2482
2483         * WebCore.exp.in: Updated.
2484
2485         * css/CSSStyleSelector.cpp:
2486         (WebCore::CSSStyleSelector::styleForDocument):
2487         (WebCore::CSSStyleSelector::applyProperty):
2488         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
2489         * dom/Document.cpp:
2490         (WebCore::Document::nodesFromRect):
2491         (WebCore::Document::elementFromPoint):
2492         (WebCore::Document::caretRangeFromPoint):
2493         * dom/MouseRelatedEvent.cpp:
2494         (WebCore::contentsX):
2495         (WebCore::contentsY):
2496         (WebCore::pageZoomFactor):
2497         * dom/Node.cpp:
2498         (WebCore::Node::dispatchMouseEvent):
2499         (WebCore::Node::dispatchWheelEvent):
2500         * html/HTMLBodyElement.cpp:
2501         (WebCore::adjustForZoom):
2502         (WebCore::HTMLBodyElement::scrollLeft):
2503         (WebCore::HTMLBodyElement::setScrollLeft):
2504         (WebCore::HTMLBodyElement::scrollTop):
2505         (WebCore::HTMLBodyElement::setScrollTop):
2506         (WebCore::HTMLBodyElement::scrollHeight):
2507         (WebCore::HTMLBodyElement::scrollWidth):
2508         * html/ImageDocument.cpp:
2509         (WebCore::pageZoomFactor):
2510         (WebCore::ImageDocument::scale):
2511         (WebCore::ImageDocument::imageFitsInWindow):
2512         * page/DOMWindow.cpp:
2513         (WebCore::DOMWindow::innerHeight):
2514         (WebCore::DOMWindow::innerWidth):
2515         (WebCore::DOMWindow::scrollX):
2516         (WebCore::DOMWindow::scrollY):
2517         (WebCore::DOMWindow::scrollTo):
2518         * page/DragController.cpp:
2519         (WebCore::elementUnderMouse):
2520         * rendering/RenderView.cpp:
2521         (WebCore::RenderView::zoomFactor):
2522         * svg/SVGSVGElement.cpp:
2523         (WebCore::SVGSVGElement::currentScale):
2524         (WebCore::SVGSVGElement::setCurrentScale):
2525         Get zoom factor from Frame rather than FrameView.
2526
2527         * page/Frame.cpp:
2528         (WebCore::parentPageZoomFactor): Moved back here from FrameView.
2529         (WebCore::parentTextZoomFactor): Ditto.
2530         (WebCore::Frame::Frame): Ditto.
2531         (WebCore::Frame::setPageZoomFactor): Ditto.
2532         (WebCore::Frame::setTextZoomFactor): Ditto.
2533         (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
2534
2535         * page/Frame.h: Moved functions and data for zooming back here
2536         from FrameView.
2537
2538         * page/FrameView.cpp:
2539         (WebCore::FrameView::FrameView):
2540         * page/FrameView.h:
2541         Removed code from here.
2542
2543 2010-09-17  Matthew Delaney  <mdelaney@apple.com>
2544
2545         Reviewed by Simon Fraser.
2546
2547         Reduce minimum DOMTimer interval
2548         https://bugs.webkit.org/show_bug.cgi?id=45362
2549
2550         Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
2551         which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
2552         performance on perf tests that have tight frequent loops such as canvas "animation"
2553         performance tests.
2554
2555         No new tests added. Can't reliably instrument a test in javascript to verify that
2556         the minimum clamped interval time is in fact 4ms. 
2557
2558         * WebCore.exp.in:
2559         * page/DOMTimer.cpp: Removed old comments.
2560         * page/DOMTimer.h: Removed old comments.
2561         * page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
2562         * page/Settings.h:
2563
2564 2010-09-17  Marc-Antoine Ruel  <maruel@chromium.org>
2565
2566         Reviewed by Dimitri Glazkov.
2567
2568         [Chromium] Split webcore_platform off webcore_remaining
2569
2570         Further reduce webcore_remaining size by moving platform/ code in its
2571         own static libary.
2572         https://bugs.webkit.org/show_bug.cgi?id=45915
2573
2574         * WebCore.gyp/WebCore.gyp:
2575
2576 2010-09-13  Matt Perry  <mpcomplete@chromium.org>
2577
2578         Reviewed by Darin Fisher.
2579
2580         Have V8DOMWindowShell ask the embedder whether to run a V8 extension
2581         in a particular script context.
2582         https://bugs.webkit.org/show_bug.cgi?id=45721
2583
2584         * bindings/v8/V8DOMWindowShell.cpp:
2585         (WebCore::V8DOMWindowShell::createNewContext):
2586         * bindings/v8/V8Proxy.cpp:
2587         (WebCore::V8Proxy::registeredExtensionWithV8):
2588         (WebCore::V8Proxy::registerExtension):
2589         * bindings/v8/V8Proxy.h:
2590         * loader/EmptyClients.h:
2591         (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
2592         * loader/FrameLoaderClient.h:
2593
2594 2010-09-17  Anders Carlsson  <andersca@apple.com>
2595
2596         Reviewed by Sam Weinig.
2597
2598         REGRESSION (r66711): Plug-in replacement text is never shown
2599         https://bugs.webkit.org/show_bug.cgi?id=45997
2600         <rdar://problem/8446766>
2601
2602         Don't return when the plug-in has replacement text.
2603
2604         * rendering/RenderEmbeddedObject.cpp:
2605         (WebCore::RenderEmbeddedObject::paintReplaced):
2606
2607 2010-09-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2608
2609         Unreviewed, build fix. Add files missed in r67704.
2610
2611         * CMakeLists.txt:
2612
2613 2010-09-17  Simon Fraser  <simon.fraser@apple.com>
2614
2615         Reviewed by Chris Marrin.
2616
2617         Remove scroll and clip layers for WKCACFLayerRenderer
2618         https://bugs.webkit.org/show_bug.cgi?id=45922
2619
2620         WKCACFLayerRenderer no longer needs its own layers for managing scrolling
2621         and clipping, because RenderLayerCompositor provides this functionality.
2622
2623         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
2624         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame().
2625         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
2626
2627         * platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers
2628         (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
2629         (WebCore::WKCACFLayerRenderer::setRootChildLayer):
2630         (WebCore::WKCACFLayerRenderer::destroyRenderer):
2631         (WebCore::WKCACFLayerRenderer::resize):
2632         * platform/graphics/win/WKCACFLayerRenderer.h:
2633
2634         * rendering/RenderLayerCompositor.cpp:
2635         (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer.
2636         (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows,
2637         always say yes.
2638
2639 2010-09-17  Jian Li  <jianli@chromium.org>
2640
2641         Reviewed by Dmitry Titov.
2642
2643         createBlobURL with no argument causes crash.
2644         https://bugs.webkit.org/show_bug.cgi?id=45880
2645
2646         The fix is to check if the passing blob argument is NULL or not.
2647
2648         Test: fast/files/create-blob-url-crash.html
2649
2650         * dom/ScriptExecutionContext.cpp:
2651         (WebCore::ScriptExecutionContext::createPublicBlobURL):
2652         * page/DOMWindow.idl: Add attribute to convert null string to undefined.
2653
2654 2010-09-17  Chris Marrin  <cmarrin@apple.com>
2655
2656         Reviewed by Simon Fraser.
2657
2658         Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
2659         https://bugs.webkit.org/show_bug.cgi?id=45911
2660
2661         * WebCore.exp.in:
2662
2663 2010-09-17  Tony Gentilcore  <tonyg@chromium.org>
2664
2665         Reviewed by Adam Barth.
2666
2667         ASSERTION FAILED: m_loadEventDelayCount
2668         https://bugs.webkit.org/show_bug.cgi?id=45790
2669
2670         * dom/AsyncScriptRunner.cpp: 
2671         (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
2672
2673 2010-09-17  Stephen White  <senorblanco@chromium.org>
2674
2675         Reviewed by Kenneth Russell.
2676
2677         [CHROMIUM] GPU-accelerated canvas should work in test_shell.
2678         https://bugs.webkit.org/show_bug.cgi?id=45968
2679
2680         In order for the shaders in GPU-accelerated canvas to work in both the
2681         GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
2682         passes them to the Mesa backend unmodified), the precision specifiers
2683         in the fragment shader have to be wrapped in #if GL_ES.
2684
2685         Soon to be covered by many layout tests.
2686
2687         * platform/graphics/gpu/SolidFillShader.cpp:
2688         (WebCore::SolidFillShader::create):
2689         * platform/graphics/gpu/TexShader.cpp:
2690         (WebCore::TexShader::create):
2691
2692 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2693
2694         Reviewed by Xan Lopez.
2695
2696         [GTK] [REGRESSION] Listbox rendering is incorrect
2697         https://bugs.webkit.org/show_bug.cgi?id=45941
2698
2699         Only apply the shadow tiling optimization to a layer if the GraphicsContext
2700         has a shadow.
2701
2702         This is covered by manual-tests/select-element-type-select.html.
2703
2704         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2705         (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization
2706         first check to see if the context has a shadow at all.
2707
2708 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2709
2710         Reviewed by Oliver Hunt.
2711
2712         [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
2713         https://bugs.webkit.org/show_bug.cgi?id=45917
2714
2715         Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
2716         members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
2717         as this type is reference-counted.
2718
2719         No new tests as this should not introduce any functionality changes.
2720
2721         * platform/graphics/cairo/FontCacheFreeType.cpp:
2722         (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes.
2723         (WebCore::FontCache::createFontPlatformData): Ditto.
2724         * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
2725         (WebCore::FontPlatformData::FontPlatformData): Ditto.
2726         (WebCore::FontPlatformData::operator=): Ditto.
2727         (WebCore::FontPlatformData::~FontPlatformData): Ditto.
2728         (WebCore::FontPlatformData::isFixedPitch): Ditto.
2729         (WebCore::FontPlatformData::operator==): Ditto.
2730         * platform/graphics/cairo/FontPlatformDataFreeType.h:
2731         (WebCore::FontPlatformData::FontPlatformData): Ditto.
2732         (WebCore::FontPlatformData::scaledFont): Ditto.
2733         (WebCore::FontPlatformData::hash): Ditto.
2734         (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
2735         * platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp:
2736         (WebCore::GlyphPage::fill): Ditto.
2737         * platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
2738         * platform/graphics/cairo/OwnPtrCairo.h: Ditto.
2739         * platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations.
2740         (WTF::refPlatformPtr): Ditto.
2741         (WTF::derefPlatformPtr): Ditto.
2742         * platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
2743         * platform/graphics/cairo/SimpleFontDataCairo.cpp:
2744         (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes.
2745         (WebCore::SimpleFontData::containsCharacters): Ditto.
2746         (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
2747         * platform/graphics/gtk/FontGtk.cpp:
2748         (WebCore::setPangoAttributes): Ditto.
2749
2750 2010-09-14  Pavel Podivilov  <podivilov@chromium.org>
2751
2752         Reviewed by Pavel Feldman.
2753
2754         Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
2755         https://bugs.webkit.org/show_bug.cgi?id=45114
2756
2757         * English.lproj/localizedStrings.js:
2758         * inspector/InspectorDOMAgent.cpp:
2759         (WebCore::InspectorDOMAgent::performSearch):
2760         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
2761         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
2762         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
2763         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
2764         * inspector/InspectorDOMAgent.h:
2765         * inspector/InspectorDebuggerAgent.cpp:
2766         (WebCore::InspectorDebuggerAgent::didPause):
2767         * inspector/front-end/CallStackSidebarPane.js:
2768         (WebInspector.CallStackSidebarPane):
2769         (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s):
2770         (WebInspector.CallStackSidebarPane.prototype.updateStatus.append):
2771         (WebInspector.CallStackSidebarPane.prototype.updateStatus):
2772         * inspector/front-end/ElementsPanel.js:
2773         (WebInspector.ElementsPanel.prototype.linkifyNodeById):
2774         * inspector/front-end/ScriptsPanel.js:
2775         (WebInspector.ScriptsPanel.prototype.debuggerPaused):
2776         * inspector/front-end/inspector.css:
2777         (.pane > .body .placard + .info):
2778         * inspector/front-end/inspector.js:
2779         (WebInspector.pausedScript):
2780         (WebInspector.formatLocalized):
2781
2782 2010-09-17  Johnny Ding  <jnd@chromium.org>
2783
2784         Reviewed by Adam Barth.
2785
2786         Stop history reload navigation to bypass WebKit's popup blocker.
2787         Now history reload can only navigate the page in self frame, no matter
2788         what target frame is defined in <base> and no new window can be created.
2789         https://bugs.webkit.org/show_bug.cgi?id=45369
2790
2791         Test: fast/events/popup-blocked-from-history-reload.html
2792
2793         * loader/RedirectScheduler.cpp:
2794         (WebCore::ScheduledNavigation::ScheduledNavigation):
2795         (WebCore::ScheduledNavigation::wasUserGesture):
2796         Move the m_wasUserGesture to base class ScheduledNavigation. Then all
2797         asynchronous navigation situations can restore the correct gesture state
2798         during the real navigation process.
2799         (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
2800         (WebCore::ScheduledURLNavigation::fire):
2801         (WebCore::ScheduledURLNavigation::referrer):
2802         (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
2803         (WebCore::ScheduledHistoryNavigation::fire):
2804         (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
2805         (WebCore::ScheduledFormSubmission::fire):
2806         (WebCore::RedirectScheduler::scheduleHistoryNavigation):
2807
2808 2010-09-16  Vangelis Kokkevis  <vangelis@chromium.org>
2809
2810         Reviewed by James Robinson.
2811
2812         [chromium] Clip the update region of an ImageLayerChromium to actual size
2813         of the image bitmap to prevent uninitialized memory access when uploading
2814         the dirty region to the texture.
2815         https://bugs.webkit.org/show_bug.cgi?id=45937
2816
2817
2818         * platform/graphics/chromium/ImageLayerChromium.cpp:
2819         (WebCore::ImageLayerChromium::updateContents):
2820
2821 2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>
2822
2823         Reviewed by David Hyatt.
2824
2825         Remove extraneous RenderObject traversal.
2826         https://bugs.webkit.org/show_bug.cgi?id=45821
2827
2828         This code always exits in the first iteration of the loop,
2829         because in the context of this call, node->renderer()->node() != 0
2830         is always true.
2831
2832         No behavior change, covered by existing tests.
2833
2834         * page/EventHandler.cpp:
2835         (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop.
2836         (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
2837
2838 2010-09-17  Pavel Feldman  <pfeldman@chromium.org>
2839
2840         Reviewed by Yury Semikhatsky.
2841
2842         Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
2843         resource as not cached to InspectorController.
2844         https://bugs.webkit.org/show_bug.cgi?id=45961
2845
2846         Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
2847         resource as not cached to InspectorController.
2848         There is one path in control flow that leads to resources being
2849         reported as not cached. Patch to follow.
2850
2851         * inspector/InspectorController.cpp:
2852         (WebCore::InspectorController::markResourceAsCached):
2853         * inspector/InspectorController.h:
2854         * inspector/InspectorResource.cpp:
2855         (WebCore::InspectorResource::markAsCached):
2856         (WebCore::InspectorResource::updateResponse):
2857         * inspector/InspectorResource.h:
2858         * loader/FrameLoader.cpp:
2859         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
2860
2861 2010-09-17  Alexander Pavlov  <apavlov@chromium.org>
2862
2863         Unreviewed, build fix. Add files missed in the previous commit.
2864
2865         * GNUmakefile.am:
2866         * css/CSSPropertySourceData.cpp: Added.
2867         (WebCore::SourceRange::SourceRange):
2868         (WebCore::SourceRange::operator=):
2869         (WebCore::CSSPropertySourceData::CSSPropertySourceData):
2870         (WebCore::CSSPropertySourceData::operator=):
2871         (WebCore::CSSPropertySourceData::toString):
2872         (WebCore::CSSPropertySourceData::hash):
2873         (WebCore::CSSPropertySourceData::init):
2874         * css/CSSPropertySourceData.h: Added.
2875         (WebCore::CSSPropertySourceData::~CSSPropertySourceData):
2876         (WebCore::CSSStyleSourceData::create):
2877
2878 2010-09-15  Alexander Pavlov  <apavlov@chromium.org>
2879
2880         Reviewed by Pavel Feldman.
2881
2882         Provide source-based properties for style declarations to CSSParser clients
2883
2884         This change:
2885         - Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets,
2886           even with the resource tracking turned off.
2887         - Adds to CSSParser a capability of source-related style declaration data extraction:
2888           * Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
2889           * Start/end source offsets for CSS properties, relative to the declaration start.
2890           * CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
2891         - Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData().
2892         https://bugs.webkit.org/show_bug.cgi?id=44949
2893
2894         * WebCore.gypi:
2895         * WebCore.pro:
2896         * WebCore.vcproj/WebCore.vcproj:
2897         * WebCore.xcodeproj/project.pbxproj:
2898         * css/CSSGrammar.y:
2899         * css/CSSMutableStyleDeclaration.h:
2900         (WebCore::CSSMutableStyleDeclaration::node):
2901         * css/CSSParser.cpp:
2902         (WebCore::CSSParser::CSSParser):
2903         (WebCore::CSSParser::parseSheet):
2904         (WebCore::CSSParser::parseDeclaration):
2905         (WebCore::CSSParser::createStyleRule):
2906         (WebCore::CSSParser::markRuleBodyStart):
2907         (WebCore::CSSParser::markPropertyStart):
2908         (WebCore::CSSParser::markPropertyEnd):
2909         * css/CSSParser.h:
2910         (WebCore::CSSParser::resetPropertyMarks):
2911         * css/CSSPropertySourceData.cpp: Added.
2912         (WebCore::SourceRange::SourceRange):
2913         (WebCore::SourceRange::operator=):
2914         (WebCore::CSSPropertySourceData::CSSPropertySourceData):
2915         (WebCore::CSSPropertySourceData::operator=):
2916         (WebCore::CSSPropertySourceData::toString):
2917         (WebCore::CSSPropertySourceData::hash):
2918         (WebCore::CSSPropertySourceData::init):
2919         * css/CSSPropertySourceData.h: Added.
2920         (WebCore::CSSPropertySourceData::~CSSPropertySourceData):
2921         (WebCore::CSSStyleSourceData::create):
2922         * inspector/Inspector.idl:
2923         * inspector/InspectorCSSStore.cpp:
2924         (WebCore::InspectorCSSStore::reset):
2925         (WebCore::InspectorCSSStore::styleSheetText):
2926         (WebCore::InspectorCSSStore::resourceStyleSheetText):
2927         (WebCore::InspectorCSSStore::inlineStyleSheetText):
2928         (WebCore::InspectorCSSStore::getStyleSourceData):
2929         (WebCore::InspectorCSSStore::extractRanges):
2930         (WebCore::InspectorCSSStore::getStyleAttributeRanges):
2931         (WebCore::InspectorCSSStore::getParentStyleSheet):
2932         (WebCore::InspectorCSSStore::inlineStyleElement):
2933         * inspector/InspectorCSSStore.h:
2934         * inspector/InspectorController.cpp:
2935         (WebCore::InspectorController::resourceContentForURL):
2936         * inspector/InspectorController.h:
2937         * inspector/InspectorDOMAgent.cpp:
2938         (WebCore::InspectorDOMAgent::getStyleSourceData):
2939         (WebCore::InspectorDOMAgent::buildObjectForStyle):
2940         * inspector/InspectorDOMAgent.h:
2941
2942 2010-09-17  Alexander Pavlov  <apavlov@chromium.org>
2943
2944         Reviewed by Pavel Feldman.
2945
2946         Web Inspector: Show node description in inspector highlight
2947         https://bugs.webkit.org/show_bug.cgi?id=20930
2948
2949         * inspector/InspectorController.cpp:
2950         (WebCore::InspectorController::drawNodeHighlight):
2951         (WebCore::InspectorController::drawElementTitle):
2952         * inspector/InspectorController.h:
2953
2954 2010-09-16  takano takumi  <takano1@asia.apple.com>
2955
2956         Reviewed by Kent Tamura.
2957
2958         https://bugs.webkit.org/show_bug.cgi?id=45020
2959         Support "block-flow" and "writing-mode": interpret properties into RenderStyle
2960
2961         Fixed a regression in SVG test introduced by my previous change.
2962
2963         * css/CSSPrimitiveValueMappings.h:
2964         (WebCore::CSSPrimitiveValue::operator EWritingMode):
2965         * css/SVGCSSParser.cpp:
2966         (WebCore::CSSParser::parseSVGValue):
2967
2968 2010-09-16  Kenneth Russell  <kbr@google.com>
2969
2970         Reviewed by James Robinson.
2971
2972         Add entry points to GraphicsContext3D needed for Chromium compositor port
2973         https://bugs.webkit.org/show_bug.cgi?id=45939
2974
2975         Added entry points for two Chromium-specific extensions, and added
2976         a flag to the GraphicsContext3D constructor, currently unsupported
2977         by all ports (including Chromium), indicating whether the context
2978         should render directly to the passed HostWindow or off-screen per
2979         the current semantics. The switch to use GraphicsContext3D in
2980         Chromium's compositor will follow in a subsequent patch.
2981
2982         No new tests; functionality is unchanged. Built and tested
2983         Chromium and WebKit on Mac OS X.
2984
2985         * platform/graphics/GraphicsContext3D.cpp:
2986         (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM):
2987         (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM):
2988         (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM):
2989         (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM):
2990         (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM):
2991         (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM):
2992         (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
2993         * platform/graphics/GraphicsContext3D.h:
2994         * platform/graphics/mac/GraphicsContext3DMac.mm:
2995         (WebCore::GraphicsContext3D::create):
2996         (WebCore::GraphicsContext3D::GraphicsContext3D):
2997         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2998         (WebCore::GraphicsContext3D::create):
2999         (WebCore::GraphicsContext3D::GraphicsContext3D):
3000
3001 2010-09-16  Simon Fraser  <simon.fraser@apple.com>
3002
3003         Reviewed by James Robinson.
3004
3005         In layerTreeAsText output, avoid printing properties which have their default values
3006         https://bugs.webkit.org/show_bug.cgi?id=45931
3007
3008         Don't dump properties that have their default values to simplify output.
3009
3010         * platform/graphics/GraphicsLayer.cpp:
3011         (WebCore::GraphicsLayer::dumpProperties):
3012
3013 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
3014
3015         Reviewed by Ariya Hidayat.
3016
3017         [Qt] GraphicsContext: Remove unused variable
3018
3019         GraphicsContextPlatformPrivate::redirect wasn't used for anything.
3020
3021         * platform/graphics/qt/GraphicsContextQt.cpp:
3022         (WebCore::GraphicsContextPlatformPrivate::p):
3023         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
3024
3025 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
3026
3027         Reviewed by Ariya Hidayat.
3028
3029         [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
3030         https://bugs.webkit.org/show_bug.cgi?id=45923
3031
3032         QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
3033         instead of QPainter::clipPath().isEmpty().
3034
3035         * platform/graphics/qt/TransparencyLayer.h:
3036         (WebCore::TransparencyLayer::TransparencyLayer):
3037
3038 2010-09-16  David Hyatt  <hyatt@apple.com>
3039
3040         Reviewed by Eric Seidel.
3041
3042         Fix for regression from my previous check-in.  Make sure not to move the LayoutRepainter line
3043         below the setHeight(0) call.  This meant it snagged the wrong rectangle and we ended up repainting
3044         the world.
3045
3046         * rendering/RenderBlock.cpp:
3047         (WebCore::RenderBlock::layoutBlock):
3048
3049 2010-09-16  takano takumi  <takano1@asia.apple.com>
3050
3051         Reviewed by Dave Hyatt.
3052
3053         https://bugs.webkit.org/show_bug.cgi?id=45020
3054         Support "block-flow" and "writing-mode": interpret properties into RenderStyle
3055  
3056         Added code that interprets "block-flow" property and "writing-mode" property settings
3057         into a RenderStyle object.
3058
3059         Test: fast/text/international/block-flow-parser-test.html
3060
3061         * css/CSSComputedStyleDeclaration.cpp:
3062         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3063         * css/CSSParser.cpp:
3064         (WebCore::CSSParser::parseValue):
3065         * css/CSSPrimitiveValueMappings.h:
3066         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3067         (WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):
3068         * css/CSSPropertyNames.in:
3069         * css/CSSStyleSelector.cpp:
3070         (WebCore::CSSStyleSelector::applyProperty):
3071         * css/CSSValueKeywords.in:
3072         * css/SVGCSSValueKeywords.in:
3073         * rendering/style/RenderStyle.cpp:
3074         (WebCore::RenderStyle::diff):
3075         * rendering/style/RenderStyle.h:
3076         (WebCore::InheritedFlags::setBitDefaults):
3077         (WebCore::InheritedFlags::blockFlow):
3078         (WebCore::InheritedFlags::setBlockFlow):
3079         (WebCore::InheritedFlags::initialBlockFlow):
3080         * rendering/style/RenderStyleConstants.h:
3081
3082 2010-09-16  Martin Robinson  <mrobinson@igalia.com>
3083
3084         Reviewed by Xan Lopez.
3085
3086         [GTK] Implement dissolveDragImageToFraction
3087         https://bugs.webkit.org/show_bug.cgi?id=45826
3088
3089         Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
3090         might this allow code to be shared between Cairo ports it prevents a
3091         full data copy when the image is not resized and makes the implementation
3092         of dissolveDragImageToFraction more straight-forward.
3093
3094         This feature is covered by manual-tests/drag-image.html.
3095
3096         * page/gtk/DragControllerGtk.cpp:
3097         (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag
3098         image a little smaller.
3099         * platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
3100         * platform/gtk/DragImageGtk.cpp:
3101         (WebCore::dragImageSize): Reimplemented to reflect new drag image type.
3102         (WebCore::deleteDragImage): Ditto.
3103         (WebCore::scaleDragImage): Ditto.
3104         (WebCore::dissolveDragImageToFraction): Filled the stub of this function.
3105         (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
3106         * platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.
3107
3108 2010-09-15  David Hyatt  <hyatt@apple.com>
3109
3110         Reviewed by Darin Adler.
3111
3112         https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.
3113
3114         This patch adds support for column breaking at layout time rather than at paint time.  New variables have been
3115         added to LayoutState and to ColumnInfo to track column information while laying out.
3116         
3117         The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
3118         into multiple columns.  Now, however, layout is aware of the columns and will move objects up and down vertically in order
3119         to ensure they don't intersect a break.
3120         
3121         Many new tests added in fast/multicol and new results added for existing fast/multicol tests.
3122
3123         * rendering/ColumnInfo.h:
3124         (WebCore::ColumnInfo::ColumnInfo):
3125         (WebCore::ColumnInfo::columnCount):
3126         (WebCore::ColumnInfo::columnHeight):
3127         (WebCore::ColumnInfo::setColumnCountAndHeight):
3128         (WebCore::ColumnInfo::setColumnHeight):
3129         (WebCore::ColumnInfo::updateMinimumColumnHeight):
3130         (WebCore::ColumnInfo::minimumColumnHeight):
3131         (WebCore::ColumnInfo::forcedBreaks):
3132         (WebCore::ColumnInfo::forcedBreakOffset):
3133         (WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
3134         (WebCore::ColumnInfo::clearForcedBreaks):
3135         (WebCore::ColumnInfo::addForcedBreak):
3136         * rendering/LayoutState.cpp:
3137         (WebCore::LayoutState::LayoutState):
3138         (WebCore::LayoutState::clearPaginationInformation):
3139         (WebCore::LayoutState::pageY):
3140         (WebCore::LayoutState::addForcedColumnBreak):
3141         * rendering/LayoutState.h:
3142         (WebCore::LayoutState::LayoutState):
3143         (WebCore::LayoutState::paginatingColumns):
3144         (WebCore::LayoutState::paginated):
3145         * rendering/RenderBlock.cpp:
3146         (WebCore::RenderBlock::RenderBlock):
3147         (WebCore::RenderBlock::~RenderBlock):
3148         (WebCore::RenderBlock::layoutBlock):
3149         (WebCore::RenderBlock::collapseMargins):
3150         (WebCore::RenderBlock::estimateVerticalPosition):
3151         (WebCore::RenderBlock::layoutBlockChild):
3152         (WebCore::RenderBlock::layoutPositionedObjects):
3153         (WebCore::RenderBlock::paintColumnRules):
3154         (WebCore::RenderBlock::paintColumnContents):
3155         (WebCore::RenderBlock::paintChildren):
3156         (WebCore::RenderBlock::insertFloatingObject):
3157         (WebCore::RenderBlock::removeFloatingObjects):
3158         (WebCore::RenderBlock::positionNewFloats):
3159         (WebCore::RenderBlock::positionNewFloatOnLine):
3160         (WebCore::RenderBlock::lowestPosition):
3161         (WebCore::RenderBlock::rightmostPosition):
3162         (WebCore::RenderBlock::leftmostPosition):
3163         (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
3164         (WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
3165         (WebCore::RenderBlock::hitTestColumns):
3166         (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
3167         (WebCore::RenderBlock::columnCount):
3168         (WebCore::RenderBlock::columnRectAt):
3169         (WebCore::RenderBlock::layoutColumns):
3170         (WebCore::RenderBlock::adjustPointToColumnContents):
3171         (WebCore::RenderBlock::adjustRectForColumns):
3172         (WebCore::RenderBlock::adjustForColumns):
3173         (WebCore::RenderBlock::setMaxTopMargins):
3174         (WebCore::RenderBlock::setMaxBottomMargins):
3175         (WebCore::RenderBlock::setPaginationStrut):
3176         (WebCore::RenderBlock::setPageY):
3177         (WebCore::RenderBlock::nextPageTop):
3178         (WebCore::inNormalFlow):
3179         (WebCore::RenderBlock::applyBeforeBreak):
3180         (WebCore::RenderBlock::applyAfterBreak):
3181         (WebCore::RenderBlock::adjustForUnsplittableChild):
3182         (WebCore::RenderBlock::adjustLinePositionForPagination):
3183         * rendering/RenderBlock.h:
3184         (WebCore::RenderBlock::paginationStrut):
3185         (WebCore::RenderBlock::pageY):
3186         (WebCore::RenderBlock::maxTopPosMargin):
3187         (WebCore::RenderBlock::maxTopNegMargin):
3188         (WebCore::RenderBlock::maxBottomPosMargin):
3189         (WebCore::RenderBlock::maxBottomNegMargin):
3190         (WebCore::RenderBlock::initMaxMarginValues):
3191         (WebCore::RenderBlock::FloatingObject::FloatingObject):
3192         (WebCore::RenderBlock::FloatingObject::type):
3193         (WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
3194         * rendering/RenderBlockLineLayout.cpp:
3195         (WebCore::RenderBlock::layoutInlineChildren):
3196         (WebCore::RenderBlock::determineStartPosition):
3197         (WebCore::RenderBlock::skipLeadingWhitespace):
3198         (WebCore::RenderBlock::findNextLineBreak):
3199         * rendering/RenderBox.cpp:
3200         (WebCore::RenderBox::mapLocalToContainer):
3201         (WebCore::RenderBox::computeRectForRepaint):
3202         (WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):
3203         * rendering/RenderBox.h:
3204         * rendering/RenderFlexibleBox.cpp:
3205         (WebCore::RenderFlexibleBox::layoutBlock):
3206         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
3207         (WebCore::RenderFlexibleBox::layoutVerticalBox):
3208         * rendering/RenderFlexibleBox.h:
3209         * rendering/RenderInline.cpp:
3210         (WebCore::RenderInline::computeRectForRepaint):
3211         (WebCore::RenderInline::mapLocalToContainer):
3212         * rendering/RenderLayer.cpp:
3213         (WebCore::RenderLayer::updatePagination):
3214         (WebCore::RenderLayer::paintChildLayerIntoColumns):
3215         (WebCore::RenderLayer::hitTestChildLayerColumns):
3216         * rendering/RenderLineBoxList.cpp:
3217         (WebCore::RenderLineBoxList::paint):
3218         * rendering/RenderTable.cpp:
3219         (WebCore::RenderTable::RenderTable):
3220         (WebCore::RenderTable::layout):
3221         * rendering/RenderTable.h:
3222         * rendering/RenderTableRow.cpp:
3223         (WebCore::RenderTableRow::layout):
3224         * rendering/RenderTableSection.cpp:
3225         (WebCore::RenderTableSection::layoutRows):
3226         * rendering/RenderView.cpp:
3227         (WebCore::RenderView::RenderView):
3228         (WebCore::RenderView::pushLayoutState):
3229         * rendering/RenderView.h:
3230         (WebCore::RenderView::setTruncatedAt):
3231         (WebCore::RenderView::pushLayoutState):
3232         (WebCore::RenderView::popLayoutState):
3233         (WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
3234         (WebCore::LayoutStateMaintainer::push):
3235         * rendering/RootInlineBox.h:
3236         (WebCore::RootInlineBox::RootInlineBox):
3237         (WebCore::RootInlineBox::paginationStrut):
3238         (WebCore::RootInlineBox::setPaginationStrut):
3239
3240 2010-09-16  Pavel Podivilov  <podivilov@chromium.org>
3241
3242         Reviewed by Dimitri Glazkov.
3243
3244         Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
3245         https://bugs.webkit.org/show_bug.cgi?id=45737
3246
3247         Test: fast/frames/frame-limit.html
3248
3249         * html/HTMLFrameOwnerElement.cpp:
3250         (WebCore::HTMLFrameOwnerElement::willRemove):
3251
3252 2010-09-16  Thomas Zander <t.zander@nokia.com>
3253
3254         Reviewed by Andreas Kling.
3255
3256         https://bugs.webkit.org/show_bug.cgi?id=45878
3257
3258         [Qt] Fixed incorrect Symbian scoping.
3259
3260         The missing install functionality is only true for mmp based systems.
3261
3262         * WebCore.pro: limit functionality to mmp systems.
3263
3264 2010-09-16  Anders Carlsson  <andersca@apple.com>
3265
3266         Fix clang build.
3267
3268         * page/animation/AnimationBase.h:
3269         Fix struct/class mismatch.
3270
3271 2010-09-16  Darin Adler  <darin@apple.com>
3272
3273         Reviewed by Andreas Kling.
3274
3275         Reduce use of HTMLInputElement::inputType so we can remove it later
3276         https://bugs.webkit.org/show_bug.cgi?id=45903
3277
3278         * accessibility/AccessibilityRenderObject.cpp:
3279         (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload.
3280         (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton.
3281         (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use
3282         isCheckbox and isRadioButton.
3283
3284         * css/CSSStyleSelector.cpp:
3285         (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.
3286
3287         * editing/Editor.cpp:
3288         (WebCore::Editor::setBaseWritingDirection): Use isTextField.
3289
3290         * editing/ReplaceSelectionCommand.cpp:
3291         (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.
3292
3293         * editing/SelectionController.cpp:
3294         (WebCore::SelectionController::isInPasswordField): Use isPasswordField.
3295
3296         * html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.
3297
3298         * page/Chrome.cpp:
3299         (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.
3300
3301         * page/DragController.cpp:
3302         (WebCore::asFileInput): Use isFileUpload.
3303
3304         * page/EventHandler.cpp:
3305         (WebCore::isSubmitImage): Use isImageButton.
3306
3307         * rendering/RenderFileUploadControl.cpp:
3308         (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.
3309
3310 2010-09-16  Pavel Podivilov  <podivilov@chromium.org>
3311
3312         Reviewed by Pavel Feldman.
3313
3314         Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
3315         https://bugs.webkit.org/show_bug.cgi?id=45901
3316
3317         * inspector/InspectorController.cpp:
3318         (WebCore::InspectorController::breakpointsSettingKey):
3319
3320 2010-09-16  Pavel Feldman  <pfeldman@chromium.org>
3321
3322         Reviewed by Yury Semikhatsky.
3323
3324         Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
3325         https://bugs.webkit.org/show_bug.cgi?id=45892
3326
3327         * inspector/InspectorResource.cpp:
3328         (WebCore::InspectorResource::endTiming):
3329
3330 2010-09-16  Ilya Tikhonovsky  <loislo@chromium.org>
3331
3332         Reviewed by Yury Semikhatsky.
3333
3334         Web Inspector: move resourceTracking flag under control of BackendSettings.
3335
3336         Four Inspector API methods about resourceTracking flag were removed.
3337         Actual state of the flag is transfered as the response of setResourceTracking request.
3338         Initial state of the flag on the frontend side is obtained from settings.backend.
3339
3340         https://bugs.webkit.org/show_bug.cgi?id=45887
3341
3342         * inspector/Inspector.idl:
3343         * inspector/InspectorController.cpp:
3344         (WebCore::InspectorController::getBackendSettings):
3345         (WebCore::InspectorController::populateScriptObjects):
3346         (WebCore::InspectorController::setResourceTracking):
3347         * inspector/InspectorController.h:
3348         * inspector/front-end/ResourcesPanel.js:
3349         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
3350         * inspector/front-end/Settings.js:
3351         (WebInspector.Settings.initialize.populateBackendSettings):
3352         (WebInspector.Settings.initialize):
3353         * inspector/front-end/inspector.js:
3354
3355 2010-09-16  Jian Li  <jianli@chromium.org>
3356
3357         Reviewed by David Levin.
3358
3359         BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
3360         https://bugs.webkit.org/show_bug.cgi?id=45909
3361
3362         * fileapi/ThreadableBlobRegistry.cpp:
3363         (WebCore::BlobRegistryContext::BlobRegistryContext):
3364
3365 2010-09-16  Daniel Cheng  <dcheng@chromium.org>
3366
3367         Reviewed by Simon Fraser.
3368
3369         [chromium] Fix incorrect drag node/selection painting.
3370         https://bugs.webkit.org/show_bug.cgi?id=45573
3371
3372         Drag selections were being incorrectly clipped when dragging a selection
3373         near the bottom of a page that was taller than the viewport. To fix
3374         this, we use paintContents() instead of paint().
3375
3376         * page/chromium/FrameChromium.cpp:
3377         (WebCore::Frame::nodeImage):
3378         (WebCore::Frame::dragImageForSelection):
3379
3380 2010-09-16  Daniel Cheng  <dcheng@chromium.org>
3381
3382         Reviewed by Tony Chang.
3383
3384         Fix incorrect usage of dissolveDragImageToFraction().
3385         https://bugs.webkit.org/show_bug.cgi?id=45835
3386
3387         createDragImageForSelection() was ignoring the return value of
3388         dissolveDragImageToFraction(). This didn't happen to crash on most
3389         platforms, since most implementations simply modified the image that was
3390         passed in. However, Chromium Mac's implementation actually creates a new
3391         image and returns that instead. This caused us to crash when copying the
3392         image from the renderer to the browser process, since the memory had
3393         already been freed.
3394
3395         * manual-tests/selection-drag-crash.html: Added.
3396         * platform/DragImage.cpp:
3397         (WebCore::createDragImageForSelection):
3398
3399 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3400
3401         Unreviewed, rolling out r67628.
3402         http://trac.webkit.org/changeset/67628
3403         https://bugs.webkit.org/show_bug.cgi?id=45904
3404
3405         broke the build (Requested by eric_carlson on #webkit).
3406
3407         * page/ContextMenuController.cpp:
3408         (WebCore::ContextMenuController::contextMenuItemSelected):
3409         * platform/ContextMenu.cpp:
3410         (WebCore::ContextMenu::populate):
3411         (WebCore::ContextMenu::checkOrEnableIfNeeded):
3412         * platform/ContextMenuItem.h:
3413         * platform/LocalizationStrategy.h:
3414         * platform/LocalizedStrings.cpp:
3415         * platform/LocalizedStrings.h:
3416         * platform/android/LocalizedStringsAndroid.cpp:
3417         * platform/brew/LocalizedStringsBrew.cpp:
3418         * platform/efl/LocalizedStringsEfl.cpp:
3419         * platform/gtk/ContextMenuItemGtk.cpp:
3420         (WebCore::gtkStockIDFromContextMenuAction):
3421         * platform/gtk/LocalizedStringsGtk.cpp:
3422         * platform/haiku/LocalizedStringsHaiku.cpp:
3423         * platform/wx/LocalizedStringsWx.cpp:
3424         * rendering/HitTestResult.cpp:
3425         (WebCore::HitTestResult::absoluteMediaURL):
3426         * rendering/HitTestResult.h:
3427
3428 2010-09-16  Andreas Kling  <andreas.kling@nokia.com>
3429
3430         Reviewed by Simon Fraser.
3431
3432         CSS: Fix crash in getTimingFunctionValue()
3433         https://bugs.webkit.org/show_bug.cgi?id=45896
3434
3435         Use a RefPtr to avoid deleting the TimingFunction prematurely.
3436
3437         This is covered by existing tests, e.g transitions/inherit-other-props.html
3438         but will only actually crash on picky platforms (or in valgrind.)
3439
3440         * css/CSSComputedStyleDeclaration.cpp:
3441         (WebCore::getTimingFunctionValue):
3442
3443 2010-09-16  Pavel Feldman  <pfeldman@chromium.org>
3444
3445         Reviewed by Yury Semikhatsky.
3446
3447         Web Inspector: prevent resource timing popover from having scrollers.
3448         https://bugs.webkit.org/show_bug.cgi?id=45883
3449
3450         * inspector/front-end/ResourcesPanel.js:
3451         (WebInspector.ResourcesPanel.prototype._showPopover):
3452
3453 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3454
3455         Reviewed by Eric Carlson.
3456
3457         [GTK] enhanced context menu for media elements
3458         https://bugs.webkit.org/show_bug.cgi?id=45021
3459
3460         New items in the media Element context menu:
3461         - play/pause
3462         - mute/unmute
3463         - controls display control
3464         - switch to fullscreen (for video only)
3465         - loop playback control
3466         - copy media url to clipboard
3467         - open in new window
3468
3469         Test: media/context-menu-actions.html
3470
3471         * page/ContextMenuController.cpp:
3472         (WebCore::ContextMenuController::contextMenuItemSelected):
3473         * platform/ContextMenu.cpp:
3474         (WebCore::ContextMenu::populate):
3475         (WebCore::ContextMenu::checkOrEnableIfNeeded):
3476         * platform/ContextMenuItem.h:
3477         * platform/LocalizationStrategy.h:
3478         * platform/LocalizedStrings.cpp:
3479         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3480         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3481         (WebCore::contextMenuItemTagToggleMediaControls):
3482         (WebCore::contextMenuItemTagToggleMediaLoop):
3483         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3484         (WebCore::contextMenuItemTagMediaPlay):
3485         (WebCore::contextMenuItemTagMediaPause):
3486         (WebCore::contextMenuItemTagMediaMute):
3487         (WebCore::contextMenuItemTagMediaUnMute):
3488         * platform/LocalizedStrings.h:
3489         * platform/android/LocalizedStringsAndroid.cpp:
3490         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3491         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3492         (WebCore::contextMenuItemTagToggleMediaControls):
3493         (WebCore::contextMenuItemTagToggleMediaLoop):
3494         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3495         (WebCore::contextMenuItemTagMediaPlay):
3496         (WebCore::contextMenuItemTagMediaPause):
3497         (WebCore::contextMenuItemTagMediaMute):
3498         (WebCore::contextMenuItemTagMediaUnMute):
3499         * platform/brew/LocalizedStringsBrew.cpp:
3500         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3501         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3502         (WebCore::contextMenuItemTagToggleMediaControls):
3503         (WebCore::contextMenuItemTagToggleMediaLoop):
3504         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3505         (WebCore::contextMenuItemTagMediaPlay):
3506         (WebCore::contextMenuItemTagMediaPause):
3507         (WebCore::contextMenuItemTagMediaMute):
3508         (WebCore::contextMenuItemTagMediaUnMute):
3509         * platform/efl/LocalizedStringsEfl.cpp:
3510         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3511         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3512         (WebCore::contextMenuItemTagToggleMediaControls):
3513         (WebCore::contextMenuItemTagToggleMediaLoop):
3514         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3515         (WebCore::contextMenuItemTagMediaPlay):
3516         (WebCore::contextMenuItemTagMediaPause):
3517         (WebCore::contextMenuItemTagMediaMute):
3518         (WebCore::contextMenuItemTagMediaUnMute):
3519         * platform/gtk/ContextMenuItemGtk.cpp:
3520         (WebCore::gtkStockIDFromContextMenuAction):
3521         * platform/gtk/LocalizedStringsGtk.cpp:
3522         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3523         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3524         (WebCore::contextMenuItemTagToggleMediaControls):
3525         (WebCore::contextMenuItemTagToggleMediaLoop):
3526         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3527         (WebCore::contextMenuItemTagMediaPlay):
3528         (WebCore::contextMenuItemTagMediaPause):
3529         (WebCore::contextMenuItemTagMediaMute):
3530         (WebCore::contextMenuItemTagMediaUnMute):
3531         * platform/haiku/LocalizedStringsHaiku.cpp:
3532         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3533         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3534         (WebCore::contextMenuItemTagToggleMediaControls):
3535         (WebCore::contextMenuItemTagToggleMediaLoop):
3536         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3537         (WebCore::contextMenuItemTagMediaPlay):
3538         (WebCore::contextMenuItemTagMediaPause):
3539         (WebCore::contextMenuItemTagMediaMute):
3540         (WebCore::contextMenuItemTagMediaUnMute):
3541         * platform/wx/LocalizedStringsWx.cpp:
3542         (WebCore::contextMenuItemTagOpenMediaInNewWindow):
3543         (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
3544         (WebCore::contextMenuItemTagToggleMediaControls):
3545         (WebCore::contextMenuItemTagToggleMediaLoop):
3546         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3547         (WebCore::contextMenuItemTagMediaPlay):
3548         (WebCore::contextMenuItemTagMediaPause):
3549         (WebCore::contextMenuItemTagMediaMute):
3550         (WebCore::contextMenuItemTagMediaUnMute):
3551         * rendering/HitTestResult.cpp:
3552         (WebCore::HitTestResult::absoluteMediaURL):
3553         (WebCore::HitTestResult::mediaSupportsFullscreen):
3554         (WebCore::HitTestResult::mediaElement):
3555         (WebCore::HitTestResult::toggleMediaControlsDisplay):