12c398464582118e23608f172c6893f89ea1b9fd
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-31  Mitz Pettel  <mitz@webkit.org>
2
3         Reviewed by Maciej.
4
5         - fix image dragging
6
7         This is covered by editing/selection/drag-to-contenteditable-iframe.html
8
9         * rendering/HitTestResult.cpp:
10         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
11         HTML IMG elements.
12         (WebCore::HitTestResult::absoluteImageURL): Ditto.
13
14 2006-10-31  Beth Dakin  <bdakin@apple.com>
15
16         Reviewed by Maciej.
17
18         This adds the back-end of the remaining WebElementDictionary 
19         functions into HitTestResult.
20
21         * WebCore.exp:
22         * rendering/HitTestResult.cpp:
23         (WebCore::HitTestResult::title):
24         (WebCore::displayString): This is nearly identical to the 
25         displayString() defined in DOMInternal.mm except that it returns a 
26         String instead of an NSString. The old code path used the 
27         DOMInternal method, so I made a new one here for the new code path.
28         (WebCore::HitTestResult::altDisplayString):
29         (WebCore::HitTestResult::image):
30         (WebCore::HitTestResult::absoluteImageURL):
31         (WebCore::HitTestResult::absoluteLinkURL):
32         (WebCore::HitTestResult::titleDisplayString):
33         (WebCore::HitTestResult::textContent):
34         * rendering/HitTestResult.h:
35
36 2006-10-31  John Sullivan  <sullivan@apple.com>
37
38         * bridge/mac/FrameMac.mm:
39         (WebCore::FrameMac::markMisspellings):
40         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
41
42 2006-10-31  John Sullivan  <sullivan@apple.com>
43
44         Reviewed by Maciej
45         
46         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
47         
48         The foundation of this was in my last checkin. This checkin is all about displaying
49         the correct string in the toolTip.
50
51         * dom/DocumentMarker.h:
52         New description field in this struct.
53
54         * bridge/mac/FrameMac.mm:
55         (WebCore::FrameMac::advanceToNextMisspelling):
56         When adding a grammar marker, supply the appropriate description. Also, added a comment
57         about the remaining work to make grammar checking return sensible answers.
58         (WebCore::FrameMac::markMisspellings):
59         ditto (yes, still needs some refactoring to minimize duplicated code)
60         
61         * dom/Document.h:
62         * dom/Document.cpp:
63         (WebCore::Document::addMarker):
64         Now takes an optional description string
65         (WebCore::Document::markerContainingPoint):
66         New function, returns a pointer to the (first) marker of the specified type whose rect 
67         contains the specified point, or 0 if none.
68         
69         * rendering/HitTestResult.cpp:
70         (WebCore::HitTestResult::spellingToolTip):
71         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
72         and gets the description from the marker.
73
74 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
75
76         Reviewed by Maciej.
77         
78         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
79
80         * loader/mac/FrameLoaderMac.mm:
81         (WebCore::FrameLoader::createWindow):
82         * manual-tests/window-open-features-parsing.html: Updated for clarity.
83
84 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
85
86         Reviewed by Alice.
87
88         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
89         to WebCore::Editor.
90         
91         Layout tests pass.
92         
93         Renamed "may*" to "can*" because "can" is more accurate (these functions
94         aren't just about permission) and it matches WebKit.
95
96         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
97         password field. Now that WebCore fully implements canCopy(), it doesn't just
98         mean "the selection is not in a password field" anymore.
99         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
100         The fact that it's not called anymore may represent a security issue, but I
101         don't see how commented-out code will help reveal the issue, and the
102         bridge is going away, anyway.
103         * editing/SelectionController.h: Changed selection() calls to references
104         to m_sel, to match the rest of the file.
105
106 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
107
108         Reviewed by harrison
109         
110         <rdar://problem/4711063>
111         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
112
113         * editing/ReplaceSelectionCommand.cpp:
114         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
115         insertion and plain text string creation unless we need the string
116         for a BeforeTextInserted event handler or for a plain text only region.
117         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
118         code here from ReplacementFragment's constructor.
119         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
120         FIXME.
121         * editing/ReplaceSelectionCommand.h:
122
123 2006-10-31  Ada Chan  <adachan@apple.com>
124
125         Reviewed by Adam
126
127         Correct forward declarations of the HitTestRequest struct.
128
129         * rendering/EllipsisBox.h:
130         * rendering/InlineBox.h:
131         * rendering/InlineFlowBox.h:
132         * rendering/RenderLayer.h:
133         * rendering/RenderObject.h:
134
135 2006-10-31  John Sullivan  <sullivan@apple.com>
136
137         Reviewed by Beth and Adam
138
139         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
140         next I'll make it use a string that's relevant for a specific grammar error.
141
142         * WebCore.exp:
143         export symbol for spellingToolTip function
144         
145         * rendering/HitTestResult.h:
146         * rendering/HitTestResult.cpp:
147         (WebCore::HitTestResult::spellingToolTip):
148         new function, returns the string to be used in a tool tip that describes the questionable grammar
149         
150         * rendering/InlineTextBox.h:
151         * rendering/InlineTextBox.cpp:
152         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
153         now takes a style and font, needed to compute the rect representing the range containing
154         questionable grammar. Computes the rect and associates it with the marker.
155         (WebCore::InlineTextBox::paintDocumentMarkers):
156         Pass in the style and font now needed by paintSpellingOrGrammarMarker
157
158 2006-10-31  Adele Peterson  <adele@apple.com>
159
160         Removed commented out variable from last checkin.
161
162         * html/HTMLSelectElement.cpp:
163         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
164
165 2006-10-31  Brady Eidson  <beidson@apple.com>
166
167         Build fix (unused variable in release builds)
168
169         * html/HTMLSelectElement.cpp:
170         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
171
172 2006-10-31  Adele Peterson  <adele@apple.com>
173
174         Reviewed by Adam.
175
176         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
177         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
178         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
179
180         Tests: 
181         * LayoutTests/fast/forms/listbox-selection.html
182         * LayoutTests/fast/forms/listbox-onchange.html
183
184         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
185           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
186           And one for onChange, that is updated after onChange is fired.
187           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
188  
189         * html/HTMLSelectElement.cpp:
190         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
191         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
192         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
193         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
194         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
195         (WebCore::HTMLSelectElement::setExtent): Added.
196         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
197         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
198
199         * rendering/RenderListBox.cpp:
200         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
201         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
202         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
203         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
204          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
205          notify the select element from here.
206         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
207         (WebCore::RenderListBox::listIndexIsVisible): Added.
208         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
209
210         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
211         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
212         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
213         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
214         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
215
216 2006-10-31  Beth Dakin  <bdakin@apple.com>
217
218         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
219
220         * rendering/HitTestRequest.h: Added.
221         (WebCore::HitTestRequest::HitTestRequest):
222
223 2006-10-31  Beth Dakin  <bdakin@apple.com>
224
225         Reviewed by Maciej.
226
227         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
228         should be split into HitTestRequest and HitTestResult
229
230         This patch creates a new struct called HitTestRequest that holds 
231         the three boolean values (readonly, active, and mouseMove) that 
232         were formerly a part of HitTestResult. All hitTest() and 
233         nodeAtPoint() functions now take a HitTestRequest in addition to 
234         the HitTestResult.
235
236         * WebCore.exp:
237         * WebCore.xcodeproj/project.pbxproj:
238         * bridge/mac/FrameMac.mm:
239         (WebCore::FrameMac::eventMayStartDrag):
240         (WebCore::FrameMac::handleMouseMoveEvent):
241         * bridge/mac/WebCoreAXObject.mm:
242         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
243         (-[WebCoreAXObject accessibilityHitTest:]):
244         * dom/Document.cpp:
245         (WebCore::Document::elementFromPoint):
246         (WebCore::Document::prepareMouseEvent):
247         * editing/SelectionController.cpp:
248         (WebCore::SelectionController::contains):
249         * page/Frame.cpp:
250         (WebCore::Frame::hitTestResultAtPoint):
251         * page/FrameView.cpp:
252         (WebCore::FrameView::handleWheelEvent):
253         * rendering/EllipsisBox.cpp:
254         (WebCore::EllipsisBox::nodeAtPoint):
255         * rendering/EllipsisBox.h:
256         * rendering/HitTestResult.cpp:
257         (WebCore::HitTestResult::HitTestResult):
258         (WebCore::HitTestResult::operator=):
259         * rendering/HitTestResult.h:
260         * rendering/InlineBox.cpp:
261         (WebCore::InlineBox::nodeAtPoint):
262         * rendering/InlineBox.h:
263         * rendering/InlineFlowBox.cpp:
264         (WebCore::InlineFlowBox::nodeAtPoint):
265         * rendering/InlineFlowBox.h:
266         * rendering/InlineTextBox.cpp:
267         (WebCore::InlineTextBox::nodeAtPoint):
268         * rendering/InlineTextBox.h:
269         * rendering/RenderBlock.cpp:
270         (WebCore::RenderBlock::nodeAtPoint):
271         * rendering/RenderBlock.h:
272         * rendering/RenderBox.cpp:
273         (WebCore::RenderBox::nodeAtPoint):
274         * rendering/RenderBox.h:
275         * rendering/RenderFlow.cpp:
276         (WebCore::RenderFlow::hitTestLines):
277         * rendering/RenderFlow.h:
278         * rendering/RenderForeignObject.cpp:
279         (WebCore::RenderForeignObject::nodeAtPoint):
280         * rendering/RenderForeignObject.h:
281         * rendering/RenderFrameSet.cpp:
282         (WebCore::RenderFrameSet::nodeAtPoint):
283         * rendering/RenderFrameSet.h:
284         * rendering/RenderImage.cpp:
285         (WebCore::RenderImage::nodeAtPoint):
286         * rendering/RenderImage.h:
287         * rendering/RenderInline.cpp:
288         (WebCore::RenderInline::nodeAtPoint):
289         * rendering/RenderInline.h:
290         * rendering/RenderLayer.cpp:
291         (WebCore::RenderLayer::autoscroll):
292         (WebCore::RenderLayer::hitTest):
293         (WebCore::RenderLayer::hitTestLayer):
294         (WebCore::RenderLayer::updateHoverActiveState):
295         * rendering/RenderLayer.h:
296         * rendering/RenderObject.cpp:
297         (WebCore::RenderObject::hitTest):
298         (WebCore::RenderObject::nodeAtPoint):
299         * rendering/RenderObject.h:
300         * rendering/RenderPath.cpp:
301         (WebCore::RenderPath::nodeAtPoint):
302         * rendering/RenderPath.h:
303         * rendering/RenderSVGImage.cpp:
304         (WebCore::RenderSVGImage::nodeAtPoint):
305         * rendering/RenderSVGImage.h:
306         * rendering/RenderSVGText.cpp:
307         (WebCore::RenderSVGText::nodeAtPoint):
308         * rendering/RenderSVGText.h:
309         * rendering/RenderTableRow.cpp:
310         (WebCore::RenderTableRow::nodeAtPoint):
311         * rendering/RenderTableRow.h:
312         * rendering/RenderTableSection.cpp:
313         (WebCore::RenderTableSection::nodeAtPoint):
314         * rendering/RenderTableSection.h:
315         * rendering/RenderText.h:
316         (WebCore::RenderText::nodeAtPoint):
317         * rendering/RenderTextControl.cpp:
318         (WebCore::RenderTextControl::nodeAtPoint):
319         * rendering/RenderTextControl.h:
320         * rendering/RootInlineBox.cpp:
321         (WebCore::RootInlineBox::nodeAtPoint):
322         * rendering/RootInlineBox.h:
323
324 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
325
326         Reviewed by Maciej.
327
328         Bug 11442: [CSS 3] support for cursor: all-scroll
329         http://bugs.webkit.org/show_bug.cgi?id=11442
330
331         * css/CSSComputedStyleDeclaration.cpp:
332         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
333         * css/CSSValueKeywords.in:
334         * css/cssparser.cpp:
335         (WebCore::CSSParser::parseValue):
336         * page/FrameView.cpp:
337         (WebCore::selectCursor):
338         * rendering/RenderStyle.h:
339
340 2006-10-31  Oliver Hunt  <oliver@apple.com>
341
342         Reviewed by Geoff.
343
344         Converting Obj-C++ to C++ in kcanvas
345
346         * WebCore.xcodeproj/project.pbxproj:
347         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
348         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
349         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
350         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
351         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
352         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
353         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
354         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
355         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
356         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
357         * kcanvas/device/quartz/QuartzSupport.h:
358         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
359         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
360         (WebCore::SVGResourceClipper::applyClip):
361         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
362         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
363         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
364
365 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
366
367         Reviewed by harrison
368         
369         <rdar://problem/4808375>
370         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
371         
372         Completely back out r17276 because of performance issues.
373
374         * editing/TextIterator.cpp:
375         (WebCore::TextIterator::TextIterator):
376         (WebCore::TextIterator::advance):
377         (WebCore::TextIterator::handleTextNode):
378         (WebCore::TextIterator::handleTextBox):
379         (WebCore::TextIterator::handleReplacedElement):
380         (WebCore::TextIterator::handleNonTextNode):
381         (WebCore::TextIterator::exitNode):
382         (WebCore::TextIterator::emitCharacter):
383         (WebCore::TextIterator::range):
384         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
385         (WebCore::SimplifiedBackwardsTextIterator::advance):
386         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
387         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
388         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
389         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
390         (WebCore::SimplifiedBackwardsTextIterator::range):
391         (WebCore::CharacterIterator::range):
392         (WebCore::TextIterator::rangeFromLocationAndLength):
393         * editing/TextIterator.h:
394         (WebCore::TextIterator::atEnd):
395         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
396
397 2006-10-31  Darin Adler  <darin@apple.com>
398
399         Reviewed by Brady.
400
401         - got "action dictionary" code out of FrameLoader,
402           replacing with a class called NavigationAction
403
404         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
405         * loader/mac/DocumentLoaderMac.mm:
406         (WebCore::DocumentLoader::triggeringAction): Ditto.
407         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
408
409         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
410
411         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
412         Removed elementForEvent.
413         * loader/mac/FrameLoaderMac.mm:
414         (WebCore::FrameLoader::load): Ditto.
415         (WebCore::FrameLoader::reload): Ditto.
416         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
417         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
418         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
419         (WebCore::FrameLoader::post): Ditto.
420
421         * loader/NavigationAction.h: Added.
422         * loader/NavigationAction.cpp: Added.
423         * loader/mac/NavigationActionMac.mm: Added.
424
425         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
426
427         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
428         * WebCore.exp: Updated.
429
430 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
431
432         Reviewed by Adam.
433
434         Build fix
435
436         * platform/win/CookieJarWin.cpp:
437         (WebCore::cookies):
438
439 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
440
441         Reviewed by Maciej. Landed by Adam.
442
443         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
444
445         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
446         as dicussed with Dave. Also kill the outdated DESIGN document.
447
448         * CMakeLists.txt:
449         * WebCore.xcodeproj/project.pbxproj:
450         * kcanvas/DESIGN: Removed.
451         * kcanvas/KCanvasFilters.cpp:
452         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
453         * kcanvas/KCanvasTreeDebug.h: Ditto.
454         * kcanvas/device/KRenderingPaintServerGradient.cpp:
455         * kcanvas/device/KRenderingPaintServerPattern.cpp:
456         * kcanvas/device/KRenderingPaintServerSolid.cpp:
457         * platform/graphics/svg/SVGResourceClipper.cpp:
458         * rendering/RenderTreeAsText.cpp:
459         * rendering/SVGRenderTreeAsText.cpp: Added.
460         * rendering/SVGRenderTreeAsText.h: Added.
461         (WebCore::operator<<):
462
463 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
464
465         Reviewed by Maciej.
466
467         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
468         Includes some CRLF -> LF fixups.
469
470         * platform/win/CookieJarWin.cpp:
471         (WebCore::cookies):
472
473 2006-10-31  Adam Roben  <aroben@apple.com>
474
475         Reviewed by Steve.
476
477         Fix some incorrect forward declarations.
478
479         * loader/FrameLoader.h:
480         * page/Frame.h:
481
482 2006-10-31  Darin Adler  <darin@apple.com>
483
484         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
485         try to fix the build on the buildbot.
486
487 2006-10-31  Darin Adler  <darin@apple.com>
488
489         * bridge/mac/FrameMac.mm:
490         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
491         (WebCore::FrameMac::markMisspellings): Ditto.
492
493 2006-10-31  John Sullivan  <sullivan@apple.com>
494
495         * bridge/mac/FrameMac.mm:
496         (WebCore::FrameMac::advanceToNextMisspelling):
497         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
498
499 2006-10-30  John Sullivan  <sullivan@apple.com>
500
501         Reviewed by Adam Roben
502         
503         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
504         
505         This patch introduces much of the guts of grammar checking, though still not enough to actually
506         check grammar sensibly, due to:
507           
508         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
509         context passed to grammar checker
510
511         * platform/Logging.h:
512         * platform/Logging.cpp:
513         new log channel SpellingAndGrammar
514
515         * bridge/mac/WebCorePageBridge.mm:
516         (initializeLoggingChannelsIfNecessary):
517         initialize new log channel
518
519         * bridge/mac/FrameMac.mm:
520         (WebCore::FrameMac::advanceToNextMisspelling):
521         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
522         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
523         in the event of a tie), and do further processing with that one (select range; create marker that
524         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
525         (WebCore::FrameMac::markMisspellings):
526         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
527         differently enough to make sharing code between these two functions a little tricky, so I decided to 
528         save that for a later patch.
529         
530         (WebCore::FrameMac::respondToChangedSelection):
531         remove grammar markers when we remove spelling markers        
532
533 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
534
535         Reviewed by Mitz.
536
537         Fix Qt/Linux build with older gcc3.3.4.
538
539         * bindings/js/kjs_window.cpp:
540         (KJS::WindowFunc::callAsFunction):
541
542 2006-10-31  Zack Rusin  <zack@kde.org>
543
544         Reviewed by Mitz.
545
546         Fix the Qt build after last nights changes.
547
548         * WebCore/platform/qt/FrameQt.cpp:
549         * WebCore/platform/qt/EditorClientQt.h:
550         * WebCore/platform/qt/EditorClientQt.cpp:
551         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
552         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
553         * WebCore/CMakeLists.txt:
554         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
555         * WebKitQt/QtLauncher/CMakeLists.txt:
556         * WebKitQt/WebKitPart/CMakeLists.txt:
557
558 2006-10-30  Darin Adler  <darin@apple.com>
559
560         Reviewed by Anders.
561
562         - remove BrowserExtension
563
564         * WebCore.vcproj/WebCore/WebCore.vcproj:
565         * WebCore.xcodeproj/project.pbxproj:
566         * bindings/js/kjs_window.cpp:
567         (KJS::createNewWindow):
568         (KJS::WindowFunc::callAsFunction):
569         * bridge/BrowserExtension.h: Removed.
570         * bridge/mac/BrowserExtensionMac.h: Removed.
571         * bridge/mac/BrowserExtensionMac.mm: Removed.
572         * bridge/mac/FrameMac.mm:
573         (WebCore::FrameMac::FrameMac):
574         (WebCore::FrameMac::submitForm):
575         (WebCore::FrameMac::urlSelected):
576         * bridge/win/BrowserExtensionWin.cpp: Removed.
577         * bridge/win/BrowserExtensionWin.h: Removed.
578         * bridge/win/FrameWin.cpp:
579         (WebCore::FrameWin::FrameWin):
580         * loader/FrameLoader.cpp:
581         (WebCore::FrameLoader::createWindow):
582         * loader/FrameLoader.h:
583         * loader/icon/IconLoader.cpp:
584         * loader/mac/FrameLoaderMac.mm:
585         (WebCore::FrameLoader::safeLoad):
586         (WebCore::FrameLoader::load):
587         (WebCore::FrameLoader::createWindow):
588         * page/Frame.cpp:
589         (WebCore::Frame::urlSelected):
590         (WebCore::Frame::requestFrame):
591         (WebCore::Frame::submitForm):
592         (WebCore::Frame::scheduleHistoryNavigation):
593         (WebCore::Frame::redirectionTimerFired):
594         * page/Frame.h:
595         * page/FrameLoadRequest.h:
596         (WebCore::FrameLoadRequest::FrameLoadRequest):
597         (WebCore::FrameLoadRequest::isEmpty):
598         (WebCore::FrameLoadRequest::resourceRequest):
599         (WebCore::FrameLoadRequest::frameName):
600         (WebCore::FrameLoadRequest::setFrameName):
601         * page/FramePrivate.h:
602         (WebCore::FramePrivate::FramePrivate):
603         (WebCore::FramePrivate::~FramePrivate):
604         * platform/gdk/BrowserExtensionGdk.h: Removed.
605         * platform/gdk/FrameGdk.cpp:
606         (WebCore::FrameGdk::FrameGdk):
607         * platform/gdk/TemporaryLinkStubs.cpp:
608         * platform/network/ResourceRequest.h:
609         (WebCore::ResourceRequest::isEmpty):
610
611 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
612
613         Reviewed by Oliver.
614
615         Modified from original due to earlier reversion
616
617         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
618
619         Better SVG integration in WebKit, Part I.
620
621         The patch is mostly about creating a new platform/graphics directory, and
622         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
623         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
624         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
625
626         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
627         All details of the patch, and upcoming patches can be found in the bug report.
628
629         * CMakeLists.txt:
630         * WebCore.xcodeproj/project.pbxproj:
631         * graphics/svg/SVGResource.cpp: Removed.
632         * graphics/svg/SVGResourceClipper.cpp: Removed.
633         * graphics/svg/SVGResourceClipper.h: Removed.
634         * graphics/svg/SVGResourceImage.h: Removed.
635         * graphics/svg/SVGResourceListener.h: Removed.
636         * graphics/svg/SVGResourceMarker.cpp: Removed.
637         * graphics/svg/SVGResourceMarker.h: Removed.
638         * graphics/svg/SVGResourceMasker.cpp: Removed.
639         * graphics/svg/SVGResourceMasker.h: Removed.
640         * kcanvas/KCanvasClipper.cpp: Removed.
641         * kcanvas/KCanvasClipper.h: Removed.
642         * kcanvas/KCanvasCreator.cpp: Removed.
643         * kcanvas/KCanvasCreator.h: Removed.
644         * kcanvas/KCanvasFilters.cpp:
645         (WebCore::getFilterById):
646         * kcanvas/KCanvasFilters.h:
647         * kcanvas/KCanvasImage.h: Removed.
648         * kcanvas/KCanvasMarker.cpp: Removed.
649         * kcanvas/KCanvasMarker.h: Removed.
650         * kcanvas/KCanvasMasker.cpp: Removed.
651         * kcanvas/KCanvasMasker.h: Removed.
652         * kcanvas/KCanvasResource.cpp: Removed.
653         * kcanvas/KCanvasResource.h: Removed.
654         * kcanvas/KCanvasResourceListener.h: Removed.
655         * kcanvas/KCanvasTreeDebug.cpp:
656         (WebCore::writeRenderResources):
657         * kcanvas/device/KRenderingDevice.h:
658         * kcanvas/device/KRenderingPaintServer.h:
659         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
660         * kcanvas/device/KRenderingPaintServerGradient.cpp:
661         (WebCore::KRenderingPaintServerGradient::listener):
662         (WebCore::KRenderingPaintServerGradient::setListener):
663         * kcanvas/device/KRenderingPaintServerGradient.h:
664         * kcanvas/device/KRenderingPaintServerPattern.cpp:
665         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
666         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
667         (WebCore::KRenderingPaintServerPattern::tile):
668         (WebCore::KRenderingPaintServerPattern::setTile):
669         (WebCore::KRenderingPaintServerPattern::listener):
670         (WebCore::KRenderingPaintServerPattern::setListener):
671         * kcanvas/device/KRenderingPaintServerPattern.h:
672         * kcanvas/device/KRenderingPaintServerSolid.h:
673         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
674         * kcanvas/device/qt/KCanvasClipperQt.h:
675         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
676         (WebCore::KRenderingDeviceQt::contextForImage):
677         (WebCore::KRenderingDeviceQt::createResource):
678         (WebCore::KRenderingDeviceQt::createPaintServer):
679         * kcanvas/device/qt/KRenderingDeviceQt.h:
680         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
681         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
682         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
683         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
684         * kcanvas/device/qt/RenderPathQt.h: Removed.
685         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
686         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
687         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
688         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
689         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
690         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
691         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
692         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
693         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
694         (WebCore::KRenderingDeviceQuartz::contextForImage):
695         (WebCore::KRenderingDeviceQuartz::createPaintServer):
696         (WebCore::KRenderingDeviceQuartz::createResource):
697         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
698         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
699         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
700         (WebCore::KRenderingPaintServerGradientQuartz::setup):
701         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
702         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
703         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
704         (WebCore::patternCallback):
705         (WebCore::KRenderingPaintServerPatternQuartz::setup):
706         * kcanvas/device/quartz/QuartzSupport.mm:
707         * ksvg2/misc/KCanvasRenderingStyle.cpp:
708         (WebCore::sharedSolidPaintServer):
709         * ksvg2/svg/SVGClipPathElement.cpp:
710         (WebCore::SVGClipPathElement::SVGClipPathElement):
711         (WebCore::SVGClipPathElement::~SVGClipPathElement):
712         (WebCore::SVGClipPathElement::canvasResource):
713         * ksvg2/svg/SVGClipPathElement.h:
714         * ksvg2/svg/SVGFEImageElement.cpp:
715         * ksvg2/svg/SVGFilterElement.cpp:
716         (WebCore::SVGFilterElement::SVGFilterElement):
717         (WebCore::SVGFilterElement::~SVGFilterElement):
718         (WebCore::SVGFilterElement::canvasResource):
719         * ksvg2/svg/SVGFilterElement.h:
720         * ksvg2/svg/SVGGradientElement.cpp:
721         (WebCore::SVGGradientElement::SVGGradientElement):
722         (WebCore::SVGGradientElement::~SVGGradientElement):
723         (WebCore::SVGGradientElement::canvasResource):
724         (WebCore::SVGGradientElement::resourceNotification):
725         * ksvg2/svg/SVGGradientElement.h:
726         * ksvg2/svg/SVGImageElement.cpp:
727         * ksvg2/svg/SVGLinearGradientElement.cpp:
728         (WebCore::SVGLinearGradientElement::buildGradient):
729         * ksvg2/svg/SVGLinearGradientElement.h:
730         * ksvg2/svg/SVGMarkerElement.cpp:
731         (WebCore::SVGMarkerElement::SVGMarkerElement):
732         (WebCore::SVGMarkerElement::~SVGMarkerElement):
733         (WebCore::SVGMarkerElement::canvasResource):
734         * ksvg2/svg/SVGMarkerElement.h:
735         * ksvg2/svg/SVGMaskElement.cpp:
736         (WebCore::SVGMaskElement::SVGMaskElement):
737         (WebCore::SVGMaskElement::~SVGMaskElement):
738         (WebCore::SVGMaskElement::drawMaskerContent):
739         (WebCore::SVGMaskElement::canvasResource):
740         * ksvg2/svg/SVGMaskElement.h:
741         * ksvg2/svg/SVGPatternElement.cpp:
742         (WebCore::SVGPatternElement::SVGPatternElement):
743         (WebCore::SVGPatternElement::~SVGPatternElement):
744         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
745         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
746         (WebCore::SVGPatternElement::canvasResource):
747         * ksvg2/svg/SVGPatternElement.h:
748         * ksvg2/svg/SVGRadialGradientElement.cpp:
749         (WebCore::SVGRadialGradientElement::buildGradient):
750         * ksvg2/svg/SVGRadialGradientElement.h:
751         * ksvg2/svg/SVGStyledElement.h:
752         (WebCore::SVGStyledElement::canvasResource):
753         * platform/GraphicsContext.cpp: Removed.
754         * platform/GraphicsContext.h: Removed.
755         * platform/GraphicsTypes.cpp: Removed.
756         * platform/GraphicsTypes.h: Removed.
757         * platform/graphics/GraphicsContext.cpp:
758         (WebCore::GraphicsContextState::GraphicsContextState):
759         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
760         (WebCore::GraphicsContext::createGraphicsContextPrivate):
761         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
762         (WebCore::GraphicsContext::save):
763         (WebCore::GraphicsContext::restore):
764         (WebCore::GraphicsContext::font):
765         (WebCore::GraphicsContext::setFont):
766         (WebCore::GraphicsContext::pen):
767         (WebCore::GraphicsContext::setPen):
768         (WebCore::GraphicsContext::setFillColor):
769         (WebCore::GraphicsContext::fillColor):
770         (WebCore::GraphicsContext::updatingControlTints):
771         (WebCore::GraphicsContext::setUpdatingControlTints):
772         (WebCore::GraphicsContext::setPaintingDisabled):
773         (WebCore::GraphicsContext::paintingDisabled):
774         (WebCore::GraphicsContext::drawImage):
775         (WebCore::GraphicsContext::drawText):
776         (WebCore::GraphicsContext::drawHighlightForText):
777         (WebCore::GraphicsContext::initFocusRing):
778         (WebCore::GraphicsContext::clearFocusRing):
779         (WebCore::GraphicsContext::focusRingBoundingRect):
780         (WebCore::GraphicsContext::addFocusRingRect):
781         (WebCore::GraphicsContext::focusRingWidth):
782         (WebCore::GraphicsContext::focusRingOffset):
783         (WebCore::GraphicsContext::focusRingRects):
784         (WebCore::GraphicsContext::drawTiledImage):
785         * platform/graphics/GraphicsContext.h:
786         * platform/graphics/GraphicsTypes.cpp:
787         (WebCore::):
788         (WebCore::parseCompositeOperator):
789         (WebCore::compositeOperatorName):
790         (WebCore::parseLineCap):
791         (WebCore::lineCapName):
792         (WebCore::parseLineJoin):
793         (WebCore::lineJoinName):
794         * platform/graphics/GraphicsTypes.h:
795         (WebCore::):
796         * platform/graphics/svg/SVGResource.cpp: Added.
797         (WebCore::SVGResource::SVGResource):
798         (WebCore::SVGResource::~SVGResource):
799         (WebCore::SVGResource::invalidate):
800         (WebCore::SVGResource::addClient):
801         (WebCore::SVGResource::clients):
802         (WebCore::SVGResource::idInRegistry):
803         (WebCore::SVGResource::setIdInRegistry):
804         (WebCore::SVGResource::externalRepresentation):
805         (WebCore::getResourceById):
806         (WebCore::getPaintServerById):
807         (WebCore::operator<<):
808         * platform/graphics/svg/SVGResource.h: Added.
809         (WebCore::):
810         (WebCore::SVGResource::isPaintServer):
811         (WebCore::SVGResource::isFilter):
812         (WebCore::SVGResource::isClipper):
813         (WebCore::SVGResource::isMarker):
814         (WebCore::SVGResource::isMasker):
815         (WebCore::SVGResourceListener::~SVGResourceListener):
816         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
817         (WebCore::SVGResourceClipper::SVGResourceClipper):
818         (WebCore::SVGResourceClipper::~SVGResourceClipper):
819         (WebCore::SVGResourceClipper::resetClipData):
820         (WebCore::SVGResourceClipper::addClipData):
821         (WebCore::SVGResourceClipper::clipData):
822         (WebCore::SVGResourceClipper::externalRepresentation):
823         (WebCore::operator<<):
824         (WebCore::getClipperById):
825         * platform/graphics/svg/SVGResourceClipper.h: Added.
826         (WebCore::ClipDataList::addPath):
827         (WebCore::SVGResourceClipper::isClipper):
828         * platform/graphics/svg/SVGResourceImage.h: Added.
829         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
830         (WebCore::SVGResourceMarker::SVGResourceMarker):
831         (WebCore::SVGResourceMarker::~SVGResourceMarker):
832         (WebCore::SVGResourceMarker::setMarker):
833         (WebCore::SVGResourceMarker::setRef):
834         (WebCore::SVGResourceMarker::draw):
835         (WebCore::SVGResourceMarker::externalRepresentation):
836         (WebCore::getMarkerById):
837         * platform/graphics/svg/SVGResourceMarker.h: Added.
838         (WebCore::SVGResourceMarker::refX):
839         (WebCore::SVGResourceMarker::refY):
840         (WebCore::SVGResourceMarker::setAngle):
841         (WebCore::SVGResourceMarker::setAutoAngle):
842         (WebCore::SVGResourceMarker::angle):
843         (WebCore::SVGResourceMarker::setUseStrokeWidth):
844         (WebCore::SVGResourceMarker::useStrokeWidth):
845         (WebCore::SVGResourceMarker::isMarker):
846         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
847         (WebCore::SVGResourceMasker::SVGResourceMasker):
848         (WebCore::SVGResourceMasker::~SVGResourceMasker):
849         (WebCore::SVGResourceMasker::setMask):
850         (WebCore::SVGResourceMasker::mask):
851         (WebCore::SVGResourceMasker::externalRepresentation):
852         (WebCore::getMaskerById):
853         * platform/graphics/svg/SVGResourceMasker.h: Added.
854         (WebCore::SVGResourceMasker::isMasker):
855         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
856         (WebCore::SVGResourceClipper::applyClip):
857         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
858         (WebCore::SVGResourceImage::SVGResourceImage):
859         (WebCore::SVGResourceImage::~SVGResourceImage):
860         (WebCore::SVGResourceImage::init):
861         (WebCore::SVGResourceImage::size):
862         (WebCore::SVGResourceImage::cgLayer):
863         (WebCore::SVGResourceImage::setCGLayer):
864         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
865         (WebCore::applyLuminanceToAlphaFilter):
866         (WebCore::applyExpandAlphatoGrayscaleFilter):
867         (WebCore::transformImageIntoGrayscaleMask):
868         (WebCore::SVGResourceMasker::applyMask):
869         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
870         (WebCore::SVGResourceClipper::applyClip):
871         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
872         (WebCore::SVGResourceImage::init):
873         (WebCore::SVGResourceImage::size):
874         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
875         (WebCore::SVGResourceMasker::applyMask):
876         * platform/qt/GraphicsContextQt.cpp:
877         * rendering/RenderPath.cpp:
878         (WebCore::RenderPath::paint):
879         (WebCore::DrawMarkersData::DrawMarkersData):
880         (WebCore::RenderPath::drawMarkersIfNeeded):
881         * rendering/RenderSVGContainer.cpp:
882         (WebCore::RenderSVGContainer::paint):
883         * rendering/RenderSVGImage.cpp:
884         (WebCore::RenderSVGImage::paint):
885         * rendering/SVGInlineFlowBox.cpp:
886         (WebCore::paintSVGInlineFlow):
887
888 2006-10-30  John Sullivan  <sullivan@apple.com>
889
890         Reviewed by Brady
891         
892         - minor cleanup to make future patches clearer
893
894         * bridge/mac/FrameMac.mm:
895         (WebCore::FrameMac::advanceToNextMisspelling):
896         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
897         with "continue" to better match structure of similar code in markMisspellings; a few
898         other style tweaks.
899         
900         (WebCore::FrameMac::markMisspellings):
901         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
902         a block just after a break and outdented accordingly.
903
904 2006-10-30  John Sullivan  <sullivan@apple.com>
905
906         Reviewed by Geoff Garen
907         
908         WebCore part of change to push the code that updates the spelling panel
909         into WebCore, in preparation for some grammar-checking stuff.
910
911         * bridge/mac/FrameMac.h:
912         * bridge/mac/FrameMac.mm:
913         (WebCore::FrameMac::advanceToNextMisspelling):
914         no more return value for this method, and update the spelling panel with
915         the misspelled word here rather than in the WebKit callers.
916
917 2006-10-30  Oliver Hunt  <oliver@apple.com>
918
919         Reviewed by Anders.
920
921         Roll out last patch
922
923         * CMakeLists.txt:
924         * ChangeLog:
925         * WebCore.xcodeproj/project.pbxproj:
926         * graphics/svg/SVGResource.cpp:
927         * graphics/svg/SVGResourceClipper.cpp:
928         * graphics/svg/SVGResourceClipper.h:
929         * graphics/svg/SVGResourceImage.h:
930         * graphics/svg/SVGResourceListener.h:
931         * graphics/svg/SVGResourceMarker.cpp:
932         * graphics/svg/SVGResourceMarker.h:
933         * graphics/svg/SVGResourceMasker.cpp:
934         * graphics/svg/SVGResourceMasker.h:
935         * kcanvas/KCanvasClipper.cpp: Added.
936         (WebCore::operator<<):
937         (WebCore::KCanvasClipper::KCanvasClipper):
938         (WebCore::KCanvasClipper::~KCanvasClipper):
939         (WebCore::KCanvasClipper::resetClipData):
940         (WebCore::KCanvasClipper::addClipData):
941         (WebCore::KCanvasClipper::clipData):
942         (WebCore::KCanvasClipper::externalRepresentation):
943         (WebCore::getClipperById):
944         * kcanvas/KCanvasClipper.h: Added.
945         (WebCore::KCClipData::windRule):
946         (WebCore::KCClipDataList::KCClipDataList):
947         (WebCore::KCClipDataList::addPath):
948         (WebCore::KCanvasClipper::isClipper):
949         * kcanvas/KCanvasFilters.cpp:
950         (WebCore::getFilterById):
951         * kcanvas/KCanvasFilters.h:
952         * kcanvas/KCanvasImage.h: Added.
953         (WebCore::KCanvasImage::KCanvasImage):
954         (WebCore::KCanvasImage::~KCanvasImage):
955         * kcanvas/KCanvasMarker.cpp: Added.
956         (WebCore::KCanvasMarker::KCanvasMarker):
957         (WebCore::KCanvasMarker::~KCanvasMarker):
958         (WebCore::KCanvasMarker::setMarker):
959         (WebCore::KCanvasMarker::setRef):
960         (WebCore::KCanvasMarker::refX):
961         (WebCore::KCanvasMarker::refY):
962         (WebCore::KCanvasMarker::setAngle):
963         (WebCore::KCanvasMarker::angle):
964         (WebCore::KCanvasMarker::setAutoAngle):
965         (WebCore::KCanvasMarker::setUseStrokeWidth):
966         (WebCore::KCanvasMarker::useStrokeWidth):
967         (WebCore::KCanvasMarker::draw):
968         (WebCore::KCanvasMarker::externalRepresentation):
969         (WebCore::getMarkerById):
970         * kcanvas/KCanvasMarker.h: Added.
971         (WebCore::KCanvasMarker::isMarker):
972         * kcanvas/KCanvasMasker.cpp: Added.
973         (WebCore::KCanvasMasker::KCanvasMasker):
974         (WebCore::KCanvasMasker::~KCanvasMasker):
975         (WebCore::KCanvasMasker::setMask):
976         (WebCore::KCanvasMasker::externalRepresentation):
977         (WebCore::getMaskerById):
978         * kcanvas/KCanvasMasker.h: Added.
979         (WebCore::KCanvasMasker::isMasker):
980         (WebCore::KCanvasMasker::mask):
981         * kcanvas/KCanvasResource.cpp: Added.
982         (WebCore::operator<<):
983         (WebCore::KCanvasResource::KCanvasResource):
984         (WebCore::KCanvasResource::~KCanvasResource):
985         (WebCore::KCanvasResource::addClient):
986         (WebCore::KCanvasResource::clients):
987         (WebCore::KCanvasResource::invalidate):
988         (WebCore::KCanvasResource::idInRegistry):
989         (WebCore::KCanvasResource::setIdInRegistry):
990         (WebCore::KCanvasResource::externalRepresentation):
991         (WebCore::getResourceById):
992         (WebCore::getPaintServerById):
993         * kcanvas/KCanvasResource.h:
994         (WebCore::):
995         (WebCore::KCanvasResource::isPaintServer):
996         (WebCore::KCanvasResource::isFilter):
997         (WebCore::KCanvasResource::isClipper):
998         (WebCore::KCanvasResource::isMarker):
999         (WebCore::KCanvasResource::isMasker):
1000         * kcanvas/KCanvasResourceListener.h: Added.
1001         (KCanvasResourceListener::KCanvasResourceListener):
1002         (KCanvasResourceListener::~KCanvasResourceListener):
1003         * kcanvas/KCanvasTreeDebug.cpp:
1004         (WebCore::writeRenderResources):
1005         * kcanvas/device/KRenderingDevice.h:
1006         * kcanvas/device/KRenderingPaintServer.h:
1007         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1008         (WebCore::KRenderingPaintServer::idInRegistry):
1009         (WebCore::KRenderingPaintServer::setIdInRegistry):
1010         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1011         (WebCore::KRenderingPaintServerGradient::listener):
1012         (WebCore::KRenderingPaintServerGradient::setListener):
1013         * kcanvas/device/KRenderingPaintServerGradient.h:
1014         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1015         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1016         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1017         (WebCore::KRenderingPaintServerPattern::tile):
1018         (WebCore::KRenderingPaintServerPattern::setTile):
1019         (WebCore::KRenderingPaintServerPattern::listener):
1020         (WebCore::KRenderingPaintServerPattern::setListener):
1021         * kcanvas/device/KRenderingPaintServerPattern.h:
1022         * kcanvas/device/KRenderingPaintServerSolid.h:
1023         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1024         (WebCore::KCanvasClipperQt::applyClip):
1025         * kcanvas/device/qt/KCanvasClipperQt.h:
1026         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1027         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1028         (WebCore::KRenderingDeviceQt::contextForImage):
1029         (WebCore::KRenderingDeviceQt::createResource):
1030         (WebCore::KRenderingDeviceQt::createPaintServer):
1031         * kcanvas/device/qt/KRenderingDeviceQt.h:
1032         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1033         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1034         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1035         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1036         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1037         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1038         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1039         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1040         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1041         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1042         (WebCore::applyLuminanceToAlphaFilter):
1043         (WebCore::applyExpandAlphatoGrayscaleFilter):
1044         (WebCore::transformImageIntoGrayscaleMask):
1045         (WebCore::KCanvasMaskerQuartz::applyMask):
1046         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1047         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1048         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1049         (WebCore::KCanvasImageQuartz::init):
1050         (WebCore::KCanvasImageQuartz::size):
1051         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1052         (WebCore::KCanvasClipperQuartz::applyClip):
1053         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1054         (WebCore::KCanvasImageQuartz::cgLayer):
1055         (WebCore::KCanvasImageQuartz::setCGLayer):
1056         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1057         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1058         (WebCore::KRenderingDeviceQuartz::contextForImage):
1059         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1060         (WebCore::KRenderingDeviceQuartz::createResource):
1061         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1062         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1063         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1064         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1065         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1066         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1067         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1068         (WebCore::patternCallback):
1069         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1070         * kcanvas/device/quartz/QuartzSupport.mm:
1071         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1072         (WebCore::sharedSolidPaintServer):
1073         * ksvg2/svg/SVGClipPathElement.cpp:
1074         (WebCore::SVGClipPathElement::SVGClipPathElement):
1075         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1076         (WebCore::SVGClipPathElement::canvasResource):
1077         * ksvg2/svg/SVGClipPathElement.h:
1078         * ksvg2/svg/SVGFEImageElement.cpp:
1079         * ksvg2/svg/SVGFilterElement.cpp:
1080         (WebCore::SVGFilterElement::SVGFilterElement):
1081         (WebCore::SVGFilterElement::~SVGFilterElement):
1082         (WebCore::SVGFilterElement::canvasResource):
1083         * ksvg2/svg/SVGFilterElement.h:
1084         * ksvg2/svg/SVGGradientElement.cpp:
1085         (WebCore::SVGGradientElement::SVGGradientElement):
1086         (WebCore::SVGGradientElement::~SVGGradientElement):
1087         (WebCore::SVGGradientElement::canvasResource):
1088         (WebCore::SVGGradientElement::resourceNotification):
1089         * ksvg2/svg/SVGGradientElement.h:
1090         * ksvg2/svg/SVGImageElement.cpp:
1091         * ksvg2/svg/SVGLinearGradientElement.cpp:
1092         (WebCore::SVGLinearGradientElement::buildGradient):
1093         * ksvg2/svg/SVGLinearGradientElement.h:
1094         * ksvg2/svg/SVGMarkerElement.cpp:
1095         (WebCore::SVGMarkerElement::SVGMarkerElement):
1096         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1097         (WebCore::SVGMarkerElement::canvasResource):
1098         * ksvg2/svg/SVGMarkerElement.h:
1099         * ksvg2/svg/SVGMaskElement.cpp:
1100         (WebCore::SVGMaskElement::SVGMaskElement):
1101         (WebCore::SVGMaskElement::~SVGMaskElement):
1102         (WebCore::SVGMaskElement::drawMaskerContent):
1103         (WebCore::SVGMaskElement::canvasResource):
1104         * ksvg2/svg/SVGMaskElement.h:
1105         * ksvg2/svg/SVGPatternElement.cpp:
1106         (WebCore::SVGPatternElement::SVGPatternElement):
1107         (WebCore::SVGPatternElement::~SVGPatternElement):
1108         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1109         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1110         (WebCore::SVGPatternElement::canvasResource):
1111         * ksvg2/svg/SVGPatternElement.h:
1112         * ksvg2/svg/SVGRadialGradientElement.cpp:
1113         (WebCore::SVGRadialGradientElement::buildGradient):
1114         * ksvg2/svg/SVGRadialGradientElement.h:
1115         * ksvg2/svg/SVGStyledElement.h:
1116         (WebCore::SVGStyledElement::canvasResource):
1117         * platform/GraphicsContext.cpp: Added.
1118         (WebCore::GraphicsContextState::GraphicsContextState):
1119         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1120         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1121         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1122         (WebCore::GraphicsContext::save):
1123         (WebCore::GraphicsContext::restore):
1124         (WebCore::GraphicsContext::font):
1125         (WebCore::GraphicsContext::setFont):
1126         (WebCore::GraphicsContext::pen):
1127         (WebCore::GraphicsContext::setPen):
1128         (WebCore::GraphicsContext::setFillColor):
1129         (WebCore::GraphicsContext::fillColor):
1130         (WebCore::GraphicsContext::updatingControlTints):
1131         (WebCore::GraphicsContext::setUpdatingControlTints):
1132         (WebCore::GraphicsContext::setPaintingDisabled):
1133         (WebCore::GraphicsContext::paintingDisabled):
1134         (WebCore::GraphicsContext::drawImage):
1135         (WebCore::GraphicsContext::drawText):
1136         (WebCore::GraphicsContext::drawHighlightForText):
1137         (WebCore::GraphicsContext::initFocusRing):
1138         (WebCore::GraphicsContext::clearFocusRing):
1139         (WebCore::GraphicsContext::focusRingBoundingRect):
1140         (WebCore::GraphicsContext::addFocusRingRect):
1141         (WebCore::GraphicsContext::focusRingWidth):
1142         (WebCore::GraphicsContext::focusRingOffset):
1143         (WebCore::GraphicsContext::focusRingRects):
1144         (WebCore::GraphicsContext::drawTiledImage):
1145         * platform/GraphicsContext.h: Added.
1146         * platform/GraphicsTypes.cpp: Added.
1147         (WebCore::):
1148         (WebCore::parseCompositeOperator):
1149         (WebCore::compositeOperatorName):
1150         (WebCore::parseLineCap):
1151         (WebCore::lineCapName):
1152         (WebCore::parseLineJoin):
1153         (WebCore::lineJoinName):
1154         * platform/GraphicsTypes.h: Added.
1155         (WebCore::):
1156         * platform/graphics/GraphicsContext.cpp:
1157         * platform/graphics/GraphicsContext.h:
1158         * platform/graphics/GraphicsTypes.cpp:
1159         * platform/graphics/GraphicsTypes.h:
1160         * platform/qt/GraphicsContextQt.cpp:
1161         * rendering/RenderPath.cpp:
1162         (WebCore::RenderPath::paint):
1163         (WebCore::DrawMarkersData::DrawMarkersData):
1164         (WebCore::RenderPath::drawMarkersIfNeeded):
1165         * rendering/RenderSVGContainer.cpp:
1166         (WebCore::RenderSVGContainer::paint):
1167         * rendering/RenderSVGImage.cpp:
1168         (WebCore::RenderSVGImage::paint):
1169         * rendering/SVGInlineFlowBox.cpp:
1170         (WebCore::paintSVGInlineFlow):
1171
1172 2006-10-30  John Sullivan  <sullivan@apple.com>
1173
1174         Reviewed by Geoff Garen.
1175         
1176         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1177         grammar-related method.
1178
1179         * bridge/EditorClient.h:
1180         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1181         isGrammarCheckingEnabled()
1182         
1183         * bridge/mac/WebCoreFrameBridge.h:
1184         removed bridge equivalents
1185
1186         * bridge/mac/FrameMac.mm:
1187         (WebCore::FrameMac::advanceToNextMisspelling):
1188         convert bridge-using code to editor()->client()-using code
1189         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1190         ditto
1191         (WebCore::FrameMac::markMisspellings):
1192         ditto
1193         (WebCore::FrameMac::respondToChangedSelection):
1194         ditto
1195         
1196         * editing/Editor.h:
1197         * editing/Editor.cpp:
1198         (WebCore::Editor::client):
1199         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1200         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1201         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1202
1203 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1204
1205         Reviewed by Darin.
1206
1207         Removed a number of editing and selection methods from the bridge.
1208         
1209         I moved cross-platform editing and selection code into Editor and 
1210         SelectionController, respecitvely.
1211
1212         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1213         everything + the kitchen sink.
1214         
1215         Specific comments below for interesting things.
1216         
1217         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1218         a new file so that WebKit can use them, too. Added a helper method for
1219         handling exceptions when selecting a Range.
1220         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1221         WebKit, since they have to do with creating an NSAttributedString for API
1222         consumption, and not much to do with general Frame functionality.
1223         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1224         for now) into the Editor. Eventually, the Frame will not have to notify 
1225         the Editor of what the lastEditCommand was, since the Editor will perform
1226         all EditCommands.
1227         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1228         * editing/SelectionController.cpp:
1229         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1230         and return them. The bridge method to select a DOM range did this implicitly,
1231         since all ObjC DOM operations handle DOM exceptions by throwing them as
1232         ObjC exceptions.
1233         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1234         The two enumerations are numerically identical, but that's an implementation
1235         detail of TextAffinity that clients shouldn't be required to know about.
1236
1237 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1238
1239         Rolling out the following change because this crash:
1240         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1241
1242         And this regression:
1243         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1244
1245     2006-09-06  David Harrison  <harrison@apple.com>
1246
1247         Reviewed and tweaked by Tim H. 
1248
1249         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1250
1251         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1252         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1253         No layout tests affected. Not testable in an automated way that will work on all systems. 
1254
1255         * platform/mac/WebFontCache.mm: 
1256         (+[WebFontCache fontWithFamily:traits:size:]): 
1257
1258 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1259
1260         Reviewed by harrison
1261
1262         <rdar://problem/4808375>
1263         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1264
1265         * editing/TextIterator.cpp:
1266         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1267         when we're going to use them to create a range for an emitted character.
1268         We should further speed TextIterators up by avoiding creating VisiblePositions
1269         for TIs that are only used for the characters they emit (like the one that 
1270         plainText uses).
1271
1272 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1273
1274         Reviewed by Mitz.
1275
1276         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1277         More rendering code cleaning
1278
1279         * WebCore.xcodeproj/project.pbxproj:
1280         * rendering/RenderApplet.cpp:
1281         (WebCore::RenderApplet::RenderApplet):
1282         (WebCore::RenderApplet::createWidgetIfNecessary):
1283         * rendering/RenderApplet.h:
1284         * rendering/RenderArena.cpp:
1285         (WebCore::):
1286         (WebCore::RenderArena::RenderArena):
1287         (WebCore::RenderArena::allocate):
1288         (WebCore::RenderArena::free):
1289         * rendering/RenderArena.h:
1290         * rendering/RenderBR.cpp:
1291         (WebCore::RenderBR::RenderBR):
1292         (WebCore::RenderBR::baselinePosition):
1293         (WebCore::RenderBR::lineHeight):
1294         (WebCore::RenderBR::setStyle):
1295         (WebCore::RenderBR::caretMinOffset):
1296         (WebCore::RenderBR::positionForCoordinates):
1297         (WebCore::RenderBR::inlineBox):
1298         * rendering/RenderBR.h:
1299         * rendering/RenderBlock.cpp:
1300         * rendering/RenderBlock.h:
1301         (WebCore::RenderBlock::maxTopMargin):
1302         (WebCore::RenderBlock::maxBottomMargin):
1303         (WebCore::RenderBlock::initMaxMarginValues):
1304         (WebCore::RenderBlock::containsFloats):
1305         (WebCore::RenderBlock::setHasMarkupTruncation):
1306         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1307         (WebCore::RenderBlock::BlockSelectionInfo::block):
1308         (WebCore::RenderBlock::BlockSelectionInfo::state):
1309         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1310         (WebCore::RenderBlock::CompactInfo::clear):
1311         * rendering/RenderButton.cpp:
1312         (WebCore::RenderButton::removeChild):
1313         (WebCore::RenderButton::paintObject):
1314         * rendering/RenderButton.h:
1315         (WebCore::RenderButton::renderName):
1316         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1317         * rendering/RenderContainer.cpp:
1318         (WebCore::RenderContainer::RenderContainer):
1319         * rendering/RenderContainer.h:
1320         (WebCore::RenderContainer::firstChild):
1321         (WebCore::RenderContainer::lastChild):
1322         (WebCore::RenderContainer::calcMinMaxWidth):
1323         * rendering/RenderCounter.cpp:
1324         (WebCore::RenderCounter::RenderCounter):
1325         (WebCore::toRoman):
1326         (WebCore::toHebrew):
1327         (WebCore::RenderCounter::calcMinMaxWidth):
1328         * rendering/RenderCounter.h:
1329         * rendering/RenderFieldset.cpp:
1330         (WebCore::RenderFieldset::paintBoxDecorations):
1331         (WebCore::RenderFieldset::paintBorderMinusLegend):
1332         (WebCore::RenderFieldset::setStyle):
1333         * rendering/RenderFileUploadControl.cpp:
1334         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1335         (WebCore::RenderFileUploadControl::setStyle):
1336         (WebCore::RenderFileUploadControl::paintObject):
1337         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1338         * rendering/RenderFileUploadControl.h:
1339         (WebCore::RenderFileUploadControl::renderName):
1340         * rendering/RenderFlexibleBox.h:
1341         * rendering/RenderFlow.cpp:
1342         * rendering/RenderFlow.h:
1343         * rendering/RenderForeignObject.cpp:
1344         (WebCore::RenderForeignObject::RenderForeignObject):
1345         (WebCore::RenderForeignObject::paint):
1346         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1347         (WebCore::RenderForeignObject::layout):
1348         (WebCore::RenderForeignObject::nodeAtPoint):
1349         * rendering/RenderForeignObject.h:
1350         (WebCore::RenderForeignObject::renderName):
1351         * rendering/RenderFormElement.cpp:
1352         (WebCore::RenderFormElement::setStyle):
1353         (WebCore::RenderFormElement::layout):
1354         (WebCore::RenderFormElement::textAlignment):
1355         * rendering/RenderFormElement.h:
1356         * rendering/RenderFrame.cpp:
1357         * rendering/RenderFrame.h:
1358         (WebCore::RenderFrame::element):
1359         * rendering/RenderFrameSet.cpp:
1360         * rendering/RenderFrameSet.h:
1361         (WebCore::RenderFrameSet::element):
1362         * rendering/RenderHTMLCanvas.cpp:
1363         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1364         (WebCore::RenderHTMLCanvas::paint):
1365         * rendering/RenderHTMLCanvas.h:
1366         (WebCore::RenderHTMLCanvas::renderName):
1367         * rendering/RenderImage.cpp:
1368         (WebCore::RenderImage::RenderImage):
1369         (WebCore::RenderImage::setStyle):
1370         (WebCore::RenderImage::setContentObject):
1371         (WebCore::RenderImage::setCachedImage):
1372         (WebCore::RenderImage::imageChanged):
1373         (WebCore::RenderImage::paint):
1374         (WebCore::RenderImage::layout):
1375         (WebCore::RenderImage::updateAltText):
1376         * rendering/RenderImage.h:
1377         (WebCore::RenderImage::element):
1378         * rendering/RenderInline.cpp:
1379         (WebCore::RenderInline::RenderInline):
1380         (WebCore::RenderInline::~RenderInline):
1381         (WebCore::RenderInline::setStyle):
1382         (WebCore::RenderInline::addChildToFlow):
1383         (WebCore::RenderInline::cloneInline):
1384         (WebCore::RenderInline::splitInlines):
1385         (WebCore::RenderInline::splitFlow):
1386         (WebCore::RenderInline::paint):
1387         (WebCore::RenderInline::absoluteRects):
1388         (WebCore::RenderInline::calcMinMaxWidth):
1389         (WebCore::RenderInline::requiresLayer):
1390         (WebCore::RenderInline::width):
1391         (WebCore::RenderInline::height):
1392         (WebCore::RenderInline::renderName):
1393         (WebCore::RenderInline::nodeAtPoint):
1394         (WebCore::RenderInline::positionForCoordinates):
1395         * rendering/RenderInline.h:
1396         (WebCore::RenderInline::layout):
1397         * rendering/RenderLayer.cpp:
1398         * rendering/RenderLayer.h:
1399         (WebCore::ClipRects::ClipRects):
1400         (WebCore::RenderLayer::nextSibling):
1401         (WebCore::RenderLayer::root):
1402         (WebCore::RenderLayer::setPos):
1403         (WebCore::RenderLayer::height):
1404         (WebCore::RenderLayer::relativePositionOffset):
1405         * rendering/RenderLineEdit.cpp:
1406         (WebCore::RenderLineEdit::setStyle):
1407         (WebCore::RenderLineEdit::updateFromElement):
1408         (WebCore::RenderLineEdit::selectionStart):
1409         (WebCore::RenderLineEdit::selectionEnd):
1410         (WebCore::RenderLineEdit::setSelectionStart):
1411         (WebCore::RenderLineEdit::setSelectionEnd):
1412         (WebCore::RenderLineEdit::setSelectionRange):
1413         * rendering/RenderLineEdit.h:
1414         * rendering/RenderListBox.cpp:
1415         * rendering/RenderListBox.h:
1416         (WebCore::RenderListBox::renderName):
1417         * rendering/RenderListItem.cpp:
1418         (WebCore::RenderListItem::setStyle):
1419         (WebCore::getParentOfFirstLineBox):
1420         (WebCore::RenderListItem::updateMarkerLocation):
1421         (WebCore::RenderListItem::positionListMarker):
1422         (WebCore::RenderListItem::paint):
1423         * rendering/RenderListItem.h:
1424         * rendering/RenderListMarker.cpp:
1425         * rendering/RenderListMarker.h:
1426         (WebCore::RenderListMarker::renderName):
1427         (WebCore::RenderListMarker::isListMarker):
1428
1429 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1430
1431         Reviewed by Hyatt.
1432
1433         <rdar://problem/4478625> Basic table editing and culling
1434
1435         Refined the criteria for deletable elements, rely on the renderer more.
1436         Corrected the interface positioning for elements that have borders.
1437
1438         * editing/DeleteButtonController.cpp:
1439         (WebCore::isDeletableElement):
1440         (WebCore::DeleteButtonController::show):
1441
1442 2006-10-30  Darin Adler  <darin@apple.com>
1443
1444         - fix build
1445
1446         * loader/ResourceLoader.h: Added header guard.
1447
1448 2006-10-31  Darin Adler  <darin@apple.com>
1449
1450         Reviewed by Adam.
1451
1452         - fix FrameLoader files so they can be built on non-Mac platforms
1453
1454         * page/FramePrivate.h:
1455         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1456         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1457
1458         * page/Page.h:
1459         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1460         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1461         the other day.
1462
1463         * bridge/mac/FrameMac.mm:
1464         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1465         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1466
1467         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1468         around the PolicyCheck definition.
1469
1470         * loader/FormState.cpp: Changed import to include.
1471         * loader/FrameLoader.cpp: Ditto.
1472         * loader/MainResourceLoader.h: Ditto.
1473
1474         * loader/FrameLoaderTypes.h: Added a header guard.
1475
1476         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1477         Added #if PLATFORM(MAC) around Mac-specific details.
1478         * loader/SubresourceLoader.h: Ditto.
1479
1480         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1481         m_loader from m_frameLoader.
1482
1483         * CMakeLists.txt: Updated.
1484         * WebCoreSources.bkl: Updated.
1485
1486 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1487
1488         Reviewed and landed by Anders.
1489
1490         Patch by Zack rusin to fix: 
1491         http://bugs.webkit.org/show_bug.cgi?id=11429
1492
1493         Fix startup crash.
1494
1495         * platform/qt/FrameQtClient.cpp:
1496         (WebCore::FrameQtClientDefault::openURL):
1497
1498 2006-10-30  Zach Rusin  <zack@kde.org>
1499
1500         Reviewed and landed by Anders.
1501
1502         * platform/network/qt/ResourceHandleQt.cpp:
1503         (WebCore::ResourceHandle::receivedResponse):
1504         * platform/qt/FrameQtClient.cpp:
1505         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1506         * platform/qt/LoaderFunctionsQt.cpp:
1507         (WebCore::ServeSynchronousRequest):
1508         More build fixes.
1509
1510 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1511
1512         Reviewed and landed by Anders.
1513         
1514         - fix Qt build
1515         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1516         ResourceHandleClient
1517
1518 2006-10-30  Darin Adler  <darin@apple.com>
1519
1520         Reviewed by John Sullivan.
1521
1522         - work toward removing Objective-C data types from FrameLoader.h:
1523           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1524           and WebCoreResourceHandle
1525         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
1526
1527         * page/PageState.h:
1528         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
1529
1530         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
1531         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
1532         double for the date instead of an NSDate.
1533
1534         * bridge/mac/WebCoreFrameBridge.h:
1535         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
1536         saveDocumentToPageCache methods.
1537
1538         * bridge/mac/WebCorePageState.h:
1539         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
1540         an Objective-C wrapper for PageState.
1541
1542         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
1543         NSDate and WebCorePageState.
1544         * loader/FrameLoaderClient.h: Changed NSDate to double.
1545         * loader/mac/FrameLoaderMac.mm:
1546         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
1547         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
1548         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
1549         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
1550         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
1551         extract the parameters from the response. Changed the open function that takes
1552         a PageState to use the new C++ PageState.
1553         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
1554         function; tightened up logic, removing a few cases that could never happen, as
1555         well as the unused reload boolean.
1556
1557         * ForwardingHeaders/kjs/property_map.h: Added.
1558
1559         * WebCore.exp: Updated.
1560         * WebCore.xcodeproj/project.pbxproj: Updated.
1561
1562 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1563
1564         Reviewed by Anders.
1565
1566         - added ResourceResponse class and didReceiveResponse delegate call
1567         
1568         * WebCore.xcodeproj/project.pbxproj: Added new files.
1569         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
1570         expiresTimeForResponse: method.
1571         * dom/XMLTokenizer.cpp:
1572         (WebCore::openFunc): Updated to use ResourceResponse.
1573         * loader/FrameLoader.h: Update loadResourceSynchronously to
1574         use ResourceResponse.
1575         * loader/LoaderFunctions.h:
1576         * loader/icon/IconLoader.cpp:
1577         (IconLoader::didReceiveResponse): Updated from receivedResponse
1578         and made cross-platform.
1579         * loader/icon/IconLoader.h: updated for above change
1580         * loader/loader.cpp:
1581         (WebCore::Loader::receivedResponse): reduced to just saving
1582         the PlatformResponse (ideally we'd phase out use of this).
1583         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
1584         logic.
1585         * loader/loader.h:
1586         * loader/mac/FrameLoaderMac.mm:
1587         (WebCore::FrameLoader::loadResourceSynchronously): Return results
1588         as ResourceResponse.
1589         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
1590         * loader/mac/LoaderFunctionsMac.mm:
1591         (WebCore::ServeSynchronousRequest): take ResourceResponse as
1592         argument.
1593         * platform/network/ResourceHandle.cpp:
1594         * platform/network/ResourceHandle.h: Remove calls for
1595         broken out response pieces.
1596         * platform/network/ResourceHandleClient.h:
1597         (WebCore::ResourceHandleClient::didReceiveResponse): New
1598         delegate method.
1599         * platform/network/ResourceHandleInternal.h:
1600         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
1601         storage of response bits, we're not gonna return them
1602         seprately any more.
1603         * platform/network/ResourceResponse.h: Added.
1604         (WebCore::ResourceResponse::ResourceResponse): Freshly
1605         implemented. Same for below.
1606         (WebCore::ResourceResponse::url):
1607         (WebCore::ResourceResponse::mimeType):
1608         (WebCore::ResourceResponse::expectedContentLength):
1609         (WebCore::ResourceResponse::textEncodingName):
1610         (WebCore::ResourceResponse::suggestedFilename):
1611         (WebCore::ResourceResponse::httpStatusCode):
1612         (WebCore::ResourceResponse::setHTTPStatusCode):
1613         (WebCore::ResourceResponse::httpHeaderField):
1614         (WebCore::ResourceResponse::httpHeaderFields):
1615         (WebCore::ResourceResponse::isMultipart):
1616         (WebCore::ResourceResponse::setExpirationDate):
1617         (WebCore::ResourceResponse::expirationDate):
1618         * platform/network/cf/ResourceHandleCFNet.cpp:
1619         (WebCore::didReceiveResponse): Send didReceiveResponse
1620         client method.
1621         * platform/network/cf/ResourceResponseCFNet.h: Added.
1622         * platform/network/cf/ResourceResponseCFNet.mm: Added.
1623         (getResourceResponse): Helper function to get a ResourceResponse 
1624         from CFURLResponseRef.
1625         * platform/network/mac/ResourceHandleMac.mm:
1626         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
1627         Don't bother cleaning up fields we no longer have.
1628         (WebCore::ResourceHandle::receivedResponse): Send
1629         didReceiveResponse client method.
1630         * platform/network/mac/ResourceResponseMac.h: Added.
1631         * platform/network/mac/ResourceResponseMac.mm: Added.
1632         (getResourceResponse): Helper function to get a ResourceResponse 
1633         from an NSURLResponse*.
1634         * rendering/HitTestResult.cpp:
1635         * xml/XSLTProcessor.cpp:
1636         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
1637         * xml/xmlhttprequest.cpp:
1638         (WebCore::XMLHttpRequest::getResponseText): Store http response
1639         info in the form of a ResourceResponse, change all methods to
1640         account for this.
1641         (WebCore::XMLHttpRequest::getResponseXML):
1642         (WebCore::XMLHttpRequest::XMLHttpRequest):
1643         (WebCore::XMLHttpRequest::open):
1644         (WebCore::XMLHttpRequest::send):
1645         (WebCore::XMLHttpRequest::getAllResponseHeaders):
1646         (WebCore::XMLHttpRequest::getResponseHeader):
1647         (WebCore::XMLHttpRequest::getStatus):
1648         (WebCore::XMLHttpRequest::getStatusText):
1649         (WebCore::XMLHttpRequest::processSyncLoadResults):
1650         (WebCore::XMLHttpRequest::didFinishLoading):
1651         (WebCore::XMLHttpRequest::didReceiveResponse):
1652         (WebCore::XMLHttpRequest::didReceiveData):
1653         * xml/xmlhttprequest.h:
1654
1655 2006-10-29  Darin Adler  <darin@apple.com>
1656
1657         - fix build
1658
1659         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
1660         * loader/NetscapePlugInStreamLoader.h: Ditto.
1661         * loader/ResourceLoader.h: Ditto.
1662
1663 2006-10-29  Darin Adler  <darin@apple.com>
1664
1665         - one last name change -- WebFormState.h to FormState.h
1666         - added more empty placeholder platform-independent files
1667           for currently-Mac-specific loader classes
1668
1669         * loader/FormState.cpp: Updated include.
1670         * loader/FrameLoader.cpp: Updated include.
1671         * loader/mac/FrameLoaderMac.mm: Updated include.
1672
1673         * loader/WebFormState.h: Removed.
1674         * loader/FormState.h: Added.
1675
1676         * loader/DocumentLoader.cpp: Added.
1677         * loader/MainResourceLoader.cpp: Added.
1678         * loader/NetscapePlugInStreamLoader.cpp: Added.
1679         * loader/ResourceLoader.cpp: Added.
1680         * loader/SubresourceLoader.cpp: Added.
1681
1682         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
1683
1684 2006-10-29  Darin Adler  <darin@apple.com>
1685
1686         - did the do-webcore-rename renames, including a number of changes
1687           to the names of loader files (and WebResourceLoader -> ResourceLoader),
1688           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
1689           and improvements to the names of decoder classes and their source
1690           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
1691
1692         * CMakeLists.txt:
1693         * WebCore.exp:
1694         * WebCore.vcproj/WebCore/WebCore.vcproj:
1695         * WebCore.xcodeproj/project.pbxproj:
1696         * WebCoreSources.bkl:
1697         * bindings/js/kjs_binding.cpp:
1698         (KJS::ScriptInterpreter::updateDOMNodeDocument):
1699         * bindings/js/kjs_events.cpp:
1700         (KJS::JSAbstractEventListener::handleEvent):
1701         (KJS::JSLazyEventListener::parseCode):
1702         * bindings/js/kjs_html.cpp:
1703         (KJS::JSHTMLElement::implementsCall):
1704         * bindings/js/kjs_traversal.cpp:
1705         (KJS::JSNodeFilterCondition::acceptNode):
1706         * bindings/js/kjs_window.cpp:
1707         (KJS::Window::interpreter):
1708         (KJS::Window::retrieveWindow):
1709         (KJS::Window::retrieve):
1710         (KJS::ScheduledAction::execute):
1711         * bindings/objc/DOMInternal.mm:
1712         (-[WebScriptObject _initializeScriptDOMNodeImp]):
1713         * bridge/mac/FrameMac.mm:
1714         (WebCore::FrameMac::executionContextForDOM):
1715         (WebCore::FrameMac::bindingRootObject):
1716         (WebCore::FrameMac::windowScriptObject):
1717         (WebCore::FrameMac::windowScriptNPObject):
1718         (WebCore::FrameMac::partClearedInBegin):
1719         * bridge/mac/WebCoreEncodings.mm:
1720         * bridge/mac/WebCoreFrameBridge.mm:
1721         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
1722         (-[WebCoreFrameBridge stringWithData:]):
1723         (-[WebCoreFrameBridge executionContextForView:]):
1724         * bridge/win/FrameWin.cpp:
1725         * dom/Document.cpp:
1726         (WebCore::Document::inputEncoding):
1727         (WebCore::Document::setCharset):
1728         (WebCore::Document::createHTMLEventListener):
1729         (WebCore::Document::setDecoder):
1730         * dom/Document.h:
1731         (WebCore::Document::decoder):
1732         * dom/EventTargetNode.cpp:
1733         (WebCore::EventTargetNode::dispatchGenericEvent):
1734         * html/HTMLParser.cpp:
1735         (WebCore::HTMLParser::noscriptCreateErrorCheck):
1736         (WebCore::HTMLParser::canvasCreateErrorCheck):
1737         (WebCore::HTMLParser::isInline):
1738         * html/HTMLPlugInElement.cpp:
1739         (WebCore::HTMLPlugInElement::createNPObject):
1740         * html/HTMLScriptElement.cpp:
1741         (WebCore::HTMLScriptElement::evaluateScript):
1742         * html/HTMLTokenizer.cpp:
1743         (WebCore::HTMLTokenizer::parseTag):
1744         (WebCore::HTMLTokenizer::processToken):
1745         * ksvg2/misc/SVGDocumentExtensions.cpp:
1746         (WebCore::SVGDocumentExtensions::createSVGEventListener):
1747         * loader/CachedCSSStyleSheet.cpp:
1748         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
1749         (WebCore::CachedCSSStyleSheet::setEncoding):
1750         * loader/CachedCSSStyleSheet.h:
1751         * loader/CachedXBLDocument.cpp:
1752         (WebCore::CachedXBLDocument::CachedXBLDocument):
1753         (WebCore::CachedXBLDocument::setEncoding):
1754         * loader/CachedXBLDocument.h:
1755         * loader/CachedXSLStyleSheet.cpp:
1756         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
1757         (WebCore::CachedXSLStyleSheet::setEncoding):
1758         * loader/CachedXSLStyleSheet.h:
1759         * loader/Decoder.cpp: Removed.
1760         * loader/Decoder.h: Removed.
1761         * loader/FrameLoader.cpp:
1762         * loader/FrameLoader.h:
1763         * loader/FrameLoaderClient.h:
1764         * loader/MainResourceLoader.h: Added.
1765         * loader/NetscapePlugInStreamLoader.h: Added.
1766         * loader/Request.h:
1767         (WebCore::Request::cachedResource):
1768         * loader/ResourceLoader.h: Added.
1769         * loader/SubresourceLoader.h: Added.
1770         * loader/TextResourceDecoder.cpp: Added.
1771         (WebCore::TextResourceDecoder::determineContentType):
1772         (WebCore::TextResourceDecoder::defaultEncoding):
1773         (WebCore::TextResourceDecoder::TextResourceDecoder):
1774         (WebCore::TextResourceDecoder::~TextResourceDecoder):
1775         (WebCore::TextResourceDecoder::setEncoding):
1776         (WebCore::TextResourceDecoder::checkForBOM):
1777         (WebCore::TextResourceDecoder::checkForCSSCharset):
1778         (WebCore::TextResourceDecoder::checkForHeadCharset):
1779         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
1780         (WebCore::TextResourceDecoder::decode):
1781         (WebCore::TextResourceDecoder::flush):
1782         * loader/TextResourceDecoder.h: Added.
1783         * loader/WebDocumentLoader.h: Removed.
1784         * loader/WebLoader.h: Removed.
1785         * loader/WebMainResourceLoader.h: Removed.
1786         * loader/WebNetscapePlugInStreamLoader.h: Removed.
1787         * loader/WebSubresourceLoader.h: Removed.
1788         * loader/loader.cpp:
1789         (WebCore::Loader::servePendingRequests):
1790         (WebCore::Loader::receivedAllData):
1791         (WebCore::Loader::receivedResponse):
1792         (WebCore::Loader::didReceiveData):
1793         (WebCore::Loader::cancelRequests):
1794         (WebCore::Loader::jobForRequest):
1795         * loader/mac/DocumentLoaderMac.mm:
1796         * loader/mac/FormDataStream.m: Added.
1797         * loader/mac/FrameLoaderMac.mm:
1798         (WebCore::FrameLoader::cancelPendingArchiveLoad):
1799         (WebCore::FrameLoader::addPlugInStreamLoader):
1800         (WebCore::FrameLoader::removePlugInStreamLoader):
1801         (WebCore::FrameLoader::addSubresourceLoader):
1802         (WebCore::FrameLoader::removeSubresourceLoader):
1803         (WebCore::FrameLoader::willSendRequest):
1804         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
1805         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
1806         (WebCore::FrameLoader::didReceiveResponse):
1807         (WebCore::FrameLoader::didReceiveData):
1808         (WebCore::FrameLoader::didFinishLoad):
1809         (WebCore::FrameLoader::didFailToLoad):
1810         (WebCore::FrameLoader::open):
1811         (WebCore::FrameLoader::willUseArchive):
1812         (WebCore::FrameLoader::isArchiveLoadPending):
1813         * loader/mac/ImageDocumentMac.mm:
1814         * loader/mac/LoaderFunctionsMac.mm:
1815         (WebCore::CheckCacheObjectStatus):
1816         * loader/mac/MainResourceLoaderMac.mm:
1817         (WebCore::MainResourceLoader::MainResourceLoader):
1818         (WebCore::MainResourceLoader::releaseDelegate):
1819         (WebCore::MainResourceLoader::didCancel):
1820         (WebCore::MainResourceLoader::addData):
1821         (WebCore::MainResourceLoader::willSendRequest):
1822         (WebCore::MainResourceLoader::continueAfterContentPolicy):
1823         (WebCore::MainResourceLoader::didReceiveData):
1824         (WebCore::MainResourceLoader::didFinishLoading):
1825         (WebCore::MainResourceLoader::setDefersLoading):
1826         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
1827         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
1828         (WebCore::NetscapePlugInStreamLoader::releaseResources):
1829         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1830         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
1831         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
1832         (WebCore::NetscapePlugInStreamLoader::didFail):
1833         (WebCore::NetscapePlugInStreamLoader::didCancel):
1834         * loader/mac/ResourceLoaderMac.mm:
1835         (WebCore::ResourceLoader::ResourceLoader):
1836         (WebCore::ResourceLoader::~ResourceLoader):
1837         (WebCore::ResourceLoader::releaseResources):
1838         (WebCore::ResourceLoader::load):
1839         (WebCore::ResourceLoader::setDefersLoading):
1840         (WebCore::ResourceLoader::frameLoader):
1841         (WebCore::ResourceLoader::addData):
1842         (WebCore::ResourceLoader::resourceData):
1843         (WebCore::ResourceLoader::clearResourceData):
1844         (WebCore::ResourceLoader::willSendRequest):
1845         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
1846         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
1847         (WebCore::ResourceLoader::didReceiveResponse):
1848         (WebCore::ResourceLoader::didReceiveData):
1849         (WebCore::ResourceLoader::willStopBufferingData):
1850         (WebCore::ResourceLoader::didFinishLoading):
1851         (WebCore::ResourceLoader::didFinishLoadingOnePart):
1852         (WebCore::ResourceLoader::didFail):
1853         (WebCore::ResourceLoader::willCacheResponse):
1854         (WebCore::ResourceLoader::didCancel):
1855         (WebCore::ResourceLoader::cancel):
1856         (WebCore::ResourceLoader::setIdentifier):
1857         (WebCore::ResourceLoader::response):
1858         (WebCore::ResourceLoader::inConnectionCallback):
1859         (WebCore::ResourceLoader::cancelledError):
1860         (WebCore::ResourceLoader::receivedCredential):
1861         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
1862         (WebCore::ResourceLoader::receivedCancellation):
1863         (WebCore::ResourceLoader::delegate):
1864         (WebCore::ResourceLoader::releaseDelegate):
1865         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
1866         * loader/mac/SubresourceLoaderMac.mm:
1867         (WebCore::SubresourceLoader::SubresourceLoader):
1868         (WebCore::SubresourceLoader::willSendRequest):
1869         (WebCore::SubresourceLoader::didReceiveResponse):
1870         (WebCore::SubresourceLoader::didReceiveData):
1871         (WebCore::SubresourceLoader::didFinishLoading):
1872         (WebCore::SubresourceLoader::didFail):
1873         (WebCore::SubresourceLoader::didCancel):
1874         * loader/mac/WebFormDataStream.h: Removed.
1875         * loader/mac/WebFormDataStream.m: Removed.
1876         * page/Frame.cpp:
1877         (WebCore::Frame::javaScriptEnabled):
1878         (WebCore::Frame::scriptProxy):
1879         (WebCore::Frame::executeScript):
1880         (WebCore::Frame::write):
1881         (WebCore::Frame::userGestureHint):
1882         (WebCore::Frame::saveInterpreterBuiltins):
1883         (WebCore::Frame::restoreInterpreterBuiltins):
1884         (WebCore::Frame::backslashAsCurrencySymbol):
1885         * page/Frame.h:
1886         * page/FramePrivate.h:
1887         * platform/StreamingTextDecoder.cpp: Removed.
1888         * platform/StreamingTextDecoder.h: Removed.
1889         * platform/StreamingTextDecoderICU.cpp: Removed.
1890         * platform/StreamingTextDecoderICU.h: Removed.
1891         * platform/TextCodec.cpp: Added.
1892         * platform/TextCodec.h: Added.
1893         * platform/TextCodecICU.cpp: Added.
1894         * platform/TextCodecICU.h: Added.
1895         * platform/TextCodecLatin1.h:
1896         * platform/TextCodecUTF16.h:
1897         * platform/TextDecoder.h:
1898         * platform/TextEncoding.cpp:
1899         * platform/TextEncodingRegistry.cpp:
1900         * platform/image-decoders/jpeg/jmorecfg.h:
1901         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
1902         * platform/mac/StreamingTextDecoderMac.h: Removed.
1903         * platform/mac/TextCodecMac.cpp: Added.
1904         * platform/mac/TextCodecMac.h: Added.
1905         * platform/network/ResourceHandleInternal.h:
1906         * platform/network/mac/ResourceHandleMac.mm:
1907         * platform/qt/FrameQt.cpp:
1908         (WebCore::FrameQt::bindingRootObject):
1909         * platform/qt/LoaderFunctionsQt.cpp:
1910         (WebCore::CheckCacheObjectStatus):
1911         * rendering/RenderObject.cpp:
1912         (WebCore::RenderObject::backslashAsCurrencySymbol):
1913         * xml/XSLTProcessor.cpp:
1914         (WebCore::XSLTProcessor::createDocumentFromSource):
1915         * xml/xmlhttprequest.cpp:
1916         (WebCore::XMLHttpRequest::didReceiveData):
1917         * xml/xmlhttprequest.h:
1918
1919 2006-10-29  Darin Adler  <darin@apple.com>
1920
1921         Rubber stamped by Adam (kinda).
1922
1923         - add Mac suffixes and correct filenames inside loader/mac
1924
1925         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
1926
1927         * loader/mac/FrameLoader.mm: Removed.
1928         * loader/mac/WebDocumentLoader.mm: Removed.
1929         * loader/mac/WebLoader.mm: Removed.
1930         * loader/mac/WebMainResourceLoader.mm: Removed.
1931         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
1932         * loader/mac/WebSubresourceLoader.mm: Removed.
1933
1934         * loader/mac/FrameLoaderMac.mm: Added.
1935         * loader/mac/DocumentLoaderMac.mm: Added.
1936         * loader/mac/ResourceLoaderMac.mm: Added.
1937         * loader/mac/MainResourceLoaderMac.mm: Added.
1938         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
1939         * loader/mac/SubresourceLoaderMac.mm: Removed.
1940
1941 2006-10-29  Darin Adler  <darin@apple.com>
1942
1943         Reviewed by Adam.
1944
1945         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
1946           and FrameLoader.cpp mostly ready
1947
1948         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
1949         FormState.cpp. Removed WebFormState.mm.
1950
1951         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
1952         get this header compiling on non-Mac.
1953         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
1954         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
1955
1956         * loader/FrameLoaderClient.h: Added some ifdefs.
1957         * loader/WebDocumentLoader.h: Ditto.
1958         * loader/WebLoader.h: Ditto.
1959         * loader/WebMainResourceLoader.h: Ditto.
1960
1961         * loader/mac/WebDocumentLoader.mm:
1962         (WebCore::DocumentLoader::isLoadingInAPISense):
1963         Rewrote to work without bridge, partly to remove the need for ObjC
1964         bridge type in the header, and also because we're tearing down the bridge.
1965
1966         * loader/mac/WebMainResourceLoader.mm:
1967         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
1968         m_contentLength and m_bytesReceived.
1969         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
1970         (WebCore::MainResourceLoader::didReceiveData): Ditto.
1971
1972         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
1973         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
1974
1975         * loader/mac/FormState.mm: Removed.
1976         * loader/FormState.cpp: Added.
1977
1978 2006-10-29  Darin Adler  <darin@apple.com>
1979
1980         Rubber stamped by Adam.
1981
1982         - moving towards use of FrameLoader cross-platform; move the headers
1983           for the Mac loader from loader/mac into loader, in preparation for
1984           making them useful on non-Mac
1985
1986         * WebCore.xcodeproj/project.pbxproj:
1987
1988         * loader/mac/FrameLoader.h: Removed.
1989         * loader/mac/WebDocumentLoader.h: Removed.
1990         * loader/mac/WebFormState.h: Removed.
1991         * loader/mac/WebLoader.h: Removed.
1992         * loader/mac/WebMainResourceLoader.h: Removed.
1993         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
1994         * loader/mac/WebSubresourceLoader.h: Removed.
1995
1996         * loader/FrameLoader.h: Added.
1997         * loader/WebDocumentLoader.h: Added.
1998         * loader/WebFormState.h: Added.
1999         * loader/WebLoader.h: Added.
2000         * loader/WebMainResourceLoader.h: Added.
2001         * loader/WebNetscapePlugInStreamLoader.h: Added.
2002         * loader/WebSubresourceLoader.h: Added.
2003
2004 2006-10-29  Adam Roben  <aroben@apple.com>
2005
2006         Reviewed by Geoff.
2007
2008         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2009         r17405.
2010
2011         * platform/DeprecatedString.h:
2012
2013 2006-10-29  Beth Dakin  <bdakin@apple.com>
2014
2015         Rubber stamped by Geoff.
2016
2017         This is a followup to my HitTestResult checkin. Most of the 
2018         HitTestResult local variables in the code were named i or info for 
2019         when the class was named NodeInfo. This patch renames all of these 
2020         local variables to result.
2021
2022         * dom/Document.cpp:
2023         (WebCore::Document::prepareMouseEvent):
2024         * html/HTMLAreaElement.cpp:
2025         (WebCore::HTMLAreaElement::mapMouseEvent):
2026         * html/HTMLMapElement.cpp:
2027         (WebCore::HTMLMapElement::mapMouseEvent):
2028         * rendering/EllipsisBox.cpp:
2029         (WebCore::EllipsisBox::nodeAtPoint):
2030         * rendering/EllipsisBox.h:
2031         * rendering/InlineBox.cpp:
2032         (WebCore::InlineBox::nodeAtPoint):
2033         * rendering/InlineFlowBox.cpp:
2034         (WebCore::InlineFlowBox::nodeAtPoint):
2035         * rendering/InlineTextBox.cpp:
2036         (WebCore::InlineTextBox::nodeAtPoint):
2037         * rendering/RenderBlock.cpp:
2038         (WebCore::RenderBlock::isPointInScrollbar):
2039         (WebCore::RenderBlock::nodeAtPoint):
2040         * rendering/RenderBlock.h:
2041         * rendering/RenderBox.cpp:
2042         (WebCore::RenderBox::nodeAtPoint):
2043         * rendering/RenderBox.h:
2044         * rendering/RenderFlow.cpp:
2045         (WebCore::RenderFlow::hitTestLines):
2046         * rendering/RenderFlow.h:
2047         * rendering/RenderForeignObject.cpp:
2048         (WebCore::RenderForeignObject::nodeAtPoint):
2049         * rendering/RenderFrameSet.cpp:
2050         (WebCore::RenderFrameSet::nodeAtPoint):
2051         * rendering/RenderImage.cpp:
2052         (WebCore::RenderImage::nodeAtPoint):
2053         * rendering/RenderInline.cpp:
2054         (WebCore::RenderInline::nodeAtPoint):
2055         * rendering/RenderInline.h:
2056         * rendering/RenderLayer.cpp:
2057         (WebCore::RenderLayer::autoscroll):
2058         (WebCore::RenderLayer::hitTest):
2059         (WebCore::RenderLayer::hitTestLayer):
2060         (WebCore::RenderLayer::updateHoverActiveState):
2061         * rendering/RenderListBox.cpp:
2062         (WebCore::RenderListBox::isPointInScrollbar):
2063         * rendering/RenderObject.cpp:
2064         (WebCore::RenderObject::hitTest):
2065         (WebCore::RenderObject::setInnerNode):
2066         (WebCore::RenderObject::nodeAtPoint):
2067         * rendering/RenderObject.h:
2068         * rendering/RenderPath.cpp:
2069         (WebCore::RenderPath::nodeAtPoint):
2070         * rendering/RenderSVGImage.cpp:
2071         (WebCore::RenderSVGImage::nodeAtPoint):
2072         * rendering/RenderSVGText.cpp:
2073         (WebCore::RenderSVGText::nodeAtPoint):
2074         * rendering/RenderTableRow.cpp:
2075         (WebCore::RenderTableRow::nodeAtPoint):
2076         * rendering/RenderTableRow.h:
2077         * rendering/RenderTableSection.cpp:
2078         (WebCore::RenderTableSection::nodeAtPoint):
2079         * rendering/RenderTableSection.h:
2080         * rendering/RenderTextControl.cpp:
2081         (WebCore::RenderTextControl::nodeAtPoint):
2082         * rendering/RootInlineBox.cpp:
2083         (WebCore::RootInlineBox::nodeAtPoint):
2084         * rendering/RootInlineBox.h:
2085
2086 2006-10-29  Adam Roben  <aroben@apple.com>
2087
2088         More semi-fixes.
2089
2090         * page/Page.cpp: Forgot to wrap the actual definition of
2091         setDefersLoading() in PLATFORM(MAC).
2092         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2093
2094 2006-10-29  Adam Roben  <aroben@apple.com>
2095
2096         Build semi-fix.
2097
2098         Move all FrameLoader-related code in Page.{cpp,h} within #if
2099         PLATFORM(MAC), since this class currently only exists on Mac.
2100
2101         * page/Page.cpp:
2102         * page/Page.h:
2103
2104 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2105
2106         build fix.
2107         
2108         * platform/PlatformString.h:
2109         (WebCore::String::operator NSString*):
2110
2111 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2112
2113         Rolled out accidental commit.
2114         
2115         * platform/AtomicString.h:
2116         (WebCore::AtomicString::AtomicString):
2117         (WebCore::AtomicString::operator NSString*):
2118
2119 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2120
2121         RS by Darin.
2122
2123         Rolled out change to map NULL Strings to nil NSStrings because it caused
2124         even more AppKit crashes. Maybe we should remove the NSString * operator
2125         entirely, since its use is not straight-forward, and require callers to
2126         specify explicitly whether they tolerate NULL.
2127         
2128         * platform/AtomicString.h:
2129         * platform/PlatformString.h:
2130         (WebCore::String::operator NSString*):
2131         * platform/mac/TextFieldMac.mm:
2132         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2133
2134 2006-10-29  Darin Adler  <darin@apple.com>
2135
2136         Reviewed by Geoff.
2137
2138         - fixed storage leak showing up on the buildbot
2139
2140         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2141         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2142
2143 2006-10-29  Darin Adler  <darin@apple.com>
2144
2145         Rubber stamped by Adam.
2146
2147         - renamed WebFrameLoaderClient to match the class name inside it
2148
2149         * loader/mac/WebFrameLoaderClient.h: Removed.
2150         * loader/FrameLoaderClient.h: Moved it here.
2151
2152         * WebCore.xcodeproj/project.pbxproj: Updated project.
2153
2154         * bridge/mac/FrameMac.mm: Updated includes.
2155         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2156         * loader/mac/FrameLoader.mm: Ditto.
2157         * loader/mac/WebLoader.h: Ditto.
2158
2159 2006-10-29  Darin Adler  <darin@apple.com>
2160
2161         Reviewed by Mitz.
2162
2163         - fix crash visible on buildbot and also when running the test
2164           anchor-image-scrolled-x-y.html under libgmalloc
2165
2166         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2167         now that the class is named ResourceHandle.
2168         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2169         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2170         a local RefPtr before calling finishJobAndHandle, since we might get
2171         cancelled inside that function, so we should not rely on m_handle to
2172         keep the ResourceHandle alive.
2173         (WebCore::SubresourceLoader::didFail): Ditto.
2174         (WebCore::SubresourceLoader::didCancel): Ditto.
2175
2176 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2177
2178         - build fix
2179
2180         * platform/network/mac/ResourceHandleMac.mm:
2181
2182 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2183
2184         Rubber stamped by Darin.
2185
2186         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2187
2188         * CMakeLists.txt:
2189         * Projects/gdk/webcore-gdk.bkl:
2190         * WebCore.vcproj/WebCore/WebCore.vcproj:
2191         * WebCore.xcodeproj/project.pbxproj:
2192         * WebCoreSources.bkl:
2193         * bridge/mac/FrameMac.mm:
2194         * bridge/win/FrameWin.cpp:
2195         * dom/XMLTokenizer.cpp:
2196         * loader/Cache.cpp:
2197         * loader/CachedResource.h:
2198         * loader/LoaderFunctions.h:
2199         * loader/icon/IconLoader.cpp:
2200         (IconLoader::startLoading):
2201         (IconLoader::didReceiveData):
2202         (IconLoader::didFinishLoading):
2203         * loader/icon/IconLoader.h:
2204         * loader/loader.cpp:
2205         (WebCore::Loader::servePendingRequests):
2206         (WebCore::Loader::receivedAllData):
2207         (WebCore::Loader::receivedResponse):
2208         (WebCore::Loader::didReceiveData):
2209         (WebCore::Loader::cancelRequests):
2210         (WebCore::Loader::jobForRequest):
2211         * loader/loader.h:
2212         * loader/mac/IconLoaderMac.mm:
2213         (IconLoader::receivedResponse):
2214         * loader/mac/LoaderFunctionsMac.mm:
2215         * loader/mac/WebLoader.h:
2216         * loader/mac/WebSubresourceLoader.h:
2217         * loader/mac/WebSubresourceLoader.mm:
2218         (WebCore::SubresourceLoader::SubresourceLoader):
2219         (WebCore::SubresourceLoader::create):
2220         * platform/gdk/FrameGdk.cpp:
2221         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2222         (WebCore::FrameGdkClientDefault::openURL):
2223         (WebCore::FrameGdkClientDefault::submitForm):
2224         (WebCore::FrameGdkClientDefault::receivedResponse):
2225         (WebCore::FrameGdkClientDefault::didReceiveData):
2226         (WebCore::FrameGdkClientDefault::receivedAllData):
2227         * platform/gdk/FrameGdk.h:
2228         * platform/gdk/TemporaryLinkStubs.cpp:
2229         (WebCore::ServeSynchronousRequest):
2230         (WebCore::ResourceHandle::assembleResponseHeaders):
2231         (WebCore::ResourceHandle::retrieveCharset):
2232         * platform/network/ResourceHandle.cpp: Added.
2233         (WebCore::ResourceHandle::ResourceHandle):
2234         (WebCore::ResourceHandle::create):
2235         (WebCore::ResourceHandle::isErrorPage):
2236         (WebCore::ResourceHandle::error):
2237         (WebCore::ResourceHandle::setError):
2238         (WebCore::ResourceHandle::responseEncoding):
2239         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2240         (WebCore::ResourceHandle::kill):
2241         (WebCore::ResourceHandle::requestHeaders):
2242         (WebCore::ResourceHandle::url):
2243         (WebCore::ResourceHandle::postData):
2244         (WebCore::ResourceHandle::method):
2245         (WebCore::ResourceHandle::client):
2246         * platform/network/ResourceHandle.h: Added.
2247         (WebCore::ResourceHandle::getInternal):
2248         * platform/network/ResourceHandleClient.h: Added.
2249         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2250         (WebCore::ResourceHandleClient::didReceiveData):
2251         (WebCore::ResourceHandleClient::didFinishLoading):
2252         (WebCore::ResourceHandleClient::receivedRedirect):
2253         (WebCore::ResourceHandleClient::receivedResponse):
2254         (WebCore::ResourceHandleClient::receivedAllData):
2255         * platform/network/ResourceHandleInternal.h: Added.
2256         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2257         * platform/network/ResourceLoader.cpp: Removed.
2258         * platform/network/ResourceLoader.h: Removed.
2259         * platform/network/ResourceLoaderClient.h: Removed.
2260         * platform/network/ResourceLoaderInternal.h: Removed.
2261         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2262         (WebCore::willSendRequest):
2263         (WebCore::didReceiveResponse):
2264         (WebCore::didReceiveData):
2265         (WebCore::didFinishLoading):
2266         (WebCore::didFail):
2267         (WebCore::willCacheResponse):
2268         (WebCore::didReceiveChallenge):
2269         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2270         (WebCore::ResourceHandle::~ResourceHandle):
2271         (WebCore::ResourceHandle::start):
2272         (WebCore::ResourceHandle::cancel):
2273         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2274         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2275         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2276         (WebCore::ResourceHandle::~ResourceHandle):
2277         (WebCore::ResourceHandle::start):
2278         (WebCore::ResourceHandle::cancel):
2279         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2280         (WebCore::ResourceHandleManager::ResourceHandleManager):
2281         (WebCore::ResourceHandleManager::get):
2282         (WebCore::ResourceHandleManager::useSimpleTransfer):
2283         (WebCore::writeCallback):
2284         (WebCore::ResourceHandleManager::downloadTimerCallback):
2285         (WebCore::ResourceHandleManager::remove):
2286         (WebCore::ResourceHandleManager::add):
2287         (WebCore::ResourceHandleManager::cancel):
2288         * platform/network/gdk/ResourceHandleManager.h: Added.
2289         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2290         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2291         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2292         * platform/network/mac/ResourceHandleMac.mm: Added.
2293         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2294         (WebCore::ResourceHandle::~ResourceHandle):
2295         (WebCore::ResourceHandle::start):
2296         (WebCore::ResourceHandle::assembleResponseHeaders):
2297         (WebCore::ResourceHandle::retrieveResponseEncoding):
2298         (WebCore::ResourceHandle::receivedResponse):
2299         (WebCore::ResourceHandle::cancel):
2300         (WebCore::ResourceHandle::redirectedToURL):
2301         (WebCore::ResourceHandle::addData):
2302         (WebCore::ResourceHandle::finishJobAndHandle):
2303         (WebCore::ResourceHandle::reportError):
2304         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2305         * platform/network/qt/ResourceHandleManager.cpp: Added.
2306         (WebCore::ResourceHandleManager::ResourceHandleManager):
2307         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2308         (WebCore::ResourceHandleManager::self):
2309         (WebCore::ResourceHandleManager::slotData):
2310         (WebCore::ResourceHandleManager::slotMimetype):
2311         (WebCore::ResourceHandleManager::slotResult):
2312         (WebCore::ResourceHandleManager::remove):
2313         (WebCore::ResourceHandleManager::add):
2314         (WebCore::ResourceHandleManager::cancel):
2315         * platform/network/qt/ResourceHandleManager.h: Added.
2316         * platform/network/qt/ResourceHandleQt.cpp: Added.
2317         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2318         (WebCore::ResourceHandle::~ResourceHandle):
2319         (WebCore::ResourceHandle::start):
2320         (WebCore::ResourceHandle::cancel):
2321         (WebCore::ResourceHandle::assembleResponseHeaders):
2322         (WebCore::ResourceHandle::retrieveResponseEncoding):
2323         (WebCore::ResourceHandle::receivedResponse):
2324         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2325         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2326         * platform/network/qt/ResourceLoaderManager.h: Removed.
2327         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2328         * platform/network/win/ResourceHandleWin.cpp: Added.
2329         (WebCore::):
2330         (WebCore::addToOutstandingJobs):
2331         (WebCore::lookupResourceHandle):
2332         (WebCore::ResourceHandleWndProc):
2333         (WebCore::initializeOffScreenResourceHandleWindow):
2334         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2335         (WebCore::ResourceHandle::~ResourceHandle):
2336         (WebCore::ResourceHandle::onHandleCreated):
2337         (WebCore::ResourceHandle::onRequestRedirected):
2338         (WebCore::ResourceHandle::onRequestComplete):
2339         (WebCore::ResourceHandle::start):
2340         (WebCore::ResourceHandle::fileLoadTimer):
2341         (WebCore::ResourceHandle::cancel):
2342         (WebCore::ResourceHandle::setHasReceivedResponse):
2343         (WebCore::ResourceHandle::hasReceivedResponse):
2344         * platform/network/win/ResourceHandleWin.h: Added.
2345         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2346         * platform/network/win/ResourceLoaderWin.h: Removed.
2347         * platform/qt/FrameQt.cpp:
2348         * platform/qt/FrameQtClient.cpp:
2349         (WebCore::FrameQtClientDefault::openURL):
2350         (WebCore::FrameQtClientDefault::submitForm):
2351         (WebCore::FrameQtClientDefault::receivedResponse):
2352         (WebCore::FrameQtClientDefault::didReceiveData):
2353         (WebCore::FrameQtClientDefault::receivedAllData):
2354         * platform/qt/FrameQtClient.h:
2355         * platform/win/TemporaryLinkStubs.cpp:
2356         (WebCore::ResourceHandle::assembleResponseHeaders):
2357         (WebCore::ResourceHandle::retrieveResponseEncoding):
2358         (WebCore::ServeSynchronousRequest):
2359         * xml/XSLTProcessor.cpp:
2360         * xml/xmlhttprequest.cpp:
2361         (WebCore::XMLHttpRequest::send):
2362         (WebCore::XMLHttpRequest::didFinishLoading):
2363         (WebCore::XMLHttpRequest::receivedRedirect):
2364         (WebCore::XMLHttpRequest::didReceiveData):
2365         * xml/xmlhttprequest.h:
2366
2367 t2006-10-29  Darin Adler  <darin@apple.com>
2368
2369         Reviewed by Maciej.
2370
2371         - eliminate use of NSArray to carry form data around
2372
2373         * WebCore.exp:
2374         * WebCore.xcodeproj/project.pbxproj:
2375         * bridge/mac/FormDataMac.h: Removed.
2376         * bridge/mac/FormDataMac.mm: Removed.
2377         * bridge/mac/FrameMac.h:
2378         * bridge/mac/WebCoreFrameBridge.h:
2379         * bridge/mac/WebCoreFrameBridge.mm:
2380         * html/HTMLFormElement.cpp:
2381         (WebCore::HTMLFormElement::submit):
2382         * loader/FormData.h:
2383         (WebCore::FormData::isEmpty):
2384         * loader/mac/FrameLoader.h:
2385         * loader/mac/FrameLoader.mm:
2386         (WebCore::FrameLoader::load):
2387         (WebCore::FrameLoader::post):
2388         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2389         (WebCore::FrameLoader::loadResourceSynchronously):
2390         * loader/mac/LoaderFunctionsMac.mm:
2391         (WebCore::ServeSynchronousRequest):
2392         * loader/mac/WebFormDataStream.h:
2393         * loader/mac/WebFormDataStream.m:
2394         (WebCore::pairRetain):
2395         (WebCore::pairRelease):
2396         (WebCore::pairEqual):
2397         (WebCore::pairHash):
2398         (WebCore::closeCurrentStream):
2399         (WebCore::scheduleWithPair):
2400         (WebCore::advanceCurrentStream):
2401         (WebCore::openNextStream):
2402         (WebCore::formCreate):
2403         (WebCore::formFinalize):
2404         (WebCore::formOpen):
2405         (WebCore::formRead):
2406         (WebCore::formCanRead):
2407         (WebCore::formClose):
2408         (WebCore::formSchedule):
2409         (WebCore::formUnschedule):
2410         (WebCore::formEventCallback):
2411         (WebCore::setHTTPBody):
2412         * loader/mac/WebSubresourceLoader.h:
2413         * loader/mac/WebSubresourceLoader.mm:
2414         (WebCore::SubresourceLoader::create):
2415         * platform/network/mac/ResourceLoaderMac.mm:
2416
2417 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2418
2419         Reviewed by Darin.
2420
2421         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2422
2423         * loader/mac/WebSubresourceLoader.h:
2424         * loader/mac/WebSubresourceLoader.mm:
2425         (WebCore::SubresourceLoader::create):
2426         * platform/network/mac/ResourceLoaderMac.mm:
2427         (WebCore::ResourceLoader::start):
2428
2429 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2430
2431         Reviewed by Darin.
2432
2433         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2434
2435         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2436         
2437         * WebCore.xcodeproj/project.pbxproj:
2438         * bridge/mac/WebCoreFrameBridge.h:
2439         * loader/mac/FrameLoader.h:
2440         * loader/mac/FrameLoader.mm:
2441         * loader/mac/LoaderFunctionsMac.mm:
2442         * loader/mac/WebLoader.h:
2443         * loader/mac/WebSubresourceLoader.h:
2444         * loader/mac/WebSubresourceLoader.mm:
2445         (WebCore::SubresourceLoader::SubresourceLoader):
2446         (WebCore::SubresourceLoader::create):
2447         (WebCore::SubresourceLoader::willSendRequest):
2448         (WebCore::SubresourceLoader::didReceiveResponse):
2449         (WebCore::SubresourceLoader::didReceiveData):
2450         (WebCore::SubresourceLoader::didFinishLoading):
2451         (WebCore::SubresourceLoader::didFail):
2452         (WebCore::SubresourceLoader::didCancel):
2453         * platform/network/ResourceLoader.h:
2454         * platform/network/ResourceLoaderInternal.h:
2455         * platform/network/mac/ResourceLoaderMac.mm:
2456         (WebCore::ResourceLoader::~ResourceLoader):
2457         (WebCore::ResourceLoader::start):
2458         (WebCore::ResourceLoader::receivedResponse):
2459         (WebCore::ResourceLoader::cancel):
2460         (WebCore::ResourceLoader::redirectedToURL):
2461         (WebCore::ResourceLoader::addData):
2462         (WebCore::ResourceLoader::finishJobAndHandle):
2463         (WebCore::ResourceLoader::reportError):
2464         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2465         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2466         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2467
2468 2006-10-28  Darin Adler  <darin@apple.com>
2469
2470         Reviewed by Maciej.
2471
2472         - eliminated the use of Objective-C for the policy decider
2473           machinery, obviating the need for WebPolicyDecider,
2474           WebCoreFrameLoaderAsDelegate, and
2475           WebCoreMainResourceLoaderAsPolicyDelegate
2476
2477         - grouped the state related to policy decisions into a PolicyCheck
2478           class to simplify the FrameLoader logic
2479
2480         - removed six methods from the bridge, reducing FrameLoader's use of
2481           the bridge to a single method
2482
2483         - changed form state to always use HashMap instead of NSDictionary
2484
2485         - moved the defersLoading flag from WebView to WebCore::Page
2486           and changed code to consistently call it defersLoading rather
2487           than defersCallbacks
2488
2489         - updated for rename of PassRefPtr::release to releaseRef
2490         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2491         - cleaned up kjs_binding.h a bit
2492         - cleaned up FrameMac.h a bit
2493
2494         * loader/mac/WebPolicyDecider.h: Removed.
2495         * loader/mac/WebPolicyDecider.mm: Removed.
2496         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2497
2498         * WebCore.exp:
2499         * bindings/js/kjs_binding.cpp:
2500         (KJS::ScriptInterpreter::ScriptInterpreter):
2501         (KJS::ScriptInterpreter::wasRunByUserGesture):
2502         * bindings/js/kjs_binding.h:
2503         (KJS::ScriptInterpreter::setCurrentEvent):
2504         (KJS::ScriptInterpreter::setInlineCode):
2505         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2506         (KJS::ScriptInterpreter::getCurrentEvent):
2507         (KJS::cacheDOMObject):
2508         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2509         * bridge/AXObjectCache.h:
2510         * bridge/mac/BrowserExtensionMac.mm:
2511         (WebCore::BrowserExtensionMac::createNewWindow):
2512         * bridge/mac/FrameMac.h:
2513         * bridge/mac/FrameMac.mm:
2514         (WebCore::FrameMac::loadRequest):
2515         (WebCore::FrameMac::submitForm):
2516         (WebCore::FrameMac::urlSelected):
2517         (WebCore::FrameMac::userAgent):
2518         (WebCore::FrameMac::passMouseDownEventToWidget):
2519         (WebCore::FrameMac::handleMouseMoveEvent):
2520         * bridge/mac/PageMac.mm:
2521         (WebCore::Page::Page):
2522         * bridge/mac/WebCoreEditCommand.mm:
2523         * bridge/mac/WebCoreFrameBridge.h:
2524         * bridge/mac/WebCoreFrameBridge.mm:
2525         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
2526         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2527         * css/CSSComputedStyleDeclaration.cpp:
2528         (WebCore::):
2529         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2530         * css/CSSPrimitiveValue.cpp:
2531         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2532         (WebCore::CSSPrimitiveValue::cleanup):
2533         (WebCore::CSSPrimitiveValue::cssText):
2534         * css/CSSPrimitiveValue.h:
2535         (WebCore::CSSPrimitiveValue::):
2536         * css/CSSValueList.cpp:
2537         (WebCore::CSSValueList::append):
2538         * css/cssparser.cpp:
2539         (WebCore::CSSParser::parseValue):
2540         * css/cssparser.h:
2541         * css/cssstyleselector.cpp:
2542         (WebCore::CSSStyleSelector::applyProperty):
2543         * dom/Document.cpp:
2544         (WebCore::Document::Document):
2545         (WebCore::Document::updateSelection):
2546         (WebCore::Document::implicitClose):
2547         (WebCore::Document::setFocusNode):
2548         * dom/Document.h:
2549         * editing/ReplaceSelectionCommand.h:
2550         * html/HTMLParser.cpp:
2551         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2552         * loader/mac/FrameLoader.h:
2553         (WebCore::PolicyCheck::request):
2554         * loader/mac/FrameLoader.mm:
2555         (WebCore::FrameLoader::~FrameLoader):
2556         (WebCore::FrameLoader::safeLoad):
2557         (WebCore::FrameLoader::load):
2558         (WebCore::FrameLoader::open):
2559         (WebCore::FrameLoader::stopLoading):
2560         (WebCore::setAllDefersLoading):
2561         (WebCore::FrameLoader::setDefersLoading):
2562         (WebCore::FrameLoader::willSendRequest):
2563         (WebCore::FrameLoader::receivedMainResourceError):
2564         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
2565         (WebCore::FrameLoader::commitProvisionalLoad):
2566         (WebCore::FrameLoader::checkNavigationPolicy):
2567         (WebCore::FrameLoader::checkContentPolicy):
2568         (WebCore::FrameLoader::cancelContentPolicyCheck):
2569         (WebCore::FrameLoader::stopPolicyCheck):
2570         (WebCore::FrameLoader::checkNewWindowPolicy):
2571         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
2572         (WebCore::FrameLoader::continueAfterNavigationPolicy):
2573         (WebCore::FrameLoader::continueAfterContentPolicy):
2574         (WebCore::FrameLoader::continueAfterWillSubmitForm):
2575         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
2576         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2577         (WebCore::FrameLoader::closeDocument):
2578         (WebCore::FrameLoader::transitionToCommitted):
2579         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
2580         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
2581         (WebCore::FrameLoader::post):
2582         (WebCore::FrameLoader::detachFromParent):
2583         (WebCore::FrameLoader::addExtraFieldsToRequest):
2584         (WebCore::PolicyCheck::PolicyCheck):
2585         (WebCore::PolicyCheck::clear):
2586         (WebCore::PolicyCheck::set):
2587         (WebCore::PolicyCheck::call):
2588         (WebCore::PolicyCheck::dropRequest):
2589         (WebCore::FrameLoaderClient::~FrameLoaderClient):
2590         * loader/mac/WebFormState.h:
2591         * loader/mac/WebFormState.mm:
2592         * loader/mac/WebFrameLoaderClient.h:
2593         * loader/mac/WebLoader.h:
2594         (WebCore::WebResourceLoader::defersLoading):
2595         * loader/mac/WebLoader.mm:
2596         (WebCore::WebResourceLoader::WebResourceLoader):
2597         (WebCore::WebResourceLoader::load):
2598         (WebCore::WebResourceLoader::setDefersLoading):
2599         * loader/mac/WebMainResourceLoader.h:
2600         * loader/mac/WebMainResourceLoader.mm:
2601         (WebCore::MainResourceLoader::MainResourceLoader):
2602         (WebCore::MainResourceLoader::releaseDelegate):
2603         (WebCore::MainResourceLoader::didCancel):
2604         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
2605         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
2606         (WebCore::MainResourceLoader::willSendRequest):
2607         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
2608         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2609         (WebCore::MainResourceLoader::didReceiveResponse):
2610         (WebCore::MainResourceLoader::didReceiveData):
2611         (WebCore::MainResourceLoader::didFinishLoading):
2612         (WebCore::MainResourceLoader::didFail):
2613         (WebCore::MainResourceLoader::loadNow):
2614         (WebCore::MainResourceLoader::load):
2615         (WebCore::MainResourceLoader::setDefersLoading):
2616         * page/Frame.cpp:
2617         (WebCore::Frame::paint):
2618         * page/FrameView.cpp:
2619         (WebCore::FrameView::layout):
2620         * page/FrameView.h:
2621         * page/Page.cpp:
2622         (WebCore::Page::setDefersLoading):
2623         * page/Page.h:
2624         (WebCore::Page::defersLoading):
2625         * platform/DeprecatedString.h:
2626         * platform/DeprecatedStringList.h:
2627         * platform/FontFallbackList.h:
2628         * platform/PlatformKeyboardEvent.h:
2629         * platform/PlatformMouseEvent.h:
2630         * platform/PlatformWheelEvent.h:
2631         * platform/mac/ClipboardMac.h:
2632         * platform/mac/ClipboardMac.mm:
2633         (WebCore::ClipboardMac::setDragImage):
2634         (WebCore::ClipboardMac::dragNSImage):
2635         (WebCore::ClipboardMac::sourceOperation):
2636         (WebCore::ClipboardMac::destinationOperation):
2637         * rendering/RenderObject.cpp:
2638         (WebCore::RenderObject::setStyle):
2639         * rendering/break_lines.cpp:
2640         (WebCore::nextBreakablePosition):
2641
2642 2006-10-28  Adam Roben  <aroben@apple.com>
2643
2644         Reviewed by Maciej.
2645
2646         Fix layout tests that broke after r17399. Mitz discovered that the
2647         failures were caused by HitTestResult::m_point being uninitialized
2648         much of the time. HitTestResults are now always constructed with a
2649         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
2650         point instead of being passed one explicitly.
2651
2652         * WebCore.exp: Change constructor symbol.
2653         * bridge/mac/FrameMac.mm:
2654         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
2655         hitTest().
2656         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
2657         * bridge/mac/WebCoreAXObject.mm:
2658         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
2659         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
2660         * dom/Document.cpp:
2661         (WebCore::Document::elementFromPoint): Ditto.
2662         (WebCore::Document::prepareMouseEvent): Ditto.
2663         * page/Frame.cpp:
2664         (WebCore::Frame::isPointInsideSelection): Ditto.
2665         (WebCore::Frame::hitTestResultAtPoint): Ditto.
2666         * page/FrameView.cpp:
2667         (WebCore::FrameView::handleWheelEvent): Ditto.
2668         * rendering/HitTestResult.cpp:
2669         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
2670         passed point.
2671         * rendering/HitTestResult.h: Update constructor declaration.
2672         * rendering/RenderLayer.cpp:
2673         (WebCore::RenderLayer::autoscroll): Update to new constructor and
2674         hitTest().
2675         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
2676         HitTestResult instead of being passed one.
2677         (WebCore::RenderLayer::hitTestLayer): Ditto.
2678         * rendering/RenderLayer.h: Update declarations.
2679
2680 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
2681
2682         Reviewed by Anders.
2683
2684         Fix Qt/Linux build.
2685
2686         * CMakeLists.txt:
2687         * platform/qt/FrameQtClient.cpp:
2688         (WebCore::numRequests):
2689         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
2690         * platform/qt/PopupMenuQt.cpp:
2691         (WebCore::PopupMenu::updateFromElement):
2692
2693 2006-10-28  David Carson  <dacarson@gmail.com>
2694
2695         Tweaked by Sam. Reviewed by Brady.
2696
2697         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
2698         Initialize m_modifyBiasSet to false, as it sometimes gets 
2699         used before it has been initalized.
2700
2701         * editing/SelectionController.cpp:
2702         (WebCore::SelectionController::SelectionController):
2703
2704 2006-10-28  Beth Dakin  <bdakin@apple.com>
2705
2706         Reviewed by Darin.
2707
2708         This is the WebCore half of pushing elementAtPoint and the backend 
2709         of WebElementDictionary into WebCore. Most of the changes below are 
2710         to accommodate one of the following:
2711                 
2712         -NodeInfo is now a stand-alone class called HitTestResult. 
2713                 Previously it was defined in RenderObject.h, but not for 
2714                 any particular reason. The WebElementDictionary 
2715                 functionality that was pushed into WebCore has been pushed 
2716                 specifically into the this class. In fact, 
2717                 WebElementDictionary now keeps a HitTestResult as a member 
2718                 varibale.
2719                 
2720         -The enumeration AccessPolicy is now called 
2721                 ClipboardAccessPolicy and is defined in its own header. It 
2722                 was previously defined in ClipboardMac.h, but is now 
2723                 defined independently to avoid including ClipboardMac.h 
2724                 from within FrameMac.h since FrameMac.h is now included in 
2725                 WebElementDictionary.m in WebKit.
2726                 
2727         -Element now has a virtual target() for the sake of 
2728                 NodeInfo::targetFrame() 
2729
2730         * WebCore.exp: Several WebCore functions are newly called from 
2731         WebKit, so they have been added here. 
2732         * WebCore.xcodeproj/project.pbxproj:
2733         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
2734         to ClipboardMac.
2735         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
2736         * bridge/mac/FrameMac.mm:
2737         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
2738         and HitTestResult changes.
2739         (WebCore::FrameMac::eventMayStartDrag): Same.
2740         (WebCore::FrameMac::handleMouseMoveEvent): Same.
2741         (WebCore::FrameMac::dispatchCPPEvent): Same.
2742         (WebCore::FrameMac::mayDHTMLCut): Same.
2743         (WebCore::FrameMac::mayDHTMLCopy): Same.
2744         (WebCore::FrameMac::mayDHTMLPaste): Same.
2745         (WebCore::FrameMac::tryDHTMLCut): Same
2746         (WebCore::FrameMac::tryDHTMLCopy): Same.
2747         (WebCore::FrameMac::tryDHTMLPaste): Same.
2748         * bridge/mac/WebCoreAXObject.mm:
2749         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
2750         HitTestResult changes.
2751         (-[WebCoreAXObject accessibilityHitTest:]): Same.
2752         * bridge/mac/WebCoreFrameBridge.h: Same.
2753         * bridge/mac/WebCoreFrameBridge.mm:
2754         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
2755         ClipboardAccessPolicy changes.
2756         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
2757         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
2758         * dom/Document.cpp:
2759         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
2760         changes.
2761         (WebCore::Document::prepareMouseEvent): Same.
2762         * dom/Element.h:
2763         (WebCore::Element::target): Now has a virtual target()
2764         * html/HTMLAnchorElement.h: Same.
2765         * html/HTMLAreaElement.cpp:
2766         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
2767         changes.
2768         * html/HTMLAreaElement.h: Virtual target()
2769         * html/HTMLBaseElement.h:
2770         (WebCore::HTMLBaseElement::target): Same.
2771         * html/HTMLFormElement.h: Same.
2772         * html/HTMLLinkElement.h: Same.
2773         * html/HTMLMapElement.cpp:
2774         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
2775         changes.
2776         * html/HTMLMapElement.h: Same.
2777         * page/Frame.cpp:
2778         (WebCore::Frame::isPointInsideSelection): Same.
2779         (WebCore::Frame::hitTestResultAtPoint): Same. 
2780         * page/Frame.h: Same.
2781         * page/FrameView.cpp:
2782         (WebCore::FrameView::handleWheelEvent): Same.
2783         * platform/mac/ClipboardAccessPolicy.h: Added.
2784         (WebCore::):
2785         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
2786         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
2787         ClipboardAccessPolicy.
2788         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
2789         (WebCore::ClipboardMac::ClipboardMac):
2790         (WebCore::ClipboardMac::setAccessPolicy):
2791         (WebCore::ClipboardMac::clearData):
2792         (WebCore::ClipboardMac::clearAllData):
2793         (WebCore::ClipboardMac::getData):
2794         (WebCore::ClipboardMac::setData):
2795         (WebCore::ClipboardMac::types):
2796         (WebCore::ClipboardMac::setDragImage):
2797         (WebCore::ClipboardMac::setDropEffect):
2798         (WebCore::ClipboardMac::setEffectAllowed):
2799         * rendering/EllipsisBox.cpp:
2800         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
2801         changes.
2802         * rendering/EllipsisBox.h:
2803         * rendering/HitTestResult.cpp: Added.
2804         (WebCore::HitTestResult::HitTestResult):
2805         (WebCore::HitTestResult::~HitTestResult):
2806         (WebCore::HitTestResult::operator=):
2807         (WebCore::HitTestResult::setInnerNode):
2808         (WebCore::HitTestResult::setInnerNonSharedNode):
2809         (WebCore::HitTestResult::setURLElement):
2810         (WebCore::HitTestResult::setScrollbar):
2811         (WebCore::HitTestResult::targetFrame):
2812         (WebCore::HitTestResult::boundingBox):
2813         (WebCore::HitTestResult::isSelected):
2814         (WebCore::HitTestResult::title):
2815         * rendering/HitTestResult.h: Added.
2816         (WebCore::HitTestResult::readonly):
2817         (WebCore::HitTestResult::active):
2818         (WebCore::HitTestResult::mouseMove):
2819         (WebCore::HitTestResult::innerNode):
2820         (WebCore::HitTestResult::innerNonSharedNode):
2821         (WebCore::HitTestResult::point):
2822         (WebCore::HitTestResult::URLElement):
2823         (WebCore::HitTestResult::scrollbar):
2824         (WebCore::HitTestResult::setPoint):
2825         (WebCore::HitTestResult::setReadonly):
2826         (WebCore::HitTestResult::setActive):
2827         (WebCore::HitTestResult::setMouseMove):
2828         * rendering/InlineBox.cpp:
2829         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
2830         * rendering/InlineBox.h: Same.
2831         * rendering/InlineFlowBox.cpp:
2832         (WebCore::InlineFlowBox::nodeAtPoint): Same.
2833         * rendering/InlineFlowBox.h: Same.
2834         * rendering/InlineTextBox.cpp: 
2835         (WebCore::InlineTextBox::nodeAtPoint): Same.
2836         * rendering/InlineTextBox.h: Same.
2837         * rendering/RenderBlock.cpp:
2838         (WebCore::RenderBlock::isPointInScrollbar): Same.
2839         (WebCore::RenderBlock::nodeAtPoint): Same.
2840         * rendering/RenderBlock.h: Same.
2841         * rendering/RenderBox.cpp:
2842         (WebCore::RenderBox::nodeAtPoint): Same.
2843         * rendering/RenderBox.h: Same.
2844         * rendering/RenderFlow.cpp:
2845         (WebCore::RenderFlow::hitTestLines): Same.
2846         * rendering/RenderFlow.h: Same.
2847         * rendering/RenderForeignObject.cpp:
2848         (WebCore::RenderForeignObject::nodeAtPoint): Same.
2849         * rendering/RenderForeignObject.h: Same.
2850         * rendering/RenderFrameSet.cpp:
2851         (WebCore::RenderFrameSet::nodeAtPoint): Same.
2852         * rendering/RenderFrameSet.h: Same.
2853         * rendering/RenderImage.cpp:
2854         (WebCore::RenderImage::nodeAtPoint): Same.
2855         * rendering/RenderImage.h: Same.
2856         * rendering/RenderInline.cpp:
2857         (WebCore::RenderInline::nodeAtPoint): Same.
2858         * rendering/RenderInline.h: Same.
2859         * rendering/RenderLayer.cpp:
2860         (WebCore::RenderLayer::autoscroll): Same.
2861         (WebCore::RenderLayer::hitTest): Same.
2862         (WebCore::RenderLayer::hitTestLayer): Same.
2863         (WebCore::RenderLayer::updateHoverActiveState): Same.
2864         * rendering/RenderLayer.h: Same.
2865         * rendering/RenderListBox.cpp:
2866         (WebCore::RenderListBox::isPointInScrollbar): Same.
2867         * rendering/RenderListBox.h: Same.
2868         * rendering/RenderObject.cpp:
2869         (WebCore::RenderObject::hitTest): Same.
2870         (WebCore::RenderObject::setInnerNode): Same.
2871         (WebCore::RenderObject::nodeAtPoint): Same.
2872         * rendering/RenderObject.h: Remove NodeInfo class and forward 
2873         declare HitTestResult.
2874         * rendering/RenderPath.cpp:
2875         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
2876         changes.
2877         * rendering/RenderPath.h: Same.
2878         * rendering/RenderSVGImage.cpp:
2879         (WebCore::RenderSVGImage::nodeAtPoint): Same.
2880         * rendering/RenderSVGImage.h: Same
2881         * rendering/RenderSVGText.cpp:
2882         (WebCore::RenderSVGText::nodeAtPoint): Same.
2883         * rendering/RenderSVGText.h: Same.
2884         * rendering/RenderTableRow.cpp:
2885         (WebCore::RenderTableRow::nodeAtPoint): Same.
2886         * rendering/RenderTableRow.h: Same.
2887         * rendering/RenderTableSection.cpp:
2888         (WebCore::RenderTableSection::nodeAtPoint): Same.
2889         * rendering/RenderTableSection.h: Same.
2890         * rendering/RenderText.h: Same.
2891         (WebCore::RenderText::nodeAtPoint): Same.
2892         * rendering/RenderTextControl.cpp:
2893         (WebCore::RenderTextControl::nodeAtPoint): Same.
2894         * rendering/RenderTextControl.h: Same.
2895         * rendering/RootInlineBox.cpp:
2896         (WebCore::RootInlineBox::nodeAtPoint): Same.
2897         * rendering/RootInlineBox.h: Same.
2898
2899 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2900
2901         Reviewed by Anders.
2902
2903         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
2904         impact of fixing it again.
2905
2906         * bridge/mac/FrameMac.mm:
2907         (WebCore::FrameMac::clear):
2908
2909 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
2910
2911         Reviewed by John & Adam.
2912
2913         - assorted speedups to fix perf regression from fixing correctness regression
2914
2915         * WebCore.exp: exported new methods.
2916         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
2917         * bridge/mac/WebCoreFrameBridge.h:
2918         * bridge/mac/WebCoreFrameBridge.mm:
2919         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
2920         * loader/CachedResource.h:
2921         * loader/mac/CachedResourceMac.mm: Added.
2922         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
2923         now cached in the CachedObject.
2924         * loader/mac/FrameLoader.h:
2925         * loader/mac/FrameLoader.mm:
2926         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
2927         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
2928         * loader/mac/LoaderFunctionsMac.mm:
2929         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
2930         just call loadedResourceFromMemoryCache.
2931         * loader/mac/WebFrameLoaderClient.h:
2932
2933 2006-10-27  Oliver Hunt  <oliver@apple.com>
2934
2935         Reviewed by Maciej.
2936
2937         build fix
2938
2939         * dom/Document.cpp:
2940         (WebCore::Document::referrer):
2941
2942 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
2943
2944         Reviewed by Maciej.
2945
2946         Moved some WebCoreFrameBridge functions into FrameLoader.
2947         
2948         I had to make FrameLoader.h capable of compiling in C++-only source files
2949         by adding some forward declarations and __OBJC__ #ifdefs.
2950
2951         * WebCore.exp:
2952         * bridge/mac/FrameMac.h:
2953         * bridge/mac/FrameMac.mm:
2954         (WebCore::FrameMac::createEmptyDocument):
2955         (WebCore::FrameMac::tokenizerProcessedData):
2956         * bridge/mac/WebCoreFrameBridge.h:
2957         * bridge/mac/WebCoreFrameBridge.mm:
2958         * dom/Document.cpp:
2959         (WebCore::Document::processHttpEquiv):
2960         (WebCore::Document::referrer):
2961         * loader/LoaderFunctions.h:
2962         * loader/mac/FrameLoader.h:
2963         * loader/mac/FrameLoader.mm:
2964         (WebCore::numRequests):
2965         (WebCore::FrameLoader::numPendingOrLoadingRequests):
2966         (WebCore::FrameLoader::isReloading):
2967         (WebCore::FrameLoader::referrer):
2968         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2969         (WebCore::FrameLoader::startLoadingResource):
2970         * loader/mac/LoaderFunctionsMac.mm:
2971         (WebCore::CheckIfReloading):
2972         * page/Frame.h:
2973         * page/FrameTree.cpp:
2974         (WebCore::FrameTree::isDescendantOf):
2975         (WebCore::FrameTree::traverseNext):
2976         * page/FrameTree.h:
2977         * platform/network/mac/ResourceLoaderMac.mm:
2978         (WebCore::ResourceLoader::start):
2979
2980 2006-10-27  Timothy Hatcher  <timothy@apple.com>
2981
2982         Reviewed by Darin.
2983
2984         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2985
2986         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
2987
2988         * editing/DeleteButtonController.cpp:
2989         (WebCore::isDeletableElement):
2990         (WebCore::enclosingDeletableElement):
2991         (WebCore::DeleteButtonController::respondToChangedSelection):
2992
2993 2006-10-27  John Sullivan  <sullivan@apple.com>
2994
2995         Reviewed by Kevin Decker
2996         
2997         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
2998         you haven't not finished reading this.
2999
3000         * rendering/InlineTextBox.h:
3001         * rendering/InlineTextBox.cpp:
3002         (WebCore::InlineTextBox::paint):
3003         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3004         considered also.
3005         (WebCore::InlineTextBox::paintDocumentMarkers):
3006         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3007         markers should be painted, instead of a marker type. This avoids walking the collection of
3008         markers multiple times back to back. Now handles grammar markers.
3009
3010 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3011
3012         Reviewed by Beth.
3013
3014         Renamed Copy Files to Copy Generated Headers.
3015         Copy 4 DOM*Internal.h headers.
3016
3017         * WebCore.xcodeproj/project.pbxproj:
3018         * bindings/scripts/CodeGeneratorObjC.pm:
3019
3020 2006-10-27  John Sullivan  <sullivan@apple.com>
3021
3022         Reviewed by Anders
3023
3024         * WebCore.exp:
3025         exported symbol for FrameMac->advanceToNextSpelling()
3026         
3027         * bridge/mac/WebCoreFrameBridge.h:
3028         * bridge/mac/WebCoreFrameBridge.mm:
3029         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3030
3031 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3032
3033         Reviewed by harrison
3034         
3035         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3036         REGRESSION: First newline missing from textarea's value
3037         
3038         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3039         
3040         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3041         (the line break) then a br to prevent the '\n' from collapsing, since the 
3042         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3043         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3044         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3045         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3046         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3047         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3048         the shadow div will be placeholders or collapsed.
3049         
3050         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3051         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3052         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3053         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3054         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3055         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3056         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3057         before it.
3058         
3059         * editing/CompositeEditCommand.cpp:
3060         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3061         a br or '\n' if content inserted just before it will cause it to collapse.
3062         * editing/CompositeEditCommand.h:
3063         * editing/InsertLineBreakCommand.cpp:
3064         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3065         to prevent a collapse as was used for the line break.  Fixed comments.
3066         * editing/InsertTextCommand.cpp:
3067         (WebCore::InsertTextCommand::input): Call the renamed function.
3068         
3069 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3070
3071         Reviewed by Brady.
3072
3073         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3074         String became an empty NSString *, instead of nil. This will become important
3075         as we start using this conversion more.
3076         
3077         Added work-around for AppKit crash that semantic accuracy revealed.
3078         
3079         No testcase because I don't think there's a way to reflect this change
3080         in a webpage yet.
3081
3082         * platform/PlatformString.h:
3083         (WebCore::String::operator NSString*):
3084         * platform/mac/TextFieldMac.mm:
3085         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3086
3087 2006-10-27  David Harrison  <harrison@apple.com>
3088
3089         Reviewed by Maciej,
3090
3091         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3092
3093         * bridge/mac/WebCoreAXObject.mm:
3094         (blockquoteLevel):
3095         Calculate and return the blockquote level of the element.
3096         
3097         (AXAttributeStringSetBlockquoteLevel):
3098         Add, if non-zero, or clear the block quote level attribute.
3099         
3100         (AXAttributedStringAppendText):
3101         Send AXAttributeStringSetBlockquoteLevel.
3102
3103 2006-10-27  Darin Adler  <darin@apple.com>
3104
3105         - fix one error in the Qt build
3106
3107         * platform/qt/GraphicsContextQt.cpp:
3108         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3109         Updated.
3110
3111 2006-10-27  Darin Adler  <darin@apple.com>
3112
3113         Reviewed by Maciej.
3114
3115         * WebCore.exp: Export more symbols needed by WebKit.
3116
3117 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3118
3119         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3120
3121         Fixed layout test crash. Oops.
3122         
3123         * loader/mac/WebDocumentLoader.mm:
3124         (WebCore::canonicalizedTitle):
3125
3126 2006-10-26  John Sullivan  <sullivan@apple.com>
3127
3128         Reviewed by Brady
3129         
3130         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3131         
3132         This restores some of the nil-handling that was implicit before some of the code was converted from
3133         Objective-C to C++.
3134
3135         * bridge/mac/FrameMac.mm:
3136         (WebCore::FrameMac::loadRequest):
3137         handle nil FrameMac
3138         
3139         * bridge/mac/WebCoreFrameBridge.mm:
3140         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3141         handle nil Frame
3142
3143 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3144
3145         Reviewed by Darin, Maciej.
3146
3147         Removed many uses of NSString *.
3148         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
3149         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
3150         
3151         PLT says no performance regression.
3152         
3153         * WebCore.exp:
3154         * bridge/mac/WebCoreFrameBridge.mm:
3155         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3156         * loader/mac/FrameLoader.h:
3157         * loader/mac/FrameLoader.mm:
3158         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3159         (WebCore::FrameLoader::load):
3160         (WebCore::FrameLoader::canShowMIMEType):
3161         (WebCore::FrameLoader::representationExistsForURLScheme):
3162         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3163         (WebCore::FrameLoader::checkContentPolicy):
3164         (WebCore::FrameLoader::reloadAllowingStaleData):
3165         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
3166         (WebCore::FrameLoader::checkNewWindowPolicy):
3167         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3168         (WebCore::FrameLoader::transitionToCommitted):
3169         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3170         (WebCore::FrameLoader::post):
3171         * loader/mac/WebDocumentLoader.h:
3172         * loader/mac/WebDocumentLoader.mm:
3173         (WebCore::DocumentLoader::doesProgressiveLoad):
3174         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3175         (WebCore::DocumentLoader::title):
3176         (WebCore::DocumentLoader::setOverrideEncoding):
3177         (WebCore::DocumentLoader::overrideEncoding):
3178         (WebCore::DocumentLoader::setTitle):
3179         * loader/mac/WebFrameLoaderClient.h:
3180         * loader/mac/WebMainResourceLoader.mm:
3181         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3182
3183 2006-10-26  Timothy Hatcher  <timothy@apple.com>
3184
3185         Reviewed by Adam.
3186
3187         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
3188
3189         The main table at nytimes.com has a fixed width of 874px, but the table ends
3190         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
3191         this. The other bug was a missing top and left of 0px on the container element,
3192         causing the deletion UI to sometimes be offset below the table.
3193
3194         Now check for the element's renderer at the beginning of show() and
3195         return early if it is null.
3196
3197         * editing/DeleteButtonController.cpp:
3198         (WebCore::DeleteButtonController::updateOutlineStyle):
3199         (WebCore::DeleteButtonController::show):
3200
3201 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3202
3203         Build fix.
3204
3205         * html/CanvasRenderingContext2D.cpp:
3206         Include MathExtras.h
3207         
3208 2006-10-26  John Sullivan  <sullivan@apple.com>
3209
3210         Reviewed by Anders.
3211
3212         Some changes to support new grammar checking code in WebKit.
3213
3214         * WebCore.exp:
3215         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
3216         
3217         * WebCore.xcodeproj/project.pbxproj:
3218         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
3219         Made HTMLCollection.h private because Document.h uses it.
3220         
3221         * bridge/mac/WebCoreFrameBridge.h:
3222         * bridge/mac/WebCoreFrameBridge.mm:
3223         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
3224
3225 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3226
3227         Reviewed by Brady.
3228
3229         Add reverseFind to String and use it instead of findRev.
3230         Use CString instead of DeprecatedCString in one place.
3231         
3232         * html/HTMLFormElement.cpp:
3233         (WebCore::HTMLFormElement::formData):
3234         * ksvg2/svg/SVGURIReference.cpp:
3235         (WebCore::SVGURIReference::getTarget):
3236         * loader/Decoder.cpp:
3237         (WebCore::Decoder::checkForCSSCharset):
3238         * platform/PlatformString.h:
3239         (WebCore::String::reverseFind):
3240         * platform/StringImpl.cpp:
3241         (WebCore::StringImpl::reverseFind):
3242         * platform/StringImpl.h:
3243
3244 2006-10-26  John Sullivan  <sullivan@apple.com>
3245
3246         Reviewed by Darin
3247         
3248         More plumbing for grammar checking. Still no grammars is checked.
3249
3250         * dom/DocumentMarker.h:
3251         (WebCore::DocumentMarker::):
3252         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
3253         
3254         * platform/GraphicsContext.h:
3255         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
3256         now takes a bool parameter for whether it represents bad grammar or a misspelling 
3257         
3258         * platform/mac/GraphicsContextMac.mm:
3259         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3260         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
3261         an existing "assert" to "ASSERT".
3262         
3263         * rendering/InlineTextBox.h:
3264         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
3265
3266         * rendering/InlineTextBox.cpp:
3267         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3268         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
3269         bad grammar or a misspelling
3270         (WebCore::InlineTextBox::paintAllMarkersOfType):
3271         now handles markers of type Grammar
3272
3273 === Safari-521.29 ===
3274         
3275 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
3276
3277         Reviewed by Mitz.
3278
3279         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
3280         Cleanup rendering code
3281
3282         - Assorted code cleanup.
3283
3284         * rendering/AutoTableLayout.cpp:
3285         * rendering/AutoTableLayout.h:
3286         (WebCore::AutoTableLayout::totalPercent):
3287         * rendering/CounterListItem.h:
3288         * rendering/CounterNode.cpp:
3289         * rendering/CounterNode.h:
3290         (WebCore::CounterNode::~CounterNode):
3291         (WebCore::CounterNode::isReset):
3292         * rendering/CounterResetNode.cpp:
3293         * rendering/CounterResetNode.h:
3294         * rendering/DataRef.h:
3295         (WebCore::DataRef::DataRef):
3296         * rendering/DeprecatedRenderSelect.h:
3297         * rendering/DeprecatedSlider.cpp:
3298         * rendering/DeprecatedSlider.h:
3299         * rendering/EllipsisBox.cpp:
3300         * rendering/EllipsisBox.h:
3301         (WebCore::EllipsisBox::EllipsisBox):
3302         * rendering/FixedTableLayout.cpp:
3303         * rendering/FixedTableLayout.h:
3304         * rendering/GapRects.h:
3305         * rendering/InlineBox.cpp:
3306         * rendering/InlineBox.h:
3307         (WebCore::InlineBox::InlineBox):
3308         (WebCore::InlineBox::setConstructed):
3309         (WebCore::InlineBox::clearTruncation):
3310         (WebCore::InlineBox::markDirty):
3311         * rendering/InlineFlowBox.cpp:
3312         * rendering/InlineFlowBox.h:
3313         (WebCore::InlineFlowBox::InlineFlowBox):
3314         (WebCore::InlineFlowBox::setConstructed):
3315         (WebCore::InlineFlowBox::setEdges):
3316         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
3317         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
3318         * rendering/InlineRunBox.h:
3319         (WebCore::InlineRunBox::paintBackgroundAndBorder):
3320         (WebCore::InlineRunBox::paintDecorations):
3321         * rendering/InlineTextBox.cpp:
3322         * rendering/InlineTextBox.h:
3323         (WebCore::InlineTextBox::InlineTextBox):
3324         (WebCore::InlineTextBox::end):
3325         (WebCore::InlineTextBox::textObject):
3326         * rendering/Length.h:
3327         (WebCore::Length::Length):
3328         * rendering/ListMarkerBox.cpp:
3329         * rendering/ListMarkerBox.h:
3330         * rendering/RenderPartObject.h:
3331         * rendering/RootInlineBox.cpp:
3332         * rendering/RootInlineBox.h:
3333         * rendering/SVGInlineFlowBox.cpp:
3334         * rendering/SVGInlineFlowBox.h:
3335         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
3336         * rendering/SVGRootInlineBox.cpp:
3337         * rendering/SVGRootInlineBox.h:
3338         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
3339         * rendering/TableLayout.h:
3340         (WebCore::TableLayout::TableLayout):
3341         (WebCore::TableLayout::~TableLayout):
3342         * rendering/bidi.h:
3343         (WebCore::BidiStatus::BidiStatus):
3344         (WebCore::BidiRun::BidiRun):
3345         * rendering/break_lines.h:
3346
3347 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
3348
3349         Reviewed by john
3350
3351         <http://bugs.webkit.org/show_bug.cgi?id=11329>
3352         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
3353         
3354         * editing/Editor.cpp:
3355         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
3356         Wrapped the plain text fragment in a style span with the document 
3357         default style so that it will appear unstyled regardless of where
3358         it is inserted.  Could have also inserted the plain text fragment 
3359         and then applied the document default style to it, but there is not 
3360         yet any redundant style prevention in ApplyStyleCommand, so this
3361         is cleaner.
3362         * editing/Editor.h:
3363         * editing/JSEditor.cpp:
3364
3365 2006-10-26  Oliver Hunt  <oliver@apple.com>
3366
3367         Reviewed by Anders.
3368         Fixes <rdar://problem/4800518> -- needed to update existing
3369         canvas path elements when transforms are performed on the
3370         context.
3371
3372         * html/CanvasRenderingContext2D.cpp:
3373         (WebCore::CanvasRenderingContext2D::scale):
3374         (WebCore::CanvasRenderingContext2D::rotate):
3375         (WebCore::CanvasRenderingContext2D::translate):
3376
3377 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
3378
3379         Reviewed by Darin.
3380
3381         Fix Qt/Linux build.
3382
3383         * platform/network/qt/ResourceLoaderManager.cpp:
3384         (WebCore::ResourceLoaderManager::slotData):
3385         (WebCore::ResourceLoaderManager::slotMimetype):
3386         (WebCore::ResourceLoaderManager::remove):
3387         (WebCore::ResourceLoaderManager::add):
3388         * platform/network/qt/ResourceLoaderQt.cpp:
3389         (WebCore::ResourceLoader::receivedResponse):
3390         * platform/qt/FrameQtClient.cpp:
3391         (WebCore::FrameQtClientDefault::openURL):
3392         * platform/qt/LoaderFunctionsQt.cpp:
3393         (WebCore::ServeSynchronousRequest):
3394
3395 2006-10-26  Adam Roben  <aroben@apple.com>
3396
3397         Reviewed by Adele.
3398
3399         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
3400         boxes (<select> elements)
3401         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
3402         should have type-ahead selection without popping up menu
3403
3404         * WebCore.xcodeproj/project.pbxproj: Version wars.
3405         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
3406         find.
3407         * html/HTMLSelectElement.cpp:
3408         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
3409         instance variables.
3410         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
3411         find on printable character presses.
3412         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
3413         redundant check that the listIndex has changed (setSelectedIndex does
3414         this for us), and fix indentation.
3415         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
3416         to an else-if.
3417         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
3418         to strip leading whitespace (including non-breaking spaces) from a
3419         string.
3420         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
3421         type-ahead find.
3422         * platform/PopupMenu.h: Added new updateFromElement() method to be
3423         called from RenderMenuList::updateFromElement().
3424         * platform/mac/PopupMenuMac.mm:
3425         (WebCore::PopupMenu::updateFromElement): While we are using
3426         NSPopUpButtonCell for our popups, this method can stay empty.
3427         * rendering/RenderListBox.cpp:
3428         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
3429         selected element.
3430         * rendering/RenderMenuList.cpp:
3431         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
3432         if it's visible.
3433
3434 2006-10-26  Darin Adler  <darin@apple.com>
3435
3436         Reviewed by Anders.
3437
3438         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
3439           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
3440
3441         * editing/ReplaceSelectionCommand.cpp:
3442         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
3443         Use two vectors instead of a hash map: more efficient, deterministic. There was no
3444         reason to use a hash table.
3445
3446 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
3447
3448         Reviewed by Anders.
3449
3450         - .5% speed improvement by avoiding excess CFURLRef allocation
3451
3452         * loader/CachedResource.cpp:
3453         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
3454         here for later reuse.
3455         * loader/CachedResource.h:
3456         * loader/mac/LoaderFunctionsMac.mm:
3457         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
3458
3459 2006-10-25  Darin Adler  <darin@apple.com>
3460
3461         Reviewed by Anders.
3462
3463         - removed 55 methods from WebCoreFrameBridge
3464         - changed callers to use Frame directly instead
3465         - put FrameLoaderTypes.h types into the WebCore namespace
3466         - first steps to get FrameLoader.h ready for cross-platform duty
3467
3468         * WebCore.exp:
3469         * WebCore.xcodeproj/project.pbxproj:
3470         * bridge/mac/BrowserExtensionMac.mm:
3471         (WebCore::BrowserExtensionMac::createNewWindow):
3472         * bridge/mac/FrameMac.h:
3473         * bridge/mac/FrameMac.mm:
3474         (WebCore::FrameMac::loadRequest):
3475         (WebCore::FrameMac::startRedirectionTimer):
3476         (WebCore::FrameMac::stopRedirectionTimer):
3477         (WebCore::FrameMac::passSubframeEventToSubframe):
3478         (WebCore::FrameMac::handledOnloadEvents):
3479         (WebCore::FrameMac::isLoadTypeReload):
3480         * bridge/mac/WebCoreFrameBridge.h:
3481         * bridge/mac/WebCoreFrameBridge.mm:
3482         (-[WebCoreFrameBridge executionContextForView:]):
3483         (updateRenderingForBindings):
3484         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3485         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
3486         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3487         (-[WebCoreFrameBridge installInFrame:]):
3488         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
3489         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3490         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
3491         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3492         (stringByCollapsingNonPrintingCharacters):
3493         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3494         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3495         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3496         * loader/FrameLoaderTypes.h:
3497         * loader/mac/FrameLoader.h:
3498         * loader/mac/FrameLoader.mm:
3499         (WebCore::FrameLoader::FrameLoader):
3500         (WebCore::FrameLoader::setupForReplace):
3501         (WebCore::FrameLoader::load):
3502         (WebCore::FrameLoader::activeDocumentLoader):
3503         (WebCore::FrameLoader::state):
3504         (WebCore::FrameLoader::setState):
3505         (WebCore::FrameLoader::clearProvisionalLoad):
3506         (WebCore::FrameLoader::markLoadComplete):
3507         (WebCore::FrameLoader::commitProvisionalLoad):
3508         (WebCore::FrameLoader::receivedMainResourceError):
3509         (WebCore::FrameLoader::handleFallbackContent):
3510         (WebCore::FrameLoader::isLoadingMainFrame):
3511         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3512         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3513         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3514         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3515         (WebCore::FrameLoader::transitionToCommitted):
3516         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3517         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3518         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
3519         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
3520         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
3521         * loader/mac/ImageDocumentMac.mm:
3522         (WebCore::finishImageLoad):
3523         * loader/mac/WebDocumentLoader.mm:
3524         (WebCore::DocumentLoader::isLoadingInAPISense):
3525         * loader/mac/WebMainResourceLoader.h:
3526         * loader/mac/WebMainResourceLoader.mm:
3527         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3528         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
3529         * loader/mac/WebSubresourceLoader.mm:
3530         (-[WebCoreSubresourceHandle initWithLoader:]):
3531         * platform/mac/ListBoxMac.mm:
3532         (-[WebCoreTableView keyDown:]):
3533         (-[WebCoreTableView keyUp:]):
3534         * platform/mac/WebCoreTextField.mm:
3535         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
3536
3537 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
3538
3539         Reviewed by Darin.
3540
3541         Printing fixes
3542
3543         * page/Frame.cpp:
3544         (WebCore::Frame::adjustPageHeight):
3545         * page/Frame.h:
3546         (WebCore::Frame::setupRootForPrinting):
3547         (WebCore::Frame::computePageRects):
3548
3549 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
3550
3551         Reviewed by Geoff.
3552
3553         <rdar://problem/4799088>
3554         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
3555
3556         * loader/mac/WebSubresourceLoader.h:
3557         * loader/mac/WebSubresourceLoader.mm:
3558         (-[WebCoreSubresourceHandle initWithLoader:]):
3559         Set the HTTP method before the HTTP body.
3560
3561 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
3562
3563         Reviewed by Adam.
3564
3565         Renamed WebFrameLoader to FrameLoader, to match class name.
3566
3567         * WebCore.xcodeproj/project.pbxproj:
3568         * bridge/mac/FrameMac.mm:
3569         * bridge/mac/WebCoreFrameBridge.mm:
3570         * loader/mac/FrameLoader.mm: Added.
3571         * loader/mac/IconLoaderMac.mm:
3572         * loader/mac/WebDocumentLoader.mm:
3573         * loader/mac/WebFrameLoader.h: Removed.
3574         * loader/mac/WebFrameLoader.mm: Removed.
3575         * loader/mac/WebLoader.mm:
3576         * loader/mac/WebMainResourceLoader.mm:
3577         * loader/mac/WebNetscapePlugInStreamLoader.mm:
3578         * loader/mac/WebSubresourceLoader.mm:
3579
3580 2006-10-25  Darin Adler  <darin@apple.com>
3581
3582         - fix full builds
3583
3584         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
3585
3586 2006-10-25  David Smith  <catfish.man@gmail.com>
3587
3588         Reviewed by Mitz.
3589
3590         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
3591         http://bugs.webkit.org/show_bug.cgi?id=11411
3592
3593         * bridge/mac/WebCoreFrameBridge.mm:
3594         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
3595
3596 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3597
3598         Rubber stamped by Mitz.
3599
3600         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
3601
3602         * WebCore.xcodeproj/project.pbxproj:
3603         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
3604         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
3605         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
3606
3607 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3608
3609         Rubber stamped by Mark.
3610
3611         - remove no longer existing symbol that was breaking linking
3612
3613         * WebCore.exp:
3614
3615 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
3616
3617         Reviewed by Mitz.
3618         
3619         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
3620         http://bugs.webkit.org/show_bug.cgi?id=11212
3621
3622         I couldn't figure out how to write a test case.
3623
3624         * bindings/js/kjs_window.cpp:
3625         (KJS::Window::clear): Avoid crashing if already detached.
3626         * bridge/mac/FrameMac.h:
3627         * bridge/mac/FrameMac.mm:
3628         (WebCore::FrameMac::clear): Change prototype to make this a proper
3629         overload for Frame::clear once again(!).
3630
3631 2006-10-24  Darin Adler  <darin@apple.com>
3632
3633         Reviewed by Anders.
3634
3635         - converted WebFrameLoaderClient to C++
3636         - renamed frame->frameLoader() function to frame->loader()
3637         - renamed [bridge impl] to [bridge _frame]
3638         - removed some bridge methods
3639
3640         * WebCore.exp: Added more exports.
3641         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
3642         so it can be used in WebKit.
3643
3644         * bridge/mac/BrowserExtensionMac.mm:
3645         (WebCore::BrowserExtensionMac::createNewWindow):
3646         * bridge/mac/FrameMac.mm:
3647         (WebCore::FrameMac::createFrame):
3648         (WebCore::FrameMac::didFirstLayout):
3649         * bridge/mac/WebCoreAXObject.mm:
3650         (-[WebCoreAXObject rendererForView:]):
3651         * bridge/mac/WebCoreFrameBridge.h:
3652         * bridge/mac/WebCoreFrameBridge.mm:
3653         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
3654         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3655         (-[WebCoreFrameBridge setOpener:]):
3656         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
3657         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
3658         (-[WebCoreFrameBridge setTitle:]):
3659         (-[WebCoreFrameBridge originalRequestURL]):
3660         (-[WebCoreFrameBridge isLoadTypeReload]):
3661         (-[WebCoreFrameBridge frameDetached]):
3662         (-[WebCoreFrameBridge tokenizerProcessedData]):
3663         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3664         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3665         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3666         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
3667         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3668         (-[WebCoreFrameBridge incomingReferrer]):
3669         (-[WebCoreFrameBridge isReloading]):
3670         (-[WebCoreFrameBridge handledOnloadEvents]):
3671         (-[WebCoreFrameBridge mainResourceURLResponse]):
3672         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
3673         (-[WebCoreFrameBridge _frame]):
3674         (-[WebCoreFrameBridge executionContextForView:]):
3675         * bridge/mac/WebCorePageBridge.mm:
3676         (-[WebCorePageBridge setMainFrame:]):
3677         * dom/Position.cpp:
3678         (WebCore::Position::upstream):
3679         * loader/mac/IconLoaderMac.mm:
3680         (IconLoader::notifyIconChanged):
3681         * loader/mac/WebDocumentLoader.mm:
3682         (WebCore::DocumentLoader::frameLoader):
3683         (WebCore::DocumentLoader::stopLoading):
3684         (WebCore::DocumentLoader::finishedLoading):
3685         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3686         * loader/mac/WebFormState.mm:
3687         (WebCore::FormState::FormState):
3688         * loader/mac/WebFrameLoader.h:
3689         * loader/mac/WebFrameLoader.mm:
3690         (WebCore::FrameLoader::~FrameLoader):
3691         (WebCore::FrameLoader::prepareForLoadStart):
3692         (WebCore::FrameLoader::finalSetupForReplace):
3693         (WebCore::FrameLoader::safeLoad):
3694         (WebCore::FrameLoader::load):
3695         (WebCore::FrameLoader::startLoading):
3696         (WebCore::FrameLoader::stopLoadingSubframes):
3697         (WebCore::FrameLoader::stopLoading):
3698         (WebCore::FrameLoader::cancelPendingArchiveLoad):
3699         (WebCore::FrameLoader::defersCallbacksChanged):
3700         (WebCore::FrameLoader::setDefersCallbacks):
3701         (WebCore::FrameLoader::setDocumentLoader):
3702         (WebCore::FrameLoader::provisionalLoadStarted):
3703         (WebCore::FrameLoader::clearProvisionalLoad):
3704         (WebCore::FrameLoader::identifierForInitialRequest):
3705         (WebCore::FrameLoader::willSendRequest):
3706         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
3707         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
3708         (WebCore::FrameLoader::didReceiveResponse):
3709         (WebCore::FrameLoader::didReceiveData):
3710         (WebCore::FrameLoader::didFinishLoad):
3711         (WebCore::FrameLoader::didFailToLoad):
3712         (WebCore::FrameLoader::privateBrowsingEnabled):
3713         (WebCore::FrameLoader::receivedMainResourceError):
3714         (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
3715         (WebCore::FrameLoader::clientRedirected):
3716         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
3717         (WebCore::FrameLoader::closeOldDataSources):
3718         (WebCore::FrameLoader::opened):
3719         (WebCore::FrameLoader::commitProvisionalLoad):
3720         (WebCore::FrameLoader::download):
3721         (WebCore::FrameLoader::finishedLoading):
3722         (WebCore::FrameLoader::notifyIconChanged):
3723         (WebCore::FrameLoader::cancelledError):
3724         (WebCore::FrameLoader::fileDoesNotExistError):
3725         (WebCore::FrameLoader::willUseArchive):
3726         (WebCore::FrameLoader::isArchiveLoadPending):
3727         (WebCore::FrameLoader::handleUnimplementablePolicy):
3728         (WebCore::FrameLoader::cannotShowMIMEType):
3729         (WebCore::FrameLoader::interruptionForPolicyChangeError):
3730         (WebCore::FrameLoader::canShowMIMEType):
3731         (WebCore::FrameLoader::representationExistsForURLScheme):
3732         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3733         (WebCore::FrameLoader::checkContentPolicy):
3734         (WebCore::FrameLoader::reloadAllowingStaleData):
3735         (WebCore::FrameLoader::reload):
3736         (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
3737         (WebCore::FrameLoader::finishedLoadingDocument):
3738         (WebCore::FrameLoader::committedLoad):
3739         (WebCore::FrameLoader::revertToProvisional):
3740         (WebCore::FrameLoader::setMainDocumentError):
3741         (WebCore::FrameLoader::mainReceivedCompleteError):
3742         (WebCore::FrameLoader::subframeIsLoading):
3743         (WebCore::FrameLoader::willChangeTitle):
3744         (WebCore::FrameLoader::didChangeTitle):
3745         (WebCore::FrameLoader::checkNewWindowPolicy):
3746         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3747         (WebCore::FrameLoader::checkNavigationPolicy):
3748         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3749         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3750         (WebCore::FrameLoader::didFirstLayout):
3751         (WebCore::FrameLoader::frameLoadCompleted):
3752         (WebCore::FrameLoader::transitionToCommitted):
3753         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3754         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3755         (WebCore::FrameLoader::sendRemainingDelegateMessages):
3756         (WebCore::FrameLoader::requestFromDelegate):
3757         (WebCore::FrameLoader::post):
3758         (WebCore::FrameLoader::detachChildren):
3759         (WebCore::FrameLoader::detachFromParent):
3760         (WebCore::FrameLoader::addExtraFieldsToRequest):
3761         (WebCore::FrameLoader::actionInformation):
3762         (WebCore::FrameLoader::checkLoadComplete):
3763         (WebCore::FrameLoader::setClient):
3764         (WebCore::FrameLoader::client):
3765         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3766         * loader/mac/WebFrameLoaderClient.h:
3767         * loader/mac/WebLoader.mm:
3768         (WebCore::WebResourceLoader::frameLoader):
3769         * loader/mac/WebSubresourceLoader.mm:
3770         (-[WebCoreSubresourceHandle initWithLoader:]):
3771         * page/Frame.cpp:
3772         (WebCore::Frame::loader):
3773         * page/Frame.h:
3774         * platform/mac/SliderMac.mm:
3775         (Slider::focusPolicy):
3776
3777 2006-10-24  Darin Adler  <darin@apple.com>
3778
3779         Rubber stamped by Anders.
3780
3781         - get rid of the assertion firing while running the layout tests
3782
3783         This does not fix the real problem, which is that we need to map offsets within
3784         possibly-text-transformed text in the render tree to DOM tree offsets and vice
3785         versa -- but it gets the tests running again.
3786
3787         * dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
3788
3789 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3790
3791         Reviewed by Oliver.
3792
3793         - more ResourceLoader cleanup
3794             - moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
3795             - took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed
3796         
3797         * loader/LoaderFunctions.h:
3798         * loader/mac/LoaderFunctionsMac.mm:
3799         (WebCore::ServeSynchronousRequest):
3800         * loader/mac/WebSubresourceLoader.mm:
3801         (-[WebCoreSubresourceHandle initWithLoader:]):
3802         * platform/network/HTTPHeaderMap.h: Added.
3803         * platform/network/ResourceLoader.cpp:
3804         (WebCore::ResourceLoader::requestHeaders):
3805         * platform/network/ResourceLoader.h:
3806         * platform/network/ResourceRequest.h:
3807         * platform/network/cf/ResourceLoaderCFNet.cpp:
3808         (WebCore::addHeadersFromHashMap):
3809         * xml/xmlhttprequest.cpp:
3810         (WebCore::XMLHttpRequest::send):
3811         * xml/xmlhttprequest.h:
3812
3813 2006-10-24  Justin Garcia  <justin.garcia@apple.com>
3814
3815         Reviewed by darin
3816
3817         <http://bugs.webkit.org/show_bug.cgi?id=10993>
3818         GMail Editor: Caret doesn't always position itself after list marker
3819         
3820         List creation uses moveParagraphs to push content into list items.  
3821         moveParagraphs uses a TextIterator to restore selections after moves.
3822         Some characters emitted by the TextIterator had bad ranges associated
3823         with them.  rangeFromLocationAndLength would skip past the range it
3824         should have used when asked for ranges of length 0.
3825
3826         * editing/TextIterator.cpp:
3827         (WebCore::TextIterator::TextIterator): No longer need to initialize a
3828         removed member variable.
3829         (WebCore::TextIterator::advance): An extra newline is emitted when leaving
3830         some blocks.  Use the same range for this newline as for the first newline.
3831         We should remove this code and just emit two '\n's.
3832         (WebCore::TextIterator::handleTextNode): Setup m_range.
3833         (WebCore::TextIterator::handleTextBox): Ditto.
3834         (WebCore::TextIterator::handleReplacedElement): Ditto.
3835         (WebCore::TextIterator::handleNonTextNode): Ditto.
3836         (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition
3837         in the block we're leaving to that VP after that one.
3838         (WebCore::TextIterator::emitCharacter): This function now takes in the start
3839         and the end of the range associated with the emited character, and sets up m_range.
3840         (WebCore::TextIterator::range): Return m_range.  If it is null (we are atEnd), 
3841         return the end of the range used to create the iterator, as a convenience to
3842         callers that use call range() on an iterator that is atEnd.
3843         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
3844         Same as the changes made to TextIterator's constructor.
3845         (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of
3846         a null m_positionNode to signal that we're finished.
3847         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
3848         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes
3849         made to TextIterator.
3850         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto.
3851         (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified.
3852         (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to
3853         TextIterator::range.
3854         (WebCore::CharacterIterator::range): This function assumed that an iterator's
3855         range() was safe to modify.
3856         (WebCore::TextIterator::rangeFromLocationAndLength):
3857         If the range we're looking for starts in the current chunk, this function assumed
3858         that if the chunk started in a text node, it would end in the same text node.  This
3859         is no longer the case.
3860         If the range we're looking for starts in the middle of the current chunk, I assume
3861         that the chunk is inside a text node, because those are the only chunks with length
3862         greater than one at the moment.
3863         If the range we're looking for is a zero length range that starts/ends at the end of the
3864         current chunk, we used to return the start of the next chunk, but that's wrong and
3865         is what caused this bug.
3866         * editing/TextIterator.h:
3867         (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null.
3868         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
3869         * editing/visible_units.cpp:
3870         (WebCore::previousBoundary): Cleaned up by using a convenience function.
3871         (WebCore::nextBoundary): Ditto.
3872
3873 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3874
3875         Reviewed by Maciej.
3876
3877         * platform/network/mac/ResourceLoaderMac.mm:
3878         (WebCore::ResourceLoader::start):
3879         Don't retain the header dictionary.
3880
3881 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3882
3883         Reviewed by Anders.
3884
3885         Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
3886         REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref() 
3887         running svg/custom/svg/custom/gradient-attr-update.svg
3888         
3889         SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.
3890
3891         * ksvg2/css/SVGRenderStyle.h:
3892         * ksvg2/css/SVGRenderStyleDefs.h:
3893
3894 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3895
3896         Reviewed by Mitz.
3897
3898         * platform/network/ResourceRequest.h:
3899         (WebCore::ResourceRequest::ResourceRequest):
3900         Set the http method to "GET" in the constructor that takes a String.
3901
3902 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3903
3904         Reviewed by Tim H.
3905
3906         Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
3907         and rendering/SVG* respectively.  Fix Xcode project and
3908         CMakeLists.txt to account for the moves.
3909
3910         * CMakeLists.txt:
3911         * WebCore.xcodeproj/project.pbxproj:
3912         * kcanvas/RenderForeignObject.cpp: Removed.
3913         * kcanvas/RenderForeignObject.h: Removed.
3914         * kcanvas/RenderPath.cpp: Removed.
3915         * kcanvas/RenderPath.h: Removed.
3916         * kcanvas/RenderSVGContainer.cpp: Removed.
3917         * kcanvas/RenderSVGContainer.h: Removed.
3918         * kcanvas/RenderSVGImage.cpp: Removed.
3919         * kcanvas/RenderSVGImage.h: Removed.
3920         * kcanvas/RenderSVGInline.cpp: Removed.
3921         * kcanvas/RenderSVGInline.h: Removed.
3922         * kcanvas/RenderSVGInlineText.cpp: Removed.
3923         * kcanvas/RenderSVGInlineText.h: Removed.
3924         * kcanvas/RenderSVGTSpan.cpp: Removed.
3925         * kcanvas/RenderSVGTSpan.h: Removed.
3926         * kcanvas/RenderSVGText.cpp: Removed.
3927         * kcanvas/RenderSVGText.h: Removed.
3928         * kcanvas/SVGInlineFlowBox.cpp: Removed.
3929         * kcanvas/SVGInlineFlowBox.h: Removed.
3930         * kcanvas/SVGRootInlineBox.cpp: Removed.
3931         * kcanvas/SVGRootInlineBox.h: Removed.
3932
3933 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
3934
3935         Rolling back in, now fixed:
3936         
3937         Nixed a few more redundant loading functions in Frame. Did my best to update
3938         the non-Mac builds.
3939
3940         * bridge/mac/FrameMac.h:
3941         * bridge/mac/FrameMac.mm:
3942         (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture
3943         always 'true', because changing it broke the world, and testing seems to
3944         indicate that the one caller that might have passed 'false' didn't need to.
3945         * page/Frame.cpp:
3946         (WebCore::Frame::requestFrame):
3947         (WebCore::Frame::frameLoader):
3948         (WebCore::Frame::redirectionTimerFired):
3949         * page/Frame.h:
3950         * platform/gdk/FrameGdk.cpp:
3951         * platform/gdk/FrameGdk.h:
3952         * platform/gdk/TemporaryLinkStubs.cpp:
3953         (FrameGdk::issueCopyCommand):
3954         * platform/qt/FrameQt.cpp:
3955         * platform/qt/FrameQt.h:
3956         * platform/win/TemporaryLinkStubs.cpp:
3957         (WebCore::FrameWin::shouldInterruptJavaScript):
3958         (WebCore::FrameWin::issueCopyCommand):
3959
3960 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
3961
3962         Fix the build (Update for changes to ResourceLoader)
3963         
3964         * platform/network/cf/ResourceLoaderCFNet.cpp:
3965         (WebCore::addHeadersFromHashMap):
3966         (WebCore::ResourceLoader::start):
3967         (WebCore::ResourceLoader::cancel):
3968
3969 2006-10-24  Sam Weinig  <sam.weinig@gmail.com>
3970
3971         Reviewed by Mitz.
3972
3973         Change #includes using <kcanvas/*.h> to use "*.h" instead
3974         to prepare for moving the kcanvas files.
3975
3976         * kcanvas/RenderSVGContainer.h:
3977         * ksvg2/svg/SVGAElement.cpp:
3978         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
3979         * ksvg2/svg/SVGFETileElement.cpp:
3980         * ksvg2/svg/SVGStyledLocatableElement.cpp:
3981         * ksvg2/svg/SVGStyledTransformableElement.cpp:
3982
3983 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
3984
3985         Reviewed by Darin.
3986
3987         - More movement towards the final network API.
3988         
3989         Changed ResourceLoader::create to take a ResurceRequest and start
3990         the load. Removed methods relating to setting request
3991         headers. Removed methods relating to metaData. Added some more
3992         convenience methods to ResourceRequest.
3993
3994         * dom/XMLTokenizer.cpp:
3995         (WebCore::openFunc):
3996         * loader/LoaderFunctions.h:
3997         * loader/icon/IconLoader.cpp:
3998         (IconLoader::startLoading):
3999         (IconLoader::didFinishLoading):
4000         * loader/icon/IconLoader.h:
4001         * loader/loader.cpp:
4002         (WebCore::Loader::servePendingRequests):
4003         * loader/mac/LoaderFunctionsMac.mm:
4004         (WebCore::ServeSynchronousRequest):
4005         * platform/gdk/FrameGdk.cpp:
4006         (WebCore::FrameGdkClientDefault::openURL):
4007         (WebCore::FrameGdkClientDefault::submitForm):
4008         * platform/network/ResourceLoader.cpp:
4009         (WebCore::ResourceLoader::ResourceLoader):
4010         (WebCore::ResourceLoader::create):
4011         (WebCore::ResourceLoader::responseHTTPHeadersAsString):
4012         (WebCore::ResourceLoader::url):
4013         (WebCore::ResourceLoader::postData):
4014         (WebCore::ResourceLoader::method):
4015         (WebCore::ResourceLoader::client):
4016         * platform/network/ResourceLoader.h:
4017         * platform/network/ResourceLoaderInternal.h:
4018         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
4019         * platform/network/ResourceRequest.h:
4020         (WebCore::ResourceRequest::ResourceRequest):
4021         (WebCore::ResourceRequest::httpAccept):
4022         (WebCore::ResourceRequest::setHTTPAccept):
4023         (WebCore::ResourceRequest::addHTTPHeaderFields):
4024         * platform/network/mac/ResourceLoaderMac.mm:
4025         (WebCore::ResourceLoader::start):
4026         (WebCore::ResourceLoader::receivedResponse):
4027         * platform/qt/FrameQtClient.cpp:
4028         (WebCore::FrameQtClientDefault::openURL):
4029         (WebCore::FrameQtClientDefault::submitForm):
4030         * platform/win/TemporaryLinkStubs.cpp:
4031         (WebCore::ResourceLoader::retrieveResponseEncoding):
4032         * xml/XSLTProcessor.cpp:
4033         (WebCore::docLoaderFunc):
4034         * xml/xmlhttprequest.cpp:
4035         (WebCore::XMLHttpRequest::send):
4036         (WebCore::XMLHttpRequest::didFinishLoading):
4037         (WebCore::XMLHttpRequest::didReceiveData):
4038         * xml/xmlhttprequest.h:
4039
4040 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
4041
4042         Reviewed by Geoff.
4043
4044         * loader/FormData.cpp:
4045         (WebCore::FormData::FormData):
4046         * loader/FormData.h:
4047         (WebCore::FormData::FormData):
4048         Add new constructor that takes a void* and a size.
4049
4050 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
4051
4052         Rolling out my last change because it broke the world.
4053
4054         * bridge/mac/FrameMac.h:
4055         * bridge/mac/FrameMac.mm:
4056         (WebCore::FrameMac::openURL):
4057         (WebCore::FrameMac::openURLRequest):
4058         (WebCore::FrameMac::urlSelected):
4059         * page/Frame.cpp:
4060         (WebCore::Frame::openURL):
4061         (WebCore::Frame::frameLoader):
4062         (WebCore::Frame::requestFrame):
4063         (WebCore::Frame::redirectionTimerFired):
4064         * page/Frame.h:
4065         * platform/gdk/FrameGdk.cpp:
4066         (WebCore::FrameGdk::openURL):
4067         * platform/gdk/FrameGdk.h:
4068         * platform/gdk/TemporaryLinkStubs.cpp:
4069         * platform/qt/FrameQt.cpp:
4070         (WebCore::FrameQt::openURL):
4071         (WebCore::FrameQt::openURLRequest):
4072         * platform/qt/FrameQt.h:
4073         * platform/win/TemporaryLinkStubs.cpp:
4074         (WebCore::FrameWin::openURL):
4075         (WebCore::FrameWin::openURLRequest):
4076
4077 2006-10-24  Nikolas Zimmermann  <zimmermann@kde.org>
4078
4079         Reviewed by Adam.
4080
4081         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11396
4082
4083         Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
4084         anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
4085         or broken.
4086
4087         * CMakeLists.txt:
4088         * WebCore.xcodeproj/project.pbxproj:
4089         * kcanvas/KCanvasTreeDebug.cpp:
4090         (WebCore::operator<<):
4091         (WebCore::writeStyle):
4092         * kcanvas/RenderPath.cpp:
4093         (WebCore::RenderPath::fillContains):
4094         * kcanvas/device/KRenderingFillPainter.cpp:
4095         * kcanvas/device/KRenderingFillPainter.h:
4096         * kcanvas/device/KRenderingStrokePainter.cpp:
4097         * kcanvas/device/KRenderingStrokePainter.h:
4098         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
4099         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
4100         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
4101         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
4102         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
4103         (WebCore::KRenderingPaintServerQt::setPenProperties):
4104         * kcanvas/device/qt/KRenderingPaintServerQt.h:
4105         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
4106         (WebCore::KRenderingPaintServerSolidQt::setup):
4107         * kcanvas/device/qt/RenderPathQt.cpp:
4108         (WebCore::getPathStroke):
4109         (WebCore::RenderPath::strokeBBox):
4110         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
4111         (WebCore::RenderPath::strokeBBox):
4112         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
4113         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
4114         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
4115         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
4116         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
4117         * kcanvas/device/quartz/QuartzSupport.h:
4118         (WebCore::CGLineCapFromKC):
4119         (WebCore::CGLineJoinFromKC):
4120         * kcanvas/device/quartz/QuartzSupport.mm:
4121         (WebCore::applyStrokeStyleToContext):
4122         (WebCore::strokeBoundingBox):
4123         * ksvg2/css/SVGCSSStyleSelector.cpp:
4124         (WebCore::CSSStyleSelector::applySVGProperty):
4125         * ksvg2/css/SVGRenderStyle.h:
4126         (WebCore::SVGRenderStyle::InheritedFlags::):
4127         * ksvg2/css/SVGRenderStyleDefs.h:
4128         * ksvg2/misc/KCanvasRenderingStyle.cpp:
4129         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
4130         * ksvg2/misc/KCanvasRenderingStyle.h:
4131         * ksvg2/svg/SVGFEImageElement.cpp:
4132
4133 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
4134
4135         Reviewed by Anders.
4136
4137         Nixed a few more redundant loading functions in Frame. Did my best to update
4138         the non-Mac builds.
4139
4140         * bridge/mac/FrameMac.h:
4141         * bridge/mac/FrameMac.mm:
4142         (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture
4143         to actually check for a user gesture. New callers rely on this behavior,
4144         and it seems like the previous behavior must have been a bug.
4145         * page/Frame.cpp:
4146         (WebCore::Frame::requestFrame):
4147         (WebCore::Frame::frameLoader):
4148         (WebCore::Frame::redirectionTimerFired):
4149         * page/Frame.h:
4150         * platform/gdk/FrameGdk.cpp:
4151         * platform/gdk/FrameGdk.h:
4152 &