Renaming some parameters passed to DB-related methods to better
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Renaming some parameters passed to DB-related methods to better
6         indicate their purpose.
7
8         https://bugs.webkit.org/show_bug.cgi?id=31449
9
10         * platform/chromium/ChromiumBridge.h:
11
12 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
13
14         Reviewed by Dan Bernstein.
15
16         Transformed reflected elements are clipped inside element with opacity
17         https://bugs.webkit.org/show_bug.cgi?id=30957
18         
19         transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
20         each clip rect into painting space before taking the unions. This, however, did not work
21         correctly with combinations of reflections and transforms. Fixed by unioning the
22         clipRect and mapping through transforms along the way.
23         
24         Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
25         where the transparency layers are.
26
27         Test: fast/reflections/opacity-reflection-transform.html
28
29         * rendering/RenderLayer.cpp:
30         (WebCore::expandClipRectForDescendantsAndReflection):
31         (WebCore::transparencyClipBox):
32         (WebCore::RenderLayer::beginTransparencyLayers):
33
34 2009-11-12  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Darin Fisher.
37
38         Improve SecurityOrigin::toString comment
39         https://bugs.webkit.org/show_bug.cgi?id=31041
40
41         * page/SecurityOrigin.h:
42
43 2009-11-12  Shinichiro Hamaji  <hamaji@chromium.org>
44
45         Reviewed by Darin Adler.
46
47         externalRepresentation should take Frame as the argument
48         https://bugs.webkit.org/show_bug.cgi?id=31393
49
50         No new tests as this is just a refactoring.
51
52         * WebCore.base.exp:
53         * rendering/RenderTreeAsText.cpp:
54         (WebCore::externalRepresentation):
55         * rendering/RenderTreeAsText.h:
56
57 2009-11-12  Ben Murdoch  <benm@google.com>
58
59         Reviewed by Dimitri Glazkov.
60
61         [Android] The Android specific files in page/Android are out of date.
62         https://bugs.webkit.org/show_bug.cgi?id=31437
63
64         No tests required.
65
66         * page/android/DragControllerAndroid.cpp:
67         (WebCore::DragController::dragOperation): Added.
68         (WebCore::DragController::cleanupAfterSystemDrag):
69         * page/android/EventHandlerAndroid.cpp:
70         (WebCore::EventHandler::accessKeyModifiers): Added.
71         * page/android/InspectorControllerAndroid.cpp: Removed.
72
73 2009-11-12  Brent Fulgham  <bfulgham@webkit.org>
74
75         Reviewed by Simon Fraser.
76
77         [CAIRO] shadow support for Canvas and SVG.
78         [https://bugs.webkit.org/show_bug.cgi?id=30960]
79
80         Implement Canvas/SVG shadow support for Cairo.  This patch
81         uses the filter code from SVG Filters.  That means that it is
82         necessary to activate filters to see the shadows.
83
84         Test: fast/canvas/canvas-shadow.html
85
86         * GNUmakefile.am:
87         * WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
88         * platform/graphics/GraphicsContext.h:
89         * platform/graphics/cairo/GraphicsContextCairo.cpp:
90         (GraphicsContext::calculateShadowBufferDimensions): New helper routine.
91         (WebCore::setPlatformFill):
92         (WebCore::setPlatformStroke):
93         (WebCore::copyContextProperties):
94         (WebCore::drawPathShadow):
95         (WebCore::GraphicsContext::fillPath):
96         (WebCore::GraphicsContext::strokePath):
97         (WebCore::GraphicsContext::drawPath):
98         (WebCore::GraphicsContext::setPlatformShadow):
99         (WebCore::GraphicsContext::createPlatformShadow):
100         * platform/graphics/cairo/ImageCairo.cpp:
101         (WebCore::BitmapImage::draw): Add filter effect.
102         * platform/graphics/filters/Filter.h: Correct 'const' signatures.
103         * platform/graphics/filters/ImageBufferFilter.cpp: Added.
104         * platform/graphics/filters/ImageBufferFilter.h: Added.
105         * svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
106         * svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
107
108 2009-11-12  Dmitry Titov  <dimich@chromium.org>
109
110         Reviewed by Alexey Proskuryakov.
111
112         Add postTaskToMainThread to ScriptExecutionContext.
113         Move the code to post task to the main thread into a new method on ScriptExecutionContext,
114         to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
115         contexts that live on the main thread.
116         https://bugs.webkit.org/show_bug.cgi?id=31427
117
118         No new tests - simply moving the code.
119
120         * dom/Document.cpp:
121         (WebCore::Document::postTask):
122         * dom/ScriptExecutionContext.cpp:
123         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
124         (WebCore::ScriptExecutionContextTaskTimer::fired):
125         (WebCore::PerformTaskData::PerformTaskData):
126         (WebCore::PerformTaskData::performTask):
127         (WebCore::ScriptExecutionContext::postTaskToMainThread):
128         * dom/ScriptExecutionContext.h:
129
130 2009-11-12  Simon Fraser  <simon.fraser@apple.com>
131
132         Reviewed by Darin Adler.
133
134         Fix crash when removing compositing layers when GC is enabled
135         https://bugs.webkit.org/show_bug.cgi?id=31429
136
137         Workaround <rdar://problem/7390716> by special-casing the removal
138         of all sublayers when GC is enabled.
139
140         * platform/graphics/mac/GraphicsLayerCA.mm:
141         (WebCore::safeSetSublayers):
142         (WebCore::GraphicsLayerCA::updateSublayerList):
143         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
144
145 2009-11-12  Jens Alfke  <snej@chromium.org>
146
147         Reviewed by Dimitri Glazkov.
148
149         The last of the V8 binding optimizations.
150         - Replace string-valued element accessors with a shared getter/setter function.
151         - Change error handling flow of control to avoid extra branches and function calls.
152         https://bugs.webkit.org/show_bug.cgi?id=31443
153         
154         * bindings/scripts/CodeGeneratorV8.pm:
155         * bindings/v8/V8Binding.cpp:
156         (WebCore::getElementStringAttr):  Body of string-valued Element getter function.
157         (WebCore::setElementStringAttr):  Body of string-valued Element setter function.
158         * bindings/v8/V8Binding.h:
159
160 2009-11-12  Sam Weinig  <sam@webkit.org>
161
162         Reviewed by Oliver Hunt.
163
164         Fix for <rdar://problem/7267951>
165         Canvas methods should reject uses of NaN and Infinity.
166
167         Test: fast/canvas/canvas-with-illegal-args.html
168
169         * html/canvas/CanvasRenderingContext2D.cpp:
170         (WebCore::CanvasRenderingContext2D::scale):
171         (WebCore::CanvasRenderingContext2D::rotate):
172         (WebCore::CanvasRenderingContext2D::translate):
173         (WebCore::CanvasRenderingContext2D::transform):
174         (WebCore::CanvasRenderingContext2D::setTransform):
175
176 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
177
178         Reviewed by Timothy Hatcher.
179
180         Web Inspector: profile timeline panel, fix obvious problems.
181
182         https://bugs.webkit.org/show_bug.cgi?id=31432
183
184         * inspector/front-end/AbstractTimelinePanel.js:
185         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
186         * inspector/front-end/TimelinePanel.js:
187         (WebInspector.TimelinePanel.prototype._setWindowPosition):
188         (WebInspector.TimelineCalculator):
189         (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
190         (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
191         (WebInspector.TimelineCalculator.prototype.reset):
192         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
193         (WebInspector.TimelineCalculator.prototype.formatValue):
194         (WebInspector.TimelineGraph):
195         (WebInspector.TimelineGraph.prototype.refresh):
196         * inspector/front-end/utilities.js:
197         (Element.prototype.hasStyleClass):
198
199 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
200
201         Reviewed by Timothy Hatcher.
202
203         Web Inspector: preload status bar button glyphs
204         in order to prevent them from flickering.
205
206         https://bugs.webkit.org/show_bug.cgi?id=31439
207
208         * inspector/front-end/inspector.js:
209         (preloadImages):
210
211 2009-11-12  Adam Roben  <aroben@apple.com>
212
213         Replace worldIDs with world objects
214
215         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
216         user scripts/stylesheets and isolated worlds
217
218         Reviewed by Sam Weinig.
219
220         Covered by existing tests.
221
222         * WebCore.base.exp: Update exported symbols to match what now exists
223         and is needed by WebKit.
224
225         * bindings/js/ScheduledAction.cpp:
226         (WebCore::ScheduledAction::execute): Updated for function rename.
227
228         * bindings/js/ScriptController.cpp: Removed code that dealt with
229         worldIDs.
230         (WebCore::ScriptController::createWorld): Added. Returns a new world
231         suitable for use on the main thread.
232         (WebCore::ScriptController::executeScriptInWorld): Renamed from
233         executeScriptInIsolatedWorld, since this works just fine with a
234         "normal" world.
235
236         * bindings/js/ScriptController.h: Added createWorld, removed functions
237         that took worldIDs, renamed executeScriptInIsolatedWorld to
238         executeScriptInWorld.
239
240         * page/Frame.cpp:
241         (WebCore::Frame::injectUserScripts):
242         (WebCore::Frame::injectUserScriptsForWorld):
243         Updated for changes to UserScriptMap and ScriptController.
244
245         * page/Frame.h: Changed injectUserScriptsForWorld to take a
246         DOMWrapperWorld* instead of a worldID.
247
248         * page/PageGroup.cpp:
249         (WebCore::PageGroup::addUserScriptToWorld):
250         (WebCore::PageGroup::addUserStyleSheetToWorld):
251         (WebCore::PageGroup::removeUserScriptFromWorld):
252         (WebCore::PageGroup::removeUserStyleSheetFromWorld):
253         (WebCore::PageGroup::removeUserScriptsFromWorld):
254         (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
255         * page/PageGroup.h:
256         Changed these functions to take a DOMWrapperWorld* instead of a
257         worldID. Also updated for changes to UserScript and UserStyleSheet.
258
259         * page/UserScript.h:
260         * page/UserStyleSheet.h: Changed not to hold a worldID, since it was
261         never used.
262
263         * page/UserScriptTypes.h:
264         * page/UserStyleSheetTypes.h: Changed UserScriptMap and
265         UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
266         worldID as their key type.
267
268
269 2009-11-12  Brian Weinstein  <bweinstein@apple.com>
270
271         Reviewed by Tim Hatcher.
272
273         Fixes <http://webkit.org/b/31260>.
274         Web Inspector: Main Resources Other than HTML are mis-detected.
275         
276         Even if the resource is a main resource, look at its CachedResource type, 
277         because it might be an image, stylesheet, or JavaScript file, and we
278         want to show them all correctly.
279
280         * inspector/InspectorResource.cpp:
281         (WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
282         (WebCore::InspectorResource::type): 
283         * inspector/InspectorResource.h:
284
285 2009-11-12  Jens Alfke  <snej@chromium.org>
286
287         Reviewed by Dimitri Glazkov.
288
289         Table-driven setup for V8 binding template callback functions. 100k in code savings.
290         https://bugs.webkit.org/show_bug.cgi?id=31420
291
292         * bindings/scripts/CodeGeneratorV8.pm:  Change generated ConfigureXXXTemplate fn
293             to call configureTemplate().
294         * bindings/v8/V8Binding.cpp:
295         (WebCore::configureTemplate):  New function; does all the standard configuration work.
296         (WebCore::createCallback):  De-inlined wrapper for FunctionTemplate creation.
297         * bindings/v8/V8Binding.h:
298         * bindings/v8/V8Proxy.cpp:
299         (WebCore::batchConfigureAttributes):  Just wrapped the very long fn parameter list.
300         (WebCore::batchConfigureCallbacks):  New function, used by configureTemplate.
301         (WebCore::batchConfigureConstants):  Just wrapped the very long fn parameter list.
302         * bindings/v8/V8Proxy.h:
303
304 2009-11-12  Dumitru Daniliuc  <dumi@chromium.org>
305
306         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50876.
307
308         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
309
310 2009-11-12  Eric Carlson  <eric.carlson@apple.com>
311
312         Reviewed by Dan Bernstein.
313
314         <rdar://problem/7388969> Add DOM API for fullscreen video
315         
316         DOM API for fullscreen <video>.
317
318         Tests: media/media-fullscreen-inline.html
319                media/media-fullscreen-not-in-document.html
320
321         * dom/EventNames.h:
322             Add webkitbeginfullscreen and webkitendfullscreen.
323
324         * html/HTMLAttributeNames.in:
325             Add onwebkitbeginfullscreen and onwebkitendfullscreen.
326
327         * html/HTMLMediaElement.cpp:
328         (WebCore::HTMLMediaElement::parseMappedAttribute):
329             Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
330         (WebCore::HTMLMediaElement::enterFullscreen):
331             Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
332             actually do enter fullscreen.
333         (WebCore::HTMLMediaElement::exitFullscreen):
334             Schedule webkitendfullscreenEvent event.
335         (WebCore::HTMLMediaElement::webkitEnterFullScreen):
336         (WebCore::HTMLMediaElement::webkitExitFullScreen):
337         (WebCore::HTMLMediaElement::webkitSupportsFullscreen):
338         (WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
339             New, access to fullscreen properties and methods.
340
341         * html/HTMLMediaElement.h:
342         * html/HTMLMediaElement.idl:
343             Declare methods needed for fullscreen API.
344
345         * html/HTMLVideoElement.cpp:
346         (WebCore::HTMLVideoElement::supportsFullscreen):
347             Return false if a movie does not have video.
348
349         * page/DOMWindow.h:
350             Add webkitbeginfullscreen and webkitendfullscreen.
351
352 2009-11-12  Adam Barth  <abarth@webkit.org>
353
354         Reviewed by Dimitri Glazkov.
355
356         [Chromium] Sify compose button alerts error
357         https://bugs.webkit.org/show_bug.cgi?id=31394
358
359         Test: http/tests/security/calling-versus-current.html
360
361         We're supposed to use the calling context for security checks.  In JSC
362         land, this is the lexicalGlobalObject.
363
364         * bindings/v8/V8Proxy.cpp:
365         (WebCore::V8Proxy::canAccessPrivate):
366
367 2009-11-12  Daniel Bates  <dbates@webkit.org>
368
369         Reviewed by Darin Adler.
370
371         https://bugs.webkit.org/show_bug.cgi?id=30291
372
373         Fixes an issue where the returned drop effect is incorrect when
374         effectAllowed == "uninitialized".
375
376         According to section 7.9.2 of the HTML 5 spec.
377         <http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
378         when effectAllowed = "uninitialized" the resulting dropEffect should be the
379         user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
380         other case.
381         
382         No test cases are included because we have an existing test case from
383         bug #24731.
384
385         * dom/Clipboard.cpp:
386         (WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
387
388 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
389
390         Reviewed by Timothy Hatcher.
391
392         Web Inspector: Do not highlight node on refresh.
393
394         https://bugs.webkit.org/show_bug.cgi?id=31419
395
396         * inspector/front-end/ElementsPanel.js:
397         (WebInspector.ElementsPanel.prototype.reset):
398
399 2009-11-12  Pavel Feldman  <pfeldman@chromium.org>
400
401         Reviewed by Timothy Hatcher.
402
403         Web Inspector: Minor timeline fixes.
404
405         https://bugs.webkit.org/show_bug.cgi?id=31417
406
407         * inspector/front-end/TimelinePanel.js:
408         (WebInspector.TimelinePanel.prototype._getRecordDetails):
409         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
410         (WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
411         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
412
413 2009-11-12  Alexey Proskuryakov  <ap@apple.com>
414
415         SnowLeopard build fix.
416
417         Renamed initWithClient to initWithAuthenticationClient.
418
419         * platform/network/mac/AuthenticationMac.mm:
420         (-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
421         (WebCore::AuthenticationChallenge::setAuthenticationClient):
422
423 2009-11-12  Chris Fleizach  <cfleizach@apple.com>
424
425         Reviewed by Darin Adler.
426
427         ARIA: add alert type roles
428         https://bugs.webkit.org/show_bug.cgi?id=31392
429
430         Test: platform/mac/accessibility/aria-alerts.html
431
432         * accessibility/AccessibilityObject.h:
433         * accessibility/AccessibilityRenderObject.cpp:
434         * accessibility/mac/AccessibilityObjectWrapper.mm:
435
436 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
437
438         Reviewed by Darin Adler.
439
440         https://bugs.webkit.org/show_bug.cgi?id=31386
441         Make Mac AuthenticationChallenge usable from cross-platform code
442
443         No change in behavior, so no tests.
444
445         * platform/network/ResourceHandle.cpp:
446         (WebCore::ResourceHandle::clearAuthentication):
447         * platform/network/ResourceHandleInternal.h:
448         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
449         Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
450         NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
451         is identical.
452
453         * platform/network/cf/AuthenticationChallenge.h:
454         (WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
455         Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
456
457         * platform/network/cf/ResourceHandleCFNet.cpp:
458         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
459         of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
460         be already set.
461
462         * platform/network/mac/AuthenticationChallenge.h:
463         (WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
464         best of my understanding.
465         (WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
466         confusion with "mac" and "web" challenges in ResourceHandleInternal.
467
468         * platform/network/mac/AuthenticationMac.mm:
469         (WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
470         making it possible to use the latter with NSURLAuthenticationChallenge.
471         (WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
472         m_nsChallenge renaming.
473         (WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
474         set it as sender (or unset, if client is null).
475
476         * platform/network/mac/ResourceHandleMac.mm:
477         (WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
478         authentication challenge sender.
479         (WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
480         authentication sheet.
481         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
482         using the new setAuthenticationClient() method.
483         (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
484         Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
485         the original Mac one, not the one we created for use with authentication sheet. I don't
486         know when a connection would cancel authentication in practice, so I haven't tested this.
487
488 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
489
490         Reviewed by Timothy Hatcher.
491
492         Web Inspector: breakpoint sidebar entries should allow click over entire list item
493         https://bugs.webkit.org/show_bug.cgi?id=31411
494
495         No new tests; no new functionality, small usability change. 
496
497         * inspector/front-end/BreakpointsSidebarPane.js:
498         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
499         (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
500
501 2009-11-12  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
502
503         Reviewed by Timothy Hatcher.
504
505         Web Inspector: breakpoints in named evals are not restored after a reload
506         https://bugs.webkit.org/show_bug.cgi?id=31375
507
508         Manual test added
509
510         * inspector/front-end/ScriptsPanel.js:
511         (WebInspector.ScriptsPanel.prototype.addScript):
512         * manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
513
514 2009-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
515
516         Reviewed by Kenneth Rohde Christiansen.
517
518         Custom printing shrink factors
519         https://bugs.webkit.org/show_bug.cgi?id=29042
520
521         This reverts commit r49769. The public API for this needs to be reviewed
522         before its inclusion in Qt.
523
524         * page/PrintContext.cpp:
525         (WebCore::PrintContext::begin):
526         * page/Settings.cpp:
527         (WebCore::Settings::Settings):
528         * page/Settings.h:
529
530 2009-11-12  Alexander Pavlov  <apavlov@chromium.org>
531
532         Reviewed by Pavel Feldman.
533
534         Web Inspector: Resource errors/warnings not shown in the Resource tree.
535
536         Error/Warning bubbles are not displayed next to the resource in the 
537         Resources panel if those occur before the resource is attached to the tree.
538         https://bugs.webkit.org/show_bug.cgi?id=31404
539
540         Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
541
542         * inspector/front-end/AbstractTimelinePanel.js:
543         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
544         * inspector/front-end/ResourcesPanel.js:
545         (WebInspector.ResourceSidebarTreeElement.prototype.onattach):
546
547 2009-11-12  Philippe Normand  <pnormand@igalia.com>
548
549         Reviewed by Jan Alonzo.
550
551         https://bugs.webkit.org/show_bug.cgi?id=31047
552         [GTK] Failing test media/video-played-ranges-1.html
553
554         Follow-up of r50726, don't block the UI thread when calling
555         gst_element_get_state(). Also fixed a compilation warning and some
556         static casts.
557
558         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
559         (WebCore::playbackPosition):
560         (WebCore::MediaPlayerPrivate::seek):
561         (WebCore::MediaPlayerPrivate::setRate):
562
563 2009-11-12  Philippe Normand  <pnormand@igalia.com>
564
565         Reviewed by Jan Alonzo.
566
567         https://bugs.webkit.org/show_bug.cgi?id=31047
568         [GTK] Failing test media/video-played-ranges-1.html
569
570         don't pause pipeline if already paused, same for play()
571
572         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
573         (WebCore::MediaPlayerPrivate::play):
574         (WebCore::MediaPlayerPrivate::pause):
575
576 2009-11-12  Kinuko Yasuda  <kinuko@google.com>
577
578         Reviewed by David Levin.
579
580         Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
581         Chromium too.
582         https://bugs.webkit.org/show_bug.cgi?id=31292
583
584         No new tests. (Corresponding test for Gtk+ is
585         platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
586
587         * page/EventHandler.cpp:
588         * page/chromium/EventHandlerChromium.cpp:
589
590 2009-11-12  Yuta Kitamura  <yutak@chromium.org>
591
592         Reviewed by Eric Seidel.
593
594         Prevent text inside a multi-column block from being split into columns.
595         
596         If the tentative height of a multi-column block was too small, we need to
597         expand the block height and try to layout again, in order to prevent text
598         from being split into different columns.
599
600         CSS Multicolumn text is split awkwardly
601         https://bugs.webkit.org/show_bug.cgi?id=22249
602
603         Test: fast/multicol/single-line.html
604
605         * rendering/RenderBlock.cpp:
606         (WebCore::RenderBlock::layoutColumns):
607         * rendering/RenderBlock.h:
608         * rendering/RenderLineBoxList.cpp:
609         (WebCore::RenderLineBoxList::paint):
610         * rendering/RenderView.h:
611         (WebCore::RenderView::setTruncatedAt):
612         (WebCore::RenderView::setMinimumColumnHeight):
613         (WebCore::RenderView::minimumColumnHeight):
614
615 2009-11-11  Kent Tamura  <tkent@chromium.org>
616
617         Reviewed by Darin Adler.
618
619         Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
620         https://bugs.webkit.org/show_bug.cgi?id=31195
621
622         Test: fast/forms/input-file-re-render.html
623
624         * rendering/RenderFileUploadControl.cpp:
625         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
626
627 2009-11-09  Dumitru Daniliuc  <dumi@chromium.org>
628
629         Reviewed by Dimitri Glazkov.
630
631         Fixing Chromium's POSIX VFS implementation, by adding the required
632         "used file descriptors" logic.
633
634         https://bugs.webkit.org/show_bug.cgi?id=31275
635
636         * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
637
638 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
639
640         Reviewed by Oliver Hunt.
641
642         need to implement aria tree roles
643         https://bugs.webkit.org/show_bug.cgi?id=31284
644
645         Tests: platform/mac/accessibility/aria-multiselectable.html
646                platform/mac/accessibility/aria-tree.html
647
648         * accessibility/AccessibilityList.cpp:
649         (WebCore::AccessibilityList::accessibilityIsIgnored):
650         * accessibility/AccessibilityObject.cpp:
651         (WebCore::AccessibilityObject::ariaTreeRows):
652         (WebCore::AccessibilityObject::ariaTreeItemContent):
653         (WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
654         * accessibility/AccessibilityObject.h:
655         (WebCore::):
656         (WebCore::AccessibilityObject::isTree):
657         (WebCore::AccessibilityObject::isTreeItem):
658         (WebCore::AccessibilityObject::setIsExpanded):
659         (WebCore::AccessibilityObject::canSetExpandedAttribute):
660         (WebCore::AccessibilityObject::hierarchicalLevel):
661         (WebCore::AccessibilityObject::setSelectedRows):
662         (WebCore::AccessibilityObject::performDefaultAction):
663         * accessibility/AccessibilityRenderObject.cpp:
664         (WebCore::AccessibilityRenderObject::hierarchicalLevel):
665         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
666         (WebCore::AccessibilityRenderObject::isExpanded):
667         (WebCore::AccessibilityRenderObject::setElementAttributeValue):
668         (WebCore::AccessibilityRenderObject::elementAttributeValue):
669         (WebCore::AccessibilityRenderObject::setIsExpanded):
670         (WebCore::AccessibilityRenderObject::isSelected):
671         (WebCore::AccessibilityRenderObject::setSelected):
672         (WebCore::AccessibilityRenderObject::setSelectedRows):
673         (WebCore::createARIARoleMap):
674         (WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
675         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
676         (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
677         (WebCore::AccessibilityRenderObject::selectedChildren):
678         * accessibility/AccessibilityRenderObject.h:
679         * accessibility/mac/AccessibilityObjectMac.mm:
680         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
681         * accessibility/mac/AccessibilityObjectWrapper.mm:
682         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
683         (RoleEntry::):
684         (-[AccessibilityObjectWrapper subrole]):
685         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
686         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
687         (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
688         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
689         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
690         * html/HTMLAttributeNames.in:
691
692 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
693
694         Build fix after @r50760 with ENABLE_FILTERS.
695
696         * platform/graphics/filters/SourceAlpha.cpp:
697         (WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
698         * svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
699           to fillRect.
700
701 2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>
702
703         Reviewed by Alexey Proskuryakov.
704
705         Fix WebSocket frame parser of frame_type with high-order bit set.
706         https://bugs.webkit.org/show_bug.cgi?id=30668
707
708         If buffer is smaller than frame's length, it should break the loop
709         instead of reading next byte.
710
711         Tests: websocket/tests/frame-length-longer-than-buffer.html
712                websocket/tests/frame-length-skip.html
713
714         * websockets/WebSocketChannel.cpp:
715         (WebCore::WebSocketChannel::didReceiveData):
716
717 2009-11-11  Yusuke Sato  <yusukes@chromium.org>
718
719         Reviewed by Adam Barth.
720
721         [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
722         https://bugs.webkit.org/show_bug.cgi?id=31345
723
724         Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.
725
726         * platform/graphics/chromium/FontCustomPlatformData.cpp:
727         (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
728         (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
729         (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.
730
731 2009-11-11  Beth Dakin  <bdakin@apple.com>
732
733         Build fix. No review needed.
734
735         * platform/graphics/gtk/FontGtk.cpp:
736         (WebCore::Font::drawComplexText):
737
738 2009-11-11  Beth Dakin  <bdakin@apple.com>
739
740         Build fix. No review needed.
741
742         * platform/graphics/cairo/FontCairo.cpp:
743         (WebCore::Font::drawGlyphs):
744
745 2009-11-11  Beth Dakin  <bdakin@apple.com>
746
747         Windows build fix. No review needed. 
748
749         * platform/graphics/win/FontCGWin.cpp:
750         (WebCore::Font::drawGlyphs):
751
752 2009-11-11  Beth Dakin  <bdakin@apple.com>
753
754         Reviewed by Simon Fraser.
755
756         Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
757         Make -webkit-color-correction work with shadows
758
759         From canvas, just send DeviceColorSpace to setShadow() for now. 
760         Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
761         * html/canvas/CanvasRenderingContext2D.cpp:
762         (WebCore::CanvasRenderingContext2D::setShadow):
763         (WebCore::CanvasRenderingContext2D::applyShadow):
764
765         setShadow() and setPlatformShadow() now take a ColorSpace.
766         * platform/graphics/GraphicsContext.cpp:
767         (WebCore::GraphicsContext::setShadow):
768         * platform/graphics/GraphicsContext.h:
769         * platform/graphics/cg/GraphicsContextCG.cpp:
770         (WebCore::createCGColorWithColorSpace): New helper to create a 
771         color in a ColorSpace.
772         (WebCore::setCGFillColor): Call new helper.
773         (WebCore::setCGStrokeColor): Call new helper.
774         (WebCore::GraphicsContext::setPlatformShadow): Call new helper.
775         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
776         (WebCore::GraphicsContext::setPlatformShadow):
777
778         Send appropriate ColorSpace to setShadow().
779         * platform/graphics/mac/FontMac.mm:
780         (WebCore::Font::drawGlyphs):
781         * rendering/EllipsisBox.cpp:
782         (WebCore::EllipsisBox::paint):
783         * rendering/InlineFlowBox.cpp:
784         (WebCore::InlineFlowBox::paintTextDecorations):
785         * rendering/InlineTextBox.cpp:
786         (WebCore::paintTextWithShadows):
787         (WebCore::InlineTextBox::paintDecoration):
788         * rendering/RenderBoxModelObject.cpp:
789         (WebCore::RenderBoxModelObject::paintBoxShadow):
790         * rendering/SVGInlineTextBox.cpp:
791         (WebCore::SVGInlineTextBox::paintCharacters):
792         * rendering/SVGRenderSupport.cpp:
793         (WebCore::SVGRenderBase::prepareToRenderSVGContent):
794
795         Attempt to keep ports building.
796         * platform/graphics/cairo/GraphicsContextCairo.cpp:
797         (WebCore::GraphicsContext::setPlatformShadow):
798         * platform/graphics/qt/GraphicsContextQt.cpp:
799         (WebCore::GraphicsContext::setPlatformShadow):
800         * platform/graphics/skia/GraphicsContextSkia.cpp:
801         (WebCore::GraphicsContext::setPlatformShadow):
802         * platform/graphics/wince/GraphicsContextWince.cpp:
803         (WebCore::GraphicsContext::setPlatformShadow):
804         * platform/graphics/wx/GraphicsContextWx.cpp:
805         (WebCore::GraphicsContext::setPlatformShadow):
806
807 2009-11-11  Kent Tamura  <tkent@chromium.org>
808
809         Reviewed by Darin Adler.
810
811         Print the file text of a file upload control in DumpRenderTree for ease of tests.
812         https://bugs.webkit.org/show_bug.cgi?id=31195
813
814         * rendering/RenderFileUploadControl.cpp:
815         (WebCore::RenderFileUploadControl::paintObject):
816         (WebCore::RenderFileUploadControl::fileTextValue):
817         * rendering/RenderFileUploadControl.h:
818         (WebCore::RenderFileUploadControl::isFileUploadControl):
819         (WebCore::toRenderFileUploadControl):
820         * rendering/RenderObject.h:
821         (WebCore::RenderObject::isFileUploadControl):
822         * rendering/RenderTreeAsText.cpp:
823         (WebCore::operator<<):
824
825 2009-11-11  Gavin Barraclough  <barraclough@apple.com>
826
827         Reviewed by Sam Weinig.
828
829         DOM Wrappers for some nodes may not be marked.
830         https://bugs.webkit.org/show_bug.cgi?id=31380
831
832         Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
833         the wrapper for the current world only.  This means that wrappers may be GC'ed
834         prematurely, and properties lost.
835
836         Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.
837
838         * bindings/js/JSAttrCustom.cpp:
839         (WebCore::JSAttr::markChildren):
840         * bindings/js/JSDOMBinding.cpp:
841         (WebCore::markDOMNodeWrapper):
842         * bindings/js/JSDOMBinding.h:
843         * bindings/js/JSNamedNodeMapCustom.cpp:
844         (WebCore::JSNamedNodeMap::markChildren):
845         * bindings/js/JSNodeCustom.cpp:
846         (WebCore::JSNode::markChildren):
847         * bindings/js/JSSVGElementInstanceCustom.cpp:
848         (WebCore::JSSVGElementInstance::markChildren):
849         * bindings/js/JSStyleSheetCustom.cpp:
850         (WebCore::JSStyleSheet::markChildren):
851
852 2009-11-11  Ben Murdoch  <benm@google.com>
853
854         Reviewed by Darin Adler.
855
856         bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
857         https://bugs.webkit.org/show_bug.cgi?id=31384
858
859         No functionality change so no tests required.
860
861         * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.
862
863 2009-11-11  Jens Alfke  <snej@chromium.org>
864
865         Reviewed by Dimitri Glazkov.
866
867         The Big De-Inlining. 450k code size reduction (32-bit x86.)
868         - Various inline functions in V8Binding.h made non-inline.
869         - Some renaming for consistency.
870         - New function createRawTemplate().
871         https://bugs.webkit.org/show_bug.cgi?id=31383
872
873         * bindings/scripts/CodeGeneratorV8.pm:
874         * bindings/v8/V8Binding.cpp:
875         (WebCore::v8DOMWrapperToNative):
876         (WebCore::v8ValueToWebCoreString):
877         (WebCore::v8ValueToAtomicWebCoreString):
878         (WebCore::toInt32):
879         (WebCore::toWebCoreString):
880         (WebCore::toWebCoreStringWithNullCheck):
881         (WebCore::toAtomicWebCoreStringWithNullCheck):
882         (WebCore::toWebCoreStringWithNullOrUndefinedCheck):
883         (WebCore::isUndefinedOrNull):
884         (WebCore::v8Boolean):
885         (WebCore::v8UndetectableString):
886         (WebCore::v8StringOrNull):
887         (WebCore::v8StringOrUndefined):
888         (WebCore::v8StringOrFalse):
889         (WebCore::v8StringToWebCoreString):
890         (WebCore::v8ExternalString):
891         (WebCore::createRawTemplate):  New function.
892         * bindings/v8/V8Binding.h:
893         (WebCore::v8DOMWrapperTo):
894         (WebCore::v8DOMWrapperToNode):
895         (WebCore::v8StringToWebCoreString):
896         (WebCore::v8StringToAtomicWebCoreString):
897
898 2009-11-11  Jens Alfke  <snej@chromium.org>
899
900         Reviewed by Dimitri Glazkov.
901
902         More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
903         event-listener setter into a new subroutine transferHiddenDependency().
904         https://bugs.webkit.org/show_bug.cgi?id=31377
905
906         * bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
907         * bindings/v8/V8Utilities.cpp:
908         (WebCore::transferHiddenDependency):  New.
909         * bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.
910
911 2009-11-11  Brian Weinstein  <bweinstein@apple.com>
912
913         Reviewed by Beth Dakin.
914
915         If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
916         because there is a CG bug preventing this from working.
917
918         * platform/graphics/cg/GraphicsContextCG.cpp:
919         (WebCore::sRGBColorSpaceRef):
920
921 2009-11-11  Pavel Feldman  <pfeldman@chromium.org>
922
923         Reviewed by Timothy Hatcher.
924
925         Check that if Storage panel exists before calling its methods
926
927         https://bugs.webkit.org/show_bug.cgi?id=31343
928
929         * inspector/front-end/inspector.js:
930         (WebInspector.addDatabase):
931         (WebInspector.addCookieDomain):
932         (WebInspector.addDOMStorage):
933         (WebInspector.updateDOMStorage):
934
935 2009-11-11  Jens Alfke  <snej@chromium.org>
936
937         Reviewed by Dimitri Glazkov.
938
939         De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
940         times in the generated V8 bindings.
941         https://bugs.webkit.org/show_bug.cgi?id=31368
942
943         * bindings/v8/V8DOMWrapper.cpp:
944         (WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
945         * bindings/v8/V8DOMWrapper.h:  Removed inline method body.
946
947 2009-11-11  Jessie Berlin  <jberlin@webkit.org>
948
949         Reviewed by Timothy Hatcher.
950
951         Display the correct summary in the web inspector for the shorthands
952         border-color, border-width, border-style, margin, and padding.
953         https://bugs.webkit.org/show_bug.cgi?id=7987
954
955         Test: fast/css/shorthands-four-values.html
956
957         * css/CSSMutableStyleDeclaration.cpp:
958         (WebCore::CSSMutableStyleDeclaration::get4Values):
959         Display the summary information in the same way the shorthand would be
960         specified in a css rule.
961
962 2009-11-11  Jens Alfke  <snej@chromium.org>
963
964         Reviewed by Dimitri Glazkov.
965
966         Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
967         meaning to the caller, saves code, and appears to save a few cycles at runtime too.
968         https://bugs.webkit.org/show_bug.cgi?id=31367
969
970         * bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"
971
972 2009-11-11  Jens Alfke  <snej@chromium.org>
973
974         Reviewed by Dimitri Glazkov.
975
976         Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
977
978         * bindings/v8/DOMData.cpp:
979         (WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
980             so it can be inlined by its caller.
981         * bindings/v8/DOMData.h:
982         * bindings/v8/MainThreadDOMData.cpp:
983         (WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
984         (WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
985         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
986             and getStore, which inline both calls together.
987         * bindings/v8/MainThreadDOMData.h:
988         (WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
989         * bindings/v8/V8DOMMap.cpp:
990         (WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.
991
992 2009-11-11  Nate Chapin  <japhet@chromium.org>
993
994         Reviewed by Dimitri Glazkov.
995
996         Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.
997
998         https://bugs.webkit.org/show_bug.cgi?id=31357
999
1000         * platform/KURLGoogle.cpp:
1001         (WebCore::isSchemeFirstChar):
1002         (WebCore::isSchemeChar):
1003         (WebCore::KURL::hasPort):
1004         (WebCore::KURL::removePort):
1005         (WebCore::protocolIsValid):
1006
1007 2009-11-11  Brent Fulgham  <bfulgham@webkit.org>
1008
1009         Build fix, no reviewed.
1010
1011         Correct setPlatformFillColor and setPlatformStrokeColor calls
1012         to match new ColorSpace-supporting signatures.
1013
1014         * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
1015           color space to the set[...]Color calls.
1016
1017 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1018
1019         Reviewed by Sam Weinig.
1020
1021         https://bugs.webkit.org/show_bug.cgi?id=31327
1022         Clean up SocketStreamHandleClient interface
1023
1024         No change in behavior.
1025
1026         * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
1027         (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
1028         the only client (WebSocketChannel), and it's not clear what this callback's semantics
1029         should be.
1030         (WebCore::SocketStreamHandleClient::willSendData): Ditto.
1031         (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
1032         For ResourceHandle, this method is called when the user cancels authentication sheet,
1033         not when something happens with the stream.
1034
1035         * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
1036         reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.
1037
1038         * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
1039         callbacks have no real implementation yet.
1040
1041 2009-11-11  Zoltan Horvath  <zoltan@webkit.org>
1042
1043         Reviewed by Eric Seidel.
1044
1045         Allow custom memory allocation control for the part of page directory in WebCore
1046         https://bugs.webkit.org/show_bug.cgi?id=31350
1047
1048         Inherits the following classes from Noncopyable because these are instantiated
1049         by 'new' and these are no need to be copyable:
1050
1051         class DragController         - instantiated at: WebCore/page/Page.cpp:107
1052         class FocusController        - instantiated at: WebCore/page/Page.cpp:109
1053         class Settings               - instantiated at: WebCore/page/Page.cpp:116
1054         class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
1055         struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
1056         class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
1057         struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
1058         class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
1059         class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222
1060
1061         Inherits PropertyWrapperBase class from Noncopyable because (its child class) 
1062         PropertyWrapper is instantiated by 'new' in 
1063         WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.
1064
1065         * page/DragController.h:
1066         * page/EventHandler.h:
1067         * page/FocusController.h:
1068         * page/FrameView.cpp:
1069         * page/PluginHalter.h:
1070         * page/Settings.h:
1071         * page/UserScript.h:
1072         * page/UserStyleSheet.h:
1073         * page/XSSAuditor.h:
1074         * page/animation/AnimationBase.cpp:
1075
1076 2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1077
1078         Reviewed by Kenneth Rohde Christiansen.
1079
1080         https://bugs.webkit.org/show_bug.cgi?id=31323
1081         Fix a few compiler warnings
1082
1083         No new tests as there is no new functionality.
1084
1085         * editing/htmlediting.cpp:
1086         (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
1087         parentheses to silence gcc 4.4 -Wparentheses warnings
1088
1089 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1090
1091         Reviewed by Mark Rowe.
1092
1093         Set m_hasPendingGeometryChange to true by default, so that
1094         at least one call to NPP_SetWindow is executed, which is
1095         needed by the DRT plugin testing framework.
1096
1097         * plugins/PluginView.cpp:
1098         (WebCore::PluginView::PluginView):
1099
1100 2009-11-11  Csaba Osztrogonác  <ossy@webkit.org>
1101
1102         Rubber-stamped by Kenneth Rohde Christiansen.
1103
1104         https://bugs.webkit.org/show_bug.cgi?id=31348
1105         [Qt] Remove unnecessary LUT creator from WebCore.pro
1106
1107         * WebCore.pro:
1108
1109 2009-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1110
1111         Reviewed by Tor Arne Vestbø.
1112
1113         Introduce a function for querying the input method status
1114         in QWebPageClient.
1115
1116         * platform/qt/QWebPageClient.h:
1117
1118 2009-11-11  Benjamin Otte  <otte@gnome.org>
1119
1120         Reviewed by Jan Alonzo.
1121
1122         [GTK] Black artifacts in youtube.com/html5
1123
1124         Paint the video to the given size. It's the job of the callers to keep
1125         track of aspect ratio. RenderVideo.cpp does it for the <video>
1126         element.
1127         https://bugs.webkit.org/show_bug.cgi?id=30925
1128
1129         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1130         (WebCore::MediaPlayerPrivate::paint):
1131
1132 2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1133
1134         Reviewed by Reviewed by Jan Alonzo.
1135
1136         https://bugs.webkit.org/show_bug.cgi?id=30901
1137         [Gtk] Need to de-lint the Atk a11y code
1138
1139         Cleaned up some missed capitalization style-guideline violations.
1140
1141         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1142
1143 2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1144
1145         Reviewed by Eric Seidel.
1146
1147         [Qt] Make the default style background color valid.
1148         Currently the color is transparent but invalid, this causes
1149         list boxes in QtWebKit to be drawn with a black background
1150         since r49242.
1151         https://bugs.webkit.org/show_bug.cgi?id=31295
1152
1153         * rendering/style/RenderStyle.h:
1154         (WebCore::InheritedFlags::initialBackgroundColor):
1155         * rendering/style/StyleBackgroundData.cpp:
1156         (WebCore::StyleBackgroundData::StyleBackgroundData):
1157
1158 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1159
1160         Reviewed by Geoff Garen.
1161
1162         Simplify the ownership model for worlds - rather than having a pair of weak references
1163         between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
1164         ref pointer to the former.  This reduces complexity & cost of the caching entries in the
1165         back forward cache.
1166
1167         * WebCore.base.exp:
1168         * bindings/js/JSDOMBinding.cpp:
1169         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1170         * bindings/js/JSDOMBinding.h:
1171         (WebCore::DOMWrapperWorld::forgetDocument):
1172         * bindings/js/ScriptCachedFrameData.cpp:
1173         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1174         (WebCore::ScriptCachedFrameData::restore):
1175         (WebCore::ScriptCachedFrameData::clear):
1176         * bindings/js/ScriptCachedFrameData.h:
1177         * bindings/js/ScriptController.cpp:
1178         (WebCore::ScriptController::~ScriptController):
1179         (WebCore::ScriptController::clearWindowShell):
1180         (WebCore::ScriptController::initScript):
1181         (WebCore::ScriptController::updateDocument):
1182         * bindings/js/ScriptController.h:
1183
1184 2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>
1185
1186         Reviewed by Darin Adler.
1187
1188         rename counter to makeCounterNode in RenderCounter.cpp
1189         https://bugs.webkit.org/show_bug.cgi?id=31289
1190
1191         No new test because this is just a small refactoring.
1192
1193         * rendering/RenderCounter.cpp:
1194         (WebCore::findPlaceForCounter):
1195         (WebCore::makeCounterNode):
1196         (WebCore::RenderCounter::originalText):
1197
1198 2009-11-10  Daniel Bates  <dbates@webkit.org>
1199
1200         Reviewed by Oliver Hunt.
1201
1202         https://bugs.webkit.org/show_bug.cgi?id=30754
1203
1204         Patch 2 of 2.
1205
1206         Removed method EventHandler::dragSourceMovedTo, since it is no longer
1207         needed. This method fired a drag event whenever the mouse moved, but
1208         section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
1209         model independent of when the mouse moves. See "Among other changes..."
1210         in the change log for patch 1 for more details.
1211
1212         * WebCore.DragSupport.exp:
1213         * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
1214         (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
1215         * page/EventHandler.h:
1216
1217 2009-11-10  Daniel Bates  <dbates@webkit.org>
1218
1219         Reviewed by Oliver Hunt.
1220
1221         https://bugs.webkit.org/show_bug.cgi?id=30754
1222
1223         Patch 1 of 2.
1224
1225         As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
1226         the drag event should always fire before the dragover event.
1227
1228         In fixing this bug, this patch also makes our drag processing model
1229         conform to the HTML 5 spec.
1230
1231         Among the changes, this patch ensures that the drag event isn't fired outside
1232         of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
1233         Currently, the drag event is fired whenever the mouse button is down and the OS
1234         detects the mouse moved. But, as per the spec, the drag event should
1235         fire approx. every 350ms so long as the mouse button is down.
1236
1237         Test: fast/events/drag-and-drop-fire-drag-dragover.html
1238
1239         * page/EventHandler.cpp:
1240         (WebCore::EventHandler::clear):
1241         (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
1242         Modified to determine when we are in the correct instance of EventHandler to service the drag
1243         and drop operation.
1244         (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
1245         into this method.
1246         (WebCore::EventHandler::cancelDragAndDrop):
1247         (WebCore::EventHandler::performDragAndDrop):
1248         (WebCore::EventHandler::clearDragState):
1249         * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
1250         we should fire both drag and dragover events or only the dragover event.
1251
1252 2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>
1253
1254         Reviewed by Dimitri Glazkov.
1255
1256         [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
1257         https://bugs.webkit.org/show_bug.cgi?id=31301
1258
1259         Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.
1260
1261         Allowed passing V8Proxy for the calling JS context:
1262         * bindings/v8/V8DOMWrapper.h:
1263         (WebCore::V8DOMWrapper::getXPathNSResolver):
1264         * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
1265         (WebCore::V8CustomXPathNSResolver::create):
1266         (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
1267         (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
1268         * bindings/v8/custom/V8CustomXPathNSResolver.h:
1269         * bindings/v8/custom/V8DocumentCustom.cpp:
1270         (WebCore::CALLBACK_FUNC_DECL):
1271
1272 2009-11-10  Yael Aharon  <yael.aharon@nokia.com>
1273
1274         Reviewed by Timothy Hatcher.
1275
1276         Implement URL decomposition IDL attributes for HTMLAnchorElement.
1277         https://bugs.webkit.org/show_bug.cgi?id=29972.
1278
1279         Add methods for setting different parts of the URL in href attribute.
1280
1281         Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
1282                fast/dom/HTMLAnchorElement/set-href-attribute-host.html
1283                fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
1284                fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
1285                fast/dom/HTMLAnchorElement/set-href-attribute-port.html
1286                fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
1287                fast/dom/HTMLAnchorElement/set-href-attribute-search.html
1288
1289         * bindings/js/JSLocationCustom.cpp:
1290         (WebCore::JSLocation::setPort):
1291         * html/HTMLAnchorElement.cpp:
1292         (WebCore::parsePortFromStringPosition):
1293         (WebCore::HTMLAnchorElement::setHash):
1294         (WebCore::HTMLAnchorElement::setHost):
1295         (WebCore::HTMLAnchorElement::setHostname):
1296         (WebCore::HTMLAnchorElement::setPathname):
1297         (WebCore::HTMLAnchorElement::setPort):
1298         (WebCore::HTMLAnchorElement::setProtocol):
1299         (WebCore::HTMLAnchorElement::setSearch):
1300         * html/HTMLAnchorElement.h:
1301         * html/HTMLAnchorElement.idl:
1302         * loader/FrameLoader.cpp:
1303         (WebCore::FrameLoader::iconURL):
1304         * platform/KURL.cpp:
1305         (WebCore::KURL::removePort):
1306         (WebCore::KURL::setPort):
1307         (WebCore::KURL::prettyURL):
1308         (WebCore::protocolIsValid):
1309         * platform/KURL.h:
1310         (WebCore::KURL::canSetHostOrPort):
1311         (WebCore::KURL::canSetPathname):
1312         (WebCore::KURL::hasPort):
1313         * platform/network/soup/ResourceHandleSoup.cpp:
1314         (WebCore::):
1315
1316 2009-11-10  Nate Chapin  <japhet@chromium.org>
1317
1318         Unreviewed, fix Chromium build after http://trac.webkit.org/changeset/50760.
1319
1320         * platform/chromium/PopupMenuChromium.cpp:
1321         (WebCore::PopupContainer::paintBorder):
1322         (WebCore::PopupListBox::paint):
1323         (WebCore::PopupListBox::paintRow):
1324         * platform/graphics/chromium/TransparencyWin.cpp:
1325         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1326         * platform/graphics/skia/GraphicsContextSkia.cpp:
1327         (WebCore::GraphicsContext::fillRect):
1328         (WebCore::GraphicsContext::fillRoundedRect):
1329         (WebCore::GraphicsContext::setPlatformFillColor):
1330         (WebCore::GraphicsContext::setPlatformStrokeColor):
1331         * rendering/RenderMediaControlsChromium.cpp:
1332         (WebCore::paintMediaSlider):
1333         (WebCore::paintMediaVolumeSlider):
1334         (WebCore::paintMediaTimelineContainer):
1335         * rendering/RenderThemeChromiumMac.mm:
1336         (WebCore::RenderThemeChromiumMac::paintMenuListButton):
1337
1338 2009-11-10  Brady Eidson  <beidson@apple.com>
1339
1340         Reviewed by Sam Weinig.
1341
1342         Repro crash saving pcmag.com article as a webarchive.
1343         <rdar://problem/7381219> and https://webkit.org/b/31322
1344
1345         Test: http/tests/webarchive/cross-origin-stylesheet-crash.html
1346
1347         * css/CSSStyleSheet.cpp:
1348         (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
1349           of creating a CSSRuleList (and subjecting ourselves to the security origin check)
1350
1351 2009-11-10  Beth Dakin  <bdakin@apple.com>
1352
1353         Attempt 2 to fix Tiger build. No review needed.
1354
1355         * platform/graphics/cg/GraphicsContextCG.cpp:
1356         (WebCore::deviceRGBColorSpaceRef):
1357         (WebCore::sRGBColorSpaceRef):
1358
1359 2009-11-10  Kevin Ollivier  <kevino@theolliviers.com>
1360
1361         wx build fix. Changes needed after r50760.
1362
1363         * platform/graphics/wx/GraphicsContextWx.cpp:
1364         (WebCore::GraphicsContext::GraphicsContext):
1365         * platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp:
1366         (WebCore::drawTextWithSpacing):
1367
1368 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1369
1370         Qt build fix.
1371
1372         * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
1373         that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).
1374
1375 2009-11-10  Beth Dakin  <bdakin@apple.com>
1376
1377         Tiger build fix. No review needed.
1378
1379         * platform/graphics/cg/GraphicsContextCG.cpp:
1380         (WebCore::sRGBColorSpaceRef):
1381
1382 2009-11-10  Alexey Proskuryakov  <ap@apple.com>
1383
1384         Reviewed by Dan Bernstein.
1385
1386         https://bugs.webkit.org/show_bug.cgi?id=31312
1387         Decouple authentication panel callbacks from ResourceHandle
1388
1389         No change in functionality.
1390
1391         SocketStreamHandle also needs to request credentials, so it's not appropriate to store
1392         ResourceHandle as delegate.
1393
1394         * WebCore.vcproj/WebCore.vcproj:
1395         * platform/network/AuthenticationClient.h: Added.
1396         Added a new interface for listening to authentication panel notifications.
1397
1398         * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
1399         it wants with the project file.
1400
1401         (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
1402         interface class.
1403         (WebCore::AuthenticationClient::deref): Ditto.
1404
1405         * platform/network/ResourceHandle.h:
1406         (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
1407         (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.
1408
1409         * platform/network/cf/AuthenticationCF.cpp:
1410         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
1411         (WebCore::AuthenticationChallenge::platformCompare):
1412         * platform/network/cf/AuthenticationChallenge.h:
1413         (WebCore::AuthenticationChallenge::authenticationClient):
1414         * platform/network/chromium/AuthenticationChallenge.h:
1415         (WebCore::AuthenticationChallenge::authenticationClient):
1416         * platform/network/curl/AuthenticationChallenge.h:
1417         (WebCore::AuthenticationChallenge::authenticationClient):
1418         Keeping a reference to AuthenticationClient, not to ResourceHandle.
1419
1420 2009-11-10  Beth Dakin  <bdakin@apple.com>
1421
1422        Second attempted gtk build fix. No review needed.
1423
1424         * html/canvas/CanvasStyle.cpp:
1425         (WebCore::CanvasStyle::applyStrokeColor):
1426
1427
1428 2009-11-10  Gavin Barraclough  <barraclough@apple.com>
1429
1430         Reviewed by Geoff Garen.
1431
1432         Fix back/forwards cache with JSC isolated worlds.
1433         https://bugs.webkit.org/show_bug.cgi?id=31310
1434         <rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world
1435
1436         Store the global object for all worlds, not just the normal world.
1437         Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
1438         so we can forget global objects if a world goes away.
1439
1440         * bindings/js/JSDOMBinding.cpp:
1441         (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
1442         * bindings/js/JSDOMBinding.h:
1443         (WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
1444         (WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
1445         * bindings/js/ScriptCachedFrameData.cpp:
1446         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
1447         (WebCore::ScriptCachedFrameData::forgetWorld):
1448         (WebCore::ScriptCachedFrameData::domWindow):
1449         (WebCore::ScriptCachedFrameData::restore):
1450         (WebCore::ScriptCachedFrameData::clear):
1451         * bindings/js/ScriptCachedFrameData.h:
1452         * bindings/js/ScriptController.h:
1453
1454 2009-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1455
1456         [Qt] Unreviewed buildfix after r50760.
1457
1458         * platform/graphics/qt/GraphicsContextQt.cpp:
1459         (WebCore::GraphicsContext::GraphicsContext):
1460
1461 2009-11-10  Beth Dakin  <bdakin@apple.com>
1462
1463         Attempted build fix. (No review needed.)
1464
1465         * GNUmakefile.am: Adding ColorSpace.h
1466
1467 2009-11-10  Brian Weinstein  <bweinstein@apple.com>
1468
1469         Reviewed by NOBODY - Build Fix.
1470
1471         Updated function calls to take a ColorSpace argument, passing
1472         in DeviceColorSpace for now - this should be fixed. Also added
1473         ColorSpace.h to WebCore project.
1474
1475         * WebCore.vcproj/WebCore.vcproj:
1476         * platform/graphics/win/FontCGWin.cpp:
1477         (WebCore::Font::drawGlyphs):
1478         * platform/graphics/win/GraphicsContextCGWin.cpp:
1479         (WebCore::GraphicsContext::GraphicsContext):
1480         * platform/win/PopupMenuWin.cpp:
1481         (WebCore::PopupMenu::paint):
1482         * platform/win/WebCoreTextRenderer.cpp:
1483         (WebCore::doDrawTextAtPoint):
1484         * rendering/RenderThemeSafari.cpp:
1485         (WebCore::RenderThemeSafari::paintMenuListButton):
1486
1487 2009-11-10  Jens Alfke  <snej@chromium.org>
1488
1489         Reviewed by Darin Adler.
1490
1491         Optimizations to Element::getAttribute
1492         https://bugs.webkit.org/show_bug.cgi?id=30926
1493
1494         * dom/Element.cpp:
1495         (WebCore::Element::getAttribute):  User case-insensitive compare instead of lowercasing the name.
1496         * dom/NamedAttrMap.cpp:
1497         (WebCore::NamedNodeMap::getAttributeItem):  Avoid redundant compares, and do fast/likely compares first.
1498         * platform/text/PlatformString.h:
1499         (WebCore::equalPossiblyIgnoringCase):  New inline method, used by both of the above.
1500
1501 2009-11-10  Beth Dakin  <bdakin@apple.com>
1502
1503         Reviewed by Darin Adler.
1504
1505         Fix for <rdar://problem/7059710> 
1506         -and corresponding-
1507         https://bugs.webkit.org/show_bug.cgi?id=31196 Implement -webkit-
1508         color-correction for CSS colors
1509
1510         New exported symbol for GraphicsContext::fillColor() which now 
1511         accepts a ColorSpace as an optional parameter.
1512         * WebCore.base.exp:
1513
1514         Added a new file, ColorSpace.h, to define the ColorSpace enum.
1515         * WebCore.xcodeproj/project.pbxproj:
1516
1517         Computed Style for -webkit-color-correction
1518         * css/CSSComputedStyleDeclaration.cpp:
1519         (WebCore::):
1520         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1521
1522         Parse -webkit-color-correction
1523         * css/CSSParser.cpp:
1524         (WebCore::CSSParser::parseValue):
1525
1526        Map CSS identifiers to the appropriate values of the ColorSpace enum
1527         * css/CSSPrimitiveValueMappings.h:
1528         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1529         (WebCore::CSSPrimitiveValue::operator ColorSpace):
1530
1531         New property -webkit-color-correction
1532         * css/CSSPropertyNames.in:
1533
1534         Map -webkit-color-correction into the RenderStyle.
1535         * css/CSSStyleSelector.cpp:
1536         (WebCore::CSSStyleSelector::applyProperty):
1537
1538         Add new value sRGB.
1539         * css/CSSValueKeywords.in:
1540
1541         Comment out the reference to sRGB since it will now be inherited as 
1542         a value from CSSValueKeywords.
1543         * css/SVGCSSValueKeywords.in:
1544
1545         Definition of the ColorSpace enum.
1546         * platform/graphics/ColorSpace.h: Added.
1547         (WebCore::):
1548
1549         These functions all now take a ColorSpace as a parameter.
1550         * platform/graphics/GraphicsContext.cpp:
1551         (WebCore::GraphicsContext::setStrokeColor):
1552         (WebCore::GraphicsContext::setFillColor):
1553         (WebCore::GraphicsContext::drawHighlightForText):
1554
1555         Return the appropriate ColorSpace.
1556         (WebCore::GraphicsContext::strokeColorSpace):
1557         (WebCore::GraphicsContext::fillColorSpace):
1558
1559         These functions all call other functions which require a ColorSpace 
1560         as a parameter.
1561         (WebCore::GraphicsContext::setStrokePattern):
1562         (WebCore::GraphicsContext::setFillPattern):
1563         (WebCore::GraphicsContext::setStrokeGradient):
1564         (WebCore::GraphicsContext::setFillGradient):
1565
1566         All of the GraphicsContext functions that take a Color should now 
1567         also take a ColorSpace.
1568         * platform/graphics/GraphicsContext.h:
1569
1570         Added new member variables stokeColorSpace and fillColorSpace.
1571         * platform/graphics/GraphicsContextPrivate.h:
1572         (WebCore::GraphicsContextState::GraphicsContextState):
1573
1574         Attempt to keep the Cairo port building with all of the massive 
1575         changes to GraphicsContext.        
1576         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1577         (WebCore::GraphicsContext::fillRect):
1578         (WebCore::GraphicsContext::setPlatformFillColor):
1579         (WebCore::GraphicsContext::setPlatformStrokeColor):
1580         (WebCore::GraphicsContext::fillRoundedRect):
1581
1582         
1583         * platform/graphics/cg/GraphicsContextCG.cpp:
1584         (WebCore::sRGBColorSpaceRef): New static function that returns a 
1585         CGColorSpaceRef for the sRGB color space.
1586         (WebCore::deviceRGBColorSpaceRef): New static function that returns 
1587         a CGColorSpaceRef for the device RGB color space.
1588
1589         (WebCore::setCGFillColor): Now takes a ColorSpace parameter and 
1590         sets the fill color to the specified color in the given ColorSpace.
1591         (WebCore::setCGStrokeColor): Same, but for stroke.
1592
1593         (WebCore::setCGFillColorSpace): New static to set the 
1594         CGFillColorSpace to the given ColorSpace
1595         (WebCore::setCGStrokeColorSpace): Same, but for stroke.
1596
1597         Send ColorSpaces when appropriate, set ColorSpaces when 
1598         appropriate, and check ColorSpaces when appropriate.
1599         (WebCore::GraphicsContext::GraphicsContext):
1600         (WebCore::GraphicsContext::drawRect):
1601         (WebCore::GraphicsContext::drawLine):
1602         (WebCore::GraphicsContext::fillPath):
1603         (WebCore::GraphicsContext::strokePath):
1604         (WebCore::GraphicsContext::fillRect):
1605         (WebCore::GraphicsContext::fillRoundedRect):
1606         (WebCore::GraphicsContext::strokeRect):
1607         (WebCore::GraphicsContext::drawLineForText):
1608         (WebCore::GraphicsContext::setPlatformStrokeColor):
1609         (WebCore::GraphicsContext::setPlatformFillColor):
1610
1611         Attempt to keep Haiku building.
1612         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
1613         (WebCore::GraphicsContext::fillRect):
1614         (WebCore::GraphicsContext::fillRoundedRect):
1615         (WebCore::GraphicsContext::setPlatformStrokeColor):
1616         (WebCore::GraphicsContext::setPlatformFillColor):
1617
1618         Attempt to keep QT building.
1619         * platform/graphics/qt/GraphicsContextQt.cpp:
1620         (WebCore::GraphicsContext::fillRect):
1621         (WebCore::GraphicsContext::fillRoundedRect):
1622         (WebCore::GraphicsContext::setPlatformStrokeColor):
1623         (WebCore::GraphicsContext::setPlatformFillColor):
1624
1625         Attempt to keep Wince building.
1626         * platform/graphics/wince/GraphicsContextWince.cpp:
1627         (WebCore::GraphicsContext::fillRect):
1628         (WebCore::GraphicsContext::setPlatformFillColor):
1629         (WebCore::GraphicsContext::setPlatformStrokeColor):
1630         (WebCore::GraphicsContext::clearRect):
1631         (WebCore::GraphicsContext::fillRoundedRect):
1632         (WebCore::GraphicsContext::setPlatformShadow):
1633
1634         Attempt to keep WX building.
1635         * platform/graphics/wx/GraphicsContextWx.cpp:
1636         (WebCore::GraphicsContext::fillRect):
1637         (WebCore::GraphicsContext::fillRoundedRect):
1638         (WebCore::GraphicsContext::setPlatformStrokeColor):
1639         (WebCore::GraphicsContext::setPlatformFillColor):
1640
1641         Added functions colorSpace() and setColorSpace()
1642         * rendering/style/RenderStyle.h:
1643         (WebCore::InheritedFlags::colorSpace):
1644         (WebCore::InheritedFlags::setColorSpace):
1645
1646         The ColorSpace is stored here.
1647         * rendering/style/StyleRareInheritedData.cpp:
1648         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1649         (WebCore::StyleRareInheritedData::operator==):
1650         * rendering/style/StyleRareInheritedData.h:
1651
1652         All of these call sites call GraphicsContext functions which now 
1653         require ColorSpaces.
1654         * editing/SelectionController.cpp:
1655         (WebCore::SelectionController::paintCaret):
1656         * html/canvas/CanvasRenderingContext2D.cpp:
1657         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1658         * html/canvas/CanvasStyle.cpp:
1659         (WebCore::CanvasStyle::applyStrokeColor):
1660         (WebCore::CanvasStyle::applyFillColor):
1661         * inspector/InspectorController.cpp:
1662         (WebCore::drawOutlinedQuad):
1663         * page/FrameView.cpp:
1664         (WebCore::FrameView::paintContents):
1665         * platform/ScrollbarTheme.h:
1666         (WebCore::ScrollbarTheme::paintScrollCorner):
1667         * platform/ScrollbarThemeComposite.cpp:
1668         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
1669         * platform/graphics/Image.cpp:
1670         (WebCore::Image::fillWithSolidColor):
1671         * platform/graphics/mac/FontMac.mm:
1672         (WebCore::Font::drawGlyphs):
1673         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1674         (WebCore::MediaPlayerPrivate::paint):
1675         * rendering/EllipsisBox.cpp:
1676         (WebCore::EllipsisBox::paint):
1677         * rendering/InlineFlowBox.cpp:
1678         (WebCore::InlineFlowBox::paintTextDecorations):
1679         * rendering/InlineTextBox.cpp:
1680         (WebCore::updateGraphicsContext):
1681         (WebCore::paintTextWithShadows):
1682         (WebCore::InlineTextBox::paint):
1683         (WebCore::InlineTextBox::paintSelection):
1684         (WebCore::InlineTextBox::paintCompositionBackground):
1685         (WebCore::InlineTextBox::paintDecoration):
1686         (WebCore::InlineTextBox::paintTextMatchMarker):
1687         (WebCore::InlineTextBox::paintCompositionUnderline):
1688         * rendering/InlineTextBox.h:
1689         * rendering/RenderBlock.cpp:
1690         (WebCore::RenderBlock::fillHorizontalSelectionGap):
1691         (WebCore::RenderBlock::fillVerticalSelectionGap):
1692         (WebCore::RenderBlock::fillLeftSelectionGap):
1693         (WebCore::RenderBlock::fillRightSelectionGap):
1694         * rendering/RenderBoxModelObject.cpp:
1695         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1696         (WebCore::RenderBoxModelObject::paintBoxShadow):
1697         * rendering/RenderFileUploadControl.cpp:
1698         (WebCore::RenderFileUploadControl::paintObject):
1699         * rendering/RenderFrameSet.cpp:
1700         (WebCore::RenderFrameSet::paintColumnBorder):
1701         (WebCore::RenderFrameSet::paintRowBorder):
1702         * rendering/RenderImage.cpp:
1703         (WebCore::RenderImage::paintReplaced):
1704         * rendering/RenderLayer.cpp:
1705         (WebCore::RenderLayer::paintScrollCorner):
1706         (WebCore::RenderLayer::paintResizer):
1707         * rendering/RenderListBox.cpp:
1708         (WebCore::RenderListBox::paintItemForeground):
1709         (WebCore::RenderListBox::paintItemBackground):
1710         * rendering/RenderListMarker.cpp:
1711         (WebCore::RenderListMarker::paint):
1712         * rendering/RenderObject.cpp:
1713         (WebCore::RenderObject::drawLineForBoxSide):
1714         (WebCore::RenderObject::drawArcForBoxSide):
1715         * rendering/RenderReplaced.cpp:
1716         (WebCore::RenderReplaced::paint):
1717         * rendering/RenderScrollbarTheme.cpp:
1718         (WebCore::RenderScrollbarTheme::paintScrollCorner):
1719         * rendering/RenderThemeMac.mm:
1720         (WebCore::RenderThemeMac::paintMenuListButton):
1721         * rendering/RenderView.cpp:
1722         (WebCore::RenderView::paintBoxDecorations):
1723         * rendering/RenderWidget.cpp:
1724         (WebCore::RenderWidget::paint):
1725         * rendering/SVGInlineTextBox.cpp:
1726         (WebCore::SVGInlineTextBox::paintSelection):
1727         * svg/graphics/SVGPaintServerGradient.cpp:
1728         (WebCore::SVGPaintServerGradient::setup):
1729         * svg/graphics/SVGPaintServerSolid.cpp:
1730         (WebCore::SVGPaintServerSolid::setup):
1731
1732 2009-11-10  Keishi Hattori  <casey.hattori@gmail.com>
1733
1734         Reviewed by Timothy Hatcher.
1735
1736         Web Inspector: Speed up syntax highlighter
1737         https://bugs.webkit.org/show_bug.cgi?id=31291
1738
1739         * inspector/front-end/SourceFrame.js:
1740         (WebInspector.SourceFrame.prototype._loaded):
1741         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): Replace the line content node.
1742         (WebInspector.SourceSyntaxHighlighter.prototype.process):
1743         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
1744         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
1745         (WebInspector.CSSSourceSyntaxHighlighter):
1746         (WebInspector.JavaScriptSourceSyntaxHighlighter):
1747
1748 2009-11-09  Jeremy Orlow  <jorlow@chromium.org>
1749
1750         Reviewed by Eric Seidel.
1751
1752         Remove session storage setting
1753         https://bugs.webkit.org/show_bug.cgi?id=31279
1754
1755         Remove session storage from Settings.  It was added temporarily so we could
1756         disable it by default at runtime in Chromium.  We now disable these things in a
1757         different way, so it's time to remove it.  Qt also depended on this setting for
1758         a short period of time, but after talking to them we agreed that it should be
1759         removed.
1760
1761         This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602
1762
1763         * page/DOMWindow.cpp:
1764         (WebCore::DOMWindow::sessionStorage):
1765         * page/Settings.cpp:
1766         (WebCore::Settings::Settings):
1767         * page/Settings.h:
1768
1769 2009-11-10  Dan Bernstein  <mitz@apple.com>
1770
1771         Reviewed by Eric Carlson and Darin Adler.
1772
1773         WebCore part of making full-screen video pause during scrubbing.
1774
1775         * WebCore.Video.exp: Sorted and added HTMLMediaElement::beginScrubbing()
1776         and HTMLMediaElement::endScrubbing().
1777
1778 2009-11-10  Anton Muhin  <antonm@chromium.org>
1779
1780         Reviewed by Adam Barth.
1781
1782         Reapply 50562 reverted by 50588 due to issues with sandboxing (should be fine now).
1783         https://bugs.webkit.org/show_bug.cgi?id=31051
1784
1785         * bindings/v8/V8GCController.cpp:
1786         (WebCore::V8GCController::gcEpilogue):
1787         (WebCore::V8GCController::checkMemoryUsage):
1788         * bindings/v8/V8GCController.h:
1789         * bindings/v8/V8Proxy.cpp:
1790         (WebCore::V8Proxy::evaluate):
1791         (WebCore::V8Proxy::runScript):
1792         (WebCore::V8Proxy::callFunction):
1793
1794 2009-11-10  Zoltan Horvath  <zoltan@webkit.org>
1795
1796         Reviewed by Darin Adler.
1797
1798         Allow custom memory allocation control for the part of loader directory in WebCore
1799         https://bugs.webkit.org/show_bug.cgi?id=31161
1800
1801         Inherits the following classes from Noncopyable because these are instantiated
1802         by 'new' and these are no need to be copyable:
1803
1804         class Request - WebCore/loader/loader.cpp:100
1805         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
1806         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
1807         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
1808         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
1809         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
1810
1811         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
1812         MainThreadBridge is instantiated by 'new' in 
1813         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
1814
1815         ThreadableLoaderClient's inheriting has been changed to public.
1816
1817         * loader/ImageLoader.cpp:
1818         * loader/ProgressTracker.cpp:
1819         * loader/RedirectScheduler.cpp:
1820         * loader/Request.h:
1821         * loader/ThreadableLoaderClient.h:
1822         * loader/WorkerThreadableLoader.h:
1823         * loader/appcache/ApplicationCacheHost.h:
1824         * loader/appcache/ApplicationCacheStorage.h:
1825
1826 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1827
1828         Reviewed by Eric Seidel.
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=31047
1831         [GTK] Failing test media/video-played-ranges-1.html
1832
1833         WebKit coding style fixes.
1834
1835         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1836         (WebCore::mediaPlayerPrivateMessageCallback):
1837         (WebCore::MediaPlayerPrivate::naturalSize):
1838         (WebCore::MediaPlayerPrivate::paint):
1839         (WebCore::mimeTypeCache):
1840
1841 2009-11-10  Oliver Hunt  <oliver@apple.com>
1842
1843         Remove build failure introduced by earlier build fix.
1844
1845         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1846
1847 2009-11-10  Oliver Hunt  <oliver@apple.com>
1848
1849         Is this the last build fix? grep tells me yes.
1850
1851         * bindings/v8/custom/V8DocumentCustom.cpp:
1852         (WebCore::CALLBACK_FUNC_DECL):
1853
1854 2009-11-10  Oliver Hunt  <oliver@apple.com>
1855
1856         Hopefully the last one.  Why aren't these autogenerated?
1857
1858         * bindings/v8/V8DOMWrapper.cpp:
1859         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
1860         (WebCore::V8DOMWrapper::getTemplate):
1861         (WebCore::V8DOMWrapper::convertToV8Object):
1862
1863 2009-11-10  Oliver Hunt  <oliver@apple.com>
1864
1865         Another chrome build fix.
1866
1867         * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
1868         (WebCore::CALLBACK_FUNC_DECL):
1869
1870 2009-11-10  Oliver Hunt  <oliver@apple.com>
1871
1872         Yet another chrome buildfix
1873
1874         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
1875         (WebCore::CALLBACK_FUNC_DECL):
1876         * bindings/v8/custom/V8WebGLArrayCustom.h:
1877         (WebCore::constructCanvasArray):
1878         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
1879         (WebCore::CALLBACK_FUNC_DECL):
1880         (WebCore::INDEXED_PROPERTY_GETTER):
1881         (WebCore::INDEXED_PROPERTY_SETTER):
1882         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
1883         (WebCore::CALLBACK_FUNC_DECL):
1884         (WebCore::INDEXED_PROPERTY_GETTER):
1885         (WebCore::INDEXED_PROPERTY_SETTER):
1886         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
1887         (WebCore::CALLBACK_FUNC_DECL):
1888         (WebCore::INDEXED_PROPERTY_GETTER):
1889         (WebCore::INDEXED_PROPERTY_SETTER):
1890         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1891         (WebCore::CALLBACK_FUNC_DECL):
1892         (WebCore::vertexAttribAndUniformHelperf):
1893         (WebCore::uniformHelperi):
1894         (WebCore::uniformMatrixHelper):
1895         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
1896         (WebCore::CALLBACK_FUNC_DECL):
1897         (WebCore::INDEXED_PROPERTY_GETTER):
1898         (WebCore::INDEXED_PROPERTY_SETTER):
1899         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
1900         (WebCore::CALLBACK_FUNC_DECL):
1901         (WebCore::INDEXED_PROPERTY_GETTER):
1902         (WebCore::INDEXED_PROPERTY_SETTER):
1903         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
1904         (WebCore::CALLBACK_FUNC_DECL):
1905         (WebCore::INDEXED_PROPERTY_GETTER):
1906         (WebCore::INDEXED_PROPERTY_SETTER):
1907         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
1908         (WebCore::CALLBACK_FUNC_DECL):
1909         (WebCore::INDEXED_PROPERTY_GETTER):
1910         (WebCore::INDEXED_PROPERTY_SETTER):
1911
1912 2009-11-10  Oliver Hunt  <oliver@apple.com>
1913
1914         Chrome build fix.
1915
1916         * bindings/v8/V8Index.h:
1917
1918 2009-11-10  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1919
1920         Reviewed by Reviewed by Jan Alonzo.
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=30901
1923         [Gtk] Need to de-lint the Atk a11y code
1924
1925         Removal of various and sundry style-violating nits.
1926
1927         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1928
1929 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1930
1931         Reviewed by Jan Alonzo.
1932
1933         https://bugs.webkit.org/show_bug.cgi?id=31047
1934         [GTK] Failing test media/video-played-ranges-1.html
1935
1936         Fix playback rate setter by remembering the rate was changed. Also
1937         correctly handle reverse playback by doing a seek from end to
1938         beginning of the media.
1939
1940         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1941         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1942         (WebCore::MediaPlayerPrivate::currentTime):
1943         (WebCore::MediaPlayerPrivate::seek):
1944         (WebCore::MediaPlayerPrivate::hasAudio):
1945         (WebCore::MediaPlayerPrivate::setVolume):
1946         (WebCore::MediaPlayerPrivate::setRate):
1947         (WebCore::MediaPlayerPrivate::updateStates):
1948         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
1949
1950 2009-11-10  Oliver Hunt  <oliver@apple.com>
1951
1952         Reviewed by Maciej Stachowiak.
1953
1954         Rename 3D Canvas related classes to use WebGL prefix
1955         https://bugs.webkit.org/show_bug.cgi?id=29095
1956
1957         Automatic rename of all WebGL related types from Canvas* to
1958         WebGL* per more recent version of the WebGL spec.
1959
1960         Due to the automatic rename I've removed the 600+ line change list.
1961
1962 2009-11-09  Dirk Schulze  <krit@webkit.org>
1963
1964         Reviewed by Oliver Hunt.
1965
1966         SVG feDisplacementMap is not implemented
1967         [https://bugs.webkit.org/show_bug.cgi?id=31255]
1968
1969         This is the implementation of the SVG filter effect
1970         feDisplacementMap. 
1971
1972         Test: svg/filters/feDisplacementMap.svg
1973
1974         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
1975         (WebCore::FEDisplacementMap::apply):
1976
1977 2009-11-09  Kent Tamura  <tkent@chromium.org>
1978
1979         Reviewed by Darin Adler.
1980
1981         Add a comment about null strings and hash functions.
1982         https://bugs.webkit.org/show_bug.cgi?id=29118
1983
1984         * platform/text/StringHash.h:
1985
1986 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1987
1988         Reviewed by Darin Adler.
1989
1990         Compiler warnings in InspectorResource.h
1991         https://bugs.webkit.org/show_bug.cgi?id=29231
1992
1993         Fix compilation warnings by removing addition operation on an enum type.
1994
1995         * inspector/InspectorResource.h:
1996         (WebCore::InspectorResource::):
1997         (WebCore::InspectorResource::Changes::hasChange):
1998         (WebCore::InspectorResource::Changes::set):
1999         (WebCore::InspectorResource::Changes::setAll):
2000
2001 2009-11-09  Anders Carlsson  <andersca@apple.com>
2002
2003         Reviewed by Darin Adler and Dan Bernstein.
2004
2005         <rdar://problem/7328395>
2006         https://bugs.webkit.org/show_bug.cgi?id=31277
2007
2008         When an object tag's style changes (for example when child nodes are added/removed),
2009         reuse its Frame (if it has one) instead of creating multiple Frames.
2010
2011         Test: fast/dom/HTMLObjectElement/children-changed.html
2012
2013         * loader/FrameLoader.cpp:
2014         (WebCore::FrameLoader::requestObject):
2015
2016 2009-11-09  Norbert Leser  <norbert.leser@nokia.com>
2017
2018         Reviewed by Kenneth Rohde Christiansen.
2019
2020         Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
2021         since adjustment of RW-section base address will be needed for all new symbian
2022         tool chains, specifically for arm and gcc compilation targets.
2023         Also, change target address to 0xE00000 to be sufficient for all targets.
2024
2025         * WebCore.pro:
2026
2027 2009-11-09  Pavel Feldman  <pfeldman@chromium.org>
2028
2029         Reviewed by Timothy Hatcher.
2030
2031         Web Inspector: Crash when inspecting
2032         WebCore\manual-tests\inspector\dom-mutation.html
2033
2034         https://bugs.webkit.org/show_bug.cgi?id=31259
2035
2036         * inspector/InspectorDOMAgent.cpp:
2037         (WebCore::InspectorDOMAgent::handleEvent):
2038
2039 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2040
2041         Reviewed by Kenneth Rohde Christiansen.
2042
2043         [Qt] Few classes have virtual functions but non-virtual destructor
2044         https://bugs.webkit.org/show_bug.cgi?id=31269
2045
2046         No new tests as there is no functional change.
2047
2048         * platform/qt/QWebPageClient.h:
2049         (QWebPageClient::~QWebPageClient): Add virtual destructor.
2050
2051 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2052
2053         Reviewed by Kenneth Rohde Christiansen.
2054
2055         [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
2056         https://bugs.webkit.org/show_bug.cgi?id=31140
2057
2058         QtNetwork interprets null string as request to remove the header, not add it.
2059         Replace null values with empty values before passing them to QtNetwork.
2060
2061         Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
2062
2063         * platform/network/qt/ResourceRequestQt.cpp:
2064         (WebCore::ResourceRequest::toNetworkRequest):
2065
2066 2009-11-09  Vadim Zeitlin  <vadim@wxwidgets.org>
2067
2068         Reviewed by Kevin Ollivier.
2069
2070         [wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
2071         simply ignored before resulting in transparent areas being black in PNG
2072         images for example.
2073         
2074         https://bugs.webkit.org/show_bug.cgi?id=30823
2075
2076         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2077         (WebCore::RGBA32Buffer::asNewNativeImage):
2078
2079 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2080
2081         Reviewed by Kenneth Rohde Christiansen.
2082
2083         Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
2084         https://bugs.webkit.org/show_bug.cgi?id=31040
2085
2086         No new tests as there is no functional change.
2087
2088         * dom/Document.cpp:
2089         (WebCore::Document::recalcStyleSelector):
2090         * editing/TextIterator.cpp:
2091         (WebCore::pushFullyClippedState):
2092         * editing/VisibleSelection.cpp:
2093         (WebCore::VisibleSelection::appendTrailingWhitespace):
2094         * html/HTMLLinkElement.cpp:
2095         (WebCore::HTMLLinkElement::process):
2096         * loader/RedirectScheduler.cpp:
2097         (WebCore::RedirectScheduler::mustLockBackForwardList):
2098         * loader/appcache/ApplicationCacheGroup.cpp:
2099         (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
2100         * platform/graphics/qt/FontCacheQt.cpp:
2101         (WebCore::FontPlatformDataCacheKey::computeHash):
2102         * rendering/RenderBlock.cpp:
2103         (WebCore::RenderBlock::handleRunInChild):
2104         * rendering/RenderBox.cpp:
2105         (WebCore::RenderBox::calcHeight):
2106         * rendering/RenderTextControlMultiLine.cpp:
2107         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2108         * rendering/style/RenderStyle.cpp:
2109         (WebCore::RenderStyle::diff):
2110         * svg/SVGAnimateElement.cpp:
2111         (WebCore::parseNumberValueAndUnit):
2112         * svg/SVGAnimationElement.cpp:
2113         (WebCore::SVGAnimationElement::startedActiveInterval):
2114         * svg/SVGPreserveAspectRatio.cpp:
2115         (WebCore::SVGPreserveAspectRatio::getCTM):
2116
2117 2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>
2118
2119         Reviewed by Dimitri Glazkov.
2120
2121         Win chromium is slow to draw transparent texts
2122         https://bugs.webkit.org/show_bug.cgi?id=31258
2123
2124         Clip graphics context to reduce calculation.
2125
2126         No new tests because this change only affects performance.
2127
2128         * platform/graphics/chromium/FontChromiumWin.cpp:
2129         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2130         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
2131
2132 2009-11-09  Carol Szabo  <carol.szabo@nokia.com>
2133
2134         Reviewed by Darin Adler.
2135
2136         showTree(CounterNode*) generates too little info and has too many spaces.
2137         https://bugs.webkit.org/show_bug.cgi?id=31212
2138
2139         No new tests as the change has no functional effect it is just for
2140         improved debugging.
2141
2142         * rendering/CounterNode.cpp:
2143         (WebCore::showTreeAndMark):
2144         Changed to also show addresses of parent, next and previous
2145         siblings.
2146
2147 2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>
2148
2149         Reviewed by Darin Adler.
2150
2151         Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
2152         enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).
2153
2154         https://bugs.webkit.org/show_bug.cgi?id=31083
2155
2156         No new tests; implementation is unchanged.
2157
2158         * page/Frame.cpp:
2159         (WebCore::Frame::setUseSecureKeyboardEntry):
2160         * page/mac/FrameMac.mm:
2161
2162 2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2163
2164         Reviewed by Jan Alonzo.
2165
2166         Make XP_UNIX tests consistent
2167         https://bugs.webkit.org/show_bug.cgi?id=31250
2168
2169         No new tests as there is no functional change.
2170
2171         * plugins/PluginView.cpp:
2172         (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
2173         instead of the value of the macro
2174
2175         * plugins/gtk/PluginViewGtk.cpp:
2176         (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
2177         defined instead of using the PLATFORM macro to be consistent
2178         (WebCore::PluginView::getValue): Ditto.
2179
2180 2009-11-09  Kevin Watters  <kevinwatters@gmail.com>
2181
2182         Reviewed by Darin Adler.
2183
2184         Thunk to the main thread from ~Database to deref Database's m_document.
2185
2186         If the Database was the Document's last referrer, then ~Document occurs on the
2187         Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
2188         ASSERT in debug builds.
2189
2190         * storage/Database.cpp:
2191         (WebCore::derefDocument):
2192         (WebCore::Database::~Database):
2193
2194 2009-11-09  Mark Mentovai  <mark@chromium.org>
2195
2196         Reviewed by Dan Bernstein.
2197
2198         Track "can have scrollbar" state within FrameView independently of the
2199         individual scrollbar states in ScrollView.
2200
2201         rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
2202         REGRESSION (r48064): mint.com loses scrollbars after coming out of
2203         edit mode.
2204
2205         rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
2206         REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.
2207
2208         Test: fast/overflow/scrollbar-restored.html
2209
2210         * WebCore.base.exp:
2211         * page/FrameView.cpp:
2212         (WebCore::FrameView::FrameView):
2213         (WebCore::FrameView::resetScrollbars):
2214         (WebCore::FrameView::setCanHaveScrollbars):
2215         (WebCore::FrameView::updateCanHaveScrollbars):
2216         (WebCore::FrameView::layout):
2217         * page/FrameView.h:
2218         * platform/ScrollView.h:
2219
2220 2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>
2221
2222         Reviewed by Timothy Hatcher.
2223
2224         Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
2225         https://bugs.webkit.org/show_bug.cgi?id=31257
2226
2227         * inspector/front-end/SourceFrame.js:
2228
2229 2009-11-09  Alexander Pavlov  <apavlov@chromium.org>
2230
2231         Reviewed by Timothy Hatcher.
2232
2233         Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
2234         https://bugs.webkit.org/show_bug.cgi?id=31252
2235
2236         Route F1-F12 keypresses in the Console view to the current panel if there is one.
2237
2238         Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html
2239
2240         * inspector/front-end/ConsoleView.js:
2241         (WebInspector.ConsoleView.prototype._promptKeyDown):
2242         * inspector/front-end/utilities.js:
2243         ():
2244         * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.
2245
2246 2009-11-09  Yael Aharon  <yael.aharon@nokia.com>
2247
2248         Reviewed by Kenneth Rohde Christiansen.
2249
2250         [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
2251         https://bugs.webkit.org/show_bug.cgi?id=31208
2252
2253         After r42483, the credentials are no longer passed to the network request
2254         in the URL of the request.
2255         Pass the credentials from XMLHTTPRequest to the network request, the same
2256         way that other ports do.
2257
2258         After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.
2259
2260         * platform/network/qt/ResourceHandleQt.cpp:
2261         (WebCore::ResourceHandle::start):
2262         (WebCore::ResourceHandle::loadResourceSynchronously):
2263
2264 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2265
2266         Unreviewed.
2267
2268         https://bugs.webkit.org/show_bug.cgi?id=31161
2269
2270         Roll back r50657 because it breaks the MAC builds.
2271
2272         * loader/ImageLoader.cpp:
2273         * loader/ProgressTracker.cpp:
2274         * loader/RedirectScheduler.cpp:
2275         * loader/Request.h:
2276         * loader/ThreadableLoaderClient.h:
2277         * loader/WorkerThreadableLoader.h:
2278         * loader/appcache/ApplicationCacheHost.h:
2279         * loader/appcache/ApplicationCacheStorage.h:
2280         * loader/icon/IconDatabaseClient.h:
2281
2282 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2283
2284         Reviewed by Darin Adler.
2285
2286         Allow custom memory allocation control for the part of loader directory in WebCore
2287         https://bugs.webkit.org/show_bug.cgi?id=31161
2288
2289         Inherits the following classes from Noncopyable because these are instantiated
2290         by 'new' and these are no need to be copyable:
2291
2292         class Request - WebCore/loader/loader.cpp:100
2293         struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
2294         class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
2295         class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
2296         class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
2297         class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
2298         struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169
2299
2300         Inherits ThreadableLoaderClient class from Noncopyable because (its child class) 
2301         MainThreadBridge is instantiated by 'new' in 
2302         WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.
2303
2304         ThreadableLoaderClient's inheriting has been changed to public.
2305
2306         * loader/ImageLoader.cpp:
2307         * loader/ProgressTracker.cpp:
2308         * loader/RedirectScheduler.cpp:
2309         * loader/Request.h:
2310         * loader/ThreadableLoaderClient.h:
2311         * loader/WorkerThreadableLoader.h:
2312         * loader/appcache/ApplicationCacheHost.h:
2313         * loader/appcache/ApplicationCacheStorage.h:
2314         * loader/icon/IconDatabaseClient.h:
2315
2316 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2317
2318         Reviewed by Darin Adler.
2319
2320         Allow custom memory allocation control for WebCore's DocLoader
2321         https://bugs.webkit.org/show_bug.cgi?id=31163
2322
2323         Inherits DocLoader class from Noncopyable because it is
2324         instantiated by 'new' in WebCore/dom/Document.cpp:370 and 
2325         it is no need to be copyable.
2326
2327         * loader/DocLoader.h:
2328
2329 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2330
2331         Reviewed by Darin Adler.
2332
2333         Allow custom memory allocation control for WebCore's Tokenizer
2334         https://bugs.webkit.org/show_bug.cgi?id=31162
2335
2336         Inherits Tokenizer class from Noncopyable because (its child class)
2337         ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178 
2338         and it is no need to be copyable.
2339
2340         * dom/Tokenizer.h:
2341
2342 2009-11-09  Zoltan Horvath  <zoltan@webkit.org>
2343
2344         Reviewed by Darin Adler.
2345
2346         Allow custom memory allocation control for WebCore's DeleteButtonController
2347         https://bugs.webkit.org/show_bug.cgi?id=31105
2348
2349         Inherits DeleteButtonController class from Noncopyable because it is 
2350         instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
2351         it is no need to be copyable.  
2352
2353         * editing/DeleteButtonController.h:
2354
2355 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2356
2357         Reviewed by Jan Alonzo.
2358
2359         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2360         https://bugs.webkit.org/show_bug.cgi?id=30482
2361
2362         Expose Page::tabKeyCyclesThroughElements as a property of
2363         WebKitWebView.
2364
2365         No new tests; fast/events/keypress-insert-tab.html is no longer skipped.
2366
2367         * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
2368         (WebCore::singleCharacterString):
2369
2370 2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2371
2372         Reviewed by Xan Lopez.
2373
2374         https://bugs.webkit.org/show_bug.cgi?id=25415
2375         [GTK][ATK] Please implement support for get_text_at_offset
2376
2377         Fix a crasher that occurred with text which included newline
2378         chars in the markup.
2379
2380         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2381         (convertUniCharToUTF8):
2382
2383 2009-11-05  Jakub Wieczorek  <faw217@gmail.com>
2384
2385         Reviewed by Holger Freyther.
2386
2387         [Qt] The XML tokenizer reports a parse error twice if it occurs before the document element is found.
2388         https://bugs.webkit.org/show_bug.cgi?id=31144
2389
2390         XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
2391         documents that end prematurely but are not considered invalid by QXmlStream.
2392         This is to stay compatible with the libxml2 implementation.
2393         However, that code path would be also hit in situations when it should not,
2394         i.e. the error would have already been caught and handled. As a result, the
2395         same error would be reported twice.
2396
2397         No new tests, because the problem is already covered by
2398         fast/parser/xml-declaration-missing-ending-mark.html.
2399
2400         * dom/XMLTokenizerQt.cpp:
2401         (WebCore::XMLTokenizer::doEnd):
2402
2403 2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>
2404
2405         Reviewed by Pavel Feldman.
2406
2407         Web Inspector: Inspector should support copy() in the command line
2408         https://bugs.webkit.org/show_bug.cgi?id=31238
2409
2410         * inspector/InspectorBackend.cpp:
2411         (WebCore::InspectorBackend::copyText): Added.
2412         * inspector/InspectorBackend.h: Added copyText
2413         * inspector/InspectorBackend.idl: Added copyText
2414         * inspector/front-end/InjectedScript.js:
2415         (InjectedScript._copy): Added.
2416         (InjectedScript._ensureCommandLineAPIInstalled):
2417
2418 2009-11-08  Drew Wilson  <atwilson@chromium.org>
2419
2420         Reviewed by Dimitri Glazkov.
2421
2422         V8 WorkerContextExecutionProxy does not handle SharedWorkers
2423         https://bugs.webkit.org/show_bug.cgi?id=31226
2424
2425         Now checks to see what type of context is active and creates the
2426         appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).
2427
2428         Added support for converting to SharedWorkers and SharedWorkerContexts.
2429
2430         Test: Existing layout tests cover this case (start passing in Chrome).
2431
2432         * bindings/v8/WorkerContextExecutionProxy.cpp:
2433         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2434         Now generates the right type of DOMWrapper for SharedWorkerContexts.
2435         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2436         Added support for SHAREDWORKERCONTEXT.
2437         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2438         Added support for SharedWorker and SharedWorkerContext.
2439
2440 2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>
2441
2442         Reviewed by Dimitri Glazkov.
2443
2444         https://bugs.webkit.org/show_bug.cgi?id=31224
2445         [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.
2446
2447         Test: fast/dom/StyleSheet/get-stylesheet-byname.html
2448
2449         * bindings/v8/custom/V8StyleSheetListCustom.cpp:
2450         (WebCore::NAMED_PROPERTY_GETTER):
2451
2452 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2453
2454         Reviewed by Timothy Hatcher.
2455
2456         Web Inspector: "Search again" on scripts panel switches
2457         to the script this search started with.
2458
2459         https://bugs.webkit.org/show_bug.cgi?id=31243
2460
2461         * inspector/front-end/Panel.js:
2462         (WebInspector.Panel.prototype.jumpToNextSearchResult):
2463
2464 2009-11-08  Kent Tamura  <tkent@chromium.org>
2465
2466         Reviewed by Darin Adler.
2467
2468         Simplify Icon interface.
2469         https://bugs.webkit.org/show_bug.cgi?id=31154
2470
2471         - Remove Icon::createIconForFile().  createIconForFiles() covers
2472           createIconForFile()'s role.
2473         - Remove FileChooser::chooseIcon()
2474         - Change the parameter types of FileChooser constructor and the
2475           factory method, String -> const Vector<String>&, in order to
2476           support initialization with multiple files.
2477         - Remove the icon loading code in IconChromiumWin.cpp, which
2478           doesn't work because of the sandbox.
2479
2480         No tests because it's just a refactoring.
2481
2482         * platform/FileChooser.cpp:
2483         (WebCore::FileChooser::FileChooser):
2484         (WebCore::FileChooser::create):
2485         (WebCore::FileChooser::chooseFile):
2486         (WebCore::FileChooser::chooseFiles):
2487         * platform/FileChooser.h:
2488         * platform/graphics/Icon.h:
2489         * platform/graphics/chromium/IconChromiumLinux.cpp:
2490         * platform/graphics/chromium/IconChromiumMac.cpp:
2491         * platform/graphics/chromium/IconChromiumWin.cpp:
2492         (WebCore::Icon::createIconForFiles):
2493         * platform/graphics/gtk/IconGtk.cpp:
2494         (WebCore::Icon::createIconForFiles):
2495         * platform/graphics/haiku/IconHaiku.cpp:
2496         * platform/graphics/mac/IconMac.mm:
2497         (WebCore::Icon::createIconForFiles):
2498         * platform/graphics/qt/IconQt.cpp:
2499         (WebCore::Icon::createIconForFiles):
2500         * platform/graphics/win/IconWin.cpp:
2501         (WebCore::Icon::createIconForFiles):
2502         * platform/graphics/wx/IconWx.cpp:
2503         * rendering/RenderFileUploadControl.cpp:
2504         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
2505
2506 2009-11-08  Daniel Bates  <dbates@webkit.org>
2507
2508         Reviewed by Adam Barth.
2509
2510         https://bugs.webkit.org/show_bug.cgi?id=31098
2511
2512         Allows same-origin plugin-based content to load.
2513
2514         Test: http/tests/security/xssAuditor/object-src-inject.html
2515
2516         * page/XSSAuditor.cpp:
2517         (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
2518         (WebCore::XSSAuditor::canLoadObject): Ditto.
2519         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto. 
2520         (WebCore::XSSAuditor::isSameOriginResource): Added.
2521         * page/XSSAuditor.h:
2522
2523 2009-11-08  David Levin  <levin@chromium.org>
2524
2525         Reviewed by NOBODY (chromium build fix).
2526
2527         * platform/network/HTTPParsers.cpp:
2528         (WebCore::parseDate): Changed this to not
2529         use a date parser that needs ExecState passed.
2530         
2531 2009-11-08  David Levin  <levin@chromium.org>
2532
2533         Unreviewed build fix for chromium.
2534
2535         * platform/graphics/skia/GraphicsContextSkia.cpp:
2536         (WebCore::GraphicsContext::fillPath):
2537         (WebCore::GraphicsContext::fillRect):
2538         (WebCore::GraphicsContext::strokePath):
2539         (WebCore::GraphicsContext::strokeRect):
2540
2541 2009-11-08  David Levin  <levin@chromium.org>
2542
2543         Unreviewed build fix for chromium.
2544
2545         Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
2546         Clean up GraphicsContext's current concept of ColorSpace
2547
2548         * platform/graphics/skia/GraphicsContextSkia.cpp:
2549         (WebCore::GraphicsContext::fillPath):
2550         (WebCore::GraphicsContext::fillRect):
2551         (WebCore::GraphicsContext::strokePath):
2552         (WebCore::GraphicsContext::strokeRect):
2553
2554 2009-11-08  Pavel Feldman  <pfeldman@chromium.org>
2555
2556         Reviewed by Timothy Hatcher.
2557
2558         Web Inspector: [REGRESSION] committing style edit
2559         clears elements panel selection.
2560
2561         https://bugs.webkit.org/show_bug.cgi?id=31242
2562
2563         * inspector/front-end/ElementsTreeOutline.js:
2564         (WebInspector.ElementsTreeOutline.prototype.update):
2565         * inspector/front-end/StylesSidebarPane.js:
2566         (WebInspector.StylePropertyTreeElement.prototype.):
2567         (WebInspector.StylePropertyTreeElement.prototype):
2568
2569 2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>
2570
2571         Reviewed by Holger Freyther.
2572
2573         ResourceRequest to be class instead of struct
2574         https://bugs.webkit.org/show_bug.cgi?id=30670
2575
2576         Started as a compilation fix for Symbian where the compiler makes a distinction between
2577         class and struct in function argument signatures.
2578         Changed all forward declarations of ResourceRequest to have class in the forward
2579         declaration instead of struct and changed the definition of ResourceRequest to be class
2580         and added access qualifiers where missing. Additionally two references of friend
2581         struct ResourceRequestBase changed to class instead.
2582
2583         * history/HistoryItem.h:
2584         * inspector/InspectorController.h:
2585         * inspector/InspectorResource.h:
2586         * loader/DocumentThreadableLoader.h:
2587         * loader/FrameLoaderClient.h:
2588         * loader/MainResourceLoader.h:
2589         * loader/ResourceLoadNotifier.h:
2590         * loader/SubresourceLoader.h:
2591         * loader/SubresourceLoaderClient.h:
2592         * loader/ThreadableLoader.h:
2593         * loader/WorkerThreadableLoader.h:
2594         * loader/appcache/ApplicationCache.h:
2595         * loader/appcache/ApplicationCacheHost.h:
2596         * platform/CrossThreadCopier.h:
2597         * platform/network/ResourceHandle.h:
2598         * platform/network/ResourceHandleClient.h:
2599         * platform/network/ResourceRequestBase.h:
2600         * platform/network/cf/ResourceRequest.h:
2601         * platform/network/cf/ResourceRequestCFNet.h:
2602         * platform/network/chromium/ResourceRequest.h:
2603         * platform/network/curl/ResourceRequest.h:
2604         * platform/network/qt/ResourceRequest.h:
2605         * platform/network/soup/ResourceRequest.h:
2606         * xml/XMLHttpRequest.h:
2607
2608 2009-11-08  Dan Bernstein  <mitz@apple.com>
2609
2610         Reviewed by Simon Fraser.
2611
2612         <rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
2613         below FrameView::layout
2614         https://bugs.webkit.org/show_bug.cgi?id=31093
2615
2616         Test: fast/block/positioning/relative-positioned-inline-container.html
2617
2618         In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
2619         to mark the object for layout, doing so without marking its ancestors.
2620         However, RenderBlock::skipLeadingWhitespace and
2621         RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
2622         positioned inline container, causing it to be marked for layout without
2623         ever going back to give it layout, and thus layout could end with a
2624         dirty object still in the tree, leading to all sorts of badness.
2625
2626         The fix is to revert setStaticY() to not marking the object dirty, and
2627         instead do it in the call sites that require it, which are in
2628         RenderBlock and RenderFlexibleBox.
2629
2630         * rendering/RenderBlock.cpp:
2631         (WebCore::RenderBlock::adjustPositionedBlock):
2632         * rendering/RenderFlexibleBox.cpp:
2633         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
2634         (WebCore::RenderFlexibleBox::layoutVerticalBox):
2635         * rendering/RenderLayer.cpp:
2636         * rendering/RenderLayer.h:
2637         (WebCore::RenderLayer::setStaticY):
2638
2639 2009-11-07  Daniel Bates  <dbates@webkit.org>
2640
2641         Reviewed by Darin Adler.
2642
2643         https://bugs.webkit.org/show_bug.cgi?id=20780
2644         
2645         Fixes an issue where the onchange event handler is not fired when the 
2646         input field is autocompleted.
2647         
2648         We cannot test this using DRT since DRT cannot emulate autocompletion.
2649         So, a manual-test is included.
2650
2651         Tests: manual-tests/autocompletion-fire-onchange.html
2652
2653         * manual-tests/autocompletion-fire-onchange.html: Added.
2654         * rendering/RenderTextControl.cpp:
2655         (WebCore::RenderTextControl::setInnerTextValue):
2656
2657 2009-11-07  Benjamin Otte  <otte@gnome.org>
2658
2659         Reviewed by Holger Freyther.
2660
2661         Mark redrawn areas on image surfaces as dirty.
2662
2663         This is required to conform to the Cairo API, but is currently only
2664         used by debugging tools like cairo-trace.
2665
2666         * platform/graphics/cairo/ImageBufferCairo.cpp:
2667         (WebCore::ImageBuffer::platformTransformColorSpace):
2668         (WebCore::putImageData):
2669
2670 2009-11-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2671
2672         Reviewed by Xan Lopez.
2673
2674         https://bugs.webkit.org/show_bug.cgi?id=30878
2675         [Gtk] atk_text_get_text() fails in entries when the end_offset is -1
2676
2677         If the end_offset is -1, use the String length as the end_offset.
2678
2679         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2680         (webkit_accessible_text_get_text):
2681
2682 2009-11-06  Beth Dakin  <bdakin@apple.com>
2683
2684         Reviewed by Adele Peterson.
2685
2686         Fix for https://bugs.webkit.org/show_bug.cgi?id=31219 Clean up 
2687         GraphicsContext's current concept of ColorSpace
2688
2689         ColorSpace is now called ColorType. The variables on the state we 
2690         appropriately re-named as well. I removed strokeColorSpace() and 
2691         fillColorSpace() from GraphicsContext since they were never called. 
2692
2693         * platform/graphics/GraphicsContext.cpp:
2694         (WebCore::GraphicsContext::setStrokeColor):
2695         (WebCore::GraphicsContext::setFillColor):
2696         (WebCore::GraphicsContext::setStrokePattern):
2697         (WebCore::GraphicsContext::setFillPattern):
2698         (WebCore::GraphicsContext::setStrokeGradient):
2699         (WebCore::GraphicsContext::setFillGradient):
2700         * platform/graphics/GraphicsContext.h:
2701         (WebCore::):
2702         * platform/graphics/GraphicsContextPrivate.h:
2703         (WebCore::GraphicsContextState::GraphicsContextState):
2704         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2705         (WebCore::GraphicsContext::fillPath):
2706         (WebCore::GraphicsContext::strokePath):
2707         * platform/graphics/cg/GraphicsContextCG.cpp:
2708         (WebCore::calculateDrawingMode):
2709         (WebCore::GraphicsContext::drawPath):
2710         (WebCore::GraphicsContext::fillPath):
2711         (WebCore::GraphicsContext::strokePath):
2712         (WebCore::GraphicsContext::fillRect):
2713         (WebCore::GraphicsContext::strokeRect):
2714         * platform/graphics/qt/GraphicsContextQt.cpp:
2715         (WebCore::GraphicsContext::fillPath):
2716         (WebCore::GraphicsContext::strokePath):
2717         (WebCore::GraphicsContext::fillRect):
2718         * platform/graphics/wince/GraphicsContextWince.cpp:
2719         (WebCore::GraphicsContext::fillPath):
2720         (WebCore::GraphicsContext::fillRect):
2721
2722 2009-11-06  Brian Weinstein  <bweinstein@apple.com>
2723
2724         Reviewed by Tim Hatcher.
2725
2726         Fixes <http://webkit.org/b/31177>.
2727         Web Inspector: Bind backspace to delete cookies and DOM Storage.
2728         
2729         Refactor editing code from DOMStorageDataGrid to DataGrid, so other
2730         places in the inspector can use editing in DataGrid (added a FIXME for
2731         some stuff that needs to be generalized).
2732         
2733         Also added deleting functionality to DataGrid, and implemented it for
2734         Cookies and DOM Storage. The reason this patch is so big is because of
2735         the refactoring of editing code, which won't be used yet in a cross-datagrid
2736         way, but should be able to.
2737         
2738         Additionally, moved the callbacks members from DOMStorageDataGrid to
2739         DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to 
2740         make the architecture of DOM Storage look a lot more like the Cookies view.
2741         
2742         Lastly, added a preventDefault call in ElementsTreeOutline to prevent the 
2743         inspector from beeping at you when you delete an element.
2744
2745         * WebCore.gypi: Removed DOMStorageDataGrid.
2746         * WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
2747         * inspector/front-end/CookieItemsView.js:
2748         (WebInspector.CookieItemsView.prototype.dataGridForCookies):
2749         (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
2750         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2751         * inspector/front-end/DOMStorageDataGrid.js: Removed.
2752         * inspector/front-end/DOMStorageItemsView.js:
2753         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2754         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
2755         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
2756         (WebInspector.DOMStorageItemsView.prototype._editingCallback):
2757         (WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
2758         (WebInspector.DOMStorageItemsView.prototype._deleteCallback):
2759         * inspector/front-end/DataGrid.js:
2760         (WebInspector.DataGrid):
2761         (WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
2762         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
2763         (WebInspector.DataGrid.prototype._startEditing): Ditto.
2764         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
2765         (WebInspector.DataGrid.prototype._editingCommitted): Ditto.
2766         (WebInspector.DataGrid.prototype._editingCancelled): Ditto.
2767         (WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
2768         * inspector/front-end/ElementsTreeOutline.js:
2769         (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
2770         * inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
2771         * inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
2772
2773 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2774
2775         Qt build fix: added an ExecState parameter.
2776
2777         * bridge/qt/qt_runtime.cpp:
2778         (JSC::Bindings::convertValueToQVariant):
2779         (JSC::Bindings::convertQVariantToValue):
2780
2781 2009-11-06  Geoffrey Garen  <ggaren@apple.com>
2782
2783         https://bugs.webkit.org/show_bug.cgi?id=31197
2784         Implemented a timezone cache not based on Mac OS X's notify_check API.
2785
2786         Updated for JavaScriptCore internal API change.
2787
2788         * bridge/qt/qt_runtime.cpp:
2789         (JSC::Bindings::convertValueToQVariant):
2790         (JSC::Bindings::convertQVariantToValue): Updated for namespace change.
2791
2792         * platform/network/HTTPParsers.cpp:
2793         (WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
2794         (This function probably shouldn't be using a JavaScript date parser
2795         to begin with, but oh well.)
2796
2797 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2798
2799         Reviewed by Adam Barth.
2800
2801         The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
2802         which affects Chromium only.
2803         
2804         Changes to V8HTMLDocumentCustom.cpp are as below:-
2805         1. The HTMLDocumentOpen function would cause a crash in Chromium if
2806            there was no calling javascript context. We now check for this case
2807            and pass in NULL to the HTMLDocument::open function which can handle
2808            a NULL document parameter.
2809         2. The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc
2810            had ASSERTS for a NULL caller frame, which was bogus as it would crash
2811            anyway. We now check for this case and return a failure.
2812            
2813         Changes to V8DOMWindowCustom.cpp are as below:-
2814         1. Instead of failing the window.open call made by NPAPI for lack of a
2815            calling javascript context, we now use the entered context as the calling
2816            context.
2817
2818         Tests: plugins/document-open.html
2819                plugins/window-open.html
2820
2821         * bindings/v8/custom/V8DOMWindowCustom.cpp:
2822         (WebCore::CALLBACK_FUNC_DECL):
2823         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2824         (WebCore::CALLBACK_FUNC_DECL):
2825
2826 2009-11-06  Steve Block  <steveblock@google.com>
2827
2828         Reviewed by Eric Seidel.
2829
2830         Geolocation error code UNKNOWN_ERROR is deprecated.
2831         https://bugs.webkit.org/show_bug.cgi?id=31184
2832
2833         Remove this error code from PositionError, both for use from C++ code and from the JS object.
2834
2835         Updated fast/dom/Geolocation/error.html to test this.
2836
2837         * page/PositionError.h: Modified.
2838         (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
2839         * page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
2840         * page/Geolocation.cpp: Modified.
2841         (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2842         * platform/gtk/GeolocationServiceGtk.cpp: Modified.
2843         (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
2844
2845 2009-11-06  Dirk Schulze  <krit@webkit.org>
2846
2847         Reviewed by Nikolas Zimmermann.
2848
2849         feMorphology filter is not implemented
2850         [https://bugs.webkit.org/show_bug.cgi?id=5863]
2851
2852         The Implementation of feMorphology.
2853         
2854         Test: We have allready a test for feMorphology
2855               svg/W3C-SVG-1.1/filters-morph-01-f.svg
2856
2857         * svg/graphics/filters/SVGFEMorphology.cpp:
2858         (WebCore::FEMorphology::apply):
2859
2860 2009-11-06  Steve Block  <steveblock@google.com>
2861
2862         Reviewed by Eric Seidel.
2863
2864         V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
2865         https://bugs.webkit.org/show_bug.cgi?id=31209
2866
2867         Build fix only. No new tests possible.
2868
2869         * bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
2870
2871 2009-11-06  Drew Wilson  <atwilson@chromium.org>
2872
2873         Reviewed by David Levin.
2874
2875         V8 bindings do not support SharedWorkers as event targets
2876         https://bugs.webkit.org/show_bug.cgi?id=31199
2877
2878         No new tests because existing layout tests suffice (they currently
2879         crash on Chromium)
2880
2881         * bindings/v8/V8DOMWrapper.cpp:
2882         (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
2883         Added clause to create a DOM wrapper for SharedWorkers.
2884
2885 2009-11-06  Anton Muhin  <antonm@chromium.org>
2886
2887         Reviewed by Adam Barth.
2888
2889         Do not unnecessarly synchronzie in weak reference callbacks.
2890         https://bugs.webkit.org/show_bug.cgi?id=31191
2891
2892         * bindings/v8/DOMData.h:
2893         (WebCore::DOMData::handleWeakObject):
2894
2895 2009-11-06  Alexander Pavlov  <apavlov@chromium.org>
2896
2897         Reviewed by Pavel Feldman.
2898
2899         Fix resource content search.
2900         https://bugs.webkit.org/show_bug.cgi?id=31202
2901
2902         * inspector/front-end/AbstractTimelinePanel.js:
2903         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2904         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2905         * inspector/front-end/TimelinePanel.js:
2906         (WebInspector.TimelineGraph.prototype.refresh):
2907
2908 2009-11-05  Yuta Kitamura  <yutak@chromium.org>
2909
2910         Reviewed by Eric Seidel.
2911
2912         Fix ASSERT(currentStyle = renderStyle()).
2913         https://bugs.webkit.org/show_bug.cgi?id=31152
2914
2915         * dom/Element.cpp:
2916         (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
2917
2918 2009-11-05  Alpha Lam  <hclam@chromium.org>
2919
2920         Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
2921
2922         * bindings/v8/V8GCController.cpp:
2923         (WebCore::V8GCController::gcEpilogue):
2924         * bindings/v8/V8GCController.h:
2925         * bindings/v8/V8Proxy.cpp:
2926         (WebCore::V8Proxy::evaluate):
2927         (WebCore::V8Proxy::runScript):
2928         (WebCore::V8Proxy::callFunction):
2929
2930 2009-11-05  Adam Barth  <abarth@webkit.org>
2931
2932         Reviewed by Sam Weinig.
2933
2934         Cross-domain access to stylesheet text should not be allowed
2935         https://bugs.webkit.org/show_bug.cgi?id=20527
2936
2937         Check whether whether the current document can read the cssRules from
2938         the style sheet.  Firefox throws a security error here, but we return
2939         null instead because that's what we usually do in these cases.
2940
2941         Test: http/tests/security/cannot-read-cssrules-redirect.html
2942               http/tests/security/cannot-read-cssrules.html
2943
2944         * css/CSSStyleSheet.cpp:
2945         (WebCore::CSSStyleSheet::cssRules):
2946
2947 2009-11-05  Steve Block  <steveblock@google.com>
2948
2949         Reviewed by Eric Seidel.
2950
2951         If the Geolocation service fails to start, invoke the error callback asynchronously.
2952         https://bugs.webkit.org/show_bug.cgi?id=28276
2953
2954         All Geolocation callbacks must be invoked asynchronously.
2955         See http://www.w3.org/TR/geolocation-API/#geolocation_interface
2956
2957         No new tests possible with current LayoutTestController.
2958
2959         * page/Geolocation.cpp:
2960         (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
2961         (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
2962         (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
2963
2964 2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2965
2966         Reviewed by Eric Seidel.
2967
2968         Removed the "this is part of the KDE project" comments from 
2969         all *.h, *.cpp, *.idl, and *.pm files.
2970         
2971         https://bugs.webkit.org/show_bug.cgi?id=31167
2972         
2973         The maintenance and architecture page in the project wiki lists
2974         this as a task.
2975         
2976         This change includes no changes or additions to test cases 
2977         since the change affects only comments.
2978
2979         * bindings/scripts/CodeGeneratorV8.pm:
2980         * bindings/scripts/IDLParser.pm:
2981         * bindings/scripts/IDLStructure.pm:
2982         * css/CSSInheritedValue.cpp:
2983         * css/CSSInitialValue.cpp:
2984         * css/CSSMediaRule.cpp:
2985         * css/CSSNamespace.h:
2986         * css/CSSProperty.cpp:
2987         * css/CSSProperty.h:
2988         * css/CSSRuleList.cpp:
2989         * css/CSSRuleList.h:
2990         * css/CSSSelector.h:
2991         * css/CSSValueList.cpp:
2992         * css/FontValue.cpp:
2993         * css/MediaFeatureNames.cpp:
2994         * css/MediaFeatureNames.h:
2995         * css/Pair.h:
2996         * css/SVGCSSStyleSelector.cpp:
2997         * css/ShadowValue.cpp:
2998         * css/StyleSheet.cpp:
2999         * css/StyleSheetList.cpp:
3000         * css/maketokenizer:
3001         * dom/BeforeUnloadEvent.cpp:
3002         * dom/BeforeUnloadEvent.h:
3003         * dom/CSSMappedAttributeDeclaration.cpp:
3004         * dom/EventNames.cpp:
3005         * dom/EventTarget.cpp:
3006         * dom/MappedAttributeEntry.h:
3007         * dom/MouseRelatedEvent.h:
3008         * dom/RangeException.h:
3009         * dom/StyleElement.h:
3010         * dom/Tokenizer.h:
3011         * html/HTMLHeadElement.h:
3012         * html/HTMLHeadingElement.cpp:
3013         * html/HTMLHeadingElement.h:
3014         * html/HTMLHtmlElement.h:
3015         * html/HTMLImageLoader.h:
3016         * html/HTMLMetaElement.h:
3017         * html/HTMLModElement.cpp:
3018         * html/HTMLModElement.h:
3019         * html/HTMLOptionsCollection.cpp:
3020         * html/HTMLPlugInElement.cpp:
3021         * html/HTMLPreElement.cpp:
3022         * html/HTMLPreElement.h:
3023         * html/HTMLTableCellElement.cpp:
3024         * html/HTMLTableCellElement.h:
3025         * html/HTMLTableColElement.cpp:
3026         * html/HTMLTableColElement.h:
3027         * html/HTMLTablePartElement.cpp:
3028         * html/HTMLTablePartElement.h:
3029         * html/HTMLTitleElement.h:
3030         * page/MouseEventWithHitTestResults.h:
3031         * platform/StaticConstructors.h:
3032         * platform/text/AtomicStringImpl.h:
3033         * platform/text/qt/TextBreakIteratorQt.cpp:
3034         * rendering/AutoTableLayout.h:
3035         * rendering/CounterNode.cpp:
3036         * rendering/EllipsisBox.cpp:
3037         * rendering/EllipsisBox.h:
3038         * rendering/FixedTableLayout.cpp:
3039         * rendering/FixedTableLayout.h:
3040         * rendering/HitTestRequest.h:
3041         * rendering/HitTestResult.h:
3042         * rendering/InlineRunBox.h:
3043         * rendering/PointerEventsHitRules.cpp:
3044         * rendering/PointerEventsHitRules.h:
3045         * rendering/RenderBR.cpp:
3046         * rendering/RenderBR.h:
3047         * rendering/RenderButton.cpp:
3048         * rendering/RenderButton.h:
3049         * rendering/RenderFieldset.cpp:
3050         * rendering/RenderFrameSet.cpp:
3051         * rendering/RenderListItem.cpp:
3052         * rendering/RenderTableRow.cpp:
3053         * rendering/RenderView.h:
3054         * rendering/RootInlineBox.h:
3055         * rendering/SVGInlineTextBox.cpp:
3056         * rendering/SVGInlineTextBox.h:
3057         * rendering/TableLayout.h:
3058         * rendering/break_lines.h:
3059         * rendering/style/SVGRenderStyle.cpp:
3060         * rendering/style/SVGRenderStyle.h:
3061         * rendering/style/SVGRenderStyleDefs.cpp:
3062         * rendering/style/SVGRenderStyleDefs.h:
3063         * svg/GradientAttributes.h:
3064         * svg/LinearGradientAttributes.h:
3065         * svg/PatternAttributes.h:
3066         * svg/RadialGradientAttributes.h:
3067         * svg/SVGAElement.cpp:
3068         * svg/SVGAngle.idl:
3069         * svg/SVGAnimateColorElement.cpp:
3070         * svg/SVGAnimateColorElement.h:
3071         * svg/SVGAnimateElement.cpp:
3072         * svg/SVGAnimateElement.h:
3073         * svg/SVGAnimateTransformElement.h:
3074         * svg/SVGAnimatedPathData.cpp:
3075         * svg/SVGAnimatedPathData.h:
3076         * svg/SVGAnimatedPoints.cpp:
3077         * svg/SVGAnimatedPoints.h:
3078         * svg/SVGAnimationElement.cpp:
3079         * svg/SVGCircleElement.cpp:
3080         * svg/SVGClipPathElement.cpp:
3081         * svg/SVGColor.cpp:
3082         * svg/SVGColor.idl:
3083         * svg/SVGComponentTransferFunctionElement.cpp:
3084         * svg/SVGComponentTransferFunctionElement.h:
3085         * svg/SVGCursorElement.cpp:
3086         * svg/SVGDefsElement.cpp:
3087         * svg/SVGDescElement.cpp:
3088         * svg/SVGDescElement.h:
3089         * svg/SVGDocument.idl:
3090         * svg/SVGElement.idl:
3091         * svg/SVGElementInstanceList.cpp:
3092         * svg/SVGElementInstanceList.h:
3093         * svg/SVGEllipseElement.cpp:
3094         * svg/SVGExternalResourcesRequired.cpp:
3095         * svg/SVGFEBlendElement.cpp:
3096         * svg/SVGFEBlendElement.h:
3097         * svg/SVGFEColorMatrixElement.cpp:
3098         * svg/SVGFEColorMatrixElement.h:
3099         * svg/SVGFEComponentTransferElement.cpp:
3100         * svg/SVGFEComponentTransferElement.h:
3101         * svg/SVGFECompositeElement.cpp:
3102         * svg/SVGFECompositeElement.h:
3103         * svg/SVGFEFloodElement.cpp:
3104         * svg/SVGFEFloodElement.h:
3105         * svg/SVGFEFuncAElement.cpp:
3106         * svg/SVGFEFuncAElement.h:
3107         * svg/SVGFEFuncBElement.cpp:
3108         * svg/SVGFEFuncBElement.h:
3109         * svg/SVGFEFuncGElement.cpp:
3110         * svg/SVGFEFuncGElement.h:
3111         * svg/SVGFEFuncRElement.cpp:
3112         * svg/SVGFEFuncRElement.h:
3113         * svg/SVGFEGaussianBlurElement.cpp:
3114         * svg/SVGFEGaussianBlurElement.h:
3115         * svg/SVGFEImageElement.cpp:
3116         * svg/SVGFEMergeElement.cpp:
3117         * svg/SVGFEMergeElement.h:
3118         * svg/SVGFEMergeNodeElement.cpp:
3119         * svg/SVGFEOffsetElement.cpp:
3120         * svg/SVGFEOffsetElement.h:
3121         * svg/SVGFETileElement.cpp:
3122         * svg/SVGFETileElement.h:
3123         * svg/SVGFETurbulenceElement.cpp:
3124         * svg/SVGFETurbulenceElement.h:
3125         * svg/SVGFilterElement.cpp:
3126         * svg/SVGGElement.cpp:
3127         * svg/SVGGradientElement.cpp:
3128         * svg/SVGHKernElement.idl:
3129         * svg/SVGLangSpace.cpp:
3130         * svg/SVGLangSpace.h:
3131         * svg/SVGLength.cpp:
3132         * svg/SVGLength.h:
3133         * svg/SVGLength.idl:
3134         * svg/SVGLengthList.cpp:
3135         * svg/SVGLengthList.h:
3136         * svg/SVGLineElement.cpp:
3137         * svg/SVGLinearGradientElement.h:
3138         * svg/SVGList.h:
3139         * svg/SVGListTraits.h:
3140         * svg/SVGLocatable.h:
3141         * svg/SVGMaskElement.cpp:
3142         * svg/SVGMatrix.idl:
3143         * svg/SVGMetadataElement.cpp:
3144         * svg/SVGMetadataElement.h:
3145         * svg/SVGMetadataElement.idl:
3146         * svg/SVGNumber.idl:
3147         * svg/SVGNumberList.cpp:
3148         * svg/SVGNumberList.h:
3149         * svg/SVGPaint.cpp:
3150         * svg/SVGPathElement.cpp:
3151         * svg/SVGPathSeg.h:
3152         * svg/SVGPathSegArc.cpp:
3153         * svg/SVGPathSegArc.h:
3154         * svg/SVGPathSegClosePath.cpp:
3155         * svg/SVGPathSegClosePath.h:
3156         * svg/SVGPathSegCurvetoCubic.cpp:
3157         * svg/SVGPathSegCurvetoCubic.h:
3158         * svg/SVGPathSegCurvetoCubicSmooth.cpp:
3159         * svg/SVGPathSegCurvetoCubicSmooth.h:
3160         * svg/SVGPathSegCurvetoQuadratic.cpp:
3161         * svg/SVGPathSegCurvetoQuadratic.h:
3162         * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
3163         * svg/SVGPathSegCurvetoQuadraticSmooth.h:
3164         * svg/SVGPathSegLineto.cpp:
3165         * svg/SVGPathSegLineto.h:
3166         * svg/SVGPathSegLinetoHorizontal.cpp:
3167         * svg/SVGPathSegLinetoHorizontal.h:
3168         * svg/SVGPathSegLinetoVertical.cpp:
3169         * svg/SVGPathSegLinetoVertical.h:
3170         * svg/SVGPathSegMoveto.cpp:
3171         * svg/SVGPathSegMoveto.h:
3172         * svg/SVGPatternElement.cpp:
3173         * svg/SVGPoint.idl:
3174         * svg/SVGPointList.cpp:
3175         * svg/SVGPointList.h:
3176         * svg/SVGPolyElement.cpp:
3177         * svg/SVGPolygonElement.cpp:
3178         * svg/SVGPolygonElement.h:
3179         * svg/SVGPolylineElement.cpp:
3180         * svg/SVGPolylineElement.h:
3181         * svg/SVGPreserveAspectRatio.cpp:
3182         * svg/SVGPreserveAspectRatio.h:
3183         * svg/SVGRadialGradientElement.h:
3184         * svg/SVGRect.idl:
3185         * svg/SVGRectElement.cpp:
3186         * svg/SVGRenderingIntent.h:
3187         * svg/SVGSVGElement.idl:
3188         * svg/SVGScriptElement.cpp:
3189         * svg/SVGSetElement.cpp:
3190         * svg/SVGSetElement.h:
3191         * svg/SVGStopElement.cpp:
3192         * svg/SVGStringList.cpp:
3193         * svg/SVGStringList.h:
3194         * svg/SVGStylable.cpp:
3195         * svg/SVGStylable.h:
3196         * svg/SVGStyleElement.cpp:
3197         * svg/SVGStyleElement.h:
3198         * svg/SVGStyledElement.h:
3199         * svg/SVGStyledLocatableElement.cpp:
3200         * svg/SVGStyledLocatableElement.h:
3201         * svg/SVGStyledTransformableElement.cpp:
3202         * svg/SVGStyledTransformableElement.h:
3203         * svg/SVGSwitchElement.cpp:
3204         * svg/SVGSymbolElement.cpp:
3205         * svg/SVGTRefElement.cpp:
3206         * svg/SVGTSpanElement.cpp:
3207         * svg/SVGTSpanElement.h:
3208         * svg/SVGTests.h:
3209         * svg/SVGTextElement.cpp:
3210         * svg/SVGTextElement.h:
3211         * svg/SVGTextPathElement.cpp:
3212         * svg/SVGTextPositioningElement.cpp:
3213         * svg/SVGTextPositioningElement.h:
3214         * svg/SVGTitleElement.cpp:
3215         * svg/SVGTitleElement.h:
3216         * svg/SVGTransform.cpp:
3217         * svg/SVGTransform.h:
3218         * svg/SVGTransform.idl:
3219         * svg/SVGTransformList.cpp:
3220         * svg/SVGTransformList.h:
3221         * svg/SVGTransformable.h:
3222         * svg/SVGURIReference.h:
3223         * svg/SVGUnitTypes.h:
3224         * svg/SVGUseElement.cpp:
3225         * svg/SVGViewElement.cpp:
3226         * svg/SVGZoomAndPan.cpp:
3227         * svg/SVGZoomAndPan.h:
3228         * svg/SVGZoomEvent.cpp:
3229
3230 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3231
3232         Reviewed by Dimitri Glazkov.
3233
3234         REGRESSION Clean up security origin usage in DOM Storage.
3235         https://bugs.webkit.org/show_bug.cgi?id=31188
3236
3237         Clean up security origin usage in DOM Storage.  This fixes a bug in my
3238         refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
3239
3240         Instead of having StorageAreaSync's constructor (which is called in the
3241         constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
3242         database identifier, simply have StorageAreaImpl pass the identifier into
3243         StorageAreaSync.
3244
3245         No test because there's no change in externally observable behavior.
3246
3247         * storage/StorageAreaImpl.cpp:
3248         (WebCore::StorageAreaImpl::StorageAreaImpl):
3249         * storage/StorageAreaImpl.h:
3250         * storage/StorageAreaSync.cpp:
3251         (WebCore::StorageAreaSync::create):
3252         (WebCore::StorageAreaSync::StorageAreaSync):
3253         * storage/StorageAreaSync.h:
3254
3255 2009-11-05  Scott Violet  <sky@google.com>
3256
3257         Reviewed by Dimitri Glazkov.
3258
3259         Need notification of scrolling frame
3260         https://bugs.webkit.org/show_bug.cgi?id=31145
3261
3262         Adds FrameLoaderClient::didChangeScrollOffset that is called when
3263         the frame scrolls. This will be used to know when history state
3264         needs to be updated.
3265
3266         * loader/FrameLoaderClient.h:
3267         (WebCore::FrameLoaderClient::didChangeScrollOffset):
3268         * page/FrameView.cpp:
3269         (WebCore::FrameView::valueChanged):
3270
3271 2009-11-05  Kenneth Russell  <kbr@google.com>
3272
3273         Reviewed by Dimitri Glazkov.
3274
3275         [V8] Update bindings to use new API for external arrays
3276         https://bugs.webkit.org/show_bug.cgi?id=31181
3277
3278         No new tests; covered by existing WebGL tests.
3279
3280         * bindings/v8/V8DOMWrapper.cpp:
3281         (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
3282         (WebCore::V8DOMWrapper::getTemplate):
3283         (WebCore::V8DOMWrapper::convertToV8Object):
3284         * bindings/v8/V8DOMWrapper.h:
3285         * bindings/v8/custom/V8CanvasArrayCustom.h:
3286         (WebCore::constructCanvasArray):
3287
3288 2009-11-05  Alpha Lam  <hclam@chromium.org>
3289
3290         Not reviewed, Chromium build fix.
3291
3292         50561 introduces a custom method for SVGMatrix, we need to implement
3293         this in V8.
3294
3295         * bindings/v8/custom/V8CustomBinding.h:
3296         Adding definition for V8SVGMatrixMultiply.
3297         * bindings/v8/custom/V8SVGMatrixCustom.cpp:
3298         (WebCore::CALLBACK_FUNC_DECL):
3299         Implement V8SVGMatrixMultiply according to the same method in JSC.
3300
3301 2009-11-05  Jeremy Orlow  <jorlow@chromium.org>
3302
3303         Revert 50569 since it broke QT.  Build fix and just a revert, so no review.
3304
3305         * page/DOMWindow.cpp:
3306         (WebCore::DOMWindow::sessionStorage):
3307         * page/Settings.cpp:
3308         (WebCore::Settings::Settings):
3309         (WebCore::Settings::setSessionStorageEnabled):
3310         * page/Settings.h:
3311         (WebCore::Settings::sessionStorageEnabled):
3312
3313 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3314
3315         Reviewed by Timothy Hatcher.
3316
3317         REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
3318
3319         https://bugs.webkit.org/show_bug.cgi?id=30884
3320
3321         Test: inspector/styles-iframe.html
3322
3323         * inspector/front-end/DOMAgent.js:
3324         (WebInspector.DOMNode):
3325         * inspector/front-end/InjectedScript.js:
3326         (InjectedScript.getStyles):
3327         (InjectedScript.getComputedStyle):
3328         (InjectedScript.addStyleSelector):
3329         * inspector/front-end/TestController.js:
3330         (WebInspector.TestController.prototype.notifyDone):
3331         (WebInspector.TestController.prototype.runAfterPendingDispatches):
3332         (WebInspector.evaluateForTestInFrontend.invokeMethod):
3333         (WebInspector.evaluateForTestInFrontend):
3334
3335 2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>
3336
3337         Reviewed by Geoffrey Garen and Dimitri Glazkov.
3338
3339         Rehashing of EventListenerMap leads to loss of EvenListenerList.
3340         https://bugs.webkit.org/show_bug.cgi?id=31027
3341
3342         Tested by new fast/events/event-listener-map-rehash-crash.html.
3343
3344         EventListenerMap modified to store pointers to listener vectors:
3345         * dom/EventTarget.cpp:
3346         (WebCore::EventTargetData::~EventTargetData):
3347         (WebCore::EventTarget::addEventListener):
3348         (WebCore::EventTarget::removeEventListener):
3349         (WebCore::EventTarget::fireEventListeners):
3350         (WebCore::EventTarget::getEventListeners):
3351         (WebCore::EventTarget::removeAllEventListeners):
3352         * dom/EventTarget.h:
3353
3354         Usages updated after interface changes:
3355         * inspector/InspectorDOMAgent.cpp:
3356         (WebCore::InspectorDOMAgent::getEventListenersForNode):
3357         * svg/SVGUseElement.cpp:
3358         (WebCore::SVGUseElement::transferEventListenersToShadowTree):
3359
3360 2009-11-05  Dan Kegel  <dank@chromium.org>
3361
3362         Reviewed by Dmitri Titov.
3363
3364         Add missing initialization for m_createdByParser.
3365         https://bugs.webkit.org/show_bug.cgi?id=31089
3366
3367         Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
3368
3369         * dom/ProcessingInstruction.cpp:
3370         (WebCore::ProcessingInstruction::ProcessingInstruction):
3371
3372 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3373
3374         Reviewed by Adam Barth.
3375
3376         DOM Storage runtime flag changes
3377         https://bugs.webkit.org/show_bug.cgi?id=30602
3378
3379         Part 2/2.
3380
3381         Revert my changes to Settings and instead implement DOM Storage enabling via
3382         the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
3383
3384         This stuff was (intentionally) never exposed to web pages or DRT, so there's no
3385         LayoutTest visible changes and thus no tests.
3386
3387         * bindings/v8/custom/V8CustomBinding.h:
3388         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3389         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3390         * page/DOMWindow.cpp:
3391         (WebCore::DOMWindow::sessionStorage):
3392         * page/DOMWindow.idl:
3393         * page/Settings.cpp:
3394         (WebCore::Settings::Settings):
3395         * page/Settings.h:
3396         * storage/Storage.cpp:
3397         (WebCore::Storage::setLocalStorageAvailable):
3398         (WebCore::Storage::localStorageAvailable):
3399         (WebCore::Storage::setSessionStorageAvailable):
3400         (WebCore::Storage::sessionStorageAvailable):
3401         * storage/Storage.h:
3402
3403 2009-11-05  Jian Li  <jianli@chromium.org>
3404
3405         Reviewed by Pavel Feldman.
3406
3407         Bug 31108 - [V8] REGRESSION: Pause on exception is broken
3408         https://bugs.webkit.org/show_bug.cgi?id=31108
3409
3410         * bindings/v8/V8AbstractEventListener.cpp:
3411         (WebCore::V8AbstractEventListener::invokeEventHandler):
3412         * bindings/v8/V8Utilities.cpp:
3413         (WebCore::reportException):
3414
3415 2009-11-05  Jian Li  <jianli@chromium.org>
3416
3417         Reviewed by Dmitri Titov.
3418
3419         We should not bubble up events if we drag something to an iframe that
3420         has an invalid source.
3421         https://bugs.webkit.org/show_bug.cgi?id=30469
3422
3423         Test: http/tests/misc/bubble-drag-events.html
3424
3425         * page/EventHandler.cpp:
3426         (WebCore::EventHandler::handleDragAndDropForTarget):
3427         (WebCore::EventHandler::updateDragAndDrop):
3428         (WebCore::EventHandler::cancelDragAndDrop):
3429         (WebCore::EventHandler::performDragAndDrop):
3430         * page/EventHandler.h:
3431         (WebCore::EventHandler::):
3432
3433 2009-11-05  Pavel Feldman  <pfeldman@chromium.org>
3434
3435         Reviewed by Timothy Hatcher.
3436
3437         Web Inspector: speed up Timelines Clear by a factor of thousands.
3438
3439         https://bugs.webkit.org/show_bug.cgi?id=31160
3440
3441         * inspector/front-end/utilities.js:
3442         (Element.prototype.removeChildren):
3443
3444 2009-11-05  Anton Muhin  <antonm@chromium.org>
3445
3446         Reviewed by Adam Barth.
3447
3448         If high memory usage is detected, hint to V8 that it might be due
3449         to external objects retained by V8 objects.
3450         https://bugs.webkit.org/show_bug.cgi?id=31051
3451
3452         * bindings/v8/V8GCController.cpp:
3453         (WebCore::GetMemoryUsageInMB):
3454         (WebCore::V8GCController::gcEpilogue):
3455         (WebCore::V8GCController::checkMemoryUsage):
3456         * bindings/v8/V8GCController.h:
3457         * bindings/v8/V8Proxy.cpp:
3458         (WebCore::V8Proxy::evaluate):
3459         (WebCore::V8Proxy::runScript):
3460         (WebCore::V8Proxy::callFunction):
3461
3462 2009-11-05  Jeff Schiller  <codedread@gmail.com>
3463
3464         Reviewed by Simon Fraser.
3465
3466         Correct order of matrix multiplication for SVGMatrix.
3467         https://bugs.webkit.org/show_bug.cgi?id=16062
3468
3469         Test: svg/dom/SVGMatrix-interface.xhtml
3470
3471         * bindings/js/JSSVGMatrixCustom.cpp:
3472         (WebCore::JSSVGMatrix::multiply):
3473         * svg/SVGMatrix.idl:
3474
3475 2009-11-04  Pavel Feldman  <pfeldman@chromium.org>
3476
3477         Reviewed by Timothy Hatcher.
3478
3479         Web Inspector: Make resource-related records in timeline
3480         actually take some time.
3481
3482         https://bugs.webkit.org/show_bug.cgi?id=31139
3483
3484         * English.lproj/localizedStrings.js:
3485         * inspector/front-end/TimelinePanel.js:
3486         (WebInspector.TimelinePanel):
3487         (WebInspector.TimelinePanel.prototype._formatRecord):
3488         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3489         (WebInspector.TimelinePanel.prototype.reset):
3490
3491 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3492
3493         Reviewed by Darin Fisher.
3494
3495         Simplify LocalStorageThread
3496         https://bugs.webkit.org/show_bug.cgi?id=30935
3497
3498         This is a re-submit of 50519.  LocalStorageTask should have never been ref
3499         counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.
3500
3501         On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
3502         of the method names a bit more clear. Assert proper thread usage. Join rather
3503         than detaching the thread and doing an ad-hoc form of join. Avoid touching
3504         variables on the background thread when simple to do so.  Also create a generic
3505         scheduleTask function rather than one for each task.
3506
3507         No behavior should have changed.
3508
3509         * storage/LocalStorageTask.h:
3510         * storage/LocalStorageThread.cpp:
3511         (WebCore::LocalStorageThread::create):
3512         (WebCore::LocalStorageThread::LocalStorageThread):
3513         (WebCore::LocalStorageThread::~LocalStorageThread):
3514         (WebCore::LocalStorageThread::start):
3515         (WebCore::LocalStorageThread::threadEntryPointCallback):
3516         (WebCore::LocalStorageThread::threadEntryPoint):
3517         (WebCore::LocalStorageThread::scheduleTask):
3518         (WebCore::LocalStorageThread::terminate):
3519         (WebCore::LocalStorageThread::performTerminate):
3520         * storage/LocalStorageThread.h:
3521         * storage/StorageSyncManager.cpp:
3522         (WebCore::StorageSyncManager::StorageSyncManager):
3523         (WebCore::StorageSyncManager::~StorageSyncManager):
3524         (WebCore::StorageSyncManager::scheduleImport):
3525         (WebCore::StorageSyncManager::scheduleSync):
3526         * storage/StorageSyncManager.h:
3527
3528 2009-11-04  Jeremy Orlow  <jorlow@chromium.org>
3529
3530         Reviewed by Darin Fisher.
3531
3532         Calling databaseIdentifier on LocalStorage's background thread is not safe.
3533         https://bugs.webkit.org/show_bug.cgi?id=31149
3534
3535         Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
3536         is not safe.  databaseIdentifier does a bunch of string concatenation which
3537         ref-counts StringImpls in some cases.  This was caught by valgrind thread
3538         sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
3539
3540         There's no way to test for such racyness, unfortunately.
3541
3542         * storage/StorageAreaSync.cpp:
3543         (WebCore::StorageAreaSync::StorageAreaSync):
3544         (WebCore::StorageAreaSync::performImport):
3545         * storage/StorageAreaSync.h:
3546         * storage/StorageSyncManager.cpp:
3547         (WebCore::StorageSyncManager::fullDatabaseFilename):
3548         * storage/StorageSyncManager.h:
3549
3550 2009-11-03  Jeremy Orlow  <jorlow@chromium.org>
3551
3552         Reviewed by Darin Fisher.
3553
3554         Clean up StorageAreaSync
3555         https://bugs.webkit.org/show_bug.cgi?id=31100
3556
3557         Major fixes: Break the ref count cycle for StorageArea on the main
3558         thread, not the background thread since the latter is not safe.
3559         Length() needs to block on the import completing.
3560
3561         Small fixes: setItem needs to handle the copy on write case even if it
3562         has an exception.  setItem and removeItem should just bail from the
3563         the function if the value hasn't changed rather than wrapping the end
3564         in an if block.  Clear should only send an event if it wasn't already
3565         cleared.  StorageAreaSync should assert that the final sync was
3566         scheduled.
3567
3568         * storage/StorageAreaImpl.cpp:
3569         (WebCore::StorageAreaImpl::length):
3570           Forgot to block on the import.
3571         (WebCore::StorageAreaImpl::key):
3572         (WebCore::StorageAreaImpl::setItem):
3573           Handle the copy on write case even when there's an exception.
3574         (WebCore::StorageAreaImpl::removeItem):
3575         (WebCore::StorageAreaImpl::clear):
3576         * storage/StorageAreaSync.cpp:
3577         (WebCore::StorageAreaSync::~StorageAreaSync):
3578         (WebCore::StorageAreaSync::scheduleFinalSync):
3579         (WebCore::StorageAreaSync::performImport):
3580         (WebCore::StorageAreaSync::markImported):
3581         (WebCore::StorageAreaSync::blockUntilImportComplete):
3582         * storage/StorageAreaSync.h:
3583
3584 2009-11-05  Zoltan Horvath  <zoltan@webkit.org>
3585
3586         Reviewed by Eric Seidel.
3587
3588         Allow custom memory allocation control for WebCore's CachedResource
3589         https://bugs.webkit.org/show_bug.cgi?id=31114
3590
3591         Inherits CachedResource class from Noncopyable because its (its child
3592         class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75 
3593         and it is no need to be copyable.
3594
3595         * loader/CachedResource.h:
3596
3597 2009-11-04  Mark Mentovai  <mark@chromium.org>
3598
3599         Reviewed by Mark Rowe.
3600
3601         Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
3602         is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
3603         which is true when targeting 10.6 or later.
3604
3605         HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
3606         is present in the CGInterpolationQuality enum, and must be handled
3607         by a switch that has cases for each enumerated value.
3608
3609         USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
3610         on 10.6 or later, and that CoreGraphics will understand when
3611         InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
3612
3613         * platform/graphics/cg/GraphicsContextCG.cpp:
3614         (WebCore::GraphicsContext::setImageInterpolationQuality):
3615         (WebCore::GraphicsContext::imageInterpolationQuality):
3616
3617 2009-11-04  Dan Kegel  <dank@chromium.org>
3618
3619         Reviewed by Alexey Proskuryakov.
3620
3621         Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
3622         https://bugs.webkit.org/show_bug.cgi?id=31138
3623
3624         Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
3625
3626         * page/Page.cpp:
3627         (WebCore::Page::userStyleSheetLocationChanged):
3628
3629 2009-11-04  Timothy Hatcher  <timothy@apple.com>
3630
3631         Update the Web Inspector Timeline panel to better match the mock-up.
3632
3633         https://bugs.webkit.org/show_bug.cgi?id=31150
3634
3635         Reviewed by Pavel Feldman.
3636
3637         * inspector/front-end/TimelinePanel.js:
3638         (WebInspector.TimelinePanel.prototype._getRecordDetails):
3639         (WebInspector.TimelinePanel.prototype._dragWindow):
3640         (WebInspector.TimelinePanel.prototype._resizeWindowLeft):