WebCore/ChangeLog

   1 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
   2
   3         Reviewed by Maciej.
   4
   5         More frame/iframe merging.
   6
   7         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
   8         false, so this was dead code.
   9         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
  10         than attach(), is the correct place for setInViewSourceMode, because
  11         openURL() is the function that creates our frame.
  12         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
  13         code that did the same thing in other places.
  14         - Made FRAME's attach() method suffuciently generic so that IFRAME could
  15         call up to it, rather than skipping its superclass and calling up directly
  16         to ELEMENT.
  17         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
  18         - Replaced ad hoc frame loading code in FRAME::attach() with call to
  19         openURL(), the designated frame loading function.
  20
  21         Layout tests pass. I added a layout test for viewsource mode, since I
  22         broke it in the course of writing this patch.
  23
  24 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
  25
  26         Reviewed by Geoff.
  27
  28         * dom/Document.cpp:
  29         (WebCore::Document::recalcStyleSelector):
  30         * dom/Document.h:
  31         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
  32
  33         * dom/Node.h:
  34         Remove DeprecatedStringList class forward declaration.
  35
  36         * editing/markup.cpp:
  37         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
  38
  39         * kcanvas/KCanvasTreeDebug.cpp:
  40         * kcanvas/KCanvasTreeDebug.h:
  41         Remove unused functions.
  42
  43         * loader/loader.cpp:
  44         * page/Frame.cpp:
  45         * page/Frame.h:
  46         * page/FrameView.h:
  47         Fixup DeprecatedStringList.h includes.
  48
  49 2006-09-30  David Harrison  <harrison@apple.com>
  50
  51         Reviewed by John Sullivan.
  52
  53         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
  54
  55         Problem was that the decision to trim was based only on whether the character
  56         is a soft hyphen, which caused pretty much any Japanese character to go.
  57         Changed to decide based on whether the character is ignorable whitespace.
  58
  59         Test:
  60         * fast/text/international/wrap-CJK-001.html
  61
  62         * rendering/bidi.cpp:
  63         (WebCore::isTrimmableChar):
  64         New. Checks whether character is whitespace that can be ignored
  65         according to the text node's style.
  66         trimmed from the end of wrapped line.
  67         (WebCore::checkMidpoints):
  68         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
  69
  70 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
  71
  72         Reviewed by Mitz Pettel.
  73
  74         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
  75
  76         * ksvg2/svg/SVGColor.cpp:
  77         (WebCore::SVGColor::setRGBColor):
  78         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  79         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  80         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
  81         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  82         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
  83         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
  84         (SVGFESpecularLightingElement::parseMappedAttribute):
  85         * ksvg2/svg/SVGFETurbulenceElement.cpp:
  86         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
  87         * ksvg2/svg/SVGLengthList.cpp:
  88         * ksvg2/svg/SVGNumberList.cpp:
  89         (SVGNumberList::parse):
  90         * ksvg2/svg/SVGNumberList.h:
  91         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
  92         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
  93         * ksvg2/svg/SVGStringList.cpp:
  94         (WebCore::SVGStringList::reset):
  95         * ksvg2/svg/SVGStringList.h:
  96         * ksvg2/svg/SVGTransformable.cpp:
  97         (SVGTransformable::parseTransformAttribute):
  98
  99 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
 100
 101         Reviewed by Eric, tweaked and landed by ap.
 102
 103         Fix Qt/Linux build.
 104
 105         * CMakeLists.txt:
 106         * platform/qt/PlatformScrollBar.h:
 107         * platform/qt/TemporaryLinkStubs.cpp:
 108         (WebCore::ScrollBar::ScrollBar):
 109         (WebCore::PlatformScrollBar::PlatformScrollBar):
 110         (FrameView::passMousePressEventToSubframe):
 111         (FrameView::passMouseMoveEventToSubframe):
 112         (FrameView::passMouseReleaseEventToSubframe):
 113         (FrameView::passWheelEventToSubframe):
 114         (FrameView::passMousePressEventToScrollbar):
 115         * ksvg2/svg/SVGDocument.h:
 116
 117 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 118
 119         Reviewed by Darin.
 120
 121         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
 122         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
 123
 124         No test case added (probably requires new DumpRenderTree functionality)
 125
 126         * rendering/RenderImage.cpp:
 127         (WebCore::RenderImage::imageChanged): Added early return if the document is
 128         being destroyed.
 129
 130 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
 131
 132         Reviewed by Hyatt.
 133
 134         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
 135         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
 136
 137         Make sure we only break after a space (and not any other valid line-break) if
 138         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
 139         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
 140         twice in quick succession.
 141
 142         * rendering/bidi.cpp:
 143         (WebCore::RenderBlock::findNextLineBreak):
 144
 145 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
 146
 147         Reviewed by Maciej and Darin.
 148
 149         http://bugs.webkit.org/show_bug.cgi?id=4372
 150         JavaScript document.write page form does not submit in Safari
 151
 152         Test: fast/forms/document-write.html
 153
 154         * page/Frame.cpp:
 155         (WebCore::Frame::submitForm): Don't check for parsing().
 156
 157 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
 158
 159         Build fix.
 160
 161         * bridge/mac/FrameViewMac.mm: Add missing #imports.
 162
 163 2006-10-01  Dave Hyatt  <hyatt@apple.com>
 164
 165         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
 166
 167         Reviewed by mitz
 168
 169         * bridge/mac/FrameMac.mm:
 170         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
 171         * bridge/mac/FrameViewMac.mm:
 172         (WebCore::FrameView::passMousePressEventToScrollbar):
 173         * page/FrameView.cpp:
 174         (WebCore::FrameView::handleMousePressEvent):
 175         (WebCore::FrameView::setMousePressed):
 176         * page/FrameView.h:
 177         * platform/win/TemporaryLinkStubs.cpp:
 178         (FrameView::passMousePressEventToScrollbar):
 179
 180 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
 181
 182         Reviewed by Darin.
 183
 184         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
 185         Add more SVG Objective-C DOM bindings
 186
 187         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
 188           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
 189           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
 190           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
 191           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
 192           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
 193
 194         * DerivedSources.make:
 195         * WebCore.xcodeproj/project.pbxproj:
 196         * bindings/objc/DOMInternal.h:
 197         * bindings/objc/DOMSVG.h:
 198         * bindings/scripts/CodeGeneratorObjC.pm:
 199         * ksvg2/svg/SVGAElement.idl:
 200         * ksvg2/svg/SVGAnimateColorElement.idl:
 201         * ksvg2/svg/SVGAnimateElement.idl:
 202         * ksvg2/svg/SVGAnimateTransformElement.idl:
 203         * ksvg2/svg/SVGAnimatedPathData.idl:
 204         * ksvg2/svg/SVGAnimatedPoints.idl:
 205         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
 206         * ksvg2/svg/SVGAnimationElement.idl:
 207         * ksvg2/svg/SVGCircleElement.idl:
 208         * ksvg2/svg/SVGClipPathElement.idl:
 209         * ksvg2/svg/SVGColor.idl:
 210         * ksvg2/svg/SVGCursorElement.idl:
 211         * ksvg2/svg/SVGDefsElement.idl:
 212         * ksvg2/svg/SVGDescElement.idl:
 213         * ksvg2/svg/SVGDocument.idl:
 214         * ksvg2/svg/SVGEllipseElement.idl:
 215         * ksvg2/svg/SVGPointList.idl:
 216         * ksvg2/svg/SVGPreserveAspectRatio.idl:
 217         * ksvg2/svg/SVGRect.idl:
 218         * ksvg2/svg/SVGSVGElement.idl:
 219
 220 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
 221
 222         Reviewed by Adele.
 223
 224         - fix build
 225
 226         * platform/FloatRect.h:
 227         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
 228         but more appropriate for path-type stuff.
 229         * platform/cg/PathCG.cpp:
 230         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
 231
 232 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
 233
 234         Reviewed by Darin.
 235
 236         http://bugs.webkit.org/show_bug.cgi?id=11011
 237         External CSS is parsed as iso-8859-1 even though the main document is utf-8
 238
 239         Test: fast/encoding/css-charset-default.xhtml
 240
 241         * loader/CachedResourceClient.h:
 242         (WebCore::CachedResourceClient::setCSSStyleSheet):
 243         (WebCore::CachedResourceClient::setXSLStyleSheet):
 244         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
 245         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
 246
 247         * css/CSSImportRule.cpp:
 248         (WebCore::CSSImportRule::setCSSStyleSheet):
 249         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
 250         * css/CSSImportRule.h:
 251
 252         * css/CSSStyleSheet.cpp:
 253         (WebCore::CSSStyleSheet::CSSStyleSheet):
 254         * css/CSSStyleSheet.h:
 255         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
 256         member. Changed some String parameters to const String&.
 257
 258         * css/StyleSheet.cpp:
 259         (WebCore::StyleSheet::StyleSheet):
 260         * css/StyleSheet.h:
 261         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
 262
 263         * css/StyleSheetList.cpp:
 264         (WebCore::StyleSheetList::length):
 265         (WebCore::StyleSheetList::item):
 266         * css/StyleSheetList.h:
 267         Special-casing implicit stylesheets seemed to be dead code, removed.
 268
 269         * dom/Document.cpp:
 270         (WebCore::Document::setCSSStyleSheet):
 271         (WebCore::Document::recalcStyleSelector):
 272         * dom/Document.h:
 273         Renamed setStyleSheet() to setCSSStyleSheet().
 274
 275         * dom/ProcessingInstruction.cpp:
 276         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
 277         (WebCore::ProcessingInstruction::setCSSStyleSheet):
 278         (WebCore::ProcessingInstruction::setXSLStyleSheet):
 279         (WebCore::ProcessingInstruction::parseStyleSheet):
 280         * dom/ProcessingInstruction.h:
 281
 282         * html/HTMLLinkElement.cpp:
 283         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
 284         is not specified.
 285         (WebCore::HTMLLinkElement::setCSSStyleSheet):
 286         * html/HTMLLinkElement.h:
 287
 288         * html/HTMLStyleElement.cpp:
 289         (WebCore::HTMLStyleElement::childrenChanged):
 290         * ksvg2/svg/SVGStyleElement.cpp:
 291         (WebCore::SVGStyleElement::childrenChanged):
 292         Inherit URL and charset from the document.
 293
 294         * loader/Cache.cpp:
 295         (WebCore::Cache::requestCSSStyleSheet):
 296         * loader/Cache.h:
 297         Adjust for setStyleSheet() renaming.
 298
 299         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
 300         * loader/CachedCSSStyleSheet.cpp:
 301         (WebCore::CachedCSSStyleSheet::ref):
 302         (WebCore::CachedCSSStyleSheet::deref):
 303         (WebCore::CachedCSSStyleSheet::checkNotify):
 304         Pass the encoding to setCSSStyleSheet().
 305
 306         * loader/CachedXSLStyleSheet.cpp:
 307         (WebCore::CachedXSLStyleSheet::ref):
 308         (WebCore::CachedXSLStyleSheet::checkNotify):
 309         * loader/DocLoader.cpp:
 310         (WebCore::DocLoader::requestCSSStyleSheet):
 311         * loader/DocLoader.h:
 312         * page/Frame.cpp:
 313         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
 314         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
 315         * xml/XSLImportRule.cpp:
 316         (WebCore::XSLImportRule::setXSLStyleSheet):
 317         (WebCore::XSLImportRule::loadSheet):
 318         * xml/XSLImportRule.h:
 319         Adjust for setStyleSheet() renaming.
 320
 321 2006-09-30  Rob Buis  <buis@kde.org>
 322
 323         Reviewed by eseidel.
 324
 325         http://bugs.webkit.org/show_bug.cgi?id=11096
 326         Hit testing for polylines fails
 327
 328         Fix Path::contains so it handles filled, non-closed paths too.
 329
 330         * platform/cg/PathCG.cpp:
 331         (WebCore::Path::contains):
 332
 333 2006-09-30  Dave Hyatt  <hyatt@apple.com>
 334
 335         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
 336         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
 337         subframes while the mouse is down.
 338
 339         Reviewed by mitzpettel
 340
 341         * bridge/mac/FrameMac.h:
 342         * bridge/mac/FrameMac.mm:
 343         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
 344         (WebCore::FrameMac::passWheelEventToWidget):
 345         * bridge/mac/FrameViewMac.mm:
 346         (WebCore::FrameView::passMousePressEventToSubframe):
 347         (WebCore::FrameView::passMouseMoveEventToSubframe):
 348         (WebCore::FrameView::passMouseReleaseEventToSubframe):
 349         (WebCore::FrameView::passWheelEventToSubframe):
 350         * page/Frame.cpp:
 351         * page/Frame.h:
 352         * page/FrameView.cpp:
 353         (WebCore::subframeForTargetNode):
 354         (WebCore::FrameView::handleMousePressEvent):
 355         (WebCore::FrameView::handleMouseDoubleClickEvent):
 356         (WebCore::FrameView::handleMouseMoveEvent):
 357         (WebCore::FrameView::handleMouseReleaseEvent):
 358         (WebCore::FrameView::handleWheelEvent):
 359         * page/FrameView.h:
 360         * platform/ScrollBar.h:
 361         (WebCore::ScrollBar::handleMouseMoveEvent):
 362         (WebCore::ScrollBar::handleMouseOutEvent):
 363         * platform/Widget.h:
 364         (WebCore::Widget::handleMouseMoveEvent):
 365         (WebCore::Widget::handleMouseReleaseEvent):
 366         * platform/win/TemporaryLinkStubs.cpp:
 367         (FrameView::passMousePressEventToSubframe):
 368         (FrameView::passMouseMoveEventToSubframe):
 369         (FrameView::passMouseReleaseEventToSubframe):
 370         (FrameView::passWheelEventToSubframe):
 371         (Widget::capturingMouse):
 372         (Widget::setCapturingMouse):
 373         (Widget::capturingTarget):
 374         (Widget::capturingChild):
 375         (Widget::setCapturingChild):
 376         * rendering/RenderView.cpp:
 377         (WebCore::RenderView::paintBoxDecorations):
 378
 379 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
 380
 381         Reviewed by Adele.
 382
 383         Fixes windows bustage:
 384         http://bugs.webkit.org/show_bug.cgi?id=11093
 385
 386         * platform/win/PlatformScrollBar.h:
 387         * platform/win/TemporaryLinkStubs.cpp:
 388         (PlatformScrollBar::PlatformScrollBar):
 389         (ScrollBar::ScrollBar):
 390
 391 2006-09-29  David Hyatt  <hyatt@apple.com>
 392
 393         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
 394         in RenderObject::NodeInfo (and then propagating that Widget to
 395         MouseEventWithHitTestResults).
 396
 397         This allows RenderListBox and RenderBlock to do the same thing when the
 398         mouse is over the scrollbar.
 399
 400         Also land fix to support font-size: 0.
 401
 402         Reviewed by mjs (scrollbar), eric (font-size)
 403
 404         * dom/Document.cpp:
 405         (WebCore::Document::prepareMouseEvent):
 406         * page/Frame.cpp:
 407         (WebCore::Frame::passWidgetMouseDownEventToWidget):
 408         * page/FrameView.cpp:
 409         (WebCore::selectCursor):
 410         (WebCore::FrameView::handleMouseMoveEvent):
 411         (WebCore::FrameView::dispatchMouseEvent):
 412         * page/MouseEventWithHitTestResults.cpp:
 413         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
 414         * page/MouseEventWithHitTestResults.h:
 415         (WebCore::MouseEventWithHitTestResults::scrollbar):
 416         * rendering/RenderBlock.cpp:
 417         (WebCore::RenderBlock::isPointInScrollbar):
 418         (WebCore::RenderBlock::nodeAtPoint):
 419         * rendering/RenderBlock.h:
 420         * rendering/RenderLayer.cpp:
 421         (WebCore::RenderLayer::hitTest):
 422         * rendering/RenderLayer.h:
 423         (WebCore::RenderLayer::getHiddenBehavior):
 424         * rendering/RenderListBox.cpp:
 425         (WebCore::RenderListBox::RenderListBox):
 426         (WebCore::RenderListBox::~RenderListBox):
 427         (WebCore::RenderListBox::isPointInScrollbar):
 428         * rendering/RenderListBox.h:
 429         * rendering/RenderObject.h:
 430         (WebCore::RenderObject::NodeInfo::NodeInfo):
 431         (WebCore::RenderObject::NodeInfo::scrollbar):
 432         (WebCore::RenderObject::NodeInfo::setScrollbar):
 433
 434 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
 435
 436         Reviewed by Adele.
 437
 438         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
 439
 440         * platform/win/ScrollViewWin.cpp:
 441         (WebCore::ScrollView::convertToContainingWindow):
 442         (WebCore::ScrollView::convertFromContainingWindow):
 443         * platform/win/WidgetWin.cpp:
 444         (WebCore::Widget::convertToContainingWindow):
 445         (WebCore::Widget::convertFromContainingWindow):
 446
 447 2006-09-29  Adele Peterson  <adele@apple.com>
 448
 449         Updated with new argument for PlatformScrollBar.
 450
 451         * platform/win/TemporaryLinkStubs.cpp:
 452         (PlatformScrollBar::PlatformScrollBar):
 453
 454 2006-09-29  Adele Peterson  <adele@apple.com>
 455
 456         Reviewed by Hyatt.
 457
 458         Fixing build bustage with cast to int.
 459
 460         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
 461
 462 2006-09-29  Adele Peterson  <adele@apple.com>
 463
 464         Fixing accidental include.
 465
 466         * rendering/RenderListBox.cpp:
 467
 468 2006-09-29  Adele Peterson  <adele@apple.com>
 469
 470         Adding RenderListBox files.
 471
 472         * WebCore.vcproj/WebCore/WebCore.vcproj:
 473
 474 2006-09-29  Adele Peterson  <adele@apple.com>
 475
 476         Reviewed by Adam.
 477
 478         Initial implementation of engine-based list box control.
 479
 480         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
 481
 482         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
 483         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
 484         (WebCore::FrameMac::FrameMac):
 485         (WebCore::FrameMac::handleMousePressEvent):
 486         (WebCore::FrameMac::handleMouseMoveEvent):
 487         (WebCore::FrameMac::mouseDown):
 488
 489         * page/Frame.cpp:
 490         (WebCore::Frame::handleMouseMoveEvent):
 491         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
 492         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
 493         (WebCore::Frame::autoscrollTimerFired): ditto.
 494         (WebCore::Frame::stopAutoscrollTimer): ditto.
 495         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
 496         * page/Frame.h:
 497         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
 498
 499         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
 500         (WebCore::FrameViewPrivate::reset):
 501         (WebCore::FrameView::currentMousePosition):
 502         (WebCore::FrameView::handleMousePressEvent):
 503         (WebCore::FrameView::handleMouseDoubleClickEvent):
 504         (WebCore::selectCursor):
 505         (WebCore::FrameView::handleMouseMoveEvent):
 506         (WebCore::FrameView::handleMouseReleaseEvent):
 507         * page/FrameView.h:
 508
 509         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
 510         * platform/ScrollBar.h:
 511         (WebCore::):
 512         (WebCore::ScrollBar::controlSize):
 513         * platform/mac/PlatformScrollBar.h:
 514         * platform/mac/PlatformScrollBarMac.mm:
 515         (NSControlSizeForScrollBarControlSize):
 516         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
 517         (WebCore::PlatformScrollBar::PlatformScrollBar):
 518
 519         * rendering/RenderBlock.h:
 520         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
 521         * rendering/RenderLayer.h:
 522         * rendering/RenderObject.cpp:
 523         (WebCore::RenderObject::shouldAutoscroll):
 524         (WebCore::RenderObject::autoscroll):
 525         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
 526
 527         * css/html4.css: Added properties for new list boxes.
 528
 529         * html/HTMLOptionElement.cpp:
 530         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
 531         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
 532         * html/HTMLOptionElement.h: Added disabled method.
 533
 534         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
 535         (WebCore::HTMLSelectElement::recalcStyle):
 536         (WebCore::HTMLSelectElement::lastSelectedListIndex):
 537         (WebCore::HTMLSelectElement::deselectItems):
 538         (WebCore::HTMLSelectElement::setSelectedIndex):
 539         (WebCore::HTMLSelectElement::isKeyboardFocusable):
 540         (WebCore::HTMLSelectElement::isMouseFocusable):
 541         (WebCore::HTMLSelectElement::createRenderer):
 542         (WebCore::HTMLSelectElement::recalcListItems):
 543         (WebCore::HTMLSelectElement::setRecalcListItems):
 544         (WebCore::HTMLSelectElement::reset):
 545         (WebCore::HTMLSelectElement::notifyOptionSelected):
 546         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
 547         (WebCore::HTMLSelectElement::nextSelectableListIndex):
 548         (WebCore::HTMLSelectElement::previousSelectableListIndex):
 549         * html/HTMLSelectElement.h:
 550
 551         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
 552         (WebCore::RenderTheme::paint):
 553         (WebCore::RenderTheme::paintBorderOnly):
 554         (WebCore::RenderTheme::paintDecorations):
 555         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
 556         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
 557         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
 558         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
 559         (WebCore::RenderTheme::isControlStyled):
 560         (WebCore::RenderTheme::supportsFocusRing):
 561         * rendering/RenderTheme.h:
 562         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
 563
 564         * rendering/RenderListBox.cpp: Added.
 565         (WebCore::RenderListBox::RenderListBox):
 566         (WebCore::RenderListBox::~RenderListBox):
 567         (WebCore::RenderListBox::setStyle):
 568         (WebCore::RenderListBox::updateFromElement):
 569         (WebCore::RenderListBox::calcMinMaxWidth):
 570         (WebCore::RenderListBox::size):
 571         (WebCore::RenderListBox::numItems):
 572         (WebCore::RenderListBox::calcHeight):
 573         (WebCore::RenderListBox::baselinePosition):
 574         (WebCore::RenderListBox::itemBoundingBoxRect):
 575         (WebCore::RenderListBox::paintObject):
 576         (WebCore::RenderListBox::paintScrollbar):
 577         (WebCore::RenderListBox::paintItemForeground):
 578         (WebCore::RenderListBox::paintItemBackground):
 579         (WebCore::RenderListBox::scrollBarTarget):
 580         (WebCore::RenderListBox::isPointInScrollbar):
 581         (WebCore::RenderListBox::optionAtPoint):
 582         (WebCore::RenderListBox::autoscroll):
 583         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
 584         (WebCore::RenderListBox::scroll):
 585         (WebCore::RenderListBox::valueChanged):
 586         * rendering/RenderListBox.h: Added.
 587         (WebCore::RenderListBox::isListBox):
 588         (WebCore::RenderListBox::selectionChanged):
 589         (WebCore::RenderListBox::setSelectionChanged):
 590         (WebCore::RenderListBox::canHaveChildren):
 591         (WebCore::RenderListBox::renderName):
 592         (WebCore::RenderListBox::setOptionsChanged):
 593         (WebCore::RenderListBox::shouldAutoscroll):
 594         (WebCore::RenderListBox::listIndexIsVisible):
 595
 596 2006-09-29  Beth Dakin  <bdakin@apple.com>
 597
 598         Reviewed by Darin.
 599
 600         We had a bug where html4.css was ignoring Media Queries. In the end
 601         the problem was that we were trying to send a char* to the
 602         MediaQueryEvaluator constructor that expects a String, but the
 603         char* got interpreted as a bool, the wrong constructor was called,
 604         and the media type was never set.
 605
 606         No test case possible since this only affects html4.css
 607
 608         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
 609         char*
 610         (WebCore::MediaQueryEvaluator):
 611         * css/MediaQueryEvaluator.h: Same.
 612
 613 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
 614
 615         Reviewed by John, Maciej.
 616
 617         Integrated some frame and iframe code. I'm trying to fix up frame ownership
 618         and loading. Reducing the number of different code paths involved
 619         seemed like a good first step.
 620
 621         As a side effect, I fixed a bug where FRAME elements would report their
 622         src attributes as relative, rather than compelete, URLs. (IFRAME elements
 623         had the correct complete URL behavior.)
 624
 625         * html/HTMLFrameElement.cpp:
 626         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
 627         (WebCore::HTMLFrameElement::openURL):
 628             (1) Removed checks that requestFrame does for us
 629             (2) Added isURLAllowed check, to have one clear bottleneck for it
 630             (3) Added viewsource check, to have one clear bottleneck for it
 631         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
 632         method, instead of finding our content frame in our own unique way.
 633         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
 634         since openURL does this for us now.
 635         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
 636         This is what FF does, and it made no sense to have different behaviors
 637         for FRAME and IFRAME elements.
 638         * html/HTMLIFrameElement.cpp:
 639         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
 640         code.
 641         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
 642         HTMLFrameElement now does everything we need.
 643
 644 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
 645
 646         Reviewed by Hyatt.
 647
 648         Fix Qt/Linux build.
 649
 650         * CMakeLists.txt:
 651         * platform/qt/ScrollViewQt.cpp:
 652         (WebCore::ScrollView::convertToContainingWindow):
 653         (WebCore::ScrollView::convertFromContainingWindow):
 654         * platform/qt/TemporaryLinkStubs.cpp:
 655         (WebCore::signedPublicKeyAndChallengeString):
 656         * platform/qt/WidgetQt.cpp:
 657         (WebCore::Widget::convertToContainingWindow):
 658         (WebCore::Widget::convertFromContainingWindow):
 659
 660 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
 661
 662         Reviewed by Tim H.
 663
 664         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
 665         Simplify Internal methods for the auto-generated Objective-C DOM code
 666
 667         - Auto-generate the internal methods for more Objective-C classes.
 668
 669         * WebCore.xcodeproj/project.pbxproj:
 670         * bindings/objc/DOM.mm:
 671         * bindings/objc/DOMCSS.mm:
 672         (-[DOMStyleSheet WebCore::]):
 673         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
 674         (-[DOMCSSRule WebCore::]):
 675         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
 676         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
 677         (-[DOMCSSValue WebCore::]):
 678         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
 679         (+[DOMCSSValue _CSSValueWith:WebCore::]):
 680         * bindings/objc/DOMHTMLAppletElement.mm:
 681         (-[DOMHTMLAppletElement WebCore::]):
 682         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
 683         * bindings/objc/DOMHTMLEmbedElement.mm:
 684         (-[DOMHTMLEmbedElement WebCore::]):
 685         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
 686         * bindings/objc/DOMInternal.h:
 687         * bindings/objc/DOMInternal.mm:
 688         * bindings/scripts/CodeGeneratorObjC.pm:
 689         * css/CSSCharsetRule.idl:
 690         * css/CSSFontFaceRule.idl:
 691         * css/CSSImportRule.idl:
 692         * css/CSSMediaRule.idl:
 693         * css/CSSPageRule.idl:
 694         * css/CSSPrimitiveValue.idl:
 695         * css/CSSStyleRule.idl:
 696         * css/CSSStyleSheet.idl:
 697         * css/CSSUnknownRule.idl:
 698         * css/CSSValueList.idl:
 699         * dom/KeyboardEvent.idl:
 700         * dom/MouseEvent.idl:
 701         * dom/MutationEvent.idl:
 702         * dom/NodeIterator.idl:
 703         * dom/OverflowEvent.idl:
 704         * dom/UIEvent.idl:
 705         * dom/WheelEvent.idl:
 706
 707 2006-09-29  David Harrison  <harrison@apple.com>
 708
 709         Reviewed by John Sullivan.
 710
 711         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
 712         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
 713
 714         Test added
 715         * fast/text/attributed-substring-from-range-001.html
 716
 717         * bridge/mac/FrameMac.mm:
 718         (WebCore::FrameMac::attributedString):
 719         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
 720         Also, add validation of the range.
 721
 722 2006-09-29  Rob Buis  <buis@kde.org>
 723
 724         Reviewed by Maciej.
 725
 726         http://bugs.webkit.org/show_bug.cgi?id=10893
 727         InsertRule can not handle @import statements
 728
 729         Allow @import as part of a css rule.
 730
 731         * css/CSSGrammar.y:
 732
 733 2006-09-28  David Hyatt  <hyatt@apple.com>
 734
 735         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
 736
 737         * bridge/mac/FrameMac.mm:
 738         (WebCore::FrameMac::eventMayStartDrag):
 739         (WebCore::FrameMac::dragHysteresisExceeded):
 740         (WebCore::FrameMac::mouseDown):
 741         (WebCore::FrameMac::shouldDragAutoNode):
 742         (WebCore::FrameMac::sendContextMenuEvent):
 743         * bridge/mac/WebCoreFrameBridge.mm:
 744         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
 745
 746 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 747
 748         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
 749         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
 750         view.
 751
 752         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
 753         the patch after review, once I realized that these new functions essentially do the same thing.)
 754
 755         * dom/EventTargetNode.cpp:
 756         (WebCore::EventTargetNode::dispatchMouseEvent):
 757         (WebCore::EventTargetNode::dispatchWheelEvent):
 758         * page/Frame.cpp:
 759         (WebCore::Frame::selectClosestWordFromMouseEvent):
 760         (WebCore::Frame::handleMousePressEventTripleClick):
 761         (WebCore::Frame::handleMousePressEventSingleClick):
 762         (WebCore::Frame::handleMouseMoveEvent):
 763         (WebCore::Frame::handleMouseReleaseEvent):
 764         * page/FrameView.cpp:
 765         (WebCore::FrameView::handleMousePressEvent):
 766         (WebCore::selectCursor):
 767         (WebCore::FrameView::dispatchDragEvent):
 768         (WebCore::FrameView::prepareMouseEvent):
 769         (WebCore::FrameView::handleWheelEvent):
 770         * platform/ScrollView.h:
 771         * platform/Widget.cpp:
 772         (WebCore::Widget::convertToContainingWindow):
 773         * platform/Widget.h:
 774         * platform/mac/ScrollViewMac.mm:
 775         (WebCore::ScrollView::convertToContainingWindow):
 776         (WebCore::ScrollView::convertFromContainingWindow):
 777         * platform/mac/WidgetMac.mm:
 778         (WebCore::Widget::convertToContainingWindow):
 779         (WebCore::Widget::convertFromContainingWindow):
 780         * platform/win/ScrollViewWin.cpp:
 781         (WebCore::ScrollView::convertToContainingWindow):
 782         (WebCore::ScrollView::convertFromContainingWindow):
 783         * rendering/RenderLayer.cpp:
 784         (WebCore::RenderLayer::resize):
 785
 786 2006-09-28  Alice Liu  <alice.liu@apple.com>
 787
 788         Build fix by adding missing files for CommandByName
 789
 790         * WebCore.xcodeproj/project.pbxproj:
 791
 792 2006-09-28  Alice Liu  <alice.liu@apple.com>
 793
 794         Adding CommandByName files to the vcproj
 795
 796         * WebCore.vcproj/WebCore/WebCore.vcproj:
 797
 798 2006-09-28  Alice Liu  <alice.liu@apple.com>
 799
 800         Reviewed by Adam Roben.
 801
 802         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
 803         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
 804         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
 805
 806         * editing/CommandByName.cpp: Added.
 807         Added a command class that hangs off the frame so the frame can call commands more easily.
 808         (WebCore::Frame::commandImp):
 809         (WebCore::Frame::execCopy):
 810         (WebCore::Frame::execCut):
 811         (WebCore::Frame::execDelete):
 812         (WebCore::Frame::execForwardDelete):
 813         (WebCore::Frame::execPaste):
 814         (WebCore::Frame::execMoveLeft):
 815         (WebCore::Frame::execMoveRight):
 816         (WebCore::Frame::execMoveUp):
 817         (WebCore::Frame::execMoveDown):
 818         (WebCore::Frame::execSelectAll):
 819         (WebCore::Frame::execSelectLeft):
 820         (WebCore::Frame::execSelectRight):
 821         (WebCore::Frame::execSelectUp):
 822         (WebCore::Frame::execSelectDown):
 823         (WebCore::Frame::enabled):
 824         (WebCore::Frame::enabledAnySelection):
 825         (WebCore::Frame::enabledAnyEditableSelection):
 826         (WebCore::Frame::enabledPaste):
 827         (WebCore::Frame::enabledAnyRangeSelection):
 828         (WebCore::Frame::enabledAnyEditableRangeSelection):
 829         (WebCore::Frame::createCommandDictionary):
 830         (WebCore::Frame::Command::):
 831         (WebCore:::m_frame):
 832         (WebCore::CommandByName::execCommand):
 833         * editing/CommandByName.h: Added.
 834         * page/Frame.cpp:
 835         Added implementation of accessor for CommandByName member
 836         (WebCore::Frame::command):
 837         * page/Frame.h:
 838         Added accessor for CommandByName member
 839         * page/FramePrivate.h:
 840         Added a CommandByName member
 841         (WebCore::FramePrivate::FramePrivate):
 842         * platform/PlatformMouseEvent.h:
 843         Changed constructor prototype
 844         * platform/StringImpl.cpp:
 845         Exposing getWordBreakIterator to be used elsewhere
 846         (WebCore::getWordBreakIterator):
 847         * platform/StringImpl.h:
 848         Exposing getWordBreakIterator to be used elsewhere
 849         * platform/win/MouseEventWin.cpp:
 850         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
 851         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
 852
 853 2006-09-28  Adam Roben  <aroben@apple.com>
 854
 855         Reviewed by Adele.
 856
 857         Remove no-longer-used PopUpButton.
 858
 859         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
 860         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
 861         PopUpButtonMac.mm
 862         * platform/PopUpButton.h: Removed.
 863         * platform/mac/PopUpButtonMac.mm: Removed.
 864         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
 865         * rendering/DeprecatedRenderSelect.cpp: Change #include of
 866         PopUpButton.h to ListBox.h
 867
 868 2006-09-28  Darin Adler  <darin@apple.com>
 869
 870         Reviewed by Alice.
 871
 872         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
 873           10% perf. regression (copying strings while decoding)
 874
 875         Use Vector<UChar> instead of String when building up the decoded string in
 876         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
 877         String grows the buffer every single time that append is called. Using
 878         Vector::append instead of String::append also avoids constructing a string
 879         each time just to append and a questionable copy that is done inside the
 880         String::append function which also contributed to the slowness.
 881
 882         * platform/PlatformString.h:
 883         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
 884         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
 885         allocation.
 886         * platform/StringImpl.h:
 887         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
 888
 889         * platform/StreamingTextDecoder.h:
 890         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
 891         Change to use a Vector<UChar> instead of a String, since vectors have better
 892         resizing performance (they store a separate capacity).
 893
 894         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
 895         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
 896         Change to use Vector<UChar> instead of String and then create a string at
 897         the end of the process using the new adopt function.
 898
 899 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
 900
 901         Reviewed by Tim H.
 902
 903         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
 904         Auto-generate more SVG Objective-C bindings
 905
 906         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
 907           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
 908           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
 909           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
 910           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
 911           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
 912           and DOMSVGTransformable.
 913
 914         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
 915           parent interfaces and the SVG animated classes.
 916
 917         - Corrects CodeGenerator.pm to only skip the first parent for the main
 918           interface.
 919
 920         * DerivedSources.make:
 921         * WebCore.xcodeproj/project.pbxproj:
 922         * bindings/objc/DOMInternal.h:
 923         * bindings/objc/DOMSVG.h:
 924         * bindings/scripts/CodeGenerator.pm:
 925         * bindings/scripts/CodeGeneratorObjC.pm:
 926         * ksvg2/svg/SVGAnimatedAngle.idl:
 927         * ksvg2/svg/SVGAnimatedBoolean.idl:
 928         * ksvg2/svg/SVGAnimatedEnumeration.idl:
 929         * ksvg2/svg/SVGAnimatedInteger.idl:
 930         * ksvg2/svg/SVGAnimatedLength.idl:
 931         * ksvg2/svg/SVGAnimatedLengthList.idl:
 932         * ksvg2/svg/SVGAnimatedNumber.idl:
 933         * ksvg2/svg/SVGAnimatedPathData.idl:
 934         * ksvg2/svg/SVGAnimatedString.idl:
 935         * ksvg2/svg/SVGAnimatedTransformList.idl:
 936         * ksvg2/svg/SVGExternalResourcesRequired.idl:
 937         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
 938         * ksvg2/svg/SVGFitToViewBox.idl:
 939         * ksvg2/svg/SVGLangSpace.idl:
 940         * ksvg2/svg/SVGLocatable.idl:
 941         * ksvg2/svg/SVGMetadataElement.idl:
 942         * ksvg2/svg/SVGStringList.idl:
 943         * ksvg2/svg/SVGStylable.idl:
 944         * ksvg2/svg/SVGStyleElement.idl:
 945         * ksvg2/svg/SVGTests.idl:
 946         * ksvg2/svg/SVGTransformable.idl:
 947         * ksvg2/svg/SVGURIReference.idl:
 948         * ksvg2/svg/SVGUnitTypes.idl:
 949         * ksvg2/svg/SVGZoomAndPan.idl:
 950
 951 2006-09-28  Brady Eidson  <beidson@apple.com>
 952
 953         Reviewed by Mitz Pettel!!!
 954
 955         Change the error code check for common functions from SQLResultOk to SQLResultDone
 956
 957         * loader/icon/IconDatabase.cpp:
 958         (WebCore::IconDatabase::forgetPageURLQuery):
 959         (WebCore::IconDatabase::setIconIDForPageURLQuery):
 960         (WebCore::IconDatabase::addIconForIconURLQuery):
 961
 962 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 963
 964         Just eliminate MapWindowPoints usage and use the HWND as
 965         the viewport.
 966
 967         * platform/win/MouseEventWin.cpp:
 968         (WebCore::positionForEvent):
 969         * platform/win/ScrollViewWin.cpp:
 970         (WebCore::ScrollView::viewportToContents):
 971         (WebCore::ScrollView::contentsToViewport):
 972
 973 2006-09-27  David Hyatt  <hyatt@apple.com>
 974
 975         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
 976         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
 977         scrollbars to provide hover feedback if needed.
 978
 979         Reviewed by Eric
 980
 981         * page/FrameView.cpp:
 982         (WebCore::selectCursor):
 983         (WebCore::FrameView::handleMouseMoveEvent):
 984         * platform/ScrollBar.h:
 985         (WebCore::ScrollBar::mouseMoved):
 986
 987 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
 988
 989         Reviewed by Maciej and Adam, landed by Adam
 990
 991         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
 992         Windows build is busted
 993
 994         * platform/win/TemporaryLinkStubs.cpp:
 995         (ScrollView::paint):
 996         (ScrollView::themeChanged):
 997
 998 2006-09-27  Eric Seidel  <eric@eseidel.com>
 999
1000         Reviewed by mitz.
1001
1002         paths with no fill specified default to black but do not recieve paint-related mouse events
1003         http://bugs.webkit.org/show_bug.cgi?id=11069
1004         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
1005
1006         Test: svg/custom/hover-default-fill.svg
1007
1008         * kcanvas/RenderPath.cpp:
1009         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
1010         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
1011         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1012         (WebCore::KSVGPainterFactory::isFilled): remove null check
1013         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
1014         (WebCore::KSVGPainterFactory::isStroked): remove null check
1015         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
1016         * ksvg2/svg/SVGPaint.cpp:
1017         (WebCore::SVGPaint::defaultFill): added.
1018         (WebCore::SVGPaint::defaultStroke): added.
1019         * ksvg2/svg/SVGPaint.h:
1020
1021 2006-09-27  Rob Buis  <buis@kde.org>
1022
1023         Reviewed by eseidel.
1024
1025         http://bugs.webkit.org/show_bug.cgi?id=11015
1026         SVG handles em units incorrectly
1027
1028         Calculate viewport coordinates at layout time, since
1029         at this point the font size is known and lengths depending
1030         on font sizes can be calculated correctly.
1031
1032         * kcanvas/RenderSVGContainer.cpp:
1033         (WebCore::RenderSVGContainer::layout):
1034         (WebCore::RenderSVGContainer::viewport):
1035         (WebCore::RenderSVGContainer::calcViewport):
1036         * kcanvas/RenderSVGContainer.h:
1037         * ksvg2/svg/SVGLength.cpp:
1038         (WebCore::SVGLength::updateValue):
1039         * ksvg2/svg/SVGMarkerElement.cpp:
1040         (WebCore::SVGMarkerElement::createRenderer):
1041         * ksvg2/svg/SVGSVGElement.cpp:
1042         (WebCore::SVGSVGElement::createRenderer):
1043         (WebCore::SVGSVGElement::attributeChanged):
1044         * ksvg2/svg/SVGSVGElement.h:
1045
1046 2006-09-27  Eric Seidel  <eric@eseidel.com>
1047
1048         Reviewed by darin.
1049
1050         Change our invalid-fill error behavior to match Opera (and soon Firefox)
1051         http://bugs.webkit.org/show_bug.cgi?id=11017
1052
1053         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1054         (WebCore::KSVGPainterFactory::isFilled):
1055         (WebCore::KSVGPainterFactory::fillPaintServer):
1056         (WebCore::KSVGPainterFactory::isStroked):
1057         (WebCore::KSVGPainterFactory::strokePaintServer):
1058
1059 2006-09-27  Brady Eidson  <beidson@apple.com>
1060
1061         Build fix
1062
1063         * loader/icon/IconDatabase.cpp:
1064         (WebCore::readySQLStatement):
1065
1066 2006-09-27  Brady Eidson  <beidson@apple.com>
1067
1068         Reviewed by Adam
1069
1070         In very specific circumstances, prepared SQLStatements can become invalid without
1071         any warning.  This checks for that state and re-prepares the statement and also
1072         adds more aggressive error-checking everywhere these statements are used.
1073
1074         * loader/icon/IconDatabase.cpp:
1075         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
1076         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
1077         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
1078         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
1079         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
1080         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
1081         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
1082         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
1083         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
1084         * loader/icon/SQLStatement.cpp:
1085         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
1086         * loader/icon/SQLStatement.h:
1087
1088 2006-09-26  Darin Adler  <darin@apple.com>
1089
1090         Reviewed by Steve.
1091
1092         - clean up options for font code path
1093
1094         * platform/Font.h:
1095         * platform/Font.cpp:
1096         (WebCore::Font::setCodePath): Added. Replaces boolean version.
1097         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
1098
1099         * platform/mac/WebCoreTextRenderer.mm:
1100         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
1101
1102 2006-09-26  John Sullivan  <sullivan@apple.com>
1103
1104         Reviewed by Darin
1105
1106         * bridge/mac/WebCoreFrameBridge.h:
1107         * bridge/mac/WebCoreFrameBridge.mm:
1108         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
1109         Added limit parameter, passed down to Frame
1110
1111         * page/Frame.h:
1112         * page/Frame.cpp:
1113         (WebCore::Frame::markAllMatchesForText):
1114         Added limit parameter. Stop the search if it hits limit.
1115
1116 2006-09-26  Sean Gies  <seangies@apple.com>
1117
1118         Reviewed by Brady Eidson.
1119
1120         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
1121
1122 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
1123
1124         Reviewed by john
1125
1126         <rdar://problem/4747695>
1127         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
1128
1129         * editing/DeleteSelectionCommand.cpp:
1130         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
1131         to select special elements that are fully selected after expansion
1132         moves to positions that are visually distinct from the originals.
1133         * editing/InsertListCommand.cpp:
1134         (WebCore::InsertListCommand::doApply): If the content of the list
1135         item will be moved into another list, put it in a list item.
1136
1137 2006-09-26  Geoffrey Garen <ggaren@apple.com>
1138
1139         Reviewed by Darin.
1140
1141         Temporary work-around for frame lifetime issue.
1142
1143         * page/Frame.cpp:
1144         (WebCore::Frame::clear):
1145         (WebCore::Frame::disconnectOwnerElement):
1146
1147 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1148
1149         Reviewed by Tim H.
1150
1151         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1152         Auto-generate DOMSVGElement for the Objective-C bindings
1153
1154         - Auto-generates DOMSVGElement.
1155
1156         - Make SVGExceptions work like all the other ExceptionCode
1157           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1158           and SVGExceptionMax.
1159
1160         * DerivedSources.make:
1161         * WebCore.xcodeproj/project.pbxproj:
1162         * bindings/js/kjs_binding.cpp:
1163         (KJS::):
1164         (KJS::setDOMException):
1165         * bindings/objc/DOMInternal.h:
1166         * bindings/objc/DOMInternal.mm:
1167         (raiseDOMException):
1168         * bindings/objc/DOMSVG.h:
1169         * bindings/objc/DOMSVGExecption.h: Added.
1170         * ksvg2/ksvg.h:
1171         * ksvg2/svg/SVGElement.cpp:
1172         (WebCore::SVGElement::setId):
1173         (WebCore::SVGElement::setXmlbase):
1174         * ksvg2/svg/SVGElement.h:
1175         * ksvg2/svg/SVGElement.idl:
1176         * ksvg2/svg/SVGException.h: Added.
1177         (WebCore::):
1178
1179 2006-09-26  Eric Seidel  <eric@eseidel.com>
1180
1181         Reviewed by Tim H.
1182
1183         viewbox parser does not allow <tab> as a delimiter
1184         http://bugs.webkit.org/show_bug.cgi?id=11014
1185
1186         Test: svg/hixie/viewbox/003.xml
1187
1188         * ksvg2/svg/svgpathparser.cpp:
1189         (WebCore::isWhitespace): new function
1190         (WebCore::skipOptionalSpaces):
1191         (WebCore::skipOptionalSpacesOrComma):
1192
1193 2006-09-26  Eric Seidel  <eric@eseidel.com>
1194
1195         Reviewed by Tim H.
1196
1197         SVGDocument::createElement does not create elements in the SVG namespace
1198         http://bugs.webkit.org/show_bug.cgi?id=10932
1199
1200         Test: svg/custom/createelement.svg
1201
1202         * ksvg2/svg/SVGDocument.cpp:
1203         (WebCore::SVGDocument::createElement):
1204         * ksvg2/svg/SVGDocument.h:
1205
1206 2006-09-26  Eric Seidel  <eric@eseidel.com>
1207
1208         Reviewed by Tim H.
1209
1210         RenderPath::nodeAtPoint does not respect stroke width
1211         http://bugs.webkit.org/show_bug.cgi?id=10829
1212
1213         Test: svg/custom/stroke-width-click.svg
1214
1215         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1216         (WebCore::RenderPath::strokeContains):
1217         * kcanvas/device/quartz/QuartzSupport.h:
1218         * kcanvas/device/quartz/QuartzSupport.mm:
1219
1220 2006-09-26  Eric Seidel  <eric@eseidel.com>
1221
1222         Reviewed by mitz.
1223
1224         Bring animation back to life
1225         http://bugs.webkit.org/show_bug.cgi?id=11021
1226
1227         Register/unregister SVGSVGElements as time containers on insertion/removal.
1228         Replace uses of DeprecatedString with String in SVGAnimationElement
1229         Various whitespace clean-up.
1230
1231         * ksvg2/misc/KSVGTimeScheduler.cpp:
1232         (WebCore::SVGTimer::notifyAll):
1233         * ksvg2/misc/SVGDocumentExtensions.cpp:
1234         (WebCore::SVGDocumentExtensions::startAnimations):
1235         (WebCore::SVGDocumentExtensions::pauseAnimations):
1236         (WebCore::SVGDocumentExtensions::unpauseAnimations):
1237         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1238         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1239         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1240         * ksvg2/svg/SVGAnimateTransformElement.h:
1241         * ksvg2/svg/SVGAnimationElement.cpp:
1242         (WebCore::SVGAnimationElement::SVGAnimationElement):
1243         (WebCore::SVGAnimationElement::parseMappedAttribute):
1244         (WebCore::SVGAnimationElement::parseClockValue):
1245         (WebCore::SVGAnimationElement::targetAttribute):
1246         (WebCore::SVGAnimationElement::setTargetAttribute):
1247         (WebCore::SVGAnimationElement::attributeName):
1248         * ksvg2/svg/SVGAnimationElement.h:
1249         (WebCore::SVGAnimationElement::rendererIsNeeded):
1250         * ksvg2/svg/SVGSVGElement.cpp:
1251         (WebCore::SVGSVGElement::getScreenCTM):
1252         (WebCore::SVGSVGElement::createRenderer):
1253         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
1254         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
1255         * ksvg2/svg/SVGSVGElement.h:
1256         * ksvg2/svg/SVGSetElement.cpp:
1257         (WebCore::SVGSetElement::handleTimerEvent):
1258         * ksvg2/svg/SVGURIReference.cpp:
1259         (WebCore::SVGURIReference::getTarget):
1260         * ksvg2/svg/SVGURIReference.h:
1261
1262 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
1263
1264         Reviewed by mitzpettel.
1265
1266         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
1267         No-SVG build broken since r16549
1268
1269         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
1270
1271         * css/cssparser.cpp:
1272         (WebCore::CSSParser::parseValue):
1273         * css/cssstyleselector.cpp:
1274         (WebCore::CSSStyleSelector::applyProperty):
1275         * page/FrameView.cpp:
1276         (WebCore::selectCursor):
1277         * platform/qt/GraphicsContextQt.cpp:
1278
1279 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
1280
1281         Reviewed by Maciej.
1282
1283         http://bugs.webkit.org/show_bug.cgi?id=10820
1284         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
1285
1286         (Originally written by Eric Seidel).
1287
1288         * bindings/js/kjs_window.cpp:
1289         (KJS::floatFeature):
1290         * ksvg2/svg/SVGAngle.cpp:
1291         (SVGAngle::setValueAsString):
1292         * ksvg2/svg/SVGAnimationElement.cpp:
1293         (SVGAnimationElement::parseMappedAttribute):
1294         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1295         (SVGComponentTransferFunctionElement::parseMappedAttribute):
1296         * ksvg2/svg/SVGFECompositeElement.cpp:
1297         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1298         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1299         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1300         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1301         (SVGFEDisplacementMapElement::parseMappedAttribute):
1302         * ksvg2/svg/SVGFELightElement.cpp:
1303         (SVGFELightElement::parseMappedAttribute):
1304         * ksvg2/svg/SVGFEOffsetElement.cpp:
1305         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1306         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1307         (SVGFESpecularLightingElement::parseMappedAttribute):
1308         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1309         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1310         * ksvg2/svg/SVGStopElement.cpp:
1311         (SVGStopElement::parseMappedAttribute):
1312         * platform/AtomicString.h:
1313         (WebCore::AtomicString::toDouble):
1314         * platform/PlatformString.h:
1315         * platform/String.cpp:
1316         (WebCore::String::toDouble):
1317         * platform/StringImpl.cpp:
1318         (WebCore::StringImpl::toDouble):
1319         * platform/StringImpl.h:
1320         * rendering/DeprecatedSlider.cpp:
1321         (WebCore::DeprecatedSlider::updateFromElement):
1322         * xml/XPathGrammar.y:
1323
1324 2006-09-25  David Harrison  <harrison@apple.com>
1325
1326         Reviewed by Tim Omernick and Tim Hatcher.
1327
1328         <rdar://problem/4717965> Text Field text parameterized attributes should work
1329         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
1330
1331         * bridge/mac/WebCoreAXObject.mm:
1332         (-[WebCoreAXObject accessibilityAttributeValue:]):
1333         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
1334
1335         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1336         Cleaned up. Added text field and text area parameterzed attributes.
1337
1338         (-[WebCoreAXObject doAXLineForTextMarker:]):
1339         Fixed to be zero-based and to deal with the first position properly.
1340
1341         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
1342         Minor formatting.
1343
1344         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
1345         (-[WebCoreAXObject indexForTextMarker:]):
1346         (-[WebCoreAXObject textMarkerRangeForRange:]):
1347         (-[WebCoreAXObject rangeForTextMarkerRange:]):
1348         New utility methods.
1349
1350         (-[WebCoreAXObject doAXLineForIndex:]):
1351         (-[WebCoreAXObject doAXRangeForLine:]):
1352         (-[WebCoreAXObject doAXStringForRange:]):
1353         (-[WebCoreAXObject doAXRangeForPosition:]):
1354         (-[WebCoreAXObject doAXRangeForIndex:]):
1355         (-[WebCoreAXObject doAXBoundsForRange:]):
1356         (-[WebCoreAXObject doAXAttributedStringForRange:]):
1357         (-[WebCoreAXObject doAXRTFForRange:]):
1358         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
1359         Implement text field and text area parameterized attributes.
1360
1361         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1362         Added text field and text area parameterzed attributes.
1363
1364         * rendering/RenderTextControl.h:
1365         Made indexForVisiblePosition() and visiblePositionForIndex() public.
1366
1367 2006-09-25  Adam Roben  <aroben@apple.com>
1368
1369         Reviewed by Brady.
1370
1371         Build fixes.
1372
1373         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
1374         * platform/ResourceLoader.h: Store whether a particular job
1375         has received a response within the ResourceLoader object itself, since
1376         it's possible that we will enter the InternetReadFileExA while loop
1377         twice for the same job.
1378         * platform/ResourceLoaderInternal.h: Add private instance variable to
1379         store whether we've received a response.
1380         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1381         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
1382         directives.
1383         * platform/win/ResourceLoaderWin.cpp:
1384         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
1385         whether it has received a response instead of assuming it hasn't.
1386         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
1387         (WebCore::ResourceLoader::hasReceivedResponse): Added.
1388         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
1389         setProportion
1390         (ScrollBar::setProportion):
1391
1392 2006-09-25  Brady Eidson  <beidson@apple.com>
1393
1394         Requested by ggaren
1395
1396         Disabled IconDatabase logging by default
1397
1398         * platform/Logging.cpp:
1399         (WebCore::):
1400
1401 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
1402
1403         Build fix
1404
1405         * platform/cf/ResourceLoaderCFNet.cpp:
1406         (WebCore::willCacheResponse):
1407
1408 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
1409
1410         Reviewed by john
1411
1412         <http://bugs.webkit.org/show_bug.cgi?id=11002>
1413         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
1414
1415         * editing/IndentOutdentCommand.cpp:
1416         (WebCore::IndentOutdentCommand::indentRegion): Special case
1417         an empty root editable element.
1418
1419 2006-09-25  Brady Eidson  <beidson@apple.com>
1420
1421         Reviewed by Steve
1422
1423         Math error in SystemTimeWin
1424
1425         * platform/win/SystemTimeWin.cpp:
1426         (WebCore::currentTime):
1427
1428 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
1429
1430         Reviewed by Eric.
1431
1432         Whitespace cleanup; rename *job variables to *loader.
1433
1434         * bindings/js/JSXMLHttpRequest.cpp:
1435         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
1436         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
1437         (KJS::JSXMLHttpRequestConstructorImp::construct):
1438         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
1439         (KJS::JSXMLHttpRequest::getValueProperty):
1440         (KJS::JSXMLHttpRequest::put):
1441         (KJS::JSXMLHttpRequest::putValueProperty):
1442         (KJS::JSXMLHttpRequest::mark):
1443         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
1444         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
1445         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
1446         * bindings/js/JSXMLHttpRequest.h:
1447         (KJS::JSXMLHttpRequest::toBoolean):
1448         * xml/xmlhttprequest.cpp:
1449         (WebCore::XMLHttpRequest::XMLHttpRequest):
1450         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1451         (WebCore::XMLHttpRequest::send):
1452         (WebCore::XMLHttpRequest::abort):
1453         (WebCore::XMLHttpRequest::receivedAllData):
1454         (WebCore::XMLHttpRequest::receivedData):
1455         * xml/xmlhttprequest.h:
1456         (WebCore::):
1457
1458 2006-09-25  Timothy Hatcher  <timothy@apple.com>
1459
1460         Reviewed by Brady.
1461
1462         - Deprecate the rest of the old-style methods that are not generated.
1463         - Add @property syntax to DOMRange.
1464
1465         * WebCore.xcodeproj/project.pbxproj:
1466         * bindings/objc/DOM.mm:
1467         (-[DOMRange setStart:offset:]):
1468         (-[DOMRange setEnd:offset:]):
1469         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1470         (-[DOMRange setStart::]):
1471         (-[DOMRange setEnd::]):
1472         (-[DOMRange compareBoundaryPoints::]):
1473         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1474         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1475         (-[DOMDocument createNodeIterator::::]):
1476         (-[DOMDocument createTreeWalker::::]):
1477         * bindings/objc/DOMCSS.h:
1478         * bindings/objc/DOMCSS.mm:
1479         (-[DOMDocument getComputedStyle:pseudoElement:]):
1480         (-[DOMDocument getComputedStyle::]):
1481         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1482         * bindings/objc/DOMExtensions.h:
1483         * bindings/objc/DOMHTML.h:
1484         * bindings/objc/DOMRange.h:
1485         * bindings/objc/DOMTraversal.h:
1486
1487 2006-09-25  Eric Seidel  <eric@eseidel.com>
1488
1489         Reviewed by mjs.
1490
1491         Outermost <svg> element should clip to viewport
1492         http://bugs.webkit.org/show_bug.cgi?id=11007
1493
1494         Test: svg/custom/viewport-clip.svg
1495
1496         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1497
1498 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1499
1500         Reviewed by Maciej.
1501
1502         * css/MediaList.cpp:
1503         Remove unused header.
1504
1505         * dom/Document.cpp:
1506         (WebCore::Document::clear):
1507         Use clear instead of iterating through the list of event listeners, removing each one.
1508         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1509
1510         * html/HTMLKeygenElement.cpp:
1511         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1512         (WebCore::HTMLKeygenElement::appendFormData):
1513         Update due to changes in the SSL key generator.
1514
1515         * ksvg2/svg/SVGAngle.cpp:
1516         Remove unused header.
1517
1518         * ksvg2/svg/SVGAnimationElement.cpp:
1519         (SVGAnimationElement::parseMappedAttribute):
1520         Rename methods and pass Strings instead of DeprecatedStrings to
1521         parseSeparatedList.
1522
1523         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1524         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1525         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1526         * ksvg2/svg/SVGFEMergeElement.cpp:
1527         * ksvg2/svg/SVGFEOffsetElement.cpp:
1528         Remove unused headers.
1529
1530         * ksvg2/svg/SVGHelper.cpp:
1531         (WebCore::SVGHelper::parseSeparatedList):
1532         * ksvg2/svg/SVGHelper.h:
1533         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
1534         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1535
1536         * ksvg2/svg/SVGLengthList.cpp:
1537         (WebCore::SVGLengthList::parse):
1538         * ksvg2/svg/SVGLengthList.h:
1539         Use Vector<String> instead of DeprecatedStringList.
1540
1541         * loader/Cache.cpp:
1542         (WebCore::Cache::requestImage):
1543         (WebCore::Cache::requestStyleSheet):
1544         (WebCore::Cache::requestScript):
1545         (WebCore::Cache::requestXSLStyleSheet):
1546         (WebCore::Cache::requestXBLDocument):
1547         (WebCore::Cache::remove):
1548         (WebCore::Cache::get):
1549         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1550
1551         * loader/DocLoader.cpp:
1552         (WebCore::DocLoader::needReload):
1553         * loader/DocLoader.h:
1554         Use a HashSet instead of DeprecatedStringList.
1555
1556         * page/FrameView.h:
1557         Remove declarations that have no functions.
1558
1559         * platform/SSLKeyGenerator.h:
1560         * platform/mac/SSLKeyGeneratorMac.mm:
1561         (WebCore::supportedKeySizes):
1562         (WebCore::signedPublicKeyAndChallengeString):
1563         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1564         DeprecatedString.
1565
1566 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1567
1568         Shunt the RenderTheme world transform adoption between
1569         Cairo and Windows into getWindowsContext and move the method
1570         out of GraphicsContextCairo and into GraphicsContextWin.
1571
1572         * ChangeLog:
1573         * WebCore.vcproj/WebCore/WebCore.vcproj:
1574         * platform/cairo/GraphicsContextCairo.cpp:
1575         * platform/win/GraphicsContextWin.cpp: Added.
1576         (WebCore::GraphicsContext::getWindowsContext):
1577         (WebCore::GraphicsContext::releaseWindowsContext):
1578         * rendering/RenderThemeWin.cpp:
1579         (WebCore::prepareForDrawing):
1580
1581 2006-09-24  Eric Seidel  <eric@eseidel.com>
1582
1583         Reviewed by hyatt.
1584
1585         <svg:a> cannot be styled with a:hover
1586         http://bugs.webkit.org/show_bug.cgi?id=11005
1587
1588         Test: svg/hixie/cascade/002.xml
1589
1590         * css/cssstyleselector.cpp:
1591         (WebCore::checkPseudoState):
1592
1593 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1594
1595         Reviewed by Tim H.
1596
1597         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1598         SVG needs Obj-C DOM bindings
1599
1600         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
1601           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1602           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
1603           DOMSVGTransformList.
1604
1605         * DerivedSources.make:
1606         * WebCore.xcodeproj/project.pbxproj:
1607         * bindings/objc/DOMInternal.h:
1608         * bindings/objc/DOMSVG.h: Added.
1609         * ksvg2/svg/SVGAngle.idl:
1610         * ksvg2/svg/SVGLength.idl:
1611         * ksvg2/svg/SVGLengthList.idl:
1612         * ksvg2/svg/SVGMatrix.idl:
1613         * ksvg2/svg/SVGPathSeg.idl:
1614         * ksvg2/svg/SVGPathSegList.idl:
1615         * ksvg2/svg/SVGTransform.idl:
1616         * ksvg2/svg/SVGTransformList.idl:
1617
1618 2006-09-24  Rob Buis  <buis@kde.org>
1619
1620         Reviewed by eseidel.
1621
1622         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1623         WebKit does not handle fallback custom cursors
1624         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1625         WebKit does not properly handle SVG <cursor> element
1626
1627         Add support for svg cursor images. Also make sure hotspot
1628         settings are handled correctly. Add tests for handling of css3
1629         cursor syntax with hotspots in strict and quirks mode. Finally
1630         implement fallback.
1631
1632         * WebCore.xcodeproj/project.pbxproj:
1633         * css/CSSComputedStyleDeclaration.cpp:
1634         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1635         * css/CSSCursorImageValue.cpp: Added.
1636         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1637         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1638         * css/CSSCursorImageValue.h: Added.
1639         (WebCore::CSSCursorImageValue::hotspot):
1640         * css/cssparser.cpp:
1641         (WebCore::CSSParser::parseValue):
1642         * css/cssstyleselector.cpp:
1643         (WebCore::CSSStyleSelector::applyProperty):
1644         * ksvg2/svg/SVGCursorElement.cpp:
1645         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1646         * manual-tests/css3-cursor-fallback-strict.html: Added.
1647         * manual-tests/cursorfallback.xml: Added.
1648         * page/FrameView.cpp:
1649         (WebCore::selectCursor):
1650         * platform/Cursor.h:
1651         * platform/mac/CursorMac.mm:
1652         (WebCore::createCustomCursor):
1653         (WebCore::Cursor::Cursor):
1654         * platform/qt/CursorQt.cpp:
1655         (WebCore::Cursor::Cursor):
1656         * rendering/RenderStyle.cpp:
1657         (WebCore::StyleInheritedData::StyleInheritedData):
1658         (WebCore::StyleInheritedData::operator==):
1659         (WebCore::RenderStyle::diff):
1660         (WebCore::RenderStyle::addCursor):
1661         (WebCore::RenderStyle::addSVGCursor):
1662         (WebCore::RenderStyle::setCursorList):
1663         (WebCore::RenderStyle::clearCursorList):
1664         * rendering/RenderStyle.h:
1665         (WebCore::CursorData::CursorData):
1666         (WebCore::CursorList::operator[]):
1667         (WebCore::CursorList::size):
1668         (WebCore::CursorList::append):
1669         (WebCore::RenderStyle::cursors):
1670
1671 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1672
1673         Reviewed by Tim H.
1674
1675         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1676         Auto-generate the internal methods interfaces for the Objective-C bindings
1677
1678         - Auto-generate the internal method declarations into their own files
1679           named in the form DOMFooBarInternal.h for class DOMFooBar.
1680
1681         - Remove all use of DOM_cast from code.
1682
1683         - Assorted cleanups.
1684
1685         * WebCore.xcodeproj/project.pbxproj:
1686         * bindings/objc/DOM.mm:
1687         (-[DOMNode _initWithNode:WebCore::]):
1688         (-[DOMNode WebCore::]):
1689         (-[DOMRange dealloc]):
1690         (-[DOMRange finalize]):
1691         (-[DOMRange _initWithRange:WebCore::]):
1692         (-[DOMRange WebCore::]):
1693         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1694         (-[DOMNodeFilter WebCore::]):
1695         (-[DOMNodeFilter dealloc]):
1696         (-[DOMNodeFilter finalize]):
1697         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1698         (-[DOMNodeIterator WebCore::]):
1699         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1700         (-[DOMTreeWalker WebCore::]):
1701         * bindings/objc/DOMAbstractView.mm:
1702         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1703         * bindings/objc/DOMCSS.mm:
1704         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1705         (-[DOMCSSRule _initWithRule:WebCore::]):
1706         (-[DOMCSSValue _initWithValue:WebCore::]):
1707         * bindings/objc/DOMEvents.mm:
1708         (-[DOMEvent _initWithEvent:WebCore::]):
1709         * bindings/objc/DOMHTMLAppletElement.mm:
1710         (-[DOMHTMLAppletElement align]):
1711         (-[DOMHTMLAppletElement setAlign:]):
1712         (-[DOMHTMLAppletElement alt]):
1713         (-[DOMHTMLAppletElement setAlt:]):
1714         (-[DOMHTMLAppletElement archive]):
1715         (-[DOMHTMLAppletElement setArchive:]):
1716         (-[DOMHTMLAppletElement code]):
1717         (-[DOMHTMLAppletElement setCode:]):
1718         (-[DOMHTMLAppletElement codeBase]):
1719         (-[DOMHTMLAppletElement setCodeBase:]):
1720         (-[DOMHTMLAppletElement height]):
1721         (-[DOMHTMLAppletElement setHeight:]):
1722         (-[DOMHTMLAppletElement hspace]):
1723         (-[DOMHTMLAppletElement setHspace:]):
1724         (-[DOMHTMLAppletElement name]):
1725         (-[DOMHTMLAppletElement setName:]):
1726         (-[DOMHTMLAppletElement object]):
1727         (-[DOMHTMLAppletElement setObject:]):
1728         (-[DOMHTMLAppletElement vspace]):
1729         (-[DOMHTMLAppletElement setVspace:]):
1730         (-[DOMHTMLAppletElement width]):
1731         (-[DOMHTMLAppletElement setWidth:]):
1732         * bindings/objc/DOMInternal.h:
1733         (getDOMWrapper):
1734         (addDOMWrapper):
1735         (raiseOnDOMError):
1736         * bindings/objc/DOMXPath.mm:
1737         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1738         * bindings/scripts/CodeGeneratorObjC.pm:
1739
1740 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1741
1742         Reviewed by eseidel.
1743
1744         Fix Qt/Linux build after Dave's Scrollbar changes.
1745
1746         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
1747         * platform/qt/TemporaryLinkStubs.cpp:
1748         (WebCore::ScrollBar::setProportion):
1749         (WebCore::PlatformScrollBar::updateThumbPosition):
1750         (WebCore::PlatformScrollBar::updateThumbProportion):
1751
1752 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1753
1754         Reviewed by eseidel.
1755
1756         Qt/Linux build system changes: enable xpath/xslt by default.
1757         Offer possibility to change all of these using 'ccmake'.
1758
1759         * CMakeLists.txt:
1760
1761 2006-09-24  Dave Hyatt  <hyatt@apple.com>
1762
1763         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
1764         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
1765         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
1766
1767         * platform/ScrollBar.cpp:
1768         (WebCore::ScrollBar::setValue):
1769         (WebCore::ScrollBar::setProportion):
1770         * platform/ScrollBar.h:
1771         (WebCore::ScrollBar::value):
1772         * platform/mac/PlatformScrollBar.h:
1773         * platform/mac/PlatformScrollBarMac.mm:
1774         (WebCore::PlatformScrollBar::updateThumbPosition):
1775         (WebCore::PlatformScrollBar::updateThumbProportion):
1776         * platform/win/PlatformScrollBar.h:
1777         * platform/win/TemporaryLinkStubs.cpp:
1778         (PlatformScrollBar::updateThumbPosition):
1779         (PlatformScrollBar::updateThumbProportion):
1780         * rendering/RenderLayer.cpp:
1781         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1782
1783 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
1784
1785         Reviewed by Eric.
1786
1787         http://bugs.webkit.org/show_bug.cgi?id=4872
1788         XMLHttpRequest fails to throw an exception when there is a security violation
1789         (mismatching domains)
1790
1791         Raise an exception if there is a security violation, and also in cases required by
1792         the current draft of XHR specification.
1793
1794         * bindings/js/JSXMLHttpRequest.cpp:
1795         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
1796         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
1797         reports one, and also if there were too few arguments passed.
1798
1799         * bindings/js/kjs_binding.cpp:
1800         (KJS::setDOMException): Added support for custom XHR exceptions.
1801
1802         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
1803         exception code range for XHR exceptions.
1804
1805         * xml/xmlhttprequest.cpp:
1806         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
1807         (WebCore::XMLHttpRequest::send):
1808         (WebCore::XMLHttpRequest::setRequestHeader):
1809         (WebCore::XMLHttpRequest::getStatus):
1810         (WebCore::XMLHttpRequest::getStatusText):
1811         (WebCore::XMLHttpRequest::processSyncLoadResults):
1812         (WebCore::XMLHttpRequest::receivedAllData):
1813         (WebCore::XMLHttpRequest::receivedData):
1814
1815 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
1816
1817         Reviewed by Jeff Jenkins.
1818
1819         Tweak CF types.
1820
1821         * platform/cf/ResourceLoaderCFNet.cpp:
1822         (WebCore::willCacheResponse):
1823
1824 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
1825
1826         Reviewed by darin
1827
1828         <http://bugs.webkit.org/show_bug.cgi?id=8029>
1829         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
1830
1831         * dom/Document.cpp:
1832         (WebCore::Document::clearSelectionIfNeeded):
1833         * dom/Element.cpp:
1834         (WebCore::Element::contains):
1835         * dom/Node.cpp:
1836         (WebCore::Node::traverseNextNode):
1837         (WebCore::Node::traverseNextSibling):
1838         (WebCore::Node::traversePreviousNodePostOrder):
1839         (WebCore::Node::checkAddChild):
1840         (WebCore::Node::isDescendantOf):
1841         * dom/Node.h:
1842         * dom/NodeIterator.cpp:
1843         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
1844         * editing/ApplyStyleCommand.cpp:
1845         (WebCore::ApplyStyleCommand::applyBlockStyle):
1846         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1847         (WebCore::ApplyStyleCommand::applyInlineStyle):
1848         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
1849         * editing/CompositeEditCommand.cpp:
1850         (WebCore::CompositeEditCommand::mergeIdenticalElements):
1851         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
1852         * editing/DeleteSelectionCommand.cpp:
1853         (WebCore::updatePositionForNodeRemoval):
1854         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1855         (WebCore::DeleteSelectionCommand::mergeParagraphs):
1856         * editing/FormatBlockCommand.cpp:
1857         (WebCore::FormatBlockCommand::doApply):
1858         * editing/IndentOutdentCommand.cpp:
1859         (WebCore::enclosingListOrBlockquote):
1860         * editing/Selection.cpp:
1861         (WebCore::Selection::validate):
1862         * editing/SelectionController.cpp:
1863         (WebCore::SelectionController::nodeWillBeRemoved):
1864         * editing/TextIterator.cpp:
1865         (WebCore::SimplifiedBackwardsTextIterator::advance):
1866         * editing/VisiblePosition.cpp:
1867         (WebCore::VisiblePosition::next):
1868         (WebCore::VisiblePosition::previous):
1869         (WebCore::VisiblePosition::canonicalPosition):
1870         (WebCore::isFirstVisiblePositionInNode):
1871         (WebCore::isLastVisiblePositionInNode):
1872         * editing/htmlediting.cpp:
1873         (WebCore::firstEditablePositionAfterPositionInRoot):
1874         (WebCore::lastEditablePositionBeforePositionInRoot):
1875         (WebCore::enclosingNodeWithTag):
1876         (WebCore::enclosingList):
1877         (WebCore::enclosingListChild):
1878         * editing/markup.cpp:
1879         (WebCore::createMarkup):
1880
1881 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1882
1883         Reviewed by Darin.
1884
1885         - Added @property syntax to non-generated headers
1886           inside #ifndef BUILDING_ON_TIGER.
1887         - Changed the DOMEventTarget protocol to have have new versions
1888           of addEventListener and removeEventListener with named parameters.
1889           These old style methods can be removed once Mail changes to use
1890           the new methods <rdar://problem/4746649>.
1891
1892         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
1893         * bindings/objc/DOM.mm:
1894         (-[DOMNode addEventListener:listener:useCapture:]):
1895         (-[DOMNode addEventListener:::]): call the new method
1896         (-[DOMNode removeEventListener:listener:useCapture:]):
1897         (-[DOMNode removeEventListener:::]): call the new method
1898         * bindings/objc/DOMAbstractView.h:
1899         * bindings/objc/DOMEventTarget.h:
1900         * bindings/objc/DOMHTMLAppletElement.h:
1901         * bindings/objc/DOMHTMLEmbedElement.h:
1902         * bindings/objc/DOMHTMLOptionElement.h:
1903         * bindings/objc/DOMObject.h:
1904         * bindings/objc/DOMRGBColor.h:
1905
1906 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1907
1908         Reviewed by Eric.
1909
1910         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
1911
1912         * platform/qt/FrameQt.cpp:
1913         * platform/qt/GraphicsContextQt.cpp:
1914         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
1915         (WebCore::GraphicsContext::origin):
1916         * platform/qt/PlatformScrollBar.h: Added.
1917         (WebCore::PlatformScrollBar::isWidget):
1918         * platform/qt/WidgetQt.cpp:
1919         (WebCore::Widget::invalidate):
1920         (WebCore::Widget::invalidateRect):
1921
1922 2006-09-22  Dave Hyatt <hyatt@apple.com>
1923
1924         Super-minor tweaks to the systemFont function on Mac.
1925         Set the generic family to None rather than to Serif, and
1926         don't waste time setting the computed size, since that is
1927         set from the specified size over in CSSStyleSelector anyway.
1928
1929         * rendering/RenderThemeMac.mm:
1930         (WebCore::RenderThemeMac::systemFont):
1931
1932 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1933
1934         Reviewed by Brady.
1935
1936         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
1937         take floats. There was already an implicit conversion to float/double
1938         when calling CGContextTranslateCTM or cairo_translate.
1939
1940         * platform/GraphicsContext.h:
1941         * platform/cairo/GraphicsContextCairo.cpp:
1942         (WebCore::GraphicsContext::translate):
1943         * platform/cg/GraphicsContextCG.cpp:
1944         (WebCore::GraphicsContext::translate):
1945
1946 2006-09-22  Brady Eidson  <beidson@apple.com>
1947
1948         Reviewed by Sfalken
1949
1950         Add redirect and other cleanup to ResourceLoaderWin.cpp
1951         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
1952         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
1953
1954         * WebCore.xcodeproj/project.pbxproj:
1955         * platform/ResourceLoader.h:
1956         * platform/win/ResourceLoaderWin.cpp:
1957         (WebCore::ResourceLoaderWndProc):
1958         (WebCore::initializeOffScreenResourceLoaderWindow):
1959         (WebCore::ResourceLoader::onHandleCreated):
1960         (WebCore::ResourceLoader::onRequestRedirected):
1961         (WebCore::ResourceLoader::onRequestComplete):
1962         (WebCore::transferJobStatusCallback):
1963
1964 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
1965
1966         Reviewed by Geoff.
1967
1968         http://bugs.webkit.org/show_bug.cgi?id=10803
1969         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
1970
1971         * page/FrameView.cpp:
1972         (WebCore::FrameView::hoverTimerFired): Use the current event.
1973
1974 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1975
1976         Reviewed by Anders.
1977
1978         Fix (last) svg memory leak.
1979
1980         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
1981         (SVGTransformable::parseTransformAttribute):
1982
1983 2006-09-22  Eric Seidel  <eric@eseidel.com>
1984
1985         No review necessary, just removing a dead file.
1986
1987         Remove unused file (added previously by mistake) to make room for real implementation.
1988
1989         * platform/mac/BitmapImageMac.mm: Removed.
1990
1991 2006-09-22  Dave Hyatt <hyatt@apple.com>
1992
1993         Move PlatformScrollBar.h down into the platforms.
1994
1995         Reviewed by andersca
1996
1997         * platform/PlatformScrollBar.h: Removed.
1998         * platform/win/PlatformScrollBar.h: Added.
1999         * platform/mac/PlatformScrollBar.h: Added.
2000
2001 2006-09-22   Dave Hyatt  <hyatt@apple.com>
2002
2003         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
2004         any widget subsystems that don't have any underlying native objects backing the widgets.
2005
2006         Reviewed by anders
2007
2008         * platform/Widget.h:
2009         * platform/mac/WidgetMac.mm:
2010         (WebCore::Widget::invalidate):
2011         (WebCore::Widget::invalidateRect):
2012         * platform/win/TemporaryLinkStubs.cpp:
2013         (Widget::invalidate):
2014         (Widget::invalidateRect):
2015
2016 2006-09-22  Rob Buis  <buis@kd.org>
2017
2018         Reviewed by eseidel.
2019
2020         http://bugs.webkit.org/show_bug.cgi?id=10901
2021         Merge build fixes from unity
2022
2023         * CMakeLists.txt:
2024
2025 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2026
2027         Reviewed by eseidel.
2028
2029         http://bugs.webkit.org/show_bug.cgi?id=10977
2030         SVGDocument does not expose 'rootElement' property
2031
2032         Enable 'rootElement' property.
2033
2034         * ksvg2/svg/SVGDocument.idl:
2035
2036 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
2037
2038         Tweak includes.
2039
2040         * platform/ResourceLoaderInternal.h:
2041
2042 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2043
2044         build fixed. band happy.
2045
2046         * platform/cg/GraphicsContextCG.cpp:
2047         (WebCore::GraphicsContext::translate):
2048         * platform/mac/WidgetMac.mm:
2049
2050 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2051
2052         Reviewed by Maciej.
2053
2054         Some Widget refactoring.
2055
2056         * WebCore.vcproj/WebCore/WebCore.vcproj:
2057         * bridge/mac/FrameMac.mm:
2058         * bridge/win/FrameWin.cpp:
2059         (WebCore::FrameWin::runJavaScriptAlert):
2060         (WebCore::FrameWin::runJavaScriptConfirm):
2061         * bridge/win/PageWin.cpp:
2062         (WebCore::Page::Page):
2063         (WebCore::rootWindowForFrame):
2064         * html/CanvasRenderingContext2D.cpp:
2065         (WebCore::CanvasRenderingContext2D::translate):
2066         * page/FrameView.cpp:
2067         (WebCore::FrameView::isFrameView):
2068         * page/Page.h:
2069         (WebCore::Page::setInstanceHandle):
2070         (WebCore::Page::instanceHandle):
2071         * platform/GraphicsContext.h:
2072         * platform/ScrollView.h:
2073         * platform/Widget.h:
2074         * platform/cairo/GraphicsContextCairo.cpp:
2075         (WebCore::GraphicsContext::translate):
2076         (WebCore::GraphicsContext::origin):
2077         * platform/mac/WidgetMac.mm:
2078         (WebCore::Widget::clearFocus):
2079         * platform/win/ResourceLoaderWin.cpp:
2080         (WebCore::initializeOffScreenResourceLoaderWindow):
2081         * platform/win/ScreenWin.cpp:
2082         (WebCore::monitorInfo):
2083         * platform/win/ScrollViewWin.cpp:
2084         (WebCore::ScrollView::updateContents):
2085         (WebCore::ScrollView::visibleWidth):
2086         (WebCore::ScrollView::visibleHeight):
2087         (WebCore::ScrollView::visibleContentRect):
2088         (WebCore::ScrollView::viewportToContents):
2089         (WebCore::ScrollView::contentsToViewport):
2090         (WebCore::ScrollView::scrollBy):
2091         (WebCore::ScrollView::updateScrollInfo):
2092         (WebCore::ScrollView::updateScrollBars):
2093         * platform/win/SharedTimerWin.cpp:
2094         (WebCore::initializeOffScreenTimerWindow):
2095         * platform/win/TemporaryLinkStubs.cpp:
2096         (FrameView::updateBorder):
2097         (ScrollView::paint):
2098         (GraphicsContext::clip):
2099         * platform/win/WidgetWin.cpp:
2100         (WebCore::Widget::Widget):
2101         (WebCore::Widget::parentWindow):
2102         (WebCore::Widget::setParentWindow):
2103         (WebCore::Widget::frameGeometry):
2104         (WebCore::Widget::hasFocus):
2105         (WebCore::Widget::setFocus):
2106         (WebCore::Widget::show):
2107         (WebCore::Widget::hide):
2108         (WebCore::Widget::setFrameGeometry):
2109
2110 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2111
2112         Reviewed by Tim H.
2113
2114         * platform/TextEncoding.cpp:
2115         (WebCore::TextEncoding::backslashAsCurrencySymbol):
2116         Add comment clarifying why backslashAsCurrencySymbol is needed.
2117
2118 2006-09-21  Sean Gies  <seangies@apple.com>
2119
2120         Reviewed by Adam Roben.
2121
2122         Add utility functions to get and release HDC from GraphicsContext.
2123
2124         * platform/GraphicsContext.h: Add utilities to get and release HDC.
2125         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
2126         * rendering/RenderThemeWin.cpp: Switch to new utilities.
2127
2128 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
2129
2130         Reviewed by anders
2131
2132         <rdar://problem/4426622>
2133         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
2134
2135         * editing/htmlediting.cpp:
2136         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
2137         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
2138         Got rid of uses of DepricatedString.
2139
2140 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2141
2142         Reviewed by eseidel.
2143
2144         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2145
2146         * page/Frame.cpp:
2147         (WebCore::Frame::endIfNotLoading):
2148
2149 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2150
2151         Reviewed by eseidel.
2152
2153         Fix Qt/Linux build.
2154
2155         * CMakeLists.txt:
2156         * kcanvas/device/qt/KCanvasClipperQt.h:
2157         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2158         * platform/qt/FrameQt.cpp:
2159         (WebCore::FrameQt::isLoadTypeReload):
2160         (WebCore::FrameQt::originalRequestURL):
2161         * platform/qt/FrameQt.h:
2162         * platform/qt/GraphicsContextQt.cpp:
2163         (WebCore::GraphicsContext::concatCTM):
2164         * platform/qt/ScrollViewQt.cpp:
2165         (WebCore::ScrollView::wheelEvent):
2166         * platform/qt/TemporaryLinkStubs.cpp:
2167         (WebCore::IconDatabase::setIconURLForPageURL):
2168
2169 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2170
2171         Reviewed by john
2172
2173         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2174         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2175
2176         * editing/MoveSelectionCommand.cpp:
2177         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2178         to the position-to-move-to's document, not the fragment's document.  The
2179         fragment's document is the document used to create the fragment and is irrelavant.
2180
2181 === Safari-521.27 ===
2182
2183 2006-09-21  Brady Eidson  <beidson@apple.com>
2184
2185         Reviewed by Anders
2186
2187         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2188         This fixes Spinneret so it won't crash on its first load!
2189
2190         * page/Frame.cpp:
2191         (WebCore::Frame::endIfNotLoading):
2192
2193 2006-09-21  Brady Eidson  <beidson@apple.com>
2194
2195         Build fix
2196
2197         * platform/win/TemporaryLinkStubs.cpp:
2198         (ScrollView::wheelEvent):
2199
2200 2006-09-20  Rob Buis  <buis@kde.org>
2201
2202         Reviewed by eseidel.
2203
2204         http://bugs.webkit.org/show_bug.cgi?id=10946
2205         new marker code draws end-marker in wrong place
2206
2207         Keep track of the start of the subpath so we can handle
2208         closeTo/moveTo correctly.
2209
2210         * kcanvas/RenderPath.cpp:
2211         (WebCore::DrawMarkersData::DrawMarkersData):
2212         (WebCore::updateMarkerDataForElement):
2213
2214 2006-09-21  David Hyatt <hyatt@apple.com>
2215
2216         Wheel scrolling prep for Win32.
2217
2218         WARNING: NO TEST CASES ADDED OR CHANGED
2219
2220         * platform/PlatformWheelEvent.h:
2221         * platform/ScrollBar.h:
2222         * platform/ScrollView.h:
2223         * platform/mac/ScrollViewMac.mm:
2224         (WebCore::ScrollView::wheelEvent):
2225         * rendering/RenderLayer.cpp:
2226
2227 2006-09-20  Timothy Hatcher  <timothy@apple.com>
2228
2229         Reviewed by Hyatt.
2230
2231         Bug 10917: REGRESSION (r16027): iFrame transparency broken
2232         http://bugs.webkit.org/show_bug.cgi?id=10917
2233
2234         Don't paint the base background color if we transparent.
2235
2236         * rendering/RenderBox.cpp:
2237         (WebCore::RenderBox::paintBackgroundExtended):
2238
2239 2006-09-20  Adam Roben  <aroben@apple.com>
2240
2241         Reviewed by andersca.
2242
2243         * platform/FileChooser.h: Remove no-longer-necessary namespace std
2244
2245 2006-09-20  Eric Seidel  <eric@eseidel.com>
2246
2247         Reviewed by beth.
2248
2249         Cleanup style in KCanvas.
2250         Remove extra white-space, unneeded arguments, etc.
2251
2252         * WebCore.xcodeproj/project.pbxproj:
2253         * kcanvas/KCanvasClipper.cpp:
2254         (WebCore::operator<<):
2255         (WebCore::KCanvasClipper::externalRepresentation):
2256         * kcanvas/KCanvasClipper.h:
2257         * kcanvas/KCanvasFilters.cpp:
2258         (WebCore::KCanvasFilter::externalRepresentation):
2259         (WebCore::operator<<):
2260         (WebCore::KCanvasFilterEffect::externalRepresentation):
2261         (WebCore::KCPointLightSource::externalRepresentation):
2262         (WebCore::KCSpotLightSource::externalRepresentation):
2263         (WebCore::KCDistantLightSource::externalRepresentation):
2264         (WebCore::KCanvasFEBlend::externalRepresentation):
2265         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
2266         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
2267         (WebCore::KCanvasFEComposite::externalRepresentation):
2268         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
2269         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
2270         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
2271         (WebCore::KCanvasFEFlood::externalRepresentation):
2272         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
2273         (WebCore::KCanvasFEImage::externalRepresentation):
2274         (WebCore::KCanvasFEMerge::externalRepresentation):
2275         (WebCore::KCanvasFEMorphology::externalRepresentation):
2276         (WebCore::KCanvasFEOffset::externalRepresentation):
2277         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
2278         (WebCore::KCanvasFETile::externalRepresentation):
2279         (WebCore::KCanvasFETurbulence::externalRepresentation):
2280         * kcanvas/KCanvasFilters.h:
2281         (WebCore::KCanvasFEDiffuseLighting::lightSource):
2282         (WebCore::KCanvasFESpecularLighting::lightSource):
2283         * kcanvas/KCanvasImage.h:
2284         * kcanvas/KCanvasMarker.cpp:
2285         (WebCore::KCanvasMarker::externalRepresentation):
2286         * kcanvas/KCanvasMarker.h:
2287         * kcanvas/KCanvasResource.cpp:
2288         (WebCore::operator<<):
2289         * kcanvas/KCanvasResource.h:
2290         * kcanvas/KCanvasTreeDebug.cpp:
2291         (WebCore::operator<<):
2292         (WebCore::writeIndent):
2293         (WebCore::writeStyle):
2294         (WebCore::write):
2295         (WebCore::writeRenderResources):
2296         * kcanvas/KCanvasTreeDebug.h:
2297         (WebCore::operator<<):
2298         * kcanvas/RenderForeignObject.cpp:
2299         (WebCore::RenderForeignObject::paint):
2300         * kcanvas/RenderPath.cpp:
2301         (WebCore::RenderPath::paint):
2302         (WebCore::drawStartAndMidMarkers):
2303         * kcanvas/RenderSVGContainer.cpp:
2304         (WebCore::RenderSVGContainer::paint):
2305         * kcanvas/RenderSVGImage.cpp:
2306         (WebCore::RenderSVGImage::translateForAttributes):
2307         * kcanvas/RenderSVGImage.h:
2308         * kcanvas/device/KRenderingDevice.cpp:
2309         (WebCore::KRenderingDevice::currentContext):
2310         (WebCore::KRenderingDevice::popContext):
2311         (WebCore::KRenderingDevice::pushContext):
2312         * kcanvas/device/KRenderingDevice.h:
2313         * kcanvas/device/KRenderingFillPainter.h:
2314         * kcanvas/device/KRenderingPaintServer.h:
2315         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2316         (WebCore::KRenderingPaintServer::activeClient):
2317         (WebCore::KRenderingPaintServer::setActiveClient):
2318         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2319         (WebCore::operator<<):
2320         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
2321         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
2322         (WebCore::KRenderingPaintServerGradient::listener):
2323         (WebCore::KRenderingPaintServerGradient::setListener):
2324         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
2325         * kcanvas/device/KRenderingPaintServerGradient.h:
2326         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2327         (WebCore::KRenderingPaintServerPattern::tile):
2328         (WebCore::KRenderingPaintServerPattern::setTile):
2329         (WebCore::KRenderingPaintServerPattern::listener):
2330         (WebCore::KRenderingPaintServerPattern::setListener):
2331         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
2332         * kcanvas/device/KRenderingPaintServerPattern.h:
2333         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2334         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
2335         * kcanvas/device/KRenderingPaintServerSolid.h:
2336         * kcanvas/device/KRenderingStrokePainter.cpp:
2337         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2338         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2339         * kcanvas/device/KRenderingStrokePainter.h:
2340         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2341         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2342         (WebCore::KCanvasFilterQuartz::prepareFilter):
2343         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2344         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2345         (WebCore::KCanvasMaskerQuartz::applyMask):
2346         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2347         (WebCore::KCanvasImageQuartz::init):
2348         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2349         (WebCore::KCanvasClipperQuartz::applyClip):
2350         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2351         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2352         (WebCore::KRenderingDeviceQuartz::quartzContext):
2353         (WebCore::KRenderingDeviceQuartz::contextForImage):
2354         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2355         (WebCore::KRenderingDeviceQuartz::createResource):
2356         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2357         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2358         (WebCore::CGShadingRefForLinearGradient):
2359         (WebCore::CGShadingRefForRadialGradient):
2360         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2361         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2362         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2363         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2364         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
2365         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
2366         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
2367         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
2368         (WebCore::KRenderingPaintServerSolidQuartz::draw):
2369         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2370         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2371         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2372         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2373         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
2374         * kcanvas/device/quartz/QuartzSupport.h:
2375         * kcanvas/device/quartz/QuartzSupport.mm:
2376         (WebCore::applyStrokeStyleToContext):
2377
2378 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2379
2380         Reviewed by Dave Hyatt.
2381
2382         * dom/WheelEvent.cpp:
2383         (WebCore::WheelEvent::WheelEvent):
2384         Use lroundf instead of lround since deltas are floats.
2385
2386 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
2387
2388         Reviewed by eseidel.  Landed by eseidel.
2389
2390         Test: svg/custom/pattern-y-offset.svg
2391
2392         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2393         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2394
2395 2006-09-20  David Hyatt  <hyatt@apple.com>
2396
2397         Add a new wheelEvent method to ScrollView.  Platforms that wish
2398         to handle the wheel event for the scroll view themselves can then
2399         do so there.  (Mac lets the underlying NSScrollView do it for now.)
2400
2401         * page/FrameView.cpp:
2402         (WebCore::FrameView::handleWheelEvent):
2403         * platform/ScrollView.h:
2404         (WebCore::ScrollView::wheelEvent):
2405
2406 2006-09-20  Brady Eidson  <beidson@apple.com>
2407
2408         Reviewed by Tim Omernick
2409
2410         Part of fixing a crash Tim O showed me that I missed in a release build.
2411         WebKit should be able to call through the bridge to WebCore no matter what -
2412         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
2413
2414         * bridge/mac/WebCoreIconDatabaseBridge.h:
2415         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2416         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2417         (-[WebCoreIconDatabaseBridge isOpen]):
2418         (-[WebCoreIconDatabaseBridge removeAllIcons]):
2419         (-[WebCoreIconDatabaseBridge _isEmpty]):
2420         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2421         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2422         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2423         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2424         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2425         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2426         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2427         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2428         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2429         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2430         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2431         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
2432         (-[WebCoreIconDatabaseBridge _setEnabled:]):
2433         (-[WebCoreIconDatabaseBridge _isEnabled]):
2434
2435 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2436
2437         Reviewed by Darin.
2438
2439         Add String::split which returns a Vector of Strings and use it instead of
2440         DeprecatedStringList.
2441
2442         * bindings/js/kjs_events.cpp:
2443         (KJS::Clipboard::getValueProperty):
2444         * bindings/js/kjs_window.cpp:
2445         (KJS::parseModalDialogFeatures):
2446         * css/MediaList.cpp:
2447         (WebCore::MediaList::setMediaText):
2448         * dom/Clipboard.h:
2449         * html/HTMLFormElement.cpp:
2450         (WebCore::HTMLFormElement::formData):
2451         * html/HTMLLinkElement.cpp:
2452         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2453         * platform/PlatformString.h:
2454         * platform/String.cpp:
2455         (WebCore::String::split):
2456         * platform/StringImpl.cpp:
2457         * platform/StringImpl.h:
2458         * platform/mac/ClipboardMac.h:
2459         * platform/mac/ClipboardMac.mm:
2460         (WebCore::ClipboardMac::types):
2461
2462 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2463
2464         Reviewed by harrison
2465
2466         * css/cssstyleselector.cpp:
2467         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
2468         HTMLElement::isContentEditable just to check the Frame's editability, since
2469         it calls updateRenderering, which can get us into infinite recursion.
2470
2471 2006-09-20  Brady Eidson  <beidson@apple.com>
2472
2473         Reviewed by Darin
2474
2475         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2476
2477         * loader/icon/IconDatabase.cpp:
2478         (WebCore::IconDatabase::IconDatabase): Disabled by default
2479         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2480         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2481         (WebCore::IconDatabase::iconForPageURL): Ditto
2482         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2483         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2484         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2485         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2486         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2487         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2488         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2489         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2490
2491 2006-09-20  Adam Roben  <aroben@apple.com>
2492
2493         Reviewed by Adele.
2494
2495         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2496         REGRESSION: file upload control with direction:rtl or text-align:right
2497         draws button on top of filename/icon
2498
2499         * rendering/RenderFileUploadControl.cpp:
2500         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2501         match direction
2502         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2503         the filename and icon in RTL
2504
2505 2006-09-20  Alice Liu  <alice.liu@apple.com>
2506
2507         Reviewed by Adam Roben.
2508
2509         fixed windows build
2510
2511         * dom/WheelEvent.cpp:
2512         (WebCore::WheelEvent::WheelEvent):
2513         changed lrint to lround
2514
2515 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2516
2517         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2518         for the Objective-C bindings.  If it is found that isHorizontal
2519         is not used, we should remove it again but also remove it's
2520         declaration from PublicDOMInterfaces.h
2521
2522         * dom/WheelEvent.h:
2523         (WebCore::WheelEvent::isHorizontal):
2524         * dom/WheelEvent.idl:
2525
2526 2006-09-20  David Hyatt  <hyatt@apple.com>
2527
2528         Fix for 10945, WheelEvent should support two dimensions at once, since
2529         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2530         to allow for diagonal scrolling.
2531
2532         Reviewed by Eric
2533
2534         * dom/EventTargetNode.cpp:
2535         (WebCore::EventTargetNode::dispatchWheelEvent):
2536         * dom/WheelEvent.cpp:
2537         (WebCore::WheelEvent::WheelEvent):
2538         (WebCore::WheelEvent::initWheelEvent):
2539         * dom/WheelEvent.h:
2540         (WebCore::WheelEvent::wheelDelta):
2541         (WebCore::WheelEvent::wheelDeltaX):
2542         (WebCore::WheelEvent::wheelDeltaY):
2543         * dom/WheelEvent.idl:
2544         * page/FrameView.cpp:
2545         (WebCore::FrameView::handleWheelEvent):
2546         * platform/PlatformWheelEvent.h:
2547         (WebCore::PlatformWheelEvent::deltaX):
2548         (WebCore::PlatformWheelEvent::deltaY):
2549         (WebCore::PlatformWheelEvent::normalize):
2550         * platform/mac/WheelEventMac.mm:
2551         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2552
2553 2006-09-19  Eric Seidel  <eric@eseidel.com>
2554
2555         Reviewed by hyatt.
2556
2557         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2558
2559         No tests were harmed in the making of this patch.
2560
2561         * WebCore.xcodeproj/project.pbxproj:
2562         * kcanvas/KCanvasClipper.cpp: Added.
2563         (WebCore::operator<<):
2564         * kcanvas/KCanvasClipper.h: Added.
2565         * kcanvas/KCanvasFilters.h:
2566         * kcanvas/KCanvasImage.h:
2567         * kcanvas/KCanvasMarker.cpp: Added.
2568         * kcanvas/KCanvasMarker.h: Added.
2569         * kcanvas/KCanvasMasker.cpp: Added.
2570         (WebCore::KCanvasMasker::KCanvasMasker):
2571         (WebCore::KCanvasMasker::setMask):
2572         (WebCore::KCanvasMasker::externalRepresentation):
2573         (WebCore::getMaskerById):
2574         * kcanvas/KCanvasMasker.h: Added.
2575         * kcanvas/KCanvasResource.cpp: Added.
2576         (WebCore::KCanvasResource::invalidate):
2577         (WebCore::KCanvasResource::externalRepresentation):
2578         (WebCore::getResourceById):
2579         (WebCore::getPaintServerById):
2580         * kcanvas/KCanvasResource.h: Added.
2581         * kcanvas/KCanvasResources.cpp: Removed.
2582         * kcanvas/KCanvasResources.h: Removed.
2583         * kcanvas/RenderPath.cpp:
2584         * kcanvas/RenderSVGContainer.cpp:
2585         * kcanvas/RenderSVGImage.cpp:
2586         * kcanvas/RenderSVGText.cpp:
2587         * kcanvas/device/KRenderingPaintServer.h:
2588         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2589         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2590         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2591         * ksvg2/svg/SVGClipPathElement.h:
2592         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2593         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2594         * ksvg2/svg/SVGFECompositeElement.cpp:
2595         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2596         * ksvg2/svg/SVGFELightElement.cpp:
2597         * ksvg2/svg/SVGFEOffsetElement.cpp:
2598         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2599         * ksvg2/svg/SVGFilterElement.cpp:
2600         * ksvg2/svg/SVGLinearGradientElement.cpp:
2601         * ksvg2/svg/SVGMarkerElement.h:
2602         * ksvg2/svg/SVGMaskElement.h:
2603
2604 2006-09-19  Brady Eidson <beidson@apple.com>
2605
2606         Reviewed by Sarge Decker
2607
2608         <rdar://problem/4739892> and <rdar://problem/4729797>
2609         - WebCore::IconDatabase needs to have and respect an enabled() flag
2610         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2611
2612         * bridge/mac/WebCoreIconDatabaseBridge.h:
2613         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2614         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2615         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2616         * loader/icon/IconDatabase.cpp:
2617         (WebCore::IconDatabase::IconDatabase):
2618         (WebCore::IconDatabase::open): Don't open if disabled
2619         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2620         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2621         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2622         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2623         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2624         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2625         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2626         (WebCore::IconDatabase::releaseIconURL):
2627         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2628         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2629         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2630         (WebCore::IconDatabase::setEnabled): Added
2631         * loader/icon/IconDatabase.h:
2632         (WebCore::IconDatabase::enabled): Added
2633         * page/Frame.cpp:
2634         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2635         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2636
2637 2006-09-20  David Hyatt  <hyatt@apple.com>
2638
2639         Massage mouse wheel handling so that it is more cross-platform.  Make
2640         all the work happen in handleWheelEvent on the FrameView.
2641
2642         Reviewed by bradee-oh
2643
2644         * bridge/mac/FrameMac.mm:
2645         (WebCore::FrameMac::wheelEvent):
2646         * page/FrameView.cpp:
2647         (WebCore::FrameView::handleWheelEvent):
2648         * platform/PlatformWheelEvent.h:
2649         (WebCore::PlatformWheelEvent::platformDelta):
2650         (WebCore::PlatformWheelEvent::delta):
2651         * platform/mac/WheelEventMac.mm:
2652         (WebCore::platformDeltaForEvent):
2653         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2654         * rendering/RenderLayer.cpp:
2655         (WebCore::RenderLayer::scroll):
2656         * rendering/RenderObject.cpp:
2657         (WebCore::RenderObject::scroll):
2658
2659 2006-09-19  Eric Seidel  <eric@eseidel.com>
2660
2661         Reviewed by adele.
2662
2663         Improve test output for filters with bounding-box relative sizes.
2664         http://bugs.webkit.org/show_bug.cgi?id=8585
2665
2666         Many test results updated.
2667
2668         * kcanvas/KCanvasFilters.cpp:
2669         (WebCore::KCanvasFilter::externalRepresentation):
2670
2671 2006-09-19  Eric Seidel  <eric@eseidel.com>
2672
2673         Reviewed by adele.
2674
2675         Markers should clip to their viewport.
2676         http://bugs.webkit.org/show_bug.cgi?id=5967
2677
2678         Test: svg/custom/marker-overflow-clip.svg
2679
2680         * kcanvas/KCanvasResources.cpp:
2681         (WebCore::KCanvasMarker::KCanvasMarker):
2682         (WebCore::KCanvasMarker::setMarker):
2683         (WebCore::KCanvasMarker::draw):
2684         * kcanvas/KCanvasResources.h:
2685         (WebCore::KCanvasMasker::mask):
2686         * ksvg2/svg/SVGMarkerElement.cpp:
2687         (WebCore::SVGMarkerElement::SVGMarkerElement):
2688         (WebCore::SVGMarkerElement::parseMappedAttribute):
2689         (WebCore::SVGMarkerElement::canvasResource):
2690         (WebCore::SVGMarkerElement::createRenderer):
2691
2692 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2693
2694         Reviewed by eseidel
2695
2696         Backing out my recent change.
2697
2698         * css/cssstyleselector.cpp:
2699         (WebCore::CSSStyleSelector::adjustRenderStyle):
2700
2701 2006-09-19  Brady Eidson  <beidson@apple.com>
2702
2703         Reviewed by Kevin McCullough
2704
2705         http://bugs.webkit.org/show_bug.cgi?id=10940
2706         Opening a PDF in a new tab/window creates a documentless-frame
2707         and we deref the document without checking its validity
2708
2709         * page/Frame.cpp:
2710         (WebCore::Frame::iconURL):
2711
2712 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2713
2714         Reviewed by harrison
2715
2716         <rdar://problem/4735272>
2717         Can not click into link in programmatically editable content
2718
2719         * css/cssstyleselector.cpp:
2720         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
2721         userModify to implement document wide editability.
2722
2723 2006-09-19  MorganL  <morlmor@yahoo.com>
2724
2725         Reviewed by Darin and landed by Brady
2726
2727         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
2728         Build broken when SVG is not enabled.
2729
2730         * dom/XMLTokenizer.cpp:
2731         (WebCore::XMLTokenizer::startElementNs):
2732
2733 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2734
2735         Reviewed by harrison
2736
2737         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
2738
2739         Pasting plain text results in a match style paste, and the insertion
2740         position is whitespace normal, which clobbers the whitespace:pre on
2741         tab spans.  Skip changes to the whitespace mode when computing a style
2742         change for tab spans or the text nodes inside tab spans.
2743
2744         * editing/ApplyStyleCommand.cpp:
2745         (WebCore::StyleChange::init): Don't change the whitespace mode inside
2746         tab spans.
2747
2748 2006-09-19  David Hyatt  <hyatt@apple.com>
2749
2750         Fix for bug 5298, shape=default not supported for image maps.  Implement
2751         support for it.
2752
2753         Reviewed by timo
2754
2755         * html/HTMLAreaElement.cpp:
2756         (WebCore::HTMLAreaElement::getRegion):
2757         * html/HTMLMapElement.cpp:
2758         (WebCore::HTMLMapElement::mapMouseEvent):
2759
2760 2006-09-19  Adam Roben  <aroben@apple.com>
2761
2762         Reviewed by Adele.
2763
2764         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
2765         "no file selected" placeholder text missing from file upload control
2766
2767         * WebCore.xcodeproj/project.pbxproj:
2768         * rendering/RenderFileUploadControl.cpp: Remove class
2769         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
2770         defaultWidthNumChars
2771         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
2772         RenderBlock constructor instead of RenderFlexibleBox,
2773         (WebCore::RenderFileUploadControl::setStyle): Remove references to
2774         m_fileBox.
2775         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
2776         instead of updateIconAndFileName() (which has been removed)
2777         (WebCore::RenderFileUploadControl::updateFromElement): Remove
2778         references to m_fileBox, don't call updateIconAndFilename()
2779         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
2780         without using m_fileBox
2781         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
2782         now-unnecessary display:box rule.
2783         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
2784         to paintingDisabled() now that Icon::paint() does it, and add code to
2785         paint the filename directly.
2786         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
2787         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
2788         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
2789         subclass of RenderBlock instead of RenderFlexibleBox, remove
2790         updateIconAndFilename() method, remove m_fileBox instance variable.
2791
2792 2006-09-19  Eric Seidel  <eric@eseidel.com>
2793
2794         Reviewed by hyatt.
2795
2796         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
2797         http://bugs.webkit.org/show_bug.cgi?id=10846
2798
2799         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
2800
2801         * dom/XMLTokenizer.cpp:
2802         (WebCore::XMLTokenizer::XMLTokenizer):
2803         (WebCore::XMLTokenizer::startElementNs):
2804         (WebCore::XMLTokenizer::endElementNs):
2805
2806 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2807
2808         Reviewed by eseidel.  Landed by eseidel.
2809
2810         Build fix only, no tests affected.
2811
2812         * platform/gdk/FontPlatformDataGdk.cpp:
2813         (WebCore::FontPlatformData::FontPlatformData):
2814         (WebCore::FontPlatformData::~FontPlatformData):
2815         * platform/gdk/FrameGdk.h:
2816         * platform/gdk/TemporaryLinkStubs.cpp:
2817         (FrameGdk::isLoadTypeReload):
2818         (FrameGdk::originalRequestURL):
2819         (IconDatabase::setIconURLForPageURL):
2820
2821 2006-09-19  David Hyatt  <hyatt@apple.com>
2822
2823         Refine the fix for 9805 to really get all the complex cases right.
2824
2825         Reviewed by Eric
2826
2827         * rendering/RenderBlock.cpp:
2828         (WebCore::RenderBlock::clearFloatsIfNeeded):
2829         (WebCore::RenderBlock::handleBottomOfBlock):
2830
2831 2006-09-18  David Hyatt  <hyatt@apple.com>
2832
2833         Fix for 9805, <hr> not positioned properly following a previous empty sibling
2834         that had clear:both set on it.  Update self-collapsing block clearance
2835         behavior to match what is specified in the latest draft of CSS2.1.
2836
2837         Reviewed by Eric
2838
2839         Added fast/block/margin-collapse/empty-clear-blocks.html
2840
2841         * rendering/RenderBlock.cpp:
2842         (WebCore::RenderBlock::clearFloatsIfNeeded):
2843         (WebCore::RenderBlock::handleBottomOfBlock):
2844
2845 2006-09-18  MorganL  <morlmor@yahoo.com>
2846
2847         Reviewed by Brady, landed by Brady
2848
2849         Send receivedResponse callback to ResourceLoaderClient when loading
2850         file URLs.
2851
2852         See http://bugs.webkit.org/show_bug.cgi?id=10845
2853
2854         * platform/win/ResourceLoaderWin.cpp:
2855         (WebCore::ResourceLoader::fileLoadTimer):
2856
2857 2006-09-18  Brady Eidson  <beidson@apple.com>
2858
2859         Reviewed by Anders
2860
2861         <rdar://problem/3028061> - WebKit never updates favicon
2862         The WebKit enforced expiration date for icons has worked for some time, but the
2863         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
2864         functionality.  This patch fixes that up, along with some other architectural improvements,
2865         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
2866
2867         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
2868         * bridge/mac/FrameMac.mm:
2869         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
2870         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
2871         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
2872         * dom/Document.h: Added m_iconURL
2873         (WebCore::Document::iconURL): Added
2874         (WebCore::Document::setIconURL): Ditto
2875         * html/HTMLLinkElement.cpp:
2876         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
2877         * page/Frame.cpp:
2878         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
2879         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
2880         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
2881         * page/FramePrivate.h: Nuked IconURL
2882         * platform/win/TemporaryLinkStubs.cpp:
2883         (FrameWin::isLoadTypeReload):
2884
2885 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2886
2887         Reviewed by Tim H.
2888
2889         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
2890           it is it turns out that AppKit uses it.
2891
2892         * bindings/objc/DOMPrivate.h:
2893         * bindings/objc/DOMRGBColor.mm:
2894         (-[DOMRGBColor _color]):
2895
2896 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2897
2898         Reviewed by Tim H.
2899
2900         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
2901         Yet Another Objective-C Bindings Patch
2902
2903         - Whitespace cleanup for IDLParser.pm
2904
2905         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
2906           and DOMAbstractView into their own files.
2907
2908         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
2909           it is not used and a public method is available now.
2910
2911         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
2912           as it not used.
2913
2914         - Auto-generate method isContentEditable for DOMNode.
2915
2916         - General cleanup of bindings code including removing unneeded #imports
2917           and whitespace cleanup
2918
2919         * WebCore.xcodeproj/project.pbxproj:
2920         * bindings/objc/DOM.mm:
2921         (addElementClass):
2922         (elementClass):
2923         (-[DOMNode _initWithNode:WebCore::]):
2924         (+[DOMNode _nodeWith:WebCore::]):
2925         (-[DOMNode WebCore::]):
2926         (-[DOMNode KJS::Bindings::]):
2927         (-[DOMNode addEventListener:::]):
2928         (-[DOMNode removeEventListener:::]):
2929         (-[DOMNode dispatchEvent:]):
2930         (-[DOMElement image]):
2931         (-[DOMElement _font]):
2932         (-[DOMElement _imageTIFFRepresentation]):
2933         (-[DOMElement _getURLAttribute:]):
2934         (-[DOMElement _NPObject]):
2935         (-[DOMElement isFocused]):
2936         (-[DOMRange dealloc]):
2937         (-[DOMRange finalize]):
2938         (-[DOMRange description]):
2939         (-[DOMRange startContainer]):
2940         (-[DOMRange startOffset]):
2941         (-[DOMRange endContainer]):
2942         (-[DOMRange endOffset]):
2943         (-[DOMRange collapsed]):
2944         (-[DOMRange commonAncestorContainer]):
2945         (-[DOMRange setStart::]):
2946         (-[DOMRange setEnd::]):
2947         (-[DOMRange setStartBefore:]):
2948         (-[DOMRange setStartAfter:]):
2949         (-[DOMRange setEndBefore:]):
2950         (-[DOMRange setEndAfter:]):
2951         (-[DOMRange collapse:]):
2952         (-[DOMRange selectNode:]):
2953         (-[DOMRange selectNodeContents:]):
2954         (-[DOMRange compareBoundaryPoints::]):
2955         (-[DOMRange deleteContents]):
2956         (-[DOMRange extractContents]):
2957         (-[DOMRange cloneContents]):
2958         (-[DOMRange insertNode:]):
2959         (-[DOMRange surroundContents:]):
2960         (-[DOMRange cloneRange]):
2961         (-[DOMRange toString]):
2962         (-[DOMRange detach]):
2963         (-[DOMRange _initWithRange:WebCore::]):
2964         (+[DOMRange _rangeWith:WebCore::]):
2965         (-[DOMRange WebCore::]):
2966         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2967         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2968         (-[DOMNodeFilter WebCore::]):
2969         (-[DOMNodeFilter dealloc]):
2970         (-[DOMNodeFilter finalize]):
2971         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2972         (-[DOMNodeIterator WebCore::]):
2973         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
2974         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2975         (-[DOMTreeWalker WebCore::]):
2976         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
2977         (ObjCNodeFilterCondition::acceptNode):
2978         (-[DOMDocument createNodeIterator::::]):
2979         (-[DOMDocument createTreeWalker::::]):
2980         (ObjCEventListener::find):
2981         (ObjCEventListener::create):
2982         (ObjCEventListener::handleEvent):
2983         * bindings/objc/DOMAbstractView.h: Added.
2984         * bindings/objc/DOMAbstractView.mm: Added.
2985         (-[DOMAbstractView document]):
2986         (-[DOMAbstractView WebCore::]):
2987         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2988         (+[DOMAbstractView _abstractViewWith:WebCore::]):
2989         * bindings/objc/DOMCSS.mm:
2990         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2991         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2992         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
2993         (-[DOMCSSRule _initWithRule:WebCore::]):
2994         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2995         (-[DOMCSSValue _initWithValue:WebCore::]):
2996         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2997         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
2998         (-[DOMDocument getComputedStyle::]):
2999         (-[DOMDocument getMatchedCSSRules::]):
3000         * bindings/objc/DOMCore.h:
3001         * bindings/objc/DOMEventException.h: Added.
3002         * bindings/objc/DOMEvents.h:
3003         * bindings/objc/DOMEvents.mm:
3004         * bindings/objc/DOMException.h: Added.
3005         * bindings/objc/DOMHTML.mm:
3006         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
3007         (viewForElement):
3008         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
3009         (-[DOMHTMLInputElement _selectedRange]):
3010         (-[DOMHTMLInputElement _setAutofilled:]):
3011         * bindings/objc/DOMInternal.h:
3012         * bindings/objc/DOMObject.h:
3013         * bindings/objc/DOMPrivate.h:
3014         * bindings/objc/DOMRange.h:
3015         * bindings/objc/DOMRangeException.h: Added.
3016         * bindings/objc/DOMViews.h:
3017         * bindings/objc/DOMViews.mm: Removed.
3018         * bindings/objc/DOMXPath.h:
3019         * bindings/objc/DOMXPathException.h: Added.
3020         * bindings/scripts/IDLParser.pm:
3021         * dom/Node.idl:
3022
3023 2006-09-18  Brady Eidson  <beidson@apple.com>
3024
3025         Windows build fix
3026
3027         * platform/win/TemporaryLinkStubs.cpp:
3028         (IconDatabase::setIconURLForPageURL):
3029
3030 2006-09-18  David Hyatt  <hyatt@apple.com>
3031
3032         Fix for bug 3969, hr width doesn't update when it clears a float.  This
3033         was also a problem with tables and overflow sections.
3034
3035         Reviewed by Eric
3036
3037         Added fast/block/float/width-update-after-clear.html
3038
3039         * rendering/RenderBlock.cpp:
3040         (WebCore::RenderBlock::collapseMargins):
3041         (WebCore::RenderBlock::clearFloatsIfNeeded):
3042
3043 2006-09-18  Brady Eidson  <beidson@apple.com>
3044
3045         Reviewed by John
3046
3047         http://bugs.webkit.org/show_bug.cgi?id=10907
3048         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
3049
3050         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
3051         * bridge/win/FrameWin.h: Added originalRequestURL()
3052         * loader/icon/IconLoader.cpp:
3053         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
3054         * page/Frame.cpp:
3055         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
3056         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
3057         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
3058         * page/Frame.h: Added pure virtual originalRequestURL()
3059         * platform/win/TemporaryLinkStubs.cpp:
3060         (FrameWin::originalRequestURL): Added
3061
3062 2006-09-18  Rob Buis  <buis@kde.org>
3063
3064         Reviewed by Maciej.
3065
3066         http://bugs.webkit.org/show_bug.cgi?id=10807
3067         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
3068
3069         Make sure the paint method is not exited without popping
3070         context and transparency layer.
3071
3072         WARNING: NO TEST CASES ADDED OR CHANGED
3073
3074         * kcanvas/RenderSVGImage.cpp:
3075         (WebCore::RenderSVGImage::paint):
3076
3077 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
3078
3079         Reviewed by Eric.
3080
3081         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
3082         REGRESSION: WebKit can't be built with SVG disabled
3083
3084         * bindings/scripts/CodeGeneratorObjC.pm:
3085         For each file generated add a #ifdef <something>_SUPPORT / #endif
3086         pair if the idl file has a Conditional extended attribute
3087
3088 2006-09-17  Eric Seidel  <eric@eseidel.com>
3089
3090         Reviewed by ap.
3091
3092         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
3093         http://bugs.webkit.org/show_bug.cgi?id=10813
3094
3095         * bridge/mac/WebCoreFrameBridge.mm:
3096         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
3097
3098 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3099
3100         Reviewed by Hyatt.
3101
3102         http://bugs.webkit.org/show_bug.cgi?id=10779
3103         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
3104
3105         No test possible.
3106
3107         * platform/Image.cpp:
3108         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
3109         maybe the rest just hasn't been loaded yet.
3110         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
3111         to start animating before we get at least two frames.
3112
3113 2006-09-17  Brady Eidson <beidson@apple.com>
3114
3115         Reviewed by Sarge
3116
3117         IconLoader now gracefully handles the condition where there's no document in the frame
3118         (ie. PDFs)
3119
3120         * loader/icon/IconLoader.cpp:
3121         (IconLoader::startLoading):
3122
3123 2006-09-17  David Hyatt  <hyatt@apple.com>
3124
3125         Fix for bug 10899, rework how CSS keywords work to be smarter about
3126         using the correct size when generic families change (e.g., monospace to
3127         serif and vice versa).
3128
3129         Reviewed by aroben
3130
3131         Added fast/text/basic/generic-family-changes.html
3132
3133         * css/cssstyleselector.cpp:
3134         (WebCore::CSSStyleSelector::applyProperty):
3135         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
3136         (WebCore::CSSStyleSelector::fontSizeForKeyword):
3137         * css/cssstyleselector.h:
3138         * dom/Document.cpp:
3139         (WebCore::Document::recalcStyle):
3140         * platform/FontDescription.h:
3141         (WebCore::FontDescription::FontDescription):
3142         (WebCore::FontDescription::keywordSize):
3143         (WebCore::FontDescription::setKeywordSize):
3144         (WebCore::FontDescription::operator==):
3145
3146 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3147
3148         Reviewed by Brady.
3149
3150         http://bugs.webkit.org/show_bug.cgi?id=10852
3151         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
3152
3153         Test: http/tests/xmlhttprequest/xhr-onunload.html
3154
3155         * xml/xmlhttprequest.cpp:
3156         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
3157
3158         * loader/icon/IconLoader.cpp:
3159         (IconLoader::startLoading): Fix a similar latent bug here.
3160
3161 2006-09-17  Adam Roben  <aroben@apple.com>
3162
3163         Build fix.
3164
3165         * loader/icon/IconDatabase.cpp:
3166
3167 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
3168
3169         Reviewed by Brady.
3170
3171         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
3172         Change the XSLT Parameter Map to use Strings instead of StringImpls.
3173         General cleanup.
3174
3175         * bindings/js/JSXSLTProcessor.cpp:
3176         (KJS::XSLTProcessorProtoFunc::callAsFunction):
3177         * bindings/js/kjs_events.cpp:
3178         (KJS::JSAbstractEventListener::handleEvent):
3179         * bindings/js/kjs_window.cpp:
3180         (KJS::ScheduledAction::execute):
3181         * css/MediaList.cpp:
3182         (WebCore::MediaList::setMediaText):
3183         * dom/Document.cpp:
3184         (WebCore::Document::processHttpEquiv):
3185         * editing/ApplyStyleCommand.cpp:
3186         (WebCore::StyleChange::init):
3187         * html/HTMLDocument.cpp:
3188         (WebCore::parseDocTypeDeclaration):
3189         * html/HTMLLinkElement.cpp:
3190         (WebCore::HTMLLinkElement::parseMappedAttribute):
3191         * html/HTMLObjectElement.cpp:
3192         (WebCore::HTMLObjectElement::HTMLObjectElement):
3193         (WebCore::HTMLObjectElement::parseMappedAttribute):
3194         (WebCore::HTMLObjectElement::attach):
3195         (WebCore::HTMLObjectElement::setComplete):
3196         (WebCore::HTMLObjectElement::detach):
3197         (WebCore::HTMLObjectElement::recalcStyle):
3198         (WebCore::HTMLObjectElement::childrenChanged):
3199         (WebCore::HTMLObjectElement::isImageType):
3200         * html/HTMLObjectElement.h:
3201         * html/HTMLOptionElement.cpp:
3202         (WebCore::HTMLOptionElement::value):
3203         * html/HTMLSelectElement.cpp:
3204         (WebCore::HTMLSelectElement::appendFormData):
3205         * html/HTMLTokenizer.cpp:
3206         (WebCore::HTMLTokenizer::parseTag):
3207         * ksvg2/svg/SVGColor.cpp:
3208         (WebCore::SVGColor::setRGBColor):
3209         * ksvg2/svg/SVGDescElement.cpp:
3210         (WebCore::SVGDescElement::description):
3211         * platform/PlatformString.h:
3212         * platform/String.cpp:
3213         (WebCore::String::stripWhiteSpace):
3214         (WebCore::String::simplifyWhiteSpace):
3215         * platform/StringImpl.cpp:
3216         (WebCore::isSpace):
3217         (WebCore::parseLength):
3218         (WebCore::StringImpl::stripWhiteSpace):
3219         (WebCore::StringImpl::simplifyWhiteSpace):
3220         (WebCore::StringImpl::toInt):
3221         * platform/StringImpl.h:
3222         * platform/mac/ClipboardMac.mm:
3223         (WebCore::cocoaTypeFromMIMEType):
3224         * rendering/RenderPartObject.cpp:
3225         (WebCore::RenderPartObject::updateWidget):
3226         * xml/XPathFunctions.cpp:
3227         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
3228         * xml/XPathGrammar.y:
3229         * xml/XPathStep.cpp:
3230         (WebCore::XPath::Step::nodeTestMatches):
3231         * xml/XSLStyleSheet.cpp:
3232         (WebCore::XSLStyleSheet::loadChildSheets):
3233         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
3234         * xml/XSLTProcessor.cpp:
3235         (WebCore::xsltParamArrayFromParameterMap):
3236         (WebCore::XSLTProcessor::setParameter):
3237         (WebCore::XSLTProcessor::getParameter):
3238         (WebCore::XSLTProcessor::removeParameter):
3239         * xml/XSLTProcessor.h:
3240         * xml/xmlhttprequest.cpp:
3241         (WebCore::XMLHttpRequest::getStatusText):
3242
3243 2006-09-17  David Hyatt  <hyatt@apple.com>
3244
3245         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
3246         are declared right before the fieldsets.  It turns out fieldsets in other
3247         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
3248         adding that behavior to fieldset fixes the bug.
3249
3250         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
3251         and fieldsets all subclass.
3252
3253         Reviewed by anders
3254
3255         Added fast/forms/float-before-fieldset.html
3256
3257         * rendering/RenderFieldset.h:
3258         (WebCore::RenderFieldset::avoidsFloats):
3259         * rendering/RenderFlexibleBox.h:
3260         (WebCore::RenderFlexibleBox::avoidsFloats):
3261         * rendering/RenderObject.cpp:
3262         (WebCore::RenderObject::avoidsFloats):
3263         * rendering/RenderObject.h:
3264         * rendering/RenderTable.h:
3265         (WebCore::RenderTable::avoidsFloats):
3266
3267 2006-09-17  David Hyatt  <hyatt@apple.com>
3268
3269         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
3270         "rules" attributes on tables.
3271
3272         Reviewed by bradee-oh
3273
3274         Well-covered by existing layout tests.
3275
3276         * html/HTMLTableCellElement.cpp:
3277         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
3278         * html/HTMLTableColElement.cpp:
3279         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
3280         * html/HTMLTableColElement.h:
3281         * html/HTMLTableElement.cpp:
3282         (WebCore::HTMLTableElement::HTMLTableElement):
3283         (WebCore::HTMLTableElement::~HTMLTableElement):
3284         (WebCore::HTMLTableElement::setCaption):
3285         (WebCore::HTMLTableElement::setTHead):
3286         (WebCore::HTMLTableElement::setTFoot):
3287         (WebCore::HTMLTableElement::setTBody):
3288         (WebCore::HTMLTableElement::createTHead):
3289         (WebCore::HTMLTableElement::deleteTHead):
3290         (WebCore::HTMLTableElement::createTFoot):
3291         (WebCore::HTMLTableElement::deleteTFoot):
3292         (WebCore::HTMLTableElement::createCaption):
3293         (WebCore::HTMLTableElement::deleteCaption):
3294         (WebCore::HTMLTableElement::insertRow):
3295         (WebCore::HTMLTableElement::deleteRow):
3296         (WebCore::HTMLTableElement::addChild):
3297         (WebCore::HTMLTableElement::childrenChanged):
3298         (WebCore::HTMLTableElement::mapToEntry):
3299         (WebCore::HTMLTableElement::parseMappedAttribute):
3300         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
3301         (WebCore::HTMLTableElement::getSharedCellDecl):
3302         (WebCore::HTMLTableElement::getSharedGroupDecl):
3303         (WebCore::HTMLTableElement::attach):
3304         * html/HTMLTableElement.h:
3305         (WebCore::HTMLTableElement::caption):
3306         (WebCore::HTMLTableElement::tHead):
3307         (WebCore::HTMLTableElement::tFoot):
3308         (WebCore::HTMLTableElement::):
3309         * html/HTMLTableRowElement.h:
3310         * html/HTMLTableSectionElement.cpp:
3311         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
3312         * html/HTMLTableSectionElement.h:
3313
3314 2006-09-17  David Hyatt  <hyatt@apple.com>
3315
3316         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
3317         specify their own new font-family list.  Make sure to always
3318         reset the generic family along with the family list when mapping in
3319         new font-family values.
3320
3321         Reviewed by bradee-oh
3322
3323         fast/text/basic/generic-family-reset.html
3324
3325         * css/cssstyleselector.cpp:
3326         (WebCore::CSSStyleSelector::applyProperty):
3327
3328 2006-09-16  Brady Eidson <beidson@apple.com>
3329
3330         Reviewed by Hyatt
3331
3332         Pruning code relating to WebKit's icon loader
3333
3334         * bridge/mac/WebCoreIconDatabaseBridge.h:
3335         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3336         * loader/icon/IconDatabase.h:
3337         * page/Frame.cpp:
3338         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
3339         its new home
3340
3341 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3342
3343         Reviewed by Tim H.
3344
3345         Patch for http://bugs.webkit.org/show_bug.cgi?id=10885
3346         Auto-generate DOMHTMLDocument for the Objective-C bindings
3347
3348         * DerivedSources.make:
3349         * WebCore.xcodeproj/project.pbxproj:
3350         * bindings/objc/DOMExtensions.h:
3351         * bindings/objc/DOMHTML.mm:
3352         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
3353         * bindings/objc/DOMHTMLDocument.h: Removed.
3354         * bindings/objc/DOMHTMLDocument.mm: Removed.
3355         * bindings/objc/PublicDOMInterfaces.h:
3356         * bindings/scripts/CodeGeneratorObjC.pm:
3357         * html/HTMLDocument.idl:
3358         * platform/DeprecatedString.h:
3359         (WebCore::DeprecatedString::operator NSString*):
3360
3361 2006-09-16  Rob Buis  <buis@kde.org>
3362
3363         Reviewed by Eric.
3364
3365         http://bugs.webkit.org/show_bug.cgi?id=10866
3366         Code in kcanvas/ should not use Private
3367
3368         Remove Private classes and tweak coding style.
3369
3370         WARNING: NO TEST CASES ADDED OR CHANGED
3371
3372         * kcanvas/RenderPath.cpp:
3373         (WebCore::RenderPath::RenderPath):
3374         (WebCore::RenderPath::~RenderPath):
3375         (WebCore::RenderPath::localTransform):
3376         (WebCore::RenderPath::setLocalTransform):
3377         (WebCore::RenderPath::fillContains):
3378         (WebCore::RenderPath::relativeBBox):
3379         (WebCore::RenderPath::setPath):
3380         (WebCore::RenderPath::path):
3381         (WebCore::RenderPath::layout):
3382         * kcanvas/RenderPath.h:
3383         * kcanvas/RenderSVGContainer.cpp:
3384         (WebCore::RenderSVGContainer::RenderSVGContainer):
3385         (WebCore::RenderSVGContainer::~RenderSVGContainer):
3386         (WebCore::RenderSVGContainer::drawsContents):
3387         (WebCore::RenderSVGContainer::setDrawsContents):
3388         (WebCore::RenderSVGContainer::localTransform):
3389         (WebCore::RenderSVGContainer::setLocalTransform):
3390         (WebCore::RenderSVGContainer::layout):
3391         (WebCore::RenderSVGContainer::paint):
3392         (WebCore::RenderSVGContainer::setViewport):
3393         (WebCore::RenderSVGContainer::viewport):
3394         (WebCore::RenderSVGContainer::setViewBox):
3395         (WebCore::RenderSVGContainer::viewBox):
3396         (WebCore::RenderSVGContainer::setAlign):
3397         (WebCore::RenderSVGContainer::align):
3398         (WebCore::RenderSVGContainer::fillContains):
3399         (WebCore::RenderSVGContainer::strokeContains):
3400         (WebCore::RenderSVGContainer::setSlice):
3401         (WebCore::RenderSVGContainer::slice):
3402         * kcanvas/RenderSVGContainer.h:
3403         * kcanvas/device/KRenderingFillPainter.cpp:
3404         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
3405         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
3406         (WebCore::KRenderingFillPainter::fillRule):
3407         (WebCore::KRenderingFillPainter::setFillRule):
3408         (WebCore::KRenderingFillPainter::opacity):
3409         (WebCore::KRenderingFillPainter::setOpacity):
3410         * kcanvas/device/KRenderingFillPainter.h:
3411         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3412         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
3413         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
3414         (WebCore::KRenderingPaintServerGradient::gradientStops):
3415         (WebCore::KRenderingPaintServerGradient::setGradientStops):
3416         (WebCore::KRenderingPaintServerGradient::spreadMethod):
3417         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
3418         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
3419         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
3420         (WebCore::KRenderingPaintServerGradient::gradientTransform):
3421         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
3422         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
3423         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
3424         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
3425         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
3426         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
3427         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
3428         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
3429         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
3430         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
3431         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
3432         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
3433         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
3434         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
3435         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
3436         (WebCore::KRenderingPaintServerGradient::listener):
3437         (WebCore::KRenderingPaintServerGradient::setListener):
3438         * kcanvas/device/KRenderingPaintServerGradient.h:
3439         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3440         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3441         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3442         (WebCore::KRenderingPaintServerPattern::setBbox):
3443         (WebCore::KRenderingPaintServerPattern::bbox):
3444         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
3445         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
3446         (WebCore::KRenderingPaintServerPattern::tile):
3447         (WebCore::KRenderingPaintServerPattern::setTile):
3448         (WebCore::KRenderingPaintServerPattern::patternTransform):
3449         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
3450         (WebCore::KRenderingPaintServerPattern::listener):
3451         (WebCore::KRenderingPaintServerPattern::setListener):
3452         * kcanvas/device/KRenderingPaintServerPattern.h:
3453         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3454         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
3455         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
3456         (WebCore::KRenderingPaintServerSolid::color):
3457         (WebCore::KRenderingPaintServerSolid::setColor):
3458         * kcanvas/device/KRenderingPaintServerSolid.h:
3459         * kcanvas/device/KRenderingStrokePainter.cpp:
3460         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
3461         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
3462         (WebCore::KRenderingStrokePainter::strokeWidth):
3463         (WebCore::KRenderingStrokePainter::setStrokeWidth):
3464         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3465         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3466         (WebCore::KRenderingStrokePainter::strokeCapStyle):
3467         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
3468         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
3469         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
3470         (WebCore::KRenderingStrokePainter::dashOffset):
3471         (WebCore::KRenderingStrokePainter::setDashOffset):
3472         (WebCore::KRenderingStrokePainter::dashArray):
3473         (WebCore::KRenderingStrokePainter::setDashArray):
3474         (WebCore::KRenderingStrokePainter::opacity):
3475         (WebCore::KRenderingStrokePainter::setOpacity):
3476         (WebCore::KRenderingStrokePainter::dirty):
3477         (WebCore::KRenderingStrokePainter::setDirty):
3478         * kcanvas/device/KRenderingStrokePainter.h:
3479
3480 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
3481
3482         Reviewed by Anders.
3483
3484         http://bugs.webkit.org/show_bug.cgi?id=10887
3485         Fix build error
3486
3487         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
3488
3489 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3490
3491         Reviewed by Anders.
3492
3493         Fix for http://bugs.webkit.org/show_bug.cgi?id=10886
3494         REGRESSION (r16387): Reproducible crash when mousing over HTML document
3495
3496         - Special case method [DOMNode ownerDocument] to call document() instead
3497           or ownerDocument() to return to the old behavior.
3498
3499         * WebCore.xcodeproj/project.pbxproj:
3500         * bindings/scripts/CodeGeneratorObjC.pm:
3501
3502 2006-09-15  Brady Eidson  <beidson@apple.com>
3503
3504         Reviewed by Tim Hatcher
3505
3506         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
3507         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
3508
3509         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
3510         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
3511         (WebCore::IconDatabase::open): Make sure the directory exists
3512
3513 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3514
3515         Reviewed by Brady.
3516
3517         Make new style ObjC methods public API.
3518
3519         * WebCore.xcodeproj/project.pbxproj:
3520         * bindings/objc/DOMPrivate.h:
3521         * bindings/objc/PublicDOMInterfaces.h:
3522
3523 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3524
3525         Reviewed by Tim H.
3526
3527         Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
3528         Auto-generate DOMNode for the Objective-C bindings
3529
3530         * DerivedSources.make:
3531         * WebCore.xcodeproj/project.pbxproj:
3532         * bindings/objc/DOM.mm:
3533         (-[DOMNode boundingBox]):
3534         (-[DOMNode lineBoxRects]):
3535         * bindings/objc/DOMEvents.h:
3536         * bindings/objc/DOMExtensions.h:
3537         * bindings/objc/DOMNode.h: Removed.
3538         * bindings/objc/DOMNode.mm: Removed.
3539         * bindings/objc/PublicDOMInterfaces.h:
3540         * bindings/scripts/CodeGeneratorObjC.pm:
3541         * dom/Node.idl:
3542
3543 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3544
3545         Reviewed by Justin.
3546
3547         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
3548
3549         * bridge/mac/WebCoreFrameBridge.h:
3550         * bridge/mac/WebCoreFrameBridge.mm:
3551         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
3552         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
3553         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
3554         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
3555         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
3556         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
3557         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3558         (-[WebCoreFrameBridge increaseSelectionListLevel]):
3559         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
3560         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
3561         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
3562         (-[WebCoreFrameBridge insertLineBreak]):
3563         (-[WebCoreFrameBridge insertParagraphSeparator]):
3564         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
3565         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
3566         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
3567         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
3568         (createMouseEventFromDraggingInfo):
3569         * editing/SelectionController.cpp:
3570         (WebCore::SelectionController::moveTo):
3571         (WebCore::SelectionController::setSelection):
3572         (WebCore::SelectionController::modify):
3573         (WebCore::SelectionController::setBase):
3574         (WebCore::SelectionController::setExtent):
3575         * editing/SelectionController.h:
3576         * page/Frame.cpp:
3577         (WebCore::Frame::revealSelection):
3578         (WebCore::Frame::revealCaret):
3579         * page/Frame.h:
3580
3581 2006-09-15  Brady Eidson  <beidson@apple.com>
3582
3583         Reviewed by Anders
3584
3585         Added the ability to get a mutable char* from a CString, which will copy the internal
3586         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
3587         referrer of that buffer.
3588
3589         * platform/CString.cpp:
3590         (WebCore::CString::mutableData):
3591         (WebCore::CString::copyBufferIfNeeded):
3592         * platform/CString.h:
3593
3594 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
3595
3596         Reviewed by harrison
3597
3598         <rdar://problem/4674869>
3599         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
3600
3601         * editing/SelectionController.cpp:
3602         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
3603         * editing/visible_units.cpp:
3604         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
3605         position before it, not after it.
3606
3607 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3608
3609         Reviewed by Adam.
3610
3611         http://bugs.webkit.org/show_bug.cgi?id=10864
3612         Bug 10864: Linux\GDK build fixes
3613
3614         * Projects/gdk/webcore-gdk.bkl:
3615         * WebCoreSources.bkl: