WebCore/ChangeLog

   1 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
   2
   3         Build fix.
   4
   5         * bridge/mac/FrameViewMac.mm: Add missing #imports.
   6
   7 2006-10-01  Dave Hyatt  <hyatt@apple.com>
   8
   9         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
  10
  11         Reviewed by mitz
  12
  13         * bridge/mac/FrameMac.mm:
  14         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
  15         * bridge/mac/FrameViewMac.mm:
  16         (WebCore::FrameView::passMousePressEventToScrollbar):
  17         * page/FrameView.cpp:
  18         (WebCore::FrameView::handleMousePressEvent):
  19         (WebCore::FrameView::setMousePressed):
  20         * page/FrameView.h:
  21         * platform/win/TemporaryLinkStubs.cpp:
  22         (FrameView::passMousePressEventToScrollbar):
  23
  24 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
  25
  26         Reviewed by Darin.
  27
  28         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
  29         Add more SVG Objective-C DOM bindings
  30
  31         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
  32           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
  33           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
  34           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
  35           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
  36           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
  37
  38         * DerivedSources.make:
  39         * WebCore.xcodeproj/project.pbxproj:
  40         * bindings/objc/DOMInternal.h:
  41         * bindings/objc/DOMSVG.h:
  42         * bindings/scripts/CodeGeneratorObjC.pm:
  43         * ksvg2/svg/SVGAElement.idl:
  44         * ksvg2/svg/SVGAnimateColorElement.idl:
  45         * ksvg2/svg/SVGAnimateElement.idl:
  46         * ksvg2/svg/SVGAnimateTransformElement.idl:
  47         * ksvg2/svg/SVGAnimatedPathData.idl:
  48         * ksvg2/svg/SVGAnimatedPoints.idl:
  49         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
  50         * ksvg2/svg/SVGAnimationElement.idl:
  51         * ksvg2/svg/SVGCircleElement.idl:
  52         * ksvg2/svg/SVGClipPathElement.idl:
  53         * ksvg2/svg/SVGColor.idl:
  54         * ksvg2/svg/SVGCursorElement.idl:
  55         * ksvg2/svg/SVGDefsElement.idl:
  56         * ksvg2/svg/SVGDescElement.idl:
  57         * ksvg2/svg/SVGDocument.idl:
  58         * ksvg2/svg/SVGEllipseElement.idl:
  59         * ksvg2/svg/SVGPointList.idl:
  60         * ksvg2/svg/SVGPreserveAspectRatio.idl:
  61         * ksvg2/svg/SVGRect.idl:
  62         * ksvg2/svg/SVGSVGElement.idl:
  63
  64 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
  65
  66         Reviewed by Adele.
  67
  68         - fix build
  69
  70         * platform/FloatRect.h:
  71         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
  72         but more appropriate for path-type stuff.
  73         * platform/cg/PathCG.cpp:
  74         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
  75
  76 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
  77
  78         Reviewed by Darin.
  79
  80         http://bugs.webkit.org/show_bug.cgi?id=11011
  81         External CSS is parsed as iso-8859-1 even though the main document is utf-8
  82
  83         Test: fast/encoding/css-charset-default.xhtml
  84
  85         * loader/CachedResourceClient.h:
  86         (WebCore::CachedResourceClient::setCSSStyleSheet):
  87         (WebCore::CachedResourceClient::setXSLStyleSheet):
  88         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
  89         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
  90
  91         * css/CSSImportRule.cpp:
  92         (WebCore::CSSImportRule::setCSSStyleSheet):
  93         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
  94         * css/CSSImportRule.h:
  95
  96         * css/CSSStyleSheet.cpp:
  97         (WebCore::CSSStyleSheet::CSSStyleSheet):
  98         * css/CSSStyleSheet.h:
  99         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
 100         member. Changed some String parameters to const String&.
 101
 102         * css/StyleSheet.cpp:
 103         (WebCore::StyleSheet::StyleSheet):
 104         * css/StyleSheet.h:
 105         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
 106
 107         * css/StyleSheetList.cpp:
 108         (WebCore::StyleSheetList::length):
 109         (WebCore::StyleSheetList::item):
 110         * css/StyleSheetList.h:
 111         Special-casing implicit stylesheets seemed to be dead code, removed.
 112
 113         * dom/Document.cpp:
 114         (WebCore::Document::setCSSStyleSheet):
 115         (WebCore::Document::recalcStyleSelector):
 116         * dom/Document.h:
 117         Renamed setStyleSheet() to setCSSStyleSheet().
 118
 119         * dom/ProcessingInstruction.cpp:
 120         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
 121         (WebCore::ProcessingInstruction::setCSSStyleSheet):
 122         (WebCore::ProcessingInstruction::setXSLStyleSheet):
 123         (WebCore::ProcessingInstruction::parseStyleSheet):
 124         * dom/ProcessingInstruction.h:
 125
 126         * html/HTMLLinkElement.cpp:
 127         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
 128         is not specified.
 129         (WebCore::HTMLLinkElement::setCSSStyleSheet):
 130         * html/HTMLLinkElement.h:
 131
 132         * html/HTMLStyleElement.cpp:
 133         (WebCore::HTMLStyleElement::childrenChanged):
 134         * ksvg2/svg/SVGStyleElement.cpp:
 135         (WebCore::SVGStyleElement::childrenChanged):
 136         Inherit URL and charset from the document.
 137
 138         * loader/Cache.cpp:
 139         (WebCore::Cache::requestCSSStyleSheet):
 140         * loader/Cache.h:
 141         Adjust for setStyleSheet() renaming.
 142
 143         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
 144         * loader/CachedCSSStyleSheet.cpp:
 145         (WebCore::CachedCSSStyleSheet::ref):
 146         (WebCore::CachedCSSStyleSheet::deref):
 147         (WebCore::CachedCSSStyleSheet::checkNotify):
 148         Pass the encoding to setCSSStyleSheet().
 149
 150         * loader/CachedXSLStyleSheet.cpp:
 151         (WebCore::CachedXSLStyleSheet::ref):
 152         (WebCore::CachedXSLStyleSheet::checkNotify):
 153         * loader/DocLoader.cpp:
 154         (WebCore::DocLoader::requestCSSStyleSheet):
 155         * loader/DocLoader.h:
 156         * page/Frame.cpp:
 157         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
 158         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
 159         * xml/XSLImportRule.cpp:
 160         (WebCore::XSLImportRule::setXSLStyleSheet):
 161         (WebCore::XSLImportRule::loadSheet):
 162         * xml/XSLImportRule.h:
 163         Adjust for setStyleSheet() renaming.
 164
 165 2006-09-30  Rob Buis  <buis@kde.org>
 166
 167         Reviewed by eseidel.
 168
 169         http://bugs.webkit.org/show_bug.cgi?id=11096
 170         Hit testing for polylines fails
 171
 172         Fix Path::contains so it handles filled, non-closed paths too.
 173
 174         * platform/cg/PathCG.cpp:
 175         (WebCore::Path::contains):
 176
 177 2006-09-30  Dave Hyatt  <hyatt@apple.com>
 178
 179         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
 180         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
 181         subframes while the mouse is down.
 182
 183         Reviewed by mitzpettel
 184
 185         * bridge/mac/FrameMac.h:
 186         * bridge/mac/FrameMac.mm:
 187         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
 188         (WebCore::FrameMac::passWheelEventToWidget):
 189         * bridge/mac/FrameViewMac.mm:
 190         (WebCore::FrameView::passMousePressEventToSubframe):
 191         (WebCore::FrameView::passMouseMoveEventToSubframe):
 192         (WebCore::FrameView::passMouseReleaseEventToSubframe):
 193         (WebCore::FrameView::passWheelEventToSubframe):
 194         * page/Frame.cpp:
 195         * page/Frame.h:
 196         * page/FrameView.cpp:
 197         (WebCore::subframeForTargetNode):
 198         (WebCore::FrameView::handleMousePressEvent):
 199         (WebCore::FrameView::handleMouseDoubleClickEvent):
 200         (WebCore::FrameView::handleMouseMoveEvent):
 201         (WebCore::FrameView::handleMouseReleaseEvent):
 202         (WebCore::FrameView::handleWheelEvent):
 203         * page/FrameView.h:
 204         * platform/ScrollBar.h:
 205         (WebCore::ScrollBar::handleMouseMoveEvent):
 206         (WebCore::ScrollBar::handleMouseOutEvent):
 207         * platform/Widget.h:
 208         (WebCore::Widget::handleMouseMoveEvent):
 209         (WebCore::Widget::handleMouseReleaseEvent):
 210         * platform/win/TemporaryLinkStubs.cpp:
 211         (FrameView::passMousePressEventToSubframe):
 212         (FrameView::passMouseMoveEventToSubframe):
 213         (FrameView::passMouseReleaseEventToSubframe):
 214         (FrameView::passWheelEventToSubframe):
 215         (Widget::capturingMouse):
 216         (Widget::setCapturingMouse):
 217         (Widget::capturingTarget):
 218         (Widget::capturingChild):
 219         (Widget::setCapturingChild):
 220         * rendering/RenderView.cpp:
 221         (WebCore::RenderView::paintBoxDecorations):
 222
 223 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
 224
 225         Reviewed by Adele.
 226
 227         Fixes windows bustage:
 228         http://bugs.webkit.org/show_bug.cgi?id=11093
 229
 230         * platform/win/PlatformScrollBar.h:
 231         * platform/win/TemporaryLinkStubs.cpp:
 232         (PlatformScrollBar::PlatformScrollBar):
 233         (ScrollBar::ScrollBar):
 234
 235 2006-09-29  David Hyatt  <hyatt@apple.com>
 236
 237         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
 238         in RenderObject::NodeInfo (and then propagating that Widget to
 239         MouseEventWithHitTestResults).
 240
 241         This allows RenderListBox and RenderBlock to do the same thing when the
 242         mouse is over the scrollbar.
 243
 244         Also land fix to support font-size: 0.
 245
 246         Reviewed by mjs (scrollbar), eric (font-size)
 247
 248         * dom/Document.cpp:
 249         (WebCore::Document::prepareMouseEvent):
 250         * page/Frame.cpp:
 251         (WebCore::Frame::passWidgetMouseDownEventToWidget):
 252         * page/FrameView.cpp:
 253         (WebCore::selectCursor):
 254         (WebCore::FrameView::handleMouseMoveEvent):
 255         (WebCore::FrameView::dispatchMouseEvent):
 256         * page/MouseEventWithHitTestResults.cpp:
 257         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
 258         * page/MouseEventWithHitTestResults.h:
 259         (WebCore::MouseEventWithHitTestResults::scrollbar):
 260         * rendering/RenderBlock.cpp:
 261         (WebCore::RenderBlock::isPointInScrollbar):
 262         (WebCore::RenderBlock::nodeAtPoint):
 263         * rendering/RenderBlock.h:
 264         * rendering/RenderLayer.cpp:
 265         (WebCore::RenderLayer::hitTest):
 266         * rendering/RenderLayer.h:
 267         (WebCore::RenderLayer::getHiddenBehavior):
 268         * rendering/RenderListBox.cpp:
 269         (WebCore::RenderListBox::RenderListBox):
 270         (WebCore::RenderListBox::~RenderListBox):
 271         (WebCore::RenderListBox::isPointInScrollbar):
 272         * rendering/RenderListBox.h:
 273         * rendering/RenderObject.h:
 274         (WebCore::RenderObject::NodeInfo::NodeInfo):
 275         (WebCore::RenderObject::NodeInfo::scrollbar):
 276         (WebCore::RenderObject::NodeInfo::setScrollbar):
 277
 278 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
 279
 280         Reviewed by Adele.
 281
 282         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
 283
 284         * platform/win/ScrollViewWin.cpp:
 285         (WebCore::ScrollView::convertToContainingWindow):
 286         (WebCore::ScrollView::convertFromContainingWindow):
 287         * platform/win/WidgetWin.cpp:
 288         (WebCore::Widget::convertToContainingWindow):
 289         (WebCore::Widget::convertFromContainingWindow):
 290
 291 2006-09-29  Adele Peterson  <adele@apple.com>
 292
 293         Updated with new argument for PlatformScrollBar.
 294
 295         * platform/win/TemporaryLinkStubs.cpp:
 296         (PlatformScrollBar::PlatformScrollBar):
 297
 298 2006-09-29  Adele Peterson  <adele@apple.com>
 299
 300         Reviewed by Hyatt.
 301
 302         Fixing build bustage with cast to int.
 303
 304         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
 305
 306 2006-09-29  Adele Peterson  <adele@apple.com>
 307
 308         Fixing accidental include.
 309
 310         * rendering/RenderListBox.cpp:
 311
 312 2006-09-29  Adele Peterson  <adele@apple.com>
 313
 314         Adding RenderListBox files.
 315
 316         * WebCore.vcproj/WebCore/WebCore.vcproj:
 317
 318 2006-09-29  Adele Peterson  <adele@apple.com>
 319
 320         Reviewed by Adam.
 321
 322         Initial implementation of engine-based list box control.
 323
 324         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
 325
 326         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
 327         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
 328         (WebCore::FrameMac::FrameMac):
 329         (WebCore::FrameMac::handleMousePressEvent):
 330         (WebCore::FrameMac::handleMouseMoveEvent):
 331         (WebCore::FrameMac::mouseDown):
 332
 333         * page/Frame.cpp:
 334         (WebCore::Frame::handleMouseMoveEvent):
 335         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
 336         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
 337         (WebCore::Frame::autoscrollTimerFired): ditto.
 338         (WebCore::Frame::stopAutoscrollTimer): ditto.
 339         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
 340         * page/Frame.h:
 341         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
 342
 343         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
 344         (WebCore::FrameViewPrivate::reset):
 345         (WebCore::FrameView::currentMousePosition):
 346         (WebCore::FrameView::handleMousePressEvent):
 347         (WebCore::FrameView::handleMouseDoubleClickEvent):
 348         (WebCore::selectCursor):
 349         (WebCore::FrameView::handleMouseMoveEvent):
 350         (WebCore::FrameView::handleMouseReleaseEvent):
 351         * page/FrameView.h:
 352
 353         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
 354         * platform/ScrollBar.h:
 355         (WebCore::):
 356         (WebCore::ScrollBar::controlSize):
 357         * platform/mac/PlatformScrollBar.h:
 358         * platform/mac/PlatformScrollBarMac.mm:
 359         (NSControlSizeForScrollBarControlSize):
 360         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
 361         (WebCore::PlatformScrollBar::PlatformScrollBar):
 362
 363         * rendering/RenderBlock.h:
 364         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
 365         * rendering/RenderLayer.h:
 366         * rendering/RenderObject.cpp:
 367         (WebCore::RenderObject::shouldAutoscroll):
 368         (WebCore::RenderObject::autoscroll):
 369         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
 370
 371         * css/html4.css: Added properties for new list boxes.
 372
 373         * html/HTMLOptionElement.cpp:
 374         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
 375         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
 376         * html/HTMLOptionElement.h: Added disabled method.
 377
 378         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
 379         (WebCore::HTMLSelectElement::recalcStyle):
 380         (WebCore::HTMLSelectElement::lastSelectedListIndex):
 381         (WebCore::HTMLSelectElement::deselectItems):
 382         (WebCore::HTMLSelectElement::setSelectedIndex):
 383         (WebCore::HTMLSelectElement::isKeyboardFocusable):
 384         (WebCore::HTMLSelectElement::isMouseFocusable):
 385         (WebCore::HTMLSelectElement::createRenderer):
 386         (WebCore::HTMLSelectElement::recalcListItems):
 387         (WebCore::HTMLSelectElement::setRecalcListItems):
 388         (WebCore::HTMLSelectElement::reset):
 389         (WebCore::HTMLSelectElement::notifyOptionSelected):
 390         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
 391         (WebCore::HTMLSelectElement::nextSelectableListIndex):
 392         (WebCore::HTMLSelectElement::previousSelectableListIndex):
 393         * html/HTMLSelectElement.h:
 394
 395         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
 396         (WebCore::RenderTheme::paint):
 397         (WebCore::RenderTheme::paintBorderOnly):
 398         (WebCore::RenderTheme::paintDecorations):
 399         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
 400         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
 401         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
 402         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
 403         (WebCore::RenderTheme::isControlStyled):
 404         (WebCore::RenderTheme::supportsFocusRing):
 405         * rendering/RenderTheme.h:
 406         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
 407
 408         * rendering/RenderListBox.cpp: Added.
 409         (WebCore::RenderListBox::RenderListBox):
 410         (WebCore::RenderListBox::~RenderListBox):
 411         (WebCore::RenderListBox::setStyle):
 412         (WebCore::RenderListBox::updateFromElement):
 413         (WebCore::RenderListBox::calcMinMaxWidth):
 414         (WebCore::RenderListBox::size):
 415         (WebCore::RenderListBox::numItems):
 416         (WebCore::RenderListBox::calcHeight):
 417         (WebCore::RenderListBox::baselinePosition):
 418         (WebCore::RenderListBox::itemBoundingBoxRect):
 419         (WebCore::RenderListBox::paintObject):
 420         (WebCore::RenderListBox::paintScrollbar):
 421         (WebCore::RenderListBox::paintItemForeground):
 422         (WebCore::RenderListBox::paintItemBackground):
 423         (WebCore::RenderListBox::scrollBarTarget):
 424         (WebCore::RenderListBox::isPointInScrollbar):
 425         (WebCore::RenderListBox::optionAtPoint):
 426         (WebCore::RenderListBox::autoscroll):
 427         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
 428         (WebCore::RenderListBox::scroll):
 429         (WebCore::RenderListBox::valueChanged):
 430         * rendering/RenderListBox.h: Added.
 431         (WebCore::RenderListBox::isListBox):
 432         (WebCore::RenderListBox::selectionChanged):
 433         (WebCore::RenderListBox::setSelectionChanged):
 434         (WebCore::RenderListBox::canHaveChildren):
 435         (WebCore::RenderListBox::renderName):
 436         (WebCore::RenderListBox::setOptionsChanged):
 437         (WebCore::RenderListBox::shouldAutoscroll):
 438         (WebCore::RenderListBox::listIndexIsVisible):
 439
 440 2006-09-29  Beth Dakin  <bdakin@apple.com>
 441
 442         Reviewed by Darin.
 443
 444         We had a bug where html4.css was ignoring Media Queries. In the end
 445         the problem was that we were trying to send a char* to the
 446         MediaQueryEvaluator constructor that expects a String, but the
 447         char* got interpreted as a bool, the wrong constructor was called,
 448         and the media type was never set.
 449
 450         No test case possible since this only affects html4.css
 451
 452         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
 453         char*
 454         (WebCore::MediaQueryEvaluator):
 455         * css/MediaQueryEvaluator.h: Same.
 456
 457 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
 458
 459         Reviewed by John, Maciej.
 460
 461         Integrated some frame and iframe code. I'm trying to fix up frame ownership
 462         and loading. Reducing the number of different code paths involved
 463         seemed like a good first step.
 464
 465         As a side effect, I fixed a bug where FRAME elements would report their
 466         src attributes as relative, rather than compelete, URLs. (IFRAME elements
 467         had the correct complete URL behavior.)
 468
 469         * html/HTMLFrameElement.cpp:
 470         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
 471         (WebCore::HTMLFrameElement::openURL):
 472             (1) Removed checks that requestFrame does for us
 473             (2) Added isURLAllowed check, to have one clear bottleneck for it
 474             (3) Added viewsource check, to have one clear bottleneck for it
 475         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
 476         method, instead of finding our content frame in our own unique way.
 477         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
 478         since openURL does this for us now.
 479         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
 480         This is what FF does, and it made no sense to have different behaviors
 481         for FRAME and IFRAME elements.
 482         * html/HTMLIFrameElement.cpp:
 483         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
 484         code.
 485         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
 486         HTMLFrameElement now does everything we need.
 487
 488 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
 489
 490         Reviewed by Hyatt.
 491
 492         Fix Qt/Linux build.
 493
 494         * CMakeLists.txt:
 495         * platform/qt/ScrollViewQt.cpp:
 496         (WebCore::ScrollView::convertToContainingWindow):
 497         (WebCore::ScrollView::convertFromContainingWindow):
 498         * platform/qt/TemporaryLinkStubs.cpp:
 499         (WebCore::signedPublicKeyAndChallengeString):
 500         * platform/qt/WidgetQt.cpp:
 501         (WebCore::Widget::convertToContainingWindow):
 502         (WebCore::Widget::convertFromContainingWindow):
 503
 504 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
 505
 506         Reviewed by Tim H.
 507
 508         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
 509         Simplify Internal methods for the auto-generated Objective-C DOM code
 510
 511         - Auto-generate the internal methods for more Objective-C classes.
 512
 513         * WebCore.xcodeproj/project.pbxproj:
 514         * bindings/objc/DOM.mm:
 515         * bindings/objc/DOMCSS.mm:
 516         (-[DOMStyleSheet WebCore::]):
 517         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
 518         (-[DOMCSSRule WebCore::]):
 519         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
 520         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
 521         (-[DOMCSSValue WebCore::]):
 522         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
 523         (+[DOMCSSValue _CSSValueWith:WebCore::]):
 524         * bindings/objc/DOMHTMLAppletElement.mm:
 525         (-[DOMHTMLAppletElement WebCore::]):
 526         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
 527         * bindings/objc/DOMHTMLEmbedElement.mm:
 528         (-[DOMHTMLEmbedElement WebCore::]):
 529         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
 530         * bindings/objc/DOMInternal.h:
 531         * bindings/objc/DOMInternal.mm:
 532         * bindings/scripts/CodeGeneratorObjC.pm:
 533         * css/CSSCharsetRule.idl:
 534         * css/CSSFontFaceRule.idl:
 535         * css/CSSImportRule.idl:
 536         * css/CSSMediaRule.idl:
 537         * css/CSSPageRule.idl:
 538         * css/CSSPrimitiveValue.idl:
 539         * css/CSSStyleRule.idl:
 540         * css/CSSStyleSheet.idl:
 541         * css/CSSUnknownRule.idl:
 542         * css/CSSValueList.idl:
 543         * dom/KeyboardEvent.idl:
 544         * dom/MouseEvent.idl:
 545         * dom/MutationEvent.idl:
 546         * dom/NodeIterator.idl:
 547         * dom/OverflowEvent.idl:
 548         * dom/UIEvent.idl:
 549         * dom/WheelEvent.idl:
 550
 551 2006-09-29  David Harrison  <harrison@apple.com>
 552
 553         Reviewed by John Sullivan.
 554
 555         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
 556         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
 557
 558         Test added
 559         * fast/text/attributed-substring-from-range-001.html
 560
 561         * bridge/mac/FrameMac.mm:
 562         (WebCore::FrameMac::attributedString):
 563         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
 564         Also, add validation of the range.
 565
 566 2006-09-29  Rob Buis  <buis@kde.org>
 567
 568         Reviewed by Maciej.
 569
 570         http://bugs.webkit.org/show_bug.cgi?id=10893
 571         InsertRule can not handle @import statements
 572
 573         Allow @import as part of a css rule.
 574
 575         * css/CSSGrammar.y:
 576
 577 2006-09-28  David Hyatt  <hyatt@apple.com>
 578
 579         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
 580
 581         * bridge/mac/FrameMac.mm:
 582         (WebCore::FrameMac::eventMayStartDrag):
 583         (WebCore::FrameMac::dragHysteresisExceeded):
 584         (WebCore::FrameMac::mouseDown):
 585         (WebCore::FrameMac::shouldDragAutoNode):
 586         (WebCore::FrameMac::sendContextMenuEvent):
 587         * bridge/mac/WebCoreFrameBridge.mm:
 588         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
 589
 590 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 591
 592         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
 593         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
 594         view.
 595
 596         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
 597         the patch after review, once I realized that these new functions essentially do the same thing.)
 598
 599         * dom/EventTargetNode.cpp:
 600         (WebCore::EventTargetNode::dispatchMouseEvent):
 601         (WebCore::EventTargetNode::dispatchWheelEvent):
 602         * page/Frame.cpp:
 603         (WebCore::Frame::selectClosestWordFromMouseEvent):
 604         (WebCore::Frame::handleMousePressEventTripleClick):
 605         (WebCore::Frame::handleMousePressEventSingleClick):
 606         (WebCore::Frame::handleMouseMoveEvent):
 607         (WebCore::Frame::handleMouseReleaseEvent):
 608         * page/FrameView.cpp:
 609         (WebCore::FrameView::handleMousePressEvent):
 610         (WebCore::selectCursor):
 611         (WebCore::FrameView::dispatchDragEvent):
 612         (WebCore::FrameView::prepareMouseEvent):
 613         (WebCore::FrameView::handleWheelEvent):
 614         * platform/ScrollView.h:
 615         * platform/Widget.cpp:
 616         (WebCore::Widget::convertToContainingWindow):
 617         * platform/Widget.h:
 618         * platform/mac/ScrollViewMac.mm:
 619         (WebCore::ScrollView::convertToContainingWindow):
 620         (WebCore::ScrollView::convertFromContainingWindow):
 621         * platform/mac/WidgetMac.mm:
 622         (WebCore::Widget::convertToContainingWindow):
 623         (WebCore::Widget::convertFromContainingWindow):
 624         * platform/win/ScrollViewWin.cpp:
 625         (WebCore::ScrollView::convertToContainingWindow):
 626         (WebCore::ScrollView::convertFromContainingWindow):
 627         * rendering/RenderLayer.cpp:
 628         (WebCore::RenderLayer::resize):
 629
 630 2006-09-28  Alice Liu  <alice.liu@apple.com>
 631
 632         Build fix by adding missing files for CommandByName
 633
 634         * WebCore.xcodeproj/project.pbxproj:
 635
 636 2006-09-28  Alice Liu  <alice.liu@apple.com>
 637
 638         Adding CommandByName files to the vcproj
 639
 640         * WebCore.vcproj/WebCore/WebCore.vcproj:
 641
 642 2006-09-28  Alice Liu  <alice.liu@apple.com>
 643
 644         Reviewed by Adam Roben.
 645
 646         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
 647         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
 648         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
 649
 650         * editing/CommandByName.cpp: Added.
 651         Added a command class that hangs off the frame so the frame can call commands more easily.
 652         (WebCore::Frame::commandImp):
 653         (WebCore::Frame::execCopy):
 654         (WebCore::Frame::execCut):
 655         (WebCore::Frame::execDelete):
 656         (WebCore::Frame::execForwardDelete):
 657         (WebCore::Frame::execPaste):
 658         (WebCore::Frame::execMoveLeft):
 659         (WebCore::Frame::execMoveRight):
 660         (WebCore::Frame::execMoveUp):
 661         (WebCore::Frame::execMoveDown):
 662         (WebCore::Frame::execSelectAll):
 663         (WebCore::Frame::execSelectLeft):
 664         (WebCore::Frame::execSelectRight):
 665         (WebCore::Frame::execSelectUp):
 666         (WebCore::Frame::execSelectDown):
 667         (WebCore::Frame::enabled):
 668         (WebCore::Frame::enabledAnySelection):
 669         (WebCore::Frame::enabledAnyEditableSelection):
 670         (WebCore::Frame::enabledPaste):
 671         (WebCore::Frame::enabledAnyRangeSelection):
 672         (WebCore::Frame::enabledAnyEditableRangeSelection):
 673         (WebCore::Frame::createCommandDictionary):
 674         (WebCore::Frame::Command::):
 675         (WebCore:::m_frame):
 676         (WebCore::CommandByName::execCommand):
 677         * editing/CommandByName.h: Added.
 678         * page/Frame.cpp:
 679         Added implementation of accessor for CommandByName member
 680         (WebCore::Frame::command):
 681         * page/Frame.h:
 682         Added accessor for CommandByName member
 683         * page/FramePrivate.h:
 684         Added a CommandByName member
 685         (WebCore::FramePrivate::FramePrivate):
 686         * platform/PlatformMouseEvent.h:
 687         Changed constructor prototype
 688         * platform/StringImpl.cpp:
 689         Exposing getWordBreakIterator to be used elsewhere
 690         (WebCore::getWordBreakIterator):
 691         * platform/StringImpl.h:
 692         Exposing getWordBreakIterator to be used elsewhere
 693         * platform/win/MouseEventWin.cpp:
 694         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
 695         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
 696
 697 2006-09-28  Adam Roben  <aroben@apple.com>
 698
 699         Reviewed by Adele.
 700
 701         Remove no-longer-used PopUpButton.
 702
 703         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
 704         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
 705         PopUpButtonMac.mm
 706         * platform/PopUpButton.h: Removed.
 707         * platform/mac/PopUpButtonMac.mm: Removed.
 708         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
 709         * rendering/DeprecatedRenderSelect.cpp: Change #include of
 710         PopUpButton.h to ListBox.h
 711
 712 2006-09-28  Darin Adler  <darin@apple.com>
 713
 714         Reviewed by Alice.
 715
 716         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
 717           10% perf. regression (copying strings while decoding)
 718
 719         Use Vector<UChar> instead of String when building up the decoded string in
 720         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
 721         String grows the buffer every single time that append is called. Using
 722         Vector::append instead of String::append also avoids constructing a string
 723         each time just to append and a questionable copy that is done inside the
 724         String::append function which also contributed to the slowness.
 725
 726         * platform/PlatformString.h:
 727         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
 728         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
 729         allocation.
 730         * platform/StringImpl.h:
 731         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
 732
 733         * platform/StreamingTextDecoder.h:
 734         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
 735         Change to use a Vector<UChar> instead of a String, since vectors have better
 736         resizing performance (they store a separate capacity).
 737
 738         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
 739         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
 740         Change to use Vector<UChar> instead of String and then create a string at
 741         the end of the process using the new adopt function.
 742
 743 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
 744
 745         Reviewed by Tim H.
 746
 747         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
 748         Auto-generate more SVG Objective-C bindings
 749
 750         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
 751           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
 752           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
 753           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
 754           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
 755           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
 756           and DOMSVGTransformable.
 757
 758         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
 759           parent interfaces and the SVG animated classes.
 760
 761         - Corrects CodeGenerator.pm to only skip the first parent for the main
 762           interface.
 763
 764         * DerivedSources.make:
 765         * WebCore.xcodeproj/project.pbxproj:
 766         * bindings/objc/DOMInternal.h:
 767         * bindings/objc/DOMSVG.h:
 768         * bindings/scripts/CodeGenerator.pm:
 769         * bindings/scripts/CodeGeneratorObjC.pm:
 770         * ksvg2/svg/SVGAnimatedAngle.idl:
 771         * ksvg2/svg/SVGAnimatedBoolean.idl:
 772         * ksvg2/svg/SVGAnimatedEnumeration.idl:
 773         * ksvg2/svg/SVGAnimatedInteger.idl:
 774         * ksvg2/svg/SVGAnimatedLength.idl:
 775         * ksvg2/svg/SVGAnimatedLengthList.idl:
 776         * ksvg2/svg/SVGAnimatedNumber.idl:
 777         * ksvg2/svg/SVGAnimatedPathData.idl:
 778         * ksvg2/svg/SVGAnimatedString.idl:
 779         * ksvg2/svg/SVGAnimatedTransformList.idl:
 780         * ksvg2/svg/SVGExternalResourcesRequired.idl:
 781         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
 782         * ksvg2/svg/SVGFitToViewBox.idl:
 783         * ksvg2/svg/SVGLangSpace.idl:
 784         * ksvg2/svg/SVGLocatable.idl:
 785         * ksvg2/svg/SVGMetadataElement.idl:
 786         * ksvg2/svg/SVGStringList.idl:
 787         * ksvg2/svg/SVGStylable.idl:
 788         * ksvg2/svg/SVGStyleElement.idl:
 789         * ksvg2/svg/SVGTests.idl:
 790         * ksvg2/svg/SVGTransformable.idl:
 791         * ksvg2/svg/SVGURIReference.idl:
 792         * ksvg2/svg/SVGUnitTypes.idl:
 793         * ksvg2/svg/SVGZoomAndPan.idl:
 794
 795 2006-09-28  Brady Eidson  <beidson@apple.com>
 796
 797         Reviewed by Mitz Pettel!!!
 798
 799         Change the error code check for common functions from SQLResultOk to SQLResultDone
 800
 801         * loader/icon/IconDatabase.cpp:
 802         (WebCore::IconDatabase::forgetPageURLQuery):
 803         (WebCore::IconDatabase::setIconIDForPageURLQuery):
 804         (WebCore::IconDatabase::addIconForIconURLQuery):
 805
 806 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 807
 808         Just eliminate MapWindowPoints usage and use the HWND as
 809         the viewport.
 810
 811         * platform/win/MouseEventWin.cpp:
 812         (WebCore::positionForEvent):
 813         * platform/win/ScrollViewWin.cpp:
 814         (WebCore::ScrollView::viewportToContents):
 815         (WebCore::ScrollView::contentsToViewport):
 816
 817 2006-09-27  David Hyatt  <hyatt@apple.com>
 818
 819         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
 820         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
 821         scrollbars to provide hover feedback if needed.
 822
 823         Reviewed by Eric
 824
 825         * page/FrameView.cpp:
 826         (WebCore::selectCursor):
 827         (WebCore::FrameView::handleMouseMoveEvent):
 828         * platform/ScrollBar.h:
 829         (WebCore::ScrollBar::mouseMoved):
 830
 831 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
 832
 833         Reviewed by Maciej and Adam, landed by Adam
 834
 835         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
 836         Windows build is busted
 837
 838         * platform/win/TemporaryLinkStubs.cpp:
 839         (ScrollView::paint):
 840         (ScrollView::themeChanged):
 841
 842 2006-09-27  Eric Seidel  <eric@eseidel.com>
 843
 844         Reviewed by mitz.
 845
 846         paths with no fill specified default to black but do not recieve paint-related mouse events
 847         http://bugs.webkit.org/show_bug.cgi?id=11069
 848         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
 849
 850         Test: svg/custom/hover-default-fill.svg
 851
 852         * kcanvas/RenderPath.cpp:
 853         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
 854         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
 855         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 856         (WebCore::KSVGPainterFactory::isFilled): remove null check
 857         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
 858         (WebCore::KSVGPainterFactory::isStroked): remove null check
 859         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
 860         * ksvg2/svg/SVGPaint.cpp:
 861         (WebCore::SVGPaint::defaultFill): added.
 862         (WebCore::SVGPaint::defaultStroke): added.
 863         * ksvg2/svg/SVGPaint.h:
 864
 865 2006-09-27  Rob Buis  <buis@kde.org>
 866
 867         Reviewed by eseidel.
 868
 869         http://bugs.webkit.org/show_bug.cgi?id=11015
 870         SVG handles em units incorrectly
 871
 872         Calculate viewport coordinates at layout time, since
 873         at this point the font size is known and lengths depending
 874         on font sizes can be calculated correctly.
 875
 876         * kcanvas/RenderSVGContainer.cpp:
 877         (WebCore::RenderSVGContainer::layout):
 878         (WebCore::RenderSVGContainer::viewport):
 879         (WebCore::RenderSVGContainer::calcViewport):
 880         * kcanvas/RenderSVGContainer.h:
 881         * ksvg2/svg/SVGLength.cpp:
 882         (WebCore::SVGLength::updateValue):
 883         * ksvg2/svg/SVGMarkerElement.cpp:
 884         (WebCore::SVGMarkerElement::createRenderer):
 885         * ksvg2/svg/SVGSVGElement.cpp:
 886         (WebCore::SVGSVGElement::createRenderer):
 887         (WebCore::SVGSVGElement::attributeChanged):
 888         * ksvg2/svg/SVGSVGElement.h:
 889
 890 2006-09-27  Eric Seidel  <eric@eseidel.com>
 891
 892         Reviewed by darin.
 893
 894         Change our invalid-fill error behavior to match Opera (and soon Firefox)
 895         http://bugs.webkit.org/show_bug.cgi?id=11017
 896
 897         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 898         (WebCore::KSVGPainterFactory::isFilled):
 899         (WebCore::KSVGPainterFactory::fillPaintServer):
 900         (WebCore::KSVGPainterFactory::isStroked):
 901         (WebCore::KSVGPainterFactory::strokePaintServer):
 902
 903 2006-09-27  Brady Eidson  <beidson@apple.com>
 904
 905         Build fix
 906
 907         * loader/icon/IconDatabase.cpp:
 908         (WebCore::readySQLStatement):
 909
 910 2006-09-27  Brady Eidson  <beidson@apple.com>
 911
 912         Reviewed by Adam
 913
 914         In very specific circumstances, prepared SQLStatements can become invalid without
 915         any warning.  This checks for that state and re-prepares the statement and also
 916         adds more aggressive error-checking everywhere these statements are used.
 917
 918         * loader/icon/IconDatabase.cpp:
 919         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
 920         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
 921         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
 922         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
 923         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
 924         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
 925         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
 926         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
 927         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
 928         * loader/icon/SQLStatement.cpp:
 929         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
 930         * loader/icon/SQLStatement.h:
 931
 932 2006-09-26  Darin Adler  <darin@apple.com>
 933
 934         Reviewed by Steve.
 935
 936         - clean up options for font code path
 937
 938         * platform/Font.h:
 939         * platform/Font.cpp:
 940         (WebCore::Font::setCodePath): Added. Replaces boolean version.
 941         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
 942
 943         * platform/mac/WebCoreTextRenderer.mm:
 944         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
 945
 946 2006-09-26  John Sullivan  <sullivan@apple.com>
 947
 948         Reviewed by Darin
 949
 950         * bridge/mac/WebCoreFrameBridge.h:
 951         * bridge/mac/WebCoreFrameBridge.mm:
 952         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
 953         Added limit parameter, passed down to Frame
 954
 955         * page/Frame.h:
 956         * page/Frame.cpp:
 957         (WebCore::Frame::markAllMatchesForText):
 958         Added limit parameter. Stop the search if it hits limit.
 959
 960 2006-09-26  Sean Gies  <seangies@apple.com>
 961
 962         Reviewed by Brady Eidson.
 963
 964         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
 965
 966 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
 967
 968         Reviewed by john
 969
 970         <rdar://problem/4747695>
 971         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
 972
 973         * editing/DeleteSelectionCommand.cpp:
 974         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
 975         to select special elements that are fully selected after expansion
 976         moves to positions that are visually distinct from the originals.
 977         * editing/InsertListCommand.cpp:
 978         (WebCore::InsertListCommand::doApply): If the content of the list
 979         item will be moved into another list, put it in a list item.
 980
 981 2006-09-26  Geoffrey Garen <ggaren@apple.com>
 982
 983         Reviewed by Darin.
 984
 985         Temporary work-around for frame lifetime issue.
 986
 987         * page/Frame.cpp:
 988         (WebCore::Frame::clear):
 989         (WebCore::Frame::disconnectOwnerElement):
 990
 991 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
 992
 993         Reviewed by Tim H.
 994
 995         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
 996         Auto-generate DOMSVGElement for the Objective-C bindings
 997
 998         - Auto-generates DOMSVGElement.
 999
1000         - Make SVGExceptions work like all the other ExceptionCode
1001           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1002           and SVGExceptionMax.
1003
1004         * DerivedSources.make:
1005         * WebCore.xcodeproj/project.pbxproj:
1006         * bindings/js/kjs_binding.cpp:
1007         (KJS::):
1008         (KJS::setDOMException):
1009         * bindings/objc/DOMInternal.h:
1010         * bindings/objc/DOMInternal.mm:
1011         (raiseDOMException):
1012         * bindings/objc/DOMSVG.h:
1013         * bindings/objc/DOMSVGExecption.h: Added.
1014         * ksvg2/ksvg.h:
1015         * ksvg2/svg/SVGElement.cpp:
1016         (WebCore::SVGElement::setId):
1017         (WebCore::SVGElement::setXmlbase):
1018         * ksvg2/svg/SVGElement.h:
1019         * ksvg2/svg/SVGElement.idl:
1020         * ksvg2/svg/SVGException.h: Added.
1021         (WebCore::):
1022
1023 2006-09-26  Eric Seidel  <eric@eseidel.com>
1024
1025         Reviewed by Tim H.
1026
1027         viewbox parser does not allow <tab> as a delimiter
1028         http://bugs.webkit.org/show_bug.cgi?id=11014
1029
1030         Test: svg/hixie/viewbox/003.xml
1031
1032         * ksvg2/svg/svgpathparser.cpp:
1033         (WebCore::isWhitespace): new function
1034         (WebCore::skipOptionalSpaces):
1035         (WebCore::skipOptionalSpacesOrComma):
1036
1037 2006-09-26  Eric Seidel  <eric@eseidel.com>
1038
1039         Reviewed by Tim H.
1040
1041         SVGDocument::createElement does not create elements in the SVG namespace
1042         http://bugs.webkit.org/show_bug.cgi?id=10932
1043
1044         Test: svg/custom/createelement.svg
1045
1046         * ksvg2/svg/SVGDocument.cpp:
1047         (WebCore::SVGDocument::createElement):
1048         * ksvg2/svg/SVGDocument.h:
1049
1050 2006-09-26  Eric Seidel  <eric@eseidel.com>
1051
1052         Reviewed by Tim H.
1053
1054         RenderPath::nodeAtPoint does not respect stroke width
1055         http://bugs.webkit.org/show_bug.cgi?id=10829
1056
1057         Test: svg/custom/stroke-width-click.svg
1058
1059         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1060         (WebCore::RenderPath::strokeContains):
1061         * kcanvas/device/quartz/QuartzSupport.h:
1062         * kcanvas/device/quartz/QuartzSupport.mm:
1063
1064 2006-09-26  Eric Seidel  <eric@eseidel.com>
1065
1066         Reviewed by mitz.
1067
1068         Bring animation back to life
1069         http://bugs.webkit.org/show_bug.cgi?id=11021
1070
1071         Register/unregister SVGSVGElements as time containers on insertion/removal.
1072         Replace uses of DeprecatedString with String in SVGAnimationElement
1073         Various whitespace clean-up.
1074
1075         * ksvg2/misc/KSVGTimeScheduler.cpp:
1076         (WebCore::SVGTimer::notifyAll):
1077         * ksvg2/misc/SVGDocumentExtensions.cpp:
1078         (WebCore::SVGDocumentExtensions::startAnimations):
1079         (WebCore::SVGDocumentExtensions::pauseAnimations):
1080         (WebCore::SVGDocumentExtensions::unpauseAnimations):
1081         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1082         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1083         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1084         * ksvg2/svg/SVGAnimateTransformElement.h:
1085         * ksvg2/svg/SVGAnimationElement.cpp:
1086         (WebCore::SVGAnimationElement::SVGAnimationElement):
1087         (WebCore::SVGAnimationElement::parseMappedAttribute):
1088         (WebCore::SVGAnimationElement::parseClockValue):
1089         (WebCore::SVGAnimationElement::targetAttribute):
1090         (WebCore::SVGAnimationElement::setTargetAttribute):
1091         (WebCore::SVGAnimationElement::attributeName):
1092         * ksvg2/svg/SVGAnimationElement.h:
1093         (WebCore::SVGAnimationElement::rendererIsNeeded):
1094         * ksvg2/svg/SVGSVGElement.cpp:
1095         (WebCore::SVGSVGElement::getScreenCTM):
1096         (WebCore::SVGSVGElement::createRenderer):
1097         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
1098         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
1099         * ksvg2/svg/SVGSVGElement.h:
1100         * ksvg2/svg/SVGSetElement.cpp:
1101         (WebCore::SVGSetElement::handleTimerEvent):
1102         * ksvg2/svg/SVGURIReference.cpp:
1103         (WebCore::SVGURIReference::getTarget):
1104         * ksvg2/svg/SVGURIReference.h:
1105
1106 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
1107
1108         Reviewed by mitzpettel.
1109
1110         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
1111         No-SVG build broken since r16549
1112
1113         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
1114
1115         * css/cssparser.cpp:
1116         (WebCore::CSSParser::parseValue):
1117         * css/cssstyleselector.cpp:
1118         (WebCore::CSSStyleSelector::applyProperty):
1119         * page/FrameView.cpp:
1120         (WebCore::selectCursor):
1121         * platform/qt/GraphicsContextQt.cpp:
1122
1123 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
1124
1125         Reviewed by Maciej.
1126
1127         http://bugs.webkit.org/show_bug.cgi?id=10820
1128         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
1129
1130         (Originally written by Eric Seidel).
1131
1132         * bindings/js/kjs_window.cpp:
1133         (KJS::floatFeature):
1134         * ksvg2/svg/SVGAngle.cpp:
1135         (SVGAngle::setValueAsString):
1136         * ksvg2/svg/SVGAnimationElement.cpp:
1137         (SVGAnimationElement::parseMappedAttribute):
1138         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1139         (SVGComponentTransferFunctionElement::parseMappedAttribute):
1140         * ksvg2/svg/SVGFECompositeElement.cpp:
1141         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1142         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1143         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1144         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1145         (SVGFEDisplacementMapElement::parseMappedAttribute):
1146         * ksvg2/svg/SVGFELightElement.cpp:
1147         (SVGFELightElement::parseMappedAttribute):
1148         * ksvg2/svg/SVGFEOffsetElement.cpp:
1149         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1150         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1151         (SVGFESpecularLightingElement::parseMappedAttribute):
1152         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1153         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1154         * ksvg2/svg/SVGStopElement.cpp:
1155         (SVGStopElement::parseMappedAttribute):
1156         * platform/AtomicString.h:
1157         (WebCore::AtomicString::toDouble):
1158         * platform/PlatformString.h:
1159         * platform/String.cpp:
1160         (WebCore::String::toDouble):
1161         * platform/StringImpl.cpp:
1162         (WebCore::StringImpl::toDouble):
1163         * platform/StringImpl.h:
1164         * rendering/DeprecatedSlider.cpp:
1165         (WebCore::DeprecatedSlider::updateFromElement):
1166         * xml/XPathGrammar.y:
1167
1168 2006-09-25  David Harrison  <harrison@apple.com>
1169
1170         Reviewed by Tim Omernick and Tim Hatcher.
1171
1172         <rdar://problem/4717965> Text Field text parameterized attributes should work
1173         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
1174
1175         * bridge/mac/WebCoreAXObject.mm:
1176         (-[WebCoreAXObject accessibilityAttributeValue:]):
1177         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
1178
1179         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1180         Cleaned up. Added text field and text area parameterzed attributes.
1181
1182         (-[WebCoreAXObject doAXLineForTextMarker:]):
1183         Fixed to be zero-based and to deal with the first position properly.
1184
1185         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
1186         Minor formatting.
1187
1188         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
1189         (-[WebCoreAXObject indexForTextMarker:]):
1190         (-[WebCoreAXObject textMarkerRangeForRange:]):
1191         (-[WebCoreAXObject rangeForTextMarkerRange:]):
1192         New utility methods.
1193
1194         (-[WebCoreAXObject doAXLineForIndex:]):
1195         (-[WebCoreAXObject doAXRangeForLine:]):
1196         (-[WebCoreAXObject doAXStringForRange:]):
1197         (-[WebCoreAXObject doAXRangeForPosition:]):
1198         (-[WebCoreAXObject doAXRangeForIndex:]):
1199         (-[WebCoreAXObject doAXBoundsForRange:]):
1200         (-[WebCoreAXObject doAXAttributedStringForRange:]):
1201         (-[WebCoreAXObject doAXRTFForRange:]):
1202         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
1203         Implement text field and text area parameterized attributes.
1204
1205         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1206         Added text field and text area parameterzed attributes.
1207
1208         * rendering/RenderTextControl.h:
1209         Made indexForVisiblePosition() and visiblePositionForIndex() public.
1210
1211 2006-09-25  Adam Roben  <aroben@apple.com>
1212
1213         Reviewed by Brady.
1214
1215         Build fixes.
1216
1217         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
1218         * platform/ResourceLoader.h: Store whether a particular job
1219         has received a response within the ResourceLoader object itself, since
1220         it's possible that we will enter the InternetReadFileExA while loop
1221         twice for the same job.
1222         * platform/ResourceLoaderInternal.h: Add private instance variable to
1223         store whether we've received a response.
1224         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1225         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
1226         directives.
1227         * platform/win/ResourceLoaderWin.cpp:
1228         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
1229         whether it has received a response instead of assuming it hasn't.
1230         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
1231         (WebCore::ResourceLoader::hasReceivedResponse): Added.
1232         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
1233         setProportion
1234         (ScrollBar::setProportion):
1235
1236 2006-09-25  Brady Eidson  <beidson@apple.com>
1237
1238         Requested by ggaren
1239
1240         Disabled IconDatabase logging by default
1241
1242         * platform/Logging.cpp:
1243         (WebCore::):
1244
1245 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
1246
1247         Build fix
1248
1249         * platform/cf/ResourceLoaderCFNet.cpp:
1250         (WebCore::willCacheResponse):
1251
1252 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
1253
1254         Reviewed by john
1255
1256         <http://bugs.webkit.org/show_bug.cgi?id=11002>
1257         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
1258
1259         * editing/IndentOutdentCommand.cpp:
1260         (WebCore::IndentOutdentCommand::indentRegion): Special case
1261         an empty root editable element.
1262
1263 2006-09-25  Brady Eidson  <beidson@apple.com>
1264
1265         Reviewed by Steve
1266
1267         Math error in SystemTimeWin
1268
1269         * platform/win/SystemTimeWin.cpp:
1270         (WebCore::currentTime):
1271
1272 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
1273
1274         Reviewed by Eric.
1275
1276         Whitespace cleanup; rename *job variables to *loader.
1277
1278         * bindings/js/JSXMLHttpRequest.cpp:
1279         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
1280         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
1281         (KJS::JSXMLHttpRequestConstructorImp::construct):
1282         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
1283         (KJS::JSXMLHttpRequest::getValueProperty):
1284         (KJS::JSXMLHttpRequest::put):
1285         (KJS::JSXMLHttpRequest::putValueProperty):
1286         (KJS::JSXMLHttpRequest::mark):
1287         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
1288         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
1289         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
1290         * bindings/js/JSXMLHttpRequest.h:
1291         (KJS::JSXMLHttpRequest::toBoolean):
1292         * xml/xmlhttprequest.cpp:
1293         (WebCore::XMLHttpRequest::XMLHttpRequest):
1294         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1295         (WebCore::XMLHttpRequest::send):
1296         (WebCore::XMLHttpRequest::abort):
1297         (WebCore::XMLHttpRequest::receivedAllData):
1298         (WebCore::XMLHttpRequest::receivedData):
1299         * xml/xmlhttprequest.h:
1300         (WebCore::):
1301
1302 2006-09-25  Timothy Hatcher  <timothy@apple.com>
1303
1304         Reviewed by Brady.
1305
1306         - Deprecate the rest of the old-style methods that are not generated.
1307         - Add @property syntax to DOMRange.
1308
1309         * WebCore.xcodeproj/project.pbxproj:
1310         * bindings/objc/DOM.mm:
1311         (-[DOMRange setStart:offset:]):
1312         (-[DOMRange setEnd:offset:]):
1313         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1314         (-[DOMRange setStart::]):
1315         (-[DOMRange setEnd::]):
1316         (-[DOMRange compareBoundaryPoints::]):
1317         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1318         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1319         (-[DOMDocument createNodeIterator::::]):
1320         (-[DOMDocument createTreeWalker::::]):
1321         * bindings/objc/DOMCSS.h:
1322         * bindings/objc/DOMCSS.mm:
1323         (-[DOMDocument getComputedStyle:pseudoElement:]):
1324         (-[DOMDocument getComputedStyle::]):
1325         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1326         * bindings/objc/DOMExtensions.h:
1327         * bindings/objc/DOMHTML.h:
1328         * bindings/objc/DOMRange.h:
1329         * bindings/objc/DOMTraversal.h:
1330
1331 2006-09-25  Eric Seidel  <eric@eseidel.com>
1332
1333         Reviewed by mjs.
1334
1335         Outermost <svg> element should clip to viewport
1336         http://bugs.webkit.org/show_bug.cgi?id=11007
1337
1338         Test: svg/custom/viewport-clip.svg
1339
1340         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1341
1342 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1343
1344         Reviewed by Maciej.
1345
1346         * css/MediaList.cpp:
1347         Remove unused header.
1348
1349         * dom/Document.cpp:
1350         (WebCore::Document::clear):
1351         Use clear instead of iterating through the list of event listeners, removing each one.
1352         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1353
1354         * html/HTMLKeygenElement.cpp:
1355         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1356         (WebCore::HTMLKeygenElement::appendFormData):
1357         Update due to changes in the SSL key generator.
1358
1359         * ksvg2/svg/SVGAngle.cpp:
1360         Remove unused header.
1361
1362         * ksvg2/svg/SVGAnimationElement.cpp:
1363         (SVGAnimationElement::parseMappedAttribute):
1364         Rename methods and pass Strings instead of DeprecatedStrings to
1365         parseSeparatedList.
1366
1367         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1368         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1369         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1370         * ksvg2/svg/SVGFEMergeElement.cpp:
1371         * ksvg2/svg/SVGFEOffsetElement.cpp:
1372         Remove unused headers.
1373
1374         * ksvg2/svg/SVGHelper.cpp:
1375         (WebCore::SVGHelper::parseSeparatedList):
1376         * ksvg2/svg/SVGHelper.h:
1377         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
1378         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1379
1380         * ksvg2/svg/SVGLengthList.cpp:
1381         (WebCore::SVGLengthList::parse):
1382         * ksvg2/svg/SVGLengthList.h:
1383         Use Vector<String> instead of DeprecatedStringList.
1384
1385         * loader/Cache.cpp:
1386         (WebCore::Cache::requestImage):
1387         (WebCore::Cache::requestStyleSheet):
1388         (WebCore::Cache::requestScript):
1389         (WebCore::Cache::requestXSLStyleSheet):
1390         (WebCore::Cache::requestXBLDocument):
1391         (WebCore::Cache::remove):
1392         (WebCore::Cache::get):
1393         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1394
1395         * loader/DocLoader.cpp:
1396         (WebCore::DocLoader::needReload):
1397         * loader/DocLoader.h:
1398         Use a HashSet instead of DeprecatedStringList.
1399
1400         * page/FrameView.h:
1401         Remove declarations that have no functions.
1402
1403         * platform/SSLKeyGenerator.h:
1404         * platform/mac/SSLKeyGeneratorMac.mm:
1405         (WebCore::supportedKeySizes):
1406         (WebCore::signedPublicKeyAndChallengeString):
1407         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1408         DeprecatedString.
1409
1410 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1411
1412         Shunt the RenderTheme world transform adoption between
1413         Cairo and Windows into getWindowsContext and move the method
1414         out of GraphicsContextCairo and into GraphicsContextWin.
1415
1416         * ChangeLog:
1417         * WebCore.vcproj/WebCore/WebCore.vcproj:
1418         * platform/cairo/GraphicsContextCairo.cpp:
1419         * platform/win/GraphicsContextWin.cpp: Added.
1420         (WebCore::GraphicsContext::getWindowsContext):
1421         (WebCore::GraphicsContext::releaseWindowsContext):
1422         * rendering/RenderThemeWin.cpp:
1423         (WebCore::prepareForDrawing):
1424
1425 2006-09-24  Eric Seidel  <eric@eseidel.com>
1426
1427         Reviewed by hyatt.
1428
1429         <svg:a> cannot be styled with a:hover
1430         http://bugs.webkit.org/show_bug.cgi?id=11005
1431
1432         Test: svg/hixie/cascade/002.xml
1433
1434         * css/cssstyleselector.cpp:
1435         (WebCore::checkPseudoState):
1436
1437 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1438
1439         Reviewed by Tim H.
1440
1441         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1442         SVG needs Obj-C DOM bindings
1443
1444         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
1445           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1446           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
1447           DOMSVGTransformList.
1448
1449         * DerivedSources.make:
1450         * WebCore.xcodeproj/project.pbxproj:
1451         * bindings/objc/DOMInternal.h:
1452         * bindings/objc/DOMSVG.h: Added.
1453         * ksvg2/svg/SVGAngle.idl:
1454         * ksvg2/svg/SVGLength.idl:
1455         * ksvg2/svg/SVGLengthList.idl:
1456         * ksvg2/svg/SVGMatrix.idl:
1457         * ksvg2/svg/SVGPathSeg.idl:
1458         * ksvg2/svg/SVGPathSegList.idl:
1459         * ksvg2/svg/SVGTransform.idl:
1460         * ksvg2/svg/SVGTransformList.idl:
1461
1462 2006-09-24  Rob Buis  <buis@kde.org>
1463
1464         Reviewed by eseidel.
1465
1466         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1467         WebKit does not handle fallback custom cursors
1468         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1469         WebKit does not properly handle SVG <cursor> element
1470
1471         Add support for svg cursor images. Also make sure hotspot
1472         settings are handled correctly. Add tests for handling of css3
1473         cursor syntax with hotspots in strict and quirks mode. Finally
1474         implement fallback.
1475
1476         * WebCore.xcodeproj/project.pbxproj:
1477         * css/CSSComputedStyleDeclaration.cpp:
1478         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1479         * css/CSSCursorImageValue.cpp: Added.
1480         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1481         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1482         * css/CSSCursorImageValue.h: Added.
1483         (WebCore::CSSCursorImageValue::hotspot):
1484         * css/cssparser.cpp:
1485         (WebCore::CSSParser::parseValue):
1486         * css/cssstyleselector.cpp:
1487         (WebCore::CSSStyleSelector::applyProperty):
1488         * ksvg2/svg/SVGCursorElement.cpp:
1489         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1490         * manual-tests/css3-cursor-fallback-strict.html: Added.
1491         * manual-tests/cursorfallback.xml: Added.
1492         * page/FrameView.cpp:
1493         (WebCore::selectCursor):
1494         * platform/Cursor.h:
1495         * platform/mac/CursorMac.mm:
1496         (WebCore::createCustomCursor):
1497         (WebCore::Cursor::Cursor):
1498         * platform/qt/CursorQt.cpp:
1499         (WebCore::Cursor::Cursor):
1500         * rendering/RenderStyle.cpp:
1501         (WebCore::StyleInheritedData::StyleInheritedData):
1502         (WebCore::StyleInheritedData::operator==):
1503         (WebCore::RenderStyle::diff):
1504         (WebCore::RenderStyle::addCursor):
1505         (WebCore::RenderStyle::addSVGCursor):
1506         (WebCore::RenderStyle::setCursorList):
1507         (WebCore::RenderStyle::clearCursorList):
1508         * rendering/RenderStyle.h:
1509         (WebCore::CursorData::CursorData):
1510         (WebCore::CursorList::operator[]):
1511         (WebCore::CursorList::size):
1512         (WebCore::CursorList::append):
1513         (WebCore::RenderStyle::cursors):
1514
1515 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1516
1517         Reviewed by Tim H.
1518
1519         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1520         Auto-generate the internal methods interfaces for the Objective-C bindings
1521
1522         - Auto-generate the internal method declarations into their own files
1523           named in the form DOMFooBarInternal.h for class DOMFooBar.
1524
1525         - Remove all use of DOM_cast from code.
1526
1527         - Assorted cleanups.
1528
1529         * WebCore.xcodeproj/project.pbxproj:
1530         * bindings/objc/DOM.mm:
1531         (-[DOMNode _initWithNode:WebCore::]):
1532         (-[DOMNode WebCore::]):
1533         (-[DOMRange dealloc]):
1534         (-[DOMRange finalize]):
1535         (-[DOMRange _initWithRange:WebCore::]):
1536         (-[DOMRange WebCore::]):
1537         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1538         (-[DOMNodeFilter WebCore::]):
1539         (-[DOMNodeFilter dealloc]):
1540         (-[DOMNodeFilter finalize]):
1541         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1542         (-[DOMNodeIterator WebCore::]):
1543         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1544         (-[DOMTreeWalker WebCore::]):
1545         * bindings/objc/DOMAbstractView.mm:
1546         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1547         * bindings/objc/DOMCSS.mm:
1548         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1549         (-[DOMCSSRule _initWithRule:WebCore::]):
1550         (-[DOMCSSValue _initWithValue:WebCore::]):
1551         * bindings/objc/DOMEvents.mm:
1552         (-[DOMEvent _initWithEvent:WebCore::]):
1553         * bindings/objc/DOMHTMLAppletElement.mm:
1554         (-[DOMHTMLAppletElement align]):
1555         (-[DOMHTMLAppletElement setAlign:]):
1556         (-[DOMHTMLAppletElement alt]):
1557         (-[DOMHTMLAppletElement setAlt:]):
1558         (-[DOMHTMLAppletElement archive]):
1559         (-[DOMHTMLAppletElement setArchive:]):
1560         (-[DOMHTMLAppletElement code]):
1561         (-[DOMHTMLAppletElement setCode:]):
1562         (-[DOMHTMLAppletElement codeBase]):
1563         (-[DOMHTMLAppletElement setCodeBase:]):
1564         (-[DOMHTMLAppletElement height]):
1565         (-[DOMHTMLAppletElement setHeight:]):
1566         (-[DOMHTMLAppletElement hspace]):
1567         (-[DOMHTMLAppletElement setHspace:]):
1568         (-[DOMHTMLAppletElement name]):
1569         (-[DOMHTMLAppletElement setName:]):
1570         (-[DOMHTMLAppletElement object]):
1571         (-[DOMHTMLAppletElement setObject:]):
1572         (-[DOMHTMLAppletElement vspace]):
1573         (-[DOMHTMLAppletElement setVspace:]):
1574         (-[DOMHTMLAppletElement width]):
1575         (-[DOMHTMLAppletElement setWidth:]):
1576         * bindings/objc/DOMInternal.h:
1577         (getDOMWrapper):
1578         (addDOMWrapper):
1579         (raiseOnDOMError):
1580         * bindings/objc/DOMXPath.mm:
1581         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1582         * bindings/scripts/CodeGeneratorObjC.pm:
1583
1584 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1585
1586         Reviewed by eseidel.
1587
1588         Fix Qt/Linux build after Dave's Scrollbar changes.
1589
1590         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
1591         * platform/qt/TemporaryLinkStubs.cpp:
1592         (WebCore::ScrollBar::setProportion):
1593         (WebCore::PlatformScrollBar::updateThumbPosition):
1594         (WebCore::PlatformScrollBar::updateThumbProportion):
1595
1596 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1597
1598         Reviewed by eseidel.
1599
1600         Qt/Linux build system changes: enable xpath/xslt by default.
1601         Offer possibility to change all of these using 'ccmake'.
1602
1603         * CMakeLists.txt:
1604
1605 2006-09-24  Dave Hyatt  <hyatt@apple.com>
1606
1607         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
1608         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
1609         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
1610
1611         * platform/ScrollBar.cpp:
1612         (WebCore::ScrollBar::setValue):
1613         (WebCore::ScrollBar::setProportion):
1614         * platform/ScrollBar.h:
1615         (WebCore::ScrollBar::value):
1616         * platform/mac/PlatformScrollBar.h:
1617         * platform/mac/PlatformScrollBarMac.mm:
1618         (WebCore::PlatformScrollBar::updateThumbPosition):
1619         (WebCore::PlatformScrollBar::updateThumbProportion):
1620         * platform/win/PlatformScrollBar.h:
1621         * platform/win/TemporaryLinkStubs.cpp:
1622         (PlatformScrollBar::updateThumbPosition):
1623         (PlatformScrollBar::updateThumbProportion):
1624         * rendering/RenderLayer.cpp:
1625         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1626
1627 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
1628
1629         Reviewed by Eric.
1630
1631         http://bugs.webkit.org/show_bug.cgi?id=4872
1632         XMLHttpRequest fails to throw an exception when there is a security violation
1633         (mismatching domains)
1634
1635         Raise an exception if there is a security violation, and also in cases required by
1636         the current draft of XHR specification.
1637
1638         * bindings/js/JSXMLHttpRequest.cpp:
1639         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
1640         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
1641         reports one, and also if there were too few arguments passed.
1642
1643         * bindings/js/kjs_binding.cpp:
1644         (KJS::setDOMException): Added support for custom XHR exceptions.
1645
1646         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
1647         exception code range for XHR exceptions.
1648
1649         * xml/xmlhttprequest.cpp:
1650         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
1651         (WebCore::XMLHttpRequest::send):
1652         (WebCore::XMLHttpRequest::setRequestHeader):
1653         (WebCore::XMLHttpRequest::getStatus):
1654         (WebCore::XMLHttpRequest::getStatusText):
1655         (WebCore::XMLHttpRequest::processSyncLoadResults):
1656         (WebCore::XMLHttpRequest::receivedAllData):
1657         (WebCore::XMLHttpRequest::receivedData):
1658
1659 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
1660
1661         Reviewed by Jeff Jenkins.
1662
1663         Tweak CF types.
1664
1665         * platform/cf/ResourceLoaderCFNet.cpp:
1666         (WebCore::willCacheResponse):
1667
1668 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
1669
1670         Reviewed by darin
1671
1672         <http://bugs.webkit.org/show_bug.cgi?id=8029>
1673         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
1674
1675         * dom/Document.cpp:
1676         (WebCore::Document::clearSelectionIfNeeded):
1677         * dom/Element.cpp:
1678         (WebCore::Element::contains):
1679         * dom/Node.cpp:
1680         (WebCore::Node::traverseNextNode):
1681         (WebCore::Node::traverseNextSibling):
1682         (WebCore::Node::traversePreviousNodePostOrder):
1683         (WebCore::Node::checkAddChild):
1684         (WebCore::Node::isDescendantOf):
1685         * dom/Node.h:
1686         * dom/NodeIterator.cpp:
1687         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
1688         * editing/ApplyStyleCommand.cpp:
1689         (WebCore::ApplyStyleCommand::applyBlockStyle):
1690         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1691         (WebCore::ApplyStyleCommand::applyInlineStyle):
1692         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
1693         * editing/CompositeEditCommand.cpp:
1694         (WebCore::CompositeEditCommand::mergeIdenticalElements):
1695         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
1696         * editing/DeleteSelectionCommand.cpp:
1697         (WebCore::updatePositionForNodeRemoval):
1698         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1699         (WebCore::DeleteSelectionCommand::mergeParagraphs):
1700         * editing/FormatBlockCommand.cpp:
1701         (WebCore::FormatBlockCommand::doApply):
1702         * editing/IndentOutdentCommand.cpp:
1703         (WebCore::enclosingListOrBlockquote):
1704         * editing/Selection.cpp:
1705         (WebCore::Selection::validate):
1706         * editing/SelectionController.cpp:
1707         (WebCore::SelectionController::nodeWillBeRemoved):
1708         * editing/TextIterator.cpp:
1709         (WebCore::SimplifiedBackwardsTextIterator::advance):
1710         * editing/VisiblePosition.cpp:
1711         (WebCore::VisiblePosition::next):
1712         (WebCore::VisiblePosition::previous):
1713         (WebCore::VisiblePosition::canonicalPosition):
1714         (WebCore::isFirstVisiblePositionInNode):
1715         (WebCore::isLastVisiblePositionInNode):
1716         * editing/htmlediting.cpp:
1717         (WebCore::firstEditablePositionAfterPositionInRoot):
1718         (WebCore::lastEditablePositionBeforePositionInRoot):
1719         (WebCore::enclosingNodeWithTag):
1720         (WebCore::enclosingList):
1721         (WebCore::enclosingListChild):
1722         * editing/markup.cpp:
1723         (WebCore::createMarkup):
1724
1725 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1726
1727         Reviewed by Darin.
1728
1729         - Added @property syntax to non-generated headers
1730           inside #ifndef BUILDING_ON_TIGER.
1731         - Changed the DOMEventTarget protocol to have have new versions
1732           of addEventListener and removeEventListener with named parameters.
1733           These old style methods can be removed once Mail changes to use
1734           the new methods <rdar://problem/4746649>.
1735
1736         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
1737         * bindings/objc/DOM.mm:
1738         (-[DOMNode addEventListener:listener:useCapture:]):
1739         (-[DOMNode addEventListener:::]): call the new method
1740         (-[DOMNode removeEventListener:listener:useCapture:]):
1741         (-[DOMNode removeEventListener:::]): call the new method
1742         * bindings/objc/DOMAbstractView.h:
1743         * bindings/objc/DOMEventTarget.h:
1744         * bindings/objc/DOMHTMLAppletElement.h:
1745         * bindings/objc/DOMHTMLEmbedElement.h:
1746         * bindings/objc/DOMHTMLOptionElement.h:
1747         * bindings/objc/DOMObject.h:
1748         * bindings/objc/DOMRGBColor.h:
1749
1750 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1751
1752         Reviewed by Eric.
1753
1754         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
1755
1756         * platform/qt/FrameQt.cpp:
1757         * platform/qt/GraphicsContextQt.cpp:
1758         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
1759         (WebCore::GraphicsContext::origin):
1760         * platform/qt/PlatformScrollBar.h: Added.
1761         (WebCore::PlatformScrollBar::isWidget):
1762         * platform/qt/WidgetQt.cpp:
1763         (WebCore::Widget::invalidate):
1764         (WebCore::Widget::invalidateRect):
1765
1766 2006-09-22  Dave Hyatt <hyatt@apple.com>
1767
1768         Super-minor tweaks to the systemFont function on Mac.
1769         Set the generic family to None rather than to Serif, and
1770         don't waste time setting the computed size, since that is
1771         set from the specified size over in CSSStyleSelector anyway.
1772
1773         * rendering/RenderThemeMac.mm:
1774         (WebCore::RenderThemeMac::systemFont):
1775
1776 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1777
1778         Reviewed by Brady.
1779
1780         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
1781         take floats. There was already an implicit conversion to float/double
1782         when calling CGContextTranslateCTM or cairo_translate.
1783
1784         * platform/GraphicsContext.h:
1785         * platform/cairo/GraphicsContextCairo.cpp:
1786         (WebCore::GraphicsContext::translate):
1787         * platform/cg/GraphicsContextCG.cpp:
1788         (WebCore::GraphicsContext::translate):
1789
1790 2006-09-22  Brady Eidson  <beidson@apple.com>
1791
1792         Reviewed by Sfalken
1793
1794         Add redirect and other cleanup to ResourceLoaderWin.cpp
1795         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
1796         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
1797
1798         * WebCore.xcodeproj/project.pbxproj:
1799         * platform/ResourceLoader.h:
1800         * platform/win/ResourceLoaderWin.cpp:
1801         (WebCore::ResourceLoaderWndProc):
1802         (WebCore::initializeOffScreenResourceLoaderWindow):
1803         (WebCore::ResourceLoader::onHandleCreated):
1804         (WebCore::ResourceLoader::onRequestRedirected):
1805         (WebCore::ResourceLoader::onRequestComplete):
1806         (WebCore::transferJobStatusCallback):
1807
1808 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
1809
1810         Reviewed by Geoff.
1811
1812         http://bugs.webkit.org/show_bug.cgi?id=10803
1813         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
1814
1815         * page/FrameView.cpp:
1816         (WebCore::FrameView::hoverTimerFired): Use the current event.
1817
1818 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1819
1820         Reviewed by Anders.
1821
1822         Fix (last) svg memory leak.
1823
1824         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
1825         (SVGTransformable::parseTransformAttribute):
1826
1827 2006-09-22  Eric Seidel  <eric@eseidel.com>
1828
1829         No review necessary, just removing a dead file.
1830
1831         Remove unused file (added previously by mistake) to make room for real implementation.
1832
1833         * platform/mac/BitmapImageMac.mm: Removed.
1834
1835 2006-09-22  Dave Hyatt <hyatt@apple.com>
1836
1837         Move PlatformScrollBar.h down into the platforms.
1838
1839         Reviewed by andersca
1840
1841         * platform/PlatformScrollBar.h: Removed.
1842         * platform/win/PlatformScrollBar.h: Added.
1843         * platform/mac/PlatformScrollBar.h: Added.
1844
1845 2006-09-22   Dave Hyatt  <hyatt@apple.com>
1846
1847         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
1848         any widget subsystems that don't have any underlying native objects backing the widgets.
1849
1850         Reviewed by anders
1851
1852         * platform/Widget.h:
1853         * platform/mac/WidgetMac.mm:
1854         (WebCore::Widget::invalidate):
1855         (WebCore::Widget::invalidateRect):
1856         * platform/win/TemporaryLinkStubs.cpp:
1857         (Widget::invalidate):
1858         (Widget::invalidateRect):
1859
1860 2006-09-22  Rob Buis  <buis@kd.org>
1861
1862         Reviewed by eseidel.
1863
1864         http://bugs.webkit.org/show_bug.cgi?id=10901
1865         Merge build fixes from unity
1866
1867         * CMakeLists.txt:
1868
1869 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1870
1871         Reviewed by eseidel.
1872
1873         http://bugs.webkit.org/show_bug.cgi?id=10977
1874         SVGDocument does not expose 'rootElement' property
1875
1876         Enable 'rootElement' property.
1877
1878         * ksvg2/svg/SVGDocument.idl:
1879
1880 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
1881
1882         Tweak includes.
1883
1884         * platform/ResourceLoaderInternal.h:
1885
1886 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1887
1888         build fixed. band happy.
1889
1890         * platform/cg/GraphicsContextCG.cpp:
1891         (WebCore::GraphicsContext::translate):
1892         * platform/mac/WidgetMac.mm:
1893
1894 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1895
1896         Reviewed by Maciej.
1897
1898         Some Widget refactoring.
1899
1900         * WebCore.vcproj/WebCore/WebCore.vcproj:
1901         * bridge/mac/FrameMac.mm:
1902         * bridge/win/FrameWin.cpp:
1903         (WebCore::FrameWin::runJavaScriptAlert):
1904         (WebCore::FrameWin::runJavaScriptConfirm):
1905         * bridge/win/PageWin.cpp:
1906         (WebCore::Page::Page):
1907         (WebCore::rootWindowForFrame):
1908         * html/CanvasRenderingContext2D.cpp:
1909         (WebCore::CanvasRenderingContext2D::translate):
1910         * page/FrameView.cpp:
1911         (WebCore::FrameView::isFrameView):
1912         * page/Page.h:
1913         (WebCore::Page::setInstanceHandle):
1914         (WebCore::Page::instanceHandle):
1915         * platform/GraphicsContext.h:
1916         * platform/ScrollView.h:
1917         * platform/Widget.h:
1918         * platform/cairo/GraphicsContextCairo.cpp:
1919         (WebCore::GraphicsContext::translate):
1920         (WebCore::GraphicsContext::origin):
1921         * platform/mac/WidgetMac.mm:
1922         (WebCore::Widget::clearFocus):
1923         * platform/win/ResourceLoaderWin.cpp:
1924         (WebCore::initializeOffScreenResourceLoaderWindow):
1925         * platform/win/ScreenWin.cpp:
1926         (WebCore::monitorInfo):
1927         * platform/win/ScrollViewWin.cpp:
1928         (WebCore::ScrollView::updateContents):
1929         (WebCore::ScrollView::visibleWidth):
1930         (WebCore::ScrollView::visibleHeight):
1931         (WebCore::ScrollView::visibleContentRect):
1932         (WebCore::ScrollView::viewportToContents):
1933         (WebCore::ScrollView::contentsToViewport):
1934         (WebCore::ScrollView::scrollBy):
1935         (WebCore::ScrollView::updateScrollInfo):
1936         (WebCore::ScrollView::updateScrollBars):
1937         * platform/win/SharedTimerWin.cpp:
1938         (WebCore::initializeOffScreenTimerWindow):
1939         * platform/win/TemporaryLinkStubs.cpp:
1940         (FrameView::updateBorder):
1941         (ScrollView::paint):
1942         (GraphicsContext::clip):
1943         * platform/win/WidgetWin.cpp:
1944         (WebCore::Widget::Widget):
1945         (WebCore::Widget::parentWindow):
1946         (WebCore::Widget::setParentWindow):
1947         (WebCore::Widget::frameGeometry):
1948         (WebCore::Widget::hasFocus):
1949         (WebCore::Widget::setFocus):
1950         (WebCore::Widget::show):
1951         (WebCore::Widget::hide):
1952         (WebCore::Widget::setFrameGeometry):
1953
1954 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
1955
1956         Reviewed by Tim H.
1957
1958         * platform/TextEncoding.cpp:
1959         (WebCore::TextEncoding::backslashAsCurrencySymbol):
1960         Add comment clarifying why backslashAsCurrencySymbol is needed.
1961
1962 2006-09-21  Sean Gies  <seangies@apple.com>
1963
1964         Reviewed by Adam Roben.
1965
1966         Add utility functions to get and release HDC from GraphicsContext.
1967
1968         * platform/GraphicsContext.h: Add utilities to get and release HDC.
1969         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
1970         * rendering/RenderThemeWin.cpp: Switch to new utilities.
1971
1972 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
1973
1974         Reviewed by anders
1975
1976         <rdar://problem/4426622>
1977         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
1978
1979         * editing/htmlediting.cpp:
1980         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1981         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1982         Got rid of uses of DepricatedString.
1983
1984 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1985
1986         Reviewed by eseidel.
1987
1988         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
1989
1990         * page/Frame.cpp:
1991         (WebCore::Frame::endIfNotLoading):
1992
1993 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1994
1995         Reviewed by eseidel.
1996
1997         Fix Qt/Linux build.
1998
1999         * CMakeLists.txt:
2000         * kcanvas/device/qt/KCanvasClipperQt.h:
2001         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2002         * platform/qt/FrameQt.cpp:
2003         (WebCore::FrameQt::isLoadTypeReload):
2004         (WebCore::FrameQt::originalRequestURL):
2005         * platform/qt/FrameQt.h:
2006         * platform/qt/GraphicsContextQt.cpp:
2007         (WebCore::GraphicsContext::concatCTM):
2008         * platform/qt/ScrollViewQt.cpp:
2009         (WebCore::ScrollView::wheelEvent):
2010         * platform/qt/TemporaryLinkStubs.cpp:
2011         (WebCore::IconDatabase::setIconURLForPageURL):
2012
2013 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2014
2015         Reviewed by john
2016
2017         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2018         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2019
2020         * editing/MoveSelectionCommand.cpp:
2021         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2022         to the position-to-move-to's document, not the fragment's document.  The
2023         fragment's document is the document used to create the fragment and is irrelavant.
2024
2025 === Safari-521.27 ===
2026
2027 2006-09-21  Brady Eidson  <beidson@apple.com>
2028
2029         Reviewed by Anders
2030
2031         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2032         This fixes Spinneret so it won't crash on its first load!
2033
2034         * page/Frame.cpp:
2035         (WebCore::Frame::endIfNotLoading):
2036
2037 2006-09-21  Brady Eidson  <beidson@apple.com>
2038
2039         Build fix
2040
2041         * platform/win/TemporaryLinkStubs.cpp:
2042         (ScrollView::wheelEvent):
2043
2044 2006-09-20  Rob Buis  <buis@kde.org>
2045
2046         Reviewed by eseidel.
2047
2048         http://bugs.webkit.org/show_bug.cgi?id=10946
2049         new marker code draws end-marker in wrong place
2050
2051         Keep track of the start of the subpath so we can handle
2052         closeTo/moveTo correctly.
2053
2054         * kcanvas/RenderPath.cpp:
2055         (WebCore::DrawMarkersData::DrawMarkersData):
2056         (WebCore::updateMarkerDataForElement):
2057
2058 2006-09-21  David Hyatt <hyatt@apple.com>
2059
2060         Wheel scrolling prep for Win32.
2061
2062         WARNING: NO TEST CASES ADDED OR CHANGED
2063
2064         * platform/PlatformWheelEvent.h:
2065         * platform/ScrollBar.h:
2066         * platform/ScrollView.h:
2067         * platform/mac/ScrollViewMac.mm:
2068         (WebCore::ScrollView::wheelEvent):
2069         * rendering/RenderLayer.cpp:
2070
2071 2006-09-20  Timothy Hatcher  <timothy@apple.com>
2072
2073         Reviewed by Hyatt.
2074
2075         Bug 10917: REGRESSION (r16027): iFrame transparency broken
2076         http://bugs.webkit.org/show_bug.cgi?id=10917
2077
2078         Don't paint the base background color if we transparent.
2079
2080         * rendering/RenderBox.cpp:
2081         (WebCore::RenderBox::paintBackgroundExtended):
2082
2083 2006-09-20  Adam Roben  <aroben@apple.com>
2084
2085         Reviewed by andersca.
2086
2087         * platform/FileChooser.h: Remove no-longer-necessary namespace std
2088
2089 2006-09-20  Eric Seidel  <eric@eseidel.com>
2090
2091         Reviewed by beth.
2092
2093         Cleanup style in KCanvas.
2094         Remove extra white-space, unneeded arguments, etc.
2095
2096         * WebCore.xcodeproj/project.pbxproj:
2097         * kcanvas/KCanvasClipper.cpp:
2098         (WebCore::operator<<):
2099         (WebCore::KCanvasClipper::externalRepresentation):
2100         * kcanvas/KCanvasClipper.h:
2101         * kcanvas/KCanvasFilters.cpp:
2102         (WebCore::KCanvasFilter::externalRepresentation):
2103         (WebCore::operator<<):
2104         (WebCore::KCanvasFilterEffect::externalRepresentation):
2105         (WebCore::KCPointLightSource::externalRepresentation):
2106         (WebCore::KCSpotLightSource::externalRepresentation):
2107         (WebCore::KCDistantLightSource::externalRepresentation):
2108         (WebCore::KCanvasFEBlend::externalRepresentation):
2109         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
2110         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
2111         (WebCore::KCanvasFEComposite::externalRepresentation):
2112         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
2113         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
2114         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
2115         (WebCore::KCanvasFEFlood::externalRepresentation):
2116         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
2117         (WebCore::KCanvasFEImage::externalRepresentation):
2118         (WebCore::KCanvasFEMerge::externalRepresentation):
2119         (WebCore::KCanvasFEMorphology::externalRepresentation):
2120         (WebCore::KCanvasFEOffset::externalRepresentation):
2121         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
2122         (WebCore::KCanvasFETile::externalRepresentation):
2123         (WebCore::KCanvasFETurbulence::externalRepresentation):
2124         * kcanvas/KCanvasFilters.h:
2125         (WebCore::KCanvasFEDiffuseLighting::lightSource):
2126         (WebCore::KCanvasFESpecularLighting::lightSource):
2127         * kcanvas/KCanvasImage.h:
2128         * kcanvas/KCanvasMarker.cpp:
2129         (WebCore::KCanvasMarker::externalRepresentation):
2130         * kcanvas/KCanvasMarker.h:
2131         * kcanvas/KCanvasResource.cpp:
2132         (WebCore::operator<<):
2133         * kcanvas/KCanvasResource.h:
2134         * kcanvas/KCanvasTreeDebug.cpp:
2135         (WebCore::operator<<):
2136         (WebCore::writeIndent):
2137         (WebCore::writeStyle):
2138         (WebCore::write):
2139         (WebCore::writeRenderResources):
2140         * kcanvas/KCanvasTreeDebug.h:
2141         (WebCore::operator<<):
2142         * kcanvas/RenderForeignObject.cpp:
2143         (WebCore::RenderForeignObject::paint):
2144         * kcanvas/RenderPath.cpp:
2145         (WebCore::RenderPath::paint):
2146         (WebCore::drawStartAndMidMarkers):
2147         * kcanvas/RenderSVGContainer.cpp:
2148         (WebCore::RenderSVGContainer::paint):
2149         * kcanvas/RenderSVGImage.cpp:
2150         (WebCore::RenderSVGImage::translateForAttributes):
2151         * kcanvas/RenderSVGImage.h:
2152         * kcanvas/device/KRenderingDevice.cpp:
2153         (WebCore::KRenderingDevice::currentContext):
2154         (WebCore::KRenderingDevice::popContext):
2155         (WebCore::KRenderingDevice::pushContext):
2156         * kcanvas/device/KRenderingDevice.h:
2157         * kcanvas/device/KRenderingFillPainter.h:
2158         * kcanvas/device/KRenderingPaintServer.h:
2159         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2160         (WebCore::KRenderingPaintServer::activeClient):
2161         (WebCore::KRenderingPaintServer::setActiveClient):
2162         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2163         (WebCore::operator<<):
2164         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
2165         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
2166         (WebCore::KRenderingPaintServerGradient::listener):
2167         (WebCore::KRenderingPaintServerGradient::setListener):
2168         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
2169         * kcanvas/device/KRenderingPaintServerGradient.h:
2170         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2171         (WebCore::KRenderingPaintServerPattern::tile):
2172         (WebCore::KRenderingPaintServerPattern::setTile):
2173         (WebCore::KRenderingPaintServerPattern::listener):
2174         (WebCore::KRenderingPaintServerPattern::setListener):
2175         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
2176         * kcanvas/device/KRenderingPaintServerPattern.h:
2177         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2178         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
2179         * kcanvas/device/KRenderingPaintServerSolid.h:
2180         * kcanvas/device/KRenderingStrokePainter.cpp:
2181         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2182         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2183         * kcanvas/device/KRenderingStrokePainter.h:
2184         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2185         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2186         (WebCore::KCanvasFilterQuartz::prepareFilter):
2187         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2188         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2189         (WebCore::KCanvasMaskerQuartz::applyMask):
2190         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2191         (WebCore::KCanvasImageQuartz::init):
2192         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2193         (WebCore::KCanvasClipperQuartz::applyClip):
2194         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2195         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2196         (WebCore::KRenderingDeviceQuartz::quartzContext):
2197         (WebCore::KRenderingDeviceQuartz::contextForImage):
2198         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2199         (WebCore::KRenderingDeviceQuartz::createResource):
2200         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2201         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2202         (WebCore::CGShadingRefForLinearGradient):
2203         (WebCore::CGShadingRefForRadialGradient):
2204         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2205         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2206         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2207         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2208         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
2209         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
2210         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
2211         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
2212         (WebCore::KRenderingPaintServerSolidQuartz::draw):
2213         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2214         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2215         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2216         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2217         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
2218         * kcanvas/device/quartz/QuartzSupport.h:
2219         * kcanvas/device/quartz/QuartzSupport.mm:
2220         (WebCore::applyStrokeStyleToContext):
2221
2222 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2223
2224         Reviewed by Dave Hyatt.
2225
2226         * dom/WheelEvent.cpp:
2227         (WebCore::WheelEvent::WheelEvent):
2228         Use lroundf instead of lround since deltas are floats.
2229
2230 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
2231
2232         Reviewed by eseidel.  Landed by eseidel.
2233
2234         Test: svg/custom/pattern-y-offset.svg
2235
2236         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2237         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2238
2239 2006-09-20  David Hyatt  <hyatt@apple.com>
2240
2241         Add a new wheelEvent method to ScrollView.  Platforms that wish
2242         to handle the wheel event for the scroll view themselves can then
2243         do so there.  (Mac lets the underlying NSScrollView do it for now.)
2244
2245         * page/FrameView.cpp:
2246         (WebCore::FrameView::handleWheelEvent):
2247         * platform/ScrollView.h:
2248         (WebCore::ScrollView::wheelEvent):
2249
2250 2006-09-20  Brady Eidson  <beidson@apple.com>
2251
2252         Reviewed by Tim Omernick
2253
2254         Part of fixing a crash Tim O showed me that I missed in a release build.
2255         WebKit should be able to call through the bridge to WebCore no matter what -
2256         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
2257
2258         * bridge/mac/WebCoreIconDatabaseBridge.h:
2259         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2260         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2261         (-[WebCoreIconDatabaseBridge isOpen]):
2262         (-[WebCoreIconDatabaseBridge removeAllIcons]):
2263         (-[WebCoreIconDatabaseBridge _isEmpty]):
2264         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2265         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2266         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2267         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2268         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2269         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2270         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2271         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2272         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2273         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2274         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2275         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
2276         (-[WebCoreIconDatabaseBridge _setEnabled:]):
2277         (-[WebCoreIconDatabaseBridge _isEnabled]):
2278
2279 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2280
2281         Reviewed by Darin.
2282
2283         Add String::split which returns a Vector of Strings and use it instead of
2284         DeprecatedStringList.
2285
2286         * bindings/js/kjs_events.cpp:
2287         (KJS::Clipboard::getValueProperty):
2288         * bindings/js/kjs_window.cpp:
2289         (KJS::parseModalDialogFeatures):
2290         * css/MediaList.cpp:
2291         (WebCore::MediaList::setMediaText):
2292         * dom/Clipboard.h:
2293         * html/HTMLFormElement.cpp:
2294         (WebCore::HTMLFormElement::formData):
2295         * html/HTMLLinkElement.cpp:
2296         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2297         * platform/PlatformString.h:
2298         * platform/String.cpp:
2299         (WebCore::String::split):
2300         * platform/StringImpl.cpp:
2301         * platform/StringImpl.h:
2302         * platform/mac/ClipboardMac.h:
2303         * platform/mac/ClipboardMac.mm:
2304         (WebCore::ClipboardMac::types):
2305
2306 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2307
2308         Reviewed by harrison
2309
2310         * css/cssstyleselector.cpp:
2311         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
2312         HTMLElement::isContentEditable just to check the Frame's editability, since
2313         it calls updateRenderering, which can get us into infinite recursion.
2314
2315 2006-09-20  Brady Eidson  <beidson@apple.com>
2316
2317         Reviewed by Darin
2318
2319         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2320
2321         * loader/icon/IconDatabase.cpp:
2322         (WebCore::IconDatabase::IconDatabase): Disabled by default
2323         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2324         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2325         (WebCore::IconDatabase::iconForPageURL): Ditto
2326         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2327         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2328         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2329         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2330         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2331         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2332         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2333         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2334
2335 2006-09-20  Adam Roben  <aroben@apple.com>
2336
2337         Reviewed by Adele.
2338
2339         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2340         REGRESSION: file upload control with direction:rtl or text-align:right
2341         draws button on top of filename/icon
2342
2343         * rendering/RenderFileUploadControl.cpp:
2344         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2345         match direction
2346         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2347         the filename and icon in RTL
2348
2349 2006-09-20  Alice Liu  <alice.liu@apple.com>
2350
2351         Reviewed by Adam Roben.
2352
2353         fixed windows build
2354
2355         * dom/WheelEvent.cpp:
2356         (WebCore::WheelEvent::WheelEvent):
2357         changed lrint to lround
2358
2359 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2360
2361         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2362         for the Objective-C bindings.  If it is found that isHorizontal
2363         is not used, we should remove it again but also remove it's
2364         declaration from PublicDOMInterfaces.h
2365
2366         * dom/WheelEvent.h:
2367         (WebCore::WheelEvent::isHorizontal):
2368         * dom/WheelEvent.idl:
2369
2370 2006-09-20  David Hyatt  <hyatt@apple.com>
2371
2372         Fix for 10945, WheelEvent should support two dimensions at once, since
2373         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2374         to allow for diagonal scrolling.
2375
2376         Reviewed by Eric
2377
2378         * dom/EventTargetNode.cpp:
2379         (WebCore::EventTargetNode::dispatchWheelEvent):
2380         * dom/WheelEvent.cpp:
2381         (WebCore::WheelEvent::WheelEvent):
2382         (WebCore::WheelEvent::initWheelEvent):
2383         * dom/WheelEvent.h:
2384         (WebCore::WheelEvent::wheelDelta):
2385         (WebCore::WheelEvent::wheelDeltaX):
2386         (WebCore::WheelEvent::wheelDeltaY):
2387         * dom/WheelEvent.idl:
2388         * page/FrameView.cpp:
2389         (WebCore::FrameView::handleWheelEvent):
2390         * platform/PlatformWheelEvent.h:
2391         (WebCore::PlatformWheelEvent::deltaX):
2392         (WebCore::PlatformWheelEvent::deltaY):
2393         (WebCore::PlatformWheelEvent::normalize):
2394         * platform/mac/WheelEventMac.mm:
2395         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2396
2397 2006-09-19  Eric Seidel  <eric@eseidel.com>
2398
2399         Reviewed by hyatt.
2400
2401         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2402
2403         No tests were harmed in the making of this patch.
2404
2405         * WebCore.xcodeproj/project.pbxproj:
2406         * kcanvas/KCanvasClipper.cpp: Added.
2407         (WebCore::operator<<):
2408         * kcanvas/KCanvasClipper.h: Added.
2409         * kcanvas/KCanvasFilters.h:
2410         * kcanvas/KCanvasImage.h:
2411         * kcanvas/KCanvasMarker.cpp: Added.
2412         * kcanvas/KCanvasMarker.h: Added.
2413         * kcanvas/KCanvasMasker.cpp: Added.
2414         (WebCore::KCanvasMasker::KCanvasMasker):
2415         (WebCore::KCanvasMasker::setMask):
2416         (WebCore::KCanvasMasker::externalRepresentation):
2417         (WebCore::getMaskerById):
2418         * kcanvas/KCanvasMasker.h: Added.
2419         * kcanvas/KCanvasResource.cpp: Added.
2420         (WebCore::KCanvasResource::invalidate):
2421         (WebCore::KCanvasResource::externalRepresentation):
2422         (WebCore::getResourceById):
2423         (WebCore::getPaintServerById):
2424         * kcanvas/KCanvasResource.h: Added.
2425         * kcanvas/KCanvasResources.cpp: Removed.
2426         * kcanvas/KCanvasResources.h: Removed.
2427         * kcanvas/RenderPath.cpp:
2428         * kcanvas/RenderSVGContainer.cpp:
2429         * kcanvas/RenderSVGImage.cpp:
2430         * kcanvas/RenderSVGText.cpp:
2431         * kcanvas/device/KRenderingPaintServer.h:
2432         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2433         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2434         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2435         * ksvg2/svg/SVGClipPathElement.h:
2436         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2437         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2438         * ksvg2/svg/SVGFECompositeElement.cpp:
2439         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2440         * ksvg2/svg/SVGFELightElement.cpp:
2441         * ksvg2/svg/SVGFEOffsetElement.cpp:
2442         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2443         * ksvg2/svg/SVGFilterElement.cpp:
2444         * ksvg2/svg/SVGLinearGradientElement.cpp:
2445         * ksvg2/svg/SVGMarkerElement.h:
2446         * ksvg2/svg/SVGMaskElement.h:
2447
2448 2006-09-19  Brady Eidson <beidson@apple.com>
2449
2450         Reviewed by Sarge Decker
2451
2452         <rdar://problem/4739892> and <rdar://problem/4729797>
2453         - WebCore::IconDatabase needs to have and respect an enabled() flag
2454         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2455
2456         * bridge/mac/WebCoreIconDatabaseBridge.h:
2457         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2458         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2459         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2460         * loader/icon/IconDatabase.cpp:
2461         (WebCore::IconDatabase::IconDatabase):
2462         (WebCore::IconDatabase::open): Don't open if disabled
2463         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2464         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2465         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2466         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2467         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2468         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2469         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2470         (WebCore::IconDatabase::releaseIconURL):
2471         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2472         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2473         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2474         (WebCore::IconDatabase::setEnabled): Added
2475         * loader/icon/IconDatabase.h:
2476         (WebCore::IconDatabase::enabled): Added
2477         * page/Frame.cpp:
2478         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2479         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2480
2481 2006-09-20  David Hyatt  <hyatt@apple.com>
2482
2483         Massage mouse wheel handling so that it is more cross-platform.  Make
2484         all the work happen in handleWheelEvent on the FrameView.
2485
2486         Reviewed by bradee-oh
2487
2488         * bridge/mac/FrameMac.mm:
2489         (WebCore::FrameMac::wheelEvent):
2490         * page/FrameView.cpp:
2491         (WebCore::FrameView::handleWheelEvent):
2492         * platform/PlatformWheelEvent.h:
2493         (WebCore::PlatformWheelEvent::platformDelta):
2494         (WebCore::PlatformWheelEvent::delta):
2495         * platform/mac/WheelEventMac.mm:
2496         (WebCore::platformDeltaForEvent):
2497         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2498         * rendering/RenderLayer.cpp:
2499         (WebCore::RenderLayer::scroll):
2500         * rendering/RenderObject.cpp:
2501         (WebCore::RenderObject::scroll):
2502
2503 2006-09-19  Eric Seidel  <eric@eseidel.com>
2504
2505         Reviewed by adele.
2506
2507         Improve test output for filters with bounding-box relative sizes.
2508         http://bugs.webkit.org/show_bug.cgi?id=8585
2509
2510         Many test results updated.
2511
2512         * kcanvas/KCanvasFilters.cpp:
2513         (WebCore::KCanvasFilter::externalRepresentation):
2514
2515 2006-09-19  Eric Seidel  <eric@eseidel.com>
2516
2517         Reviewed by adele.
2518
2519         Markers should clip to their viewport.
2520         http://bugs.webkit.org/show_bug.cgi?id=5967
2521
2522         Test: svg/custom/marker-overflow-clip.svg
2523
2524         * kcanvas/KCanvasResources.cpp:
2525         (WebCore::KCanvasMarker::KCanvasMarker):
2526         (WebCore::KCanvasMarker::setMarker):
2527         (WebCore::KCanvasMarker::draw):
2528         * kcanvas/KCanvasResources.h:
2529         (WebCore::KCanvasMasker::mask):
2530         * ksvg2/svg/SVGMarkerElement.cpp:
2531         (WebCore::SVGMarkerElement::SVGMarkerElement):
2532         (WebCore::SVGMarkerElement::parseMappedAttribute):
2533         (WebCore::SVGMarkerElement::canvasResource):
2534         (WebCore::SVGMarkerElement::createRenderer):
2535
2536 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2537
2538         Reviewed by eseidel
2539
2540         Backing out my recent change.
2541
2542         * css/cssstyleselector.cpp:
2543         (WebCore::CSSStyleSelector::adjustRenderStyle):
2544
2545 2006-09-19  Brady Eidson  <beidson@apple.com>
2546
2547         Reviewed by Kevin McCullough
2548
2549         http://bugs.webkit.org/show_bug.cgi?id=10940
2550         Opening a PDF in a new tab/window creates a documentless-frame
2551         and we deref the document without checking its validity
2552
2553         * page/Frame.cpp:
2554         (WebCore::Frame::iconURL):
2555
2556 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2557
2558         Reviewed by harrison
2559
2560         <rdar://problem/4735272>
2561         Can not click into link in programmatically editable content
2562
2563         * css/cssstyleselector.cpp:
2564         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
2565         userModify to implement document wide editability.
2566
2567 2006-09-19  MorganL  <morlmor@yahoo.com>
2568
2569         Reviewed by Darin and landed by Brady
2570
2571         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
2572         Build broken when SVG is not enabled.
2573
2574         * dom/XMLTokenizer.cpp:
2575         (WebCore::XMLTokenizer::startElementNs):
2576
2577 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2578
2579         Reviewed by harrison
2580
2581         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
2582
2583         Pasting plain text results in a match style paste, and the insertion
2584         position is whitespace normal, which clobbers the whitespace:pre on
2585         tab spans.  Skip changes to the whitespace mode when computing a style
2586         change for tab spans or the text nodes inside tab spans.
2587
2588         * editing/ApplyStyleCommand.cpp:
2589         (WebCore::StyleChange::init): Don't change the whitespace mode inside
2590         tab spans.
2591
2592 2006-09-19  David Hyatt  <hyatt@apple.com>
2593
2594         Fix for bug 5298, shape=default not supported for image maps.  Implement
2595         support for it.
2596
2597         Reviewed by timo
2598
2599         * html/HTMLAreaElement.cpp:
2600         (WebCore::HTMLAreaElement::getRegion):
2601         * html/HTMLMapElement.cpp:
2602         (WebCore::HTMLMapElement::mapMouseEvent):
2603
2604 2006-09-19  Adam Roben  <aroben@apple.com>
2605
2606         Reviewed by Adele.
2607
2608         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
2609         "no file selected" placeholder text missing from file upload control
2610
2611         * WebCore.xcodeproj/project.pbxproj:
2612         * rendering/RenderFileUploadControl.cpp: Remove class
2613         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
2614         defaultWidthNumChars
2615         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
2616         RenderBlock constructor instead of RenderFlexibleBox,
2617         (WebCore::RenderFileUploadControl::setStyle): Remove references to
2618         m_fileBox.
2619         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
2620         instead of updateIconAndFileName() (which has been removed)
2621         (WebCore::RenderFileUploadControl::updateFromElement): Remove
2622         references to m_fileBox, don't call updateIconAndFilename()
2623         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
2624         without using m_fileBox
2625         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
2626         now-unnecessary display:box rule.
2627         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
2628         to paintingDisabled() now that Icon::paint() does it, and add code to
2629         paint the filename directly.
2630         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
2631         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
2632         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
2633         subclass of RenderBlock instead of RenderFlexibleBox, remove
2634         updateIconAndFilename() method, remove m_fileBox instance variable.
2635
2636 2006-09-19  Eric Seidel  <eric@eseidel.com>
2637
2638         Reviewed by hyatt.
2639
2640         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
2641         http://bugs.webkit.org/show_bug.cgi?id=10846
2642
2643         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
2644
2645         * dom/XMLTokenizer.cpp:
2646         (WebCore::XMLTokenizer::XMLTokenizer):
2647         (WebCore::XMLTokenizer::startElementNs):
2648         (WebCore::XMLTokenizer::endElementNs):
2649
2650 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2651
2652         Reviewed by eseidel.  Landed by eseidel.
2653
2654         Build fix only, no tests affected.
2655
2656         * platform/gdk/FontPlatformDataGdk.cpp:
2657         (WebCore::FontPlatformData::FontPlatformData):
2658         (WebCore::FontPlatformData::~FontPlatformData):
2659         * platform/gdk/FrameGdk.h:
2660         * platform/gdk/TemporaryLinkStubs.cpp:
2661         (FrameGdk::isLoadTypeReload):
2662         (FrameGdk::originalRequestURL):
2663         (IconDatabase::setIconURLForPageURL):
2664
2665 2006-09-19  David Hyatt  <hyatt@apple.com>
2666
2667         Refine the fix for 9805 to really get all the complex cases right.
2668
2669         Reviewed by Eric
2670
2671         * rendering/RenderBlock.cpp:
2672         (WebCore::RenderBlock::clearFloatsIfNeeded):
2673         (WebCore::RenderBlock::handleBottomOfBlock):
2674
2675 2006-09-18  David Hyatt  <hyatt@apple.com>
2676
2677         Fix for 9805, <hr> not positioned properly following a previous empty sibling
2678         that had clear:both set on it.  Update self-collapsing block clearance
2679         behavior to match what is specified in the latest draft of CSS2.1.
2680
2681         Reviewed by Eric
2682
2683         Added fast/block/margin-collapse/empty-clear-blocks.html
2684
2685         * rendering/RenderBlock.cpp:
2686         (WebCore::RenderBlock::clearFloatsIfNeeded):
2687         (WebCore::RenderBlock::handleBottomOfBlock):
2688
2689 2006-09-18  MorganL  <morlmor@yahoo.com>
2690
2691         Reviewed by Brady, landed by Brady
2692
2693         Send receivedResponse callback to ResourceLoaderClient when loading
2694         file URLs.
2695
2696         See http://bugs.webkit.org/show_bug.cgi?id=10845
2697
2698         * platform/win/ResourceLoaderWin.cpp:
2699         (WebCore::ResourceLoader::fileLoadTimer):
2700
2701 2006-09-18  Brady Eidson  <beidson@apple.com>
2702
2703         Reviewed by Anders
2704
2705         <rdar://problem/3028061> - WebKit never updates favicon
2706         The WebKit enforced expiration date for icons has worked for some time, but the
2707         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
2708         functionality.  This patch fixes that up, along with some other architectural improvements,
2709         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
2710
2711         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
2712         * bridge/mac/FrameMac.mm:
2713         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
2714         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
2715         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
2716         * dom/Document.h: Added m_iconURL
2717         (WebCore::Document::iconURL): Added
2718         (WebCore::Document::setIconURL): Ditto
2719         * html/HTMLLinkElement.cpp:
2720         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
2721         * page/Frame.cpp:
2722         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
2723         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
2724         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
2725         * page/FramePrivate.h: Nuked IconURL
2726         * platform/win/TemporaryLinkStubs.cpp:
2727         (FrameWin::isLoadTypeReload):
2728
2729 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2730
2731         Reviewed by Tim H.
2732
2733         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
2734           it is it turns out that AppKit uses it.
2735
2736         * bindings/objc/DOMPrivate.h:
2737         * bindings/objc/DOMRGBColor.mm:
2738         (-[DOMRGBColor _color]):
2739
2740 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2741
2742         Reviewed by Tim H.
2743
2744         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
2745         Yet Another Objective-C Bindings Patch
2746
2747         - Whitespace cleanup for IDLParser.pm
2748
2749         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
2750           and DOMAbstractView into their own files.
2751
2752         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
2753           it is not used and a public method is available now.
2754
2755         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
2756           as it not used.
2757
2758         - Auto-generate method isContentEditable for DOMNode.
2759
2760         - General cleanup of bindings code including removing unneeded #imports
2761           and whitespace cleanup
2762
2763         * WebCore.xcodeproj/project.pbxproj:
2764         * bindings/objc/DOM.mm:
2765         (addElementClass):
2766         (elementClass):
2767         (-[DOMNode _initWithNode:WebCore::]):
2768         (+[DOMNode _nodeWith:WebCore::]):
2769         (-[DOMNode WebCore::]):
2770         (-[DOMNode KJS::Bindings::]):
2771         (-[DOMNode addEventListener:::]):
2772         (-[DOMNode removeEventListener:::]):
2773         (-[DOMNode dispatchEvent:]):
2774         (-[DOMElement image]):
2775         (-[DOMElement _font]):
2776         (-[DOMElement _imageTIFFRepresentation]):
2777         (-[DOMElement _getURLAttribute:]):
2778         (-[DOMElement _NPObject]):
2779         (-[DOMElement isFocused]):
2780         (-[DOMRange dealloc]):
2781         (-[DOMRange finalize]):
2782         (-[DOMRange description]):
2783         (-[DOMRange startContainer]):
2784         (-[DOMRange startOffset]):
2785         (-[DOMRange endContainer]):
2786         (-[DOMRange endOffset]):
2787         (-[DOMRange collapsed]):
2788         (-[DOMRange commonAncestorContainer]):
2789         (-[DOMRange setStart::]):
2790         (-[DOMRange setEnd::]):
2791         (-[DOMRange setStartBefore:]):
2792         (-[DOMRange setStartAfter:]):
2793         (-[DOMRange setEndBefore:]):
2794         (-[DOMRange setEndAfter:]):
2795         (-[DOMRange collapse:]):
2796         (-[DOMRange selectNode:]):
2797         (-[DOMRange selectNodeContents:]):
2798         (-[DOMRange compareBoundaryPoints::]):
2799         (-[DOMRange deleteContents]):
2800         (-[DOMRange extractContents]):
2801         (-[DOMRange cloneContents]):
2802         (-[DOMRange insertNode:]):
2803         (-[DOMRange surroundContents:]):
2804         (-[DOMRange cloneRange]):
2805         (-[DOMRange toString]):
2806         (-[DOMRange detach]):
2807         (-[DOMRange _initWithRange:WebCore::]):
2808         (+[DOMRange _rangeWith:WebCore::]):
2809         (-[DOMRange WebCore::]):
2810         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2811         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2812         (-[DOMNodeFilter WebCore::]):
2813         (-[DOMNodeFilter dealloc]):
2814         (-[DOMNodeFilter finalize]):
2815         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2816         (-[DOMNodeIterator WebCore::]):
2817         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
2818         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2819         (-[DOMTreeWalker WebCore::]):
2820         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
2821         (ObjCNodeFilterCondition::acceptNode):
2822         (-[DOMDocument createNodeIterator::::]):
2823         (-[DOMDocument createTreeWalker::::]):
2824         (ObjCEventListener::find):
2825         (ObjCEventListener::create):
2826         (ObjCEventListener::handleEvent):
2827         * bindings/objc/DOMAbstractView.h: Added.
2828         * bindings/objc/DOMAbstractView.mm: Added.
2829         (-[DOMAbstractView document]):
2830         (-[DOMAbstractView WebCore::]):
2831         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2832         (+[DOMAbstractView _abstractViewWith:WebCore::]):
2833         * bindings/objc/DOMCSS.mm:
2834         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2835         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2836         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
2837         (-[DOMCSSRule _initWithRule:WebCore::]):
2838         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2839         (-[DOMCSSValue _initWithValue:WebCore::]):
2840         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2841         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
2842         (-[DOMDocument getComputedStyle::]):
2843         (-[DOMDocument getMatchedCSSRules::]):
2844         * bindings/objc/DOMCore.h:
2845         * bindings/objc/DOMEventException.h: Added.
2846         * bindings/objc/DOMEvents.h:
2847         * bindings/objc/DOMEvents.mm:
2848         * bindings/objc/DOMException.h: Added.
2849         * bindings/objc/DOMHTML.mm:
2850         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
2851         (viewForElement):
2852         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2853         (-[DOMHTMLInputElement _selectedRange]):
2854         (-[DOMHTMLInputElement _setAutofilled:]):
2855         * bindings/objc/DOMInternal.h:
2856         * bindings/objc/DOMObject.h:
2857         * bindings/objc/DOMPrivate.h:
2858         * bindings/objc/DOMRange.h:
2859         * bindings/objc/DOMRangeException.h: Added.
2860         * bindings/objc/DOMViews.h:
2861         * bindings/objc/DOMViews.mm: Removed.
2862         * bindings/objc/DOMXPath.h:
2863         * bindings/objc/DOMXPathException.h: Added.
2864         * bindings/scripts/IDLParser.pm:
2865         * dom/Node.idl:
2866
2867 2006-09-18  Brady Eidson  <beidson@apple.com>
2868
2869         Windows build fix
2870
2871         * platform/win/TemporaryLinkStubs.cpp:
2872         (IconDatabase::setIconURLForPageURL):
2873
2874 2006-09-18  David Hyatt  <hyatt@apple.com>
2875
2876         Fix for bug 3969, hr width doesn't update when it clears a float.  This
2877         was also a problem with tables and overflow sections.
2878
2879         Reviewed by Eric
2880
2881         Added fast/block/float/width-update-after-clear.html
2882
2883         * rendering/RenderBlock.cpp:
2884         (WebCore::RenderBlock::collapseMargins):
2885         (WebCore::RenderBlock::clearFloatsIfNeeded):
2886
2887 2006-09-18  Brady Eidson  <beidson@apple.com>
2888
2889         Reviewed by John
2890
2891         http://bugs.webkit.org/show_bug.cgi?id=10907
2892         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
2893
2894         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
2895         * bridge/win/FrameWin.h: Added originalRequestURL()
2896         * loader/icon/IconLoader.cpp:
2897         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
2898         * page/Frame.cpp:
2899         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
2900         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
2901         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
2902         * page/Frame.h: Added pure virtual originalRequestURL()
2903         * platform/win/TemporaryLinkStubs.cpp:
2904         (FrameWin::originalRequestURL): Added
2905
2906 2006-09-18  Rob Buis  <buis@kde.org>
2907
2908         Reviewed by Maciej.
2909
2910         http://bugs.webkit.org/show_bug.cgi?id=10807
2911         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
2912
2913         Make sure the paint method is not exited without popping
2914         context and transparency layer.
2915
2916         WARNING: NO TEST CASES ADDED OR CHANGED
2917
2918         * kcanvas/RenderSVGImage.cpp:
2919         (WebCore::RenderSVGImage::paint):
2920
2921 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
2922
2923         Reviewed by Eric.
2924
2925         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
2926         REGRESSION: WebKit can't be built with SVG disabled
2927
2928         * bindings/scripts/CodeGeneratorObjC.pm:
2929         For each file generated add a #ifdef <something>_SUPPORT / #endif
2930         pair if the idl file has a Conditional extended attribute
2931
2932 2006-09-17  Eric Seidel  <eric@eseidel.com>
2933
2934         Reviewed by ap.
2935
2936         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
2937         http://bugs.webkit.org/show_bug.cgi?id=10813
2938
2939         * bridge/mac/WebCoreFrameBridge.mm:
2940         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
2941
2942 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2943
2944         Reviewed by Hyatt.
2945
2946         http://bugs.webkit.org/show_bug.cgi?id=10779
2947         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
2948
2949         No test possible.
2950
2951         * platform/Image.cpp:
2952         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
2953         maybe the rest just hasn't been loaded yet.
2954         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
2955         to start animating before we get at least two frames.
2956
2957 2006-09-17  Brady Eidson <beidson@apple.com>
2958
2959         Reviewed by Sarge
2960
2961         IconLoader now gracefully handles the condition where there's no document in the frame
2962         (ie. PDFs)
2963
2964         * loader/icon/IconLoader.cpp:
2965         (IconLoader::startLoading):
2966
2967 2006-09-17  David Hyatt  <hyatt@apple.com>
2968
2969         Fix for bug 10899, rework how CSS keywords work to be smarter about
2970         using the correct size when generic families change (e.g., monospace to
2971         serif and vice versa).
2972
2973         Reviewed by aroben
2974
2975         Added fast/text/basic/generic-family-changes.html
2976
2977         * css/cssstyleselector.cpp:
2978         (WebCore::CSSStyleSelector::applyProperty):
2979         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2980         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2981         * css/cssstyleselector.h:
2982         * dom/Document.cpp:
2983         (WebCore::Document::recalcStyle):
2984         * platform/FontDescription.h:
2985         (WebCore::FontDescription::FontDescription):
2986         (WebCore::FontDescription::keywordSize):
2987         (WebCore::FontDescription::setKeywordSize):
2988         (WebCore::FontDescription::operator==):
2989
2990 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2991
2992         Reviewed by Brady.
2993
2994         http://bugs.webkit.org/show_bug.cgi?id=10852
2995         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
2996
2997         Test: http/tests/xmlhttprequest/xhr-onunload.html
2998
2999         * xml/xmlhttprequest.cpp:
3000         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
3001
3002         * loader/icon/IconLoader.cpp:
3003         (IconLoader::startLoading): Fix a similar latent bug here.
3004
3005 2006-09-17  Adam Roben  <aroben@apple.com>
3006
3007         Build fix.
3008
3009         * loader/icon/IconDatabase.cpp:
3010
3011 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
3012
3013         Reviewed by Brady.
3014
3015         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
3016         Change the XSLT Parameter Map to use Strings instead of StringImpls.
3017         General cleanup.
3018
3019         * bindings/js/JSXSLTProcessor.cpp:
3020         (KJS::XSLTProcessorProtoFunc::callAsFunction):
3021         * bindings/js/kjs_events.cpp:
3022         (KJS::JSAbstractEventListener::handleEvent):
3023         * bindings/js/kjs_window.cpp:
3024         (KJS::ScheduledAction::execute):
3025         * css/MediaList.cpp:
3026         (WebCore::MediaList::setMediaText):
3027         * dom/Document.cpp:
3028         (WebCore::Document::processHttpEquiv):
3029         * editing/ApplyStyleCommand.cpp:
3030         (WebCore::StyleChange::init):
3031         * html/HTMLDocument.cpp:
3032         (WebCore::parseDocTypeDeclaration):
3033         * html/HTMLLinkElement.cpp:
3034         (WebCore::HTMLLinkElement::parseMappedAttribute):
3035         * html/HTMLObjectElement.cpp:
3036         (WebCore::HTMLObjectElement::HTMLObjectElement):
3037         (WebCore::HTMLObjectElement::parseMappedAttribute):
3038         (WebCore::HTMLObjectElement::attach):
3039         (WebCore::HTMLObjectElement::setComplete):
3040         (WebCore::HTMLObjectElement::detach):
3041         (WebCore::HTMLObjectElement::recalcStyle):
3042         (WebCore::HTMLObjectElement::childrenChanged):
3043         (WebCore::HTMLObjectElement::isImageType):
3044         * html/HTMLObjectElement.h:
3045         * html/HTMLOptionElement.cpp:
3046         (WebCore::HTMLOptionElement::value):
3047         * html/HTMLSelectElement.cpp:
3048         (WebCore::HTMLSelectElement::appendFormData):
3049         * html/HTMLTokenizer.cpp:
3050         (WebCore::HTMLTokenizer::parseTag):
3051         * ksvg2/svg/SVGColor.cpp:
3052         (WebCore::SVGColor::setRGBColor):
3053         * ksvg2/svg/SVGDescElement.cpp:
3054         (WebCore::SVGDescElement::description):
3055         * platform/PlatformString.h:
3056         * platform/String.cpp:
3057         (WebCore::String::stripWhiteSpace):
3058         (WebCore::String::simplifyWhiteSpace):
3059         * platform/StringImpl.cpp:
3060         (WebCore::isSpace):
3061         (WebCore::parseLength):
3062         (WebCore::StringImpl::stripWhiteSpace):
3063         (WebCore::StringImpl::simplifyWhiteSpace):
3064         (WebCore::StringImpl::toInt):
3065         * platform/StringImpl.h:
3066         * platform/mac/ClipboardMac.mm:
3067         (WebCore::cocoaTypeFromMIMEType):
3068         * rendering/RenderPartObject.cpp:
3069         (WebCore::RenderPartObject::updateWidget):
3070         * xml/XPathFunctions.cpp:
3071         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
3072         * xml/XPathGrammar.y:
3073         * xml/XPathStep.cpp:
3074         (WebCore::XPath::Step::nodeTestMatches):
3075         * xml/XSLStyleSheet.cpp:
3076         (WebCore::XSLStyleSheet::loadChildSheets):
3077         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
3078         * xml/XSLTProcessor.cpp:
3079         (WebCore::xsltParamArrayFromParameterMap):
3080         (WebCore::XSLTProcessor::setParameter):
3081         (WebCore::XSLTProcessor::getParameter):
3082         (WebCore::XSLTProcessor::removeParameter):
3083         * xml/XSLTProcessor.h:
3084         * xml/xmlhttprequest.cpp:
3085         (WebCore::XMLHttpRequest::getStatusText):
3086
3087 2006-09-17  David Hyatt  <hyatt@apple.com>
3088
3089         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
3090         are declared right before the fieldsets.  It turns out fieldsets in other
3091         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
3092         adding that behavior to fieldset fixes the bug.
3093
3094         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
3095         and fieldsets all subclass.
3096
3097         Reviewed by anders
3098
3099         Added fast/forms/float-before-fieldset.html
3100
3101         * rendering/RenderFieldset.h:
3102         (WebCore::RenderFieldset::avoidsFloats):
3103         * rendering/RenderFlexibleBox.h:
3104         (WebCore::RenderFlexibleBox::avoidsFloats):
3105         * rendering/RenderObject.cpp:
3106         (WebCore::RenderObject::avoidsFloats):
3107         * rendering/RenderObject.h:
3108         * rendering/RenderTable.h:
3109         (WebCore::RenderTable::avoidsFloats):
3110
3111 2006-09-17  David Hyatt  <hyatt@apple.com>
3112
3113         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
3114         "rules" attributes on tables.
3115
3116         Reviewed by bradee-oh
3117
3118         Well-covered by existing layout tests.
3119
3120         * html/HTMLTableCellElement.cpp:
3121         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
3122         * html/HTMLTableColElement.cpp:
3123         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
3124         * html/HTMLTableColElement.h:
3125         * html/HTMLTableElement.cpp:
3126         (WebCore::HTMLTableElement::HTMLTableElement):
3127         (WebCore::HTMLTableElement::~HTMLTableElement):
3128         (WebCore::HTMLTableElement::setCaption):
3129         (WebCore::HTMLTableElement::setTHead):
3130         (WebCore::HTMLTableElement::setTFoot):
3131         (WebCore::HTMLTableElement::setTBody):
3132         (WebCore::HTMLTableElement::createTHead):
3133         (WebCore::HTMLTableElement::deleteTHead):
3134         (WebCore::HTMLTableElement::createTFoot):
3135         (WebCore::HTMLTableElement::deleteTFoot):
3136         (WebCore::HTMLTableElement::createCaption):
3137         (WebCore::HTMLTableElement::deleteCaption):
3138         (WebCore::HTMLTableElement::insertRow):
3139         (WebCore::HTMLTableElement::deleteRow):
3140         (WebCore::HTMLTableElement::addChild):
3141         (WebCore::HTMLTableElement::childrenChanged):
3142         (WebCore::HTMLTableElement::mapToEntry):
3143         (WebCore::HTMLTableElement::parseMappedAttribute):
3144         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
3145         (WebCore::HTMLTableElement::getSharedCellDecl):
3146         (WebCore::HTMLTableElement::getSharedGroupDecl):
3147         (WebCore::HTMLTableElement::attach):
3148         * html/HTMLTableElement.h:
3149         (WebCore::HTMLTableElement::caption):
3150         (WebCore::HTMLTableElement::tHead):
3151         (WebCore::HTMLTableElement::tFoot):
3152         (WebCore::HTMLTableElement::):
3153         * html/HTMLTableRowElement.h:
3154         * html/HTMLTableSectionElement.cpp:
3155         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
3156         * html/HTMLTableSectionElement.h:
3157
3158 2006-09-17  David Hyatt  <hyatt@apple.com>
3159
3160         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
3161         specify their own new font-family list.  Make sure to always
3162         reset the generic family along with the family list when mapping in
3163         new font-family values.
3164
3165         Reviewed by bradee-oh
3166
3167         fast/text/basic/generic-family-reset.html
3168
3169         * css/cssstyleselector.cpp:
3170         (WebCore::CSSStyleSelector::applyProperty):
3171
3172 2006-09-16  Brady Eidson <beidson@apple.com>
3173
3174         Reviewed by Hyatt
3175
3176         Pruning code relating to WebKit's icon loader
3177
3178         * bridge/mac/WebCoreIconDatabaseBridge.h:
3179         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3180         * loader/icon/IconDatabase.h:
3181         * page/Frame.cpp:
3182         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
3183         its new home
3184
3185 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3186
3187         Reviewed by Tim H.
3188
3189         Patch for http://bugs.webkit.org/show_bug.cgi?id=10885
3190         Auto-generate DOMHTMLDocument for the Objective-C bindings
3191
3192         * DerivedSources.make:
3193         * WebCore.xcodeproj/project.pbxproj:
3194         * bindings/objc/DOMExtensions.h:
3195         * bindings/objc/DOMHTML.mm:
3196         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
3197         * bindings/objc/DOMHTMLDocument.h: Removed.
3198         * bindings/objc/DOMHTMLDocument.mm: Removed.
3199         * bindings/objc/PublicDOMInterfaces.h:
3200         * bindings/scripts/CodeGeneratorObjC.pm:
3201         * html/HTMLDocument.idl:
3202         * platform/DeprecatedString.h:
3203         (WebCore::DeprecatedString::operator NSString*):
3204
3205 2006-09-16  Rob Buis  <buis@kde.org>
3206
3207         Reviewed by Eric.
3208
3209         http://bugs.webkit.org/show_bug.cgi?id=10866
3210         Code in kcanvas/ should not use Private
3211
3212         Remove Private classes and tweak coding style.
3213
3214         WARNING: NO TEST CASES ADDED OR CHANGED
3215
3216         * kcanvas/RenderPath.cpp:
3217         (WebCore::RenderPath::RenderPath):
3218         (WebCore::RenderPath::~RenderPath):
3219         (WebCore::RenderPath::localTransform):
3220         (WebCore::RenderPath::setLocalTransform):
3221         (WebCore::RenderPath::fillContains):
3222         (WebCore::RenderPath::relativeBBox):
3223         (WebCore::RenderPath::setPath):
3224         (WebCore::RenderPath::path):
3225         (WebCore::RenderPath::layout):
3226         * kcanvas/RenderPath.h:
3227         * kcanvas/RenderSVGContainer.cpp:
3228         (WebCore::RenderSVGContainer::RenderSVGContainer):
3229         (WebCore::RenderSVGContainer::~RenderSVGContainer):
3230         (WebCore::RenderSVGContainer::drawsContents):
3231         (WebCore::RenderSVGContainer::setDrawsContents):
3232         (WebCore::RenderSVGContainer::localTransform):
3233         (WebCore::RenderSVGContainer::setLocalTransform):
3234         (WebCore::RenderSVGContainer::layout):
3235         (WebCore::RenderSVGContainer::paint):
3236         (WebCore::RenderSVGContainer::setViewport):
3237         (WebCore::RenderSVGContainer::viewport):
3238         (WebCore::RenderSVGContainer::setViewBox):
3239         (WebCore::RenderSVGContainer::viewBox):
3240         (WebCore::RenderSVGContainer::setAlign):
3241         (WebCore::RenderSVGContainer::align):
3242         (WebCore::RenderSVGContainer::fillContains):
3243         (WebCore::RenderSVGContainer::strokeContains):
3244         (WebCore::RenderSVGContainer::setSlice):
3245         (WebCore::RenderSVGContainer::slice):
3246         * kcanvas/RenderSVGContainer.h:
3247         * kcanvas/device/KRenderingFillPainter.cpp:
3248         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
3249         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
3250         (WebCore::KRenderingFillPainter::fillRule):
3251         (WebCore::KRenderingFillPainter::setFillRule):
3252         (WebCore::KRenderingFillPainter::opacity):
3253         (WebCore::KRenderingFillPainter::setOpacity):
3254         * kcanvas/device/KRenderingFillPainter.h:
3255         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3256         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
3257         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
3258         (WebCore::KRenderingPaintServerGradient::gradientStops):
3259         (WebCore::KRenderingPaintServerGradient::setGradientStops):
3260         (WebCore::KRenderingPaintServerGradient::spreadMethod):
3261         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
3262         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
3263         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
3264         (WebCore::KRenderingPaintServerGradient::gradientTransform):
3265         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
3266         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
3267         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
3268         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
3269         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
3270         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
3271         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
3272         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
3273         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
3274         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
3275         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
3276         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
3277         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
3278         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
3279         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
3280         (WebCore::KRenderingPaintServerGradient::listener):
3281         (WebCore::KRenderingPaintServerGradient::setListener):
3282         * kcanvas/device/KRenderingPaintServerGradient.h:
3283         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3284         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3285         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3286         (WebCore::KRenderingPaintServerPattern::setBbox):
3287         (WebCore::KRenderingPaintServerPattern::bbox):
3288         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
3289         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
3290         (WebCore::KRenderingPaintServerPattern::tile):
3291         (WebCore::KRenderingPaintServerPattern::setTile):
3292         (WebCore::KRenderingPaintServerPattern::patternTransform):
3293         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
3294         (WebCore::KRenderingPaintServerPattern::listener):
3295         (WebCore::KRenderingPaintServerPattern::setListener):
3296         * kcanvas/device/KRenderingPaintServerPattern.h:
3297         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3298         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
3299         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
3300         (WebCore::KRenderingPaintServerSolid::color):
3301         (WebCore::KRenderingPaintServerSolid::setColor):
3302         * kcanvas/device/KRenderingPaintServerSolid.h:
3303         * kcanvas/device/KRenderingStrokePainter.cpp:
3304         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
3305         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
3306         (WebCore::KRenderingStrokePainter::strokeWidth):
3307         (WebCore::KRenderingStrokePainter::setStrokeWidth):
3308         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3309         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3310         (WebCore::KRenderingStrokePainter::strokeCapStyle):
3311         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
3312         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
3313         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
3314         (WebCore::KRenderingStrokePainter::dashOffset):
3315         (WebCore::KRenderingStrokePainter::setDashOffset):
3316         (WebCore::KRenderingStrokePainter::dashArray):
3317         (WebCore::KRenderingStrokePainter::setDashArray):
3318         (WebCore::KRenderingStrokePainter::opacity):
3319         (WebCore::KRenderingStrokePainter::setOpacity):
3320         (WebCore::KRenderingStrokePainter::dirty):
3321         (WebCore::KRenderingStrokePainter::setDirty):
3322         * kcanvas/device/KRenderingStrokePainter.h:
3323
3324 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
3325
3326         Reviewed by Anders.
3327
3328         http://bugs.webkit.org/show_bug.cgi?id=10887
3329         Fix build error
3330
3331         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
3332
3333 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3334
3335         Reviewed by Anders.
3336
3337         Fix for http://bugs.webkit.org/show_bug.cgi?id=10886
3338         REGRESSION (r16387): Reproducible crash when mousing over HTML document
3339
3340         - Special case method [DOMNode ownerDocument] to call document() instead
3341           or ownerDocument() to return to the old behavior.
3342
3343         * WebCore.xcodeproj/project.pbxproj:
3344         * bindings/scripts/CodeGeneratorObjC.pm:
3345
3346 2006-09-15  Brady Eidson  <beidson@apple.com>
3347
3348         Reviewed by Tim Hatcher
3349
3350         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
3351         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
3352
3353         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
3354         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
3355         (WebCore::IconDatabase::open): Make sure the directory exists
3356
3357 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3358
3359         Reviewed by Brady.
3360
3361         Make new style ObjC methods public API.
3362
3363         * WebCore.xcodeproj/project.pbxproj:
3364         * bindings/objc/DOMPrivate.h:
3365         * bindings/objc/PublicDOMInterfaces.h:
3366
3367 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3368
3369         Reviewed by Tim H.
3370
3371         Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
3372         Auto-generate DOMNode for the Objective-C bindings
3373
3374         * DerivedSources.make:
3375         * WebCore.xcodeproj/project.pbxproj:
3376         * bindings/objc/DOM.mm:
3377         (-[DOMNode boundingBox]):
3378         (-[DOMNode lineBoxRects]):
3379         * bindings/objc/DOMEvents.h:
3380         * bindings/objc/DOMExtensions.h:
3381         * bindings/objc/DOMNode.h: Removed.
3382         * bindings/objc/DOMNode.mm: Removed.
3383         * bindings/objc/PublicDOMInterfaces.h:
3384         * bindings/scripts/CodeGeneratorObjC.pm:
3385         * dom/Node.idl:
3386
3387 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3388
3389         Reviewed by Justin.
3390
3391         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
3392
3393         * bridge/mac/WebCoreFrameBridge.h:
3394         * bridge/mac/WebCoreFrameBridge.mm:
3395         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
3396         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
3397         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
3398         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
3399         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
3400         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
3401         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3402         (-[WebCoreFrameBridge increaseSelectionListLevel]):
3403         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
3404         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
3405         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
3406         (-[WebCoreFrameBridge insertLineBreak]):
3407         (-[WebCoreFrameBridge insertParagraphSeparator]):
3408         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
3409         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
3410         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
3411         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
3412         (createMouseEventFromDraggingInfo):
3413         * editing/SelectionController.cpp:
3414         (WebCore::SelectionController::moveTo):
3415         (WebCore::SelectionController::setSelection):
3416         (WebCore::SelectionController::modify):
3417         (WebCore::SelectionController::setBase):
3418         (WebCore::SelectionController::setExtent):
3419         * editing/SelectionController.h:
3420         * page/Frame.cpp:
3421         (WebCore::Frame::revealSelection):
3422         (WebCore::Frame::revealCaret):
3423         * page/Frame.h:
3424
3425 2006-09-15  Brady Eidson  <beidson@apple.com>
3426
3427         Reviewed by Anders
3428
3429         Added the ability to get a mutable char* from a CString, which will copy the internal
3430         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
3431         referrer of that buffer.
3432
3433         * platform/CString.cpp:
3434         (WebCore::CString::mutableData):
3435         (WebCore::CString::copyBufferIfNeeded):
3436         * platform/CString.h:
3437
3438 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
3439
3440         Reviewed by harrison
3441
3442         <rdar://problem/4674869>
3443         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
3444
3445         * editing/SelectionController.cpp:
3446         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
3447         * editing/visible_units.cpp:
3448         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
3449         position before it, not after it.
3450
3451 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3452
3453         Reviewed by Adam.
3454
3455         http://bugs.webkit.org/show_bug.cgi?id=10864
3456         Bug 10864: Linux\GDK build fixes
3457
3458         * Projects/gdk/webcore-gdk.bkl:
3459         * WebCoreSources.bkl:
3460         * platform/gdk/FontCacheGdk.cpp:
3461         * platform/gdk/FontDataGdk.cpp:
3462         (WebCore::FontData::platformInit):
3463         * platform/gdk/FontGdk.cpp:
3464         (WebCore::Font::drawGlyphs):
3465         * platform/gdk/FrameGdk.cpp:
3466         (WebCore::FrameGdk::handleGdkEvent):
3467         * platform/gdk/FrameGdk.h:
3468         * platform/gdk/ImageGdk.cpp: Added.
3469         (WebCore::Image::initPlatformData):
3470         (WebCore::Image::invalidatePlatformData):
3471         (WebCore::Image::loadPlatformResource):
3472         (WebCore::Image::supportsType):
3473         * platform/gdk/RenderPopupMenuGdk.cpp:
3474         (WebCore::RenderPopupMenuGdk::hidePopup):
3475         * platform/gdk/RenderPopupMenuGdk.h:
3476         * platform/gdk/ScreenGdk.cpp:
3477         (WebCore::drawableForPage):
3478         (WebCore::screenRect):
3479         (WebCore::screenDepth):
3480         (WebCore::usableScreenRect):
3481         (WebCore::scaleFactor):
3482         * platform/gdk/SystemTimeLinux.cpp:
3483         (WebCore::currentTime):
3484         * platform/gdk/TemporaryLinkStubs.cpp:
3485         (FrameGdk::bindingRootObject):
3486         (FrameGdk::markMisspellings):
3487         (WebCore::screenDepthPerComponent):
3488         (WebCore::screenIsMonochrome):
3489         (WebCore::fileButtonChooseFileLabel):
3490         (WebCore::fileButtonNoFileSelectedLabel):
3491         (FrameGdk::shouldChangeSelection):
3492         (FrameGdk::respondToChangedSelection):
3493         (FrameGdk::respondToChangedContents):
3494         (Path::contains):
3495         (PlatformScrollBar::PlatformScrollBar):
3496         (PlatformScrollBar::~PlatformScrollBar):
3497         (PlatformScrollBar::width):
3498         (PlatformScrollBar::height):
3499         (PlatformScrollBar::setEnabled):
3500         (PlatformScrollBar::paint):
3501         (PlatformScrollBar::setScrollBarValue):
3502         (PlatformScrollBar::setKnobProportion):
3503         (PlatformScrollBar::setRect):
3504         (ScrollBar::ScrollBar):
3505         (FileChooser::FileChooser):
3506         (FileChooser::~FileChooser):
3507         (FileChooser::openFileChooser):
3508         (FileChooser::basenameForWidth):
3509         (FileChooser::uploadControlDetaching):
3510         (FileChooser::chooseFile):
3511         (Icon::Icon):
3512         (Icon::~Icon):
3513         (Icon::newIconForFile):
3514         (Icon::paint):
3515         (IconLoader::stopLoading):
3516         (IconLoader::startLoading):
3517         (IconLoader::createForFrame):
3518         (IconDatabase::isIconExpiredForIconURL):
3519         (IconDatabase::hasEntryForIconURL):
3520         (IconDatabase::sharedIconDatabase):
3521         * platform/gdk/WidgetGdk.cpp:
3522         * webcore-base.bkl:
3523
3524 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3525
3526         Reviewed by Eric.
3527
3528         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10835
3529         Fix svg memory leaks.
3530
3531         Reworked SVGList to deal with RefPtr's for ptr types
3532         which makes manual refcounting unnecessary, and is much safer.
3533
3534         Removing all virtual functions (nullItem) from SVGList, and
3535         also remove SVGListBase. Switch to a similar concept like
3536         Vector/VectorTraits (see new file SVGListTraits.h).
3537
3538         Credits go to Eric/Maciej for the inspiration.
3539
3540         * CMakeLists.txt: Add SVGListTraits.cpp to build
3541         * WebCore.xcodeproj/project.pbxproj: Ditto.
3542         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
3543         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
3544         (WebCore::RenderSVGText::translationForAttributes):
3545         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
3546         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3547         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
3548         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
3549         * ksvg2/svg/SVGElementInstanceList.h:
3550         * ksvg2/svg/SVGLengthList.cpp: Ditto.
3551         (WebCore::SVGLengthList::SVGLengthList):
3552         * ksvg2/svg/SVGLengthList.h: Ditto.
3553         * ksvg2/svg/SVGList.h: Rewrote, as described above.
3554         (WebCore::SVGListTypeOperations::nullItem):
3555         (WebCore::SVGList::SVGList):
3556         (WebCore::SVGList::~SVGList):
3557         (WebCore::SVGList::clear):
3558         (WebCore::SVGList::getFirst):
3559         (WebCore::SVGList::getLast):
3560         (WebCore::SVGList::getItem):
3561         (WebCore::SVGList::replaceItem):
3562         (WebCore::SVGList::removeItem):
3563         * ksvg2/svg/SVGListTraits.cpp: Added.
3564         * ksvg2/svg/SVGListTraits.h: Added.
3565         (WebCore::):
3566         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
3567         (WebCore::SVGPathElement::toPathData):
3568         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
3569         (WebCore::SVGPathSegList::SVGPathSegList):
3570         * ksvg2/svg/SVGPathSegList.h: Ditto.
3571         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
3572         (SVGTransform::SVGTransform):
3573         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
3574         (SVGTransformList::SVGTransformList):
3575         (SVGTransformList::createSVGTransformFromMatrix):
3576         (SVGTransformList::consolidate):
3577         * ksvg2/svg/SVGTransformList.h: Ditto.
3578         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
3579         (SVGTransformable::parseTransformAttribute):
3580
3581 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3582
3583         Reviewed by eseidel.  Landed by eseidel.
3584
3585         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
3586         be able to see javascript errors for instance.
3587
3588         * CMakeLists.txt:
3589         * platform/qt/FrameQt.h:
3590         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
3591         (WebCore::FrameQt::bindingRootObject):
3592         * platform/qt/TemporaryLinkStubs.cp
3593         (WebCore::IconDatabase::hasEntryForIconURL):
3594         (WebCore::IconDatabase::sharedIconDatabase):
3595
3596 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3597
3598         Reviewed by Tim H.
3599
3600         Patch for http://bugs.webkit.org/show_bug.cgi?id=10869
3601         Auto-generate the internal methods for the Objective-C bindings
3602
3603         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
3604           implementations where standard.  For cases where a custom implementation was
3605           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
3606
3607         - Some general cleanup of some of the non-generated bindings, to bring them in-
3608           line with what the generated bindings look like.
3609
3610         * bindings/objc/DOM.mm:
3611         (-[DOMNode description]):
3612         * bindings/objc/DOMCSS.mm:
3613         (-[DOMCSSPrimitiveValue WebCore::]):
3614         (-[DOMDocument getComputedStyle::]):
3615         (-[DOMDocument getMatchedCSSRules::]):
3616         * bindings/objc/DOMEvents.mm:
3617         (-[DOMEvent WebCore::]):
3618         * bindings/objc/DOMHTML.mm:
3619         * bindings/objc/DOMHTMLDocument.mm:
3620         (-[DOMHTMLDocument title]):
3621         (-[DOMHTMLDocument setTitle:]):
3622         (-[DOMHTMLDocument referrer]):
3623         (-[DOMHTMLDocument domain]):
3624         (-[DOMHTMLDocument URL]):
3625         (-[DOMHTMLDocument body]):
3626         (-[DOMHTMLDocument setBody:]):
3627         (-[DOMHTMLDocument images]):
3628         (-[DOMHTMLDocument applets]):
3629         (-[DOMHTMLDocument links]):
3630         (-[DOMHTMLDocument forms]):
3631         (-[DOMHTMLDocument anchors]):
3632         (-[DOMHTMLDocument cookie]):
3633         (-[DOMHTMLDocument setCookie:]):
3634         (-[DOMHTMLDocument open]):
3635         (-[DOMHTMLDocument close]):
3636         (-[DOMHTMLDocument write:]):
3637         (-[DOMHTMLDocument writeln:]):
3638         (-[DOMHTMLDocument getElementById:]):
3639         (-[DOMHTMLDocument getElementsByName:]):
3640         (-[DOMHTMLDocument WebCore::]):
3641         (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
3642         * bindings/objc/DOMHTMLOptionElement.mm:
3643         (-[DOMHTMLOptionElement form]):
3644         (-[DOMHTMLOptionElement defaultSelected]):
3645         (-[DOMHTMLOptionElement setDefaultSelected:]):
3646         (-[DOMHTMLOptionElement text]):
3647         (-[DOMHTMLOptionElement index]):
3648         (-[DOMHTMLOptionElement disabled]):
3649         (-[DOMHTMLOptionElement setDisabled:]):
3650         (-[DOMHTMLOptionElement label]):
3651         (-[DOMHTMLOptionElement setLabel:]):
3652         (-[DOMHTMLOptionElement selected]):
3653         (-[DOMHTMLOptionElement setSelected:]):
3654         (-[DOMHTMLOptionElement value]):
3655         (-[DOMHTMLOptionElement setValue:]):
3656         (-[DOMHTMLOptionElement WebCore::]):
3657         (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
3658         * bindings/objc/DOMInternal.h:
3659         * bindings/objc/DOMNode.mm:
3660         (-[DOMNode dealloc]):
3661         (-[DOMNode finalize]):
3662         (-[DOMNode nodeName]):
3663         (-[DOMNode nodeValue]):
3664         (-[DOMNode setNodeValue:]):
3665         (-[DOMNode nodeType]):
3666         (-[DOMNode parentNode]):
3667         (-[DOMNode childNodes]):
3668         (-[DOMNode firstChild]):
3669         (-[DOMNode lastChild]):
3670         (-[DOMNode previousSibling]):
3671         (-[DOMNode nextSibling]):
3672         (-[DOMNode attributes]):
3673         (-[DOMNode ownerDocument]):
3674         (-[DOMNode insertBefore::]):
3675         (-[DOMNode replaceChild::]):
3676         (-[DOMNode removeChild:]):
3677         (-[DOMNode appendChild:]):
3678         (-[DOMNode hasChildNodes]):
3679         (-[DOMNode cloneNode:]):
3680         (-[DOMNode normalize]):
3681         (-[DOMNode isSupported::]):
3682         (-[DOMNode namespaceURI]):
3683         (-[DOMNode prefix]):
3684         (-[DOMNode setPrefix:]):
3685         (-[DOMNode localName]):
3686         (-[DOMNode hasAttributes]):
3687         (-[DOMNode isSameNode:]):
3688         (-[DOMNode isEqualNode:]):
3689         (-[DOMNode isDefaultNamespace:]):
3690         (-[DOMNode lookupPrefix:]):
3691         (-[DOMNode lookupNamespaceURI:]):
3692         (-[DOMNode textContent]):
3693         (-[DOMNode setTextContent:]):
3694         (-[DOMNode boundingBox]):
3695         (-[DOMNode lineBoxRects]):
3696         * bindings/objc/DOMObject.mm:
3697         (-[DOMObject _init]):
3698         * bindings/objc/DOMXPath.mm:
3699         (-[DOMNativeXPathNSResolver dealloc]):
3700         (-[DOMNativeXPathNSResolver finalize]):
3701         (-[DOMNativeXPathNSResolver WebCore::]):
3702         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
3703         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
3704         (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
3705         * bindings/scripts/CodeGeneratorObjC.pm:
3706         * bridge/mac/WebCoreFrameBridge.mm:
3707         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3708         (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
3709         * css/CSSCharsetRule.idl:
3710         * css/CSSFontFaceRule.idl:
3711         * css/CSSImportRule.idl:
3712         * css/CSSMediaRule.idl:
3713         * css/CSSPageRule.idl:
3714         * css/CSSPrimitiveValue.idl:
3715         * css/CSSRule.idl:
3716         * css/CSSStyleRule.idl:
3717         * css/CSSStyleSheet.idl:
3718         * css/CSSUnknownRule.idl:
3719         * css/CSSValue.idl:
3720         * css/CSSValueList.idl:
3721         * css/StyleSheet.idl:
3722         * dom/Event.idl:
3723         * dom/KeyboardEvent.idl:
3724         * dom/MouseEvent.idl:
3725         * dom/MutationEvent.idl:
3726         * dom/NodeIterator.idl:
3727         * dom/OverflowEvent.idl:
3728         * dom/TreeWalker.idl:
3729         * dom/UIEvent.idl:
3730         * dom/WheelEvent.idl:
3731
3732 2006-09-15  Adam Roben  <aroben@apple.com>
3733
3734         Reviewed by timothy.
3735
3736         Fixes http://bugs.webkit.org/show_bug.cgi?id=10865
3737         New file upload control should match the width of the old one
3738
3739         Make width of new file upload control match the old one as closely as
3740         possible.
3741
3742         * rendering/RenderFileUploadControl.cpp:
3743
3744 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3745
3746         Reviewed by Eric.
3747
3748         Remove the SVG IDL files from the Copy Resources phase.
3749
3750         * WebCore.xcodeproj/project.pbxproj:
3751
3752 2006-09-15  Brady Eidson  <beidson@apple.com>
3753
3754         Reviewed by Eric Siedel
3755
3756         Dumped the use of CGColorRef and directly use the floating point data from
3757         WebCore::Color
3758
3759         This fixes the performance regression found between 16285 and 16286
3760
3761         * platform/mac/FontMac.mm:
3762         (WebCore::Font::drawComplexText):
3763         (WebCore::Font::drawGlyphs):
3764
3765 2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>
3766
3767         Reviewed by Adam.
3768
3769         http://bugs.webkit.org/show_bug.cgi?id=10838
3770         Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
3771
3772         FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
3773         Frame::cleanupPluginObjects method is called from Frame's destructor, which results
3774         in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
3775
3776         * bridge/mac/FrameMac.mm:
3777         (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
3778         will be called from Frame::clear
3779         * page/Frame.cpp:
3780         (WebCore::Frame::~Frame): Use cancelAndClear.
3781         (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
3782         FrameMac can use.
3783         * page/Frame.h:
3784
3785 2006-09-14  Brady Eidson  <beidson@apple.com>
3786
3787         Reviewed by Maciej's rubber stamp
3788
3789         Exact same fix I just made, but in the other method I horked up
3790         Also added a reference to the bugzilla in comments
3791
3792         * page/Frame.cpp:
3793         (WebCore::Frame::endIfNotLoading):
3794         (WebCore::Frame::stop):
3795
3796 2006-09-14  Brady Eidson  <beidson@apple.com>
3797
3798         Reviewed by Maciej
3799
3800         Fixed a bad iFrame crash, resolving some of the layout test badness
3801
3802         * page/Frame.cpp:
3803         (WebCore::Frame::endIfNotLoading):
3804         - Added a RefPtr to protect the frame itself to prevent its destruction during this method
3805
3806 2006-09-14  Justin Garcia  <justin.garcia@apple.com>
3807
3808         Reviewed by harrison
3809
3810         <rdar://problem/4655880> Up/Down arrows skip over To Do
3811
3812         * bridge/mac/WebCoreFrameBridge.mm:
3813         (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
3814         * dom/Node.cpp: Removed the unused inSameRootEditableElement.
3815         * dom/Node.h:
3816         * editing/SelectionController.cpp:
3817         (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
3818         * editing/visible_units.cpp:
3819         (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
3820         editable content into editable content that's embedded in non-editable content.
3821         (WebCore::nextLinePosition): Ditto.
3822         (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
3823         This is the behavior that callers desire.  This fixes Command + Up/Down.
3824         (WebCore::endOfEditableContent): Ditto.
3825         * editing/visible_units.h:
3826
3827 2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>
3828
3829         Reviewed by timothy. Landed by aroben.
3830
3831         Fixes http://bugs.webkit.org/show_bug.cgi?id=10856
3832         Windows build fixes after r16360
3833
3834         * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
3835         AdditionalIncludeDirectories
3836         * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
3837         IconDatabase
3838         (IconLoader::stopLoading):
3839         (IconLoader::startLoading):
3840         (IconLoader::createForFrame):
3841         (IconDatabase::isIconExpiredForIconURL):
3842         (IconDatabase::hasEntryForIconURL):
3843         (IconDatabase::sharedIconDatabase):
3844
3845 2006-09-14  Brady Eidson  <beidson@apple.com>
3846
3847         Part of a build fix for Windows - rest will be working out a mess of temporary link stubs
3848
3849         * loader/icon/IconLoader.cpp:
3850         (IconLoader::receivedAllData):
3851         * page/Frame.cpp:
3852         * page/FramePrivate.h:
3853
3854 2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
3855
3856         Reviewed by Justin Garcia.
3857
3858         - http://bugs.webkit.org/show_bug.cgi?id=10726
3859           Crash in ApplyStyleCommand::applyRelativeFontStyleChange
3860
3861         * editing/ApplyStyleCommand.cpp:
3862         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
3863         makeing sure that the 'beyondEnd' node is after the start node.
3864
3865 2006-09-14  MorganL  <morlmor@yahoo.com>
3866
3867         Reviewed by Brady.
3868
3869         Fixes http://bugs.webkit.org/show_bug.cgi?id=10845
3870         Various bugs/crashes in ResourceLoaderWin with local files.
3871
3872         * platform/ResourceLoaderInternal.h:
3873         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3874         * platform/win/ResourceLoaderWin.cpp:
3875         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
3876         (WebCore::ResourceLoader::fileLoadTimer):
3877
3878 2006-09-13  Brady Eidson <beidson@apple.com>
3879
3880         Reviewed by Maciej
3881
3882         Icon loads now take place in WebCore
3883
3884         * WebCore.xcodeproj/project.pbxproj:
3885         * bridge/BrowserExtension.h:
3886         * bridge/mac/BrowserExtensionMac.h:
3887         * bridge/mac/BrowserExtensionMac.mm:
3888         - Moved enforcement of a Mozilla Favicon extension elsewhere
3889
3890         * bridge/mac/FrameMac.h:
3891         * bridge/mac/FrameMac.mm:
3892         (WebCore::FrameMac::originalRequestURL):
3893         - Added accessor to "original request URL"
3894
3895         * bridge/mac/WebCoreFrameBridge.h:
3896         - Removed methods to set the iconURL as all loading is now done in WebCore
3897         - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
3898
3899         * html/HTMLLinkElement.cpp:
3900         (WebCore::HTMLLinkElement::process):
3901         - Moved enforcement of a Mozilla Favicon extension elsewhere
3902
3903         * loader/icon/IconDatabase.cpp:
3904         (WebCore::IconDatabase::setIconURLForPageURL):
3905         - Changed an ASSERT to correctly handle a sketchy (invalid) situation
3906
3907         * loader/icon/IconLoader.h: Added.
3908         * loader/icon/IconLoader.cpp: Added.
3909         (IconLoader::IconLoader):
3910         (IconLoader::createForFrame):
3911         - Static factory method with a private constructor to enforce
3912           "you MUST have a Frame to create an IconLoader" semantics
3913         (IconLoader::~IconLoader):
3914         (IconLoader::startLoading):
3915         (IconLoader::stopLoading):
3916         (IconLoader::receivedData):
3917         - ResourceLoaderClient delegate
3918         (IconLoader::receivedAllData):
3919         - Ditto
3920
3921         * loader/mac/IconLoaderMac.mm: Added.
3922         (IconLoader::receivedResponse):
3923         (IconLoader::notifyIconChanged):
3924         - For now, these are platform specific methods
3925         - One to get the HTTP response code of an icon load
3926         - The other to call through to the app when the icon has changed (loaded)
3927
3928         * page/Frame.h:
3929         * page/Frame.cpp:
3930         (WebCore::Frame::iconURL):
3931         (WebCore::Frame::setIconURL):
3932         - Frame objects now have an inherent icon URL and a way to calculate/access it
3933         (WebCore::Frame::endIfNotLoading):
3934         - This is where we actually kick off the IconLoader
3935         (WebCore::Frame::stop):
3936         - Added call to stop loading the icon
3937
3938         * page/FramePrivate.h:
3939         (WebCore::FramePrivate::FramePrivate):
3940         (WebCore::FramePrivate::~FramePrivate):
3941         - Added the icon URL as a private member
3942         - Added the IconLoader as a private member, and clean it up on deletion
3943
3944         * platform/mac/ResourceLoaderMac.mm:
3945         (WebCore::ResourceLoader::start):  Added a valuable ASSERT
3946
3947 2006-09-13  David Hyatt  <hyatt@apple.com>
3948
3949         Fix for 10841, unable to check checkboxes inside labels.
3950
3951         Reviewed by xenon, bradee-oh
3952
3953         * css/html4.css:
3954         * dom/Element.cpp:
3955         (WebCore::Element::contains):
3956         * dom/Element.h:
3957         * html/HTMLLabelElement.cpp:
3958         (WebCore::HTMLLabelElement::defaultEventHandler):
3959
3960 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3961
3962         Reviewed by Adam.
3963
3964         http://bugs.webkit.org/show_bug.cgi?id=10834
3965         Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
3966
3967         * platform/mac/FileChooserMac.mm:
3968         (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
3969
3970 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
3971
3972         Reviewed by Eric.
3973
3974         http://bugs.webkit.org/show_bug.cgi?id=10836
3975         Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
3976
3977         * platform/mac/FontMac.mm:
3978         (WebCore::Font::drawComplexText): Release CGColorRef after use.
3979         (WebCore::Font::drawGlyphs): Ditto.
3980
3981 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3982
3983         Try fixing the Win32 build.
3984
3985         * bridge/win/FrameWin.h:
3986         * platform/win/TemporaryLinkStubs.cpp:
3987         (FrameWin::bindingRootObject):
3988
3989 2006-09-14  Anders Carlsson  <acarlsson@apple.com>
3990
3991         Reviewed by Tim O.
3992
3993         Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
3994
3995         * bindings/js/kjs_binding.cpp:
3996         (KJS::ScriptInterpreter::createLanguageInstanceForValue):
3997         * bindings/js/kjs_dom.cpp:
3998         (KJS::getRuntimeObject):
3999         * bridge/mac/FrameMac.h:
4000         * config.h:
4001         * html/HTMLAppletElement.cpp:
4002         (WebCore::HTMLAppletElement::~HTMLAppletElement):
4003         (WebCore::HTMLAppletElement::detach):
4004         * html/HTMLAppletElement.h:
4005         * html/HTMLEmbedElement.cpp:
4006         (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
4007         (WebCore::HTMLEmbedElement::detach):
4008         * html/HTMLEmbedElement.h:
4009         * html/HTMLObjectElement.cpp:
4010         (WebCore::HTMLObjectElement::~HTMLObjectElement):
4011         (WebCore::HTMLObjectElement::detach):
4012         * html/HTMLObjectElement.h:
4013         * html/HTMLPlugInElement.cpp:
4014         (WebCore::HTMLPlugInElement::HTMLPlugInElement):
4015         (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
4016         (WebCore::HTMLPlugInElement::createNPObject):
4017         * html/HTMLPlugInElement.h:
4018         * page/Frame.h:
4019
4020 2006-09-13  David Hyatt  <hyatt@apple.com>
4021
4022         Clean up the XBL and XSLT ifdefs to be consistent with the SVG
4023         and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
4024         KHTML_XSLT is now XSLT_SUPPORT.
4025
4026         * WebCore.xcodeproj/project.pbxproj:
4027         * bindings/js/JSXSLTProcessor.cpp:
4028         * bindings/js/JSXSLTProcessor.h:
4029         * bindings/js/kjs_window.cpp:
4030         (KJS::Window::getValueProperty):
4031         * config.h:
4032         * css/CSSComputedStyleDeclaration.cpp:
4033         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
4034         * css/cssparser.cpp:
4035         (WebCore::CSSParser::parseValue):
4036         * css/cssstyleselector.cpp:
4037         (WebCore::CSSStyleSelector::applyProperty):
4038         * dom/Document.cpp:
4039         (WebCore::Document::Document):
4040         (WebCore::Document::~Document):
4041         (WebCore::Document::recalcStyleSelector):
4042         * dom/Document.h:
4043         (WebCore::Document::bindingManager):
4044         * dom/Node.cpp:
4045         (WebCore::Node::createRendererIfNeeded):
4046         * dom/ProcessingInstruction.cpp:
4047         (WebCore::ProcessingInstruction::ProcessingInstruction):
4048         (WebCore::ProcessingInstruction::checkStyleSheet):
4049         (WebCore::ProcessingInstruction::setStyleSheet):
4050         * dom/ProcessingInstruction.h:
4051         * dom/XMLTokenizer.cpp:
4052         (WebCore::XMLTokenizer::processingInstruction):
4053         (WebCore::XMLTokenizer::insertErrorMessageBlock):
4054         * dom/XMLTokenizer.h:
4055         * loader/Cache.cpp:
4056         (WebCore::Cache::getStatistics):
4057         * loader/Cache.h:
4058         * loader/CachedResource.h:
4059         (WebCore::CachedResource::):
4060         * loader/CachedResourceClient.h:
4061         * loader/CachedXBLDocument.cpp:
4062         * loader/CachedXBLDocument.h:
4063         * loader/CachedXSLStyleSheet.cpp:
4064         * loader/CachedXSLStyleSheet.h:
4065         * loader/DocLoader.cpp:
4066         * loader/DocLoader.h:
4067         * rendering/RenderStyle.cpp:
4068         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
4069         (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
4070         (WebCore::StyleCSS3NonInheritedData::operator==):
4071         * rendering/RenderStyle.h:
4072         * xml/XSLImportRule.cpp:
4073         * xml/XSLImportRule.h:
4074         * xml/XSLStyleSheet.cpp:
4075         * xml/XSLStyleSheet.h:
4076         * xml/XSLTProcessor.cpp:
4077         * xml/XSLTProcessor.h:
4078
4079 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
4080
4081         Reviewed by eseidel.  Landed by eseidel.
4082
4083         Fix newly introduced memory leaks in SVG.
4084         http://bugs.webkit.org/show_bug.cgi?id=10835
4085
4086         * ksvg2/svg/SVGList.h:
4087         (WebCore::SVGListBase::~SVGListBase):
4088         (WebCore::SVGListBase::clearVector):
4089         (WebCore::SVGListBase::clear):
4090         (WebCore::SVGList::clearVector):
4091         (WebCore::):
4092         * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
4093         (SVGNumberList::SVGNumberList):
4094         * ksvg2/svg/SVGNumberList.h: Ditto.
4095
4096 2006-09-13  MorganL  <morlmor@yahoo.com>
4097
4098         Reviewed/landed by aroben.
4099
4100         Fixes http://bugs.webkit.org/show_bug.cgi?id=10833
4101         Windows build needs fixed after move to engine-rendered file upload widget
4102
4103         * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
4104         remove RenderFileButton files
4105         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
4106         (FileChooser::FileChooser):
4107         (FileChooser::~FileChooser):
4108         (FileChooser::openFileChooser):
4109         (FileChooser::basenameForWidth):
4110         (FileChooser::uploadControlDetaching):
4111         (FileChooser::chooseFile):
4112         (WebCore::fileButtonChooseFileLabel):
4113         (WebCore::fileButtonNoFileSelectedLabel):
4114         (Icon::Icon):
4115         (Icon::~Icon):
4116         (Icon::newIconForFile):
4117         (Icon::paint):
4118
4119 2006-09-13  MorganL  <morlmor@yahoo.com>
4120
4121         Reviewed/landed by aroben.
4122
4123         Fixes http://bugs.webkit.org/attachment.cgi?id=10537
4124         Webkit WebCore build fails on Windows
4125
4126         * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
4127         variable
4128
4129 2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
4130
4131         Reviewed by Tim H.
4132
4133         Fix Qt/Linux build.
4134
4135         * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
4136         * platform/Icon.h: Add wtf/Platform.h include
4137         * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
4138         (WebCore::FileChooser::FileChooser):
4139         (WebCore::FileChooser::~FileChooser):
4140         (WebCore::FileChooser::openFileChooser):
4141         (WebCore::FileChooser::basenameForWidth):
4142         (WebCore::FileChooser::uploadControlDetaching):
4143         (WebCore::FileChooser::chooseFile):
4144         * platform/qt/IconQt.cpp: Added as stub.
4145         (WebCore::Icon::Icon):
4146         (WebCore::Icon::~Icon):
4147         (WebCore::Icon::newIconForFile):
4148         (WebCore::Icon::paint):
4149         * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
4150         (searchableIndexIntroduction):
4151         (fileButtonChooseFileLabel):
4152         (fileButtonNoFileSelectedLabel):
4153
4154 2006-09-12  Adam Roben  <aroben@apple.com>
4155
4156         Reviewed by eseidel.
4157
4158         Switch back to passing relative paths to generate-bindings.pl when
4159         generating JS bindings.
4160
4161         * DerivedSources.make: Pass in relative paths to generate-bindings.pl
4162         * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
4163         chdir and always construct absolute paths instead.
4164
4165 2006-09-12  David Hyatt  <hyatt@apple.com>
4166
4167         Fix for bug 3244, implement html4 label support.
4168
4169         Reviewed by mjs, aroben
4170
4171         Added fast/events/label-focus.html
4172
4173         * css/html4.css:
4174         * html/HTMLLabelElement.cpp:
4175         (WebCore::HTMLLabelElement::formElement):
4176         (WebCore::HTMLLabelElement::setActive):
4177         (WebCore::HTMLLabelElement::setHovered):
4178         (WebCore::HTMLLabelElement::defaultEventHandler):
4179         * html/HTMLLabelElement.h:
4180
4181 2006-09-12  Julien Palmas  <julien.palmas@gmail.com>
4182
4183         Reviewed by darin.  Landed by eseidel.
4184
4185         * ksvg2/svg/svgpathparser.cpp:
4186         (WebCore::SVGPolyParser::parsePoints):
4187
4188 2006-09-11  Kevin McCullough  <KMcCullough@apple.com>
4189
4190         Reviewed by Andersca, Maciej, Brady.
4191
4192         - Implemented intersectsNode in the Range Class
4193           to be compliant with Mozilla standard
4194
4195         * dom/Range.cpp:
4196         (WebCore::Range::intersectsNode):
4197         * dom/Range.h:
4198         * dom/Range.idl:
4199
4200 2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>
4201
4202         Reviewed by eseidel.  Landed by eseidel.
4203
4204         Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
4205         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10826
4206
4207         Also finally fixes some long outstanding bugs:
4208         Fixes: http://bugs.webkit.org/show_bug.cgi?id=9190
4209         Fixes: http://bugs.webkit.org/show_bug.cgi?id=9229
4210         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10413
4211
4212         Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.
4213
4214         * CMakeLists.txt:
4215         * DerivedSources.make:
4216         * WebCore.xcodeproj/project.pbxproj:
4217         * bindings/scripts/CodeGenerator.pm:
4218         * bindings/scripts/CodeGeneratorJS.pm:
4219         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
4220         * ksvg2/svg/SVGAElement.idl: Added.
4221         * ksvg2/svg/SVGAngle.idl:
4222         * ksvg2/svg/SVGAnimateColorElement.idl: Added.
4223         * ksvg2/svg/SVGAnimateElement.idl: Added.
4224         * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
4225         * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
4226         * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
4227         * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
4228         * ksvg2/svg/SVGAnimationElement.idl: Added.
4229         * ksvg2/svg/SVGCircleElement.idl: Added.
4230         * ksvg2/svg/SVGClipPathElement.idl: Added.
4231         * ksvg2/svg/SVGColor.idl:
4232         * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
4233         * ksvg2/svg/SVGCursorElement.idl: Added.
4234         * ksvg2/svg/SVGDefsElement.idl: Added.
4235         * ksvg2/svg/SVGDescElement.idl: Added.
4236         * ksvg2/svg/SVGEllipseElement.idl: Added.
4237         * ksvg2/svg/SVGEvent.idl:
4238         * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
4239         * ksvg2/svg/SVGFEBlendElement.idl: Added.
4240         * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
4241         * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
4242         * ksvg2/svg/SVGFECompositeElement.idl: Added.
4243         * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
4244         * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
4245         * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
4246         * ksvg2/svg/SVGFEFloodElement.idl: Added.
4247         * ksvg2/svg/SVGFEFuncAElement.idl: Added.
4248         * ksvg2/svg/SVGFEFuncBElement.idl: Added.
4249         * ksvg2/svg/SVGFEFuncGElement.idl: Added.
4250         * ksvg2/svg/SVGFEFuncRElement.idl: Added.
4251         * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
4252         * ksvg2/svg/SVGFEImageElement.idl: Added.
4253         * ksvg2/svg/SVGFEMergeElement.idl: Added.
4254         * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
4255         * ksvg2/svg/SVGFEOffsetElement.idl: Added.
4256         * ksvg2/svg/SVGFEPointLightElement.idl: Added.
4257         * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
4258         * ksvg2/svg/SVGFESpotLightElement.idl: Added.
4259         * ksvg2/svg/SVGFETileElement.idl: Added.
4260         * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
4261         * ksvg2/svg/SVGFilterElement.idl: Added.
4262         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
4263         * ksvg2/svg/SVGFitToViewBox.idl: Added.
4264         * ksvg2/svg/SVGForeignObjectElement.idl: Added.
4265         * ksvg2/svg/SVGGElement.idl: Added.
4266         * ksvg2/svg/SVGGradientElement.idl: Added.
4267         * ksvg2/svg/SVGImageElement.idl: Added.
4268         * ksvg2/svg/SVGLangSpace.idl: Added.